Add `do_sample`attr to generation_config

#10
by johnucm - opened

Since temperature, top_k etc are listed in this file, the do_sample = true should also be added. The default value for do_sample is false for transformers. Otherwise GenerationConfig.save_pretrained() will raise error, e.g.:

  File "/opt/conda/envs/py310/lib/python3.10/site-packages/transformers/generation/configuration_utils.py", line 837, in save_pretrained
    raise ValueError(str(exc) + "\n\nFix these issues to save the configuration.")
ValueError: GenerationConfig is invalid:
- `temperature`: `do_sample` is set to `False`. However, `temperature` is set to `0.6` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `temperature`.
- `top_p`: `do_sample` is set to `False`. However, `top_p` is set to `0.95` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `top_p`.
- `min_p`: `do_sample` is set to `False`. However, `min_p` is set to `0.0` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `min_p`.
- `top_k`: `do_sample` is set to `False`. However, `top_k` is set to `20` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `top_k`.
If you're using a pretrained model, note that some of these attributes may be set through the model's `generation_config.json` file.

Fix these issues to save the configuration.
johnucm changed pull request title from Add `do_sample`attr in generation_config to Add `do_sample`attr to generation_config

Make sense, approved

alandao changed pull request status to merged

Sign up or log in to comment