var Packet = require('../packets/packet');

// creating JS string is relatively expencive (compared to
// reading few bytes from buffer) because all string properties
// except for name are unlikely to be used we postpone
// string conversion until property access
function ColumnDefinition(packet)
{
  this._buf     = packet.buffer;

  this._catalogLength = packet.readLengthCodedNumber();
  this._catalogStart  = packet.offset;
  packet.offset += this._catalogLength;

  this._schemaLength = packet.readLengthCodedNumber();
  this._schemaStart  = packet.offset;
  packet.offset += this._schemaLength;

  this._tableLength = packet.readLengthCodedNumber();
  this._tableStart  = packet.offset;
  packet.offset += this._tableLength;

  this._orgTableLength = packet.readLengthCodedNumber();
  this._orgTableStart  = packet.offset;
  packet.offset += this._orgTableLength;

  // name is always used, don't make it lazy
  this.name     = packet.readLengthCodedString();

  this._orgNameLength = packet.readLengthCodedNumber();
  this._orgNameStart  = packet.offset;
  packet.offset += this._orgNameLength;

  packet.skip(1); //  length of the following fields (always 0x0c)
  this.characterSet = packet.readInt16();
  this.columnLength = packet.readInt32();
  this.columnType   = packet.readInt8();
  this.flags        = packet.readInt16();
  this.decimals     = packet.readInt8();
}

var addString = function(name) {
  Object.defineProperty(ColumnDefinition.prototype, name, { get: function() {
    var start = this['_' + name + 'Start'];
    var end = start + this['_' + name + 'Length'];
    return this._buf.utf8Slice(start, end);
  }});
};

addString('catalog');
addString('schema');
addString('table');
addString('orgTable');
addString('orgName');

ColumnDefinition.prototype.inspect = function() {
  return {
    catalog      : this.catalog,
    schema      : this.schema,
    name        : this.name,
    orgName     : this.orgName,
    table       : this.table,
    orgTable    : this.orgTable,
    characterSet: this.characterSet,
    columnLength: this.columnLength,
    columnType  : this.columnType,
    flags       : this.flags,
    decimals    : this.decimals
  };
};

ColumnDefinition.toPacket = function(column, sequenceId)
{
  var length = 0;
  var fields = 'catalog schema table orgTable name orgName'.split(' ');
  function addFieldLength(name) {
    var str = column[name];
    length +=Packet.lengthCodedNumberLength(str);
    length += str.length;
  }
  fields.forEach(addFieldLength);
  length += 13;
  var buffer = new Buffer(length);
  function writeField(name) {
    packet.writeLengthCodedString(column[name]);
  }
  var packet = new Packet(sequenceId, buffer);
  packet.offset = 4;
  fields.forEach(writeField);
  packet.writeInt8 (0x0c);
  packet.writeInt16(column.characterSet);
  packet.writeInt32(column.columnLength);
  packet.writeInt8 (column.columnType);
  packet.writeInt16(column.flags);
  packet.writeInt8 (column.decimals);
  return packet;
};

module.exports = ColumnDefinition;

@@ -258,16 +258,440 @@
  access%0A
+//%0A// TODO: watch for integration benchmarks (one with real network buffer)%0A// there could be bad side effect as keeping reference to a buffer makes it%0A// sit in the memory longer (usually until final .query() callback)%0A// Latest v8 perform much better in regard to bugger -%3E string convertion,%0A// at some poinyt of time this optimisation might become unnecessary%0A// see https://github.com/sidorares/node-mysql2/pull/137%0A//%0A
 function

add comment on hacky optimisation