/*
 * The Alluxio Open Foundation licenses this work under the Apache License, version 2.0
 * (the "License"). You may not use this work except in compliance with the License, which is
 * available at www.apache.org/licenses/LICENSE-2.0
 *
 * This software is distributed on an "AS IS" basis, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
 * either express or implied, as more fully set forth in the License.
 *
 * See the NOTICE file distributed with this work for information regarding copyright ownership.
 */

package alluxio.master.journal;

import alluxio.util.io.PathUtils;

/**
 * Interface for factories which create {@link Journal}s.
 */
public interface JournalFactory {
  /**
   * @param directory the directory for the journal
   * @return a journal based on the given directory
   */
  Journal get(String directory);

  /**
   * A factory which creates read-write journals.
   */
  final class ReadWrite implements JournalFactory{
    private final String mBaseDirectory;

    /**
     * Creates a journal factory with the specified directory as the root. When journals are
     * created, their paths are appended to the base path, e.g.
     *
     *<pre>
     * baseDirectory
     *   journalDirectory1
     *   journalDirectory2
     *</pre>
     *
     * Journals created by this factory support both reading and writing.
     *
     * @param baseDirectory the base directory for journals created by this factory
     */
    public ReadWrite(String baseDirectory) {
      mBaseDirectory = baseDirectory;
    }

    @Override
    public Journal get(String directory) {
      return new ReadWriteJournal(PathUtils.concatPath(mBaseDirectory, directory));
    }
  }

  /**
   * A factory which creates read-only journals.
   */
  final class ReadOnly implements JournalFactory {
    private final String mBaseDirectory;

    /**
     * Creates a journal factory with the specified directory as the root. When journals are
     * created, their paths are appended to the base path, e.g.
     *
     *<pre>
     * baseDirectory
     *   journalDirectory1
     *   journalDirectory2
     *</pre>
     *
     * Journals created by this factory only support reads.
     *
     * @param baseDirectory the base directory for journals created by this factory
     */
    public ReadOnly(String baseDirectory) {
      mBaseDirectory = baseDirectory;
    }

    @Override
    public Journal get(String directory) {
      return new ReadWriteJournal(PathUtils.concatPath(mBaseDirectory, directory));
    }
  }
}

@@ -2425,37 +2425,36 @@
  return new Read
-Write
+Only
 Journal(PathUtil

Make read-only journal factory return read-only journals