/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */


package org.apache.tomcat.util.modeler;


import java.util.Locale;

import javax.management.MBeanOperationInfo;
import javax.management.MBeanParameterInfo;


/**
 * <p>Internal configuration information for an <code>Operation</code>
 * descriptor.</p>
 *
 * @author Craig R. McClanahan
 */
public class OperationInfo extends FeatureInfo {
    static final long serialVersionUID = 4418342922072614875L;
    // ----------------------------------------------------------- Constructors


    /**
     * Standard zero-arguments constructor.
     */
    public OperationInfo() {

        super();

    }

    // ----------------------------------------------------- Instance Variables

    protected String impact = "UNKNOWN";
    protected String role = "operation";
    protected ParameterInfo parameters[] = new ParameterInfo[0];


    // ------------------------------------------------------------- Properties

    /**
     * The "impact" of this operation, which should be a (case-insensitive)
     * string value "ACTION", "ACTION_INFO", "INFO", or "UNKNOWN".
     */
    public String getImpact() {
        return (this.impact);
    }

    public void setImpact(String impact) {
        if (impact == null)
            this.impact = null;
        else
            this.impact = impact.toUpperCase(Locale.ENGLISH);
    }


    /**
     * The role of this operation ("getter", "setter", "operation", or
     * "constructor").
     */
    public String getRole() {
        return (this.role);
    }

    public void setRole(String role) {
        this.role = role;
    }


    /**
     * The fully qualified Java class name of the return type for this
     * operation.
     */
    public String getReturnType() {
        if(type == null) {
            type = "void";
        }
        return type;
    }

    public void setReturnType(String returnType) {
        this.type = returnType;
    }

    /**
     * The set of parameters for this operation.
     */
    public ParameterInfo[] getSignature() {
        return (this.parameters);
    }

    // --------------------------------------------------------- Public Methods


    /**
     * Add a new parameter to the set of arguments for this operation.
     *
     * @param parameter The new parameter descriptor
     */
    public void addParameter(ParameterInfo parameter) {

        synchronized (parameters) {
            ParameterInfo results[] = new ParameterInfo[parameters.length + 1];
            System.arraycopy(parameters, 0, results, 0, parameters.length);
            results[parameters.length] = parameter;
            parameters = results;
            this.info = null;
        }

    }


    /**
     * Create and return a <code>ModelMBeanOperationInfo</code> object that
     * corresponds to the attribute described by this instance.
     */
    MBeanOperationInfo createOperationInfo() {

        // Return our cached information (if any)
        if (info == null) {
            // Create and return a new information object
            int impact = MBeanOperationInfo.UNKNOWN;
            if ("ACTION".equals(getImpact()))
                impact = MBeanOperationInfo.ACTION;
            else if ("ACTION_INFO".equals(getImpact()))
                impact = MBeanOperationInfo.ACTION_INFO;
            else if ("INFO".equals(getImpact()))
                impact = MBeanOperationInfo.INFO;

            info = new MBeanOperationInfo(getName(), getDescription(),
                                          getMBeanParameterInfo(),
                                          getReturnType(), impact);
        }
        return (MBeanOperationInfo)info;
    }

    protected MBeanParameterInfo[] getMBeanParameterInfo() {
        ParameterInfo params[] = getSignature();
        MBeanParameterInfo parameters[] =
            new MBeanParameterInfo[params.length];
        for (int i = 0; i < params.length; i++)
            parameters[i] = params[i].createParameterInfo();
        return parameters;
    }
}

@@ -796,18 +796,16 @@
 se.%0A */%0A
-%0A%0A
 package 
@@ -837,17 +837,16 @@
 deler;%0A%0A
-%0A
 import j
@@ -861,16 +861,163 @@
 .Locale;
+%0Aimport java.util.concurrent.locks.Lock;%0Aimport java.util.concurrent.locks.ReadWriteLock;%0Aimport java.util.concurrent.locks.ReentrantReadWriteLock;
 %0A%0Aimport
@@ -1099,17 +1099,16 @@
 rInfo;%0A%0A
-%0A
 /**%0A * %3C
@@ -1280,16 +1280,17 @@
 eInfo %7B%0A
+%0A
     stat
@@ -1344,16 +1344,17 @@
 14875L;%0A
+%0A
     // -
@@ -1426,17 +1426,16 @@
 uctors%0A%0A
-%0A
     /**%0A
@@ -1507,33 +1507,32 @@
 erationInfo() %7B%0A
-%0A
         super();
@@ -1532,24 +1532,24 @@
 uper();%0A
-%0A
     %7D%0A%0A
+%0A
     // -
@@ -1703,16 +1703,91 @@
 ation%22;%0A
+    protected ReadWriteLock parametersLock = new ReentrantReadWriteLock();%0A
     prot
@@ -2128,25 +2128,24 @@
      return 
-(
 this.impact)
@@ -2139,25 +2139,24 @@
  this.impact
-)
 ;%0A    %7D%0A%0A   
@@ -2489,25 +2489,24 @@
      return 
-(
 this.role);%0A
@@ -2502,17 +2502,16 @@
 his.role
-)
 ;%0A    %7D%0A
@@ -3012,24 +3012,122 @@
 gnature() %7B%0A
+        Lock readLock = parametersLock.readLock();%0A        try %7B%0A            readLock.lock();%0A    
         retu
@@ -3129,17 +3129,16 @@
  return 
-(
 this.par
@@ -3144,18 +3144,78 @@
 rameters
-)
 ;
+%0A        %7D finally %7B%0A            readLock.unlock();%0A        %7D
 %0A    %7D%0A%0A
@@ -3512,35 +3512,96 @@
     
-synchronized (parameters) %7B
+Lock writeLock = parametersLock.writeLock();%0A        try %7B%0A            writeLock.lock();
 %0A   
@@ -3874,25 +3874,76 @@
 l;%0A        %7D
-%0A
+ finally %7B%0A            writeLock.unlock();%0A        %7D
 %0A    %7D%0A%0A%0A   

Fix a FindBugs issue (incorrect synchronization)