package org.apache.james.protocols.api.handler;

import java.util.ArrayList;
import java.util.Collection;
import java.util.List;

import org.apache.james.protocols.api.ProtocolSession;
import org.apache.james.protocols.api.ProtocolSession.State;
import org.apache.james.protocols.api.Response;

/**
 * A special {@link LineHandler} which will "buffer" the received lines till a point and the push them all at
 * one to the {@link #onLines(ProtocolSession, Collection)} method
 * 
 *
 * @param <S>
 */
public abstract class MultiLineHandler<S extends ProtocolSession> implements LineHandler<S>{

    private static final String BUFFERED_LINES = "BUFFERED_LINES";
    
    /*
     * (non-Javadoc)
     * @see org.apache.james.protocols.api.handler.LineHandler#onLine(org.apache.james.protocols.api.ProtocolSession, byte[])
     */
    @SuppressWarnings("unchecked")
    public Response onLine(S session, byte[] line) {
        Collection<byte[]> lines = (List<byte[]>) session.getAttachment(BUFFERED_LINES, State.Transaction);
        if (lines == null)  {
            lines = new ArrayList<byte[]>();
            session.setAttachment(BUFFERED_LINES, lines, State.Transaction);
        }
        lines.add(line);
        if (isReady(session, line)) {
            return onLines(session, (Collection<byte[]>) session.setAttachment(BUFFERED_LINES, null, State.Transaction));
        }
        return null;
    }

    /**
     * Return <code>true</code> if the buffered lines are ready to get pushed to the {@link #onLines(ProtocolSession, Collection)} method
     * 
     * @param session
     * @param line
     * @return ready
     */
    protected abstract boolean isReady(S session, byte[] line);
    
    /**
     * Handle the buffered lines
     * 
     * @param session
     * @param lines
     * @return response
     */
    protected abstract Response onLines(S session, Collection<byte[]> lines);
}

@@ -42,16 +42,44 @@
 ndler;%0A%0A
+import java.nio.ByteBuffer;%0A
 import j
@@ -919,30 +919,34 @@
 (S session, 
-byte%5B%5D
+ByteBuffer
  line) %7B%0A   
@@ -957,30 +957,34 @@
  Collection%3C
-byte%5B%5D
+ByteBuffer
 %3E lines = (L
@@ -987,22 +987,26 @@
 = (List%3C
-byte%5B%5D
+ByteBuffer
 %3E) sessi
@@ -1122,22 +1122,26 @@
 rayList%3C
-byte%5B%5D
+ByteBuffer
 %3E();%0A   
@@ -1335,22 +1335,26 @@
 lection%3C
-byte%5B%5D
+ByteBuffer
 %3E) sessi
@@ -1725,22 +1725,26 @@
 ession, 
-byte%5B%5D
+ByteBuffer
  line);%0A
@@ -1933,22 +1933,26 @@
 lection%3C
-byte%5B%5D
+ByteBuffer
 %3E lines)

Allow easy handling of multiple lines. See PROTOCOLS-72