/*
 * Copyright  1999-2004 The Apache Software Foundation.
 *
 *  Licensed under the Apache License, Version 2.0 (the "License");
 *  you may not use this file except in compliance with the License.
 *  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 *  Unless required by applicable law or agreed to in writing, software
 *  distributed under the License is distributed on an "AS IS" BASIS,
 *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 *  See the License for the specific language governing permissions and
 *  limitations under the License.
 *
 */
package org.apache.xml.security.keys.content.x509;



import java.math.BigInteger;
import java.security.cert.X509Certificate;

import org.apache.xml.security.exceptions.XMLSecurityException;
import org.apache.xml.security.utils.Constants;
import org.apache.xml.security.utils.RFC2253Parser;
import org.apache.xml.security.utils.SignatureElementProxy;
import org.apache.xml.security.utils.XMLUtils;
import org.w3c.dom.Document;
import org.w3c.dom.Element;


/**
 *
 * @author $Author$
 */
public class XMLX509IssuerSerial extends SignatureElementProxy
        implements XMLX509DataContent {

   /** {@link org.apache.commons.logging} logging facility */
    static org.apache.commons.logging.Log log = 
        org.apache.commons.logging.LogFactory.getLog(
                    XMLX509IssuerSerial.class.getName());

   /**
    * Constructor XMLX509IssuerSerial
    *
    * @param element
    * @param BaseURI
    * @throws XMLSecurityException
    */
   public XMLX509IssuerSerial(Element element, String BaseURI)
           throws XMLSecurityException {
      super(element, BaseURI);
   }

   /**
    * Constructor XMLX509IssuerSerial
    *
    * @param doc
    * @param X509IssuerName
    * @param X509SerialNumber
    */
   public XMLX509IssuerSerial(Document doc, String X509IssuerName,
                              BigInteger X509SerialNumber) {

      super(doc);

      XMLUtils.addReturnToElement(this._constructionElement);
      this.addTextElement(X509IssuerName, Constants._TAG_X509ISSUERNAME);
      XMLUtils.addReturnToElement(this._constructionElement);
      this.addTextElement(X509SerialNumber.toString(), Constants._TAG_X509SERIALNUMBER);
   }

   /**
    * Constructor XMLX509IssuerSerial
    *
    * @param doc
    * @param X509IssuerName
    * @param X509SerialNumber
    */
   public XMLX509IssuerSerial(Document doc, String X509IssuerName,
                              String X509SerialNumber) {
      this(doc, X509IssuerName, new BigInteger(X509SerialNumber));
   }

   /**
    * Constructor XMLX509IssuerSerial
    *
    * @param doc
    * @param X509IssuerName
    * @param X509SerialNumber
    */
   public XMLX509IssuerSerial(Document doc, String X509IssuerName,
                              int X509SerialNumber) {
      this(doc, X509IssuerName,
           new BigInteger(Integer.toString(X509SerialNumber)));
   }

   /**
    * Constructor XMLX509IssuerSerial
    *
    * @param doc
    * @param x509certificate
    */
   public XMLX509IssuerSerial(Document doc, X509Certificate x509certificate) {

      this(doc,
           RFC2253Parser.normalize(x509certificate.getIssuerDN().getName()),
           x509certificate.getSerialNumber());
   }

   /**
    * Method getSerialNumber
    *
    *
    * @return the serial number
    */
   public BigInteger getSerialNumber() {

      String text =
         this.getTextFromChildElement(Constants._TAG_X509SERIALNUMBER,
                                      Constants.SignatureSpecNS);
      if (log.isDebugEnabled())
      	log.debug("In dem X509SerialNumber wurde gefunden: " + text);

      return new BigInteger(text);
   }

   /**
    * Method getSerialNumberInteger
    *
    *
    * @return the serial number as plain int
    */
   public int getSerialNumberInteger() {
      return this.getSerialNumber().intValue();
   }

   /**
    * Method getIssuerName
    *
    *
    * @return the issuer name
    */
   public String getIssuerName()  {

      return RFC2253Parser
         .normalize(this
            .getTextFromChildElement(Constants._TAG_X509ISSUERNAME,
                                     Constants.SignatureSpecNS));
   }

   /** @inheritDoc */
   public boolean equals(Object obj) {

      if (!obj.getClass().getName().equals(this.getClass().getName())) {
         return false;
      }

      XMLX509IssuerSerial other = (XMLX509IssuerSerial) obj;


      if (other.getSerialNumber().equals(this.getSerialNumber())
                 && other.getIssuerName().equals(this.getIssuerName())) {
           return true;
      }

       return false;      
   }

   /** @inheritDoc */
   public String getBaseLocalName() {
      return Constants._TAG_X509ISSUERSERIAL;
   }
}

@@ -4246,32 +4246,33 @@
 cNS));%0A   %7D%0A%0A   
+ 
 /** @inheritDoc 
@@ -4266,32 +4266,33 @@
  @inheritDoc */%0A
+ 
    public boolea
@@ -4311,24 +4311,68 @@
 ect obj) %7B%0A%0A
+%09if (obj == null) %7B%0A%09    return false;%0A%09%7D%0A  
       if (!o
@@ -4370,19 +4370,20 @@
    if (!
-obj
+this
 .getClas
@@ -4399,28 +4399,27 @@
 me().equals(
-this
+obj
 .getClass().
@@ -4424,32 +4424,35 @@
 ).getName())) %7B%0A
+   
          return 
@@ -4460,27 +4460,31 @@
 alse;%0A      
+  
 %7D%0A%0A
+  
       XMLX50
@@ -4537,24 +4537,27 @@
 j;%0A%0A
-%0A
       
-if (other
+  return this
 .get
@@ -4574,28 +4574,29 @@
 er().equals(
+o
 th
-is
+er
 .getSerialNu
@@ -4599,26 +4599,24 @@
 alNumber())%0A
-  
             
@@ -4621,21 +4621,20 @@
      && 
-o
 th
-er
+is
 .getIssu
@@ -4649,20 +4649,21 @@
 .equals(
+o
 th
-is
+er
 .getIssu
@@ -4675,72 +4675,141 @@
 e())
-) %7B
+;
 %0A    
-   
+%7D%0A%0A
     
-return true;%0A      %7D%0A%0A       return false;      %0A
+public int hashCode() %7B%0A%09// uncomment when JDK 1.4 is required%0A%09// assert false : %22hashCode not designed%22;%0A%09return 82;%0A 
    %7D

Fix findbugs bugs: XMLX509IssuerSerial defines equals and uses Object.hashCode() Possible null pointer dereference in equals().