// Copyright 2018 The Bazel Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//    http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.devtools.build.lib.skyframe.actiongraph.v2;

import com.google.devtools.build.lib.analysis.AnalysisProtosV2.ActionGraphContainer;
import java.util.HashMap;
import java.util.Map;

/**
 * Basic class to abstract action graph cache functionality.
 */
abstract class BaseCache<K, P> {
  private final Map<K, Long> cache = new HashMap<>();
  protected final ActionGraphContainer.Builder actionGraphBuilder;

  BaseCache(ActionGraphContainer.Builder actionGraphBuilder) {
    this.actionGraphBuilder = actionGraphBuilder;
  }

  private long generateNextId() {
    return cache.size();
  }

  protected K transformToKey(K data) {
    // In most cases, the data is the key but it can be overridden by subclasses.
    return data;
  }

  Long dataToId(K data) {
    K key = transformToKey(data);
    Long id = cache.get(key);
    if (id == null) {
      // Note that this cannot be replaced by computeIfAbsent since createProto is a recursive
      // operation for the case of nested sets which will call dataToId on the same object and thus
      // computeIfAbsent again.
      id = generateNextId();
      cache.put(key, id);
      P proto = createProto(data, id);
      addToActionGraphBuilder(proto);
    }
    return id;
  }

  abstract P createProto(K key, Long id);

  abstract void addToActionGraphBuilder(P proto);
}

@@ -1178,24 +1178,169 @@
 eNextId() %7B%0A
+    // protobuf interprets the value 0 as %22default value%22 for uint64, thus treating the field as%0A    // %22unset%22. We should start from 1 instead.%0A
     return c
@@ -1350,16 +1350,21 @@
 e.size()
+ + 1L
 ;%0A  %7D%0A%0A 
@@ -1505,16 +1505,155 @@
 a;%0A  %7D%0A%0A
+  /**%0A   * Store the data in the internal cache, if it's not yet present. Return the generated id. Ids are%0A   * positive and unique.%0A   */%0A
   Long d

Bump the messages' ids from 0 to 1.