/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.karaf.instance.command;

import java.util.List;

import org.apache.karaf.features.command.completers.AllFeatureCompleter;
import org.apache.karaf.features.command.completers.InstalledRepoUriCompleter;
import org.apache.karaf.instance.core.InstanceSettings;
import org.apache.karaf.shell.api.action.Argument;
import org.apache.karaf.shell.api.action.Command;
import org.apache.karaf.shell.api.action.Completion;
import org.apache.karaf.shell.api.action.Option;
import org.apache.karaf.shell.api.action.lifecycle.Service;

/**
 * Creates a new instance.
 */
@Command(scope = "instance", name = "create", description = "Creates a new container instance.")
@Service
public class CreateCommand extends InstanceCommandSupport
{
    @Option(name = "-s", aliases = {"--ssh-port"}, description = "Port number for remote secure shell connection", required = false, multiValued = false)
    int sshPort = 0;

    @Option(name = "-r", aliases = {"-rr", "--rmi-port", "--rmi-registry-port"}, description = "Port number for RMI registry connection", required = false, multiValued = false)
    int rmiRegistryPort = 0;

    @Option(name = "-rs", aliases = {"--rmi-server-port"}, description = "Port number for RMI server connection", required = false, multiValued = false)
    int rmiServerPort = 0;

    @Option(name = "-l", aliases = {"--location"}, description = "Location of the new container instance in the file system", required = false, multiValued = false)
    String location;

    @Option(name = "-o", aliases = {"--java-opts"}, description = "JVM options to use when launching the instance", required = false, multiValued = false)
    String javaOpts;
    
    @Option(name = "-f", aliases = {"--feature"},
            description = "Initial features. This option can be specified multiple times to enable multiple initial features", required = false, multiValued = true)
    @Completion(AllFeatureCompleter.class)
    List<String> features;
    
    @Option(name = "-furl", aliases = {"--featureURL"}, 
            description = "Additional feature descriptor URLs. This option can be specified multiple times to add multiple URLs", required = false, multiValued = true)
    @Completion(InstalledRepoUriCompleter.class)
    List<String> featureURLs;

    @Option(name = "-v", aliases = {"--verbose"}, description = "Display actions performed by the command (disabled by default)", required = false, multiValued = false)
    boolean verbose = false;

    @Argument(index = 0, name = "name", description="The name of the new container instance", required = true, multiValued = false)
    String instance = null;

    protected Object doExecute() throws Exception {
        InstanceSettings settings = new InstanceSettings(sshPort, rmiRegistryPort, rmiServerPort, location, javaOpts, featureURLs, features);
        getInstanceService().createInstance(instance, settings, verbose);
        return null;
    }

}

@@ -856,19 +856,146 @@
 ava.
-util.List;%0A
+io.File;%0Aimport java.util.ArrayList;%0Aimport java.util.Arrays;%0Aimport java.util.List;%0A%0Aimport org.apache.felix.utils.properties.Properties;
 %0Aimp
@@ -1664,16 +1664,226 @@
 pport%0A%7B%0A
+%0A    public static final String FEATURES_SERVICE_CONFIG_FILE = %22org.apache.karaf.features.cfg%22;%0A%0A    @Option(name = %22-b%22, aliases = %22--bare%22, description = %22Do not use add default features%22)%0A    boolean bare;%0A%0A
     @Opt
@@ -3813,16 +3813,776 @@
 ption %7B%0A
+        if (!bare) %7B%0A            Properties configuration = new Properties();%0A            File configFile = new File(System.getProperty(%22karaf.etc%22), FEATURES_SERVICE_CONFIG_FILE);%0A            configuration.load(configFile);%0A            String featuresRepositories = configuration.getProperty(%22featuresRepositories%22, %22%22);%0A            String featuresBoot = configuration.getProperty(%22featuresBoot%22, %22%22);%0A            if (featureURLs == null) %7B%0A                featureURLs = new ArrayList%3C%3E();%0A            %7D%0A            featureURLs.addAll(Arrays.asList(featuresRepositories.split(%22,%22)));%0A            if (features == null) %7B%0A                features = new ArrayList%3C%3E();%0A            %7D%0A            features.addAll(Arrays.asList(featuresBoot.split(%22,%22)));%0A        %7D%0A
         

Use the current distribution configuration for default boot features when creating children