/*
 * Copyright © 2013-2019 camunda services GmbH and various authors (info@camunda.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.camunda.bpm.engine.rest.sub.history.impl;

import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status;

import org.camunda.bpm.engine.ProcessEngine;
import org.camunda.bpm.engine.exception.NotFoundException;
import org.camunda.bpm.engine.history.HistoricVariableInstance;
import org.camunda.bpm.engine.history.HistoricVariableInstanceQuery;
import org.camunda.bpm.engine.query.Query;
import org.camunda.bpm.engine.rest.dto.history.HistoricVariableInstanceDto;
import org.camunda.bpm.engine.rest.exception.InvalidRequestException;
import org.camunda.bpm.engine.rest.sub.AbstractResourceProvider;
import org.camunda.bpm.engine.rest.sub.history.HistoricVariableInstanceResource;
import org.camunda.bpm.engine.variable.value.TypedValue;

/**
 * @author Daniel Meyer
 * @author Ronny Bräunlich
 *
 */
public class HistoricVariableInstanceResourceImpl extends
    AbstractResourceProvider<HistoricVariableInstanceQuery, HistoricVariableInstance, HistoricVariableInstanceDto> implements HistoricVariableInstanceResource {

  public HistoricVariableInstanceResourceImpl(String variableId, ProcessEngine engine) {
    super(variableId, engine);
  }

  protected HistoricVariableInstanceQuery baseQuery() {
    return getEngine().getHistoryService().createHistoricVariableInstanceQuery().variableId(getId());
  }

  @Override
  protected Query<HistoricVariableInstanceQuery, HistoricVariableInstance> baseQueryForBinaryVariable() {
    return baseQuery().disableCustomObjectDeserialization();
  }

  @Override
  protected Query<HistoricVariableInstanceQuery, HistoricVariableInstance> baseQueryForVariable(boolean deserializeObjectValue) {
    HistoricVariableInstanceQuery query = baseQuery().disableBinaryFetching();

    if (!deserializeObjectValue) {
      query.disableCustomObjectDeserialization();
    }
    return query;
  }

  @Override
  protected TypedValue transformQueryResultIntoTypedValue(HistoricVariableInstance queryResult) {
    return queryResult.getTypedValue();
  }

  @Override
  protected HistoricVariableInstanceDto transformToDto(HistoricVariableInstance queryResult) {
    return HistoricVariableInstanceDto.fromHistoricVariableInstance(queryResult);
  }

  @Override
  protected String getResourceNameForErrorMessage() {
    return "Historic variable instance";
  }
  
  @Override
  public Response deleteVariableInstance() {
    try {
      getEngine().getHistoryService().deleteHistoricVariableInstance(id);
    } catch (NotFoundException nfe) {
      throw new InvalidRequestException(Status.NOT_FOUND, nfe, nfe.getMessage());
    }
    return Response.noContent().build();
  }

}

@@ -3132,24 +3132,89 @@
 ption nfe) %7B
+ // rewrite status code from bad request (400) to not found (404)
 %0A      throw
@@ -3282,32 +3282,89 @@
 ssage());%0A    %7D%0A
+    // return no content (204) since resource is deleted%0A
     return Respo

add documentation on return codes