/*
 * Copyright 2015 Red Hat, Inc. and/or its affiliates.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *       http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.optaplanner.benchmark.impl.ranking;

import java.io.Serializable;
import java.util.Comparator;

import org.optaplanner.benchmark.impl.result.SubSingleBenchmarkResult;

public class SubSingleBenchmarkRankBasedComparator implements Comparator<SubSingleBenchmarkResult>, Serializable {

    @Override
    public int compare(SubSingleBenchmarkResult a, SubSingleBenchmarkResult b) {
        return Comparator
                // Reverse, less is better (redundant: failed benchmarks don't get ranked at all)
                .comparing(SubSingleBenchmarkResult::hasAnyFailure, Comparator.reverseOrder())
                .thenComparing(SubSingleBenchmarkResult::getRanking, Comparator.naturalOrder())
                .compare(a, b);
    }

}

@@ -15,10 +15,10 @@
 t 20
-15
+20
  Red
@@ -243,17 +243,16 @@
  *      
- 
 http://w
@@ -919,114 +919,112 @@
     
-@Override%0A    publ
+private stat
 ic 
+f
 in
-t c
+al C
 ompar
-e(SubSingleBenchmarkResult a, SubSingleBenchmarkResult b) %7B%0A        return 
+ator%3CSubSingleBenchmarkResult%3E COMPARATOR =%0A            Comparator.nullsLast(
 Comp
@@ -1030,16 +1030,20 @@
 parator%0A
+    
         
@@ -1144,24 +1144,28 @@
             
+    
 .comparing(S
@@ -1247,16 +1247,20 @@
         
+   
+ 
 .thenCom
@@ -1330,33 +1330,140 @@
 Order())
+);%0A
 %0A    
-            
+@Override%0A    public int compare(SubSingleBenchmarkResult a, SubSingleBenchmarkResult b) %7B%0A        return COMPARATOR
 .compare

Fix NPE when benchmark result is null