/*
 * Copyright 2003-2005 The Apache Software Foundation.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * 
 */

package org.apache.jmeter.functions;

import java.io.Serializable;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;

import org.apache.jmeter.engine.util.CompoundVariable;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.samplers.Sampler;
import org.apache.jmeter.threads.JMeterVariables;
import org.apache.jmeter.util.JMeterUtils;

/**
 * Provides a Random function which returns a random long integer between a min
 * (first argument) and a max (second argument).
 * 
 * @author <a href="mailto:sjkwadzo@praize.com">Jonathan Kwadzo</a>
 */
public class Random extends AbstractFunction implements Serializable {

	private static final List desc = new LinkedList();

	private static final String KEY = "__Random"; //$NON-NLS-1$

	static {
		desc.add(JMeterUtils.getResString("minimum_param")); //$NON-NLS-1$
		desc.add(JMeterUtils.getResString("maximum_param")); //$NON-NLS-1$
		desc.add(JMeterUtils.getResString("function_name_param")); //$NON-NLS-1$
	}

	private transient CompoundVariable varName, minimum, maximum;

	/**
	 * No-arg constructor.
	 */
	public Random() {
	}

	/**
	 * Clone this Add object.
	 * 
	 * @return A new Add object.
	 */
	public Object clone() {
		Random newRandom = new Random();
		return newRandom;
	}

	/**
	 * Execute the function.
	 * 
	 * @see Function#execute(SampleResult, Sampler)
	 */
	public synchronized String execute(SampleResult previousResult, Sampler currentSampler)
			throws InvalidVariableException {

		JMeterVariables vars = getVariables();

		long min = Long.parseLong(minimum.execute().trim());
		long max = Long.parseLong(maximum.execute().trim());

		long rand = Math.round(min + Math.random() * (max - min));

		String randString = Long.toString(rand);
		vars.put(varName.execute(), randString);

		return randString;

	}

	/**
	 * Set the parameters for the function.
	 * 
	 * @see Function#setParameters(Collection)
	 */
	public synchronized void setParameters(Collection parameters) throws InvalidVariableException {
		Object[] values = parameters.toArray();

		if (values.length < 3) {
			throw new InvalidVariableException();
		}
		varName = (CompoundVariable) values[2];
		minimum = (CompoundVariable) values[0];
		maximum = (CompoundVariable) values[1];

	}

	/**
	 * Get the invocation key for this function.
	 * 
	 * @see Function#getReferenceKey()
	 */
	public String getReferenceKey() {
		return KEY;
	}

	/**
	 * Get the description of this function.
	 * 
	 * @see Function#getArgumentDesc()
	 */
	public List getArgumentDesc() {
		return desc;
	}

}

@@ -2293,24 +2293,20 @@
 d = 
-Math.round(min +
+min + (long)
  Mat
@@ -2328,17 +2328,20 @@
 ax - min
-)
+ + 1
 );%0A%0A%09%09St

Fix uneven distribution of end values, see: http://mail-archives.apache.org/mod_mbox/jakarta-jmeter-user/200609.mbox/%3cloom.20060928T021049-454@post.gmane.org%3e