/*
 * Copyright 2019 Anton Tananaev (anton@traccar.org)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.traccar.protocol;

import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.channel.Channel;
import org.traccar.BaseProtocolDecoder;
import org.traccar.DeviceSession;
import org.traccar.NetworkMessage;
import org.traccar.Protocol;
import org.traccar.helper.BitUtil;
import org.traccar.helper.Checksum;
import org.traccar.helper.UnitsConverter;
import org.traccar.model.Position;

import java.net.SocketAddress;
import java.util.Date;
import java.util.LinkedList;
import java.util.List;

public class SatsolProtocolDecoder extends BaseProtocolDecoder {

    public SatsolProtocolDecoder(Protocol protocol) {
        super(protocol);
    }

    @Override
    protected Object decode(
            Channel channel, SocketAddress remoteAddress, Object msg) throws Exception {

        ByteBuf buf = (ByteBuf) msg;

        buf.readUnsignedShortLE(); // checksum
        buf.readUnsignedShortLE(); // preamble
        long id = buf.readUnsignedIntLE();
        buf.readUnsignedShortLE(); // length

        DeviceSession deviceSession = getDeviceSession(channel, remoteAddress, String.valueOf(id));
        if (deviceSession == null) {
            return null;
        }

        List<Position> positions = new LinkedList<>();

        while (buf.isReadable()) {

            buf.readUnsignedShortLE(); // checksum
            buf.readUnsignedShortLE(); // checksum
            buf.readUnsignedShortLE(); // type
            int length = buf.readUnsignedShortLE();

            Position position = new Position(getProtocolName());
            position.setDeviceId(deviceSession.getDeviceId());

            position.setTime(new Date(buf.readUnsignedIntLE() * 1000));
            position.setLongitude(buf.readUnsignedIntLE() * 0.000001);
            position.setLatitude(buf.readUnsignedIntLE() * 0.000001);
            position.setSpeed(UnitsConverter.knotsFromKph(buf.readUnsignedShortLE()));
            position.setAltitude(buf.readShortLE());
            position.setCourse(buf.readUnsignedShortLE());
            position.setValid(buf.readUnsignedByte() > 0);

            position.set(Position.KEY_SATELLITES, buf.readUnsignedByte());
            position.set(Position.KEY_EVENT, buf.readUnsignedByte());

            if (BitUtil.check(buf.readUnsignedByte(), 0)) {
                position.set(Position.KEY_ARCHIVE, true);
            }

            positions.add(position);

            buf.skipBytes(length);

        }

        if (channel != null) {
            ByteBuf response = Unpooled.buffer();
            response.writeShortLE(0);
            response.writeShortLE(0x4CBF); // preamble
            response.writeIntLE((int) id);
            response.writeShortLE(0);
            response.setShortLE(0, Checksum.crc16(
                    Checksum.CRC16_CCITT_FALSE, response.nioBuffer(2, response.readableBytes() - 2)));
            channel.writeAndFlush(new NetworkMessage(response, remoteAddress));
        }

        return positions;
    }

}

@@ -2333,19 +2333,18 @@
 ion.setL
-ong
+at
 itude(bu
@@ -2395,34 +2395,35 @@
    position.setL
-at
+ong
 itude(buf.readUn

Fix coordinates decoding