// Copyright (C) 2017 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.googlesource.gerrit.plugins.webhooks;

import org.eclipse.jgit.lib.Config;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import com.google.common.base.Strings;
import com.google.gerrit.common.EventListener;
import com.google.gerrit.extensions.annotations.PluginName;
import com.google.gerrit.server.config.PluginConfigFactory;
import com.google.gerrit.server.events.Event;
import com.google.gerrit.server.events.ProjectEvent;
import com.google.gerrit.server.project.NoSuchProjectException;
import com.google.inject.Inject;

class EventHandler implements EventListener {
  private static final Logger log = LoggerFactory
      .getLogger(EventHandler.class);

  private final PluginConfigFactory configFactory;
  private final String pluginName;
  private final PostEventTask.Factory taskFactory;

  @Inject
  EventHandler(PluginConfigFactory configFactory,
      @PluginName String pluginName,
      PostEventTask.Factory taskFactory) {
    this.configFactory = configFactory;
    this.pluginName = pluginName;
    this.taskFactory = taskFactory;
  }

  @Override
  public void onEvent(Event event) {
    if (!(event instanceof ProjectEvent)) {
      return;
    }

    ProjectEvent projectEvent = (ProjectEvent) event;
    Config cfg;
    try {
      cfg = configFactory.getProjectPluginConfigWithInheritance(
          projectEvent.getProjectNameKey(), pluginName);
    } catch (NoSuchProjectException e) {
      log.warn("Ignoring event for a non-existing project {}, {}",
          projectEvent.getProjectNameKey().get(), projectEvent);
      return;
    }

    for (String name : cfg.getSubsections("remote")) {
      String url = cfg.getString("remote", name, "url");
      if (Strings.isNullOrEmpty(url)) {
        log.warn("remote.{}.url not defined, skipping this remote", name);
        continue;
      }

      String[] eventTypes = cfg.getStringList("remote", name, "event");

      if (eventTypes.length == 0) {
        post(url, projectEvent);
      }

      for (String type : eventTypes) {
        if (Strings.isNullOrEmpty(type)) {
          continue;
        }
        if (type.equals(projectEvent.getType())) {
          post(url, projectEvent);
        }
      }
    }
  }

  private void post(final String url, final ProjectEvent projectEvent) {
    taskFactory.create(url, projectEvent).schedule();
  }
}

@@ -2452,29 +2452,36 @@
     
-String%5B%5D eventTypes =
+if (shouldPost(projectEvent,
  cfg
@@ -2523,91 +2523,208 @@
 nt%22)
-;%0A
+)) %7B
 %0A      
-if (eventTypes.length == 0) %7B%0A        post(url, projectEvent);%0A      %7D%0A%0A  
+  post(url, projectEvent);%0A      %7D%0A    %7D%0A  %7D%0A%0A  private boolean shouldPost(ProjectEvent projectEvent, String%5B%5D wantedEvents) %7B%0A    if (wantedEvents.length == 0) %7B%0A      return true;%0A    %7D%0A%0A
     
@@ -2746,17 +2746,19 @@
 e : 
-eventType
+wantedEvent
 s) %7B
@@ -2760,30 +2760,29 @@
 ts) %7B%0A      
-  
 if (
+!
 Strings.isNu
@@ -2800,54 +2800,12 @@
 ype)
-) %7B%0A          continue;%0A        %7D%0A        if (
+ && 
 type
@@ -2851,41 +2851,27 @@
     
-  post(url, projectEvent)
+return true
 ;%0A      
   %7D%0A
@@ -2870,25 +2870,34 @@
     
-  
 %7D%0A    
-  
 %7D
+%0A
 %0A    
-%7D
+return false;
 %0A  %7D

Extract the shouldPost condition into own method