/*
 * Copyright 2013 Robert von Burg <eitch@eitchnet.ch>
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package li.strolch.model.parameter;

import java.util.ArrayList;
import java.util.Collections;
import java.util.List;

import li.strolch.model.StrolchValueType;
import li.strolch.model.visitor.StrolchElementVisitor;
import li.strolch.utils.dbc.DBC;

/**
 * @author Robert von Burg <eitch@eitchnet.ch>
 */
public class IntegerListParameter extends AbstractListParameter<Integer> implements ListParameter<Integer> {

	/**
	 * Empty constructor
	 */
	public IntegerListParameter() {
		//
	}

	/**
	 * Default constructor
	 *
	 * @param id
	 * 		the id
	 * @param name
	 * 		the name
	 * @param value
	 * 		the value
	 */
	public IntegerListParameter(String id, String name, List<Integer> value) {
		super(id, name);

		setValue(value);
	}

	@Override
	protected String elementToString(Integer element) {
		return element.toString();
	}

	@Override
	protected void validateElement(Integer value) {
		DBC.PRE.assertNotNull("null values not allowed!", value);
	}

	@Override
	public String getType() {
		return StrolchValueType.INTEGER_LIST.getType();
	}

	@Override
	public StrolchValueType getValueType() {
		return StrolchValueType.INTEGER_LIST;
	}

	@Override
	public IntegerListParameter getClone() {
		IntegerListParameter clone = new IntegerListParameter();

		super.fillClone(clone);

		clone.setValue(this.value);

		return clone;
	}

	@Override
	public <U> U accept(StrolchElementVisitor<U> visitor) {
		return visitor.visitIntegerListParam(this);
	}

	@Override
	protected List<Integer> parseString(String value) {
		return parseFromString(value);
	}

	public static List<Integer> parseFromString(String value) {
		if (value.isEmpty()) {
			return Collections.emptyList();
		}

		String[] valueArr;
		if (value.contains(VALUE_SEPARATOR1))
			valueArr = value.split(VALUE_SEPARATOR1);
		else
			valueArr = value.split(VALUE_SEPARATOR2);

		List<Integer> values = new ArrayList<>();
		for (String val : valueArr) {
			values.add(Integer.valueOf(val.trim()));
		}
		return values;
	}

	@Override
	public int compareTo(Parameter<?> o) {
		DBC.PRE.assertEquals("Not same Parameter types!", this.getType(), o.getType());
		return Integer.compare(this.getValue().size(), ((IntegerListParameter) o).getValue().size());
	}
}

@@ -2556,15 +2556,14 @@
 ger.
-valueOf
+decode
 (val

Use Integer.decode() on IntegerListParameter.parseFromString()