// Copyright (C) 2012 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.google.gerrit.client.ui;

import com.google.gerrit.client.Gerrit;
import com.google.gwtexpui.safehtml.client.HighlightSuggestOracle;

/**
 * Suggest oracle that only provides suggestions if the user has typed at least
 * as many characters as configured by 'suggest.from'. If 'suggest.from' is set
 * to 0, suggestions will always be provided.
 */
public abstract class SuggestAfterTypingNCharsOracle extends HighlightSuggestOracle {

  @Override
  protected void onRequestSuggestions(final Request request, final Callback done) {
    final int suggestFrom = Gerrit.getConfig().getSuggestFrom();
    if (suggestFrom == 0 || request.getQuery().length() >= suggestFrom) {
      _onRequestSuggestions(request, done);
    }
  }

  protected abstract void _onRequestSuggestions(Request request, Callback done);
}

@@ -748,16 +748,70 @@
 racle;%0A%0A
+import java.util.Collections;%0Aimport java.util.List;%0A%0A
 /**%0A * S
@@ -1153,22 +1153,16 @@
 estions(
-final 
 Request 
@@ -1168,19 +1168,9 @@
  req
-uest, final
+,
  Cal
@@ -1179,20 +1179,18 @@
 ack 
-done
+cb
 ) %7B%0A    
 fina
@@ -1189,30 +1189,37 @@
     
-final int suggestFrom 
+if (req.getQuery().length() %3E
 = Ge
@@ -1255,126 +1255,170 @@
 om()
-;
+) %7B
 %0A    
-if (suggestFrom == 0 %7C%7C request.getQuery().length() %3E= suggestFrom) %7B%0A      _onRequestSuggestions(request, d
+  _onRequestSuggestions(req, cb);%0A    %7D else %7B%0A      List%3CSuggestion%3E none = Collections.emptyList();%0A      cb.onSuggestionsReady(req, new Response(n
 one)
+)
 ;%0A  

Fix reviewer suggestions when suggestFrom > 0