/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * 
 */

package org.apache.jmeter.functions;

import java.io.Serializable;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;

import org.apache.jmeter.engine.util.CompoundVariable;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.samplers.Sampler;
import org.apache.jmeter.threads.JMeterVariables;
import org.apache.jmeter.util.JMeterUtils;

/**
 * Provides a Random function which returns a random long integer between a min
 * (first argument) and a max (second argument).
 * 
 * @author <a href="mailto:sjkwadzo@praize.com">Jonathan Kwadzo</a>
 */
public class Random extends AbstractFunction implements Serializable {

	private static final long serialVersionUID = 1L;
	
	private static final List desc = new LinkedList();

	private static final String KEY = "__Random"; //$NON-NLS-1$

	static {
		desc.add(JMeterUtils.getResString("minimum_param")); //$NON-NLS-1$
		desc.add(JMeterUtils.getResString("maximum_param")); //$NON-NLS-1$
		desc.add(JMeterUtils.getResString("function_name_param")); //$NON-NLS-1$
	}

	private transient CompoundVariable varName, minimum, maximum;

	/**
	 * No-arg constructor.
	 */
	public Random() {
	}

	public Object clone() throws CloneNotSupportedException {
		return super.clone();
	}

	/**
	 * Execute the function.
	 * 
	 * @see Function#execute(SampleResult, Sampler)
	 */
	public synchronized String execute(SampleResult previousResult, Sampler currentSampler)
			throws InvalidVariableException {

		JMeterVariables vars = getVariables();

		long min = Long.parseLong(minimum.execute().trim());
		long max = Long.parseLong(maximum.execute().trim());

		long rand = min + (long) (Math.random() * (max - min + 1));

		String randString = Long.toString(rand);
		vars.put(varName.execute(), randString);

		return randString;

	}

	/**
	 * Set the parameters for the function.
	 * 
	 * @see Function#setParameters(Collection)
	 */
	public synchronized void setParameters(Collection parameters) throws InvalidVariableException {
		Object[] values = parameters.toArray();

		if (values.length < 3) {
			throw new InvalidVariableException();
		}
		varName = (CompoundVariable) values[2];
		minimum = (CompoundVariable) values[0];
		maximum = (CompoundVariable) values[1];

	}

	/**
	 * Get the invocation key for this function.
	 * 
	 * @see Function#getReferenceKey()
	 */
	public String getReferenceKey() {
		return KEY;
	}

	/**
	 * Get the description of this function.
	 * 
	 * @see Function#getArgumentDesc()
	 */
	public List getArgumentDesc() {
		return desc;
	}

}

@@ -1328,76 +1328,8 @@
  * %0A
- * @author %3Ca href=%22mailto:sjkwadzo@praize.com%22%3EJonathan Kwadzo%3C/a%3E%0A
  */%0A
@@ -1446,17 +1446,17 @@
 onUID = 
-1
+2
 L;%0A%09%0A%09pr
@@ -1765,26 +1765,27 @@
 ion_name_par
-am
+opt
 %22)); //$NON-
@@ -2479,16 +2479,43 @@
 (rand);%0A
+%0A%09%09if (varName != null) %7B%0A%09
 %09%09vars.p
@@ -2548,16 +2548,20 @@
 String);
+%0A%09%09%7D
 %0A%0A%09%09retu
@@ -2841,16 +2841,37 @@
 length %3C
+ 2 %7C%7C values.length %3E
  3) %7B%0A%09%09
@@ -2910,56 +2910,85 @@
 ion(
-);%0A%09%09%7D%0A%09%09varName = (CompoundVariable) values%5B2%5D;
+%22Expecting 2 or 3 parameters, but found %22 + values.length);//$NON-NLS-1$%0A%09%09%7D%0A
 %0A%09%09m
@@ -3067,16 +3067,117 @@
 lues%5B1%5D;
+%0A%09%09if (values.length%3E2)%7B%0A%09%09%09varName = (CompoundVariable) values%5B2%5D;%0A%09%09%7D else %7B%0A%09%09%09varName = null;%0A%09%09%7D
 %0A%0A%09%7D%0A%0A%09/

Make variable name optional