// $Header$
/*
 * Copyright 2003-2004 The Apache Software Foundation.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * 
*/

package org.apache.jmeter.functions;

import java.io.Serializable;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;

import org.apache.jmeter.engine.util.CompoundVariable;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jmeter.samplers.Sampler;
import org.apache.jmeter.threads.JMeterVariables;
import org.apache.jmeter.util.JMeterUtils;

/**
 * Provides a Random function which returns a random integer between
 * a min (first argument) and a max (seceond argument).
 *
 * @author <a href="mailto:sjkwadzo@praize.com">Jonathan Kwadzo</a>
 * @version $Id$
 */
public class Random extends AbstractFunction implements Serializable
{

    private static final List desc = new LinkedList();
    private static final String KEY = "__Random";

    static {
        desc.add(JMeterUtils.getResString("minimum_param"));
        desc.add(JMeterUtils.getResString("maximum_param"));
        desc.add(JMeterUtils.getResString("function_name_param"));
    }

    private CompoundVariable varName, minimum, maximum;

    /**
     * No-arg constructor.
     */
    public Random()
    {
    }

    /**
     * Clone this Add object.
     *
     * @return A new Add object.
     */
    public Object clone()
    {
        Random newRandom = new Random();
        return newRandom;
    }

    /**
     * Execute the function.
     *
     * @see Function#execute(SampleResult, Sampler)
     */
    public synchronized String execute(
        SampleResult previousResult,
        Sampler currentSampler)
        throws InvalidVariableException
    {

        JMeterVariables vars = getVariables();

        int min = Integer.parseInt(minimum.execute());
        int max = Integer.parseInt(maximum.execute());

        int rand = (int) Math.round(min + Math.random() * (max - min));

        String randString = Integer.toString(rand);
        vars.put(varName.execute(), randString);

        return randString;

    }

    /**
     * Set the parameters for the function.
     *
     * @see Function#setParameters(Collection)
     */
    public void setParameters(Collection parameters)
        throws InvalidVariableException
    {
        Object[] values = parameters.toArray();

        if (values.length < 3)
        {
            throw new InvalidVariableException();
        }
        else
        {
            varName = (CompoundVariable) values[2];
            minimum = (CompoundVariable) values[0];
            maximum = (CompoundVariable) values[1];
        }

    }

    /**
     * Get the invocation key for this function.
     *
     * @see Function#getReferenceKey()
     */
    public String getReferenceKey()
    {
        return KEY;
    }

    /**
     * Get the description of this function.
     *
     * @see Function#getArgumentDesc()
     */
    public List getArgumentDesc()
    {
        return desc;
    }

}

@@ -1636,16 +1636,26 @@
 private 
+transient 
 Compound

Make non-serialisable fields transient