// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.container.component;

import com.yahoo.container.bundle.BundleInstantiationSpecification;
import com.yahoo.osgi.provider.model.ComponentModel;
import com.yahoo.config.model.producer.AbstractConfigProducer;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

/**
 * Models a jdisc RequestHandler (including ClientProvider).
 * RequestHandlers always have at least one server binding,
 * while ClientProviders have at least one client binding.
 * <p>
 * Note that this is also used to model vespa handlers (which do not have any bindings)
 *
 * @author gjoranv
 */
public class Handler<CHILD extends AbstractConfigProducer<?>> extends Component<CHILD, ComponentModel> {

    private List<String> serverBindings = new ArrayList<>();
    private List<String> clientBindings = new ArrayList<>();

    public Handler(ComponentModel model) {
        super(model);
    }

    public static Handler<AbstractConfigProducer<?>> fromClassName(String className) {
        return new Handler<>(new ComponentModel(className, null, null, null));
    }

    public static Handler<AbstractConfigProducer<?>> getVespaHandlerFromClassName(String className) {
        return new Handler<>(new ComponentModel(BundleInstantiationSpecification.getInternalHandlerSpecificationFromStrings(className, null), null));
    }

    public void addServerBindings(String... bindings) {
        serverBindings.addAll(Arrays.asList(bindings));
    }

    public void addClientBindings(String... bindings) {
        clientBindings.addAll(Arrays.asList(bindings));
    }

    public final List<String> getServerBindings() {
        return Collections.unmodifiableList(serverBindings);
    }

    public final List<String> getClientBindings() {
        return Collections.unmodifiableList(clientBindings);
    }

}

@@ -451,17 +451,71 @@
 .util.Li
-s
+nkedHashSet;%0Aimport java.util.List;%0Aimport java.util.Se
 t;%0A%0A/**%0A
@@ -925,35 +925,34 @@
  %7B%0A%0A    private 
-Lis
+Se
 t%3CString%3E server
@@ -962,32 +962,36 @@
 dings = new 
-ArrayLis
+LinkedHashSe
 t%3C%3E();%0A    p
@@ -1798,35 +1798,34 @@
    public final 
-Lis
+Se
 t%3CString%3E getSer
@@ -1879,19 +1879,18 @@
 difiable
-Lis
+Se
 t(server

Store serverBindings in a Set instead of List