// Copyright 2019 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package google.registry.model.transaction;

import com.google.common.annotations.VisibleForTesting;
import google.registry.model.ofy.DatastoreTransactionManager;

/** Factory class to create {@link TransactionManager} instance. */
// TODO: Rename this to PersistenceFactory and move to persistence package.
public class TransactionManagerFactory {

  private static final TransactionManager TM = createTransactionManager();
  @VisibleForTesting static JpaTransactionManager jpaTm = createJpaTransactionManager();

  private TransactionManagerFactory() {}

  private static JpaTransactionManager createJpaTransactionManager() {
    // TODO(shicong): There is currently no environment where we want to create a real JPA
    // transaction manager here.  The unit tests that require one are all set up using
    // JpaTransactionManagerRule which launches its own PostgreSQL instance.  When we actually have
    // PostgreSQL tables in production, ensure that all of the test environments are set up
    // correctly and restore the code that creates a JpaTransactionManager when
    // RegistryEnvironment.get() != UNITTEST.
    return DummyJpaTransactionManager.create();
  }

  private static TransactionManager createTransactionManager() {
    // TODO: Determine how to provision TransactionManager after the dual-write. During the
    // dual-write transitional phase, we need the TransactionManager for both Datastore and Cloud
    // SQL, and this method returns the one for Datastore.
    return new DatastoreTransactionManager(null);
  }

  /** Returns {@link TransactionManager} instance. */
  public static TransactionManager tm() {
    return TM;
  }

  /** Returns {@link JpaTransactionManager} instance. */
  public static JpaTransactionManager jpaTm() {
    // TODO: Returns corresponding TransactionManager based on the runtime environment.
    //  We have 3 kinds of runtime environment:
    //    1. App Engine
    //    2. Local JVM used by nomulus tool
    //    3. Unit test
    return jpaTm;
  }
}

@@ -1735,16 +1735,466 @@
 ITTEST.%0A
+    //%0A    // We removed the original code because it didn't work in sandbox (due to the absence of the%0A    // persistence.xml file, which has since been added), and then (after adding this) didn't work%0A    // in crash because the postgresql password hadn't been set up.  Prior to restoring, we'll need%0A    // to do setup in all environments, and we probably only want to do this once we're actually%0A    // using Cloud SQL for one of the new tables.%0A
     retu

Add an explanation to dummied-out JPA init (#299)