// Copyright 2014, Kevin Ko <kevin@faveset.com>

package com.faveset.khttp;

import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;

abstract class Pool<T> implements PoolInterface<T> {
    // Used for generating unique tags for each entry's hashCode.
    // Since Java is a GCed language, we need not worry about wraparound.
    // If a duplication occurs, the entry Set will only hold one
    // of the entries.  The other will be released and treated as a normal
    // reference, which will cause a negligible amount of GC churn.
    private int mTagCount;

    // The maximum number of entries to maintain.
    private int mMaxCount;

    // Tracks all free entries.  A free entry is one that is allocated and
    // then released.
    private Set<PoolEntry<T>> mFreeEntries;

    /**
     * @param maxCount the maximum number of entries to maintain before letting
     * the GC take over.
     */
    protected Pool(int maxCount) {
        mMaxCount = maxCount;

        mFreeEntries = new HashSet<PoolEntry<T>>(mMaxCount);
    }

    public PoolEntry<T> allocate() {
        PoolEntry<T> entry;
        if (mFreeEntries.size() == 0) {
            entry = new PoolEntry<T>(mTagCount, allocateValue());
            mTagCount++;
        } else {
            Iterator<PoolEntry<T>> iter = mFreeEntries.iterator();
            entry = iter.next();
            iter.remove();
        }

        return entry;
    }

    /**
     * Child classes should implement this.
     */
    protected abstract T allocateValue();

    // Used for testing.
    int getFreeEntryCount() {
        return mFreeEntries.size();
    }

    /**
     * This returns null so that one can clear the reference to entry when
     * releasing:
     *
     *   entry = pool.release(entry);
     *
     * @return null
     */
    public PoolEntry<T> release(PoolEntry<T> entry) {
        if (mFreeEntries.size() < mMaxCount) {
            // Keep the entry so that we can reach the desired thresholds.
            mFreeEntries.add(entry);
        }
        // At this point, mFreeEntries.size() <= mMaxCount.

        return null;
    }
}

@@ -1862,24 +1862,89 @@
 T%3E entry) %7B%0A
+        if (entry == null) %7B%0A            return null;%0A        %7D%0A%0A
         if (

Handle null entries.