package com.linkedin.thirdeye.dashboard.resources;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import java.util.Arrays;

import javax.ws.rs.core.MultivaluedMap;
import javax.ws.rs.core.UriInfo;

import org.testng.Assert;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.linkedin.thirdeye.dashboard.api.CollectionSchema;
import com.linkedin.thirdeye.dashboard.util.DataCache;
import com.linkedin.thirdeye.dashboard.util.QueryCache;
import com.sun.jersey.core.util.MultivaluedMapImpl;

public class TestDashboardConfigResource {
  private static final String COLLECTION = "ignored";

  private DataCache mockDataCache;
  private QueryCache mockQueryCache;
  private CollectionSchema mockCollectionSchema;
  private final ObjectMapper objectMapper = new ObjectMapper();

  DashboardConfigResource testDashboardConfigResource;

  @BeforeMethod
  public void beforeMethod() throws Exception {
    mockDataCache = mock(DataCache.class);
    mockCollectionSchema = mock(CollectionSchema.class);
    mockQueryCache = mock(QueryCache.class);

    when(mockDataCache.getCollectionSchema(COLLECTION)).thenReturn(mockCollectionSchema);

    testDashboardConfigResource =
        new DashboardConfigResource(mockDataCache, mockQueryCache, null, null, objectMapper);
  }

  @Test
  public void testGetAllDimensions() throws Exception {
    testDashboardConfigResource.getAllDimensions(COLLECTION);
    verify(mockCollectionSchema).getDimensions();
  }

  @Test
  public void testGetDimensionsWithSelection() throws Exception {
    UriInfo mockUriInfo = mock(UriInfo.class);
    MultivaluedMap<String, String> queryParams = new MultivaluedMapImpl();
    queryParams.put("b", Arrays.asList("x", "y", "z"));
    when(mockUriInfo.getQueryParameters()).thenReturn(queryParams);
    when(mockCollectionSchema.getDimensions()).thenReturn(Arrays.asList("a", "b", "c"));
    Assert.assertEquals(testDashboardConfigResource.getDimensions(COLLECTION, mockUriInfo),
        Arrays.asList("a", "c"));
  }

  @Test
  public void testGetAllDimensionAliases() throws Exception {
    testDashboardConfigResource.getDimensionAliases(COLLECTION);
    verify(mockCollectionSchema).getDimensionAliases();
  }

  @Test
  public void testGetDimensionValues() throws Exception {
    // TODO lots of moving parts here, difficult to test easily.
  }

  @Test
  public void testGetMetrics() throws Exception {
    testDashboardConfigResource.getMetrics(COLLECTION);
    verify(mockCollectionSchema).getMetrics();
  }

  @Test
  public void testGetAllMetricAliases() throws Exception {
    testDashboardConfigResource.getMetricAliases(COLLECTION);
    verify(mockCollectionSchema).getMetricAliases();
  }

  @Test
  public void testGetMetricAliasesAsList() throws Exception {
    testDashboardConfigResource.getMetricAliasesAsList(COLLECTION);
    verify(mockCollectionSchema).getMetricAliases();
  }

}

@@ -1405,16 +1405,22 @@
 l, null,
+ null,
  objectM

Test class bugfix