/*
 * FindBugs - Find bugs in Java programs
 * Copyright (C) 2005 Dave Brosius <dbrosius@users.sourceforge.net>
 * Copyright (C) 2005 University of Maryland
 * 
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 * 
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 * 
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */
package edu.umd.cs.findbugs.detect;

import org.apache.bcel.Repository;
import org.apache.bcel.classfile.JavaClass;

import edu.umd.cs.findbugs.BugInstance;
import edu.umd.cs.findbugs.BugReporter;
import edu.umd.cs.findbugs.Detector;
import edu.umd.cs.findbugs.StatelessDetector;
import edu.umd.cs.findbugs.ba.AnalysisContext;
import edu.umd.cs.findbugs.ba.ClassContext;
import edu.umd.cs.findbugs.visitclass.Constants2;
import edu.umd.cs.findbugs.visitclass.PreorderVisitor;

public class RedundantInterfaces extends PreorderVisitor implements Detector, Constants2, StatelessDetector
{
	private BugReporter bugReporter;
	
	public RedundantInterfaces(BugReporter bugReporter) {
		this.bugReporter = bugReporter;
	}
	
	public Object clone() throws CloneNotSupportedException {
		return super.clone();
	}
	
	public void visitClassContext(ClassContext classContext) {
		JavaClass obj = classContext.getJavaClass();

		String superClassName = obj.getSuperclassName();
		if (superClassName.equals("java.lang.Object"))
			return;
		
		String[] interfaceNames = obj.getInterfaceNames();
		if ((interfaceNames == null) || (interfaceNames.length == 0))
			return;

		try {
			JavaClass superObj = obj.getSuperClass();
			
			for (int i = 0; i < interfaceNames.length; i++) {
				JavaClass inf = Repository.lookupClass(interfaceNames[i]);
				if (superObj.instanceOf(inf)) {
					bugReporter.reportBug( new BugInstance( this, "RI_REDUNDANT_INTERFACES", LOW_PRIORITY )
						.addClass(obj)
						.addClass(inf));
				}
			}
		} catch (ClassNotFoundException cnfe) {
			bugReporter.reportMissingClass(cnfe);
		}
	}

	public void setAnalysisContext(AnalysisContext analysisContext) {
	}
	
	public void report() {
	}
}

@@ -933,16 +933,98 @@
 etect;%0A%0A
+import java.util.Iterator;%0Aimport java.util.SortedSet;%0Aimport java.util.TreeSet;%0A%0A
 import o
@@ -2191,12 +2191,76 @@
 ();%0A
+%09%09%09SortedSet%3CString%3E redundantInfNames = new TreeSet%3CString%3E();%0A
 %09%09%09%0A
-
 %09%09%09f
@@ -2408,38 +2408,127 @@
 nf))
- %7B
 %0A%09%09%09%09%09
-bugReporter.reportBug(
+redundantInfNames.add(inf.getClassName());%0A%09%09%09%7D%0A%09%09%09%09%0A%09%09%09if (redundantInfNames.size() %3E 0) %7B%0A%09%09%09%09BugInstance bug =
  new
@@ -2587,32 +2587,33 @@
 RIORITY )%0A%09%09%09%09%09%09
+%09
 .addClass(obj)%0A%09
@@ -2610,23 +2610,107 @@
 ass(obj)
+;
 %0A%09%09%09%09
-%09%09
+Iterator%3CString%3E it = redundantInfNames.iterator();%0A%09%09%09%09while (it.hasNext())%0A%09%09%09%09%09bug
 .addClas
@@ -2716,18 +2716,23 @@
 ss(i
-nf
+t.next(
 ));%0A%09%09%09%09
 %7D%0A%09%09
@@ -2731,15 +2731,48 @@
 %09%09%09%09
-%7D
+%09%0A%09%09%09%09bugReporter.reportBug(bug);
 %0A%09%09%09%7D%0A
+%0A
 %09%09%7D 

refactor so that each src class only produces at most one bug report, even if it implements multiple interfaces that super classes implement. All are listed in the one report.