/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.camel.model.validator;

import javax.xml.bind.annotation.XmlAccessType;
import javax.xml.bind.annotation.XmlAccessorType;
import javax.xml.bind.annotation.XmlElementRef;
import javax.xml.bind.annotation.XmlType;

import org.apache.camel.Expression;
import org.apache.camel.Predicate;
import org.apache.camel.model.ExpressionNodeHelper;
import org.apache.camel.model.language.ExpressionDefinition;
import org.apache.camel.spi.Metadata;
import org.apache.camel.spi.Validator;

/**
 * Represents a predicate {@link Validator} which leverages expression or
 * predicates to perform content validation. A
 * {@link org.apache.camel.impl.validator.ProcessorValidator} will be created
 * internally with a
 * {@link org.apache.camel.processor.validation.PredicateValidatingProcessor}
 * which validates the message according to specified expression/predicates.
 * {@see ValidatorDefinition} {@see Validator}
 */
@Metadata(label = "validation")
@XmlType(name = "predicateValidator")
@XmlAccessorType(XmlAccessType.FIELD)
public class PredicateValidatorDefinition extends ValidatorDefinition {

    @XmlElementRef
    private ExpressionDefinition expression;

    public ExpressionDefinition getExpression() {
        return expression;
    }

    public void setExpression(ExpressionDefinition expression) {
        // favour using the helper to set the expression as it can unwrap some
        // unwanted builders when using Java DSL
        if (expression instanceof Expression) {
            this.expression = ExpressionNodeHelper.toExpressionDefinition((Expression)expression);
        } else if (expression instanceof Predicate) {
            this.expression = ExpressionNodeHelper.toExpressionDefinition((Predicate)expression);
        } else {
            this.expression = expression;
        }
    }

}

@@ -1068,43 +1068,8 @@
 on;%0A
-import org.apache.camel.Predicate;%0A
 impo
@@ -2212,60 +2212,8 @@
 DSL%0A
-        if (expression instanceof Expression) %7B%0A    
     
@@ -2290,16 +2290,17 @@
 ression)
+ 
 expressi
@@ -2307,229 +2307,8 @@
 on);
-%0A        %7D else if (expression instanceof Predicate) %7B%0A            this.expression = ExpressionNodeHelper.toExpressionDefinition((Predicate)expression);%0A        %7D else %7B%0A            this.expression = expression;%0A        %7D
 %0A   

Remove useless type tests identified by lgtm.com.