/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.flink.runtime.jobmaster.utils;

import org.apache.flink.runtime.jobmaster.JobResult;

import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;

/**
 * Testing utils surrounding the {@link JobResult}.
 */
public final class JobResultUtils {
	public static void assertSuccess(final JobResult result) {
		if (!result.isSuccess()) {
			if (result.getSerializedThrowable().isPresent()) {
				throw new AssertionError("Job failed.", result.getSerializedThrowable().get().deserializeError(JobResultUtils.class.getClassLoader()));
			} else {
				throw new AssertionError("Job was not successful but did not fail with an error.");
			}
		}
	}

	public static void assertIncomplete(final CompletableFuture<JobResult> result) {
		if (result.isDone()) {
			final JobResult jobResult;
			try {
				jobResult = result.get();
			} catch (InterruptedException | ExecutionException e) {
				// we already know it is done so this doesn't happen
				throw new AssertionError("Unexpected exception when processing finished future.", e);
			}

			if (jobResult.isSuccess()) {
				throw new AssertionError("Job finished successfully.");
			} else {
				// this is guarantee to fail with an error
				assertSuccess(jobResult);
			}
		}
	}
}

@@ -1158,337 +1158,50 @@
 %7B%0A%09%09
-if (!result.isSuccess()) %7B%0A%09%09%09if (result.getSerializedThrowable().isPresent()) %7B%0A%09%09%09%09throw new AssertionError(%22Job failed.%22, result.getSerializedThrowable().get().deserializeError(JobResultUtils.class.getClassLoader()));%0A%09%09%09%7D else %7B%0A%09%09%09%09throw new AssertionError(%22Job was not successful but did not fail with an error.%22);%0A%09%09%09%7D%0A%09%09%7D
+throwAssertionErrorOnFailedResult(result);
 %0A%09%7D%0A
@@ -1701,78 +1701,468 @@
 %09%09%09%09
-// this is guarantee to fail with an error%0A%09%09%09%09assertSuccess(jobResult
+throwAssertionErrorOnFailedResult(jobResult);%0A%09%09%09%7D%0A%09%09%7D%0A%09%7D%0A%0A%09private static void throwAssertionErrorOnFailedResult(final JobResult result) %7B%0A%09%09if (!result.isSuccess()) %7B%0A%09%09%09if (result.getSerializedThrowable().isPresent()) %7B%0A%09%09%09%09throw new AssertionError(%22Job failed.%22, result.getSerializedThrowable().get().deserializeError(JobResultUtils.class.getClassLoader()));%0A%09%09%09%7D else %7B%0A%09%09%09%09throw new AssertionError(%22Job was not successful but did not fail with an error.%22
 );%0A%09

Make JobResultUtils#assertIncomplete implementation more comprehensive