/*
 * 
 * 
 * Copyright (C) 2005 SIPfoundry Inc.
 * Licensed by SIPfoundry under the LGPL license.
 * 
 * Copyright (C) 2005 Pingtel Corp.
 * Licensed to SIPfoundry under a Contributor Agreement.
 * 
 * $
 */
package org.sipfoundry.sipxconfig.site.admin;

import org.apache.tapestry.AbstractComponent;
import org.apache.tapestry.IRequestCycle;
import org.apache.tapestry.callback.ICallback;
import org.apache.tapestry.html.BasePage;
import org.apache.tapestry.valid.IValidationDelegate;
import org.apache.tapestry.valid.ValidationConstraint;
import org.sipfoundry.sipxconfig.common.ExtensionPool;
import org.sipfoundry.sipxconfig.common.ExtensionPoolContext;
import org.sipfoundry.sipxconfig.components.TapestryUtils;

public abstract class ExtensionPoolsPage extends BasePage {

    public static final String PAGE = "ExtensionPools";

    /**
     * Properties
     */
    
    public abstract ExtensionPoolContext getExtensionPoolContext();
    public abstract void setExtensionPoolContext(ExtensionPoolContext pool);
    
    public abstract ExtensionPool getUserExtensionPool();
    public abstract void setUserExtensionPool(ExtensionPool pool);
    
    public abstract ICallback getCallback();
    public abstract void setCallback(ICallback callback);
    
    /**
     * Listeners
     */  
    public void commit(IRequestCycle cycle_) {
        // Proceed only if Tapestry validation succeeded
        if (!TapestryUtils.isValid(this)) {
            return;
        }
        
        // Complain if the extension pool upper limit is lower than the lower limit
        ExtensionPool pool = getUserExtensionPool();
        if (pool.getFirstExtension() != null && pool.getLastExtension() != null) {
            if (pool.getLastExtension().intValue() < pool.getFirstExtension().intValue()) {
                recordError("message.lastExtensionTooSmall");
            }
        }
        
        // For now, we are not letting the user edit the pool's nextExtension value,
        // which controls where to start looking for the next free extension.
        // Set it to be the same as the start of the range.
        pool.setNextExtension(pool.getFirstExtension());
        
        getExtensionPoolContext().saveExtensionPool(pool);
    }
    
    /**
     * Utilities
     */  
    private void recordError(String messageId) {
        IValidationDelegate delegate = TapestryUtils.getValidator((AbstractComponent) getPage());
        delegate.record(getMessage(messageId), ValidationConstraint.TOO_SMALL);
    }
    
}

@@ -1853,16 +1853,40 @@
 mall%22);%0A
+                return;%0A
         

Fix XCF-599 for real. Sathya found (thanks for keeping me honest!) that although you get an error when you try to set the upper limit of the ext pool below the lower limit, nonetheless the limits are still updated to these bogus values. Now they are not.