/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 * 
 */

package org.apache.jmeter.control;

import java.io.Serializable;

import org.apache.jmeter.samplers.Sampler;
import org.apache.jmeter.testelement.property.BooleanProperty;
import org.apache.jmeter.testelement.property.IntegerProperty;
import org.apache.jmeter.testelement.property.JMeterProperty;
import org.apache.jmeter.testelement.property.StringProperty;

/**
 * @author Michael Stover
 * @author Thad Smith
 * @version $Revision$
 */
public class LoopController extends GenericController implements Serializable {

	private final static String LOOPS = "LoopController.loops"; // $NON-NLS-1$

	/*
	 * TODO: eliminate this setting?
	 * Most places assume that forever is the same as loopcount = -1 or < 0,
	 * so having a separate flag is potentially ambiguous.
	 * In fact, this already happens with ThreadGroup which can set forever = false and loops = -1
	 */
	private final static String CONTINUE_FOREVER = "LoopController.continue_forever"; // $NON-NLS-1$

	private transient int loopCount = 0;

	public LoopController() {
		setContinueForever(true);
	}

	public void setLoops(int loops) {
		setProperty(new IntegerProperty(LOOPS, loops));
	}

	public void setLoops(String loopValue) {
		setProperty(new StringProperty(LOOPS, loopValue));
	}

	public int getLoops() {
		try {
			JMeterProperty prop = getProperty(LOOPS);
			return Integer.parseInt(prop.getStringValue());
		} catch (NumberFormatException e) {
			return 0;
		}
	}

	public String getLoopString() {
		return getPropertyAsString(LOOPS);
	}

	/**
	 * Determines whether the loop will return any samples if it is rerun.
	 * 
	 * @param forever
	 *            true if the loop must be reset after ending a run
	 */
	public void setContinueForever(boolean forever) {
		setProperty(new BooleanProperty(CONTINUE_FOREVER, forever));
	}

	private boolean getContinueForever() {
		return getPropertyAsBoolean(CONTINUE_FOREVER);
	}

    /*
     * (non-Javadoc)
     * 
     * @see org.apache.jmeter.control.Controller#next()
     */
    public Sampler next() {
        if(endOfLoop()) {
            return null;
        }
        else {
            return super.next();
        }
    }

	private boolean endOfLoop() {
		final int loops = getLoops();
		return (loops > -1) && (loopCount >= loops);
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.apache.jmeter.control.GenericController#nextIsNull()
	 */
	protected Sampler nextIsNull() throws NextIsNullException {
		reInitialize();
		if (endOfLoop()) {
			if (!getContinueForever()) {
				setDone(true);
			} else {
				resetLoopCount();
			}
			return null;
		}
		return next();
	}

	protected void incrementLoopCount() {
		loopCount++;
	}

	protected void resetLoopCount() {
		loopCount = 0;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.apache.jmeter.control.GenericController#getIterCount()
	 */
	protected int getIterCount() {
		return loopCount + 1;
	}

	/*
	 * (non-Javadoc)
	 * 
	 * @see org.apache.jmeter.control.GenericController#reInitialize()
	 */
	protected void reInitialize() {
		setFirst(true);
		resetCurrent();
		incrementLoopCount();
		recoverRunningVersion();
	}
}
@@ -1169,75 +1169,50 @@
 %0A * 
-@author Michael Stover%0A * @author Thad Smith%0A * @version $Revision$
+Class that implements the Loop Controller.
 %0A */
@@ -1373,272 +1373,656 @@
 -1$%0A
-%0A%09/*%0A%09 * TODO: eliminate this setting?%0A%09 * Most places assume that forever is the same as loopc
+%09%0A%09private static final long serialVersionUID = 232L;%0A%0A%09/*%0A%09 * In spite of the name, this is actually used to determine if the loop controller is repeatable.%0A%09 * %0A%09 * The value is only used in nextIsNull() when the loop end condition has been detected:%0A%09 * If forever==true, then it calls resetLoopC
 ount
- = -1 or %3C 0,%0A%09 * so having a separate flag is potentially ambiguous.%0A%09 * In fact, this already happens wi
+(), otherwise it calls setDone(true).%0A%09 * %0A%09 * Loop Controllers always set forever=true, so that they will be executed next time%0A%09 * the parent invokes them.%0A%09 * %0A%09 * Thread Group sets the value false, so nextIsNull() sets done, and 
 th
+e
  Thread
+ 
 Group w
-hich can set forever = false and loops = -1
+ill not be repeated.%0A%09 * However, it's not clear that a Thread Group could ever be repeated.  
 %0A%09 *
@@ -2208,16 +2208,24 @@
 eForever
+_private
 (true);%0A
@@ -2896,24 +2896,127 @@
  forever) %7B%0A
+%09%09setContinueForever_private(forever);%0A%09%7D%0A%0A%09private void setContinueForever_private(boolean forever) %7B%0A
 %09%09setPropert

Document meaning of forever setting; constructor should not call overridable method