/**
 * @license
 * Copyright 2018 The FOAM Authors. All Rights Reserved.
 * http://www.apache.org/licenses/LICENSE-2.0
 */

package foam.nanos.auth;

import foam.core.FObject;
import foam.core.X;
import foam.dao.DAO;
import foam.dao.ProxyDAO;
import foam.util.SafetyUtil;

/**
 * Custom authentication for groupDAO
 *
 * Features:
 *   - If creating a group, you can only give it permissions implied by those
 *     that you already have.
 *   - If updating a group, you can't modify the permissions array to have a
 *     permission that isn't implied by one you have.
 *   - If updating a group, you can't modify the parent of the group such that
 *     the group gains a permission that isn't implied by one you have.
 */
public class AuthenticatedGroupDAO extends ProxyDAO {
  public AuthenticatedGroupDAO(X x, DAO delegate) {
    super(x, delegate);
  }

  @Override
  public FObject put_(X x, FObject obj) {
    checkUserHasAllPermissionsInGroupAndAncestors(x, (Group) obj);
    return super.put_(x, obj);
  }

  private void checkUserHasAllPermissionsInGroupAndAncestors(X x, Group toCheck) {
    Group group = toCheck;
    checkUserHasAllPermissionsInGroup(x, group);
    while ( getAncestor(x, group) != null ) {
      group = getAncestor(x, group);
      checkUserHasAllPermissionsInGroup(x, group);
    }
  }
  
  // Make sure that the user has all permissions in the given group.
  private void checkUserHasAllPermissionsInGroup(X x, Group group) {
    AuthService auth = (AuthService) x.get("auth");
    Permission[] permissions = group.getPermissions();
    for ( Permission permission : permissions ) {
      String id = permission.getId();
      if ( ! auth.check(x, id) ) {
        throw new AuthorizationException("Permission Denied. You do not have the '" + id + "' permission.");
        }
     }
  }

  // returns ancestor of a group if it exists, null otherwise null
  private Group getAncestor(X x, Group group) {    
    String ancestorGroupId = group.getParent();
    if ( SafetyUtil.isEmpty(ancestorGroupId) ) {
      return null;
    }
    Group ancestor = (Group) getDelegate().find_(x, ancestorGroupId);
    if ( ancestor == null ) {
      throw new RuntimeException("The '" + group.getId() + "' group has a null ancestor named '" + ancestorGroupId + "'.");
    }
    return ancestor;
  }
}

@@ -1009,30 +1009,29 @@
 j);%0A  %7D%0A%0A  p
-rivate
+ublic
  void checkU
@@ -1387,22 +1387,21 @@
 oup.%0A  p
-rivate
+ublic
  void ch
@@ -1797,21 +1797,18 @@
 ;%0A      
-  
 %7D%0A
- 
     %7D%0A  
@@ -1856,21 +1856,16 @@
  exists,
- null
  otherwi
@@ -1879,14 +1879,13 @@
 %0A  p
-rivate
+ublic
  Gro

Make helper methods public and fix indentation