/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.jmeter.monitor.parser;

import java.io.ByteArrayInputStream;
import java.io.IOException;

import org.xml.sax.SAXException;
import org.xml.sax.InputSource;

import javax.xml.parsers.ParserConfigurationException;
import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;

import org.apache.jmeter.monitor.model.ObjectFactory;
import org.apache.jmeter.monitor.model.Status;
import org.apache.jmeter.samplers.SampleResult;
import org.apache.jorphan.logging.LoggingManager;
import org.apache.log.Logger;

public abstract class ParserImpl implements Parser {

    private static final Logger log = LoggingManager.getLoggerForClass();

    private SAXParserFactory PARSERFACTORY = null;

    private SAXParser PARSER = null;

    private MonitorHandler DOCHANDLER = null;

    private ObjectFactory FACTORY = null;

    /**
     *
     */
    public ParserImpl(ObjectFactory factory) {
        super();
        this.FACTORY = factory;
        try {
            PARSERFACTORY = SAXParserFactory.newInstance();
            PARSER = PARSERFACTORY.newSAXParser();
            DOCHANDLER = new MonitorHandler();
            DOCHANDLER.setObjectFactory(this.FACTORY);
        } catch (SAXException e) {
            log.error("Failed to create the parser",e);
        } catch (ParserConfigurationException e) {
            log.error("Failed to create the parser",e);
        }
    }

    /**
     * parse byte array and return Status object
     *
     * @param bytes
     * @return Status
     */
    public Status parseBytes(byte[] bytes) {
        try {
            InputSource is = new InputSource();
            is.setByteStream(new ByteArrayInputStream(bytes));
            PARSER.parse(is, DOCHANDLER);
            return DOCHANDLER.getContents();
        } catch (SAXException e) {
            log.error("Failed to parse the bytes",e);
            // let bad input fail silently
            return DOCHANDLER.getContents();
        } catch (IOException e) { // Should never happen
            log.error("Failed to read the bytes",e);
            // let bad input fail silently
            return DOCHANDLER.getContents();
        }
    }

    /**
     * @param content
     * @return Status
     */
    public Status parseString(String content) {
        return parseBytes(content.getBytes());
    }

    /**
     * @param result
     * @return Status
     */
    public Status parseSampleResult(SampleResult result) {
        return parseBytes(result.getResponseData());
    }

}

@@ -900,16 +900,45 @@
 ception;
+%0Aimport java.io.StringReader;
 %0A%0Aimport
@@ -1495,32 +1495,38 @@
 );%0A%0A    private 
+final 
 SAXParserFactory
@@ -1522,88 +1522,35 @@
 rser
-Factory PARSERFACTORY = null;%0A%0A    private SAXParser PARSER = null;%0A%0A    private
+ PARSER;%0A%0A    private final
  Mon
@@ -1571,23 +1571,16 @@
 CHANDLER
- = null
 ;%0A%0A    p
@@ -1586,16 +1586,22 @@
 private 
+final 
 ObjectFa
@@ -1617,15 +1617,8 @@
 TORY
- = null
 ;%0A%0A 
@@ -1747,39 +1747,128 @@
     
-try %7B%0A            PARSERFACTORY
+SAXParser parser = null;%0A        MonitorHandler handler = null;%0A        try %7B%0A            SAXParserFactory parserFactory
  = S
@@ -1914,30 +1914,30 @@
     
-PARSER = PARSERFACTORY
+parser = parserFactory
 .new
@@ -1961,26 +1961,23 @@
         
-DOCHANDLER
+handler
  = new M
@@ -2005,26 +2005,23 @@
         
-DOCHANDLER
+handler
 .setObje
@@ -2245,32 +2245,87 @@
 %22,e);%0A        %7D%0A
+        PARSER = parser;%0A        DOCHANDLER = handler;%0A
     %7D%0A%0A    /**%0A 
@@ -3198,47 +3198,598 @@
     
-return parseBytes(content.getByte
+try %7B%0A            InputSource is = new InputSource();%0A            is.setCharacterStream(new StringReader(content));%0A            PARSER.parse(is, DOCHANDLER);%0A            return DOCHANDLER.getContents();%0A        %7D catch (SAXException e) %7B%0A            log.error(%22Failed to parse the String%22,e);%0A            // let bad input fail silently%0A            return DOCHANDLER.getContents();%0A        %7D catch (IOException e) %7B // Should never happen%0A            log.error(%22Failed to read the String%22,e);%0A            // let bad input fail silently%0A            return DOCHANDLER.getContent
 s()
-)
 ;%0A
+        %7D%0A
     

Tidy up class; parse string directly rather than converting to byte[] first