/*
 * FindBugs - Find bugs in Java programs
 * Copyright (C) 2003,2004 University of Maryland
 * 
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 * 
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 * 
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

package edu.umd.cs.findbugs.detect;

import edu.umd.cs.findbugs.BugInstance;
import edu.umd.cs.findbugs.BugReporter;
import edu.umd.cs.findbugs.BytecodeScanningDetector;
import edu.umd.cs.findbugs.visitclass.Constants2;
import org.apache.bcel.classfile.Code;

public class FindFieldSelfAssignment extends BytecodeScanningDetector implements Constants2 {
	private BugReporter bugReporter;
	int state;


	public FindFieldSelfAssignment(BugReporter bugReporter) {
		this.bugReporter = bugReporter;
	}

	public void visit(Code obj) {
		state = 0;
		super.visit(obj);
	}


	String f;

	public void sawOpcode(int seen) {

		switch (state) {
		case 0:
			if (seen == ALOAD_0)
				state = 1;
			break;
		case 1:
			if (seen == ALOAD_0)
				state = 2;
			else
				state = 0;
			break;
		case 2:
			if (seen == GETFIELD) {
				state = 3;
				f = getRefConstantOperand();
			} else
				state = 0;
			break;
		case 3:
			if (seen == PUTFIELD && getRefConstantOperand().equals(f)) {

				bugReporter.reportBug(new BugInstance(this, "SA_FIELD_SELF_ASSIGNMENT", NORMAL_PRIORITY)
				        .addClass(getClassName())
				        .addMethod(getClassName(), getMethodName(), getMethodSig())
				        .addField(getDottedClassConstantOperand(), getNameConstantOperand(),
				                getDottedSigConstantOperand(), false)
				        .addSourceLine(this));
			}
			state = 0;
		}
	}

}

@@ -1923,234 +1923,60 @@
 lass
-(getClassName())%0A%09%09%09%09        .addMethod(getClassName(), getMethodName(), getMethodSig())%0A%09%09%09%09        .addField(getDottedClassConstantOperand(), getNameConstantOperand(),%0A%09%09%09%09                getDottedSigConstantOperand(), false
+AndMethod(this)%0A%09%09%09%09        .addReferencedField(this
 )%0A%09%09

Use better methods for adding annotations to the bug instance