Add missing libretro cores

Motivation for this change
We are missing some RetroArch cores, so this PR will add some of them.
The idea is not to package everything from upstream though (some of them are even impossible since they're missing the necessary files, e.g.: DuckStation). However I want to package at least some of the more interesting ones.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

melonds is also an interesting core that I think should be added.

melonds is also an interesting core that I think should be added.

Done.

I think that is it for now, opening this PR for review.

Just an explanation on why I am adding those specific cores:

SwanStation: fork of DuckStation, that is probably one of the most interesting PSX emulators right now. It has features like upscalling, PXGP, widescreen, etc., while being reasonable fast and accurate (not its main focus).
bsnes: the best and most update fork of Near contributions to the SNES community. Probably the recommended emulator if you don't want improvements.
bsnes-hd: this is fun, running SNES games in high definition and widescreen. Doesn't work in all cases, but where it does it looks beautiful.
bsnes-mercury-{balanced,accuracy}: this is the only available fork of bsnes that still has the old, more performant, balanced and accuracy cores, so it seems a waste to not enable them. Should be useful for less powerful hardware (aarch64-linux maybe?).
mesen-s: another accuracy-focused SNES emulator that also supports GB/GBC. Have some interesting features like overclock, so maybe worth it in some cases (bsnes is still recommended if you don't care about improvements).
melonds: seems fair, there isn't many Nintendo DS emulators in RetroArch and this one seems very competent.

Some cores that I don't think it is worth the addition so I didn't package them:

higan-snes: the higan fork of libretro is out-of-date, higan itself was kinda abandoned since it was (eventually) replaced by ares. So doesn't seem worth to have, bsnes is newer and better.
bsnes C++98: an older version of bsnes that only makes sense on very odd targets that don't have a working C++11 compiler.

There are also cores for more obscure targets that I don't care, however we can always add it later if someone is interested.

Result of nixpkgs-review pr 146958 run on x86_64-linux 1

88 packages built:

kodiPackages.libretro-genplus
kodiPackages.libretro-mgba
kodiPackages.libretro-snes9x
libretro.atari800
libretro.beetle-gba
libretro.beetle-lynx
libretro.beetle-ngp
libretro.beetle-pce-fast
libretro.beetle-pcfx
libretro.beetle-psx
libretro.beetle-psx-hw
libretro.beetle-saturn
libretro.beetle-snes
libretro.beetle-supergrafx
libretro.beetle-vb
libretro.beetle-wswan
libretro.blastem
libretro.bluemsx
libretro.bsnes
libretro.bsnes-hd
libretro.bsnes-mercury
libretro.bsnes-mercury-balanced
libretro.bsnes-mercury-performance
libretro.citra
libretro.desmume
libretro.desmume2015
libretro.dolphin
libretro.dosbox
libretro.eightyone
libretro.fbalpha2012
libretro.fbneo
libretro.fceumm
libretro.flycast
libretro.fmsx
libretro.freeintv
libretro.gambatte
libretro.genesis-plus-gx
libretro.gpsp
libretro.gw
libretro.handy
libretro.hatari
libretro.mame
libretro.mame2000
libretro.mame2003
libretro.mame2003-plus
libretro.mame2010
libretro.mame2015
libretro.mame2016
libretro.melonds
libretro.mesen
libretro.mesen-s
libretro.meteor
libretro.mgba
libretro.mupen64plus
libretro.neocd
libretro.nestopia
libretro.np2kai
libretro.o2em
libretro.opera
libretro.parallel-n64
libretro.pcsx_rearmed
libretro.picodrive
libretro.play
libretro.ppsspp
libretro.prboom
libretro.prosystem
libretro.quicknes
libretro.sameboy
libretro.scummvm
libretro.smsplus-gx
libretro.snes9x
libretro.snes9x2002
libretro.snes9x2005
libretro.snes9x2010
libretro.stella
libretro.stella2014
libretro.swanstation
libretro.tgbdual
libretro.thepowdertoy
libretro.tic80
libretro.vba-m
libretro.vba-next
libretro.vecx
libretro.virtualjaguar
libretro.yabause
retroarch
retroarchBare
retroarchFull

CC @aanderse.

I think branch off for 21.11 already occurred. We should probably backport this, if so.
Looks good @thiagokokada :rocket:

I think branch off for 21.11 already occurred. We should probably backport this, if so.

Yeah, I already marked this PR to be backported.

@aanderse Sorry to bother you, but if possible I would like to merge this PR before the 21.11 release (just to avoid the issue with the beetle-saturn-hw that I removed).

Sorry this slipped by me. It looks good to me. Let's ship it!


Updates :D

^

You cant update mixin :). The later versions need a newer version of ASM that is not present in this version of Forge. I can theoretically add a fix for that but it is really quite complex for honestly not much gain.

oh main :( ok im gonna open the pr again


Impossible to create WinUI 3 C++ Desktop Project

Describe the bug
It is impossible to create a WinUI C++ Desktop Project in Visual Studio Community 2019 Preview
Steps to reproduce the bug

Steps to reproduce the behavior:

Open VS 2019 Preview
Create new Blank App, Packaged (WinUI in Desktop) C++ App

Expected behavior
Should create a new WinUI C++ Desktop app
Screenshots

I've installed all components with a similar name in the installer, there is none that exactly matches that name, does not help either that the names are translated so its really really hard to Google for this issue...
Version Info

NuGet package version:
Can't tell as I dont end up with a working project that has it.

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)
Yes

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

(Tested on Windows 10 Pro 1909 18363.900)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Figured it out.
You need to search for it in the Project Templates not in the Installer. Create a Project with it and it will launch the installer and install the needed tools. (It will not actually create a project, just install the tools)

for people coming across this later, there is also #2492 with some info on what you need to check in the installer


How to check valid expiry date ?

Hey,
This library is just a credit card viewer, it doesn't care about validation.
The package that we use to test card numbers, payment, have some validation methods so you can try those.


Added json extensions module

Improves syntax with type inference and improves type safety of LibGDX Json reader and writer. The module doesn't add anything new, just reified extension function.
I didn't do the readme yet because I realized this module doesn't add any functionality apart from syntax, unlike other modules. For the same reason, only minimal tests were made.

Thanks for the PR, I'll review it soon.
Keep in mind that the PRs should be made to develop branch rather than master. I know it's a bit confusing since the master branch is the default one, but this is deliberate - I want people to browse the relevant code that they would find in the current Maven release rather than new features, which might not be included yet.

I didn't do the readme yet because I realized this module doesn't add any functionality apart from syntax, unlike other modules.

That's not entirely true, ktx-math and ktx-collections are basically syntax sugar modules and they still list all of the functionalities and show you some practical examples. I'd like to keep this sort of documentation for every module. I could still accept the PR without it, but keep in mind I'll not merge it into master and include in the next release before writing such documentation myself. I think the documentation is what made people use and contribute to this library in the first place. :)

For the same reason, only minimal tests were made.

I agree that you shouldn't test the whole LibGDX JSON API, but please make sure each included extension method is tested by at least one test case.

Keep in mind that the PRs should be made to develop branch rather than master.

If I did it correctly, the commit was made on a new maltaisn/json branch, branched from the maltaisn/develop branch (which may not be up-to-date with libktx/develop). I created a new branch since I intended to do many commits (which I haven't made yet).

I agree that you shouldn't test the whole LibGDX JSON API, but please make sure each included extension method is tested by at least one test case.

I'll make the tests soon.
I'll also do the readme following the structure of other readmes, and mentioning the fact that other serialization libraries exist and should be preferred in some cases.

You used the correct branch, but made the request to merge into libktx:master rather than libktx:develop. Don't worry, I changed it already.

I added some tests and made a readme draft, you can complete it if anything is missing.

There are only minor changes required (e.g. missing trailing new lines in some files), but I can correct these manually. Thanks for the contribution.

Somehow passing name: String, jsonData: JsonValue in that order feels wrong. I'd include jsonData as the first parameter in most methods, but I understand consistency with LibGDX API might be more important in this case.

Not sure if you were aware of this, but you can use Kotlin data classes along with LibGDX Json API as long as you manage to provide defaults for each variable. You can check the latest commits to develop to see my slight refactoring.
Anyway, a snapshot of the libraries is being uploaded to Maven as I'm writing this. Thanks again for the contribution.

Somehow passing name: String, jsonData: JsonValue in that order feels wrong.

As you said that was for consistency with the original API but I agree the order feels wrong. In fact, if we put name after, the two readValue methods could be merged into a single one with a default argument value of null for name. (Same for readArrayValue)

Not sure if you were aware of this, but you can use Kotlin data classes along with LibGDX Json API as long as you manage to provide defaults for each variable. You can check the latest commits to develop to see my slight refactoring.

No I didn't know thanks! I just checked the Kotlin documentation:

Note that, as described in Secondary Constructors, if a class has default values for all constructor parameters, a public no-argument constructor will be generated for it. This works even if the `@JvmOverloads annotation is not specified.

So it should work with all classes not just data classes.

As you said that was for consistency with the original API but I agree the order feels wrong. In fact, if we put name after, the two readValue methods could be merged into a single one with a default argument value of null for name. (Same for readArrayValue)

Now I'm tempted to do that. Our goal is to improve LibGDX after all.

So it should work with all classes not just data classes.

Yes, it's just that data classes are the most useful in terms of serialized data objects.


AlignedStorage and InstanceStorage types

These are two untyped storage types that can be used in Phobos
and in user code when there's a need for specific aligned space.
E.g. we could use this as static storage to emplace() objects
instead of allocating them with GC, where functions need to be made @nogc.

Not sure why tests would fail on win32. Can anyone offer insight?

Gah... So there is no way of telling at compile time whether invariants are enabled or not?

@andralex I tagged you because I can't remember if it's all Phobos symbols, or only std.algorithm/std.range that you want to be notified of.

@andralex This need not necessarily be a member, it could be a local, a global, an allocated storage...
I'll be fixing and rebasing this shortly.

@thewilsonator unstall please, I'm resuming this :)

std/typecons.d(9074:8)[warn]: Public declaration 'AlignedStorage' has no documented example.
std/typecons.d(9108:6)[warn]: Trusting a whole scope is a bad idea, `@trusted` should only be attached to the functions individually
std/typecons.d(9119:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9128:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9152:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9171:10)[warn]: Public declaration 'InstanceStorage' has no documented example.
std/typecons.d(9171:33)[warn]: If constraints should have the same indentation as the function
std/typecons.d(9184:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9194:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9210:1)[warn]: A unittest should be annotated with at least @safe or @system
std/typecons.d(9232:1)[warn]: A unittest should be annotated with at least @safe or @system

As far as convincing goes, there are already places in the standard library that use this kind of storage. Allocators is one, Scoped is the other. There may be more, this is just off the top of my head.

@andralex @atilaneves The argument given by @radcapricorn is that the invariant safeguards against misaligned moves.

But why necessarily in the standard library?

I am going to close this as @radcapricorn  seems to have abandoned it and @atilaneves and @andralex are against adding it to the standard library.
@radcapricorn please reopen if you ever turn back it.


VOTLE on Cx branch not working for NSA!

Hi, @herlesupreeth
I've tested the open5gs_hss_cx after the last commit, but it wont conenct to Volte Network!
smf      | 07/09 11:26:49.151: [smf] INFO: [Added] Number of SMF-Sessions is now 2 (../src/smf/context.c:3053)
smf      | 07/09 11:26:49.151: [smf] INFO: UE IMSI[001010123456795] APN[ims] IPv4[<IP_ADDRESS>] IPv6[] (../src/smf/s5c-handler.c:255)
upf      | 07/09 11:26:49.156: [upf] INFO: [Added] Number of UPF-Sessions is now 2 (../src/upf/context.c:206)
upf      | 07/09 11:26:49.157: [upf] INFO: UE F-SEID[UP:0xf71 CP:0x22c] APN[ims] PDN-Type[1] IPv4[<IP_ADDRESS>] IPv6[] (../src/upf/context.c:483)
upf      | 07/09 11:26:49.157: [upf] INFO: UE F-SEID[UP:0xf71 CP:0x22c] APN[ims] PDN-Type[1] IPv4[<IP_ADDRESS>] IPv6[] (../src/upf/context.c:483)
smf      | 07/09 11:26:49.157: [smf] WARNING: Unknown PCO ID:(0x2) (../src/smf/context.c:2996)
smf      | 07/09 11:26:49.157: [smf] WARNING: Unknown PCO ID:(0x1a) (../src/smf/context.c:2996)
smf      | 07/09 11:26:49.157: [smf] WARNING: Unknown PCO ID:(0x23) (../src/smf/context.c:2996)
smf      | 07/09 11:26:49.157: [smf] WARNING: Unknown PCO ID:(0x24) (../src/smf/context.c:2996)

The request goes to the Core but it wont respond!
Steps to reproduce:
git clone https://github.com/herlesupreeth/docker_open5gs
sleep 2
cd docker_open5gs && git checkout open5gs_hss_cx && nano docker-compose.yaml nsa-deploy.yaml sa-deploy.yaml .env && cd base
###############################################################################################
## Uncomment ports for MME, SGWU, AMF
&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&
For .env file:
Change Docker_host_ip=<IP_ADDRESS> and SGWU_ADVERTISE_IP=<IP_ADDRESS> ,UE_IPV4_INTERNET=<IP_ADDRESS>/24, UE_IPV4_IMS=<IP_ADDRESS>/24
###############################################################################################

docker build --no-cache --force-rm -t docker_open5gs . && cd ../ims_base && docker build --no-cache --force-rm -t docker_kamailio .  && cd .. && set -a && source .env && docker compose build --no-cache

cd ~/docker_open5gs
sudo ip link set mtu 1400 dev $INTERFACE
set -a
source .env
docker compose -f nsa-deploy.yaml up -d

So i have uncommented AMF, MME,SGWU ports in docker-compose.yaml , nsa-deploy.yaml
also uncommented AMF ports in sa-deploy.yaml
Also in .env file changed Docker_host_ip, sgwu advertise ip and also changed UE_IPV4_INTERNET=<IP_ADDRESS>/24, UE_IPV4_IMS=<IP_ADDRESS>/24
and then docker compose -f nsa-deploy.yaml up -d

but the internet is not available!
any steps i missed?

Do i need to change SMF or UPF config as well?
I don't want to use 5G but just 4G network + VOLTE
Please find the traces bellow:
volte_NW_9_7_23.zip
I dont see any pcscf, ... activity!
Do i need to use docker-compose up? (without NSA)

With Docker Compose up
without the  -f nsa-deploy.yaml it works well!


Improve safety checks

When setting an array that is already bound to another key, it should throw an error.
When setting an object that is bound to a key, it should throw an error.
Prefer WeakMap over hidden property, guarantees no collision. may not be as performant.

Done https://github.com/0x8890/simulacra/commit/4fd8ab20a8640b228a08f05408764a65655d606e.


Social Media Sharing

Right now users need to download the image, then share it to social media. It would be helpful to have sharing buttons on the image so it can be shared directly.

Perhaps something like this would work? https://www.jqueryscript.net/social-media/jQuery-Plugin-For-Image-Social-Share-Overlay-socialpic.html

I don't think the overlays are going to work with the way images are just data:image blocks of binary. We'll need some kind of instructions for people telling them how to save their images.

Instructions are now cleared about what to do. I was worried the personal gallery would confuse people into thinking their images were saved on the server, so I removed that option, so now there is only one thing to do with your chart.


Added description for Tenant parameter

https://github.com/MicrosoftDocs/office-docs-powershell/issues/4100

Docs Build status updates of commit 4552566:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 4552566:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Remove-CsVoiceNormalizationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7ab60bb:
:clock10: Full build: the average full build time is 11 min(s) 46 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 7ab60bb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Remove-CsVoiceNormalizationRule.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ref #132, add preliminary implementation of bounding box

[ ] Move FOV-label processing to a function.
[ ] Add a test on the output table (perform task, then read from disk, check something).
[ ] Check overlap, at the FOV level.


[Feature Request] Logs to be able to inspect and diagnose from

What's the problem?
As #1085 stated: logging inspect ability is useful when I encountered some bugs and me as being a developer could help and diagnostic. I've encountered several bugs when try to use it:

Indexing and processing stucked
Failed to send chat messages with GPT (possibly failed to send requests?)

And I have no ways to find out what is wrong, am I missing something or network breaks, therefor bug report involves with such ability.
What's the solution?

Provide a way to diagnostic, or view logs when user has the ability to do

diagnostic tool to generate from when reporting bugs
log inspect tools for users, or physical log files to be find with guides in documentations
maybe devtools or similar tools for users to interact with when encountered network issues, frontend bugs

Additional context
None.

Hi @nekomeowww, bloop writes logs from bleep (the server) to disk. Depending on your OS you can find them at:

~/Library/Application\ Support/ai.bloop.bloop/bleep/logs
%APPDATA%/bloop/bleep/logs
~/.local/share/bloop/bleep/logs

Agree that we can make this more prominent in the documentation.

Nicely. Can I do something for the documentation as contribution?


Deploy to final host machine

Problem:
The vis system needs to be deployed to the new host machine once it is set up in the in the display room by @pclemow
Proposed Solution:
Installed on the machine:

Docker
Python
pip install pyyaml
OpenVidu - needs to be installed and deployed, follow this process: https://docs.openvidu.io/en/stable/deployment/ce/on-premises/

Then you can deploy the vis system. Simplest way would be to clone this repo into a location like /opt/gridlington/deployment/ and run bash run.sh. There might be a permissions issue with docker, then try sudo bash run.sh
Check logs with docker compose logs from inside this directory. Specifically check the dash app logs with docker compose logs dash
Additional context:
Some small changes will be required. Namely:

The OPENVIDU_HOST environment variable will need to be updated to where the openvidu client is running. I think this should be done by changing the hard-coded location to using the {ip} variable and the appropriate port (note it needs to be https)
I had to change the configuration for openvidu to run on port 4443 instead of 443 because those ports were being used by the datahub. It might be necessary again, or the datahub will need to use 4443 in the Caddy config instead (datahub using 4443 will required changing the ports in the environment feels defined by configure.py)

The vis system has be deployed in the host machine with the following caveats:

We did not deployed OpenVidu as it is used only to connect the NMX views, which seem to be causing too much trouble at the moment with all the WebRTC stuff, so they are being displayed directly without going through our application.
Running run.sh resulted in a production configuration being setup. For some reason, this did not work as docker-compose was complaining that a boolean value for this entry was not valid. So we end up running the develop configuration.

@tsmbland , did I missed anything in relation to what we deployed for the vis system?

Phil will review the current implementation over the next few weeks - screens content, layout, L&F, etc. - and will provide feedback on things that needs changing. This will be done, most likely, by him but with our support.

@tsmbland , did I missed anything in relation to what we deployed for the vis system?

No I think that covers it. Thinking about it we would have had to run in develop mode anyway because if the LIVE_MODEL flag is set to True the vis system will try and connect to the DataHub rather than using the pre-set data (either that or we would have had to manually set LIVE_MODEL back to False). Presumably this is something we'd want easier control over, i.e. easy switching between the live model and preset data?


Change the name of msbuild path variables

[Current coverage][cc-pull] is 72.47%

Merging [#1][cc-pull] into [CB-11548][cc-base-branch] will decrease coverage by 0.15%

@@           CB-11548         #1   diff @@
==========================================
  Files            14         14
  Lines          1929       1929
  Methods         358        358
  Messages          0          0
  Branches        389        389
==========================================
- Hits           1401       1398     -3
- Misses          528        531     +3
  Partials          0          0

Powered by Codecov. Last updated by [bd2f1b7...7030f25][cc-compare]
[cc-base-branch]: https://codecov.io/gh/vladimir-kotikov/cordova-windows/branch/CB-11548?src=pr
[cc-compare]: https://codecov.io/gh/vladimir-kotikov/cordova-windows/compare/bd2f1b798d54a550411b31ac5319516be69db817...7030f2567506d868081003f2c8b4f606eca3357c?src=pr
[cc-pull]: https://codecov.io/gh/vladimir-kotikov/cordova-windows/pull/1?src=pr


bug fix: malformed node or string

Bug fix for ValueError: malformed node or string

Hi @GeneKao! Could you provide more detail?

ast.literal_eval() expects a string input, I experienced that sometimes fkey is not (int), casting in to a string might solve the potential error. Just a suggestion, please ignore this if this is not reasonable, I might use it in the wrong way as well.


Will resnet50 or pvanet works better?

I tried resnet50 and pvanet as base nets. However, vgg16 is the best one. I wonder that if I did something wrong in training process? Have you guys tried other base nets?

@baby313
I got worse result too with resnet50. Which endpoints did you use in resnet?

Pixel_link learns very minimalistic representations with limited receptive fields. Hence ResNet might be an overkill. Has anyone experimented with alexNet as the base model?

@aravinthmuthu i try to use modified VGG Net as backbone, after cut a lot of parameters, the final mAP is still at 82.5%, PixelLink network is a little bit tricky.

@BowieHsu
PixelLink is really tricky, never seen this kind of network before. My final mAP is 83.3 with only icdar15 dataset. I tried to raise this score by inserting batch norm or change hyper parameters, but it never succeeded yet so far. I'll share it if there is any improvement.

@baby313 @GodOfSmallThings @aravinthmuthu @BowieHsu @comzyh
Did you use the pretained resnet on Imagenet? and could you share the best score based on resnet?

@lizzyYL
In my case, resnet50 performed worse(~7x%) with paper's training setting.
And since learning rate is relatively so high(1e-2), I'm not sure ImageNet pretrained model would work.

@GodOfSmallThings  Thank you for your reply.
My result is 68%-70%(80000 iterations), and the resnet did not been pretrained.

~7x% @ not pretrained  @lizzyYL

@GodOfSmallThings @BowieHsu @lizzyYL
i can't evaluate my result
please help me to calculate precision and recall on my result

@mn7142 You can use the test scripts to build an offline test platform，
or  use the online testing : http://rrc.cvc.uab.es/?ch=4&com=evaluation&task=1&gtv=1

Replacing vgg with resnet-50, why did it deteriorate? Who can explain  to me?  thanks .

thank you @lizzyYL
how to evaluate on other dataset?

Hi，@BowieHsu，can you tell me how does batchnorm influence the performance?


Add CI jobs for wasm32-wasi

It looks like wasm32-wasi is going to be renamed to wasm32-wasip1 ("WASI Preview 1") at some point. It's possible that targetting wasm32-wasi will fail at some point in the future.


Add eth_getBlockByHash/Number to engine API

Registers and enables eth API namespace with EngineBackend.
For now only implements eth_getBlockByHash and eth_getBlockByNumber in limited fashion (no full transactions and no pending blocks).

Related: https://github.com/protolambda/mergemock/issues/24


Python 3 support

Per @sharoonthomas's request from https://github.com/openlabs/magento/issues/23
Seems like @giampaolo's patch works perfectly and allows to use code with python 3. Can we please add that to repo?
diff --git a/magento/api.py b/magento/api.py
index dc7c085..bda6977 100644
--- a/magento/api.py
+++ b/magento/api.py
@@ -9,9 +9,14 @@
     :license: AGPLv3, see LICENSE for more details
 '''

+import sys
+
 PROTOCOLS = []
 try:
-    from xmlrpclib import ServerProxy
+    if sys.version_info <= (2, ):
+        from xmlrpclib import ServerProxy
+    else:
+        from xmlrpc.client import ServerProxy
 except ImportError:
     pass
 else:
diff --git a/setup.py b/setup.py
index 16a1c32..ba9a7cb 100644
--- a/setup.py
+++ b/setup.py
@@ -8,10 +8,11 @@
     :license: AGPLv3, see LICENSE for more details

 '''
+
 import os
 from setuptools import setup

-execfile(os.path.join('magento', 'version.py'))
+exec(open(os.path.join('magento', 'version.py')).read())

 setup(
     name = 'magento',
@@ -26,15 +27,17 @@ setup(
     zip_safe=False,
     platforms='any',
     install_requires=[
-        'suds>=0.3.9',
+        'suds-jurko',
     ],
     classifiers=[
         'Development Status :: 6 - Mature',
         'Environment :: Web Environment',
         'Intended Audience :: Developers',
-        'License :: OSI Approved :: GNU Affero General Public License v3',
+        'License :: OSI Approved :: GNU Affero General Public License v3',
         'Operating System :: OS Independent',
         'Programming Language :: Python',
+        'Programming Language :: Python :: 2',
+        'Programming Language :: Python :: 3',
         'Topic :: Internet :: WWW/HTTP :: Dynamic Content',
         'Topic :: Software Development :: Libraries :: Python Modules'
     ],

Above code is written by @giampaolo.

+1 to merging Python 3 support. We have a bunch of forks for this which seems silly. Anything I can do to help get it merged?

Happy to merge a pull request

Perfect will prepare one today. Have used my fork for a few months and had success in python3

@sharoonthomas done at https://github.com/fulfilio/python-magento/pull/9

@listingmirror merged. Thanks for your contribution 👍


Bugfix/do not use same variable name inside and outside of loop

@dereuromark found this weird thing I did, where the same variable name is used inside and outside the loop:
        foreach ($value as $key => $value) {
            ...
        }

Interestingly enough, this actually works (there is an explanation here), but it is clearly poor form.

Codecov Report

Merging #1812 (2f38b72) into master (431b8d0) will decrease coverage by 19.30%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master    #1812       +/-   ##
=============================================
- Coverage     87.85%   68.54%   -19.31%
  Complexity     7816     7816
=============================================
  Files           281      281
  Lines         22710    22156      -554
=============================================
- Hits          19951    15186     -4765
- Misses         2759     6970     +4211

Flag
Coverage Δ

5-max
68.54% <100.00%> (-19.31%)
:arrow_down:

7.4
68.54% <100.00%> (-19.31%)
:arrow_down:

agnostic
68.54% <100.00%> (ø)

mysql
?

pgsql
?

sqlite
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431b8d0...2f38b72. Read the comment docs.


Release 1.7.0 doesn't work in Unity with custom server

This is because the ParseInitializeBehaviour is required to be instantiated in the Unity SDK to setup the async-task processing (otherwise async Parse calls never complete) but it doesn't allow you to pass a custom server URL for it to use in the ParseClient.Initialize() call it makes.
Fix: I've created a fork and added a 1.7.1 release with (just) a fix for this issue here.
Note: This issue also seems to be fixed in the latest code in the master branch but I wasn't sure how to use that against my pre-existing project.

Actually, after some more testing, there's also an issue with the ParseInitializeBehaviour.OnApplicationPause() method not initializing the ParseClient properly. I will recreate the release on my fork with that fixed too.

That's fixed now and I've recreated the 1.7.1 release on that fork. I wasn't sure how the sample projects are generated so I left that zip out from the release rather than adding a broken version.

Hey @CapeGuy-Ben I'll see if I can't take a look at this during this upcoming weekend. If you've managed to put together a fix would you mind putting up a PR for it here? From there we can take a look at it and see how it works out 👍 .
The goal here is to get the .NET, Arduino and Embedded C sdks up to snuff with parse-server. I'll be moving this along to see if we can't get that achieved in a decent time frame. From what I've heard though the .NET is good to go as is. Just missing some of the newer functionality that's been added.

Hey @montymxb! I did try to put a pull request in but as there's no branch for release 1.7.0 I couldn't work out how to do it. My fix is a minor edit to version 1.7.0 rather than an edit to the (now significantly different) master branch.

The releases are generated off a given commit from a given branch, specified by a user. It's very akin to git tags. Github just makes it convenient and automatically generates the zips and tars as well.
As for creating pull requests from a fork, there's info on how to do that here. Although the current master be a bit ahead of where you forked, it looks like the change you made was just a one liner? You could even just go to the file directly and chose to Fork and Edit just that file from the browser (it's the little pencil icon on the top right) considering that it's a pretty small change.

This change is already in the master branch, but the master branch also contains API changes which make it incompatible with the pre-existing Parse project which I'm trying to move over to a custom server. So I made this simple single commit change against 1.7.0 which fixes using it with custom servers in Unity. Think of it as a hot-fix for 1.7.0 rather than a new release. If you're planning on releasing a new version against master anytime soon then just ignore this. There are quite a few people struggling with this issue though. See this issue.
FYI. I know what a release is (I did one on this fork) and I know how to create a pull request in GitHub, however, it needs to be a pull request against a branch in the target repo and there is no branch sitting where the 1.7.0 tag is in your repo so I can't do a pull request unless you create one.

@CapeGuy-Ben The intent here will be to push out a new release, eventually. If a fix has already been integrated into the master for this then it seems I misunderstood... Once the next release is published we should be ok.
I did take a look at the aforementioned issue as well. I see what you're getting at regarding the custom servers. Since I'm just stepping on this I'll be verifying the existing tests and such for starters, then going through the rest of these issues and resolving what we can 👍 . From there we'll be pushing out a new release altogether.
You'll have to forgive me for that, don't take the excessive detailing personally. It appears I glazed over the fact you were suggesting a merge onto a branch poised at release 1.7.0 itself, oops! We won't be going that route however, given that the focus is to push up a new release altogether.
With all that, you mentioned that the master contains breaking changes? That's no good :/ .... I've only recently been looking into this so I'll have to see exactly what was done, unless you know of any particular examples you could bring up. I'll be checking tests and such this weekend.
If there's anything else you think would be prudent to mention please do! The faster I'm able to catch up with the current state of affairs the sooner we can move onto the fixing 🔧.

Hey @mintymxb, sounds good. Don't worry, nothing taken personally - just trying to do a better job of explaining the situation! Good luck putting together a new release. 👍
A few things that might be worth thinking about:

I tried building the project (1.7.0 and master) on my Mac via Xamarin Studio and then on my PC via Visual Studio 2017 & 2015 Community editions and couldn't get them to build without lots of errors about unsupported project types. I was only able to build everything once I tried Visual Studio Enterprise 2015 which prompted me to install all sorts of extra bits and bobs to get the remaining projects working. It might be worth working out what the dependencies of the project are and listing them in the readme so people without Visual Studio Enterprise can also build it?

These issues were from trying to build the master branch, it was about a week ago so some of details are a little hazy :-/. It's also quite possible that the second of these issues was caused by me grabbing the wrong dlls while trying to fix the first issue:

After building master the instructions to find the build results in the Parse/Bin folder are no longer correct, I had to go rooting around the various build folders to find what I thought were the right dlls.
Once I swapped in the build from the master branch (I tried that before deciding a slightly modified 1.7.0 was the way to go) I got a few compile errors in my pre-existing Unity project. Presumably that is because there are missing/changed bits of the API. I can't remember exactly what they were off the top of my head but I can take another look and let you know if that would be helpful?

Thanks! Yeah it's going to be interesting, especially considering that the CI configuration appears to have been server-side at appvoyer, and that's gone now :/.
I can confirm the issues with VS 2017, looking into this a bit (and a helpful so post) it appears VS 2017 does not support silverlight projects, or 8.0/1. Although these work in VS 2015 (with the necessary dependencies for xamarin and such), there's no guarantee that these will ever be accessible in VS 2017. I need to do more research before I proceed but that's certainly a problem if you're on 2017.
I haven't looked into the building issues yet, but perhaps there's something up there as well. Looking at #91 it looks like they were in the middle or porting everything over to UWP. Once I've setup my dev environment properly for this I'll see where things are.
I'll be around working on this from time to time in the near future. If you think you've found anything else that's of significance feel free to bring it up. It'll take a while to really look through most of the issues to check for any reported compatibility problems, but after that we should start getting some PRs rolling in! Once things are stable (and the CI is back in place) we'll have ourselves a release 👍 .

Thanks for looking into it. I will let you know if I find anything else. I'm going to close this issue as anyone using Unity can use the 1.7.1 release on my fork until another release comes along and once there's a new release they can use that.
BTW. I think the users would be happy to install VS 2015 Community for building the project. Just add the requirement to the ReadMe file.

@CapeGuy-Ben No problem. Hopefully we can get this project back on it's feet!

@richardjrossiii or anybody: Is there a release that has the fix for the Android Push Notification Registration error? Found com.parse.push.gcm_sender_id <meta-data> element with value "id:190765109935", but the value is missing the expected "id:" prefix.
We were not able to create a working dll from the master, so I'm looking if anybody has compiled a Parse.Unity.dll that contains this bug fix.

@cabhara not that I am aware of. If this is still outstanding can you open up another issue specifically for your problem?


Applied Jetbrains Rider Solution wide Code Cleanup (Reformatting Code)

-Note: Some files manually adjusted Rider Code Reformatting

@VelvetThePanda Sorry for the delay! Tried to address the places where the indentation was kinda wonky from what you had pointed out 👍🏽

@VelvetThePanda Sorry for the delay! Tried to address the places where the indentation was kinda wonky from what you had pointed out 👍🏽

Formatting was applied in a later commit made by Velvet 👍🏽

Formatting was applied in a later commit made by Velvet 👍🏽


Resolve minor readme bug due to API change

Types of changes
Minor readme update.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue
While trying to get a sample working I noticed:
class PrivacyEngine:
def init(
self,
module: nn.Module,
batch_size: int,
sample_size: int,
alphas: List[float],
noise_multiplier: float,
max_grad_norm: float,
grad_norm_type: int = 2,
However the README.md had:
privacy_engine = PrivacyEngine(
model,
train_loader,
alphas=[1, 10, 100],
noise_multiplier=1.3,
max_grad_norm=1.0)
How Has This Been Tested (if it applies)

My code did not fail. After I deleted the Batchnorm layers of the model but that was a separate issue that I would like to understand more but maybe later.
Use pytorch-dp to privatize training
from torchdp import PrivacyEngine
privacy_engine = PrivacyEngine(
    model,
    BATCH_SIZE,
    1,
    alphas=[1, 10, 100],
    noise_multiplier=1.3,
    max_grad_norm=1.0,
)

privacy_engine.attach(optimizer)

Checklist

[X] The documentation is up-to-date with the changes I made.
[X] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[ X All tests passed, and additional code has been covered with new tests.

Thank you for updating doc. I will merge this request shortly


Add "oracles" and "storage" to tags

TODO: Add descriptions to both tags and an emoji to "oracles".

I have no idea how I managed to forget a comma, not once, but three times... smh
Should be all good now!

Thanks for your submission @TypicalHog. While these tags are valid, we don't think they add all that much value. We are interested in creating "opinionated" tags — that is, tags that are not just descriptive, but that help users develop an opinion about what has value and what doesn't. These tags are purely descriptive, and in our opinion don't meaningfully drive users to any sort of conclusion about token value.


Use new Picture in Picture APIs to show e.g. PTZ controls

See: https://developer.chrome.com/blog/the-future-of-picture-in-picture/

Maybe someday


Crash when open file->setting menu

As my subtitle, I can't open file->setting menu, the idb window is crash immediately. May I open connection to iOS 7.1.2 jailbroken?

Having the same problem :-/

This should be fixed in c87dc47770eb661f69831132c314b6ee2ff8326c
When no settings file existed, idb would not add the sqlite_editor option, resulting in a crash when reading it.
Try a gem update idb and please let me know if the issue still exists.


Docker version tags

Would be nice if the docker images had version tags. This would mean docker installations could be more predictable in which version they run. As it is today there is only the latest tag so you don't know which version you will get when you do docker pull.

@jonaskello this repo does not handle the docker version. I think you are looking for this project https://github.com/wzrdtales/docker-sinopia don't you? Please correct me if I'm wrong.

@juanpicado If you look at the docker hub it lists this repo as source. Also there is a Dockerfile in this repo, I thought that is what is used to build to docker hub but maybe it isn't?

I created the docker image as an easy way for people to pull the latest image. If someone wants to help out and tag builds, let me know so I can add you.

If you like I can manage the Docker stuff for this project. I have my own Drone.io installation, it would automatically generate and publish a new Docker image whenever you create a new release. It will be tagged with the version number. I see there are quite some improvements possible to the Dockerfile, I can handle that as well.
Just let me know, I can start with it soon.

@Richie765 please feel free to PR any change

@juanpicado, I've looked into it and there's an easier way to do it. You can setup automated builds on Docker Hub. I've outlined the steps:

Link your Docker Hub account with Github (settings, linked accounts).
Delete your current Docker Hub verdaccio/verdaccio repo.
Choose: Create Automated Build. Select your verdaccio/verdaccio repo.
Go to the build settings and fill out as follows:

Type    Name            Docker Tag Name
Tag     /v([0-9.]+)/    {\1}
Tag     /v(\d+\.\d+)/   {\1}
Tag     /v([0-9]+)/     {\1}
Tag     /v([0-9.]+)/    latest

When you push new tags (releases) an automatic build will be triggered. You can see how it will look like here:
https://hub.docker.com/r/richie765/verdaccio/tags/
There's probably more tweaking that you could do but this should get you started quickly.

As soon I got permissions on Docker Hub I'll take care of this one.

Great! Since you already have automated builds, you only need to do the last step, the build settings.

@Richie765 done 👍

Nice work! 👍


My bot can cancel my loans but could not make one..

Like I wrote, It can cancel my orders that i made by myself manually but It could not make new one automatiaclly,
Can anyone give me some help?
I am not familiar with coding thing, but I am trying to do something..
thanks
FYI, now I am lending BTC and LTC
[BOT]
#Sleeps between active iterations, time in seconds (1-3600)
sleeptimeactive = 130
#Sleeps between inactive iterations, time in seconds (1-3600)
#Set to the same value as sleeptimeactive to disable
sleeptimeinactive = 300
#Minimum daily lend rate in percent (0.0031-5)
#Setting to 0.0031 is about 1% a year, not worth it.
mindailyrate = 0.0083
#Maximum lending rate. 2% is good choice because it's default at margin trader interface.
#5% is the maximum rate accepted by the exchange (0.003-5)
maxdailyrate = 5
#The number of offers to split the available balance across the [gaptop, gapbottom] range. (1-20)
spreadlend = 3
#The depth of lendbook (in percent of lendable balance) to move through
#before placing the first (gapbottom) and last (gaptop) offer.
#If gapbottom is set to 0, the first offer will be at the lowest possible rate.
#However some low value is recommended (say 10%) to skip dust offers.
gapbottom = 10
gaptop = 200
#Daily lend rate threshold after which we offer lends for x days as opposed to 2.
#If set to 0 all offers will be placed for a 2 day period (0.003-5)
xdaythreshold = 0.2
xdays = 2
#Auto-transfer of funds from exchange to lending balance.
#Enter ALL to transfer all coins, enter ACTIVE to transfer any coins you have in your lending account when the bot starts, these can be mixed.
#The currencies you enter below (comment it out to disable entirely, just leaving empty will result in an error) will be automatically transferred from your exchange $
#transferableCurrencies = BTC
#Minimum loan size, the minimum size of offers to make, bigger values prevent the bot from loaning small available amounts but reduce loan fragmentation.
minloansize = 0.01
#Keep Stuck Orders - Sometimes an order gets partially filled. When this happens it may leave the remainder of your coin under the set minloansize.
#If this happens, KeepStuckOrders will keep your order where it is so maybe it can be filled. Otherwise it will be canceled and held until orders expire.
keepstuckorders = True
#Hide coins - Instead of keeping your coins lent out at minlendrate when it is not met, the bot will hold them and wait for the rate to surpass it.
hideCoins = True
#End date for lending, bot will try to make sure all your loans are done by this date so you can withdraw or do whatever you need.
#Uncomment to enable.
#Format: YEAR,MONTH,DAY
#endDate = Disabled
#Raw maximum amount to lend if under maxtolendrate.
#If set to 0 or commented: the bot will check for maxpercenttolend.(0+)
#maxtolend = Disabled
#Maximum percent to lend if under maxtolendrate.
#If set to 0 or commented: the bot will lend 100% of your balance regardless of rate. (0-100)
#maxpercenttolend = Disabled
#Max to lend conditional rate.
#If set to more than 0: the maxtolend or maxpercenttolend will be used when the rate is less than or equal to the maxtolendrate.
#If set to 0 or commented: the bot will use the maxtolend or maxpercenttolend all the time. (0.0031-5)
#maxtolendrate = Disabled
# Local Market Analysis: Choose which coins to record the market of in order to analyse them and compute a recommended lending rate.
# Enter ALL to analyse all coins, enter ACTIVE to analyse the markets of any coins you have in your lending account when the bot starts, these can be mixed.
#analyseCurrencies = BTC
# Choose how long to keep market data. (In days) (1-365)
#analyseMaxAge = 30
# Choose how often to record a market's rate. (In seconds.) (10-3600)
#analyseUpdateInterval = 60
# Choose how aggressive to lend at based on a market's performance. (As a percentile of the market's rate.) (1-99)
# Recommendations: Conservative = 50, Moderate = 75, Aggressive = 90, Very Aggressive = 99
#lendingStyle = 75
#Syntax: ["COIN:mindailyrate:maxactiveamount:maxtolend:maxpercenttolend:maxtolendrate",...]
#If maxactive amount is 0: stop lending this coin. in the future you'll be able to limit amount to be lent.
#If maxtolend is 0: check for maxpercenttolend.
#If maxpercenttolend is 0: 100% is going to be lent.
#If maxtolendrate is set to more than 0: the maxtolend or maxpercenttolend will be used when then rate is less or equal to the maxtolendrate. if set to 0 the bot will$
# Please configure via the coinconfig line below OR individual coins in the [BTC], [CLAM], etc section. NOT both.
# coinconfig takes precedence
#coinconfig = ["BTC:0.18:1:0:0:0","CLAM:0.6:1:0:0:0"]
#This option creates a json log file instead of console output which includes the most recent status.
#Uncomment both jsonfile and jsonlogsize to enable.
#Keep this in the default location if you want to use the webserver.
jsonfile = www/botlog.json
#Limits the amount of log lines to save.
jsonlogsize = 200
#Enables a webserver for the www folder, in order to easily use the lendingbot.html with the .json log.
#startWebServer = true
#Customize the IP and port that the webserver is hosted on. Defaults to <IP_ADDRESS>:8000
#<IP_ADDRESS> will point to your default IP (Local IP on LAN as well as localhost), set to <IP_ADDRESS> if you want it to be only accessible by host computer.
#Do not set to a reserved port
#Advanced users only.
#customWebServerAddress = <IP_ADDRESS>:8000
#The currency that the HTML Overview will present the earnings summary in.
#Options are BTC, USDT, ETH or anything as long as it has a direct BTC market. The default is BTC.
#outputCurrency = BTC
#Plugins allow extending Bot functionality with extra features.
plugins = AccountStats
# Currencies can be configured here, or in the coinconfig. Coinconfig takes precedence.
#[BTC]
#minloansize = 0.01
#mindailyrate = 0.0083
#maxactiveamount = 50
#maxtolend = 5
#maxpercenttolend = 5
#maxtolendrate = 5
#[CLAM]
#minloansize = 1
#mindailyrate = 0.6
#maxactiveamount = 1
#maxtolend = 0
#maxpercenttolend = 0
#maxtolendrate = 0
[notifications]
notify_new_loans = False
notify_tx_coins = False

Can you add a log output?

Is this resolved @marketingsteven
Can we see the log?
Have you set up the permisssions for the key correctly in poloniex?

@rnevet @laxdog I made another pythoneanywhere account and try new bash, but it says
04:43 ~ $ git clone https://github.com/Mikadily/poloniexlendingbot
fatal: destination path 'poloniexlendingbot' already exists and is not an empty d
irectory.
04:43 ~ $ python2.7 lendingbot.py
python2.7: can't open file 'lendingbot.py': [Errno 2] No such file or directory
04:43 ~ $ default.cfg
bash: default.cfg: command not found

I think I have to reset this whole thing?

problem is , I am not a programmer so no idea what I have to do ;(
If you guys can help me out, that would be more than welcome!

I still think you need to check your permission on Poloniex.
I'm launching my own platform running this bot @marketingsteven . It's in closed beta at the minute, but I'd be happy to run it for you there if you want.
Send me a message on Slack or Telegram if you're interested. It's free for the mean time.

@marketingsteven In the second bit of code you pasted, you are not inside the folder you are trying to access. You properly cloned it, so the next step is cd poloniexlendingbot before doing python lendingbot.py
Your original issue may stem from this misunderstanding.


Add webhook support (specifically "receiving_amount")

Original issue title: Fire callback on change in receiving amount

Right now it looks like the only way I can tell if my tipping amount has changed is to go to the gittip website and check. It looks like there's also an API but I have to poll that to see if anything has changed.
I would love a simple, machine-friendly callback, that fires when the tipping amount changes. Let the user specify (in their 'advanced' settings) a URL to which we POST a chunk of JSON to when their receiving amount changes. I suggest it just contains:

timestamp (seconds from the epoch)
gittip user ID
previous receiving amount
new receiving amount
transaction note (if #2011 is implemented)
digital signature (optional, but means we can verify it's gittip making the callback)

One could generalise this ticket to trigger a callback when either the sending or receiving amount changes (in which case the above packet should have sending fields added).
This change would allow for easier creation of gateways into third-party message systems, and would allow advanced users to trigger their own events upon status changes. (I can hook callbacks into my exobrain system, which would give me gittip notifications going straight to my Pebble watch.)
These would be the gittip equivalent of what github does with post receive hooks.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Closing in light of our decision to shut down Gratipay.
Thank you all for a great run, and I'm sorry it didn't work out! 😞  💃


Date parser error

ValueError: time data '1965' does not match format '%Y/%m/%d'
at _strptime (/usr/lib/python3.7/_strptime.py:359)
at _strptime_datetime (/usr/lib/python3.7/_strptime.py:577)
at parse_date (/memorious/src/opensanctions/opensanctions/crawlers/interpol_red_notices.py:18)
at parse_notice (/memorious/src/opensanctions/opensanctions/crawlers/interpol_red_notices.py:78)
at execute (/memorious/memorious/logic/context.py:77)

It should be already fixed by https://github.com/alephdata/opensanctions/commit/92b944ce868a515d629d9571ce036677434351ec. Just need to release and deploy.

kk sorry to bother.


Ubuntu 16.04 LTS cfncluster AMI release?

We are readying an Ubuntu 16.04 LTS release of our campus community-supported image and would like to build on the cfncluster AWS AMI when it is available, so I wanted to make this feature request to let you know there is interest. If you have a timeline in mind for doing a release with this new version we'd appreciate knowing when so we can plan accordingly.
Thanks,
Aaron

We haven't looked at Ubuntu 16.04 LTS yet and you're the first to ask! I'll keep the issue here and open it as part of the cfncluster-cookbook project.

Friendly nudge!

Please see the issue in https://github.com/awslabs/cfncluster-cookbook/issues/9 for updates

This has been released as part of cfncluster-1.3


docker container: disable tagging every gitrev

Issue

This PR results/does not result in breaking changes to upstream dependencies.

Checklist

[ ] This PR contains all the work required to resolve the linked issue.

[ ] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[ ] I have added the appropriate labels to this PR.

What's up?
https://github.com/input-output-hk/cardano-node/releases/tag/do-not-use
https://github.com/input-output-hk/cardano-node/releases/tag/do-not-use-2
https://github.com/input-output-hk/cardano-node/releases/tag/do-not-use-3

I don't know enough about docker, but I believe the following lines will fail:
https://github.com/input-output-hk/cardano-node/blob/31e0190a5edf32aaca2412933c967e28d6a122d8/.buildkite/docker-build-push.nix#L59
https://github.com/input-output-hk/cardano-node/blob/31e0190a5edf32aaca2412933c967e28d6a122d8/.buildkite/docker-build-push.nix#L72
because, the docker image "$fullrepo:$gitrev" won't exist if we haven't tagged an image as such. Unless, the docker image is already named "$fullrepo:$gitrev" by default, which is the case for some repos, but not "cardano-wallet".

I don't know enough about docker, but I believe the following lines will fail:
https://github.com/input-output-hk/cardano-node/blob/31e0190a5edf32aaca2412933c967e28d6a122d8/.buildkite/docker-build-push.nix#L59
https://github.com/input-output-hk/cardano-node/blob/31e0190a5edf32aaca2412933c967e28d6a122d8/.buildkite/docker-build-push.nix#L72
because, the docker image "$fullrepo:$gitrev" won't exist if we haven't tagged an image as such. Unless, the docker image is already named "$fullrepo:$gitrev" by default, which is the case for some repos, but not "cardano-wallet".

Yes, it seems that this repo's docker image is by default of the form "inputoutput/cardano-wallet:gitrev", see: https://buildkite.com/input-output-hk/cardano-node/builds/5030#9251f4d8-b26f-4cb8-906a-5f00450f2a38/21-57
So this should be fine.

What's up?
do-not-use (release)
do-not-use-2 (release)
do-not-use-3 (release)

removed. Was testing automation workflow so release manager automatically publishes docker container to docker hub when release is published.

bors r+


Flicker'ish test tree

vscode selfhost
filter text tree by inlineChat
select run all
🐛 the progress items flicker a lot

https://github.com/user-attachments/assets/f7687f11-d796-4865-97d6-8550f49451f7

We show the spinner whenever a test is currently running, which in the selfhost case is based on mocha reports. But for the time between tests there's no spinner. Not sure what I'd do to solve this -- a debounce isn't good because then we'd just stick in one state or the other arbitrarily.

a debounce isn't good because then we'd just stick in one state or the other arbitrarily.

Not so sure, I believe debounce is good and commonly used for cases like this. You can always lean towards showing "running" for a bit longer, esp while the parent node show "running"


Release Candidate Comments (Contributor Location)

This issue was created to collect comments about the upcoming metrics release.
This thread is for comments about Contributor Location
GitHub location: https://github.com/chaoss/wg-common/blob/master/focus-areas/who/contributor-location.md

I really like the visualizations in this metric and the clarity of the filters. LGTM :ship:

No comments, so we'll use this one as-is.


delete() method returns 500

It's still working for me, internal server error is Claude's fault though. There was a period a few days ago where it was down so that might have been the cause. Please tell me if this is working on the web ui but not in the cli and I'll investigate further


need a robust way to import HMM parameters

Currently parameters are hardcoded, then can be overwritten through the GUI.
But this isn't good enough, and is especially hacky for >2 state HMMs
Requirements:

this needs to be accessible from rtxi-hmmGenerator and Decoder

Proposed solutions:

simple: text -> std::vector (vector of vectors)

a version of this exists in the legacy folder (see legacy / dataFuns.cpp / pullParamLine() )

more robust / heavier: load from matio

matioStimLd is probably the right template for this

notably pullParamFromLine relies on importing a matrix as a vector then reshaping it


test(loadstrategy): added failing test for LoadingStrategy.JOINED

Failing tests for #1331

Closing due to @TiesB 's PR https://github.com/mikro-orm/mikro-orm/pull/1336

Closing due to @TiesB 's PR https://github.com/mikro-orm/mikro-orm/pull/1336


Create spec sheet of comm's protocols for accumulator air (fan) cooling

1 STM32 F-series chip

1 CANBUS

check how/what is needed to drive 0-12V @30A (6.6A each fan, maybe PWM, maybe something else [pull up/down, etc])

@hernantech
Draft 1 of Spec Sheet
let me know what changes need to be made to the first draft of the spec sheet


training code

Excuse me, Can you supply your NRP training code, I want to try for training the NRP module. Thanks.

Hi Ken, NRP training is based on the following framework: https://github.com/xinntao/BasicSR


Examples

I do not like this approach, commented code is not code. If we need some of this code in future, we implement this in future. It's a long discussion :stuck_out_tongue_winking_eye:


Use ov in CI + CD

Fixes

Fixes #4406 by @sarayourfriend
Description

This PR updates the CI + CD workflow to use ov. This should make ov more resilient to accidental breakages.
🚧 WIP:

[ ] Implement caching for ov and its contents.
[ ] Speed up workflow by removing redundant steps.
[ ] Simplify and deduplicate workflow code.

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This is definitely not ready for review, lol. How did that happen?

Well, at least the error is new and different.


feat(app): edit env vars

There's a bunch of code changes that are mostly moving code around.
https://github.com/aptible/app-ui/assets/1940365/8e4856ad-dc6e-4c79-8342-79b3eaf4154b

Looks great! The only change I would make is this:
Say Save Changes instead of Save


Connect fails returning a true value

Hi all, I'm facing a weird behavior of the connect() function. I'm using the common example code with Arduino 1.8.4 with both an ESP8266 board and an Arduino Duemilanove with Ethernet shield. The behavior is the same.
Here my reconnect() function:
void reconnect() {   while (!client.connected())    {     Serial.print("Attempting MQTT connection...");     if (client.connect(clientId.c_str()), mqtt_username, mqtt_password) Serial.println("connected");     else      {       Serial.print("failed, rc=");       Serial.print(client.state());       Serial.println(" try again in 5 seconds");       delay(5000);     }   } }
The problem is I get a "true" return value even if the connection is not established. Here an example of the output:

Ethernet configured via DHCP
IP address: <IP_ADDRESS>
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
Attempting MQTT connection...connected
...

Is it a known behavior?

Apologize:
if (client.connect(clientId.c_str()), mqtt_username, mqtt_password)
I was blind and I didn't see this error.


Migrating some Setup docs

Details

The original articles are under https://github.com/umbraco/UmbracoDocs/tree/main/Getting-Started/Setup;
Some pictures are reused others newly taken;

Setup index.md

Only the links for Requirements and Install work;
For the other ones, their articles need to be migrated.

Requirements index.md

Fully migrated.

Install index.md

Added a new section for .NET CLI installation;
.NET CLI installation and VS Code installation links work - the articles are created/migrated;
Removed the Running Umbraco on a Mac section as dotnet new templates should work and can be used on any OS;
Update the Umbraco.Templates nuget package link once we publish it in install-umbraco-with-templates.md;
It is currently referenced as https://www.nuget.org/packages/Umbraco.Templates;

Note:

Haven't added anything for installing using the Umbraco Package template - let me know if I should do that!
installer-v9.png should probably be renewed closer to the launch - not sure if the functionality of the Installer screen will change. -> Have 1 button Next as it currently is or has Install and Customize as before.

install-umbraco-with-vs-code.md contains the recent look of the Install screen but refers to the old functionality with Install and Customize buttons.

In regards to using the Umbraco Package Template, I think there should be a doc for that, but maybe it should be separate, since it's more oriented towards package developers, instead of just "getting started" with Umbraco.
It might be nice however to go a bit more in-depth in regards to installing the templates, and perhaps have a section for getting started with visual studio/rider once the template feature is out of the "opt-in" phase in visual studio.

It might be nice however to go a bit more in-depth in regards to installing the templates, and perhaps have a section for getting started with visual studio/rider once the template feature is out of the "opt-in" phase in visual studio.

That should be next VS Preview

@nikolajlauridsen, thanks for the review!
Regarding the "more in-depth in regards to installing the templates" "with visual studio/rider", that is totally relevant, however, the task only mentioned "a new article about installing using cli." But I am sure it will be useful to add a section about those in the future 😁


⚠ Bofrost.lu has degraded performance

In dc25eda, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1043 ms

Resolved: Bofrost.lu performance has improved in 2800750 after 8 minutes.


Update of AppsPlus API for MoreApps module

Needs
The AppsPlus proprietary backend used by MoreApps module can send more types of data, mainly a carousel of applications. The module must be updated to deal with this new specifications.
Definition of Ready

[ ] Get JSON files matching any cases (carousel, no carousel)
[ ] Get a swagger or an API description explaining error cases and which JSON fields are optional

Definition of Done

[ ] Update CHANGELOG
[ ] Update README
[ ] Update documentation
[ ] Update unit tests
[ ] For demo app, add a field to test some API key
[ ] In DTO layer, deal with carousel
[ ] In BO layer, deal with carousel
[ ] Update GUI to deal with carousel

cc @B3nz01d


Add downside risk loss

hey @jankrepl, great work, thanks!
i'm adding the downside risk (which specializes to the semi-variance) in the list of loss functions.
let me know if anything is missing.
Thanks again!

hey @jankrepl, great work, thanks!
i'm adding the downside risk (which specializes to the semi-variance) in the list of loss functions.
let me know if anything is missing.
Thanks again!

Amazing! Thank you for your interest and this PR. I will review it ASAP. BTW the failing CI does not seem to be caused by the changes introduced in this PR. I will take care of it.

Looks great! Thank you for your contribution!

@jankrepl no problem, thanks for releasing this package to the public!


Icon request: Mailcow

URL of the site or app (required): https://mailcow.email/

Logo resources for the icon (optional, but recommended): https://github.com/mailcow/mailcow-dockerized/blob/master/data/web/img/cow_mailcow.svg

Oh boy, that's challenge to make that logo into monochrome. I will try, but I don't promise that's gonna 100% great result.

This gave me lot of work , but it's done.
https://github.com/krisu5/aegis-icons/blob/master/PNG/Mailcow.png


sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found

brew config output
when brew install datawire/blackbird/telepresence
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.
brew doctor output
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.

[X] The brew doctor above contains no "Warning" lines.

What were you trying to do (and why)?
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.
What happened (include all command output)?
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.
What did you expect to happen?
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.
Step-by-step reproduction instructions (by running brew commands)
sshfs.c:15:10: fatal error: 'fuse_lowlevel.h' file not found
#include <fuse_lowlevel.h>
^~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [sshfs-sshfs.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install-recursive] Error 1
Do not report this issue to Homebrew/brew or Homebrew/core!
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels.

Do not report this issue to Homebrew/brew or Homebrew/core!

Please report this to whomever runs datawire/blackbird.


Fix some issues on the documentation

Description
This PR adds some refactors to the installation section of the documentation

/rebase


Allow custom omc executable on Windows

@AnHeuermann  I have pushed the requested feature you asked for may be you can wait for the commit is built successfully

I did more or less the same stuff you did in https://github.com/arun3688/OMJulia.jl/commit/35485fabbeb575a219c481ae6206db2693cfec4f
but can't build a model for e.g. Modelica.Electrical.Analog.Examples.CauerLowPassAnalog

But yeah, I can wait

@AnHeuermann  , IT is now successfully pushed, Can you test it now

It's not working for building and simulating:
julia> out = sendExpression(omc, "simulate(Modelica.Electrical.Analog.Examples.CauerLowPassAnalog)")
Dict{String,Any} with 8 entries:
  "timeCompile"       => 2.41841
  "simulationOptions" => "startTime = 0.0, stopTime = 60.0, numberOfIntervals = 500, tolerance = 1e-006, m…  "messages"          => "Simulation execution failed for model: Modelica.Electrical.Analog.Examples.Cauer…  "timeFrontend"      => 0.354831
  "timeTemplates"     => 0.0440197
  "resultFile"        => ""
  "timeSimCode"       => 0.00372372
  "timeBackend"       => 0.0232729
julia> println(out["messages"])
Simulation execution failed for model: Modelica.Electrical.Analog.Examples.CauerLowPassAnalog
Der Befehl ""D:/workspace/julia/OMJulia.jl/Modelica.Electrical.Analog.Examples.CauerLowPassAnalog.exe"" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.

For some reason the generated makefile can't compile the generated files. Running simulate(...) from mingw shell with the same omc works though.
Modelica.Electrical.Analog.Examples.CauerLowPassAnalog_12jac.c
Modelica.Electrical.Analog.Examples.CauerLowPassAnalog_12jac.c: In function 'Modelica_Electrical_Analog_Examples_CauerLowPassAnalog_initialAnalyticJacobianLSJac2':
Modelica.Electrical.Analog.Examples.CauerLowPassAnalog_12jac.c:19:27: error: incompatible types when assigning to type 'SPARSE_PATTERN {aka struct SPARSE_PATTERN}' from type 'SPARSE_PATTERN * {aka struct SPARSE_PATTERN *}'
   jacobian->sparsePattern = (SPARSE_PATTERN*) malloc(sizeof(SPARSE_PATTERN));
                           ^
Modelica.Electrical.Analog.Examples.CauerLowPassAnalog_12jac.c:20:26: error: invalid type argument of '->' (have 'SPARSE_PATTERN {aka struct SPARSE_PATTERN}')
   jacobian->sparsePattern->leadindex = (unsigned int*) malloc((2+1)*sizeof(int));
...

I found the problem. Environment flag OPENMODELICAHOME is used to generate the makefile. So setting
ENV["OPENMODELICAHOME"] = # something from executable path

should work. I'll try it later

It is working for me, I run from the normal command prompt
julia>OMJulia.sendExpression(omc,"simulate(Modelica.Electrical.Analog.Examples.CauerLowPassAnalog)")
Dict{String,Any} with 10 entries:
  "timeCompile"       => 7.45829
  "simulationOptions" => "startTime = 0.0, stopTime = 60.0, numberOfIntervals = 500, tolerance = 1e-006, method = 'dassl', fileNa…

  "messages"          => "LOG_SUCCESS       | info    | The initialization finished successfully without homotopy method.\nLOG_SU…

  "timeFrontend"      => 0.375048
  "timeTotal"         => 8.13228
  "timeTemplates"     => 0.0413075
  "timeSimulation"    => 0.219032
  "resultFile"        => "C:/Users/arupa54/Modelica.Electrical.Analog.Examples.CauerLowPassAnalog_res.mat"
  "timeSimCode"       => 0.0057934
  "timeBackend"       => 0.0323025`

@AnHeuermann , Hi Andreas i have pushed the changes now with this commit,https://github.com/OpenModelica/OMJulia.jl/commit/727417431d6da9c940c2f2a857347bba2144f592, It should now be possible to run different omc versions at the same time

It's almost working. I can use two different omc when non of them is the "default one".
In OMJulia.jl:136 omhome is now out of scope
omc_2 = OMJulia.OMCSession()
ERROR: UndefVarError: omhome not defined
Stacktrace:
 [1] OMJulia.OMCSession(::Nothing) at D:\workspace\julia\OMJulia\src\OMJulia.jl:141
 [2] OMJulia.OMCSession() at D:\workspace\julia\OMJulia\src\OMJulia.jl:97
 [3] top-level scope at none:0

@AnHeuermann It is a small typo issue, I fixed it with this https://github.com/OpenModelica/OMJulia.jl/commit/73cf0834cbbad78a5b5fb1c23cb0ef2b6125158c

Thanks


Remove space between alarm and % for KPI

Type of issue

[x ] Bug
[ ] New feature
[ ] Improvement

Description

Critical Alarm % KPI needs to not be below the #.  Remove the space between the # and the % should fix this.  Happens when the screen isn't full size.

Fix checked in, closing.


Clean up Violation tests

As a follow up to this PR https://github.com/Expensify/App/pull/31656#pullrequestreview-1760736570, let's address the comments in that review
@trevor-coleman @cdanwards @lindboe please comment so I can assign you

Commenting for assignment

The outstanding issues are I think:

Whether to keep transactionViolations as a variable in ViolationUtilsTest
Whether to keep the export of hasViolations from the useViolations hook

I'll copy my comments over so we can discuss here:
1. transactionViolations
From this thread:
transactionViolations is used in every test as it's one of the parameters of the function that is being tested, so even if it is not being redefined, it's base value is being used in every function call.
Declaring it in each test would also mean that if the base case changed in the future, every test would need to be edited to reflect this change.
In Jest, there's a specific approach to handling variables across tests

Shared Variable Scope: Variables are declared once in the outer describe scope, shared across tests. Their values are reset in beforeEach, ensuring test isolation.

beforeEach Initialization: Executes before each test, assigning default values to shared variables (declared in the outer scope with let to allow reassignment). This guarantees a clean data set for each test, avoiding interference from preceding tests.

Consistent Starting Point: Default initialization in beforeEach (e.g., transactionViolations as an empty array) provides predictability and readability, a common Jest practice.

Naming Consistency: Best practice is have a single variable for each parameter of the function being tested, named identically to the parameter for easy overrides  and clear understanding of modifications within tests.

If you really want me to break the standard I can do that, but I strongly recommend against it as consistent variable handling in jest makes tests much easier to maintain for future devs on the project.
2. hasViolations()
From [this thread]:(https://github.com/Expensify/App/pull/31656/files/2b275095c9a2939b4a3ebfd5787a2e1cdddd9000#r1411149605)
I get the concerns about the apparent redundancy of getViolationsForField and hasViolations. Right now, neither is used in the main codebase yet because this issue & PR are only focused on setting them up for future use in other PRs, which aren't visible here yet.
The improved readability will be most important when we actually start to use this code in the MoneyRequestView component.
In React development, as you know, it's best to keep the component body as clean as possible for readability's sake. This becomes especially important when dealing with complex JSX syntax and nested components, which can quickly become hard to navigate.
Take, for instance, our MenuItemWithTopDescription component – it's already getting pretty large:
<MenuItemWithTopDescription
    description={translate('common.description')}
    shouldParseTitle
    title={transactionDescription}
    interactive={canEdit}
    shouldShowRightIcon={canEdit}
    titleStyle={styles.flex1}
    onPress={() => Navigation.navigate(ROUTES.EDIT_REQUEST.getRoute(report.reportID, CONST.EDIT_REQUEST_FIELD.DESCRIPTION))}
    wrapperStyle={[styles.pv2, styles.taskDescriptionMenuItem]}
    brickRoadIndicator={hasViolations('comment') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
    numberOfLinesTitle={0}
/>

Replacing
brickRoadIndicator={hasViolations('comment') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

with
brickRoadIndicator={getViolationForField('comment').length > 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

May seem to be a relatively small increase in complexity in itself, but the problem is cumulative, so we need to work to improve readability as much as possible where we can.
Since this logic repeats across several components, implementing hasViolations makes sense for consistency and clarity. Placing it in the useViolations() hook aligns it with related code, making it easier to understand.

re: 1. transactionVilations, I don't feel strongly, so I'll lean on what you're suggesting here
re: 2. hasViolations, I still think we don't need that function, and I don't agree that the second version of the code below is worse than the first, even if the problem you're describing is cumulative. Is hasViolation only going to be called in MoneyRequestView ? If so, perhaps we can define a local hasViolations function inside MoneyRequestView, though I still like the simplicity of using getViolationForField better

brickRoadIndicator={hasViolations('comment') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

brickRoadIndicator={getViolationForField('comment').length > 0 ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

In react the first is definitely preferred to the second, but if you feel strongly about it I can not use hasViolations and instead add the conditional each time (I think there are six) that we need to calcuate that value.

Should I open a new PR for this? And if so, should I wait for the old PR to get merged first?

Yes, and yes, but the old PR is already merged, right?

Yeah that message was pre-merge.
I think all of the feedback from the PR got into the other branch before it was merged --  or are there outstanding issues you still wanted addressed?

If all the other feedback was addressed, hasViolations is the only outstanding change, but if that's really the only one, we can just close this issue and do that later if needed

If that's not removed in that branch, I've removed it in the MoneyRequestView branch so it'll get cleaned up regardless.


Cursor tokens

Good points @benoitgrelard, I feel a bit floaty about all the interactive components that don't look like actual links or buttons. I think there's also more wiggle room with them depending on how strongly you want to reinforce the click affordance:

Menu items—I think there’s a strong argument for default cursor menu and select items working well with pointer cursor buttons, as the menu item affordances are obvious once the menu is open. VS Code has pointer cursor buttons but native menus with the default cursor, feels fine.
Slider—I agree, the thumb probably warrants a separate var.
Switch—not sure if this should get a separate control or work together with the button setting?
Radios and checkboxes—have rarely seen these with pointer cursor when they are not a part of a label with some background hover style. E.g. GitHub has pointer cursor buttons, but default checkboxes. Slack uses pointer checkboxes together with pointer checkbox labels (no background hover effect, feels hideous).
Cards that are <button>—no idea what to expect here as a user. Crossed my mind a few times that all interactive cards should always get pointer cursor by default because Card is not a common affordance for interactivity on desktop, but definitely exists in the wild (we have it in the WorkOS dashboard in one or two places).

And one final thing, do you have a preference when it comes to the naming style—--cursor-button vs --button-cursor? Maybe this depends on how many fine-grained cursor options we are going to have?


Unable build qt5-base under windows

Unable build qt5-base under windows
Enable fix-system-pcre2.patch again for successful build
diff --git a/ports/qt5-base/portfile.cmake b/ports/qt5-base/portfile.cmake
index 39498b4a..c398b437 100644
--- a/ports/qt5-base/portfile.cmake
+++ b/ports/qt5-base/portfile.cmake
@@ -42,7 +42,7 @@ file(REMOVE_RECURSE ${SOURCE_PATH}/include/QtZlib)
vcpkg_apply_patches(
SOURCE_PATH ${SOURCE_PATH}
PATCHES
-#        "${CMAKE_CURRENT_LIST_DIR}/fix-system-pcre2.patch"

   "${CMAKE_CURRENT_LIST_DIR}/fix-system-pcre2.patch"
   "${CMAKE_CURRENT_LIST_DIR}/fix-system-freetype.patch"

)

@ras0219-msft Please see. I can provide more logs.

Thanks a ton for catching this regression and providing the fix! I've added it back in on master :)


Update Grafana dashboards in Grafana UI

Please describe the Improvement and/or Feature Request
OSM Grafana charts rare imported to Grafana UI as well here : https://grafana.com/grafana/dashboards/14145. The dashboards here are very old and have not been updated for a long time. Please update them with the dashboards from : https://github.com/openservicemesh/osm/tree/release-v0.11/charts/osm/grafana/dashboards .
Once this done, pdate the documentation here as needed : https://github.com/openservicemesh/osm-docs/blob/327c06c3ca1fc73d421bd785841e278903942044/content/docs/demos/prometheus_grafana.md#importing-osm-dashboards
We should also add this to the release process, whereby every time a new release is cut the dashboards in the Grafana UI are also updated.  Please update the release documents based on the steps followed to update s that anyone doin the release is aware and follows the required steps.
Scope (please mark with X where applicable)

New Functionality          [ ]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [X]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Demo                       [ ]
Project Release            [ ]

Possible use cases
Upto date dashboards in Grafana UI

@jaellio would you be able to take this up, since you have experience with Grafana ?

@phillipgibson filed a support request with Grafana labs to unblock this issue.

With @shalier's help, I created this PR in the OSM docs repo to temporarily remove references to Grafana.com in the instructions for getting the OSM Grafana dashboards. Once the support request with Grafana Labs has been resolved references to Grafana.com can be added back to the docs.
The Grafana images on the docs site are updated in this PR and reflect the dashboards in v1.0.0-rc.2.
With the above-mentioned PRs, this issue is no longer a blocker for v1. I think this issue should be moved to the vNext milestone.


Not working on https://www.onlinesbi.com/

Yes, it was working last month, was it because of updated code or something in browsing like web language update is the reason for not working?

I cannot log into https://www.onlinesbi.com/, so I'm using https://corp.onlinesbi.com/saral/login.htm (after clicking "Continue to login"), for my testing.
There are many ways that a website author can try to control a user's browsing experience, this extension is just meant to prevent a site from blocking copy and paste browser events -- which is the most direct way for a site to interfere with copying/pasting, but not the only way. As @ThomasMldr mentioned, they are also blocking the contextmenu event (right click). Taking a quick look at their JavaScript, they are also trying to prevent copy, cut, and paste by listening to keyboard events involving the Control key. Since I'm using a Mac, I'm able to paste when this extension is active because the key combination is Command+v. For non-Mac computers, with this extension active, you'd need to use the Edit menu then select Paste from there.
I don't want this extension to start interjecting itself into keyboard and mouse events, as I'm afraid this extension would break more sites than it fixed if it were to do that.

Awesome! It's working now from Edit menu method. Thanks!!

Glad to hear.


Use HubSpot for signup form

Description
Closes #644
Refactors the signup form to use the hub spot form API instead of MailChip. This works by using the HubSpot API to create an invisible form in the SignupForm component. We then use DOM APIs to update the form and submit it.
This feels a bit hacky, but is the suggested approach in the docs:

Demo
https://user-images.githubusercontent.com/2176050/190032829-bfbc9683-fc12-4647-9a67-00d8553ce04d.mp4

@codemonkey800 has verified that the new form is functional and sending data to Mailchimp on this dev branch

@codemonkey800 @neuromusic After a user subscribes via their email, if they were to do the same thing again, would it tell them the email address has already been subscribed, or would it show "Thank you for joining our newsletter" again?


ability to prompt the user for confirmation before closing a focus view

Trigger a prompt when the user attempts to close the drawer, and ask them to confirm before closing

The confirmation dialog does not show up on closing the focussed view by clicking the X at the top or when we have a secondary action like cancel. It works only when focussed view is closed by clicking outside or pressing escape. Can this be fixed to make the conformation dialog appear on all focussed view closing scenarios ?

@Rajkiran0147 Thanks for this note. I've opened up a new issue and you can track progress there: https://github.com/stripe/stripe-apps/issues/651


ng build -prod fail

$ ng build -prod
ERROR in ..\ng-tree-antd\index.ts(10,2): Error during template compile of 'NzTreeModule'
Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule'
'NgModule' calls 'ɵmakeDecorator'.

尝试使用最新版本的 angular-tree-component，我本地未发现该问题


request to add rss support to gui.

wanna to display sensors status on pc screen with rainmeter(using plugin webparser).see this pls:https://docs.rainmeter.net/tips/webparser-tutorial/.
if a rss webpage is not diffcult to build, pls add it to your plan. thanks.

Hi @philboycn,
I don't think this is in-scope for this project. Exposing an rss feed based on the status of the homebridge accessories is probably best handled in a separate homebridge plugin.


Create workflow for Z-phase calibration

This calibration workflow is created for excitation preserving 2-qubit gates and assumes an error model that can be described with small random z-rotations
0: ───Rz(a)───two_qubit_gate───Rz(c)───
                │
1: ───Rz(b)───two_qubit_gate───Rz(d)───

for some small angles a, b, c, and d.

when the error model doesn't apply the workflow may give absured numbers (e.g. fidilities $\notin [0, 1]$). The fidilities can be slightly outside the $[0, 1]$ interval because it's a statistical estimate as can be seen in the following figure which compares the estimated fidelity of a CZ surrounded by random z rotations before and after calibration

test notebook: https://colab.sandbox.google.com/drive/10gZ5dggYKH_xSsCJFpg__GakxvoaZDIi

@pavoljuhas ptal
@eliottrosenberg I was not able to reproduce the warnings you recieved locally


Remove "cluster" string from events name

Hi, I am not sure why it was there in the first place (probably to match the clusterclick event), but the following line
const clusterEvent = `cluster${eventAsProp.substring(2).toLowerCase()}`;
was messing with most Leaflet.markercluster events as spiderfied.
Removing the "cluster" instance addresses that problem.

Should not be closed.

Still relevant

Bump


small revision of the intro

I am going over the text again and fix the last remaining issue + improve the grammar when necessary.

I am merging that one to work on @jrgissing PR without conflict.


Openverse should be added to supported search engines

Fixes
FIx #37 by @bunmix
Description
Add Openverse as a supported search engine on the search portal.
Technical details

Update index.php
Add openverse element to page display
Add redirection to openverse site in both index.php and search.js

Tests

On the search portal page, enter the search string
Check/uncheck the filters you want to add/remove
Confirm your search results on the Openverse search page

Verify that checked / unchecked filter(s) reflect on Openverse.
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@bunmix You'll need to correct the merge conflicts here before this can be Approved.


Publish updates from master

Publish the latest updates from master.

@StefanScherer @thaJeztah Could either of you approve the PR to publish release notes for the Desktop Edge release? Thanks.


error?

Also, if there is already a file present in the cache directory, VeloxDownloader removes the files and replaces the file.

when i download my file the second time(mean i finished the first file,and press the download button second time):
file1 got deleted : true
file is finished downloading

is this mean the second i download the file,it do not redownload the file from the remote url? instead it just replace the file?
then i reopen the app,the temp file deleted,and the cache file still exist,i press the download btn ,the file download from remote url and replace the file that in the cache file?
is that right above?

Hi @bulolo
Thanks for reporting this. I have identified and fixed the issue in version 1.6. Now downloading will occur every time and will either create a new file or will replace the existing file if it's present in the cache. Please download the version 1.6 of the VeloxDownloader.
put following in your PodFile.
pod 'VeloxDownloader', '~> 1.6'
Along with this I have also fixed an issue related to VeloxDownloader UI so if you want to try that you can see it in action by cloning and running this project.
git clone https://github.com/nitinsh99/VeloxDownloader.git
Please verify and let me know so we can close this issue.


Add note about Chromebook

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/4473

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LolaJacobsen
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Python dependency upgrade

[x] Upgrade indirect dependencies including parse.

[X] Upgrade Django.

[x] Upgrade Twisted.

[x] Upgrade Pillow.

This is ready for a review.

Added commit to upgrade Pillow as well.

Merged, thanks @hackerkid!


_overview_radio_clicked() takes 1 positional argument but 2 positional arguments were given

Originally reported on the forum here. I can reproduce on MNE/MNE-QT-Browser main with:
from mne import set_config
from mne.datasets import sample
from mne.io import read_raw_fif

set_config("MNE_BROWSE_RAW_SIZE", "20,10")

directory = sample.data_path() / "MEG" / "sample"
raw = read_raw_fif(directory / "sample_audvis_raw.fif", preload=True)
raw.plot(
    show=True, block=True, duration=20, bgcolor="w", color="b", bad_color="r"
)

Changing to Z-score fails with:
TypeError: MNEQtBrowser._overview_radio_clicked() takes 1 positional argument but 2 positional arguments (and 2 keyword-only arguments) were given.

Screencast from 03-06-2023 04:10:59 PM.webm

@mscheltienne can you look into a fix?

I had a quick look, but nothing weird strikes me.. and I am not very familiar with Qt, GUI, ...
The method is defined here: https://github.com/mne-tools/mne-qt-browser/blob/e3fec001106fab34db0dc87f121f50dc278ddc40/mne_qt_browser/_pg_figure.py#L3396-L3398
And is linked to the button here: https://github.com/mne-tools/mne-qt-browser/blob/e3fec001106fab34db0dc87f121f50dc278ddc40/mne_qt_browser/_pg_figure.py#L3085-L3087
Not sure what _methpartial is for.. https://github.com/mne-tools/mne-qt-browser/blob/e3fec001106fab34db0dc87f121f50dc278ddc40/mne_qt_browser/_pg_figure.py#L2666-L2675
It looks like when the radio button is clicked, _methpartial: call is called with args_=(True,) and kwargs_={}, but I don't know where this extra True is coming from.

I think the hint is in
            radio.clicked.connect(

this is a Qt signal:
https://doc.qt.io/qt-6/qabstractbutton.html#clicked
So I think the key is to change some signature to (self, checked=False, *, ...) or so