Timeframe for adding geometry shader semantics and other missing features?

Hey, love this project! Was looking for a shader cross compiler to integrate into my engine (https://github.com/bearishsun/bansheeengine) and this seems like exactly what I need.
I'm wondering do you have a rough timeframe when you might add full support for geometry shaders and (potentially) other missing features? Would love to try integrating it once those features are in.
And as a side note, do you have plans on adding a reflection API so we can query uniforms & vertex inputs? Or just exposing the AST in some way so this information can be easily retrieved (if not already possible)? It could come very handy and avoid having separate reflection code depending on the render API used.
Anyway, keep up the good work.

Thanks for the feedback :)
I definitely have planed to support Geometry- and Tessellation Shaders as well.
But since I do this in my spare time, I can not give any precise timeframes or deadlines.
In addition to geometry and tessellation, there are a few nice-to-have features, which I don't know if I will implement them at all. One of them are the classes and interfaces in HLSL, because I think it's very hard to translate it to GLSL (subroutines should be the counterpart I guess).
Full access to the AST is not part of the API, but take a look at the Reflection.h file, where a couple of information can be retrieved, such as all attributes of static SamplerState objects for instance.
More reflection information may come.

Sounds good. Personally I don't care about classes or interfaces - in fact right now I can't think of an engine that actually uses them. Therefore I'd be very happy with a specific minimum subset of functionality, with those less commonly used features left for last (or ignored).
One thing that might be helpful (or not): Generating "binding" qualifiers is very important for GLSL consumed by Vulkan (i.e. converted to SPIR-V). I'm finding them problematic because you pretty much need to explicitly define them in shaders - they can't be auto-generated as shaders get compiled separately, yet they need to be unique across all currently bound shaders - which I'm not sure how to guarantee, other than just explicitly setting the binding indices. I'm guessing you could generate them somehow from HLSL register keywords? Just food for thought, unless you thought about it already.

Do you mean something like the --explicit-bind shell command?
Here the binding point is generated from the texture-register slot: GLSLGenerator.cpp.

Yep seems like it. As long as a specific register is translated to a specific binding, and that register name maps to the same binding in different shaders.
It might be problematic to deal with different register types, like texture or uniform ones, which need to map to different binding indices across shaders. For example a vertex shader has a constant buffer at b0, and a texture at t0. Ideally constant buffer would map to binding 0, and texture to binding 1. But then what happens when the pixel shader uses the same texture ? When compiled and parsed separately it would receiving binding 0, which is the binding of the constant buffer.
The only decent way of handling that I can think of, is to group bindings into sets (using the "set" qualifier). This way all textures would be in set 0, all constant buffers in set 1, etc. I'm not sure if that has any downsides though.

Registers in HLSL can be indeed target specific, which is handeld by XShaderCompiler, too.
By default, all targets (or rather shader profiles) get the same slot.
But why should it be problematic for uniform buffers and samplers to have the same binding point in GLSL?
I see that this is a problem for a "uniform sampler2D" and a "uniform float" for instance, since both are 'standard' uniform qualifiers.
But uniform buffers should have there own binding space (correct me if I'm wrong).

They don't have their own binding space. Its one shared binding space between all shader stages and all parameter types (uniform buffers, textures, buffers, etc.). You can explicitly pick a different binding space by using the "set" qualifier though.
Not sure if we're misunderstanding each other, so in another words, you can't have same binding for different types in the same shader:
layout (binding=0) uniform texture2D mySampledImage;
layout (binding=0) uniform myUniformBuffer
{
vec4 myElement;
};
You also can't have the same binding across shader profiles (if used together):
Vertex shader:
layout (binding=0) uniform myUniformBuffer
{
vec4 myElement;
};
Pixel shader:
layout (binding=0) uniform texture2D mySampledImage;

Ok, I understand. Maybe in this case, a programmer how knows that a shader will be ported to GLSL should be aware of this issue.
It's a similar problem like the lack of Texture/SamplerState-separation.
Nonetheless, some kind of reordering of the binding points should be possible, but than host application needs to know the reordered slots, which should be accessible through the shader reflection.

Yeah, perhaps just provide a way for the app to specify how to translate registers into bindings (either via a callback, or by providing a builtin way or two). Anyway, just wanted to bring to keep it in mind :)


upgrade jdk17.

Fixes #121
Motivation
upgrade to jdk17.
Documentation
Check the box below.
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

This PR will only be cherry-picked to branch-2.11+

all right.


Fix jruby builds

Install jruby manually in a generic language image, since we can't modify the /home/travis/.rvm/gemsets/jruby/global.gems in what travis gives us.
travis home/travis/.rvm/gemsets/jruby/global.gems  has in it jruby-openssl wich makes rvm install a new version of jruby-openssl whenever we install jruby, making the test suite run with that jruby-openssl version instead of the one that comes with jruby itself an break.

@bundlerbot r+


stow: patch that removes warning for 2.2.0

This removes an annoying warning that is only going to be patched with the next release, which could be quite a while. See http://git.savannah.gnu.org/cgit/stow.git/commit/?id=d788ce0c1c59b3158270143659f7a4363da73056

@garbas Just closing a merge without saying why isn’t quite helpful, you know.


Segmentation fault from RootInitializer::init

The following initialization code causes an segfault:
let root = RootConsole::initializer()
  .size( 80, 50 )
  .title( &title )
  .font( Path::new( "data/terminal.png" ), tcod::FontLayout::AsciiInCol )
  .init();

It was built on 64bit Windows 7 with rustc 1.8.0 and gcc.exe (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 4.9.1.
The stack trace is:
#0  0x000007fefde611cb in msvcrt!memmove () from C:\Windows\system32\msvcrt.dll
#1  0x00000000004e6d62 in TCOD_sys_read_png (filename=0x4fd854 <TCOD_ctx+20> "data/terminal.png") at libtcod/src/sys_sdl_img_png.c:87
#2  0x00000000004e64da in TCOD_sys_load_image (filename=0x4fd854 <TCOD_ctx+20> "data/terminal.png") at libtcod/src/sys_sdl_c.c:2006
#3  0x00000000004e56aa in TCOD_sys_load_font () at libtcod/src/sys_sdl_c.c:226
#4  0x00000000004e51fa in TCOD_sys_init (w=80, h=50, buf=0x620080, oldbuf=0x62fab0, fullscreen=0 '\000') at libtcod/src/sys_sdl_c.c:1057
#5  0x00000000004c3541 in TCOD_console_init (con=0x366d20, title=0x7ac550 "Atina v0.1.0", fullscreen=0 '\000') at libtcod/src/console_c.c:1069
#6  0x00000000004c3673 in TCOD_console_init_root (w=80, h=50, title=0x7ac550 "Atina v0.1.0", fullscreen=0 '\000', renderer=TCOD_RENDERER_SDL) at libtcod/src/console_c.c:1049
#7  0x00000000004192b9 in tcod::console::RootInitializer<'a>::init (self=0x22fb80) at C:\Users\Administrator\.cargo\registry\src\github.com-88ac128001ac3a9a\tcod-0.9.0\src/console.rs:487
#8  0x00000000004016f3 in atina::CoreState::new () at src/main.rs:30
#9  0x000000000040c744 in atina::main () at src/main.rs:104
#10 0x000000000046d5de in sys_common::unwind::try::h4717244116533778359 ()
#11 0x000000000046d4a6 in rt::lang_start::hfbc17a9e986c24d2ZSz ()
#12 0x000000000040c7eb in main () at src/main.rs:109

Now this might be a bug in libtcod, in that case I'll file a bug report there.
The image being loaded by the way is the standard terminal.png.

I cannot reproduce this on Linux, and it very much seems like a libtcod (or a 3rd party library) bug. The Rust initializer code does very little. The only error-prone thing would be the Path -> C string conversion, but it's done by the standard library, but the libtcod code gets way past anything that would indicate that it has anything to do with wrong filenames.
The code in question:
bitmap=TCOD_sys_get_surface(width,height,bpp==32);
source=image;
rowsize=width*bpp/8;

for (y=0; y<  height; y++ ) {
	Uint8 *row_pointer=(Uint8 *)(bitmap->pixels) + y * bitmap->pitch;
	memcpy(row_pointer,source,rowsize);
	source+=rowsize;
}

I don't know why it would segfault though. There's error handling for image (and so for source) a few lines above, and since it dies on the memcpy, the TCOD_sys_get_surface call probably succeeds. My best guess is still source being a null pointer (or incorrectly reported width or height).

Okay, I'll try to find out if it's Path or libctod whose the source of the error.
Closing this issue then.

I found out that after calling SDL_AllocSurface with a height of 128 in this case, it returns a surface with a h feild of -1163066880 and a pixel null pointer. This seems to be an SDL bug


Thanos support

Checklist

[x] Keep pull requests small so they can be easily reviewed.
[ ] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[ ] Link this PR to related issues.

Implementation seems good as far as I can tell, but I'm missing documentation for the new component parameters in https://github.com/projectsyn/component-rancher-monitoring/blob/2cd563b8c491e13a5dfc37018394cafa716f047e/docs/modules/ROOT/pages/references/parameters.adoc
Please make sure to document the new parameters prometheusAdditionalConfig, thanos, and rules, and ideally extend the existing example or add a second example showing how those parameters can be used to configure Thanos.

I have removed the prometheusAdditionalConfig paramater since I don't need it in the end.
I have also documented the two other parameters.

PS: It's sufficient to just add the enhancement label for new features


problem with nosql tmp

Hi,
I have really bad problem with this error:
have error: Error: ENOENT: no such file or directory, rename '/www/www/eshop/databases/users.nosql-tmp' -> '/www/www/eshop/databases/users.nosql'

Which version of Total.js do you use? Do you use cluster?

2.9.4

Do you use cluster? Please describe me where/when/under what conditions this problem has been created?

No I don't user cluster.
I get this error when I wanna insert data into nosql db.

And I'm using superadmin for it

I found more information
Whenever I update db with large data with nosql modify method this error shows up
Maybe db become so large and it cant search for specific id using where method?


Improve load-time performance of widgets

When mounting a lot of widgets, the time to mount can add up quite a bit. This issue highlights a couple ways to deal with it. These PRs are ordered in the ordering they should end up in master.
Times are for an extreme app which mounts hundreds of widgets using DynamicWidgets.
If you want to try out the final bundles, those are available in the last PR in the chain: https://github.com/algolia/instantsearch/pull/6007#issuecomment-1896167602
swap clearRefinements for individual refinement clearing methods which are more efficient 🟠

PR: #6004
impact: 650ms -> 350ms

Fix sort of facet values in requestBuilder 🟠

PR: #6007
sort the facet values in a non-mutating manner for cache hit rate
issue is shown in failing test in #6006

avoid a copy of parameters to set in setQueryParameters and new SearchParameters 🟠

PR: #6006
impact: 350ms -> 120ms

Don't recompute search parameters for every widget 🔴

privateHelperSetState function needs to loop through every already added widget, and this is called once per addWidgets. In react there's one addWidgets for every widget, instead of being able to call addWidgets once for all widgets at once
impact: 120ms -> ~70ms(?) (only an estimate, this was completely removing the code completely)
relevant code:
https://github.com/algolia/instantsearch/blob/2258d899fab887d495af8f31905f0974f53e8e47/packages/instantsearch.js/src/widgets/index/index.ts#L326-L333

Don't clean up "unused" UiState and parameters 🔴

For the moment this is too much code to change to be able to measure, but we have a decent amount of impact cleaning up the impact of a widget no longer being mounted in getWidgetSearchParameters and getWidgetUiState. This would be more efficient if we left the empty values in place instead of looping and checking if every value is empty.
This isn't straightforward to change, as UiState is passed to routing for example where we need to be sure empty values are removed (they aren't today), as well as for inheriting parameters with multi-index, where an empty values implies a child index takes preference over a parent index, even if it has no refinements.

Exciting @Haroenv - I think https://sorare.com/football/market/new-signings could be a great production use-case to confirm those numbers  ; I can give this a try next week

@Haroenv I'm a bit confused, is instantsearch.js 4.64.1 including those?

Hi @redox, Haroen is off so I'll answer in his place. Today's release of<EMAIL_ADDRESS><EMAIL_ADDRESS>and<EMAIL_ADDRESS>include the PRs mentioned in this issue.


Add autoformatting

This PR adds instructions on how to use JuliaFormatter for enforcing the Blue style in the README and applies it to all files.
The PR also adds a workflow that will make a PR fail if the formatting is incorrect. I am happy to make the formatting optional and disable the workflow if others think this is too strict.

I'm happy with forcing the style guide as part of the CI workflow. It would force me to familiarise myself with the style and follow the guides, while otherwise the "optional" part will make it very easy to ignore.
It is also good to establish the formatting sooner rather than later to ensure the the repo formatting is coherent from the get go.

The nice thing about JuliaFormatter is that it does it for you so in fact you can almost forget about it (other than running the format function) but it ensures that the code looks consistent


(Fix) Step4 - transaction is generated after each page refreshing

Closes #1113
Based on what was discussed in the issue, each step of the deployment process was divided into steps, each of which is properly updated and serve for traceability of every tx status.
If a tx is not signed (confirmation pending), and for instance, the user refreshes the page; that tx will be considered as Lost. In this scenario, a modal asking the user to reject/cancel the current pending tx will be displayed.
If the page is refreshed after signing the tx, and the transactionHash was stored (transaction pending of being mined); the wizard will update the tx status based on the information retrieved from the blockchain based on the transactionHash stored.
NOTE: Despite the intention of this PR is to prevent multiple txs being queued, TW cannot prevent the user from cheating the wizard and clicking 'Continue' even if the Lost tx wasn't rejected in the wallet. Thus this situation may lead to having more than one tx pending in the wallet (you can see that behavior being simulated in the last step of the deployment in the video).
This is a video where I tried to generate all possible scenarios to make the deployment process fail: https://drive.google.com/file/d/1653l5Xq3qdTwEFQbfbUrF0Np0J5oRcRX/view
PS: Do not evaluate the styles, I just did structural changes to facilitate the redesign work. Thus, styles will be changed in the redesign process.

Pull Request Test Coverage Report for Build 3219

11 of 114 (9.65%)  changed or added relevant lines in 7 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.5%) to 19.223%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utils/alerts.js
0
1
0.0%

src/components/stepFour/utils.js
0
2
0.0%

src/utils/blockchainHelpers.js
4
16
25.0%

src/components/Common/TxProgressStatus.js
0
14
0.0%

src/components/stepFour/index.js
0
33
0.0%

src/stores/DeploymentStore.js
1
42
2.38%

Files with Coverage Reduction
New Missed Lines
%

src/stores/DeploymentStore.js
1
6.34%

src/components/stepFour/index.js
1
0.0%

src/utils/blockchainHelpers.js
2
9.26%

Totals

Change from base Build 3165:
-0.5%

Covered Lines:
887

Relevant Lines:
3921

💛  - Coveralls

If user rejected transaction in a wallet for some reason then there is no way to restore this transaction unless to reload the page. I think there is should be more understandable way  to restore transaction. It could be:

In modal add button restore transaction in addition to button skip transaction
OR/AND
If user select No in alert  Skip transaction then transaction will be constructed again
@fernandomg  thoughts?

@dennis00010011b, good point
I'd rather prefer the idea of adding a button by the skip transaction button.
Will try to implement it.
Thanks!

@dennis00010011b Now a button retry transaction will appear next to the skip transaction option.

@fernandomg
App crashed if user attempt to contribute

Steps:

Create Minted crowdsale, 1 tier , no whitelist, mincap = 0( I tried with ganache, Sokol, Ropsten)
Open contribution page and buy any valid amount

@dennis00010011b, fixed the

@fernandomg
Crowdsale initialized with incorrect start/end time if 2nd transaction is skipped and retried.
Steps:

Start creating crowdsale: Minted, no whitelist , 1 tier. Keep start end time by default
In Step 4 skip and retry 2nd transaction
Finish deployment
Observe start/end time on Publish, Manage, Contribution pages
Actual result:

time values  is incorrect (converted to UTC and set as local time)

Sokol, 0xac93a5c5414d9dff190094d686b00d6464dcb613
https://www.useloom.com/share/4e6d8da4a28b470abfea1e931b58e629

Crowdsale initialized with incorrect start/end time if 2nd transaction is skipped and retried.
@dennis00010011b, tricky thing you found. Where you in GMT -7 by chance? Clearly, there's an offset of +7 in the values, except for the summary in step four, that is +14.

I'll check that tomorrow. Thanks

Where you in GMT -7 by chance?
@fernandomg Yes, my local machine time was PDT( Pacific Daylight Time) = GMT-7

Crowdsale initialized with incorrect start/end time if 2nd transaction is skipped and retried.

@dennis00010011b fixed.
Please take special care on this change review, as I modified part of how the dates are handled.
I didn't find any issue. Dates are being displayed in UTC+0 in the publish screen, and in the downloaded files. Manage screen shows dates in local TZ.
@mariano-aguero Your feedback is really appreciated

The issue was that when a tx is being constructed, a method is called which modified the dates stored in the tierStore... that is not a problem if the tx happens only one time. But in the scenario that Dennis found, if the user retries the tx, the date already modified is modified once again, and it will continue happening for every repeat of a tx construction.


How can I precisely select one barcode among many?

I want to scan the only single barcode among many and found the following guide in FAQ:

Start the scanner in paused mode (camera preview on but not scanning) and:

Use our laser UI (you will find it in the ScanOverlay class of your platform in our documentation) to give the user a precise indication of where he should scan.
Restrict the scanning area (you will find a guide about it for your platform in our documentation) to a thin line in the center of the screen.

Add a “Scan” button to [resume the scanner] on user tap. When the scanner is active, the button can be greyed out and display “Scanning”.

When a barcode is scanned, [pause] or [stop] the scanner. This will ensure that you are not scanning any other codes.

But I dont know how to add "Scan" button to barcode picker UI and can't find anything in documentation.
I've tried also Multiscan feature, but there is no possibility to select barcode interactively.

Hi @abondarenko
Our 5.x cordova plugin is limited in the way that you are unable to add buttons on top of it (this is something that will be addressed in our new 6.x plugin, but only with version 6.2 at the end of the year, so you can't move to that yet). The option you have in 5.x is that you add constraints which will make the scanner not fill 100% of the screen. That way you can place a button in the area where the scanner isn't. So for example you can set a bottom constraint of 20% to show the bottom 20% of the webview below where you can place a button that starts/pauses/stops the scanner.
Multiscan is also something that is limited in the 5.x plugin, a nice Cordova solution there will only be available with 6.3.
I hope that helps, if you have follow-up questions, just ask.


Percentile and percentile standard error speed up/default behavior

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1779
What are the significant changes in functionality due to this change request?

Vectorizes innermost loop of percentile and percentile standard error calculation to improve computation time

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 The computation should be significantly faster now. Is this fast enough, or do we need to implement the standard normal method?
Before merging, I would like to include some notes in the documentation about the sample size needed for percentile and its standard error calculation from the paper.

@dgarrett622 Thanks for updates. I have checked the test, it reduced the time to ~170s now. Original test took about ~130s. I think the changes would be good for now. But I would like to keep the issue open. The only thing I'm worried about is the nonlinear increase in time. We may need to add a benchmark test in the future to prevent this behavior.

I discovered some additional enhancements for speed when using _computeWeightedPercentile. It will involve using xarray.DataSet methods directly when probability weights are provided but are all equal. This will likely require new gold files for some tests. Since some gold files will already need to be updated, I'll update _computeWeightedPercentile with numpy.interp to (hopefully) provide a faster computation.
The KDE implementation is more accurate, however, it takes far too long to compute for even moderately sized samples. I'll implement the standard normal formulation of the standard error for speed.

I made a number of changes that significantly speed up the percentile and percentile standard error calculation. Whenever possible native xarray.DataSet.quantile() is used. This yields a slightly different value than before for many cases. I had to update the gold files for many tests. I suspect this will impact a number of plugin tests that use percentile and median.

Adding the user specified 'interpolation' parameter to median and percentile affected _computeWeightedPercentile which is used in EconomicRatio. I rolled the fixes for #1775 into this PR since EconomicRatio required updates with this new 'interpolation' parameter.

@dgarrett622 One more comment, please update some tests to reflect the option of "interpolation=midpoint". In this case, you will test both situations.  Also an email to the user group need to be drafted to reflect the changes.

Email draft for users:
Dear users,
PR #1780 makes a number of changes to the BasicStatistics and EconomicRatio PostProcessors that change some of the calculated statistics. This PR introduces the following changes:

median and percentile in BasicStatistics now have an additional parameter, "interpolation," that can take the values "linear" or "midpoint." This parameter influences how RAVEN interpolates between data points to calculate the median or percentile. The default is "linear." To get the previous behavior, use "midpoint."
valueAtRisk and expectedShortfall in EconomicRatio have the same "interpolation" parameter as median and percentile.
Due to the long computational time to calculate the standard error for percentile and valueAtRisk, the standard error method has been changed. The new method is much faster, however, gives slightly different values.
xarray has been used wherever possible to speed up the computations. This may result in slightly different values for median, percentile, and valueAtRisk.

Job Test qsubs sawtooth on 2cf63ff : invalidated by @dgarrett622
failing test does not use PostProcessor, run again

@dgarrett622 I have merged your PR, could you send the drafted email to raven user group?


New GPAW parser, simple Base Workflow

Major changes:

Added GPAWParser: In case gpaw is the code, the GPAW parser will take parse and store many attributes specific to this code, over and beyond what is expected from AseParser. It also provides more detailed error options.
Addition of BaseGPAWWorkChain: A very simple BaseWorkchain for restarts.

Minor changes:

Store and create files in calculations: Create gpw files which are helpful for restarts, allow for WriteIntervals (from link).
Tests for parser

Thanks @sudarshanv01


Crash when selecting a broken symlink

Hi, first of all: nice work! It looks really fancy.
I did however immediately encounter a tiny bug because I had a broken symlink in my home directory.
Reproduce:

ln -s /broken/link test
Open superfile and move the cursor to the test file.

Output:
Caught panic:

runtime error: invalid memory address or nil pointer dereference

Restoring terminal...

goroutine 1 [running]:
runtime/debug.Stack()
   /usr/lib/golang/src/runtime/debug/stack.go:24 +0x5e
runtime/debug.PrintStack()
   /usr/lib/golang/src/runtime/debug/stack.go:16 +0x13
github.com/charmbracelet/bubbletea.(*Program).Run.func1()
   /home/nightcat/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.25.0/tea.go:478 +0x91
panic({0x7f9300?, 0xc24300?})
   /usr/lib/golang/src/runtime/panic.go:920 +0x270
github.com/MHNightCat/superfile/components.returnMetaData({{{0xc00012f100, 0x1, 0x1}, 0xa8, 0x0}, {{{0xc000198f70, 0x5, 0x5}}, 0x0}, {0x0, ...}, ...})
   /home/nightcat/Documents/code/superfile/src/components/function.go:367 +0x1ef
github.com/MHNightCat/superfile/components.model.Update({{{0xc00012f100, 0x1, 0x1}, 0xa8, 0x0}, {{{0xc000198f70, 0x5, 0x5}}, 0x0}, {0x0, ...}, ...}, ...)
   /home/nightcat/Documents/code/superfile/src/components/model.go:167 +0x109b
github.com/charmbracelet/bubbletea.(*Program).eventLoop(0xc00020fd40, {0x925d18?, 0xc0001c4800?}, 0xc00019eba0?)
   /home/nightcat/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.25.0/tea.go:411 +0x75a
github.com/charmbracelet/bubbletea.(*Program).Run(0xc00020fd40)
   /home/nightcat/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.25.0/tea.go:543 +0x86e
main.main.func1(0xc00020c160?)
   /home/nightcat/Documents/code/superfile/src/main.go:55 +0x9e
github.com/urfave/cli/v2.(*Command).Run(0xc00020c160, 0xc000146a40, {0xc000118050, 0x1, 0x1})
   /home/nightcat/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/command.go:279 +0x9dd
github.com/urfave/cli/v2.(*App).RunContext(0xc0001e0200, {0x926410?, 0xc65920}, {0xc000118050, 0x1, 0x1})
   /home/nightcat/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:337 +0x5db
github.com/urfave/cli/v2.(*App).Run(...)
   /home/nightcat/go/pkg/mod/github.com/urfave/cli/v2@v2.27.1/app.go:311
main.main()
   /home/nightcat/Documents/code/superfile/src/main.go:65 +0xa5

Hi! can u check this ?
https://github.com/MHNightCat/superfile/issues/7

I do have exiftool installed already, if that's what you mean :)

Ok i will check it thanks for report!

@thomasave  What is your super file version?

I tried it with v1.0.0 from the releases, but also when building it myself from master (v1.0.1)

Got it thank you

@thomasave This issue has been resolved thanks to your report!!
e89722b

I can confirm that it works now, thanks!
Small comment: there's a typo in the related message :)
Link file is broken!(you cant only delete this file)
Should be:
Link file is broken! (you can only delete this file)

oh yeah thanks!


Fix composer indentation

Also added an editorconfig file

Maybe we should set up a StyleCI in place rather than the editorconfig file?

Both are different.
.editorconfig will ensure most popular IDE to be conform of code styling, that make developer life better. :-) http://editorconfig.org/
StyleCI and PHP-CS-fixer juste make sure dev are not coding so bad. ;-)
Both should be implemented IMO.


Unknown properties are assignable to Object in union

For the last week or so they have been treated as excess properties when assigning to a union type containing Object, but not when assigning directly to Object type.
Fixes #15254

Maybe Object | string === Object before?

Oh, subtype reduction? Maybe.


adding remote backend

files/deploy_app.sh

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.


Remove layer7 components divert

The setting of the 'divert' array key was only done by layer7, so these downstream bits of code are also now dead.
What happens to rules in old configs that had layer7 selected? Now that there is no code to react to any layer7 setting, those rules are probably going to apply whatever other settings they had, without the diversion to the layer7 processing? Will that make people's rulesets become automagically/unexpectedly more permissive? Should there be code in upgrade_config.inc to remove (or disable) any rules with layer7 specified?

@phil-davis yeah I'd left that ticket there to finish some clean up. With 2.2.x systems, it'd pass a lot more post-upgrade because layer7 would /dev/null everything. :) Now 2.3 has config upgrade code to unset all of that from the config, and file a notice for those who had that in their config so users are definitely aware.

Yes, I noticed your addition of config upgrade code. Once users are aware, then it is up to them to re-evaluate their rule set and decide what to do with traffic that they previously passed to layer7 for evaluation.


[BEAM-1914] XmlIO should comply with PTransform style guide

R: @jbonofre

Coverage increased (+0.2%) to 70.665% when pulling 7607d797db0d898bb51f0fecf2da42b4e952c5b0 on jkff:xml-style into 3101e69c438d5c42577fc7d3476d623f6e551837 on apache:master.

Coverage decreased (-0.003%) to 70.446% when pulling 3d209e8b684d0a557beed635cd85068d410bce1b on jkff:xml-style into 0be61dbb5cb44d08edf2ffbb09dce1d810683aa5 on apache:master.


No implicit any

Codecov Report

Merging #210 into master will increase coverage by 0.23%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage    93.9%   94.14%   +0.23%
==========================================
  Files           6        6
  Lines         443      444       +1
  Branches       75       74       -1
==========================================
+ Hits          416      418       +2
  Misses          9        9
+ Partials       18       17       -1

Impacted Files
Coverage Δ

src/binding.ts
100% <100%> (ø)
:arrow_up:

src/component.ts
88.88% <100%> (ø)
:arrow_up:

src/route.ts
98.36% <100%> (+0.02%)
:arrow_up:

src/utils.ts
98.24% <100%> (ø)
:arrow_up:

src/router.ts
89.44% <86.66%> (ø)
:arrow_up:

src/context.ts
98.11% <94.11%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e95b1f...80609f9. Read the comment docs.


fix: converted bytes to string

This fixes the herokuapp error -- I think it happened because I'm using python 3.6 and I'm assuming heroku is using 3.5?

When running locally, I am still seeing an error associated with the gh_user["access_token"] call. On running, the page crashes yielding:
  File "brainspell.py", line 502, in get
    gh_user['access_token'])
KeyError: 'access_token'

Is the replicable on your computer?

yes -- try the latest commit?

nope, that commit broke something else! Don't merge yet!

ok, this one should work. Let me know! Try adding an article to a collection, and then refresh the page. Make sure it still shows up in the text input, and then try deleting it!

Unfortunately it looks like one more error popped up. On running python3 brainspell.py and navigating to the main page I get this error:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/tornado/web.py", line 1467, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "brainspell.py", line 52, in get
    gh_user = self.get_current_github_user()
  File "brainspell.py", line 39, in get_current_github_user
    return json_decode(user_json)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/torngithub.py", line 47, in json_decode
    return json.loads(to_basestring(value))
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/simplejson/__init__.py", line 516, in loads
    return _default_decoder.decode(s)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.scanner.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Last time I just put a Try catch around this method:
    def get_current_github_user(self):
        user_json = self.get_secure_cookie("user")
        if not user_json:
            return {"name": None, "avatar_url": None, "access_token":None}
        else:
            return json_decode(user_json)

Just to make sure that it keeps running, but that's probably not the best long term solution. Any ideas?

Do you know what self.get_secure_cookie("user") is returning? Its something non-empty but not JSON-like. I put in a more specific exception to make debugging easier

It looks like get_secure_cookie("user") is defined by:
class GithubLoginHandler(tornado.web.RequestHandler, torngithub.GithubMixin):
       ...
        # if we have a code, we have been authorized so we can log in
        if self.get_argument("code", False):
            user = yield self.get_authenticated_user(
                redirect_uri=redirect_uri,
                client_id=settings["github_client_id"],
                client_secret=settings["github_client_secret"],
                code=self.get_argument("code"))
            if user:
                self.set_secure_cookie("user", json_encode(user))
            else:
                self.clear_cookie("user")
            self.redirect(self.get_argument("next", "/"))
            return

But this is only set if a user is already logged in.
We have to add simplejson to the requirements, but otherwise I think this looks good to pull?


Remove the Prisma version check

Is your feature request related to a problem? Please describe.
It is inconvenient to have to wait for this library to update the (strict) peer dependency version for Prisma to be able to update Prisma. I understand that you can ignore this check with an env variable, but I'm struggling to understand why this exists in the first place. NPM already ensures peer dependencies, which can be overridden with --force.
Describe the solution you'd like
Remove the version check from the generator.
Describe alternatives you've considered
Setting the env variable SKIP_PRISMA_VERSION_CHECK to true.
Additional context
Note in README
Prisma version check file

I understand that you can ignore this check with an env variable

That's the solution you should use.

It is inconvenient to have to wait for this library to update the (strict) peer dependency version for Prisma to be able to update Prisma.

For the past year, ~75% of Prisma releases contained breaking changes for the typegraphql-prisma.
Disabling this check won't fix your issue, you will just see a stacktrace with undefined is not a function instead.

NPM already ensures peer dependencies

But not everyone uses npm@7, some of them overridde the deps, so that's why I was spammed by bug reports that "it doesn't work with Prisma 2.x.y".
Rejecting your proposal 🔒


Vector register

After preparing high level schema of vector core I start the implementation with the implementation of very simple (and very not optimal) vector registers. Next step is to create a more "intelligent" implementation.

[x] Continuous vector register with tests
[x] ~Interlacing vector register with tests~ (in separate PR)
[x] Split changes in utils to separate merge request
[ ] Add docs strings
[x] ~Add support for scalars~ (in separate PR)

I tried to implement inside VRRFragment a logic to make forwarding between reading methods e.g:

Let assume that we have two ports (p1 and p2)
We get request to read from v1 element on position x on both ports
In simple implementation this will take two cycles (first cycle to read by p1 and second to read by p2)
I tried to implement forwarding, so in case when the same element is read p1 read data from register and p2 copy read data from p1

Problem which I hit is that register is synchronous memory, so I need to have request - response pattern and I have to synchronize responses to have correct data forwarding from p1 to p2 (both p1 and p2 responses have to be called in the same cycle). I was able to write implication that p2 response is ready when p1 is run, but I don't see how to do that in the other way (I thought about some helper structures e.g buffers/fifos).
As for now I plan to drop this forwarding functionality and it will have to be handled either by unit reading register or there will be an additional cycle of delay. The other possibility was to leave only this implication, but this would be error prone due to timings dependency (both methods run in the same cycle).

Tomorrow I plan to add docstrings and merge it to development branch.


Add Serge

This merges all the various ways localization was set up in this repo into a single localization file with a Lit mixin and a Polymer behaviour.
That allows for Serge to be set up, which I'll connect once this merges.

I'm going to have to circle back to these tests on Monday. I thought converting to Playwright would help with the Safari problems, but it seems worse -- can't repro any of them locally.


feature request: bam splitting by HP tag

Hey @bluenote-1577 ,
Floria looks like a very promising tool !
One feature that would be very nice to have would be the splitting of the bam file generated by scripts/haplotag_output_dir.py by hapolotypes using the HP tag.
For example, from mapped.bam, you would get mapped_hp1.bam, mapped_hp[...].bam, mapped_hpn.bam

The use case I had in mind was for calling the consensus sequence by strain.
But maybe you have a better way of doing this ?

Hi @maxibor,
That's a reasonable thing to do...  see the script scripts/get_bam_partition.py that I tested quickly and seems to work. It can be used like this:
python scripts/get_bam_partition.py -b all_reads.bam -t contig1.haplosets contig2.haplosets -p some_dir/
and should split the files into something like 0.bam, 1.bam, 2.bam for each haploset index 0,1,2
let me know if it works for you


Support older ember-cli versions

Fixes the error, Path or pattern "EmberFire/**/*.js" did not match any files which was due to wrong case.
Updated peerDependencies to enforce ember-cli >=0.1.3, we need this for Blueprint.prototype.addBowerPackagesToProject
We could put some more energy in, to allow even older versions, by working around the following:

0.1.0 if we stopped using Blueprint.prototype.insertIntoFile with the after option
0.0.43 if we use Blueprint.prototype.addBowerPackageToProject instead of the multi version

/cc @puf


AWS logo is misleading

On the scanner page the AWS logo is showing (https://www.chainguard.dev/scanners), but after uploading a chainguard image (I tried node-lts:latest, sha256:d40e810c66fce05225a68aa6350f7365dd258e3f12434d310ff7fc1a308c60f5) to the ECR registry it is flagged as unsupported. Which is it?

UnsupportedImageError: The operating system and/or package manager are not supported.

They've committed to finishing the rollout within 2024H2.

Hello! Do you know if this is still en route for release?


Update index.rst to clarify .NET 4.5.1 requirement

Bump up to .NET 4.5.1 required

LGTM.

I think the current release does work on .NET 4.5 right? I've been bumping the min-version to 4.5.1 as I work on the updates for RC1. It's fine to leave this in, but master is for the current stable release.

I haven't tested. I thought we bumped to 4.5.1 before beta8.

I have never tested on a Vanilla 4.5 Windows 8.0 machine with VS 2012. I think the required Nuget tools in VS do not work with VS 2012 anyway


BUG: jax.linear_transpose of scan fails

Description
Consider these 2 equivalent functions. Only the one that doesn't use scan is differentiable via jax.linear_transpose:
def foo(p):
    x = jnp.zeros_like(p)
    for _ in range(10):
        x += p
    return x

def bar(p):
    return jax.lax.scan(lambda x, _: (x + p, None), jnp.zeros_like(p), None, length=10)[0]

# works
jax.linear_transpose(foo, jnp.zeros(10))(jnp.ones(10))

# nope
jax.linear_transpose(bar, jnp.zeros(10))(jnp.ones(10))

Traceback:
---------------------------------------------------------------------------
JaxStackTraceBeforeTransformation         Traceback (most recent call last)
File /opt/homebrew/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py:191, in _run_module_as_main(***failed resolving arguments***)
    190 except _Error as exc:
--> 191     msg = "%s: %s" % (sys.executable, exc)
    192     sys.exit(msg)

File /opt/homebrew/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py:75, in _run_code(***failed resolving arguments***)
     74 loader = mod_spec.loader
---> 75 fname = mod_spec.origin
     76 cached = mod_spec.cached

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel_launcher.py:12, in <module>
      9 if __name__ == "__main__":
     10     # Remove the CWD from sys.path while we load stuff.
     11     # This is added back by InteractiveShellApp.init_path()
---> 12     if sys.path[0] == "":
     13         del sys.path[0]

File ~/.virtualenvs/science/lib/python3.10/site-packages/traitlets/config/application.py:963, in Application.launch_instance(***failed resolving arguments***)
    959 """Launch a global instance of this Application
    960
    961 If a global instance already exists, this reinitializes and starts it
    962 """
--> 963 app = cls.instance(**kwargs)
    964 app.initialize(argv)

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/kernelapp.py:702, in IPKernelApp.start(***failed resolving arguments***)
    701 if self.trio_loop:
--> 702     from ipykernel.trio_runner import TrioRunner
    704     tr = TrioRunner()

File ~/.virtualenvs/science/lib/python3.10/site-packages/tornado/platform/asyncio.py:195, in BaseAsyncIOLoop.start(***failed resolving arguments***)
    194 except (RuntimeError, AssertionError):
--> 195     old_loop = None  # type: ignore
    196 try:

File /opt/homebrew/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py:594, in BaseEventLoop.run_forever(***failed resolving arguments***)
    592 self._thread_id = threading.get_ident()
--> 594 old_agen_hooks = sys.get_asyncgen_hooks()
    595 sys.set_asyncgen_hooks(firstiter=self._asyncgen_firstiter_hook,
    596                        finalizer=self._asyncgen_finalizer_hook)

File /opt/homebrew/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/base_events.py:1860, in BaseEventLoop._run_once(***failed resolving arguments***)
   1858     timeout = min(max(0, when - self.time()), MAXIMUM_SELECT_TIMEOUT)
-> 1860 event_list = self._selector.select(timeout)
   1861 self._process_events(event_list)

File /opt/homebrew/Cellar/python@3.10/3.10.5/Frameworks/Python.framework/Versions/3.10/lib/python3.10/asyncio/events.py:80, in Handle._run(***failed resolving arguments***)
     79 try:
---> 80     self._context.run(self._callback, *self._args)
     81 except (SystemExit, KeyboardInterrupt):

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/kernelbase.py:504, in Kernel.dispatch_queue(***failed resolving arguments***)
    503 try:
--> 504     await self.process_one()
    505 except Exception:

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/kernelbase.py:490, in Kernel.process_one(***failed resolving arguments***)
    489 try:
--> 490     t, dispatch, args = self.msg_queue.get_nowait()
    491 except (asyncio.QueueEmpty, QueueEmpty):

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/kernelbase.py:377, in Kernel.dispatch_shell(***failed resolving arguments***)
    376     self.shell_stream.flush(zmq.POLLOUT)
--> 377     return
    379 # Print some info about this message and leave a '--->' marker, so it's
    380 # easier to trace visually the message chain when debugging.  Each
    381 # handler prints its message at the end.

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/kernelbase.py:695, in Kernel.execute_request(***failed resolving arguments***)
    693 stop_on_error = content.get("stop_on_error", True)
--> 695 metadata = self.init_metadata(parent)
    697 # Re-broadcast our input for the benefit of listening clients, and
    698 # start computing output

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/ipkernel.py:352, in IPythonKernel.do_execute(***failed resolving arguments***)
    350 if with_cell_id:
    351     coro = run_cell(
--> 352         code,
    353         store_history=store_history,
    354         silent=silent,
    355         transformed_cell=transformed_cell,
    356         preprocessing_exc_tuple=preprocessing_exc_tuple,
    357         cell_id=cell_id,
    358     )
    359 else:

File ~/.virtualenvs/science/lib/python3.10/site-packages/ipykernel/zmqshell.py:528, in ZMQInteractiveShell.run_cell(***failed resolving arguments***)
    527 self._last_traceback = None
--> 528 return super().run_cell(*args, **kwargs)

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/interactiveshell.py:2881, in InteractiveShell.run_cell(***failed resolving arguments***)
   2879 try:
   2880     result = self._run_cell(
-> 2881         raw_cell, store_history, silent, shell_futures, cell_id
   2882     )
   2883 finally:

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/interactiveshell.py:2910, in InteractiveShell._run_cell(***failed resolving arguments***)
   2908 assert transformed_cell is not None
   2909 coro = self.run_cell_async(
-> 2910     raw_cell,
   2911     store_history=store_history,
   2912     silent=silent,
   2913     shell_futures=shell_futures,
   2914     transformed_cell=transformed_cell,
   2915     preprocessing_exc_tuple=preprocessing_exc_tuple,
   2916     cell_id=cell_id,
   2917 )
   2919 # run_cell_async is async, but may not actually need an eventloop.
   2920 # when this is the case, we want to run it using the pseudo_sync_runner
   2921 # so that code can invoke eventloops (for example via the %run , and
   2922 # `%paste` magic.

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/async_helpers.py:129, in _pseudo_sync_runner(***failed resolving arguments***)
    128 try:
--> 129     coro.send(None)
    130 except StopIteration as exc:

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/interactiveshell.py:3108, in InteractiveShell.run_cell_async(***failed resolving arguments***)
   3107     code_ast = compiler.ast_parse(cell, filename=cell_name)
-> 3108 except self.custom_exceptions as e:
   3109     etype, value, tb = sys.exc_info()

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/interactiveshell.py:3305, in InteractiveShell.run_ast_nodes(***failed resolving arguments***)
   3304     to_run_exec, to_run_interactive = nodelist[:-1], nodelist[-1:]
-> 3305 elif interactivity == 'all':
   3306     to_run_exec, to_run_interactive = [], nodelist

File ~/.virtualenvs/science/lib/python3.10/site-packages/IPython/core/interactiveshell.py:3394, in InteractiveShell.run_code(***failed resolving arguments***)
   3393 try:
-> 3394     if async_:
   3395         await eval(code_obj, self.user_global_ns, self.user_ns)

Input In [207], in <cell line: 10>()
      8     return x
---> 10 jax.linear_transpose(foo, jnp.zeros(10))(jnp.ones(10))

Input In [207], in foo(***failed resolving arguments***)
      1 def foo(p):
----> 2     return jax.lax.scan(lambda x, _: (x + p, None), jnp.zeros_like(p), None, length=10)[0]

JaxStackTraceBeforeTransformation: AssertionError

The preceding stack trace is the source of the JAX operation that, once transformed by JAX, triggered the following exception.

--------------------

The above exception was the direct cause of the following exception:

AssertionError                            Traceback (most recent call last)
Input In [207], in <cell line: 10>()
      7         x += p
      8     return x
---> 10 jax.linear_transpose(foo, jnp.zeros(10))(jnp.ones(10))

    [... skipping hidden 3 frame]

File ~/.virtualenvs/science/lib/python3.10/site-packages/jax/_src/lax/control_flow/loops.py:663, in _scan_transpose(reduce_axes, cts, reverse, length, num_consts, num_carry, jaxpr, linear, unroll, *args)
    661 ires, _ = split_list(consts, [num_ires])
    662 _, eres = split_list(xs, [sum(xs_lin)])
--> 663 assert not any(ad.is_undefined_primal(r) for r in ires)
    664 assert not any(ad.is_undefined_primal(r) for r in eres)
    666 carry_avals, y_avals = split_list(jaxpr.out_avals, [num_carry])

AssertionError:

What jax/jaxlib version are you using?
v0.3.15
Which accelerator(s) are you using?
CPU
Additional System Info
OSX ARM

Duplicate of #6619, sorry for the noise.


Can not add any service after updating from beta 14 (Windows 10)

Expected Behavior
If I click on aservice like "Slack" "Office365" or any other service from the "Available services" window, the service should be added.
Current Behavior
After clicking on a service, it shows a loading indication for a spolit second and nothing happens
Steps to Reproduce (for bugs)

add a service

Your Environment

Franz Version used: updated from version 5.00 beta 14 to current beta 16
Operating System and version: Windows 10

short update: reinstalled previous beta 14 from https://github.com/meetfranz/franz/releases/tag/v5.0.0-beta.14 and all services are still up and running with the old version.

Can confirm; just had this bug happen to me as well.
Franz updated to 5.0.0-beta 16, claimed could not connect to Franz services despite internet working fine.
Installed 5.0.0-beta 14 again from github releases and it worked as if nothing was wrong, as it should.


Despite errors, jpm test prints All tests passed. and has error code 0

Using either:

Windows 11, commit ce14c833e6ea69f1515c59a1f3898dba419f0f4d, using Native Tools Command Prompt for VS 2019
Github CI windows-latest

jpm test seems to always return 0.
Example:
git clone https://github.com/saikyun/jpm-wrong-error-code
cd jpm-wrong-error-code
jpm test
running test/error.janet ...
error: wat
  in _thunk [test/error.janet] (tailcall) on line 1, column 1
running test/exit.janet ...
All tests passed.

The tests are running (error "wat") and (os/exit 1).

I was able to reproduce this in a Windows environment using jpm at the latest commit and janet at the latest commit.
On a side note, behavior was as expected under a Linux environment -- i.e.
$ jpm test
running test/error.janet ...
error: wat
  in _thunk [test/error.janet] (tailcall) on line 1, column 1
non-zero exit code in test/error.janet: 1
running test/exit.janet ...
non-zero exit code in test/exit.janet: 1
Failing test scripts: 2

Looks like this was an error in Janet, has been fixed on master: https://github.com/janet-lang/janet/commit/427f7c362e19117c6ac91b9fe2419019c0adbeb3
We were using the wrong member of a structure to get the return value of the process.

I still get similar errors.  May be I didn't update appropriately.
Perhaps @saikyun wouldn't mind trying?

I can confirm the update works - tested with latest master and spork with a fake bug introduced.

Confirmed it's working here.  I think I misinterpreted the output before.  Sorry about that.


Item.getIsFromMe() always returns false

I have been using the Item.getIsFromMe() method to check if a given email was sent from a user to himself.
Using Exchange Server 2010 SP2 the property always returns false.
Here is a simple repro:
(Obviously I cleared the Inbox before sending an email from the user to himself)
ExchangeService service = new ExchangeService(ExchangeVersion.Exchange2010_SP2);
ExchangeCredentials credentials = new WebCredentials("emailAddress", "password");
service.setCredentials(credentials);

PropertySet mailPropertySet = new PropertySet(ItemSchema.IsFromMe, EmailMessageSchema.Attachments, EmailMessageSchema.Body, EmailMessageSchema.CcRecipients, EmailMessageSchema.ConversationId, EmailMessageSchema.DateTimeCreated, EmailMessageSchema.HasAttachments, EmailMessageSchema.Importance, EmailMessageSchema.IsRead, EmailMessageSchema.ParentFolderId, EmailMessageSchema.Sender, EmailMessageSchema.Subject, EmailMessageSchema.ToRecipients, EmailMessageSchema.UniqueBody);

EmailMessage message = EmailMessage.bind(service, new ItemId(uniqueItemId), mailPropertySet);
message.getIsFromMe()

System.out.println(current.getIsFromMe());
// writes false

I think the code you provided does not declare you are referring to an EmailMessage created by your own account. You are currently binding to a message that also could be created by someone else. Plz provide a more suitable example.

closed due to inactivity


support different payout address for each delegator

Many delegators of locked accounts will want their pool awards paid to a different account, which may also be delegated, but could earn supercharged coinbase.
We need to determine a secure way to establish where funds should be paid out (suggest requiring a signed message from the delegator specifying the new payout address, although that may increase the difficulty for delegators not running any node and with only cold wallets.) Perhaps it would be preferable to the node operator to independently determine the authenticity of a request, and then update their configuration accordingly.
Depending on the solution above, implement a method of redirecting the payout from delegator A to payout address B.

Now supported via configuration in src/data/.substitutePayTo file - see readme for more information.
The current implementation does not address "secure way to establish" ... but provides the payout capability.


Catch up PR to get up to date with parent

Ungh trying to resolve with upstream is a nightmare. Abandon ship!


⚠ Bofrost.fr has degraded performance

In 76953b5, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 957 ms

Resolved: Bofrost.fr performance has improved in c3b20f6 after 6 minutes.


Sample portals down

Describe the bug
Neither http://stag.mixcore.org/ nor https://demo.mixcore.org/portal are responding.
To Reproduce
Navigate to either/both of the links above
Expected behavior
I should be able to demo the site so I know if I want to download / create a POC with mixcore

@wesfincher  please access https://dev.mixcore.org/ for v1 demo. And v2 demo here: https://v2.dev.mixcore.org/
Or https://mochahost.demo.mixcore.org/portal (administrator / P@ssw0rd)
Best regards.


Downloaded Shapefile does not import to Carto

The GeoJSON imports correctly, but the SHP throws an error.
After deleting the .prj that is added to the zip by mapshaper, it imports correctly into carto

Fixed by removing .prj altogether, should be tested again once .prj is added again.  .prj issue: https://github.com/NYCPlanning/travelsheds/issues/11


Reintroducing multiQR functionality

In this PR, I have solved the problems occurred from #1699

Dependence moment.js was replaced by day.js to solve issues using Safari.
Code refactored (+100 lines optimized).
Now generate a PDF, not pages like images.
The PDF generated can be seen at the site like a slider.
Working in all browsers.

@dsarkar
When I execute npm install on this branch it makes a change to package-lock.json.

so it seems that the package-lock.json in this branch is not quite in sync with the package.json from the branch.

@MikeMcC399 Yes, it changes package-lock.json, since there are new dependencies.

@dsarkar
I understand that there are new packages defined in package.json
"dayjs": "^1.10.7",
"jspdf": "^2.4.0",
"papaparse": "^5.3.1",

which lead to changes in package-lock.json. My comment was just about a minor difference, not about most of the changes.
Can I suggest the following?
Execute this in cuisines/cwa-website:
git switch master
npm ci

which deletes and re-installs node_modules exactly according to the master branch version of package-lock.json
then
git switch brifemu-eventregistration-refactor
npm install
git diff

and I think you will see a small difference in package-lock.json which should be committed.
When I carried out these steps I got:
$ git diff
diff --git a/package-lock.json b/package-lock.json
index 062a3829..a1b7488d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -13488,7 +13488,8 @@
       "dependencies": {
         "ansi-regex": {
           "version": "5.0.0",
-          "resolved": ""
+          "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-5.0.0.tgz",
+          "integrity": "sha512-bY6fj56OUQ0hU1KjFNDQuJFezqKdrAyFdIevADiqrWHwSlbmBNMHp5ak2f40Pm8JTFyM2mqxkG6ngkHO11f/lg=="
         },
         "ansi-styles": {
           "version": "4.3.0",

@dsarkar
One other minor comment,
if you add papaparse from the command line
npm install<EMAIL_ADDRESS>--save
npm will add it to package.json in alphabetical order in the dependencies:
All the other dependencies are in alphabetical order in  package.json which is helpful for maintenance. It does not affect the functionality however.

@MikeMcC399 thanks for your input! I did execute your suggested changes.

@svengabr

I did execute your suggested changes.

Perfect 👍🏻
That resolves the issues I pointed out. Thank you!

Is there any ETA when this PR will land?
I'm asking especially as there might be a growing demand for this functionality as the constraint to deploy the luca-app may drop in several federal countries...

@benbender We will have a final look at this, then we should merge it.


Simplified CMake mode for including as a submodule

We are currently using protobuf, without gRPC, as a submodule. This works well and we tend to switch off various targets in the cmake project add with add_subdirectory(protobuf EXCLUDE_FROM_ALL).
We want to use gRPC. However, the build system is much more complicated. It looks like some requirements (such as Go) could be avoided with an ENABLE_TESTING=Off switch. As far as I can tell Go is only used for boringssl tests (which we would not want to build when using a submodule).
With the current set up we will probably build dynamic libraries, and distribute them, as adding ~10 submodules and a requirement on Go is probably too much overhead.
What version of gRPC and what language are you using?
C++ with grpc 1.10.0 on macOS 10.10 to 10.13, Win10 and Linux too.

There's some progress in https://github.com/grpc/grpc/pull/14864 (demonstrates that adding grpc via add_subdirectory is easy, but there's still a problem with additional dependencies being required - but the comments in the example also partially explain what can be done about it).


Adding changes in #335 by @kayslay to handle transaction panic

Original comment was:

Handle panic that comes from the fn func(tx *Connection) parameter.
Whenever a panic occurs in a Connection.Transaction the TX.Rollback or TX.Commit is not called after the panic has been recovered. Any call to the Connection.Transaction would block forever.

Thanks @kayslay
cc @stanislas-m @kayslay

Shouldn't we rather look into what's causing the panic?

Ah! Fair point. Honestly I'm not sure how the underlying layers of transaction work in Pop and just wanted to bring this PR up in case it still relevant. Will take a look.

It's also possible that the user is running into panics in her/his code and the panic just bubbles up. In that case however I don't think that pop should be the one recovering it but rather the user's middleware for example. Did the original issue include a stack trace for the panic?

It did not, lets just close this one and maybe take a look when we have a concrete case. So far I don't have a way to reproduce it. Thanks @aeneasr

I found this closed PR during branch cleanup. The same issue was addressed with two PRs below, and there are also related fixes on Buffalo core side too. (leaving this comment just for a note with references)

https://github.com/gobuffalo/pop/pull/775
https://github.com/gobuffalo/pop/pull/797


Local dev environment breaks with absolute path

Using the instructions on https://github.com/ibm-cds-labs/pipes/wiki/Instructions-for-setting-up-a-local-dev-environment-for-Simple-Data-Pipe -- if you provide the environment variables (NODE_CONFIG, HOME) with absolute paths to the files, the system breaks.
I watched David debug this. He fixed this by adding getAppRootDir(); to this block in his configManager.js:
//Load the nconfig
		var configPath = null;
		if ( path.isAbsolute( process.env.NODE_CONFIG ) ){
			getAppRootDir();
			configPath = process.env.NODE_CONFIG;

Sorry I'm a weirdo who used absolute paths to my vcap.json and pipes.json. Thanks! --Broberg

Fixed on bluemix-helper-config module. You'll need to delete the node_modules/bluemix-helper-config dir and do another npm install

Fixed! Thanks :dancer:


add nav block at the end of blog pages

Describe the problem
When reaching the end of long pages it would cool to have a nav block instead of having to scroll back up.
Describe the proposed solution
Add nav block section at the end of the end of the following layouts:

blogPostList
blogPost
CategoriesList

Nav block links:

home
blog index
scroll to top

Alternatives considered
We could alternatively just add a scroll to top button and call it a day.
Importance
nice to have

Hi, I would like to solve this issue, could you assign me to it?


Replace .env file in figma-to-react with .env.example for security reasons

The .env file should not be tracked in the git repo under the figma-to-react folder. When the user adds their own key values the changes will be committed to the history. Instead you can include a .env.example file as a template or remove the file and outline how to create it in the readme file.

Hi Matt, thanks for looking out for concerns like this. You’re absolutely right that in most circumstances it goes against best practices to commit secrets to a repository. In this case we’ve included the .env file here with a placeholder value deliberately for clarity and ease of reference since this is only a demo/example repo. We don’t expect others to be running this code in production or making commits back to this repository.


v2021.12.0 Breaks Kuna Camera Streaming

After upgrading to core-2021.12.0, my Kuna cameras would no longer stream.  I tried deleting and re-adding the integration, but I'm still getting the same error in the logs:
Logger: homeassistant.components.camera
Source: custom_components/kuna/camera.py:100
Integration: Camera (documentation, issues)
First occurred: 9:50:49 PM (2 occurrences)
Last logged: 9:50:49 PM
kuna: Error on device update!
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 431, in _async_add_entity
await entity.async_device_update(warning=False)
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 684, in async_device_update
await task
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/kuna/camera.py", line 100, in update
self.is_streaming = True
AttributeError: can't set attribute

Ha.  Thought it was just me.   Looking forward to a fix, let me know if I can provide any logs etc.

From Github
boctok https://github.com/boctok commented 15 hours ago https://github.com/marthoc/kuna/issues/37#issuecomment-991982953
I was able to fix the error and get the cameras back by changing line 100 in camera.py from
self.is_streaming = True to
self._is_streaming = True

On Dec 13, 2021, at 6:24 AM, D @.***> wrote:
Ha. Thought it was just me. Looking forward to a fix, let me know if I can provide any logs etc.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/marthoc/kuna/issues/38#issuecomment-992473005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOJDTN7YJ3UYZ4OCKO2NPTUQXXXJANCNFSM5J5DHX4A.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@mcfarlde Good call.  That worked for me as well.

Thanks @mcfarlde for the suggestion - it worked for me as well. I created this trivial PR to keep things up to date: https://github.com/marthoc/kuna/pull/41

I don't get any camera entities (only switches and motion) when installing the addon. Any ideas? HA 2021.12.10

after making the change, I am seeing this error. Any ideas?
File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 179, in _async_get_image if image_bytes := await camera.async_camera_image( TypeError: async_camera_image() got an unexpected keyword argument 'width'

I'm getting the same:
File "/usr/src/homeassistant/homeassistant/components/camera/init.py", line 169, in _async_get_image
if image_bytes := await camera.async_camera_image(
TypeError: KunaCamera.async_camera_image() got an unexpected keyword argument 'width'

I updated HACS, rebooted and now the camera is back!

I only get that error when using Safari.  The camera works in chrome, the Mac App and the mobile app.


Remove the phase banner

Elements definitely isn’t in alpha any more (2.1.0 currently), and the page that the survey link points at was last updated 3 years ago. Let’s just drop it.
Fixes the symptom (but not the underlying problem) of https://github.com/alphagov/govuk_elements/issues/343

It'a probably worth deleting the phase banner survey include as part of this PR too. It was added (as a duplicate of the original phase banner include) to get feedback for the govuk frontend alpha.

https://github.com/alphagov/govuk_elements/blob/master/app/views/includes/phase_banner_survey.html

This seems sensible, I've removed the survey phase banner include too.
Thanks @robinwhittleton 💯


Use proper exception types

SonarQube analysis reported 2 issues

 2 major

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.


Latest Images pane is squished up on mobile

It causes the entire right pane to overflow its parent div which makes you have to scroll to the right to see the active threads and latest posts, especially in portrait mode.

https://user-images.githubusercontent.com/3119646/263434117-3c97dc6e-ffef-423f-877d-ca3516a6e4e2.mp4
Please refer to https://github.com/Transfusion/LynxChan/commit/e47ee4af5d943e1eb55391d481c64c337999d991 for the backend changes needed. src/be/data/defaultPages.json and src/be/engine/domManipulator/static.js need to be replaced.


[PE-D][Tester E] [Pilot mode: Delete command] No feedback given for delete 0

delete 0 should prompt feedback for delete successfully but no feedback was prompted instead. (Indexing seems to start from 1, so 0 should be invalid instead (an example in UG specified 0 as a valid index) - I tried delete 1 and it seems like it will delete the first object, which makes 0 invalid index. if 0 is invalid index then there is also no feedback given for user :( maybe you could add some feedback to prompt to the user that 0 is invalid indexing
(Deletion was unable, but nothing was shown at Result Display)
Attached is the bug and an example in UG saying that 0 is valid indexing.

Labels: severity.Medium type.FeatureFlaw
original: dohaduong/ped#2

Have transit to one-based indexing completely.
Need to update UG.


Request parameters in mocks

I would like to have the possibility that the mock functions can receive the request parameters, in order to generate data based on them.
An example would be: GET /api/pets?page=1&pagesize=10
It would take the pageSize to generate an array of 10 elements.

Is it possible to do this? Or I'm wrong
Thanks!

Hey @BartoGabriel, should be possible if you want you can check to add it to the codebase. Otherwise I will check when I have a bit of time to add it

Hi @anymaniax,
Thank you for all your work on orval!
I would really like to see this one done, so I'm considering to submit a PR. I plan to take a minimal approach of just passing URL params and request body to all mock functions (and the nested data and properties handlers).

I'm sure it's also possible to add some configuration options to streamline this use case, but I think we should probably keep it out of the scope until the basic functionality is merged.

Some inspirational use cases:

Endpoint that creates an entity could return a response with correctly set relational fields, so application code could actually work with all the data coming from the mocks. (E.g. creating a comment under a post would actually return an instance with the relevant postId, which would enable any flows after that to work as expected).
Conditional fields (optional values or enums that have to be determined based on the request data)
Page size and other meta parameters could be set correctly (@BartoGabriel's reason for opening this issue)

I'd really appreciate if you could answer a few questions before I work on this.

Do you agree to accept this change in principle?
Would it be possible to release this enhancement with a minor version bump without waiting for v7 release?
What are the current workarounds that allow setting properties based on the request object, if there are any? I tried to make it work at the level of msw setup (right before calling setupWorker), but without much success.

Hope we can get this done, as it would make mocking a lot more practical and realistic.


nativeSetOption can return an OSError but specifies bool

https://github.com/dart-lang/sdk/blob/a9abc6461395e3327c7d3c22095ea3bf3de3d075/runtime/bin/socket_patch.dart#L1148-L1149
Some of the other native methods omit a return type and get an implicit dynamic for this reason - the return value is checked to see if it's an OSError before trying to use it.
The caller here even tries that:
https://github.com/dart-lang/sdk/blob/a9abc6461395e3327c7d3c22095ea3bf3de3d075/runtime/bin/socket_patch.dart#L1082-L1083
However we get a type error before we can because the signature only allows bool.
See https://github.com/dart-lang/http/issues/214

This should be fixed with https://dart-review.googlesource.com/c/sdk/+/137140


Package request: Errands

Project description
A task manager for Gnome
Metadata

homepage URL: https://github.com/mrvladus/Errands
source URL: https://github.com/mrvladus/Errands
license: mit
platforms: linux

Add a :+1: reaction to issues you find important.

Looking at the README, the author seems to be against packaging it outside of FlatHub. Would it make sense to first open an issue there to see if they would consent to being added to nixpkgs ?

Ah that's a fair point I hadn't spotted that, I'll ask

Per the authors wishes, closing this PR


WIP : Data augmentation for C-API Activity Classifier

Let's mark this WIP for now?

Closing this pull request since the augmentation is not showing significant improvements on known datasets.


Add an Ergonomics Override for version()

When setting the version it would be nice not to have to wrap the
string in Some(..). This moves to use the Into type to accept
plain version strings in addition to None and Some(..).
This means you can now set the version like this:
d.version(format!("v{}.{}", major, minor))

The version string doesn't need to be wrapped in a Some any
more. I think the types accepted by this should be a superset of
what the old method accepted. Not sure if this might cause type
inference to fail in some places that it didn't previously though.

I appreciate the intent here, but I think I'm going to pass. In general, I prefer the addition of generics like this (which complicate the type signature) to carry their weight, but I don't think this does. I don't think this is a function that is called a lot, so adding the extra Some(...) here feels fine to me.

I agree in retrospect.


Pass cosmos-sdk client.Context to engine

This struct provides access the required contextual data for the engine to sign deposit transactions.
Checkpointing this small PR in case there's a good reason

not to pass it
to pass via a restricted interface

Summary by CodeRabbit

New Features

Enhanced the EngineAPI to manage application-specific chain interactions through the addition of a new client context.
Improved the Node structure to leverage client context for better integration with Cosmos SDK client functionalities.
Expanded transaction handling capabilities in the adapters to support comprehensive transaction signing and structuring.

Bug Fixes

Modified the initialization process of the node in tests for improved flexibility in handling parameters.

Refactor

Updated multiple function signatures to incorporate new client context parameters for better handling of client-specific information in various components.

@NiloCK mind marking this as a draft and/or removing the reviewers? I get pinged on every push now; not sure if there's a way to disable temporarily before reviews are needed again.

@NiloCK mind marking this as a draft and/or removing the reviewers? I get pinged on every push now; not sure if there's a way to disable temporarily before reviews are needed again.

Agh, sorry about that.

Closing. Superceded by #123.


change newLine() method signature to be compatible with Laravel 8.10

fixes #11

Sorry I missed this! The next release already has this addressed.


Add note about AUTHORS file in contribution guidelines

As we're still fixing some issues with the github action related to the authors file, can add a note about including your name/email in the AUTHORS file when making a PR in the contribution guidelines

@Kiyoshika are you ok to pick this up?

The authors check is fixed, so this is not needed anymore


metrics: refactor metrics to deal only with events

This patch refactors the metrics package to make integration with
aggregation and event based metrics libraries simpler. It drops the
Counter and Timer shim objects and exposes only functions for triggering
metric events.
Namespacing is supported but only for go-metrics based libraries.
The api no longer exposes the current rate and 99% percentile.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please see https://github.com/fabiolb/fabio/issues/211#issuecomment-375880738


Naive question about multiple seeds

Hi,
I am familiar with MARL in Pytorch, but very new to JAX, so please forgive me if this question is naive.
I see that many of your baselines are parallelized over multiple seeds at once (e.g. here in QMIX or here in transfQMIX). However, when running the baselines I notice that the resulting WandB runs seem to aggregate the seeds together. Is there some way to separate the performance of each seed for plotting purposes (e.g. to report the min/avg/max)? Your paper has several average return curves with some sort of error shading, so I imagine I must be missing something obvious.

Hey! So
Thanks for reaching out and exciting that you are trying out JAX. Off the top of my head, I think for wandb the easiest way is to run one seed per script and then sweep over each seed with wandb sweeps (and if you set XLA_PYTHON_CLIENT_PREALLOCATE=false as an environment variable you can then run multiple scripts on one GPU but this is quite a bit less efficient then multiple seeds over one device). Have I have missed something @mttga ?

Hi, thanks for the reply!
Okay, so you're saying the answer is simply not to parallelize across seeds, then use WandB's tools to aggregate separate 1-seed runs together. If I'm understanding that correctly, then what is being plotted when I run multiple seeds in parallel? The average across those seeds?

The parallel runs will plot in the same space, meaning that you will have datapoints from all your runs but you will not be able to distinguish them. To distinguish them you can use an approach like this:
def function(rng):

  original_seed = rng[0]

  # random stuff

  metrics = # a dictionary of your logging metrics

  def callback(metrics, original_seed):
        metrics.update({
            f'rng{int(original_seed)}/{k}':v
            for k, v in metrics.items()
        })
        wandb.log(metrics)

    jax.debug.callback(callback, metrics, original_seed)

we will include training code like this soon


Exception when returning from parent page

If the control is placed in a secondary page, when you return to the main page an exception is thrown.
Step to reproduce:
Create a page with your control.
register it in di (optional)
builder.Services.AddSingleton();
From main page:
await Shell.Current.GoToAsync($"{nameof(YourPage}");
From your page
await Shell.Current.GoToAsync($"..");
Exception:
System.ObjectDisposedException: 'Cannot access a disposed object.
Object name: 'AndroidX.Camera.View.PreviewView'.'

Try to add it in DI as transient and/or override OnDisappearing and set CameraEnabled to false to close the camre before you move out of the page.

This should be fixed by the PR my colleague got merged (thanks for the quick turnaround @afriscic), so try the latest nuget @be-swarm

Same problem here.
From main page to secondary page: await Navigation.PushAsync(new PageScanNT());
Using the back button of the page to return, than I get also that error: Cannot access a disposed object.
I did set CameraEnabled to false in the OnDisappering event but still that error.
BarcodeScanning.Native.Maui version 1.0.2
Visual Studio 2022 version 17.8.1

OK, I have finally managed to consistently replicate this error from your scenario and found the culprit.
Should be fixed in 1.0.3 and I'll mark this issue as resolved.

I'm having this issue in 1.3.1:
Java.Interop.JniPeerMembers.AssertSelf (/home/user/workspace/app/.meteor/sources/xamarin/java.interop/bec0326a925ff888d96cb433f5049000a6d32a33/src/Java.Interop/Java.Interop/JniPeerMembers.cs:153)
Java.Interop.JniPeerMembers.JniInstanceMethods.InvokeVirtualObjectMethod (/home/user/workspace/app/.meteor/sources/xamarin/java.interop/bec0326a925ff888d96cb433f5049000a6d32a33/src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.cs:858)
AndroidX.Camera.View.CameraController.EnableTorch (AndroidX.Camera.View.CameraController.cs:1654)
BarcodeScanning.CameraViewHandler.Stop (:-1)
Java.Lang.Thread.RunnableImplementor.Run (/home/user/workspace/app/.meteor/sources/xamarin/xamarin-android/f68622cf6b97fa23cc3d3105a52ef5b2e31d52a1/src/Mono.Android/Java.Lang/Thread.cs:36)
Java.Lang.IRunnableInvoker.n_Run (/home/user/workspace/app/.meteor/sources/xamarin/xamarin-android/f68622cf6b97fa23cc3d3105a52ef5b2e31d52a1/src/Mono.Android/obj/Release/net8.0/android-34/mcw/Java.Lang.IRunnable.cs:84)
Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V (/home/user/workspace/app/.meteor/sources/xamarin/xamarin-android/f68622cf6b97fa23cc3d3105a52ef5b2e31d52a1/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:26)


remove ensureMFS call when generating share link

This removes the call to ensureMFS in doFilesShareLink to fix and close https://github.com/ipfs/ipfs-webui/issues/1744
I wasn't able to run the e2e tests on my machine, so we'll see if anything complains in CI, I guess :)
cc @lidel

I can get the e2e tests to pass locally against go-ipfs, but I get the same error as in CI for js-ipfs.

e2e tests with E2E_IPFSD_TYPE=go
env PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true PUPPETEER_EXECUTABLE_PATH=/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome E2E_IPFSD_TYPE=go npm run test:e2e

<EMAIL_ADDRESS>test:e2e
cross-env JEST_PUPPETEER_CONFIG=test/e2e/jest-puppeteer.config.js jest --verbose -c test/e2e/jest.config.js --runInBand

Determining test suites to run...
E2E using go-ipfs/0.8.0/ (/Users/yusef/work/repos/ipfs-webui/node_modules/go-ipfs/go-ipfs/ipfs) with Peer ID 12D3KooWPUDbhzrsfWeS1FkAHwBVLef6tQzckcfgAimdCGHGJLKy
(node:71386) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
(Use node --trace-deprecation ... to show where the warning was created)
(node:71367) V8: /Users/yusef/work/repos/ipfs-webui/node_modules/borc/src/decoder.asm.js:3 Linking failure in asm.js: Unexpected stdlib member
(Use node --trace-warnings ... to show where the warning was created)
PASS  test/e2e/peers.test.js (17.716 s)
Peers screen
✓ should have a clickable "Add connection" button (1184 ms)
✓ should confirm connection after "Add connection"  (2498 ms)
✓ should have a peer from a "Local Network" (5112 ms)
PASS  test/e2e/files.test.js (9.095 s)
Files screen
✓ should have the active Add menu (1596 ms)
✓ should allow for a successful import of two files (1796 ms)
PASS  test/e2e/navigation.test.js (8.769 s)
Navigation menu
✓ should work for Status page (882 ms)
✓ should work for Files page (554 ms)
✓ should work for Explore page (1148 ms)
✓ should work for Peers page (337 ms)
✓ should work for Settings page (804 ms)
PASS  test/e2e/settings.test.js (6.172 s)
Settings screen
✓ should show config of IPFS node (109 ms)
PASS  test/e2e/explore.test.js (6.617 s)
Explore screen
✓ should have Project Apollo Archive as one of examples (112 ms)
✓ should open arbitrary CID (1385 ms)
PASS  test/e2e/status.test.js (6.474 s)
Status page
✓ should have Status menu item (102 ms)
✓ should inform it is sucessfully connected to IPFS (25 ms)
✓ should display Peer ID of real IPFS node (30 ms)
(node:71367) V8: /Users/yusef/work/repos/ipfs-webui/node_modules/borc/src/decoder.asm.js:3 Linking failure in asm.js: Unexpected stdlib member
PASS  test/e2e/remote-api.test.js (22.805 s)
API @ multiaddr
✓ should be possible to set via Settings page (4833 ms)
✓ should show full multiaddr on Status page (1530 ms)
✓ should show full multiaddr on Settings page (519 ms)
API @ URL
✓ should be possible to set via Settings page (884 ms)
✓ should show full multiaddr on Status page (624 ms)
✓ should show full multiaddr on Settings page (268 ms)
API with CORS and Basic Auth
✓ should work when localStorage[ipfsApi] is set to URL with inlined Basic Auth credentials (890 ms)
✓ should work when localStorage[ipfsApi] is set to a JSON string with a custom ipfs-http-client config (766 ms)
✓ should work when URL with inlined credentials are entered at the Settings page (1818 ms)
✓ should work when JSON with ipfs-http-client config is entered at the Settings page (2715 ms)
Test Suites: 7 passed, 7 total
Tests:       26 passed, 26 total
Snapshots:   0 total
Time:        77.796 s, estimated 113 s
Ran all test suites.

It looks like the e2e tests are failing against js-ipfs generally at the moment (#1737).


Remove hard dependency on WebMVC from Logging

The logging starter can now also be used without Web MVC.
In this case the Web MVC interceptor for trace id extraction will not
automatically kick in.
Fixes #713.

Outside of Spring MVC, how do we expect this module to be used?
After all, TraceIdLoggingWebMvcInterceptor is Spring MVC-specific and the TraceIdExtractors are pretty trivial and not Spring-specific at all.

This module would be used to get the Logback appender configs.
It's still useful even without the interceptor because MDC context is supported.

The most obvious aspect to me is that we're completely getting rid of what little Spring there is in this module. :)
For the MDC to be used, there has to be something that writes to it. That's not clear from the documentation.
If users want someone else's appenders, shouldn't they be importing them on their own? Or are we assuming an auto-configuration role a-la-Spring Boot, where we're automating configuration for users? :)

Sleuth handles writing to the MDC and we will have our specialized trace ID extractor after you PR in openzipkin is merged.


Add darwin x86_64

This builds fine and allowed me to install riot without issue.
This bypasses the bug in config.ml which isn't allowing the following:
[@@config all (target_os = "macos")]

Thanks @metame for opening this PR! ✨


Use calico as the default CNI for unmanaged clusters

What this PR does / why we need it
Currently, on restart, managed/unmanaged clusters on docker
with antrea CNI do not reconnect. This means a user would have
to rebuild their cluster if they docker stop <cluster>
or suffer a system reboot. This patch sets calico as the
default CNI for unmanaged clusters
Related: https://github.com/vmware-tanzu/community-edition/issues/3058
Details for the Release Notes (PLEASE PROVIDE)
Calico is the default CNI for unmanaged clusters

Which issue(s) this PR fixes
Fixes: https://github.com/vmware-tanzu/community-edition/issues/3239
Describe testing done for PR
Build binaries and configure works as expected
$ ./build configure test
Wrote configuration file to: test.yaml
$ cat test.yaml
ClusterName: test
KubeconfigPath: ""
ExistingClusterKubeconfig: ""
NodeImage: ""
Provider: kind
ProviderConfiguration: {}
Cni: calico
CniConfiguration: {}
PodCidr: <IP_ADDRESS>/16
ServiceCidr: <IP_ADDRESS>/16
TkrLocation: projects.registry.vmware.com/tce/tkr:v1.21.5
PortsToForward: []
SkipPreflight: false
ControlPlaneNodeCount: "1"
WorkerNodeCount: "0"

Started a new default cluster (that gets calico CNI):
$ k get pods -A
NAMESPACE            NAME                                         READY   STATUS    RESTARTS   AGE
kube-system          calico-kube-controllers-c46d6db79-wjqqc      1/1     Running   0          20s
kube-system          calico-node-ttb46                            1/1     Running   0          20s
kube-system          coredns-558bd4d5db-q6p57                     1/1     Running   0          76s
kube-system          coredns-558bd4d5db-zbmkf                     1/1     Running   0          76s
kube-system          etcd-meow-control-plane                      1/1     Running   0          79s
kube-system          kube-apiserver-meow-control-plane            1/1     Running   0          79s
kube-system          kube-controller-manager-meow-control-plane   1/1     Running   0          79s
kube-system          kube-proxy-7g9xg                             1/1     Running   0          77s
kube-system          kube-scheduler-meow-control-plane            1/1     Running   0          79s
local-path-storage   local-path-provisioner-547f784dff-x594n      1/1     Running   0          76s
tkg-system           kapp-controller-555f8b88d5-9zbjg             1/1     Running   0          76s

and on systemctl restart docker, the pods come back up and am able to run k get pods -A successfully again

@jpmcb see my comment here: https://github.com/vmware-tanzu/community-edition/issues/3239#issuecomment-1059380151
This gets a soft-approve from me. If you feel it's otherwise ready, let's mark it as ready for review and get approvals, and merge.
Thanks!

Sounds good! Ready to review!! ⛷

One more final validation:
🌐 Installing CNI
   calico.tanzu.vmware.com:3.11.3+vmware.1-tkg.1

Looks good!


fix: incorrect update annotation of svc

Description:

Testing done:

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

Codecov Report
Attention: 311 lines in your changes are missing coverage. Please review.

Comparison is base (1eeee08) 47.58% compared to head (69ff23e) 46.81%.
Report is 2 commits behind head on release/v1.2.

Files
Patch %
Lines

cmd/cli/connector_enable.go
6.71%
235 Missing and 1 partial :warning:

cmd/cli/connector_disable.go
30.00%
34 Missing and 1 partial :warning:

cmd/cli/util.go
0.00%
11 Missing :warning:

cmd/cli/egressgateway_enable.go
0.00%
9 Missing :warning:

pkg/sidecar/providers/pipy/registry/services.go
0.00%
7 Missing :warning:

pkg/providers/kube/client.go
69.23%
4 Missing :warning:

cmd/cli/flb_enable.go
0.00%
3 Missing :warning:

cmd/cli/ingress_enable.go
0.00%
3 Missing :warning:

pkg/k8s/client.go
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2     #173      +/-   ##
================================================
- Coverage         47.58%   46.81%   -0.77%
================================================
  Files               196      199       +3
  Lines             14884    15229     +345
================================================
+ Hits               7083     7130      +47
- Misses             7757     8053     +296
- Partials             44       46       +2

Flag
Coverage Δ

unittests
46.81% <14.79%> (-0.77%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.