When I use insertAtomicBlock, I got an error: Unknown DraftEntity key: null

When I encountered this error, I compared the media code in the example.

this.setState({
// The third parameter here is a space string, not an empty string
// If you set an empty string, you will get an error: Unknown DraftEntity key: null
editorState: AtomicBlockUtils.insertAtomicBlock(
newEditorState,
entityKey,
'  '
),
showURLInput: false,
urlValue: '',
}, () => {
setTimeout(() => this.focus(), 0);
});
https://github.com/love-fay/draft-js/commit/a4c877846bd206af6f75d2ea6fe2ec5c064c57fd?diff=unified
I'm just adding two lines of comments, because I made this hard to see difference mistake, and I'm worried that others are the same as me

I have same issue, how do you solve? @love-fay

@pohsiu I annotated AtomicBlockUtils.insertAtomicBlock. I thought the third parameter was an empty string, but it was actually a space string


Image Carousel

Add image carousel. Mainly, I'm thinking about the home page images.

Got the carousel itself working very nicely. The only extra styling I had to do was narrow the -prev/-next controls so they didn't take up so much space.
If I felt like hard-coding the info for each book, I could finish this right now.  However...
Instead of hard-coding all the items, I want to use a query to pull data from the files. I can add a series and order to the book data, then auto-generate the carousel items from the data.  There'll be no need to update the index page when the fourth book comes out.

Populates from data now, and is working very smoothly.


Version number should show in build info

Currently, just the build date. Can we also get the version number, like v1.0.1?

Fixed


small css patch

with a localization file (for me lang fr-FR), the menu disappears, this patch fixes the bug ,
thank you

Thanks for the PR! I'll be focusing on localization soon, so keep in touch and feel free to contact me on Discord if you need anything.


when will the weights be updated for the sparse tensor in the optimizer

I notice there are both SparseApplyAdadeltaOp and ApplyAdadeltaOp in the /tensorflow/core/kernels/training_ops.cc.
Apparently, when the weights for the dense feature is optimized using Adadelta, the class of ApplyAdadeltaOp will be called, while when the weights for the categorical feature is optimized, SparseApplyAdadeltaOp will be called.
My question is when the SparseApplyAdadeltaOp  is called, for which part of the weights will be updated seems to not be in the code annotation, on earth the wights that are not zero will be updated or the weights whose gradients that are not zero will be updated?

@ymodak hi, is there any answer for this problem :)

@oanush hi, but who should I turn to help for this problem?

@gadagashwini sos

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.


enables input txt file for initialization

added info in the usage of the function on how to do it within bash


Yourdfpy loader and continuous integration

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.834%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
602

Relevant Lines:
603

💛  - Coveralls


Ipn issue

I've integrated the API with codeigniter framework
Everything is going good but the second call for callback url is not firing
I have to reload the page after the payment confirmed to get response from gourl (to check it as confirmed on db)
I use Ajax so it should fired automatically ?

Maybe

When payment confirmed, GoUrl server send data through IPN url (https://gourl.io/images/paymentbox6.png)
https://gourl.io/api-php.html#ipn

I've integrated the API with codeigniter framework Everything is going good but the second call for callback url is not firing I have to reload the page after the payment confirmed to get response from gourl (to check it as confirmed on db) I use Ajax so it should fired automatically ?

Please, how did you integrate it?


Cannot create account

I'm running litd version 0.3, when I try to create an account I get this error
$ pool --rpcserver localhost:3004 accounts new --amt 1200000 --expiry_blocks 8064 --conf_target 144
[pool] unable to estimate on-chain fees: rpc error: code = Unknown desc = error estimating total on-chain fee: rpc error: code = Unknown desc = insufficient funds available to construct transaction
I've noticed that my on-chain balance is actualy unconfirmed, maybe is related to the issue? I can't see an option to spend unconfirmed output.

Spending unconfirmed change isn't permitted atm.


Logging: make param's logging interface match python's logging interface.

Seems like the right changes to me.


iree-compile segfaults on Pypi out of the box

What happened?
Hi, I followed the Getting started tutorial for CPU, installed the Pypi stable release of the project. with  python -m pip install iree-compiler
I tried running  iree-compile with various options nothing was happening so I looked a bit into it and found a segFault.
Please see steps below.
Steps to reproduce your issue
python -m pip install iree-compiler
iree-compile --iree-llvmcpu-list-targets
echo $?
245

iree compile calls :
lib/python3.9/site-packages/iree/compiler/tools/scripts/ireec/main.py
which calls this segFaulting binary.
lib/python3.9/site-packages/iree/compiler/_mlir_libs/iree-compile
gdb lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/iree-compile  -batch -ex  'disassemble main'
Dump of assembler code for function main:
   0x00000000002108a4 <+0>:     b       0x2109a0 <ireeCompilerRunMain@plt>
End of assembler dump.

ireeCompilerRunMain appears in lib/python3.9/site-packages/iree/compiler/tools/../_mlir_libs/libIREECompiler.so
What component(s) does this issue relate to?
Compiler
Version information
--version fails as well.
It is the Pypi version currently available.
Additional context
No response

Hi, It is an AArch64 machine with EulerOS.

Versions and exact CPU, please?
I don't know anything about that combination, but EulerOS claims to be a RHEL derivative. Should work barring some basic incompatibility.
We build binaries with this docker image on aarch64: quay.io/pypa/manylinux_2_28_aarch64

EulerOS 2.0 (SP8).
Armv8.3-a

Can you please verify on an exact docker image and provide the details of it? We will end up trying that on a cloud instance of some kind as we don't have any more access to arm servers than that.


[Bug] Outputted type definitions are referencing the wrong path

Bug Report
Describe the bug
dist/index.d.ts is attempting to import the directory instead of the individual file, which is causing projects using the package to not correctly be able to utilize the types.
export { default as CldImage } from './components/CldImage';
export { default as CldOgImage } from './components/CldOgImage';

I think this should be:
export { default as CldImage } from './components/CldImage/CldImage';
export { default as CldOgImage } from './components/CldOgImage/CldOgImage';

Is this a regression?
New bug based on my work to add typescript.
Expected behaviour
When used as a dependency, projects should correctly see types for all the components.
Your environment

N/A
Additional context
I'll go ahead and work on this, should be pretty simple to fix.

thanks @tanzoniteblack

Update: This seemed like it should be easy, but I'm still struggling with it.

hey @tanzoniteblack wanted to give you a heads up in case you planned to do any other tweaks to TS-related stuff on this project
i published via #111 a separate package to maintain the loader and utility functions as my plan is to be able to use that in other frameworks
https://github.com/colbyfayock/cloudinary-util
feel free to poke around. i converted everything to typescript and i think i got most htings taken care of. probably some things to still improve on there and here but progress :)
thanks for your help


Changes to DepartmentUser model, add preferred_name to user profile API post options.

This change is

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


API Key exposed to clients

With the current structure (as of commit ), the MetaAnchor-API key is exposed to the client. This is, because Communication with the API is done frontend-side and not within getServersideProps()

This violates the following requirement from #2

The MetaAnchor-API-Key (provided to users of the framework with the physical labels) as well as other secrets / keys must be well protected. Especially when people with mediocre programming and IT-Security skills edit the provided software in this repo, it shall be very hard to accidentially expose those keys

Acceptance

From within a browser or any other client, it is impossible to retrieve or sniff any direct communication with MetaAnchor-API.

Good catch. I'll also file a ticket to do a sec. audit so we can catch mistakes like that before going live.


Adding a top pointing arrow .

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
In your website i have seen that instead of an arrow that should take u back to the home page i can see "GO TO TOP" which looks too ugly for ur beautiful website . I would like to replace it with an arrow icon pointing to top.
Use Case
yeah this feature will add enhancement to ur website
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSOC'24 contributor
[X] I have starred the repository

@apu52 kindly assign me this issue under gssoc'24


[feature]: cooperative close when restoring from static backup

Problem
When restoring from static backup, channels are force closed. This causes unnecessary waiting and fees.
Solution
Change the restoration pipeline. At some point the remote node has a force close transaction. Instead of broadcasting the force close, send it directly to the node which is recovering using static backup. Then the nodes can agree on cooperative close transaction using the balances from force close transaction, sign the cooperative close tx and broadcast it.
If remote node provides outdated force close transaction and local node notices this, the regular punishment for the remote node can be delivered, because the local node knows the outdated force close tx and can broadcast it and punish the remote node by collecting its funds.

Instead of broadcasting the force close, send it directly to the node which is recovering using static backup. Then the nodes can agree on cooperative close transaction using the balances from force close transaction, sign the cooperative close tx and broadcast it.

So you're proposing that this is an extra-protocol flow? I think the tricky part here is "agree on a co-op close transaction". What balance would be proposed vs accepted? Incentive wise, if you contact me for this, then I'll just tell you all the balance was on my side, and take all the funds. With the existing flow, the live party only has a single way out of the channel: force closing. If they broadcast a prior state, they lose funds.

So you're proposing that this is an extra-protocol flow?

I propose to adjust the protocol to allow such a sub-flow.

What balance would be proposed vs accepted?

The balance as of the force close tx. It is sent by the live party to the recovering party.

Incentive wise, if you contact me for this, then I'll just tell you all the balance was on my side, and take all the funds.

I would see that it doesn't match the balance of the force close transaction you sent earlier. I won't sign such a fraudulent coop transaction. If the force close transaction itself is fraudulent (outdated) - that's what can happen with the existing flow and the live party is ricking its fund in this case.

With the existing flow, the live party only has a single way out of the channel: force closing. If they broadcast a prior state, they lose funds.

This does not change, except they can agree to use coop instead of force close to safe on fees and waiting time. The live node waits for longer time, so for it it is even move beneficial to use this sub-flow.

Sounds like this issue is better suited for the spec repo: https://github.com/lightning/bolts

It's handled via the channel_reestablish message, see https://github.com/lightning/bolts/blob/master/02-peer-protocol.md#message-retransmission (option_data_loss_protect).


[Feat]: M3U8 Support

Can broadcast support be added with M3U8?
For example:

TVNET: https://mn-nl.mncdn.com/tvnet/tvnet/playlist.m3u8
TV 8.5: https://tv8.daioncdn.net/tv8bucuk/tv8bucuk.m3u8?app=tv8bucuk_web&ce=3

HLS plzzzz  m3u8

@brixxnatt I will be making developments here soon.
https://github.com/ramazansancar/mertskaplan_multitv


ENH: GHA: cancel in progress builds for pull requests

Based on InsightSoftwareConsortium/ITK#5019.
I based it on v5.4.0, let me know if this is adequate.

Have you tried this in any remote modules?

I just tried it:

created https://github.com/RTKConsortium/RTK/pull/650
amended (randomly) one file
checked that the previous actions were cancelled (with the message "Canceling since a higher priority waiting request for 'Build, test, package@concurrency' exists")

Looks good to me!

#99 proposes this for main branch.


Static env files

Use the makefile to automatically pick the right values to feed
Avoid editing config files during the deployment process
Reusing common commands
Storing deployment logs into a file
Reactive makefile targets

Removing coverage.sh, doing the work on make instead

Make env values general purpose
Add an auto generated make help target
Improve the make init target

I think these are really nice changes, thank you. Cleaning up and productionising the makefile and segmenting the tests is excellent.
There's a slight extra overhead having to learn the makefile syntax which I wasn't intimately familiar with, but piping it through GPT it became pretty clear. I would expect most users just use the default commands in the readme.

The main goal would be to just 'use' the makefile rather than needing to read/edit it, but for the sake of the review it obviously needs to be clear :)
Among the idiomatic makefile details to remark, I should probably have mention:

The use of inheritable env vars (make the final commands work on any scenario)
Defining build rules in a declarative fashion, rather than imperative

Linking artifacts to the source files that generate them

Is this what needed a bit of clarification?


bpf: xdp: don't support GENEVE passthrough with DSR-Hybrid

tail_nodeport_nat_egress_ipv4() doesn't have any support for XDP passthrough yet. See encap_geneve_dsr_opt4() for what would be needed to rewrite the outer headers. We also haven't considered how the reply traffic for non-DSR connections would get handled in the LB.
Therefore limit the encap-detection to full-DSR.

/test

/test

/test


Automatic Register Bundle

PR for issue #1492
What is being addressed
You were not previously able to automatically register user_resource bundles
How is this addressed

new parameter passed to register-bundle --user_resource_name which helps to set the path when we register the bundles
Update documentation

/test

/test


Subtract request buffering from queue time

Follow up from https://github.com/newrelic/rpm/issues/342

When enabled, this will subtract time spent waiting for the HTTP request body to be received from the queue time.
Currently only supported for Puma.
Enabled with config queue_time_subtract_buffering set to true.

If we adjust the queue time within QueueTime, then it will update queue time, response time, and the apdex calculation.  Please let me know what should be changed.  When we figure out the implementation, then I can update and add tests.  Thank you!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @tannalynn, hope you're well.  Please let me know what you think of this approach. Thank you so much!

Hi @mwlang, hope you're well.  Did you close this by accident?  Having this could make a big difference for Puma users.  Our queue time, response time, and apdex calculations are impacted so much that we can't use them.  This impacts apps that have create/update payloads a couple kB or more.  We're seeing this with 7kB payloads and the data we took shows it also impacts high-bandwidth clients.
I documented more in https://github.com/newrelic/rpm/issues/342
Would it help if I investigate if we can use another header with nginx so other setups could benefit from this?  Other webservers could also expose the buffering time like Puma does.  I could open up issues on those projects.
I think this issue is underreported because I think most don't realize this is happening and could be resolved.

This shouldn't have been closed.  I'll reopen it!

This looks like a system error of some sort.  The issue still appears as "OPEN" to me despite showing Closed above.  I think this might be because we decided to rename 'master' to 'main' and this PR is for merging to master

Oh, thank you that makes perfect sense!  I tried to update this PR's target but wasn't able to.  Please let me know if I should create a new PR.

@tlynam Figured it out!  We moved master to main and dropped the master branch altogether.  This triggered closing all PRs targeting master  If you would, please reopen or retarget this PR to main  The work you have here and the proposal is solid and we definitely want to collaborate further on this effort.


Crash when working on some projects like SAP ABAP with embedded SCM

Type: Bug
Hi VS Code Dev team,
I'm trying to program ABAP using vs code plugin 'abap remote fs' on a Mac, but everytime when I try to connect to the backend system, the IDE will crash. It seems like the IDE is trying to scan the whole system repository under this project to find out the changed files, there might be millions of files on the server, that's not in the right direction. When dealing with SAP projects, the SCM shouldn't be enabled, since we have our own scm mechansism.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


ClickhouseContainer: added generic type and withUsername/withPassword/withDatabaseName methods

ClickHouseContainer small refactoring:

added the generic type in the class definition
added methods withDatabaseName, withUsername and withPassword
other minor changes

@anshlykov could you please add tests that verify that these newly added methods are working? Thanks!


background disappears

Hello guys.
Please tell me the solution to my problem.
I use the sidebar.
In pusher I set the other div and set him background.
When the menu pops up and hides back, the background disappears.
It look like:

i update #backgroumd style
position: absolute;
background-attachment: fixed;
now background not disappears, but his little part of the bottom is not visible until I open the sidebar.

in mobile version background after sidebar toggle becomes too big and stretched


Markdown links don't work properly when there is text in brackets at the beginning of the line

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to a conversation
Send the following message

[Text text] more text ([link here](www.google.com))

Expected Result:
Message should be displayed like this -> [Text text] more text (link here)
Actual Result:
Message is not correctly hyperlinked. Please check the screenshot

The more text part is incorrectly included in a hyperlink.
Workaround:
N/A
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.83-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Please check the screenshot in Actual Result.
Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @rafecolton https://expensify.slack.com/archives/C01GTK53T8Q/p1628560869141100

Markdown links don't work properly when there is text in brackets at the beginning of the line.

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

If it could be external I would like to post my proposal 😅

Unfortunately, this is a regression from https://github.com/Expensify/expensify-common/pull/401. We expected a couple of regressions from this PR https://github.com/Expensify/expensify-common/pull/400#issuecomment-887870536.

Yeah this is the regression from m PR https://github.com/Expensify/expensify-common/pull/400. I'll fix it.

I've tried a few regex but some of the test cases break. Give me a day or two to find a solution and close this. @tgolen can you please assign this to me?

OK, assigned!

@isagoico @tgolen Can you guys help me with additional test cases for Markdown links?
While I was able to fix, [Text text] more text ([link here](www.google.com)) but the following nested cases fail.
1. [link `[inside another link](https://google.com)`](https://google.com)
2. [link with [brackets] inside of it](https://google.com)

I can find a solution to get both the nested cases work but if additional test cases are provided I can give a better solution to avoid any regression later.

Are nested links a requirement? I don't think so.
I think case 2 in your comment is something we want to support though. How is that different than the case that spawned this issue with brackets at the beginning of the text?

@tgolen I've raised the PR with fixes.
https://github.com/Expensify/expensify-common/pull/407
What I mean by the earlier question was, by default JS regex doesn't support recursion and hence are we looking at any nested options. Anyway, I've got the answer. Please review this PR so that I can update the hash in App and close it.

@mananjadhav I think there was some miscommunication here. When you asked me to assign it to you, I didn't know that you thought that meant it was OK to work on. This needs to go back through our normal process, so I am going to unassign it from you and we will walk some of this back before I can evaluate your PR.

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@arielgreen we goofed up a little bit on the process here. I am OK with the proposal that @mananjadhav gave, but we need to get this to go through UpWork before he can work on it I believe (if @mananjadhav wants to be paid for the fix).

@mananjadhav I've just sent over an offer via Upwork.

@tgolen I had worked on the first task of handling few conditions on MD Hyperlink conversion. This PR is meant to handle additional cases, which I treated as a regression from that PR. Whether this change is eligible for payment or not I am not sure about it.

Actually this issue is caused as a regression from the main PR. That's @mananjadhav  actively participated in it.

Oh, ha... well, welcome to my chaos roller coaster! Sorry about that confusion, I get it now.
OK, if it's a regression from a previous PR, then this would be part of the original job and there would be no additional payment, so I think we are OK here and I'm assigning back to @mananjadhav and we can go ahead and get the fix merged when it's done being reviewed.

@tgolen I've raised the PR with the screenshots.
There seems to be a problem in rendering the hyperlinks on mobile Apps. You'll notice that they're aligned to the top. IIt isn't due to this PR. I've attached a screenshot where even if I paste a regular link it is aligned at the top.
@parasharrajat Could this be because of the recent upgrade of react-native-render-html

@mananjadhav It could be but You don't need to worry about that in the Current PR. I am in discussions about the issues from the upgrade of react-native-render-html. Hopefully, soon they will be fixed.

@tgolen, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

@tgolen, @mananjadhav Eep! 4 days overdue now. Issues have feelings too...

@tgolen, @mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@tgolen, @mananjadhav 10 days overdue. I'm getting more depressed than Marvin.

@tgolen Is this safe to close? or add some label? It is deployed to production already as the comment on the PR

Yeah, I think this is OK to closed since it went to production. The reason it wasn't automatically closed was because in the PR description, it needs the full URL to the GH issue:


Migrated to net5.0 TFM

Thanks @mkArtakMSFT! The changes looks good. I'm glad this is a pretty simple upgrade.
We won't be able to merge this into master until .NET 5 ships, because people are still using this repo for 3.2.0. Would you be able to retarget the PR to a different branch, e.g., called net5?
Longer term when we want to merge this to master then it would also be necessary to update all the code snapshots in the save-points directory. I totally understand you might not want to do that right now if the goal is just to have a finished sample for size measurements.

Was talking to @danroth27 about this and he has suggested to have a new branch in this repo for 5.0. @SteveSandersonMS what are your thoughts? Can you create that new branch and I can retarget this PR to that?

Merging into the release/5.0 branch as is. We can make changes afterwards as needed.

@danroth27  FYI


Driver/attocube

Qcodes driver for Attocube controllers, like ANC300 (https://www.attocube.com/en/products/nanopositioners/motion-controllers-overview/anc300)

Just realised that there is also another PR  for the same instrument written by @MichaelWagener . Can we work on these and try to unify?

I've looked into this code. It has a slightly different interface than my code but I can try this at our device and so we can unify both. Should we discuss this here or contact directly via mail?

@MichaelWagener we can discuss here. It looks like you have implemented a few more features than I have (AC/DC inputs and triggered outputs), and you are using qcodes InstrumentChannel and ChannelList, which is probably preferable to the way I implemented multiple axes.
My driver has been in use since 2018 on multiple ANC300 devices with three ANM150 modules each (as well as with an older ANC150 device). Unfortunately I don't currently have access to these instruments, so I can't test out your version of the driver. If you would like to try my driver on your devices and suggest changes for a unified driver, that would be great.
One question I have is: why are you using pyserial instead of qcodes' built-in serial communication via pyvisa?

@loganbvh yes, I can test your driver in the next days and will report. And yes, it’s better to switch to pyvisa. I’ll do it.
I would prefer to put the communication parameters in the constructor parameter string and then ask all version numbers of the axis controller. If there was an error, this modul is not installed. And I think then it should be a good idea to check the version numer to get the limits and enable other functions (such as AC/DC and trigger outputs). That is in my mind and not programmed at the moment. I think that would be better than a dict as you do it.

@MichaelWagener and @loganbvh thank you very much for both of your contributions and openness for collaboration. I will make the review and merge when your works are finalised.

Just for information: my driver is ready (https://github.com/QCoDeS/Qcodes_contrib_drivers/pull/34) and tested with my device. I switched to pyvisa, the initialization was copied from your code. Thanks for that.

@GateBuilder It is fine with me if you go ahead and merge @MichaelWagener PR (https://github.com/QCoDeS/Qcodes_contrib_drivers/pull/34) and close mine

I am closing this PR as the one pushed by @MichaelWagener has now been merged. Thanks for the hard work.


[zh] sync concepts/configuration/overview.md

PR Summary

EN upstream: content/en/docs/concepts/configuration/overview.md
Sync to: content/zh-cn/docs/concepts/configuration/overview.md

Sync check byscripts/lsync.sh on main branch:
$ scripts/lsync.sh content/zh-cn/docs/concepts/configuration/overview.md
diff --git a/content/en/docs/concepts/configuration/overview.md b/content/en/docs/concepts/configuration/overview.md
index 7266f2b7eb..a040990cd8 100644
--- a/content/en/docs/concepts/configuration/overview.md
+++ b/content/en/docs/concepts/configuration/overview.md
@@ -37,6 +37,23 @@ to others, please don't hesitate to file an issue or submit a PR.

 - Put object descriptions in annotations, to allow better introspection.

+{{< note >}}
+There is a breaking change introduced in the [YAML 1.2](https://yaml.org/spec/1.2.0/#id2602744)
+boolean values specification with respect to [YAML 1.1](https://yaml.org/spec/1.1/#id864510).
+This is a known [issue](https://github.com/kubernetes/kubernetes/issues/34146) in Kubernetes.
+YAML 1.2 only recognizes **true** and **false** as valid booleans, while YAML 1.1 also accepts
+**yes**, **no**, **on**, and  **off** as booleans. However, Kubernetes uses YAML
+[parsers](https://github.com/kubernetes/kubernetes/issues/34146#issuecomment-252692024) that are
+mostly compatible with YAML 1.1, which means that using **yes** or **no** instead of **true** or
+**false** in a YAML manifest may cause unexpected errors or behaviors. To avoid this issue, it is
+recommended to always use **true** or **false** for boolean values in YAML manifests, and to quote
+any strings that may be confused with booleans, such as **"yes"** or **"no"**.
+
+Besides booleans, there are additional specifications changes between YAML versions. Please refer
+to the [YAML Specification Changes](https://spec.yaml.io/main/spec/1.2.2/ext/changes) documentation
+for a comprehensive list.
+{{< /note >}}
+
 ## "Naked" Pods versus ReplicaSets, Deployments, and Jobs {#naked-pods-vs-replicasets-deployments-and-jobs}

 - Don't use naked Pods (that is, Pods not bound to a [ReplicaSet](/docs/concepts/workloads/controllers/replicaset/) or
@@ -135,4 +152,3 @@ to others, please don't hesitate to file an issue or submit a PR.
   Deployments and Services.
   See [Use a Service to Access an Application in a Cluster](/docs/tasks/access-application-cluster/service-access-application-cluster/)
   for an example.
-

Sync check byscripts/lsync.sh on sync/configuration_overview branch:
$ scripts/lsync.sh content/zh-cn/docs/concepts/configuration/overview.md
content/zh-cn/docs/concepts/configuration/overview.md is still in sync

Thanks to the reviewers in advance.
Best Regards,
Kivinsae Fang

@windsonsea
Thanks so much for the review.
All suggestions have been committed and rebased.
Best Regards,

/lgtm


Hour and minutes when pressing timeline, delegate bug

Added hour and minutes when pressing timeline (not just hours)
Added tap gesture on timeline, not just long press
TimelinePager delegate bug when changing day by tapping on the header

Hi, thank you for your pull request. The method you've modified is soon to be deprecated once I merge the changes with editing support. New methods allow fine-grained control over the information passed to the delegate, including the specific "Date" object, not just hour.

I'm closing this pull request, as the new API introduced in the CalendarKit v0.8 solves this problem.
public protocol DayViewDelegate: AnyObject {
// Use this method to get exact date of LongPress Event
  func dayView(dayView: DayView, didLongPressTimelineAt date: Date)
}

However, thank you for the commit 325de0339e2c8afad76e460ae365aac353698b70 (delegate fix), it definitely gets cherry-picked!


CASMINST-5675: Create Argo workflow templates for prepare-images

Description
Create two Argo workflow templates for the two operations in the
prepare-images IUF stage, prepare-management-images and
prepare-managed-images. The only difference between these two stages
is that they reerence a different bootprep input file from the input
parameters on the IUF Activity.
Note that currently these two operations will occur serially, which is
slower than if we did them concurrently. We could probably improve to
get them running concurrently, but it may not always be safe to run two
sat bootprep commands concurrently if they are trying to create items
with the same names.
Test Description:
Tested by running with a sat bootprep input file that defined a few
simple CFS configurations, an image built from the barebones recipe, a
customized version of that image, and a couple of session templates that
use that image and those configurations.
Should be tested again since a few minor changes were made.
Notably, should be tested again with a sat bootprep command that
fails, e.g. on an invalid bootprep file.
Checklist Before Merging

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4


Update Plugin Artifacts Links for v0.163.11

Automated changes by create-pull-request GitHub action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Talos Local PV Hostpath prerequisites

Description
When using Local PV Hostpath on Talos, pods fail to mount PVCs with the following error
  Warning  FailedMount  13s (x2 over 2m30s)   kubelet            Unable to attach or mount volumes: unmounted volumes=[local-storage], unattached volumes=[local-storage kube-api-access-6gmx9]: timed out waiting for the condition

From my testing, this is easily resolved (solution below). I would have created a PR to document this however I'm unsure where exactly it should be documented.
The prerequisites specifically discuss iSCSI steps (and Talos does not support iSCSI at all) so I'm not sure this fits there.
If someone could confirm where this should go, I am happy to create a PR to add the required steps.
Solution
This can be resolved in a similar way to the steps outlined for the Rancher setup.
Within the Talos config, machine.kublet.extraMounts needs to contain the Local PV basePath value.
For example
extraMounts:
    - destination: /var/mnt/openebs
       type: bind
       source: /var/mnt/openebs
       options:
         - bind
         - rshared
         - rw

Yes, exactly. That is why I'm unsure where this should be documented as it doesn't relate to iSCSI. Ideally, this would be documented on the prerequisites page but this page says "Choose the platform for iSCSI client settings" so I don't think it fits there.
Alternatively, I can just add the Talos platform to this page anyway but include a disclaimer which states that only Mayastor and Local PV will work as the OS doesn't include iSCSI tooling required for other storage engines.

Hi @adamoswick can i ask if you manage to sort this, please?


[Room-Booking] Add button to collapse sidebar on mobile

Describe the feature
Currently on mobile the sidebar takes a lot of space. It would be great to add possibility to minimize sidebar to view the timeline.
Suggested solution
Add button that hides sidebar or shows the short name of room.
Additional context
No response

Not relevant in favor of #158.


edgex docker images can not launch in raspbian-buster-lite os, and the docker logs is :standard_init_linux.go:207: exec user process caused "exec format error"

🐞 Bug Report
Affected Services
The issue is located in: all docker imagex of edgex components.
   Exit 1
edgex-core-command            /core-command --registry - ...   Exit 1
edgex-core-consul             docker-entrypoint.sh agent ...   Exit 1
edgex-core-data               /core-data --registry --pr ...   Exit 1
edgex-core-metadata           /core-metadata --registry  ...   Exit 1
edgex-device-modbus           /device-modbus --profile=d ...   Exit 1
edgex-device-mqtt             /device-mqtt --profile=doc ...   Exit 1
edgex-export-client           /export-client --registry  ...   Exit 1
edgex-export-distro           /export-distro --registry  ...   Exit 1
edgex-files                   /bin/sh -c /usr/bin/tail - ...   Exit 1
edgex-mongo                   /bin/sh -c /edgex/mongo/co ...   Exit 1
edgex-support-logging         /support-logging --registr ...   Exit 1
edgex-support-notifications   /support-notifications --r ...   Exit 1
edgex-support-rulesengine     /bin/sh -c java -jar -Djav ...   Exit 1
edgex-support-scheduler       /support-scheduler --regis ...   Exit 1
And the logs of docker is:
root@raspberrypi:/home/pi/share# docker logs 5cde2024cf19
standard_init_linux.go:207: exec user process caused "exec format error"
standard_init_linux.go:207: exec user process caused "exec format error"
The logs of above is  export-distro-go-arm64:1.0.1, and the other components are the same result.
🌍  Your Environment
My yml file:
root@raspberrypi:/home/pi/share# cat docker-compose.yml
version: '3'
volumes:
db-data:
log-data:
consul-config:
consul-data:
portainer_data:
services:
volume:
image: edgexfoundry/docker-edgex-volume-arm64:1.0.0
container_name: edgex-files
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
consul:
image: arm64v8/consul:1.1.0
ports:
- "8400:8400"
- "8500:8500"
- "8600:8600"
container_name: edgex-core-consul
hostname: edgex-core-consul
networks:
edgex-network:
aliases:
- edgex-core-consul
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- volume
config-seed:
image: edgexfoundry/docker-core-config-seed-go-arm64:1.0.1
container_name: edgex-config-seed
hostname: edgex-core-config-seed
networks:
edgex-network:
aliases:
- edgex-core-config-seed
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- volume
- consul
mongo:
image: edgexfoundry/docker-edgex-mongo-arm64:1.0.1
ports:
- "27017:27017"
container_name: edgex-mongo
hostname: edgex-mongo
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- volume
logging:
image: edgexfoundry/docker-support-logging-go-arm64:1.0.1
ports:
- "48061:48061"
container_name: edgex-support-logging
hostname: edgex-support-logging
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- config-seed
- mongo
- volume
notifications:
image: edgexfoundry/docker-support-notifications-go-arm64:1.0.1
ports:
- "48060:48060"
container_name: edgex-support-notifications
hostname: edgex-support-notifications
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- logging
metadata:
image: edgexfoundry/docker-core-metadata-go-arm64:1.0.1
ports:
- "48081:48081"
container_name: edgex-core-metadata
hostname: edgex-core-metadata
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- logging
data:
image: edgexfoundry/docker-core-data-go-arm64:1.0.1
ports:
- "48080:48080"
- "5563:5563"
container_name: edgex-core-data
hostname: edgex-core-data
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- logging
command:
image: edgexfoundry/docker-core-command-go-arm64:1.0.1
ports:
- "48082:48082"
container_name: edgex-core-command
hostname: edgex-core-command
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- metadata
scheduler:
image: edgexfoundry/docker-support-scheduler-go-arm64:1.0.1
ports:
- "48085:48085"
container_name: edgex-support-scheduler
hostname: edgex-support-scheduler
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- metadata
export-client:
image: edgexfoundry/docker-export-client-go-arm64:1.0.1
ports:
- "48071:48071"
container_name: edgex-export-client
hostname: edgex-export-client
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- data
environment:
- EXPORT_CLIENT_MONGO_URL=edgex-mongo
- EXPORT_CLIENT_DISTRO_HOST=edgex-export-distro
- EXPORT_CLIENT_CONSUL_HOST=edgex-config-seed
export-distro:
image: edgexfoundry/docker-export-distro-go-arm64:1.0.1
ports:
- "48070:48070"
- "5566:5566"
container_name: edgex-export-distro
hostname: edgex-export-distro
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- export-client
environment:
- EXPORT_DISTRO_CLIENT_HOST=edgex-export-client
- EXPORT_DISTRO_DATA_HOST=edgex-core-data
- EXPORT_DISTRO_CONSUL_HOST=edgex-config-seed
- EXPORT_DISTRO_MQTTS_CERT_FILE=none
- EXPORT_DISTRO_MQTTS_KEY_FILE=none
rulesengine:
image: edgexfoundry/docker-support-rulesengine-arm64:1.0.0
ports:
- "48075:48075"
container_name: edgex-support-rulesengine
hostname: edgex-support-rulesengine
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
device-mqtt:
image: edgexfoundry/docker-device-mqtt-go-arm64:1.0.0
ports:
- "49982:49982"
container_name: edgex-device-mqtt
hostname: edgex-device-mqtt
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- data
- command
device-modbus:
image: edgexfoundry/docker-device-modbus-go-arm64:1.0.0
ports:
- "49991:49991"
container_name: edgex-device-modbus
hostname: edgex-device-modbus
networks:
- edgex-network
volumes:
- db-data:/data/db
- log-data:/edgex/logs
- consul-config:/consul/config
- consul-data:/consul/data
depends_on:
- data
- command
networks:
edgex-network:
driver: "bridge"
...
My os is raspbian-buster-lite:2019-07-10-raspbian-buster-lite,img download from https://www.raspberrypi.org/

If you are running Raspbian, then I'm fairly certain you are running armhf, which is not supported by the project. You need to use arm64 to run the published EdgeX containers, see https://wiki.edgexfoundry.org/display/FA/Running+on+a+RaspberryPi for how to run arm64 Ubuntu 18.04 LTS Server on the Raspberry Pi 3B+ and use EdgeX.


Remove duplicated line in syntax/yaml.vim

I found duplicated line in syntax/yaml.vim file.

ping @ZyX-I as the maintainer of that file.

Codecov Report

Merging #4799 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4799      +/-   ##
==========================================
- Coverage   81.55%   81.39%   -0.16%
==========================================
  Files         118      118
  Lines      145677   143042    -2635
==========================================
- Hits       118800   116429    -2371
+ Misses      26877    26613     -264

Impacted Files
Coverage Δ

src/libvterm/src/unicode.c
87.17% <0%> (-7.7%)
:arrow_down:

src/if_cscope.c
75.5% <0%> (-0.93%)
:arrow_down:

src/search.c
81.13% <0%> (-0.85%)
:arrow_down:

src/move.c
86.91% <0%> (-0.69%)
:arrow_down:

src/tag.c
77.63% <0%> (-0.69%)
:arrow_down:

src/screen.c
82.02% <0%> (-0.68%)
:arrow_down:

src/profiler.c
92.59% <0%> (-0.67%)
:arrow_down:

src/viminfo.c
75.06% <0%> (-0.58%)
:arrow_down:

src/gui.c
63.13% <0%> (-0.58%)
:arrow_down:

src/misc1.c
80.08% <0%> (-0.57%)
:arrow_down:

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4999a7f...b935f23. Read the comment docs.

I'll include it now, since it's an obvious fix, but I do hope Nikolai still maintains this file.


switch to ESP8266HTTPClient

esp8266/Arduino added an http client in their libraries: https://github.com/esp8266/Arduino/pull/1081, let's switch to that :)
We should file separate issues and contribute PR for the current limitations.

implicit and blocking connect (apparently lwip support non blocking connect and protected connect() could be exposed via a derived class).
no support for PUT DELETE PATCH UPDATE.
setter for certs/key but no impl.

Fixes #21 #19.

lgtm, great progress.


Allow for rendering at high frame rates

Version: 1.30.0
Commit: c6e592b2b5770e40a98cb9c2715a8ef89aec3d74
Date: 2018-12-11T22:21:33.585Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Linux x64 4.18.20-gentoo
Graphics driver: amdgpu
I have done some rudimentary testing, and I have concluded that VS Code does not render above 60 frames per second. I recently enabled smooth selection caret rendering, and I noticed that for moving to the end of longer lines, the number of frames rendered are about half or less than what is rendered by my mouse going at the same distance and speed. I have a 144hz monitor, and 144 is more than double 60, which would confirm my test results.
Additionally, I can get 144 frames per second in Chrome, tested via https://www.testufo.com/ and compared with Firefox running at 60 frames per second.
What I would like is the possibility of rendering VS Code at a frame rate higher than 60. This would of course only be expected with GPU rendering.

still no status?

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430
Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

I for one would really like to see VS Code respect refresh rates higher than 60hz. I cringe whenever I need to switch over to VS Code from PhpStorm on my 144hz monitor.
I'd even be happy with 100 FPS if it's a performance issue. Or allow the FPS cap to be configured for "power" users. Or use requestAnimationFrame() like it's not the 20th century. Or something!

If you're still looking for a solution, adding these settings to settings.json should do the trick.
  "editor.smoothScrolling": true,
  "editor.cursorSmoothCaretAnimation": true,
  "workbench.list.smoothScrolling": true,

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430
Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

im a starter user, how i can get at vscode/src/vs/base/browser/dom.ts, ive searched this path and i cant find

@LukGaming I assume you would need to clone the repo, make that modification, and build VSCode from scratch. It's more of a POC than a solution.

Launching VSCode like this on Linux uncaps the FPS for me and makes scrolling smooth:
code --disable-gpu-vsync --disable-frame-rate-limit

But it still seems that mouse input is capped to 60 FPS, as dragging the scroll bar with the mouse still visually looks like 60 FPS.

Launching VSCode like this on Linux uncaps the FPS for me and makes scrolling smooth:
code --disable-gpu-vsync --disable-frame-rate-limit

But it still seems that mouse input is capped to 60 FPS, as dragging the scroll bar with the mouse still visually looks like 60 FPS.

Those options are not known in the latest Ubuntu (20.04).

Solution
I found out that this is already baked in as of today, here is a more detailed explanation: https://stackoverflow.com/a/68611751/8816585

I just tested it using my original smooth caret test. The smooth caret animation is running at 144 FPS on my 144 Hz monitor by default. Thanks for finding that out. Now the only outstanding issue is mouse input.

VS Code locks framerate to the lowest refresh rate of all monitors, so the linked answer above involves unplugging or disabling your other low refresh rate monitors, which is very unconvinient for me. A different work around I found, is disabling hardware acceleration, tho be aware that your cpu and gpu usage will increase, because VS Code will be using software rendering and will have to render higher framerate. On i7-8700 and GTX 1080 while not doing anything usage is 0%, but while scrolling it goes up to CPU 9% and GPU 10% but if smooth scrolling is enabled then CPU 16% and GPU 22%
To disable hardware acceleration:

Open VS Code
Open the Command Palette (Ctrl+Shift+P)
Run the Preferences: Configure Runtime Arguments command
This command will open an argv.json file
Add or uncomment "disable-hardware-acceleration": true
Save the file (Ctrl+S)
Restart VS Code

And if you also want smooth scrolling animation, enable it in settings. Open settings, search for smooth scrolling and enable both options.

You can also try launching VS Code like this:
code --use-gl=egl

This is a Chromium flag that (for some reason) seems to enable max FPS in all Chromium/Electron based apps that I've tried it with on either of my monitors. YMMV.

You can also try launching VS Code like this:
code --use-gl=egl

This is a Chromium flag that (for some reason) seems to enable max FPS in all Chromium/Electron based apps that I've tried it with on either of my monitors. YMMV.

From my testing this flag also disables hardware acceleration, so it has the same effect.

Not sure that disabling HW accel is the way here tho, I'd rather buy another matching monitor.

From my testing this flag also disables hardware acceleration, so it has the same effect.

Ah that makes sense.
In any case, this issue already seems to be somewhat fixed upstream in Chromium. Hopefully it will trickle down to Electron and VS Code sooner or later.

From my testing this flag also disables hardware acceleration, so it has the same effect.

I've just tested this myself, and when using --use-gl=egl on Google Chrome, all of the Graphics Features under chrome://gpu/ remain the same. So it doesn't look like hardware acceleration is being disabled on my end.
@Skillter How did you determine that --use-gl=egl was disabling hardware acceleration in VS Code?

For what it's worth:
https://github.com/microsoft/vscode/blob/da0afcff64ff1efc6ae6580294537b3b87dd682e/src/vs/base/browser/dom.ts#L430
Changing it to 6 (144 FPS is 6.9ms) allows for 144 FPS mouse-based scrolling (dragging scrollbar). It does not appear to change monaco css animations (for smooth cursor caret).

Hi, thank you. I think this is the only real solution, because if you check extantion page's scrolling, it is buttery smooth. So Vs Code is already running at 144hz, but the scrolling inputs are locked for optimization it looks like, and this causes '60hz like' experience on high refresh rate monitors.
It is pain to we have to build from source this though, I hope they can add an option for this in settings.

You can also try launching VS Code like this:
code --use-gl=egl

This is a Chromium flag that (for some reason) seems to enable max FPS in all Chromium/Electron based apps that I've tried it with on either of my monitors. YMMV.

This is the only thing that fixed the issue for me. VSCode felt 30FPS and i have dual 144hz, so no reason for low framerate

You can also try launching VS Code like this:
code --use-gl=egl

This is a Chromium flag that (for some reason) seems to enable max FPS in all Chromium/Electron based apps that I've tried it with on either of my monitors. YMMV.

This is the only thing that fixed the issue for me. VSCode felt 30FPS and i have dual 144hz, so no reason for low framerate

I have tried other methods such as disable gui for many time, and this is THE ONLY solution on Ubuntu24.04 by now.


Add obfuscation

Someone from the developers want to add to the project this https://github.com/fritzone/obfy ?

Interesting link. Indeed obfuscation is necessary especially for an open source licensing library.
There is another intrinsic weakness to keep in mind. We need to use this library in java and python, the api need to be very simple, and that's until now the easiest point of attack.
My current effort is on:

getting the tests to work, otherwise every modification risk to break other people's work.
rearrange the build in order to make it more robust and modular. I'll publish a document about that feel free to comment.
Thanks for your contributions until now.

@gcontini check https://github.com/lurumdare/open-license-manager/tree/obfy this branch if u interested.
I think obfy only for C++.

The research showed that the use of this project (obfy) has little meaning in front of advanced technologies (virtualization(Themida,VMProtect) ). The weak point in virtualization is the use of functions similar to strcmp and external calls (Intermodular calls)
It is worth paying more attention to working with the network, so that it is more difficult for an attacker to emulate a server.

Indeed, a better protection would be to have the client software connect
over the network to either a license server that you (software editor)
control, or that is protected with a reasonably difficult-to-crack hardware
usb token.
The certificate authority's public certificate would still need to be
installed on the client, which would be a weak point of the system.
Le lun. 2 sept. 2019 à 07:11, lurumdare<EMAIL_ADDRESS>a écrit :

The research showed that the use of this project (obfy) has little meaning
in front of advanced technologies (virtualization(Themida,VMProtect) ). The
weak point in virtualization is the use of functions similar to strcmp and
external calls (Intermodular calls)
It is worth paying more attention to working with the network, so that it
is more difficult for an attacker to emulate a server.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/open-license-manager/open-license-manager/issues/22?email_source=notifications&email_token=ALRMGXLN2T4POEXLMQFZAWLQHSN6RA5CNFSM4HP5NM3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UXALA#issuecomment-527003692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALRMGXIKM4GMIAEHXDQYZ5DQHSN6RANCNFSM4HP5NM3A
.

@emgstabilis
I believe that a hardware USB token is meaningless in this case. Better use obfuscation syscalls, for example. Well, bind this obfuscation to a secure server (to minimize MITM).


how to emit back to client?

Hey,
How do i send data back to the client? With socket.io i used to use emit method but it's seems it wont work with SC..
Here is the example:
server.js
    const socketClusterServer = require('socketcluster-server');
    const agServer = socketClusterServer.attach(server, options);

    (async () => {
        for await (let { socket } of agServer.listener('connection')) {
            socket.send('connected',true);//won't work
            socket.transmit('connected',true);//won't work
            socket.emit('connected',true);  //won't work
        }
    })();

client.js
let socket = require('socketcluster-client').create({
    hostname: 'localhost',
    port: 4000
});

(async () => {
    for await (let data of socket.receiver('connected')) {
        console.log(data)
    }
});

@xeroxstar It has been renamed from emit to transmit. See https://socketcluster.io/docs/basic-usage/#client-transmit-messages-through-a-socket
This was done to avoid mistaking it for the emit method of EventEmitter.

@xeroxstar It has been renamed from emit to transmit. See https://socketcluster.io/docs/basic-usage/#client-transmit-messages-through-a-socket
This was done to avoid mistaking it for the emit method of EventEmitter.

So how i transmit back to the client? socket.transmit wont send back the data to the browser.

@xeroxstar In client.js, the async block was declared but not invoked as an IIFE.
(async () => {
    for await (let data of socket.receiver('connected')) {
        console.log(data)
    }
});

should be
(async () => {
    for await (let data of socket.receiver('connected')) {
        console.log(data)
    }
})();

Actually this is a common mistake (I've also done it a few times before). Maybe I will mention in the docs to be careful about this.

Declaring IIFEs should get easier when async do becomes supported: https://github.com/tc39/proposal-do-expressions/issues/4

It's so embarrassing, sorry for that.... you right, i did not invoke the method!!!

No worries, it's easy to overlook. Happened to me as well in the past. That's why I'm looking forward to async do syntax.


Speed up the checking

Mitigated by 8aa48fc5b6450f2cb3fa89ad58408cbe16822fdf.
Queries could still be parallelized.

Queries were parallelized using a thread pool in 0.1.4.


Hi, there are problems with uploading pictures

Hello,
let me know if there is any problem.
thanks


Import statement with jspm

Hello
I used to use jspm in my react typescript projects. I installed for instance react, react-dom, bootstrap, material-ui succesfully, and i.m able to import them in my ts files with import statement.
Unfortunately, for some packages like react toolbox which successfully downloads with jspm too, i.m unable to import these libraries in the project.
In the same way, il i use a sub reference in for instance material-ui like import {ThemeDecorator} from 'material-ui/styles'' it does'nt work too.
Could you explain me how the eclipse plugin try to find references for js libraries? And give me a hint to perform the above tasks?
Best regards
Ps : it is a very nice plugin! Which is better in my sense than the webstorm or vs ones

The plugin resolves references via the built-in TypeScript language services support. Basically, the plugin finds all the .ts and .tsx files within the source folders of a project and sends them all into TypeScript language services. The service then resolves things.

Thanks
But when importing for instance react which is not a ts or tsx file but a js file found in the the jspm repository? How does it do?
Envoyé de mon iPhone

Le 11 nov. 2015 à 16:55, Derek Cicerone<EMAIL_ADDRESS>a écrit :
The plugin resolves references via the built-in TypeScript language services support. Basically, the plugin finds all the .ts and .tsx files within the source folders of a project and sends them all into TypeScript language services. The service then resolves things.
—
Reply to this email directly or view it on GitHub.

JavaScript files are not passed into TypeScript so they aren't included. I believe newer versions of TypeScript may be able to ingest JS, but the version currently available does not.

Oki
Last mail :)
So if the react library is a js library and that the import * as React from 'react' works, it is because there were a ///reference ... To a d.ts file before. Is it right?
Envoyé de mon iPhone

Le 11 nov. 2015 à 17:09, Derek Cicerone<EMAIL_ADDRESS>a écrit :
JavaScript files are not passed into TypeScript so they aren't included. I believe newer versions of TypeScript may be able to ingest JS, but the version currently available does not.
—
Reply to this email directly or view it on GitHub.

Yeah - if there is a d.ts file anywhere in the project with the definitions for React than that would work. Definition files are not loaded by path typically. (For our projects we typically put them all in a typings directory)

thanks
I put also my d.ts files in the typings directory which is created when i
use automatically  while using tsd,  The js library are loaded in my case
through jspm with a" jspm install react" command for instance into the
jspm_packages directory/npm or github
it is quite convenient and easy to use (excepted when i don't understand
for some packages why it is not working in ts ;) )
best regards
2015-11-11 17:25 GMT+01:00 Derek Cicerone<EMAIL_ADDRESS>
Yeah - if there is a d.ts file anywhere in the project with the
definitions for React than that would work. Definition files are not loaded
by path typically. (For our projects we typically put them all in a typings
directory)
—
Reply to this email directly or view it on GitHub
https://github.com/palantir/eclipse-typescript/issues/289#issuecomment-155834766
.


Should we implement Python 2 backwards compatibility?

Although it is true that Python 3 is slowly becoming the new standard (at least in my experience), lots of people still use Python 2. Is there anything in the code here that might not be backwards compatible? Keras is compatible with at worst 2.7.
Note this might be as simple as requesting that Travis build with Python 2.7 and then just debugging from a forked origin/dev branch.

Let me know what happens! Also could you elaborate a bit on this?

I've removed 3.4 and 3.5 because of the build failure that comes from Travis due to being able to deploy just once per version to pypi

I'm sorry I just don't know enough about Travis. Specifically what do you mean about Travis being able to deploy once per version? Thanks!

3.7 is not available on Travis looks like, and 2.7 fails on the Cervical Cancer test where spear_reducer() is used. Gives pandas KeyError on val_acc...I'll look into what's causing this...but in other words looks good.
For Travis there is travis.yml where we can simply add the versions of python we want to test with. Then travis will run the procedures for all those versions we list separately. It's very convenient :)

@x94carbone ...by the way are you getting all the build fail notices from the dev-mikko branch to your email?

Ok it's resolved now. All tests passing for Python versions:

2.7
3.4
3.5
3.6

The corresponding Travis build report here.
I will do some QA tomorrow and get it merged with dev. Closing.


HDFS-17497. The number of bytes of the last committed block should be calculated into the file length

One in-writing HDFS file may contains multiple committed blocks, as follows (assume one file contains three blocks)

| Block 1 | Block 2 | Block 3
-- | -- | -- | --
Case 1 | Complete | Commit | UnderConstruction
Case 2 | Complete | Commit | Commit
Case 3 | Commit | Commit | Commit

But the logic for committed blocks is mixed when computing file size, it ignores the bytes of the last committed block and contains the bytes of other committed blocks.
public final long computeFileSize(boolean includesLastUcBlock,
    boolean usePreferredBlockSize4LastUcBlock) {
  if (blocks.length == 0) {
    return 0;
  }
  final int last = blocks.length - 1;
  //check if the last block is BlockInfoUnderConstruction
  BlockInfo lastBlk = blocks[last];
  long size = lastBlk.getNumBytes();
  // the last committed block is not complete, so it's bytes may be ignored.
  if (!lastBlk.isComplete()) {
     if (!includesLastUcBlock) {
       size = 0;
     } else if (usePreferredBlockSize4LastUcBlock) {
       size = isStriped()?
           getPreferredBlockSize() *
               ((BlockInfoStriped)lastBlk).getDataBlockNum() :
           getPreferredBlockSize();
     }
  }
  // The bytes of other committed blocks are calculated into the file length.
  for (int i = 0; i < last; i++) {
    size += blocks[i].getNumBytes();
  }
  return size;
}

The bytes of one committed block will not be changed, so the bytes of the last committed block should be calculated into the file length too.
And the logic for committed blocks is mixed too when computing file length in DFSInputStream. Normally DFSInputStream does not need to get visible length for committed block regardless of whether the committed block is the last block or not.
HDFS-10843 encountered one bug which actually caused by the committed block, but HDFS-10843 fixed that bug by updating quota usage when completing block. The num of bytes of the committed block will no longer change, so we should update the quota usage when the block is committed, which can reduce the delta quota usage in time.
So there are somethings we need to do:

Unify the calculation logic for all committed blocks in computeFileSize of INodeFile
Unify the calculation logic for all committed blocks in getFileLength of DFSInputStream
Update quota usage when committing block

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 48s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
40m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 290 unchanged - 1 fixed = 294 total (was 291)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
40m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
268m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

426m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestLargeBlockReport

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6765

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux be83e02b2463 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c54e4a633f06fcaceb4781e63f06bb8a76b0fc8

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/1/testReport/

Max. process+thread count
3165 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 31s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
41m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  3s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 290 unchanged - 1 fixed = 290 total (was 291)

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
40m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
269m  3s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

427m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6765

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 3ed817d3780c 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0aa96155ae7aed9c69d8c0ede601fffd4bc8c17f

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/2/testReport/

Max. process+thread count
2789 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6765/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Great catch, not review carefully, but I remember this have been discussed for long time. IIRC, client also check the file length through request DataNode which manage the uncomplete block? Thanks.
(will try to review PR later.)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 01s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 00s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
86m 48s

trunk passed

+1 :green_heart:
compile
5m 57s

trunk passed

+1 :green_heart:
checkstyle
4m 39s

trunk passed

+1 :green_heart:
mvnsite
6m 25s

trunk passed

+1 :green_heart:
javadoc
5m 50s

trunk passed

+1 :green_heart:
shadedclient
143m 08s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 37s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 19s

the patch passed

+1 :green_heart:
mvnsite
4m 00s

the patch passed

+1 :green_heart:
javadoc
3m 25s

the patch passed

+1 :green_heart:
shadedclient
154m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 13s

The patch does not generate ASF License warnings.

412m 04s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6765

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 15fffafc3582 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 0aa96155ae7aed9c69d8c0ede601fffd4bc8c17f

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6765/3/testReport/

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6765/3/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

IIRC, client also check the file length through request DataNode which manage the uncomplete block?

Like other committed blocks, the client does not need to get the visible length from DN if the last block is in committed state.


Error handling path names with spaces

I get an error log for every path that contains spaces.
Example output:
2019-10-17T08:42:47+0200 error: Failed to add Time Machine exclusion: /Users/mario/Sites/CraftCMS/craftcms-starter/project_data/know: Error (-43) while attempting to change exclusion setting.
how/.DS_Store: Error (-43) while attempting to change exclusion setting.

This should be fixed in the next release.


improve  the intro of blockchain..

There is a problem in the lines of readme file. I  am fix this issue, so you can assign me this file...

Can u please describe the problem.

ViKASH SIR, i am add references links  and add lines in conclusion..

Gr8.

sir add the ssoc 2.0 label


Missing touchbar actions

In version 2, I seem to remember that there was a Touchbar item to choose smileys.
It would be a nice addition to add some functionality to the Touchbar.

This is blocked until electron supports the TouchBar.
Here is their issue: https://github.com/electron/electron/issues/7781

@danielbuechele, slightly off-topic, but what was the main reason for switching to Electron? There are other electron apps that wrap Messenger already like https://github.com/sindresorhus/caprine.
Not switching to Electron, would've given more flexibility with macOS like resolving this issue.

Electron just added Touch Bar support: https://electron.atom.io/blog/2017/03/08/touch-bar-support

@danielbuechele I checked out the latest master version. I completely understand it is a WIP version, but an emoji button would be a lot more helpful than buttons to switch conversations. Keep up the good work!
(I can only dream: thumbs up button? GIFs? Stickers?)

With version 3.1.0 there is basic TouchBar support. But I fully agree that we should continue discussion on what the TouchBar support should look like. I want to give the current implementation a chance to try out, but I agree that at least the like-button should be available on the TouchBar.

I would argue that an emoji button is at least as important, seeing it was there in the non-electron version and all native MacOS messaging apps. I see that the Electron TouchBar API does not (yet) provide an emoji button. A custom implementation would probably be overkill, although it would be very cool if it would display the facebook emoji instead of the Apple ones. 😎

I think it's interesting to note is that, as far as I can tell, the Touchbar integration (emojis) with version 2 is a native thing (text-input field) and not done custom by Daniel. That emojis are now missing from the touchbar in version 3 is simply unintended result of moving to Electron.
But Electron meanwhile introduced Touchbar support, so sooner than later we'll see it integrated into Goofy as well.
Currently running V2 and V3 side by side to test performance and energy usage.

Changed the way the touchbar works now - instead of using to swap between conversations, can now perform actions on the conversation e.g. mute, archive, like previous conversation, etc.
Was thinking about putting stickers / gifs etc but lets see how we do with these first (and we can look at adding more later).
This was completed in v3.3.6


Rename client_name to company_name

In the PowerMeter, rename client_name to company_name

can this be assigned to me

@moazfarrukh feel free to make a PR regarding this issue


No way to get current route without Request object from App

Slim version 3.x.
The app creates new request objects when executing $request->withAttribute(). This means the attributes being set are not available for other objects that get the request object injected from the DI container.
Scenario: I'm trying to create a twig extension that needs the current route name. It gets the request object injected, but this reject object has no attributes because the object is treated immutable.
The matched route is also not stored somewhere else, but only used in transition (in the dispatchRouterAndPrepareRoute() method), so the only way to currently find the current route is to match it again.
Any ideas on how to get access to the current route object?

This is how PSR-7 works.
Use the request object in the action - the route is in an attribute.

Yes, I've already used that attribute in middleware, and that's working alright. But now I'm trying to get the current route in a Twig extension (somewhat like is_current_path in Twig-View), but that's already setup before $app->run() is executed.

... ah yes. chicken and the egg problem.
@akrabat Twig-View has a dependency on the Request object... I think this issue should be opened on Twig-View

@geggleto I just used Twig-View as an example. That extension itself does not need the current route, as it is just looking at the paths, so it can just do with the router and request object.
But I'm trying to match on the route name instead of its path. That way you don't need to provide the path params. But getting the current route proves to be difficult.

@Ikke for the reasons Akrabat stated it's not possible to do what you want with Slim 3. PSR-7 clearly states objects must be cloned which causes issues with referencing them.... Slim requires them to be in the container... for BC/Other reasons. Slim 4 will not have this problem.

@geggleto Alright, thanks. Then I'll use my work-around for now.

The way to do it is to set the setting that determines the route early to true. Then have a piece of middleware that sets the matched route into a property in your extension, which it retreives via the DIC (though I suppose it could be a static propety).


Fix documentation on minikube installation ID docs

Changed title and content for "Menginstal kubectl" on each tab for consistency, also fix id on link kubectl installation
Page: https://kubernetes.io/id/docs/tasks/tools/

/assign @irvifa

I signed it

I signed it

I signed it

Superb 😎
/lgtm
/approve


Refs/heads/kurushitan istam patch 1

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request


Adds prepared execution tests for every sous subcommand

Shouls improve coverage and make room to move more into DI

Current coverage is 47.61% (diff: 61.53%)

Merging #105 into master will increase coverage by 0.25%

@@             master       #105   diff @@
==========================================
  Files            98         98
  Lines          4873       4881     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2308       2324    +16
+ Misses         2339       2330     -9
- Partials        226        227     +1

Powered by Codecov. Last update 6fb8f2b...20441f0


[Tooltip] Unmount Tooltip on exit and mount on enter

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Ideally I'd like an option to configure the Tooltip to unmountOnExit and mountOnEnter
Current Behavior

Seems like there is no easy way to achieve that.
 This I think impacts the performance.
Your Environment

Tech
Version

Material-UI
beta.40

React
16.20

browser

etc

I'd not suggest to unmount tooltips for Accessibility reasons. Often adding a tooltip specifies aria to be labeled by this tooltip (especially if it is an icon), so it has to be in DOM so screen reader can actually read it properly.

@z-ax I didn't think of the Accessibility part. Good point. However, I've already noticed a big perf drawback introduced by Tooltips not being unmounted upon disappearance, especially if you want to enable tooltips for cells in a table with lots of rows. Switching between pages has become chunky and laggy because of this. (I verified by taking out the tooltips from the table cells, and the perf dramatically boosted)

We should really think about fixing this issue now. I've seen several issues that are related to this.
For example, I recently found out that even though the tooltips are hidden, they still occupy the original space and is on top of other elements:
The tooltip was triggered by the ? in the red circle.

After mouse leave:

As you can see, that tooltip is hidden now, but still takes up the original space, overlapping existing elements, resulting in those element not able to be interacted.

This issue comes from #10843

I've seen the Popper dependency was upgraded in v1.2.2. @franklixuefei, is performance still an issue? Just curious :) We don't have tooltips for table cells to test quickly, but overall didn't see any performance problems recently.

you could implement the tooltip in a way that the same DOM element would be used for the tooltip contents (Reference in<EMAIL_ADDRESS>terms). should be quite performant?

I also had dramatic performance issues using Tooltip in a list and then scrolling. I'm assuming this is caused by Popper constantly reevaluating every items position.
I made a drop-in replacement for material-uis Tolltip that solves this issue by only rendering the Tooltip when the mouse is over the childrens element.
https://gist.github.com/matthiasp42/c561fe09f86b61e364bdd23369be5485
I'm sharing it here so it may help somebody else, but also I would love some feedback on my solution, or if this is for some reason not a proper way to do it.

I also had dramatic performance issues using Tooltip in a list and then scrolling

Yes, it's a recent regression. It's already fixed on master. We will soon release the fix.


[V8] ~100% test coverage

How to add code coverage with istanbul:
npm i -D nyc
# npm i -D graceful-readlink

// package.json > "scripts"
"test": "nyc --reporter=lcov --reporter=text mocha --require script/test/index.js"

now when test is run, code coverage will print to console, with a detailed report available at
/coverage/lcov-report/index.html

e.g. getDefaultProps() is never hit by tests

Thanks, added, this would help clear up what test should be left to write to reach ~100%. It's currently at ~90%.


SeedKey Remote sharing and signing

Describe the bug
Enable remote sharing and signing flow for seed key.

Verified this issue on keeper app v 1.2.20(419)


chore(ci): update rpm prefix

FTI-6054

Summary

Checklist

[ ] The Pull Request has tests
[ ] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

full matrix:
https://github.com/Kong/kong/actions/runs/10313492722?pr=13477
https://github.com/Kong/kong/actions/runs/10313492726?pr=13477

Cherry-picked in Kong/kong-ee#10120


Agent should be able to create a tool autonomously

Agent should be able to programatically create a tool, load it dynamically and use on the fly.

This can be packaged as a toolkit which could constitute of access to tools apis, validation of the tool , iterate and improve it

love the idea! let us know when ready!

I have been giving some thought to our current approach towards tool development and I'd like to suggest a different strategy that could potentially make our process more efficient and cost-effective.
Instead of creating a wide variety of specialized tools, we could look into using a restricted execution environment, such as 'RestrictedPython'. This environment would come pre-installed with the necessary libraries required by our tools, and provide a secure and controlled space to execute our code, similar to the function of a code interpreter.
One of the key features we could implement within this environment is a filter mechanism. This mechanism would act as a safeguard against the download and usage of potentially harmful libraries, ensuring the safety and integrity of our environment. Although this might limit the use of unrestricted 'pip install', I believe we can address this by implementing appropriate barriers or filters.
To help guide the construction and use of our tools, I suggest maintaining an extensive, step-by-step documentation. This documentation can serve as an initial resource for our universal agent. As we develop new tools or update existing ones, their respective documentations can be added to this resource.
Additionally, to assist the universal agent in building a particular tool, we could employ techniques like Maximal Marginal Relevance (MMR) to search for the most relevant documentation. This approach will allow the agent to find the most pertinent information effectively.
Looking forward, I anticipate advancements in AI, such as GPT-5 or its successors, which will likely be trained on comprehensive internet data. These advancements could naturally solve our current challenges. However, until such technology is available, the above-proposed solution could serve as an effective, safe, and cost-efficient approach.


Autoscaling Group Race Condition

I believe this is all glued together now, but we still have a race condition if the first member of the autoscaling group doesn't come up before the configure.sh is run.  This might be a non-issue in practice as the use of the script has changed substantially since I last encountered this issue.  I'm going to leave this open and see if we observe it.

I don't think this is an issue anymore.


explain how to set environment in Azure better

For setting environment in Azure this documentation only says "Add the key and value in App settings.". But it does not say what should I set for key. Is it Aspnetcore_Environment?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ceffa6a2-770c-1cd9-5145-dcd423f9dd22
Version Independent ID: 1cb5eb30-dd84-e5e1-5826-d74243fabf04
Content: Use multiple environments in ASP.NET Core
Content Source: aspnetcore/fundamentals/environments.md
Product: asp.net-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Thanks for commenting @samnaseri ... this topic + sample is coming up for the 2.1 update on #5495. I'll address this at the same time.

@guardrex this should be part of the configuration docs. There's nothing here about app service:
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-2.1&tabs=basicconfiguration

@davidfowl Config of environment is only lightly covered, and the topic throws the reader over to the Multiple environments topic to deal with the subject in detail.
I opened https://github.com/aspnet/Docs/issues/7102 so that we can discuss config broadly later ... after a handful of issues are fixed first.


remove k8s admission log UI

removing the deprecated k8s admission log UI

Codecov Report

Merging #1556 (b296348) into master (205e2b5) will increase coverage by 1.18%.
The diff coverage is 60.60%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   77.30%   78.49%   +1.18%
==========================================
  Files         281      280       -1
  Lines        8056     7906     -150
==========================================
- Hits         6228     6206      -22
+ Misses       1455     1329     -126
+ Partials      373      371       -2

Impacted Files
Coverage Δ

pkg/cli/run.go
85.71% <ø> (ø)

pkg/downloader/module-download.go
79.67% <ø> (ø)

pkg/http-server/routes.go
100.00% <ø> (ø)

pkg/iac-providers/arm/v1/load-file.go
70.83% <ø> (ø)

pkg/iac-providers/docker/v1/load-file.go
93.33% <ø> (ø)

pkg/iac-providers/docker/v1/parser.go
100.00% <ø> (ø)

pkg/iac-providers/output/types.go
100.00% <ø> (ø)

pkg/iac-providers/output/vulnerability.go
100.00% <ø> (ø)

pkg/iac-providers/providers.go
100.00% <ø> (ø)

pkg/iac-providers/terraform/commons/convert.go
69.42% <ø> (ø)

... and 44 more


Remove the meta WeakMap

I was reviewing #42 and I realized that we don't actually need to store the id and lang for each entity.  The id is needed for the error recovery which can be (and even should be) done in the context, and lang is needed for getting the right values for placeables and macros, but it should be constant during a single formatting operation.
I decided to go ahead and suggest this change.  @zbraniecki, I can help you rebase #42 on top of this, I'm expecting some (but not many) conflicts.

I don't see any change in raptor tests on FM using French as the non-default language.  The code gets simpler, however, so: @zbraniecki r?

r+


Call out scaling in Spatial.translate docstring

Add a note to make it clear that Spatial.translate is affected by the object's scale.

I think this needs more precision about what this implies. I'd leave an example in the description, something like:
For a given Spatialnode at position (0,0,0), that was scaled by 1000 on X axis, calling translate() will make theSpatial move by 1000 units on X axis, not only 1 unit.
func _ready():
	var spat = Spatial.new()
	add_child(spat)
	# Reset node position to origin
	spat.global_transform.origin = Vector2(0, 0, 0)
	# Scale the node by 1000 factor on X axis
	spat.global_scale(1000,0,0)
	# Translate the node by 1 unit on X axis
	spat.translate(Vector(1,0,0))
	print(spat.global_transform.origin) # prints (1000,0,0)
	# Translate the node by 1 unit on Y axis
	spat.translate(Vector(0,1,0))
	print(spat.global_transform.origin) # prints (1000,1,0)

Adding an example sounds good, but some style comments:

no need to add func _ready():. This code can be used in any method, so it can be provided as is without any function scope.
it should follow the GDScript style guide, so there should be a space after commas in Vector3(1000, 0, 0) etc.

@akien-mga Actually I wrote that code totally from memory. I guess I partially failed as it contains many mistakes (Vector, Vector2, Vector3 misuses), which I guess are corrected now.
But tbf, I didn't actually think about including this code snippet in the doc, but only the above precision. If you think the snippet is useful, I'm all for it! :D

I force pushed an updated docstring with a clearer sentence and an example.

Thanks!

Cherry-picked for 3.1.2.


[FEATURE] Show results above the search bar

Is your feature request related to a problem? Please describe.
I have a map where the top bar can expand or shrink. I've placed the geocoder widget in a fixed position that's usually beneath this bar, but it's quite awkward to use:

Describe the solution you'd like
I'd like a new option to render the results above the search bar. This would allow a better placement near the bottom of the screen. Skimming through the Svelte compnent, the ul would then appear above <div class="input-group">.
Describe alternatives you've considered
I've also thought about always placing the geocoding control directly beneath my app's top bar, but if it also jumped around as that bar expands/collapses, that might be disorienting.

I am not sure if I understand you correctly. Do you want an option to display dropdown menu above the search input box? Like this?

This should be achievable by adding the following style:
maplibregl-ctrl-geocoder ul {
  top: auto;
  bottom: calc(100% + 6px);
}

@dabreegster Hey, Dustin, thanks for reaching out!
If I understand correctly what you want to achieve, you can actually do it easily by calling
map.addControl(gc, "bottom-right");
It'll then add the control to the bottom corner and have the results displayed above the search box without any extra CSS work.
Let us know if it solved your issue so we can close this, thanks!

Hi both, thanks for the tips and sorry for the slow response! My current attempt is at https://github.com/acteng/atip/blob/nobuild_geocode_position/src/lib/common/Geocoder.svelte, following https://docs.maptiler.com/svelte/maplibre-gl-js/geocoding-control/.
I can't get the CSS override approach to work with the Svelte component, because nothing with the maplibregl-ctrl-geocoder class name gets created. It's a bit tricky to select the component in Firefox inspector (if you click the results element to focus in inspector, it closes the element), but you can see the class name is autogenerated by Svelte, due to how scoped CSS works:

map.addControl(gc, "bottom-right") isn't possible directly through the Svelte layer. I might try dropping down and using https://docs.maptiler.com/sdk-js/modules/geocoding/api/usage/maplibre-gl-js/ directly; the Svelte control adds indirection and I'm having some trouble tracing through how some of the config works.

@dabreegster I think in your use case, it'll be easier to add it as a control for the map. Maybe we should update the docs to make it more clear it's preferable.
@zdila Do you see any other use/benefit for the Geocoding as Svelte component apart from the use case when there's no map present or if one wants to position it outside of the map (let's say similar to https://www.maptiler.com/cloud/geocoding/ demo)

@dabreegster I see you already use div wrapped which you position with style. You can keep using this approach.
Or you can implement it as in https://github.com/maptiler/maptiler-geocoding-control/blob/main/examples/maptiler-sdk/AppMapTilerSdk.svelte
@petr-hajek Using it as a Svelte component directly in Svelte app may bring some optimizations, but they are negligible.

@dabreegster never mind my (deleted) comment, only now I had a look at your code
@zdila I believe what we are missing is an easy way how to define position when using createMapLibreGlMapController - something like in https://svelte-maplibre.vercel.app/examples/controls - possibly there will be more people using this library trying to add maptiler-geocoding-control as Svelte component


LoRA llama2-70b not giving any info when fine tuning

I am currently trying to fine tune a llama2-70b models, but scripts seems freezed.
!python lora.py --data datafn --model meta-llama/Llama-2-70b-chat-hf  --train --iters 2 --batch-size 4, I waited for almost two hours and nothing appeared on log. Do i need to wait more time?

Do i need to wait more time?

No it shouldn't take two hours to see some output. I'm guessing you don't have enough RAM so it's grinding the machine to a halt. I'm not even sure it's possible to fine tune non-quantized on an M2 Ultra, I haven't tried it tbh.
My recommendation is to do QLoRA, even so you still need a lot of RAM. You can try some of the following strategies to reduce the memory footprint or use a smaller model.


Add Script API for get_state/set_state of other EditorPlugins

Added two functions on EditorInterface to call set_state/get_state for other EditorPlugins. This allows the current state of the SpatialEditorPlugin to be manipulated by other EditorPlugins.
This is intended to be the basis for discussion to solve #26534

I think this is confusing and probably a more convoluted solution to what is needed

I am open to suggestions on how to interact with the respective editor
components. If desired I can also just expose an api for spatial editor
using classdb! It would certainly be more ergonomic to use.
Juan Linietsky<EMAIL_ADDRESS>schrieb am Do., 4. Apr. 2019,
22:31:

I think this is confusing and probably a more convoluted solution to what
is needed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/26535#issuecomment-480052167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABM_V4wL_lV3yDH0VhFuL6ZD0iCu8t_1ks5vdmEjgaJpZM4bbGHp
.

Needs a rebase to solve merge conflicts, and it would be great if you could add documentation for those methods (run godot --doctool . to generate the template to fill).

Needs a rebase to solve merge conflicts, and it would be great if you could add documentation for those methods (run godot --doctool . to generate the template to fill).

Ping @shartte.