X87 floating point assembly instructions not displaying quite right

When looking at x87 floating point instuctions (like FLD) Ghidra produces assembly like
   1000:0bc3 d9 84 16 1d  004           FLD        dword ptr [SI + e0to7]
instead of this original
FLD     FLOAT (e0to7 [si])
When looking into the ia.sinc file I found the code responsible is
# spec versions of the m8/m16/m32/... tables explicitly print the operand size
spec_m8: "byte ptr "^Mem     is Mem      { export *:1 Mem; }
spec_m16: "word ptr "^Mem    is Mem      { export *:2 Mem; }
spec_m32: "dword ptr "^Mem    is Mem      { export *:4 Mem; }
spec_m64: "qword ptr "^Mem    is Mem      { export *:8 Mem; }
spec_m80: "tword ptr "^Mem    is Mem      { export *:10 Mem; }

However, spec_m?? are also used in :MOV^xrelease specs so if I correct the spec_m??: lines above that would affect those :MOV^xrelease commands.
What's the best/correct solution?

I suspect that the MOV^xrelease operand could be changed to use the appropriate m? operand.  Some of the x87 instructions with integer operands (such as FIMUL) would also need to be updated.

I suspect that the MOV^xrelease operand could be changed to use the appropriate m? operand. Some of the x87 instructions with integer operands (such as FIMUL) would also need to be updated.

Can you give an example please as I don't understand the sleigh stuff, then I can do them all.  Thanks.


feat: improve telemetry for external system interactions

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

146 of 160 (91.25%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 75.273%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ext/datastore/bigquery/bigquery.go
21
35
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
6350

Relevant Lines:
8436

💛  - Coveralls


[crashtracker] Use common Endpoint to further decouple from profiler

What does this PR do?
Uses the ddcommon::Endpoint rather than the profiling-ffi::exporter::Endpoint.
Motivation
We're trying to decouple the crashtracker and the profiler, this removes one of the final remaining links.
Additional Notes
This is a breaking change for users of the API.
Eventually, the profiling-ffi endpoint type itself should probably be unified with this.
How to test the change?
Compile and run the modified example file.

Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.44%. Comparing base (a2cd10a) to head (de4bfb6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   70.45%   70.44%   -0.01%
==========================================
  Files         213      213
  Lines       28408    28412       +4
==========================================
  Hits        20014    20014
- Misses       8394     8398       +4

Components
Coverage Δ

crashtracker
25.21% <ø> (ø)

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
86.23% <0.00%> (-0.20%)
:arrow_down:

ddcommon-ffi
74.58% <0.00%> (-0.72%)
:arrow_down:

ddtelemetry
58.95% <ø> (ø)

ipc
84.13% <ø> (ø)

profiling
78.09% <0.00%> (ø)

profiling-ffi
56.76% <0.00%> (ø)

serverless
0.00% <ø> (ø)

sidecar
35.42% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
71.14% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
91.03% <ø> (ø)


Add support for using nearest .clang-tidy file.

.clang-tidy is a config file in YAML used by clang-tidy. If a codebase has proscribed clang-tidy settings, .clang-tidy can enforce them. It can be placed in multiple directories within a single project, and clang-tidy uses the nearest one, going parentward in the directory tree.
Also, I simply haven’t figured out how to do some things without the aid of the .clang-tidy file.
It would be extremely useful for my C++ linter plugin of choice to enforce the actual clang-tidy options relevant to the current project, instead of a universal set that may differ from what I need in a given situation.

After some experimentation, I found out that not setting g:ale_cpp_clangtidy_checks actually accomplishes this, but I still essentially want to be able to have a default set of checks. This might not make sense outside the context of a project (with its known includes, etc), so I’ll go ahead and close this issue.


:memo: Add dat-adi to the users

Added my site to the users.md, and fixed an alignment. Thank you for providing this masterpiece! :D

Thanks for using Congo, @dat-adi! I'll merge this change in and your site will appear on the public list when the next theme release is published.


Implement PPG

As discussed in sb3#346, I'd like to merge an existing implementation of the PPG algorithm.
I'm unsure about the two SDE-related calls here and here; I just oriented myself on PPO, calling it before the policy is used for its forward pass (sadly haven't gotten to read your nice paper yet ;) ).
Two other things worth pointing out:

I added a use_paper_parameters flag.
It's possible to initialize the policy weights the same way the paper did. I could put this behind a policy_kwarg and overwrite the init_weights method at runtime.

I also changed the line length to be PEP-compliant instead of having your desired line length of 127; I hope make format resets my changes.
Finally, I will put in some comments clearly separating the different phases in the algorithm.
Other than that, there are

[ ] documentation and
[ ] tests left to write, as well as
[ ] reproducing the paper.

I can't reproduce the paper results due to space issues on my laptop, sadly. Will see if I can get to it on the weekend; if it's not possible for me, I hope a helpful someone can finish this for me. I will at least provide a code baseline for this as well.

I'm unsure about the two SDE-related calls here and here; I just oriented myself on PPO, calling it before the policy is used for its forward pass (sadly haven't gotten to read your nice paper yet ;) ).

For now, let's try to have something without SDE.

It's possible to initialize the policy weights the same way the paper did. I could put this behind a policy_kwarg and overwrite the init_weights method at runtime.

I need to think about it and we need to see the results. Usually the best place to keep the tuned hyperparams is the RL Zoo.
btw, this
self.policy_kwargs["activation_fn"] = th.nn.Identity

is weird. But I guess, this is because you assume PPG is using a CNN policy?
Make sure to check the updated SB3 doc that explain feature extraction vs net arch: https://stable-baselines3.readthedocs.io/en/master/guide/custom_policy.html

I also changed the line length to be PEP-compliant instead of having your desired line length of 127; I hope make format resets my changes.

I'm not sure what you did. You should keep the max line length as it is, but yes make format will reformat your lines if needed.

I can't reproduce the paper results due to space issues on my laptop,

for the evaluation, we need obviously to compare to original results (I guess it was on CoinRun only) and then
I think it would be nice to have some results on classic control problem (simpler to run) and compare them to PPO.
I can also later run some experiments on pybullet/Atari envs.

For now, let's try to have something without SDE.

Sure, fine. :)

th.nn.Identity is weird. But I guess, this is because you assume PPG is using a CNN policy?

That's also part of the paper parameters, and they used an IMPALA encoder, so yeah, I guess that's the assumption.
What should I look out for in the docs regarding feature extraction vs net architecture?

I'm not sure what you did [regarding PEP compliancy].

That's a max line length of 79, just in case you were actually wondering. :D

for the evaluation, we need obviously to compare to original results (I guess it was on CoinRun only) and then
I think it would be nice to have some results on classic control problem (simpler to run) and compare them to PPO.

Sounds good to compare to PPO. The PPG paper used the whole Procgen suite.

I can also later run some experiments on pybullet/Atari envs.

That would be really great, thank you!

regarding the implementation, it would be better at first to have it inherit from OnPolicyAlgorithm rather than PPO

I absolutely understand why you'd want this; it was actually how I first programmed it as well. However, as PPG heavily reuses PPO, it just leads to a lot of copied code. As the code has already been used in practical experiments, outmatching PPO, I'd suggest keeping it the way it is for now. In case the reproduction experiments fail, we could still change the code to the more verbose version for debugging. What do you think?

I'm sorry this is taking so long again. For your comment about code duplication, I thought the issue is mostly that fixes and improvements to PPO will not be incorporated into PPG.

in fact, depending on how hard it is to reproduce results, I would first try to have results on simpler env (the classic control ones).

Sounds good.

I see, I think an Impala CNN feature extractor would be a nice addition.
So, when using CNN, by default, net_arch=[] (linear layer) which means you don't need to specify a different activation fn.

Ah, that's great! I'll remove that line, then.

Hey guys, cool stuff here! Maybe I've misunderstood but I'm not entirely sure this implementation of PPG matches what is described in the paper. Again correct me if I'm wrong, but I don't think n_epochs is the same as the N_pi parameter in the paper because n_epochs defines how many times to use the same samples for training whereas we want to train the policy N_pi times but each time with a fresh set of environment experiences (sample reuse hurts on-policy!). I'd argue the n_epochs variable instead represents E_pi in the paper, so in essence we're only performing one policy phase update per auxiliary phase (a.k.a N_pi=1).
I've also had a stab at an implementation, although admittedly I'm having some performance issues with the auxiliary value head in the auxiliary loss function for some reason (maybe something we can work on together if you agree with what I've said above?), hopefully it illustrates at least what I mean in principle though: https://github.com/09tangriro/brain-PUBLIC-VERSION/tree/dev/brain/ppg
Also made it so that the string 'MlpPolicy' can be used rather than 'AuxMlpPolicy' and extends OnPolicy rather than PPO, let me know your thoughts and again super cool work :)

Hey! Thank you so much for the review and bringing this issue up!
I absolutely agree with everything you said, n_epochs would be more suitable as E_pi = E_V (if we assume we don't create a new variable so they are controllable separately).
Since I haven't gotten any work into this since starting the first issue over a month back, would you like to take over as you have a working, correct (fingers crossed ;) ) implementation?

Yeah sure I can start working on a pr 👍

Yeah sure I can start working on a pr +1

PR to @janEbert fork or PR to SB3 contrib? (for the latter make sure to read the contributing guide carefully first)

I'll do it for sb3 contrib, I've given it a look over and for now I'll just create the feature branch until it's ready :)

Any progress on this algorithm?


Tensorflow 2,0 doesnot support tf.contrib sfft

the updated tensorflow 2.x does not support the ones in tf 1.15

Hi @patricphinehas ,
the contrib.signal module in TF1 has been integrated to TF2, so basically all stft functions should now be directly in tf.signal in TF2. Note that we haven't migrated yet.


How to know a resource is dependent or independent?

I think you are asking if something should be created in Initialize, in CreateDevice / CreateDeviceDependentResources, -or- CreateResources / CreateWindowSizeDependentResources in the directx-vs-templates?
Or do you mean something else?

Yes, that is exactly what I mean.


BlobContainerClientTest.BlobSasTest fails locally on Windows when running in VS test explorer.

https://github.com/Azure/azure-sdk-for-cpp/blob/09e174865ac6402d00020991a10e47ca1e1bafae/sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp#L81
BlobContainerClientTest.BlobSasTest
   Source: blob_sas_test.cpp line 11
   Duration: 2.1 sec

  Message:

    ..\..\..\sdk\storage\azure-storage-blobs\test\blob_sas_test.cpp(81): error: Expected: blobClient.AppendBlock(&blockContent) doesn't throw an exception.
      Actual: it throws.
    unknown file: error: C++ exception with description "403 This request is not authorized to perform this operation using this permission.
    This request is not authorized to perform this operation using this permission.
    RequestId:20c43c6d-801e-0060-6304-cedf86000000
    Tim.6649201Z
    Request ID: 20c43c6d-801e-0060-6304-cedf86000000" thrown in the test body.
  Stack Trace:
    20:18 line 18

cc @Jinming-Hu, @katmsft

This hasn't happened in the last one or two months. Reopen this if it happens again

@Jinming-Hu - this continues to fail locally in VS. Inactivity on the issue doesn't mean the problem went away. Did you re-try it yourself before closing?

It continues to fail in Visual Studio Test Explorer:

 BlobContainerClientTest.BlobSasTest
   Source: blob_sas_test.cpp line 14
   Duration: 6.7 sec

  Message:

    unknown file: error: C++ exception with description "403 This request is not authorized to perform this operation using this permission.
    This request is not authorized to perform this operation using this permission.
    RequestId:e4aff730-a01e-0058-7518-ff7b46000000
    Tim.1943041Z
    Request ID: e4aff730-a01e-0058-7518-ff7b46000000" thrown in the test body.
  Stack Trace:
    18:56 line 56

We refactored SAS-related test cases. Please open new issues for any questions.


Using FastHttpLocust gives a 'dict object

Describe the bug

Expected behavior

Actual behavior

Steps to reproduce

Environment settings

OS:
Python version:
Locust version:

I guess this worked itself out?

Hi @krishnakeshan I got the same issue. Do you mind to share the solution? Thanks

Hi @krishnakeshan I got the same issue. Do you mind to share the solution? Thanks

Could you share some specifics like your test plan and what the dict contains?

Hi @feizalasmoro, @cyberw, I had the same problem last week. Since this issue does not have any details in it, I was going to open a new one, but maybe its better to reopen this one instead.
Here are the details of what happened to me and how I solved the problem in my test:

After using transformer to generate a script and running a successful test with the default settings, I wanted to see the difference in performance when using FastHttpLocust. Unfortunately, a post request in my test was not working (for two different reasons, I'll detail them below), with this traceback:
[2020-04-17 18:54:04,093] localhost/ERROR/stderr: File "/home/iadmin/stresstests/locust/test2.py", line 19, in on_start
    self.client.post(path='/my-app/j_spring_security_check', name='/my-app/j_spring_security_check', timeout=30, allow_redirects=False, headers={'User-Agent': 'Locust-Request', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8', 'Accept-Language': 'en-US,en;q=0.5', 'Accept-Encoding': 'gzip, deflate', 'Content-Type': 'application/x-www-form-urlencoded', 'Content-Length': '73', 'Origin': '', 'DNT': '1', 'Connection': 'keep-alive', 'Upgrade-Insecure-Requests': '1'}, data={"j_username":username, "j_password":password, "desired_dashboard":"", "login_mode_embed":"false"} )
[2020-04-17 18:54:04,093] localhost/ERROR/stderr:
[2020-04-17 18:54:04,093] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/locust/contrib/fasthttp.py", line 228, in post
    return self.request("POST", path, data=data, **kwargs)
[2020-04-17 18:54:04,093] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/locust/contrib/fasthttp.py", line 170, in request
    response = self._send_request_safe_mode(method, url, payload=data, headers=headers, **kwargs)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/locust/contrib/fasthttp.py", line 116, in _send_request_safe_mode
    return self.client.urlopen(url, method=method, **kwargs)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/geventhttpclient/useragent.py", line 352, in urlopen
    last_error = self._handle_error(e, url=req.url)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/geventhttpclient/useragent.py", line 319, in _handle_error
    raise reraise(type(e), e, sys.exc_info()[2])
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/six.py", line 693, in reraise
    raise value
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/geventhttpclient/useragent.py", line 347, in urlopen
    resp = self._urlopen(req)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/locust/contrib/fasthttp.py", line 305, in _urlopen
    body=request.payload, headers=request.headers)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/geventhttpclient/client.py", line 236, in request
    sock.sendfile(body)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/gevent/_socket3.py", line 671, in sendfile
    return self._sendfile_use_send(file, offset, count)
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,094] localhost/ERROR/stderr: File "/home/iadmin/anaconda3/lib/python3.7/site-packages/gevent/_socket3.py", line 609, in _sendfile_use_send
    file_read = file.read
[2020-04-17 18:54:04,094] localhost/ERROR/stderr:
[2020-04-17 18:54:04,095] localhost/ERROR/stderr: AttributeError: 'dict' object has no attribute 'read'
[2020-04-17 18:54:04,095] localhost/ERROR/stderr:
[2020-04-17 18:54:04,095] localhost/ERROR/stderr: 2020-04-17T21:54:04Z
[2020-04-17 18:54:04,095] localhost/ERROR/stderr:
[2020-04-17 18:54:04,095] localhost/ERROR/stderr: <Greenlet at 0x7f1555b744d0: start_locust(<test2.WebsiteUser object at 0x7f1555b0d390>)> failed with AttributeError

What was really strange to me is that this issue only happened when I defined the header 'Content-Type': 'application/x-www-form-urlencoded'. Looking through the client code, I think this is the cause:
        if payload:
            # Adjust headers depending on payload content
            content_type = req_headers.get('content-type', None)
            if not content_type and isinstance(payload, dict):
                req_headers['content-type'] = "application/x-www-form-urlencoded; charset=utf-8"
                payload = urlencode(payload)

As we can see, if you do not define the content-type but pass a dict as payload (parameter data), the client urlencodes it. However, if you do set it beforehand, we get the AttributeError exception.
After encoding the body, however, I ran into the second cause of this issue (this affects GET requests as well): leaving the parameters timeout and allow_redirects from my original test in the requests. Looking through the code again, if you leave unrecognized named parameters in the request they are added as the request body:
    def urlopen(self, url, method='GET', response_codes=valid_response_codes,
                headers=None, payload=None, to_string=False, debug_stream=None, **kwargs):
        """ Open an URL, do retries and redirects and verify the status code
        """
        # POST or GET parameters can be passed in **kwargs
        if kwargs:
            if not payload:
                payload = kwargs
            elif isinstance(payload, dict):
                payload.update(kwargs)

After removing both parameters, my test worked as expected.
I'm not sure what is the best solution here, but I'd like to suggest two possible options:

Update the documentation, to be more precise about when you must urlencode the data parameter
urlencode the data parameter before calling self._send_request_safe_mode in fasthttp.py

Environment

OS: Ubuntu 18.04.4 LTS
Python version: 3.7.4
Locust version: 0.14.5
Locust command line that you ran: locust -f test2.py
Locust file contents (anonymized if necessary):

Yes. That was exactly what happen in my case. Sorry I haven't got the time to add all details.

IMO we should wrap geventhttpclient so that it gets the same behaviour as requests. If someone creates a PR to fix this, I am +1.
At the same time we might change it so that it automatically converts a dict type data parameter to json (which requests does). I was thinking about doing that when I added the json parameter (9a090163fcb748d577f9aa780c320fdcceb91246), but decided against it because I was lazy and didnt want to break anything :)

I seem to experience the same problem. In order to solve some other problem I followed these instructions, but I got an error
Traceback (most recent call last):
  File "src/gevent/greenlet.py", line 854, in gevent._gevent_cgreenlet.Greenlet.run
  File "/Users/adietz/Work/10_NSE/1.19_SSCX_Portal/dev/salpeter/locustfile.py", line 51, in <lambda>
    group.spawn(lambda: self.client.get(url, headers=headers, verify=False))
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/locust/contrib/fasthttp.py", line 245, in get
    return self.request("GET", path, **kwargs)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/locust/contrib/fasthttp.py", line 189, in request
    response = self._send_request_safe_mode(method, url, payload=data, headers=headers, **kwargs)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/locust/contrib/fasthttp.py", line 109, in _send_request_safe_mode
    return self.client.urlopen(url, method=method, **kwargs)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/geventhttpclient/useragent.py", line 359, in urlopen
    last_error = self._handle_error(e, url=req.url)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/geventhttpclient/useragent.py", line 326, in _handle_error
    raise reraise(type(e), e, sys.exc_info()[2])
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/six.py", line 703, in reraise
    raise value
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/geventhttpclient/useragent.py", line 354, in urlopen
    resp = self._urlopen(req)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/locust/contrib/fasthttp.py", line 402, in _urlopen
    resp = client.request(
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/geventhttpclient/client.py", line 236, in request
    sock.sendfile(body)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/gevent/_socket3.py", line 684, in sendfile
    return self._sendfile_use_send(file, offset, count)
  File "/Users/adietz/Envs/mac_1.19_salpeter/lib/python3.8/site-packages/gevent/_socket3.py", line 622, in _sendfile_use_send
    file_read = file.read
AttributeError: 'dict' object has no attribute 'read'
2020-12-04T06:55:32Z <Greenlet at 0x107ce76a0: <lambda>> failed with AttributeError

OS: MacOS 10.14.6
Python version: 3.8.6
Locust version: 1.4.1

fixed in geventhttpclient 2.0.1


Notifications when Engine is about to play

Provide a means for the engine developer to be notified (maybe email or text) when their engine is about to play or is starting to play.

What about a native browser notification?


Implement bootstrapping a new controller repository

Issue: aws-controllers-k8s/community/issues/1358
Description of changes:

This PR adds the initial implementation to bootstrap a new controller repository.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

There is a lot of duplication from code-generator. Let's do a fast follow-up after completing this issue to refactor common code inside aws-controllers-k8s/pkg repository.
It will be nice learning for you to refactor an existing code-base. :)

And think about adding some simple tests to the controller-bootstrap package.

There is a lot of duplication from code-generator. Let's do a fast follow-up after completing this issue to refactor common code inside aws-controllers-k8s/pkg repository.
It will be nice learning for you to refactor an existing code-base. :)

Yes, that would be great. Thank you!


RE4 auto disappear during REframework initializing

re2_framework_log.txt
RE4 game window auto disappear when REframework initializing, but its process still showing in process list, just with 0 CPU usage. so it is  not a crash.
I am using newest REframework for it.
Win 11 21H2
AMD 6800U
portable win device.

Pirated copies are not supported.
https://cursey.github.io/reframework-book/#help-my-pirated-copy-does-not-work


Server should have an auth timer

If someone tries to auth to the server, and fails 3 times, add an exponential timer on retries

a captcha field should appear if more than 3 times as well

shitty quick read on basics - https://wpforms.com/simple-tricks-to-eliminate-spam-user-registration/
reCaptcha by google - https://wpforms.com/how-to-add-recaptcha-in-wordpress-contact-forms/

Create a honey pot field for spammers
Check the blocked IP_Address table if more than 3 times wrong


INVALID vs invalid

The dataOpsScripts:  DBS3SetDatasetStatus.py and DBS3SetFileStatus.py accept status as INVALID that is what defined in DBS, however sometime user provides invalid instead. We should make the scripts to accept both cases.

Done. Now both VALID and valid or any combination will work, basically it case insensitive now.


Cargo doors not opening in turn around state

Hello,
I have a weird issue that my Cargo Doors wont open if I am in a turn around state.
This are my settings:

BR

Logs.
The Screenshot does not represent a Turn-Around.
Guesses: Either an Issue with the GSX Aircraft Profile (reset it under customize airplane) or the Combination of these Fenix2GSX Settings - it is rather unusual to use no Automation at all.

No further Feedback => Closed


Sort alphabetically or quick search in outline

From<EMAIL_ADDRESS>on 2011-09-22T10:08:21Z
Spyder Version:  2.1.0beta1
What steps will reproduce the problem?
With overly long contents in outline it is often hard to find the stuff. It will help to add button to sort A->Z and vice versa inside the dialog. On the second thought a search form accessible with keyboard shortcut maybe even more usable.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=766

From<EMAIL_ADDRESS>on 2011-12-09T06:53:16Z
issue #874 has been merged into this issue.

From<EMAIL_ADDRESS>on 2011-11-30T10:55:22Z
issue #840 has been merged into this issue.

From<EMAIL_ADDRESS>on 2011-12-09T07:07:00Z
Also, useful would be to have some shortcut-keys in order to expand/collapse the Trees to predefined levels (module, class etc).
WingIDE has a similar feature in the main editor (with code folding).

From pierre.raybaut on 2012-03-18T14:10:47Z
Labels: -Type-Enhancement Type-Enh

@techtonik I dont think this makes sense now that we have a Ctrl+P finder for the editor
@ccordoba12 closing?

Sure, closing.


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
abd981de096254aa451d84c5a847ffd015aaffaa
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Incorrect result from count query

OrientDB Version: 2.23
Java Version: 1.8.0
OS: freeBSD 10.3
I have encountered strange result during "count" query. Im not sure if this is actual bug or just my misunderstanding.
Expected behavior
count * and count rid should have equal number.
Actual behavior
These queries are in 2.2.23.
select count(@rid) from transactions  -  792743
select count(*) from transactions  -  1276958

I thought rid can never be null ?
I even check if there is any record that rid is NULL but there is none.
select * from transactions where @rid is NULL  -  nothing

Then I realized we just upgraded ordb from 2.2.4 to 2.2.23. So I went back to query in 2.2.4 if it works correctly.
select count(*) from transactions  -  1276958
select count(@rid) from transactions  -  810532

Notice count(rid) result from v2.2.4 is not even equal to result from v2.2.23.
--
Steps to reproduce
I don't know how this happen.

Hi @Bankde
First of all, @rid can never be null, so the results are supposed to be the same.
On the SQL executor there is an optimization so that select count(*) is calculated using a schema API, OClass.count(), while select count(@rid) is performed as a manual count. My guess is that you have some problems in the db (eg. wrong metadata on the class) but it's hard to say it without some debugging.
Do you think you can share a DB that has this problem? This will help a lot to find the root cause
Thanks
Luigi

We could share a DB. However the DB is 1G in size, which method of file transfer do you prefer ?
By the way, do you think we can continue using this database ? and could you suggest a way to hotfix a DB ?
Thanks

Hi @Bankde
If you could send a link with Dropbox or or GoogleDrive it would be awesome.
It's hard to say if the DB is corrupted and if it can be repaired, but we'll do what we can ;-)
Thanks
Luigi

Sure I will send you link when we're ready. It will take a while because database is not on my own computer.
I'm also concerned how could you access the database because we have password on it. Is there anyway to remove password from database ?

Ok we have found that one of our test database also has this issues, it is much smaller. (but still we don't know exactly what happen; thus we can't reproduce it)
Could you send me your mail address or any method that I can send you a link to GoogleDrive ?

Hi @Bankde
Please send it to l.dellaquila -at- orientdb.com
Thanks
Luigi

DB, log, along with more details sent.
Thank you.

Hi @Bankde
From what I see from the db, you have a problem with a cluster: the cluster metadata report the wrong size, but the data contained in it are correct.
The fix requires a little low-level modification of the cluster, there is no public API for this, so OrientDB team has to do a little change to the code to expose this functionality.
In the meantime, just for the record, did this problem happen on a single stand-alone node or are you running distributed?
Thanks
Luigi

HI, @Bankde are you absolutely sure that you did not have issues with the database before the update to 2.2.23? Before 2.2.15 versions we had a bug when some pages are only partially flushed, your issues looks exactly the same for the first glance?

It's single stand-alone node. I don't think my team ever touch any distribute feature.
You might want to see those logs too (e.g. orientdb.err). There are some of these errors:
- expression item 'userID' cannot be resolved because current record is NULL
- Error on execution of command (I have seen 2 error stacks: paginatedStorage and OSBTree)

I'm not sure if these are related issues, it would be nice for us to get more information whether data still behave correctly.
So far we have found more strange thing like this (you can try on that DB)
select * from (select expand(out()) from data where<EMAIL_ADDRESS>where<EMAIL_ADDRESS>
The above one returns 1 record.
However if I switch between two data, switch expand 'out' to 'in', this one returns 0 record.
select * from (select expand(in()) from data where<EMAIL_ADDRESS>where<EMAIL_ADDRESS>
@laa I couldn't say for sure. However, we did play 2.2.4 for a year and never have this kind of issues until we upgrade to 2.2.23 (unless those bugs were hidden in data, I don't know) then these happen to 2 different server within 1-2 weeks.

@laa I will check more with production team tomorrow. Hopefully I could give you more accurate on ordb version use when these issue occur.

@laa We have gone through logs and backups. I can assure that the data on one server (the one I sent database to you) is still ok after having already upgraded to v2.23 for almost a whole month. The chaos seems to start at 1 Sept. (orient-server.log.7 I have sent you)
Unfortunately another server is lacking log and backup so we can't confirm on that one.

@Bankde do you have a backup of the same database just before you update to 2.2.23 or just after you update to 2.2.23 but before the error happens. In other words most earlier backup with 2.2.23 and latest backup with 2.2.4? Could you send them to me to check data structure?

@laa  I will try to get the one suit your needs.
Do you want me to send link via orientdb mail or gmail ? If ordb mail, what's your address ?

@Bankde my email<EMAIL_ADDRESS>could you send DBs there?

DBs sent.
Don't hesitate to ask me if you need more information.

Any update on these issues ?

Hi, @Bankde I do not feel quite well, I will continue in the middle of this week, or earlier if things will get better. Sorry for the delay.

No problem. Thank for the update 👍
Wish you get well soon.

@Bankde could you while I am looking at your databases to do the following:

Take the latest 2.2.3 backup.
Replace your database with the latest 2.2.3 backup.
Run your tests on the server again.

I am really curious whether is it possible to reproduce this issue again?

@Bankde as additional precaution could you also run file system checks and disk SMART tests?

Ok.

@Bankde I also noticed that you have super small disk cache size 16 megabytes,  that probably causes concurrency issues in 2.2.23 . I am going to check that too on our benchmark server, but it is busy now with other tests. Once it will be free I will do it for sure.

@Bankde I am still investigating your issue though.

I'm not sure what you mean by small disk cache. Could you please point it out ?

@Bankde I mean following. In your logs I see OrientDB auto-config DISKCACHE=16MB (heap=989MB direct=524,288MB os=3,054MB)  so your disk cache size is only 16MB. We need to have enough cache to keep pages of all simultaneously running transactions. But probably in your case it may cause a problem. I will start long running tests next week to be sure. Did you replace again database by 2.2.3 backup but with 2.2.23 libraries, do you see any issues?

Already tried that for 2 days and no issue yet.
I didn't expect to encounter any issues though. It took us 3 weeks running 2.2.23 before we got this issue the first time.
By the way, could you suggest a proper value of DiskCache ?

@Bankde I think that 256M would be enough for you. But let's try to reproduce issue first if it will be possible.

@Bankde BTW did you check disks?

Already check before testing, 0 error found.

@Bankde I am still investigating your DBs what I actually noticed when I opened DB first is following:

Connecting to database [plocal:./cw_database] with user 'admin'...
2017-09-19 15:58:59:345 WARNI {db=cw_database} Storage 'cw_database' was not closed properly. Will try to recover from write ahead log... [OLocalPaginatedStorage]
2017-09-19 15:58:59:353 WARNI {db=cw_database} Record com.orientechnologies.orient.core.storage.impl.local.paginated.wal.OFuzzyCheckpointEndRecord{lsn=LSN{segment=2, position=93381418}} will be skipped during data restore [OLocalPaginatedStorage]
2017-09-19 15:58:59:354 WARNI {db=cw_database} Record OFuzzyCheckpointStartRecord{lsn=LSN{segment=2, position=93381425}} com.orientechnologies.orient.core.storage.impl.local.paginated.wal.OFuzzyCheckpointStartRecord{lsn=null, previousCheckpoint=LSN{segment=2, position=93381378}} will be skipped during data restore [OLocalPaginatedStorage]
2017-09-19 15:58:59:354 WARNI {db=cw_database} Record com.orientechnologies.orient.core.storage.impl.local.paginated.wal.OFuzzyCheckpointEndRecord{lsn=LSN{segment=2, position=93381465}} will be skipped during data restore [OLocalPaginatedStorage]
2017-09-19 15:58:59:354 WARNI {db=cw_database} Record OFuzzyCheckpointStartRecord{lsn=LSN{segment=2, position=93381472}} com.orientechnologies.orient.core.storage.impl.local.paginated.wal.OFuzzyCheckpointStartRecord{lsn=null, previousCheckpoint=LSN{segment=2, position=93381425}} will be skipped during data restore [OLocalPaginatedStorage]
2017-09-19 15:58:59:355 WARNI {db=cw_database} Record com.orientechnologies.orient.core.storage.impl.local.paginated.wal.OFuzzyCheckpointEndRecord{lsn=LSN{segment=2, position=93381512}} will be skipped during data restore [OLocalPaginatedStorage]OK

It seems like you copied database without stopping the server. Is it true?
Did you perform similar actions on a database located on your server just before those problems are started? Did you experience server crash may be?

Only time I can think of doing that is when I copied the database and sent to you (I might forgot that time, deeply sorry).

Other than that, we do vm snapshot but it saves a complete state of machine (means every process including ordb will still be running if you restore) so I don't think that's a case. The issues also occur on another non-vm machine (the one that lack of backup and snapshot since we don't do any actions like copying files; thus we can't confirm that issue happens after v2.23 on that machine. However, due to similarities of errors, we believe it's the same one) so I don't think running on vm is a cause either.

Server crash, as far as I can remember there's no blackout during that period. Do you think stopping ordb a hard way could also be a cause of this problem ? (e.g. shutdown the server (via command line), or kill -9 ordb when it doesn't stop after 30min, etc) I will go check more on these.

Hi, @Bankde, your issue is very strange, all previous backups completely normal but the last one which you sent to me is broken. Just in case if that is possible, could you send me broken database but after server shutdown, because if you just copy the database on the running server it will be completely broken does not matter are there any running transactions or not, and there will be no much use of it. So no much use to inspect it. For now, I consider two possibilities:

Very few disk cache size. I am running tests now it will take some time.
The server was killed/crashed but data restore did not go well, in such case I need to see a log of data restore.

I suppose for now we can assume that database was broken but would be really good to have the instance of the database which is copied after server shutdown.

because if you just copy the database on the running server it will be completely broken does not matter are there any running transactions or not
I think I did that to some of previous backup, good that they're still normal. Not sure of the latest one, I will see if I can still get that DBs and send to you soon.

Checked on another server that also has same issue but no backup, it has 2048 MB disk cache size. So disk cache might not be a cause.
2017-09-18 13:16:36:238 INFO  OrientDB auto-config DISKCACHE=2,048MB (heap=1,963MB direct=2,048MB os=8,086MB) [orientechnologies]
Personally I go with 2nd possibility. Gathering information on that right now.
What do you mean by log of data restore ? If it's orient log, I have sent you all (that's 1-2 days before issues occur) and those are all we have.

@Bankde could you send me logs from other sever too. Also, I am waiting for DB backup in a broken state.

Database sent.
Sorry, since we couldn't do anything more with existing data on that other server, my team has decided to purge those corrupted data, continue testing on new one and we don't have any backup / snapshot on that server, there is no log left.

Hi, @Bankde, I have run tests which updates records on 16 MB of disk cache and as I suppose you guessed tests passed without problems. Just in case I started them again, but they will run in the much longer interval of 2.5 days. I do not expect any problems though. As an additional experiment, I will create and fill data in the database under 2.2.4 version and then will run tests under 2.2.23 version. Maybe it will reveal some problems.  Also, I carefully investigated your database. I have the impression that part of the files was not flushed during the close. But if you look at the log, logging is stopped once server receives  SIGTERM signal. So even if some exceptions happen, we will never see them. I have fixed this problem and now even if the server receives  SIGTERM signal logging proceeds. I have two questions for you:

Could you update to 2.2.28 ASAP so if you have some problems during server shutdown, we will see them?
Did you have any new problems with database once we resolved all your previous issues related to SQL and you created a new database?

Might take a while, we normally have checklist test on new ordb version.
We haven't found any new problems yet. I have also tested on killing / crashing server and running old db from 2.2.4 in 2.2.23, all dbs still look fine.

@Bankde , good, it will be really helpful if we encounter this issue again if you perform version update. So I encourage you to do that.

@Bankde , I have run tests under the version of 2.2.24 on a database which was created under the version 2.2.3 , but as I suppose you guessed did not find any problems. Anyway if you still do not update to 2.2.28 version, I do suggest to update to version 2.2.29 because it contains fix of an issue critical for database consistency. I will leave the issue open for about a month and then will close it if you will not experience this problem anymore.

Haha, already upgraded to 2.2.28, can I proceed to 2.2.29 straight away ?
btw, the changelog is still drafted.
https://github.com/orientechnologies/orientdb/wiki/OrientDB-2.2-Release-Notes
I will keep you update if anything goes wrong.

Hi @Bankde
Yes, absolutely, I suggest you to upgrade to 2.2.29.
Sorry for the release notes, we had a bit of trouble during the release and just forgot to close it, now it's OK
Thanks
Luigi

Hi, few question here.
I have tried "CHECK DATABASE" on corrupted database from this issue and it returns
Check of storage completed in 200ms.  without errors.
Is there any other API to check database consistency ? How can I make sure that our production databases are still ok without having to rely on those count queries ?  (which probably still look ok even databases have gone corrupted right ?)
Thanks

@Bankde check database also should check database consistency if you use a distribution from an official site.  The output should be like following:
Scanning 8049 edges (skipEdges=0)...
Scanning edges completed
Scanning 809 vertices...
Scanning vertices completed
Check of graph 'plocal:../databases/GratefulDeadConcerts' completed in 0 secs
 scannedEdges.....: 8049
 edgesToRemove....: 0
 scannedVertices..: 809
 scannedLinks.....: 16098
 linksToRemove....: 0
 verticesToRepair.: 0

Checking storage.Check of storage is started...Check of storage completed in 23ms.  without errors.
Checking indexes.
Checking cluster ofunction  for index OFunction.name
cluster ofunction (6) |********************| 100%
Total errors found on indexes: 0

Just realized I called check database in 2.2.23 and it only checks for storage. Try again in 2.2.29 and it now works really well.
Thank you.

Close issue because it is not reproducible anymore.


settings_template.yml vs. baselines files

The baselines listed in settings_template.yml don't match the filenames in the baselines folder. I still think getting up and running is a bit confusing - and I'm a good guinea pig for that.
Is it the intention that if the filenames in the baselines folder change, then they should also change in settings_template.yml? The ps1 files like src\Private\Validation\Test-M365.1-1.1.ps1 also seem to have to match the baselines filenames. It feels a bit brittle to me.

@sympmarc Thanks for your contribution!
The filenames in the baselines folder don't match the references in the tenant settings file (settings_template.yml). As you've described, this could lead to confusion.
For now, there are two options to reference a baseline from the tenant settings file:

By referencing its filename (aka the "name" of the file without .yml suffix); e.g. M365.IAM.1-2.1
By referencing its id which is contained in the baseline; e.g. M365.1-2.1

It doesn't matter which option you choose.
But to make it clearer from an end user perspective, I think we should add this to the documentation here:
https://github.com/tmaestrini/easyGovernance#tenant-settings-file

@sympmarc My bad – you were right: the reference must match filename of the .yml file in the baselines folder (or wherever you set the reference to). Therefore, I've changed the definitions in the settings_template.yml.


BUG FIX: Multipart/form-data crashed if data was missing

Fix a crash in FormDataDecoderContext when the offset doesn't exist when parsing multipart form data ( vapor/vapor#2548 )

also moved over a test from vapor and removed a utility function that was unused

also moved over a test from vapor and removed a utility function that was unused

@JaapWijnen in order to revive multipart-kit properly we'd also need to update the README to bump the minimum Swift version and replace the Circle CI badge with the GH Actions one. Up to you if you want to include that in this PR or if you want to keep this one purely about the bug fix.

@JaapWijnen in order to revive multipart-kit properly we'd also need to update the README to bump the minimum Swift version and replace the Circle CI badge with the GH Actions one. Up to you if you want to include that in this PR or if you want to keep this one purely about the bug fix.

I'll try to add those later today, thanks for pointing out!

I'll try to add those later today, thanks for pointing out!

@siemensikkema All done! :) I've also updated the tools version and macOS requirements to match all vapor packages. I assumed we want to keep these uniform across all repos to minimize maintenance :) Let me know if you'd like to see anything different!

@siemensikkema All done! :) I've also updated the tools version and macOS requirements to match all vapor packages. I assumed we want to keep these uniform across all repos to minimize maintenance :) Let me know if you'd like to see anything different!

These changes are now available in 4.0.0-beta.2.1

These changes are now available in 4.0.0-beta.2.1


Overlay flashes in and out

The overlay flashes in and out when we hover or click on an element. This is due to us hiding the window in those cases to get the elements underneath, though we should try to find a less intrusive approach.

Fixed with commit aad85d8a30e78c57870fc5c46d74e00906a60749.


Basic documentation

Curious why this serve RL and how is this RL related to known RL framework e.g. SB3

This project is based on https://github.com/VowpalWabbit/vowpal_wabbit

Contextual Bandit algorithms
Logged Contextual Bandit Example

@rajan-chari
We now have 3 new people supporting TorchSharp, this provides opportunities to support RL for .NET that is beyond Bandit algorithms such as PPO.
Interested to get your views.
Always hope to have SB3 RL framework for .NET


Permit ingress to robots.txt for Asset Manager

This will allow the robots.txt file added in https://github.com/alphagov/govuk-helm-charts/pull/2462 to be visible.

Good catch - can you update integration and staging too?

Sure, have added it to all three environments now.


Could not load type 'Microsoft.SqlServer.Server.SqlContext' from assembly 'System.Data, Version=<IP_ADDRESS>

I am getting this exception when  i tried to restore the Data base using c# , .Net core2 and VS2017 preview2 ,
here is the sample code
SqlConnection sqlConnection = new SqlConnection(ConnectionString);
// Error on the line below
Microsoft.SqlServer.Management.Common.ServerConnection conn = new Microsoft.SqlServer.Management.Common.ServerConnection(sqlConnection);
but this is working in console application .  Did i miss anything ...
Thanks
Victor.A

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

This is a SMO issue and there is already a .NET Standard version (https://github.com/dotnet/SqlClient/issues/76#issuecomment-402709831). Closing this issue.

@shueybubbles & @David-Engel. I hear what you are saying that SMO already has a .NET Standard version. I'm not clear how to use Microsoft.Data.SqlClient with the SMO .NET Standard package. I'm still getting similar errors with my application that targets .NET Core 3.0.

We're not quite ready to push a public SMO package that changes its dependency from System.Data.SqlClient to Microsoft.Data.SqlClient. Once the kinks get worked out between SMO and M.D.S to fully support key apps like Azure Data Studio we'll make that version of NetStandard SMO available on nuget.org.


feature-card-image.html

assigned issue#112
screenshot:

@Rajdip019 now check is it ok.

@Rajdip019 check this one updated the image as you have described

Remove border @hritikbhattacharya

@Rajdip019 ok

@Rajdip019 now check.
screenshot after removing border:

@Rajdip019 now review the PR

LGTM.
Good job @hritikbhattacharya
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


ImageDecoderFixtureTest.ValidImageResultsInSuccess is flaky and causes tree-closures.

Sample failure at here. This seems to have failed only once in the past 200 runs.

I am going to land a low risk patch to get the tree going and then investigate de-flaking this.

I'm seeing something similar here, except the segfault is in ImageDecoderFixtureTest.ExifDataIsRespectedOnDecode:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8870622653939142288/+/steps/Host_Tests_for_host_debug_unopt/0/stdout

Just saw this again on Linux Host Engine release run of ui_unittests. Looks like Chinmay's above was profile.
Build: https://ci.chromium.org/p/flutter/builders/prod/Linux Host Engine/6839
Logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8869029216637469536/+/steps/Host_Tests_for_host_release/0/stdout

Let's track this one at the newer issue here: https://github.com/flutter/flutter/issues/80582


fix(kutt): add missing .auth level to postgres secret.yaml

Following the pattern in README.md for externalPostgresql and externalPostgresql:
https://github.com/christianknell/helm-charts/tree/main/charts/kutt#:~:text=externalPostgresql.auth.password
https://github.com/christianknell/helm-charts/tree/main/charts/kutt#:~:text=externalRedis.auth.password
https://github.com/christianknell/helm-charts/blame/5a9b896a800f4c8781645463639f60651878d4c3/charts/kutt/README.md#L56-L63

Thanks for your contribution @lucasfcnunes. Released with v3.2.4


[Test server] ConcurrentModificationException on Workflow.upsertSearchAttributes in tests

Expected Behavior
Workflow.upsertTypedSearchAttributes calls are successful in tests
Actual Behavior
    Caused by: java.util.ConcurrentModificationException: null
    	at java.base/java.util.HashMap.compute(HashMap.java:1317)
    	at io.temporal.internal.testservice.TestVisibilityStoreImpl.upsertSearchAttributesForExecution(TestVisibilityStoreImpl.java:97)
    	at io.temporal.internal.testservice.TestWorkflowMutableStateImpl.processUpsertWorkflowSearchAttributes(TestWorkflowMutableStateImpl.java:1542)
    	at io.temporal.internal.testservice.TestWorkflowMutableStateImpl.processCommand(TestWorkflowMutableStateImpl.java:686)
    	at io.temporal.internal.testservice.TestWorkflowMutableStateImpl.lambda$completeWorkflowTask$4(TestWorkflowMutableStateImpl.java:488)
    	at io.temporal.internal.testservice.TestWorkflowMutableStateImpl.update(TestWorkflowMutableStateImpl.java:317)
    	... 12 common frames omitted

Steps to Reproduce the Problem
See https://github.com/sfc-gh-pjagielski/temporal-playground/blob/main/src/main/kotlin/com/snowflake/HelloWorkflow.kt#L37
Failing build: https://github.com/sfc-gh-pjagielski/temporal-playground/actions/runs/5412424059/jobs/9836504936#step:5:837
Specifications

Version: 1.20

Thanks for the report. Note, the time-skipping test server (and therefore TestWorkflowExtension using default built-in test server) is not built to run multiple top-level workflows concurrently. Time skipping is applied globally. So if one workflow is waiting on an activity (which disables time-skipping so it runs in real time) but another workflow is expected to time-skip until timeout, the latter won't happen immediately.
@Quinn-With-Two-Ns and/or @mjameswh - while our test service isn't really built for concurrent top-level workflows, the map at https://github.com/temporalio/sdk-java/blob/57cb086f7df02c54e6952f46855eb9118c4b77ca/temporal-test-server/src/main/java/io/temporal/internal/testservice/TestVisibilityStoreImpl.java#L58 should be concurrent map because technically child workflows can run concurrently too. I guess this was just missed in #1067. It seems other non-thread-safe constructs are used in TestWorkflowMutableStateImpl but that is per workflow execution so none of that code will run concurrently, and TestWorkflowStoreImpl locks things it uses, so it's just this field in TestVisibilityStoreImpl we need to fix.

@cretz thanks for the analysis!
Currently we have some tests with concurrent workflows and this is the only issue that we're facing. Commenting out the code with upsertSearchAttributes helps, so I guess the change to ConcurrentHashMap should help


Add the sendHeartbeat method to the AbstractClient class

In a long running consumer I need to send the heartbeat frames periodically to prevent the client disconnection.

Hello Petr! There has already been similar PR - see #7. I don't think this is a good idea to expose such low-level protocol method in public API. Please set heartbeat option in constructor appropriately that you always finish blocking work within the specified interval. Heartbeat is mostly useful for keeping open connection that crosses loadbalancers or WAN. If you connect to RabbitMQ directly on LAN, you can set heartbeat in order of tens of minutes and everything should be fine.


Terraform registry?

Thanks for this nice terraform plugin.
 (I might be missing something obvious which makes that impossible, of course.)

there's usually a process to get added to the TF registry.
https://www.terraform.io/guides/terraform-provider-development-program.html
usually looks something like this:
https://github.com/microsoft/terraform-provider-azuredevops/issues/241

Hi guys, this is currently one of the new things supported in Terraform v0.13 Beta. I have also requested this feature for over a year and glad that it is finally being supported.
I am working on it and hope to have it ready once 0.13 is released. 👍

This is now resolved (see updated README and release) 👍


Remove additional pane whitespace on dash.

Can you elaborate on what this fixes? I saw no changes when applying this.

Before

After

Hmm, weird. This extension should remove the "Repositories you contribute to" box: https://github.com/sindresorhus/refined-github/blob/735933c01165e4f706b6a8193035928d59761e7b/extension/content.css#L14-L17
Any idea why it doesn't? Do you have other CSS selectors for it than me?

:)

Looks like we will want to always hide the js-notice

Looks like we will want to always hide the js-notice

Would you be able to do a PR on that? I don't have the notice, so hard to test...

Never mind. Doing it.


Replacing space with underscore in unsecure username

Impact:
In vttablet debug/vars
UserTableQueryCount: {
<#table_name>.unsecure_grpc_client.Execute: <#count>
}
Likewise in UserTableQueryTimesNs stats
Immediate Caller will have unsecure_grpc_client

You also have to change the test in test/encrypted_transport.py


fix: go.mod hook should overwrite existing line

Description
go.mod hook should overwrite existing line
Check the relevant boxes:

[x] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

Need to consider the use case where the module is not defined on the first line of the file (e.g. if there is a comment as the first line like we have seen).
Suggest doing a replace using regex maybe


Is there any method to provide the already executed replicas value of services like docker CLI "docker service ls"

Description
I have just used the spotify docker client to create services in a swarm. Everything is OK,  and I want to check the execution state of all services to verify if the services are finally executed. I know that spotify provide the method  listServices() to provide the information of all services, but it can not provide the already executed replicas numbers of a service, whicn can be provide in docker CLI "docker service ls".
For example, the below picture is the debug info in IDEA, which shows  one service infomation given by listServices() method. I can just know the expected replicas value.

And in the CLI, the result of  "docker service ls" command is shown below. Not only the expected value of replicas, but also the value in real state can be acquired.

How to reproduce
seen above
What do you expect
Is there any method to acquire the already executed replicas value of services?
I think the listTasks() method can be useful, but it is sophisticated to realize the same function.
What happened instead
Software:

docker version: docker 17.09
Spotify's docker-client version: 8.9.0

Full backtrace

Thanks.

There is no easy way to do this, sorry. But I can explain why.
When you call DockerClient.listServices(), that gets translated into a call to the Docker API. Docker sends back a JSON list of services, and docker-client binds those into java Services objects. Here is an example of the JSON that gets sent back from the API:
  {
    "ID": "za84hqdj0tvmskhc68q8yf7hk",
    "Version": {
      "Index": 54
    },
    "CreatedAt": "2017-10-31T15:49:46.658654787Z",
    "UpdatedAt": "2017-10-31T15:49:46.658654787Z",
    "Spec": {
      "Name": "suspicious_fermat",
      "Labels": {},
      "TaskTemplate": {
        "ContainerSpec": {
          "Image": "xnat/debug-command:latest",
          "Command": [
            "/bin/sh",
            "-c",
            "echo hello world > /output/out.txt"
          ],
          "Env": [
            "XNAT_USER=03dcbc11-21ee-489f-9eb6-ed796db23142",
            "XNAT_PASS=YPzaMZGyPiuk3mj11u3Blx72K9gozaXv4LkY1Y7dexZM43nbINPscdHZdMEKMRR3",
            "XNAT_HOST=http://xnat-31.xnat.org"
          ],
          "Mounts": [
            {
              "Type": "bind",
              "Source": "/data/xnat/archive/auto/arc001/5Yp0E/SCANS/801",
              "Target": "/input",
              "ReadOnly": true
            },
            {
              "Type": "bind",
              "Source": "/data/xnat/build/19f5bba1-7839-44a4-aef0-717fe8fb3650",
              "Target": "/output"
            }
          ]
        },
        "RestartPolicy": {
          "Condition": "none",
          "MaxAttempts": 0
        },
        "ForceUpdate": 0,
        "Runtime": "container"
      },
      "Mode": {
        "Replicated": {
          "Replicas": 1
        }
      },
      "EndpointSpec": {
        "Mode": "vip"
      }
    },
    "Endpoint": {
      "Spec": {}
    }
  }

You can see that JSON has properties Mode.Replicated.Replicas. This maps directly into the properties of the Service object that docker-client gives you. Docker doesn't return any more information than that. In order to get more information, you have to make more API calls.
Now, you rightly ask, "But doesn't the docker CLI give me more information in one command?" It does give you more in one command, but that one command wraps up several API calls. Take a look at the source code for the docker CLI to see what I mean.
This is the code that gets executed when you call docker service ls: https://github.com/docker/cli/blob/master/cli/command/service/list.go
This line is where it calls the /services API endpoint. (That's the same endpoint that docker-client calls when you do DockerClient.listServices().) But then it goes on to list all the Tasks and list all the Nodes, gathers the Task and Node information into a map, then passes that to a function GetServicesStatus. The job of that function is essentially to do nothing other than making that Replicas: x/y number that you see.
So, in the end, there is no way to use one API call to reproduce the behavior of docker service ls. Not even docker can do it in one; they have to use three! On the bright side, by looking at the source of the docker CLI, you can see exactly how they get the number of replicas and you can do the same thing.

@johnflavin Thanks a lot for your reply.

@johnflavin wow thanks for your detailed reply and help. @xiaohesdu it sounds like this answers your question. Can we close the issue?

yes, of course.


Suggested guidance update

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
CR files get corrupt if they are individually downloaded on browser.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Update the document to make sure download files in the repo in Zip or with Github Desktop to avoid CR corruptions
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/SAP/CR

Hi @takhoshi , thank you for flagging this. Apologies for the delayed response. If you still need assistance, please reply here within 5 business days.

Since we have not received a response in the last 5 days, we are closing your issue #<2425> as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation.


Have you ever tried segmentation to image？

Your work is very meaningful, but both your previous work (Controlnet,Adapter) and your concurrent work (Unicontrol,Uni-ControlNet) have attempted segmentation to image, which you did not mention in your paper. Have you ever tried segmentation to image?

Hello @guoqincode,
Sorry for the late reply.
We have used segmentation maps only for randomly masking the sketches, not for one of the input modalities. I believe DiffBlender can be easily extended to include the segmentation modality as well, and use the similar encoder network to that of sketch and depth map. If time allows, we will hopefully update our model to include the segmentation.
Thanks!

Thanks for your reply. If your training code is released, I can try to use more data to train segmentation to image


Errors when trying to run on MacOS Ventura 13.5 with Qt 6.5.1 and Cmake 3.27.3

First had to make one change as it was complaining of overlapping smcli:
diff --git a/smcli/CMakeLists.txt b/smcli/CMakeLists.txt
index c8b331a..d31a3cd 100644
--- a/smcli/CMakeLists.txt
+++ b/smcli/CMakeLists.txt
@@ -55,7 +55,7 @@ target_compile_options(smcli PRIVATE
     $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Wpedantic -Werror>
 )

-target_link_libraries(smcli Qt${QT_VERSION_MAJOR}::Core smcore)
+target_link_libraries(smcli PRIVATE Qt${QT_VERSION_MAJOR}::Core smcore)

It now would build in Qt Creator -- but when I try to run it in Qt Creator, get the following errors.  Help?
15:17:46: Running steps for project SourceMonitorOS...
15:17:46: Starting: "/opt/homebrew/Cellar/cmake/3.27.3/bin/cmake" --build /Users/pschlesinger/GitHub/build-SourceMonitorOS-Qt_6_5_1_6_5_1_2_temporary-Release --target all
[  2%] Building CXX object smcore/CMakeFiles/smcore.dir/archivereader.cpp.o
In file included from /Users/pschlesinger/GitHub/SourceMonitorOS/smcore/archivereader.cpp:23:
/Users/pschlesinger/GitHub/SourceMonitorOS/smcore/archivereader.h:66:17: error: unknown type name '__time32_t'
                __time32_t time_32;
                ^
/Users/pschlesinger/GitHub/SourceMonitorOS/smcore/archivereader.h:67:74: error: use of undeclared identifier '__time32_t'
                m_stream.read(reinterpret_cast<char *>(&time_32), sizeof(__time32_t));
                                                                         ^
/Users/pschlesinger/GitHub/SourceMonitorOS/smcore/archivereader.h:73:21: error: unknown type name '__time64_t'
                    __time64_t time_64;
                    ^
/Users/pschlesinger/GitHub/SourceMonitorOS/smcore/archivereader.h:74:78: error: use of undeclared identifier '__time64_t'
                    m_stream.read(reinterpret_cast<char *>(&time_64), sizeof(__time64_t));
                                                                             ^
4 errors generated.
make[2]: *** [smcore/CMakeFiles/smcore.dir/archivereader.cpp.o] Error 1
make[1]: *** [smcore/CMakeFiles/smcore.dir/all] Error 2
make: *** [all] Error 2
15:17:46: The process "/opt/homebrew/Cellar/cmake/3.27.3/bin/cmake" exited with code 2.
Error while building/deploying project SourceMonitorOS (kit: Qt 6.5.1 (6.5.1_2))
When executing step "Build"
15:17:46: Elapsed time: 00:01.

Hello @philCryoport , sorry for the delayed answer. Up to now the development is in a very early state. The focus is to get the software running on Windows again with MFC replacement. In consequence there is actual no Mac version available. If you are able to support, please join the team to get the code compiling on Mac.

Hello @philCryoport , sorry for the delayed answer. Up to now the development is in a very early state. The focus is to get the software running on Windows again with MFC replacement. In consequence there is actual no Mac version available. If you are able to support, please join the team to get the code compiling on Mac.

Roger that.  Alas, swamped.  Good luck to you!


Server Crash on Load

Minecraft v1.15.2
Forge v31.1.39
Chance Globe v1.3.3
The first time I loaded the server it loaded just fine, but after that the server crashes with each load.
Crash Report

Can you please post your latest.log?

Sure!
https://gist.github.com/WenXin20/f0d1151cf3e5898e04ea7e77f5f16ff0

Thanks! Please try out this version https://www.curseforge.com/minecraft/mc-mods/chance-globe/files/2927288

After a bit of testing, it still seems to crash after the 1st time loading: https://gist.github.com/WenXin20/8e3335d81efcb9cd2b18baa06364848a

Ok. I uploaded a new version, please try it out. While I do have an understanding of the crashes, this will basically go on like this as I can't reproduce them. https://www.curseforge.com/minecraft/mc-mods/chance-globe/files/2927939

This seems to be resolved.

Oh sorry, I've been pretty busy with school. But I'll let you know once I'm able to try it out.

Hello, apologies for not getting back on this! I'm now using v1.16.5 with forge v36.1.4, but I am still getting the exact same crash. But something that I have figured out is that the crash only happens after the config file is generated, deleting the config file fixes the crash temporarily. And then if I disable the blacklist in the config, the crash stops completely so far.

Can you post an updated crash report please?

Yep, here is is: https://gist.github.com/WenXin20/546807641635deb50577b21876c7d0f0#file-chance_globe_crash-txt-L44

Appreciate it! Updated the mod, third time's the charm? https://www.curseforge.com/minecraft/mc-mods/chance-globe/files/3283133

So far so good. :)


Fix deviations in corridor delineation

As pointed out in https://github.com/CityRiverSpaces/prototyping/pull/19#pullrequestreview-2344045578, we still need to find a solution to fix deviations from the optimal corridor boundary. What is optimal still needs to be defined more precisely.
A few possible approaches:

splitting the resulting corridor edges at nodes where the angle is above a threshold, running the shortest path algorithm between pairs of consecutive nodes bordering a split linestring and keeping the shortest linestrings;
using the coins algorithm to identify continuous lines running parallel with the river and "pulling back" the deviations to those main lines;
using angle deviations as pre-computed weights in the shortest path algorithm.

@fnattino, I had another idea about this: what if we run the same algorithm we used for corridor edge detection again and instead of wighting by the distance to the valley edge, we weight by the distance to the current edge. Depending on the weight, this might lead to an optimised edge in which deviations are removed.
If it works, this could be generalised into a recursive/iterative approach in which we try to converge towards an optimal solution in which the deviations go below a certain threshold (e.g., ratio between reference path length and optmisied path length converges to 1).
I am planning to try this out. Please let me know if you anticipate any issues with this approach.


Update data cube extension based on scientific schema

The json schema has changed based on the scientific schema and we need to check if this extension json schema needs to change as well.
related pr:
https://github.com/stac-extensions/scientific/pull/2

The "not" > "additionalProperties" > "not" (i.e. "contains") schema structure is coming from here: https://github.com/json-schema-org/json-schema-spec/issues/1077


Order/filter selectable columns

I was trying to order or filtered on the "checkbox" columns, to which I added two of my own to identify some components I have to order extra (this may not matter, Sourced and Placed have similar functionnality).
There is a "Mark when checked" option in the options menu, but that's not what I was looking for.  This highlights the components on the board.
When I click a "checkbox" column, all the content disappears, except the header.
What I expected was that the checkbox column would be ordered, ticked first or ticked last.  A small triangle in the header suggests that it would do so.
This may be related to #254, but the header column does disappear.
Tested with InteractiveHtmlBom v2.4 Chrome Version 94.0.4606.8.

Fix coming soon.


⚠ SkipTheTrailers has degraded performance

In 7cf59c3, SkipTheTrailers ($STT) experienced degraded performance:

HTTP code: 200
Response time: 1865 ms

Resolved: SkipTheTrailers performance has improved in 628bd3e.


[1.19.2] Incompatibility with certain mods

https://github.com/ItsThosea/BadOptimizations/blob/cf6c12acc56873a462ebd8682c4c368498eb3f60/common/src/main/java/me/thosea/badoptimizations/mixin/entitydata/MixinEntity.java#L89-L94
things like this auto-cancel
meaning mods which e.g. in this case make entities glow when the player has certain effects (or enchantments) (so it's visual only for that player, not a persistent state affecting all players) would no longer apply
(i know this can be avoided using the priority but that usually just stays at the default of 1000)
i did notice your default is 1200
i ran into some issues since i used RETURN to skip redundant logic

I'll try replacing the @Injects with @Redirects

that actually might be the wrong method for that kind of purpose, since at times it does update the glowing status on the server side
i switched to Minecraft#shouldEntityAppearGlowing

oh wait you saw that lmfao
Anyway, I think I might just remove those optimizations completely and use a faster array in DataTracker to compensate?

i meant my code / idea with "wrong method for that kind of purpose" btw
(i got an email about your comment though if you're curios)

i meant my code / idea with "wrong method for that kind of purpose" btw
(since whatever you return there can lead to server updates, so it's not fit for client-only logic)
(i got an email about your comment though if you're curios)

I mean there's always @WrapOperation from MixinExtras, basically @Redirect but conditional and stackable with other mods.

Fixed in 1.6.4, don't know when I'll release it tho, I still have some other bugs to fix.
I replaced each injector with @Overwrite since it stacks with @Inject and very few mods will @Redirect on the data tracker get call.


tls/x509utils/certpool: initial implementation of x509utils.CertPool

Summary by CodeRabbit

New Features

Introduced a CertPool for managing x509 certificates, with methods for adding, deleting, and retrieving certificates.
Added functionality to create a CertPool from environment variables.
Implemented system certificate pool management for loading CA certificates from the system.
Enhanced hashing capabilities for X.509 certificates using the Blake3 algorithm.
Introduced methods for exporting, copying, and cloning CertPool instances.
Added methods for retrieving certificate entries based on names and patterns.
Introduced error variables for improved error handling during certificate management.
Added support for managing system certificates on Linux systems.

Bug Fixes

Enhanced error handling during certificate loading and management.

Documentation

Improved documentation for new methods and functionalities in the certpool package.

Tests

Added unit tests for the SystemCertPool function to ensure correct behavior and logging of certificates.

as SystemRootPool() may contains non-CA certificates, CertPool.Export() won't filter them out. it's up to the user to sanitize the CertPool before Export() if wanted.

amended. see comments

@coderabbit full review

refactored CertPool so Copy() can now filter for CA-only results

fixed regression (unlocked access to List) on Certool.Delete()

introduced NewSystemCertPool(), returning always a fresh CertPool and the aggregated errors.

another iteration, hopefully the last

minor clean-up

<EMAIL_ADDRESS>tagged


feat: 🎸 Implement swagger UI documentation

Add and configure SwaggerUI in the API
Add docs explaining how to use Swagger UI

✅ Closes: #13

issue: our CI is not testing my test, its only doing the context loads.


specify an OSS licence

It would be nice, for users to know, what open source license covers this code, before they dive in.

It's been specified now to Apache


Fix stock allocator and add tests for it

Fix #649
Thanks to @m-sanders :)

Current coverage is 63.74% (diff: 100%)

Merging #683 into master will increase coverage by 0.11%

@@             master       #683   diff @@
==========================================
  Files            91         91
  Lines          4295       4295
  Methods           0          0
  Messages          0          0
  Branches        462        462
==========================================
+ Hits           2733       2738     +5
+ Misses         1468       1463     -5
  Partials         94         94

Powered by Codecov. Last update 0200322...1b2ea4c

Current coverage is 63.74% (diff: 100%)

Merging #683 into master will increase coverage by 0.11%

@@             master       #683   diff @@
==========================================
  Files            91         91
  Lines          4295       4295
  Methods           0          0
  Messages          0          0
  Branches        462        462
==========================================
+ Hits           2733       2738     +5
+ Misses         1468       1463     -5
  Partials         94         94

Powered by Codecov. Last update 0200322...1b2ea4c


bump up netty-all 4.1.42->4.1.73

address security complain and bump up netty-all dependency in carina-proxy module

done, changes should be available in 7.3.15-SNAPSHOT. To test run api_regression and api demo jobs.
they should be executed as early with the same state as in 7.2.14

Verified on develop branch, fixed.


Select value of an anyOf() property at random

The current implementation of anyOf() always only selects the first value
when generating a property. It means that other possible enum values are always
ignored when producing a value for the property.
This changes the behaviour so that the value is picked at random from any of
the provided values. It could be considered a breaking changes because of the
change of behaviour although it shouldn't be from the contract perspective.
Fixes #1424

Thanks @sguillope for the PR!


DOC-06-03-00 重新关联

原文地址

[ ] Why Test Controllers

[ ] Unit Testing

[ ] Integration Testing

#289 重新关联


Upgrade path from old template to new

I'm working on a project that has been using this template for quite a while, it's still using mocha instead of jest and is using the express server instead of webpack-dev-server. I'd like to update the project to be inline with this template, is there a recommended method of doing that, or is it just up to me to reconcile the differences and apply them?

There's no easy upgrade path yet -  we aim to solve this with vur-cli 3.
For now, the best way to go depends on the level of customization that you applied to the template.
Of you hardly changed anything, it's actually quite simple to roll out a fresh install of the template, copy all your source files and tests and replace everything in your original project directory with that.
Just make sure to adjust anything  you changed in  /config and /build afterwards.

alright thanks, I'm interested to see what changes vue-cli 3 will make. I ended up just going thru the main build files in each project and resolving differences. However it's rather tricky to manually remove the unneeded package.json devDeps


Add missing winerror feature

This PR fixes Cargo.toml that mentions winbase feature twice for winapi-rs but lacks winerror that prevents compilation with the latest winapi-rs 0.3.9.
error[E0432]: unresolved import `winapi::shared::winerror`
 --> C:\Users\pronebird\.cargo\registry\src\index.crates.io-6f17d22bba15001f\parity-tokio-ipc-0.9.0\src\win.rs:1:21
  |
1 | use winapi::shared::winerror::{ERROR_PIPE_BUSY, ERROR_SUCCESS};
  |                     ^^^^^^^^ could not find `winerror` in `shared`

:Bump:
Is there any chance of getting this merged and added in a release? If not this crate will break in any projects hoping to build for windows in the future. If this project is EoL or unmaintained that is fine I can look for something else to use in place of this.
@Xanewok not sure if you are the proper person to poke, but you have several of the most recent commits on this crate.


Can i replace the mindustry client download

So the default vanilla client has its fair share of "issues", so to speed up testing aspects, im willing to create a version of the game that imports some foos aspects, such as multithreaded server list loading so its less laggy, and other optimizations that would not cause issues with testing aspects using toxopid's runMindustryClient task.
Obviously the repo will be open source, and only contain the optimizations with the base vanilla game
Completely understandable if you decline and choose to keep it completely vanilla

If you wish to use foo's client for testing, modify the downloadMindustryClient task to download it instead of the vanilla client.
Add this at the bottom of the build script.
tasks.downloadMindustryClient {
    user.set("mindustry-antigrief")
    repo.set("mindustry-client-v7-builds")
    name.set("desktop.jar")
    version.set("1673")
}

Sorry for late response, did not see this


minor doc tweak

Fix wording in the upgrade docs

Thanks for the PR. Actually, while checking your changes, I noticed that the sentences you modified still have problems "... Unzip this file while within the modules/x/y/z directory of the WildFly distribution. " Would you mind fixing the remaining problems so that I merge your PR? (otherwise I'll simply close this and go and fix the stuff directly).


Move OCS error handlers to pkg

The OCS errors need a better implementation, because there is a difference between the OCS v1 Vs V2 http status code handling. We need to respond with different codes, depending on the endpoint. Tomorrow, I'll link to the to-do, which also references the ownCloud core implementation.

The TODO is right above the mapping code: https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/reqres.go#L117-L138
It is derived from https://github.com/owncloud/core/commit/bacf1603ffd53b7a5f73854d1d0ceb4ae545ce9f#diff-c1d6f3585e52926be0ec6169c0f58c38R442-R466
However, it is only necessary for the v2 endpoint.
This ties the mapping to the endpoint.
We can pass a boolean isV2 flag (shudder) or a mapper function as a new parameter (meh) which clutters up the handler signatures. In this case the context might be the right place. Then the ocs handler can store the error mapper function in the context and the error handler can check if the context has a mapper function. If you feel this does not make functionality obvious enough we could also store the mapper function or a preconfigure error handler in the handler when setting up the v1 and v2 handlers.
I am leaning towards adding a mapper function to the handlers. But maybe the OCM implementation has requirements that clarify how we should implement it.
opinions?

I am leaning towards adding a mapper function to the handlers. But maybe the OCM implementation has requirements that clarify how we should implement it.
opinions?

My two cents: Agree with the implementation details, but my point on an untied, abstract, cold interface definition that's not tied to the OCS API still stands. Do the OCM messages care about OCS meta statuses? Because this implementation requires just that. Or at least is not reflecting a more general approach

@ishank011 for time being we leave the OCS on one side and the OCM on other. These two services will evolve independently. OCS and OCDAV at some point will be moved to the OCIS repo while OCM will continue to live in Reva.

@labkode Okay, will close this and add a similar implementation for OCM. Thanks all for the reviews!


Upgrading uglify to 3.0.10

What kind of change does this PR introduce?
This changes updates uglify to v3 as requested by the Issue #4910
Did you add tests for your changes?
Since this is a module upgrade, no new tests are needed.
If relevant, link to documentation update:
NA
Summary
I wanted to contribute to webpack and took up Issue #4910 as a first step.
Does this PR introduce a breaking change?
It updates uglify-js module from 2.8.x to 3.0.10. So there shoudn;t be any breaking changes.
Other information
N/A

Closing this PR as uglify 3 has new api's
https://github.com/webpack-contrib/uglifyjs-webpack-plugin/issues/32


[s]int8 in structures throw not implemented exception

In this function a NotImplementedException is thrown when a structure contains a member of type int8_t. Noting that the rest of this library appears to support signed bytes; however, this one particular class in the C# frontend doesn't handle them in its' two static functions

@ReeceSX Seems like an oversight, I think we need to add the following line, along with a test:
                case PrimitiveType.Char:
+               case PrimitiveType.SChar:
                    signed = true;
                    return (targetInfo.CharWidth, targetInfo.CharAlign);

Do you wanna try sending a PR fixing this?
Re-reading this code, I'm thinking we might also have another bug here. Right now we just assume that char will always be signed, but I think that may not be the case with -funsigned-char.

I'm unable to work on this right; however, if it helps, the target toolchain was msvc. Perhaps there is some deviation between clangs internal ABI expectations based on the MSVCToolChain driver.

I had the same Problem with MSVC. Adding case PrimitiveType.SChar: fixed it for me.

We're running into the same issue with NuGet release 1.0.1.


Patient View: Medications tab missing

🐛 Bug Report
Medications tab is missing from the list of available tabs under the Patient view.
To Reproduce
On https://staging.hospitalrun.io/

Login and go to patients,
Select an existing patient to view or create a new one if no patients already exist, then view the patient
Notice there is no Medications tab

Expected behavior
Medications tab should exist between Notes and Labs tabs. This should show a list of all medications for this patient. See how the Labs tab works and use that as the basis for the Medications tab
Your Environment

node version: 6,8,10
fastify version: >=1.0.0
os: Mac, Windows, Linux
any other relevant information

I would like to work on this issue.

Sure thing @dev-script


ShallowWrapper performs deep equality check in pureComponentShouldComponentUpdate

Current behavior
ShallowWrapper uses lodash.isequal in the shouldComponentUpdate implementation. This is causing some minor discrepancy between React and Enzyme since _.isEqual performs a deep equality check whereas React, I believe, performs a shallow comparison on each member of the props/state objects.
I noticed this in a unit test when shallow rendering a PureComponent whose state uses ImmutableJS for some parts of it. In my unit test (and not in the actual web app), I was getting some unwanted warnings from ImmutableJS that were caused by the deep equality checks.
Also, I haven't really dived into the enzyme code prior to this, so apologies if I'm misunderstanding how ShallowWrapper works :)
Expected behavior
ShallowWrapper uses a shallow comparison as opposed to a deep comparison for its pureComponentShouldComponentUpdate check.
Your environment
API

[x] shallow
[ ] mount
[ ] render

Version

library
version

enzyme
3.7.0

react
16.6.0

react-dom
16.6.0

react-test-renderer
16.6.0

adapter (below)

Adapter

[x] enzyme-adapter-react-16
[ ] enzyme-adapter-react-16.3
[ ] enzyme-adapter-react-16.2
[ ] enzyme-adapter-react-16.1
[ ] enzyme-adapter-react-15
[ ] enzyme-adapter-react-15.4
[ ] enzyme-adapter-react-14
[ ] enzyme-adapter-react-13
[ ] enzyme-adapter-react-helper
[ ] others ( )

Thanks for the report - could you provide a reproducible test case?

@ljharb added a test case and also included the stack trace from my project's test output


Word motion grabs whitespace

The word motion w (and e, E and W) grabs adjoining whitespace, including newlines.
e.g. if the cursor is at the beginning of the word "foo":
yo
foo

bar

and the command cw is issued, the result is a reduction in the number of lines from 4 to 2:
yo
bar

with the cursor in front of the word "bar".
The expected result is:
yo

bar

with the cursor on the second line, and no change in the total number of lines.
This behaviour is consistent whether with d, c or y (which copies the empty lines)

Thanks for this one too. "cw" makes the "w" motion work like "iw" (inner word), excluding trailing whitespace. Regular "w" would include the whitespace. At least that's how it works in my mind. (:
There may be more combinations of "c" plus motion that need this change. Would be good to find docs somewhere that explain the mental model of the motions (including for visual select) and whether they have special interactions with certain commands.
Will be making a release with these changes now.

Thanks @mjl- - I've just tested and this seems to work exactly like I expect!
In testing this, I've noticed one thing which may or may not be related, but is a difference to vi/vim. Namely, that dd will not remove the final line in a piece of text - it just leaves an empty line in place.
dd on any line other than the final line works correctly though and removes the line entirely.
I can open another issue, though :)


Add missing test coverage

Test coverage is currently at ~48%. This is the minimum coverage needed for current development; however, ideally, we'd like to have 100% coverage.

Am i supposed to set these values according to me ISSUER_WEB5_PASSWORD=' ', ISSUER_WEB5_RECOVERY_PHRASE=' ' ?

@MuskanSaxena6 yes, you can set them manually in a .env or if you look at https://github.com/TBD54566975/incubation-dcx/blob/main/packages/issuer/src/config.ts you'll see the config object is looking for process.env.ISSUER_WEB5_PASSWORD and
process.env.ISSUER_WEB5_RECOVERY_PHRASE in the env or if null, coalesce to a function from the Mnemonic class to fill it.
Setting these vars in .env is more for BYO-Keys. If you don't have a pre-existing Agent DID recovery phrase and password, I recommend allowing the Mnemonic class auto-populating them or you can explicitly define them using that same class.

Am i supposed to set these values according to me: ISSUER_WEB5_PASSWORD=' ', ISSUER_WEB5_RECOVERY_PHRASE=' ' ?

@MuskanSaxena6 you can set them manually in a .env or if you look at issuer/src/config.ts you'll see the config object is looking for process.env.ISSUER_WEB5_PASSWORD and
process.env.ISSUER_WEB5_RECOVERY_PHRASE in the env or if null, coalesce to a function from the Mnemonic class to fill it. Setting these vars in .env is more for BYO-Keys. If you don't have a pre-existing Agent DID recovery phrase and password, I recommend allowing the Mnemonic class to auto-populate them. You can also use that same class to explicitly define those vars wherever you need them.
Recommendation
Because this is a test coverage issue, I recommend either letting the config.ts code handle the auto-population or importing Mnemonic and explicitly defining a new  ISSUER_WEB5_PASSWORD and ISSUER_WEB5_RECOVERY_PHRASE in the test case you're writing. If you look in the issuer/tests folder and specifically the issuer/tests/issuer.spec.ts test file, you'll find good starting points for understanding what has been setup already and where to go from here. Looking at issuer.spec.ts and config.spec.ts, you can see there's only 2 tests for the issuer package. Ideally, we'd have coverage for all the parts of the issuer package code + the applicant, common and server code bases.
Feel free to send me your questions in the TBD Discord channel for #dcx. I tend to not see GitHub comments as quickly.

@bnonni thanks a lot , you could have easily given me the answer in a single line but you explained it in such a detailed manner, I'm learning a lot!!

@bnonni I've tried to increase the test coverage but , I've failed to do the same,you can unassign me , so that others can help with this issue.Thank you got being so patient I learned a lot from working on this issue.


[json] schema Validation/Intellisense very slow when JSON deep and Schema Complex

In my project we design an API that allows people to define web pages in json using a bunch of nested components. We have schema files for all components and how to combine them. When merged into 1 schema file it becomes around 7000 lines long.
I am noticing a huge slowdown when a file has JSON that is relatively deep.
 Or just validate on file save? Could we show Intellisense suggestions before validation happens?
Also, when i am editing 2 JSON files the slowness is shared by the two. Even after closing the file that made everything slow, I still have to wait for some validation thing to finish before it realized the file is closed and updates the UI
If needed I can try to reproduce this bug with generic schema files.
What seems to be the issue is when i have a Collection component. This component can hold any other component, including more nested collections.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

@hipstersmoothie Any chance you can share the schema or a similar example?

@aeschli I will try to get a sharable example going tomorrow!

Thanks a lot for the example, and sorry for the wait.
It's an interesting example, and the our schema validation gets to its limits.
Each node can have have multiple alternatives. When testing which alternative to use we test the full object, including children and children's children. Each child type again has many alternatives.
To make this more performant we need to avoid validating children if we see that we are of the wrong type.

@aeschli is there any chance of progress on this? I don't have the experience to fix it myself but it's very impactful on us working with a similarly complex and recursive schema.
We have to fall back to regularly validating with ajv or similar while writing documents when vscode is no longer suitable.
We've even got 'fast' versions of the schema that don't validate certain parts of the file at all so we can stretch the intellisense further.
I've got an example for you here of the schema; homebrew.json is the base document, entry.json is the part that recurses.
https://github.com/TheGiddyLimit/5etools-utils/blob/master/schema/brew/entry.json
Here's an example of a document that slows to basically non-responsive during editing:
https://github.com/TheGiddyLimit/homebrew/blob/master/book/Darrington Press%3B Tal'Dorei Campaign Setting Reborn.json

@revilowaldow Sorry, there is currently no time budget for working on this.


Extractor return list of dicts (no more nesting in an object as "items")

Extractors' .extract() now return list of objects directly, without the {"items": [{}, {},...]} nesting.
This is obvisouly backwards incompatible, but it seems much more natural to simplify the API like this.

Codecov Report

Merging #36 into master will not impact coverage.

@@          Coverage Diff           @@
##           master     #36   +/-   ##
======================================
  Coverage    86.8%   86.8%
======================================
  Files           3       3
  Lines         235     235
  Branches       47      47
======================================
  Hits          204     204
  Misses         29      29
  Partials        2       2

Impacted Files
Coverage Δ

extruct/w3cmicrodata.py
98.98% <100%> (ø)
:white_check_mark:

extruct/jsonld.py
94.44% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f09455...625dd0e. Read the comment docs.


Cholesky: Fix misleading error message

The diagonals of the decomposed matrix were negative, which means the original matrix was not positive definite (even the the diagonal was positive).

I think this is a good change from the user perspective! @Andlon am I missing anything here?

Thanks for the PR @vks! Yes, I agree that the original error message is indeed misleading.
Note that the documentation for the method also needs to be updated as it has a similar wording as the original error message. Would you mind changing this as well @vks? In this case, we need to be a bit careful with how it is worded.
I see now that also the other documented error message is misleading, since it states that:

A diagonal entry is effectively zero to working precision.

As you pointed out, it is not the diagonal entry in the original matrix, but the diagonal entry in the decomposition which is being carried out. Perhaps just replace this by "The matrix is effectively singular to working precision"?


[backport] Simplify softmax with cuDNN

Backport of #5566

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 2060b74e1ed6d5f6c1fa2072900efb0a64a36cf6, target branch v5) succeeded!

LGTM!