Feature Request: add option to remove printing of control characters (--no-control-characters ?)

Bug Report (Feature Request)

TSLint version: 5.8.0
TypeScript version: 2.5.3
Running TSLint via: CLI (yarn)

TypeScript code being linted
// Not actually relevant?  Any code will do.  I will edit if it is deemed necessary.

with tslint.json configuration:
{
  "extends": [
    "tslint-config-standard",
    "tslint-immutable",
    "tslint-react"
  ],
  "rules": {
    "jsx-no-multiline-js": false,
    "jsx-boolean-value": false,
    "typedef": [ true, "call-signature" ],
    "no-consecutive-blank-lines": false,
    "no-let": true,
    "no-var-keyword": true
  }
}

Actual behavior
Depending on the terminal, the control characters print:
 RUNS  ...

 RUNS  ...

 RUNS  ...

 RUNS  ...
PASS src/renderer/foo.tsx

Expected behavior
With this option (--no-control-characters ?):
 RUNS  ...
PASS src/renderer/foo.tsx

What formatter are you using? This doesn't look like any of the core formatters.
What's your use case for not wanting any control characters in the output?

facepalm
Sorry, this is actually meant to be for jest.  I just always yarn lint && yarn test so I confused myself.


sigsci_site_templated_rule: interval value of 0 fails validation

Update sigsci_site_templated_rule resource documentation. Providing an interval of 0 fails API validation.
$ curl 'https://dashboard.signalsciences.net/api/v0/corps/example/sites/example/configuredtemplates/AWS-SSRF' \
  --data-raw '{"alertAdds":[{"action":"info","enabled":true,"interval":0,"skipNotifications":false,"longName":"AWS-SSRF-1-in-1","threshold":1}],"alertDeletes":[],"alertUpdates":[],"detectionAdds":[{"name":"AWS-SSRF","enabled":true,"fields":[]}],"detectionDeletes":[],"detectionUpdates":[]}'

{"message":"Validation failed"}

This should close #100.

Just kidding unfortunately. interval = 0 is just fine for action = "blockImmediate", which is undocumented.
$ curl 'https://dashboard.signalsciences.net/api/v0/corps/example/sites/example/configuredtemplates/AWS-SSRF' \
  --data-raw '{"alertAdds":[{"action":"blockImmediate","enabled":true,"interval":0,"skipNotifications":false,"longName":"","threshold":0}],"alertDeletes":[],"alertUpdates":[],"detectionAdds":[],"detectionDeletes":[],"detectionUpdates":[]}'

< HTTP/2 200


Update Stretchly to 1.11.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

I have manually made this update. Can you please check why the bot failed to find it?
Microsoft Reviewers: Open in CodeFlow

I get this prompt while installing, i'm investigating.

I get this prompt while installing, i'm investigating.

cc @auanasgheps: It's because "Microsoft Defender SmartScreen" (which is the blue prompt) has been removed from Windows Sandbox in Windows 11 which is most likely a side effect of ContainerOSPlus that Windows Sandbox uses in newer builds of Windows.
You can workaround it by running this in Windows PowerShell to disable Microsoft Defender SmartScreen:
if ($env:USERNAME -eq "WDAGUtilityAccount") {
    if (-not(Get-ItemProperty -Path HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer -Name SmartScreenEnabled)) {
        Set-ItemProperty -Path HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer -Name SmartScreenEnabled -Value Off -Force
    }
}

@ItzLevvie thank you!
If this is the case, the application installs normally without any user prompt.


[DOC-6963] Add docs about rolling back a self-hosted upgrade

[DOC-6963]
Previews
v22.1/upgrade-cockroach-version.md
v22.2/upgrade-cockroach-version.md
v23.1/upgrade-cockroach-version.md
Tests

[x] Local build
[x] Linkcheck

LGTM.


Add alerts for user PVC usage

/lgtm

Why the immediate merge :(

I was going to propose updating the evaluated true duration for the 90% data usage to be higher than 2 minutes.
And also updating the wording on the critical to remove "might want to" to "you should"


Update to use a global connection so we don't open tons of connection…

…s. Set to autocommit. have 5 retries so if the DB is locked it will retry

@rootedbox do we need all the extra requriements in the requirements.txt?

@rootedbox do we need all the extra requriements in the requirements.txt?

Yah the requirements.txt was not being kept up to date.. it's not like NPM where if you add a library it adds it your package.json.. you have to tell it explicitly to write to a file.


Adds Copy button to output panel

Fixes #27543. Adds a context menu to the Editor Log with "Copy" as an option. Could potentially add more, both "Clear" and "Select All" would be relevant (and simple to add on). Will update this PR if we decide to go that path.

I would just put a "Copy" button to the left of "Clear", there is no point in a context menu here.

Done! Removed the context menu and just added a "Copy" button next to "Clear".

Could you amend the commit log to reflect what it does now?

Cherry-picked for 3.1.2.

Not clear to me if we will have a "select all" option here.

@kielse The "select all" button hasn't been added yet, work is welcome in that area :slightly_smiling_face:


Feature Suggestion: Embed the ability for user to grade experience & provide that feedback to designer/bot owner

Use this query to search for the most popular feature requests.
Is your feature request related to a problem? Please describe.
Bots are (still) inherently bound to fail the conversation leading to the phenomena of the user trying to bail out & escalate to humans (operator, representative, '0'...).
Describe the solution you'd like
BF should provide the mechanism for developers to hook in end user feedback capabilities for specific "turn" to help dev/designers track and improve failed conversations.
Describe alternatives you've considered
There are at least two levels for capturing end-user sentiment:

A shortcut (side button) to escalate to human. Essentially a '0'/operator/representative button (or the text itself). This is the "nuclear option" leading to increased support costs. Bot developers may not want to permit that in all cases.
A softer feedback button ( e.g.  :) or ;(  ), In some cases the developer may desire to provide the user with the ability to grade the answer (with side UI, or during beta) & provide feedback to enable improvement on specific points in the conversation. The developer may hook additional actions to the poor experience such that a reset, or escalation (opt 1 above).

The proposal is to enable some metadata property bag in turn communications to enable hook up of grading button.
[enhancement]

This is a great feature, but it's out of scope for this SDK. This could be considered for the WebChat control, although even there this requires a SAAS service backend.


Add benchmarks

I was interested to see how this compared to a few of the other base32 libs out there, so ran some benchmarks. Sharing in case you want to add them to the repo.

Thanks!

For reference, I got this
# z32 encode 100 times
ok ~488 ms (0 s + 487680916 ns)

# z32 decode 100 times
ok ~368 ms (0 s + 368237875 ns)

# buf.toString('hex') 100 times
ok ~92 ms (0 s + 91695000 ns)

# Buffer.from(s, 'hex') 100 times
ok ~159 ms (0 s + 159276750 ns)

# base32 encode 100 times
ok ~748 ms (0 s + 748404834 ns)

# base32 decode 100 times
ok ~2.04 s (2 s + 35783542 ns)

# rfc4648.base32 encode 100 times
ok ~480 ms (0 s + 480188250 ns)

# rfc4648.base32 decode 100 times
ok ~1.22 s (1 s + 224891458 ns)

# base-x z-base-32 encode 100 times
ok ~6.09 s (6 s + 89891958 ns)

# base-x z-base-32 decode 100 times
ok ~8.11 s (8 s + 114600708 ns)

So seems quite fast

Yep, agreed! My results on an M2 Pro:
# z32 encode 100 times
ok ~490 ms (0 s + 490117333 ns)

# z32 decode 100 times
ok ~344 ms (0 s + 344101416 ns)

# buf.toString('hex') 100 times
ok ~122 ms (0 s + 121909125 ns)

# Buffer.from(s, 'hex') 100 times
ok ~181 ms (0 s + 181029166 ns)

# base32 encode 100 times
ok ~730 ms (0 s + 729948583 ns)

# base32 decode 100 times
ok ~2.09 s (2 s + 91318250 ns)

# rfc4648.base32 encode 100 times
ok ~489 ms (0 s + 489016834 ns)

# rfc4648.base32 decode 100 times
ok ~1.26 s (1 s + 263399458 ns)

# base-x z-base-32 encode 100 times
ok ~5.9 s (5 s + 895720417 ns)

# base-x z-base-32 decode 100 times
ok ~6.77 s (6 s + 773363167 ns)


Document the environment variables in the README

I'm developing a Nuxt application inside a Docker container with a TTY connection tailing the logs. The fancy progress bars on build do not always render correctly so I wanted to disable them.
I wound up doing it the hard way by overriding the progress bar plugins in the webpack config, see here.
I only learned after the fact that the minimalCLI (which Nuxt uses to determine basic or fancy progress bars in the CLI) has environment variables that can force certain modes (eg: MINIMAL=1).
It would be really good to document the environment variables in the README.

I love the idea of also generally document how each detection is working

Added JSDocs for v3 explaining each flag.


CS: introduces configurable limit before cook executor is no longer used

…to launch instances for a given job
Changes proposed in this PR

A configurable limit before cook executor is no longer used to run instances

Why are we making these changes?
As Cook Executor gains in stability and popularity, users no longer want the Mesos Executor to run their jobs. With this increased limit we will try to run jobs using Cook Executor and only fallback to the Mesos executor if we fail multiple times while trying to run the job using Cook executor.

Maybe we should never fall back to the mesos executor. As users start to depend on the features provided by the cook executor, maybe not having those features is as bad as the job failing.

We spoke offline. The plan is to release with this knob set at 5. If we see there are very few tasks using the Mesos executor, eventually we will remove support for this knob (in a follow-up PR) and run all jobs with the Cook Executor.

@dposada removed retry-limit from the configuration.adoc documentation.


Pop-up window "Ooops… We  could not capture all your beauty. Please try again" is displayed after saving profile photo

Pre-condition: User have wallet and logged in eWallet.
Steps:

Open the GoodDollar app
Go to the main screen page
Tap the mini photo of profile
Tap the editor icon
Tap the photo icon
Tap the place of photo
Choose the photo from device
Tap the Save button
Pay attention to the screen

Actual result: Pop-up window "Ooops… We  could not capture all your beauty. Please try again" is displayed after saving profile photo
Expected result: Pop-up window with an error does not open when uploading photos of acceptable sizes and resolution
Used devices:
iPhone XS // iOS 13.1.3
Environment:
eWallet ver. 0.10.6
Video: https://www.screencast.com/t/OJCm6ydEgG

@AnastasiiaOdnoshevna can this be reproduced?

@sirpy
It's not reproduced now.
I will check it on ewallet again after the release, to be sure. If everything will be ok, then issue can be closed

@AnastasiiaOdnoshevna this was on 10.6 we are already on 10.7 in ewallet

Doesn't reproduced on eWallet ver. 0.10.7
Device used:
iPhone X // 12.3.1
Xiaomi Redmi 7 // 9.0


Do not delete not activated users after 60 days

Short Description
We are incorrectly deleting not activated users too early (after 60 instead of 90 days). This checks if the users are active (we store an unlock code) and only deletes those.
Changes

Adapt the query
Adapt the tests

Feedback
I have changed the tests. We could also use freezegun and change the tests a little bit like that.
    def setUp(self):
        db.create_all()

        self.not_outdated_not_activated_idnr = "04452397687"
        not_activated_not_outdated_user = create_user(self.not_outdated_not_activated_idnr, '1985-01-01', '123')
        not_activated_not_outdated_user.last_modified = dt.date(2020, 6, 10)

        self.outdated_not_activated_idnr = "02293417683"
        outdated_not_activated_user = create_user(self.outdated_not_activated_idnr, '1985-01-01', '123')
        outdated_not_activated_user.last_modified = dt.date(2020, 6, 10)

        self.not_outdated_activated_idnr = "02259417680"
        not_outdated_activated_user = create_user(self.not_outdated_activated_idnr, '1985-01-01', '123')
        activate_user(self.not_outdated_activated_idnr, "UNLO-CKCO-DE07")
        not_outdated_activated_user.last_modified = dt.date(2020, 6, 11)

        self.outdated_activated_idnr = "06642573191"
        outdated_activated_user = create_user(self.outdated_activated_idnr, '1985-01-01', '123')
        activate_user(self.outdated_activated_idnr, "UNLO-CKCO-DE07")
        outdated_activated_user.last_modified = dt.date(2020, 6, 10)

    @freeze_time("2020-08-9")
    def test_if_less_than_60_days_since_last_modified_then_delete_no_user(self):
        _delete_inactive_users()
        self.assertTrue(user_exists(self.not_outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.not_outdated_activated_idnr))
        self.assertTrue(user_exists(self.outdated_activated_idnr))

    @freeze_time("2020-08-10")
    def test_if_more_than_60_days_since_last_modified_then_delete_only_activated_user(self):
        _delete_inactive_users()
        self.assertTrue(user_exists(self.not_outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.not_outdated_activated_idnr))
        self.assertFalse(user_exists(self.outdated_activated_idnr))

    def tearDown(self):
        db.drop_all()

I think the current tests show the different use cases better, but it is a little strange because we change the last_modified time instead of the system time. WDYT?

I agree that the current tests are easier to understand. Can we avoid touching last_modified directly, though? It has an onupdate on the column which these tests circumvent and I think the functionality is critical enough to test completely as a black box.
Something like this?
    def setUp(self):
        db.create_all()

        # 30 days before 2021-08-10
        with freeze_time("2021-07-11"):
            self.non_outdated_idnr = "04452397687"
            self.non_outdated_user = create_user(self.non_outdated_idnr, '1985-01-01', '123')

        # 61 days before 2021-08-10
        with freeze_time("2021-06-10"):
            self.outdated_not_activated_idnr = "02293417683"
            self.outdated_not_activated_user = create_user(self.outdated_not_activated_idnr, '1985-01-01', '123')
            self.outdated_activated_idnr = "02259417680"
            self.outdated_activated_user = create_user(self.outdated_activated_idnr, '1985-01-01', '123')
            activate_user(self.outdated_activated_idnr, "UNLO-CKCO-DE07")

    @freeze_time("2021-08-10")
    def test_if_activated_user_older_than_60_days_then_delete_user(self):
        with patch('app.elster_client.elster_client.send_unlock_code_revocation_with_elster') as revoke_fun:
            _delete_inactive_users()

        self.assertFalse(user_exists(self.outdated_activated_idnr))
        self.assertTrue(user_exists(self.outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.non_outdated_idnr))
        revoke_fun.assert_called_once()

    @freeze_time("2021-08-10")
    def test_if_not_activated_user_older_than_60_days_then_do_not_delete_user(self):
        _delete_inactive_users()
        self.assertTrue(user_exists(self.outdated_not_activated_idnr))
        self.assertTrue(user_exists(self.non_outdated_idnr))

    @freeze_time("2021-08-10")
    def test_if_user_newer_than_60_days_then_do_not_delete_user(self):
        _delete_inactive_users()
        self.assertTrue(user_exists(self.non_outdated_idnr))
        self.assertTrue(user_exists(self.outdated_not_activated_idnr))

    def tearDown(self):
        db.drop_all()

I've added a non_outdated_activated_user to make sure that we do not only delete the activated users


[Additional Parameter Request] Codeunit 17 Gen. Jnl. - Post Reverse - OnReverseCustLedgEntryOnBeforeInsertDtldCustLedgEntry

Hi Team,
In codeunit 17 we need possibility to have additional checks in the procedure ReverseCustLedgEntry. Standard publisher would suit us if it had additional parameter with boolean type IsHandled. OnReverseCustLedgEntryOnBeforeInsertDtldCustLedgEntry would be perfect solution:

[IntegrationEvent(false, false)]
local procedure OnReverseCustLedgEntryOnBeforeInsertDtldCustLedgEntry(var NewDtldCustLedgEntry: Record "Detailed Cust. Ledg. Entry"; DtldCustLedgEntry: Record "Detailed Cust. Ledg. Entry"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


fail at import

Sorry for this,  but I have a failure at import
Traceback (most recent call last):
  File "twitterStream.py", line 7, in <module>
    import tweepy
  File "/usr/local/lib/python3.7/site-packages/tweepy/__init__.py", line 17, in <module>
    from tweepy.streaming import Stream, StreamListener
  File "/usr/local/lib/python3.7/site-packages/tweepy/streaming.py", line 355
    def _start(self, async):
                         ^
SyntaxError: invalid syntax

$ python3 --version
Python 3.7.4

This is a duplicate of #1017 and was already fixed with #1042.
You're using an older version of Tweepy (<3.7.0) that doesn't support Python 3.7.
In the future, please make sure you're using the latest development version when reporting issues.


Error message not quite correct for Trivial/Opaque mistakes in extern types

If I modify the demo example along these lines:
unsafe impl ExternType for bindgen::BlobstoreClient {
    type Id = type_id!("org::blobstore::BlobstoreClient");
    type Kind = cxx::kind::Opaque; // no good!
}

mod bindgen {
    #[repr(C)]
    pub struct BlobstoreClient {
        a: u32,
    }
}

#[cxx::bridge(namespace = "org::blobstore")]
mod ffi {
    impl UniquePtr<BlobstoreClient> {}

    // C++ types and signatures exposed to Rust.
    unsafe extern "C++" {
        include!("demo/include/blobstore.h");

        type BlobstoreClient = super::bindgen::BlobstoreClient;

        fn update(blob: BlobstoreClient); // reason why the type needs to be Trivial
    }
}

Expected behavior:

Rust error message that cxx::Kind::Opaque is insufficient and the kind needs to be cxx::Kind::Trivial

Ideal behavior:

Rust error message that cxx::Kind::Opaque is insufficient, _with details from the TrivialReason saying why it needs to be Trivial

Actual behavior:

When building the demo, the C++ is built first, giving an error: error: static_assert failed due to requirement '::rust::IsRelocatable<org::blobstore::BlobstoreClient>::value' "type ::org::blobstore::BlobstoreClient marked as Trivial in Rust is not trivially move constructible and trivially destructible in C++"
We never see any Rust compilation or errors.

At the very least, this sentence is factually incorrect, because the type is not marked as Trivial. It needs to be trivial and that's what the error message should be saying.
At least in the cargo case the C++ will always be built first and I can't think of any way to get a nice error message pertaining to the Kind of the ExternType since that's entirely invisible to cxx::bridge and therefore to the generated C++. For other build systems, I guess it's 50/50 whether the user sees the Rust or C++ error message first.
Before I raise a small PR to fix the wording of the C++ error message, I wondered whether you had any cunning plans to squeeze out a better error message in these cases.
NB I have not tried the exact code I state above. I am encountering these symptoms for my WIP in #546.

Another thing in this area: where there are multiple TrivialReasons, we currently only store and output one. I'm inclined to make Types::required_trivial into a BTreeMap<&Ident, Vec<TrivialReason>> such that we can output all the reasons why a given type needs to be trivial, not just the first. Any objections?


200+ compiler warnings when building dspace-api with JDK 11

Describe the bug
Compiling 1213 source files to /app/dspace-api/target/classes results in more than 200 compiler warnings.
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/Context.java:[710,19] [deprecation] finalize() in Object has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/Context.java:[719,13] [deprecation] finalize() in Object has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/BitstreamFormat.java:[82,95] [deprecation] DELETE_ORPHAN in CascadeType has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/BitstreamFormat.java:[82,95] [deprecation] DELETE_ORPHAN in CascadeType has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/BitstreamFormat.java:[82,95] [deprecation] DELETE_ORPHAN in CascadeType has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/BitstreamFormat.java:[82,95] [deprecation] DELETE_ORPHAN in CascadeType has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/AbstractHibernateDAO.java:[313,24] [deprecation] finalize() in Object has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseUtils.java:[585,31] [deprecation] ignoreIgnoredMigrations(boolean) in FluentConfiguration has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/statistics/SolrLoggerServiceImpl.java:[192,16] [deprecation] post(DSpaceObject,HttpServletRequest,EPerson) in SolrLoggerService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/statistics/SolrLoggerServiceImpl.java:[1317,31] [deprecation] RemoteSolrException in HttpSolrClient has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/google/GoogleAsyncEventListener.java:[226,30] [deprecation] propagate(Throwable) in Throwables has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/curate/Curation.java:[195,29] [deprecation] NullOutputStream() in NullOutputStream has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[135,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[135,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[135,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[135,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[149,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[149,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[149,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/importer/external/metadatamapping/contributor/EpoIdMetadataContributor.java:[149,5] [deprecation] Required in org.springframework.beans.factory.annotation has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/RoleDisseminator.java:[487,31] [deprecation] findAll(Context,List<MetadataField>) in GroupService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/RoleDisseminator.java:[570,33] [deprecation] findAll(Context,int) in EPersonService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/AbstractMETSDisseminator.java:[1332,57] [deprecation] getLicenseTextBitstream(Item) in CreativeCommonsService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/DSpaceMETSDisseminator.java:[208,45] [deprecation] getLicenseTextBitstream(Item) in CreativeCommonsService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/identifier/EZIDIdentifierProvider.java:[266,22] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] /app/dspace-api/src/main/java/org/dspace/identifier/EZIDIdentifierProvider.java:[547,38] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/METSManifest.java:[268,29] [deprecation] SAXBuilder(boolean) in SAXBuilder has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/health/UserCheck.java:[42,51] [deprecation] findAll(Context,int) in EPersonService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/util/MultiFormatDateParser.java:[110,29] non-varargs call of varargs method with inexact argument type for last parameter;
  cast to Object for a varargs call
  cast to Object[] for a non-varargs call and to suppress this warning
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/bitstore/S3BitStoreService.java:[97,20] [deprecation] AmazonS3Client(AWSCredentials) in AmazonS3Client has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/bitstore/S3BitStoreService.java:[108,26] [deprecation] doesBucketExist(String) in AmazonS3 has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/bitstore/S3BitStoreService.java:[352,26] [deprecation] AmazonS3Client(AWSCredentials) in AmazonS3Client has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPersonCLITool.java:[454,48] [deprecation] findAll(Context,int) in EPersonService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[67,42] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[68,50] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[69,48] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[76,44] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[77,44] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[78,52] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[79,52] [deprecation] getTableName(int,boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[237,36] [deprecation] getTableName(boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/storage/rdbms/migration/V6_0_2016_01_26__DS_2188_Remove_DBMS_Browse_Tables.java:[238,36] [deprecation] getTableName(boolean,boolean,boolean,boolean) in BrowseIndex has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/authority/orcid/Orcidv3SolrAuthorityImpl.java:[175,52] [deprecation] encode(String) in URLEncoder has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/packager/DSpaceAIPDisseminator.java:[380,49] [deprecation] getLicenseTextBitstream(Item) in CreativeCommonsService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPersonServiceImpl.java:[182,25] [deprecation] findAll(Context,int) in EPersonService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/logic/TestLogicRunner.java:[64,39] [deprecation] PosixParser in org.apache.commons.cli has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/GroupServiceImpl.java:[418,23] [deprecation] findAll(Context,List<MetadataField>) in GroupService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/app/util/OptimizeSelectCollection.java:[64,49] [deprecation] findAll(Context,int) in EPersonService has been deprecated
[WARNING] /app/dspace-api/src/main/java/org/dspace/submit/migration/SubmissionFormsMigration.java:[158,53] [DefaultCharset] Implicit use of the platform default charset, which can result in differing behaviour between JVM executions or incorrect behavior if the encoding of the data source doesn't match expectations.
    (see https://errorprone.info/bugpattern/DefaultCharset)
  Did you mean 'byte[] strToBytes = dummyContent.getBytes(UTF_8);' or 'byte[] strToBytes = dummyContent.getBytes(Charset.defaultCharset());'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/scripts/DSpaceRunnable.java:[30,3] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/scripts/DSpaceRunnable.java:[66,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[552,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[553,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[564,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[565,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[578,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[579,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[590,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/service/AuthorizeService.java:[591,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/Context.java:[504,21] [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.
    (see https://errorprone.info/bugpattern/JdkObsolete)
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/Context.java:[610,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/Context.java:[707,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPerson.java:[388,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPerson.java:[403,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPerson.java:[417,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/eperson/EPerson.java:[444,19] [JavaUtilDate] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
    (see https://errorprone.info/bugpattern/JavaUtilDate)
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/DSpaceObject.java:[109,27] [JdkObsolete] StringBuffer performs synchronization that is usually unnecessary; prefer StringBuilder.
    (see https://errorprone.info/bugpattern/JdkObsolete)
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/DSpaceObject.java:[116,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns summary of event details, or null if there are none.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/DSpaceObjectLegacySupport.java:[20,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns the old integer based legacy identifier.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[396,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns database ID of subject of this event.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[403,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns database ID of object of this event, or -1 if none was set.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[410,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns type number (e.g. Constants.ITEM) of subject of this event.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[417,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns type number (e.g. Constants.ITEM) of object of this event, or -1'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[425,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns type of subject of this event as a String, e.g. for logging.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[437,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns type of object of this event as a String, e.g. for logging.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[469,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns event-type (i.e. action) this event, one of the masks like'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[515,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns timestamp at which event occurred, as a count of milliseconds'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[523,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns hashcode identifier of name of Dispatcher which first dispatched'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[531,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns value of detail element of the event.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[538,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns array of identifiers of this event's subject.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[546,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns value of transactionID element of the event.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/event/Event.java:[627,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns the set of consumers which have consumed this Event.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/DBConnection.java:[39,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns true if this session has an uncommitted transaction.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/DBConnection.java:[44,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns true if the session is open, false if it has been closed.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/DBConnection.java:[105,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/DBConnection.java:[131,29] [InvalidLink] `entity` is a parameter; use {@code paramName} to refer to parameters inline.
    (see https://errorprone.info/bugpattern/InvalidLink)
  Did you mean '* @param <E>    type of {@code entity}'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/core/DBConnection.java:[146,29] [InvalidLink] `entity` is a parameter; use {@code paramName} to refer to parameters inline.
    (see https://errorprone.info/bugpattern/InvalidLink)
  Did you mean '* @param <E>    Type of {@code entity}'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[136,27] [UndefinedEquals] Date does not have well-defined equals behavior.
    (see https://errorprone.info/bugpattern/UndefinedEquals)
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[139,27] [UndefinedEquals] Date does not have well-defined equals behavior.
    (see https://errorprone.info/bugpattern/UndefinedEquals)
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[166,86] [JavaUtilDate] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
    (see https://errorprone.info/bugpattern/JavaUtilDate)
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[167,82] [JavaUtilDate] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
    (see https://errorprone.info/bugpattern/JavaUtilDate)
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[200,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns get the action this policy authorizes.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/authorize/ResourcePolicy.java:[207,7] [MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)
  Did you mean '*Returns eperson, null if EPerson not set.'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/InProgressSubmission.java:[48,7] [InvalidThrows] The documented method doesn't actually throw this checked exception.
    (see https://errorprone.info/bugpattern/InvalidThrows)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/Item.java:[74,32] [JavaUtilDate] Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.
    (see https://errorprone.info/bugpattern/JavaUtilDate)
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/Item.java:[158,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/service/DSpaceObjectService.java:[310,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/Bitstream.java:[431,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/service/CollectionService.java:[331,7] [EmptyBlockTag] A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.
    (see https://google.github.io/styleguide/javaguide.html#s7.1.3-javadoc-block-tags)
  Did you mean '*'?
[WARNING] /app/dspace-api/src/main/java/org/dspace/content/service/CollectionService.java:[328,7] [MissingSummary] A summary line is required on public/protected Javadocs.
    (see https://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment)

To Reproduce
Steps to reproduce the behavior:

clone Git repo
checkout main branch
run mvn package

Expected behavior
No compiler warnings should occur.

Flagging as "help wanted".  These warnings can be safely ignored, and do not all come from the compiler.  Most of them are deprecation warnings (just reminding us that certain code is deprecated).  At the end are warnings generated by https://errorprone.info , which is a code analysis tool that helps us find areas of code to cleanup.
While I agree overall that it'd be nice to have fewer warnings, this likely will need to be broken down into several smaller PRs... trying to solve all at once would be difficult.  It's also not high priority right now as none of these are severe warnings, but it's a good area for someone new to the codebase to chip in by helping us work to minimize the warnings via code cleanup.


added default headers to constants

passing new parameter to Socket init
converting dict of headers into Headers object while connecting to ws with old client in websockets.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Socket class connects with default headers
What is the new behavior?
Adding custom headers into _connect method as new optional parameter in class
Additional context
Issue from link

thanks for picking this one up btw @doubledare704 ! I actually forgot that we can't send headers via the ws connection

@awalias then should we close this PR?

Hey @doubledare704,
Thanks for your contribution! Unfortunately, it seems like we have to close this for now since we can't send headers over websockets. We really appreciate the time and effort put into this PR though! We can close this for now if we find a workaround.
If you'd like some stickers do feel free to reach out to me on Discord(J0).
@dreinon @awalias feel free to chime in if you have any concerns/thoughts as well.
Thanks!
Joel


Provide CMake install target setup

Ever since we released the C++ SDK, having no cmake INSTALL is a common limitation people hit. Usecase examples:

Use with a different build system (see https://github.com/kyle-figure/bazel-minimal-rerun/blob/main/third_party/rerun/patches/cmake.patch)
Not having to build Rerun again from scratch for several rerun using applications on the same machine
Using it with your own library that uses install (https://discord.com/channels/1062300748202921994/1173517222010966047/1173517222010966047)
#4130

Tried cloning and running scripts/setup_dev.sh
It fails in scripts/setup.sh line rustup install 1.72.1
The script assumes rustup is available on my vanilla ubuntu 20.04, which is not the case.

@rishabh-slamcore This issue here is specifically about the C++ SDK distribution, not about building Rerun from the repository. For getting started with the repository check https://github.com/rerun-io/rerun/blob/main/BUILD.md#getting-started-with-the-repository - you first have to install rustup. The setup shell scripts aren't in a good shape generally, we gonna soon replace it with a full pixi setup, see

#4170

But worth noting you only need all of this when you want to build Rerun from the repository which is typically only when you want to modify something for a fork (with the goal of either experimenting, making personal enhancements or contributing) 🙂


proxy: send full data to agent

don't use pointers to structures in the data that is sent to the agent
fixes #207
Signed-off-by: Julio Montes<EMAIL_ADDRESS>

clearcontainers/proxy#196 was merged  and seems like this pr is not needed


Text upload fixes

Please check if the PR fulfills these requirements
[ X ] The commit message describes your change
[ X ] Tests for the changes have been added if possible (for bug fixes / features)
[ X ] Docs have been added / updated (for bug fixes / features)
[ X ] Changes are mentioned in the changelog (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a bugfix PR. We've seen several reports that the S3UploadFile feature where a string value was used to populate the S3 object was working incorrectly. This PR fixes the errors that were introduced, and updates the precondition checks that were not working properly.

What is the current behavior? (You can also link to an open issue here)
https://github.com/jenkinsci/pipeline-aws-plugin/issues/196
https://github.com/jenkinsci/pipeline-aws-plugin/pull/168

What is the new behavior (if this is a feature change)?
As suggested by @webark in https://github.com/jenkinsci/pipeline-aws-plugin/pull/168, the localPath variable was replaced with the path variable. Additionally, I added and updated some of the precondition checks to confirm that one and only one of the parameters (text, file, includePathPattern) were provided.

Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
This is a non-breaking change, just fixing a previously broken featureset. No updates to documentation are required.

Other information:

LGTM @tylersouthwick any objections?


Building on iOS fails

This is the return from Xcode.
Header 'permission_handler-Swift.h' not found

@paulomelo this it not really a bug in the plug-in, bit more a shortcoming in the way Flutter handles Swift. The Flutter team is hard at work on solving this issue.
In the meantime you can implement a simple workaround by adding a few lines of code to you iOS podfile. More information can be found here: Flutter#16049

@paulomelo this it not really a bug in the plug-in, bit more a shortcoming in the way Flutter handles Swift. The Flutter team is hard at work on solving this issue.
In the meantime you can implement a simple workaround by adding a few lines of code to you iOS podfile. More information can be found here: Flutter#16049


Report relevant semantic errors for JS files

Today semantic errors are ignored for JS files. That include errors for labels, some strict mode checks, invalid call expressions, unknown modules, etc.. We will need to go through all the semantic errors and expose ones that are applicable to JS. we can also consider changing the diagnostic message level to be warning instead of an error.

Isn't this covered by #6802?

my bad. closing.


[SR-3896] Add missing r-value coercion for type(of:)'s argument

When this was migrated over to the awesome new special representation
of type(of:) the argument coercion didn’t come with it.  The missing
load expression caused any l-value run through type(of:) to crash in the
verifier.
@jckarter, how does it look?

@swift-ci please smoke test.

@swift-ci please smoke test

Nice catch! Does withoutActuallyEscaping need the same thing?

Is there a way to take a non-escaping closure parameter as an l-value?  The only permitted operation is a call.

Do we check that before or after normal type-checking? We still don't want to crash if you write var g = f; withoutActuallyEscaping(g) { ... }


modules: lvgl: Fix coordinate handling for invert-{x,y} and swap-xy

This patch fixes two issue in the coordinate handling of the zephyr,lvgl-pointer-input compatible:

If the swap-xy flag is set the coordinates need to be swapped even before the sync event is received.
If the invert-{x,y} property is set the coordinates should only be inverted when the state is pressed. This is because the pointer saves the coordinates of a previous press event and upon release event it reuses them, causing the inversion to be applied twice.

Resolves issue #70539.

Yes I think this is good, can you squash the commits?

ping @fabiobaltieri I did the rebase :^)

@faxe1008 hey just noticed you left the squased commit comment in the commit message, wanna clean that up? I'll try to not miss the notification and reapprove immediately this time :-)

This breaks the adafruit_2_8_tft_touch_v2 shield.
Touch presses are now rotated 180 degrees (top-left is bottom right, etc.)

This breaks the adafruit_2_8_tft_touch_v2 shield.
Touch presses are now rotated 180 degrees (top-left is bottom right, etc.)

Scrolling to find this comment after I made mine on the same ;) But yes, .. probably good to have the touch test sample in https://github.com/zephyrproject-rtos/zephyr/pull/67508


Visualizer Effects

Add visualizer effects that respond to the music's beat and frequency, enhancing the visual experience.
The effects can be added to the background of the app.
Difficulty: Advanced

please assign this to me


Update README.md

I just added some lines to README.md file to improve the repository's readability.

Added installation of Rust and Solana CLI.
Updated some bash lines.

@tavakyan @dlin128 could you please review the PR? It is sitting here for 2 months. Thanks.

Thanks for your contribution! We made a major refactor which is why we hadn't accepted this yet. Please feel free to try the new version and port your improvements there.
We just merged our new version to main.


Add a parameter to configure label locale in asciichart library

Add a parameter to configure label locale in asciichart library
https://mtnsat.atlassian.net/browse/AG-629

This PR was merged to master by mistake. It is not part of the access-gateway branch (master has been reverted by force-pushing it).


Add Custom Lint Check

[ ] Add Custom Lint check to exclude Compose previews from Jacoc coverage report

Useful Links:
https://medium.com/@parthgupta48/writing-custom-lint-checks-in-android-6a7c2c090efa#:~:text=To include this lint rule,all upstream modules as well.


pythonPackages.z3c_checkversions: init at 1.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python37Packages.z3c-checkversions python27Packages.z3c-checkversions python35Packages.z3c-checkversions python36Packages.z3c-checkversions

Thanks, looks prefect. Can you squash the commits?


Bump version to 0.13.2.dev0

After the patch release of PEFT v0.13.1, let's bump the dev version of PEFT to v0.13.2.dev0 so that it stays ahead (the bugfix from the patch release is already contained in the main branch).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Advice on creating adaptor for use with ADFS/Azure via simplesamlphp

Hi,
Our parent institution is centralized on ADFS (and soon to be Azure) authentication and I have some experience with a custom web app where I've used simpleSAMLphp. I'm hoping that I might be able to leverage your work to add ADFS as an option to this plugin.  Do you have any advice on whether and how to proceed?
Thank you,
Ian

Hello Ian,
I did attempt to write the plugin in such a way that other auth methods could be added. Omeka is based on Zend Framework 1, and different types can be added to that framework's Zend_Auth package through the use of Adapter classes.
Omeka itself provides a Login Adapter Filter for plugins where you can return which Adapter should be used to authenticate a user. This filter only authenticates but does not handle existing sessions or logging out. So I found it only usable for a LdapAdapter just for authenticating the initial login.
For the CasAdapter, I ended up extending Omeka's UserController to more fully utilize the Zend_Auth adapters. The _getAdapter() method in that class is where the plugin obtains the correct adapter based on the settings.
You'll likely want to make an adapter similar to the CasAdapter but with your own backend. It's been a few years, but I remember the biggest issue I had was dealing with PHP's session mechanism. Omeka sets up items in the session before any auth happens, but one of the CAS libraries I was working with would always clear the entire session upon instantiation. I ultimately went with a different library to avoid that issue. I am not familiar enough with the simpleSAMLphp project to know if this may be an issue for you.
Feel free to post again or otherwise contact me if you have any questions, and good luck with your project. I'll be happy to add anything you come up with to this plugin.

Thank you, John. The information you provide is super helpful and apologies for not responding sooner. I'm just starting to look into adding an adaptor. I'll close this issue and open a new one if I run into specific roadblocks.


Fixed snapshot testing for CI

Summary
Due to recent changes to the binder snapshot test file structure the snapshot tests were not actually getting run by CI. This PR adds the missing  __init__.py files that should make the tests in new subdirectories discoverable

It looks like you need to add seaborn to the requirements list here: https://github.com/Qiskit/qiskit-terra/blob/main/azure-pipelines.yml#L816 since the new state visualization tests need it to generate the colormap. That being said it might be better to just delete that line and replace https://github.com/Qiskit/qiskit-terra/blob/main/azure-pipelines.yml#L815 with pip install -U -c constraints.txt -e ".[visualization]" to ensure we install all the visualization dependencies.

Note: the merge of #6807 means that the line Matthew's talking about is now in a slightly different place:
https://github.com/Qiskit/qiskit-terra/blob/4ce11d89efeeee905636ad9c7bcacbd67d2d9075/azure-pipelines.yml#L249-L251


go/printer: blank lines at top/bottom of composite literal handled differently by gofmt

Searched and didn't find a duplicate issue.
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
play.golang.org
What did you do?
var x = []int{

	1,
	2,
	3,

}

https://play.golang.org/p/xDO9L4ROUA (press the format button)
What did you expect to see?
Either both blank lines in the composite literal removed, or neither of them removed.
What did you see instead?
The bottom blank line is removed, but not the top.

The typical answer to gofmt bug reports is to relax and accept whatever gofmt gives you, but I'll let @griesemer decide. This might be a dup of #6996.

Ah, could be. I searched for composite literals specifically, but it could be a more general block issue.

See also #18264. Leaving open for now.

Closing due to no activity.


cmd/compile: misleading error message when using type parameter in typeset

What version of Go are you using (go version)?

devel go1.18-c8861432b8 Sun Jan 2 14:27:43 2022 +0000

What did you do?
type X[T any] interface {
	T | string
}

https://go.dev/play/p/v-8zaOs_d3r?v=gotip
What did you expect to see?
"cannot use type parameter in typeset"
What did you see instead?
"cannot embed a type parameter"

This is specified in https://tip.golang.org/ref/spec#Interface_types

In a union, a term cannot be a type parameter ...

@griesemer per owners.
Personally I think "cannot use type parameter in typeset" is perfectly clear as it is.

Just to be clear (@thanm ), the current error message is: cannot embed a type parameter.
cc: @findleyr for suggestions.

I'm not sure if the word(s) 'type set' (or typeset) are appropriate here, since it refers to the entire type set of the interface type.  Maybe "cannot use a type parameter in a union", which is the phrasing currently used in the spec.

...though it may also be confusing that *T is valid here, as in
type X[T any] interface {
	*T | string
}

Maybe union terms cannot be type parameters is sufficiently specific.

Some off-topic, should the "union" be replaced with "intersection"? int | string means allowing the operations which are legal for both int and string, instead of for either int or string.

int | string means that both int and string are in the type set of the interface.  More generally T1 | T2 means that the union of the type sets of T1 and T2 are in the type set of the interface.  So union is the correct term.
It's true that because an operation is supported if it is supported by all types in the type set, one can view operations as going by the intersection.  But from a type set perspective it is definitely a union operator.
See #45346.


no-mergable-selectors should not raise warning with @-blocks or mixins

Currently the no-mergable-selectors is very aggressive at trying to merge selectors, going so far as to claim that items within @media and mixins blocks must be moved into each selector. For instance it raises warnings when writing:
.item {
  width: 100%;
}

.item__inner {
  width: 75%;
}

@media (min-width: 50em) {
  .item {
    width: 50%;
  }

  .item__inner {
    width: 50%;
  }
}

As it prefers merging those .item and .item__inner selectors, suggesting that you should write it like:
.item {
  width: 100%;

  @media (min-width: 50em) {
    width: 50%;
  }
}

.item__inner {
  width: 75%;

  @media (min-width: 50em) {
    width: 50%;
  }
}

In my opinion the first example is just as valid, and is how I prefer to write my scss, as I find logically grouping by viewport size makes more sense. I actually use a mixin for outputting my media queries so replacing the @media blocks with @includes should also not raise warnings.
To reproduce this, add the following to the bottom of no-mergable-selectors.scss:
// make sure a selector inside a media query is not marked as mergable
@media (min-width: 50em) {
  h1 {
    padding: 0;
  }
}

// make sure a selector inside a supports query is not marked as mergable
@supports (display: flex) {
  h1 {
    display: flex;
  }
}

// make sure a selector inside a mixin is not marked as mergable
@include mq($min: 50em) {
  h1 {
    border: 0;
  }
}

I would expect this to raise no additional linting errors.

Hmm, i'm not sure. I feel like the first example is a bad way of writing media queries. The second example is much clearer and easier to follow from a developer experience point of view. Having a block defined once with all contexts contained within is much clearer than duplicating your selectors within a media query context.
Technically it is a duplicated selector, it's still targeting the same element but under a certain context. I'm open to discussion here though. I think it's probably another case where we may have become a little too stylistic in our reach..

The second example is much clearer and easier to follow from a developer experience point of view. Having a block defined once with all contexts contained within is much clearer than duplicating your selectors within a media query context.

I disagree with this. Where there are many selectors and contexts, I find having single contexts and duplicated selectors easier to grok that the alternative. This is because mostly I tend to care about sets of selectors as related to each other, and I mostly think about understanding an overview of all items within a given context, rather than focusing in on a single element and thinking "what does this selector look like in all contexts".
But this discussion isn't about convincing each other on which nesting style is better :) They're both equally valid in my opinion. I think scss-lint is being too heavy handed currently as it is saying "The way you write media queries in native CSS is bad and must be changed". This feels very hostile to people who are comfortable writing CSS but are new to Sass. Forcing people to use Sass features sounds too opinionated for my liking.
I do appreciate that "use root level @ blocks" or "use nested @ blocks" is a stylistic choice within a codebase and sass-lint should allow users to choose one of those options, but I think that choice is distinct from the no-mergable-selectors rule.
How about this...
The notion of "mergable selectors" should take into account the context (i.e. @media, @supports or mixin) they are written in. Both of my examples in the original issue should be valid when used in isolation when only the no-mergable-selectors rule is enabled. However if those two styles are mixed and matched sass-lint should raise a warning. e.g.
.item {
  width: 100%;

 @media (min-width: 50em) {
    background-color: red;
  }
}

@media (min-width: 50em) {
  .item {
    width: 50%;
  }

should emit a warning stating that the two ".item when the viewport width is >=50em" rules should be merged.
In addition to that there can be a new rule, something like root-level-conditional-groups (as the spec claims they're called with an option called style, that would allow the user to choose if they want to force these blocks to only exist within a selector (your preferred style), or if they should always exist at the root.
In that world, personally I would enable no-mergable-selectors, but disable root-level-conditional-groups as I want to catch cases like .foo { color:red; } .foo { background-color: blue; }, but believe there are valid use cases for both styles of conditional group nesting within my codebase.

Yeah I agree, that's one thing I really want to avoid with sass-lint is it becoming too opinionated. It should be a tool to help everyone enforce their own opinions! :smile:
Our whole mindset with sass-lint is for small single purpose rules so it's definitely the right approach to split these ideas up. If you'd like to create a separate issue for the new rule proposal so it doesn't get lost here then that would be appreciated.
As for enhancing the no-mergeable-selectors rule I'll look into it hopefully for 1.4.0

Had to change my styles because of this. My two cents. I didn't feel my old code was wrong even thought the no-mergeable-selectorssays so. See the point about reducing selectors ("column" in this example). Agree with @BPScott that forcing users of this rule to nest queries is very opinionated. Maybe an option to ignore @media and @include is sufficient? In the end I had no real problems with having to change my code after understanding what it wanted.
Old
@media all and (min-width: 600px) {
    %column {
        float: left;
    }
}

%column {
    padding-right: 1rem;
    padding-left: 1rem;
}

New
%column {
    padding-right: 1rem;
    padding-left: 1rem;

    @media all and (min-width: 600px) {
        float: left;
    }
}

in regards to the technically a duplicated selector, this bourbon keyframes mixin also throws, which shouldn't be merged at all:
@include keyframes(fade-in) {
	0% {
		opacity: 0;
	}

	100% {
		opacity: 1;
	}
}

@include keyframes(fade-out) {
	0% {
		opacity: 1;
	}

	100% {
		opacity: 0;
	}
}

With the following sort of error:
  12:5   warning  Rule `0` should be merged with the rule on line 2    no-mergeable-selectors
  32:5   warning  Rule `100` should be merged with the rule on line 6  no-mergeable-selectors

Thanks @intellix yeah, I'm currently redoing this rule to take into account all mixins. It will warn you if a selector can be merged within a mixin but wont attempt to warn you across mixins as I think we open up a whole can of worms there, maybe something for the future though.
Hoping to have this sorted soon but I've just not had the time in the past few days to work on this.

@DanPurdy that's awesome that you're taking mixins into account; in addition we also would like to consolidate all styling within a specific media query, so we would also like at least the option to disable the behavior of suggesting merging media queries into other selectors (as @BPScott also describes). Please don't close this task until that behavior is also implemented, or at least a follow-up issue is created. ;) Thanks for the awesome work! :)

+1 for this.
Just had the same warning for:
@keyframes Before {
  50% {
    transform: rotate(0deg);
  }

  100% {
    transform: rotate(45deg);
  }
}

@keyframes After {
  50% {
    transform: rotate(0deg);
  }

  100% {
    transform: rotate(-45deg);
  }
}

+1 for same use case as @danimalweb

I am aslo following the approach described by @BPScott and I think that element can be duplicated in different @-blocks. So for now no-mergeable-selectors rule is useless for me.
Would be nice to have an option to allow duplication over different @-blocks.

Hi @eugef I actually meant to label this as a bug after our discussion above. It should be doing what it does but I just haven't had the time recently to get round to fixing it :cry: soon though!

So I'm handling this with the rule re write for the 1.6 release and the gonzales 3.2.x update. It'll still be look in every node but should be so aggressive with what it tries to merge. I'm sure with feedback we can fine tune it to a level that suits everyone.

@BPScott @alfaproject @eugef @danimalweb @intellix I've just tested all your examples again with the new mergeable selectors rule I added to 1.6.0 and they all work as discussed! I'll close this issue but if you find anything else then please raise another issue and enjoy 1.6!


does cython support template class? (not template type)

i know cython can use "fused" to define template types.
but how to use template class, for example, the ".h" file is as below, C1 and C2 are classes, not types.
template<class C1, class C2>
void queryInterface(C1& c, C2 iid) {
pointer_type p;
if (!c.queryInterface(iid, (void**)&p))
reset(p);
}

how to wrap it in ".pxd" file?
thx!

See http://cython.readthedocs.io/en/latest/src/userguide/wrapping_CPlusPlus.html#templates . If you have further questions, user support is provided at<EMAIL_ADDRESS>the issue tracker is used for tracking issues (bugs and feature requests).


feat: add creating HelmRepository type sources

This change introduces providers which can handle a specific resource type and create a specific Source object type based on the type that each individual provider supports. The provider pattern is handy in here to avoid having to use switch cases. Rather any given provider can handle a specific type and if not, it will call the next provider in a chain of providers until one is reached that can either handle the type or any type.
If no more providers are found it will error and return that the given type cannot be handled.

Oh and I need to add unit tests ofc

Testing the flow with https://github.com/Skarlso/ocm-helm:
Annotations:  delivery.ocm.software/content-type: helmChart

So far so good... Let's see a localization...


modular js?

create worker: new Worker("worker.mjs", { type: "module" });
remove "use strict";
make sure bytebeats aren't running in strict mode
preload workers: <link rel="modulepreload" href="worker.mjs">
load script: <script type="module" async src="main.mjs"></script>
not sure if this is an improvement and how good the support is

done


[Typo/Bug] Insane GCI

This is bad:

It needs to go ASAP.

what is a GCI?

what is a GCI?

Loosely, a subclass axiom where there is an anonymous expression (not a named class) on both sides.

Or anonymous class expression on left, named on right

In this case anonymous class expression on left is 'in taxon' some 'Homo Sapiens'.
So all things that are 'in taxon' some 'Homo Sapiens' (where things might include 'anatomical structures', 'biological processes'. ...) have all of the properties on the right - - plasma membrane part endoglin; are capable_of 'neuron differentiation'. etc.
I'm rather surprised it didn't break a whole load of builds.  Might have got through because we don't use 'in taxon' some 'Homo sapiens' much outside of CL.

I don't know anything about the origin of this CGI.  I have never used CGIs in my ontology work.

@addiehl  - wasn't suggesting you added it.  Can you look at the right hand side to see if it looks familiar?  I suspect the left hand side should have been some class you worked on.
(BTW  - you may not be aware of it, but you've added many GCIs to CL: mixing subClassOf and equivalence axioms on a single class produces hidden GCIs.  e.g. if you made a term equivalentTo: 'in Taxon' some 'Homo Sapiens' and added the subClassOf restriction on the right, you would have added a hidden GCI equivalent to the above)


win 10 按照报错

系统：win 10 x64
ruby：ruby 2.5.0p0 (2017-12-25 revision 61468) [x64-mingw32]
gem：2.7.5
执行bundle install的时候报错了，下面是报错信息

D:\app-host>gem sources -u
source cache successfully updated

D:\app-host>bundle install
Your Gemfile lists the gem paranoia (~> 2.2) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of one of them later.
Fetching gem metadata from https://gems.ruby-china.org/.........
Fetching gem metadata from https://gems.ruby-china.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "ruby ":
  In Gemfile:
    ruby  (~> <IP_ADDRESS>)

    capybara (~> 2.13) was resolved to 2.14.4, which depends on
      nokogiri (>= 1.3.3) was resolved to 1.8.0, which depends on
        ruby  (< 2.5) x64-mingw32

Could not find gem 'ruby  (< 2.5)', which is required by gem 'nokogiri (>=
1.3.3)', in any of the relevant sources:
  the local ruby installation

非常抱歉，没测试条件，所以没法维护 window 环境。
建议你用 linux 系统或者 docker 版本


Chore: Tag often-used models

Tagging these models will allow us to more easily and implicitly handle discrimination when using these models in unions.

@znicholasbrown couple ts errors popped up from adding these. Couple mocks (do we even need mocks anymore?) and one around artifacts, which is an interesting one that might influence this decision.

Yeah @pleek91 we probably don't need mocks anymore tbh but it's pretty easy to update those so I've opted to do that instead; cleaned up the artifact kinds as well so this should be g2g


New CLI tool docs and conversion to RST

FYI the formatting will look better on Sphinx as compared to the GitHub preview. The headings are formatted so in the sphinx sidebar you will see the parent commands.

Looking good,
This is a really long doc, propose adding a TOC at the top with :
.. contents::
    :backlinks: top

See example at: https://docs.mattermost.com/install/prod-ubuntu-1404.html

Thanks, addressed feedback above

Thanks @JeffSchering for the review! I like your proposed formatting with the indented subheadings. I will check with dev on the technical questions tomorrow and address your feedback.

@JeffSchering feedback addressed, thanks for the detailed review!

Docs tested and reviewed by dev

Thanks Jason, updated

Verified on docs.mattermost.com


Sidebar flickers on handbook pages

On every page load the handbook nav flickers. This is because there's a time between the nav being shown and the JS hiding the nav from https://github.com/microsoft/TypeScript-Website/commit/bbd4f49e92912733335a2af9ca3b7c1540947176

Improvement Idea:
Maybe a noscript tag which sets some CSS to force the closed classes to be shown as open
Why:
It's not polished enough if it flickers

Confirmed the technique above works and is now deployed


Rework vue-core

The build is failing because I removed all tests because they were implementation details test. This is failing on npm run test:coverage don't find any test.
I don't know if I add a dummy test or change the target. Any input are welcome here :)

I don't know if I add a dummy test or change the target. Any input are welcome here :)

Could it be a dummy route test?

@DamnClin : after this redesign got merged. Can you tell me if is it going to be a AxiosHttp module for each client (angular, vue, react)?

I don't know if I add a dummy test or change the target. Any input are welcome here :)

@DamnClin : Could it be a home route test?

@renanfranca I'm strongly agains route test since this is an implementation detail test

@DamnClin : after this redesign got merged. Can you tell me if is it going to be a AxiosHttp module for each client (angular, vue, react)?

Can be a good idea to have the same AxiosHttp module for every clients yes

I don't know if I add a dummy test or change the target. Any input are welcome here :)

@DamnClin : Could it be a home route test?

@renanfranca I'm strongly agains route test since this is an implementation detail test

So dummy test is fine 🙂

cc @Gnuk @murdos @pascalgrimaud what do you think of this version?

@DamnClin: I have already applied these changes to add the vue-core module to implement a sample that will be used to fix https://github.com/jhipster/jhipster-lite/issues/1133. Everything went well! Can you explain why you chose not to add the AxiosHttps stubs and tests? I think a well-implemented test would help guide those who use that module. Anyway, thank you for your work!

@DamnClin: I have already applied these changes to add the vue-core module to implement a sample that will be used to fix Vue: add OAuth2 keycloak authentication. Everything went well! Can you explain why you chose not to add the AxiosHttps stubs and tests? I think a well-implemented test would help guide those who use that module. Anyway, thank you for your work!

As it is, for me, this is testing an implementation detail

I'm adding a big bounty on this, as it was a lot of work here.
Don't forget to claim it @DamnClin

I'm adding a big bounty on this, as it was a lot of work here. Don't forget to claim it @DamnClin

Thanks a lot, claimed https://github.com/jhipster/jhipster-lite/pull/10712#issuecomment-2350923193

@DamnClin : the link is not correct :-D

@DamnClin : the link is not correct :-D

Sorry, misslick in github... https://opencollective.com/generator-jhipster/expenses/220095

@DamnClin : approved, thanks a lot for your work


Implemented SMS Auth

This adds the built-in feature for SMS Auth with the new package serverpod_auth_sms_flutter, which allows the client to authenticate users with SMS and with their favorite SMS provider without worrying about the Verification code being stored in the database.
Added SMS Auth to authenticate users with phones.
Pre-launch Checklist

[x] I read the Contribute page and followed the process outlined there for submitting PRs.
[x] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[x] I read and followed the Dart Style Guide and formatted the code with dart format.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[ ] I added new tests to check the change I am making.
[ ] All existing and new tests are passing.
[x] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.
Breaking changes
None

I have read the CLA Document and I hereby sign the CLA

Could you try to run a serverpod migrate inside the test project? You have to use the cli from main for this to work (How to?).
Since you have changed the database definitions it might simply be an issue with the database state that is out of sync.

You can also run these test locally by executing the script util/run_tests_single_server from the root of the entire mono-repo. You need docker for this to work.

@Isakdl All the tests passed locally. Thanks.

Can u help me to get the sms of +971543566766 and
+919633659993


Add set_secret() and get_secret() for iOS impl.

Closes #187.

Good call @brotskydotcom , thats done!

I notice you convert to Vec<u8> when calling decode_password() but std::str::from_utf8 will take a slice so you can just pass to without the calls to to_vec().

Can you please update README.md to add your name in the contributor's list?

I notice you convert to Vec<u8> when calling decode_password() but std::str::from_utf8 will take a slice so you can just pass to without the calls to to_vec().
Edit: so if you prefer std::str::from_utf8 to String::from_utf8 then we could avoid the allocations here.

Well the definition of decode_password is shared across platforms and most of the others have already done the vector conversion.  But I still like the optimization you suggest in the iOS case, because password_bytes is already a Vec when it comes back from get_secret, so there's really no reason to have the .to_vec() redundant copy made.  It should just be decode_password(password_bytes).

Whoops.  Just noticed one more fix needed to get the tests working on iOS:
You need to change line 91 from
    use keyring::default::IosCredential;

to
    use keyring::ios::IosCredential;


Added EmbeddedFilesEndpoint (rust-embed integration)

Can I merge it? @Eugeny

@sunli I've just fixed the formatting errors, it's good to merge once the pipeline passes

Released in v1.3.23


Request: Allow inversion of redstone behavior

This is not a bug, just a humble request from the perspective of a server owner.
Previous versions had the following config line:
B:"Invert Redstone"=false
I would like to request, if possible, that this ability be reinstated.  I understand that the consequences mean all tier configs will have to use
"checkRedstone": true
Thank you for your consideration and for porting this mod to current

To clarify, you want a blanket config option that forces the Cage to require a redstone signal in order to spawn, correct?

Default vs Config functionality: https://streamable.com/ck1n
Not going to close or release until you confirm this is what was intended.

Yes, this is what I intended.  Thats awesome, thank you

coolio

Tested today, working as intended.  Thanks again :)


Restore default colours for enums (green) and type definitions (orange-ish)

Recently docs built on docs.rs use the same purple colour for struct types, enum types, and type definitions.
Compare when building docs locally: only struct types are purple, enum types are green, and type definitions are orange.
Any reason for this change? Types in different colours are helpful when scanning signatures etc. Please revert to different colours for different types if possible.

@glts docs.rs is using nightly to build the docs, so this is probably a recent change to nightly.
cc @GuillaumeGomez ?

@syphar Thank you. Pity, but I will get used to it.

I can't find the PR and issue for this change. Do you have them by any chance @jsha ?

Personally, I think it's a significant part of the API whether the main way to interact with a type is using match val or val.field. So to be able to visually distinguish between enums and structs on pages like https://docs.rs/serde_json/latest/serde_json/value/fn.to_value.html for related types like Value has been useful to me in the past.

Please open an issue on the rust repository and tag me and @jsha so we can discuss it.


Feature Request: S3 + SQS

I would like to re-open the request for S3 & SQS, this tool is lovely and covers everything that the paid for documenting systems do except they also show S3 & sqs.
it would be great if they could be included somehow

Closing this in favor of the more general #339 and #365


Allow to override settings without touch git-controlled files

Attempt to import settings_local.py and use values given there. This
way we can have different secret keys, database configurations etc without
touching the upstream and git-controlled settings.py.
Modify .gitignore to ignore settings_local.py

That is a good idea. There is indeed some cruft left in this project from back when it was just something I ran and nobody knew about.
Thank you!


feat: disable log for uri

disable rest uri log

It doesn't work for the routes like /api/users/:name.


Add a description of how to get involved

Target developers, students, and businesses.

First pass is done. Closing.


Issue with godep go build straight out of the box

I don't really have a lot of experience with go, so I might be doing something dumb, but godep go build returns the following error (while building on OS X):
main.go:18:2: cannot find package "github.com/snowplow/sql-runner/playbook" in any of:
    /usr/local/Cellar/go/1.4.2/libexec/src/github.com/snowplow/sql-runner/playbook (from $GOROOT)
    /Users/jakedust/workspace/pkg/sql-runner/Godeps/_workspace/src/github.com/snowplow/sql-runner/playbook (from $GOPATH)
    /Users/jakedust/.go/src/github.com/snowplow/sql-runner/playbook
main.go:19:2: cannot find package "github.com/snowplow/sql-runner/run" in any of:
    /usr/local/Cellar/go/1.4.2/libexec/src/github.com/snowplow/sql-runner/run (from $GOROOT)
    /Users/jakedust/workspace/pkg/sql-runner/Godeps/_workspace/src/github.com/snowplow/sql-runner/run (from $GOPATH)
    /Users/jakedust/.go/src/github.com/snowplow/sql-runner/run
godep: go exit status 1

After a go get github.com/snowplow/sql-runner, the build works fine.

Closing as the package structure has been changed to put all snowplow code in one folder.


Improve multicast, allow children to listen to src:0xffff or maybe redefine Link-Local to Logical-Local

2 issues closely related.

A Child does not listen to 0xffff broadcast for ff02::1 or ff03::1 only if it the source is it's router. meaning even if it was in range and received the multicast it will ignore it leaving it to only react to 1 of many possible received radio transmissions containing a valid message for the child.

A message to ff02::1 or ::2 is not actually as described "Link-Local — all interfaces reachable by a single radio transmission" for children - as a child within range will not receive a message sent from a child with different parent even tho they are i radio range. Making the term for "ff02::?" not Link-Local but Logical-Local.

A solution for 1.:
Allow children to receive messages from src: 0xffff this will drastically improve delivery assurance of multicasts since the child will most likely hear the message from others before it's own router sends it there by also decreasing delivery latency.
A solution for 2.:
Is closely related to point 1. Sending ff02::? local link multicasts to dst:0xffff and listening to it will allow children to receive messages from it's non parental related neighbors.
Alternatives i have looked at is the raw module for making a actual local link radio transmission meaning it would be received by all neighboring devices regardless of heritage however there is no documentation on it's usage. Like can one use the raw api concurrent with thread?
Additional context
So far very happy with open thread and the api structure falling right with in my coding style but my implementation plan of an speedy efficient distribution of data blobs was kind of destroyed with "Link-local" actually being "Logical-Local" :)

@jwhui thanks for answering so fast.

We are running all of our devices as FTD and i am pretty sure we are running RX always on. But i have to check if that was the specifically defined with the last test.
But if i understand you correctly it dose not matter if the device is FTD and rx on always if the broadcast message comes from child with different parent. As according to you they will only listen to whom they have a "MLE" relationship with.
Q: Is that correct?

We require as low latency and low packet loss as possible. So we designed a distribution model based on ff02::1 local-link using different ways to ensure every device got the message without a complete/"controlled" flod as with ff03::1. However the design broke down with the addition of children due to devices not receiving otherwise in range and "valid" broadcast packets...

So i would state that the definition of scope:
"Link-Local — all interfaces reachable by a single radio transmission"
in the documentation/thread primer should be changed to Logical-local or have an addendum stating something like "all connected/established interfaces reachable by a single radio transmission"
Just a suggestion :)

Also in the primer on https://openthread.io/guides/thread-primer/router-selection
there is a the following text:
"An End Device may also wish to establish a receive link with neighboring non-Parent Routers to improve multicast reliability. We'll learn more about this when we get to Multicast Routing."
However that is the last you see of that...
Q: Perhaps you can spread some light on this?

The data we need to disseminate does not need encryption only source verification so we were considering to send the packets as raw but cryptographically signed packets or time share the radio with a custom protocol. As we really like many of the features offered by thread.
Q: A. Is it possible to use the raw link api concurrent with thread to support this or do we need to use the time share approach?

@musalk-dk

Because Thread requires IEEE 802.15.4 MAC security for all data traffic, Thread devices will generally only receive data traffic for neighbors where an MLE link is established.

One exception to the above is MLE packets, which are sent without IEEE 8021.5.4 MAC security enabled. MLE is used to establish a secure link, which is why MLE does not require MAC security. In the case of MLE, link-local scope is as defined in the Thread specification.

FTDs operating as children continuously listen for MLE Advertisement messages from any neighboring routers. Upon discovering a new neighboring router, the FTD child may use MLE Link Request/Accept to establish an MLE link for the purposes of receiving multicast messages.

If your application only requires link-local communication and does not require MAC security, then you could try sending "unsecure" traffic. I have pushed a minor patch to the UDP CLI that should allow you to play with this feature. Note that this behavior is not a part of the Thread specification.

Hope that helps.


Image quality with 4096 x 4096 (stereo) on Cardboard

I have been testing a stereo image of size 4096x406 against the initial version (0.2.0, which I had downloaded as soon as the repository was announced) and the 2.0.0 version that is now at the master. The image looks crisp and shown at the correct resolution with the original version. However, with the latest  the image is blurry and seems like it is being downscaled on the cardboard (full screen seems to be ok).

Try tweaking the WebVRConfig.BUFFER_SCALE in index.html. Does that change
anything?
On Mon, Nov 14, 2016 at 12:44 AM hasandogu<EMAIL_ADDRESS>wrote:

I have been testing a stereo image of size 4096x406 against the initial
version (0.2.0, which I had downloaded as soon as the repository was
announced) and the 2.0.0 version that is now at the master. The image looks
crisp and shown at the correct resolution with the original version.
However, with the latest the image is blurry and seems like it is being
downscaled on the cardboard (full screen seems to be ok).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlevr/vrview/issues/75, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQ8gHC0Jh9r4UGJEW6wn4yS5ukZGDApks5q-B9OgaJpZM4KxEpM
.

Yes, that fixed the quality issue. Thank you very much.