Add consult_exporter

This will install consul_exporter on kubernetes to collect consul metrics for Prometheus

/assign @seanknox

just signed CLA
On Fri, Mar 23, 2018 at 1:43 PM, k8s-ci-robot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. Before we can look at your pull request,
you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to
sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered;
after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data and verify that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please sign in with your
organization's credentials at https://identity.
linuxfoundation.org/projects/cncf
https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA
being reported as unsigned, please email the CNCF helpdesk:
<EMAIL_ADDRESS><EMAIL_ADDRESS>
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/devel/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/charts/pull/4441#issuecomment-375746619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdkuxrYV--FoTSnwWJKNJfH4xqpNMxIDks5thTQ6gaJpZM4S5IJk
.

--
Confidentiality Notice: This email message and any attachments from COTA,
Inc are confidential and for the sole use of the intended recipient. This
communication may contain Protected Health Information. Protected Health
Information is confidential information that may only be used or disclosed
in accordance with applicable law. There are penalties under the law for
the improper use or further disclosure of Protected Health Information. If
you are not the intended recipient of this email or the employee or agent
responsible for delivering the communication to the intended  recipient,
then you may not read, copy, distribute or otherwise use or disclose the
information contained in this message. If you received this message in
error, please notify us by telephone at<PHONE_NUMBER>. Please indicate that
you were not the intended recipient, and confirm that you have deleted the
original message. Please do not retransmit the contents of the message.
Thank you.

/close


Does not support uppercase context(enum) names

contexts:
  GenderContext:
    enum:
      - MALE
      - FEMALE

i18n yaml
  greet:
    MALE: a
    FEMALE: b

Then do not understand GenderContext, but instead generate as if MALE and FEMALE are normal keys.

Fixed in 1ac786359c25e04c51a3a93a85b817306448d2d6


how to Increase throughput when I send big file? 10g or more

Recently, I have encountered some problems. During my file transfer process, the speed of the receiver does not increase, which is around 660MB/s. What parameters or methods can be further improved?
My network is a 10 Gigabit.
thank you!

Is the file read from or written to SATA SSDs? Because that's about the speed of what they can do.

also you might want to check how busy your system is in terms of IO with tools like iostat

Last, are you trying to achieve this number on a single connection? if yes, you must hustle a lot to get those numbers.


Update refund order linking and VATs

Description
Updates:

Update refund order linking from vehicle and address change processes to point to permit latest order
Create renewal orders only with positive sums
Use VAT from price change list
Convert Talpa vat percentage to vat when creating new OrderItem
Update tests

Context
PV-871
How Has This Been Tested?
Manually and through unit tests.

LGTM!


[ModTranslation]: ConveyorTile zh

What mod is that translation for?
Cluster Generation Manager
Additional Comments
by chinchou
translation file
ConveyorTilesZH.zip

1.1.3 release


Add regression test for merging with ea and numpy

[x] Closes #6018
[x] Tests added / passed
[x] Passes pre-commit run --all-files

I think this is a useful test to have. There is still some work going on on the pandas side for merge (especially for arrow dtypes) and this would enable us to catch failures on our side early

Yep, thx. Closing


Rename sdg_path to tasks_dir

Related to https://github.com/instructlab/instructlab/issues/1663
Corresponding UI change: https://github.com/instructlab/instructlab/pull/1677

I guess eval isn't tested in the e2e CI tests yet, so we don't need to worry about doing this in multiple steps to avoid breaking CI?

That's correct, the only API change was to the exceptions which aren't used directly.


Strip leading/trailing whitespace from CSV import

Example: Attempting to import secrets to devices with whitespace on each line before the name will yield an error complaining that the devices cannot be found. We should strip leading and trailing whitespace from each line to avoid this.

Or even from each field?

@candlerb Probably. The only exception might be free-form comment fields, since technically a user might want to lead with whitespace for indentation.


Kakoune hangs when running any easymotion command

Kakoune v2018.10.27
Python 3.6.7
Shell: dash-0.5.10
Commit that breaks it for me: 9098e0ff15089e1a0b0ea469441d6f58d76d40cf
When running any easymotion command kakoune hangs and waits for some command to complete. I have to use <c-c> to stop the command. After this there's plenty of selections in the buffer, empty *pydef* buffer and some errors in debug
*** This is the debug buffer, where debug info will be written ***
Config-change detected:
Config-change detected:
error running hook ModeChange(insert:next-key)/: 2:6: 'set-option' no window in context
error running hook ModeChange(insert:normal)/: 2:6: 'set-option' no window in context

@danr Any ideas?..

Ping

btw: if you are affected by this bug - 40d73d commit works fine for me, even on master branch.

I'm having the same problem (in 7f080c172b9e0e20bf3866b9bc98cbc1d5c2d1cc) and can confirm that it works fine in 40d73d70904a7db3edaa3169212aa2f587d48e13

Hmm... I don't see what's going on. Without 7f080c1 (using 40d73d7) we have \n literally being sent to kakoune. Can you check what set window debug commands gives you?

I got rid of the scratch buffer and started using echo -to-file instead, maybe this will fix the problem. Can anyone check?

If I run easymotion-word, I get this:
With 40d73d7:
Screenshot

With current master (a0ee34a):
Screenshot

Yes, you will need https://github.com/mawww/kakoune/commit/744778be. There will be a new kakoune release with this included shortly.

With https://github.com/mawww/kakoune/commit/e4d6bff5ec1a6bf3a3456e26d51e53d85c282ea0 and https://github.com/danr/kakoune-easymotion/commit/a0ee34ac7f7b50f5fefdab0c3327d21edc64deae
running any easymotion command hangs Kakoune definitely, I can't do anything, I have to kill process.
Ubuntu 19.04, Python 3.7.3 and 2.7.16

Hmm I cannot reproduce this here. I'm using arch. The communication is via fifos, maybe the OS can buffer the fifos in different ways. I'm assuming line buffering.

Hard to tell, I have this issue on Void as well.

Are you testing with kak -n?

I tried with -n and without it, no difference :(

Can you try now? I pushed 9f69176.
Also https://unix.stackexchange.com/questions/25372/turn-off-buffering-in-pipe might be relevant...

Still nothing. I tried stdbuf -oL -eL kak -n as well but it does not help (not sure if I use it correctly)

Maybe try stdbuf -oL -eL cat $kakfifo here:
https://github.com/danr/kakoune-easymotion/blob/master/easymotion.kak#L22
Also can you try set window debug shell|commands in the window where you will run the easymotion command + have the debug buffer open? That way we might see how far we get before kakoune hangs.

Also can you try set window debug shell|commands in the window where you will run the easymotion command + have the debug buffer open? That way we might see how far we get before kakoune hangs.

It would be good idea but debug buffer is not updated after I call any easymotion-command.

Maybe try stdbuf -oL -iL cat $kakfifo here:

Unfortunately it doesn't help

I ran this too, while yours has this line:
openat(AT_FDCWD, "/tmp/tmp.Qv0LWFVlWH.py.pyfifo", O_WRONLY|O_CREAT|O_TRUNC, 0644) = ? ERESTARTSYS (To be restarted if SA_RESTART is set)
--- SIGTERM {si_signo=SIGTERM, si_code=SI_USER, si_pid=11484, si_uid=1000} ---

mine succeds with actually writing the parameters (the alphabet is em_jumpchars and so on), and later gets the reply starting with a select:
openat(AT_FDCWD, "/tmp/tmp.9GBM1vDndo.py.pyfifo", O_WRONLY|O_CREAT|O_TRUNC, 0644) = 5
write(5, "abcdefghijklmnopqrstuvwxyz^1^e^^"..., 50) = 50
close(5)                                = 0
pipe([5, 6])                            = 0
pipe([7, 8])                            = 0
vfork()                                 = 17730
close(6)                                = 0
close(8)                                = 0
fcntl(-1, F_GETFL)                      = -1 EBADF (Bad file descriptor)
fcntl(-1, F_SETFL, O_ACCMODE|O_CREAT|O_EXCL|O_NOCTTY|O_TRUNC|O_APPEND|O_NONBLOCK|O_SYNC|O_DIRECT|O_LARGEFILE|O_NOFOLLOW|O_NOATIME|O_CLOEXEC|O_PATH|O_TMPFILE|FASYNC|0xff80003c) = -1 EBADF (Bad file descriptor)
rt_sigprocmask(SIG_BLOCK, [CHLD], [], 8) = 0
wait4(17730, 0x7ffe652ded94, WNOHANG, NULL) = 0
pselect6(8, [0 3 5 7], [], [], {tv_sec=0, tv_nsec=27970828}, {[], 8}) = 1 (in [5], left {tv_sec=0, tv_nsec=24842887})
select(6, [5], NULL, NULL, {tv_sec=0, tv_usec=0}) = 1 (in [5], left {tv_sec=0, tv_usec=0})
read(5, "select 1.1,1.1\neasy-motion-rmhl\n"..., 1024) = 1024
select(6, [5], NULL, NULL, {tv_sec=0, tv_usec=0}) = 1 (in [5], left {tv_sec=0, tv_usec=0})
read(5, " em_fg 1;_on_key '';easy-motion-"..., 1024) = 565
select(6, [5], NULL, NULL, {tv_sec=0, tv_usec=0}) = 1 (in [5], left {tv_sec=0, tv_usec=0})
read(5, "", 1024)                       = 0

I don't know what to make out of this though. I'll ask Screwtape.

To be restarted if SA_RESTART is set
SIGTERM

Just from that strace snippet, it looks like your attempt to openat() the FIFO just hangs until the Kakoune script (or something else) sends it SIGTERM. On my machine, fifo(7) says:

The FIFO must be opened on both ends (reading and writing) before data can be passed.  Normally, opening the FIFO blocks until the other end is opened also.

...so I'd guess that's what's happening here. Could there be some kind of race condition where the reader tries to open the FIFO, fails, and exits before the writer tries to open it?

When running any easymotion command kakoune hangs and waits for some command to complete. I have to use  to stop the command. After this there's plenty of selections in the buffer, empty pydef buffer and some errors in debug

Samething here on macOS

The PR #18 was merged, does this help the hangs?

It seems it helped, at least at my Void Linux machine. I'll check tomorrow on Ubuntu.

Had the same problem (Void Linux). For me it was a python alias missing. I've solved it by making a symbolic link in the /bin directory:
cd /bin
sudo ln -s python3 python

Might be useful for others encountering this problem.

This issue has been stale for a while, but still happens by default on MacOS. It looks like switching the python command from python to python3 does the trick in my environment. Would you have any objection to this change @danr?


HitBTC AccountTransfer throws an ExchangeSharp.APIException   HResult=0x80131500   Message=

I don't see the problem. There is enough balance in the account bank. keys are set up to allow. Any suggestion why this does not work?
Symbol is "NIM"
Amount is dec 2000
ToBank = false
    public async Task<bool> AccountTransfer(string Symbol, decimal Amount, bool ToBank)
    {
        var payload = await GetNoncePayloadAsync();
        payload["type"] = ToBank ? "exchangeToBank" : "bankToExchange";
        payload["currency"] = Symbol;
        payload["amount"] = Amount;
        JToken obj = await MakeJsonRequestAsync<JToken>("/account/transfer", null, payload);
        return (obj != null && obj.HasValues && !String.IsNullOrEmpty(obj["id"].ToStringInvariant()));
    }

ExchangeSharp.APIException
HResult=0x80131500
Message=

Error

Cannot GET /api/2/account/transfer

Source=ExchangeSharp
StackTrace:
at ExchangeSharp.APIRequestMaker.d__4.MoveNext() in ...ExchangeSharp\API\Common\APIRequestMaker.cs:line 216
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()    at ExchangeSharp.BaseAPI.<MakeJsonRequestAsync>d__751.MoveNext() in ....API\Common\BaseAPI.cs:line 456
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()    at ExchangeSharp.ExchangeHitbtcAPI.<AccountTransfer>d__33.MoveNext() in ...ExchangeSharp\API\Exchanges\Hitbtc\ExchangeHitbtcAPI.cs:line 472    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at Binace_Auto_Sell.Form1.<button1_Click_1>d__3.MoveNext() in ....Hitbtc Auto Sell\Hitbtc Auto Sell\Form1.cs:line 143

why is it showing "Cannot GET /api/2/account/transfer"
should it not be  POST?
https://api.hitbtc.com/#account-management
shows POST /api/2/account/transfer

YES!!
this works
    public async Task<bool> AccountTransfer(string Symbol, decimal Amount, bool ToBank)
    {
        var payload = await GetNoncePayloadAsync();
        payload["type"] = ToBank ? "exchangeToBank" : "bankToExchange";
        payload["currency"] = Symbol;
        payload["amount"] = Amount;
        JToken obj = await MakeJsonRequestAsync<JToken>("/account/transfer", null, payload,"POST");
        return (obj != null && obj.HasValues && !String.IsNullOrEmpty(obj["id"].ToStringInvariant()));
    }


Remove Lithuanian legacy card support

WE2-769
Signed-off-by: Raul Metsma<EMAIL_ADDRESS>

See https://www.nsc.vrm.lt/default.htm about revoking of legacy card certificatese


Vulnerability GO-2024-2609

Vulnerability: GO-2024-2609
Comments in display names are incorrectly handled in net/mail
More info: https://pkg.go.dev/vuln/GO-2024-2609
Standard library
Found in<EMAIL_ADDRESS>Fixed in<EMAIL_ADDRESS>Example traces found:
protovalidate.Validator.Validate, which eventually calls mail.ParseAddress

sorry for reporting this here i now notice that golang builtin packages must be updated on the user side not the model provider side


Update README.md to include VC Redist for 2013

Required for MonoGame mgcb.exe to work for FreeType.dll image conversion

Why haven't they updated this? It really doesn't seem like part of the challenge should be googling for an obscure issue via an error code that doesn't exist and somehow stumbling across this solution. Come on MS, show you care, since a lot of people are only finding out about this challenge now with the most recent dev email <3


Dataset

Could you please tell me where I can get the same training dataset used in your paper?

Hi,
You can find the training dataset by following the instructions provided in this repository.

ok!! Thank you!!

Sorry, could you please tell me how to get the audio file of the Beatles dataset? I didn't find it in the link you provided, nor in the article you cited in your paper.


[bug]Unable to create storage with Stronghold plugin

We are currently trying to create our first crypto storage with the following documentation, but it is not working.
https://v2.tauri.app/plugin/stronghold/
Rust
let crypto_path = app.path().app_local_data_dir()
    .expect("could not resolve app local data path").join("crypto.bin"); // File containing pre-prepared hash strings
app.handle().plugin( tauri_plugin_stronghold::Builder::with_argon2( &crypto_path ).build() ).unwrap();

let conf_path = app.path().app_local_data_dir()
    .expect("could not resolve app local data path").join("config.st");
let conf_pwd = "my password".as_bytes().to_vec();
let store = tauri_plugin_stronghold::stronghold::Stronghold::new(conf_path, conf_pwd).unwrap();

Error
thread 'main' panicked at src/main.rs:191:93:
called `Result::unwrap()` on an `Err` value: Memory(NCSizeNotAllowed)

TypeScript
import { appDataDir } from '@tauri-apps/api/path';
import { Stronghold, Client } from '@tauri-apps/plugin-stronghold';

const conf_path = (await appDataDir()) + "/config.st";
const stronghold = await Stronghold.load(conf_path, "my password");
let client: Client;
const clientName = 'app-config';
try {
  client = await stronghold.loadClient(clientName);
} catch {
  client = await stronghold.createClient(clientName);
}

Error
VM9:107
 IPC custom protocol failed, Tauri will now use the postMessage interface instead TypeError: Failed to fetch
    at Object.sendIpcMessage (<anonymous>:73:7)
    at Object.<anonymous> (<anonymous>:132:38)
    at action (<anonymous>:269:38)
    at <anonymous>:278:11
    at new Promise (<anonymous>)
    at Object.value (<anonymous>:254:14)
    at invoke (core.js:134:39)
    at _Stronghold.load (index.js:265:22)
    at App.tsx:59:43

The permissions are set to stronghold:default.
I have tried the above on the Rust side and on the TypeScript side, but have yet to find a solution.
If this is not a bug and my perception or usage of this plugin is wrong, please point it out.
development environment
Windows 11 Pro
rust 1.81
TAURI 2.0.2
tauri-plugin-stronghold 2.0.1 with node package 2.0.0

Self resolved.
The problem was that the length of the key I had prepared was slightly less than 32 bytes.
Sorry for the trouble.


miniai - Disabling builtin text object does not restore default behavior

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.ai
Description
Not quite sure if this qualifies as a bug or if this is the intended behavior, however disabling the "b" builtin textobject does not restore the original "b" vim textobject
Neovim version
NVIM v0.9.0-dev-220+g234b8c5f3
Steps to reproduce
minimal_init.lua:
local on_windows = vim.loop.os_uname().version:match("Windows")
-- vim.api.nvim_command("!rm -rf /tmp/nvim")

local function join_paths(...)
  local path_sep = on_windows and "\\" or "/"
  local result = table.concat({ ... }, path_sep)
  return result
end

vim.cmd([[set runtimepath=$VIMRUNTIME]])

local temp_dir = vim.loop.os_getenv("TEMP") or "/tmp"

vim.cmd("set packpath=" .. join_paths(temp_dir, "nvim", "site"))

local package_root = join_paths(temp_dir, "nvim", "site", "pack")
local install_path = join_paths(package_root, "packer", "start", "packer.nvim")
local compile_path = join_paths(install_path, "plugin", "packer_compiled.lua")

local function load_plugins()
  vim.cmd([[ syntax off]])
  vim.g.ts_highlight_lua = true
  require("packer").init({
    package_root = package_root,
    compile_path = compile_path,
  })
  require("packer").startup({
    function(use)
      use({ "wbthomason/packer.nvim" })
      use({ "nvim-treesitter/nvim-treesitter" })
      use({
        "echasnovski/mini.ai",
      })
    end,
  })
end

_G.load_config = function()
  require("mini.ai").setup({
    -- Table with textobject id as fields, textobject specification as values.
    -- Also use this to disable builtin textobjects. See |MiniAi.config|.
    custom_textobjects = {
      f = false,
      a = false,
      b = false,
    },

    -- Module mappings. Use `''` (empty string) to disable one.
    mappings = {
      -- Main textobject prefixes
      around = "a",
      inside = "i",

      -- Next/last variants
      around_next = "an",
      inside_next = "in",
      around_last = "al",
      inside_last = "il",

      -- Move cursor to corresponding edge of `a` textobject
      goto_left = "g[",
      goto_right = "g]",
    },

    -- Number of lines within which textobject is searched
    n_lines = 50,

    -- How to search for object (first inside current line, then inside
    -- neighborhood). One of 'cover', 'cover_or_next', 'cover_or_prev',
    -- 'cover_or_nearest', 'next', 'previous', 'nearest'.
    search_method = "cover_or_next",
  })
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system({ "git", "clone", "https://github.com/wbthomason/packer.nvim", install_path })
  load_plugins()
  require("packer").sync()
else
  load_plugins()
  require("packer").sync()
  _G.load_config()
end

Open file that contains text with parentheses and curly braces using vim -u minimal_init.lua file.txt
Try to use the b textobject on parenthesis
Notice nothing happens

Expected behavior
b textobject is restored to default vim behavior
Actual behavior
b textobject does  not work anymore

Thanks for the clear issue!
It is indeed a bug. A sever one, even. I somehow missed to test this behavior. I'll fix it soon.

Could you try the latest main? Should be fixed there.

works great, thanks for the quick fix!


Zip64 - 0 Size on Entry > 4GiB

I have a zip containing 1 file that's greater than 4GiB.
The Entry returns a Size of 0. I've had a look at the code and the correct size appears to be in the RelativeOffsetOfEntryHeader property of the Zip64ExtendedInformationExtraField class.
I've made a workaround but I don't know how correct it is
var zip64ExtraData = Extra.OfType<Zip64ExtendedInformationExtraField>().FirstOrDefault();
if (zip64ExtraData != null)
{
    if (CompressedSize == uint.MaxValue)
    {
        CompressedSize = zip64ExtraData.CompressedSize;
    }

    if (UncompressedSize == uint.MaxValue)
    {
        //hacky fix for resolving 0 Size being returned for files > 4GiB. This returns the correct size for the test case
        if (zip64ExtraData.UncompressedSize == 0 && zip64ExtraData.RelativeOffsetOfEntryHeader > (long)uint.MaxValue)
            UncompressedSize = zip64ExtraData.RelativeOffsetOfEntryHeader;
        else
            UncompressedSize = zip64ExtraData.UncompressedSize;
    }

    if (RelativeOffsetOfEntryHeader == uint.MaxValue)
    {
        RelativeOffsetOfEntryHeader = zip64ExtraData.RelativeOffsetOfEntryHeader;
    }
}

There appears to be no other header set if (RelativeOffsetOfEntryHeader == uint.MaxValue) is false
Any advice would be appreciated. I'm happy to try and create a PR. I've not done this before.

Might need to research the ZIp64 loading of the Extra is correct
from APPNOTE.txt
  4.5.3 -Zip64 Extended Information Extra Field (0x0001):

      The following is the layout of the zip64 extended
      information "extra" block. If one of the size or
      offset fields in the Local or Central directory
      record is too small to hold the required data,
      a Zip64 extended information record is created.
      The order of the fields in the zip64 extended
      information record is fixed, but the fields MUST
      only appear if the corresponding Local or Central
      directory record field is set to 0xFFFF or 0xFFFFFFFF.

      Note: all fields stored in Intel low-byte/high-byte order.

        Value      Size       Description
        -----      ----       -----------
(ZIP64) 0x0001     2 bytes    Tag for this "extra" block type
        Size       2 bytes    Size of this "extra" block
        Original
        Size       8 bytes    Original uncompressed file size
        Compressed
        Size       8 bytes    Size of compressed data
        Relative Header
        Offset     8 bytes    Offset of local header record
        Disk Start
        Number     4 bytes    Number of the disk on which
                              this file starts

      This entry in the Local header MUST include BOTH original
      and compressed file size fields. If encrypting the
      central directory and bit 13 of the general purpose bit
      flag is set indicating masking, the value stored in the
      Local Header for the original file size will be zero.

The code does different things based on the length which feels wrong:
https://github.com/adamhathcock/sharpcompress/blob/faf1a9f7e4fa6b3ac71a4cbf7f73abf7257ed87a/src/SharpCompress/Common/Zip/Headers/LocalEntryHeaderExtraFactory.cs#L83
You could be getting the situation were only the uncompressed size is provided but putting it in the wrong field

Thanks, I was apprehensive I'd made a bad assumption so went for the defensive change.
I think you're correct. Although I don't know which app created the file I'm using. I created another with 7Zip. < 4GiB compressed but > 4GiB decompressed. It has the same behaviour.
            {
                case 4:
                    VolumeNumber = BinaryPrimitives.ReadUInt32LittleEndian(DataBytes);
                    return;
                case 8:
                    UncompressedSize = BinaryPrimitives.ReadInt64LittleEndian(DataBytes); //works for test zip and a new 7zip created zip
                    //Original - RelativeOffsetOfEntryHeader = BinaryPrimitives.ReadInt64LittleEndian(DataBytes);
                    return;
                case 12:
                    RelativeOffsetOfEntryHeader = BinaryPrimitives.ReadInt64LittleEndian(DataBytes);
                    VolumeNumber = BinaryPrimitives.ReadUInt32LittleEndian(DataBytes.AsSpan(8));
                    return;
                case 16:
                    UncompressedSize = BinaryPrimitives.ReadInt64LittleEndian(DataBytes);
                    CompressedSize = BinaryPrimitives.ReadInt64LittleEndian(DataBytes.AsSpan(8));
                    return;
                case 20:

Both indicate that length of 8 should be as above. Creating another test zip with a file > 4GiB that compresses to > 4GiB hits case 16; and works correctly as is. Just thought I'd test that as I don't know how to create the other examples.

I think that switch statement shouldn't be there.  Looking at the spec, there is a given order of values but it can be variable.
So the first 8 bytes, if exists, is always the uncompressed length.
So the next 8 bytes, if exists, is always the compressed length.
So the next 8 bytes, if exists, is always the offset of the local header.
etc.

        private void Process()
        {
            if (DataBytes.Length >= 8)
                UncompressedSize = BinaryPrimitives.ReadInt64LittleEndian(DataBytes); //as per spec
            if (DataBytes.Length >= 16)
                CompressedSize = BinaryPrimitives.ReadInt64LittleEndian(DataBytes.AsSpan(8));
            if (DataBytes.Length >= 24)
                RelativeOffsetOfEntryHeader = BinaryPrimitives.ReadInt64LittleEndian(DataBytes.AsSpan(16));
            if (DataBytes.Length == 28)
                VolumeNumber = BinaryPrimitives.ReadUInt32LittleEndian(DataBytes.AsSpan(24));

            if (DataBytes.Length > 28)
                throw new ArchiveException("Unexpected size of of Zip64 extended information extra field");
        }

I think this matches the spec. You beat me to it ha

Released https://github.com/adamhathcock/sharpcompress/releases/tag/0.28


refactor: document extra methods

What type of PR is this?

refactor schema.Document builtin extra methods

rename few method names and extra key
add sparse vector getter & setter（basically for indexer and retrieve）

Check the PR title.

[x] This PR title match the format: <type>(optional scope): <description>
[x] The description of this PR title is user-oriented and clear enough for others to understand.
[x] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

调整 schema.Document extra 的部分内置方法

修改部分方法名称与 key
新增 sparse vector getter setter，供 indexer & retriever 使用

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Internet Explorer improperly caches /queue/ JSON requests and is generally just trash :(

Every time I attempt to import a pdf I get the message "DEBUG: resetting rack response due exception" in the command line window, and the upload progress never changes from "waiting to be processed.."

Is your document really big? Sometimes the processing can take a long time to get started...
(The "DEBUG" message usually doesn't mean there was a problem.)

Its not very big at all, only 7kb.
Sent from my iPhone
On Sep 28, 2015, at 5:59 PM, Jeremy B. Merrill <notifications<EMAIL_ADDRESS>wrote:
Is your document really big? Sometimes the processing can take a long time to get started...
(The "DEBUG" message usually doesn't mean there was a problem.)
—
Reply to this email directly or view it on GitHubhttps://github.com/tabulapdf/tabula/issues/408#issuecomment-143885561.

Hmm. If the PDF isn't sensitive, can you send us a link to it? Or upload a
PDF on the Github issue page.
(The thing NOT to do is not to attach it to an email -- I won't get that.)
On Mon, Sep 28, 2015 at 6:03 PM, comprehenderic<EMAIL_ADDRESS>wrote:

Its not very big at all, only 7kb.
Sent from my iPhone
On Sep 28, 2015, at 5:59 PM, Jeremy B. Merrill<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Is your document really big? Sometimes the processing can take a long time
to get started...
(The "DEBUG" message usually doesn't mean there was a problem.)
—
Reply to this email directly or view it on GitHub<
https://github.com/tabulapdf/tabula/issues/408#issuecomment-143885561>.
—
Reply to this email directly or view it on GitHub
https://github.com/tabulapdf/tabula/issues/408#issuecomment-143886688.

Unfortunately the pdf is sensitive. However, I tried to use the software on another machine with another file and got the same results. Is there a specific version of Java I should be using? Tried it with 6 (wouldn’t  run) 7 & 8 (seemed to act the same with those).
From: Jeremy B. Merrill<EMAIL_ADDRESS>Sent: Monday, September 28, 2015 6:09 PM
To: tabulapdf/tabula
Cc: Eric Ross
Subject: Re: [tabula] "DEBUG: resetting rack response due exception" (#408)
Hmm. If the PDF isn't sensitive, can you send us a link to it? Or upload a
PDF on the Github issue page.
(The thing NOT to do is not to attach it to an email -- I won't get that.)
On Mon, Sep 28, 2015 at 6:03 PM, comprehenderic<EMAIL_ADDRESS>wrote:

Its not very big at all, only 7kb.
Sent from my iPhone
On Sep 28, 2015, at 5:59 PM, Jeremy B. Merrill<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Is your document really big? Sometimes the processing can take a long time
to get started...
(The "DEBUG" message usually doesn't mean there was a problem.)
—
Reply to this email directly or view it on GitHub<
https://github.com/tabulapdf/tabula/issues/408#issuecomment-143885561>.
—
Reply to this email directly or view it on GitHub
https://github.com/tabulapdf/tabula/issues/408#issuecomment-143886688.

—
Reply to this email directly or view it on GitHubhttps://github.com/tabulapdf/tabula/issues/408#issuecomment-143887834.

Hmm. Java 7 and Java 8 should both work fine. What browser are you using?
One last possibility: Can you try again to upload your document, wait a minute or so, then open the Web Console and copy-paste any error messages to here? In Firefox, go to Tools -> Web Developer -> Web Console; in Chrome, View -> Developer -> Javascript Console.
Thanks and sorry for hte inconvenience.

Hi @comprehenderic
You can email your document privately to us, if possible. Just send it to manuel at jazzido dot com

Aha! It works fine after I tried in Firefox. IE11 seems to be the problem. We have to use IE for some other software, so I’d like the end user to be able to use this in IE. Do I need to use an older version, or set some permissions or something?
From: Jeremy B. Merrill<EMAIL_ADDRESS>Sent: Tuesday, September 29, 2015 11:15 AM
To: tabulapdf/tabula
Cc: Eric Ross
Subject: Re: [tabula] "DEBUG: resetting rack response due exception" (#408)
Hmm. Java 7 and Java 8 should both work fine. What browser are you using?
One last possibility: Can you try again to upload your document, wait a minute or so, then open the Web Console and copy-paste any error messages to here? In Firefox, go to Tools -> Web Developer -> Web Console; in Chrome, View -> Developer -> Javascript Console.
Thanks and sorry for hte inconvenience.
—
Reply to this email directly or view it on GitHubhttps://github.com/tabulapdf/tabula/issues/408#issuecomment-144091023.

No, it's probably our fault. I'll try to check on IE Edge and IE11 next time I get the chance. You'll have to either use Firefox/Chrome/Safari or wait until the next version (which should fix this problem, once we figure out what it is).

Just wanted to provide feedback that I had the same issue with IE11 - though both Chrome & Firefox work wonderfully.
Thank you!

@pthartmann: thank you for the reminder, I forgot.... :)

Okay, the problem is a mundane one. Internet Explorer (including Edge on Win10, which is what I tested with) inappropriately caches the JSON request that the Tabula webpage uses to ask the Tabula server for the status of your document. After a short period of time (seconds, maybe a couple minutes for huge documents), the document is done. If you were to refresh the page, you'd see it in your file library.
The workaround (for now):

Switch to Firefox or Chrome.
In Internet Explorer, let Tabula "process" your document for five minutes or so, then refresh the page and click on "Extract Data" next to your document in the File Library.

I'll examine why this is happening. Should be an easy fix. Might be as easy as adding a cachebuster querystring argument...

This bug is fixed in https://github.com/tabulapdf/tabula/commit/8f5e24579bb79d94d21836128206a0456db25c18. Thank you both @comprehenderic, @pthartmann for reporting the bug and sorry for the wait on the fix. (For workarounds, see above comment.)
Hey @mtigas: Can we get a new Windows build off of stable/1.0.x? Other platforms should be okay. (I can also send you a built version, just the output of rake windows if that's helpful. Lmk.)

It looks like the windows release is still 1.0.1 from 15th September unless there's somewhere else it's listed I haven't found.

That's correct. I need to harass @mtigas to make a new official build. If you're waiting on a fix, you're welcome to use my testing build from here: https://www.dropbox.com/s/302zrspteh5cflu/tabula-win-revf2bb3d14efeb2dcc1f49a0d592f0a90b781e13f4.zip?dl=1

Thanks very much for getting back to me so fast. Unfortunately my version of IE 11 still seems to be having trouble with your testing build but I'm happy to wait for the release.

The same trouble?

Yes, same error message and general not working-ness. I'm going to try and get another browser installed.

Hmm, that's surprising to me. Another browser should work...
If you still want to try IE, have you tried letting it process for a few minutes, then refreshing the page? Your file should be fully processed and show up in your file library...

@comprehenderic @pthartmann @Henry-E: I’ve uploaded another Windows build; can you try this? https://cdn.tig.as/dist/tabula/1.0/tabula-win-<IP_ADDRESS>-rc1.zip
Will release within the next day or two unless something's completely wrong with it.

It still doesn't appear to be working. The test pdf is only small, 365kb and 3 pages long. I wait, refresh and don't see anything. If there's anything more detailed I can do to help you test please let me know. Thanks for the help.
DEBUG: resetting rack response due exception
io/console not supported; tty will not be manipulated
DEBUG: resetting rack response due exception

Yikes. Lemme re-check tomorrow night on my windows machine, to see if I can
figure out what's going on...
Jeremy B. Merrill
Sent from my mobile device
On Oct 29, 2015 9:29 AM, "Henry-E"<EMAIL_ADDRESS>wrote:

It still doesn't appear to be working. The test pdf is only small, 365kb
and 3 pages long. I wait, refresh and don't see anything. If there's
anything more detailed I can do to help you test please let me know. Thanks
for the help.
DEBUG: resetting rack response due exception
io/console not supported; tty will not be manipulated
DEBUG: resetting rack response due exception
—
Reply to this email directly or view it on GitHub
https://github.com/tabulapdf/tabula/issues/408#issuecomment-152178971.

reopening for now;
I wonder if we need to cachebust the tabula.js file that sets the JQuery parameter that prevents caching JSON requests...

Much to my befuddlement and dismay, the new version worked perfectly for me on IE edge on Windows 10. I have one idea that I'll implement soon -- just the cachebuster on tabula.js, and then we'll test that out...
Sorry to make this a multi-attempt ordeal for all of y'all...

I should have mentioned we're still on Windows 7, sorry. That's probably part of the issue.

Did another browser work? (If so, I don't think the OS is the problem.)

Okeedoke, @mtigas, I added a cachebuster to ensure users get the latest tabula.js which includes the fix for IE's dumb caching behavior: 0783fe5
Can you rebuild when you get a chance?

Don’t have a Windows box to test on, but:
https://cdn.tig.as/dist/tabula/1.0/tabula-win-<IP_ADDRESS>-rc2.zip
Updated my local Java, so it's on Java 8u66 and not whatever I originally built 1.0.1 with (probably u65?). Probably doesn’t matter though.

@comprehenderic @pthartmann @Henry-E: Any chance one of y'all would be willing to test Mike's new build?  https://cdn.tig.as/dist/tabula/1.0/tabula-win-<IP_ADDRESS>-rc2.zip
Thanks!

I do hate to disappoint you but it still doesn't appear to work.

Isn't working for me either. Should mention, that along with IE 11, I'm on Windows 7.

Dammit. I'll try to find a VM and test on Win7... Thank you both, again, for generously testing these intermediate builds.

I'm not sure what changed but the build I downloaded on the 4th November appears to work on IE11 now. It didn't seem to work when I tried it out earlier.

Never mind. The PDF was only there because I uploaded it in another browser. Still can't upload files. The extract of cells and stuff works perfectly.

Hmm. I still haven't had a chance to test on a VM (i.e. I forgot...), so I'll try to get to this soon.

Okay. Thank you for your patience...
Can those of you on IE11 try out this build? https://www.dropbox.com/s/npvrzlx4lz0tn42/tabula-win.zip?dl=0
I was able to replicate the issue in a modern.ie VM and it looks like the bug is that IE is... a piece of software of questionable quality. In some cases, IE11 incorrectly serializes multipart form-data, which confuses Rack (a Tabula component). The solution is to add a "fake" form element at the end of the form, as I've done here: https://github.com/tabulapdf/tabula/commit/4d45f8961d33c2ad073d094d7fb5936f76b1d4b8#diff-993d50876f35e232013fe86cdcef31f2R269
This fixed the issue for me. If this works for you too, we'll merge this into master and rebuild.

Congratulations this appears to fix the issue in IE11

Hooray!

Oh, @mtigas, when you get a chance, could you rebuild Windows?


Variant template fallback

Shout out to @asgerb; this is practically a clone of #142, but with one commit from me that moves the logic to ActionView::Component::Base.call_method_name per Joel's comment.

👏 nice teamwork folks!


Visa Card 13 Digits Not Validating

Visa Card with 13 digits are not validating here:
Try VISA: 4222-2222-2222-2
Link: https://www.paypalobjects.com/en_AU/vhelp/paypalmanager_help/credit_card_numbers.htm
Below is a testing sample:

That doesn't really seem like an official PayPal URL. Here's what I see as the valid test cards with them. https://developer.paypal.com/tools/sandbox/card-testing/
This does bring up a good idea of allowing for custom card types so that I don't have to put in support for every possible card type out there. I'll probably work on that refactor

It just an example I share
VISA 13 digit is an official card being used around
I shared the link to try a card number I didn't claim whether its an official link or not

I understand. I'll keep close this issue in favor of the new one I made in the credit_card_type_detector repo that allows for creating custom card types or modifying the built-in card types

Understood


Component gets mounted twice when using with redux-saga

I have a redux-saga which yields a put() action with push("/") from connected-react-router as an argument in reaction to LOGIN_SUCCESSFUL action. I can see that LOCATION_CHANGE appears once in Redux dev tools, but the component which gets loaded on / route will be mounted twice.
I don't honestly know where to start debugging this issue, but has anyone experienced something similar?

Yes, I'm experiencing the exact same problem. I don't know how to solve this.

I made a quick and dirty demo, but looks like I'm not able to repeat the issue.

It should be fixed in v6.1.0. Feel free to re-open this issue if the problem still exists.


feat: RandomTranslateVolumetricIndex

@nkemnitz I'll close this for now.
If you'd like to re-open this, it should be much easier to make it fit -- IndexAdj is not a thing now, a simple callable that takes and returns and Index is sufficient.


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Codecov Report

Merging #500 into master will increase coverage by 0.74%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   71.85%   72.59%   +0.74%
==========================================
  Files           1        1
  Lines         135      135
==========================================
+ Hits           97       98       +1
+ Misses         38       37       -1

Impacted Files
Coverage Δ

src/service-consul.js
72.59% <0%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201bb33...0885d4c. Read the comment docs.

Coverage decreased (-0.5%) to 65.241% when pulling 0885d4c8d8ce47c0c940dbfb7732e5aae5ce6123 on template-sync-1 into 201bb3305c064781a3427a8b55fe5961482fe28f on master.

:tada: This PR is included in version 2.20.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support CamAPS and Glooko API

Some users use a FreeStyle Libre 3 sensor together with a mylife YpsoPump and the app CamAPS from CamDiab.
If that is the case the Libre 3 app CANNOT be used anymore as the sensor has to be started within the CamAPS FX then so LibreLinkUp is not available.
The CamAPS FX app has the option to share the glucose details to other CamDiab users and/or Glooko.
Let us evaluate if it would be possible to support one or both platforms inside LibreLinkUpDesktop.

I will contact both companies.
Glooko says

Direct API Integrations are available to Glooko's US, Canada, and EU-based commercial customers, and access depends on each customer's subscription model. Individual user API access is not available

on the API docs.
I did not find an API from CamDiab yet.
But it is always good to ask.


Update code license statements

Signed-off-by: Steve Winslow<EMAIL_ADDRESS>

@fayazg @dealako This is to update the code license notices.


Bugfixes for non-insiders

Now that the creators update is out of the door I see a lot of new issues being raised here.
So I was wondering: Are you planning to release bugfixes (not talking about new features) to the non-insider Version of Win10 or do we have to again wait until the next upgrade?

@MikeGitb:
This is an issue under discussion since the beginning, the last reference you can find it here: https://github.com/Microsoft/BashOnWindows/issues/1821

@iz0eyj: Thanks for the link, but what I'm asking is a little bit different:
I don't expect new functionality (like supporting new system calls / system call options) being introduced via regular updates to the non-insider versions (although I would very much appreciate if they did).
But I wonder if actual bugs in the implementation might receive fixes (e.g. something like #1882 ord BSODs or any regressions relative to the AU)

@MikeGitb:
I think it is impossible because the debugging WSL involves a kernel-level changes, therefore suitable only to the distribution in the ring Insider Fast.
At least that is my idea.

@MikeGitb - I think this is a very fair question. I feel that security and reliability bugs, and bugs causing bash to fail to install or launch are good candidates for bug fixes that are targeted at the current release.  We'll have to see how amenable the servicing team is though, the ball is largely in their court.


BewitRegistrationBuilder.GetRepository should be of Type Func<IServiceProvider, INonceRepository> to facilitate the use of registered services

Is your feature request related to a problem? Please describe.
Currently, the property BewitRegistrationBuilder.GetRepository is of type Func<INonceRepository>. This comes with certain limitations, as it is therefore not easily possible to consume services from the serviceProvider during the initialization of the NonceRepository.
Example from the MongoDB persistence package:
        public static BewitRegistrationBuilder UseMongoPersistance(
            this BewitRegistrationBuilder builder,
            BewitMongoOptions options)
        {
            ...
            var client =
                new MongoClient(options.ConnectionString);
            IMongoDatabase db =
                client.GetDatabase(options.DatabaseName);

            builder.GetRepository = () => new NonceRepository(
                db, options.CollectionName ?? nameof(Token));

            return builder;
        }

Describe the solution you'd like
BewitRegistrationBuilder.GetRepository should be of type Func<IServiceProvider, INonceRepository>. That way we could use registered services to initialize the NonceRepository:
builder.GetRepository = (ctx) => new NonceRepository(
                ctx.GetRequiredService<IMongoDatabase>(), options.CollectionName ?? nameof(Token));

We can keep the old implementation and add an overload to don't introduce a braking change


ENYO-5687: Enact core Job.idle() should stop an existing job before scheduling a new job

Checklist

[x] I have read and understand the contribution guide

[x] A CHANGELOG entry is included

[x] At least one test case is included for this feature or bug fix

[x] Documentation was added or is not needed

[ ] This is an API breaking change

Issue Resolved / Feature Added
It is possible for a race condition to be exposed when multiple calls to a Job's idle method are executed when the main thread is overloaded and finally released.  Multiple jobs can end up with the same id and if the component that the Job is operating on is unmounted at the time the thread is released, a console warning can occur:
Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

Resolution
Job's idle method is updated to stop any existing jobs before scheduling a new one.
Links
ENYO-5687
Enact-DCO-1.0-Signed-off-by: Dave Freeman<EMAIL_ADDRESS>

I discovered that the change to properly fallback to startAfter prevented us from testing the fix to call stop() so I added a requestIdleCallback polyfill to the test so we can verify that the type === 'idle' code paths run correctly.

@rundmt + @sugardave - Good reminder to ensure that Travis clears before moving it along. I understand that sometimes we hand off PRs before Travis clears (I've done it too!) but we need to keep an eye out and avoid moving tickets to integration with failing CI.
In this case, the change to fall back to startAfter rather than running the job immediately (a good change) caused another test (ExpandableList) which made an incorrect assumption to fail. All fixed up now and ready to go! :shipit:


Add Ansible Collection to server start

https://issues.redhat.com/browse/ISPN-13744

Merged, thanks


Co-maintainer offer

I am interested in being a co-maintainer of Minimist to provide some redundancy and extra expertise.
I have a particular interest in CLI. I maintain Commander.js, and helped develop parseArgs which is now included in Node.js. I have been watching Minimist for a couple of years to see what issues were coming up, and have done some digging in the code while researching behaviours across multiple CLIs.
(I know you already know my credentials @ljharb , but applying in the open!)

Sounds great, let's wait a bit to see if I can recover the original minimist repo with issues/PRs, but once that's resolved one way or the other, I'll add you to the relevant places.

@ljharb what happened to the old repository btw?

@unvented the original author deleted their github, and thus all the associated repositories.

@unvented the original author deleted their github, and thus all the associated repositories.

oh ok 🙁

I am still interested in Minimist. It has been a couple of months, so I expect the original repo with issues is not coming back?

I think that's a safe expectation. I'll add you to the repo!

I now have maintainer access on GitHub (thanks). But have no access on npmjs.com yet, so I couldn't do a release if you were unavailable for a long time.
I would like to also be a lifter for Minimist on TideLift. (Don't know if you had thought of that, so raising it before I do anything about it!)
Plans: I have one more historical bug in Minimist I would like to investigate and hopefully fix (bad numeric conversions for large "numbers"), and interested in discussing when and how we might release current PR, but not in any rush. The issues are all very long-standing.

@shadowspawn let's chat about that stuff on a call sometime this week.

Update: I had a good chat with @ljharb about outlook on Minimist in particular and package maintenance in general. Jordan was very gracious about me onboarding to Minimist. I have write access to git and npm so capable of independently publishing a release, if necessary. (I won't be publishing normally.)


community[patch]: pass through sql agent kwargs

Fix #19961

@baskaryan Did the PR get approved? What I need to do (e.g. which package I need to upgrade) to implement the fix? Thanks for your great help. Hope this works!


Improved MultipartFileUpload a small bit

Hiya!
This is from our discussion here @tipsy
I didn't realize that contentLength was the filesize.
You might want to consider changing contentLength to a long(breaking change), because files can be huge!
This also gets covered by the Multipart tests 😄

We can't introduce breaking changes, so we could instead include something like contentStream and contentStreamLength, and make bytes lazy ?

Hi,
I like that idea. Maybe mark contentLength as deprecated and add UploadedFile.size?
As of now the max upload contentLength is 2.15 GB.
And another question, I have no idea why build is failing...I reverted the changes and got the same result

There is something wrong with the test that's failing, it started being flaky when we moved from Travis to Github Actions. It's not related to your change.

Maybe mark contentLength as deprecated and add UploadedFile.size?

Sounds like a plan!

Done!

Thanks!

Thanks ! This has been released now - https://javalin.io/news/2019/11/03/javalin-3.6.0-released.html


Set Focus time as private

I`d like to have a option to set "Focus time" as private.

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Receiving resultType of PINRemoteImageResultTypeDownload when offline and no image is downloaded

I expect that when I get a result in my completion block with a non-nil error, and a nil image, the resultType should be PINRemoteImageResultTypeNone - no image was downloaded, after all.
However, with my iPad in Airplane mode, I get PINRemoteImageResultTypeDownload.
This happens because the result type is assumed to be a successful download if a cache miss occurs, regardless of the error state or images existence.
Is this expected behaviour?

It would be nicer to return PINRemoteImageResultTypeNone. I'd happily accept a pull request!

Great, I'll get one your way this weekend.
On 10 Oct 2015 14:53, "Garrett Moon"<EMAIL_ADDRESS>wrote:

It would be nicer to return PINRemoteImageResultTypeNone. I'd happily
accept a pull request!
—
Reply to this email directly or view it on GitHub
https://github.com/pinterest/PINRemoteImage/issues/68#issuecomment-147116754
.


Add support for clipboard input

Would be great to support both text and image contents in clipboard. Would make it a lot easier to ingest information through the clipboard (since we don't support multi-line strings, you currently have to paste contents to a file, or a path to the screenshot).
Suggested by /u/Either-Nobody-3962

We'd dump the image contents to a tmp file and attach it to the message like any other vision message.

With #244 we now support pasting multiline strings thanks to prompt-toolkit, so the priority on this is now less.

Cool. I guess only the use case now is the screenshot input.


Paket 4.x install command takes hours to complete (while 3.x takes minutes)

Description
Paket 4.x install command takes a very long time to process my paket.dependencies. I let it run for ~hour and then just killed it. Paket 3.x handled it without problems.
I'm on windows.
Repro steps

Clone https://github.com/pmbanka/paket-perf-repro
Run paket_old.exe install
git add .; git reset --hard
Try running paket.exe install

Expected behavior
Both versions should end running in short time.
Actual behavior
paket.exe install takes > 1h
Known workarounds
Use Paket 3.x.

/cc @cloudRoutine I assume it's related to the resolver change. Any chance you could take a look?

I was a bit bored, so I let the profiler run for a while parallel to my normal work.

The 30% inclusive in String.Concat is slightly concerning.

I think there are a few big quick-wins, will try to send a pr in a few minutes.

haha. we should remove verbosefn completely!

After eliminating that:

yep very nice! The bug report really indicated some algorithmic problem (like the graph list you found, instead of the string concat). thanks for looking into this. I'm really waiting for these improvements :) (you saved me from some work I wanted to do eventually, thanks!)

r.Graph is currently a List, I will try to convert that to a set.

I'm not sure if order is important. And I think the issue is equality checks on Requirements. they are very slow

@forki, yup, 43% of total time is Requirements.Compare. Luckily that compare function should have a bit of potential for improvements.
Changing list to set didn't improve it noticeably.

that verbosefn was essential in diagnosing issues when I rewrote the resolver to be tail recursive. That being said I still think we should have another level of detail above verbose like diagnosticfn

@cloudRoutine see https://github.com/0x53A/Paket/commit/2251ab34554fd3961dd0f3ec1366ac920abde0d0, that fixed it without affecting logging.

Yes that's the correct fix. Verbosefn should go completely
Am 26.04.2017 20:41 schrieb "Lukas Rieger"<EMAIL_ADDRESS>
@cloudRoutine https://github.com/cloudRoutine see 0x53A@2251ab3
https://github.com/0x53A/Paket/commit/2251ab34554fd3961dd0f3ec1366ac920abde0d0,
that fixed it without affecting logging.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/2289#issuecomment-297503941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNFovpUqzHeaw5D4mV84wSAyXeHEvks5rz4_lgaJpZM4NI1d6
.

So I'm not familiar with the Resolve algorithm, but I feel like it goes bonkers somewhere.
One example: it considers these two versions of SourceLink.Fake at the end, but the highest one doesn't have any requirements and so should be an automatic match!

Or is that expected?

@0x53A you're right it is going mad at some point and it's done that for a long time, I never was able to identify the reason behind it and the last time I worked on the resolve function I was focused on eliminating the stack overflows and never got around to fixing this part

since appveyor just failed due to a goddamn timeout on package resolver spec I included this change on https://github.com/fsprojects/Paket/pull/2267/commits/ef3f1c49ea1e77ccecf987f4eaa904e79a7b9f9e

I tried a few things, the ones that seemed to improve performance are pushed to https://github.com/0x53A/Paket/tree/perf, but in general I think the algorithm should be fixed first.
If none of you beat me to it, I will try to reduce the repro tomorrow, and maybe figure out what's wrong with the resolver.

So I was able to reduce it:
redirects: on
framework: net46

source https://api.nuget.org/v3/index.json

nuget FsCheck.Nunit
nuget NUnit ~> 2

nuget Suave

Paket version 4.8.4
Resolving packages for group Main:
 - NUnit 2.6.4
 - FsCheck.Nunit 2.8.0
 - Suave 2.1.0
 - Suave 2.0.5
 - Suave 2.0.4
 - Suave 2.0.3
 - Suave 2.0.2
 - Suave 2.0.1
 - Suave 2.0.0
 - Suave 1.1.3
 - Suave 1.1.2
 - Suave 1.1.1
 - Suave 1.1.0
 - Suave 1.0.0
 - Suave 0.33.0
 - Suave 0.32.1
 - Suave 0.32.0
 - Suave 0.31.2
 - Suave 0.31.1
 - Suave 0.31.0
 - Suave 0.30.0
 - Suave 0.29.1
 - Suave 0.29.0
 - Suave 0.28.1
 - Suave 0.28.0
     Suave 0.28.0 was unlisted
 - Suave 0.27.0
 - Suave 0.26.2
 - Suave 0.26.1
 - Suave 0.26.0
 - Suave 0.25.0
 - Suave 0.24.0
 - Suave 0.23.0
 - Suave 0.22.0
 - Suave 0.21.1
 - Suave 0.21.0
 - Suave 0.20.2
 - Suave 0.20.1
 - Suave 0.20.0
 - Suave 0.19.1
 - Suave 0.19.0
 - Suave 0.18.0
 - Suave 0.17.0
 - Suave 0.16.0
 - Suave 0.15.0
 - Suave 0.14.0
 - Suave 0.13.0
 - Suave 0.12.0
 - Suave 0.11.0
 - Suave 0.10.0
 - Suave 0.9.0
 - Suave 0.8.0
 - Suave 0.7.0
 - Suave 0.6.0
 - Suave 0.5.0
 - Suave 0.4.0
 - Suave 0.3.0
 - Suave 0.2.0
 - Suave 0.1.78
 - Suave 0.0.5
 - Suave 0.0.4
 - Suave 0.0.3
 - Suave 0.0.2
 - Suave 0.0.1
     Suave 0.0.1 was unlisted
 - FsCheck.Nunit 2.7.2
 - FsCheck.Nunit 2.7.1
 - FsCheck.Nunit 2.7.0
 - FsCheck.Nunit 2.6.3
 - NUnit.Runners 2.6.4
 - FSharp.Core 4.1.12
 - FsCheck 2.8.0
 - System.ValueTuple 4.3.0
Locked version resolution written to C:\Users\lr\Source\Repos\paket-perf-repro\paket.lock
Garbage collecting Akka
Garbage collecting Akka.TestKit
Garbage collecting Akka.TestKit.NUnit
Garbage collecting Newtonsoft.Json
Garbage collecting System.Collections.Immutable
5 seconds - ready.

REDIRECTS: ON
FRAMEWORK: NET46
NUGET
  remote: https://api.nuget.org/v3/index.json
    FsCheck (2.8)
      FSharp.Core (>= <IP_ADDRESS>)
    FsCheck.Nunit (2.6.3)
      FsCheck (>= 2.6.3)
      NUnit (>= 2.6.4 < 2.7)
      NUnit.Runners (>= 2.6.4 < 2.7)
    FSharp.Core (4.1.12)
      System.ValueTuple (>= 4.3)
    NUnit (2.6.4)
    NUnit.Runners (2.6.4)
    Suave (2.1)
      FSharp.Core (>= <IP_ADDRESS>)
    System.ValueTuple (4.3)

If you try to reproduce it yourself, you need to always delete the lockfile so that it will start with a clean slate.
As you can see, even if it is now able to resolve it, it still demonstrates that strange behaviour of testing all different versions of suave.

I got a bit further debugging this:
It (successfully) resolves the following Requirements:
NUnit 2.6.4
FsCheck.Nunit 2.8.0
Suave 2.1.0
then it tries to resolve NUnit < 3, but finds a conflict.
So it goes back one step, to Suave, and loops over all versions of Suave.

So I think (I hope) I solved it:
The full initial paket.dependencies:
Locked version resolution written to paket.lock
37 seconds - ready.

the relevant change is fuseConflicts:
https://github.com/fsprojects/Paket/compare/master...0x53A:perf#diff-781e85b03afcc7c6cedfbd46e3d3b607R659
Instead of just going back one step, I try to find a step that matches the current conflict.

@0x53A This now also resolves with https://github.com/fsprojects/Paket/pull/2307 So I'm really looking forward to combining your perf improvements with the fix :)
Locked version resolution written to C:\PROJ\paket.test\paket.lock
1 minute, 9 seconds - ready.

Omg I merged your branch and get exactly the same :(. Seems like my fix/additional change neglects your improvements?!
Locked version resolution written to C:\PROJ\paket.test\paket.lock
1 minute, 9 seconds - ready.

I just wanted to say thank you to everyone working on the issue. Watching you resolving this from a poor repro in just a few days made my jaw drop on the floor. You are awesome and I hope next time I'll be able to help and participate more!


Cut segements without re-encoding

Hi WyattBlue,
love, love, love auto-editor. Thanks for the mention on the contributors page. I was wondering how I could contribute more. Maybe I can do so short tutorials or work a little on the docs.
So here is what has been bugging me the last weeks. I auto-edit a lot a videos. Usually tutorials by myself. Some of them are very long. I would like to know if there is a way to cut the parts without re-encoding them. Or get a list of timestamps with which I could "extract" the parts myself. For example this 3 minute 4k clip took almost 5 minutes to finish:
PS C:\home\Videos\Trading> auto-editor clip.mkv --no_open --ffmpeg-location C:\bin\ffmpeg.exe --export clip-sequence -vcodec copy --margin 1sec --show-ffmpeg-commands
C:\bin\ffmpeg.exe -hide_banner -y -i clip.mkv -map 0:a:0 -ac 2 -ar 48000 -rf64 always C:\Users\ebach\AppData\Local\Temp\tmpfwlhxrzp\0.wav -nostats -loglevel error

C:\bin\ffmpeg.exe -hide_banner -y -f rawvideo -c:v rawvideo -pix_fmt yuv420p -s 3840*2160 -framerate 60 -i - -pix_fmt yuv420p -b:v 10M -c:v hevc -movflags faststart -vf setsar=1 C:\Users\ebach\AppData\Local\Temp\tmpfwlhxrzp\spedup0.mp4

# TRUNCATED OUTPUT

C:\bin\ffmpeg.exe -hide_banner -y -i clip.mkv -i C:\Users\ebach\AppData\Local\Temp\tmpfwlhxrzp\spedup0.mp4 -i C:\Users\ebach\AppData\Local\Temp\tmpfwlhxrzp\new0.wav -map 1:0 -map  -color_trc unknown -strict -2 -map 0:t? clip_ALTERED-8.mkvc:a aac -color_range tv

Finished. took 290.59 seconds (0:04:51)

What else can I do expect -vcodec copy to ensure that it doesn't get re-encoded? I was thinking of taking the output of --export shotcut and trying to create a script and use ffmpeg myself. But maybe this is not necessary.
I actually tried using the shotcut timestamps to slice the original file:
C:\bin\ffmpeg -copyts -i clip.mkv -c copy -ss 00:00:11.283 -to 00:00:14.850 output1.mkv
...
C:\bin\ffmpeg -copyts -i clip.mkv -c copy -ss 00:02:54.817 -to 00:02:59.633 output9.mkv

The results were not good. I think this has to do with the keyframes, but I am not sure.
Any ideas?
Greetings
Saša

Your suggestion is very reasonable.
I don't think using the ffmpeg cli is a reasonable approach for implementation. A better approach would be to use PyAV and copy the video packet if no modification is needed. This is pretty involved on my end, however, so I'll circle back on this eventually.


Update editor's guide: image\document collections

Would be great to cover image\document collections in editor's guide.
Related PR: #2243

Closing this as it was resolved via #5385
I just reviewed the docs currently and walked through the images, they are all still accurate as of October 2019
http://docs.wagtail.io/en/v2.6.2/editor_manual/documents_images_snippets/collections.html


Add Travis CI gating

Gate PRs against unit tests against py27,py37,pep8.

This was done with #24


Feature #1 - Data Model

Description
This pull  request creates the migration files for the data model of the app
Task: https://github.com/microverseinc/curriculum-rails/blob/main/blog-app/projects/creating_data_model_project_v1_1.md
This PR makes the following changes:

Create the classes for all the tables
Create the relationship of the foreign keys

Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist

[X] My code follows the style guidelines of this project (no linters errors)
[X] I have checked my code and corrected any misspellings
[X] I have commented on my code
[X] I have deleted any unused code as comments in my codebase

@rloterh Hi, thank you very much for the feedback, I'll try right away to fix them.

@emmanuellekamwa Thank you!!


Use the database category value for Elasticsearch model

Fixes

Fixes #710 by @obulat
Description

On the first implementation of filtering by category, catalog database did not have the category field.
Then, the API implemented a computation of the category. However, because of the order of code computation, the computed value was (anyways) overwritten by the value in the upstream database, even if it was None.
This PR removes the categorize module for category computation because it is done by the catalog.
Testing Instructions

Note: I could not run just init from this branch. The only way I could test this branch is by using the changes to load_sample_data script from #830.
Testing this PR
To test that the code uses category from the database, change sample_image.csv items. You would need to replace the second last item in the rows with either digitized_artwork or illustration. Then, run just init and go to http://localhost:8000/v1/images/?category=digitized_artwork,illustration. You should see two results.
Testing that category computation does not work
You can see that the current code always replaces the computed category (including illustration for .svg items, and default for provider, such as digitized_artwork for clevelandmuseum).

Checkout the main branch.
Change sample_image.csv items. In the first item, we set category to None (by deleting the second from last item in the row) and replace the provider and source with clevelandmuseum. If the code was implemented correctly, the image category would be set to digitized_artwork as the default category for clevelandmuseum. In the second item, set the URL extension to .svg, and delete the categoryvalue. The category for items with svg extension were supposed to be set to illustration. You can simply the first 2 lines in sample_image.csv with the copy below:

0e3315c5-3328-4a99-80ab-567ac32f685f,2021-12-15 20:49:19.976193+00,2021-12-15 20:49:19.976193+00,provider_api,clevelandmuseum,clevelandmuseum,51745822704,https://www.flickr.com/photos/54633257@N04/51745822704,https://live.staticflickr.com/65535/51745822704_ae97226e20_b.jpg,https://live.staticflickr.com/65535/51745822704_ae97226e20_m.jpg,433,1024,97150,by-nc-sa,2.0,mexicofist3,https://www.flickr.com/photos/54633257@N04,my dress is not very short,"{""views"": ""5991"", ""pub_date"": ""1639443671"", ""date_taken"": ""2021-07-20 18:19:25"", ""description"": ""dressed"", ""license_url"": ""https://creativecommons.org/licenses/by-nc-sa/2.0/"", ""raw_license_url"": null}",,f,2021-12-15 20:49:19.976193+00,f,jpg,,0.9989994997498749
b840de61-fb9d-4ec5-9572-8d778875869f,2021-12-15 20:49:19.976193+00,2021-12-15 20:49:19.976193+00,provider_api,flickr,flickr,51745349583,https://www.flickr.com/photos/129684398@N07/51745349583,https://live.staticflickr.com/65535/51745349583_cebf1fa6e0_b.svg,https://live.staticflickr.com/65535/51745349583_cebf1fa6e0_m.jpg,1024,713,171956,by-nc,2.0,clairetresse,https://www.flickr.com/photos/129684398@N07,Barranco de las bodegas,"{""views"": ""4156"", ""pub_date"": ""1639440673"", ""date_taken"": ""2021-10-28 10:54:43"", ""description"": ""Descente dans un des Barranco, descente prudente parce que ça glisse. L’érosion des sols est extrêmement puissante, les reliefs sont sculptés par les forces de la nature telles que le vente les pluies . Descent in one of the Barranco, careful descent because it slips. The erosion of the soil is extremely powerful, the reliefs are sculpted by the forces of nature such as the rains."", ""license_url"": ""https://creativecommons.org/licenses/by-nc/2.0/"", ""raw_license_url"": null}","[{""name"": ""bardenas"", ""provider"": ""flickr""}, {""name"": ""barranco"", ""provider"": ""flickr""}, {""name"": ""desert"", ""provider"": ""flickr""}, {""name"": ""espagne"", ""provider"": ""flickr""}, {""name"": ""glaise"", ""provider"": ""flickr""}, {""name"": ""navarre"", ""provider"": ""flickr""}, {""name"": ""pyrennees"", ""provider"": ""flickr""}, {""name"": ""ravin"", ""provider"": ""flickr""}, {""name"": ""roches"", ""provider"": ""flickr""}, {""name"": ""water"", ""provider"": ""flickr""}]",f,2021-12-15 20:49:19.976193+00,f,jpg,,0.9985583853916387

If you run just init on main with these lines, and search for digitized_artwork items (http://localhost:8000/v1/images/?category=digitized_artwork), you will not get any results.
And if you replaced the last line here:
https://github.com/WordPress/openverse-api/blob/9eb73b27014925c9d24acf77dbd143060e1ee7a1/ingestion_server/ingestion_server/elasticsearch_models.py#L232-L234
with
category = row[schema["category"]] or category
you would see that the category falls back to the computed value if the database category is NULL.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat how does this PR relate to PR #839?

@obulat how does this PR relate to PR #839?

It is related only insofar as both steps are run during the data refresh process, and both PRs would simplify and speed it up. However, the big difference is that #839 is blocked because the upstream database needs to be cleaned up before removing the API clean up process, but this PR can be merged as is. The computed category information was mostly unused by the API, and upstream has a lot of the computed category data.


Use orquestra python dev

Description
Currently, we use dev requirements (e.g. black, mypy, flake8) specified separately in each project. This PR replaces those separate package dependencies into a centralized one managed by us: orquestra-python-dev.
Please verify that you have completed the following steps

[x] I have self-reviewed my code.
[ ] I have included test cases validating introduced feature/fix.
[ ] I have updated documentation.

Codecov Report

Merging #25 (c09a1be) into main (ff315d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   94.23%   94.23%
=======================================
  Files          68       68
  Lines        5519     5519
=======================================
  Hits         5201     5201
  Misses        318      318

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff315d2...c09a1be. Read the comment docs.


Feature/tabular

This PR:

adds a design first to document how users can edit FHIR data using tabular representation
adds a test first set of tests to illustrate test expectations
linked to user facing documentation here

#29

A little concerned with the deep-merge library being a dependency issue in the future, but also recognize that there aren't many/any libraries that do specialized python dict merging operations that are super well maintained
General architecture/user story seems adequate.

@matthewpeterkort @lbeckman314
Validation exception caused by version drift in fhir.resources dependency, which in turn was caused by this branch not properly based on development branch.  Closing this PR, deleting this branch and re-opening on new branch #32 32


Add health-check-cn.md

add health-check-cn.md
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
Summary
补充中文文档
Full changelog

增加健康检查中文文档

Issues resolved
Fix #1728


You never mentioned that this package does almost nothing, frankly speaking...

...and, actually, doesn’t do anything with Angular. And hence its name, that’s quite weird.
All you suggest here is an opinioned simple template of api call responses.
However, Angular can consume Laravel API right out of the box.
I don’t understand why people star it at all.

Hi @zhekaus
Thanks for opening an issue!
This repository is for the Laravel package
The Angular package was supposed to go in angular-laravel
However I never had the time to work on it due to time constraints
If you can send in a contribution, I'd be happy to work with you on it! 😄
Indeed Angular can consume Laravel API right out of the box, it's nowhere claimed the opposite. However this package helps you return consistent responses for errors and success based on the response macro described in the documentation.
I'm waiting for the package to evolve with feedback from the community, so if you've got any feature suggestion, feel free to create one!
Cheers

The only reason to have such a thingy as laravel-angular is having working-out-of-the-box demo with
self-sufficient tutorial.
That what people really need. That what is still absent for tymondesigns/jwt-auth version 1.0
I saw your laravel-angular.io, indeed. And it is far from being completed. Currently it simply contains copy-pasts from origins. However, thanks so much, it gives the idea and it is a good start: for you – to create something really useful, for others, currently – to follow the origins and comprehend them there.
Nonetheless, I don’t see any use in any kind of laravel-angular package though.

I'm going to have time to work on it again very soon, so I've you come up with new specific features that you think are nice to have, please open a new issue on either one of the repositories
Cheers!

It will be good to have one user interface for developing apis like
loopback node js framework .
On Dec 3, 2017 4:00 PM, "Jad Joubran"<EMAIL_ADDRESS>wrote:

I'm going to have time to work on it again very soon, so I've you come up
with new specific features that you think are nice to have, please open a
new issue on either one of the repositories
Cheers!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jadjoubran/laravel-angular/issues/11#issuecomment-348754683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK7T3cCEZIYgvXASsjBcP-TOtW6OczJtks5s8nhdgaJpZM4Qs6J0
.


Fix a bug in rbac adapter to evaluate the properties correctly.

Fix #6012.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
Assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test e2e-pilot-noauth-v1alpha3-v2

/retest

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests.sh
3af301a9148b11bc0042e79ca98122635c62ac8e
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


TADA_CalculateTotalNP should use TADA.MonitoringLocationIdentifier if it exists in data frame

Is your feature request related to a problem? Please describe.
Currently, the TADA_FindNearbySites identifies sites within some buffer distance of each other and assigns them a TADA.MonitoringLocationIdentifier which concatenates the two original MonitoringLocationIdentifier's, but it does not automatically harmonize them to one site's metadata (name, latitude, longitude, organization, and many more... ??). This is difficult when subsequent functions (like total NP summation) depend upon monitoring location identifier as a grouping variable to define total N or total P summations.
Which site metadata (name, latitude, longitude and...??) should TADA_CalculateTotalNP assign these totals to if they should come from multiple nearby sites?
Describe the solution you'd like
The TADA_CalculateTotalNP in Transformations.R already mentions the TADA_FindNearbySites function (lines 233 and 319) but it is not directly used within the function yet.
To start/for now, TADA_CalculateTotalNP can be updated as follows:

When creating new rows with the TN and TP results, TADA_CalculateTotalNP could use the TADA.MonitoringLocationIdentifier if it exists in the data frame as a grouping variable by default, and use MonitoringLocationIdentifier instead if TADA.MonitoringLocationIdentifier does not exist (meaning TADA_FindNearbySites  was not run first & is not applicable).
Metadata does not need to be carried through to the new row and users can go back to original rows to see metadata from the two different sites/organizations.

Describe alternatives you've considered
This option is more complicated and if needed, could be created as a separate issue to address later after further discussions with the TADA Working Group about requirements.

Additional site metadata (name, latitude, longitude, organization(s), and...??) could be carried through to the new row.

Option A: The function could have an organization hierarchy like the duplicate functions and could preferentially pick the best-ranked organization to provide the key metadata (both for organization and site metadata elements) needed to merge sites to one. Result information should remain distinct.
Option B: The function could concatenate site and organization metadata to carry both through to the new row.
Reminders for TADA contributors addressing this issue
New features should include all of the following work:

[ ] Update the function/code.

[ ] Document all code using comments to describe what is does.

[ ] Create tests in tests folder.

[ ] Create help file using roxygen2 above code.

[ ] Create working examples in help file (via roxygen2).

[ ] Add to or update appropriate vignette (or create new one).

@hillarymarler this is related to the discussion we had about creating TADA.MonitoringLocationIdentifier as part of autoclean at the start. Once that is implemented, then all TADA functions including this one can reference that instead of the original MonitoringLocationIdentifier.

I will work on this as part of the pull request that also creates TADA.MonitoringLocationIdentifier


Pluggable parser support

Would it be possible to decouple the main logic from parsing itself and provide support for pluggable parsers similarly to ESLint? As far as I understand, they're not hardly linked so far, so should be possible to do as soon as parser emits same AST and tokens format.

Yeah I think so. Don't know when I'l be able to merge https://github.com/cst/cst/pull/73. I'm not sure what we would do about how object rest/spread is different in eslint.

How is it different?

Nvm the ast is the probably same I just was thinking we had to map the type to SpreadProperty and RestProperty

As far as I understand, they're not hardly linked so far, so should be possible to do as soon as parser emits same AST and tokens format

Since now we are using babylon and it seems babylon will never output same AST/tokens.

That's pretty sad. Can't you use ESTree standard and convert from anything else using adapters that already exist for ESLint?

That's pretty sad.

Totally :/
I guess it could be done as a plugin (plugin system should be done after the next weekend), that plugin could convert and provide different parser.

that plugin could convert and provide different parser

Except that ESLint has bunch of adapters (Acorn, Babylon, Esprima, even TypeScript) around it already that could be reused, while plugin would need either to add enother level of abstraction between them and cst or each adapter needs to be reimplemented as plugin for cst :(

So... do you have an idea how to make it work?


Downgrade Circle CI to use 2.0

None of the 2.1 features are currently being used, so revert back to the older version to attempt to improve stability.

Thanks for looking into this @danrbailey. Do we know this for certain to be the fix or is this just a test? A comment in the yml would be good too

Thanks for looking into this @danrbailey. Do we know this for certain to be the fix or is this just a test? A comment in the yml would be good too

I just don't know - going to re-submit this PR now.


Investigate why _enqueueMicrotask breaks on IE8

Internal functions required by the polyfills should be available on all browsers. When we made this change for _enqueueMicrotask it broke on IE8 (https://github.com/Financial-Times/polyfill-service/commit/598f48770365cecfa7f0ec76f36ebca7bdfa8aef). This issue is to investigate why it breaks. For the time being we will switch the range back to IE9 and above.

I also get the _enqueueMicrotask is not defined error when loading from the following UA (iPad):
Mozilla/5.0 (iPad; CPU OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53

Happens for me with any bundle that includes Promise, e.g.
https://cdn.polyfill.io/v1/polyfill.js?features=default,Promise

@callumlocke your particular issue is fixed in the RC (http://qa.polyfill.io/v1/polyfill.js?features=default,Promise&ua=Mozilla/5.0 (iPad; CPU OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53)
Will be going live after the QA grace period.

We no longer have an enqueuemicrotask polyfill

Why was the _enqueueMicrotask polyfill removed? I recall some discussion about setImmediate not being the correct fallback. Is there an issue you can point me to to learn more about what happened?

We continued to support setImmediate for compatibility, because once we have a polyfill it's hard to remove it. Also the Promise polyfill we're using piggybacks on a setImmediate implementation, so we were previously having to modify the polyfill to hook it up to enqueueMicrotask.  Just using setImmediate means we can modify the polyfill less.


RequestOptions UseCookieJar seems not in use

It seems that RequestOptions UseCookieJar parameter is specified but not used.
func BuildHTTPClient always use a cookie jar

Hi @aolu11
I don't understand what you are asking, can you please be more specific in your question? Right now, the library will use http.Client if you don't request any http.Client modifications.
func (ro RequestOptions) dontUseDefaultClient() bool {
	return ro.InsecureSkipVerify == true ||
		ro.DisableCompression == true ||
		len(ro.Proxies) != 0 ||
		ro.TLSHandshakeTimeout != 0 ||
		ro.DialTimeout != 0 ||
		ro.DialKeepAlive != 0 ||
		len(ro.Cookies) != 0 ||
		ro.UseCookieJar != false
}

Will return true if a new http.Client is needed

@levigross
I mean, when we specify some custom request options, dontUseDefaultClient() will return true, and we still do not need cookie, so we set the UseCookieJar to false
but BuildHTTPClient will always create a cookieJar and ignore the UseCookieJar option, like:
cookieJar, _ := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List})
And
return &http.Client {       jar: cookieJar     //... }
Am i miss something?

No you are not missing anything. I have just pushed a fix for this. Enjoy!


When will this be available on mainnnet?

Hi guys,
This is Garvit from Electron. Thanks for doing this awesome work here. We are interested in using this, and just wondering if you are aware of any timeline on when this will be available on mainnet?
And is there any stop gap solution meanwhile?

It seems that this has already been available on the mainnet (aka mainnet beta) since mainnet is in v1.16 now.

Ok. Correction. Someone from Elusiv told me that you need to wait until the end of the year.

The feature is still not active on mainnet, probably March/April. You can already use it on devnet.


How to get invited into Kotlintest Slack Channel?

From the REAMDE, there's a link towards the Kotlintest Slack Channel, but there is no link on how to join it.

We use the public KotlinLang slack. To get an invite, check http://slack.kotlinlang.org/


(2/3) RUM-392 refactor shared android library build script

What does this PR do?
This PR refactor the build.gradle.kts buildscript for all our libraries to extract shared configurations and make it easier to:

create new libraries
add build features to all libraries

Motivation
This is part of our effort on improving our test suites across the mobile teams

Codecov Report

Merging #1667 (172b18f) into xgouchet/RUM-392/1_shared_core_fixtures (eea183c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                             Coverage Diff                             @@
##           xgouchet/RUM-392/1_shared_core_fixtures    #1667      +/-   ##
===========================================================================
- Coverage                                    83.72%   83.71%   -0.01%
===========================================================================
  Files                                          459      459
  Lines                                        15775    15778       +3
  Branches                                      2353     2354       +1
===========================================================================
+ Hits                                         13207    13208       +1
- Misses                                        1938     1943       +5
+ Partials                                       630      627       -3

see 19 files with indirect coverage changes


Import and export restraints as JSON

Is this not automatically running on Travis?

Codecov Report

Merging #75 into master will decrease coverage by 0.15%.
The diff coverage is 69.16%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   80.49%   80.33%   -0.16%
==========================================
  Files          10       11       +1
  Lines        1697     1765      +68
==========================================
+ Hits         1366     1418      +52
- Misses        331      347      +16

Impacted Files
Coverage Δ

paprika/restraints.py
68.69% <68.13%> (+0.56%)
:arrow_up:

paprika/json.py
73.77% <73.77%> (ø)

paprika/amber.py
84.5% <0%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd31c81...9af7c04. Read the comment docs.

What happened to the Travis badge?

It's in the README, but I'm not sure why it's not here.

I guess it just took a long time to run. We have lots of warnings here https://travis-ci.org/slochower/pAPRika/jobs/427460883 Plus it seems to have taken 9 minutes.


Multi-platform GDAL jar

Due to SWIG versions used by GISInternals and by this dev team, the GDAL jar was created in such a way that Windows and Linux were having problems using the same one in each environment.
This PR hopes to address that.

This change is

Coverage remained the same at 53.656% when pulling a3282f310b4cb8d6d00dc17ce5f167da64c36b1a on gdal-2.1.0 into 5d8d1e6c2ffaed2f2a19976a874357f9f7831648 on master.


Ability to specify default database name to store embeddings in aurora database

Optionally capture user input (from CLI) for default database name while choosing aurora rag engine. This would allow us to create the workspace tables in the specified database instead of postgres database.

@massi-ang I can work on this change.

Assigned @surukonda - thank you


[5.4] Add whereNotIn() to Collection

Refs #18140 and #18145.

@guidocella: Could you send a PR to the https://github.com/laravel/docs?


[core] Allow sub-classing Javalin

Any interesting plans?

Released as part of 1.7.0 now: https://javalin.io/news/2018/05/21/javalin-1.7.0-released.html


Scale modelPosition() to account for tile overzooming

We concluded in https://github.com/tangrams/tangram/issues/259 that we should scale the modelPosition() accessor to account for tile overzooming, providing a consistent scale for shader-based patterns.
This is done by adding an additional scaling factor of 2^(tile style zoom - tile coord zoom) to the modelPosition().
Implementation notes:

u_tile_origin.z was already set to the tile's style zoom (the zoom at which the tile is being displayed) in JS, but to the coordinate zoom (e.g. the zoom at which the tile was loaded) in ES. We concluded that it should be set to the style zoom on both platforms.
However we also need access to the tile coordinate zoom, which is now provided as u_tile_origin.w.
Previously, JS was using u_tile_origin.w as the depth offset for proxy tiles. This was moved to a new uniform u_tile_proxy_depth, however this will not be documented/exposed as a public "API" uniform (unlike u_tile_origin, which is available to users).
modelPosition() has never really been in a true [0, 1] range, because geometry can go outside the tile bounds. This means it cannot safely have a modulus or fract applied. Instead we've opted to simply scale it, meaning the scale of its values is consistent with what the user would expect for a given zoom level, but the actual values cover a greater range.

cc @blair1618

In the corresponding change set for ES, I noticed a small difference in the way line extrusion is being calculated in ES and in JS
In ES I found that line extrusion was only correct when dz was calculated using the "coordinate zoom". The vertex coordinates and extrusion vectors were produced at the scale of the "coordinate zoom", so it seems to me that this should be the value compared to the map zoom. Does the current code in JS result in correct extrusion scaling for over-zoomed tiles?

Lines are scaling properly in JS for overzooming. That suggests to me that there's a difference in the meters-per-pixel scale being used when the extrusion vectors are calculated. In JS, the feature's style zoom is used for all styling-related calculations, of which line width / extrusion is included. If it were based on coordinate zoom instead, then it would be expected to see the line width scaling up (incorrectly) with overzooming?

Ah, yes! The line-width evaluation in ES currently uses the "coordinate zoom" of the tile, not the "styling zoom" - so both implementations are internally self-consistent. Once this corresponding PR in tangram-es is merged, we could switch to evaluating width using the "styling zoom" for consistency (before we only had the "coordinate zoom" available in shaders).


Fix parenthesis error and remove unused column name

This PR is to address some changes made by issue #96. I removed a parenthesis that was causing an error and an unused column name.

@kalenluciano Weird, I swear I made that parenthesis fix somewhere. That state_name column is to enable search on the full state name instead of just a two letter abbreviation

When I pulled down the main branch, it gave me an error when I ran python app.py but maybe I needed to pull again if it works for you locally.
As for the state_name, the one I removed is for labelling the returned values that we select in the sql query
SELECT                 data_sources.airtable_uid,                 data_sources.name AS data_source_name,                 data_sources.description,                 data_sources.record_type,                 data_sources.source_url,                 data_sources.record_format,                 data_sources.coverage_start,                 data_sources.coverage_end,                 data_sources.agency_supplied,                 agencies.name AS agency_name,                 agencies.municipality,                 agencies.state_iso
It's only going to return these 12 values, which match with these column names: 1column_names = ['airtable_uid', 'data_source_name', 'description', 'record_type', 'source_url', 'record_format', 'coverage_start', 'coverage_end', 'agency_supplied', 'agency_name', 'municipality', 'state_iso']`. Adding the state_name to this column won't do anything, but I think it's probably best practice to remove the excess label. We still will check for matches in the state_name because you added this to the where clause of our sql query: state_names.state_name ILIKE %s

No totally, just thought I had addressed it already.
Ah yeah I see now.

hey nice catch