GEODE-6205: Set disk-dir in gfsh either absolute or relative based on…

… input directory
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@Petahhh: Yes, thats right. This is changing what is persisted in cluster configuration. Without the change, this command:
create disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir

Saved the relative disk-dir to cluster configuration:
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
    <disk-dir>myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>

When a new server was started, it created a DiskStore in the working directory instead of the absolute directory.
With the change, this command:
create disk-store --name=DISKSTORE --dir=/absolute/path/to/myDiskDir

Saves the absolute disk-dir to cluster configuration:
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
    <disk-dir>/absolute/path/to/myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>

And this command:
create disk-store --name=DISKSTORE --dir=myDiskDir

Saves the relative disk-dir to cluster configuration:
<disk-store name="DISKSTORE" ...>
  <disk-dirs>
      <disk-dir>myDiskDir</disk-dir>
  </disk-dirs>
</disk-store>

In both cases, the server gets the correct disk directory.
Basically whatever is typed as the value of the dir in the command is saved to cluster configuration.


Added the speech recognition polyfill

The Chromium WebView flavor that WebARonTango and WebARonARCore are built on does not support the SpeechRecognition API. A native polyfill has been implemented that provides the API and this PR adds it to the three.ar.js library stack.

Created #15


Add  WRB

is it possible to add the World Reference Base classification?

@sow-ibrahima Thanks for your comment. I will work on this and make it available in a new release. I will let you know after it is ready. Thank you!

@sow-ibrahima A new release v0.1.4 is available which supports wrb map service. I will close this issue and please create a new issue if you find any issues. Thank you!

Thanks Gaitan.
Will do.


IUnknown implementation of DX12 wrapper objects

Add an IUnknown implementation for the DX12 object wrappers with the following properties:

Forward AddRef and Release calls to the wrapped objects.
Free wrapper resources when the wrapped object's Release returns 0.
Ensure that QueryInterface always returns a DX12 wrapper object

First, forward the QueryInterface call to the wrapped object.  On a successful call, use the returned pointer as a key to a global table to retrieve an associated wrapper object.
If a wrapper object is found in the table, return it.
If a wrapper object is not found in the table, create a wrapper for the retrieved object based on the REFIID.

I think we don't want to create our own custom IUnkonwn implementation we want to use ATL to create classes that implement 1+ ID3D12 interfaces.
If you just wrap the D3D interfaces as is, you will get cases where 2+ separate wrappers point to the same D3D object.
This can cause issues when you need to track state tracking and DXR meta data on a single object that implements multiple D3D interfaces (each with its own wrapper).
We want to keep the ref count for the wrapped object separate from the ref count of the wrapper.
The D3D runtime has ownership logic between D3D objects - e.g. when a texture is created, it becomes an owner of the device it is created on.
This will help making sure that the wrappers are destroyed based on ownership by the captured app.
However this requires mimicking the D3D runtime internal ownership logic.


Ci cd poc

Overview
This PR is a rough-draft at forming a foundation on auto-shipping the agent and comparison builds to NR Internal Dev

See this vision board for a general vision on CI/CD testing and shipping.


Tray Icon not shown after update

Some vendor, despite #388, allowed to auto-update PH recently :-D (it of course garbage-collected the sysdriver, but I can live with that ;-))
I don't have much to over except the two lines above. Host is a Win 10 1803 (17134.1304), and I have no idea from which version I updated.
I tried turning off and on again.

That vendor might have polluted the shell tray icon cache and you might need a new icon guid.

open settings.xml
change the IconGuids value back to default:
  <setting name="IconGuids"></setting>
start Process Hacker

That works. So, just removing that line is okay? Do I need to do anything with that data I removed?

So, just removing that line is okay?

Yep

Do I need to do anything with that data I removed?

Nope, you can delete them. Process Hacker will generate new guids for the explorer shell and the tray icons will continue working without the old data :)


Update C interface to make it more consistent

Function naming convention for C interface:
Option 1
helics_{modulename}_{action}[_{subject}] ( ... ) {
    ...
}

e.g.
helicsStatus helics_federateinfo_setfederatename (helics_federate_info_t fi, const char *name);
helicsStatus helics_federateinfo_setcorename (helics_federate_info_t fi, const char *corename);
helicsStatus helics_federateinfo_setcoreinitstring (helics_federate_info_t fi, const char *coreInit);

Here, federateinfo is the module name.
Optionally, we could have underscore separators for all words.
e.g.
helicsStatus helics_federate_info_set_federate_name (helics_federate_info_t fi, const char *name);
helicsStatus helics_federate_info_set_core_name (helics_federate_info_t fi, const char *corename);
helicsStatus helics_federate_info_set_core_init_string (helics_federate_info_t fi, const char *coreInit);

Question: What to do about the following function? It does not have a clear module name.
helics_core helics_create_core (const char *type, const char *name, const char *initString);

The advantage of this option is that is enables easier autocompletion in IDEs to find what a user is looking for.
The disadvantage of including the module names is that the names may have redundant information.
helics_message_federate helics_messagefederate_createmessagefederate (const helics_federate_info_t fi);
helics_message_federate helics_messagefederate_createmessagefederatefromfile (const char *fileName);

Option 2
helics_{action}[_{subject}] ( ... ) {
    ...
}

This option excludes the module name in favor of description action names on an optional subject.
e.g.
helicsStatus helics_setfederateinfofederatename (helics_federate_info_t fi, const char *name);
helicsStatus helics_setfederateinfocorename (helics_federate_info_t fi, const char *corename);
helicsStatus helics_setfederateinfocoreinitstring (helics_federate_info_t fi, const char *coreInit);

This following function no longer requires a module name.
helics_core helics_create_core (const char *type, const char *name, const char *initString);

There's no redundant naming, however autocomplete in IDEs may not be as helpful as in Option 1. This can be countered by using regex to search.
helics_message_federate helics_createmessagefederate (const helics_federate_info_t fi);
helics_message_federate helics_createmessagefederatefromfile (const char *fileName);

Option 2 can also be set up using underscore separators for every word.
helicsStatus helics_set_federate_info_federate_name (helics_federate_info_t fi, const char *name);
helicsStatus helics_set_federate_info_core_name (helics_federate_info_t fi, const char *corename);
helicsStatus helics_set_federate_info_core_init_string (helics_federate_info_t fi, const char *coreInit);

wouldn't the helics_core_*  be its own module.  There are a few functions we need to add for the core and broker yet and those would go in that "module"  so  helics_core_create(...

Okay, that makes sense, then that point can be discarded in the comment above. So the related question is are there other functions that wouldn't necessarily fall under a "module"?

I prefer option 1, minus some redundant information -- instead of helics_messagefederate_createmessagefederate[fromfile], the method would be helics_messagefederate_create[fromfile]. Underscore separators looks like some names result in a lot of underscores, and makes the module name harder to recognize.

Sorry for being late in this conversation. Thanks for bringing this up, @kdheepak. It's great to have this information at this early stage of HELICS development. Here are my thoughts:

Is there a particular advantage to switching to using underscores than the existing CamelCase format? I use CamelCase and most scientific software I know, including PETSc and SunDials, use a CamelCase format for naming functions and objects. There is this paper http://www.cs.loyola.edu/~binkley/papers/icpc09-clouds.pdf that advocates using CamelCase but I'm sure there may be other papers having a differing view. The question is whether to switch to underscores instead of CamelCase. Having worked with both underscore and CamelCase format, I prefer CamelCase because it is easier to understand and interpret. But, I'm completely fine to use underscores if you all think it provides better value.

Regardless of whichever format is chosen, I think having a single format would promote uniformity used for both data types and function names. Currently, the function names use a mixed CamelCase for function names (e.g. helicsSetDefaultDouble) and underscores for data types (e.g. helics_time_t).

I prefer function names starting the ObjectName rather than the prefix helics. I like the  or (object)_(action). I am not sure if having the prefix helics adds any specific value to the function name. In my opinion, it only makes the function names longer. Yes, one can argue that it makes it more clear that it is a HELICS function, but I don't think that is a strong argument.

Common functions and datatypes that are used by ALL objects, e.g. helicsStatus (note that this should be either helics_status or HelicsStatus), could be prefixed with Helics. Other example is HelicsEnterXXXMode.  Functions for objects such as ValueFederate and others can start with its own object name e.g. ValueFedereateCreate instead of HelicsCreateValueFederate.

Constants should be all caps. HELICS has this currently.

In PETSc, we differentiate between C and C++ headers by having an extension .h and .hpp, respectively. So ValueFederate_c.h would be just ValueFederate.h. Note that CamelCase is not necessarily needed for filenames.

Maybe think of abbreviating some of the object names and their associated functions, e.g. instead of ValueFederate use ValueFed, instead of FederateInfo use FedInfo? Shorter function and data type names.

Rename HelicsEnterXXXMode to HelicsXXXBegin() or HelicsXXXInitiliaze, and a corresponding HelicsXXXClose() or HelicsXXXFinalize(). I am saying this because I find the name helicsEnterXXXModelFinalize() confusing.

@abhyshr made me think a little bit of what I was basing the "not completely consistent" standard as it exists.  For the most part I just did the same as I did in the GridDyn C interface.  But that was based off the FMI API.  which used camelCase {namespace}{Action}  they didn't really have objects so in GridDyn I always did {namespace}{Object}{Action}  the namespace is always in lowercase,  along with a tendency to name simple or enumerated types with underscores.    Come to think of it Shri is right, with the exception of zmq most of the C libraries I have interacted with use camelCase,  so I am inclined to agree with Shri that we should use some form of that.

Thanks for the detailed reply @abhyshr.
The GNU Coding Standard asks that people use underscores to separate words in names, so that it will be easier to navigate with Emacs. And, I think the main argument for underscores comes from this CppCodingStandard which states that using underscores for C functions clarifies that they are different from CPP. The CPP Core Guidelines also seems to recommend against camelCase. It seems that the only thing common across every style guide is that developers should ensure that they are internally consistent.
That said, I'm for using camelCase for all functions, C and CPP. I think separating the C functions from the CPP functions visually is appealing. However, we already have a helics prefix for all C functions, which should suffice. In addition, documentation and file layout will separate the C functions from the CPP functions.
I do like the idea of having underscores for general naming. Google's CPP style guide recommends underscores for general naming, camelCase for functions and PascalCase for Classes.
I also think the prefix helics is necessary for clean code. If there were another library with a same set{Object} function, there would be a conflict, would there not?. Using the helics prefix provides a namespace to ensure that no conflicts can occur. And coming from Python, in my experience I have found that it has made my life so much easier when I know where a function is coming from when I am reading a codebase developed by someone else. So I would say that quickly being able to identify which functions are coming from HELICS is definitely an advantage, at the small cost of being slightly verbose. It also would help in autocompletion when someone is working with HELICS.
I agree with your other points. I'll be making these changes to a branch and requesting a review from everyone that comments on this thread. Feel free to add more thoughts and comments here.

Lets write up a simple document with the proposed style guide before modifying any code, we can finish hashing out the document, then make the required changes over the next couple weeks and potentially encode some of them in a analyzer as well.

I will add a page to the documentation that describes coding style.

On Dec 14, 2017, at 8:14 PM, Dheepak Krishnamurthy <notifications<EMAIL_ADDRESS>wrote:
Thanks for the detailed reply @abhyshrhttps://github.com/abhyshr.
The GNU Coding Standardhttps://www.gnu.org/prep/standards/html_node/Names.html#Names asks that people use underscores to separate words in names, so that it will be easier to navigate with Emacs. And, I think the main argument for underscores comes from this CppCodingStandardhttps://users.ece.cmu.edu/~eno/coding/CppCodingStandard.html#cnames which states that using underscores for C functions clarifies that they are different from CPP. The CPP Core Guidelineshttps://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#nl10-avoid-camelcase also seems to recommend against camelCase. It seems that the only thing common across every style guide is that developers should ensure that they are internally consistent.
That said, I'm for using camelCase for all functions, C and CPP. I think separating the C functions from the CPP functions visually is appealing. However, we already have a helics prefix for all C functions, which should suffice. In addition, documentation and file layout will separate the C functions from the CPP functions
I do like the idea of having underscores for general naming. Google's CPP style guidehttps://google.github.io/styleguide/cppguide.html#Naming recommends underscores for general naming, camelCase for functions and PascalCase for Classes.
I'm fine with whichever format you guys decide. However, having a single format would be easy to remember for the user, in my opinion.
I also think the prefix helics is necessary for clean code. If there were another library with a same set{Object} function, there would be a conflict, would there not?.
Yes, but that's really really rare probability. I've only heard a couple of times of this issue happening with any of PETSc functions, which has been used for over twenty years now.
Using the helics prefix provides a namespace to ensure that no conflicts can occur. And coming from Python, in my experience I have found that it has made my life so much easier when I know where a function is coming from when I am reading a codebase developed by someone else. So I would say that quickly being able to identify which functions are coming from HELICS is definitely an advantage, at the small cost of being slightly verbose. It also would help in autocompletion when someone is working with HELICS.
That's a good point. I am not opposed to having a prefix, but I think it is redundant and only makes the function names longer. I agree with you on the auto-complete point. Speaking of autocomplete , do you guys recommend any auto-complete libraries for emacs? I use autocomplete from MELPA, but I've not figured how to have autocomplete the function prototypes from a third-party library like Helics. Any suggestions? Has anyone tried Cedet semantics or Irony?
I agree with your other points. I'll be making these changes to a branch and requesting a review from everyone that comments on this thread. Feel free to add more thoughts and comments here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/GMLC-TDC/HELICS-src/issues/42#issuecomment-351893784, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHuMHag-XHkPm3HuZqVct522QVJR4aNks5tAdX2gaJpZM4Q_L3J.

That's a very good proposition.
On Dec 14, 2017, at 10:47 PM, Philip Top <notifications<EMAIL_ADDRESS>wrote:
Lets write up a simple document with the proposed style guide before modifying any code, we can finish hashing out the document, then make the required changes over the next couple weeks and potentially encode some of them in a analyzer as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/GMLC-TDC/HELICS-src/issues/42#issuecomment-351912575, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHuMPgkEW9foAQLl6lCLAxqIHB83JUrks5tAfm_gaJpZM4Q_L3J.

I've started putting together the style guide here.

Coming from VisualStudio I use autocomplete frequently and having all the available functions from a single library show up when I type the library name is very useful.  the same goes for specific modules in the library to see what functions are available.
as far as namespace collisions I am not that concerned about function name collisions for most functions, but if we don't include the name on the C function then the C++ wrapper will require a distinct name and that is something I would like to avoid.

@abhyshr I am going to separate out comment 8 you made to its own issue since it is a little distinct from the nameing convention discussion

Generally, I like the document -- I really don't have a strong opinion about what style is used, but rather one is used.
Should additional elements be added to this (or is that becoming too burdensome)?  Such as:

When is it okay to use pointers? (or more importantly, when not to use them)
When should variables be public v. private?
Space, tabs, line lengths, conditional formatting, expressions, etc? (all these can be reformatted by an editor, but do we declare what we are using)?
Defined commenting style or header blocks? (for later parsing)
(this list could go on)

Maybe instead we default back to established guidelines for specific languages (e.g., Cocoa Coding Guidelines)?

Any code formatting issues are encapsulated in the .clang_format file if you want to discuss them it is open but we can encode those rules pretty easily.
what is not captured in that file is the naming conventions, I think some can be encoded in a .clang_tidy file but that is a ways off yet.
I think we can work out documentation standards in a later step, so I think we should get there but one step at a time.   as far as other coding guidelines I am hesitant to encode those to much at this stage would prefer we focus on the automated tools to catch potential issues.
In any case I think this document that Dheepak has should clearly focus on naming conventions

The CamelCase format for function names in the style guide is incorrect. PascalCase and CamelCase are basically the same. The first letter in CamelCase is capitalized. The function name in the style guide should be RegisterGlobalPublication and not registerGlobalPublication. Thus, the function names and class (or struct) names would follow CamelCase. Any fields in it (including function pointers) will use small letters with underscores, if needed. Here are a few suggestions:
Structs and Classes: CamelCase format
Struct or class fields: lowercase with underscores if needed
typedef struct HelicsObject {
int some_int;
};

Function Names: CamelCase format
Order of arguments: Inputs first followed by the outputs.
Return type: HelicsStatus -- I propose all public API functions return HelicsStatus so that we can use it for error checking.

HelicsStatus HelicsRegisterGlobalPublication(InputType input, OutputType *output);

Constants: All CAPS
We could define it in a single constants.h file rather than have them dispersed in several headers. I would suggest not having constants declared via `const`. It makes difficult to track down what the value of the constant is and where it is being set.

#define HELICSCONSTANT <constant_value>;
Enumerations: CamelCase
Any of its fields: ALL CAPS since they are basically constant
typedef enum HelicsEnum{
 HELICS_OK;
 HELICS_ERR;
};

Also, I propose we use lowercase for filenames with underscores if needed. Using a .c and .h extension for C and .cpp and .hpp for C++. I don't think this is a high priority, but it is a simple way of differentiating between C and C++ code.

In C++ it is much more preferable to use constexpr/const objects vs a #define to allow for type checking so defines should be avoided.  This is not possible in C.
In generate in C++ I have always gone with the .h and .cpp file names matching the name of the class including capitalization.
in the C interface the helicsStatus or possibly renamed to helics_status would be indicative of errors.  Not all the functions can return errors,  nor do I have a clear idea how that would work for the object creation functions.
int helicsCoreIsConnected (helics_core core)

returns 1 if a core is connected, if the core is invalid it obviously isn't connected.  There is no error possibility of an error condition hence returning a helics_status is misleading.  In the library at present if helicsStatus is returned there is the possibility of an error, if not there is no possibility of an error, and on the construction functions returning through a pointer would be very confusing as to memory management.
helicsStatus helicsGetPublicationUnits (helics_publication pub, char *str, int maxlen);

there are many functions like this where the output is placed in a string.  The user manages memory of the string and must provide a valid memory and size.  In some ways maxlen is part of the output str, but it is used as an input variable.  It is not clear that switching the order of these makes it better as most functions like that take pointer then size vs the other way around.


configure boxes to present pertinent info on login

Not dissimilar to neofetch, but neofetch is pretty slow and not very flexible.

pertinent information would include what software is installed and where (outside of standard uses. ie NetIQ flavored tomcat and NetIQ flavored Java outside of PATH)
how to use software (ie what port is the web server to run on?)

alternatively, this info can be abbreviated with further reading made available at a local resource (also specified)

Could use Polaroid


NLP example script not working with num_processes=8

System Info
- `Accelerate` version: 0.18.0.dev0
- Platform: Linux-5.13.0-1027-gcp-x86_64-with-glibc2.29
- Python version: 3.8.10
- Numpy version: 1.24.2
- PyTorch version (GPU?): 2.0.0+cu117 (False)
- `Accelerate` default config:
        - compute_environment: LOCAL_MACHINE
        - distributed_type: TPU
        - mixed_precision: no
        - use_cpu: False
        - num_processes: 8
        - machine_rank: 0
        - num_machines: 1
        - rdzv_backend: static
        - same_network: True
        - main_training_function: main
        - downcast_bf16: no
        - tpu_use_cluster: False
        - tpu_use_sudo: False
        - tpu_env: []

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
I created a TPU VM v2-8 (From google), when running this example script https://github.com/huggingface/accelerate/blob/main/examples/nlp_example.py
It fails and gives this error:
https://symbolize.stripped_domain/r/?trace=https://symbolize.stripped_domain/r/?trace=7f4fbf0fc873,7f356bff2873,7f505752408f7f360441a08f&map=&map=
*** SIGSEGV (@0x8), see gl__________46#s15 received by PID 5397 (TID 7308) on cpu 82; stack trace: ***

*** SIGSEGV (@0x87), see gl__________46#s15 received by PID 5400 (TID 7955) on cpu 45; stack trace: ***
Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/distributed/parallel_loader.py", line 140, in _loader_worker

PC: @     0x7f356bff2873  (unknown)  torch_xla::XLAGraphExecutor::SyncTensorsGraphInternal()
PC: @     0x7f4fbf0fc873  (unknown)  torch_xla::XLAGraphExecutor::SyncTensorsGraphInternal()
    @     0x7f34b5adaa1a       1152  (unknown)
    @     0x7f4f08be4a1a       1152  (unknown)
    @     0x7f360441a090  (unknown)  (unknown)
https://symbolize.stripped_domain/r/?trace=7f356bff2873,7f34b5adaa19,    @     0x7f5057524090  (unknown)  (unknown)
7f360441a08f&map=https://symbolize.stripped_domain/r/?trace=ceee8fa20ddf9c34af43f587221e91de:7f34a8bb2000-7f34b5cf18407f4fbf0fc873,7f4f08be4a19,7f505752408f&map=
ceee8fa20ddf9c34af43f587221e91de:7f4efbcbc000-7f4f08dfb840E0408 07:37:46.418757    7308 coredump_hook.cc:414] RAW: Remote crash data gathering hook invoked.

E0408 07:37:46.418781    7308 coredump_hook.cc:453] RAW: Skipping coredump since rlimit was 0 at process start.
E0408 07:37:46.418809    7308 client.cc:278] RAW: Coroner client retries enabled (b/136286901), will retry for up to 30 sec.
E0408 07:37:46.418802    7955 coredump_hook.cc:414] RAW: Remote crash data gathering hook invoked.
E0408 07:37:46.418820    7308 coredump_hook.cc:512] RAW: Sending fingerprint to remote end.
E0408 07:37:46.418827    7308 coredump_socket.cc:120] RAW: Stat failed errno=2 on socket /var/google/services/logmanagerd/remote_coredump.socket
E0408 07:37:46.418834    7308 coredump_hook.cc:518] RAW: Cannot send fingerprint to Coroner: [NOT_FOUND] Missing crash reporting socket. Is the listener running?
E0408 07:37:46.418837    7955 coredump_hook.cc:453] RAW: Skipping coredump since rlimit was 0 at process start.
E0408 07:37:46.418843    7308 coredump_hook.cc:580] RAW: Dumping core locally.
E0408 07:37:46.418852    7955 client.cc:278] RAW: Coroner client retries enabled (b/136286901), will retry for up to 30 sec.
E0408 07:37:46.418864    7955 coredump_hook.cc:512] RAW: Sending fingerprint to remote end.
E0408 07:37:46.418877    7955 coredump_socket.cc:120] RAW: Stat failed errno=2 on socket /var/google/services/logmanagerd/remote_coredump.socket
E0408 07:37:46.418901    7955 coredump_hook.cc:518] RAW: Cannot send fingerprint to Coroner: [NOT_FOUND] Missing crash reporting socket. Is the listener running?
E0408 07:37:46.418908    7955 coredump_hook.cc:580] RAW: Dumping core locally.

Exception in thread Thread-4:
Traceback (most recent call last):
  File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/distributed/parallel_loader.py", line 140, in _loader_worker
    _, data = next(data_iter)
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/data_loader.py", line 369, in __iter__
    synchronize_rng_states(self.rng_types, self.synchronized_generator)
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/utils/random.py", line 89, in synchronize_rng_states
    synchronize_rng_state(RNGType(rng_type), generator=generator)
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/utils/random.py", line 68, in synchronize_rng_state
    rng_state = xm.mesh_reduce("random_seed", rng_state, lambda x: x[0])
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/core/xla_model.py", line 1160, in mesh_reduce
    xdata = rendezvous(tag, bio.getvalue())
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/core/xla_model.py", line 1110, in rendezvous
    return pjrt.rendezvous(tag, payload, replicas or None)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/experimental/pjrt.py", line 419, in rendezvous
    xm.mark_step()
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/core/xla_model.py", line 949, in mark_step
    torch_xla._XLAC._xla_step_marker(
RuntimeError: /pytorch/xla/torch_xla/csrc/xla_graph_executor.cpp:523 : Check failed: tensor_data
*** Begin stack trace ***
        tsl::CurrentStackTrace()
        torch_xla::XLAGraphExecutor::CollectSyncTensors(std::vector<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> >, std::allocator<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> > > > const&, torch::lazy::LazyGraphExecutor::SyncTensorsConfig const&)
        torch_xla::XLAGraphExecutor::SyncTensorsGraphInternal(std::vector<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> >, std::allocator<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> > > >*, absl::lts_20220623::Span<std::string const>, torch::lazy::LazyGraphExecutor::SyncTensorsConfig const&, bool)
        torch_xla::XLAGraphExecutor::SyncTensorsGraph(std::vector<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> >, std::allocator<c10::intrusive_ptr<torch_xla::XLATensor, c10::detail::intrusive_target_default_null_type<torch_xla::XLATensor> > > >*, absl::lts_20220623::Span<std::string const>, bool, bool, bool)
        torch_xla::XLAGraphExecutor::SyncLiveTensorsGraph(torch::lazy::BackendDevice const*, c10::ArrayRef<std::string>, bool)

        PyCFunction_Call
        _PyObject_MakeTpCall
        _PyEval_EvalFrameDefault

        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyEval_EvalCodeWithName
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyEval_EvalCodeWithName
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyEval_EvalCodeWithName
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault

        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall

        PyObject_Call
        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall
        _PyEval_EvalFrameDefault
        _PyFunction_Vectorcall

        PyObject_Call

        clone
*** End stack trace ***

E0408 07:37:46.664046    7308 process_state.cc:784] RAW: Raising signal 11 with default behavior
E0408 07:37:46.721980    7955 process_state.cc:784] RAW: Raising signal 11 with default behavior
https://symbolize.stripped_domain/r/?trace=7fa983018454,7fa98306c08f&map=
*** SIGTERM received by PID 5399 (TID 5399) on cpu 38 from PID 5214; stack trace: ***
https://symbolize.stripped_domain/r/?trace=7feafccfa454,7feafcd4e08f&map=
*** SIGTERM received by PID 5398 (TID 5398) on cpu 95 from PID 5214; stack trace: ***
PC: @     0x7fa983018454  (unknown)  do_futex_wait.constprop.0
    @     0x7fa83472ca1a       1152  (unknown)
PC: @     0x7feafccfa454  (unknown)  do_futex_wait.constprop.0
    @     0x7fe9ae40ea1a       1152  (unknown)
    @     0x7fa98306c090  (unknown)  (unknown)
    @ ... and at least 1 more frames
https://symbolize.stripped_domain/r/?trace=7fa983018454,7fa83472ca19,7fa98306c08f&map=ceee8fa20ddf9c34af43f587221e91de:7fa827804000-7fa834943840
E0408 07:37:48.470860    5399 coredump_hook.cc:360] RAW: Remote crash gathering disabled for SIGTERM.
    @     0x7feafcd4e090  (unknown)  (unknown)
    @ ... and at least 1 more frames
https://symbolize.stripped_domain/r/?trace=7feafccfa454,7fe9ae40ea19,7feafcd4e08f&map=ceee8fa20ddf9c34af43f587221e91de:7fe9a14e6000-7fe9ae625840
E0408 07:37:48.470932    5398 coredump_hook.cc:360] RAW: Remote crash gathering disabled for SIGTERM.
E0408 07:37:48.655386    5398 process_state.cc:784] RAW: Raising signal 15 with default behavior
E0408 07:37:48.672290    5399 process_state.cc:784] RAW: Raising signal 15 with default behavior
Traceback (most recent call last):
  File "/home/soliman/.local/bin/accelerate", line 8, in <module>
    sys.exit(main())
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/commands/accelerate_cli.py", line 45, in main
    args.func(args)
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/commands/launch.py", line 930, in launch_command
    tpu_launcher(args)
  File "/home/soliman/.local/lib/python3.8/site-packages/accelerate/commands/launch.py", line 694, in tpu_launcher
    xmp.spawn(PrepareForLaunch(main_function), args=(), nprocs=args.num_processes)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/distributed/xla_multiprocessing.py", line 386, in spawn
    return pjrt.spawn(fn, nprocs, start_method, args)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/experimental/pjrt.py", line 365, in spawn
    _run_multiprocess(spawn_fn, start_method=start_method)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/experimental/pjrt.py", line 92, in wrapper
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/experimental/pjrt.py", line 322, in _run_multiprocess
    replica_results = list(
  File "/usr/local/lib/python3.8/dist-packages/torch_xla/experimental/pjrt.py", line 323, in <genexpr>
    itertools.chain.from_iterable(
  File "/usr/lib/python3.8/concurrent/futures/process.py", line 484, in _chain_from_iterable_of_lists
    for element in iterable:
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 619, in result_iterator
    yield fs.pop().result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 444, in result
    return self.__get_result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

/usr/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 4 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

It's worth noting:

When running the same script but with num_processes=1 in the tpu configuration, it works normally.
When running another example from google documentation (training a ResNet, with num_processes=8) it works normally (You can find it here: https://cloud.google.com/tpu/docs/pytorch-xla-ug-tpu-vm#changing_pytorch_version)
git clone --recursive https://github.com/pytorch/xla.git python3 xla/test/test_train_mp_imagenet.py --fake_data --model=resnet50 --num_epochs=1

Setting these environment variables didn't help
export XRT_TPU_CONFIG="localservice;0;localhost:51011"
export PJRT_DEVICE="TPU"

What is the cause and how to fix this error? Thanks
Expected behavior
Training with no errors

Similar problem here: https://discuss.huggingface.co/t/kaggle-tpuvm-doesnt-allow-setting-nprocs-1/35999/2
Again on TPUs. This can be reproduced really easily in kaggle kernels just with accelerate test --config_file ... so is not model dependent. When using my own model & script for training I get the same error - so the problem is definitely here with XLA

Any updates? I can't really train my scripts in the meantime :(


⚠ Bofrost.at has degraded performance

In 3e9434b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1227 ms

Resolved: Bofrost.at performance has improved in 1d26c0e.


Unable to load lightmaps in Build; working fine in Editor

Hi Laurenth,
I have built couple of scenes and baked as per steps provided. They seem to work fine in the Editor. However, when I build the project and test the same, lightmaps are not being loaded while switching from one scene to another.

Hi @petergraham003, I have built my little example project using unity 2017.3f1 on windows and things worked as expected. Could you provide more info or better provide an example ?

Hi Laurenth,
I am able to solve this issue. It was my bad that I had broke the link to prefab instance after baking the light. However, this was working in the Editor somehow, but unable to load lightmaps in the build.
All I did was applied the changes on the Prefab and baked the Scene again and it worked !!! Thank You.. :-)

Hi Laurenth,
I am able to resolve this issue. It was my bad that I had broke the prefab instance after baking the light. It seems to work somehow in the Editor, but was not loading the lightmaps in the build. All I did was to apply the changes done to the Prefab and bake the light again. It worked!!! Thank You :-)


Move towards a standard of persistent_id for Subject

Previously most AAF applications have relied on a combination of eduPersonSharedToken and eduPersonEntitlement when identifying users.
This is seen within lipstick where calls are made to Subject#targeted_id within helpers (and likely elsewhere).
Whilst Rapid Connect will continue to provide edupersontargetedid in its JWT payload we should convert receivers and subjects to operate on and store this value as persistent_id to keep parity across our application stack.
This will become relevant when dealing with OIDC also as the persistent_id value will be transported to applications as sub.

Other relevant PR associated with this change:

https://github.com/ausaccessfed/aaf-lipstick/issues/77
https://github.com/ausaccessfed/aaf-gumboot/issues/50
https://github.com/ausaccessfed/shib-rack/issues/15

There may also be need to consider a shared_persistent_id value that is populated from auEduPersonSharedToken or in the future eduPersonUniqueId http://software.internet2.edu/eduperson/internet2-mace-dir-eduperson-201602.html#eduPersonUniqueId as opposed to our current reliance on calling this auEduPersonSharedToken


Improve error handling when deserializing json

If a JSON file with incorrect format is in the same folder as an ARM template, the following error is produced.
Scenario
Create a valid arm template called azuredeploy.json
Create an invalid json file called testrequest.json
Invoke Arm TTK tests.
$TemplatePath = ".\arm\mytemplate"
Test-AzTemplate -Verbose -TemplatePath $TemplatePath -MainTemplateFile $MainTemplateFile

Result
Import-Json: C:\Azure\arm-ttk\arm-ttk\Expand-AzTemplate.ps1:216
Line |
 216 |  …                 $fileObject.Object = Import-Json $fileObject.FullPath
     |                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Conversion from JSON failed with error: Unexpected end when deserializing object. Path 'content', line 52, position 5.

Suggestion
It would be useful to include the actual path from $fileObject.FullPath in the above error message, and provide some verbose toggle for details on errors.
In addition, unclear why this file is being picked up at all other than it has a json extension...

@asears - what's the scenario where you want invalid json to be used in your project but ignored by ttk?
I could envision a scenario where we wrap in a try-catch (we don't parse the json, pwsh does) but then we need to make sure we don't catch an error that we didn't want to catch.

Not necessarily ignored, just surface the specific filename under inspection or throwing error.  Took a bit of time to figure out which file was causing an issue - there was a partial json template causing problems.  I wasn't clear why it was searching every json file instead of just the arm templates and parameters files either...

So throw a warning if we can't parse the json?  or just output the filename?

I'm going to propose we throw an error with the filename in the error.


Added vendor folder to close the issue occurred due to my previous pull request.

Description
This PR fixes #
Notes for Reviewers
Added vendor folder to close the issue occurred due to my previous pull request.
Signed commits

[ ] Yes, I signed my commits.

@sudhay23 Merge this it will work.

@sridhar-5 Cool 🎉
Are you sure the 'slash' conventions don't matter across Mac and Windows?

It's a web app right. for this application it remains the same

yeah slash convention are opposite exactly but since this is a web app doesn't matter.

It works 🎉

I think this is a project setting up problem. so to be able to use environment variables you need this phpdotenv package. which can be installed using composer.
install composer from here.
https://getcomposer.org/download/
and then
composer require --dev vlucas/phpdotenv execute this after installing composer.

@sridhar-5 But now since you gave the /vendor folder ig it doesn't matter now!?

The thing is if you are going ahead and deploying the application then you have to explicitly set the environment variables in what every platforms you are hosting this on.

@sridhar-5 But now since you gave the /vendor folder ig it doesn't matter now!?

This is a valid point too. can we have a session sometime and sort this out?

@sridhar-5 Hop into our discord server 😋 .

can you send me an invite?

https://discord.gg/yhtkaawfNq

@sridhar-5 do you know how to setup live website preview after each commit


after user uploads data, should navigate to next tab

if url is provided --> viewer
if file is provided --> peak table
@jokedurnez is that correct?

Nevermind this is working :)


nsb5 msmq and rabbitmq

The commit is missing packaging bit.
Please ensure that all new monitor types have own package (see nsb3 package for example).
The same applies to HealthMonitoring.Monitors.Nsb5.Messages project (see nsb3 message package ).
Also HealthMonitoring.Monitors.Nsb5.Messages should have semantic versioning in place, managed manually like Nsb3 equivalent has. It is a contract package so it should not be changing version with each build.


Specifying time delta in the CLI is not enforced

When creating, it is possible to omit the time span, eg 1m or 1d  which then causes the time to default to 10minutes. Just hitting enter at this prompt will cause the default to kick in which is the expected behaviour.
Best to check and enforce for either 'm' (minutes), 'h' (hours) or 'd' (days)

This has now been fixed with a loop which basically requires the number to end with m (mins), h (hours) or d (days)


Checkstyle

Hi to all,
what about introducing some checkstyle for Refine...?

@fpompermaier Any recommendation on your mind?

The simplest thing is to use google checkstyle:
http://checkstyle.sourceforge.net/google_style.html
On 28 November 2017 at 01:52, Jacky<EMAIL_ADDRESS>wrote:

@fpompermaier https://github.com/fpompermaier Any recommendation on
your mind?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenRefine/OpenRefine/issues/1359#issuecomment-347377847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADmeJZxt8TbAxZEzUjsjj4p_RN5tD08Pks5s61lKgaJpZM4QrZHv
.

@fpompermaier does this actually perform any fixes? Codacy already provide style warnings:
https://www.codacy.com/app/OpenRefine/OpenRefine/dashboard

I just didn't know Refine was using a checkstyle. Is there any wiki about how to enable it on Eclipse and IntelliJ?

@fpompermaier I'm not sure if Codacy has any Eclipse or IntelliJ integrations - your best bet is probably to look at the underlying tools that they use to generate the warnings and configure them locally.

@fpompermaier Most folks just use PMD and its what Codacy uses behind the scenes for Code Style checking  https://marketplace.eclipse.org/content/eclipse-pmd
Feel free to submit pull requests on all 365 issues it currently finds here :)
https://www.codacy.com/app/OpenRefine/OpenRefine/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W251bGxdfSx7ImlkIjoiQ2F0ZWdvcnkiLCJ2YWx1ZXMiOlsiQ29kZSBTdHlsZSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltudWxsXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOltudWxsXX0seyJpZCI6IkF1dGhvciIsInZhbHVlcyI6W251bGxdfV0=


Code vs paper

Hello,
thank you for publishing your code - outstanding work :)
However I have a question regarding JSD/GAN based estimators and differences between implementation and formulation in your paper:
Eq. 4:

Eq. 7:

At the same time, in your code:
(for the JSD estimator)
if mode == 'fd':
    loss = fenchel_dual_loss(l_enc, m_enc, measure=measure)
[...]
E_pos = get_positive_expectation(u, measure, average=False).mean(2).mean(2)
E_neg = get_negative_expectation(u, measure, average=False).mean(2).mean(2)
[...]
Ep = log_2 - F.softplus(-p_samples)  # Note JSD will be shifted
Eq = F.softplus(-q_samples) + q_samples - log_2  # Note JSD will be shifted

While I do know, where does thie log_2 come from [Nowozin et al., 2016], the addition of q_samples in Eq is a bit more mysterious :D
And then for the prior matching:
    if not loss_type or loss_type == 'minimax':
        return get_negative_expectation(q_samples, measure)
    elif loss_type == 'non-saturating':
        return -get_positive_expectation(q_samples, measure)

Seems like you are using just half of the equation 7 to obtain loss value.
Could you clarify those differences (maybe I am missing something in the code)? I have been trying to merge DIM with my existing code (a bit different setup, yet should work together properly) and cannot get it to work well.
Thanks in advance!

So the log 2 in the code is an artifact of another model (BGAN) where I just wanted all the f-divergences to align in a way that the estimate of p/q ended up being e^T. This doesn't change anything from a learning perspective, but it does shift the JSD.
q_samples are just the negative samples. So in the case of MI estimation, these would come from the product of marginals. If you write out the Eq part as log (1+ exp (-qsamples)) + log exp qsamples, then refactor, you get something of the form of (4).
For the prior matching, this is just done as in GAN, where the second term is all that's used for training the generator in the case of minmax. Or if you do non-saturating, you replace the first term of the f-divergence with q_samples (from the generator).
Does that make sense?

Okey, that makes sense! Thank you for clarification :)
One question - why would you use the log(1+exp(-qsamples)) + qsamples, instead of just log(1+exp(qsamples))? Is it more stable during the training?

I think it's an artifact of the olden days of Theano, as I'm guessing in PyTorch these are equivalent.

Hi devon, Thanks for your interesting work! I have some trouble in reading your code about prior matching. Like your said:

For the prior matching, this is just done as in GAN, where the second term is all that's used for training the generator in the case of minmax.

But besides training the generator, we also need to train the discriminator, that is, to maximize Equation (7) in your paper, but I didn't find any code to do this part. Am I missing anything? Or have I misunderstood anything?
Thanks a lot!

Oh sorry, I think you have done this maximize procedure in class Discriminator. Sorry to disturb.

Hi Dr.
I have two questions about postive and negative samples for the JSD estimator mentioned above in dim_losses.py

   # Compute the positive and negative score. Average the spatial locations.  E_pos = get_positive_expectation(u, measure, average=False).mean(2).mean(2)  E_neg = get_negative_expectation(u, measure, average=False).mean(2).mean(2)
While calculating the E_pos and E_neg, all the inputs are the same --- u calculating with different expectation formulas. In my opinion: the pos and neg samples should be distinguished before that.
E_pos = (E_pos * mask).sum() / mask.sum()  E_neg = (E_neg * n_mask).sum() / n_mask.sum()
Why do this?  In code comments Since we have a big tensor with both positive and negative samples, we need to mask., I'm still confused about why using mask, and the intention to operate E_neg * n_mask. Why not inpus another imgs as neg samples.


Can we improve type or view does not exist message?

Here is the query:
SELECT User { id } FILTER email = <str>$email

And the error is:
edgedb.errors.InvalidReferenceError: object type or view 'email' does not exist

My points are:

It would be quite common error (as it closely matches SQL WHERE email =)
It's hard to understand what object type or view means in this context.

The best fix would be to look through all the names and make a suggestion:
edgedb.errors.InvalidReferenceError: object type or view 'email' does not exist. Try `User.email`?

If it's hard to implement we can use some heuristics (like 99% that lowercase name is a field). Or at least add an explanation You can't reference field directly use 'Object.field'.

Yes, this can be improved.  FYI, you don't have to use Object.field, .field (with a leading dot) is enough.


[Feature] use selectors for ship skins

Perhaps just until slash commands are done. It's a shame to have to type out names all the time. Use $showme ship  to display a selector with all the skins available

blocked until updated to new BASED to include based components


Make i18n work with JSX

Describe The Problem To Be Solved
Currently, there is no way how to format an i18n value. For example, you have a user variable, and you want to display the user in bold. Like this
"complete_registration_subtitle": "Hi {{ name }}! <>Hi {{ name }}!<>

or

or create a custom template resolver that parses html and returns html elements.

Unfortunately this causes weird issues with solid start (or seroval 🙂) on the latest available version 0.3.10:
Error
Seroval caught an error during the parsing process.

Error
The value [object Function] of type "function" cannot be parsed/serialized.

There are few workarounds for this problem:
- Transform the value in a way that it can be serialized.
- If the reference is present on multiple runtimes (isomorphic), you can use the Reference API to map the references

Thats interesting. To be honest I have no idea what solid start chooses to serialize and what not, I don't think the i18n lib is doing anything wring, in the end you are just calling a function and getting some values back, and here the values happen to be html elements.
A reproduction would be helpful regardless if this is an issue with solid start or solid primitives.

Here you go: https://stackblitz.com/~/github.com/BierDav/solid-primitives-i18n-bug
The problem is that createResource is not able to work with functions as result value I guess: https://github.com/BierDav/solid-primitives-i18n-bug/blob/e27d9bed2350c0c20800b6c6502318443a42d077/src/App.tsx#L18-L24

ssrLoadFrom: "initial" fixes the issue for me, thanks for rubber ducking 🙈

No, actually this is still an issue, because I don't want to use ssrLoadFrom: "initial", because I need to fetch the current language in ssr, I can't simply render everything in english.

@thetarnav do you have an idea how to dynamically bundle the correct language files on ssr in the initial response, so that the client gets all the translations in it's first request. The problem is that createResource would allow that, but it sadly doesn't work with functions so my idea was to really import the files dynamically so that the get bundled directly into the ssr response. Is this even possible? I mean it should be, because createResource does a similar thing, but is it also possible for normal .ts and .tsx files?
If we come to a solution, I'm willing to create a full fledged tutorial how to implement i18n with solid start.

on the solidjs website we just default to english, it is the language that is always immediately available both on the server and client.
And other languages fetched dynamically.
Which should work fine with SSR, as th

I'm not sure if there is a way to include translations in the response if they cannot be serialized.
I would just lazy load the correct translations on the client.
You could maybe try adding a <link rel="preload" as="fetch" href="lang-specific-translations" /> to html head to fetch it as soon as possible.
Or inline the whole module in a


Transfusion-L

In transfusion.py: create_2D_grid
this function create 2d grid of shape (2,W,H) then reshape to (1,2,WH), it is inconsistent with bev_feat of (B, C, H, W) flatten to be (B, C, HW), which H comes first. After flatten, x and y cord is swapped.
I read the source code of Transfuison, it is the same.
is this a bug or just on purpose?

Hi @minrui-hust,
We've checked that the current implementation in our codebase is correct. We did change the order of H and W in the head on purpose (at least for CenterHead). Specifically, in the original implementation, the voxel features are assumed to be in B,C,Z,Y,X; but in our implementation we assume it to be in B,C,X,Y,Z.
Best,
Haotian

Got it, thanks for your reply,  It confused me for a while.


URL flickers as if multiple state update events are triggered (likely zoom-set min-max loop is to blame)

After resize is done I drop the window corner, and the url flickers as if multiple state update events are triggered!
Also the history is populated with tons of entries
http://tools-dev.gapminderdev.org/tools/bubbles#_state_entities_select@_geo=rus&labelOffset@:0&:0;&trailStartTime=2015;;;&marker_axis%2F_y_which=life%2F_expectancy&domainMin:10&domainMax:83&zoomedMin:10&zoomedMax:83
Change to LEX on y axis

BubbleChart component force-sets zoom/min-max and sets size and label extent on resize. That's the url updates you see. No clue why. Part of the big forest of calls in charts. I'm scared of big forests :D

why wouldn't i see them on preview page, but only on tools page?

Alright, the events get fired in both preview and tools and I don't think they should be fired.
However, angular on tools page also has a onhashchange event which for some reason encodes the hash. Why encoding? No idea. Why does it even care about hashchanges: I guess for navigation without reloading, using the hash.
As those 4 or 5 persistent change events from Vizabi reach tools page, it generates 8-10 hash changes. For every one of the Vizabi events the TP code changes hash, then Angular updates hash. TP changes hash back again, Angular updates hash again. etc.
So in essence: two bugs

(I think unnecessary) forced triggering of events on resizing in bubble chart
Angular onhashchange event runs on every hash change and interferes with url-state

By the way: it is significantly less annoying with developer toolbar closed. Seems dev toolbar open has big influence on speed of hash changes.

This seems to be resolved somehow. Likely i fixed it in fada1b6b841e0d47bb1ba1fca04e3f9f515f32a1

It was fixed on toolspage by same fix as toolspage back button fix.
However, your fix might have fixed a deeper lying issue too which also caused the flickering. To check that, you should check how many events are fired when resizing the page.


Unable to Install via Ansible-Galaxy requirements.txt

When trying to automatically install your role, the following error message due to the first published release being named different from your others.
[WARNING]: - don_rumata.ansible_role_install_virtualbox was NOT installed successfully: Unable to compare role versions (0.0.16, v1.0.0, v1.0.1) to determine the most recent version due to incompatible version formats. Please contact the role author to resolve versioning conflicts, or specify an explicit role version to install.

As a temporary solution, use: ansible-galaxy install don_rumata.ansible_role_install_virtualbox,v1.0.1

Fixed


Improve Exception and Error Handling in the Java API

On current master (Flyway 6.4.2)
Currently, the FlywayException has a few Subclasses, which are only partly documented, and it's not always clear which exception relates to which problem. For example: what if I'm only interested in schema validation failures, but I don't want to catch connectivity issues?
Moreover, ErrorCodes should be documented with Javadoc in the Java API. A user can right now only try to guess what the codes mean according to their name, which isn't always straightforward. For example, what's the difference between FAULT and ERROR?

Related to https://github.com/flyway/flyway/issues/2948

We did a revamp of the exception handling and error codes in https://github.com/flyway/flyway/commit/39197c36943fc11390fe8036d35438d1bd5c5561


[berkeley] Fork_config realignment

Merges https://github.com/MinaProtocol/mina/pull/15077

!ci-build-me

!ci-build-me

!approved-for-mainnet


NIFI-4376: Remove expired S2S request from internal queue.

Before this fix, expired requests stay in the queue and blocks newly
received requests to be offerred.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Looks good. +1 merged to master. Thanks @ijokarumawak !


Doesn't correctly display the locations of component

Type: Bug
There is a component that exports by default in the project. It doesn't correctly display the locations where it was used when I hit Ctrl + Click, but webStorm does.
const MyComponent: FC = () => {}
export default MyComponent
VS Code version: Code 1.77.0 (7f329fe6c66b0f86ae1574c2911b681ad5a45d63, 2023-03-29T10:02:16.981Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-11700F @ 2.50GHz (16 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: unavailable_offraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.84GB (12.01GB free)

Process Argv
--crash-reporter-id 2762568a-98c0-4b4e-acdc-cd118c69bd04

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-22.04

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
11th Gen Intel(R) Core(TM) i7-11700F @ 2.50GHz (16 x 2495)

Memory (System)
15.55GB (7.27GB free)

VM
0%

Please share a small example project where the  locations are displayed incorrectly

vscode example

webstorm

Please share a small example project (code) that demonstrates the issue so we can investigate

I'm sorry, but I've provided an actual example and images that demonstrate the problem. I can't share project code.

I can't share project code.

Please share the minimal code that demonstrates this issue. You should be able to put together a minimal repo that doesn't include any proprietary code

In my opinion, a tiny bit of code will operate properly, but a large project and monorepo will result in problems.

I'm closing as we can't investigate this issue without a code sample

https://user-images.githubusercontent.com/94377644/233038234-f90057d5-9d89-42b7-863d-784c50218bb8.mp4


[WIP] Let conntrack track non-NATed short-lived connections

Fixes #2494
Regression introduced by https://github.com/weaveworks/scope/pull/2135

[ ] Add integration test

I was done coding an integration test when I realized we already have one doing almost exactly what I demonstrated at https://github.com/weaveworks/scope/issues/2494#issuecomment-301941456
The only difference is that it goes through Weave. Maybe it somehow does NATting? (I doubt it)

There must be something wrong with the test because if I run sudo conntrack --buffer-size 212992 -E -o id -p tcp --any-nat while running the test locally, no connections are shown by conntrack.
The connections show if I remove the --any-nat parameter.
In other words, the integration test should have been failing.

The existing test was working because, for some reason, the connection between the client and nginx (through Weave) was using NATting. Here's the report.json.gz at the point at which the test was successful.
And here are the relevant pieces from the Endpoint topology:
    "host1-weaveworks-scope-7212-0;<IP_ADDRESS>;60566": {
      "id": "host1-weaveworks-scope-7212-0;<IP_ADDRESS>;60566",
      "topology": "endpoint",
      "counters": {},
      "sets": {},
      "adjacency": [
        ";<IP_ADDRESS>;80"
      ],
      "edges": {
        ";<IP_ADDRESS>;80": {}
      },
      "controls": {},
      "latestControls": {},
      "latest": {
        "addr": {
          "timestamp": "2017-05-18T19:22:16.618664092Z",
          "value": "<IP_ADDRESS>"
        },
        "port": {
          "timestamp": "2017-05-18T19:22:16.618664092Z",
          "value": "60566"
        },
        "conntracked": {
          "timestamp": "2017-05-18T19:22:16.618670138Z",
          "value": "true"
        }
      },
      "parents": {},
      "children": null
    },

    ";<IP_ADDRESS>;60566": {
      "id": ";<IP_ADDRESS>;60566",
      "topology": "endpoint",
      "counters": {},
      "sets": {},
      "adjacency": [
        ";<IP_ADDRESS>;80"
      ],
      "edges": {
        ";<IP_ADDRESS>;80": {}
      },
      "controls": {},
      "latestControls": {},
      "latest": {
        "addr": {
          "timestamp": "2017-05-18T19:22:16.61933701Z",
          "value": "<IP_ADDRESS>"
        },
        "copy_of": {
          "timestamp": "2017-05-18T19:22:16.61933701Z",
          "value": "host1-weaveworks-scope-7212-0;<IP_ADDRESS>;60566"
        },
        "port": {
          "timestamp": "2017-05-18T19:22:16.61933701Z",
          "value": "60566"
        },
        "conntracked": {
          "timestamp": "2017-05-18T19:22:16.618670138Z",
          "value": "true"
        }
      },
      "parents": {},
      "children": null
    },

    ";<IP_ADDRESS>;80": {
      "id": ";<IP_ADDRESS>;80",
      "topology": "endpoint",
      "counters": {},
      "sets": {},
      "adjacency": null,
      "edges": {},
      "controls": {},
      "latestControls": {},
      "latest": {
        "addr": {
          "timestamp": "2017-05-18T19:22:16.618672488Z",
          "value": "<IP_ADDRESS>"
        },
        "port": {
          "timestamp": "2017-05-18T19:22:16.618672488Z",
          "value": "80"
        },
        "conntracked": {
          "timestamp": "2017-05-18T19:22:16.618675297Z",
          "value": "true"
        }
      },
      "parents": {},
      "children": null
    },

This means that the connection was happening from IP <IP_ADDRESS> in the client container which was NATed to <IP_ADDRESS> before reaching the nginx container (IP ;<IP_ADDRESS>;80). I guess <IP_ADDRESS> is the Weave interface IP? (The client container has a Weave network IP `<IP_ADDRESS>).
I will re-add my test and see if it fails before adding my fix.

The new test fails without the fix.

@errordeveloper the netlify CI is a bit flakey


fixed style was not parsed correctly into attrs

Version
3.2.7
Reproduction link
sfc.vuejs.org/
Steps to reproduce
see the demo
What is expected?
fixed style should be parsed to object for child component attrs.style
What is actually happening?
fixed style was not be parsed to object , while bind style was parsed  correctly

This working correctly, you should do   <comp style="color:red;"></comp> without the '.

I modified the demo, please see again.
demo link

@posva can you see that ? Please

Why do you think style string should be parsed into objects? It doesn't seem to be a bug to me as we do not expect this behavior.


Adds Option Select component

https://trello.com/c/VCANsToa/233-3-replace-search-filters-with-govuk-checkbox-groups-option-select
The Option Select component is heavily based on the Finder Frontend component: https://github.com/alphagov/finder-frontend/blob/master/app/views/components/_option-select.html.erb
It creates a collapsible container with checkboxes. If checkboxes are selected, a count is displayed and updated. We don't include the search text input from Finder.
Test this in operation by running this branch of the Buyer frontend locally: https://github.com/alphagov/digitalmarketplace-buyer-frontend/tree/bk-replace-filters-with-checkboxes
Option select on Buyer search pages:

My review checklist
I've:

[ ] looked at the code
[ ] tested locally


glass clustering flow + util scripts

Closes #19

Checklist:

[x] I have refactored my code out from notebooks/
[x] I have run flake8 and addressed any linter erors
[x] I have checked the code runs
[ ] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have rebased onto dev (or merged any new changes from dev)
[x] I have documented the code

[x] Major functions have docstrings
[x] Appropriate information has been added to READMEs

[x] I have explained the feature in this PR or (better) in output/reports/
[x] I have requested a code review

What this does
We cluster company descriptions in SIC codes. Flow and utilities scripts can be found in industrial_taxonomy/pipeline/cluster_glass,
The user can choose the minimum sector size to include in the clustering (defaults to 1000)
The flow includes branching for different values of an assigned_shares parameter that controls the % of companies within
a SIC to assign into clusters. We can test performance for different parameter values downstream.
Before running

Install graph_tool
Install topsbm by running gh repo clone martingerlach/hSBM_Topicmodel inside industrial_taxonomy/pipeline/glass_clusters (I couldn't import the topic model when installing via pip @bishax)

I did the following:
Generic stuff

Removed the instructions to clone and fix hsbmtm from the README
added the sbmtm.py repo

flow.py

Added more information about the purpose of the flow
Fixed typos in docstrings
Removed empty and unnecessary steps (leftover from a previous version of the flow)
I separated topic modelling and description clusterings into two steps because it is unnecessary to train a new topic model for each assignment strategy (we only use the strategy to decide how many documents to cluster inside a topic model)
test-mode only runs when not with --production.
Kept all_sectors_corpora as a dict (converting it to a list was a leftover from an older version of the flow where I branched the flow over sectors)
This simplified subsequent steps as you suggested
I clarified the meaning of the assigned-shares parameter
I created {assigned_shares:models, clusters} dicts in the cluster_glass_descriptions step as suggested and used the join step to combine them into a single  dict.

topic_utils.py

Subsumed fit_model code within fit_model_sector
Fixed type typos

utils.py

Removed unnecessary partial in the tokenising pipe
Changed gl_sic4 name
Moved glass_sic4_lookup to the glass_house getters and added new info to the docstring

Changed variable names and apply to slice
I also fixed the typing bug in get_sector

Changed variable names in the dict comprehensions

requirements.txt

I removed the pip install topsbm thing.

I didn't do the following

I tried using the conda decorator to create a virtual environment with graph-tool but this raised a pip install error so I decided to follow your advice in Kuebiko: "stick to using your project’s main environment and only use Metaflow’s conda decorators when you definitely need them."
I tried adding AB's refactored version of sbmtm.py but that raised an error I assume is linked to subsequent changes in graph-tool:

Error message:  minimize_nested_blockmodel_dl() got an unexpected keyword argument 'deg_corr'

I didn't decompose lookup creation and filtering into two functions because lookup creation would have amounted to a thin wrapper doing {k:v for k,v in dict.items()}

Misc

The reason to strip_nes is because we wouldn't want ngrams including generic NE names to appear in sector names generated later. Admittedly, this is unlikely to happen + we could also strip them when we name the sectors. I don't feel strongly either way.

Points for clarification

What do you mean by "input data should be a parameter" (to pipe)?

What I have done:
flow.py

Removed hSBM import
Relative paths for util and topic_util imports
Removed redundant self.sectors
Fixed various typing problems

utils.py

tokenised filtering pipeline takes data instead of a getter
added big_ to sector_tokens_lookup

misc

Renamed utils/utils.py as collections.py

What I haven't done

Branching for each sector

What I have done:
flow.py

Tested with mypy and fixed all typing errors
Updated the docstrings
Added glass_sic4_lookup as a parameter into make_sector_corpora
Removed duplicated self.sectors assignment
Removed comma from topic_utils import

utils.py

Turned glass_sic4_lookup into a parameter for make_sector_corpora

Given issues loading saved models I opted to leave the sbmtm imports as they were previously.
I ran the flow on test-mode and it works.

I turned get_descriptions_tokenised into an argument into make_sector_corpora
I ran it in test-mode and it works.


Adjusting labels on a single worker node group rolls out all worker node groups

What Happened?
When adding, removing or changing labels on a single worker node group it rolls out new nodes for all worker node groups. This is using the CLI; untested with the lifecycle controller.
What should happen?
Modifying the label configuration on a worker node group rolls out only the node associated with that worker node group.
Analysis
The issue was originally found using the CloudStack provider but the bug exists in the majority (probably all) providers.
The code iterates over each worker node group checking if it requires a new template.
The call path ends in NeedsNewWorkloadTemplate. NeedsNewWorkloadTemplate calls a function to compare all worker node groups labels with their existing representations.
If there is > 1 worker node group, the algorithm will return true if there are changes to any worker node group labels.

Should verify the behavior for generating new templates in the lifecycle controller. I don't think the call path reaches NeedsNewWorkloadTemplate because we always generate the CAPI resources and compare the generated output with existing output.


No typescript highlighting for arrow function with line break before first param

From @arznaar on November 8, 2017 17:35
Code below compiles correctly to javascript and runs without error.

VSCode Version: 1.17.2
Typescript version: 2.5.3
OS Version: Windows 10 version 1703 build 15063.540
Reproduces without extensions: Yes

Steps to Reproduce:
Write first param for the arrow function on the next line. Example:
const goodMethod = (param1: string, param2: string) => {
}

const badMethod = (
    param1: string,
    param2: string
) => {
}

Copied from original issue: Microsoft/vscode#37837

This is a similar issue to #481 and some others. We currently do not handle multiline arrow function declarations well

We currently do not handle multiline arrow function declarations well

It still can be reproduced in case of single arrow function

We currently do not handle multiline arrow function declarations well

It still can be reproduced in case of single arrow function

We currently do not handle multiline arrow function declarations well

It still can be reproduced in case of single arrow function

This is duplicate of #481 and cant be fixed because of limitation of the tmLanguage syntax not being able to lookup beyond current line

It's so sad that highlighting works differently than compiler and we have such inconsistencies.

Released VS Code Extension version 0.0.33 that contains #552 which should address issues reported here. After letting it bake in that extension for 2-3 weeks, I could merge #552


Please invite me to the community

Name
Vaibhav Upreti
Discord Username (if applicable)
No response
Additional Context
Hey! My first issue on Web3 Community.

Awesome! Congrats on your first issue and welcome 🎉


Loading a compiled SPV-shader from a buildscript

Template
If you dont understand something just leave it.
If you can provide more detailed information than the template allows for, please ignore the template and present all of your findings.

Version of vulkano: 0.27.1
OS: Linux Pop!OS
GPU (the selected PhysicalDevice): NVIDIA GeForce GTX 1060 6GB
GPU Driver: nvidia 470.86

Issue
I would like to use a build script that compiles my shaders (using shaderc), which outputs the spv-files to the designated OUT_DIR. Because the shader macro does not take other macros like env!("OUT_DIR") as an argument for the bytes, I cannot use it for this purpose. When I tried loading the shader with shader::ShaderModule::from_bytes, it gives me the error assertion failed: word_count >= 1 in vulkano-0.27.1/src/shader/spirv.rs:74:17.
How do I load a compiled shader from the OUT_DIR directory?

That assertion shouldn't be happening. It either means there's a bug in Vulkano, or the SPIR-V file isn't correct. Could you attach the file here so it can be examined?

Sure, This is the compiled shader:
shader1.vert.spv.gz
Which was built from this source:
#version 450

layout (location = 0) in vec2 position;

void main() {
    gl_Position = vec4(position, 0.0, 1.0);
}

I was using this code to compile it:
// (...) kind is Vertex
compiler.compile_into_spirv(source, kind, file_name, "main", None);
// (...)
let ref mut dest = fs::OpenOptions::new()
    .write(true)
    .create(true)
    .open(out_file)?;
dest.write_all(spv.as_binary_u8())?;
dest.flush()?;

I confirmed that the output file was included by the compiler.

I tried running your shader through the SPIR-V disassembler spirv-dis and got this output:
$ spirv-dis shader1.vert.spv
; SPIR-V
; Version: 1.0
; Generator: Google Shaderc over Glslang; 10
; Bound: 27
; Schema: 0
               OpCapability Shader
          %1 = OpExtInstImport "GLSL.std.450"
               OpMemoryModel Logical GLSL450
               OpEntryPoint Vertex %main "main" %_ %position
               OpSource GLSL 450
               OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
               OpSourceExtension "GL_GOOGLE_include_directive"
               OpName %main "main"
               OpName %gl_PerVertex "gl_PerVertex"
               OpMemberName %gl_PerVertex 0 "gl_Position"
               OpMemberName %gl_PerVertex 1 "gl_PointSize"
               OpMemberName %gl_PerVertex 2 "gl_ClipDistance"
               OpMemberName %gl_PerVertex 3 "gl_CullDistance"
               OpName %_ ""
               OpName %position "position"
               OpMemberDecorate %gl_PerVertex 0 BuiltIn Position
               OpMemberDecorate %gl_PerVertex 1 BuiltIn PointSize
               OpMemberDecorate %gl_PerVertex 2 BuiltIn ClipDistance
               OpMemberDecorate %gl_PerVertex 3 BuiltIn CullDistance
               OpDecorate %gl_PerVertex Block
               OpDecorate %position Location 0
       %void = OpTypeVoid
          %3 = OpTypeFunction %void
      %float = OpTypeFloat 32
    %v4float = OpTypeVector %float 4
       %uint = OpTypeInt 32 0
     %uint_1 = OpConstant %uint 1
%_arr_float_uint_1 = OpTypeArray %float %uint_1
%gl_PerVertex = OpTypeStruct %v4float %float %_arr_float_uint_1 %_arr_float_uint_1
%_ptr_Output_gl_PerVertex = OpTypePointer Output %gl_PerVertex
          %_ = OpVariable %_ptr_Output_gl_PerVertex Output
        %int = OpTypeInt 32 1
      %int_0 = OpConstant %int 0
    %v2float = OpTypeVector %float 2
%_ptr_Input_v2float = OpTypePointer Input %v2float
   %position = OpVariable %_ptr_Input_v2float Input
    %float_0 = OpConstant %float 0
    %float_1 = OpConstant %float 1
%_ptr_Output_v4float = OpTypePointer Output %v4float
       %main = OpFunction %void None %3
          %5 = OpLabel
         %19 = OpLoad %v2float %position
         %22 = OpCompositeExtract %float %19 0
         %23 = OpCompositeExtract %float %19 1
         %24 = OpCompositeConstruct %v4float %22 %23 %float_0 %float_1
         %26 = OpAccessChain %_ptr_Output_v4float %_ %int_0
               OpStore %26 %24
               OpReturn
               OpFunctionEnd
error: 50: Invalid instruction word count: 0

The disassembler gives the same error about the instruction word count as Vulkano does. So it appears something is wrong with the generated .spv file.

Okay, that's interesting.. maybe it does not write the entire file? I'll investigate that

As for using OUT_DIR, does it work like this?
bytes: concat!(env!("OUT_DIR"), "/shader1.vert.spv"),

It seems that when syn (the crate Vulkano uses to parse vulkano-shaders) is told to parse a string literal, it is very literal (ha!) about what it accepts and doesn't even accept a macro that evaluates into a string literal, like concat!. It would be nice if there were some way to tell it to evaluate the macro before passing it to vulkano-shaders. Time for me to go puzzle...

Yes, that would be great, as it is the same that macros do when defined using macro_rules!. I also found my error. It seems that my code that writes the file does not replace the file and instead only overrides from the beginning of the file, so there was excess data at the end. This code works now:
fs::write(out_file, spv.as_binary_u8())?;


TypeError: Challenge evaluation failed: can't redefine non-configurable property "document"

Hi @codemanki and team,
I am using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Cloudscraper works fine when run in node. Code:
require('cloudscraper').get('https://sochain.com/api/v2/address/btctest/2N7GbVfHioqGTHEAwftrqSxXf4mk919xySY', (e, _, r) => console.log(r));

Using Webpack, I create one js file (named as index.js) from the cloudcraper module and run it in Firefox 71.0. Code (look here: Tests.zip):
<!DOCTYPE html>

  <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  <meta charset="UTF-8">
  <meta content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" name="viewport">
  <title>Tests cloudscraper</title>

<button id="btnCheckMySochain" onclick="checkMySochain()">This will test cloudscraper when clicked.</button>

This code works fine for a period of time from approximately 8 GMT+2 to 14 GMT+2. Other times, I get an error:
name: ParserError
message:
### Cloudflare may have changed their technique, or there may be a bug.
### Bug Reports: https://github.com/codemanki/cloudscraper/issues
### Check the detailed exception message that follows for the cause.

TypeError: Challenge evaluation failed: can't redefine non-configurable property "document"
constructor: function n(e,t,a){if(e instanceof s)return e;Object.defineProperties(this,h),s.apply(this,arguments),this.name=i,"function"==typeof r&&r(this),Error.captureStackTrace&&Error.captureStackTrace(this,n)}
errorType: 3

Any help would be greatly appreciated.
Thanks in advance.
Vasyl

Please attempt to answer the following questions before submitting a new issue:

What version of Cloudscraper are you using? 4.5.0
What version of Node.js are you using? (Please share the process information)? 10.15.1
When did the problem start occurring? Periodically
How often does the problem occur? Periodically
What is the URL?
https://www.sochain.com/api/v2/address/btctest/2N7GbVfHioqGTHEAwftrqSxXf4mk919xySY
Are there any similar issues? (Please share the links)
https://www.sochain.com/api/v2/address/btctest/tb1qhdx9nylta364u7tkc4qdtyjsekqtw8ml2p29e8

[Х] I have read the README.  Very interesting. Why would it work only in certain periods of time?
Most probably this happens because of this code - https://github.com/codemanki/cloudscraper/blob/master/lib/sandbox.js#L18
You could try putting something like:
    const cache = Object.create(null);
    const keys = [];
    const { body, href } = global;

    if(typeof document !== 'undefined') {
        return;
    }

    Object.defineProperties(global, {
      document: {
....

@Codemanki thank you very much for your reply and help!
Now cloudscraper is working fine. A little later, when the error reappears, I will try your advice.

@vvpgrp my pleasure :) Please let me know if that fix helps or not. If it does, I might add it to the source code

@vvpgrp my pleasure :) Please let me know if that fix helps or not. If it does, I might add it to the source code

Today cloudscraper worked fine with 8 GMT+2, but after 14:36 GMT+2 an error message appeared:
ParserError:
### Cloudflare may have changed their technique, or there may be a bug.
### Bug Reports: https://github.com/codemanki/cloudscraper/issues
### Check the detailed exception message that follows for the cause.
TypeError: Challenge evaluation failed: a is null

Dear @codemanki,
Is there a chance to solve this problem?


HOSTEDCP-1479: Update IBM/networking-go-sdk package

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/approve


Show Pending Checkins

In Starlims Designer I often just the "Pending Checkins" tree so navigate to the forms/code I'm working on.

My proposal would be that we add a button (or CheckBox) to the title bar which filters the tree to only show the currently checked out items. We could just pass a parameter to the GetEnterpriseItems script and call the Enterprise_Data_Providers.CheckInProvider.GetPendingCheckins procedure from there.

GetEnterpriseItems does not load the entire tree currently, it loads one category at a time i.e. it's called every time you expand a tree branch. It uses the selected branch's URI as a starting point to return the items on that level.
I think we would need to add a "Pending Checkins" enterprise category. So... you would call GetEnterpriseItems with a "/PendingCheckins" URI and it would use the CheckinProvider to return the items with the appropriate URIs for each (dropping the /PendingCheckins root). The user would still need to expand each branch to get the the actual checked out items too.
This could work for Search as well. We could have a /Search path followed by the search string e.g. /Search/dsGet and it return everything that matches "%dsGet%" in all categories.
But yeah, the only drawback in using the tree, is that the tree loads collapsed by default and the user would have to dig into the tree to find their items.

Sorry, I hit the wrong button! The issue is not yet closed, but I'm working on it. I guess it'll be finished tomorrow.


Peer To Peer Code Review

When users try to upload a photo with a size greater than 1MB, they should get proper feedback about validation.

Great project Kubilay. I liked the new feature you added with Javascript. Thank you for presenting it to us.

Good job kubilay. As a suggestion, you could try to alert the user with a message when validating file size. with all my respect


Another tweak IBA::compare() for nonfinite values

Make sure mismatched non-finite values are flagged as the biggest differences in the images, so you can find them right away.

LGTM


Setup local databases as group

Setup databases, tables and export to github

Local database created for each team member to work on local machine.


Country Code for EU is not working

Hello! Thank you so much for your module.
The country code for EU is not working. EU, eu, and EUROPEAN_UNION (as listed in the gallery) return the default Unknown flag.
The other country flags are working as intended.
Values:
<CountryFlag countryCode='EUROPEAN_UNION' height='30' onClick={setIsOpen} />
<CountryFlag countryCode='eu' height='30' onClick={setIsOpen} />
Screenshots:

Nevermind! Fixed it by looking at your source. But the gallery needs updating for EUROPEAN_UNION to lowercase and a few broken flags (e.g. Corsica)


Remove stale.yml?

This project has currently a stale.yml file, however it appears probot-stale is not actively maintained anymore, see https://github.com/probot/stale/issues/385.
Though in general, all these stale bots can be disruptive for contributors (see for example https://github.com/actions/stale/issues/719 and linked issues and discussions), so maybe unless you really find yourself in a situation where there are too many outdated issues / pull requests in the future, would it make sense to remove the stale bot?

Also, stalebots are highly controversial. Perhaps it's best not to include it in an endorsed Github OSPO template? I doubt incurring that controversy is going to make it easier for a company to get internal buyin for its OSPO.

Thanks both for the input. I do use stalebot on a lot of things personally and this just got carried over and forgotten. I'll remove it. No need to have stalebot in here.

68f7d2cd663d8753f7770376c11287438bd672ab


Manage sequences in the right way

For sequences,

keep only elements defined in the XSD
put elements in the right order

Why not contribute back to the original project ?
It seems very much alive.

The first few changes we made to the library was a bit ugly and specific to our projects, that's the reason why this fork exists.
But they we'll be deprecated by this version so we'll definitely consider the MR in the next few days.

I'm not sure that the original project will, one day, respond to our needs: in the original project, not respecting the WSDL seems to be a feature (you can look at all the "dummy" tests), and this is the opposite of what we want.

Reading the tests it looks like there's a strict mode. May be we should update this one ? Or add a stricter one ?

This feature is not documented at all, but when I look at the code, it's for the parsing of the WSDL file, not building of the request you send.

:+1: ok for this change

The best way forward is to discuss that with the maintainer, not assume he doesn't want that.


patch version

Stack:

#12
#11
#10 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #12


Add an accessibility development guide

As requested by the FB team @rachelnabors , we'd like to share some thoughts for making accessible react native components to enrich the react native accessibility documentation.

Thanks so much for your contribution! The queue is a little backed up at the moment, but I Will review this as soon as possible :)


https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure

Request type

[ ] New documentation
[ ] Correction or update
[x] Attempt to find out why Safari is not displaying a simple HTML code example from Github correctly

Details

Hi,
First of all, thanks and compliments for the Mozilla HTML course which I have started following a few days ago.
This morning (Sunday October 11, 2020), I started with the section "Document and website structure" and started learning about the basic sections of a document, such as the header, the navigation bar, main content, the sidebar and the footer.
When I got to the Active learning part, I downloaded the code example from the GitHub repository:
https://github.com/mdn/learning-area/blob/master/html/introduction-to-html/document_and_website_structure/index.html
I copied and pasted the HTML code to a Sublime document, which I then saved to a local folder on my Mac.
Upon opening the document with Safari, what I got to see was a simple text which did differentiate between Headers and Paragraphs, but which otherwise did not display structural elements such as a header or a navigation bar.
So far, I've not yet been able to find out whether I've done something wrong, or whether something might be the matter with using Safari to open example HTML documents.
Thanks in advance,
Warm regards,
Jan Wybe Oosterkamp
https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure

Hi @janwybe !
Thanks for getting in touch, and I hope you are finding our content useful!
So to be clear, structural elements like header, nav, section, etc. are not styled in any way by default. They do provide useful semantics that are good for accessibility, but to style them you've got to provide your own CSS.
In this example, the HTML page references a CSS file (see the link element on line 8). This can be found at https://github.com/mdn/learning-area/blob/master/html/introduction-to-html/document_and_website_structure/style.css
Save this in same directory as your HTML file and you see clearer styling of the structural elements.

Thanks for your kind and helpful response, @chrisdavidmills !
After having followed your instruction, the page opened correctly. Then, when I went over de page again to see whether I had missed it somewhere, I realised that I had been getting ahead of myself and that CSS only comes later in the course.
And yes, I'm finding your content most useful; I'm enjoying the course a lot!
Thanks again - Jan Wybe.

@janwybe always glad to help.
Yeah, it was hard to write this course — HTML and CSS are two separate disciplines, but they are so closely related that you can't help but include parts of them in each other's courses. For now, the important thing is to know that you don't have to know CSS right now in the HTML course, but it does help ;-)


fix(scan): do not dedup middleware handlers

🔗 Linked issue
https://github.com/nuxt/nuxt/issues/18518
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
x ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Currently we are deduplicating middleware, which means only one middleware will ever be included in the built app. We should probably only deduplicate routes that have a path.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks!


HDDS-8223. SCM delete block service shoud run wait for safemode to exit.

What changes were proposed in this pull request?
SCM delete block service shoud run wait for safemode to exit.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8223

Looks mostly good. I just suggested a few renames which I think makes the code more readable. Please have a look and let me know what you think.

Your suggestion is very good. I have revised it

Seems like checkstyle violations need to be fixed.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
 21: Unused import - java.time.Duration.
 27: Unused import - java.util.concurrent.TimeUnit.
 30: Unused import - org.apache.hadoop.hdds.HddsConfigKeys.
 37: Unused import - org.apache.hadoop.hdds.scm.ScmConfig.
 54: Unused import - org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_BLOCK_DELETING_SERVICE_TIMEOUT.
 55: Unused import - org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_BLOCK_DELETING_SERVICE_TIMEOUT_DEFAULT.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java
 21: Unused import - java.time.Duration.
 95: More than 7 parameters (found 8).

Note that you can run checkstyle on your laptop easily by running the following from the root of the repo:
./hadoop-ozone/dev-support/checks/checkstyle.sh