using WhenExpressions, skipped task runs

Expected Behavior
According to documentation https://tekton.dev/docs/pipelines/pipelines/#guard-task-execution-using-whenexpressions
"If any of the WhenExpressions evaluate to False, the Task is not run and the Task is listed in the Skipped Tasks section of the PipelineRunStatus."
Actual Behavior
WhenExpressions evaluate to False but Task runs.
Steps to Reproduce the Problem
Example from https://github.com/tektoncd/pipeline/blob/master/examples/v1beta1/pipelineruns/pipelinerun-with-when-expressions.yaml with one modification in line 63 ("exists" -> "some-value"):
apiVersion: tekton.dev/v1beta1
kind: Pipeline
metadata:
  name: guarded-pipeline
  namespace: tekton-execution
spec:
  params:
    - name: path
      type: string
      description: The path of the file to be created
  workspaces:
    - name: source
      description: |
        This workspace will receive the cloned git repo and be passed
        to the next Task to create a file
  tasks:
    - name: create-file
      when:
        - input: "$(params.path)"
          operator: in
          values: ["README.md"]
      workspaces:
        - name: source
          workspace: source
      taskSpec:
        workspaces:
          - name: source
            description: The workspace to create the readme file in
        steps:
          - name: write-new-stuff
            image: ubuntu
            script: 'touch $(workspaces.source.path)/README.md'
    - name: check-file
      params:
        - name: path
          value: "$(params.path)"
      workspaces:
        - name: source
          workspace: source
      runAfter:
        - create-file
      taskSpec:
        params:
          - name: path
        workspaces:
          - name: source
            description: The workspace to check for the file
        results:
          - name: status
            description: indicates whether the file exists or is missing
        steps:
          - name: check-file
            image: alpine
            script: |
              if test -f $(workspaces.source.path)/$(params.path); then
                printf exists | tee /tekton/results/status
              else
                printf missing | tee /tekton/results/status
              fi
    - name: echo-file-exists
      when:
        - input: "$(tasks.check-file.results.status)"
          operator: in
          values: ["some-value"]
      taskSpec:
        steps:
          - name: echo
            image: ubuntu
            script: 'echo file exists'
    - name: task-should-be-skipped
      when:
        - input: "$(params.path)"
          operator: notin
          values: ["README.md"]
      taskSpec:
        steps:
          - name: echo
            image: ubuntu
            script: exit 1
---
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: guarded-pr
  namespace: tekton-execution
spec:
  serviceAccountName: 'default'
  pipelineRef:
    name: guarded-pipeline
  params:
    - name: path
      value: README.md
  workspaces:
    - name: source
      volumeClaimTemplate:
        spec:
          accessModes:
          - ReadWriteOnce
          resources:
            requests:
              storage: 1Gi

Execute PipelineRun

guarded-pr-check-file-97n5x-pod-dl9bg         0/1     Completed   0          107s
guarded-pr-create-file-7wvkp-pod-67vbf        0/1     Completed   0          2m1s
guarded-pr-echo-file-exists-b9bk8-pod-vx4b6   0/1     Completed   0          100s

Note: Task echo-file-exists should be skipped due to WhenExpressions but was executed.

At the same time Task is listed in the Skipped Tasks section of the PipelineRunStatus:

  skippedTasks:
  - name: echo-file-exists
  - name: task-should-be-skipped

Additional Info

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-14T11:09:22Z", GoVersion:"go1.14.7", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.4", GitCommit:"c96aede7b5205121079932896c4ad89bb93260af", GitTreeState:"clean", BuildDate:"2020-06-17T11:33:59Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:

Client version: 0.12.0
Pipeline version: v0.16.0
Triggers version: v0.8.0

@r0bj quick questions, what are the logs for pod guarded-pr-echo-file-exists-b9bk8-pod-vx4b6 ?

@vdemeester Logs are:
+ echo file exists
file exists

My observation is that this issue is related to tasks that use other tasks as an input to WhenExpressions. Tasks which use params as an input seems work ok - they skipped and do not run, as expected.

Quick update: @jerop is working on these and we'll make a 0.16.1 release (https://github.com/tektoncd/pipeline/milestone/34) once these are fixed. Thanks for the quick report @r0bj !

@r0bj thank you for reporting this issue!
we needed to do an additional check for skipping vs executing before creating tasks after variable replacement --
https://github.com/tektoncd/pipeline/pull/3197
it'll be fixed in 0.16.1 release

Quick update: since there are a few issues, we're aiming to have fixes for all 3 in 0.16.2 on Monday

Okay 0.16.2 is up now (https://github.com/tektoncd/pipeline/releases/tag/v0.16.2) please let us know if you still run into problems!


loading...

i have set everything up which has resulted in a loading... on the index page. i get this error on the http://altislifeeu.esy.es/php/login-status.php (note this isnt going to be the domain just setting it up here so i know it all works) page and i get that error i have set everything up right on the default page
this is my default.php file
 1, 'data' => $data));
}

function jsonErr($errMsg) {
	return json_encode(array('success' => 0, 'errMsg' => $errMsg));
}

function getSteamAPIKey() {
	$fileLoc = $_SERVER['DOCUMENT_ROOT'] . '/../passwords.txt';
	if (file_exists($fileLoc)) {
		$fh = fopen($fileLoc, 'r');
		$jsonStr = fgets($fh);
		$arr = json_decode($jsonStr, true);
		$key = $arr['steamAPIKey'];
		fclose($fh);
		return $key;
	} else {
		die('no file found');
	}
}

function postVar($varName) {
	$var = isset($_POST[$varName]) ? $_POST[$varName] : null;

	if (is_null($var) || strlen($var) === 0) {
		return null;
	} else {
		return $var;
	}
}

function getVar($varName) {
	$var = isset($_GET[$varName]) ? $_GET[$varName] : null;

	if (is_null($var) || strlen($var) === 0) {
		return null;
	} else {
		return $var;
	}
}
?>
any help would be great thanks.

Don't need help with this anymore this is now working

ho, how did u get it working? same problem here


求助 Centos7.9 无法安装 byconity-0.2.2 报错。

(you don't have to strictly follow this form)
感谢。求助
OS: Centos7.9 X64
GCC ：gcc-11
Cmake : 3.26.3
python: 2.7
Question
执行如下
rpm -ivh --force --nodeps  --replacepkgs byconity-*.rpm

Hi @mdys , please try the method in this issue #712. We will try to provide the no debug info package in next version

感谢 请问新版本快出来了么？ 需要安装生产了，无比感谢提供这个软件！

Hi @mdys, could you please download this package https://github.com/ByConity/ByConity/releases/download/0.2.2/byconity-common-static_no_debug_info-0.2.2.x86_64.rpm . And rename it into byconity-common-static-0.2.2.x86_64.rpm  and try to install

感谢大佬 ，试了 还是出错

Hi @mdys , please follow this guideline to install the package. https://byconity.github.io/docs/deployment/package-deployment. The ByConity packages has some dependencies and also require you to make change to the configuration files

@mdys  Is this issue fixed?


WIP working through RN64 update process

Hope to finish verifying RN64 with notifee core + test app + react-native module shortly
This is still WIP, it is not ready for merge

RN update done elsewhere


Handle the Connction Errors of forward_geocode_results() in main

https://github.com/syedsadiquh/Geocoding-app/blob/87a31385b2789961e46cef4e41aaea11515ff807/geocoding_main.py#L28

This Issue has been fixed in
commit 816478f - "Added: Exception handled with error message_box GUI"


[GEP-26] Allow replacing SecretBindingName with CredentialsBindingName in Shoot spec (Part 1)

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
This PR allows replacing SecretBindingName with CredentialsBindingName in shoot spec. In order to do that the feature gate AllowCredentialsBinding should be enabled. Mind that not all features implemented for SecretBindings are implemented for CredentialsBindings. The following packages should also be extended to support CredentialsBindings:

pkg/controllermanager/controller/project/activity
pkg/controllermanager/controller/project/stale
pkg/controllermanager/controller/project/quota
pkg/controllermanager/controller/project/shoot/quota
plugin/pkg/global/extensionlabels

The reason for that is that I thought that two PRs will be easier to review instead of one.
/cc @vpnachev
Which issue(s) this PR fixes:
Part https://github.com/gardener/gardener/issues/9586
Special notes for your reviewer:
Release note:

A new field `.spec.CredentialsBindingName` referencing a `CredentialsBinding` was introduced to shoot specification. It is meant to replace the existing `SecretBindingName`. As of now the field is guarded by a feature gate called `AllowCredentialsBinding`.

Mind that not all features implemented for SecretBindings are implemented for CredentialsBindings. The following packages should also be extended to support CredentialsBindings:

pkg/controllermanager/controller/project/activity
pkg/controllermanager/controller/project/stale
pkg/controllermanager/controller/project/quota
pkg/controllermanager/controller/project/shoot/quota
plugin/pkg/global/extensionlabels

The reason for that is that I thought that two PRs will be easier to review instead of one.

Does it make sense to track these pending tasks in #9586?

I cannot edit the issue, but these are next on my TODO list so they will for sure be linked sooner or later to that issue.

/assign

Thanks @timuthy for the review! I separated the feedback in commits so you can follow more easily on the changes


[SPARK-14830][SQL] Add RemoveRepetitionFromGroupExpressions optimizer.

What changes were proposed in this pull request?
This PR aims to optimize GroupExpressions by removing repeating expressions.
RemoveRepetitionFromGroupExpressions is added.
Before
scala> sql("select a from (select explode(array(1,2)) a) T group by a, a, a").explain()
== Physical Plan ==
WholeStageCodegen
:  +- TungstenAggregate(key=[a#5,a#5,a#5], functions=[], output=[a#5])
:     +- INPUT
+- Exchange hashpartitioning(a#5, a#5, a#5, 200), None
   +- WholeStageCodegen
      :  +- TungstenAggregate(key=[a#5,a#5,a#5], functions=[], output=[a#5,a#5,a#5])
      :     +- INPUT
      +- Generate explode([1,2]), false, false, [a#5]
         +- Scan OneRowRelation[]

After
scala> sql("select a from (select explode(array(1,2)) a) T group by a, a, a").explain()
== Physical Plan ==
WholeStageCodegen
:  +- TungstenAggregate(key=[a#5], functions=[], output=[a#5])
:     +- INPUT
+- Exchange hashpartitioning(a#5, 200), None
   +- WholeStageCodegen
      :  +- TungstenAggregate(key=[a#5], functions=[], output=[a#5])
      :     +- INPUT
      +- Generate explode([1,2]), false, false, [a#5]
         +- Scan OneRowRelation[]

How was this patch tested?
Pass the Jenkins tests (with a new testcase)

Test build #56613 has started for PR 12590 at commit 75b8f73.

Test build #56613 has finished for PR 12590 at commit 75b8f73.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56613/
Test PASSed.

Merged build finished. Test PASSed.

Rebased.

Test build #56772 has started for PR 12590 at commit bda4ae6.

Test build #56772 has finished for PR 12590 at commit bda4ae6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56772/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @rxin .
Could you review this PR about RemoveRepetitionFromGroupExpressions?

Rebased.

Test build #56891 has started for PR 12590 at commit 78a42c5.

Test build #56891 has finished for PR 12590 at commit 78a42c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56891/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @rxin .
Could you review this PR please?

Test build #56970 has started for PR 12590 at commit 01ce1a4.

Test build #56970 has finished for PR 12590 at commit 01ce1a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56970/
Test PASSed.

Hi, @marmbrus .
Could you review this PR when you have some time?

Test build #57274 has started for PR 12590 at commit e3bdc16.

Test build #57274 has finished for PR 12590 at commit e3bdc16.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57274/
Test PASSed.

Test build #57411 has started for PR 12590 at commit d16ebc2.

Test build #57411 has finished for PR 12590 at commit d16ebc2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57411/
Test PASSed.

Merged build finished. Test PASSed.

Test build #57540 has started for PR 12590 at commit 2198f0f.

Test build #57540 has finished for PR 12590 at commit 2198f0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57540/
Test PASSed.

@marmbrus . Now, it's ready for review again.
This PR becomes to do much better than what I expected.
Thank you so much.

Thanks, merging to master and 2.0

Thank you, @marmbrus !


Small issue in css exampleSite

Thank you for theme.
I set it up as described in the readme. When I run the example site, the css has some issues. It looks like there is missing a part of the styling.
See the video that I have added.
What could be the cause?
Screencast from 30-12-24 22:53:32.webm

It seems the css file is not built. Make sure you run npm run start or npm run build. Don't use hugo serve because it relies on PostCSS in NodeJS.

That is a quick response!
I do use npm run start.
A stylesheet with the name main.css is being used by the site. It has 881 lines.
This is the console output:
><EMAIL_ADDRESS>start
> concurrently "npx tailwindcss -i assets/css/main.css -o static/css/style.css --watch" "hugo server -D"

[1] Watching for changes in /home/janvc/APPS/flo-it-website/quickstart/{archetypes,assets,content,data,i18n,layouts,package.json,postcss.config.js,static,tailwind.config.js,themes}
[1] Watching for config changes in /home/janvc/APPS/flo-it-website/quickstart/hugo.toml, /home/janvc/APPS/flo-it-website/quickstart/themes/hugo-saasify-theme/config.toml
[1] Start building sites ...
[1] hugo v0.140.2-aae02ca612a02e085c08366a9c9279f4abb39d94+extended linux/amd64 BuildDate=2024-12-30T15:01:53Z VendorInfo=snap:0.140.2
[1]
[0]
[0] Rebuilding...
[1]
[1]                    | EN
[1] -------------------+-----
[1]   Pages            | 75
[1]   Paginator pages  |  0
[1]   Non-page files   |  0
[1]   Static files     | 33
[1]   Processed images |  0
[1]   Aliases          | 26
[1]   Cleaned          |  0
[1]
[1] Built in 1667 ms
[1] Environment: "development"
[1] Serving pages from disk
[1] Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
[1] Web Server is available at //localhost:1313/ (bind address <IP_ADDRESS>)
[1] Press Ctrl+C to stop
[0]
[0] Done in 866ms.
[1]
[1] Change of Static files detected, rebuilding site (#1).
[1] 2024-12-31 00:31:26.528 +0100
[1] Syncing /css/style.css to /

You probably missed updating the tailwind.config.js in the README instructions. I can replicate the same result if the tailwind.config.js is not updated.

Please pull the latest commits, and then copy tailwind.config.copy.js to your website as tailwind.config.js.

I did, and it works, thank you very much!


You do not have permission to call DocumentApp.openById.

Hi again, When I run the code I get the You do not have permission to call DocumentApp.openById. Required permissions:
Message details
You do not have permission to call DocumentApp.openById. Required permissions: https://www.googleapis.com/auth/documents (line 18, file "1")
line 18     var body = DocumentApp.openById(documentId).getBody();
When I run debug it gives body undefined
Any suggestions?
Thanks.
Vlatko

Solution https://stackoverflow.com/questions/50859119/google-script-error-you-do-not-have-permission-to-call-create-line-38-file-m


[1383] Make archived reservations accessible [master]

Resolves #1383 on master

Add 'archived' tab and filter to the Reservations index
Display archived Reservations in the 'Past' category on the User profile page
Add archived trait to the Reservations factory
Update Reservations controller spec with new filter

This looks good

Great, I'll merge both this one and #1398. Thanks!


Add index drawer

Possible candidates for drawer implementation:

https://dile-components.polydile.com/components/dile-app-drawer/
https://component.kitchen/elix/Drawer
https://lion-web.netlify.app/components/drawer/overview/

More alternatives:

https://shoelace.style/components/drawer
https://ketchup.smeup.com/ketchup-showcase/#/drawer

Notes:

Dile seems immature, couldn't get it to work.
Emix seems dead
Lion is too clunky


🗑 Removed "MineGenesis()"

Removed "MineGenesis()" funciton we do not need it anymore.....

Good first pull!


Running commands in parallel

@prabhatsharma any progress on merging this anytime?

No progress whatsoever, closing since this is a ghost town


When setting the location from URL focus the cursor on the UITextView

When setting location, focus the cursor to location UITextView for input.
It is frustrating to me to have to click with the cursor each time I want to paste a URL and seems to be an expected behaviour on macOS platform.

This issue has been addressed in my fork of this work. Check out its releases page.

Fixed!

Thanks Jaden, I build and tested it – works a charm and make such a difference!!


Replace Loki VPA with HVPA

How to categorize this PR?

/area logging
/kind enhancement
/priority normal
What this PR does / why we need it:
Replace the VPA of the Loki with HVPA
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/assign @amshuman-kr @ggaurav10 @rfranzke @vlvasilev
Release note:

Loki vpa is replaced with hvpa

/rebase

Thanks for the PR @Kristian-ZH! The changes look good. My understanding might not be up-to-date, does this change only work for the loki in the seed's garden namespace but also for the loki in the shoot namespaces?

Thanks for the comments and for the help!
The comments should be fixed now.
The HVPA will be applied in Shoot namespaces and the Garden namespace

The HVPA will be applied in Shoot namespaces and the Garden namespace

Was confused by the name DeploySeedLogging 🙂

Changed the Gap values as @ggaurav10 recommended me


Azurite installation reliability

We are seeing reliability issues installing Azurite from NPM. Example build failures:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=687931&view=logs&jobId=1e00682f-6081-5348-8da2-7d601664b2e3&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3
https://dev.azure.com/azure-sdk/public/_build/results?buildId=687906&view=logs&jobId=a29a9301-eb24-55e3-7f41-428a64e7d719&j=a29a9301-eb24-55e3-7f41-428a64e7d719&t=ffad2da6-41f8-5fd8-d02d-4ae0fffc98ee
The frequency isn't high (about 0.5 to 1% of .NET builds). We may want to look at alternative options for hosting this package and/or look at using a container side-car for the build.
Further analysis: The error<PHONE_NUMBER> is a Windows access violation. Nothing indicates that this is a network download issue. It also means that this problem would only be affecting Windows.

Closing. This error doesn't appear to be occuring anymore.


IP address change notification

For a notification of IP address change, I assume the following description (copied from "Handling planned maintenance notifications for Windows virtual machines") applies to the IP address change notification, is it correct? I would like to make sure that since it's not described in this page explicitly.  Thanks.
"By default, notification is sent to subscription owner and co-owners. You can add more recipients and messaging options like email, SMS, and Webhooks, to the notifications using Azure Activity Log Alerts."
Handling maintenance notifications for Windows VMs in Azure | Microsoft Docs
https://docs.microsoft.com/en-us/azure/virtual-machines/windows/maintenance-notifications

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e05cdb94-c985-242c-1460-b16b1ed2df5d
Version Independent ID: 1254aa45-6289-6553-06e5-38766c89d017
Content: Prepare for inbound IP address change - Azure App Service
Content Source: articles/app-service/ip-address-change-inbound.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin

@kazshi Thanks for the feedback! We are currently investigating and will update you shortly.

@kazshi Thanks again for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

@SnehaAgrawal-MSFT I would appreciate if you could provide information here so that I can update my customer.  Thanks.

@kazshi Yes  it applies to the IP address change notification, as well. We will close this out but if you feel you need more information please just let us know.

@SnehaAgrawal-MSFT Thanks for your clarification!


Tab order incorrect in language server options page

Text box should come before the browse button.

Fixed in 15.9


fix(api-reference): add a code snippet for Astro.params with SSR

Description (required)
Based on a discussion in #9673, I updated the Astro.params section with the following changes:

Move the code snippet under In SSR builds, to In Static builds
Add a new code snippet under In SSR builds to show an example specific to SSR

Related issues & labels (optional)

Suggested label:  code snippet update

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
reference/api-reference.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


AnimationPlaybackTracks no longer functioning as intended

Tested versions

Reproducible on 4.3.dev.gh [2efbc6bfb]
Reproducible on 4.2.2-rc3 and 4.2.2-stable
Not reproducible on 4.2.2-rc2 and before

System information
Godot v4.2.2.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; <IP_ADDRESS>86) - 12th Gen Intel(R) Core(TM) i7-12700H (20 Threads)
Issue description
While in-editor seeking of AnimationPlaybackTracks now works as it should, actually playing the animation that uses an AnimationPlaybackTrack no longer plays the referenced animation properly. It also does not seem to work when running the project with this animation setup.
https://github.com/godotengine/godot/assets/79013106/0cb57735-d74a-4169-8af8-8e3e84cce395
Steps to reproduce

Create an AnimationPlayer
Create any animation
Create another AnimationPlayer
Insert AnimationPlaybackTrack and reference the animation in step 2

Minimal reproduction project (MRP)
This is project in the video, it has the steps above already done.
AnimPlaybackTrackBug.zip

The problem seems to be in scene/animation/animation_mixer.cpp at line 1611
a->track_get_key_indices_in_range(i, time, delta, &to_play, looped_flag)
doesn't seem to return anything if the clip lands at 0 seconds on the timeline. I don't really have time to dig any deeper, but hopefully that give someone a starting point

The problem seems to be in scene/animation/animation_mixer.cpp at line 1611

It is not related since immediately after playback it never goes through line 1661.
This is actually due to some missing processing that should be taken into account for the internal seek (meaning immediately after playback). I have sent https://github.com/godotengine/godot/pull/90960 to fix that, so please check it if possible.


Azure campaign images (to be used on external ads)

Description
These images won't be live on the website. Since they don't have storage, I need them to exist in pulumi.com, so they can be pulled to appear on the ads.
Checklist:

[ ] I have reviewed the style guide.
[ ] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

I think it would be good if we could put these (and future images for the same use) into a new subdirectory under the static/images directory just to help with organization


updater: Fix hang on shutdown

If the manager is shut down during a task update, updateTask might still delay, and block the shutdown process.
Have the closure of stopChan abort updateTask.
cc @tonistiigi @dongluochen

SGTM

LGTM

Current coverage is 54.53% (diff: 25.00%)

Merging #1857 into master will decrease coverage by 0.28%

@@             master      #1857   diff @@
==========================================
  Files           103        103
  Lines         17250      17256     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           9456       9410    -46
- Misses         6649       6703    +54
+ Partials       1145       1143     -2

Powered by Codecov. Last update fef7386...51299d3

LGTM


Add TSC Meeting Notes from 2022-06-21.

Signed-off-by: Andre Pradhana<EMAIL_ADDRESS>

@apradhana have you managed to sort out your CLA for this one?


Image Grid always treats LaTeX entries as seperate

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
Yes
Minimal theme version
7.3.2
Describe the bug
When using the Image Grids feature, LaTeX snippets like this $$ F_x = zzy $$ always render in a separate column from the image or the surrounding text. My ideal use case is being able to type in mostly text with small snippets of LaTeX in one column, and images in the next.
An example of what I'm referring to:

If this is intended, may I ask why?
Either way, a huge thanks for the image grids functionality and this theme as a whole - there's no better option for quickly making columns in Obsidian (that I've found)
Debug info
SYSTEM INFO:
Obsidian version: v1.4.14
Installer version: v1.4.13
Operating system: Windows 10 Pro 10.0.22621
Login status: logged in
Catalyst license: none
Insider build toggle: off
Live preview: off
Legacy editor: off
Base theme: dark
Community theme: Minimal v7.3.2
Snippets enabled: 0
Restricted mode: off
Plugins installed: 22
Plugins enabled: 19
1: Lapel v0.1.1
2: Annotator v0.2.10
3: Binary File Manager v0.3.0
4: Callout Manager v1.0.1
5: Code Editor Shortcuts v1.14.0
6: Dataview v0.5.59
7: Editor Syntax Highlight v0.1.3
8: Minimal Theme Settings v7.2.4
9: Natural Language Dates v0.6.1
10: Omnisearch v1.17.1
11: Outliner v4.8.0
12: Settings Search v1.3.9
13: txt as md v0.0.1
14: Text Extractor v0.4.8
15: Templater v1.16.3
16: Tasks v4.9.0
17: Task Collector (TC) v1.0.12
18: Style Settings v1.0.7
19: Paste URL into selection v1.7.0
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

Yes this is expected. To create a space add a line break.


Can't sync HBO Max

The settings keep stating "Not Logged In: Looks like you're not logged in to this service. Please go to the page below and log in before trying to sync."
I go to the link, log in to HBO Max, and the error still appears.
I've also tried signing out of all devices, and still the error appears.
What does happen, however, is that although any new tab I open will be logged in to HBO Max, clicking the link takes me to a landing page where I am NOT logged in.
Is there perhaps a setting in HBO Max that I need to change to make this work? Or within the extension?

Same here, Chrome 109.0.5414.119 on macOS. W

Not Logged In
Looks like you're not logged in to this service. Please go to the page below and log in before trying to sync.
https://www.hbomax.com/

When I click https://www.hbomax.com/ I'm redirected to https://www.hbomax.com/fi/fi where I am logged in.

It's working now, although it's only showing history back to 5th Feb 2023 (so 1 month and 1 day). Is it possible to fetch more history, like with Netflix?

Yeah, seems like this could be added to the "Known Issues" in the readme? There are several open issues showing the same thing.

Are other people still able to sync now that HBO Max is now Max? I haven't been able to sync since the changeover.

Are other people still able to sync now that HBO Max is now Max? I haven't been able to sync since the changeover.

I haven't been able to sync since they changed HBO Max to Max either.

It's working now, although it's only showing history back to 5th Feb 2023 (so 1 month and 1 day).
Is it possible to fetch more history, like with Netflix? Edit: history issue already reported at #245

How did you get it to work? I'm having the same issue I think. I'm logged in, but the plugins says I'm not...

@tlauen I don't think I did anything, but don't have HBO right now.


Array Validation stops on first element

my schema:
creditAccounts: {
                type: 'array',
                items: [ {
                    type: 'object',
                    properties: {
                        recordType: {
                            type: 'number',
                            const: 3,
                        },
                        beneficiaryAccountNumber: {type: 'string'},
                        beneficiarySortCode: {type: 'string'},
                        paymentDate: {type: 'string'},
                        paymentCurrency: {type: 'string'},
                        paymentAmount: {type: 'number'},
                        beneficiaryName: {type: 'string'},
                        paymentReference: {type: 'string'},
                        dealerId: {type: 'string'},
                        dealerRate: {type: 'number'},
                    },
                    required: ['recordType', 'beneficiaryAccountNumber', 'beneficiarySortCode', 'paymentDate', 'paymentCurrency'],
                }]

when I validate,.it fails for the first element in my array but not the others which have the same error.

Your schema is only supposed to validate first item - please see the JSON schema spec

In case anyone landing here needs an actual explanation of how this can be fixed based on the json schema spec:

If your items property is an array, it will validate only on the first item --> tuple validation.
If your items property is an object, it will validate all items in your array --> list validation.

So to fix your issue, you would need to change your schema to using on object (aka singe schema), like this:
creditAccounts: {
                type: 'array',
                items: {
                    type: 'object',
                    properties: {
                        recordType: {
                            type: 'number',
                            const: 3,
                        },
                        beneficiaryAccountNumber: {type: 'string'},
                        beneficiarySortCode: {type: 'string'},
                        paymentDate: {type: 'string'},
                        paymentCurrency: {type: 'string'},
                        paymentAmount: {type: 'number'},
                        beneficiaryName: {type: 'string'},
                        paymentReference: {type: 'string'},
                        dealerId: {type: 'string'},
                        dealerRate: {type: 'number'},
                    },
                    required: ['recordType', 'beneficiaryAccountNumber', 'beneficiarySortCode', 'paymentDate', 'paymentCurrency'],
                }

It's really a simple fix :) hope this helps!


Feature request: cloudflare protected email deobsfuscation

First of all, excellent module, it has saved me a lot of time and effort.
Would it be possible to add support for de-obsfuscating cloudflare email fields?
A code snippet detailing the process can be found here: http://www.saltycrane.com/blog/2015/07/calling-javascript-python-de-cloudflare-scraped-content

It would be possible. But I won't be doing it, sorry. It would primarily be used by spammers seeking to harvest email addresses. I definitely don't want to encourage anyone using this library to attack or harass websites or individuals.

I will say one annoyance that pops up is that cloudflare matches any string with an "@" symbol as an email address.  So even things like episode titles with an @ in the name get obfuscated.

This was my problem, too - any time I scrape content with an @ in the middle of a string, it gets converted to a protected email field. So far I have been correcting them manually, but it has been tedious. I have no wish to harvest email addresses. It would have been fine if Cloudflare were using an actual email regex, or didn't have the feature turned on by default.

Sorry about that, but you should take that up with Cloudflare's customer service. I have no doubt the vast majority of people who would use this feature intend on giving it to spammers, even if there are some legitimate use cases.


Updated npm dependencies

R: @addyosmani @gauntface @wibblymat
A few of the dependent libraries have been updated since the last sw-precache release.
I don't see any breaking changes that would affect our usage from the release notes of each library, and functionality seems to be identical, so I'm not updated any actual code to account for the major version bumps.

Appears to work for me. :+1:


cmd/go: list confuses imports

go list std cmd should show information about the standard math/rand package, but it seems to only show information for math/rand compiled for cmd/compile, or at least with dependencies compiled for cmd/compile.
This bug appears to have been introduced between Go 1.20 and Go 1.21.0. I have not bisected further.
% go list -f '{{.Dir}} {{.Imports}}' std |grep /src/math/rand
/Users/rsc/go/src/math/rand [internal/godebug math sync sync/atomic unsafe]
/Users/rsc/go/src/math/rand/v2 [errors internal/chacha8rand math math/bits unsafe]
% go list -f '{{.Dir}} {{.Imports}}' std cmd |grep /src/math/rand
/Users/rsc/go/src/math/rand [internal/godebug [cmd/compile] math [cmd/compile] sync [cmd/compile] sync/atomic [cmd/compile] unsafe [cmd/compile]]
/Users/rsc/go/src/math/rand/v2 [errors internal/chacha8rand math math/bits unsafe]
%

@findleyr  I wonder whether this is the source of a number of the metadata inconsistency problems we've been seeing in gopls.

I also wonder whether this is related to the various ssa panics that go away when compiling with 1.22 (#65608). That could be explained by a go list inconsistency for a package.

@adonovan while it does look like there's a bug in cmd/go, I believe for this specific case we won't encounter that bug as we disabled PGO in go list in https://go.dev/issue/60456.

It does seem quite likely this is related to PGO.

git checkout go1.21.0 && git qbisect --from go1.20 --setup ./make.bash zsh -c "go list -f '{{.Dir}} {{.Imports}}' std cmd |grep /src/math/rand | grep 'math sync'" says 45b74d20a08d8e5159480d86f95073b9ea661cc6, which confirms PGO, but otherwise isn't very helpful.

Wondering what is happening with this bug (during weekly release checkin meeting). Any updates?

@matloob Are there updates on this? This is currently a blocker for Go 1.23 RC 1. Is this important enough to be considered a release blocker for Go 1.23?

@matloob Is there is status update on this issue? This came up in the release meeting.

Not yet. I plan to start looking tomorrow.

So it looks like what's happening is that while when we split off the pgo variant of a package, while we clone the Internal.Imports slice so that the actual import links between packages are different, we don't do the same thing for the (non-internal) Imports field. See https://github.com/golang/go/blob/1c924572d07df9c267028a20ee8934a94bfd7f8c/src/cmd/go/internal/load/pkg.go#L2948 for where the split is done.
The split code is does the following
	p1 := new(Package)
	*p1 = *p
	p1.Internal.Imports = slices.Clone(p.Internal.Imports)
	p1.Internal.ForMain = pmain.ImportPath

where p is the original package. So the slices point to the same arrays and other pointers in p at the time of the split are shared.
So the pgo and non pgo variants share the same (PackagePublic) Imports slice. When the list code updates the package public Imports, it then ends up modifying the original too.


Add operation sorting to make sure they are in the proper order

Golden CL: https://github.com/googleads/google-ads-python/pull/693

@BenRKarl PTAL


Set default browser not working

Hi again,
you can set the default browser in Chrom* via settings and inital toolbar button.
Somehow, this does not work for me in Thorium. Default browser is definetly not set.
Do you know what this might cause?
Cheers
midzer

@midzer This is an upstream bug. I noted it in https://github.com/Alex313031/Thorium/blob/main/BUGS.md I have pushed a "fix" that simply appends --no-default-browser-check in the .desktop file to prevent the annoying infobar every startup. You can still set it as the default in your window manager. In Ubunutu/PopOS/Gnome you can do that in settings. In xfce it's default applications. In openbox (what I use), I recommend galternatives.
What OS/DE are you using, and how did you find Thorium?
Thank you muchly for being my third official user, it keeps me motivated to keep improving Thorium and not just rebasing existing patches on chromium trunk. I just added a patch that will (supposed to) enable VAAPI on older intel chips, namely nahalem/sandy bridge/ivy bridge.
Also, the next release is changing the profile dir from $HOME/.config/chromium to $HOME/.config/thorium. This will allow running chromium and thorium side by side and will prevent user profile errors from version differences for people migrating from chromium to thorium.
If upgrading from an earlier thorium release (once this patch lands tommorow), I recommend sudo apt purge thorium-browser-unstable, then making the thorium dir in .config and copying all content from chromium into the thorium dir, then reinstalling. This will migrate your user profile dir over.

I am using Debian bullseye with Cinnamon Desktop and found Thorium via https://chromium.woolyss.com/#linux-64-bit and tested it immediately:
My Speedometer score went up 5 points (from 99 to 104) compared to latest Chrome Dev build (https://twitter.com/midzer/status/1467595495140900876). In addition Thorium "feels" way more fast and instant. Browsing with it is a real joy!
If I can support this project give me a hint, whether it's testing or else.

@midzer I'm using CrunchBangPlusPlus, a minimalist Openbox distro based on Debian Bullseye https://crunchbangplusplus.org/. And yeah, besides the various patches and installer changes, It is compiled with AVX, FMA, LOOP Optimizations, PGO, ThinLTO, and has CFlags and LDFlags set to 3, all of which increases the binary size by about 50mb compared to a vanilla chromium build, but increases performance substantially. Have you read the README.md? And yeah I've been using chromium.woolyss.com for forever, using the windows xp builds back in 2015 and still do (Im also a legacy OS enthusiast, ask about my IBM PS/2 machine and various win 95/98/NT/pentium iii/pentium4/core 2 duo machines lolol), using it on my win 7,10, and 11 drives, and using it on my linux drives until about 6 months ago when I started building chromium myself. I then got into contact with RobRich (we have a discussion here https://github.com/RobRich999/Chromium_Clang/issues/26  where we help each other improve chromium). Rob makes the releases right above mine on Chromium.wooylss. Anyway, I then decided to make my own fork, with all the most important (IMO) patches from various sources and compiler optimizations shared by Rob. Thorium is my favourite element, and thus Thorium was born. I daily drive it and always test my own releases before uploading. Rob shared Jerry's (chromium.woolyss.com creator) contact info, and I asked him and showed him my project, and he accepted! It is a great honour and very exciting to be part of chromium.woolyss, and this is one of the reasons - gaining more users!
As far as helping, I'd love testers for various platforms (I build for windows, other architectures, and just recently Android). And also I would like someone to help build, as I'm on an overclocked AMD FX-8370 and even at that it takes 3-4 hours to compile. If you or someone else has a more powerful system It would help. The readme has instructions on building but if you or anyone else wanted to help build, I would give an interactive demo on how to build it sucessfully. I am down to video chat, give out my email, and have just about every social media besides tiktok (gross lol) It would also allow you or someone else to test their own changes, or tailor it to their system (by setting AVX2 or AVX-512 for example, which my system lacks and I can't cross build for that, but I am getting a Haswell i7 4790K and Z97 board for christmas which will help). And my fine sir, always feel free to ask questions, offer suggestions, and make bug reports/issues. Nothing is off limits, even stuff that has nothing to do with Thorium, because I like learning and love Linux/FOSS.
Again thank you for using Thorium, and welcome to my GitHub page(s).
I also build ChromiumOS for general pc usage, it has codecs, firmware, extra packages, and API Keys to sign in. > https://github.com/Alex313031/ChromiumOS and a pretty shell script called TrImLy to automate defragging/trimming depending on HDD/SSD for ChromiumOS, for which it doesn't do automatically like ChromeOS does on chromebooks > https://github.com/Alex313031/TrImLy
And I also build my own chromium app, called Chromium Dev Editor, which is a revived version of an abandoned project by google to make an IDE for Chrome written in the DART language. > https://github.com/Alex313031/Chromium-Dev-Editor
Also (sorry this is getting long) I have various snippets and small .bat/.bash/.vbs scripts one might find useful here > https://github.com/Alex313031/Snippets and here > https://github.com/Alex313031/PageFileMon
Last thing. Tell me about yourself. Age/Country/State/Interests/Job. How you became a Chromium user/lover. And YOUR projects you'd like to share with me (I'm gonna look through your GitHub right now but share anything you wish)
Cheers, m8 - Alex313031

Thanks for your introduction :)
Probably I can't help out with building Thorium as I'm running a rather ancient machine (i7-2600k Sandy Bridge) myself, too. Thats why I'm highly interested in those Thorium-Special AVX only builds. I made another issue and requested ARM32 builds for my Samsung S5 (from 2014).
If the project evolves and gets bigger, we might need a proper website for it. GitHub Pages will do at the beginning. Later we can get thorium-browser.com or similar. I'm familiar with web dev, so I can help there.

I don't know how much FMA4 is worth it, but we could use it for Thorium repo and not remove it.
We could use Thorium-Special for ARM32/64 and older CPU builds (SSE4 only and AVX only).
Yeah, I OC'd my CPU yesterday to 4,5GHz in Turbo Mode Single Core :D
Jup, av1me uses ffmpeg and is a batch tool for many videos in a folder to convert them.
I'm from Munich, Bavaria as stated in my profile. Check out my personal homepage for more info (some german there though).

Okay, did not want to interfere with build strategy, just my two cents as I'm newbie :)
Have a look at https://docs.github.com/en/pages, custom URL would be probably better if projects matures.
THX for AVX build!
I can try ChromiumOS on one of my USB sticks, yes :)

No, you're not interfering at all.
And thanks.
And you is welcomz
Are you familiar with ChromiumOS? (just the equivalent open source project to ChromeOS i.e. Chromium <> Chrome & ChromiumOS <> ChromeOS.) The main thing is that ChromiumOS can run on non chromebook hardware, although there is a project called Brunch https://github.com/sebanc/brunch that allows booting ChromeOS on many regular PC's
It can be written to USB with dd, or https://www.balena.io/etcher/ and booted like any other linux os.
Latest release is here (.7z contains the chromiumos_image.bin file) > https://github.com/Alex313031/ChromiumOS/releases/tag/R98.0.4729.0
You'll need a 16gb usb drive or bigger. Normal ChromiumOS images are 6.8 gb and can fit on a 8gb drive, but mine has added packages and firmware that bring the size to 9.8gb.
Also it has API Keys to sign in, but you'll still need to add your google account to https://groups.google.com/u/1/a/chromium.org/g/google-browser-signin-testaccounts as per https://www.chromium.org/developers/how-tos/api-keys as stated in the readme.

@midzer Going to close this issue now.


Glossary: Add WebVR/VR terminology and definitions

Added a stub to /about/glossary. Perhaps the wrong place for it. Thoughts? Perhaps separate glossaries for /creating and consuming (most else)?

I put it into getting-started since I see this as a basic information.  https://github.com/WebVRRocks/webvrrocks/commit/97f68d5af3bd6660dcb7ed1834e3086c64811b81
I really like how smashingmagazine makes it a resource as well: https://www.smashingmagazine.com/2009/05/web-design-industry-jargon-glossary-and-resources/
A bunch of word definitions on their own doesn't do anyone much good and this seems like a good middle ground.

Inspiration:

https://www.freeflyvr.com/virtual-reality-glossary/
http://fabbula.com/willing-suspension-of-disbelief/

Really good start at a glossary: https://github.com/w3c/webvr/pull/149/files#diff-ec9cfa5f3f35ec1f84feb2e59686c34dR45

Another: https://virtualrealitypop.com/vr-glossary-81f1d8b5dccc


Minor fix to retry in mistral querier

Minor code refactoring and unit tests added.

The goal is to retry even on a ConnectionError - correct?

Yes. The goal is to exponential retry on ConnectionError. This patch though is just refactoring to be consistent with using they retrying decorator.


full screen iOS 8

in order the capture of problem.
thanks. bye.

The problem is status bar ...
newRect = superView_.bounds;
newRect.size.height = newRect.size.height - 20; <--- i put a path
bye

Thank you!


Check if it would not be better to create a webpack loader or plugin to handle dependencies requirement for the DLL

The problem is that it is not as simple as just using the name of the package listed in dependencies for the vendors-list. For example angular-i18n, there is no require('angular-i18n') as you can only cherry pick the file you are interested in. Perhaps a better way would be to use a webpack plugin/loader.
An idea would be to check how create-react-app do it and get inspiration from them.

Going to use autodll-webpack-plugin


Post your Dockerfile here please and I will give you some suggestions about what you can trim to make it smaller!

@penhauer-xiao please post more information, so we can help with your issue.

@kingdonb  Very thank you very much, the problem is solved. Java virtual machine compressed to about 400M.   Perhaps consider Alpine Linux

We've had others suggesting that we should support Alpine Linux.  I'll make a note.
The next release should be a bit smaller, as we've stopped building the PAM packages.  I'm not sure how much that adds to the release bundle size, but it's probably non-trivial amount.


Add Plugin Settings Page

Will need to save values for #21

@creecros
<a
		href="#"
		class="glancer-extra"
		title="<?= $this->configModel->get('tooltip_title', '') ?>"
		target="_blank">test

Please explain how I am meant to call the setting.  Im getting a white screen right now and Im really confused on how to call the setting... I already tried the if (!empty)

                   //check box in settings

@creecros
<?= $this->configModel->get('tooltip_title', '') ?> doesnt work
<?= $this->task->configModel->get('tooltip_title', '') ?> this works on the text field (not even in the docs)
...but we working the config side, not in the task...

@creecros <?= $this->configModel->get('tooltip_title', '') ?> doesnt work <?= $this->task->configModel->get('tooltip_title', '') ?> this works on the text field (not even in the docs) ...but we working the config side, not in the task...

@creecros please explain... is it okay to use this task for this plugin when it has nohing to do with tasks (for the config settings pages)

ues, in a template it is $this->task->configModel

@creecros
<a
		href="#"
		class="glancer-extra"
		title="<?= $this->configModel->get('tooltip_title', '') ?>"
		target="_blank">test

Please explain how I am meant to call the setting. Im getting a white screen right now and Im really confused on how to call the setting... I already tried the if (!empty)

$this->task->configModel->get('tooltip_title', '')  the last '' in this is your default value, if it is empty. So you can actually put a default link in there, i.e. $this->task->configModel->get('tooltip_title', 'http://mydefault.com')

yes, in a template it is $this->task->configModel, anywhere else, it would just be $this->configModel
and yes, the docs leave that out, but my examples i gave should help in the usage.

yeh your examples help alot but with a generic word like 'task' it confused the hell out of me as we have a 'tast' feature in kanboard.... the docs should be more detailed.  the new version is harder to read and feels like more information has removed.  been 7 days since my PR hasnt gone through either for the plugins.json.... not sure if i should still continue working on kanboard

ya, i dont know whats going on with either of those, im the same as you, just some guy who at one point in time enjoyed working on kanboard. i really only use it to keep my mind occupied and help increase my programming aptitude. i should probably devote time to docpht, since i at least have skin in that game.

@creecros I dont understand why this is not working in the template.... only if i complete the blank value will it show but the whole point is not to have a blank value
rel="<?php if ($this->task->configModel->get('not_allowed_tracking', '') == 'not_allowed_tracking'): ?> noreferrer noopener <?php endif ?>"


Okay. Why is the DATA NOT AN ARRAY!

Please restructer it for Arrays. Would be much easier to parse.
The District wise JSON file.

Have you taken a look at the version 2 api for state-district-wise api?
The data is arranged as an array in it.
Link: state_district_wise v2

Yeah sorry , checked it later, sorry
On Sat, 18 Apr, 2020, 8:32 pm Cibin Joseph<EMAIL_ADDRESS>wrote:

Have you taken a look at the version 2 api for state-district-wise api?
The data is arranged as an array in it.
Link: state_district_wise v2
https://api.covid19india.org/v2/state_district_wise.json
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/covid19india/api/issues/134#issuecomment-615885633,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGETRXBBGK3OIRFZIEPA7MDRNG6GRANCNFSM4MLGMIZA
.


Syntax Error: Octal Literal error - "todo" does NOT work.

http://i.imgur.com/YkpwPF8.png
Syntax Error: octal literal '0076' must be prefixed with '0o'
Seems that the script isn't critical - it does NOT crash, however, only "todo users" will work. todo does NOT work.

Looks like the asana script.   This repository has been deprecated for awhile in favor of npm packages, and it looks like this one was extracted to https://github.com/hubot-scripts/hubot-asana . I'd give that a try to see if it works any better.

cc https://github.com/github/hubot-scripts/issues/1641 for details on the deprecation


Expo tutorial failing to build

Expected Behavior
XCode should build the project
Current Behavior
Build is failing:
fatal error: module map file '/Users/me/Library/Developer/Xcode/DerivedData/myapp-coktmzdtbaovyjfokbdvhvmbqdjl/Build/Products/Debug-iphonesimulator/react-native-ble-plx-swift/react_native_ble_plx_swift.modulemap' not found
Steps to Reproduce
I followed the guide on GitHub and also this guide:
tutorial
Context
package.json:
{   "main": "node_modules/expo/AppEntry.js",   "scripts": {     "start": "expo start",     "android": "expo start --android",     "ios": "expo start --ios",     "eject": "expo eject"   },   "dependencies": {     "expo": "^32.0.0",     "expokit": "^32.1.1",     "react": "16.5.0",     "react-native": "https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz",     "react-native-ble-plx": "^1.0.3"   },   "devDependencies": {     "babel-preset-expo": "^5.0.0"   },   "private": true }

So turns out i needed to launch the application from the workspace project in XCode. Opening the workspace project and hitting the 'Play' button got the application up and running.
I'm quite new to IOS development, so i guess this was one of the first hurdles.

Resolved with above comment.


Custom selector for prometheus service auto discovery

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The auto discovery of prometheus uses hardcoded labels which just gets longer and longer.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Allow the user to specify selectors that point to the right service.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Forking the repo
Are you interested in contributing a PR for this?
Yes/no. If yes, we will provide guidance what parts of the code to modify and help you.
Not sure yet.
Additional context
Add any other context or screenshots about the feature request here.

Hi @mrueg, we are open to a PR for this! Absolutely.

It would be best to base the PR on the prometheus-workload-loader branch which has some major changes that will be merged soon.

One more thing: note that as a workaround you may be able to use --prometheus-url


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_4605cc69-0404-412c-8e03-f116587281ca/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_4605cc69-0404-412c-8e03-f116587281ca.git

Docs Build status updates of commit 51c0f14:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-09-03-02-37-33 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-09-03-02-37-33

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


⚠ Bofrost.de has degraded performance

In 2a62be8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1990 ms

Resolved: Bofrost.de performance has improved in 1a83e52.


Refreshing this branch to use for Netbox going forward

Too many small commits in Main branch that are application hotfixes, so reusing the application branch.

Looks okay, will not change streamlit app to applications branch.


ol.geom.Circle is not considered in ol.interaction.Snap, exception is thrown

I have a layer based on ol.source.Vector with collection of the following features:

Point
LineString
Polygon
GeometryCollection (Circle + Point)

... and want to add snap interaction while drawing over this layer. But I'm getting the following error
VM52171:240 Uncaught TypeError: Cannot read property 'call' of undefined
    at ol.interaction.Snap.writeGeometryCollectionGeometry_ (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:1508:404)
    at ol.interaction.Snap.addFeature (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:1500:289)
    at ol.interaction.Snap.forEachFeatureAdd_ (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:1500:490)
    at Array.forEach (native)
    at ol.interaction.Snap.setMap (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:1505:172)
    at ol.Map.eval (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:598:409)
    at ol.Collection.b (eval at 65 (http://localhost:8080/app.js:1122:1), <anonymous>:128:506)
    at ol.Collection.ol.events.EventTarget.dispatchEvent (eval at 65 (http://localhost:8080/app.js:1122:1),

After investigation of snap.js I found that there are SEGMENT_WRITERS_ which are not defined for 'Circle'. And therefore the exception is thrown.
From my understanding Circle is ignored when features are being added to Snap-interaction, but it's not ignored in writeGeometryCollectionGeometry_ function in snap.js:
ol.interaction.Snap.prototype.writeGeometryCollectionGeometry_ = function(feature, geometry) {
  var i, geometries = geometry.getGeometriesArray();
  for (i = 0; i < geometries.length; ++i) {
    this.SEGMENT_WRITERS_[geometries[i].getType()].call(
        this, feature, geometries[i]);
  }
};

I guess it has sense to proceed with one of the following approaches:

implement SEGMENT_WRITER for Circle
ignore Circle in writeGeometryCollectionGeometry_

See #4304.

Thanks for the quick reply!
I actually don't want to snap to Circles and current behavior is suitable for me. I'm talking only about thrown exception.
Would you accept a pull request, if I make Cirlces ignored in writeGeometryCollectionGeometry_ the same way as it's done in addFeature function (snap.js)?

Yes, please submit a pull request.

It's submitted and waiting for approval

fixed with #6757


Enter keys not working

Hello! It appears when someone sends me a media message, I cannot see it nor reply back, as I type a response and click enter, it only begins a new line. I've tried plugging in a new keyboard, reinstalling and uninstalling and still nothing. I messaged someone else that hadn't sent me a media message and it worked just fine.

To augment this issue, which I too am now seeing, I notice that the last activity was my sending a media message.  So, it appears to arise following either receipt or sending of media messages.


Indicate a recurring billing method to indicate CVV is not expected

From NMI: "It looks like there is an indication that can be submitted
with the transaction that will indicate it is a recurring charge (not
a first time charge) and it should not expect the CVV to be passed.
The “billing-method” will need to be indicated as “recurring” when the
sale is passed through the API"
This is not a problem for most customers but fails for Optimal
Payments, in particular.

@bvandenbos :eyes: please.


add demo for heter pipeline ps

add demo for heterogenous  pipeline parameter server

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


attendance-toggle in meetups pages doesn't work

The attendance toggle in the meetups page doesn't trigger any change in the RSVP state.

I second this...


Updated grammar for "more-about-django-form-classes" documentation.

Trac ticket number
N/A
Branch description
Minor grammatical nitpicks while reading the documentation re: forms.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[ ] I have checked the "Has patch" ticket flag in the Trac system.
[ ] I have added or updated relevant tests.
[x] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

Hi 👋 thanks for the suggestion 🏆, though I'd do it a bit differently 🙂

Thank you both for this discussion.
This is slightly clearer, but considering this would update the translation strings, I'm not sure it is worth the work it would give to others 🤔
@laaksomavrick if you're looking to make a documentation update, picking up https://code.djangoproject.com/ticket/35441 might be a good start 👍


Mention the Python Version for easier deployment

I'm unable to deploy on kaggle (py version: Python 3.10.13), plz mention the py version u have deployed this project.
/kaggle/working/TripoSR
Traceback (most recent call last):
File "/kaggle/working/TripoSR/run.py", line 12, in
from tsr.system import TSR
File "/kaggle/working/TripoSR/tsr/system.py", line 16, in
from .models.isosurface import MarchingCubeHelper
File "/kaggle/working/TripoSR/tsr/models/isosurface.py", line 6, in
from torchmcubes import marching_cubes
File "/opt/conda/lib/python3.10/site-packages/torchmcubes/init.py", line 2, in
import torchmcubes_module as mc
ImportError: /opt/conda/lib/python3.10/site-packages/torchmcubes_module.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3c104impl3cow11cow_deleterEPv

Alright I have been able to run its easily on Python 3.9 (1st tried 3.8 but was not working)


How to upstream?

Hi,
I'd like to know your thoughts on upstreaming.
How is this going to be integrated with the new turnup ux that's developed in sig-cluster-lifecycle?
Really nice thing, would like to make it even more portable

@luxas I believe a core component of the functionality here could be replaced with something like a kubelet pod api. See https://github.com/kubernetes/kubernetes/issues/28138 for somewhat of an umbrella issue.
What this might look like:

Initial node starts the kubelet pointing to an api-server(s), which don't yet exist.
Pod manifests for control-plane (api-server, scheduler, controller-manager) are pushed to kubelet-api.
Once the api-server is running as a pod, daemonsets/deployment objects for control-plane are pushed to api-server.
The higher-order objects (daemonsets/deployments) "adopt" the initially running pods, and we are now self-hosted.

Implementation wise, this should be relatively flexible, but one option is simply using kubectl:
# Create initial control-plane pods
until success:
    kubectl create -f manifests/pods

# Create objects which will adopt those pods
until success:
    kubectl create -f manifests/objects

If we wanted to wrap that in some kind of kube bootstrap command, it would be fine. But hopefully it is such a simple process additional tooling is minimal / relatively unnecessary.
From here, I'm a proponent of the discovery api proposal: https://github.com/kubernetes/kubernetes/pull/28422
So the UX for all subsequent nodes would potentially look something like:
$ kubelet --cluster=v1alpha1/${CLUSTER_ID}

This is a bit dated at this point, but the general plan was for kubeadm to adopt similar self-hosted installation methods (and eventually move to using kubeadm directly). Current tracking issue: https://github.com/kubernetes/kubeadm/issues/127
Closing this in favor of the above issue - with the "upstreaming" plan being to move functionality into kubeadm


API documentation in english

I do not find the English version of the API documentation, is there any available? If there is not, do you plan to publish one?

What swordqiu mentioned, if you use google translate on the chinese docs it does a pretty good job, It only fails on a couple of categories like the kubernetes section of the docs for some reason.


Any games or algorithms in open-spiel on cooperative MARL

Dear Authors,
Just want to ask whether there are some games and benchmark algorithms to support the research on  cooperative MARL.
Thanks.
Hui

We have both full-sized games and smaller games for research purposes. Of course, it's possible to use independent RL approaches (which are implemented), but we don't have any other algorithms implemented in OpenSpiel. What did you have in mind?
Full-size games:

Hanabi (we wrap the Hanabi Learning Environment to conform to the OpenSpiel interface)
Bridge uncontested bidding (a sub-game of contract bridge, used by experts for training / practice)

Small games:

TinyHanabi - a variety of very small cooperative games; see paper reference in the source code
TinyBridge2p - a tiny version of bridge uncontested bidding
CoopBoxPushing
MatrixCoordination

In this paper [A Survey and Critique of Multiagent Deep Reinforcement Learning], there are many methods addressing MARL on cooperative games, however, there is no available open source codes. So it's very different to reproduce these algorithms for a fair comparison. Does you plan to implement some of them?

We could certainly use more cooperative games. We don't have any planned at the moment, but this is why we released it open source: so anybody (such as yourself) can add games! So, I invite you to do add the ones you are most interested in and then everyone can benefit from it.

That's great. I am very happy to merge my new algorithm into open spiel.  I think open spiel is very helpful and influential in MARL communities.


What is the radiograph sample?

Describe the bug
It's not a bug report, just a question. In the screenshots, there is a radiograph sample. But I don't see any trace of it in the code.
Is it a mistake or a sample to come?
I take the opportunity to thank you about your work. There is work to do to refine some styles, but I do like the simplicity of the code compared to other repos with lot of stuff (too much in my opinion).

Hey @YBAZAN. Radiograph is an implementation example. This app is actually the reason I made WPF UI. Before that, it was just a Radiograph module.
The app will be updated soon in the Store:
https://www.microsoft.com/en-us/p/radiograph/9nh1p86h06cg
Data reading is based on:
https://github.com/LibreHardwareMonitor/LibreHardwareMonitor


Provide an ability to mask/exclude certain keys when printing show_locals=True

Hello! We've just started our journey of adopting rich on kedro, the first part of this journey introduced the rich logging handler + pretty tracebacks.
We've just had a user, quite rightly, highlight that show_locals has printed out some credentials in plain text. The immediate fix for this is to set show_locals=False, which we will fix quickly.
My question is as follows, would you accept a PR where we allow the user to exclude certain keys when printing out the stack trace?  I think it would go somewhere in this dictionary comprehension:
https://github.com/Textualize/rich/blob/aea574a215823a7f05e088399745cee00f959324/rich/traceback.py#L376
Thanks!

Agree in principal. Another (possibly complimentary) option might be to have a specially crafted local attribute with a set of keys to exclude from locals.
Something like:
def get_password(self):
    _rich_exclude_locals = {"password"}

This would be more granular than a global black list.
If we were to add a blacklist, perhaps it should accept a list of regexes?

That would be possible with atomic data structures. For other objects you can't really know what attributes will be displayed in the repr. It would also be unwise to iterate over the attributes on an object as Rich may end up invoking arbitrary code via properties etc.
It would be possible for Rich to omit arbitrary __repr__ calls to prevent user code from leaking credentials. You may miss out on some useful debugging information, but that might be a reasonable compromise.

+1, this seems like a big security issue for production

I'd still accept a PR if anyone proposes an elegant solution, but frankly showing locals is a debug aid, and should always be disabled in production.


Update Issue - 3755792

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 38.0

Operating System
Windows XP

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


I-SB-01 test war hazard (address register)

Looking at this section of the test leaves me confused. According my understanding, we load the symbol's address of test_E2_res into x28, subtract 4 from it and compare it against the constant 0x8000403C. This test fails for me since my symbol's address test_E2_res is not anywhere near that value.
Here the excerpt from I-SB-01.S :
    RVTEST_IO_WRITE_STR("# Test part E2 - test war hazard (address register)\n");

    # Address for test results
    la      x28, test_E2_res

    # Clear memory
    sw      x0, 0(x28)

    # Test
    li      x27, 0x89ABCDEF
    sb      x27, 0(x28)
    addi    x28, x28, -4

    RVTEST_IO_ASSERT_GPR_EQ(x27, 0x89ABCDEF)
    RVTEST_IO_ASSERT_GPR_EQ(x28, 0x8000403C) # what is this assertion here for?

Yep, that's very wrong. A lot of these inline assertions are wrong -- the only correct way to run the tests is to compile the test suite without them, via make RISCV_TARGET=spike.

Well, some of the assertion macros are wrong even though they pass on most platforms, since they introduce side effects that change the outcome of the test. I-ADD-01.S is an example; line 84 asserts that a register should be 0 when it should be 1; however, the assertion passes anyway because the register ends up getting set to 0 by the macro itself. See below email from a few days ago to the compliance working group:
The macros are target dependent and are implemented in compliance_io.h, e.g. RVTEST_IO_ASSERT_GPR_EQ. Some registers are said to be reserved and are used by the tests.

False errors get reported by macros because the checked value is a side effect of the macro implementation. As an example rv32i/src/I-ADD-01.S line 84: the code asserts x5 is 0, but the signature checks it should be 1.

The macros are pretty useful because they basically run in many environments. The asserted value should check the real value, and not a side effect of the checking macro. If a macro is using reserved registers, then it should check it and not execute it if a conflict occurs. It is likely possible to use target specific macros that can use fixed memory locations to swap registers and thus avoid solve reserved register issues.

Last comment: by not implementing the macros, it is possible to skip it. If macros are choosen, it is however not possible to skip saving the signature to memory. It would probably save memory and accelerate tests if it was possible to disable signature saving when using self-checking macros.

I just cloned the riscv repo, run the compliance suite and encountered these failures.  So the good news is its repeatable.  :smile:  However, this issue has not been commented on for almost 10 months and is currently not assigned to anyone.   How can we move this issue along?

I just looked at the latest code, and it doesn't resemble the code above. The newest version has an explicit scratch register in the macro arguments, and doesn't check the contents of the scratch register. Could you ensure you ran this with the latest? E.g. the example above has : RVTEST_IO_ASSERT_GPR_EQ(x27, 0x89ABCDEF) while the latests tests look like RVTEST_IO_ASSERT_GPR_EQ(x2, x26, 0x7654321)

This issue no longer exists as the macros have been updated in the test and there is no longer checks on the contents on the signature section


[2.35] - mockClient running middlewares which fails matching to the mock store

In PR #168 we added headers to mock strategy. Now I have an issue in 2.35 release that my mocks are no longer matching because of DurationMiddleware running and setting x-started-at to a value that is later unable to be matched in isExactMatch (specifically in the headerMatch):
    {
      A: 'correlation-id=f497e1b8-0fc8-42c5-87e3-5ef58f39bd8e&service-to-service-request=yes&x-started-at=1637663489675',
      B: 'correlation-id=f497e1b8-0fc8-42c5-87e3-5ef58f39bd8e&service-to-service-request=yes&x-started-at=1637663489668'
    }

A workaround is to do a MockDate.set(date) in a beforeEach - which felt a bit random - but without it the Date.now() values will be mismatching and failing to match the correct mock. Mocks not matching have always been a bit hard to debug, and now it is even harder.
This was unexpected though: We do not provide headers, so the test should just work, right?

Yes, but however, the problem is the fact that mockClient (as per specification!) runs the middleware stack on the mock gateway! This is different to how mockRequest works. So actually, all tests work if switched to mockRequest API instead (without the need for calling MockDate.set(date)).

In summary:

mockClient runs middlewares which potentially adds headers
This can cause existing tests to fail (if they are using mockClient) even if they are not providing headers to the mock definition
#168 was meant to be backwards compatible if your mock definition did not add headers and break if there was mismatch only
#168 got stabbed in the back by mockClient running middlewares which we were unaware of

Any opinions what we should do, a few options:

We can proceed, add warnings about the differences mockClient and mockRequest to the README
We can add best practices about using MockDate.set when running tests (and using DurationMiddleware)
We can try to make this new behaviour more optional
We can revert the whole thing

WDYT? Discuss.

I think we should improve the ergonomics of the DurationMiddleware, maybe use a fixed test date when in test mode. Or ignore the headers in test mode. Users should test user land code and not mappersmith, so I don't see a lot of value in testing auto included headers, wdyt @klippx ?

ignore the headers in test mode.

I like it, for example:
  isExactMatch (request) {
+    // (omitted)

+    const relevantHeaders = { ...this.headersObject }
+    delete relevantHeaders['x-started-at']

    const headerMatch = !this.headers || (
      this.headersFunction
        ? this.headers(request.headers())
-        : isSubset(this.headersObject, request.headers())
+        : isSubset(relevantHeaders, request.headers())
    )
  },

Something like this would completely solve my issue. If we do this then we can forget all about MockDate.set, readme updates and whatnot. My somewhat painful upgrade to 2.35 then suddenly becomes a one liner .set('correlation-id', '123') in one single spec out of 768 in total 👍

Is there any way to track which headers have been included by client middleware, and which have been manually provided in the mock definitions?
I think it'd make sense to take only the latter into consideration when matching mocks, to ensure the mock definition in the test body is a good reflection of what is going to be used as a matcher.
On the other hand, I do believe this problem also applies to parameters and body. A middleware that adds a parameter, for example, might make matching fail even though it's nowhere defined in the mock definition inside the test.
I'd love to understand why we run the client middleware on top of the mock definition 🤔 it came as a surprise for me in the first place to be honest.

There was also this approach suggested which is a lot cleaner and also solves the problem:
@ src/middleware/duration.js:4 @
/**
 * Adds started_at, ended_at and duration headers to the response
 */
- const DurationMiddleware = () => ({
+ const DurationMiddleware = ({ mockRequest }) => ({
  prepareRequest (next) {
+    if (mockRequest) {
+      return next()
+    }
    return next().then(request => request.enhance({
      headers: { 'X-Started-At': Date.now() }
    }))
  }

With this approach DurationMiddleware take responsibility for its own ergonomics.

I don't think this problem is limited to DurationMiddleware. From my perspective, letting middleware change what is going to be matched is very unintuitive and it's what ultimately leads to this issue.
Say I have a middleware that injects a param to outgoing requests called count in my client that increments whenever the middleware is run.
If my mock definition is
mockClient(client)
  .resource('Potato')
  .method('solid')
  .with({
    someParameter: 'is here'
  })

I don't see why we'd take count into consideration when trying to match outgoing requests. They should always be compared using what's in your actual mock definition, in this example, the someParameter param.
On this example as well, we might even be unable to match a request, since the count parameter will be ever increasing.

I appreciate the concern, but this issue is specifically about what I observed in consumer land when upgrading to 2.35 and as far I am concerned this issue can be solved by fixing DurationMiddleware (see #248)
I think that I agree with what you said, but I haven't seen that this is an actual production issue yet. If it is, the right move would be to open a new issue for that and provide a breaking example that proves the point and we can discuss potential fixes there.

@Yurickh a good idea is to add a canonical way for middleware to add headers, so we can track and differentiate between input headers from userland. I think it's a good idea.

@tulios Would this also apply to anything that middleware can modify? Like body and params? This might be a more apparent issue because middleware are more likely to inject headers than anything else, but I do think this issue affects all of the api surface of a request.

I think we can diff the input/output. We could do it for all properties. A bit harder with things like body, but we can still know if a middleware changed it. This change has the potential to improve error messages, etc.


chore: Update CI

Description

Update firebase config and xcode version

Commit message

chore: Update CI config

Screenshot

Testing

[ ] Added unit tests
[ ] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

Code coverage
Total coverage: 93.40%

Powered by Slather

  Generated by :no_entry_sign: Danger


Various improvements to Scene Understanding

Overview
This PR mainly focuses on the following aspects of SU:

Make Guids we receive from the SU binary internal to the SU observer, and for external classes the relevant events are fired with the regular int id as spatial mesh observer currently do.
If the SU observer is instantiating quad/mesh GameObjects, the OnObservationAdded event waits until the instantiation finishes before firing. Also a GameObject field is added to both MeshData and Quad class within the SpatialAwarenessSceneObject class so that when the handler receives the fired event, it can gain access to the instantiated GameObjects.
Remove legacy XR calls and replace some with call to utility function when applicable.
Renamed the SU interface to make it less verbose
General cleanup
Add SU asmdef to exception list

To do

[x] Investigate whether (and if not, how) we can load a serialized scene from file on HL2 This feature is currently not available for spatial mapping so it will not be available for SU as either.
[x] Determine the behavior when SpatialAwarenessSceneObjects are updated (i.e. do we instantiate new GameObjects and remove the already instantiated ones?) Events are now sent when a SASO is first observed, continue to be observed and removed. The instantiated GameObjects managed by the SU observer are updated accordingly.

/azp run

/azp run

Please ignore the doc CI failure as it seems to be not caused by this PR. Running docfx on the current SU branch without the contents of this PR generates these warnings failing the CI as well. However, running docfx on the dev branch with this PR merged into it does not generate the warnings.

/azp run

/azp run

/azp run

/azp run

/azp run


[Bug report] spark connector create hive table from RDD failed for partition schema check

Version
main branch
Describe what's wrong
spark connector create hive table from dataframe failed for partition schema check, because favorite_color is not the last column in dataframe.
Error message and/or stacktrace
java.lang.IllegalArgumentException: Failed to operate table(s) [users_partitioned_bucketed] operation [CREATE] under schema [default], reason [The partition field must be placed at the end of the columns in order]
java.lang.IllegalArgumentException: The partition field must be placed at the end of the columns in order
	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143)
	at com.datastrato.gravitino.catalog.hive.HiveCatalogOperations.validatePartitionForCreate(HiveCatalogOperations.java:569)
	at com.datastrato.gravitino.catalog.hive.HiveCatalogOperations.createTable(HiveCatalogOperations.java:676)
	at com.datastrato.gravitino.catalog.TableOperationDispatcher.lambda$createTable$7(TableOperationDispatcher.java:160)

How to reproduce
val usersDF = spark.read.load("examples/src/main/resources/users.parquet")
usersDF.write.partitionBy("favorite_color").bucketBy(42, "name").saveAsTable("users_partitioned_bucketed")

please refer https://spark.apache.org/docs/3.1.1/sql-data-sources-load-save-functions.html
Additional context
No response

How does Spark itself handle this problem?

For normal Hive table, Spark add extra Project plan after the data query plan to reorder columns.  I just see the result and have not found where added the Project plan.  For datasourceV2, no extra plan is added, maybe because Iceberg like systems doesn't need to recorder columns.

close it as not strong requirement in real enviroment.


Revert "set upper bound on google-cloud-profiler (#23354)"

This reverts commit 8dea86bc9d5abdda866c986a32afd1f611d1c1b2.
Causing beam_PreCommit_Python_Cron to be permared.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @AnandInguva @tvalentyn

LGTM

Nvm, this was caused by the 0.6.0 release.


[BUG] dev experience - rxui for windows desktop currently tied to net6.0.2+

this is just a heads up as been chasing an issue with downstream dll's failing to build against rx ui 17.1.50
CSC : error CS1705: Assembly 'ReactiveUI.Wpf' with identity 'ReactiveUI.Wpf, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' uses 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' which has a higher version than referenced assembly 'PresentationFramework' with identity 'PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
https://github.com/dotnet/core/issues/7176
i've resolved my issue by updating visual studio, but just in case anyone else turns around and states it's not building for wpf\winforms on older versions of visual studio 2022. it does mean there is a ripple effect on downstream projects until the core issue is resolved.
there is a workaround of
<ItemGroup>
<FrameworkReference
Update="Microsoft.WindowsDesktop.App;Microsoft.WindowsDesktop.App.WPF;Microsoft.WindowsDesktop.App.WindowsForms"
TargetingPackVersion="6.0.0" />
</ItemGroup>

happy to do the PR if wanted

This one seems to be resolved @dpvreony can you confirm?

yeah ado and github agents both fine now


Auto-Scaling

How does redis cluster handle auto-scaling in/out depends on load?
In the case of Kubernetes cluster, there is horizontal pod autoscaler. Does it work with redis cluster?

Unfortunately, autoscaling is not supported in this setup. You can add a HPA and it will create extra pods, but since the resharding process is manual, it won't have any effect as the new instances won't receive any keys.
As I stated in the README, I advise you to look for alternatives, since the setup in this repository is probably not that future-proof.


Fix 'NoneType' object has no attribute 'state'

Summary by Sourcery
Fix the error related to 'NoneType' object by passing the client instance to the get_download function and enhance the QbittorrentStatus class by adding a method to access the client instance.
Bug Fixes:

Fix the 'NoneType' object has no attribute 'state' error by ensuring the client is passed correctly to the get_download function.

Enhancements:

Introduce a client method in the QbittorrentStatus class to access the client instance.

Thanks a lot! 💖

welcome


🌐 Add German translation for docs/de/docs/reference/response.md

← reference/httpconnection.md (#10823)
→ reference/responses.md (#10825)
German translation progress

📝 Docs preview for commit d19d7437c95626a3ce7353723169e010e55b8c2b at: https://9d305746.fastapitiangolo.pages.dev

📝 Docs preview for commit 21fd9aafab315633ae243b52fcc431d6d001df3d at: https://226c483b.fastapitiangolo.pages.dev

Awesome @nilslindemann! :rocket:
As you are the champion of German translations and you have done so many, and with so much attention to detail, I'm gonna go ahead and merge this. :tada:
If others see things that could be improved later, we can check that in new PRs. :nerd_face:


Demo/doc left-hand side-bar navigation has too many buttons

With the adding of sections, the left-hand side bar now overflows on the bottom on not-too modestly sized screens (a laptop, in my case). Even though it reduces the flavor, I think we need to lose the "TOP" button and the "SRC" button. Or possibly if someone is feeling ambitious, move them to the bottom horizontal footer frame bar.

Moving them to the horizontal bars entails modifying the element's height. This is something @xenziffen managed to do in their fork. Their solution should be integrated (and/or improved).
On the issue: For the future, it would be preferably if one finds a solution for overlong elements, esp. bars. This could entail "half-height" buttons (not exactly half, I'm afraid) that would also fit in the horizontal bars, also in vertical bars.
After master has been renamed into main, I will open a PR to remove TOP/SRC for a quick fix.

I do encourage you to use/copy any useful changes from my fork. I attempted
PRs then mothballed my local.
The color CSS specificity, horizontal bars and sweep transitions, and
brackets were all adapted and I hope could be useful.
I stalled at audio element improvements and layout templates. I think I
only made 3 standard layouts, and didn't revise the example content as much
as needed.
On Thu, Dec 3, 2020, 13:41 dthv<EMAIL_ADDRESS>wrote:

Moving them to the horizontal bars entails modifying the element's height.
This is something @xenziffen https://github.com/xenziffen managed to do
in their fork. Their solution should be integrated (and/or improved).
On the issue: For the future, it would be preferably if one finds a
solution for overlong elements, esp. bars. This could entail "half-height"
buttons (not exactly half, I'm afraid) that would also fit in the
horizontal bars, also in vertical bars.
After master has been renamed into main, I will open a PR to remove
TOP/SRC for a quick fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joernweissenborn/lcars/issues/64#issuecomment-738336264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3PFB4KEXISNDMT46X6N2LSTAAX3ANCNFSM4UMQ7PVQ
.

@xenziffen I have discovered that you will not be credited as a "contributor" by GitHub systems unless you file a PR. Indeed, I believe there are a few of your commits in there already (I must have branched off of your fork or something), which brought in your work on color specificity (three commits starting with aeec4897376801b496ac7b4ea77ec91c2dcd9dec from around the end of February), but that did not result your addition to the Contributors list.
If that doesn't matter to you, we'll certainly dig further into your work. Or perhaps you could find the simplest of your changes and create a simple, small PR that can be expedited, and that can stand for all of your contributions.


When expanded, menu does not allow for scrolling if height becomes larger than window height

Left navigation doesn't have overflow setup when it's larger than height of window and it also hides the expand/contract on the bottom when it's height isn't perfect.  Attached image, can give visual demo if needed as well.  Please contact Dale Hille on slack for if a demo is needed.

Ignore, will open with the correct account.  This is an old account.


ERROR: Cannot read property 'now' of undefined

Describe the bug
Running tests with inso cli inso run test results into an error.
> inso run test
✔ Select a document or unit test suite · <collection name>
✔ Select an environment · Staging - <env name>
This browser doesn't support requestAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills
This browser doesn't support cancelAnimationFrame. Make sure that you load a polyfill in older browsers. https://fb.me/react-polyfills

 ERROR  Cannot read property 'now' of undefined

  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32481:98)
  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32491:30)
  at __webpack_require__ (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:21:30)
  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32460:20)
  at __webpack_require__ (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:21:30)
  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32169:59)
  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32450:30)
  at __webpack_require__ (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:21:30)
  at Object.<anonymous> (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:32148:20)
  at __webpack_require__ (/usr/lib/node_modules/insomnia-inso/node_modules/insomnia-send-request/dist/index.js:21:30)

ℹ To view tracing information, re-run inso with --verbose

To Reproduce
Steps to reproduce the behavior:

Go to command line
execute inso cli
select a design document containing tests
select an environment
execute the tests
See the error described above

Expected behavior
Inso CLI runs the tests as expected without throwing errors.
Desktop (please complete the following information):

OS: Linux (Manjaro Linux 21.0.7)
Installation Method: npm
App Version v2.3.0

Some code path is leading into loading react polyfills? Hmm

I'm encountering the same error using macOS big sur. I've made the same steps as @xeras.

Hi @mdhenriksen, the request being run by the test, is that by any chance consuming a plugin or template tag? If that's the case, unfortunately plugins are not yet supported with Inso, though we do plan to allow this - I suggest following this thread.
It would be incredibly useful for us if you are able to provide a document export that we can validate with!

Hey @develohpanda! The request is using an environment variable tag (I guess thats a template tag).
However, I've just created a completely new test, that only sends a GET request without any parameters, tags or what so ever - and I'm still hitting the same error.
My steps are as follows:

Create design document
Under the "debug" tab, create GET request pointed at https://api.chucknorris.io/jokes/random
Under the "test tab, create default test to see if response code is 200
Validate the test works in Insomnia
Go to terminal, run inso run test and find and run the test suite

Thank you for those steps! Environment variables should be supported just fine, it's more if there are any custom plugins. I followed your steps above and it seems to be working fine.

Could you please confirm which version of Insomnia and Inso you are using? Are they both the current latest versions?

Insomnia 2021.5.2
Inso 2.3.0

Weird it works for you.
I have a few plugins installed, but that's fine as long at they are not used in the actual requests and tests, right?
These are my versions:

Insomnia 2021.5.2
Inso 2.3.2

Full specifications on my Insomnia installation:
Version: Insomnia 2021.5.2
Release date: 31/08/2021
OS: Darwin x64 20.6.0
Electron: 11.2.3
Node: 12.18.3
V8: <IP_ADDRESS>-electron.0
Architecture: x64
node-libcurl: libcurl/7.73.0 OpenSSL/1.1.1k zlib/1.2.11 brotli/1.0.9 zstd/1.4.9 libidn2/2.1.1 libssh2/1.9.0 nghttp2/1.42.0

I have a few plugins installed, but that's fine as long at they are not used in the actual requests and tests, right?

In theory yes, there might be a situation where an environment variable that uses a template tag/plugin could cause an issue. Could you please see if you can reproduce this with a fresh design document?
I also mistakenly thought Inso 2.3.0 was the latest, however I get the same success response using Inso 2.3.2.

I had the same problem with all node v16 versions, but it worked with v14
nvm install v14.18.1 Now using node v14.18.1 (npm v6.14.15) npm install -g insomnia-inso inso run test

Oh that's a good point^. Inso only works (currently) with Node 12. We've released single-executable binaries which you can access from GitHub Releases if you want to skip installing via NPM.


Issue on the PWC task on creating a sequence of Pokemon names

Hi Simon,
sorry to spam this repository with an issue on something else, but I don't have a mail address and  can't find any better way to get in touch with you.
Your program to  find Pokemon name sequence apparently finds a best sequence of only 14 words with Mohammad's input list, and this is (IMHO) wrong. As far as I can say, the longest sequence has at least 23 words, and there are more than two thousand such sequences. See http://blogs.perl.org/users/laurent_r/2019/09/perl-weekly-challenge-25-pokemon-sequence-and-chaocipher.html for some more details.
Best, Laurent.

Yeah I know. Unfortunately I have been feeling sick for most of the week so haven't returned to it. Or picked up the second challenge.
Hopefully next week will go better.


Checkstyle fixes in Cloud Storage JSON API tests.

Getting ready to use shared java-repo-tools configuration.
I also convert the assertions to use truth.
Since I find it more readable to get a list of object names first
instead of manually looping through, I also update the sample to use
Java 8 lambdas to extract these object names. The sample is used here:
https://cloud.google.com/storage/docs/json_api/v1/json-api-java-samples
which does not indicate the required Java version.
Depends on https://github.com/GoogleCloudPlatform/java-docs-samples/pull/107

Just use <properties> and set maven.compiler.source & maven.compiler.target

LGTM