Plugin system

Staging area before releasing all plugins to main

@LeaVerou - I merged the approved PRs into this branch because I was thinking it would be better to ensure everything is working together and that we're happy with the API, documentation, etc. before merging all of it into master and releasing a new version. Buf if you would prefer to merge straight into main that's fine with me too 🤷🏻♀

Looks very good. I like the fact users can keep this simple, as I think most of jsep usages will be without plugins, but it is also very nice that extendability is possible and well documented now. Great!

Just waiting on #147 #148 and #153 before releasing (and bumping the version)?

Just waiting on #147 #148 and #153 before releasing (and bumping the version)?

Why do we need to have agreement on all individual plugins to merge a plugin system? The whole point of a plugin system is that it's modular, plugins can be added at any time, by us or others.

Why do we need to have agreement on all individual plugins to merge the plugin system into jsep? The whole point of a plugin system is that it's modular, plugins can be added at any time, by us or others.

I agree that we don't have to wait ... but the whole change to add the plugin system started from #123 and my original PR to add arrow-function support. So personally, I would like to have that included in the initial release... 🤷🏻♀ . All of the plugins could realistically be moved into individual projects as well if that's preferred, but I think it's convenient, at the moment, to have it together to ensure everything works well together. I was also waiting on creating another PR that just adds a test file with all plugins combined, to ensure that all of the expressions and tests work when all plugins are registered together to ensure no errors with breaking other functionality with a loaded plugin.

I'm not used to the workflow of releasing a new version every time a PR is merged, but I'm not opposed to it either. 🤷🏼♀
Ok, let's get consensus on the existing plugin PRs before merging. What's left to review?

not used to the workflow of releasing a new version every time a PR is merged

I typically don't either ... but I thought for a significant change like this it might make more sense. Especially if we're updating the readme docs but haven't yet published to npm 🤷🏻♀
At any rate, I think it's nearly ready. I just updated the .npmignore file after I noticed what was included (npm pack builds a tar file to test).
One issue I noticed, when trying to use the build in a typescript project, is that the plugins themselves don't have a type definition:
import * as jsep from 'jsep';
import * as jsepArrow from 'jsep/dist/cjs/jsepArrow.cjs.js';

TS7016: Could not find a declaration file for module
'jsep/dist/cjs/jsepArrow.cjs.js'. 'node_modules/jsep/dist/cjs/jsepArrow.cjs.js' implicitly has an 'any' type.   Try `npm i --save-dev @types/jsep` if it exists or add a new declaration (.d.ts) file containing `declare module 'jsep/dist/cjs/jsepArrow.cjs.js';`

I could fix it by adding types to the tsd.ts file:
declare module 'jsep/dist/jsepArrow' {
  import * as jsep from 'jsep';
  const name: string;
  const init: (this: typeof jsep) => void;
}

declare module 'jsep/dist/cjs/jsepArrow.cjs.js' {
  import * as jsep from 'jsep';
  const name: string;
  const init: (this: typeof jsep) => void;
}

declare module 'jsep/dist/jsepArrow' {
  import * as jsep from 'jsep';
  const name: string;
  const init: (this: typeof jsep) => void;
}

declare module 'jsep/dist/iife/jsepArrow.iife.js' {
  import * as jsep from 'jsep';
  const name: string;
  const init: (this: typeof jsep) => void;
}

Or do you have a better suggestion? (I'd hate to do nothing and force 'allow implicit any', or have to manually declare the module)

Can we have separate typings per module, included in its own directory? I'd like them to be as self-contained as possible.

Maybe we should make the plugins more like a mono repo then? So that each plugin is individually published to npm (i.e. @jsep/arrow-plugin)? Might be nicer for versioning in the future if each has their own version?

@LeaVerou and @EricSmekens - I think this should have all of the PRs and changes that were already individually reviewed and approved. Do you want one more review of the branch before merging all to main? With the separate packages per plugin, should the github actions be updated?

Approval on my side on merging this all to main.
Thank you for all your time and work on this! I think the actions should be updated, but I'm fine with that in a seperate pr.
(It currently uses npm publish, I guess for the multiple packages we need something different).

I guess for the multiple packages we need something different).
I think each plugin package could be manually published (cd packages/arrow && npm publish) in the meantime? :-)

Approval on my side too. We can always iterate with other PRs.

FYI - I started working on updating expression-eval to support the new node types and have been confirming that it can evaluate the nodes and use the updated jsep and packages. Merging! :-)

This is exciting, I'm looking forward to using the object plugin. Do you have plans to include this work in an upcoming release?


App crash after sometimes. memory leak?

The carousel view is working fine for start. but the app will crashed after 5-10 mins. I am using timer for auto increase the position for archive screen saver feel as below:
I am suspecting memory leak.... any idea?
test.txt

If you are using the control with images, you have to use FFImageLoading plugin.

Use this repo as example: https://github.com/alexrainman/TabbedCarouselView

alex, thanks for your prompt reply! could you able provide me sample with StreamImageSource? which get from byte array.

First, you have to use FFImageLoading instead of XF Image. Then you set source from stream same as you do with XF Image.

thanks bro... everything work fine now!!

Great!

If my work is helping you, please help me back: https://xamarinhq.wufoo.com/forms/nominate-a-xamarin-mvp/
This is what i have done that is community visible:

Alex has been pretty active sharing his knowledge and answering questions in StackOverflow, GitHub and Xamarin Forums.
Alex has been open sourcing Xamarin components and plugin with the community, with more of 10 repositories being maintained on GitHub.
One of Alex's Xamarin.Forms plugin, the CarouselView, is currently being pulled into the Xamarin.Forms core (https://github.com/xamarin/Xamarin.Forms/pull/853). As an stable widget, this control has become the standard for Xamarin.Forms carousel screens with more that 16K downloads in NuGet and more than 100 solved and not open issues.
Another Alex's plugin, the SegmentedControl (https://github.com/alexrainman/SegmentedControl), is a big candidate to be also pulled into Xamarin.Forms core.
Plus Xamarin.Forms UI related plugins, Alex shares plugins to set app icon Badge, Google Analytics and KeyChain access.
Alex shares his knowledge about cutting edge technologies like Couchbase NoSQL and MobileIron integration with Xamarin Apps.

please get me your email address for the nomination

<EMAIL_ADDRESS>

done

Thanks

sorry to disturb you alexrainman, its still crashed for ipad mini 1 in iOS 9.3.5. any idea??

StackTrace? Demo project?

its only happen on device. not able to capture the stack trace so far

Debug mode? Release mode? How do you know its the carousel?

its crash from carousel page. I have create a screen saver page

I don't have a way to know what's going on my friend unless you can provide a demo project or StackTrace :(

Another issue i had is The app will crashed if i swipe the carousel view quickly. Error as below:
FYI, I am using timer for auto increase the position for screen saver feel.
NSInternalInconsistencyException
No view controller managing visible view <Xamarin_Forms_Platform_iOS_Platform_DefaultRenderer: 0x7f889e444760; frame = (0 0; 1024 768); autoresize = LM+W+RM+TM+H+BM; layer = <CALayer: 0x60800582b840>>


MERN_MongoDB: 3.1 Creating Database in MongoDB

Description
Description
Creating Database in MongoDB

Explain all the steps for creating a MongoDB Database with the CLI.

It should include basic commands to insert data, show and use the database.

Explain all the steps for creating a MongoDB Database with Compass.

Project Directory
Branch MERN>MERN/Topic/Backend/MongoDB/
Name the File as 3.1_Creating_Database_in_MongoDB.md
Domain
MERN
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

@Dhruvsinghjadon, what's the status for this issue?

/assign

@saloni-15  I would like to work on the video for this issue

@saloni-15 I would like to work on the video for this issue

@husain3012 https://github.com/girlscript/winter-of-contributing/issues/4607 check here and get self assigned

Hello @saloni-15,
I want to work on this topic as no one has done any work on this.


raftstore v2: A region's peer may be stolen by another region and cause destruction of its Leader peer

Bug Report
This seems to happen in a merging situation where region 14277 want to be merged into 12462.
Check the following log, the peer 14280 is of region 14277. However, it suddenly becomes to a peer with larger ID of region 12462. This will destroy the region 12462's original peer 12465, which is actually a leader.
// At this timepoint, peer became Leader of region 12462
[2023/08/22 09:41:46.609 +08:00] [INFO] [raft.rs:1306] ["broadcasting vote request"] [to="[12464, 12463]"] [log_index=11325] [log_term=8] [term=8] [type=MsgRequestPreVote] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [raft.rs:2219] ["received votes response"] [term=8] [type=MsgRequestPreVoteResponse] [approvals=2] [rejections=0] [from=12464] [vote=true] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [raft.rs:1151] ["became candidate at term 9"] [term=9] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [raft.rs:1306] ["broadcasting vote request"] [to="[12464, 12463]"] [log_index=11325] [log_term=8] [term=9] [type=MsgRequestVote] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [raft.rs:2219] ["received votes response"] [term=9] [type=MsgRequestVoteResponse] [approvals=2] [rejections=0] [from=12464] [vote=true] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [raft.rs:1235] ["became leader at term 9"] [term=9] [raft_id=12465] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.610 +08:00] [INFO] [txn_ext.rs:122] ["require updating max ts"] [initial_status=38654706024] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:46.611 +08:00] [INFO] [misc.rs:92] ["succeed to update max timestamp"] [region_id=12462]

// However, it is then destroyed for some strange reason
[2023/08/22 09:41:52.605 +08:00] [INFO] [raft.rs:1557] ["starting a new election"] [term=8] [raft_id=14280] [peer_id=14280] [region_id=14277]
[2023/08/22 09:41:52.684 +08:00] [INFO] [mod.rs:366] ["mark for destroy for larger ID"] [larger_id=14280] [peer_id=12465] [region_id=12462]

After the destroy happens, the region 12462 will bootstrap a new peer with id=14280. The following log is from TiKV1, which is region leader previously.
[2023/08/22 09:41:52.685 +08:00] [INFO] [life.rs:846] ["peer destroyed"] [peer_id=12465] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [router.rs:348] ["shutdown mailbox"] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [raft.rs:2663] ["switched to configuration"] [config="Configuration { voters: Configuration { incoming: Configuration { voters: {} }, outgoing: Configuration { voters: {} } }, learners: {}, learners_next: {}, auto_leave: false }"] [raft_id=14280] [peer_id=14280] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [raft.rs:1127] ["became follower at term 0"] [term=0] [raft_id=14280] [peer_id=14280] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [raft.rs:388] [newRaft] [peers="Configuration { incoming: Configuration { voters: {} }, outgoing: Configuration { voters: {} } }"] ["last term"=0] ["last index"=0] [applied=0] [commit=0] [term=0] [raft_id=14280] [peer_id=14280] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [raw_node.rs:315] ["RawNode created with id 14280."] [id=14280] [raft_id=14280] [peer_id=14280] [region_id=12462]
[2023/08/22 09:41:52.685 +08:00] [INFO] [peer.rs:50] ["create peer"] [region_state="region { id: 12462 region_epoch { conf_ver: 37 version: 180 } peers { id: 12467 store_id: 27 role: Learner } peers { id: 14280 store_id: 4 } }"] [apply_state=] [raft_state="hard_state {}"] [peer_id=14280] [region_id=12462]
[2023/08/22 09:41:52.690 +08:00] [INFO] [endpoint.rs:342] ["register observe region"] [region="id: 14277 start_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856640000000000FA end_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA region_epoch { conf_ver: 49 version: 181 } peers { id: 14278 store_id: 1 } peers { id: 14280 store_id: 4 } peers { id: 14281 store_id: 19 role: Learner } peers { id: 14282 store_id: 27 role: Learner } peers { id: 16796 store_id: 26 }"]

After then the new peer 14280 established, without any information about the region 12462. Since it has no information about its peers, it can't elect.
[2023/08/22 09:43:25.095 +08:00] [INFO] [mod.rs:250] ["failed to propose admin command"] [error="Other(\"[components/raftstore-v2/src/operation/command/admin/merge/prepare.rs:266]: target region not matched, skip proposing: id: 12462 region_epoch { conf_ver: 37 version: 180 } peers { id: 12467 store_id: 27 role: Learner } peers { id: 14280 store_id: 4 } != id: 12462 start_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA end_key:<PHONE_NUMBER>000001FF5B5F728000000000FF87BD360000000000FA region_epoch { conf_ver: 37 version: 180 } peers { id: 12463 store_id: 1 } peers { id: 12464 store_id: 26 } peers { id: 12465 store_id: 4 } peers { id: 12466 store_id: 19 role: Learner } peers { id: 12467 store_id: 27 role: Learner }\")"] [cmd_type=PrepareMerge] [peer_id=14280] [region_id=14277]

What version of TiKV are you using?

nightly
What operating system and CPU are you using?

na
Steps to reproduce

What did you expect?
Leader can be elected
What did happened?
Leader can not be elected

In another tikv instance(tikv3), we noticed the similar logs
[2023/08/22 07:45:03.816 +08:00] [INFO] [compact_log.rs:588] ["compact log"] [truncated="applied_index: 8515 truncated_state { index: 8514 term: 7 }"] [apply_trace="ApplyTrace { data_cfs: [Progress { flushed: 5, last_modified: 5 }, Progress { flushed: 8514, last_modified: 8514 }, Progress { flushed: 8514, last_modified: 8514 }], admin: Progress { flushed: 8515, last_modified: 8515 }, persisted_applied: 8515, last_flush_trigger: 0, try_persist: false }"] [index=8515] [peer_id=14278] [region_id=14277]

[2023/08/22 09:15:34.124 +08:00] [INFO] [mod.rs:366] ["mark for destroy for larger ID"] [larger_id=14278] [peer_id=12463] [region_id=12462]
[2023/08/22 09:15:34.124 +08:00] [INFO] [life.rs:846] ["peer destroyed"] [peer_id=12463] [region_id=12462]
[2023/08/22 09:15:34.124 +08:00] [INFO] [router.rs:348] ["shutdown mailbox"] [region_id=12462]
[2023/08/22 09:15:34.124 +08:00] [INFO] [raft.rs:2663] ["switched to configuration"] [config="Configuration { voters: Configuration { incoming: Configuration { voters: {} }, outgoing: Configuration { voters: {} } }, learners: {}, learners_next: {}, auto_leave: false }"] [raft_id=14278] [peer_id=14278] [region_id=12462]
[2023/08/22 09:15:34.124 +08:00] [INFO] [raft.rs:1127] ["became follower at term 0"] [term=0] [raft_id=14278] [peer_id=14278] [region_id=12462]
[2023/08/22 09:15:34.124 +08:00] [INFO] [raft.rs:388] [newRaft] [peers="Configuration { incoming: Configuration { voters: {} }, outgoing: Configuration { voters: {} } }"] ["last term"=0] ["last index"=0] [applied=0] [commit=0] [term=0] [raft_id=14278] [peer_id=14278] [region_id=12462]

[2023/08/22 09:41:34.100 +08:00] [INFO] [mod.rs:250] ["failed to propose admin command"] [error="Other(\"[components/raftstore-v2/src/operation/command/admin/merge/prepare.rs:266]: target region not matched, skip proposing: id: 12462 region_epoch { conf_ver: 37 version: 180 } peers { id: 12466 store_id: 19 role: Learner } peers { id: 14278 store_id: 1 } != id: 12462 start_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA end_key:<PHONE_NUMBER>000001FF5B5F728000000000FF87BD360000000000FA region_epoch { conf_ver: 37 version: 180 } peers { id: 12463 store_id: 1 } peers { id: 12464 store_id: 26 } peers { id: 12465 store_id: 4 } peers { id: 12466 store_id: 19 role: Learner } peers { id: 12467 store_id: 27 role: Learner }\")"] [cmd_type=PrepareMerge] [peer_id=14278] [region_id=14277]
[2023/08/22 09:41:39.100 +08:00] [INFO] [region.rs:317] ["try to merge"] [merge="target { id: 12462 start_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA end_key:<PHONE_NUMBER>000001FF5B5F728000000000FF87BD360000000000FA region_epoch { conf_ver: 37 version: 180 } peers { id: 12463 store_id: 1 } peers { id: 12464 store_id: 26 } peers { id: 12465 store_id: 4 } peers { id: 12466 store_id: 19 role: Learner } peers { id: 12467 store_id: 27 role: Learner } }"] [region_id=14277]

In TiFlash2's log
[2023/08/22 07:42:21.229 +08:00] [INFO] [apply.rs:1690] ["execute admin command"] [command="cmd_type: BatchSplit splits { requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF422BB60000000000FA new_region_id: 14265 new_peer_ids: 14266 new_peer_ids: 14267 new_peer_ids: 14268 new_peer_ids: 14269 new_peer_ids: 14270 } requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF5D43010000000000FA new_region_id: 14271 new_peer_ids: 14272 new_peer_ids: 14273 new_peer_ids: 14274 new_peer_ids: 14275 new_peer_ids: 14276 } requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA new_region_id: 14277 new_peer_ids: 14278 new_peer_ids: 14279 new_peer_ids: 14280 new_peer_ids: 14281 new_peer_ids: 14282 } right_derive: true }"] [index=9] [term=8] [peer_id=12467] [region_id=12462]
[2023/08/22 07:42:21.229 +08:00] [INFO] [command.rs:236] ["observe admin command"] [region_epoch="conf_ver: 37 version: 177"] [command="cmd_type: BatchSplit splits { requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF422BB60000000000FA new_region_id: 14265 new_peer_ids: 14266 new_peer_ids: 14267 new_peer_ids: 14268 new_peer_ids: 14269 new_peer_ids: 14270 } requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF5D43010000000000FA new_region_id: 14271 new_peer_ids: 14272 new_peer_ids: 14273 new_peer_ids: 14274 new_peer_ids: 14275 new_peer_ids: 14276 } requests { split_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA new_region_id: 14277 new_peer_ids: 14278 new_peer_ids: 14279 new_peer_ids: 14280 new_peer_ids: 14281 new_peer_ids: 14282 } right_derive: true }"] [index=9] [term=8] [peer_id=12467] [region_id=12462]
[2023/08/22 07:42:21.231 +08:00] [INFO] [peer.rs:4113] ["insert new region"] [region="id: 14277 start_key:<PHONE_NUMBER>000001FF5B5F728000000000FF5D43010000000000FA end_key:<PHONE_NUMBER>000001FF5B5F728000000000FF7856650000000000FA region_epoch { conf_ver: 37 version: 180 } peers { id: 14278 store_id: 1 } peers { id: 14279 store_id: 26 } peers { id: 14280 store_id: 4 } peers { id: 14281 store_id: 19 role: Learner } peers { id: 14282 store_id: 27 role: Learner }"] [region_id=14277]

Is it reproed without TiFlash? @CalvinNeo

It might be caused by https://github.com/tikv/tikv/issues/15623#issuecomment-1723172816, which is fixed by https://github.com/tikv/tikv/pull/15643.
Please open if it happens again.


Dynamic Withdrawal Limit

This should close #1950
Most of the Exchanges has 3 types of withdrawal limit structure.

Email verified: ex 2BTC, if user has email verified then he can withdraw upto 2BTC each day
KYC Verified: ex 10BTC, if user has kyc verified then he can withdraw upto 10BTC each day
Custom: ex 20BTC, admin can set the withdrawal limit for the user

The idea is simple, we use labels like barong.
we can use a label with key being the level and time in hours and value being the limit, ex. key:value = level3_24h:10.
if user contains a label then this label will be used to calculate the limit.
this way we can create multiple withdrawal limits for the same level or user but a different time.

Hi @martianatwork,
I like this idea, we will need to discuss and define priority for this feature.

hope can be realize fast ✌

Hey @shal let me know your inputs


Detail pages that have slug generate when create is errored

When admin create product or category or similar have detail page need slug. After a period of time, i can't access the slug but if i update again and save, the slug work and i can access to the detail page

Can you submit a PR to fix this?

Can you submit a PR to fix this?

I can't, i don't know reason why it's not working
Can you help me, pls ?

Please steps to reproduce the issue

Please steps to reproduce the issue

The first you go to admin page and create a product or category, ...
Detail page URL of product or category is slug that is entered or auto generated when created
Immediately after being created or update, the URL operates normally
But after a period of time, i'm not sure how long, sometimes 2-3 days, sometimes 2 hours, it not working (I have attached a photo of the error when accessing the URl above)
It's intermittent bug, it won't happen immediately.
Thank you.

But after a period of time, i'm not sure how long, sometimes 2-3 days, sometimes 2 hours, it not working (I have attached a photo of the error when accessing the URl above)

This is hard to reproduce, l suggest to leave this open until someone else confirm otherwise we can't help one this

Same issue.

Link demo: https://demo.simplcommerce.com/perfumes


vello_editor: Add basic Touch handling.

With my other PR and a local addition to the Cargo.toml for configuring cargo-bundle, I was able to run and move the cursor around and do selection.
Interestingly, keyboard input doesn't work yet and just beeps at me.
But this PR worked for the thing it aims to solve.


Selectable columns not working

I have tried the exact code in codepen from below links, It doesn't show the icon to select columns. Any specific settings or includes?
https://codepen.io/iamisti/pen/RGvvWL
http://iamisti.github.io/mdDataTable/

It must work, can you send me here your setup?

md.zip
Hi, uploaded the example files, Appreciate your help.

Hi,
Attached the example i tried to use the selectable columns, Appreciate your
help.
-Thanks
On Sat, Nov 12, 2016 at 1:36 PM, Istvan Fodor<EMAIL_ADDRESS>wrote:

It must work, can you send me here your setup?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/iamisti/mdDataTable/issues/228#issuecomment-260108569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHPgFq9JULFVzcF3LcVSxsWQcpZlXoGPks5q9XN2gaJpZM4KtHcF
.

@saifuddin123
I also tried the exact codePen from your links it perfectly works for me (I can see the icon to select column... ).
My setup :
4.4.0-45-generic GNU/Linux
=>  Browsers :
Google Chrome 54.0.2840.100
Mozilla Firefox 49.0.2
Opera 41.0.2353.56
You should send your setup this will help to fix your bug


Exception raised on 'news.ycombinator.com'

Cool project, everything seems to work as intended, but for some reason trying to use news.ycombinator.com as the news_source raises Exception: check internet connection / website is not supported.
It's odd, because other sources with subdomains work without issue, such as wired.co.uk.

Hey. thx.
I just tested with website = Newscatcher('news.ycombinator.com')
It works. Probably you made an error somewhere.
If still does not work, please, share the full code.


Development

First non-preview release
Made TextMate scope specification more flexible
Handles CSS and JavaScript nested within HTML using proper corresponding rules.
Fixed some ligatures which were not being matched
Fixed handling of comma-separated language lists
Added attribute_value category
Updated settings schema to include "ligatures" property within language specs
Fixed prefix of commands: now ligaturesLimited. instead of extension. (Note: any keybindings created using the preview version will have to be redone)


Expanded support for shared flag

If this is in the roadmap and I have missed it, apologies.
Soon after issue #204 was closed initial support for shared tag was added to Linkding.
Shared can be set and queried using the API, but full support is not yet reached.
Observations:

no front end way to set shared flag when adding a bookmark (in the same way as "Mark as unread" works)
shared status is not displayed in the list view
import strips private flag rather than mapping it to shared
exporting sets private=0/false even if bookmark has shared flag set as shared=true

I have a bit of time coming up, I could get started on any import/export changes? any thoughts?

Another weekend approaches, shall I begin work on this?

Some feedback on this:

You need to enable bookmark sharing in the settings in order for a checkbox in the bookmark form to show up
Shared status is indeed not shown in the list. I'm being careful with adding more stuff to bookmark items, in order to keep the list readable. An opinionated choice, but you're the first to want this, so maybe not very relevant.

Regarding mapping shared bookmarks to the private flag, I'm not convinced that this is the right approach, as these have different meanings:

At least in Pinboard, a non-private bookmark is a public one, which means everyone, even anonymous users can see it.
In Linkding, a shared bookmark is only shared with other authenticated users.

That results in two issues:

Users, especially existing ones, might not expect that importing a non-private bookmark now suddenly shares it with everyone else in their installation
If support for public bookmarks ever gets added, then the private flag is already mapped to something else

Thanks for your thoughts.

but you're the first to want this

I think it would be easy to argue that the users in issue #204 also want it?

Users, especially existing ones, might not expect that importing a non-private bookmark now suddenly shares it with everyone else in their installation

I can't speak for the number of installs that have multiple users, but this scenario would be easy to cope with by defaulting the setting to off (no change to behaviour, just like the one to enable bookmark sharing).

If support for public bookmarks ever gets added, then the private flag is already mapped to something else

My first thought is that the a private bool (0/1) could be transformed into an enum (0/1/2) for an easy migration to private/localshare/publicshare. Just an idea.

I added a setting that allows public access to shared bookmarks: https://github.com/sissbruecker/linkding/pull/503. With that, shared now pretty much maps to public, or not private. As such, implementing that mapping in the import / export makes more sense. Still, I'd consider adding that as an option, maybe as checkboxes next to the import / export buttons.

Many thanks!
Is the mapping something you plan to do? or are you looking for a PR?

I was thinking, if entries that were marked with a CSS class for "shared" (and not) then I could style these myself using my own browser stylesheet. Even if the class is unused by Linkding styles, it would be enough.

Added mapping of the PRIVATE flag in https://github.com/sissbruecker/linkding/pull/505.
Sure, adding a CSS class to bookmarks would be fine, you could open a PR for that. Another thing that could be useful is a search keyword for shared bookmarks, similar to !untagged or !unread. That would give a clear list of shared bookmarks at least.


Document implicit dynamic label value supported by CloudStack cluster

What happened:
To support labeling node with failuredomain info, Cloudstack provider supports a placehold string ds.meta_data.failuredomain and this string will be replaced with failuredomain name where the node is located.
To use it, eksa customer needs to add a label section under controlPlaneConfiguration or workerNodeGroupConfiguration:
for example:
controlPlaneConfiguration:
    count: 3
    endpoint:
      host: <IP_ADDRESS>:6443
    machineGroupRef:
      kind: CloudStackMachineConfig
      name: wanyufe-cp
    labels:
      cluster.x-k8s.io/failure-domain: ds.meta_data.failuredomain

What you expected to happen:
This needs to be documented in eksa doc.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

EKS Anywhere Release:
EKS Distro Release:

I documented this label in PR #3677

Sounds like this can be closed then. Please reopen if needed.


Add composer file for wordpress-theme install

Let's support composer installers for multi-framework support in wordpress.
By doing so, we have the ability to define a custom themes folder and bring this
as a dependency to build upon. This also makes it easier on
build/deploy processes where we don't have to worry about controlling a parent
theme folder that is being maintained by someone else.
For more info: https://github.com/composer/installers

@olefredrik thanks! I'm going to pass on ownership to you for https://packagist.org/packages/olefredrik/foundationpress
This will allow those to leverage the composer feature.

@olefredrik actually, I can't add you as maintainer until you have an account registered at packagist.org.
Once you do, I'll add you. I will suggest to add an auto-update hook in this repo so all you have to worry about is just pushing and pulling on here. The listener on packagist will do the rest.
Thanks again!

Awesome, @KLVTZ ! I'm currently on vacation with a sloppy internet connection on my phone. Will look into this and create a packagist account as soon as I'm back next week. I'll keep in touch. Thanks!

:+1:

Hi. My username on packagist.org is olefredrik.

Added you as maintainer, you will need to remove me as maintainer in the upper-right sidebar in order to complete the process. Also, you will need to add the hook within this repos settings for auto-updates.

Sweet! Added the service hook in the repo seetings. Seems to work fine. Thanks!


detectFaces method returns empty array

After following through the example, I found that detectFaces method returns an empty array somehow.  This is after loadImage(path).

Hi, which example do you mean?

Closing because of inactivity.


Responsive Menu

A configurable navigation ready to be used within mobile browser

CSS menu example https://codyhouse.co/gem/css-multi-level-accordion-menu/

Every page is different so: not useful


Disable login header

Make sure you include the related JIRA issue in the title e.g. '[SDP-007] Fixed navbar issue'
Make sure you have checked off the following before you issue your Pull Request:

N\A Added unit tests for new functionality
[x] Passed all unit tests using rails test with 90%+ coverage
N\A Added cucumber tests for any new functionality
[x] Passed all cucumber tests using bundle exec cucumber
[x] Passed overcommit hooks, including running all code through Rubocop
N\A If any database changes were made, run rake generate_erd to update the README.md
N\A If any changes were made to config/routes.rb run rake jsroutes:generate

Out of process merging of my own PR because it is needed to support testing and cant wait.


Fixed erros when parse description and wind attributes

Hi @lucasduete thanks a lot for your contribution, I really appreciate it :smile: :rocket:


Suggestion: Rare price prediction

I know many people frown on this, but I like to use poeprices.info to get a quick estimate for rare items and if something jumps out, I check it manually. Could you please implement price prediction using poeprices.info? If you do, please also display the weightings that contribute to the predicted price. You could make it toggle-able for people who hate it.

If I might add to this, it would be nice to have a feature pricing whole dump tab then highlighting result in-game by drawing a border around items with pricing info and extended details upon hover. This will require using stash tab API, and poeprices API (if they have one, technically response JSON is hardcoded into HTML page, but using that would be in bad taste without permission.)
It can be useful to find items that might be worth something if the ability to filter results is added (for example only show items worth more than 25 chaos).
Another way would be to submit data from stash tab then open a browser page with results ingame. The drawback is that poeprices has abysmal UI for results that are hard to read.

If I might add to this, it would be nice to have a feature pricing whole dump tab then highlighting result in-game by drawing a border around items with pricing info and extended details upon hover. This will require using stash tab API, and poeprices API (if they have one, technically response JSON is hardcoded into HTML page, but using that would be in bad taste without permission.)
It can be useful to find items that might be worth something if the ability to filter results is added (for example only show items worth more than 25 chaos).
Another way would be to submit data from stash tab then open a browser page with results ingame. The drawback is that poeprices has abysmal UI for results that are hard to read.

PoePrices already does this: https://www.poeprices.info/#priceastash

To the main feature request of adding the pricing info, I'd like to add more details to make this happen quickly. I know there are a lot of Issues right now with league launch, but this is the last feature I need to make the switch completely to this tool, so I'll do what I can to help push it along.
All you need to do is take the exact item text:
Rarity: Rare
Armageddon Dash
Crusader Boots
--------
Quality: +20% (augmented)
Armour: 174 (augmented)
Energy Shield: 42 (augmented)
--------
Requirements:
Level: 70
Str: 62
Dex: 111
Int: 155
--------
Sockets: G-B-B-B
--------
Item Level: 86
--------
+39 to Strength
+24 to Armour
+11 to maximum Energy Shield
+45 to maximum Mana
35% increased Movement Speed
+19% to Fire and Cold Resistances (crafted)

And Base64 Encode it:
UmFyaXR5OiBSYXJlCkFybWFnZWRkb24gRGFzaApDcnVzYWRlciBCb290cwotLS0tLS0tLQpRdWFsaXR5OiArMjAlIChhdWdtZW50ZWQpCkFybW91cjogMTc0IChhdWdt
ZW50ZWQpCkVuZXJneSBTaGllbGQ6IDQyIChhdWdtZW50ZWQpCi0tLS0tLS0tClJlcXVpcmVtZW50czoKTGV2ZWw6IDcwClN0cjogNjIKRGV4OiAxMTEKSW50OiAxNTUK
LS0tLS0tLS0KU29ja2V0czogRy1CLUItQiAKLS0tLS0tLS0KSXRlbSBMZXZlbDogODYKLS0tLS0tLS0KKzM5IHRvIFN0cmVuZ3RoCisyNCB0byBBcm1vdXIKKzExIHRv
IG1heGltdW0gRW5lcmd5IFNoaWVsZAorNDUgdG8gbWF4aW11bSBNYW5hCjM1JSBpbmNyZWFzZWQgTW92ZW1lbnQgU3BlZWQKKzE5JSB0byBGaXJlIGFuZCBDb2xkIFJl
c2lzdGFuY2VzIChjcmFmdGVkKQo=
Then you just call:
https://www.poeprices.info/api?l=Delirium&i=
with the encoded data at the end.
If all you had was the min/max and currency from the first result that would be a huge help. But if you could highlight mods that have positive effect that would be extra helpful too.

Closed in favor of #544

This is off-topic, but wouldn't it be smart to merge duplicate requests instead of just closing them? I am just thinking that some information could be lost.


correct typo of NVDI to NDVI

I picked up this small typo. I assume NVDI is meant to be NDVI

Good catch; thanks!


Create Cart Item component and Place in in cart page

Make a new cart item component in the components folder
import it in cart page
component should be responsive
you can try additionally placing a list of the component with a dummy data

#8 done


[Demo] Use plotly.express for more charts in the visual vocabulary

Description
Various small bits of tidying but the main change is that I've rewritten butterfly, column_and_line, dumbbell and diverging_stacked_bar. I already discussed this with @huong-li-nguyen before she went on holiday so I think this should be fine to merge already and then she can take another look when she's back.
Appearance of the graphs is almost exactly the same in all the examples, so no new screenshots here.
Here's our preferred scheme:

base plot on px where possible
pass through **kwargs for all arguments apart from data_frame (which you need to specify due to capture decorator)
write code to be as generic as possible i.e. not hardcoding x vs. y or assuming the structure of data_frame using groupby etc.

Now these plots are much more generic they are suitable for potential addition to vizro.charts rather than being specific examples.
The main advantage of this is that we get lots of the nice parts of px for free, e.g.

we can handle long and wide format data
you can pass arguments like pattern_shape or log_x etc. and they will work (some arguments like facets probably won't fully, but the vast majority of them will)
you get the nice hover data, handling of automatic colour schemes, other nice touches etc. from px

[!NOTE]
(up for discussion, maybe will add to docs if it seems like good advice). In general with Vizro dashboards I recommend always starting off by basing your plot on px. Writing something fully generic takes quite a while and is generally not worth the effort if it's a custom chart for a single dashboard, but it's nice to get the hover data and familiar px API for free.

Screenshot
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Thanks for the reviews @petar-qb and @maxschulz-COL!
Definitely good points on the docstrings @maxschulz-COL. I just spent a while going through all of them (not only the ones I changed) to tidy them up so all should be good there. I would have expected pydocstyle (through ruff) to have picked up that we shouldn't have type hints in the docstrings though - do you think it's working ok? Or maybe we need pydoclint or something else to do that?

Notes on vizro.charts in response to comments and for future reference
This PR is still kind of MVP so I decided to keep the docstrings short and sweet for now, so they don't mention conditions like two groups or which arguments might not work. If and when we move this stuff to vizro.charts I would tighten up on those things, but at the moment the level of documentation here is comparable to the other custom charts which also have lots of implicit assumptions, so I'll leave it like this for now.
Definitely let's discuss again before adding anything to vizro.charts - I'm actually not in a huge hurry to do that. I agree the **kwargs approach has some problems, and maybe overall using make_figure would actually be better for some of these after all.
@maxschulz-COL raised a great point in the team learning session that maybe we actually don't want the visual vocabulary snippets to show this weird looking generic code and would instead be better showing a specific code snippet that's easier for a copy and paste user to understand and tweak. But if we do end up moving this code (or similar) to vizro.charts then we'd just simplify all those examples to do from vizro.charts import butterfly etc. anyway. So now I'm in two minds whether I've actually improved the dashboard or whether most of these changes should be reverted and saved for possible future additions to vizro.charts 😅 I'll leave like this for now anyway because there's some follow up changes I'd like to get finished off in another PR.
If/when it comes to adding stuff to vizro.charts then it's not totally clear to me at the moment which of these would be good candidates. Should all plots in visual vocabulary be possible in a single function call (either vizro.plotly.express or vizro.charts)? e.g. this chart:
@capture("graph")
def radar(data_frame: pd.DataFrame, **kwargs) -> go.Figure:
    fig = px.line_polar(data_frame, **kwargs)
    fig.update_traces(fill="toself")
    return fig

In future a Vizro user should be able to do this without defining a custom chart function at all so we won't need a function for it. So the only thing a vizro.charts version would add is (a) our opinion to fill in the traces and (b) one-to-one corresponds with visual vocabulary dashboard. It's not immediately clear to me how custom a custom chart needs to be before it's worth adding to vizro.charts.
No need to resolve these questions now, but just putting them here to keep track of it in one place.


feat(ci): run nodebuilder if functional test fails

Describe the changes and your approach

Verification Checklist

[ ] I performed a self-review of my changes and approve them.
[ ] I checked of the automated test results for any irregularities.
[ ] I manually tested the code changes on my local environment.
[ ] I considered changes to the README or test docs. (Check if not applicable.)

Resolved conflicts.


Aggiunta della funzione list_arith_collection e dei relativi test

Unfortunately  as soon as he graduated and contrary to our gentlemen agreement @danielminutolo totally disappeared without reporting the fixes that I had showed him to avoid him submit a thesis full of severe errors. So we must be careful of this pullman request

too late I guess :)
anyway before merging I did a pass fixing things, so at least it does not introduce inconsistencies (but I'm not sure whether the algorithm is implemented correctly)


Hyperledger Network Crash  - Agilia's Scenario

Hyperledger Network Crash  - Agilia's Scenario

Agilia reported that the network got crashed after some days of deployment.

Agilia has deployed the fabric network with the following configurations.

all machines have 1vCPU and 2GB RAM

Glusterfs size - 13 GB
[swarm_manager_prime]
hlf1 ansible_host=<IP_ADDRESS>  ansible_python_interpreter="/usr/bin/python3"

[swarm_managers]
hlf1 ansible_host=<IP_ADDRESS>  ansible_python_interpreter="/usr/bin/python3"
hlf2 ansible_host=<IP_ADDRESS>  ansible_python_interpreter="/usr/bin/python3"

[swarm_workers]
hlf3 ansible_host=<IP_ADDRESS>  ansible_python_interpreter="/usr/bin/python3"
hlf4 ansible_host=<IP_ADDRESS>  ansible_python_interpreter="/usr/bin/python3"

Observations :
1) Checking docker service status

primary manager machine

docker service ls  gave the following error

root@hlf1:~# docker service ls                  Error response from daemon: This node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again.                  root@hlf1:~# packet_write_wait: Connection to <IP_ADDRESS> port 22: Broken pipe

secondary manager machine

docker service ls and docker ps commands gave the following error

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Tried starting the docker daemon by running dockerd

docker daemon failed to start with the following error
INFO[2021-07-05T10:48:40.800594620Z] ClientConn switching balancer to "pick_first"  module=grpc INFO[2021-07-05T10:48:40.800778252Z] manager selected by agent for new session: {tld00x72nnotw4cow1e3qs86l <IP_ADDRESS>:2377}  module=node/agent node.id=r2k5std2e3ul1ckm5lz84hym7 INFO[2021-07-05T10:48:40.805403579Z] waiting 0s before registering session         module=node/agent node.id=r2k5std2e3ul1ckm5lz84hym7 ERRO[2021-07-05T10:48:40.914002957Z] agent: session failed                         backoff=100ms error="rpc error: code = Unknown desc = The swarm does not have a leader. It's possible that too few managers are online. Make sure more than half of the managers are online." module=node/agent node.id=r2k5std2e3ul1ckm5lz84hym7

Conclusions
- primary manager - docker daemon was running . But docker swarm set up was corrupted. Being the primary manager, it could not recognize itself as primary manager.
- secondary manager-

2) Debugging the reason for docker daemon stoppage in secondary manager

Running dmesg command in secondary showed the following output
[868647.134539] Out of memory: Kill process 20759 (dockerd) score 280 or sacrifice child [868647.137422] Killed process 20759 (dockerd) total-vm:2474268kB, anon-rss:1638528kB, file-rss:0kB, shmem-rss:0kB

Conclusion

The swarm setup got corrupted in both primary and secondary manager machines
The docker daemon in secondary manager stopped  with the error Out of memory

Fix steps

Restart docker daemon in secondary manager

Following the suggestion from https://github.com/docker/swarmkit/issues/1985#issuecomment-283191356

ran the command rm -r /var/lib/docker/swarm in the secondary manager machine

restarted the docker daemon using the command "sudo systemctl start docker"

Now the docker daemon restarted successfully in secondary manager.

Purge swarm and restart the swarm

In the 014.purge_swarm.yml playbook, commented out the last task "rm -rf /root/hlft-store/*" to preserve old data

Ran the 014.purge_swarm.yml playbook and it was successful .

Ran the 014.spawn_swarm.yml playbook. But it  failed at the last task of creating the overlay network in the primary manager.

Following the suggestion from https://github.com/docker/swarmkit/issues/1985#issuecomment-283191356

ran the command rm -r /var/lib/docker/swarm in the primary manager machine

restarted the docker daemon using the command "sudo systemctl restart docker" in the primary manager machine

Ran the 014.spawn_swarm.yml playbook and it was successful

Start all other services

015.deploy_swarm_visualizer.yml playbook ran successfully
016.deploy_portainer.yml failed with the following filesystem error

Debugging the filesystem error :

This was caused due to the gluster fs volume in primary manager was not online.

The output of command "gluster volume status"

Following the suggestion from https://bobcares.com/blog/gluster-bring-brick-online/

ran the command "gluster volume start gfs0 force" -> This brought back the brick in pimary manager online.

Now all the playbooks ran successfully and all the docker services started successfully.

The old data was preserved in the glusterfs but could not be used.

Reason : Since the swarm was purged and restarted, the docker container related to the stopped chaincodes was also removed. The newly started fabric services started new containers for each microservice and hence could not use the old data from the persistent storage .

Final Conclusion

The swarm setup got corrupted in both primary and secondary manager machines.

The docker daemon in secondary manager had stopped  with the error "Out of memory"
Running dmesg command in secondary manager showed the following output
[868647.134539] Out of memory: Kill process 20759 (dockerd) score 280 or sacrifice child   [868647.137422] Killed process 20759 (dockerd) total-vm:2474268kB, anon-rss:1638528kB, file-rss:0kB, shmem-rss:0kB

The out of memory could have occurred due to the observations specified here : https://github.com/bityoga/fabric_as_code/issues/45**

To avoid this issue in future, it was suggested to use machines with higher memory.


Adding DogStatsd Codec

Pull request
Description
This PR adds a DogStatsD codec to support the Datadog Statsd implementation.
Related
Related to issue: #1950
Checklist

[ ] The RFC, if required, has been submitted and approved
[x] Any user-facing impact of the changes is reflected in docs.tremor.rs
[x] The code is tested
[ ] Use of unsafe code is reasoned about in a comment
[x] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[x] The performance impact of the change is measured (see below)

Performance

Existing Benchmarks
main - passthrough-json
| Throughput   (data): 199.7 MB/s
| Throughput (events): 332.9k events/s

sshields_add_dogtatsd - passthrough-json
| Throughput   (data): 192.3 MB/s
| Throughput (events): 320.6k events/s

New Benchmarks
passthrough-dogstatsd
| Throughput   (data): 29.5 MB/s
| Throughput (events): 484.3k events/s

passthrough-statsd
| Throughput   (data): 8.7 MB/s
| Throughput (events): 648.7k events/s

The benchmarks in the bench folder are unfortunately completely out of date and we didn't clean them up yet. The new benchmarks, whose results are also shown at https://tremor.rs/benchmarks are in the folder tremor-cli/tests/bench.
Sorry for the confusion, we promise to take the time to clean those up.

Nice work @scott-shields-github - let us know if you need a hand with the benchmark suite!

Unfortunately clippy is not happy (just two little things) and our safety checker detected some unwraps and array access.
If you are 100% sure the array access is safe, put a comment like: // ALLOW: <explanation why this is safe> above it, if not use something like array.get(2..).ok_or_(ErrorKind::InvalidDogStatsD)

I am wondering why the throughput numbers between dogstatsd and statsd are so different. I guess the incoming events have different sizes?


Bring to org commmon standard

added lab
linted
moved index file to /lib
updated readme
updated deps
enforced linting at test

why not call lib/queue.js lib/index.js ?

@maxired it wasn't on my list of things, feel free to pr it though :D


import MutableSequence and MutableMapping in a future proof way

from collections import is deprecated in python3.8 and causes a warning in 3.7
Warning is raised here

Please approve changes

Python 3.8 is now the official latest, greatest version of Python. This REALLY needs to get fixed... It's been around since March 29.

Python 3.8 is now the official latest, greatest version of Python. This REALLY needs to get fixed... It's been around since March 29.

Dunno, @akesterson , you still with us ? Do you still supporting that module ? 'cause sooner or later someone may clone this module which will bring a "ripple in the force".

@vulogov We would be interested in someone helping to maintain the library. Reach out to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>if you're interested.

Thanks @akesterson, @vulogov, @berend!

Great! Finally!


"ReferenceError: Blob is not defined" during setting up frontend

Thanks for this wonderful work! I tried to run the demo (in a wsl2 environment) however ran into this problem when trying to setup the frontend:
npm install && npm run build && cd ..

up to date, audited 266 packages in 3s

59 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

><EMAIL_ADDRESS>build
> vite build

vite v4.5.0 building SSR bundle for production...
✓ 94 modules transformed.

vite v4.5.0 building for production...
✓ 87 modules transformed.
.svelte-kit/output/client/_app/version.json                              0.03 kB │ gzip:  0.05 kB
.svelte-kit/output/client/.vite/manifest.json                            2.77 kB │ gzip:  0.48 kB
.svelte-kit/output/client/_app/immutable/assets/2.4b49e46c.css           0.88 kB │ gzip:  0.27 kB
.svelte-kit/output/client/_app/immutable/assets/0.82666576.css           9.71 kB │ gzip:  2.75 kB
.svelte-kit/output/client/_app/immutable/nodes/0.5ed3b7c1.js             0.60 kB │ gzip:  0.38 kB
.svelte-kit/output/client/_app/immutable/chunks/index.57cd3851.js        0.92 kB │ gzip:  0.57 kB
.svelte-kit/output/client/_app/immutable/nodes/1.0b2d00ed.js             1.03 kB │ gzip:  0.59 kB
.svelte-kit/output/client/_app/immutable/chunks/singletons.49bed12e.js   2.45 kB │ gzip:  1.26 kB
.svelte-kit/output/client/_app/immutable/chunks/scheduler.d303939e.js    2.49 kB │ gzip:  1.16 kB
.svelte-kit/output/client/_app/immutable/entry/app.2f014e65.js           5.94 kB │ gzip:  2.34 kB
.svelte-kit/output/client/_app/immutable/chunks/index.b58b6c9b.js        6.16 kB │ gzip:  2.60 kB
.svelte-kit/output/client/_app/immutable/entry/start.35296672.js        24.87 kB │ gzip:  9.81 kB
.svelte-kit/output/client/_app/immutable/nodes/2.45ba902c.js            72.26 kB │ gzip: 21.33 kB
✓ built in 2.90s
ReferenceError: Blob is not defined
    at file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/entries/pages/_page.svelte.js:22:49
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async Module.component (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/nodes/2.js:5:59)
    at async Promise.all (index 1)
    at async render_response (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/index.js:1322:21)
    at async render_page (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/index.js:2162:12)
    at async resolve (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/index.js:2743:24)
    at async respond (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/.svelte-kit/output/server/index.js:2629:22)

node:internal/event_target:1011
  process.nextTick(() => { throw err; });
                           ^
Error: 500 /
To suppress or handle this error, implement `handleHttpError` in https://kit.svelte.dev/docs/configuration#prerender
    at file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/node_modules/@sveltejs/kit/src/core/config/options.js:212:13
    at file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:64:25
    at save (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:403:4)
    at visit (file:///mnt/c/Users/vince/Documents/foco/code/Real-Time-Latent-Consistency-Model/frontend/node_modules/@sveltejs/kit/src/core/postbuild/prerender.js:236:3)
Emitted 'error' event on Worker instance at:
    at Worker.[kOnErrorMessage] (node:internal/worker:298:10)
    at Worker.[kOnMessage] (node:internal/worker:309:37)
    at MessagePort.<anonymous> (node:internal/worker:205:57)
    at MessagePort.[nodejs.internal.kHybridDispatch] (node:internal/event_target:736:20)
    at MessagePort.exports.emitMessage (node:internal/per_context/messageport:23:28)

May I ask if you have any clue what the problem is? Thanks for your help in advance!

hi @vincentlux , that's odd, what's your node version?

hi @radames , yeah that's the problem, after upgrading to node 19 everything is good. Thanks!


keybase log send show offer to review the log

A simple pipe to less would do the trick.

The logs can be really big (we cap the upload to 100MB I think?), and probably wouldn't do well in a pipe situation.  You can manually inspect the logs before you run keybase log send if you want.  On OSX, they are at ~/Library/Logs/keybase.*.log.

That makes sense. Then maybe a message saying "these are the files that are about to be sent"?

Yeah that's a good idea.   @patrickxb?

Sure, we can output the file locations that are used.
The log send command reads the last 10k lines of each file into memory then posts them.
For the record, you can find the location of all the logs on all operating systems with keybase status.

small correction, I think it's up to 100K lines, right @patrickxb ?

Yes, sorry, missed a zero.

Where are they on Linux?

@Nowaker usually ~/.cache/keybase/keybase.*.log


feat: add tools for unit test

What this PR does / why we need it:
Add helper functions for writing unit test.
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @kdada @ddysher

Release note:

NONE

@kdada updated

/lgtm
This package needs more utils for testing nirvana.


*: update all registry deps

Signed-off-by: Brian Anderson<EMAIL_ADDRESS>
What have you changed?
Upgrade all non-git dependencies to their latest, updating lockfile.
What is the type of the changes?
Pick one of the following and delete the others:

Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?
cargo test --all --features=jemalloc,sse,portable
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
no
Does this PR affect tidb-ansible?
no
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

/bench

ok @5kbpers I restored the previous git revs for rocks and libfuzzer. ptal and @sticnarf


version 2.8 not available through brew on macOS

Is there a way to make brew on macOS installing the latest gimme-aws-creds 2.8?
Expected Behavior
brew on macOS should install the latest version 2.8 of gimme-aws-creds
brew install gimme-aws-creds
Current Behavior
Warning: gimme-aws-creds 2.7.2_3 is already installed and up-to-date.
To reinstall 2.7.2_3, run:
  brew reinstall gimme-aws-creds

Possible Solution
?
Steps to Reproduce (for bugs)
call
brew install gimme-aws-creds
Context
we require latest changes in 2.8
Your Environment

Operating System and version: macOS Monterey 12.7.3

2.8.1 should be available in Homebrew when it is released next week


[Accessibility] Keyboard shortcuts and request creation do not work with screen readers

Hello.
I have a problem with the accessibility with Insomnia:
the keyboard shortcuts do not work with screen readers and when I go to create new request
I'm a web developer and I want to use this program.
Thanks so much

We have fixed all the shortcut problems in the upcoming Insomnia 9.0, for which there is a beta available now in the releases. Make sure to download Insomnia, not the CLI application.

Thanks so much.
El jue, 28 mar 2024, 3:58 a. m., Marco Palladino @.***>
escribió:

We have fixed all the shortcut problems in the upcoming Insomnia 9.0, for
which there is a beta available now in the releases
https://github.com/Kong/insomnia/releases. Make sure to download
Insomnia, not the CLI application.
—
Reply to this email directly, view it on GitHub
https://github.com/Kong/insomnia/issues/6491#issuecomment-2024309097,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3TLQZXYQ3DVWHZB7E27JELY2OBLRAVCNFSM6AAAAAA4V5YQBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUGMYDSMBZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Writers: Resource limits on the number of matched readers [4570]

This PR:

Adds matched_subscriber_allocation to PublisherAttributes
Adds matched_readers_allocation to WriterAttributes
Refactors the collections on RTPSWriter, StatelessWriter and StatefulWriter that depend on the number of matched readers to be resouce limited by matched_readers_allocation.
Refactors ReaderProxy to be only used from within StatefulWriter and removing its internal mutex
Refactors the collections on StatelessWriter and ReaderProxy that depend on the resource limits of the writer's history to be resource limited.

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows

Build status:

Linux
Mac
Windows


Python client should handle the "nextPageToken" = "" (empty string) case as described in the document

I'm implementing a Delta Sharing server which returns an empty string for "nextPageToken" when there are no additional results as described in the document here: https://github.com/delta-io/delta-sharing/blob/main/PROTOCOL.md#list-shares
Note: the nextPageToken field may be an empty string or missing when there are no additional results. The client must handle both cases.

But the Python client only works with "None" (missing) case, not the empty string case:
https://github.com/delta-io/delta-sharing/blob/main/python/delta_sharing/delta_sharing.py#L277
With this issue, the Python client will loop forever.

This has been fixed in the most recent PR and will be released sometime soon


TypeError when computing Element.borderEdge/etc with fractional CSS values

If there are fractional CSS values involved in computing Element.paddingEdge/Element.borderEdge/Element.marginEdge, then the getters throw with the following error:
Uncaught exception:
TypeError: 0.1: type 'JSDouble' is not a subtype of type 'int'

Reduced test case:
import 'dart:html';

main() {
  var element = new Element.div();
  document.body.append(element);
  element.style.marginTop = '0.1px';
  element.style.borderTop = '0.2px';
  element.style.paddingTop = '0.3px';
  print(element.marginEdge);
}

Dart version: 2.4.0 (Dartpad)
Tested in dart2js

cc @eernstg

I don't really see any language level issue here, but there might be an issue caused by the choice of a new type (because Dart of today infers the type of a variable declared as var x = e; as the type of e, whereas x in Dart 1 had type dynamic).
The dart:html documentation says that the methods Element.paddingEdge, Element.borderEdge, Element.marginEdge all return a CssRect which implements Rectangle<num>. The code that actually runs would be something like the following:
@Native("Element")
class Element extends Node
    implements
        NonDocumentTypeChildNode,
        GlobalEventHandlers,
        ParentNode,
        ChildNode { ...
  CssRect get marginEdge => new _MarginCssRect(this);
}
...

abstract class CssRect implements Rectangle<num> { ...
    num _addOrSubtractToBoxModel(
      List<String> dimensions, String augmentingMeasurement) { ...
    var val = 0;

    for (String measurement in dimensions) {
      // The border-box and default box model both exclude margin in the regular
      // height/width calculation, so add it if we want it for this measurement.
      if (augmentingMeasurement == _MARGIN) {
        val += new Dimension.css(
                styles.getPropertyValue('$augmentingMeasurement-$measurement'))
            .value;
      }
   ...
    return val;
  }
}

The problem might be that the above code hasn't been tested with non-integral numbers for a long time, and val is now inferred as int val because of the initializer, so val += ... makes an attempt to add a double (typed as num) to val, which causes the run-time failure as reported. In that case using double val = 0; should fix the issue.
@terrylucas, you have been working on this file recently—WDYT?

@terrylucas
Looks like this code in dart:html:
  num _addOrSubtractToBoxModel(
      List<String> dimensions, String augmentingMeasurement) {
    // getComputedStyle always returns pixel values (hence, computed), so we're
    // always dealing with pixels in this method.
    var styles = _element.getComputedStyle();

    var val = 0;

should be (see type on last line):
  num _addOrSubtractToBoxModel(
      List<String> dimensions, String augmentingMeasurement) {
    // getComputedStyle always returns pixel values (hence, computed), so we're
    // always dealing with pixels in this method.
    var styles = _element.getComputedStyle();

    double val = 0;

Or, alternately: var val = 0.0

Fixed by @Markzipan in https://dart-review.googlesource.com/c/sdk/+/118240


bug; abort called for not started nodes

TL;DR
A regression was introduced, that would let abort be propagated for nodes that are not yet started.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
Added checks and unit tests
Tracking Issue
https://github.com/lyft/flyte/issues/333
Follow-up issue
NA

Codecov Report

Merging #140 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.


Gem won't install on Windows 2019 Server Core

Hi there - it seems the current approach for unzipping is not very portable across Windows systems due to the use of cscript/vbascript to unzip the binary.
It works fine on Windows 10/11, however on Windows 2019 Server Core (e.g container mcr.microsoft.com/windows/servercore:ltsc2019), it fails to install without any feedback.
fetch https://github.com/sass/dart-sass-embedded/releases/download/1.54.9/sass_embedded-1.54.9-windows-x64.zip
cscript unzip.vbs //B //Nologo sass_embedded-1.54.9-windows-x64.zip .
rake aborted!
sass_embedded/dart-sass-embedded not found

By removing the //B argument to cscript (suppresses all errors) you now get feedback on the failure:
fetch https://github.com/sass/dart-sass-embedded/releases/download/1.54.9/sass_embedded-1.54.9-windows-x64.zip
cscript unzip.vbs //Nologo sass_embedded-1.54.9-windows-x64.zip .
C:\go\pipelines\test\ext\sass\unzip.vbs(10, 1) (null): Unspecified error

rake aborted!
sass_embedded/dart-sass-embedded not found
C:/go/pipelines/test/ext/sass/Rakefile:28:in `block in <top (required)>'
Tasks: TOP => default => install => embedded.rb
(See full trace by running task with --trace)
rm sass_embedded-1.54.9-windows-x64.zip

Line 10 is
https://github.com/ntkme/sass-embedded-host-ruby/blob/81177507031b58175dfd6e7ecc9f133a7d2303fb/ext/sass/unzip.vbs#L10
The reason this doesn't work is that the NameSpace logic here seems to rely upon some kind of Compressed Folders feature of the Windows shell/explorer that makes zips easy to work with. This feature is so old, that it seems difficult to find information about, but is hinted at here.

In addition, this method will NOT work if Compressed Folders is disabled. In that situation, you will get this message:
Path\to\script.vbs(line number, char number) (null): Unspecified error
It is simple to Google how to enable/disable Compressed Folders.

Maybe was simple to google in 2011, but not so much now? 😅 I am inferring that this is not enabled by default on server variants especially Core which omits many features of full fledged windows. These core variants are common to use to run as build agents (we use Windows 2019 Server Core containers to build). I'm not even sure how to enable whatever is needed when building a docker image to try and resolve this, but will keep playing around.
Would you consider going back to a more standard approach here, using Powershell 5? I don't have context on why it was replaced in https://github.com/ntkme/sass-embedded-host-ruby/commit/778c61a9bc393a3bd6e0736c3d5b09fbebe55843 but it seems this would be more robust to me, rather than depending on weird Windows Shell options like Compressed Folders?

Have you tried the pre-built ones which does not require vbscript for unzipping? E.g.
1.54.9 - September 08, 2022 x64-mingw-ucrt (3.04 MB)
1.54.9 - September 08, 2022 x64-mingw32 (3.04 MB)
1.54.9 - September 08, 2022 x86-mingw32 (14.2 MB)

I guess you're on JRuby? I can put back the powershell version.

Yeah, on JRuby. I don't follow all the way this works but I understand all the challenges with platform detection (the same ones that cause me issues with sassc and libsass trying to compile on Windows) causes it to "build the native extension" i.e download and unzip in this case.

@chadlwilson I don't have access to windows. If possible can you please see if the main branch works?
gem 'sass-embedded', github: 'ntkme/sass-embedded-host-ruby'

Thanks! 🙏 Switched in https://github.com/gocd/gocd/pull/10796
4724a84 seems to be working fine on both Windows 2019 Server Core and Windows 11 (with appropriate Set-ExecutionPolicy, one of these annoying Powershell things, I guess 🤔).
Windows 11
Fetching https://github.com/ntkme/sass-embedded-host-ruby.git
Using sass-embedded 1.54.9 from https://github.com/ntkme/sass-embedded-host-ruby.git (at main@4724a84)

gem_make.out via JRuby
current directory: C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/sass-embedded-host-ruby-4724a844b7cd/ext/sass
C:/gocd/server/scripts/jruby.bat -Iuri:classloader:/META-INF/jruby.home/lib/ruby/stdlib -rrubygems C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/gems/rake-13.0.6/exe/rake RUBYARCHDIR\=C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/extensions/universal-java-17/2.6.0/sass-embedded-host-ruby-4724a844b7cd RUBYLIBDIR\=C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/extensions/universal-java-17/2.6.0/sass-embedded-host-ruby-4724a844b7cd
fetch https://github.com/sass/dart-sass-embedded/releases/download/1.54.9/sass_embedded-1.54.9-windows-x64.zip
powershell -NoLogo -NoProfile -NonInteractive -File unzip.ps1 -Archive sass_embedded-1.54.9-windows-x64.zip -DestinationPath .
rm sass_embedded-1.54.9-windows-x64.zip
fetch https://github.com/sass/embedded-protocol/raw/1.1.0/embedded_sass.proto
fetch https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/3.21.5/protoc-3.21.5-windows-x86_64.exe
chmod a+x protoc.exe
./protoc.exe --proto_path=. --ruby_out=. embedded_sass.proto

Windows 2019 Server Core
Fetching https://github.com/ntkme/sass-embedded-host-ruby.git
Using sass-embedded 1.54.9 from https://github.com/ntkme/sass-embedded-host-ruby.git (at main@4724a84)

I just pushed a Java based unzip solution. It should work better for JRuby on Windows as neither powershell nor vbscript is required.

OK, I can give it a go tomorrow 🙏

Working fine on Windows 11.
current directory: C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/sass-embedded-host-ruby-0d103fd1936a/ext/sass
C:/gocd/server/scripts/jruby.bat -Iuri:classloader:/META-INF/jruby.home/lib/ruby/stdlib -rrubygems C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/gems/rake-13.0.6/exe/rake RUBYARCHDIR\=C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/extensions/universal-java-17/2.6.0/sass-embedded-host-ruby-0d103fd1936a RUBYLIBDIR\=C:/gocd/server/src/main/webapp/WEB-INF/rails/gems/jruby/2.6.0/bundler/gems/extensions/universal-java-17/2.6.0/sass-embedded-host-ruby-0d103fd1936a
fetch https://github.com/sass/dart-sass-embedded/releases/download/1.54.9/sass_embedded-1.54.9-windows-x64.zip
Archive:  sass_embedded-1.54.9-windows-x64.zip
  inflating: sass_embedded/src/LICENSE
  inflating: sass_embedded/src/dart.exe
  inflating: sass_embedded/src/dart-sass-embedded.snapshot
  inflating: sass_embedded/dart-sass-embedded.bat
rm sass_embedded-1.54.9-windows-x64.zip
fetch https://github.com/sass/embedded-protocol/raw/1.1.0/embedded_sass.proto
fetch https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/3.21.5/protoc-3.21.5-windows-x86_64.exe
chmod a+x protoc.exe
./protoc.exe --proto_path=. --ruby_out=. embedded_sass.proto

And on Windows 2019 Server Core (don't have easy access to gem_make.out here)
> Task :server:initializeRailsGems
Using environment variables
CLASSPATH='C:\Users\ContainerAdministrator\.gradle\caches\modules-2\files-2.1\org.jruby\jruby-complete\<IP_ADDRESS>\92b318807fd957ace836078a1df5810e5471f42\jruby-complete-<IP_ADDRESS>.jar' \
 GEM_HOME='C:\go\pipelines\build-windows\server\src\main\webapp\WEB-INF\rails\gems\jruby\2.6.0' \
 GEM_PATH='C:\go\pipelines\build-windows\server\src\main\webapp\WEB-INF\rails\gems\jruby\2.6.0' \
     PATH='C:\go\pipelines\build-windows\server\scripts;C:\go\pipelines\build-windows\server\src\main\webapp\WEB-INF\rails\gems\jruby\2.6.0\bin;C:\tools\ruby31\bin;C:\Program Files\Eclipse Adoptium\jdk-<IP_ADDRESS>-hotspot\bin;C:\Python310\Scripts\;C:\Python310\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\ProgramData\chocolatey\bin;C:\Program Files\nodejs\;C:\Program Files (x86)\nant-0.92\bin;C:\Program Files (x86)\Yarn\bin\;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Git\cmd;C:\Program Files\Perforce\;C:\Program Files (x86)\GNU\GnuPG\pub;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;C:\Program Files\Amazon\AWSCLIV2\;C:\Program Files\\Perforce\\bin;C:\Users\ContainerAdministrator\AppData\Local\Microsoft\WindowsApps;C:\Users\ContainerAdministrator\AppData\Roaming\npm;C:\Program Files\Mercurial\;C:\Users\ContainerAdministrator\AppData\Local\Yarn\bin' \
     RUBY='C:/go/pipelines/build-windows/server/scripts/jruby.bat' \
[C:\go\pipelines\build-windows\server\src\main\webapp\WEB-INF\rails]$ java -Djruby.home=uri:classloader://META-INF/jruby.home -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Xss2048k -client --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED -Xmx1g -Dfile.encoding=windows-1252 -Duser.country=US -Duser.language=en -Duser.variant -cp C:\Users\ContainerAdministrator\.gradle\caches\modules-2\files-2.1\org.jruby\jruby-complete\<IP_ADDRESS>\92b318807fd957ace836078a1df5810e5471f42\jruby-complete-<IP_ADDRESS>.jar org.jruby.Main org.jruby.Main -S bundle install

# ... snip

Fetching https://github.com/sass/sassc-ruby.git
Fetching https://github.com/ntkme/sass-embedded-host-ruby.git
Using sassc 2.4.0 from https://github.com/sass/sassc-ruby.git (at refs/pull/233/head@244d3dc)
Using sass-embedded 1.54.9 from https://github.com/ntkme/sass-embedded-host-ruby.git (at main@0d103fd)
Fetching sassc-embedded 1.54.0
Installing sassc-embedded 1.54.0
Fetching sassc-rails 2.1.2
Installing sassc-rails 2.1.2

# ... snip

Bundle complete! 14 Gemfile dependencies, 72 gems now installed.
Bundled gems are installed into `./gems`

And then works fine after that with the assets pipeline :-)

Hello @ntkme - are you planning to publish a 1.59 patch release with these enhancements soon? It would be useful so I can switch back to proper rubygems releases rather than using main in order to have things working on Windows.

Dart Sass 1.55.0 (https://github.com/sass/dart-sass/pull/1806) will be released soon, and I will cut a matching release once 1.55.0 is out.


[SP-1824][PDI-12847] - TextFileOutput step splits the rows incorrectly

@mattcasters, @brosander, @mattyb149 Could you review and merge this backport for
https://github.com/pentaho/pentaho-kettle/pull/1223  and https://github.com/pentaho/pentaho-kettle/pull/1223
Should I squash this commits?

@mattyb149, @brosander, review it please

@deinspanjer could you review it, please?


bug(dashmate): cannot change base template settings before setup

Expected Behavior

You can change base template config and it will persist during setup command
Current Behavior

Some config values gets overwritten because migrations are getting executing during setup process
Possible Solution

Fix this thing, so you can change some default values in the first place.
Steps to Reproduce (for bugs)

dashmate config set --config local platform.drive.tenderdash.log.level trace
dashmate setup local

Context

Your Environment

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop, server, or mobile):
Link to your project:

@pshenmic This is happening because the dashmate setup local command configures logs verbosity. The config options that the dashmate setup local doesn't touch are inherited from the local preset. If you still think it's a bug please reopen it and provide a description how you think it should behave.


1.20.1 Issue

Only the Aether dragon seems to be in the mod and no ther dragon. Any fixes?

hey i downloaded an extra mod on curseforge it adds more dragons and i have a decent set now mod is called Dragon Mounts: More Dragons


feat(#74): incorrect-test-object-name lint

In this pull I've introduced new lint: incorrect-test-object-name, that issues warning defect if test object name doesn't match special regexp.
closes #74
History:

feat(#74): test case
feat(#74): test object name
feat(#74): cases
feat(#74): lines
feat(#74): regexp
feat(#74): allows good
feat(#74): motive

@yegor256 take a look, please

@yegor256 updated pull request. Take a look again, please

@h1alexbel perfect, thanks!


Windows10 problem. Cannot run node recognize.js listen

Hello
I am trying to launch nodejs-speech/samples by using node recognize.js listen
but it is not working. The error message is the following:
node recognize.js listen
Listening, press Ctrl+C to stop.
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: spawn rec ENOENT
    at _errnoException (util.js:1024:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
    at onErrorNT (internal/child_process.js:372:16)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
    at Function.Module.runMain (module.js:678:11)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

I am using Windows10, I set $env:GOOGLE_APPLICATION_CREDENTIALS="D:\projects\current\speech\speech-recognition-1eec10025372.json".
Also I added sox folder to $path.
When I try another command:
node recognize.js sync ./resources/audio.raw -e LINEAR16 -r 16000

It works fine.
What is wrong? Let me know, please.
Best regards.

👋  @googleapis/ml-apis

Hi, do you have sox installed on your machine?

Does not work, Sox 14.4.2 and 14.4.1 both tried and, yes they were added to PATH.

@ajaaym can you please have someone take a look at this?

@sduskis ack, will have someone to start on this soon.

please go through this issue and change the index.js of node-record-lpcm16 as suggested here.

@GTamara just following up, did @laljikanjareeya's recommendation do the trick for you?

Also following up, any movements toward a longer term fix?

issue in node-record-lpcm16 and PR for this issue is already in node-record-lpcm16 repository, once they release the new version we will upgrade it.

currently blocked by https://github.com/gillesdemey/node-record-lpcm16/pull/46


there is issue with error messages

please check this

i guess u have to do prop or smth so i can change the color of the background and the font color  for handle things like this

Hello @OmarHossamEldin 👋
I will add component customization in the next version.
Thanks for your suggestion!

gl @yudax42 <3


Made path resolution algorithm more robust, added support for non-anaconda environments

Thanks Immortalin. I am hesitant to edit this codebase because it is part of the methods for a scientific paper.
However, please do check out our new simulator which we are trying to make more user friendly:
https://cdorgs.github.io/code
We will address pull requests there if you have any.
~Sam

Thanks Immortalin. I am hesitant to edit this codebase because it is part of the methods for a scientific paper.
However, please do check out our new simulator which we are trying to make more user friendly:
https://cdorgs.github.io/code
We will address pull requests there if you have any.
~Sam


example monaco-graphql-webpack not working properly

Hi gays
I tried to execute the example.
I execute yarn && yarn build first
Entering the [example/monaco-graphql-webpack]  directory,
execute yarn start
I got error like this

Is there anything I missed or did wrong?

Hey @imranyun, thanks for reporting 👋 quick check from my side confirms that the same thing happens for me, so this looks like a bug (but I don't know monaco-graphql good enough to know why).

@imranyun my bad, we need to update the example, it likely needs an update to the ancient webpack config


feat: added ability to set default axios instance for all rest instances

Added ability to set default axios instance
Added ClientCredentialsRequest to oAuth2.ts

@ChuckJonas Can I get a review?

Alternatively, if we could get access to the axios instance when using setDefaultConfig so as to add on interceptors (primarily for auth refetch), that would also be another approach.

Curious what your use case was for the default Axios instance was?  If I needed to modify its behavior, I'd always just do so after setting up the default instance (via the request property).
Your approach is probably more explicit and self documenting though

@kpervin  Sorry, I should have looked at the code more closely (it's been a while since I wrote this).
The default rest instance IS a "singleton"
That means you should be able to do something like this:
setDefaultConfig(...)
const client = new Rest()
client.request.interceptors = ...

Either way, like I said before, your improvements make this process more explicit so I think they make sense

Part of the reason for this would be to add in capabilities for NestJS, such that:
@Module({
  imports: [
    ConfigModule.forFeature(salesforceConfig),
    HttpModule.registerAsync({
      imports: [ConfigModule.forFeature(salesforceConfig)],
      inject: [salesforceConfig.KEY],
      useFactory: (config: ConfigType<typeof salesforceConfig>) => {
        return {
          baseURL: config.instanceUrl,
        };
      },
    }),
  ],
})
export class SalesforceModule implements OnModuleInit {
  private logger = new Logger(SalesforceModule.name);

  constructor(
    private http: HttpService,
    @Inject(salesforceConfig.KEY)
    private readonly config: ConfigType<typeof salesforceConfig>,
  ) {}

  private auth(): Promise<TokenResponse> {
    return this.http.axiosRef
      .post<TokenResponse>(
        "/services/oauth2/token",
        new URLSearchParams({
          grant_type: "client_credentials",
          client_id: this.config.clientId,
          client_secret: this.config.clientSecret,
        }),
      )
      .then(({ data }) => {
        setDefaultConfig({
          accessToken: data.access_token,
        });
        return data;
      })
      .catch((e) => {
        throw e;
      });
  }
  public onModuleInit(): void {
    this.http.axiosRef.interceptors.response.use(
      (response) => {
        return response;
      },
      async (error) => {
        const originalRequest = error.config;

        // If the error is due to token expiry
        if (error.response.status === 401) {
          this.logger.log("Access token expired. Refreshing...");
          delete this.http.axiosRef.defaults.headers.common["Authorization"]; // Remove the invalid access token

          try {
            // Obtain a new access token
            const { access_token } = await this.auth();

            originalRequest.headers["Authorization"] = `Bearer ${access_token}`;
            return this.http.axiosRef.request(originalRequest); // Retry the original request with the new access token
          } catch (error) {
            this.logger.error("Error refreshing access token:", error);
            return Promise.reject(error);
          }
        }

        return Promise.reject(error);
      },
    );
    setDefaultConfig({
      instanceUrl: this.config.instanceUrl,
      version: this.config.version,
      axiosInstance: this.http.axiosRef,
    });
  }
}

This means that it has underlying access to all NestJS lifecycles due to the module-based approach.


fix(repeatWhen): support synchronous notifier

test(repeatWhen): rename to repeat in descriptions
test(repeatWhen): align expectations with docs
test(repeatWhen): add failing empty notifier test
test(repeatWhen): add failing notifier test
fix(repeatWhen): support synchronous notifier

Description:
This PR cherry picks the commits made in #3460 into the stable branch.
The problem with the repeatWhen operator has been present for sometime, so I guess it should be fixed in stable, too.
Related issue (if exists): #3444

Coverage remained the same at 97.4% when pulling 3c86f32761071953a59da899b58353bb4d11233a on cartant:issue-3444-stable into 4cbd91c64cf7c2e5143203f2fd34014ea627d200 on ReactiveX:stable.

Thank you, @cartant!


Ingesting tabulate as an internal module

What is the change?
I removed the tabulate dependency, and just ingested the parts of that tool we use to armi.utils.tabulate.
Why is the change being made?
To close #1749
The problem is that tabulate appears to be a nigh abandoned project, and it is keeping us from being able to support modern PIP versions.
(Arrielle also points out that we could just replace tabulate with something else, like prettytable. I am not super convinced my approach here is better than that one. I went this route first because it was easy for me to do, and would be easier to make the update for our downstream repos.)
Code Coverage
The code coverage on this file is pretty high:

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

I think it's fine to pull in 🐫 case throughout and then move code over to armi's tabulate as it makes sense. Should be pretty easy to see where to replace these things. Could also replace things that are 🐍 case with a simple name (tabular_data -> data or something). Should we pull in additional documentation of this new feature into the ARMI docs?

I think it's fine to pull in 🐫 case throughout and then move code over to armi's tabulate as it makes sense. Should be pretty easy to see where to replace these things. Could also replace things that are 🐍 case with a simple name (tabular_data -> data or something). Should we pull in additional documentation of this new feature into the ARMI docs? For example pull in examples from https://github.com/astanin/python-tabulate?tab=readme-ov-file#library-usage?

Most of that is already included in the docstring for the tabulate.tabulate() function:
https://github.com/terrapower/armi/blob/cac33246db511304058a50837fa24349b13fcb78/armi/utils/tabulate.py#L1027-L1043
I considered putting what you linked as a module-level docstring, and reducing this ridiculously long function docstring (>200 lines). I could do that, and find any missing pieces from the docs you linked as well.

@jakehader I grabbed that README and put it in the module-level docstring in this file.  Thanks!


Add vault credential to factory and provision_job_options.

Add  ansible_vault_credential into factory.
Add vault credential to service's provision_job_options.

Blocks https://github.com/ManageIQ/manageiq-providers-ansible_tower/pull/70.
@miq-bot assign @gmcculloug
@miq-bot add_label enhancement, gaprindashvili/yes, services
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1526048 required to get to Embedded Ansible 3.2.x
Part of https://bugzilla.redhat.com/show_bug.cgi?id=1561116 required to get to Embedded Ansible 3.2.x

Gaprindashvili backport details:
$ git log -1
commit 1d081728431111d2e6d32290a0ffc5ab9f427a3e
Author: Greg McCullough<EMAIL_ADDRESS>Date:   Tue Mar 27 10:22:02 2018 -0400

    Merge pull request #17207 from lfu/ansible_vault_credential_3

    Add vault credential to factory and provision_job_options.
    (cherry picked from commit 1d647baa7207499b046aeda30447fab51b78798f)

    https://bugzilla.redhat.com/show_bug.cgi?id=1561146


Force software based aes_cbc decryption

Hi Bubblepoint,
with this pull request I do the following changes to the code:

Force always a software based encryption to avoid runtime errors
Bump to version 0.2.0
Fix some comments
Update dependency crates

I hope you can merge this request and upload a new version to crates.io.
After this is done, my actual project spe3d can again use it.
Thanks,
Robert

Hi Robert
Thank you for your commit. crates.io ist updated. Your project sounds interesting.
Best regards,
Tobias


Raising this issue in the WHATWG

I came across this on Twitter and since I've been involved I wanted to provide more background and make a suggestion.
This was removed from the spec in https://www.w3.org/Bugs/Public/show_bug.cgi?id=19619, and the discussion there is worth looking over. It mostly boils down to the observations listed in https://github.com/filamentgroup/html-video-responsive#challenges-and-differences-from-picture. I was initially skeptical of removal, but eventually came around to removing it from Blink, which then led to the spec removal. I was happy about that outcome at the time, but seeing repo/proposal I'm not so sure it was the right call.
It would be great if you could file an issue at https://github.com/whatwg/html/issues/new about solving the problem of video delivery size on mobile. It's very interesting to see that it's actually heavier on mobile than on desktop, and it seems like an important problem to solve. Whether reviving the media attribute is the way to make it happen I'm not sure, but it seems well worth revisiting, 6 years later.
cc @zcorpan

For anyone who lands here, I found what appears to be the relevant issue: https://github.com/whatwg/html/issues/6363


ConnectedFieldArray.js uses "includes" which is unsupported in IE11

Are you submitting a bug report or a feature request?

What is the current behavior?

IE11 blows up when visiting a form that uses a FieldArray
What is the expected behavior?
IE11 shouldn't blow up
Sandbox Link

What's your environment?

Form v7.1.1
IE11
Other information

TypeError: Object doesn't support property or method 'includes'

Swapping in thisValue.indexOf(val) !== -1 for thisValue.includes(val) and IE11 no longer blows up.

Thanks for the report! Would you like to send a PR to fix this?

Will do it tomorrow, cheers!

Fix published in v7.1.2.


New mainfields option

Closes https://github.com/rollup/rollup-plugin-node-resolve/pull/180
/cc @kkalass @ncoden @TrySound

Just added a commit to switch the order so browser takes top precedence. I think this is ready to go!

This feature would help with a fix in the bazel rollup_bundle rule. Is there anything left blocking it from getting merged in? Anything I could do to help? Thanks

Ping. @lukastaegert @allex @kkalass Do you have time to review this? Or could we land #429 instead if this is still blocked?

Another gentle ping for @lukastaegert would be great to get this in.

I hope I find time in the next days, for now I am patching up things elsewhere.

Would be nice to have a look why the tests are failing

Ok, started checking this. I am not really happy about how browser is handled. browser CAN be an entry point, but it can also just replace some files. Currently, the "replacing" will happen if browser is "somewhere in the list". This looks really confusing. I would prefer to keep browser separate in the options.

I have fixed the remaining issues and updated the branch. I kept the behaviour for "browser" but also kept the "browser" option as a non-deprecated alternative and extended the Readme. From my side, this is good to go.

This LGTM 👍. What's the merge etiquette now? Shall I merge+release or would you like to @lukastaegert? This should be semver minor still, right?

I would actually consider it major due to the new deprecation warnings. Please merge and release at your own discretion!

I would actually consider it major due to the new deprecation warnings.

In SemVer it MUST be a MINOR for deprecation warnings. You don't have to do a MAJOR ("MAJOR MAY include MINOR").

I do not see a "must" in that document but rather a recommendation. Personally, I like Facebooks approach with React of doing deprecations over two major versions. But sure, I have no problem with doing it in a minor, this is not Rollup core.

@lukastaegert

[...] It MUST be incremented if any public API functionality is marked as deprecated [...]

-- https://semver.org/#spec-item-7
The anchor doesn't seem to work

I like Facebooks approach with React of doing deprecations over two major versions

In strict mode you get them between minors: https://github.com/facebook/react/blob/master/CHANGELOG.md#react-1


implement TextView using WebView; split FilePreview up

This PR integrates Taru's findings on WebView to implement a TextView component. Just the component here; I still haven't hooked up actual content yet. I think actions are mostly ready; we just need to change a few places to handle the new web-view and web-view-text intent, and perhaps add a loading screen while we copy files to local.
Screenshots:

Let's chat about this pr

@jzila @chrisnojima ready for review again!
There doesn't seem to be a way to disable javascript on react-native. This option only works on Android. We can still use the mime-type to make the webView show .html as plain text though.

Thanks @chrisnojima !

Hmm in my simulator, it seems the old WebView is actually a lot faster than WKWebView. Not sure if it's because the later is better sandboxed so can't utilize local cache.

The simulator should not be used to profile anything

It's a simulator and not an emulator. Totally different than the device

I see; makes sense. I'll just keep the WK one for now and try it out on my phone after the admin build is out then. Thanks!


Fix false negatives for Style/MapIntoArray when using non-splatted arguments

Bugfix https://github.com/rubocop/rubocop/pull/13119 fixed the splat bug in Style/MapIntoArray, but it also limited the types of offenses the cop recognized. For example,
dest = []
arr.each { |e| dest << [1, e] }
arr.each { |e| dest << true }
arr.each { |e| dest << (cond? ? 1 : e) }

and several others are no longer detected as of 1.66.1
This PR restores the original cop behavior while preserving the splat fix.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@vlad-pisanov Ping :-)

@vlad-pisanov Can you take a look at this?

Thanks!


Inference

How could I do the inference on Cityscapes dataset? Can someone help me please?
Thank you!

Use test.py and enter the required arguments.


Large update of obsolete datasets

@jbusecke , I just want to give you a heads up that I am starting to go through the whole CMIP6 collection, replacing old dataset versions with new versions when available. I have only been replacing old datasets upon request so far, so the downstream effects have been minimal.  There have been many updates to existing datasets since we started building our GC CMIP6 collection, so I am anticipating some confusion and glitches in the next few weeks as I focus on this large remove/replace process.
For @jbusecke, this could change the pre-processing required for some of the datasets (hopefully it will fix many problems??).  The tracking_id will change, as should the version entry in the csv forms for each of the affected datasets.
For everyone, there will be small intervals when a dataset is temporarily unavailable and/or the csv catalog is temporarily out of sync.  I have tried to minimize the disruption, but replacing objects in the object store is a bit of a pain.
Apologies in advance for any disruption, but it had to happen.  In future, the processing of any new request coming in involves the checking and replacement of any datasets for which there is a newer version. So this is not a one-time revision - datasets in the future will be automatically updated as new versions become available.

Thanks for the heads up! I'll try to catch stuff with my new testing but maybe we could build in a quick check into your routines aswell? Do you perform a final check after the store is created? If you think it would be useful to link in parts of my tests there (they don't take super long) and flag problems that way, I'd be happy to discuss more (and supply code 😃). In any way, is there an easy way of getting a list of recently updated stores?

Thanks for the heads up! I'll try to catch stuff with my new testing but maybe we could build in a quick check into your routines aswell? Do you perform a final check after the store is created? If you think it would be useful to link in parts of my tests there (they don't take super long) and flag problems that way, I'd be happy to discuss more (and supply code 😃). In any way, is there an easy way of getting a list of recently updated stores?

I do perform a final check on all stores, but, even if I could check for all known and unknown problems, the codes are already so complicated it is really best if I concentrate on the new workflow before changing it again!
Since the list of recently updated stores changes minute to minute, the easiest thing to do is quick diffs with previous csv catalogs - I could put every version for the past six months in my cmip6collect2 repo - and provide a sample notebook to make a list of changed datasets between any two dates. Helpful?

I do perform a final check on all stores, but, even if I could check for all known and unknown problems, the codes are already so complicated it is really best if I concentrate on the new workflow before changing it again!
Since the list of recently updated stores changes minute to minute, the easiest thing to do is quick diffs with previous csv catalogs - I could put every version for the past six months in my cmip6collect2 repo - and provide a sample notebook to make a list of changed datasets between any two dates. Helpful?

Totally understand that sentiment!

Since the list of recently updated stores changes minute to minute, the easiest thing to do is quick diffs with previous csv catalogs - I could put every version for the past six months in my cmip6collect2 repo - and provide a sample notebook to make a list of changed datasets between any two dates. Helpful?

I believe so, yes. I will try to take a look soon and maybe put in another part of the cmip6_pp ci to just check the most recent updates, to catch problems early.

Totally understand that sentiment!

Since the list of recently updated stores changes minute to minute, the easiest thing to do is quick diffs with previous csv catalogs - I could put every version for the past six months in my cmip6collect2 repo - and provide a sample notebook to make a list of changed datasets between any two dates. Helpful?

I believe so, yes. I will try to take a look soon and maybe put in another part of the cmip6_pp ci to just check the most recent updates, to catch problems early.

@jbusecke - There is a new notebook here for listing the new versions.  I have put about 6 months worth of old catalogs in the GC bucket, gs://cmip6, so the notebook finds the catalog for a given date and then lists the zarr stores versions, both old and new.

@jbusecke - There is a new notebook here for listing the new versions.  I have put about 6 months worth of old catalogs in the GC bucket, gs://cmip6, so the notebook finds the catalog for a given date and then lists the zarr stores versions, both old and new.


Correct JSON tags in v1alpha1 fields

Some of these were missed across two or three different PRs.

LGTM

just waiting on CI