Generic annoyances.

I recently had to write a line of code which annoyed me greatly:
n.Assignment.GetType().BaseType.ActualType().(TupleType)
Is there any reason why we don't eliminate the generic arguments as early as possible so we can avoid wrapping types in yet another layer of stuff?
@MovingtoMars

I like the idea of an intermediate stage of code between semantic and codegen where interfaces are "flattened out" (this could be helpfulf for a lot of Ark-specific optimisations).
However, I think we should keep generic arguments how they are until after semantic because I think it gives much better error messages. There might be some more reasons to keep them, but I can't think of any right now.


Fix: Add .gitattributes to set LF endings

Set .gitattributes so that LF endings are used on git clone for Windows, jscs linting fails otherwise

LGTM :thumbsup:

[Current coverage][cc-pull] is 100%

Merging [#206][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #206   diff @@
==========================================
  Files            21         21
  Lines           222        222
  Methods          38         38
  Messages          0          0
  Branches         23         23
==========================================
  Hits            222        222
  Misses            0          0
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [cb5c75b...43ed8de][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Adslot/alexandria/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Adslot/alexandria/compare/cb5c75b44fae159fc1c82d516e7ca8e28ca6e3dc...43ed8de97bb5cbf0c70ed18589b974c62da1319d
[cc-pull]: https://codecov.io/gh/Adslot/alexandria/pull/206?src=pr

Merging...


May array into an object

how to map an array into an object, say , use fn1 to map key and fn2  to map value

Here's one solution:
//    strMapFromArray :: (a -> String) -> (a -> b) -> StrMap b
const strMapFromArray = R.curry((keyFn, valFn, xs) =>
  R.fromPairs(R.map(x => [keyFn(x), valFn(x)], xs))
);

strMapFromArray(R.toUpper, R.identity, ['a', 'b', 'c']);
// => {A: 'a', B: 'b', C: 'c'}

See StrMap if you're wondering why I used StrMap b rather than Object in the type signature.

good solution. I don't know why Ramada didn't include such functions


⚠ Bofrost.es has degraded performance

In a260200, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1521 ms

Resolved: Bofrost.es performance has improved in 89e5093 after 9 minutes.


Arrays can now be read in every case, even at the root of the document

What this PR does:
Fixes a regression that was recently encountered, where root level array data could be written but could not be read back out.  When reading back out a 500 would occur consistently.
Which issue(s) this PR fixes:
Fixes #1224
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[x] Documentation added/updated

One beginner question: are root-level arrays expected valid content? I assume so, just wanted to verify as requiring (JSON) Object at root level is something databases could legitimately do.

So I remembered that initially root-level arrays were allowed, and suspected that at some point things regressed, so I looked back in git history; and sure enough there was a point where the code got refactored and the support for it sort of got dropped (and there was no test to cover it)
At any rate, I think it is legitimate to allow root-level docs - search will still work with them (you could search using the array path brackets like [0].whatever), and since it's valid JSON I think it is reasonable to allow them as documents!

@EricBorczuk this is probably something Lorene could maybe help with once she is back?


Internal classes don't type check properly

Classes in the yoga-sys package are written in a way that Luau doesn't type check properly (self is any). These should be updated to type the self parameter explicitly.
This is the cause of this issue. Explicitly typing the self parameter will catch type errors in CI.

Closed by #11


🦄 Hola
¡Hola, AsyncAPI community! 😄
For today's latest announcement around AsyncAPI Docs 📑, I wanted to share with all technical writers about our organization’s plan for participation in Google Season of Docs 2023 (GSoD). Any and all technical writers are welcome to come and interview with us for GSoD 2023 season, regardless of tech background or years of experience! At AsynAPI, we love mentoring folks who want to get involved in OSS, tech, and Docs. ❤  If AsyncAPI is accepted into GSoD 2023, we will conduct interviews and review portfolios. Stay tuned!
As some may remember, last year, AsyncAPI participated successfully in GSoD 2022, and I wrote a case study summarizing the work involved and our results.
In anticipation of our application for this year, I have created a new AsyncAPI Slack channel named #temp-gsod-2023 that anyone can join! First, join our Slack workspace ☎  and please respect our slack etiquette.🙂 Then join the #temp-gsod-2023 channel, our temporary channel, to coordinate GSoD 2023 setup. I'll publish regular updates on where we are in the application process, so stay tuned as the process continues. 🙂
Join the #temp-gsod-2023 slack channel for:

Mentees identification
Mentors identification
Ideas identification
Mentees, ideas, and mentors matching

Below is the project proposal we've submitted to GSoD 2023, and then we close with a reminder of how to get started as an AsyncAPI Docs contributor:

🙌🏾  Bridge AsyncAPI Document Knowledge Gaps & Build Interactive Learning Paths
❤ About AsyncAPI
AsyncAPI (currently version 2.6.0, first released in 2016) is an Apache License 2.0 library under the Linux Foundation that seeks to improve the current state of Event-Driven Architectures (EDA). The AsyncAPI Initiative is a specification and growing set of open-source tools to help developers define asynchronous APIs and build and maintain EDAs. Developers familiar with OpenAPI (aka Swagger) for RESTful APIs will see strong similarities when using AsyncAPI. One common use case is generating documentation (HTML or Markdown) of an asynchronous API. The specification is both platform and language-agnostic. Current tooling includes support for common message brokers such as Apache Kafka and RabbitMQ and languages including Python, Java, and Nodejs. Our long-term goal is to make working with EDAs as easy as working with REST APIs. That goes from documentation to code generation, discovery to event management, and beyond. Our 150+ Open-Source (OSS) contributors are EDA enthusiasts from all around the world.
📑 About our Docs project
🔎 Our current Docs problems
First solution: cover AsyncAPI document sections in detail
First, the AsyncAPI documentation needs more in-depth explanations of the different sections of an AsyncAPI document to avoid difficulties in implementing EDAs.
Here are the individual sections of an AsyncAPI document we need to cover:

AsyncAPI structure - Introduce all root elements, add short explanation of info, servers, channels, components, and their purpose.
Adding variables to URL - Explain how to add variables to the server URL when parts of the URL may be different per runtime. Explain how these can be reused between two servers via components.serverVariables.
Adding channel - Explain the purpose of channels, different names for it, and what users should put here. Add a simple channel there, and explain how it relates to the server. If you specify a channel and server, it is expected that a given channel is present on all servers. Explain that the channel can also specify that it is present only on server A or server B.
Specifing dynamic parts of channel name - Explain how to use and reuse parameters.
Adding operations - Introduce operations, how many there can be, what kind of, and their purpose, and explain pub/sub.
Securing operations - Explain that server security applies to all the operations in all channels. Still, if you have different security per operation, you can use the security prop at the operation level.
Adding messages - Add a simple message as in previous examples, explain the most important parts, and explain there can be one or multiple (oneOf) under operation. Talk about contentType and add a note about defaultSchema. Also, show how to reuse components.
Payload schema - More complex message example with payload added using JSON and Avro schemas, and explain how to specify them. Explain how to reuse schema from components.
AsyncAPI reusable parts - Explain the $ref concept, introduce and explain that $ref can point to the same document, other documents in a local system, and external URLs.
Reuse with traits - Explain how trait concepts work.
Organizing document with tags - Explain different tags info in different parts of AsyncAPI and their purpose.
Extending AsyncAPI specification - Explain what to do when the specification does not yet support something you need, some field is missing, and more.

Second solution: Interactive Learning Paths
Second, our only educational content is static AsyncAPI documentation; the community needs more engaging and interactive ways to learn AsyncAPI concepts and architecture. To make learning AsyncAPI more accessible and enjoyable, we propose creating interactive learning paths that incorporate best practices. Our solution is to create interactive learning paths with engaging videos, gamification elements, immersive storylines with eLearning characters, badges, quizzes, points systems, etc.
By integrating these elements, we aim to make the learning experience more enjoyable and rewarding for the entire community. We can have videos that showcase AsyncAPI in action and visual animations of AsyncAPI spec terms and architecture. We'd love to create a  learning experience that is useful, fun, and interactive! The first learning paths would also be able to re-purpose content from the current AsyncAPI Docs content buckets of tutorials and concepts, which were created thanks to GSoD 2022.
In addition, we can create said interactive learning paths on the current Killercoda AsyncAPI profile ...

...or even host them with Linux Foundation interactive content.

🎯 Our Docs project’s scope
As a result, AsyncAPI is proposing two projects for the Google Season of Docs 2023:

Interactive Learning Paths: Our proposed solution aims to make learning AsyncAPI more enjoyable and accessible, reducing the learning curve and accelerating technology adoption by building interactive learning paths. By integrating best practices such as videos, gamification elements, immersive storylines, badges, quizzes, and a points systems in our learning paths, we can make the learning experience more rewarding and help OSS communities build better event-driven architectures with confidence.
Document the AsyncAPI document sections in detail: We will document the 12 sections of an AsyncAPI document, providing examples and use cases to help users understand how to code each section. By providing this information, we aim to improve the overall usability of the AsyncAPI document and make it easier for users to implement Event-Driven Architectures.

📏 Measuring our Docs project’s success
We will partially measure success in the Docs project by capturing specific feedback about these changes via our Docs feedback card, how many new OSS Docs contributors we gain from this effort, and by measuring engagement via our Docs analytics.
We will also track the number of views, likes, and shares of any new videos to measure user engagement. We'll even monitor user feedback to continue improving our videos further.

⌛ Timeline
The project will take approximately 4-6 months to complete, depending on the different levels of knowledge from diverse technical writers (TW) that might get involved. (At AsyncAPI, we want to work with any TW, regardless of their years of experience. We have a passion for mentorship, and we do not wish to have a bar that would prevent any TW from contributing to our OSS Initiative. We look forward to mentoring TW(s) who are completely new to tech and making them feel welcome!)
The timeline would look as follows:

May: Orientation on how to contribute to AsyncAPI Initiative, organize Docs issues, and assign good first-time-tickets to get each new TW contributor started.
June - August:	Each TW goes through designated issues marked for first-time contributors and work set aside for GSoD 2023. Each TW starts creating documentation for the issues assigned/selected.
September - October: We determine if we can complete both projects successfully and re-align priorities as needed.
November- early December:	Project completion and GSoD contributors receive some swag!

💸 Project budget
We'll set aside 2-3 mentors for our two proposed projects: documenting the AsyncAPI document sections in detail and creating educational videos. Should we be selected, AsyncAPI would like to request from Google a US $5000 budget for each project. For both projects, the request then totals a $10,000 budget. That said, we would also like to request an additional $350 dollars in our budget to provide cool swag for participants.

Budget item
Total Amount

Technical writer updates, reviews, edits AsyncAPI Interactive Learning Paths.
$5000

Technical writer updates, reviews, and edits AsyncAPI documentation section details.
$5000

Award swag to selected Technical Writers
$350

TOTAL
$10,350

👉🏽 Get started contributing to AsyncAPI Docs Today
Last but not least, don't forget that code isn't the only way to contribute to OSS; Dev Docs are a huge help that benefits the entire OSS ecosystem. At AsyncAPI, we value Doc contributions as much as every other type of contribution. ❤
To get started as a Docs contributor:

Familiarize yourself with our project's Contribution Guide and our Code of Conduct.
Head to our Docs GH Board here.
Pick an issue you would like to contribute and leave a comment introducing yourself. This is also the perfect place to leave any questions you may have on how to get started.
If there is no work done in that Docs issue yet and you've already received onboarding help, feel free to open a PR and get started!

🏷 Tag me in your AsyncAPI Doc PRs
Do you have a documentation contributor question, and you're wondering how to tag me into a GitHub discussion or PR? Never fear!
Tag me in your AsyncAPI Doc PRs or GitHub Discussions via my GitHub handle, alequetzalli 🐙.
-A.Q. 👩🏻💻 and Canela 🐕🦺
Originally posted by @alequetzalli in https://github.com/asyncapi/community/discussions/601

looking at the title and that description is a copy of discussion I assume it was created by mistake. Closing


Drop SelectTwoMany::one() method

PR Info

Closes https://github.com/SeaQL/sea-orm/issues/486

Breaking Changes

[x] Drop SelectTwoMany::one() method: SelectTwoMany is for selecting models of a one-to-many relationship but SelectTwoMany::one() returns Option<(E, Option<F>)> and the return value is a pair of models instead of (E, Vec<F>) which is weird select result for a one-to-many relationship

I guess we would like to add some API docs somewhere explaining the absence of such function.
But yeah it's a trap

Actually, it might be "easy" to make two queries, first one(), and then find_related ?

Docs updated :)


Add yesqa-style rule against unused ignores

Is your feature request related to a problem? Please describe.
It's good to ensure that the ignores remain up-to-date, in particular it would be nice to ensure that unnecessary ignores are deleted.

Describe the solution you would like
My favorite solution to this type of problem is yesqa or equivalently RUF100. In particular, I'd like a new rule, like maybe DEP005, that fails when there exists an ignore which was never triggered.

That would be a great feature indeed!
Similarly to Ruff, since it's kind of a "meta" rule, maybe we could use DEP100 rather than DEP005? If we ever add new rules that are closer in behavior to the existing ones, I feel that having DEP006 after this one would feel quite weird for users.

I made a quick start with this last week, in which I called it DEP100, see here. My idea was to add an attribute to the violation finders;
modules_to_ignore: A tuple of module names to ignore when scanning for issues. Defaults to an
    empty tuple.
used_ignores: a list to keep track of which values in 'modules_to_ignore' were actually used. This list should
    be updated during the `find()` method, so that the set difference of `modules_to_ignore` and `used_ignores`
    results in a set of modules in `modules_to_ignore` that no longer need to be ignored.

I struggled a bit with coming up how to implement it in the reporter classes, since they rely on a location; but we do not know the location for these ignores, they can come from either the command line or from pyproject.toml. Needs some more thought.


UIImageOrientation' has been renamed to 'UIImage.Orientation'

UIImageOrientation' has been renamed to 'UIImage.Orientation'

In objective-c it is still UIImageOrientation.


is it normal that LIME doesn't work with large dataset ?

Thank you for this interesting package !
I am trying to explain 100.000 observations with LIME but it doesn't work,
I have a memory error ..
Is it possible to avoid this error ?
thanks in advance

Can you show us the error? What type of features does your dataset have?

I have a similar problem... I was working with spark, and implemented some strategies to be able to use LIME. It works perfectly on small data. When I try to use it in a real dataset (>5m lines), it results in variables with 0 importances, all variables.

@khammouna  What classifier do you use? For my case I had to implement predict_proba by myself and  also encountered similar issue (out of memory). Solution was to change my implementation to use mini-batches for prediction.
Reason was, lime was calling predict_proba with 5000 instances and that was too much for my PC to handle at once.


Document running a jar using java -jar, maybe talk about systemd?

This should 100% be advanced usage.


Make 'gmaven.bzl' file generating more faster

Tested on my MacBook (2.4 GHz Intel Core i5), from 9 mins to about 3 mins.
On master branch:
$ time ( java GMavenToBazel; )
( java GMavenToBazel; )  13.94s user 1.71s system 2% cpu 9:37.83 total

Checkout the requested branch:
$ time ( java GMavenToBazel; )
( java GMavenToBazel; )  15.96s user 1.55s system 10% cpu 2:43.81 total

Sorry this took a while! Thank you for the contribution.


Prevent cycle by recording elements visited in each node path

Additional testing from the monitoring side will be added separately

Check out #15 and see if we like this better


Option to start minimized

there should be an option to run parsec-vsd minimized/closed without showing the UI on startup.

Add -silent to the exe shortcut, but didn't it run on startup silently?


[stable/atlantis] Add a flag to silence Atlantis repository whitelist errors

Signed-off-by: paulness<EMAIL_ADDRESS>
What this PR does / why we need it:
Github repositories not in the Atlantis whitelist that have nothing to do with the Atlantis pipeline are currently getting noisy comments about the repository not being whitelisted for Atlantis. This is undesirable for some organizations.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @jkodroff

Sorry I'm just seeing this now. Not sure why I wasn't auto-assigned.
You'll need to rebase off of master.


Web Build : Reflection probes not working correctly

Godot version:
3.2.1
OS/device including version:
Web Build + GLES2
Issue description:
Reflection probes not working correctly in web builds, see the image.
Steps to reproduce:
Minimal reproduction project:
https://www.dropbox.com/s/ndg1i75yknqfhus/minifix.zip?dl=0

@AlveLarsson Please upload a minimal reproduction project to make this easier to troubleshoot.
Also, which renderer are you using? You should always use GLES2 when exporting a project to HTML5.

@Calinou Yep sorry, it's on the way.
yeah I'm using GLES2, and the mini-project has the same bug

and here is the mini-project with the bug in action

Is this still an outstanding issue in master? I have added a fix to my own fork of 3.2. Tested on:
Chrome Windows
Chrome Android
Safari IOS

Is this still an outstanding issue in master? I have added a fix to my own fork of 3.2. Tested on:
Chrome Windows
Chrome Android
Safari IOS

Is this still an outstanding issue in master?

The master branch currently only has a Vulkan renderer which can't run on HTML5.

Is this still an outstanding issue in master?

The master branch currently only has a Vulkan renderer which can't run on HTML5.

Is this still an outstanding issue in master?

The master branch currently only has a Vulkan renderer which can't run on HTML5.

So is this a candidate for inclusion in 3.2?

Is this still an outstanding issue in master?

The master branch currently only has a Vulkan renderer which can't run on HTML5.

So is this a candidate for inclusion in 3.2?

So is this a candidate for inclusion in 3.2?

Yes, feel free to open a pull request against this repository's 3.2 branch :slightly_smiling_face:

So is this a candidate for inclusion in 3.2?

Yes, feel free to open a pull request against this repository's 3.2 branch :slightly_smiling_face:

Done :)
https://github.com/godotengine/godot/pull/45465

Done :)
https://github.com/godotengine/godot/pull/45465

Fixed by #45465.

Fixed by #45465.


Add support of limited repetitions

Syntax
Meaning

x{n,m}
at least n of x and at most m of x

x{n,}
at least n of x

x{,m}
at most m of x

x{n}
exactly n of x

If n is greater than m an error is triggered.

I will implement this in one of the next major versions, because it is a breaking change.


add output types for hdfsOpenFile and hdfsBuilderConnect

@martindurant this sufficed to solve the segfaults that I was seeing.  I think it would be worthwhile to continue this sort of definition on most relevant functions.


Compose the docker file

This ticket has been moved back to the product backlog after discussing the test suite architecture among the developers.  We believe we can perform the test suite purely in git actions without need for provisioning azure resources/a docker container.  We do still feel the docker implementation is an important tool for testing large datasets on containerized engine in a cloud environment and as a utility that our stakeholders will want to use.


Add tracking of code quality with Codeclimate and replace Coveralls with Codeclimate coverage

This pull requests:

Add tracking of code quality with Codeclimate
replace Coveralls with Codeclimate coverage

since the integration it will be possible to have the following outputs:

it will be easy then fix issues in the code related to not standard/interoperable syntaxes
After integration the codeclimate token should be replaced with a token specific for the dchest/scrypt-async-js to be taken loggin onto https://codeclimate.com/dashboard

Thanks, I'll take a look at it a bit later. Can this "function complexity" and "too many statements" noise be turned off, because this stuff is the result of optimizing the implementation.

Here are links in order to evaluate the capabilities:
https://github.com/evilaliv3/scrypt-async-js/tree/codeclimate
https://codeclimate.com/github/evilaliv3/scrypt-async-js/scrypt-async.js

answering your question yes @dchest , codeclimate allow very easily to configure ignore statements:

Hmm, all of these "issues" look useless to me right now. I'm happy that it runs ESLint, although we can put it into the "build" step instead of calling their APIs.

Yes i agree that nothing critical is here but the great thing of integrating the tracker is that you can enable callbacks on the pull request and spot automagically the various code issues without having to manually run the linter.
In addition is useful to improve the trust of user in the library to show them that all is coded properly.

OK, good arguments.


ApplicationInsightsTraceListener does not respect Flush

When calling Trace.Flush(), some of the last messages may be lost. Per this, TelemetryClient.Flush needs to be called to make sure the last batch is sent.

A similar issue exists in ApplicationInsightsAppender (Log4NetAppender).
ApplicationInsightsAppender doesn't override AppenderSkeleton.Flush(), so calling Flush just hits AppenderSkeleton.Flush().
I haven't experimented with ApplicationInsightsTarget (NLogTarget), but I'd expect the same issue to exist there, since there doesn't appear to be anything calling TelemetryClient.Flush()

I am not familiar with NLog, but I looked for AppenderSkeleton.Flush() before I put in my PR and was unable to find it. The version that is referenced doesn't implement the IFlushable interface in the latest code. To my eye, this seems to be the issue with #68.


oauth2client is archived

The Python code depends on
'oauth2client>=2.0.1,<4.0.0',
which library is archived and likely doesn't work anymore: https://github.com/googleapis/oauth2client
We need to move to google-auth and oauthlib or turn this down.

@kolea2 I've downgraded the priority of this issue as part of the Yoshi FixIt. Please adjust the priority as needed.

We will be turning this down as current development is happening elsewhere. I did confirm that the current client does not have this issue: https://github.com/googleapis/python-datastore/blob/main/setup.py


TASK: Switch to  phpcsstandards/php_codesniffer

squizlabs/php_codesniffer has been abandoned in favor of phpcsstandards/php_codesniffer, see:
https://github.com/squizlabs/PHP_CodeSniffer/issues/3932
also:
https://packagist.org/packages/phpcsstandards/php_codesniffer

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.
Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

Hi @jrfnl,
thanks a lot for reaching out and taking care :)


Update cgp-0071.md

fix typo

Going to close this @tobikuhlmann as it looks like the changes are no longer relevant and the proposal has been merged into main. Please open up if it is still relevant.


[stable/nginx-ingress] Allow to configure source IP preservation on Kubernetes 1.7

Unfortunately, after upgrading Kubernetes to 1.7, I'm no longer able to set service.beta.kubernetes.io/external-traffic.
According to documentation, the annotation is deprecated and the field under service.spec should be used.
This pull request adds two values to controller's service: externalTrafficPolicy and healthCheckNodePort

Probably duplicate of #1542. The only difference is the healthCheckNodePort value.

/ok-to-test

/lgtm


Dose this work with roll-up?

Dose it?

Hello! What do you mean? Can you describe your case in more detail?


Can't See my posts on HomePage

I Can't see my own posts on HomePage!

I'm gonna need more than that

When i post something on voten i cant see my post which are upvoted!

I'll fix it ASAP

fine waiting for the fix!

fixed

Thanks

You're welcome


Modify core ontology to require an identifier for all THINGs.

It seems that we should require an identifier for every THING, rather than the current state where it is optional.  All objects are identified by a SemTK-generated UUID-based URL, which is not very useful without an associated user-presentable identifier.

I'm generally in favor of this, but I can think of ways to ingest things that don't use identifiers using custom nodegroups. It's probably the case that the whole current ingestion package has an identifier for everything. Setting this would help us keep it that way.

This sounds okay to me as well. I added @cuddihyge as a reviewer just to be sure.

Ping @cuddihyge

I concur -- that was exactly the problem I accidentally created when I did TEST_RESULTs, which didn't have obvious identifiers, but then made it unreasonably hard to query out to TEST_STATUS.


(Typescript) Type definition file for satellizer?

As the typescript is getting phenomenal, would it be possible to have a type definition file in place?

I haven't played around with TypeScript much. Not going to get into that at least until Angular 2.0 goes live.


Add to History also when link inside "bookmark" is clicked

It happens very often that when I bookmark a link, I have related or sub-links in the description, instead of bookmarking all of them separately.
When I click one of those sub-links I want the main bookmark to appear in the History tab and soon to be implemented shortcut...

implemented


[WIP] PEP 741: Add PyConfig_Get() and PyConfig_GetInt()

PR created to check if it's possible to implement these functions in pythoncapi-compat for Python 3.13 and older.

It's not possible to fully implement PEP 741 on pythoncapi-compat. I prefer to have no PEP 741 API, rather than a partial support. I close the PR.


Component density does not exactly agree with 3D density

#818 created a test comparing component density to material 3D density, and the differences are larger than expected (but still somewhat small, on the order of 0.001 g/cc).

@onufer   Is this different than #819 ?

@john-science  yes. See the 2 comments in the unit tests i created. i call them out sepeartly


dbtool should not create default admin account

dbtool should not automatically create default admin account. Currently dbtool creates a default admin account, but the new SEGSAdmin tool incorporates this into server setup. Also, as eoS pointed out, it'll be silly to have every server with the same default admin login credentials.
Need to remove this line from dbtool, and add a reminder message to create an admin user using the adduser command.
https://github.com/Segs/Segs/blob/f9cb381410fa5e26b2df668dfc4bf9f564f4766f/Projects/CoX/Utilities/dbtool/main.cpp#L432
As most users will use the SEGSAdmin tool, this issue is low priority for now, but a simple enough fix that I'm marking it good-first-issue

I have updated dbtool in Pull Request #410.


remove the local variable and return the result directly

I found a code smell that  Local Variables should not be declared and then immediately returned or thrown.
Some developers argue that the practice improves code readability, because it enables them to explicitly name what is being returned. However, this variable is an internal implementation detail that is not exposed to the callers of the method. The method name should be sufficient for callers to know exactly what will be returned.
So I remove the local variable and return the personMapper.count(selectStatement); directly to fix the Code Quality Issue detected by SonarQube.
https://rules.sonarsource.com/java/RSPEC-1488

Coverage remained the same at 100.0% when pulling e96a77b225f584027d1091d141e0e674080fd1c6 on xuejiangtao:master into 79513ebda0e9f6404c524a09bb27238b75c79b5d on mybatis:master.

@jeffgbutler hello, I found a code smell that Local Variables should not be declared and then immediately returned or thrown.
Some developers argue that the practice improves code readability, because it enables them to explicitly name what is being returned. However, this variable is an internal implementation detail that is not exposed to the callers of the method. The method name should be sufficient for callers to know exactly what will be returned.
So I remove the local variable and return the personMapper.count(selectStatement); directly to fix the Code Quality Issue detected by SonarQube.
https://rules.sonarsource.com/java/RSPEC-1488

Thanks!

Thanks!

thanks for reviewing and i will do some contributions to improve the Code Quality with fix patch generated by my tool


feat: add Rocket Pool rETH Adapter

Hey @nickdoherty,
Thanks for the adapter, could you make the PR editable by repo authors please? So we can rebase and make some small edits?

Hey @jpsains,
Unfortunately, I don't have the checkbox. Looks like there is an open issue for this on Github.
https://github.com/orgs/community/discussions/5634
The issue lies as our fork lives under an organisation.
Did you just need me to rebase and fix the eslint issues? Or did you need to make additional edits?

Hi @nickdoherty,
No problem, I'll take it from here and get the adapter merged will let you know when it's merged, cheers.

Hey @nickdoherty
https://github.com/consensys-vertical-apps/mmi-defi-adapters/commit/dcc37dc2f7cc708b20de748a53be74543a25c35a rocket-pool adapter has been merged, thanks for your PR.
We also support APR I notice you have it on your UI, how does your UI calculate APR? Can you share the code, please? Cheers :)

Im going to close this PR now since we cheery picked the commit into main 👍

Thank you @jpsains.
Our APR calculation requires the use of an Archive Node & some event queries.
We have an API for the value available at https://api.rocketpool.net/mainnet/reth/apr however in the adapter documentation it stated that API calls were frowned upon, so we didn't include it.
Would a simple API call be allowed?


Add an SVG parsing tool

Also, how do you decide whether to log a warning or an error with success = False?

You can find commits implementing bullets 1 and 2 in my branch: https://github.com/Hjdskes/libratbag/commits/whot-wip/svg-parsing-tool. I've also fixed the G502 with a style property, and made a missing leader an error instead.
That leaves bullet 3, which admittedly isn't that important because Piper will still function without it. I also noticed that the script outputs errors for the roccat-kone-xtd's wheel tilt buttons, because they're missing their leaders.

, how do you decide whether to log a warning or an error

something that looks wrong but where we can't be sure is a warning. something that's definitely wrong is an error.

A missing leader should be an error because without it

how are we doing this for the wheel tilt buttons?

@Hjdskes I merged your patches and addressed the comments I had regarding the 502. This won't pass the check suite, we need to figure out what we do for the leader lines on wheel tilt buttons

how are we doing this for the wheel tilt buttons?

Wheel tilt buttons require these elements just as any other button does. I've force pushed to my branch (78f72c4a5298ccb9686bda36fe70f540b639f745), making sure not to include detritus this time (though there are some thing I'm not sure are required, feel free to remove those if they aren't) and putting it before the commit that introduces the script.

@Hjdskes  thanks, cherry-picked from your branch, reshuffled a few things. ended up squashing all the commits regarding the check-svg.py into one - no need to have more than one here.


Load spinner main

Adds a loading spinner to the main route (home screen) as lists are loaded from the database.
Implemented using a Future Builder
Loading spinner appears on initial load and when a new list is created, causing the list of lists needs reloaded.

Closed in favor of #19


Update Docs for i18n

This change is

Coverage remained the same at 99.33% when pulling 69bc1c9404a3d84ff05ef302fa8fdfa240494f5b on justin808-doc-updates into c2947686317b7be8722ccb844c8d35bb48a18469 on master.

Coverage remained the same at 99.33% when pulling 69bc1c9404a3d84ff05ef302fa8fdfa240494f5b on justin808-doc-updates into c2947686317b7be8722ccb844c8d35bb48a18469 on master.

Coverage remained the same at 99.33% when pulling 69bc1c9404a3d84ff05ef302fa8fdfa240494f5b on justin808-doc-updates into c2947686317b7be8722ccb844c8d35bb48a18469 on master.

@JasonYCHuang Please review!

Coverage remained the same at 99.33% when pulling 737468d0d3fa8e6c9a69144ed866a096750b9642 on justin808-doc-updates into c2947686317b7be8722ccb844c8d35bb48a18469 on master.


Sdk automation branch cleanup

It's not good to add specific logic to  branch-cleanup.yml to cleanup branches created by sdk automation pipeline. So, I create a new tool to cleanup the branches.
The logic to cleanup branches in this tool is:

Get all open PRs in sdk repo.
Check whether each sdk PR meets the following requirements:
a. PR's creator is azure-sdk.
b. PR's source branch name is prefixed with sdkAuto.
c. The corresponding swagger PR is merged/closed.
Close the sdk PR and delete the source branch if it meets all conditions.

As best I can tell your update only does one extra layer of clean-up above what branch-cleanup.yml does today which is check to see if a Swagger PR that created this PR has been closed and if so it will close the language PR and then it will also delete the branch.
This exact scenario is something that we need for our eng/common sync PR clean-up as well. Can you please work with @sima-zhu to try and consolidate this functionality in a more generic way so we can share it with the existing branch-cleanup.yml and only have one pipeline that is cleaning up branches and old PRs.

@dw511214992 The criteria is clear to me. Can I learn why the sdk PR cannot close/merge automatically after swagger PR merged? How do we merge the swagger PR currently, manually or through pipeline?

@sima-zhu the swagger PR is closed manually when things get merged. Today there isn't a good place to close the PR's we create.
Thinking about this a little more I think we could extend our existing clean-up to do the following:

Find all branches matching a particular regex pattern.
If that branch name pattern as a group called "prnumber" (i.e. sync-eng/common-.*-(<prnumber>\d+)
We can use that prnumber and plug it into a template like https://github.com/Azure/azure-sdk-tools/pull/$prnumber or specs PR in the case of swagger.
Once you find the PR you can check the status of that related PR (i.e. closed, merged, open, etc) to decide whether or not to delete the branch and any associated PRs in the language repos.

close it because it's handled in #3342


Result problem

Sorry to bother you, I can't use your pretrained model GoPro.pth to get the same result as you in the Gopro dataset. Since this paper is accepted by cvpr23, this problem should be taken seriously.

Did you use the same test script I provided？（merge_full.py and calculate_psnr.py）
---- Replied Message ----
| From | @.> |
| Date | 09/30/2023 16:42 |
| To | @.> |
| Cc | @.***> |
| Subject | [xuboming8/DSTNet] Result problem (Issue #4) |
Sorry to bother you, I can't use your pretrained model GoPro.pth to get the same result as you in the Gopro dataset. Since this paper is accepted by cvpr23, this problem should be taken seriously.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Yes, I only change the dataset path and change the GoPro dataset structure as your demand.

Did you use the same test script I provided？（merge_full.py and calculate_psnr.py）
…
---- Replied Message ---- | From | @.> | | Date | 09/30/2023 16:42 | | To | @.> | | Cc | @.> | | Subject | [xuboming8/DSTNet] Result problem (Issue #4) | Sorry to bother you, I can't use your pretrained model GoPro.pth to get the same result as you in the Gopro dataset. Since this paper is accepted by cvpr23, this problem should be taken seriously. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>

Can you provide more details about your testing process? The model GOPRO_large is correspond to test_deblur_GOPROL.Did you change the parameters in merge_full.py correctly?
---- Replied Message ----
| From | @.> |
| Date | 09/30/2023 18:41 |
| To | @.> |
| Cc |<EMAIL_ADDRESS>|
| Subject | Re: [xuboming8/DSTNet] Result problem (Issue #4) |
Yes, I only change the dataset path and change the GoPro dataset structure as your demand.
Did you use the same test script I provided？（merge_full.py and calculate_psnr.py）
…
---- Replied Message ---- | From | @.> | | Date | 09/30/2023 16:42 | | To | @.> | | Cc | @.> | | Subject | [xuboming8/DSTNet] Result problem (Issue #4) | Sorry to bother you, I can't use your pretrained model GoPro.pth to get the same result as you in the Gopro dataset. Since this paper is accepted by cvpr23, this problem should be taken seriously. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Sorry to bother you, when I prepare the dataset, I accidentally changed the order of the frames.I have resolved this problem. Thank you.

Can you provide more details about your testing process? The model GOPRO_large is correspond to test_deblur_GOPROL.Did you change the parameters in merge_full.py correctly?
…
---- Replied Message ---- | From | @.> | | Date | 09/30/2023 18:41 | | To | @.> | | Cc |<EMAIL_ADDRESS>| | Subject | Re: [xuboming8/DSTNet] Result problem (Issue #4) | Yes, I only change the dataset path and change the GoPro dataset structure as your demand. Did you use the same test script I provided？（merge_full.py and calculate_psnr.py） … ---- Replied Message ---- | From | @.> | | Date | 09/30/2023 16:42 | | To | @.> | | Cc | @.> | | Subject | [xuboming8/DSTNet] Result problem (Issue #4) | Sorry to bother you, I can't use your pretrained model GoPro.pth to get the same result as you in the Gopro dataset. Since this paper is accepted by cvpr23, this problem should be taken seriously. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.> — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>


Request: add Earth/Stone as default terrain type

In D&D 5e, the Earth Genasi has the following feature:
Earth Walk: You can move across difficult terrain made of earth or stone without expending extra movement.

I wonder what's the best approach to implement this in Enhanced Terrain Layer? Maybe an extra default environment or obstacle type for "Rock/Stone" would work well?
There already is a "mountain" environment but rocks on the ground, caves, etc. are not really mountains.

I would just use Rubble for that.  Rubble is essentially rocks on the ground.
I'd thought about having a default environment, but there's just too many systems and worlds out there that have their own way of doing things to be able to have a decent "default".  Leaving it as a generic difficult terrain is probably best, with the option for the GMs to get more specific.


Issue from website page Get Started: Install on Windows

From URL: https://flutter.io/setup-windows/
There seems to be NO WAY to develop for iOS on my Windows machine. Am I right?
Is there anything Google/Flutter can do?
This seems to me to be an unfair advantage for Apple.
Thanks.
Love and peace,
Joe Dorocak

You need xcode to run your flutter app on a iOS device.
To install xcode you will need a mac.

@development-s365 is correct.
See also this comment https://github.com/flutter/flutter/issues/17471#issuecomment-388171536


updated how created and last modified fields are set

Codecov Report

Merging #22 (275082d) into main (8968428) will decrease coverage by 3.23%.
The diff coverage is 62.82%.

@@             Coverage Diff              @@
##               main      #22      +/-   ##
============================================
- Coverage     85.55%   82.31%   -3.24%
- Complexity      106      109       +3
============================================
  Files            30       35       +5
  Lines           443      458      +15
  Branches         19       20       +1
============================================
- Hits            379      377       -2
- Misses           53       68      +15
- Partials         11       13       +2

Impacted Files
Coverage Δ

...uk/gov/justice/digital/hmpps/config/FeignConfig.kt
76.92% <ø> (ø)

...ps/integrations/delius/audit/AuditedInteraction.kt
0.00% <0.00%> (ø)

...s/integrations/delius/audit/BusinessInteraction.kt
0.00% <0.00%> (ø)

...ce/digital/hmpps/integrations/delius/audit/User.kt
100.00% <ø> (ø)

...delius/audit/AuditedInteractionOutcomeConverter.kt
18.18% <18.18%> (ø)

.../digital/hmpps/config/security/ServicePrincipal.kt
80.00% <80.00%> (ø)

.../integrations/delius/audit/service/AuditorAware.kt
83.33% <83.33%> (ø)

...integrations/delius/audit/config/AuditingConfig.kt
100.00% <100.00%> (ø)

...gital/hmpps/integrations/delius/entity/CaseNote.kt
74.62% <100.00%> (+4.47%)
:arrow_up:

.../digital/hmpps/integrations/delius/entity/Staff.kt
100.00% <100.00%> (+7.40%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8968428...275082d. Read the comment docs.


Prop for inline styling of slide component

Hello, and thanks for the awesome component you have made!
We would need to be able to style the slide component, so I made a modification to the source which allows user to pass inline styles for the slide as props.
BR,
Ville Miekk-oja

@VilleMiekkoja Thanks for opening this PR :+1:.

@VilleMiekkoja Thanks!

No problem, thanks for you!
BR,
Ville
perjantai 4. maaliskuuta 2016 Olivier Tassinari<EMAIL_ADDRESS>kirjoitti:

@VilleMiekkoja https://github.com/VilleMiekkoja Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/oliviertassinari/react-swipeable-views/pull/39#issuecomment-192400282
.


Push version 0.1.0 to npm

I blindly followed the README and ran tests to get:
  48) ParseMock when object has beforeSave hook registered rejects the save if there is a problem:
     Error: You need to call Parse.initialize before using Parse.
      at Context.<anonymous> (test.js:828:13)

Only then did I realise npm_modules contained 0.0.3 and not the latest 0.1.0.

Yup, waiting to deploy 0.1.0, need to get package transferred to me. Hold tight.

It's deployed, do you want to give it a whirl?

Remember to run npm update parse-mockdb as well as ensure you are using version 1.6.0 or higher of the Parse JS SDK.

Nice one :beers:
Trying to run example test file ... updating node...


Remove Netif name and rely on enumerated Interface Id's for netif.

A defined Netif Interface ID enumeration has been added to openthread-types.h, allowing code both inside and out of OpenThread to specify well known InterfaceId values, such as within a otMessageInfo struct.
The Name member and associated API's, has been removed from the netif. This feature was not used and is no longer necessary now that all allowable Interface ID's are exposed in openthread-types.h

someone needs to explain to me why when I run make pretty at my desk it changes topology.hpp. But when travis runs make pretty it fails at topology.hpp?

@pvanhorn, not sure why you are seeing different results.  What version of astyle do you have?
FWIW, I tried make pretty locally and see the same behavior as Travis.
My version:
$ astyle --version
Artistic Style Version 2.05.1

Current coverage is 73.86% (diff: 83.33%)

Merging #833 into master will increase coverage by 0.54%

@@             master       #833   diff @@
==========================================
  Files           109        109
  Lines         16306      16297     -9
  Methods        2219       2216     -3
  Messages          0          0
  Branches       1953       1950     -3
==========================================
+ Hits          11956      12038    +82
+ Misses         3706       3611    -95
- Partials        644        648     +4

Powered by Codecov. Last update 117ecaf...d26b129


Add kuttl test case deploying galera

Add a kuttl test case deploying galera and checking that all the
resources are created and deleted, and the deployment can be scaled
down.

/retest

/test mariadb-operator-build-deploy-kuttl

/test mariadb-operator-build-deploy-kuttl

/test mariadb-operator-build-deploy-kuttl

/lgtm

@dciabrin thanks for the review. It seems that tide requires either the /approve label or approving the PR through the github interface to merge, could you do that?

/approve


gegl: 0.4.44 → 0.4.46

Description of changes
Waiting on upstream: https://gitlab.gnome.org/GNOME/gegl/-/merge_requests/136
https://gitlab.gnome.org/GNOME/gegl/-/compare/GEGL_0_4_44...GEGL_0_4_46

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

https://gitlab.gnome.org/GNOME/gegl/-/merge_requests/136 was merged.


Fix lsass finder

Hello again,
Sorry I've forgot a byref in the NtQuerySystemInformation. Thats why it wasn't working on 32 bit.
I've tested the code on 32 bit and 64 bit and added a method in case the main one failed (QueryFullProcessImageNameW).
Do pypykatz supposed to support older systems XP/2000 ?
Let me know if you have any comment.
Thank you for your work.

Win 7 32 bit CloseHandle raises exception "Handle invalid". I checked and CloseHandle receives the handle value correctly so I'm not sure why it gives that error. Will do further checks on that.
Commenting out CloseHandle "solves" the issue but there must be a better way.
pypykatz live parsing is not supported on winxp and 2000 because python3 is not supported on those platforms.

Win 7 32 bit CloseHandle raises exception "Handle invalid". I checked and CloseHandle receives the handle value correctly so I'm not sure why it gives that error. Will do further checks on that.
Commenting out CloseHandle "solves" the issue but there must be a better way.
pypykatz live parsing is not supported on winxp and 2000 because python3 is not supported on those platforms.


[CARBONDATA-1686]  Presto Version Upgrade to  0.186

[No] Any interfaces changed?

[Yes ] Any backward compatibility impacted?  Carbondata will now work with Presto Server 0.186 onward

[ No] Document update required?

[ Yes] Testing done
Since it is a version upgrade  all the integration test cases are executed successfuly.
Performance testing done manually and there is improvement in query execution times.

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/917/

@bhavya411 please rework this PR, there are many issues.

All issues have been resolved

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/928/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1532/

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/936/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1543/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1551/

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/943/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1558/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/956/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1571/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/964/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1580/


[SPARK-48566][PYTHON] Fix bug where partition indices are incorrect when UDTF analyze() uses both select and partitionColumns

What changes were proposed in this pull request?
This PR fixes a bug that resulted in an internal error with some combination of the Python UDTF "select" and "partitionBy" options of the "analyze" method.
Specifically, this logic in Analyzer.scala was wrong because it did not update the usage of partitioningExpressionIndexes to take the "select" expressions into account when they were introduced in https://github.com/apache/spark/pull/45007:
val tvfWithTableColumnIndexes = tvf match {
  case g @ Generate(pyudtf: PythonUDTF, _, _, _, _, _)
      if tableArgs.head._1.partitioningExpressionIndexes.nonEmpty =>
    //////////////////////////////////////////////////////////////////////////////
    // The bug is here: the 'partitioningExpressionIndexes' are not valid
    // if the UDTF "select" expressions are non-empty, since that prompts
    // us to add a new projection (of a possibly different number of
    // expressions) to evaluate them.
    //////////////////////////////////////////////////////////////////////////////
    val partitionColumnIndexes =
      PythonUDTFPartitionColumnIndexes(tableArgs.head._1.partitioningExpressionIndexes)
    g.copy(generator = pyudtf.copy(
      pythonUDTFPartitionColumnIndexes = Some(partitionColumnIndexes)))
  case _ => tvf
}

To reproduce:
from pyspark.sql.functions import (
    AnalyzeArgument,
    AnalyzeResult,
    PartitioningColumn,
    SelectedColumn,
    udtf
)

from pyspark.sql.types import (
    DoubleType,
    StringType,
    StructType,
)

@udtf
class TestTvf:
    @staticmethod
    def analyze(observed: AnalyzeArgument) -> AnalyzeResult:
        out_schema = StructType()
        out_schema.add("partition_col", StringType())
        out_schema.add("double_col", DoubleType())

        return AnalyzeResult(
            schema=out_schema,
            partitionBy=[PartitioningColumn("partition_col")],
            select=[
                SelectedColumn("partition_col"),
                SelectedColumn("double_col"),
            ],
        )

    def eval(self, *args, **kwargs):
        pass

    def terminate(self):
        for _ in range(10):
            yield {
                "partition_col": None,
                "double_col": 1.0,
            }

spark.udtf.register("serialize_test", TestTvf)

# Fails
(
    spark
    .sql(
        """
        SELECT * FROM serialize_test(
            TABLE(
                SELECT
                    5 AS unused_col,
                    'hi' AS partition_col,
                    1.0 AS double_col

                UNION ALL

                SELECT
                    4 AS unused_col,
                    'hi' AS partition_col,
                    1.0 AS double_col
            )
        )
        """
    )
    .toPandas()
)

Why are the changes needed?
The above query returned internal errors before, but works now.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Additional golden file coverage
Was this patch authored or co-authored using generative AI tooling?
Some light GitHub copilot usage

👍 @ueshin I updated the PR description to clarify the exact bug fix more. All CI tests are passing, please feel free to merge at your convenience :)

Thanks! merging to master.


LUIS SDK azure vs container implementation

Is your feature request related to a problem? Please describe.
When using the container version, you need to access web service. SDK Abstraction don't work as sdk URLs differ in webservice endpoints...
https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/424#issuecomment-568755331
The problem here is that prediction results are not the same...
Exemple in code :
Task pred;
            if (_config.UseLocalServices)
            {
                pred = GetPredictionFromEndpointAsync(_config.LuisAPIKey, _config.LuisContainerUrl, _config.LuisAppId, _config.LuisSlotName, question.ToLowerInvariant());
            }
            else
            {
                IList<DynamicList> dynamicLists = _luisFeedDynamicListService.LuisEntries.Select(e => new DynamicList(e.Key, RequestListExtensions.FromLuisEntries(e.Value))).ToList();
                var predictionRequest = new PredictionRequest(question.ToLowerInvariant(), null, null, dynamicLists);

                pred = _luisClient.Prediction.GetSlotPredictionAsync(
                   Guid.Parse(_config.LuisAppId),
                   slotName: _config.LuisSlotName,
                   predictionRequest,
                   verbose: true,
                   showAllIntents: true,
                   log: true);
            }

Describe the solution you'd like
The proper solution would be to change only the enpoint like this:
Version Azure
_luisClient = new LUISRuntimeClient(new ApiKeyServiceClientCredentials(_config.LuisAPIKey))
{
Endpoint = _config.LuisHostRegion
};
Version container
_luisClient = new LUISRuntimeClient(new MockCredentials())
{
Endpoint = "http://localhost:5010"
};
How can you have exactly the same result from webservice ?

@cedrox - Did you turn off negative sampling?


Can get  from React Router styled anymore [v1.0.0]

In v0.57, this worked:
render() {
    const { label, to } = this.props;
    return (
      <div className="ButtonLink">
        <Link className="ButtonLink-link" to={to} onClick={this.onClickLink}>
          {label}
        </Link>
        <style jsx>{`
          [some other rules]
          .ButtonLink-link {
            border: .25rem solid ${colors.shadowWhite};
            color: ${colors.white};
            display: inline-block;
            height: 100%;
            line-height: 2rem;
            padding: .5rem;
            text-decoration: none;
            transition: border-color .1s .4s, background-color .4s;
            width: 100%;
          }
        `}</style>
      </div>
    );
  }

I updated to v1.0.0 and it doesn't work anymore.
In this case, a generated by React Routed get the className OK, but they never get the styles applied.
I think this is because (and extract of what it's inyected in <style>, at the page:
.ButtonLink[data-jsx="1324817230"]{rules rules}.ButtonLink-link[data-jsx="1324817230"]{rules rules}

And, in the HTML, the data-jsx is only setted to ButtonLink element, not to the a tag.
So, it get's it never applied.
I also tried with .ButtonLink > .ButtonLink-link. Same result, it only sets the data-jsx to ButtonLink and in injects something like:
.ButtonLink[data-jsx="1368184654"]{rules rules}.ButtonLink[data-jsx="1368184654"]>.ButtonLink-link[data-jsx="1368184654"]{rules rules}

and, like ButtonLink-link never gets the attribute data-jsx, the styles are never applied.
And, mention appart, previously to tried this (before to migrate to v1.0.0), I had .ButtonLink-link as .ButtonLink > a. And it was working just fine. I just changed it and added a className to Link and all that just to try if that way it worked (previously to checked what it was injecting.
I'm not so sure if this is a stylis issue or a styled-jsx, so I prefered to put it here (already put another issue in stylis, so, balancing the charge :þ).

As far as I can tell this behavior is "correct" because we don't add the data attribute to components (in your case Link). What you are trying to do shouldn't work in 0.5.7 either.
The following should work:
.ButtonLink > :global(.ButtonLink-link) { ... }

In the future something like #209 should make it possible to avoid the global selector for cases like yours.

Thanks, @giuseppeg. Well, it was working in 0.5.7, so it got me puzzled.
What you proposes works fine, so: problem solved. But, Ideally, yes, #209 would be great :). I will be watching that issue ^^.
Thanks for your help 👍.


Dropwizard application 0.9 memory usage?

How to find the memory usage?
how much memory does dropwizard consume usually?

@snehaldkshah You can use the standard JVM (such as jstat or VisualVM) or operating system utilities to print the memory consumption of a Dropwizard application.


Distinguish between prepared and unprepared cantrips on the core sheet

Originally in GitLab by @Pjb518
Tasha's Cauldron of Everything introduced a new wizard feature called Cantrip Formulas. This feature allows wizards to change their known cantrips on a day by day basis.
It would be convenient for players to be able to leave all of their frequently chosen cantrips on their sheet, but there's currently no way to indicate which of these are prepared on a given day.
Now that this degree of cantrip preparation versatility exists in the game, I think we should support a visual indication of cantrip preparation on the core sheet. This feature already exists on 3rd party sheets, such as Tidy.

yes, this would be super convenient!
Especially for some 3rd party games where you have a number of cantrip live abilities that can be toggled on/off (Arcanis 5e Psion).


Implement initial shopping cart system

Should be ready for functionality testing.
Left to do:
Review responsive design for small viewports and modify UI accordingly.

Initial shopping cart main feature set:
Shopping cart icon in header that will open the cart in a modal
Shopping cart icon on NFT page and NFT cards on collection/nfts page with logic implemented to only display the icon for adding NFTs to cart if it passes same checks that allow the buy button to be visible on the NFT page.
Notifications for when NFTs are added to cart, removed from cart or is blocked due to NFT already being present in the cart.
Shopping cart to have the follow info per NFT added to cart: Image, Collection Name (linkable to collection page), NFT Name (linkable to NFT page), Royalties %, available for sale status, quantity / quantity available to add, [price] [token] per NFT and a remove icon.
When cart loads, it will grab fresh Collection/NFT to display most up to date information and track if availability for sale of each cart NFT has changed or not.
For NFTs that have more than 1 available for purchase (SFTs and Generated+Unowned etc.) have an input where quantity can be typed in or increased/decremented via up/down arrows.
Checkout button that will launch an overlay with the cart checkout screen.
Checkout screen will group each NFT from cart by network/token symbol since bulk order API requires a single network per call.
NFTs in each group will display the following information: NFT Name (linkable to NFT page), Collection Name (linkable to Collection page), quantity, price per NFT, line item total showing price * quantity, a total row with sum of quantities and total price for all NFTs and quantities.
If there are NFTs in cart that have become unavailable for sale, when checkout overlay loads it will warn the user that X number of NFTs were not included in the checkout review due to no longer being available for sale.
Radio selector to choose which group of NFTs to purchase.
Checkbox to agree to Terms and Conditions prior to Confirm and Lock button press which will generate the bulk buy transaction.
Same process for purchase as single NFT buys with exception of button to "Show My NFT" upon purchase completion.
"Sweep to Cart" button on collection/nft pages that will have a slider and a "Sweep to Cart" button. Upon slider select and button press, the collection NFTs available for sale will be sorted by price low to high and the top X NFTs added to the cart.


Multiline ENV vars not working when using Dotenv with Foreman

I've recently encountered a problem when using Foreman in conjunction with Dotenv on a Rails project. I've got a ENV file with a multiline string like so:
MULTILINE_ENV_VAR="
Here is
a multiline
env var
"

When I spin up the application as normal (i.e. bundle exec rails s) the env var works as expected, however, if I add the command to a Procfile like so:
web: bundle exec rails s

And run foreman start, the ENV var gets munged. I've created an example Rails project here to demonstrate the error. Here's some screenshots too:
With rails s

With foreman start

I'm not sure if this is a bug with Dotenv or Foreman, but thought it best to try here first.

Any update on a possible fix for this issue?


Add option to define path of cilium-envoy.log and add log rotation to the log file

It's currently being placed under {state-dir}/cilium-envoy.log. We should be able to change this

Right, with debug logging the volume hosting the state dir can fill up fast.

log rotation has already been merged as part of Issue #3034

This can be closed when @jrajahalme merges #2990


UX [Submit challenge entry page]: Design / implement basic page layout using material UI components

This will be complete when the PR is approved after David reviews it. I'll leave it to you to merge it to develop.

@bernardbaker Wow awesome work! I actually did not see this page until I scrolled to the end of the FE README and found this link:
http://localhost:3000/challenge-submission/0044703947287/789632
FY localhost:3000 is showing attached:
https://ibb.co/nLT8vN9
https://ibb.co/qyWnGzc
Am I doing something wrong?

No,
That was all the text copy made available to me in previously.
I guess you have to decide what copy you want on the landing page.
I had a few suggestions about navigating and presenting the copy.
On Tue, 7 Apr 2020, 17:19 un7c0rn<EMAIL_ADDRESS>wrote:

@bernardbaker https://github.com/bernardbaker Wow awesome work! I
actually did not see this page until I scrolled to the end of the FE README
and found this link:
http://localhost:3000/challenge-submission/0044703947287/789632
FY localhost:3000 is showing attached:
https://ibb.co/nLT8vN9
https://ibb.co/qyWnGzc
Am I doing something wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/issues/14#issuecomment-610483429,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTAKTETDVM7YB72JOPDRLNG7VANCNFSM4MDHGE3Q
.

Right I understand the copy is temporary and we'll update per tasks (17) and (18) but the part I'm a little less clear on is the delta between these screenshots vs. the virus-fe branch which looks like this:
https://ibb.co/Vv4MF9t
And the navigation links work. Please let me know your thoughts on navigating and presenting copy!

The landing page work was done before the David did his work.
But it depended on the React spa structure.
So it wasn't pushed.
Those links represent routes which have been created.
But in the wireframes I don't see a screen with all those links.
Re' navigating and presenting copy. I thought an expandable menu could be
used.
Or centered topic text which is swipeable.
There is a lot to convey, with the exception of rules which I needs to be
an indexable web page. And has a button which links to it.
On Tue, 7 Apr 2020, 17:33 un7c0rn<EMAIL_ADDRESS>wrote:

Right I understand the copy is temporary and we'll update per tasks (17)
and (18) but the part I'm a little less clear on is the delta between these
screenshots vs. the virus-fe branch which looks like this:
https://ibb.co/Vv4MF9t
And the navigation links work. Please let me know your thoughts on
navigating and presenting copy!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/issues/14#issuecomment-610491150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTG4IW4Z4BZ5RT6JOBLRLNIWDANCNFSM4MDHGE3Q
.

@bernardbaker Agree and centered topic text which is swipeable sounds perfect. We don't have official copy yet but it should be relatively brief and fit within a small number of swipeable views.

Ok great.
There's a react native swipeable npm library that I've used in the past
which might be useful.
But we want a web version.
On Tue, 7 Apr 2020, 17:52 un7c0rn<EMAIL_ADDRESS>wrote:

@bernardbaker https://github.com/bernardbaker Agree and centered topic
text which is swipeable sounds perfect. We don't have official copy yet but
it should be relatively brief and fit within a small number of swipeable
views.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/issues/14#issuecomment-610501155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTGXAEYAYXUBWFVCOXTRLNK6LANCNFSM4MDHGE3Q
.

Marking this as done. I think next steps will require design assets and backend endpoint.

Great! Do we have a UI designer?
I know a good one that I've worked with before. I can reach out to her.
On Sat, 11 Apr 2020, 18:36 un7c0rn<EMAIL_ADDRESS>wrote:

Closed #14 https://github.com/un7c0rn/stopthevirus/issues/14.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/un7c0rn/stopthevirus/issues/14#event-3224300790, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHNTTCMPEKLDDI7AFEDEVLRMCTAZANCNFSM4MDHGE3Q
.


Adding .NetStandard2.0 + Bump up version

Thank you very much for the pull request. I've merged it in. The new verison will also be on NuGet in the next hour so so.


Unable to login into mega

I also have login problems

rclone v1.47.0
os/arch: linux/amd64 (debian)
go version: go1.12.4

rclone lsd HOST: --mega-debug -vv
2019/05/02 17:23:52 DEBUG : rclone: Version "v1.47.0" starting with parameters ["rclone" "lsd" "HOST:" "--mega-debug" "-vv"]
2019/05/02 17:23:52 DEBUG : Using config file from "/home/USER/.config/rclone/rclone.conf"
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 1/10: Try again
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 2/10: Try again
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 3/10: Try again
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 4/10: Try again
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 5/10: Try again
2019/05/02 17:23:52 DEBUG : go-mega: Retry API request 6/10: Try again
2019/05/02 17:23:53 DEBUG : go-mega: Retry API request 7/10: Try again
2019/05/02 17:23:53 DEBUG : go-mega: Retry API request 8/10: Try again
2019/05/02 17:23:55 DEBUG : go-mega: Retry API request 9/10: Try again
2019/05/02 17:23:57 DEBUG : go-mega: Retry API request 10/10: Try again
2019/05/02 17:24:02 Failed to create file system for "HOST:": couldn't login: Try again
Normal login via the client works fine. Also on the website.
Any idea?

do you have 2fa enabled ?

No, I didn't. :)

There is some issue with rclone/mega logins.
Further information
https://forum.rclone.org/t/failed-to-create-file-system-for-remote-folder-couldnt-login-try-again/9501/3
No such issues with megatools nor megacmd nor web interface. (while megacmd has needed up to three minutes to connect to challenging remotes...).
I personally believe that sometimes a mega remote gets some non expected (by rclone) answer or that some kind of throthigling is done by mega.... I believe that rclone modus operandi makes too many login/logouts in small time, then probably triggers some pacing.
I have a remote that can list its contents, then I cannot get the full list of public links because it stops login... until a week later....

Today my wild mega remote behaved... I did a pause of 3 seconds after each logoff... (so, after each rclone command).
I cannot promise it is just a random fact or that there is correlation of both facts...
@Anagastes :
Wait a week, then try to login...
CT

I've tested it again after a week. Now it seems to work as usual again.
I will open it again if it appears again. Thanks for the help! :)

for reference
https://github.com/ncw/rclone/commit/cff85f0b9551881be535a4847b56742451e6b476


New card idea

I think it would also be good to provide a greyscale map and one of the nine regions of England or the other constituent countries, and your task is to name the counties and imagine the border. Then on the back you're told the counties and they get highlighted. This would be a fairly hard set of cards, but, I think, would be necessary to tie everything together.

I do like this idea, but as Scotland has 32 "counties" (actually council areas) this wouldn't really be feasible for Scotland.
Potential solutions would be:

to break up Scotland into smaller regions, but I like the consistency of using the NUTS1 regions throughout, otherwise it feels a little arbitrary.

To omit Scotland from this type of card completely. Again, I like the consistency and also I wouldn't want anyone to feel left out ;)

If you have any other suggestions/potential solutions I'd be happy to hear them, I think I'll hold off on this idea for this release though.


What's Next For CSS?

What’s next for CSS?
cssdb is a comprehensive list of CSS features and their positions in the process of becoming implemented web standards:
https://cssdb.org/
It seems to be consistently maintained over time by @jonathantneal for years

Indeed a great one!
My intent with Can We was to propose websites based on browsers usage data, but maybe it could be widened to other resources answering the “can we?” question. 🤔
(Maybe I’m biased because I’m a postcss-preset-env fan, but I’ll seriously consider this.)

Hi @Martin-Pitt!
Here’s a preview of Can We with #2 and #5 added in a separate category maybe.canwe.dev.
I’d like to have your opinion before merging: do you think it’s acceptable and clear enough?

Hmm, seems a bit at odd with whocanuse which doesn't use browser usage data at all, but the other two do?

There’s indeed something messy in the current classification. It’s more like:

some websites have data about how many people may be concerned (Can I Use, Can I Stop, Who Can Use)
others are strictly about features and don’t have any data.

But at the end, all of them help to shape answers to the many “can we” questions developers have.
Maybe they don’t need to be classified, or at least not that way but I don’t know how. 🕳


Make run tests use cached bundle

Coverage remained the same at 79.403% when pulling 9ff688b5fd52bb73032b3f27b4cd99f31ed99656 on jodh-intel:make-run-tests-use-cached-bundle into<PHONE_NUMBER>7d71c1964048dec5e40c47592ef7cf on clearcontainers:master.

lgtm


Submitting an expense requires you to attach file twice

Repro steps:

visit http://www.opencollective.com/opencollective/expenses/new.
Try to attach a pdf (it may happen with other types too)
Dialog selects the file, disappears and then comes back instantly and you have to select again.

Fix here: https://github.com/OpenCollective/opencollective-website/pull/260

Still happening in production. Reopening.

fixed again


[FEATURE] RapiDoc Integration

There's another OpenAPI web viewer: RapiDoc. It has a nice interface (like redoc) and support for using the API (like swagger).
Apparently, it supports uploading an array of files. Swagger has a bug that prevents this (https://github.com/swagger-api/swagger-ui/issues/4600).
It would be nice to also have RapiDoc integration, maybe at /rapidoc?

It might be nice at some point to make doc renderers configurable in a less kitchen sink fashion, since bundling RapiDoc, SwaggerUI, ReDoc, Stoplight and all the others alongside FastAPI (when most people tend to pick and use just one anyway) could end up turning into a source of avoidable bloat eventually.

I agree with @sm-Fifteen that a more configurable/pluggable system might be good for OpenAPI interfaces.
In the meantime though, you can of course add any interface you'd like on your own, and it's quite easy!  This is how you'd do it for RapiDoc:
from fastapi import APIRouter, FastAPI
from fastapi.responses import HTMLResponse

app = FastAPI()
router = APIRouter()

@router.get("/rapidoc", response_class=HTMLResponse, include_in_schema=False)
async def rapidoc():
    return f"""
        <!doctype html>
        <html>
            <head>
                <meta charset="utf-8">
                <script
                    type="module"
                    src="https://unpkg.com/rapidoc/dist/rapidoc-min.js"
                ></script>
            </head>
            <body>
                <rapi-doc spec-url="{app.openapi_url}"></rapi-doc>
            </body>
        </html>
    """

app.include_router(router)

Thanks for the help here everyone! :clap:
Yep, what @sm-Fifteen and @acnebs said.
You could create an issue in that repo requesting an example of how to integrate it with FastAPI. For example with @acnebs example.
Also, if they add the fastapi topic, it will automatically show up in the "External Links" section in the docs.

I'd like to work on this issue :)
I guess I need to:

add RapiDoc integration
update docs:

add it to the features page, together with Swagger/ReDoc
add screenshots where there are Swagger/ReDoc ones.

request fastapi topic in RapiDoc repo
request rapidoc topic in fastapi repo

Should the question of the configurability of the renderers be in another issue?

Thanks @heitorPB for your interest!
But actually, I would prefer not to have it by default in FastAPI among the others.

About configurability, I'm not really sure it would be worth it, as it would mean taking configurations for:

Extra docs URL
HTML for that config, or a function that provides that HTML
I can imagine others wanting to pass configurations for that HTML, like custom JS or CSS files

And then that would have to allow multiple of those things, so it would have to be a dict of dicts, or a list of some additional custom object, etc.
What I see is that it would probably end up being an involved extra configuration setup that would be more or less complex to understand and use, and wouldn't provide a huge benefit compared to just adding a new docs interface by hand, explicitly.
And as @acnebs shows above, it's quite simple to do it explicitly and doesn't impose any restrictions that a new set of configs would have to impose.


Wrong typecript namespaces with class composition

Hello,
I am trying to use class composition like this:
namespace NAOTConsoleGreet {
    [JSExport]
    public class MainEntry {
        public HumanGreet Human { get; set; } = new HumanGreet();
        public DuckGreet Duck { get; set; } = new DuckGreet();
    }
    [JSExport]
    public class HumanGreet {
        public string Greeting { get; set; } = "Hello from human!";
} }
namespace AnimalGreetings {
    [JSExport]
    public class DuckGreet {
        public string Greeting { get; set; } = "Quack!";
} }

but it generates this d.ts:
export class DuckGreet {
	constructor();
	greeting: string;
}
export class MainEntry {
	constructor();
	human: NAOTConsoleGreet.HumanGreet;
	duck: AnimalGreetings.DuckGreet;
}
export class HumanGreet {
	constructor();
	greeting: string;
}

As you can see:

DuckGreet should belong to an AnimalGreetings namespace
even though MainEntry and HumanGreet are in the same namespace, MainEntry's human property is prefixed with the same namespace (which is not necessary)

Thanks in advance!
P.S: As a workaround I am using the same global namespace for all my project's classes + a script to post-process the output d.ts file (it replaces the unnecessary namespace strings with an empty one) which is laborious.

.NET types tagged with [JSExport] are not namespaced in JavaScript/TypeScript - that is by design and follows modern JS conventions in which it is preferable to organize JS APIs by modules and not by namespaces.
On the other hand, .NET namespaces are preserved when dynamically loading pre-existing .NET assemblies (with no [JSExport] attributes), because .NET types are conventionally organized by namespace and it would not work well to reorganize them by assembly/module. (There is some more explanation here about the differences between these 2 approaches, but I need to document this better.)
All that said, there is clearly a bug in the generated typedefes: it should not be using those namespace prefixes when referencing other exported types. I'll fix that.


Rename getDataPayload.cs to GetDataPayload.cs to fix build in Linux

Linux filesystem is case sensitive :)

what you can compile on linux ???

what you can compile on linux ???

Of course, don't you know the mono project? :)

I know xamarin, but did not know that they ported msbuild on it.

Well Xamarin is a company (well, was a company! now it has been acquired by Microsoft!).
That company was in charge of maintaining 4 products:

The mono project (open source, for Linux/MacOSX/Windows).
Xamarin.iOS (proprietary, for iOS devices).
Xamarin.Mac (proprietary, for MacOSX).
Xamarin.Android (propietary, for Android devices).

The three latter were all based on Mono, which works beautifully in Linux since many years. The equivalent of MSBuild in the mono world is called "xbuild", and was created many years ago (although now it's going to be replaced by MSBuild itself because it has been recently opensourced by Microsoft, and the Xamarin people are fixing it to be cross-platform).
That being said, today I tried to build NBitcoin using MonoDevelop, not xbuild (but if it builds in MonoDevelop, it's very likely that it also does in xbuild).

and it just worked minus the nits ?

Well, I had to comment a couple of things that are not supported in the version of Mono I'm using (3.10.0), but I've checked the sources of mono master (https://github.com/mono/mono) and both things are implemented in the latest version (4.3) so it's only a matter of upgrading.

I think you are using the wrong project, for mono use

"NBitcoin.Portable\NBitcoin(Mono).csproj"

It should compile right away.

Also there is the NBitcoin.Mono package that should work with nuget on Xamarin studio.

I know that you're offering two different packages for MS.NET and Mono in nuget :) But I wanted to check for myself why.
And so, IMNSHO, NBitcoin users should use, moving forward, just one Nuget package, regardless if they're using Mono or not, if they're using Mono 4.3 or higher.
Unfortunately, Mono 4.3 is still unstable (stable version will be 4.4, which is not released yet; and even when it's released, it will take a while until distributions end up packaging it), so let's live with NBitcoin.Mono for now :)


html options (css class) not retained after rendering

<%= pagelet :pagelets_my_pagelet, remote: true, html: { class: 'my-class' } %>
my-class is correctly applied to the placeholder div, but is no longer there when the pagelet has rendered.
Is that by design, or a bug? :) I'd like to keep my class :D

I think that was recently fixed in the master branch. Could you please try it out and confirm if it works/doesn't.

Tested with master now. It seems to retain the class only with remote: false, true or :turbolinks loses the class.

Cool, thanks for checking, will do the fix in a day or so

@Frexuz should be fixed in 0.2.0 or master

Thank you! :D

Works


More refactoring

@johnlugton This fixes some of the issues I encountered, including the problem with the JIRA search. I realize that there are a lot of changes in there, but I tried to address a specific topic within each commit.
The other things which I plan to do are:

Improve performance. Currently, there is a bit of a feedback effect when a change occurs: Github sends webhook for alert change -> we adjust the JIRA ticket -> JIRA sends a webhook for that change -> We use the GitHub API to first check whether we actually need to propagate that change. This has some overhead, particularly during a full sync. It might make sense to use some sort of cache to avoid that.
Documentation. I think I want to write a few paragraphs on how to set this up properly.
Race conditions. I think there are some race conditions, since this web framework seems to serve the hooks concurrently, counter to my expectations.

LGTM - thanks!

LGTM - thanks!


docs: Fix faulty links on "Install Nuxt SEO"

Description
This MR is fixing some faulty links on the get started page. IMO the final solution would be to also fix the typo in the url (getting-familar-with-nuxt-og-image to getting-familiar-with-nuxt-og-image - familiar).

Thanks!


How to run LLaMa inference?

Hello!
How is it possible to run LLaMa models with the great FP8 inference speedup?
Would one need to train a new LLM from scratch or is it possible to convert existing models with the same accuracy?
Thank you very much and thank you for all the awesome work!

#199


Create ibex account for staging and work with Ibex to onboarding developer accounts

Follow up of https://github.com/lnflash/flash/issues/40 which was originally motivated for onboarding developers without requiring sharing of ibex password. Adding developer accounts will improve the development experience as more developers (& environments) are run.
Additionally, now that we have a staging env set up, we're using the same Ibex account for multiple environments: staging + each development environment. Each of these environments compete with each other over gaining valid access tokens to Ibex. With minimal developers, this issue is less noticeable. As we add more developers, more environments will be running concurrently which will cause more sign-in flows and risks getting the account locked.

Introduction of Ibex otel will gives us insight into the number of times Ibex.signIn is called, which will help us evaluate the priority of this issue

I'm closing this issue since we now have a staging environment and a production environment.


Move the inMemoryDatabase to the manager

I don't like having this in this repo.
I'd prefer having it in the storage folder of the manager repo.

Actually, I moved it to: https://www.npmjs.com/package/brackets-json-db

I still need to remove it from the codebase!


Provide Zookeeper dynamic configuration center implementation. fixes #2825

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] Bug fix
[x] New feature provided
[ ] Improve performance

Related issues
#2855 #2810

Coverage decreased (-0.002%) to 17.244% when pulling 82cd7b9a5d3644d03922c6c69f8620c70c76923b on zhaoyuguang:zk_plugin into ec731b2ad800f3621e90902c8a44b959f7b10ad7 on apache:master.

Please add IT test. I have asked @kezhenxu94 to add document about it.

Please add IT test. I have asked @kezhenxu94 to add document about it.

ok

I am not finish IT test yet, so add TBD Label

I finish it test.


monthCohorts? quarterCohorts?

Could have additional time based cohort manipulations like yearCohorts

@nmercadeb @catalamarti let's discuss if you think these would be necessary
One alternative would be to have a single function, where there is an argument specifying months/ quarters/ years, with another argument specifying start and end date (for the time intervals to be applied within)

I would go for a general function that can accomodate the different options


Performance question: while True: lpopmany ?

Hi !
I've been playing with channels and asgi_redis, and what I see in redis-cli monitor is a huge lot of calls to the lua script in lua_lpopmany, which is called in a while True loop : ~100 calls per second.
Do I need to be concerned about performance/load issues when running redis on a very small VM because of the high amount of commands being run ?
I imagine there might be a way to use redis pub/sub features somehow to implement this differently ? https://redis.io/commands#pubsub
Thanks !

Turning redis connection into pub/sub mode will disable another commands execution. You can't run LPUSH while you are in the pub/sub mode. For example, exactly the same reason lays in the way celery implements redis broker.
For the speed I can confirm it is the fastest layer implementation right now. It gives 0.010s latency at my very old laptop.

To expand on this - ASGI backends have two modes, a blocking mode that waits for changes (this is what the Django worker uses) and a nonblocking mode that fast-polls like you see, which is what Daphne uses.
The reason for this is that the list of channels it has to listen on changes as new connections come in, so any delay or blocking poll would mean new connections having significant latency in the handshake process.


Clicking on others' posts triple dots

Description
on Clicking on others' posts triple dots, no action is performed
Steps to reproduce
we can add a feature that on clicking on these dots show option to view the users profile
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

You're already assigned an issue @Lakshyyaa , also I believe this issue has been addressed already in another issue.Need to confirm


Getting profile: server error - Value cannot be null. Parameter name: clientSecret

In the downloaded zip example there is still a small error in the Web.config file.
In the appsettings the key "ida:AppKey" is used for the client secret, whereas in the Startup.Auth.cs code a search is done against the "ida:ClientSecret" key.  By changing the Web.config file accordingly the error is solved:
<add key="ida:ClientSecret" value="[The client secret saved from the Azure Portal Certificates & Secrets section]" />
All other stuff is working well! Thanks for the example.

Hi @mvancamp, thanks for catching that.


If the finetuned 2B model using RoPE or fixed position embedding?

R.T.

This may need to be re-fine-tuned.

Thanks for your response!
But I am asking about if your finetuned 2B model is using RoPE or the basic 3d pos embedding used in original CogVideoX?

Sorry, the basic 3d pos embedding used in original CogVideoX.


The cookie "sanctum.token.cookie" was rejected because a non-HTTPS cookie cannot be set as "secure".

Expected behavior
Login without errors
Actual behavior
The cookie "sanctum.token.cookie" was rejected because a non-HTTPS cookie cannot be set as "secure".
### On Login and can't redirect to the homepage on logging in
in Browser with German language

Module information

Content of your nuxt.config.ts:

// REPLACE WITH YOUR FILE CONTENT!
// https://nuxt.com/docs/api/configuration/nuxt-config
export default defineNuxtConfig({
  ssr: false,
  compatibilityDate: '2024-04-03',
  devtools: { enabled: true },
  modules: ['@pinia/nuxt','nuxt-auth-sanctum','nuxt-feather-icons'],
  sanctum: {
    proxy: true,
    baseUrl: 'http://localhost:8000/',
    mode: "token",
    redirectIfAuthenticated: false,
    redirectIfUnauthenticated: true,
    endpoints: {
      csrf: '/sanctum/csrf-cookie',
      login: '/api/auth/login',
      logout: '/api/auth/logout',
      user: '/api/profile',
    },

    // csrf: {
    //   cookie: 'XSRF-TOKEN',
    //   header: 'X-XSRF-TOKEN',
    // },
    redirect: {
      keepRequestedRoute: false,
      onLogin: '/',
      onLogout: '/auth/logout',
      onAuthOnly: '/auth/login',
      onGuestOnly: '/',
    },
    globalMiddleware: {
      enabled: true,
      allow404WithoutAuth: false,
    },
  }
})

Nuxt environment:

Version: nuxt: ^3.13.2, "nuxt-auth-sanctum": "^0.4.11",
SSR Enabled: no
Environment: No Local but dev mode

Laravel environment:

Version:  laravel/framework": "^11.0
Sanctum installed via Breeze: / no
Checklist completed: yes / no
What is your session domain in config/session.php: SESSION_DOMAIN=.localhost
What is your stateful domains in config/sanctum.php: SANCTUM_STATEFUL_DOMAINS=http://localhost:8000,localhost:3000,localhost:8000,http://localhost:3000
Content of config/cors.php:

login works only on localhost but on uploading to dev server with ip xx.xx.xx.x:3000 and backend with same ip xx.xx.xx.x:8000 it does not work

even success login on localhost i get this message before redirecting to home page
The cookie "sanctum.token.cookie" does not have a valid value for the "SameSite" attribute. Soon, cookies without the "SameSite" attribute or with an invalid value for it will be treated as "Lax". This will stop the cookie from being sent to contexts belonging to a third party. If your application needs the cookie in these contexts, please add the "SameSite=None" attribute to it. For more information about the "SameSite" attribute, see https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite.

Hey @OrPh4ns, it looks like you are using HTTP protocol instead of HTTPS on your server, please check Laravel configuration in session.php and set secure to false. Otherwise, you have to use HTTPS for Nuxt/Laravel applications (for your address <IP_ADDRESS>).
Also, you should not use .localhost as your SESSION_DOMAIN, sometimes it can work localhost but better to keep it empty or use correct TLD.

@manchenkoff
Unfortunately, i tried all solution to fix this issue but without success. It works with axios as well, and I don't get this message that cookie get rejected

@OrPh4ns can you setup a minimal repro for Nuxt/Laravel apps so I can take a closer look? You can also take a look at breeze-nuxt and breeze-api as examples of proper configuration if it helps.

Please, try the latest version 0.5.2. Feel free to re-open this issue if the problem persists.


Do not remove .nuxt dir on building

To play nicely with capistrano-like deployments we need to create symlink .nuxt directory. But build script deletes it anyway

@Darkside73 What about soft links?


How to keep the signal values of a heat diffusion higher

Hi developers of Pygsp,
After playing around with some heat diffusion code in your package, I was wondering how I could tweak the settings of:
G = graphs.Grid2d(10,10)
G.estimate_lmax()
taus = [0,1,2,3]
print(len(taus))
g = filters.Heat(G, taus)
DELTA = 25
s = np.zeros(G.N)
s[DELTA] = 1
s = g.filter(s, method='chebyshev', order = 10)
G.plot_signal(s[:,1], limits=[0,1])
for i in range(0,len(taus)):
    print(max(s[:,i]))

To not drop so fast in maximum values. Since the maximum value of the heat origin is dropping  and reducing from the original delta 1 to [0.62, 0.41, 0.28]. Also, is there a way to create a filter that eventually fades out completely? Such that I can simulate pressure data originating from a source which then completely disappears after N tau values? That would be great for simulating training data for my machine learning model, which works with pressure sensors that can detect events.  Hopefully my explanation is clear enough!

The value of tau controls the amount of heat diffusion. tau=0 is diffusion at time 0, i.e., no diffusion (a delta stays a delta). On the other extreme, as tau goes to infinity, heat diffuses to a constant value.
For the simulation of a system, a filter kernel is the fundamental solution of the PDE that governs the system (e.g., filters.Heat is the solution to heat diffusion, filters.Wave is the solution to the propagation of waves). If your pressure system behaves like heat diffusion, then you can use the heat kernel.


Add new Rank dictionaries

Rank dictionary stores rank icon url. More can be added such as min and max mmr for that rank.
Marks RankNames and LegacyRankNames dictionaries obsolete.
Currently uses images used on Dragon6 website.

Would it be better to change Rank and MaxRank from uint to Rank? Have it return all the information by default.

now closes #50


Show bare category value if there is no translation available

Signed-off-by: Ian Costanzo<EMAIL_ADDRESS>@esune Not sure if this is the correct approach, or if there are any other locations in the front-end code that will need similar logic

I think this is the right spot, the general-data-service should be what is used throughout the front end code to perform these translations.


I2p: 2.1.0 -> 2.2.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This update mitigates DDoS attacks; the sooner it can be merged the better.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/896