Cleanup dead and deprecated options

In 1.6 we deprecated a number of flags, with user warning. Now in master
we can remove them. The intent is users will directly use meshConfig.XYZ
instead of values.xyz to configure options. This means we don't need to
have two apis (which often times are not exactly the same like foo.bar
vs fooBar) to configure that same API.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test gencheck_istio

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7bc76168eadbf515b2e09873c97b78cb63918a78
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-galley-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

gencheck_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test gencheck_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-galley-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-galley-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-pilot-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-pilot-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-mixer-k8s-tests_istio

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

integ-security-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-security-k8s-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

integ-telemetry-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-distroless-k8s-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-local-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-local-tests_istio

lint_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test lint_istio

unit-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test unit-tests_istio

release-test_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test release-test_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-galley-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-galley-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-telemetry-k8s-tests_istio

integ-distroless-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-security-k8s-tests_istio
5c44c89883c24fa7e47649f30341cf4d92a15d28
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
5824e5aa7f2004e95e274f783c4e44203bc6782b
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

integ-security-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
0cdda753d337d5440ced02e819408b3196d4638f
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-security-k8s-tests_istio

unit-tests_istio
9716eda494152e76f6a7ed912a7153864fd99434
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
348a6cdf9b5677bed1a6b92d31c58464350dc446
link
/test integ-security-k8s-tests_istio

unit-tests_istio
9716eda494152e76f6a7ed912a7153864fd99434
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
9716eda494152e76f6a7ed912a7153864fd99434
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dde4863556f90ba3e0c05403042b65072491a0af
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
2b14268470ed441ca32c38bb60586ddb7ac4209d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ef8d7996cddf204b212a063edacc734274c928a0
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


UT3000 violin plot overhaul

Update Violin Plots
The violin plots for the framework paper are good, but I was told to change how the information is relayed.
The Problem
The violin plots are good, but need to be improved.
The Solution
The following changes need to be implemented:

[x] Combine everything into one figure: all four moods, energy, and 10000 steps. The end results would be a 3x3 subplot (really 6x3 in terms of violins) with a width ratio of 4:1:1.
[x] Include p-value on the figures themselves rather than just telling people there was significance
[x] significance test should be altered or at least looked into more. Perhaps a paired t-test (?) is more appropriate than what I am doing. Have to look into how to do that.

generated new, complete figure


Remove www.estpak.ee from the list

www.estpak.ee belongs to a major Estonian ISP named Telia (formerly Elion, that started out as first commercial ISP in Estonia called Estpak). It is in the unified hosts list. The ISP has not distributed any malware or adware as far as I know and has generally a good reputation.
dig gives the following result for the domain:
estpak.ee.		86215	IN	SOA	ns.elion.ee. hostmaster.elion.ee.<PHONE_NUMBER> 28800 7200<PHONE_NUMBER>0

@juusujanar you need to email upstream curator Dan Pollock<EMAIL_ADDRESS>for the removal inquiry 👍

Or add manual exception by own script in bash/python/powershell/batch or exception in Pi-Hole/NextDNS.

Thank you, guys, for sending me in the right direction. I had already included it as an exception for myself, but I have heard a few others having issues. I have emailed Dan with the details.
Not sure if the issue should be closed or not, I'll leave it up to you.

I suppose rejected and no fixed in Dan project, this no support option to delete problematic 3-rd party copied domains.

I suppose rejected and no fixed in Dan project

I emailed him just a few minutes before this reply, so he probably hasn't seen it yet.

Dan replied that the domain is now removed.

Steve @StevenBlack  ☝

Github add option, not allow close issue/pr by autor of these issue/pr in settings for repo/oraganisation?
If yes = imo useless.

@krystian3w I trust all our list curators.  They are all good people.  This has worked well for over nine years now.  I've never believed we needed a feature like the one you're alluding to.

Thanks Janar @juusujanar this will be live in the next release, coming shortly.


bridge data provider constructor

Try to adjust bridge data provider so it can be used...  @liujoshua can you comment on if this is valid or not?

Nice!  This is one of the issues I encountered.


Icons based on registry

Is your feature request related to a problem? Please describe.
Is it possible to connect an Icon src to a icon registry?
Here the current situation:
rome.setStyle(
  new Style({
    image: new Icon({
      color: '#BADA55',
      crossOrigin: 'anonymous',
      // For Internet Explorer 11
      imgSize: [20, 20],
      src: 'data/square.svg',
    }),
  })
);

Describe the solution you'd like
Based an a icon registry (i.e. : https://materialdesignicons.com/ ), be able to specify an icon only by his name
rome.setStyle(
  new Style({
    image: new Icon({
      color: '#BADA55',
      crossOrigin: 'anonymous',
      // For Internet Explorer 11
      imgSize: [20, 20],
      src: 'romeIcon',
    }),
  })
);

Those icons are available via jsdelivr.  You must include the path and .svg extension https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>https://codesandbox.io/s/icon-color-forked-pzlqb

Thanks! But in a offline mode, these will not work properly.

You would need to download them for local use.  The easiest way to do that would be to create a local clone of the repository https://github.com/Templarian/MaterialDesign/tree/master/svg

Yes you are right...
Refer to this.
https://github.com/Templarian/MaterialDesign/issues/4913


LDAP authentication into control center not working when bindDn and bindPassword are configured using secrets

We tried to configure the bindDn and bindPassword using secrets as shown here for control center. However it doesn't work as expected. When we configure the bindDn and bindPassword  in-line (as shown here) it works as expected.
Upon further investigation, we noticed that the jaas-config.file on the pod is malformed when the configuration is via secrets. See below (the bindDn appears to have a double quote at the beginning of the line)
bash-4.4$ cat /mnt/config/shared/jaas-config.file
ldap {
  org.eclipse.jetty.jaas.spi.LdapLoginModule required
  debug="false"
  authenticationMethod="simple"
" bindDn="CN=sa_confluentldapbind,OU=RBAC,DC=xx,DC=xx,DC=com
  bindPassword="xxx"
  contextFactory="com.sun.jndi.ldap.LdapCtxFactory"
  forceBindingLogin="true"
  hostname="xx.xx.com"
  port="389"
  roleBaseDn="ou=RBAC,dc=xx,dc=xx,dc=com"
  roleMemberAttribute="member"
  roleNameAttribute="cn"
  roleObjectClass="group"
  useLdaps="false"
  userBaseDn="dc=xx,dc=xx,dc=com"
  userIdAttribute="sAMAccountName"
  userObjectClass="user"
  userPasswordAttribute="Password"
  userRdnAttribute="sAMAccountName";
};

Our environment is on GCP. We tried to replicate this locally on a minikube using the exact same configuration, but the jaas-config.file rendered correctly on minikube. So wondering if this could be a bug specific to a particular platform?

The lda-credential secret, since it was created from a file from a windows machine, it had a carriage return (\r) in it which was causing the bindDn to get substituted incorrectly. It would be good to get that handled in the operator so others won’t run into such issues in the future.
The command kubectl get configmap controlcenter-shared-config showed the following in the output which helped us figure this out.
jaas-config.file: "ldap {\n  org.eclipse.jetty.jaas.spi.LdapLoginModule required\n
    \ debug=\"false\"\n  authenticationMethod=\"simple\"\n  bindDn=\"xxx\r\"\n  bindPassword=\"xx\"\n
    \ contextFactory=\"com.sun.jndi.ldap.LdapCtxFactory\"\n  forceBindingLogin=\"true\"\n
    \ hostname=\"xxx.xxx.com\"\n  port=\"389\"\n  roleBaseDn=\"ou=RBAC,dc=xxx,dc=xxx,dc=com\"\n
    \ roleMemberAttribute=\"member\"\n  roleNameAttribute=\"cn\"\n  roleObjectClass=\"group\"\n
    \ useLdaps=\"false\"\n  userBaseDn=\"dc=xxx,dc=xxx,dc=com\"\n  userIdAttribute=\"sAMAccountName\"\n
    \ userObjectClass=\"user\"\n  userPasswordAttribute=\"Password\"\n  userRdnAttribute=\"sAMAccountName\";\n};\n"


Add a dialog system for modal dialogs prompt, alert and confirm in the JS style.

Add a dialog system for modal dialogs prompt, alert and confirm in the JS style.
Dialogs like these are very helpful when the game is in prototyping, or when we want to ask the user to rate the game. For example, the code interface will be like this:
if (SilenceEngine.display.confirm("Do you want to run dialogs test?"))
{
    String value = SilenceEngine.display.prompt("Enter something!");
    SilenceEngine.display.alert("You've entered " + value);

    value = SilenceEngine.display.prompt("Enter something again!!", "why not?");
    SilenceEngine.display.alert("You've entered " + value);
}

This is now done! Care must be taken not to call these dialogs in the init() method, otherwise Android backend will crash.


Accepting trades

Please, add ability to manually accept trades(for each bot separetely and all of them). It would be really useful.

Just leave API key as "null.

I want not to restart asf each time I need to accept trade, that's it.

ASF automatically accepts trades whenever it sees new one, what's the problem?

How long does it take to "refresh" tradings? Cuz I tried it several times by now and the fastest solution for me was restart. But because I have a lot of accounts it takes time too.

As long as it requires. Bot should accept the trade as soon as it sees them, but steam doesn't send notification right away. And there is nothing to be fixed here.

Does there rules apply to sent trade offers?

ASF supports Master->Bot trades only.

Well, bot to master works okay for me too.) When I start asf at least.

Hello
I run into a problem when some bots do not accept trades from master account. In a log it look like: "INFO: ParseTrade()  Accepting trade: 921054124" and that's it, nothing else. What I can to do to make bot accept trade? Why it occurs?
Thank you

Read wiki.


multiple versions of portable-ruby

My brewconfig:
HOMEBREW_VERSION: 1.6.4-75-gc422214
ORIGIN: https://github.com/Homebrew/brew
HEAD: c4222141accae73b2d442430e634987850044459
Last commit: 34 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: fa98922082d8ad32f1aeb25d57fead9bd93fe89f
Core tap last commit: 81 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: --appdir=/Applications
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_NO_AUTO_UPDATE: 1
CPU: quad-core 64-bit ivybridge
Homebrew Ruby: 2.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3_2/bin/ruby
Clang: 8.0 build 800
Git: 2.10.1 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.43.0 => /usr/bin/curl
Java: 1.8.0_66
macOS: 10.11.6-x86_64
CLT: <IP_ADDRESS>.1.1480973914
Xcode: 8.2.1
XQuartz: 2.7.11 => /opt/X11

I have three versions of homebrew's portable ruby at:
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3_1
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3_2

Both /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/current and /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby-version point to 2.3.3_2, so are the older two versions absolutely necessary? I'd like to recoup the space (~67.3 MB) since I'm on a small internal SSD.

You can remove them. Please file future questions like this on our Discourse.


[web][PWA] SafeArea Widget does not work on iOS Safari PWA

My app is running as PWA on iOS Safari but the SafeArea widget does not work as expected. see image below or
App

@peerwaya
Can you provide flutter doctor -v and a complete minimal reproducible code sample along with index.html that has PWA script that shows this issue ?

here is a minimal example
import 'package:animations/animations.dart';
import 'package:flutter/material.dart';
import 'package:url_launcher/link.dart';

void main() {
  runApp(const MyApp());
}

const url = 'https://google.com';

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);
  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _selectedIndex = 0;
  final PageStorageBucket bucket = PageStorageBucket();

  final List<Widget> pages = const [
    Page1(),
    Page2(),
  ];

  Widget _bottomNavigationBar(int selectedIndex) => SafeArea(
        child: BottomNavigationBar(
          onTap: (int index) => setState(() => _selectedIndex = index),
          currentIndex: selectedIndex,
          items: const [
            BottomNavigationBarItem(
                icon: Icon(Icons.local_dining), label: 'Page1'),
            BottomNavigationBarItem(
                icon: Icon(Icons.assignment), label: 'Page2'),
          ],
        ),
        bottom: true,
      );

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.amber,
      body: PageTransitionSwitcher(
        transitionBuilder: (
          Widget child,
          Animation<double> animation,
          Animation<double> secondaryAnimation,
        ) {
          return FadeThroughTransition(
            animation: animation,
            secondaryAnimation: secondaryAnimation,
            child: child,
            fillColor: Colors.amber,
          );
        },
        child: KeyedSubtree(
          key: ValueKey(_selectedIndex),
          child: pages[_selectedIndex],
        ),
      ),
      bottomNavigationBar: _bottomNavigationBar(
          _selectedIndex), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

class Page1 extends StatelessWidget {
  const Page1({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Page 1'),
      ),
      backgroundColor: Colors.amber,
      body: const SizedBox.expand(
        child: Center(
          child: Text('Empty Page'),
        ),
      ),
    );
  }
}

class Page2 extends StatelessWidget {
  const Page2({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Page 2'),
      ),
      backgroundColor: Colors.amber,
      body: Center(
        child: Link(
          uri: Uri.parse(url),
          target: LinkTarget.blank,
          builder: (context, onPressed) {
            return ElevatedButton(
                onPressed: onPressed, child: const Text('Button 2'));
          },
        ),
      ),
    );
  }
}

https://github.com/GotokHQ/mini_test

Same as https://github.com/flutter/flutter/issues/84832#issuecomment-868267175
Keeping it open for further insights from team.

I thought we already handled this, but maybe I'm wrong. We might need to do what Apple recommends here: https://webkit.org/blog/7929/designing-websites-for-iphone-x/.
Another possibly related issue: https://github.com/flutter/flutter/issues/71278.

I am currently solving this with the help of this javascript library https://www.npmjs.com/package/safe-area-insets, not so elegant but it works. May be this can help
@JS()
library safe_area_insets;

import 'package:js/js.dart';
import 'interface.dart' as _interface;
import 'dart:ui' as ui;
import 'dart:html' as html;

typedef InsetCallbackHandler = void Function(Inset reult);

@JS('safeAreaInsets.onChange')
external void onChange(InsetCallbackHandler callback);
@JS('safeAreaInsets.offChange')
external void offChange(InsetCallbackHandler callback);
@JS('safeAreaInsets.left')
external num get left;
@JS('safeAreaInsets.top')
external num get top;
@JS('safeAreaInsets.right')
external num get right;
@JS('safeAreaInsets.bottom')
external num get bottom;

@JS('navigator.standalone')
external bool? get standAlone;

@JS('document.referrer')
external String? get referrer;

@JS()
@anonymous
class Inset {
  external num get left;
  external num get top;
  external num get right;
  external num get bottom;
}

void initializeViewPort() {
  final viewportMeta = html.MetaElement()
    ..setAttribute('flt-viewport', '')
    ..name = 'viewport'
    ..content =
        'width=device-width,initial-scale=1.0,maximum-scale=1.0,user-scalable=no,viewport-fit=cover';
  html.document.head!.append(viewportMeta);
}

class SafeAreaInsets extends _interface.SafeAreaInsets {
  late InsetCallbackHandler sub;

  SafeAreaInsets() {
    sub = allowInterop(_onChange);
    onChange(sub);
    value = value.copyWith(
      left: left.isNaN ? 0 : left.toDouble() / devicePixelRatio,
      top: top.isNaN ? 0 : top.toDouble() / devicePixelRatio,
      right: right.isNaN ? 0 : right.toDouble() / devicePixelRatio,
      bottom: bottom.isNaN ? 0 : bottom.toDouble() / devicePixelRatio,
    );
  }

  @override
  dispose() {
    offChange(sub);
    super.dispose();
  }

  num get devicePixelRatio {
    return 1; //ui.window.devicePixelRatio;
  }

  bool get isInStandaloneMode =>
      (html.window.matchMedia('(display-mode: standalone)').matches) ||
      (standAlone ?? false) ||
      (referrer ?? '').contains('android-app://');

  void _onChange(Inset result) {
    value = value.copyWith(
      left: result.left.isNaN ? 0 : result.left.toDouble() / devicePixelRatio,
      top: result.top.isNaN ? 0 : result.top.toDouble() / devicePixelRatio,
      bottom:
          result.bottom.isNaN ? 0 : result.bottom.toDouble() / devicePixelRatio,
      right:
          result.right.isNaN ? 0 : result.right.toDouble() / devicePixelRatio,
    );
  }
}

Same error in PWA with Flutter 2.8.1.
Following...

I have the same issue.
Any solution ?

I have the same problem in flutter stable 2.10.4.

We have the same issue with flutter stable 3.0.1

Same on flutter 3.3.2

Same on 3.5.0

Same on 3.3.5, are there any plans to fix this? Shouldn't be that hard to implement. Plus, it's a very important bug to fix, this should be one of the top priorities.

I've reimplemented safe-area-insets - npm with Dart. 😅
=> safe_area_insets | Flutter Package

Still problem in version 3.7

Hi, I found a solution.
`

`
reference:
https://docs.flutter.dev/platform-integration/web/initialization#initializing-the-engine
https://webkit.org/blog/7929/designing-websites-for-iphone-x/

Solution above breaks any communication with keyboard because in case of using custom host element flutter becomes to use different dimension provider.
https://github.com/flutter/engine/blob/a9da7212eacf1bf47d12993f6cc812cffbbad689/lib/web_ui/lib/src/engine/view_embedder/dimensions_provider/dimensions_provider.dart
Also you can find that main problem why other solutions don't work in next code.
void _applyViewportMeta() {
    for (final DomElement viewportMeta
        in domDocument.head!.querySelectorAll('meta[name="viewport"]')) {
      assert(() {
        // Filter out the meta tag that the engine placed on the page. This is
        // to avoid UI flicker during hot restart. Hot restart will clean up the
        // old meta tag synchronously with the first post-restart frame.
        if (!viewportMeta.hasAttribute('flt-viewport')) {
          print(
            'WARNING: found an existing <meta name="viewport"> tag. Flutter '
            'Web uses its own viewport configuration for better compatibility '
            'with Flutter. This tag will be replaced.',
          );
        }
        return true;
      }());
      viewportMeta.remove();
    }

    // The meta viewport is always removed by the for method above, so we don't
    // need to do anything else here, other than create it again.
    final DomHTMLMetaElement viewportMeta = createDomHTMLMetaElement()
      ..setAttribute('flt-viewport', '')
      ..name = 'viewport'
      ..content = 'width=device-width, initial-scale=1.0, '
          'maximum-scale=1.0, user-scalable=no';

    domDocument.head!.append(viewportMeta);

    registerElementForCleanup(viewportMeta);
  }

from https://github.com/flutter/engine/blob/a9da7212eacf1bf47d12993f6cc812cffbbad689/lib/web_ui/lib/src/engine/view_embedder/embedding_strategy/full_page_embedding_strategy.dart.
It replaces viewport meta tag. (Weird decision. It should be changed)
Possible solution
1. Find return appRunner.runApp() in your index.html and replace
        return appRunner.runApp().then((_) => {
          document.querySelector('meta[name="viewport"]').setAttribute('content', "width=device-width, initial-scale=1.0, viewport-fit=cover");
        })

It will enable env(safe-area-inset-bottom) in css.
2. Add to head of index.html
<style>
    :root {
      --sat: env(safe-area-inset-top);
      --sar: env(safe-area-inset-right);
      --sab: env(safe-area-inset-bottom);
      --sal: env(safe-area-inset-left);
    }
</style>

3. Create function in index.html or another js file
    function bottomInset() {
      return parseFloat(getComputedStyle(document.documentElement).getPropertyValue("--sab"));
    }

4. Add function on dart side
@JS()
library safe_area;

import 'package:js/js.dart';

@JS('bottomInset')
external double bottomInset();

Now you can get correct bottom inset inside flutter app. This is a working solution but of course it looks bad. If someone has time please update flutter engine for pass value of bottomInset() to viewInsets of FlutterView (you can find example in implementation insets for keyboard)

shocked this hasn't been sorted

Please fix this! It's realy important to me!

This problem, as well as the one mentioned in https://github.com/flutter/flutter/issues/69529, is causing difficulties in launching our Flutter web app on iOS Safari. The limited screen space is preventing our app from functioning properly. Would anyone be able to provide a solution for this issue?

@wjkoh https://github.com/flutter/flutter/issues/84833#issuecomment-1342902220

Still in 3.19.4 and still need a fix... :/

I also faced with 3.19.6 flutter version

I'm running the latest flutter version and I'm still facing this problem

Hi! Any update?

My approach is a bit ugly but it gets things done:
import 'package:universal_html/html.dart' as html;

// Check if it's an installed PWA
final isPwa = kIsWeb &&
  html.window.matchMedia('(display-mode: standalone)').matches;
// Check if it's web iOS
final isWebiOS = kIsWeb &&
  html.window.navigator.userAgent
  .contains(RegExp(r'iPad|iPod|iPhone'));

  // Use Container with color instead of Padding if you need to
  return Padding(
    padding: EdgeInsets.only(bottom: isPwa && isWebiOS ? 25 : 0),
    child: YourApp(),
  );


Error when saving the autopilot config

Describe the bug
When configuring the autopilot on a fresh renter node and saving the changes, an undefined is not an object (evaluating 'i.default') error pops up.
Expected behaviour
No error messages should appear.
Additional context
The config is saved successfully, though.
General Information
Are you running a fork of renterd? Yes, but this part of code is untouched.
Are you on the mainnet or on the testnet? Mainnet.
Renterd Config
Please provide us the following information:
Autopilot Config
curl -u ":[YOUR_PASSWORD]" http://localhost:9980/api/autopilot/config

Bus Config
curl -u ":[YOUR_PASSWORD]" http://localhost:9980/api/bus/setting/redundancy

curl -u ":[YOUR_PASSWORD]" http://localhost:9980/api/bus/setting/gouging
{
	"minShards": 3,
	"totalShards": 9
}
{
	"hostBlockHeightLeeway": 6,
	"maxContractPrice": "15000000000000000000000000",
	"maxDownloadPrice": "3000000000000000000000000000",
	"maxRPCPrice": "1000000000000000000000",
	"maxStoragePrice": "631593542901",
	"maxUploadPrice": "3000000000000000000000000000",
	"minAccountExpiry":<PHONE_NUMBER>0000,
	"minMaxCollateral": "10000000000000000000000000",
	"minMaxEphemeralAccountBalance": "1000000000000000000000000",
	"minPriceTableValidity":<PHONE_NUMBER>00
}```

**Contract Set Contracts**

```bash
curl -u ":[YOUR_PASSWORD]" http://localhost:9980/api/bus/contracts/set/autopilot | grep '"id"' | wc -l
[]

Renterd Logs
If applicable, upload your renterd.log file or part of the file you think is relevant to the issue.

Wow, I just came here to report this error, but then I saw that you had already done it 😅👍
But also I noticed a curious detail, if you enter all the values in the 'Configuration' tab BEFORE configuring the 'Autopilot' tab this error does not show up. Idk, maybe this small detail help devs to find a bug 🤷♂

Hey thank you both for reporting this. The sync default contract set feature was causing the issue when the default contract set was not yet set. I've put together a fix that will go into the next release.

we merged UI recently so this should be fixed, closing this out but feel free to re-open should there be any issues


Add "sendInvalidate" request

I'm interested in having this PR merged

Hello @iAbadia , Unfortunately, I'm busy right now and I can't spare the time. You can use the code for inspiration and make your own contribution.

Thanks @sbobko , I'll do that!


Change how we display degrees on the Manage application choice page

Context

Providers need to be able to see an international candidate's degrees. We want to display these in a new qualifications card component.
Changes proposed in this pull request
Introduce a DegreeQualificationCardsComponent that renders a card for
each degree held by a candidate.

Each card contains the details expected by the provider (subject,
grade, degree type, etc)
A NARIC statement is displayed if the corresponding database fields
contain values
An '(Hons)' is appended to the degree type if the awarded grade is an
honours
Predicted grades are prefixed with 'Predicted:'
The component can be initialised with an optional
application_choice_state argument. If provided, we only show the
institution name if the application is in an 'offer accepted' state.
This was implemented as an optional argument because this component is
also used in the Support interface, where hiding the institution isn't
a requirement.

Before

After

Guidance to review

Should be possible to submit different applications on the review app to then view in Manage. May need to switch the app to 'Mid-cycle' in support.
An outline of the DegreeQualificationCardsComponent behaviour from the spec output:

Link to Trello card

https://trello.com/c/66hZWX9d
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Review app link: https://apply-for-te-2014-degre-soj19k.herokuapp.com/ (not sure why Github didn't pick it up)

@malcolmbaig Just a few changes in commit 589052c590ef483d0ad22763c4a24d2e3caa3d69

Ensure we are using the correct heading levels on this page for different sections and their individual items
Fix a few cases where heading `ids did not match the respective title
Move some of the grid layout divs into components to prevent layout breakages

Be good to see this page with all types of qualifications present (Degree, GCSE, Other and EFL), but couldn't see a dummy application. How can I simulate that?


Add support to new Reliance Jio mobile range 87788 in India

Spinoff from #1520
Include phone numbers that start with 87788 range. This is a Reliance JIO number.
Example number: +91<PHONE_NUMBER>

@RMK19,
Thank you for taking the time to improve libphonenumber!
We've accepted this issue and will fix this in an upcoming release.
Please note that you have submitted this information with the knowledge that we
may use, modify, reproduce, publicly display, and distribute the information in
accordance with our open source policies. Please let us know if you did not
intend to submit the information for such use.
Please share any supporting evidence (for example, a national numbering plan,
announcements from mobile carriers, news articles) so that we can update the
carrier details as well.

@penmetsaa  Now above phone number range has been included. I have checked it here.

Fixed in release 8.3.0.


host_volume should be configurable

master has implemented host_volumes, but it is mandatory in order to use the module.
That is too opinionated and we should allow for no host_volumes to exist on the nomad clients

@fredrikhgrelland :+1:
Yeah, that's true!
So inorder to render flexibility, we need a switch that could turn on or off this feature say minio_enable_host_volume ?
And the switch needs to be upstreamed to the box as well.
Do you think we need to fix this in 0.1.0 release(scheduled for today) or  could we add it in a patch release next week?
Also we need to add a similar switch for postgres host volume feature as well to have it behave consistently across our modules?

@Neha-Sinha2305 before release 👍

@fredrikhgrelland:
ok..will start working on this then.
The switch minio_enable_host_volume should have default value as false?
Are you ok with the name: minio_enable_host_volume or do we have a standard naming convention for switches?

default: false
name: use_host_volume ?


Add support for several composition files

Fix #1
Add support for multiple positional arguments composition_file and update the file formatting process by using str.format() which seems appropriate here.
Note:  I don't really understand the get_root() function in install.py so I change it to check_path() with a reference to current path as return by os.getcwd() instead of the path corresponding to __file__.
Feel free to correct if I did it wrong.

get_root() was need to identify the root path of the composition so that the install.py file can be put in any side directory of the app.

ok like a utilsor scripts directory I guess ?
I thought that the instal.py file1 file2 command should be launch as if we launch docker-compose -f file1 -f file2 (same proper path for file1 and file2). That way install.py could be put everywhere in the path (even system-wise in /usr/bin for example).


Save the video while recording for every 5 min and capture the images also.

Save the video while recording for every 5 min and capture the images also.

Can you please describe the feature you need to have? Do you need the video to be divided into 5min parts and have a snapshot for each? Or you just need a frame from every 5 mins of the video?
Do you need all the parts uploaded as separate things, or maybe process them locally?
Would be cool to hear as many details as possible :)

closing it, since there is no details regarding the request.


Refactor CompiledModule to separate compile and linking stages

This is a major refactoring to:

Uniformly handle relocation data for functions and trampolines
Store relocations with its code
Separate debug image generation from DWARF sections creation (and their relocations)
Cleaner linking

No new functionality added here, mostly moving code around. Though it is a first step to allow serialization of compilation artifacts with ability to instantiate that later.

👍


Roadmap for version 4.

Just a note; v4 is not in the works just now, due to time constraints. However I would like to get some community feedback on this set of major changes, which I think are really important for this project's health going forward.
/cc @ai @MoOx @TrySound @sindresorhus @yisibl @benfrain @davidtheclark @jonathantneal

Plugin architecture
Performance, though much improved by the 1.5x speed up in PostCSS remains one of our major sticking points. Due to the way this module is built, each sub module wastes time by parsing and stringifying values each time they are run. We can cut this down to hopefully a single parse/stringify step for each node rather than for each plugin, but to do this we need to change our architecture.
I propose that a new architecture should export only one PostCSS plugin, as our current setup means that for each value transform (https://github.com/TrySound/postcss-value-parser) we perform, we have to:

Parse a node's value into memory.
Transform it.
Stringify it ready for the next transform...

This is due to each plugin being totally focused in its own PostCSS world. Each transform can work independently, which is a nice feature but not totally relevant given that most people would rather include a call to cssnano in their PostCSS instance, rather than bundle each plugin.
In addition, each plugin utilises PostCSS' each or eachInside methods at least once; if we can try to group these calls together that will also improve performance. Previous refactors involved reducing the usage of these methods per module which improved performance, so doing this on a global level would be beneficial.
I still believe in the plugin pattern being the best way going forward however, so v4 should have a different architecture that exposes hooks that visitors can exploit. For example there could be a hook for each time that a color value [rgba?|hsla?|hex|keyword] is detected; then in cssnano we have a system more like PostCSS itself:

Parse node values into memory.
Transform, transform, transform...
Stringify.

We then have a plugin list like the following:

postcss-colormin => cssnano-minify-colors
postcss-zindex => cssnano-reduce-zindexes
etc...

All current modules that I maintain and bundle with cssnano will be deprecated in favour of this new architecture. For modules that I don't maintain, such as autoprefixer, they will continue to be bundled with cssnano but will run first. That way we keep current functionality the same.
As I already found out when refactoring postcss-discard-duplicates, stringifying PostCSS trees are really expensive and you should always try and cache/reduce these calls whenever possible. We should operate on arrays instead.
Preset configurations
One of the things that I really like about Babel 6 is its customisability; you can specify a preset for ES2015 and it will download only the relevant modules. I think we should follow this pattern and at the same time look to making v4 run safe by default. Transforms such as postcss-zindex are not intuitive default options - we assume too much from a user by turning it on by default. So in v4, we will expose a core module that is safe by default, and then presets for cssnano's more aggressive behaviours.
Perhaps something like the following:

cssnano (main module, loads only safe transforms)
cssnano-preset-advanced (loads transforms like postcss-zindex, postcss-discard-unused)
cssnano-preset-experimental (loads experimental optimisation paths that may not be safe yet, such as CSS custom variable name reduction)
cssnano-preset-all (loads the whole lot)

sourcemap option removal
options.sourcemap should be removed as it is just sugar for the PostCSS map option. By dropping this option we can remove this method, making our codebase that much leaner:
https://github.com/ben-eb/cssnano/blob/a66892373552966d06210421d3f257279b704dab/index.js#L128-L132
Other changes
See the 4.0 milestone for related issues: https://github.com/ben-eb/cssnano/milestones/4.0

I'll add more details as and when I think of them. Any feedback would be greatly appreciated. :smile:

Grouping each* can be a thing, but at the level of cssnano only. Like you said, it's the power of postcss after all. And some plugins even make 2 passes (like postcss-custom-properties).

Babel 6 also have some good plugin optimizations by combining many plugins into one step. Might be worth looking into for inspiration.

@MoOx Yep, some plugins will need two or more passes still. I am thinking that transforms like postcss-colormin, postcss-convert-values, postcss-svgo, & postcss-normalize-url (and others) that map over values and transform e.g. black to #000 and 1.0px to 1px are going to benefit the most from this.
@sindresorhus Definitely. I think Babel's monorepo is a great pattern for testing/release cycles too. :+1:

@ben-eb I tried that monorepo today. It was hard. And I haven't success on testing it. ))

I have nothing smart to offer in terms of architecture. I would just like to add that I think a safe default would be the better default.
We were stung in production by z-index rebase and autoprefixer running (we already had autoprefixer in our chain and didn't realise nano was running it again with its own default config).

@benfrain But autoprefixer in cssnano is removed from chain by postcss-filter-plugins. @ben-eb Doesn't it work?

Maybe that was introduced after the version we are running. I can check version number if it helps?

On 12 Nov 2015, at 08:08, Bogdan Chadkin<EMAIL_ADDRESS>wrote:
@benfrain But autoprefixer in cssnano is removed from chain by postcss-filter-plugins. @ben-eb Doesn't it work?
—
Reply to this email directly or view it on GitHub.

We introduced that functionality since v2.2.0. https://github.com/ben-eb/cssnano/commit/57451355efc9595de3f144e6a72d88d69dc40424

Just to confirm: yes, we are currently running gulp-cssnano 1.1.0 ;)

I'll be really curious to see how an event-hooks architecture affects performance. If it's a significant gain, might be worth looking into for stylelint.

I was a fan of Babel 6's move to being a highly pluggable 'platform' and this mode would benefit from their approach to presets. safe transforms as a default that just gives you the minimal amount needed to get you up and running sounds like a good bet. The above breakdown for cssnano-preset-advanced, cssnano-preset-experimental etc. also seems fairly sane. I use cssnano in some of my projects and wouldn't have a hard time at all determining what those groupings relate to so :+1:

Babel 6 also have some good plugin optimizations by combining many plugins into one step. Might be worth looking into for inspiration.

:+1:

+10 to @addyosmani comment 👌🏼

Maybe more postcss-preset-cssnano-* (long but make even more sense). Or just postcss-cssnano-*.

@addyosmani Thanks for the feedback! :+1:
@MoOx At the moment I am thinking of playing around in a cssnano-* namespace as I feel that we can improve performance in our own sandbox, and look to bringing those changes back to PostCSS. Right now I have a performance problem that I hope to solve by merging the more expensive parts of each plugin (parsing, stringifying, iterating), without the concession that each has to be an independent transform that can plug into PostCSS.
We have tried the independent transform approach up until this point and it is slow. So I would like to see if we can do better with visitors and a common parsing/stringifying step for values/node trees. :smile:

Fair enough.

I think one nice thing to introduce is the idea of the configuration being a project-file. Like .cssnanorc, which could also be included within the package.json config to keep the number of files per-project down. Babel's configuration system looks for the dotfile first and then checks package.json for a specific key. It would be nice to replicate the same setup.
The main benefit here is, speed to check out a projects ruleset. If you know it is one of these places then it is faster to find and view then digging through any given projects build pipeline.

The performance right now is the only thing keeping us from using cssnano as a big part of our pipeline.

If you have some large CSS that creates a performance problem, it would be nice to share so that I can have a look at areas in where we can improve performance. :smile:

It's not that it's large, but we need to minify millions of CSS documents as fast as possible. Right now we're using cleancss, but investigating csswring so we don't introduce more than one CSS parser. Obviously cssnano would be rad, but it's about 1.5x-2x slower than the alternatives.

Why is autoprefixer even bundled with cssnano? I think of cssnano as a CSS minifier, and vendor prefixing doesn't have anything to do with minifying... It does the opposite if you think about it. I would prefer to use autoprefixer directly in Gulp, and update it seperately. Write programs that do one thing and do it well

@felixfbecker autoprefixer here only removes unnecessary prefixes. You can disable it in your build. And why you use split autoprefixer in gulp plugin? Parse once in one postcss pipe via gulp-postcss.

I just have to say after spending 3 hours today trying to figure out why all the z-indexes in my site were breaking. I was very surprised to find this was a performance tweak that was enabled by default.
Very excited to see safe will be on by default in 4.

@ben-eb if you are looking for large and slow css example, take a look at this one http://semantic-ui.com/introduction/getting-started.html

I've published an alpha build that is much less ambitious than the original goals I've outlined here, especially when it comes to performance & reducing parsing steps. In all honesty I think I'm reaching PostCSS' limits already, and while I did try to do a build that would combine all three parsers into a Frankenstein parser, it was too complex to make something useful out of, and I probably would have been better off writing another CSS parser from scratch. That's too time-consuming. 😄
But yet, we still have presets which was one of my main goals, and a bunch more things. Check it out at https://github.com/ben-eb/cssnano/releases/tag/v4.0.0-rc.0

why change zindex by default?????????????

Please don't change the z-index by default. That's just madness and a huge recipe for bugs.

Agree. z-index was the most confused rule. We can keep the rule, just disable it by default.

zindex is disable by default in cssnano


SGD w/ momentum

Hi --
I'm wondering about the implementation of SGD w/ momentum in autograd.optimizers.sgd:
velocity = momentum * velocity - (1.0 - momentum) * g
x = x + learning_rate * velocity

Other places I've looked have a different version of momentum -- CS231 from Stanford and the NAG paper [1] have:
velocity = momentum * velocity - learning_rate * g
x = x + velocity

EDIT:  pytorch implements something closer to autograd, but definitely still different:
velocity = mass * velocity + g
x = x - learning_rate * velocity

Does anyone have any thoughts on why these might be different?  AFAICT they are meaningfully different, so not sure which one is correct.
Thanks
Ben
[1] http://www.cs.toronto.edu/~hinton/absps/momentum.pdf

Good question! I think this just comes down to parameterization, by which I mean we can produce the same iterates using any of these versions by setting the (hyper)parameters differently.
For example, take the autograd version:
velocity = momentum * velocity - (1.0 - momentum) * g
x = x + learning_rate * velocity

We could move the learning_rate scale into the velocity sequence, to yield
velocity = (learning_rate * momentum) * velocity - (learning_rate * (1.0 - momentum)) * g
x = x + velocity

Now by choosing learning_rate and momentum appropriately we can simulate the CS231/NAG version (because the map (x, y) -> (xy, x(1-y)) is invertible, with inverse (a, b) -> (a+b, 1/(b/a+1))).
Similarly, if we start from the PyTorch version,
velocity = mass * velocity + g
x = x - learning_rate * velocity

We can push the -learning_rate scale into the velocity sequence to get
velocity = (-learning_rate * mass) * velocity - learning_rate * g
x = x + velocity

and now by choosing mass such that -learning_rate * mass = momentum we can simulate the CS231/NAG version.

Here's a quick check that my debug math worked out:
import numpy as np

gs = np.random.randn(10)

def cs231_sgd(x0, v0, learning_rate, momentum):
    x = x0
    velocity = v0
    for g in gs:
        velocity = momentum * velocity - learning_rate * g
        x = x + velocity
        print x
    print

def autograd_sgd(x0, v0, learning_rate, momentum):
    x = x0
    velocity = v0
    for g in gs:
        velocity = momentum * velocity - (1.0 - momentum) * g
        x = x + learning_rate * velocity
        print x
    print

autograd_sgd(0., 0., 0.5, 0.9)
cs231_sgd(0., 0., 0.5 / (1. - 0.9), 0.9)

Ah great, thanks for the answer.
Looks like you have the calls flipped -- should be
cs231_sgd(0., 0., 0.5, 0.9)
autograd_sgd(0., 0., 0.5  / (1. - 0.9), 0.9)

to yield the same answers.
As a general point, I'd contend that a parameterization where LRs are > 1 is a little confusing -- it doesn't really jive with my intuition of what a learning rate is.
Actually part of the reason I was looking into this was that in Figure 2 of this paper [1], they show that the optimal learning rate schedule for a simple NN has values as high as LR=7.0 at certain points, but looks like under their parameterization this probably translates to ~0.7 under SGD implementations I'm more familiar with. (Those are still high LRs, but not 7.0!)
Thanks again!
[1] https://arxiv.org/pdf/1502.03492.pdf

Thanks for the catch on my flipped calls :)
Good point about learning rates. It'd be good to follow some standard so that people can transfer learning rate values without too much confusion. It looks like TensorFlow does the same thing as PyTorch.
@dougalm or @duvenaud, should we switch the optimizer(s) to use a different hyperparameter convention to match other libraries?


Standardize mg command prereq logic, tests, and general clean up

Fantastic. Do not underestimate the power of compatibility with powershell5! this will help many people use the module with Azure Automation!