added styling

Summary by Sourcery
Enhancements:

Add a Tamagotchi device frame background image and adjust the screen positioning to match the frame design

This is a benchmark review for experiment reviews_for_yhkli.
Run ID: reviews_for_yhkli/benchmark_2024-10-29T11-27-46_v1-23-0-113-g9fada7a5a-dirty.
This pull request was cloned from https://github.com/ykhli/AI-tamago/pull/6. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark
    enable_functionality_review: benchmark

    enable_pull_request_summary: benchmark
    enable_review_guide: benchmark

    enable_approvals: false

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: benchmark
      overall_comments_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/ykhli/AI-tamago/pull/25
- https://github.com/ykhli/AI-tamago/pull/22
- https://github.com/ykhli/AI-tamago/pull/21
- https://github.com/ykhli/AI-tamago/pull/19
- https://github.com/ykhli/AI-tamago/pull/18
- https://github.com/ykhli/AI-tamago/pull/17
- https://github.com/ykhli/AI-tamago/pull/16
- https://github.com/ykhli/AI-tamago/pull/15
- https://github.com/ykhli/AI-tamago/pull/14
- https://github.com/ykhli/AI-tamago/pull/13
- https://github.com/ykhli/AI-tamago/pull/12
- https://github.com/ykhli/AI-tamago/pull/11
- https://github.com/ykhli/AI-tamago/pull/10
- https://github.com/ykhli/AI-tamago/pull/9
- https://github.com/ykhli/AI-tamago/pull/8
- https://github.com/ykhli/AI-tamago/pull/7
- https://github.com/ykhli/AI-tamago/pull/6
- https://github.com/ykhli/AI-tamago/pull/5
- https://github.com/ykhli/AI-tamago/pull/4
- https://github.com/ykhli/AI-tamago/pull/3
- https://github.com/ykhli/AI-tamago/pull/2
- https://github.com/ykhli/AI-tamago/pull/1

# Questions to ask to label the review comments
review_comment_labels: []
# - label: correct
#   question: Is this comment correct?

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews:
- dataset_pull_request: https://github.com/sourcery-ai/core/pull/4792
  review_pull_request: https://github.com/sourcery-ai-experiments/core/pull/414
- dataset_pull_request: https://github.com/ykhli/AI-tamago/pull/1
  review_pull_request: https://github.com/sourcery-ai-experiments/AI-tamago/pull/1

Reviewer's Guide by Sourcery
This PR adds styling changes to the Tamagotchi component by introducing a new CSS file and modifying the component's layout classes. The main changes include adding a Tamagotchi frame background image and adjusting the screen positioning within the frame.
Class diagram showing updated Tamagotchi component styling structure
classDiagram
    class Tamagotchi {
        +frameIndex: number
        +tamaStatus: string
        +render()
    }
    class TamagotchiStyles {
        <<CSS>>
        +tamago-frame
        +tamago-screen
    }
    Tamagotchi ..> TamagotchiStyles : uses
    note for TamagotchiStyles "New styling classes added"
    note for Tamagotchi "Updated with new CSS classes"

File-Level Changes

Change
Details
Files

Added new CSS styling for Tamagotchi frame and screen
Created new CSS classes for Tamagotchi frame with background imageAdded screen styling with white background and position adjustmentsImported new CSS file into Tamagotchi component
src/index.csssrc/components/Tamagotchi.tsx

Updated component layout classes
Added tamago-frame class to main containerAdded tamago-screen class to screen containerAdjusted screen height from 260px to 250px
src/components/Tamagotchi.tsx

Tips and commands
Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience
Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.


Compatibility with shared API GW

@HyperBrain Thanks for the plugin.
I see that you had mentioned this plugin wouldn't work with the PR that enables reusing existing API GW's across multiple sls stacks.
Do you plan on updating the plugin to support that model anytime soon? Also, do you have any short-term recommendations or workarounds in the interim?

Can you move the issue to the plugin repo? I think you accidentially used the examples project as target 😃

You are right... I apologize for the goof up.


using on Heroku

I'm attempting to implement this package on my Vapor app running on Heroku.
I forked the Vapor community's Heroku buildpack and enabled debug symbols: https://github.com/centaurlabs/heroku-buildpack/commit/5a9945181bb5762e29221fb500d13b704e8dd050.
I changed my main.swift file to the following:
import App
import Backtrace

Backtrace.install()
try app(.detect()).run()

And I added a route that runs the following code:
let tinyArray = [0]
_ = tinyArray[100]

The app crashes when a make a request to that route, but Heroku only logs the following:
State changed from up to crashed
Process exited with status 132

which is what it logged before I started using the buildpack.
If you can spot anything I overlooked in this implementation, please let me know!

It looks like you did the right thing. If you add a print("hello") after installing the backtrace do you see that in your Heroku log?

(We're also discussing this on Vapor's Discord server.)
The problem is that Heroku buffers stdout, and when the process dies, this buffer is lost. I replaced the print with fputs in my fork, and it seems to work better – the backtrace is visible at least.

I don't see the print in my Heroku log.
I changed my package to use @vzsg's fork, .package(url: "https://github.com/vzsg/swift-backtrace.git", .branch("stderr")). I got the same result he did. Something does get logged, but the symbols don't get translated.

I just updated the package to use the current master branch (which was just updated) and deployed a simple Vapor app to Heroku that generates an index-out-of-range error. It works!
My routes.swift file looks like:
import Vapor

/// Register your application's routes here.
public func routes(_ router: Router) throws {
    router.get { req -> String in
        let values: [String] = []
        return values[5]
    }
}

When I hit that route, I get the following:
0x55995f0b93bf, generic specialization <Swift.String> of Swift.Array._checkSubscript(_: Swift.Int, wasNativeTypeChecked: Swift.Bool) -> Swift._DependenceToken at /tmp/build_f2bbe0c0719f003adc3ab200c1b798fe/Sources/App/configure.swift:0
0x55995f0b93bf, generic specialization <Swift.String> of Swift.Array.subscript.getter : (Swift.Int) -> A at /tmp/build_f2bbe0c0719f003adc3ab200c1b798fe/<compiler-generated>:0
0x55995f0b93bf, function signature specialization <Arg[0] = Dead, Arg[18446744073709551615] = Owned To Guaranteed> of closure #1 (Vapor.Request) -> Swift.String in App.routes(Vapor.Router) throws -> () at /tmp/build_f2bbe0c0719f003adc3ab200c1b798fe/Sources/App/routes.swift:7
...

It identifies the line in Sources/App/routes.swift that generated the crash. It doesn't say exactly what went wrong, but pinpointing the line is a huge step.
Thanks so much for this!

Awesome - thanks so much for letting me know!

@rausnitz Thank you! Would you mind opening a PR with your change into the community buildpack? I don't think there are issues with it?

@maciejtrybilo It actually doesn't need any changes. I just had to set my SWIFT_BUILD_FLAGS config var to -Xswiftc -g.

@rausnitz Thanks! It crashes nicely now ;)


报表分析功能报错：json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Windows
Python version information

=3.11

DB-GPT version
main
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[X] Dashboard
[ ] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
GPU
Models information
chatglm2
m3e-base
What happened

What you expected to happen
期望可以得到正确的输出包括柱状图等
How to reproduce
实现报表分析功能
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Switching the model to glm-4 or ChatGPT. This is because the result generated by the model cannot be parsed into JSON.

Switching the model to glm-4 or ChatGPT. This is because the result generated by the model cannot be parsed into JSON.

只支持到ChatGLM2，好像不支持chatglm3和chatglm4


[libvorbis:x64-mingw-static] build failure

Host Environment

OS: Windows 10
Compiler: Mingw-w64 5.0.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg install libvorbis --triplet x64-mingw-static
Failure logs
Computing installation plan...
The following packages will be built and installed:
libvorbis[core]:x64-mingw-static
Detecting compiler hash for triplet x64-mingw-static...
Starting package 1/1: libvorbis:x64-mingw-static
Building package libvorbis[core]:x64-mingw-static...
Could not locate cached archive: C:\Users\Trider\AppData\Local\vcpkg\archives\47\473d16276b48e3a6c196a984423c6b665fa55ba7.zip
-- Using community triplet x64-mingw-static. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: D:\GitRepos\vcpkg\triplets\community\x64-mingw-static.cmake
-- Using cached D:/GitRepos/vcpkg/downloads/xiph-vorbis-v1.3.7.tar.gz
-- Cleaning sources at D:/GitRepos/vcpkg/buildtrees/libvorbis/src/v1.3.7-6c4ca9c573.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/GitRepos/vcpkg/downloads/xiph-vorbis-v1.3.7.tar.gz
-- Applying patch 0001-Dont-export-vorbisenc-functions.patch
-- Applying patch 0002-Fixup-pkgconfig-libs.patch
-- Using source at D:/GitRepos/vcpkg/buildtrees/libvorbis/src/v1.3.7-6c4ca9c573.clean
-- Configuring x64-mingw-static
-- Building x64-mingw-static-dbg
-- Building x64-mingw-static-rel
-- Using msys root at D:/GitRepos/vcpkg/downloads/tools/msys2/c809757c94447846
-- Fixing pkgconfig file: D:/GitRepos/vcpkg/packages/libvorbis_x64-mingw-static/lib/pkgconfig/vorbis.pc
-- Fixing pkgconfig file: D:/GitRepos/vcpkg/packages/libvorbis_x64-mingw-static/lib/pkgconfig/vorbisenc.pc
-- Fixing pkgconfig file: D:/GitRepos/vcpkg/packages/libvorbis_x64-mingw-static/lib/pkgconfig/vorbisfile.pc
-- CHECK_LIB_m_RELEASE:CHECK_LIB_m_RELEASE-NOTFOUND
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:232 (message):
Library "m" was not found! If it is a system library use the
SYSTEM_LIBRARIES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
correct the *.pc file
Call Stack (most recent call first):
scripts/cmake/vcpkg_fixup_pkgconfig.cmake:297 (vcpkg_fixup_pkgconfig_check_files)
ports/libvorbis/portfile.cmake:30 (vcpkg_fixup_pkgconfig)
scripts/ports.cmake:79 (include)
Error: Building package libvorbis:x64-mingw-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: libvorbis:x64-mingw-static
Vcpkg version: 2020.06.15-nohash
Additional context
Was actually trying to install SFML. vcpkg is up to date.

@Trider12, this is not usual scenario we're working on now, does anybody who help have a look?
I tried to build libvorbis:x64-windows-static, however, I can't repro this issue, what does D:/GitRepos/vcpkg/packages/libvorbis_x64-mingw-static/lib/pkgconfig/vorbisfile.pc look like?

@PhoebeHui, Hi. These are the contents of the file:
`prefix=${pcfiledir}/../..
libvorbisfile pkg-config source file
exec_prefix=${prefix}/bin
libdir=${prefix}/lib
includedir=${prefix}/include
Name: vorbisfile
Description: vorbisfile is a library that provides a convenient high-level API for decoding and basic manipulation of all Vorbis I audio streams
Version: 1.3.7
Requires.private: vorbis
Conflicts:
Libs: -L${libdir} -lvorbisfile
Cflags: -I${includedir}
`

@Trider12 , I see, the m library added by https://github.com/microsoft/vcpkg/blob/master/ports/libvorbis/0002-Fixup-pkgconfig-libs.patch#L10
It may has libm in mingw, however, the scripts/cmake/vcpkg_fixup_pkgconfig.cmake has not good support on mingw. So it can't find the library.
cc @Neumann-A

https://github.com/microsoft/vcpkg/blob/7e3d3beac5ca6fe8aab4599d4e1d8ce270ccdea8/scripts/cmake/vcpkg_common_definitions.cmake#L126-L129 probably needs to be updated for mingw? mingw is a community triplet so I don't care enough about it to make it work.

@Neumann-A, thanks! That solved the issue with libvorbis, however, I tried installing SFML again and have the following:
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:85 (message):
    Command failed: ninja -v
    Working Directory: D:/GitRepos/vcpkg/buildtrees/openal-soft/x64-mingw-static-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\GitRepos\vcpkg\buildtrees\openal-soft\config-x64-mingw-static-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:305 (vcpkg_execute_required_process)
  ports/openal-soft/portfile.cmake:35 (vcpkg_configure_cmake)
  scripts/ports.cmake:79 (include)

Error: Building package openal-soft:x64-mingw-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: openal-soft:x64-mingw-static
  Vcpkg version: 2020.06.15-nohash

I checked the logs and see this error:
...
CMake Warning (dev) at D:/GitRepos/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
  The package name passed to `find_package_handle_standard_args` (WindowsSDK)
  does not match the name of the calling package (DSound).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindWindowsSDK.cmake:472 (find_package_handle_standard_args)
  cmake/FindDSound.cmake:12 (include)
  D:/GitRepos/vcpkg/scripts/buildsystems/vcpkg.cmake:530 (_find_package)
  CMakeLists.txt:884 (FIND_PACKAGE)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- No compatible version of the Windows SDK or Platform SDK found. (missing: WINDOWSSDK_DIRS)
-- Could NOT find DSound (missing: DSOUND_LIBRARY DSOUND_INCLUDE_DIR)
-- Looking for mmdeviceapi.h
-- Looking for mmdeviceapi.h - found
CMake Error at CMakeLists.txt:911 (MESSAGE):
  Failed to enabled required WinMM backend

I then checked that I do indeed have the Windows SDK 10.0.18362.0 installed and the dsound.lib is there under x64. I'm guessing I need to somehow point CMake to that location?

https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure

Seems to be connected with #7790

The PR has been merged, thanks for your contibution!


Using generated pictures for commercial uses

Describe the change
Hey Carbon team! It is not an issue, but rather a question I could not find the answer to.
I would like to use your tool Carbon (accessed via https://carbon.now.sh/) to generate images and use them in a product I would like to sell. So it will be commercial use.
I would like to ask if this is allowed to do, legally. I already checked the terms but could not find any specific info.
Could you pleas help me in this matter?
Thank you and keep up with the good work!

I found a related issue
It says You have full creative control with the images you generate using Carbon.
Does that mean I can use it for commercial purposes? If so, then we can close this issue.
Thank you!

Please send your question with full detail of use to<EMAIL_ADDRESS>and we will get back to you there. Thanks!


Firebase throws error on 250 virtual shards, says limit is now 200

Version 20.08.01
com.google.api.client.googleapis.json.GoogleJsonResponseException: 400 Bad Request
POST https://testing.googleapis.com/v1/projects/test-lab-test-project/testMatrices
{
  "code" : 400,
  "errors" : [ {
    "domain" : "global",
    "message" : "Matrix expands to 250 supported executions which is more than the maximum allowed 200",
    "reason" : "badRequest"
  } ],
  "message" : "Matrix expands to 250 supported executions which is more than the maximum allowed 200",
  "status" : "INVALID_ARGUMENT"
}
        at com.google.api.client.googleapis.json.GoogleJsonResponseException.from(GoogleJsonResponseException.java:149)

This is the first run really looked at that was running on >200 shards, so I'm not sure if it is supposed to be 200 or 250 now.
https://github.com/Flank/flank/pull/915 changed it to 250, so I'm guessing it was changed recently on the firebase side.
May abandon this PR:
From firebase:

Looks like one code location didn't get updated to the new 250 limit. We'll try to have a fix for that in the next release.

https://firebase-community.slack.com/archives/C1MTSQ5QT/p1597951056010300?thread_ts=1597950018.009700&cid=C1MTSQ5QT

issue should be resolved by FTL now, they're considering reworking the sharding limit.
https://firebase-community.slack.com/archives/C72V6UW8M/p1597979321010300?thread_ts=1597950801.008900&cid=C72V6UW8M


Delay after setting actionbarextras properties

Hi!
Don't know if it is a module issue or my module implementation that creates this glitch.
Every time, just after the app starts, there is little delay in which the actionBar applies my configurations.
I have set a red background color inside the window's "open" event .
At first, the action bar is black, then background color changes to red only half second later.
Both emulator and device reproduce this effect.

Hi @grazianogrespan
yes this is how it works, you're not doing anything wrong. The reason for the delay is the timing until the open event gets fired on the window. This is a Titanium limitation since you cannot access the activity of a window before the open event got fired.
If you are just using this for changing the actionbars background color, you should workaround this by using themes to style your actionbar. If you need to change it at runtime, then you could use this module.

Thanks @manumaticx  for your reply !
I have to use this module cause i make changes to actionbar at runtime. Every window of my app has a different actionbar title,bg-color etc.
Anyway thank you very much for the explanation!

You can use themes for this anyway.
Am 16.10.2015 6:20 nachm. schrieb "Graziano"<EMAIL_ADDRESS>
Thanks @manumaticx https://github.com/manumaticx for your reply !
I have to use this module cause i make changes to actionbar at runtime.
Every window of my app has a different actionbar title,bg-color etc.
Anyway thank you very much for the explanation!
—
Reply to this email directly or view it on GitHub
https://github.com/ricardoalcocer/actionbarextras/issues/91#issuecomment-148759156
.

You can set window.title and window.theme before opening it. This will solve the delay issue. Use abx to change the background color after the window was opened.

Can we close this?

Yes @manumaticx , thank you again! ;)

:v:


Resolve classpath configuration only once

#25549 updated plugin resolution to be two-phased. The first phase resolved the classpath configuration. The second phase analyzed that configuration, and if the auto-applied plugins were not present there, it would modify that configuration's dependencies and resolve it again with new dependencies. The only reason this works is because we specially treat the classpath configuration and clear all resolution state after it is resolved. This double-resolution with different dependencies is very unconventional for a configuration so we should avoid it.
This commit updates the two-phase resolution into a single phase. Instead of resolving, checking for existence on the classpath, and resolving again, we resolve a single time. However, we place the auto-applied plugin on the original resolution by adding a dependency with a preferred version constraint instead of a required version constraint. This ensures any required version constraints from either explicit or transitive plugin requests override the preferred version from the auto applied plugin
Furthermore, we improve the way alternative plugin coordinates are implemented -- specifically to handle the transition from the Gradle Enterprise coordinates to the Develocity coordinates. Previously, during the second resolution phase, we would not auto-apply plugins if they were present on the first phase classpath. This however broke-down if the plugin was on the classpath but was not applied.
Instead, we enhance the plugin manager to be alternate-id aware, and also ensure we register the alternate coordinates with the resolution so that conflict resolution can properly ensure two versions of the plugin with different coordinates are not present on the classpath simultaneously.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.