Feature/ct development

Description
This PR has been created to add the following features:

Ability to create organization trail
The necessary IAM policy required to create an organizational trail
Ensure S3 buckets have versioning enabled and that objects at rest are encrypted
SCP to protect the trail from deletion
Introduced public accessibility control for trail S3 bucket

Features/Fixes/Patches/Changes list:
Please check the CHANGELOG.md
Checklists:

PR Owners Checklist:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you checked there aren't open Pull Requests of upstream or parallel code that will cause conflicts?
[x] Have you updated the CHANGELOG.md?
[x] Have you updated the README.md(s)?
[ ] OWNER: Does your submission pass?

[x] Pre-commit (attach logs/print screen to this PR)
[x] Checkov/terrascan (attach logs/print screen to this PR)
[x] Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully run tests with your changes locally?
[ ] First PR? Have you deleted ## How to use this template... from the root .README.md?

PR Reviewers Checklists?

[ ] Are all your comments/changes resolved?
[ ] Are you happy with the OWNER checklists and additional information provided?
[ ] Does your review tests pass?

[ ] Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

Checkov Analysis Results
cloudtrail-checkov.txt

Is it a valid case to request the creation of the CloudTrail Trail with an existing KMS Key? Seems like right now it will create it for you in any case.

Description
This PR has been created to add the following features:

Ability to create organization trail
The necessary IAM policy required to create an organizational trail
Ensure S3 buckets have versioning enabled and that objects at rest are encrypted
SCP to protect the trail from deletion
Introduced public accessibility control for trail S3 bucket

Features/Fixes/Patches/Changes list:
Please check the CHANGELOG.md
Checklists:
PR Owners Checklist:

[x]  Have you followed the guidelines in our Contributing document?

[x]  Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[x]  Have you checked there aren't open Pull Requests of upstream or parallel code that will cause conflicts?

[x]  Have you updated the CHANGELOG.md?

[x]  Have you updated the README.md(s)?

[ ]  OWNER: Does your submission pass?

[x]  Pre-commit (attach logs/print screen to this PR)
[x]  Checkov/terrascan (attach logs/print screen to this PR)
[x]  Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

[x]  Have you added an explanation of what your changes do and why you'd like us to include them?

[x]  Have you written new tests for your core changes, as applicable?

[x]  Have you successfully run tests with your changes locally?

[ ]  First PR? Have you deleted ## How to use this template... from the root .README.md?

PR Reviewers Checklists?

[ ]  Are all your comments/changes resolved?

[ ]  Are you happy with the OWNER checklists and additional information provided?

[ ]  Does your review tests pass?

[ ]  Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

Checkov Analysis Results

       _               _
   ___| |__   ___  ___| | _______   __
  / __| '_ \ / _ \/ __| |/ / _ \ \ / /
 | (__| | | |  __/ (__|   < (_) \ V /
  \___|_| |_|\___|\___|_|\_\___/ \_/

By bridgecrew.io | version: 2.0.1161

terraform scan results:

Passed checks: 47, Failed checks: 0, Skipped checks: 0

Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_61: "Ensure IAM role allows only specific principals in account to assume it"
	PASSED for resource: module.complete.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_45
Check: CKV_AWS_60: "Ensure IAM role allows only specific services or principals to assume it"
	PASSED for resource: module.complete.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_44
Check: CKV_AWS_62: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_47
Check: CKV_AWS_63: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_48
Check: CKV_AWS_24: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 22"
	PASSED for resource: module.complete.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/networking_1-port-security
Check: CKV_AWS_25: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 3389"
	PASSED for resource: module.complete.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/networking_2
Check: CKV_AWS_153: "Autoscaling groups should supply tags to launch configurations"
	PASSED for resource: module.complete.aws_autoscaling_group.main
	File: /main.tf:98-235
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/autoscaling-groups-should-supply-tags-to-launch-configurations
Check: CKV_AWS_88: "EC2 instance should not have public IP."
	PASSED for resource: module.complete.aws_launch_template.main
	File: /main.tf:240-443
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/public_12
Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	PASSED for resource: module.complete.aws_sns_topic.main
	File: /main.tf:569-572
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/general_15
Check: CKV_AWS_61: "Ensure IAM role allows only specific principals in account to assume it"
	PASSED for resource: module.minimal.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_45
Check: CKV_AWS_60: "Ensure IAM role allows only specific services or principals to assume it"
	PASSED for resource: module.minimal.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_44
Check: CKV_AWS_62: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_47
Check: CKV_AWS_63: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_48
Check: CKV_AWS_24: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 22"
	PASSED for resource: module.minimal.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/networking_1-port-security
Check: CKV_AWS_25: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 3389"
	PASSED for resource: module.minimal.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/networking_2
Check: CKV_AWS_153: "Autoscaling groups should supply tags to launch configurations"
	PASSED for resource: module.minimal.aws_autoscaling_group.main
	File: /main.tf:98-235
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/autoscaling-groups-should-supply-tags-to-launch-configurations
Check: CKV_AWS_88: "EC2 instance should not have public IP."
	PASSED for resource: module.minimal.aws_launch_template.main
	File: /main.tf:240-443
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/public_12
Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	PASSED for resource: module.minimal.aws_sns_topic.main
	File: /main.tf:569-572
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/general_15
Check: CKV2_AWS_5: "Ensure that Security Groups are attached to another resource"
	PASSED for resource: aws_security_group.main
	File: /main.tf:63-81
	Guide: https://docs.bridgecrew.io/docs/ensure-that-security-groups-are-attached-to-ec2-instances-or-elastic-network-interfaces-enis

Description
This PR has been created to add the following features:

Ability to create organization trail
The necessary IAM policy required to create an organizational trail
Ensure S3 buckets have versioning enabled and that objects at rest are encrypted
SCP to protect the trail from deletion
Introduced public accessibility control for trail S3 bucket

Features/Fixes/Patches/Changes list:
Please check the CHANGELOG.md
Checklists:
PR Owners Checklist:

[x]  Have you followed the guidelines in our Contributing document?

[x]  Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[x]  Have you checked there aren't open Pull Requests of upstream or parallel code that will cause conflicts?

[x]  Have you updated the CHANGELOG.md?

[x]  Have you updated the README.md(s)?

[ ]  OWNER: Does your submission pass?

[x]  Pre-commit (attach logs/print screen to this PR)
[x]  Checkov/terrascan (attach logs/print screen to this PR)
[x]  Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

[x]  Have you added an explanation of what your changes do and why you'd like us to include them?

[x]  Have you written new tests for your core changes, as applicable?

[x]  Have you successfully run tests with your changes locally?

[ ]  First PR? Have you deleted ## How to use this template... from the root .README.md?

PR Reviewers Checklists?

[ ]  Are all your comments/changes resolved?

[ ]  Are you happy with the OWNER checklists and additional information provided?

[ ]  Does your review tests pass?

[ ]  Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

Please see Checkov Analysis Results

       _               _
   ___| |__   ___  ___| | _______   __
  / __| '_ \ / _ \/ __| |/ / _ \ \ / /
 | (__| | | |  __/ (__|   < (_) \ V /
  \___|_| |_|\___|\___|_|\_\___/ \_/

By bridgecrew.io | version: 2.0.1161

terraform scan results:

Passed checks: 47, Failed checks: 0, Skipped checks: 0

Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.complete.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.complete.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.minimal.aws_iam_policy_document.assume_role
	File: /data.tf:1-12
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_108: "Ensure IAM policies does not allow data exfiltration"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-data-exfiltration
Check: CKV_AWS_109: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-permissions-management-resource-exposure-without-constraint
Check: CKV_AWS_111: "Ensure IAM policies does not allow write access without constraints"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-write-access-without-constraint
Check: CKV_AWS_1: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_23
Check: CKV_AWS_107: "Ensure IAM policies does not allow credentials exposure"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-do-not-allow-credentials-exposure
Check: CKV_AWS_49: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_43
Check: CKV_AWS_110: "Ensure IAM policies does not allow privilege escalation"
	PASSED for resource: module.minimal.aws_iam_policy_document.asg
	File: /data.tf:14-66
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/ensure-iam-policies-does-not-allow-privilege-escalation
Check: CKV_AWS_61: "Ensure IAM role allows only specific principals in account to assume it"
	PASSED for resource: module.complete.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_45
Check: CKV_AWS_60: "Ensure IAM role allows only specific services or principals to assume it"
	PASSED for resource: module.complete.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_44
Check: CKV_AWS_62: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.complete.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_47
Check: CKV_AWS_63: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.complete.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/iam_48
Check: CKV_AWS_24: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 22"
	PASSED for resource: module.complete.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/networking_1-port-security
Check: CKV_AWS_25: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 3389"
	PASSED for resource: module.complete.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/networking_2
Check: CKV_AWS_153: "Autoscaling groups should supply tags to launch configurations"
	PASSED for resource: module.complete.aws_autoscaling_group.main
	File: /main.tf:98-235
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/autoscaling-groups-should-supply-tags-to-launch-configurations
Check: CKV_AWS_88: "EC2 instance should not have public IP."
	PASSED for resource: module.complete.aws_launch_template.main
	File: /main.tf:240-443
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/public_12
Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	PASSED for resource: module.complete.aws_sns_topic.main
	File: /main.tf:569-572
	Calling File: /examples/complete/main.tf:1-177
	Guide: https://docs.bridgecrew.io/docs/general_15
Check: CKV_AWS_61: "Ensure IAM role allows only specific principals in account to assume it"
	PASSED for resource: module.minimal.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_45
Check: CKV_AWS_60: "Ensure IAM role allows only specific services or principals to assume it"
	PASSED for resource: module.minimal.aws_iam_role.main
	File: /main.tf:41-46
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/bc_aws_iam_44
Check: CKV_AWS_62: "Ensure IAM policies that allow full "*-*" administrative privileges are not created"
	PASSED for resource: module.minimal.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_47
Check: CKV_AWS_63: "Ensure no IAM policies documents allow "*" as a statement's actions"
	PASSED for resource: module.minimal.aws_iam_policy.main
	File: /main.tf:48-53
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/iam_48
Check: CKV_AWS_24: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 22"
	PASSED for resource: module.minimal.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/networking_1-port-security
Check: CKV_AWS_25: "Ensure no security groups allow ingress from <IP_ADDRESS>:0 to port 3389"
	PASSED for resource: module.minimal.aws_security_group.main
	File: /main.tf:63-81
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/networking_2
Check: CKV_AWS_153: "Autoscaling groups should supply tags to launch configurations"
	PASSED for resource: module.minimal.aws_autoscaling_group.main
	File: /main.tf:98-235
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/autoscaling-groups-should-supply-tags-to-launch-configurations
Check: CKV_AWS_88: "EC2 instance should not have public IP."
	PASSED for resource: module.minimal.aws_launch_template.main
	File: /main.tf:240-443
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/public_12
Check: CKV_AWS_26: "Ensure all data stored in the SNS topic is encrypted"
	PASSED for resource: module.minimal.aws_sns_topic.main
	File: /main.tf:569-572
	Calling File: /examples/minimal/main.tf:1-21
	Guide: https://docs.bridgecrew.io/docs/general_15
Check: CKV2_AWS_5: "Ensure that Security Groups are attached to another resource"
	PASSED for resource: aws_security_group.main
	File: /main.tf:63-81
	Guide: https://docs.bridgecrew.io/docs/ensure-that-security-groups-are-attached-to-ec2-instances-or-elastic-network-interfaces-enis

Is it a valid case to request the creation of the CloudTrail Trail with an existing KMS Key? Seems like right now it will create it for you in any case.

@mariomerco yes and our thinking is, you can create one when you deploy or you can specify a external key, some organisations want a dedicated KMS key but other orgs might want to use one for the all account or even kms byok and this way they can overwrite the default behaviour.

@hugoalmeida264 but with this module looks like it will always create the KMS key. As a matter of fact, I don't see a way to specify an external key for this use case.

Is it a valid case to request the creation of the CloudTrail Trail with an existing KMS Key? Seems like right now it will create it for you in any case.

@mariomerco yes and our thinking is, you can create one when you deploy or you can specify a external key, some organisations want a dedicated KMS key but other orgs might want to use one for the all account or even kms byok and this way they can overwrite the default behaviour.

@hugoalmeida264 but with this module looks like it will always create the KMS key. As a matter of fact, I don't see a way to specify an external key for this use case.

@patrickmukumbu please add this feature for KMS, aka, use external key, as we added to other modules, I belive the behaviour should be:

Create a KMS key within the module
Use external KMS key either a standard CMK or BYOK doesn't matter
Add to the unreleased a note to also allow to overwrite the default KMS Policies (I understand there are several)

I understand this is quite the amount of work, if you wan to add this to the unreleased section we will accept it.


Offline: Restore managed object observer class

This brings the multiple-context branch from services back over to the new apps repo.  In introduces a MSManagedObjectObserver class that will allow working directly with core data and still get tracking operations to use the sync logic later on.

Part of the end solution for #28


Feature: MarketProtocol Tokenized Implementation

Description
The implementation of the new functionalities of MarketProtocol.
Checklist

[x] Linter status: 100% pass
[ ] Changes don't break existing behavior
[ ] Tests coverage hasn't decreased

Affected core subsystem(s)
MarketContract, CollateralPool
Refers/Fixes
Fixes:

Pull Request Test Coverage Report for Build 657

80 of 98 (81.63%)  changed or added relevant lines in 9 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.09%) to 84.665%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contracts/chainlink/OracleHubChainLink.sol
0
3
0.0%

contracts/oraclize/OracleHubOraclize.sol
16
31
51.61%

Files with Coverage Reduction
New Missed Lines
%

contracts/libraries/MathLib.sol
2
88.89%

contracts/MarketContract.sol
3
84.62%

Totals

Change from base Build 574:
-4.09%

Covered Lines:
305

Relevant Lines:
343

💛  - Coveralls


Redefine voice search icon placement logic

Task/Issue URL: https://app.asana.com/0/0/1205629102384066/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3477

PR #3585

PR #3587

PR #3607

PR #3608

PR #3613   👈

PR #3583
PR #3574
PR #3489

PR #3516
PR #3491
PR #3490

PR #3528

PR #3541

PR #3564

PR #3567

PR #3550

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #3477

PR #3585

PR #3587

PR #3607

PR #3608

PR #3613   👈

PR #3583
PR #3574
PR #3489

PR #3516
PR #3491
PR #3490

PR #3528

PR #3541

PR #3564

PR #3567

PR #3550

This comment was auto-generated by Graphite.


chore(aws-ecs): refactor high level aws-ecs constructs into the aws-ecs-patterns module

Refactored all high level constructs from the aws-ecs module into the aws-ecs-patterns module as discussed offline. I've left the LoadBalancesXxxService constructs in the aws-ecs module as I think it make more sense to leave them there.
Pull Request Checklist

[X] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[X] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated
Design: For significant features, design document added to design folder

[X] Title and Description

Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@awslabs/aws-cdk-team Are we going to follow this model? Do we want to come up with what we call these? CDK Pattern Resources?

I would call this a fix and it needs a BREAKING CHANGE notice for the classes you moved.

I would call this a fix and it needs a BREAKING CHANGE notice for the classes you moved.

Updated the title to be fix, and added a BREAKING CHANGE notice.


[Visual Bug] The "Play along" button disappeared when the song's name is too long

The button disappeared as you can see when the song's name is too long

That looks like a discord issue, this plugin does not change the button visually


Upload binary releases to GitHub

This would make it easier for people to get started.
Platforms we need to support:

[x] Linux (using musl-libc)
[x] Mac
[x] Windows

The binaries are now available, but I'm waiting to hear back from users before declaring this closed.

Nobody has complained about these binaries, so I'm going to close this bug and let people report any future issues separately.


react-native link does not link the native project for android

I'm trying to use react-native-version-number in my RN app. On iOS everything works, but on Android I get a redbox saying RNVersionNumber is undefined. Looking at my app's native android project I can see that it's not including the react-native-version-number native project at all. If I add it manually it'll fail on gradle sync with an error about the default configuration.
On further investigation, it seems that android studio (or rnpm/react-native-cli) is not able to recognize the react-native-version-number android project. It doesn't allow the submodule to be expanded when it's included in my app project and when opened directly in android studio it offers to setup gradle for the project.
Versions:
react-native-version-number: 0.3.0
react-native-cli: 2.0.1
react-native: 0.48.4
android studio: 3.0

Sorry, was a problem on my side. Closing.


Displayed image IDs and dates not refreshed in frontend

Description
We got user reports that, although there were updates on the activity log in the dashboard showing an image:latest being updated, the repository view (/repositories/40) shows the initial image's id, not the latest pushed one.
We looked into the DB and found that the digest in the tags table was updated, but that is displayed nowhere in the GUI. However the updated_at as well as the image_id entry in the tag table do not get updated. One can see the updated latest tag in the activities table. I attached a text file with queries for the tag and the activities table.
portus_db_queries.txt
Steps to reproduce

Upload an image:latest with image ID sha256:A at timepoint 00:00:00
Upload an altered image:latest with image ID sha256:B at timepoint 11:11:11
Go to repository view /repositories/40

Expected behavior: The hash sha256:B is shown in the table with timepoint at timepoint 11:11:11
Actual behavior: Still the sha256:A is shown with timepoint 00:00:00

Deployment information
Deployment method: We are using a Nomad job to deploy Portus. The config was adjusted by blending the docker-compose.ldap.yaml with docker-compose.yaml.
Configuration and Portus version:
Portus version: 2.3.5@d1bc09bf2d27246d04349c6677c9c35e09e0fb7b
portus_frontend_config.txt
portus_backend_config.txt

I will take a look at this whenever I can. I remember writing the code so digests where updated, but I'm not sure about image IDs. Thanks for this report :+1:

@mssola Did you already have a chance to look at this problem?

@knorx @hmeine which registry version are you using? could you attach the docker compose file?

We're using Nomad, not docker compose. I attached our registry_portus.hcl (had to change the file ending for GitHub), in which I anonymized / removed some things like hostnames and vault access.
We're using opensuse/portus:2.3, but the registry image looks more anonymous (registry:2). I need to wait for a colleague to answer that one.

Without that information I won't be able to help you.
For now what I can tell you is that I was able to reproduce the issue with registry < 2.4 and sync strategy as initial. When I used the registry > 2.4 (I tested with latest 2.6) everything worked as expected. Also with registry < 2.3 and sync strategy as update/update-delete also worked as expected.


Unity Mod/Hook fail with "System.EntryPointNotFoundException: winelfx_WaitAndBeginFrame" when launching the game from Steam

When i setup LatencyFlex for Unity games and start them from Steam this error appears in the Bepinex output (from the LogOutput.log file in the Bepinex folder):
...
[Info   :   BepInEx] 1 plugin to load
[Info   :   BepInEx] Loading [LatencyFleX 1.0.0]
[Info   :LatencyFleX] Direct DLL load failed: trying wine bridge
[Error  :   BepInEx] Error loading [LatencyFleX 1.0.0]: System.EntryPointNotFoundException: winelfx_WaitAndBeginFrame
  at (wrapper managed-to-native) System.Runtime.InteropServices.Marshal.Prelink(System.Reflection.MethodInfo)
  at LatencyFleX.Plugin.Run () [0x00043] in <b63a64aa56334f3d866cedb38365850d>:0
  at LatencyFleX.Il2CppPlugin.Load () [0x0000b] in <b63a64aa56334f3d866cedb38365850d>:0
  at BepInEx.IL2CPP.IL2CPPChainloader.LoadPlugin (BepInEx.PluginInfo pluginInfo, System.Reflection.Assembly pluginAssembly) [0x00011] in <e9997477cd8143c9a348224def0a337e>:0
  at BepInEx.Bootstrap.BaseChainloader`1[TPlugin].LoadPlugins (System.Collections.Generic.IList`1[T] plugins) [0x0025c] in <16694cdb03bf4887828a298c286d045b>:0
[Message:   BepInEx] Chainloader startup complete

Games tested:

BattleBit Remastered (EAC Game) with Proton-GE (IL2CPP)
Crab Game (For testing) with Proton 8.0 (IL2CPP)
Catto Pew Pew! (For testing) with Proton Experimental (IL2CPP)

The error is always almost the same, with System.EntryPointNotFoundException: winelfx_WaitAndBeginFrame on it
As i said, this only happens when launching the game from Steam. But if i launch the game maually (using the command WINEDLLOVERRIDES="winhttp=n,b" LFX=1 proton <gameexecutable.exe> in a command line prompt) it loads without any problems and the output is:
...
[Info   :   BepInEx] 1 plugin to load
[Info   :   BepInEx] Loading [LatencyFleX 1.0.0]
[Info   :Unhollower] Registered mono type LatencyFleX.Plugin+LfxBeforeLoopInit in il2cpp domain
[Info   :LatencyFleX] Plugin LatencyFleX is loaded!
[Message:   BepInEx] Chainloader startup complete

Thing that i checked:

[x] I'm using BepInEx_UnityIL2CPP_x64_6.0.0-pre.1
[x] When i start the game from steam I provide the necessary launch arguments arguments: WINEDLLOVERRIDES="winhttp=n,b" LFX=1 %command%
[x] Copy the files latencyflex_layer.dll and latencyflex_wine.dll to the system32 folder of the compatdata folder of the game
[x] LatencyFlex is installed correctly and it works as it should if i start the game externally and not from Steam (With steam running in background of course, or the game will not start)

Please do not inject code into anti-cheat enabled games. This will get you banned.
Could you try direct copy instead of symlinks? Symlinks can have issues when the Steam Container Runtime is used.

Could you try direct copy instead of symlinks? Symlinks can have issues when the Steam Container Runtime is used.

Oh yeah i have to note that i copied the files and i didn't symlink them because the DLL doesn't load as you said, sorry about that.

I disabled Steam Container Runtime using SteamTinkerLaunch, now it loads the LatencyFlex plugin without any problems.
But this is still an issue. If it can't be solved and the only workaround is disabling the Steam Container Runtime then feel free to close it.

Yeah I think the hiccups with container runtime is pretty much a limitation of this bridge approach. For the in-development LFX2 I've opted for PE binaries only which should suffer less from all this dynamic library ABI and containerization problem.


论文原文

请问您是否可以分享论文原文？

Thanks for your attention. This paper is under review and will be published soon, maybe this summer.

OK！Thanks～

在 2023年5月9日，21:07，Jiacheng Lin @.***> 写道：

Thanks for your attention. This paper is under review and will be published soon, maybe this summer.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.


[bug] slider breaks on SSR when vertical is true

Issue Reproduction
https://codesandbox.io/s/9wrmql2xo
(or see live site)
Description

slider breaks on SSR + vertical: true.
SSR works as expected when  vertical: false

React SSR render (using next.js)

React Browser render

slick settings
{
    dots: true,
    infinite: false,
    vertical: true,
    verticalSwiping: true,
    slidesToShow: 3,
    slidesToScroll: 1
  }

I also encountered the same issue, were you able to fix it or find any alternative solution?

And I have the same problem, maybe someone has a solution?

Same issue. Any solutions?


How to calculate those metrics in the DTLN paper?

Could you please share some code about calculating the metrics , like PESQ SI-SDR STOI score  in the DTLN paper .

Besides how do you evaluate the performance in realtime  speech enhancement track?

Hi,
the objective metrics in the paper were calculated with Matlab. Sadly I can not share this scripts at the moment. I good solution in python is maybe https://github.com/aliutkus/speechmetrics .
The evaluation for the challenge were performed by Microsoft with this framework https://github.com/microsoft/P.808 on the Amazon Mechanical Turk.

Hi, breizhn, In pesq, is the  reference signal the output of the model? here are snippest of my code, the mean pesq is 3.06. I'm not sure whether the way to calculate pesq is right@breizhn
est, fs = sf.read("/data/www/project_speech/datanoreverb/clean/" +estfile)
denoised, fs = sf.read("/data/www/project_speech/datanoreverb/noisy/" + noisyfile)
pesq(est, denoised, fs)

I use est as the reference signal in this case. @breizhn

Why I get the mean PESQ is 3.68 which is much higher than the result, when I use the PESQ(clean, estimation, samplerate).@breizhn

Hi,
the reference signal is always the clean signal, so in the case of this model, the speech signal without noise. If the clean signal is not available, PESQ can not be used . 3.06 does not sound far from the result calculated in the paper.

thank you!

Hi,
the objective metrics in the paper were calculated with Matlab. Sadly I can not share this scripts at the moment. I good solution in python is maybe https://github.com/aliutkus/speechmetrics .
The evaluation for the challenge were performed by Microsoft with this framework https://github.com/microsoft/P.808 on the Amazon Mechanical Turk.

I just stumbled across this issue.  For your information: I reimplemented most of these metrics in Python (see pyspem )


Add flake8 plugins

[ ] flake8 plugin to check that all function parameters have annotation

[ ] components: #377
[x] cryptography #388
[x] databases #380
[ ] federated

[ ] data #390
[ ] plan #391
[ ] task #393

[ ] interface
[ ] native
[ ] pipelines
[ ] plugins
[ ] protocols
[ ] transport
[ ] utilities
[ ] openfl-tutorials (optional) #383
[x] openfl-workspace (optional) #381
[ ] final check

[x] flake8 plugin to check that all files have correct copyrights: #370
[ ] flake8 plugin to check trailing comma flake8-commas

Closing due to inactivity. OpenFL now uses an updated linting and formatting tool.


⚠ Turnos 24x7 has degraded performance

In d5631b8, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1325 ms

Resolved: Turnos 24x7 performance has improved in 5b710d0.


Netplay compatible icon for games

Hello,
I have a suggestion for theming: show a compatible netplay icon, I understand that a whole system is compatible or not, and not the games one by one, but this is mainly intended to make it visible which game is compatible with netplay in collections, where there are games from different systems.
@fabricecaruso  At the development level we have the following variables to filter, there are none for games if I'm not mistaken:
global.netplay -> bool. if netplay is enabled in batocera
system.netplay -> bool. if the system is compatible
But we dont have a "game.netplay" filter to show or hide content, or a name like in the old method, something like: md_netplay
I think it would be a good addition to improve the user experience.
Thanks.


⚠ St. Lawrence Global Observatory CKAN Sitemap has degraded performance

In 32193cf, St. Lawrence Global Observatory CKAN Sitemap (https://catalogue.ogsl.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 6796 ms

Resolved: St. Lawrence Global Observatory CKAN Sitemap performance has improved in 3116be0 after 5 minutes.


(WIP) (BOLT-253) Use containers instead of vms for tests

At least the unit and integration tests

This is awesome.

Waiting for CLA signature by @lucywyman
@lucywyman - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html


Add Option to Send Enter Key in Send Command Combobox

I often need to send several empty new lines to several devices after sending a
command to them. It would be really nice if there was an option to enable the
ability to do this -- it's suppressed right now if the combobox has no
character entered.

<IP_ADDRESS>

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 26 Oct 2014 at 2:16

This feature has been added and committed to the repository, will be in the next binary release.


Custom setup for metatheory

This adds a custom setup to the metatheory package, which adds a hook to call Agda to
generate the Haskell source before building. Concretely, cabal build plc-agda should now work (modulo caveats below).
This requires having the right Agda on the path already. I've provided
this in our shell.nix, so it will work from there, but it will
continue to not work outside it. There's not much we can do about this:
there's no good way to declare a dependency on Agda that cabal
understands, especially not since we also need the standard library.
Along the way, I rewrote our Agda building to use the Agda builders from
nixpkgs-unstable, which handle the recent changes to
--local-interfaces better, and also work properly with library files
(and we do have a checked in library file for our Agda, which we
previously had to throw away!).
As a bonus, we no long have to do the Nix cleverness that I had before
where we replaced the source of plc-agda with the generated Haskell.
Instead, we just provide the right Agda and let cabal generate the
Haskell source as part of a build hook.
(Aren't custom setups a pain? Yes: for cross-compilation, which we
don't care about for this package.)

James, I had to add some stuff to the cabal file, it's a big ugly. I think that's okay, since we should tidy it up and turn it into a library anyway?

Agreed.

I switched to using turtle, which is much nicer than the baroque process handling in System.Process. Now we get the stdout from agda, which does at least tell us when it's checking/compiling things.


Enhancement - Trade UI - Consider removing the *** .table>tbody>tr>td { border-bottom: 1px solid #ddd;} *** Reduces bloat and eye strain (+ pics)

From this

To this

we should reduce the border noisy all over the market page as well .. IMO with small changes we would gain a big eye pleasure effect ...

I'm not sure it's good idea to remove horizontal lines at all - they help eyes to scan table rows. Probably making them less visible (darker) would be enough.

yep sry .. my fault, ment this .. !

I agree with @valzav I'd keep them and go lighter as a compromise. Personally I like them as is. But I UX'd it :)

This looks quite different now so I'm closing it,  but feel free to open a new one if you still see possible improvements after the next release.


binary protocol does not support update command

I use pyorient
Error message:
pyorient.exceptions.PyOrientCommandException: Cannot find a command executor for the command request: sql. UPDATE my_class CONTENT {"holiday": "sea", "work": "universe", "accommodation": "house"} UPSERT WHERE holiday="sea"  - com.orientechnologies.orient.core.command.OCommandExecutorNotFoundException

This is supported. Could you provide the full stack trace?

The issue has been closed because no response has been received after a while. In case the issue is still valid, please reopen it or write a comment that explains why it's still valid and a way to reproduce it. Thank you.


Clarify this is the "Dashboard 2" - the successor to node-red-dashboard v1

Description
There is some confusion, even among regulars (See https://discourse.nodered.org/t/how-to-add-a-radio-button-in-node-red/80601/6?u=steve-mcl) as to what dashboard 2 is.
We should endeavour to make this clearer in the package info.
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

Think within our documentation and readme now we are sufficiently describing ourself as the successor/v2.


Export named vertex attribute sets as custom attributes.

Proposed fix for https://github.com/KhronosGroup/glTF-Blender-IO/issues/542.
Not ready to merge – there's one TODO in the code, and I'd like to get more feedback on whether this is the right approach and whether it's useful.
Steps to test:

Create one or more vertex color sets.
Assign a custom (non-"Col") name to at least one vertex color set.
Export with the "Meshes -> Custom Attributes" option enabled.
Result should be something like this, given a vertex color set named "Flux":

This will import to three.js with the name mesh.geometry.attributes._flux, for example.

I fixed tests (download daily build was KO), so you should merge master to re-run tests

Maybe this feature should use Weight Painting instead of vertex colors... 🤔

i'm wondering why limit exported color layers count. Master branch limits to 2 and current PR limits to 4.
Is there any reason to have a limit? and have it hard coded?
If so maybe we could at least log a warning during export.

Yeah, I'm not sure why there's a limit at all... I'd be fine with removing that.

@donmccurdy I'm guessing this has changed as it appears that all Vertex Color data (regardless of name) is now exported as COLOR_1..N. We have a bit of a problem with this as several Blender plug-ins these days (uvpackmaster, etc.) store useful data in Vertex Colors, but of course we don't want to export that, though we do want to export our vertex colors. Is there some plan to filter vertex colors during export in a better way? Maybe a regex or wildcard to include or exclude?

We have a bit of a problem with this as several Blender plug-ins these days (uvpackmaster, etc.) store useful data in Vertex Colors, but of course we don't want to export that ...

Hm, I'm sure some users do want to export that data as well. Two thoughts:

Is there a better way that we could encourage other extensions to store this data, like generic vertex attributes? I don't totally understand those but I think they are part of the geometry nodes development maybe. It would be ideal if this exporter could distinguish vertex colors from data-only attributes automatically.
Perhaps we could add a sub-checkbox like "Geometry -> Vertex Colors -> Visible Only"?

I would defer to @julienduroure on how (or if) to do this, I'm not able to pick this PR back up at the moment.

Vertex color is kinda weird in another way. COLOR_0 always affects the material, COLOR_1,2,... do nothing, but you can't export COLOR_1,2,... without a COLOR_0. This is in contrast to TEXCOORD_n where you can export whatever you want but you don't have to actually use them. You have to use COLOR_0 if you export it.
So far so good. But in 3.2 vertex color layers are replaced by color attributes and the sort order is basically out of your control. Since the first one in the list becomes the special COLOR_0, you've lost control of which one that is!
My idea was maybe color attributes should be treated like all the other generic attributes (export as _AttributeName, controlled by "Mesh > Attributes" or whatever). If "Geometry > Vertex Colors" is enabled, the active color attribute would instead be exported as COLOR_0. In no case would the exporter write COLOR_1 or higher. This solves the problem of "how do you decide which one is the special COLOR_0".


Fix typos in docs and examples

Thanks @dongjoon-hyun. These all look good to me!

Thank you, @gheinrich and @lukeyeager .
I sent my CLA for this PR a few minutes ago.

Thanks @dongjoon-hyun!

Thank you again! :)


add_swift_host_library cleanup

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @drexin

@swift-ci please test

@compnerd Could you please add a description as to why these changes are safe?

@drexin - its two individual changes bundled - the first one inlines a single call function (_add_swift_host_library_single) into its only caller (add_swift_host_library).  The second one fixes a couple of mistakes in the first one (I can go back and fix up the commits if you care).  It renames the usage of the variable that was named differently.  The only other thing it does is re-order the computation of the flags, it doesn't change anything but the order of the flags.  The functional change here is that path handling is delegated to CMake:
string(REGEX MATCHALL "/[^/]+" split_path ${CMAKE_CURRENT_SOURCE_DIR})
list(GET split_path -1 dir)

is replaced with
get_filename_component(dir ${CMAKE_CURRENT_SOURCE_DIR} DIRECTORY)


Using scRNA

Hey Caleb,
I am currently working on scATAC data but was wondering if it were possible to use mgatk with scRNA data.
Do you know how to implement scRNA into the mgatk workflow or which prerequisites are needed to work with scRNA.
As I am aware the calling of SNV does not seem to be working. Is it possible to circumvent this problem by providing a list of SNV coming from scATAC data?
Thanks and greetings.

So it's definitely already possible. In principle, you can run the CLI to get per position / per genotype counts (if you have 10x data, I discuss how to deal with the UMI here: https://github.com/caleblareau/mgatk/wiki/Process-mtDNA-from-CellRanger-ATAC). Once you have these tabulations, it's not clear yet how to find subclonal variants since the workflow that I found to be optimal requires both strands of nucleic acid. However, if you look at Figure 4 of the mtscATAC-seq paper, we do indeed analyze 5' scRNAseq data as part of the CLL analyses.


Facilitate test users to get HNYT

We can consider having a faucet to allow users to get HNYT for testing their Garden on Rinkeby.

We provide liquidty of HNYT on Uniswap for the Rinkeby network.


Android xml not support wrap_reverse and setVisibility(GONE)  not work

Report

[ ] I have searched existing issues and this is not a duplicate
i found two bug in Android
1、yg_wrap not support "wrap_reverse"

2、when use YogaLayout, view.setVisibility(GONE) by code or xml both won't work

The ImageView above seem to be in "Invisible" state, unless add yoga:yg_display="none"

Issues and Steps to Reproduce
Replaces this with steps to repro your issue.
Expected Behavior
Describe what you expected would happen.
Actual Behavior
Describe what actually happened.
Link to Code
If you have some code that maintainers can clone/test for themselves, bugs can be resolved much faster. Please paste a link here.
When applicable, use this fiddle to post a web repro.

Feel free to make a PR for #1, it seems like you already found where to define the missing attribute, and its source of truth.
For #2, it looks like:

YogaLayout.applyLayoutParams, which transfers attributes to the underlying Yoga Node, only ever inputs from Yoga namespaced sources. So we do not read from Android standard ones as any input into layout calculation.
Similarly, yg_{} attributes only ever effect layout. So yg_display will make your views zero-sized, but will not remove them from screen reader, focus loops, or any performance optimizations reliant on android:visibility="gone'.

So, TLDR, under the current model you need to do both, and also manage other scenarios around invalidating the Yoga tree.

I might also warn that the YogaLayout ViewGroup was not hardened as a production tool used by Meta, and I am personally unaware of large-scale production usages of it (though some may exist that I am not aware of).
From some of the issues I have seen from users, I have wondered if it might be better to deprecate it, since it's not a place I think will be prioritized. But I would like to learn more from someone who is using it, on what you are using it for, and how serious of an imapct not releasing a new version would have.

i used yogalayout for its cross platform, if i only write an app for android，i will use constraintlayout, linearlayout support by Goolgle。But since i need run my code in both android, html and even linux，i need a cross platform ui engine to support all this which will make it much more easier to write layout once,and run it every。

i need a cross platform ui engine to support all this which will make it much more easier to write layout once, and run it every

Shameless plug, closer to the level of a "UI engine" than Yoga are frameworks like React Native using Yoga, where you write the same UI code between Android, iOS, web (there are also versions for macOS, Windows, but not GTK or Qt). https://snack.expo.dev/?platform=web
But I think Meta's own usage of Yoga for Android-compatibile cross-platform code has been to enable it in higher level UI libraries like React Native for React components, or Litho for writing native Android components which are powered by Yoga (also OSS, but more used internally to Meta).
For the specific case of Android, there is also a library which Google developed first with the goal of exposing flexbox constraints as an Android ViewGroup. I have not used it personally though, but as an example, they do receive Visibility.GONE as an input https://github.com/google/flexbox-layout

We're deprecating the com.facebook.yoga.android.YogaLayout ViewGroup in the next major release of Yoga. We intend to still push out a new version aligned to the core Yoga 2.0. I have bulk closed ViewGroup issues to reflect that we are not planning to invest time into functional changes of the ViewGroup. and eventually intend to remove it from the repo.


Possible to see UNIQUE clicks?

Hello!
It would be helpful, to see unique clicks...
Can someone make a plugin? :-)

The clicks that YOURLS tracks should already be pretty unique, unless you're running a plugin that changes the redirect type. By default, YOURLS uses HTTP 301, which is considered "permanent", and therefore browsers and other clients will cache them for a long time. So, a single client opening one of your short URLs will likely only get counted once (unless their cache is cleared or something).
If you're trying to track "unique clicks" based on the user, not the client, that's not possible. Users may use different browsers, different devices, move from one network to another (and get a new public IP), and so on. A subset of these applies to tracking unique devices, since multiple browsers might coexist on a single device, without sharing a redirect cache.

Wow, what a fast reply... (^<>^)
Well, I clicked on an url 3 times (from the same beowser), and it displays 3 clicks...
Isn't it possible to see unique clicks based on the ip? And most of the time, users don't switch browsers...

Well, I clicked on an url 3 times (from the same beowser)

Depending of your browser settings and how you "clicked". 🔍

Isn't it possible to see unique clicks based on the ip?

Yes, everything is possible, but you may have a lot of false positives: eg. every terminal on my university network is behind one of the 3 shared public IPs for the all university…
So second excellent @dgw answer, it will not be very relevant.

And most of the time, users don't switch browsers

Ha ha, you can't imagine how much! 😆

Closing: plugin request

In the way we use the system, we also need the unique IP counter, in our case, by country.
I have add a new query and modified the graphic to add and show something like this...
"SELECT `country_code`, COUNT(distinct `ip_address`) AS `count` FROM `$table` WHERE `shorturl` $keyword_range GROUP BY `country_code`"

Hope that you can be helpful for you.


[BUG]fix expr's args type and return type check failed

compile be BUILD_TYPE=DEBUG，run sql as 'select a + 1 from table' will cause be failed.
be.INFO as below
function.h:263] Check failed: return_type == get_return_type(arguments) (0xa44f410 vs. 0xa44feb0)

If we use DataTypeUInt8 to represent the bool type, then the sink also needs to be modified

If we use DataTypeUInt8 to represent the bool type, then the sink also needs to be modified

MysqlRowBuffer doesn't support putuint8 now, so I use putint8 instead.
For 0 and 1, int8 and uint8 should be same.


🐌 Performance troubleshooting

Question
Hi! I'm currently using a library called react-native-bigheads that uses react-native-svg for rendering. The library renders some complex vectors, but it shouldn't be too much to handle.
My problem is, that the library renders really slow. I'm talking about noticeable delay in initial rendering (mounting) (see this demo), and generally really slow renders on re-rendering when a prop changes (see this demo).
I am trying to debug why this renders so slow, as normally vector rendering should be really fast. Now to my actual question(s):

What could possibly be the cause of those incredibly slow renders?
How can I debug/perf-measure this?
What do I generally have to look out for when using vectors? Stuff like "don't use a lot of clipping, that's really slow"

More info

The main component that renders all other child SVG components is Base.tsx
All other components are in this folder
Component renderers are stored as variables in maps (like a table lookup)

All kinds of help appreciated 👍

Try React.memo Worked for me.

@angadp I'm not having re-render issues. React.memo only prevents unnecessary re-renders, but in my case the actual render times are slow.

@mrousavy any update on this ?

I just did most of it natively.

I just did most of it natively.

are you saying you stopped using the package and did your own thing?


Nested items (submenus)?

The screenshot shows submenus, i.e. items nested under other items. Where are there instructions or examples of this?
Thank you.

Found it here
    {id: 'inventory', title: 'Inventory',
        'sub-menu': [
            { id: 'levels', title: 'Product Levels', 'icon-cls': 'fa fa-list'},
            { id: 'levels', title: 'Sales Report', 'icon-cls': 'fa fa-area-chart'},
        ]
    },

I may fork and add this to the readme

@OKNoah - Is this working?  I'm using the component in JSX, but I keep getting "Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined" @react-sidenav.js:222
React.Children.map(this.props.children, function(child)  {

using the following config
{key: 'parentMenu', title: 'Parent Menu','iconClassName': 'fa fa-exchange',
   subMenu: [
      {key: 'childMenu', title: 'Child Menu', 'iconClassName': 'fa fa-exchange'}
    ]
},

My menu works fine until I try to include the subMenu.  Any thoughts?  I'd love to know for sure if someone else has sub menus working. THANKS!

Is there an example of how to configure submenus manually without supplying the navigation attribute?
<SideNav.Menu className={"sidenav"} itemHeight="32px">
    <SideNav.MenuItem itemKey={"test-parent"}>
        <SideNav.IRightItem className={"fa fa-truck"}>
            Test Parent
        </SideNav.IRightItem>
        <SideNav.Menu className={"sidenav-submenu"} itemHeight="32px">
            <SideNav.MenuItem className={"sidenav-submenu-item"} itemKey={"test-child"}>
                <SideNav.PlainLink>TRUCK</SideNav.PlainLink>
            </SideNav.MenuItem>
        </SideNav.Menu>
    </SideNav.MenuItem>
</SideNav.Menu>

I've tried many variations on this theme, and the best I could do was to get the submenu items to render on top of the parent items.

This component has been updated. I'm adding support for custom renders. Closing this issue now and I have added sub-menu on the README


Delete Key

The delete key does not work. In termion this is Key::Delete

Got it added, thanks for the suggestion.

@IGI-111 delete should remove the character in front of the cursor, not behind

Yeah I kinda overlooked it since I don't use the delete key that much myself. It's behaving as intended now.

cool


equalize_adapthist leaves artefacts when image size is not a multiple of tile size

#Reported here, here and here.
A possible workaround is to pad the image to a multiple of the kernel size, apply CLAHE, and then output the image after unpadding. By default, 1/8 of NX and NY is used, which means that the padding should result in NX and NY being a multiple of 8.

Only user of the code has a fix for the issue, closing.


Werf dismiss should not fail when release is not exists

Werf dismiss command should act in the more declarative way. For now werf dismiss will fail with an error if release is not exists:

werf dismiss not failing now if release not exists.


cert manager cert requests

This PR:
Add CertManagerTooManyCertificateRequests alert to identify early possible control plane overloading.

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
[x] Alerting rules must have a comment documenting why it needs to exist.
[x] Consider creating a dashboard (if it does not exist already) to help oncallers monitor the status of the issue.

Since we have metric for the count of all objects in etcd, wouldn't it make sense to alert on all resources? Or is it that a single kind of resource causes problem not the whole number? My thinking is that this can happen for other resource types and not just cert-manager

Since we have metric for the count of all objects in etcd, wouldn't it make sense to alert on all resources? Or is it that a single kind of resource causes problem not the whole number? My thinking is that this can happen for other resource types and not just cert-manager

Although I don't where the limit on the number of resources is, it's true that it might be a problem. Having said that, I believe that alerting on all the resources has a few drawback and we should not pursue it:

It's hard to define an owner, as the scope is too wide.
It's impossible to define a recipe for resolution during on-call. TooManyResources feels more like a capacity planning issue than a "the cluster is broken, fix it" thing.

Also, I think the alert makes sense for this specific case because the number of CertificateRequests is always going up. Once the cleanup mechanism is properly working, this alert has way less importance.


[SPARK-24176][SQL] LOAD DATA can't identify wildcard in the hdfs file path

What changes were proposed in this pull request?
When the wildcard characters (like "?") were in the LOAD DATA command's path name, the Path related API (hadoop and URI) couldn't parse it correctly. For example:
val srcPath = new Path(hdfsUri) in the tables.scala, returned wrong result for the following cases:

hdfsUri = file: /user/testdemo1/user1/t??eddata60.txt,
srcPath = file:/user/testdemo1/user1/t
hdfsUri = file:/user/testdemo1/user1/?eddata60.txt',
srcPath = file:/user/testdemo1/user1/
(the same problem exists at val uriPath = uri.getPath())

The LOAD DATA LOCAL works  because the local case called a utility Utils.resolveURI to replaced the "?" to "%3F", then the PATH API will not truncate the file name.
This fix uses Utils.resolveURI method for both local and non-local cases.
I did similar test on hive, it seems the hive has the same behavior.
hive> load data inpath 'hdfs:/tmp/?evin.txt' into table foo1; FAILED: SemanticException Line 1:17 Invalid path ''hdfs:/tmp/?evin.txt'': No files matching path hdfs://stcindia-node-6.fyre.ibm.com:8020/tmp/%3Fevin.txt hive> load data inpath 'hdfs:/tmp/k?evin.txt' into table foo1; FAILED: SemanticException Line 1:17 Invalid path ''hdfs:/tmp/k?evin.txt'': No files matching path hdfs://stcindia-node-6.fyre.ibm.com:8020/tmp/k%3Fevin.txt hive>
How was this patch tested?
Did the unit test locally, and added new test cases.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

is it a duplicate of https://github.com/apache/spark/pull/20611?

cc @wzhfy and @sujith71955

@HyukjinKwon thanks for reviewing this pr. I didn't notice that pr until you point out. If we plan to support wildcard in the LOAD DATA command, then we can close this PR.
But with his current code, the problem reported by this JIRA still exists, because for the non-local case, the Path will be truncate after val srcPath = new Path(loadPath). I download his code, and it still have the same issue as this pr reported.
I create text1.txt on my local machine, then run LOAD DATA
load data inpath '/Users/qianyangyu/IdeaProjects/spark/??xt1.txt' into table foo1;'  successful, but it didn't load data into the table
load data inpath '/Users/qianyangyu/IdeaProjects/spark/t?xt1.txt' into table foo1; failed
`spark-sql> load data inpath '/Users/qianyangyu/IdeaProjects/spark/??xt1.txt' into table foo1;
Time taken: 0.112 seconds
spark-sql> select * from foo1;
18/05/09 23:23:51 INFO DAGScheduler: Job 1 finished: processCmd at CliDriver.java:376, took 0.000029 s
Time taken: 0.056 seconds
18/05/09 23:23:51 INFO SparkSQLCLIDriver: Time taken: 0.056 seconds
spark-sql> load data inpath '/Users/qianyangyu/IdeaProjects/spark/t?xt1.txt' into table foo1;
Error in query: LOAD DATA input path does not exist: /Users/qianyangyu/IdeaProjects/spark/t?xt1.txt;
`

Can one of the admins verify this patch?

close this pr, pr#20611 has combined this fix into his.


[do not merge] [timeseries] Update to GluonTS v0.12.0

DO NOT MERGE UNTIL GLUONTS v0.12.0 IS RELEASED ON PYPI!
Description of changes:

Add TFT PyTorch model
Update the SFF model (use StudentT output, fix the quantile workaround)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@canerturkmen Cannot run the tests on CI until GluonTS v0.12.0 is released on PyPI, unfortunately. Will do that tomorrow after the release

@canerturkmen

I have removed the prophet model (it's anyway currently completely unusable since it's not included in MODEL_TYPES in presets.py)
ran the tests locally with the latest version of GluonTS master branch (see screenshot)


How to automatically create mounted directory?

I use compose like this:
services:
  mysql:
    image: mysql:8.0
    environment:
      - MYSQL_ROOT_PASSWORD=root
    ports:
      - 3306:3306
    volumes:
      - ../../data/mysql/var/lib/mysql/:/var/lib/mysql/

Which works with docker-compose:1.29.* (pip install docker-compose), the mounted directory will be created automatically  as follow:
/d/docker
|--linux
   |--mysql
      |--docker-compose.yml
|--data # automatically created
   |--var
      |--lib
         |--mysql

However, nerdctl compose up -d got:
FATA[0000] failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:76: mounting "/d/docker/data/mysql/var/lib/mysql" to rootfs at "/var/lib/mysql/" caused: stat /d/docker/data/mysql/var/lib/mysql: no such file or directory: unknown

Am I using it as wrong way?

If you dont need to bind the exact directory, you can change the type from from Bind (compose detects the path there) and put into Volume mode. Something like:
    volumes:
      - mysql_data:/var/lib/mysql/

or
    volumes:
      - type: Volume
        target: /var/lib/mysql/
        source: mysql_data

I'm studying the code for a possible adjust. But I'm new here. :-)

@jopapo @AkihiroSuda
Is there something new you can share with us?
I get the same error mentioned by @icefery and can't figure it out how to get it to run.
I couldn't get it to run with the Volume mode either.
myimage:
  network_mode: bridge
  build: ./myimage
  dns:
    - <IP_ADDRESS>
  ports:
    - 443:443
  volumes:
    - /tmp/myvolume:/tmp/myvolume:z

FATA[0000] failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:75: mounting "/tmp/myvolume" to rootfs at "/tmp/myvolume" caused: stat /tmp/myvolume: no such file or directory: unknown

Interesting(?) sidefact:
I tried the same setup with Docker/Docker Desktop and got the same error but as soon as I disabled "Use gRPC FUSE for file sharing" and started using the legacy osfx file sharing it worked.

I've ran into this issue too. To me (and I'll admit I'm not an expert at all), it seems nerdctlis trying to access the file system as root and not as the current user. Thus, for instance, my binding to ~/data/mongodb goes to /home/root/data/mongodb and that directory doesn't exist and can't be created and because root is "disabled" the volume binding fails.
Using the volume mode worked though. So, thanks @jopapo for the tip.
Scott

I've ran into this issue too.


Widgets binding error after upgrading flutter version to 2.13.0-0.1.pre

I'm facing below warnings since I upgraded the flutter version to 2.13.0-0.1.pre.
Warnings:
Testing started at 10:59 AM ...
                      ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:32:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
                   ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:195:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
                   ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:205:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.addObserver(this);
                   ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:211:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.removeObserver(this);
                   ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:279:34: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    final value = WidgetsBinding.instance?.window.viewInsets.bottom;
                                 ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/object_widget.dart:107:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
    WidgetsBinding.instance?.addPostFrameCallback((timestamp) {
                   ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_redux-0.9.0/lib/flutter_redux.dart:474:22: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
      WidgetsBinding.instance?.addPostFrameCallback((_) {
                     ^
../../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_redux-0.9.0/lib/flutter_redux.dart:577:22: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
 - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../flutter/packages/flutter/lib/src/widgets/binding.dart').
      WidgetsBinding.instance?.addPostFrameCallback((_) {
                     ^

Flutter version:
Flutter 2.13.0-0.1.pre • channel unknown • unknown source
Framework • revision 13a2fb10b8 (8 days ago) • 2022-04-12 15:34:25 -0500
Engine • revision 499984f99c
Tools • Dart 2.17.0 (build 2.17.0-266.1.beta) • DevTools 2.12.1

Facing loss of background image on renderImage(). Seems related to same mentioned issue. Occurred after upgrading to flutter 3.0
`/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:32:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:195:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
^
/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:205:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
WidgetsBinding.instance?.addObserver(this);
^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:211:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
WidgetsBinding.instance?.removeObserver(this);
^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:279:34: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
final value = WidgetsBinding.instance?.window.viewInsets.bottom;
                           ^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/object_widget.dart:107:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
WidgetsBinding.instance?.addPostFrameCallback((timestamp) {
^
`

Facing loss of background on renderImage(size). Seems related to WidgetsBinding issue as mentioned above. Started getting issue after flutter upgrade to 3.0
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
                   ^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:195:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addPostFrameCallback((timeStamp) {
                   ^
/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:205:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addObserver(this);
                   ^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:211:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.removeObserver(this);
                   ^

/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/text_widget.dart:279:34: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    final value = WidgetsBinding.instance?.window.viewInsets.bottom;

                                 ^
/home/system/snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_painter-1.0.1/lib/src/views/widgets/object_widget.dart:107:20: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/home/system/snap/flutter/common/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addPostFrameCallback((timestamp) {
                   ^


Open Rubi Integration notebook for specific rule in the Steps display

This issue might require advanced knowledge Mathematica. The goal is that the user can open the correct integration rule notebook (which contains more information) at the correct place from one of the rules in the Steps display:

The chain of information flow for the integration rules is as follows:

Albert writes each rule as a separate section in the integration rule notebooks and often provides additional references into the literature or explanations.
The notebooks are then transformed into *.m files where everything, except the Mathematica code for the rule, is stripped.
Rubi loads these files in a fixed order. The order is vitally important. During "loading" the code for all rules are turned into DownValues for Int.
Some of the Int rules are further processed (see FixIntRules)
When using Steps for integration, we know which specific DownValue was used, but we lost the information from which cell in the source-notebook this rule is coming from.

The question is: Is there a reliable way to calculate or store the information where a DownValue can be found in the source-notebooks? This should work across multiple Mathematica versions and operating system.
I already tested some approaches like calculating hash-codes for the rule but these failed because Mathematica makes adjustments in the expressions when it transforms a := definition into a DownValue. Talk to me, @halirutan, if you like to work on this issue.

I noted that RubiRule has an ID now. Is this issue still open?

I'm not exactly sure about what ID you're talking, but the preliminary work I did on this can be found on the NotebookReferences branch. It worked pretty well on my machine but I haven't looked at this for well over a year. It works by calculating a hash for each integration rule that is then included in the rule itself.
So if you check one of the final integration rule files you find that each rule has an additional default RubiNotebookReference argument:
Int[1/x_, x_Symbol, _:RubiNotebookReference["70cb09bc"]] := Log[x]

The hash of each rule is available in a large map that is used to resolve the filename and cell-number back.
If the original Rubi notebooks are available locally, this can be used to open the exact notebook in read-only mode (much like you do with Mathematica's documentation) and navigate to the cell where a specific integration rule is defined.
What's still missing is a separate "resource paclet" that can be installed automatically and contains the original Rubi notebooks. It needs to be placed so that rules from the<EMAIL_ADDRESS>can be opened. The current implementation just expects the $UserBaseDirectory and you can find the implementation here. Look at the  locateRubiNotebook function for more info.


please clean up those useless models uploaded by users

please clean up those useless models uploaded by users
many models does not work normally. it just wast time.

Hi @taozhiyuai, working on improving the full model library and building tools to make it easier to see more about a model before downloading it. Also, sorry you hit an error running a model – in the meantime there are a set of curated models here: https://ollama.com/library


rpm: fix logrotate config migration

We need to support these cases.

When the file is edited, RPM renames it to td-agent.rpmsave.
When the file is not edited, RPM removes it.

Thanks for your review!

It seems that the tests are unstable...
I will check them.

#539 will make the tests stable.

I will rebase this after #539 is merged.

Rebased to apply #539

Now, the tests should be stable.


Hi, any chance for adding Message Batches (beta)

It sees promising as it suits my workflow well so I would like to try.

@chew-z This feature has been added and is available in the latest release of go-anthropic (v2.9.0).
Hope this helps!


Fix Functional Test

coverage: 100.0%. remained the same
when pulling fd2cc7d05a0d13c64438ae3138a0dc8155b5ad63 on test_fix
into 2ca613acabb2ff8406a38047c071a1ab48602a2d on master.


[azeventhubs] Improperly resetting etag in the checkpoint store

We shouldn't be resetting the etag to nil - it's what we use to enforce a "single winner" when doing ownership claims.
The bug here was two-fold: I had bad logic in my previous claim ownership, which I fixed in a previous PR, but we need to reflect that same constraint properly in our in-memory checkpoint store for these tests.

/azp run go - azeventhubs


0 results when using multiple keywords

Great tool!
I have noticed that the tool does not return results for multiple keywords - "filetype:pdf site:microsoft.com". This is the same for selenium and the http methods.

GoogleScraper -m http --keyword "filetype:pdf"  works fine.
2.GoogleScraper -m http --keyword "site:microsoft.com" works fine.
GoogleScraper -m http --keyword "filetype:pdf site:microsoft.com" fails to return results.

This looks like a parsing issue?

This can be fixed with - https://github.com/NikolaiT/GoogleScraper/pull/131


#1029 Put dotscanner in profile

Thank you for your contribution to the KodaDot NFT gallery.
👇  _ Do a quick check before the merge.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main-nuxt and I've no conflicts
[x] I've tried respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases

What's new?

[x] PR closes #1029
[ ] <brief_description_of_what_I've_added>

Had issue bounty label ?

[x] Fill up your KSM address:
Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI, a screenshot is best to understand changes for others.

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x0100388c9921b6b019e02312e9ebf3dd68122c0743a3c48502fb64156bf49845
Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/


Integrate iceberg-ext Crate in iceberg-rust

The iceberg-ext crate of this Repo contains various classes that should eventually be migrated to iceberg-rust.
There are a few obstacles to overcome first, such as the IntoResponse implementations for some types that we heavily depend on.
With this issue we want to:

Migrate the most important functions from iceberg-ext of this crate to an iceberg-rust fork
Create PRs to iceberg-rust from our fork

Depends on https://github.com/hansetag/iceberg-catalog/issues/46