sleeplog: fix #1423

Fixes
Uncaught Error: Expecting a string, got undefined
 at line 93 col 59 in sleeplog.boot.js
...(storage.read(this.logfile)));

see https://github.com/espruino/BangleApps/issues/1423

Thanks!


JSMin: Unterminated String at byte (even with html param)

Getting this error in production: https://github.com/mrclay/minify/issues/81
However, I'm only using {%- minify html -%}, so it shouldn't be touching any JS...

Hi Tim,
are you running SEOmatic too? Try and disable that quickly. I found the same and believe the issue lies with the  Google JSON schema and the minifier. I'm still investigating

@john-henry Indeed I am. I'll give it a shot.

So if you're seeing this, somehow SEOmatic is generating JSON-LD that is invalid.  Which would be really strange, it tries very hard to guard against such things.
Normally it's something like a quote that isn't escaped or such.
What would REALLY help me would be if you could get me the dump of JSON that the minifier is choking on.  What you can do to make this happen is:
Disable Minify
Send me the entire page source used to cause the error so I can look at the generated script tags
If you don't want to post them here, email them to<EMAIL_ADDRESS>

Came back after my dinner and all seems to be working now. Not sure what has changed. Was happening on local and dev and cache was disabled on local. Ill keep and eye on things but looks to have shook itself out. Thanks

This should be fixed in SEOmatic 1.1.27, which I just pushed:
https://github.com/nystudio107/seomatic
Basically, it was stray control characters (most like \n or \r) in the meta that then was carried into the JSON-LD, and apparently JS-min didn't like it.  That's why it happened for some entries, but not others.
We now strip all control characters from the SEOmatic meta JSON-LD.
Thanks to @timkelty for the help.

I have also run into trouble with JSMin with exact same error on magento2. It does not happen everytime though. It happens at the JSON that I am pushing to GA. But my json is valid. there are no stray characters.

I also ran into this issue. I'm not using SEOmatic, but was outputting some JSON-LD that contained html tags. Annoyingly, since Minify now defaults disableDevModeMinifying to true, I didn't catch the error until it was pushed to the remote staging site.
I fixed it by using the json_encode twig filter when outputting the relevant json-ld properties.

I have this as well and Im on SEOmatic 1.1.56

This also happens when you have just inline JS in the template also. For me, it was because I had a Vimeo play function that looked like player.on('play", function() { which needed to be player.on('play', function() {
Just got to check for any minor mistakes in the code, as well as checking SEOMatic JSON

@bymayo Did you mean to post this on the old Craft 2 SEOmatic repo?

WHOOPS. I just came across the issue on Google. My bad.

I too encountered similar issue but not with SEOmatic.
I scraped <textarea></textarea> value into JS variable and string had \n character. I couldn't remove \n because it had to stay in the same text format. I had to find other way to manipulate it.


Date Manipulating/Formatting Functions

Should we allow Date or time formatting related functions in the main repo?
While ubiquitous I feel like they would more belong in the archive section due to the reliance on a very confusing library and regional/national standards.

After re-reading the whole thread, I think I have a suggestion about the date category as a whole, one that could go into the guidelines:
Date snippets considerations
As far as snippets that deal with date parsing and formatting are concerned:

Snippets that apply mathematical transformations to raw millisecond (ms) values, such as formatDuration are acceptable and considered relevant to dates.
Snippets that apply string transformations to raw ms values are considered relevant to dates.
Snippets that accept Date objects and use the prototype's built-in functionality or apply transformations are acceptable, as long as they do not have confusing edge-cases.
Snippets that parse Date objects internally from strings or numeric values are going to be declined, as they are going to have edge-cases that need to be dealt with.

I think the above rules should cover it all and keep everything safe and consistent, due to the fact that dealing with existing Date objects lets the developers tackle the issue of localization on their own and, for snippets that use raw ms and string data, we only apply transformations without parsing dates in them. That being said, all the currently accepted snippets in the date category are safe to use (and I see no reason to remove them as they are not really all that problematic and don't seem to have any unhandled edge-cases), while the snippets in #536 seem to conform to these guidelines, so they are safe to merge and showcase to new users.
Opinions? @kingdavidmartins @fejes713 @skatcat31


GPG keys  is not correct for this package.

When i try to install azure-cli on centos, I get this error :
The GPG keys listed for the "Azure CLI" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.
It was working in the past... But it seems that a new azure-cli version has been released ...

Détails du document
⚠ Ne pas modifier cette section. C’est obligatoire pour docs.microsoft.com ➟ Liaison des problèmes GitHub.

ID: f9f55d23-7802-e0da-6d12-b71f6da8a1d4
Version Independent ID: 192846d7-baae-bcba-698b-22bdcdae468a
Content: Installation d’Azure CLI pour Linux avec yum
Content Source: docs-ref-conceptual/install-azure-cli-yum.md
Product: azure
Technology: azure-cli
GitHub Login: @sptramer
Microsoft Alias: sttramer

Yes, I can confirm this error on my end as well, hit it today.

I found that when following the instructions this install works fine. So the issue must be with my Artifactory proxy of the remote repository.

@CondormanFr The GPG signing key was changed sometime in the last year, and the new key is required if you have not updated since approximately May 2018. Please follow the full install instructions to reinstall the Azure CLI and update your signing keys.


Sample App Crashing in a different way

So I changed the name to TimeClock and now everything goes fine until rake newclear. I get to the install and start steps (after many a fine compiler warning) and then the app crashes.
Since I wasn't sure about a possible device / genymotion conflict. I tried on both with rake and rake device. I followed all of the steps on the first page (gradle:install, API 16 etc) but at the end of the day this is what I get:
KC:TimeClock$ rake device
   Install ./build/Development-16/TimeClock.apk
5401 KB/s (7723878 bytes in 1.396s)
     Start com.your_company.TimeClock/.PMHomeActivity
--------- beginning of /dev/log/main
--------- beginning of /dev/log/system
  open fragment: #<HomeScreen:0x34d00051>
E/dalvikvm(23974): VM aborting

What to do ?

Not sure without looking at the code.
I'll tell you what though.  I've actually seen Genymotion get into some funky states.  Especially when I start changing the name of app or package name.
I have no explanation, but what I've found sometimes is to remove the Android app entirely from the emulator.
Give that a shot.

After a refreshing sleep...  I think this is related to #94 .  Are you running RM 4.0?

Not sure without looking at the code.

I should have been more clear: I don't have any custom code yet. This is crashing on just
$ bluepotion create TimeClock
$ cd TimeClock
$ bundle
$ rake gradle:install
$ rake newclear

By crashing I mean that rake newclear rake and rake device (for the sake of touching nothing, not even the Rakefile) with my device or with Genymotion (both with no copy of TimeClock on them) all fail after Start, and none of them give a reason why.
My device at least installs TimeClock, but on Genymotion I don't even see an icon indicating it installed (in spite of terminal output to the contrary).

Especially when I start changing the name of app or package name.

Since I didn't have any code, I just created a new package from scratch rather than trying to change the app name.

remove the Android app entirely

On my device I tried that to no avail, but in Genymotion it wasn't even getting an app onto the device!

Are you running RM 4.0

:eyes:  yes

This is fine now by the way. Just RM issues I guess.

w00t


Refactory how locale is handled

Sets english on /en
Redirect / to /en
Removes a lot of “if” on the code
Prepare for a new locale

Sorry, because I was using master instead of opening a new branch for each implementation, this PR becomes mixed with previous commits.

Thank you very match


AppMap CI

This rebases and fixes https://github.com/getappmap/appmap-intellij-plugin/pull/369 to create a working CI setup with the GH AppMap action.
It's based on https://github.com/getappmap/appmap-intellij-plugin/pull/367, which could be merged first to simplify the review of this PR.

@kgilpin Your changes look good to me. If you think that this PR is doing what it should with AppMap analysis, then feel free to merge :)


GH-253 Include registered autoloads in all actions menu

Fixes #253

Applied to main (=2.1) and branch 2.0.


finish #1885

Description

Related Issue

close #1885
Checklist

[X] The target PR branch is develop branch

Rollback StreamCopyWorker
Use Command in GamePackageOperationViewModel


Storage Rebase

This is a rebase of the storage branch on top of current master.  Master's received a number of changes, some of which are storage related (eg: ciao-cli's image support) and ought to be in the storage branch for dev/test consistency.

Coverage increased (+0.1%) to 64.835% when pulling c0987fd6abd55dfa5cf56081d9d62edcf9524821 on tpepper:storage into fd0ea1db30287e775571ccb0d30a95d6cc8dcc25 on 01org:master.

wrong PR direction


Update Location Service

Open Weather Map Geocoding Not Accurate
the openWeatherMap API doesn't return the name correctly in the API response there is a name property in the response referring to the city, in the API you give it the lat &  long and it will return the name of the current location
https://api.openweathermap.org/data/2.5/weather?lat={lat}&lon={lon}&appid={API key}

so replacing the city name that came from the response with a local one using the geocoding package and it works perfectly
Location Service Disable Handling

[x] Create the required UI
[x] The logic has been handled it seems like works on the emulator
[ ] Need to test it on a real device

The tests have been completed and the results indicate that everything is functioning properly.

[x] Need to test it on a real device


add_sanitation_facility_jmp_cat() miscategorizes improved and not shared facilities

returned NA, when "sanitation_facility_cat" is "improved and "sharing_sanitation_facility_cat" is "not_shared"
see :

Test updated f13c646a526f06a4999340c7b42d45e299a7f6ff


Allowed origins

Awesome! A couple questions:

Does it work on localhost without having to add it here?
Wildcard or multiple domain support?

(Mostly asking so I can document it accordingly)

Awesome! A couple questions:

Does it work on localhost without having to add it here?
Wildcard or multiple domain support?

(Mostly asking so I can document it accordingly)

Haven't built it to work with localhost automatically, I can though? I can make it skip it in dev (for when building squeak), but that won't help user testing against Squeak cloud with localhost.
It's multi-domain


Option to display multiple accounts on main screen

I would love to be able to switch between my multiple accounts from the home screen, perhaps just with a row of small icons in the upper left where the "current" avatar is shown now. In an ideal world, I could choose which to display of the multiple accounts I'm connected to in the settings (ie. I may want to have four accounts connected but only three shown in the account switcher on the main page).

@rmacmich by "home screen", do you mean on the Home / Following timeline page?

I assume @rmacmich is asking for there to be an account switcher like:

in the place where the logged in account currently is shown with only one icon

this is something I dearly miss as well from elk:

@rmacmich @wakest just wondering how do you all using it now? Is it a desktop PWA app, mobile PWA app, desktop site on one tab or mobile site on one tab?

@cheeaun I use it on my desktop in a browser tab as well as a mobile PWA app.

@rmacmich I'm wondering, if on desktop, would it be more convenient to open multiple tabs with each tab logged-in to different accounts? As for mobile, it's also possible to install multiple PWA of the same web app, each logged-in to different accounts.

@cheeaun I am using Phanpy as my first pinned tab on Firefox. I don't think multiple tabs of Phanpy are really a solution here. It is very common to have multiple accounts and the need to switch between them frequently. Imagine everyone who has a project account and a personal account on the fedi. I would say it may even be a majority of frequent users of the fediverse to have at least 2 active accounts... One thing that I could imagine making this specific less important is just a keyboard shortcut to a user account switcher. I could imagine like the command tab interface on the Mac but for logged in accounts.


[backport/1.23] test: fixing a flake (#22328)

Fixes #22324
Signed-off-by: Alyssa Wilk<EMAIL_ADDRESS>Signed-off-by: Ryan Northey<EMAIL_ADDRESS>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

seeing https://github.com/envoyproxy/envoy/issues/22489 on this branch:
https://dev.azure.com/cncf/envoy/_build/results?buildId=120929&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&s=b2710bd9-3b3a-5a17-3102-13ba462a848c&t=1fb0b72f-6293-562d-a4d1-bb649223eaca&l=2970


Support declaring WebElementDescription via Attribute mode

Support declaring a WebElementDescription via attribute, the implementation is similar to Selenium Page Objects
@FindBy(how = How.CLASS_NAME, using = "classname")
private List<WebElement> singlecriterion;

In WebEngine .NET, it will be implemented with FindsByAttribute
[FindsBy(How = How.Id, Using = "element-id1")]
public WebElementDescription SubmitButton {get;} = new WebElementDescription();

Enhancement:

The presentation of an element is simplified for identifiable elements

Usage:

Supported locators can be either defined in FindsByAttribute, or via its properties
Use of FindsByAttribute is not mandatory
It is not recommended to declare WebElementDescription in both Property and Attribute.
If the same locator is defined in both Property and attribute, the value provided in attribute will be ignored.

Implemented in https://github.com/AxaGuilDEv/webengine-dotnet/commit/01f9231561f0d05fede8b3b1890c1b6ca824d512.
Usage:

In PageModel you can define ElementDescription with either class initializer or FindsByAttribute.
You can use multiple FindsBy on different locators.
in the following example, desc and descWithAttribute is identical.

        public class TestPageModel : PageModel
        {
            public TestPageModel(WebDriver driver) : base(driver)
            {
            }

            [FindsBy(How.ClassName, "class1 class2")]
            public WebElementDescription descWithAttribute { get; set; }

            public WebElementDescription desc { get; set; } = new WebElementDescription()
            {
                ClassName = "class1 class2"
            };
        }


In the IOS system, it is nonfluency！

In the IOS system, use browsers, browse lists, , it is nonfluency！

Android has no problem

Could you please put in another (or better) words. I'm not sure if I understand


Adding new subdomains to existing certificate

Are you in the right place?
I hope I am, as I am considering this a feature request I could not find by searching in the existing issues.
Is your feature request related to a problem? Please describe.
Currently there is no way to add subdomains to an existing certificate using the UI, unless I am mistaken. I would have to remove my existing certificate and reissue it with all previous subdomains including the new one. I haven't done that yet because I did not want to risk breaking my existing proxy settings and potentially have to edit each and set the certificate again after having it recreated.
Describe the solution you'd like
Ability to add one or more new subdomains to an existing certificate via the comfortable UI this project offers. Certbot itself is able to do so via expanding onto the existing certificate. This will renew it and also add the new domains. See https://certbot.eff.org/docs/using.html#re-creating-and-updating-existing-certificates
Describe alternatives you've considered
Dropping to terminal in my docker instance and manually interacting with certbot to do the expansion like I was doing it prior to switching to NGM as my reverse proxy. I do not plan to add subdomains very often but when I do, it would be nice to not have to it manually. Also I am not sure if NGM will actually pick up on the manual change, which is why I have not tried to do that yet.
Additional context
No extra context

Sorry, I couldn't find another way to upvote this enhancement proposal. But I painfully miss this feature, too. I've already made a cert expansion once, but it is pretty laborious:

Write down all the domain names in your existing cert.
Create a new cert request
Copy and insert all existing and new domain names one by one into the dialog (the dialog requires input validation for each domain separately).
Let certbot create a totally new certificate (which is not the recommended way due to the existing --expand option)
After creation, open each configured Proxy host or Redirect and edit its settings. Replace the old cert with the new cert and save.
If you have post hook processes (e.g. replicating the cert for your mail container), then you have to adjust your scripts, as the new certficate has been stored in a different npm- folder. If I'm not wrong...

Having an "Add subdomain" / "Edit subdomains" button would be a vast improvement for the whole process.

I use LetsEncrypt for a longer time and there is even no need to expand Certificate. You can simply add new domains to existing one with command via Changing a Certificate’s Domains:
certbot certonly --cert-name example1.com -d example2.com -d example3.com

Or remove from the Certification via:
certbot certonly --cert-name example1.com -d example2.com

So, basically there is ZERO changes in code, because you are using this feature already with domain separation via ,. What is missing is only Edit button.

👍

👍

👍


DropboxOAuth2Helper.ProcessCodeFlowAsync()'s state parameter is lost/ignored

Describe the bug
When invoking DropboxOAuth2Helper.ProcessCodeFlowAsync(Uri responseUri, string appKey, string appSecret, string redirectUri = null, string state = null, HttpClient client = null, string codeVerifier = null), the one with the state parameter, the state parameter is ignored/abandoned.
To Reproduce
Invoke the DropboxOAuth2Helper.ProcessCodeFlowAsync() (the one that includes a state parameter), and then check the State property on the response.  The states should be the same value as passed in but, instead, the value is null.
Expected Behavior
When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response should include the state.
Actual Behavior
When calling ProcessCodeFlowAsync() with a state parameter the returned OAuth2Response's State property is null
Screenshots
If applicable, add screenshots to help explain your problem.
Versions

What version of the SDK are you using?
v6.8 but I assume the problem has been around for some time.

Additional context
Notice that the OAuthPKCE sample does not test the state whereas the SimpleTest sample does.

Thanks! We'll look into it.


Initialize-ISHRegional sets incorrect registry key for 'Long Time' format #17

Issue #17
Replaced sLongTime with sTimeFormat

Bug fixed.


data missing after search

I just noticed that searching in a tree with the following search options:
search: {
	show_only_matches: true,
	show_only_matches_children: true
}

with a search query that results in a node with children (the children do not answer the query requirements) will result in the tree showing the correct nodes but the child nodes that are shown because their parent was found will not have the corresponding data in the other columns.
(I was thinking of setting up a jsfiddle but I couldn't find an online link to the jstree-grid.js is there somewhere where I can find the latest version for use in jsfiddle or should I request an upload on cdnjs?)
before searching (data from demo but I've increased the size of the grid a bit):

after searching (the line in the search at the end is my cursor):

filtering even further:

You can clearly see that the node "GrandChild" is missing its data

Not sure of or how I can contribute this directly (do I need to fork the project and then remerge projects? seems weird I would think that I'd need to create a new branch and and then commit that branch so you can review it and merge it with the master if it looks okay to you)
anyway around this point: https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L413
you'd need to have something link this:
if(this._data.search.smc) {
	data.nodes = data.nodes.add(data.nodes.find('.jstree-node'));
}

(maybe it is cleaner to use a new variable instead of overwriting but you get the gist of it.)

I was thinking of setting up a jsfiddle but I couldn't find an online link to the jstree-grid.js is there somewhere where I can find the latest version for use in jsfiddle or should I request an upload on cdnjs?

Definitely should request upload to cdnjs, but for fiddles, I just use the GitHub raw link directly.

anyway around this point: https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L413
you'd need to have something like this

I don't understand what you are changing here. Can you explain it?

anyway around this point: https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L413
you'd need to have something like this

I don't understand what you are changing here. Can you explain it?

sure. When the jssearch completes it will trigger the search.jstree event and will pass you the nodes it has found (so data.nodes are all the nodes that match the search query). currently you check the search settings to see if show_only_matches is true over here: https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L409. (Show_Only_Matches).
If this option is true you hide all data cells. then on https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L414 you'll add all parents of the matching nodes to the matching nodes and make each node visible.
What I do before this last statement is check if the  show_only_matches_children is true:
if(this._data.search.smc) {
    data.nodes = data.nodes.add(data.nodes.find('.jstree-node'));
}

(Show_only_Matches_Children)
If this is true I'll add the child nodes with the class '.jstree-node' to the matching nodes.
That way when you get to the next statement you'll add the parents and show those data cells.
The only thing I'm a bit unhappy about is that in my example I just save the matching nodes + children back in the data object nodes property. I feel like it would probably be safer to use a new variable where you first put the matching nodes in and later can add the child nodes to (if the option is true)

When the jssearch completes it will trigger the search.jstree event and will pass you the nodes it has found (so data.nodes are all the nodes that match the search query). currently you check the search settings to see if show_only_matches is true over here: https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L409. (Show_Only_Matches).

If this option is true you hide all data cells. then on https://github.com/deitch/jstree-grid/blob/master/jstreegrid.js#L414 you'll add all parents of the matching nodes to the matching nodes and make each node visible.

Yes, correct, makes sense. I probably should do it the other way round - find each node and hide only those that do not match, rather than hide all and then show matches - but good enough for now.

If this is true I'll add the child nodes with the class 'jstree-node' to the matching nodes.

So this just adds a previous step (could just as easily do it after), to add the children's cells as well, in addition to the matching row itself, which already is handled?
To some degree, I dislike replicating the show logic. I wish that data.nodes arg would return not just the matched nodes, but also all of the visible nodes. Then I don't need to search up or down for them, just add the cells for those nodes.
Conceptually, I like it. I think I want to change it slightly. Instead of adding children back and then matching rows' cells and parents, I would rather build one list and then add them. Same idea, just a bit cleaner.

The only thing I'm a bit unhappy about is that in my example I just save the matching nodes + children back in the data object nodes property. I feel like it would probably be safer to use a new variable where you first put the matching nodes in and later can add the child nodes to (if the option is true)

Agreed completely. I am going to close this in a minute in favour of a PR, which I will flag you on.

Instead of adding children back and then matching rows' cells and parents, I would rather build one list and then add them. Same idea, just a bit cleaner.

Never mind that. You already are doing that.

Closed in favour of PR.


Both Camera Positions

First of all great work.
I have managed to replicate your code as you have provided the relevant data. I still couldn't find what was the position of both cameras that are capturing the ball trajectories (in comparison to the court).
If you can either provide a sample video or point me in the direction of the position of both cameras with respect to the court.

Thanks!
If I understand correctly you are looking for the positions of the cameras in the demo. These are calculated in the Analyzer class during plotting using the factorizations A1 and A2 of the camera matrices (line 306-307). Hope this helps!

please provide sample video from both angles about what you are trying to convey about camera position as fast as possible.

I am not going to upload the videos in the demo if that is what you are asking.
The cameras should currently be placed somewhere on one side of the table each, and then the camera matrices will be calculated when you mark the six points of the table in the videos. These matrices include information about the camera positions relative to the table, and the positions are currently only extracted (calculated) from the camera matrices during plotting, as mentioned above.

Ill try again and let you know. The code sometimes made py1 py2 files and
didnt make other trajectory files in the data folder
Maybe the video is an issue
Thanks for the reply
On Wed, 12 Apr 2023, 21:32 Christoffer Kjellson, @.***>
wrote:

I am not going to upload the videos in the demo if that is what you are
asking.
The cameras should currently be placed somewhere on one side of the table
each, and then the camera matrices will be calculated when you mark the six
points of the table in the videos. These matrices include information about
the camera positions relative to the table, and the positions are currently
only extracted (calculated) from the camera matrices during plotting, as
mentioned above.
—
Reply to this email directly, view it on GitHub
https://github.com/ckjellson/tt_tracker/issues/4#issuecomment-1505540534,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUR6UAKJQ7K2SHMXZVH3TX3XA3GX3ANCNFSM6AAAAAATEH5SMI
.
You are receiving this because you commented.Message ID:
@.***>


Duplicated Quest

I added just 1 quest to the Miner and I set maxDailyQuests: 2
If I do /jobs quests I get this:

This is the quest:

1:
Name: "Rompi della pietra"
Action: Break
Target: "STONE"
Amount: 5000
RewardCommands:
- "acb [playerName] 400"
- "msg [playerName] Quest completata!"
RewardDesc:
- "Rompi 5000 blocchi di pietra"
- "Ottieni 400 blocchi di claim!"
Chance: 80
fromLevel: 41

Try restarting your server and the computer because this is minor Java bug.

It happens when I modify the quest on jobConfig.yml and then do /jobs reload.

@montlikadani - not sure why this won't be fixed as I've also been using /jobs reload a lot during editing configuration files.  That's been a feature supported for quite a long time.  Are we saying that with Quests (or other changes to jobConfig.yml) that the /jobs reload will no longer work?  Just trying to get a sense into what's broken or wont be fixed.  Thanks! -Steve


Fix test “should cancel a redeem request”

The skipped test in redeem.test.ts needs a rewrite:
We want to ban one vault (one specific collateral currency), and check that the other currency for a vault with the same account id is still active.

This test was removed here: https://github.com/interlay/interbtc-api/pull/575/files#diff-1cb48d1bc778727f45d06bb984462c58e5fcd9be803860ad5c647489c95965dd


v0.1.0 → v0.1.1 update in latest IntelliJ CE broke the theme

It's all white now, with dark text.

My bad, sorry. Figured it out.

Mine did this too!  When it updates, it flips to a light theme.  I am still trying to understand why.  This version of Intellij also changed the way my clipboard works with IdeaVim.  In any case, setting the color scheme to Zenburn fixed it for me.  Sorry.  I don't know what I can do to make this not happen.

Right! What helped in my case, was a "reset to defaults" for the theme.
Thanks a lot for the IntelliJ plugin btw, @smashedtoatoms ! Zenburn is the best; use it in all my editors.

I tried to set and reset the theme, but it's still broken for me. I'm running Rider 2023.2.2.
Any additional tips to fix this? I really don't want to use any other themes.

Downgrading Rider to 2023.1.4 solved the issue for me.


References to obsolete 'fixed' and 'shared'

Ehcache documentation  still refers to "fixed" and "shared" instead of .clusteredDedicated and .clusteredShared in the description

Fix needs to exist in release/3.1 as well.


Namespace

We attach FDEM to everything (it is a bit of overkill). What do you guys think of:
Sources:
EM.FDEM.SrcFDEM.SrcFDEM_MagDipole --> EM.FDEM.Src.MagDipole
Receivers:
EM.FDEM.RxFDEM --> EM.FDEM.Rx
Problem:
EM.FDEM.ProblemFDEM_b --> EM.FDEM.Problem_b
Fields:
EM.FDEM.FieldsFDEM_b --> EM.FDEM.Fields_b
@rowanc1 @sgkang @grosenkj

Sounds reasonable. What happen when we use same module on time domain? For example, we may share some sources in TDEM.
Cheers,
Seogi
Sent from my iPhone

On 12 Jul 2015, at 5:44 am, Lindsey<EMAIL_ADDRESS>wrote:
We attach FDEM to everything (it is a bit of overkill). What do you guys think of:
Sources:
EM.FDEM.SrcFDEM.SrcFDEM_MagDipole --> EM.FDEM.Src.MagDipole
Receivers:
EM.FDEM.RxFDEM --> EM.FDEM.Rx
Problem:
EM.FDEM.ProblemFDEM_b --> EM.FDEM.Problem_b
Fields:
EM.FDEM.FieldsFDEM_b --> EM.FDEM.Fields_b
@rowanc1 @sgkang @grosenkj
—
Reply to this email directly or view it on GitHub.

There is still some work to be done to figure it out for the time domain, but I think we can use the same structure / namespace, ie for a TDEM source: EM.TDEM.Src.MagDipole instead of what it is currently. (We may be able to have the TDEM and FDEM sources inherit from the same base class?)

or do we want:
EM.FDEM.Survey.Rx
EM.FDEM.Survey.Src.MagDipole
(similar for TDEM)
?

I prefer the past one.
2015-07-17 8:15 GMT+09:00 Lindsey<EMAIL_ADDRESS>
or do we want:
EM.FDEM.Survey.Rx
EM.FDEM.Survey.Src.MagDipole
(similar for TDEM)
?
—
Reply to this email directly or view it on GitHub
https://github.com/simpeg/simpegem/issues/29#issuecomment-122128342.

Yeah, I like them under something other than survey. Like your first setup.

will do!

Another one for you all:
There are a lot of derivatives to keep track of, but it boils down to taking derivatives wrt the model, m, and the field we compute, u. My suggestion is that any time we create a thing, ie. getA, we should specify which derivative we are taking: ie. getADeriv_m. This becomes important when taking derivatives of fields in the fields object as aliased fields have (potentially) derivatives wrt both m and u.
So basically any time "Deriv" is used, it should be followed by either "_u" or "_m". What do you guys think?

Makes sense as we are talking about the function c(m,u). Would clear a lot
up for me in the flow code.
On Thu, Jul 23, 2015 at 4:04 PM Lindsey<EMAIL_ADDRESS>wrote:

Another one for you all:
There are a lot of derivatives to keep track of, but it boils down to
taking derivatives wrt the model, m, and the field we compute, u. My
suggestion is that any time we create a thing, ie. getA, we should specify
which derivative we are taking: ie. getADeriv_m. This becomes important
when taking derivatives of fields in the fields object as aliased fields
have (potentially) derivatives wrt both m and u.
So basically any time "Deriv" is used, it should be followed by either
"_u" or "_m". What do you guys think?
—
Reply to this email directly or view it on GitHub
https://github.com/simpeg/simpegem/issues/29#issuecomment-124261968.

This issue was moved to simpeg/simpeg#153


UI fixes

Refers to https://github.wdf.sap.corp/ux-engineering/tools-suite/issues/23834
done:
1, 3, 4, 5, 6
still to do:
2, 7
plus:
add value help for visual filters/compact filters

Open questions:

how can I rename the (default?) measure "sum prices"?
how do I get reasonable value helps for visual filters status and airline?

how can I rename the (default?) measure "sum prices"?

Could you please explain what you mean? The property name or the label seen in runtime?

how do I get reasonable value helps for visual filters status and airline?

Value Help for Status:

Expose BookingStatus as a projection in analytics-service.cds
 entity BookingStatus as projection on my.BookingStatus

You can use the Page Editor to add a value help for the compact filter Booking Status in the Display Type property.

The resulting annotations look as follows:
annotate service.Bookings with {
    status @(Common.ValueList : {
            $Type : 'Common.ValueListType',
            CollectionPath : 'BookingStatus',
            Parameters : [
                {
                    $Type : 'Common.ValueListParameterInOut',
                    LocalDataProperty : status,
                    ValueListProperty : 'code',
                },
            ],
        },
        Common.ValueListWithFixedValues : false
)};

Value Help for Airline:
Same as p2 above. You can add additional information to the results list.

The resulting annotations:
annotate service.Bookings with {
    airline @(Common.ValueList : {
            $Type : 'Common.ValueListType',
            CollectionPath : 'Airline',
            Parameters : [
                {
                    $Type : 'Common.ValueListParameterInOut',
                    LocalDataProperty : airline,
                    ValueListProperty : 'AirlineID',
                },
                {
                    $Type : 'Common.ValueListParameterDisplayOnly',
                    ValueListProperty : 'Name',
                },
                {
                    $Type : 'Common.ValueListParameterDisplayOnly',
                    ValueListProperty : 'CurrencyCode_code',
                },
            ],
        },
        Common.ValueListWithFixedValues : false
)};

how can I rename the (default?) measure "sum prices"?

Could you please explain what you mean? The property name or the label seen in runtime?

In the settings for the chart, for example: there is a default measure "Flight Price" which I'd prefer to be called "Total price"
-> is there a way to change that name?

@stewsk

In the settings for the chart, for example: there is a default measure "Flight Price" which I'd prefer to be called "Total price" -> is there a way to change that name?

If the measure label is defined on the same app, you can change it directly in the Properties pane of the Page editor. Just enter a new text in the label field and put the cursor out. Then you can click on the Globe button to prepare it for translation:

If the measure label comes from the different app, you cannot change it from the Page Editor UI for the current app to avoid cross-app dependencies. You can change it from the app it is defined in or just navigate to the source code and change it there manually.

Please keep in mind that if it is a custom measure based on the property, the changed label will apply to all occurrences of the field unless a different label is applied for that occurrence (e.g. column name).

I believe it makes sense to use the transformation measures for the standard aggregation methods like sum:
  Analytics.AggregatedProperty #sumPrice :
   {
    Name                 : 'sumPrice',
    AggregationMethod    : 'sum',
    AggregatableProperty : price,
    @Common.Label        : 'test'
  }

In that case you will not have such an unwanted side effect. But I'm not sure if you still need a custom aggregate for the KPI


Support ignoreRevs on Collection.delete() calls

The HTTP API for ArangoDB supports revision checking on document removal via the If-Match header:
https://www.arangodb.com/docs/stable/http/document-working-with-documents.html#removes-a-document
However, the ArangoJS API doesn't expose this option.  It should be exposed similar to how Collection.update() calls used to work prior to 7.x.  Or, at least, how they're supposed to work (#707).

I'm closing this as a duplicate of #707 as that issue provides more additional information and the solution seems to be to re-implement the if-match header from v6.

I'm closing this as a duplicate of #707 as that issue provides more additional information and the solution seems to be to re-implement the if-match header from v6.

I'm not sure this should have been closed.  I don't know if Collection.delete() on ArangoJS ever supported revision checks via If-Match.  #707 is a bug ticket.  I had submitted this as a feature request.  Just want to make sure we're tracking the distinction.

I'm not sure this should have been closed.  I don't know if Collection.delete() on ArangoJS ever supported revision checks via If-Match.  #707 is a bug ticket.  I had submitted this as a feature request.  Just want to make sure we're tracking the distinction.


dynamic linkage issue

Using Firebase through Cocoapods I receive the following error
dyld: Library not loaded: @rpath/FBLPromises.framework/FBLPromises
  Referenced from: /Users/<Me>/Library/Developer/CoreSimulator/Devices/36EADE97-65F3-4E85-AEED-E73CDED046E4/data/Containers/Bundle/Application/A89E5B88-D246-49CE-9BC0-EC7669AC1902/Remind101.app/<MyApp>
  Reason: image not found

This appears related to FBLPromises.framework/. The solution here suggests using static linkage https://github.com/firebase/firebase-ios-sdk/issues/4889#issuecomment-596147745 however, this is not acceptable in our application on it's own, since multiple other dependencies require dynamic linkage.
It appears that podspec may have a flag to enforce static linkage https://guides.cocoapods.org/syntax/podspec.html#static_framework . Is it possible that you need to add this? I do not see it in the

Hey, thanks for reporting.
I tried to repro but was unable to. Here were my steps:

create new app
Add these to Podfile:

pod 'Firebase/Analytics'
pod 'Firebase/Auth'
pod 'Firebase/Firestore'

Run pod install
Add the following to AppDelegate:

import Firebase

// in ...didFinishLaunching...
FirebaseApp.configure()

Ran app in simulator

Do you have more specific instructions on how to repro?

Closing for now (unable to repro). Please re-open if you are able to provide additional details. Thanks.


Does this expand an already existing service
No
Link to a game or software
https://store.steampowered.com/app/2646460/Soulmask/
Links for the download
https://steamdb.info/app/3017310/info/
Links for the install docs
https://soulmask.fandom.com/wiki/Private_Server

https://github.com/pelican-eggs/games-steamcmd/tree/main/soulmask
already added some days ago?


ValueError... at json.load(cache_file)

Traceback (most recent call last):
  File "./python3.3/threading.py", line 901, in _bootstrap_inner
  File "./python3.3/threading.py", line 858, in run
  File "C:\Users\Ivan\AppData\Roaming\Sublime Text 3\Packages\Gulp\gulp.py", line 220, in run_process
    process.run(task)
  File "C:\Users\Ivan\AppData\Roaming\Sublime Text 3\Packages\Gulp\cross_platform_process.py", line 41, in run
    ProcessCache.add(self)
  File "C:\Users\Ivan\AppData\Roaming\Sublime Text 3\Packages\Gulp\caches.py", line 40, in add
    cls.storage().update(lambda procs: procs + [process] if process not in procs else procs)
  File "C:\Users\Ivan\AppData\Roaming\Sublime Text 3\Packages\Gulp\caches.py", line 132, in update
    current_data = json.load(cache_file)
  File "./python3.3/json/__init__.py", line 271, in load
  File "./python3.3/json/__init__.py", line 316, in loads
  File "./python3.3/json/decoder.py", line 351, in decode
  File "./python3.3/json/decoder.py", line 367, in raw_decode
ValueError:

Solution
I was getting the error, after some debugging I found out the problem is that the json cache file this plugin uses was corrupted, the one at %userprofile%\AppData\Roaming\Sublime Text 3\Packages\Gulp\.sublime-gulp.cache so I deleted its content and put the default .sublime-gulp.cache content, meaning just [] (yeah, only those 2 characters in the file).
If you cant find the corrupted cache file open caches.py and add print("PATH: " + self.cache_path); so you can see its path in the console (View > Show Console)
Good luck

Thanks a lot for posting your solution. I'll keep it in mind for future issues!

@NicoSantangelo the file seems to be constantly getting corrupted somehow


Rewrite sys module declaration

I replaced the cfg attributes with the cfg_attr. It doesn't really change anything, just looks a little more neatly.

@jayvdb, fixed the conflicts, I hope didn't break anything else in the process.


consider making the github api calls with a dedicated library

such as https://github.com/PyGithub/PyGithub

at the moment the calls are quite simple, no need for introducing a new dependency


Enable forcing useLayoutEffect when using alternate renderers

useLayoutEffect does not work with server-side rendering, and so a warning is displayed if it is used under Node. To get around this warning, useIsomorphicLayoutEffect tries to detect if the environment is not a browser (via the absence of window.document.createElement, etc) and falls back to useEffect if the check fails. Unfortunately, this may cause issues for alternate renderers that run in Node but are not using server-side rendering, such as react-blessed or Ink, and rely on useLayoutEffect to ensure store subscriptions happen at the appropriate phase of rendering.
This PR makes available a function forceUseLayoutEffect exported from alternate-renderers. A client of the react-redux library can call this to force use of useLayoutEffect in any environment.
import { forceUseLayoutEffect } from 'react-redux/alternate-renderers'
//...

forceUseLayoutEffect()

Implementation notes:

Because calling forceUseLayoutEffect() is dynamic and will happen after all of the module files are evaluated (thanks to ES module imports), a getUseIsomorphicLayoutEffect dynamic getter is provided and existing imports and calls to useIsomorphicLayoutEffect are replaced with calls to the getter
Dynamic importing (import(...)) is enabled via a babel.config.json file, as dynamic importing is necessary to mimic different import-time environment conditions for testing

Noticing that in TravisCI a test fails with
TypeError: _vm(...).SyntheticModule is not a constructor

I had this issue locally before providing a babel.config.json to enable dynamic imports. Not sure how to make TravisCI pick this up, or does it need to be configured in a different way (package.json, etc)?

Noticing that in TravisCI a test fails with
TypeError: _vm(...).SyntheticModule is not a constructor

I had this issue locally before providing a babel.config.json to enable dynamic imports. Not sure how to make TravisCI pick this up, or does it need to be configured in a different way (package.json, etc)?

This is impressively causing Node to segfault, so is there some looping going on in the tests? That's usually the cause of those kinds of hard crashes.
@markerikson Did you want to take a look at this? I consider this more "your" code, since you implemented it originally IIRC.

Yeah, I asked for this PR, and i do want to look it over. I've just got a lot going on atm and don't have the mental capacity to do so right now.  Will try to, Soon (TM) :)

It is strange that it's seg faulting, before the error was TypeError: _vm(...).SyntheticModule is not a constructor  (which I also experienced locally when babel-plugin-dynamic-import-node was not ini the env:test config in .babelrc). There are no loops or circular logic, and the additional test coverage for forceUseEffect is structurally identical to forceUseLayoutEffect. That said upon looking I noticed I forgot to export forceUseEffect from alternate-renderers, and additionally the @babel/plugin-syntax-dynamic-import plugins entry is not necessary, only  the babel-plugin-dynamic-import-node entry in env.test.plugins so I'll push those changes

My inclination here is that we don't want to allow switching between useLayoutEffect and useEffect after the app has started up.  I don't see any benefit to doing so, and it feels potentially confusing.  Also, right now, we're adding in a couple extra function calls every time even though the odds of this ever changing are practically zero.
Problem is, I'm not sure how to restrict that.  If we call the getter before the hook is defined, then the file probably gets imported and loaded well before your entry point has a chance to import and call forceUseLayoutEffect(), and the call sorta ends up being useless because we already got a handle to useEffect before you could override that.
I suppose we could add yet another ref to store that hook reference, but it feels like a waste.

Heh, this never did get merged. I believe it's obsolete as of v8 because we switched to useSyncExternalStore.


align NPM_TOKEN with registry used by the project

when the .npmrc defines the target registry as the github registry, use GITHUB_TOKEN instead of NPM_PUBLISH_TOKEN for the NPM_TOKEN used by semantic-release

also consider that the registry will likely only be set for the scope of the package for the current project, rather than redefining the overall registry


Naming of options button

Should we rename the options button? It doesn't give any options in its current state, so we could be better off with renaming it.

We had a quick chat about this, and it's actually quite appropriately named. What exists in the options is purely for people responsible for the event and provides some options for changing which event the client is currently at.


Best practice to use validator in high traffic web service?

Package version eg. v8, v9:
v9
Issue, Question or Enhancement:
What's the best practice to use validator for a web service that has high traffic?
Code sample, to showcase or reproduce:
// The following code works.
// However, calling New() for each income request doesn't seem to be efficient.
// Another thing I'd like to avoid is global variable.
// Is there any solution to create validator as "static member variable" or "singleton"?

err := validator.New().Struct(mystruct)

I think you need pools to cache it.

@laughmetal @thinkgos you should not call validator.New() but create a single instance and reuse it in your service.
Validator has an internal cache for struct parsing & information already and is completely thread-safe.
I won't go into the details of how to share it around, that's really up to what framework your using and how you want to inject context or ther dependencies.

Thanks for the inputs @thinkgos @deankarn !
Creating a single instance for the service was exactly what I did.
Closing this question.

got it ,thanks.


Dummy PR

A new configuration was created for openacademy80 with task id t950_011. You can deploy it here.

WARNING: Could not create a deploy configuration. Task ID not found in the title of the PR, supported formats:
{ task type }#{ number }
{ task type }{ number }

Available task types: task, t, vx, issue, i, us, hu (case insensitive)
Examples:

task#123

Issue123

US#123

The instance created for openacademy80 with task id t950_011 has been deleted.

A new configuration was created for openacademy80 with task id t950_012. You can deploy it here.

The instance created for openacademy80 with task id t950_012 has been deleted.


Validation error, add certificate to load balancer

Rancher versions:
rancher/server: 2.0 beta
Infrastructure Stack versions:
Kubernetes 1.8.10
Steps to Reproduce:

Open existing load balancer (already contains 2 service backends, dex-idp and whoami, default namespace)
Edit load balancer
Add new certificate
Choose certificate
Save

Results:
Validation failed in API: Ingress.extensions "lb1" is invalid: [spec.rules[0].http.backend.serviceName: Invalid value: "default/dex-idp": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?'), spec.rules[0].http.backend.serviceName: Invalid value: "default/whoami": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?')]

The error doesn't occur, without certificate.
Perhaps related to #12334

I can confirm this. Happens when the ingress already has a certificate, too.

create ingress with certificate -> saves successfully
edit that ingress (e.g. just change the target port) -> saving throws above mentioned error.

So editing an ingress seems broken when it already has a certificate set or you're going to add one.

This issue should be fixed as UI now filters out workload/services from the different namespace (k8s doesn't support cross namespace linking for ingress services). With services/workload only from the same namespace, the issue should be gone.
@sangeethah @soumyalj can we re-test on the very latest.

Tested with latest build from master.
This issue is still reproducible:
Create a Ingress that has "Target Backend" set to "Service".
Edit load balancer and add a certificate to this ingress.
Ingress update fails with following errors:
Validation failed in API: Ingress.extensions "mynewcheck" is invalid: spec.rules[0].http.backend.serviceName: Invalid value: "default/santest1": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

Ok, here are the most simple steps to repro:
create ingress with service
Click edit. Do not change any params, just hit save.
I've tried by modifying the path for service based ingress; there issue doesn't happen. NO issue is present for workload based ingress either.

Tested with latest build from master.
This issue is still reproducible:
Create a Ingress that has "Target Backend" set to "Service".
Edit load balancer and add a certificate to this ingress.
Able to add certificates successfully.


Promisify auth methods

To make the flow clearer.  Have not tested LDAP login, but it should be same as old one.

@metsjeesus, could you rebase this on master please? You should see some CI failures around linting after that (same with #1235).

I feel ive done something wrong. Git and github is hard.

 There are multiple ways to do that, but this one should fix your commit entanglement above.

I probably do something differently.

My working copy is cloned from lounge repository git clone https://github.com/thelounge/lounge.git. So origin will be thelounge repo.

I add my repo git remote add metsjeesus https://github.com/metsjeesus/lounge.git

I checkout base branch git checkout xpaw/safer-auth-flow

I generate new branch git checkout -b metsjeesus/promisify-auth

After code is added, push it to my github repo git push metsjeesus metsjeesus/promisify-auth --force

What i think the problem is, I dont use master as base branch, what means ./node_modules/.bin/eslint . --fix fixes and commits all the eslint changes what xpaw/safer-auth-flow dont have.

Closing for the same reason as in https://github.com/thelounge/lounge/pull/1235#issuecomment-314083457


Add classes to animated elements

It would allow setting the color directly from CSS.

Could we now reconsider this?

@andreyvolokitin What class(es) do you think should be added? I believe it's already possible to target the spinner lines in CSS via .spinner > div > div.

It's possible, but I think only with a help of !important (which is generally a bad practice), since all styles are applied inline currently. I thought about at least 1 class for changing a color of spinner lines (something like .{className}__line), but I'm not familiar with spin.js specifics and maybe more classes could be helpful.
On the other hand, maybe .spinner > div > div with !important wouldn't cause any problems and could be sufficient...

maybe .spinner > div > div with !important wouldn't cause any problems and could be sufficient.

I actually do this myself in a couple projects (in order to override the spinner color when dark mode is enabled). I don't think there's anything wrong with this approach. Even if there was a separate CSS class for the lines, !important would be necessary to override inline styles.

I thought that styles which are prone to change (like background-color) would become external in case of classes. If they remain inline there is indeed no point in classes

The styles are inline because they can be set dynamically in the spinner options (e.g. using an array of colors causing each line to be a different color).


⚠ ClamAV has degraded performance

In f532ae8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 6e3269c.


There is no "Asp.net Core" Application Type

In the documentation found here
https://github.com/Microsoft/ApplicationInsights-aspnetcore/wiki/Getting-Started
It tells you that you have to select the application type of "Asp.net Core" when creating a new Application Insights account.   There are four options in the drop down with one of them being "ASP.Net web application"  it is not clear which option you should select as ASP.Net and Asp.Net Core are not the same

The docs have been updated to say:
Create a new Application Insights resource. (Click New -> Monitoring + management -> Application Insights). Select the ASP.NET application type.

@dnduffy might want to close this


To fix a violation of this rule, change the return type to non-generic Task or, if the delegate is a route handler, cast it to Delegate so the return value is written to the response.

lol doesn't mean anything provide code

... and please follow the MS Code of Conduct. Just ask ... I'm sure the author will answer or work the issue for improved text.


Still being maintained

Is this project still being maintained? I haven't seen an update in quite some time now.

last stable release was on https://www.nuget.org/packages/ZXing.Net.Mobile.Forms/ . I don't think they are maintaining it properly. There are lot of issues to be address and the package is buggy :(


move common api functions to pkg/api

What does this PR do?
Move the common api machinery from cmd/agent to pkg/api so all components in cmd can use them.
Motivation
We'll need it for the cluster agent, figured I'd create a separate PR for it.
Additional Notes
Anything else we should know when reviewing?

🍰  and bonus 🍰  for the new security package!


Allow setting i18n.locales from collection

Is your feature request related to a problem? Please describe.
I would like to allow open editing of my documentation site, along with providing the tools to add additional translations.  From what I can tell, though, the locales setting (https://www.netlifycms.org/docs/beta-features/#top-level-configuration) is only allowed to be an array of string literals.
Describe the solution you'd like
I thought maybe I could add a locales list collection, and then point to that collection in i18n.locales, but that doesn't seem to work.
Describe alternatives you've considered
I'll need to add some instructions for contributors to manually edit the cms config to add the locale for the translation they want to add, I guess.  Which works, but it's a bit clunky and it doesn't let contributors work entirely within the CMS interface.

I think I've found a way to accomplish this.  I can create a locales.json file from a collection, import that json file and map the array into a list of locales, and use that within my netlify cms config that I pass to CMS.init({config});. It's a little roundabout, but it works!


Build stuck when work on ubuntu

Nuxt.js version 0.10.7
Node.js version 7.10
I used koa templete to build app, It's works well on windows, When i deploy the project to the server and run build, It's always stuck in 91%, No error message, And dev mode works well, How can i debug this?

@nothinggift You may have to await on nuxt constructor if upgraded to 1.0.0-alpha . (#754)

Well...

@nothinggift Is your problem resolved?

Yes, I downgrade Node.js to 6.10 and reinstall all dependencies, And then work properly.
But it's also stuck in 91% for a long time.

@nothinggift  I have the same problem,  Is your problem resolved?  My nuxt.js version 0.10.6

@chengwudji 已经确认了问题，是因为服务器剩余内存不足。

@nothinggift  我也在查，发现服务器4g内存 刚不住


ToolStatus: Added setting for auto focus to search box.

Hello @dmex.
This is my first try to contribute to open source project. In this pull request I've tried to make a enhancement for auto focusing search box as suggested in issue #521.
Forgive me if I made a mistake for my first pull request.
Best regards.

Thank you @dmex  for your feedback.
Hope dc388a9 this fix it.

@php940
Thanks!
I've approved the PR but I'm on the road and will be a few days before I can test it properly and merge it 👍


Linked up various new pages

fixes https://github.com/kubeflow/website/issues/609

This change is

Preview:

https://deploy-preview-624--competent-brattain-de2d6d.netlify.com/docs/pipelines/concepts/component/
https://deploy-preview-624--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/build-component/
https://deploy-preview-624--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/component-development/
https://deploy-preview-624--competent-brattain-de2d6d.netlify.com/docs/pipelines/sdk/best-practices/
deploy-preview-624--competent-brattain-de2d6d.netlify.com/docs/pipelines/reusable-components/

/lgtm
/approve


Monitor multiple IPs through/for a gateway

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
Is your feature request related to a problem? Please describe.
gateway monitoring only allows to monitor a single ip, limiting (smallscale) debugging.
You cannot always set up a dedicated system for something like smokeping, while you would still want to monitor connection quality.
Right now the issue is, when only being able to monitor a single IP for/through the gateway:
->if you monitor your next-hop, you do not know if you have packet loss behind your provider network. (so you might get a perfect looking graph, but internet quality is horrible)
-> if you monitor an internet location (say <IP_ADDRESS>), and you experience loss, you can't determine if it is your provider's network or somewhere on the internet itself.
(meaning you don't really have a way to communicate this to the provider without, again, setting up a dedicated machine or vm)
Describe the solution you'd like
the solution would be to be able to monitor both, and in doing so being able to compare graphs.
(or the CSVs, ofcourse)
From what i have found online it seems to be out of the scope for dpinger.
I suggest to create an option in the frontend to add an ip to monitor,
which would then do something like running a bash script to create and update the database with the ping results.
we could then show these results in a graph on the health page.
maybe adding the choice of which gateway to use for this ping on top would also allow for monitoring the quality of available links towards a certain target.
an added bonus (imho) would be having something useful that has been requested in the pfsense community for years without results. (adding yet another reason for people to choose OPNSense)

To be honest, network monitoring is likely better handled using zabbix or nagios (or a similar system).
Although I also misuse dpinger sometimes to monitor a specific host, it’s purpose from the firewall is mainly to take action when appropriate (demote gateways).
I think you can already add extra gateways with a low priority for monitoring purposes.

Alas, adding an extra gateway for monitoring is not possible (it does add, but then shows up as defunct)
I agree if you need full or extensive monitoring, you would need something else, however the idea here would not be full-blown monitoring, but rather confirming that:
A) the gateway is actually up, reachable, and has no packet loss and
B) it can actually reach the internet, and there is no packet loss there
the specific reason i am asking/suggesting this, is because i am in a situation where i am talking to my provider about packet loss, and it would help to be able to monitor both the gateway IP and the remote IP to find where the packet loss is actually happening.
as i said, it's always possible to set up a new machine just for this, but the reasons for preferring this on the firewall are, to name 2:
-> it is always the first in line (most reliable to do this simple quick testing)
-> it is always on anyway, meaning you don't have to leave another machine running
i would never ask or expect the firewall to be doing real network monitoring, but graphing some ping tests is something that i'd assume to be an acceptable thing for a firewall to do.
though this is not the case for me, i assume that, for example, in production environments where you manage client firewalls you would be able to use this to monitor their network connectivity and quality to follow up on specific issues a client might report (about packet loss),
since you would be unlikely to monitor their connection from your network (due to resources, dynamic ip, ...)
this way you would be able to get the results without having to tell the customer you will set up a monitoring and see what happens next week.

You can add these IPs as gateways and dont set upstream gateway. Also tick far gateway when not in range.
Usually you take smokeping for this :)

adding the IP to monitor as a gateway itself does indeed work, so i have done that now, which "solves" my current issue for monitoring the GW and and internet target but it's probably not really the best thing to do, so this request would make it somewhat more "clean" to monitor i suppose.
and integrating smokeping to opnsense is not desirable, while setting up a new machine (virtual or otherwise, which has to run 24/7 alongside your firewall) to monitor 1 extra IP would be overkill as well.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


feat: Add multi send option for queued transactions

What it solves
Resolves #3687
How this PR fixes it
We are adding a Batch Execute Button to the top of the Tx Queue. If there is more than one eligible transaction the user can opt to execute them with a single call to the MultiSend contract.
ToDos

[x] Handle Reject Transactions (multiple transactions for the same nonce)
[x] Add Unit Tests for BatchExecute and getBatchableTransactions
[x] Add Toggle to Settings page
[x] Highlight batchable transactions on button hover
[x] Add notifications on user interaction
[x] Add tracking for Batch Execute Button
[x] Add unit test for BATCH_LIMIT

How to test it
This needs to be tested with different Safe versions and on different networks where the MultiSend Contract might not be deployed i.e. Avalanche with a v1.1.1 Safe.

Open the Safe App
Queue up multiple transactions
Make sure that their nonces are in order and fully sign them
Observe that the Button should become enabled as soon as there is more than one eligible transaction
Click the Button
Observe that a modal opens with more details
Click Submit
Observe that MM opens with the correct MultiSend call
Click Confirm in MM
Observe that a pending state is added to the transactions

Analytics changes
Clicks on the Execute Batch Button are tracked with the number of transactions that are included in the batch.
Screenshots

Test Scenarios
Scenarios:
safe 1/1:
Batch tx with:

No txs  (not possible to excute in batch is expected)
1 tx nonces (not possible to excute in batch is expected)
2 tx nonces
2 tx nonces with more than 1 tx in the same nonce
2 tx nonces with one rejection
3 tx nonces
3 tx nonces with one of them guaranteed to fail
tx executed by a non owner

Safe 2/2: v1.3.0 and 1.1.1

Same as safe 1/1
2 tx nonces with only the 1st one fully signed
2 tx nonces with only the 2nd one fully signed (not possible to excute in batch is expected)
2 tx nonces. One of the nonces has 3 tx in parallel and the 1st one is fully signed
2 tx nonces. One of the nonces has 3 tx in parallel and all of them are signed
2 tx nonces. One of the nonces has 3 tx in parallel with one of them a rejection, all fully signed
3 tx nonces with the first 2 fully signed
3 tx nonces with 1st and 3rd one fully signed (not possible to excute in batch is expected)
4 tx nonces with 1, 2 and 4 fully signed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 104 (8.65%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 34.518%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Transactions/TxList/styled.tsx
0
1
0.0%

src/logic/safe/store/selectors/gatewayTransactions.ts
1
17
5.88%

src/routes/safe/components/Transactions/TxList/BatchExecute.tsx
3
81
3.7%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
3387

Relevant Lines:
8869

💛  - Coveralls

Request:
Can we update this branch to have the fix of #3751? is hard to test with that issue present here
1 - While tx are being executed (The pending status is shown in the tx in the queue list), you can still access the deep link view of one of the tx and see the Execute/reject button, and is in the "Needs execution" status.
The tx  in their deep link view should not show the Execute/reject buttons and should be in the pending status.
2 - This contract interaction with the safe itself sending 0 bytes is the rejection that can be seen in the background. Since is not obvious for the user, can we label it "rejection" or  something like that so is more obvious?

3 - The Execute batch button is not checking if a tx is fully signed and that now it can be used:
In a safe 2/2 create 2 tx, both different nonce, just signed by one person
Sign the 2nd one, makes it ready to be executed but it cannot since the 1st one is still not fully signed
Fully sign the 1st one without executing
Result: The batch button is still disabled after this, even tho now it should be possible to use it since all tx are fully signed. The user has to reload the page to see the button enabled and ready to use.
Another way to enable the button is to display the tx details once fully signed.
4 - In a safe 2/2 v1.1.1 I executed 3 tx in batch, with the 3rd one guaranteed to fail: the 3rd tx failed, but the first 2 succeeded. According to the message read in the modal, the first 2 should had failed as well.
Tested it in a safe 2/2 v1.3.0 and here it works fine, none of the 3 tx are executed, even tho the first 2 should be good to be executed.

Safe: https://pr3705--safereact.review-safe.gnosisdev.com/app/rin:0x51c125bb0D2FB3394129e4AAa97BbF91e737d9b2/transactions/history
Send me a message with a MM account so I can make you owner of a safe 2/2 v1.1.1
5 - The length of the tx are of different width. I think they should be the full width of the modal like the ones you see from tx created from apps.
It seems the legth in this case are given by the content of the tx, since the 2 seen in the snapshot have a short content in length they look like that
To create this tx, use this dummy contract with test methods in rinkeby 0x49d4450977E2c95362C13D3a31a09311E0Ea26A6 from the "contract interaction" form

From the tx builder:

6 - For safes 1/1, if there is a batch of tx where one of them is guaranteed to fail the MM popup knows that it will, but we don't show anything. Is it possible for us to know it as well and show it before hitting "review"?
Tested the same with safe 2/2 v1.3.0 and here MM did show the warning in the pop up
Also tested in safes 2/2 v1.1.1, but there the warning is not shown anywhere, so maybe the warning of "tx will fail" is something only safes 1.3.0 have.
The modal before reviewing:

The MM pop up knows the tx will fail:

Issue 3 is no longer happening. Mabye the merge of what dev has fixed it.

The Issue 1 was also fixed.

For safes 1/1, if there is a batch of tx where one of them is guaranteed to fail the MM popup knows that it will, but we don't show anything. Is it possible for us to know it as well and show it before hitting "review"?

Afaik our gasLimit estimation call only works for the next transaction in order. Not sure how MM gets around that but I propose that we should look into it separately for a future version of this feature.

I just realize that there is no way to edit the gas limit/gas price/gas fee of the execution batch. Are we going to leave that to the wallet's estimation? Some wallets don't have a way to edit those values like trezor and ledger.
Note: there is currently a bug were trezor and ledger are ignoring the amouts set by the user during safe review in the gnosis app, but still the question is valid I think
Regarding the correction of the message, I don't think is correct:
In safes 2/2 v1.1.1, if from 3 tx is the 3rd one the one that will fail, the first 2 are actually successfully executed. So the text "Be aware that if any of the included transactions reverts, none of them will be executed" is not correct.
This 4 tx where executed in batch. only the last one failed, the others executed just fine:

https://pr3705--safereact.review-safe.gnosisdev.com/app/rin:0x51c125bb0D2FB3394129e4AAa97BbF91e737d9b2/transactions/history
I've seen an issue where sometimes the listed tx in the review modal dissapear. I tried for a while but it only happened twice, but still hard to reproduce. It seems to happen for a specific batch but after you see it properly loaded the tx will always appear.
Try to reproduce it by creating brand new tx, executing in batch and wait in the "review" modal for a bit.


Us 12607 : new changes related to timeout pop on un-auth confirmation screen

These are the changes done according to the latest user story 12607 , where claimant will be having a timeout pop appearing on confirmation screen after submitting a claim.
Here claimant will be asked to either stay on same confirmation page or exit and go back to gov.uk page

Please make sure the following 3 scenarios are working correct
click stay on page button
click exit button
leave the msg to expire by itself.

Please make sure the following 3 scenarios are working correct click stay on page button click exit button leave the msg to expire by itself.

Yes Mody , done this now.


Swap with parent/child assist should work on single-child Flex

Use case
If you have a code like this:
Scaffold(
  body: Column(
    children: [
      Padding(
        padding: const EdgeInsets.all(8),
        child: Text('Hello'),
      ),
    ],
  ),
);

You already can remove the Column/Row because they have only one child.
Proposal
I'd like for the Swap with parent/child to work on single-child Flex so that, in cases like the above, I can place the Padding around the whole Column.
Aditional information
First filed at https://github.com/flutter/flutter/issues/149736

I created https://dart-review.googlesource.com/c/sdk/+/387862


allow .devfile.yaml

(not sure if this is part of kubernets-api for devfile but it should for sure be part of the devfile spec - let me know if any better place this issue)
originally opened at https://github.com/openshift/odo/issues/3126 and https://github.com/openshift/odo/issues/3126
Simply asking that .devfile.yaml should be allowed for the name of the devfile to allow it to be hidden by default and not take up "visual space" in projects that create these files.

@maxandersen you linked to the same 2 issues… 😄
That said, I'm ambivalent on this since I'm not sure the devfile should be hidden as it's potentially an integral part of the project.

That's not strictly speaking something that will be transled in a change in the OpenAPI spec. And Che at least already allow .devfile.yaml if the file is specified explicitely but it doesn't automatically discover it (it discovers devfil.yaml).
But I agree that we may formalize that in the spec somehow: tools that supports the spec should automatically discover devfile.yaml and .devfile.yaml when a git repo or a local folder is provided.

But I agree that we may formalize that in the spec somehow: tools that supports the spec should automatically discover devfile.yaml and .devfile.yaml when a git repo or a local folder is provided.

If we formalize that than we need to also define that tools need to error out when both .devfile.yaml and devfile.yaml are present.

if we formalize that than we need to also define that tools need to error out when both .devfile.yaml and devfile.yaml are present.

Right. Or define a precedence order.

Right. Or define a precedence order.

That will just lead to a lot of confusion
Let's say that I have a project that uses .devfile.yaml

Someone doesn't notice that there already is .devfile.yaml and adds new devfile.yaml
Now there are two devfiles and each might be different.
If tooling just priorities devfile.yaml over .devfile.yaml the users that are used to editing .devfile.yaml will get confused about why their changes are not being reflected or vice versa.

This won't create a good user experience.
I think that erroring out in case of both devfile naming styles is present is the only way to make sure that there is no ambiguity or confusion.

I think that erroring out in case of both devfile naming styles is present is the only way to make sure that there is no ambiguity or confusion.

You convinced me 👍

I would just print a warning rather than blocking users and error out.
But I'm fine either way.

Treat it the same as if you had a devfile.yml.

I see a new PR on Che https://github.com/eclipse/che/pull/17537

@l0rd, what is the documentation tasks here (I see you added the area/documentation label)?

@rkratky probably adding a paragraph about that in the devfile author guide

Based on the discussions, we'll support the .devfile.yaml. If both devfile.yaml and .devfile.yaml exists, then the tools will error out and let the user know that both files exist. We treat it as an error instead of a warning is to avoid any potential confusion on the user.
From the spec perspective, we'll:

add to the doc to specify this behaviour
check if the common library accepts a path (instead of including the devfile.yaml itself), then the parser will error out if both the devfile.yaml and .devfile.yaml exists at the specified path

Based on the discussions, we'll support the .devfile.yaml. If both devfile.yaml and .devfile.yaml exists, then the tools will error out and let the user know that both files exist. We treat it as an error instead of a warning is to avoid any potential confusion on the user.
From the spec perspective, we'll:

add to the doc to specify this behaviour
check if the common library accepts a path (instead of including the devfile.yaml itself), then the parser will error out if both the devfile.yaml and .devfile.yaml exists at the specified path

@maysunfaisal pointed out that the existing devfile library does not currently have limitations on the devfile file name as long as it has the .yaml extension. I think it is fine to keep it that way to provide flexibility on the library code.
Having said that, we still need to make changes to support this on the registry library/registry build tools. We currently have to find the location of the devfile when building the index.jsp as part of scanning through the list of stacks. So the index.jsp build tools will need to look for either devfile.yaml or .devfile.yaml and flag as an error on the stack if both files are found in the registry as part of the index.jsp generation that is being run as part of the registry build tools.
@GeekArthur Can you make the change on the registry index generator code?

@elsony Sure, I can do that.


Update README.md

Add a link to another source for USB-to-Serial console cables.

Ping @DouglasUrner


"Add" button on basal profile screen disappears when an 11:30 pm basal segment is added

Describe the bug
*When you add a basal segment commencing at 11:30pm, the "Add" button disappears and you are unable to add any further basal segments, regardless of start time. Work-around: Deleting the 11:30pm segment (or editing the start time to an earlier time) re-enables the add button, allowing you to create new basal segment. *
Attach a Log
see video
To Reproduce
Steps to reproduce the behaviour:

Go to 'Settings - Basal Profile'
Click on 'Add' to create a new basal segment, or edit an existing basal segment to start at 11:30pm
Scroll down to '....'
See error

Expected behaviour
*If there are basal start times that are unallocated (i.e. between 00:00 and 11:30pm, setting a basal segment start time at 11:30pm should not prevent you from creating earlier ones.*
Screenshots
If applicable, add screenshots to help explain your problem.
Setup Information (please complete the following information):
Smartphone:

Hardware: * iPhone 15 Pro Max]*
OS Version: iOS 17.7

Pump:

Any - confirmed on Dash and Simulator

Trio Version:

Version Number: 0.2.1 main
Repo: nightscout/trio

https://github.com/user-attachments/assets/bddc4bf6-46ea-42c3-9add-7ad945ddf75f

Would be nice if the add button would appear in between possible segments right? So instead of an add button on the bottom, it will appear in between entries that are more than 0:30 apart?
Or an add button on top and a dialog before adding it to the list?
Or would this be awful? Just a first thought? Any other recommendations?

From this FB post: https://www.facebook.com/groups/diytrio/posts/1685489575518224
I don't think this really needs fixing in 0.2.1, the workaround is probably enough until 1.0 is released?

This is not ‘fixed’ in 1.0 either. It’s better, but your ‘issue’ is still not possible and needs the same work around.

Bump


Fixed error in parking_sensors/scripts/deploy_infrastructure.sh where…

… the attribute for user id on the Microsoft Graph has changed from objectId to just id.
Type of PR

Code changes

Purpose
Yesterday I tried running the deployment and it failed as the objectId in the JSON returned by
az ad signed-in-user show --output json

has been renamed to "id". See https://github.com/Azure/azure-cli/issues/9506#issuecomment-1149942398
Does this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist

[ ] Added test to prove my fix is effective or new feature works
[ ] Made corresponding changes to the documentation

Validation steps

...

Issues Closed or Referenced

Closes #issue_number

References #issue_number

Thanks @Illuminae for this and appreciate the PR. There were a few other places in the repo which needed changing to accommodate for this change so I've went ahead and made those changes in this PR: https://github.com/Azure-Samples/modern-data-warehouse-dataops/pull/547.


java.lang.RuntimeException: Only triangles supported

i have an error while add my obj file instead of bus.obj

please help me

Hello Haris and thanks for using smartGL.
SmartGL handles only objects made of triangles, so you have to convert your object first.
You can try a tool like http://www.meshlab.net/ to re-export your object in Wavefront OBJ format.
When it is converted you should be able to use it with smartGL.
Arnaud.

try this:
cat my.obj | sed -E -e "s/f ([0-9\/]+) ([0-9\/]+) ([0-9\/]+) ([0-9\/]+)/f \1 \2 \3`echo -e "\r"`f \1 \3 \4/g" > my_tri.obj

thanks i will try it
On Thu, May 18, 2017 at 10:15 PM, dawjdh<EMAIL_ADDRESS>wrote:

try this:
cat my.obj | sed -E -e "s/f ([0-9/]+) ([0-9/]+) ([0-9/]+) ([0-9/]+)/f \1 \2 \3echo -e "\r"f \1 \3 \4/g" > my_tri.obj
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/smart-fun/smartGL/issues/4#issuecomment-302467298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbcSbtmiOcEnD9FVz_2aaW9JVtLtDFijks5r7HWMgaJpZM4NezM5
.

please provide detail for your solutions
On Thu, May 18, 2017 at 10:15 PM, dawjdh<EMAIL_ADDRESS>wrote:

try this:
cat my.obj | sed -E -e "s/f ([0-9/]+) ([0-9/]+) ([0-9/]+) ([0-9/]+)/f \1 \2 \3echo -e "\r"f \1 \3 \4/g" > my_tri.obj
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/smart-fun/smartGL/issues/4#issuecomment-302467298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbcSbtmiOcEnD9FVz_2aaW9JVtLtDFijks5r7HWMgaJpZM4NezM5
.

You can solve by importing your model in Blender, then exporting it ticking the "Triangulate Faces" option.


KUVA-418 | Add support for basic internationalization

Description
Adds support to three locales by default (some translations pending): fi, sv and en. Translations are implemented with a simple custom hook in order to avoid unduly powerful (and large) dependencies.
Motivation and Context
All (most) of our application can be used in three different languages. Supporting these out of the box makes the development experience smoother which will likely translate into a better UX for the users as well. For cases where the translations need to be changed or a new locale has to be added, support is also provided.
How Has This Been Tested?
I added a knob into the storybook environment which allows for manual testing.
Screenshots (if appropriate):

Can't test localization on storybook, playground crashes on start.

Thank you for trying out the playground!
I moved this PR on top of the develop branch, which included a force push. I also fixed the problem you were having:

The playground still assumed that the locale could be  an undefined
value and that the FeedbackForm component would replace it with a
sensible default. I changed locale to be a required value--because
setting it by default likely does more harm than good--but forgot to
fix the playground.


Use contrasting canvas text colors when changing to a light Interface theme to make it much easier to read

Describe the project you are working on
This relates to the editor so applies for any project across Godot v3.3 / v4
Describe the problem or limitation you are having in your project
When changing the Interface Theme to either of the following:
Light
Solarized (Light(
The magnification text on the 2D canvas shows black font color on a dark canvas making it very hard to see on the light themes.

Describe the feature / enhancement and how it helps to overcome the problem or limitation
Make the magnification text white colour, and, preferablly provide the option to change just the canvas text color on the Interface Theme page (for v3.x branch and v4). Such as the below option highlighted in red below:

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
After changing the canvas font colour to white (as shown in mockup above), the font colour change will look like below:

If this enhancement will not be used often, can it be worked around with a few lines of script?
No
Is there a reason why this should be core and not an add-on in the asset library?
This should be core because it is part of the main editor.

This is actually a bug, so I transferred it to the main Godot repository.
This is fixed by https://github.com/godotengine/godot/pull/42995 in master, but its 3.x cherrypick was undone because it caused a crash.

Okay sure, but is this expected to be fixed in v4?

Okay sure, but is this expected to be fixed in v4?

Yes, as master represents the current development state of Godot 4.0.

Okay sure, but is this expected to be fixed in v4?

Yes, as master represents the current development state of Godot 4.0.

Sounds good :)


Certificate pinner GitHub editing doc link broken

The edit button on https://square.github.io/okhttp/4.x/okhttp/okhttp3/-certificate-pinner/ links to https://github.com/square/okhttp/edit/master/docs/4.x/okhttp/okhttp3/-certificate-pinner/index.md, which returns a 404 error, i.e. it seems to be broken.
I could not find the correct file easily either.

Directly from source https://github.com/square/okhttp/blob/master/okhttp/src/main/kotlin/okhttp3/CertificatePinner.kt

Can I take it up?

I'd like to remove the edit links completely.


Adds model convertors to deal with pyodide issues

Adds a pooch processor to perform the necessary corrections to the HistGradientBoosting models to allow then to work in pyodide.
These should only run in that environment.

@stuartlynn if I resolve merge conflicts, is this mergeable?

Hey yup I think this should be good to go


Consider indirect sibling css selector in toggle

When extending the uui-toggle component, when you override the renderCheckbox() method, to keep the component working you cannot really add any sibling to #slider without breaking the component, as the #slider is no longer an adjacent sibling of input.
https://github.com/umbraco/Umbraco.UI/blob/89e0441bfb4ada1763e55a2351888e3feb4f9040/packages/uui-toggle/lib/uui-toggle.element.ts#L131
Would you consider changing the adjacent sibling + combinator to a general sibling ~ instead in any selector that targets slider and input?

That's a really good idea, @julczka. Would you consider making a PR for it?


Support recursive glob for path conditions

ATM a wildcard as path condition like docs/* would only match files in docs/file.txt, but not from subfolders like docs/sub/file.txt. This can now be archived by using docs/**, which would match  docs/sub/file.txt and  docs/sub/subsub/file.txt.
closes #324

@alexef How do you use recursive path conditions atm or have you simply avoided them for now 😉?  Could you have a quick look to this PR if it fits your needs as well?


video and audio slip out of sync

Have you read the FAQ and checked for duplicate open issues?
What link can we use to reproduce this?
https://v4-3-2-dot-shaka-player-demo.appspot.com/demo/#audiolang=ja;textlang=ja;uilang=ja;asset=https://7a5aa5b9.wurl.com/master/f36d25e7e52f1ba8d7e56eb859c636563214f541/UmFrdXRlbkpQLXdlYl9UcmF2ZWxYUF9DTUFG/playlist.m3u8;panel=CUSTOM CONTENT;build=compiled
What version of Shaka Player are you using?
v4.3.2
What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
What did you do?

This stream is restricted to Japan, please use a VPN to access it.
Watch the stream and usually within about 15 minutes, a video segment is repeated while the audio for the segment is not repeated. Because the .ts segments for this particular stream are 6 seconds in length, the audio sync issue is such that the audio is 6 seconds ahead of the video. When the stream goes into an ad break, the issue is resolved for a bit, but then it will eventually slip again. It's not a gradual slip of sync, rather, there will be a very jarring moment when the .ts video repeats and the audio is instantly out of sync. This happens on multiple streams, but we are only able to share this one stream.
What did you expect to happen?
The audio and video should remain in sync during playout.
What actually happened?

I have seen this problem yesterday with the demo player v4.4.1 with the following stream:
https://ztnr.rtve.es/ztnr/1694255.m3u8
Video was few seconds behind the audio after some time. Probably as mentioned above, video from previous chunk was played together with the audio from the current chunk (video and audio are multiplexed in the same .ts here).
I have seen it only once after having the Chrome playing in background for some time and activating it again. I couldn't reproduce it again yet.

@avelad @joeyparrish
I'm sorry, but I tried playing the video with the new version 4.4.3, and the issue still persists. The audio loop happens multiple times. Could you please check it?
Thanks.
https://v4-4-3-dot-shaka-player-demo.appspot.com/demo/#audiolang=ja;textlang=ja;uilang=ja;asset=https://7a5aa5b9.wurl.com/master/f36d25e7e52f1ba8d7e56eb859c636563214f541/UmFrdXRlbkpQLXdlYl9UcmF2ZWxYUF9DTUFG/playlist.m3u8;panel=CUSTOM CONTENT;build=compiled

@avelad I have the same issue still as well, can you let me know how to try with the main branch?

@avelad-san
Please help us resolve this issue.
Thanks!


High resolution rendering of multi-page PDF with swipeHorizontal enabled

In one of my tests, i have a multiple page PDF i am attempting to render with swipeHorizontal enabled (allowing for horizontal view of pages, side by side). When I am fully zoomed out (1) there is no problem, the quality is maintained between all visible content. However, when I zoom in (the issue occurs less at 1.75, and frequently at 3), the quality of all visible regions on the screen is not consistent. Some regions appear to be processed at the user's current zoom, while others are still processed without zoom (1). At times, slight movement causes the entire visible region to render without zoom (1). Is anyone else having this problem? (My test cases are just using double-tap for zoom, so DEFAULT_MIN_SCALE, DEFAULT_MID_SCALE, DEFAULT_MAX_SCALE)

Yes. Zooming creates many smaller segments and when you zoom out it keeps them. So eventually you run out of segments you are able to render and it removes the oldest ones. You then see the thumbnail mode behind the full renders.
Enable debug mode of your want to visualise the problem. My current hack fix is to empty the cache when it fills up and it makes all new grids that are much neater but it's not perfect.

Hi SlinkyRaptor, and how exactly did you implemented this hack?


bool comparison false positive

There are cases where we may want to test a value that may or may not be a boolean like so if v == true. Statix currently suggests I reduce this to if v.
If I do the reduction, and v is not a boolean, evaluation aborts with a type mismatch error. I could change it to if builtins.isBool v && v, but if v == true seems more concise in that case.

I could change it to if builtins.isBool v && v

I think that would make it obvious that the value might not be a boolean whereas v == true seems pretty redundant and also without statix could easily be factored out.

One is more explicit the other more concise, I guess my main concern is that if v == true and if v are not semantically equivalent.

would you have a few examples of this scenario? perhaps there are some heuristics to determine and avoid such cases.

@nerdypepper For a snippet like this:
let
  f = value:
    if <condition>
      then <first branch>
      else <second branch>;
in
f <argument>

The below is a table that shows the evaluation result when <condition> and <argument> are replaced with different values:

condition
value argument
evaluation result

value
true
<first branch>

value
2
error: value is an integer while a Boolean was expected

value == true
true
<first branch>

value == true
2
<second branch>

isBool value && value
true
<first branch>

isBool value && value
2
<second branch>

statix prints the following output when the condition is value == true:
[W01] Warning: Unnecessary comparison with boolean
   ╭─[default.nix:3:8]
   │
 3 │     if value == true
   ·        ──────┬──────
   ·              ╰──────── Comparing value with boolean literal true
───╯

The warning message suggests that value == true and value are equivalent but this is not true. value == true can be replaced with isBool value && value but not with value.

This is a function that I use:
# Imply that `cond` is not falsy, if it is,
# return `default` and otherwise `val`.
imply = cond: val: implyDefault cond null val;
implyDefault = cond: default: val:
  if (cond == null) || cond == false || cond == { } || cond == [ ] || cond == ""
  || cond == 0 then
    default
  else
    val;

Statiz wants to change cond == false to !cond, which is incorrect.


2.1.0 release notes and version bump

Could we add Ed's new docs? I've just merged them into master (#145). We'll need to update the download link in the installation instructions when we do the version bump.

no worries, but this release was ready 5 days ago - I dont think there's any value in delaying releases because of other features? You can just do another release whenever


Fix the intermittently failing tests in SCXA

This is a fix for a list of intermittently failing unit tests:

[x] uk.ac.ebi.atlas.search.ToBeDeprecatedJsonGeneSearchControllerWIT.whenSearchTermExistsInDBThenReturnsSetOfCellType
[x] uk.ac.ebi.atlas.search.organismpart.OrganismPartSearchDaoIT.whenValidCellIdsAndValidCellTypesProvidedReturnSetOfOrganismPart
[x] uk.ac.ebi.atlas.search.ToBeDeprecatedJsonGeneSearchControllerWIT.jsonPayloadContainsFacetDescription

@lingyun1010 @upendrakumbham
I needed to put this PR back to draft, as I found another intermittently failing test.
I am going to work on that one from now on.
Thanks

The 4th intermittent failing test is fixed now. I got a green build. ✅

@lingyun1010 I have already created it: Investigate ToBeDeprecatedJsonGeneSearchControllerWIT intermittently failing test


[ALLUXIO-2119] Centralize version checking test and avoid whitebox

https://alluxio.atlassian.net/browse/ALLUXIO-2119
The version checking functionality is in AbstractClient, so it makes sense to test it in AbstactClientTest

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10941/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10945/
Test PASSed.

@apc999 Comments addressed, PTAL


Refactor some repetition in iptables UDP rules

Just some cleanup, the generated iptables is identical

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
70b17449446f16459a3aa0571777ae9c91f680a8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Create loadbalancer-clb-securelistener.config

See https://github.com/awsdocs/elastic-beanstalk-samples/issues/127
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jpswade Sorry for the slow response.
There's an error in the file's path - you have ".../security-configuration/security-configuration/..." (repeating a path component). Please fix this and I'll promptly merge.

Done @dankhen


Do not fail Consul discovery on Prometheus startup when Consul is down.

Fixes https://github.com/prometheus/prometheus/issues/1707
When Prometheus is started, there is no datacenter option set in the config (consul_sd_configs section) and Consul is down, then Consul discovery will fail until Prometheus is restarted or reloaded.
The problem is when datacenter is not set, Prometheus tries to get it once on startup from Consul which is down and discovery fails to run at all.
I have moved the code for retrieving the datacenter name to retry loop below.
Current behaviour (fail on getting datacenter from agent/self endpoint, no retry):
time="2016-09-26T18:35:46Z" level=info msg="Listening on :9090" source="web.go:235"
time="2016-09-26T18:35:46Z" level=error msg="Cannot create Consul discovery: Get http://localhost:8500/v1/agent/self: dial tcp [::1]:8500: getsockopt: connection refused" source="ta
rgetmanager.go:386"

Now it is in the retry loop and will start once Consul is up:
time="2016-09-26T19:10:31Z" level=info msg="Listening on :9090" source="web.go:238"
time="2016-09-26T19:10:31Z" level=error msg="Error refreshing service list: Get http://localhost:8500/v1/catalog/services?wait=30000ms: dial tcp [::1]:8500: getsockopt: connection r
efused" source="consul.go:127"
time="2016-09-26T19:10:36Z" level=error msg="Error refreshing service list: Get http://localhost:8500/v1/catalog/services?wait=30000ms: dial tcp [::1]:8500: getsockopt: connection r
efused" source="consul.go:127"

Thanks 👍