Missing enum - create an enum from the description

URL Hash
#/sklearn/sklearn.impute._base/SimpleImputer/__init__/strategy
Expected Annotation Type
@enum
Expected Annotation Inputs
Enum with content:
"mean", "median", "most_frequent", "constant"
Minimal API Data (optional)

Minimal API Data for `sklearn/sklearn.impute._iterative/IterativeImputer/__init__/min_value`
{
    "schemaVersion": 1,
    "distribution": "scikit-learn",
    "package": "sklearn",
    "version": "1.1.1",
    "modules": [
        {
            "id": "sklearn/sklearn.impute",
            "name": "sklearn.impute",
            "imports": [
                {
                    "module": "typing",
                    "alias": null
                }
            ],
            "from_imports": [
                {
                    "module": "sklearn.impute._base",
                    "declaration": "MissingIndicator",
                    "alias": null
                },
                {
                    "module": "sklearn.impute._base",
                    "declaration": "SimpleImputer",
                    "alias": null
                },
                {
                    "module": "sklearn.impute._iterative",
                    "declaration": "IterativeImputer",
                    "alias": null
                },
                {
                    "module": "sklearn.impute._knn",
                    "declaration": "KNNImputer",
                    "alias": null
                }
            ],
            "classes": [
                "sklearn/sklearn.impute._iterative/IterativeImputer"
            ],
            "functions": []
        }
    ],
    "classes": [
        {
            "id": "sklearn/sklearn.impute._iterative/IterativeImputer",
            "name": "IterativeImputer",
            "qname": "sklearn.impute._iterative.IterativeImputer",
            "decorators": [],
            "superclasses": [
                "_BaseImputer"
            ],
            "methods": [
                "sklearn/sklearn.impute._iterative/IterativeImputer/__init__"
            ],
            "is_public": true,
            "reexported_by": [
                "sklearn/sklearn.impute"
            ],
            "description": "Multivariate imputer that estimates each feature from all the others.\n\nA strategy for imputing missing values by modeling each feature with\nmissing values as a function of other features in a round-robin fashion.\n\nRead more in the :ref:`User Guide <iterative_imputer>`.\n\n.. versionadded:: 0.21\n\n.. note::\n\nThis estimator is still **experimental** for now: the predictions\nand the API might change without any deprecation cycle. To use it,\nyou need to explicitly import `enable_iterative_imputer`::\n\n>>> # explicitly require this experimental feature\n>>> from sklearn.experimental import enable_iterative_imputer  # noqa\n>>> # now you can import normally from sklearn.impute\n>>> from sklearn.impute import IterativeImputer",
            "docstring": "Multivariate imputer that estimates each feature from all the others.\n\nA strategy for imputing missing values by modeling each feature with\nmissing values as a function of other features in a round-robin fashion.\n\nRead more in the :ref:`User Guide <iterative_imputer>`.\n\n.. versionadded:: 0.21\n\n.. note::\n\n  This estimator is still **experimental** for now: the predictions\n  and the API might change without any deprecation cycle. To use it,\n  you need to explicitly import `enable_iterative_imputer`::\n\n    >>> # explicitly require this experimental feature\n    >>> from sklearn.experimental import enable_iterative_imputer  # noqa\n    >>> # now you can import normally from sklearn.impute\n    >>> from sklearn.impute import IterativeImputer\n\nParameters\n----------\nestimator : estimator object, default=BayesianRidge()\n    The estimator to use at each step of the round-robin imputation.\n    If `sample_posterior=True`, the estimator must support\n    `return_std` in its `predict` method.\n\nmissing_values : int or np.nan, default=np.nan\n    The placeholder for the missing values. All occurrences of\n    `missing_values` will be imputed. For pandas' dataframes with\n    nullable integer dtypes with missing values, `missing_values`\n    should be set to `np.nan`, since `pd.NA` will be converted to `np.nan`.\n\nsample_posterior : bool, default=False\n    Whether to sample from the (Gaussian) predictive posterior of the\n    fitted estimator for each imputation. Estimator must support\n    `return_std` in its `predict` method if set to `True`. Set to\n    `True` if using `IterativeImputer` for multiple imputations.\n\nmax_iter : int, default=10\n    Maximum number of imputation rounds to perform before returning the\n    imputations computed during the final round. A round is a single\n    imputation of each feature with missing values. The stopping criterion\n    is met once `max(abs(X_t - X_{t-1}))/max(abs(X[known_vals])) < tol`,\n    where `X_t` is `X` at iteration `t`. Note that early stopping is only\n    applied if `sample_posterior=False`.\n\ntol : float, default=1e-3\n    Tolerance of the stopping condition.\n\nn_nearest_features : int, default=None\n    Number of other features to use to estimate the missing values of\n    each feature column. Nearness between features is measured using\n    the absolute correlation coefficient between each feature pair (after\n    initial imputation). To ensure coverage of features throughout the\n    imputation process, the neighbor features are not necessarily nearest,\n    but are drawn with probability proportional to correlation for each\n    imputed target feature. Can provide significant speed-up when the\n    number of features is huge. If `None`, all features will be used.\n\ninitial_strategy : {'mean', 'median', 'most_frequent', 'constant'},             default='mean'\n    Which strategy to use to initialize the missing values. Same as the\n    `strategy` parameter in :class:`~sklearn.impute.SimpleImputer`.\n\nimputation_order : {'ascending', 'descending', 'roman', 'arabic',             'random'}, default='ascending'\n    The order in which the features will be imputed. Possible values:\n\n    - `'ascending'`: From features with fewest missing values to most.\n    - `'descending'`: From features with most missing values to fewest.\n    - `'roman'`: Left to right.\n    - `'arabic'`: Right to left.\n    - `'random'`: A random order for each round.\n\nskip_complete : bool, default=False\n    If `True` then features with missing values during :meth:`transform`\n    which did not have any missing values during :meth:`fit` will be\n    imputed with the initial imputation method only. Set to `True` if you\n    have many features with no missing values at both :meth:`fit` and\n    :meth:`transform` time to save compute.\n\nmin_value : float or array-like of shape (n_features,), default=-np.inf\n    Minimum possible imputed value. Broadcast to shape `(n_features,)` if\n    scalar. If array-like, expects shape `(n_features,)`, one min value for\n    each feature. The default is `-np.inf`.\n\n    .. versionchanged:: 0.23\n       Added support for array-like.\n\nmax_value : float or array-like of shape (n_features,), default=np.inf\n    Maximum possible imputed value. Broadcast to shape `(n_features,)` if\n    scalar. If array-like, expects shape `(n_features,)`, one max value for\n    each feature. The default is `np.inf`.\n\n    .. versionchanged:: 0.23\n       Added support for array-like.\n\nverbose : int, default=0\n    Verbosity flag, controls the debug messages that are issued\n    as functions are evaluated. The higher, the more verbose. Can be 0, 1,\n    or 2.\n\nrandom_state : int, RandomState instance or None, default=None\n    The seed of the pseudo random number generator to use. Randomizes\n    selection of estimator features if `n_nearest_features` is not `None`,\n    the `imputation_order` if `random`, and the sampling from posterior if\n    `sample_posterior=True`. Use an integer for determinism.\n    See :term:`the Glossary <random_state>`.\n\nadd_indicator : bool, default=False\n    If `True`, a :class:`MissingIndicator` transform will stack onto output\n    of the imputer's transform. This allows a predictive estimator\n    to account for missingness despite imputation. If a feature has no\n    missing values at fit/train time, the feature won't appear on\n    the missing indicator even if there are missing values at\n    transform/test time.\n\nAttributes\n----------\ninitial_imputer_ : object of type :class:`~sklearn.impute.SimpleImputer`\n    Imputer used to initialize the missing values.\n\nimputation_sequence_ : list of tuples\n    Each tuple has `(feat_idx, neighbor_feat_idx, estimator)`, where\n    `feat_idx` is the current feature to be imputed,\n    `neighbor_feat_idx` is the array of other features used to impute the\n    current feature, and `estimator` is the trained estimator used for\n    the imputation. Length is `self.n_features_with_missing_ *\n    self.n_iter_`.\n\nn_iter_ : int\n    Number of iteration rounds that occurred. Will be less than\n    `self.max_iter` if early stopping criterion was reached.\n\nn_features_in_ : int\n    Number of features seen during :term:`fit`.\n\n    .. versionadded:: 0.24\n\nfeature_names_in_ : ndarray of shape (`n_features_in_`,)\n    Names of features seen during :term:`fit`. Defined only when `X`\n    has feature names that are all strings.\n\n    .. versionadded:: 1.0\n\nn_features_with_missing_ : int\n    Number of features with missing values.\n\nindicator_ : :class:`~sklearn.impute.MissingIndicator`\n    Indicator used to add binary indicators for missing values.\n    `None` if `add_indicator=False`.\n\nrandom_state_ : RandomState instance\n    RandomState instance that is generated either from a seed, the random\n    number generator or by `np.random`.\n\nSee Also\n--------\nSimpleImputer : Univariate imputation of missing values.\n\nNotes\n-----\nTo support imputation in inductive mode we store each feature's estimator\nduring the :meth:`fit` phase, and predict without refitting (in order)\nduring the :meth:`transform` phase.\n\nFeatures which contain all missing values at :meth:`fit` are discarded upon\n:meth:`transform`.\n\nReferences\n----------\n.. [1] `Stef van Buuren, Karin Groothuis-Oudshoorn (2011). \"mice:\n    Multivariate Imputation by Chained Equations in R\". Journal of\n    Statistical Software 45: 1-67.\n    <https://www.jstatsoft.org/article/view/v045i03>`_\n\n.. [2] `S. F. Buck, (1960). \"A Method of Estimation of Missing Values in\n    Multivariate Data Suitable for use with an Electronic Computer\".\n    Journal of the Royal Statistical Society 22(2): 302-306.\n    <https://www.jstor.org/stable/2984099>`_\n\nExamples\n--------\n>>> import numpy as np\n>>> from sklearn.experimental import enable_iterative_imputer\n>>> from sklearn.impute import IterativeImputer\n>>> imp_mean = IterativeImputer(random_state=0)\n>>> imp_mean.fit([[7, 2, 3], [4, np.nan, 6], [10, 5, 9]])\nIterativeImputer(random_state=0)\n>>> X = [[np.nan, 2, 3], [4, np.nan, 6], [10, np.nan, 9]]\n>>> imp_mean.transform(X)\narray([[ 6.9584...,  2.       ,  3.        ],\n       [ 4.       ,  2.6000...,  6.        ],\n       [10.       ,  4.9999...,  9.        ]])"
        }
    ],
    "functions": [
        {
            "id": "sklearn/sklearn.impute._iterative/IterativeImputer/__init__",
            "name": "__init__",
            "qname": "sklearn.impute._iterative.IterativeImputer.__init__",
            "decorators": [],
            "parameters": [
                {
                    "id": "sklearn/sklearn.impute._iterative/IterativeImputer/__init__/min_value",
                    "name": "min_value",
                    "qname": "sklearn.impute._iterative.IterativeImputer.__init__.min_value",
                    "default_value": "-np.inf",
                    "assigned_by": "NAME_ONLY",
                    "is_public": true,
                    "docstring": {
                        "type": "float or array-like of shape (n_features,)",
                        "description": "Minimum possible imputed value. Broadcast to shape `(n_features,)` if\nscalar. If array-like, expects shape `(n_features,)`, one min value for\neach feature. The default is `-np.inf`.\n\n.. versionchanged:: 0.23\nAdded support for array-like."
                    },
                    "type": {}
                }
            ],
            "results": [],
            "is_public": true,
            "reexported_by": [],
            "description": "Multivariate imputer that estimates each feature from all the others.\n\nA strategy for imputing missing values by modeling each feature with\nmissing values as a function of other features in a round-robin fashion.\n\nRead more in the :ref:`User Guide <iterative_imputer>`.\n\n.. versionadded:: 0.21\n\n.. note::\n\nThis estimator is still **experimental** for now: the predictions\nand the API might change without any deprecation cycle. To use it,\nyou need to explicitly import `enable_iterative_imputer`::\n\n>>> # explicitly require this experimental feature\n>>> from sklearn.experimental import enable_iterative_imputer  # noqa\n>>> # now you can import normally from sklearn.impute\n>>> from sklearn.impute import IterativeImputer",
            "docstring": ""
        }
    ]
}

Minimal Usage Store (optional)

Minimal Usage Store for `sklearn/sklearn.impute._iterative/IterativeImputer/__init__/min_value`
{
    "schemaVersion": 1,
    "module_counts": {
        "sklearn/sklearn.impute": 1924
    },
    "class_counts": {
        "sklearn/sklearn.impute._iterative/IterativeImputer": 130
    },
    "function_counts": {
        "sklearn/sklearn.impute._iterative/IterativeImputer/__init__": 55
    },
    "parameter_counts": {
        "sklearn/sklearn.impute._iterative/IterativeImputer/__init__/min_value": 5
    },
    "value_counts": {
        "sklearn/sklearn.impute._iterative/IterativeImputer/__init__/min_value": {
            "0": 1,
            "1": 4,
            "-np.inf": 50
        }
    }
}

Suggested Solution (optional)
Parse text segments with "- If..."
Additional Context (optional)
No response

It should work for #/sklearn/sklearn.linear_model._stochastic_gradient/SGDClassifier/__init__/learning_rate, too.
Explicit values with their meaning are given.

It should work for #/sklearn/sklearn.linear_model._stochastic_gradient/SGDRegressor/__init__/learning_rate, too.

Strongly related to https://github.com/lars-reimann/api-editor/issues/403. I'll leave it open since we have more examples here.


Images from ".album" are at the very end of the gallery

Describe the bug
When selecting images from PHAssetCollection two types of albums are selected .album and .smartAlbum in 2 different arrays, separately and joined in a loop.
Problem is that regular .album results get at the very end of the array, so they are shown at the end of the gallery, even though the creation time is newer
To Reproduce
Steps to reproduce the behavior:
0. Make sure you save an image that doesnt take part of a smart album (PNG for example)

Go to 'gallery'
That image doesnt appears
Scroll down to very bottom of the gallery (good luck if u have thousands of images)
See error, only there u see the image u are looking for

Expected behavior
.albums and .smartAlbums should be merged respecting the image creation date
Environment (please complete the following information):

Device: [iPhone8]
OS: [iOS12]
Xcode Version [e.g. 10]
Swift Version [e.g. 4.2]

Installation Type

Cocoapods

Hi @mcaldas
This looks like a bug indeed, thanks for taking the time to write and issue 👍
I can't seem to reproduce it on my side though.
By default, the media request has as creationDate sort.
options.sortDescriptors = [NSSortDescriptor(key: "creationDate", ascending: false)]

Are you by any chance using a non null config.library.options ? (which would override the default)
Saving a PNG from safari works great on my side, does the issue also happens in that case for you?

Hey @s4cha ,
Nope I dont use config.library.options anywhere.
I didnt try from safari, tried from telegram, but the thing is that specific image i see it "All Photos" album but not in "Photos" so my guess was something there

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


bookstack: 23.08.3 -> 23.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bookstackapp/bookstack/releases.
meta.description for bookstack is: A platform to create documentation/wiki content built with PHP & Laravel
meta.homepage for bookstack is: https://www.bookstackapp.com/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 23.10 with grep in /nix/store/ms8zjz4s06dlb1nrjbl1cnprs9r3w44m-bookstack

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
bookstack

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ms8zjz4s06dlb1nrjbl1cnprs9r3w44m-bookstack \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bookstack https://github.com/r-ryantm/nixpkgs/archive/996434f93f86d3852f5cbf2e62e57cefdbd420ff.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/996434f93f86d3852f5cbf2e62e57cefdbd420ff#bookstack

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ms8zjz4s06dlb1nrjbl1cnprs9r3w44m-bookstack
ls -la /nix/store/ms8zjz4s06dlb1nrjbl1cnprs9r3w44m-bookstack/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

bookstack

Maintainer pings
cc @ymarkus for testing.

Some php modules were updated. Closing in favor of #264974


Depend on more packages

Should dask[complete] or the dask conda meta package depend on more stuff?  lz4?  prometheus_client?  pyarrow?
cc @jacobtomlinson @fjetter @jrbourbeau
This came up in conversation internally at Coiled with people being sad that Promeetheus metrics weren't always present.  We can inject this dependency in separately (so it's not a huge driver here) but I suspect that no one has reviewed our "complete" dependencies in a while and this might be a good time to revisit there.

+1 for extending complete but I'm not entirely sure what the extended subset should be
I think an argument could be made for complete shipping with everything that is necessary to make all dask features work (excluding all the various file formats)
Having pyarrow around will enable P2P, lz4 enables network compression, ...
However, strictly speaking this would also mean we should be adding (python-)graphviz, crick, one of a couple of choices for hashing libs (cityhash, xxhash, mmh3), scipy (for array.fft, array.stats), possibly cytoolz
This "rule" would even include jupyter_server and ipython which is not a good idea, I think.

Principles aside, adding lz4 and pyarrow makes a lot of sense to me and I believe much more users will benefit from this than take harm.
prometheus_client is something probably only few will benefit from but the lib itself is very small and doesn't have any dependencies itself so I don't see any harm.
From an UX perspective, I would also love to see graphviz installed (or am I very biased as a developer here? I like dask.visualize)

I don't think that this should be a principled / rule-based decision.  I think that it should be made with some human thought.

I'm +1 on expanding complete. I agree that in general installing everything to turn on most features makes sense. I rarely pip install Dask so I'm assuming this conversation also covers the conda feedstock?
I agree that prometheus_client would be nice to have around all the time. There have been discussions about switching to OTEL instrumentation though, I haven't looked at the package for that but it would be good to check that it is similarly lightweight.
I would also like graphviz to be around more but am I right in thinking you can't pip install that? Only conda or apt + pip?


Subscriptions not being disposed

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Hot Chocolate
Describe the bug
I wrote my own subscription provider for Azure Service Bus, using the RabbitMq and Redis source code as an example. I've used OnConnectAsync as a hook to ensure the a ServiceBus exists and create a new Subscription to it via the MS-provided ServiceBusManagementClient. I'm able to then get a processor to start processing messages and return a subscription object derived from IDisposable. No problems there.
However, the above creates some objects in Azure that I'd like to clean up. I suspected from looking at the subscriptions source code that the intention was that the subscription (again, an IDisposable) object would get disposed whenever the websocket closes, but when I cancel the subscription via Banana Cake Pop the Dispose method does not get called.
Is my assumption of how this ought to work just wrong? How should my server get notified that a subscription is no longer being used/can be cleaned up?
Thanks for everything, very happy with this set of libraries and the documentation overall.
Steps to reproduce

Implement a subscription provider :)
Set a breakpoint on your subscription's Dispose() method
Start and stop a subscription in Banana Cake Pop
Observe that the Dispose() method is never called

Relevant log output
No response
Additional Context?
No response
Version
13.0.5

After doing some more reading through subscriptions issue, I think this is maybe a duplicate of #5877. Closing for now.


Allow highcharts@9 as peer dependency

This just adds peer dependency for highcharts@9.
The tests pass and it seems to work okay.

Codecov Report

Merging #325 (8e3c4fb) into master (a67f2e0) will decrease coverage by 18.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #325       +/-   ##
===========================================
- Coverage   89.13%   70.98%   -18.16%
===========================================
  Files          82       18       -64
  Lines        1086      255      -831
  Branches      211       45      -166
===========================================
- Hits          968      181      -787
+ Misses        106       66       -40
+ Partials       12        8        -4

Impacted Files
Coverage Δ

...ges/react-jsx-highcharts/src/utils/debounce-raf.js

...sx-highcharts/src/components/ChartContext/index.js

...-highcharts/src/components/WithHighcharts/index.js

...ighcharts/src/components/ColorAxisContext/index.js

...highcharts/src/components/UsePlotBandLine/index.js

...x-highcharts/src/components/BarSeries/BarSeries.js

...-highcharts/src/components/UseChartUpdate/index.js

...highcharts/src/components/PlotBandLine/PlotLine.js

...x-highcharts/src/components/UseHighcharts/index.js

...highcharts/src/components/PlotBandLine/PlotBand.js

... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67f2e0...8e3c4fb. Read the comment docs.


How can certain classes be excluded from Dependency checks

Q
A

Library version
0.2.7

PHP version
8.1

Support Question
I have a check for my domain model purity:
$domainLayerIsolation = Rule::allClasses()
        ->that(new ResideInOneOfTheseNamespaces('App\AppointmentMgmt\Domain'))
        ->should(new NotHaveDependencyOutsideNamespace('App\AppointmentMgmt\Domain'))
        ->because('we want protect our domain');

This generates lots of violations about certain classes that are from different namespaces, which I have allowed in the domain layer.
Is there a way to exclude certain classes - the domain model does have certain dependencies that I'd like to permit without them raising violations.
Thanks

Hi @benr77 we are discussing this feature many times like in this issue: #200 and at the moment you can use  a trick, instead of using this:
->should(new NotHaveDependencyOutsideNamespace('App\AppointmentMgmt\Domain'))

You can. use this:
->should(new DependsOnlyOnTheseNamespaces('App\AppointmentMgmt\Domain', 'OtherNamespace\'))

If you want to help with the new feature about excluding some dependencies, feel free to open a PR.

Thank you for pointing out #200 - the title of that issue is not very descriptive as you are really talking about how to exclude classes in a generic way, not just for \Exceptions.
I will try your workaround - looks like it will work well for me. Thanks again!

I have just discovered that ResideInOneOfTheseNamespaces is not picking up any classes at all... It was working on older releases, but on 0.2.7 it seems not.
->that(new ResideInOneOfTheseNamespaces('App\AppointmentMgmt\Domain'))

@benr77 I am trying without problems with the newer version of the expression ResideInOneOfTheseNamespaces .
If you have a new problem, can you please open a new PR with a concrete example to understand well the problem?

My apologies. I had my src directory set incorrectly. ResideInOneOfTheseNamespaces is working correctly. Sorry for the confusion.

No problem @benr77
Thanks for your contribution!


Move synchronize code slot automation logic into binary sensor to try to resolve #25

Proposed change
This may resolve the issues that @tankdeer is having in #25. For some reason, the automation isn't clearing the code when he disables a code slot, and the debug logs make me think that the state change for PIN synched is happening too fast for the automation to catch it. I believe this will improve the guarantee that the automation catches the action in time.
Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

Codecov Report

Merging #53 (6b1a15f) into main (a6d4bef) will decrease coverage by 1.46%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   94.32%   92.85%   -1.47%
==========================================
  Files           8        8
  Lines         581      602      +21
==========================================
+ Hits          548      559      +11
- Misses         33       43      +10

Impacted Files
Coverage Δ

custom_components/keymaster/binary_sensor.py
91.82% <60.00%> (-6.01%)
:arrow_down:

Codecov Report

Merging #53 (6b1a15f) into main (a6d4bef) will decrease coverage by 1.46%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   94.32%   92.85%   -1.47%
==========================================
  Files           8        8
  Lines         581      602      +21
==========================================
+ Hits          548      559      +11
- Misses         33       43      +10

Impacted Files
Coverage Δ

custom_components/keymaster/binary_sensor.py
91.82% <60.00%> (-6.01%)
:arrow_down:


4 Perks stuck in slots if you had used old perk bug to have all 4

Its a followup bug concerning the now fixed ability to have 4 perks even if you're not lvl 15. If previously you had used the bug to have all 4 perks now they're stuck in the perk slots and you still have all the bonuses (22 knowledge at lvl 1).
Video that shows the issue: https://youtu.be/HFVIFr9grew

I would just delete the character and create a new one


removes forward spaces from numeric selector

I fixed match to remove forward spaces from numeric selector. This is useful for themes like mine with color background highlights.

Well review this today


fix: DotAll flag with group

Hi, this PR is to fix DotAll flag not working in group, and I've created unit test case for it, please review.

Thanks!


Python vector index client remaining tasks

[x] Ensure integration tests pass against alpha locally
[x] Ensure integration tests pass against alpha in CI. You may need to add the TEST_VECTOR_INDEX_NAME variable to job environment
[x] Audit the error messages. For each operation, test error conditions and ensure the error message is correct, human readable, and does not include extraneous details. They should also be helpful and, if possible, suggest a fix.
[x] Add integration tests to test bad auth tokens (see commented out tests in the test_control_async)
[x] Add integration tests to test adding vectors to an index where the input vector dimension does not match the index number of dimensions
[x] Add integration tests to test searching with a query vector where the query vector dimension does not match the index number.
[x] Audit documentation

All issues have been addressed under https://github.com/momentohq/client-sdk-python/pull/358/


Feature Request: Add a setting that disables HTML copy

Description of the new feature/enhancement
The new HTML copy feature introduced in v0.4.2382.0 may not always be desirable, and removing the formatting typically means either opening a text editor like Notepad, pasting the text, and then copying it again, or asking the receiving application to strip formatting.  For cases where a user knows this is going to happen to them frequently, it would be helpful if there were a setting that could disable the HTML copy feature.
If entirely disabling HTML copy is undesirable, under the assumption that users may still want to keep formatting sometimes, another possible option would be to provide separate key bindings that behave the "old" way. However, admittedly with no experience with the codebase, this seems like it would be more work.

As an aside, what application is serving as the destination that doesn't support "Paste [as] Plain Text"?

The last place I pasted before leaving work today was the web version of outlook, which actually does have the option to paste as plain text - but it's in a context menu that has to be clicked and has no keyboard shortcut. I have a tendency to copy something out of the terminal, start typing an email, and then press Ctrl+V, only to find that I've pasted colored text with a dark background into my email.
Like I said in the original post, it's a small delay; it's just a new delay that wasn't there before the last update, in exchange for a feature I wasn't really looking for and typically don't want to use.

When copying text to the clipboard, Terminal copies both the plaintext, and HTML text. Applications that can handle both generally allow you to paste content keeping source formatting, keeping target formatting, or pasting plain text. This is available via the context menu (right-click / Keyboard: right-context-menu-key / SHIFT+F10) and is a well understood, and well supported behavior by most rich-text apps/tools.

@bitcrazed Thanks, but as I mentioned above, the place I'm mostly running into this does support these options via a context menu after I paste. In the web version of outlook, right clicking and using the keyboard shortcuts mentioned just bring up my browser's context menu, which only includes "paste".

@amazingant When I hit the context key / SHIFT+F10 in Outlook online, I see a context menu that offers me both paste and paste as text:

This MAY be because I am running a preview release of Outlook online, and if so, its likely this will be publicly released before long.

Nope; that's Chrome's default context menu, I use Firefox. :)

Then this would be a great bug to file on the Firefox team. It is 2019 and the Clipboard's ability to contain content in multiple formats has been there for at least 20 years.


Rename vfredsum and vfwredsum to vfredusum and vfwredusum to match 1.0 spec

These were rename to include "u" for unordered

Should we add a tag for v0.10?

we already have v0.10 tag

https://github.com/riscv-non-isa/rvv-intrinsic-doc/commit/dc1a3f0c2691cd4c5270d8010efaa30a8a366653


Ultraleap/Leapmotion controller manual offset

Hi there!
Is there any reason why we can't use a transform for the offset of the leapmotion/ultraleap controller? Like how we can with the XR Input controller provided by the leapmotion sdk?

Hi @HyperLethalVector is the offset you are referring to the Leap Controller Offset while the controller orientation is on the Desk?

What happens if we intend to use it in a HMD, but can't adjust the offset from the head ;)
Also offset might include rotation, which is why the leapmotion sdk allows the offset to be set by a transform.
shrug

Controlling the offset of the hands if the device is in the headset orientation is possible.  When the leap controller is in the headset orientation, the LeapXRServiceProvider component is attached to the main camera during play mode and the offset can be edited there.  Although we could maybe expose these settings in the Leap Motion Device Manager to make things easier.

I agree, however your implementation doesn't search for a Leap XR service provider and use it's settings, check my modified code snippet, rather than spawning a gameobject I first use the one in the scene.
I think this is better, as it allows for adjustment during runtime.
(LeapMotionDeviceManager.cs)

Might be useful :)

@HyperLethalVector the transform offset can be modified in the current implementation, here is an example:
LeapMotionDeviceManager leapMotionDeviceManager = CoreServices.GetInputSystemDataProvider<LeapMotionDeviceManager>();
LeapXRServiceProvider leapXRServiceProvider = leapMotionDeviceManager.LeapMotionServiceProvider as LeapXRServiceProvider;
leapXRServiceProvider.deviceOffsetMode = LeapXRServiceProvider.DeviceOffsetMode.Transform;
leapXRServiceProvider.deviceOrigin = gameObject.transform;

But I agree that we can expose offset properties in the profile for easy initial offset value setting.


null values cannot be formatted as an SQL identifier

I tried replicating one test table with two columns(id and name) and a single row. When I update the name column in MySQL, I get below error and replication stops. Also, I get same error when I tried replicating actor table of sakila database(https://dev.mysql.com/doc/sakila/en/sakila-installation.html)
Below are the versions I am using:
mysql  Ver 14.14 Distrib 5.7.21, for osx10.12 (x86_64) using  EditLine wrapper
psql (PostgreSQL) 10.2
pg-chameleon 2.0.9
Logs:
2018-08-27 16:21:26 MainProcess INFO: Checking if the replica for source mysql is stopped
2018-08-27 16:21:48 MainProcess INFO: Checking if the replica for source mysql is stopped
2018-08-27 16:21:48 MainProcess INFO: Cleaning not processed batches for source mysql
2018-08-27 16:21:48 MainProcess INFO: Starting the replica daemons for source mysql
2018-08-27 16:21:58 MainProcess ERROR: Read process alive: True - Replay process alive: False
2018-08-27 16:21:58 MainProcess ERROR: Stack trace: Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pg_chameleon/lib/global_lib.py", line 503, in replay_replica
    tables_error = self.pg_engine.replay_replica()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pg_chameleon/lib/pg_lib.py", line 1164, in replay_replica
    self.pgsql_cur.execute(sql_replay, (replay_max_rows, self.i_id_source, exit_on_error))
psycopg2.DataError: null values cannot be formatted as an SQL identifier
CONTEXT:  PL/pgSQL function sch_chameleon.fn_replay_mysql(integer,integer,boolean) line 211 at FOR over EXECUTE statement

2018-08-27 16:21:58 MainProcess ERROR: Replay daemon crashed. Terminating the read daemon.
2018-08-27 16:21:58 MainProcess INFO: Replica process for source mysql ended

Below is my default.yml
---
#global settings
pid_dir: '~/.pg_chameleon/pid/'
log_dir: '~/.pg_chameleon/logs/'
log_dest: file
log_level: info
log_days_keep: 10
rollbar_key: ''
rollbar_env: ''

# type_override allows the user to override the default type conversion into a different one.
type_override:
  "tinyint(1)":
    override_to: boolean
    override_tables:
      - "*"

#postgres  destination connection
pg_conn:
  host: "localhost"
  port: "5432"
  user: "usr_replica"
  password: "never_commit_password"
  database: "sakila"
  charset: "utf8"

sources:
  mysql:
    db_conn:
      host: "localhost"
      port: "3306"
      user: "usr_replica"
      password: "never_commit_passwords"
      charset: 'utf8'
      connect_timeout: 10
    schema_mappings:
      sakila: sakila
    limit_tables:
      - sakila.test
    skip_tables:
      - delphis_mediterranea.foo
    grant_select_to:
      - rahil.r
    lock_timeout: "120s"
    my_server_id: 100
    replica_batch_size: 10000
    replay_max_rows: 10000
    batch_retention: '1 day'
    copy_max_memory: "300M"
    copy_mode: 'file'
    out_dir: /tmp
    sleep_loop: 1
    on_error_replay: continue
    on_error_read: continue
    auto_maintenance: "disabled"
    gtid_enable: No
    type: mysql
    skip_events:
      insert:
        - delphis_mediterranea.foo #skips inserts on the table delphis_mediterranea.foo
      delete:
        - delphis_mediterr
anea #skips deletes on schema delphis_mediterranea
      update:

Below is the table that pg_chameleon created in psql

Thanks for reporting the bug, the issue appears to be postgresql 10 specific.
postgresql 9.6 is not affected.
I'll work to a fix and release a new version asap.

Can you please run this test for me?
Install the version 2.0.9. When the process crashes load this updated function (it's already formatted to overwrite the one in sch_chameleon https://pastebin.com/DJ2Den9S.
The problem was caused by not filtering the  NULL value for the primary key before the formatting.
PostgreSQL 9.6 didn't complain but the version 10 it seems it is more stringent in that sense.
If the function works as expected I'll run some tests and I'll do a new release this week end.
Thanks

@the4thdoctor I installed the latest chameleon and updated function, now I don't get any error but data is not replicated

This is the package with the fix (replay and json). Can you please test it?
pg_chameleon-<IP_ADDRESS>.tar.gz


New version: SaaSGroup.Tower version 8.3.499

Created by 🥟 Dumplings in workflow run #10313.

Log
Updated: 8.2.496 → 8.3.499
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

2024-12-16 04:27:27.326 [CLI ] Starting installer selection.
2024-12-16 04:27:27.326 [CLI ] Installer [Arm64,burn,Unknown,] not applicable: Installer scope does not match required scope: Unknown != User
2024-12-16 04:27:27.326 [CLI ] Installer [Arm64,burn,Unknown,] not applicable: Machine is not compatible with Arm64
2024-12-16 04:27:27.326 [CLI ] Installer [X64,burn,Unknown,] not applicable: Installer scope does not match required scope: Unknown != User
2024-12-16 04:27:27.326 [CLI ] Installer [X86,burn,Unknown,] not applicable: Installer scope does not match required scope: Unknown != User
2024-12-16 04:27:27.327 [CLI ] No suitable installer found for manifest Microsoft.DotNet.DesktopRuntime.8 with version 8.0.11

@stephengillie https://github.com/microsoft/winget-pkgs/issues/152555


[CELEBORN-1447] Support configuring thread number of worker to wait for commit shuffle data files to finish

What changes were proposed in this pull request?
Introduce celeborn.worker.commitFiles.wait.threads to support configuring thread number of worker to wait for commit shuffle data files to finish.
Why are the changes needed?
celeborn.worker.commitFiles.threads supports the configuration that is the thread number of worker to commit shuffle data files asynchronously including waiting for commit files to finish at present. It should support to configure thread number of waiting for commit shuffle data files to finish which avoids the situation where the commit thread pool is waiting for commit files and no thread could commit shuffle data files.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.

Ping @FMX, @waitinfuture.


Mining Rewards not being processed since block 45887 yesterday. pending amount not being paid

mining rewards are not being paid since yesterday..  block number 45887 is stuck on 92/100 for half a day (approximately)..
There are (more than) 15 pending payments plus the new ones i cannot see yet..
Maybe server reboot required etc??

a day later.. the mining pool now has 46 workers - double when i started.. and still the confirmations for my payments are not being processed.. i have had only a small amount reach my wallet since yesterday. all other payments (now there are 15 with more to follow - maybe another 50? ) please look at why the payments are taking so long to complete confirmations (more than 24 hours)..

Good to see this is an echo chamber..  i like talking to myself anyway .. :)   In case someone reads this.. The pending payments have caught up until about 2 days ago. Now i have NO pending payments from the past few days even though i have been mining for a couple of hours..  this is stopping me from mining any further..


Revisit incorrect answer animations with Geoff

The wrong answer animations don't read well (it's very hard to tell that it is spitting out the stone). More frames needed?

Closing as there is a duplicate task.


[Feat/1173] implement fallback article images

This Ticket Resolves #1173
Please see below before and after for all effected areas on desktop and mobile, very slight difference on "Show" page, due to moving to  so no bg-repeat. The adjustment was minimal, so replicating the previous setup didn't seem necessary
I also hasHeroImage from the backend code as it's no longer needed as this code change will handle this logic in the view.
Overview Summary
Before:

After:

Show
Before:

After:

Summary
Before:

After:

User Summary
Before:

After:

Thanks a bunch!


Added with_query to EntityCommands

Objective

Fixes #4917

Solution

Added a convenience method to EntityCommands, with_query which allows a mutable query to be run for a specific Entity.
Added documentation and unit tests as appropriate.

Example
commands
    .entity(player.entity)
    .insert(ReallyComplexPlayerBundle::default()) // This adds Health to the Entity
    .with_query::<&mut Health>(|mut health| {
        health.0 = 100;
    });

I see the utility, but I'll note that this feels like a more specialized form of one-shot systems (which I believe we will eventually support). Thinking holistically, would we want to support both this and one-shot systems? (We may -- I haven't formed a full opinion on this yet).
Also, I think the inclusion of a with_query_filtered variant is a bit odd, given that this only runs for a single entity. If users want to add conditions I think it would make more sense to just put an if statement inside of the closure.
Also, I think there should be some kind of error or warning if the command gets applied on an entity that doesn't match the query.

Something that would achieve a similar effect is to implement EntityCommand for FnOnce(EntityMut). That way you could do:
commands
    .spawn()
    .add(|mut entity: EntityMut| {
        entity.get_mut::<Health>().0 *= 2;
    });

Something that would achieve a similar effect is to implement EntityCommand for FnOnce(EntityMut). That way you could do:

I like this much better!

Closing this out; let's do that instead in a new PR.


fix(log): Fix confusing comments and error messages in zebra-checkpoints

Motivation
Minor fixes from @upbqdn's review of PR #6516.
Solution
Fix the issues listed in this PR review:
https://github.com/ZcashFoundation/zebra/pull/6516#pullrequestreview-1402212516
Review
Marek can review this, it's not urgent at all.
Reviewer Checklist

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

@mergifyio update


Provider web-api request timed out.

Hey! I feel like I am doing everything correctly (I connect to localhost through MongoDBCompass, I connect the observer tool and sync & I put in a fresh riot development api key) but I keep getting (warning) event timed out and (warning) no handler was executed. I feel like it goes perfectly from lobby to champselect not further. Am I doing something wrong?

<EMAIL_ADDRESS>start
node --trace-warnings dist/core/app.js

2022-04-26T17:18:16.546Z [info ] main        :  _          _       _____           _ _    _ _
2022-04-26T17:18:16.547Z [info ] main        : | |    ___ | |     |_   |_   ___ | | | () |_
2022-04-26T17:18:16.548Z [info ] main        : | |   / _ | |       | |/ _ \ / _ | | |/ / | |
2022-04-26T17:18:16.548Z [info ] main        : | || () | |__    | | () | () | |   <| | |_
2022-04-26T17:18:16.548Z [info ] main        : |_/||   |_|_/ ___/|||__|__|
2022-04-26T17:18:16.548Z [info ] main        :
2022-04-26T17:18:16.549Z [info ] lpte-svc    : Initialized event bus.
2022-04-26T17:18:16.550Z [info ] module-svc  : Initializing module service.
2022-04-26T17:18:17.821Z [info ] module-svc  : Initialized 17 module(s). Now loading plugins.
2022-04-26T17:18:17.822Z [info ] module-svc  : Loaded 17 plugin(s).
2022-04-26T17:18:18.625Z [info ] main        : LoL Toolkit started up successfully.
2022-04-26T17:18:18.626Z [info ] module-svc  : Plugin status changed: plugin=plugin-webapi, old=UNAVAILABLE, new=RUNNING2022-04-26T17:18:18.627Z [info ] module-svc  : Plugin status changed: plugin=plugin-prod-clock, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.627Z [info ] module-svc  : Plugin status changed: plugin=plugin-config, old=UNAVAILABLE, new=RUNNING2022-04-26T17:18:18.627Z [info ] module-svc  : Plugin status changed: plugin=module-valorant-state, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.628Z [info ] module-svc  : Plugin status changed: plugin=module-valorant-pregame, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.628Z [info ] module-svc  : Plugin status changed: plugin=module-tournament-tree, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.628Z [info ] module-svc  : Plugin status changed: plugin=module-teams, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.628Z [info ] module-svc  : Plugin status changed: plugin=module-league-state, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.629Z [info ] module-svc  : Plugin status changed: plugin=module-league-runes, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.629Z [info ] module-svc  : Plugin status changed: plugin=module-league-end-of-game, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.630Z [info ] module-svc  : Plugin status changed: plugin=module-league-champselect-ui, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.630Z [info ] module-svc  : Plugin status changed: plugin=module-caster, old=UNAVAILABLE, new=RUNNINGsetting storageRoot to C:\Tools\prod-toolkit\modules\plugin-webapi\node_modules\leaguejs\StaticDataDefaultRoot
2022-04-26T17:18:18.641Z [info ] module-svc  : Plugin status changed: plugin=plugin-database, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.641Z [info ] module-svc  : Plugin status changed: plugin=module-league-static, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.642Z [info ] module-svc  : Plugin status changed: plugin=module-league-in-game, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.653Z [info ] module-svc  : Plugin status changed: plugin=plugin-theming, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.942Z [info ] module-svc  : Plugin status changed: plugin=module-valorant-static, old=UNAVAILABLE, new=RUNNING
2022-04-26T17:18:18.960Z [info ] server      : Listening for requests on http://localhost:3003
2022-04-26T17:18:42.612Z [warn ] lpte-svc    : Request was sent, but no handler was executed. This will result in a timeout. Meta={"namespace":"prod-clock","type":"request-sync","version":1,"reply":"request-sync-iet0jbq8l2gewz3m","channelType":"REQUEST"}
2022-04-26T17:19:05.151Z [info ] module-league-state: Flow: champselect - active
2022-04-26T17:20:20.426Z [info ] module-league-state: Flow: champselect - game started (spectator delay)
2022-04-26T17:20:20.446Z [warn ] lpte-svc    : Request was sent, but no handler was executed. This will result in a timeout. Meta={"channelType":"REQUEST","namespace":"provider-webapi","type":"fetch-livegame","version":1,"sender":{"name":"module-league-state","version":"4.1.1","mode":"PLUGIN","path":"C:\Tools\prod-toolkit\modules\module-league-state"},"reply":"fetch-livegame-iet0jd7sl2gez2l6"}
2022-04-26T17:20:50.447Z [warn ] lpte-svc    : Awaiting event timed out. namespace=reply, type=fetch-livegame-iet0jd7sl2gez2l6, timeout=30000
2022-04-26T17:20:50.448Z [error] lpte-svc    : Request timed out after 30000ms. Request meta={"channelType":"REQUEST","namespace":"provider-webapi","type":"fetch-livegame","version":1,"sender":{"name":"module-league-state","version":"4.1.1","mode":"PLUGIN","path":"C:\Tools\prod-toolkit\modules\module-league-state"},"reply":"fetch-livegame-iet0jd7sl2gez2l6"}
2022-04-26T17:23:47.386Z [info ] module-league-state: Flow: champselect - inactive

Thanks for reporting this issue.
Can you pls tell us which versions of the individual modules you are using?
But if everything is up to date, that's a bug and we gonna fix this as soon as we can.

I would love to, but there seems to be an issue with starting the application.
I'm getting to the datadragon download but afterwards the start.bat just shuts down without warning after briefly showing the error message below. I have tried on another device and im getting the same problem there.

I did download the 1.0 release today so I assume all of the modules are up-to-date (regarding the original issue).

I should be fixed with an update of the module for the league state you can do that why the module page in the web interface and the just restart the tool :)

I would love to, but there seems to be an issue with starting the application.
I'm getting to the datadragon download but afterwards the start.bat just shuts down without warning after briefly showing the error message below. I have tried on another device and im getting the same problem there.

I did download the 1.0 release today so I assume all of the modules are up-to-date (regarding the original issue).

Exactly the same issue and error from me, can't start the application and access the web panel because of that.

So im getting this warning everytime the server connects with the observer tool.
2022-04-27T16:05:37.311Z [info ] server      : Listening for requests on http://localhost:3003
2022-04-27T16:05:41.271Z [warn ] lpte-svc    : Request was sent, but no handler was executed. This will result in a timeout. Meta={"namespace":"prod-clock","type":"request-sync","version":1,"reply":"request-sync-iet0jgc4l2hrqx3a","channelType":"REQUEST"}
2022-04-27T16:05:57.252Z [info ] module-league-state: Flow: lobby - active
2022-04-27T16:06:45.479Z [info ] module-league-state: Flow: champselect - active
2022-04-27T16:08:20.200Z [info ] module-league-state: Flow: champselect - game started (spectator delay)
2022-04-27T16:08:20.216Z [info ] plugin-webapi: Fetching livegame data for summoner=(My name)
2022-04-27T16:08:33.710Z [info ] plugin-webapi: Fetched livegame for summoner=(My name), gameId=5843842698
100
200
2022-04-27T16:12:45.569Z [info ] module-league-state: Flow: champselect - inactive
2022-04-27T16:14:45.044Z [info ] module-league-state: Flow: end of game - active
The flow seems to be working properly until I get ingame. The levelups and item buys dont seem to work at all. I also dont get any information at the "Game is loaded: #" section in the game state module, and in-game-live always stays unknown.

Also, if I start the client after starting the start.bat & league observer tool it doesnt quite work as expected. Once I get into champ-select the start.bat either doesnt recognise that I have entered champselect or just crashes without warning or error message. This also happens when I am in champ-select and there is an update like a ban or a pick. I'm not sure if this is expected behavior or user error or anything but Ill mention it regardless.

I can reproduce the issue with ingame events not showing up, we will look into it and let you know once we know whats happening.
The observer tool needs the client to be running when syncing modules, I recommend always starting league, then the toolkit, then the observer tool. In some rare cases, playing with the observer tool can lead to crashes, although we haven't been able to reliably reproduce these.
If this keeps happening, you can start the toolkit from PowerShell, this way any error messages should be visible on a hard crash (shift+rightclick in the toolkit folder -> open PowerShell here -> npm start)

Ah okay I will do it in that order.
Is this warning also related to that problem or can it be resolved on my side?
2022-04-27T16:05:41.271Z [warn ] lpte-svc : Request was sent, but no handler was executed. This will result in a timeout. Meta={"namespace":"prod-clock","type":"request-sync","version":1,"reply":"request-sync-iet0jgc4l2hrqx3a","channelType":"REQUEST"}
Regardless of that, thanks for the quick responses and help!

We are aware of this issue, this should not be a problem and will be fixed with the next patch of the observer tool.

This should now be fixed, I am seeing ingame events again with the newest version of the observer tool.
Could you try again and confirm if this fix also works for you? (The observer tool auto updates, no need to reinstall or anything)

Yes, I can see the ingame events now (I only tried mythic & lvl 6)! Thanks!


Remove es-abstract dependency.

Is the next step to break up the ES object in ecmascript.ts into separate exported functions and then to import those functions (not ES overall) in all other files?

I'm not sure it's strictly needed, but it seems like a relatively easy thing to do (and it's considered idiomatic Google TypeScript to not have "container objects" like this) so I was going to send a PR for that today.

I'm not sure it's strictly needed, but it seems like a relatively easy thing to do (and it's considered idiomatic Google TypeScript to not have "container objects" like this) so I was going to send a PR for that today.

Cool. I assume the main reason to do that would be to help with tree-shaking?

My understanding is that tree-shaking is easier when the things to be shaken are module exports, but that this might only apply to some build tools and not others. E.g. I believe Closure Compiler can handle this and DCE the unused functions.

Yep. Not sure if webpack's tree-shaking can handle it.  FWIW, I could help you test it by trying to build one of my apps (which is bundled with webpack) before and after your upcoming PR. I'll let you know if there's a bundle size diff.


Base Transform Op shape check

https://github.com/deeplearning4j/nd4j/issues/959
Currently we only check if length is equal if a base transform has two nd arrays as arguments. Mismatched shapes even with the same length can cause JVM crashes. Changed so that it now throws an exception

Tests are all passing.


Exclude body validation on openapi object upload

Fix #2905
Fix #2907
Skip upload object body validation that read the complete request body

Note the docs yaml update have missing update from previous change


v1.7.1 - Mini player improvement and various bug fixes

Fixed issue when Tuneful was crashing on launch if Spotify is not installed
Fixed notch notification appearance for Light Mode
Fixed accent color in settings window
Mini player now remembers its position after relaunching Tuneful, huge thanks to @itssali
Minor player manager optimisation

/release


world ball beginning position

Hi all,
I had somehow managed to overwrite the built-in ball starting position and now it is positioned under the table and I have to set it position every time I start the simulator. I tried to find something in the simConfig directory but with any luck. I assume there should be some .ini file for that but I am unable to find it.
Thanks
Matus

Hi @matusko89, the short answer is that, at the moment, the default sphere position cannot be configured in the simConfig or in any ini file. You will have to set its position or initialise the simulator's world as you please from your module, once you start the simulator. This has been noted as a future feature request for the simulator.

@matusko89: how did you manage to change the ball position? in the code? Maybe you need to reset your repository and discard your local changes:
git reset --hard
be careful because you lose all your local changes.

@lornat75 I think this is related to this issue #18

@lornat75 I was messing around with yarp rpc /icubSim/world and trying if it is maybe possible to change color of ball. I managed to crash the simulator few times and the ball just happened to start render under the table...

Nevertheless It is back to normal now but some .ini file would be nice for future.
Thanks

@matusko89, make sure that you are not trying to place the ball within the table as that might create some issues due to various collisions. I should suggest to use the custom object creation instead of the default ones as you have more control on their properties. You can find everything here


net: wifi_mgmt: Support to provide raw scan data

Support to provide raw beacon and probe response data to registered application.

@sachinthegreen @krish2718 @rado17 @udaynordic


Allow customization of search match text color

I couldn't find this by searching, but it would be very good for readability if we could add the option to change the foreground color for find matches (editor.findMatchForeground?). Otherwise, we have to pick a background color that won't clash with any possible color in our theme, which is not an easy feat.
Example of how it works now in VS Code:

Example of how it works in Sublime:

See https://github.com/Microsoft/vscode/issues/29091


Medium and Small Admob Adds are not shown

Hi,
I was able to integrate your library on a project that uses . I successfully added Large Admob Adds but for Small and Medium Native Admob Express ads I was unable.
I am using AdmobRecyclerAdapterWrapper in my app and this is the error that I receive:
E/Ads: Malformed native JSON response.
org.json.JSONException: Index 0 out of range [0..0)
  at org.json.JSONArray.get(JSONArray.java:282)
  at org.json.JSONArray.getJSONObject(JSONArray.java:510)
  at com.google.android.gms.ads.internal.renderer.nativeads.h.a(:com.google.android.gms.DynamiteModulesA:238)
  at com.google.android.gms.ads.internal.webview.c.a(:com.google.android.gms.DynamiteModulesA:955)
  at com.google.android.gms.ads.internal.webview.u.run(:com.google.android.gms.DynamiteModulesA:44)
  at android.os.Handler.handleCallback(Handler.java:733)
  at android.os.Handler.dispatchMessage(Handler.java:95)
  at android.os.Looper.loop(Looper.java:136)
  at android.app.ActivityThread.main(ActivityThread.java:5017)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at java.lang.reflect.Method.invoke(Method.java:515)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
  at dalvik.system.NativeStart.main(Native Method)

I tried with AdmobExpressRecyclerAdapterWrapper also but when I am using this to set the AdSize in ExpressAdPreset, I receive the warning:
W/Ads: Not enough space to show ad
I think this is a padding issue but I don't know how I can set the padding on the adView from your adapter
Is this a known issue for you?

@Geodark Hi,
Please correct me if I'm wrong but the Advanced Native ads are still in Beta. So you should definitely use the  AdmobExpressRecyclerAdapterWrapper.
On the issue "W/Ads: Not enough space to show ad": I had the same, it is closely connected with paddings/margins and I'm not sure but maybe it's a kind of bug in Express ads...
However I solved it after I removed all the paddings from the RecyclerView itself and from all parent Views.  Then I set a required paddings/margins for all items' views but ads. The gist is to let ads fill the full width of a screen.

Hi @kot331107,
Thanks a lot for your reply.
You are right: the Native Advance Ads are in beta, but I didn't know that AdmobRecyclerAdapterWrapper  is for advanced ads. Although the large were shown when I used this and without the padding - I think ths wrapper does this for us.
I will try to use  AdmobExpressRecyclerAdapterWrapper. There is a chance to have a gist with the removed paddings for RecyclerView as you suggested?

@Geodark hi,
I guess you don't need a gist! You should simply remove all paddings/margins in the app from RecyclerView and its'parents.

@Geodark how's it going? Just a friendly reminder...have you handled it successfully?

@kot331107 Hi,
I was managed to user Express Wrapper and to remove the paddings from RecyclerView in case of Native ads, but now the Large native ads are not shown if I use in Wrapper constructor only the Ad Unit Id.
I've managed to show the large ad when I used ExpressAdPreset - but in this case the height of the ad it's hard coded.
Do you know something about it?

@kot331107 hi again,
In addition to this issue. In my app I want to start different activities in ListPostItemTouchListener listener - we I click the coresponding item from the list. I determine the view type and I wanted to see if it's express ads but the following function it's private. It's possible to make this function public in the next release:
AdmobExpressRecyclerAdapterWrapper.java:130 (version 1.3.0 of this library)
    private int getViewTypeAdExpress(){
        return getViewTypeBiggestSource() + VIEW_TYPE_AD_EXPRESS + 1;
    }

@Geodark hi,
Sure it's not hard to make it public...but let's get with it together. Am I right that you want to do some certain action (start any specific activity) on touch on the corresponding item ? And you need some way to determine what the exact item was clicked outside of the wrapper, let's say right in your listener? Then see this post.
On the ad's height: When you created ad banner in the Admob Console you'd set there a size for it with exact widthxheight. So you should pass this height to the to the ExpressAdPreset#AdSize like it was shown here. Try to leave the width as FULL_WIDTH and set the height from your banner's options .


problem to start

http://SSMaker.ru/d3026efe/

how to read the value of the first register?
device description - https://contactless.ru/wiki/index.php/Relay_Module_Modbus_Management by
default,,1,ZZZZ,1,104,1
/Modbus/relay-6сh/1ch/status, 0

What should be where - ZZZZ ?
If we read coil register where the possible values 0 or 1
thanks in advance


RFC: improve gpu logging

RFC, as this is just an idea, and there may be a number of other things that can be improved before this is landed.
Changes basically:

move to using klog for logging, rather than directly hitting fmt.
add a single extra log entry, that is particularly helpful when you have no GPUs to register

queries still pending in my head then:

Overall, is this a move in the right direction
I wonder if anything can, or should, be done at the generic device plugin code level?
does this imply there are extra klog things that can be configured (on the command line maybe), that should now be documented for the plugin

@grahamwhaley want to keep this separate or shall we consolidate with #329?

I think this will indeed consolidate into #329. Let me close this one...


starlark: preserve the backtrace in load() errors

The errors from a load() were dropping the stack trace on the floor. Hopefully this should be non-controversial.
I also considered using the Go 1.13 error wrapping API, but decided that there are probably too many starlark users on Go 1.12

hmmm...that makes sense. A couple ideas:

Would you accept a change to implement the Unwrap() interface, so that API callers can at least get the underlying error? This would make it more compatible with the Go 1.13 way of doing errors

Alternatively, we could check if the root of the EvalError call stack against the current call stack, and only do this if they match?  That way, Load() implementations that use the same thread would work ok, and we wouldn't break Load() implementations that use a different thread.

Idea #1 sounds fine.

great!
I just pushed a change that uses xerrors.Wrappers. If we don't want starlark to depend on xerrors, happy to change it to use a different dependency (or create structs that implement Unwrap() manually)

all comments addressed! ptal?


Feature: map visible paragraph index to all paragraph index & vice versa

Resolves #599

AppVeyor isn't set up yet, but Travis built fine.


Simplified 'Stop/Start Charging ability ?

Is there anyway to have a simple as it comes 'start charging', 'pause' & 'stop charging' ?    (i.e. the same options shown in the app when you press on the green 'play' button at the bottom/centre of the app).
My use case is because the AC3 doesn't have two charge time slots - only the one.   What I'd like to be able to do is charge from 00:00 to 02:00, pause all battery operations and then charge again from 06:00 to 07:00    (this is trying to get the most from a cheap overnight rate whilst only having a 5.2 battery).  If I could do this by essentially just turning an entity (switch) on and off that would be easy to do.
Or should I be doing this some other way? - although if so I don't see how I am supposed to update the charge slot programatically - if I could I guess I could just set it to 00:00-02:00 at 23:00 and then set it to 06:00-07:00 at 05:00.   Am I missing the obvious ?
Thanks

Or is this an alternative sequence (and if so how do I actually do it?): -
Single timed charge setting 00:00 - 07:00
Set charge power to zero at 02:00
Set charge power to maximum at 06:00
Then leave charge power at maximum to get whatever I can from solar during the day ? Again - sounds simple but I don't know how to do it.

If it helps, I have charging slot 1 set to 00:00-23:59, and I just use HA to toggle the AC Charging Enabled switch. This essentially does away with the scheduling logic inside the inverter and replaced it with my HA automations, which works great for me.
Note the same isn't true for DC Discharging! If you're 'inside' a discharging slot, but the DC Discharging switch is off, the inverter no longer supplies the house, which usually isn't what you want

Ah, right - so the AC Charging Enabled switch becomes a   is-grid-charging/is-not-grid-charging    switch?
And when it's 'not charging' everything works as per normal eco-mode would ?

For AC Charging, yes, if you turn off the switch then it just goes back to eco mode (but not the same for DC Discharging, which is very annoying!)

@pskillen Many thanks for your suggestion - it's worked a treat!

Sounds like this has been solved.
Unfortunately every inverter is a bit different, so trying to build high level functions on top of what we have can be quite difficult, especially when testing is impossible without owning the relevant bit of kit. In this case, I suspect the "pause" you see in the app refers to battery pause mode, which is only supported on more recent equipment. The integration aligns more closely with the "Remote Control" view in the web portal, which reads & writes lower level values to control the inverter. Hopefully this approach continues to work for most users and HA give us enough power through automations to achieve what's needed.


Strings with spaces are cut in half when using gq

gq reindents selected lines and is really nice to use. It works quite good with this plugin, except when a string with reaches the 79 character mark halfway through. In that case it cuts the string in half and ruins further indenting.

I think this can be closed?!
Please re-open in case I missed something.


Set tcp_connections_established to gauge type

Resolves #407
While the ConnectionsEstablished property in the
Win32_PerfRawData_Tcpip_TCP class is listed as a counter, real-world
metric values have been shown to increase and decrease.
Documentation for the property states "Number of TCP connections for
which the current state is either ESTABLISHED or CLOSE-WAIT" which
would imply the metric is a gauge.
No other class properties have shown this behaviour.

Good find!


Add territories to Web UI languages

Based on a discussion with @kulmann and @dragonchaser, documenting the outcome.
We need a way to represent different territory settings per country or language, eg:

Swiss (special case, three major languages): de_ch, it_ch, fr_ch
German speaking: de_de, de_at
(probability of governmental regulations regarding language gendering )
Spanish speaking countries like: es_cl, es_co, es_ar, es_mx,... (south america)
Portugese speaking countries like: pt_br
...

Solution:

Add white-listing for language files being distributed to make generate to the web service
Add territory codes to the request made by the webui

This is not the request to actually support each of those special constellations, but to implement the technical ability to do so (white-listing solution). Translations from Transifex can be white-listed as needed and as they mature (company internal or via community).

product decision was not have territories, thus I don't see the need to prepare it technically. we have enough work maintaining good translations for en and de;


[Feature Request]: pdf instead of cbz

I would like to use this on a mac but zathura and zathura-cb don't work. Now this works perfectly on my Linux machine but I would like to try to use this on a mac.  I am requesting a change of complication from cbz to pdf if possible or any recommendations for cbz viewers that can be accessed via the terminal like zathura.

Mentioning this #2
You can edit script for it.
Refer this commit for it https://github.com/notprash/manga-cli/commit/ad7880457be9a9c020ca4ad680e4fab6b340a4b1
@notprash  Maybe you could add both option to download to pdf or cbz with query (-p & -z) ?
As some will prefer pdf as they are used everywhere

I really like the idea of querying for pdf or cbz @fossimprove. Also thank you for the links, it helps me a lot.

Thanks for your feature request. I will add option for change the file type.

Mentioning this #2
You can edit script for it. Refer this commit for it ad78804
@notprash Maybe you could add both option to download to pdf or cbz with query (-p & -z) ? As some will prefer pdf as they are used everywhere

what about a variable in the script
file_format="cbz" # or pdf

Well I have got my answer and understood what to do. Thank you for the support everyone.


Clarity on declarative and imperative approaches with Pulumi

Adding a section on our how Pulumi works to describe Pulumi's powerful declarative model and how this relates to using imperative languages to author y our solutions.
Description
Checklist:

[ ] I have reviewed the style guide.
[ ] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

Hey @ringods I've made some adjustments to your blog title to help with SEO and would appreciate your thoughts on how i've incorporated things into the docs. thanks!


Add string rendering, remove psr/container-implementation dependency

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

We can move code from renderProxy to renderAsString and use him instead renderProxy.

Done.

👍


Reusable function to render flags for docker run

This will make it easier to add/change flags

@mcls excellent, thanks, much appreciated.


receiver: show deploy progress in git push like flynn scale

Closes #2161
$ git push flynn master
Counting objects: 40, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (39/39), done.
Writing objects: 100% (40/40), 3.73 KiB | 0 bytes/s, done.
Total 40 (delta 20), reused 0 (delta 0)
-----> Building example...
-----> Node.js app detected

-----> Creating runtime environment

       NPM_CONFIG_LOGLEVEL=error
       NPM_CONFIG_PRODUCTION=true
       NODE_ENV=production
       NODE_MODULES_CACHE=true

-----> Installing binaries
       engines.node (package.json):  0.10.x
       engines.npm (package.json):   2.x

       Resolving node version 0.10.x via semver.io...
       Downloading and installing node 0.10.40...
       Resolving npm version 2.x via semver.io...
       Downloading and installing npm 2.14.13 (replacing version 1.4.28)...

-----> Restoring cache
       Skipping cache (new runtime signature)

-----> Building dependencies
       Pruning any extraneous modules
       Installing node modules (package.json)

-----> Caching build
       Clearing previous node cache
       Saving 1 cacheDirectories (default):
       - node_modules (nothing to cache)

-----> Build succeeded!
       └── (empty)

-----> Discovering process types
       Procfile declares types -> web
       Default process types for Node.js -> web
-----> Compiled slug size is 7.0M
-----> Creating release...
=====> Deploying release (16:56:24.198)
=====> web host-1e486c0d-9309-40f8-94bd-7c95d89cc531 starting (16:56:24.221)
=====> web host-1e486c0d-9309-40f8-94bd-7c95d89cc531 up (16:56:25.065)
To https://git.dev.localflynn.com/example.git
 * [new branch]      master -> master

We are only listening for formation changes for web process types. should we be listening for process types with suffix -web? And, if so, should we also include them in the default scale?

We are only listening for formation changes for web process types. should we be listening for process types with suffix -web? And, if so, should we also include them in the default scale?

I think it is fine for now to only default scale web=1, users can then subsequently scale other process types if need be.

Closing until the deploy system is reworked.


chore: build with typescript

esbuild has difficulty with cases like "bundle these entry points, but don't bundle these specific files, treat them as separate imports, and don't bundle them into any other files that import them". This makes it hard to load rh-gllobal-footer.js separately.
Closes #429
See https://github.com/RedHat-UX/red-hat-design-system/discussions/420#discussioncomment-3174377 (nice)
cc @eyevana
What I did

This commit replaces the per-element esbuild builds with a typescript build that uses a
typescript transform to replace import specifiers ending with css with css.js,
uses the node filesystem api to directly build shadow DOM css into their own javascript modules.

Testing Instructions
npm run build

check that the build is sane, try copying it into a separate node project and see that it works as expected. check that 11ty builds as expected

Ship it 🚢


Label argument for run commands as [PROCESS...]

Run commands that take arguments (start, stop and restart) all
take a process name as an argument.
If you do not provide a valid process, you get error such as
"Unknown proc: .."

Thank you


Not expanded default root location root='~/.mxnet/models'  in gluon/model_zoo/vision networks

Environment info
Operating System:
ubuntu 16.04
Compiler:
root='~/.mxnet/models'
Package used (Python/R/Scala/Julia):
python
MXNet version:
Or if installed from source:
Downloading mxnet-0.11.1b20170928-py2.py3-none-manylinux1_x86_64.whl (21.0MB)
MXNet commit hash (git rev-parse HEAD):
If you are using python package, please provide
Python version and distribution:
Python 2.7.12 (default, Nov 19 2016, 06:48:10)
[GCC 5.4.0 20160609] on linux2
Error Message:
Please paste the full error message, including stack trace.
when the correct file exits on disk, I got
Model file is not found. Downloading.
Minimum reproducible example
if you are using your own code, please provide a short script that reproduces the error.
from mxnet.gluon import nn
from mxnet.gluon.model_zoo import vision as models
deep_dog_net = models.densenet121(pretrained = True)
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.
What have you tried to solve it?
In this pull request,
https://github.com/apache/incubator-mxnet/pull/7892/files
there are some net.load_params(get_model_file(*,
remove default variable
root=root
or use os.path.expanduser to expand
default root location

@szha

Fix is in #8086

The problem was that the path expansion was only used in default value. The fix was to move the expansion logic into the function body for model store. The fix will be included in the next nightly build.

@szha Thank you! Do I need to close this or it will be automatically closed?

You can close now and feel free to reopen if the issue still persists in the next nightly build.

Thank you!


[BUG]: gpt2 pipeline error

🐛 Describe the bug
I use examples to run gpt2 with pipeline mode.
The command is in examples/language/gpt/experiments/pipeline_parallel/run.sh.
The error is
Traceback (most recent call last):
File "/home/guest_01/ColossalAI/colossalai/fx/tracer/tracer.py", line 295, in _meta_data_computing
attr_itr = getattr(attr_itr, atom)
File "/home/guest_01/anaconda3/envs/bloom/lib/python3.9/site-packages/torch/fx/_symbolic_trace.py", line 705, in module_getattr_wrapper
return self.getattr(attr, attr_val, parameter_proxy_cache)
File "/home/guest_01/anaconda3/envs/bloom/lib/python3.9/site-packages/torch/fx/_symbolic_trace.py", line 484, in getattr
maybe_parameter_proxy = maybe_get_proxy_for_attr(
File "/home/guest_01/anaconda3/envs/bloom/lib/python3.9/site-packages/torch/fx/_symbolic_trace.py", line 478, in maybe_get_proxy_for_attr
val_proxy = self.create_proxy("get_attr", n, (), {}, **kwargs)  # type: ignore[arg-type]
File "/home/guest_01/ColossalAI/colossalai/fx/tracer/tracer.py", line 142, in create_proxy
meta_out = self._meta_data_computing(
File "/home/guest_01/ColossalAI/colossalai/fx/tracer/tracer.py", line 308, in _meta_data_computing
raise RuntimeError(f"Could not compute metadata for {kind} target {target}: {e}")
Environment
CUDA 11.6 + Pytorch 1.13 + colossalai 0.2.7

May you tell me the version of transformers?


Bug: Unused parameter "source"

Is there an existing issue for this?

[X] I have searched the existing issues

Orb version
<EMAIL_ADDRESS>Current behavior
If I set docker-archive as value for the parameter source I expect to be able to run an analysis over a tar file on the disk. Actually the orb code doesn't use the source parameter at all.
Minimum reproduction config
docker-verify:
    steps:
      - dive/install
      - dive/check:
          source: docker-archive
          image: image.tar

The error logged in CircleCI is:

Image Source: docker://image.tar
Fetching image... (this can take a while for large images)
Handler not available locally. Trying to pull 'image.tar'...
Using default tag: latest

Other
No response

This issue has been solved in https://github.com/packituz-gttz/dive-orb/pull/3


Modify the load test faucet to only deposit when necessary

Overview
Modify the load test faucet to only do a deposit if necessary. This can greatly speed up testing by pre loading the faucet account.
Changes

Stop the faucet from always doing a deposit on init()
When asked to fund an account, the faucet checks if it has sufficient funds, and deposits more if not

Closes https://github.com/omisego/omg-load-testing/issues/44

Coverage remained the same at ?% when pulling 930d347430f616f307b142edfb93e818c46e3b69 on kevin/improve_load_test_faucet into e0279d39b2560980343f62907f50b51568d60ae0 on master.


Unable to restore wallet in ord 0.16.0-rc1

I am unable to restore a known-good ord wallet using the 0.16.0-rc1 version of ord.
 $ ./ord --version
ord 0.16.0-rc1

I start a server:
 $ ./ord server --http-port 8000
Listening on http://<IP_ADDRESS>:8000

I leave that running and execute this in another window:
 $ ./ord wallet --name TEST123 --server-url http://<IP_ADDRESS>:8000 restore --from mnemonic

...and then I get a cursor on the new line. I assume I am supposed to type in my space-separated mnemonic here, on one line? When I do, and press enter, the cursor advances to the next line and then nothing happens. Am I doing something wrong, or is this broken?
Restoring the same wallet in ord 0.15.0 works fine:
 $ ./ord --version
ord 0.15.0

 $ ./ord wallet --name TEST1234 restore "phrase redacted phrase redacted phrase redacted phrase redacted phrase redacted phrase redacted"
{}

I also just tried entering the mnemonic one word per line. That didn't work either.

https://github.com/ordinals/ord/blob/0529f3e4f4715270006c7b03d232ab0cea749970/src/subcommand/wallet/restore.rs#L30
for read_to_string , when you input end In the terminal, you can input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems) .

@so7ow for your example:
 $ ./ord wallet --name TEST123 --server-url http://<IP_ADDRESS>:8000 restore --from mnemonic

after  input your mnemonic, you must input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems).

@raphjaph BTW,  Is io::stdin(). read_line(&mut buffer)? a better choice instead of io::stdin().read_to_string(&mut buffer)?;

Thank you, I'll give that a try. If that's truly required, some notice to the user would seem to be in order!

@so7ow for your example:
 $ ./ord wallet --name TEST123 --server-url http://<IP_ADDRESS>:8000 restore --from mnemonic

after input your mnemonic, you must input EOF (End of File) by pressing Ctrl + D (on Unix/Linux systems) or Ctrl + Z (on Windows systems).

That worked! 👍🏻

I've fixed this and written some documentation in #3237


Cloudflare Zero Trust session revocation handling

Cloudflare Zero Trust, as explained in this guide, can be used to configure external/better/safer/more-convenient authentication. However, there's an issue with session expiration: Whenever a session expires (this can be forced as explained in cloudflare zero trust's session management docs, the app UI will show as "offline" (red header), and the JS console will show the following message:

Access to fetch at 'https://lutzky.cloudflareaccess.com/cdn-cgi/access/login/MY_SILVERBULLET_DOMAIN_REDACTED?kid=LONG_REDACTED_STRING&redirect_url=%2FProjects%2FSilverBullet.md&meta=LONG_REDACTED_STRING' (redirected from 'https://MY_SILVERBULLET_DOMAIN_REDACTED/Projects/SilverBullet.md') from origin 'https://MY_SILVERBULLET_DOMAIN_REDACTED' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

This is true for version 0.9.4. It is possible that https://github.com/silverbulletmd/silverbullet/commit/f7fe7cadbcc2b36bbc2049199fcb8cc46e056283 changes this, but I'm opening this issue anyway to make sure it doesn't get missed while working on #1028. What we should see is a full-fat redirect.
I guess this is a known issue for the general case, e.g. this 2019 report about the same issue for a different app, but I figure that the app can be customized to overcome this.
Workarounds:

On machines with keyboards running Chrome, Ctrl-Shift-R issues enough of a reload to allow re-authentication.
On machines without keyboards (e.g. Android phones), there does not appear to be a way to "reload that hard" - and only a "delete site data" bit works, thereby causing a full re-sync (and losing any data you wrote while offline).

Yes I think this is the same issues as #1028 but here it's blocked due to CORS. What I need to figure out how to detect this is happening when I perform the fetch, if I can (i'd have to create a setup that replicates this) detect this I can attempt the unregister service worker and reload approach.

That makes sense. I'm thinking something along the lines of accessing a test instance through a proxy that will usually just forward traffic to real-silverbullet, but on-command will start redirecting to https://example.com/ (that should be "distant enough" CORS-wise); indeed, detecting that that happened and doing an unregister-and-reload should do the trick.

Indeed, this reproduces the condition:

Start a local server (default port 3000), set it to sync mode
Open browser, write some files
Kill the server
Run the following:

while true; do echo -ne "HTTP/1.1 301 Moved Permanently\r\nLocation: https://example.com\r\n\r\n" | nc -N -l -p 3000; done

Indeed, this generates the following error:

Access to fetch at 'https://example.com/' (redirected from 'http://localhost:3000/index.md') from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Desired behavior - the browser should redirect to https://example.com.

I pushed something to main. Could you try if this solves it for you? It's in the edge build.

There's definitely some weirdness going on. I need to improve my test setup and take a better look at this tomorrow, but one thing that I can already clearly identify is that it re-re-redirect to /.auth multiple times (I also use SB_AUTH), and that it overwrites my SETTINGS with its own version. I probably shouldn't test on the prod version of my space :thinking:.

Also - what is the intended upgrade mechanism? That is, I think I had to "delete all site data" for a new version of the upstream to load... but then again maybe I didn't. What's the intended UX, and how does one check?

Why would you use two levels of auth? I'd disable SB_USER if you use CF for authentication.
Upgrading on the server depends on if you use docker or Deno. On the client simply reloading the page 2-3x to be safe should be sufficient, no cleaning of any data.

The reason I have two levels of auth is that I want to still require authentication within my home network (e.g. what if my ISP goes down, I want to investigate, and I'd like to use silverbullet to take notes for that). If this is a problem, I could work around it by having a no-SB_USER instance exposed only to localhost (and therefore cloudflare), and expose a separate instance during emergencies. Would be nice to explicitly say "this isn't supported" in the docs.
For now, I'm testing without SB_USER - so far so good, I'm setting a shorter auto-expiration to see what happens (explicit expiration is somewhat more violent).
Upgrading the server I understand (I use docker), as it's clearly "new version means restart the server binary". What I mean is, on the client, how do I know if I'm indeed using an up-to-date client and not just a cached version of the previous one? Is it Help: Version? Maybe we can add a commit ID to that to help debug?

Hmm, now it does seem to work with SB_USER as well. Tests I ran include:

Reducing cloudflare session expiration timeout to 15 minutes and waiting it out
Changing SB_USER and restarting the server

In both cases it seems to be doing the right thing.
I'll now try with a hard re-auth (cloudflare's "revoke sessions" button), which was giving me some trouble before, but I know it refuses to re-auth the user for at least a few minutes.

And, yeah, "revoke sessions" re-authenticated correctly as well. I think some of my synthetic testing with "redirect to example.com" was causing some unrealistic problem with the CORS headers and such, but this seems to work fine!

Ok happy to hear it. Finally 😆

I'm guessing this is fixed by a combination of https://github.com/silverbulletmd/silverbullet/commit/cb88eae8858b46dcdb4d94776a123a9636e1a872 and https://github.com/silverbulletmd/silverbullet/commit/4eae0c975b7ea75ecbfc967f17d0d6e9bd7679ed. Any more tests you'd like me to run, or do we close this?

I'll close it. We can always reopen when more issues appear. I hope not, because this has been quite a pain and I'm running into hard browser limits.


put multitool on syndie holster

About the PR
sus box has holster and all tools
holster can fit all tools except multi which is annoying

(all other tools are allowed as they are melee weapons)
now it also allows multitools
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

tweak: Syndicate shoulder holster now has a pocket for a multitool.

Isn’t the holster supposed to only hold guns and ammo?

yes but since it can store any melee weapon, it can hold just about anything (but not multitool argh)

yes but since it can store any melee weapon, it can hold just about anything (but not multitool argh)

thats more of a side-effect thank something intended, whitelisted storages should remain more specific than vague

will make it just whitelist multitool in a bit

will make it just whitelist multitool in a bit

thats not the problem imo, the reason the holster can hold those tools in the first place is because they are regarded as valid melee weapons when they shouldnt, making it also hold multitools does not solve that

then why would the sus box have a holster and not a utility belt?

then why would the sus box have a holster and not a utility belt?

Looks like an oversight by the holster PR’s author, it would make more sense for the holster to be unable to hold melee weapons and a utility belt going in the toolbox


Cannot set properties of undefined Type Error for React Moment package

Describe the bug
I'm migrating one of our projects at my company to Vite from CRA, and I see the following error in the console when I navigate to the locally hosted application in my browser:

See also the log file:
localhost-1647615535049.log
Needless to say, this wasn't an issue when we were using CRA.
I've tried a number of work arounds myself, but to no avail.
Happy to share if they're of interest.
Would love to find a fix for this as CRA is painfully slow for running a local development environment and building our project for production.
Thank you!
Reproduction
https://stackblitz.com/edit/vitejs-vite-vvkwaa
System Info
System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 1.05 GB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 16.2.0 - ~/.nvm/versions/node/v16.2.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.2.0/bin/yarn
    npm: 7.13.0 - ~/.nvm/versions/node/v16.2.0/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 99.0.4844.74
    Firefox: 94.0.2
    Firefox Developer Edition: 98.0
    Safari: 14.1.2
  npmPackages:
    @vitejs/plugin-react: ^1.2.0 => 1.2.0
    vite: ^2.8.6 => 2.8.6

Used Package Manager
npm
Logs
N/A (no errors when running vite or vite build)
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This issue is simillar to #7053.

react-moment(cjs) is importing moment by import (which is transpiled to require) here.
moment is resolved to moment/dist/moment.js(esm) by jsnext:main field.

After prebundle, module.exports = { default: Moment } but react-moment expects it to be module.exports = Moment so the error occurs.

I digged down a bit more.
moment is resolved by jsnext:main field here.
https://github.com/vitejs/vite/blob/fe4c1edbe009e1df340b4d879c02d2e57a6cd7f0/packages/vite/src/node/plugins/resolve.ts#L773-L780
So for a workaround setting resolve.mainFields to [] will work.
I am not sure whether it is ok to change !entryPoint || entryPoint.endsWith('.mjs') to !options.isRequire && (!entryPoint || entryPoint.endsWith('.mjs')) like #7438.

Can confirm that the above work around resolves the issue:
https://stackblitz.com/edit/vitejs-vite-3kngck?file=vite.config.js
Thanks @sapphi-red!

Closing as #7582 should fix this issue too.

@bluwy , the latest version of Vite (2.9.1) doesn't resolve the issue:
https://stackblitz.com/edit/vitejs-vite-skvjpc?file=package.json
I'm assuming a build with the fix just hasn't been released it.
When can we expect a new version that has the fix?
Thanks!

Yes, it will be in 2.9.2, probably in a few days. We have some CI issues to check first.

Sounds good. Thank you @patak-dev for the prompt reply!

I am getting this error from a library Ros.js:36 Uncaught TypeError: Cannot set properties of undefined (setting 'socket').
How do I fix this, the workaround is not working.

The same thing happened to me and here  I found the solution for my part, it works fine, you just have to modify the file vite.config.js and also install the plugin

The same thing happened to me and here #6675 (comment) I found the solution for my part, it works fine, you just have to modify the file vite.config.js and also install the plugin

It worked for me as well, thanks Jair :)

those who created react app with vite can get the issues like that can be resolve by using this just

those who created react app with vite can get the issues like that can be resolve by using this just

you're the king here! simple, no show off words. plain solution. other people who try to show off by using technical terms can go f themselves.

Sorry is this a good comment for me or a bad because i m not good at kuch English

Very Good comment brother. You are the only one who explained the solution
very clear. Others just used fancy technical terms to show off.
On Fri, 14 Apr 2023, 18:59 Deependra Singh, @.***>
wrote:

Sorry is this a good comment for me or a bad because i m not good at kuch
English
—
Reply to this email directly, view it on GitHub
https://github.com/vitejs/vite/issues/7376#issuecomment-1508506932, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5FPL4DTTKS3C72L5VVXQU3XBFGMXANCNFSM5RCDVMOQ
.
You are receiving this because you commented.Message ID:
@.***>

The same thing happened to me and here #6675 (comment) I found the solution for my part, it works fine, you just have to modify the file vite.config.js and also install the plugin

Worked for me. Thanks!!

I am not using CRA for a project and unfortunately the issue persists even with @trdxDeepu 's solution.

I had some luck when importing moment.js directly as an ESM module by overriding the module resolution to the source file in node_modules.
import { defineConfig } from "vite";
import react from "@vitejs/plugin-react";
import path from "path";

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [react()],
  resolve: {
    alias: [
      {
        // Allow moment.js to be used as an ESM module
        find: /^moment$/,
        replacement: path.resolve(__dirname, "./node_modules/moment/moment.js"),
      },
    ],
  },
});

Still problem after npm run build

those who created react app with vite can get the issues like that can be resolve by using this just

Beware of using this workaround. This basically tells vite to ignore “browser” property of the package.json of all your dependencies and will break manage packages such as axios, engine-io/client, and more.

TLDR: for people using moment, set resolve.mainFields: ['browser', 'module', 'jsnext'] for now
Moment only exposes ESM files via the legacy jsnext:main. Because the module field (which was supported by rollup and webpack) was not set for a long time, some packages depending on moment does not expect moment to be ESM (https://github.com/moment/moment/commit/9ce89e7fea881b39be23b8c0646f7ef7817985d9, https://github.com/moment/moment/commit/0c709ba7e463c12c68d7bf217fbdff4ed3b46f2c). But later on Vite has been made and included jsnext:main field to resolve.mainFields without knowing that fact. That made those packages depending on moment not to work like the OP in this issue. Given that Vite has been included jsnext:main field by default, it's probably better to avoid removing otherwise it might break other things. So in conclusion, for users using dependencies using moment, please set resolve.mainFields: ['browser', 'module', 'jsnext'] so that the ESM version of moment won't be used.


Compare json object values instead of byte streams when matching bodies that are content-type json

Resolves #3171

Located a hole in the logic where we don't properly handle when the body doesn't parse even when it's marked as json (this happens for deliberate error cases).
This test in java turned it up. Newest commit protects against the unexpected exception + resolves the test invocation locally.


Skip broken tests

Codecov Report

Merging #12191 (2ac49e6) into main (51f8dcd) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #12191   +/-   ##
======================================
- Coverage     70%      70%   -1%
======================================
  Files        500      500
  Lines      31638    31638
  Branches    4940     4940
======================================
- Hits       22278    22209   -69
- Misses      7491     7533   +42
- Partials    1869     1896   +27

Impacted Files
Coverage Δ

...otebooks/debugger/controllers/restartController.ts
50% <0%> (-36%)
:arrow_down:

...ebooks/debugger/controllers/runByLineController.ts
76% <0%> (-11%)
:arrow_down:

src/kernels/installer/productInstaller.node.ts
74% <0%> (-5%)
:arrow_down:

.../notebooks/debugger/debugLocationTrackerFactory.ts
96% <0%> (-4%)
:arrow_down:

src/notebooks/debugger/kernelDebugAdapterBase.ts
76% <0%> (-4%)
:arrow_down:

...aw/finder/contributedLocalKernelSpecFinder.node.ts
83% <0%> (-4%)
:arrow_down:

src/notebooks/controllers/connectionDisplayData.ts
87% <0%> (-4%)
:arrow_down:

src/kernels/helpers.ts
72% <0%> (-3%)
:arrow_down:

...tive-window/debugger/jupyter/kernelDebugAdapter.ts
60% <0%> (-2%)
:arrow_down:

src/notebooks/debugger/debuggingManagerBase.ts
65% <0%> (-2%)
:arrow_down:

... and 10 more