Updated point Reliability. (What makes Reliable Services different)

Reliability : For stateful services, your state is preserved even in the absence of network or other failures.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@viveksinghnegi7 : Thanks for your contribution to the Azure documentation! The author, @masnider, has been notified to review your proposed change.

Hi @viveksinghnegi7 - what the document is saying is correct. Service Fabric will preserve your state even when there are failures (when those failures are present). I'll try to reword it to make it a little more clear in my next revision, but you can close this PR for now.
Thanks for taking a look and helping out!

Thank you
On 12-Oct-2017 11:47 PM, "Matt"<EMAIL_ADDRESS>wrote:

Hi @viveksinghnegi7 https://github.com/viveksinghnegi7 - what the
document is saying is correct. Service Fabric will preserve your state even
when there are failures (when those failures are present). I'll try to
reword it to make it a little more clear in my next revision, but you can
close this PR for now.
Thanks for taking a look and helping out!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/pull/2800#issuecomment-336222082,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUWfhpfarXb9oo7FtZArajmaJNSdqPyUks5srleggaJpZM4O7IBy
.

#please-close


Consistent approach to identifiers/accessions and their associated versions

Our current sequence feature #19 proposal refers to identifiers (id) however example payloads describe these as a single field without a version. This issue is here to collate examples of the use of identifiers in the wild and how versioning is modelled in payloads or in other standards.

Ensembl holds an identifier as a separate field to its version. This is persisted into our core database schemas where stable ids are strings and versions are ints. Creating the ID.VERSION string requires domain knowledge to know you can concat both together with a . mark.
This persists into our REST API representations where id and version are separate fields.
A version increment for transcripts has meant different things over time but now it represents a change in the splicing or resulting sequence (CDNA, CDS, peptide). Those sequences can also be influenced by sequence edits e.g. selenocystine edits. Gene version increments mean there's a change to the underlying transcript set. Proteins when there is a change in the peptide sequence. Note the transcript logic changed post GRCh38 so we have identical versioned transcripts on 37 and 38.
Feedback from the clinical community has stated that having versioned stable ids is essential for clear tracking.

It comes down to being very precise about defining the identifier that represents a stable concept accurately.
Based on @andrewyatz description above, the "transcript" concept defined by the ensembl id alone does not include the specificity of  representing "...a change in the splicing or resulting sequence (CDNA, CDS, peptide)." A version appended to the ensembl id represents the more specific concept. This is a critical difference and we should take care to recognize the differences between the concepts defined by the identifier represented by just the ensembl "id" versus the identifier represented by the ensembl "id+ver".  These can both be relevant and useful identifiers that distinguish two dependent or associated concepts that are different and important to distinguish (as they seem to be).
Let's not get tied down with presuming that just because there's an "id" that it is the only concept and all versions of it are really the same thing. Each version "or instance" of the "id"s general concept are dependent but should not be considered equal.

in some cases "versioning" can be changes to a single thing over time - or change events to a single concept. And in other cases, it can be different forms of a similar things, where the "un-versioned" concept is more of a generalization and does not contain any of the specificity associated with any one version.

Hey @larrybabb. Yes your comments did address the issue but also I am unsure with the current state of VA if this is a continued valid concern.
The concepts that IDs (with or without versions) represents needs to be understood based on the provider and our examples should represent the best case scenario for a data point. Otherwise implementations may incorrectly assume what is meant by a field (ID in GFF3 is a perfect example of this). More details about a specific example below.

Going back to #19 though there is a section which states:
exonNumber: "4/4",
gene: "APOE",
transcript: "ENST00000252486"

Stating ENST00000252486 is insufficient to recapture what actually was exon 4 as the number of exons and its splicing within a transcript is permitted to change. If the original data source only recorded ENST00000252486 there's not a lot we can do. If the model examples omit version numbers where they are essential then lossy statements will be produced. ENST00000252486 has been through 9 versions, the latest being a truncation in the 5' UTR. That would not be important to this specific statement but would be if the exonNumber was 1/4.


Default collection formatter not throwing exception

Regarding issue #392, this implementation of the default collection formatter now does not throw an exception. In my opinion, it is not a good solution to throw an exception in default implementation because this throws an exception on an not supporter language (I had this with German and Danish).

I don't believe this will handle Cyrillic languages,  Asian langues, Arabic, or Greek correctly. There may be others I can't think of at the moment as well.

@justin-edwards what's wrong with Cyrillic languages?

I think DefaultCollectionFormatter should return string without any additional separator, just string.Join(", ", items);

@hazzik, sorry, I had intended to remove Cyrillic languages from that list after I researched it. I may have had bad info on Greek as well (I spoke with someone fluent, but further research contradicts what they said).

@MehdiK, @mexx what'd you say?

@hazzik I find the idea of & a little better as ,. We already have other areas where the default going to some English inspired implementation. So I'm OK with &.
For me default implementation should produce following output:
new[] { "a", "b" }.Humanize() = "a & b"
new[] { "a", "b", "c", "d" }.Humanize() = "a, b, c & d"

I'm with @mexx on this. Also regardless of the default, if one is interested in a better formatter they should just provide their separators in the config.

I resolved the raised issues, rebased and pushed the code. Thanks.

This is now released to NuGet as v1.35.0. Thanks for the quick fix.


Form validation triggered when displaying hidden form control

Describe the bug
Clarity forms validation is triggered when a hidden form control is displayed (using *ngIf).
A reactive form with one required field and one optional field hidden by default. There is a button that toggles the visibility of the optional field.
When the optional field is shown, form validations are displayed for all form controls, even if they haven't been touched.
How to reproduce
https://stackblitz.com/edit/dynamic-input-validation-demo?file=src/app/app.component.html
Steps to reproduce the behavior:

Click on "Edit Description" button without touching the Name input
See validation error is shown on the Name input

Expected behavior
No validation error is shown - the form control is not touched or dirty.
Versions
App

Angular: 10.2.1
Clarity: 4.0.5

Device:

Type: MacBook
OS: macOS Catalina
Browser: Chrome
Version: 86

Additional Notes
If the hidden field is required, its validation would also be triggered.

Any buttons within a form, without specified type are implicitly considered as Submit buttons. That's why your forms validates on clicking the button.
You could either move the button outside the form, or add type="button" to it and it won't trigger validaiton.


babel error on first install and run dev

Hi
I'm running locally the latest main, and hitting a babel error right away. My node version is 20.6.0. Computer is a M1, OS Ventura 13.5.1 (22G90). This is the error after running npm install and then npm run dev:
astrowind 🤡 npm run dev

<EMAIL_ADDRESS>dev
astro dev

/Users/repos/ccs/astrowind/node_modules/@babel/core/lib/index.js:7
Object.defineProperty(exports, "File", {
^
TypeError: Cannot redefine property: File
at Function.defineProperty ()
at Object. (/Users/repos/ccs/astrowind/node_modules/@babel/core/lib/index.js:7:8)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
at Module.load (node:internal/modules/cjs/loader:1091:32)
at Module._load (node:internal/modules/cjs/loader:938:12)
at Module.require (node:internal/modules/cjs/loader:1115:19)
at require (node:internal/modules/helpers:130:18)
at Object. (/Users/repos/ccs/astrowind/node_modules/@babel/core/lib/config/helpers/config-api.js:16:14)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
Node.js v20.6.0
My guess is incompatability with this babel version in my environment. I'm not sure which dependency is installing that version. I'll try manually installing different versions. Thanks!

Noting I'm finding out that this is probably an issue with Node 20.6.0 if others are encountering this: https://github.com/microsoft/typespec/pull/2373

Hello everyone, we know about the long delay. We were working on a complex project, we are back. In the discussion area we will present the new fixed and defined update schedule. Thanks for the patience.


Enhance resource mgr to support remote connection

Just track this as a potential enhancement. This will need well design to prevent a lot of network security issues such as DoS, access control, connection encryption, etc.

Won't fix. Resourcemgr has been deprecated. This would be a welcome addition to the new implementation though. When that's released we should reconsider this enhancement.


Fixed wires color codes and added a comment with wiring instructions

Hi, I changed the colors of the wires as reported by @CarVac in the issue #3.
To prevent confusion for those not using the SO3-ToolBoard (like me :) ), I also included a brief comment at the top describing the connector, taking inspiration from the image found in the official SO3 page.
Let me know if it's ok for you and if I should do something with the version number/release date before merging this request.
fixes #3

I guess the colors references should be completely removed...

I see a similar change has been done in commit 0fed9e36019792186085c31b19183c1ae314cd54, so I'll close this pull request as it's no longer needed. As an additional note I would add a link to the reference image in the website, reading only the configuration it's hard to tell which pin is "SO3 Pin1". I know I'm being very pedantic on this, but I think it's worth to avoid any possible misinterpretation by people buying this extruder, even though is very well done and hard to break.


config.properties should be configurable and optional

Characteristics

Issue Type: feature

Description
botsing should not rely on a config file inside a fixed folder, but this should be outside of it and configurable. And maybe optional.
Example:
https://github.com/STAMP-project/botsing/blob/bb093a838fdaf28865a945fad11d9f95e136352f/botsing-reproduction/src/main/java/eu/stamp/botsing/CrashProperties.java#L99

Hi @luandrea
The parameters which passed in the config file can be set by Command Line too. The CLI parameters override those in the config file.

Hi @pderakhshanfar,
I will check that and let you know if I have problems.
What about the reference to the config file?


README.md updated

README.md was updated with many improvements!
Additions

README documentation details about the errors Object

Changes

Corrections to the README

Review

@ascott1, @marteki, @niqjohnson - It's not perfect, but give it a read and let me know what you think!

Animated GIF
Chuck's Theory of Github Repo Documentation:

I added a suggestion as a line note, but addressing it is not a requirement for me for shipping. Overall, this looks great! :+1: from me.

:+1:
Looks clear and concise to me.

:shipit:

@marteki - Definitely a good idea. I still have another iteration in mind for these docs, so I will take your suggestion when I do that.


[DOCS] Add a linter to the project for copyright and license verification

Signed-off-by: Michael Robinson<EMAIL_ADDRESS>
Problem
The project lacks a way to check new source files for copyright and license lines. A linter could be used for this purpose.
Closes: #ISSUE-NUMBER
Solution
This PR is a testbed/experiment in using a linter to check for copyright and license lines in the project.

Note: All schema changes require discussion. Please link the issue for context.

[ ] Your change modifies the core OpenLineage model
[ ] Your change modifies one or more OpenLineage facets

If you're contributing a new integration, please specify the scope of the integration and how/where it has been tested (e.g., Apache Spark integration supports S3 and GCS filesystem operations, tested with AWS EMR).
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[ ] Your changes are accompanied by tests (if relevant)
[x] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)

Codecov Report

Merging #864 (a8a4037) into main (674e4c2) will decrease coverage by 18.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #864       +/-   ##
=============================================
- Coverage     84.56%   65.65%   -18.92%
  Complexity       55       55
=============================================
  Files            72       17       -55
  Lines          3038      230     -2808
  Branches         20       20
=============================================
- Hits           2569      151     -2418
+ Misses          442       52      -390
  Partials         27       27

Impacted Files
Coverage Δ

...ion/common/openlineage/common/provider/bigquery.py

client/python/openlineage/client/facet.py

...egration/common/openlineage/common/sql/__init__.py

integration/airflow/openlineage/airflow/utils.py

...age/common/provider/great_expectations/__init__.py

...neage/common/provider/great_expectations/action.py

integration/airflow/openlineage/airflow/adapter.py

...ntegration/common/openlineage/common/sql/parser.py

.../openlineage/airflow/extractors/mysql_extractor.py

integration/dagster/openlineage/dagster/cursor.py

... and 45 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[WIP] Shifud

Shifud
How do I run it locally
for f in plugins/*.go; do go build -buildmode=plugin -o "${f%.go}.so" "$f"; done
go run main.go

Running in docker
docker build -t shifud .
docker run -p 8080:8080 shifud

Shifud Plugin Development Guide
Shifud is a flexible network scanning tool with an extensible plugin system. This guide will help you create and integrate a new plugin into the Shifud system.
Understanding the Plugin System
Shifud uses Go's plugin package to dynamically load plugins at runtime. Plugins are compiled as shared libraries (.so files) and loaded from the plugins folder. Each plugin must implement the ScannerPlugin interface, which is defined in the shifud.go file:
type ScannerPlugin interface {
	Scan() ([]DeviceConfig, error)
}

Creating a New Plugin

** folder.**  Name the file based on your plugin's functionality, e.g., http_scanner.go.
** interface.**  For example:

package plugins

import (
	"example.com/Shifud/shifud"
	"fmt"
)

type HttpScanner struct{}

func (s *HttpScanner) Scan() ([]shifud.DeviceConfig, error) {
	fmt.Println("Scanning with HTTP scanner...")
	// Add your plugin logic here
	return nil, nil
}

var ScannerPlugin HttpScanner

** function.**  This is where you'll add the core functionality of your plugin. The Scan() function should return a slice of DeviceConfig objects and an error if something goes wrong.
Compiling and Loading the Plugin
Compile the plugin as a shared library.  Use the following command to compile your plugin:
go build -buildmode=plugin -o plugins/*.so plugins/*.go

You can also build all plugins yourself with the following command:
for f in plugins/*.go; do go build -buildmode=plugin -o "${f%.go}.so" "$f"; done

Replace your_plugin_name with the appropriate name for your plugin.
file.  The LoadPlugins function in the shifud.go file handles the loading of plugins. It is called in the main.go file as follows:
err := shifud.LoadPlugins(scanner, "plugins")
if err != nil {
	fmt.Println("Error loading plugins:", err)
	os.Exit(1)
}

With these steps, your new plugin will be loaded and used by Shifud at runtime. You can create additional plugins by following the same process, and Shifud will automatically load and use them.
Testing Your Plugin
After creating and loading your plugin, run the main.go file to test your plugin's functionality. If everything is set up correctly, you should see the output of your plugin's Scan() function when Shifud runs.

@frankhli843 we'd better consist with the folder structure of existing repo. should move shifud as a subfolder under /pkg?


Improve scalability for embedded DNS server

The external dns library used by the DNS server is setting up the socket in blocking mode causing inefficient use of the goroutines.

@sanimej It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?

Thank you!
This issue will be automatically closed in 1 week unless it is commented on.
For more information please refer to https://github.com/docker/libnetwork/issues/1926


Feature Request - Verified accounts with verified ranking from go servers

It would be great if there were a way to verify user accounts with go rankings from one of the major internet servers.  Since it is possible to pull KGS data (http://kgs.gosquares.net/) and probably OGS data, it would be good if accounts could verify user's skill level.  This would add more trust to the commenting system.

This is something I thought about when creating GoKibitz, as I definitely sympathize with the desire to have the rank commenters claim have some reliability to it. A person's rank is important context to their comments, not that one should ever not carefully listen to a weaker player, but it gives an idea how much strength a player has backing up their arguments.
However, I can't really see how a verified user rank would work in practical terms, since I don't want there to be any requirement that people use a particular server. Also, I'd have to have authenticated integration with that server or else anyone could claim anyone else's rank, and only OGS really offers any robust API.
So, as with many things, I've chosen the simple route. Rank goes by the honor system, and so far it's worked out well.
Thanks for raising the issue!


ENH: Update minimum required CMake version in examples.

Update minimum required CMake version in examples to conform to current
ITK requirements.

Looks like the OpenSlide library is not present in the CI docker containers. Any chance to do this @thewtex @fbudin69500 ?

I took a look at OpenSlide, and it does not build with Visual Studio. The macOS and Linux builds have many dependencies. So, I think we should disable the AppVeyor build and keep a look out for Conan.io, etc. builds that can build it with dependencies from source. I could not find one that works at last check.

Opened issue #24 to keep track of the CI issues. Merging this PR then.


Improve Readme

There are a lot of typos in there, and a lot of things I'm not really comfortable with having in the readme. The explanation block is simply to explain why it's impossible to block parts of the internet, from a technical perspective. The rest is unnecessary.


typo: fixed typo in event-sourcing-content.md

There was a tiny typo in the docs

Learn Build status updates of commit ffe45e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/patterns/event-sourcing-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks @shahabganji


Multiple singletons when retrieved with different class keys

Hi there,
I recently encountered a subtle bug, where I ended up with two instances of a singleton. During a refactoring I introduced an interface to a singleton class. Older parts of the code are still injected with the class, newer parts are using the interface, which is bound to that implementation class.
I wrote some unit tests to illustrate this issue: Commit 512107c
I am not quite sure about the best course of action here. Maybe the generated factory should cache the instance for singletons instead of always creating a new instance?
P.S. Keep up the good work :thumbsup:

This is not a bug and I don't see any workaround that could make sense.
By creating to bindings, they get converted to 2 internal providers in TP. And both of them will use the singleton implementation class's factory to create a different instance.
The problem here is to use 2 bindings for a singleton using the to(impl.Class) bindings. For instance, using an instance of the singleton, manually constructed, and then associating it to both key classes would work. Here there is nothing we can do really. Devs should simply not do that. But I agree it's not easy to get and it requires some knowledge of TP internals to understand what happens.
The only thing we could do would be to detect this situation in a check at runtime for the development config. But it will quickly become very very very complicated to intercept that for all possible cases. I don't think it can even fully make sense.
It s good we have a ticket in case people face the same issue but I can't find any workaround.

One solution I found to have the same singleton instance bound to different types in Toothpick is to declare a Provider for each extra type, where the base type is injected in the constructor of the Provider and the get() method simply casts it to the correct type and returns it.

Yes, that's the right way to do it. Thx. FYI: this is a duplicate of https://github.com/stephanenicolas/toothpick/issues/327


How to patch?

You can apply our changes to create-react-app by downloading this patch file to your computer then using the steps to apply it using the information below:
sps-create-react.patch.zip

Taken from https://www.devroom.io/2009/10/26/how-to-create-and-apply-a-patch-with-git/

Applying the patch
… who will apply the patch you just sent! But, before you do that, there are some other steps you should take.

First, take a look at what changes are in the patch. You can do this easily with git apply

git apply --stat fix_empty_poster.patch

Note that this command does not apply the patch, but only shows you the stats about what it’ll do. After peeking into the patch file with your favorite editor, you can see what the actual changes are.

Next, you’re interested in how troublesome the patch is going to be. Git allows you to test the patch before you actually apply it.

git apply --check fix_empty_poster.patch

If you don’t get any errors, the patch can be applied cleanly. Otherwise you may see what trouble you’ll run into. To apply the patch, I’ll use git am instead of git apply. The reason for this is that git am allows you to sign off an applied patch. This may be useful for later reference.

git am --signoff < fix_empty_poster.patch

Applying: Added specs to test empty poster URL behaviour
Applying: Added poster URL as part of cli output
Okay, patches were applied cleanly and your master branch has been updated. Of course, run your tests again to make sure nothing got borked.

In you git log, you’ll find that the commit messages contain a “Signed-off-by” tag. This tag will be read by Github and others to provide useful info about how the commit ended up in the code.

The version 2.4.6 is included in the package.json in the patch. You will have to edit that to match which ever version you wish to publish, then run npm publish. That's pretty much it.


bullnose, cerniture

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,c]

/trunk merge


Problem serializing std::tuple

I am not able to get tuples to serialize using g++ 11.3.0 on ubuntu 22.04.
Here's my program
#include <alpaca/alpaca.h>
#include <tuple>
std::tuple<int, double> t(1, 2.3);

std::vector<uint8_t> bytes;
auto bytes_written = alpaca::serialize(t, bytes);

which fails to compile as follows
g++ -std=c++17 -I../build/_deps/alpaca-src/include/ test_alpaca.cpp
In file included from ../build/_deps/alpaca-src/include/alpaca/alpaca.h:9,
                 from test_alpaca.cpp:1:
../build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h: In instantiation of ‘constexpr decltype(auto) alpaca::detail::get(type&) [with long unsigned int index = 0; type = const std::tuple<int, double>&; long unsigned int arity = 4]’:
../build/_deps/alpaca-src/include/alpaca/alpaca.h:139:60:   required from ‘void alpaca::detail::serialize_helper(const T&, Container&, std::size_t&) [with alpaca::options O = alpaca::options::none; T = std::tuple<int, double>; long unsigned int N = 4; Container = std::vector<unsigned char>; long unsigned int I = 0; std::size_t = long unsigned int]’
../build/_deps/alpaca-src/include/alpaca/alpaca.h:156:62:   required from ‘std::size_t alpaca::serialize(const T&, Container&) [with T = std::tuple<int, double>; long unsigned int N = 4; Container = std::vector<unsigned char>; std::size_t = long unsigned int]’
test_alpaca.cpp:8:39:   required from here
../build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h:41:11: error: 4 names provided for structured binding
   41 |     auto &[p1, p2, p3, p4] = value;
      |           ^~~~~~~~~~~~~~~~
../build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h:41:11: note: while ‘const std::tuple<int, double>’ decomposes into 2 elements

Any thoughts appreciated.
Thanks,
Mike

It looks like the problem is with it computing the aggregate arity wrong for tuple. Adding the following specialization seems to fix at least on g++12 (although there is another problem on g++11).
template<typename ...Ts>
struct aggregate_arity<std::tuple<Ts...>> : std::make_index_sequence<sizeof...(Ts)> {};

alpaca::serialize is designed for a struct input. Does it work if you wrap your tuple inside a struct? Like so:
struct MyType {
  std::tuple<int, double> t(1, 2.3);
};

Thanks for the quick response. Unfortunately, same problem if I write it with MyType
#include <tuple>
#include <vector>
#include <cstdint>

std::vector<uint8_t> bytes;

struct MyType {
  std::tuple<int, double> t{1, 2.3};
};
MyType m;
#include <alpaca/alpaca.h>

auto bytes_written = alpaca::serialize(m.t, bytes);

which again produces
build] /usr/bin/g++-12  -I/home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include -g -std=c++20 -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT test/CMakeFiles/test_alpaca.dir/test_alpaca.cpp.o -MF test/CMakeFiles/test_alpaca.dir/test_alpaca.cpp.o.d -o test/CMakeFiles/test_alpaca.dir/test_alpaca.cpp.o -c /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/test/test_alpaca.cpp
[build] In file included from /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/alpaca.h:9,
[build]                  from /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/test/test_alpaca.cpp:1:
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h: In instantiation of ‘constexpr auto& alpaca::detail::get(type&) [with long unsigned int index = 0; type = const std::tuple<int, double>&; long unsigned int arity = 4]’:
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/alpaca.h:139:60:   required from ‘void alpaca::detail::serialize_helper(const T&, Container&, std::size_t&) [with alpaca::options O = alpaca::options::none; T = std::tuple<int, double>; long unsigned int N = 4; Container = std::vector<unsigned char>; long unsigned int I = 0; std::size_t = long unsigned int]’
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/alpaca.h:156:62:   required from ‘std::size_t alpaca::serialize(const T&, Container&) [with T = std::tuple<int, double>; long unsigned int N = 4; Container = std::vector<unsigned char>; std::size_t = long unsigned int]’
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/test/test_alpaca.cpp:16:39:   required from here
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h:41:11: error: 4 names provided for structured binding
[build]    41 |     auto &[p1, p2, p3, p4] = value;
[build]       |           ^~~~~~~~~~~~~~~~
[build] /home/msspertu/GitHub/high-level-enhancements-for-aws-in-cpp/build/_deps/alpaca-src/include/alpaca/detail/struct_nth_field.h:41:11: note: while ‘const std::tuple<int, double>’ decomposes into 2 elements

But this works with MyType, just like it does with a top-level tuple.
#include <alpaca/alpaca.h>
namespace alpaca::detail {
template<typename ...Ts>
struct aggregate_arity<std::tuple<Ts...>> : std::make_index_sequence<sizeof...(Ts)> {};
}

#include <tuple>
#include <vector>
#include <cstdint>

std::vector<uint8_t> bytes;

struct MyType {
  std::tuple<int, double> t{1, 2.3};
};
MyType m;

auto bytes_written = alpaca::serialize(m.t, bytes);

The serialize function is expecting the struct object, not each field.
This should work:
#include <tuple>
#include <vector>
#include <cstdint>

std::vector<uint8_t> bytes;

struct MyType {
  std::tuple<int, double> t{1, 2.3};
};
MyType m;
#include <alpaca/alpaca.h>

auto bytes_written = alpaca::serialize(m, bytes);

Of course. Yes, that seems to work. It also seems to resolve my other issue as well. Thanks very much!
Granting all of that, it looks like the code changes I described make top-level tuples work. Do you think that would be worth enabling? (May overlap with this issue)

As long as there are no regressions (unit tests), I'd be open to it, yes :)

It looks like I spoke too soon about it working if you wrap a tuple in a struct. If you modify your example to have only one type in the struct, serializing produces 0 bytes;
#include <tuple>
#include <vector>
#include <cstdint>

std::vector<uint8_t> bytes;

struct MyType {
  std::tuple<int> t{1};
};
MyType m;
#include <alpaca/alpaca.h>

auto bytes_written = alpaca::serialize(m, bytes); // bytes_written is 0

The reason for this is that the conversion from filler to tuple<int> is ambiguous due to the constructor templates in tuple, so it incorrectly deduces 0 for aggregate_arity<MyType> as shown in this godbolt.
I'll try to create a PR that fixes all tuple-related issues.


upgrade project not using packages.config

Make upgrade project use packages.config.  CppWinRT had to manually be hand updated

We just released 0.20 and this should be resolved there.  Please try it out.


The New Detekt Website

Fixes #4235
Sorry this took so long. I've finalized all the work for the New Website. You can preview it on https://ncorti.com/detekt
Once we merge this I'm going to add a couple of nice things:

A search bar with Algolia that will make easier to crawl through the docs
Deployment with Vercel so we'll have website previews on every PR

Aside from that, I've moved all the documentation from docs/ to website/. Moreover, there are a couple of other changes that are worth pointing out:

The CI has been updated to build the website at every PR. Once a PR is merged, the website is also published.
I've moved KDoc to use the JetBrains HTML theme. Mostly because the Jekyll one was not workign well with docusaurus as it was creating invalid html. I'm not sure how many users are reading the KDoc, but the new UI feels nicer.
I've configured redirects for the URLs of the old website.

(The diff size is quite big as there is a bunch of generated code, but the meaningful changes are not that many)

Do we want to include a way to search the website? The Jekyll powered website included one. However, we received complains regarding the limit search functionality (#1077).

Do we want to include a way to search the website?

Yup. I've applied for https://docsearch.algolia.com/ which is free for OSS projects.
The website needs to be merged first though as they need to scrape the content.


[Bug]:  Unexpected end of JSON input

Version
29.6.2
Steps to reproduce
Clone my repo https://github.com/sagarkhadka12345/hms.git
yarn install
yarn test
Error comes up
Expected behavior
I want test to run
Actual behavior
node:events:491
throw er; // Unhandled 'error' event
^
SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at ChildProcess. (D:\Demo\HMS\node_modules\fb-watchman\index.js:210:22)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at ChildProcess._handle.onexit (node:internal/child_process:302:5)
Emitted 'error' event on Client instance at:
at ChildProcess. (D:\Demo\HMS\node_modules\fb-watchman\index.js:219:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at ChildProcess._handle.onexit (node:internal/child_process:302:5)
Additional context
No response
Environment
System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i5-10505 CPU @ 3.20GHz
  Binaries:
    Node: 18.15.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.5.0 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^29.6.2 => 29.6.2

Does not reproduce for me.
yarn install warns: "package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json."
yarn test fails with different error:

Does jest not support tsx?

Why do you think so?

Support for experimental syntax jsx is not supported is shown in your error

Nope. The message states that JSX syntax "isn't currently enabled". A line below this one tells how to do that.
Your reproduction cannot work, because it has numerous configuration issues:

babel.configure.js will not be picked up by Babel, because of wrong name;
dependencies are missing;
"type": "module" is included in package.json, but you did not follow the ECMAScript Modules to setup Jest according;
the error you see comes from fb-watchman, but it isn’t even included in the reproduction and probably that is why we see different error messages;
and so on.

I can recommend to begin with Getting Started which explains setup with Babel (if you need it). Or pick a template which already includes Jest.


Does Cloudflare changed his API ? Proxied record issue

Hello all,
since ~1 month i'm not able to update CloudFlare records using OctoDNS. The config file i've used before was the same and suddenly it stopped to work. After tests (fortunately i run it using GitLab pipelines), like forcing OctoDNS to run an older version, issue is still here. So i guess CloudFlare did an update to his API regarding proxied records.
For information, i usually run the latest OctoDNS from the Git repository here on master branch, and the issue is still there.
All my records works if i put them manually in CloudFlare web gui, and i can proxy them. OctoDNS in dry mode does not detect any error with my record config file.
Here the error i get:
octodns.provider.cloudflare.CloudflareError: This kind of record cannot be proxied
My record config file is quite big, but i can share it if you think it's relevant or are not able to reproduce my issue.
Thanks a lot for your help.
-- o_be_one

There's been some changes to the CF provider since the most recent release, e.g. https://github.com/github/octodns/pull/565. We're about due a new release, but it's still a bit down my todo list. In the meantime you might try running with a recent sha, e.g. 5c26f388519433a07e50d80abd02fef1a91e312f.
That can be installed with pip (requirements.txt etc.) with something like:
-e git+https://git@github.com/github/octodns.git@5c26f388519433a07e50d80abd02fef1a91e312f#egg=octodns

Will leave this open for now. Please close if the more recent version fixes your issue.

Thank you ross for your quick and explained answer. So i've tried with the suggested sha and i still have the same error.
For reference, confirming sha from my pipeline:
Cloning<EMAIL_ADDRESS>(to revision 5c26f388519433a07e50d80abd02fef1a91e312f) to /tmp/pip-install-LIxcrh/octodns
Error:
octodns.provider.cloudflare.CloudflareError: This kind of record cannot be proxied
If you have any other hint let me know. In the meantime i will let my pipeline run the latest release on master and will try it again sometime.
Have a good week :)

☹ guess that is a new CF issue. I don't currently have CF setup so it'll be tough for me to debug. That said I or whoever picks this up will need some more info on how to recreate the problem. Do you have an example record (yaml config) that runs into this error?


Create Dockerfile for contributing

Close #9105
To Do

[X] Create functional Dockerfile for contributing
[X] Add documentation for dockerfile *Should be reviewed
[X] Update CHANGELOG.md in the root of the project if you have not done so.
[X] Run prettier over CONTRIBUTING.md
[X] Fix change log to say Chore && Maintainance
[X] Verified yarn runs correctly
[ ] yarn test does NOT run correctly. Troubleshooting...

Summary
This PR adds a Dockerfile that contributors can use. This allows people to get Jest up and running without manual installation. See #9105 for more details.
I am by no means a Docker or Jest expert. I'm sure there are improvements to this file that can be made. Feel free to let me know any changes that are requested! 👍
Test plan
Simply run the following commands to test this (Tested on Ubuntu 18.04):
Build Jest
docker build -t jest .

Run Jest

You may need to replace $PWD with the path to your Jest clone.

docker run --volume="$PWD:/usr/src/app" --rm jest:latest

Expected Results

Jest builds successfully
Jest runs successfully (in watch mode)
When you modify && save a .ts file in /packages, it should automatically re-compile.

@SimenB thanks for the feedback. I'll work on these changes. I'll keep a log of my work on my top comment.

@SimenB I ran the container and get this error:
Investigating now.

I'm not sure if mounting the volume stuff will work properly at all since we need e.g. nested node_modules that differ between architectures... Will need to think that through a bit
Not sure about the snapshot failure, possibly related to the mounted volume thing?
The mercurial errors are expected (for now), see #8653.

@SimenB got it. So mercurial errors are expected, but not the snapshot errors. I have an idea of what might be going wrong with the snapshots. Troubleshooting now...

@Alex-Cannon hey! are you still interested in working on this? 🙂

This PR should be closed and the work should be continuedo on pr #13009

@SimenB @Alex-Cannon


Add overflowX hidden to carousel.tsx

Prevent scroll with overflowX: 'hidden' on carousel.tsx's outer div
Overview
List the GitHub issues containing the issues relevant to this pull request.
Resolves #33
Prevents the animation between pages in the carousel component from momentarily causing a scrollbar to appear at the bottom of the screen.
What Changed
Added overflowX: 'hidden' to the child div in carousel.tsx

Ah I didn't know about Conventional Commits style. I'll use that in the future, thanks.


I can't install flatpak's

using App.Outlet-1.2.1.AppImage
Fedora silverblue 31 gnome wayland
$ ./App.Outlet-1.2.1.AppImage
Fontconfig warning: "/usr/share/fontconfig/conf.avail/05-reset-dirs-sample.conf", line 6: unknown element "reset-dirs"
[18980:1107/173302.694442:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command

May be a Wayland hardware acceleration related issue... can you try with software rendering?
export LIBGL_ALWAYS_SOFTWARE=1

Your issue title does not refer to content

I can't install flatpak as well.

@wcolato was you using snap version?


if no instance path use content path

if no path is defined, just use the same paths.. allows for multiple collections in different paths to sync, mapping can be changed in docker if you want it in a different path.

sorry my ide removed all your whitespaces

create PR to merge into develop

change this to merge into dev

I went ahead and added the functionality to the next version instead of merging this since it had merge conflicts. its in version 1.9.0


Adding Swagger GIF to README.md

Added a GIF showing how Swagger can be used for Issue #14

@omarmjhd ,
Thank you for the pull request!


Add PK-INIT support inside the Kerberos

Add PK-INIT support inside the Kerberos: implement AsReq and AsRep generation based on the existing functions from the PKU2U module. Move those functions into separate module pk-init because they are used in two protocols.

Implemented.


Failing tests

What problem has occurred? What issues has it caused?
Several of the recent tests are failures, possibly due to the recent refactoring #6948
For example, https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true failed with the error traceback below.
What would you like to happen/not happen?
Tests should succeed when nothing is wrong (-:
May be relevant: When I run the tests locally, I get this warning:
test/test_blacklists.py:215
  /home/tripleee/charcoal/SmokeDetector/test/test_blacklists.py:215: PytestUnknownMarkWarning: Unknown pytest.mark.xdist_group - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
    @pytest.mark.xdist_group(name="long_runner_1")

Here is the traceback from the example:
def test_metasmoke():
        orig_tell_rooms_with = chatcommunicate.tell_rooms_with
        chatcommunicate.tell_rooms_with = dummy_tell_rooms_with
        msg = Fake({
            "owner": {
                "name": "ArtOfCode",
                "id": 121520,
                "is_moderator": False
            },
            "room": {
                "id": 11540,
                "_client": {
                    "host": "stackexchange.com"
                }
            },
            "_client": {
                "host": "stackexchange.com"
            }
        })
        msg_source = "metasmoke is {}. Current failure count: {} " + "({id})".format(id=GlobalVars.location)

        chatcommands.metasmoke(original_msg=msg, alias_used="ms-up")
        assert GlobalVars.MSStatus.is_up()
        chatcommands.metasmoke(original_msg=msg, alias_used="ms-down")
>       assert GlobalVars.MSStatus.is_down()
E       AssertionError: assert False
E        +  where False = <function GlobalVars.MSStatus.is_down at 0x7f41f81237f0>()
E        +    where <function GlobalVars.MSStatus.is_down at 0x7f41f81237f0> = <class 'globalvars.GlobalVars.MSStatus'>.is_down
E        +      where <class 'globalvars.GlobalVars.MSStatus'> = GlobalVars.MSStatus

test/test_chatcommands.py:656: AssertionError
----------------------------- Captured stderr call -----------------------------
[09:55:04.7[34](https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true#step:10:34)] KeyError: ('stackexchange.com', 11540)
2022-05-06 09:55:04.73[36](https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true#step:10:36)09 UTC
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 482, in __call__
    result = self.__func__(*processed_args, alias_used=alias_used)
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommands.py", line 926, in metasmoke
    if not is_privileged(msg.owner, msg.room):
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 432, in is_privileged
    return user.id in _privileges[(room._client.host, room.id)] or user.is_moderator

  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 482, in __call__
    result = self.__func__(*processed_args, alias_used=alias_used)
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommands.py", line 926, in metasmoke
    if not is_privileged(msg.owner, msg.room):
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 432, in is_privileged
    return user.id in _privileges[(room._client.host, room.id)] or user.is_moderator

[09:55:04.738] KeyError: ('stackexchange.com', 11540)
2022-05-06 09:55:04.7[37](https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true#step:10:37)917 UTC
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 482, in __call__
    result = self.__func__(*processed_args, alias_used=alias_used)
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommands.py", line 926, in metasmoke
    if not is_privileged(msg.owner, msg.room):
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line [43](https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true#step:10:43)2, in is_privileged
    return user.id in _privileges[(room._client.host, room.id)] or user.is_moderator

  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line [48](https://github.com/Charcoal-SE/SmokeDetector/runs/6320800336?check_suite_focus=true#step:10:48)2, in __call__
    result = self.__func__(*processed_args, alias_used=alias_used)
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommands.py", line 926, in metasmoke
    if not is_privileged(msg.owner, msg.room):
  File "/home/runner/work/SmokeDetector/SmokeDetector/chatcommunicate.py", line 432, in is_privileged
    return user.id in _privileges[(room._client.host, room.id)] or user.is_moderator

The closure of this issue was automated by GitHub as a result of my saying "partially resolve #[issue number]" in the commit. Apparently, it's just looking for "resolve #[issue number]" in order to invoke auto-close. That commit should resolve the majority of the failures we've seen, but we'll have to wait to see, as the issue was that tests that didn't fully set up the test environment were being run without having previously run a test earlier in the file which did set it up (i.e. the tests were not independent).
That's very likely what's happening with the other test which appears to be failing:
test/test_chatcommunicate.py::test_init

I'll take a look at that one too, but probably later.

Another potentially related CI failure:
https://app.circleci.com/pipelines/github/Charcoal-SE/SmokeDetector/71161/workflows/ccff8a1d-3aa6-46b2-9ed0-0438f1e95a75/jobs/109367
Failed: Privileged user 22202197 does not have a corresponding entry in users.yml

test/test_chatcommunicate.py:45: Failed
=========================== short test summary info ============================
FAILED test/test_chatcommunicate.py::test_validate_yaml - Failed: Privileged ...

There have been multiple additional failures in test/test_chatcommunicate.py (e.g. 1, 2, 3).
While this is an annoyance wrt. having the CI tests fail, it does reveal a real issue, which is that chatcommunicate.py is substantially lacking wrt. thread safety. I've looked through the code in chatcommunicate.py and made edits to fix that. Before submitting a PR, I still need to check if there are other portions of the code which access or modify chatcommunicate.py's globals and make sure they use the new locks. Then, some testing to verify that there aren't any obvious deadlocks created.

For the issue you mention in the initial comment here when running the tests locally, that appears to be that the pytest-xdist package is not being applied during the tests. The error is saying that it doesn't understand a pytest.mark which is defined in that package. I added the pytest-xdist package to requirements.txt when the CI testing was changed to running tests in parallel. Have you installed the pytest-xdist package? If not, installing it will probably be the solution. If it is installed, then we'll need to see if we can figure out why it isn't automatically incorporated in the testing.
I'm sorry, I should have explicitly mentioned to you that the requirement.txt file had been updated. I also recently added psutil to requirements.txt, if you haven't installed that. That package is used in bodyfetcher.py to prevent starting additional threads when the CPU is already heavily loaded.
As for testing locally, my personal choice was to change the script which I use to start the tests to have pytest run the tests in parallel in order to substantially reduce the overall elapsed time, but use OS scripting methods to reduce the priority of the tests, so that running them doesn't interfere with my local system being interactive. If you do choose to run them in parallel, I'd suggest setting the number of threads to use to one more than the number of CPU cores which you are willing to have working on the task. The tests are configured such that one thread starts up first running the long DNS based verification test, which is very network bound and takes very little CPU. All remaining threads will tend to be first occupied by CPU intensive tasks. For example, when wanting to primarily allocate 4 CPU cores to the testing, I use python3 -W default::Warning -m pytest -n 5 --dist loadgroup to start up 1 thread which isn't CPU intensive and 4 which are CPU intensive. You should, of course, adjust the -n <x> setting to whatever fits for your setup. If you don't desire to have them run in parallel, then the existing way which you are invoking the tests should work, as long as pytest-xdist is installed.

Thanks for the tips. For the record, I probably installed psutil manually at the time, but probably hadn't noticed pytest-xdist. (Not near my computer now.)

For the failure which is
FAILED test/test_chatcommunicate.py::test_validate_yaml - Failed: Privileged user 22202197 does not have a corresponding entry in users.yml

I added some extra printing, both of the data structures being tested and the raw file contents, as read within the test. The most recent error on Circle CI of this type shows the raw text contents of the file, as read by SD, doesn't have the line for that user (last lines of output in the "Pytest" section). However, the line for that user does, in fact, exist in the file when is checked out of git outside of the CI environment. It's unclear to me why that line is not being read. It's almost as if it's reading an older version of the file. The next thing to determine is if the file, as stored in the checked out repository, really doesn't contain that line or if the problem is it's not being read properly. In other words, is it a problem with the git checkout not putting the right version of the file on disk, or is it a problem with Python reading the file.
There's another issue with tests which involve reading from disk which also is intermittently causing errors. I haven't tracked it as far as this one, but the test_check_if_spam_json() test in test_spamhandling.py sometimes fails, due to being called with no test JSON data. That data is supposed to be read at the start of testing from the test/data_test_spamhandling.txt file, but the data when the test is called is empty. It's not clear these issues are related. I'm just noting it here as they both involve reading data from disk within the tests.

I've added cating the two files, users.yml and test/data_test_spamhandling.txt to the CircleCI tests just prior to executing pytest. That should at least tell us what's on the disk at that time.
Hmmmm... what could be happening for these is that the file contents are changing due to us performing git operations in other tests. I wouldn't have expected that to affect test/data_test_spamhandling.txt, as that data should be read prior any tests being run. But, it could affect users.yml, as that's read within the test.

It looks like this CircleCI test run confirms that the contents of the users.yml file which are read in the test/test_chatcommunicate.py::test_validate_yaml() test are different than what was on the disk prior to running pytest. So, either that test is somehow reading the contents of the file incorrectly, or we have something that's changing the content that's on the disk (which seems more likely). Given that we do have tests which do git operations, we should take a look at those to see if any of them change the contents of the files. It may mean we need to run those tests separately, or in some way prevent interference between tests.

As to the more prevalent sporadic errors (at least 3 today: 1, 2, 3:
FAILED test/test_chatcommunicate.py::test_validate_yaml - Failed: Privileged user 22202197 does not have a corresponding entry in users.yml

which I mention above, I've been working on adding threading locks on quite a bit of stuff which we use across threads, both in CI testing, but more importantly in normal operation of SD. Some of those changes should address the above issue, or at least reduce it. Given that those changes are adding a bunch of locks, I'd prefer to wait for the weekend to put them in. I'll try to get what I have so far into a PR in the next day or two. While I've made a lot of changes, there's still substantial sections of code which need to be reviewed for thread safety.
In addition to the changes I have so far for our code, I also have changes for the regex package. I still need to look in detail at both the ChatExchange and phonenumbers packages wrt. thread safety (a cursory check makes it appear both have issues which will need to be resolved).


[question] No end-of-game info after a custom match

I just had a quick question.
So I checked the end-of-game module with just a random ranked match of a friend<PHONE_NUMBER>), and it works perfectly fine.
However when I try it in a custom created tournament draft it doesn't seem to work<PHONE_NUMBER>), while that is the intended usage (I assume).
I get that it's probably client related, but is there a way for it to work with customs?

Standard custom games are not available in the matchv5 API (although they have been available in the recent past since Riot apparently broke things).
Games created with a tournament code (e.g. through Battlefy or other platforms like it) are contained in the API, this is how we do it during our streams.


APPS/pkeyutl: improve -rawin usability and doc for EdDSA

This improves the usability of they pkeyutl app when signing or verifying with Ed25519 and Ed448 keys.
When the -rawin option was not given with them, so far an obscure low-level error was thrown such as
pkeyutl: Error initializing context
80205AEC01000000:error:03000096:digital envelope routines:evp_pkey_signature_init:operation not supported for this keytype:crypto/evp/signature.c:526:

This PR makes sure that the -rawin option is implied for such scenarios,
[update: also in case the -digest option is given, ]
also making the app more convenient to use.
Implementing this required a split of the init_ctx() helper function, which is now less convoluted.
Tests and doc are updated accordingly,
and on this occasion the help output and the doc of the -rawin option are made less confusing.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/otc but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@DDvO could you please answer @hlandau's comment?
Willit work with ed448/25519 when -rawin is specified (scripts backward compatibility)?

@DDvO could you please answer @hlandau's comment?

Thanks for pointing me to that, and
sorry that I missed that good review comment of March 10th.
Handled it now.

Will it work with ed448/25519 when -rawin is specified (scripts backward compatibility)?

Yes.
Rebased to fix trivial merge conflict in CHANGES.md.

@t-j-h would you mind confirming your aproval?

@hlandau or can you give the 2nd approval?

Rebased to fix trivial merge conflict

Rebased again to fix trivial merge conflict in CHANGES.md

PIng @openssl/committers for 2nd approval / reconfirmation.
Should not be a big deal.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

I also have to ask also @t-j-h to reconfirm approval.

Asking again @t-j-h to reconfirm, or any @openssl/committers for 2nd review.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

Regarding -pkeyopt digest:{name}, it's not just useful with RSA.  If you openssl list -signature-algorithms -verbose, you'll find this (assuming a default installation):
$ openssl list -signature-algorithms -verbose
  { 1.2.840.1135<IP_ADDRESS>, <IP_ADDRESS>.1, RSA, rsaEncryption } @ default
    settable operation parameters:
      digest: UTF8 encoded string (arbitrary size)
...
  ECDSA @ default
    settable operation parameters:
      digest: UTF8 encoded string (arbitrary size)
...

Regarding -pkeyopt digest:{name}, it's not just useful with RSA. If you openssl list -signature-algorithms -verbose, you'll find this (assuming a default installation):
$ openssl list -signature-algorithms -verbose
  { 1.2.840.1135<IP_ADDRESS>, <IP_ADDRESS>.1, RSA, rsaEncryption } @ default
    settable operation parameters:
      digest: UTF8 encoded string (arbitrary size)
...
  ECDSA @ default
    settable operation parameters:
      digest: UTF8 encoded string (arbitrary size)
...

What is the effect of -pkeyopt digest:<md> with ECDSA? It does not seem to make any difference to signature verification (and so perhaps also signature content).

Moved doc fixes that clearly should be backported to PR #25831.

How about backporting the change that -digest implies -rawin?
This should be pretty convenient, so would be nice to have also in older versions.

Please consider the merging the suggestions, and I'll reapprove.

Glad to hear!
Thank you for your excellent review and for doing a first approval.

This pull request is ready to merge

Merged to master - thank you for the approvals.

I'm glad that we've been able to complete this PR,
at least w.r.t its original aim, and actually went beyond that.
From my perspective, at least two points in this regard are still open:

whether it's worth/suitable to backport part of these commits
whether and how to warn more precisely if the input is not considered raw but its length is not beyond EVP_MAX_MD_SIZE = 512 bits but larger than the input size of the pure asymmetric signing operation (e.g., 256 bits ECDSA).

From my perspective, at least the following three points in this regard are still open:

Raise a new issue for them?

From my perspective, at least the following three points in this regard are still open:

Raise a new issue for them?

Done in #25892


Added SwifterSwift to Utility

Added SwifterSwift to Utility
Project URL
https://github.com/omaralbeik/SwifterSwift
Description
A handy collection of more than 290 native Swift 3 extensions to boost your productivity.
Why it should be included to awesome-ios (optional)
Swifter Swift is a library of over 290 properties and methods, designed to extend Swift's functionality and productivity, staying faithful to the original design guidelines of swift 3.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 2 link issues

Link issues by awesome_bot

Line
Status
Link

987
301
https://github.com/alvinvarghese/EasyIAPs redirects tohttps://github.com/aaalveee/EasyIAPs

1027
503
https://boxcar.io

  Generated by :no_entry_sign: danger

Hey
You're missing the Swift marker :)

🔶

@dkhamsing sorry, I added it

Thx!


Handle more kinds of structure corruption

Misparented roots. We've seen this in the wild, where the menu or toolbar ends up in unfiled. We can either have our tree mark the root as diverged, and always reparent to the Places root, or handle them in the merger.
Deleted roots. Unlike other deleted folders, we want to resurrect instead of taking the deletion and relocating orphans. If the root is deleted on both sides, that's odd, but technically okay. I think this is more of a theoretical concern; we haven't (IIRC) seen it come up.
Multiple parents with the same timestamp. We rely on the age and parent type to break the tie, but, if we have multiple parents with the same timestamp, could we still end up with children in multiple parents?
Cycles. The merger's cycle detection should stop us from walking subtrees multiple times, but we want to make sure we don't exclude them. We also want to make sure that trying to log a tree with cycles doesn't infinitely recurse.

I think cycles are only a theoretical concern. Last time I looked we had never even seen telemetry reporting them.

Last time I looked we had never even seen telemetry reporting them.

Sold. 👩⚖ I added a check (and got to learn about the tortoise and hare cycle detection algorithm!) that fails the merge if we somehow produce a tree with cycles, instead of trying to make sense of them.

and got to learn about the tortoise and hare cycle detection algorithm

Heh, the only experience I have with that algorithm is that I've heard of it as a famously cruel job interview question (how do you detect a cycle in a linked list with O(1) space). Of course, this is not the fault of the algorithm at all!
The way I've usually done this is by doing a DFS but keeping a set containing which items I've seen. If we ever hit an item we've seen, we have a cycle. Although, the way I did it in the bookmark validator was actually a bit more complicated than this, since we wanted be able to produce the set of cycles that we've seen (for e.g. about:sync), and not just that we saw a cycle. I think this makes it the same as finding the strongly connected components, but am not certain.
Anyway, that's neither here nor there, that code seems completely fine (even if thinking about traversing the bookmark tree from the children to the parents in that way threatens to melt my brain :p)


Small typos

What does this PR do?
Minor typos in docs; add link to BetterTransformer guideline docs
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


save model does not use tf.io.gfile.GFile

.save method does not use tf.io.gfile.GFile and it limits its use to local file systems

Synced up offline and verified the save behavior. The model.save() works, but the index save throws an error in memory_store.py.
> /google_src/head/depot/google3/third_party/py/tensorflow_similarity/stores/memory_store.py(155)_make_fname()
    154     if not p.exists():
--> 155       raise ValueError("Index path doesn't exist")
    156     fname = p / "index.npz"


[v0.12.1.x testnet] Masternode stays in state "PRE_ENABLED"

I'm running a hot/cold Masternode on testnet for a couple of days now and it gets regular MN-payments.
The problem is, it's listed in status "PRE_ENABLED" with an "Active" time of "00m:00s". That shouldn't be.
If you need logs just give me an email address to send them to.
Update: the wallet with the 1000 tDASH vin reports it as "PRE_ENABLED". The remote dashd (and probably the rest of the world) sees the status "ENABLED", so it should be correct to receive payments.

Re update: yep, I don't see any pre-enabled either.
Can I have local debug.log<EMAIL_ADDRESS>[zip it first pls :)]

Email sent!

Ok, so if I get debug.log output correctly you are using dash.conf hot/cold setup and it's quite possible that something doesn't play quite right in that kind of setup. Try masternode.conf instead. If that helps I would rather not fix this one because... you know why :D

Yep, masternode.conf works as expected... I think when I'll find some more time this week I'll have a look  into what's needed to completely deprecate masternoding via dash.conf


Decrease window size to use less screen space

Removes large black empty rectangle that draws over CLI + X server (if installed).

I signed it!


[IOTDB-291] Statement close operation may cause the whole connection's resource to be released

Good job.


Plugin name in Kong Manager is wrong when using declarative yaml

Summary
When configuring a plugin with declarative yaml, the name that is showing in the Kong Manager is wrong - it shows the plugin type instead of plugin name.
Steps To Reproduce

Let's say we have a plugin called "my-plugin". Let's configure a yaml file for it:

# vim my-plugin.yaml
apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: plugin-name
config:
  key_ex: value_ex
plugin: my-plugin

kubectl apply -f my-plugin.yaml

Log in to Kong Manager and under "Plugins" check that the plugin is loaded

Expected: behavior

Additional Details & Logs

Kong version <IP_ADDRESS>

On further thinking, this might be more of a feature request than a bug. But I'm looking forward to hear other thoughts on the matter.

Hello, @eladbs! Welcome to the Kong community.

When configuring a plugin with declarative yaml, the name that is showing in the Kong Manager is wrong - it shows the plugin type instead of plugin name.

This is expected behavior. Kong Manager shows the plugin name (for example, rate-limiting, acl, or my-plugin in your example), rather than the Kubernetes object name. Check out this how-to: https://docs.konghq.com/enterprise/2.3.x/kong-manager/enable-plugin/.
Closing this, but feel free to open a new one with any other issues you might have. If you are new to the Kong Community, also check out https://discuss.konghq.com!
Happy Konging! 🦍

@gszr
Thanks for the prompt response!
I understood it is like this by design, hence my comment above.
All other objects (services, routes, consumers, etc.) can be distinguished one from the other by looking at their main page and there's no need to go into the details.
Plugins are not.
Can this be considered/converted into a feature request?
Is this even feasible?
Thanks!
Elad.

@eladbs I will pass this along to our product team. Thanks for the feedback!

@eladbs Just so I better understand your request, wouldn't the "applied to" field help with that? See the screenshot here https://docs.konghq.com/enterprise/2.3.x/kong-manager/enable-plugin/.

@eladbs Just so I better understand your request, wouldn't the "applied to" field help with that? See the screenshot here https://docs.konghq.com/enterprise/2.3.x/kong-manager/enable-plugin/.

The "applied to" field shows only the object type the plugin is configured on (i.e. route, service, etc.) but not on which "instance".
The issue is that when you have a lot of plugins configured, many of the same type, it is impossible to know which one is which simply looking at the plugins main page.
To edit the right plugin you would have go inside each plugin until you find the right one or go to the route/service/etc., then to the right object and view it's properties and then go to the plugin.
Both way require a lot more clicks than it should
And again, this is in contrast to other object types (routes, services, consumers, upstreams) where each and every item on their respective main page is distinguishable from another.
Thanks!!!
Elad.


[R4] Align and refine UI appearances

Goal

Align and refine UI appearances
Align wordings and fix typos

Result
Index Page

Shopcarts RESTful API

Items RESTful API

Looks beautiful!!!

I think in rest_api.js file, it is needed to create the reset-items-form-btn


Add legal document access to project

From PyWorkout created by willtheorangeguy: willtheorangeguy/PyWorkout#15
Add buttons or commands that display each of the legal documents when they are executed.
The following need to be completed:

[ ] Universal License
[ ]  Universal EULA
[ ]  Universal Terms and Conditions
[ ]  Univeral Priacy Policy

Not necessary because it is a template web page.


Keep get tables API with and without database

From cluster management purpose, we need APIs to read table names from all databases. Keep the original APIs the same (without filtering on database), and for database aware purpose, use the new APIs.

Codecov Report
Attention: Patch coverage is 0% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (8b58b77).
Report is 218 commits behind head on master.

Files
Patch %
Lines

...apache/pinot/controller/BaseControllerStarter.java
0.00%
41 Missing :warning:

...ntroller/helix/core/PinotHelixResourceManager.java
0.00%
18 Missing :warning:

...controller/helix/core/minion/PinotTaskManager.java
0.00%
5 Missing :warning:

...ller/api/resources/PinotBrokerRestletResource.java
0.00%
4 Missing :warning:

.../helix/core/cleanup/StaleInstancesCleanupTask.java
0.00%
3 Missing :warning:

.../resources/PinotLeadControllerRestletResource.java
0.00%
1 Missing :warning:

...elix/core/periodictask/ControllerPeriodicTask.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12804       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2390       -46
  Lines        133233   131171     -2062
  Branches      20636    20273      -363
=============================================
- Hits          82274        0    -82274
- Misses        44911   131171    +86260
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Revamp journal data structure

The journal we are using right now has several issues:

It's a JSON, which means that each time it's updated the whole file needs to be read and written
For a given transaction within an executor, it only keeps track of the last try, but it should keep previous attempts too (for example, to handle the race condition where the gas price of a transaction is bumped but just at that moment the "replaced" transaction is mined).
It's unclear what happens if there's a problem during writing.

I'm not sure what the right data structure for this would be, so some research is needed. One idea is to have an append-only structure with some guarantee of having "atomic" appends (I have no idea how to implement this though)

We switched to line-orientated json so we are append only.


[typescript-to-proptypes] Allow to represent dates as PropTypes.object

Needed for https://github.com/mui/mui-x/pull/11791
To give some context, on the pickers we are supporting several date libraries (dayjs, moment, date-fns and Luxon)
Date-fns is using JavaScript dates for its values and the other are using custom objects
In https://github.com/mui/mui-x/pull/11791, I'm improving the typing so that when you import an adapter (the utility that unifies all the date library APIs), you also say to the components that the props can receive a value in the date format of your date libraries.
But we have one issue, the proptypes generated are not PropTypes.oneOfType([PropTypes.object, PropTypes.instanceOf(Date)]) due to date-fns. And this is super misleading for people using another date library.
To solve this, I added a new option to the prop-types generation to allow to represent dates as object.
If you have a better idea I'm interested

I'm not sure to understand. Currently your PR that uses this branch shows PropTypes.oneOfType([PropTypes.object, PropTypes.instanceOf(Date)]).

I'm trying to use this branch on the X repo but I end up with incompatibilities on other parts of the monorepo...
I had the right prop-types before, I should have them again soon.

A more flexible approach could be to export the createAnyType, createInstanceOfType, ... and instead of shouldUseObjectForDate we could have a getProptypesOverride that is called before others. If it return undefined we continue. If it returns an object we use it.

Maybe it's slightly overkill for a first occurrence of custom behavior indeed.
But to keep in mind if we encounter others

The PR should be updated on X :+1:


Avoid running two travis builds when a PR is opened

Coverage remained the same at 98.063% when pulling<PHONE_NUMBER>ef1d8ef7cd67d54277af215119e8e6 on travis-build into 6906736a42ea86afd8bc9565faf6b72dee505b3c on master.


Change from TestPyPI to PyPI

Changes the publishing workflow from the test package index to the live one

Codecov Report
Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (7abd642) 99.49% compared to head (5b72890) 99.48%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   99.49%   99.48%   -0.01%
==========================================
  Files          51       51
  Lines       76248    76248
  Branches      709      709
==========================================
- Hits        75860    75858       -2
- Misses        265      266       +1
- Partials      123      124       +1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


ansible hot fix

Had to make these changes to deploy the new plex bin. Is this because something happened on our box or should these changes be in the ansible script?
Errors I was getting before these changes

fixed by https://github.com/labdao/plex/pull/383


BUG - Error message. See comment.

IndexOutOfRangeException: Array index is out of range.
GameEndUI.OnEnable () (at Assets/Scripts/GameEndUI.cs:61)
UnityEngine.GameObject:SetActive(Boolean)
GUIManager:GameEnd(Boolean) (at Assets/Scripts/GUIManager.cs:156)
ArchetypePlayer:OnDeathEvent(GameEndEvent) (at Assets/Scripts/Archetypes/ArchetypePlayer.cs:501)
c__AnonStorey0`1:<>m__0(GameEvent) (at Assets/Scripts/EventHandling/Events.cs:35)
Events:Raise(GameEvent) (at Assets/Scripts/EventHandling/Events.cs:73)

@wadek2 just pushed a potential fix for this - please let me know if this works for you


Send selection

I would love to see a feature where I can send selected text as a direct message or to a channel. This is my most used feature of the sublime package.
Do you think it is doable here?

Yeah, that sounds doable. I'll add it to the todo list!

Excellent. I don't know much (any) coffee script, but if there is something I can do to hurry this along let me know!

So this has been implemented?!
:clap:

It's in the list :) It'll be implemented along with regular file uploads, displaying/downloading files, etc. The next 4 items in the todo will likely be done together. Probably this week/end.

Excellent. Great work on the package

Selection uploads to one or more channels is supported as of 3.1.8. See the wiki for binding the command to a key.


Parser hangs on input

{1--} will hang the parser.
see djot/inlines.lua around l.428; in this case hyphens == 0

Found with make fuzz.

The inline parser should be able to monitor itself for lack of progress and abort instead of looping.

Also relevant: this one gives an overlapping match:
{1-}
+para 1-1
str 1-4
str 4-4
-para 5-5

I have improved things somewhat (no more hangs), but now we have the same doubled character noted above for {1-} with {1--}.  The problem is quite mysterious.
Add prints as follows in djot/inline.lua:
--- a/djot/inline.lua
+++ b/djot/inline.lua
@@ -497,9 +497,7 @@ function Tokenizer:feed(spos, endpos)
     self.lastpos = endpos
   end
   pos = spos
+  print("before while loop")
   while pos <= endpos do
+    print("top of loop: pos = ", pos, "endpos = ", endpos)
     if self.attribute_tokenizer then
       local sp = pos
       local ep2 = bounded_find(subject, special, pos, endpos) or endpos
@@ -592,7 +590,6 @@ function Tokenizer:feed(spos, endpos)
         local matcher = matchers[c]
         pos = (matcher and matcher(self, pos, endpos)) or self:single_char(pos)
       end
+      print("pos adjusted to ", pos)
     end
   end
 end

Now try echo "{1-}" | ./run.sh: (I've annotated with ##)
% ./run.sh
{1-}
before while loop
## here it's trying to parse this an an attribute:
top of loop: pos = 	1	endpos = 	5
pos adjusted to 	1
top of loop: pos = 	1	endpos = 	5
top of loop: pos = 	2	endpos = 	5
top of loop: pos = 	4	endpos = 	5
before while loop

## here it has given up on attribute parsing and tries a regular parse.
## This is the part to look at:
top of loop: pos = 	1	endpos = 	3
pos adjusted to 	2
top of loop: pos = 	2	endpos = 	3
## and here's the weird part, the next two lines:
pos adjusted to 	5
top of loop: pos = 	4	endpos = 	5
## notice how pos has the value 5 at the bottom of the while loop, but
## right at the top it has the value 4!  How did that happen????
pos adjusted to 	5
top of loop: pos = 	5	endpos = 	5
pos adjusted to 	6
<p>{1-}}</p>

@tarleb do you have any Lua insights here?

OK, I see what's happening now.

I had to revert this change because it was not well thought-out.
It led to losing content when attribute parsing fails after more than one 'feed'.


Bump v1.1.0-canary.1

Changes
Version bump

[delete] branch

the commits will be duplicated since they are under different commit hashes. do you want to rebase the branch on master instead?

Hmm i did exactly that though. I rebased onto master

Problems with branch. Will rebranch


project: rename ViewState in ViewStateMachine

Codecov Report

Merging #10 (16e7e70) into main (b82510a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   97.27%   97.27%
=======================================
  Files          51       51
  Lines        4799     4799
=======================================
  Hits         4668     4668
  Misses        131      131

Impacted Files
Coverage Δ

Sources/ViewStateMachine.swift
100.00% <ø> (ø)

Tests/ViewStateMachineTests.swift
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[ungoogled]chromium: 93.0.4577.63

https://termbin.com/69cf python2 has been dropped. 'angle_enable_null=true' has to be set as build was failing with '../../third_party/angle/src/libANGLE/Display.cpp:217:6: error: #error No default ANGLE platform', maybe due to our non-usage of x11 / libGLES (Still need to look into this). Build hasn't been checked beyond 'chromium --version' yet.

I haven't been able to pull a successful build out of this update so I can't confirm if it works or not -- I'll keep plucking away at it. If you think it looks good, we can just chance it; I have a feeling we are basically the only two people who use chromium anyways...

musl patches didnt need any changes and glibc build works fine so i guess it's ok to merge. There was some crashing which was fixed with chromium-InkDropHost-crash.patch from gentoo

Good enough for me.
Let us know if you have issues folx!


Playback API not working

Checklist:

[X] I have checked that there are no issues with similar or the same content
YOU SHOULD CHECK CLOSED ISSUES ASWELL

[X] I have checked the FAQ (https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/wiki/FAQ) and the answer I am looking for is not there

[X] I have double checked and can reproduce the issue

OS:
Windows
GPMDP Version:
4.6.1
Issue Descriptions:
The playback api json updates the first time you play a song/playlist, but never updates again when the song changes.
Steps to Reproduce:
Play any playlist.
Check playback.json file.
Skip to next song.
Json file not updated.

Does this only happen in YTM or GPMDP? I believe this may be fixed already but not released.

It happens when I use YTM, haven't checked if it does the same for GPMDP

After testing, the playback json works fine for GPMDP but doesn't for YTM

This is fixed in master, we are just waiting on a release for it to be live.

Not to raise this thread from the dead, but I'm seeing something similar - using GPMDP it is updating when I move from track-to-track, but the playing flag is always true.  In the past, it used to toggle between true and false.  I can tell if a song is playing using the time.current value (i.e., if it's changing then a song is playing) but the true/false toggle was a little easier to work with.
Is this related to the above discussed and fixed bug?


Add Linux GitHub actions CI (and lint) workflow

Closes #18.
Signed-off-by: Abrar Rahman Protyasha<EMAIL_ADDRESS>

Initially, I wanted to have separate workflows for compile-and-test and linting. However, that proved to be cumbersome for no other reason except that some ament_lint utilities report errors if no compatible file is found in a package tree.
Since I have enabled automatic linter tests as part of the test suite for each of the packages, it makes sense to just have linting as a byproduct of the compile-and-test step in the CI workflow. I may revisit this in the future once trac_ik_kinematics_plugin and trac_ik_py have been ported, and when support for MacOS and Windows are added.


https://<IP_ADDRESS>/auth-response connection refused

I ran the python script in README.md
and this showed up
Please open https://login.microsoftonline.com/consumers/oauth2/v2.0/authorize?client_id=... in your browser and copy the url you are redirected into the prompt below.
but whenever I click this link after I logged in microsoft account, I constantly get connection refused from <IP_ADDRESS>
I'm not sure if this is a particular problem of this project, but I have no place to ask
I've done with disabling firewall and flushing DNS but that doesn't seem to solve my issue

I have a similar error upon calling
voyager = Voyager(
    mc_port = 65243,
    openai_api_key=openai_api_key
)
voyager.learn()

It gives:
Mineflayer process has exited, restarting
Subprocess mineflayer started with PID 22472.
Mineflayer process has exited, restarting
\Voyager\voyager\env\process_monitor.py:65: UserWarning: Subprocess mineflayer failed to start.
  warnings.warn(f"Subprocess {self.name} failed to start.")

requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=3000): Max retries exceeded with url: /start (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x000001600>: Failed to establish a new connection: [WinError 10061] No connection could be made because the target machine actively refused it'))

Same issue, for Azure auth, I don't see any server receiving request at <IP_ADDRESS>.
For mc_port auth, I got an error: RuntimeError: Minecraft server reply with code 400 (I have no problem connecting to my local LAN port from another minecraft client).

Same issue.
Any ideas?

Hi, all. Thanks for your interest in this project. It's normal that you got a connection refused or 404 error after you click that link. You will still see the new URL in your browser. You just need to copy and paste that link. It should contain things like code=M.C.... in that link.

Oh, I saw the connection refused and instinctively thought something was wrong, but then the following issue occurred
Traceback (most recent call last):   File "C:\Users\yangh\Documents\Voyager\run.py", line 12, in <module>     voyager = Voyager(               ^^^^^^^^   File "C:\Users\yangh\Documents\Voyager\voyager\voyager.py", line 102, in __init__     self.env = VoyagerEnv(                ^^^^^^^^^^^   File "C:\Users\yangh\Documents\Voyager\voyager\env\bridge.py", line 42, in __init__     self.mc_instance = self.get_mc_instance()                        ^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\yangh\Documents\Voyager\voyager\env\bridge.py", line 67, in get_mc_instance     return MinecraftInstance(            ^^^^^^^^^^^^^^^^^^   File "C:\Users\yangh\Documents\Voyager\voyager\env\minecraft_launcher.py", line 36, in __init__     self.mc_command = self.get_mc_command()                       ^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\yangh\Documents\Voyager\voyager\env\minecraft_launcher.py", line 89, in get_mc_command     login_data = minecraft_launcher_lib.microsoft_account.complete_login(                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "C:\Users\yangh\AppData\Local\Programs\Python\Python311\Lib\site-packages\minecraft_launcher_lib\microsoft_account.py", line 261, in complete_login     token = token_request["access_token"]             ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^ KeyError: 'access_token'

how did you fix it?


Remove version from zip file

zip files will no longer have the version in the file name on releases.
Simplifies downloads.

 Versionless hops artifact names


naive question - where can I get / how I provide data for Valhalla?

sample extracts here seems to be gone...

The Valhalla readme has some instructions: https://github.com/valhalla/valhalla under the Running section.  It recommends trying Geofabrik to get a country or state/province extract:
wget http://download.geofabrik.de/europe/switzerland-latest.osm.pbf http://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf


modelOutput doesn't render for multinomial GLM model | Cannot read property 'cm' of null at createOutput

code to reproduce:
buildModel 'glm', {"model_id":"glm-c2cd61ad-3df8-4434-aeb4-e3b204c542e6","training_frame":"train_random_frame_0.750","validation_frame":"valid_random_frame_0.250","nfolds":0,"seed":-1,"response_column":"C55","ignored_columns":[],"ignore_const_cols":true,"family":"multinomial","solver":"AUTO","alpha":[],"lambda":[],"lambda_search":false,"standardize":true,"non_negative":false,"score_each_iteration":false,"compute_p_values":false,"remove_collinear_columns":false,"max_iterations":-1,"link":"family_default","max_confusion_matrix_size":20,"max_hit_ratio_k":0,"max_runtime_secs":0,"missing_values_handling":"MeanImputation","intercept":true,"objective_epsilon":-1,"beta_epsilon":0.0001,"gradient_epsilon":-1,"prior":-1,"max_active_predictors":-1}

if you have already trained this model, you can later reproduce the bug with only
getModel "glm-c2cd61ad-3df8-4434-aeb4-e3b204c542e6"

looks like the problem is that cross_validation_metrics is null

here's what it looks like in h2o-flow

the relevant bit of the h2o-flow CoffeeScript source looks like this

what does that odd ?. operator? it soaks up null values

http://coffeescript.org/

can test deep learning model with this code
buildModel 'deeplearning', {"model_id":"deeplearning-e0a1104e-b84f-4018-a1f1-27f2260272fa","training_frame":"train_random_frame_0.750","validation_frame":"valid_random_frame_0.250","nfolds":0,"response_column":"C11","ignored_columns":[],"ignore_const_cols":true,"activation":"Rectifier","hidden":[200,200],"epochs":10,"variable_importances":true,"score_each_iteration":false,"balance_classes":false,"max_confusion_matrix_size":20,"max_hit_ratio_k":0,"checkpoint":"","use_all_factor_levels":true,"standardize":true,"train_samples_per_iteration":-2,"adaptive_rate":true,"input_dropout_ratio":0,"l1":0,"l2":0,"loss":"Automatic","distribution":"AUTO","huber_alpha":0.9,"score_interval":5,"score_training_samples":10000,"score_validation_samples":0,"score_duty_cycle":0.1,"stopping_rounds":5,"stopping_metric":"AUTO","stopping_tolerance":0,"max_runtime_secs":0,"autoencoder":false,"categorical_encoding":"AUTO","pretrained_autoencoder":"","overwrite_with_best_model":true,"target_ratio_comm_to_comp":0.05,"seed":-1,"rho":0.99,"epsilon":1e-8,"nesterov_accelerated_gradient":true,"max_w2":3.4028235e+38,"initial_weight_distribution":"UniformAdaptive","classification_stop":0,"score_validation_sampling":"Uniform","diagnostics":true,"fast_mode":true,"force_load_balance":true,"single_node_mode":false,"shuffle_training_data":false,"missing_values_handling":"MeanImputation","quiet_mode":false,"sparse":false,"col_major":false,"average_activation":0,"sparsity_beta":0,"max_categorical_features":2147483647,"reproducible":false,"export_weights_and_biases":false,"mini_batch_size":1,"elastic_averaging":false}

assuming the response column is an enum
then
getModel "deeplearning-e0a1104e-b84f-4018-a1f1-27f2260272fa"


BUG: Prevent infinite recursion in Qt log handler

Slicer sometimes crashed on exit because in Qt log handler in ctk::qtHandleString while executing line QTextStream s(&str)
a QDeviceClosedNotifier::QDeviceClosedNotifier() object was insantiated that tried to log a message, which eventually got to
ctk::qtHandleString, creating an infinite recursion.
To solve this, a counter is added that is incremented at each recursion level and when it reaches a threshold then it does not try
to handle the message, thus preventing the crash.

+1  Nice!

Thanks for your contribution :+1:


Release related issue

Latest Release
On Github release page, https://github.com/tinytacoteam/zazu/releases, the Latest release is 0.3.2-builder, which should be 0.4.0
Filename format
And the filename format has been changed from previous release, from:
zazu-v0.3.2-darwin-x64.dmg
zazu-v0.3.2-linux-x64.deb
zazu-v0.3.2-win32-ia32.exe

to
zazu-0.4.0.dmg
zazu-Setup-0.4.0.exe
zazu_0.4.0_amd64.deb

It causes the homebrew cask recipe, https://github.com/caskroom/homebrew-cask/blob/811e3d88f245d5bfd99aedcfc93e5a6bc9a582e3/Casks/zazu.rb#L6, download url template failed, which is:
url "https://github.com/tinytacoteam/zazu/releases/download/v#{version}/zazu-v#{version}-darwin-x64.dmg"

Of course, we can submit a PR to change the template, but my point is that I think we may need a release procedure/script to formalize the tag, filename format. So, it will easier for the downstream project's integration.
latest.yml
I'm not quite sure about the purpose of latest.yml, but the content only contains Windows-related information:
version: 0.4.0
path: zazu-Setup-0.4.0.exe
sha2: 915c65adc26746c41da15325b6b8e03ed559824f4d74abf41934d71ae603d24c

appcast.xml
And I think we might need an appcast.xml or something else for the Auto Update. Currently, it's only promote to user there is an update, and user have to open zazu website and manually download it. It might be great if it can download automatically.
Currently the homebrew cask is using this link: https://github.com/tinytacoteam/zazu/releases.atom, but it doesn't contain the download link.

The new format is the default for electron builder. We could try and keep the naming convention, but I've already started updating places that reference the old convention. Like the website.
The "deployment" workflow is documented, but it was more of just a rough draft, but it is up to date:
https://github.com/tinytacoteam/zazu#deployment
Brew:
We should update the cask recipe.
latest.yml
I'm not sure why this was uploaded but it's not hurting anything I suppose?
appcast.xml
The electron-builder has things for auto updates but we need to start signing the code. I have an apple developer license now, so I just need to setup some environment variables for mac. I have no clue how to sign windows/linux though, maybe we can pair on this?
Once it's signed we should be able to do auto updates with github releases.

I submitted to cask here: caskroom/homebrew-cask#30005
I have no clue why the v0.4.0 isn't being shown as the "latest release" do you have any idea?

Okay the cask is updated and the website is up to date. Is there any other issues?

Most issues solved, I'm closing this issue now, and I will create another PR with a release script to standardize the procedure later.