[Bug] After update to 2.2.0, the module is not marked as compatible with v11, but also controls in modules window are missing

After update to 2.2.0, the module is still not marked as compatible with v11, but the main issue is that many of the controls available in the previous module next to each module (such as opening its Configuration windows, follow the URL to the project home etc.) are missing:

I understand for the v11 :) I hope this is tested soon. When I open the Manage Module window this is what I see in the console:

Uncaught (in promise) TypeError: t.querySelector(...) is null
[Detected 2 packages: module-credits, lib-wrapper]
    renderModuleManagement bundle.min.mjs:1
    #call foundry.js:724
    callAll foundry.js:681
    _render foundry.js:5153
    _render foundry.js:5822
    render foundry.js:5067
    _onSettingsButton foundry.js:76701
    jQuery 9
    activateListeners foundry.js:76682
    _render foundry.js:5138
    _render foundry.js:60343
    _render foundry.js:60113
    render foundry.js:5067
    initializeUI foundry.js:8069
    setupGame foundry.js:7931
    _initializeGameView foundry.js:8999
    _initializeView foundry.js:8975
    initialize foundry.js:7825
    call_wrapped libWrapper-wrapper.js:507
    libWrapperInit libWrapper-api.js:803
    initialize#0 libWrapper-wrapper.js:187
    <anonymous> foundry.js:79693
    async* foundry.js:79675
bundle.min.mjs:1:91766
    renderModuleManagement bundle.min.mjs:1
    AsyncFunctionNext self-hosted:756
    (Async: async)
    #call foundry.js:724
    callAll foundry.js:681
    _render foundry.js:5153
    AsyncFunctionNext self-hosted:756
    (Async: async)
    _render foundry.js:5822
    render foundry.js:5067
    _onSettingsButton foundry.js:76701
    jQuery 9
    activateListeners foundry.js:76682
    _render foundry.js:5138
    AsyncFunctionNext self-hosted:756
    (Async: async)
    _render foundry.js:60343
    _render foundry.js:60113
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionNext self-hosted:756
    (Async: async)
    render foundry.js:5067
    initializeUI foundry.js:8069
    setupGame foundry.js:7931
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionNext self-hosted:756
    (Async: async)
    _initializeGameView foundry.js:8999
    _initializeView foundry.js:8975
    initialize foundry.js:7825
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionNext self-hosted:756
    (Async: async)
    call_wrapped libWrapper-wrapper.js:507
    libWrapperInit libWrapper-api.js:803
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionNext self-hosted:756
    (Async: async)
    initialize#0 libWrapper-wrapper.js:187
    <anonymous> foundry.js:79693
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionNext self-hosted:756
    (Async: async)
    <anonymous> foundry.js:79675

Can you test this in Chrome or Edge. It looks like you are using Firefox? I wonder if its a bug in Firefox as for right now, this is what the currently released version looks like to me on Edge

I don't currently have firefox installed, but I can install it and test it out on firefox later tonight when I get home.

So I just installed a https://gitlab.com/fvtt-modiphius/foundryvtt-conan2d20 and created a blank world and then installed MM+ and still don't have this issue, can you send me a list of your active modules? I am lost and until I can replicate the issue

Below is the list. I haven't tried on clean world yet, but tomorrow when the session is over I can also help.
Active Modules
Bar Brawl v1.8.0 Bugs URL
Chat Portrait v0.8.46 Bugs URL
Combat Enhancements v1.2.2
Combat Tracker Effect Tooltips v3.0.0 Bugs URL
Compendium Folders v2.5.7
Dice So Nice! v4.6.8 Bugs URL
Drag Anything to Hotbar v1.1.0
Drag Ruler v1.13.4 Bugs URL
Filepicker Improvements v1.4.0 Bugs URL
FXMaster v3.6.0 Bugs URL
GM Screen v4.0.4 Bugs URL
Health Estimate v30.8.7 Bugs URL
Illandril's Token HUD scaler v2.2.1 Bugs URL
Illandril's Token Tooltips v3.2.2 Bugs URL
Layer Hotkeys v2.4.1
lib - Color Settings v2.9.1
Forien's Copy Environment vv2.1.6 Bugs URL
libWrapper v<IP_ADDRESS> Bugs URL
socketlib v1.0.13 Bugs URL
Lock View v1.5.5
Module Management+ v2.2.0 Bugs URL
Monk's Combat Details v10.2 Bugs URL
Monk's Combat Marker v10.1 Bugs URL
Monk's Little Details v10.09 Bugs URL
Monk's Player Settings v10.1 Bugs URL
Monk's Scene Navigation v10.3 Bugs URL
Ownership Viewer v0.10.0 Bugs URL
PnP - Pointer and Pings! v2.4.1 Bugs URL
Popout Resizer v1.4.5
Quick Insert - Search Widget v2.8.1 Bugs URL
Splatter v3.2.2
Status Icon Counters v2.0.16 Bugs URL
Sync Token Names v1.0.4
Token Health v0.6.0
Token Mold v2.15.4 Bugs URL
TouchVTT v1.9.1 Bugs URL
Mobile Improvements v1.1.1 Bugs URL
Minimal UI v1.5.6

Alright, So I downloaded and installed as many of these as I could, the ones I couldn't foundry said it couldn't install them or that it was for an older core version.
System Details
Browser: Edge v1114.0.1823.37
Foundry VTT: v11.300
System: Robert E. Howard's Conan: Adventures In An Age Undreamed Of v1.9.3
Active Modules
Bar Brawl v1.8.1 Bugs URL
Chat Portrait v0.7.4 Bugs URL
Combat Enhancements v1.2.2
Combat Tracker Effect Tooltips v11.0.0 Bugs URL
Compendium Folders v2.6.1
Dice So Nice! v4.6.8 Bugs URL
Drag Ruler v1.13.4 Bugs URL
Filepicker Improvements v1.2.5 Bugs URL
FXMaster v4.0.1 Bugs URL
GM Screen v4.0.4 Bugs URL
Health Estimate v30.8.7 Bugs URL
Illandril's Token HUD scaler v2.2.1 Bugs URL
Illandril's Token Tooltips v3.2.2 Bugs URL
Layer Hotkeys v2.4.0
lib - Color Settings v2.9.1
Forien's Copy Environment vv2.1.6 Bugs URL
libWrapper v<IP_ADDRESS> Bugs URL
socketlib v1.0.13 Bugs URL
Lock View v1.5.5
Module Management+ v2.2.0 Bugs URL
Monk's Combat Details v10.2 Bugs URL
Monk's Combat Marker v10.1 Bugs URL
Monk's Little Details v10.09 Bugs URL
Monk's Player Settings v10.1 Bugs URL
Monk's Scene Navigation v10.3 Bugs URL
Quick Insert - Search Widget v2.8.3 Bugs URL
Splatter v3.3
Status Icon Counters v2.0.17 Bugs URL
And everything seems to be working fine. The only other thing I can think to do is, if you go to https://github.com/mouse0270/module-credits/releases/tag/2.2.0 and download the Source code (zip) file and extract those files over the module-credits folder in your Foundry User Data folder, it might be able to give us a better idea of which line is breaking, as rollup.js minifies the package for release.

Howdy!  First off, terrific module - thanks for your time and effort on developing it!  I was experiencing the same issue(s) as Valyar, attempted all of the usual things without any success, but took your advice on downloading the ZIP file.  Traced it to line 807 in module.mjs: elemPackage.querySelector('.package-overview span.tag i.fas.fa-user').closest('span.tag').remove(); which is consistently returning a null value instead of a valid object.
Commenting this out resolved the issue immediately (apparently the dislike is mutual between you and the author tag ;p); all other calls to FA icons are successful.  No other modules were active during this exercise and, with MM+ subsequently disabled completely, no instances of the fa-user icon appear in the default package list render.  Only other thing that might be common to both of us is...@r-valyar, any chance you're hosted through Forge?
Hope this helps!

No that completely makes sense, because I remove their author tag in favor of mine, as mine will list all available social networks that people may add, where there's just adds a link to the url from what I can tell.
I can fix this today and push out an update later.

@PanSatyricon  I self-host in Azure

Heh - nice update title. ;)  Yes, everything appears to be functioning as expected with 2.2.1 both when loaded from the Forge bazaar and imported directly from source files.  Much appreciated!

I think there is an issue. On v11 the same world looks different when module is loaded:
V10:

V11:

Heh - nice update title. ;) Yes, everything appears to be functioning as expected with 2.2.1 both when loaded from the Forge bazaar and imported directly from source files. Much appreciated!

I try to have fun with them... what the point of putting work into tracking all my changes if I can't? haha
@r-valyar are you getting any errors? It looks like something still isn't working as its supposed to.

@mouse0270  yep, this is the console output from V11 (on v10 all is clean)

Are you able to download and install the Source Code (zip) from https://github.com/mouse0270/module-credits/releases/tag/2.2.1 and see if it gives any better example of what the error might be.

This is what I received after updating from the module interface. is the zip same?

Yeah, the "compatibility" warning is a dispute between foundry and I... Basically I wont mark it as v11 verified because I haven't went through every thing and tested everything, nor have I had anyone confirm everything work perfect, actually I've been told of bugs.
So its only verified to work on v10 because it works on v10... But foundry basically shows this warning unless you say its verified... but in my personal opinion, it hasn't been verified to work on v11.
As for the zip. The Package downloaded from the manifest.json url will downloaded a bundled version of the module that is minfiied. Overriding the files in module-credits with those found in Source Code (zip) will give you the unminified files and may make bug reporting easier to determine.

Yes, I get the verification part. No issue. Will get the zip tomorrow and test, as I am now on the tablet and can’t do much as I host machines in Azure.  I will be Guinea pig and see where we can go with this.

v2.2.1 seems to have fixed the issue for most others, so I am honestly not sure what is causing this specific issue. So any further details will help me fix the issue.

This is the console error that appears after I put the module from the zip file:

It says bundle.min.mjs are you sure you downloaded the file labeled Source Code (zip) and extracted its contents into the module-credits folder?

I just did. This is the output of the console from MS Edge:

Can you do this again, but with the Source Code (zip) file here: https://github.com/mouse0270/module-credits/releases/tag/<IP_ADDRESS>

Absolutely! :)
Seems this fixed it:

thanks for jumping through all those hoops for me, looks like I can close this issue and release v<IP_ADDRESS>


Java RSA compatibility

Hi. I am trying to implement Javascript encryption and Java decryption system.
Javascript part:

key = [new Uint8Array([0x00, .....]), new Uint8Array([0, 1, 0, 1])]
data = asmCrypto.RSA_OAEP_SHA256.encrypt("abc", key, "");

Java part:

Cipher rsa = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding");
rsa.init(Cipher.DECRYPT_MODE, entry);
String decrypted = new String(rsa.doFinal(data));

Key exchange: Key was generated and stored in the keystore. Java loads it directly from it.
Next key was extracted to .pem file:

keytool -list -rfc -keystore keystore.jks -alias testkey -storepass 123456
Parsed:
openssl x509 -inform pem -text -in key.pem
And put into a tuple as discussed here https://github.com/vibornoff/asmcrypto.js/issues/98#issuecomment-209900658

So, when trying to do so, I get:

Caused by: javax.crypto.BadPaddingException: Decryption error

So the questions are:

Is there any code example, how one can make Javascript-java compatible encryption/decryption?
In the RSA_OAEP_SHA256 which MGF parameter is used?
Any suggestions on how to troubleshoot this issue?

Is there any code example, how one can make Javascript-java compatible encryption/decryption?
Any suggestions on how to troubleshoot this issue?
Your code snippet seems legit. Try to remove leading 0x00 from the RSA modulus part.

In the RSA_OAEP_SHA256 which MGF parameter is used?
SHA-256 for both hashing and MGF.

Your code snippet seems legit. Try to remove leading 0x00 from the RSA modulus part.
I've tried with and without it - the same.

I've tried the following:
Java:

Cipher.getInstance("RSA/ECB/OAEPWithSHA-1AndMGF1Padding");
JS:
asmCrypto.RSA_OAEP_SHA1.encrypt("abc", key, "");

And it worked.
So, I guess, the problem is:

SHA-256 for both hashing and MGF.

By default Java supports the following RSA algorithms:

RSA/ECB/PKCS1Padding (1024, 2048)
RSA/ECB/OAEPWithSHA-1AndMGF1Padding (1024, 2048)
RSA/ECB/OAEPWithSHA-256AndMGF1Padding (1024, 2048)

So, now the question is, is there possibility to configure MGF in JS library? And could you point, where is it performed?

SO, proceeding with some tests, I've got it working:
JS code:

enc = asmCrypto.RSA_OAEP_SHA256.encrypt("abc", key, "");

And Java:

Cipher rsa = Cipher.getInstance("RSA/ECB/OAEPPadding");
OAEPParameterSpec oaepParams = new OAEPParameterSpec("SHA-256", "MGF1", new MGF1ParameterSpec("SHA-256"), PSource.PSpecified.DEFAULT);
rsa.init(Cipher.DECRYPT_MODE, key, oaepParams);
String decrypted = new String(rsa.doFinal(data));

The problem is that by default "RSA/ECB/OAEPWithSHA-256AndMGF1Padding" algorithm is using SHA-1 For MGF1, regardless that SHA-256 is provided for hashing.
So, it would be nice to have ability to config Hash for MGF separately.

I want to encrypt using RSA_OAEP_SHA256 at JavaScript side
var encrypted = asmCrypto.RSA_OAEP_SHA256.encrypt(stringToBeEncrypted, pubkey, "");
getting error: Uncaught TypeError: Cannot read property 'encrypt' of undefined
Do you know the solution or any example that would help?
Thanks


Tokenizer's nb_words not taking effect when fit_on_texts is run - please fix or re-open #4998

The Tokenizer still doesn´t take into account the nb_words (nor num_words) argument.
from keras.preprocessing.text import Tokenizer

MAX_NB_WORDS = 20000

tokenizer = Tokenizer(num_words=MAX_NB_WORDS)
tokenizer.fit_on_texts(texts)
sequences = tokenizer.texts_to_sequences(texts)

word_index = tokenizer.word_index
print('Found %s unique tokens.' % len(word_index))

Results for my texts (newsgroup example from Keras blog) in this:
Found 174074 unique tokens.
How can I fix this?

I found this thread that explains how Tokenizer interprets the num_words parameter:
https://github.com/fchollet/keras/issues/7551
Therefore I close this issue. Sorry for my misunderstanding.


create_exploration_memory() is hard to understand.

I find it shows level, hp, explore as bar. But what about color, cover, bound.
I notice hp is green bar. But I didn't find where define green.
And when I scale up pixels, bars actually are blurry.

Its definitely not standard or easy to understand. It can be removed without much impact on performance too. Was working on that in a branch but didn't full match original performance.
you can also check out this repo which has a simpler implementation:
https://github.com/PufferAI/pokegym


[refactor] Cleanup contracts a bit

There are some bug fixes, comments, error messages, and formatting help to make it more legible for other users.
Additionally, some error checks were moved earlier, which can help some gas costs in failure scenarios.

This looks great. Thanks for optimizing the code


GoogleService-Info.plist not found

The file “GoogleService-Info.plist” couldn’t be opened because there is no such file. Hope you can upload this plist!Thank you very much!

I forgot to upload this file , it will be upload next update , thx.

I forgot to upload this file , it will be upload next update , thx.

ok,thanks a lot !I want to learn how to use fish_redux for full appcation!

GoogleService-Info.plist is now uploaded


Add allowipcproc to support ALLOWIPCPROC

I guess this changes are already integrated at voxpopuli https://github.com/voxpupuli/puppet-rkhunter
Thank you very much and sorry for ignoring this for such a long time


Update Node stable to v.0.12.0

Patch is from ewemoa on IRC and claims it built successfully. User didn't want to create a Github account. Original patch is at https://pastee.org/zx45s

http://www.lgtm.in/p/ciEU8f6Bn
Now we need to update unstable so it's not older than stable :grin:


getting "tar: Unexpected EOF in archive" error

Hi all, I am getting the following error when I try to create a Singularity image using the following command. Any ideas why I am getting this error. I tried creating images for other apps (like CPAC) which were made without this or any error. Thanks for any help!
$ docker run --privileged -t --rm -v /var/run/docker.sock:/var/run/docker.sock -v /Users/saggar/Singularity:/output singularityware/docker2singularity bids/fmriprep:latest
Size: 15318 MB for the singularity container
(1/9) Creating an empty image...
Creating a sparse image with a maximum size of 15318MiB...
Using given image size of 15318
Formatting image (/sbin/mkfs.ext3)
Done. Image can be found at: /tmp/bids_fmriprep_latest-2017-06-13-7a3a119f98c2.img
(2/9) Importing filesystem...
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

It seems that this bug belongs more to https://github.com/singularityware/docker2singularity than here.
Nonetheless - have you tried resetting Docker and trying again?

Oops sorry. Thanks complete reset (factory reset) worked. Thanks!


Build migration planning review process for STORAGE_MIGRATION (regarding HDFS to Ozone)

The help with the mapping process and best practices in converting from HDFS to Ozone, we need to build a mapping plan for moving data from a single namespace hierarchical filesystem to the multi-tenant bucket centric world of Ozone.

The new Web UI (and CLI) version(s) supports the concept of "Warehouse Plans" to accomplish this.  Refer to the new docs for details.


fix: Merge container from env vars with existing env vars

Fixes https://github.com/dagger/dagger/issues/4085
Merges existing env vars with the container env vars.

@sipsma Can you review it again if you get some time? Thanks!


Highlight bug introduced recently (screenshot included)

This kind of bug started very recently:

Sorry about that. I must've introduced that issue when I added syntax highlight for a few PHP keywords. Fixed in newest version (0.23.2).


Cannot Launch Ansible Tower Workflow Template

Recently installed a new set of appliances on petrosian 1, and am noticing we no longer can launch Ansible Tower workflows. When we attempt to launch a workflow from either an Automate instance, or a button, we always get a runtime error stating:
ERROR -- automation: The following error occurred during method evaluation:
ERROR -- automation: RuntimeError: Job Template not specified
In the instance we have the name of the workflow defined as an attribute job_template_name. Here is a screenshot of the instance:

Ive also tried setting the job template name with a .missing instance and calling that with the job template name appended, but same error. In our VMDB, I can see the workflow template and I can also see the workflow template under Automation --> Automation --> Templates

We can launch job templates just fine from a button and can even launch a workflow template from a service catalog item and bundle, but when launching just a workflow template from either a button or Automate instance, it appears it cannot find the template and returns the errors shown above.

Hey @bfilion87 I started investigating this last week.  I was able to run a workflow template from a service catalog item successfully, I'm working on getting an automate instance referencing a workflow shortly.

Hey @bfilion87 I started investigating this last week. I was able to run a workflow template from a service catalog item successfully, I'm working on getting an automate instance referencing a workflow shortly.

Sounds good! Yeah I was able to get a workflow to run from a service catalog item as well. Where I run into an issue is from a button or from an automate instance. In my case, I am attempting to run an ansible/AWX workflow during a VM retirement.


public: Add a responsive "My links" view

A future commit will add an end-to-end test or two.

Coverage increased (+0.07%) to 97.952% when pulling 095c350d5fdf7b15435e51a204e4352b437e8155 on my-links into c484cd320d3d6e1b7549ceca01136fdf67f4626e on master.

Coverage increased (+0.07%) to 97.952% when pulling 095c350d5fdf7b15435e51a204e4352b437e8155 on my-links into c484cd320d3d6e1b7549ceca01136fdf67f4626e on master.


[BUG] Error when pushing model to HuggingFace

🐛 Bug
When trying to push finetuned model to HF OR download model,  KeyError occurred.
2024-03-12 15:45:24,520 - INFO: Loaded h2oai/h2ogpt-4096-llama2-7b.
2024-03-12 15:45:24,522 - INFO: Lora module names: ['q_proj', 'k_proj', 'v_proj', 'o_proj', 'gate_proj', 'up_proj', 'down_proj']
trainable params: 9,994,240 || all params: 6,748,409,856 || trainable%: 0.14809770321098886
2024-03-12 15:45:27,392 - ERROR: Unknown exception
Traceback (most recent call last):
  File "/home/jeff/h2o-llmstudio/./llm_studio/app_utils/handlers.py", line 337, in handle
    await experiment_push_to_huggingface_dialog(q)
  File "/home/jeff/h2o-llmstudio/./llm_studio/app_utils/sections/experiment.py", line 1808, in experiment_push_to_huggingface_dialog
    publish_model_to_hugging_face(
  File "/home/jeff/h2o-llmstudio/./llm_studio/app_utils/hugging_face_utils.py", line 108, in publish_model_to_hugging_face
    cfg, model, tokenizer = load_cfg_model_tokenizer(
  File "/home/jeff/h2o-llmstudio/./llm_studio/app_utils/sections/chat.py", line 201, in load_cfg_model_tokenizer
    load_checkpoint(cfg, model, strict=False)
  File "/home/jeff/h2o-llmstudio/./llm_studio/src/utils/modeling_utils.py", line 237, in load_checkpoint
    model = load_model_weights(model, model_weights, strict, cfg)
  File "/home/jeff/h2o-llmstudio/./llm_studio/src/utils/modeling_utils.py", line 153, in load_model_weights
    model_weights = {
  File "/home/jeff/h2o-llmstudio/./llm_studio/src/utils/modeling_utils.py", line 160, in <dictcomp>
    else model_state_dict[k]
KeyError: 'backbone.base_model.model.model.layers.0.self_attn.q_proj.base_layer.weight.quant_state.bitsandbytes__nf4'

To Reproduce

Run experiment with

backbone_dtype: int4
lora enabled

LLM Studio version
$ git rev-parse HEAD
80a75cd628f69ad7ae4f0ae850833ba813959041

Seems related to this pr https://github.com/TimDettmers/bitsandbytes/pull/753 introduced in bitsandbytes==0.42.0

Thanks @jeffwang0516 - I opened a PR to fix the issue.


Creating Dockerfile for build of application

Image build process
docker build -t market-manager-backend .

Image run process
docker run -e "DB_URL=" -e "DB_USERNAME=" -e "DB_PASSWORD=" -e "JWT_SECRET=" --name market-manager-backend -d -p 8080:8080 market-manager-backend


Update register-scan-azure-databricks.md - Missing step

Added step to provide access to purview account to read Azure Key Vault secrets.

@linda33wj

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@stvflowers - I am making these updates in another request, as I also want to make sure to link to the documentation on how to grant Purview the permissions to access the Key Vault.
Once the linked pull request above is merged through, you should see the update in about 24 hours.
Thank you for reaching out and improving our documentation! You can close this Pull Request once the above
is merged.

@stvflowers - The changes have been merged. Can you close this PR?


Add handler print-object method to make them more legible.

@BlueFlo0d Trivial but a great improvement nonetheless :)

Nice improvement!

Unless you have a particular preference for the merge policy, I prefer to avoid merge commits for trivial twigs like this one.  On GitHub, you can click the drop-down arrow and choose to "rebase and merge" instead of just merging.  Does that make sense?

Unless you have a particular preference for the merge policy, I prefer to avoid merge commits for trivial twigs like this one. On GitHub, you can click the drop-down arrow and choose to "rebase and merge" instead of just merging. Does that make sense?

Sure! Thanks for the note.


In-depth integration with Choreo

Analyze and implement in-depth integration options with Choreo

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Added logo to README.rst

I added logos in two color schemes:
First is:

Second is:

Images are located in media/
In README.rst we use first logo, but i can change it, if you want.

I like both, but the first one is slightly better.

@sobolevn I removed second logo. Can i merge it or any other remarks?

@sobolevn Here i renamed media/ to other/. I can create PR and merge it if name of directory is significant or remove branch if not.

media is fine. Thanks!


APP-63 Fix datacollection demo build

/cc @forGGe @rasendubi

@rasendubi take a look please

LGTM


Add social cards

⚠ IMPORTANT ⚠: This is a public repository. Make sure to not disclose:

[x] personal data beyond what is necessary for interacting with this Pull Request;
[x] business confidential information, such as customer names.

I just discovered that mkdocs-material, the tech that fuels elastisys.io, includes a social plugin. Said plugin can generate a social card for each page, which includes our logo, the page title and page description.
I'm copy-pasting some examples below.
If we want to background image then we need to sponsor mkdocs-material with at least $125/months. I feel that no background image is good enough for now, and we should revisit sponsorship later.
What do you think?

I don't quite understand here. Does getting the thing you're showing in the screenshots require us to sponsor mkdocs?
Or is it something else that requires sponsorship?

Then it 100% looks good enough for me.  How long do they get to be to still fit?
It seems like merging this PR as such is only 5% of the full work, because the other 95% is about making sure all pages have good metadata that this would pick up and generate images from. Correct?

Surely merging these 5% would be better than not doing it. Ew.


refactor: the table is not in the center.

The table which displays the information about the user is align:Left it would be great its align:Center changing the alignment will not help as the table can be move to left and right only but the content can be centralized.

its been solved


chore: add fix table fragment ctl

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Options:
      --etcd-endpoints <ETCD_ENDPOINTS>
          The address of the etcd cluster [default: localhost:2388]
      --etcd-username <ETCD_USERNAME>
          The username for etcd authentication, used if `--enable-etcd-auth` is set
      --etcd-password <ETCD_PASSWORD>
          The password for etcd authentication, used if `--enable-etcd-auth` is set
      --enable-etcd-auth
          Whether to enable etcd authentication

./risedev ctl debug fix-table-fragments --table-d 1 --dirty-fragment-ids 1

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@shanicky @zwang28 PTAL


Upgrading from 0.9.7 to 0.9.8

        GraphQLSchemaGenerator generator = new GraphQLSchemaGenerator()
                .withNestedResolverBuilders(resolverBuilder)
                .withValueMapperFactory(valueMapperFactory)
                .withOutputConverters((config, defaults) -> defaults.drop(ObjectScalarAdapter.class));

This works fine under 0.9.7, but won't compile under 0.9.8.
In 0.9.7 ObjectScalarAdapter implements OutputConverter<Object, Map<String, ?>> but it does not in 0.9.78. Is there a replacement class? Or do we need to implement our own?

ObjectScalarAdapter has been removed, indeed, but all that line does is dropping the ObjectScalarAdapter. So just remove the line :)

Would be funny if you implemented your own replacement solely for the purpose of dropping it :)

I may or may not have already done that while waiting for a reply...
Thanks!


Helm deploy task fails with Environment in YAML Release Pipeline

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
HelmDeploy@0 tasks fails to authenticate the cluster when using the environment in yaml release pipeline
Question, Bug, or Feature?
Type: Bug
Enter Task Name: here
HelmDeploy@0
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines
Account: waynefs
Project: NextGenMedia
Build Definition Id: 260

Agent - Hosted
agent queue name: ubuntu-20.04

Issue Description
HelmDeploy@0 tasks fails to authenticate the cluster when using the environment in yaml release pipeline
Getting the below error:
[error]Error: Kubernetes cluster unreachable: Get "http://localhost:8080/version?timeout=32s": dial tcp [::1]:8080: connect: connection refused. I have attached my service connection, resource and environment configuration screenshots as well
Here is my pipeline
`- stage: Deploy
displayName: Deploy
jobs:

deployment: Deploy
displayName: Deploy
environment: Dev.default
pool:
vmImage: 'Ubuntu 20.04'
strategy:
runOnce:
deploy:
steps:
- task: HelmInstaller@0
inputs:
helmVersion: '3.2.4'
installKubectl: true
  - task: HelmDeploy@0
    displayName: Helm upgrade
    inputs:
      command: upgrade
      chartType: filepath
      chartPath: $(Pipeline.Workspace)/charts/myservice-2.0.0.tgz
      releaseName: apple
      install: true
      waitForExecution: true
      connectionType: None`

Task logs
logs_83542.zip

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[error]Error: Kubernetes cluster unreachable: Get "http://localhost:8080/version?timeout=32s": dial tcp [::1]:8080: connect: connection refused

I have event tried changing the service connection of type kubeconfig and manually updating it as well. I get the same issue even after trying that.

@raswinraaj Could you please validate the server url in Kuubeconfig that you are using? It should have been a public endpoint, but from the error logs, looks like it is not: http://localhost:8080/version?timeout=32s

@raswinraaj Could you please validate the server url in Kuubeconfig that you are using? It should have been a public endpoint, but from the error logs, looks like it is not: http://localhost:8080/version?timeout=32s

Closing stale issue. Feel free to reopen it in case you need more clarity.

Closing stale issue. Feel free to reopen it in case you need more clarity.

I am experiencing a similar problem.
I have defined the following YAML:
- stage: Deploy
  jobs:
  - deployment: stage_v2
    displayName: stage-v2
    environment: 'aksstage.devops'
    dependsOn:
    pool:
      name: $(vmName)
    strategy:
      runOnce:
        deploy:
          steps:
          - checkout: self
- task: HelmInstaller@0
            displayName: 'Install Helm $(helmVersion)'
            inputs:
              helmVersion: '$(helmVersion)'
              checkLatestKubectl: true
          - task: Bash@3
            displayName: 'Bash Script'
            inputs:
              targetType: filePath
              filePath: '$(appDir)/prepare.sh'
          - task: HelmDeploy@0
            displayName: 'helm upgrade'
            inputs:
              namespace: 'devops'
              command: 'upgrade'
              chartType: 'Name'
              chartName: 'csi-secrets-store-provider-azure/csi-secrets-store-provider-azure'
              releaseName: 'csi-secrets-store-provider-azure'
              valueFile: '$(appDir)/values.yaml'

While aksstage is a Kubernetes provider with a devops namespace as the resource.
However, when I run it, it keeps failing with the following message:

Error: UPGRADE FAILED: could not get information about the resource: customresourcedefinitions.apiextensions.k8s.io "secretproviderclasses.secrets-store.csi.x-k8s.io" is forbidden: User "system:serviceaccount:devops:***" cannot get resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

Only when I add the following to the HelmDeploy task it works:
connectionType: 'Azure Resource Manager'
azureSubscription: 'Microsoft Azure Sponsorship (..)'
azureResourceGroup: 'stage-general'
kubernetesCluster: '...'

and while it does deploy, the environment resource stays empty:

So I assume that the same problem occurs because of permission issue.
Having said that, the environment: dev with the default namespace does work as expected:

And the ServiceAccount that was created by Azure DevOps is indeed set to be a cluster-admin.
Any idea what might went wrong?
Thanks
Shaked


Allow suppression of all rules for a file

StyleCop Classic allowed you to do this:
<Compile Include="Collection\OrderedDictionary.cs">
  <ExcludeFromStyleCop>true</ExcludeFromStyleCop>
</Compile>

Which we found very useful when we wanted to just drop externally-written code in without having to make it conform to our typical StyleCop rules.  I cannot find a good replacement in StyleCopAnalyzers.  It seems I need to [SuppressMessage] or #pragma each element and each rule in turn, which can be quite a lot of work and requires changing the original file which is not ideal.
Is there/can there be a simpler way to mark a file as "don't bother, StyleCop!"?

It seems like
// <auto-generated />

sort of would do this, though I don't quite understand how it works and anyway, it's obviously a hack.
Being able to externally mark the file as do-not-process or being able to flag it with something would be of value.

sort of would do this, though I don't quite understand how it works and anyway, it's obviously a hack.

This is the standard way to indicate that a file should not have style analysis run on it. It's implemented in an optimized manner within the compiler itself. 😄

@sharwell Should that be documented then as the official prescribed way to mark a file as "do not bother to analyze", or should there be some kind of stylecop-specific mark?

@mavasani is this pattern documented anywhere for Roslyn?

No, it is part of heuristic that determines generated code in the analyzer driver, which is not documented behavior but it will likely not break in future. Note that autogenerated tag will skip execution and/or diagnostic reporting on file only if analyzer has explicitly configured generated code analysis by invoking AnalysisContext.CongigureGeneratedCode API.

Note that autogenerated tag will skip execution and/or diagnostic reporting on file only if analyzer has explicitly configured generated code analysis by invoking AnalysisContext.CongigureGeneratedCode API.

All analyzers in this repository are configured that way 🛩

It seems to me that a method to control StyleCop specifically rather than incidentally disabling all analyzers might be nice, but we can definitely move forward with this.
Thanks a lot @sharwell @mavasani!

@watsonsong This project does not control code exclusions. You'll want to file a feature request on dotnet/roslyn for that.

Thanks, I asked in roslyn-analyzers because I think this is a common request not just for stylecop. And I get a link to this issue.
https://github.com/dotnet/roslyn-analyzers/issues/2140
May be I will wait the .editorconfig support for c# compilers.


stack overflow crash/OOM when hovering

If you hover over the x in |x| in my day 1 advent of code solution rust analyzer crashes with stack overflow/OOM errors.
use std::error::Error;
use std::fs::File;
use std::io::{BufRead, BufReader};

pub fn larger_moving_group_count(seq: &[impl PartialOrd], grp_size: usize) -> usize {
    seq.windows(grp_size + 1)
        .filter(|x| x.last().unwrap() > x.first().unwrap())
        .count()
}

fn main() -> Result<(), Box<dyn Error>> {
    let depths: Vec<i32> = BufReader::new(File::open("input.txt")?)
        .lines()
        .map(|l| l.unwrap().parse().unwrap())
        .collect();
    let part1 = larger_moving_group_count(&depths, 1);
    let part2 = larger_moving_group_count(&depths, 3);
    println!("part 1: {}", part1);
    println!("part 2: {}", part2);
    Ok(())
}

rust-analyzer version: (eg. output of "Rust Analyzer: Show RA Version" command) it should be the one from this past monday (e.g. in vscode, my neovim install), but also old ones like on https://ra-wasm.netlify.app/ crash too
rustc version: (eg. output of rustc -V)
rustc 1.57.0 (f1edd0429 2021-11-29)

Oh this is a fun one, the right hand side of the impl PartialOrd is inferred to be the same impl PartialOrd again, and for that one again and so on..., as can be seen by the type hint


Suport 10.10.52?

This module is great, you update to a new version of support for Youtube 10.10.52?

Yes, very soon.


DIP 161 Optional Result Field

Adding DIP 161: optional result field in off-chain protocol as defined in this issue https://github.com/diem/dip/issues/161

I don't think there's any big blockers here, but hit me up or dismiss review so we can get it in


Private DNS Zones must be in the same subscription as AKS

Looks like when Private DNS Zones are specified, the zone has be defined in the same subscription as AKS.  This breaks when there's a Hub & Spoke network topology where Hub subscription manages private dns zones.
If this is really not supported, then we need to get this documented on the page.
Steps to reproduce:
Hub Subscription

Create private dns zone:  privatelink.canadacentral.azmk8s.io

Spoke Subscription

Create User Assigned Managed Identity.  i.e. aks-managed-identity
Assign RBAC to aks-managed-identity with 'Private DNS Zone Contributor' and wait 1-2 minutes for IAM propagation
Create AKS with managed identity and a reference to private zone in the Hub Subscription.

Example Azure CLI:
az aks create -n akstest1 -g test --load-balancer-sku standard --enable-private-cluster --enable-managed-identity --disable-public-fqdn --assign-identity /subscriptions/<spoke-subscription-id>/resourceGroups/test/providers/Microsoft.ManagedIdentity/userAssignedIdentities/aks-managed-identity --private-dns-zone /subscriptions/<hub-subscription-id>/resourceGroups/dns-rg/providers/Microsoft.Network/privateDnsZones/privatelink.canadacentral.azmk8s.io

Error:
{
    "status": "Failed",
    "error": {
        "code": "CheckAccessError",
        "message": "failed to check access for permission regarding resource /subscriptions/<hub-subscription-id>/resourceGroups/dns-rg/providers/Microsoft.Network/privateDnsZones/privatelink.canadacentral.azmk8s.io."
    }
}

The only way to make this work is to put the Private DNS Zone in the spoke subscription.  When this is done, the exact Az CLI command works.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b68f2c4-bb6c-11a2-6c61-8af4057a2438
Version Independent ID: e3498bed-1447-6841-8353-9f1b5d3dc8df
Content: Create a private Azure Kubernetes Service cluster - Azure Kubernetes Service
Content Source: articles/aks/private-clusters.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@SenthuranSivananthan
Thanks for your Question! We are currently investigating and will get back on this.

Thanks @VikasPullagura-MSFT.  I've been testing since opening this issue and this could be related to IAM propagation.
I created a User Assigned Managed Identity, let it sit for ~5 minutes and I'm now able to use it.  Originally, I waited just 1 or 2 minutes. Not sure if it was just bad timing or not.  I will test in parallel as well.

@SenthuranSivananthan Thanks for sharing the update. Please check and let us know if you are still seeing the issue.

@SenthuranSivananthan thank you for sharing this information. Indeed this is valuable. Please do let us know of results at your end. In the meanwhile, it is key that:

If the Private DNS Zone is in a different subscription than the AKS cluster, you need to register Microsoft.ContainerServices in both the subscriptions.

[How-to guide]

Additionally, you will need a user assigned identity or service principal with at least the private dns zone contributor and vnet contributor roles.

@SrijitBose-MSFT Thanks for adding the details.
@SenthuranSivananthan
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.

@SrijitBose-MSFT To which resource scope would I need to apply the vnet contributor role?  I'm able to get a functioning AKS cluster w/ private dns zone in a separate subscription with just private dns zone contributor on the zone itself.

@SenthuranSivananthan The VNET Contributor role mentioned earlier should be granted on the scope of the AKS cluster's virtual network. This is mostly important if you are using a user assigned managed identity or a service principal and deploying the AKS cluster in an existing virtual network.

@SrijitBose-MSFT thanks!  this clarifies for me.
Is it possible to create a table on the page and list both roles & the scope each should be assigned to?

@SenthuranSivananthan
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@mlearned @zr-msft
Can you please check and add your comments on this doc update request as applicable.

Thank you @SenthuranSivananthan for the feedback!
We've added an item to our backlog and will prioritize accordingly.
#please-close

#please-close


Make case sensitive methods Unicode aware

Currently methods like upcase, downcase and the new compare only respect ASCII case sensitivity. We should add normalization and comparison methods respecting Unicode equivalence and other case sensitivity  related parts of the Unicode standard.

I think this should really go into a Unicode module of some sort. Imagine comparing a string or checking the presence of a string in a hash, and doing the normalization process all the time. It will slow down everything.

Couldn't we mark string as ASCII or MaybeUnicode to use optimized algorithms in each case?
Playing nice with unicode as default is a good thing IMO.
Also case insensitivity should be used only by demand, so I would expect that checking string in a hash to be CS.

Well UTF-8 is fully ASCII compatible and I don't believe there are any normalizations done for the codepoints betwee 128 and 255, so we could just reuse the single byte optmizable flag.

Ah, right, we already have a fast path for ASCII in many places, so you are right.
However, the unicode equivalence article says:

For example, the code point U+006E (the Latin lowercase "n") followed by U+0303 (the combining tilde "◌̃") is defined by Unicode to be canonically equivalent to the single code point U+00F1 (the lowercase letter "ñ" of the Spanish alphabet).

So let's see what Ruby does: http://carc.in/#/r/he5
It considers the strings different, but they are equal for unicode. So should their #hash be equal? Should they be true when compared with ==? And if you insert one in a Hash, should it be there when you get it using the other one?

I think people can understand that they're different, I'm not aware of any language that does implicit normalization, Rubyists are used to it not happening anyway. So the answer is no, they're not equal, they're different byte sequences after all. I'm asking for explicit normalization here and implicit normalization only where it makes sense like in downcase etc..

As some data point, the just released Ruby 2.4 preview does this now on the regular String methods: https://bugs.ruby-lang.org/issues/10085

We can do this. What's the algorithm?

I'm not sure, it looks like it's just based upon existing capabilities of oniguruma, so a bit hard to track down https://github.com/ruby/ruby/commit/be897c2507a9d7710f218ccf377e6ea67d6d47bf

https://github.com/ruby/ruby/blob/trunk/enc/unicode/case-folding.rb

Yeah, I think most of Ruby's unicode support comes from oniguruma... which is a regex engine... weird :-P

What progress on this issue?

@dimparf No progress, this is super hard, and probably low priority right now. But if someone wants to tackle this, go ahead :-)


Support GHC 7.8

Closing in favour of tightening deps: https://github.com/pusher-community/pusher-http-haskell/pull/48.


HBASE-25452 Use MatcherAssert.assertThat instead of org.junit.Assert.…

…assertThat

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 36s
master passed

+1 :green_heart:
checkstyle
3m  4s
master passed

+1 :green_heart:
spotbugs
6m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
checkstyle
0m 31s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
0m 18s
The patch passed checkstyle in hbase-zookeeper

+1 :green_heart:
checkstyle
0m 13s
The patch passed checkstyle in hbase-replication

+1 :green_heart:
checkstyle
0m 12s
The patch passed checkstyle in hbase-http

+1 :green_heart:
checkstyle
1m 19s
hbase-server: The patch generated 0 new + 38 unchanged - 1 fixed = 38 total (was 39)

+1 :green_heart:
checkstyle
0m 17s
The patch passed checkstyle in hbase-rest

+1 :green_heart:
checkstyle
0m 12s
The patch passed checkstyle in hbase-hbtop

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 34s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
8m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
1m 17s
The patch does not generate ASF License warnings.

64m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2826

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 2ec4bb7abf2a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 13s
master passed

+1 :green_heart:
compile
3m 22s
master passed

+1 :green_heart:
shadedjars
6m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 39s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 43s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-replication in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-http in the patch passed.

+1 :green_heart:
unit
130m 53s
hbase-server in the patch passed.

+1 :green_heart:
unit
3m 24s
hbase-rest in the patch passed.

+1 :green_heart:
unit
0m 48s
hbase-hbtop in the patch passed.

176m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2826

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 453436f73bf4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/testReport/

Max. process+thread count
4043 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
3m  1s
master passed

+1 :green_heart:
shadedjars
6m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 20s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
3m  3s
the patch passed

+1 :green_heart:
javac
3m  3s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

+1 :green_heart:
unit
0m 43s
hbase-zookeeper in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-replication in the patch passed.

+1 :green_heart:
unit
0m 42s
hbase-http in the patch passed.

+1 :green_heart:
unit
138m 26s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  0s
hbase-rest in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-hbtop in the patch passed.

181m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2826

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 40b860f8151f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/testReport/

Max. process+thread count
4580 (vs. ulimit of 30000)

modules
C: hbase-client hbase-zookeeper hbase-replication hbase-http hbase-server hbase-rest hbase-hbtop U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2826/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


release

When can we expect the next release to npm? Would love to get the change in that removes the noisy console.log.

Thanks for the reminder!
I would need to set up a release pipeline/timeline for the libs.
Just published 1.0.10 to npm.


Bazelisk: error during the fetch of repository 'google_bazel_common'

I'm trying to build Closure-Compiler v20201006 using Bazelisk under Windows 7 x64.
I get the following error:
A:\Desktop\closure-compiler-20201006> ..\bazelisk build //:compiler_unshaded_deploy.jar
Loading:
Loading: 0 packages loaded
INFO: Call stack for the definition of repository 'google_bazel_common' which is a git_repository (rule definition at C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git.bzl:195:18):
 - <builtin>
 - A:/desktop/closure-compiler-20201006/WORKSPACE.bazel:5:1
ERROR: An error occurred during the fetch of repository 'google_bazel_common':
   Traceback (most recent call last):
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git.bzl", line 177
                _clone_or_update(ctx)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git.bzl", line 36, in _clone_or_update
                git_repo(ctx, directory)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 91, in git_repo
                _update(ctx, git_repo)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 101, in _update
                init(ctx, git_repo)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 115, in init
                _error(ctx.name, cl, st.stderr)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 181, in _error
                fail(<1 more arguments>)
error running 'git init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common' while working with @google_bazel_common:
java.io.IOException: ERROR: src/main/native/windows/process.cc(199): CreateProcessW("git" init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common): The system cannot find the file specified.
 (error: 2)
ERROR: no such package '@google_bazel_common//': Traceback (most recent call last):
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git.bzl", line 177
                _clone_or_update(ctx)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git.bzl", line 36, in _clone_or_update
                git_repo(ctx, directory)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 91, in git_repo
                _update(ctx, git_repo)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 101, in _update
                init(ctx, git_repo)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 115, in init
                _error(ctx.name, cl, st.stderr)
        File "C:/users/administrator/_bazel_<user>/zflckzzj/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 181, in _error
                fail(<1 more arguments>)
error running 'git init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common' while working with @google_bazel_common:
java.io.IOException: ERROR: src/main/native/windows/process.cc(199): CreateProcessW("git" init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common): The system cannot find the file specified.
 (error: 2)
INFO: Elapsed time: 0.542s
INFO: 0 processes.

Is it Closure Compiler's fault?
Is it Bazelisk's fault?
Is it Bazel's fault?
The output of bazelisk version is:
Bazelisk version: v1.7.4
Build label: 2.2.0
Build target: bazel-out/x64_windows-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Mar 3 09:28:29 2020<PHONE_NUMBER>)
Build timestamp:<PHONE_NUMBER>
Build timestamp as int:<PHONE_NUMBER>

error running 'git init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common' while working with @google_bazel_common:
java.io.IOException: ERROR: src/main/native/windows/process.cc(199): CreateProcessW("git" init C:/users/administrator/_bazel_<user>/zflckzzj/external/google_bazel_common): The system cannot find the file specified.

This sounds like a setup issue. Do you have a working git binary installed?

I didn't know I needed that. Git is not mentioned as prerequisite in the build instructions.
It turns out that I also need MSYS2, which is also not mentioned as prerequisite.
I installed those tools and now I get the following error:
A:\Desktop\closure-compiler-20201102> bazelisk build //:compiler_unshaded_deploy.jar
WARNING: Running Bazel server needs to be killed, because the startup options are different.
Starting local Bazel server and connecting to it...
Loading:
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading:
Analyzing: target //:compiler_unshaded_deploy.jar (1 packages loaded)
Analyzing: target //:compiler_unshaded_deploy.jar (1 packages loaded, 0 targets configured)
Analyzing: target //:compiler_unshaded_deploy.jar (9 packages loaded, 11 targets configured)
Analyzing: target //:compiler_unshaded_deploy.jar (11 packages loaded, 18 targets configured)
Analyzing: target //:compiler_unshaded_deploy.jar (11 packages loaded, 18 targets configured)
Analyzing: target //:compiler_unshaded_deploy.jar (16 packages loaded, 249 targets configured)
Analyzing: target //:compiler_unshaded_deploy.jar (30 packages loaded, 375 targets configured)
INFO: Analyzed target //:compiler_unshaded_deploy.jar (51 packages loaded, 2196 targets configured).
INFO: Found 1 target...
INFO: Deleting stale sandbox base C:/users/administrator/_bazel_<user>/cy7rdti4/sandbox
[0 / 16] [Prepa] BazelWorkspaceStatusAction stable-status.txt
[4 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/code_generator.cc [for host]; 4s local ... (2 actions, 1 running)
[6 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_doc_comment.cc [for host]; 3s local ... (2 actions, 1 running)
[7 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_enum_field.cc [for host]; 5s local ... (2 actions running)
[9 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_message.cc [for host]; 4s local ... (2 actions running)
[10 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_message.cc [for host]; 11s local ... (2 actions running)
[10 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_message.cc [for host]; 20s local ... (2 actions running)
[12 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_extension_lite.cc [for host]; 2s local ... (2 actions running)
[15 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_file.cc [for host]; 4s local ... (2 actions running)
[18 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/csharp/csharp_wrapper_field.cc [for host]; 4s local
[22 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_map_field_lite.cc [for host]; 6s local
[26 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_message_field.cc [for host]; 6s local ... (2 actions running)
[32 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_string_field.cc [for host]; 1s local ... (2 actions running)
[37 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_generator.cc [for host]; 6s local ... (2 actions running)
[43 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/php/php_generator.cc [for host]; 8s local ... (2 actions running)
[50 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/csharp/csharp_message.cc [for host]; 8s local ... (2 actions running)
[58 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_file.cc [for host]; 8s local ... (2 actions running)
[64 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_helpers.cc [for host]; 9s local ... (2 actions running)
[71 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/cpp/cpp_service.cc [for host]; 3s local ... (2 actions running)
[84 / 143] Compiling external/com_google_protobuf/src/google/protobuf/compiler/java/java_name_resolver.cc [for host]; 1s local ... (2 actions running)
[116 / 196] Compiling external/com_google_protobuf/src/google/protobuf/util/internal/type_info.cc [for host]; 5s local ... (2 actions running)
[130 / 196] Compiling external/com_google_protobuf/src/google/protobuf/struct.pb.cc [for host]; 1s local ... (2 actions, 1 running)
[157 / 196] Compiling external/com_google_protobuf/src/google/protobuf/util/time_util.cc [for host]; 5s local ... (2 actions, 1 running)
ERROR: A:/desktop/closure-compiler-20201102/BUILD.bazel:151:1: Executing genrule //:externs_zip failed (Exit 127)
Target //:compiler_unshaded_deploy.jar failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 702.918s, Critical Path: 51.93s
INFO: 170 processes: 170 local.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

It says use  --verbose_failures near the end. So I did that and I got this:
A:\Desktop\closure-compiler-20201102> bazelisk build //:compiler_unshaded_deploy.jar --verbose_failures
Loading:
Loading: 0 packages loaded
Analyzing: target //:compiler_unshaded_deploy.jar (0 packages loaded, 0 targets configured)
INFO: Analyzed target //:compiler_unshaded_deploy.jar (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
[0 / 10] [Prepa] BazelWorkspaceStatusAction stable-status.txt
[1 / 25] Action external/bazel_tools/tools/jdk/platformclasspath.jar; 1s local ... (2 actions running)
ERROR: A:/desktop/closure-compiler-20201102/BUILD.bazel:151:1: Executing genrule //:externs_zip failed (Exit 127): bash.exe failed: error executing command
  cd C:/users/administrator/_bazel_<user>/cy7rdti4/execroot/com_google_javascript_jscomp
  SET PATH=C:\tools\msys64\usr\bin;C:\tools\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Users\Administrator\AppData\Local\bazelisk\downloads\bazelbuild\bazel-2.2.0-windows-x86_64\bin;C:\ProgramData\Oracle\Java\javapath;C:\Windows\system32;C:\Windows;C:\Windows\System32\WindowsPowerShell\v1.0\;A:\App files\Node.js v8.12.0\;A:\App files\Git\cmd
    SET RUNFILES_MANIFEST_ONLY=1
  C:/tools/msys64/usr/bin/bash.exe -c source external/bazel_tools/tools/genrule/genrule-setup.sh; cd externs && find . -name '*.js' | zip ../bazel-out/x64_windows-fastbuild/bin/externs.zip -@ &> /dev/null
Execution platform: @local_config_platform//:host
Target //:compiler_unshaded_deploy.jar failed to build
INFO: Elapsed time: 5.224s, Critical Path: 2.54s
INFO: 0 processes.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

It says that bash.exe failed: error executing command, but there are many commands being shown there. I'm clueless as to what specific command is failing.

I think the zip command is what is failing. Do you have a zip binary on
your system?
Taking a step back, what problem are you actually trying to solve here?

I found a linux-compatible zip.exe here: http://stahlworks.com/dev/index.php?tool=zipunzip
I added it to the PATH and now the build process completed successfully.
Where I work they use a custom version of Closure Compiler that was built from version 20190121.
There are several bugs in that version that have been fixed in these two years, so I needed to rebuild that custom Closure Compiler using the latest version as a base.
Bottom line, the missing prerequisites are:

Git
MSYS2
A zip command-line executable (compatible with the one in linux)

It will help others if you specify them in the build instructions.
Thanks for your help.

Good point, and thanks for researching the tooling requirements.

@Getfree i know it's been a while, but i'm having problems still with the same command. i did everything you mentioned (git, msys2, that zip tool, adding it to PATH etc) but i still get the same error
BUILD.bazel:186:8: Executing genrule //:externs_zip failed: (Exit 127): bash.exe failed: error executing command

do you remember doing anything else?

When I did the entire process back then, I wrote the instructions step by step in case I needed to do it again.
Here they are:

Download and uncompress the newest closure-compiler-20201102 file from https://github.com/google/closure-compiler/releases

Uncompress it to a folder path without spaces (bazelisk complains about it)

Download and install Java SDK (install just the SDK, not the source code or the JRE or anything else)

Set the JAVA_HOME environment variable to C:\Program Files\Java\jdk1.8.0_201

Download the latest bazelisk binary from https://github.com/bazelbuild/bazelisk/releases

rename it to "bazelisk.exe" and move it to the closure-compiler-20201102 folder

Download a portable Git binary from https://git-scm.com/download/win

Uncompress it to "A:\App files\Git"
Add "A:\App files\Git\cmd" to the PATH variable (Control Panel > User Accounts > Change my environment variables)

Download and install MSYS2 from https://www.msys2.org

Download zip.exe from http://stahlworks.com/dev/index.php?tool=zipunzip (direct link http://stahlworks.com/dev/zip.exe)

Add zip.exe's path to the PATH environment variable

Open a cmd window under closure-compiler-20201102 and run the command:
bazelisk build //:compiler_unshaded_deploy.jar

The command takes about 7 minutes the first time. And about 1 minute the second time on.

Copy the file "closure-compiler-20201102\bazel-bin\compiler_unshaded_deploy.jar" to wherever it's needed.

thanks a lot! did everything in your list but the externs_zip command still failed. found out why, it's really the find command. per default it takes the one from cmd which works completely different. i pointed it to the msys64 one within BUILD.bazel and now it works. i still have another issue when trying to build :all though (//:compiler_unshaded_deploy.jar works fine):
bazel-out/x64_windows-fastbuild/bin/compiler_lib_no_runtime_libs.javadoc.run_shell_0.sh: line 2: external/local_jdk/bin/javadoc: Argument list too long

other than that, not wanting to go too much into smalltalk, but did you manage to get the project into eclipse or vscode to debug it?

I remember I did open the project in vscode, but my debugging consisted of simple log lines to a text file.
i.e. I didn't use breakpoints, step by step or anything like that.


Failed to run config for dracula.nvim

I recently updated all my plugins for neovim and now I am getting this error whenver I start up neovim. I really have no idea what could be causing the issue.
Running NVIM v0.9.5
Failed to run `config` for dracula.nvim
vim/shared.lua:0: after the second argument: expected table, got nil
# stacktrace:
  - vim/shared.lua:0 _in_ **validate**
  - vim/shared.lua:0 _in_ **tbl_deep_extend**
  - /dracula.nvim/lua/dracula/init.lua:10 _in_ **setup**
  - lua/plugins.lua:105 _in_ **config**
  - lua/plugins.lua:14
  - init.lua:2

Here is the output from my :checkhealth command: https://gist.github.com/NeuroWinter/add3cfcb03abdc6b3e47445d1bdba330

Managed to get it running, cant remember exactly what I did, but after clearing up a lot of the things in my check health and updating plugins, it seems to have solved itself.


ci: temporary solution for testing bug

A temporary solution is to remove the coverage check.

Removing coverage check didn't help. Trying to add to pytest config param to ignore warning because of WandB lib:
============================== warnings summary ===============================
.venv\Lib\site-packages\wandb\sdk\launch\builder\build.py:11
  c:\Users\user\Projects\polony-counting\.venv\Lib\site-packages\wandb\sdk\launch\builder\build.py:11: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html


JRuby bridge for TimestampFormatter

Embulk provides org.embulk.spi.time.TimestampFormatter so that plugins (especially formatter and output plugins) can format timestamps easily and users can use the consistent configuration parameter to configure timestamp formats.
However, it's difficult to use TimestampFormatter in JRuby-based plugins because there're no convenient bridges.

We have no plans for expanding Ruby-based Embulk plugins. Closing this issue.


WalletStatus JSON encoding

As part of https://github.com/ergoplatform/oracle-core/issues/42 I found that WalletStatus needs the following serde field annotations:
pub struct WalletStatus {
    #[serde(rename = "isInitialized")]
    pub initialized: bool,
    #[serde(rename = "isUnlocked")]
    pub unlocked: bool,
    #[serde(rename = "changeAddress")]
    pub change_address: Option<P2PKAddressString>,
    #[serde(rename = "walletHeight")]
    pub height: BlockHeight,
    pub error: Option<String>,
}

as required by the node (openAPI reference: https://github.com/ergoplatform/ergo/blob/3fa0ed3d73bcc7d1e0130a347b182b8f5313f49e/src/main/resources/api/openapi.yaml#L1511)
I'll just wait for you to merge the update-ergo-lib-15 branch, then will apply the fix.

If you don't have any immediate plans for the update-ergo-lib-15 branch, I'd be happy to refactor this crate as well as oracle-pool to depend on ergo-lib version 16.
Also when you have time, could you please cut a new minor version for ergo-lib to incorporate https://github.com/ergoplatform/sigma-rust/pull/578?

If you don't have any immediate plans for the update-ergo-lib-15 branch, I'd be happy to refactor this crate as well as oracle-pool to depend on ergo-lib version 16.

Please do. I appreciate it!

Also when you have time, could you please cut a new minor version for ergo-lib to incorporate ergoplatform/sigma-rust#578?

Sure, will do. I'd like to include https://github.com/ergoplatform/sigma-rust/pull/577, which I'm wrapping up today.

If you don't have any immediate plans for the update-ergo-lib-15 branch, I'd be happy to refactor this crate as well as oracle-pool to depend on ergo-lib version 16.

Did you have a chance to work on it? If not, I'd be happy to take it back. :) I'm stuck in ergoplatform/oracle-core#61 on WalletStatus parsing.

Oh yes I can get onto it ASAP. https://github.com/ergoplatform/sigma-rust/pull/584 is just about done except for the "task chunking" thing I mentioned in the associated issue. Looks like this is more urgent for now, so can shift to it. Let me know what you think should be prioritised and I'll do it.

I don't want to pull you from way more complex https://github.com/ergoplatform/sigma-rust/pull/584 for this issue.
I can take care of this if you don't mind.

Ok sure, no problem. Thanks!


Update index.html; Add GetQuick.link to improve performance

Description
⚡  Faster subsequent page-loads by prefetching in-viewport links during idle time
https://github.com/GoogleChromeLabs/quicklink
Implementing Quicklink in sites can speed up navigations, by automatically prefetching in-viewport links during idle time. Different metrics can be improved as a result of this, the most common ones being Start Render and First Contentful Paint.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

I have read the CLA Document and I hereby sign the CLA


dotnet dev-certs --clean does not clean certs created by VisualStudio

Create a new web project with configured https
Boot the app (let it configure the certificate).
run dotnet dev-certs https --clean at command line
Re-boot app, cert is still valid.

(this same flow outside of VS results in the cert being revoked)
This means if you have your certs created by VisualStudio you need to manually go and revoke them.

Are you running behind IIS or Kestrel. The dev-certs tool is only for the certificates kestrel uses

Behind IIS. If the --clean shouldn't nuke certs behind IIS it should be explicit about what it nukes in its description (it says it nukes every cert in the world associated with localhost https)

It nukes the ones produced for ASP.NET Core, not any other localhost certificate on the machine that you might have.
I’m closing this as by design

It nukes the ones produced for ASP.NET Core, not any other localhost certificate on the machine that you might have.
I’m closing this as by design

@javiercn please fix the description then. Devs will see the VisualStudio experience as a shared experience with the command line. As reference here's the current description:

I’m failing to understand this. AFAIK the tool never says it cleans localhost certificates nor anything like that. This took only manipulates certificates that are marked with a specific OID. It’s not a general certificate management tool. I think your complain is that the tool is not explicit about the certificates it cleans? But I think your confusion can be caused by a lack of context.
All I’m trying to say is that you should not expect this tool to do anything for environments other than Kestrel.
(A similar thing would happen with fiddler or any other ingress like ngynx or similar)

All I’m trying to say is that you should not expect this tool to do anything for environments other than Kestrel.
I think your complain is that the tool is not explicit about the certificates it cleans? But I think your confusion can be caused by a lack of context.

Cleans all HTTPS development certificates from the machine.
You're right it doesn't say "localhost" but I interpreted HTTPS development certificates as one and the same. I misunderstood its capabilities based off of its description, I'm sure others will run into similar misunderstandings. We can't rely on people to have a significant amount of context in this area because this is now a perceived pre-requisite step to run our default templates with a valid cert.
There's probably a better modification but this would even be an improvement:
Cleans all HTTPS development certificates created by 'dotnet dev-certs https --trust'.

After deleting all localhost (asp.net core) certificates manually, everything started to work normally as described in the documention.
The state I had before resetting everything manually was:

localhost certificates already existed
couldn't be cleaned
a new certificate was generated each time I excuted the command "dotnet dev-certs https" even though a valid one existed

I am not sure, If the problems described below won't reappear tomorrow if i try the same again.
Before the above mentioned (good) results, I wrote the following:
This statement "There was an error trying to clean HTTPS development certificates on this machine." is not really accurate.
here are a few notes from what I experienced using dev-certs:

I had to navigate to certmgr.msc and manually remove the localhost certs generated by the dev-certs tool (from the personal certificates section)
The clean-command does not remove any pre-existing certificates
dev-certs https does not check if there is a valid certificate available for the localhost before generating a new one (not showing a warning either)
generating certificates multiple times in a row leads to having several localhost-certs which do not get cleaned

This should be fixed in the 2.2 preview3


[Request]: Converter Now

Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
Converter Now
Description
Converter NOW is an effective unit and currencies converter
Homepage
https://github.com/ferraridamiano/ConverterNOW
Download Link(s)
https://github.com/ferraridamiano/ConverterNOW/releases/download/v4.0.1/converternow-windows.msix
Some Indication of Popularity/Repute
261 github stars

Hi,
You can install it from my bucket by running the following commands:
scoop bucket add naderi https://github.com/naderi/scoop-bucket
scoop update *
scoop install converter-now


Adjust height to match editor height

See https://github.com/fundon/atom-minimap/issues/229

Travis failed but it appears to be something with react, not my patch.

Thanks for this PR :)


Clean imports

Removed unused imports as well as some declared but unused variables.

@robin-janssen this pull request was not merged into the main yet


Getting id's of drawn SVG line

There are multiple leader lines drawn between multiple divs and if a user wants to delete a single line or highlight a single line on clicking, how to track the Id of that line

Hi @udit9412, thank you for the comment.
Try this:
const
  line1 = new LeaderLine(elmA, elmB),
  elmLine1 = document.querySelector('body>.leader-line:last-of-type'),

  line2 = new LeaderLine(elmC, elmD),
  elmLine2 = document.querySelector('body>.leader-line:last-of-type');

Note that this is not supported by the library.

Thank you so much for the solution. So as per current suggestion I applied that to register an eventListner to trigger a function at call but again function was not triggered on clicking of the line
let element =document.querySelector('body>. leader-line:last-of-type').addEventListener("click", (event) {
alert(s(event.target.nodeName.toUpperCase() element );
console.log("Ciciked")
});

Your code has some problems.
For example, the variable element has nothing because addEventListener method returns nothing. And also, a function must be event => {} if you intended to write an arrow function.
And more...
Maybe you have to learn JavaScript and rewrite your code.
For example: https://jsfiddle.net/sbvnh30g/

Thanks for the reply!. Yeah I missed the syntax while writing code in GitHub while it was already an arrow function in the code. And with that particular line I removed variable declaration as it will never return anything but the point is the function was not getting triggered and after some time, while using dev tools, I noticed that "pointer-events" was set to none!important by default which was creating the issue. Now it's solved and thanks for the support

:smile:


Adding event_version to TaskExecutionEvent and TaskExecutionClosure

TL;DR
Adding an "event_version" field to the TaskExecutionEvent and TaskExecutionClosure protos to track updates in event reporting format. In the near term this will be used to indicate the updated subtask metadata reporting for map tasks.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
^^^
Tracking Issue
https://github.com/flyteorg/flyte/issues/2288
Follow-up issue
NA

@EngHabu I'm actually a bit confused, because in the accompanying admin PR it looks like we update the event version over the lifetime of a task execution which is what I thought PhaseVersion was originally intended for
@hamersaw mind explaining when the event version will change? or is this just hard-coded in propeller somewhere now?

Sorry to introduce the complexity. We are hardcoding the taskExecutionEventVersion in propeller just like the current nodeExecutionEventVersion.
I added the ability to update the taskExecutionEventVersion during execution as a minor defense in cases where propeller is updated (or downgraded ... shudders) mid-run. I think handling these cases correctly is extremely difficult, not sure if it's a rabbit hole we want to go down.

got it, the defensive case makes sense 👍


Set datadog hostname on elk, logs and bastion

It looks like datadog is considering bastion and bastion.openstack and
the others as seperate hosts because what is in the ansible inventory
does not match what datadog thinks it is talking to.
Hopefully if we force set the hostname these things will start being
correlated. And I'm not sure if they're being billed as seperate
entities or not.
Signed-off-by: Jamie Lennox<EMAIL_ADDRESS>

Prefer: https://github.com/BonnyCI/hoist/pull/367


Components do not complete loading... no obvious network problem

Describe the bug
I've waited a few minutes, and https://portal-prod.stage.hubmapconsortium.org/browse/dataset/4fc4e11da541a395a165016b7a3d5124 still looks like this. Usually the heatmap is the last to load, so it feels like something is wrong.
In the console:
waiting on 5: ["cells","molecules","raster","cell-sets","expression-matrix"]
waiting on 3: ["cells","expression-matrix","cell-sets"]
waiting on 1: ["raster"]
waiting on 2: ["cells","cell-sets"]
waiting on 1: ["expression-matrix"]
waiting on 3: ["cells","cell-sets","expression-matrix"]
cleared molecules; waiting on 4: ["cells","raster","cell-sets","expression-matrix"]
cleared neighborhoods; waiting on 4: ["cells","raster","cell-sets","expression-matrix"]
cleared expression-matrix; waiting on 3: ["cells","raster","cell-sets"]
cleared expression-matrix; waiting on 2: ["cells","cell-sets"]
cleared molecules; waiting on 1: ["raster"]
XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [tSNE_All_Features]/.zattrs
[HTTP/2 404 Not Found 215ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Mean-All-SubRegions] Expression/.zattrs
[HTTP/2 404 Not Found 227ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Mean] Expression/.zattrs
[HTTP/2 404 Not Found 181ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Shape-Vectors]/.zattrs
[HTTP/2 404 Not Found 318ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Texture]/.zattrs
[HTTP/2 404 Not Found 275ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Total] Expression/.zattrs
[HTTP/2 404 Not Found 262ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/obs/Cell K-Means [Covariance] Expression/.zattrs
[HTTP/2 404 Not Found 244ms]

XHRGEThttps://assets.hubmapconsortium.org/4fc4e11da541a395a165016b7a3d5124/anndata-zarr/reg1_stitched_expressions-anndata.zarr/X/.zattrs
[HTTP/2 404 Not Found 307ms]

WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. 11.c1ceccb1acc4cf9d034c.js:38
WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. 11.c1ceccb1acc4cf9d034c.js:38
WEBGL_debug_renderer_info is deprecated in Firefox and will be removed. Please use RENDERER. 11.c1ceccb1acc4cf9d034c.js:38
cleared expression-matrix; waiting on 3: ["cells","raster","cell-sets"]
cleared expression-matrix; waiting on 2: ["cells","cell-sets"]
cleared expression-matrix; waiting on 0: []
cleared cells; waiting on 2: ["raster","cell-sets"]
cleared cells; waiting on 1: ["cell-sets"]
cleared cells; waiting on 1: ["raster"]
cleared cells; waiting on 1: ["cell-sets"]
cleared cells; waiting on 2: ["cell-sets","expression-matrix"]
cleared cell-sets; waiting on 1: ["raster"]
cleared cell-sets; waiting on 0: []
cleared cell-sets; waiting on 1: ["expression-matrix"]
cleared expression-matrix; waiting on 0: []

To Reproduce
No reproducer: Reloading the page worked, but I feel like I've hit something like this before.
Expected behavior
All component finish loading, or there is an error message if they can't
Screenshots

Environment:

Release or git hash: portal-ui v0.33.1
Browser: FF
Browser version: 95.0

First impression is that FF web workers just can't handle the heat map.  That's the next thing on my to-do list is making that more efficient.


GFT: Filter CATS permits that start with PA or PB permit id

Fixes #872.
I also moved filtering by status from staging to intermediate model as it makes more sense to have it there.
Build here

Before filtering, the # of records with undesired permits is non-zero:

After filtering, the # of records in the intermediate table is zero as expected:


About Big Sur and preferences/videos disappearing

Please note that there is a bug currently in Big Sur betas with screen saver containers that will make you "lose" your settings and videos after install. They may (very likely) still be there though as there's a bit of a path mismatch currently.
If you are a terminal person, those are the paths in various versions of MacOS for the Container:
~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver <- Catalina, Big Sur beta 1/2
~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver.x86_64 <- Big Sur Beta 3 on x86
~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver.x86-64 <- Big Sur Beta 4/5 on x86
Inside that path, you can find Data/Library/Application Support/Aerial for where Aerial stores the videos. Please move that to whatever version you are running above.
So to recap full path of beta 4/5 : ~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver.x86-64/Data/Library/Application Support/Aerial
For preferences, look at Data/Library/Preferences/ByHost/com.JohnCoates.Aerial.{UUID}.plist
(where UUID is a random list of letters and numbers)
Again the correct location in beta4/5 is `~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver.x86-64/Data/Library/Preferences/ByHost/com.JohnCoates.Aerial.{UUID}.plist
If you are a finder person, it's a bit more complex. You may not see this if you didn't install beta3, but the new paths will look like this, instead of what you see in terminal :

Look for the most recent one that ends with x86_64. Yes they are named the same, and this is very different than the paths you see in Terminal.
As you've guessed, this is a macOS with the screen saver container mechanism in Big Sur beta. Please feel free to file a bug in macOS's Feedback Assistant to get more traction to the issue and hopefully get it fixed !
Please also be aware that I've seen the screensaver container lose the focus on playback, and pressing the keyboard will not exit/beep, and you'll be able to actually move your mouse pointer above the screensaver. As of right now I don't have a workaround for that issue in code, but should you find yourself in that situation, press cmd+option+shift+esc to force quit the container. This will launch another screensaver which you'll be able to exit.

So please be aware, this bug is finally fixed in beta9 🍾🎉 🥖
That means that after install, it will look like you've lost your videos/settings, you can move them back.
Old location : ~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver.x86-64/Data/Library/Application Support/Aerial
New location : ~/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application Support/Aerial


Benchmark for keyword argument sends

@noahgibbs we're adding this tiny new benchmark to assess the kwarg optimizations we're about to make.


feat(cli): add option to recuresively push dependencies

The "push" command now supports pushing the dependencies of a recipe to the target registry before
the recipe itself is pushed. This should make it easier to handle deploying recipes with complex
depenency trees between registries (ie: staging and production)

Yes I did test it (with the --dry-run tag 😅). Lets get this merged in!


Incompatible peer dependency to "@angular/common"

Angular 11.2.7 Migration failed
Error log :
Package "ng-thermal-print" has an incompatible peer dependency to "@angular/common" (requires "^8.0.0-rc.0 || ^8.0.0" (extended), would install "11.2.7").
Package "ng-thermal-print" has an incompatible peer dependency to "@angular/core" (requires "^8.0.0-rc.0 || ^8.0.0" (extended), would install "11.2.7").

Me too!


readme update: add note about requiring xcode 8

Current coverage is 82.22% (diff: 100%)

Merging #108 into master will not change coverage

@@             master       #108   diff @@
==========================================
  Files            27         27
  Lines          1907       1907
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1568       1568
  Misses          339        339
  Partials          0          0

Powered by Codecov. Last update 13f612f...115e866

@timbroder
Thanks for pointing that out ...
I've just fixed the Xcode 7 compatibility and released 1.4.2 which should work.


[T2A3][T13-A2]William Hawken

it looks like you have mixed a few things in one PR..accepted for this week, going forward submit one PR per activity


Setup 3 node cluster on multiple machines

Hey man!
Thanks for this repo! Was a big help in getting scylla running on my laptop.
Do you know what needs to be changed in the yaml files in order for ths setup to work on say two machines?
For example I started the seed node on one machine and want to start node2 and node3 on another machine. But nodes 2 and 3 are not showing up when I used nodetool to check the state of the cluster. I also changed the seeds parameter under seed_provider of the yaml file but that didnt seem to work. any ideas?
cheers!

Nice to hear from you! :)
Internally, Scylla uses a gossip protocol to make the cluster nodes aware of each other. This mechanism is not the same used to distribute data over the nodes in the cluster, but inherently as important.
This is from the Readme, indicating how a second node is started. Notice the --seeds argument?

docker run --name scylla-node2 --publish 9043:9042
--volume /Users/froran/scylla/mapped/node2:/var/lib/scylla
--volume /Users/froran/scylla/scylla-node2.yaml:/etc/scylla/scylla.yaml
--detach scylladb/scylla
--seeds="$(docker inspect --format='{{ .NetworkSettings.IPAddress }}' scylla-node1)"

This informs the second node to participate in the gossiping that eventually leads to transfer of data into this node and that this node will participate in cluster searches.
If you run Scylla on different physical machines, make sure they can talk with each other (no firewalls blocking the important ports), and then seed new nodes with the IP-address of (any) existing node in the cluster. In my example, I used 'docker inspect' to determine the IP-address of the first node, but it may be necessary to actually determine the IP-address of your nodes in order to correctly seed additional cluster nodes.
Hope this answer may be of any help.
// Frode

Hey man, thanks for that quick response!
Ja I played around with the seeds flag but to no avail. I think the ip was probably not correct. Is that the only parameter one has to change you think?
Looking at the yaml file there are quite a few ip address parameters one can fiddle around with. Like this here for example.
# seeds address(es) are mandatory!
seed_provider:
    # Addresses of hosts that are deemed contact points.
    # Scylla nodes use this list of hosts to find each other and learn
    # the topology of the ring.  You must change this if you are running
    # multiple nodes!
    - class_name: org.apache.cassandra.locator.SimpleSeedProvider
      parameters:
          # seeds is actually a comma-delimited list of addresses.
          # Ex: "<ip1>,<ip2>,<ip3>"
          - seeds: "<IP_ADDRESS>"```Ja communication between the machines is no issue.

What I did was change the seeds value to the ip of the host machine where the seed node was started.
I'll figure it out eventually:)
Have a good weekend!
P


vscode-dev-containers regression tests

I managed to convert and cleanup the initial test implementation after the extension refactoring.  Only odd thing about it is it does require the private repo but is in an OSS repo, so anyone cloning the repo wouldn't actually be able to use it. Started with #87 and built up from there.
It also adds in a few utilities to allow you to turn on trace logging and get config either from an env var or a json file -- we could move those into the core test utilities if you think they'd be broadly useful.  Here they're important since these are bulk tests primarily, but you want to be able to scope to one test for debugging of the tests themselves. The only other thing is I am duping the json schema here since cloining the distro would be overkill for that one file.
Thoughts?

One thing I hit with using package.json to grab the extension repo is that I got a cached copy of the repo since yarn.lock said 0.62.0 -- the latest for the repo is 0.63.0.  We may need to re-add it to ensure the latest is pulled or run yarn install --no-lockfile or something like that in CI.

We could download the schema from the public repo: https://github.com/microsoft/vscode/blob/master/extensions/configuration-editing/schemas/devContainer.schema.json
Maybe yarn upgrade ... also works on URLs (not tried yet).

I've made the suggested changes, but in thinking about it, it is pretty odd to put code in a public repo that depends on a private repo. Let's move this into a more logical location rather than here.