editor.renameOnType associates existing closing tag with new opening tag

VSCode Version:1.44 and 1.45.0-insider
OS Version: Windows 10

Steps to Reproduce:

set "editor.renameOnType": true,
("editor.formatOnType" can be true or false,
"html.mirrorCursorOnMatchingTag" can be true or false.
have an html tag present on a line of the editor, like :
text
begin typing a new instance of this same tag before the existing one :
<emtext
first bug : the existing closing tag gets selected !
close the new tag :
text
2nd bug : > is added after the existing closing tag :
text>

It also happens on different displayed lines, when there is no CR LF between the new tag and the existing one.

Does this issue occur when all extensions are disabled?: Yes

Actually, it happens always (when the same tag is already present somewhere below), except when one types a carriage return before typing the new opening tag.
The consequences are varied, depending on the existing tags below, on whether one types a tag nested inside an existing one etc.
Sometimes it seems to insert additional tags wrapping some parts of the code below...

Surprise : by setting editor.renameOnType : false,
the buggy behaviour above stops. The auto-closing of tags, if set to true, works, and the closing tag is matched.
I have set back "htmlmirrorCursorOnMatchingTag": true,
but it does not seem to have any influence.
What a strange and messy implementation !

<emtext

In this case, the editor would think you are writing a pair of <em       , and mark them as the same tag.

text
<emtext

I'm not sure why you have to strangely write a new tag from this position. Why not start writing  here? |text. This feature works best for common cases and does not guarantee always ending up with correct HTML.

2nd bug : > is added after the existing closing tag :

Yes, the editor told you that would be the case, it marked the two regions as red, whatever you enter in one region get duplicated in the other region.

Sorry, I really don't understand ! Where does that strange _text <em_text come from ? I wrote about <em text , worrying that it is impossible to type a new tag before an existing one.
Do you always type new code at the end of existing code, and never in the middle of it ? Do you never add a new  title before an existing one ?
Fortunately, as I wrote afterwards, by deactivating editor.renameOnType, the old behaviour of htmlmirrorCursorOnMatchingTag , which worked perfectly, comes back !

GitHub formatted them and I updated the comment.
Yes, I understand you want to add a
 into middle of text.
I believe most people would start typing
 here |text.
If you have to start typing it from here text, I suggest that you turn off this functionality. That's where people write attributes. I'm not sure why would you try to add a tag in that position to make your HTML invalid.

Sorry, that is not the case. in the image at the bottom of my first message, I simply wanted to type a new h2 tag before an existing one, and Code highlighted the existing closing tag together with my new opening tag, messing everything since there was the existing h2 opening tag inbetween. Obviously, Code closed automatically my new opening tag, since it was paired with the already existing closing tag...
The same happens when typing a new em tag before an existing one. Even several lines before !

I see. Here are the reproducible steps:

With content

Type <div before it so it becomes  which makes it

>

I didn't run into this issue myself since I would usually just type div and let emmet expand that to

. If you are accustomed to writing the < and >, I suggest that you turn this feature off "editor.renameOnType": false.

This rename on type is giving me a headache.
My bug here is probably really similar to this (let me know if I should open another one), but basically the matched tags ignore the fact that they are not at the "same nested level". Which means when I delete things, I just get random tags being deleted here and there and it is not pleasant.
video1.zip
video2.zip
See the video here. In both cases, I delete my lines with CTRL+X.
That second video is just painful, it went to delete something super far of my view.
If this is "the expected behavior", then this feature will be turned off since it's more an annoyance than anything else.

duplicate of https://github.com/microsoft/vscode/issues/98053


ANSI not working on Windows

Also having that as an integrated terminal inside the UI would be like a hundred times nicer.

Hi and thanks for reporting this issue!
I believe this issue has been resolved (or at least it's effects hidden), so I'm closing this issue.

Log messages are no longer printed to console
Lapce no longer opens a terminal window in the release builds
Lapce also has an integrated terminal, and I encourage you to try it!

Thank you!


vim: Get rid of Python 2 dependency

Motivation for this change
Python 2 is unsupported.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after) (607534224 → 649524120)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Several other distributions have already switched (e.g. Fedora and Debian).
One of the derivation's maintainers approved.
Seems to work fine.


WAF ACLs, IP rules, etc not shown (not created?) on AWS WAF Console

I followed the guide (https://docs.aws.amazon.com/solutions/latest/aws-waf-security-automations/deployment.html) which created two CF stacks successfully.
Since we use ALB not CF, I chose ALB.
But when I go to AWS WAF Console, I see no WAF resources shown. Even if I picked us-east-1, nothing shown.
If I go to EC2 console and pick ALB, it says "this ALB not WAF protected"

Hello @cscareerkaizen,
Thanks for reaching out. Are you using V2.3.2? This version supports AWS WAF Classic.
If you go to AWS WAF on console, by default it shows the WAFv2 UI. You will have to switch to WAF Classic (you can make the selection in the blue banner as shown in the picture)
You will be able to find your WAF security automation related resources under WAF Classic UI.

We are also working on a new version of WAF Security Automations to support WAFv2 and will be releasing it shortly.

I see it in WAF classic but not from ELB integrated services @rakshb

@cscareerkaizen to attach a WAF ruleset to your ALB go to "AWS Firewall Manager" -> "AWS WAF Classic" ->  Select "Web ACLs" (under left hand side menu items) -> Select your region at "Filter" -> Select your Web ACL -> Then select the tab "Rules" -> At the bottom you'll find a button "Add association" which lets you attach your Web ACL ruleset to a load balancer.

Thanks @peteroruba! Give us a thumbs up when you are able to set up the association successfully @cscareerkaizen

Yes, was able to. Thanks!

@rakshb Do you have any timeline on the WAFv2 support? I'm interested in implementing this solution, but would rather hold off until then. Thanks!!

@dclose20 We released WAF V3.0 last week with support for WAFv2 API. Check it out on https://aws.amazon.com/solutions/implementations/aws-waf-security-automations/


Add binding to Compress

The wrapper does not support the method Compress. The issue was reported in this question:
https://openfhe.discourse.group/t/determining-the-size-of-compressed-ciphertext/1761

Great. I did a bit of a hack which I will push to my fork. My python code now gives a more reasonable result.
$ ./batesste-openfhe.py
ciphertext     = 385.0 KiB
compciphertext = 129.0 KiB

@caesaretos take a look at my fix referenced above. Is it worth also adding a test case for this (or adding a check in an existing test).


Function Builder for Grammar

Hello,
I am going to use your library for rather large grammar of Relax NG Compact (https://www.oasis-open.org/committees/relax-ng/compact-20020607.html).
After some attempts to rewrite the original notation to the Covfefe notation as defined in https://github.com/palle-k/Covfefe/blob/master/BNF.md, I've came to the conclusion, it would be much better for me, to write a DSL.
I've completed a simple proof of concept implementation which supports all expressions with exception for ranges. The DSL I've designed looks like this:
    Grammar.build {
        %"person"   → %"name" .. %"space" .. (%"name" .. %"space")-? .. %"surname"
        %"name"     → ^"Mikolas"
                    | ^"Jan"
                    | ^"Lukas"
        %"surname"  → ^"Stuchlik"
                    | ^"Dvorak"
        %"space"    → ^" "
    }

translating to
name = ('Mikolas' | 'Jan' | 'Lukas');
space = ' ';
surname = ('Stuchlik' | 'Dvorak');
person = name, space, [name, space], surname;

I've had to deal with Swift's limitations on which characters are allowed as an operator.
I'm open to suggestions.
I see two main advantages in using Function Builders

some degree of static analysis is provided by the Swift compiler
the user of the library is able to write some additional checks, for example, whether there are any unused non-terminals or undefined non-terminals, warnings when a non-terminal has the same name as a terminal string etc.

Would you be interested in having a Builder as a part of the main library?
Have a nice day, Mikoláš

Hi @mikolasstuchlik! This proposal seems great.
Covfefe already has a built in DSL to express rules (or lists of rules). You can see it in action in BNFImporter.swift and EBNFImporter.swift. However, this existing DSL is somewhat messy and if we can achieve a more streamlined solution using function builders, that would be a great improvement.
If you want to fully implement this function builder based approach, I'd be happy to merge it. If you need help with anything, feel free to ask.
There are a few things that I saw that I think can be improved however or that I would require from an implementation:

The new DSL should not use special characters (like →). All characters used should be easy to type on a keyboard.

The new DSL should ideally be somewhat close to existing and established notations for context free grammars, like ABNF, EBNF or BNF.

The following features have to be present:

Repetitions, optional symbols and groups.
Nested expressions should work. For example it should be possible to express something like a, (b | c), d (a is followed by either b or c and then by d) or {[x], y} (one or multiple repetitions of optionally x and then y.
All public symbols (including operator implementations) have to be documented.
Everything should be tested to a reasonable level through unit tests. (100% code coverage is not necessary but all individual features should be tested).

The following features would be nice to have:

Unicode range expressions, specific and variable repetitions (ABNF).
Incremental alternatives (ABNF).

Hello,
I would like to provide an update to demonstrate this issue is still of an interest for me.
I’ve done some more reasearch into the Relax NG and unfortunately found out, that implementing Relax NG grammar will not be beneficial. Therefore have no need for parsing in general.
Having said that, the main reason for the delay is, that since I’ve posted this issue, Function Builders or rather Result Builders were moved into formal review. (There originating the name change.) At the same time, the Swift toolchain does not provide the same implementation of the feature on all platforms.
I will make a PR in this repo once result builders are accepted.


Update next Cartographer Open House date.

@wally-the-cartographer merge

Merge requested by authorized user gaschler. Merge queue now has a length of 1.


Deploying ARM template for Ingestion Client for Batch, it fails when SQL fields are used

Describe the bug
When Deploying Ingestion Client for Batch w/ SQL, it fails w/ the following error:
ServiceBus-20220523T130216Z/start_transcription_queue/StartTranscription
Microsoft.ServiceBus/namespaces/queues/authorizationRules
NotFound
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
"details": [
{
"code": "NotFound",
"message": "The requested resource StartTranscription does not exist."
}
]
}
To Reproduce
Steps to reproduce the behavior:

Deploying Custom Template
Use Defaults - only fill out required fields except SQL username & password.

Expected behavior
Success on Deployment of the ARM
Version of the Cognitive Services Speech SDK
N/A
Platform, Operating System, and Programming Language
N/A
Additional context
Works fine w/ only required fields filled in, when I added SQL portion it fails.

In Activity Log:
ListKeys
Write AuthorizationRules
Failed

Got it to work when text analytics was added


yarn install @sqltools/extension fails on: "Error installing vscode.d.ts: Error: Request returned status code: 404 while"

Hi @mtxr ,
Describe the bug
yarn install of plugin started to fails in version 0.21.8.
To Reproduce
We have a DOCKER image which builds the sqltools extension:
ARG VSCODE_SQLTOOLS_VERSION=0.21.8

RUN git clone --branch v${VSCODE_SQLTOOLS_VERSION} https://github.com/mtxr/vscode-sqltools.git &&  cd vscode-sqltools && git checkout -b vscode_sqltools && \
    # get dependencies
    yarn && git submodule update --init --recursive && yarn workspace @sqltools/formatter install && \
    # build
    npm install -g cross-env && ${NODE_PATH}/cross-env NODE_ENV=production yarn workspace @sqltools/formatter build && \
    ${NODE_PATH}/cross-env NODE_ENV=production yarn workspace @sqltools/extension run compile && cd .. && \

Since last week it started to fail on:
**error /source/vscode-sqltools/node_modules/@sqltools/extension: Command failed.**
Exit code: 1
Command: yarn run vscode-install
Arguments:
Directory: /source/vscode-sqltools/node_modules/@sqltools/extension
Output:
yarn run v1.22.5
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
$ /source/vscode-sqltools/node_modules/.bin/vscode-install
Detected VS Code engine version: ^1.36.0
**Error installing vscode.d.ts: Error: Request returned status code: 404**
Details: <!DOCTYPE html>

<meta charset="utf-8">
<title>Error</title>

Cannot GET /api/releases/stable

Could you please assist?

this has nothing to do with the extension.
If yout check /source/vscode-sqltools/node_modules/.bin/vscode-install file you will see it requests some microsoft servers and those are returning 404.
There's a long time I don't support the v0.21.x branches, so I'm not up to date with recent changes on vscode api for those versions.
As seen here https://github.com/microsoft/vscode/issues/62429 microsoft updated the url https://vscode-update.azurewebsites.net/api/releases/stable to https://update.code.visualstudio.com/api/releases/stable
That's what I've found so far.
Hope it helps, I'm closing this issue since it's unrelated and for a no longer supported version.
But I'm curious about the reasons to be using this old version, would you mind answering?


[BUG] Forecasting horizon in score method

Describe the bug
The following code fails when no forecasting horizon is provided to compute score.
To Reproduce
from sktime.forecasters import ExpSmoothingForecaster
from sktime.datasets import load_shampoo_sales

import pandas as pd

shampoo = load_shampoo_sales()

# split data into train, update and test
train = pd.Series([shampoo.iloc[0].iloc[:30]])
test = pd.Series([shampoo.iloc[0].iloc[30:]])

# simple exponential smoothing
m = ExpSmoothingForecaster()
m.fit(train)
m.score(test)

Expected behavior
Code should return a score
Additional context
Remove None as default fh
Versions

Darwin-18.6.0-x86_64-i386-64bit
Python 3.7.4 (default, Aug  5 2019, 21:56:28)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]
NumPy 1.17.2
SciPy 1.3.1
sktime 0.3.0

Thanks for reporting the bug! I believe this has been fixed already (see #126) but isn't in the latest release yet.

Hello @mloning,
I've already seen this PR. Tell me if I'm wrong, but it seems to me that the issue was fixed for fixand predict methods, but not score.
Also I left out than I ran my tests on the dev branch.

Yes, you're right, thanks, will fix this!

Yes, you're right, thanks! Will add this via the forecasting branch, unless you want to make a PR?

Thank you for proposing. I made a new PR.

Fixed by #168


Inline Editing inserts line breaks, colliding with diff

If a motion is edited using the inline editing mode, new line breaks are inserted at an earlier point than where they should be.

So this is a (wrong?) behavior of the CKEditor? Do you have an idea for a fix or what we maybe can change in the CKEditor config?

For once, I've written a patch that handles data like that, once it's in the database like that. I'll have a look if we can normalize that when saving the HTML after inline-editing.

Since we will eventually ditch CKeditor and rewrite the whole client, this won't hopefully be an issue anymore. If it persists, this issue should be reopened.


Minor Update: Scale Down Diagram for Mobile

Scale down this arrow diagram. It is used in the lesson 3 page, and probably others.

tentatively assigned to hunter


Utility meter is having a bad time

Figured I had enough time to mess around with finally configuring this today but seem to have hit a wall with the utility meters
The power and energy sensors are both working great but it has only generated some of the utility meter entities, all of which are forever stuck with a value of "unknown" and my logs get updated every few seconds with:
Logger: homeassistant.helpers.event
Source: components/utility_meter/sensor.py:176
First occurred: 7:40:51 PM (327 occurrences)
Last logged: 7:56:03 PM

Error while processing state change for sensor.electricity_used_server_rack_light_2_virtual
Error while processing state change for sensor.electricity_used_front_porch_light_1_virtual
Error while processing state change for sensor.electricity_used_back_patio_light_1_virtual
Error while processing state change for sensor.electricity_used_server_rack_light_1_virtual
Error while processing state change for sensor.electricity_used_kitchen_ceiling_light_2_virtual
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/event.py", line 269, in _async_state_change_dispatcher
    hass.async_run_hass_job(job, event)
  File "/usr/src/homeassistant/homeassistant/core.py", line 433, in async_run_hass_job
    hassjob.target(*args)
  File "/usr/src/homeassistant/homeassistant/components/utility_meter/sensor.py", line 176, in async_reading
    for sensor in self.hass.data[DATA_UTILITY][self._parent_meter][
KeyError: 'sensor.electricity_used_kitchen_ceiling_light_2_virtual_daily'

Running the current power calc master branch / home assistant core-2021.10.0

Was able to reproduce something. Had the same error. Have a potential fix is this MR #315. Now the error is gone.
Have set up a hourly meter, so will leave my HA running for a bit to see if it is calculated correctly.

Additional fixes for utility meters has been released in v0.10.1.
Could you check if this also solves your problems?

I was getting this error yesterday which I couldn't work out and am still getting after I updated

Looks like utility meter expects ATTR_LAST_PERIOD to be a float (numeric value), but it is actually None, which causes this error. I would suggest to delete all state entries for this utility meter from the database. DELETE FROM states WHERE entity_id="sensor.utility_meter_id";.

Could not restore state . Resetting utility_meter.Electricity Used Plug 15 Virtual yearly

Yes I get similar errors just after creating new utility meters. It should not really be an error imho because it just means there is no old state known yet. So this error will appear on all new utility meters, and will disappear when the meter calculated for the first time.
Actually this error message was introduced since I reported an issue with broken utility meters at Home Assistant core issue tracker https://github.com/home-assistant/core/issues/57001.
You could create a new issue on Home Assistant core.

Great!

Hey, I just run into this bug (ValueError: could not convert string to float: 'None').
I can confirm, from my understanding, that this is the problem:

Looks like utility meter expects ATTR_LAST_PERIOD to be a float (numeric value), but it is actually None, which causes this error. I would suggest to delete all state entries for this utility meter from the database. DELETE FROM states WHERE entity_id="sensor.utility_meter_id";.

Deleting all the states from the db wasn't enough for me, had to go into .storage/core.restore_state file and delete all the entries for the utility_meter entities.
In core.restore_state I could see that in fact the non working entities had "last_period": None, as complained in the logs, while after deleting them they were re-created with "last_period": 0, which does not raise any error as far as I can see.
I'll see tomorrow if the sensors works as expected, but I can confirm that are now being created, while before they didn't even show up in the list of entities.
Finally, I'm not using powercalc, this looks like an HA bug (2021.11.5).


Crash during export process : can only concatenate str (not "NoneType") to str_

Hello,
I use the last current version of OSXPHOTOS (0.68.4).
I export correctly many photos (around 50 000), and suddenly, export process crash with the following error :
Something went wrong and osxphotos encountered an error:
can only concatenate str (not "NoneType") to str
I cannot tell you if it occurs always on the same picture but it occurs after hours of processing.
Anyways it occurs always during export process.
I attach error log file for further analysis.
If you have an idea, I would be interested, because I can never finish my exporting process.
Anyway, thanks for you fantastic work with this script.....
Thanks to all,
Alban
osxphotos_crash.log

Hello. Thanks for your answer. Of course, I will come back later with the result.

Hello,
Here is the new log file. Not sure il will be more clear.
Thanks !
osxphotos_crash.log

Thanks for the additional data. Unfortunately that didn't give me the details I thought it would but I do see exactly where the problem is occurring. If you're able to run one more command to get additional details that would be helpful. Note that the output of this command may contain sensitive data such as location information so if you'd prefer, you can send it to me at<EMAIL_ADDRESS>rather than post here. The command will generate a file debug.txt which is what I need.
osxphotos debug-dump --dump photos --uuid 2841BC31-2C83-4343-BB6C-DE1B0F65B3C3 > debug.txt
The issue is caused because a photo has been edited but the universal type identifier (UTI) of the edited photo is an expected value. I'm trying to determine what value is in the database for this. OSXPhotos uses this value to know what extension to use for the edited image (this may be required in cases where the edited image is not on the local mac and must be downloaded from iCloud with --download-missing.)

So, debug.txt file, with your command line is nearly empty :
Opening database: /Volumes/DISQUE HDD/Photothèque.photoslibrary
Done; took 323.08 seconds
But, I tried the same command line with this UUID : 218D3B6A-A4B2-4088-9B30-2BFEF29490D6 (in my message too). And then it works. File joined.
debug.txt

Hello, just remove the specific picture  ( not important ) , and just trying to launch again process. Keep you in touch.

Using your additional data was able to figure out which UTI (edited Olympus RAW) was causing the issue and implemented a fix. Should be fixed in release 0.68.5.
@all-contributors please add @alban73  for bug, data

Thanks !!!


Mention API-M version in all the doc pages to avoid any confusions

Description:
When referring doc pages, it confuses the users as always it asks to download the latest version of API-M and the link directed to the latest released version.
For example, in the APIM CLI doc page, although the tool is relevant to API-M 2.5.0 version, the doc asks to download the latest version pointing to API-M 3.0 version.

In all the doc pages this download reference details should get changed. It's good to mention the exact API-M version always without saying the "latest".
Affected Product Version:
All the API-M versions doc pages
Related Issues:
https://github.com/wso2/product-apim-tooling/issues/176

Hi Team,
Can we please fix this issue ASAP in all our APIM doc pages for all the APIM versions? This causes issues as users download the latest APIM version instead of the compatible version.


MoreCompany Cosmetics are not loading in-game

Describe the bug
Using a clean R2 mod profile with just AdvancedCompany and its dependencies installed, MoreCompany's cosmetics are not loading.
To Reproduce
Steps to reproduce the behavior:

Launch Lethal Company with AdvancedCompany enabled.
Click "AdvancedCompany settings" on main menu and navigate to "Cosmetics". No cosmetics are loaded.
Host a lobby with the default AdvancedCompany settings and upon pressing Escape and "AdvancedCompany" in the menu and navigating to "Cosmetics", they are still not populated.

Expected behavior
To be able to use MoreCompany's cosmetics without having the MoreCompany modded loaded in the modlist.
Screenshots

Logfiles
Player.log
Add a list of all of your mods
BepInEx-BepInExPack-5.4.2100
Rune580-LethalCompany_InputUtils-0.6.0
PotatoePet-AdvancedCompany-1.0.130

Misunderstanding on my part!

You need to install MoreCompany if you want the standard MoreCompany cosmetics.


Image References?

Wondering if Image References (as per are working in Markdig?
This does not work for me:
![](configicons)

...

[configicons]: configicons.png "title for image"

I noticed #51 talks about image references, but not sure where that comes in. Could I just be missing an extension (although I have most enabled)?

The specs of Images in CommonMark expect that after paranthesis after a link (...) are an URL only. You need to use bracket [...] for the id, as you can verify this on babelmark3
![][configicons]

...

[configicons]: configicons.png "title for image"

Duh - sorry my bad :-) Thanks and it works great.
Good use case for this BTW: Embedding base64 encoded image content at the ends of the document.

Note that you can also use ![configicons] alone (it will just set the alttext to configicons)

Good use case for this BTW: Embedding base64 encoded image content at the ends of the document.

Indeed, good idea!


shaderObject: Mark the shader object layer as beta

CI Vulkan-ExtensionLayer build queued with queue ID 6819.

CI Vulkan-ExtensionLayer build # 505 running.

CI Vulkan-ExtensionLayer build # 505 passed.


Bumped sonobuoy to latest release

Latest is 0.55? https://github.com/vmware-tanzu/sonobuoy/releases/tag/v0.55.0


crypto is not defined

I see that in https://github.com/MikeMcl/bignumber.js/commit/4a80c3637245606279eda45e503a428b8f9b9793, you removed the var crypto = require('crypto').
In NodeJS I need that, otherwise it throws an error that crypto is not defined.

Yes, I moved the responsibility for providing the crypto object to the user:
global.crypto = require('crypto')

I will make this explicit in the documentation.

Added to the documentation in v8.0.0.
Thanks for the report.


Add Bleachbit

Bleachbit is open source system cleaner
They have a deb available from their website.
https://download.bleachbit.org/bleachbit_4.4.2-0_all_ubuntu2004.deb

I am wondering if this is needed (I know versions may go out of sync possibly with the latest released version and that may be a reason to add it) since Bleachbit is the Ubuntu repos
With different say Ubuntu bases having older versions, this may be a good idea to add to get the latest version


Document container user/group

Due to the default container user being non-root, permissions of mounted
files must be adjusted when running with Docker.
Resolves #72

Thanks for the update.


The tck has an unsatisifed dependnecy on reactive-streams-examples

ReactiveStreamsArquillianTck places the package org.reactivestreams.tck and it's subpackages into the test war. That will create a dependency on reactive-streams-examples.
For example org.reactivestreams.tck.flow.support.HelperPublisher imports org.reactivestreams.example.unicast.AsyncIterablePublisher

Thanks, in my own testing, I was adding the MicroProfile Reactive Streams Operators implementation dynamically using Arquillian (since I didn't have a container that supported it out of the box), and had an archive appender with this line:
.addPackages(true, org.reactivestreams.Publisher.class.getPackage())

Which would have caused the recursive adding of the reactive-streams-examples package. Are you able to work around to verify whether there are any other dependencies that are missing?


Only client code, no server?

This is only the source of the client, not the server. It in no way proves that you are not using the data collected from the app in malicious or unintended ways.
In order to solve this I would like to propose that the server source code be made open as well. This would allow the core of the service to be audited by security professionals and would improve user trust.

My bad didn't see https://github.com/cds-snc/covid-alert-server

You can also see our infrastructure code here: https://github.com/cds-snc/covid-alert-server-staging-terraform


Supply Mule does not work with a pure warehouse (without production modules)

Supply Mule does not work with a pure warehouse (without production modules)
The following situation:
I wanted to fill my warehouse by the surrounding NPC stations. But this is not possible.
These are my settings:
Supply Mule:
Home Station: Warehouse
Serve Source Only: activated
Everything below enabled, except "Allow Build Storage"
No goods selected.
The warehouse has no production modules.
Result: Search for trade offers.
I thought it was due to the update to 1.6.4. So I installed the old version again. But the same result.
I still have a shipyard in this sector. This shipyard is supplied immediately, although I have activated "Serve Source Only". This is ignored.The warehouse is completely ignored. Buy orders in the warehouse are available.
I have built a production module for testing on another warehouse in another sector. This works immediately.
But as soon as I ONLY have a warehouse without production modules, no trade orders are found.
As it looks like Supply Mule does not work with a
pure warehouse. But it would have to be.

Does the warehouse have a manager and significant budget?

Yes.

Ah sorry, forgot one other thing, on a warehouse you need something to add wares as something they actually are looking to buy. They don't just look to buy everything by default. One way is a station mule with a factory as the source and the warehouse as target, with "make target warehouse" checked. I think there's also a way to manually add wares through either logical overview or by manually making a trade order (then you can give the order back to the manager).
Basically you need the wares to show up in logical overview for any orders to be created by the manager. There used to be a big where wares with 0 storage NEVER showed up in logical overview; not sure if that's fixed.

also worth mentioning is once the station mule has added the wares to the warehouse, he can be re-assigned.
Basically he will take everything from logical overview at the source, and add it to logical overview on the target, when "make target warehouse" is checked. After that, he doesn't need to be a station mule anymore. It's a convenience (in fact when the author originally wrote it, I think it was the only way to add tradewares to a station with no production)

Ok, all the goods to be refilled are available in the warehouse at a small quantity. I'll test this immediately with station mule.

Perhaps this is the cause.

If it doesn't work, please post screenshots of the logical overview of the warehouse, the "trade offers" menu showing buy orders, and the supply mule options on the ship's order tab.

(also, double check your trade rules)

unfortunately does not work.
No Trade Rules active.
Supply Mule shows me the goods from the shipyard in the sector and not from the warehouse.

Get me those screenshots if you can.
Also, do you know how to turn debug on? I could use the debug log for the supply mule assigned to the warehouse.

I have activated station mule:
Source: PHQ
Target: Warehouse
everything unchecked except Make Target Warehouse
Does a station mule trade have to be completed first or is one-time activation sufficient?
Debug ? how do I activate it ? In the game menu settings?
Screenes, it takes time.

I don't think the trade has to be completed, but it'd be good to let him run long enough to make a trade or get stuck in searching for trades. If you have small amounts of goods in the warehouse then that should be sufficient.
The first thing to debug is why no trades are being found for the warehouse; the second is to figure out what's going on with the "Serve source only" that you're seeing. I'll probably need the debug log for that.
To turn debug on, I use this script to launch the game:
https://gist.github.com/MattMcFarland/4c2f5cdd4657e91239cf7285b5d3b726
Make sure to edit the line in the comment:
start "" %X4_EXE_PATH% -showfps -debug all -logfile %LOG_FILE_NAME% -scriptlogfiles <---- %SCRIPT_LOG_FILE_NAME%
Then, when you launch the game, there will be log files created in:
Documents\Egosoft\X4<number>\
And mule specific logs at
Documents\Egosoft\X4<number>\logs\mulesextended
In that second folder will be a file for each mule. After launching with debug on, delete the order and restart it, then send that file. I need to see what trades the mule is finding to figure out where to go from here.

Here is the log :
ScriptStart
Ship: Sonra Verteidiger (OVS-652) - 0x51abe
Entity (this): 0x51ad3
Supply Mule Settings:
Home: Argon Prime Handelsstation I (THU-676)
assignHome: 0
maxDist: 30
dedicatedServe: 1
allowPlayerSuppliers: 1
allowAiSuppliers: 1
allowBuildstorage: 0
allowResources: 1
allowIntermediates: 1
allowTradewares: 1
lockWares: 0
specialWareBasket: []
maxTrades: 5
playerBuyMod: 100
Serving Station or Ship: Argon Prime Handelsstation I
Serving Sector: Argon Prime
Serving Factions: [faction.player]
Current priority is to supply "stationOrShip" by buying "resources" from "player"
Current priority is to supply "stationOrShip" by buying "resources" from "ai"
Current priority is to supply "stationOrShip" by buying "intermediates" from "player"
Current priority is to supply "stationOrShip" by buying "intermediates" from "ai"
Current priority is to supply "stationOrShip" by buying "tradewares" from "player"
Current priority is to supply "stationOrShip" by buying "tradewares" from "ai"
Current priority is to supply "sector" by buying "resources" from "player"
----- needs (8):
Argon Prime Schiffswerft I (EJJ-566) wants to buy 1331 Elektronikkomponenten for 131800 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 4551 Energiezellen for 2200 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 662 Feldspulen for 57600 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 315 Nahrungsrationen for 2900 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 219 Hüllenteile for 27200 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 188 Medikamente for 8900 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 402 Schildkomponenten for 26400 (1)
Argon Prime Schiffswerft I (EJJ-566) wants to buy 2233 Geschützkomp. for 38300 (1)
----- supply offers (4):
Profitabler Handel I Hauptquartier (XOD-708) wants to sell 2971 Feldspulen for 43598 (0.14622)
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to sell 125000 Energiezellen for 1000 (-1)
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to sell 1133 Feldspulen for 24700 (-1)
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to sell 12500 Schildkomponenten for 11300 (-1)
ship capacity: 54000
Occupied Cargo: 0
----- trade offer comparisons
Energiezellen target desired amount 136848 supply amount: 54000 ship can hold: 54000 amount will be: 54000 need unitprice: 2200 supp unitprice: 1000 faction buy modifier: 100 profit: 648.000,00 Cr
Feldspulen target desired amount 19860 supply amount: 2971 ship can hold: 3600 amount will be: 2971 need unitprice: 57600 supp unitprice: 43598 faction buy modifier: 100 profit: 504.072,00 Cr
Feldspulen target desired amount 19860 supply amount: 1133 ship can hold: 3600 amount will be: 1133 need unitprice: 57600 supp unitprice: 24700 faction buy modifier: 100 profit: 1.184.400,00 Cr
Schildkomponenten target desired amount 12110 supply amount: 5400 ship can hold: 5400 amount will be: 5400 need unitprice: 26400 supp unitprice: 11300 faction buy modifier: 100 profit: 815.400,00 Cr
Suggested Trade is: Buy 1133 Feldspulen from Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) and sell to Argon Prime Schiffswerft I (EJJ-566) with 1.184.400,00 Cr of profit.
buying 1133 Feldspulen from Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) at 247 Cr  to sell to Argon Prime Schiffswerft I (EJJ-566) at 576 Cr for a profit of
Occupied Cargo: 16995
----- trade offer comparisons
Energiezellen target desired amount 136848 supply amount: 54000 ship can hold: 37005 amount will be: 37005 need unitprice: 2200 supp unitprice: 1000 faction buy modifier: 100 profit: 444.060,00 Cr

Not sure what's going on with "Serve source only" yet but right away it looks like it's not finding any "needs" (i.e. buy orders) for the station you've assigned it to. They're all for the other station.

If we can't figure out any reason why the warehouse doesn't have buy orders, I'll have to try to see if I can find a way to reproduce. That would have to wait a few hours.

ok, in the warehouse buy offers are created.
When I use the other warehouse, where I have added a production module for testing, it works immediately. But as soon as there is no production module, it doesn't work.

if it helps, I can also send you the log of it.

I have a whole bunch of supply mules on a warehouse with no production modules and they're working fine.
Hoe much money does the warehouse have? How many buy orders are there?

100 million cr
14 buy offers

Ok, that's plenty.
I think you have found a bug, we will have to dig in and look for it later. Sorry for the trouble.

ok, I guess so.
Let's hope it's as easy to find as the bug yesterday.

Hey morgenrot 68,
could you send me a savefile? That would speed stuff up considerably for me.
You can upload it here, or (more privately) send it to me via discord (Galaxy-Spam#1117).l

Here is the log of the warehouse with production:
ScriptStart
Ship: Sonra Verteidiger (OVS-652) - 0x51abe
Entity (this): 0x51ad3
Supply Mule Settings:
Home: Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932)
assignHome: 0
maxDist: 30
dedicatedServe: 1
allowPlayerSuppliers: 1
allowAiSuppliers: 1
allowBuildstorage: 0
allowResources: 1
allowIntermediates: 1
allowTradewares: 1
lockWares: 0
specialWareBasket: []
maxTrades: 5
playerBuyMod: 100
Serving Station or Ship: Wiedergutmachung des Kardinals Hüllenteilefabrik III
Serving Sector: Wiedergutmachung des Kardinals
Serving Factions: [faction.player]
Current priority is to supply "stationOrShip" by buying "resources" from "player"
----- needs (2):
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to buy 3886 Graphen for 23300 (1)
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to buy 18750 Veredelte Metalle for 18435 (0.616102)
----- supply offers (2):
Argon Prime Handelsstation I (THU-676) wants to sell 421 Graphen for 18466 (0.278507)
Argon Prime Handelsstation I (THU-676) wants to sell 876 Veredelte Metalle for 18437 (0.616441)
ship capacity: 54000
Occupied Cargo: 0
----- trade offer comparisons
Veredelte Metalle target desired amount 18750 supply amount: 876 ship can hold: 3857 amount will be: 876 need unitprice: 18435 supp unitprice: 18437 faction buy modifier: 100 profit: -77,14 Cr
no valid trade found
Current priority is to supply "stationOrShip" by buying "resources" from "ai"
----- needs (2):
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to buy 3886 Graphen for 23300 (1)
Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) wants to buy 18750 Veredelte Metalle for 18435 (0.616102)
----- supply offers (33):
HAT Erzraffinerie I (RIV-709) wants to sell 409 Veredelte Metalle for 20479 (0.962542)
TEL Komplex für Veredelte Güter I (FYY-208) wants to sell 3987 Graphen for 18468 (0.278806)
PAR High-Tech-Fabrik I (XVW-071) wants to sell 272 Graphen for 20694 (0.611045)
HOP Schiffstechnologie-Fabrik II (BGR-049) wants to sell 8310 Veredelte Metalle for 13297 (-0.254746)
HOP High-Tech-Fabrik VI (XOY-912) wants to sell 4055 Graphen for 17917 (0.196567)
HOP High-Tech-Fabrik II (HTY-640) wants to sell 8130 Veredelte Metalle for 12983 (-0.307966)
ANT High-Tech-Fabrik I (CPV-192) wants to sell 2980 Veredelte Metalle for 15875 (0.182203)
ANT High-Tech-Fabrik VII (LOF-954) wants to sell 2487 Veredelte Metalle for 15470 (0.113559)
ANT Graphen-Raffinerie I (OXW-527) wants to sell 8477 Graphen for 17708 (0.165373)
ARG Komplex für Veredelte Güter I (XFY-717) wants to sell 830 Graphen for 22743 (0.916866)
ANT High-Tech-Fabrik II (RWB-259) wants to sell 115 Graphen for 14613 (-0.301061)
ANT Erzraffinerie I (ORR-062) wants to sell 17071 Veredelte Metalle for 14710 (-0.0152543)
ANT High-Tech-Fabrik IV (BQF-773) wants to sell 1372 Graphen for 18364 (0.263284)
TEL High-Tech-Fabrik II (NEZ-312) wants to sell 2622 Graphen for 17946 (0.200896)
HOP Graphen-Raffinerie I (EBU-523) wants to sell 5678 Graphen for 18529 (0.28791)
HOP Erzraffinerie III (NSB-130) wants to sell 16163 Veredelte Metalle for 13113 (-0.285932)
HOP Erzraffinerie I (XSS-131) wants to sell 20441 Veredelte Metalle for 13052 (-0.296271)
HOP Graphen-Raffinerie II (ZGS-360) wants to sell 6687 Graphen for 19389 (0.416269)
FRF High-Tech-Fabrik I (IVC-652) wants to sell 8010 Veredelte Metalle for 15383 (0.0988136)
ARG High-Tech-Fabrik I (DIY-733) wants to sell 65 Graphen for 18041 (0.215075)
HOP High-Tech-Fabrik II (JOH-915) wants to sell 4499 Graphen for 19097 (0.372687)
HOP Erzraffinerie I (PMB-431) wants to sell 1832 Veredelte Metalle for 18284 (0.590508)
HOP Erzraffinerie II (ERE-214) wants to sell 156 Veredelte Metalle for 20642 (0.990169)
HOP Erzraffinerie III (RGY-084) wants to sell 7456 Veredelte Metalle for 13749 (-0.178136)
PAR Erzraffinerie I (JBN-777) wants to sell 10648 Veredelte Metalle for 16476 (0.284068)
HOP Erzraffinerie I (SED-914) wants to sell 13265 Veredelte Metalle for 14838 (0.00644068)
ARG Komplex für Veredelte Güter I (RJZ-209) wants to sell 5720 Graphen for 15990 (-0.0924242)
ARG Graphen-Raffinerie I (MUC-570) wants to sell 3355 Graphen for 19353 (0.410896)
ARG Erzraffinerie I (VQN-599) wants to sell 10303 Veredelte Metalle for 16727 (0.32661)
ARG High-Tech-Fabrik I (EAS-316) wants to sell 3575 Graphen for 17710 (0.165672)
ARG Erzraffinerie I (QLV-038) wants to sell 13530 Veredelte Metalle for 16457 (0.280847)
HAT Komplex für Veredelte Güter I (ODW-600) wants to sell 6893 Veredelte Metalle for 17383 (0.437797)
ZYA Erzraffinerie II (KUC-061) wants to sell 4996 Veredelte Metalle for 16771 (0.334068)
ship capacity: 54000
Occupied Cargo: 0
----- trade offer comparisons
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 18468 faction buy modifier: 100 profit: 130.464,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 17917 faction buy modifier: 100 profit: 145.341,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 17708 faction buy modifier: 100 profit: 150.984,00 Cr
Graphen target desired amount 3886 supply amount: 830 ship can hold: 2700 amount will be: 830 need unitprice: 23300 supp unitprice: 22743 faction buy modifier: 100 profit: 15.039,00 Cr
Graphen target desired amount 3886 supply amount: 1372 ship can hold: 2700 amount will be: 1372 need unitprice: 23300 supp unitprice: 18364 faction buy modifier: 100 profit: 133.272,00 Cr
Graphen target desired amount 3886 supply amount: 2622 ship can hold: 2700 amount will be: 2622 need unitprice: 23300 supp unitprice: 17946 faction buy modifier: 100 profit: 144.558,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 18529 faction buy modifier: 100 profit: 128.817,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 19389 faction buy modifier: 100 profit: 105.597,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 19097 faction buy modifier: 100 profit: 113.481,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 15990 faction buy modifier: 100 profit: 197.370,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 19353 faction buy modifier: 100 profit: 106.569,00 Cr
Graphen target desired amount 3886 supply amount: 2700 ship can hold: 2700 amount will be: 2700 need unitprice: 23300 supp unitprice: 17710 faction buy modifier: 100 profit: 150.930,00 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 13297 faction buy modifier: 100 profit: 198.172,66 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 12983 faction buy modifier: 100 profit: 210.283,64 Cr
Veredelte Metalle target desired amount 18750 supply amount: 2980 ship can hold: 3857 amount will be: 2980 need unitprice: 18435 supp unitprice: 15875 faction buy modifier: 100 profit: 98.739,20 Cr
Veredelte Metalle target desired amount 18750 supply amount: 2487 ship can hold: 3857 amount will be: 2487 need unitprice: 18435 supp unitprice: 15470 faction buy modifier: 100 profit: 114.360,05 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 15008 faction buy modifier: 100 profit: 132.179,39 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 13113 faction buy modifier: 100 profit: 205.269,54 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 13052 faction buy modifier: 100 profit: 207.622,31 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 15383 faction buy modifier: 100 profit: 117.715,64 Cr
Veredelte Metalle target desired amount 18750 supply amount: 1832 ship can hold: 3857 amount will be: 1832 need unitprice: 18435 supp unitprice: 18284 faction buy modifier: 100 profit: 5.824,07 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 13749 faction buy modifier: 100 profit: 180.739,02 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 16476 faction buy modifier: 100 profit: 75.558,63 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 14838 faction buy modifier: 100 profit: 138.736,29 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 16727 faction buy modifier: 100 profit: 65.877,56 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 16457 faction buy modifier: 100 profit: 76.291,46 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 17383 faction buy modifier: 100 profit: 40.575,64 Cr
Veredelte Metalle target desired amount 18750 supply amount: 3857 ship can hold: 3857 amount will be: 3857 need unitprice: 18435 supp unitprice: 16771 faction buy modifier: 100 profit: 64.180,48 Cr
Suggested Trade is: Buy 3857 Veredelte Metalle from HOP High-Tech-Fabrik II (HTY-640) and sell to Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) with 210.283,64 Cr of profit.
buying 3857 Veredelte Metalle from HOP High-Tech-Fabrik II (HTY-640) at 129 Cr  to sell to Wiedergutmachung des Kardinals Hüllenteilefabrik III (WKW-932) at 184 Cr for a profit of
Occupied Cargo: 53998
Cargo Full, skip to end
******* went to end

oh, sorry, red to late.

yes, i can do that, but i have a lot of other mods installed Is that useful?

I dont mind installing them, might even reveal other issues.
Just Zip the whole modfolder as well. Unless its several GBs it should be fine.

i could try to reproduce it in a mod free installation. But then I would have to build warehouses first. In the save I am just at the beginning, without much credits and ships. So this may take some time.

mod folder is 3.3 gb

For me thats fine, if you have the bandwidth to upload it somewhere

3.3 gb. hmmm, difficult.
i try to send a save from the mod free installation. But that will take some time. I will not be able to do that today. I have to create the infrastructure in the game. Maybe you can have a look at the code until then.

You could take a shortcut with the cheat menu. Anyway, let me first take a look then, no need to go though all this trouble yet.

ok, cheat menu is installed. but then i don't have a mod free version. ok, this is what i do.

ok, i think i was able to reproduce the part with no tradeoffers found.

I have now tested it on a clean installation, it doesn't work there either, so it really should be a bug.

I found the bug, it should be an easy fix. I thought i fixed that a couple of releases ago, but it seems it sneaked back in...

But I am glad that it is not a big deal.

Did we have a merge issue that caused it to get back in?

I'm not sure, dev branch looks fine, could have been some merge issue back in the rework branch. Pushing update now.

Should be fixed in with the next update.


feat: Removed 'default-value' workaround for secrets that was originally needed to be PSRule compatible

Description
Removed 'default-value' workaround for secrets that was originally needed to be PSRule compatible
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Hey @AlexanderSehr ,
Firstly, thanks for your work on this PR!
We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.
Changes to CI That Have Been Made That You Need To Take Action On

https://github.com/Azure/bicep-registry-modules/pull/3745

Adds WAF Security PSRule Checks using this custom baseline of rules (/avm/utilities/pipelines/staticValidation/psrule/.ps-rule/cb-waf-security.Rule.yaml)
Action Required By You:

Ingest/pull-in these changes into your PR branch and re-run your tests to ensure they pass

If any issues with the rules and you think it should apply, please ping/reach out to the core team

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams
Thanks
Jack (AVM Core Team)


New Terminal Options/Selector

Terminal: Create New Terminal should show the option to Terminal: Create New Terminal (In Active Workspace).
For multi-root workspaces: You can configure terminal.integrated.cwd in the workspace settings and open this location with Terminal: Create New Terminal (In Active Workspace) but the default (keybound) action only selects between the different root folders.
Showing (active workspace) as selection option saves a keybind and should be the most common option anyway. (At least if terminal.integrated.cwdis set)

Just add a keybinding for workbench.action.terminal.newInActiveWorkspace

This is not a Solution.  This is no Question.


test: add cypress config and tests [TECH-464]

Included in this PR:

cypress configuration based on current DHIS2 convention (cli-utils-cypress initialized the configuration)
tests for viewing dashboard (can be run against actual DHIS2 instance or stubbed fixtures - useful for CI)
tests for creating and deleting dashboard (can only be run against an actual DHIS2 instance)
fixtures for non-mutating tests (viewing dashboard)
github action to run non-mutating tests on CI when creating and updating PRs, and on push to master
README updated with info on how to set up and run the tests
linting forced a function name change for a deprecated react lifecycle method (componentWillReceiveProps to UNSAFE_componentWillReceiveProps). Doesn't affect functionality.

This PR in the first step in building e2e test coverage. I expect that the tests will get reorganized into different files/folders as the test suite grows.
You can see the test run on the Cypress dashboard for dashboards-app

I'm not too familiar with the Cucumber syntax, but generally I think the steps should be named in a way that they only contain what the name implies. e.g.
 Then('the dashboard displays in edit mode', () => {
 cy.get('[data-test="dhis2-dashboard-dashboard-title-input"]').should( 'exist' )
 cy.location().should(loc => { expect(getRouteFromHash(loc.hash)).to.eq(ROUTE_EDIT) })
 })
are really a two-in-one, that both checks that the item displays and that the url is correct. Preferably I'd split that in to separate steps (or rename the one step to make it more apparent that two things are checked). But this could also caused by my lack of experience in Cucumber... 🤷♂

I guess I look at it based on this "best practice":  https://docs.cypress.io/guides/references/best-practices.html#Creating-“tiny”-tests-with-a-single-assertion
Suppose a tester or product person is writing the test feature file (which is the idea, though it probably never will happen). They would not break down each assertion (url is correct, title is correct, the first item's vis is correct) into separate clauses in the Gherkin sentence. They just want it checked that "the right page with the right information is showing"


Add Annotator for Clinical Data (ACD) connect route

This PR addresses issue #73
There are two primary routes included:

direct:fhir-r4-to-acd
direct:acd-analyze
Per our slack conversation, I omitted the Kafka consumer route that fed route #1 above.
I cleaned up the code since our review last week and added unit tests.
I look forward to your feedback.
Thanks in advance

My apologies - got a little tangled up on the commits for this one.
Closing and reopening a cleaner PR


"Inline temporary variable" quickfix

Suggestion
🔍 Search Terms

Quickfix, quick fix
Inline temporary variable, inline variable, temporary variable

✅ Viability Checklist

My suggestion meets these guidelines:

[ ✔ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[ ✔ ] This wouldn't change the runtime behavior of existing JavaScript code
[ ✔ ] This could be implemented without emitting different JS based on the types of the expressions
[ ✔ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[ ✔ ] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
C# has a nice quickfix called "inline temporary variable":

I propose adding an equivalent quickfix to TypeScript.
📃 Motivating Example
Developers frequently define variables and then only use them in one place. Inlining such variables can make the code more succinct and readable. As with all quickfixes, this quickfix would simply be a convenient shortcut for what you can already do by hand.
For example, the quickfix would transform this code:
const message = 'Failed to activate foobars.'
throw new Error(message)

into
throw new Error('Failed to activate foobars.')

💻 Use Cases

Automate the process of inlining temporary variables that are only used once (in both JavaScript and TypeScript code)
(???) Automate the process of inlining temporary variables that are used more than once. The C# quickfix does support this but I'm not sure if it's a useful feature, since inlining a variable that is used multiple times results in duplication.

We would need to define exactly which variable declarations are eligible for this quickfix. I'm not sure since I'm not a compiler person.

Duplicate of #18459


Removed chained method alignment from formatter

See the first method for an alternative layout, with aligned chained methods (though method extraction might not always be applicable).
See second method for new (old) formatting, after this PR.

Current coverage is 97.03% (diff: 100%)

Merging #1520 into master will decrease coverage by <.01%

@@             master      #1520   diff @@
==========================================
  Files            87         87
  Lines         10541      10541
  Methods           0          0
  Messages          0          0
  Branches       1798       1798
==========================================
- Hits          10229      10228     -1
  Misses          183        183
- Partials        129        130     +1

Powered by Codecov. Last update 252964c...5f6827f

Thank you Lorinc!


Directory metadata analysis progress bar

Since the runtime of the directory analysis tool is rather long, the hope is to have a progress bar to estimate how long the program will run for
This is currently implemented in directory.py as a function of the total number of files. This is an accurate measure because the program processes files in tandem and each file takes approximately the same amount of time to process
However, it is time-consuming to count the number of files in a directory, especially for one on the scale of terabytes. Therefore, it is necessary to somehow estimate the total number of files
I have tested various Python libraries as well as cmd scripts. The current os.walk implementation is already very efficient and the only improvement I observed was from the robocopy cmd command which is roughly 20% faster (but still infeasible for larger directories)
It may be possible to run the program for a bit, track runtime v. data (in terms of file size) processed, then run a linear regression or curve fit to estimate total runtime after n files are processed, but this may lack accuracy due to runtime being a function of # of files rather than file size

May not be possible to address this issue. Perhaps revisit in the future if new use cases arrise.


changed the way zoom is calculated to the upper zoom level instead of…

… the lower one
cc @rafatower

@ethervoid please review, I'll push as soon as tests passes.


can't add customer managed policy to role using iam-config.yaml

Describe the bug
I can't add customer managed policy to role using iam-config.yaml
To Reproduce
I'm attempting to add a role with a customer created policy using the following code:
providers: []
policySets:

deploymentTargets:
organizationalUnits:

Root
policies:
name: DevPlusLocalTerraform
policy: iam-policies/DevPlusLocalTerraform.json
roleSets:

deploymentTargets:
organizationalUnits:

UAT
PROD
roles:
name: AzureDevOpsDeployer_v1
assumedBy:

type: account
principal: "arn:aws:iam::***:root"
policies:
customerManaged:

arn:aws:iam::*:policy/DevPlusLocalTerraform

getting error:
Expected behavior
Im expecting this to add this policy with the appropriate role
Please complete the following information about the solution:

[ ] Version: . v1.5.1

[ ] Region:  eu-west-1

[ ] Was the solution modified from the version published on this repository? No

[ ] If the answer to the previous question was yes, are the changes available on GitHub?

[ ] Have you checked your service quotas for the services this solution uses? yes

[ ] Were there any errors in the CloudWatch Logs? yes:

024-01-11 13:35:11.055 \| error \| accelerator \| Resolution error: Resolution error: Resolution error: Cannot read properties of undefined (reading 'managedPolicyArn').
--
119 | Object creation stack:
120 | at new UniqueStringSet (/codebuild/output/src3854/src/s3/00/source/node_modules/aws-cdk-lib/aws-iam/lib/private/util.js:1:2060)
121 | at Function.from (/codebuild/output/src3854/src/s3/00/source/node_modules/aws-cdk-lib/aws-iam/lib/private/util.js:1:1961)
122 | at new Role (/codebuild/output/src3854/src/s3/00/source/node_modules/aws-cdk-lib/aws-iam/lib/role.js:1:5927)
123 | at OperationsStack.createRole (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/lib/stacks/operations-stack.ts:422:18)
124 | at OperationsStack.addRoles (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/lib/stacks/operations-stack.ts:464:27)
125 | at new OperationsStack (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/lib/stacks/operations-stack.ts:128:12)
126 | at createOperationsStack (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/utils/stack-utils.ts:734:29)
127 | at createMultiAccountMultiRegionStacks (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/bin/app.ts:172:28)
128 | at main (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/bin/app.ts:232:5)
129 | at processTicksAndRejections (node:internal/process/task_queues:96:5)
130 | at async /codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/bin/app.ts:240:5..
131 | /codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/lib/accelerator.ts:57
132 | throw new Error('Synthesis failed');
133 | ^
134 |
135 | Error: Synthesis failed
136 | at process. (/codebuild/output/src3854/src/s3/00/source/packages/@aws-accelerator/accelerator/lib/accelerator.ts:41:9)
137 | at process.emit (node:events:525:35)
138 | at process.emit (node:domain:489:12)
139 | at process.emit.sharedData.processEmitHook.installedValue [as emit] (/codebuild/output/src3854/src/s3/00/source/node_modules/@cspotcode/source-map-support/source-map-support.js:745:40)
140 | at process._fatalException (node:internal/process/execution:149:25)
141 | 2024-01-11 13:35:11.160 \| error \| toolkit \| Subprocess exited with error 7
142 | 2024-01-11 13:35:11.161 \| error \| toolkit \| Options were: {"command":"synth","enableSingleAccountMode":false,"partition":"aws","stackPrefix":"AWSAccelerator","stage":"operations","configDirPath":"/codebuild/output/src3854/src/s3/01","requireApproval":"never","cdkOptions":{"centralizeBuckets":true,"useManagementAccessRole":true},"useExistingRoles":false}
143 | Synthesis of stacks failed

**Screenshots**
If applicable, add screenshots to help explain your problem (please **DO NOT include sensitive information**).
Additional context
what i'm trying to do here is to create this role in all new accounts automatically so it is easier to integrate with Azure DevOps
the role creates without attaching the policy
thanks for your help
David

just tried using the following and worked:
customerManaged:

DevPlusLocalTerraform


Replace comma-delimited string flags with repeatable flags

Closes https://github.com/prometheus-community/stackdriver_exporter/issues/44
The original issue is pretty old but the feature request still holds up, I too find it more ergonomic to manage repeatable flags rather than a large comma-delimited string. As suggested in the issue, I also changed metrics-type-prefixes to just metrics-prefixes

I like it, mind doing a rebase?

@SuperQ Done, thanks

I wonder if it would be worth keeping the original flag as-is, and append the strings.Split() to the new flag results. Then mark the original flag as deprecated and print a warning in the log.


Failed to load stdlib module when executing cyclonedx-gomod

The issue I'm facing is that I have a CI with Go 1.21 that tries to generate the bom for an application that requires Go 1.22.
The error I get is the following:
~ cyclonedx-gomod app -verbose -json=true -main ./cmd/server
12:29AM DBG loading modules moduleDir=.
12:29AM DBG executing command cmd="/usr/local/go/bin/go list -deps -json ./cmd/cli/" dir=.
12:29AM DBG executing command cmd="/usr/local/go/bin/go env -json" dir=
12:29AM DBG loading module<EMAIL_ADDRESS>12:29AM DBG executing command cmd="/usr/local/go/bin/go list -mod readonly -json -m"<EMAIL_ADDRESS>12:29AM ERR error="failed to load modules: failed to convert packages to modules: failed to load stdlib module: failed to load stdlib module: listing module failed: command `/usr/local/go/bin/go list -mod readonly -json -m` failed: exit status 1"

While I'm not sure if it's a bug, the following behavior presents frictions with respect to the new policy in which Go 1.21+ version try to compile newer versions.
My goal is not to have to update de go version every time a release occur since now Go 1.21 and later will not try to compile code that requires a newer version of Go but instead download the corresponding toolchain.

There is nothing in cdx-gomod that relies on specific versions of Go, as it merely orchestrates calls to the go binary in the environment.
To my understanding, merely listing modules should not build anything, but download sources of all dependencies in involved. So it's definitely odd if you're now getting errors due to builds failing.
Can you try running the /usr/local/go/bin/go list -mod readonly -json -m command manually, in the<EMAIL_ADDRESS>directory? Do you get any additional output?

<EMAIL_ADDRESS>/usr/local/go/bin/go list -mod readonly -json -m
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available

Maybe related https://github.com/golang/go/issues/62278 ?

I found I needed to make several improvements to get it to run right in my environment.

My go.mod had a toolchain line that wasn't compatible with the different build systems it ran on.  I had to bump this back to toolchain 1.21.0 from toolchain 1.22
Based on the related tidy issue (thanks, @emacampolo), it led me to running go mod tidy, which allowed the command to pass.


add subclassOf to congenital diseases: 'has modifier' some congenital

For any class that has 'congenital' in the title, we should do a SPARQL query for these terms and add a subclassOf axiom
'has modifier' some congenital (MONDO_0021140) using ROBOT

This issue is part of the November 2021 Mondo workshop here

@matentzn : I am trying to create a sparql query to get:
All terms with "congenital" in the label
and
filter to get the terms that do not have the axiom "has modifier" some "congenital".
I am able to get all the terms with "congenital" in the label.
However, I cannot filter terms based on the axiom. I tried the following 2 queries, but it is unclear what is being filtered.
Could you help, please? Thank you
Here is my sparql queries.
https://api.triplydb.com/s/PgxwM704v
https://api.triplydb.com/s/PgxwM704v

Very good proposal, you simply needed to use complex owl restriction syntax instead of ?diseases :has_modifer ?c
https://api.triplydb.com/s/troQ8I-vC
This query exclude all cases that have a SUBCLASS axiom (not logical definition!) that "has modifier some congenital"

Thank you @matentzn .
Note to self:

running the query against the ontology or the reasoned ontology does give the same results (which was to be expected since "congenital disease" grouping term is already obsoleted.
The list should be reviewed as some terms might not fit the "congenital" pattern. For example "hereditary thrombophilia due to congenital protein C deficiency" might not be "congenital"

Report here

@nicolevasilevsky : terms which are "disease due to congenital ~~" were excluded as I don't believe they should get the congenital modifier. (there were only 6 terms, please see report above to review).
ROBOT template: https://docs.google.com/spreadsheets/d/e/2PACX-1vQj7JiEHKb4EqxRC7uWV1bmkUMTmpM1O-8x92rIwvEEm061e61o2WhJiSVpETu0O0HAqyum2I7Snrjn/pub?gid=1977378741&single=true&output=tsv


InvokeMethod issue on Android side, MethodChannel and EventChannel must be executed on the main thread

Steps to Reproduce

Currently developing an App in flutter which is communicating with Android through EventChannels and MethodChannels,
got some problem since I updated flutter from 1.5.4 to 1.7.8. So basically my workflow follows this steps.

On android side I am waiting for detection of sensor
On detection i read it and invoke a method from Flutter
Flutter generates a string based on argument, which he returns over method channel
When i get the String back on Android side, I use that String and run other methods
I send a variable on EventStream sink back to flutter
Flutter listens to stream and displays the content

And there are a couple of issues, your invoke method needs to run on MainThread, same goes for pushing variables on EventSink. Is this a bug in the new version or you just want us to do with a single thread? Second issue i found was even in the previous version, I simply don't know how and didn't find anything on the internet or your docs about awaiting results of invokeMethod on Android side, in flutter you can simply create a Future method and await it, but in Kotlin i don't know how (Currently time racing with Thread.Sleep(50ms)). Any suggestions? Am i doing something wrong?
I am doing all of this on MainActivity, is this the source of problem?
I tried to wrap it inside runOnUiThread, but it freezes my UI for the doing, would like to work it as async.
What are your words on that, what direction will you go next?
Logs

Setting methodCallHandler on Flutter:
_channel.setMethodCallHandler(_checkPassword);

Invoking method on Android:

Log error after update (Same for Invoke method and EventChannel):
W/Binder: Caught a RuntimeException from the binder stub implementation.
    java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: Binder:10473_3
        at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:794)
        at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:684)
        at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:80)
        at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:189)
        at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:155)
        at io.flutter.view.FlutterView.send(FlutterView.java:750)
        at io.flutter.view.FlutterView.send(FlutterView.java:740)
        at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler$EventSinkImplementation.error(EventChannel.java:235)
        at com.tracklegit.mobile.MainActivity.onTagDiscovered(MainActivity.kt:145)
        at android.nfc.NfcActivityManager.onTagDiscovered(NfcActivityManager.java:602)
        at android.nfc.IAppCallback$Stub.onTransact(IAppCallback.java:83)
        at android.os.Binder.execTransact(Binder.java:739)

<!-- If possible, paste the output of running `flutter doctor -v` here. -->
[√] Flutter (Channel stable, v1.7.8+hotfix.3, on Microsoft Windows [Version 10.0.17763.615], locale sl-SI)
    • Flutter version 1.7.8+hotfix.3 at D:\Games\flutter
    • Framework revision b712a172f9 (2 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\blazj\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] VS Code (version 1.36.1)
    • VS Code at C:\Users\blazj\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.2.0

[√] Connected device (1 available)
    • SM G950F • 988a5c344849314e57 • android-arm64 • Android 9 (API 28)

• No issues found!

I have the same problem. Does one have an answer?

@BlazJeger Is it the same using current flutter stable?
Also, please do not include screenshots of code. This makes it extremely tedious to reproduce the issue, as we would have to manually transcribe your example. If you want to highlight syntax, you can wrap it into triple backticks with language in the beginning like
some code

I'm not an expert on these things so take with a pinch of salt, but seeing as there isn't much response to this old issue, here are some suggestions:
Is this a bug in the new version or you just want us to do with a single thread?
I think this is deliberate. It makes sense that you need to invokeMethod on the Android side using the UI thread, because it's the UI thread on the Dart side which is listening
I simply don't know how and didn't find anything on the internet or your docs about awaiting results of invokeMethod on Android side, in flutter you can simply create a Future method and await it, but in Kotlin i don't know how (Currently time racing with Thread.Sleep(50ms)). Any suggestions?
Don't use Thread.sleep. I can think of two strategies:

Don't try to await on the Android side. Instead, start whatever process you are doing on a separate thread (e.g. using AsyncTask or Kotlin's coroutines) and just return a boolean to indicate to the Flutter side that the request to start the task was successful. When the task is completed, call invokeMethod from the Android to the Dart / Flutter side with the result of your task.

Kotlin appears to have support for async / await although I haven't used these myself, which might be easier

I am doing all of this on MainActivity, is this the source of problem?

Not necessarily, that's what I'm doing and it seems to work great:

const val METHOD_CHANNEL_BILLING = "com.example/billing"

class MainActivity: FlutterActivity() {

  companion object {
    lateinit var methodChannelBilling: MethodChannel
  }

  private lateinit var methodHandlerBilling: MethodHandlerBilling

  override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)
    GeneratedPluginRegistrant.registerWith(this)

    methodChannelBilling = MethodChannel(flutterView, METHOD_CHANNEL_BILLING)
    methodHandlerBilling = MethodHandlerBilling()
    methodChannelBilling.setMethodCallHandler(methodHandlerBilling)
  }
}

class MethodHandlerBilling() : MethodChannel.MethodCallHandler {
    override fun onMethodCall(call: MethodCall, result: MethodChannel.Result) {
        // Note: this method is invoked on the main thread.
        when (call.method) {
            "queryProductsForSale" -> {
               ...
            }
            else -> {
                result.notImplemented()
            }
        }
    }
}

abstract class Payload {

  // optimizes future cast
  Type type;
  String actionButtonPressed;

  @mustCallSuper
  Payload(){
    type = runtimeType;
  }

  @mustCallSuper
  Map<String, String> toMap() => ({ 'type': runtimeType.toString() });

  Payload fromMap(Map<String, dynamic> receivedPayload){
    this.actionButtonPressed = receivedPayload['action_key'];
    return this;
  }
}

Please, its not finished yet. The code is not intuitive enough. But you can test the example code and see the polimorfism working on payload.
Commit differences bellow:
https://github.com/rafaelsetragni/flutter_local_notifications/commit/2e95146717b707ad1011cb419de0c68f3dd7edbe

Steps to Reproduce
Currently developing an App in flutter which is communicating with Android through EventChannels and MethodChannels,
got some problem since I updated flutter from 1.5.4 to 1.7.8. So basically my workflow follows this steps.

On android side I am waiting for detection of sensor
On detection i read it and invoke a method from Flutter
Flutter generates a string based on argument, which he returns over method channel
When i get the String back on Android side, I use that String and run other methods
I send a variable on EventStream sink back to flutter
Flutter listens to stream and displays the content

And there are a couple of issues, your invoke method needs to run on MainThread, same goes for pushing variables on EventSink. Is this a bug in the new version or you just want us to do with a single thread? Second issue i found was even in the previous version, I simply don't know how and didn't find anything on the internet or your docs about awaiting results of invokeMethod on Android side, in flutter you can simply create a Future method and await it, but in Kotlin i don't know how (Currently time racing with Thread.Sleep(50ms)). Any suggestions? Am i doing something wrong?
I am doing all of this on MainActivity, is this the source of problem?
I tried to wrap it inside runOnUiThread, but it freezes my UI for the doing, would like to work it as async.
What are your words on that, what direction will you go next?
Logs
Setting methodCallHandler on Flutter:
_channel.setMethodCallHandler(_checkPassword);

Invoking method on Android:

Log error after update (Same for Invoke method and EventChannel):
W/Binder: Caught a RuntimeException from the binder stub implementation.
    java.lang.RuntimeException: Methods marked with @UiThread must be executed on the main thread. Current thread: Binder:10473_3
        at io.flutter.embedding.engine.FlutterJNI.ensureRunningOnMainThread(FlutterJNI.java:794)
        at io.flutter.embedding.engine.FlutterJNI.dispatchPlatformMessage(FlutterJNI.java:684)
        at io.flutter.embedding.engine.dart.DartMessenger.send(DartMessenger.java:80)
        at io.flutter.embedding.engine.dart.DartExecutor.send(DartExecutor.java:189)
        at io.flutter.view.FlutterNativeView.send(FlutterNativeView.java:155)
        at io.flutter.view.FlutterView.send(FlutterView.java:750)
        at io.flutter.view.FlutterView.send(FlutterView.java:740)
        at io.flutter.plugin.common.EventChannel$IncomingStreamRequestHandler$EventSinkImplementation.error(EventChannel.java:235)
        at com.tracklegit.mobile.MainActivity.onTagDiscovered(MainActivity.kt:145)
        at android.nfc.NfcActivityManager.onTagDiscovered(NfcActivityManager.java:602)
        at android.nfc.IAppCallback$Stub.onTransact(IAppCallback.java:83)
        at android.os.Binder.execTransact(Binder.java:739)

<!-- If possible, paste the output of running `flutter doctor -v` here. -->
[√] Flutter (Channel stable, v1.7.8+hotfix.3, on Microsoft Windows [Version 10.0.17763.615], locale sl-SI)
    • Flutter version 1.7.8+hotfix.3 at D:\Games\flutter
    • Framework revision b712a172f9 (2 days ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\blazj\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] VS Code (version 1.36.1)
    • VS Code at C:\Users\blazj\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.2.0

[√] Connected device (1 available)
    • SM G950F • 988a5c344849314e57 • android-arm64 • Android 9 (API 28)

• No issues found!

i have the same issue!

I just had this problem (v1.12.13+hotfix.9), what I did was force executing the invokeMethod on main thread.
new Handler(Looper.getMainLooper()).post(new Runnable() {
    @Override
    public void run() {
        channel.invokeMethod( ... );
    }
});

In your case, I suggest you invoke another method in your success response to continue processing.
Hope it helps!!

To wait for the invokeMethod call from Kotlin to Dart to finish before continuing execution in the original thread, you can use CompletableDeferred.  ) }


Proper keyboard focus boundary is not visible on the ‘Copy to clipboard’ button.

Test Environment:
OS: Windows11
OS Version: 23H2 (Build 25905.1000)
Browser: Edge Dev (Version 117.0.2007.0 (Official build) dev (64-bit))
URL: PWABuilder - Packaging for the Google Play Store
Screen reader: Narrator
Steps to reproduce

Open the URL: PWABuilder - Packaging for the Google Play Store in browser.
Navigate to ‘Copy to clipboard’ button through tab key.
Observe the issue.

Current behaviour
Keyboard focus boundary is not visible on the ‘Copy to clipboard’ button present at the page.
Expected behaviour
Proper keyboard focus boundary should be visible on the ‘Copy to clipboard’ button.
Attachments:

Verified this issue is still reproduce on latest environment
Pre-requisite:
Open System Settings.
Select 'Accessibility' tab.
Select 'Color Contrast theme'.
In the 'Color Contrast theme' combo box select 'Aquatic/Desert' theme.
Test Environment:
OS Build: Windows 11 version 23H2 (26040.1000)
Edge Browser: Version 122.0.2365.3(Official build) dev (64-bit)
URL: PWA Starter - Routing and Navigation (pwabuilder.com)

@jperasmus, Can you please guide on which we need to add PR?

@jperasmus, we are unable to create PR for this issue. Could you please help us on creating the PR?

@msftedad Are you running into permission issues or what is the problem you're experiencing? If it is permission issues, you are likely trying to push directly to a branch on this repo. That won't work. What you should do instead is fork this repo and then create the PR from your branch on the fork to the master branch of this repo.


[Feature]: Enhance the basic CLI features

Description
Enable a better local integration in your CLI :fire:
Expected behaviour
You have to use a system similar to git:

[x] When a command is executed, look in the current directory for a .env file to load
[x] It should be possible to push changes to the vault (read the .env file, take all the variables excepted the ones starting with SECURE_ENV_ and save them in the vault using the API)
[x] It should be possible to pull changes to the vault (get the vault using the API and write to the .env file)
[x] It should be possible to view the status of the variables (which one are outdated, new, modified...)
[x] Check with the API team to see how you can integrate these features

Environment
/
Proposed solution
No response

Issue done, all task is finished.


Comment hotkey fails on multiple lines in CSS with existing comments in the selection

Issue Type: Bug
Trying remove existing comments with a hotkey ( CTRL + / ) fails if multiple comments present in the selection
Highlight 2 lines:
  /* flex-grow: 1; */
  /* justify-self: center; */

Press CTRL + /
The result is currupted CSS:
  flex-grow: 1; */
  /* justify-self: center;

VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:46:01.075Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.95GB (38.36GB free)

Process Argv
--verbose

Screen Reader
no

VM
67%

Extensions (55)

Extension
Author (truncated)
Version

better-comments
aar
3.0.0

vscode-userscript
adp
1.3.2

vscode-log-viewer
ber
0.12.2

vscode-intelephense-client
bme
1.8.2

insert-unicode
bru
0.13.3

bracket-pair-colorizer-2
Coe
0.2.4

autoit
Dam
1.0.7

copy-directory-path
dan
1.0.2

jshint
dba
0.11.0

xml
Dot
2.5.1

gitlens
eam
12.0.6

EditorConfig
Edi
0.16.4

vscode-great-icons
emm
2.1.86

prettier-vscode
esb
9.5.0

vscode-macros
EXC
1.3.0

vscode-highlight
fab
1.6.0

auto-rename-tag
for
0.1.10

vscode-pull-request-github
Git
0.40.0

vscode-test-explorer
hbe
2.21.1

beautify
Hoo
1.5.0

reg
ion
1.1.0

tabsanity
jed
0.0.11

auto-comment-blocks
kev
1.0.1

node-module-intellisense
lei
1.5.0

render-crlf
med
1.6.0

vscode-language-babel
mgm
0.0.36

git-graph
mhu
1.30.0

vscode-filesize
mkx
3.1.0

vscode-apache
mrm
1.2.0

vscode-edge-devtools
ms-
1.4.7

python
ms-
2022.4.1

vscode-pylance
ms-
2022.4.1

remote-ssh
ms-
0.78.0

remote-ssh-edit
ms-
0.80.0

cpptools
ms-
1.9.7

hexeditor
ms-
1.9.5

test-adapter-converter
ms-
0.1.6

debugger-for-edge
msj
1.0.15

color-highlight
nau
2.5.0

vscode-auto-scroll
pej
1.1.0

material-product-icons
PKi
1.2.0

vscode-phpunit
rec
2.0.76

format-html-in-php
rif
1.7.0

color-manager
roy
0.6.3

comment-divider
sta
0.4.0

code-spell-checker
str
2.1.11

tabnine-vscode
Tab
3.5.42

tauri-vscode
tau
0.1.4

vscode-ltex
val
13.1.0

vscodeintellicode
Vis
1.2.19

vscode-backup
Wes
0.0.6

php-debug
xde
1.26.0

local-history
xyz
1.8.1

json-color-token
yec
1.3.2

html-css-class-completion
Zig
1.20.0

(1 theme extensions excluded)

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

So a clear failure of already integrated functionality, also referred to as a bug, is now also a "feature request" theat will get discarded after 2 months. Interresting.
Because absolutely nobody ever comments out some items individually and wants to remove the commenting for all of them in one go later on. So this will never ever affect anyone.

It is odd, that this clearly an issue was marked as a "feature request"...

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Screen space effects + MSAA cause blurry screen

Godot version
3.3.2.stable
System information
Windows 10, Vulkan, RTX 2080
Issue description
MSAA appears to mistakenly cause blurry screen when screen space effects are enabled. FXAA does not have the same problem.
MSAA 16x, SSAO OFF, SS Reflections OFF

MSAA 16x, SSAO ON, SS Reflections OFF

MSAA 16x, SSAO OFF, SS Reflections ON

Steps to reproduce

Enable MSAA to 16x in project settings
Add a WorldEnvironment node to scene
Either enable Ssao or Ss Reflections

Minimal reproduction project
No response

16× MSAA causes various issues and will likely be removed (leaving 8× MSAA as the highest option, which is very demanding already).. It's surprising that the editor doesn't freeze completely on your end :slightly

This bug is for 3.3.2, not Vulkan.

This bug is for 3.3.2, not Vulkan.

The outcome is the same regardless of whether or not you use Vulkan, GLES3, DirectX, or any 3D rendering API. Because of how 16x MSAA works, it's extremely excessive and expensive to render in real-time, not to mention it causes a lot of issues, to the point that no game or game engine out there these days goes beyond 8x MSAA for that exact reason. MSAA is a method of supersampling, which by its very nature, is expensive. 16x MSAA should definitely be removed as an option altogether.
I think there are other options for anti-aliasing that the engine could add like TAA, which is in almost every game out there these days. It's a more modern implementation of anti-aliasing and a lot cheaper to render than MSAA while also providing near-identical quality in parts of the picture with no motion.

16x MSAA you're actually effectively rendering at 30720x17280 in some parts of the image, which is just ridiculous.

Somehow my graphics card was handling it with no problems.
I'm all for something that looks better and is cheaper. 16x MSAA is the best looking option in 3.3.2 right now, so I was using it. My fps is so blazingly high in the first place I don't notice a performance impact.

I think there are other options for anti-aliasing that the engine could add like TAA, which is in almost every game out there these days. It's a more modern implementation of anti-aliasing and uses a fraction of the rendering power that MSAA does while also providing near-identical quality in parts of the picture with no motion. SMAA would also be a nice addition.

See https://github.com/godotengine/godot-proposals/issues/2779. TAA is planned in a future 4.x release, but not 4.0 as it requires significant changes to the renderer to expose motion vectors.

No, like you said it only happens on 16x