Petrified Oak Blocks Bugs

Petrified Planks just have an empty recipe whilst the Stairs don't have any recipes whatsoever for it.

Petrified Slabs & Stairs aren't able to be mined with an axe, breaking and disappearing if doing so.

Most likely intentional but I find it a bit odd for Petrified Wood specifically, mining Petrified Logs with a pickaxe makes it break into planks.

I'll add the slabs and stairs to the axe category, but the planks thing for no. 3 is because of the code for breaking into planks with the wrong tool on wood, I just copied that over


feat: nyc is being refactored to become the official Istanbul 1.0 bin

This refactoring work moves nyc towards using Istanbul's more modular v1.0 API.
Features of Note

I've changed the messaging somewhat, announcing nyc as the official Istanbul bin.
We no longer call out to the istanbul bin for the feature check-coverage (calculating this is now our responsibility).
we no longer load .istanbul.yml, we will extend nyc's configuration gradually to support any configuration options that we're missing.
we now point folks towards babel-plugin-istanbul for ES6/ES7 support.
we no longer use the preamble function for --all functionality, using an approach closer to what istanbul's original bin used:

this fixes #183

Breaking Changes

.istanbul.js is no longer supported.
removed instrumenter configuration option for the time being (I think we get pretty far with the new istanbul-lib-instrument, and a noop instrumenter, and can avoid abstracting this part of the API for the time being).
completely new underlying instrumentation engine.

Todo

[x] test with a few libraries on Windows (windows testing went very smoothly \o/)
[ ] add unit tests for native ES6 code (excited to exercise the new instrumentation library).
[x] create tickets for further work: porting more istanbul configuration options, switching to the istanbuljs org's source-map library, source-maps for errors?
[ ]  get<EMAIL_ADDRESS>published.

CC: @novemberborn, @jamestalmage, @dtinth, @gotwarlost

one thing I've noted, is that the final bundled nyc balloons from 3MB to 7MB. On the plus side, since it's bundled it comes down as a single .tgz file, on the other hand, it would definitely be good to try to shrink the module a little bit.
As we discussed, a good chunk of this size is in istanbul-lib-instrument:
16K	append-transform
 16K	arrify
164K	caching-transform
 72K	convert-source-map
 52K	default-require-extensions
 56K	find-cache-dir
 68K	find-up
560K	foreground-child
308K	glob
108K	istanbul-lib-coverage
 57M	istanbul-lib-instrument
384K	istanbul-lib-report
5.4M	istanbul-reports
 52K	md5-hex
672K	micromatch
156K	mkdirp
 16K	pkg-up
 16K	resolve-from
 24K	rimraf
 24K	signal-exit
784K	source-map
304K	spawn-wrap
1.0M	test-exclude
1.9M	yargs```

Specifically the babel tool-chain:

```sh
 12M	./babel-generator
 12M	./babel-template
 13M	./babel-traverse
 12M	./babel-types
7.8M	./babylon

Currently we bundle nyc with an<EMAIL_ADDRESS>bin, to avoid some weird historical bugs related to singletons -- I'll try publishing a version using deduping, and see where it gets us to; perhaps we'd do better to address these long-standing singleton bugs, rather than increasing the size of the module.

package size update
If I bundle using an<EMAIL_ADDRESS>bin, the tarball size is only 2.7MB, and deduping gets the total size on disk down to about 25MB (post untar) not too shabby!
testing update
I've published the new<EMAIL_ADDRESS>bin to the next tag, I would love help testing. If folks could run it against a few of their modules.
npm cache clear; npm i nyc@next
CC: @JaKXz, @rmg, @addaleax.

I'm seeing some issues with the ava test suite, using the new instrumentation approach:
not ok should match pattern provided
    found: >
      /Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/location.js:25
        throw err;
        ^

      SyntaxError: 'return' outside of function (14:1)
          at Parser.pp.raise (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/location.js:22:13)
          at Parser.pp.parseReturnStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:321:10)
          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:107:19)
          at Parser.pp.parseBlockBody (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:529:21)
          at Parser.pp.parseBlock (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:510:8)
          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:127:19)
          at Parser.pp.parseIfStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:314:26)
          at Parser.pp.parseStatement (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:105:19)
          at Parser.pp.parseBlockBody (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:529:21)
          at Parser.pp.parseTopLevel (/Users/benjamincoe/bcoe/coverage/ava/node_modules/nyc/node_modules/babylon/lib/parser/statement.js:36:8)

@jamestalmage @novemberborn any thoughts?

It looks like you probably need to enable the allowReturnOutsideFunction in babylon.

@jamestalmage just came to that conclusion myself, got tests running by removing returns in the top-level cli module, I'll go ahead and set that configuration option. great find!

added a test for native ES6 support, found a few interesting edge-cases but in general, things seem to be working a lot better:

I could not get this to instrument:
let a = 33 || () => {
   console.log('missed')
}

CC: @gotwarlost ^ we should probably put a test around this.

@bcoe just tried<EMAIL_ADDRESS>and found some reporting errors with a ES2015 Babel project.
Interestingly, the errors look similar to what I was getting with the current instructions using the --all flag with the __coverage__ plugin. I ignored this mostly because of the --all flag before.

On the subject of allowReturnsOutsideFunction, this is controlled using the instrumenter option autoWrap (false by default - which is a change from v0)
https://github.com/istanbuljs/istanbul-lib-instrument/blob/master/v0-changes.md

On the es6 edge cases, this is a babylon issue:
$ cat .babelrc
{
  "presets": ["es2015"]
}

$ ./node_modules/.bin/babel
let a = 33 || () => {
   console.log('missed')
}
SyntaxError: unknown: Unexpected token (1:15)
> 1 | let a = 33 || () => {
    |                ^
  2 |    console.log('missed')
  3 | }
  4 |

@bcoe - great progress so far. We need to figure out - if the istanbul-cli is gone - what happens to commands needed for testing on the browser (e.g. istanbul instrument , istanbul report etc.)

I think babylon is correct in its parsing and parens are needed around the second expression (need someone who knows the ES6 spec intimately to chime in). This one works:
let a = 33 || (() => {
   console.log('missed')
})

@JaKXz mind opening a separate issues with a reproduction case for the behavior that you're seeing?
@gotwarlost found the allowReturnsOutsideFunction setting and enabled it 👍, I think in nyc's case we want to be pretty loose out of the gate (we'll probably find there are a few other babylon nits we gradually address).
@gotwarlost embarrassingly I haven't used Istanbul too much in the browser, mind opening a ticket describing an MVP of some of the features we should consider adding:

we have nyc report.
we can add nyc instrument, which I assume instruments a file and returns the code.

@gotwarlost mind tossing me on babel-plugin-istanbul as an owner:

I'd like to mention this plugin on HackerNews, I think it will bring some attention to the Istanbul 1.0 effort.
once we land this, and are happy, I'd love to also write a blog post on the merger of Istanbul 1.0 + nyc.

Ran tests for a couple of my packages with nyc@next, looks great so far! :)

I'm a little afraid to actually drop the hammer, but:

I've tested thoroughly with Windows.
I've tested against yargs, ava, npm, and tap (found a few bugs in the process, but for the most part all these large nyc reliant libraries are working well).
people's smoke tests seem to be going well so far?

If folks could take one more day to hammer on this (CC: @istanbuljs/nyc) I think we'll land it.

After npm i nyc@next, I'm getting:
/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-reports/lib/lcovonly/index.js:32
        writer.println('FN:' + [meta.decl.start.line, meta.name].join(','));
                                         ^

TypeError: Cannot read property 'start' of undefined
    at /Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-reports/lib/lcovonly/index.js:32:42
    at Array.forEach (native)
    at LcovOnlyReport.onDetail (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-reports/lib/lcovonly/index.js:30:28)
    at LcovReport.(anonymous function) [as onDetail] (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-reports/lib/lcov/index.js:21:24)
    at Visitor.(anonymous function) [as onDetail] (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-lib-report/lib/tree.js:34:30)
    at ReportNode.Node.visit (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-lib-report/lib/tree.js:123:17)
    at /Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-lib-report/lib/tree.js:116:23
    at Array.forEach (native)
    at visitChildren (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-lib-report/lib/tree.js:115:32)
    at ReportNode.Node.visit (/Users/kdodds/Developer/paypal/p2pnodeweb/node_modules/nyc/node_modules/istanbul-lib-report/lib/tree.js:126:5)

Works fine with latest.

@kentcdodds don't suppose you might be able to make a reproduction case, and tack it onto an issue? I'm holding off on merging this until we address a couple similar issues that have cropped up.
@gotwarlost saw some patches landing regarding crashers/performance. Just let me know any code reviews/implementation work you need done.

I believe my issue is the same that @JaKXz reported in #288

istanbul v1 now adds a new location called decl in the fnMap metadata to track the range for function declarations. This is being lost here: https://github.com/istanbuljs/nyc/blob/master/lib/source-map-cache.js#L123-L147
That's the reason the lcov report is failing. Note that this new location info also needs to be mapped when source maps are in play.

@gotwarlost would retiring nyc's sourcemap handling for istanbul's solve this issue?

possibly. We need to compare if there is any difference in processing between the two.

@gotwarlost I pulled in istanbul-lib-source-maps and it seems to have solved the problems, there's still the weird highlighting issues (which I think you have an open issue on babel regarding). We have a few remaining things to do:

seems like there continues to be some performance questions with babel-plugin-istanbul.
I'd like to add the instrument feature to nyc so that we can support front-end better, like you requested. Mind commenting on this issue and letting me know if I'm on the right track.
I'd like to switch to using your better --all support (maybe this will make it easier to support --all in babel-pluglin-istanbul too?).

Other than that, I think we're pretty on track for landing this?

Re: my "better --all" support, I'm having second thoughts about this. It may not be "better" :)
Problem is the babel cache. If we process a file for side-effects only then only the preamble gets written to the babel cache because we basically nuke the real code, which is going to have all sorts of fun implications when the user goes about exercising that code later and "nothing works".
If the caching were smarter to allow inclusion of the extra parameters in the cache key, it would be fine but previous comments seemed to indicate that the caching in babel is naive.

I have been poking around in the babel code recently. I think the cache only applies to babel-register. You can still parse any code using babel-core without impacting the cache.

@jamestalmage - when the babel plugin is used, it does not control any babel-specific options (the library API will not have issues since we use babylon and babel-generate as libraries). I'm not sure what will happen to the cache when babel-plugin-istanbul is used.

Although if we are disabling the babel cache in nyc this might work. Just now sure how we plan to implement the --all processing when the babel plugin is used.

Hey, if this has been previously mentioned apologies - I had a project recently where I wanted to use nyc but ended up at the older istanbul bin primary for the ability to run coverage to a JSON file and then run istanbul report after the fact. This was for a node lib that had been packaged for the browser with browserify - I found that command pair immensely useful to get browser coverage over the library. I think I also used the browserify-istanbul transform. Just mentioning in case you needed someone to speak up for the use case. And lastly, hank you ever so much for tools. AJB


Rename api action to actionCallbacks

Breaking Change
- <SwipeableViews action={} >
+ <SwipeableViews actionCallbacks={} >

Fixes #615
TODO:
when this change is merged and released, we need to fix type definition on DefinetlyTyped.

It can be fixed in the types


Added Kepler Energy Sources doc

Added a doc describing energy sources read by kepler.

@vimalk78 can you link this file in mkdocs.yaml
Each new file needs to be linked here otherwise they won't be rendered on the website.


HBASE-28465 Implementation of framework for time-based priority bucket-cache

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
HBASE-28463 passed

+1 :green_heart:
compile
3m 12s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 42s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 58s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  2s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
compile
3m  6s
the patch passed

+1 :green_heart:
javac
3m  6s
the patch passed

-0 :warning:
checkstyle
0m 46s
hbase-server: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 24s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 47s
patch has 46 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

37m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux d3046cc1445b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 39s
HBASE-28463 passed

+1 :green_heart:
compile
0m 44s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 27s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
shadedjars
5m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
245m 25s
hbase-server in the patch passed.

268m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5ffc7c6e8b3f 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/testReport/

Max. process+thread count
4663 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
HBASE-28463 passed

+1 :green_heart:
compile
1m  2s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
7m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

-1 :x:
unit
269m  1s
hbase-server in the patch failed.

299m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 13e6d25cc16e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/testReport/

Max. process+thread count
4865 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
4m 16s
HBASE-28463 passed

+1 :green_heart:
compile
3m 16s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 43s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 58s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  5s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
2m 58s
the patch passed

+1 :green_heart:
javac
2m 58s
the patch passed

-0 :warning:
checkstyle
0m 45s
hbase-server: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 32s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 46s
patch has 46 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

37m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 7c12c5b4ff03 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m  2s
HBASE-28463 passed

+1 :green_heart:
compile
0m 50s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
0m 52s
the patch passed

+1 :green_heart:
javac
0m 52s
the patch passed

+1 :green_heart:
shadedjars
5m 21s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed

_ Other Tests _

-1 :x:
unit
251m 27s
hbase-server in the patch failed.

275m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e0f2e8772541 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/testReport/

Max. process+thread count
4710 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 19s
HBASE-28463 passed

+1 :green_heart:
compile
1m  1s
HBASE-28463 passed

+1 :green_heart:
shadedjars
6m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

-1 :x:
unit
292m 22s
hbase-server in the patch failed.

321m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0331e5823b27 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/testReport/

Max. process+thread count
4988 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
HBASE-28463 passed

+1 :green_heart:
compile
2m 48s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 38s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 49s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 43s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

+1 :green_heart:
javac
2m 44s
the patch passed

-0 :warning:
checkstyle
0m 37s
hbase-server: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 48s
Patch does not cause any errors with Hadoop 3.3.6.

-1 :x:
spotless
0m 50s
patch has 46 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

35m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 7f8b257c1b65 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 52s
HBASE-28463 passed

+1 :green_heart:
compile
0m 51s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
240m 27s
hbase-server in the patch passed.

263m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a8b35c1b787d 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/testReport/

Max. process+thread count
4671 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 45s
HBASE-28463 passed

+1 :green_heart:
compile
0m 43s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 12s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 30s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
248m 38s
hbase-server in the patch passed.

271m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ef1ff8a4a597 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/testReport/

Max. process+thread count
5053 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

LTGM, can we just address latest spotless failure?

LTGM, can we just address latest spotless failure?

That's because of the Javadoc in the TestDataTieringManager class, where I included the structure of the TestDataTieringManager#hStoreFiles for better code comprehension. What do you think we should do instead?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
HBASE-28463 passed

+1 :green_heart:
compile
2m 38s
HBASE-28463 passed

+1 :green_heart:
checkstyle
0m 37s
HBASE-28463 passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 37s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 58s
the patch passed

+1 :green_heart:
compile
2m 39s
the patch passed

+1 :green_heart:
javac
2m 39s
the patch passed

-0 :warning:
checkstyle
0m 37s
hbase-server: The patch generated 8 new + 4 unchanged - 0 fixed = 12 total (was 4)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
5m 40s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

31m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux e517e1c5bde6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 55s
HBASE-28463 passed

+1 :green_heart:
compile
0m 49s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
248m 11s
hbase-server in the patch passed.

273m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 949ec8740130 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/testReport/

Max. process+thread count
4817 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-28463 Compile Tests _

+1 :green_heart:
mvninstall
2m 27s
HBASE-28463 passed

+1 :green_heart:
compile
0m 44s
HBASE-28463 passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
HBASE-28463 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

-1 :x:
unit
278m 11s
hbase-server in the patch failed.

300m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5793

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 30591c443986 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-28463 / 28c1e3b2a6

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/testReport/

Max. process+thread count
5764 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5793/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Valhalla Knights 3 [PCSE00244]

App summary

App name: Valhalla Knights 3
App serial: PCSE00244
App version: 1.01

Vita3K summary

Version: v0.1.5
Build number: 2663
Commit hash: https://github.com/vita3k/vita3k/commit/e8151664
CPU backend: Dynarmic

Test environment summary

Tested by: gymzatan
OS: Windows 11
CPU: AMD Ryzen 7 5800H
GPU: AMD Radeon(TM) Graphics
RAM: 16 GB

Issues
Game crashes before reaching title screen.
Screenshots

Log
vita3k.log
Recommended labels

Intro
crash

Vita3K v0.1.6 3093-3b536ec9
Game loads into main menu on Vulkan and gets stuck after starting a new game, endless loading screen.
vita3k.log

same status as before as of https://github.com/Vita3K/Vita3K/commit/968df5b60b53c5e81fc9ceec6de4c015f5f87ffc.
Screenshots

Logs
vita3k.log
Recommended Labels

Menu

How can i get this game work really wanna play it

I get in game and am able to walk around now, But this happens if you change the color of your character hair.

Anyone found a solution to fix the black characters? SD720g
This is my problem:

Vita3K summary

Version: v0.2.0
Build number: 3546
Commit hash: https://github.com/vita3k/vita3k/commit/ef89d019
CPU backend: Dynarmic
GPU backend: Vulkan

App summary

App name: VALHALLA KNIGHTS 3
App serial: PCSE00244
App version: 1.00
Screenshots

Logs
vita3k.log
Recommended Labels
graphics bug
Ingame +

as of https://github.com/Vita3K/Vita3K/commit/22595c5060298e246bbef02eb70d32752259ee09, the game is ingame, but refused to go further while in character screen. Has graphics glitches, but disappears soon as you switch back.
Screenshots

Log

Recommended labels
Ingame -

The game is playable from start to finish playing on default settings with Vulkan and audio is Cubeb. Only minor issue is body textures for naked characters but if you wear armor everything appears correctly. Had only one crash after multiple story events happened in a row, but reloading got me passed that.

App summary

App name: Valhalla Knights 3
App serial: PCSE00244
App version: 1.00

Vita3K summary

Version: v0.2.0
Build number: 3571
Commit hash: https://github.com/vita3k/vita3k/commit/[6ce9b659]
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: mparpuni
OS: Windows 10
CPU: AMD Ryzen 5 5600x
GPU: AMD Radeon RX6600
RAM: 16 GB

Issues
Body textures missing if character is naked.
Screenshots

Recommended labels

https://github.com/Vita3K/compatibility/labels/Playable


Expired Tasks

Store expired tasks in a list to be deleted or edited by task creator for a certain amount of blocks (1 or 2 weeks).
After 2 weeks, tasks are permanently deleted.

https://github.com/UniversalDot/universal-dot-node/issues/65

When a task is updated, the hash of the task changes and this hash is pushed to storage. The old task hash is only read not taken. I will change this so that the old value is removed.


More than just MYSQL

I was looking at the code in the database part, and I realized that the only database you can connect to is mysql, it's obvious that php + mysql is like beans and rice, but maybe it would be interesting for you to have the possibility of connect to PostgreSQL for example.

Yes, that's true.
Although I started with MySQL support because it is a common combination, it is important to have support for other databases, including postgresql.
In this case, one should continue with PDO following the singleton approach to establish the connection. I believe that a good option is to add a DB_DRIVER variable in .env and dynamically configure the $dsn, allowing the use of other databases.
The code could look like the following:

.env:

DB_DRIVER=db_driver
DB_HOST=localhost
DB_USER=root
DB_PASS=root
DB_NAME=name

source.php:

...

define("DB_DRIVER", $_ENV['DB_DRIVER']);
define("DB_HOST", $_ENV['DB_HOST']);
define("DB_USER", $_ENV['DB_USER']);
define("DB_PASS", $_ENV['DB_PASS']);
define("DB_NAME", $_ENV['DB_NAME']);

Connection.php:

...

$dsn = sprintf("%s:host=%s;dbname=%s;charset=utf8", DB_DRIVER, DB_HOST, DB_NAME);
self::$connection = new PDO($dsn, DB_USER, DB_PASS);

Feel free to share any ideas

Looks great to me, good idea.


CPP: Fix a bug in NewFree.qll

See https://discuss.lgtm.com/t/malloc-delete-mismatch-false-positive/1914.
The issue was that the call to tmp.data() was being misrecognized as an allocation call, due to over-enthusiastic data-flow tracking.  The fix is to only use local data flow for the purposes of identifying malloc-like functions (whereas global flow is still used to track between the malloc and free).
Diff query: https://lgtm.com/query/3658696700719411428/

How is performance on the snapshots that recently made this query act up?

I just ran the three queries that use NewDelete.qll on wireshark.  The first query goes from 643s -> 809s with these changes.  The other two (with a warmed up cache) stay at around 21s and 12s.  Similar results for one of the projects we had problems with recently - Singular (167s -> 226s on the first query).  And finally 'qtbindings' I don't have and can't get a snapshot of, but qt behaves as expected (379s -> 470s on the first query).
It's likely that with a warmed up cache these queries perform well.  In the long run we might replace the remaining SSA in this library with dataflow, which I'd expect to improve performance.

Do you think this bug is new in 1.20?

I don't think so, though we have made some changes to the query lately.  It's certainly plausible that the particular FP in the ticket above didn't show up until recently 1.20.

I'm not worried about performance on a cold cache. The data flow library has to be computed at some point in the suite anyway, so the suite won't get slower just because this query uses it. If the second and third queries take 21s and 12s, that means NewFree.qll is likely still fast since there's no cached in that file.

Yep I agree.


How to configure AWS X-Ray Variables

When I deploy X-Ray daemon on cluster nodes, I need to give Envoy to the connection information with the following environment variables.
ENABLE_ENVOY_XRAY_TRACING
XRAY_DAEMON_PORT
How can I pass this information?

For ECS, see this example and also, XRAY_DAEMON_PORT defaults to 2000, so you could use just this value.

Using this helm chart, you can configure tracing: https://github.com/aws/eks-charts/tree/master/stable/appmesh-inject


Track process position in real time

Currently we determine process position on the desktop in the beginning and use these coordinates. Probably we can do it in real time and handle the case if process window was moved

This might become in handy to solve this issue: WindowsGraphicsCapture https://docs.microsoft.com/en-us/uwp/api/windows.graphics.capture?view=winrt-19041


In Ansi_ The ColorTableFg in the windows.go file may have an array out of bounds

The length of ColorTableFg is 8, and when c>37, array out of bounds will occur


Added the abort controller to cancel requests. (#1067)

Description:
Cherry pick #1067
Uses the axios controller abort to cancel requests on timeouts.
Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.09 :tada:

Comparison is base (f549a69) 74.54% compared to head (9332deb) 74.64%.

:exclamation: Current head 9332deb differs from pull request most recent head f9bc8e9. Consider uploading reports for the commit f9bc8e9 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.21    #1077      +/-   ##
================================================
+ Coverage         74.54%   74.64%   +0.09%
================================================
  Files                30       30
  Lines              2055     2059       +4
  Branches            392      394       +2
================================================
+ Hits               1532     1537       +5
+ Misses              417      416       -1
  Partials            106      106

Impacted Files
Coverage Δ

packages/relay/src/lib/clients/mirrorNodeClient.ts
94.25% <100.00%> (+0.08%)
:arrow_up:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PostgreSQL sorting based on LC_COLLATE causes issues when not using C

First of all thanks a lot for this gem :)
This is not really a bug report, but rather a summary of an issue I've stumbled across. I'm not an DB expert and therefore not 100% certain if all this is correct. But, maybe it helps others how run into the same issue.
After integrating your gem everything worked correctly in development/test environment on my local laptop. But, when deploying to Heroku on production it raised duplicate entry errors caused by the unique index on the "rank" column. This was indirectly caused by the wrong sorting order.
On Heroku PostgreSQL LC_COLLATE is set to en_US.UTF-8. But, on my laptop it is set to C.
When using C the sorting order is (I think) what we want, where uppercase letters come before lowercase letters. But, when using en_US.UTF-8 the sorting order is different.
One can solve this at query time in sql order by rank collate "C" asc or in ruby order(Arel.sql('rank collate "C" asc')).
Alternatively, the column collate value can be changed with a migration:
ALTER TABLE items ALTER COLUMN rank TYPE varchar COLLATE "C";

Hey thanks for reaching out!
As far as I can see from your response we would have two possibilities to improve the gem and fix this issue:

Add documentation on which collations are supported by the gem. This means everybody using this gem has to make sure they use a supported column collation. This gives the user the freedom on which collation they want to use, but may lead to unexpected errors if they do not take care about it.
Use COLLATE in our order query. I guess this would mean that we need to differentiate between different database adapters in the code because each DBMS uses different collation names. This would probably be the easiest way for users of the gem because they do not have to care about it at all.

Do you have a preferred way of fixing this? I think I personally prefer the second option.
I definitely need to add multiple database adapters to the Github action script to verify they all work as expected.

For people using Rails, this oughta be enough (in a migration)
t.text :rank, collation: 'C'
Thanks for the gem. It helps!

Sorry for my late reply!

I guess just adding this migration line (as proposed above) to the README for PostgreSQL users should be sufficient.
I'm still pretty new to the whole collation thingy. I've noticed that it doesn't work reliably when only adding the collation to the query. But, it works great if using a migration.

Thanks a lot!

I'm guessing this problem isn't restricted to Postgres, has anyone tried it with MySQL?

Closed via #7.
Adding a new column type will be tracked in #8.


update variable names due to changes in iron.format.obj.Loader

Ouch, did not get to this for quite a while, the code is extremely messy prototype. Thanks for the fix!


[Feature]: Ability to use pre-existing JSONs to scan.

Contact Details
<EMAIL_ADDRESS>Feature Request
I've been fetching different endpoints from Infinite's API for a few months now, and different items have been removed/changed on those endpoints, yet they still exist on the API. Having the ability to import custom JSONs to scan would help build a broader cache library.

Hi there, to clarify you're thinking of a custom list of paths that HaloInfiniteGetter would fetch from halowaypoint and cache, correct? Currently, you can work around by changing the contents of something like Progression/file/Calendars/Seasons/SeasonCalendar.json and scanning it. Though it does deserve it's own feature and I'm willing to implement it, perhaps like:
{
  "recursive": true,
  "paths": [
    "Progression/file/Calendars/Seasons/SeasonCalendar.json",
    "images/file/progression/Switcher/Season_Switcher_S2_LW.png",
    "images/file/progression/ScreenBackgrounds/progression_background.png",
    "progression/file/Seasons/Season7.json"
  ]
}

I could also add an option to export all cached requests as path lists too, as opposed to the actual contents. This would avoid the need to share large archives.

I couldn't quite explain it in the initial issue, what I'm trying to do is scan pre-existing JSONs which were cached from Waypoint API, not using InfiniteGetter beforehand. As 343 removes content in endpoints like inventory_guide, it'd help with building a larger repository of GameCMS data/images.

Oh alright, so a simple scan selector for local (not in the application cache) json files should be enough. I'll add this in the Tools context menu, with the ability to choose multiple files to scan at the same time for convenience.


LDAPS is not supported

nginx: [emerg] http_auth_ldap: Protocol "ldaps://" is not supported. in /etc/nginx/nginx.conf:81
nginx: configuration file /etc/nginx/nginx.conf test failed

I built my nginx from source using the following:
./configure --user=nginx --group=nginx --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx
--conf-path=/etc/nginx/nginx.conf --pid-path=/var/run/nginx.pid
--lock-path=/var/run/nginx.lock --error-log-path=/var/log/nginx/error.log
--http-log-path=/var/log/nginx/access.log --without-http_gzip_module
--with-http_stub_status_module --with-pcre --with-file-aio --with-http_realip_module
--add-module=/home/ubuntu/nginx-auth-ldap --with-ipv6 --with-debug

(not sure if it means much, but no gzip)
ldap_server block:
##
# LDAP configurations
##
auth_ldap_cache_enabled on;
auth_ldap_cache_expiration_time 1000;
auth_ldap_cache_size 1000;

ldap_server test {
    url "ldaps://ldaps.company.com:636/OU=Users,DC=company,DC=com?sAMAccountName?sub";
    binddn "CN=asdf,OU=Users,DC=company,DC=com";
    binddn_passwd "password";
}

server block:
location /dev/admin {
    auth_ldap "Forbidden";
    auth_ldap_servers test;
}

What seems to be the issue? I see that ldaps is supported from the README.md, but for some reason mine is not cooperating.
nginx version: 1.9.9
Thank you!

I think you need --with-http_ssl_module in your configure or ldaps will never work. I'm not sure why using a new version would change anything... could be a change to how configure works I guess.


Sort the subsections

I think this will make it easier to find things in the subsections

I considered it, but this list is for discovering things, not finding. And nobody follows the alphabetic order when submitting PRs (from earlier experience), so I'd rather not do this for now. Thanks though ;)


Fix UVM processor cap bug with processor groups.

Fix bug where we were incorrectly capping a users requested
CPU count in multiple processor group scenarios. This was due to
the fact that we used runtime.NumCPU() to get the logical processor
count of the system and this does not take into account multiple
processor groups. Instead use the processor topology information from HCS
to cap the UVMs amount and the win32 API function GetMaximumProcessorCount
to cap a process isolated containers requested amount.
Add HCS schema files necessary to retrieve the processor topology information.

Signed-off-by: Daniel Canter<EMAIL_ADDRESS>

While we work out how best to pass in the NUMA settings, we can just quickly get this bug fixed that's a part of that work.


Add Values to the choices

Normally when creating a form with user entry that uses select , radio buttons and other data entry elements like that, I prefer to have a different value from the displayed value, I was wondering if there is any way of doing that, while still Programmatically creating the form.
e.g
  new PropertyVm(typeof(string) , "number")
                    {
                        DisplayName = "Select a number",
                        NotOptional =false,
                        Choices = new List<string>(){"one","two","three"},

                },

renders
<select name="number" class="form-control">
                <option value="one">one</option>
                <option value="two">two</option>
                <option value="three">three</option>
                <option value="four">four</option>
        </select>

but I want it render like
<select name="number" class="form-control">
                <option value="1">one</option>
                <option value="2">two</option>
                <option value="3">three</option>
                <option value="4">four</option>
        </select>

was wondering is there is any functionality that like?

Did that work for you? Closing as I assume it did.

This does not seem to work with suggestions. What would need to be done in order to get this to work with suggestions?

I'm working on it by changing https://github.com/mcintyre321/FormFactory/blob/master/FormFactory/Scripts/bootstrap3-typeahead.unobtrusive.js in order to support this use case. I yet have to think about a method to neatly pass the selected value's id on a submit event instead of the form value's input.
Besides this I'm thinking really hard whether I'm using the correct control for the correct use case...

Are you wanting AJAX suggestions (i.e. loaded from a url) or local suggestions (i.e. embedded in the page)?

If it's loaded from a URL, I think you just need to return data in the format:
 [
    {id: "someId1", name: "Display name 1"},
    {id: "someId2", name: "Display name 2"}
  ]

If you want local suggestions, you'll need to add something like:
 var suggestions = Model.Suggestions as IEnumerable<Tuple<string, string>>;
    if (suggestions == null && Model.Suggestions is IEnumerable<string>)
    {
        suggestions = Model.Suggestions.Cast<string>().Select(c => Tuple.Create(c, c));
    }

at line 59 of Property.System.String.cshtml and change line 60 to set the data-source attribute to contain JSON similar to that at the start of this comment.

The Tuple thing is working, but when you load a model with value on the property, the dropdown is not showing the correct one. It alwasys display the first item selected. Any suggestionts?

@guidozanon are you working with a string property? You also need to set the property value to match the value of the tuple. See https://github.com/mcintyre321/FormFactory/blob/master/FormFactory/Views/Shared/FormFactory/Property.System.String.cshtml#L13


Make OpenAPI metadata more rich & useful to clients

Adds an OpenAPI enum for attributes that are constrained to a set of Attributor values.

Coverage increased (+0.006%) to 92.872% when pulling f57362fa9c96721a0575fee199a42d2c17038ef2 on xeger:openApiEnhancements into c7c5663df34249107063339f4c404eade0b36dd9 on praxis:openApiEnhancements.


Ability to choose MaterialEditTextPreference EditText implementation

In MaterialEditTextPreference the dialog uses default EditText implementation, which is not having material dialog -like error messages, and the "old style" error messages come over the buttons:

It would be really nice to be able to choose or replace the default implementation with custom one. We are using in our project this one: MaterialEditText Their implementation has a nice error handling which looks like this:

It would be really nice to be able to choose/replace this implementation to be used within MaterialEditTextPreference. It would not go over the dialog buttons.

You can subclass MaterialEditTextPreference to do this.


Shouldn't Priority annotation be absorbed by Rule annotation?

As far as I know getPriority is a kind of method that always returns some constant. Maybe it makes sense to move this configuration to Rule annotation next to description and name?
I have made this decision while porting this engine to PHP but it's not even in beta yet, so let me know what you think :)

Hi,
Just for your information, I added the ability to define the priority in the @Rule annotation coupled with the possibility to override (dynamically) if required with a method annotated with @Priority (see #96).
I just wanted to ask, do you want to have your work appear in the list here (even if it's a WIP)? If yes, you are welcome to open a PR, otherwise, if you give me your permission to reference it, I will do it.
Kr,
Mahmoud


cs2.exe crash randomly

Describe the bug
I have a tool to run "generate highlight video" 100 times. cs2.exe will crash randomly and never pass the test. I doubt the root cause is that the "cs2-server-plugin" execute client commands outside the main game thread. We should process webserver commands and actions in frame callback(or sth in main thread), like what we do in "csgo-server-plugin".
Demo links
https://cdn.b5csgo.com.cn/b5demo/demos/b5match_725795961453888643.dem.zip
Steps to reproduce
run generate highlight video repeatly.
Expected behavior
Don't crash the game.
How often does this bug happen?
10%
Log file
No response
Environment information
None.
Additional context
No response

I have a tool to run "generate highlight video" 100 times.

Please provide steps to use this tool (the source code not the binary) and reproduce the issue.

you can use Demo Manager to play highlight with any demo.

try more times until cs2.exe crash.

The probability is larger than 10%

BTW, I've modify cs2-server-plugin and put cmd execution into FrameStageNotify, but it does not fix the issue.https://github.com/jaredliu2018/cs-demo-manager/tree/dev_server_plugin


Adding suppport for reverse iteration

In current, Transaction::scan and DB::scan only supports ascending order, it should be better to support reverse order iteration. This includes two steps tasks:

[ ] API design
[ ] the reverse iteration implentation

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Taking this up

This is what I am thinkging, please let me know if this is okay or feel free to mention changes.
Api design -
enum ScanOrder {
    Ascending,
    Descending,

This can be passed to DB::Scan
pub async fn scan<'scan, T: 'scan>(
        &'scan self,
        range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
        mut f: impl FnMut(TransactionEntry<'_, R>) -> T + 'scan,
        order: ScanOrder
    ) -> impl Stream<Item = Result<T, CommitError<R>>> + 'scan

and
Also to Transaction::Scan
pub async fn scan<'scan>(
       &'scan self,
       range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
       order: ScanOrder
   ) -> Scan<'scan, R, FP> {
       let streams = vec![TransactionScan {
           inner: self.local.range(range), // match here to wrt to scanorder to do ascending(default) or descending
           ts: self.ts,
       }
       .into()];
       Scan::new(&self.share, range, self.ts, &self.version, streams)
   }

Is it better to have a builder pattern here? Because I think iteration is much more common than reverse iteration, we could keep:
pub async fn scan<'scan>(
       &'scan self,
       range: (Bound<&'scan R::Key>, Bound<&'scan R::Key>),
   ) -> Scan<'scan, R, FP>

then we add reverse method on Scan, users are able to use it like
            let mut scan = txn
                .scan((Bound::Included(&name), Bound::Excluded(&upper)))
                .await
                .reverse()
                .take()
                .await
                .unwrap();

In this way, if users do not explicitly decalre reverse iterating, Tonbo could use iterating as default.

Aligned.

MergeScan consists of multiple iterators

MutableScan
ImmutableScan
LevelStream
SsTableScan

ParquetRecordBatchStream

These should all implement reverse


run image purges

docker rmi docker images | grep "<none>" | awk '{print $3}'

why can't docker do this :(


It is impossible to change the value when using ARC when the value has reached the limit

Perform all steps below and tick them with [x]

[x] Check the related part of the Documentation
[x] Update openHASP to the latest version
[x] Reproduce the issue and describe all steps

Describe the bug
It is impossible to change the value when using ARC when the value has reached the limit. There is a number with a minimum limit of 0 and a maximum of 5. Now the number has a value of 1:

I move it to 0 and it is no longer possible to return it from 0

To Reproduce
          - obj: "p1b91" # Heater on/off button
            properties:
              "bg_color": '{{ "#ffffff" if is_state("input_boolean.heating", "on") else "#000000" }}'
              "bg_opa": '{{ "255" if is_state("input_boolean.heating", "on") else "128" }}'
            event:
              "up":
                - service: input_boolean.toggle
                  target:
                    entity_id: input_boolean.heating
              "hold":
                - service: script.plate01kitchen_thermostat_popup_number
                  data:
                    entity_name: "Режим котла"
                    entity_id: "number.boiler_operating_mode"
                    state_id: "input_boolean.heating"
                    entity_icon: "\uE156"

          - obj: "p0b179" # thermostat popup: temperature meter  (number)
            properties:
              "value_str": "{{ states(states('input_text.plate01kitchen_sel_enity')) | int() }}"
            event:
              "up":
                - service: number.set_value
                  target:
                    entity_id: "{{ tag }}"
                  data:
                    value: "{{ val }}"

      plate01kitchen_thermostat_popup_number:
        mode: single
        fields:
          entity_id:
            name: entity_id
          state_id:
            name: state_id
          entity_name:
            name: entity_name
          entity_icon:
            name: entity_icon
        sequence:
          - service: openhasp.command
            target:
              entity_id: openhasp.plate01kitchen
            data:
              keyword: jsonl
              parameters: >-
                {"page":0,"id":150,"obj":"obj","x":85,"y":90,"w":310,"h":340,"radius":15,"click":true,"border_side":0,"bg_color":"#0B61A4"}
                {"page":0,"id":151,"parentid":150,"obj":"label","x":10,"y":10,"w":48,"h":48,"click":false,"text":"\uE50F","text_font":48,"text_color":"#fff"}
                {"page":0,"id":152,"parentid":150,"obj":"label","x":63,"y":18,"h":28,"w":184,"align":"center","text_color":"#fff","text_font":24,"text":"{{ entity_name }}"}
                {"page":0,"id":153,"parentid":150,"obj":"btn","x":253,"y":10,"w":48,"h":48,"radius":24,"click":true,"border_side":0,"bg_color":"#CCC","text":"{{ entity_icon }}"}
                {"page":0,"id":179,"parentid":150,"obj":"arc","x":30,"y":60,"w":250,"h":250,"start_angle":135,"end_angle":45,
                "start_angle10":135,"end_angle10":45,"adjustable": true,"bg_color":"#0B61A4","line_color":"#FF0000", "bg_opa": 0,
                "min":{{ state_attr(entity_id, 'min') | int() }},"max":{{ state_attr(entity_id, 'max') | int() }}, "val":{{ states(entity_id) | int() }},
                "value_str":"{{ states(entity_id) | int() }}", "tag":"{{ entity_id }}"}
                {"page":0,"id":178,"parentid":150,"obj":"btn","x":125,"y":230,"w":60,"h":60,"toggle":true, "val": {{ 0 if is_state(state_id, 'off') else 1 }},
                "text":"\uE425","align":"center","radius":30,"tag":"{{ state_id }}"}
          - service: input_text.set_value
            data:
              value: "{{ entity_id }}"
            target:
              entity_id: input_text.plate01kitchen_sel_enity

          - service: input_text.set_value
            data:
              value: "{{ entity_id }}"
            target:
              entity_id: input_text.plate01kitchen_sel_enity

Expected behavior
I expect that it is possible to change the values even when they are equal to the limits
Screenshots or video

If I use a simple ARC, this problem does not occur.
Maybe it is a problem with Homeassist. Please create a minimal project and test again. The problem could be here :
"min":{{ state_attr(entity_id, 'min') | int() }},"max":{{ state_attr(entity_id, 'max') | int() }}
Set fixed values there to test.


Fix property overriding itself when accessed on the prototype

The function would rewrite itself when it was accessed from the prototype. Specifically, I noticed this when testing autobind-decorator in the soon-to-be-released update to React Hot Loader. The method version worked, but the class version broke because if (typeof prototype.render === 'function') check inside React Hot Loader caused render to get bound to the prototype.

Good catch, thank you. And loving your work :wink:

Thank you for the quick merge!


Installation problem

Hi, I'm now in programing,
How to Copy make/osx.mk to project root config.mk ?
I copy this [cp make/osx.mk config.mk] to commit line, it shows 'No such file or directory.'
Thanks!

It is here https://github.com/dmlc/mxnet/blob/master/make/osx.mk

Thanks,
Now, I'm in "R Package Installation", error shows:
Jeff-2:mxnet urAD_Jeff$ R CMD INSTALL R-package
-bash: R: command not found
How to fix it?

You need to install R if you are using the R package. If you have installed it and it is not find, try to find it in your system add add path/to/R/bin to the PATH env variable


Fix warning on Emscripten target

Fix for https://github.com/abseil/abseil-cpp/issues/1301

I removed the warning in bc097314fe5ba91e7f358159f84d7b9477502f75 instead since it doesn't provide much value.


[WIP] Handle impl in kt

Here's the work I've done so porting the handle typescript code over to Kotlin. This is currently a work in progress; opening this PR primarily as a vehicle for my own enlightenment.
For the most part, the work thus far is only the superficial aspects of the Handle functionality:

Respecting read/write settings for the handle
Setters/getters for the underlying data (update/clear/get for Singleton, add/remove/clear/get/toSet for Collection)
Delegating the correct operation to a storageproxy (mocked for now) for given operations
Trivial forwarding of sync, desync, and update events to the associated particle.

Open Questions:

The typescript implementation sends a structure to particles in onUpdate indicating some details about the data update that occurred. The current Particle.kt implementation omits this, so I've left it out for now.

There's no support for any sort of serialization right now, will there be boundaries over which we need to do some sort of serialization (or other transformation)?

There's no automatic ID generation

All invocations are synchronous and direct, seems possible that might need to change?

Options are not implemented yet. I notice that the configuration struct exists in the storageNG handle on the typescript side, but the values there don't seem to be respected, so I wanted to verify the expections around those settings before implementing them.

Thanks for getting this out early Jason, it's looking great! Some comments/answers to your questions below:

Trivial forwarding of sync, desync, and update events to the associated particle.

The typescript implementation sends a structure to particles in onUpdate indicating some details about the data update that occurred. The current Particle.kt implementation omits this, so I've left it out for now.

I wouldn't look too closely at the current Particle.kt implementation, it functions very differently from how we want to do things. Those details about the data update are important, and should be passed on to the particle. Maybe not critical to address in your first PR though, but we definitely want to expose them, somehow.

There's no support for any sort of serialization right now, will there be boundaries over which we need to do some sort of serialization (or other transformation)?

This should all be handled for you. The StorageProxy will talk to a Store and tell it what to do. That Store will actually be a ServiceStore, which will handle the serialization for you and will pass it over the Service AIDL interface. So I don't think there's anything to worry about here.

There's no automatic ID generation

As discussed in the meeting today, there should be a Kotlin implementation of this you can use if you need it.

All invocations are synchronous and direct, seems possible that might need to change?

You're probably right, but that can probably wait till later.

Options are not implemented yet. I notice that the configuration struct exists in the storageNG handle on the typescript side, but the values there don't seem to be respected, so I wanted to verify the expections around those settings before implementing them.

You can probably punt on this for now. It's likely we're not going to need any advanced configuration options for a while.


Select2TagWidget bug for arrayfield

Hello. I have some problem with custom Select2TagWidget for my ArrayField. When I create values in input and want delete only latest value, I can do that only if I push Enter or Space two times. My code:
It's my widget
class Select2TagWidgetArray(Select2TagWidget):

    def format_value(self, value):
        if not value:
            return []

        return value.split(',')

    def optgroups(self, name, value, attrs=None):
        if not self.choices and value:
            self.choices = [(c, c) for c in value]
        return super().optgroups(name, value, attrs=None)

    def value_from_datadict(self, data, files, name):
        values = super().value_from_datadict(data, files, name)
        return ','.join(values)

my form:
class CustomForm(forms.ModelForm):
    field = SimpleArrayField(
        forms.CharField(max_length=256), required=False, delimiter=',',
        widget=Select2TagWidgetArray(attrs={'data-width': '70%', 'data-token-separators': ','})
    )

Demonstration problem:
Tap one time on ENTER and will remove all values after clicked on BACKSPACE

If tap two times to ENTER and trying push on BACKSPACE will remove only latest value

It too difficult push to button two times.
requirements:
django-select2 = 5.11.1
Django = 1.11

Hi @teror4uks wow good catch. This looks to me like a select2 issue and not related to this Django package. Please make sure to make the maintainers at select2 aware for this issue. Thanks -Joe


Support logical references and foreign keys on the References panel

All logical foreign keys and references has to be shown in the list on the Reference panel together with regular and foreign keys and references.
As foreign keys and references can be from different databases now we need to show the database name on the Reference panel.

必须在“参考”面板的列表中显示所有逻辑外键和引用以及常规键和外键和引用。
由于外键和引用现在可以来自不同的数据库，我们需要在“参考”面板上显示数据库名称。

Can SQL completion be prompted for name completion in the editor? Currently, the lookup function in name cannot be implemented

Verified.


[Bug]: Keycloak 25 healthcheck endpoint not configured properly when using custom keycloak docker image

Testcontainers version
3.10.0 (Keycloak test container)
Using the latest Testcontainers version?
Yes
Host OS
Linux
Host arch
x86
.NET version
8
Docker version
N/A

Docker info
N/A

What happened?
Since Keycloak version 25, the ready check is not working properly even with latest TestContainers.Keycloak nuget package (3.10.0) because we are using custom keycloak docker image with custom versioning.
The new endpoint is configured based on the image version: https://github.com/testcontainers/testcontainers-dotnet/pull/1213
I don't have a perfect solution in mind, but maybe making an extension method on the builder would be the best solution?
Relevant log output
No response
Additional information
No response

If your custom image does not follow the semantic versioning of the official image, you can either override the default wait strategy or use the generic builder to create your own container configuration from scratch. Modules are pre-configured and opinionated, so we cannot support all types of customizations.

Alright, understandable.
We did just that, we overrode the wait strategy.


Job query fails to report a job with a single sample

I have a job on fox (756722 on gpu-9 on aug 5) that had only a single sample b/c the job is mostly idle and sampling only kicks in once it has been running for a while.  This job is not reported by the job query, and there can be good reasons for that (we can't compute record-to-record differences in cpu time with only one record) but at the same time it is annoying that this job just disappears.  Filing this as a bug but probably want to investigate a little more.

$ ./sonalyze parse -data-dir ~/sonar/data/fox.educloud.no -j 756722 -from 2024-08-05 -to 2024-08-05 -fmt all,csvnamed
version=0.11.0,localtime=2024-08-05 08:40,host=gpu-9.fox,cores=0,memtotal=0,user=ec-ewinge,pid=1249908,
job=756722,cmd=pt_main_thread,cpu_pct=100.5,mem_gb=3,res_gb=2,gpus=0,gpu_pct=0,gpumem_pct=0,
gpumem_gb=48,gpu_status=0,cputime_sec=279,rolledup=0,cpu_util_pct=0

Filtering nukes it:
Streams constructed by postprocessing: 1
Samples retained after filtering: 1
Jobs constructed by merging: 1
Jobs discarded by aggregation filtering: 1
Jobs after aggregation filtering: 0
Number of jobs after output filtering: 0

On branch larstha-550-verbose-filters, probably good to go for record filters and job filters, but want to do the other verbs too.

It would appear that only sonalyze jobs uses -min-samples.  Both sonalyze metadata and sonalyze parse support merging streams into multi-process multi-node jobs, but will never discard any resulting streams that have only one sample.  It seems to me that the right fix here is to set the -min-samples value to 1 (conservatively... even though 0 ought to mean the same thing...) and reconsider if there is any fallout.

Additionally -min-samples could be added to metadata and parse, to make things symmetric.  And the help text everywhere should make it clear that it applies to merged streams (jobs).


About Raspberry-Pi Support

Interested in this project and would like to ask if this firmware can only support both NRF52840-MDK and nRF52840 Micro Dev Kit USB Dongle the two development boards. If I want to use Raspberry-Pi, can it be achieved?

Interested in this project and would like to ask if this firmware can only support both NRF52840-MDK and nRF52840 Micro Dev Kit USB Dongle the two development boards. If I want to use Raspberry-Pi, can it be achieved?

Hi,
This firmware is prebuilt for NRF52840-MDK and nRF52840 Micro Dev Kit USB Dongle. However it can be easily ported to any nRF52840 based boards.
For Raspberry-Pi support, did you mean making Raspberry-Pi as a U2F key or a host?

Thanks for the reply.
Yeah,wanna make Raspberry-Pi as a U2F key

Thanks for the reply.
Yeah,wanna make Raspberry-Pi as a U2F key

@vinsec This implementation is not for RPI. But, you can take it as a reference. This U2F process should be similar.

Hi there,
I am going to develop a website that supports U2F certification, first to implement only the basic functions. Now want to implement  a U2F Key through this open source project and the nRF52840 Development Board, because I don't have the money to pay for Yubikey. This piece of source code I may not be able to carefully analyze(a bit hard), want to ask if the implementation of such a site is very difficult. Could you give me some advise.It's a school student at the moment.Thanks for your valuable time:)

Hi there,
I have a question
I want to implement FIDO2 Server in nrf52 chip, Is that possible without OS? or via it
about project: I want to assemble a device hardware to acquisition patients signals in hospital. and for accessing doctors to these data and settings, I want to implement FIDO2 Server on it , so doctors can connect to device with mobile Bluetooth and be authenticated in it.
on the other hand we implemented FIDO client in android.
thanks


Closes: #1

this is the first time i am pushing changes to a remote repo.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!

@googlebot I signed it!


Camera triggering in QGC survey missions not supported.

Currently there is no support for the MAV_CMD_DO_SET_CAM_TRIGG_DIST mission item, which is the standard way of triggering in a survey mission. Currently a survey mission imported with import_qgroundcontrol_mission will be executed but without the camera doing anything.
There is a test case for MAV_CMD_DO_SET_CAM_TRIGG_DIST in https://github.com/mavlink/MAVSDK/blob/develop/src/plugins/mission/mission_import_qgc_test.cpp  but no implementation yet.

That's right. Contributions are welcome :). The first question is what the MAVSDK API should look like for this.

MissionRaw enables this.


Fatal error on checkout page after 5.3.0 upgrade due to PaymentOption

After upgrading to Prestashop <IP_ADDRESS>, I updated to Paypal 5.3.0 (the update was not available on <IP_ADDRESS>??). No settings were changed.
Upon testing the checkout page, I realised it fails (error 500) as the page output stops printing after the Shipping Method tab's heading.
This happened on both dev and prod sites, so I had to revert back to 5.2.1.
This is the error I get in the logs:
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to PrestaShop\PrestaShop\Core\Payment\PaymentOption::convertLegacyOption() must be of the type array, string given in /src/Core/Payment/PaymentOption.php:337

Stack trace:
#0 [internal function]: PrestaShop\PrestaShop\Core\Payment\PaymentOption::convertLegacyOption('')
#1 /classes/checkout/PaymentOptionsFinder.php(46): array_map(Array, Array)
#2 /classes/checkout/PaymentOptionsFinder.php(82): PaymentOptionsFinderCore->find()
#3 /classes/checkout/CheckoutPaymentStep.php(84): PaymentOptionsFinderCore->present(false)
#4 /src/Core/Foundation/Templating/RenderableProxy.php(52): CheckoutPaymentStepCore->render(Array)
#5 /config/smartyfront.config.inc.php(98): PrestaShop\PrestaShop\Core\Foundation\Templating\RenderableProxy->render(Array)
#6 /classes/Smarty/SmartyLaz in /home/vipcigie/public_html/live/src/Core/Payment/PaymentOption.php on line 337

PHP is 7.3.24 on CentOS 7.
Any idea of what it could be caused by?

Hello,
Thank you for your message.
It seams that this issue is connected to https://github.com/PrestaShop/PrestaShop/blob/<IP_ADDRESS>/classes/checkout/PaymentOptionsFinder.php#L46
$rawDisplayPaymentEUOptions is the result of the search by hook displayPaymentEU.
We are not using this hook for the v5.x of the module.
Do you have the same errors if you disable the module?
Do not hesitate to contact our support team for get a quick help for solving the issue.
Best regards,
Tetiana

Hello @tvorgul,
thanks for replying. I just resolved the issue.
As it turns out, the Paypal module was attached to the displayPaymentEU hook. I'm not sure how that happened - I suspect during the latest upgrades (PS <IP_ADDRESS> => <IP_ADDRESS> and PP 5.2.1 => 5.3.0) but it may have been before.
I unhooked the hook and the error went away. After completing uninstalling and re-installing the Paypal module, I can confirm the hook is not re-attached.
I am a bit concerned this may re-happen... I'll keep checking for it after any future upgrade.
Anyway, just a note: the odd thing is that version 5.2.1 was working fine with the hook.
The only difference that I could trace was that in the previous version the HookManager adapter was returning Array() while in the latest was returning Array( [paypal] => ).
Kind regards,
Luca

Hi,
same problem here, with PS <IP_ADDRESS> and Paypal 5.3.0.
In fact, the Paypal module is attached to 28 hooks, among which I found these :

displayCustomerAccount
displayBackOfficeHeader
displayMobileAddToCartTop
displayMobileHeader
displayMobileShoppingCartTop
displayMyAccountBlock
displayPaymentEU
displayPaymentReturn
displayRightColumn
... which are declared nowhere in the code.
My guess is that they are not used.
I have upgraded it many times, from old v3 version, so I guess old hooks are not removed on upgrade.
Do you think it is safe to remove the module from all these seemingly unused hook ?

After writing my last message, I realised this is indeed the case. Most likely mine were left over from v4.
So on my dev site I went ahead and completely uninstalled the module. Upon reinstalling it, I 'only' had 18 hooks - I had 22 on the live site and you even have 28!
I'm not sure if it's Prestashop that should reset the hooks upon installing a new version or it should have been the Paypal module should have instructed PS which hooks to unhook.
Anyway, that gives me the confidence that is not going to happen again randomly.
So I went ahead and upgraded the live site, removing any extra hooks.

Hello,
Thank you for your comments !
You are right, the old hooks were not unhooked during the update. Normally the hooks like "displayPaymentEU" are not using in the module since v3.x.
We will try to add verification in the new release (v5.3.1) in order to unhook useless hooks.
Thank you very much for reporting this issue  and for your suggestions !
Best regards,
Tetiana

From my experience, you are right. And I confirm the module is OK when upgraded from v5.0, with PS <IP_ADDRESS>.
After removing the 10 unused hooks, I even gained 100ms per page on average (regarding the rendering time server-side).

Thank you so much for this information and contribution ! :)

Hello,
The official release of the v5.3.1 is now available on prestashop addons and on the github.
The issue that you encountered should be fixed. Thank you for your collaboration.
Do not hesitate to share you feedback.
Best regards,
Tetiana


Add support for NULL values

CSV reader
Parquet reader
min/max must respect nulls
add IS NULL / IS NOT NULL predicates

I think the CSV reader has been dealt with in #145, hasn't it?

@srenatus Yes it has. thanks.

well, it hasn't been handled for parquet but I will create new issue for that


Osdsctl bugs

What this PR does / why we need it:
Modifed somes osdsctl display items to adapt the new response structure.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Coverage remained the same at 59.012% when pulling 42f7c0abd13d348cb5fb8cca1ef463ccf9416474 on xxwjj:osdsctl into 448c95322c7621b72808c49e5edc23f5246c6473 on opensds:development.

Coverage remained the same at 59.012% when pulling 42f7c0abd13d348cb5fb8cca1ef463ccf9416474 on xxwjj:osdsctl into 448c95322c7621b72808c49e5edc23f5246c6473 on opensds:development.

Coverage remained the same at 59.012% when pulling 42f7c0abd13d348cb5fb8cca1ef463ccf9416474 on xxwjj:osdsctl into 448c95322c7621b72808c49e5edc23f5246c6473 on opensds:development.

Coverage remained the same at 59.012% when pulling 42f7c0abd13d348cb5fb8cca1ef463ccf9416474 on xxwjj:osdsctl into 448c95322c7621b72808c49e5edc23f5246c6473 on opensds:development.

Coverage remained the same at 59.012% when pulling 42f7c0abd13d348cb5fb8cca1ef463ccf9416474 on xxwjj:osdsctl into 448c95322c7621b72808c49e5edc23f5246c6473 on opensds:development.

Good job!


OPENCAST-855: Exposed download options for LR episodes

Link to test:
https://media.uct.ac.za/ltitools/courses2/index.html?sid=c8c41822-531d-4256-b773-033d354a2aa9&upload=false

The download descriptions should be the same as we have in the Download tab in the player.
The animations are a bit slow and should be snappier.
Also please check how this behaves on mobile devices (small viewports) - test full-screen, tablet-size and mobile.

Bonus points if you can make the download also trigger a POST to the usertracking endpoint to record a play event the same way that Theodul player does. But we shouldn't post more than one play event for different download for the same event (so if you download 3 different formats, still only 1 event).
Otherwise we lose some playback stats from these downloads.

Bonus points if you can make the download also trigger a POST to the usertracking endpoint to record a play event the same way that Theodul player does. But we shouldn't post more than one play event for different download for the same event (so if you download 3 different formats, still only 1 event).
Otherwise we lose some playback stats from these downloads.

Working on it

bootstrap and underscore seem to be duplicated (in both shared and courses).

Duplicate files removed from courses


Original exporter IP in aggregated flow records is not Node IP

Describe the bug
Original exporter IP is not Node IP, but it is always the gateway of the Pod network on the Node in the Encap mode. This is expected as the Flow Exporter sends the flow records from the Antrea agent, which is on the host network to the Flow Aggregator which is on the Pod network.
It is not useful to have gateway IP in the aggregated flow records.
To Reproduce
Any aggregated flow record from Flow Aggregator on Antrea in Encap mode.
Expected
Having gateway IP as the original exporter IP is not very useful. We should think about the use of adding this field in Flow Aggregator.
As we already send the source Node name and destination Node name, which are the original exporters of the aggregated flow record. One option is to remove this as the original exporter IP does not make sense when correlating the flow records. The second option is to add the exporter IP in the flow record sent by the Flow Exporter and have two different fields corresponding to each exporter (source and destination).
I prefer option 1.
We have a similar field OriginalObservationDomainID. This also does not make much sense when we correlate the flow records exported from two nodes. This should also be removed if we go with the Option 1.
Actual behavior
Sample flow record:
egressNetworkPolicyRuleAction: 0
tcpState: FIN_WAIT_2
flowType: 3
destinationClusterIPv4: <IP_ADDRESS>
**originalExporterIPv4Address: <IP_ADDRESS>**
originalObservationDomainId: 273090675
octetDeltaCountFromSourceNode: 0
octetTotalCountFromSourceNode: 0
packetDeltaCountFromSourceNode: 0
packetTotalCountFromSourceNode: 0

Versions:
Antrea main branch ToT
Additional context
If we go with the option 1 of removing the fields, then we can remove the additional templates we recently added.
/cc @zyiou

Also prefer option 1 to remove both originalExporterIPv4Address/originalExporterIPv6Address and OriginalObservationDomainID since the information these fields reveal is either generated or can be shown from node name.

Proposed solution sounds good to me


Fix for maas webhook

Hot fix for maas webhook

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AmitSahastra
To complete the pull request process, please assign jzhoucliqr
You can assign the PR to them by writing /assign @jzhoucliqr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Logout Flow

Please include the Logout Flow for Blazor Authorization using AuthenticationStateProvider

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9942b0a-a7fb-0d34-9201-af0963affa9e
Version Independent ID: 19770710-5225-a1ea-e082-65da6ba4a49a
Content: ASP.NET Core Blazor authentication and authorization
Content Source: aspnetcore/security/blazor/index.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

Cross-linking a few existing topics for authn/authz ...

Social login provider tokens+claims for Blazor auth
Google Social login provider for Blazor
Token Based Authorization using IdentityServer with Blazor
Signalr Context.User missing on hub
Logout Flow

Note that this issue will be addressed with the scaffolding PR that I'm turning in shortly.
btw -- The answer is along those lines :point_up:, but you need an XSRF token to submit that form. I plan to have that approach on the PR.


verifyUserSignatures

I see the examples to sign a message - is there an example that takes a signature + wallet address; along with a message in clear text - and verifies that the signature is valid?

Sorry, but I don't know any examples like this currently.


Fix provenance issues

When creating a BoxString using from_string or from_box_str, str::as_ptr was used to get the pointer, which only has read provenance for the initialized part of the string. Going through Vec in the from_string and through Box::into_raw in the from_box_str case fixed the issue.
Using proper miri flags (MIRIFLAGS=-Zmiri-strict-provenance) miri also complains about repr::arc, which is wrong since it uses a zero length array to be a fake custom dst, which is not allowed.

The MSRV check fails because of addr_of_mut, which was added in 1.51.
There are 3 options to fix this:

Raise the MSRV
Create a reference (unsound)
Do manual pointer arithmetic since it's repr(C)


Conversion

Sir, after this script a_convert_to_csv.py, an empty folder is created, the respective folder does not contain any csv file, can you please help me, how to do the conversion properly?
Code that I am using
from pathlib import Path
import numpy as np
import pandas as pd
import wfdb  # WaveForm-Database package. A library of tools for reading, writing, and processing WFDB signals and annotations.
def convert_to_csv(path='stress-recognition-in-automobile-drivers-1.0.0./', new_folder=True):
"""
Code to convert all .dat files (ECG signals) in a folder to CSV format
Path - location of the dat files (str)
new_folder - whether to put the files in a new csv folder (boolean)
@authors: Abhishek Patil, Enes Ahmeti
"""
print('Reading files...')
if new_folder:
    Path(path).joinpath("csv_files").mkdir(parents=True, exist_ok=True)
# Get list of all .dat files in the current folder
for file in read_data(path=path, extension="*.dat"):
    print(file)
    # Get only the name from file.
    filename = file.stem
    # Read the signal data
    record, fields = wfdb.rdsamp(filename)
    # Drive7 hand GSR is misspelled.
    fields['sig_name'] = ["hand GSR" if s == "hand GSr" else s for s in fields['sig_name']]
    # Column headers
    header = ",".join(["-".join(x) for x in zip(fields['sig_name'], fields['units'])])
    # Add to the corresponding folder
    filename = Path(path).joinpath("csv_files") / f"{filename}.csv" if new_folder else f"{filename}.csv"
    np.savetxt(filename, record, delimiter=",", header=header, comments="")
print('All files read successfully!')

def read_data(path, extension=".csv"):
"""
Function to read the all the csv/dat files.
Since there are many files, it returns an iterator.
path - path to the csv/dat files.
extension - csv/dat. (if csv, it returns the dataframe else only filename)
"""
file_paths = Path(path).glob(extension)
for file in file_paths:
if extension == ".csv":
dataset = pd.read_csv(file)
yield file.stem, dataset
else:
yield file
convert_to_csv()
It would be a great help.

@karandeep8 would be great to share what the issue was so that other people in the future could resolve similar problems. I would assume that the issue was mostly related to paths, but please give a detailed description. Thanks :)


Please add some form of 2FA authentication for remote logins

See title. Funds on the node are quite vulnerable due to only a password protection funds on a node from remote attackers. And most apps even have standard passwords, so then only the onion-adress is needed.

Closing as this should have been resolved with recent release of 2fa.


moment constructor.name returns 'p'

Is it possible to change moment contructor name to 'moment' or something more specific than 'p' ?
      	let tututu = moment("2000-01-02T00:00:00");       	alert(tututu.constructor.name);

The constructor name in source code is Moment, and that's what you'll get if you do moment().constructor.name using the non-minified version.
You're seeing p because you're either using a minified version of moment, or part of your own build process is minifying moment, therefore renaming the constructor function.

thanks