No google services compile option

🚀 Feature Requests
I would like that at compile time, the plugin use pure Android location manager
Contextualize the feature
To use this plugin on flutter apps that have to be published on Fdroid, I need to have an apk without any google location classes.
Describe the feature
I'm trying to find the way to do this, with the same code, just adding maybe a flutter build option, or something on gradle, to specify if Android location manager or both have to be added to the APK.
I'm not sure if this is possible to be done, and how difficult can be. For the moment i have two versions, one including this plugin, and the other without. Witch is annoying.
Platforms affected (mark all that apply)

[ ] :iphone: iOS
[x] :robot: Android

We are also in need of such a feature
github.com/digitalfabrik/ehrenamtskarte
There is also a floss fork which is more or less uptodate: https://gitlab.com/hanntech-gmbh/free2pass/flutter-geolocator-floss

This issue should be solved with the release of geolocator_android version 3.1.8.

@mvanbeusekom It seems like excluding the dependency is sadly not enough. The full discussion can be found here: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10991 In short the argument is: even if we exclude GMS via gradle it will still be used on compile time and just be excluded as a runtime dependency.
Since you already separated GMS and the android location manager very well in your code, I thought it might be possible to create two android packages: geolocator_android_floss and geolocator_android. Most of the core android geolocator code would be located in geolocator_android_floss while geolocator_android imports geolocator_android_floss and implements the 2 files that use GMS on top. So this should ensure compatibility. To exclude GMS compelty as an app developer we then could use an override dependency (in the pubspec) of  geolocator_android with geolocator_android_floss.
I feel like this could work, but I'm not sure. @mvanbeusekom What do you think about it? Any other ideas? I also read about: https://docs.gradle.org/current/userguide/feature_variants.html but I don't have enough knowledge about this stuff.
@maxammann Would you be interested on working on this together if we have a proposed solution that @mvanbeusekom is happy with?
To get a better idea of how I imagine the file structure I've described above I started moving and patching some files here:
https://github.com/Robbendebiene/flutter-geolocator

Since you already separated GMS and the android location manager very well in your code, I thought it might be possible to create two android packages: geolocator_android_floss and geolocator_android. Most of the core android geolocator code would be located in geolocator_android_floss while geolocator_android imports geolocator_android_floss and implements the 2 files that use GMS on top. So this should ensure compatibility. To exclude GMS compelty as an app developer we then could use an override dependency (in the pubspec) of geolocator_android with geolocator_android_floss.
I feel like this could work, but I'm not sure. @mvanbeusekom What do you think about it? Any other ideas? I also read about: https://docs.gradle.org/current/userguide/feature_variants.html but I don't have enough knowledge about this stuff.

That would be the clean approach. I think this should work, but would require some massive refactoring. An alternative approach which I already mentioned in some discussion would be to create FOSS GMS shims. It might even be possible to simply use https://github.com/microg/GmsCore/tree/master/play-services-location during building and make the build-process google free.

@maxammann Would you be interested on working on this together if we have a proposed solution that @mvanbeusekom is happy with?

I'm a bit back-and-forth whether I would like to work on this. I don't really agree that the way F-Droid is handling some of this is in the interest of "the greater good". I can understand their ethical standpoint, but this whole discussion went a little bit too far.

Opinion: I think this whole problem/discussion with F-Droid, does not promote FLOSS for users, but prohibits it. In order to solve this issue cleanly, we would need to refactor flutter-geolocator (Which I sadly think won't happen, because there is no benefit for 99% of the developers and 100% for users).

I think the re-factoring might seem big due to the amount of files that will be moved around, but since actually only 2 files in total include the GMS dependency it could be fairly simple. But @mvanbeusekom has to decide if he can accept this fragmentation for the (admittedly) small benefit.

It might even be possible to simply use https://github.com/microg/GmsCore/tree/master/play-services-location during building and make the build-process google free.

Yeah, this solution actually might provide some benefits. I might try this. Please let me know if you manage to get it running with microG.

I'm a bit back-and-forth whether I would like to work on this. I don't really agree that the way F-Droid is handling some of this is in the interest of "the greater good". I can understand their ethical standpoint, but this whole discussion went a little bit too far.

I have a similar feeling. I'm still unsure if they even have a valid point from a technical point of view.

I'm not sure if this is a viable option, but a very simple solution would be if geolocator could read from an environment variable or a project property that decides whether it should include the google dependency or the microg dependency.
So this line would contain a conditional check like:
dependencies {
    if (CONDITON) {
        def microg_version = "<IP_ADDRESS>816"
        implementation "org.microg.gms:play-services-location:$microg_version"
    } else {
        implementation 'com.google.android.gms:play-services-location:17.0.0'
    }
    implementation 'androidx.core:core:1.2.0'
}

This wouldn't require any further code changes, and it would even allow using the Fusedlocationprovider on devices that have microg installed instead of gms.

I'm not sure if this is a viable option, but a very simple solution would be if geolocator could read from an environment variable or a project property that decides whether it should include the google dependency or the microg dependency.
So this line would contain a conditional check like:

Looks good if it works! :tada:

Hi @Robbendebiene,
The problem is that I am not at all familiar with FLOSS or F-Droid and that makes it hard for me to follow, test and ensure quality is up to par. This means I am indeed reluctant to go forward with any significant refactoring.
In you last comment you mentioned using an environment variable to swap out dependencies. This part looks straight forward and if it works I have nothing against it if:

By default the Google Play Services are used;
This is properly documented.

Hi @Robbendebiene,
The problem is that I am not at all familiar with FLOSS or F-Droid and that makes it hard for me to follow, test and ensure quality is up to par. This means I am indeed reluctant to go forward with any significant refactoring.
In you last comment you mentioned using an environment variable to swap out dependencies. This part looks straight forward and if it works I have nothing against it if:
1. By default the Google Play Services are used;

2. This is properly documented.

I think those changes can also be done in downstream applications. So there is no strict requirement that we adjust Gradle files of flutter-geolocator.

@mvanbeusekom Thanks for your answer. I'm also in favor of providing an option to replace gms with microg. The problem is that org.microg.gms:play-services-location is not published on maven even though an implementation exists (see here and here) wherefore we cannot simply include it like that.
@maxammann If we do it downstream I'm pretty sure we run into the same problem as we already did with just excluding GMS downstream. They will argue that one dependency still depends on something proprietary..

@mvanbeusekom Thanks for your answer. I'm also in favor of providing an option to replace gms with microg. The problem is that org.microg.gms:play-services-location is not published on maven even though an implementation exists (see here and here) wherefore we cannot simply include it like that.
@maxammann If we do it downstream I'm pretty sure we run into the same problem as we already did with just excluding GMS downstream. They will argue that one dependency still depends on something proprietary..

You are probably right :D we could publish our own maven repo. Maybe my company woulf be willing to host it


Depth estimation on invalid projection area

Thanks for the great work and the release of augmented data and corresponding code. I might want to ask how do you guys make depth estimation on areas on the fisheye images that are, for example, self-occluded (remain static to the fisheye view) or do not have a valid projection of photometric information (black areas) due to distortion or projection due to augmentation? Meanwhile, I also kind of wonder if the augmentation of viewing direction would change camera intrinsics ? (I cannot come up with a reason why it would change it, but still being a bit curious).
Thanks! Looking forward to your reply.

Thanks for your interest in our work!
First, for the missing regions (black areas) on the fisheye image, we do not give supervision during the training step. We mask black areas according to the valid pixel region (regions that have ground-truth depth value) when we measure the loss. So, on the black regions depth loss is actually not measured, but the model predicts similar values considering neighborhood pixels.
Next, our viewing direction augmentation doesn't change the camera intrinsic parameters. It only changes the camera's extrinsic parameters especially, rotation metrics.
Thank you.

Thanks for your interest in our work!
First, for the missing regions (black areas) on the fisheye image, we do not give supervision during the training step. We mask black areas according to the valid pixel region (regions that have ground-truth depth value) when we measure the loss. So, on the black regions depth loss is actually not measured, but the model predicts similar values considering neighborhood pixels.
Next, our viewing direction augmentation doesn't change the camera intrinsic parameters. It only changes the camera's extrinsic parameters especially, rotation metrics.
Thank you.

Thanks so much for the instant answer! Is it possible that you could also share the valid masks on each augmented fisheye views?

Itt would be better for you to write codes for making a valid depth mask rather than download all corresponding valid masks. Following the conventions, we make a valid mask from the ground-truth depth map within a pre-defined valid depth range as follows:
valid_mask = np.logical_and(gt_depth > args.min_depth_eval, gt_depth < args.max_depth_eval)
You can use this code snippet in your dataloader or trainer file.
Thank you.

It would be better for you to write codes for making a valid depth mask rather than download all corresponding valid masks. Following the conventions, we make a valid mask from the ground-truth depth map within a pre-defined valid depth range as follows:
valid_mask = np.logical_and(gt_depth > args.min_depth_eval, gt_depth < args.max_depth_eval)
You can use this code snippet in your dataloader or trainer file.
Thank you.

"Could you please advise on the appropriate values for min_depth_eval and max_depth_eval when working with the KITTI360 and SynWoodScape datasets you have processed?"

It would be better for you to write codes for making a valid depth mask rather than download all corresponding valid masks. Following the conventions, we make a valid mask from the ground-truth depth map within a pre-defined valid depth range as follows:
valid_mask = np.logical_and(gt_depth > args.min_depth_eval, gt_depth < args.max_depth_eval)
You can use this code snippet in your dataloader or trainer file.
Thank you.

"Could you please advise on the appropriate values for min_depth_eval and max_depth_eval when working with the KITTI360 and SynWoodScape datasets you have processed?"

I got. The paper mentions that the maximum depth is 40.0 m. Thank you


FInal Project

Night of the Museum or Friday in Class before break.
5
Individual Attendance, Capture the Moment: 2 pointsTeam Presentation to Teacher: 3 points (1 minute),FrontendBehind the scenesCross DomainFE/BE DebuggingJWTDatabase

Live Review with student crossover
10
Individual Score for Runtime (binary criteria below, 5 points)Project quality, running cross domain and no crashes on FE to BE with these reviewsUI contains inputs that are validated for garbage, data cleaned (ie validate DOB or Password)UI contains actions for Create, Read,UI contains actions for Update, DeleteJWT is guarding a feature, demonstration of cookiesIndividual Score for Code Review (binary criteria below,  5 points) Project quality, observation of comments in every function, class, or method reviewed.  Be sure to review POJO, API Controller, and JPA.BE contains and API that shows that it handles error conditions (ie duplicate user id)BE contains support for GET and POST methodsBE contains a database that supports Create, ReadBE contains a database that supports Update, Delete

Silent Review
5
Team review ticket 3 points. .5 per bulletPurpose/Theme/Quality.VideoRuntime LinksREADME.mdBlog, Guides for review75% of individuals have met full stack work.Individual Review Ticket 2 points.   Provide me individual review ticket that is linked from Team Summary.  Highlight your accomplishments.. Quality of Presentation .5 per bulletIndividual Review TicketRuntime LinksTechnical AccomplishmentsBlog, Guides for reviewMeeting full stack and backend objectivesGitHub analytics

Night at the Museum: 5/5

pictures of behind the scenes
frontend/backend debugging after server went down

Live Review:
Individual Score for Runtime: 5/5

no crashing
validate password matching
create/read user
update/delete users
jwt for login

Code Review: 5/5

comments in functions reviewed
error handling/exception handling in API controllers that return custom errors
GET/POST for decrypting
database CRUD

Silent Review:
Team Review: 2/3

purpose/quality inside readme.md
runtime links
full stack most individuals

Individual Review: 1.5/2

review ticket exists
runtime links
full stack/backend objectives

Total: 18.5/20


Remove version: Jackett.Jackett version 0.20.3846

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.3846/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


rename point::value_type to coordinate_type

It would be useful if all geometry types had a member type identifying the T template parameter. point currently uses value_type for this, but that name is already taken for the types that inherit from vector such as line_string and multi_*. Let's use coordinate_type instead.

cc @artemp @springmeyer

@jfirebaugh - yes! Why don't we  shorten name to be coord_type to avoid extra typing ? (ref: https://github.com/mapnik/mapnik/blob/geometry-refactor/include/mapnik/geometry/point.hpp#L31)

Since it's something that you're likely reading much more often then typing, I think it's better to use the full word here. It's only one more character than container_type which we're not abbreviating.

👍


Is this extension compatible with Swift 2?

There is a Swift2 branch. The changes there were not programmed by me and I did not have the time to test them. Please check out this branch, try it and report here if you find any issues! As long as ABAddressBook is not removed from iOS (it is deprecated in 9.0, though), I am planning to keep this wrapper up to date :smiley:

On the iOS9 simulator, the tests fail. I think they have actually removed the old AddressBook framework from the operating system, since they are now offering a new address book framework. Although, I have not found any place where they state directly, that the deprecation means the removal of the framework at the same time. Functions and methods are often left in place for quite a while after deprecation.
I was not able to verify with the older simulators yet, because I am running into errors running or trying to reinstall the iOS8 Simulators. Most probably I first have to turn of rootless to allow that feature, in that case it would be quite poor by apple (why does that simulator need to modify system files?)

@TAKeanice I just tested on iOS 9 and got it to work. In addition to using the swift_2 branch, I also had to apply the change described here: https://github.com/SocialbitGmbH/SwiftAddressBook/pull/64 in SwiftAddressBookHelperMethods.swift
Specifically, it seems like in Swift 2, you can't cast CFArray? into [ABRecord]. You have to cast it to NSArray first:
let swiftRecords = (records as? [ABRecord])?.map {(record : ABRecord) -> SwiftAddressBookPerson in

changes to:
let swiftRecords = (records as NSArray? as? [ABRecord])?.map {(record : ABRecord) -> SwiftAddressBookPerson in

That helped! Another thing that I had to change was 17c454f (optional unwrapping or better this together with casting conditionally afterwards somehow failed).

Tests are now running, with iOS9 (the interface was not removed). Travis CI is just checking, and afterwards I will merge the swift_2.0 branch into master. Thanks for your help!


CAMEL-14285: Create bundle based karaf tests for camel-osgi-activator.

Also not sure if it makes sense to remove the tests from camel-itest-karaf.  They are similar with the exception that camel-itest-karaf uses feature installs rather than bundle installs.

Yeah we can remove that other test, or adjust it if we add camel-osgi-activator to features.xml and test it like the others

I'll merge this today.

Merged on master and removed the tests in camel-itest-karaf, thanks @bobpaulin


Add a derive macro for CustomType

The macro currently generates getters and setters for all fields in the struct, and has helper attributes for overriding generated getter/setter functions. There is also a readonly helper attribute that prevents a setter from being registered.
TODOs:

[ ] Docs docs docs
[ ] More tests
[ ] Register a pretty-print name for types
[ ] Attribute for calling a user-provided function with the TypeBuilder passed in

What would it be called?
Do we call it before or after registering everything else?

[ ] Attribute for skipping a field entirely
[ ] Support for tuple structs

What would the fields be named? field0, field1, etc perhaps?

[ ] Support for enums as described in the book

Looking good!
Let me know when to merge.

So below is list of all the attributes so far...

All fields (pub or private) will be exported

perhaps later a skip attribute

#[readonly] => only getter, no setter
#[get] => generated getter

#[get(func_name)] => use func_name as getter function

#[set] => generated setter

#[set(func_name)] => use func_name as setter function

omitted => generated getter and setter

Unfortunately we cannot make #[get(func_name)] use a standard getter signature with &self instead of &mut self which is quite unusual for normal structs...

I'll open another tracking issue...


If running locally, don't check for pipeline status before firing request to the worker

Background
Link to issue
Not related to a Jira card
Link to staging deployment URL
Not related to staging
Links to any Pull Requests related to this
nope
Anything else the reviewers should know about the changes here
The purpose of this change is to help people when working with the platform locally. What it does is it makes it so that if you are running the platform locally, you don't have to run data processing before that and wait a couple of minutes.
I found this to be a huge pain personally, because it was preventing me from easily checkout people's branches and test their PR changes locally.
Changes
Code changes
Added a check for the environment before checking pipeline status. If the environment is equal to development, we don't care about whether the pipeline has ran or not.
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[ ] Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

I merged this, but we will need to fix those unit tests -- I will make a ticket for it


requirements.txt: add missing onnx and bump onnxruntime to 1.14.1

Thanks for figuring out how to statically compile onnxruntime! :)
When I tried your project, I had to add onnx as a requirement or else I had an error. I also figured I'd bump the onnxruntime requirement to the latest. Hope you or someone will find it useful, cheers!

thanks!


error when running npm query

Bug description
error when running npm query
Module config
freshly pulled from github.
Screenshots
`root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas# npm run query

<EMAIL_ADDRESS>query
node ./convenience/query_stations.mjs

file:///var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas/convenience/query_stations.mjs:122
const {profile} = await import(hafas-client/p/${profileName}/index.js);
^^^^^
SyntaxError: Unexpected reserved word
at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)
at async link (internal/modules/esm/module_job.js:42:21)
root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas# npm run query Berlin

<EMAIL_ADDRESS>query
node ./convenience/query_stations.mjs "Berlin"

file:///var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas/convenience/query_stations.mjs:122
const {profile} = await import(hafas-client/p/${profileName}/index.js);
^^^^^
SyntaxError: Unexpected reserved word
at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)
at async link (internal/modules/esm/module_job.js:42:21)
root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas#
`
Additional context
I installed the Module and run the command npm query which caused the above error. I also tried to supply the command with a city name, but also no success - same error.
Can you please advise? Much appreciated <3

I also tried to supply it with "db" and "sbb", but still does not work.
root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas# npm run query db

<EMAIL_ADDRESS>query
node ./convenience/query_stations.mjs "db"

internal/modules/cjs/loader.js:818
throw err;
^
Error: Cannot find module '/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas/convenience/query_stations.mjs'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
at Function.Module._load (internal/modules/cjs/loader.js:667:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas# npm run query sbb

<EMAIL_ADDRESS>query
node ./convenience/query_stations.mjs "sbb"

internal/modules/cjs/loader.js:818
throw err;
^
Error: Cannot find module '/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas/convenience/query_stations.mjs'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
at Function.Module._load (internal/modules/cjs/loader.js:667:27)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
at internal/main/run_main_module.js:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
root@server:/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas#

That's odd. I just did a clean install of the module and can't reproduce this issue.
Which node version do you have?
Run node -v to check.
Did you run npm ci oder npm install in the modules directory?
I just noticed that the path "/var/lib/docker/volumes/magicmirror_modules/_data/MMM-PublicTransportHafas" is a bit strange. I never used MagicMirror in a docker container. Is that the right place to install modules when you use docker?

Hey, I ran node -v and the version is 12.22.9.
I also installed it via npm ci as advised by you here: https://github.com/KristjanESPERANTO/MMM-PublicTransportHafas/issues/161#issuecomment-2028498507
yeah it is the right place, other modules like MMM-CalendarExt3 work fine.
Thanks for your help!

Nice, that it worked 🙂 But node 12 is very old. The current version of MagicMirror doesn't work with such an old version. I recommend to install node 20.

Hey, i updated node and now it works, thanks!
One more thing: the documentation says I need to provide my satation ID in this format "XXXXXX". The query also returns a 6 digit number. But that did not work - nothing was shown in the plugin. I checked your example config and there it shows 2 leading 0s - "00XXXXXX". I tried this format and it worked fine. So maybe you can update the table with configuration values with information, that the number needs padding with zeros until it reaches 8 numbers in length.
Thanks for creating this plugin and for your great help! Much appreciated! :)

That's odd. Both "008012202" and "8012202" are working. Which station ID do you use?


JobData naming collision warning

We should provide a console warning when multiple jobs are registered with the same JobData name to help prevent collisions during decoding.

Fixed in #8


Removal, Renaming and Deprecation of Unused Sonar Projects

Please report undisclosed or confidential vulnerabilities here: Eclipse Security
Topics (Please mark an [x] to your Topic):

[ ] KICS
[ ] Invicti
[ ] GitGuardian
[ ] Pentesting
[ ] Security assessment (threat modeling, code reviews)
[ ] Trivy
[ ] Veracode (initial setup, GitHub integration)
[x] Other

Please describe your request:
Since the fork were created this projects are or deprecated or with the wrong name confusing when validation is need.
Projects to remove:

catenax-ng_product-value-added-service
catenax-ng_product-vas-country-risk-frontend

Project to rename:

catenax-ng_tx-vas-country-risk-backend - Rename from value-added-service to tx-vas-country-risk-backend

If there are any issues or further information needed, feel free to reach out. Thank you.

Hi @fabiodmota , the security team is not responsible for SonarQube or SonarCloud.
@FaGru3n can you help please?

Hi @fabiodmota,
I deleted both of the mentioned sonarcloud projects.
You should be able to rename the project yourself with the sonar.projectName setting.
I cannot find that in either your pom.xml or the sonar-project.properties, so I think it is defaulting to the name defined in your pom.
The change should then take effect automatically with the next analysis. Could you try that please and also double check, if the right projects are deleted?

Also changed added the project name to my pom and changed the name on sonar , we can close on my side this ticket


Update index.html to reflect the buffed rate of mob packs spawning in some areas

Along with introducing new TC85 areas, Blizzard buffed the unique mob spawn rate in some of them in the same patch. For example, Arachnid Lair now spawns 6-8 elites to make it more comparable to other TC85 zones.

Thanks for the PR!


CI: Cannot contact jenkins-node-8: java.lang.InterruptedException

It seems jenkins is failing for k8s 1.12 for some reason, it happen 3 times for this PR https://github.com/cilium/cilium/pull/5449
One of the builds that failed https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/875/

Believed to be fixed


Update README.md

Fixing typo on "project" word.

There are many other issues to fix in the file, can you make some more corrections and resubmit the pull request?

I made more changes and committed them. Do you want me to close this PR and open a new one or is this one enough? Thanks!

Nice work - thanks for the additional updates, I'm closing this PR now so others can complete the assignment.


Update to go version 1.22.3

#34  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aschepis and the rest of your teammates on  Graphite


Next download feature 2.0

Created the PR for Monaco download 2.0. Still implementing the unit and integration test but everyone can grab the code and start testing/ reviewing it. I have reuse most of the entities from the convert command.
Pending tasks:

Performance improvements in the dependency resolution feature
Testing for special config cleanup. I have tested it with management zone and alerting profiles and works fine, will need to test it with more configurations.
Documentation
Integration test
Unit test

this is good and very important work in this pull request
the download feature and command options should maintain consistency with the deploy command options
The download feature should use the same manifest file as the deployment file to reference environments to download configurations from and get rid of the --environment flag

feature was integrated into v2 dev branch


Make a Docker image

Hello,
It looks like you don't have a proper docker image. As compilation is not trivial, it would be great to have such an image.
I'd be willing to make one, but want to know before if this would be interesting or if you already tried.

I've been looking into making a statically-linked binary.  If that doesn't work out, I'll probably do a snap package which is based on docker.
https://insights.ubuntu.com/2016/06/14/universal-snap-packages-launch-on-multiple-linux-distros/

Why not both? :)

Static linux binary just finished:
https://github.com/Genoil/cpp-ethereum/issues/87


remove the use of web3

better if we use https://github.com/ethjs/ethjs-contract and https://github.com/ethjs/ethjs-query

We have 2 technical proposals to replace eth-js so this will be handled as part of that work. Closing in favor of that work and associated issues.


cameras.npz file

In order to run IDR on new data [DIR PATH], you need to supply image and mask directories, as well as cameras.npz file containing the appropriate camera projection matrices.
Dear authors,
Do we need to convert camera projection matrices in DTU dataset from txt to npy files?
Thanks

+1. Any chance of how to obtain the .npz file? Been searching around everywhere for a solution for this.

Hi,
Yes, the normalization code of the cameras is acting on cameras.npz file. For DTU, this npz file is a simple parsing of the txt files, meaning:
cameras = {}
n_cameras = 49 # or 64
scan_folder = 'DTU_preprocessed/scan65'
path_to_dtu_cameras = 'DTU/SampleSet/MVS Data/Calibration/cal18'
for i in range(n_cameras):
    filename = '{0}/pos_{1}.txt'.format(path_to_dtu_cameras, '%03d' % (i + 1))
    lines = open(filename).read().splitlines()
    lines = [[x[0], x[1], x[2], x[3]] for x in (x.split(" ") for x in lines)]
    P = np.asarray(lines).astype(np.float32).squeeze()
    P = np.concatenate([P, [[0, 0, 0, 1]]], 0)
    cameras['world_mat_%d' % i] = P
np.savez('{0}/cameras.npz'.format(scan_folder), **cameras)

And maybe you'll need to make this code compatible with your pathnames.

Do we need to process the downloaded camera parameters in DTU dataset first before converting them to npz files?

As can be seen in the code in the previous comment, the only thing that needs to do to the camera parameters is to make them 4x4 instead of 3x4.

Hi, thank you for your work. Currently, I have these three files: cameras.bin/txt, cameras.bin/txt, poses3D.bin/txt. These 3 files contain all the data for my images. It seems from your previous reply that you are using individual.txt file for each image (/pos_{1}.txt'), can you provide me with any advice on how to obtain cameras.npz file? Thanks for you time~!

嗨，谢谢你的工作。目前，我有这三个文件：cameras.bin/txt、cameras.bin/txt、poses3D.bin/txt。这 3 个文件包含我的图像的所有数据。从您之前的回复看来，您对每张图片都使用了 individual.txt 文件（/pos_{1}.txt'），您能给我提供有关如何获取 camera.npz 文件的任何建议吗？谢谢你的时间~！

I have the same question , can you help me


Build tfchain

repo: tfchain, path: substrate-node

was trying to build tfchain using the rustbuilder but...
rust by default produces statically linked binaries on musl linux and rocksdb doesn't like that

seems solved by:
 tfchain % cat substrate-node/.cargo/config.toml
[build]
# By default, on musl linux, statically linked binaries are produced.
# Rocksdb doesn't like that
rustflags = ["-C", "target-feature=-crt-static"]

Compiling tfchain-runtime v2.2.0-rc8 (/code/tfchain/substrate-node/runtime)
error: failed to run custom build command for `tfchain-runtime v2.2.0-rc8 (/code/tfchain/substrate-node/runtime)`

Caused by:
 process didn't exit successfully: `/code/tfchain/substrate-node/target/release/build/tfchain-runtime-1ebab0711e400a2b/build-script-build` (exit status: 1)
 --- stderr
 Rust nightly not installed, please install it!

Updated the nightly to a version that works for polkadot and added it to the Dockerfile  ( 100ae5a287073058de760aa21e48df06eb104640 ) but still:
log
Compiling tfchain-runtime v2.2.0-rc8 (/code/threefoldtech/tfchain/substrate-node/runtime)
error: failed to run custom build command for tfchain-runtime v2.2.0-rc8 (/code/threefoldtech/tfchain/substrate-node/runtime)
Caused by:
process didn't exit successfully: /code/threefoldtech/tfchain/substrate-node/target/release/wbuild/tfchain-runtime/target/release/build/tfchain-runtime-0e85f4a5d4684c4b/build-script-build (signal: 11, SIGSEGV: invalid memory reference)

Will build on ubuntu

TODO:

[ ] execute the build script inside the container and copy using zinit

when executing zinit init inside the container, the flow is blocked:
zinit list
---
build: "Error(Exited(Pid(59), 2))"
copy: Blocked
shutdown: Blocked
root@tfchainbuilder:/var/run#

Cannot write to '-' (No such file or directory).

building is ok, the zinit shutdown is not:
zinit: INFO (zinit::zinit) shutting down
zinit: INFO (zinit::zinit) service 'shutdown' is scheduled for a shutdown
zinit: ERROR (zinit::app::api) failed to execute shutdown: EPERM: Operation not permitted

 docker run -it --name tfchainbuilder -v /root/myhost:/myhost -v /code/threefoldtech/builders/builders/20_tfgrid/1_tfchain/scripts:/scripts -v /code/threefoldtech/builders/builders/20_tfgrid/1_tfchain/zinit:/etc/zinit --env TFCHAIN_VERSION --hostname tfchainbuilder --entrypoint /bin/zinit tfchainbuilder init
zinit: INFO (zinit::zinit) shutting down
zinit: INFO (zinit::zinit) service 'shutdown' is scheduled for a shutdown
zinit: ERROR (zinit::app::api) failed to execute shutdown: EPERM: Operation not permitted


Bug fixes

Fix typo for default output function.
For signed tags, get the only required last 5. matches signed
releases.

TBR since typo fix is imp.


Use older carousel

we need to port the carousel from the SSA version 1 landing page because the new one is dumb.

nevermind


Update transaction URL #28

Closes #28

This is not yet documented here https://developer.authorize.net/api/reference/
But the transactions were failing. And I noticed that the fix has been done in commerce_authnet 7.x https://cgit.drupalcode.org/commerce_authnet/commit/?id=c38308b3ab0adee9b2f09130a9f5e2c22684d4c0

I see, thanks. I think that slipped in when it was copied.


SQL AAD Rule Failures

Description of the issue
The existing rule 'Azure.SQL.AAD' only checks for sub resources. Newer API version support adding the Azure Active Directory configuration in the SQL.Server Properties directly.
To Reproduce
Steps to reproduce the issue:
Execute a PSRules test against a sql.server resource type with the below values. It will Fail saying AAD not configured.
{
      "Name": "server-D",
      "ResourceId": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Sql/servers/server-D",
      "ResourceName": "server-D",
      "ResourceType": "Microsoft.Sql/servers",
      "Kind": "v12.0",
      "ResourceGroupName": "test-rg",
      "Location": "region",
      "SubscriptionId": "00000000-0000-0000-0000-000000000000",
      "Tags": null,
      "Properties": {
          "version": "12.0",
          "minimalTlsVersion": "1.2",
          "publicNetworkAccess": "Disabled",
          "administrators": {
              "administratorType": "ActiveDirectory",
              "azureADOnlyAuthentication": true
          }
      }
  }

Expected behaviour
The rule needs to handle both SQL AAD configurations options.

Hey @BernieWhite,
I've raised this as a bug, but if it's wrong I'm happy to correct it.
I started trying to write this rule but I got stuck. The existing rule looks like this: https://github.com/Azure/PSRule.Rules.Azure/blob/main/src/PSRule.Rules.Azure/rules/Azure.SQL.Rule.ps1#L58

Rule 'Azure.SQL.AAD' -Type 'Microsoft.Sql/servers' -Tag @{ release = 'GA'; ruleSet = '2020_06' } {
    $configs = @(GetSubResources -ResourceType 'Microsoft.Sql/servers/administrators');
    if ($configs.Length -eq 0) {
        return $Assert.Fail($LocalizedData.SubResourceNotFound, 'Microsoft.Sql/servers/administrators');
    }
    foreach ($config in $configs) {
        $Assert.HasFieldValue($config, 'Properties.administratorType', 'ActiveDirectory');
    }
}

Which seems to only check the subResource type, it doesn't support if the type microsoft.sql/servers/administrators is used arm-doc.
So I think I need to include this in the -Type selector for the rule.
Can you provide me with some tips for this one, please?

@ms-sambell Happy for this to be logged as a bug.
-Type 'Microsoft.Sql/servers' is set it is about the SQL Logical Server being compliance or not. Technically if Microsoft.Sql/servers/administrators is used it can only be set to properties.administratorType = ActiveDirectory.
If Microsoft.Sql/servers/administrators is absent then no AAD identity is configured.

Leaving the type as is should be fine. We should check if either the sub-resource exists or the newer API property is set. Have a look at Azure.AppService.NETVersion since this is a similar behaviour with the web site config sub-resource. Web site config is either a siteConfig property or a sub-resource of the site.
https://github.com/Azure/PSRule.Rules.Azure/blob/ebca1323fc4daf2ac30a5c013ec18a0cd7b9c11f/src/PSRule.Rules.Azure/rules/Azure.AppService.Rule.ps1#L54-L71

@ms-sambell Did you have work complete on this? Otherwise I might fix it up.


feat(tutorial): complete step 4

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Congratulations! 🥇 You have successfully completed part 4 of the Carbon Tutorial.  You are one step away from getting a t-shirt and badge.


[Fix] SPADE with scipy 1.14.0, deprecated .A attribute in scipy.sparse matrices`

Description
This PR addresses the issue arising from the deprecation of the .A attribute in scipy.sparse matrices starting with scipy==1.14.0 .
The .A attribute was  used to convert sparse matrices to dense ndarray format.
However, this attribute was deprecated and has been removed in favor of the more explicit .toarray() method.
This deprecation was introduced with scipy==1.11.0. The PR removing it is #20499, see: https://github.com/scipy/scipy/pull/20499
See also release notes: https://docs.scipy.org/doc/scipy/release/1.14.0-notes.html#expired-deprecations
Changes
Replaced the use of .A with .toarray() in the _build_context function in the  spade module.
This change preserves the functionality of converting a coo_matrix to a dense format without breaking the code due to the deprecated attribute.
This was done follwing the offcial recommendation, see property docstring:
    @property
    def A(self) -> np.ndarray:
        """DEPRECATED: Return a dense array.
        .. deprecated:: 1.11.0
            `.A` is deprecated and will be removed in v1.14.0.
            Use `.toarray()` instead.
        """
        if isinstance(self, sparray):
            message = ("`.A` is deprecated and will be removed in v1.14.0. "
                       "Use `.toarray()` instead.")
            warn(VisibleDeprecationWarning(message), stacklevel=2)
        return self.toarray()

coverage: 87.892% (-0.3%) from 88.222%
when pulling f9145c2170bb53a42e35f90a52442a6369164ada on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 88.222%. remained the same
when pulling f9145c2170bb53a42e35f90a52442a6369164ada on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 88.222%. remained the same
when pulling e7cf9e0b10bbdc096bab7e2869f3907353e2ee6f on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 87.892% (-0.3%) from 88.222%
when pulling c3a1aa62309bb9bf4a4905ac109ec01490d6cf26 on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 88.222%. remained the same
when pulling c3a1aa62309bb9bf4a4905ac109ec01490d6cf26 on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 87.892% (-0.3%) from 88.222%
when pulling 17d4609f4a1adb4a9a7e8177e85572192555507a on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 88.222%. remained the same
when pulling 17d4609f4a1adb4a9a7e8177e85572192555507a on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.

coverage: 87.892% (-0.3%) from 88.222%
when pulling c8fcf8f6afa208985686c14f376cce9bcf5bb29d on INM-6:fix/spade_with_scipy_1_14_0
into bdd98eefe99706621f5c840ce28134dac0e794af on NeuralEnsemble:master.


[SPARK-32306][SQL][DOCS][3.0] Clarify the result of percentile_approx()

What changes were proposed in this pull request?
More precise description of the result of the percentile_approx() function and its synonym approx_percentile(). The proposed sentence clarifies that  the function returns one of elements (or array of elements) from the input column.
Why are the changes needed?
To improve Spark docs and avoid misunderstanding of the function behavior.
Does this PR introduce any user-facing change?
No
How was this patch tested?
./dev/scalastyle
Authored-by: Max Gekk<EMAIL_ADDRESS>Signed-off-by: Liang-Chi Hsieh<EMAIL_ADDRESS>(cherry picked from commit 7c14f177eb5b52d491f41b217926cc8ca5f0ce4c)
Signed-off-by: Max Gekk<EMAIL_ADDRESS>

Test build #129009 has started for PR 29845 at commit d1bacac.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33632/
Test PASSed.

Test build #129009 has finished for PR 29845 at commit d1bacac.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129009/
Test FAILed.

Merged to branch-3.0.


snapFilenameExtension cause removing of snapshot after test

When defining snapFilenameExtension (e.g. to empty string), the snapshot image will be removed after execute method call to 'matchImageSnapshot', if removed 'snapFilenameExtension' then it will work just fine.
Sample code:
addMatchImageSnapshotCommand({
failureThreshold: 0.2,
capture: 'viewport',
//   snapFilenameExtension: '',
})

I use it in the same way, and problem occurs too for me

There is a specific test case to allow snapFilenameExtension to be an empty string, so this should be fine. For that reason I need a more robust reproduction of the issue to make that test fail
https://github.com/simonsmith/cypress-image-snapshot/blob/master/cypress/e2e/matchImageSnapshot.cy.ts#L28-L42


Divide by zero in Orlanski package

Hello everyone,
I think I have stumbled across a niche bug. Recently, I had a working MITgcm configuration with open boundaries on the northern, eastern, and western side of my domain. At the boundary salinity and temperature varied with depth. The western boundary had the Orlanski condition enabled. With this setup I ran dozens of simulations which completed without error
However, when I changed my model setup to have a constant temperature throughout the domain the model would crash after ~0.75 years. When I looked at the last model step before blowup a full depth 10x1 strip of grid points in only the temperature field became NaN. This error only occurred when the Orlanski condition was turned on.
@andystew7583 managed to track it down to this condition in orlanski_west.F.  I believe it isn't sufficient just to ensure that TW_STORE_2(J,K,bi,bj) and TW_STORE_3(J,K,bi,bj) are not 0, because if you get unlucky enough they can be non zero but (ab1TW_STORE_2(J,K,bi,bj) + ab2TW_STORE_3(J,K,bi,bj)) can still equal zero.
When I amended that condition to:
                IF ((ab1*TW_STORE_2(J,K,bi,bj)
     &             + ab2*TW_STORE_3(J,K,bi,bj)).EQ.0.) THEN
                  CL=0.
               ELSE

My simulation did not produce any NaNs and did not crash. It seems there are a number of conditions similar to this for salt, u, v, etc...
Thank you MITgcm!
Garrett
Side note: It seems to me that in the case that the denominator ((ab1TW_STORE_2(J,K,bi,bj) + ab2TW_STORE_3(J,K,bi,bj)) is equal to zero, CL should be equal to CMAX not zero.

nice catch @garrettdreyfus !!
I guess the same problem appears in the other 3 directions as well, also with the velocities
Would you be willing to open a PR with the bug fix?
I don't know about CMAX. Do you think CL=CMAX makes more sense for continuity reasons? I assume that the original intention with CL=0 in this case was to have no effect.
Do you get "better" results (i.e. according to expectation) when you use CL=CMAX

I guess the same problem appears in the other 3 directions as well, also with the velocities
Would you be willing to open a PR with the bug fix?

Yeah! I'll open a PR with the fix in all directions and variables this week!

I don't know about CMAX. Do you think CL=CMAX makes more sense for continuity reasons? I assume that the original intention with CL=0 in this case was to have no effect.

Yeah I was just thinking it made more sense for continuity reasons. I'm not sure physically which option is better.

Do you get "better" results (i.e. according to expectation) when you use CL=CMAX

I haven't actually tried changing it. Aside from the divide by zero the orlanski condition has always looked good in our simulations. I just happened to notice it when reading orlanski_west.F

I went with the second option in a pull request I just submitted (#824). I have yet to test the fix...
In the next week or two I'll try and spin up an experiment with the orlanski condition enabled on all four sides and make sure it works as expected.


Windows 10 charset and Reverse Engineering

For bugs/errors, please provide the following if feasible:

Description of problem
Please see below.
Steps to reproduce the issue (e.g. the commands that you ran)
Run the reveng process
Any DDLs/code to help reproduce the issue
The process fails while generating the interim folder sql.
Logs/stack traces for exceptions
Please see below.
Obevo version you were on (I will assume the latest released version if not specified)
Latest snapshot version.

I am running reverse engineering on windows 10. Looks the oracle kotlin reveng uses the Charset.defaultCharset(). This might be the platform default charset.  I was able to resolve it using UTF-8. Let me know if I can do a pull request for changing charset.
Action completed with errors at Fri May 24 09:27:06 EDT 2019, took 105 seconds.
*** Exception stack trace ***
java.nio.charset.UnmappableCharacterException: Input length = 1
at java.nio.charset.CoderResult.throwException(CoderResult.java:282)
at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:285)
at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125)
at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207)
at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129)
at java.io.BufferedWriter.write(BufferedWriter.java:230)
at java.io.Writer.write(Writer.java:157)
at com.gs.obevo.db.impl.platforms.oracle.OracleReveng.doRevengOrInstructions(OracleReveng.kt:106)
at com.gs.obevo.db.apps.reveng.AbstractDdlReveng.reveng(AbstractDdlReveng.java:164)
at com.gs.obevo.dist.Main$7.value(Main.java:208)
at com.gs.obevo.dist.Main$7.value(Main.java:203)
at com.gs.obevo.dist.Main.execute(Main.java:119)
at com.gs.obevo.dist.Main.execute(Main.java:87)
at com.gs.obevo.dist.Main.main(Main.java:69)
Suppressed: java.nio.charset.UnmappableCharacterException: Input length = 1
at java.nio.charset.CoderResult.throwException(CoderResult.java:282)
at sun.nio.cs.StreamEncoder.implWrite(StreamEncoder.java:285)
at sun.nio.cs.StreamEncoder.write(StreamEncoder.java:125)
at java.io.OutputStreamWriter.write(OutputStreamWriter.java:207)
at java.io.BufferedWriter.flushBuffer(BufferedWriter.java:129)
at java.io.BufferedWriter.close(BufferedWriter.java:265)
at kotlin.io.CloseableKt.closeFinally(Closeable.kt:56)
at com.gs.obevo.db.impl.platforms.oracle.OracleReveng.doRevengOrInstructions(OracleReveng.kt:76)
... 6 common frames omitted

Hi, I'm open to taking pull requests. I'm not clear what change you are requesting (i.e. whether to change the default used, or to allow the charset to be parametrizable by command line); you can submit the pull request if it helps to clarify that
In terms of getting the merge request accepted, you'll have to fill out a DCO, per the contribution guide. You can see an example at the kata project (see the DCO and the commit that was done by that developer). But we can do those steps once agreeing on the change to be made

Hi, let me know if you'd like to submit a pull request, or if you just want to point me to the file + line number where you think the change is required. Also for my use case, where was the UTF character: in the object name or the object definition?

ok I will be submitting the change request. Can I please know what should the change number in the change log be ?  Please see below example what does 231 and 233 mean ?
EX: #231 #233: Correct reverse-engineering of table indices to their correct tables

Those correspond to the pull request # and/or the issue # that corresponded to the ticket. You can click the #231 link in the comment as an example
As you haven't created the pull request yet, you may not have the number yet for that (though I've can infer it). Given that we already have a ticket number for this, you can just add the number for this issue #236

Thank you Submitted a pull requested.

I made a minor change on the pom (a change that should have been there previously) and merged in your pull request. Thanks!
Fyi - per the dco, I added "covered by: gopal_ramadugu.dco" to your commit message

Snapshot has been published based on your change - https://github.com/goldmansachs/obevo/releases/download/master-SNAPSHOT/obevo-cli-master-SNAPSHOT-dist.zip

@shantstepanian I dont see the obevo-cli-dist.zip on the releases page. Can you please look in to this ?

This will need a couple days. The build failed as IBM changed the location of its DB2 Container on Dockerhub

DB2 issue is fixed. Will perform the release once your other tickets are resolved


Invalid diagnostic attempt to expose non-public symbol '' for the valid code

Description:
public function test(1|2|3 n) {
    if n is 2 {
        return;
    }

    1|3 _ = n;
}

Affected Versions:
2201.0.0 RC2

Even for the valid scenarios, I think we need to give the error for the return-stmt instead of highlighting the whole function-defn.

The incorrect error message for singleton types is fixed with https://github.com/ballerina-platform/ballerina-lang/pull/36959.. Need to fix the error pos for valid scenarios


Make it possible to ignore CN/SAN mismatches

Hi,
right now deploying etcd with TLS enabled requires setting up stable names or IPs for which the certs are valid. That can be quite difficult in some environments.
On AWS for instance it's good practice to run your instances in a ASG. For things like etcd it allows controlled rolling upgrades by utilizing wait conditions etc. In general, it's the idiomatic way to group your instances. But it's not easy to get stable IPs or names for ASG instances.
This applies more or less to any dynamic environment.
It would simplify the setup of etcd and therefor the most complex part of kubernetes infrastructures a lot if etcd could be made to ignore the CN/SAN fields, e.g accept any certificate as long as it's signed by the trusted CA.
I don't even think this decreases security much in most environments, since the most likely place for an attacker to get their hands on a TLS server/peer key is on a peer itself for which the name is already valid. Either way, I think it's a reasonable trade-off.

I am still under the impression that disabling CN/SAN checking while enabling CA checking is not easy in go TLS library. But things might be changed overtime as go adds more fields into TLS configuration.
As a first step, can you explore how to do this in go? Ideally with an example. /cc @discordianfish

cc @wenjiaswe

@discordianfish hello, just a friendly ping, the last update on this issue was back in January this year, I was just wondering if this issue is still relevant and need to be worked on? Otherwise, we are closing out long pending issues.

AFAIK it is.


Request/ option to add subtitles

Would be great if there is an option to add subtitles ..app is great just this is the only missing feature ,i'm not requesting you to add another sources

Subtitles would be a good addition


ENH: Use date and datetime objects

Use datetime.date for info["subject_info"]["birthday"] rather than a year/month/day tuple
Use datetime.datetime for info["helium_info"]["meas_date"]
Fix in-memory anonymization for EDF by deleting edf_info["subject_info"] and edf_info["meas_date"]

Closes #11966
Closes #11327

Thanks for the quick reviews, should be good now!

thanks Eric, very nice


envelopesApi.update: Error: INVALID_REQUEST_BODY

In an attempt to resend a document using the node api client, the code below throws error status 400 - INVALID REQUEST BODY.
await envelopesApi.update(dsJwtAuth.accountId, envelopeId, {
    resendEnvelope: true
})

However, doing the following works:
await envelopesApi.update(dsJwtAuth.accountId, envelopeId, {
    resendEnvelope: true,
    envelope: {}
})

Fix suggestions:

Update node-client-api documentation for update(accountId, envelopeId, opts, callback) to say opts.envelope is required

OR

Update api/EnvelopesApi.js, line 3861 to be var postBody = opts['envelope'] || {} ;

Thank you for the bug report. I have filed internal report DCM-3369.

Hi @by12380 This issue has been resolved starting in version 4.10.1 and 5.8.1

Can confirm that this is working, thanks! might be nice to have this as an example on examples project


Select farms randomly while deploying any solution

this can be done by 2 requests

Get the available farms and their count and how many pages.
Select a random page and get a random farm from this page.

@AhmedHanafy725 can you mention the endpoint for the first request please?

the same as the current one but set the ret_count to true

Investigation and Solution:

currently we are using grid client to get the farms and the send method returns only the data we are locking for a header
using gridproxy client is also an option but we will have to change the filteroptions type
another solution is to have competition between gridporxy to get the count, then getting the farms after that by the existing option.

Work Completed:
I implemented the needed function in gridclient and its call on utils/getfarms
implemented the randomization logic that store the selected pages and pick a new random number that isn't in the selected list
Work in Progress (WIP):
testing the current flow and have some issue with reset the selected array when the filters got updated, also there is some requests that I didn't catch why they were called.
Investigation and Solution:

will work on the reset section
the two requests take so long time to pick the farm, not sure if this is a general issue or something related to my network

Work Completed:
all needed logic is done.
Work in Progress (WIP):

faced an issue while testing that the website keep making requests and didn't stop,

Screencast from 06 نوف, 2023 EET 05:59:33 م.webm

the { exclusiveFor: props.exclusiveFor } and filtering the blocked farms on get farms count not sure how to handle this point

status
Work Completed:

requests issue is not related to the current solution and i opened an issue for it #1373
all needed logic are completed and pr #1370 is ready for review.

Verified on Devnet,
Every time a solution is selected, the farms are randomized, and a node is shown from that farm.
I tried on devnet, and it only had 2 farms, and both showed after a few refreshings.

I will leave it as a mainnet verification because there are more farms on the mainnet, to be sure.

verified on https://dashboard.bknd1.ninja.tf
version : 2.3.0-alpha6
tried 3 times every time i got a different random node

Verified:

Mainnet (Ninja)
2.3.0-alpha6


is extension supposed to only work once?

I see similar behavior with Windows and Linux customscript, looks like the first run result is cached and following run just show first run's result.
for example, I have a json file
cat script-centos.json
{
"fileUris": ["https://mystorageshare.blob.core.windows.net/publicshare/centos.sh"],
"commandToExecute": "sh  ./centos.sh"
}
When I run
az vm extension set -g rg --vm-name centosvm1 --name CustomScriptForLinux --publisher Microsoft.OSTCExtensions --settings script-centos.json --protected-settings "{}"
the first time, I got error "The specified blob does not exist", cause I forgot to upload centos.sh to the storage account. then I uploaded it and rerun the command, still got the same error even when the file is there now.
To make it work, I need to delete the previous extension first:
az vm extension delete -g rg --vm-name centosvm1 --name CustomScriptForLinux
then it will work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ebbeb5f-6ab6-3fb3-c969-5d935e60f251
Version Independent ID: 9d4169c9-f5b5-512a-8061-2234d6dec1eb
Content: az vm extension
Content Source: src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_help.py
Service: virtual-machines
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

CRP will not re-provision the extension if the configuration has not changed, to overturn this behavior , make sure you supply the argument of  --force-update

please activate the issue if the flag doesn't help


Tree node menu issue on mouse hover

Observed after #335 - fancytree wide is being used.

Assigning to @rka12

Setting z-index =0 for span.fancytree-title in inspect element works. But doesnt work when set through css or js.

Fixed in PR #339


dev-cmd/rubocop: use bundle check.

It's not reliable enough to just check for the binary.

Review period skipped due to critical label.


Full transparency

hello @willeastcott,
as you asked, I just opened a new request for full transparency for hide.

This was fixed in #258. Should be released this week sometime.


Fix JSONAPI::PathSegment::Relationship#eql?

Relationship objects are used as key in @join_details in JoinManager . This hash contains two types of objects: String and Relationship. In case of hash collisions in @join_details the method Relationship#eql? is called. It currently fails when comparing with a string key.
Fixes #1333
All Submissions:

[x] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[x] I've submitted a ticket for my issue if one did not already exist.
[x] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[x] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

[x] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:
There's no reliable way to test for hash collisions. It would be possible to specifically test for Relationship#eql?("") . Shall I add such a test?
Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

This bug has been biting me bad lately and it's really hard to reproduce. Going to merge your PR into my branch and ship it out.

@larskanis Thanks for finding and fixing that

@larskanis Thanks for finding and fixing that

I ran into this today after upgrading from ruby 2.5.3 to 2.7.2. Looking at the fix I can't figure out how this would be related to the version upgrade, and never came across this before.
Does anyone know if this is a bug specific to 2.7? Or is it just really unlikely?

In my experience chasing this particular bug, it's presented itself so sporadically that it was quite the chore chasing down. @larskanis was the only other person I found and he managed to create a failing test and his methodology was the only one that could prove it's existence.

I looked through the source and it doesn't seem like this ever made it into an official release? Is this fix the same as #1368 ?
Confused why this is in the master branch, but the merge commit doesn't show up in the list of commits for v0.10.7

Hi @lgebhardt ! Will this fix be included to the next release? We still facing the issue on 0.10.4 in production.

@mikhaillopandia Thanks for the reminder. I'll get this merged into the v0.10 branch and see if I can get a release out this week.


[Request] Restore MSAA feature from AI 1

Would it be possible to force MSAA , which was a feature in AI 1? Trying to force AA through NVIDIA profile inspector doesn't appear to work.

So I've had a look in to this and the game does appear to be forward rendered (like the first game) which should allow MSAA. However, it seems to be disabled for the build and I haven't had any luck changing it yet. I'll keep looking in to it though as it should technically be possible.

yep msaa can be enabled, its not a clean patch yet

the remaining issues are xray and outlines dont work properly

atm, until i can figure a way to edit the renderpipeline itself / the shaders, its falling back to SMAA when its rendering xray / outlines


Bug: auto registration not working for appsec

Not sure if it's a missconfiguration or an actual bug, however appsec autoregistration fails all the time and i have to manually validate it via cscli.
The issue is that being a deployment, every time a new pod is created it needs to be revalidated manually. Is this the desired behaviour or a bug?
This is the log I get

│ time="2024-11-24T16:55:04Z" level=fatal msg="unable to start crowdsec routines: authenticate watcher (security-crowdsec-appsec-b8ff487bd-kjl4z): API error: machine security-crowdsec-appsec-b8ff487bd-kjl4z not validated"

My values.yaml
    container_runtime: containerd
    agent:
      acquisition:
        - namespace: network
          podName: traefik-*
          program: traefik
          poll_without_inotify: true
        - namespace: authentik
          podName: authentik-*
          program: authentik
          poll_without_inotify: true
        - namespace: homeassistant
          podName: homeassistant-*
          program: home-assistant
          poll_without_inotify: true
      metrics:
        enabled: true
        serviceMonitor:
          enabled: true
          additionalLabels:
            app.kubernetes.io/component: monitoring
      env:
        - name: PARSERS
          value: "crowdsecurity/cri-logs crowdsecurity/whitelists"
        - name: COLLECTIONS
          value: "crowdsecurity/linux crowdsecurity/traefik crowdsecurity/home-assistant firix/authentik"

    lapi:
      metrics:
        enabled: true
        serviceMonitor:
          enabled: true
          additionalLabels:
            app.kubernetes.io/component: monitoring
      env:
        - name: ENROLL_KEY
          value: "<enroll key>"
        - name: ENROLL_INSTANCE_NAME
          value: "..."
        - name: ENROLL_TAGS
          value: "..."
        - name: BOUNCER_KEY_traefik
          value: "..."

    appsec:
      enabled: true
      acquisitions:
        - source: appsec
          listen_addr: "<IP_ADDRESS>:7422"
          path: /
          appsec_config: crowdsecurity/appsec-default
          labels:
            type: appsec
      env:
        - name: COLLECTIONS
          value: "crowdsecurity/appsec-virtual-patching crowdsecurity/appsec-generic-rules"
        - name: APPSEC_CONFIGS
          value: "crowdsecurity/appsec-default"

I can see that the secret  crowdsec-lapi-secrets exists and it's attached to the pod, and the wait-for-lapi-and-register job succeeds and registers appsec with the local LAPI
level=info msg="Successfully registered to Local API (LAPI)"
level=info msg="Local API credentials written to '/etc/crowdsec/local_api_credentials.yaml'"
level=warning msg="Run 'sudo systemctl reload crowdsec' for the new configuration to be effective."

However cscli machine list shows it as not validated
security-crowdsec-lapi-69668bb5db-6cngc:/# cscli machine list
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Name                                              IP Address   Last Update           Status  Version                 OS                            Auth Type  Last Heartbeat
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 ...
 security-crowdsec-appsec-b8ff487bd-kjl4z          <IP_ADDRESS>   2024-11-24T16:54:59Z  🚫                              ?                             password   ⚠ -
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Hello,
This is actually a documentation issue :(
You need to add the following to your values (assuming your cluster is using the <IP_ADDRESS>/8 IP range):
lapi:
  config.yaml.local: |
    api:
      server:
        auto_registration:
          enabled: true
          token: "${REGISTRATION_TOKEN}" # /!\ Do not modify this variable (auto-generated and handled by the chart)
          allowed_ranges:
            - "<IP_ADDRESS>/8"

You can find the documentation for the auto validation feature here
When this config is set, the appsec will be able to register automatically to LAPI (you might need to delete the appsec pod after applying the change to force k8s to deploy a new version of the pod with the proper env variables)

I even saw this here https://github.com/crowdsecurity/helm-charts/pull/189/files#diff-46edd849e7dd696fb564f53733767c38e644bb97db91ad180254b66f4031248dR98 but thought it wasn't needed anymore as it wasn't in the README anymore...
Thanks a lot!
For future reference, if someone stumbles across this issue in the future AND uses FluxCD's HelmRelease, the variable needs to be escaped with an extra $
lapi:
  config.yaml.local: |
    api:
      server:
        auto_registration:
          enabled: true
          token: "$${REGISTRATION_TOKEN}" # /!\ Do not modify this variable (auto-generated and handled by the chart)
          allowed_ranges:
            - "<IP_ADDRESS>/8"

I use HelmRelease and:

double $$ actually caused msg="Auto-register failed: invalid token for auto registration" ip=<IP_ADDRESS> machine_id=crowdsec-agent-rgp52
config.yaml.local should be under config:, not lapi:


Needs some documentation

You should eithor remove 'node-red' from the keywords or document the node

The node is very straightforward, what documentation do you want to see ?

Maybe an example flow and more explaination. The readme says

a screenshot of the host

the editor? all screens that are open? the dashboard? What do you send to it? The flow in the example didn't do anything except throw an error
11/14/2019, 8:31:35 AMnode: 48a2e0f6.bde18
msg : error
error
Error: Command failed: import -silent -window root jpeg:-
/bin/sh: 1: import: not found
so I have to disagree that it is straight forward.

Did you look at the Node's help ?
A Node that takes a screenshot of the host and outputs it as a Buffer.
Send any input to the node to take the screenshot.
The error however is not normal and to troubleshoot I will need more info,
what version of Node-Red are you using? What os ?
Le jeu. 14 nov. 2019, à 08 h 33, juggledad<EMAIL_ADDRESS>a
écrit :

Maybe an example flow and more explaination. The readme says
a screenshot of the host
the editor? all screens that are open? the dashboard? What do you send to
it? The flow in the example didn't do anything except throw an error
11/14/2019, 8:31:35 AMnode: 48a2e0f6.bde18
msg : error
error
Error: Command failed: import -silent -window root jpeg:-
/bin/sh: 1: import: not found
so I have to disagree that it is straight forward.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/natcl/node-red-contrib-screenshot/issues/1?email_source=notifications&email_token=AAAS55FB4QWBFGH6BMTAYALQTVHQVA5CNFSM4JNJFPW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEB24LA#issuecomment-553889324,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAS55F63XZVJZL5QBFMPA3QTVHQVANCNFSM4JNJFPWQ
.

Did you look at the Node's help ?

If you mean the "Help" section in the info tab - yes - it says

A Node that takes a screenshot of the host and outputs it as a Buffer.
Send any input to the node to take the screenshot.
So I copied your sample flow and run it and get the error

Node-red v1.0.2
Node.js  v10.15.3
Rpi running stretch
So I am using safari on a mac to access NR running on the pi. The pi runs stretch-lite so there is no GUI. I open a browser window on the Mac and enter http://<IP_ADDRESS>::1880/image and the error occurs.

The error is because imagemagick isn't installed @juggledad. Probably worth updating the readme with dependencies!


Custom Spawns module broken

Using custom spawns always results in the error thrown: "Couldn't find a valid spawn set-up file for ns2_summit, disabling the plug-in for now"
The problem persists even when Shine Ex has generated a new spawn file, using the default values.

Fixed with https://github.com/GhoulofGSG9/ShineExtraPlugins/commit/12d75c56f0c3814871587d61f378340f37ee0fcd


@ngtools/webpack - enable sourceMap generates different build

@ngtools/webpack produces different javascript output if you toggle the sourceMap setting. With source maps enabled, the compiler seems to include imports, that shouldn't be there.
Angular: 8.0.0 (but issue is present in 7.2.x as well)
Reproduction: https://github.com/sod/issue-ngtools-14617
Compare both dist-* folders. The only difference in the build is the --source-map flag. In one build the chunk big-dependency is missing and was inlined by webpack.
You can try to build it yourself with either one:
ng build --prod --aot --build-optimizer --source-map
ng build --prod --aot --build-optimizer

If you watch the output with --source-map of the ngtools/webpack loader in https://github.com/angular/angular-cli/blob/master/packages/ngtools/webpack/src/loader.ts#L104, I see for the file https://github.com/sod/issue-ngtools-14617/blob/master/src/app/lorem/lorem.service.ts this output:
import { BigDependencyOptions } from 'src/app/lorem/big-dependency';
import * as i0 from "@angular/core";
var bigDependencyLoader = function () { return import(/* webpackChunkName: "big-dependency" */ '../lorem/big-dependency'); };
var ɵ0 = bigDependencyLoader;
var LoremService = /** @class */ (function () {
    function LoremService() {
    }
    LoremService.prototype.load = function (options) {
        return bigDependencyLoader().then(function (m) { return new m.BigDependency().setOptions(options); });
    };
    LoremService.ngInjectableDef = i0.ɵɵdefineInjectable({ factory: function LoremService_Factory() { return new LoremService(); }, token: LoremService, providedIn: "root" });
    return LoremService;
}());
export { LoremService };
export { ɵ0 };

BigDependencyOptions is an Interface and only used as a type, that import should not be visible in javascript. If you throw the source into typescriptlang, you see that tsc wouldn't include that import as well.
We use an error reporting tool where we can upload the source maps to get better reports. But this behavior increases our build by ~100kb so we compile without source maps right now.

Reproduction: https://github.com/sod/issue-ngtools-14617
Compare both dist-* folders. The only difference in the build is the --source-map flag. In one build the chunk big-dependency is missing and was inlined by webpack.
The reproduction doesn't reflect the issue we got, but it at least shows that just turning source map on/off alters the build output, whereas I'd assume that the builds should be identical, with either source maps on or off.

This seems unintended. I'm not sure why that would change... if you're interested in looking at this bug, I expect https://github.com/angular/angular-cli/blob/master/packages/ngtools/webpack/src/angular_compiler_plugin.ts is the right place.

I'm investigating this problem but I am a bit confused by your report and repro.
lorem.service.ts is part of a lazy chunk and looks like this:
import {BigDependency, BigDependencyOptions} from 'src/app/lorem/big-dependency';
import {Injectable} from '@angular/core';

const bigDependencyLoader = () => import(/* webpackChunkName: "big-dependency" */'../lorem/big-dependency');

@Injectable({providedIn: 'root'})
export class LoremService {
    load(options: BigDependencyOptions): Promise<any> {
        return bigDependencyLoader().then((m: {BigDependency}) => new m.BigDependency().setOptions(options));
    }
}

You have both a static import to big-dependency:
import {BigDependency, BigDependencyOptions} from 'src/app/lorem/big-dependency';

and a dynamic import:
const bigDependencyLoader = () => import(/* webpackChunkName: "big-dependency" */'../lorem/big-dependency');

You expect the direct import to be removed because BigDependencyOptions is an interface and also because BigDependency is unused.
In dist-with-source-map-true we can see the big-dependency.b63b360e949b2fda8373.js chunk. This means that the static import was removed, and only the dynamic import remained, otherwise there would be no lazy chunk.
In dist-with-source-map-false there is no big-dependency.b63b360e949b2fda8373.js chunk. Instead, it's contents are rolled into the other lazy chunk, 5.abbe2b336002b205b922.js. You can verify that is true because 5.abbe2b336002b205b922.js contains two results setOptions: one for the BigDependency class definition and one for it's invocation in LoremService. In dist-with-source-map-true those two results for setOptions are split among the two lazy chunks instead.
So at this point I can see that setting source-maps to false prevents a lazy chunk from being generated.
Yes this looks like a weird problem. But it doesn't impact total bundle size. You mention that this bug increases your build size by ~100kb but I am not seeing that here. What I see instead is that the contents of a lazy chunk were inlined in another chunk. So same total size, but different distribution.
What also confuses me is that you say that you have to disable sourcemaps. But disabling sourcemaps is what causes the inlining. According to this repo, I expected you to have to enable sourcemaps in order to actually have a lazy loaded chunk.
I'll continue looking into why there's a difference of behaviour regardless.

https://github.com/angular/angular-cli/pull/16085 should fix this.
What happened was this:

we remove angular decorators as a transformation to speed up builds by removing unneeded symbols
when a transform removes references, TS doesn't know it should remove their imports
thus we manually add a pass to remove imports whenever we remove or modify nodes
in this example our import removing pass identified both BigDependency and import {Injectable} from '@angular/core; for removal
removing BigDependency altered the original import {BigDependency, BigDependencyOptions} from 'src/app/lorem/big-dependency'; and caused TypeScript to not identify BigDependencyOptions for removal anymore.

Now we correctly identify type references as not being a usage for an import, for eliding purposes.

nice, thank you :)


Could NOT find ODBC (missing: ODBC_LIBRARY ODBC_INCLUDE_DIR)

I am not much experienced with C++, but I am trying to build this wrapper for GDAL to include access to SAP HANA (https://gdal.org/drivers/vector/hana.html)
I am trying to compile it on
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
but running into Could NOT find ODBC (missing: ODBC_LIBRARY ODBC_INCLUDE_DIR):
# cmake ..
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find ODBC (missing: ODBC_LIBRARY ODBC_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.16/Modules/FindODBC.cmake:198 (find_package_handle_standard_args)
  CMakeLists.txt:7 (FIND_PACKAGE)

-- Configuring incomplete, errors occurred!
See also "/root/odbc-cpp-wrapper/build/CMakeFiles/CMakeOutput.log".

I have unixodbc installed:
# apt info unixodbc
Package: unixodbc
Version: 2.3.6-0.1build1
Priority: optional
Section: universe/libs
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: Steve Langasek<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 108 kB
Depends: libc6 (>= 2.14), libodbc1 (>= 2.3.1), libreadline8 (>= 6.0), odbcinst1debian2 (>= 2.3.1)
Homepage: http://www.unixodbc.org/
Download-Size: 24.6 kB
APT-Manual-Installed: yes
APT-Sources: http://archive.ubuntu.com/ubuntu focal/universe amd64 Packages
Description: Basic ODBC tools

What else might I miss?

It seems you miss a dev package that includes required header files.
Please install the dev package as given here.


RLN: fix proof generation/verification and E2E tests (WIP)

This WIP PR addresses https://github.com/vacp2p/zerokit/issues/16 solving previous issues with proving and verifying keys import, proof generation/verification, RLN witness fields, etc. It further removes some unnecessary crates.
In progress: cleaning code from unnencessary imports, functions, etc., previously used for tests.

@oskarth As we already discussed, this implementation comes from implementing from scratch RLN using semaphore primitives for Merkle tree and Poseidon hash and checking outputs at each step against zk-kit RLN. Then I integrated only the required code to make test_end_to_end pass and now I'll proceed with eliminating the unnecessary parts.
Thus regarding the consistency of the outputs generated, I cannot guarantee if there are differences or not, since I didn't check the output of current master, since RLN was already failing.
In general the main changes/fixes were about:

Import of ZKEYs was somehow faulty. It is interesting that with previous import function a ZKEY was correctly imported and a proof computed, but then the verification always failed, even with a good input which passes verify when the zkey is randomly populated.
Even when a ZKEY was correctly imported with the above fix (that is that passes verify over a good input), the implemented proof function create_proof_with_reduction_and_matrices seemed to fail with the matrices generated from read_zkey. It is still unclear to me what is the reason, but I suspect that the circom builder does some backend work by itself and create_random_proof_with_reduction was enough. This made random proofs created with imported proving ZKEY correctly verified.
The rest are utility functions to import verification keys from JSON (useful for nodes to verify proofs with no need to have a proving key), verify them against proving keys (if present), and prepare RLN witnesses from JSON or by passing each fields.
Other minor changes;

Note that this version already has cargo clippy; cargo fmt applied. I'll pipe these with cargo build/run so that are applied automatically.

Note that this version already has cargo clippy; cargo fmt applied. I'll pipe these with cargo build/run so that are applied automatically.

Oops my bad, I accidentally ended up reviewing a previous chunk.
Let me know ready for review and we can merge it

@oskarth ready for review. I need to think a bit more on the C APIs, so I will update them in a followup issue.

Once test/lint succeeds and you are happy with it, feel free to merge. Then we can open smaller PRs for specific improvements.

Thanks @oskarth ! There are some other improvements implemented in this PR, which I would like to keep track of here:

I standardized all primitives to work with semaphore's Field type, a wrapper over U256;
Added some utility conversion from/to bytes, (bn254) Fr, and Field.
Arithmetic over Field element is done in arkworks algebra by mapping elements to Fr and doing operation there efficiently.
Added procedure to generate circuit's public inputs/outputs (e.g., x and y shares, nullifier, tree root, etc.) from witness. These values are stored in a new serializable struct called RLNProofValues which is passed to verify_proof.

These changes go towards https://github.com/vacp2p/zerokit/issues/19.


using Base64 img

I need to use your API with a base64 OR ImgUrl string to remove background images.
Can you do implement this option in your API?

Hi Alexandre, thanks for your report, this has been added to 1.1.2, please upgrade your current version.
<EMAIL_ADDRESS>


File Length Distribution

It would be great to have a "file length distribution" diagram of a project, similar to the attached photo from "Clean Code"
.
The sticks show the range from the minimum file length to the maximum file length. The box on a stick shows the third of all the files from the mean.

Can we use the LOC analyzer for this? It creates LOC metrics by file and we're saving the file ending to each metric. So if we use the LOC analyzer with a wildcard pattern so it analyzes every file type we should be able to get all LOC metrics for a specific file type. On this set of values we should be able to create a box plot.


Call conduit with JSON params

This will allow us to pass more complex objects, which is a requirement for
passing lint/unit results.

@jjx

Tested manually on my local Phabricator instance. @jjx does Java have something like VCR where I can record requests against a "real" Phabricator API and check in the responses as flat files for future replaying / "integration" tests?

Maybe http://freeside.co/betamax?

:dancers:

Cool, I will look at that in a future diff


Add version to file comments

the plugin version should be included in the css and js file, like in jquery, Bootstrap etc.

There is already a PR for this issue in #1185 the version will be added in the comments of the js/css files and in #1205 there will be a version added to the datepicker object itself


Automatically Unloading Worlds

Hi, Multiverse has been unloading my plotworld and spawn area everytime theres no players in them, ill restart, and the worlds load in fine, but 5 minutes later.. poof unloaded.
and I get this from the console.
[17:29:29 INFO]: [Multiverse-Core] World 'PlotWorld' was unloaded from memory.

I have this same issue.
Imported my old minigame world, working fine but when there is no players there the world unloads. and need to be unloaded with /mv load.

Oh thanks. I already fixed it though by just doing some console stuff...
Don't really remember. Thanks
http://bit.ly/BarbaqSmash
On Thu, Nov 16, 2017 at 6:00 PM, HePezi<EMAIL_ADDRESS>wrote:

I have this same issue.
Imported my old minigame world, working fine but when there is no players
there the world unloads. and need to be unloaded with /mv load.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Multiverse/Multiverse-Core/issues/1826#issuecomment-345090681,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa5O6kkwwZkrZ8NhaFRxdqXPZQGgTSRpks5s3L5zgaJpZM4N-1ZC
.


fix: use colIdx on header to override pseudo dim width

Since the overrideIndex for pseudo dim is -1, we need to look at the colIdx on the header, not the index for the array

LGTM not sure I fully understood the issue tho

overrideIndex === collIdx was never true for pseudo dim, since it colIdx is the itterator of the array, so it is always > -1

:tada: This PR is included in version 2.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Connector Admin CLI guide

Remove connector related contents from Pulsar admin CLI guide
Add an independent guide: Connector Admin CLI

@sijie could you please help review? Thank you

@tuteng please review this.

@tuteng thanks for your advice, I've incorporated your comments, PTAL.


python37Packages.telethon: 1.6.2 -> 1.8.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-telethon/versions.
meta.description for python37Packages.telethon is: '"Full-featured Telegram client library for Python 3"'.
meta.homepage for python37Packages.telethon is: '"https://github.com/LonamiWebs/Telethon"

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.8.0 with grep in /nix/store/1n19mzk00ciqqmhkdwmyr05xdq21im7v-python3.7-telethon-1.8.0
directory tree listing: https://gist.github.com/8e2315c0dadac67ac280b44e21352564
du listing: https://gist.github.com/c2c311314206be91d2205c8940baf3a8

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
mautrix-telegram
python37Packages.telethon

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1n19mzk00ciqqmhkdwmyr05xdq21im7v-python3.7-telethon-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python37Packages.telethon https://github.com/r-ryantm/nixpkgs/archive/1ce5b7a23812d3961a8f680ec5e415acc9d2bfd7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1n19mzk00ciqqmhkdwmyr05xdq21im7v-python3.7-telethon-1.8.0
ls -la /nix/store/1n19mzk00ciqqmhkdwmyr05xdq21im7v-python3.7-telethon-1.8.0/bin

cc @nyanloutre for testing.

I'm upgrading it here #63947

Closing in favor of #63947


Error on git clone BodyHands_private

Thanks for your interest in our work. I hope you could clone the repository successfully. If not, please download the repository as a zip file.

I have the same issue, and cannot find this repository in order to download as zip file.


CB-21839 Basic secret rotation flow

See detailed description in the commit message.

waiting for https://github.com/hortonworks/cloudbreak/pull/14870

rebased, added forgotten entitlement check


requirements.txt outdated?

Hello,
most of the packages in the requirements.txt seem to not exist anymore. Do you have an updated version perhaps?

Sorry, this seems to be an issue with conda. The requirements.txt works fine in a normal python venv.


enable fortify failure

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-5624
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

https://tools.hmcts.net/jira/browse/CCD-5624 status is Awaiting QA


Application breaks after update to 5.1.2

console warning says:
Use shouldComponentUpdate in an observer based component breaks the behavior of observer and might lead to unexpected results. Manually implementing sCU should not be needed when using mobx-react.
After upgrading to latest from 5.0.0. Why?

Check #417


release GHA: upload files in release-artifacts

release dir was renamed to release-artifacts

Signed-off-by: Arko Dasgupta<EMAIL_ADDRESS>

Codecov Report

Merging #315 (6ef609c) into main (626ad42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   58.19%   58.19%
=======================================
  Files          31       31
  Lines        2837     2837
=======================================
  Hits         1651     1651
  Misses       1087     1087
  Partials       99       99

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: port cve fixes to v1.8

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:
ports CVE fix to v1.8
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

/retest-required

/retest-required

/retest-required

/retest-required


docker cp nests directories, instead of merging

Description
When issuing docker cp twice in the same directory, the effect is that the dir is not copied over the old one, but rather it's nested.
Steps to reproduce the issue:

docker cp friendly_shaw:/wanderio/build/client/ client/
ls client

ai_ja_nai@aiMacBookPro:~/wanderio-devops/aws/elasticbeanstalkStagingCloner-Frontend$ ls client/
fileA fileB

docker cp friendly_shaw:/wanderio/build/client/ client/ (repeact exactly previous command)
ls client

ai_ja_nai@aiMacBookPro:~/wanderio-devops/aws/elasticbeanstalkStagingCloner-Frontend$ ls client/
fileA fileB client

Describe the results you received:
Now the dir client has been included in the one previously copied
Describe the results you expected:
I expected the dir client was just merged (existing files overwritten and new ones added). Particularly, I expected that trailing slashes were honored.
Output of docker version:
Client:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:50:14 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:50:14 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 2
 Running: 0
 Paused: 0
 Stopped: 2
Images: 68
Server Version: 1.13.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 154
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: 949e6fa
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-64-generic
Operating System: Ubuntu 16.04.2 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.707 GiB
Name: aiMacBookPro
ID: BEFQ:LYRP:E22V:X3WB:5EMX:34AB:OPFP:7ITH:YAPQ:KGQD:I5RM:ORLT
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
It happens both on AWS and on my laptop.
Thanks

I think this is the expected behavior, but it can be tricky to get it right, see: https://github.com/docker/docker/blob/52df69f00d966904ba230dc2e3a0646cc52b7688/docs/reference/commandline/cp.md;
Assuming a path separator of /, a first argument of SRC_PATH and second
argument of DEST_PATH, the behavior is as follows:

SRC_PATH specifies a file

DEST_PATH does not exist

the file is saved to a file created at DEST_PATH

DEST_PATH does not exist and ends with /

Error condition: the destination directory must exist.

DEST_PATH exists and is a file

the destination is overwritten with the source file's contents

DEST_PATH exists and is a directory

the file is copied into this directory using the basename from
SRC_PATH

SRC_PATH specifies a directory

DEST_PATH does not exist

DEST_PATH is created as a directory and the contents of the source
directory are copied into this directory

DEST_PATH exists and is a file

Error condition: cannot copy a directory to a file

DEST_PATH exists and is a directory

SRC_PATH does not end with /. (that is: slash followed by dot)

the source directory is copied into this directory

SRC_PATH does end with /. (that is: slash followed by dot)

the content of the source directory is copied into this
directory

In your case

DEST_PATH exists, and is a directory
SRC_PATH does not end with /.  (slash followed by dot)

So, the source directory is copied into this directory
From the description, changing this to
docker cp friendly_shaw:/wanderio/build/client/. client/

Should probably give the expected result, but let me know if that doesn't resolve the issue

First of all, thanks for the prompt support.
It works.
My mistake was not consulting the manpage, where I would have found all the above, but just the --help section of the command.
Closing.

Good to hear it worked!


Cannot use class methods

When I add class methods as route handlers:
class TestClass(object):
    async def hello(self, request):
        return request.Response(json=dict(aaa=2))
app = Application()

app.router.add_route('/json2', TestClass().hello)

I get error:
TypeError: hello() missing 1 required positional argument: 'request'
Is it possible to use async class methods at all?
Or maybe I have done something wrong?

I have the same problem too

I have the same problem too. Looks like when hello is an async method, Japronto won't accept self as the first argument. It only runs correctly when request is the first argument**, which feels wrong


[BEAM-1558] add cloudera repository for flink runner deps

When building beam from source with a fresh local repository, the org.mortbay.jetty:jetty-util:jar:6.1.26.cloudera.4 dependency is not available in the repository list (the dependency is transitive via org.apache.flink:flink-java:jar:1.2.0).
This PR adds the cloudera repo matching the repo listed in flink 1.2.0 pom.xml, to follow convention of listing repositories containing the artifacts required for the build.

Coverage remained the same at 69.322% when pulling ba600375f2e25367f5a0979a684359600f7aed98 on tom-haines:BEAM-1558-add-cloudera into 4bba380cb011e38bd78c1ec899a6672a6b02fd05 on apache:master.

Coverage decreased (-0.01%) to 69.309% when pulling ba600375f2e25367f5a0979a684359600f7aed98 on tom-haines:BEAM-1558-add-cloudera into 4bba380cb011e38bd78c1ec899a6672a6b02fd05 on apache:master.

Thanks @tom-haines for pointing this out!
R: @davorbonaci, @aljoscha
@aljoscha, can you comment on the Flink's dependency on the Cloudera's patched release (version 6.1.26.cloudera.4)? Is this necessary? Can we override back to a version from Maven Central? Or use another dependency instead?

@davorbonaci I'm investigating

Yesterday, I commented on the Jira issue:
On my machine, when I run your command I get this
$ mvn -f runners/flink/runner/pom.xml dependency:tree -Dincludes="*:jetty-util"
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: osx
[INFO] os.detected.arch: x86_64
[INFO] os.detected.classifier: osx-x86_64
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache Beam :: Runners :: Flink :: Core 0.6.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.0.0:tree (default-cli) @ beam-runners-flink_2.10 ---
[INFO] org.apache.beam:beam-runners-flink_2.10:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.flink:flink-java:jar:1.2.0:compile
[INFO]    \- org.apache.flink:flink-shaded-hadoop2:jar:1.2.0:compile
[INFO]       \- org.mortbay.jetty:jetty-util:jar:6.1.26:compile

Having that shaded dependency there is still messy but it's not cloudera specific? Do you maybe have a custom-built Flink somewhere in your deps or something else Cloudera related in some of your settings?