Invalid device function on ROCm

Prerequisites
Please answer the following questions for yourself before submitting an issue.

[x] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
[x] I carefully followed the README.md.
[x] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
[x] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior
I tried to compile llama-cpp-python to run on my local machine, which has an RX 7900 XTX in it and runs Arch Linux. I have installed (to the best of my knowledge) all of the required packages for compiling this software. In the past, I've ran Oobabooga's default setup (using pyenv instead of Conda) using ROCm based GPU acceleration (verified, it does use ROCm hipBLAS and not OpenCL CLBLAS, it says so in the logs). This still works now, but I wanted to compile the package myself so I could use the latest version supporting Mixtral. That's when I discovered it doesn't work.
I expected the package to just compile, install and run without issues.
Current Behavior
I compile the package according to the instructions in the README, running CMAKE_ARGS="-DLLAMA_HIPBLAS=on" pip install llama-cpp-python and also setting CC=/opt/rocm/llvm/bin/clang and CXX=/opt/rocm/llvm/bin/clang++ to compile and install it. Then run it using Oobabooga's software, it doesn't work. Neither Mixtral nor any other gguf model works at that point.
What happens is that the webui starts and when I try to load a model using llama.cpp it works, even offloading some layers to the GPU works. However, when I try to generate anything I get the following error:
llama_new_context_with_model: n_ctx      = 2048
llama_new_context_with_model: freq_base  = 10000.0
llama_new_context_with_model: freq_scale = 1
llama_kv_cache_init: offloading v cache to GPU
llama_kv_cache_init: offloading k cache to GPU
llama_kv_cache_init: VRAM kv self = 44.00 MiB
llama_new_context_with_model: kv self size  =   44.00 MiB
llama_build_graph: non-view tensors processed: 510/510
llama_new_context_with_model: compute buffer total size = 147.07 MiB
llama_new_context_with_model: VRAM scratch buffer: 144.00 MiB
llama_new_context_with_model: total VRAM used: 1236.51 MiB (model: 1048.51 MiB, context: 188.00 MiB)
AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 |
2023-12-14 11:23:49 INFO:LOADER: llama.cpp
2023-12-14 11:23:49 INFO:TRUNCATION LENGTH: 2048
2023-12-14 11:23:49 INFO:INSTRUCTION TEMPLATE: Alpaca
2023-12-14 11:23:49 INFO:Loaded the model in 0.35 seconds.

CUDA error 98 at /tmp/pip-install-7tnzxpkb/llama-cpp-python_65cef98c297d463c84d58f07be341594/vendor/llama.cpp/ggml-cuda.cu:6951: invalid device function
current device: 0
/arrow/cpp/src/arrow/filesystem/s3fs.cc:2904:  arrow::fs::FinalizeS3 was not called even though S3 was initialized.  This could lead to a segmentation fault at exit

I am pretty sure that last line can be ignored, as it doesn't always show up and I believe isn't related to this project, however what concerns me more is the line before that.
I have tried to compile both the latest v0.2.23 version as well as the version currently used by Oobabooga, v0.2.19. Both result in exactly the same error about invalid device function.
Environment and Context
Sorry, I am remote right now and rebooted, but it's not coming back up. I will add a fully detailed spec list later, but I will add as much as I can right now.

Physical (or virtual) hardware you are using, e.g. for Linux:

CPU
Architecture:            x86_64
  CPU op-mode(s):        32-bit, 64-bit
  Address sizes:         43 bits physical, 48 bits virtual
  Byte Order:            Little Endian
CPU(s):                  48
  On-line CPU(s) list:   0-47
Vendor ID:               AuthenticAMD
  Model name:            AMD Ryzen Threadripper 3960X 24-Core Processor
    CPU family:          23
    Model:               49
    Thread(s) per core:  2
    Core(s) per socket:  24
    Socket(s):           1
    Stepping:            0
    Frequency boost:     enabled
    CPU(s) scaling MHz:  65%
    CPU max MHz:         3800.0000
    CPU min MHz:         2200.0000
    BogoMIPS:            7603.96
    Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc
                          cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalig
                         nsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2
                          cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin arat npt lb
                         rv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip rdpid overflow_recov succor smca sev sev_es
Virtualization features:
  Virtualization:        AMD-V
Caches (sum of all):
  L1d:                   768 KiB (24 instances)
  L1i:                   768 KiB (24 instances)
  L2:                    12 MiB (24 instances)
  L3:                    128 MiB (8 instances)
NUMA:
  NUMA node(s):          1
  NUMA node0 CPU(s):     0-47
Vulnerabilities:
  Gather data sampling:  Not affected
  Itlb multihit:         Not affected
  L1tf:                  Not affected
  Mds:                   Not affected
  Meltdown:              Not affected
  Mmio stale data:       Not affected
  Retbleed:              Mitigation; untrained return thunk; SMT enabled with STIBP protection
  Spec rstack overflow:  Mitigation; Safe RET
  Spec store bypass:     Mitigation; Speculative Store Bypass disabled via prctl
  Spectre v1:            Mitigation; usercopy/swapgs barriers and __user pointer sanitization
  Spectre v2:            Mitigation; Retpolines, IBPB conditional, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
  Srbds:                 Not affected
  Tsx async abort:       Not affected

Operating System, e.g. for Linux:

Arch Linux. Kernel version 6.6.6 (Maybe the devil is my issue :laughing:)

SDK version, e.g. for Linux:

python version 3.11.5
make 4.4.1
/opt/rocm/llvm/bin/clang++ --version --> clang version 17.0.0

Failure Information (for bugs)
Fails quite spectacularly sometimes. Doesn't always happen, but sometimes the screen of the PC will flash black for a minute and nvtop will keep reporting 100% GPU usage forever until a reboot is issued. This also breaks any future runs until a reboot is done.
Steps to Reproduce

Clone oobabooga text-generation-webui and follow the installation instructions for AMD with AVX2.
Run pip uninstall llama-cpp-python and pip uninstall llama-cpp-python-cuda to uninstall the versions that came with Ooba.
Run CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" CMAKE_ARGS="-DLLAMA_HIPBLAS=on" pip install llama-cpp-python to install the latest version or install v0.2.19, which verified works on Ooba.
Run Ooba normally, load a gguf model with some layers offloaded to the GPU.
Try to generate anything
Check logs, cuz it just broke.

It should be noted that this exact thing also happens with the original llama.cpp program, but this one breaks my computer way less. llama.cpp always messes up the entire GPU driver, preventing even just loading any of models until a reboot is issued.
Failure Logs
Already provides above.

you need to specify your gpu architecture while building. see llama.cpp readme, unde hipblas it tells you how to select your specific gpu architecture

Tried that already, doesn't work. I ran export AMDGPU_TARGETS=gfx1100 before running CMAKE_ARGS="-DLLAMA_HIPBLAS=on" pip install llama-cpp-python --upgrade --no-cache-dir --force-reinstall and it produced about the same results:
llama_new_context_with_model: n_ctx      = 32768
llama_new_context_with_model: freq_base  = 10000.0
llama_new_context_with_model: freq_scale = 1
llama_new_context_with_model: KV self size  = 4096.00 MiB, K (f16): 2048.00 MiB, V (f16): 2048.00 MiB
llama_build_graph: non-view tensors processed: 676/676
llama_new_context_with_model: compute buffer total size = 2139.32 MiB
llama_new_context_with_model: VRAM scratch buffer: 2136.00 MiB
llama_new_context_with_model: total VRAM used: 6943.06 MiB (model: 4807.05 MiB, context: 2136.00 MiB)
AVX = 1 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 |
2023-12-14 19:31:01 INFO:LOADER: llama.cpp
2023-12-14 19:31:01 INFO:TRUNCATION LENGTH: 32768
2023-12-14 19:31:01 INFO:INSTRUCTION TEMPLATE: Mistral
2023-12-14 19:31:01 INFO:Loaded the model in 3.41 seconds.

CUDA error 98 at /tmp/pip-install-d9j8vt1_/llama-cpp-python_f434b6fed78941cbb1ce642d6a511ebb/vendor/llama.cpp/ggml-cuda.cu:7788: invalid device function
current device: 0
GGML_ASSERT: /tmp/pip-install-d9j8vt1_/llama-cpp-python_f434b6fed78941cbb1ce642d6a511ebb/vendor/llama.cpp/ggml-cuda.cu:7788: !"CUDA error"
ptrace: Operation not permitted.
No stack.
The program is not being run.
 It generates stuff now. However, it doesn't really generate all that nicely. When I have to reload the prompt data it seems, it messes up and just generates completely random stuff. This happens with any model, I tested both the older Mistral 7B instruct v0.1 and the new Mixtral.

I have to unload and reload the model for it to work again. This is a huge step forward tho.

i have the same issue. i thought it's just that my gpu isn't supported.
i do get this only in chat mode though.

i have the same issue. i thought it's just that my gpu isn't supported. i do get this only in chat mode though.

I notice this happens only when I give it a prompt that is too long. Happens in both chat and the default/notebook when the prompt is too long. Very weird actually

does this happen with regular llama.cpp?

I get normal working results when I set the context size to anything <32768!

i think this is a bug in llama.cpp itself. i made an issue there.

@SuperPou1 is this still an issue with the latest release, I saw a few HIPBLAS / ROCm related fix commits recently in llama.cpp

I don't think this still happens. I was able to compile and run now.


feat: add links in connect wallet details

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

/release-pr

/release-pr


ConnectionError is missleading

ConnectionError is documented as the error that can be thrown by the client. However it is not very well documented that it is actually requests.exceptions.ConnectionError and not builtins.ConnectionError. Further more ConnectionError does not include any timeout errors.
Replace ConnectionError with RequestException as the more general exception.

should be solved using weaviate.ConnectionError now, which is just an alias for requests.ConnectionError.


Will this page be updated? Some aspects seem out of date with current D365 Finance and Operations

For instance Step 11 instructs us to 'Select the Unified Operations template'.  I think now we would select Finance and Operations, as I can't find Unified Operations in the 'Create a new project' dialog box.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 71438101-e8d0-6636-a397-64b039c85a39
Version Independent ID: 9db6265c-437c-75d2-be92-131273a8ca56
Content: Create models and data model elements overview - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/dev-tools/create-data-model-elements.md
Service: dynamics-365-cross-app
GitHub Login: @gianugo
Microsoft Alias: gianura

Bug 803364 has been logged to address this issue.


Drop libapparmor dependency from build docs

As of opencontainers/runc@db093f6 runc no longer depends on libapparmor
thus libapparmor-dev no longer needs to be installed to build it or
anythind that depends on it (like cri-o). Adjust the documentation
accordingly.
Signed-off-by: Tobias Klauser<EMAIL_ADDRESS>

/ok-to-test

/test all

LGTM


Integration with Nuxt Image for built in image optimization

Description
For elements like UAvatar that use images, it would be a good idea to integrate with Nuxt Image for those who have it installed to benefit from image optimizations like setting image format, applying modifiers, and all the other features that Nuxt Image offers.
Additional context
No response

You can already do this using the as prop of the Avatar component:
<script setup>
const NuxtImg = resolveComponent('NuxtImg')
</script>

<template>
  <UAvatar src="https://github.com/benjamincanac.png" :as="NuxtImg" />
</template>

@benjamincanac
My apologies if it seemed as a duplicate, my suggestion was more so meant for automatic detection and usage of NuxtImg, not just plain capability. It would be a nice DX improvement in my opinion as it would simplify pages with a lot of avatar/other image elements.

@GalacticHypernova Indeed, we could automatically use <NuxtImg> if installed. We can't do it yet in v3 because of nuxt/ui#2141, we'll have to wait for a fix in Radix Vue first.


Status returning null, why?

Got the following object while trying to catch a pokémon: { Status: null, MissPercent: null }

same: +1


Bugfix: jmeter maven reactor fix

Codecov Report

Merging #426 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #426   +/-   ##
========================================
  Coverage      99.7%   99.7%
  Complexity     1013    1013
========================================
  Files           162     162
  Lines          3376    3376
  Branches        184     184
========================================
  Hits           3366    3366
  Partials         10      10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c8ea6...021b79b. Read the comment docs.


Scenarios - Scenario options

Figma prototype status

User story
As a policymaker, I want to explore various dietary change scenarios so I can make evidence-based recommendations.
Summary
The card will allow you to toggle between:

Food item composition
Food item consumption
Food item comparison

The scenario details are addressed in separate issues.
Figma prototype
Location
Diet Data > Explore Simple dietary change scenarios
Part of scenarios page:
#499
Scenario options:

Composition #506
Change #507
Comparison #508

Reference

Other Scenarios issues

Acceptance criteria

[ ] You can toggle between different scenarios

@bgsandan  Are these controls to have query linked params that allow pre-population from a link?

If we can make it sensibly work it would be nice please 😊

When switching between these options, will the previously selected food items stay selected?

As in stay selected so you could switch back to a previous option and see your previous selection?
I'm happy for switching between the different modes "Composition", "Consumption", "Food Item" to wipe out the previous selection so when you switch mode you get a fresh empty selection (ideally with an 'are you sure you want to do this' type dialog/warning first).  I assume that would still be simpler than trying to maintain/store all permutations?
Given that if params are part of the URL a user could save/share a scenario to get back to it, don't think they need to persist between mode changes.
Happy to hear other thoughts/opinions though :smile:

The "food items" are consistent between the three modes, so we could keep them, but persisting those without the values might seem inconsistent.
That would mean it's all or nothing, and if you're happy with nothing (initially), then so am I. :-)

I agree with Andy that some warning message would be useful in case the selection gets deleted. If somebody adds more than 10 items and then loses their progress, that could be frustrating :)
If we have an option to save a URL with query params, we could add "Bookmark scenario" button next to "Share Page".

We'll probably need to alert on changing the option and have a "canDeactivate" route guard too then.

I agree with Andy that some warning message would be useful in case the selection gets deleted. If somebody adds more than 10 items and then loses their progress, that could be frustrating :)
If we have an option to save a URL with query params, we could add "Bookmark scenario" button next to "Share Page".

There's certainly the potential to frustratingly lose a lot of configuration there!
Is it not likely that they will want to change from "Composition" to "Consumption" with the same food items selected?

@LouiseAnder see above conversation - what are your thoughts on the likelihood of a user wanting to switch from "Composition" scenario to "Consumption" scenario and maintain the same list of food items?

this is a good question - I am also concerned that if we are allowing a large number of simultaneous changes we support the user diverging from anything vaguely realistic / achievable in a food system.  I tend to think that Andy's suggestion where they are (with prior warning) wiped, keeps it very clear what the user is altering too. Like that there is some URL/bookmark way of returning to scenarios though.
Not sure if this should be a separate issue, but will these permutations be captured somewhere on any downloadable output @bgsandan ?

Any idea how the API will deliver the food groups and items?  Will it be a single call for everything, given the micronutrient, with the response being an array of food groups with a nested food items?

Open for discussion/requests! Assuming that sort of structure works for you that is probably more efficient than a separate call to get the food items for each food group?

Open for discussion/requests! Assuming that sort of structure works for you that is probably more efficient than a separate call to get the food items for each food group?

Would this be dependant on anything or more like a dictionary call (no params).

Good question.  The food groups/food items probably more of dictionary. The call to get "current" value will need to pass either the consumption data source id or composition source id depending on the mode along with the selected fooditem. Make sense?

Good question. The food groups/food items probably more of dictionary. The call to get "current" value will need to pass either the consumption data source id or composition source id depending on the mode along with the selected fooditem. Make sense?

Might it make sense to have these "current" values as part of the "food item" object, as they're not going to change.

Ignore this.  :-)

I'm currently trying to get some api endpoints and mock data in for this.

Good question. The food groups/food items probably more of dictionary. The call to get "current" value will need to pass either the consumption data source id or composition source id depending on the mode along with the selected fooditem. Make sense?

Where are the consumption data source id and composition source ids obtained from?

The data-source endpoint called to populate the bottom select option in the sidebar.  e.g. https://devapi.micronutrient.support/data-source/ZAF/diet

The data-source endpoint called to populate the bottom select option in the sidebar. e.g. https://devapi.micronutrient.support/data-source/ZAF/diet

So they're not different things, just the data source id (as opposed to "consumption data source id" and "composition source id")?

Sorry, caused confusion yesterday with inaccurate terminology when typing on my phone!
In "Composition Change" mode, there will be an API to get the 'Current composition' value.  That will take as input the compositionDataId parameter from the above URL and an id for the fooditem selected e.g /diet/scenario/composition/?foodItem=123&compositionDataId=XYZ (url TBC)
In "Consumption Change" mode, there will be an API to get the 'Current consumption' value.  That will take as input the consumptionDataId parameter from the above URL and an id for the fooditem selected e.g /diet/scenario/consumption/?foodItem=123&consumptionDataId=XYZ (url TBC)
Is that clearer?  Happy to chat otherwise :)

@Sveouu It's probably not completely obvious from the conversations on this issue that this task really is just selecting the mode (consumption/composition/food item), and there are other issues for the options associated with those selections.
I hope I haven't confused matters too much by starting conversations here that should maybe have been on other issues.  I know that @Fuhji is looking at the composition options task #506, so I just wanted to ensure that there isn't any duplication of effort.

@bgsandan @pautva
Not really associated with this task but as it spans all three modes it seems the best place for it.
Can we tweak the UI for the options panel so that when you "Add Food Item" it makes the previously selected food items un-editable?
Otherwise updating the available options in all of the active selects will be complicated.  The scenario value can still be editable.

As in:

User selects a food item using the dropdowns
Tool loads the value for 'current consumption' (or composition etc)
User can then update the scenario values
At this point user can change the select box as it isn't 'locked in'
User clicks "Add Food item" to add another option
The select boxes for selection no. 1 are locked so they can't change that food item but can still edit the scenario value
Steps 2-4 apply to selection no. 2

?
In which case i think that is fine.
With multiple fooditems we may want to be able to delete/remove one of them though..  Happy to allow removing only the latest one (thus 'unlocking' the selection box for the previous item) if that is easier and fits with the above model though

Should be:

Steps 1-4 apply to selection no. 2

I don't see a problem with being able to remove any of the previous rows.
The "All" option will complicate matters, and will only be available if nothing from that group has previously been selected.

On the subject of the "ALL" option, I'm working on the assumption that that will need expanding to a full group of individual food item selections for the API call and that there won't be a shortcut way to send a group id instead.  Is that correct.

Sending a full group of id's will certainly work.  Though we could look at an endpoint that takes a group id if we think it would be useful

Sending a full group of id's will certainly work.  Though we could look at an endpoint that takes a group id if we think it would be useful

It would have to be the same endpoint since they might have selected item A from group 1 and All from group 2.
I'll still assume expanding the "ALL" to include all food item IDs.


Improve accessibility

Label announced. Aria attributes for readonly, invalid and required added.
Closes #48

This change is

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 316 at r1 (raw file):

          }

          var uniqueId = TextFieldElement._uniqueId = 1 + TextFieldElement._uniqueId || 0;

I would maintain the comment, so as the reader knows why, and also in order to remove this hack when there shadydom support disappears.

Comments from Reviewable

vaadin-text-field.html, line 316 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
I would maintain the comment, so as the reader knows why, and also in order to remove this hack when there shadydom support disappears.

I didn't just remove the comment but also removed the whole check for ShadyDOM. There's no reason to make this work differently in Shadow/Shady. Don't expect us to be able to drop shadydom support since we support IE11.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

vaadin-text-field.html, line 316 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
I didn't just remove the comment but also removed the whole check for ShadyDOM. There's no reason to make this work differently in Shadow/Shady. Don't expect us to be able to drop shadydom support since we support IE11.

Yes the removal of the check is ok.
What I meant is that the uniqueId calculation is not needed when everything is shadow, and it's here exclusively because of shady.
Polymer announced that all polyfill will be removed when all browsers support specs, I don't expect to remove support for IE11 in brief, but I believe we can do in a long term.
I don't think leaving the comment is bad anyways. It will help (to me) when reading back this code in some months. Not leaving this comment as a blocker though.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Mbasiuk/tdi 38446 salesforce bulk connection

What is the current behavior? (You can also link to an open issue here)
Was not shown message about using Partner connections in bulk mode
What is the new behavior?
Added INFO message in logger to tell user about using Partner connection
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:


pull request for e2e test at 01/19/2017 21:45:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: support midway 3

Codecov Report

Merging #179 (45ef944) into master (22a9318) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   81.92%   81.92%
=======================================
  Files          36       36
  Lines        3065     3065
  Branches      859      859
=======================================
  Hits         2511     2511
  Misses        500      500
  Partials       54       54

Impacted Files
Coverage Δ

packages/cli-plugin-package/src/index.ts
79.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22a9318...45ef944. Read the comment docs.


Update astro.rst with latest version

Description

Related Issue(s)

Breaking Change?

Checklist

[x] I have made corresponding changes to the documentation (if required)
[ ] I have added tests that prove my fix is effective or that my feature works

This is a blocker: https://github.com/astronomer/astronomer-cosmos/pull/772
Once #772 is merged, we should be good to merge this!


commands in say

hi.
can you tell me where the say-function is defined?
i want to execute a command to blink an LED every time the say function is executed.
my current workaround for this is to modify each plugin like this:
say "$(blink1-tool)" say "my text"

You can use hooks, they are for that ;)

Thanks a lot!


candidate paths are prepended to PATH

We require a conversation to take place in the appropriate Gitter Room before raising a new Github Issue. Please note that issues will be closed immediately if prior discussion did not take place. We need to do this to help manage the quality and validity of Issues raised on this project.
Please tick one:

[ ] this is a new Feature Request, a conversation was started in the Gitter CLI Development Room.
[ ] this is a new Bug Report or Issue, a conversation was started in Gitter User Issues Room.

Please explain the Issue / Feature Request here:
(no discussion required, the bug is obvious)
Version SDKMAN 5.7.3+337
The path of the installed candidates are put in front of the shell PATH variable, which is bad practice.
The problem is due to the __sdkman_prepend_candidate_to_path function in skdman-path-helpers.sh, line 73:
echo "$PATH" | grep -q "$candidate_dir" || PATH="${candidate_bin_dir}:${PATH}"
It can be fixed by adding the path to the end of the list to give the expected behaviour, like so:
echo "$PATH" | grep -q "$candidate_dir" || PATH="${PATH}:${candidate_bin_dir}"
Please don't put application's path first as it may disrupt the normal functioning of the shell!

Really? A bug? Could you provide a proof / link as citation that it is bad practice as you say?
Please follow the guidelines stated above as everyone else does.

If it's not a bug, it's a mistake (the line between the two can indeed be very blurry). Prepending paths introduces a vulnerability as someone could add fake executables in the new directories, it is also a risk of shadowing the legit OS commands.
Check for example here:
https://unix.stackexchange.com/questions/26047/how-to-correctly-add-a-path-to-path
Please note also that it is best to add this in .profile and not .bashrc. For an explanation, please check for example here:
https://superuser.com/questions/183870/difference-between-bashrc-and-bash-profile/183980

Nope, no mistake, it is by design. We purposefully want our path entries to have precedence over existing ones in user space. Take JAVA_HOME for instance. Many systems export JAVA_HOME, as part of the PATH which would mean that sdkman's path entry would never be picked up. Now that would be a bug.
As for your argument about vulnerabilities, a fake executable could make it's way anywhere on your system, even in the system directories? Heck, they could even make their way into your ~/bin folder which usually always has precedence over the rest of the path entries.
Lastly, we don't distribute any binaries that could shadow system binaries (except say java and javac which we purposefully want to shadow).
For an explanation why we don't use .profile (which is typically used for login shells) and instead use .bashrc and .zshrc, see the feature specification.

This is definitely wrong - If during an installation phase a certain env variable / binary exists it should be noted as a warning to the user, and presumably prefixed (HomeBrew style)
Most system don't have 99% of the SDK's, sure Java is common but thats just about it.
Just as HomeBrew doesn't prepend anything to the $PATH and is still widely used, so should this tool, but seeing as you're the author it is entirely up to you.
BTW Here's an example: Currently there is Java candidate for Oracle's 8 JDK
Even when I installed it manually, my system kept looking for JAVA_HOME set by this tool.
If the binaries path were appended instead, there would be no problem.

@eladchen a simple solution for you would be to do a local install of this external version, making sdkman aware of it and thus also managing its home variable.
Also, there is another issue open about making sdkman aware of system installed versions. It just hasn't been implemented yet.

Thanks for the tip.
I think it will be nice if there was a reference to that issue in this one.

Sure, the issue in question is #673.


cannot read non-functions in python worker

main thread (works): https://pyscript.com/@bugzpodder/xworker-sync-access-js-vals-copy/latest
worker (not working): https://bugzpodder.pyscriptapps.com/xworker-sync-access-js-vals-copy/latest/
basically, in js land I am passing in some stuff via: xworker.sync.foo = 'abc'
it doesn't seem like I can pull them out in python
functions works fine
I'm interested in getting all attributes defined on xworker.sync but unable to do this as well.
My workaround is to declare a function to pass it in and it will return whatever I need.

sync is a proxy, all things are discovered lazy and at runtime. Sync also is, by design, for functions: you invoke one and pass zero or more arguments, you get a result. Create your own method to return a list of sync utilities, as you define these yourself, right?

P.S. this has low to zero priority these days due release coming

fair enough, i'm fine with only supporting functions.

If it’s worth adding anything, sync as properties has design issues because it can’t be (easily) observed cross realms … it’s kept simple on purpose to serve patches for foreign PLs and all use cases right now are targeting functions, not accessors (getters). As functions can work both to invoke utilities or retrieve data, like accessors (getters), that felt good enough for most use cases. Accessors work out of window proxies though, but that’s a different use case / pattern all together. I’m not saying coincident could be smarter for sync, but I need a very strong reason to make sync more complex.

sg.  Is xworker.window a special thing then?

it's a whole Proxy with a completely different orchestration behind the scene.
this is coincident ... by design, docs, and API, it allows you to define a callback either in the main or the worker thread.
this is coincident/window which is a completely different orchestration to offer 1:1 usage from a worker.


Test exposing a service running inside kubernetes cluster on mycelium ip

The service won't run over Mycileum or IPv6 due to https://github.com/threefoldtech/tf-images/issues/291

moved to the next milestone


Google Auth - UI doesnt handle invalid inputs in OAuth credentials

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Login to Rancher UI
Go to Global --> Authentication --> Google
Enter Admin Email and Hostname.
Enter invalid OAuth creds and valid Service account creds.
Click on Authenticate with Google.

User is redirected to a page which throws this error

On the Rancher UI, user sees this error.

Expected Result:
It should behave the same way as it does for github Auth enabling.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head
Installation option (single install/HA): single

Verified with latest master-head - commit id: 734bd953
Steps:

Login to Rancher UI
Go to Global --> Authentication --> Google
Enter Admin Email and Hostname.
Enter invalid OAuth creds and valid Service account creds.
Click on Authenticate with Google.
The page does NOT get redirected. This error is seen on UI.

Enter invalid OAuth creds And click on Authenticate.
Page is redirected to this

On closing and going back to Rancher UI. Google was not Authorized message is seen


Add php cs fixer and psalm to dev dependencies

Initially psalm was not a dev dependency as we
supported php 5.3.
Now that we no longer support those php versions
we move this to a dev dependency instead
This should also make it easier for new people
to contribute as they can run all the tools
locally

I do like that we remove the ci directory and the bump to php-cs-fixer 3.0. But I don't really feel that they are dev-dependencies. Static analysers are just a tool that makes it easier for you to develop. Just like your IDE. If PHPStorm was a php package, would you add it in require-dev? =)
Lately, I started to like static setup like this. It will make Github PR comments where you need to change things (for the new contributors). Lazy contributors like myself like this too.

Alternatively you can use https://github.com/bamarni/composer-bin-plugin in combination with a Makefile to provide a good DX. For example: https://github.com/theofidry/console


Mouse pointer should vanish

If the 2nd render is full screen, it would be nice if the mouse cursor would vanish after a few seconds of inactivity.

Can you describe in more detail what you're trying to accomplish? What is your window layout?
Do you have multiple displays connected?
Why not just move the pointed into a corner?
Messing with the point is always a bit tricky with ImGui (because it's rendered natively by Windows. So we should

I just have the laptop screen. My workflow is

run Tooll in full screen
open the 2nd render window
switch to the main window (alt+tab)
change something in graph window
switch to the 2nd render window and watch the result
repeat 3...

I guess this is another issue specific for laptops ... the output window is just too small to get a impression, so I prefer the 2nd render window. But there is always the mouse pointer disturbing a bit. Sure I can train myself to push it away and back again in the graph window. It is just a little anoyance because it happens so frequently

Ah I see! I think that's a very creative work around to an important use-case that should better solved.
A current work around might be to create a layout (in current version this will be Default F10) with only a single output-window and hide UI (with Shift Esc). Sadly this will not remove the mouse pointer or the Output window tools.
We should add a preview mode that can easily be toggled with a hotkey (e.g. CTRL+Space). I renamed this issue accordingly.

Good idea, but I insist on being annoyed by some ugly white pixels disturbing my creations (aka mouse pointer)


Main.py missing

Please help us to get the combined python file

Please have a look at the other branch. That has the combined file. However, there are only eye tracking, mouth opening detection an person detection implemented in it.
It is not developed in the new branch as running those things together was very slow with multithreading. So adding further functionalities will be even slower. You can get a rough idea from that if you you want to develop it.

https://github.com/vardanagarwal/Proctoring-AI/blob/old_master/main.py


Deploy to heroku

Hello i deploy to heroku as all the guides say, and i have used grunt build but still the landing page and basically all my pages are blank and i dont know why can anyone help

Did u use yo generator to create your application?

see this discussion.. https://github.com/meanjs/mean/issues/960

yes i use yo generator also i use git clone but still nothings shows up
everything is blank, and i did use grunt build i am trying to figure this
out but no solution anywhere
2015-12-24 8:40 GMT+02:00 Michael Leanos<EMAIL_ADDRESS>
see this discussion.. #960 https://github.com/meanjs/mean/issues/960
—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/1117#issuecomment-167055445.

Are you getting a browser error? I'd expect an Angular injection error.
If you're getting an injection error, its most likely due to a dependency that's missing. Make sure your production asset file contains any custom libraries that you've added. Essentially, your prod assets need to look like your dev assets.
If that still.doesn't help, then make sure you've followed that steps in the #960.

no i am not, i told you i push the official code repo after git clone stuff
how is it possible to have an angular injection error? but i ll try this
steps and i will tell you what happens.
2015-12-24 14:05 GMT+02:00 Michael Leanos<EMAIL_ADDRESS>
Are you getting a browser error? I'd expect an Angular injection error.
If you're getting an injection error, its most likely due to a dependency
that's missing. Make sure your production asset file contains any
custom libraries that you've added. Essentially, your prod assets need to
look like your dev assets.
If that still.doesn't help, then make sure you've followed that steps in
the #960 https://github.com/meanjs/mean/issues/960.
—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/1117#issuecomment-167101129.

2015-12-24T12:28:17.909016+00:00 heroku[router]: at=info method=GET
path="/lib/angular-ui-router/release/angular-ui-router.min.js"
host=epratirio.herokuapp.com
request_id=6775e725-885a-47de-8e20-54a52a475d1a fwd="<IP_ADDRESS>"
dyno=web.1 connect=1ms service=2ms status=304 bytes=402
2015-12-24T12:28:18.026261+00:00 heroku[router]: at=info method=GET
path="/lib/angular-file-upload/angular-file-upload.min.js"
host=epratirio.herokuapp.com
request_id=efc1aa02-eef0-46c1-856d-ae7060fcde45 fwd="<IP_ADDRESS>"
dyno=web.1 connect=0ms service=2ms status=304 bytes=402
2015-12-24T12:28:17.881855+00:00 heroku[router]: at=info method=GET
path="/socket.io/socket.io.js" host=epratirio.herokuapp.com
request_id=e0143096-2f56-48e6-8ce7-89fe81fe0bb2 fwd="<IP_ADDRESS>"
dyno=web.1 connect=0ms service=1ms status=304 bytes=85
2015-12-24T12:28:18.041877+00:00 heroku[router]: at=info method=GET
path="/lib/owasp-password-strength-test/owasp-password-strength-test.js"
host=epratirio.herokuapp.com
request_id=6729c6d5-e4fc-4bea-8577-56a9131bca22 fwd="<IP_ADDRESS>"
dyno=web.1 connect=0ms service=1ms status=304 bytes=402
2015-12-24T12:28:17.908209+00:00 heroku[router]: at=info method=GET
path="/lib/angular-animate/angular-animate.min.js"
host=epratirio.herokuapp.com
request_id=53988a84-e6c4-455a-aae0-23cf341642eb fwd="<IP_ADDRESS>"
dyno=web.1 connect=0ms service=2ms status=304 bytes=402
2015-12-24T12:28:17.994468+00:00 heroku[router]: at=info method=GET
path="/lib/angular-ui-utils/ui-utils.min.js"
host=epratirio.herokuapp.com
request_id=3ec58f7c-5e26-4f76-89ef-0647688867e5 fwd="<IP_ADDRESS>"
dyno=web.1 connect=0ms service=1ms status=304 bytes=402
still getting these after i did the steps u told me but the answer is
i still get blank
see for yourselfhttps://epratirio.herokuapp.com/
2015-12-24 14:25 GMT+02:00 Panos tost<EMAIL_ADDRESS>
no i am not, i told you i push the official code repo after git clone
stuff how is it possible to have an angular injection error? but i ll try
this steps and i will tell you what happens.
2015-12-24 14:05 GMT+02:00 Michael Leanos<EMAIL_ADDRESS>
Are you getting a browser error? I'd expect an Angular injection error.
If you're getting an injection error, its most likely due to a dependency
that's missing. Make sure your production asset file contains any
custom libraries that you've added. Essentially, your prod assets need to
look like your dev assets.
If that still.doesn't help, then make sure you've followed that steps in
the #960 https://github.com/meanjs/mean/issues/960.
—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/1117#issuecomment-167101129.

Can you share the log from the Heroku build?

It looks like you're missing your minified app.js. Are you sure you've added the Grunt (or Gulp) build task to your postinstall config in your package.json?
When viewing the source of your application, you should see this in the Application Javascript Files section, along with your other library dependencies..
<script type="text/javascript" src="dist/application.min.js"></script>

hello i am sorry but i am no native english speaker the truth is that i
dont see my application.min,js but i dont know how to add these in the
package.json.
"postinstall": "bower install --config.interactive=false"
i see this in my package.json file but i dont know what to change.
can you tell me?
2015-12-24 15:16 GMT+02:00 Michael Leanos<EMAIL_ADDRESS>
It looks like you're missing your minified app.js. Are you sure you've
added the Grunt (or Gulp) build task to your postinstall config in your
package.json?
When viewing the source of your application, you should see this in the Application
Javascript Files section, along with your other library dependencies..

—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/1117#issuecomment-167108189.

@panospost

Change this line, https://github.com/meanjs/mean/blob/master/package.json#L20 to:
"postinstall": "bower install --config.interactive=false && grunt build"

This will be executed when you deploy your application to Heroku; thus the necessary files, including application.min.js, will be created in a folder named dist/ (in your Heroku app's root folder).

Change these two settings in your Heroku application settings, through your site's Heroku admin portal:
NODE_ENV: production
NPM_CONFIG_PRODUCTION: false

Please use this as a reference: https://github.com/meanjs/mean/issues/960#issuecomment-144898560

ok just i dont know what else to do still does not work here check it out
https://epratirio.herokuapp.com/
2015-12-27 15:51 GMT+02:00 Michael Leanos<EMAIL_ADDRESS>
@panospost https://github.com/panospost

Change this line,
https://github.com/meanjs/mean/blob/master/package.json#L20 to:
"postinstall": "bower install --config.interactive=false && grunt build"

This will be executed when you deploy your application to Heroku; thus the
necessary files, including application.min.js, will be created in a
folder named dist/ (in your Heroku app's root folder).

Change these two settings in your Heroku application settings, through
your site's Heroku admin portal:
NODE_ENV: production
NPM_CONFIG_PRODUCTION: false

Please use this as a reference: #960 (comment)
https://github.com/meanjs/mean/issues/960#issuecomment-144898560
—
Reply to this email directly or view it on GitHub
https://github.com/meanjs/mean/issues/1117#issuecomment-167414454.

@panospost please take this to Gitter, Stack Overflow, or another forum that is more appropriate. GitHub is for framework-wide bugs and feature requests, and we cannot handle everyone's individual bugs. If you realize that your bug was a result of something in the framework, please let us know, but try to resolve this issue on another forum to allow us to focus on development of the framework.


fix(lookup_token): should be None if original tokens hasn't the line

close https://github.com/rolldown/rolldown/issues/3112.
You could see the pervious test (1000, 0) return (2, 8), it is last token at original mapping, if we add more token exceeding the line, it will always mapping to the last token, it is incorrect.
The pr fixed it. Here create Vec<LineLookupTable> for original tokens, if is easy to check exceeding line, and also has better performance  than the previous implement, it only binarySearch the line tokens instead of the all tokens. It  inspire from https://github.com/jridgewell/trace-mapping/blob/main/src/trace-mapping.ts#L178

@hi-ogawa can you help me review?


Issues in Add command

After running the add command, there is nothing happening. I am typing the value from "Title" but it doesn't show up. Looks like it hangs there !!!!
~ Using it on Windows 10, build 16299.371

Sorry, I never had convenient access to a Windows machine to investigate this properly. I'll close this for now as there have been quite a few updates since, but feel free to reopen the issue if the problem persists.


Is there any problem?

Bill@~$ websocket-benchmark -h 'ws://<IP_ADDRESS>:8080/ws'
Starting 1000 clients doing 5 roundtrips to ws://<IP_ADDRESS>:8080/ws.
events.js:66
throw arguments[1]; // Unhandled 'error' event
^
Error: unexpected server response (403)
at ClientRequest. (/usr/local/lib/node_modules/websocket-benchmark/node_modules/ws/lib/WebSocket.js:463:17)
at ClientRequest.g (events.js:185:14)
at ClientRequest.EventEmitter.emit (events.js:88:17)
at HTTPParser.parserOnIncomingClient as onIncoming
at HTTPParser.parserOnHeadersComplete as onHeadersComplete
at Socket.socketOnData as ondata
at TCP.onread (net.js:404:27)

Hope it will help someone as this worked for me.
I was missing the headers & was getting "Error: unexpected server response (403)"
var ws = new WebSocket('wss://apiv2.unificationengine.com/v2/ws/start', {
    origin: 'https://apiv2.unificationengine.com',
    headers: { Authorization: 'base64 auth' }
});


Issues with change detection

when a run is recalculated (new datasets are created) the old datapoints and (unconfirmed) changes are not removed
alerting ignores new datapoints because there are already newer (same timestamp) ones

Fixed.


body is interpreted as next request if handler doesn't read it

This is vulnerable to the same security issue async-h1 fixed a few days ago.
https://github.com/http-rs/async-h1/releases/tag/v2.3.0
https://github.com/http-rs/async-h1/issues/163

Thanks for this! I'll take a look at how they handled it.

Thanks for this! I'll take a look at how they handled it.


sslcertificate depends on old puppetlabs-powershell module and blocks its upgrade

Affected Puppet, Ruby, OS and module versions/distributions
Puppet: Agent 6.15.0
Ruby: built in
Distribution: opensource puppet agent
Module version: 4.1.0

How to reproduce (e.g Puppet code you use)
puppet module upgrade puppetlabs-powershell
What are you seeing
Powershell module upgrade is blocked because:
'puppet-sslcertificate' (v4.1.0) requires 'puppetlabs-powershell' (>= 1.1.1 < 3.0.0)
Current version of powershell is 3.0.1
What behaviour did you expect instead
Output log
Any additional information you'd like to impart
Unless explicitly needed, can you please update the requirement of puppetlabs-powershell? Thank you

Hi,
based on a discussion in https://groups.io/g/voxpupuli/message/449 we decided to archive this repository. I'm going to close all issues and PRs. If you're interested in maintaining the module, please respond to our mailinglist.


Bump to 0.31 stargate client

This fixes issues for SDK v47 chains to work properly with the new TM37 client
Proof of work(ing)

Thanks!


Click sound when each sinewave in example finishes playing.

Hi :) Thanks for making this library, I'm excited to use it to write a morse code (cw) training application.
I'm just now getting started and trying out sending some audio but I've run into an issue.  Each time my app (and the example app in this repo) finishes a play of a sinewave there's a click sound.  I don't notice this when the sinewave starts playing, just right as it stops.
I'm not audio genius and am quite new to this library so I am hoping there are some wizards in here that might have a solution to this?  Having this ending click sound does make this unusable for my morse code goals since things would be very confusing with beeps and clicks all together! :(
I'm building the example inside WSL on Windows 10 and cross compiling it for Win 10, then just running the executable on the same Windows 10 machine under Windows (not WSL) if that all makes sense.

Could you show the minimal code to reproduce your issue? Thanks,

@hajimehoshi your simple sinewave example code in this project does it, as each tone ends, there's a pop/click sound.
@Asday is right.  I did some google digging and learning on Sinewaves and apparently if you cut it off somewhere other than back at zero it ends with a somewhat harsh clickish sound.   I was able to confirm this by doing some hackish code to find the ending sinewave point then truncate the bytes sent by the Read() func in the example to that point and pass that over to the oto player, and the click is gone.  The way I did it though is kind of clunkly so I'd like to fine a cleaner solution so that the Read function itself is smart and ends at a zero point.
So, my next struggle since I'm not that smart :)  How do I modify the example code so that it ends on a zero point?  Is there some math that I can use to calculate the right amount of bytes or time length that a given freq/sample would be back at zero?
I'm going to dig around on the internet more and try to figure it out but if anyone happens to already know or have an example that'd be awesome and I would appreciate it :)  Thanks.

@hajimehoshi your simple sinewave example code in this project does it, as each tone ends, there's a pop/click sound.

You mean an Ebitengine's example? (In this case, github.com/hajimehoshi/ebiten is the better place to discuss by the way) Then, as @Asday said, this is expected. The sounds abruptlly ends and a noisy sound could happen. If you want to avoid this, you should fade out the sound before terminating the game. For the sake of simplicity, the example doesn't handle such things.

So, my next struggle since I'm not that smart :) How do I modify the example code so that it ends on a zero point? Is there some math that I can use to calculate the right amount of bytes or time length that a given freq/sample would be back at zero?

Multiply the volume value between 0 and 1 for each samples. Start with 1 and decrease to 0 gradually. You can call SetVolume at every Update assuming you are using Ebitengine.

I mean the example code here in this oto repo - https://github.com/ebitengine/oto/blob/main/example/main.go

Thanks. This is the same thing: the example abrupts its wave so you would have to adjust the volume.


⚠ Buyfrom.io has degraded performance

In 4aa3fe8, Buyfrom.io ($BUYFROM_IO_URL) experienced degraded performance:

HTTP code: 200
Response time: 16009 ms

Resolved: Buyfrom.io performance has improved in 3c80dbc.


Enable API/ABI checks for bigtable.

There are still a couple of changes we may want to make to the API, but
I would prefer to notice those and not miss other breakage.
This fixes #694.

This change is

PTAL.

Codecov Report

Merging #2682 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2682   +/-   ##
======================================
  Coverage    93.3%   93.3%
======================================
  Files         296     296
  Lines       19077   19077
======================================
  Hits        17800   17800
  Misses       1277    1277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acff376...cb7c9c6. Read the comment docs.


Add a parameter to overwrite the default response timeout.

Noticed that for some BLC_UNKNOWN errors it were related to the response timeout, in order to avoid that
added an option to overwrite the default response timeout.

Evidence regarding the response timeout:

This is working fine for me. Can it be merged? @stevenvachon

Would solve #83 and #63 I think.

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the change to test my branch? It's not merged into master yet.

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the chance to test it using my branch? It's not merged into master yet.

How can I test your changes if they are still not merged into the master branch. Sorry I am new to Open-source, git & github.
Actually I was recently given my first issue, its to create a GitHub action that will check for broken links and if it finds any it will create a broken-link issue. Can you give me some advice it will be helpful. Thank you

@thiagosanches
if you have added the response time-out feature or changed the default response time-out. what is the syntax to use it i tried using npx broken-link-checker https://open-horizon.github.io/ --ordered --recursive --response-timeout 10000 but it still hanged

Hey, Did you have the chance to test it using my branch? It's not merged into master yet.

How can I test your changes if they are still not merged into the master branch. Sorry I am new to Open-source, git & github.
Actually I was recently given my first issue, its to create a GitHub action that will check for broken links and if it finds any it will create a broken-link issue. Can you give me some advice it will be helpful. Thank you

Hey @HarshalRathore , no worries! Basically, you can clone my fork and use that branch to test it. Something link this:
git clone git@github.com:thiagosanches/broken-link-checker.git
npm i
<run blc here with my parameter>

I hope that helps you!
Thanks,
Regards.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

https://github.com/bandavelaharishkumar/mslearn-tailspin-spacegame-web


Order of properties can break certain functionalities.

Take the following 2 lines:
toast.error('Dashboard name cannot be empty.', {id: 'DashboardNameNotEmpty'}, {style: {backgroundColor: '#FFFFFF33', color: 'white'}} );
toast.error('Dashboard name cannot be empty.', {style: {backgroundColor: '#FFFFFF33', color: 'white'}}, {id: 'DashboardNameNotEmpty'} );

The 1st line will only re-render the toast when the toast changes.
The 2nd line will re-render multiple times (not appropriate for my useCase) but on the other hand, it retains the styles.
Ideally both the ID functionality and the styles should be retained (not break based on their order).

Hi! The toast function takes only two arguments: the message & the options object. In you example only the first object is respected. You can combine them into one:
toast.error("Dashboard name cannot be empty.", {
  id: "DashboardNameNotEmpty",
  style: { backgroundColor: "#FFFFFF33", color: "white" },
});


Vanadium flow battery: voltage model fixes

Fixes:

Copied over some fixes from develop on calculate_max_charge_w and calculate_max_discharge_w
fix -inf potential from voltage_model
voltage drop across aggregated stack the same for charge or discharge
adapt test to show catch difference in using abs(I_string)

With the thermal model turned off: this is the yearly battery charging & discharging table:

@cpaulgilman Yes, it would be a separate PR. It think it's easier to review and track changes when the Pull requests (and Issues) are smaller and more targeted.
I haven't gotten a chance to look at the Li-ion part, but I'll move it to an issue of its own about the voltage table.


[zh] sync coarse-parallel-processing-work-queue.md

Sync with en.
content/zh-cn/docs/tasks/job/coarse-parallel-processing-work-queue.md

Preview: https://deploy-preview-37985--kubernetes-io-main-staging.netlify.app/zh-cn/docs/tasks/job/coarse-parallel-processing-work-queue/

/lgtm
/approve


feat(super user panel): workspace page

Basic workspace page that displays the plan and a button to upgrade or downgrade

thanks for the review @PopDaph 🙏


[Question] Display dataset record(Sample) metadata in the viewer main page

Is there a way to display additional columns in the Viewer main page? Currently only "Input", "Target", "Answer" and "Score" are displayed, and additional metadata is shown when record is clicked on.
Is there a way to add additional columns to the main view?

Not currently (cc @dragonstyle)


Textual instance for LogStr

The packages wai-extra, which implements the Middleware interface for wai depends on fast-logger: https://hackage.haskell.org/package/wai-extra
The fast-logger package defines a LogStr: https://hackage.haskell.org/package/fast-logger-3.1.0/docs/System-Log-FastLogger.html#t:LogStr
I find a couple of interesting things here:

There is a very strong similarity between LogStr and Rope:
data LogStr = LogStr !Int Builder

And
newtype Rope = Rope (F.FingerTree Width S.ShortText)

It's interesting that both data types have good performance for append operations.

With that said:
If we could have a Textual instance LogStr, it would help towards a potential implementation of a Middleware for wai 😄
Downside: More dependencies in core-text.

@carlosdagos ahh I see so instead of having a whole wai app wrapped in Program it would become a Middleware?
Would you still get the same access to its instance/functions through the ReaderT inside the handlers?

I think using Middleware (which is nothing but a type alias for Application -> Application is a good way to keep things nicely decoupled, potentially as a separate lib like core-wai or something (?). However, I'm still thinking about it and probably would need to experiment a bit to see all the pros and cons

@carlosdagos I've adapted as your idea and integrated it directly into the Program monad as #90. If we use that I think it supersedes this? I tried messing around with the logging helers in wai-extra; Vince's examples really helped me understand what was going on there but probably if we launch the webserver directly with an appropriately coonfigured Middleware it looks like it works.

@carlosdagos @istathar Think my main con would be finding information/ blog post / examples of solving problems when one wants to use servant & wai. With the method in the PR we'd be wrapping it inside of core which feels like an extra level of abstraction. Rather than a middleware that runs along side of the application and handles a piece ie "logging".
The primary problem being the type of Program having the static Monad set to IO. Which I've previously shown and discussed how that doesn't align with the whole implementation in wai and servant.
Personally I would have used something like this code to be a middleware if the end goal was to send logs to honeycomb.
I seem to be really missing the benefits of using unbeliever as part of a web server and would love to be shown the pros of it so I can have pros + cons ?
As a terminal tool yes it's really good but still unsure the functionality it provides is also suited for servers. Are we trying to fit a square peg into a round hole for the sake of being able to use unbeliever ?

Think my main con would be finding information/ blog post / examples of solving problems when one wants to use servant & wai

The code in #90 doesn't really touch on servant, it does two things primarily:

Creates a launchWebserver action on the Program monad that works with any wai Application. How one gets this Application is up to the consumer, this is commented here.
Creates a loggingMiddleware :: Context τ -> Middleware. This is used within launchWebserver, the implementation details of that are not necessarily important for this issue, I don't think.

The primary problem being the type of Program having the static Monad set to IO. Which I've previously shown and discussed how that doesn't align with the whole implementation in wai and servant.

If your concern is using blogposts+examples then yes I agree, using Program within Servant Handlers is not too straightforward. But I don't believe that Program setting its internal monad to IO is indeed the problem. If we want to use honeycomb-haskell as an example, they also provide a servant+rio integration and well, it does pretty much the same things as #90 to be honest, except with different constructs and a different set of ecosystem libraries.

Personally I would have used something like this code to be a middleware if the end goal was to send logs to honeycomb.

That code is 2-3 years old with no updates. I think you meant this code here. I don't have any issues with that code at all. As said above though, I think it mostly does the same thing as #90

I seem to be really missing the benefits of using unbeliever as part of a web server and would love to be shown the pros of it so I can have pros + cons ?
As a terminal tool yes it's really good but still unsure the functionality it provides is also suited for servers. Are we trying to fit a square peg into a round hole for the sake of being able to use unbeliever?

unbeliever is a set of opinionated libraries. The docs do a pretty good job of explaining those opinions: https://hackage.haskell.org/package/core-program-<IP_ADDRESS>/docs/Core-Program-Execute.html
I don't think that the demarcation between console and webserver is all too important here if I'm honest. The webserver is warp and that's still used, just that it's launched via the Program monad with liftIO, so that it can play along with execute and therefore unify all the administrative tasks that core-program aims to solve in a unified way 😄
With all that said, I think that this issue is no longer relevant as #90 covers the logging bits for an Application.

@carlosdagos ah thanks that explains a lot. Guess we need a chat about "the administrative tasks that core-program aims to solve" for me to understand all the benefits it brings.
Think my scepticism is routed from having to have a buy in to what could be classed as an eco system in unbeliever. Much like the choice of using servant/wai but this is a level above that. This isn't necessarily  a bad thing but I foresee issues potentially arising that require complexity that might not have been needed if things had just been vanilla. 🤔


Fixes #3639

Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced. Fixes #3639.

Why should this gated on the state of the document in any way?
If the secretariat or an AD (or other stream-appropriate person) wanted to change the list of addresses to "also notify" years after the document was approved in case someone added a comment to the document and they wanted to be notified, why should the tool prevent that?


App Store and Apple Music app lose internet connection and unable to connect

Describe the bug
After jailbreak I am able to use the App Store and Apple Music and can connect to Internet with those apps but after a while I try to use the apps again they appear to lose connection to the Internet.  I have tried to enable airplane mode and disable airplane mode but it does not resolve the issue.  If I re-jailbreak the iPad it will then work again for a while before it stops working again.
To Reproduce
Steps to reproduce the behavior:

Go to App Store and get message "Cannot connect to App Store, retry
Go to Apple Music app and try to play a song in the cloud that is not downloaded and eventually get error message "
Re-jailbreak
Apps then work for a while.

Screenshots
Not required.
Device (please complete the following information):

iOS Version: 12.1.1b3
iOS Device: iPad 12.9 1st Gen
unc0ver Version: v3.0.0b41

Place an "x" between the brackets if true:

[x ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x ] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

Same issue. After a while I can’t connect to AppStore. I have to rejailbreak to connect to AppStore again.

i have this issue with google maps, "no location detected." Apple maps works tho


remove array syntax

Ensure variations can not call internal functions, see https://github.com/yiisoft/yii2/pull/19741#issuecomment-1399228457

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#19741

Thanks.


swaynotificationcenter: 0.7.3 -> 0.8.0

Description of changes
Bumps to new version, including thsese changes:

Includes new deps: libgee and libpulseaudio;
Adds meta.changelog;
Release changelog: https://github.com/ErikReider/SwayNotificationCenter/releases/tag/v0.8.0
Full changelog: https://github.com/ErikReider/SwayNotificationCenter/compare/v0.7.3...v0.8.0

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

╭─pedrohlc at desktop in /home/pedrohlc/Projects/com.pedrohlc/nixpkgs (swaync-0.8.0 ✚1)
╰─λ ./result/bin/swaync &

** (swaync:1109033): CRITICAL **: 10:36:29.531: baseWidget.vala:36: title: Config not found! Using default config...

** Message: 10:36:29.531: factory.vala:42: Loading widget: title

** (swaync:1109033): CRITICAL **: 10:36:29.531: baseWidget.vala:36: dnd: Config not found! Using default config...

** Message: 10:36:29.531: factory.vala:42: Loading widget: dnd
╭─pedrohlc at desktop in ~/nixpkgs (swaync-0.8.0 ✚1)
╰─λ disown
╭─pedrohlc at desktop in ~/nixpkgs (swaync-0.8.0 ✚1)
╰─λ ./result/bin/swaync-client -c
0⏎                                                                                ╭─pedrohlc at desktop in ~/nixpkgs (swaync-0.8.0 ✚1)
╰─λ notify-send 'test'
╭─pedrohlc at desktop in ~/nixpkgs (swaync-0.8.0 ✚1)
╰─λ ./result/bin/swaync-client -c
1⏎

Result of nixpkgs-review pr 218442 run on x86_64-linux 1

1 package built:

swaynotificationcenter


Demos not working

Hey, I noticed the demos look awesome, but when I attempted to open the demo scenes in engine, they did now work. I am using Unity 4.6.1. Basically, the scene opens, but no lighting effects / shadows. Am I supposed to do anything for demos to work or something?

Hi, thanks for the question :)
You don't need to setup extra things to try the demo. I just tried on another PC running Unity 4.5, which is ok.
Did you open the scene in an existing project, or did you open it in a new project? As the lighting / shadow effects need to work with layers in Unity, so if the layers used in demo are messed up with the layers in the existing project, it may not work. So if it's the reason, I recommend to use a new project to open the scene.
Hope it helps!

Thanks for speedy reply! I figured the issue was on my behalf hah. So you were correct, it automatically assigned the game object "Container - Obstacles" to one of my custom layers. By default (in your demo scene), the layer is blank. How is this possible? I cannot find a way to assign a blank or empty layer to a game object. Also, do they have to be blank? Can I create another custom layer that works with the lighting? I apologize for the plethora of questions xd

Actually, it dont need to be blank, and should not be too. You can create and assign your own layers to it.
Why it's blank in the demo is because the layer information was not put inside the example folder, so the scene just remember the index of the layer, but it doesn't know the name of the layer ;p

Ahhh, I see! Thank you very much for your help! :)
On Thu, Mar 19, 2015 at 10:19 AM, Yifeng<EMAIL_ADDRESS>wrote:

Actually, it dont need to be blank, and should not be too. You can create
and assign your own layers to it.
Why it's blank in the demo is because the layer information was not put
inside the example folder, so the scene just remember the index of the
layer, but it doesn't know the name of the layer ;p
—
Reply to this email directly or view it on GitHub
https://github.com/f15gdsy/2D-Light-of-Sight-Unity/issues/3#issuecomment-83599261
.


[📑 Docs]: Adapt Validate AsyncAPI documents guide for v3

For AsyncAPI v3, we need to adapt validate AsyncAPI documents guide (https://www.asyncapi.com/docs/guides/validate) to be usable with AsyncAPI v3.
I actually don't know what exactly is needed here, because I don't know whether the spectral rules in Spectral, will be adapted, or whether it will be part of the parser 🤔

/good-first-issue area/docs

opening a PR for this

solved with https://github.com/asyncapi/website/pull/2303
in next major branch, but considered to be fixed and closing - also for easier management of the scope for v3


UI-Router $resolve

I tried to find any resources on how to access the resolved data for ui-router states in a redux-way.
It is still possible to get hold of those by injecting into the controller/binding to a component, but the best would be if they were available in the redux store.
Is there any way to do/support this?

I'm not entirely sure I understand your issue.  There is an example on this issue that addresses resolves. Is this helpful?

Yes, I think it helps - I shall try to adjust my code according to that example.
Apologies for not finding that myself.

No worries ;)


Use std::unique_ptrs for storing model definitions

I fancied tinkering with some code rather than just config files, so I did this, even though it's not in the backlog and is a pretty minor refactor :stuck_out_tongue:.
Currently, the model definitions are stored in the repository (of type CachedRepository) as std::shared_ptrs, even though they don't really need to be "shared", because the repository object will outlive any of the users of these model definitions. So instead, I've changed these to be std::unique_ptrs; when they're needed they can be accessed as good old-fashioned const refs.
I also changed a couple of small issues I spotted on the way.

That sounds v bizarre 😆 but I'm sure there's a good reason for it! Yes, you could easily modify it to be non-const. The thing is though, if you do that it will also modify the version in the repository (and therefore any future models will also have modified params). Would that be a problem?
I did wonder if we might be able to remove the model definition classes, but having had a look just now, I'm wondering how we'd be able to construct models without having the params encapsulated in a separate class somewhere? (That's assuming that we actually do want to cache model parameters rather than reloading them every time.)

The only sensible reason I could think of for caching parameters was if they wanted some persistent interface in future, where they could stop, reinitialise, restart, etcetera, which would mean re-initialising from some pristine confifg. In which case, you're right, it's probably better to keep the 'definition' classes, keep the cache constant, and just copy out of it whenever they need fresh state.
If they don't want that, then there's no reason to cache anything. But I suppose they might want that in future, so I guess that's reason enough to keep the pristine cache.

Rather than wondering what they might want, why do you ask them (after giving some context of the issue)?

Ali has just confirmed that future plans might include a GUI which would need a persistent pristine configuration cache to generate models from, so I would say that this is the correct approach, and to go ahead and merge this.


Docker Desktop's "resource saver mode" causes WSL to "lock" when AutoMemoryReclaim is set to gradual

Windows Version
Microsoft Windows [Version 10.0.22621.3007]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-1
Distro Version
Ubuntu 22.04
Other Software
Docker Desktop 4.26.1 (131620) - Windows version
Repro Steps
When Docker Desktop is running but is in "Resource Saver" mode, running any command that has to read from the disk will "hang" until I manually "wake up" Docker from its Resource Saver mode (by running a container for example).
I'm not really sure about the "read from disk" part, but it's been the common denominator of commands affected by this (e.g. apt, ls, lsof are all affected, while zsh scripts that are already running or top/htop aren't).
This issue happens when Docker Desktop is running in resource saver mode AND WSL's autoMemoryReclaim is set to gradual.
I've tried the following scenarios and they don't seem to cause the issue:

autoMemoryReclaim is set to dropcache
autoMemoryReclaim is disabled (commented out in .wslconfig)
Docker Desktop is running in its normal mode
Docker Desktop isn't running at all

For now I have autoMemoryReclaim set to dropcache, but if you want me to run additional tests or need some other info let me know.
Expected Behavior
Expected the normal command behavior.
Actual Behavior
I've taken a screen recording while the issue happens:
https://github.com/microsoft/WSL/assets/56894914/64ac6b36-90a3-44af-89d5-83fe4e5d864e
Diagnostic Logs
Those are the corresponding WSL logs for the screen recording:
WslLogs-AutoMemReclaim-Gradual-2024-01-23_20-40-10.zip

I also see this with Ansible commands, even ansible --version. If I restart docker or just run any docker command that contacts the daemon, the hanging commands immediately resume.

I am also seeing this. I got the hunch that anything accessing the network also hangs, not just what's accessing the file system.

I am facing the same issue. Maybe related to #10378

same issue here.
it's actually just slowing down the system a lot but not hanging indefinitely.
one can see this if you ran "service --status-all".  it takes minutes to list services one by one.  if i stop docker desktop, then the command finishes quickly.

My problem is similar but not identical. I am running WSL2 Ubuntu 22.04. I can run ls and even apt list without problem.  However, running sudo apt-get update hangs indefinitely when Docker Desktop is in "Resource Saver mode".
To fix it, all I have to do is click on the Resume button in Docker Desktop. Then sudo apt-get update runs instantly

Note that I also confirmed that I do have autoMemoryReclaim=gradual set in ~/.wslconfig
> wsl -v
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>-2
WSLg version: 1.0.61
MSRDC version: 1.2.5326
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26091.1-240325-1447.ge-release
Windows version: 10.0.22631.4037

I also just updated Docker Desktop today, and the problem persists with Docker Desktop 4.33.1 (161083)
$ docker --version
Docker version 27.1.1, build 6312585


<EMAIL_ADDRESS>installing extra packages with yarn 3 that break<EMAIL_ADDRESS>

Is there an existing issue for this?

[X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[X] I have reviewed the documentation https://docs.sentry.io/
[X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/browser
SDK Version
7.60.0
Framework Version
No response
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce

Using<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>Run<EMAIL_ADDRESS>with yarn tsc.
See tsc with errors such as

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:1:84 - error TS2307: Cannot find module 'rollup' or its corresponding type declarations.

1 import { SourceMapInput, EmittedAsset, AcornNode, Plugin, PluginContextMeta } from 'rollup';
                                                                                ~~~~~~~~

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:2:40 - error TS2307: Cannot find module 'rollup' or its corresponding type declarations.

2 export { Plugin as RollupPlugin } from 'rollup';
                                         ~~~~~~~~

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:5:36 - error TS2307: Cannot find module 'vite' or its corresponding type declarations.

5 import { Plugin as Plugin$1 } from 'vite';
                                     ~~~~~~

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:6:38 - error TS2307: Cannot find module 'vite' or its corresponding type declarations.

6 export { Plugin as VitePlugin } from 'vite';
                                       ~~~~~~

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:7:49 - error TS2307: Cannot find module 'esbuild' or its corresponding type declarations.

7 import { Plugin as Plugin$2, PluginBuild } from 'esbuild';
                                                  ~~~~~~~~~

.yarn/cache/unplugin-npm-1.0.1-70bc9bb0e2-b6bf00dcc7.zip/node_modules/unplugin/dist/index.d.ts:8:41 - error TS2307: Cannot find module 'esbuild' or its corresponding type declarations.

8 export { Plugin as EsbuildPlugin } from 'esbuild';
                                          ~~~~~~~~~

Run yarn why -R unplugin and see

├─ @org/package@workspace:package
│  └─ @sentry/webpack-plugin@npm:2.4.0 [e43e3] (via npm:^2.4.0 [e43e3])
│     ├─ @sentry/bundler-plugin-core@npm:2.4.0 (via npm:2.4.0)
│     │  └─ unplugin@npm:1.0.1 (via npm:1.0.1)
│     └─ unplugin@npm:1.0.1 (via npm:1.0.1)

Expected Result
tsc should not report errors because a package doesn't correctly record which dependencies it needs. Yarn is stricter than npm in this regard.
Actual Result
https://github.com/unjs/unplugin/blob/main/package.json#L34 doesn't seem to specify the dependencies it's reaching out for.

Thanks for writing in!
Unfortunately the dependencies come from the unplugin package and I currently don't know how I would sustainably resolve this issue. We're open to any suggestions!
Short to mid-term plans are to move away from unplugin anyhow. This will implicitly be resolved then.

I have now also created this unplugin issue: https://github.com/getsentry/sentry-javascript-bundler-plugins/issues/435
Given how it's designed to work and limitations of npm, I'm not sure there is anything it could do to fix this issue though...

Yes sorry. This shouldn't be closed. Plan is still to move away from unplugin.

I'm not interested in this work going forward. If folks still want it open, feel free to reopen.

For anybody running into this, as a workaround, try not to point tsc to your build config.


fix: keep inheritance of language chain during seo url update

NOTE: we validated this is a fix. we will update the PR note.
fixes wrong id comparison

1. Why is this change necessary?
language inheritance is broken when generating seo urls .
example: german (austria) extends german (germany).
current code falls back to system default language.
2. What does this change do, exactly?
fixes wrong uuid comparison
3. Describe each step to reproduce the issue or behaviour.
run dal:index:refresh
language interitance is broken when generating seo urls
example: german (austria) extends german (germany).
current code falls back to system default language.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

would you mind squashing the commits?

would you mind squashing the commits?

https://github.com/shopware/platform/pull/1646


Getx can't find async global dependency in InitialBinding

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS.
Fill in the template. Issues that do not respect the model will be closed.
Describe the bug
So I have an ApiProvider dependency injected to the app. I also have another dependency which is a specific API fetch response that should be injected as a global dependency. I tried to construct both in initialBinding, and use them in a view. While the ApiProvider is fine, flutter complained that the latter is not found on red screen. Sometimes the error flashed for one second and disappears at the next build routine. I wonder what is wrong with my code, or is it some issue in GetX? (Although I may have used the library the wrong way, at least I could not find relevant information on the documentation)
Reproduction code
NOTE: THIS IS MANDATORY, IF YOUR ISSUE DOES NOT CONTAIN IT, IT WILL BE CLOSED PRELIMINARY)
https://gist.github.com/fhfuih/8ab5a4539844cdb6dc0c0e77fe479396
To Reproduce
Steps to reproduce the behavior:

In InitialBinding.dependencies, put an ApiProvider, followed by a putAsync of the return value of an async method in the ApiProvider.
Build/hot-rebuild the app

Expected behavior
No exception
Flutter Version:
2.2.0
Getx Version:
4.1.4
Describe on which device you found the bug:
android (1+7pro) & web (chromium edge)

Also, a quick off-topic question: are these independent (and all correct) approaches to inject global dependencies?

put the dependency anywhere with permanent: true
put the dependency in initialBinding (regardless of the permanent parameter)
declare the dependency as extends GetxService or with GetxServiceMixin and put it anywhere  (regardless of the permanent parameter)
put the dependency in main before runApp. (Like the initServices() code example in doc)

I managed to overcome the issue using (4) in my previous comment, i.e.,
Future<void> initServices() async {
  Get.put...
  await Get.putAsync...
}
void main() async {
  await initServices();
  runApp...
}

(Although new issue arises because I tried to load asset JSON files in my mock ApiProvider, and loading assets before building any widgets returns null because (maybe) no BuildContext is presented yet. But that should be another irrelevant issue.)
Alright I still wonder why InitialBinding does not work in this case. If it is my issue, could you please add some more clarifications on the documentations, as I couldn't find any related information there? Thanks!

For putAsync the doc saild:

If you want to register an asynchronous instance, you can use Get.putAsync

which means that returned instance must be asynchronous, not the method you called is async/await, so I think this is why throw error when you call final data = Get.find<InitialData>();
  Future<InitialData> getInitialData() async {
    await 2.delay();
    return InitialData();  // the return part must be asynchronous
  }

For putAsync the doc saild:

If you want to register an asynchronous instance, you can use Get.putAsync

which means that returned instance must be asynchronous, not the method you called is async/await, so I think this is why throw error when you call final data = Get.find<InitialData>();
  Future<InitialData> getInitialData() async {
    await 2.delay();
    return InitialData();  // the return part must be asynchronous
  }

Thanks @KevinZhang19870314 for the reply. But I don't think that's the reason. Because

I succeeded in injecting dependencies this way:

Future<void> initServices() async {
  Get.put<ApiProvider>(ApiProvider());
  await Get.putAsync<InitialData>(() => Get.find<ApiProvider>().getInitialData());
}
void main() async {
  await initServices();
  runApp(MyApp());
}

in which this line Get.putAsync<InitialData>(() => Get.find<ApiProvider>().getInitialData()) is intact except that I awaited.
2. It is equivalent that "my function is async" and the return value is asynchronous (i.e. Future). Plus, the signature of putAsync is Future<S> putAsync<S>(Future<S> Function() builder, {...}). So indeed, the return type is a Future of concrete data type. (And also it is a valid Dart syntax to declare async in function signature and return a concrete data object. Dart will automatically wrap it in Future like JavaScript. The return type Future<InitialData> says everything, or otherwise I would fail the compilation ;))
I guess the problem may be that the InitialBinding approach does not wait for putAsyncs to complete. Even if I modify the gist above to let dependencies() be async
Future<void> dependencies() async {
    Get.put<ApiProvider>(ApiProvider());
    await Get.putAsync<InitialData>(() => Get.find<ApiProvider>().getInitialData()); // added await here
  }

The problem persists. By simple logging Get.putAsync(...).then((value) => print(...)), in my console the print results is after the exception.
In fact, the documented examples on Bindings happened to not use any putAsyncs. I guess this part need further clarification or async supports.

Flutter from runApp starts building the app synchronously. It is not possible to start an instance asynchronously in initialBinding, because it will be placed at the end of the dart event loop (unless you use a SplashScreen).

Flutter from runApp starts building the app synchronously. It is not possible to start an instance asynchronously in initialBinding, because it will be placed at the end of the dart event loop (unless you use a SplashScreen).

I see... Maybe I can look into the SplashScreen then. After all we're going to handle potential API issues.


Add subdirectory option

What problem are you trying to solve?
We want to allow users to run an analyze from a subdirectory.
What is your solution?
Support the analyzer's subdirectory option.
Verification
When no subdirectory is passed

A directory (/subway) is set, but it doesn't exist

A directory (/subway) is set, exists, but doesn't have a config file there

A directory (/subway) is set, exists, and has a config file

A directory (subway) is set, exists, and has a config file

@dastrong can you please try without setting the parameter?

@dastrong can you please try without setting the parameter?

Added an image in the description.

Note: we should probably remove the version pinning for datadog-ci

@juli1 updated the description images with the latest commit from this GitHub action and the static analyzer CLI.


Added new module: Motivation

Closes #78
@swapagarwal @TeAmP0is0N Please review.

Not the right fit for the bot.