CMake config file to link target

There is no TorchvisionConfig.cmake file generated, or FindTorchvision.cmake, so that we can link the target from CMake. Should there be some, or the library is supposed to be linked in some other way?
If there should be one, I could work on a PR to add it.

cc @ShahriarSS

Hi @facug91 I'm looking into this.

@facug91 This is a minimal example of usage:
CMakeLists.txt:
cmake_minimum_required(VERSION 2.8)

project(testvision)
add_executable(${PROJECT_NAME} "main.cpp")

find_package(Torch REQUIRED)
target_link_libraries(${PROJECT_NAME} torchvision)
target_link_libraries(${PROJECT_NAME} PUBLIC "${TORCH_LIBRARIES}")

main.cpp:
#include <torchvision/vision.h>

int main()
{
    vision::models::AlexNet network;
    network->forward(torch::rand({1, 3, 224, 224}));
    return 0;
}

But having a cmake config file would be a good thing. Can you work on a PR adding it?

Is that CMake script working for you? Because torchvision target shouldn't exist, Torch doesn't create it.
What I could do is work on a PR to add a cmake config file, so that with a new line find_package(TorchVision REQUIRED), the target_link_libraries(${PROJECT_NAME} torchvision) should work.

Yes it is working because libtorchvision.so is  just another shared library and you cal link to it with target_link_libraries. I think it would be better if a config and a version file would exist.

@ShahriarSS I don't see libtorchvision.so generated.
How are you able to link it? Am I missing something?

@ShahriarSS How can I get libtorchvision.so ?
I am configuring cmake for torchvision. cmake generated TorchVisionTargets.cmake and TorchVisiontargets-release.cmake files in which libtorchvision.so is been referred. Its not provided by the torchvision package that I installed. I am getting the following error:
CMake Error at /path/libtorch/share/cmake/TorchVision/vision/build/TorchVisionTargets.cmake:70 (message):
The imported target "TorchVision::TorchVision" references the file
 "path/libtorch/share/cmake/lib/libtorchvision.so"

but this file does not exist.  Possible reasons include:

The file was deleted, renamed, or moved to another location.

An install or uninstall procedure did not complete successfully.

The installation package was faulty and contained

How should I solve it?

Hi @Pnikam
You can build and install torchvision's C++ API from source. The instructions are in the README file.

I have followed all the steps given. I was able to configure it successfully. But when I try to configure it for detectron2 models, I am getting the error:
`CMake Error at /home/admin1/Vision2/vision/build/TorchVisionConfig.cmake:50 (include):
include could not find load file:
/home/admin1/Vision2/vision/build/TorchVisionTargets.cmake

Call Stack (most recent call first):
CMakeLists.txt:9 (find_package)
CMake Error at /home/admin1/Vision2/vision/build/TorchVisionConfig.cmake:58 (target_link_libraries):
Cannot specify link libraries for target "TorchVision::TorchVision" which
is not built by this project.
Call Stack (most recent call first):
CMakeLists.txt:9 (find_package)
Configuring incomplete, errors occurred!`
TorchVisionTargets.cmake file is:
`# TorchVisionConfig.cmake
--------------------

Exported targets:: Vision

####### Expanded from @PACKAGE_INIT@ by configure_package_config_file() #######
####### Any changes to this file will be overwritten by the next CMake run ####
####### The input file was TorchVisionConfig.cmake.in                            ########
get_filename_component(PACKAGE_PREFIX_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../" ABSOLUTE)
macro(set_and_check _var _file)
set(${_var} "${_file}")
if(NOT EXISTS "${_file}")
message(FATAL_ERROR "File or directory ${_file} referenced by variable ${_var} does not exist !")
endif()
endmacro()
macro(check_required_components _NAME)
foreach(comp ${${_NAME}_FIND_COMPONENTS})
if(NOT ${NAME}${comp}_FOUND)
if(${_NAME}FIND_REQUIRED${comp})
set(${_NAME}_FOUND FALSE)
endif()
endif()
endforeach()
endmacro()
####################################################################################
set(PN TorchVision)
location of include/torchvision
set(${PN}_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include")
set(${PN}_LIBRARY "")
set(${PN}DEFINITIONS USING${PN})
check_required_components(${PN})
if(NOT (CMAKE_VERSION VERSION_LESS 3.0))
#-----------------------------------------------------------------------------
Don't include targets if this file is being picked up by another
project which has already built this as a subproject
#-----------------------------------------------------------------------------
if(NOT TARGET ${PN}::TorchVision)
include("${CMAKE_CURRENT_LIST_DIR}/${PN}Targets.cmake")
if(NOT TARGET torch_library)
find_package(Torch REQUIRED)
endif()
if(NOT TARGET Python3::Python)
find_package(Python3 COMPONENTS Development)
endif()
target_link_libraries(TorchVision::TorchVision INTERFACE ${TORCH_LIBRARIES} Python3::Python)
if(OFF)
target_compile_definitions(TorchVision::TorchVision INTERFACE WITH_CUDA)
endif()
endif()
endif()`
TorchVisionTargets.cmake file has been generated by cmake at CmakeFiles/Export/share/cmake/TorchVision.
As it was not found, I copied it to the same folder as TorchVisionConfig.cmake. Now I am getting error that libtorchvisio.so is not found.
``

having exactly the same problem as above

+1 on the problems as above

Same problem here, something like torch.utils.cmake_prefix_path would be great


Place some conditionality on SBI PMU Extension requirement

Current text indicates PMU is mandatory, but that requirement is actually dependent on some in-flight extensions. We should capture our reasoning in the text and make a late binding decisions based on the dependent extensions being ratified.
Atish (@atishp04 ), you said you'd pick this one up.

Sure. I will send a PR.

Sure. I will add it.

FYI: PTAL
https://github.com/riscv-non-isa/riscv-brs/pull/86

Complete


'layer.composite().save' bug

test.psd.zip
photoshop export the layer:

layer.composite().save the layer:

please help me.

layer.composite(force=True) ，add force=True, then export right, why? Do you have detailed documents？

How to synthesize multiple layers and export a picture

any question,
Source image：

export:

So many questions, please help me

layer.composite(force=True).save , the image hasn't  drop shadow effects

@wushiwein119 Compositing is incomplete and does not support all of Photoshop's functionality


Error when starting dev server with global react-static CLI

After running react-static start in a newly created project and visiting http://localhost:3000 I get the following message: Oh-no! Something’s gone wrong!
Detailed error output from Chrome: localhost-1546195846717.log
Using npm run start or npx react-static start works just fine.
Environment

react-static -V: 6.0.18
node -v: v10.14.2
npm -v: 6.4.1
Operating system: macOS 10.14.2

Steps to Reproduce the problem

Install react-static npm install -g react-static
Run react-static create. Create new-project and select basic template.
cd new-project && react-static start
Open browser at http://localhost:3000

This should be fixed in the latest version and is likely related to #929


readme.md: fix typos

Please be aware that this pull request was automatically created using gtf - a typo fixing bot
You should be able to merge this with no other problems.
In case the proposed changes do not make sense, I would be glad to hear about it.

This repo is a fork please open PRs upstream


Update github-toggle-expanders.user.js

A minor addition in order to work in releases pages too, e.g. https://github.com/ahkscript/SublimeAutoHotkey/releases.

Hi @darkred!
Thanks!! 😸

BTW, I'd like to ask you this, please:
since you had invited me a collaborator to this repo,
whenever have a suggested addition for a script of yours (like this one),
would you prefer if I immediately pressed the "Merge" button myself (provided that I have included a script's version bump, of course),
or it's better to only make a pull request and let you decide whether to merge?

Yeah, I'm fine with you pushing to the master branch. I'll add a contributions file soon to spell out what I've been doing for each release. Thanks again!

Great! I'm glad.

Done - CONTRIBUTING.md.


Standby interface is not documented/exposed

There is no API documented/exposed that provides switching a single device into standby (e.g. by providing an output_id).

note that multiple things on an output can be put into standby... one could theoretically have a device with an amp and a dac with different and independent types of standby support. That's the point of the control_key


Can't Determine Scanner Existence if No Print Exists

window.plugins.touchid.isAvailable(...) calls the error handler if a device has a TouchID/FaceID scanner, but no fingerprints. This is different from the most popular Android plugin for this purpose. It would be very nice to be able to determine if a device has a TouchID/FaceID scanner in order to provide messaging to encourage the user to add a fingerprint/faceprint.

I understand, but I don't agree because my rationale was that if isAvailable is true, you can let your user use bio ID with your app. And it's not up to your app to encourage configuring a system-wide feature.


Selection never shows up when using Ajax

Release version (Select 4.0.1)
HTML
<select id="search_customers" style="width: 300px;"></select>
Javascript:
$("#search_customers").select2({
                multiple: false,
                allowClear: true,
                ajax: {
                    url: "@Url.Action("SearchCustomers", "Home")",
                    dataType: 'json',
                    delay: 250,
                    data: function (params) {
                        return {
                            id: params.term, // search term
                        };
                    },
                    processResults: function (data, params) {
                        return { results: data } // Data is a List<T> of id an text
                    },
                }
            });

The dropdown works, and I can see my records, however, when I click on one of the options the box closes, and the selected record isn't shown. My box looks like this

I've tried everything I can think of. The issue appears in all browsers. The data being return is a list of id/text pairs.
Controller code
var customers = this.service.SearchCustomers(id).Select(x => new { id = x.CustomerID, text = x.CustomerName }).ToList();

return Json(customers, JsonRequestBehavior.AllowGet);

It turns out the ID number was returning "0 4567", and the leading space/spaces in some cases were causing the error. Modifying my c# code to this
var customers = this.service.SearchCustomers(id).Select(x => new { id = x.CustomerID.Trim(), text = x.CustomerName }).ToList();
fixed the issue.

This appears to be a usage question, rather than a bug report or feature request.  Please see our contributing guidelines.
Usage questions should be discussed on the forums instead.


Fix: clear envBindings when change project

Signed-off-by: xianyue<EMAIL_ADDRESS>Description of your changes

Fixes # Fix: clear envBindings when change project
the envBindings may not be exist in new project
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run yarn lint to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@xianyue390348 Thanks for your contribution.


direct users to the readme in the docs repo

Adds a small link to the docs readme to ensure users find the proper procedure for making a docs PR.
Signed-off-by: Jacob Salmela<EMAIL_ADDRESS>

Hmm, I don't think we need this introduction.

My thought is that reading a README is a common rule and we don't have to emphasis this in a separate repository.

Fair enough.  I just got lost for a bit jumping between ebiten in your personal repo and the docs in the ebiten org.  I figured most people land here first.  Feel free to do what you need with this PR.

Oh I realized that you changed CONTRIBUTING.md rather than README.md I'm sorry I was misunderstanding. Adding a notification there seems to make sense.

Fair enough. I just got lost for a bit jumping between ebiten in your personal repo and the docs in the ebiten org.

Good point. I plan to this repository to github.com/ebiten in near future (3 or 4 years later?), so this might decrease such confusions to some extent.

I figured most people land here first. Feel free to do what you need with this PR.

I accept this change as it is. Thanks!


Add parameters to configure the docker image to use in the invoke tasks

What does this PR do?
Add parameters to configure the docker image to use in the invoke tasks
Which scenarios this will impact?
Motivation
We would like to have the ability to use locally built Agent images to be used in e2e tests in the future. These images will be pushed to a registry so we need to provide the image path
Additional Notes
https://datadoghq.atlassian.net/browse/ADXT-497

/merge


Simpler PenguinDataset

To make the data reading aspect a little easier to understand, we intend to embed a simpler version of the PenguinDataset directly into the notebook. The src/ml_workshop/_penguins.py will remain untouched and can still be used as before.
Thought process around the 'simpler' class (discussion between @jatkinson1000 and @ma595)
Load pandas df in notebook:
Put the definition of the PenguinDataset in the notebook:

Remove x_tfms and y_tfms
Hardcode one_hot, tensor, fp32 into __getitem__

Propagate change to

solution notebook
colab
ex 2+? Consider leaving this as is.

from typing import Optional, List, Dict, Tuple, Any

# import pytorch functions necessary for transformations:
from torch import tensor, float32, eye

from torch.utils.data import Dataset
from torchvision.transforms import Compose

from pandas import DataFrame

from palmerpenguins import load_penguins

class PenguinDataset(Dataset):
    def __init__(
        self,
        input_keys: List[str],
        target_keys: List[str],
        train: bool,
        transform: Optional[bool] = False,
    ):
        """Build ``PenguinDataset``."""
        self.input_keys = input_keys
        self.target_keys = target_keys

        self.full_df = _load_penguin_data()
        self.split = _split_data(self.full_df)["train" if train is True else "valid"]

        self.transform = transform

    def __len__(self) -> int:
        return len(self.split)

    def _test(self):
        return "hello"

    def __getitem__(self, idx: int) -> Tuple[Any, Any]:
        # get the row index (idx) from the dataframe and
        # select relevant column features (provided as input_keys)
        feats = self.split.iloc[idx][self.input_keys]

        # this gives a 'species' i.e. one of ('Gentoo',), ('Chinstrap',), or ('Adelie',)
        tgts = self.split.iloc[idx][self.target_keys]

        if self.transform:
            # Put the features in a more suitable format for PyTorch

            # Exercise #1: convert the feats to PyTorch
            feats = tensor(feats, dtype=float32)

            # Exercise #2: convert this to a 'one-hot vector'
            target_names = sorted(self.full_df.species.unique())

            tgts = eye(len(target_names))[target_names.index(tgts[0])]

        return (feats, tgts)

def _load_penguin_data() -> DataFrame:

    data = load_penguins()
    data = (
        data.loc[~data.isna().any(axis=1)]
        .sort_values(by=sorted(data.keys()))
        .reset_index(drop=True)
    )
    # Transform the sex field into a float, with male represented by 1.0, female by 0.0
    data.sex = (data.sex == "male").astype(float)
    return data

def _split_data(penguin_df: DataFrame) -> Dict[str, DataFrame]:
    valid_df = penguin_df.groupby(by=["species", "sex"]).sample(
        n=10,
        random_state=123,
    )

    # The training items are simply the items *not* in the valid split
    train_df = penguin_df.loc[~penguin_df.index.isin(valid_df.index)]

    return {"train": train_df, "valid": valid_df}

Another 2c:
Could you get rid of the transform and instead hard code the processing? I can't see that anyone will ever use it without transform=True.
You could have the default code in there to start, run and show the obvious issues, then replace the code for feats and tgts? Would remove the 'hackiness' and potential confusion.
The _load_penguins function could just be subsumed into the __init__ method of the PenguinDataset?
Same for _split_data?
I only just see how Jim did this by running the split on the fly but ensuring it will always be the same split by fixing the seed.

thanks @jatkinson1000, I'll make those changes.

from typing import Optional, List, Dict, Tuple, Any

# import pytorch functions necessary for transformations:
from torch import tensor, float32, eye

from torch.utils.data import Dataset
from torchvision.transforms import Compose

from pandas import DataFrame

from palmerpenguins import load_penguins

class PenguinDataset(Dataset):
    def __init__(
        self,
        input_keys: List[str],
        target_keys: List[str],
        train: bool,
    ):
        """Build ``PenguinDataset``."""
        self.input_keys = input_keys
        self.target_keys = target_keys

        data = load_penguins()
        data = (
        data.loc[~data.isna().any(axis=1)]
        .sort_values(by=sorted(data.keys()))
        .reset_index(drop=True)
        )
        # Transform the sex field into a float, with male represented by 1.0, female by 0.0
        data.sex = (data.sex == "male").astype(float)
        self.full_df = data

        valid_df = self.full_df.groupby(by=["species", "sex"]).sample(
                n=10,
                random_state=123,
            )
        # The training items are simply the items *not* in the valid split
        train_df = self.full_df.loc[~self.full_df.index.isin(valid_df.index)]

        self.split = {"train": train_df, "valid": valid_df}["train" if train is True else "valid"]

    def __len__(self) -> int:
        return len(self.split)

    def __getitem__(self, idx: int) -> Tuple[Any, Any]:
        # get the row index (idx) from the dataframe and
        # select relevant column features (provided as input_keys)
        feats = self.split.iloc[idx][self.input_keys]

        # this gives a 'species' i.e. one of ('Gentoo',), ('Chinstrap',), or ('Adelie',)
        tgts = self.split.iloc[idx][self.target_keys]

        # Exercise #1: convert the feats to PyTorch
        feats = tensor(feats.values, dtype=float32)

        # Exercise #2: convert this to a 'one-hot vector'
        target_names = sorted(self.full_df.species.unique())

        tgts = eye(len(target_names))[target_names.index(tgts.values[0])]

        return (feats, tgts)

If the above all works I think that is a lot more transparent to students what is going on, and directly introduces the Torch Dataset. Nice one.


Changed start behaviour

Hello,
I have adjusted the behavior of the robotic lawnmower so that the robot does not go into “start override” mode when starting, but into normal start mode. I have implemented the clean spot command to let the robot run for a specified time (“start override”). This together makes it possible, for example, to send the robot home weather-controlled and it can then resume its normal work schedule.
Purtzel

There is no need to create comments with your name on it - everyone can see in the git history who changed the code.


Support keep-alive and format options in Ollama chat requests

I added an OllamaChatRequestOptions class and wired it into call() and stream() in OllamaChatClient. It's optional and won't break existing code, but it provides a couple of new options that I find very convenient.
The keep-alive option will keep your model loaded in Ollama for the duration you specify.
The format option was there in part already, but not fully wired up. There was no way to actually use it from an application. It is a way to tell Ollama that you only want JSON output instead of chat.

Hey @scionaltera ,
Thanks for adding support for the missing, additional properties.
I believe thought that we can reuse the existing OllamaOptions class rather than creating a new one.
This has multiple benefits as it allows auto-configuration properties stetting as well as the Run-time options.
So, IMO we an add the Ollama additional properties to the existing OllamaOptions.java (updating the builder) and use it in the ChatClient to initialise the ChatRequest (feel free to extend the ChatRequest with the missing properties).
But then we have to make sure that those new properties added to the OllamOptionsn are not passed as options. For this you need to extend the filterNonSupportedFields to filter those out before the options are passed to the request.
I hope this makes sense. Let me know if you would interested to give it a try. Otherwise i will do it myself.

No problem, I thought that might be the desired approach but I hesitated because the parameters I was working with seemed to have very little to do with the ones in OllamaOptions. I'm happy to refactor it.

Thanks @scionaltera ,
I agree that filterNonSupportedFields reveals a bad design, there are similar issues with some of the other model options. We are exploring the possibility to split the ModelOptions in to sub-category (e.g. model-related and non-model related such as request params, function calling configs ..).
But for now we have cope with the existing limitations.

@scionaltera, can you please pull/rebase our code on top of upstream/main without merging (e.g. git pull -r upstream/main).
Otherwise you can open a new PR with your latest code on top of upstream/main

Squashed and merged at: aca8ffd400fd3e3851aec8dc6705c6613d456073
Additionally:

add support for the template advanced parameter.
update Ollama docs with the new config parameters.

Thank you again @scionaltera .
For consistency I added the template parameter as well and updated the docs.
What value for the keep-alive are you commonly using? I see that it is 5 min by default.

I've been setting it to 1 hour. That's long enough that I can go make changes in my code and the model is still there when I'm ready to run it again.


Ensure that all core recipes are tested via travis

Make framework use recipe-core/recipe-cms instead of individual composer require calls.
This is a task pulled out of https://github.com/silverstripe/silverstripe-framework/issues/6860

Proof of concept is at https://github.com/silverstripe/silverstripe-s3/pull/10
Note that all that is necessary is to use silverstripe/recipe-core in place of all the inlined dependencies in .travis.yml.


extension dependency problem

Failed to build openfl application which uses admob extension with google-play-services dependency with this error
error: package com.google.android.gms.ads does not exist
import com.google.android.gms.ads.*;

This is admob-extension project properties
android.library=true
target=android-23
android.library.reference.1=../extension-api
android.library.reference.2=../google-play-services_lib
android.library.reference.3=../android-support-v4

Can't link google play services into admob extension. It seems google play services dependency from project.properties is not being read.

I think, since it's using gradle now, the extension needs to be modified too?
https://developers.google.com/android/guides/setup


Add more ENV vars for better out of the box deployment - fixes #205

Add more ENV vars for better out of the box deployment - fixes #205

do you have an idea why the test is failing. Does the CI use anon biding?


Is there a way to list all the failing tests at the bottom/end of the report?

We're now running Minitest with a fairly large test suite. When a test fails it's getting more and more inconvenient to track down which one it was, in order to fix it. It would be great if we could have only the failing tests reported again at the bottom. Is there any way to currently do that please?
Otherwise, this approach seems promising: https://stackoverflow.com/questions/63517155/minitest-how-to-see-the-failed-tests/63525669#63525669

This is now possible with our SpecReporter!
You can use the print_failure_summary option:
Minitest::Reporters::SpecReporter.new(print_failure_summary: true)

Documentation


Implement yara -u to uniq the results

Sometimes the same rule matches several times in a single binary, it will be good to have yara -u to | uniq the results and only the first match of any rule

Can you give an example of the same rule matching multiple times. I haven't read the code in a while but I think this shouldn't happen.

pancake@~/yara-bug$ ls
rules.yar test.txt
pancake@~/yara-bug$ cat test.txt
foofoobar
pancake@~/yara-bug$ cat rules.yar
rule regex : bug {
	meta:
		author = "pancake"
	strings:
		$regex = /foo([^\ ]*)/
	condition:
		all of them
}

pancake@~/yara-bug$ yara -s rules.yar test.txt
regex test.txt
0x0:$regex: foofoobar\x0A
0x3:$regex: foobar\x0A
pancake@~/yara-bug$

This is not the rule matching twice, but the strings. My opinion is this is not a good idea, because I want to know all the offsets when I ask to see the strings.

yes, i have posted the example of the wrong issue (moved there). check the comment above again, i its now updated.
the behaviour im looking for is to stop searching for a rule that matches exactly the same string. This will speedup results and reduce noise in output, because for me in this case i just want to see that this file contains "foo" at 0, and i dont care if there's any other foo after that

The option you are looking for is probably --fast-scan. With this option once YARA finds a match for a particular string it stops looking for more matches for the same string. Notice however that $str1 and $str2 are considered different strings even if they are both "foo", so YARA will look for the first match for $str1 and the first match for $str2. Also, not all string are suitable to be optimized with --fast-scan, if the string is used in a condition like #str > 10 (number of occurrences of $str larger than 10) YARA will keep looking for more matches even if you are using --fast-scan, because it needs them in order to verify if the condition is true or not.


[Bug] GraphNode is created instead of Node if selected from Recent list

Windows 64bits - v2.1.3
Issue description:
If you add a Node to a scene and select it via the Recent list, it creates a GraphNode instead. Doesn't seem to happen with any other node.
http://i.imgur.com/e2zphKm.gif
Steps to reproduce:
Add a new node to a scene (CTRL+A), select Node from the Recent list.

Can confirm.

can confirm in v3 too


new cla Update test_file

@laojiuh, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

1w2


Admin dashboard reports: Total money managed section

Part of https://github.com/opencollective/opencollective/issues/4300
Design file: Figma

Collapsed view

[x] For the first part of this issue, HostMetrics should provide all the data we need
[x] The chart must use the primary color of the collective. For now, we've decided to build it with fixed percentage widths and without any JS library, just some good old CSS.

Historical view

[ ] When clicked, "See historical" should expand and fetch the data it needs dynamically
[ ] On HostMetrics add a new totalMoneyManagedProgress field:

[ ] Args: year (required)
[ ] Response: [{ date, amount  }]

[ ] Use a chart library to display the progress across time
[ ] The select filter should include all the years of activity for this collective. We can achieve that with something simple like getYearsFrom(getYear(collective.createdAt)).

@Betree : I'll take this one if no objections, or unless you already have plans to do it yourself. 😉  😄

@SudharakaP Feel free to implement the Collapsed view part. For the historical view, I want to explore a bit the API queries to try and see how we can re-use as much as possible what we have while making sure performances are there.

@Betree : So I've done the initial implementation of the reports section. Hope it looks good. 😄
Few things to note;

I was exactly sure if I did the calculations correctly here;

https://github.com/opencollective/opencollective-frontend/blob/bc49043dac6e1292a591eb93b959e15c5e7eb3f2/components/host-dashboard/reports-section/TotalMoneyManagedSection.js#L121-L126
Let me know if you see any issues.

Small deviation from the design; I used the words Collectives and Host Organization instead of My Collectives and My Host Organization in the labels. It made it a bit easier to make it work well with the smallest size mobile screens without splitting it to two lines. Hope that's okay? 🙂

@Betree : If you haven't already started, I'll be working on the historical view of this? Hope there's no objections. 😉

@Betree : If you haven't already started, I'll be working on the historical view of this? Hope there's no objections. wink

Just for the record; it was discussed that this will be looked at first by Ben (@Betree) as it involves some tricky revenue metric calculations.

plan

[ ] close out this issue


Need to update twitter icon in mj-social-element

Describe the bug
The twitter icon shown through mj-social-element still displays the old icon. Need to update it to the newer icon. We can, of course, pass src prop but this should be default behaviour ideally.
To Reproduce
Steps to reproduce the behavior:
Pls check the code: https://mjml.io/try-it-live/RiRg8c8gnw
Expected behavior
mj-social-element with "twitter" as name show display the newer "X" icon

Well, we kept those default value from earlier version of MJML. I would advise to use a custom social element instead to host your own icons as we had some issue in the past cf #2551
Twitter is not even Twitter anymore and called X 😬


Add and configure automated focal point detection in Wagtail

Having investigated this as far as a peer debug via strace with RC sysadmins, two thread processes are deadlocked on a mutex when opencv is being used with Apache and mod_wsgi. Various troubleshooting options (including process timeouts, using no threads, etc.) have failed, and I believe getting this to work would end up being the equivalent of significant story points.
Given that it is not essential, I am marking it won't fix and closing. If we change our stack or have a compelling need, we can revisit (probably with a blank VM for troubleshooting).
Sorry this turned out to be such a pain.


[Enhancement] Do not display type when table comment is empty

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/Table.java
1
1
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/Table.java
1
1
100.00%
[]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Improves reliability of e2e testing

Major changes

Switch to global operator where possible
Refactored location of tests to reflect either global or namspaced testing

Also, I'm curious -- after the changes should we choose global e2e testing as default, and only go for namespaced testing only when it's truly necessary?

Also, I'm curious -- after the changes should we choose global e2e testing as default, and only go for namespaced testing only when it's truly necessary?

The way I've approached splitting the tests is only if the test has to be namespaced should it be so. For example, those tests that require adding an env var to the operator need to be namespaced whilst those tests that add changes to the integration platform can still be global. Therefore, the namespaced tests tend to be defined as install-related, cli-related and change-to-the-operator-related.

The OpenShift workflow keeps failing, so there seems to be something which may not be just flaky.

@squakez
You might like to review the changes I have made to promotion in the final commit of this series. The promotion tests now all pass successfully (locally at least) with these changes.

It really fails one of the promotion tests:
    --- FAIL: TestKamelCLIPromote/plain_integration_promotion (0.31s)

@squakez @christophd @tadayosi
Can we look at merging this now please?
The oppenshift tests are failing but the errors are much more random (quarkus-native tests not spinning up, Environment tests failing then passing ....). The same tests are comfortably passing on OCP4 test suite so the tests themselves and camel-k seem less a problem than the OCP 3.11 platform. I can continue looking but the priority feels a lot lower now.

@phantomjinx After merging this, it appears that the openshift-build workflow starts to be unstable again. IIRC I haven't seen this type of test failure before:
=== RUN   TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit
Integration "jvm-to-native" created
=== CONT  TestNativeIntegrations
    test_support.go:116: Get "https://<IP_ADDRESS>:8443/apis/camel.apache.org/v1/namespaces/test-22193ffe-620a-425d-a687-b15526c6fa0d/integrationkits?labelSelector=camel.apache.org%2Fkit.layout%3Dnative": http2: client connection lost
=== CONT  TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit
    testing.go:1113: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
=== CONT  TestNativeIntegrations
    dump.go:47: -------------------- start dumping namespace test-22193ffe-620a-425d-a687-b15526c6fa0d --------------------
    test_support.go:1851: Error while dumping namespace test-22193ffe-620a-425d-a687-b15526c6fa0d: Get "https://<IP_ADDRESS>:8443/apis/camel.apache.org/v1/namespaces/test-22193ffe-620a-425d-a687-b15526c6fa0d/integrationplatforms": dial tcp <IP_ADDRESS>:8443: connect: connection refused
    test_support.go:116: Get "https://<IP_ADDRESS>:8443/apis/image.openshift.io/v1?timeout=32s": dial tcp <IP_ADDRESS>:8443: connect: connection refused
--- FAIL: TestNativeIntegrations (277.28s)
    --- PASS: TestNativeIntegrations/unsupported_integration_source_language (0.64s)
    --- FAIL: TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit (262.36s)

is this something we can improve?


NullPointerException after updating IntelliJ

Every time after an IntelliJ update, a NullPointerException occurs when starting tomcat.
Error displayed:
Error running 'Tomcat': java.lang.NullPointerException
There seems not to be any more logging than that.
It can only be fixed by completely removing the Smart Tomcat configuration and adding a new one.

me too

2.0 works fine - as soon as I upgrade to 2.6 - I have NPE mentioned above.
Is there any way to run plugin in verbose mode or get some run logs?

Hi, i'm unable too to use the plugin. My laptop==> OSX:10.13.1, plugin:v2.6, idea:2018.3.5
Error running 'tomcat': java.lang.NullPointerException

Still happening for me with latest plugin, haven't been able to solve at all.

@wizofaus  could you share intellij idea and smarttomcat version?

Still happening for me with latest plugin, haven't been able to solve at all.

@wizofaus could you share intellij idea and smarttomcat version?

Actually it turns out the upgrade hadn't worked for some reason, after re-upgrading and re-starting and re-creating the configuration all is good, thanks!


Create Kaiken Compose Bindings

https://github.com/dropbox/kaiken/pull/113 shows a brute force approach to integrating kaiken with compose. Primarily by creating a CompositionLocal for auth scopes https://github.com/dropbox/kaiken/blob/42aa9861df9670abea67634d274b7c8acf8d2006/sample/sample-with-di/helloworldfeature/src/main/java/com/dropbox/kaiken/sample/advancedsample/helloworldfeature/LoginFragment.kt#L52
This was prone to user error as folks might forget to call this function.  Instead we should create a KaikenContext and extension functions on kaiken fragtivities to launch into the KaikenContext. This follows similar patterns to how coroutines or composables work. Example api can look like this:
 //create a KaikenContext
setKaikenContent { injector, navigator ->
  val foo =  injector.getFoo()
  MyComposable()
}

@KaikenComposable //compiler plugin to validate called inside a kaikenContext
fun MyComposable(){
  val presenter by Kaiken<MyComposablePresenter>() //grabs KaikenContext and resolves this
 //make magic
}

where setKaiken hooks into the current kaiken locateInjector apis. Similar the setKaikenContent will create the compositionlocal of the injector and will finally will delegate to the setContent fractivity call.

#113


Dose Mutex lock with ttl?

I see the document https://godoc.org/github.com/coreos/etcd/clientv3/concurrency.
etcd clientv3 has its own Mutex, but there is not ttl for Mutex.Lock().

@YuleiXiao yes, the ttl is attached to the client's Session. It's currently hard-coded to 1 minute, there's an open issue to make it configurable (#5989)

@heyitsanthony OK, thank you very much


fix for DataFrameNaFunctions return type hints

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-1000455

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.

Fixed DataFrame return type hint import path for DataFrameNaFunctions class methods.

I have read the CLA Document and I hereby sign the CLA


Xenos shouldn't be able to strip marines

See https://github.com/space-wizards/space-station-14/pull/26908


Use message pack for project.razor.* configuration file

This change uses the message pack formatters to serialize and deserialize the project configuration file. Of particular note, I added support to the message pack formatters for "skimming". The idea is that, when deserializing tag helpers, we look at the checksum first and determine whether that tag helper is in our cache. If it is, partially deserialize the tag helper by skimming through the byte stream. While skipping, we ensure that the SerializerCachingOptions are populated correctly with cached streams and MetadataCollections. In addition, because we're no longer serializing the file as "json", I've changed the file extension to ".bin".

My only question is why Skim uses ReadArrayHeader and not ReadArrayHeaderAndVerify

I looked through and didn't spot anyplace where Skim(...) didn't use ReadArrayHeaderAndVerify where the number of elements is know. Do you have a pointer to the code where you noticed this?

/azp run

I looked through and didn't spot anyplace where Skim(...) didn't use ReadArrayHeaderAndVerify where the number of elements is know. Do you have a pointer to the code where you noticed this?

I saw this and figured it could be ReadArrayHeaderAndVerify(checksums.Length), then saw the others and thought it must be deliberate. Now that I've had a better look, I think that might be the only place it could apply.

I saw this and figured it could be ReadArrayHeaderAndVerify(checksums.Length), then saw the others and thought it must be deliberate. Now that I've had a better look, I think that might be the only place it could apply.

Good catch! Very good idea to use ReadArrayHeaderAndVerify(...) and avoid a Debug.Assert.


2015-08-12 JSOxhog BBQ

You know what goes really well with JavaScript? Barbecued stuff.
Seeing as we have guaranteed (yeah right!) good weather and long evenings, we'll trade speakers for some quality barbecue time and a chance to catch up.
The barbecue is open to all, and we'll have a selection of vegetarian-friendly options as well as the usual meat-fest.
Date
Wednesday 12th August 2015, 6:30pm
Core actions

[ ] Confirm sponsorship for venue/food/drinks (@spikeheap)
[ ] Organise venue (@peterjwest)
[ ] Organise the food (@peterjwest)

Event organisation

[ ] Ensure someone has carried out the actions above
[ ] Add to MeetUp.com (just prior to preceding event)
[ ] Announce event
[ ] There'll be some setup required

We could consider charging a nominal fee for this event to help contribute to the food costs and generally ensure that people who've signed up do attend. I wouldn't want this to be any more than the price of a beer (and you'll get one back with the food, so it's good value ;)).

Link to Meetup.com draft: http://www.meetup.com/JSOxford/events/221686941/

I love this!

We're now going to have regular food at St Aldates Tavern, mainly due to budget constraints.
Have phoned them and now waiting for them to reply to an email.
Moved this to 7pm, since we're not BBQing/outside now.
Will update the issue later.

This happened. It was pretty good. We should do it again sometime

We should do it again sometime.

Totes. In the autumn please, I was kinda bummed to miss this one. The JSOxford community is a good one.
Any pics to share of a smiling Ryan tucking into roast beef and yorkies with a cheddar mash and a raspberry coulis?  :smile_cat:
I always like a good foodie pic. @iiSeymour -- of tacocat fame -- is pretty good about tweeting pics of delicious food from the many conferences he attends and I love him for it.

In the end it was just a social, we didn't have enough sponsorship to do a hog roast :(


Update http-dependency to 0.1.13

Hello!
I'd like to update http (https://github.com/hyperium/http/blob/master/CHANGELOG.md) to latest version (0.1.13) because it contains fixes for bugs in urls that caused panics upstream.

Is there a reason this must be done in h2?
The dependency versions in Cargo.toml are intended to describe the minimum version required at an API level. However, Cargo will pull in the most up to date versions. So, you should be getting http 0.1.13 by default w/o needing to change h2.

yeah, you are right. Closing this! thx


Feature/offline support

Related to #86

So this does the download and cleaning up.
But I am stock in the views, side.
Some questions

First, do I have to check every single file used in my local file structure right? If they do not exists I fallback to the hosted one.
Am I assuming that they have configured Plug.Static, right?! Because I will need to to the to: ""  configuration from Plug.Static to be able to setup the URL to the file.

Thanks! I put myself on an the reviewer for this; I'll try to do a solid review today.

:) awesome. 🔥🔥🔥

@bruce @benwilson512 I simplify the workflow.
If you download the assets it will use the local assets if not then it will use the remote one. This way you don't have to be dealing with using local or remote which I don't think is a good idea to pass it throw any config because that's relative to people, no necessary to environment.

Great; I'll test this in a project.

@bruce hey man, any updates on this?

This is looking good, but going to wait to merge this after #93 (imminent).

@bruce mate when can we have this on deployed? Any time sooner?

@yordis The much-awaited PR is in after some testing and a merge with the socket changes.
One change I made: renamed the removal mix task clean_up -> remove
I did see one small problem that it would be good to get a PR for: the GraphiQL Workspace tries to load the glyphicons-halflings-regular font and fails (check the console) when offline -- it would be good to have that taken care of as well as part of the download process.

@bruce could you create an issue witht he font issue and assign it to me? I will work on it for sure

@yordis I can't assign (as you're not a collaborator, probably), but you're mentioned here: #99. Thanks!


update README

This PR will add the updated README in the development branch.

Thank you for reviewing this.


updated permissions to fix issue #74

Fixes: #74

@Aravind04101996 Thanks for your contribution, LGTM!

Released as v1.1.1!


Second set of fixes

Load css
Inherit from DOMWidget (how did it ever work without this!?)
Use ES6 promise logic correctly

@cekees with these changes I'm able to use the DrawControl notebook completely.  Please let me know if there's anything else missing!

Great! I've only found one problem so far, that's in the GeoJSON notebook when it removes a layer:
Uncaught (in promise) TypeError: Cannot read property 'id' of undefined {stack: (...), message: "Cannot read property 'id' of undefined"}message: "Cannot read property 'id' of undefined"stack: (...)get stack: function () { [native code] }arguments: nullcaller: nulllength: 0name: ""prototype: StackTraceGetter__proto__: function Empty() {}<function scope>set stack: function () { [native code] }__proto__: Errorwidget.DOMWidgetView.extend.remove_layer_model @ leafletwidget.js?v=20150521171811:381(anonymous function) @ widget.js?v=20150521171811:723

I put the images directory in the wrong place, so some of the markers aren't displaying, but I'm fixing that.

Ok, the last commit should fix the layer removal.  It turns out I was doing something wrong with the ViewList, but it should be fixed now.

Thanks!


CloudSQL users unmanageable

Hi,
using CloudSQL template for CloudSQL MySQL and configuring some users return the following error since the second time configuration are deployed:
- code: MISSING_METHOD_IN_COLLECTION
  message: Method 'get' does not exist for collection 'users' in descriptor url 'https://www.googleapis.com/discovery/v1/apis/sqladmin/v1beta4/rest'

So, the first time instance and users are created, after the deployment is no more applicable (also without modifying users)
I've found a similar issue: https://github.com/GoogleCloudPlatform/deploymentmanager-samples/issues/142
This make the template unusable
Thanks

For people who are facing the same issue solution is:
# Failed one
- name: {{ deployment }}-dbUser
  type: gcp-types/sqladmin-v1beta4:users

# Correct one
- name: {{ deployment }}-dbUser
  type: gcp-types/sqladmin-v1beta4:sql.users.insert

After examine the descriptor json https://sqladmin.googleapis.com/$discovery/rest?version=v1beta4
There are four methods available: sql.users.list, sql.users.insert, sql.users.delete, sql.users.update


Build Failing

Current build status says failing? Is this correct?

2 years later...

3 years later...


Sitemap generator

I want to merge this change because...

Screenshots

Pull Request Checklist

[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).
[x] Changes are mentioned in the changelog.

Commited few fixes:

Used prettier to reformat code
Added 1 as  return code in case of error - without it script returns 0 which means OK in unix :)
Added extra checks for

dist folder existance
check if url(changed name from "hostname") exists and starts with http:// or https:// - some validator in the internet are arguing if urls do not have http or https


Add management command to generate sample data

Generates sample users, layers, images, tags, and favorites. All data,
except for superuser accounts, will be deleted.
To run this command:
./scripts/manage.py sampledata

There's no real need to merge this into the project but it could be useful for testing purposes.

+1. Tested.
I have no objection to merging this in but it would be nice to add some sort of flag or test so that it is not possible to run it on prod.

Rebased.


gps_common/GPSFix has wrong time data

The gps/gps topic publishing gps_common/GPSFix messages is using the utc field from the novatel messages to fill the time field in the ROS message instead of GPS time.

Ah, that's a good catch.  That's definitely not correct, although something to note is that the GPGGA log does not actually report GPS time, so in order to fill that field in properly, the driver would need to get the GPS time from a log that it synchronizes together with GPGGA such as BESTPOS.  We could try to estimate it if we fail to synchronize logs for some reason, but I feel like that might be misleading and it'd be better to just leave it blank...
Although the more I look at it, the more I feel like the current approach to generating GPSFix messages -- which is to combine data from GPGGA and GPRMC logs and augment them with BESTPOS logs when possible -- might be better if it were inverted and it used BESTPOS logs as the basis for it and augmented that with GPGGA/GPRMC data when possible.  I might test that out and see how it works...

All right, if you'd like to take a look at it, I think the branch in #74 should put the correct timestamps in GPSFix messages.  It will also use BESTVEL logs to fill in the speed/track and PSRDOP2 logs to fill in the DoP values if it is configured to publish those.
This is actually a pretty significant rewrite of how GPSFix messages are generated, so I'd like to get some more testing for it before I merge it into master.

Does it make sense to use INSPVA as the basis for GPSFix? I didn't compare the fields in detail, but they seem to have some overlapping data. INSPVA has gps week and seconds.

I think BESTPOS is preferable over INSPVA; BESTPOS is supposed to be the best position calculated by the receiver, which can incorporate INS data, but also INS logs are only available on receivers with SPAN support.


'NoneType' object has no attribute 'strip' error when editing the dashboard setting

A clear and concise description of what the bug is.
Expected results
Dashboard title changed
Actual results
'NoneType' object has no attribute 'strip' appear
Screenshots

How to reproduce the bug

Go to 'Dashboard' section
Click on 'Edit record' on dashboard
Edit the dashboard title and save
See error

or

Go to 'Dashboard' section
Click on '+' button which is 'Add a new record'
Save without content
See error

Environment
(please complete the following information):

superset version: 0.28.1
python version: Python 3.6
node.js version: 10.16.0
npm version: 6.9.0

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

Hi @syazwan0913,
Please fill out the issue template, thank you

Thanks @syazwan0913, can you fill the "How to reproduce the bug" steps

Replicated your steps and got no errors. Can you post the server log?

Is it on superset version 0.28.1 ?

Fixed it already

Fixed it already
How did you fix it?

@AasthaPoddar use the latest version


Assignment one

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding code
What did you learn from the changes you have made?
using functions to analysis database
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
it was an standard approach
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
none
How were these changes tested?
good
A reference to a related issue in your repository (if applicable)

Checklist

[X ] I can confirm that my changes are working as intended

Hello Niaz,
Thanks for the feedback!
Should I close the pull request?
On Mon, Dec 16, 2024 at 12:35 Niyaz Nazari @.***> wrote:

@.**** commented on this pull request.
Thank you for submitting assignment 1. Everything looks correct.
Point: 30/30
—
Reply to this email directly, view it on GitHub
https://github.com/Yara607/sql/pull/1#pullrequestreview-2506859477, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BM4AX6PHC7WH4JNEYMFASET2F4FM3AVCNFSM6AAAAABTU37JLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBWHA2TSNBXG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Images not Vulnerable

C:\labpano_github\exifLooter\images> exifLooter --image GPS_frame00000.jpeg
These image/images not Vulnerable
Hello. Whats the "These image/images not Vulnerable" means ? how can i fix it ? :P Thank you :D
My photos are from labpano 360 camera

Image not Vulnerable means There is not any Geolocation Metadata on those images.

ok thank you :)


Parse.File Upload - Parse.com

Hiya,
I was wondering if there is a best practice way to use the Parse.File upload of the Parse.com-SDK.
It seems a bit odd to me to convert the image into base64 and send it to the server.
https://parseplatform.github.io/Parse-SDK-JS/api/classes/Parse.File.html
Is anyone using the Parse.com Server + react-native-camera ?

interested here too


Update README.textile

Hi,
I added section "Books" and a link to the Arquillian in Action written by Alex Soto Bueno and Jason Porter for Manning Publications. We believe this book is a great resource and all members of community will benefit from this information. If you find this inappropriate, please let me know where I can publish it.

Nothing against the book, it's allready front page on the website; http://arquillian.org/
But i don't think the README for the website source is the correct location for this. We'll add a actual books section somewhere on the website instead.

We'll be greatful if you do this. Thank you.
 Datuma 2:40 Srijeda, 19. Kolovoz 2015., Aslak Knutsen<EMAIL_ADDRESS>je napisao:

Nothing against the book, it's allready front page on the website; http://arquillian.org/But i don't think the README for the website source is the correct location for this. We'll add a actual books section somewhere on the website instead. —
Reply to this email directly or view it on GitHub.


GPX files with multiple  segments - how to dissect?

how would I load this example GPX and dissect into separate named tracks?

Duplicate of #60.


store upload timestamp

I suggest storing the upload timestamp of new files supplied to the database and showing that timestamp on the file report.

file upload time is added.


Let lidar ray come across attached vehicle

Currently the point cloud generated by ray_cast sensor has many points fall on to the top of the ego vehicle (its like 10 rings out of 32 rings). Near objects cannot be seen with a lot of points blocked by ego vehicle. Also the simplified shape of vehicle make this problem worse.
So please add option to make the ray_cast sensor ignore attached vehicle in case implementing precise lidar point clouds is still under development.

Solved by putting lidar higher on the vehicle. But still hope that this option can be added

Any update on this?


Correct intra-page links in the workflow spec

Add a missing link for CreateMachineImages.
Fix a typo in ResizeDisks target.
Lowercase the #type-* anchor targets. Uppercase anchors magically work on GitHub, but not on googlecloudplatform.github.io.

/ok-to-test


Crash when both AE2 (forge) and Modern Industrialization (fabric) are loaded

Describe the bug
When both AE2 and MI are loaded together, it results in a crash on launch.
Steps to reproduce

Install Sinytra Connector 1.0.0-beta19
Install AE2 15.0.3, MI 1.7.4, and their dependencies
Attempt to start up the game
Observe a crash

Logs
https://mclo.gs/aneOzSW
Additional context
No response

I fixed a conflict with AE2's early registration, though MI will still initialize its addon items without registering them. This is due to AE2 not running its addon entrypoint on Forge. It's also not possible to run a bridge like we do with other mods because AE2 for Fabric and Forge are two independent versions.
Fortunately, MI provides a config option to disable AE2 integration entirely. This comes in handy when you're running the Forge version of AE2, which is not supported by the integration. To do so, open the modern_industrialization.toml config file and set enableAe2Integration to false. AE2 and MI will then run fine.


WIP: WEBAPP-174: Fix tests

Relates to issue 274 right? https://integreat.atlassian.net/browse/WEBAPP-274

@klinzo oops yep, will rewrite the branch history


Add Elm support

Can you please provide a screenshot? Also, is the Elm version changes so often that it needs to be shown in prompt? Would it be useful for users and make the clutter in prompt? Is there any Elm version management systems, like nvm for Node.js?

Merged with #528


Update to Fullcalendar 2.7.2

I'm no longer maintaining a project that uses this gem, so I appreciate the maintenance you and others give back.

@gr8bit or @bokmann can you publish this? :)


cant able to authentication

Type: Feature Request
I am trying to get connect my visual studio with github but im not getting access
Extension version: 0.86.1
VS Code version: Code 1.88.1 (e170252f762678dec6ca2cc69aba1570769a5d39, 2024-04-10T17:41:02.734Z)
OS version: Windows_NT x64 10.0.18363
Modes:

There aren't enough steps here for me to try to repro the issue.


Aligning the text message properly under the custom shortcut submenu of tools.

Describe the bug
The text message inside the box is not aligned properly after the user click on any of the option mention under the keybinding preference.
To Reproduce
Steps to reproduce the behavior:

Go to simulator
Click on Tools
Select Submenu Custom Shortcut
Click on any of the option under the keybinding preference.
See the bug.

Expected behavior
The text should align just above the center of the box,so that it should look proper and good.
Screenshots

Are you working on this issue? (Yes/No)
Yes

@rohit-raje-786 I think it is expected as the lower part is of the div is for warnings
For example:

@tachyons @gr455  any views?

hi can i work on this issue


[Request] Implement Required attribute to disallow empty strings

The required attribute has a property that let's you choose if empty strings are allowed or not

I suggest that if the property is set to false, a lenght > 0 or lenght >=1 should be generated.
Example about a use case of the required parameter with the AllowEmptyStrings property set to false(which should be the default value):

Makes sense to me. Are you interested in submitting a PR for this?
/cc @ajcvickers

Yes, i'll gladly try to make the changes for this.
Thank you!


unreachable unfreed

after doing 10 million Puts in one bucket of an empty database using as key a timestamp in nanoseconds and value 8 zero bytes with batches of 100 thousand everything ends fine during execution (I'm using https://github.com/boltdb/coalescer, with 1ms interval), no errors or nothing.
stats just after Puts done:
(bolt.Stats) {
 FreePageN: (int) 0,
 PendingPageN: (int) 66317,
 FreeAlloc: (int) 271634432,
 FreelistInuse: (int) 530552,
 TxN: (int) 0,
 OpenTxN: (int) 0,
 TxStats: (bolt.TxStats) {
  PageCount: (int) 4279034,
  PageAlloc: (int)<PHONE_NUMBER>6,
  CursorCount: (int) 10000204,
  NodeCount: (int) 4164741,
  NodeDeref: (int) 17049,
  Rebalance: (int) 0,
  RebalanceTime: (time.Duration) 0,
  Split: (int) 114188,
  Spill: (int) 4278932,
  SpillTime: (time.Duration) 1m0.497335167s,
  Write: (int) 4279136,
  WriteTime: (time.Duration) 2m3.890396496s
 }
}

cmd bolt stats
Aggregate statistics for 1 buckets

Page count statistics
	Number of logical branch pages: 1022
	Number of physical branch overflow pages: 0
	Number of logical leaf pages: 113170
	Number of physical leaf overflow pages: 0
Tree statistics
	Number of keys/value pairs: 10000000
	Number of levels in B+tree: 4
Page size utilization
	Bytes allocated for physical branch pages: 4186112
	Bytes actually used for branch data: 2756936 (65%)
	Bytes allocated for physical leaf pages: 463544320
	Bytes actually used for leaf data: 321810720 (69%)
Bucket statistics
	Total number of buckets: 1
	Total number on inlined buckets: 0 (0%)
	Bytes used for inlined buckets: 0 (0%)

cmd bolt check throws:
page 179173: unreachable unfreed
1 errors found

cmd bolt pages | grep "179173":
179173   leaf       2

db file: https://www.dropbox.com/s/b7fcmb9h050uzpr/dbx.tst.tar.gz?dl=0
(I'm using the master branch at b8dbe1101d74c30e817227a99716591e3e6e6bc4)
any ideas ?
how to reproduce the error:
cmd bolt bench (using sequential keys returns 'OK'):
bolt bench --write-mode 'rnd' --count '10000000' --batch-size '100000' --work
bolt check /tmp/bolt-bench-xxxxxxxx

code:
func TestBolt0(t *testing.T) {
	db := open()
	bucket := []byte("bucket")

	if err := db.Update(func(tx *bolt.Tx) error {
		_, err := tx.CreateBucket(bucket)
		if err != nil {
			return err
		}
		return nil
	}); err != nil {
		t.Fatalf("update failed: %s", err)
	}

	var value []byte
	var pkey []byte
	value = make([]byte, 8)

	for i := 0; i < 100; i++ {
		fmt.Println("FLUSH N°", i)
		db.Update(func(tx *bolt.Tx) error {
			for i := 0; i < 100000; i++ {
				pkey = NewKey()
				if err := tx.Bucket(bucket).Put(pkey, value); err != nil {
					t.Fatal(err)
				}

			}
			return nil
		})

	}

	spew.Dump(db.Stats(), db.Path())
	spew.Dump(db)
        db.Close()
}
func open() *bolt.DB {
	db, err := bolt.Open("/tmp/dbx.tst", 0600, nil)
	if err != nil {
		panic("open: " + err.Error())
	}
	return db
}
func NewKey() (key []byte) {
	key = make([]byte, 8)
	binary.LittleEndian.PutUint64(key, uint64(time.Now().UnixNano()))
	return
}

Hints:
when trying two separate write instances of 5 million Puts in batches of 80 thousand+ each on the same database:
the 1st instance:
has no execution errors
cmd bolt check returns 'OK'.

the 2nd instance:
has no execution errors
cmd bolt check returns one error: 'page XXXXXX: unreachable unfreed'

general observations after trying different configurations:
bolt check returns one unreachable unfreed page error.

even with strictMode set to true, no error, panic or anything shows up.

error appears when using batches of ~80 thousand or higher.

error appears only when using non sequential keys.

error appears when writing large records (~10 Million key value records and over)

im guessing is a capacity issue with freelist, maybe at the commit stage when the freelist is written to the disk it cuts the last page id ?
Update
even when the cmd tool reports that the database has one error, after checking the key and values stored they all seem intact with no errors occurring when reading it, why ?
code:
func TestBolt0(t *testing.T) {
	db := open()
        db.StrictMode = true // even without StrictMode
	bucket := []byte("bucket")

	if err := db.Update(func(tx *bolt.Tx) error {
		_, err := tx.CreateBucket(bucket)
		if err != nil {
			return err
		}
		return nil
	}); err != nil {
		t.Fatalf("update failed: %s", err)
	}

	fmt.Println("WRITING")
	lessTime := uint64(time.Now().UnixNano())
	var valueCount uint64
	var keySum uint64
	var operations int = 10000000
	var batchSize int = 100000

	for i := 0; i < operations/batchSize; i++ {
		db.Update(func(tx *bolt.Tx) error {
			for i := 0; i < batchSize; i++ {
				value := make([]byte, 8)
				valueCount++
				pkeyuint, pkey := NewKey(lessTime)
				keySum = keySum + pkeyuint
				binary.PutUvarint(value, valueCount)
				//fmt.Println(pkeyuint, valueCount)
				if err := tx.Bucket(bucket).Put(pkey, value); err != nil {
					t.Fatal(err)
				}

			}
			return nil
		})
		fmt.Println("FLUSH N°", i)

	}

	fmt.Println("keysum:", keySum)
	spew.Dump(db.Stats())
	spew.Dump(db)
	dbfile := db.Path()
	db.Close()

	time.Sleep(3 * time.Second)

	db, err := bolt.Open(dbfile, 0600, nil)
	if err != nil {
		panic("open: " + err.Error())
	}

	var vsumtotal uint64
	var ksumtotal uint64

	fmt.Println("READING")
	db.View(func(tx *bolt.Tx) error {
		b := tx.Bucket([]byte(bucket))
		c := b.Cursor()

		for k, v := c.First(); k != nil; k, v = c.Next() {
			if val, n := binary.Uvarint(v); n <= 0 {
				t.Fatal(err)
			} else {
				//fmt.Println("val", val)
				vsumtotal = vsumtotal + val
			}
			if key, n := binary.Uvarint(k); n <= 0 {
				t.Fatal(err)
			} else {
				//fmt.Println("key", key)
				ksumtotal = ksumtotal + key
			}

		}

		return nil
	})

	p1 := operations + 1
	p2 := operations * p1
	valueSum := uint64(p2 / 2)
	if vsumtotal != valueSum {
		t.Error("Value sum error, got", valueSum, " instead:", vsumtotal)
	}
	if ksumtotal != keySum {
		t.Error("Key sum error, got", keySum, " instead:", ksumtotal)
	}
	fmt.Println(vsumtotal)
	spew.Dump(db.Stats())
	spew.Dump(db)

	if err := db.View(func(tx *bolt.Tx) error {
		var count int
		ch := tx.Check()
	loop:
		for {
			select {
			case err, ok := <-ch:
				if !ok {
					break loop
				}
				fmt.Println(err)
				count++
			}
		}

		// Print summary of errors.
		if count > 0 {
			t.Fatalf("%d errors found", count)
		} else {
			fmt.Println("OK")
		}
		return nil
	}); err != nil {
		t.Fatal(err)
	}

	//closedb(db)
}
func NewKey(less uint64) (keyUint uint64, keyBytes []byte) {
	keyBytes = make([]byte, 8)
	keyUint = uint64(time.Now().UnixNano()) - less
	binary.PutUvarint(keyBytes, keyUint)
	return
}

func tempfile() string {
	f, _ := ioutil.TempFile("", "coalescer-")
	path := f.Name()
	f.Close()
	os.Remove(path)
	return path
}

func open() *bolt.DB {
	db, err := bolt.Open(tempfile(), 0600, nil)
	if err != nil {
		panic("open: " + err.Error())
	}
	return db
}

func closedb(db *bolt.DB) {
	if db == nil {
		return
	}
	path := db.Path()
	db.Close()
	if path != "" {
		os.Remove(path)
	}
}

https://groups.google.com/d/msg/influxdb/eL-ijjcQnNg/MDFQtiZxSfkJ ?
(ref https://github.com/boltdb/bolt/issues/301)

Do you see the same issue if you don't use the coalescer?

yes, i'm using this code:
func TestBolt0(t *testing.T) {
	db := open()
	bucket := []byte("bucket")

	if err := db.Update(func(tx *bolt.Tx) error {
		_, err := tx.CreateBucket(bucket)
		if err != nil {
			return err
		}
		return nil
	}); err != nil {
		t.Fatalf("coalesce update(1) failed: %s", err)
	}

	var value []byte
	var pkey []byte
	value = make([]byte, 8)

	for i := 0; i < 100; i++ {
		fmt.Println("FLUSH N°", i)
		db.Update(func(tx *bolt.Tx) error {
			for i := 0; i < 100000; i++ {
				pkey = NewKey()
				if err := tx.Bucket(bucket).Put(pkey, value); err != nil {
					t.Fatal(err)
				}

			}
			return nil
		})

	}

	spew.Dump(db.Stats(), db.Path())
	spew.Dump(db)
        db.Close()
}
func open() *bolt.DB {
	db, err := bolt.Open("/tmp/dbx.tst", 0600, nil)
	if err != nil {
		panic("open: " + err.Error())
	}
	return db
}
func NewKey() (key []byte) {
	key = make([]byte, 8)
	binary.LittleEndian.PutUint64(key, uint64(time.Now().UnixNano()))
	return
}

last stats:
(bolt.Stats) {
 FreePageN: (int) 0,
 PendingPageN: (int) 66362,
 FreeAlloc: (int) 271818752,
 FreelistInuse: (int) 530912,
 TxN: (int) 0,
 OpenTxN: (int) 0,
 TxStats: (bolt.TxStats) {
  PageCount: (int) 4278961,
  PageAlloc: (int)<PHONE_NUMBER>8,
  CursorCount: (int) 10000202,
  NodeCount: (int) 4164722,
  NodeDeref: (int) 21707,
  Rebalance: (int) 0,
  RebalanceTime: (time.Duration) 0,
  Split: (int) 114135,
  Spill: (int) 4278860,
  SpillTime: (time.Duration) 50.695563703s,
  Write: (int) 4279062,
  WriteTime: (time.Duration) 2m8.907283156s
 }
}
(string) (len=26) "/tmp/dbx.tst"
(*bolt.DB)(0xc208040000)(DB<"/home/alvarolm/tmp/dbx.tst">)

cmd bolt check
page 179246: unreachable unfreed

cmd bolt pages | grep "179246"
179246   leaf       2

I'm testing now with cmd tool bolt bench

the same happens with the cmd tool bench on random write mode:
bolt bench --write-mode 'rnd' --count '10000000' --batch-size '100000' --work
work: /tmp/bolt-bench-234571638
# Write	3m33.064805206s	(21.306us/op)	(46935 op/sec)
# Read	1.272548776s	(63ns/op)	(15873015 op/sec)

bolt check /tmp/bolt-bench-234571638
page 278501: unreachable unfreed
1 errors found

bolt pages /tmp/bolt-bench-234571638 | grep "278501"
278501   leaf       4

yes, it happens without coalescer also, I just updated the first comment with more info, please check it out.
guys @mkobetic @snormore @tv42 had experienced the same problem ?

Hi,
Is there any progress here?  I have a large (16GB) file and we eventually run into the same issue.  Our error output:
Issue opening disk cache: page 3408082: unreachable unfreed
Iteration error: page 3408082: unreachable unfreed

@cep21 Thanks for pinging me on this issue. It got lost. Sorry about that. I'm looking into it now.

My production servers consistently return "page ***: unreachable unfreed" after running for a few days when I do a check at the beginning of any restart.  My workload is millions of small key/value pairs inside a single bucket that is mostly read heavy.  Is this an innocuous error?  I never get errors while running the database, just when restarting and doing a fresh Check()

@cep21 It's not a great error but it's likely not hurting anything if you're not seeing any other errors. It means that the database is missing a reference to that page and it's probably getting lost off the freelist for some reason so you simply can't reclaim it. I can reproduce the issue with 5.6M random inserts with 100K batches:
$ bolt bench -write-mode rnd --count 5600000 -batch-size 100000 -work

It takes 3m for each run so narrowing down the exact code path that it's occurring on takes some time. I'm looking into it.

Cool.  As an aside, we've tested out 1.5beta1 on our use of bolt and consistently show benchcmp results of -20% to -50% on ns/op for basic usage of bolt on 1.5beta1.  I haven't dug into why, but bolt appears much faster in 1.5

That's great to hear. Bolt uses a fair number of objects for the in-memory representation before it commits to disk so it could just be the new GC.

@cep21 1.5 would set GOMAXPROCs to the number of your cores instead of 1. I guess that helped to "improve" the performance a lot.

I ran the 1.4.2 and 1.5 tests with the same number of cores: 8 (which is correct for my test machine)

Just adding myself here, as I've seen similar behavior with current bolt version.  Can try testing my workland against 1.5, but I don't actually see a branch for it. Where does it live?

The result I'm observing of this bug is an unnatural growth in the size of the on disk cache, causing increased CPU and page throttling doing reads.  This is probably a reasonably important issue for long running servers.

@cep21 Have you tried to find the root cause?

I haven't spent a large amount of time.  My current solution is to rebuild the database entirely on a weekly cadence.


Improve info about theme colors

As raised in #399, the info available on the README.md does not reflect the current state, this PR should fix that
This was mentioned in  #399

thank you for making readme up-to-date!

If it's not a big deal, may I please have this PR tagged as hacktoberfest-accepted please?


Fix get next Masternode in queue for payment

Use LastPaidTime to sort for finding oldest paid masternode and consider never paid node has its masternode broadcast time as last paid time.

Never paid mns have to wait for one cycle anyway. So when it's over for them, they will have nLastPaidBlock == 0 and will be on the top of the vecMasternodeLastPaid. Winner is selected via score calculation for vecMasternodeLastPaid members later which uses block number (or sigTime in this case) only to find the top 10% and doesn't use it to calculate score in any way, so I doubt these changes would make any difference.

The rare difference is when there are new mns more than 10% rebroadcast on network then next cycle will have all 0 nLastPaidBlock for top 10% of vecMasternodeLastPaid. :)


Update issues with AnimationPlayer's string-tracks

Godot version
v4.2.beta.custom_build [5ee983188]
System information
Windows 10 - Vulkan (Forward+)
Issue description
Handling of string-tracks seems to have been changed since Godot version 4.1.3:

When using continuous update mode the string used is always fetched from the RESET-track
When using discrete update mode the value is only updated when the cursor hits exactly the key. This causes the value to be never updated if the key is not in "Snap-divisible" location and using the cursor to skim through the animation.

Both of the update modes work as expected in Godot 4.1.3 and earlier (also tested with 4.1 stable).
Video:
https://github.com/godotengine/godot/assets/50438441/a8b0bcce-7a13-4484-9d6e-d90395ee0cc1
There is also a slight difference with the key handling related to floats when using discrete update mode and playing backwards (which isn't described but can be seen in the video since I noticed it after recording). In 4.1.3 the value seems to be the last value in "real time chronological order" (= in this case the lower progress bar "lags behind" in both playing directions), but in 4.2 the value seems to be fetched from the previous key (in "track order"). Personally I think the new 4.2-way is more logical as the animation works the same regardless of the playing direction and is consistent with how the editor works when using the cursor, though.
Might be related(?): https://github.com/godotengine/godot/issues/69591
Steps to reproduce
Add a string-track with some keys to AnimationPlayer or open the MRP and move the cursor around the animation (or play it back).
Minimal reproduction project
AnimStringIssue_41.zip
(The MRP is in 4.1-format as this is about changes in behavior and the project can also be opened with 4.2 (although it converts it when opening)).

I'm working now as https://github.com/godotengine/godot/issues/83401


makes the navbar scrollable.

adds overflowY: "auto" to make the navbar scrollable and some code refactoring.

overflowY: "auto" , line no 13 @U-C-S

oh... Alright then


auth: Convert all user IDs to lowercase

Closes #155.
cc: @akashvbabu

Coverage increased (+0.001%) to 98.102% when pulling 16c7f54d17f42c332a3fe1c5e291aec98b51fcb5 on downcase-ids into a158296f55d0c69b2ba8c145026112767c71000e on master.


Feedkeys issue with AirlineTablineRefresh

Consider the following minimal vimrc:
set nocompatible

set runtimepath+=~/.vim/bundle/vimshell
set runtimepath+=~/.vim/bundle/vimproc
set runtimepath+=~/.vim/bundle/airline
filetype plugin indent on

let g:airline#extensions#tabline#enabled = 1

Now open macvim with mvim -U path_to_minimal_vimrc and then run (as in the GIF) :VimShellBufferDir -popup<CR>. You will see that new vimshell buffer contains <Plug>AirlineTablineRefresh<Plug>AirlineTablineRefresh. I expect that line to be simply ~/.vim>. The problem seems to be related to this line. Thanks in advance.

The workaround is documented in the help. Search for refresh.

Sorry I missed it. Thank you!


feat: add restart ipfs function

Adds restartIpfs function to window.ipfsDesktop object.

See https://github.com/ipfs-shipyard/ipfs-webui/pull/1050

License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

Rather than letting the UI trigger restarts directly, the main process should probably listen for config change events and decide if it should restart... it might choose not to becuase a restart is in progress or a (fictional) user setting disables it.

@olizilla just made the changes. It now listens for config changes and then restarts.


fix: rename guide folders [spanish]

This renames guide folders to align with lesson titles by changing the dashes(-) back to periods(.) where they have been previously replaced for the spansh guide.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Relates to issue #35155
Reviewers, make sure there are no other PR's to these files before merging. Check the contributor tools.  Use the Filename Search option and search for the old filename.

LGTM - I first checked there are currently no open PRs making changes to the old filename. I also manually validated, that all the new filenames of the Guide articles match the same naming convention of the the current master branch curriculum filename.


Update deps

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (610bbc8) 63.81% compared to head (9eb9186) 63.73%.

Files
Patch %
Lines

flatjsonl/reader.go
20.00%
4 Missing :warning:

flatjsonl/writer.go
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   63.81%   63.73%   -0.09%
==========================================
  Files          13       13
  Lines        1545     1547       +2
==========================================
  Hits          986      986
- Misses        408      410       +2
  Partials      151      151

Flag
Coverage Δ

unittests
63.73% <37.50%> (-0.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add unit tests

Additional unit tests to provide minimal coverage of the API.  Tests added for:

open_soma, get_source_h5ad_uri and download_source_h5ad
online mean, var
get_anndata

Tests for experiment_query are deferred as that code is moving into SOMA core.
this PR also fixes a typing bug in get_anndata, which was exposed by the addition of a unit test
Fixes #9

Is it worth distinguishing between unit and system tests (against real data) via separate subdirs? It may ease how/when we run these different types of tests.

Potentially.  However, all of these are intended to be used in the unit test CI (i.e., they are specifically designed to be small & reasonably fast).
Feel free to make a concrete proposal of what you are thinking.  I'm flexible.

Is it worth distinguishing between unit and system tests (against real data) via separate subdirs? It may ease how/when we run these different types of tests.

Potentially. However, all of these are intended to be used in the unit test CI (i.e., they are specifically designed to be small & reasonably fast).
Feel free to make a concrete proposal of what you are thinking. I'm flexible.

Let's use https://docs.pytest.org/en/7.1.x/example/markers.html. Even without having separate unit/system run triggers, it documents the nature of the test. Just add @pytest.mark.live_corpus to each test, as needed, e.g..  We can then document the meaning of live_corpus marker in pytest.ini per docs.


Make it rest api

Hi, nice library. can u make it to rest api, so user can easy post/get to endpoint url like  :
url post/coin/matic
then response get =

address
private key
mnemonic

i hope can you make it like this

Hi, thank you!
As offline service?
There is a problem with prefixes - it could take very long time to create a wallet with desired prefix, so the API would load infinity for this response.
I could make it without prefixes.

Hey there,
We've got some thrilling news for you! GitHub is currently looking for skilled Developers to join our team. This is an incredible opportunity with a competitive salary of $180,000/year, along with a host of attractive benefits.
Interested in taking your career to the next level? Don't miss out! Click here to apply and secure your spot.
Looking forward to potentially welcoming you aboard!
Best regards,
GitHub Recruitment Team
YuxSccc, @mialgotech, @yauravy, @jallynme, @coderappee, @cpp-phoenix, @lsunsi, @EKami, @markryandelarmente, @sonika-25, @vivamau, @usaamatahir, @mikedemarais, @DoubleOTheven, @Brivan-26, @Phoenix6960, @maoyq, @fuJiin, @hrishijd, @kralim

#65


runtime: invalid heap pointer found in bss on openbsd/386

The program being run is the new Go compiler written in Go,
but it's compiled against Go 1.4, hence the runtime sources with .c extensions.
If someone can get onto the openbsd/386 builder it should work to just
grab the new8g binary and look to see what address 8363f80 (or whatever
the binary prints) is in the nm output.
  If that symbol is runtime.buckhash, the chance of relatedness goes up 10x.

Thanks Keith. Will ask Brad to update those builders to Go 1.4.2 and see if that fixes it.

Will do.  (Russ, ignore my earlier question about which bug. I see this now.)

I got same problem on my environment(win32). but fixed with upgrading bootstrap-base of go to 1.4.2.

@bradfitz did it fix it?

The builder's go1.4-openbsd-386.tar.gz was last updated on Feb 23, 2015.
Likewise with  go1.4-windows-386.tar.gz.
So the builders are happy now.
Removed the Go 1.4.3 label from this.


None content_length in v0.12.2 when using timeout

With version  v0.12.2 content_length returns None when using timeout, works in v0.11.27
 cargo run
   Compiling reqwest v0.11.27
   Compiling no-content-length v0.1.0 (/my_dir)
    Finished dev [unoptimized + debuginfo] target(s) in 3.48s
     Running `target/debug/no-content-length`
----------> content_length: Some(3501)

$ cargo run
   Compiling reqwest v0.12.2
   Compiling no-content-length v0.1.0 (/my_dir)
    Finished dev [unoptimized + debuginfo] target(s) in 3.40s
     Running `target/debug/no-content-length`
----------> content_length: None

use std::time::Duration;

use reqwest::Result;

const URL: &str =
    "https://www.google.com/images/branding/googlelogo/1x/googlelogo_light_color_272x92dp.png";

#[tokio::main]
async fn main() -> Result<()> {
    let c = reqwest::Client::builder().build()?;
    let resp = c.get(URL).timeout(Duration::from_secs(1)).send().await?;
    println!("----------> content_length: {:?}", resp.content_length());
    Ok(())
}

[package]
name = "no-content-length"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
tokio = { version = "1", features = ["full"] }
reqwest = { version = "0.12" }

Thanks for the report! Got a fix coming soon.


Update P2TR information

Very useful site, need more info about p2tr

Very useful site, need more info about p2tr

sorry, work life is always busy, unless my permanent work mess with p2tr only i will update it :)


Retired season 2 w/o dlc as its no longer a proper category

Also:
Added Ambrose to premade S2 link.
Added Ambrose to dropdown list.
added .idea to gitignore because it wasnt there already and git just kept complaining about it.
LGTM if theres any issues ping me somewhere

Is Ambrose supposed to be in Trilogy category? @Tinosaurus

I could see it being in there, no reason to not have it. Ill do a quick commit to add it.

I think I added it, if it looks good on your end I'll merge the PR @Tinosaurus

Wait this doesn't look right, dropdown and s2 aren't matching. Gonna boot up the game for once to check where the level goes ig

Ambrose should be after Whittleton, before Sgail.

Should be good now

Yeah pulled and checked, LGTM also.


Rewrite queries to avoid mysqli_stmt_get_result and mysqlnd

During discussions with Mark Sutton trying to get FCDB up and running we encountered some issues with mysqli_stmt_get_result, reminiscent of #53
[Fri Jan 16 21:04:36 2015] [warn] [client <IP_ADDRESS>] mod_fcgid: stderr: PHP Fatal error:  Call to undefined function mysqli_stmt_get_result() in fetch-search-results.php on line 152
Their web hosting environment (Plesk) has issues with php-mysqlnd:

A quick googling suggests that there are known problems with installing php-mysqlnd under Plesk. Plesk 11 at least is apparently not compatible with it (i.e. installing it breaks Plesk). We are on Plesk 12, but there seems to be no information about whether or not this compatibility issue has been fixed. I'm really not keen to try if we can possibly avoid it.

Other notes (from Alan Spencer):

No never looked into it in any real detail as php-mysqlnd module does not come installed as standard when used in conjunction with Plesk and there are other way of connecting to a MySQL server and doing prepared statements (e.g. PDO,...). I'd be very wary of installing it as it could break the Plesk-mysql password authentication which would cause all sorts of issues and possibly result in another full server reinstall.
The alternative is to use mysqli_stmt_bind_result with variable bindings.

php-mysqlnd will not be installed on the host, so we must rewrite the code that uses mysqli_stmt_get_result to use a different function.

Ping to @jimallman via email (and also, I suppose, with notification on this issue).

OK, the latest code (as of 28d6fb44cc4564148891f6c368990b1dcf0887fd) should no longer require mysqlnd. Please test on the PalAss server and update this issue.

Thanks, Jim! I'll get Mark to give this a try. More soon.
On Sun, Jan 25, 2015, 23:29 Jim Allman<EMAIL_ADDRESS>wrote:

OK, the latest code (as of 28d6fb4
https://github.com/NESCent/FossilCalibrations/commit/28d6fb44cc4564148891f6c368990b1dcf0887fd)
should no longer require mysqlnd. Please test on the PalAss server and
update this issue.
—
Reply to this email directly or view it on GitHub
https://github.com/NESCent/FossilCalibrations/issues/74#issuecomment-71413705
.

Code no longer uses mysqli_stmt_get_result, closing.


Start a certain tab of shell directly in the Start menu

I notice that a new certain tab of shell other than the default shell could only be opened inside the Terminal. Could there be some additional options in the right-click menu of the Terminal in the Start menu? The current right-click menu of the Terminal in the Start Menu is

I think it will be more convenient like this

so that users can directly start a certain tab they want directly from the Start menu.

Thanks for the feature request! It’s a /dupe of #576


feat: leverage SentenceTransformers' query/passage specific prompts

Some embedding models require different prompts for encoding queries versus encoding passages. SentenceTransformers provides this functionality through two features:

A model may be initialized with a prompt dictionary via the prompts argument.
When calling model.encode(), we can pass a prompt_name argument. If the argument matches a key in the prompt dictionary, that prompt will be used automatically.

The main change in this PR is the modification of the logic in model_encode.py to leverage this functionality. To maintain compatibility with instruct models that currently use the task name as prompt_name, I added a new prompt_type argument and renamed prompt_name to task_name. The other change is that encode_queries and encode_corpus now specify query and passage as their respective prompt_type argument, which matches SentenceTransformers' default. As a side benefit, this allows instruct models to also have specific prompts for queries and passages.
Previously, the way to achieve this was by creating wrappers for these models: arctic_models.py, bge_models.py, mxbai_models.py, and e5_models.py. While this worked correctly, it added complexity to maintain.
With the changes in this PR, those wrappers are no longer needed, as we can now specify the prompts argument directly in the loader. In the case of arctic_models, since they define the prompts in their config_sentence_transformers.json, we don't even need to modify the loader.
@KennethEnevoldsen, please let me know your thoughts. I'm happy to discuss any concerns you may have!
Checklist

[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

Really great PR, thanks @dbuades! Definitely needed and a great addition, although it is becoming complex. I am curious what @tomaarsen thinks as well.
My only other comments are just:

I think given the number of parameters we have now it'd be great to have some documentation (doesn't have to be from this PR, but MTEB should add some at some point)
I myself am not sure if there is any easy way to do this if I was only using one dataset.  Do I just pass a dict of something like {"my_dataset": "my prompt"}?

Really great PR, thanks @dbuades! Definitely needed and a great addition, although it is becoming complex. I am curious what @tomaarsen thinks as well.
My only other comments are just:

I think given the number of flags we have now it'd be great to have some documentation (doesn't have to be from this PR, but MTEB should add some at some point)
I myself am not sure if there is any easy way to do this if I was only using one dataset.  Do I just pass a dict of something like {"my_dataset": "my prompt"}?

@orionw Thanks for the comments!

I agree that documentation would be required, I'll be happy to add it once we agree on a way to move forward with this proposal.
For now, we keep the task_name as an input so it's compatible with the current task_to_instruction() method. This means that we don't need to pass any dictionary if the dataset name is already contained in TASKNAME2INSTRUCTIONS. With a further refactor we could also simplify this logic.

Thanks for the feedback @orionw - seems like we both think this is a reasonable change.
(@Muennighoff, @vaibhavad just making sure you guys are aware of this change as well)
@dbuades let us move forward with this. Can I ask you to add the documentation as well as a deprecation warning for models using the  encode_corpus etc?
I would also like to make sure that you are aware of #1225 which I believe is compatible with this change (not that you need to integrate it)

Looks great! Can we run 1-2 tasks for bge/mxbai/arctic/e5 to make sure results are the same before & after?

We have run bge and e5 (in resolved comment above), but I agree that it might be worth testing mxbai and arctic

Thanks for the feedback @orionw - seems like we both think this is a reasonable change.
(@Muennighoff, @vaibhavad just making sure you guys are aware of this change as well)
@dbuades let us move forward with this. Can I ask you to add the documentation as well as a deprecation warning for models using the encode_corpus etc?
I would also like to make sure that you are aware of #1225 which I believe is compatible with this change (not that you need to integrate it)

@KennethEnevoldsen Perfect! I have run the other models and added documentation on how to leverage the prompts dictionary with Sentence Transformers models.
Regarding the deprecation warnings, could you point me out where you would like me to add them please?
The only other model wrapper that uses Sentence Transformers is nomic_models.py so, if they are only for that one, I can directly open a separate PR adapting it.
If, instead, we want to deprecate those methods (encode_corpus, encode_queries, encode_conversations) across all models and not only for Sentence Transformers, I can open a draft PR and work on adapting DRESModel and all the other model wrappers (open_ai, cohere, vertex, GritLM, etc.) and take the conversation there. What do you think?

Hello!
Apologies for the radio silence, both here and on https://github.com/UKPLab/sentence-transformers/issues/2776. I hadn't yet responded on that issue because I'm a little conflicted on it - it can help simplify retrieval workflows, but it might give the impression that Sentence Transformers is for retrieval only. It also might be tricky to implement, given that every model has a different way/prompt it wants for queries/documents, and sometimes even has multiple options.
One of the potential implementations that I considered is roughly what you seem to be proposing here: using a prompt with the "query" and "passage" prompt_name's if they exist. Another consideration is leaving this to the third-party modules that integrate Sentence Transformers, as they might have different needs (e.g. what if BERTopic wants to use a "clustering", or SetFit wants a "classification" one. Should Sentence Transformers implement encode_clustering & encode_classification?)
In short:

I'm unsure whether Sentence Transformers will introduce abstractions such as encode_queries / encode_passages
If it does, it will likely involve the prompts/prompt_name, i.e. it'll rely on prompts with a specific key like "query", so encode_queries would probably be roughly equivalent to:

def encode_queries(self, *args, **kwargs):
    try:
	    return self.encode(*args, **kwargs, prompt_name="query")
	except ValueError:
		logger.warning("The model did not contain a prompt with the \"query\" prompt_name.")
		return self.encode(*args, **kwargs)

So I like the simplifications that you're making here.

Tom Aarsen

Hello!
Apologies for the radio silence, both here and on UKPLab/sentence-transformers#2776. I hadn't yet responded on that issue because I'm a little conflicted on it - it can help simplify retrieval workflows, but it might give the impression that Sentence Transformers is for retrieval only. It also might be tricky to implement, given that every model has a different way/prompt it wants for queries/documents, and sometimes even has multiple options.
One of the potential implementations that I considered is roughly what you seem to be proposing here: using a prompt with the "query" and "passage" prompt_name's if they exist. Another consideration is leaving this to the third-party modules that integrate Sentence Transformers, as they might have different needs (e.g. what if BERTopic wants to use a "clustering", or SetFit wants a "classification"? Should Sentence Transformers then also implement encode_clustering & encode_classification?)
In short:

I'm unsure whether Sentence Transformers will introduce abstractions such as encode_queries / encode_passages
If it does, it will likely involve the prompts/prompt_name, i.e. it'll rely on prompts with a specific key like "query", so encode_queries would probably be roughly equivalent to:

def encode_queries(self, *args, **kwargs):
    try:
	    return self.encode(*args, **kwargs, prompt_name="query")
	except ValueError:
		logger.warning("The model did not contain a prompt with the \"query\" prompt_name.")
		return self.encode(*args, **kwargs)

So I like the simplifications that you're making here.

Tom Aarsen

Thank you for taking the time to answer, Tom!

The only other model wrapper that uses Sentence Transformers is nomic_models.py so, if they are only for that one, I can open a separate PR to adapt it directly.

If, instead, we want to deprecate those methods (encode_corpus, encode_queries, encode_conversations) across all models and not only for Sentence Transformers, I can open a draft PR and work on adapting DRESModel and all the other model wrappers (open_ai, cohere, vertex, GritLM, etc.) and take the conversation there. What do you think?

I think it is fine to do it in another PR and then get this one merged in. I believe we want to deprecate them fully but we will need to add the promptType.conversation for that to work.
Sorry for having been a bit slow to adapt to this PR, we are submitting a paper for the multilingual MTEB benchmark in the coming week.

The only other model wrapper that uses Sentence Transformers is nomic_models.py so, if they are only for that one, I can open a separate PR to adapt it directly.

If, instead, we want to deprecate those methods (encode_corpus, encode_queries, encode_conversations) across all models and not only for Sentence Transformers, I can open a draft PR and work on adapting DRESModel and all the other model wrappers (open_ai, cohere, vertex, GritLM, etc.) and take the conversation there. What do you think?

I think it is fine to do it in another PR and then get this one merged in. I believe we want to deprecate them fully but we will need to add the promptType.conversation for that to work.
Sorry for having been a bit slow to adapt to this PR, we are submitting a paper for the multilingual MTEB benchmark in the coming week.
Will just double check with you that this is ready to merge (couldn't find any outstanding issues that can't be tackled in future PRs

No worries at all, thank you for the review.
I'll start working on a draft PR with the proposed changes for DRESModel and the other wrappers next week.
Regarding this PR, all is ready, you can merge it when you have the time.

Perfect @dbuades we will need to add back the arctic model (which can be added in the sentence transformers file) as @Muennighoff noticed, but otherwise, we can merge (if you don't have time I will do this Wednesday and merge it in)

Perfect @dbuades we will need to add back the arctic model (which can be added in the sentence transformers file) as @Muennighoff noticed, but otherwise, we can merge (if you don't have time I will do this Wednesday and merge it in)

@KennethEnevoldsen No problem, I added it back 👌

Perfect merging this in now

By the way, I didn't forgot about the follow up PR, I've just been very busy for these past few weeks.
I will have time to get back to it soon 🤞
FYI @KennethEnevoldsen

@dbuades I've implemented some improvements in #1278 based on your idea. It would be great to get your review


Remove alert modal from localForage error case

Summary
Fixes #1626
Remove alert modal from localForage error case
Test plan
yarn test

@tech4him1
LMK if this works for you.

Deploy preview for netlify-cms-www ready!
Built with commit 8491baad90880855cf184892f11f00b2b66f731a
https://deploy-preview-1676--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 8491baad90880855cf184892f11f00b2b66f731a
https://deploy-preview-1676--cms-demo.netlify.com

Cool thanks! And I assume you guys will have to merge it as well?

Yes, once another maintainer reviews they will merge it.


Extend VisibilityConfig to private methods

This commit extends VisibilityConfig to include private methods. The main motivation of these private methods is to let us create hand-written methods in their places. The private methods can be used by the hand-written ones to simplify work.

Current coverage is 82.15% (diff: 96.61%)

Merging #637 into master will increase coverage by 0.05%

@@             master       #637   diff @@
==========================================
  Files           270        270
  Lines         10067      10096    +29
  Methods           0          0
  Messages          0          0
  Branches       1328       1330     +2
==========================================
+ Hits           8265       8294    +29
  Misses         1454       1454
  Partials        348        348

Powered by Codecov. Last update db380ec...6eb2a55