Improve the word wrapping of the stack-view

When the content of the stack-view appears to be too long in some of the
browsers it doesn't fit in the container and scrollers appear.
This will:

Allow the browser to brake unbreakable words, so the content fits in the container
Avoid appearance of the scrollers around the stack-view

Fixes #1304
Before:

After:

@matonev: Thanks for the contribution. Your name has been added to our community page: https://vmware.github.io/clarity/community


support autocompletion/hinting

Like the title says. I don't know how that is done best for extensions, but I've seen it done via published openapi definitions.

i'm not sure either but i always thought we'd need an LSP for it. like when the editor is trying to autocomplete a "shapes" value, i don't think it'd be able to know to pull from list of shape values for autocomplete with just openapi definitions.

Yeah, nested structures could not be mapped with openapi alone I guess. But I guess it is not rocket science to set it up. Probably tedious work.

yeup, i'll leave this open as it eventually will be vscode task, but we have one for LSP in d2: https://github.com/terrastruct/d2/issues/104

When I have time, I'll setup a branch that has the framework for an LSP on the client side.  The hard part is going to be the "error tolerant parser" on the server side :)
https://code.visualstudio.com/api/language-extensions/language-server-extension-guide

@alixander and @gavin-ts
I have branches in both D2 and D2-VSCODE called LanguageServer that have a working language server.  Please check them out.  Have the following working:

Errors shown without a preview being created
Import links can be opened, "foo: @bar" will underline "bar" and allow for a ctrl+click to open "bar.d2".
Rename works, so if you have multiple "x: ...", "x.style...", etc, you can rename "x" and and have it change everywhere.

Check it out.
I'll try to work on autocomplete for styles if I can figure out what to trigger it on.

So these would be the 2 PRs right? We can create these to review/work on
https://github.com/terrastruct/d2/compare/master...BarryNolte:d2:LanguageServer
https://github.com/terrastruct/d2-vscode/compare/master...BarryNolte:d2-vscode:LanguageServer


Selenium 3.0 beta version is not supporting implicit wait and Wait for Page load. Does anybody knows how to use implicit wait in selenium 3.0 beta which uses geckodriver. Following code is not working.

driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);

@anukriti-chawla What was the resolution for this? I am having the same issue.

@FFLSH: see #262

@dnschneid I don't get it

@FFLSH, This topic and the resolution is not relevant.
It should probably be researched elsewhere since this forum is for 'crouton' issues.


http://webgoatphp.com/ is down

Hi,
This is not an issue per se with your repo, I am wondering whats happening with the webgoat project now that it is down.
Thanks.

Hmm…
I hosted the website personally. Now that I’m no longer partaking in OWASP, we need volunteers to do that.
-A

On Aug 4, 2016, at 4:28 PM, nhajiyani<EMAIL_ADDRESS>wrote:
Hi,
This is not an issue per se with your repo, I am wondering whats happening with the webgoat project now that it is down.
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/shivamdixit/WebGoatPHP/issues/47, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVjW1Emln7zO_hb4onT-hKoQw6bnn9Tks5qcktXgaJpZM4JdFyt.

Hi @nhajiyani,
We will be bringing the website back up soon. You need to host the application locally till then.
Thanks!


[Feature]: repack NWB file

What would you like to see added to NeuroConv?
It would be nice to have a workflow that could take in an NWB file that has already been saved to disk and repack it with recommended chunking and compression.
The first step would be to fetch the current backend configuration from existing Datasets. Maybe this could be a function in _dataset_configuration.py:
get_existing_backend_configuration(nwbfile) -> BackendConfiguration
where the nwbfile must be linked to an on-disk NWB File. The backend should be automatically extracted, so no need to have that as a separate arg.
Then we should have a way to get the recommended configuration for that file. This works already in some cases with get_default_backend_configuration(nwbfile, backend), but does not work in all cases. If you have an ImageSeries with an external file and a (0,0,0) dataset, this triggers an error when the dataset in an h5py Dataset:
from pynwb.testing.mock.file import mock_NWBFile
from neuroconv.tools.nwb_helpers import get_default_backend_configuration
from pynwb.image import ImageSeries

nwbfile = mock_NWBFile()

im_series = ImageSeries(
    name="my_video",
    external_file=["my_video.mp4"],
    starting_frame=[0],
    format="external",
    rate=30.0
)
nwbfile.add_acquisition(im_series)

from pynwb import NWBHDF5IO

with NWBHDF5IO("this_test4.nwb", "w") as io:
    io.write(nwbfile)

io = NWBHDF5IO("this_test4.nwb", "r")
nwbfile = io.read()

get_default_backend_configuration(nwbfile, "hdf5")

---------------------------------------------------------------------------
ZeroDivisionError                         Traceback (most recent call last)
Cell In[22], line 1
----> 1 get_default_backend_configuration(nwbfile, "hdf5")

File ~/dev/neuroconv/src/neuroconv/tools/nwb_helpers/_backend_configuration.py:19, in get_default_backend_configuration(nwbfile, backend)
     16 """Fill a default backend configuration to serve as a starting point for further customization."""
     18 BackendConfigurationClass = BACKEND_CONFIGURATIONS[backend]
---> 19 return BackendConfigurationClass.from_nwbfile(nwbfile=nwbfile)

File ~/dev/neuroconv/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py:61, in BackendConfiguration.from_nwbfile(cls, nwbfile)
     58 @classmethod
     59 def from_nwbfile(cls, nwbfile: NWBFile) -> Self:
     60     default_dataset_configurations = get_default_dataset_io_configurations(nwbfile=nwbfile, backend=cls.backend)
---> 61     dataset_configurations = {
     62         default_dataset_configuration.location_in_file: default_dataset_configuration
     63         for default_dataset_configuration in default_dataset_configurations
     64     }
     66     return cls(dataset_configurations=dataset_configurations)

File ~/dev/neuroconv/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py:61, in <dictcomp>(.0)
     58 @classmethod
     59 def from_nwbfile(cls, nwbfile: NWBFile) -> Self:
     60     default_dataset_configurations = get_default_dataset_io_configurations(nwbfile=nwbfile, backend=cls.backend)
---> 61     dataset_configurations = {
     62         default_dataset_configuration.location_in_file: default_dataset_configuration
     63         for default_dataset_configuration in default_dataset_configurations
     64     }
     66     return cls(dataset_configurations=dataset_configurations)

File ~/dev/neuroconv/src/neuroconv/tools/nwb_helpers/_dataset_configuration.py:154, in get_default_dataset_io_configurations(nwbfile, backend)
    151 if isinstance(candidate_dataset, np.ndarray) and candidate_dataset.size == 0:
    152     continue
--> 154 dataset_io_configuration = DatasetIOConfigurationClass.from_neurodata_object(
    155     neurodata_object=neurodata_object, dataset_name=known_dataset_field
    156 )
    158 yield dataset_io_configuration

File ~/dev/neuroconv/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_dataset_io.py:272, in DatasetIOConfiguration.from_neurodata_object(cls, neurodata_object, dataset_name)
    270     compression_method = "gzip"
    271 elif dtype != np.dtype("object"):
--> 272     chunk_shape = SliceableDataChunkIterator.estimate_default_chunk_shape(
    273         chunk_mb=10.0, maxshape=full_shape, dtype=np.dtype(dtype)
    274     )
    275     buffer_shape = SliceableDataChunkIterator.estimate_default_buffer_shape(
    276         buffer_gb=0.5, chunk_shape=chunk_shape, maxshape=full_shape, dtype=np.dtype(dtype)
    277     )
    278     compression_method = "gzip"

File ~/dev/neuroconv/src/neuroconv/tools/hdmf.py:38, in GenericDataChunkIterator.estimate_default_chunk_shape(chunk_mb, maxshape, dtype)
     35 chunk_bytes = chunk_mb * 1e6
     37 min_maxshape = min(maxshape)
---> 38 v = tuple(math.floor(maxshape_axis / min_maxshape) for maxshape_axis in maxshape)
     39 prod_v = math.prod(v)
     40 while prod_v * itemsize > chunk_bytes and prod_v != 1:

File ~/dev/neuroconv/src/neuroconv/tools/hdmf.py:38, in <genexpr>(.0)
     35 chunk_bytes = chunk_mb * 1e6
     37 min_maxshape = min(maxshape)
---> 38 v = tuple(math.floor(maxshape_axis / min_maxshape) for maxshape_axis in maxshape)
     39 prod_v = math.prod(v)
     40 while prod_v * itemsize > chunk_bytes and prod_v != 1:

ZeroDivisionError: division by zero

We should either adjust this function so it works for this purpose, or create a different function for this specific purpose.
Then, finally, we would need a way to write this to a new file, probably using the export function in pynwb.
It would be nice to have two usage modes, one that completely automates everything, and one that would allow users to repack specific datasets with specific parameters.
This workflow should also allow the user to switch from one backend to another.
Is your feature request related to a problem?
It's somewhat common for other users to upload sub-optimal NWB files. This would also be a suitable workflow for when users create NWB Files in MatNWB and don't know how to configure the datasets properly there.
Do you have any interest in helping implement the feature?
No.
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] Have you ensured this bug was not already reported?

@bendichter, I can't get this error with get_default_backend_configuration  to replicate, so maybe it has been fixed in the time since you raised this issue?

yeah, maybe


Deployment option for restricting account creation

Describe the feature you'd like and what it will do
We should create a deployment option that will let certain instances of HydroServer require that new users be verified or created by an admin user before they can complete their account and post data to the instance. We may also want to consider hiding the "Create Account" button on the website for these instances and requiring new accounts to be created through the admin dashboard.
Why is this feature important?
We want to allow organizations to deploy their own instance of HydroServer if doing so would better meet their needs. Some HydroServer deployments may not be intended for public data upload. In these cases, it will be necessary to restrict who can create a user account and upload data to the HydroServer instance.
Is your feature request related to a problem? Please describe.
No response
Any additional comments?
No response

https://github.com/hydroserver2/hydroserver-webapp-back/pull/191


feat: adding interchain account address query to controller submodule

Description

Adding interchain account address query to controller submodule
Adding basic CLI client query

closes: #2192
needed for: #2039

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Can we backport this to minor releases? Would allow anyone launching pre v6 to start using this gRPC and avoid migrations later cc @crodriguezvega


Adds extraParams to openUrl to allow rich object passing

Through routing when a controller opens an url.

Hi @clayallsopp, I've written tests for @NorthStar's changes. Would you like me to submit a new pull request?

Thanks! Sorry that schooling got in my way.

Hi all, any update on this?

I pushed the tests to my fork of Routable. I also updated the tests from SenTest to XCTest and fixed a bug which meant that the rich object params weren't working properly when a different object was sent to the same URL.
In the process I discovered this issue which I'm currently trying to work out a fix for. I'm hesitant to make a pull request while there are still failing tests.

@sweetverbs @NorthStar thanks for digging into these problems - I'm totally happy to look at any PR/one of your fork


FEATURE: Close 'Application is locked' dialog using code command

Is your feature request related to a problem? Please describe.
Following [/issues/11], I think we need a command to close the 'Application is locked' dialog.
The reason the dialog is closing in the Cantilever example, is because the console application is exited (the command prompt itself doesn't need to be closed).
When you create a Form or a library for another application, the 'script' isn't closed, resulting in the dialog remaining opened. If you then close the Form or alternatively an application containing the library, the dialog disappears.
If no action is taken, the dialog remains opened exactly 90 seconds after the script is run. This is not influenced by any of the BasicHttpBinding setting possibilities.
Describe the solution you'd like
A method in RfemSoapWsCoreClient that closes the dialog, so you don't have to wait 90 seconds for the dialog to timeout.
Describe alternatives you've considered
Saving, closing and reopening the RFEM model but it seams a bad (slow) workaround.
Additional context

We have created mechanism which close connection directly.


Fix replication for 5.6 as well

Start master properly, initializing correct configuration files.
Fix replication template as well to point to new image namespace.
OpenShift extended tests for mysql replication should work after this is picked-up.
@bparees @mfojtik @hhorak @soltysh @pmorie @smarterclayton
Big kudos to @hhorak who found the main bug.

:+1:

failed [test]

Looks fine, LGTM.

looks to me like the 5.6 rhel version keeps failing here:
2015-11-06 13:47:42 65 [Note] /opt/rh/rh-mysql56/root/usr/libexec/mysqld: ready for connections.
Version: '5.6.26-log'  socket: '/tmp/mysql.sock'  port: 0  MySQL Community Server (GPL)
/usr/share/container-scripts/mysql/common.sh: line 99:    65 Killed                  ${MYSQL_PREFIX}/libexec/mysqld --defaults-file=$MYSQL_DEFAULTS_FILE --skip-networking --socket=/tmp/mysql.sock "$@"
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/tmp/mysql.sock' (111)

Weird, it works fine on my machine (if that is the rhel7 image with the same test 5.6/test/run).

yeah not failing for me either... seeing other weirdness in the push job right now too.  will revisit this after getting that sorted out...wonder if dockerhub is having issues.

Tests passed, merging.


docs: Add a copyright notice to the example

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #52

PR #53

PR #54   👈

PR #55

PR #56

This stack of pull requests is managed by Graphite.

Merge activity

Jan 11, 7:34 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.


Sidebar brokes ScrollToTop functional

Sidebar using overflow: hidden; on root component and overflow-y: scroll; on content component.
ScrollToTop not working with this properties.
I can change these parameters to initial !important but open sidebar stay scrollable at this case.
Open sidebar not contain any additional class, isn't it?

This is just another symptom of the same underlying problem that is described in #77.

Solved by using BodyClassName and {!!this.props.main.sidebarOpen && <BodyClassName className="sidebar-opened" />}

Hi @indapublic, can you elaborate on this?  I'm not sure what BodyClassName is referring to


Build has rusted

The build process for CircuitPython has been updated. Need to upgrade the build to the newest process  detailed in Creating and Sharing CircuitPython Library documented on Adafruit's Learning website.
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/creating-a-library

The build process has been updated and a new build published.


Python 3.6 Compatibility

I recently upgraded my system to python 3.6.2 and it seems that that version may not be compatible with gmusicapi and more specifically with the pycrytodomex module due a syntax which appears to be no longer supported. I have setup a virtualenv in which I experienced the same error.
$ python --version
Python 3.6.2

$ pip freeze
appdirs==1.4.3
beautifulsoup4==4.6.0
certifi==2<IP_ADDRESS>
chardet==3.0.4
decorator==4.1.2
docopt-unicode==0.6.1
future==0.16.0
gmusicapi==10.1.2
gmusicapi-scripts==0.5.0
gmusicapi-wrapper==0.5.2
gpsoauth==0.4.1
httplib2==0.10.3
idna==2.6
MechanicalSoup==0.8.0
mock==2.0.0
mutagen==1.38
oauth2client==4.1.2
pbr==3.1.1
proboscis==<IP_ADDRESS>
protobuf==3.4.0
pyasn1==0.3.7
pyasn1-modules==0.1.5
pycryptodomex==3.4.7
python-dateutil==2.6.1
requests==2.18.4
rsa==3.4.2
six==1.11.0
urllib3==1.22
validictory==1.1.1
wrapt==1.10.11

$ ./gmsync
Traceback (most recent call last):
  File "./gmsync", line 7, in <module>
    from gmusicapi_scripts.gmsync import main
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi_scripts/gmsync.py", line 63, in <module>
    from gmusicapi_wrapper import MusicManagerWrapper
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi_wrapper/__init__.py", line 13, in <module>
    from .mobileclient import MobileClientWrapper
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi_wrapper/mobileclient.py", line 11, in <module>
    from gmusicapi.clients import Mobileclient
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi/__init__.py", line 4, in <module>
    from gmusicapi.clients import Webclient, Musicmanager, Mobileclient
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi/clients/__init__.py", line 4, in <module>
    from gmusicapi.clients.webclient import Webclient
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi/clients/webclient.py", line 20, in <module>
    import gmusicapi.session
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gmusicapi/session.py", line 11, in <module>
    import gpsoauth
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gpsoauth/__init__.py", line 4, in <module>
    from . import google
  File "/tmp/gmusicapi/lib/python3.6/site-packages/gpsoauth/google.py", line 4, in <module>
    from Cryptodome.PublicKey import RSA
  File "/tmp/gmusicapi/lib/python3.6/site-packages/Cryptodome/PublicKey/__init__.py", line 21, in <module>
    from Cryptodome.Util.asn1 import (DerSequence, DerInteger, DerBitString,
  File "/tmp/gmusicapi/lib/python3.6/site-packages/Cryptodome/Util/asn1.py", line 25, in <module>
    from Cryptodome.Util.number import long_to_bytes, bytes_to_long
  File "/tmp/gmusicapi/lib/python3.6/site-packages/Cryptodome/Util/number.py", line 387
    s = pack('>I', n & 0xffffffffL) + s
                                 ^
SyntaxError: invalid syntax

Huh. A brief look looks like they expect it to work with 3.6 and that you're on the latest version.

That's what I saw too. Am I missing something?

Yeah, not sure what's up. I'll have to try recreating it when I get a chance.

For what it's worth, it works fine on travis: https://travis-ci.org/simon-weber/gmusicapi/builds/288287072.

So it looks like the pycrytodomex setup script is not refactoring using 2to3 library in my environment for reasons I wasn't able to determine at this point. I had to do it manually which resolved my issue.
$ 2to3 -wWn --no-diffs /tmp/gmusicapi/lib/python3.6/site-packages/Cryptodome

Bizarre! Glad you got it figured out. May be worth an issue over on their repo.

Ended up having the same issue when I upgraded to 3.7. After doing some additional troubleshooting, I believe I found the root cause per my comment below.
https://github.com/Legrandin/pycryptodome/issues/105#issuecomment-423775965

Woah, that's super bizarre. Yeah, I can definitely see how distributing only bytecode would cause an issue.
Thanks for following up!


UploadedFile - Codeception

What steps will reproduce the problem?
When i have a codeception test, i send the next POST request
$files = [
'file_name' => codecept_data_dir('image.jpg')
];
but it gets conflicted with the function UploadedFile::saveAs ()
[...] elseif (is_uploaded_file($this->tempName)) [...]
Because the file is not upladed but 'emulated' via codeception
What is the expected result?
File Uploaded
What do you get instead?
File is not uploaded
Additional info

Q
A

Yii version
2.0.12

PHP version
7.0.18

Operating system
Linux Ubuntu 16.04

Please fix this issue, we can not write any test cases around uploading a file at the moment.

The same problem here. Can't test because any use of attachFile() will not really save the file in Yii2 at all because UploadedFile::saveAs() with $deleteTempFile = false will check is_uploaded_file() and, if it has not POSTed, it will not be saved.

Any idea on how to fix it?

Yeah, @samdark. I tryed this and it works fine in my tests (files are being 'copied' or moved as expected):
public function saveAs($file, $deleteTempFile = true)
    {
        if ($this->error == UPLOAD_ERR_OK) {
            // added this if block
            if (YII_ENV_TEST) {
                if ($deleteTempFile) {
                    return rename($this->tempName, $file);
                } else {
                    return copy($this->tempName, $file);
                }
            }
            if ($deleteTempFile) {
                return move_uploaded_file($this->tempName, $file);
            } elseif (is_uploaded_file($this->tempName)) {
                return copy($this->tempName, $file);
            }
        }

        return false;
    }

Can't we mock UploadedFile somehow instead of mixing production code and tests?

About the mock, maybe somebody has some idea but now I just cant see how since UploadedFile is being directly instantiated inside the SUT code without use SL/DI.

@SamMousa do you have any ideas about that?

We could mock the function; since UploadedFile is in a namespace, doing this will make it work:
namespace \yii\web {
    function is_uploaded_file() {
        return true;
    }

This code could then be part of the yii2 module, this is a working example:

<?php

namespace test\abc;

class Test {

    public function override() {

        eval(<<<PHP
        namespace test\abc {
            function is_uploaded_file() {
                echo "OVERRIDE IN EFFECT\n";
                return true;
            }
        }
PHP
        );
    }
}

$test = new Test();
$file = tempnam(sys_get_temp_dir(), 'x');
file_put_contents($file, 'abc');
var_dump(is_uploaded_file($file));
$test->override();
var_dump(is_uploaded_file($file));

Sounds much better than conditions in UploadedFile itself. Should we move it to Codeception repo issues?

Yes, first there should be a failing test case created: https://github.com/codeception/yii2-tests
@BerkantC are you up for that?
Basically you create a new app config with a test that fails.
In your case you could even just add a test here:
https://github.com/Codeception/yii2-tests/tree/master/cases/simple/functional

Everytime I enter in github I learn more! It seems a very good solution @SamMousa.

Was it finally fixed? I'm having the same error :(

@marcis14 no, it was not. Do you have time to contribute a fix?

I think https://github.com/yiisoft/yii2/issues/14260#issuecomment-401725014 is still valid but tests were moved to https://github.com/Codeception/module-yii2

Sorry, didn't get it.
In case it helps, this was my solution:
// Copy if TESTING, move if not
$this->file->saveAs($fullPath, !YII_ENV_TEST);


_snippetResult is null

Hello 👋
I've been using MeiliSearch-React and was able to use react-instantsearch along with Highlight API successfully 🎉
However, I'm also trying to use the Snippet API, but the _snippetResult property seems to come back as null. I might be missing something though, but this is reproducible in the sandbox mentioned in the repository as well. I'm wondering if something extra needs to be done for the same.

FWIW: Algolia has an attributesToSnippet property, which I think determines what comes back in the snippetResult. Is there a similar option to that? I also don't see docs mentioning about Snippeting, so not entirely sure if Snippets are currently supported in Meili now ( I might be wrong about this 😅 ).
Thanks!

Hello @Shriram-Balaji!
Thanks for using MeiliSearch and trying to integrate it into your react application 😁
There is indeed an equivalent to snippet in MeiliSearch that is called crop. See this documentation. But as you are using InstantSearch which belongs to Algolia, all the configuration in front end will be called snippet.
Here are the steps to add the snippetting:

Add the snippetting in the Configure component:

<Configure
    attributesToSnippet={['description:50']}
    snippetEllipsisText={"…"}
/>

(50 is the number of characters, not words!)

Add the Snippet component

<Snippet attribute="description" hit={props.hit} />

This works for me.
Tell me if you still have the issue. Maybe do you work with an old instant-meilisearch version? The crop/snippet has been added since the v0.2.0 and the latest is the v0.2.2.
If you still stuck, I will create a sandbox to show you what I succeed to get 🙂

@curquiza Thank You! The Configure was what I was missing. I was able to get it to work.
Quick question: Is there a simple way to hide an attribute Highlight / Snippet if it doesn't have anything matches at all?
Say I have a document indexed like
{
 name: 'shriram',
 phone:<PHONE_NUMBER>,
dob: 01/01/1960

}

and my searchQuery is shriram. Here the hit will only be on the hit.name, and I don't want to show the other two snippets.

@Shriram-Balaji
What do you mean exactly by I don't want to show the other two attribute snippets / highlights?
When setting attributesToHighligh to ["name"] (and with q="shiram") you get this hit:
{
    "name": "shriram",
    "phone":<PHONE_NUMBER>,
    "dob": "01/01/1960",
    "_formatted": {
        "title": "shiram",
        "phone":<PHONE_NUMBER>,
        "dob": "01/01/1960"
    }
}

Do you want to get the situation 1 or 2?

situation 1:

{
    "name": "shriram",
    "phone":<PHONE_NUMBER>,
    "dob": "01/01/1960",
    "_formatted": {
        "title": "shiram",
    }
}

situation 2:

{
    "name": "shriram",
    "_formatted": {
        "title": "shiram",
    }
}

Unfortunately, situation 1 is not doable, but situation 2 is by setting attributesToRetrieve to name 🙂
See these docs

@curquiza Basically, there are some fields in a search document that I want to show only if there's an actual text match to highlight.
It seems to me that I could just do a .contains('em') on the hit response, but that feels slightly messy.

Ok I understand better now, and, unfortunately you cannot do that with MeiliSearch so far.
Glad your fix works even if you are not really proud of it, I hope this would be useful for people looking for a solution! Thanks for your feedback then 😁

@curquiza , I am getting same issue with vue-instantsearch. In my case when I do add  component, meilisearch doesn't take any query parameters(It doesn't work). Both,  &  components are not working for me with meili. Can you help me out or make any sandbox with vue?

Hello @vivekneem!
We made a sandbox with Vue (that is accessible from the meilisearch-vue README -> https://codesandbox.io/s/ms-vue-is-1d6bi.
If you still have the issue,  can you open a new issue in https://github.com/meilisearch/meilisearch-vue/ or https://github.com/meilisearch/instant-meilisearch/?
Don't hesitate to detail your steps 😉

@curquiza , I have just gone through your codesandbox example. Whatever things you have used in an example are also working fine for me, but ais-snippet & ais-configure components are not working

Can you open a new issue with the detailed steps please? We cannot help you if you don't describe what you are doing.
Here is the link to open a new issue: https://github.com/meilisearch/instant-meilisearch/issues/new
I'm also going to open an issue to improve the documentation of these packages 😉


Use bundle cache

is there a way to use a bundle cache to speed up builds
something like this instead of just bundle
bundle config path vendor/bundle
bundle install --jobs 4 --retry 3

add tell people to add

uses: actions/cache@v1
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-

before the build if they want to use a cache

if you do this It seems to break the ability to run the jekyll command. Honestly Im a noob at this stuff not sure why

@HoloPollock this is a good suggestion and an easy fix. Will update shortly.


implement monadic attribute specs

Type's native property 'has' will create monadic wrapper with proper attribute spec subtype inside.
.options, .value, and .has will return monadic wrapper.
Which will allow us to use better option's syntax:
Date.has
	.value(null)
	.events({

	})
	.triggerWhenChanged(false),

[ ] Consider adding datatypes for Anything and JSON (will affect clone operation).
[x] Consider deep refactoring of Attributes metatypes.
[-] Consider making untyped attrubute metatype a subclass, not the base class.

Implemented in f/optimized-set


Updates for 1.13.0 final release

Description
Updating 1.13.0 tag with all final versions of runtime and SDKs.
Updates:
[x] global.env update to 1.13.0 runtime and cli
[x] go update for 1.10.0
[x] C# update for 1.13.*-*
[x] Javascript update for 3.3.0
[x] Python update for dapr>=1.13.0a,<1.14.0
[x] Java update for 1.11.0 (0.11.0 for workflow)
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] The quickstart code compiles correctly
[x] You've tested new builds of the quickstart if you changed quickstart code
[x] You've updated the quickstart's README if necessary
[x] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

We're good to go.  @msfussell please merge
The javascript test failure is due to these issues, and they will be magically fixed once the sdk is updated and tagged.
https://github.com/dapr/quickstarts/issues/998
https://github.com/dapr/js-sdk/issues/580


Remove set_hs_protocol function

This is a preparation for implementing Key Update and dropping keys. The goal of this PR is eliminating set_hs_protocol.
I'm going to introduce QUICPacketProtectionKeyInfo as a shared storage. It will be shared between QUICHandshakeProtocol and classes that use keys. By using the class, the key users don't need to access a handshake protocol.
This will simplify QUICHandshakeProtocol interface, and remove necessity of adding functions like drop_key to QUICHandshakeProtocol.

This is still WIP.

KeyMaterial and QUICPacketProtection were replaced with QUICPacketProtectionKeyInfo. Like I wrote on the description, this object is shared between a key generator and key users.
I also introduced QUICPacketPayloadProtector. Packet protection (payload encryption) was done by QUICHandshakeProtocol (QUICTLS), but now QUICHandshakeProtocol only does handshake. Keying materials generated as a result of handshake will be stored into QUICPacketProtectionKeyInfo, and QUICPacketPaylaodProtector (and QUICPacketHeaderProtector) will read the keys from it.
I'm still updating tests so this PR still has WIP label, but please start review. At minimum, a simple GET request from ngtcp was succeeded.
However there are many places we can optimize, I'm going to make small changes when I have time after I merge this. I think adding support for Key Update and dropping keys have priority (and anybody can work on these once we merge this).

It's ready for review.

Cool. Will have a look tomorrow.

@maskit Do you have any Key Update code based on this?

Do you have any Key Update or dropping keys code based on this?

No, I don't have any code at the moment.
I think next step for Key Update will be adding QUICHandshake::get_key_genearator() or passing a key generator to QUICHandshakeProtocol instead of QUICPPKeyInfo. In either ways, QUICNetVC will have a full and direct control for managing keys. It should satisfy key update and key drop scenarios. I may introduce QUICKeyUpdater to delete the processes.


Update to the latest go-amqp

(pending release of a new rev of go-amqp to incorporate @jhendrixMSFT 's fix)

/azp run go - azservicebus


web UI: document that we have the raw search operator

https://perkeep-review.googlesource.com/c/perkeep/+/18066


[EdgeTPU] Add EdgeTPU Input Path to CfgEditor

Implemented the ability to input the path as either text or via a dialog.
Disabled the output path functionality.
Modified the output path to append "_edgetpu" as a postfix to the name of the .tflite file received from the input path.

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk<EMAIL_ADDRESS>

LGTM


Is there a remove-gitlabproject command?

I can use remove-gitlabgroup command successfully. When I want remove a gitlab project ,I can't find remove-gitlabproject.
Am I missing some command list?
PS /root> Get-Help Remove-GitlabProject
Name                              Category  Module                    Synopsis

Remove-GitlabProjectHook          Function  GitlabCli                 …
Remove-GitlabProjectIntegration   Function  GitlabCli                 …
Remove-GitlabProjectMember        Function  GitlabCli                 …
Remove-GitlabProjectVariable      Function  GitlabCli                 …
https://docs.gitlab.com/ee/api/projects.html#delete-project
Thanks.

typically I've used Invoke-GitlabProjectArchival (aka Archive-GitlabProject) to "soft delete" projects.
but I see no reason why not to add Remove-GitlabProject as well

Dear,Thanks for your message.I will get back to you shortly.Have a good day!
Regards
Yueheng Guo

typically I've used Invoke-GitlabProjectArchival (aka Archive-GitlabProject) to "soft delete" projects.
but I see no reason why not to add Remove-GitlabProject as well

Thank you chris, Invoke-GitlabProjectArchival is also a workround at present.

Fixed in https://github.com/chris-peterson/pwsh-gitlab/commit/08d718fb9557e6171349eae65dfb892096e63c64

Dear,Thanks for your message.I will get back to you shortly.Have a good day!
Regards
Yueheng Guo


Adding English Editorial for LOJ-1063

ISSUE: https://github.com/lightoj-dev/problem-tutorials/issues/223

@maverickjoy Hello dear author. Please include the example under the Solution para. We also don't allow github/linkedIn links for author credits. However you can take credits by linking your LightOJ user name.

Updated

@maverickjoy Thank you for your contribution 💯


fix(trigger) : Change order of skip triggers

Do skip triggers after the base hook object has been filled with commit message when it is empty.
It should fix the issue that the [skip ci] didn't work for recent Bitbucket version because the commit message isn't on the push event but the hash still being in it.
linked to : https://github.com/drone/go-scm/pull/84

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've not realy tested it, but the goal is to do skip triggers after the commit message has been filled with the "After" property of the hook (Bitbucket push hook has been modified in https://github.com/drone/go-scm/pull/84 to add the hash commit).


⚠ ClamAV has degraded performance

In ec6414a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 75 ms

Resolved: ClamAV performance has improved in 722cc11 after 5 minutes.


[Bug] Console will be stuck in workflow sample

Expected Behavior
The program exits gracefully when I press Ctrl + C.
Actual Behavior
Unable to terminate the generation of these logs
...
info: Microsoft.DurableTask[3]
      The gRPC server for Durable Task gRPC worker is unavailable. Will continue retrying.
info: Microsoft.DurableTask[3]
      The gRPC server for Durable Task gRPC worker is unavailable. Will continue retrying.
info: Microsoft.DurableTask[3]
      The gRPC server for Durable Task gRPC worker is unavailable. Will continue retrying.
...

Steps to Reproduce the Problem
dotnet run in ./examples/Workflow/WorkflowConsoleApp without dapr sidecar start.
Or terminate the dapr sidecar when the program is running.

Which process are you killing with Ctrl+C? The dapr sidecar? If so, I think this behavior is expected. Here you can see that the app waits for the sidecar to become available. Even after this, the app is designed to run continuously.

Which process are you killing with Ctrl+C? The dapr sidecar? If so, I think this behavior is expected. Here you can see that the app waits for the sidecar to become available. Even after this, the app is designed to run continuously.

I cant exit the WorkflowConsoleApp even I press ctrl + C as long as I exit the dapr sidecar first. It gets stuck in my command line so I can't do anything else, which I'm sure isn't a great experience for other users either.


Cannot set function breakpoint

Issue Type: Bug
Testing #43836
Following the documentation on this, the function breakpoint did not work. Also note that in the screenshot the function breakpoint is shown as resolved, but when I add it while the program is running, it is shown as unresolved.

VS Code version: Code - Insiders 1.21.0-insider (1a84a882737184488d965426747a05474f54a759, 2018-02-27T06:09:52.377Z)
OS version: Darwin x64 16.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.25GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --user-data-dir tmp/user --extensions-dir tmp/ext

Screen Reader
no

VM
20%

Extensions: none
Reproduces without extensions

@weinand can you please investigate if the backend is providing the expected data.

Please be aware of the limitations of function breakpoints: https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_function-breakpoints

Retried with v6.11.3 and it didn't work. (This time the function breakpoint was shown as unconfirmed when I started debugging.)

This also didn't work for me.

node.js versions >= 8.0 no longer support function breakpoints.

@weinand should the adapter then return function breakpoints as unverified. Or it already does that but the UI is not respecting it?

for node.js >= 8 the adapter does not support function breakpoints so "supportsFunctionBreakpoints" is falsy.
VS Code should not send any functionBreakpoints.
for node.js < 8 the DA sends back Breakpoint with the "verified" property set to true, see:
https://github.com/Microsoft/vscode-node-debug/blob/602790fc530a89825bcc779b2f4cfbb249c8a199/src/node/nodeDebug.ts#L2121-L2127

In the latest we properly show that the breakpoint is not resolved no matter when it is added. So imho this behaves fine now


Unable to build from node-gyp : cannot use typeid with -fno-rtti / jni.h file not found

I'm using Djinni in the context of a react native project.
My starting point is this repo where Djinni is linked as a submodule.
In on macOS High Sierra.
When I run npm install, it tries to build Djinni...
...
gyp verb command build []
gyp verb build type Release
gyp verb architecture x64
gyp verb node dev dir /Users/omatrot/.node-gyp/7.10.1
gyp verb `which` succeeded for `make` /usr/bin/make
gyp info spawn make
gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
  c++ '-DNODE_GYP_MODULE_NAME=djinni_jni' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' -I/Users/omatrot/.node-gyp/7.10.1/include/node -I/Users/omatrot/.node-gyp/7.10.1/src -I/Users/omatrot/.node-gyp/7.10.1/deps/uv/include -I/Users/omatrot/.node-gyp/7.10.1/deps/v8/include -I../deps/djinni/support-lib/jni  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF ./Release/.deps/Release/obj.target/djinni_jni/deps/djinni/support-lib/jni/djinni_support.o.d.raw   -c -o Release/obj.target/djinni_jni/deps/djinni/support-lib/jni/djinni_support.o ../deps/djinni/support-lib/jni/djinni_support.cpp
In file included from ../deps/djinni/support-lib/jni/djinni_support.cpp:18:
In file included from ../deps/djinni/support-lib/jni/djinni_support.hpp:26:
../deps/djinni/support-lib/jni/../proxy_cache_interface.hpp:137:49: error: cannot use typeid with -fno-rtti
        ~Handle() { if (m_obj) cleanup(m_cache, typeid(TagType), get_unowning(m_obj)); }
                                                ^
In file included from ../deps/djinni/support-lib/jni/djinni_support.cpp:18:
../deps/djinni/support-lib/jni/djinni_support.hpp:28:10: fatal error: 'jni.h' file not found
#include <jni.h>
         ^~~~~~~
2 errors generated.
make: *** [Release/obj.target/djinni_jni/deps/djinni/support-lib/jni/djinni_support.o] Error 1

I'm sure that I could find a way to not use -fno-rtti but what about the missing file ? Are these 2 problems related ?
Thanks for your help.

The first problem is a node-gyp related problem.
I modified ~/.node-gyp/7.10.1/include/node/common.gypi' in line 367 to set YES instead of NO
'GCC_ENABLE_CPP_RTTI': 'YES',              # -fno-rtti

The second problem was solved by creating an environment variable:
export CPLUS_INCLUDE_PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/include:/Library/Java/JavaVirtualMachines/jdk1.8.0_101.jdk/Contents/Home/include/darwin/
There has been additional problems all solved by modifying common.gpyi:
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',

'OTHER_CFLAGS': [
            '-fno-strict-aliasing',
            '-fobjc-arc'
          ],

All problem solved

for Linux build (Ubuntu 16.04): we need to fix several issues at 3 different locations:
-in our node-gyp installation: common.gypi line for 'OS in Linux .... use those flags:
'cflags_cc': [ '-frtti','-fexceptions', '-std=gnu++0x' ],

in Djinnius/binding.gyp remove ldflags: llog
in Djinnius/libhelloworld.gyp remove ldflags: llog


orchestrator to inject Pseudo-GTID

This idea has been circling: that orchestrator should take ownership of injecting pseudo-GTID entries onto masters. Thus, the user will not need to take care of a special pseudo-gtid service or an event_scheduler entry. Moreover, the user will not need to manage enabling/disabling said service or event at time of failover.
Considerations:

This requires orchestrator to reliably know who the master is. This statement sounds almost trivial, given that orchestrator is the one to run failovers. Just noting.
orchestrator would need privileges to inject the pseudo-gtid entry. On RBR  like using drop view if exists ... which means orchestrator would need the DROP privilege.

Closed by https://github.com/github/orchestrator/pull/384


Only accepting ALIVE changes from unknown trusted writers <1.8.x> [7588]

This is a port of #1005 from 1.9.x

Refs #7552. Only accepting changes from unknown writers when they are ALIVE.
Refs #7552. Added blackbox test.

Build status:

Linux
Mac
Windows

Failures on Mac are due to #954 not being backported to 1.8.x


Rendering broken on X11 since recent changes

Hi,
I'm trying to run the latest git master + Wayfire git master and getting the following errors:
EE 17-12-20 12:57:25.913 - [backend/x11/backend.c:602] X11 error: op 149:7, code 11, sequence 32, value 109051908
EE 17-12-20 12:57:25.964 - [render/swapchain.c:97] No free output buffer slot

Everything works when reverting to 16a51bbab27ba5fa9348f21cfabff3085e25fc99
Notes: I'm on Ubuntu 18.04 and have to revert commits dd69c5871cbfd00b88309fcff8a159f9bb515510 and 1100c509c253bab72a0b51879d23558305e8723a to build; I understand if this might be an issue, but opening this since the problem does not seem directly related.
I'm attaching the full log (note: the error about no matching mode in line 56 appears in a working build as well)
swapchain_error.log

Can you try building with xcb-errors? This would make it easier to debug these X11 errors.
What X11 driver are you using? I've tested with the modesetting driver on amdgpu.

Hi,
with xcb-errors, I get the following errors:
EE 17-12-20 21:17:57.746 - [backend/x11/backend.c:592] X11 error: op DRI3 (PixmapFromBuffers), code Alloc (no extension), sequence 62, value 52428804
EE 17-12-20 21:17:57.746 - [backend/x11/backend.c:592] X11 error: op Present (Pixmap), code Pixmap (no extension), sequence 64, value 52428805
EE 17-12-20 21:17:57.746 - [backend/x11/backend.c:592] X11 error: op DRI3 (PixmapFromBuffers), code Alloc (no extension), sequence 65, value 52428804
EE 17-12-20 21:17:57.746 - [backend/x11/backend.c:592] X11 error: op Present (Pixmap), code Pixmap (no extension), sequence 67, value 52428807
EE 17-12-20 21:17:57.764 - [backend/x11/backend.c:592] X11 error: op DRI3 (PixmapFromBuffers), code Alloc (no extension), sequence 72, value 52428804
EE 17-12-20 21:17:57.764 - [backend/x11/backend.c:592] X11 error: op Present (Pixmap), code Pixmap (no extension), sequence 74, value 52428809
EE 17-12-20 21:17:57.783 - [backend/x11/backend.c:592] X11 error: op DRI3 (PixmapFromBuffers), code Alloc (no extension), sequence 75, value 52428804
EE 17-12-20 21:17:57.783 - [backend/x11/backend.c:592] X11 error: op Present (Pixmap), code Pixmap (no extension), sequence 77, value 52428811

After this, the No free output buffer slot keeps repeating until I kill the process, and there is no output.
As far as I can, the X11 driver is modesetting, with the i965 DRI2 driver. DRI3 is loaded, but I see no messages related to it in my Xorg.log -- I'm attaching it here, in case there's something useful in it.
Xorg.0.log

Can you try https://github.com/swaywm/wlroots/pull/2553?

Just tried and it's working with #2553 . Thanks!


Long tap and release on devices gives session lost popup all the time

Which OS is that? Also is it in landscape?

i m seeing this in 17.5.1 and 15.8.3 , it is happening in portrait/landscape

This particular snippet shows the session timed out after 120 seconds? If you go back and reopen the device does it start working again? Also are you using the custom WDA from my fork?

yes it works fine after capturing the device again , i'm using custom wda only from your forked branch. Is the issue reproducible from your side?

I haven't tested yet but I have an assumption why it happens - with mainstream WDA the interactions go through Appium so the session refreshes each time you do something. With my WDA the interaction endpoints do not use a session so even if you tap/swipe for Appium its like nothing has been done and at some point the session expires... I didn't really think about that so it is something I need to fix in some way :( 😅

If you are building the provider from source instead of using the prebuilt binaries you can go here and here and update the value to something bigger - this should help until I have the time and find a reasonable way to handle this

@Gnanaprakash22 I've updated the session management implementation in the latest release - default device control Appium session timeout is 30 minutes, so if for some reason it expires I've added a button to refresh it directly from the device control UI. Also I've implemented a separate "control" session that is also 30 minutes, so if someone is controlling the device and does not perform any action for 30 minutes they will be kicked out and the device released

@shamanec thanks for the update

@shamanec long tap and hold is giving

@Gnanaprakash22 does this happen consistently? is it possible that the session has just expired? What if you reload the Appium session from the button above the canvas, does it still show an error after? When it happens does it happen only for touch&hold?

i see it happens only for touch and hold @shamanec

@Gnanaprakash22 sorry for the delay? is this in both landscape and portrait? is it using custom WDA from my fork or mainstream WDA? I can't seem to reproduce it right now

@shamanec sorry for the delay in response i m using version 2.4.1 and I'm still facing issues
let me update the version and check

@shamanec i m still facing the same issue and also i m not able to input any text using textfield any recommended appium & xcuitest driver version ?

typeText api is giving 500 internal server error with "invalid character ''' looking for beginning of object key string" response

@shamanec FYI I'm facing this Touch and hold issue & Text input in ios devices , haven't verified the same in android so please check this from your end if possible in ios devices

@shamanec did you get a chance to check Touch and hold & Text input issues in ios devices ?

@Gnanaprakash22 hey, man, not yet, sorry about that, I was quite busy and now its Christmas holiday 😅 Just to make sure, you are trying to type in English? Because this uses Appium under the hood and I believe it does not support any other language

@Gnanaprakash22 nvm, I found the issue with typing, I've create a hotfix release 2.6.1. I will look into the touch&hold issue next :P

@shamanec
Thank you for the quick release! 😊 Just to clarify, I’m entering text in English only, no other languages. Apologies for reaching out during the holidays—there’s no rush at all. Enjoy your holidays and have a Merry Christmas! 🎄✨

@Gnanaprakash22 it should work now, I released 2.6.2 hotfix. There was an issue both in portrait for touch&hold and in landscape for all actions with custom WDA, stupid mistake on my part 😅

@shamanec Awesome, thanks for the update !!!

You got it, feel free to close the issue if everything is fine 🙃

sure will do it


feat: configuring debugging on vscode

This PR configures debugging on vscode.
Works for both the api routes, and the turborepo packages.

It's very similar to the default launch.json vscode creates, but it has some very important differences for the monorepo architecture.
default launch.json:
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "skipFiles": [
                "<node_internals>/**"
            ],
            "program": "${file}"
        }
    ]
}

The default misses the startup parameter we use in create-t3-turbo: "command": "pnpm dev",
And most important for the monorepo architecture the "cwd": "${workspaceFolder}/apps/nextjs/", parameter.
As we can have multiple different apps, the vscode debugger needs to point to the correct node_modules folder. Without the pointing, the debugger cannot find the dependencies the app needs to startup:


README isn't that great

Please change your README, I don't get what these files do.

I submitted a pull request, pretty sure I made it like 100x better.

Haha merged!


Roll Flutter Engine from 8ed7a1905b0a to 1934ddbed6e8 (2 revisions)

https://github.com/flutter/engine/compare/8ed7a1905b0a...1934ddbed6e8
2022-10-17<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from JIZ3JUIi-78MpuBlm... to GvWjlKsW1ybhJZzUp... (flutter/engine#36793)
2022-10-17<EMAIL_ADDRESS>Roll Dart SDK from 78cc201df487 to d027485f6adf (1 revision) (flutter/engine#36789)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from JIZ3JUIi-78M to GvWjlKsW1ybh
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


NCDA - Aggregated Scorecard: ANC + Newborn pane (data + presentation) [6h]

Techinical note:
For path params, the logic is: if there's NCDA questioneer where answer is Y, it's considered for whole duration of pregnancy (9 precending months to birth month).

NCDA is on live for few months. Closing.


Window Position

First things first, I appreciate all the hard work that has gone into scrcpy, so BIG thank you!.
I have been using scrcpy for a couple years now on a daily basis. On previous versions of scrcpy when window position and size wasnt available I have been using Auto Hot Key to do this. Thought I would let scrcpy do it instead but have run into a problem. My PC is currently running 3 screens, which I think maybe the problem. Using the same x y positions that a used with Auto Hot Keys gives me this error: ERROR: Could not parse window position: value (-1080) out-of-range (-1; 32767). I use AHK's windows spy to get the x y positions, not too sure if that has anything to do with it. Is there another way to get x y positions that scrcpy will accept? Cheers again.

ERROR: Could not parse window position: value (-1080)

There is now more checking for input values.
Currently, a window position may not be negative in scrcpy. The reason is that it seems that SDL does not support negative values (it places the window at 0 anyway).
I just allowed negative values locally, and tested with multiple screens, I cannot reproduce a case where a negative value is correctly handled by SDL.
In practice, why do you pass -1080?

Hi again, changing my main screen to screen 1 will get the results that I'm after but not what I want. If my screens are layed out side by side it also works just abit of getting used to. Cheers again

Unfortunately, it seems SDL does not allow to pass negative values. Or more precisely, it behaves as if you passed 0.
This is weird because it is not possible to initialize a window partially offscreen on the left, but once it is created, we can move it manually…

In fact, it is programmatically possible to set a negative position, but only once the window is shown (and we can see it "jump").
diff --git a/app/src/screen.c b/app/src/screen.c
index beb1075..3521331 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -236,6 +238,7 @@ screen_init_rendering(struct screen *screen, const char *window_title,
 void
 screen_show_window(struct screen *screen) {
     SDL_ShowWindow(screen->window);
+    SDL_SetWindowPosition(screen->window, -100, 100);
 }

 void

:confused:


Hiding element not working as expected.

<div class="col-xs-2 d-none d-xs-block d-md-none" >
    Something
</div>

As I understand div should be visible on xs and sm breakpoints. d-none stands for hide all from xs to xl. d-xs-block stands for show as block xs and above, d-md-none stands for stop showing element starting from md including it.
But the block doesn't show up at all. What is the problem?

Hi @berpcor you are overdoing it.
By default any div will be block, d-md-none will remove it on md and up:
https://codepen.io/andresgalante/pen/pdmjyX?editors=1000

There is no .d-xs-block. You're .d-none is applying for the first grid tier (xs). You want d-none d-sm-block d-md-none or the equivalent.


RFP - Laragon

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://laragon.org/
Direct download URL for the software / installer : https://sourceforge.net/projects/laragon/files/releases/4.0/laragon-full.exe
Software summary / short description:
"Laragon is a universal development environment"

Just submitted, waiting for automatic and manual reviews.
https://chocolatey.org/packages/laragon
https://chocolatey.org/packages/laragon.install
https://chocolatey.org/packages/laragon.portable

What is the difference between "laragon" and "laragon.install" package please?

@Michal-Mikolas The laragon package is a meta package. This can be seen when you go to the package page for laragon and you'll notice this banner:

This banner contains a link to the Chocolatey FAQ documentation about metapackages

"laragon" is metapackage, "laragon.install" is also metapackage. What is the difference between the two?
Which one should I use for the best user experience?

@Michal-Mikolas
Inside the screenshot above following text is displayed:

Install (.install/.app (deprecated naming convention)) - uses native installers, usually requires administrative access to install.

The laragon package is there for discovery, it has a dependency on the laragon.install and that package will install the laragon software.
Depending on how you want to work with meta packages, you can either choose to install the laragon.install package or not.
I would like to request that you read the banner and the FAQ.


[string] Add a c_str() method

Does adding the storage to the body of hana::string affect the compile-time of creating strings?
I might have some time to test this out if you haven't already. ☕

Good point; I don't know for sure. It would be great if you had time to check it out, I'm at the committee meeting right now.

Thanks a lot for looking into it! Here's what I tried: https://gist.github.com/ldionne/bf105d0ee029774677ef55c3e2e409c1.
And the results:

So I'll use the second implementation, which seems to be a bit faster.


repo-stream update

Opened by mondeja/repo-stream-config/upstream.yaml

Pull Request Test Coverage Report for Build 981378249

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 25.091%

Totals

Change from base Build 964253897:
0.3%

Covered Lines:
69

Relevant Lines:
275

💛  - Coveralls


chore(ci): remove version lock on changelog generation

Issue number: #1009
Summary
Changes

Please provide a summary of what's being changed

This PR reduces operational overhead when releasing a new version by restricting manual steps to a single job: Drafting release notes.
Main changes

Changelog generation and version bump are now part of the release process
Release process can be triggered manually in case of GH Actions intermittent failures with builds to start
Split release jobs into three to ease further maintenance: 1/ release PyPi/SAR, 2/ docs, 3/ post release

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of my this change
[x] Changes are tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Tasks

[x] Remove version checking
[x] Push staged files pyproject/changelog to trunk
[x] Prevent concurrent docs pushing different changelog versions
[x] Split docs and auto-close issues
[x] Update manual x automated activities step
[x] Split jobs to ease further maintenance

[x] Make sure git is configured in separate job just in case

[x] Update failure mechanism
[x] Update MAINTAINERS.md release steps
[x] Include manual dispatch for failures

Separate PR to limit failure radius

[ ] Make docs build workflow reusable
[ ] Include changelog bump on every PR merge (unreleased section)

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

View rendered .chglog/CHANGELOG.tpl.md
View rendered MAINTAINERS.md

@rubenfonseca @leandrodamascena -- need your input the most here. Please let me know if this is clear, and whether there are any areas you want to me further document now (or later?).

Hello @heitorlessa. Thanks for tagging me.
I added two comments but this PR looks amazing. This will reduce friction in the manual steps and make things more automated.
This PR makes announcing new releases even more interesting as it automates all the work in the repository and allows for human interaction by writing text (and with images) announcing the release.
I can't think of anything to add to the documentation right now. But I'll let you know if I think of anything new.
Congrats :100: :rocket:

@rubenfonseca need your approval before I fix a conflict and merge


docs: cleanup adapters files (fixes #2421)

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
fixes #2421
since v0.14.0 the serve cmd is no longer created on package.json files. Therefore it is now removed from the docs.
Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

thanks @zanettin !


upgrade to ONNX 1.17.0 (opset 22)

Jenkins Linux ppc64le Build #14994 [push] upgrade to ONNX 1.17.0 (... started at 15:03

Jenkins Linux amd64 Build #15964 [push] upgrade to ONNX 1.17.0 (... started at 13:48

Jenkins Linux s390x Build #15967 [push] upgrade to ONNX 1.17.0 (... started at 14:48

LGTM, thanks @gongsu832
as a follow on, one will have to update what is actually supported (e.g. we don't support the bfloat16. @Sunny-Anand can someone on your team update the limitations in our docs?

Thanks @gongsu832 for the upgrade. @AlexandreEichenberger I will have someone update the limitation in the docs.

Jenkins Linux amd64 Build #15964 [push] upgrade to ONNX 1.17.0 (... passed after 1 hr 20 min

Jenkins Linux s390x Build #15967 [push] upgrade to ONNX 1.17.0 (... passed after 1 hr 24 min

Jenkins Linux ppc64le Build #14994 [push] upgrade to ONNX 1.17.0 (... passed after 2 hr 16 min


Add OnResumeFragments event for FragmentActivity

Hi,
This is an important event, because only after it we can use the fragmentManager without getting an exception of execute pending transactions while onSaveInstanceState is called.
I personally used it to postpone any fragment transaction to a point where it can be run without forgetting about it but I guess there are other scenarios as well.
In my code I've changed ActivityEvent.RESUME to be run after this call instead of the regular onResume but that because I didn't want to change the ActivityEvent enum. so it might be a better change over there.
But I guess this event is only applicable to FragmentActivity so a different approach might be needed
Tnx, Nitzan

How are you using RxLifecycle in this context? Are you using the Observable<ActivityEvent> to listen for ActivityEvent.RESUME, and then posting fragment transactions in there? Or are you just wanting to bind to a different event?

The first one, I'm using the lifecycle() method and filters the RESUME, then using either delay with lifecycle() as the delay observable or combineWith, depending on exactly what I want to achieve

That's not really the general use case for RxLifecycle. That's why we created navi which has a lot more callbacks from the lifecycle.
That also doesn't have onResumeFragments() but that could easily be added there.

o.k I will check it out, so as I understand it, you only want RxLifecycle to handle the unsubscription of subscribers (which performs through onComplete..)  right?
I actually had another use case which is more appropriate to unsubscription , I will post it tomorrow.
Tnx for all the work, It is much appreciated


Do not swallow IOException in case it is not recoverable

There are 2 changes here:

More failure causes is considered recoverable.
In case the exception is considered nonrecoverable, it is thrown instead of ignored.

https://issues.jenkins-ci.org/browse/JENKINS-41163
https://issues.jenkins-ci.org/browse/JENKINS-26379

@jenkinsci/code-reviewers, pretty please. I would like to get this released soon.

I'm not clear on what IOExceptions we'd expect to be recovering from after this change - the point of the retry seems to be to overcome any network issues which this change now seems to be preventing, so why still have the retry?

I do not follow. It is supposed to retry on exception that is considered recoverable and throws those that are not right away.

LGTM

Sorry, I'd read the logic the wrong way round!
However, we're being very specific about the exceptions we're allowing to try and recover from. Are any exceptions outside of the list you've specified likely to be transient conditions that the next connection attempt may overcome?
The IllegalArgumentException that's being shown in the logs is misleading ('This may be a bug in Jenkins'), and should be handled better, but I'm not convinced that white-listing certain messages is a good way to go.

The IllegalArgumentException that's being shown in the logs is misleading ('This may be a bug in Jenkins'), and should be handled better, but I'm not convinced that white-listing certain messages is a good way to go.

What you are referring to is probably:
[05/20/16 13:01:45] [SSH] Opening SSH connection to <IP_ADDRESS>:22.
No route to host
ERROR: Unexpected error in launching a slave. This is probably a bug in Jenkins.
java.lang.IllegalStateException: Connection is not established!
at com.trilead.ssh2.Connection.getRemainingAuthMethods(Connection.java:1030)
at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPublicKeyAuthenticator.getRemainingAuthMethods(TrileadSSHPublicKeyAuthenticator.java:88)
at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPublicKeyAuthenticator.canAuthenticate(TrileadSSHPublicKeyAuthenticator.java:80)
at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:212)
at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:172)
at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:1212)
...

This is no longer possible with this patch. The old code retried iff it knew it was recoverable and continued execution if it was not considered recoverable causing vague exception of first connection use in, say, No route to host situation.  This code will either fail fast, retry until success or retry and throw if unsuccessful. I share your dislike to exception message processing but I do not see a better way to go.

I'd probably prefer to see a flag set inside the try block if connection.connect() doesn't throw an exception, and then not attempt the authentication if that flag isn't set, whilst logging/reporting any failures on each iteration of attempting to connect.
I'm not clear on what errors we think we're going to fail-fast with (you've covered off a large number of the normal network failures on your recoverable list), or the impact of re-attempting connection if they occur, so I'd just log them and continue trying unless there's a security or performance impact on doing so. This means we're consistent on re-trying for all network failures, but give the user some indication of what they are, and then don't print the java.lang.IllegalStateException: Connection is not established! message if we've attempted all the connection attempts without success,

I'd probably prefer to see a flag set inside the try block if connection.connect() doesn't throw an exception, and then not attempt the authentication if that flag isn't set, whilst logging/reporting any failures on each iteration of attempting to connect.

That is not necessary. The only way for that retry loop to ever finish is by successful connection or throwing an exception.

... but give the user some indication of what they are, and then don't print the java.lang.IllegalStateException: Connection is not established! message if we've attempted all the connection attempts without success,

See above. That is what this fix does exactly.

I'm not clear on what errors we think we're going to fail-fast with (you've covered off a large number of the normal network failures on your recoverable list), or the impact of re-attempting connection if they occur, so I'd just log them and continue trying unless there's a security or performance impact on doing so.

I do not know where to find an authority to provide the necessary guidance here. The retry code was in effect for a while so I see this as a step to more complete list that will likely be a subject of further refinement. I have been using this for testing and in production for a couple of days and it work better.

I will go an and release this later this week unless there are objections.

Is there a fix or workaround other than rolling back?

We tried building this patch and updating our Jenkins to use ssh-slaves plugin with this patch included but still get failure as below. The key is available on the server though and I'm able to manually login to the system through my own SSH client.
ERROR: Server rejected the 1 private key(s) for jenkins (credentialId:test-credential/method:publickey)
[01/26/17 17:50:49] [SSH] Authentication failed.
hudson.AbortException: Authentication failed.
at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:1231)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:724)
at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:719)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
[01/26/17 17:50:49] Launch failed - cleaning up connection

@zxiiro, that seems unrelated to this patch. The connection.connect() succeeded but the authentication failed - as I understand it, this was the same before the patch.

@olivergondza it does seem to be a different issue then. I'll continue to investigate and open a new issue. Did something change in OpenStack plugin around authentication? because this works if we revert OpenStack plugin to 2.11.

This is a change on openstack side of things: https://github.com/jenkinsci/openstack-cloud-plugin/issues/137


Automate - Quota - fixed issue with memory and storage sizes.

https://bugzilla.redhat.com/show_bug.cgi?id=1289278

@mkanoor
Please review

@gmcculloug
Please review

@billfitzgerald0120
The bugzilla ticket talks about changing the log message, is that going to be addressed in this PR
After:
Request exceeds maximum allowed for the following: (cpu - Used: 1719 plus requested: 4 exceeds quota: 1) (memory - Used: 3.27 MB plus requested: 15.00 GB exceeds quota: 2.00 GB) (storage - Used: 4.79 MB plus requested: 80.00 GB exceeds quota:

@mkanoor
The log message now has accurate information and all memory and storage values are expressed as GB.  I have provided a sample below:
(memory - Used: 3145.95 GB plus requested: 2.00 GB exceeds quota: 100.00 GB) (storage - Used: 14809.10 GB plus requested: 18.00 GB exceeds quota: 100.00 GB)

@mkanoor
Correction: Storage values will be expressed in the proper increment.  The problem was that some values were wrong.  The Used values were supposed to be GB and we were expressing them as MB.
Also the requested memory was in KB not bytes so I needed to changed this line to set it to bytes ...
{:memory  => get_total_requested(options_hash, :vm_memory) * 1024**2,

:+1:

@mkanoor
The code was expecting the requested memory to be in bytes but it was in KB.  I modified the 'requested' method to change KB into bytes ({:memory  => get_total_requested(options_hash, :vm_memory) * 1024**2).  The 'bytes_to_megabytes' routine in the 'used' method was also causing problems so I removed it.  The original BZ:  https://bugzilla.redhat.com/show_bug.cgi?id=1289278 mentions that the values were incorrect.  That is the log formatting problem.
I also modified the 2 rspecs to handle the proper values.

@gmcculloug
Please review


Update co_csp.m

assign op twice

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Javascript Replace fails

Hello.
I have some JavaScript that search text inside the pjax container and replaced it. Imagine search the keywood FirstName and replace it to John.
$('#pjax-container').html($('#pjax-container').html().replace(/(FirstName)/ig, 'John'))

it works in a normal Request. (If you press F5 it works)
But when the request is a Pjax rquest the script fails.
If I evaluate the execution using Chrome I see the script has been replaced
$('#pjax-container').html($('#pjax-container').html().replace(/(John)/ig, 'John'))

What Pjax does that changes my script?

You'll need to provide more info. Where do you put your script? How exactly does it fail? What is the error message?

On 12 Jan 2015, at 21:26, Ricardo Polo<EMAIL_ADDRESS>wrote:
Hello.
I have some JavaScript that search text inside the pjax container and replaced it. Imagine search the keywood FirstName and replace it to John.
$('#pjax-container').html($('#pjax-container').html().replace(/(FirstName)/ig, 'John'))
it works in a normal Request. (If you press F5 it works)
But when the request is a Pjax rquest the script fails.
If I evaluate the execution using Chrome I see the script has been replaced
$('#pjax-container').html($('#pjax-container').html().replace(/(John)/ig, 'John'))
What Pjax does that changes my script?
—
Reply to this email directly or view it on GitHub.

This is a invalid Issue. After some testing we found Pjax was no the culprid. Sorry.


Add etcd and controlplane role to exising node

What kind of request is this (question/bug/enhancement/feature request):
bug
Failed to reconcile etcd plane: Failed to add etcd member [etcd-node-1] to etcd cluster
Steps to reproduce (least amount of steps as possible):

Create a Cluster with 3 etcd & controlplane nodes and 2 worker nodes
run some stuff
Edit cluster to flag one of the worker nodes for additional role etcd & controlplane
wait...

Result:
The cluster stucks with this error message (already waitet around 40 minutes in this state):
Failed to reconcile etcd plane: Failed to add etcd member [etcd-node-1] to etcd cluster
Other details that may be helpful:
If  I click edit again, disable etcd and controlplane on the worker node again everything looks fine.
I want to add a 4th etcd to safely remove another etcd node after.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.4
Installation option (single install/HA): single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): hosted vm datacenter ubuntu 16.04

Just to confirm, you didn't see any error while adding 4 etcd nodes? 1,3 or 5 etcd nodes are required to maintain etcd quorum and shouldn't have allowed adding this additional role to just one worker

If I click for the 4th etcd node, the "1, 3 or 5" gets red and a message appear:
Setting 4 etcd nodes is a waste of hardware because it doesn't increase the quorum until you have an odd number.
I can save this configuarion normally and it starts with "updating cluster".
I'm aware that 4 etcd brings no benefit for me. I just want to replace one of the existing etcd nodes so i thought to add the 4th one before I remove one of the existing.

Gotcha, thanks for your reply. I am unable to reproduce this - able to add 4 etcd nodes to custom cluster

Don't know what the problem is.
I now created a new cluster and there it works normal as discribed above.
The old cluster was haning on the step. I now migrated all workload and data to the new cluster and removed the old one.