Go through CII Best Practices Badging

https://bestpractices.coreinfrastructure.org/
This is for @yurishkuro and a requirement of CNCF graduation (down the road). This isn't a super high priority.

If this is something I could help, assign it to me.

@jpkrohling go for it, I don't think @yurishkuro has started this work.

@caniszczyk curious ... is there a label for a project that isn't yet CNCF graduated? or is that something undefined in CNCF. This is the first I've seen a mention of graduation related to CNCF

@adriancole inception, incubating, graduated - https://www.cncf.io/projects/graduation-criteria/

@adriancole the project maturity levels are here: https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc
You can see the status of each CNCF project here: https://github.com/cncf/toc#projects
No project has graduated yet, but we plan to go through a graduation process for some of our projects before the end of this year. As part of bootstrapping a foundation, it took awhile to come up with maturity levels / a process :)

Thx all
On 21 Sep 2017 23:38, "Chris Aniszczyk"<EMAIL_ADDRESS>wrote:

@adriancole https://github.com/adriancole the project maturity levels
are here: https://github.com/cncf/toc/blob/master/process/
graduation_criteria.adoc
You can see the status of each CNCF project here:
https://github.com/cncf/toc#projects
No project has graduated yet, but we plan to go through a graduation
process for some of our projects before the end of this year. As part of
bootstrapping a foundation, it took awhile to come up with maturity levels
/ a process :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/uber/jaeger/issues/404#issuecomment-331195578, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD612XL6mboSHiAinXqoMSzt4Zxofatks5skoLfgaJpZM4PbsPE
.

Started https://bestpractices.coreinfrastructure.org/projects/1273

@jpkrohling Is it supposed to be one badge per git repo, or one for the whole project? If whole project, then possibly the URL for versioned repo should point to the org instead of the jaeger repo? And the programming languages should also cover the clients and js for the UI.

@caniszczyk can confirm, but I understand it is one for the whole project (nodejs can be seen as reference for this)

generally you can use one badge for the whole project
On Fri, Sep 22, 2017 at 7:13 AM, Juraci Paixão Kröhling <
<EMAIL_ADDRESS>wrote:

@caniszczyk https://github.com/caniszczyk can confirm, but I understand
it is one for the whole project (nodejs can be seen as reference for this)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaegertracing/jaeger/issues/404#issuecomment-331430270,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5IU-CeLm7yA1Y3btx5QHdP0Cl-XnHks5sk6RxgaJpZM4PbsPE
.

--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1<PHONE_NUMBER>

I just finished going over the items for this badge and I think we are in a good shape. The missing parts are mostly regarding security and I created issues on this repository to handle that.

Thanks!
On Fri, Oct 6, 2017 at 6:17 AM Juraci Paixão Kröhling <
<EMAIL_ADDRESS>wrote:

I just finished going over the items for this badge and I think we are in
a good shape. The missing parts are mostly regarding security and I created
issues on this repository to handle that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jaegertracing/jaeger/issues/404#issuecomment-334716367,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD5IchopSYEzPiQBWuWjE5mKlxp12mgks5spf5IgaJpZM4PbsPE
.

--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1<PHONE_NUMBER>

I'm closing this, as I believe this has been done already.


⚠ Msite has degraded performance

In 30849d9, Msite ($MSITE_URL) experienced degraded performance:

HTTP code: 200
Response time: 10306 ms

Resolved: Msite performance has improved in 1d65d83.


Document all auditing checks

Have a list of the auditing checks that get performed by the various commands.  Ideally move these all into audit.  Also explain what they mean better.

This exists now in https://github.com/duo-labs/cloudmapper/blob/master/audit_config.yaml


Config option to turn off demo route

It's a bit annoying to have an extra page available on your website that's more for admins to test. Not just for users.
And adding a new route redirecting to an error for only this route seems unnecessary when we have a nice option to just create a boolean in the config file. It seems like it SHOULD be a functionality already instead of having to manually add this yourself
If you could add a config variable named 'demo_page_on' or something alike which is standard on true, that'd be great
Using Route::get('/demo', fn() => abort(418)); works fine after loading your routes but it would be more clean to just have a config option

Agreed. This route was set as default enabled to provide a quick way to verify if installation is successful, for developers who are new to this package. But I agree that add a config or simply add some documentation will also do, since the demo page should not be accessed in production.


unnecessary heap allocations when rangeing over an empty array

What version of Go are you using (go version)?

$ go version
go version go1.14.2 linux/amd64

Does this issue reproduce with the latest release?
Yes (1.15beta1)
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/nickgregory/.cache/go-build"
GOENV="/home/nickgregory/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/nickgregory/dev/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.14"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.14/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build389543628=/tmp/go-build -gno-record-gcc-switches"

What did you do?

In an example like the following, thing is created on the heap even if the passed arr has length 0 and the loop body is never run:
package main

type foo struct {
	a uint64
	b uint64
}

var glob *foo

//go:noinline
func f(arr []foo) {
	for _, thing := range arr {
		glob = &thing
	}
}

func main() {
	f([]foo{})
}

This is contrived/minimalistic example (inlining is just to make the asm easier to read), but shows the point. This originally came up in a case where arr was generated in an event processing critical path, and this iteration over a (usually empty array) was creating millions of objects that escaped to heap (due to storage in another object, not assignment to a global), eating ~10% of run time.
What did you expect to see?
I would expect that the runtime.newobject call would only happen after the array is checked for length > 0.

This is more or less intentional. We want that allocation to happen outside the loop, so it only happens once even if the loop has many iterations. Of course, that's pessimistic if the loop has 0 iterations.
We could condition the allocation by checking the number if iterations first. Offhand I suspect this would be fairly hard to do, just because it requires some form of loop peeling. But it would be nice to handle this case.


The author wasn't showing up in published posts.

The author wasn't showing up in a published entry and "wok.Author..." was actually being dumped into the html.

Oh yeah, this. I have been meaning to make this better. Thanks for the help.

I am not going to merge this directly. I am going to leave the repr method as is, and add a unicode method, which is what Jinja is calling first anyways. Eventually I am going to make more advanced auto escaping feature part of wok, but for now this is a good stop gap.


Number of coins in output is wrong

Describe the bug
When deploying I have put MassaCoins(1) in the output it says that it deploy with<PHONE_NUMBER> MAS
To Reproduce
npm run deploy

Will be fixed here https://github.com/massalabs/massa-sc-toolkit/issues/123


Update tests

Improve install script
Simplify tests
Update docs

/!\ This one is important

Use correct .simg extension for Singularity images

PR checklist

[X] PR is made against dev branch
[X] This comment contains a description of changes (with reason)
[X] Ensure the test suite passes (./scripts/test.sh -p docker -t ALL).
[X] Documentation in docs is updated
[X] CHANGELOG.md is updated
[X] README.md is updated

Aaa, I am just updating the test.sh also :S Whatever, you actually made changes I wanted to ask you to do.
Could you please remove the Mutect1 reference?


Watson Assistant installation failure

fatal: [localhost]: FAILED! => {"msg": "The conditional check '_current_cp4d_cartridge.version < "4.0.5"' failed. The error was: error while evaluating conditional (_current_cp4d_cartridge.version < "4.0.5"): 'dict object' has no attribute 'version'\n\nThe error appears to be in '/cloud-pak-deployer/automation-roles/50-install-cloud-pak/cp4d/cp4d-cartridge-install/tasks/cp4d-prep-watson-assistant.yml': line 4, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n- block:\n  - name: Run preparation for Watson Assistant\n    ^ here\n"}

Fixed


Cap string length in binary channels

Use same logic as readBytes to cap max chunk length at  at NETWORK_BINARY_MAX_CONTENT_LENGTH.
This prevents OOME when invalid protocol traffic is directed at binary port (e.g. by security scanners).
Motivation:
In our deployment our SRE's have a security scanner that probes all open ports and shoves random data as well as well-known attacks down them. We noticed that we were getting OOM exceptions and traced the root cause to this. We have subsequently disabled the security scanner from running against these ports, but thought it prudent to add a sanity check to orientdb.
Checklist

[x] I have run the build using mvn clean package command

Happy to do some more work on this if you can point to where these checks might be applied - the failure is just a plain IOException (as is the bytes failure now), so not sure how they'd differentiate from other channel issues on the sender side.
The default limit works out to 16MB, which I thought was more than adequate for the use of strings in the binary protocols - essentially it's just a DOS limit, not a protocol limit.

Hi,
Yes this is conceptually correct, the issue is that is legit to produce a document with a field with 16MB of string, so you can let's say make a javascript function that store a document with that content, and the node that is creating that document will successfully send it to all the other nodes, causing the other nodes to reject is requests, as an IOException for all the retry it does, making the node think is isolated, and disconnect from the network, probably is worth to add some check also on the sender side, to make sure that it understand the message is sending is not correct and raise an exception that interrupt the request, avoiding the node to self isolate.
One way to try the case would be as a said just make a function that insert a document with that content, the execution of that function should produce a failure and not isolate the node.

Hi,
well yes the case was for writeString and readString anyway merged and added the check also in writeString should be all sorted.
Regards

Yeah, my bad - too many branches and patches going on.
Thanks for the extra fix and merge.


An error occurred

When in use, the following error message is displayed.
An error occurred
You can check the console for more details.
(Ctrl+Shift +J)

I have the same problem.
the server answers 403, chatgpt has blocked your request. Maybe chatgpt has blacklisted my account and your account ?

same here.

SAME right now

Hi, thanks for the feedback!
A patched version that fixes this problem has already been submitted for a review. It just takes a little bit longer than expected to be reviewed and published. Hopefully, it should become available in the coming days.
You can install this version manually in the meantime. See the instructions on how to do that: https://github.com/qunash/chatgpt-advanced/tree/dev#manual-installation
You can also join our Discord server to get notified about the recent updates and announcements: https://discord.gg/hjvAtVNtHa


How to run the documentation in docs folder?

I'm submitting a ...
[X] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Question

What is the expected behavior?
to be able to run the docs folder and see the documentation like https://akveo.github.io/ng2-admin/articles/001-getting-started/

What is the motivation / use case for changing the behavior?
for creating docs for our projects that are based on this admin template

How to be able to run the docs like here: https://akveo.github.io/ng2-admin/articles/001-getting-started/
I have updated my projects and updates the docs section to match my project but how can I make it accessible like your docs page?
I see some jade templates but I'm not aware to how render them
any pointer or tutorial is greatly appreciated.
thanks.

I have finally run the docs properly.
For those who want to run the docs and generate a static site, what you need to do is the following:

install wintersmith
install a wintersmith plugin called wintersmith-sass
edit the file config.json in the plugins section form wintersmith-sassy to wintersmith-sass
now you can preview and generate the docs through commands wintersmith preview and wintersmith build

Hope this helps those who wanted to customize their own docs.


Setup vault client

Towards: https://github.com/giantswarm/giantswarm/issues/16355
Part of: https://github.com/giantswarm/capi-migration/pull/1

Tested, works.


fix(): reduce minimum tls version for control plane

Description: Envoy proxy fails if tlsMaxProtocolVersion is set to TLSv1_2 because the minimum tls version for control plane was set to TLSv1_3

Testing done:

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[x]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

Resolves #5282

The main branch has drifted pretty far from our release branches. You may want to make your PR based on release 1.2 branch instead of main

@keithmattix To maintain our previous workflow should the changes including e2e tests first be made on main and then backported to v1.2?

Closing in favor of #5292


Automated cherry pick of #8672: scheduler: ignore non running guests only exclude ready status

Cherry pick of #8672 on release/3.4.
#8672: scheduler: ignore non running guests only exclude ready status

Codecov Report

Merging #8674 into release/3.4 will decrease coverage by 2.63%.
The diff coverage is 3.24%.

@@              Coverage Diff               @@
##           release/3.4   #8674      +/-   ##
==============================================
- Coverage         6.22%   3.58%   -2.64%
==============================================
  Files              759     304     -455
  Lines           117145   62478   -54667
==============================================
- Hits              7289    2241    -5048
+ Misses          109197   60082   -49115
+ Partials           659     155     -504

Flag
Coverage Δ

aFlag
3.58% <3.24%> (-2.64%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/events.go
0.00% <0.00%> (ø)

pkg/cloudcommon/notifyclient/notify.go
1.84% <0.00%> (-0.40%)
:arrow_down:

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.73% <0.00%> (-0.08%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/dbinstances.go
0.77% <0.00%> (-0.02%)
:arrow_down:

... and 448 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55022a...827be91. Read the comment docs.


fix(sql-execute): anonymous block execution module adapted to oracle11g

What type of PR is this?
type-bug
module-sql-execution
module-db-browser
What this PR does / why we need it:

Anonymous block execution module adapted to oracle11g

rename OBOracleDBMSOutputInitializer to OracleDBMSOutputInitializer

Fixed the problem of error reporting when viewing packages without package body

Which issue(s) this PR fixes:

Fixes #1729
Fixes #1754
Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

lgtm


Add name headers for all participants

Ideas for your contributions
list headers, hyperlinks examples here
Stefanie
Your first contrib? Fix this tpyo
Name

closed as completed


Can't select keys to import when manually importing

dougdeperry:

When importing keys, the UI appears to give you the ability to choose individual keys to import, but when you do this and attempt to import, a popup warns you to verify all keys and will not let you continue. Clicking “Select All” (which doesn't really look like a hyperlink) selects all keys and then the import will work successfully.

This seems fixable by changing goog.array.every to goog.array.some in dialogs.ImportConfirmation.prototype.invokeCallback.

Actually when I do that, it still imports every key even though I only selected some.


How to custom multipart boundary?

when i upload a file to server,i want to  custom multipart boundary,how can i do ? thanks!

Hey @chiseller, currently it's not possible to do, however I just created an issue that links to this one and to the other one we had recently as well and we might be able to get this one implemented soon!

hey @sunshinejr  thanks for you response!


Switch to turn off population frequency plot

We can now view population frequencies of a mutation by clicking on a data point in the main mutations view. For this, we're computing a numpy array of shape num_nodes x num_populations. With large number of populations (e.g. >200 in  the Unified Genealogies dataset) this array grows extremely big and tsqc runs out of memory, getting killed. We should make frequency plots optional, which users can choose to switch on only when sufficient memory is available.

Can we calculate these on-the-fly instead?

Impractical at chromosome scale I'm afraid. Possible for a small window, though?

Don't you just need to do it for the single mutation that's been clicked on?

Yes, it's only for a the single mutation that's clicked on. We considered on-the-fly calculations, but I think one of the reasons we thought it would be easier to pass the whole set of arrays to the browser, was so interactivity is smoother for larger datasets.
The reason for creating this issue was that a big machine was needed everytime we served the dataset, even when we care about the population frequencies. Now that we have the preprocess logic, perhaps this issue is not as relevant? I'll do a couple of checks and confirm.

If we're doing it for a single mutation then maybe it is feasible. You'd have to do this:
tree = ts.at(mutation_position)
nodes =  tree.preorder(mutation_node) # numpy array
subtree_population = ts.nodes_population[nodes]
# return a data frame of the counts

Moving this to MVP+1 as it isn't a showstopper and we have a good solution.


SNS & Beanstalk - Allow Beanstalk to consume events from SNS

Create and then confirm(?) SNS subscriptions.

I'd like to talk to you about your use case so I can make sure I understand what you're trying to do, but I think this is already implemented and available through your Beanstalk having a service dependency on the SNS topic instead of a service event.
SNS won't send events to Beanstalk the service itself, but it can send to the HTTP endpoint in the Beanstalk app. When you consume SNS as a service dependency in Beanstalk, you'll have permissions to subscribe to the topic, as well as post to it.
There may still be value in making Beanstalk an event "consumer" for SNS and just setting up an HTTP subscription for you if people want to do it in that way. Let's talk a bit and see what we come up with.

At the time, I didn't realize listing an SNS topic as a beanstalk dependency gave the appropriate permissions to subscribe at will.
I think I interpreted dependencies as things the resource was allowed to access (essentially, outbound traffic) and event_consumers as things that would automatically get some sort of notification, since that's how those properties work with Lambdas.
I don't really see a need for this request anymore.


Update docs to reflect OpenSSL version requirements

resolves #1907

Suggested commit message:
OpenSSL 1.0.2 or later is required

Suggested commit message:
OpenSSL 1.0.2 or later is required

fixed in Version 292 PR


Dev timeseries json

added two keys in the time series JSON object to specify the class of the time and values column. If it's an instance of "Number" (e.g. integers, doubles), it will output "Number", otherwise it will write whatever the original value's class is.
Michael will support a selection of classes and if his code detects any other classes, it should throw an error. For the time column, I assume the code will support either "Instant" or "Number". The list of supported classes will probably grow in the future.
@markushofmeister this is mostly FYI for you

added two keys in the time series JSON object to specify the class of the time and values column. If it's an instance of "Number" (e.g. integers, doubles), it will output "Number", otherwise it will write whatever the original value's class is.
Michael will support a selection of classes and if his code detects any other classes, it should throw an error. For the time column, I assume the code will support either "Instant" or "Number". The list of supported classes will probably grow in the future.
@markushofmeister this is mostly FYI for you

I understand the approach; however, it is not fully clear to me how this information will be used by Michael's code (I assume that's the DTVF) and how we make sure that this implementation is "in sync" with the requirements of the updated DTVF?


Uncaught TypeError: cannot read properties of undefined when using GridHelper.addToolbarFooter

I'm using GridHelpers 1.1.1. and Vaadin 24.1.4.
When adding a footer toolbar (HorizontalLayout), I get the above message. The toolbar is shown and working ok, though.
The message:

I've tried to narrow it down, however that did not succeed. The only thing I know is that when I remove the GridHelper.addToolbarFooter call the error does not happen.

Hello. Please try adding com.flowingcode to the whitelisted packages.
By default, Vaadin Flow only includes com/vaadin/flow/component to be always scanned for UI components and views. For this reason, the add-on might need to be whitelisted in order to display correctly.
To do so, just add com.flowingcode to the vaadin.whitelisted-packages property in src/main/resources/application.properties, like:
vaadin.whitelisted-packages = com.vaadin,org.vaadin,dev.hilla,com.flowingcode
More information on Spring whitelisted configuration here.

Yes, that works! Thanks.


Reduce the number of calls to the docker API when using project.up()

don't inspect the container immediately after creating it. Instead use the values passed to create for the name and Id
add a new fresh_start kwarg to project.up() which doesn't try to restart containers, and assumes the containers it will be creating don't already exist. This allows us to skip the listing of containers entirely.
with fresh_start assume that all containers will be named with a _1 suffix so we also don't have to list containers to create links to them.

cc @osarood

Test run is green here: https://app.wercker.com/#build/54fb73d0dbc0ae162a02fb2c
Some more background about this change, our "main test suite sandbox" currently makes ~23 calls to "list all containers", which is the slowest docker API call. This change removes all of those calls. After this change our sandbox will only issue 1 pull, create, start, and inspect per container.


Take over sdl2-ttf from @rongcuid and add a few other packages

See https://github.com/haskell-game/sdl2-ttf/issues/11

Got stackage-curator: AesonException "Error in $.packages['Rongcui Dong<EMAIL_ADDRESS>@rongcuid']: expected Vector a, encountered Null", so I have to amend it...

Done.

Thank you.


Doesn't work

I follow the instructions in the readme, as well as have treesitter installed, then I try renaming tags and nothing happens.

Do you have treesitter parser for html installed?

Same here downloaded it using Packer, show up on PackerSync as properly installed. Added the lines in my treesitter.lua file yet it does not work on any html files I open.

Unfortunately, the plugin does not work for me either. I use NvChad, so the lazy.nvim, and the following configuration for treesitter and nvim-ts-autoclose:
{
   "nvim-treesitter/nvim-treesitter",
   opts = {
     ensure_installed = {
       -- defaults
       "vim",
       "lua",
       "markdown",

       "html",
       "css",
       "javascript",
       "typescript",
       "json",
       "c_sharp",
       "sql",
       "yaml",
       "xml",
       "tsx",
     },
     autotag = {
       enable = true
     },
   },
 },
 {
   "windwp/nvim-ts-autotag",
   dependencies = "nvim-treesitter/nvim-treesitter",
   event = "VeryLazy",
   config = function()
     require("nvim-ts-autotag").setup()
   end,
 },

Especially important to me would be the automatic closing of xml tags.

Having a similar issue installing, also with lazy.nvim

Works for me in html and tsx/jsx files.
Replacing tag name works with quirks....

Works for me in html and tsx/jsx files.
Renmaing tag back from <xyz> to <div> works with quirks....


The size of tensor a (352768) must match the size of tensor b (352800) at non-singleton dimension 1

Hi, there is a problem with the BS-Roformer-De-Reverb model (deverb_bs_roformer_8_384dim_10depth.ckpt) in version 0.21.0.
When I try to split an audio I get this error:
2024-09-18 03:14:22.947 - INFO - cli - Separator version 0.21.0 beginning with input file: /content/temp/5 Seconds of Summer - Youngblood (Official Video).wav
2024-09-18 03:14:22.948 - INFO - separator - Separator version 0.21.0 instantiating with output_dir: /content/drive/MyDrive/Vocales, output_format: wav
2024-09-18 03:14:22.957 - INFO - separator - Operating System: Linux #1 SMP PREEMPT_DYNAMIC Thu Jun 27 21:05:47 UTC 2024
2024-09-18 03:14:22.959 - INFO - separator - System: Linux Node: 603cb85998bb Release: 6.1.85+ Machine: x86_64 Proc: x86_64
2024-09-18 03:14:22.959 - INFO - separator - Python Version: 3.10.12
2024-09-18 03:14:22.959 - INFO - separator - PyTorch Version: 2.4.0+cu121
2024-09-18 03:14:23.045 - INFO - separator - FFmpeg installed: ffmpeg version 4.4.2-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2021 the FFmpeg developers
2024-09-18 03:14:23.047 - INFO - separator - ONNX Runtime GPU package installed with version: 1.19.2
2024-09-18 03:14:23.065 - INFO - separator - CUDA is available in Torch, setting Torch device to CUDA
2024-09-18 03:14:23.065 - INFO - separator - ONNXruntime has CUDAExecutionProvider available, enabling acceleration
2024-09-18 03:14:23.065 - INFO - separator - Loading model deverb_bs_roformer_8_384dim_10depth.ckpt...
2024-09-18 03:14:25.929 - INFO - mdxc_separator - MDXC Separator initialisation complete
2024-09-18 03:14:25.929 - INFO - separator - Load model duration: 00:00:02
2024-09-18 03:14:25.929 - INFO - separator - Starting separation process for audio_file_path: /content/temp/5 Seconds of Summer - Youngblood (Official Video).wav
  0% 0/115 [00:01<?, ?it/s]
Traceback (most recent call last):
  File "/usr/local/bin/audio-separator", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/audio_separator/utils/cli.py", line 194, in main
    output_files = separator.separate(args.audio_file)
  File "/usr/local/lib/python3.10/dist-packages/audio_separator/separator/separator.py", line 735, in separate
    output_files = self.model_instance.separate(audio_file_path)
  File "/usr/local/lib/python3.10/dist-packages/audio_separator/separator/architectures/mdxc_separator.py", line 137, in separate
    source = self.demix(mix=mix)
  File "/usr/local/lib/python3.10/dist-packages/audio_separator/separator/architectures/mdxc_separator.py", line 261, in demix
    result = self.overlap_add(result, x, window, i, length)
  File "/usr/local/lib/python3.10/dist-packages/audio_separator/separator/architectures/mdxc_separator.py", line 195, in overlap_add
    result[..., start : start + length] += x[..., :length] * weights[:length]
RuntimeError: The size of tensor a (352768) must match the size of tensor b (352800) at non-singleton dimension 1

This error only occurs with that specific model, I tried some files and different overlaps and the error persists.

Yeah I'm aware, thanks for the reminder though!
Will look into it at some point unless someone beats me to it and raises a PR with a fix ☺

It might be worth reducing the dim_t parameter in the configuration files.
I compared the Roformer model configurations from other repositories, and everywhere this parameter is set to 256. However, in your configuration files, it is set to 801. Additionally, some configurations differ significantly from what I found.

Yeah, I wasn't able to get this model working as easily as the others just by modifying the config - but if you manage to get it working please raise a PR 😃

By the way, I've run into this error too, and turning on the override_model_segment_size parameter did the trick for me. Give it a shot; it might work for you too.

@beveradb
I found a way to make this model work:
You have to delete linear_transformer_depth: 0 (line 17) from the config file and change stft_hop_length: 512 to stft_hop_length: 441 (line 89).
So just updating the configuration file from here should work.
Tested on cloud and locally several times
Reference: https://github.com/ZFTurbo/Music-Source-Separation-Training/issues/1#issuecomment-2229279531

Nice one, thanks for the pointer to the fix @Eddycrack864  - I've updated that config file in this repo now and have just tested successfully, so that's it fixed! 🎉


[UI] Add Toc in Sidebar

Summary

Toc enables the viewport center.
Will add more follow-up UI tuning in future

Test

Instead of showing (full) IDs, some options (ordered by priority, high to low):

show pod/scope title (.name)
show the title/first-line of rich text content
show the function defined in code pod (I'll populate the parse result somewhere)
show a shortened ID (e.g., first 8 characters)

Instead of showing (full) IDs, some options (ordered by priority, high to low):

show pod/scope title (.name)
show the title/first-line of rich text content
show the function defined in code pod (I'll populate the parse result somewhere)
show a shortened ID (e.g., first 8 characters)

1d71993 addresses comments.

show a shortened ID (e.g., first 8 characters)

1d71993 addresses comments.

Nice, thanks!


[WIP] Readout mitigator classes

Summary
#6484
Add Readout Mitigator classes bases on the current code in ignis.
Details and comments

[x] BaseReadoutMitgator
[x] CompleteReadoutMitigator
[ ] TensoredReadoutMitigator
[x] Update qiskit.result classes (Counts, ProbDitribution, QuasiDistribution)
[ ] Add tests

Here is the basic way M3 works:
# Grab a mitigator instance and target a given backend
mit = mthree.M3Mitigation(backend)

# calibrate over the desired number of qubits (can be renamed to something more generic)
mit.tensored_cals_from_system(qubits)

# apply correction
quasi_probs = mit.apply_correction(real_counts, qubits=measured_qubits)

The M3 code is up here #6748.  So thoughts on this PR:
I think the mitigation classes should be simpler.  Namely, the bare minimum one needs is:
mit = Mitigator(backend)
mit.calibrations_from_system(qubits)
mitigated_values = mit.apply_correction(raw_counts, qubits, **kwargs)

The mitigator itself should in charge of executing the calibration circuits because at some point the backends should just compute this info on a regular basis and cache it at which point calibrations_from_system might just be an API call, or another method like calibrations_from_remote may exist.
Things like plotting the A-matrix should not be here, just simply return an array for the given matrix.
Returning the mitigation matrix should not be in the base class as computing it is optional depending on the solution method.
I am also not a big fan of having expectation_value attached to the mitigator as it is not really a property of the mitigator but rather of the return values and additional info attached to them.  I do however understand that the CTMP works this was, but, in my opinion, that should be refactored to return quasi-probs like the others do.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

202 of 232 (87.07%)  changed or added relevant lines in 6 files are covered.
202 unchanged lines in 24 files lost coverage.
Overall coverage increased (+0.2%) to 82.515%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/result/counts.py
4
6
66.67%

qiskit/mitigation/utils.py
53
57
92.98%

qiskit/mitigation/complete_readout_mitigator.py
57
68
83.82%

qiskit/mitigation/tensored_readout_mitigator.py
75
88
85.23%

Files with Coverage Reduction
New Missed Lines
%

qiskit/qasm/node/if_.py
1
85.71%

qiskit/qasm/node/reset.py
1
85.71%

qiskit/qasm/node/binaryoperator.py
2
81.25%

qiskit/qasm/node/creg.py
2
81.25%

qiskit/qasm/node/indexedid.py
2
86.67%

qiskit/qasm/node/qreg.py
2
81.25%

qiskit/qasm/node/unaryoperator.py
2
81.25%

qiskit/transpiler/layout.py
3
93.55%

qiskit/algorithms/minimum_eigen_solvers/qaoa.py
4
89.19%

qiskit/extensions/quantum_initializer/squ.py
4
89.66%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
49820

Relevant Lines:
60377

💛  - Coveralls

@chriseclectic - thank you for the detailed review! @gadial and I fixed the code accordingly, but have not changed the framework of the tests yet. Perhaps it's worth to review and merge this PR now, to meet the deadline for the 0.19 release and open a separate PR for the tests?


Pressing START GAME button speeds up the game.

Pressing the START GAME button after the game has been started will speed the game up. Start button should at first start the game and then on second or more attempts reset the progress. PAUSE GAME button should act both as pause and continue without having to press START GAME to continue.

Added if clause to stop and clear game after pressing start again. Added event to start button to clear score, pause button has if clause to check if game is already paused or not.


missing methods for gio::File

Missing:

[ ] replace_contents_bytes_async
[ ] copy_async
[ ] copy_async_future
[ ] load_partial_contents_async
[ ] load_partial_contents_async_future
[ ] measure_disk_usage_async
[ ] measure_disk_usage_async_future
[ ] query_settable_attributes
[ ] query_writable_namespaces
[ ] set_attribute

@A6GibKm do  you want to contribute some of those for the next release? :)

I am a bit low on time, so I dont think ill be able to.

[ ] set_attribute

See https://github.com/gtk-rs/gtk-rs-core/issues/40 , not handling that one here.

Note that we have lots of type-specific set_attribute_XXX() functions.

* [ ] load_partial_contents_async_future

This one has a processing model that makes not much sense for futures.

@A6GibKm See https://github.com/gtk-rs/gtk-rs-core/pull/319 . Let me know if anything else is still missing for you and if all that behaves correctly.

@A6GibKm See #319 . Let me know if anything else is still missing for you and if all that behaves correctly.

Certainly works for me, I haven't tested it yet (as the places where I need it use libadwaita-rs which cannot be build with master). Just note that copy has an optional progress callback

and copy_async's callback is not optional (can be NULL according to https://docs.gtk.org/gio/method.File.copy_async.html)

Please create a separate issue for that


Binary ops

Support for binary operation

Thanks for doing this Yannis. As we discussed, we can do a more proper refactoring to separate the interfaces when we expose more of the commands.


Expose the checks used by the check container and check operator actions in their help outputs

It may be useful for the user to know exactly what tests are going to be executed when they call container/operator check commands.

/assign rocrisp

Assign over to @rocrisp, thanks!
Some notes on what I'm expecting here - I'm thinking the easiest thing to do is to make that list available in each command's --help outputs. If you think this should live elsewhere, let us know!
Something like this might be the end result, where CheckOne and CheckTwo represent implemented checks for the requested policy (container or `operator):
$ ./preflight check container --help
This command will run the Certification checks for a container image.

The checks that will be executed are the following:
     CheckOne
     CheckTwo

Usage:
  preflight check container <url to container image> [flags]

Flags:
  -h, --help   help for container

You'll likely have to change these two files to add the additional documentation to the help command.

https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/cmd/check_container.go
https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/cmd/check_operator.go

The check lists for both the container and operator subcommands are accessible using these accessor methods

https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/certification/engine/engine.go#L130-L136

Let me know if I can help with anything! 👍


Wrangle to support for Pandas Reindex

While our pandas wrangle supports lots of parameterized functions, I believe that custom functions are required to manipulate the index.  Can we create a special pandas function(s) that allows doing these types of thing (set_, reset_, reindex, transpose...)  without custom functions?  Here is the code from the Bosch eComm recipe as an example:
    """
    Re-index and reorient dataframe
    """
    df = _wrangles.recipe.run(
        recipe="""
        wrangles:
          - pandas.set_index:
              parameters:
                keys: ${NEW_INDEX}
          - pandas.reindex:
              parameters:
                columns: ${COLUMNS}
                fill_value: ''
          - pandas.transpose: {}
          - pandas.reset_index:
              parameters:
                level: 0
          - rename:
              index: ${NEW_INDEX}
        """,
        variables={
            "NEW_INDEX": new_index,
            "COLUMNS": columns,
        },
        dataframe=df
    )

    return df

Transpose and reindex are available as 'native' wrangles. The others are available as pandas passthrough calls.


Update Github actions and quickstart for 2.0

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Change Log

Update GitHub actions to also target 2.0
Add a "Quickstart 2.0" GitHub action for 2.0
Remove unused "Quickstart" action
Update quick start guide to target 2.0
Remove unused Release action

Does this affect the toolchain?

NO

Note: Github detects the deletion of quickstart.yml and the addition of quickstart_2.0.yml as a rename. Quickstart_2.0.yml is just a small modifcation to quickstart_1.0.


PartyKit integration on drop page

Let's party a bit

Integration
https://www.partykit.io/
https://github.com/partykit/partykit
https://docs.partykit.io/
Design

default cursors, like from the example with flags

the cursor will have random colors - not sure if its default behavior or not?
instead of flag, it shows dot spent in small container - please round to the whole number

figma link: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=8127-21723&mode=design&t=W4cp7VefogMZZOIv-11
Notes

cursor will have 20% opacity over the cards section
this:

Hey, @kodadot/internal-dev, any taker on this? It should be one-liner and quick! :)

Need SSR first?

It should be one-liner and quick! :)

Need SSR first?

why you need SSR for this?

Hey everyone, this issue is not limited to internal team, who wants to grab it?

👋


add hop command, add some websites and fix duplicates

this is awesome, i love the hop command, tysm!


Error -

i get this error in console (like if 10 players joining i get this error for 2-3 of them)
Error:
https://hastebin.com/uqalulebox.md

Duplicate of #264


[snapshot] enable Snapshot to take Apple Watch 44mm screenshots (#1709)

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass

🚨 I have two failing RSpec tests, on the clean master branch - see notes below

[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
🔑 This PR adds Apple Watch support to Snapshot, as requested in some discussion threads (1, 2) and one old issue which was closed because UIAutomation was not supported on Apple Watch at the time.
Description

changes test_command_generator.rb to identify watchOS destination devices

new test in ``test_command_generator_spec.rb`

changes test_command_generator.rb to identify when watchOS is the only type of device in the list of devices, or when it's mixed with other device types

new test in ``test_command_generator_spec.rb`

changes report_generator.rb include Apple Watch Series 5 - 44mm and Apple Watch Series 6 - 44mm in the device mappings

no evidence of RSpec tests for report_generator.rb 😢

change fixLandscapeOrientation function in SnapshotHelper.swift to ignore UIKit-specific code when building for Apple Watch

Notes

I've had two failing RSpec tests when running on my local machine

these fail on the master branch with no local changes
the failures are for a part of Fastlane that I haven't touched - so I'm confident that I haven't caused a regression
details in this discussion

This PR only adds support for 44mm Apple Watch, because AppStoreConnect only allows screenshots for that size display
SnapshotHelperVersion not updated - I don't think this is my decision to make 😕

Testing Steps
Tested with this Snapfile:
devices([
  'Apple Watch Series 6 - 44mm'
])
ios_version('7.4')
erase_simulator(false)
test_target_name('watchOS')
scheme('watchOS')
number_of_retries(0)
concurrent_simulators(false)

languages([
  "en-GB",
])

Note: test_target_name and scheme parameters are for my "watchOS app" target, not my "watchOS screenshot tests" target. I honestly don't know why this is necessary - maybe just a problem with the setup of my test Xcode project?

@googlebot I signed it!

@googlebot I consent.

@googlebot I signed it!

how do I setup my UI tests to run for watchOS? 😊

add new target “Watch App for iOS App”
add new target “watchOS UI Testing Bundle”, and select the Watch App target as “Target to be Tested”
edit the new “watchOS” scheme: add the new UITest bundle to this scheme’s test action (I don’t know if this is correct)
copy the snapshot helper into the project, and add it to the WatchOS UITest target
change Snapfile:

change the devices array to contain only Apple Watch Series 6 - 44mm
test_target_name is the Watch App target
scheme is the Watch App target (I don’t know if this is correct)

Does this only work with a watch app that as an iOS app? Or does this also work with a standalone watch app?

I’ve only tried with “Watch App for iOS App” - but I don’t see why it wouldn’t work standalone.
Note: the status-bar override doesn’t work for watchOS simulator.

@mflint Dooohhh... I need Xcode 12.5 and I only have Xcode 12.4 🤦♂ Downloading that now!


[PL-43780] [CDS-87415] Delegate HF 81808 release notes

Delegate HF 81808 release notes
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://658af05530feeeb0cb9258fb--harness-developer.netlify.app


CMSMap : File cmsmap.py

Checkboxes

[x] Updated fsociety
[x] Issue does not already exist
[ ] fsociety issue, not a tool issue

Traceback (most recent call last):
  File "/var/www/Infosec/fsociety/tools/CMSmap/cmsmap.py", line 2033, in <module>
    scanner.ForceCMSType()
  File "/var/www/Infosec/fsociety/tools/CMSmap/cmsmap.py", line 194, in ForceCMSType
    WPScan(self.url,self.threads).WPrun()
  File "/var/www/Infosec/fsociety/tools/CMSmap/cmsmap.py", line 357, in WPrun
    bruter.WPXMLRPC_brute()
  File "/var/www/Infosec/fsociety/tools/CMSmap/cmsmap.py", line 1274, in WPXMLRPC_brute
    htmltext = opener.open(req).read()
  File "/usr/lib/python2.7/urllib2.py", line 421, in open
    protocol = req.get_type()
  File "/usr/lib/python2.7/urllib2.py", line 283, in get_type
    raise ValueError, "unknown url type: %s" % self.__original
ValueError: unknown url type: example.fr/xmlrpc.php

Ubuntu 17.10

See about redownloading CMSmap. the path is: '.../tools/CMSmap'


"exec format error" on arm64/armv7 (Raspberry Pi 3B+)

I keep getting
db_1   | standard_init_linux.go:211: exec user process caused "exec format error"
followed by
app_1  | [6/3/2020] [7:21:29 PM] [Global   ] › ✖  error     getaddrinfo ENOTFOUND db
(obviously, since db just crashed) which then leads to Bad Gateway errors when trying to login into the WebUI.
Target architecture: armv7l, armv7 as well as aarch64/arm64.
Tested on: Raspbian Lite, Ubuntu 20.04 Server 64bit and HypriotOS/armv7 (all of them were clean installs)
This is my first time running Nginx Proxy Manager on my RPI3 but I've been using on my x86_64 server just fine.
I'm not quite sure wether docker or s6 isn't detecting my archtitecture properly and thus pulling the wrong images. I seem, however, unable to specify the target arch myself (i.e.
 image: 'jc21/nginx-proxy-manager:latest-armv7'

would be helpful (but again - I can't seem to do that..)
I suppose this is a bug since the guide indicates that no special setup needs to be done for ARM devices

'The docker images are a manifest of all the architecture docker builds supported, so this means you don't have to worry about doing anything special and you can follow the common instructions above.'
Source: Nginx Proxy Manager Setup Page

Edit: Spelling.

This isn't really a fix itself, but as a workaround for anyone else encountering this issue:
Replace
image: jc21/mariadb-aria:10.4
with
image: yobasystems/alpine-mariadb:latest
and it should work.
Please either update the guide or fix the jc21/mariadb-aria image.

Closing as a duplicate of https://github.com/jc21/nginx-proxy-manager/issues/212


Can't add image with JPG

Just the title says, I can't add picture with JPG format, it appears the error "not a PNG buffer", is JPG format supported or not?
Thanks.

Please reopen if this problem can be pinpointed to a bug in gofpdf rather than just an invalid image.


feat: add payout service

Type of Change

[ ] Bugfix
[x] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[x] Documentation
[ ] CI/CD

Description

This change introduces a new endpoint for payouts functionality.

Additional Changes

[x] This PR modifies the API contract
[x] This PR modifies the database schema
[x] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?
Changes were tested locally using the Postman collection.
Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[x] I added unit tests for my changes where possible
[x] I added a CHANGELOG entry if applicable

This PR has a lot of issues that are unaddressed. I was fixing conflicts on my PR and had to create template code for new connector which had threw 37+ errors.


Save model in ubj as the default.

Related https://github.com/dmlc/xgboost/issues/7547 .

Set default to UBJ in C.
Set default to UBJ in JVM.
Extract Python serialization tests.
Remove changing verbosity in tests so that I can capture warnings.
Cleanup tests to reduce the amount of warnings caused by the change of default.

@wbo4958 Would be great if you could help take a look when you are available.

Otherwise, LGTM.

Thank you for sharing!

Still need to refresh the document, will open another PR once the R package is sorted out.


chore(Placeholder): use React.forwardRef()

Similarly to #4234, adds native ref forwarding to Placeholder and all subcomponents.
Fixes isConformant() to use ReactIs.isValidElementType instead of _.isFunction as components created by React.forwardRef() are not functions.

Codecov Report

Merging #4236 (6981f32) into next-v3 (1861110) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           next-v3    #4236   +/-   ##
========================================
  Coverage    99.75%   99.75%
========================================
  Files          180      180
  Lines         3244     3254   +10
========================================
+ Hits          3236     3246   +10
  Misses           8        8

Impacted Files
Coverage Δ

src/elements/Placeholder/Placeholder.js
100.00% <100.00%> (ø)

src/elements/Placeholder/PlaceholderHeader.js
100.00% <100.00%> (ø)

src/elements/Placeholder/PlaceholderImage.js
100.00% <100.00%> (ø)

src/elements/Placeholder/PlaceholderLine.js
100.00% <100.00%> (ø)

src/elements/Placeholder/PlaceholderParagraph.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1861110...6981f32. Read the comment docs.


Update functions for stdlib 9.x

This breaks compatibility with earlier stdlib versions.
Will require major release. @Phil-Friderici, do we have any other major breaking changes we want to include?

Sure that you have to use stdlib::ensure_packages ? I have used ensure_packages only successfully with stdlib 9.4.1.

From their REFERENCE.md file. I suspect there is no real hurry to get it merged though.
[ensure_packages](https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#ensure_packages): DEPRECATED. Use the namespaced function [stdlib::ensure_packages](https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/REFERENCE.md#stdlibensure_packages) instead.


Add website with documentation

Using Sphinx and potentially using:
https://marketplace.visualstudio.com/items?itemName=njpwerner.autodocstring

Added.


Is pytorch1.7 1.8 compatible?

Look forword to your reply.

It should be compatible, but not all models are tested.

Feel free to reopen the issue if there is any question.


Fix CBO broadcast join reordering

Allows reordering (and broadcast join distribution) when the original build-side estimated size is above JOIN_MAX_BROADCAST_TABLE_SIZE.

Otherwise, CBO will not choose replicated join distribution when the smaller table happens to be on the left hand-side of the join.

@rzeyde-varada CI looks related

Otherwise, CBO will not choose replicated join distribution when the smaller table happens to be on the left hand-side of the join.

Why would CBO want broadcast join on larger table from the right?

Otherwise, CBO will not choose replicated join distribution when the smaller table happens to be on the left hand-side of the join.

Why would CBO want broadcast join on larger table from the right?

Consider the following query:
SELECT count() FROM item, store_sales WHERE i_item_sk = ss_item_sk

It would be better to flip the join order (i.e. use item as build-side and store_sales as probe-side) since item is smaller than store_sales.
After we flip the join order, it is probably better to use broadcast join, since item fits into RAM (i.e. its estimated size is smaller than JOIN_MAX_BROADCAST_TABLE_SIZE), even if store_sales is very large.
Current code doesn't try to apply broadcast join in this case, since store_sales (the original build-side) doesn't fit into RAM.

@rzeyde-varada CI looks related

Yes, some of the query plans are modified - partitioned join being replaced by replicated join.
If it's fine by you, I can update the expected plans to match the new ones.

nice catch! Please fix tests. Let me run benchmarks on this change

Tests are fixed - squashed the commits into a single one.

Benchmark results. Nice improvement on tpcds/q82, tpcds/q43, tpcds/q54, tpch/q08
Thanks!
Benchmarks comparison-cbo_fix.pdf

What about tpcds/q47?


Problems with foreign characters in urls

Installed and ran blc on http://poetikon.no. Getting a HTTP_404  on a link containing a Norwegian special character "ø". http://poetikon.no/category/gjør-det-selv/   (http://bit.ly/2eRQv52 if the urlencoded url fails).
This url works when visiting in a browser.

Try using the v0.8.0 branch

Unfortunately this branch fails for me:
$ node node_modules/broken-link-checker/bin/blc -fvr http://beta.grossweber.com/test.html
Getting links from: http://beta.grossweber.com/test.html
(node:11168) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'length' of undefined
(node:11168) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

For me it fails on "ą" and gives false 400 error code - other link checkers are not complaining about a working link.
I scanned readme and I failed to see method to check just a single link (to futher debug whatever my guess that I triggered this error is correct).
For reference, full link is https://matkoniecz.github.io/bicycle_map_of_Krakow/Przegląd tras rowerowych.html and at this time it is working (note this site is experimental and url may disappear soon).
wget https://matkoniecz.github.io/bicycle_map_of_Krakow/Przegląd%20tras%20rowerowych.html > test.html
--2017-01-31 19:47:13--  https://matkoniecz.github.io/bicycle_map_of_Krakow/Przegl%C4%85d%20tras%20rowerowych.html
Resolving matkoniecz.github.io (matkoniecz.github.io)... <IP_ADDRESS>
Connecting to matkoniecz.github.io (matkoniecz.github.io)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1648 (1,6K) [text/html]
Saving to: ‘Przegl\304%85d tras rowerowych.html’

100%[===================================================================================================================================================================================================>] 1.648       --.-K/s   in 0s

2017-01-31 19:47:14 (212 MB/s) - ‘Przegl\304%85d tras rowerowych.html’ saved [1648/1648]

A tool that only checks a single link is pretty useless. But if you must, you can use UrlChecker.prototype.enqueue. v0.7.x of this library uses Node's url.parse(), which does not follow the new URL specification. v0.8.0 does, but is not yet released.

A tool that only checks a single link is pretty useless.

Well, for debygging what is causing false results it would be quite useful.

For which there is probably more than one, hence a tool for multiple. Single URLs are still possible with that API.

I think that this is fixed (on master branch).


Reduce cognitive complexity

PR Checklist

[x] Have you followed the guidelines in CONTRIBUTING.md?
[x] Have you got 100% test coverage on new code?
[x] Have you updated the prose documentation?
[x] Have you updated the reference documentation?

This PR reduces the cognitive complexity as flagged by SonarCloud (see #203) in the following modules:

typing.py
router.py
parsers.py
kwargs.py

Are you on our discord? If so - shoot me a line and let's have a chat.

invite to the org was sent to you. you can merge once youre done.


Leading spaces

Probably a nit.
When doing before and after the result contains a leading space. Easily dealt with as I use the split method and can trim.

yeah, it's important to keep the spaces around if someone calls .out('text'). if you don't want the spaces, you can call trim() or use .out('match') or .out('normal')


blob is not defined error

Dear Fengyuanchen,
I have checked in the console the value blob is not defined.Moreover reader.onloadend is not called..So I am not able to get the cropped image in base64.Please help me.Below is the code I used to create cropping canvas and save image.

import Cropper from 'cropperjs'

ionViewDidLoad() {
    console.log('ionViewDidLoad Crop');
    var image = document.getElementById('image');
    this.cropper = new Cropper(image, {
      aspectRatio: 1 / 1
    });

  }

savePicture() {

    this.cropper.getCroppedCanvas().toBlob((blob) => {
     console.log('blob'+blob); //blob is undefined
      var reader = new FileReader();
      reader.readAsDataURL(blob);

      reader.onloadend = () => {
//moreover this function is not called
        let base64data = reader.result;
 console.log('data'+base64data);

        var base64result = base64data.split(',')[1];

        this.viewCtrl.dismiss({
          croppedImage: base64result
        });

      }

    });
  }

Current behavior
When I click the save button after selecting area to be cropped I call savePicture().
Expected behavior
I am expecting blob variable to be defined .
I have used cropper * Cropper.js v1.0.0-rc.3

What is your browser and version?

I solved it by change method.
var canvas = $('#photo').cropper('getCroppedCanvas',{width:145, height:185})
//如果太大可以换成jpeg
var dataURL=canvas.toDataURL('image/png');
var blob = dataURLtoBlob(dataURL);

In my app $('#photo').cropper('getCroppedCanvas',{width:145, height:185}) not working since I am not using jquery
Moreover this.cropper.getCroppedCanvas() reverts {}  when I try to
alert JSON.stringify(this.cropper.getCroppedCanvas())
I am using the cropper in an ionic 3 app
As far as I know the app uses the native browser on the device.
The Cropping function is working sometimes and sometimes it does not work.Please advice me an alternative way to get the cropped Canvas.Thanks

Check if your browser support canvas.toBlob.
Polyfill for canvas.toBlob: https://github.com/blueimp/JavaScript-Canvas-to-Blob

PS: The getCroppedCanvas will return a <canvas> element.


Push from 2 differents IPX

Having 2 IPX v4 in the network, in the same subnet as the home assistant.
IPX Pushes are not working since addition of API auth controls.
I don't know why but the script init always take the 2nd IP of the IPX so request.remote is alway different of host and raise "API call not coming from IPX800 IP".
Push works when commenting this control.
It would be nice if this can be fixed cause I cannont fixe it from my side.
Regards*
C.

Hello, indeed it was not designed for multiple ipx, I will ckeck that

hello, it asks a lot of time to change this implementation, I'm not sure I can do it for only one person asking :disappointed:

Handled in last version :tada:


Generic Type documentation

Is there a better way to comment on a generic type declaration?
/**
 * Some function that does something.
 * @param T The item type
 * @param a The item
 */
public someFunction<T>(a: T): void {
    ...
}

At the moment we are treating T as a @param, which seems to generate the correct documentation; it doesn't sit too well with me however lol.

Yes, currently this is the only way to comment a type parameter. I have to admit this was a quick and dirty one. Any suggestions for a better tag? Maybe like this:
/**
 * Some function that does something.
 * @type T The item type
 * @param a The item
 */
public someFunction<T>(a: T): void {
    ...
}

I wouldn't mind having the @type tag.

Just asked Google, @type is used to annotate variables, see http://usejsdoc.org/tags-type.html. Maybe we should use another tag to avoid irritations. In this discussion they tend to use the form @param <T>. I tend to add support for

@param T
@param <T>
@typeparam T


Appium.Net.pdb not loaded

Description
Appium Opens the App, but before it can input data, we get a System.StackOverflowException, Then a No Symbols Loaded page appears in the editor with 'Appium.Net.pdb not loaded' as its title and Module Information Version <IP_ADDRESS>. Any Ideas how to fix this?
Output:
Process is terminated due to StackOverflowException.
An unhandled exception of type 'System.StackOverflowException' occurred in Appium.Net.dll
Environment

.NET client build version or git revision if you use some shapshot:.NET Framework 4.7.2
Appium server version or git revision if you use some shapshot: 1.9.1
Desktop OS/version used to run Appium if necessary:Windows 10
Node.js version (unless using Appium.app|exe) or Appium CLI or Appium.app|exe:node -v =v8.12.0
Mobile platform/version under test: Android 8
Real device or emulator/simulator: Real Device

appium-server-logs.txt
Please remember that, with sample code; it's easier to reproduce bug and much faster to fix it.
You can git clone https://github.com/appium/sample-code or https://github.com/appium/sample-code/tree/master/sample-code/apps and reproduce an issue using C# and sample apps.
Also you can create a gist with pasted C# code sample or put it here using markdown. About markdown please read Mastering markdown and
Writing on GitHub
Exception stacktraces
Please create a gist with pasted stacktrace of exception thrown by .NET.
Link to Appium logs
Please create a gist which is a paste of your full Appium logs, and link them here. Do not paste your full Appium logs here, as it will make this issue very long and hard to read!
If you are reporting a bug, always include Appium logs as linked gists! It helps to define the problem correctly and clearly.

Done


Fix issue 147

Added a py file that executes the failing ipynb from issue #147.
This way we can track it in the tests during fc development

Codecov Report
Patch coverage: 18.93% and project coverage change: +0.75 :tada:

Comparison is base (52446f2) 59.73% compared to head (bcd41ef) 60.49%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##               fc     #150      +/-   ##
==========================================
+ Coverage   59.73%   60.49%   +0.75%
==========================================
  Files         128      128
  Lines       13019    13106      +87
==========================================
+ Hits         7777     7928     +151
+ Misses       5242     5178      -64

Impacted Files
Coverage Δ

mth5/io/zen/coil_response.py
17.89% <14.28%> (-1.62%)
:arrow_down:

mth5/clients/fdsn.py
37.66% <15.47%> (+29.51%)
:arrow_up:

tests/version_1/test_make_mth5.py
23.63% <19.69%> (+0.62%)
:arrow_up:

mth5/groups/channel_dataset.py
47.63% <20.00%> (+0.13%)
:arrow_up:

tests/version_2/test_make_mth5.py
62.02% <21.42%> (+40.97%)
:arrow_up:

mth5/mth5.py
69.20% <50.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

The issue was when a dataset was requested using from_reference the metadata was not being read in.  This has been fixed.  I removed the tests/notebooks folder as these are redundant tests with tests/version_#/test_make_mth5.py where I've added in tests for from_reference and to_channel_ts.


Syntax Highlighting in HTML

It would be cool if the embedded code blocks in the HTML report used syntax highlighting via something like highlight.js or something.

Thank you @humphd for the great suggestion, feature has been added in pr #11!


gfortran symlinks should depend on _impl, not activation

this will now match behavior of gcc and gxx

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


Mild recipe cleanup

Switch to sha256 checksum
Use Jinja for the URL's file number

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Simplify !IArrayLike|!Array to !IArrayLike in ES6 Array polyfills

After 9d52fed2c7da2a9e3807477c852c60b56edd2497, Array implements
IArrayLike, so the union type can be simplified.

@shicks Ping?

Sorry, I don't follow compiler issues/PRs as closely. LGTM.


fix: compile error in README example

Description
Example counter code from the README caused compile errors after copy+paste.
Adding a trailing slash to change <let/count=0> to <let/count=0/> resolves the error.
Motivation and Context
It is bad developer experience to copy a getting started example and have it not work. This may lead to new user attrition as they may think the tags API preview is suffering from a currently broken or incomplete implementation, when in fact it is a simple syntax error/typo in the sole primary example.
Screenshots (if appropriate):

Checklist:

[x] I have updated/added documentation affected by my changes.
[x] I have added tests to cover my changes.

Appreciate the PR @leoj3n and the additional test!
Looks like the CI is failing though with the changes.
Will take a look soon!

Looks like for the failing format test git on the test runner is not able to pull from origin to get the PR changes or something...
https://github.com/marko-js/tags-api-preview/actions/runs/3193771317/jobs/5213695521
Wonder if the runner is set up only to be able to pull from branches on this repo and not a forked repo or something?
Not too familiar with CI

@leoj3n I'm not sure what's going on with the format action, it seems to be working in other projects...
Regardless I think everything looks good here so I'm going to merge. Again appreciate this!


Admin Rights + Internet Access Requirements - Not Best Practice

The application must be run with admin rights. The application typically needs to connect to the internet. This combination elevates risk any may be unnecessary.
One reason for requiring admin rights, is that user modifiable data exists in Program Files, which goes against best practice. Better locations would be %AppData% or  %ProgramData%.
Request that the requirement for the application to run with admin rights is removed.

The tool can be run remotely from the site server, as long as sufficient rights to configuration manager are provisioned to the running account. The reason for installing into Program Files is to adhere to defaults within app control mechanisms like app locker, and given if the app is installed on a server, that the settings could be persisted across multiple users (yes it could be written to the all users profile too).


Compass project..

Has anybody converted this over to compass just for download and ready to watch for changes?

Hi. The Sass in FoundationPress is compiled using libsass, which is way faster than the ruby version. You can indeed download the project, do an npm install and watch for changes.


Provide option to set runSetupWizard=false in JENKINS_JAVA_OPTIONS

Without this option -Djenkins.install.runSetupWizard=false, on a new install of Jenkins 2.0 it will require some manual intervention in the GUI in order to complete deployment so that the proper Jenkins homepage will be displayed.
I use this role to test deployments of Jenkins along for new plugin development, changes to Jenkins Job Builder config, and groovy scripts for interacting with internal Jenkins settings. The Setup Wizard interferes with proper testing of this.
I propose adding this option to JENKINS_JAVA_OPTIONS in the service config file (or adding an ansible var that allows arbitrary strings to be added to this). This file is at /etc/sysconfig/jenkins in a RedHat install, but I don't know how that will vary by OS/distribution.

Looks like a good idea to me. I dislike setup wizards regardless of testing and such—that's the reason I'm using Ansible :)
I left a comment on the PR—I'd be okay with explicitly setting this to false as a default.

PR has been merged—thanks!


How to convert deserialized script into address

About outs when eg using zencashjs.transaction.deserializeTx method. I can only get satoshis and script, I want to know how to get the real address through script
{
version: 1,
locktime: 0,
ins: [{
output: [Object],
script: '',
sequence: 'ffffffff',
prevScriptPubKey: ''
}],
outs: [{
satoshis: 100000,
script: '76a914da46f44467949ac9321b16402c32bbeede5e3e5f88ac200206260143838b5ff52dc2eb7b4b8099d4e4c99dc3ef19794289a2cd4c10070000b4'
}]
}
example:How to get the corresponding address through 76a914da46f44467949ac9321b16402c32bbeede5e3e5f88ac200206260143838b5ff52dc2eb7b4b8099d4e4c99dc3ef19794289a2cd4c10070000b4

You can use:
zen-cli decodescript '76a914da46f44467949ac9321b16402c32bbeede5e3e5f88ac200206260143838b5ff52dc2eb7b4b8099d4e4c99dc3ef19794289a2cd4c10070000b4'

Thanks. Is there no sdk at present? Is there a js version or a java version? I don’t know much about the c language.

The only way to decode is with the zend cli as far as I know.
It can be called from a node.js project using rpc calls.  It just means having a local node available.

OK, thanks. I'll try to see if I can convert the decrypted c code into js or java


Substitute override with dimension property in custom metric filter

Description of changes
Substitute override with dimension property in custom metric filter.
Tests
Unit tests.
Checklist

[x] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[x] Check all commits' messages are clear, describing what and why vs how.
[x] Make sure to have added unit tests or integration tests to cover the new/modified code.
[x] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lgtm!


Add pretty symbols to php-mode

I'm not pretty sure if Types are redundant or not since Php is not so much around types... But I added them just in case.

Thanks!


Uncaught Error: spawn /Users/seebei/Downloads/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper ENOENT

Uncaught Error: spawn /Users/seebei/Downloads/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper ENOENT
Atom Version: 0.154.0
System: Mac OS X 10.10.1
Thrown From: Atom Core
Steps To Reproduce

...
...

Stack Trace
At events.js:85

Error: spawn /Users/seebei/Downloads/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper ENOENT
  at exports._errnoException (util.js:742:11)
  at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
  at child_process.js:1142:20
  at process._tickCallback (node.js:378:11)

Fixed by https://github.com/atom/notifications/pull/62


Document opening rage menu via adb

You can access the rage menu via adb by sending the keycode manually if you don't have a physical device that you can shake.

Thanks!


The photo disappears when the page width is reduced below 1024

Documentation
Description:
The photo disappears when on https://awilum.github.io/ and https://awilum.github.io/about/ the page width is reduced below 1024
Environment:
HP Laptop 15s-eq1314ur,Windows 10 Version 22H2 Build 19045.2364 Тип х64
Chrome. Google Chrome <IP_ADDRESS> (WebKit 537.36)
Steps to reproduce:
1.Open the page https://awilum.github.io/
2. Set the page width to 1024
3. Set the page width to 1023
4 .Open the page https://awilum.github.io/about/
5.Set the page width to 1024
6. Set the page width to 1023
Actual result:

After the third and sixth steps there is a photo
Expected Result:
Photo disappears

Issue fixed. Updates on Live.
@alekseipiatkovskii  please retest

Retest is done, the issue is fixed.


P8S Orogenic Deformation - Add name of other Support/DPS player that is also Hit/Not Hit

During the Dominion mechanic in P8Sp2, the Orogenic Deformation spread AOE always hits 2 Support and 2 DPS, which gives them a debuff, resulting in them needing to take the second set of towers. Currently the on-screen callout text for this is "Second Towers" while the players that did not get hit receive "First Towers."
The most common strategy for this mechanic is to assign towers to pairs of players, most commonly role pairs, then assigning towers to each, such as THMR. If both melee players are hit, for instance, one of them would need to flex and take the ranged tower. Flexers are typically assigned at the start of the encounter.
It would be helpful if the trigger could identify and callout the other Support/DPS player that has the matching debuff/no-debuff, much like the Snake Debuff callouts in P8Sp1. Would it be feasible for this to be included?
Thank you

I think somebody could still add this! I just didn't have any time to.

I have a user trigger already doing this, so I'll PR it later today.  Sorry, missed the original issue being opened.


Development

Pull Request
Description

add lint python
update readme
add app
add functions on top of basic api wrapper i.e downloading mulite flies
more tests

How Has This Been Tested?
unittests

ran with metoffice credientials

[ ] No

[ ] Yes

Checklist:

[ ] My code follows OCF's coding style guidelines
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked my code and corrected any misspellings

Codecov Report

Merging #3 (b7fd55c) into main (135a56c) will increase coverage by 0.04%.
The diff coverage is 94.80%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   96.62%   96.66%   +0.04%
==========================================
  Files           4        5       +1
  Lines         148      180      +32
==========================================
+ Hits          143      174      +31
- Misses          5        6       +1

Impacted Files
Coverage Δ

metofficeamd/base.py
96.72% <ø> (-0.06%)
:arrow_down:

metofficeamd/app.py
93.33% <92.30%> (-0.15%)
:arrow_down:

metofficeamd/multiple_files.py
95.31% <95.31%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc55a62...b7fd55c. Read the comment docs.

@all-contributors please add @peterdudfield for code

@all-contributors please add @flowirtz for code

@all-contributors please add @JackKelly for review


Add prisoner's dilemma to docs

Hi, I think this one is missing from the docs?
Best,

Ah yes, thanks!

@marimeireles can you sign the CLA?


GPO Item Does Not Exist

Expand Administrative Templates > Windows Component, and select Windows Hello for Business.
In the content pane, double-click Use Windows Hello for Business. Click Enable and click OK. -> there is nothing here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77ab668a-e750-0503-7c17-093d0ea43644
Version Independent ID: 37e38b31-4599-3b00-230b-7a488ee71fb2
Content: Configure Windows Hello for Business Policy settings (Windows Hello for Business)
Content Source: windows/security/identity-protection/hello-for-business/hello-key-trust-policy-settings.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dolmont

@officedocsbot assign @e0i

@vscurtis Hey download and copy the latest administrative templates  to   C:\windows\policydefinations\
i have attached latest 1903 policies in en-US language
PolicyDefinitions.zip

@vscurtis Does this response provided by the community answer your question? We would like to follow-up. Thank you.

its my community answer to Mr vscurtis

Hello, @vscurtis
The issue is under investigation and you will be notified with any changes on the way.
Thank you for providing feedback.

@vscurtis
Upon your feedback, We have updated the content with relevant changes accordingly. Thanks.

@officedocsbot close


suggestedActionsStackedMaxHeight Style Option

Feature Request
suggestedActionsStackedHeight is a good recent addition to the style options. It would be better to have suggestedActionsStackedMaxHeight which sets the maximum height of the suggested actions area but leaves it only growing to fit it's contents when that would be less than the max height.
Is your feature request related to a problem? Please describe.
Currently the webchat component looks broken when there are too many suggested actions. If we do not use suggestedActionsStackedHeight then the suggested actions takes up too much space in the interface. If we do use suggestedActionsStackedHeight then it can be set to a sensible limit but now it is a problem when there are not enough suggested actions, because there is too much empty space.
suggestedActionsStackedMaxHeight would allow the suggested action area to resize dynamically and work in both cases.
Describe the suggestion or request in detail
Please add a suggestedActionsStackedMaxHeight or similar setting that makes the suggested actions area only take up as much space as is needed to fit it's suggested actions or it's defined max height (whichever is lowest).
[Enhancement]

We will put this on the backlog and evaluate it for an upcoming release. Thanks!

@SeanDarlingBiomni This issue was fixed in PR https://github.com/microsoft/BotFramework-WebChat/pull/3456
You can update to 4.10.1 (or 4.11, latest) to see this change in Web Chat. Sorry for the delayed close.


dep init --required

There is no way to add required packages whose version is just in the gopath:

--gopath does not exist for dep ensure. Hence, adding a constraint in Gopkg.toml does not work for commits only existing in the gopath.
dep init has no way to specify required packages, hence dep init --gopath does not work.

/cc @carolynvs

--gopath is only relevant for import, as it scans gopath for what versions you are currently using. By the time one is running dep ensure, that should have already occurred and dep is relying 100% on your source code (imports) + the Gopkg files.
I'm not quite sure what you are aiming to do with it during dep ensure? I assume it's for the k8s bot we discussed but I'm not quite seeing where this part fits in. Is it to avoid scripting out adding the require entries after running dep init to add in things like code generators?
Perhaps this PR would be helpful? https://github.com/golang/dep/pull/1640

I'm not quite sure what you are aiming to do with it during dep ensure?

We have to add k8s.io/code-generator as required package in Gopkg.toml. But as all other publisher-bot repositories, the code-generator one is also only available in the gopath during publishing. So we either need a way to tell dep init about that package or dep ensure has to have gopath support.

Perhaps this PR would be helpful? #1640

Yep, this is what I called "required package". I want to add such a package to a project. But this extra package only exists in the gopath at that time, not pushed to github yet.

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


[Feature request] Add configuration source reading from local data structure

I understand that the only way to define configuration values used when none of the files, environment variables or command line sources, is to use the memory source. The problem with it is hard to define complex data structures using the list of (key, value) string pairs.
I would be great if the function add_in_memory could take an existing data structure and its values, that can be used as default value until any subsequent source overrides them. For example:
use serde::Deserialize;

#[derive(Default, Deserialize)]
#[serde(rename_all(deserialize = "PascalCase"))]
struct Client {
    region: String,
    url: String,
}

#[derive(Default, Deserialize)]
#[serde(rename_all(deserialize = "PascalCase"))]
struct AppOptions {
    text: String,
    demo: bool,
    clients: Vec<Client>,
}

use config::{*, ext::*};

fn main() {
    let default = AppOptions {
        text: String::from("Default text"),
        demo: false,
        clients: Vec::new()
    };

    let config = DefaultConfigurationBuilder::new()
        .add_in_memory(default)
        .add_json_file("base.json")
        .build()
        .unwrap();
    let app: AppOptions = config.reify();

    if app.demo
    {
        println!("{}", &app.text);
        println!("{}", &app.clients[0].region);
        return;
    }

    println!("Not a demo!");
}

Interesting idea. It's worth exploring, but it is likely to be fairly difficult and would involve some rather complex macros to do. The biggest challenge is reversing the data structure into the ubiquitous configuration key/value format. It's not impossible, but it's definitely not trivial. Challenge accepted!
In the meantime, your goal is easily achievable with the features that serde already provides. The following is a minor refactoring of your example where the default values come from the struct itself before configuration.
#[derive(Default, Deserialize)]
#[serde(rename_all(deserialize = "PascalCase"))]
struct AppOptions {
    #[serde(default = "default_app_text")]
    text: String,

    #[serde(default)]
    demo: bool,

    #[serde(default)]
    clients: Vec<Client>,
}

fn default_app_text() -> String {
    "Default text".into()
}

fn main() {
    let config = DefaultConfigurationBuilder::new()
        .add_json_file("base.json".is().optional()) // you can make the JSON file optional if you want to
        .build()
        .unwrap();
    let app: AppOptions = config.reify();

    println!("{}", &app.text);

    if app.demo {
        println!("{}", &app.clients[0].region);
    } else {
        println!("Not a demo!");
    }
}

If no configuration is provided or the key Text doesn't exist in the configuration then AppOptions::text will be "Default text". This works because deserialization all happens through serde. serde tries to find a matching configuration key, which it doesn't. It then falls back to using its own default value mechanism, in this case a callback, to calculate default values.

I almost got a working solution using [serde_merge](https://docs.rs/serde_merge/latest/serde_merge/index.html) I just create an instance of the default configuration data structure, and I merge the one from configuration to the default one after having read the multilayer configuration sources. The whole thing looks like this:

// ...
// Clipped for brevity
// ...

use serde_merge::tmerge;

fn main() {
    let config = DefaultConfigurationBuilder::new()
        .add_json_file("base.json")
        .add_json_file(FileSource::new(PathBuf::from(local_conf_file),true,false,None))
        .build()
        .unwrap();
    let options: AppOptions = config.reify();

    let default = AppOptions {
        text: String::from("Default text"),
        demo: false,
        clients: Vec::new()
    };

    let app: AppOptions = tmerge(default.clone(), options).unwrap_or(default);

    if app.demo
    {
        println!("{}", &app.demo);
        println!("{}", &app.text);
        println!("{}", &app.clients[0].region);
        println!("{}", &app.clients[0].url);
        return;
    }

    println!("Not a demo!");
}

Only trouble is, if base.json misses any value, e.g., text, then the app crashes again with:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: MissingValue("Text")

Hmmm... I'm not familiar with serde_merge.  I get what tmerge is supposed to do, but I'd have to dig into the source to give you a better explanation.
Attached is an E2E working example based on what you've shared. Is there a reason I'm not privy to as to why the built-in default value mechanism serde provides won't work? It looks like it will.
Issue-9 : E2E Solution
Another option would be to implement serde::Deserialize::deserialize_in_place. This would allow updating the struct in-place rather than replace it and potentially ignore/skip attributes that do not have corresponding configuration values. Using serde_merge or ConfigurationBinder::bind require or otherwise result in two struct instances. You can see that ConfigurationBinder::bind calls through to config::de::bind_config, which in turn calls Deserialize::deserialize_in_place.
https://github.com/commonsensesoftware/more-rs-config/blob/f740f2ad4e0dfe04c925c43376739f10acd5380c/src/binder.rs#L45
https://github.com/commonsensesoftware/more-rs-config/blob/f740f2ad4e0dfe04c925c43376739f10acd5380c/src/de.rs#L295
The default implementation of deserialize_in_place, however, just replaces the entire struct. You can further confirm that it is not generated by the serde macros with cargo expand (if you have it installed).
Honestly, I'm not sure if there is a way to generate the necessary deserialization code on a user's behalf for in-place updates, but it's certainly a feature I'd been interesting in adding. I think what would probably have to happen is that more-config would have to generate the appropriate function and then you'd have to wire it up in Deserialize::deserialize_in_place. I'm not even sure how that would play with the default serde derive implementation for Deserialize. I'm happy to track that as a feature request, but it will probably be some time coming under the assumption it's even possible (though I have a feeling it may be).

Yeah, thought about looking for merging a default config right after I posted the feature requests. It seemed ideal and it almost is except for the case where the config source merged together still miss some value. Could be because user is fine with default value and does not want config files clobbered with settings is config file user does not care about.
The workaround suggested works. Another solution would be to always have a full config file (perhaps next to binary) and loaded first. However what is nice with more-config is that it allows multi-layer configuration with little boiler plate. These workarounds break this nice property somewhat.
I did not look at more-config code, but my guess is somewhere in the process of any source, it deals with some data structure that serde can use as base to generate the deserialized data structure. From this perspective, I imagine it should be possible to slip in a data structure that can be serialized into this intermediate representation and that more-config can take to immediately deserialize, and that would do the trick. But there might be lots of details that might get in the way of my nice little ideal scheme, or it might as well work in a very different manner. If that is a sound approach to you, I might give it a try sometime although as you said it might take some time.
Anyway, thank you for the nice crate, your interest in the feature and short answer time!

The configuration layering still works, if you add it. The last set value wins. For example, adding the cmd feature back in and applying .add_command_line(), then you can set Text straight from the console:
cargo run -- --Text "From Console"

To recap, for binding, there are currently two out-of-the-box approaches:

Use the built-in default value mechanisms in serde
Use the mem feature and populate the default values in-memory (which you said you didn't want to do)

Everything you're looking for related to deserialization within the crate is in de.rs. The first part of improving binding is making sure that it is still possible to implement deserialize_in_place if the serde #[derive(Deserialize)] macro is applied. If it is, then it should possible to create a function that can be dropped into. I'm not sure at this point if that will require additional macros to generate the necessary code - possibly. Using cargo expand  (you have to install the tool) will show you what #[derive(Deserialize)] generates and will help understand what's happening. I created issue #10 to track it.


fix point annotation update bug

save point annotations as parquet and udpate path api

Codecov Report

Merging #200 (c3afac8) into master (8fcef27) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head c3afac8 differs from pull request most recent head e61bb73. Consider uploading reports for the commit e61bb73 to get more accurate results

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   49.94%   49.94%   -0.01%
==========================================
  Files          60       60
  Lines        5724     5708      -16
==========================================
- Hits         2859     2851       -8
+ Misses       2865     2857       -8

Impacted Files
Coverage Δ

...pathology_annotations/get_pathology_annotations.py
65.15% <100.00%> (+0.86%)
:arrow_up:

...pathology/point_annotation/proxy_table/generate.py
80.32% <100.00%> (+2.71%)
:arrow_up:

...thology/point_annotation/refined_table/generate.py
98.11% <100.00%> (+4.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcef27...e61bb73. Read the comment docs.


update the cross-store example to the latest and greatest Spring, Spring Data, and Cloud Foundry runtime APIs

update the cross-store example to the latest and greatest Spring, Spring Data, and Cloud Foundry runtime APIs. Also, used Java configuration and Spring 3.1's

Looking into getting this merged soon, thanks! Do you have any updates for this?


Add plan_to_tcp_pose_and_joint_configuration() to DualArmPlanner interface

Currently the dual arm planner interface provides:

(🦾,🦾) -> (🦾,🦾) Joints to joints
(🦾,🦾) -> (🦾,💤) Joints to single arm joints
(🦾,🦾) -> (💤,📐) Joints to single TCP pose
(🦾,🦾) -> (📐,📐) Joints to dual TCP poses

However, for the cloth competition I have a use case where I want to move one arm to it's home joints, and the other arm to a TCP pose. So I would need:

(🦾,🦾) -> (🦾,📐) Joints to joints and TCP pose
(🦾,🦾) -> (📐,(🦾) Joitns to TCP pose and joints

I believe this is a general and valid use case, so I'm planning on adding:

plan_to_tcp_pose_and_joint_configuration()
plan_to_joint_configuration_and_tcp_pose()

The implementation should also be straightforward, as the MultipleGoalPlanner already has logic to handle this.

If you would like a single .plan() method, feel free to add that to the interfaces. It would have to use array shape of the goal(s) to infer the required planning mode. I agree this is in line with how we currently use None to signal that an arm should not move at all.
However I'm wondering whether we should go in the opposite direction. I like that the current method names are explicit. Planning to joint goals and planning to TCP goals are conceptually different things, so I believe it's good to show that in the method names, rather than relying on the variables names (e.g. a reader of your code might not know your variable naming convention).
Similarly, I have had instances where I accidentally swapped goals (None, goal) with (goal, None). Additionally readers of your code could be confused by a variable e.g. "grasp_pose" that implicitly contains None. Even worse, e.g. if grasp selection fails and returns None, you might still accidentally plan and move one of the arm. So maybe we should add methods like .plan_to_tcp_pose_left() to the dual arm interface to be even more explicit, readable and less bug prone?


Requirement spiral version 1.1.0 is not available through PyPI

spiral, a requirement of Namesake, is not available through PyPI. Running pip install -r requirements.txt will not install the package, since the specified requirement is version 1.1.0 but the most recent version available on PyPI is <IP_ADDRESS>. I was able to get around this problem by cloning the GitHub repository and manually installing it into my virtual environment but that's not a sustainable fix.
The Spiral setup documentation recommends the following command for installing the latest version of spiral: sudo pip3 install git+https://github.com/casics/spiral.git.

I think there's another python package with the same name, and you found the correct project: https://github.com/casics/spiral
The following command should work:
sudo pip3 install git+https://github.com/casics/spiral.git


HAWKULAR-877 - Enabled the Secret Store for the REST API

With this, the backend starts accepting tokens generated via Accounts, instead of only OAuth Bearer tokens and username/password.

Does this PR depends on Wildlfy10 or it can go on Wildfly9/10 ?

This does not depend on WF10.


Add RecordOf<TProps> type alias for TypeScript

The Record.Factory API is great but the current definitions lack a simple way to reference instances of a record (created from a record factory). This adds a RecordOf<TProps> which can be used to create interfaces containing records:
import { Record, RecordOf } from "immutable";

interface Foo {
    flag: boolean;
    message: string;
}

const FooRecord = Record<Foo>({
    flag: false,
    message: "DEFAULT"
});

interface Bar {
    foo: RecordOf<Foo>;
}

const bar: Bar = {
    foo: new FooRecord({ flag: true })
}

Currently I've been creating this type in every library so that I can refer to instances and I think Flow has support for something similar.

Nice


Assorted changes

Hi.
I have Hugo running on the Minos theme on my site. Thanks a lot!
Since I made some changes locally, I'd like to contribute back what I think is generic and useful.
What do you think?
I'm fine with dropping some commits if you don't see the value.

Hi @v1ne, thanks for the great work! Since I am not actively maintaining the project and I have been away from hugo theme development, I am not 100% clear with the changes but they look ok. For the omitDate param, it is possible to document it in the readme? Then this PR is good to go.

@carsonip: Good point! I added a paragraph to the README.md

Thanks!

@v1ne please look at #37 and note that we assume .Site.Params.Author is a string and how we ignore .Site.Author. If .Site.Author support is needed, please submit a PR.

@carsonip: :eyes: Hmm, so it's just a string. Ok. I saw that you already fixed it, thanks!
Sorry for causing the trouble. Next time, I'll test against the Themes website, too!


Spartacus not loading translations from local JSON files when using SSR

Environment Details

Spartacus: 1.4.0-rc.1
Browser: Google Chrome Version 79.0.3945.130 (Official Build) (64-bit)
OS: Ubuntu 18.04.3 LTS
Device: Dell Precision-5530

Steps to Reproduce

Create a new Angular application
Install Spartacus from the libraries using the schematic and the --ssr flag
Add config for loading translations from local files to the app.module

i18n: {
  backend: {
    loadPath: 'assets/translations/{{lng}}/{{ns}}.json',
  },
  chunks: translationChunksConfig,
  fallbackLang: 'en'
},

Build an run the SSR application using yarn build:ssr and yarn serve:ssr
Deactivate Javascript in the browser to see what is rendered on the server
Access a server-side rendered page(e.g.: Product Detail Page)

Observed Results
The translations are not loaded by the Node application:

Expected Results
Translations should be loaded from JSON files also on initial server-side rendered page.

QA steps:
The same as here: https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/6030#issuecomment-573036540 Please make sure to disable Javascript in your browser to see only the result of the SSR.
Expected: translations are displayed on http://localhost:4200/electronics-spa/en/USD/product/300938/Photosmart E317 Digital Camera (i.e. Add to cart button)