Example code on how Thomas would solve it.

Merged back into https://github.com/beedesk/django-trusts/pull/3.


PowerToys Won't Run After Install of Visual Studio 2022 Preview 2.1

Microsoft PowerToys version
0.56.2
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
Have PowerToys set up to start on login
Install the latest preview of Visual Studio 2022 - Version 17.2.0 Preview 2.1
Reboot PC
PowerToysReport_2022-03-24-21-59-38.zip
✔ Expected Behavior
Configured PowerToys apps run as per normal
❌ Actual Behavior
Apps that are configured in PowerToys do not start successfully and report needing .NET Desktop Runtime 6.0.2 (x64).

Clicking yes does not appear to effect any action.
Other Software
VS2022 as above
Manually downloaded & installed the .NET 6.0.2 Desktop runtime and rebooted PC - no effect

Yes, I can confirm that upgrading to 6.0.3 now allows PowerToys to run as expected. Thank you. :)


Add json_schema_extra to computed_field

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Adding json_schema_extra to @computed_field would help in making better documentatiom for Pydantic models.
While I get that some fields that you might use for a field do not apply for a computed field, but there could be others that can be useful:

deprecated: When you rename a property and you add a computed_field as an alias to keep backwards compatibility. Marking it as deprecated can be useful to let consumers know it will be removed in the future.
example: Show example values for a computed field to have an idea on how it is computed respective to other fields.

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[X] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Selected Assignee: @adriangb

It's already possible!
from typing_extensions import Annotated

from pydantic import BaseModel, Field, computed_field

class Model(BaseModel):
    @computed_field
    def foo(self) -> Annotated[str, Field(json_schema_extra={'description': 'Foo is great!'})]:
        raise NotImplementedError

print(Model.model_json_schema(mode='serialization'))
"""
{
  "properties": {
    "foo": {
      "description": "Foo is great!",
      "readOnly": true,
      "title": "Foo",
      "type": "string"
    }
  },
  "required": [
    "foo"
  ],
  "title": "Model",
  "type": "object"
}
"""

Ok, that works so it is fair.
I thought that since it already has title and description fields that are used for the JSON schema, it would make sense to also have json_schema_extra like Field so this can be done in a cleaner way than using Annotated.


Export is only exporting annotations and not the images

Version:
Label Studio version: 0.9.0.post5
Python error stack
[2021-01-25 21:13:39,161] [ERROR] [label_studio_converter.converter::convert_to_voc::412] Unable to download /data/upload/f78f75-IMG_7224.jpg. The item {'id': 5, 'input': {'image': '/data/upload/f78f75-IMG_7224.jpg'}, 'output': defaultdict(<class 'list'>, {'label': [{'height': 16.4, 'rectanglelabels': ['clubhandle'], 'rotation': 0, 'width': 17.066666666666666, 'x': 18.4, 'y': 0, 'type': 'RectangleLabels', 'original_width': 3024, 'original_height': 4032}, {'height': 25.2, 'rectanglelabels': ['clubhandle'], 'rotation': 0, 'width': 11.6, 'x': 19.2, 'y': 74.8, 'type': 'RectangleLabels', 'original_width': 3024, 'original_height': 4032}]})} will be skipped
Traceback (most recent call last):
File "/home/jth/python/label-studio/lib/python3.8/site-packages/label_studio_converter/converter.py", line 408, in convert_to_voc
image_path, is_downloaded = download(image_path, output_image_dir)
File "/home/jthpython/label-studio/lib/python3.8/site-packages/label_studio_converter/utils.py", line 75, in download
r = requests.get(url)
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/sessions.py", line 519, in request
prep = self.prepare_request(req)
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/sessions.py", line 452, in prepare_request
p.prepare(
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/models.py", line 313, in prepare
self.prepare_url(url, params)
File "/home/jth/python/label-studio/lib/python3.8/site-packages/requests/models.py", line 387, in prepare_url
raise MissingSchema(error)
requests.exceptions.MissingSchema: Invalid URL '/data/upload/f78f75-IMG_7224.jpg': No schema supplied. Perhaps you meant http:///data/upload/f78f75-IMG_7224.jpg?
It appears that requests module does not support local file URLs. This used to work but appears to be broken.

Tested on 0.8.2 and all export types work.  Appears the 0.9.x version is broken.

Tested on 0.8.2 and all export types work.  Appears the 0.9.x version is broken.

@jthaloor Thank you very much, it's a bug, I'll try to solve it asap.

@jthaloor Thank you very much, it's a bug, I'll try to solve it asap.

@jthaloor Try to
pip install -U label-studio-converter

and do export again.

@jthaloor Try to
pip install -U label-studio-converter

and do export again.

Tested and it is working now.
label-studio             0.9.0.post5
label-studio-converter   0.0.22.post2

Tested and it is working now.
label-studio             0.9.0.post5
label-studio-converter   0.0.22.post2


Show meaningful errors on rate limiting

Perhaps overlay a div on the filebrowser explaining the rate-limiting, with a time that the rate-limiting will be lifted.

Closed by #8


does not provide an export named 'default'

import vc from '@digitalbazaar/vc';
^^
SyntaxError: The requested module '@digitalbazaar/vc' does not provide an export named 'default'
What am I missing? Thanks!

was using https://gitlab.com/gaia-x/gaia-x-community/gaia-x-catalogue/catalogue-prototyping
which uses require() and package.json with "dependencies": {
"@digitalbazaar/ed25519-signature-2020": "^3.0.0",
"@digitalbazaar/ed25519-verification-key-2020": "^3.2.0",
"@digitalbazaar/vc": "github:digitalbazaar/vc-js",
but i guess this is not working anymore because this is an esm only package now?

I'm facing the same issue. @riebeb, were you able to make it work somehow?

There isn't a default export anymore.  You can pull in everything with:
import * as vc from '@digitalbazaar/vc';

or just the functions you need like:
import {issue, verifyCredential} from '@digitalbazaar/vc';

Looks like the README needs some updates.

Great, thank you! @davidlehn
And yes, README needs to be updated 👌🏻


Auto format text shortcut key?

Hi, what's the shortcut key to autoformat the code, like Shift+Alt+F in VS Code ?
Can it be enabled on file save ?
(Based on this issue https://github.com/YellowAfterlife/GMEdit/pull/7)

I don't believe that the formatter is currently bound to any shortcut at all - over time it broke due to new tokens being introduced, and has had some limitations even before that.
Making a minimal plugin to invoke gml_fmt on the current file can be a better way. You can get the path to the currently open tab via $gmedit["gml.file.GmlFile"].current.path.

Thanks


Use Python3.x virtualenv for the project

python-rq is the library we want to use for the
producer/consumer design pattern and it only works on
python3

Please review and if everything is okay merge. Thanks!


Can't start battle on LG G7

From LG G7 (LM-G710ULM)
Ram: 4 gb
Android 8
Hello guys, I downloaded the app from google play, and, although I already reinstalled, I can't get the app to work. I followed the video pinned on the main page. Maybe I'm missing something? Sorry if the answer is too obvious. Thanks for your time

Didn't read the Troubleshooting Guide: https://github.com/MathewSachin/Fate-Grand-Automata/wiki/Game-Area-detection#case-4-your-phone-is-android-7-or-8-and-has-a-notch
Notch not supported before Android 9


Can not render in IE 11.

Hey,
I had an issue when using Visjs on IE 11. UI was not rendered and the error was shown in the picture below

Browser: IE 11.
Version: 11.615.17763.0

dublicate of https://github.com/visjs/vis-util/issues/37

@mojoaxel I am using Visjs-network version 5.2.0! Please check it again!

@at-hoangnguyen2 I can confirm this issue. It must be fixed in vis-util. Please wait for the next release.

We need vis-util > 1.1.4 to be released. Than greenkeeper will pick up the change and release a new - hopefully fixed - version of vis-network.

Hi @at-hoangnguyen2,
5.2.4 is released with a fix. Could you check whether it helps or not please? I don't have access to IE 11 at the moment.
Thanks.

Using version 5.2.4 with IE11 (11.950.17134.0), none of the network examples work...exception logged in ie console:
SCRIPT5007: Object.getPrototypeOf: 'this' is not an Object
vis-network.js (7074,9)

Hi @omniflash,
I don't have access to IE 11 so this is just a wild guess but could you try if this fiddle solves your issue: https://jsfiddle.net/thomaash/wzokfg04/ ?

(We should set up a browser stack account...)

We should…

@Thomaash We could use the vis-bot account for browserstack and share it. I'll take care of it..

Hi @Thomaash! Sorry, I only could check it now...unfortunately its not working still, but now there is a different error:
SCRIPT438: Object doesn't support property or method 'isFinite'
vis-network.644b7d3a4855ea0563eb6c87e5124fe9.js (36427,13)

Yes! We're getting somewhere. Try this next: https://jsfiddle.net/thomaash/wzokfg04/7/ .

Yesss! :)) Its displaying.

Okay, so we need core js 3 to properly polyfill IE11. I'll have to make some changes to the way bundling is done in the entire visjs family. That may take a while.

I know its the worst question, but how much time you think? Asking bc its needed for a deadline project for me ;) And thank you in advance, very swift reaction :) Other option for me is to try the last version which is still working in IE11 and handles" controlNodeDragEnd" event.  Are you maybe aware of any version that may be good for me in the meanwhile?

I'm not sure how long but it is a big change I want to discuss with others (as it among other things affects all of our projects.) It could be a few days or even more.
I can publish a pre release outside of the normal versioning (to not affect other people with possible errors, overlooked breaking changes…) that you could pin in your package.json, would that be helpful?

i will check and get back to you, but few days i think is not an issue ;) thank you very much!!

Ok, so I just checked your commit and quickly changed it in the compiled js. The graph now is visible, still getting the same error in console when changing arrows or direction via buttons, but they seem to work fine nevertheless. The events tho doesnt seem to fire...
		 	network.on("dragEnd", function (params) { 		 		var controlEdge = params.controlEdge; 		                alert(JSON.stringify(controlEdge,null,2));              		        console.log('dragEnd Event:', params); 			    }); 		    network.on("controlNodeDragEnd", function (params) { 		            	var controlEdge = params.controlEdge; 		                alert(JSON.stringify(controlEdge,null,2));          		        console.log('controlNodeDragEnd Event:', params); 		    });
This doesnt do anything, when connecting edges, neither of the alerts are shown and nothing is logged.

What commit are you talking about? If you mean #85 that doesn't have the fix (https://github.com/visjs/vis-util/pull/55) for vis-util and therefore won't work. If you're talking about https://github.com/visjs/vis-util/pull/55 that uses core-js 2 and therefore won't work either. You need to have both at the same time, checking only one out is not enough.
If you just want the dist fixed for IE11 you can download it here: https://ulozto.net/file/Ks1Vf8hvqXC5/vis-network-ie11-dist-zip (md5sum: 9d34fe1b9a22943d7d245209135c7f81).

Oh ok, gotcha. The one you uploaded works perfectly, thank you very much! I can use this until the next release, which contains these fixes. Hats down for the fast support!! :)

What commit are you talking about? If you mean #85 that doesn't have the fix (visjs/vis-util#55) for vis-util and therefore won't work. If you're talking about visjs/vis-util#55 that uses core-js 2 and therefore won't work either. You need to have both at the same time, checking only one out is not enough.
If you just want the dist fixed for IE11 you can download it here: https://ulozto.net/file/Ks1Vf8hvqXC5/vis-network-ie11-dist-zip (md5sum: 9d34fe1b9a22943d7d245209135c7f81).

Quick question... Will the dist fixed files help with the timeline not displaying in IE 11 as well?

No. The dist files contain only Network. However Util which is used in Timeline is already fixed and works in IE11 (the other issues were in Network codebase) so it should be enough to update Util to 1.1.7+ in Timeline and rebuild.
PS: This assumes that there are no issues in Timeline itself.

No. The dist files contain only Network. However Util which is used in Timeline is already fixed and works in IE11 (the other issues were in Network codebase) so it should be enough to update Util to 1.1.7+ in Timeline and rebuild.
PS: This assumes that there are no issues in Timeline itself.

Should vis-network package.json also update the version of vis-util?

In addition, the example https://visjs.github.io/vis-network/examples/network/basicUsage.html ie 11 cannot be displayed.

Hi @rochappy,
does it work for you if you use https://github.com/Thomaash/vis-network/blob/peer-build/standalone/umd/vis-network.js instead of the version you're using now?

Yesss! It is displayed, So for the time being, use this scheme instead? when is it merged into the master?

Hi @rochappy,
does it work for you if you use https://github.com/Thomaash/vis-network/blob/peer-build/standalone/umd/vis-network.js instead of the version you're using now?

Yesss! It is displayed, So for the time being, use this scheme instead? when is it merged into the master?

We have a mandatory review policy so it's up to when @mojoaxel will find the time to review it and if no problems arise from the review.

We have a mandatory review policy so it's up to when @mojoaxel will find the time to review it and if no problems arise from the review.

@Thomaash Thank you for your prompt reply and look forward to the team update.

@mojoaxel plz review #85 !

@mojoaxel plz review #85 !

#85 is approved.


Update Dockerfile

This PR includes a few updates to the project's Dockerfile.

Update base image to 8.6-alpine
Quiet npm install output
Gather advisories after npm install

Not sure what to do regarding the build failure. Looks like other 3.0.0 branch builds are failing?

build failure isn't your fault :) thanks!

@nlf Thanks for the merge! Is a v3.0 release still in progress? Any estimate on when the 3.0.0 branch will be merged into master?

I have one more feature to implement and then I’ll be merging it to master. It’s published to npm and is usable now though, you can npm install nsp@next to get it

@nlf I am really waiting for the 3.0 release as it helps us setup our CI changes. Hope to see the update soon.

made 3.0 the master branch and published 3.1.0 just now


How to add all domain management tools for SolanaAgentKit?

Is there any guide to add domain management tools?

Hey there, it has been added now update to see the latest changes

https://github.com/sendaifun/solana-agent-kit/pull/29


ConfigResolver / Luau::parseConfig should store location of resolved config alongside alias

I would like to start implementing alias resolution via .luaurc for Luau LSP.
We already use Luau::ConfigResolver from Luau.Analysis, so it seems like it would be best to continue using that. Luau LSP essentially replicates the same CliConfigResolver used for luau-analyze: https://github.com/luau-lang/luau/blob/e8a7acb8023d3fa30d7d6c0fbbe6fb98faae49a1/CLI/Analyze.cpp#L193
The problem right now, however, is that once we want to start resolving aliases, we do not have the correct location to resolve it relative to. The aliases RFC states (https://github.com/luau-lang/rfcs/blob/master/docs/require-by-string-aliases.md):

if an alias is bound to a relative path, the path will be evaluated relative to the .luaurc file in which the alias was defined.

However this location is not preserved via Luau::parseConfig, making the Config datastructure unsuitable for alias resolution in analyse.
The Luau REPL does not seem to have this issue because it decides to implement its own recursive config resolution, and ends up storing and later referencing lastSearchedDir:

https://github.com/luau-lang/luau/blob/e8a7acb8023d3fa30d7d6c0fbbe6fb98faae49a1/CLI/Require.cpp#L256
https://github.com/luau-lang/luau/blob/e8a7acb8023d3fa30d7d6c0fbbe6fb98faae49a1/CLI/Require.cpp#L253

As an aside, do you folks intend to support the new require-by-string + aliases in luau-analyze soon? I imagine you will hit this same issue once you do so.

Hey, I'll take a look at this. I may have to wait until this RFC is all finalized and merged in, though: https://github.com/luau-lang/rfcs/pull/56.

Saw the introduction of Alias options in the latest sync, nice! But it wasn't included in release notes yet. Is it ready for use?

Yes! AliasOptions can be passed to parseConfig, and the Config itself will store the deduped config locations in the new AliasInfo struct.
If you want to see how it might be used in action, Require.cpp was refactored a bit to use this.

parseConfigInDirectory now creates and passes an AliasOptions struct when parsing a new config file.
getAlias now resolves the alias relative to the stored configLocation, rather than lastSearchedDir.

As an aside, do you folks intend to support the new require-by-string + aliases in luau-analyze soon? I imagine you will hit this same issue once you do so.

Also, regarding this, require-by-string semantics for luau-analyze are implemented—will land in the next release.


Potential Attack Vector

My eth got drained into this wallet: https://etherscan.io/address/0x795df9a9699b399ffc512732d2c797c781c22bc7
About 24 hours ago. My wallet is encrypted, and the last time I used it was over 2 days ago. I had this extension installed at the time. I'm documenting this warning that this extension could possibly have been the cause in an effort to find the source of this attack if other people may have been affected here as well.

Can you do a history check?

@409H https://addons.mozilla.org/en-US/firefox/user/EtherAddressLookup/
Yup definitely looks like I visited that domain. Thats odd though because I installed the plugin such a long time ago. Oh well thanks for your help.

Yeah, IIRC they updated the extension to v1.12.1 a couple days ago which had the private key stealer in it. Once it was found by a user and commented on the extension page, they rolled the extension back, then we got it delisted.
I didn't managed to get v1.12.1 of that extension so I couldn't inspect it to see what exactly it was doing.
Announcement here: https://twitter.com/myetherwallet/status/941259882367401984

(I've added the invalid tag to this issue as it's due to the malicious Firefox extension)
I'll leave the issue open for a couple days in case you need to discuss some more.


Add 'Every N Days/Weeks/Months' options to Service Schedule Wizard

Critical Changes
Changes

Add 'Every N Days/Weeks/Months' options to Service Schedule Wizard

Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below

Place holder data is incorporated (Refer to Case Management Sample Data document)
[ ] Base axe-core JEST test included for any new LWC (No critical violations)
[x] CRUD/FLS is enforced in Apex
Permission sets & field sets are updated to account for CRUD/FLS/TABS for new object metadata
[x] All modified classes are unit tested (Apex) at 100% coverage
[ ] UX approval or UX not necessary
[x] PR contains draft release notes
[x] Attach work item to the pull request with Lurch **Lurch:attach W-000000 or **Lurch:add
[ ] All acceptance criteria have been met

[x] Developer
[ ] Code Reviewer
[ ] QA

[ ] QE story level testing completed

W-8140849 Add "Every _" Recurrence options


Version bump (minor) to 18.2.0

New features

The lot descriptions for DOS5 have been updated for the new choose a lot journey (#674)
The default branch has been renamed to main (#672)
You can now use invoke instead of make (#675)

@bjgill Good question. I've updated the description.


Update sbt-jmh to 0.3.5

Updates pl.project13.scala:sbt-jmh from 0.3.4 to 0.3.5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "pl.project13.scala", artifactId = "sbt-jmh" }]

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #147   +/-   ##
=====================================
  Coverage      91%    91%
=====================================
  Files          69     69
  Lines        1190   1190
  Branches       37     36    -1
=====================================
  Hits         1083   1083
  Misses        107    107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9189bc...59ab926. Read the comment docs.


Make breadboard ui embeddable

For https://github.com/google/labs-prototypes/tree/main/seeds/gemini-guide, we'd like to be able to embed parts of the current Breadboard UI into a site. For example, we'd like to be able to show a preview of a board as part of a larger page.

@alexandraM98 has been looking over the components with a view towards this

In theory there's nothing to prevent it, I guess it's mostly a case of making sure that there's a suitable API / bootstrap in place so that it's convenient to work with. Today we keep a fair amount of stuff (like the runner) outside in the breadboard-web and feed info into breadboard-ui, which we'd need to do in any other embedded context.
Or maybe another way to say it is that we could take a similar approach to the CLI and bundle in breadboard-web and feed it the board of interest?

The @breadboard-ai/exadev team is still experimenting but will share any insights as we have them. My gut says being able to do both would be ideal

Vague ideas:

a developer runs npm install @google-labs/breadboard-web
this gives them access to a couple of web components: preview, debugger, list, etc.
they can just embed those into their docs
they can also do this from esm.run or similar.

WDYT?

I think this aligns with one of the use-cases I was thinking of us aiming for.
The flow you're describing feels a lot like that of the swagger react component:
https://www.npmjs.com/package/swagger-ui-react
import SwaggerUI from "swagger-ui-react"
import "swagger-ui-react/swagger-ui.css"

export default App = () => <SwaggerUI url="https://petstore.swagger.io/v2/swagger.json" />

There's now a bb-embed custom element at @google-labs/breadboard-web/embed.js, instantiated like this:
https://github.com/breadboard-ai/breadboard/blob/464c10e52d26ac6b6fd39171234ffe84ad0bb1ae/packages/breadboard-web/embed.html#L65-L66
Not sure what to do next though. How do I make it easily portable/usable from anywhere?

Now embeddable:
https://output.jsbin.com/biwuvec/quiet

very nice!

@dglazkov did you try with a relative local path? I'm thinking about use in a development environment
e.g.
<!DOCTYPE html>
<html lang="en">
	<head>
		<meta charset="UTF-8" />
		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
	</head>
	<body>
		<bb-embed
			url="./board.json"
		/>
		<script
			type="module"
			src="https://esm.sh/@google-labs/breadboard-web@1.2.0/embed.js?alias=fs/promises:fs"
		></script>
	</body>
</html>


ARROW-6202: [Java] Add unit test for large resultsets

This tests with a fake result set that OOMs do not occur.  On my box I tested with up-to 6MM rows.  Using the old single shot API this was consistently failing.  I also made the iterator extend auto-closeable and fixed a memory leak.

@emkornfield This is cool, mostly LGTM. Why we change testing module files here?

Thanks for catching the change in the submodule, i need to sync to what was on master, now only java files are updated.

@praveenbingo @BryanCutler @pravindra this is pretty minor change (although the fake result set is kind of large).  I'll merge this myself tomorrow, unless you guys have concerns.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6d49481). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #5134   +/-   ##
=========================================
  Coverage          ?   89.74%
=========================================
  Files             ?      682
  Lines             ?   101786
  Branches          ?        0
=========================================
  Hits              ?    91352
  Misses            ?    10434
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d49481...de3a3b5. Read the comment docs.

merged to master, thanks @emkornfield !


Is there a way to get an active class when we are on the link's route path?

Hi,
How can i get a class "active" or other class name to specify when we are in a specific page?
Thank you

https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md#active-class

I'm sorry! The docs aren't very clear about this, we just can find it in the Upgrade guide and it's a main functionality.
Thank you for your answer

feel free to send the PR


Select all box for machine translations

Motivation
Selecting all languages individually takes time. When creating a new page it would be easier to be able to tick a box that selects all languages automatically
Proposed Solution
Add a box similar to multi language xliff export:

Possibly make one box per list (existing translations and new translations)?
Alternatives
Keep it, as it is
User Story
As a CMS user I want to be able to create translations quickly and not have to select 20 languages individually.
Design Requirements
We can reuse the design from multi language xliff export.

@osmers Do you mean inside the machine translation box on the page form?

@JoeyStk yes exactly


refactor: remove GITHUB_SERVER_URL enivronment variable flag

The issue has been fixed in 217(codecov/uploader).

Codecov Report

Merging #7 (15a6ea0) into main (e68fb97) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   76.09%   76.09%
=======================================
  Files          15       15
  Lines         711      711
=======================================
  Hits          541      541
  Misses        170      170

Impacted Files
Coverage Δ

src/dev/run-test.sh
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68fb97...15a6ea0. Read the comment docs.


Juntuchen/callback uri override

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.CallAutomation

Quick questions - are we doing this for Meda/Recording? they also do send events

Quick questions - are we doing this for Meda/Recording? they also do send events

The current story that I am working on is for signaling part only. I will have the feature implemented in media team's methods and SDK in the future.


Fix NPE in ANN search when a segment doesn't contain vector field

Description
Fix NPE in ANN search when a segment doesn't contain vector field.
Whats the fix:
So I added couple of things in the code which will not only fix the bug but will also provide some speedup to the DiskAnn Queries in certain cases.

When the rescore pass happens in disk based vector search, only those segments are hit which has docs to be rescored. Earlier all the segments were getting rescore call even when they don't have to rescore the docs. This will provide some speed up to the query and also fix the bug.
Ensured that in ExactSearcher class, if fieldInfo is null for a field no results are returned. This is similar to what we have to ANNSearch ref: https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/index/query/KNNWeight.java#L232-L236.
I tried to use Optional in the code to indicate that value may not be present, rather than having some empty object of classes like DISI, KNNIterator. This will atleast now force the authors to do empty checks while using a particular value. Similar thing, we should do for while getting the fieldInfo as this can easily be a miss in future. I am trying to find a right place to put that util class but will see if I get time to enforce this in code.

Dev Testing
Create Index
PUT my-knn-index-61
{
	"settings": {
		"index": {
			"knn": true,
			"number_of_shards": 1,
			"number_of_replicas": 0,
			"refresh_interval": "1s"
		}
	},
	"mappings": {
		"properties": {
			"my_vector1": {
				"type": "knn_vector",
				"dimension": 8,
				"mode": "on_disk",
				"compression_level": "32x"
			}
		}
	}
}

Ingest 2 documents
PUT _bulk?refresh=true
{ "index": { "_index": "my-knn-index-61", "_id": "17" } }
{ "my_vector1": [-6.78, 5.34, -8.12, 6.78, -4.12, 7.89, -3.45, 8.34] }
{ "index": { "_index": "my-knn-index-61", "_id": "74" } }
{ "my_vector1": [7.34, -6.45, 5.12, -7.78, 6.89, -4.34, 8.12, -5.67] }
{ "index": { "_index": "my-knn-index-61", "_id": "5" } }
{ "my_vector1": [-5.78, 7.12, -6.45, 8.34, -4.12, 7.89, -6.78, 5.34] }
{ "index": { "_index": "my-knn-index-61", "_id": "17644" } }
{ "my_vector1": [6.45, -8.34, 5.67, -7.89, 3.12, -6.78, 8.45, -4.12] }
{ "index": { "_index": "my-knn-index-61", "_id": "177322" } }
{ "my_vector1": [-7.12, 6.78, -4.56, 8.34, -5.67, 7.12, -3.34, 6.45] }

Delete a document
DELETE my-knn-index-61/_doc/17

Segments
GET _cat/segments/my-knn-index-61
[
	{
		"index": "my-knn-index-61",
		"shard": "0",
		"prirep": "p",
		"ip": "<IP_ADDRESS>",
		"segment": "_0",
		"generation": "0",
		"docs.count": "5",
		"docs.deleted": "0",
		"size": "4.3kb",
		"size.memory": "0",
		"committed": "false",
		"searchable": "true",
		"version": "9.12.0",
		"compound": "true"
	},
	{
		"index": "my-knn-index-61",
		"shard": "0",
		"prirep": "p",
		"ip": "<IP_ADDRESS>",
		"segment": "_1",
		"generation": "1",
		"docs.count": "0",
		"docs.deleted": "1",
		"size": "3.1kb",
		"size.memory": "0",
		"committed": "false",
		"searchable": "true",
		"version": "9.12.0",
		"compound": "true"
	}
]

Search Again with error
GET my-knn-index-61/_search
{
	"query":{
		"knn":{
			"my_vector1": {
				"vector": [1,1,1,1,1,1,1,1],
				"k": 10
			}
		}
	}
}

Response
{
	"took": 61,
	"timed_out": false,
	"_shards": {
		"total": 1,
		"successful": 1,
		"skipped": 0,
		"failed": 0
	},
	"hits": {
		"total": {
			"value": 5,
			"relation": "eq"
		},
		"max_score": 0.0031684334,
		"hits": [
			{
				"_index": "my-knn-index-61",
				"_id": "177",
				"_score": 0.0031684334,
				"_source": {
					"my_vector1": [
						-7.12,
						6.78,
						-4.56,
						8.34,
						-5.67,
						7.12,
						-3.34,
						6.45
					]
				}
			},
			{
				"_index": "my-knn-index-61",
				"_id": "173",
				"_score": 0.0029043476,
				"_source": {
					"my_vector1": [
						-6.78,
						5.34,
						-8.12,
						6.78,
						-4.12,
						7.89,
						-3.45,
						8.34
					]
				}
			},
			{
				"_index": "my-knn-index-61",
				"_id": "175",
				"_score": 0.002883079,
				"_source": {
					"my_vector1": [
						-5.78,
						7.12,
						-6.45,
						8.34,
						-4.12,
						7.89,
						-6.78,
						5.34
					]
				}
			},
			{
				"_index": "my-knn-index-61",
				"_id": "174",
				"_score": 0.002864083,
				"_source": {
					"my_vector1": [
						7.34,
						-6.45,
						5.12,
						-7.78,
						6.89,
						-4.34,
						8.12,
						-5.67
					]
				}
			},
			{
				"_index": "my-knn-index-61",
				"_id": "176",
				"_score": 0.0027358374,
				"_source": {
					"my_vector1": [
						6.45,
						-8.34,
						5.67,
						-7.89,
						4.12,
						-6.78,
						8.45,
						-4.12
					]
				}
			}
		]
	}
}

Related Issues
Resolves #2277
Check List

[X] New functionality includes testing.
[ ] ~New functionality has been documented.~
[ ] ~API changes companion pull request created.~
[X] Commits are signed per the DCO using --signoff.
[ ] ~Public documentation issue/PR created.~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please fix the CI

seems to be related to new dependency upgrades. Will check

@heemin32 , @jmazanec15 and @shatejas can you guys review this PR.


Improve CI test run

:tada: This issue has been resolved in version 0.41.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allowable values of _MolFileBondCfg

What are the allowable values for _MolFileBondCfg and their meaning?
Thanks.

These are V3000 mol file CFG values:

1: wedged bonds
2: unknown stereo (squiggly bond if it's a single bond, crossed bond if double)
3: dashed bond

I'm closing this because it looks like the question is answered. Please reopen if necessary.

Thanks Greg
On Fri, Oct 23, 2020 at 9:58 PM Greg Landrum<EMAIL_ADDRESS>wrote:

These are V3000 mol file CFG values:

1: wedged bonds
2: unknown stereo (squiggly bond if it's a single bond, crossed bond
if double)
3: dashed bond

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/3522#issuecomment-715693219, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKKXN7X5NRL75WGY6XL4RETSMJNI5ANCNFSM4S5EXWZA
.

--
Valery R. Polyakov


Filter Tip Max Volume Compatibility

As a robot user, I would like the max pipetting volume for my pipette limited to the lesser of the max volume of the tip I have attached to my pipette and the max volume of my pipette.
Acceptance Criteria

[ ] Whenever max volume is used in pipette operation or validation rules, use the smaller of the tip max volume and the pipette max volume

Add pipette working volume as an InstrumentContext member
Update working volume during pick_up_tip, determined by the volume of the tip & volume of pipette
Modify aspirate function so it takes working volume into considerations rather than pipette max volume so that it protects from over-aspirating
Revert working volume back to None when return_tip and drop_tip
Modify transfer plan to use working volume rather than max pipette volume
Write tests to make sure pipette functions are working correctly


Misleading note in legacy method .pick_channels

https://github.com/mne-tools/mne-python/blob/00c0e219a371bae8fadb2ccfe268d8a6317d4ab5/mne/channels/channels.py#L467-L469
Not entirely sure, but isn't this note a little misleading, as the order of ch_names does matter when ordered=False is passed?
I think the note should at least mention the ordered parameter.
https://mne.tools/stable/generated/mne.io.Raw.html#mne.io.Raw.pick_channels

Yes I think this is a holdover from back when the default was ordered=False (and even before that when the ordered kwarg didn't even exist!)


revert potentially problematic logic change

I think this is probably causing #1302, though I've only reproduced once and I'm not sure how to reliably repro.

Can reopen this if we need to hotfix, but would be good to fix-foward if possible

Yeah thanks for opening, agree this is the likely problem spot. I think we can solve the issue; my guess is it's when the request fails


SpreadElementExpression can introduce unexpected results in ES5/3

There is a difference in behavior in spread element between ES6 and ES5/3. Given the following:
var a: number[] = undefined;
var b = [1, ...a, 2];

In ES6 hosts, you get an error when a is spread into the array. FF Nightly throws a TypeError: "undefined has no properties".
In ES5/3 hosts you do not get an error, and instead get an unintended result:
var a;
var b = [1].concat(a, [2]); // [1, undefined, 2];

I would expect our runtime behavior to roughly match the ES6 behavior.

We could emulate this behavior by changing the emit to instead be something like the following:
var a = undefined;
var b = [1].concat(a.concat && a, [2]); // throws "TypeError: undefined has no properties" in FF Nightly

I wonder how much we care about preserving error behavior in down level code. I'd hate to generate cryptic code just to preserve an exception that likely isn't important.

It's less that we need to preserve specific error cases, but that the runtime semantics of our emit don't behave as expected. If we don't care about errors, we could instead emit the following, which doesn't introduce undefined in a spread:
var b = [1].concat(a || [], [2]);

If we do want equivalent runtime semantics to ES6, we need to emit something similar to the above, though I spoke with @DanielRosenwasser last week and a better emit (that throws if a is undefined) might be:
var b = [1].concat(typeof a.length && a, [2]);

This seems very hittable with optional parameters, e.g.:
function f(x?: any[]) {
  var g = [0, ...x];
  // ...
}

f();

This is extra subtle because [...x, 0] would throw in ES3/5, which might lull people into a false sense of security. Emitting code that would break at runtime if emitted in ES6 is really bad -- it means it's not safe to move code between projects that have different emit targets.

If you want to avoid cryptic emit, you might need to instead do something like:
if (a === void 0) throw new TypeError();
var b = [1].concat(a, [2]);

@rbuckton That won't work in an arbitrary expression context (at least not without a lot of complications).
One possibility is
var b = [1].concat(a.slice(), [2]);

The slice method appears to be quite efficient on most VMs when returning the full array. Probably because the VMs implement copy-on-write semantics for arrays.
http://jsperf.com/new-array-vs-splice-vs-slice/63
Yet another possibility is
var b = [1].concat((a[0], a), [2]);

They all do look cryptic though.

@ahejlsberg I think I prefer the slice implementation, I had considered it as well but was wary of the allocation cost. If it is efficient, it looks cleaner than the other approaches.

I like the slice idea. It's definitely not as fast, but I don't really care since there's a clear workaround (just code the downlevel emit yourself instead of using a spread operator).

A better option is
var b = [1].concat(a || null.concat, [2]);

This throws an exception when a is null or undefined and ensures that the exception message is the same as if a had been the first operand (i.e. the object on which concat was invoked).
However... the problem with this and any of the other solutions is that we're not checking whether a is actually an array (we only check for falsy). It may be reasonable not to do so if the static type of a is an array type (i.e. it's reasonable to trust the type system), but it isn't when a is of type any.
This takes us right down the rabbit hole of downlevel testing for array types--there basically is no correct and efficient way to do so on ES3.
http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/
I think this leaves us with the following options, none of which are great:

Ignore the problem completely and simply state that when the operand of spread is not an array, the behavior differs from ES6. Properly written code will have to guard against non-arrays anyway as they throw exceptions on ES6.
Throw on null or undefined, but otherwise trust the operand is an array (and differ from ES6 if it isn't). That's the middle ground of the solution above, but it seems like an odd place to land.
Emit an even more thorough (and costlier) check.

Given that we care at least a little bit about performance, the best check we could emit that works for both ES3 and ES5 is
var b = [1].concat(a.concat && a.splice ? a : null.concat, [2]);

This throws an exception if a is not an object that has a concat and splice method. Beyond that, we'd trust it is an array.
We could possibly emit
var b = [1].concat(Array.isArray(a) ? a : null.concat, [2]);

when the emit target is ES5, but we'd still need the other check for ES3.
Of course we could turn this into some __checkArray helper function we inject, but I'm just not a fan of those.
My personal preference is to either do nothing or go with inlining the full check (including use of Array.isArray on ES5 targets).

Ignore the problem completely

:+1: - I care about us erroring in the null-ish cases, but we don't provide guarantees about any anyway.  I don't think vexing over whether the user has provided us with an any typed concat-able is worth the worry or effort.

Just to be clear, I meant ignore the problem for any type of a spread expression (whether type any or an array type). I definitely don't want us to be in the type-directed emit business where we emit different patterns based on the static type. The emit should be the same no matter what the static type is or otherwise incremental scenarios like emit-on-save become very hard.

I suggest we close this one. I'm not sure how much of a real world problem this is and the suggested fixes seem worse than the problem itself.


Add EndeavourOS Small Option

Description
Add EndeavourOS small version ASCII art
Features
Added to default config and --help output.

Looks good!

Thank you for your contribution!
This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.
HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.
Read the "Running Updated Original Neofetch" section for more info!


Fix selected server group when connecting from Azure tree view

This PR addresses https://github.com/microsoft/azuredatastudio/issues/17037 (2b)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 41.829%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
30272

Relevant Lines:
67026

💛  - Coveralls


runtime: go compiler with PIE enabled by default race segv

What version of Go are you using (go version)?
$ go version
go version go1.12.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
ArchLinux 5.0.7-arch1-1-ARCH #1 SMP PREEMPT
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jsimonetti/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jsimonetti/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build181627555=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Testing code using -race on a go version with PIE enabled by default I get a segv and a ENOMEM error from the ThreadSanitizer.
What did you expect to see?
An error message similar to one when using the normal go compiler but with -buildmode=pie flag:
% go test -buildmode=pie  -race -count 1 .
-buildmode=pie not supported when -race is enabled

What did you see instead?
=7219==ERROR: ThreadSanitizer failed to allocate 0x2711000 (40964096) bytes at address 176bdd04c0000 (errno: 12)
unexpected fault address 0x0
fatal error: fault
unexpected fault address 0x55af73e8b59c
fatal error: fault
unexpected fault address 0x55af74aefbea
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x2 addr=0x55af74aefbea pc=0x55af74aefbea]

goroutine 1 [running, locked to thread]:
runtime: unexpected return pc for runtime.throw called from 0x55af73e8b1bc
stack: frame={sp:0x7ffdc4bfcfd0, fp:0x7ffdc4bfd000} stack=[0xc000044000,0xc000044800)

runtime.throw(0x3, 0x3)
	/usr/lib/go/src/runtime/panic.go:617 +0x74 fp=0x7ffdc4bfd000 sp=0x7ffdc4bfcfd0 pc=0x55af73c42c14

Edit:
Package managers' patch applied to default source:
https://git.archlinux.org/svntogit/community.git/tree/trunk/default-buildmode-pie.patch?h=packages/go
BTW, feel free to flag this as WONTFIX as this probably it not your problem.

This is a problem with the patch you are applying to the sources, not with the Go source code.  There isn't anything we can do to fix this.


Documentation Request: how to install uuid-ossp.control

on macOS, when following the instructions in the README, I get
PG::UndefinedFile: ERROR:  could not open extension control file "/Users/brandon/.asdf/installs/postgres/14.0/share/extension/uuid-ossp.control": No such file or directory

For users of Postgres installed through Homebrew, it appears to be as simple as entering
$ brew install ossp-uuid

I'll keep looking for instructions relevant to ASDF, but it would be very nice to have those instructions included in the README for various operating systems and configurations.

hm, I never had any problems with uuid-ossp postgres extension, no additional installations, just postgres
I think I'll remove uuids and will use only simple ids


UX for unknown fields

Selecting Unknown makes no change to the field, just remains blank.
UX to confirm expected functionality and UX when selected.
See attached design currently.

@shroothless we should sort out the UX pattern for unknown fields in general. Right now there are some dropdown fields that have "Unknown" values e.g. gender. In the database we have decided to leave this field as not set, rather than setting a value of "Unknown".
In the UI do we want to have the option to specifically choose "Unknown" rather than not setting the field? We could also have both options (select "Unknown" or unselect that field) that translate to the same thing in the backend. But I'm a little wary that if people see an Unknown field they'll feel the need to select it for each field, where they could save time and leave it blank.
Did that all make sense? WDYT?

We had decided that we wanted users to deliberately select Unknown and prioritize accuracy over efficiency. Since many of these fields are not required and the order of the fields doesn't necessarily match the source they are curating from. I'd prefer to keep the unknown option until we hear that it's really slowing people down.


Suggestion: Highlight that connections need to be shared

Hi,
Please add a note or highlight in Step 4: Use the deployment settings file for Build Tools tasks that connections need to be shared with Service Principal app in target environments.
https://github.com/microsoft/powerplatform-build-tools/issues/540#issuecomment-1727686746

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ca1df5d8-ef79-c56d-3950-0617da9f976b
Version Independent ID: ff132857-2fc9-57d0-df24-d42c054cbf1c
Content: Pre-populate connection references and environment variables for automated deployments using Power Platform Build Tools - Power Platform
Content Source: power-platform/alm/conn-ref-env-variables-build-tools.md
Service: power-platform
Sub-service: alm
GitHub Login: @kkanakas
Microsoft Alias: kartikka

Thanks for your comment, @INC02203. This issue has been assigned to the doc author for review.


App says key is invalid.

Hi
I have the extension which works.  but if I log in, e.g. to the dpoll, it tells me the key is invalid.  Please advise.

Do you still having that issue?

Thank, no, all sorted.
--
Fiona Cameron-Brown
The Sandbag House
McGregor
Tel: +27 +23 625 1450
WhatsApp:<PHONE_NUMBER>
http://fionasfavourites.net/
From: Fabien
Sent: 17 August 2019 11:39
To: bonustrack/steemconnect
Cc: fionasfavourites; Author
Subject: Re: [bonustrack/steemconnect] App says key is invalid. (#415)
Do you still having that issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


fix groupname for custom resource code generation

Description
In order to have a groupname different from the one specified in the "input" parameter for the code generator, we have to set the "+groupName=" marker in the doc.go file in the resource package. Put the marker in any other package and the generator won't pick that up.

/test

/rebase test=true

/merge


Webpage: update katex to 0.7.0, show error messages

This updates katex to version 0.7.0. As #613 is causing problems when using this in bower, I manually copied the files from the npm package instead.
I also included a bit of script to display the error message to the output area if rendering threw an exception. That should provide easier feedback as to what's wrong with a given input.

I just realized that this change would expose the way the displaystyle was done until now, by including a \displaystyle in the input string. I've now changed that to a proper displayMode: true setting in the invocation, both to avoid confusing error messages and to demonstrate how this is meant to be handled. As a side effect, the exterior display style styling now applies to the demo output. Personally I consider this a good thing, but if you want me to I can get it back to left-aligned and without extra space around.

Personally I consider this a good thing, but if you want me to I can get it back to left-aligned and without extra space around.

Sounds good.  Thanks for noticing this difference and for updating gh-pages.


[keymgr] HWIP technical specification

Creating this issue to capture some issues that I noticed while I was working on #4256:

References to the error interrupt, which was recently removed, should be removed (searching for "error interrupt" and "interrupt" should show those references).
The spec reads:

Each state, when valid, supplies its secret material as the “key” input to a KMAC operation.

However, IIUC this statement is correct only for transitions between operational states and not for Reset -> Initialized, Initialized -> CreatorRootKey, and OwnerRootKey -> Disabled.

RomExtSecurityDescriptor should probably be a 128b value if the SOFTWARE_BINDING register will be used for it too.
Regarding sideload keys (and clearing them): When keys are sideloaded to other peripherals, do they also store these keys internally or are these direct inputs to those peripherals? If they are stored, should we have a mechanism to delete those as well?
In section "Errors, Interrupts and Alerts", there is "Invalid input" under "Software operation errors" but it doesn't have a corresponding bit in the ERROR_CODE register.
In section "Invalid Operation", reference to Init operation should be removed ("Note that even though Init is not a legal operation in most states, ...")
In section "Invalid Operation", the title of the second column of the table should probably just be "Operations" since the table lists both valid and invalid operations.
"Advance" should be removed from the second column of the second row of the same table.
OwnerKey should probably be replaced with OwnerRootKey (noticed two such instances).
In section "Software Binding", the spec reads:

This software binding exists for every stage of key manager except for OwnerKey.

But, the Identities and Root Keys document reads:

OwnerRootKey = KM_DERIVE(OwnerIntermediateKey, SoftwareBindingValue)

Creating this issue to capture some issues that I noticed while I was working on #4256:

References to the error interrupt, which was recently removed, should be removed (searching for "error interrupt" and "interrupt" should show those references).
The spec reads:

Each state, when valid, supplies its secret material as the “key” input to a KMAC operation.

However, IIUC this statement is correct only for transitions between operational states and not for Reset -> Initialized, Initialized -> CreatorRootKey, and OwnerRootKey -> Disabled.

ah yes i can clarify this.

RomExtSecurityDescriptor should probably be a 128b value if the SOFTWARE_BINDING register will be used for it too.

RomExtSecurityDescriptor should be gone now.  Do you still see it? I was thinking we just use sw_binding only.

Regarding sideload keys (and clearing them): When keys are sideloaded to other peripherals, do they also store these keys internally or are these direct inputs to those peripherals? If they are stored, should we have a mechanism to delete those as well?

This is a good question. I think all the modules will store them in some form, so this should be part of the other module's (aes / kmac / hmac) self clearing routine between runs to ensure there is nothing residual left over.  I'm not completely sure they belong to keymgr DIF though.  What do you think? We should do an audit to make sure there are mechanisms in place for clear.

In section "Errors, Interrupts and Alerts", there is "Invalid input" under "Software operation errors" but it doesn't have a corresponding bit in the ERROR_CODE register.

i think this one is INVALID_KMAC_INPUT.  Do you want me to just rename it as INVALID_INPUT?

In section "Invalid Operation", reference to Init operation should be removed ("Note that even though Init is not a legal operation in most states, ...")

thanks for the reminder.

In section "Invalid Operation", the title of the second column of the table should probably just be "Operations" since the table lists both valid and invalid operations.
"Advance" should be removed from the second column of the second row of the same table.
OwnerKey should probably be replaced with OwnerRootKey (noticed two such instances).
In section "Software Binding", the spec reads:

This software binding exists for every stage of key manager except for OwnerKey.

But, the Identities and Root Keys document reads:

OwnerRootKey = KM_DERIVE(OwnerIntermediateKey, SoftwareBindingValue)

yes thanks for catching these, i will update. The implementation does not preclude software binding for ownerkey.

Creating this issue to capture some issues that I noticed while I was working on #4256:

References to the error interrupt, which was recently removed, should be removed (searching for "error interrupt" and "interrupt" should show those references).
The spec reads:

Each state, when valid, supplies its secret material as the “key” input to a KMAC operation.

However, IIUC this statement is correct only for transitions between operational states and not for Reset -> Initialized, Initialized -> CreatorRootKey, and OwnerRootKey -> Disabled.

ah yes i can clarify this.

RomExtSecurityDescriptor should probably be a 128b value if the SOFTWARE_BINDING register will be used for it too.

RomExtSecurityDescriptor should be gone now.  Do you still see it? I was thinking we just use sw_binding only.

Regarding sideload keys (and clearing them): When keys are sideloaded to other peripherals, do they also store these keys internally or are these direct inputs to those peripherals? If they are stored, should we have a mechanism to delete those as well?

This is a good question. I think all the modules will store them in some form, so this should be part of the other module's (aes / kmac / hmac) self clearing routine between runs to ensure there is nothing residual left over.  I'm not completely sure they belong to keymgr DIF though.  What do you think? We should do an audit to make sure there are mechanisms in place for clear.

In section "Errors, Interrupts and Alerts", there is "Invalid input" under "Software operation errors" but it doesn't have a corresponding bit in the ERROR_CODE register.

i think this one is INVALID_KMAC_INPUT.  Do you want me to just rename it as INVALID_INPUT?

In section "Invalid Operation", reference to Init operation should be removed ("Note that even though Init is not a legal operation in most states, ...")

thanks for the reminder.

In section "Invalid Operation", the title of the second column of the table should probably just be "Operations" since the table lists both valid and invalid operations.
"Advance" should be removed from the second column of the second row of the same table.
OwnerKey should probably be replaced with OwnerRootKey (noticed two such instances).
In section "Software Binding", the spec reads:

This software binding exists for every stage of key manager except for OwnerKey.

But, the Identities and Root Keys document reads:

OwnerRootKey = KM_DERIVE(OwnerIntermediateKey, SoftwareBindingValue)

yes thanks for catching these, i will update. The implementation does not preclude software binding for ownerkey.

@alphan , i believe i've addressed all these issues with the latest spec update.
Please have a look.

@alphan , i believe i've addressed all these issues with the latest spec update.
Please have a look.

Thanks @tjaychen, LGTM. Just some comments:

Regarding sideload keys (and clearing them): When keys are sideloaded to other peripherals, do they also store these keys internally or are these direct inputs to those peripherals? If they are stored, should we have a mechanism to delete those as well?

This is a good question. I think all the modules will store them in some form, so this should be part of the other module's (aes / kmac / hmac) self clearing routine between runs to ensure there is nothing residual left over. I'm not completely sure they belong to keymgr DIF though. What do you think? We should do an audit to make sure there are mechanisms in place for clear.

I also think that they don't belong to keymgr DIF but we should probably do an audit and I should definitely mention this in the comments of the DIF (#4256).

In section "Errors, Interrupts and Alerts", there is "Invalid input" under "Software operation errors" but it doesn't have a corresponding bit in the ERROR_CODE register.

i think this one is INVALID_KMAC_INPUT. Do you want me to just rename it as INVALID_INPUT?

I thought this is directly related to SW inputs because the doc says:

Invalid software input was supplied (for example a greater key version than allowed in MAX_OWNER_KEY_VER.

whereas INVALID_KMAC_INPUT's description is "Invalid data issued to kmac interface".

There seems to be an issue with the table:

Thanks @tjaychen, LGTM. Just some comments:

Regarding sideload keys (and clearing them): When keys are sideloaded to other peripherals, do they also store these keys internally or are these direct inputs to those peripherals? If they are stored, should we have a mechanism to delete those as well?

This is a good question. I think all the modules will store them in some form, so this should be part of the other module's (aes / kmac / hmac) self clearing routine between runs to ensure there is nothing residual left over. I'm not completely sure they belong to keymgr DIF though. What do you think? We should do an audit to make sure there are mechanisms in place for clear.

I also think that they don't belong to keymgr DIF but we should probably do an audit and I should definitely mention this in the comments of the DIF (#4256).

In section "Errors, Interrupts and Alerts", there is "Invalid input" under "Software operation errors" but it doesn't have a corresponding bit in the ERROR_CODE register.

i think this one is INVALID_KMAC_INPUT. Do you want me to just rename it as INVALID_INPUT?

I thought this is directly related to SW inputs because the doc says:

Invalid software input was supplied (for example a greater key version than allowed in MAX_OWNER_KEY_VER.

whereas INVALID_KMAC_INPUT's description is "Invalid data issued to kmac interface".

There seems to be an issue with the table:

MAX_*_KEY_VER_REGWEN.EN fields have the following in the description column:

All values except for 2 are interpreted as configuration disable.

but these are single-bit fields.

yeah this needs to be updated to multi-bit regwen, which is kind of a
project wide thing.
the comments got a bit ahead of the implementation.
On Thu, Mar 4, 2021 at 1:34 PM Alphan Ulusoy<EMAIL_ADDRESS>wrote:

MAX_*_KEY_VER_REGWEN.EN fields have the following in the description
column:
All values except for 2 are interpreted as configuration disable.
but these are single-bit fields.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/4769#issuecomment-790960055,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSTQY2R2NTPAIJ4JJHLTB74HLANCNFSM4VZPL3JQ
.

Sounds good, thanks @tjaychen! The DIF will need to be updated when that change lands but I don't think we can miss it because it won't build :)

i believe all the comments here have been addressed. let me know if you disagree!


storjnode>=0.0.11requirement not found

I'm tring to install the dataserv-client on a new pc on Ubuntu 15.10 and I'm experiencing some issues.
First of all to run properly sudo pip install pygraphviz --install-option="--include-path=/usr/include/graphviz" --install-option="--library-path=/usr/lib/graphviz/"
I had to run: easy_install pip
But when i run: sudo pip install dataserv-client i get:
Downloading/unpacking dataserv-client
  Downloading dataserv_client-2.1.8-py2.py3-none-any.whl
Downloading/unpacking storjcore>=0.0.6 (from dataserv-client)
  Downloading storjcore-0.0.6-py2.py3-none-any.whl
Downloading/unpacking partialhash>=1.1.0 (from dataserv-client)
  Downloading partialhash-1.1.3.tar.gz
  Running setup.py (path:/tmp/pip-build-jeew8ws2/partialhash/setup.py) egg_info for package partialhash
    Downloading/unpacking psutil>=3.2.2 (from dataserv-client)
  Downloading psutil-4.0.0.tar.gz (293kB): 293kB downloaded
  Running setup.py (path:/tmp/pip-build-jeew8ws2/psutil/setup.py) egg_info for package psutil
    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no files found matching '*.rst' under directory 'scripts'
    warning: no files found matching '*README' under directory 'scripts'
Requirement already satisfied (use --upgrade to upgrade): btctxstore>=4.6.0 in ./.local/lib/python3.4/site-packages (from dataserv-client)
Downloading/unpacking RandomIO>=0.2.1 (from dataserv-client)
  Downloading RandomIO-0.2.1.tar.gz
  Running setup.py (path:/tmp/pip-build-jeew8ws2/RandomIO/setup.py) egg_info for package RandomIO
Requirement already satisfied (use --upgrade to upgrade): future>=0.15.0 in ./.local/lib/python3.4/site-packages (from dataserv-client)
Downloading/unpacking storjnode>=0.0.11 (from dataserv-client)
  Could not find a version that satisfies the requirement storjnode>=0.0.11 (from dataserv-client) (from versions: 0.0.3, 0.0.1, 0.0.2)
Cleaning up...
No distributions matching the version for storjnode>=0.0.11 (from dataserv-client)
Storing debug log for failure in /home/mat650/.pip/pip.log

Duplicate: https://github.com/Storj/dataserv-client/issues/176
Pygraphviz is not needed anymore. Better use this guide: https://github.com/Storj/dataserv-client/blob/develop/README.rst#linux-ubuntumintdebian

It doesn't works, I get:
mat650@NodeITC1:~$ dataserv-client
Traceback (most recent call last):   File "/usr/local/bin/dataserv-client", line 6, in <module>     from dataserv_client import cli   File "/usr/local/lib/python2.7/dist-packages/dataserv_client/cli.py", line 4, in <module>     from dataserv_client import api   File "/usr/local/lib/python2.7/dist-packages/dataserv_client/api.py", line 7, in <module>     import storjnode   File "/usr/local/lib/python2.7/dist-packages/storjnode/__init__.py", line 3, in <module>     from . import network  # NOQA   File "/usr/local/lib/python2.7/dist-packages/storjnode/network/__init__.py", line 1, in <module>     from . import node  # NOQA   File "/usr/local/lib/python2.7/dist-packages/storjnode/network/node.py", line 19, in <module>     from storjnode.network.file_transfer import FileTransfer   File "/usr/local/lib/python2.7/dist-packages/storjnode/network/file_transfer.py", line 4, in <module>     import pyp2p.dht_msg   File "/usr/local/lib/python2.7/dist-packages/pyp2p/dht_msg.py", line 10, in <module>     from storjkademlia.node import Node as KadNode ImportError: No module named storjkademlia.node
Than I tried:
mat650@NodeITC1:~$ pip install storjkademlia
I got: Traceback (most recent call last):   File "/usr/bin/pip", line 9, in <module>     load_entry_point('pip==1.5.6', 'console_scripts', 'pip')()   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 558, in load_entry_point     return get_distribution(dist).load_entry_point(group, name)   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2682, in load_entry_point     return ep.load()   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2355, in load     return self.resolve()   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2361, in resolve     module = __import__(self.module_name, fromlist=['__name__'], level=0)   File "/usr/lib/python2.7/dist-packages/pip/__init__.py", line 74, in <module>     from pip.vcs import git, mercurial, subversion, bazaar  # noqa   File "/usr/lib/python2.7/dist-packages/pip/vcs/mercurial.py", line 9, in <module>     from pip.download import path_to_url   File "/usr/lib/python2.7/dist-packages/pip/download.py", line 25, in <module>     from requests.compat import IncompleteRead ImportError: cannot import name IncompleteRead
So... I did:
1.sudo apt-get remove python-pip
2.sudo easy_install -U pip
3.sudo pip install --upgrade virtualenv
4.sudo pip install dataserv-client
5. sudo pip install storjkademlia
And now I get:
mat650@NodeITC1:~$ dataserv-client version 2.1.12
So... maybe the Setup procedure need to be reviewed !?

First problem was that: https://github.com/Storj/driveshare-gui/issues/182
The reason for the second one is a old pip version. I will add pip install pip --upgrade to storjnode readme.

Thanks ;)

https://github.com/Storj/storjnode/commit/0ff6b5385131a6f96c8bcea61c807e955bbeebd7


JAVA-2860: Avoid NPE if channel initialization crashes

🤦 I merged to 3.x.
I'll cherry-pick the commit to 3.10.x.


FI-1921: Add reference server

This branch adds functionality to run the reference server locally.

I think we need to clean up the language a little bit.  In reading this assuming no knowledge, I wouldn't know what a 'reference server' is in this context.  I can take a pass at updating the readme and will just push to this branch.


Private Repos on Github

When trying to import a private Repo from GitHub it throws the error: „Clone error: remote credential provider returned an invalid cred type“.

You'll need to enter your GitHub credentials in the settings menu. Note that you'll need to use a personal access token instead of the regular password. See https://docs.github.com/en/github/authenticating-to-github/keeping-your-account-and-data-secure/creating-a-personal-access-token


Private habit status

https://github.com/ita-social-projects/GreenCity/issues/7410

It is good practice to add more description to your PR.


Chore: remove unused totalShares field from PoolStateWithUnderlyings type

I originally left this in because I thought it was needed for getBptAmountFromReferenceAmount which we haven't implemented yet for boosted pools. But looking again it looks like the value is actually updated via an onchain call before calculation so should be good to remove. Thanks!

Good to read that we won't need it. The more we avoid dynamic state from the FE the better.


consul_catalog: incorrect service address

Found that consul_catalog is picking up incorrect address if registrator runs with -internal option. In this case consul has different Address and ServiceAddress, which are respectively consul agent ip and actual service ip.
docker-compose.yml
consul:
  container_name: consul
  image: consul:latest
  command: consul agent -dev -dc=local -node=docker -client=<IP_ADDRESS> -bootstrap -log-level=INFO
  ports:
    - 8500:8500
  environment:
    - SERVICE_IGNORE=true

registrator:
  container_name: registrator
  image: gliderlabs/registrator:latest
  links:
    - consul
  command: -internal consul://consul:8500
  volumes:
    - /var/run/docker.sock:/tmp/docker.sock

traefik:
  container_name: traefik
  image: traefik:latest
  links:
    - consul
  ports:
    - 80:80
    - 8000:8080
  volumes:
    - ./traefik.toml:/etc/traefik/traefik.toml:ro
  environment:
    - SERVICE_80_NAME=traefik-http
    - SERVICE_8080_NAME=traefik-dashboard

traefik.toml
logLevel = "DEBUG"
defaultEntryPoints = ["http"]

[entryPoints]
  [entryPoints.http]
  address = ":80"

[retry]
attemps = 3

[web]
address = ":8080"

[consulCatalog]
endpoint = "consul:8500"
domain = "test"

consul: catalog/node/:name
curl -s $(docker-machine ip):8500/v1/catalog/node/docker | jq
{
  "Node": {
    "Node": "docker",
    "Address": "<IP_ADDRESS>",
    "TaggedAddresses": {
      "wan": "<IP_ADDRESS>"
    },
    "CreateIndex": 3,
    "ModifyIndex": 6
  },
  "Services": {
    "ca523626ca02:traefik:80": {
      "ID": "ca523626ca02:traefik:80",
      "Service": "traefik-http",
      "Tags": null,
      "Address": "<IP_ADDRESS>",
      "Port": 80,
      "EnableTagOverride": false,
      "CreateIndex": 4,
      "ModifyIndex": 4
    },
    "ca523626ca02:traefik:8080": {
      "ID": "ca523626ca02:traefik:8080",
      "Service": "traefik-dashboard",
      "Tags": null,
      "Address": "<IP_ADDRESS>",
      "Port": 8080,
      "EnableTagOverride": false,
      "CreateIndex": 5,
      "ModifyIndex": 5
    },
    "consul": {
      "ID": "consul",
      "Service": "consul",
      "Tags": [],
      "Address": "",
      "Port": 8300,
      "EnableTagOverride": false,
      "CreateIndex": 3,
      "ModifyIndex": 6
    }
  }
}

consul: agent/services
curl -s $(docker-machine ip):8500/v1/agent/services | jq
{
  "ca523626ca02:traefik:80": {
    "ID": "ca523626ca02:traefik:80",
    "Service": "traefik-http",
    "Tags": null,
    "Address": "<IP_ADDRESS>",
    "Port": 80,
    "EnableTagOverride": false,
    "CreateIndex": 0,
    "ModifyIndex": 0
  },
  "ca523626ca02:traefik:8080": {
    "ID": "ca523626ca02:traefik:8080",
    "Service": "traefik-dashboard",
    "Tags": null,
    "Address": "<IP_ADDRESS>",
    "Port": 8080,
    "EnableTagOverride": false,
    "CreateIndex": 0,
    "ModifyIndex": 0
  },
  "consul": {
    "ID": "consul",
    "Service": "consul",
    "Tags": [],
    "Address": "",
    "Port": 8300,
    "EnableTagOverride": false,
    "CreateIndex": 0,
    "ModifyIndex": 0
  }
}

consul: catalog/service/:name
curl -s $(docker-machine ip):8500/v1/catalog/service/traefik-dashboard | jq
[
  {
    "Node": "docker",
    "Address": "<IP_ADDRESS>",
    "ServiceID": "ca523626ca02:traefik:8080",
    "ServiceName": "traefik-dashboard",
    "ServiceTags": [],
    "ServiceAddress": "<IP_ADDRESS>",
    "ServicePort": 8080,
    "ServiceEnableTagOverride": false,
    "CreateIndex": 5,
    "ModifyIndex": 5
  }
]

consul: health/service/:name
curl -s $(docker-machine ip):8500/v1/health/service/traefik-dashboard | jq
[
  {
    "Node": {
      "Node": "docker",
      "Address": "<IP_ADDRESS>",
      "TaggedAddresses": {
        "wan": "<IP_ADDRESS>"
      },
      "CreateIndex": 3,
      "ModifyIndex": 6
    },
    "Service": {
      "ID": "ca523626ca02:traefik:8080",
      "Service": "traefik-dashboard",
      "Tags": null,
      "Address": "<IP_ADDRESS>",
      "Port": 8080,
      "EnableTagOverride": false,
      "CreateIndex": 5,
      "ModifyIndex": 5
    },
    "Checks": [
      {
        "Node": "docker",
        "CheckID": "serfHealth",
        "Name": "Serf Health Status",
        "Status": "passing",
        "Notes": "",
        "Output": "Agent alive and reachable",
        "ServiceID": "",
        "ServiceName": "",
        "CreateIndex": 3,
        "ModifyIndex": 3
      }
    ]
  }
]

traefik: /api (incorrect)
curl -s $(docker-machine ip):8000/api | jq '.consul_catalog.backends["backend-traefik-dashboard"]'
{
  "servers": {
    "server-docker-8080": {
      "url": "http://<IP_ADDRESS>:8080"
    }
  },
  "loadBalancer": {
    "method": "wrr"
  }
}

Oh, never mind. It is fixed at #294 - could you release new docker image? The latest version is v1.0.0-beta.404 which is pretty old.
https://hub.docker.com/r/library/traefik/

In the meantime, you can use the image containous/traefik which is up to date :)


Update devDependencies + Add react 18

I'm currently getting install errors due to react 18 not being supported.

I don't think anyone is going to respond. Did you upload your fix to npm under a different name?

@nikeee @oren-z0 I have just published a new npm package that also supports React 18. It might be helpful.
https://www.npmjs.com/package/easy-react-text-loop
It's not better but it works! :)

I created a (more or less) hard-fork of this project:
https://github.com/pr0gramm-com/react-text-loop-next
Differences:

react 18
removed test that was basically useless
yarn -> npm
prettier -> biome
CI and dependabot
dopped cjs support

Which leads to a lot slimmer and simpler project setup.
We'll publish it to npm as soon as we're ironed stuff out.
If the author of this package wants, they can take the entire code base.


add cmake files to build and install header only library

add simple cmake files to support cmake usage as subproject
optional support install and import of cmake config package files
Pre-merge checklist

[x] I've read CONTRIBUTING.md
[x] I've rebased my changes against the current HEAD of origin/master (if necessary)
[x] I've added new test cases to verify my change
[ ] I've regenerated toml.hpp (how-to)
[ ] I've updated any affected documentation
[x] I've rebuilt and run the tests with at least one of:

[x] Clang 6 or higher
[x] GCC 7 or higher
[ ] MSVC 19.20 (Visual Studio 2019) or higher

[ ] I've added my name to the list of contributors in README.md

Oh, nice! Thanks for this.


Changes GitHub.com Available Seats policy to Compliance

Description
GitHub.com Available Seats Policy Template under the Compliance category
Issues Resolved
N/A
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] New functionality has been documented in CHANGELOG.MD

          1 Error

:no_entry_sign:
Please add a changelog

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


CFNetwork Library is missing

I see that CFNetwork is part of CoreFoundation. But after importing my xcode project with vsimporter, it seems to be that the importer is not aware that CFNetwork is not a standalone lib anymore. I got LNK1181 cannot open Input file 'CFNetwork.lib'. Not a big deal to fix. But not sure if it should be considered somehow from vsimporter or it is one step of tasks I have todo manually afterwards.

@volkrass This issue should be fixed with newer versions of the bridge. Could you please check with the latest release and close the issue if it is resolved?

@nicholasgerard-msft, sure I will do.

Closing this for now – please open a new issue if your problem persists in the latest release of the bridge.


Third party folder is not included in the source code

Hi ,
I am not very much familiarized, but how do we generate the /source/ThirdParty folder  ?
It is in released packages but not in source.
We want to actively contribute.
Best,
Dimitrios

It's from https://nodejs.org/en/download/, pick e.g. Windows Binary(.zip) 64bit and drag and drop e.g. node-v16.13.0-win-x64 renaming it to node into third party folder to upgrade node.