V5 Planned Changes

Starting a list of my desired breaking changes, feedback welcome. Likely this release won't happen until 2022-05 or 2022-06 when we can drop Node 12/17 support, unless we come up with additional breaking changes we want to release sooner.
Breaking changes for v5:

Drop Node 12 support (end-of-life 2022-04-30)
Drop Node 17 support (end-of-life 2022-06-01)
Drop ESLint v6 support (released 2019)
Add "exports": "./lib/index.js" to package.json to strictly define NodeJS API (ESLint itself made the same change)
Remove consistent-output as a recommended rule, no longer necessary since ESLint v7 validates that test cases provide output when they produce an autofix
Enable additional recommended rules:

prefer-message-ids (message IDs have become best practice, ESLint core enforces this rule already)
prefer-output-null (this will enforce upcoming ESLint v9 behavior from an approved RFC)
https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/254

Update existing rules:

#252

TODO:

Check whether any other changes to make given approved RFCs:

Stricter validation of rule tests
Require schemas and object-style rules

Future major version (v6 or later):

Convert package to ESM or TypeScript?

For reference, V4 was release 2021-10 (CHANGELOG, discussion in #120).

Convert to Typescript is better 🙂

the plugin has supported ts. is there something stopping linting ts code?

I wanted to say convert package to ts

I did not see why devs will import the plugin, so converting to ts seems not compelling to me.

I'm supportive of converting this package to both ESM and TypeScript. Both would improve the internal developer experience (TypeScript especially is great for safely traversing the AST).
Neither of these would really affect consumers since I don't think developers import any utils from this plugin (and they will be prevented from doing so once we add "exports": "./lib/index.js" unless we decide to specifically expose something).

@bmish I'm happy to help out with that if you like (I've converted a few plugins to TypeScript now, including eslint-plugin-jest).

@aladdin-add status update:

I've opened up PRs for all the breaking changes for v5
I think we should consider any conversion to ESM/TypeScript in the future and not in this major release since we already have enough changes
I'd like to do a few more checks before we ship v5 but I think we're almost ready to ship it

should we wait for the eslint v9 to be released, to see if need some more breaking changes?

@aladdin-add unless we have a specific need to wait, I recommend releasing now, and here's why:

ESLint v8 wasn't released until October, so ESLint v9 could be several months away still. If we do end up wanting to make any more changes for ESLint v9, those might just be bug fixes and not necessarily breaking changes. And any such changes would require additional implementation time, further delaying the release.
Based on the current planned changes for ESLint v9, I don't immediately see anything necessitating a change.
Releasing would provide users with a version that is fully optimized for ESLint v8.
Releasing allows us to begin taking advantage of Node 14 features in our PRs.
The sooner we release, the sooner we begin to receive feedback on the new recommended rules.
We already have a sizable set of breaking changes lined up, and these releases become unwieldy when the change list grows too big.
We can perform another release in Q4 if we've gathered worthwhile changes by then.

closing, as v5 has been released: https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/releases/tag/v5.0.0


Restarting shard restarts the bot? (startup messages shown again)

I am asking because when the shard reconnects, the bot again throws in its set startup messages i have set.
I have set 2 startup commands to initiate a cooldown in a certain channel, and a command that just says "im back online". I dont want to see those messages when the shard simply reconnects, if possible.

I can’t replicate this. Are you running the latest version of the bot? (Type .stats)

2.1.0.

It was fixed in 2.1.1 - upgrade to 2.1.2 and it shouldn’t be an issue.

damn, versions are being pushed out fast. if youre sure this fixed it, then it can be closed. ^^


Changed only documentation/comments -- describing the library in README for newcomers

Hi M5Stack and the rest of the team working on this library --
I'm contributing this documentation because I think it's missing...  I hear on forums from a lot of newcomers that they get lost trying to find documentation for the software for M5Stack, and this is meant to be a step in the right direction.  I'm happy to contribute more, as I'm thinking of recommending M5Stack products at a local school to teach coding, but I know they will struggle if documentation is hard to find.
I might make contributions to code as well, such as adding examples, but I will keep this branch strictly limited to changes that have no effect on any existing code, so as to not have a testing burden.

@chipguyhere
I appreciate your pull request !

This is some nice stuff you've done here. Especially the usage section and the lines between line 26 and line 49.
That kind of info is super helpful.


Fix typo socks5h:// -> socks5://

Fix a typo error on socks5 protocol

why do you believe it is a typo?


Correcting description based on code

Since we aren't using <= or >= to compare hence boundary conditions are included.
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

if (num > 10) {
  return "No";
}
if (num < 5) {
  return "No";
}
return "Yes";

will return "Yes" only if num is between 5 and 10 (5 and 10 included).
Follow the logic, by setting num = 5, then num = 10. What gets returned?
Now you tell me, for "Yes" to be returned, is num between 5 and 10 inclusive, or exclusive?
Close this issue, if you are satisfied.


Styled Page Generation

As requested, I have developed a style scheme for the page, and applied it to your script. The style sheet has been in-lined, and any of the static files I used to develop the style have been removed.
Notes
I would recommend that you add some sort of 'formatting' to your numeric values for player-counts; as they appear much better when using 'thousand separators' i.e. commas as opposed to simple numbers with no seperators. See the PHP number_format function for a possible method of doing this.
You can preview the changes here.
Changelog

Page now uses 'material design card' interface; implemented using MaterializeCSS from CDN
All content is contained within a 'container' in the centre of the screen.
Player numbers comparison now laid out side to side.
Colours for Grand Company pie charts have been modified to better match with those used fopr each Grand Company in game - using material design palette.
Added colours to easily identify Heavensward and A Realm Reborn data throughout the page.
Added myself to the License
Better formatting of DB downloads in README
Corrected typographical error in URL of July 2015 DB download

Colour Reference

Description
Primary Colour
Alternate Colour

A Realm Reborn
#673ab7
#ce93d8

HeavenSward
#03a9f4
#81d4fa

GC - None
#9e9e9e

GC - Immortal Flames
#212121

GC - The Maelstrom
#b71c1c

GC - Order of the Twin Adder
#ffc107

Colours adapted from Materialize palette (itself adapted from Google Material Design guidelines)

Data compilation succeeded using this file. Merging.


Error on server startup.

Hello I am running a 1.14.4 PAPERspigot minecraft server.
Whenever I start the server, I get this error in the console.
[Multiverse-Core] "Multiverse-Core v4.1.0-b775" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [Rigby, fernferret, lithium3141, main--, dumptruckman].

See #2000


Next available device id is not picked up, while attaching the disk to VM.

The device id is that is available is not picked up when attaching the disk to VM.
ISSUE TYPE

Bug / Enhancement Report

COMPONENT NAME

Volume

CLOUDSTACK VERSION

4.17 RC2

OS / ENVIRONMENT

MS: CentOS 7 + Hypervisor: KVM
SUMMARY

The device id is that is immediately available is not picked up when attaching the disk to VM.
MariaDB [cloud]> SELECT id, uuid, name, instance_id, device_id, pool_id, size, updated FROM cloud.volumes WHERE instance_id = 3 ORDER BY device_id;
+----+--------------------------------------+-------------+-------------+-----------+---------+------------+---------------------+
| id | uuid                                 | name        | instance_id | device_id | pool_id | size       | updated             |
+----+--------------------------------------+-------------+-------------+-----------+---------+------------+---------------------+
|  3 | 91a90516-ba1f-4201-a525-92e0daf8b06f | ROOT-3      |           3 |         0 |       3 |<PHONE_NUMBER> | 2022-05-09 06:14:26 |
|  8 | 488ece20-a0ba-42a1-928b-0f439bf8717b | DATA02      |           3 |         1 |       3 |<PHONE_NUMBER> | 2022-05-11 05:37:02 |
| 11 | e0731820-864f-45db-8f7c-bf7a68afa526 | LocalDATA02 |           3 |         2 |       4 |<PHONE_NUMBER> | 2022-05-11 05:43:22 |
|  7 | 366c1089-0c4a-4059-b300-00dfa50899e1 | DATA01      |           3 |         4 |       4 |<PHONE_NUMBER> | 2022-05-11 05:46:12 |
+----+--------------------------------------+-------------+-------------+-----------+---------+------------+---------------------+
4 rows in set (0.00 sec)

STEPS TO REPRODUCE

Create a VM
Attach first DATA disk with some device id
Attach second/third DATA disk without device id
Detach and Attach the first DATA disk without device id

EXPECTED RESULTS

The next available device id should be picked up, to attach the disk to VM.
ACTUAL RESULTS

The next  available device is not picked up , while attaching the disk to VM.

Device Ids to 0,1,2,4-33 are are currently allowed. Device id 3 is reserved.

Noticed the max data disks in the latest VMware and Xen versions are set to 59 and 253 in hypervisor capabilites. May be, the device Id support has to be updated accordingly. Closing the ticket, as the next available device id is picked, after skipping the reserved ones.


How to remove the max-width limit of the theme

I'm using the them to build a documentation of a graph and widget package. I need as much width real estate as I can and the main content seems to be subject to an upper limit. How can I customize this value or which pst variable should I override to widen my content on bigger screen ?

I think you should follow the steps in https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/layout.html#horizontal-spacing

thanks a lot that was exactly where I didn't look, right under my nose.


Shape issues in tf.keras.metrics.SparseTopKCategoricalAccuracy with multiple dimensions (previously #36985)

Might not be a bug could be my application. But if that is the case I feel the documentation should be edited as from reading those functionality seems to be similar.
When I run this:
target = tf.constant([[1,1,2,0,0,0],[1,1,2,2,0,0]])
predict = tf.constant([[[0,1,0],
                       [0,1,0],
                       [0,0,1],
                       [0,1,0],
                       [1,0,0],
                       [1,0,0]],
                       [[0,1,0],
                        [0,1,0],
                        [0,0,1],
                        [0,0,1],
                        [0,1,0],
                        [0,1,1000]]], dtype=tf.float32)

print(tf.shape(target))
print(tf.shape(predict))

mask = tf.math.logical_not(tf.math.equal(target, 0))

mask = tf.cast(mask, dtype=tf.int64)

loss = tf.keras.losses.SparseCategoricalCrossentropy(
        from_logits=True)
loss(target, predict, sample_weight=mask)

tf.Tensor([2 6], shape=(2,), dtype=int32)
tf.Tensor([2 6 3], shape=(3,), dtype=int32)
<tf.Tensor: shape=(), dtype=float32, numpy=0.3216761>

Works as expected. But when I try it for TopKAccuracy I get this:
m = tf.keras.metrics.SparseTopKCategoricalAccuracy(k=1)
m.update_state(target, predict, sample_weight=mask)
m.result.numpy()
InvalidArgumentError: Can not squeeze dim[1], expected a dimension of 1, got 6 [Op:Squeeze]

In the documentation, both of them have the same definitions for y_true, y_pred and sample_weight. So not sure why the applications seem different here.
This may be my misuse, but not clear regardless. Any help would be appreciated.

@dfossl
Please post this issue on keras-team/keras repo.
To know more see;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999
Thank you!

Sounds good!


Question regarding selectability / 'focusabilty' of wrapped content

i have two components in my app with these templates that have content wrapped by vue-draggable-resizable (named widget-box in the app's context):
<template>
    <widget-box id="browser" :x="0" :y="0" :w="400" :h="600" :parent="true">

Items

      <button @click="getItems">Get items</button>

{{ item.name }}

    </widget-box>
</template>

<template>
  <widget-box id="settings" :x="420" :y="0" :w="200" :h="300" :parent="true">

Settings

    User name
    <input v-model="username"/>
    User token
    <input v-model="usertoken"/>
  </widget-box>
</template>

I can observe the following behaviours:

all resizing and dragging works charmingly.
the button element in the first component is clickable and emits the click event as expected.
the content that is loaded into the component's li elements cannot be selected. i want to enable that for some parts of the contents for the user.
none of the input elements gets the focus when clicked on. that makes these unusable.

i'd appreciate hints how to address the shortcomings mentioned in the last two points and would contribute documentation extensions from what i learn.

That is a known issue, because the VDR instance prevents the default behavior of events inside it, otherwise dragging may be problematic. Unfortunately I don't know how to distinguish between a standard event (for example focus, click, scroll on touch devices) and the event that triggers dragging.
You can easily solve this problem by using a drag handle, because outside this area the events are dispatched correctly.


[core] local IPFS node?

Is this the reason why jobs take too long

Wait, wait @arsen3d the end goal for this task is to find the ideal solution or if it cannot be done, document what is going on until us or the bacalhau team can provide the long term fix.
Reopening.

Yes. It's about the way "bacalhau get" attempts to get the file. Workaround is to use "ipfs get" which works in under 7 seconds.
There maybe a way to fix "bacalhau get", but I was not able to get to the bottom of it.

Can you please show me how to reproduce your testing here and how to get your UI work going so I may test this patch? I believe I can improve the speed further with IPFS peering/preload, at which point we should see < 2 second retrieval and can consider this solved until we get a more permanent fix from the Bacalhau team.


SCMOD-13295: Upgrade okhttp and okio

https://portal.digitalsafe.net/browse/SCMOD-13295
Pending resolution of issue running tests in a dependant repo using this version

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/JobService/job/JobService~job-service-client~SCMOD-13295~CI

Closing this. If we want to use the newer okhttp3 package we will have to move to the OpenApi codegen plugin.


friday_virtual_assistant

friday_Voice_assistant Is an app build using Flutter and using OpenAI API ;
-----------------i had made a PR by commit meesage      "a virtual assistant _jarvis_friday"----------
It can speek to you and you ask any questions like of chatgpt and also
!!!! You can ask and type to get a random image of your own imaginations for example
example --------A man coding in laptop on jupyter
But you have to create  your own OpenAI  API which will be available in the openai.com and assign it to API_KEY  in the code;
Once please go through this and merge it hacktoberfest_23 :)

attach screenshots plz

okay , sure )

I had attached some images , screenshots once kindly check these : )

once go through this and merge it , kindly inform for further modifications : )

looks good. Thanks for contribution.

Hi ,
In the hacktoberfest_23 website it is showing that this repo is excluded or against the rules of hacktoberfest_23 can you please change and maintain the repo according to the rules of hacktoberfest

Hi ,
In the hacktoberfest_23 website it is showing that this repo is excluded or against the rules of hacktoberfest_23 can you please change and maintain the repo according to the rules of hacktoberfest

Can you please change the repo in such a way that it should obey the rules of hacktoberfest_23 ____
As, This PR is excluded, due to this repo is not obeying the rules of hacktoberfest_23


Plugin Informix

Plugin / UI etc.
Support jbdc informix
Plugin to capture querys that run on the informix database engine.

Is it in the project plans to implement querys capture characteristics towards informix?


⚠ Bofrost.com has degraded performance

In 2f5406e, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 570 ms

Resolved: Bofrost.com performance has improved in 87fcfb1.


Insertion should be aborted after first row with constraint violations

If user inserts multiple records within single insert like:
insert into table values (1, 2, 3), (<smallint::max>, <smallint::max>, 0), (<smallint::max>, 0, 0);

An insert should be aborted after (<smallint::max>, <smallint::max>, 0) record. However, error still should report two constraint violations for the first and the second columns
Nice to have record index in the error message
Good entry point is to examine the following test https://github.com/alex-dukhno/database/pull/152/files#diff-ae39057dfc859e4b9cf67396d323baeeR449

Interesting question is how to report errors when user updates record with SET col1 = <max_value> + 1.

@alex-dukhno could you assign this to me? Thanks.

@AndrewBregger are you going to work on both issues? If so please create separate PRs for each, I don't want that one blocks the other.
Thanks

Interesting question is how to report errors when user updates record with SET col1 = <max_value> + 1.
To answer what I think about this question. I think updates should follow the same rules for this as insert does. When an error occurs during an update the entire operation should be aborted and any operations completed operations should be undone.

In the situation you give, the first row would generate an error; therefore, the rest of the rows would not be processed due to the error.
Let's say an error occurs on a column where we are performing set col1 = col1 + 1 and col1 already is max_value> and this column is in the middle of the table. The operations that have already been performed should be discarded, the rest of the rows should be ignored, and an error generated.
What do you think?

Seems like I have very unordered ideas ... https://github.com/alex-dukhno/database/issues/153#issuecomment-655419623 is more relevant to an idea in #154


[rdom] $klist does not update its elements correctly?

Hi,
I'm new to umbrella/* and I'm having some issues with rdom/$klist. Here's the example that I have:
import { defAtom } from<EMAIL_ADDRESS>import { div, h1, li } from<EMAIL_ADDRESS>import { $compile, $klist, $list } from<EMAIL_ADDRESS>import { fromAtom } from<EMAIL_ADDRESS>import { indexed } from<EMAIL_ADDRESS>
const arr = defAtom([
  { id: 1, val: 1 },
  { id: 2, val: 2 },
  { id: 3, val: 3 },
  { id: 4, val: 4 },
])

$compile(div({},
  h1({}, '$klist:'),
  $klist(
    fromAtom(arr).map((arr) => [...indexed(arr)]),
    "ul",
    {},
    ([index, { id, val }]) => li(
      {
        onclick: () => arr.resetIn([index, "val"], val * 2),
        style: { cursor: "pointer" }
      },
      `${id}: ${val}`
    ),
    ([_, { id }]) => id
  ),
  h1({}, '$list:'),
  $list(
    fromAtom(arr).map((arr) => [...indexed(arr)]),
    "ul",
    {},
    ([index, { id, val }]) => li(
      {
        onclick: () => arr.resetIn([index, "val"], val * 2),
        style: { cursor: "pointer" }
      },
      `${id}: ${val}`
    ),
  )
)).mount(document.body);

I'm expecting the values to be correctly multiplied by 2 but it's only working for $list, am I doing something wrong?
Btw, I'm really loving your work! I've been watching it for a while now but it felt overwhelming at the time...
Thank you for your time,
Arnaud.

Hi @arnaudchenyensu - thank you so much for getting in touch about this. I know some of the packages can be a bit challenging to get started, but this kind of feedback is very helpful to also learn about what newcomers are struggling with...
In this case, the solution is actually very easy and before I explain it, I also want to point you to this part of the $klist docs:
https://github.com/thi-ng/umbrella/blob/c0731fab1ab9fd30181f97b1da82858df99c5384/packages/rdom/src/klist.ts#L21-L22
So in other words, a list item's unique key value MUST be not just unique in terms of structure (e.g. like your ID attrib), but also take into account something else, e.g. the item's current value. This is because internally $klist only identifies list item changes via changes to these composite keys and nothing else. So with that said, a possible easy solution here would be using this as key function for your $klist:
([_, { id, val }]) => `id${id}:${val}}`

Altogether:
$klist(
    fromAtom(arr).map((arr) => [...indexed(arr)]),
    "ul",
    {},
    ([index, { id, val }]) =>
        li(
            {
                onclick: () => arr.resetIn([index, "val"], val * 2),
                style: { cursor: "pointer" },
            },
            `${id}: ${val}`
        ),
    ([_, { id, val }]) => `id${id}:${val}}`
),

Hope this all makes sense. I'll update the comment & mini example in the klist docstring to make this behavior more obvious... If you've got any other ideas, please do let me know! 👍

Hi @postspectacular, thank you for your answer, it's a lot easier to understand. To be honest, even by reading the docs of $klist I find it hard to understand that the function was expecting something else than just a "normal" id. If you rephrase it just like your answer, it would be perfect :)
As a personal feedback, because I'm coming from a React/Vue/etc. background, I was expecting all the values to be tracked/reactive by default. For example, I was expecting the style attribute to change automatically (took me a while to understand that I needed to use fromAtom(val).map):
style: { "background-color": val.deref() === 1 ? 'blue' : 'white' }

I would also recommend putting an example with $list/$klist on rdom's readme. I thought that as long as I start the root of my tree with a stream (e.g div({}, fromAtom(), ...)) my list elements would update automatically.
Again, it's just a personal/first impression/on boarding feedback, not a criticism :)
Keep up the good work!

Understood & thank you for the feedback! I've updated both the docs and the readme, hopefully making the behaviors a little more clear! :)
As for the auto-tracking & everything reactive by default - that's exactly why all of these other tools require their enterprise-scale elaborate/complex pre-processing/transpilation tooling, something I've been strictly & fundamentally avoiding with all projects in this repo. In rdom, there's no "magic" reactivity or any form of centralized/auto-managed behind-the-scenes coordination and all reactivity and other control flow is forced to be explicit (by design). This not only provides super fine-grained control (see thi.ng/rstream & thi.ng/transducers for various reactivity/transformation building blocks), but also allows rdom to be absolutely nimble, components to be super simple, perform minimal updates (without any need for diffing) & IMHO is easier to reason about. I'm well aware this approach is not popular in the wider JS/frontend community, but in other language camps (e.g. Clojure, now also Zig) this "no hidden control flow" attitude is seen as one of the main design principles & net positives, even if it makes some parts more verbose...
As a more general comment about the design of umbrella packages: Most of the provided packages here started out as relatively low-level building blocks and basis for (slowly) building up higher level tooling/convenience layers, to experiment with different techniques & approaches. For years, I've been doing that myself, but also was always kinda hoping/relying that other people would do so too (and then maybe even share/feedback some of those results - not so much, yet...). This design approach & focus on composability is totally counter to the much more popular all "batteries-included" or "zero-conf" myths and their constant re-invention of the wheel...


Using IS4 with "old" MVC 5

Hi there, as the title suggests I'm using IS4 with MVC5. IS4 is great, but I think I'm having problems with MVC5 implementation of Authentication.
For MVC5 I followed IS3 tutorials and set it up like this:
AntiForgeryConfig.UniqueClaimTypeIdentifier = "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier";

            app.UseCookieAuthentication(new CookieAuthenticationOptions
            {
                AuthenticationType = "Cookies",
                CookieHttpOnly = true
            });

            app.UseOpenIdConnectAuthentication(new OpenIdConnectAuthenticationOptions {
                Authority = ConfigurationManager.AppSettings["Authority"],
                ClientId = ConfigurationManager.AppSettings["ClientId"],
                ClientSecret = ConfigurationManager.AppSettings["ClientSecret"],
                RedirectUri = ConfigurationManager.AppSettings["RedirectUri"],
                ResponseType = "code id_token",
                Scope = "openid profile api.user",

                SignInAsAuthenticationType = "Cookies"
            });

IS4 is set up by IS4 tutorials and I believe there are no problems with it.
Logout with MVC is done with:
[HttpGet]
        public void Logout()
        {
            Request.GetOwinContext().Authentication.SignOut();
        }

        [AllowAnonymous]
        public void OidcSignout(string sid)
        {
            var cp = (ClaimsPrincipal)User;
            var sidClaim = cp.FindFirst("sid");
            if (sidClaim != null && sidClaim.Value == sid)
            {
                Request.GetOwinContext().Authentication.SignOut("Cookies");
            }
        }

Although I believe the OidcSignout method is never actually called, and that was something IS3 did.
My problem is the same as I had with external auths like Google or Facebook, in that when I  - login with account1 => logout => login with account2/3... I'm again logged in with the account1, or the first account I ever logged in with. This is the same situation I asked about here, and figured that's just the way those providers work, only now it's happening with my own auth provider.
These are MVC Client settings from DB:
AbsoluteRefreshTokenLifetime 	2592000
AccessTokenLifetime 	3600
AccessTokenType 	1
AllowAccessTokensViaBrowser 	0
AllowOfflineAccess 	0
AllowPlainTextPkce 	0
AllowRememberConsent 	1
AlwaysIncludeUserClaimsInIdToken 	0
AlwaysSendClientClaims 	0
AuthorizationCodeLifetime 	3600
EnableLocalLogin 	1
Enabled 	1
IdentityTokenLifetime 	3600
IncludeJwtId 	0
LogoutSessionRequired 	1
PrefixClientClaims 	1
ProtocolType 	N'oidc'
RefreshTokenExpiration 	1
RefreshTokenUsage 	1
RequireClientSecret 	1
RequireConsent 	0
RequirePkce 	0
SlidingRefreshTokenLifetime 	1296000
UpdateAccessTokenClaimsOnRefresh	0

Although I believe the OidcSignout method is never actually called, and that was something IS3 did.

I assume the MVC client has the FrontChannelLogoutUri configured?

My problem is the same as I had with external auths like Google or Facebook, in that when I - login with account1 => logout => login with account2/3... I'm again logged in with the account1, or the first account I ever logged in with

I didn't really follow that, but we keep track of the clients you have logged into by adding those to the authentication cookie within IdSvr. If you change the identity of the user at IdSvr (which means getting a new cookie), then you lose the list of client and they won't get notified at signout (because it's a different user at that point).

Hmm, seems that somehow my DB didn't update correctly on last IS4 update with migrations, so I was missing Back/Front channel fields in my Clients table. Is it enough to set FrontChannelLogoutUri to OidcSignout method to configure everything? If not, could you please explain this help article to me since I don't understand how, for example, would that work if I don't have LoggedOut page, but rather redirect my users back to home page after the Logout.

If not, could you please explain this help article to me since I don't understand how

It's your responsibility to understand the specs. Here's the one in question: https://openid.net/specs/openid-connect-frontchannel-1_0.html

PS. It would also be nice if you added tutorials for this.

It would, but this is a project that's paid for by our free time. It's FOSS, so you can contribute.


iOS 7 Fullscreen

Issue #841 appears to be an issue again in 2.16.4 on iOS7.
Removing/commenting the line(s) that @srator mentioned seems to fix it. Any chance for an updated solution?

@mindblender Is this still an issue?

@ron666 I honestly couldn't tell you.  I've moved onto a different project so no longer maintaining this code.


Create database not suported?

Hi there,
I'm trying this package for the first time and I can't make it work.
2016/01/21 18:38:15 Migrations table not found
2016/01/21 18:38:15 Error creating migrations table: Error 1046: No database selected

if db, err := sql.Open("mysql", *mysqlUser+":"+*mysqlPassword+"@tcp("+*mysqlIp+":"+*mysqlPort+")/")
err != nil {
		log.Fatal(err)
	}

migrator, err := gomigrate.NewMigrator(db, gomigrate.Mysql{}, "./migrations")
migrator.CreateMigrationsTable()

Am I doing something wrong or creating a database is not supported?

You probably can pass the database name as part of the sql.Open string after the / symbol.


Display organization on the dev portal

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BUG] Receiving "Request failed with status code 400" error

I am able to smoothly chat using the "Conversational Retrieval QA Chain" I created. However, after sending around 30 messages, I start receiving a "Request failed with status code 400" error in the chat panel. When I inspect the page, I see the error message "Failed to load resource: the server responded with a status of 500 (Internal Server Error)." I have tried this multiple times with the "Conversational Retrieval QA Chain," and I consistently encounter a similar error. There is no restriction on the limit of the chatbot I am using.
Nodejs version
node -v
v20.3.1

Hi @trda,
Could you share the error logs from your terminal?

[llm/error] [1:chain:ConversationalRetrievalQAChain > 2:chain:LLMChain > 3:llm:ChatOpenAI] [924ms] LLM run errored with error: "Request failed with status code 400" [llm/error] [1:chain:LLMChain > 2:llm:ChatOpenAI] [923ms] LLM run errored with error: "Request failed with status code 400" [chain/error] [1:chain:ConversationalRetrievalQAChain > 2:chain:LLMChain] [926ms] Chain run errored with error: "Request failed with status code 400" [chain/error] [1:chain:LLMChain] [925ms] Chain run errored with error: "Request failed with status code 400" [chain/error] [1:chain:ConversationalRetrievalQAChain] [929ms] Chain run errored with error: "Request failed with status code 400" 2023-07-12 22:27:50 [ERROR]: [server]: Error: Request failed with status code 400 Error: Request failed with status code 400     at createError (/opt/homebrew/lib/node_modules/flowise/node_modules/openai/node_modules/axios/lib/core/createError.js:16:15)     at settle (/opt/homebrew/lib/node_modules/flowise/node_modules/openai/node_modules/axios/lib/core/settle.js:17:12)     at IncomingMessage.handleStreamEnd (/opt/homebrew/lib/node_modules/flowise/node_modules/openai/node_modules/axios/lib/adapters/http.js:322:11)     at IncomingMessage.emit (node:events:523:35)     at endReadableNT (node:internal/streams/readable:1367:12)     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

There are not much information I can look into based on the terminal logs.
Some troubleshoots options:

Check the OpenAI's account billing
Is the OpenaAI API Key correct
Re-create the same flow

I am facing with the same issue, same logs are appearing on terminal.
No problem with the open ai account
API key is correct
It happens on freshly created flows too

Have something similar

The memory's becoming too large and going over the OpenAI token limit.
I used Buffer Window Memory to limit how much it includes, which fixed it.
Flowise should deal with this better though, either truncating the memory, or throwing a better error. Maybe it's supposed to, but some check is slightly off.

I am having the same issue as well


Refactor ClearCommand to ClearPersonCommand

Resolves #53.
Refactored clear command.
Currently, the original behaviour of clear person 3 is not working. Do we need to retain this functionality, or not?

LGTM


Handle TriggerTargets that are combinations for components/entities

Objective
Fixes #14074
It is currently not possible to issues a trigger that targets a specific list of components AND a specific list of entities
Solution
We can now use ((A, B), (entity_1, entity_2)) as a trigger target, as well as the reverse
Testing
Added a unit test.
The triggering rules for observers are quite confusing:
Triggers once per entity target
For each entity target, an observer system triggers if any of its components matches the trigger target components (but it triggers at most once, since we use an internal counter to make sure that an observer can run at most once per entity target)
(copied from #14563)

I feel like I leveled up my macro skills on this one.


Published gems?

Is a packaged version of this gem still being published somewhere?  Looking at Rubygems https://rubygems.org/gems/sqlite3-ruby/versions the last version published there is 1.3.3 back in 2011.

The gem is just called sqlite3.  Hope that helps!


Svi

Minibatch style optimization for GPflow. See also #7

Hi Mark,
What do you think about changing "minibatch" to "minibatch_size"? It seems a bit misleading at the moment. I'm happy to do it.
Alex

Sure!

OK that's done. Well done on becoming a GPflow contributor @markvdw .


Mobile approach?

Carbon sketch components seem to me focused on desktop apps. I do see a couple of elements in a mobile view. I wonder if there's guidance on how to use the elements in a mobile context, that I'm missing.
In particular, thinking about iPhone development - how do the Carbon elements correlate to iOS elements, and navigation flow. Or does it matter?

Maybe @aagonzales can give more clarity on this, but as far as I know, all components are designed with breakpoints in mind. Since Carbon started as a very product-specific system, a lot of the components are created desktop-first and we make sure that they're responsive on smaller viewports.
As for your question about iOS, we've been more focused on usage within a web browser. All of our "elements" closely correlate with HTML elements where possible so that mobile OSes can interpret them as expected.
For example,
Number Input, (<input type="number">) would trigger a Number Keypad on a users device when focused.

I understand, and very much respect the honesty in the answer. It is a major achievement to create a style guide for the web, and I'm more convinced about the value of it having used it now :)
The app I'm designing and building is a web app and a desktop app. That is pretty much normal. I struggled to use the components for a web app, especially as someone who designs web apps with a strong understanding of iOS view components ... and if I was daring there are no watch ideas in there either ;)
I appreciate the design components for how they sped me along with my bluemix influenced design.
But why not take it to the next level? Think ahead ... we already have an iOS app for Bluemix in the formative stages. We should be thinking mobile first. And I can even see a few amazing and exciting opportunities for a watch app too. It'd show even more mastery to evolve the design system that far.

Cross referencing to my other comment about a quick video intro to using the components ... maybe that video, or a related one, could also show how to use them for a mobile app.

In particular, thinking about iPhone development - how do the Carbon elements correlate to iOS elements, and navigation flow. Or does it matter?

Carbon does not current have native iOS or Android components. Bluemix does have native apps in development but we have no incorporated those elements directly into Carbon yet. Native apps have very different core function and interactions than websites. Even the difference been Android and iOS can be huge. We understand this and its why we don't say our components work for native apps, especially watch components.
Carbon came from the need of Bluemix which is web app but as we grow and more teams use it adding in a iOS and Android components will be the logical next step. But for now our resources are limited and we remain web focused for the time. We always welcome collaboration and teams contributing back to the system so if you'd like to use you're great knowledge of the iOS space and contribute guidelines or native components back to the system it would be more than welcomed!
As Brian said from the product level most of our users are desktop or larger screen users and therefore the product is not mobile first. However, from the Carbon side of things we try and make all our our components completely responsive. Some components don't have "mobile" counter parts in the kit because their widths are the only thing that change. If you're ever curious how a component responds and you don't see it in the kit you can check on the "view full render" states on the code page and drag the browser around to see it demonstrated live.

All that said, the long term vision of Carbon is to create a set of components that could be used on Android/iOS (I can imagine us building react-native components or something depending on what the driving framework is). Not in the current timeframe though, unfortunately!


mobile browser support

Hello.
I am trying this library and it seems like it does not work with mobile browsers.
I tested with Safari and Chrome with my iphone xs and ipad. It cannot read the storage.
Can you please check this?

Same issue!

Have you found a solution for this?

@Andresdamelio  no. decided not to use this solution. switching to other work around.


Infinite chart refreshing (redrawing) in embedded view

When I put the chart inside of a view and use it as an embedded view in another view the chart keeps redrawing forever in runtime mode.

This is only happend in 1.0.8 and not 1.0.6

I will look into this problem over the weekend.

Hi Travis
Did you get some free time to check it? I really stuck with this as 1.0.6 doesn't work with goal setting and 1.0.8 cause this problem and I need time range chart at same time.
Thanks in Advance

Fixed this issue in 1.0.9:
https://github.com/Kyvis-Labs/ignition-apexcharts-module/releases/tag/1.0.9
Can you verify and close the ticket?

Thanks Travis It is fully working now


WIP Way to multiplatform

@thake can you provide how you did the benchmark ? Then I would also like to do it on my branch 😄


Fix missing DarkSky mdi icon

Breaking Change:
None
Description:
Fix mdi icon for DarkSky in 0.98. Icon's name has changed from weather-partlycloudy to weather-partly-cloudy
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
  - platform: darksky
    api_key: !secret dark_sky_key
    forecast:
      - 0
    monitored_conditions:
      - icon

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Thanks ! Will be in 98.1

cool. since this is now fixed in the backend, will it be available for the other weather integrations also?
to the point: can we do this now:
      - tab:
          'weer_klimaat':
            icon: >
              var weer = entity['weather.woensdrecht'].state;
              'mdi:weather-' + weer;

see: https://community.home-assistant.io/t/error-in-condition-classes-buienradar/132804?u=mariusthvdb

@Mariusthvdb These fixes were all for sensors not for weather platforms.  The weather condition is still partlycloudy that maps to this icon.  See here for the mapping on the frontend.
https://github.com/home-assistant/home-assistant-polymer/blob/a042cd2d48ae2c6f03fdae1c9c30cdfa1d7b6b28/src/cards/ha-weather-card.js#L288

check, I am aware of that, once my question.
This would seem a great time to adjust both sensors and westher components all to use the mdi naming.
Also, it would give the opportunity to add the -day and -night variations. So eg we don't see a mdi:sun during a clear-night ;-)
btw, noticed OWM wasn't changed yet


Arakaali's Fang broke application

To start off I have a melee summoner build I've been working on including Arakaali's Fang and the scourge, today when I opened up the build for it and went to the skill's window I got this error:

After hitting F5 to refresh I could again use the other tabs as normal, as such thinking the build just got corrupted somehow I deleted it and made another.
During the process of making the other I suspected that it was one of the two weapons summon ability that caused as there was always a skill produced from one of them but since it didn't effect anything I just ignored it. As such I added Terror claw and checked the skills tab but nothing showed up. I then added Arakaali's Fang which did indeed add a skill to the window. Here's were it "broke application" comes into play. Noting that I could see the skill produced by the dagger in the skill window and not getting the above message I decided to see if I could reproduce the bug by saving and reopening the build. After saving the build and hitting back to my build list I got the above error again, hitting F5 just produced the same error as does restarting the application. In order to get Path of Building working again I had to manually go in and delete the build xml so it would launch again.

Just did some more testing, I couldn't get the entire application to break again but I was reliably able to reproduce the skill tab breaking issue. All I did was make a build with Arakaali's fang, saved it, and left. After re-entering the build the skill tab would be broken.

It seems the program is processing the "Raise Spiders on Kill" modifier, but it's breaking the granted skill code because the Raise Spider skill isn't supported yet.
I'm going to fix this in two ways:

I'll add a check to the granted skill code to prevent this error from occurring again
I'll add support for Raise Spider :)


conan: Conan recipe fixups

This PR contains various fixes for issues the Conan.io CI had with our conanfile.
We need to merge this to get simfil to conan.io, as the current CMake does not work on their CI.

https://github.com/conan-io/conan-center-index/pull/22842

LGTM!


revise TinyMCE buttons

The Edit HTML Source button should be removed, as it brings more confusion in editing text (at least if not all styling possibilities are converted to MEI).
On the other hand it would be good to have a "double underline" button, as this can be found often in musical sources.

Yes, probably a good idea.


Flatten lists for ancestors for hyint to prevent nested lists.

Before you start, please read our contribution guidelines.
Please discuss your idea with the development team before getting started, to avoid disappointment later. The way to do this is to open a new issue on GitHub. If you are planning to modify an existing functionality, please discuss it with the original author(s) by tagging them in the issue.

Tasks

[x] Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
[x] Give this pull request a descriptive title that can be used as a one line summary in a changelog
[x] Make sure your code is composed of functions of no more than 50 lines and uses meaningful names for variables
[x] Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
[ ] Preferably Codacy code quality checks pass, however a few remaining hard to solve Codacy issues are still acceptable. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
[ ] Please use yamllint to check that your YAML files do not contain mistakes
[ ] (Only if really necessary) Add any additional dependencies needed for the diagnostic script to setup.py, esmvaltool/install/R/r_requirements.txt or esmvaltool/install/Julia/Project.toml (depending on the language of your script) and also to package/meta.yaml for conda dependencies (includes Python and others, but not R/Julia)
[ ] If new dependencies are introduced, check that the license is compatible with Apache2.0

New recipe/diagnostic

[ ] Add documentation for the recipe to the doc/sphinx/source/recipes folder and add a new entry to index.rst
[ ] Add provenance information

Modified recipe/diagnostic

[ ] Update documentation for the recipe to the doc/sphinx/source/recipes folder
[ ] Update provenance information if needed
[ ] Assign the author(s) of the affected recipe(s) as reviewer(s)

New data reformatting script

[ ] Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
[ ] Add the new dataset to the table in the documentation
[ ] Tag @mattiarighi in this pull request, so that the new dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

Modified data reformatting script

[ ] Test the CMORized data using recipes/example/recipe_check_obs.yml, to make sure the CMOR checks pass without errors
[ ] Tag @mattiarighi in this pull request, so that the updated dataset can be added to the OBS data pool at DKRZ and synchronized with CEDA-Jasmin

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.

Closes #1716

In principle it should work (run successfully yesterday) but I need to run an additional test if the better implementation of the "flatten" function into hyint_functions.R works.

Thanks!
Let me know when ready.

Thanks, recipe_hyint_extreme_events.yml and recipe_hyint.yml both run now!

We are left with #1718.


Prevent accessibility of login when coming in through status fqdn/cname

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
First of all, thanks for such a brilliant and easy to setup piece of software! I started using it yesterday and have almost my whole home lab monitored through it already.
I am making my kuma's status page available from the internet via traefik (using a cname and the domain parameter in the status settings) and that's working well. This however still allows access to the /dashboard path where an external attacker could try to brute force my kuma install.
I subsequently blocked access to the /dashboard PathPrefix in the traefik configuration but am wondering whether this is enough? Could login still be attempted through other paths, for instance by posting credentials directly without first loading the login page?
Thanks!
🐻 Uptime-Kuma Version
1.15.1
💻 Operating System and Arch
Docker in lxc on Proxmox, x64
🌐 Browser
curl, python, Chrome with some plugins... anything an attacker could use
🐋 Docker Version
20.10.11
🟩 NodeJS Version
No response

Maybe not enough, because admin function can be done in WebSocket connection directly.
I may plan to add checkbox for if domains added as a status page domains, it will not be allowed as the dashboard link.

Hey @Alestrix and @louislam, is it possible to monitor internal services (using fqdna) with uptime-kuma? For an example, I want to monitor nginx.default.svc.cluster.local. I tried, but it still fails. I think it is polling this url as a public endpoint. Any help?

@louislam Do admin functions have dedicated api paths, separate from those used to display the monitors? If so, I should be able block them in traefik just like normal http(s) requests.
@iamdempa Your question is not related to this issue and shouldn't be discussed here. Moreover, it's more a Kubernetes question than an uptime-kuma question. But in short: If the fqdn is resolvable and the ip and port accessible from the pod your kuma install runs on (check with kubectl exec), then sure, you can monitor it.

Normally, it should be ws://<domain>/socket.io/?EIO=4&transport=websocket.
Or if it is possible, you can just  block all Websocket connections for your domain.

Or if it is possible, you can just block all Websocket connections for your domain.

I don't think traefik can distinguish between websocket and regular http. But it is possible to block all paths starting with socket.io. I'll have a run at it during the coming days.

I may plan to add checkbox for if domains added as a status page domains, it will not be allowed as the dashboard link.

Hi @louislam, has this been implemented without me noticing? :-)


Remove thread restrictions for configuration

I use Quandl together with sidekiq and the jobs do not pick up on the api_key set in the initializer. Using class variables solved it for me, but maybe you have a reason for using thread-based variables.

Hi @cptobvious. Rather than removing the thread support entirely what about setting the default as a class variable. That way if you need to change it on your thread you can without affecting other threads.

@cptobvious We have new version 1.0.3 which should fix the problem you are having. Hopefully this new version works better for you.

@mbasset Thank you for this update!


Readme needs work

Cloned the repo, went to run npm install devbridge-styleguide --save-dev
and got

npm ERR! Darwin 15.4.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "devbridge-styleguide" "--save-dev"
npm ERR! node v5.10.1
npm ERR! npm  v3.8.3
npm ERR! code ENOSELF
npm ERR! Refusing to install devbridge-styleguide as a dependency of itself
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/steven/Frontend/triservicereg/npm-debug.log

You are trying to install styleguide inside itself.
You don't need to clone the repo because copy of it resides on npm. Just create empty project, in your CLI navigate to your project root directory and run npm install devbridge-styleguide --save-dev.


test(rpc): Add a script for comparing zcashd and zebrad RPC responses

Motivation
This PR adds a script that compares zcashd and zebrad RPC responses.
Designs
Make sure you have zcashd and zebrad installed and synced.
The script:

gets the zebrad and zcashd tip height
sends the RPC request to both of them using zcash-cli
compares the responses using diff
leaves the full responses in files in a temporary directory

Assuming zebrad's RPC port is 28232, you should be able to run:
$ zebra-rpc/rpc-diff.sh 28232 getinfo
Checking zebrad tip height...
Checking zcashd tip height...

Request:
getinfo

Querying zebrad at height 1647596...
Querying zcashd at height 1647596...

Response diff (between zcashd port and port 28232):
--- /run/user/1000/tmp.xbErphtmZ5/zebrad-1647596-getinfo.json   2022-04-27 16:04:33.204502270 +1000
+++ /run/user/1000/tmp.xbErphtmZ5/zcashd-1647596-getinfo.json   2022-04-27 16:04:33.207502243 +1000
@@ -1,4 +1,16 @@
 {
-  "build": "v1.0.0-beta.8+32.g5cc84c8",
-  "subversion": "/Zebra:1.0.0-beta.8/"
+  "version": 4070050,
+  "build": "v4.7.0-gitian",
+  "subversion": "/MagicBean:4.7.0/",
... (more extra fields) ...
 }

Sometimes zcashd will have extra fields (+) or different data.
And sometimes it will have the same data, but in a different order.
Solution

Add a script which compares zebrad and zcashd RPC responses

Closes #4130.
Review
Anyone can review this PR.
Reviewer Checklist

[ ] Code implements Specs and Designs
[ ] Tests for Expected Behaviour
[ ] Tests for Errors

Follow Up Work

compare all the RPCs
fix all the bugs

Should we locate it in zebra-utils instead of zebra-rpc ?

I moved it to zebra-utils, and added some documentation in the README.
I also made the script's error handling a bit better.


fflas-ffpack: 2.2.2 -> 2.3.2

Motivation for this change
fflas-ffpack was outdated.
This updates it, makes it more reproducible / less error-prone and enables checks.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I am not sure Nixpkgs is usable on any x86 CPU without SSE. SSE4 is another story, of course. Not sure where to draw the line…

For what its worth, arch and debian both disable it in their packages. Gentoo has this
local simd_opt="--disable-avx"
if( (use cpu_flags_x86_avx) || (use cpu_flags_x86_avx2) || (use cpu_flags_x86_sse4_1) ); then
	simd_opt="--enable-simd"
fi

--enable-simd used to be the way to set that option, until somebody upstream complained that its not fine-grained enough and they replaced it with all those other options :/

I rebased on master and changed the commit message (since the update part was already merged in #37628).

@GrahamcOfBorg build fflas-ffpack

Failure on aarch64-linux (full log)
Attempted: fflas-ffpack
Partial log (click to expand)
../configure: line 508: can't create lib/Makefile: nonexistent directory
../configure: line 508: can't create lib/Makefile: nonexistent directory
../configure: line 508: can't create lib/Makefile: nonexistent directory
../configure: line 509: can't create lib/Makefile: nonexistent directory
DONE configure
/nix/store/9vknvj1gnbd2mbci7sw07cy1lgyxxy02-stdenv-linux/setup: line 100: include/atlas_cacheedge.h: No such file or directory
builder for '/nix/store/ppbhwsd89zfhqv9l8j8zrz64m1bwnhvy-atlas-3.10.2.drv' failed with exit code 1
cannot build derivation '/nix/store/cfxdrhbk198r2dr2ivwgzrsw4cmww2ni-liblapack-3.4.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8fmb81p6llvqffmxgwapp8xfr908q6vl-fflas-ffpack-2.3.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/8fmb81p6llvqffmxgwapp8xfr908q6vl-fflas-ffpack-2.3.2.drv' failed

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: fflas-ffpack
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: fflas-ffpack
Partial log (click to expand)
 /nix/store/jy9knxp7nmw80jkf932axrs1b4p9k4hi-coreutils-8.29/bin/install -c -m 644 fflas-ffpack.pc '/nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2/lib/pkgconfig'
make[2]: Leaving directory '/build/source'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2/lib  /nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2/bin
patching script interpreter paths in /nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2
/nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2/bin/fflas-ffpack-config: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/arl8bgjkm35fxpcy1wq7rdgqmsb247qc-fflas-ffpack-2.3.2...

Apparently this fails on aarch64 because its dependency liblapack fails which again fails because its dependency atlas fails.
liblapack never ends up in the fflas-ffpack build closure and apparently openblas provides lapack. Is there any reason to keep that in buildInpugs @7c6f434c? And should we mark atlas as broken for aarch64?

ATLAS seems to have some support for ARM64, but maybe building it is complicated.
Frankly, I haven't yet needed to use something where I cared about specific choice of LAS. But sometimes library build systems have interesting preferences (and I forget to revisit the situation when they get better). So, dropping the dependency is fine with me if it builds.

In https://github.com/NixOS/nixpkgs/issues/10808 it sounds like it would be relatively unproblematic to just disable atlas for aarch64.

Dropped the dependency in https://github.com/NixOS/nixpkgs/pull/39384.

I've been meaning to add more x86_32 variants.


progress image

Hi, could you help me to show progress bar in side search text box of select2 theme when data is fetching from service for dropdown while typing.

Closing as a support issue.


Problem to submit a form with a custom element

Description of bug
I think that the form has to be submitted, but i don't know if i'm forgetting something, so is it a problem of the uniform or i'm using it at the wrong way?
To Reproduce
1 - Create a form with unform and a custom element as a child
2 - Create a file input with the useField in the child component
3 - Try to submit it
Expected behavior
I think that the form has to be submitted, but i don't know if i'm forgetting something, so is it a problem of the uniform or i'm using it at the wrong way?
Exception or Error
Parent Component:

import React from 'react';
import { useDispatch, useSelector } from 'react-redux';
import { Form, Input } from '@rocketseat/unform';

import { updateProfileRequest } from '~/store/modules/user/actions';

import AvatarInput from './AvatarInput';

import { Container } from './styles';

export default function Profile() {
  const dispatch = useDispatch();
  const profile = useSelector(state => state.user.profile);

  function handleSubmit(data) {
    dispatch(updateProfileRequest(data));
  }

return (
    <Container>
      <Form initialData={profile} onSubmit={handleSubmit}>
        <AvatarInput name="avatar_id" />

        <Input name="name" placeholder="Nome completo" />
        <Input name="email" placeholder="Seu endereço de e-mail" />

        <hr />

        <Input
          type="password"
          name="oldPassword"
          placeholder="Sua senha atual"
        />
        <Input type="password" name="password" placeholder="Nova senha" />
        <Input
          type="password"
          name="confirmPassword"
          placeholder="Confirmação de senha"
        />

        <button type="submit">Atualizar perfil</button>
      </Form>
      <button>Sair do GoBarber</button>
    </Container>
  );
}

Child Component:

import React, { useState, useRef, useEffect } from 'react';
import { useField } from '@rocketseat/unform';
import api from '~/services/api';

import { Container } from './styles';

export default function AvatarInput() {
  const { fieldName, registerField, defaultValue } = useField('avatar');

  const [file, setFile] = useState(defaultValue && defaultValue.id);
  const [preview, setPreview] = useState(defaultValue && defaultValue.url);

  const ref = useRef();

  useEffect(() => {
    if (ref.current) {
      registerField({
        name: fieldName,
        ref: ref.current,
        data: 'dataset.file',
      });
    }
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [ref.current, fieldName]);

  async function handleChange(e) {
    const data = new FormData();

    data.append('file', e.target.files[0]);

    const response = await api.post('files', data);

    const { id, url } = response.data;

    setFile(id);
    setPreview(url);
  }

return (
    <Container>
      <label htmlFor={fieldName}>
        <img
          src={
            preview ||<EMAIL_ADDRESS>          }
          alt=""
        />

        <input
          type="file"
          id="avatar"
          accept="image/*"
          data-file={file}
          onChange={handleChange}
          ref={ref}
        />
      </label>
    </Container>
  );
}

Screenshots

Environment:

OS: Windows 10
Browser Chrome
React Version:  16.10.2
Unform Version: 1.6.1

I had a problem similar to the guy, but the button is not doing the submit action on the form, I don't understand!

@danieldfc It looks like you're not using Unform at all as you're saving the input value inside a component state. Unform doesn't need that. Also, you're passing schema as a Form property but we dropped this since Unform 2.0 was launched.
You can take a look at the migration guide: https://unform.dev/migration-guide

@diego3g  I was not aware of this new update, which is why I had these problems. However, thanks for showing me how I can update to this new version of unform. :rocket:


marsha not installable anymore

Bug Report
Expected behavior/code
When I run init playbook with marsha app I expect no failure
Actual Behavior
Creating masha secrets fails whit this message:
TASK [Actually create the secrets in OpenShift] **********************************************************************************************************************************************
changed: [local] => (item=apps/marsha/templates/app/secret.yml.j2)
failed: [local] (item=apps/marsha/templates/app/secret_cloudfront_private_key.yml.j2) => {"changed": false, "error": 422, "item": "apps/marsha/templates/app/secret_cloudfront_private_key.yml.j2", "msg": "Failed to create object: Secret \"marsha-sshkey-73fcc8eea30738a6b9647f12a9e7ac8f877a64fa\" is invalid: data[%s][ssh-privatekey]: Required value"}
changed: [local] => (item=apps/marsha/templates/postgresql/secret.yml.j2)

Steps to Reproduce

Update your master branch
Run ./bin/boostrap -e "apps_filter=marsha

Possible Solution
Something was removed I think when we worked on creating vaults.

My understanding is that in apps/marsha/templates/app/secret_cloudfront_private_key.yml.j2, the variable DJANGO_CLOUDFRONT_PRIVATE_KEY is required (we default to '' and it doesn't work...).
Instead we should wrap this template in a {% if DJANGO_CLOUDFRONT_PRIVATE_KEY %} because it is not really required (Marsha can work without this key if DJANGO_CLOUDFRONT_SIGNED_URLS_ACTIVE is False ie signed urls is not activated).


Full disclosure on git-gpg weaknesses

I very much appreciate git-gpg README, where survey and criticism of other git encryption solutions is provided. It lacks only one thing - providing truthful discussion of git-gpg's own weaknesses. That makes git-gpg look like the ultimate solution, which it of course isn't. And the main issue is that git-gpg isn't compatible with ... git! That's because instead of using git protocols (or access schemes, speaking widely), it uses rsync. But git server doesn't offer rsync protocol! And no git service, no sysadmin will let you access git repositories with a standalone rsync service (that doesn't make sense and is a security risk). And if you're your own sysadmin, then there're so many ways to solve git encryption problem, that git-gpg is unlikely the brightest of them.
And that's how all the other software you quote differs from git-gpg - good or bad, it allows to work transparently with existing git infrastructure, unlike yours.
So, again, if you like to entertain readers with Hoar quotes when criticizing other software, maybe you'd also want to provide some reflection about your own solution ;-). Or maybe not, up to you.

Fair points. git-gpg isn't perfect. Like anything, it has trade-offs.
In this case, git-gpg fits my needs better than other solutions. Specifically, I needed a way to synchronize private files between trusted endpoints under my control, through an untrusted cloud server not under my control. git-gpg chooses tradeoffs that are acceptable for that use case. It sounds like you have different needs.
To address your points individually:

git-gpg isn't compatible with git. - True.  True. But it uses rsync-over-ssh, which is a more common transport method than git. Honestly, I didn't think too much about the transport mechanism (or, referring back to the previous concern, the storage system). I chose the simplest thing that worked. A motivated developer could extend git-gpg to use git as the transport protocol and storage mechanism, and it should work just fine. I personally think it adds unnecessary complexity.

No sysadmin will let you access git repositories with a standalone rsync server. - I'm definitely not advocating that you run an rsync service. As you point out, it is not secure. rsync automatically uses ssh when available. Perhaps I should have mentioned this in the docs, but in my mind it's fairly widespread knowledge.

If you're your own sysadmin, [there are better ways to] solve the git encryption problem. - I disagree, and would love to hear your suggestions. I'll happily switch to a better solution, it means less code to maintain.

Thank you for your thoughtful comments, I think others will find value in this discussion, and I've updated the README to describe git-gpg's tradeoffs.


Randomly losing keymaps

I use the default setup with the exception of setting , as my leader for conjure. Majority of the time I have no issues but occasionally when I open a new clj file the key map is gone and the only way I can get it back is to close down neovim. Any ideas what might be happening? It isn’t any specific file. On a typical 8 hour day I might see it a couple times.
Is there a quick way to reload the keymaps in the file thats missing them?

Sorry! I thought I'd responded to this, hard to keep track sometimes I'm afraid. This sounds like a really weird bug that I've never encountered, I suspect it's interplay with another plugin but can't be sure. Did you manage to resolve it or did you have to stop using Conjure? Just for future reference.


BAMT 2.0.0 - new features, refactoring, architecture refreshment

Current BAMT architecture has a number of disadvantages, some clunky code and other limitations. Thus, it was decided to make a full refactoring. This refreshment will not only include new refactored code and API but also new features (like vectorized sampling and other operations, new algorithms for structure learning, score-functions etc.)
For now, here is a checklist of modules that should be implemented in 2.0.0 architecture:

[ ] core

[ ] Graph

[ ] DAG

[ ] Nodes

[ ] root nodes

[ ] discrete root node
[ ] continuous root node

[ ] child nodes

[ ] conditional continuous node
[ ] conditional discrete node

[ ] Node models

[ ] Prediction models

[ ] Classifier
[ ] Regressor

[ ] Distribution models

[ ] Empirical distribution model
[x] Continuous distribution model

[ ] DAG-opttimizers module

[ ] Constraint-based DAG optimizers (PC)
[ ] Score-based DAG optimizers (HC, evo)
[ ] Hybrid DAG optimizers (inc. BBBN, LSevoBN)

[ ] Score-functions module

[ ] K2
[ ] MI
[ ] BIC/AIC

[ ] Parameter estimators module

[ ] MLE

[ ] Models

[ ] PGM

[ ] BNs

[ ] Continuous BN
[ ] Discrete BN
[ ] Hybrid BN
[ ] Composite BN

The development of BAMT 2.0.0 is held in 2.0.0 branch of the repository. If you, the reader of the issue, have decided to implement some module or submodule, please reply to this message, create a separate issue and add it to milestone and project.

Continuous distribution model has been implemented


chore: remove stream seek constraint

Summary of changes

Changes introduced in this pull request:

Remove AsyncSeek constraint for CarStream. The seek constraint prevents streaming data from, say, an HTTP server.

Reference issue to close (if applicable)

Closes
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

It's technically possible to craft an uncompressed CAR file which will be identified as a zstd compressed file. However, no valid Filecoin CAR file can be misidentified in this way.

Do we have a test that exercice the non-compressed path?

Added a test using the uncompressed genesis CAR file.


Append or merge two JSON objects

We don't have ways to append or merge two JSON objects together.

json_object_update() seems to be the solution


Sema: Ban potential unavailability on enum cases with associated values

This cannot be supported for the same reasons struct and class stored
properties with potential unavailability cannot be supported.
It is possible that some users relied on this, because it worked in
some cases where the type metadata for the potentially unavailable
type was not actually needed for anything (eg, if the type was @Frozen
and trivial, or a simple class reference). If this becomes an issue
we can downgrade this to a warning.
Together with the Float16 availability fix, this fixes rdar://problem/72151067.

@beccadax I'm a bit worried about the source compatibility fallout. If that occurs, we can downgrade this to a warning (as usual with this kind of issue, users will risk hitting linker errors or runtime crashes due to weak-linked symbols being unavailable if they ignore the warning).

@swift-ci Please smoke test

@swift-ci Please test

@swift-ci Please test source compatibility

After thinking about this some more I realized we need to allow @available on stored properties or enum cases as long as the attribute is idempotent, ie the written version is older than or equal to the deployment target. I'll let source compat complete here, but then I'll redo this PR a bit.

I may be misunderstanding this, but wouldn't this limit the evolution of ABI-stable non-@frozen enumerations?
AIUI, we need to able to add new cases to non-frozen enums regardless of whether or not they come with associated values, and new cases will need to come with availability -- otherwise, we we won't be able to add new cases at all.

Oh no -- IIUC, we don't even have syntax for protecting cases in a switch statement with a runtime availability check:
// SDK:
@available(macOS 10.15, *)
enum Foo {
  case old
  @available(macOS 11, *)
  case new(SomeTypeAddedInBigSur)
}

// Client deploying to 10.15:
switch foo {
  case .old:
    print("old")
  @available(macOS 11, *)   // (How do I write this?)
  case .new(let v):
    print(v.someNewMethod())
}

Do we really not support API evolution for enums? 😱

Oh no -- IIUC, we don't even have syntax for protecting cases in a switch statement with a runtime availability check:

We don't need an explicit annotation—in an OS where that case is unavailable, the switch statement will never take that branch.
(I don't know off the top of my head if we implicitly adjust the availability within that case, but if we don't, we absolutely should.)

(I don't know off the top of my head if we implicitly adjust the availability within that case, but if we don't, we absolutely should.)

It doesn't look like we do that yet, but that seems like a great solution! (As long as it's possible to fix the original issue -- as it stands, AIUI we need to discourage adding public non-@frozen Swift enums in ABI-stable interfaces, even in non performance sensitive cases)

@lorentey No, the case you described will totally work, and the incorrect availability context in the case body is a bug we should fix.

@beccadax @lorentey This PR is superseded by https://github.com/apple/swift/pull/36327. The new semantics are looser; you can still write @available on stored properties and enum cases as long as its not newer than your deployment target.


fix: pytz dependency

Describe the bug
In a few Python versions, pytz is not being imported.
Solution
Add pytz as direct dependency

fixed with #180


reduce php binary to minimum

Clone this branch, then run:
docker buildx bake
cp build/* ../phpdoc/web-php/js

You could likely reduce the size more by compressing the final file with Brotli with the highest possible compression level (the webserver will then have to be configured to serve the file as compressed with Brotli without recompressing it).

actually everything is built-in emcc: https://emscripten.org/docs/optimizing/Optimizing-Code.html#how-to-optimize-code and I found -O2 to be the most optimized when it comes to building PHP.

I'm interested to build this reproducibly with Nix!


general UI: Normalize Keyboard shortcuts icon tooltip.

Changes the Keyboard shortcuts icon tooltip to resemble the Drafts/Reply button tooltips.
Before:

After:

Fixes #9446.

@synicalsyntax I don't think this is the right solution; we want to be using the faster JS tooltips (not the HTML title attribute which also doesn't support the faded color for the ?); we just want the styling to be better.


Automated Package Upgrade

:tada: This PR is included in version 28.4.26 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


objmgr cleanup and improvements

Object Manager

objmgr cleanup and fixes

KphObjectAttributesInformation -> KphObjectExtendedInformation, retrieve object address, type index and flags.
Public hndlmenu.h APIs. ID_HANDLE_OBJECTPROPERTIES[1/2] menu support for Device/File, Key, Section handles. Add Security menu item.
Add Name and Original name columns for Device/File, Key, ALPC Port and for any type object from \ObjectTypes.

objmgr cleanup and improvements

Handles tab Refresh (F5) button added. Handles and refs counts on main page will also be updated.
EtTreeViewFindItem add reverse scan for more reliable result.
[Resolver] Extract Section information for more kernel objects using driver.

Add menu - Copy Object Address (Ctrl+Shift+C). Add Ctrl+Alt+C shortcut for Copy Full Name.

Show more correct Reference count in object properties (subtracting RefCnt of PH's opened handle). This is light version of windbg !trueref. For permanent objects with no handles it show exact RealPointerCount.

One object - one properties window. Flash already open window to user.

fix https://github.com/winsiderss/systeminformer/issues/2074

General

Handle list - new column "Handle pointer count". Show nt!_HANDLE_TABLE_ENTRY RefCnt.

[Alex Ionescu] Each time an existing handle to an object is used, the reference count goes down by 1.

Allows to see how processes uses handles in realtime. Minimal code changes, use Reserved filed in KPH_PROCESS_HANDLE and SYSTEM_HANDLE_TABLE_ENTRY_INFO_EX. Works only then driver on, column will be empty in any other scenarios.

Handle properties - Add "Handle pointer count" field. Dynamically updates on GeneralCallbackProcessProviderUpdatedEvent.

Fix handle list "File share access"

Handle attributes search support. ColorPartiallySuspended for both Protected and Inherit handles.
Fix options saving from Advanced page.

Preview:
https://github.com/user-attachments/assets/91aa5fae-e72d-402b-a6b2-b24c3b6d656d

I think this PR is ready to review. :blush:


Expose and warn about Node Filters in Scene Tree Dock

Continuation of #65352. (see also https://github.com/godotengine/godot/pull/65352#pullrequestreview-1100948259)
This PR adds "Filter by Type" and "Filter by Group"  in the Scene Tree Dock's MenuButton (the one on the top right featuring 3 dots), exposing them to everyone that doesn't religiously look at this engine's source code.

Menu
Tooltip

Hovering on them displays an useful tooltip.

Behavior
Warning

When clicking on either of these, the matching parameter is appended to the terms, and the caret is automatically brought to the end.
When typing a filter that cannot be identified, a warning icon is displayed. The reason is explained in the menu. Before this, the temporary solution of #65352 is to spam warnings to the console.

And lastly, the same options are also quickly available by right-clicking or middle-clicking in the text field.

Right Click
Middle Click

Looks good, but the warning system is weird that it shows a warning icon but the actual warning is shown in the menu. That's not something we do anywhere else in the editor.
The warning should be shown in a tooltip on hover of the warning icon, like for node configuration warnings.

The warning should be shown in a tooltip on hover of the warning icon, like for node configuration warnings.

Not sure it would be possible to have the tooltip display exactly there, without resulting into something poor and hacky. I want to note that the Warning icon in this PR is actually still the "clear" TextEdit button. Its behavior remains unchanged, which means it would clear the text on click instead of telling the user what's wrong. Not the worst thing in the world, really, just putting it out there.

Going to update this PR to display the warning as a tooltip hovering over the filter TextEdit:

All good now, I hope.

I have nodes without any groups. With empty group: filter, some of them disappear:

Why is that?

Thank you for the testing as always, @KoBeWi. The group thing may not be related to this PR, but it'd still be nice to see if something can be done about it, because I implemented the feature and it'd be nice to address it. It may be related to the way groups are detected. It'd love to take a look at that project you're testing it with to spot the issue.
Meanwhile, I addressed the right-click options not working.

Ok I can address it in another PR. Perhaps within https://github.com/godotengine/godot/pull/65939 to make it quick.

Thanks!


[bugfix]: add check in case empty detach-keys override

Signed-off-by: zhangyue<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
as title mentioned,  effect pouch start/run command.
Ⅱ. Does this pull request fix one issue?

None
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No need
Ⅳ. Describe how to verify it
None
Ⅴ. Special notes for reviews
None

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@allencloud I saw the Container struct has field DetachKeys, I think it's useless. Maybe remove it is a good way? In docker, if you can't override the default detach-keys when get a terminal such as run/start, the detach-keys will be the default not same as the former one.

@ZYecho do we have test case here?

close it temporarily


[rtl] Wire scan_rst_ni through ibex_top_tracing

Better to have the tracing top consistent with the non-tracing top.
Signed-off-by: Tom Roberts<EMAIL_ADDRESS>

While we're at it:
The docs say
| ``scan_rst_ni``         | 1                       | in  | Test controlled reset.  If DFT not     |
|                         |                         |     | used, tie off to 0.                    |

Shouldn't the tie-off be 1 if DFT is unused?

Agreed - will fix

Thanks Tom!


Missing git tags.

Expected behavior
Package is correctly installed.
Actual behavior
error: Dependencies could not be resolved because no versions of 'swift-aws-lambda-events' match the requirement 0.1.0..<1.0.0 and root depends on 'swift-aws-lambda-events' 0.1.0..<1.0.0.

There are no appropriate git tags on the repository.
Steps to reproduce

Add as dependency to Package.swift
Attempt install/build/etc.

If possible, minimal yet complete reproducer code (or URL to code)
SwiftAWSLambdaRuntime version/commit hash
Swift & OS version (output of swift --version && uname -a)
Apple Swift version 5.4.2 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>).
Darwin breathwork.local 20.4.0 Darwin Kernel Version 20.4.0: Thu Apr 22 21:46:47 PDT 2021; root:xnu-7195.101.2~1/RELEASE_X86_64 x86_64

@justinmcp You can use this in the meantime
.package(url: "https://github.com/swift-server/swift-aws-lambda-events", .branch("main")),

0.1.0 has just been tagged so I assume this can be closed.

I think this issue can be closed @fabianfett

I think this issue can be closed @tomerd @tachyonics


Simplify .github workflow using pre-commit

During working on PR https://github.com/speechbrain/speechbrain/pull/973,
I've found pre-commit workflow on this repository(.github/workflows/pythonapp.yml) can be simplified.
https://speechbrain.readthedocs.io/en/latest/contributing.html#pre-commit
I've checked all test can pass using this workflow. https://github.com/kimdwkimdw/speechbrain/pull/1

Thanks for the idea, but I think we want to maintain the pre-commit hooks and the GitHub CI tests separately, as we've realized we want to run different things in them.

Thanks for the idea, but I think we want to maintain the pre-commit hooks and the GitHub CI tests separately, as we've realized we want to run different things in them.

Something like this?

Sorry, I mean that I think we don't want to run pre-commit on GitHub at all. But perhaps there's something I am not seeing, what are the benefits of this change?

From the SpeechBrain document,

The hooks are only run on the files you git added to the commit. This is in contrast to the CI pipeline, which always tests everything

I thought that SpeechBrain maintainers want to focus on the architecture of a change not a trivial style with .pre-commit-config.yaml
Changes
So, I just try to simplify these linters from
- name: Lint dependencies
  run: |
      python -m pip install --upgrade pip
      pip install -r lint-requirements.txt
- name: Run linters
  run: |
      flake8 . --count --show-source --statistics
      black --check --diff .
      yamllint .

to
 - uses<EMAIL_ADDRESS>
However, it makes a lots of changes in Markdown files. If you don't want this change, add exclude: .md$' on .pre-commit-config.yaml
the benefits

Shorter code is usually good.

Your linter is working almost same as pre-commit except *.md
Bridge the gap between .pre-commit0-config.yml and workflow(https://github.com/speechbrain/speechbrain/blob/develop/.pre-commit-config.yaml#L5-L6), config specify removing trailing-whitespace in text

requirements.txt usually don't need linter dependancy.

Apology for too disruptive changes in commits. I've rollback removal of lint-requirements.txt

Right, I pull latest develop and apply all on it.

Ok great, thanks for this contribution! Looks good to me.


Make sure link fragment is preserved

Makes sure that the fragment part of a link is preserved when in a notebooks. There is existing special handing for links starting with #, but not with both a path and a fragment part.
Fixes https://github.com/microsoft/vscode/issues/193742
To test this, create a link in a notebook markdown cell in the form of
[Link](file.html#anchor)

When clicking on this link currently, you'll get a dialog. "Unable to open 'file.html#anchor' Cancel/Create File"
With this fix, you will either open file.html if it exists, or get a  "Unable to open 'file.html' Cancel/Create File" dialog.

@microsoft-github-policy-service agree [company="Google"]

@microsoft-github-policy-service agree company="Google"


[MINOR] Fixing secondary index logging

Change Logs
Fixing secondary index logging
Impact
Fixing secondary index logging
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

LGTM. Can you just confirm through spark-shell/sql that you don't see the logs w/o sec index?

Yes, confirmed this.


Image preview will shake

Due to the updates every 100ms, it will appear to shake as something is being updated. One fix may be to switch from updating every 100ms to updating once after the image is loaded using an event listener for img load.

Fixed in pull request #22


[API] Capitalization, naming and description of parameters

There are a few API parameters that start with lowercase, some with uppercase.
The wallet name is passed as name or walletName depending on the method, this should be consistent, I think.
The create API method needs a folderPath and a network parameter, but they seem to be not used in WalletController.cs. Similarly for the load method and its folderPath parameter.
The parameter descriptions are never filled on Swagger.
To see these, open http://localhost:37221/swagger while running the Breeze client.

@bokobza can probably comment son this best