feat: add DosageRange

Codecov Report

Merging #306 (b1be1c4) into trunk (4ce8666) will decrease coverage by 5.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            trunk     #306      +/-   ##
==========================================
- Coverage   96.53%   91.19%   -5.35%
==========================================
  Files          17       17
  Lines        1011     1033      +22
  Branches       93       83      -10
==========================================
- Hits          976      942      -34
- Misses         31       87      +56
  Partials        4        4

Impacted Files
Coverage Δ

...-of-administration/route-of-administration.spec.ts
100.00% <0.00%> (ø)

...ackages/osiris/src/dosage-unit/dosage-unit.spec.ts

packages/osiris/src/dosage-unit/dosage-unit.ts

...es/osiris/src/dosage-unit/dosage-classification.ts

.../src/dosage-unit/dosage-table/dosage-table.spec.ts

...siris/src/dosage-unit/dosage-table/dosage-table.ts

...ges/osiris/src/dosage/dosage-table/dosage-table.ts
62.85% <0.00%> (ø)

...ackages/osiris/src/dosage/dosage-classification.ts
100.00% <0.00%> (ø)

...ges/osiris/src/dosage/dosage-range/dosage-range.ts
53.19% <0.00%> (ø)

packages/osiris/src/dosage/dosage.spec.ts
100.00% <0.00%> (ø)

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create proc macro to define actions

Closes #57

Codecov Report

Merging #58 (1d34ad8) into main (1c8ef4b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           38        38
  Lines         3194      3194
=========================================
  Hits          3194      3194

Impacted Files
Coverage Δ

crates/modor/src/actions.rs
100.00% <ø> (ø)

crates/modor/src/lib.rs
100.00% <ø> (ø)

crates/modor_physics/src/module.rs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8ef4b...1d34ad8. Read the comment docs.


Fix out-of-band write and several maintenance changes

This pull request contains a fix for a potential out-of band write.
Beside of that fix, it also contains a set of maintenance commits:

documentation updates
autotools cleanup
remove duplicate references in several contexts
optimize code (use of OPENSSL_clear_free())

rebased on merged PR #6


dev-cmd/bump: skip Repology checks in CI for livecheckables

When we have a livecheck in a formula, Repology is purely informational - it is never used to perform the actual bump. In a CI autobump environment, this is wasted network requests and adds a couple seconds to each bump so let's skip it.

I could definitely (unscientifically) feel the change locally. The current autobump is quite slow at one hour: https://github.com/Homebrew/homebrew-core/actions/workflows/autobump.yml, so we'll see what it's like after merging this.
#16886 also removes a slow open PR check that will save a couple seconds per formula too.

https://github.com/Homebrew/homebrew-core/actions/runs/8304989363/job/22731571713
2x faster (~1hr -> ~30 mins)

Amazing work again @Bo98!


Plugin system

As described in https://github.com/earl-js/earl/issues/30
TODO:

[x] plugin discovery mechanism
[ ] load plugin
[ ] extend expect with plugin injected validators
[ ] extend expect with plugin injected matchers
[ ] extend smartEq with plugin injected validator logic

I think it might help if we convert earl to a monorepo, because then we could develop an example plugin inside it

@sz-piotr about monorepo - I will for now create a sample plugin in a separate repo but yes, I think migrating to monorepo would be beneficial but note that it always complicates tooling so maybe now is not the best time yet.
As for the plugin system - the current implementation works. It allows for injecting matchers, validators and additional smartEq rules. It's written in a way that allows injecting dynamic entities and stores them directly at the module level so it needs a little bit more work during tests.(I ditched my original plan with ExecutionCtx injecting this configuration). I would like to hear your opinion on this.
The bigger problem is that to make it viable to develop on top of earl we need to export more stuff. I always like to keep my entry point (index.ts) nice and tidy so this is less than ideal. I see a few options:

Export plugin related things from index.ts - ugly for regular users
Encourage for "deep" import paths like @earljs/dist/smartEq.ts (notice the ugly dist part)
Come up with a way to flatten package before the release and get rid of dist part. And perpahs create plugin-sdk.ts and export everything useful from there.

I feel like option (2) might be the most "pragmatic" and since plugin authors are power users it's not that bad that they will have to use "deep" import paths.
Thoughts?

I always like to keep my entry point (index.ts) nice and tidy

Why not have a separate entry point for plugin related stuff? They would then import from earljs/internals and get all they need from there. And in the repository you'd just need an internals folder with correctly configured package.json pointing to specific files in dist

I am not sure what do you mean by And in the repository you'd just need an internals folder with correctly configured package.json pointing to specific files in dist? If I create internals directory in /src it will endup in /dist/internals so the import path would be earljs/dist/internals.
What I proposed in (3) is something like copy package.json and contents of dist into a separate dir and publish that dir. This would flatten all the paths. Is this what you mean?

Here is what I meant:
dist/
  index.js
  index.d.ts
  internals.js
  internals.d.ts
src/
  index.ts
  internals.ts
internals/
  package.json: { main: ../dist/internals.js, types: ../dist/internals.d.ts }
package.json: { main: dist/index.js, types: dist/index.d.ts }

@sz-piotr huh never saw this approach in the wild. I will give it a try :+1:

Okay, I am pretty happy with the state of things. An example is done here: https://github.com/earl-js/earl-plugin-example (you need to link locally earl built from this branch to test it).
Exposing internals with internals/package.json is dope.
You can import plugins only just by writing import "dope-earljs-plugin" (plugin will call loadPlugin for you.


BuildWorkspace []OFF should use error exit codes starting with 12 not 10

 BuildWorkspace←{
     ⍺←0
     v←⍵
     pf←GetProjectFolder ⍺
     q←{'''',⍵,''''}
     l←⊂']Dado.Version'
     ⍝ Once saving from ⎕SE works, we can simply do:
     ⍝ l,←⊂'rc em←',(q pf),' ⎕SE.Dado.BuildWorkspace_ ', qv
     l,←⊂'rc em←',(q pf),' (⎕NS ⎕SE.zApps.Dado.Dado).Main.BuildWorkspace_ ',q v
     l,←⊂'em'
     **l,←⊂'⎕OFF (10+rc)'**
     ExecuteAPL l
 }

Dyalog default exit codes 17.1

0
Successful ⎕OFF, )OFF, )CONTINUE, graphical exit from GUI

1
APL failed to start. This will occur if there was a failure  to read a translate file, there is insufficient memory, or a critical parameter  is incorrectly specified or missing.

2
APL was terminated by SIGHUP or SIGTERM (UNIX) or in  response to a QUIT WINDOWS request. APL has done a clean exit.

3
APL issued a syserror.

4
Runtime violation. This occurs if a runtime application  attempts to read input from the Session. Only a development version has a  Session.

5
APL was unable to load the Conga libraries (14.1.25383  onwards). In 16.0 the RIDE libraries have been included in the Conga  libraries.

6
RIDE_INIT or one of its components was ill-defined, or APL was unable to use the  port, and/or unable to resolve the hostname (14.1.25383 onwards)

7
Reserved

8
Windows rejected APL's request to create a session window (in  earlier versions this generated a syserror 126)

9
Dyalog has encountered a Microsoft Windows-related error when  starting and is unable to continue. For example it cannot register clipboard  formats.

10
CEF sub-process crash - something has gone unexpectedly wrong  with either the HTMLRenderer or CEF sub-processes and cannot continue

11
Cannot create c-stack (macOS only)

Maybe I should got to 100? These are newly added codes.

I don't understand the error trapping buy maybe mimic the unix behavior or dyalog?
Under UNIX exit codes greater than 127 indicates (127+signal number) of the untrapped signal which caused the process to terminate.


Felix should ensure IP forwarding is enabled for all endpoints

Forwarding must be enabled on all endpoint interfaces, or they won't work. In other words, /proc/sys/net/ipv4/conf/<interface ID>/forwarding should be 1 (and the same for IPv6). This is usually the default, based on net.ipv4.ip_forward and net.ipv6.conf.all.forwarding in /etc/sysctl.conf, but if it is not then endpoints don't work properly.
Felix should probably check the values for each tap interface, just as it sets the value of proxy_arp for them, so that they are guaranteed to work.

Note that setting on TAP interfaces may not be sufficient.  I would guess it's also needed on the interfaces that are involved in routing between compute hosts.
(I wonder whether the per-interface forwarding flag means 'enable forwarding from this interface' or 'enable forwarding to this interface', or perhaps both?)

Should have some simple validation in Felix.

IP forwarding as above
File handle limits (set in the upstart job, but should validate as a belt and braces).

May want to add others later. Not critical for now, but worth sanity checking at startup point.

I've just been caught by this in my DevStack IPv6 testing.  IPv6 forwarding wasn't enabled on the host - grrr!  So I support working on this issue.
Just discussed options with @fasaxc, who is keen that we should if possible make Felix handle sysctl options (like IP forwarding) in a consistent way - and in particular consistent with what we've just implemented for rp_filter.
However there are 2 ways in which IP forwarding is not like rp_filter.

Possible values for IP forwarding are just 0 (don't forward) and 1 (forward).  There isn't a problem - as there is in the rp_filter case - that the 'all' value might be set to a higher value than 1 but that actually has a more restrictive (or unwanted) meaning.  So, if we're setting per-interface IP forwarding values, we don't need to care about the 'all' value.

Successful IP forwarding involves 2 interfaces, the inbound and the outbound.  It might be that IP forwarding needs to be set on both of them, or it might be just one - in which case, which?  I don't currently know - but anyway this is a possible structural difference from rp_filter.

We then discussed what we might do with IP forwarding.

Felix could just look at what is set, and complain loudly if it doesn't look right, but not actually change settings itself.

Felix could enable IP forwarding globally (i.e. with the 'all' value).

Felix could enable IP forwarding on each TAP interface individually, and require (=> document) that the operator enables IP forwarding on the particular fabric-facing interface(s) that should be used for routing instance data across the fabric; e.g. eth0.

I think the only sensible options here are (2) and (3).  Forwarding is fundamental to Calico operation, so I don't think it makes sense for Calico just to complain, so I'd rule out (1).
Therefore I propose a config option like this:
# Control whether Calico enables IP forwarding globally (default value false), or only
# on endpoint interfaces (value true).  In the latter case, the operator must also enable
# IP forwarding on the fabric-facing interfaces that are used for routing endpoint data
# between hosts and to/from the Internet.
# per_interface_forwarding = false

@beddari mentioned in IRC that https://github.com/projectcalico/calico/blob/master/debian/calico-compute.postinst should really be moved to better places (Neutron DHCP agent and Felix perhaps?).

So, I'm aware this is an endless ongoing debate but at least in the RHEL based world (a little less so perhaps in Debian) it is not expected for a package to self-configure other services at package installation time.
Documentation plus external helper scripts is much better. E.g that the package changes iptables rules and sysctl values breaks my automation setup.


Frontend and Backend

Create a blog on explaining The difference between Frontend and Backend

Hello, I would like to take this.

can i take this

Pls assign me this issue

Hey, @debrajrout please assign this issue to me


fix: switching between windows results in new magic code input field position reset

Details
Removes the setInput call in the onFocus event handler to prevent the input from being reset after switching between browser tabs when a user is trying to enter a magic code in the new magic code input field.
Fixed Issues
$ https://github.com/Expensify/App/issues/18324
PROPOSAL: https://github.com/Expensify/App/issues/18324#issuecomment-1546710743
Tests

Navigate to the sign in page.
Enter email and click the ‘Continue’ button.
Open a new browser tab and navigate to any web page.
Switch to the browser tab with the magic code and enter the first 2 or 3 digits of the magic code.
Switch to the other browser tab.
Switch back to the browser tab with the magic code input and attempt to enter more digits.
Verify that the new digits entered continue from the current point, instead of overwriting the first set of digits that were already entered.

[x] Verify that no errors appear in the JS console

Offline tests
N/A
QA Steps
Same as tests.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/4160319/b1236cd0-deaf-41c4-adcb-199c7d3b337e

Mobile Web - Chrome
18324-android-chrome.webm

Mobile Web - Safari
https://github.com/Expensify/App/assets/4160319/a235fc14-682b-43e8-af0e-ba0d0e70b878

Desktop

iOS

Android

Seems hidden on Android mWeb after switching tabs or apps.
https://user-images.githubusercontent.com/4160319/239987704-f1d56bba-53fd-4b36-83c5-00ccb60c5a5d.webm

Yeah good point. I don't know if it's a Chrome / accessibility issue or a bug here, but I see the same behavior on various inputs on other websites (I tried accounts.google.com, wikipedia, facebook). When the page loses focus and then regains it, the keyboard won't reopen until you tap the input.
It's also happening on main, so technically it's not a regression.

Seems keyboard gets hidden on Android mWeb after switching tabs or apps.

Yes. This also happens in iOS Safari where you have to tap / click to restore focus after switching tabs. It's been that way prior to this change (you can test on current staging / production).

Yeah that makes sense.
Other than this, did your tests go well @Santhosh-Sellavel ? If so let's go ahead and merge this :)

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/5544f875-e474-4e99-9088-dd0f88c24417

Mobile Web - Chrome &  Web - Safari
https://github.com/Expensify/App/assets/85645967/a67a941c-f96c-442e-bf76-29b743e4f858

iOS

 Android
https://github.com/Expensify/App/assets/85645967/4d540455-75b9-473c-adad-1ad98f30d275

@francoisl @akinwale I'm running into weird issues
1. On iOS this is blocking me from testing. Unable to input values, gets cleared.
https://github.com/Expensify/App/assets/85645967/568d3bf1-26e9-4995-b761-69c4c68059e5
2. On iOS mWeb. Focus & cursor on different inputs
https://github.com/Expensify/App/assets/85645967/f44b21cb-1d5a-40d0-b9cc-a7cfa236f07e
Both happen on the main too. But the 1 seems more serious to me. May be we need to hold this fix that before moving forward let me know your thoughts thanks!

Hmm weird, I'm not experiencing either of those issues. I'm surprised if they're also on main. I'll ask someone else to test to get a third opinion.
https://github.com/Expensify/App/assets/2229301/017de43b-c32a-447a-a69a-0afcbe89b261

We checked with @yuwenmemon on his physical iPhone and the input behaves as expected.
Any chance this is an issue with your build @Santhosh-Sellavel? Not sure what it could be - especially given that web is working fine - but maybe start with a npm i, and uninstall + rebuild the app for native?
Anyway, I think this is fine to proceed, I don't mind finishing the checklist.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Thanks, @francoisl. If it's not happening on the real device then we're good here. Maybe iOS could be a build issue, I'll recheck. But the mWeb issue occurs for me on staging too
https://github.com/Expensify/App/assets/85645967/1814d16e-2884-4298-9ffd-8e9e787dc554

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.18-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Unable to connect to carelink

CareLinkErrorReport(en-US)95.txt

It is a Medtronic server issue; they are blocking access by changing the code sent to client.
The only solution is to let the program fill out the Medtronic Login screen and click the "I am not a Robot".  It you fill out any information manually it will always fail. If it does not automatically fill it in cancel and try again usually within 2 tries it will work.
This is a duplicate of #53

I can only connect with version <IP_ADDRESS>. With higher versions it doesn't work, the credentials are filled in automatically.


Hard error in details.polyfill.js

If you try to use a <details> tag without markup suggested on govuk-elements, details.polyfill.js throws the following error in the console:
details.polyfill.js:94 Uncaught TypeError: Cannot read property 'id' of null
    at addDetailsPolyfill (details.polyfill.js:94)

As the HTML markup is technically not invalid, I would say that it is incorrect to throw a hard error just because you're using markup that differs to the recommended example. Perhaps a softer warning that you're not using the recommended markup is more appropriate.

Fixed by #521.


Player.SteamID is 0 when it shouldn't be for some demos

Hi,i changed demoParser.PlayerInformations to public so I could access it in the dll. It contains the SteamID. Still, Player.SteamID is empty.


Fix OutputSampler's coder

Previously, the OutputSampler coder would always be the Value coder (from a windowed value). This would cause a mismatch between the encoding for the PCollection defined in the ProcessBundleDescriptor vs. what is being given to the OutputSampler. The fix is to always sample WindowedValues and give the OutputSampler the literal rehydrated coder.
Task #25064

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem

lgtm!


Incorrect wheel links for torch-1.8.1+cu111

If I go to https://pytorch-geometric.com/whl/torch-1.8.1+cu111.html, all the wheels links are linked to torch-1.8.0+cu111.
As an example -
torch_cluster-1.5.9-cp37-cp37m-linux_x86_64.whl is pointing to https://pytorch-geometric.com/whl/torch-1.8.0+cu111/torch_cluster-1.5.9-cp37-cp37m-linux_x86_64.whl at torch-1.8.1+cu111
Is this expected behaviour of wheel links or am I missing something?
Thanks

Even all the wheel links at

torch-1.7.1
torch-1.7.1+cpu
torch-1.7.1+cu101
torch-1.7.1+cu102
torch-1.7.1+cu110
torch-1.7.1+cu92

are all pointed to corresponding torch-1.7.0.

Yes, this is intended. The wheels for PyTorch 1.7.0 work for 1.7.1 as well, and the same holds true for PyTorch 1.8.0.

Great. Since this is the expected behaviour, I am closing the issue.
Many thanks for the quick reply @rusty1s .


fix: Update cross-chain tutorial to make use of latest deps and ethers v6

What :computer:

Updates to reflect latest dep changes from HH
Updates to make use of ethers v6
Fixes CLI commands

Why :hand:

Should always use latest and greatest
Issue with CLI command

Evidence :camera:
Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes :memo:

Any notes/thoughts that the reviewers should know prior to reviewing the code?

LGTM!


[Question] Does this support updates for Linux?

The description does mention cross platform, but exactly which platforms does this package support?

Yes, all platforms that electron itself supports.


Experimental Macvlan: Explicit endpoint MAC address is not being set

In the CreateEndpoint() of the Macvlan driver, the user specified --mac-address or the libnetwork generated MAC address are being set but not honored somewhere along the lines. Netlink does allow the MAC to be set for a Macvlan type slave. Ipvlan uses the same MAC address as the parent and we reject user specified --mac-address setting there.
	ep := &endpoint{
		id:     eid,
		addr:   ifInfo.Address(),
		addrv6: ifInfo.AddressIPv6(),
		mac:    ifInfo.MacAddress(),
	}
	if ep.addr == nil {
		return fmt.Errorf("create endpoint was not passed an IP address")
	}
	if ep.mac == nil {
		ep.mac = netutils.GenerateMACFromIP(ep.addr.IP)
		if err := ifInfo.SetMacAddress(ep.mac); err != nil {
			return err
		}
	}

Link to the relevant codeblock

Update: the patch

I guess this is fixed now?

Yes, this now works:
$ docker version | grep Version
 Version:      1.13.0-dev
 Version:      1.13.0-dev
$
$ docker network create -d macvlan mc
bea5e21d0934445e088d705de956b11c104a5ce43d55f1b7671c9fafe423c2f5
$
$ docker run --mac-address aa:bb:cc:ee:44:55 --network mc --rm busybox ifconfig eth0 | grep HWaddr
eth0      Link encap:Ethernet  HWaddr AA:BB:CC:EE:44:55
$

Closing.


Generated file fails to compile due to the missing implicit when query parameters contain the parameter named format.

(I'm not sure here is the place to post this issue. If this issue is related to another project, please tell me the repo.)

"org.openapitools" % "sbt-openapi-generator" % "5.0.1"
"com.softwaremill.sttp.client" %% "core" % "2.2.0"
"com.softwaremill.sttp.client" %% "json4s" % "2.2.0"
"org.json4s" %% "json4s-jackson" % "3.6.8"

When I have the parameter named format, the code below is generated.
The format in argument overrides the implicit value format from import org.openapitools.client.core.JsonSupport._, which causes compile to fail.
paths:
  '/api':
    get:
      parameters:
      - name:  "format"
        in: "query"
        description: "format"
        required: true
        schema:
          type: string
          default: json

package org.openapitools.client.api

import org.openapitools.client.model.SearchResponse
import org.openapitools.client.core.JsonSupport._
import sttp.client._
import sttp.model.Method
class DefaultApi(baseUrl: String) {
  /**
   *
   * @param format format
   */
  def apiGet(format: String): Request[Either[ResponseError[Exception], MyResponse], Nothing] =
    basicRequest
      .method(Method.GET, uri"$baseUrl/api?format=${ format }")
      .contentType("application/json")
      .response(asJson[MyResponse]) // No org.json4s.Formats found.

}

Sorry for long delay. I assume that you have figure out that this project is an alternative for the official "org.openapitools" % "sbt-openapi-generator" % "5.0.1". We don't have json4s support at the moment but this is something I would like to add as soon as I will have some spare time.


Change Quantization Precision

💡 Your Question
Dear Author @BloodAxe
So I've read the PTQ and QAT for Classification README and I found about QuantDescriptor

I want to use PTQ_and_QAT_for_classification.ipynb file to produce vary quantized model with custom precision (4-bit, 8-bit, 16-bit). On what file I should declare the num_bits of QuantDescriptor's args so I can produce the quantized model?
Thank you
Versions
No response

At this moment, changing precision is not supported and is not anywhere on the roadmap.


Could not install the app on the device, read the error above for details.

jax$  react-native run-android
Starting JS server...
Building and installing the app on the device (cd android && ./gradlew installDebug...

Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

jax$ adb devices
List of devices attached
<IP_ADDRESS>:5555 device

how can I fix it , On my computer .
It's ok for react-native run-ios
and it's ok for react-native run-android  on my company computer

you might check the permission on android/gradlew
they should be 755 not 644
run chmod 755 android/gradlew inside your app root folder and that should solve your error

@cyprusglobe
Thanks for your help,I will try later!
My company computer is ok .

@cyprusglobe Your suggestion worked. Thanks a lot.

It works for me too !! Thx!!! @cyprusglobe

@cyprusglobe should this be put in documentation?

Works for me too. Thanks.

I have simillary issues but error message looks -```
 Unknown source file : UNEXPECTED TOP-LEVEL EXCEPTION:
Unknown source file : com.android.dex.DexException: Multiple dex files define La
ndroid/support/v7/appcompat/R$anim;
Unknown source file :   at com.android.dx.merge.DexMerger.readSortableTypes(DexM
erger.java:596)
Unknown source file :   at com.android.dx.merge.DexMerger.getSortedTypes(DexMerg
er.java:554)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeClassDefs(DexMerg
er.java:535)
Unknown source file :   at com.android.dx.merge.DexMerger.mergeDexes(DexMerger.j
ava:171)
Unknown source file :   at com.android.dx.merge.DexMerger.merge(DexMerger.java:1
89)
Unknown source file :   at com.android.dx.command.dexer.Main.mergeLibraryDexBuff
ers(Main.java:502)
Unknown source file :   at com.android.dx.command.dexer.Main.runMonoDex(Main.jav
a:334)
Unknown source file :   at com.android.dx.command.dexer.Main.run(Main.java:277)
Unknown source file :   at com.android.dx.command.dexer.Main.main(Main.java:245)

Unknown source file :   at com.android.dx.command.Main.main(Main.java:106)

:app:dexDebug FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.E
xecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_101\bin\java.exe'
' finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

Total time: 22.166 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

(node:6876) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejec
tion id: 2): TypeError: Cannot read property 'message' of undefined

@cyprusglobe thanks your advice.it's useful

@cyprusglobe
Thanks for your help.
This pit is good!

how about windows i am getting the same error?

Had similar problem, but with
NoClassDefFoundError. Uninstalling java and jdk, rebooting and installing java and jdk (x86 and x64) helped me.

Thanks, it worked!

@cyprusglobe it works for me too, thanks

if your android rom is MIUI ROM,find the solution: go settings -> developer option -> close MIUI optimization

Thanks, it worked! good !

I got the same error on windows. Could you give me some solutions?

Am running into similar issue and am not sure how to @cyprusglobe's solution....

I also try like this as you commented, but the error has not gone. I want to run with external device.

I finally figured out the problem and solved it.

@eaintphyo ,我想知道你是怎么解决的呀！？

@eaintphyo ,can you share the experience! thanks!

@Anndyang2017 Here's my solution,
https://stackoverflow.com/questions/43521533/error-could-not-find-or-load-main-class-org-gradle-wrapper-gradlewrappermain/44150895#44150895

@cyprusglobe  thanks!

@cyprusglobe you're clever
thx man

@cryptobiote Thanks for this.
Windows users will want to run chmod 755 android/gradlew.bat

Yes, i know
But i'm mac users :)

I am on windows and I got this working by reinstalling react-native-cli
npm uninstall -g react-native-cli
npm install -g react-native-cli

On windows, this can be resolved by reinstalling react-native-cli
npm uninstall -g react-native-cli
npm install -g react-native-cli
Restart powershell and Android Studio. You must start a new project and delete old ones.
react-native init NewProject

It worked for me :+1:

It helped on windows:
Run 'react-native run-android' via cmd as admin

hi , when I wanna run project , I have this error , guide me plz:
Scanning 556 folders for symlinks in C:\Users\sheyda\shidi\node_modules (63ms)
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat installDebug)...
Unzipping C:\Users\sheyda.gradle\wrapper\dists\gradle-2.14.1-all\8bnwg5hd3w55iofp58khbp6yv\gradle-2.14.1-all.zip to C:\Users\sheyda.gradle\wrapper\dists\gradle-2.14.1-all\8bnwg5hd3w55iofp58khbp6yv
Exception in thread "main" java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.(ZipFile.java:219)
at java.util.zip.ZipFile.(ZipFile.java:149)
at java.util.zip.ZipFile.(ZipFile.java:163)
at org.gradle.wrapper.Install.unzip(Install.java:159)
at org.gradle.wrapper.Install.access$500(Install.java:26)
at org.gradle.wrapper.Install$1.call(Install.java:69)
at org.gradle.wrapper.Install$1.call(Install.java:46)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:46)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:126)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/android-setup.html

@sheyda93
I sometimes still run into the error, and you can try to perform next steps:

Go to android-sdk\platform-tools\adb.exe and run via cmd: adb.exe devices
You should make sure that device is really visible
Remove all files from the dir: ../android/app/build
(the build dir should be empty)
Uninstall app from emulator (if you have already installed it)

Try to install again

@cyprusglobe Man, you saved my life. Thanks a lot!!!

For Windows:
@kostyaVyrodov is right. Running "react-native run-android" via cmd as admin helps. Use cmd as admin, but not PowerShell.

@enzeberg Running "react-native run-android" via cmd as admin helps me also.

how to check permission on android/gradlew?

I'm running command as:
sudo react-native run-android

It works for me.

I was facing same issue, I fixed by running "npm install" Lol

I tried "sudo react-native run-android", working fine!

Basta modificar a permissão da pasta android/grandlew dentro da raiz do projeto, ou você pode rodar o comando sudo react-native run-android...

"chmod -R 777 android/grandlew" doesn't work in my mac

I have a same issue on Ubuntu 16.04.3. I tried chmod 755 android/gradlew but it doesn't work

Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat install
Debug)...
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

List of devices attached
C4F12440556EC9E device
if i try this chmod 755 android/gradlew
i am getting chmod not a internal and external commend
Note: i am using windows 8.1
this will happen after npm run eject
please any one help to solve this.

Why there is still no solution for windows??

For me enabling developer options in emulator worked.I mean obviously you have to do that boi!

今天也遇到这个问题，刚解决，在项目下：
执行：chmod 755 android/gradlew    =>没解决
执行： chmod 755 . =>已解决

Hello,
Im getting same error message.
C:\Projects\MobApp\Project1\sample1>react-native run-android
Scanning folders for symlinks in C:\Projects\MobApp\Project1\sample1\node_modules (249ms)
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat installDebug)...
Downloading https://services.gradle.org/distributions/gradle-2.14.1-all.zip
Exception in thread "main" java.net.UnknownHostException: services.gradle.org
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at com.sun.net.ssl.internal.ssl.SSLSocketImpl.connect(Unknown Source)
at com.sun.net.ssl.internal.ssl.BaseSSLSocketImpl.connect(Unknown Source)
at sun.net.NetworkClient.doConnect(Unknown Source)
at sun.net.www.http.HttpClient.openServer(Unknown Source)
at sun.net.www.http.HttpClient.openServer(Unknown Source)
at sun.net.www.protocol.https.HttpsClient.(Unknown Source)
at sun.net.www.protocol.https.HttpsClient.New(Unknown Source)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(Unknown Source)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(Unknown Source)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(Unknown Source)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(Unknown Source)
at org.gradle.wrapper.Download.downloadInternal(Download.java:58)
at org.gradle.wrapper.Download.download(Download.java:44)
at org.gradle.wrapper.Install$1.call(Install.java:59)
at org.gradle.wrapper.Install$1.call(Install.java:46)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:46)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:126)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html
Where do i run this commend ? chmod 755 android/gradlew
if i run this in terminal i get this error message : 'chmod' is not recognized as an internal or external command,
operable program or batch file.


[VMR] linux/mac-arm64 cross build fails w/ CoreCLR runtime

Describe the Bug
When triggering a building targeting arm64 from a linux or mac x64 host, the VMR build will fail at runtime with the following error:
      [ 29%] Building CXX object nativeaot/Runtime/Full/CMakeFiles/Runtime.ServerGC.dir/__/EHHelpers.cpp.o
      [ 29%] Building CXX object pal/src/CMakeFiles/coreclrpal.dir/thread/threadsusp.cpp.o
      /Users/steve/dev/dotnet-vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/pal/src/synchmgr/synchmanager.cpp:4633:6: error: "Don't know how to get hi-res current time on this platform"
          #error "Don't know how to get hi-res current time on this platform"
           ^
      [ 30%] Building CXX object nativeaot/Runtime/Full/CMakeFiles/Runtime.WorkstationGC.dir/__/MethodTable.cpp.o
      1 error generated.
      make[2]: *** [pal/src/CMakeFiles/coreclrpal.dir/synchmgr/synchmanager.cpp.o] Error 1
      make[2]: *** Waiting for unfinished jobs....

Steps to Reproduce

Apply the patch @directhex made in https://github.com/dotnet/source-build/issues/3671#issuecomment-1783079761

Build the VMR

For Mac:
./prep.sh
./build.sh --online -- /p:OverrideTargetRid=osx-arm64

For Linux:
docker run -e CROSSCOMPILE=1 -e ROOTFS_DIR=/crossrootfs/arm64 -w pwd--platform linux/amd64 -vpwd:pwd -it mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-arm64
./build.sh --online -- /p:OverrideTargetRid=linux-arm64

Other Information

/cc @jkoritzinsky

@jtschuster @agocke looping you guys in too

I have a build finished and the arm64 sdk runs on my machine with qemu.
I've made a PR on my fork with the diff for reference: https://github.com/jtschuster/dotnet/pull/1
I have dotnet/dotnet cloned at /src/dotnet in wsl, then ran
> docker run -e ROOTFS_DIR=/crossrootfs/arm64 -w /src/dotnet --platform linux/amd64 -v \\wsl.localhost\Ubuntu\src\dotnet:/src/dotnet -it mcr.microsoft.com/dotnet-buildtools/prereqs:cbl-mariner-2.0-cross-arm64
$ ./prep.sh && ./build.sh --online -- /p:OverrideTargetRid=linux-arm64 /p:OverrideTargetArch=arm64

The issue requiring workarounds is that we don't specify the build machine's runtime pack as a prerequisite and runtime is told not to download packages (DotNetBuildOffline = true), even using --online at the root. The in-build crossgen and ilc are published self-contained, but without the runtime pack, they don't run. I've added workarounds for this so that the build can finish (see mentions above), but it's probably not what we want to ship. I can't figure out how to declare source-build prerequisites to properly fix this, can anyone point me to that?

Made https://github.com/dotnet/source-build/issues/3793 to track reenabling crossgen and ilc.


Import query packs into Fleet server

Hi, I'm trying to import query packs so that they show up in Fleet server GUI.  The goal is to be able to assign query packs to hosts.  I can't seem to find the proper way to import query packs so they can be assigned via the Fleet server UI.  If this isn't the proper place, please let me know.  Appreciate any insight.  Can't see to find the proper documentation showing what I need to do.
What version of fleet are you using (fleet version --full)?
fleet - version 2.2.0
What operating system are you using?
Ubuntu 19.04
What did you do?
Tried to import query packs by using fleetctl cli and by using osquery.conf with the packs.
What did you expect to see?
Expected to see the query packs showing in Fleet server UI.
What did you see instead?
No query packs showing in Fleet server UI.

Found the resolution on this github issue.  Was able to use fleetctl commands to import so that query packs show up in Fleet UI ("Import query packs via GUI"):
https://github.com/kolide/fleet/issues/1880


What role is required to link AppInsights to APIM instance

It is not clear from the documentation what (minimum) role is required to be able to link an Application Insights resource to an API Management resource.
It would be helpful to have this information added to the documentation.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c26c1996-853e-9a55-5802-8c4095d545b9
Version Independent ID: 437f5553-6914-c0ef-9370-bb11d3a0fa4b
Content: Integrate Azure API Management with Azure Application Insights - Azure API Management
Content Source: articles/api-management/api-management-howto-app-insights.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@fgheysels
Thanks for your feedback! We will investigate and update as appropriate.

@fgheysels If you are looking for the built-in role, you need to have API Management Service Contributor role (check Built-in service roles). However, in case of a custom role with minimum required permissions, permission Microsoft.ApiManagement/service/diagnostics/write is required based on Diagnostic entity API in addition to read access to the APIM instance. Refer Microsoft.ApiManagement doc for more detailed info.

I suggest you review https://techcommunity.microsoft.com/t5/azure-paas-blog/usage-of-custom-rbac-roles-in-azure-api-management/ba-p/1560571 for creating a custom role and validate the permission.
@dlepow any thoughts of adding a note to the doc?

@fgheysels @mumurug-MSFT - Thanks for the feedback about this article. I'll add a note about the minimum permissions required for creating the App Insights diagnostic.

@fgheysels We will proceed to close this thread and feel free to let us know if any questions. Thanks again.


Do not overwrite existing output files

Because manual edits might be lost.
Maybe provide an -f (force overwrite) command line option.

Sounds OK. Can you prepare a pull request?
--
Best Regards / S pozdravom,
Pavol Rusnak<EMAIL_ADDRESS>On Fri, Mar 4, 2016, at 02:42 PM, Christopher Arndt wrote:

Because manual edits might be lost.

Maybe provide an -f (force overwrite) command line option.

—
Reply to this email directly or view it on GitHub[1].

Links:

https://github.com/prusnak/micropython-extmod-generator/issues/3

Ok, I'll look into it later tonight.


Add documentation for the Filesystem class

Overview
Initial documentation for the Filesystem class
Resolves #328.

@jcogs-design This is great. thanks!
@intoeetive can you review and approve? thanks

Having just yet again had to go spelunking in the Filesystem class for information on methods there (this time getDirectoryContents) I am wondering what more needs to happen for this documentation to be added into the Docs...

Please bump or delete.

@jcogs-design this has been merged. Thanks for the hard work this!


Add LIKE operator support. Fixes #METAMODEL-136

I agree, we should be using replaceAll instead of replace but I think we need to keep the if in the turnOperandIntoRegExp method to prepend "^" when the like operand is like "MALE%" (pick up just elements starting with MALE). If we remove this condition we will pick up ALWAYS every string with the MALE substring in it and this is not what we want.

Changes suggested by @LosD implemented. Thank you again!

Minor issue left, but looks good to me! :)

Minor issue addressed. ping @LosD

Looks super! Let's merge it.

Though Travis seems to have failed?

Okay, seems unrelated (ElasticSearch). @kaspersorensen also mentioned that we have had Travis problems with ES, so still good :)

Yes, not sure what's going on with Travis but I've seen some builds of the PR "green"

I'm pretty sure it's not a problem; both Java 7 & 8 completes successfully, and (much unlike the ES code) there is nothing in this code that should be affected by the JDK version.

Looks good, I'll push it.


Update jmx_auth_test on Windows for config file changes

This pull request is intended to fix CASSANDRA-11730.
I originally PRed a fix to this issue as PR #1175 but the config file contents concurrently changed in CASSANDRA-12109, so the replace was no longer working correctly. This now passes correctly on trunk.
@mambocab to review probably, since he reviewed the original.

+1, based on visual inspection of this change and of 9eae8d340cb00fcabcab9b1c8c0d85943eac061b


Update mcd_parser.py

Lines 126-129 are used to sort based on DataStartOffset and DataEndOffset.  It sorts alphabetically which is incorrect, since the data is integer data.

merging directly to main


Create search for city to get weather

A search bar that can search for a city and return the weather for that city

done!


Cast using expected type

This is a breaking change, since the interface of the caster changes. So probably need to be queued for a major release.

In my casters I sometimes need the expected type. Eg: when casting a EventSauce Id It is cumbersome to pass the expected ID class to the caster when it is already typehinted in the constructor
final readonly class SomeCommand
{
    public function __construct(
        #[IdCaster(AuthorId::class)]
        public AuthorId $authorId,
    ) {}
}

The expected type is already known in the hydrator, so with this PR we can change the caster to:
final readonly class SomeCommand
{
    public function __construct(
        #[IdCaster]
        public AuthorId $authorId,
    ) {}
}

Or even register it is default caster, so we don't have to annotate our ID's anymore.

This is a breaking change, since the interface of the caster changes

@Robertbaelde I am looking for similar functionality, wouldn't it be possible to do this without a breaking change if we created 2 new interfaces and deprecated the older ones (whilst still supporting them)?


dNetHack ascensions list has invalid role/race combos listed

Notes I made while looking over it:
Archeologist:

add neutral clockwork automaton.

Anachrononaut:

I'd just kill Android overall as a race listed, since it's "clockwork automaton" in the selection screen. Could it be possible to hook up the scoreboard to read And / And-Ana as Clk? Otherwise just clear it from everything but neutral anachrononaut in the list I suppose.
Remove lawful dwarf, human, half-dragon, incantifier, vampire.
Remove gnome, yuki-onna, orc.

Binder:

Remove every alignment but non-aligned.

Convict:

I have no clue what's up with this but every non-chaotic alignment should be removed, and it should have every race.

Noble:

Remove android, chiropteran, clockwork automaton, gnome, orc, yuki-onna
Remove lawful, nonaligned drow
Remove nonaligned half-dragon, incantifier, human
Remove lawful, nonaligned vampire

Monk:

Remove nonaligned human

Pirate:

Remove android, chiro, clockwork automaton, gnome, half-dragon, orc, vampire, yuki-onna
Remove lawful, neutral, nonaligned drow
Remove lawful dwarf
Remove lawful, nonaligned human, incantifier

Priest:

Remove nonaligned human, incantifier

Troubadour:

Remove android, chiropteran
Remove lawful, nonaligned clockwork automaton, half-dragon, human, incantifier, yuki-onna, vampire
Remove lawful, neutral, nonaligned drow

In case different tables are in different locations, this was the issues with the First Combo Ascensions page on 1/27 with regard to dNetHack 3.20.0.

idk who fixed this but someone did at some point, issue stale


Register and schedule Micrometer MeterRegistry when Meters are registered

What does this PR do?

As reported in https://github.com/spring-projects/spring-boot/issues/26630, premature initialization of Micrometer's MeterRegistry in Spring applications may cause metrics loss.
This PR attempts to work around this issue assuming that Meters are only registered to fully initialized meter registries.
This assumption is yet to be verified.
Checklist

[x] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that would fail without this fix
[ ] I verified the described issue is resolved using this fix where it is reproducible without this fix

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-11T07:37:58.487+0000

Duration: 70 min 56 sec

Commit: 302e18230839809d0b11371761c996931c3a7211

Test stats :test_tube:

Test
Results

Failed
0

Passed
2521

Skipped
19

Total
2540

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark test.

run compatibility tests : Run the JDK Compatibility test.

run integration tests : Run the APM-ITs.


UInt is not documented

Are there any other undocumented unsigned types?

Completed by @tbrowder in August.
See https://docs.perl6.org/type/UInt


Using LUCENE filter in WHERE clause along with other filters

Using a LUCENE fulltext index at the same time as another index does not work. Therefore you must use subqueries to limit the result, which is very inefficient when there are many records.
The query...
SELECT * FROM Person WHERE firstname LUCENE 'Tobie~ OR John~ OR Will~'

works correctly, but...
SELECT * FROM Person WHERE cool=true AND firstname LUCENE 'Tobie~ OR John~ OR Will~'

returns no records, and does not produce any errors

Using a subquery is successful, but will not use indexes on the outer query and is therefore pretty inefficient on large data sets...
SELECT * FROM (
    SELECT * FROM Person WHERE firstname LUCENE 'Tobie~ OR John~ OR Will~'
) WHERE cool = true

OrientDB version: 2.0.2

Hi,
I am facing the same issue.
I have 4 tables, Table1, Table2, Table3 and Table4. The search function will first hit Table1 which is indexed using Lucene Engine. I fetch the records using the "lucene" keyword in my query.
Now, I use 'IN' clause to fetch data from Table2 based on data from Table1.
The data I receive from Table2 is used to perform multiple queries on Table3 and Table4 and then joining them using "UNIONALL" function.
Now this method works but is taking too long to process the query.
I am using the Graph API of tinker pop.
I would really appreciate any help regarding this or any other method by which I can attain the same.

Backported to 2.1.x you can use lucene along with other filters


Proposal: Set removeViewBox to 'false' in webpack's optimization settings

Disable removal of the SVG viewBox by default to improve compatibility. See this Discourse thread: https://discourse.roots.io/t/svg-size-change-upon-yarn-build-production/12320

thank you!


Allow PairwiseOidcRegisteredServiceUsernameAttributeProvider to be extended

Hello,
I would like to provide a custom sector identifier algorithm for my OIDC services.
So I have changed the visibility of private inner methods to allow them to be overridden.
If you agree with this, I'll propose the same for 6.2.x branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

this change does not break serialization

Do you mean the new class definition could break deserialization of existing PairwiseOidcRegisteredServiceUsernameAttributeProvider serialized instances? (in database for eg.)

It would likely be best if you just wrote your own provider.

By overriding in the classpath the CAS PairwiseOidcRegisteredServiceUsernameAttributeProvider class by our PairwiseOidcRegisteredServiceUsernameAttributeProvider class?
Or by extending it and then by registering our new MyAttributeProvider with plan.registerSerializableClass(MyAttributeProvider.class)?

Do you mean the new class definition could break deserialization of existing PairwiseOidcRegisteredServiceUsernameAttributeProvider serialized instances? (in database for eg.)

Yes, or back and forth from/to JSON or YAML.

By overriding in the classpath the CAS PairwiseOidcRegisteredServiceUsernameAttributeProvider class by our PairwiseOidcRegisteredServiceUsernameAttributeProvider class?

This is one option, you just can write your own.

It would likely be best if you just wrote your own provider.

So that's what we are already doing :-)
I wanted to avoid to duplicate most of the code of PairwiseOidcRegisteredServiceUsernameAttributeProvider.
But I understand the risks.


Add bomb feature

👉 Checklist

Please make sure to check off the following before submitting:

[x] I have reviewed my submission thoroughly.
[x] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
[x] I have run the JUnit tests (if submission is related to coding).
[x] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.

classes Bomb.java and BombComponent.java added
file bomb.png added
DinosaurController.java and EntityType.java and GameEntityFactory.java and PauseMenu.java modified

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.

[X] This Pull Request fixes the issue : 'Closes #121'
[ ] This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤ Thanks for contributing to this project 🦖

Awesome work, thanks for the PR !! And sorry for the delay ! Just resolve the conflicts, thank you !

Thanks for the review! I just resolved the confict. Please let me know if there is still any bugs. :)

Thank you so much for your contribution !!


Use with internal soundcard

Hello , i just want to know if it is possible to use it with just the internal soundcard of a macbook with vcv rack for example.
Ive tried with sunflower but no success. The audio doesn’t get to the scope. I would be happy about any help.
Update : Ive Tryed to use it with an RME UCX Soundcard all set to 44.1.
it doesnt take any input.not in version 10.9/10.7./10.6
it remains black
Merci

hey
closing this, because it looks like the switch to miniaudio is staying around, so all the audio i/o bugs will be new and different :)

i have realy no idea what that means?
switch to miniaudio ???
Am 15.08.2019 um 08:12 schrieb hansi raber:

miniaudio


Joe Danger [PCSE00478]

App summary

App name: Joe Danger
App serial: PCSE00478
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 2861
Commit hash: https://github.com/Vita3K/Vita3K/commit/45bdd66556b6c6c49411c58c0aeb8f12973cf40c
CPU backend: Dynarmic
GPU backend: OpenGL & Vulkan

Test environment summary

Tested by: someone
OS: Windows 7
CPU: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz, 4001 Mhz, 4 Core(s), 8 Logical Processor(s)
GPU: NVIDIA GeForce GTX 1080
RAM: 16 GB

Issues
Hangs on the initial loading screen regardless of GPU backend.
Screenshot

Log (for OpenGL)
vita3k.log
Recommended labels

Intro

Vita3K Summary

Version: v0.1.6
Build Number: 3039
Commit Hash: https://github.com/Vita3K/Vita3K/commit/92524b65514c54ccae57f1a64a62876c65d95a7a
CPU Backend: Dynamic
GPU Backend: Vulkan
CPU: Intel Celeron N3350
GPU: Intel Grahpics 550

Game Summary

Game Name: Joe Danger
Game Serial: PCSE00476

Issues
Got some major graphical glitches on the font and the menu because of Vulkan. Initally got Unicorn errors on first try, but it got ingame on my second try.
Screenshots

Logs
vita3k.log (First Try)
vita3k (Second Boot).log (Second Try)
Recommended Labels

Ingame +
graphics bug

As of https://github.com/Vita3K/Vita3K/commit/1b0e65e66d17202b1ae9f155cfecea802dd58778, the graphical problems are fixed.
Screenshots

Log
vita3k.log
Recommended labels
Playable


Can ajv-ts be used for inferring the schema type?

I see that typeschema doesn't have Infer capabilities for ajv. But there's a typescript version, could it be used for that?
https://github.com/vitalics/ajv-ts

Launched on @typeschema/json v0.13.2
You just need to also add the json-schema-to-ts dependency


Incorrect type annotation for generated File.payload

Describe the bug
In this line:
https://github.com/openapi-generators/openapi-python-client/blob/26e7e0ff8fc512141c71f72260cf24d635dc3bf5/openapi_python_client/templates/types.py.jinja#L22
BinaryIO is the incorrect type. What is actually returned by the generated client is BytesIO.
This causes the following type check error when trying to use BytesIO methods.
file.payload.getbuffer()

Mypy error:
error: "BinaryIO" has no attribute "getbuffer"

Even though at runtime there is no issue here.
To Reproduce
Generate a client that uses File, and inspect the type of file.payload at runtime. It is BytesIO.
Expected behavior
No invalid type checking errors when using File.
Desktop (please complete the following information):

OS: macOS 11.6
Python Version: 3.9.10
openapi-python-client version: 0.11.1

Hmm, I tried to open a PR for this, but reading the httpx docs:

https://www.python-httpx.org/quickstart/#sending-multipart-file-uploads

httpx does want a BinaryIO (not BytesIO) on the sending side.
That makes this part of the template correct:
https://github.com/openapi-generators/openapi-python-client/blob/26e7e0ff8fc512141c71f72260cf24d635dc3bf5/openapi_python_client/templates/types.py.jinja#L15
https://github.com/openapi-generators/openapi-python-client/blob/26e7e0ff8fc512141c71f72260cf24d635dc3bf5/openapi_python_client/templates/types.py.jinja#L26
What I'm guessing is going on is that for sending a File, payload needs to be BinaryIO but when receiving a file, we get back BytesIO since there is no actual open file involved, httpx is just handing us the bytes from the stream.
So perhaps the fix is:
 payload: Union[BinaryIO, BytesIO]

Or perhaps File should be make asymmetric (e.g. SendFile and ReceiveFile so that the types can be strict)?

A minimized example of the schema that surfaced this issue for me:
  /api/file-conversions/{id}/:
    get:
      operationId: api_file_conversions_retrieve
      description: Convert file
      - in: path
        name: id
        schema:
          type: integer
        description: A unique integer value
        required: true
      responses:
        '200':
          content:
            application/octet-stream:
              schema:
                type: string
                format: binary
          description: ''

@dbanty Curious if you've had time to look at this. I've run into this again and would like to submit a PR, but I'm not sure what direction you'd think would be best.

I just looked over it quickly—sorry I've been mostly incommunicado recently. I thought that typing.BinaryIO was the correct type for io.BytesIO. I think it's a super-class (like assigning BytesIO to BinaryIO should be valid), but I guess if you need methods specifically on BytesIO for receiving, then we'd better do a better job.
A separate type for sending vs. receiving is probably appropriate, even though it's not as clean 😞. A union would still require runtime checking to access BytesIO methods safely.

sorry I've been mostly incommunicado recently

Not a problem!
For future reference the line of code that creates a BytesIO is here:
https://github.com/openapi-generators/openapi-python-client/blob/3c86a7084688d4b187f46218d3661ab06690c111/openapi_python_client/templates/property_templates/file_property.py.jinja#L3
Okay, looking at this again with fresh eyes, I'm realizing now that I should have simply done:
file.payload.read()

Looking back, what I think happened to twist me up is that I was using PyCharm's debugger and noticed that it was actually BytesIO at runtime, so tried to start using BytesIO-specific methods on it. In reality, I think it's probably valid to "expose" the interface as typing.BinaryIO and "erase" the BytesIO methods as there is no real need to call getbuffer().
So, after all this I don't think this is actually a bug (even though we could express the type more clearly) and so I'm inclined to close this issue if you are. 😄

Sure, if you can do everything you need with the BinaryIO interface then let’s leave it as is for now 👍. Thanks for doing all the research here, hopefully, it’ll help someone else in the future if they encounter the same thing 😊.


[ENG-9602][eas-cli] rollouts: json output for ci

Why
Support JSON output for CI when the --json flag is passed in non-interactive mode
Test Plan

[ ] manually tested

/changelog-entry new-feature rollouts: json output for ci


Select+zoom-in-bug & improved graphics

Description of your problem
What steps will reproduce the problem?

Select all chars in the Terminal
Right click with the mouse
Click 'zoom-in'

What is the expected output? What do you see instead?
I can't see anymore the chars. The cursor instead keeps pulsing and is visible.
Please provide any additional information below
I just changed the cursor to be the underscore.
Versions and main components

Terminal Version: 0.3.0
Spyder Version: 4.1.5
Python Version: 3.7.9
Operating system: Win 10

More questions:

I can't change the color of the highlighted text (now is ugly yellow)
The zoom is not so effective on the text: the text is not so clear like the IPython console or Conda Prompt.

For illustrative purposes, I attach the following.
Thanks for all you job and support.
Sincerely,

Hi @MCilento93, this issue was fixed in our latest release, please type the following in a console to update to the latest version,
conda update spyder
conda install spyder-terminal -c spyder-ide

Thanks for reporting!

Hello Steff and thank you for helping me.
Unfortunately, now it get worse: I have spyder 4.1.5 with spyder-terminal at 0.3.0 (I didn't succeded to install a later version) and I see a fully black/white screen (without chars, except for the cursor).
Like now, the terminal is not usable anymore.

I tryied with a fresh environment.
It does not work with python=3.7 neither python=3.8
For now I keep using GUI bash console :/

Hi @MCilento93, this is an error that we are working to fix it and will be available in our next release :D


Syncing currently attached relationships updates the updated_at timestamp even if the data has not changed

Laravel Version: 6.5.1

Description:
When syncing a BelongsToMany (using ->sync()) with a custom pivot class, the pivot table updated_at timestamp is being updated even if the data has not changed.
I believe the issue may come from the following lines, within Illuminate\Database\Eloquent\Relations\Concerns\InteractsWithPivotTable, and the updateExistingPivotUsingCustomClass method.
https://github.com/laravel/framework/blob/6.x/src/Illuminate/Database/Eloquent/Relations/Concerns/InteractsWithPivotTable.php#L221-L244
$updated = $pivot ? $pivot->fill($attributes)->isDirty() : false;

$pivot = $this->newPivot([
    $this->foreignPivotKey => $this->parent->{$this->parentKey},
    $this->relatedPivotKey => $this->parseId($id),
], true);

$pivot->timestamps = in_array($this->updatedAt(), $this->pivotColumns);

Specifically $pivot->timestamps, which is detecting that the pivot uses timestamps and therefore adjusting the updated_at column value. Should it not take into account if the currently attached pivot has been modified?
This could be achieved by changing:
$pivot->timestamps = in_array($this->updatedAt(), $this->pivotColumns);

to:
$pivot->timestamps = $updated && in_array($this->updatedAt(), $this->pivotColumns);

I'm actually not sure tbh. Maybe it's best that we gather some more opinions before marking this as a bug.
@staudenmeir do you have any idea maybe?

Sure yeah. I've written a short example to try and help out better understand.
An Item model has many Fields, with the relationship $item->fields(). A pivot table field_item holds the field_id, item_id and value (as well as timestamps updated_at and created_at). A user can then assign fields to items and hold a record of when those individual fields against the each item were last modified.
$item = Item::create();

$nameField = Field::create([
    'name' => 'name',
    'type' => 'string',
]);

$item->fields()->sync([
    $nameField->id => ['value' => 'Foo bar item'],
]);

This would create an item and a field, and then associate that field to the item, with a value of "Foo bar item" as the "name".
If the item was then updated (let's say through an API or CRUD style backend), the ->sync() would run again, i.e.
$item->fields()->sync([
    1 => ['value' => 'Foo bar item'],
]);

As it currently stands, this appears to increment the updated_at timestamp on the pivot entry for the item/field combination, despite the value not actually changing.
It should only update the updated_at timestamp on the pivot, if the name was changed - i.e. say the following was ran:
$item->fields()->sync([
    1 => ['value' => 'A different name for the item'],
]);

Hope that is of some use 😊

/cc @ralphschindler

It makes sense to me that the association is updated after calling sync() method.
As documentation states:

Any IDs that are not in the given array will be removed from the intermediate table.

If you need to know when the association has been created you can probably use created_at instead of updated_at.

@ralphschindler can you maybe weigh in here if you have a minute? thanks :)

I just ran into this issue after upgrading from 6.4 to 6.16.  I have a table of events that only uses created_at (events are never modified, thus no need for updated_at). Events belong to users so they are add via attach. When attaching users to events, this property on the Event model is seemingly ignored in the corresponding query:
const UPDATED_AT = null;
I'm using this workaround until the issue is resolved or there is further clarification on how this should be more appropriately handled:
    public function setUpdatedAt($value)
    {
       // do nothing
    }

Is it better practice to set $timestamps = false; and just handle created_at without the convenience of Laravel's automatic timestamp management?

@moraleslevi yes:

PR for this was merged.

@timrspratt btw this should also already be fixed in 7.x so can you try it out on Laravel 7?

Thanks @driesvints , I can confirm it's working 😊


Bump version to 0.8.1

@DurgNomis-drol
Can you create a new 0.8.1 version release?

Just released a new one!


lake init generates an incorrect lean-toolchain when used with an -rc toolchain

mkdir /tmp/new-project
cd /tmp/new-project/
elan default leanprover/lean4:v4.0.0-rc4
lake --version # ensure we're using -rc4 toolchain
lake init NewProject
lake build
# error: could not download nonexistent lean version `leanprover/lean4:rc4`
cat lean-toolchain
# actual: leanprover/lean4:rc4
# expected: leanprover/lean4:v4.0.0-rc4

Closing, no error on leanprover/lean4:v4.1.0-rc1


upload file size limited to 30M

where is the conf-file to setup the file size limit?

It's on the add-on configuration tab

Thank you very much.

Thank you very much.


Adding IMAP-Lo dependency

Change Summary
Overview
Adding IMAP-Lo dependency

I think this looks good. A lot of this is up in the air right now because we reorganized products in both L1B and L1C and removed some things in L1B, so the dependencies are a little blurry to me right now. Colin is working on updating the algorithm document to reflect those changes. I think this is good for SIT-3 though. Thanks for doing this!
Will it be a problem to leave the badtimes and goodtimes as tbd? I still have no idea how either of those are going to be made yet.

I totally understand. We can iterate on this as you need. To you last question, it won't be triggered since we won't be producing data product with descriptor tbd. I am mainly using that as place holder for future.