Add html input validation in the form component

Details
WAF input rules filter out html/xml tags in most API parameters. Given that we rarely want users to submit html tags as inputs, we have decided to validate all inputs for html. And we will do so in the Form component.
Here is what it would look like:
First/Last Name-

Workspage Settings -> General -

Fixed Issues
$ https://github.com/Expensify/App/issues/14610
PROPOSAL: GH - Slack
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps
Let's test that it picks up for html tags, but the focus here is to make sure we don't have regressions

[ ] WorkspaceNewRoomPage.js

Create a new workspace room.
Add a name with html tags test<b>. Verify that there is an error
Now delete part of it so that it looks like test< and verify that you get an error saying you can only have characters
Now delete it so that its just text test. Verify that error is gone.
Select a workspace below that field. And submit and verify that you can create a workspace room
https://recordit.co/JgPnzb7FZf

[ ] CloseAccountPage.js

Have an account you're willing to close
Go to Security -> Close Account
Type in a message with html tags hello <b>. Verify you get an error
Now remove the html tag, hello
Add the email and close the account.
https://recordit.co/64J5ZbsT7i

[ ] WorkspaceSettingsPage.js

Go to Workspace Settings -> General Settings. Input <b> </b> as the workspace name. Verify that you see an error when you blur the field or submit the form
Remove the tags, add a valid name, and confirm that workspace name saves successfully
https://recordit.co/WW3Ne7UKHZ

[ ] DisplayName

Go to settings -> profile. Display Name
Add a name with a html tag in it Kosuke<b>. Verify that you get an error message
Remove the tag and verify that you can add a name successfully

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://recordit.co/0eTSnGSP6r

Mobile Web - Chrome
https://recordit.co/cIOjb7gHc7

Mobile Web - Safari
https://recordit.co/0L0CmlQRJF

Desktop
https://recordit.co/rrvronUa7p

iOS
https://recordit.co/6mxyX6mqLe

Android
https://recordit.co/F8zbIrxmPn

@eVoloshchak @tgolen One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Waiting on copy, but ready for an initial review. Been testing it pretty heavily

Tests well on all platforms
I think there are cases where this error superseding other errors isn't the best option, for instance on BankAccountManualStep. The error will be Please enter a valid routing number for every symbol or invalid combination of symbols, except for when there is a tag.

This is a small issue though, it will look better with Invalid character error

Yeah that is a good catch @eVoloshchak . I'd say its a rare case in general. If someone putting anything resembling tags where a routing number is supposed to be, they should be notified that that act is not allowed.
The "Please enter valid Routing Number" to me, is a "friendly" message for "friendly" users

Copy updated. Ready for review

Updated

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

It seems like it's validating only the first input, on Legal Name page tags aren't allowed only for the first name

@tgolen Hoping you can take this over or finding someone who can

@eVoloshchak Could I get your help on this to try and dig into the code for why it's only validating the first input there?

@tgolen, sure thing, I'll look into this tomorrow as a first priority

@tgolen, I've found what's causing the issue, we're using _.every to iterate over the object with inputs

The _.every method checks if the predicate returns true for all elements of collection and iteration is stopped once the predicate returns falsely
We should use _.each instead.
I've added a comment, but I can't push into this branch

Ah, excellent! I can make the change. Though, it sounds like we are still figuring out if we want to do this or not in Slack. Thank you!

@eVoloshchak OK, I've committed that change for _.each(). I think we should move forward with this. If it turns out we want to revert this at some point in the future, I think that's OK.
I'm going to merge main into this branch too just to make sure it's up to date and fine for merging.

@eVoloshchak Looks like this just needs an approved review from you now. Are you able?

Thanks! @marcaaron Could you add a review, please?

Updated

Retested to be sure my curly braces are working

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.2.83-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/tgolen in version: 1.2.83-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.2.83-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


update AboutUs with Arsalan's profile

Pull Request Test Coverage Report for Build 13

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 92.811%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/commons/util/FileUtil.java
1
90.91%

Totals

Change from base Build 10:
-0.06%

Covered Lines:
1433

Relevant Lines:
1544

💛  - Coveralls


accept an array of env vars in Exec

This would be quite convenient, and also be an analog to Exec::arg and  Exec::args.
As an aside, it would also be more general than Exec::env, so maybe it can be used as a replacement (same as Exec::arg needs a deprecation).

Thanks for the suggestion, I've now added Exec::env_extend.


Progress to ignore key out_time_us

By ignoring warning messages about unhandled key out_time_us
are not displayed.
Fixes #191

Coverage increased (+2.8%) to 84.515% when pulling<PHONE_NUMBER>0d7fd2d5ab7f0a92a4666a5d859715 on jsyrjala:progress-out_time_us into 3819b155edf9132acc75bb6af66dcef1b98c64b2 on bramp:master.

Coverage increased (+2.8%) to 84.515% when pulling<PHONE_NUMBER>0d7fd2d5ab7f0a92a4666a5d859715 on jsyrjala:progress-out_time_us into 3819b155edf9132acc75bb6af66dcef1b98c64b2 on bramp:master.

OMG Sorry it's taken me 5 years to reply!  The mix of out_time_ms, out_time_us and out_time seems messy, especially when they are mis labelled.
Someone else has fixed this in https://github.com/bramp/ffmpeg-cli-wrapper/pull/289, and we've decided to just ignore all but out_time.
Thanks!


fix(NODE-3071): Ignore error message if error code is defined

Prior behavior was to check the error message if the code did not
correspond to the server state. With this change the driver will not
inspect the error message for error type. ServerDescriptions with
topology versions less than the current will be ignored.
NODE-3071, NODE-2559

Hey @emadum if you can take a look when you get the chance that would be much appreciated 🙂

Hey @durran just a reminder to take a look at this when you get the chance, thanks!


Not all symbols in commets are detected correctly.

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:09.760Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author (truncated)
Version

Doxygen
bbe
1.0.0

python
don
0.7.0

Go
luk
0.6.65

cpptools
ms-
0.13.0

vim
vsc
0.10.1

vscode-todo-highlight
way
0.5.11

Steps to Reproduce:

I installed C/C++ plugin by Microsoft.Then I edit semphr.h for FreeRTOS
2.If the line number is large enough, eg 1061, symbols in commet may not be detected correctly.

Reproduces without extensions: Yes/No

Please file issue against cpptools extension


Modernize the application & Performance tweaks

The repo seems to be a bit out of date and isn't using best practices when it comes to performance for React applications, so this article might be unrealistic for 2019 https://medium.com/free-code-camp/a-realworld-comparison-of-front-end-frameworks-with-benchmarks-2019-update-4be0d3c78075. This PR aims to change that

Used the newest versions of React and other dependencies
Migrate away from deprecated library react-router-redux to connected-react-router
Use PureComponents and React.memo for functional components for better performance
Migrate away from deprecated lifeCycleHooks like componentWIllUpdate, componentWillReceiveProps & componentWillMount
lazyload & codesplit non-default routes with React.lazy & React.Suspense

I have the same feeling and looking forward to this PR.

Any updates?

FYI, using your fork, logging out gives me this error:

@klamping steps to reproduce? I just run it locally and it works fine.

@klamping I was able to reproduce the issue, it should be fixed now.

Is anyone maintaining this app anymore? I would be happy to maintain it myself

@khaledosman One small thing I found, currentUser.image is broken if you define no image, isn't there a way already coded on the API to recover the profile.image smiley face and use it instead of displaying the alt message ?

@helderscrolls Thanks, I'm not sure where that broke as I didn't change any API related logic, I'll look into it later when I have the time.

@khaledosman I think it’s a issue that comes from the original Build, the only way I’ve found so far is to hard code the URL on the front-end, on the Header and the Comment preview that way even if currentUser.image is undefined it displays the smiley face

@helderscrolls This should be fixed now, I've added a fallback default image everywhere that is using user.image

There is a bug when trying to submit an article. To reproduce the bug try to register as a new user then submit an article without inputing a data on the fields.

@dabonnestor looks like validation is not implemented for this form, can you check if this works on master branch?

It has validation on the master branch.

this has been fixed.

You should be the active maintainer for this repo 👍

I also forked this project - to convert it all to Hooks. Then I noticed your excellent work here, @khaledosman. Lesson learned! I should check the existing forks before starting my own! I can't believe this has been sitting here for 6 months!
My hooks conversion went smoothly. I also attempted to do the updates you did (redux, deprecated react-router-redux, etc), but I ran into complications, so I kept my fork focused.
Just browsing your source, I don't see that you converted things to hooks, though you modernized everything else. Would you be interested in my attempting to merge my work with yours?

@shanebdavis absolutely go for it, you could make a branch out of mine.
I don't see the point if the contributors will ignore it anyway though.

I don't see the point if the contributors will ignore it anyway though.

I see that the main real-world repo is accepting pull-requests. I'll try to bug them over there.

@khaledosman There is this error when i click signin / settings or signup 👍
"Uncaught Could not find router reducer in state tree, it must be mounted under "router""

@ezorfa I couldn't reproduce this error, can you delete node_modules/ package-lock.json or yarn.lock and try with a clean npm install?
it seems the backend API doesn't support CORS anymore so I'm getting this error instead
localhost/:1 Access to XMLHttpRequest at 'https://conduit.productionready.io/api/articles?limit=10&offset=0' from origin 'http://localhost:4100' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

I added some checks to make the app render when the api returns an error, it seems like error states are not implemented though.

@khaledosman  which backed do you use?

@khaledosman  I get this error now:

Console:

I am using django backend.

@ezorfa I'm not sure, its whatever backend the app was using before, I think they all use the same backend because I got the same issue in the stencil-realworld-app aswell which uses the same endpoint https://github.com/khaledosman/stencil-realworld-app
The issue you saw is the one with the error state I just mentioned, please do a git pull to get my latest commit


Error with 'Getting Started': 'must provide --name NAME'

I am using Windows 8, Node Version 5.1.0
I get an error saying 'must provide --name NAME'.
While the error seems to have been solved when I have added a 'name' parameter, it still looks like a problem with the documentation, and at this stage as a beginner to tacodb I'm not familiar with what the significance of the db name is, and rely on the getting started example to work smoothly.

It turns out I hadn't saved the .js server config file.


Fix: generate PDF name from title instead of id

Fixes #836
This changes the generated PDF name from the ID to the title (e.g. Resume V34.pdf).

Sounds good to me, name is probably better than ID.


Can not edit/upgrade the app if the original chart is hidden by the rancher-version annotation

Backend issue for: https://github.com/rancher/dashboard/issues/4276
Look into filtering the chart only from the index.

Once the UI changes merge this will be ready to test

This can be tested along with https://github.com/rancher/rancher/issues/34875

Root cause
All api calls to the index, info, chart and icons endpoints start with getting the index file. This results in all of those calls happening against a filtered index file.
What was fixed, or what changes have occurred
A skipFiltering flag was added so that the filtering of the chart index could be more finely controlled.
The info endpoint now has skipFiltering set to false so that anytime we want to know all of the currently supported charts, charts will get filtered out properly.
The info, chart and icon endpoints have skipFiltering true, because if the chart exist in the repository, we should be able to get the chart info, the chart files and the chart's icon
Areas or cases that should be tested
Chart install, edit without upgrading, upgrade, uninstall. This should be done on a chart with and without crds
In rancher v2.6.0 install a chart that is not supported in v2.6.1 (i.e a chart with catalog.cattle.io/rancher-version: "<= 2.6.0-0" in the chart.yaml). After installing, upgrade rancher to v2.6-head, edit your chart installation without upgrading, upgrade and uninstall.
What areas could experience regressions ?
All catalog v2 api endpoints had the flag added, so all of the catalog section could. Since we are skipping filtering, it could regress where charts should've been filtered based on rancher-version or kubernetes version but no longer are.
Are the repro steps accurate/minimal ?
Yes
https://github.com/rancher/dashboard/issues/4276#issue-1005961299

Assigning @jiaqiluo for dev-validate here.

The following validations are done on both the local and downstream clusters:

run rancher 2.6.0 and add a downstream cluster
add the following GH repo as a repository, it is forked from the release-v2.6 branch

URL:    https://github.com/jakefhyde/charts
branch: add-min-rancher-version

go to Charts -> select only the newly-added repo
Confirmation 1: for all available charts, all versions show up in the Chart Versions list, there is no difference with the released branch
install the app Istio 1.9.600 into the cluster
upgrade rancher to 2.6.1-rc5
Confirmation 2: for all available charts, only the versions introduced in rancher v2.6.0 show up in the Chart Versions list; those versions which are also available in rancher v2.5.x are NOT in the list anymore
Confirmation 3: the installed app can be edited on the Installed App page: keep the version unchanged, just edit some value.
Confirmation 4:the installed app can be upgraded on the Installed App page: choose the new version from the list


opensync: Fix events timestamp

Added milliseconds timestamp precision
Replaced realtime clock with monotonic
Data type changed to uint64 to hold millisecond timestamp

Signed-off-by: Yashvardhan<EMAIL_ADDRESS>

Merged, thanks.

Merged, thanks.


Cannot add methods when inheriting native Array class

I want to create a class that inherits the native Array class (as its prototype). However, I found that the methods I append to the inherited class are missed when being compiled.

TypeScript Version:  2.4.2
Code
// This class inherits the native Array class
// and has its own method "getFirst"
class MyNewArray<T> extends Array<T> {
    getFirst() {
        return this[0];
    }
}

// Create a new "MyNewArray" instance
var myArray = new MyNewArray<string>();
myArray.push("First Element");
// Print the first element by calling its "getFirst" method
console.log("getFirst", myArray.getFirst()); // "First Element"

Expected behavior:
The code should print the first element of myArray, i.e., "First Element"
Actual behavior:
The code raised an exception, saying as following:
console.log("getFirst", myArray.getFirst()); // "First Element"
                                ^

TypeError: myArray.getFirst is not a function
    at Object.<anonymous> (/Users/cosmozhang/work/temp/t.js:23:33)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

Duplicate of #18035 (and many others)
Also covered in the FAQ Why doesn't extending built ins like Error,
Array, and Map work?
Search is your friend!

Should really just have a bot that detects the string "extends Array" in bug reports


TextureRegion Editor LMB Not changing selected region

Operating system or device - Godot version:
Manjaro 64bit Godot 3.0
Issue description:

When I try to edit the texture region of a sprite in the texture-region tab I can't get the frame to move or resize without changin the values in the property panel
Steps to reproduce:

make a sprite
load a normal map with sprite
enable region selection
open texture-region tab
try to change animate your sprite using regions....groan showing your level of irritation...slap self in forehead.

Link to minimal example project:

2dtests.zip
possibly related to #9281
@Zylann do you know if your PR will fix this bug?

My PR won't fix it, it's not related to docks or even 2D stuff.

patch available on PR #9293


MAINT: extra pythran annotation for i686 support

Bug spotted on Fedora, see https://src.fedoraproject.org/rpms/scipy/pull-request/22
The int[::] annotation is used to accept non-contiguous views.

The int[::] annotation is used to accept non-contiguous views.

Ah that's good to know, I had not seen that before.

I think int[::] should be used in most annotations then?

It generates an additional prototype, which implies longer compile time and larger binaries, but yeah, it's useful ;-)


[Wait for #1230] [Example] Concat example

[Pending commit: #1230]

[Example] Concat example

This patch adds concat example with embedding

The structure is

      (input)
     /       \
  (embed1)   (embed2)
    \         /
      (concat)
         |
      (flatten)
         |
        (fc)

**Self evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1231. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnstreamer.mooo.com/nntrainer/ci/repo-workers/pr-checker/1231-202106011417070.88448810577393-277f44b22e34b36d6db4bf70a94334dd98234c8f/.


testdata not created during pascal run?

Describe the bug
Looking at nightly test run post @JustinPrivitera's blueprint additions, new tests are failing with blank images.
https://visit-dav.github.io/dashboard/2022-03-08-22:00/pascal_trunk_serial/databases_blueprint.html
@brugger1 , Justin did add a new data file - could this be that the pascal script needs a make testdata instead of just make data?
https://github.com/visit-dav/visit/blob/f31e3886db8be9501ffe98303b6dafafec703090/src/tools/dev/scripts/regressiontest_pascal#L371

Ok make data and make testdata are the same,
Maybe there is another issue.

I figured out the issue, the 7z file we added did not have test_data pattern in the name. This was an oversight by me.

Good catch. I don't think I knew that. Are you going to fix or would you like me to?

I think Justin is going to fix with a PR.

Sounds good.

I think Justin is going to fix with a PR.

Can confirm yes I am doing this


Minor corrections to README

Removed "Premium" from Az File Share because standard is supported too.
Fixed "workplace" to "workspace."
Some Markdown linting.

Thanks for your contribution @SvenAelterman


Travis CI build fails intermittently

Sometimes the build fails because of a missing maxCanvasPixels property. Build https://travis-ci.org/mozilla/pdf.js/builds/519475880?utm_source=github_status&utm_medium=notification is an example with the following stack trace:
[22:18:21] Finished 'default_preferences-pre' after 7.48 s
[22:18:21] Starting '<anonymous>'...
[22:18:22] '<anonymous>' errored after 51 ms
[22:18:22] TypeError: Cannot read property 'maxCanvasPixels' of undefined
    at Object.<anonymous> (/home/travis/build/mozilla/pdf.js/build/default_preferences/lib/web/app_options.js:70:68)
    at Module._compile (internal/modules/cjs/loader.js:816:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:685:32)
    at Function.Module._load (internal/modules/cjs/loader.js:620:12)
    at Module.require (internal/modules/cjs/loader.js:723:19)
    at require (internal/modules/cjs/helpers.js:14:16)
    at /home/travis/build/mozilla/pdf.js/gulpfile.js:552:5
    at bound (domain.js:425:14)
    at runBound (domain.js:438:12)
[22:18:22] 'default_preferences' errored after 7.76 s

I think I have also seen it happening locally once, but I'm not entirely sure. Perhaps it's a race condition where the default preferences are not generated yet before the next task in executed?

Sometimes the build fails because of a missing maxCanvasPixels property.

Not sure that it matters much, but doesn't the error indicate that the problem rather is that the object (i.e. viewerCompatibilityParams) which is holding the property in question haven't been correctly initialized/loaded yet?
https://github.com/mozilla/pdf.js/blob/8dc2d21931a1ba73866d6df0a8b96df239bfd58f/web/app_options.js#L100

Perhaps it's a race condition where the default preferences are not generated yet before the next task in executed?

The problem might be that the default_preferences task runs twice during the setup phase, in the lint respectively the lib task, which I suppose could lead to intermittent issues with files not being found.

Marking as a good beginner bug since only knowledge about Gulp should be enough to fix this. Basically we need to make sure that our tasks don't run more than once, keeping the existing dependencies.

Hi,
I would like to work on this!

It's yours!

created PR #11411

Fixed by #11413. I'll open a new issue for the Gulp 4 migration changes.


Access to older versions of the documentation

[ x] I have searched the Issues to see if this bug has already been reported
[ x] I have tested the latest version

Summary
Currently I have an older version of flowbite-react (0.7.8)
Since I want to add 2 new components Popover and Drawer (which is marked as new) in the documentation I decided that I would like to update flowbite-react. However shortly after updating it I ran into issues with custom button theming not being properly applied. This issue was already raised here: https://github.com/themesberg/flowbite-react/issues/1445
Now I'm a position where I can't upgrade flowbite-react and I can't access the documentation for my current version of flowbite-react.
Context
I'm trying to access the documentation of the version of flowbite-react that I have now and from which I can't upgrade at the moment.

@lehelk I think that this is important, but... only once we reach the 1.0.0 release, as for the pre-stable release < 1.0.0 you can clone it based on the tag and build the documentation locally.


Custom build system refactoring

Hi again. Just so you know, I have been messing with the build tasks for quite a while now. Don't worry, though, it's good stuff :smiley:
To start, that custom task code you've written earlier was restructured and split in two related tasks.
The first one is a custom task, for the users. Essentially, same stuff as before, just a few subtle differences:

It accepts a new --usage flag, displaying the CLI options and listing the optional modules available. (Note: the flag --help is reserved by Grunt and can not be overridden.)

The --exclude flag is now optional. So, even if the user don't ever want to remove any module from his custom build, now he can do that. In contrast, it was only allowed to run the custom task if the user offered a set of optional modules to be excluded or the task would fail, which seems quite counterintuitive.

The second one is a newly created, Grunt build-phaser multi-task, based on your previous work. This is the main task, used internally for Phaser releases. I found that this kind of specialized task can benefit from much of Grunt's features, much like how the 'contrib' plugins do.
So now, along with the custom task, the following build tasks are now available too:

build-phaser:standard builds the main phaser.js release file.
build-phaser:arcadephysics for the AP-only custom build.
build-phaser:nophysics with no physics engines included.
build-phaser:minimum including only the required Phaser modules.
build-phaser:full, which embeds all available Phaser modules.

Some notes here:

I did some interpretation of what a 'full' or a 'standard' build is, so I named the tasks such way to avoid confusion.

Due to its nature, the 'full' task is not ran by default, only the former four.

The first four tasks are aliased to simpler names, with the build-phaser: prefix omitted.

So, much of the work done here ensured that the distribution tasks worked the same as before. For you, that means you'll use Grunt to manage Phaser releases the same way you're used to, no big surprises.
Much of the improvements, though, were made in the (you guessed it) tasks internals, and I tried to tackle much of the limitations you may have struggled to solve. The main issues I've found dealt with how the various Phaser modules are managed, including dependency tracking, and how the users choices need to be processed.
The first issue I tried to alleviate was how modules are declared and managed. Before, you had to edit code in three different places to manage modules. In the Gruntfile, there was an object accounting for the module ordering, and information like a module description and whether it's required or optional. The manifests JSON files where just mere file listings. The concat sub-tasks were the worst part, making for most of the code bloat. There were also the stub files, should a module being excluded from a given build still being required somehow. And two minor cases: the support for Tilemaps AP being an 'opt-in'; and the entry for the 'Creatures' module missing in the concat configuration file.
To simplify that process, all the information required for a module was combined in a single place — inside each manifest file. So, I ended up devising the following format for the JSON files:
{
    "description": "A module's description",
    "optional": /* a boolean value */,
    "dependencies": {
      "modules": [ /*an array of module names this module depend on*/ ],
      "reason": "Some explanation why the above modules are necessary"
    },
    "files": [ /*the source file listing*/ ],
    "stubs": /*an array listing stub files, or a 'null' value meaning none*/
}

An index.js file inside the manifests directory is responsible of tracking module ordering — away from the task file. Also, manifests now carry information about module dependencies.
That greatly simplifies how modules are selected and bundled together. Modules are no longer concatenated and its partial results placed in a temporary directory. Instead, Module files are read directly, avoiding the necessity for concat sub-tasks -- which is one file less to edit.
The main benefit here is that you have less things to worry about. If you introduce a new feature in Phaser, just edit a new JSON file, like above, declare it in the manifests/index.js, and it's done.
The next issue is about dependency tracking. When processing users choices, some problems may arise. What if s/he tries to remove a required module, like 'gameobjects'? I noticed that there was no way to avoid that, the required module could just go missing, resulting in a broken build. What if a new module depended on some other, optional module? More code was required to link these pieces and handle the dependency properly.
At the expense of writing some more code, some routines were developed to guarantee that the task could run properly, producing the desired results and aiding on automating this process. One to filter invalid user inputs, be it unknown modules or not optional modules. So, for example, if users misspell some module names, the filtering invalidates the input, and the reasons why are reported back to them. Then, the dependencies of each optional module are evaluated, and if one is missing, the module gets removed too — same behavior as the original task code.
As for the stability of the newly written tasks, I used them to build Phaser v2.3.0, with almost no differences -- only the version tag and the time stamp.
Lastly, I upgraded some of the Grunt's plugins to their latest releases.
To summarize, this branch adds the following files to the tasks directory:
tasks/
├── build-phaser.js           # The `build-phaser` multi-task.
├── custom.js                 # The `custom` task.
├── helpers/                  # Helper modules for:
│   ├── selectBuildFiles.js   # * Files selection.
│   └── validateExcludes.js   # * Validation routines and filters.
├── manifests/
│   └── index.js              # A CommonJS module index for the JSON files.
└── options/
    └── build-phaser.js       # The multi-task configuration.

Wow, that's quite some work here! I'll merge it and start testing with 2.4 later today, but it sounds great from what I've read above, so thank you.

Hmm I can't merge this from Github for some reason. I could do it locally of course, but if you want to fix the PR so it doesn't conflict any more let me know and I can merge directly.

Well, I've tried to reproduce the issue and merge the changes locally just to be sure what the conflict is — I keep an up to date copy of the Phaser repo, just in case. As I've suspected, the only divergent file is the PIXI manifest file (tasks/manifests/pixi.json), due to upstream changes (photonstorm/phaser@fb4709fb1a7cab930c7550dacf88fb482904966e). I did one last commit to track that change a while ago, I guess it's safe to replace the current file with the one in the PR. I'm afraid you'll have to do this in your local copy though.
One way to solve it locally is, after failing the merge, issuing git co --theirs -- tasks/manifests/pixi.json in a command prompt/terminal, then adding the file again before commiting.

Ok, never mind that previous silly comment :)
I rebased the branch, so it's OK to merge again, without conflicts.
Please, before merging these into dev, do some tests with it to see if everything goes OK for you.

Oh man, it's broken again. :cry:
Rich, still interested in delivering this feature along with Phaser yet?
It may take a while for me to fix the conflicting changes this time, though. What you think?

It's probably just broken because I had to add in 2 new modules to the build task, nothing else changed there (I literally just added in the rope and tilesprite modules). I'm still interested in merging this, but it was just too much to take on for the 2.4 release.

I'm closing this pull request for now. It seems that the requirements of the custom task have changed quite a bit since last time and are not compatible with what I have done earlier back in May. That'll require more time to review and doing a git rebase like earlier is impossible at the moment. I'm not quitting, though, some of these commits will be reviewed and pushed as smaller patches later instead.


[Bug/漏洞] Players without Infinity Boots equipped randomly jump higher

Checks / 检查

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting./我确认在报告之前我已经搜索了现有的问题或者拉取请求，以避免重复报告。
[X] I confirm that I followed the Docs and read the Changelog, but this problem still exists./我确认我按照文档配置并阅读了Changelog，但这个问题仍然存在。
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly./我确认我已经检查，如果我不按照说明进行操作，该问题可能会被直接关闭。

Java Version / Java版本
17.0.7
Minecraft Version / Minecraft版本
1.20.4
Avaritia-Reforge Version / Avaritia-Reforge版本
<IP_ADDRESS>
Description / 描述
Players without Infinity Boots equipped jump higher every other game tick.
This is because every game tick, committee.nova.mods.avaritia.init.handler.AbilityHandler adds every player without Infinity Boots which is not in the entitiesWithBoots to that HashSet and removes every player without Infinity Boots who is in that HashSet. Therefore this effect happens every other tick.
The jumpBoost event is processed for all players and checks if they are present in that HashSet. Players without Infinity Boots equipped are present in that HashSet every other tick, therefore every player will jump higher every other tick without Infinity Boots.
Players with Infinity Boots equipped do not experience such a bug. No other armor effect seems to trigger without the armor equipped, only the Infinity Boots jump boost every other tick.
To Reproduce / 重现
Do not equip Infinity Boots, and jump on random ticks. Holding jump takes an even number of ticks so you can't hold jump, it has to be random.
Log / 日志

Config / 配置
default (fresh instance made exclusively to test)

1.20.4 in plan

This issue was bothering me on my world for a whole day and then I found out this issue. Sadly can't have Avaritia installed.


Fix crashes due to catching AttributeError instead of KeyError

e.g.
echo 'repositories: {somedir: {type: git}}' | vcs import .
Traceback (most recent call last):
  File "/home/dan/.local/bin/vcs", line 11, in <module>
    load_entry_point('vcstool', 'console_scripts', 'vcs')()
  File "/home/dan/Documents/colcon/src/vcstool/vcstool/commands/vcs.py", line 26, in main
    return entrypoint(args)
  File "/home/dan/Documents/colcon/src/vcstool/vcstool/commands/import_.py", line 186, in main
    repos = get_repositories(args.input)
  File "/home/dan/Documents/colcon/src/vcstool/vcstool/commands/import_.py", line 67, in get_repositories
    return get_repos_in_vcstool_format(repositories)
  File "/home/dan/Documents/colcon/src/vcstool/vcstool/commands/import_.py", line 90, in get_repos_in_vcstool_format
    repo['url'] = attributes['url']
KeyError: 'url'

versus
echo 'repositories: {somedir: {type: git}}' | vcs import .
Repository 'somedir' does not provide the necessary information:

Thanks for the patch.


Unable to recover initial memory state in GP

(Tested in Mac)
Do the following steps

Start out in Genesis Plaza and check out the memory.
Teleport away to any given scene, and see the memory increase.
Go back to GP and press the FULL button in the Memory debug window.

Memory should be about the same, but there is a clear difference. We have to find out why since this indicates there is a leak
Example in MAC
Initial state

Teleport to scene -145,69

Went back to GP and pressed FULL

Memory is now at around 8100MB vs 7700MB from start. There are an extra 400MB that shouldnt be there

It seems that it does not happen when teleporting between worlds (I mean, when not visiting Genesis).

Detected memory leaks, textures related to NFTs are not referenced by any object. Steps to reproduce:

Enter Genesis.
Go to Olavra.
Go to Genesis.
Go to Olavra. Take first snapshot with Memory Profiler.
Go to Genesis.
Go to Olavra. Take second snapshot.
Compare both snapshots in Memory profiler.
However, it does not happen always, sometimes textures are referenced by some objects.

After Misha's changes (currently in a branch) that situation should be solved.

Maybe a decision has to be made regarding whether those images should stay in memory when moving to another world or not.

These accumulation of images related to NFTs were detected in Misha's branch. He has already fixed it.

This duplication of textures has been detected, although the number does not grow when moving to other worlds.


AMBARI-23927 Disabled alert status isn't "NONE"

How was this patch tested?
21532 passing (32s)
48 pending

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2411/
Test PASSed.


[FEATURE REQUEST] Links for registrations

Is your feature request related to a problem? Please describe.
It can be useful for closed registration and you will not need to create an account yourself for person
Describe the solution you'd like
Imagine a button which creates a link to register an account for a person by himself.
It can be random link for example https://site.com/reg/xxxxx
Additional context
Maybe that not important but for closed regs it would be great if you use chibisafe for a limited circle of people

This has been added in today's commit https://github.com/chibisafe/chibisafe/pull/344/commits/d6849d15a26bf77a41e78a0bd08a90240ad39404
Keep in mind this is not yet merged to master so it will take a bit longer to get there, but it exists as a feature now.


pip compile constraining combined with git based dependencies

First things first: I have to say that I never felt so encouraged to file issues at an open source project - as it is obvious that the chance of getting it fixed and soon is orders of magnitude higher than anywhere else!
Use case that fails:

I want to have requirements and dev-requirements that are guaranteed to be compatible: I want to make sure I am not running a package version in production that I do not have in my dev environment.
The suggested workflow for this I found is to compile the dev requirements first, and then use the resulting dev-requirements.txt as a constraint file for solving the production requirements like so:

	uv pip compile --extra dev -o requirements-dev.txt pyproject.toml
	uv pip compile --constraint requirements-dev.txt -o requirements.txt pyproject.toml

This fails in the case of having packages installed directly from a git repo. I have a repo in pyproject.toml like this:
PACKAGE_NAME @ git+https://__token__:${GITLAB_ACCESS_TOKEN}@gitlab.com/PATH_TO_REPO.git@my_branch
What happens is that the branch name gets resolved to a commit hash, and as a result the resolving fails:
error: Requirements contain conflicting URLs for package `PACKAGE_NAME`:
- git+https://__token__:${GITLAB_ACCESS_TOKEN}@gitlab.com/PATH_TO_REPO.git@intraday-main
- git+https://__token__:${GITLAB_ACCESS_TOKEN}@gitlab.com/PATH_TO_REPO@THE_FULL_COMMIT_SHA

I think we can support this as a sort of special-case (when URLs conflict, and one is a pinned VCS SHA, accept the pinned VCS SHA).

I'm just gonna categorize it as a bug since that's what users would expect.

Thanks for sharing my comment on X, happy to see you appreciated it! Keep up the amazing work :)


version solving failed

am building a Flutter web app and I wanted to add sessions, so I tried adding the flutter_session package using flutter pub add flutter_session but I get this error
Because shared_preferences_linux >=0.0.4-nullsafety <2.0.0 depends on shared_preferences_platform_interface ^2.0.0-nullsafety and shared_preferences_linux <=0.0.2 depends on path_provider ^1.6.11, shared_preferences_linux <0.0.2+1 or >=0.0.4-nullsafety <2.0.0-∞ requires shared_preferences_platform_interface ^2.0.0-nullsafety or path_provider ^1.6.11.
And because shared_preferences_linux >=0.0.2+1 <0.0.4-nullsafety depends on path_provider_linux ^0.0.1 and shared_preferences >=0.5.8 <2.0.0-nullsafety depends on shared_preferences_linux ^0.0.2, shared_preferences >=0.5.8 <2.0.0-nullsafety requires path_provider_linux ^0.0.1 or shared_preferences_platform_interface ^2.0.0-nullsafety or path_provider ^1.6.11.
And because shared_preferences >=0.5.4+8 <2.0.0-nullsafety depends on shared_preferences_platform_interface ^1.0.0 and path_provider >=2.0.0 depends on path_provider_linux ^2.0.0, path_provider >=2.0.0 is incompatible with shared_preferences >=0.5.8 <2.0.0-nullsafety.
And because google_fonts >=2.0.0 depends on path_provider ^2.0.0 and every version of flutter_session depends on shared_preferences ^0.5.8, google_fonts >=2.0.0 is incompatible with flutter_session.
So, because admin depends on both google_fonts ^2.0.0 and flutter_session any, version solving failed.

i tried removing google_fonts package but the same issue remained but this time with other packages.
this one after removing google_fonts
(1) So, because path_provider_platform_interface <2.0.0-nullsafety depends on plugin_platform_interface ^1.0.1, cloud_firestore >=2.2.2 is incompatible with path_provider_platform_interface <2.0.0-nullsafety.

    Because shared_preferences_linux >=0.0.2+1 <0.0.4-nullsafety depends on path_provider_linux ^0.0.1 and shared_preferences_linux <=0.0.2 depends on path_provider ^1.6.11, shared_preferences_linux <0.0.4-nullsafety requires path_provider_linux ^0.0.1 or path_provider ^1.6.11.
    And because path_provider_linux <0.2.0-nullsafety depends on path_provider_platform_interface ^1.0.1 and path_provider >=1.6.4 <2.0.0-nullsafety depends on path_provider_platform_interface ^1.0.1, shared_preferences_linux <0.0.4-nullsafety requires path_provider_platform_interface ^1.0.1.
(2) So, because cloud_firestore >=2.2.2 is incompatible with path_provider_platform_interface <2.0.0-nullsafety (1), cloud_firestore >=2.2.2 is incompatible with shared_preferences_linux <0.0.4-nullsafety.

    Because shared_preferences_linux >=0.0.4-nullsafety <2.0.0 depends on shared_preferences_platform_interface ^2.0.0-nullsafety and shared_preferences >=0.5.8 <2.0.0-nullsafety depends on shared_preferences_linux ^0.0.2, shared_preferences >=0.5.8 <2.0.0-nullsafety requires shared_preferences_platform_interface ^2.0.0-nullsafety or shared_preferences_linux >=0.0.2 <0.0.4-nullsafety.
    And because shared_preferences >=0.5.4+8 <2.0.0-nullsafety depends on shared_preferences_platform_interface ^1.0.0, shared_preferences >=0.5.8 <2.0.0-nullsafety requires shared_preferences_linux >=0.0.2 <0.0.4-nullsafety.
    And because cloud_firestore >=2.2.2 is incompatible with shared_preferences_linux <0.0.4-nullsafety (2), cloud_firestore >=2.2.2 is incompatible with shared_preferences >=0.5.8 <2.0.0-nullsafety.
    And because every version of flutter_session depends on shared_preferences ^0.5.8, cloud_firestore >=2.2.2 is incompatible with flutter_session.
    So, because admin depends on both cloud_firestore ^2.2.2 and flutter_session any, version solving failed.
pub finished with exit code 65

Same error here. Do you have a workaround?

Possible workaround -> https://github.com/jhourlad/flutter_session/issues/8#issuecomment-848742501
Besides that, this is a very poor solution (make a local file with the package content). Please, upgrade shared_preferences packages in order to have a stable version.

Possible workaround -> #8 (comment)
Besides that, this is a very poor solution (make a local file with the package content). Please, upgrade shared_preferences packages in order to have a stable version.

Nah itsn't. The Library only using 1 library (shared_preferences), You can improve it by you own


🚀 Feature: Migrate base & gallery pages

🔖 Feature description

Migrate Base & Gallery Pages

🎤 Why is this feature needed ?
React migration
✌ How do you aim to achieve this?
React files
🔄 Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
Yes I am willing to submit a PR!

@priyanshuverma-dev Can you confirm if these pages are not migrated

@kom-senapati All pages are migrated

Some Features are remaining only like speech recog. and speech systh.

@kom-senapati : okay, I updated the title

Ok you can do that

@kom-senapati : faced some issues related to flask setup. Today, I will push code changes

You can ask in discord about setup


[Bug]: Footnote Numbers in embeds not displayed properly when using the "clean-embeds" cssclass in reading-view

Bug Description
When embedding a note containing footnotes, these respective footnotes are prinited at the bottom end of the embed, before the delimiter bar.
In live-preview and source modes (where the cssclass does not take effect), the footnote numbers within an embedded note are displayed as proper numbers regardless of whether or not the cssclass is active or not, as it does not take effect in any mode besides reading-mode.
When using the reading mode with clean-embeds active, the numbers of the footnotes at the bottom of the embedded note's space gets reduced to some very small dots, cf. Image 2.
When not using the clean-embeds-css and switching to reading mode, the problem does not occur, cf. Image 1.
I would be very happy if this can be resolved, and I am happy to give more details if required.
Thank you,
Sincerely,
~Gw
Relevant Screenshot

Image 1: Display of the footnotes within an embedded note, reading mode, no cssclass active

Image 2: Display of the footnotes within an embedded note, reading mode, with clean-embeds-cssclass active
To Reproduce

Create file1 with several footnotes
embed file1 into file2
switch to reading mode within file2
add the clean-embeds-css and repeat step 3.
compare

Obsidian Version
0.15.8
Installer Version
0.14.15
Font Size
22
Which editor are you using?

[X] New Editor
[ ] Legacy Editor

In which mode(s) does the problem occur? (if applicable)

[X] Reading (Preview)
[ ] Source (Edit)
[ ] Live Preview

Which operating system?

[X] Windows
[ ] macOS
[ ] Linux
[ ] Android
[ ] iOS

Plugin-Specific Problems

[ ] I took note of the specific instructions regarding those plugins.

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Themes - Manage → Update).
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] If the bug occured after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)

Additionally, is it possible to have certain cssclasses (especially clean-embeds) to also render in edit mode? I usually fully leverage the advantages of live-preview, but the power of clean-embeds is the only thing that usually forces me to switch to reading mode instead to correctly render.
I am aware that right now according to the theme docs cssclasses only render in reading mode, but I'd like to know if it is possible and could be implemented as an option perhaps.

Hi! As you may have heard, the upcoming Obsidian update 0.16 has a massive amount of changes for theme development, necessitating a complete rewrite of Shimmering Focus. This means:

A lot of bugs and feature requests will be obsolete. with Obsidian 0.16 and the rewritten Shimmering Focus.
As the theme has over 15,000 lines of CSS, the rewriting will take a considerable amount of time. Recreating the core features alone will likely take me a while, so I simply will not have much time to implement many feature requests, since the recreation of the past core features has priority.

Basically, this is the reason why I am – for now – closing this issue. If your bug still exists / your feature request is still relevant in the upcoming version 3.0 of Shimmering Focus, please comment here and I will re-open it. 🙂

Alright that makes sense, no worries 🖖
Good luck translating the theme, I am seriously considering staying on 0.15 for the time being until most my plugins have been updated - I have a lot, and they are all rather important to my workflows.


Await on bot/user startConversation invocation

Pull Request Test Coverage Report for Build 2286

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.411%

Totals

Change from base Build 2279:
0.0%

Covered Lines:
4893

Relevant Lines:
8321

💛  - Coveralls


Image inference results into json ?

Dear all,
Thank you for reading this thread. I am using object detection inference on image through the demo, I am using a model pre-trained on COCO. I wonder how could I export the result into json ? I have seen the method "results2json" from the CocoDataset class but I can't use it (I don't have the COCO annotation file and I'm not interested getting it). Do you have a simple way to achieve it ?
Also, I could implement it my myself I guess, but if it is already implemented I would not mind using it.
Thank you all,
Camille
result = inference_detector(model, image)

I'll give you an example.
python ./tools/test.py configs/cascade_rcnn/cascade_rcnn_r50_fpn_1x_coco.py  ./work_dirs/epoch_2.pth --format-only --options "jsonfile_prefix=./results"

@Yukinoyuki1 , similar question. I used to use the method you are suggesting here; however, it no longer seems to work under 2.0. Can you take a look at https://github.com/open-mmlab/mmdetection/issues/2167 and comment if you have any ideas.

Well, the annotation file is NECESSARY.

Seems that we can make results2json() a classmethod so that it can be used without initializing a COCO dataset.

why the annotation is necessary? if I have one ,why do I do inference any way?

have you solve this problem?

Anything new?

lar question. I used to use the method you are suggesting here; however, it

Hi, it seems that --format-onlyor --options is not provided in tools/test.py. Could you help me out? Thx!

lar question. I used to use the method you are suggesting here; however, it

Hi, it seems that --format-onlyor --options is not provided in tools/test.py. Could you help me out? Thx!

Oh, I figure it out. Here's the solution.
Modify in the config file by replacingtest_evaluatorwith
test_evaluator = dict(
    type='CocoMetric',
    ann_file=data_root + 'annotations/image_info_test-dev2017.json',
    metric=['bbox'],
    format_only=True,  # 只将模型输出转换为 coco 的 JSON 格式并保存
    outfile_prefix='./work_dirs/coco_detection/test')  # 要保存的 JSON 文件的前缀


can't upload - various errors

I RMB on a file > Upload and get this error:
[PRO Deployer] My SFTP => Can't upload file: /d:/WebDev/files/thefile.txt. Details: Error: Permission denied
If I Upload to I get:
[PRO Deployer] Can't find files for uploading
I don't know where to go with either of these.  Where is the failure?
{
	"uploadOnSave": false,
	"autoDelete": true,
	"checkGitignore": false,
	"activeTargets": [
		"My SFTP"
	],
	"concurrency": 5,
	"ignore": [
		".git/**/*",
		".vscode/**/*"
	],
	"targets": [
		{
			"name": "My FTP",
			"type": "ftp",
			"host": "localhost",
			"port": 21,
			"user": "admin",
			"password": "123456",
			"dir": "/"
		},
		{
			"name": "My SFTP",
			"type": "sftp",
			"host": "cooldomain.org",
			"port": 22,
			"user": "myuser",
			"password": null,
			"dir": "/",
			"privateKey": "D:\\WebDev\\files\\private.ppk",
			"passphrase": "mypassphrase"
		}
	]
}

I RMB on a file > Upload and get this error:
[PRO Deployer] My SFTP => Can't upload file: /d:/WebDev/files/thefile.txt. Details: Error: Permission denied
Maybe the problem is on the wrong "dir" path or the user that you use doesn't have permission to write files.

If I Upload to I get:
[PRO Deployer] Can't find files for uploading
I can't reproduce this problem. Can you tell me are you use Workspace or just open one project (folder) in VS Code?

Permissions can't be the issue because in FileZilla I don't have any permission restrictions.
Is this syntax correct?  /d:/WebDev/files/thefile.txt
Does the config look valid?
I think it is just a project folder.
Is there a way to get detailed error information?

You can check the detailed log. Go to the Output tab and select PRO Deployer.


add .gitignore

I found this to be useful when doing some slight modifications

Yes, that's true. Thanks!


To add binary tree algorithms in the repository

I would like to add binary tree algorithms such as traversal algorithms(in order, pre-order, post order, level order, etc.) and several other algorithms which are must be known for coding interviews.
Location: DSA/DSA-CPP

Please see PR #95 and Let me know if you are adding some more and different programs by making proper folder. Then i will assign this to you.

The mentioned issue only implements limited operations in a BST(binary search tree) such as insertion, deletion, searching, printing in-order type, while I am proposing to implement binary tree and its important algorithms in C++.

@The-An0rack Good to go, follow proper folder order

Link PR here if made


chore: update prepackage hook in azure.yaml

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

this fixes building and deploying on a clean clone


Getting x-platform-example component inside keychain swift.

Hi,
I would like to know do we have a Calabash-iOS library dependency in Keychain-swift library. I am getting X-Platform-example component dependency warning during black duck scan. It seems the calabash library is under GNU license. Please confirm.

Library setup method: CocoaPods
Version of the library: Latest
Xcode version: 10.1
OS version. Example: iOS 11.

Hi @ianand861, sorry it's not quite clear what you are asking. Keychain-swift library does not use any other libraries from Github, if that was the question.

Hi Evgenyneu/Keychain-Swift,
Thanks a lot for your reply. Yes I just wanted to confirm if Keychain-Swift
was using any external libraries. This answers my query.
I will close the issue.
Thanks & Regards,
Anand Govindarajan.
On Mon, Jun 24, 2019 at 4:54 PM Evgenii Neumerzhitckii <
<EMAIL_ADDRESS>wrote:

Hi @ianand861 https://github.com/ianand861, sorry it's not quite clear
what you are asking. Keychain-swift library does not use any other
libraries from Github, if that was the question.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/evgenyneu/keychain-swift/issues/107?email_source=notifications&email_token=AB3AI3GGRUKA7KB4I6DTYELP4CVFRA5CNFSM4H24OBW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYMTN7A#issuecomment-504968956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3AI3GTMNM7AUDUT5ADZ43P4CVFRANCNFSM4H24OBWQ
.


Change KeyHole Markup Language to OGC KML

OGC rep mentioned that Keyhole Markup Language is no longer accurate, KML no longer expands but is "KML".  Also, should refer to it as "OGC KML" as that is more accurate (OGC is the keeper of the KML spec).

Updated in what will be posted for the RC7 version of CMAPI 1.3.0


feat: New flag to filter results by status in all supported validations

Closes #412

[x] It doesn't accept unknown statuses
[x] Filters in the command line output
[x] Filters the records before saving it to BigQuery
[x] It's an optional flag, so if not provided all statuses (success, fail) are shown

Tested for:

[x] Column
[x] Row
[x] Schema
[ ] YAML
[ ] Custom query
[ ] Ad hoc SQL

/gcbrun


autoUpgrade: added a 'dates' option, to allow you to switch when the …

…upgrade happens.
It uses the same default time as autoUpgrade did previously, so configurations that already use 'autoUpgrade.enable' should be fine.
(Note: most of the code here just comes from nix-gc).
I've only tested this on my machine, so if more tests need to be done, let me know.

This went in release-15.09 but never into master... was that intended?

My bad, I'll make another pull request.


[WIP] Allow partial signing of Threshold condition

This is a work in progress.
See Comments for more information.
TODO:

What to do when a PreimageSha256 is encountered?

Current coverage is 86.22% (diff: 81.48%)

Merging #25 into master will decrease coverage by 0.20%

@@             master        #25   diff @@
==========================================
  Files            17         17
  Lines           818        842    +24
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            707        726    +19
- Misses          111        116     +5
  Partials          0          0

Powered by Codecov. Last update a2c8390...36ea785

I'm afraid that having a sign method in a ThresholdCondition is out of spec for the library.

It won't appear in the JS, Java or other library. Hence yielding compatibility issues
It's only relevant for subconditions that are Ed25519, but there is also RSA, and maybe other schemes

If you want to make this abstraction, it should be outside of the CC library

Here is the reference implementation
I'd want to keep the basic API as close to that as possible.
extra types such as Timeout and InvertedThreshold can only be used internally in BDB, as well as added functionality like you are proposing. I would propose to use this repo as a clean and in-sync repo. If we want to do custom stuff (including Timeout and InvertedThreshold) then we might want to embed that in our own repo through inheritance or so.

I've worked on it further.
Currently I don't see a problem in "supporting" PreimageSha256. It simply has no notion of sign which means this method will sign it neither.
It gets trickier to know though when signing can be stopped as the threshold has been reached.
For now I'm using self.validate for that, but as PreimageSha256 always returns True (https://github.com/bigchaindb/cryptoconditions/issues/26) knowing when to stop is kind of tricky (or even impossible at this point?).

It gets trickier to know though when signing can be stopped as the threshold has been reached.

I wouldnt bother with that, kinda pre-optimization
just sign everything and validate later.


Need to reauthenticate every 1 or 2 days

Did you read the instructions?

[X] I have read the README, including the advanced debugging section.

The problem
Every 1 or 2 days i need to reauthenticate the Overkiz intergration. I already fully uninstalled the intergration and reinstalled it but also that does not work. Because of this we get a lot of automation problems here at home.
What version of this integration (ha-tahoma) has the issue?
2.10.2
What version of Home Assistant Core has the issue?
core-2021.12.7
Which gateway / hub do you use?
Somfy Tahoma
Device model
PositionableRollerShutter
Home Assistant log
No response
Additional information
No response

I have the same issue. I'm following. Has been happening for a few weeks now.
Need to authenticate every few days.
In my case, once I've done this I get a little pop-up with Aborted, but everything works again as it should for a few days, before the same issues pops up again.

Duplicate of https://github.com/iMicknl/ha-tahoma/issues/599. See the pinned issue on this repository.
Explanation: https://github.com/iMicknl/ha-tahoma/issues/599#issuecomment-995825550


Adding Imran to the Design System page

Adding in Imran and his role into the team page.

:heavy_check_mark: You can preview this change here:
Built without sensitive environment variables
:hammer: Explore the source changes: 237350fbb0c2fd9d74925ee2a15d80d937fd574e
:mag: Inspect the deploy logs: https://app.netlify.com/sites/govuk-design-system-preview/deploys/5ffdbb9abf162d0007b05e6d
:sunglasses: Browse the preview: https://deploy-preview-1449--govuk-design-system-preview.netlify.app

:heavy_check_mark: You can preview this change here:
Built without sensitive environment variables
:hammer: Explore the source changes: 237350fbb0c2fd9d74925ee2a15d80d937fd574e
:mag: Inspect the deploy logs: https://app.netlify.com/sites/govuk-design-system-preview/deploys/5ffdbb9abf162d0007b05e6d
:sunglasses: Browse the preview: https://deploy-preview-1449--govuk-design-system-preview.netlify.app


Add config file for header:target map

Currently the mapping between headers and targets is hardcoded which would makes it difficult to add new targets/headers e.g. during PRs adding new features.

https://github.com/maxb2/typer-config


ppsspp 1.0

1.0 version is released.

Use sdl2 replacing sdl.
FFmpeg patch removed (hrydgard/ppsspp#5772)
A fake test always returning true added for feeding test-bot.
Regex syntax changed according to brew audit --strict.

@BrewTestBot test this please


Does not work / very badly mangled output

The resulting html is badly mangled. Doxygen 1.8.11. header files looks very wrong.

I use this project with Jekyll page generator and github pages.  You will probably have to customize the header.html and footer.html files to fit your specific needs.  You can look at the source for this page and get an idea of what those files need to look like:  view-source:http://stratifylabs.co/StratifyLib/html/

True.
For better or for worse you rank high on Google for "doxygen theme" and as a public repo it would be more responsible to indicate this clearly in the readme.md (just so others don't spend time wondering why is this broken/incomplete).
Cheers
Sid

On May 18, 2016, at 1:26 PM, tyler-gilbert<EMAIL_ADDRESS>wrote:
I use this project with Jekyll page generator and github pages. You will probably have to customize the header.html and footer.html files to fit your specific needs. You can look at the source for this page and get an idea of what those files need to look like: view-source:http://stratifylabs.co/StratifyLib/html/
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Sid, thanks for the feedback.  I will add that.


ReactJS version- Block 1 - external review

to do

Tony, can we close this issue, as an external review was provided by Kirill?


Change Date in db to ISO date

This makes no sense. There are parts of the system that needs proper dates. The UI should be able to transform the dates.


calculate % changed

[ ] How many of the metrics have changed? (in %)
[ ] How much % has each of the metrics changed?

diff src/index.js test/index.js | diffstat
 unknown |  180 ++++++++++++++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 148 insertions(+), 32 deletions(-)

fixed in a77082d1460a07ae6d07c5ddddedeceef739ea9e


Server-Driven Full Pagination

Summary
Add example Full Pagination Server-Driven example using non mock service.

What is the change?

The current Server Driven Full pagination demo relies on the internal mock service, and sets many paging variables locally. For instance, it keeps a static size count for the array, whereas the array size should rescale based on filters, and therefore be set by the api end point.

Why should it go in Clarity?

It isn't currently clear how to pass pagination information (record set total records, current page, implementing the task w/ a subscribe model instead of declared promises, etc) for a more novice programmer, or someone not completely clear with how clarity data-grid works.

Does this change impact existing behaviors? If so how?
This does not change existing behavior, it is merely a demonstration page.

Use case
Providing users unfamiliar with clarity datagrid a clear example of how to consume a restapi which provides total records/current page/and data in a complex json return (Not everyone has the luxury of building their own endpoints either sadly...).
Examples
Workarounds

It is really difficult to create something like this that works for everyone. The examples in server driven datagrid show one way to handle the mocked server response. Every API and every application will be different.
This code in the documentation could be an application service that makes http requests and then updates the list of items for the datagrid as well as the pagination properties. Noting the then, this example could easily be using HttpClient to hit an end point and mapping the results to the relevent properties.
        this.inventory.filter(filters)
            .sort(<{by: string, reverse: boolean}>state.sort)
            .fetch(state.page.from, state.page.size)
            .then((result: FetchResult) => {
                this.users = result.users;
                this.total = result.length;
                this.loading = false;
            });

I'm not sure how to create a generic demo or even if that is different from whats already in the documentation. I'm closing this for now as it seems more like a how to question specific to one API. Those types of questions can be asked on StackOverflow where it can be demonstrated with a simple example what has been tried and what the backend/API looks like. Without seeing htat its hard to help.


Fix build with gpsd-3.21 and gpsd-3.23.1

Port fix for gpsd-3.21 from master branch and add another fix corresponding to https://github.com/swri-robotics/gps_umd/pull/40

Please check Gary E. Miller's reply in: https://gitlab.com/gpsd/gpsd/-/commit/7d7b889f5ca9ec0bdef5fcea3da0e320eb8ceb97#note_692804976


ESP-03

Dear Jandrassy,
Could I use this project with an ESP-03? It only has 512Kbytes, so the max SPIFF size is 128Kbytes, but I read that the ESP8266 filesystem uploader needs at least 512kB.
Thanks and kind regards from madrid

try to use it without SPIFFS. set SSID and password in sketch

Thanks, You put me on the way.
I have managed to get port <IP_ADDRESS> in the Arduino IDE.
I have cofigured the board as "Arduino Uno WiFi" (in fact it is a bare atmega328p with minicore bootloader).
I have connected:
RX from ESP-03 to TX on Atmeta328p
TX from ESP-03 to RX on Atmeta328p
GPIO0 from ESP-03 to Reset on Atmega 328p
But I get the following error:
https://i.paste.pics/6096385882ec9b4a1a4380bd86fac892.png

The minicore in the Atmega328p is configured with an external 8MHz clock

you have Optiboot with custom frequency and baud rate in the ATmega?
try to set DEFAULT_BAUD in esp8266-serial.c in dfu library

Nice it worked. Thank you very much Jandrassy.
https://i.paste.pics/fbf514580dbf7b6924a88a1cbf3e9ff6.png
The baud rate for minicore 328p 8MHz was 38400.
Nevertheless, I have found esp-03 boards with 1MB... so I will try again with SPIFFS.

btw I am Juraj. jandrassy is only a login created from first letter of the first name and the second name.


Should fail for duplicate Property in NewPropertyList

It should fail with duplicate Property
https://github.com/AssetMantle/modules/blob/0cf454502a4c84e93502743022ca6c57fcde04fc/schema/lists/base/propertyList_test.go#L32

this should not fail as such, it just won't add the duplicate property


[Feature]: Realize the interface of console: get global lock in the redis mode

Why you need it?
Is your feature request related to a problem? Please describe in details
1.实现redis模式下，控制台中获取全局锁的接口。
原型图：#4217
接口文档：#4195
2.注意：需要实现分页功能
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

I claim this issue. Please assign it to me


Removed stop_redirect from publish_to_cluster() params

Explain the changes

Removed the param stop_redirect from publish_to_cluster method

Issues:

Fixed: #6997

Signed-off-by: nik-redhat<EMAIL_ADDRESS>

Thanks @nik-redhat
@dannyzaken Can you take a look?


android debug image can not visible

use verison     "react-native-vector-icons": "^1.0.2",
when i run android ，use debug js the  image can not visible
without the plguin  it is ok
some code
<Image
style={{width: 40, height: 40}}
source={require('./image/add.png')}
/>

That sounds strange since react-native-vector-icons nowadays is mostly a Text composition. I can't understand how it can break the Image component. Can you post a full example with steps to reproduce?

@py110: Any updates? I can't for the world imagine how this module is causing this :-)


[Cost updated] Improve accuracy of cost calculations

Previously, cost calculations were performed using standard JavaScript numbers, which introduced floating-point issues and resulted in inaccurate results.
This PR introduces a Money and a Currency classes to better handle monetary values. The Money class is implemented using the Big.js library to ensure accuracy. All monetary operations are delegated to this class to avoid precision loss.

very cool! just curious, was there a reason to not use a library such as currency.js (also understandable to not use bc we don't want more dependencies 😬)

@yuvenus good point! I looked into using a library for handling monetary values and found two potentially useful options: DineroJS and currency.js.

currency.js was almost a perfect fit, but I couldn’t find a way to force it to round down; it always rounds up when getting the final amount, which might not be suitable for our needs (as I understand we always want to round down on final amount). If you think I missed something, feel free to check it out, maybe it's doable?

DineroJS seems more mature, but its v1 version operates on integers, whereas our code uses decimals for major units, which could cause issues (and is not very handy). The v2 version looks promising, but it's been in alpha for over three years, and the project appears somewhat inactive. The documentation even has a warning about the alpha status (You're browsing the documentation for v2.0.0-alpha.14. Things might break!). If we were open to using an alpha release, DineroJS v2 might be a good option due to its sophistication and maturity. (I checked the source code and that was my impression)

After researching, many recommend using libraries like Big.js or Decimal.js for money handling. Implementing our own Money type based on Big.js could be beneficial, as it allows us to design the API to suit our needs. I’ve written some tests, and it seems to work well so far. This approach aligns with practices in other languages, like Java’s Moneta, which is based on BigDecimal (though some prefer using longs).
What are your thoughts? Should we consider DineroJS v2 alpha, or stick to implementing our own Money based on Big.js?
Additionally, it might be worth considering a reconciliation process to periodically check for discrepancies over longer periods, such as daily or weekly, what do you think?

regarding the libraries, makes sense! better safe than sorry and implement exactly as we need. it blows my mind a little bit though that no one's really solved all the problems needed to handle currency in javascript. (perhaps it's time to release citrineos-currency 😆)
regarding the reconciliation process, what discrepancies do you anticipate? is it things like the decimal precision being wrong, currencies changing, currency formats changing, etc...? i agree in general if we're maintaining essentially our own currency "library", there should be ways to make sure our currency processing isn't going out of date - but i'm not sure what this would look like in the long term 🤔


Feature Request: Random User-Agent

Could it be possible to set an option/flag for reqwest to out-of-the-box use/cycle through random user-agents? If needed, the function could take an array of possible user-agents.

Thanks for the suggestion! Do you have examples of other libraries doing something similar? At first thought, it feels like out of scope for reqwest, and is something fairly straight forward for the user to do themselves...


v8 testnet inifinite login loop due to gas estimation fail

Upon creation of a new v8 testnode, when creating a new identity, my node fails to decode estimate of gas so stops the node.
I am using RPC endpoint: https://sepolia.base.org/
Here is a screenshot of the issue:

Here is the code:
[2024-10-04 18:45:15] INFO:  Creating profile on network: base:84532
[2024-10-04 18:45:15] DEBUG:  getIdentityId(operational=0x1217D6C0f71F0CA8c267017ac6632f0E05E4B761) call has been successfully executed; Result: 0; RPC: https://sepolia.base.org.
[2024-10-04 18:45:15] WARN:  Unable to decode estimate gas error: Error: Gas estimation for createProfile has failed, reason: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:15] WARN:  Unable to create profile. Will retry in 12s. Retries left: 2 on blockchain base:84532. Error: Error: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:28] WARN:  Unable to decode estimate gas error: Error: Gas estimation for createProfile has failed, reason: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:28] WARN:  Unable to create profile. Will retry in 12s. Retries left: 1 on blockchain base:84532. Error: Error: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:40] WARN:  Unable to decode estimate gas error: Error: Gas estimation for createProfile has failed, reason: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:40] WARN:  Unable to create base:84532 blockchain profile. Removing implementation. Error: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0)
[2024-10-04 18:45:40] ERROR:  Unable to create blockchain profiles. OT-node shutting down...
[2024-10-04 18:45:40] INFO:  Stopping node...

Update, it worked after about 18 hours.


Implement conversion between FieldElement & RistrettoScalar

Another important step on the implementation is to create the conversion FieldElement <-> RistrettoScalar.
RistrettoScalar struct was implemented by Dalek devs on Curve25519. So we can maybe review it and pick it or implement it by ourselves.

@Bounce23 #7 only needs this issue to be solved in order to successfully close it. So maybe we can prio this and close the FieldElement implementation.
Which are your thoughts?

I agree with you on the choice to close the FieldElement implementation. However rom reading the paper on Decaf, to determine the path for using the Ristretto Scalar Field, to continue with Montgomery reduction issue, we first must outline the exact functions which will use this modulo. Then build the code, minus the calculated modular reduction and denote them as WIP, this is until we calculate this reduced number. This number can be calculated from the 1985 Peter Montgomery paper we have on file. However, the use case in the paper given is not for a change in group order. This paper will therefore need review and potential adjustment to our implementation.

With 20b492d , 3c9829 and 9aaa417 Ristretto255Scalar is implemented correctly and tested.
@Bounce23 can you review the last 3 commits and give me the OK? Then I'll be able to close this issue and proceed to merge #7

Closed since the review of the #7 from @Bounce23 was positive!


Parallel demo

This PR approaches #31  by including a demo/parallel_script.py script (and associated CLI command) that allows you to get updates from parallel tqdm_publisher instances through an HTTP relay server.
@CodyCBakerPhD Let me know if this aligns with what we can bring to this package's dependents. I'll integrate the script into the main demo if that's the case.

I'm only running the parallel demo in Python at the moment. But I can adapt the main demo to run both at the same time if that is desirable.

I'd hold off for a little bit on this while I think of a better way to design the tqdm injection, now that I understand the scoping better

@garrettmflynn Replaced by #51?

Yep! Feel free to close


Need to sort genome group list on alphabetical order

Can the list of genome groups be alphabetized?

I also prefer alphabetical order in genome groups, but maybe we can expand this UI component in which user can choose the order.

You can already click on folder icon to get group listing and sort them alphabetically or by date.
For now, I think we just need to decide what is more useful in the drop down, alphabetical or most recent?
My preference is alphabetical.
-Maulik

On Oct 13, 2016, at 10:46 AM, hyoo<EMAIL_ADDRESS>wrote:
I also prefer alphabetical order in genome groups, but maybe we can expand this UI component in which user can choose the order.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/1074#issuecomment-253534988, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLd78GhnBuSGb28aTCnYRZpmAlZwTDyks5qzkRRgaJpZM4KV90q.

I like the current solution. Display top N most recent groups in the drop down, assuming that user are likely to select most recent groups. You have the folder selection icon next to it to see the complete listing of the group and sort them alphabetically or by date.


cannot load fine-tuned model

I train the model from a scratch and name it as modelA. Then use the new training data to train this trained model (modelA). The training process looks good. Then when I load the model using tf.keras.models.load_model, I ran into this issue:
TypeError: Layer input_spec must be an instance of InputSpec. Got: <keras.initializers.initializers_v2.GlorotUniform object at 0x7f6c285f0130>
Does anyone can help me out with this issue? Where is wrong with this fine-tuned model? I remembered that I didn't use GlorotUniform when I built the model.
Thanks!

Hi @lwind18 ,
For me it seems the issue is with version mismatch. Could you please provide more details like on which Keras version earlier model was trained and which version you are trying to reload? Right now Keras3 designed to support multiple backends there might be design changes.

The model trained with keras 2.6 an also tensorflow 2.6. Then I tried load this model under keras 2.6 and tensorflow 2.6, and  I tried 2.8, 2.9, 2.10, 2.11 and they ended with the same error.
So you suggestion is to update keras and tensorflow to 2.13 or later, and train the model again. Then it shouldn't have this issue?

The model trained with keras 2.6 an also tensorflow 2.6. Then I tried load this model under keras 2.6 and tensorflow 2.6, and I tried 2.8, 2.9, 2.10, 2.11 and they ended with the same error.

If you have trained and loading the model in same version then it should load without any error. If there are versions mismatches wrt training and reloading the model then such problem may arise.
Please double check your environment details while reloading the model its pointing to correct version of TF/Keras that the model trained. Please submit a minimal code snippet for reproduction.

The model trained with keras 2.6 an also tensorflow 2.6. Then I tried load this model under keras 2.6 and tensorflow 2.6, and I tried 2.8, 2.9, 2.10, 2.11 and they ended with the same error.

If you have trained and loading the model in same version then it should load without any error. If there are versions mismatches wrt training and reloading the model then such problem may arise.
Please double check your environment details while reloading the model its pointing to correct version of TF/Keras that the model trained. Please submit a minimal code snippet for reproduction.

I used the newer tensorflow version (higher than v2.11) to train the model and load it. It gave me the same error.
Here is the snippet of code:
model_path = './trained_model.model'
traind_model = tf.keras.models.load_model(model_path, compile= False)
loss = myloss.multiclass_weighted_cross_entropy(num_classes, class_weights=weights,is_logits=True)
metrics = [tf.keras.metrics.SparseCategoricalAccuracy()]
learning_rate = 0.0001
optimizer=tf.keras.optimizers.RMSprop(learning_rate=learning_rate, rho=momentum    )
model.compile(optimizer=optimizer, loss=loss, metrics=['accuracy'])
model_history = traind_model.fit(train_dataset, validation_data=validation_dataset, epochs=EPOCHS, verbose=2)
model.save(model_name)
ERROR message:
Traceback (most recent call last):
File "", line 1, in
File "./python/3.11/envs/rasteriobak/lib/python3.11/site-packages/keras/src/saving/saving_api.py", line 262, in load_model
return legacy_sm_saving_lib.load_model(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "./python/3.11/envs/rasteriobak/lib/python3.11/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
raise e.with_traceback(filtered_tb) from None
File "./python/3.11/envs/rasteriobak/lib/python3.11/site-packages/keras/src/engine/base_layer.py", line 1295, in input_spec
raise TypeError(
TypeError: Layer input_spec must be an instance of InputSpec. Got: <keras.src.initializers.initializers.GlorotUniform object at 0x1553943ab610>
Thanks.

Hi @lwind18, Thanks for reporting this. You can try upgrading to keras 3 using !pip install -Uq keras  and try saving the model with.keras extention. Please provide a sample model to reproduce. Thanks.

model_path = './trained_model.model'
traind_model = tf.keras.models.load_model(model_path, compile= False)
loss = myloss.multiclass_weighted_cross_entropy(num_classes, class_weights=weights,is_logits=True)
metrics = [tf.keras.metrics.SparseCategoricalAccuracy()]
learning_rate = 0.0001
optimizer=tf.keras.optimizers.RMSprop(learning_rate=learning_rate, rho=momentum )
model.compile(optimizer=optimizer, loss=loss, metrics=['accuracy'])
model_history = traind_model.fit(train_dataset, validation_data=validation_dataset, epochs=EPOCHS, verbose=2)
model.save(model_name)


Make it run on other people's machines

[x] Push built extension to S3.
[ ] Document

Waiting for the signed extension.


refactor: Use attrs NG import

And drop attr.ib in favor of attrs.field.

Coverage remained the same at 97.238% when pulling b0143c926cf59e0223fd83a2c9b5bab54f3d37bb on refactor/attrs into ec60f7134b3ba743af98b07c2f5f62742434bed7 on main.


Update rpbasicdesign to 1.1.1

Update rpbasicdesign to 1.1.1:

Update hash probably due to a new version of lxml library (test_Construct.py)
Add test file (test_get_sbol_new.txt) for debugging (test_get_sbol function in test_Construct.py)
Add cobra import to the recipe

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Thumbnails for stream inside of the splitheader tooltip shows a different stream

Describe the bug

Thumbnails for stream inside of the splitheader tooltip shows a different stream then the one you are watching
To reproduce

open a stream hover over the splitheader tooltip then go to another stream and hover over the splitheader tooltip
Screenshots

Chatterino version

Chatterino 2.2.2 (commit 07fc0c3ad)
Operating system

windows 10
Additional information

This might be fixed already in the nightly build with https://github.com/Chatterino/chatterino2/pull/2080


Documentation: Move important_settings to wiki?

Maybe it would be nice to move the important_settings files to the Wiki or somewhere else to clean up the main folder

Maybe we could move the examples of important_settings to the example folder ?


Document the usage of containerd-shimv2-kata

The shimv2 (kata-containers/runtime#572 and related fixes) has landed in the master branch. We should document it for the coming release asap.

Include the following parts:

[ ] Manual Installation Section of the Install Guide, should mention configuration the CRI part
[ ] Run Kata Containers with Kubernetes in Developer Guide
[ ] Configure containerd to Use Kata Containers in the kubernetes Howto
[ ] Update the Architecture doc