Custom Telegram messages

Is it possible to send custom telegram messages from Node.js.
I've been trying to call session.send and session.sendMessage with various parameters but no joy. The only type of message I can successfully send is text.
Here is an example of a call I'm making.
session.send( {
    "type": "Message",
    "channelData":
    {
        "method": "sendSticker",
        "parameters":
        {
            "sticker":
            {
                "url": "https://upload.wikimedia.org/wikipedia/commons/3/33/LittleCarron.gif",
                "mediaType": "image/gif"
            }
        }
    }
});

Let me have Tom weigh in. The channelData field should work.

You still need to set the normal from, to properties like a normal message and then instead of setting text you pass the channel data
Sent from my tumbs

From<EMAIL_ADDRESS>Sent: 5/13/2016 4:35 PM
To<EMAIL_ADDRESS>Subject: [Microsoft/BotBuilder] Custom Telegram messages (#283)
Is it possible to send custom telegram messages from Node.js.
I've been trying to call session.send and session.sendMessage with various parameters but no joy. The only type of message I can successfully send is text.
Here is an example of a call I'm making.
session.send( {
"type": "Message",
"channelData":
{
"method": "sendSticker",
"parameters":
{
"sticker":
{
"url": "https://upload.wikimedia.org/wikipedia/commons/3/33/LittleCarron.gif",
"mediaType": "image/gif"
}
}
}
});
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/BotBuilder/issues/283

Tom... I add the From & To under the covers so that should be working.

So Tom I was just looking at my code and I'm wrong. For the inline reply I'm going to just send what was passed in. For out of band replies then I'm adding all of the other fields on to the envelope.
                        if (res) {
                            this.emit('reply', reply);
                            res.send(200, reply);
                            res = null;
                        } else if (ses.message.conversationId) {
                            // Post an additional reply
                            reply.from = ses.message.to;
                            reply.to = ses.message.replyTo ? ses.message.replyTo : ses.message.from;
                            reply.replyToMessageId = ses.message.id;
                            reply.conversationId = ses.message.conversationId;
                            reply.channelConversationId = ses.message.channelConversationId;
                            reply.channelMessageId = ses.message.channelMessageId;
                            reply.participants = ses.message.participants;
                            reply.totalParticipants = ses.message.totalParticipants;
                            this.emit('reply', reply);
                            post(this.options, endpoint, '/bot/v1.0/messages', reply, (err) => {
                                if (err) {
                                    this.emit('error', err);
                                }
                            });
                        } else {
                            // Start a new conversation
                            reply.from = ses.message.from;
                            reply.to = ses.message.to;
                            this.emit('send', reply);
                            post(this.options, endpoint, '/bot/v1.0/messages', reply, (err) => {
                                if (err) {
                                    this.emit('error', err);
                                }
                            });
                        }
                    });

Thanks for the prompt feedback guys. So I've made a couple of changes to setup the conversation and recipient coordinates in my reply however I'm still not getting a message back! The following is my the call I'm making now. I've tried to use the sendMessage method also with a text parameter but still no joy.
session.send( {
    type: "Message",
    to: session.message.from,
    from: session.message.to,
    replyToMessageId: session.message.id,
    conversationId: session.message.conversationId,
    channelConversationId: session.message.channelConversationId,
    channelMessageId: session.message.channelMessageId,
    participants: session.message.participants,
    totalParticipants: session.message.totalParticipants,
    channelData:
    {
        "method": "sendSticker",
        "parameters":
        {
            "sticker":
            {
                "url": "https://upload.wikimedia.org/wikipedia/commons/3/33/LittleCarron.gif",
                "mediaType": "image/gif"
            }
        }
    }
});

@byrner75 Looks like we had a bug in our handling of channelData for Telegram when the value was a JSON object. I've made it fix and it will be available in the next push to production. We try to do update production at least once a week. If you need a workaround in the meantime, you can send the value as a stringified JSON object.

Thanks for the reply, your suggested workaround works a charm.

@byrner75 The fix is now live. You should be able to send channelData as a JSON object. Serialized JSON is still supported.


[Task] Add Seeder for PostgreSQL

Task Description
The current idea is to run the postgres-init script (or another one that is very similar more than likely) and copy that along the bot file. Then we only run that script when the docker container is first started up. This essentially "seeds" the database and creates the table automatically

Done since da3a8649bc4198bbe32c105e782851d9a25a7ee2


Hotfix for HA 2022.11 compatibility

Pin databases to forked version due to incompatibility with latest sqlalchemy

database-upstream has now reverted to sqlalchemy v1.4.41 to avoid this issue. Just as a reminder so we are not mixing up the two existing 0.6.2 versions of databases 😉

databases-upstream has now reverted to sqlalchemy v1.4.41 to avoid this issue. Just as a reminder so we are not mixing up the two existing 0.6.2 versions of databases 😉


reAuthenticate on auth error listing nodes

We missed this case in c3cd70e62cf47a99216d7bfec123f7f946af0ac9

/test e2e

/lgtm

Connecting to cdn.dl.k8s.io (cdn.dl.k8s.io)|<IP_ADDRESS>|:443... connected.
ERROR: cannot verify cdn.dl.k8s.io's certificate, issued by '/C=US/O=Let\'s Encrypt/CN=R3':
  Issued certificate has expired.,

Doesn't look expired when I try locally....

/test e2e


support more game slots

We only support 4 games slots for now. Given how small programs are, we could support up to 8.

easy to change now in set {2,4,6,8}


Pin most requirements

Pin plugin requirements in imjoy/runners/subprocess.py.
Pin requirements for dev and tests in requirements.txt.
Pin engine requirements in setup.py and imjoy/__main__.py.

@MartinHjelmare I just did some commits because I think it's better to merge this PR soon, this will impact existing users with already installed virtual envs.

A side remark:  I think this is essentially good because this will accelerate the installation if conda can reuse packages across virtual env.
Conda will reuse conda libraries across virtual envs by hard/soft link files, but it's not clear to me whether it will do the same for pip packages.

What environment are you running? There shouldn't be other pyyaml installed if you run a project specific environment, I think.

It's my base env which I used to test a lot of stuff, so I think you are right, if I start install it in a new virtual env, it should just work.
However, this still shed some bad light on pin versions, it means others may have similar issues when they install imjoy in their Python environment without creating a new env.
Instead of asking the user to make new new env for ImJoy engine, I think a better choice would be only pin version when necessary. How about set a minimal version number?

We already recommend users to install in a separate conda env, right? Advanced users that don't follow our recommended approach will know how to handle this.

No we don't, I think we should not bring up how to create a virtual env.
Currently, we just mentioned install miniconda the run pip install ImJoy.
Open a terminal and just type 'imjoy' without doing conda activate just
make it so much easier to use. If one don't use conda for a while, they
will forget about the conda environment name for ImJoy and they will need
to run even "conda env list" to find out which env, or they forgot how to
use conda etc.
Having a high chance to just run the "imjoy" command directly will
definitely increases the usibility a lot. Keep in mind that the target
audience of ImJoy is non-programmers.
On Mon 3 Jun 2019 at 21:11, Martin Hjelmare<EMAIL_ADDRESS>wrote:

We already recommend users to install in a separate conda env, right?
Advanced users that don't follow our recommended approach will know how to
handle this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/oeway/ImJoy-Engine/pull/70?email_source=notifications&email_token=AADU3S4UPHXM34A6YFE5QX3PYVUHPA5CNFSM4HSHOPG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2MVII#issuecomment-498387617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADU3SZT73FCPC35KDXVQRTPYVUHPANCNFSM4HSHOPGQ
.

Even if we don't pin requirements, running multiple apps in a single python environment is problem prone. I think we should recommend using a virtual environment, and we can set up this automatically for the desktop app, if we don't do it already.

The desktop app has an independent miniconda environment in ~/ImJoyApp folder, not used by any other purpose so it's fine.
Giving the fact that python-socketio is mostly used by web apps, and it's not that popular than libraries such as numpy and pyyaml, I think we should be pretty safe by only pin the version of python-socketio (perhaps also aiohttp).


fix: to safe when got unexpected typeptr

~This patch is a workaround of #350~
EDIT:
This was not a workaround, it is a solution.
fix #350

Codecov Report

Merging #351 (48f6412) into master (fdf5700) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   79.87%   79.85%   -0.03%
==========================================
  Files          52       52
  Lines       17469    17469
==========================================
- Hits        13953    13949       -4
- Misses       2949     2952       +3
- Partials      567      568       +1

LGTM !


This is how to get it working in Nuxt (or get rid of "document is not defined")

The issue is that document is not available when server-side rendering.
Create a plugin file with this name and content:
plugins/client-only.pinch-zoom.js:
import Vue from 'vue'

export default () => {
	const PinchZoom = require('vue-pinch-zoom')
	Vue.component('pinch-zoom', PinchZoom);
}

Then add this to your plugins in nuxt.config.js:
plugins: [{ src: 'plugins/client-only.pinch-zoom.js', mode: 'client'  }],

This will then globally register your component on the client-side only, and you will not get the error of " document is not defined" on build.
Hopefully this helps someone

thanks, this was helpful. However now Im getting
TypeError: Cannot read property 'tagName' of null     at new IvyPinch (PinchZoom.umd.js:3962)     at VueComponent.PinchZoom.init (PinchZoom.umd.js:4527)     at VueComponent.PinchZoom.mounted (PinchZoom.umd.js:4477)
and TypeError: Cannot read property 'destroy' of undefined

Same here

I am also getting the error:
TypeError: Cannot read property 'tagName' of null at new IvyPinch (PinchZoom.umd.js:3962) at VueComponent.PinchZoom.init (PinchZoom.umd.js:4527) at VueComponent.PinchZoom.mounted (PinchZoom.umd.js:4477)

I am only doing a client build (no SSR)


Validation NSE's

Get validation NSE's for the LSTM model

Validation NSE for Antlers station: 0.9590679872032697
Validation NSE for Pauls Valley station: 0.8758695054560748


[Feature Request] Old navigation bar

Please consider giving the user an option to disable the floating navigation bar. It looks good though, but is very unpractical for me. A toggle in the settings would be enough. This app is really great, and the best modern opensource gallery app i could find. I would love to recieve further updates, but for now, i have to stick with the latest version before the floating navigation bar. Thanks for your time.

I will add an option to go back to the old navigation style.
Thanks for your feature request!


Implement vpc_endpoint_ids configuration

This is a 🙋♂ feature or enhancement.

[x] I've added tests (if it's a bug, feature or enhancement)
[x] I've adjusted the documentation (if it's a feature or enhancement)
[x] The test suite passes (run bundle exec rspec to verify this)

Summary
We needed a private gateway with a vpc endpoint and wanted the CloudFormation stack to handle all of the configuration on its gateway
This PR implements a config.api.vpc_endpoint_ids configuration. See https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigateway-restapi-endpointconfiguration.html

Thanks for the contribution!


ProfileFragment

Cannot find annotation method 'value()' in type 'DoNotMock': class file for com.google.errorprone.annotations.DoNotMock not found
UDACITY/GrowWithGoogleTeamProject/app/src/main/java/com/madonasyombua/growwithgoogleteamproject/ui/fragment/ProfileFragment.java uses or overrides a deprecated API.
@CleverChuk  please this does not cause the app to close but we need to figure out whats up.

Try cleaning the project and run again. If that does't work, you can wait to run the update

@CleverChuk  Okay, so any briefs on this uses or overrides a deprecated API. Lol.

@Madonahs I don't see that warning on my side. Anyone else getting that warning?

@CleverChuk  Hey, I think it happens before sync once done it is fine 👍 So closing the issue.


Supports Heroku website autodeploy

Is your feature request related to a problem? Please describe.
Before that, the chart will only be accessible via localhost. Since there is a Heroku free tier, I will make sure that all of the created charts are being deployed to Heroku
Describe the solution you'd like

Scripts that Heroku understands
Merge multiple line chart into one

Describe alternatives you've considered
none

Currently I have changed from "Test on Production" to "Test on Staging (develop branch)" and "Deploy on Production".
This is done automatically via GitHub-Heroku integrations


Revert "Merge pull request #192 from zalando-nakadi/correto"

This reverts commit 8ef6ba1f8e44a0141e6e95c6d9d09bb6cb5ca5b4, reversing
changes made to 6560ee1026d3e81b9403313a53be9b3d1d37e0a9.

:+1:

👍


Include deployment CPU and RAM in total quota

If we want to allow larger deployments, we could do this by simply counting their CPU and RAM into the total user quota. This could enable more use cases of deployments without the hassle and overhead of a VM

As a follow up, this means the user could specify the cpu and ram limits of their deployment


"Admin Local" user showing as a "Program Member" on all Program pages

"Admin Local" is showing as member on all program pages.
Since this is an system/internal account, and not really a user/member it seems like we should suppress showing this account on program pages and elsewhere.

chris hid - beauty!


CRI: add support for CDI device injection

This PR adds support for injecting CDI devices into containers.
CDI injection is already supported in Podman since v 3.20 and was recently implemented in CRI-O
This is also an essential part of work to implement Dynamic Resource Allocation in Kubernetes.

/ok-to-test

Is CDI Linux-only? Seems some of CDI dependencies is not build-able on Windows.

Is CDI Linux-only? Seems some of CDI dependencies are not build-able on Windows.

yes, it's Linux-only currently. I'll update the PR to fix build breaks on non-Linux platforms.

@mikebrow can you re-trigger Windows integration test? I'm not sure its failure caused by the PR changes as they only change Linux code.

@mikebrow can you re-trigger Windows integration test? I'm not sure its failure caused by the PR changes as they only change Linux code.

that's a known issue you'll need to rebase

@mxpv thank you for the review! rebased. it's green now.

Thanks. Need one more LGTM to get this in.

Thanks. Need one more LGTM to get this in.

@mikebrow would you mind reviewing & lgtm-ing it?

@mxpv @mikebrow thank you for approving this. Can you merge or suggest whom to ask to merge it?

@mxpv @mikebrow Should I submit this PR for 1.6 branch if I want it to be released sooner than in 1.7?

backport is for bugfix and security fix. This change is new feature and big one. I don't think it should be backported.

@mikebrow, @fuweid
Should this be added to the 1.7 milestone so it doesn't get lost for release notes purposes?


Update devices.json

Please merge after CoolStar updates her list to include MARASOV, otherwise I can revert that commit for now.

Would you like me to ask CoolStar directly whether she'll add MARASOV to her list?

i dont see why we need to wait for coolstar

Updated my website to also include Marasov. Do ping me next time :)


Fix PortBindingLevel join condition for multiple portbindings

Could use an additional test, but just to get it on the way.

Now it has an additional test!


Transformer measurement and control models

Resolves #89, but is build upon and blocked by #91

#91 should be merged first


In case of authentication with Private Key, the default username is not set to git.

(While submitting an issue briefly describe the problem you are facing or a new feature you would want to see added)
What happens?
When I don't specify pk_username in my config.json file, I would expect it to be set to git by default as per the documentation. What happens is that when I run the git2consul binary , I got the following error:
ERROR[0001] (runner): Cannot load repositories from configuration: Error loading : ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
...
What were you expecting to happen?
I would expect the username to be set to git by default.
...
Steps to reproduce:

...
...

Any errors, stacktrace, logs?
...
Environment:

Runtime version(Java, Go, Python, etc):
Desktop OS/version:

Additional comments:
...

Right now, there is a check being done for repo.Credentials.Username, just needs to be changed to repo.Credentials.PrivateKey.Username in repository/auth.go. Can I pick this up?

@rampreeth thanks for open this issue! Yes, you can submit a fix for this issue that would be great.

@seanmalloy Thanks!

@seanmalloy can you please take a look at this

@rampreeth I've added this to the v0.1.2 milestone which will be the next release. Hopefully by the end of February.

Closed by #14


Change setup.sh to use realpath to support Fedora

Done in https://github.com/TommyTran732/NGINX-Configs/commit/eb39ad2f3902f1586fe540211e33f4e64238d949


Support persisting anonymous sessions between page reloads.

Apologies if this isn't the right place for this, or if there's already a solution to my problem which I've somehow missed.
I'm trying to find a way to keep an anonymous user session alive after a user refreshes the page, e.g. so an anonymous user could load the page, add an item to a cart, reload/navigate away, then return and check out their cart.
I'm not seeing any mention of this topic in the docs, or any obvious support for it in the codebase. I did note that the anonymous auth flow accepts an anonymous_id parameter, so I tried capturing the id generated during the oauth flow, storing it in localStorage, and passing it in after a page reload, but this results in an error because the id is 'already in use'. I also tried passing in a custom tokenCache object which would read & write localStorage, but the SDK code never actually makes calls to my tokenCache (seems there's an old issue about this here: https://github.com/commercetools/commercetools-sdk-typescript/issues/140 which nobody ever responded to so it was auto-closed).
I imagine there may be a way for me to accomplish this by capturing the access token and passing it in to the ExistingToken auth flow, I'll likely try that next, though even if it works I'm not sure I'd consider it a production-ready solution, I'm having to jump through hoops to read the access token, and having to conditionally use a different auth flow is a bit clunky.
Normally when integrating an API/SDK like this, I would expect to implement this sort of functionality myself. So I'm really not opposed to having to do some of this work myself, but the SDK is already trying to automate a lot of the token handling, so it seems like a feature that should already be built in, and it doesn't expose the token value anywhere, so I had to pass in a modified copy of fetch to capture the token data.

Hi @YGKtech
Thanks for bringing this up. For anonymous authentication flow, the anonymous ID is used to get an anonymous token which is then cached in the tokenCache using a tokenCacheKey here, all subsequent requests should now use the cached token instead provided it's still within the same request-response session. To a good extent SDK automates this process of token handling.
Another thing I would suggest is to capture and save the anonymous token gotten after the first request and then use it in the headers of the subsequent request, note that here you are now managing your own tokenCache.
For the issue about the SDK not making calls to the auth token will be investigated and see if we can reproduce it on our end and why that is the case.
Thanks.

Thanks for the response @ajimae
To clarify - the token created by the anonymous authentication flow is being used on subsequent requests as expected.  The problem I'm having is that I want to make the SDK reuse that token even if the user refreshes the page. Right now, if a user refreshes the page, they are given a new token associated with a new anonymous ID. This means that if a user adds an item to their cart, then refreshes the page, they will not see that item in their cart because the new anonymous ID does not have access to the cart created with the previous one. By storing the token in the browser's localStorage and reusing that stored token as long as it remains valid, users could reload the page as many times as they want and they would still have the same anonymous ID.
I have attempted to implement this behavior myself by passing in a custom tokenCache implementation which keeps the token in localStorage until it expires. But, if you look at the code for the anonymous session flow here: https://github.com/commercetools/commercetools-sdk-typescript/blob/70db08858547cfddc7601269a9a488cb85e5699d/packages/sdk-client/src/sdk-middleware-auth/anonymous-session-flow.ts#L16 you will see that the function creates its own instance of tokenCache rather than first checking to see if one was provided in the options object. The tokenCache it creates works properly, so the token is reused on subsequent requests, but I am unable to implement the behavior I want because it always uses the default tokenCache instead of the custom one I am providing.
Compare this to the client credentials flow: https://github.com/commercetools/commercetools-sdk-typescript/blob/70db08858547cfddc7601269a9a488cb85e5699d/packages/sdk-client/src/sdk-middleware-auth/client-credentials-flow.ts#L18 and you'll see that it only creates a new tokenCache instance if options.tokenCache is undefined.
Making the anonymous flow check this parameter in the same way should enable me to implement the functionality I want, without changing the default behavior of the library.
Thanks.

Hi @YGKtech
Please look at this PR I believe this will fix the issue.
Thanks

@ajimae : Thanks, I installed the updated version and was able to get my custom tokenStore code working as I wanted.
Here's the code I'm using to make it so anonymous session tokens are reused after the page reloads, in case anyone else views this issue looking for a way to do the same, or if the team wants to try adding similar functionality to the SDK as a configurable option for the anonymous session flow.
const ANONYMOUS_TOKEN_STORAGE_KEY = 'ct-anonymous-token';

export function makePersistentTokenCache(): TokenCache {
  let current: TokenStore | {} = {};

  const storedValue = localStorage.getItem(ANONYMOUS_TOKEN_STORAGE_KEY);
  if (storedValue) {
    const parsed = JSON.parse(storedValue) as TokenStore;
    if ('expirationTime' in parsed && parsed.expirationTime >= Date.now()) {
      current = parsed;
    } else {
      localStorage.removeItem(ANONYMOUS_TOKEN_STORAGE_KEY);
      current = {};
    }
  }

  return {
    get: (tokenCacheOptions?: TokenCacheOptions) => {
      if (current) {
        return current as TokenStore;
      }
      const storedValue = localStorage.getItem(ANONYMOUS_TOKEN_STORAGE_KEY);
      if (storedValue) {
        const parsed = JSON.parse(storedValue) as TokenStore;
        if ('expirationTime' in parsed && parsed.expirationTime >= Date.now()) {
          current = parsed;
        } else {
          localStorage.removeItem(ANONYMOUS_TOKEN_STORAGE_KEY);
          current = {};
        }
        return current as TokenStore;
      }
      return {} as TokenStore;
    },
    set: (newValue: TokenStore, tokenCacheOptions?: TokenCacheOptions) => {
      current = newValue;
      localStorage.setItem(ANONYMOUS_TOKEN_STORAGE_KEY, JSON.stringify(current));
      return current;
    },
  }
}

const anonymousSessionAuthMiddlewareOptions = {
  host: 'https://auth.us-central1.gcp.commercetools.com',
  projectKey: '<projectKey goes here>',
  credentials: {
    clientId: '<clientId goes here>',
    clientSecret: '<clientSecret goes here>',
  },
  scopes: [
    'create_anonymous_token:liquor-club',
    'manage_my_quote_requests:liquor-club',
    'manage_my_business_units:liquor-club',
    'manage_my_shopping_lists:liquor-club',
    'manage_my_payments:liquor-club',
    'manage_my_profile:liquor-club',
    'manage_my_quotes:liquor-club',
    'manage_my_orders:liquor-club',
    'view_categories:liquor-club',
    'view_published_products:liquor-club',
  ],
  fetch,
  tokenCache: makePersistentTokenCache()
}

const anonymousSessionClient = new ClientBuilder()
  .withProjectKey('<projectKey goes here>')
  .withAnonymousSessionFlow(anonymousSessionAuthMiddlewareOptions)
  .withHttpMiddleware(httpMiddlewareOptions)
  .withUserAgentMiddleware()
  .build()

One more thing, in my code above, you'll see that I return {} when I don't have a valid token available. This matches the behavior of the store the SDK uses by default: https://github.com/commercetools/commercetools-sdk-typescript/blob/5e61cc76d8a6442310adf91fdf473549af13036c/packages/sdk-client/src/sdk-middleware-auth/utils.ts#L1-L10
when it is given an initial value of {}, as it usually is, like in your recent update to the anonymous session flow: https://github.com/commercetools/commercetools-sdk-typescript/blob/5e61cc76d8a6442310adf91fdf473549af13036c/packages/sdk-client/src/sdk-middleware-auth/anonymous-session-flow.ts#L16
This works perfectly fine, but it actually conflicts with the type definitions for tokenCache: https://github.com/commercetools/commercetools-sdk-typescript/blob/5e61cc76d8a6442310adf91fdf473549af13036c/packages/sdk-client/src/types/sdk.d.ts#L261-L264
which indicate that the get() method of tokenCache should always return a fully formed TokenStore object, even if one is not available. To prevent type errors, I have to cast {} as TokenStore in my code.
The default store the SDK uses internally actually doesn't use this type definition, which is probably why the inaccurate type definition hasn't been noticed before. I think the simplest solution would be to update the type definitions to allow get() to return {}. It might be better to return undefined when no token is available, but that may require more extensive updates to the codebase.
But, my code is functioning the way I need it to now, so this is just a suggestion, thanks very much for you help :)


Build chat

Moving the chat notifications action from the main repo here. Adding the option to notify individual Slack users for satellite repositories.

Looks good to me!


'x' key is captured and isn't registered as a character

When creating a query requiring an 'x' character, the character doesn't show up in the input field, and replaces the clipboard with the contents of the input.
Said another way, pressing x causes a copy operation, without holding any other modifier.

another note, I can paste a query with an x into the input field, and it works as expected.


⚠ ClamAV has degraded performance

In a60b208, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 78b9e50.


Feature Request: Option to Integrate SimpleCalendar's seasonal Sunrise/Sunset changes

Simple Calendar has recently expanded its list of features with it's 1.3.39 release (https://github.com/vigoren/foundryvtt-simple-calendar/releases/tag/v1.3.39) including the ability to determine the time of sunrise and sunset based on the seasons and the current date for more realistic sunrise/sunset times throughout the in-game year.
As there is already some crossover between SmallTime and Simple Calendar it would be nice if SmallTime could simply take the more accurate sunrise/sunset times from Simple Calendar when both modules are present.

Already in the works :)

Implemented in 1.12.0 😄


Model Information only shows [object Object] as data

When I inspect an Element and navigate to Bindings the Model data is not shown anymore. Doesn't matter if it is an OData or JSON Binding. I only get something like this:
name: "modelName"
type: "sap.ui.model.json.JSONModel"
mode: "TwoWay"
data: [object Object]

UI5 Inspector Version is 0.9.13

Hello @MichaelFlucher ,
I have tried to reproduce the problem, but cannot see it. Can you provide public URL of the app, if possible?
Regards,
Iliana

I found the issue coming from this change:
https://github.com/SAP/ui5-inspector/commit/457a5729fa12f6de7c53d11b887c99a9c7a53dba#diff-24bfd57139161e0e174e66df277fad5bc2d96905358fb7e00ccde42a8e35d0eeL184-R200


Update boxer.py

Used to have this py2 to py3 error
TypeError: write() argument must be str, not bytes
details are reported in issue 1612

Thanks @cestwc


Help troubleshooting "Response signature validation failed"

I am trying to to implement SSO, and I get an error "Response signature validation failed.
" on the samlresponse.   I get this both on our server and using the validation tool at https://www.samltool.com/validate_response.php#.  The identity provider claims that the signature is good.  How can I troubleshoot this?

Were you able to review that the x509cert info on the SAMLResponse matches the one you used for validating the Signature?
Any idea about the software used at the IdP side?

Thank you for your response!  In fact, the x509cert in the response did not match the x509cert in the MetaData file they provided with!
For testing, I have updated the IdP MetaData xml to include the x509cert sent in the response.
When I plug this into the response validator(https://www.samltool.com/validate_response.php) it now validates: "THE SAML RESPONSE IS VALID"
Unfortunately, testing on our server we get a slightly different error now: "Invalid Signature on SAML Response".  I have checked to ensure that the x509cert in the response is the same as what is loaded from the MetaData xml file, and they are the same.  Any ideas what could cuase this?  Thanks in advance!

A little more info on the error:  We're using 1.9.0, and the error is added when XMLSecurity::SignedDocument#digests_match? returns false

If digests_match fails, that means that ruby-saml was not able to validate the signature with the x509cert provided.

Maybe the x509Cert of the IdP registered is wrong
Maybe the SAMLResponse was modified in some way


fix: typings path

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please check the boxes that apply to this pull request.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] CI/CD update
[ ] This change requires a documentation update
[ ] Other... Please describe:

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.

[ ] Units
[ ] Manual
[ ] Other... Please describe:

:tada: This issue has been resolved in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix for WindowsError: [Error 206] The filename or extension is too long

I signed it!

I signed it!

Where exactly is WindowsError: [Error 206] coming from? From the error description, it only has to do with filenames. How does args equate to filenames or extensions?

Traceback (most recent call last):   File "C:\projects\libs\closure\closure\bin\build\closurebuilder.py", line 287, in <module>     main()   File "C:\projects\libs\closure\closure\bin\build\closurebuilder.py", line 276, in main     compiler_flags=options.compiler_flags)   File "...\libs\closure\closure\bin\build\jscompiler.py", line 133, in Compile     return subprocess.check_output(args)   File "C:\Python27\lib\subprocess.py", line 566, in check_output     process = Popen(stdout=PIPE, *popenargs, **kwargs)   File "C:\Python27\lib\subprocess.py", line 710, in __init__     errread, errwrite)   File "C:\Python27\lib\subprocess.py", line 958, in _execute_child     startupinfo) WindowsError: [Error 206] The filename or extension is too long
Python fails to create process on big projects. Temp file on our projects can reach 100-150 KB

Also, you'll need to squash your commits to one. See https://github.com/google/closure-library/pull/574#issuecomment-146009727 and http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

What happened with Travis CI build?

This error is from a Closure Compiler bug. They're working on it.
./closure/goog/test_module.js:25: ERROR - required "goog.test_module_dep" namespace never provided
goog.require('goog.test_module_dep');

The other errors were from Sauce Labs. It reached its VM limit (due to multiple runs). A test rerun usually solves this.


solved #4066 Added map pointing low,medium,high readers states in india

Related Issue
Added map pointing low,medium,high readers states in india
Fixes:  #4066
Description
https://github.com/user-attachments/assets/63e8583a-ad02-48c7-bdd4-bce424026886
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

Please add level3 label mam,by considering my efforts
https://github.com/user-attachments/assets/b8bc405f-cfb0-4ff1-a00a-ab69e184def4

What is  the mistake,can you elaborate

See the Navbar community spotlight option is appearing double times not Alligned properly rest of fine @KapuluruBhuvaneswariVspdbct

@sailaja-adapa  kindly check once and try to add level3 mam

what is your source ? based on which u have made this map ?

openleaflet

the map of india is distorted , add the correct map .

i think this is ok

nhi hai . add a new map .

Ok
On Sun, Oct 27, 2024, 8:56 PM Abhiruchi Sarswat @.***>
wrote:

nhi hai . add a new map .
Screenshot.2024-10-27.at.8.55.28.PM.png (view on web)
https://github.com/user-attachments/assets/837bce83-2fc1-4af4-aeae-49ab07c6c457
—
Reply to this email directly, view it on GitHub
https://github.com/anuragverma108/SwapReads/pull/4106#issuecomment-2440066255,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHOWNHH3RMPYO5PFXPRJZFDZ5UA2FAVCNFSM6AAAAABQV4HEE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQGA3DMMRVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

is it ok

no

changed level3 please

@sailaja-adapa please chweck

enhance the UI of the page . add navbar , footer and dark mode .
u can work on these issues and raise pr for it .

Good work keep Contributing @KapuluruBhuvaneswariVspdbct  :)

thank you


Remove support for non-JSON schemas (i.e. Protobuf, XSD, etc.)

Fixes #216
Props to @jstoiko.

I'm moving forward and gonna merge this PR. Please, if you see something wrong, missing, or just don't agree with the changes, don't hesitate to leave a comment after it's merged. I'll be happy to address these questions afterward.


api: present a user object on create/update

This is already done in other endpoints of the API, but this was weirdly
missing for users.
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

I'll merge this myself since it's a rather simple change and it's blocking my hackweek project 😋 Feel free to revert this or submit comments 😉


Rewording in-memory page

@jovanpop-msft : Thanks for your contribution! The author, @jodebrui, has been notified to review your proposed change.


🤡 Update tools

Changes

Enable tailwind css
Fix vercel.json (i.e. website link now works :D )
Update some ignore files
Add examples for folder structure

Looking Good 😎


[ + ] fm-mask add top props

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


SPARK-44058: Removed createPartition deprecated method for HiveShim.scala

JIRA link : SPARK-44058

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Hi @dongjoon-hyun There is going to be Hive 3.2.0 release which I am coordinating as well as Hive 4.x release after sometime. But as such this PR is not required. We can close this.

Ya, I saw the plan in dev@hive mailing list. Let's keep this PR open for now.
4.0.0 Stamatis Zampetakis
4.1.0 Denys Kuzmenko
4.2.0 Sai Hemanth Gantasala

Apache Spark also an Apache Spark 4.0.0 plan for next year.

https://lists.apache.org/thread/5vfof0nm82gt5b2k2o0ws944hofz232g

Release Plan for Apache Spark 4.0.0 (June 2024)

@dongjoon-hyun Also do you think we should migrate spark from 2.3.9 Hive to 3.x?

That is an independent topic and we can discuss in Apache Spark 4.0 scope too, @amanraj2520 .

Also do you think we should migrate spark from 2.3.9 Hive to 3.x?

That is an independent topic and we can discuss in Apache Spark 4.0 scope too, @amanraj2520 .

Also do you think we should migrate spark from 2.3.9 Hive to 3.x?

Sure I can start working on the same. Please let me know if we decide on this.


Add kube-version as entity label

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>resolves #3332

IMHO we should add this information to details drawer, not labels.

Sounds good. What should we do about the distro? Also have it only in the drawer?

@jakolehm PTALA?


Using zoom on videojs-wavesurfer

Hi
Is there any way to implement zoom on videojs-wavesurfer ? Something like this, but on the waveform of videojs
Thank you

Yes, you can set the zoom level on wavesurfer.js like this (based on the example you linked):
document.querySelector('#slider').oninput = function () {
    player.wavesurfer().surfer.zoom(Number(this.value));
};


Capability to Pass Algorithm Env Vars

Add a capability to pass environment vars for each job of the same type.
Also need to be able to set these values on a recipe type basis.

This issue was already completed.


Failed to load configuration with key workflow_dir in porla.toml file

If workflow_dir key is defined in config file, porla fails to start. After removing the key, everything is starting fine.
$ ./porla --config-file test.toml
[2023-06-16 17:33:18.577540] [0x0000ffff8c129008] [warning] No secret key set. Porla will generate one
[2023-06-16 17:33:18.577674] [0x0000ffff8c129008] [warning] Use './porla key:generate' to generate a secret key
[2023-06-16 17:33:18.631823] [0x0000ffff8c129008] [fatal]   Failed to load configuration

Used static binary from there: https://github.com/porla/porla/actions/runs/5242062776

Furthermore key listen_interfaces in porla.toml is ignored or not working properly. porla doesn't use set port.
listen_interfaces = [
  ["end0", 12345]
]

[root@alarm alarm]# netstat -tulpn | grep LISTEN
tcp        0      0 <IP_ADDRESS>:6881          <IP_ADDRESS>:*               LISTEN      60657/porla
tcp        0      0 192...:6881      <IP_ADDRESS>:*               LISTEN      60657/porla
tcp        0      0 <IP_ADDRESS>:1337          <IP_ADDRESS>:*               LISTEN      60657/porla
tcp6       0      0 ::1:6881                :::*                    LISTEN      60657/porla
tcp6       0      0 fe80:::::fe9:6881 :::*                    LISTEN      60657/porla

Thanks for fast responding. You are right. The set folder does not exist. My fault.
Obviously listen_interfaces only works properly if no session_settings key is declared.
Working
listen_interfaces = [
  ["end0", 58741]
]

#[session_settings]
#base = "default" # (valid: "default", "high_performance" or "min_memory_usage")

$ ./porla --config-file test.toml --log-level=trace
[...]
[2023-06-16 18:30:38.745819] [0x0000ffff8ae42008] [trace]   Session alert: successfully listening on [TCP] <IP_ADDRESS>:58741
[2023-06-16 18:30:38.745876] [0x0000ffff8ae42008] [trace]   Session alert: successfully listening on [uTP] <IP_ADDRESS>:58741
[2023-06-16 18:30:38.745993] [0x0000ffff8ae42008] [trace]   Session alert: successfully listening on [TCP] [fe80::e65f:1ff:fe95:aad%end0]:58741
[2023-06-16 18:30:38.746048] [0x0000ffff8ae42008] [trace]   Session alert: successfully listening on [uTP] [fe80::e65f:1ff:fe95:aad%end0]:58741
[...]

Failing
listen_interfaces = [
  ["end0", 58741]
]

[session_settings]
base = "default" # (valid: "default", "high_performance" or "min_memory_usage")

$ ./porla --config-file test.toml --log-level=trace
[...]
[2023-06-16 18:32:24.145196] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [TCP] <IP_ADDRESS>:6881
[2023-06-16 18:32:24.145252] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [uTP] <IP_ADDRESS>:6881
[2023-06-16 18:32:24.145278] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [TCP] <IP_ADDRESS>:6881
[2023-06-16 18:32:24.145301] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [uTP] <IP_ADDRESS>:6881
[2023-06-16 18:32:24.145329] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [TCP] [::1]:6881
[2023-06-16 18:32:24.145354] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [uTP] [::1]:6881
[2023-06-16 18:32:24.145495] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [TCP] [fe80::e65f:1ff:fe95:aad%end0]:6881
[2023-06-16 18:32:24.145552] [0x0000ffffb3123008] [trace]   Session alert: successfully listening on [uTP] [fe80::e65f:1ff:fe95:aad%end0]:6881
[...]

The workflow_dir issue was fixed in #195.
Ah, yeah, I see now why the listen interfaces don't work. We apply the session settings base after we set the listen interfaces. It should probably the other way around. I'll push a fix for that as well.

As usual. Thanks a lot. :)

Of course 😃 It will be fixed in #196.


Added Fnt commands (FntLoad, FntOpen, FntFlush)

Added CompMatrix to libgte.h
Added Fnt commands
Added CMakeLists.txt

Was merged manually.


Improve testing

@chaws could you squash some commits to limit the amount of changes? Some lines show up in one commit just to be removed 2 commits later.

@mwasilew I squashed all commits into 3. I think it looks better for revision now.
Also, forgot to reference: close https://github.com/Linaro/squad-client/issues/8 and close https://github.com/Linaro/squad-client/issues/7


Update package metadata

Updated maintainer information and homepage
Email needs changing also
Once this merges, can merge up into the develop branch as well

Thanks for setting up the Google Group! Will merge this and work out how to do a release again (and open a PR to merge the latest metadata/CI changes into develop)


update read me for unable to connect to the server

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

@netroby :wave: Thanks for opening this PR. Please check the box to allow edits from maintainers.

Done as request. thanks

@zacharysarah hello, can this pull request be merged?


Coverage remained the same at 100.0% when pulling e98c0d382b419a881b7de65f2cc703855d68bb85 on magicmemories:queue-not-stack into 468fe867815bd86fde9797379964b7336d5bcfec on arempe93:master.

Coverage remained the same at 100.0% when pulling e98c0d382b419a881b7de65f2cc703855d68bb85 on magicmemories:queue-not-stack into 468fe867815bd86fde9797379964b7336d5bcfec on arempe93:master.

Coverage remained the same at 100.0% when pulling e98c0d382b419a881b7de65f2cc703855d68bb85 on magicmemories:queue-not-stack into 468fe867815bd86fde9797379964b7336d5bcfec on arempe93:master.


Superman is failing to Update our OS Versions. 12.6.6 and Ventura 13.4.0 to the latest version.

We are running into this error message while trying to your your script in production. We have an issue in which the script is not updating our endpoints to 12.6.7 of Monterey. In addition to Ventura 13.4.1.  Please feel free to reach out to me at<PHONE_NUMBER>. Jon DeBerry

Executing Policy SUPERMAN Run_PRODUCTION MASTER
Running script Run Superman...
Script exit code: 1
Script result: sudo: super: command not found
Error running script: return code was 1.

This is not an issue with super's code, this is a problem with your implementation.
If you want support for using super please reach out to the Mac Admins Foundation Slack in channel #super.


[FLINK-14261] Add PermanentlyFencedRpcEndpoint

What is the purpose of the change
This PR is based on #9789.
This PR adds PermanentlyFencedRpcEndpoint which requires a non-null fencing token at startup and does not allow to change it.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

You are right that the commit can be independent of the others. It just happened to be in a chain of commits which I need for FLINK-11843 and I wanted to keep the chain in order which makes it easier for me to keep track where we are in the merge process.
Concerning @Nonnull I think the current community agreement was to not use it. Hence, I would start to stick to it so that we might eventually converge towards a consistent code base. This might still take a bit of time ;-)


feat(rhel6) drop redhat 6 as a build option

RHEL6 full support ended on May 10, 2016, End of Maintenance Support 1 ended on May 10, 2017.
The RHEL 7 and RHEL 8 ubi images have the ability to install and test our Kong releases without requiring redhat credentials.
These two reasons are strong enough reasons that it's time to ditch rhel6

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Small fix to nginx.conf

Source: https://github.com/silverstripe/silverstripe-framework/blob/4.0/docs/en/00_Getting_Started/01_Installation/How_To/Setup_Nginx_and_HHVM.md

thanks


api/v1/targets is causing liveness probe failure

Proposal
Running prometheus in a POD with 12 core and 75G memory, our kubernetes cluster have ~500 nodes.
In the job configuration, it has total around 4500 targets (node, pod...), up or down,
the problem is when I try to call API "api/v1/targets", it causes the prometheus hang, at least on the HTTP service port, and then liveness probe, /-/healthy, cannot go through so the POD got restarted, is this because the response of "api/v1/targets" is too huge? I can never really completely open http://hostnameapi/v1/targets in a browser, by "wget" the file downloads is ~342M.
by reading the document that, https://prometheus.io/docs/prometheus/latest/querying/api/#targets
It says: "Both the active and dropped targets are part of the response."
Ok, I guess this is something not good.
Can the response of this call to be split into pages?
Or accept kind of "selector"?
Bug Report
What did you do?
calling API "api/v1/targets"
What did you expect to see?
get a list of "target"
What did you see instead? Under which circumstances?
a huge response even caused the prometheus get restarted.
Environment
Running prometheus in a POD with 12 core and 75G memory, our kubernetes cluster have ~500 nodes.
d

Prometheus version:
/etc/prometheus # /bin/prometheus --version
prometheus, version 2.6.1 (branch: HEAD, revision: b639fe140c1f71b2cbad3fc322b17efe60839e7e)
build user:       root@4c0e286fe2b3
build date:       20190115-19:12:04
go version:       go1.11.4

v1.7.1

the prometheus version is:
/etc/prometheus # /bin/prometheus --version
prometheus, version 2.6.1 (branch: HEAD, revision: b639fe140c1f71b2cbad3fc322b17efe60839e7e)
build user:       root@4c0e286fe2b3
build date:       20190115-19:12:04
go version:       go1.11.4

Can you try the latest version?

@brian-brazil
good or bad, the latest version is able to survival through this, although still, none of my browsers can completely open the "api/v1/targets" URI, "wget" can download the file completely, the size is 1.4G, I assume the previous file was partial downloaded before the POD got restarted, so it was only 342M.
But the problem still exists, I don't have too much confidence to have my code to handle a 1.4G response from a single API call.
So, I still believe the particular API call  "api/v1/targets" requires to be split into pages or have some "filter" to narrow down the scope of return context.

From a Prometheus standpoint, as long as it's not blocking the server isn't not a big problem.

Is that possible to "dorp" the "droped" target from this call?

No, that's important debugging information that we need to return.

@brian-brazil do you mind direct me to the code in the project which handles this API call?

all right, I found the code, and me dig a while and see what I can do.

https://github.com/prometheus/prometheus/pull/6276 will be adding an option to exclude dropped targets from the response by usng a query parameter like /api/v1/targets?state=active.

We went through this issue in our bug scrub and we have fixed some issues around locking in the targets path. Could you upgrade to the latest issue and see if its fixed?
If it's not, please re-open the issue and let us know?


Issue template documenting process for decommissioning a hub

Mostly a copy of https://github.com/2i2c-org/pilot-hubs/issues/679#issue-995296431 with a few extra pieces of info to fill out.
fixes https://github.com/2i2c-org/team-compass/issues/171

Closed in favour of https://github.com/2i2c-org/pilot-hubs/pull/700


[Markdown] Add shield for count of open "help wanted" issues under each project

Current Behavior
Missing "help wanted" shield with count of open issues.

Desired Behavior
Include the “help wanted” for each of these orgs or maybe those could be on the individual projects.

Contributor Guide

Hello @leecalcote. Can I work on this? And can you please brief me about getting started?

Does this help?

yes @sudhay23 , let the text be just help wanted, like this

Sorry, what you have done is correct

@sudhay23 Use advanced queries on https://shields.io (https://img.shields.io/github/contributors/layer5io/layer5.svg) for each project individually .

@debo19 Is it okay to add 4 individual shields in this repo's README each one pointing to help-wanted issues of each project?

@debo19 Is this way to organize the shield desired?

@sudhay23 you have to add it to the Projects section for this one (refer to the screenshot in the issue) and please try to make all shields appear horizontally

@debo19 Sure. I'll put them in the right place. And can you clarify horizontally a bit more? I thought of placing the shields in the line right after the last sentence of description about each project

@sudhay23 I meant if you're adding more than one shield like in the picture you shared...they should be side by side and not  in a column format. You can go ahead with placing them after the description, do share a screenshot after you do , it'll be easier to check how it's looking🚀

@debo19 Yeah sure. 👍

Meshery => https://github.com/meshery/meshery/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22+org%3Ameshery
This is the repo i could find for Meshery. But I'm unable to spot the right repo to source information from for the other projects. Can you please help me out with the appropriate repo URLs @debo19 ?

@debo19 @leecalcote Can you please verify the screenshot?

@sudhay23 looks good

@debo19 Thanks. I'll open my PR now


Unauthorized access: Signature failed for reservations/convert endpoint

To reproduce:

visit solutions page in admin dashboard OR
in jsng shell j.sals.zos._explorer.conversion.initialize() which calls the endpoint https://explorer.testnet.grid.tf/api/v1//reservations/convert

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/root/js-ng/js-sdk/jumpscale/clients/explorer/conversion.py", line 24, in initialize
    resp = self._session.get(url, auth=auth, headers=headers)
           │                 │         │             └ {'threebot-id': '413'}
           │                 │         └ <jumpscale.clients.explorer.auth.HTTPSignatureAuth object at 0x7fdd2148abe0>
           │                 └ 'https://explorer.testnet.grid.tf/api/v1//reservations/convert'
           └ <jumpscale.clients.explorer.conversion.Conversion object at 0x7fdd2148ae80>
  File "/root/.cache/pypoetry/virtualenvs/js-sdk-8MwJjzMr-py3.6/lib/python3.6/site-packages/requests/sessions.py", line 543, in get
    return self.request('GET', url, **kwargs)
           │                   │      └ {'auth': <jumpscale.clients.explorer.auth.HTTPSignatureAuth object at 0x7fdd2148abe0>, 'headers': {'threebot-id': '413'}, 'allow...
           │                   └ 'https://explorer.testnet.grid.tf/api/v1//reservations/convert'
           └ <requests.sessions.Session object at 0x7fdd256ad470>
  File "/root/.cache/pypoetry/virtualenvs/js-sdk-8MwJjzMr-py3.6/lib/python3.6/site-packages/requests/sessions.py", line 530, in request
    resp = self.send(prep, **send_kwargs)
           │         │       └ {'timeout': None, 'allow_redirects': True, 'verify': True, 'proxies': OrderedDict(), 'stream': False, 'cert': None}
           │         └ <PreparedRequest [GET]>
           └ <requests.sessions.Session object at 0x7fdd256ad470>
  File "/root/.cache/pypoetry/virtualenvs/js-sdk-8MwJjzMr-py3.6/lib/python3.6/site-packages/requests/sessions.py", line 650, in send
    r = dispatch_hook('response', hooks, r, **kwargs)
    │   │                         │      │    └ {'timeout': None, 'verify': True, 'proxies': OrderedDict(), 'stream': False, 'cert': None}
    │   │                         │      └ <Response [401]>
    │   │                         └ {'response': [<function raise_for_status at 0x7fdd230d0ea0>]}
    │   └ <function dispatch_hook at 0x7fdd24c93488>
    └ <Response [401]>
  File "/root/.cache/pypoetry/virtualenvs/js-sdk-8MwJjzMr-py3.6/lib/python3.6/site-packages/requests/hooks.py", line 31, in dispatch_hook
    _hook_data = hook(hook_data, **kwargs)
                 │    │            └ {'timeout': None, 'verify': True, 'proxies': OrderedDict(), 'stream': False, 'cert': None}
                 │    └ <Response [401]>
                 └ <function raise_for_status at 0x7fdd230d0ea0>
  File "/root/js-ng/js-sdk/jumpscale/clients/explorer/errors.py", line 23, in raise_for_status
    raise HTTPError(http_error_msg, response=resp)
          │         │                        └ <Response [401]>
          │         └ '401 Client Error: {"error":"unauthorized access: signature verification failed"}\n for url: https://explorer.testnet.grid.tf/ap...
          └ <class 'requests.exceptions.HTTPError'>
requests.exceptions.HTTPError: 401 Client Error: {"error":"unauthorized access: signature verification failed"}
 for url: https://explorer.testnet.grid.tf/api/v1//reservations/convert

401 Client Error: {"error":"unauthorized access: signature verification failed"}
 for url: https://explorer.testnet.grid.tf/api/v1//reservations/convert

@ranatrk can you retry using the branch from PR #1124

I cannot reproduce it myself.
Are you sure of the default identity configured in js-sdk ? Make sure you're not trying to reach testnet explorer with a mainnet identity

yes its on testnet

@ranatrk can you retry using the branch from PR #1124

When switching to this branch:

From the admin dashboard the error isn't shown
From the shell when running the previous command it says already converted(Which means it converted successfully with no errors right?):

JS-NG> j.sals.zos._explorer.conversion.initialize()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/root/js-ng/js-sdk/jumpscale/clients/explorer/conversion.py", line 23, in initialize
    raise AlreadyConvertedError('convertion for user '' has already been done'e.tid} has already been done")
          │                                            └ Identity(
  instance_name='ranatarek_test',
  _tid=413,
  words='snake month once sure control again damp grocery essence future...
          └ <class 'jumpscale.clients.explorer.conversion.AlreadyConvertedError'>
jumpscale.clients.explorer.conversion.AlreadyConvertedError: convertion for user 413 has already been done

convertion for user 413 has already been done

Which means it converted successfully with no?

This is right. This is the expected output and seem thr authentication error is fixed.
Feel free to merge the PR and close this issue

thanks


fix(security): CVE-2019-10747 upgrade set-value >= v4.0.1

update package-lock.json to npm lockfileVersion 2

Hi @kesor!
Thank you so much for opening a PR :open_hands:
The current main branch depends on v2.0.1 of set-value, which also contains a fix for CVE-2019-10747. This has been included in release v1.0.3 of the SDK.
Does this resolve your issue?

sounds good, glad to help.


What is the different Resize and Thumbnail functions?

Hi everyone
What is the different Resize and Thumbnail functions?
Example:
resizedImg := imaging.Resize(srcImage, 100, 0, imaging.Lanczos)
resizedImg := imaging.Thumbnail(srcImage, 100, 0, imaging.Lanczos)

Solved: Thumbnail has a crop feature.


CADEOS.io将令牌合同帐户名更改为“ cadeositoken”

项目背景：
CADEOS.io-去中心化的CAD.FILES和项目管理平台
官方公告：
https://twitter.com/CadeosI/status/1068175488659714048
项目团队背景：
https://www.linkedin.com/in/guillermo-galindo-saeta-749a2557
https://www.linkedin.com/in/jesús-moya-galindo-bb24861a
https://www.linkedin.com/in/javier-saeta-hidalgo
项目基本信息：
如今，对企业家和创造者的最大限制之一是昂贵的软件许可，并且借助CADEOS.io，我们希望通过消除分散式软件的问题来为每个人提供便利。在直观和用户友好的环境中，我们将使创建过程和产品发布变得负担得起且非常容易。
通过标记各种项目，我们的用户可以看到他们的想法和努力已成功实施。我们的平台将为那些因市场壁垒而停滞不前的聪明人带来机会。
从最初的草图到制造过程，用户都可以在我们的产品生命周期管理器（PLM）平台中监视设计状态。工厂，供应商和所有相关的第三方都将能够在我们的平台上查看您的报价请求（RFQ），并发送每个组件的制造价格。
借助CADEOS.io，您可以使用我们的分散式CAD软件来设计任何机械和电子组件，并在成千上万寻求最佳创意的投资者的注视下在我们的社区中进行推广。
CADEOS.io平台将托管来自数千个不同品牌的大型组件库，并将负责提供尽可能广泛的资源，以简化产品的组成。
通过创建您的供应商组合，您将获得最佳建议，并与全球任何行业的最佳专业人员直接交流。每个区域都有自己的交流渠道和聊天室。
通过在动态用户配置文件中进行的每次创建，您将为所有产品，3D模型，3D打印机零件，电子方案等增加价值，从而有利于投标和销售，这将在CADEOS.io平台上取得成功。您的工作将永远不会丢失或遗忘，并且会不时地使用我们的代币ADE重新估价。
媒体出版物：
https://koreos.io/News/412220
https://medium.com/cadeos-io
https://www.stateofthedapps.com/dapps/cadeos
https://t.me/cadeos
https://marketcap.one/es/m/ADE
可交易的交易所：
https://token.store/eos/trade/cadeositoken-ade-eos
https://newdex.io/trade/cadeositoken-ade-eos
https://findex.pro/trade/cadeositoken_ADE-eosio.token_EOS
https://eosdaq.com/exchange/ADE_EOS
https://mydex.win/
Project background:
CADEOS.io - DECENTRALIZED CAD.FILES & PROJECT MANAGEMENT PLATFORM
Official announcement:
https://twitter.com/CadeosI/status/1068175488659714048
Project team background:
https://www.linkedin.com/in/guillermo-galindo-saeta-749a2557
https://www.linkedin.com/in/jesús-moya-galindo-bb24861a
https://www.linkedin.com/in/javier-saeta-hidalgo
Project basic information:
Today one of the biggest constrains for entrepreneurs and creators are the expensive software licenses and, with CADEOS.io, we want to facilitate this process to everyone by getting rid of the problem with our decentralised software. We will make the creation process and product launch affordable and very easy within an intuitive and user friendly environment.
By tokenising all kind of projects our users can see their ideas and effort successfully implemented. Our platform would will bring an opportunity to those brilliant minds that are stopped by the market barriers.
From the first sketch to the manufacture process, the users can monitor the state of your design in our Product Lifecycle Manager (PLM) platform. Factories, suppliers and all the 3rd parties interested will be able to review your Request for Quotation (RFQ) in our platform and send the manufacture price for each component.
With CADEOS.io you can design any mechanical and electronic component with our decentralised CAD software and promote it in our Community, under the watchful eye of thousands of investors looking for the best idea.
CADEOS.io platform will host a large gallery of components from thousands of different brands and will be responsible of providing the most extensive resources as possible for an easy product composition.
By creating your portfolio of suppliers you will have the best advice and direct communication with the best professionals in any industry around the world. Each area will have their own communication channels and chatrooms.
With every creation within your dynamic user profile, you will add value to all your products, 3D models, 3D printer parts, electronic schemes, etc., favouring the bids and sales which will be a success in CADEOS.io Platform. Your work will never be lost or forgotten and will be revaluated from time to time with our token ADE.
Media publications:
https://koreos.io/News/412220
https://medium.com/cadeos-io
https://www.stateofthedapps.com/dapps/cadeos
https://t.me/cadeos
https://marketcap.one/es/m/ADE
Tradeable exchanges:
https://token.store/eos/trade/cadeositoken-ade-eos
https://newdex.io/trade/cadeositoken-ade-eos
https://findex.pro/trade/cadeositoken_ADE-eosio.token_EOS
https://eosdaq.com/exchange/ADE_EOS
https://mydex.win/

https://bigone.zendesk.com/hc/zh-cn/articles/360025716714-BigONE-已暂停-ADE-的充提服务
https://medium.com/cadeos-io/cadeos-io-call-to-every-exchanges-to-change-ade-token-contract-account-to-cadeositoken-6c048a9e811b

https://bigone.zendesk.com/hc/zh-cn/articles/360025716714-BigONE-已暂停-ADE-的充提服务
https://medium.com/cadeos-io/cadeos-io-call-to-every-exchanges-to-change-ade-token-contract-account-to-cadeositoken-6c048a9e811b

关于重名及修改合约
在 imToken 1.0 里，如果你的项目名称和其它项目重复，我们会在后面加数字，如 TFT1、TFT2、TFT3 等；如果你希望去掉数字，我们首先声明，这是一个非常危险的操作，修改代币信息后，代币会突然消失，容易引起用户恐慌，原则是对于持币人数多的项目，我们建议项目方推荐用户下载使用 imToken 2.0，imToken 2.0 通过代币合约地址来区分代币，所以不存在代币名称重复。
如需修改合约地址，需要项目方在社区发布修改合约公告。并在 GitHub 提交新的 PR，将旧合约 Logo 作去色处理（Photoshop 操作路径：图像 - 调整 - 去色），然后提交新的代币合约和 Logo，并把公告链接在 PR 下留言，我们会核实情况修改。

I don't understand, can you write me in english please ? Translators from Chinese are really bad. This is the 5º time i try to change this following your instruction. Logo was discolored and attached here. Our token changed contract announced was attached here, i don't know what do you need more, please try to help me !!!

Regarding Duplicated Token Names or Contract Amendment
In imToken 1.0, if duplicated token names are found, imToken team will add a number after the token name for the project, like TFT1, TFT2 etc. If you wish to remove the number, we need to claim, this is a very dangerous operation. Removing the number is not advisable, as amending the token name will cause the token to disappear from imToken display and may cause unnecessary panic among users. For tokens with many holders, we recommend the token project to suggest to your users, to download and use imToken 2.0, as imToken 2.0 distinguish tokens via contract address. Therefore, this mitigates the problem of duplicated token names.
If there are update requests due to contract amendment, follow the checklist:
make an official announcement for the upgrade of the contract
submit a new PR in GitHub:
desaturate the old logo (In Photoshop: image - adjustments - desaturate)
resubmit new token contract’s json and logo
share your announcement link under the comment section in the PR
imToken team will evaluate the situation.

Hello,
PR in Github :
https://github.com/CADEOS/ADE-TOKEN-CONTRACT
Oficial token contract name announce :
https://twitter.com/CadeosI/status/1147270518426525698
https://medium.com/cadeos-io/cadeos-io-call-to-every-exchanges-to-change-ade-token-contract-account-to-cadeositoken-6c048a9e811b
Attached here desaturated old logo.
Here resubmited new token contract’s json and logo.
Is exactly all i shared all time.
Please check. What do you need more?

I'm sorry, Logo doesn't meet the requirements. 120 px * 120 px

Fixed the icon size, now is 120px x 120px . Sorry so much for every inconveniences and huge thanks for your help !


H5P loading trouble in mobile (Android)

H5P components does not load on mobile network but works fine in the wifi. We have tried accessing it from different android devices and it is the same.

@zameel7 It is not something related to H5P xblock. It might be related to the actual H5P content you have created/uploaded using H5P xblock.


Update cura to 2.6.0

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x ] brew cask audit --download {{cask_file}} is error-free.
[x ] brew cask style --fix {{cask_file}} reports no offenses.
[ x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 66056b7a01632337e75a2fa4978c7a189d0937bd. Your contribution is still credited to you.


Camera Analyzer: checks for Camera.main usage in Updates.

Checks for Camera.main usage in Monobehaviour:Updates.
Camera.main uses FindByTag<> under the hood.
Cache this call, for example to CameraCache class.

awesome - i've been meaning to get this one in since Unite Europe


an exception is received by the calling code

About exceptions, for the "Number of subscriptions per topic" quota, is the exception received "QuotaExceededException", and would it be thrown from a SubscriptionClient.CreateFromConnectionString or _namespaceManager.CreateSubscription call?
thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17b26254-ce8c-76eb-c3e9-b80c3ecc45ba
Version Independent ID: fc16f0d4-dae7-8494-e25a-6c5398215b4b
Content: Microsoft Azure Service Bus quotas and limits
Content Source: articles/service-bus-messaging/service-bus-quotas.md
Service: service-bus-messaging
GitHub Login: @sethmanheim
Microsoft Alias: sethm

Thanks for the feedback! We are currently investigating and will update you shortly.

@antondahlin not sure I am fully understanding your question.
Can you elaborate a bit more?

The "Number of subscriptions per topic" quota is said to throw an exception, but not which, I was just asking if it will use the QuotaExceededException like some other limitations do.

Ah okay! Makes sense. Thank you for clarifying that for me. In my experience when you exceed a quota the error throwing will be QuotaExceededException followed by a more detail explanation of how many cores you are going over and how many more you need.

Okay, great! Thank you for the reply!


Allow milliseconds for all timestamps

Some terms (especially media timestamp and  eventStart and eventEnd) could benefit from expressing milliseconds. Ideally we support 4 ways of writing timestamps (all ISO):
2013-11-23T08:30:00Z         # seconds UTC
2013-11-23T06:30:00-0200     # seconds + offset
2013-11-23T08:30:00.300Z     # milliseconds + UTC
2013-11-23T06:30:00.300-0200 # milliseconds + offset

All of these seem to pass Frictionless Framework validation for format=default, but according to the specs, default implies:

An ISO8601 format string e.g. YYYY-MM-DDThh:mm:ssZ in UTC time

It looks like Frictionless Framework also allows timezone offsets (i.e. more than the specs allow). @roll is this intentional?
For Camtrap DP we therefor opted to explicitly define the format:
https://github.com/tdwg/camtrap-dp/blob/22f5309f9a29d2b202d453c4c68d52d325c21e28/observations-table-schema.json#L53
That pattern will however fail for milliseconds, so we should adapt it. Or we should always require milliseconds.
Note that %z correctly allows -0200, +0200, Z and correctly forbids empty and -0280.

Explicitly defining the format (i.e. not relying on default) and having milliseconds optional is not possible. format relies on strptime, which does not have a format code for optional milliseconds (there is a feature request  for it). So we have two options:

Always requiring milliseconds and using format %Y-%m-%dT%H:%M:%S.%f%z. Note that e.g. Movebank exports always have milliseconds.
Relying on format = default, which allows (in Frictionless Framework) the four formats above, even though the specs say it should forbid non UTC.

Discussed with @kbubnicki, moved to 1.1. Camtrap DP 1.0 will thus not allow milliseconds, but we keep the explicit format that warns for missing timezone (which is likely a more common use case). We'll have to see how this evolves at Frictionless.


Remove unimplemented config options

There are some config options e.g. root that aren't actually used. These should be removed for now, an issue should be logged for the feature they are attached to, and the options can then be reintroduced when a corresponding feature implementation is added.

Resolved in this CL.


[No QA]Add port flag to allow iOS and Android to run simultaneously

Details

Adds a --port flag to the metro/react native cli commands for iOS and Android to allow all four clients to be run at the same time.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/233635
Tests

Delete your current pods (rm -rf ios/Pods)
Reinstall them (cd ios && pod install)
Run iOS, Android, Desktop, and Web all at the same time in different terminal tabs
Verify any changes are hot reloaded by all four clients at once (verifying metro and webpack builds are OK to run at once)

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

No QA, internally tested by me and @tgolen
Screenshots

Web

Desktop

iOS

Android

There are changes to package.json but there are no changes to package-lock.json.

Having an issue with my iOS simulator:
╰─ pod install

[!] Invalid `Podfile` file: [!] /usr/local/bin/node -e try {console.log(require('@react-native-community/cli').bin);} catch (e) {console.log(require('react-native/cli').bin);}

/Users/jasperhuang/Expensidev/App/node_modules/@react-native-community/cli/build/index.js:156
    cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val), typeof opt.default === 'function' ? opt.default(rest[0]) : opt.default);
                                          ^

SyntaxError: Unexpected token '?'
    at Module._compile (internal/modules/cjs/loader.js:892:18)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jasperhuang/Expensidev/App/node_modules/react-native/cli.js:13:11)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)
.

 #  from /Users/jasperhuang/Expensidev/App/ios/Podfile:15
 #  -------------------------------------------
 #
 >    config = use_native_modules!
 #
 #  -------------------------------------------

Looking into this right now, but can't test until I figure this out

My android server is not starting cmd npm run android is getting stuck at

@parasharrajat - What OS are you running on?
@jasperhuangg - Did you ever resolve your iOS issues? Can you post in Slack and tag me?

@parasharrajat - What OS are you running on?

This was Linux. I will try to setup Android on Mac for this PR. Running other WEB | IOS | Desktop for now.

Ok, this is working fine but the Android build is not starting on Linux.

And Android starts on main in your environment, correct? e.g. without the port flag? Can you get anymore flags via a verbose flag?

On Linux android works this way.

I start a metro server in a terminal react-native start or npm run start.
Then I run npm run android in another tab.

so, I think the issue is that with port option npm run android is not able to find the metro server which means the metro server may be starting on a different port.

Yeah, you are correct. It should start the metro server automatically. I will try to find a solution to that. But I suggest we change the npm run start to npm run start -- --port=8083 if that is aligned with this PR.

I think one issue is that we do not know whether to start the iOS port or Android port for npm run start?

🚀 Deployed to production by @sketchydroide in version: 1.2.17-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Sorry for the delayed ping. I just noticed this was not paid for c+. Following the C+ process, can someone assign a BZ to look into this?
cc: @AndrewGable

@Expensify/bug-zero - Can someone handle this payment? Thanks!

Created an issue for it here: https://github.com/Expensify/App/issues/12881


Is the local server required when using Parse?

After "Setup" with the following /src/lib/config.js:
module.exports = {
  PARSE: {
    APP_ID: '...',
    REST_API_KEY: '...',
    SESSION_TOKEN_KEY: 'SESSION_TOKEN_KEY'
  },
  backend: {
    parse: true,
    hapiLocal: false,
    hapiRemote: false
  }
}

Running the iOS app in Xcode fails with the following error:
Could not connect to development server.

Ensure the following:
- Node Server is running and available on the same network - run 'npm start' from react-native root
- Node server URL is correctly set in AppDelegate

URL: http://localhosts/index.ios.bundle?platform=ios&dev=true

So, 4 things (EDIT: 5 things):

Obviously it's not running, because I thought / it seemed it was possible to run the app using only Parse for the backend.
I didn't see anything in "Setup" about updating AppDelegate; I do see mention of it in the "Continuous Integration" steps.
The default / original value used in AppDelegate is localhosts. Is that a typo?
Is it possibly to run this without the local server using only Parse?
Also, switching to the automatically generated "pre-bundled file on disk" results in a successful build, with no error, but a blank (black) screen.

EDIT: Added 5th point above.
EDIT 2: Working just fine with local server AND Parse using localhost:8081 URL in AppDelegate instead of localhosts (assuming the latter is a typo).

It seems the answer is, "Obviously, yes." and that this isn't really the issue I ran into, since the server is started automatically in the Build/Run steps. It's also obviously not mentioned in "Setup" because you don't have to run it manually.
It seems the issue I ran into was just due to the default localhosts instead of localhost:8081 typo, which generated an error message that lead me to believe the server hadn't been started and needed to be started manually.
Closing & opening separate issue for typo.


Offline usage

Hey, thanks for sharing this framework. I was hoping to add offline support and was wondering what your thoughts are at the moment?

Thanks, It's a good idea. But in that case, location search would be unavailable, there's much to adjusted. I will consider it, or if you are interested, please open a pull request.

You're right. When the user is offline, location will be unavailable. I was thinking of using the text that they have entered into the search field as the name in LocationItem. hashValue might also need to account for this and use the name as the hash when coordinates are unavailable. coordinate will also need to be changed to an optional type.
What do you think? I'll work on this if you don't see anything majorly wrong with the proposed changes.

If the user has to entry the location, it will not be "LocationPicker" anymore. I don't think it's a suitable change to this project. However, if you want something like you described, you can build one based on this project.

The way I've done it also allows user to pick a location if the MKLocalSearch doesn't yield any results. I've created a pull request, let me know if you would like this feature.

This feature is added to version 1.1.0

Thanks! Do we need to update README.md to include offline behaviour? LocationItem.coordinate may be invalid if user is offline. Users may need to check CLLocationCoordinate2DIsValid(coordinate).

I think it would be better to modify LocationItem, I will work on that.

I made coordinate in LocationItem an optional property and added a new init method, how do you think about it? 60e5e9786d61ad5898b8107d13ac68df426fc3f1

Looks good! Thanks!
On Monday, 9 May 2016, Jerome Tan<EMAIL_ADDRESS>wrote:

I made coordinate in LocationItem an optional property and added a new
init method, how do you think about it? 60e5e97
https://github.com/JeromeTan1997/LocationPicker/commit/60e5e9786d61ad5898b8107d13ac68df426fc3f1
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/JeromeTan1997/LocationPicker/issues/4#issuecomment-217764818


Fedora Linux 37 with btrfs file system.

build.sh:
sudo dnf -y update
sudo dnf -y groupinstall "C Development Tools and Libraries" "Development Tools" "Development Libraries"
sudo dnf -y install git fakeroot bc flex bison openssl-devel elfutils-libelf-devel ncurses-devel qemu-system-x86 dracut
sudo dnf -y install qemu-kvm qemu-img
wget https://cdn.kernel.org/pub/linux/kernel/v6.x/linux-6.1.11.tar.xz

tar -xf linux-6.1.11.tar.xz
pushd linux-6.1.11/
curl https://raw.githubusercontent.com/google/syzkaller/master/dashboard/config/linux/upstream-apparmor-kasan.config -o .config
make olddefconfig
make -j32
popd

export KERNEL=/home/oblivion/project/linux-6.1.11/
export IMAGE=/home/oblivion/project/image/

mkdir image
qemu-img create -f raw image/stretch.img 10G
mkfs.btrfs image/stretch.img
sudo mount image/stretch.img /mnt
sudo umount /mnt

qemu-system-x86_64 \
	-m 2G \
	-smp 2 \
	-kernel $KERNEL/arch/x86/boot/bzImage \
	-append "console=ttyS0 root=/dev/sda earlyprintk=serial net.ifnames=0" \
	-drive file=$IMAGE/stretch.img,format=raw \
	-net user,host=<IP_ADDRESS>,hostfwd=tcp:<IP_ADDRESS>:10021-:22 \
	-net nic,model=e1000 \
	-enable-kvm \
	-nographic

crashlog:
[   11.149884][    T1] rdma_rxe: loaded
[   11.150337][    T1] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   11.152197][    T1] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[   11.153343][   T24] platform regulatory.0: Direct firmware load for regulatory.db failed with error -2
[   11.153901][   T24] platform regulatory.0: Falling back to sysfs fallback for: regulatory.db
[   11.156560][    T1] ALSA device list:
[   11.156836][    T1]   #0: Dummy 1
[   11.157022][    T1]   #1: Loopback 1
[   11.157225][    T1]   #2: Virtual MIDI Card 1
[   11.158597][    T1] md: Waiting for all devices to be available before autodetect
[   11.158897][    T1] md: If you don't use raid, use raid=noautodetect
[   11.159161][    T1] md: Autodetecting RAID arrays.
[   11.159365][    T1] md: autorun ...
[   11.159509][    T1] md: ... autorun DONE.
[   11.172259][    T1] exFAT-fs (sda): invalid boot record signature
[   11.172551][    T1] exFAT-fs (sda): failed to read boot sector
[   11.172792][    T1] exFAT-fs (sda): failed to recognize exfat type
[   11.196753][    T1] VFS: could not find a valid V7 on sda.
[   11.206005][    T1] qnx6: unable to read the first superblock
[   11.210329][    T1] Mount JFS Failure: -22
[   11.220601][    T1] NILFS (sda): couldn't find nilfs on the device
[   11.221726][    T1] befs: (sda): invalid magic header
[   11.223685][    T1] (swapper/0,1,1):ocfs2_fill_super:988 ERROR: superblock probe failed!
[   11.224052][    T1] (swapper/0,1,1):ocfs2_fill_super:1174 ERROR: status = -22
[   11.225282][    T1] gfs2: gfs2 mount does not exist
[   11.226155][    T1] F2FS-fs (sda): Magic Mismatch, valid(0xf2f52010) - read(0x0)
[   11.226499][    T1] F2FS-fs (sda): Can't find valid F2FS filesystem in 1th superblock
[   11.227070][    T1] F2FS-fs (sda): Magic Mismatch, valid(0xf2f52010) - read(0x0)
[   11.227380][    T1] F2FS-fs (sda): Can't find valid F2FS filesystem in 2th superblock
[   11.228416][    T1] erofs: (device sda): erofs_read_superblock: cannot find valid erofs superblock
[   11.229126][    T1] zonefs (sda) ERROR: Not a zoned block device
[   11.230248][    T1] BTRFS: device fsid c9e82c1b-c6a8-44d3-9298-eb5676ef4a3f devid 1 transid 10 /dev/root scanned by swapper/0 (1)
[   11.232451][    T1] BTRFS info (device sda): using crc32c (crc32c-generic) checksum algorithm
[   11.232848][    T1] BTRFS info (device sda): using free space tree
[   11.306536][    T1] VFS: Mounted root (btrfs filesystem) readonly on device 0:22.
[   11.307054][    T1] devtmpfs: error mounting -2
[   11.330989][    T1] Freeing unused kernel image (initmem) memory: 2884K
[   11.357631][    T1] Write protecting the kernel read-only data: 182272k
[   11.362200][    T1] Freeing unused kernel image (text/rodata gap) memory: 2016K
[   11.363084][    T1] Freeing unused kernel image (rodata/data gap) memory: 444K
[   11.430809][    T1] x86/mm: Checked W+X mappings: passed, no W+X pages found.
[   11.433766][    T1] Failed to set sysctl parameter 'max_rcu_stall_to_panic=1': parameter not found
[   11.434467][    T1] Run /sbin/init as init process
[   11.435094][    T1] Run /etc/init as init process
[   11.435558][    T1] Run /bin/init as init process
[   11.436038][    T1] Run /bin/sh as init process
[   11.436432][    T1] Kernel panic - not syncing: No working init found.  Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance.
[   11.437145][    T1] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.11 #1
[   11.437475][    T1] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.1-2.fc37 04/01/2014
[   11.437961][    T1] Call Trace:
[   11.438155][    T1]  <TASK>
[   11.438317][    T1]  dump_stack_lvl+0x100/0x178
[   11.438576][    T1]  panic+0x2c4/0x60f
[   11.438789][    T1]  ? panic_print_sys_info.part.0+0x110/0x110
[   11.439096][    T1]  ? putname+0x101/0x140
[   11.439338][    T1]  ? kernel_execve+0x3f9/0x4e0
[   11.439592][    T1]  ? kernel_init+0x1b4/0x1d0
[   11.439813][    T1]  kernel_init+0x1c5/0x1d0
[   11.440039][    T1]  ? rest_init+0x270/0x270
[   11.440283][    T1]  ret_from_fork+0x1f/0x30
[   11.440532][    T1]  </TASK>
[   11.440824][    T1] Kernel Offset: disabled
[   11.441084][    T1] Rebooting in 86400 seconds..


Node-based edit workflow confusion

Hi,
First of all, fantastic work on making a non-destructive USD import/export addon!
While using it to edit/render a few scenes, I came to some issues that I hoped to get a sense of future directions:

Is editing an imported USD scene file supported workflow? Or is it primarily aimed at mixing read-only USD scenes in Blender?

In general, a node-based system should recompute on graph change; but in the land of USD editing, I find it not the best idea:

Every time we reconnect a USD File output to Render USD node, the system would source the USD file again, so unsaved change to the imported USD hierarchy is lost. This can happen in other situations as well.

Write USD File node always saves its input on reconnection, but when connected, update to imported USD hierarchy doesn't appear to save automatically.

We can point both USD File and Write USD File nodes to the same USD file, allowing us to save local changes to USD file. But in such context it is unclear when the graph should reload itself (or when it is safe to reload without losing local changes).

If we point Write USD File to a different file, then local changes can easily reset due to (1), and unintended change can flush to export USD due to (2).

I also find out that once a Blender scene has been exported to USD via Merge node, we can no longer control much of its original settings (Light intensity, for example).

All in all, I think it depends on whether this system is designed with USD editing in mind, or mainly targeting multi-scene composition.
Thx, and look forward to your response.

Hi.
Thank you for your nice words.
You allowed to modify imported USD scene via USD nodes (e.g. transform, instancing, filter etc.)
Yes, all USD nodes recomputes if there is changes in scene happen, so they return up to date USD stage.

What kind of unsaved changes? USD File node recomputes (reads pointed file) on changing input, output or its modifiers (e.g. import animation).
Write USD File node also recomputes when you modify node tree (add new nodes, modify existing).
It doesn't sound like a valid workflow - you can't be sure in what order nodes are updated.
In any case to be sure that you export up to date USD stage, better to just reconnect Write USD File after all.
Seems like you have Blender Data node with checked "import animation", in this case you have to either uncheck it or click Update animation button to make this node recompute changes. It works this way due to infinity loop on animation update.

I approve that you able to modify scene and node tree will be recomputed with new data immediately.


[ci] Backport the Azure -> GitHub migration to earlgrey_es_sival

I think this is going to be too difficult to get working. We'll probably recreate the whole .github workflow in one go and delete azure-pipelines.yml in one go.


added digitalocean blockstorage

LGTM. Adding @jlevy for second stage review ahead of merge. Thanks @mikejennings!

👍 Thanks, seems like a good addition!


Some refactoring & added support to stop playback on Windows

Since I found your project usefull and I need some extra feature (to stop the sound) I've did some refactoring over initial project.
If you don't find those changes usefull and want to keep the project as simple as it was before please just close this pull request.
I didn't test my changes on MacOS and Linux (but I will do it soon).

This is not backwards compatible. The function playsound should still play a sound, same as before.
I'm fine with you adding a feature to make it return an object that can be stopped and anything else you want.
Should you choose to rework this, please make sure to update test.py to cover whatever new functionality you add.


Add new exercise: markdown

problem specification | description | canonical data
You may find it helpful to follow this checklist from the CONTRIBUTING.md resource.

Hello,
I have a question.
After successfully populating the .meta/tests.toml with ./bin/configlet sync --update, is there a way to make the same for the tests in <slug>.spec.js?
Thanks,

@Kmelow No, the JavaScript track does not have a test case generator. You need to write the test file yourself.