Exam mode: Fix score visibility

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I implemented the changes with a good performance and prevented too many database calls.
[ ] I documented the Java code using JavaDoc style.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context
There are currently two issues when using test exams:

After having the test exam open for a while, students can suddenly scores that they should not be able to see while solving the exam. They also no longer get updated results via the websocket.
After submitting the exam, students should see their scores and test results. See #6207

Description
Steps for Testing
Prerequisites:

1 Test Exam, 1 real Exam
1 Student
1 Programming Exercise with all Test cases set to "After due Date"

Participate in both the real and test exam.

In the real exam, at no point, the student should see scores or feedback.
In the test exam, the students should not see the feedback during the exam, but they should see it after submitting theri test exam.

Review Progress
Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage
Screenshots

Codecov Report

Merging #6218 (7ca52db) into develop (d980297) will increase coverage by 3.84%.
The diff coverage is 75.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6218      +/-   ##
=============================================
+ Coverage      76.45%   80.29%   +3.84%
- Complexity         0    12833   +12833
=============================================
  Files           1223     2273    +1050
  Lines          46460    88123   +41663
  Branches        8655    13047    +4392
=============================================
+ Hits           35521    70759   +35238
- Misses          5641     9651    +4010
- Partials        5298     7713    +2415

Impacted Files
Coverage Δ

.../in/www1/artemis/service/exam/ExamDateService.java
65.62% <28.57%> (ø)

.../www1/artemis/service/exam/StudentExamService.java
85.71% <70.00%> (ø)

...ww1/artemis/service/WebsocketMessagingService.java
90.00% <75.00%> (ø)

.../de/tum/in/www1/artemis/service/ResultService.java
93.06% <81.81%> (ø)

...m/in/www1/artemis/service/ExerciseDateService.java
100.00% <100.00%> (ø)

...rest/ProgrammingExerciseParticipationResource.java
71.92% <100.00%> (ø)

...idebar/conversation-selection-sidebar.component.ts
88.66% <0.00%> (-0.67%)
:arrow_down:

...coring/ScoringStrategyDragAndDropAllOrNothing.java
54.54% <0.00%> (ø)

...is/domain/enumeration/TextAssessmentEventType.java
100.00% <0.00%> (ø)

...tlab/dto/GitLabPersonalAccessTokenResponseDTO.java
100.00% <0.00%> (ø)

... and 1047 more

Flag
Coverage Δ

client
76.45% <ø> (-0.01%)
:arrow_down:

server
84.58% <75.40%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d980297...7ca52db. Read the comment docs.


Check GO:0090605 submerged biofilm formation and GO:0090604 surface biofilm formation

GO:0090605 submerged biofilm formation 0 direct annotations
GO:0090604 surface biofilm formation 0 direct annotations
Are these are grouping terms (in which case they may be unnecessary); or are the children (single /multi species biofilm formation) not real processes - ie are the single vs multi species biofilm formation really different processes ?
Thanks, Pascale

Redundant with #20085


[per-directory-history] Multiple shells in the same folder do not share history

How to reproduce the problem

Open a shell in a folder, and type echo hello.
Open a second shell in that same folder and type echo world.
In both shells, use the arrow keys to view their respective history.

What happens
Each shell does not contain the history of the other, albeit them being in the same folder. Sometimes, toggling to global and back makes the entries appear in the history, but a little in the wrong order.
What should happen
All shells in the same folder have a shared history.

Please submit this issue in the upstream project.


Flyte issue #4691 Add support passing integer to flytekit.resource

Flyte issue #4691
_https://github.com/flyteorg/flyte/issues/4691_
Added support for passing string as well as integer to flytekit.resource

cc @Shenr0n any updates on this


Recommend setting up soroban-cli autocompletion as part of the setup process

Forgot to close this with #527


Publish user facing API docs by using https://typedoc.org and friends

We have the package here https://github.com/aerogear/graphback/blob/master/package.json#L30.
The idea is to build the docs from code comments and publish them under the API page avoiding having to maintain two separates docs.
Idea follows these comments:

https://github.com/aerogear/graphback/pull/1698#issuecomment-656646513
https://github.com/aerogear/graphback/pull/1698#issuecomment-656658562
https://github.com/aerogear/graphback/pull/1698#issuecomment-656661720

/cc @craicoverflow
Targeted API:

[ ] buildGraphbackAPI
[ ] createCRUDService
[ ] createKnexDbProvider
[ ] createMongoDbProvider
[ ] GraphbackDataProvider
[ ] GraphbackCRUDService
[ ] GraphbackPlugin

Running the below command in the root directory:
yarn typedoc --ignoreCompilerErrors --out typedoc --inputFiles packages/**/src/**/*.ts

Will result into the attached output:
This can be further tuned, by setting up the TOC or the Theme, wanted to first push this bare minimum output
which may help us in this direction.
typedoc.zip

We need to investigate if we can use typedoc as iframe or migrate to markdown.

https://github.com/tgreyuk/typedoc-plugin-markdown

https://github.com/tgreyuk/typedoc-plugin-markdown

@craicoverflow thanks for the link. I'll play with this to see how it integrates with typdoc and our website.

Using the markdown plugin with the docusaurus theme gives the above page for the buildGraphbackAPI.


Questions about implementations and types

Hello, we are working on an implementation of the ics23 spec and we have a few questions about the spec and implementations found here.

What is this check against 32 for? https://github.com/cosmos/ics23/blob/bf89d957b019bb9a2f381edb1f24d06957807690/go/proof.go#L158

is ProofSpec.InnerSpec nullable/optional? afaict, every use site of that field requires it to be set, but I'm not 100% sure since in the testdata, it is omitted sometimes: https://github.com/cosmos/ics23/blob/master/go/proof_test.go#L36

What are the validations against the IAVL spec in LeafOp.CheckAgainstSpec (go, rust) and InnerOp.CheckAgainstSpec (go, rust) for?

Not sure if you still need answers (if not can we close?)
(1) looks to be ensuring that the resulting child is not greater than the child size, but I'm unsure why the &&
(2) interesting question! I cannot fathom how an empty inner spec could ever be used in practice (this should probably be made more explicit in the code)
(3) I just deobfuscated the code. Along with other things, it ensures the prefix is bounded such that an attacker cannot use it to prove a key which doesn't exist


Fix issue where default menu icon was not found

Under Xcode 7 and iOS 9, in AMSlideOutGlobals.m: + (NSDictionary*)defaultOptions, [UIImage<EMAIL_ADDRESS>was returning nil, so I changed this code to load the iconSlide.png image from a specific bundle, which seems to have fixed the issue for me.
The Sample project is also no currently building under Xcode 7. Any plans to update the project to the latest?

Hi @jlwebster
Yeah, this is spot on, if the library is imported as a dynamic framework the main bundle is out of scope. Thanks for the PR :+1:

Awesome! Thanks for the quick merge @andreamazz.


Broken pptx has generated if used custom slide layout in v3.3.0

Category

[ ] Enhancement
[x] Bug
[ ] Question
[ ] Documentation gap/issue

Version
Please specify what version of the library you are using: v3.3.0
Please specify what version(s) of PowerPoint you are targeting: PowerPoint 16.40, Keynote 10.1
Expected
If used the custom slide layout defined through defineLayout(), the output pptx should show the slide with the correct size defined in layout.
Observed Behavior
A broken pptx will be generated if used the custom slide layout in PptxGenJS v3.3.0.
PowerPoint will be trying to repair it but the result has different layout size. Keynote will show nothing.
Steps to Reproduce
Run this script in Node.js and open pptx.pptx:
const PptxGenJS = require('pptxgenjs')
const pptx = new PptxGenJS()

pptx.defineLayout({ name: 'A3', width: 16.5, height: 11.7 })

// console.dir(pptx.presLayout)
pptx.layout = 'A3'
// console.dir(pptx.presLayout)

pptx.addSlide()
pptx.writeFile('pptx.pptx')

Appendix

This script works correctly with v3.2.1.
v3.3.0 + built-in layout such as LAYOUT_4x3 also will work.
Workaround: Assign width and height to pptx.presLayout manually after assigning layout.

pptx.layout = 'A3'
pptx.presLayout.width = pptx.presLayout._sizeW
pptx.presLayout.height = pptx.presLayout._sizeH

Thanks @yhatt - I thought there was a test case for defineLayout(), but I was mistaken.
Issue was due to lose type definitions not catching recent changes to SlideLayout props in 3.3.0


Bug in keras.layers.DepthwiseConv2D when using stride and dilation

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes (attached)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.13.1
Python version: 3.6.8
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0/7.4.2
GPU model and memory: Nvidia Quadro P2000 with 4GB

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When executing the following lines of code, I get an assertion, because the result is not as expected, but actually the values [-29, -19, 1]. I would see how the -19 would be correct if I had a stride of 1 along the y-axis, however, then it would not match up again with the third number being 1 instead of -4. So it is not only that either dilation or stride is ignored, but actually providing for both non-trivial values results in some strange behavior, which I think is actually a bug.
import numpy as np
import tensorflow as tf

kernel = np.array([5, 5], dtype=np.float32).reshape([1, 2, 1, 1])
bias = np.array([-4], dtype=np.float32)
img = np.array([-2, -1, -3, -2, 3, -1, -2, -1, 2], dtype=np.float32).reshape([1, 1, 9, 1])

strides = (2, 2)
dilation = (1, 2)

depthconv2d_layer = tf.keras.layers.DepthwiseConv2D(
    depth_multiplier=1,
    kernel_size=(1, 2),
    strides=strides,
    dilation_rate=dilation,
    padding='valid',
    depthwise_initializer=lambda *args, **kwargs: tf.constant(kernel),
    bias_initializer=lambda *args, **kwargs: tf.constant(bias),
)
depthconv2d_output = depthconv2d_layer(tf.constant(img))

with tf.Session() as s:
    s.run(tf.global_variables_initializer())
    result = s.run(depthconv2d_output)
    print(result)
    assert np.all(result == np.array([-29, -4, 1, -4]).reshape(1, 1, 4, 1))

Describe the expected behavior
No assertion, as I computed the values by hand and expect them to be right.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Nothing else.

Seems that this is not a valid argument combination, but TF does not try to raise the assertion or print some warning message.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/layers/convolutional.py#L1700-L1705

strides: An integer or tuple/list of 2 integers,
specifying the strides of the convolution along the height and width.
Can be a single integer to specify the same value for
all spatial dimensions.
Specifying any stride value != 1 is incompatible with specifying
any dilation_rate value != 1.

I was aware of this documentation, however this is only noted on the regular convolutions. For the depthwise convolution this documentation (and the raising of an exception) is either missing, or the case is not correctly implemented! I assumed the second case is true, because depthwise convolutions are probably handled differently concerning GPU optimization which might not yield the restriction of being able to specify only one of stride or dilation. Also I find it too coincidental that the docs and the exception is missing.

I was able to reproduce the issue with 1.13.1 and even with tf-nightly. Here is the gist. Thanks!

@DavidS3141 @WindQAQ   Sorry for the delay! The link is outdated: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/layers/convolutional.py#L1700-L1705
Do you have a new link to what it means by "Seems that this is not a valid argument combination, but TF does not try to raise the assertion or print some warning message"?

It is said here:
https://www.tensorflow.org/api_docs/python/tf/keras/layers/Conv2D
under the argument description for dilation rate!

It is said here:
https://www.tensorflow.org/api_docs/python/tf/keras/layers/Conv2D
under the argument description for dilation rate!

The dilation_rate is not an argument for DepthwiseConv2D, right?

Yes that is true, quite a lot changed of course since TF 1.13.1 which I used in August when I opened this issue. Then the argument was still documented for that version and I opened this issue. TF 1.15 API docs has also no mention of this argument. Not sure what happens with these newer versions when passing the dilation_rate as argument to the Depthwise Conv2D

Yes that is true, quite a lot changed of course since TF 1.13.1 which I used in August when I opened this issue. Then the argument was still documented for that version and I opened this issue. TF 1.15 API docs has also no mention of this argument. Not sure what happens with these newer versions when passing the dilation_rate as argument to the Depthwise Conv2D

Yeah it was never part of the API, but it works as intended. I think we should add it to init.
On the other hand, I tried to do this through:
tf.nn.depthwise_conv2d(tf.constant(img), tf.reshape(tf.constant([5., 5.]), (1, 2, 1, 1)), strides=(1, 2, 2, 1), padding='VALID', data_format='NHWC', dilations=(1, 2))

It looks like the result is the same as the keras layer. I think this is probably a low level bug instead of a tf.keras bug then?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


[Feature Request] Support fs health check monitor on Azure Blob Storage / S3

Is your feature request related to a problem? Please describe
Currently I running the opensearch helm chart on kubernetes monitor.fs.health.enabled = true
My node uses azure blob storage as the backend which seems to work fine, but the fs health check seems to fail
[ERROR][o.o.m.f.FsHealthService ] [datalev-opensearch-master-0] health check of [/usr/share/opensearch/data/nodes/0] failed
Describe the solution you'd like
Ideally a health check which works on azure blob storage / Amazon S3 storage.
Related component
Other
Describe alternatives you've considered
Current workaround is setting
monitor.fs.health.enabled = false
Additional context
Error log
2024-11-29 10:15:54.713	[2024-11-29T09:15:54,712][INFO ][o.o.s.s.c.FlintStreamingJobHouseKeeperTask] [opensearch-master-0] Finished housekeeping task for auto refresh streaming jobs.
2024-11-29 10:15:54.712	[2024-11-29T09:15:54,711][INFO ][o.o.s.s.c.FlintStreamingJobHouseKeeperTask] [opensearch-master-0] Starting housekeeping task for auto refresh streaming jobs.
2024-11-29 10:15:53.436	[2024-11-29T09:15:53,436][INFO ][o.o.j.s.JobSweeper       ] [opensearch-master-0] Running full sweep
2024-11-29 10:15:53.336		at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
2024-11-29 10:15:53.336		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) [?:?]
2024-11-29 10:15:53.336		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) [?:?]
2024-11-29 10:15:53.336		at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52) [opensearch-2.18.0.jar:2.18.0]
2024-11-29 10:15:53.336		at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:1005) [opensearch-2.18.0.jar:2.18.0]
2024-11-29 10:15:53.336		at org.opensearch.threadpool.Scheduler$ReschedulingRunnable.doRun(Scheduler.java:246) [opensearch-2.18.0.jar:2.18.0]
2024-11-29 10:15:53.336		at org.opensearch.monitor.fs.FsHealthService$FsHealthMonitor.run(FsHealthService.java:195) [opensearch-2.18.0.jar:2.18.0]
2024-11-29 10:15:53.336		at org.opensearch.monitor.fs.FsHealthService$FsHealthMonitor.monitorFSHealth(FsHealthService.java:228) [opensearch-2.18.0.jar:2.18.0]
2024-11-29 10:15:53.336		at java.base/sun.nio.ch.ChannelOutputStream.close(ChannelOutputStream.java:111) ~[?:?]
2024-11-29 10:15:53.336		at java.base/java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:113) ~[?:?]
2024-11-29 10:15:53.336		at java.base/sun.nio.ch.FileChannelImpl.implCloseChannel(FileChannelImpl.java:210) ~[?:?]
2024-11-29 10:15:53.336		at java.base/jdk.internal.ref.PhantomCleanable.clean(PhantomCleanable.java:133) ~[?:?]
2024-11-29 10:15:53.336		at java.base/jdk.internal.ref.CleanerImpl$PhantomCleanableRef.performCleanup(CleanerImpl.java:178) ~[?:?]
2024-11-29 10:15:53.336		at java.base/sun.nio.ch.FileChannelImpl$Closer.run(FileChannelImpl.java:116) ~[?:?]
2024-11-29 10:15:53.336		at java.base/java.io.FileDescriptor$1.close(FileDescriptor.java:89) ~[?:?]
2024-11-29 10:15:53.336		at java.base/java.io.FileDescriptor.close(FileDescriptor.java:304) ~[?:?]
2024-11-29 10:15:53.336		at java.base/java.io.FileDescriptor.close0(Native Method) ~[?:?]
2024-11-29 10:15:53.336	java.io.IOException: Input/output error
2024-11-29 10:15:53.336	[2024-11-29T09:15:53,335][ERROR][o.o.m.f.FsHealthService  ] [opensearch-master-0] health check of [/usr/share/opensearch/data/nodes/0] failed

Here is what the health check does: https://github.com/opensearch-project/OpenSearch/blob/2.x/server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java#L223-L229
tl;dr: create a file, write a byte, fsync, close file, delete file
This is all pretty straightforward stuff using the Java NIO API. I would expect anything that is acting as a filesystem to need to work for these APIs.
@audunsolemdal It looks like your stack trace is pointing to a failure when attempting to close the OutputStream that was used to write a byte. Any idea why that might fail?

This is all pretty straightforward stuff using the Java NIO API. I would expect anything that is acting as a filesystem to need to work for these APIs.
@audunsolemdal It looks like your stack trace is pointing to a failure when attempting to close the OutputStream that was used to write a byte. Any idea why that might fail?

I am not sure why it fails on that step, but there are some limitations in Azure blob storage compared to a full fledged file system. I am mounting a Kubernetes Persistent Volume via the Azure Blob Storage CSI driver, which is based on Blobfuse2
https://github.com/Azure/azure-storage-fuse?tab=readme-ov-file#un-supported-file-system-operations
So far I have not noticed any issues using this apart from the health check.

I'm not sure if this is actionable for us at the moment. I think we'd need more specific details about the failure you're seeing and how we could accommodate it. It's really odd that these simple operations would fail but he actual usage of the file system by OpenSearch (which surely includes creating, writing, flushing, and deleting files) would succeed. I might suggest writing a super simple Java program that mimics our health check to see if you can isolate the failure in a more controlled environment. @audunsolemdal what do you think?


Sourcemap wrong line number

When working on jsx using the preact template the sourcemap lines does not match the right line in the source file (this probably happens with react files as well). The offset happens on .jsx files (but not on the main.jsx).
Reproduction

npm init vite-app --template preact demo-preact
cd demo-preact
Inject a console.log in app.jsx

import { Logo } from './logo'
import { useState } from 'preact/hooks'

export function App (props) {
  const [demo, setDemo] = useState('Hello world')

  console.log('Hello')

  return (
    <>
      <Logo />
    </>
  )
}

Run vite npx vite
Inspect the code in the browser and watch the line number in the console.

Hypothesis
You inject some code in the file to add HMR and it seems to offset the sourcemaps (I'm still figuring out this repository structure so I don't have the level yet to fix it myself :().
System Info

vite version: 1.0.0-beta.11

It is correct after test it.

This is what I got :( (I tried on linux and MacOS)

Indeed I tried and it works on my linux. It may be my setup (macos)


Environment proxy pilot

For a cluster behind a corporate proxy server, istiod needs internet access to fetch jwt. This PR utilizes the proxy environment variables (say http_proxy) to connect to "issuer" and "jwksUri".
We have edited deployment/istiod using following command:
kubectl set env deployment/istiod http_proxy="http://<IP_ADDRESS>:3128" https_proxy="http://<IP_ADDRESS>:3128" NO_PROXY="<IP_ADDRESS>/20,.svc.cluster.local,istiod.istio-system.svc,istio-ingressgateway,localhost,.istio-system.svc" -n istio-system
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

Hi @vasusheoran. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I am confused: isn't the http_proxy used by default?

@hzxuzhonghu Since a new http.Client is created with a custom http.Transport, values from http.DefaultTransport are not used.

/ok-to-test

@vasusheoran: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2d535a2877aa51237c4c96117085da8a60e8f711
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/release-notes-none

@hzxuzhonghu Since there is no user facing change in this PR, can we add a "release-notes-none" label? Then I can probably run retests.

/retest

@vasusheoran: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2d535a2877aa51237c4c96117085da8a60e8f711
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vasusheoran: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
8c21807d5757812bbc2f91004368bf883891ae18
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu I pushed to this repo using wrong author email. I tried to rebase but bot requires all authors to sign the cla. How should we proceed? Can I create another PR?


[BUG] build_cartesian_3d with reverse axis freezes

Describe the bug
I tried generating https://commons.wikimedia.org/wiki/File:Lorenz_96.svg
from Rust, using plotters. For that I reversed the second axis (based on #240) going from :
.build_cartesian_3d(-10.0..10.0, 15.0..-10.0, -7.5..15.0)
to
.build_cartesian_3d(-10.0..10.0, -10.0..15.0, -7.5..15.0)
It compiled but instead of running less than a second for my plotting function it now starts freezing when reaching:
    chart.configure_axes().draw().unwrap();
I also tried reversing the third or first axis, which resulted in the same issue.
To Reproduce
Reverse any of the three ranges inside of build_cartesian_3d in the 3d example:
https://plotters-rs.github.io/book/basic/draw_3d_plots.html#draw-a-line-series
Version Information
Latest crates.io release. 0.3.1

Closing since it's solved on the master:
https://github.com/38/plotters/issues/255


Remove cookie-based session ID setting

Remove cookie-based session ID setting. PuppetJs should not read ID from cookies, because this leads to problems when page is loaded in many tabs.
Main issue: https://github.com/Starcounter/Starcounter/issues/3798#issuecomment-263259468

Merged PR #111 that implements this.


Provide a way to get the new entry by itself

It would be great if there was a way to just get the body of what would be written to the changelog so it could be included in e.g. a GitHub release without having to manually copy and paste it (and thus automate creating the release).
If scriv collect prints the new entry to stdout then this is a suggestion to mention that in the docs.

I've refactored the code to create an API in #28.  Does it look like it would do what you want?

Yep, looks great!

A quick thanks for the API! When I cut a release now, I am able to:

Gather the release notes thanks to https://github.com/brettcannon/python-launcher/blob/main/release/notes.py
Update the changelog
Create a GitHub release with appropriate release notes


Caching

What about image caching at specific time?

Nice idea, but I think that isnt really needed, because once the image is there, the browser will cache it.

This too could probably be closed out


Device agnostic testing

This PR changes the test suite to allow running the tests on any hardware.
In order to do this I tried to make the test suite device agnostic and allow setting the device and backend through environment variables. This is hopefully a future proof way for allowing the test suite to be run on any hardware.
I've also added the functionality to change timeouts on tests that run on hardware.
In all the changes I've tried to keep previous functionality working if using the CI in the "normal" way. If the environment variables are not used, previous values are used as defaults.
Example usage:
TORCH_DEVICE=fancy_new_hw TORCH_BACKEND=new_torch_backend pytest tests/

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Update carbon database utils version

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2194210546

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2194210546
Status: failure


Minor cleanup pass

See individual commits for details - this is mostly a lightweight editing pass and fixing a couple of test issues.

@RussTheAerialist @shinchris FYI, the test code bit in test/test_workbook.py was actually failing under Python 3.8. For some reason in the request body the name and hidden attributes were swapping in 3.8, causing the test to fail. I switch to using regex there so the test now works in all Python versions.


Rename Abstact to Abstract

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Thank you @paulbalandan


Reason
Sometimes you want to use other commit types in your repository (e.g. run-fix to mark fixes concerning only the current feature run). These should not all be grouped into "Other changes" then.
Result
Commits with unknown types will then be each grouped into Other changes (<commit type>).
Example
New Features

docs:  Add docs (fd616edf)

Other Changes (run-fix)

docs: Fixed typo (658297e9)

@dmlittle & @robinjoseph08 Can you help us getting this change in? We are a bit puzzled on how to write a test here.

I updated the test.

@dmlittle & @robinjoseph08 Do you have time to review this PR?

@dmlittle @robinjoseph08 Would be great if we could get this feature into generate-changelog. :slightly_smiling_face:

Just released v1.8.0! Again, really sorry for the delay!

Hi, have a quick fix for two typos introduced here - https://github.com/lob/generate-changelog/pull/57


Added SimpleLog implementation

This removes our I'll say extremely restrictive custom logging system and instead uses SimpleLog, allowing for a more detailed view of what's going on. Along with this, a log file will be written to when the kernel is executed in the root folder of the application, named obliteration-kernel.log The filename can be changed if wanted, just a quick name for it.

Hopefully now that I used the ProjectDir, you'll use that for your config instead of a hardset Registry key lol.
(Also wow, RustFMT just made it even less consistent in style :<)

I don't agree with using a separated mechanism to get the path to write the log than the one that provided from the main application. This will cause a multiple source of truth which end up more than one locations for the debugging data.
The log formatting also is hard to read because the category and the message is too far from each other. The printing of std::error::Error object is also unclear if it will printing the nested error, which is important for me to identity the root of problem.

I don't agree with using a separated mechanism to get the path to write the log than the one that provided from the main application. This will cause a multiple source of truth which end up more than one locations for the debugging data.
The log formatting also is hard to read because the category and the message is too far from each other. The printing of std::error::Error object is also unclear if it will printing the nested error, which is important for me to identity the root of problem.

It does print the nested error. It's the same as the implementation before, except that it's adopted to fit the type of String that the Log crate wants. Also, for the 1st concern, it's a bit more trustworthy imo to use native Rust instead of Qt C++ for getting the path. Makes it not have to depend on the framework to get the path.

Given the following code:
use log::error;
use simplelog::*;
use thiserror::Error;

fn main() {
    TermLogger::init(
        LevelFilter::Info,
        Config::default(),
        TerminalMode::Mixed,
        ColorChoice::Auto
    );

    let e = FooError::Error1(BarError::Error2);

    error!("Something wrong: {}", e);
}

#[derive(Debug, Error)]
enum FooError {
    #[error("error 1")]
    Error1(#[source] BarError),
}

#[derive(Debug, Error)]
enum BarError {
    #[error("error 2")]
    Error2,
}

Its output is:
06:02:43 [ERROR] Something wrong: error 1

Which show it does not handled the nested error because it does not print both error 1 and error 2.
The main problem here with the path is a multiple source of truth.

@ultimaweapon Fixed. This is simply done by using {:#} instead of {}.

I've also reduced the crowdedness a bit, check it out! :P

Your {:#} is not working:
use log::error;
use simplelog::*;
use thiserror::Error;

fn main() {
    TermLogger::init(
        LevelFilter::Info,
        Config::default(),
        TerminalMode::Mixed,
        ColorChoice::Auto
    );

    let e = FooError::Error1(BarError::Error2);

    error!("Something wrong: {:#}", e);
}

#[derive(Debug, Error)]
enum FooError {
    #[error("error 1")]
    Error1(#[source] BarError),
}

#[derive(Debug, Error)]
enum BarError {
    #[error("error 2")]
    Error2,
}

Output:
05:54:45 [ERROR] Something wrong: error 1

@ultimaweapon Check Element, you get a choice for which one, since I tested and, you were right, but there's two formats I can use for nested errors.

I'll not participate in the real-time chat regarding to the development of Obliteration anymore. Please provide the formats that you mentioned here.

I'll not participate in the real-time chat regarding to the development of Obliteration anymore. Please provide the formats that you mentioned here.

Oh... Sorry... .m. Ahem... So yes, {:#} was wrong, but that's simply because I was missing a symbol.

This is using {:?} ^

And this is using {:#?} ^
Basically, pretty-prints the nest.

Realized the snipping tool failed to save to clipboard on that 2nd pic... Fixed! And still, sorry, Ultima...

Both of them printing the enum identifier, not the message associated with the enum. It should output error 1 and error 2 instead of Error1 and Error2. It seems like this cannot be done with the current version of log crate. So we may need to postpone this until a solution is available.

Both of them printing the enum identifier, not the message associated with the enum. It should output error 1 and error 2 instead of Error1 and Error2. It seems like this cannot be done with the current version of log crate. So we may need to postpone this until a solution is available.

I FIGURED IT OUT! :3
use log::error;
use simplelog::*;
use thiserror::Error;

fn main() {
    TermLogger::init(
        LevelFilter::Info,
        Config::default(),
        TerminalMode::Mixed,
        ColorChoice::Auto
    );

    let e = FooError::Error1(BarError::Error2);

    error!("Something wrong: {}", e);
}

#[derive(Debug, Error)]
enum FooError {
    #[error("Bad stuff {0}")]
    Error1(#[source] BarError),
}

#[derive(Debug, Error)]
enum BarError {
    #[error("And bad things")]
    Error2,
}

Using {0} at the end, we can see the nested error.

That is not a good one because it required to modify the error type, which is a problem if the error coming from the external crates.

But... It is, Ultima. Because the crate would already have it included if needed, and excluded if not needed. The errors are handled by the crate themselves... They implement their log code.

That is not how Rust error handling is working.

That is not a good one because it required to modify the error type, which is a problem if the error coming from the external crates.

Yeah uh, me and the entire Rust discord server have no clue what you mean .w.
{0} would work if you want to print the inner error. not sure what your friend means tbh

If my above example is an external crate you will never be able to print the inner one with your solution.

...Still, everyone disagrees with you.

I don't mean it to be rude, but I'm just saying... Everyone in the Rust server is confused on what you're saying because... It isn't going to be an issue.

Every developer has different experience like I said before. Those developers think it is not an issue but it is an issue for me. They are not working on this project so what is the point of following their advise that I believed it is going to cause some issues for me who are working on this project? Please don't forget this fact.

Well, I guess I just wait then.

Shall I turn this into a draft?
And still, sorry for what happened in Element... Sucks not being able to chat with ya... Oh, plus someone had a question in General!

If you believed you can fix all of the issues soon then leave this PR opened or make it draft otherwise close it and rework when a solution is available will be better so you don't need to keep merging the main branch into this, which is likely to encounter some conflicts that you need to resolve from time to time.
I found out that leaving from the real-time chat is better for me to focus on working so I'll leave our real-time chat to your responsibility or if you don't want to handle this feel free to close it. If you want to keep it maybe switching to Discord should be better. Please create a PR to update the README if you choose to close it or switch to Discord.

Drafted until solution is found for Nested errors.

I don't think we need to use the external logging anymore so I'll close this.


Entities REST API ignores 2nd and subsequent query parameters

Expected Behavior
All query parameters of the entities endpoint should be used when processing requests.
For example, a request like GET /entities?filter=kind=user&fields=metadata.name should process both filter and fields parameters.
Actual Behavior
Only the first query parameter is used.
For example,

GET /entities?filter=kind=user&fields=metadata.name and
GET /entities?fields=metadata.name&filter=kind=user

should be exactly the same, but they are not.
Steps to Reproduce

Fetch the response for curl https://demo.backstage.io/api/catalog/entities?filter=kind=user&fields=metadata.name
Fetch the response for curl https://demo.backstage.io/api/catalog/entities?fields=metadata.name&filter=kind=user
Compare the responses -> they are different

The 1st response contains all the 16 users (correct) but all their fields (incorrect), i.e. the parameter fields=metadata.name is ignored.
The 2nd response contains 66 items (incorrect, more than the 16 users) but each item only has the metadata.name property (correct), i.e. the parameter filter=kind=user is ignored.
The issue also affects requests with more than one filter parameter, e.g. when fetching all components with different tags

Fetch the response for curl https://demo.backstage.io/api/catalog/entities?filter=metadata.tags.java&filter=metadata.tags.go
Compare the response to the list of components on https://demo.backstage.io/catalog?filters[kind]=component&filters[user]=all

The components with tag go are missing from the response.
Your Environment

User agent: curl 7.79.1 (x86_64-apple-darwin21.0)
Backstage version in our environment: 0.69.1

I'm not at the computer to check, but I suspect that this may be your shell that's confusing you. The ampersand character probably has to be escaped, or the entire url quoted. Try
curl 'https://demo.backstage.io/api/catalog/entities?filter=kind=user&fields=metadata.name'
(note the quotes, you can also try double quotes instead of single)

Hi @freben , you're right it was the & character, it works well with the URL between quotes.


Init image no longer a parameter?

Is the init image no longer available as a parameter? Don't see that any more and is there a reason why?

I found that you guys split the API into the original txt2img, img2img and outpainting, and leaving img2img and outpainting with init image parameter.


azure/cli@v2 can't be configured to just use existing / installed az cli?

Describe the bug
I am trying to utilize the somewhat new GitHub-hosted runners with Azure VNET connectivity, with the azure/cli@v2 action.   I'm also using an OIDC federated credential attached to the managed identity to let this github action / branch use my MI.
When the GitHub Action runs, it seems like it always tries to go out to the internet and download the cli?  For security concerns, I'd prefer to not let this "private" runner have access to the internet.  My hope is that when I run an az cli command in the azure/cli@v2 action, it should use whatever version is pre-baked into the action, but I'm having no such luck.  Is this a bug, or a feature request, I am not sure?  Is this possible?
Related command
Here is my github action:
name: Azure CLI on a github public runner with vnet connectivity
on:
  push:
    branches:
      - main

permissions:
  id-token: write
  contents: read

jobs:
  run_az_cli:
    runs-on: my-private-runner
    env:
      client-id: my-managed-identity-guid
      subscription-id: my-subscription-guid
      tenant-id: my-tenant-guid

    steps:
      - name: Checkout repository
        uses: actions/checkout@v4

      - name: Az CLI login # Strangely, this works fine!
        uses: azure/login@v2
        with:
          client-id: my-managed-identity-guid
          subscription-id: my-subscription-guid
          tenant-id: my-tenant-guid

      - name: Run Azure CLI Action simple test - cannot figure out how to make this work
        uses: azure/cli@v2
        with:
          azcliversion: latest
          inlineScript: |
            az version

Errors
Warning: Unable to fetch all az cli versions, please report it as an issue on https://github.com/Azure/CLI/issues. Output: , Error: Error: The process 'curl' failed with exit code 28
Starting script execution via docker image mcr.microsoft.com/azure-cli:latest
Error: Error: Unable to find image 'mcr.microsoft.com/azure-cli:latest' locally
docker: Error response from daemon: Get "https://mcr.microsoft.com/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers).
See 'docker run --help'.

cleaning up container...
Warning: Error response from daemon: No such container: MICROSOFT_AZURE_CLI_17111264[16](https://github.com/my-org/my-repo/actions/runs/1111111111/job/2222222222#step:5:17)162_CONTAINER

Error: Unable to find image 'mcr.microsoft.com/azure-cli:latest' locally
docker: Error response from daemon: Get "https://mcr.microsoft.com/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers).

This is normal error, because I do not allow internet outbound access, and I don't want to either ... if I let this subnet out to the internet, it does work fine... is there a way to avoid having to let this action/runner out to the internet to use the hopefully already installed cli?  Or is there just not an az cli installed, and it has to go fetch one each time?
Issue script & Debug output
See above, --debug provided no more information that was already provided.
Expected behavior
I would expect to be able to pass some sort of parameter to the azure/cli@v2 to just use the azcliversion that is already installed in the action, so it doesn't try to connect to the internet to get another version?
Environment Summary
Can't even run az --version, but it's likely whatever is installed in the azure/cli@v2 currently, if I could get to it?
Additional context
No response

Thank you for opening this issue, we will look into it.

Hi @johnpetersjr, if the docker image mcr.microsoft.com/azure-cli:${azcliversion} is already pulled on your private runner, then azure/cli action will not download it again from the Internet. You can pre-installed the azure-cli image from mcr.

Hi @johnpetersjr, if the docker image mcr.microsoft.com/azure-cli:${azcliversion} is already pulled on your private runner, then azure/cli action will not download it again from the Internet. You can pre-installed the azure-cli image from mcr.

Understood, but it's not really my private runner, it's a GitHub public runner with private network connectivity.  Is there a preemptive action I can execute to have that available on a public runner?

@johnpetersjr, is it possible for you to access Azure Container registry with your private network? One approach could be to push the azure-cli image to ACR from a computer with outbound Internet access, and then pull it from ACR on the runner with private network connectivity.
However, this process is complex. Maybe you could simplify by adding mcr.microsoft.com to the allowed list for your vnet? Images from MCR are official Microsoft images which are considered secure.

The approach was to use the azure-cli image and run az cli commands, without having to do any extra steps.  Our expectation is the github action image we use is complete, and doesn't need to go download updates/patches from the internet.  A blessed, secure, patched, ready to use image.
We were able to work around this by using a simple run: command on the native github runner's image that magically had az cli on it somehow.
For reference - some customers run GitHub actions on private runners that have no internet access as a security guardrail.  It would be awesome if the image being used just had everything pre-installed with no need to go out to the internet for additional updates.

Thank you for posting your work around!
I just went through Hell because I couldn't even get azure/login@v2 to work. Used the instructions at:
https://docs.github.com/en/organizations/managing-organization-settings/configuring-private-networking-for-github-hosted-runners-in-your-organization
Finally figured out I had to add three additional NSG rules so it could reach login.microsoftonline.com.
But I had a simple step:
        - name: Azure CLI script
          uses: azure/cli@v2
          with:
            azcliversion: latest
            inlineScript: |
              az account show

And got the same error you reported. Was irritating, to say the least.
arning: Unable to fetch all az cli versions, please report it as an issue on https://github.com/Azure/CLI/issues. Output: , Error: Error: The process 'curl' failed with exit code 28
Starting script execution via docker image mcr.microsoft.com/azure-cli:latest
Error: Error: Unable to find image 'mcr.microsoft.com/azure-cli:latest' locally
docker: Error response from daemon: Get "https://mcr.microsoft.com/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers).

So followed what you said and changed it to just:
- name: Azure CLI script
          run: |
            az account show

and it worked.


Calling the x-option component from a variable

I want to enhance the template so I can pass in my own component name. This others to inherit from x-option and then specify the component they would like to use.

Possible to get this merged in?

Yeah! Sorry for the slow response. Could you add documentation to the readme about this? And a test would also be awesome :D

This is pretty interesting. I'm curious what the use-case is for needing to do this?

I needed to extend the select option to provide some extra functionality. By using a name dynamically I can do this
{{#x-select
    class="ui dropdown"
    value=value
    on-change=(action "update")
    optionComponentName="custom-xselect" as |xs|}}
  <option selected="selected" disabled="disabled">Select a Product</option>
  {{#each mappings_sorted as |content|}}
    {{xs.option
        value=content
        product_mapping=content
        order_selection=order_selection}}
  {{/each}}
{{/x-select}}

Then I can encapsulate all my changes on my own component that extends from x-option

I needed to extend the select option to provide some extra functionality

Exactly. I'm curious what the extra functionality is that requires this approach. What are you trying to accomplish with your x-option subclass? If you could expand on it a bit, then we can maybe mull over the various options and make sure that either with this solution, or some other, you get that use-case taken care of.

The main use case was for the disabled attribute. It was 12 lines and depended on multiple properties and conditions based on the other dropdowns selected values.
I probably could have gone the helper route, but I'd rather include the logic on the the component.

What I would do in this case would be to use a container component to clearly define the selection model, and then control the x-select explicitly.
{{#selection-model mappings=mappings_sorted as |mappings|}}
  {{x-select value=value on-change=(action mappings.update) as |select|}}
    {{#each mappings as |mapping|}}
      {{select.option value=mapping.value disabled=mapping.disabled}}
        {{mapping.name}}
      {{/select.option}}
    {{/each}}
  {{/x-select}}
{{/selection-model}}

The problem is it doesn't just depend on the mapping, it depends on the combination of
mapping, order selection, and current value. All of which can't come from a single property since they are separated.
I could used a helper but that pulls the logic out of the component. Its also not as performance friendly since I would need to observe properties.
disabled=(should-disable mapping order_selection value)

The problem is it doesn't just depend on the mapping, it depends on the combination of
mapping, order selection, and current value.

That's why you have the mappings model that computes all that for you. The suggestion isn't that it is a simple list of mappings, it is an enriched collection that contains all the properties you need, separated out into its own component.
In effect, it is the component you're seeking to write, but without its implementation co-mingled with x-select and x-option.

Yes I could go that route, but I'd prefer to have the logic encapsulated on the x-option component I plan to reuse in several places. I'm only providing a small glimpse of one of the use cases. I also have several default attributes I want on each x-option. Rather than add those same exact attributes each time I want them in the templates, I can put them on one extended x-option and re-use that everywhere. It doesn't make sense to repeat myself each time i want the same thing, when one x-option can have everything for reusability.
I understand that you're trying to provide an alternative, but I don't see why it matters if I choose to encapsulate logic in an extended component or through an alternative like mappings. Having the component name being a variable doesn't change anything on the main x-select other than allowing others to choose either direction. They can either do it in mappings as you provided or extend x-option to keep their app DRY.

I'm only providing a small glimpse of one of the use cases.

I believe you, and I believe that you have, in this PR, a working solution that accounts for those use-cases. But our job is to make sure that we fully understand a new pattern before baking it into the library because to do so means we're giving it tacit approval as a recommended way to solve problems. This is a pretty big change, and we can't do that job with just a glimpse.
It would really help to see the actual use cases, and why it can't be solved via any other means.

I'm not trying to be stubborn, but i don't know why more examples makes a difference. The api stays the exact same for everyone using it today, but allows an extension point for customization as shown in this ember conference video http://confreaks.tv/videos/emberconf2017-higher-order-components
It shouldn't matter if I choose to implement x-option like using specifically setting each attribute
x.option value=x disabled=y test=z classNames="red"

or
x-select componentName="custom"
  x.option value=x

I don't want anything different on the base component as exists today, I just want the flexibly to extend it without having to do a pull request in the future for custom functionality.

I was waiting to update the documentation and create a test before I received the final word on merging this in. Do you want me to do that or are you still deciding to merge in?

I'd say I'm still undecided on whether to merge this, and I feel like I don't have enough information to make the decision. I'm not philosophically opposed to it, but I still don't fully understand the ergonomics of extending components, which requires a change, vs composing them, which doesn't

Closing due to lack of context.


Targeting specific docker version for vendoring (SMA)

#777
Also changed OperationsType value in res/configuration.toml to "os" to accommodate natively running services.
Signed-off-by: Trevor Conn<EMAIL_ADDRESS>

Closing for now. Applied these changes on top of #763 and they don't work. Specifically, services don't stop even though they're reported as having done so. Will need to re-investigate once the #763 changes are brought into master. Hopefully there's an indication in this PR of how we can approach streamlining the references.


Case sensitive database with adhoc filter

Describe the bug
When specifying database using variable clickhouse_adhoc_query the request to clickhouse is in uppercase when the variable value is in lower case.
Versions
Grafana version 8.4.4
Plugin version 1.1.2
Query
This generate the following query:
SELECT name , type , table FROM system.columns WHERE database IN ('SAMPLE') AND table = 'cts'
To Reproduce
Steps to reproduce the behavior:

Go to 'dashboard'
Click on 'settings'
Add a new adhocfilter
Add a new constant variable clickhouse_adhoc_query with the value database.table
See the query generated by the adhoc filter is DATABASE

Expected behavior
The Adhoc filter should use the case from the value.
So for a value of database.table the query should be:
SELECT name , type , table FROM system.columns WHERE database IN ('database') AND table = 'table'
Screenshots

After playing a bit more whenever I use any filter  in the dashboard (a query or an adhoc filter) it switches every chart  into upper case for the table.

@dsztykman I am not sure what is being switched to uppercase. Is SQL sent to the server switched to uppercase? If so, will you provide before and after examples? 😃
We are switching keywords to uppercase, but values and variables should not be affected.

https://user-images.githubusercontent.com/33227713/160681963-ed879cfd-535f-4d3b-bedb-4108b14f72fa.mov
@bossinc here's the demo of the issue, basically after adding an adhoc filter the query switch from:
SELECT toStartOfInterval(toDateTime(timestamp), INTERVAL 30 second) as time,  count(*) FROM sample.cts WHERE timestamp >= '1648535440' AND timestamp <= '1648578640' GROUP BY time ORDER BY time ASC
To
SELECT toStartOfInterval(toDateTime(timestamp), INTERVAL 30 second) as time,  count(*) FROM SAMPLE .cts WHERE timestamp >= '1648535440' AND timestamp <= '1648578640' GROUP BY time ORDER BY time ASC

The same happens when I add a "simple" filter it's not specific to adhoc

As a hypothesis, this could be triggered because sample is a keyword https://clickhouse.com/docs/en/sql-reference/statements/select/sample/ and the plug-in couldn't understand that it's used in the context where a database name is expected.

@dsztykman thank you! I believe @blinkov is correct. I am working on a fix.

requires #131


Create XHTML output from eXist-db

Your to-do
Create XHTML output from eXist-db with XML declaration, doctype declaration, namespace, and media-type
Issues you may encounter

XHTML output
Mime type
XML declaration
Doctype declaration

Additional context

The following serialization strategy, combined with declaring the HTML namespace on the root  element, meets all of our requirements:
declare namespace output = "http://www.w3.org/2010/xslt-xquery-serialization";
declare option output:method "xhtml";
declare option output:media-type "application/xhtml+xml";
declare option output:omit-xml-declaration "no";
declare option output:html-version "5.0";

Note that the method must be xhtml, and not html. With html empty elements are created as unmatched start-tags (e.g.,
), instead of self-closing empty tags (e.g.,
). Specifying a method of xhtml ensures XML-compliant representation of empty elements.


Provide select users with access to production prior to launch [NO POINTS]

Overview
Select brands need to have access to production prior to launch in order to upload their facility lists
Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
@nataliegrillon and @katieashaw will provide a list of brands/user names that need to have access to production prior to launch in order to upload facility lists.
Additional Context

We certainly will - thanks @dboyer ! 😄

I added the operations label. To accomplish this I think we need to create a DNS entry that resolves to the production deployment that we can distribute to our select users before the full launch on the 28th. This needs to be in place on March 25th.


Addition request

I would like to have the ability to highlight specific lines of code and have it save when I close the file. I build a lot of templates that use for multiple clients. The templates have a lot of places that require a change and it's easy to miss one. If I could highlight each block of code it would save me loads of time as I move through each project. Multiple colors would be nice, but one color would be appreciated.

There's an extension called brackets-bookmarks that might fit your needs: https://github.com/toshsharma/brackets-bookmarks

Bookmarks aren't exactly what I need because I still have to hunt for the
places to change within the marked line; but, if it's all there is, then it
will have to do.
Thanks.
On Thu, Jul 13, 2017 at 11:04 AM, Pete Nykänen<EMAIL_ADDRESS>wrote:

There's an extension called brackets-bookmarks that might fit your needs:
https://github.com/toshsharma/brackets-bookmarks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adobe/brackets/issues/13557#issuecomment-315105726,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANsMcvuV-B85zRTu83ty-5LGjiNgx6_Hks5sNjIZgaJpZM4OWDap
.

--
Tim Quinn
Owner/CEO
Total Realty Solutions, LLC
614-407-TRS7 (8877)
<EMAIL_ADDRESS>www.YourTotalRealtySolution.com http://www.yourtotalrealtysolution.com/

I tried bookmarks in a real situation and they do not work for my need. Bookmarking 1 line doesn't help. I'm working with files that span 5 to 12 lines with several places in each line that needs to be changed. For example, in the attached image, the style for color appears several times; in other lines, there are street addresses; in others, there are email addresses; each of these items need to be changed in every file and for each client. Even with a bookmark on the line, I still have to go through every line of code to find each location. I cannot miss one because my clients expect accuracy. Having the ability to highlight these lines in different colors means I can quickly scan through the code and paste the appropriate text in each place without having to spend an excessive amount of time searching for and verifying each location.


Fixes to hlr not existing

Codecov Report

Merging #123 into master will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   95.64%   95.65%   +0.01%
==========================================
  Files          11       11
  Lines        1561     1566       +5
  Branches      179      181       +2
==========================================
+ Hits         1493     1498       +5
  Misses         39       39
  Partials       29       29

Impacted Files
Coverage Δ

morpheus/app/worker.py
93.71% <77.77%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfab49...fd7ea69. Read the comment docs.

lgtm


Why didn't I generate complete chinese.x.txt

Hello, I used your trained yolo model and found  a missing chinese.names  file，then I download ctw-trainval-01-of-26.tar，used prepare_train_data.py to generate chinese.names.
I ran prepare_test_data.py with all provided test data,got these
root@0a0fe4b86df1:~/shared/ctw-baseline/detection/products# ls
backup           chinese.2.data  chinese.8.data         test         test.3.txt  test.9.txt
cates.json       chinese.3.data  chinese.9.data         test.0.txt   test.4.txt  test.txt
chinese.0.data   chinese.4.data  chinese.data           test.1.txt   test.5.txt  trainval
chinese.1.data   chinese.5.data  chinese.names          test.10.txt  test.6.txt  trainval.txt
chinese.10.data  chinese.6.data  darknet19_448.conv.23  test.11.txt  test.7.txt  yolo-chinese-test.cfg
chinese.11.data  chinese.7.data  results                test.2.txt   test.8.txt  yolo-chinese.cfg

Then about more than a dozen hours after I ran eval.py,I got these txt in /detection/products/result/
root@0a0fe4b86df1:~/shared/ctw-baseline/detection/products/results# ls
chinese.10.txt  chinese.11.txt  chinese.3.txt  chinese.4.txt  chinese.6.txt  chinese.7.txt  chinese.8.txt  chinese.9.txt

,it  didn't generate complete chinese.x.txt,I wanna know why

It seems like out of GPU memory, died threads output nothing.
per GPU memory = 3.8 GB * num_thread (Line 74, eval.py) / TEST_NUM_GPU (line 30, settings.py)
Please modify these two variables.
You don't have to rerun all tests, just replace range(settings.TEST_SPLIT_NUM) (Line 74, eval.py) with you missing outputs [0, 1, 2, 5].

Thanks, I will try it immediately


empty params print

What is the purpose of the change
empty params print
Related issues/PRs
Related issues: #590
Related pr: https://github.com/apache/linkis/pull/4431

Please handle the compilation failure.

Please handle the compilation failure.

done


Accessable licence

If there is a licence attached to the project as a whole I was not able to find it. It would be nice to know before starting to use it.

As per https://code.google.com/p/svg-android/, Apache License 2.0. It's been included in the source.


Switched lax.linalg.eigh return order

eigh_p implementations return (vectors, values). This is propagated into lax.linalg.eigh, which is inconsistent both with it's documentation and jax.[numpy,scipy].linalg.eigh return order.
This PR reverses the order of the returned arguments in jax.linalg.eigh, making it consistent with numpy/scipy variants and existing documentation, though not eigh_p implementations.
This is a breaking change. A non-breaking version of this PR could just fix the documentation and be non-breaking. It won't break code using jax.[numpy,scipy] variants.
The inconsistency still exists between eigh_p implementations and lax.linalg.eigh, but I'm afraid I don't know enough about xla internals (e.g. eigh_translation_rule and xops.Eigh) to fix that.

In general making breaking changes where we don't need to isn't wise, but I don't think this one is a big deal and I agree it improves consistency. Can you add a sentence to the release notes (docs/CHANGELOG.rst) mentioning the breaking change?
Note if you want you can freely change the argument order to the eigh_p primitive in most of the rules, and perhaps that's a good idea: the translation rules are then the things that would need to swap the arguments. Perhaps that's better?
You'll also need to squash your commits.

In general making breaking changes where we don't need to isn't wise, but I don't think this one is a big deal and I agree it improves consistency. Can you add a sentence to the release notes (docs/CHANGELOG.rst) mentioning the breaking change?
Note if you want you can freely change the argument order to the eigh_p primitive in most of the rules, and perhaps that's a good idea: the translation rules are then the things that would need to swap the arguments. Perhaps that's better?
You'll also need to squash your commits.

@hawkinsp I agree changing primitive order would be cleaner (arguably we could go further and change the output order of lapack.pyx functions and CUDA implementations, but that's a lot more effort than I'm willing ot go do). Can you confirm I can leave xops.Eigh alone? I have no idea where that's defined and it doesn't seem to get triggered in any of the code for me to check...

@hawkinsp I agree changing primitive order would be cleaner (arguably we could go further and change the output order of lapack.pyx functions and CUDA implementations, but that's a lot more effort than I'm willing ot go do). Can you confirm I can leave xops.Eigh alone? I have no idea where that's defined and it doesn't seem to get triggered in any of the code for me to check...

Sorry this PR dropped off my radar for a while. Would you mind syncing on top of head?

@hawkinsp how's that?


Fix setTrait Return Type

The setTrait method returns a promise but the interface makes it look like a synchronous operation. This could lead to race conditions if the call is not awaited before a getValue with a userId is executed.

Awesome thanks @beeme1mr !

Brill, this is fixed in v2 (coming soon) but I'll definitely get this in v1

Published in 1.1.2


Rhmap 11065 handle mongo restarts

Motivation
Events were not being correctly emitted when there was an error with the connection to Mongo. Also, because some components dependent on fh-db need to listen for the close event, which was not being emitted, this was added

SonarQube analysis reported 2 issues:

 1 blocker
 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Reformat the code to have only one statement per line.

Pull Request Quality Guidelines
As we continue to focus on quality, here are a few things to keep in mind:

The code changes conform to the contributing & code style guides for this component (if they exist)
A component owner should review your change (we've tagged these above)
Automated testing has been added or updated for this change (e.g. UART, Unit/Acceptance tests)
If updating server component this PR should be deployed to a grid somewhere (via fhcap-cli) - please provide a link to this
Ensure JIRA is up to date before & after merge (e.g. deployment notes, tester notes, release notes, fix version)
Any SonarQube issues should be addressed where applicable (use your own judgement)

Please ping a component owner (see fh contrib) when your builds are complete, changes are deployed and you're ready for a review.
Fhcap PR will be generated automatically.
To deploy your changes to a cluster place comment in this PR with pattern [x][y] where x=deploy and y=clustername you wish to deploy.
You can also deploy your change manually using fhcap-cli

SonarQube analysis reported 2 issues:

 1 blocker
 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Reformat the code to have only one statement per line.

SonarQube analysis reported 1 issue:

 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Reformat the code to have only one statement per line.

:+1: Reviewed.

SonarQube analysis reported 1 issue:

 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Reformat the code to have only one statement per line.

SonarQube analysis reported 1 issue:

 1 minor

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Reformat the code to have only one statement per line.

:+1: Nice, safer approach

@philbrookes Yep, I have tested and the events are still emitted from the parent connection so no point in risking any uncaught breaking changes. Going to merge and publish. Thanks


Create wallet example code in README gives "missing field id" error

Meant to add this to the js-sdk issue list. Sorry.


Labels support

Adds support for adding labels to images at build time via LABEL_* or LABELS_FILE params.
Fixes: https://github.com/vito/oci-build-task/issues/41

@vito I have rebased it. I hope you had a good vacation. Thanks for reviewing!

@vito I have rebased it. I hope you had a good vacation. Thanks for reviewing!


YAML if conditions don't expand variables

I have the following parameter in a yaml build and it's set to 'yes' in VSTS variables tab.
parameters:
  buildDebugPackage: '$(BuildDebugPackage)'

I would like to do the following
- ${{ if eq(parameters.buildDebugPackage, 'yes') }}:
  - ${{ parameters.preBuildDebugProjects }}
  - task: DotNetCoreCLI@2
    displayName: Build Debug Projects
    inputs:
      projects: ${{ parameters.projects }}
      arguments: '--no-restore -c Debug /p:Version=$(ASSEMBLY_VERSION);FileVersion=$(FILE_VERSION)'
  - ${{ parameters.postBuildDebugProjects }}

But this does not work because the variable BuildDebugPackage is not expanded to the value 'yes'.
I have to instead do the following
- powershell: |
    Write-Host "##vso[task.setvariable variable=BuildDebugPackage]$($env:BuildDebugPackage)"
  displayName: Setup Environment Variables
  env:
    BuildDebugPackage: ${{ parameters.buildDebugPackage }}
  ignoreLASTEXITCODE: false
  errorActionPreference: Stop
  failOnStderr: true

- ${{ parameters.preBuildDebugProjects }}
- task: DotNetCoreCLI@2
  displayName: Build Debug Projects
  condition: and(succeeded(), eq(variables[BuildDebugPackage], 'yes'))
  inputs:
    projects: ${{ parameters.projects }}
    arguments: '--no-restore -c Debug /p:Version=$(ASSEMBLY_VERSION);FileVersion=$(FILE_VERSION)'
- ${{ parameters.postBuildDebugProjects }}

This is far inferior as I cannot even condition the pre and post steps.  This also shows up on the UI as a skipped step instead of not showing up at all.  I also have to convert the parameter to a variable in PowerShell as well.  Please fix this bug or give a workaround.  Thanks.

@vtbassmatt fyi - this is basically the process parameters for yaml feature on our backlog.

We have created a new repository for all YAML related issues, please move the current issue to there.
https://github.com/Microsoft/azure-pipelines-yaml

@vtbassmatt fyi - here is a request for process parameters


add cd.yaml

#19
This PR adds a workflow (Continuous delivery) to publish crates to crates.io.
Spec
Trigger
Continuous delivery workflow is triggered by pushing tags to the remote repository.
Tag must be of the form vX.Y.Z or vX.Y.Z-SUFFIX.
A tag with suffix means pre-release version and it enables --dry-run mode.
Secrets
Please set CARGO_REGISTRY_TOKEN for the authentication token for crates.io.
Jobs

test

This job runs several tests defined in ci.yaml.

publish

This job publishes crates (apalis-core, apalis-cron, apalis-redis, apalis-sql, and apalis) in an appropriate order.
If there are some inconsistencies between the tag version and a package version (written in Cargo.toml), the job fails before pushing the crates.

Test
I have created v0.3.4-rc10 tag and confirmed that the workflow succeeds.
https://github.com/autotaker/apalis/actions/runs/3355470587
Other changes

Trigger of ci.yaml is changed

CI for topic branch runs only after creating a pull request. (push trigger is limited to master/develop)
Add workflow_call trigger to call CI workflow from CD workflow.

Looks good to me.
I will merge and do a release over the weekend.


⭐ 27 - Content Summary Tool (Hacktoberfest Demo) - Summarify

What does this PR do?
Summarify is a content summary tool which leverages the Hooks provided by CopilotKit to enable users summerize their contents in varied tones.
It also leverages copilotActions to generate a UI based on LLMs response.
Live Demo
Screenshots

Summarify:

Suggestions

Related PRs and Issues
Checklist

[x] I have read read the Contribution Guide
[x] If the PR changes or adds functionality, I have updated the relevant documentation

Nice job @jainanuj94!

@quest-bot loot #639


Enddat 136

Added the ability to click on a location on the map, create a marker, and save the location to a model.
As part of this ticket, I also updated the NavView extensively to start implementing the navigation. I added routes for the choose data step (although I have only tested the first). Note that the url is updated as the workflow state changes but this does not render the entire page.
I also added loglevel to provide javascript logging.

@mamcderm-usgs , this pull request is not yet ready for review, but I thought you might want to see how I've implemented the WorkflowStateModel and how I'm using that information. If it's helpful to have the changes I have made to add the WorkflowStateModel, then we can go ahead and merge. The tests are passing.

Going to go ahead and merge this. When I make the final pull request for this ticket, I will try to point out where changes were made.


Semi-colon at end of fossil name lists

E-mailed spreadsheet of lists of fossil names, either in Significant or Non-significant columns, that included a semi-colon at the end of the list.
There are some in the list with a comma at the end if this is also problematic

I believe this was resolved in some of the other cardinality issues (#800, #859, #860)


Preset-based Image Rendition

What I'm trying to achieve
The way I understand it, currently, image versions are being generated based on the spec/size part of the versatile image field's settings with some approximation. The API provides the images in square dimensions since it takes only integer values.
Describe a proposed solution
I propose introducing a preset parameter to facilitate fetching renditions based on a preset's name. Checks will be minimal, it will only search in existing presets. Once the preset was found it will give back the rendition.
 You can use any sizer or filter you wish. Can generate multiple renditions of an image for different purposes. One example is (currently impossible) to create an image sized for mobile and a webp version of it so that the non-webp version can be used as a fallback.
Btw, I can send PR if you want it to be implemented.

Hello @uroybd 🖖
Thanks for your request 🙏.
Are you familiar with our "Thumbnails" feature? It does not map 1-to-1 with what you described but it is close in some regard. We plan on expanding it in the near future, too.

Hello @uroybd vulcan_salute
Thanks for your request.
Are you familiar with our "Thumbnails" feature? It does not map 1-to-1 with what you described but it is close in some regard. We plan on expanding it in the near future, too.

I'm familiar with the thumbnail feature. However, the current thumbnail feature is pretty limited. At least compared to image rendition provided by other content management systems (e.g. Wagtail).


Add with_capacity

Hello!
First and foremost, thank you for this very nice crate!
Do you think it would be feasible to add a with_capacity to the arena allocator, and ultimatly to the SgMap and SgSet implementation to pre-allocate nodes at run-time ?
This would be useful for cases where we know how much inserting will be done in the near future but don't want to pay the cost of frequent allocations (and/or re-allocations).

Hey, glad you like it! Good question, setting capacity at runtime would be a convenient feature. The answer is a little complicated, so bear with me on a long-ish explanation :neckbeard:
This library is #![no_std] compatible, it’s geared toward embedded systems that don’t have heap memory (but works on any system). So the line let mut set: SgSet<i32, 1000> = SgSet::new(); actually pre-allocates space for 1,000 i32s (and internal metadata) on the stack, at compile-time. The "arena" in this crate is an abstraction over [T; N], via tinyvec.

Good news: the current pre-allocation strategy is cheap - there’s no runtime call to a heap memory allocator and there’s no cost for move/re-allocation. That should support most cases where you know how much inserting will be done in the near future.

Bad news: without the presence of heap/dynamic memory, creating or resizing the arena at runtime is tricky. And the parameter to with_capacity(capacity: usize) is only known at runtime.

The only crate I’m aware of (there may be others) that supports runtime capacity while still being #![no_std] is fixed_slice_vec. The trick it uses, instead of supporting fn with_capacity(capacity: usize), is supporting unsafe fn from_bytes(bytes: &'a mut [u8]). You provide a mutable byte slice of whatever size you have at runtime, and the crate uses it as it’s version of an arena.

So it’s kind of like runtime pre-allocation, but less ergonomic than the usual with_capacity.
Internally, that requires the unsafe transmutation function align_to_mut. And a driving goal of this library is to avoid unsafe entirely!

All that said, runtime capacity could be a valuable feature. Not so much for performance/preallocation, but definitely for flexibility. Thank you for the suggestion!
I’ll keep this issue open, pending on the state of safe transmutation in Rust: there seems to be working group established in RFC 2835.

Hello!
Thank you for the long-ish answer, it's really appreciated.
I get that this library is geared toward embedded system. Although I think it might have applications elsewhere.
Because you use tinyvec as a dependency, I was wondering if it would be possible to add a feature flag that uses a TinyVec rather than an ArrayVec (the complexity could be hidden behind a type alias in the code).
This would still mean this library is #![no_std] but would also benefits to others like myself, looking to use this very fancy crate in more "dynamic contexts" :)

Ah, gotcha. A alloc feature flag that uses TinyVec to support to support heap use would be awesome. I'd love to make this crate viable for more users!
The blocker is I don't know how to support the current fallible APIs (like try_insert) once the heap is involved. We can't remove them because cargo's resolver requires features to be additive. But TinyVec (and Rust collections in general, see RFC 2116) don't have a way to report when the system's heap capacity is full (meaning, perhaps, a call to libc's malloc function returns null pointer, somewhere internally). Ideally this library could return a HeapCapacityExceeded error for such cases.
So it is indeed another issue altogether. But open to any suggestions!

Thinking back to your idea about type-aliasing: what about aliasing tinyvec::ArrayVec to fallible_collections::vec::FallibleVec behind a feature flag?

Provides value to ecosystem b/c the fallible_collections crate doesn't yet have a stable ordered map/set implementation (as of the time of this writing, v0.4.4).

Additional dependency is behind a feature flag (alloc? std?) so current embedded users of this crate don't experience any supply chain impact.

I think (not certain, needs test) this would maintain API semantics without modifying much code outside of src/tree/arena.rs. That means the alias could be local to a module?

I'm just now seeing the fallible_collections crate, so not certain it'll work for this usecase, just brainstorming.

If this sounds good, or there's a preferable alternative, would like to take ownership of an implementation/PR?

Hi!
Wow there is loads to say!

The blocker is I don't know how to support the current fallible APIs [...]

To support those, we could indeed use the fallible_collections::vec::FallibleVec trait.
That woulnd't require any aliasing on tinyvec::ArrayVec IMO.
The tinyvec::TinyVec enum is either Inline which uses a tinyvec::ArrayVec or Heap which uses a Vec<T>.
The tinyvec::ArrayVec already has support for try_insert().
Because the trait
(FallibleVec) is implemented on all Vec<T>, we would get the try_insert() implementation also for the Heap variant.
Although, that would mean setting the MSRV would be at least 1.57.0 to support the newly added try_reserve() in the Vec<T> implementation.

Thinking back to your idea about type-aliasing: what about aliasing tinyvec::ArrayVec to fallible_collections::vec::FallibleVec behind a feature flag?

My idea was to have an alias like:
// Bear with me for the not very original naming ;)
#[cfg(not(feature = "heap_collections"))]
type ScapegoatVec<A> = tinyvec::ArrayVec<A>;

#[cfg(feature = "heap_collections")]
type ScapegoatVec<A> = tinyvec::TinyVec<A>;

Additional dependency is behind a feature flag (alloc? std?)

I would maybe create a new heap_collections feature for that use case. I feel like alloc or std could have more fine grained features added to them later on.
In that case, the heap_collections feature would probably require alloc, std, and the fallible_collections crate.

[...] would you like to take ownership of an implementation/PR?

I would, but I'm afraid it might not be right this instant as I'm quite occupied. If you want to go ahead on an implementation that'd be great, otherwise I'll come back to that later on.

Derp, FallibleVec is indeed a trait and not a type. You're right - no aliasing necessary. I understand your original idea now.
You may already know this but worth explicitly pointing out: ArrayVec's try_insert doesn't consider current heap capacity (just fixed stack space, much like we do currently), but the FallibleVec trait's try_insert does (which we need for heap support). And, like you said, it'll become available on the Vec within the  Heap variant of the enum.
Luckily, since use of FallibleVec/try_reserve() would be feature-gated, it won't increase crate MSRV. Just like we use the tinyvec crate's rustc_1_55 feature for const generics here, even though the crate itself has a 1.34 MSRV.
Thanks for working through all this with me and taking the time for a detailed response. I think I understand both the requirements and a path to implementation now. Should have time to work on it later this week, so will assign to myself and keep you posted on progress! :+1:

So unfortunate update: after starting implementation and running into unanticipated roadblocks I think it's better to not add heap support due to fallibility complications. Even though it'd open up more dynamic usescases. :cry:
A good example of the problem is the internal function get_subtree_size (which may be called after the user calls insert):
fn get_subtree_size<U: SmallUnsigned + Default>(&self, idx: usize) -> usize {
        let mut subtree_worklist = array_vec![[U; N] => U::checked_from(idx)];
        let mut subtree_size = 0;

        while let Some(idx) = subtree_worklist.pop() {
            let node = &self.arena[idx.usize()];
            subtree_size += 1;

            if let Some(left_idx) = node.left_idx() {
                subtree_worklist.push(U::checked_from(left_idx));
            }

            if let Some(right_idx) = node.right_idx() {
                subtree_worklist.push(U::checked_from(right_idx));
            }
        }

        subtree_size
    }

Ignore the U generic, that just abstracts a u16 here. The problem is subtree_worklist. Currently we can assume subtree_worklist.push will always succeed. That's true because the arena can't store more than N items - same as subtree_worklist's length. The only "allocation" this function does is temporarily storing N unsigned integers on the stack. That stack usage is fixed, it'd decided at compile-time.
Now if we support the heap, N is no longer a constant, it could be some arbitrarily large number (len of TinyVec::Heap(Vec<A::Item>)). So push might fail at any given loop iteration, since subtree_worklist is growing dynamically after each push. Thus we need to use fallible_collectsion's try_push to maintain the current fallibility semantics of this library's public API.
Going down that path would mean changing a lot of internal signatures to return Result, and probably using a lot of cfg to keep things working without fallible_collections for the current embedded use case (default build, no features enabled). It's possible, but adds more complexity than I'd like to maintain.
As an alternative solution, tried "pulling up" buffers like subtree_worklist into the struct &self refers to. The idea being only a single, central location in the code handles fallible actions (using try_with_capacity or similar) and all other functions borrow "scratch" buffers by reference as needed. But that created a worse problem - functions passing arguments/results via implicit struct state.
So, based on this experimentation, opting to close this issue for now. It'd be too major of a change, and the standard library currently covers dynamic usecases. But always happy to discuss further or eventually circle back, learning as I go!


Error creating the VM docker host.

I'm facing issues when I want to run the setup and create the docker host VM. I get this message:
"C:\Program Files\Docker Toolbox\kitematic\resources\resources\docker-machine.exe -D create -d virtualbox --virtualbox-memory 2048 default returned non zero exit code. Stderr: Converting from raw image file="stdin" to file="C:\Users<redacted>\disk.vmdk"... Creating dynamic image with size<PHONE_NUMBER>0 bytes (20000MB)... Error creating machine: exit status 1 You will want to check the provider to make sure the machine and associated resources were properly removed."

I don't know what to try. I try to delete the VM and start again but same problem appears.
Any help?

@alexandrev There are couple of factors in Windows that could be causing this - Check the Wiki under the Windows section for possible fixes

Hi @FrenchBen, thanks for your fast anwser but I only find this section about known issues https://kitematic.com/docs/known-issues/ but nothing related to my problem. Could you be more specific? Thanks in advance

@alexandrev the 'Wiki' word above, as is this one, is a link - Just click it :)

Closing to merge with #1029


Add debug log when encounters permission check failure

Description
The main changes are:

Add some debug log when there's permission check failure, the format is as follows:
Authorization failed, principals: $principals has no $permissionModes on the requested saved object: $savedObjects
, here is an example:
Authorization failed, principals: {"groups":[""],"users":["user_read_tenant"]} has no [read] permissions on the requested saved object: [{"id":"test1-3.0.0","type":"config","workspaces":["test1"],"permissions":{"library_write":{"groups":["admin"],"users":["test_user","user_rw_tenant"]}}}]

Found that if the requested saved object doesn't exist, currently the permissionControl.validate function returns {"success":true, "result":true}, that's because when the saved object doesn't exist, bulkGetSavedObjects returns an object just like:

[
  {
    id: 'test1-3.0.1',
    type: 'config',
    error: {
      statusCode: 404,
      error: 'Not Found',
      message: 'Saved object [config/test1-3.0.1] not found'
    }
  }
]

, I think we should handle this case carefully and return the error to the caller:
{"success":false,"error":{"statusCode":404,"error":"Not Found","message":"Saved object [config/test1-3.0.1] not found"}}

Screenshot

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #125 (31e5df0) into workspace (c6037d5) will decrease coverage by 23.13%.
Report is 2 commits behind head on workspace.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           workspace     #125       +/-   ##
==============================================
- Coverage      65.76%   42.63%   -23.13%
==============================================
  Files           3336     1596     -1740
  Lines          64496    32331    -32165
  Branches       10267     6060     -4207
==============================================
- Hits           42413    13783    -28630
+ Misses         19503    17505     -1998
+ Partials        2580     1043     -1537

Flag
Coverage Δ

Linux_3
42.63% <0.00%> (-0.01%)
:arrow_down:

Windows_1
?

Windows_2
?

Windows_3
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

.../server/saved_objects/permission_control/client.ts
0.00% <0.00%> (-2.71%)
:arrow_down:

...core/server/saved_objects/saved_objects_service.ts
0.00% <0.00%> (-86.49%)
:arrow_down:

... and 2292 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Plugin error?

After updating my client and server to the new version (<IP_ADDRESS>) i got this error while trying to start my server.

Someone knows how to fix this?

Just fixed it myself!
Anyone having this error in the near future, try recopying the Rocket plugin into the Managed folder.
This fixed it for me. I think one of the files got corrupted.


Moodle and Blackboard examples dont follow spec

For discussion at weekly call:
The moodle and blackboard examples don't follow the spec in the master branch. We've spoke about them being behind the spec before, I'd just like to raise this again:

Should we only have output examples in the master branch if they are upto date
Should they be sign posted more clearly to explain why they don't follow the spec.

From call: Take new outputs and compare, create diff. Gareth to supply outputs.

Have sent updated Blackboard xAPI examples across to Cetis for update on the documentation page.


Update Stop-NetEventSession.md

added description for As Job and Input object

Docs Build status updates of commit 601831e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2012r2-ps/neteventpacketcapture/Stop-NetEventSession.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix Copy editing is needed for this PR. Thanks.

@dariomws306 @tseward
Peer review needed for this PR. Thanks.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Add Mesos books to documentation page

This commit adds the known Mesos books to-date to the Mesos documentation page so that community members can easily find them.
Testing: built the site.

Would someone mind building and pushing the website? It looks like there isn't a CI job to do this.


potential type mismatch on i386  and 32-bit arch

Hi Yann,
I noticed something that could be a potential (albeit rare in practice) issue.
The prototype for ZSTD_getDecompressedSize is
unsigned long long ZSTD_getDecompressedSize(const void* src, size_t srcSize);

unsigned long long is always a 64-bit integer IIUC.
The output of this function feeds into dstCapacity argument of ZSTD_decompress typically:
size_t ZSTD_decompress( void* dst, size_t dstCapacity,
                              const void* src, size_t compressedSize);

The issue is that while size_t is a 64-bit unsigned integer on x86_64, it's only a 32-bit unsigned integer on i386.  So presumably this effectively limits decompression to 4Gb on 32-bit architectures, after which ZSTD_decompress will likely fail I think.  Is my analysis correct?

(I understand a normal i386 machine has less than 4Gb memory)

Okay, feel free to close the issue.
I'm working on bindings for the Ada language and Ada caught this.  I'll submit a PR to update your documentation when it's done.

Comments clarified within v0.8.0.
Please let me know if this is not enough.

Thanks! I think the clarifications are sufficient.


fix(CI): removed rollup-umd-doc from package.json.

:tada: This PR is included in version 1.8.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


delete image from database

hi Noam..
How can i delete imagemanager id from database when deleting image?
On clicking delete image,image is being detached from control but how i can remove its id from database table?

Hi @thakkar-roshani that's only possible in the imagemanage. When you click on a image in the image overview there show up some details on the right side in de modal. There will be also a red delete button. If you click on that button, the file will be deleted and remove from the databse.


fix vendor import get ignored

I'm not sure if it should be fixed this way, but the issue is probably real. Gocode handles vendor package content correctly (i.e. the exported fields of a vendor package are all shown), but it seems to ignore vendor import. To reproduce the issue:
$GOPATH/src/github.com/a/b/
|---main.go
|---vendor/github.com/c/d/
    |---p.go

Where in main.go (# denotes the cursor position)
package main

import "github.com/c#"

The option github.com/c/d does not present in the candidates.

Merged as is. I don't use that feature, hence have no opinion on its correctness (weird stance frrom the point of view of a maintainer, but whateverr). Patch looks somewhat innocent.


Can't 'confirm' going to moons with LethalLib mods and LethalAutoComplete

Bug on LethalAutoComplete's tracker
Basically, typing Confirm does nothing when using LethalAutoComplete and any mod in my list involving LethalLib.  If LethalLib is active without any dependents, it works fine.
Modpack is 018cebcc-dab2-7958-1b8a-07e34048b513 with lots of things currently disabled for testing.
Enabling any of LethalThings, MirrorDecor, or Lategame_Upgrades causes the bug.
Thanks for your time in looking at this.

From this: https://github.com/IlyaChichkov/LethalAutocompleteMod/issues/8#issuecomment-1901147582, it seems like LethalLib isn't a problem either, or that the issue was magically fixed in some game update.


Error occured during sending OTP

hi @aasimtaif thanks for raising an issue here, i guess this issue is occuring because of the expired email sending password. I will update the password with new one then you will be able to receive the otp's via<EMAIL_ADDRESS>


get file from @fs 404 when the url has query

Describe the bug

this is becase the ? has been encode and sirv can not parse it and clean the query

so it can not lookup the file

This problem is happend since 2.9.14. In this pull request #8979
How i found this problem?
<EMAIL_ADDRESS>
when i import the css build by view-design ,i found this project. The css has use a url with query v=3.0.0

i think it can just clean the query when serve the local file
Reproduction
none
System Info
win10
2.9.14

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

duplicate of #9148. This is already fixed by #9173. Please upgrade to 3.0.2+.


Configuration Files

I know config files kinda suck but I think it could be good for this in a few ways:

For more complex codebases you might have to external a bunch of packages
We could add version control support and use this tool within CI systems

We could mitigate yaml or json config hell by allow all the config to be done from the cli with commands kinda like dokku

This is likely overkill, but we also parse the markdown report file to see if any of the packages are checked off as they are put in a checklist, and auto-approve/ignore them for #4


[WIP] PSP22 Permit

[x] Traits

[ ] Events
[x] PSP22PermitRef / PSP22Permit
[x] Internal, InternalImpl
[x] PSP22Permit, PSP22PermitImpl
[x] Add attribute to #[openbrush::implementation] macro

[x] Logic

[x] Permit function

[ ] Tests

[ ] Integration
[ ] E2E

[ ] Docs

[ ] Web docs
[ ] Code docs

[ ] Make it as separate feature (due to Mac problem)

Blocked by https://github.com/paritytech/ink/pull/1840

Why not go with Permit2?

How to generate signature for permit in TypeScript using polkadot-js api?

Who is continue with this issue?


Web version not working, no results displayed

Using webpack 3.3.0, so perhaps that's the issue? stats.json here

Working fine with updated webpack version 3.4.1, probably a stats.json issue.

I can confirm that the web version does not work with webpack version 3.5.3.
Related: https://github.com/chrisbateman/webpack-visualizer/issues/44


Trim extra spaces around links in FAQ

Links are styled with an underline (on hover, anyway), and there's extra spill-over

thanks for sending fixing these links @RealOrangeOne! we've just rewritten the FAQ and I believe the issues have been fixed at HEAD as well, so i'll close this PR.


add e2e v2 test for batch join non-equi condition in

@yuhao-su Could you add a regression test somewhere (maybe in e2e tests) to show that this no longer fails?
Originally posted by @jon-chuang in https://github.com/singularity-data/risingwave/issues/2462#issuecomment-1125413684

I have added e2e test for it.
https://github.com/singularity-data/risingwave/blob/main/e2e_test/v2/batch/subquery.slt


Add ruff support

This adds support for both ruff diagnostic and formatting.

Hi, thanks for the PR, but why would you use this instead of ruff server?

In this case, yes if you have an updated ruff. Should I close this PR?

I will try again with ruff server