Compile errors in VS Code codebase with latest TS nightly

🕗 Version & Regression Information

This changed between versions 4.2.0-dev.20201207 and 4.2.0-dev.20210105

Repo

Update VS Code to use the latest nightly TypeScript version  (yarn add typescript@next)
Run compile in the codebase yarn run watch

Issue
This produces around 16 compile errors. Most of these look like false positives to me:
[21:49:47] Error: vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts(1232,24): The left-hand side of an 'instanceof' expression must be of type 'any', an object type or a type parameter.
[21:49:47] Error: vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts(1232,72): Argument of type 'undefined' is not assignable to parameter of type 'Uint8Array'.
[21:49:47] Error: vscode/src/vs/base/browser/ui/dropdown/dropdownActionViewItem.ts(176,99): Property 'getActions' does not exist on type 'readonly IAction[] | IActionProvider'.
  Property 'getActions' does not exist on type 'readonly IAction[]'.
[21:49:47] Error: vscode/src/vs/base/browser/ui/actionbar/actionbar.ts(267,9): Type '(readonly IAction[] & any[]) | (IAction & any[]) | (IAction | readonly IAction[])[]' is not assignable to type 'readonly IAction[]'.
  Type '(IAction | readonly IAction[])[]' is not assignable to type 'readonly IAction[]'.
    Type 'IAction | readonly IAction[]' is not assignable to type 'IAction'.
      Type 'readonly IAction[]' is missing the following properties from type 'IAction': id, label, tooltip, class, and 4 more.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1249,24): Property 'language' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'language' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1250,22): Property 'scheme' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'scheme' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1251,30): Property 'pattern' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'pattern' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1251,94): Property 'pattern' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'pattern' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHostTypeConverters.ts(1252,25): Property 'exclusive' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'exclusive' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHost.api.impl.ts(199,26): Property 'scheme' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'scheme' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/workbench/api/common/extHost.api.impl.ts(202,58): Property 'exclusive' does not exist on type 'DocumentFilter | readonly (string | DocumentFilter)[]'.
  Property 'exclusive' does not exist on type 'readonly (string | DocumentFilter)[]'.
[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,11): Property 'language' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.
[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,21): Property 'pattern' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.
[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,30): Property 'scheme' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.
[21:49:47] Error: vscode/src/vs/editor/common/modes/languageSelector.ts(58,38): Property 'hasAccessToAllModels' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.
[21:49:47] Error: vscode/src/vs/editor/common/modes/languageFeatureRegistry.ts(28,21): Property 'exclusive' does not exist on type 'LanguageFilter | readonly (string | LanguageFilter)[]'.
  Property 'exclusive' does not exist on type 'readonly (string | LanguageFilter)[]'.

Note that after installing typescript@next, you may run into this compile error: https://github.com/googleinterns/tsec/issues/20 (which is not related to VS Code directly)

Note that after installing typescript@next, you may run into this compile error: https://github.com/googleinterns/tsec/issues/20 (which is not related to VS Code directly)

Duplicate of #41808

Duplicate of #41808


Individual thread sampling with JVMCI can return negative numbers

In some of the ScalaBench measurements with JVMCI merge threads turned OFF, the values in the instruction count column are occassionally negative. This could be a problem in the ScalaBench sampling helper class, but since it does very little with the data, it is more likely an agent issue.

Would you, please, provide concrete data here and the JVM configuration? Are the negative data arbitrary numbers or do they look like PAPI error codes?
I suspect this means that we are measuring one thread several times and the second event set could not be started...

I just took the Graal 1.0.0 release candidate on OpenJDK, current ScalaBench (652052961d26c63518995de19f7329374fc26fbe) and agent (12c6f8b8f270160e166ad0c156e59ef6f5514170), run it on my laptop and saw this:

java -agentlib:ubench-agent -jar scala-benchmark-suite-0.1.0-20120216.103539-3-d3s.jar --extra-events instructions@JVMCI_THREADS --output-file output.csv --iterations 66 xalan
...
cat output.csv
benchmark,total_ms,iteration_time_ns,process_cpu_time_ns,compilation_time_ms,compilation_total_ms,JVMCI_T6_instructions,JVMCI_T7_instructions,JVMCI_T5_instructions
xalan,3798,3359645165,25210000000,13079,13308,-1213561013,-1213561013,2924815023
xalan,6479,2588600169,17760000000,7612,21142,6659274468,3390970203,4626275666
xalan,8376,1777705439,11090000000,6300,27443,1044707730,1044707730,1044707730
...
xalan,34844,456987508,3570000000,175,94253,1161980260,619780977,328168209
xalan,35312,416696861,3250000000,667,94921,-410579606,868577954,0
xalan,35832,486861642,3580000000,194,95115,67287093,91611228,283080490
...
xalan,36727,410000414,3180000000,0,95118,0,0,0
xalan,37226,463863647,3620000000,119,95272,128900266,1347380896,-371145660
xalan,37829,564058371,4050000000,519,96229,2466654605,471780501,283313844

Perhaps another observation. It seems that in cases where there are more negative numbers present in the same output line, they are the same numbers:
xalan,15650,643145035,4980000000,1937,51952,2985997795,2985997795,2985997795
xalan,16398,682321166,5190000000,1888,53841,-1036167101,-1036167101,-1036167101
xalan,17112,630376776,4840000000,2207,56050,3740067173,3740067173,3740067173
xalan,17871,676468147,5200000000,1774,57825,581611822,-130868786,1200932886
xalan,18608,632173435,4870000000,3203,61028,3379272054,3379272054,3379272054
xalan,19321,646657455,4940000000,1650,62678,776865914,776865914,776865914
xalan,20047,632705181,4920000000,2654,65332,1782850501,846101445,1782850501
xalan,20774,652520105,5030000000,2462,67794,1099108838,1099108838,1099108838
xalan,21489,653321071,5060000000,1817,69612,-369491783,-369491783,-369491783
xalan,22133,575731713,4460000000,1650,71262,-3575862241,-3575862241,-3575862241
xalan,22735,523908903,4070000000,1392,72994,0,0,0
xalan,23305,499926428,3860000000,1423,74418,-1326725636,2519343880,85983699

After some investigation, the reason is the counter access code in PAPI. The perf_event component uses interpolation when querying the counter values, adding the actual value of the PMC register to the kernel reported offset. Problem is, the current value of the PMC register is read in the context of the thread doing PAPI_read (), but the kernel reported offset comes from a different context, and the computation therefore does not make sense.
There are some code paths through PAPI_read () that bypass the interpolation, for example when PAPI is compiled with --enable-perfevent-rdpmc=no, but that will slow down reading for all perf_event counters so not sure if we want it. On the other hand, setting the inherit flag disables the interpolation too, so perhaps we already do not have it on the main counters we use ?
Check _pe_read () in components/perf_event/perf_event.c.


fix(build): bug with AoT build when using npm link'ed libraries

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix for #1834

ayyeee 💯


Simplifying the flow to add a table

When specifying a table reference that can not be found, the system used
to still create the object, which would result in confusion and bad
error messages down the line. Now it will fail and not create the
object.
I also removed fields that are not necessary to worry about when
initially creating the table and change some of the flashed messages

LGTM


animation component: when "from" not set, it uses the default value instead of current one

First of all, thanks for all your work!
Code sample:
<a-box
        position="0 1 -2"
        rotation="30 30 0"
        color="#87CEEB"
        roughness="0.8"
        scale="1 1 1"
        animation__mouseover="property: scale; startEvents: mouseenter; to: 1 2 1; dur:500"
        animation__mouseleave="property: scale; startEvents: mouseleave; to: 1 1 1; dur:500"
    >
</a-box>

Here there is no "from" attribute set and it seems like it's using the default scale value as "from".
In this case, the second animation jus not works as scale goes from "1 1 1" to "1 1 1".
I would expect the component to use the current scale value as "from".
Is it a normal behavior?
Thanks !

Thanks, possibly a bug. I will probably get around to rewriting it to tween.js with unit tests. For now, I guess you can manually set from?

Sure.
Reviewing your code, it seems like the from is calculated at update time where it should be calculated at execution time.
function configDefault (el, data, config) {
  var from = data.from || getComponentProperty(el, data.property);
  return AFRAME.utils.extend({}, config, {
    targets: [{aframeProperty: from}],
    aframeProperty: data.to,
    update: function () {
      setComponentProperty(el, data.property, this.targets[0].aframeProperty);
    }
  });
}

So this bug may appear only when animations are triggered by events and their properties have changed between update and the event?

I see. Yeah, I think tween.js is the superior API, which is what A-Frame <a-animation> is using. anime.js was a one-and-done library and has some shortcomings.

Just recalculated the config at execution time...

thanks!

Hi Kevin,
Seems like this re-appeared here.
Interested about a PR ?
Thanks,
Arthur


Cannot connect Joule to lnd within extension pop-up window

When the Joule extension pop-up loses focus, it disappears and reverts to the extension's home page.  This makes it impossible to select the macaroons when connecting Joule to lnd.  The same issue makes it difficult to retrieve a password from a password manager to unlock Joule while paying a copied-and-pasted Lightning Network invoice.
The best workaround is to open Joule in its own page by navigating to e.g. chrome-extension://lnbbaakgapeflbgngbbjhmnjfhidhlhe/popup.html.  Joule can then be successfully connected to lnd.
To remedy this, it would be helpful if the Joule pop-up included a link to the full-page view, and/or if the extension window could be made to persist even when it loses focus.

This is a great point, I'd been clicking on the inputs and navigating to my macaroons, but if you tried to drag, it definitely would close. I'll put together an options.html page, and the "Get started" button will bounce you over there for setup.

Whoops, meant to close #18, not this one.


HABTM .delete does not run callbacks

Mongoid 3.1.4
It seems that Model#{name}.delete is not running the callbacks for a has and belongs to many relation.
I was trying to do this (a counter_cache for the HABTM relation):
class Tag
  include Mongoid::Document
  has_and_belongs_to_many :bookmarks

  before_update :set_bookmarks_count, if: :bookmark_ids_changed? # doesn't work regardless of this condition
end

class Bookmark
  include Mongoid::Document
  has_and_belongs_to_many :tags
end

$> bookmark = tag.bookmarks.first
#=> < bookmark object >
$> tag.bookmarks.delete bookmark
# callbacks do not run

@durran : you added label done to it, is it fixed in current branch or what can you please give some reference in the code which fixes this issue?


Update CI

Clang 14
GCC 6
Clang-Tidy 14

Coverage remained the same at 100.0% when pulling a75574b97cbe4ccd073b4a7facb2331faaf14331 on gcc6 into 67c8ead92319e61b50726ad8652ad5797d556220 on develop.


adds background color to resize_contain

I was looking to specify a background color on the resize_contain method.

Adds an additional parameter (bgcolor) to the method resize_contain, allowing any Pillow ImageColor as an acceptable value.
ignores test image in .gitignore

Worth noting: this was committed without the pre-commit hooks. While my tests passed, some of the other code in the tests wasn't passing to the standards.

Not ready to merge.

Needs update to readme
Needs new version number

@charlesthk What should I do about the README.md vs README.rst? Make the same change in both? Pandoc from one to the other?


Concave particle pressure validation

Description
Performs cross validation using NVT and NPT simulations of a hard particle with a concave shape. Computes the pressure in NVT simulations, and then runs NPT simulations and calculates the density the mean pressure.
Motivation and context
Validates the implementation of the SDF-based pressure calculation where the expansive contribution to the pressure is nonzero (i.e., for non-convex hard particles).

Resolves #43
How has this been tested?
Ran on PSC-Bridges2. Results:

Checklist:

[ ] I have reviewed the Contributor Guidelines.
[ ] I agree with the terms of the HOOMD-blue Contributor Agreement.
[ ] My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.

pre-commit.ci autofix

pre-commit.ci autofix

Here are the results from the GPU jobs run on Delta.


Removed attribute values from reference-based reading.

Closes #341

:white_check_mark: Build ExtendedXmlSerializer <IP_ADDRESS>-uypiabac completed (commit https://github.com/ExtendedXmlSerializer/home/commit/5a18b2efe4 by @Mike-EEE)
Install it by running the following command in Package Manager Console:
Install-Package ExtendedXmlSerializer -Version <IP_ADDRESS>-uypiabac -Source https://ci.appveyor.com/nuget/extendedxmlserializer-preview


Merge master branch into envoy-wasm

Title: Merge master branch into envoy-wasm
Description:
Please merge master branch into envoy-wasm.
Kuat added ability to add upstream network filters in envoy master. (https://github.com/envoyproxy/envoy/commit/0f892c2385e7051d325d22b3f603cc60facedd6e) Need this for TCP Metadata work as Istio Proxy uses envoy wasm SHA.

Merged.


[FLINK-24402][metric] Add a metric for back-pressure from the ChangelogStateBackend

What is the purpose of the change
Currently, the task back-pressured by the changelog state backend is shown as busy, this PR adds ioBackPressuredTimePerSecond metric and accumulates it into total BackPressuredTimePerSecond.
Brief change log

Add ioBackPressuredTimePerSecond metric
Accumulates ioBackPressuredTimePerSecond into total backPressuredTimePerSecond

Verifying this change
This change added tests and can be verified by TaskIOMetricGroupTest#testTaskIOMetricGroup()
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi @rkhachatryan, could you please help take a review?

@flinkbot run azure


Refactor unit tests

Checklist

[X] tests and code linting passes
[X] the commit message follows commit guidelines

Affected core subsystem(s)

Tests
Description of change

Updated layout for cleaner/easier testing (prepare for future fixtures and testing .eslintrc).
Test artefacts are now redirected to .tmp/test folder.
Now using a mocha.opts to define mocha options
Using bdd reporting to get a better testing feedback and performance tracking (with slow tests).

Just added a commit refactoring eslint leveraging Airbnb's config which is a pretty good (strict) starting point. Tried to minimize the changes to the code by adding according rules.
One thing that we should definitely change in my opinion is the indenting. The whole JS world uses spaces (both airbnb and feross/standard styleguide do recommend spaces), as an open-source library, this project should try to closely follow commonly used standards.
I did not want to push the change in this commit (should be a single separated commit) without polling you about it as it is often a "sensitive" subject since changing habits is hard. I won't mind if you do not want to switch.

I'm mostly ok with this. I think there are a lot of good changes in there, but a lot of things are just a matter of taste I think.
E.g. I don't think using forEach instead of for of is necessarily "better", so I don't really think it makes sense to change that kind of stuff. I don't feel strongly about balanced spacing in params. Not sure if it really makes sense to change it.
I really like the tooling changes, e.g. the Mocha config etc. Also consistently using template strings is a great idea. And we definitely needed test coverage.
Concerning tabs vs spaces: I'm using a tabstop of 8, but I realise that the rest of the world uses either 2 or 4. I think using a tabstop of 8 makes it more painful to write deeply nested functions. I think that's generally speaking not a bad thing.
Any chance we can keep 5702f15 separate and discuss the changes to the linting rules first?

Thanks for the review, indeed some changes are cosmetic, and a matter of state, I don't really mind about any of them, a few side-notes:

regarding forEach instead of for of, I'm not encountering for of in most of the code I'm looking into so I'm not "used to it", forEach is shorter of both 1 LOC and 1 variable definition so it looks like a little bit more simple/elegant to me but I'll gladly revert it if you want.

regarding balanced spacing in params, I tried to go for the rule that enforced the least changes. But usually the related eslint-rules are object-curly-spacing and array-bracket-spacing, so one issue with the code was that import statements did not respect curly-spacing ever, and it was mixed for inline objects.

I'll see if I can cherrypick the eslint commit to another PR.

@mgcrea It looks like this conflicted with the dependency update PR. Can you rebase so we can merge? Really like this.

@alexanderGugel, I'm on it.

Travis is green, ready for merge! Thanks for the review.


server: add initial Config and early initialization/validation

moved resolver.go and horizon.go out of pkg/server/ into a dedicated pkg/{resolver,horizon}/


Failed to get similar books: Failed to create driver...

I've setup eBookBuddy using the Docker Compose below. It isn't showing any recommendations and is showing the errors in the logs below.
  ebookbuddy:
    depends_on:
      readarr_ebook:
        condition: service_healthy
    image: thewicklowwolf/ebookbuddy:latest
    container_name: ebookbuddy
    network_mode: service:vpn
    restart: unless-stopped
    logging:
      driver: json-file
    environment:
      TZ: $TZ
      readarr_address: http://vpn:8788
      readarr_api_key: <redacted>
      root_folder_path: /data/eBooks/Collection/
      auto_start: True
      search_for_missing_book: True
    volumes:
      - ${APPDATA}/ebookbuddy/config:/ebookbuddy/config
      - ${APPDATA}/ebookbuddy/gunicorn_config/gunicorn_config.py:/ebookbuddy/gunicorn_config.py
      - $LOCALTIME
    labels:
      - autoheal=true
      - traefik.enable=true
      - traefik.http.routers.ebookbuddy-int.priority=20
      - "traefik.http.routers.ebookbuddy-int.rule=Host(`ebookbuddy.$DOMAIN`) && $CLIENTIP_LOCAL_IPS"
      - traefik.http.routers.ebookbuddy-int.entrypoints=websecure_7443
      - traefik.http.routers.ebookbuddy-int.middlewares=chain-default@file
      - traefik.http.routers.ebookbuddy-int.service=ebookbuddy
      - traefik.http.routers.ebookbuddy-ext.priority=10
      - "traefik.http.routers.ebookbuddy-ext.rule=Host(`ebookbuddy.$DOMAIN`)"
      - traefik.http.routers.ebookbuddy-ext.entrypoints=websecure_7443
      - traefik.http.routers.ebookbuddy-ext.middlewares=chain-organizr-auth@file
      - traefik.http.routers.ebookbuddy-ext.service=ebookbuddy
      - traefik.http.services.ebookbuddy.loadbalancer.server.port=${EBOOKBUDDY_PORT}

ebookbuddy      | [2024-08-15 20:32:25 -0400] [1] [INFO] Starting gunicorn 22.0.0
ebookbuddy      | [2024-08-15 20:32:25 -0400] [1] [INFO] Listening at: http://<IP_ADDRESS>:5010 (1)
ebookbuddy      | [2024-08-15 20:32:25 -0400] [1] [INFO] Using worker: geventwebsocket.gunicorn.workers.GeventWebSocketWorker
ebookbuddy      | [2024-08-15 20:32:25 -0400] [7] [INFO] Booting worker with pid: 7
ebookbuddy      | **************************************************
ebookbuddy      |
ebookbuddy      | eBookBuddy Version: 0.1.3
ebookbuddy      |
ebookbuddy      | **************************************************
ebookbuddy      | Loading Config via file
ebookbuddy      | <IP_ADDRESS> - - [2024-08-15 20:32:26] "GET /socket.io/?EIO=4&transport=polling&t=P5OcPba HTTP/1.1" 200 254 0.000736
ebookbuddy      | <IP_ADDRESS> - - [2024-08-15 20:32:27] "POST /socket.io/?EIO=4&transport=polling&t=P5OcPbv&sid=86i6qpDZRrTKv-NMAAAA HTTP/1.1" 200 201 0.003885
ebookbuddy      | <IP_ADDRESS> - - [2024-08-15 20:32:27] "GET /socket.io/?EIO=4&transport=polling&t=P5OcPbw&sid=86i6qpDZRrTKv-NMAAAA HTTP/1.1" 200 189 0.000203
ebookbuddy      | <IP_ADDRESS> - - [2024-08-15 20:32:27] "GET /socket.io/?EIO=4&transport=polling&t=P5OcPcZ&sid=86i6qpDZRrTKv-NMAAAA HTTP/1.1" 200 157 0.000154
ebookbuddy      | Getting Books from Readarr
ebookbuddy      | Searching for new books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | There is no [linux64] geckodriver "v0.35.0" for browser firefox "128.0" in cache
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Getting latest mozilla release info for v0.35.0
ebookbuddy      | About to download new driver from https://github.com/mozilla/geckodriver/releases/download/v0.35.0/geckodriver-v0.35.0-linux64.tar.gz
ebookbuddy      | Driver downloading response is 200
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver has been saved in cache [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0]
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver] found in cache
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver] found in cache
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver] found in cache
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver] found in cache
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Creating New Driver...
ebookbuddy      | ====== WebDriver manager ======
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Get LATEST geckodriver version for 128.0 firefox
ebookbuddy      | Driver [/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver] found in cache
ebookbuddy      | Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'
ebookbuddy      | Failed to get similar books: Failed to create driver...
ebookbuddy      | Discovered 0 potential books
ebookbuddy      | Search Exhausted - Try selecting more books from existing Readarr library
ebookbuddy      | Finished Searching

Failed to create driver: [Errno 8] Exec format error: '/home/general_user/.wdm/drivers/geckodriver/linux64/v0.35.0/geckodriver'

What architecture are you running this on? The error suggests there might be compatibility issues with your system's architecture, so I don't think I can help unfortunately.
Since this relies on web scraping (due to the lack of a decent book API), it can be unreliable at the best of times, so it’s unlikely to work on every system.
However, if you investigate further and find a solution that works for your architecture, feel free to submit a PR - I'd be happy to incorporate it.

I'm running it via Docker on a Raspberry Pi 4 running Bookworm 64bit. What is currently supported?

I'm running it via Docker on a Raspberry Pi 4 running Bookworm 64bit. What is currently supported?

I knew it worked on AMD64 and now I know it doesn't work on a Raspberry Pi 4.  Everything else is a guess.
If you want to try and get it working, you can try copy the files and see what changes are needed to get it running locally.
Best of luck with it.


When entering GalleryFragment for the first time, two network requests are executed.

When entering GalleryFragment for the first time, two network requests are executed. Can it be modified to only request once

Just add prefetchDistance in PagingConfig


API Crypto Sign JWT

You should be able to generate a jwt using the crypto/jwt endpoint
api/crypto/jwt {data="the data to sign"}

Closing this now as it is likely not a good idea to expose this at all.


Svg preview

As discussed in #3,

Modified the make_preview_image.lua file to create SVGs instead of PNGs
Added local previews directory
Updated all existing previews to SVGs in README

Excellent! My suggestion would be to not append a _preview to the svg files since they are already stored on the previews directory, making their names unnecessary long, unless you are planning on generating multiple types of previews for a color theme (like a svg mockup of the editor with the colors of the theme applied). Everything else looks great.

Done!

You forgot to git rm all the previews/*_preview.svg files and also would be nice to prepend the preview directory on local fp = io.open("previews/" .. name .. ".svg", "wb") so they are directly stored on the previews directory.

Sorry! Still learning git. Should be solved now.

Thanks!


Tracing doodles

Fork of https://github.com/typelevel/feral/pull/45 for me to doodle with how to integrate natchez with feral.

I think this is in a pretty good state, pending what happens with https://github.com/tpolecat/natchez/pull/448. Is there anything we want to try or do before merging (and maybe publishing snapshots)?

Also, I have the XRay middleware updated to use this branch, but it doesn't build since the XRay support in Natchez hasn't been published yet. I was thinking if we plan to merge this branch soon, I can push it up as a followup PR (in its own module? I'm not sure how we want to organize things yet)

Awesome! Actually, what I'd like to do is split the PRs again which got mixed up while we were experimenting :)

A PR introducing the effect-agnostic Lambda, which hopefully @djspiewak can take a look at, since it's fairly different from his original concept gist and also since he was dubious about my last attempt at effect agnosticism :)
A PR introducing the TracedLambda, at least with the Span[F]-based formulation since we can do this with Natchez as published today. If LiftTrace becomes a published thing, we can consider adding the Trace[G]-based formulation as well.
A couple more tweak PRs with the INothing thing and maybe some other minor optimizations/fixes.

All of this should be publishable right now and I'm happy to do so while Daniel looks at (1).

Also, I have the XRay middleware updated to use this branch, but it doesn't build since the XRay support in Natchez hasn't been published yet.

Ooh, I'll take a look at this shortly! I thought we could get to a place where we don't need a specific integration, but maybe this was too ambitious 😆

in its own module? I'm not sure how we want to organize things yet

I'm like wayyy into over-modularization, so please push back on this. But yes that's my first instinct!

@bpholt I just published everything in this branch, propagating now.
"com.armanbilge" %%% "feral-lambda-natchez" % "0.1-f497734" // and friends :)

Everything here now split into:

https://github.com/typelevel/feral/pull/51
https://github.com/typelevel/feral/pull/55
https://github.com/typelevel/feral/pull/52


Translation issue

Where can I find the translation repo for this page?

Here:
https://github.com/AlphaWallet/alpha-wallet-android/blob/master/app/src/main/res/values-zh/strings.xml

updated.


Placement optimisations

I was looking at the results of dffram.py -s 1024x32. Firstly the default positioning of pins looks pretty bad (somewhat random):

I found the USE_IOPLACE environment variable, which does a much better job of laying out the pins, including placing the data in and out bits in the right spot:

Another interesting thing is the layout is quite congested towards the left and (somewhat less so) towards the top. Looking at met4:

I haven't worked out why yet.

Another observation. If I understand it correctly *.BYTE\[0\].B.BIT\[0\] is the first bit of 32 and should be grouped together at the left of the macro. Why is it in 2 separate chunks:
    - BANK128\[0\].RAM128.BLOCK\[0\].RAM32.SLICE\[0\].RAM8.WORD\[1\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED ( 2760 13600 ) N ;
    - BANK128\[0\].RAM128.BLOCK\[0\].RAM32.SLICE\[0\].RAM8.WORD\[3\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED ( 2760 19040 ) N ;
    - BANK128\[0\].RAM128.BLOCK\[0\].RAM32.SLICE\[0\].RAM8.WORD\[5\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED ( 2760 24480 ) N ;
    - BANK128\[0\].RAM128.BLOCK\[0\].RAM32.SLICE\[0\].RAM8.WORD\[7\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED ( 2760 29920 ) N ;

...

    - BANK128\[2\].RAM128.BLOCK\[2\].RAM32.SLICE\[0\].RAM8.WORD\[0\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED (<PHONE_NUMBER>60 ) N ;
    - BANK128\[3\].RAM128.BLOCK\[1\].RAM32.SLICE\[0\].RAM8.WORD\[0\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED (<PHONE_NUMBER>20 ) N ;
    - BANK128\[3\].RAM128.BLOCK\[3\].RAM32.SLICE\[0\].RAM8.WORD\[0\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED (<PHONE_NUMBER>20 ) N ;
    - BANK128\[2\].RAM128.BLOCK\[1\].RAM32.SLICE\[0\].RAM8.WORD\[0\].W.BYTE\[0\].B.BIT\[0\].genblk1.STORAGE sky130_fd_sc_hd__dlxtp_1 + PLACED (<PHONE_NUMBER>60 ) FS ;

The placement thing was due to an OpenLane regression that required us to fall back to OpenROAD random pin placement, so I’ll update the default. The layout is congested towards the left because we start left to right, so the right side is typically padded with fills, taps, etc to fill the rest of the Core Area.
As for your other observation, the four banks are laid out in a 2x2 fashion, not 4x1. 4x1 would not route— we try to keep the aspect ratio within reasonable distance of 1:1.


API key is not recognize

Even though I copied it from openai.com, it does not recognize my key:
Not sure, do I need to regard something else?

@sspaeti - couple of things to check

Do you have the API balance and able to use in the OpenAI playground?
Try re-generating a new key and check
in Obsidian Open ctrl+shift+i to open the developer tools and check what is the console log right at the moment when new API key is entered into settings

Thanks so much, @sudheer82; it works now.
I didn't change anything, but now when I open the settings again, it gets the green checkmark:

And after fixing the Templater (creating the script as a file on disk instead of inside the Template itself), it works now!!
Thanks so much; I will try more; this is a useful plugin!

@sspaeti - link has a period at the end and its not working.

Oops, yes, I fixed it above. Thanks.


The domain name management page cannot be used to log in.

          you can fix this issue by adding this in .conf that you can found in this path "/data/nginx/proxy_host"

proxy_set_header Authorization $http_authorization;
location / {
    # Authorization
    auth_basic            "Authorization required";
    proxy_set_header Authorization $http_authorization;

    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection $http_connection;
    proxy_http_version 1.1;

    # Proxy!
    include conf.d/include/proxy.conf;
  }

Originally posted by @rahul1996pp in https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3124#issuecomment-1676463224

I tried various combinations with cloudflare for a long time, but nothing worked, and finally I deleted the ssl certificate, turned off cloudflare's ssl, just normal http access, still unable to log in, and kept lossing in the login screen. I saw these answers, I tried to change the.conf file, in the UI, in the Linux file, it still didn't work, I'm the latest version.

From the request it appears that the login was successful, but will jump back to the login page, I am in host network mode, so set the reverse proxy <IP_ADDRESS>.

When I used Incognito mode, it logged in successfully.

I'm having the same problem with cloudflare ssl + dns, I cleared my browser cache and logged in fine!


Merge fixes

A bunch of problems fixed due to heavy merging activity.
The current code still has one breakage: it does not correctly set ingress / egress gateway enablement and namespaces. This requires some path selection work to be fixed.

Actually it would be great if you can give details about what are the problems that this PR tries to fix because we might be missing contexts for some of them

@richardwxn I updated the PR description to give some more context.


logging Status with JSON format

logging status info with JSON format instead of Stringified JSON
eg. logger.error("ValidationError:" + status.toString());
status.toString() is pure JSON, but with prefix ValidationError, it cannot be recognized by logging framework.

 logging Status with JSON format light-4j master

For some users, they are using the JSON appenders so that the logs can be injected into Splunk. Mixing string and JSON in the same logging statement will cause issues for those appenders. Thank you @BalloonWen for your help.


please upd to 1.0, beacause this happened.

Describe your bug here.
so when i loaded a psych 1.0 song, and it crashed.

Yes, using Mods
If you edited anything in this build, mention or summarize your changes.
No.
What is your platform?
Windows

the problem is the chart json is no "song": {
you have to put the 	"song": { on { make sure is not on top
and put } all away down on } make sure its on the top on } like this
{
"song": {
blablabla
}
}


Issue with provisioning network connection

When setting up virtual network connection for DevBox I get this error message
    "statusMessage": "{\"status\":\"Failed\",\"error\":{\"code\":\"ResourceOperationFailure\",\"message\":\"The resource operation completed with terminal provisioning state 'Failed'.\",\"details\":[{\"code\":\"InternalServerError\",\"message\":\"The service encountered an internal error and was unable to complete the request. Retry the operation later, and contact support if this error persists.\"}]}}",
    "eventCategory": "Administrative",

Tried provisioning multiple network connections in west Europe and all fail.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47a5556f-f9fb-97f0-bf25-56926e66172e
Version Independent ID: 37a52ff6-d520-a12f-e12c-8381c9f87473
Content: Microsoft Dev Box key concepts - Microsoft dev box
Content Source: articles/dev-box/concept-dev-box-concepts.md
Service: dev-box
GitHub Login: @RoseHJM
Microsoft Alias: rosemalcolm

@msandbu - Please try and re-register the Microsoft.DevCenter resource provider in the subscription.
Subscriptions --> Resource providers --> Microsoft.DevCenter --> Click on Re-register in the command bar.
If that does not work, please try and register the Microsoft.Fidalgo resource provider.

Hi @msandbu,
I hope Michael's guidance has resolved the issue. If not, or if you have further questions about the service, please create a support request through Support + Troubleshooting in the Azure portal.

@msandbu - We have root caused the issue and mitigated the problem.  If the re-register does not work, please reply to the thread indicating the problem is persisting.  Apologies for the inconvenience.

Network Connections are deploying now, thanks!

@msandbu - Thank you for the report.
@RoseHJM \ @RohitMungi-MSFT - I do not have permissions to close issues on this repo.  Please close at your convenience.


Assertion messages

Resolves #1
Changes:

Added FailureBuilder class which is now used to create formatted failure messages.

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.


Cannot run posenet example in tflite

What happened?
terminal output:
2024-06-09 12:35:49.949317: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-06-09 12:35:49.983152: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-06-09 12:35:50.401913: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
Traceback (most recent call last):
  File "/home/sylvex/iree/.venv/bin/iree-import-tflite", line 8, in <module>
    sys.exit(main())
  File "/home/sylvex/iree/.venv/lib/python3.10/site-packages/iree/tools/tflite/scripts/iree_import_tflite/__main__.py", line 54, in main
    tflite_to_tosa(
  File "/home/sylvex/iree/.venv/lib/python3.10/site-packages/iree/tools/tflite/scripts/iree_import_tflite/__main__.py", line 69, in tflite_to_tosa
    tflite_to_tosa_bytecode(
  File "/home/sylvex/iree/.venv/lib/python3.10/site-packages/tensorflow/python/compiler/mlir/mlir.py", line 200, in tflite_to_tosa_bytecode
    pywrap_mlir.experimental_tflite_to_tosa_bytecode(
  File "/home/sylvex/iree/.venv/lib/python3.10/site-packages/tensorflow/python/pywrap_mlir.py", line 123, in experimental_tflite_to_tosa_bytecode
    return ExperimentalTFLiteToTosaBytecode(
tensorflow.python.framework.errors_impl.InvalidArgumentError: Unable to load input file cannot open input file '/tmp/workdir/model.tflite': No such file or directory
(.venv) sylvex@sylvex-Aspire-A715-51G:~/iree$ wget ${TFLITE_URL} -O ${TFLITE_PATH}
--2024-06-09 12:35:58--  https://storage.googleapis.com/iree-model-artifacts/tflite-integration-tests/posenet_i8.tflite
Resolving storage.googleapis.com (storage.googleapis.com)... 2404:6800:4012:4::201b, 2404:6800:4012:2::201b, 2404:6800:4012::201b, ...
Connecting to storage.googleapis.com (storage.googleapis.com)|2404:6800:4012:4::201b|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2894840 (2.8M) [application/octet-stream]
Saving to: ‘/tmp/workdir/model.tflite’

/tmp/workdir/model.tflite 100%[===================================>]   2.76M  1.56MB/s    in 1.8s

2024-06-09 12:36:00 (1.56 MB/s) - ‘/tmp/workdir/model.tflite’ saved [2894840/2894840]

(.venv) sylvex@sylvex-Aspire-A715-51G:~/iree$ iree-import-tflite ${TFLITE_PATH} -o ${IMPORT_PATH}
2024-06-09 12:36:03.387469: I tensorflow/core/util/port.cc:113] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`.
2024-06-09 12:36:03.417775: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX_VNNI FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-06-09 12:36:03.894858: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
(.venv) sylvex@sylvex-Aspire-A715-51G:~/iree$ iree-compile \
    --iree-input-type=tosa \
    --iree-hal-target-backends=llvm-cpu \
    ${IMPORT_PATH} \
    -o ${MODULE_PATH}
<unknown>:0: error: loc("floordiv"): unregistered operation 'tosa.div' found in dialect ('tosa') that does not allow unknown operations
<unknown>:0: note: loc("floordiv"): see current operation: %405 = "tosa.div"(%404, %39) : (tensor<1x1xi32>, tensor<1x1xi32>) -> tensor<1x1xi32>
<unknown>:0: note: loc("floordiv"): in bytecode version 1 produced by: MLIR19.0.0git

Steps to reproduce your issue

Build project with commit f062b19dfffeaf4e567b6f8793e0f40ff08cf525
run the command at https://iree.dev/guides/ml-frameworks/tflite/#using-command-line-tools

What component(s) does this issue relate to?
No response
Version information
f062b19dfffeaf4e567b6f8793e0f40ff08cf525
Additional context
There's probably previous version that I compiled also doesn't work.

what happend
I got almost same error here  with https://iree.dev/guides/ml-frameworks/tflite/ (using python code)
2024-06-10 00:12:28.459569: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Traceback (most recent call last):
  File "/Users/chendongsheng/github/iree/cds_demo_/test_tflite.py", line 29, in <module>
    iree_tflite_compile.compile_file(
  File "/Users/chendongsheng/github/iree/build/compiler/bindings/python/iree/compiler/tools/tflite.py", line 119, in compile_file
    result = invoke_pipeline([compile_cl])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/chendongsheng/github/iree/build/compiler/bindings/python/iree/compiler/tools/binaries.py", line 261, in invoke_pipeline
    raise CompilerToolError(stage.completed)
iree.compiler.tools.binaries.CompilerToolError: Error invoking IREE compiler tool iree-compile
Error code: 1
Diagnostics:
<unknown>:0: error: loc("floordiv"): unregistered operation 'tosa.div' found in dialect ('tosa') that does not allow unknown operations
<unknown>:0: note: loc("floordiv"): in bytecode version 1 produced by: MLIR19.0.0git

Invoked with:
 iree-compile /Users/chendongsheng/github/iree/build/compiler/bindings/python/iree/compiler/tools/../_mlir_libs/iree-compile /tmp/workdir/tosa.mlir --iree-input-type=tosa --iree-vm-bytecode-module-output-format=flatbuffer-binary --iree-hal-target-backends=llvm-cpu -o=/tmp/workdir/iree.vmfb --iree-llvmcpu-embedded-linker-path=/Users/chendongsheng/github/iree/build/compiler/bindings/python/iree/compiler/tools/../_mlir_libs/iree-lld --mlir-print-debuginfo --mlir-print-op-on-diagnostic=false

Need more information?  \
    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
    -DIREE_ENABLE_ASSERTIONS=ON \
    -DIREE_ENABLE_SPLIT_DWARF=ON \
    -DCMAKE_C_COMPILER=clang \
    -DCMAKE_CXX_COMPILER=clang++ \
    -DIREE_ENABLE_LLD=ON \
    -DCMAKE_C_COMPILER_LAUNCHER=ccache \
    -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
    -DCMAKE_CXX_COMPILER=/usr/bin/clang++ \
    -DCMAKE_C_COMPILER=/usr/bin/clang \
    -DIREE_BUILD_PYTHON_BINDINGS=ON \
    -DPython3_EXECUTABLE="$(which python)" \
    -DCMAKE_INSTALL_PREFIX=/usr/local/cds_bin \
    -DIREE_EMBED_RELEASE_INFO=ON

The version of tensorflow I installed do be 2.16.1

I sloved this problem by upgrade tensroflow version to 2.17. @Sylvexia
The mac intel chip can't download tensorflow after 2.17 by pip but anaconda did.
look like the google will not support intel-chip mac anymore!
but I did't found official msg about this.


kserver --socket=./my/socket

Specify the socket for KServer
Example
./k-distribution/bin/kserver --socket ./my-socket &
wait 10
env KSERVER_SOCKET=(pwd)/my-socket ./k-distribution/bin/kompile --help

@dwightguth Can you see any obvious reason why is my integration (pom.xml and spawn-kserver) broken?

@h0nzZik this looks like the same bug that @ehildenb is trying to fix. If you just wait a couple days it should hopefully be resolved.


List of Vulnerable functions for CVEs

Is your feature request related to a problem? Please describe.
I'm looking to reduce the number of false positives from SCA vulnerabilities by performing function-level reachability analysis. However, it is challenging without knowing which specific functions are vulnerable for each CVE. Currently, it seems that OSV.dev provides details on vulnerable packages, but not on the specific vulnerable functions, making it harder to prioritize or analyze vulnerabilities effectively.
Describe the solution you'd like
It would be highly beneficial if OSV.dev could include a list of vulnerable functions for each CVE, where applicable. This would allow security tools to perform function-level reachability analysis to determine if the vulnerable code is actually used, reducing unnecessary vulnerability reports. Such granularity would make the data much more useful for developers and security teams looking to mitigate real risks.
Describe alternatives you've considered
An alternative approach could involve manually analyzing the codebases or associated patches to determine the specific functions impacted by each CVE. However, this is not scalable, especially for large projects and multiple dependencies.
Additional context
Including vulnerable functions would provide much-needed granularity in SCA analysis and could help significantly reduce false positives. Are there any plans for this, or is there any existing data that could be leveraged for this purpose?

I just checked #2468 is a related thread, and I found this info - https://osv.dev/vulnerability/GO-2024-2961 but just wanted to check if we can get this data for maven / npm from some sources.

Hey @rohitcoder thanks for checking out our data!
We're really beholden to our upstream data sources to provide this information, at the moment.
We totally agree that having this information enables prioritisation beyond the vulnerable library package version.

Want to note that internally there's an interest in Vulnerable File analysis which is a bit easier to implement than function-based analysis.  Since we move at enterprise speed, I'll circle back in a couple months when we have a better handle of the problem space and optimal solutions.
What seems clear is that we may need to have an additional authority/standard that creates these vulnerable function/file entries data, which perhaps the respective distros confirm in their published advisory.

@rhdesmond Thanks for this info, I would be waiting for further updates.
Just wanted to confirm if you talking about the "OSV-Scanner" project? Is this a future plan for osv scanner, or something else?

This is not a current plan for osv-scanner, but if file-based vulnerability reporting proves useful it may be added to Osv-scanner in the future.


Is there any way to control playback speed?

As the subject described, is there any way to control playback speed?

Yes, actually its quite easy I will add this feature as soon as I would have the chance.

I've published the new version (0.5.4) with this new feature.

Thank you for your kind and active response. 😀


Adopt the CLI UI kit in the shopify theme open command

WHY are these changes introduced?
Fixes:

https://github.com/Shopify/internal-cli-foundations/issues/496
https://github.com/Shopify/internal-cli-foundations/issues/497

WHAT is this pull request doing?
This PR has two main parts, the REST Admin API client and the shopify theme open changes. Let's approach these changes by taking a look at modified files:

.vscode/launch.json - it introduces a handy debugger for themes

packages/cli-kit/src/api/admin* - here we're introducing the thin client to handle REST API calls, at the @shopify/cli-kit level

packages/theme/src/cli/utilities/themes-api* - here we're introducing themes API-specific logic

packages/theme/src/cli/commands/theme/open*
packages/theme/src/cli/services/open* - the shopify theme open command was updated following the convention of having a service module with the same name

packages/theme/src/cli/models/theme.ts - it's a thin data-structure that represents theme

packages/theme/src/cli/utilities/theme-selector*

packages/theme/src/cli/utilities/theme-urls* - here we're introducing utility functions to support our services

How to test your changes?

Run pnpm run shopify theme open -t <theme ID>
Run pnpm run shopify theme open -t <theme name>
Run pnpm run shopify theme open -l
Run pnpm run shopify theme open -d
Run pnpm run shopify theme open

Notice: The prototype doesn't have a header, however the CLI UI kit API requires it. I'm checking with DX, so feel free to ignore that detail for now :)
Before

After

Post-release steps
None.
Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[x] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

👋 Hey folks,
Feel free to the benchmark report - I've noticed it's happening on other PRs as well (I don't think it's related to these changes, still I'm double-checking)

I just rebased the branch to solve conflicts.

(I've rebased the branch following the refactor in the Admin public API)

(I've refreshed oclif.manifest.json and I've rebased the branch following the refactor in the Admin public API)


[BUG] Toggle navbar logo hides hamburger menu

Select logo == hidden option
Restrict viewport to mobile size
'.brand'selector encompasses the hamburger menu, thereby hiding it
Use more granular selector and offsetParent to poll state before toggling

Resolved by 760b5910233b74ada79250de118a585a7100c736


isupper() and isspace() calls does not conform to some ctypes.h macro implementation

Hello,
We are trying to use your library in an embedded system with a really strict compile environment. We noticed that in lines 491 (isupper) , 580 (isspace), 606 (isspace) you make such calls with a char subscript. However some compile options (-Werror=char-subscripts) and some libraries enforce int subscripts and will compile fail with error: array subscript has type char.
The fix is simple use an int variable for subscript or at least cast it to int like:
isspace(((int)str[i])
or
int c = str[i];
isspace(c);

Regards,
DM

Hi, thanks for the fix! I can merge such PR promptly, or will make this change myself next week.


Add simplified model manager install API to InvocationContext

Summary
This adds three model manager-related methods to the InvocationContext uniform API. They are accessible via context.models.*:

load_ckpt_from_path(model_path: Path, loader: Optional[Callable[[Path], Dict[str, Tensor]]] = None) -> LoadedModel

Load the checkpoint-format model file located at the indicated Path.
This will instantiate the model at the indicated path and load it into the model manager RAM cache if needed. If the optional loader argument is provided, the loader will be invoked to load the model into memory. Otherwise the method will call  safetensors.torch.load_file() or torch.load() (with a pickle scan) as appropriate to the file suffix.
Be aware that the LoadedModel object will have a config attribute of None.

download_and_cache_ckpt( source: str | AnyHttpUrl, access_token: Optional[str] = None, timeout: Optional[int] = 0) -> Path

Download the model file located at source to the models cache and return its Path.
This will check models/.download_cache for the desired model file and download it from the indicated source if not already present. The local Path to the downloaded file is then returned.
An example of this can be found in invokeai.backend.image_util.depth_anything.__init__, where a call the
download_with_progress_bar() has been replaced with: depth_anything_model_path =  self.context.models.download_and_cache_ckpt(DEPTH_ANYTHING_MODELS[model_size])

load_ckpt_from_url(source: str | AnyHttpUrl, access_token: Optional[str] = None, timeout: Optional[int] = 0, loader: Optional[Callable[[Path], Dict[str, torch.Tensor]]] = None) -> LoadedModel

Download, cache and load the model file located at the indicated URL.
This call combines download_and_cache_checkpt() with load_ckpt_from_path() to allow the loading of a remote or local model given its source URL. If need be, the model will be downloaded and cached.

Other Changes
This PR performs a migration, in which it renames models/.cache to models/.convert_cache, and migrates previously-downloaded ESRGAN, openpose, DepthAnything and Lama inpaint models from the models/core directory into models/.download_cache.
There are a number of legacy model files in models/core, such as GFPGAN, which are no longer used. This PR deletes them and tidies up the models/core directory.
Related Issues / Discussions
I have  systematically replaced all the calls to download_with_progress_bar(). This function is no longer used elsewhere and has been removed.

QA Instructions
I have added unit tests for the three new calls. You may test that the load_ckpt_from_url() call is working by running the upscaler within the web app. On first try, you will see the model file being downloaded into the models .cache directory. On subsequent tries, the model will either load from RAM (if it hasn't been displaced) or will be loaded from the filesystem.

Merge Plan
Squash merge when approved.

Checklist

[X] The PR has a short but descriptive title, suitable for a changelog
[X] Tests added / updated (if applicable)
[X] Documentation added / updated (if applicable)

There are two issues with the current code. The first is that the models download to the .cache directory and may be cleared periodically by the model manager in which case they will be re-downloaded when next needed. I’m not sure whether this is a feature or a bug, but I’m going to change the code so that models download somewhere that isn’t volatile.
The second issue is that if a model is already installed (usually in models/core), the existing copy is ignored. I’ll add a migrate script.

@psychedelicious @RyanJDick I think I've responded to all comments and suggestions. Thanks for the reviews!

I'll do a full review later, we still have too much coupling between the context/model manager and some of the utility classes.
I've just pushed changes that lift the loading out of the LaMa and DepthAnything classes, but not DWOpenPose - I'm not familiar with how ONNX loads models and ran out of time for this for now..

There just doesn't seem to be a good way for utility classes to access the model manager service in the running app without going through the context. One out would be to have the model manager set a singleton in the way that the configuration service does, thereby allowing the utility classes make a call to get_model_manager(). Of course, there would have to be a bit of setup in the event that the model manager hadn't already been initialized.

There just doesn't seem to be a good way for utility classes to access the model manager service in the running app without going through the context. One out would be to have the model manager set a singleton in the way that the configuration service does, thereby allowing the utility classes make a call to get_model_manager(). Of course, there would have to be a bit of setup in the event that the model manager hadn't already been initialized.

Do my changes in these two commits not do this?
feat(backend): lift managed model loading out of lama class
feat(backend): lift managed model loading out of depthanything class

There just doesn't seem to be a good way for utility classes to access the model manager service in the running app without going through the context. One out would be to have the model manager set a singleton in the way that the configuration service does, thereby allowing the utility classes make a call to get_model_manager(). Of course, there would have to be a bit of setup in the event that the model manager hadn't already been initialized.

Do my changes in these two commits not do this? feat(backend): lift managed model loading out of lama class feat(backend): lift managed model loading out of depthanything class

Sure. Those look good.

Sorry, no we need to do the same pattern for that last processor, DWOpenPose - it uses ONNX models and I'm not familiar with how they work. I can take care of that but won't be til next week.

Sorry, no we need to do the same pattern for that last processor, DWOpenPose - it uses ONNX models and I'm not familiar with how they work. I can take care of that but won't be til next week.

I'll take a look at it Friday.

I've refactored DWOpenPose using the same pattern as in the other backend image processors. I also added some of the missing typehints so there are fewer red squigglies.  I noticed that there is a problem with the pip dependencies. If the onnxruntime package is installed, then even if onnxruntime-gpu is installed as well, the onnx runtime won't use the GPU (see https://github.com/microsoft/onnxruntime/issues/7748). You have to remove onnxruntime and then install onnxruntime-gpu. I don't think pyproject.toml provides a way for an optional dependency to remove a default dependency. Is there a workaround?

I noticed that there is a problem with the pip dependencies. If the onnxruntime package is installed, then even if onnxruntime-gpu is installed as well, the onnx runtime won't use the GPU (see https://github.com/microsoft/onnxruntime/issues/7748). You have to remove onnxruntime and then install onnxruntime-gpu. I don't think pyproject.toml provides a way for an optional dependency to remove a default dependency. Is there a workaround?

I think we'd need to just update the installer script with special handling to uninstall those packages if they are already installed. It's probably time to revise our optional dependency lists. I think "cuda" and "cpu" make sense to be the only two user-facing options. "xformers" is extraneous now (torch's native SDP implementation is just as fast), so it could be removed.

Thanks for cleaning up the pose detector. It would be nice to use the model context so we get memory mgmt, but that is a future task.
I had some feedback from earlier about the public API that I think was lost:

Token: When would a node reasonably provide an API token? We support regex-matched tokens in the config file. I don't think this should be in the invocation API.

Timeout: Similarly, when could a node possibly be able to make a good determination of the timeout for a download? It doesn't know the user's internet connection speed. It's a user setting - could be globally set in the config file and apply to all downloads.

If both of those args are removed, then load_ckpt_from_path and load_ckpt_from_url look very similar. I think this is maybe what @RyanJDick was suggesting with a single load_custom_model method.
Also, will these methods work for diffusers models? If so, "ckpt" probably doesn't need to be in the name.

Thanks for cleaning up the pose detector. It would be nice to use the model context so we get memory mgmt, but that is a future task.
I had some feedback from earlier about the public API that I think was lost:

Token: When would a node reasonably provide an API token? We support regex-matched tokens in the config file. I don't think this should be in the invocation API.

Timeout: Similarly, when could a node possibly be able to make a good determination of the timeout for a download? It doesn't know the user's internet connection speed. It's a user setting - could be globally set in the config file and apply to all downloads.

If both of those args are removed, then load_ckpt_from_path and load_ckpt_from_url look very similar. I think this is maybe what @RyanJDick was suggesting with a single load_custom_model method.
Also, will these methods work for diffusers models? If so, "ckpt" probably doesn't need to be in the name.

I'll remove the arguments and consolidate the two calls. Diffusers loading is NOT supported right now, so ckpt needs to stay in the names.

Probably doesn't make sense to spend time on the onnx loading. This is the only model that uses it.

Right now the regex token handling is done in a part of the install manager that is not called by the simplifed API. I'll move this code into the core download() routine so that tokens are picked up whenever a URL is requested.

Sounds good.

I think you're saying this should be a global config option and I agree with that. Can we get the config migration code in so that I have a clean way of updating the config?

I don't think any migration is necessary - just add a sensible default value. I'll check back in on the config migration PR this week.

Not currently. It only works with checkpoints. I'd planned to add diffusers support later, but I guess I should do that now. Converting to draft.

Ok, thanks.

The onnxruntime model loading architecture seems to be very different from what the model manager expects. In particular, the onnxruntime.InferenceSession() constructor doesn't seem to provide any way to accept a model that has been read into RAM or VRAM. The closest I can figure is that you can pass the constructor an IOBytes object to a serialized version of the model in memory. This will require some architectural changes in the model manager that should be its own PR.

I've played with this a bit. It is easy to load the openpose onnx sessions into the RAM cache and they will run happily under the existing MM cache system. However, Onnx sessions do their own internal VRAM/CUDA management, and so I found that for the duration of the time that the session object is in RAM, it holds on to a substantial chunk of VRAM (1.7GB). The openpose session is only used during conversion of an image into a pose model, and I think it's better to have slow disk-based loading of the openpose session than to silently consume a chunk of VRAM that interferes with later generation.

@psychedelicious This is ready for your review now. There are now just two calls: load_and_cache_model() and download_and_cache_model() which return a locally cached Path and LoadedModel respectively. In addition, the model source can now be a URL, a local Path, or a repo_id. Support for the latter involved my refactoring the way that multifile downloads work.

@psychedelicious I just updated the whole thing to work properly with the new (and very nice) Pydantic-based events. I've also added a new migration. Please review when you can. This merge took me over an hour to resolve and I'd like to avoid repeating the experience.

I removed a number of unnecessary changes in invocation_context.py, mostly extraneous type annotations. If mypy is complaining about these, then that's a mypy problem, because all the methods are annotated correctly.

@psychedelicious I've addressed the remaining issues you raised. Thanks for a thorough review.

I removed a number of unnecessary changes in invocation_context.py, mostly extraneous type annotations. If mypy is complaining about these, then that's a mypy problem, because all the methods are annotated correctly.
I also moved load_model_from_url from the main model manager class into the invocation context.

Yes, mypy is having trouble tracking the return type of several methods. I haven't figured out what causes the problem and don't want to add a # type: ignore. But maybe I should 'cause I'm not ready to turn to pyright.

Yes, mypy is having trouble tracking the return type of several methods. I haven't figured out what causes the problem and don't want to add a # type: ignore. But maybe I should 'cause I'm not ready to turn to pyright.

We shouldn't add # type: ignore, that will stop all type checkers from doing anything - including pyright. The places where you made code quality concessions to satisfy mypy involve very straightforward types - either your mypy config is borked or mypy itself is borked. FWIW, I've found pyright to be much faster, more thorough and more correct than mypy.

@RyanJDick Would you mind doing one last review of this PR?

Yes, mypy is having trouble tracking the return type of several methods. I haven't figured out what causes the problem and don't want to add a # type: ignore. But maybe I should 'cause I'm not ready to turn to pyright.

We shouldn't add # type: ignore, that will stop all type checkers from doing anything - including pyright. The places where you made code quality concessions to satisfy mypy involve very straightforward types - either your mypy config is borked or mypy itself is borked. FWIW, I've found pyright to be much faster, more thorough and more correct than mypy.

You've convinced me. I've switched to pyright!

@RyanJDick Would you mind doing one last review of this PR?

Looks like 43/44 files have changed since I last looked 😅 . I'll plan to spend a chunk of time on this tomorrow.

@RyanJDick Can narrow that down to reviewing invocation_context.py, which changes the public API and is more important to get right the first time. Thanks.

@RyanJDick I've fixed the issues you identified.


[CocoaSpice] Working sound

Through gstreamer

I changed some codes about sound...and it seems to work well.
Test pass on XP, Win 7, Win 8.1, Win 10


scvi-tools 1.2.0

[ ] Bump version in pyproject.toml
[ ] If patch release, backport version bump PR into the appropriate branch. Else, create a new
branch off main with the appropriate rules
[ ] Trigger a Docker image build in scvi-tools-docker
targeting the release branch
[ ] After image builds and pushes to the registry, run the tutorials
using the new image
[ ] Publish a new release on the tutorials repo off main after all tutorials changes have been merged
[ ] Create a new branch off main in the main repo and run git submodule update --remote, and
then merge the PR, with an appropriate backport as needed
[ ] Run the release workflow
[ ] Check that the version updates correctly on PyPI
[ ] Build new Docker images with the stable and semantic versioning tags
[ ] Check that the feedstock repo updates correctly
[ ] (Optional) Post threads on Discourse and Twitter

Hey @martinkim0 just out of curiosity, when is v 1.2 going to release? :) Would love to test the hyperparameter tuning with Ray for some label transferring
Thanks!

Hi @Rafael-Silva-Oliveira, right now it's looking like the end of the month. Regarding #2895, it's a deprecation warning, so it should be OK to use the current version of Ray hyperparameter tuning with no problem :)

Hi @Rafael-Silva-Oliveira, right now it's looking like the end of the month. Regarding #2895, it's a deprecation warning, so it should be OK to use the current version of Ray hyperparameter tuning with no problem :)

Thank you for the reply, I think I'll wait for the new version since it just keeps giving me errors such as this one:

>>> results = tuner.fit(
...     adata=adata_to_annotate,
...     metric="validation_loss",
...     search_space=search_space,
...     num_samples=100,
...     max_epochs=20,
... )
2024-08-06 17:37:58,737 ERROR services.py:1329 -- Failed to start the dashboard , return code 1
2024-08-06 17:37:58,739 ERROR services.py:1354 -- Error should be written to 'dashboard.log' or 'dashboard.err'. We are printing the last 20 lines for you. See 'https://docs.ray.io/en/master/ray-observability/ray-logging.html#logging-directory-structure' to find where the log file is.
2024-08-06 17:37:58,740 ERROR services.py:1398 --
The last 20 lines of /mnt/scratch/tmp/ray/session_2024-08-06_17-37-49_487509_1278064/logs/dashboard.log (it contains the error message from the dashboard):
  File "/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/ray/dashboard/dashboard.py", line 75, in run
    await self.dashboard_head.run()
  File "/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/ray/dashboard/head.py", line 325, in run
    modules = self._load_modules(self._modules_to_load)
  File "/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/ray/dashboard/head.py", line 219, in _load_modules
    head_cls_list = dashboard_utils.get_all_modules(DashboardHeadModule)
  File "/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/ray/dashboard/utils.py", line 121, in get_all_modules
    importlib.import_module(name)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/ray/dashboard/modules/dashboard_sdk.py", line 10, in <module>
    from pkg_resources import packaging
ImportError: cannot import name 'packaging' from 'pkg_resources' (/mnt/work/RO_src/venv/stnav_venv/lib/python3.10/site-packages/pkg_resources/__init__.py)
2024-08-06 17:38:02,984 INFO worker.py:1724 -- Started a local Ray instance.
[2024-08-06 17:38:04,337 E 1278064 1278064] core_worker.cc:215: Failed to register worker 01000000ffffffffffffffffffffffffffffffffffffffffffffffff to Raylet. IOError: [RayletClient] Unable to register worker with raylet. No such file or directory

Hopefully version 1.2.0 will improve usability as well!
Thanks


Restrict which roles can be used from each platform

For example discord we assign roles, or make selective ones available, where reddit allows for roles to be inputted by the user.

https://github.com/socialbaking/karma/blob/8a89b6a4cd0368f9394a2a9733274bac1f957399/src/karma/listen/auth/reddit.ts#L275
The reddit code that I was worried about restricts already to just a single flair, which is self assigned, and not considered trusted
Later we will pick up on "Verified Industry" from reddit too, as it is moderator assigned, but not right now.


[VS Code] An error occurred while sending the request.

Error:
An error occurred while sending the request.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.379

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.24.1

platformName
MacOS

platformVersion
17.6.0

@D3xian Thank you for reporting this error. Would you be able to provide more information about the issue? You can get your logs by running the "Live Share: Export Logs" command in VS Code. If you could attach them to this issue or email them to<EMAIL_ADDRESS>that would help us investigate it further.

@D3xian Can you check to see whether you have Auto Proxy Discovery enabled in your System Preferences -> Network settings (underneath Advanced, then Proxies)? This appears to be a common cause for this error, and turning it off may resolve it for you. We're tracking this issue via #447, so I'm going to close this as a duplicate, but let me know if this unblocks you or not. Thanks!


Ability to delist rogue creators

This is a DIP for setting am Ability to delist rogue creators.
See the DIP for details.

I have converted this PR to a draft for reassignment of the DIP number, refinement of description, sharing of purpose, and addition of codes.


DRAFT PoC of getting close to 99%

@colleend this is just FYI. It is not meant to be merged. I need to split it in different clean PRs for fwcd.
I also need to wait for your recent PR to be accepted so I can rebase on it (no worry, no hurry).

should we close this draft out?

Yes!


False tags from songs outside of library

Describe the bug
When opening a song from outside of the library, some tags may show false values.
To Reproduce
Steps to reproduce the behavior:

Open a song outside of your library

Actual tags: (Mp3Tag)

Expected behavior
Should show all tags like embedded into the file.
System Information:

OS: Windows 10
Affected App Version: =<0.8.1-alpha

What metadata can you see on the app?
I intentionally skipped some metadata such as comments since I thought they wouldn't be much of use.

Well, like in the previous issue, none, though here I'm talking about the artist being shown as "Unknown artist".


Clarifications on numeric literals

Belief in negative numeric literals creates false expectations regarding precedence conflicts (see #971)

This pull request is OK. However, let's keep it open until this is resolved (or alternatively, open another issue for that).

That's actually interesting that the symbol which I can't type and the Inf have different precedence.

It is not interesting, it is sad.

Yeah, I'm gonna go with both interesting and sad. And implementation
specific and not necessarily correct by spec.
.
On Thu, Oct 27, 2016 at 12:53 PM, Aleks-Daniel Jakimenko-Aleksejev <
<EMAIL_ADDRESS>wrote:

It is not interesting, it is sad.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/pull/991#issuecomment-256750957, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACVdr5-wSZxAQgUtMG_kpoQdg5Ah6glSks5q4QE9gaJpZM4KhpaB
.

Thanks for the PR.
For -Inf: it's neither interesting nor sad, but a bug. It's an unwanted sideeffect of making -Inf work as literal in signatures and is to be fixed soon.


Docs: update developer docs and add openapi spec

Changes

update developer docs with debugging instructions using curl
add OpenAPI Specification for REST endpoints
add minimal REST API documentation
remove old diagram, replace with mermaid diagrams
remove preceding '$' from shell code-blocks, enables direct copy
fix markdown style issues
fixes #351

Signed-off-by: Avinal Kumar<EMAIL_ADDRESS>/kind documentation
Testing

Please use https://editor-next.swagger.io/ and import the OpenAPI file to verify the endpoints.
Open markdowns having mermaid diagram in preview mode to see the rendered diagram.

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/hold will be adding filters docs as well.

/unhold
/retest

cc @alan-ghelardi @dibyom @sayan-biswas

/lgtm
There are only a few small nits left that can be taken up as follow-up PRs. I don't think we should block on these.


Trigger production CLI release for v0.15.3

Trigger production CLI release for v0.15.3
/hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/LGTM

/unhold
/approve


Improve documentation

It'd be nice if the README contained some lines on:

The requirement that a Meter resource be deployed in order for metering to work properly
How to get some debug output from the operator. E.g by modifying the pod spec in the ClusterServiceVersion and adding an environment variable like:

- name: QUARKUS_LOG_LEVEL
  value: DEBUG

+1 @jamesnetherton
Furthermore, some information on what to do w/ the additional resources as MeteringConfig, Reports etc. (see e.g. https://access.redhat.com/documentation/en-us/red_hat_amq_streams/2.6/html-single/deploying_and_managing_amq_streams_on_openshift/index#metering-resources-str) would be beneficial to many.


Add a Redis component

In particular, we want to fail fast if we don't have a Redis connection, so start should probably ping the DB


fix: set strip_path to false by default

strip_path was set to false by default but was changed in 0.2.1
release to true.
See #193

Codecov Report

Merging #194 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   20.75%   20.74%   -0.01%
==========================================
  Files          24       24
  Lines        2313     2314       +1
==========================================
  Hits          480      480
- Misses       1792     1793       +1
  Partials       41       41

Impacted Files
Coverage Δ

internal/ingress/controller/kong.go
1.14% <0%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4765c57...5f2e30c. Read the comment docs.


Swift module with 0.6.0-rc

I'm getting the following error with the snippet below. As far as I can tell this is how the docs say wire a Swift module. What am I missing?

Unknown argument type 'NSObject' in method -[SocketIO emit:items:]. Extend RCTConvert to support this type.

# SocketBridge.m
#import "RCTBridgeModule.h"

@interface RCT_EXTERN_MODULE(SocketIO, NSObject)

RCT_EXTERN_METHOD(emit:(NSString*)event items:(NSObject*)items)

@end
``

Sorry about that - I forgot to add NSObject as a supported RCTConvert type.
It's generally better to be specific about the type, so use NSArray, NSDictionary, or whatever the actual type is. But if you aren't sure, or it's a mixed type (i.e. could be several different types) then use id, like this:
RCT_EXTERN_METHOD(emit:(NSString*)event items:(id)items)

:boom: items:(id)items does the trick. Thanks for the tip @nicklockwood!


correct classpath references and java version

updated classpath references to existing versions of the libraries.
Java version upgraded to 7 as some Java 7 specific features are used.
corrected references to old project name (grefine-all) in the launch script

@fmaali The build broke... Hmm, I wonder if its an env issue ?  Can you take a look  https://travis-ci.org/OpenRefine/OpenRefine/jobs/255029967

@thadguidry I guess it is an env problem... seeing this error on Travis:
Error: Error while uploading main/tests/data/food.csv to OpenRefine
tests run fine locally. Is there a way to re-trigger the build?

@fmaali I'm checking that now...

@fmaali OK, there's some weirdness happening on Travis for me... its just spinning when I try to do a sync....that doesn't seem right.  I'll try again tomorrow (although their status light shows green like all systems are OK)

@fmaali
build 364 failed https://travis-ci.org/OpenRefine/OpenRefine/builds/255029966
build 365 passed https://travis-ci.org/OpenRefine/OpenRefine/builds/255062631
I think we're good now.

thanks for looking after this @thadguidry


Add "latest" version of API docs to provide more durable link targets

This will allow external referrers to link to (for example)
https://kubernetes.io/docs/reference/generated/kubernetes-api/latest/#pod-v1-core
which might continue to work for many many versions instead
of the 5 or so that we support for current versions.

Hmm... it's working for the root page, but none of the assets. Looking at netlify redirect syntax to see if it supports wildcard-style matching.
/hold

Looks like it's working now. Try, for example, https://deploy-preview-21931--kubernetes-io-master-staging.netlify.app/docs/reference/generated/kubernetes-api/latest/#pod-v1-core
I'll squash it and it should be ready for review.
/hold cancel

@sftim It's not a true redirect, it's a transparent redirect, or a rewrite. A 200 is how Netlify handles rewriting paths. So with the 200, the server will serve files from the target location but the client will not know about it and will see the original URL, and will get back the requested content without a redirect. See https://docs.netlify.com/routing/redirects/rewrites-proxies/ for more information.
I'm proposing it this way so that the URL the user sees if they visit a "latest" version stays at the "latest" version of the URL as they browse around so once they find the object they want to link to and copy the URL, it will be the "latest" version, instead of (for example) the "v1.18" version of the URL it would be if we used a 30X HTTP redirect.
If you visit the URL I posted in the above comment you should be able to see this behavior in action if you watch the browser's URL. It should remain at the "latest" version without a redirect.

Reviewing and holding to consider a number of options.
/hold

Related to PR #21929

/cc @jimangel @kbarnard10 @zacharysarah

I recommend moving the discussion about how to approach this into an issue. Then, reviewers can verify that the PR implements the agreed approach.
@joelsmith how does that sound?

:wave: @joelsmith I love the idea, curious if you're still interested in working on it?
I agree with @kbhawkey & @sftim that this adds additional maintenance on the release cycle and there might be a better approach that is more hands-off.
Let us know how we can help! Thanks!

Hi @joelsmith . Sorry for the delay in getting back to you.
At this point, I think the redirect change would work. The question is maintaining the link.
I have an outstanding PR to add a small set of the previous API content back to the current location.
This would remove the need for the other API ref. redirects. This script could be run at release time.
I could add an update of the "latest" redirect path to this script so that the link was maintained.
Another possibility is to add a reference/generated/kubernetes-api/latest directory alongside the other API directories
and maintain the content as part of the "update script" (copy or link the  files (2) to this directory).
This is also a quick change to the script and does not involve maintaining the _redirect file. What do you think?

Let's go with this change and work on the maintenance of the redirect. I am happy to do this.
@joelsmith , Do you agree that there should only be ONE "latest" url -- the path associated with the
current release? Or do you envision that a "latest" path would be available in the snapshot versions,
such as https://v1-17.docs.kubernetes.io/? I am thinking that the redirect would be removed (or the latest directory would be removed) before the snapshot is created and then reapplied once the release is final.
@tengqm @sftim Do you have any objections to moving this PR forward?

Could we use a 307 (temporary) redirect for now and then consider a Netlify transparent rewrite as a separate change?
You can still link to the latest version of an API with the 307 redirect but you have to be a bit more intentional about it.
(Another option for that: we could provide a permalink and a current link and let people choose which to use).

Long term I think we want https://kubernetes.io/ to host API documentation for historical releases as well, but that needs discussing properly in an issue.

Sorry that I haven't gotten back to this, it's been a busy month. I think either approach (copied content vs. redirect) provides what I'm hoping for. I agree that it doesn't make sense for the snapshots to have a latest; that's something I didn't think much about.
I prefer transparent redirect to 307, but I can see the case for both. I'd like to be able to browse the "latest" version, then copy the URL without having to edit it. With the 307, I have to edit every URL I copy. So, yes, much more intentional that way.
Thanks, all, for looking into this for me.

With https://developers.google.com/season-of-docs/docs/participants/project-cncf-feloy underway, would it be possible to hold or close this PR until GSoC is completed (3 months). Also, it might make sense to scope into the project.
/cc @feloy

I plan to close this pull request. In coordination with the site's GSOD project, look into creating several links or ways of accessing
the API from the docs site. For more information, see issue #23809.
/close


Fix a memory leak in the HTC vive driver

Thanks, i had this in a local commit already (Vive is still under construction quite a bit), but no reason not to merge this! :)


AMPI: use zero-copy direct API to avoid intermedate copies

Original date: 2019-05-03 17:45:18
Original PR: https://charm.cs.illinois.edu/gerrit/3080

For messages sent within the same PE or process, we pack an
AmpiNcpyShmBuffer object into the AmpiMsg data. This allows direct
handling of DDTs in a single message, and avoids the cost of memory
pinning when it is unnecessary. We still have to handle the case where
the recv'er turns out to not be in the same process, so the recv'er
then requests a put() of the message payload.
For messages sent across processes, we pack a CkNcpyBuffer object into
the AmpiMsg data and use that to do a get() from the recv'er.
Change-Id: I9e8126bc8bf321b4a5ab64e08b3283e448fec4c0

This patches fixes the failures in tests/ampi/datatype that have been silently happening for a couple months

Needs another review

Still has a conflict


If the transaction fails, the log data should also be revert

Referring to This Answer, we have tested it on the Ropsten and verified that this answer is correct.
A test contract like below:
pragma solidity ^0.7.0;
contract testlog {
    event Log(uint256 a);
    function test() public {
        emit Log(1);
        revert();
    }
}

Submit a test call and get the transaction receipt like:
{
   "blockHash":"0x9281ac790fe66da2fe8dd7b4c39836de45322064c05a1b9910650a4ae9dc62ac",
   "blockNumber":14,
   "contractAddress":null,
   "cumulativeGasUsed":22250,
   "from":"0xa3503704240f764cf91faba1775754b42fd2040f",
   "gasUsed":22250,
   "logs":[
      {
         "address":"0xfCA29754bB5d5a60F96cfba820F7e76A8E1b6f97",
         "blockHash":"0x9281ac790fe66da2fe8dd7b4c39836de45322064c05a1b9910650a4ae9dc62ac",
         "blockNumber":14,
         "data":"0x0000000000000000000000000000000000000000000000000000000000000001",
         "logIndex":0,
         "removed":false,
         "topics":[
            // Here should be empty
            "0x909c57d5c6ac08245cf2a6de3900e2b868513fa59099b92b27d8db823d92df9c"
         ],
         "transactionHash":"0x9281ac790fe66da2fe8dd7b4c39836de45322064c05a1b9910650a4ae9dc62ac",
         "transactionIndex":0,
         "transactionLogIndex":"0x0",
         "id":"log_428547dd"
      }
   ],
   "logsBloom":"0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008000000000000000000000100000004000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004000000000000020000000000000000000000000000000000000000",
   "status":false,
   "to":"0xfca29754bb5d5a60f96cfba820f7e76a8e1b6f97",
   "transactionHash":"0xda28bd8ac19582fbc02d3813703681df9d81a4f7de308ff08f73b205d5625b63",
   "transactionIndex":0
}

Another strange problem is that the execution result on my machine is not equal to the ci in the Contract test.
Test result in my ubuntu 20.04:

Test result in CI:

The same test, two different hash? I have no idea about this so far.

@sorpaas
This pr is ready for review, please check it out and give me feedback if you have any questions.

I'm fixing an issue in #317. After that I'll take a look at this!

We also need to fix evm crate. It has the same issue.


DatePickerPopUp Format is not by ISO standards?

Using format string "DD.MM.YYYY" returns
Expected: "19.06.2019".
Current: "DD.06.YYYY".
Is Dateparser not using ISO standards to format date's?

I'm using Moment to get localized date format string.
Moment returns "DD.MM.YYYY" for language 'sl' but Dateparser expects "dd.MM.yyyy".
Why is that?

So, I don't have a great answer, since I'm just (barely) maintaining this code base, and didn't write it. However, it looks like angular's dates use dd not DD:
https://docs.angularjs.org/api/ng/filter/date
Can't seem to find a reason why, but I'll bet Dateparser was written to match Angular's date.

Marking this as wontfix, because (like the original authors) I feel it's better to be consistent with the underlying framework.
I get the frustration, and would definitely entertain the idea of allowing the behavior to be changed as desired, but for now, I don't have any plans on changing this.


Import suggestions and individual Lodash modules

Lodash provides individual modules for each of its functions, e.g.
import maxBy from 'lodash/maxBy';

However, currently TypeScript/VSCode will not use these files for import suggestions:

… which creates
import { maxBy } from "lodash";

maxBy

What would it take for TypeScript/VSCode to suggest these files?
I'm sure this pattern applies to other modules as well, not just Lodash.

This issue was moved to Microsoft/TypeScript#25236


[Bug] SageMaker fails to start due to policy issue.

Describe the bug
When I start a sagemaker workspace, it fails with an error message. As far as I remember, sagemaker was able to start a few days ago.
To Reproduce
Steps to reproduce the behavior:

regular SWB installation
start sagemaker,

Expected behavior
SageMaker should start
Screenshots

The relevant error message from CloudFormation is
User: arn:aws:sts::948662388200:assumed-role/prod-oh-sw-LaunchConstraint/servicecatalog is not authorized to perform: sagemaker:CreateNotebookInstanceLifecycleConfig on resource: arn:aws:sagemaker:us-east-2:948662388200:notebook-instance-lifecycle-config/BasicNotebookInstanceLifecycleConfig-pR9dIu4ZjVhk because no identity-based policy allows the sagemaker:CreateNotebookInstanceLifecycleConfig action (Service: AmazonSageMaker; Status Code: 400; Error Code: AccessDeniedException; Request ID: ca7030e3-8810-4b6e-9e90-fe062eed3bca; Proxy: null)

Versions (please complete the following information):

Release Version installed: latest master
Is the deployment from a forked version of the repository? no.

Additional context

I checked service catelog, the product is associated with a role: prod-oh-sw-LaunchConstraint
The IAM role prod-oh-sw-LaunchConstraint exists and with policy SageMakerLaunchPermissions, which contains lines

        {
            "Action": [
                "sagemaker:DescribeNotebookInstanceLifecycleConfig",
                "sagemaker:CreateNotebookInstanceLifecycleConfig",
                "sagemaker:DeleteNotebookInstanceLifecycleConfig"
            ],
            "Resource": "arn:aws:sagemaker:*:*:notebook-instance-lifecycle-config/basicnotebookinstancelifecycleconfig-*",
            "Effect": "Allow"
        },

So the policy does exist. I do not know what else have gone wrong.
3. The only thing I did in between was perhaps adding a role to my account that allows me to assume admin role of another account, which should not affect this existing role.
What else should I do to debug?

Hi BoPeng, SageMaker has released an update that makes the policy case sensitive. The current workaround is to update the policy to use BasicNotebookInstanceLifecycleConfig-* and BasicNotebookInstance-* for the resources in that policy. We are currently working on a PR that will fix this once the HostingAccount and MainAccount templates are updated through CloudFormation.

Thanks! I was suspecting something like that but I do not know AWS well enough to know if policies are case sensitive. I will manually change the policies.

Here is the PR that should fix the issue: https://github.com/awslabs/service-workbench-on-aws/pull/1177
Note that we opted for ? instead of the exact case to make the change backwards compatible with both capitalized and uncapitalized letters.

I can confirm that the fix in #1177 works.


feat(git-node): add support for the --gpg-sign git flag

I've also extended the max line length from 80 to 100 as it was making less readable to keep it at 80 IMO.

I personally set this in my gut config. What's the advantage of this flag compared to it ?

The flag let's you select a specific keyid to sign the commit with.

In the git config you can set ˋuser.signingkey` with the key I'd

If you have set a specific key id in your git config, the flag lets you specify a different one.

I still don't understand the use case. Don't you always use the same key for the node repo?

No, I usually don't sign my commits for the node repo (why would I, the CQ would sign them for me), but in the rare cases when I need to push manually to main, I have to do the git commit --amend --no-edit -S dance, and it seems easy to add the flag to ncu instead.


Misalignment in API Manager logo in Login page

Description
Misalignment in API Manager logo in the login page.

Steps to Reproduce

Go to the login page

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

This issue comes from the Authentication Endpoint.

Closing as this is fixed with https://github.com/wso2/product-apim/pull/13460


Update experimental-features.md

Fix copy-paste error.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sequencer don't forget that 3.5.x is the published branch so we need to backport to have this show up

@Mergifyio backport 3.5.x


fix: broken link due to spacing

the first paragraph,

"Say what you mean, simply and directly." - [Brian Kernighan] (https://en.wikipedia.org/wiki/The_Elements_of_Programming_Style)

which brokes the link since the markdown syntax is incorrect, I think the best practice for this best practice is to fix the best practice.
this PR fixes a broken link since the space between [] and () in the markdown, should not appear here.

sorry, missed your earlier PR.  this has been fixed in commit 7b9a1c1330973e14f9486af1d2760f798eff1ce9 now.