Added methods for user, like, comment and post

In this milestone I used models to insert data:
I added
- user method
- post method
- like method
- and comment method

Hi @Davidosky007, Kindly, can you tell me what's wrong with this PR, please?

please?

Most of the requirements for the project you submitted for where not implemented

@Davidosky007 I see the requirements, kindly I asked you what should I add to the project, please.

@Davidosky007 I see the requirements, kindly I asked you what should I add to the project, please.

I invalidated it because you didn't do any of the requirements, so implement all the requirements for this milestone and submit for another review

hum
On Fri, 19 Aug 2022 at 12:08, David Bassey @.***> wrote:

@Davidosky007 https://github.com/Davidosky007 I see the requirements,
kindly I asked you what should I add to the project, please.
I invalidated it because you didn't do any of the requirements, so
implement all the requirements for this milestone and submit for another
review
—
Reply to this email directly, view it on GitHub
https://github.com/stanleySimeon/blog-app/pull/2#issuecomment-1220546189,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVYCZFOL4HZUIRWSP3RKRMLVZ5TKJANCNFSM566UDTKA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks a lot


copy only required src file in HelloWorldTest check

This is optional. There are a lot of files copied from
https://github.com/eth-cscs/reframe/tree/master/cscs-checks/prgenv/src
when for most checks only 1 file is needed.
Would be nice to have only the required src copied OR clean a bit with something like:

class HelloWorldTestMPI(HelloWorldBaseTest):

        self.prebuild_cmd = [
            'cp %s mysrc' % self.sourcepath,
            'rm -f *.cpp *.c *.f90 *.txt *.cl *.ref',
            'mv src %s' % self.sourcepath,
        ]

I think a cleaner solution would be to restructure the source directory by separating the sources in different subirectories. Then each check could set its sourcesdir accordingly. I think we do something similar with the profiling and debugging tools.

done with https://github.com/eth-cscs/reframe/pull/1370


JS errors when trying to make a contribution

Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0
Steps to reproduce:
1.Open an addon with contributions
2.Try to contribute
3.Observe the console
Expected results:
No errors in console
Actual results:
Error: Permission denied to access property "toString"
Please see screencast for this bug : http://screencast.com/t/YRIyip1wV
NOTES:
I can see this warning too "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/" . Please let me know if a different issue is needed for this.

I couldn't see this specific error initially but then I found this: https://stackoverflow.com/questions/13100611/replace-url-from-youtube-to-embed-code-error-permission-denied-to-access-prop
It appears to only be surfaced when flash is enabled. As such it's nothing that we can resolve.

I can see this warning too "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help http://xhr.spec.whatwg.org/" . Please let me know if a different issue is needed for this.

Probably worth filing a separate issue for this (although it will be low priority) and we can investigate if there's an easy way to resolve it. I don't expect it will cause any issues as it's just a deprecation warning.


Update Design section of DG

Following issues will have to be resolved:

[x] #145
[x] #146
[x] #147
[x] #148
[x] #149
[x] #150
[x] #151
[x] #152
[x] #153
[x] #154
[x] #269

All the tracked issues have been resolved


fix - Negated character classes #26 (#1)

fix - Negated character classes #26
-Add new TimesMethod that allow only one parameter passed, ignoring
optional time[s]. Will raise Syntax exception if more parameters passed.
-Use TimesMethod for 'exactly' and 'atLeast' functions.

Current coverage is 97.13% (diff: 100%)

Merging #37 into master will increase coverage by 0.06%

@@             master        #37   diff @@
==========================================
  Files            16         17     +1
  Lines           410        419     +9
  Methods          83         84     +1
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            398        407     +9
  Misses           12         12
  Partials          0          0

Powered by Codecov. Last update 4055571...bf95ed1

Thanks for the updated pull request. Looks good now. If you could refactor the syntax a bit to fit PSR-2, as well as the indentation, then I'm happy to merge this PR.

Awesome! Thanks a lot :)

Thanks :)


k8s: Update k8s libraries to 1.21.1

Also update test libraries to latest patch releases
Signed-off-by: Nate Sweet<EMAIL_ADDRESS>Update k8s libraries to 1.21.1

test-backport-1.10

test-1.21-4.9


Fix court params - it is EWCA (England & Wales...) not ECWA

Going to merge this myself as it's an urgent fix - links are wrong on the website


What's the difference between yahoo/LBP and cat/LBP models

@wellflat ?

sorry for my late reply.
yahoo/LBP:  YahooJapan logo detection model (sample)
cat/LBP: cat face detection model
both models using LBP feature


Filter Pages plugin removes asset files (arguably unexpected -- documentation issue?)

Version
2.1.2
Platform
linux
What steps will reproduce the bug?
I use the Filter pages plugin to filter out 'draft' blog posts:
site.use(filterPages({
  fn: (page) => {
    return page.data.draft === false && page.data.publish === true;
  }
}));

I am also using the Lightning CSS plugin which, per the docs, loads *.css files as 'assets'.
How often does it reproduce? Is there a required condition?
always.
What is the expected behavior?
Intuitively, since the distinction between 'pages' and 'assets' seems fairly fundamental to Lume's architecture, I didn't expect it to affect 'assets'. I.e. the use of 'pages' in the plugin name suggests it won't affect assets since there is the distinction between site.loadPages() and site.loadAssets().
What do you see instead?
However, the plugin apparently affects all loaded files, and since the CSS files have no metadata, they fail the test and are removed.
Additional information
Of course, this behaviour is perfectly reasonable, and it is easy to work around by checking for asset === false in the filter function. However, It might be a good idea to document this with an example. And perhaps consider changing this in a future major version: rename filterPages to filterFiles, or have two functions filterPages and filterAssets (though filtering assets seems an unlikely use-case)?
If the resolution is just a matter of documentation, I would be happy to provide a pull request if that is helpful for you.

Hi.
Yes, probably it's unclear documentation. A pull request from you would be awesome, thanks!
Just clarify that the plugin has the extensions option, that by default is *. Maybe the default value should be [".html"] to only filter html pages.
And note that draft pages are ignored automatically, you don't need this plugin for that, unless something is not working fine...


Order By Desc on a column containing nulls values returns wrong results

The default null ordering for desc should be nulls first. But it is doing nulls last.
Postgres:
tpch=# select * from (select cast(null as bigint) union all select 1) T order by 1 desc;
 int8
------

    1
(2 rows)

Presto:
presto:tiny> select * from (select cast(null as bigint) union all select 1) T order by 1 desc;
 _col0
-------
     1
 NULL
(2 rows)

I just saw in another bug that null ordering may be implementation-defined if it's not specified.
If that is the case and this is intentional, I can close. But it might be nice to match behavior of other DBs is there is some consistency that is implemented.

This is actually intentional. It is legal per the SQL specification for <sort specification list>:

If <null ordering> is not specified, then an implementation-defined <null ordering> is implicit. The implementation-defined default for <null ordering> shall not depend on the context outside of <sort specification list>.

We always default to NULLS LAST because users generally do not want to see nulls. The most common use of ORDER BY in Presto is with LIMIT, so having nulls first would often result in a result set with all nulls, which is almost never what the user wants.
But we definitely should document this behavior.

The <null ordering> specification only arrived in SQL:2003, and like many things in the SQL specification, I'm guessing different existing implementations had varying behavior. Though it appears MySQL, PostgreSQL and Oracle all share the same default. SQL Server appears to always do nulls first and does not support explicit null ordering. Thus it seems we are the opposite of Microsoft :)


[Refactor] Simplify C++ interface for sox_io's info func

Currently, torchaudio.info function for "sox_io" backend gets the information via SignalInfo structure in C++.
https://github.com/pytorch/audio/blob/828df46a95310453dda13599a29fa22a1cc049da/torchaudio/csrc/sox/io.h#L14-L32
The signature of the actual function that performs querying looks like following;
https://github.com/pytorch/audio/blob/828df46a95310453dda13599a29fa22a1cc049da/torchaudio/csrc/sox/io.h#L34-L36
When binding this function (making it available on Python), the SignalInfo structure has to be bound before the function. When updating the info function, this forces updating multiple components.
Also the recently added function that performs the same operation on file-like object, which is bound via PyBind11, simplifies this via directly returning tuple object.
https://github.com/pytorch/audio/blob/828df46a95310453dda13599a29fa22a1cc049da/torchaudio/csrc/sox/io.h#L57-L59
get_info_file should also do the same and return tuple object directly.
Steps

Change the interface / implementation of torchaudio.info

get_info_file to return the tuple. The implementation should be swapped from this to this
Update the Python frontend. The construction of AudioMetaData should be replaced with the one with tuple destruction.

Remove the registration.
Remove the interface and the implementation of SignalInfo.

Building and Testing

Install nightly build of PyTorch
Clone repo and build torchaudio# mac
BUILD_SOX=1 MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ python setup.py develop
# linux
BUILD_SOX=1 python setup.py clean develop

Set PATH variable so that the sox command created as a part of torchaudio build process is used.
export PATH="<path_to_torchaudio>/third_party/install/bin:${PATH}"
Run test
Run test with pytest test/torchaudio_unittest/sox_io_backend -v, this should pass after each step 1, 2 and 3.

I can work on this.

I can work on this.

@prabhat00155
Thanks. Let me know if you need help.

@mthrok The PR has been merged and this issue can be closed now, thanks!

Thanks for the contribution!


Bump kernel version to 4.6.2-m9

Note $subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/696892441

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/696892441
Status: success


RTL: Carousel wrong direction on keyboard and touch

Windows 10
Google Chrome 87

@ffoodd
Carousel direction is wrong in RTL when changed by keyboard or touch, however left/right icons works correct on click.

@FaridAghili let's try and use one issue to track your findings please. Choose one of the 3 you have open and list there all your issues.

@XhmikosR
Thanks, listed them all in #32327 and closed others


Fix concourse deployer disk space

What
There are 2 issues with disk space on the deployer:

ephemeral disk definition was for some reason not correctly propagated into the concourse manifest. Moved the definition to a bit different place and it is now correctly rendered. Concourse doesn't seem to use that disk too much though, but it's better to have space available...

the containers are stored on the persistent disk. So it's that one that needs to be big. Increased size. Current pipeline uses 11G, so 40GB should be enough.

Testing
Deploy deployer concourse or apply against existing. SSH into instance to check disk space, you should see st. like:
vcap@7741a213-37e4-4304-7c63-49671ee209c3:/home/vcap# df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/xvda1      2.9G  1.9G  850M  70% /
none            4.0K     0  4.0K   0% /sys/fs/cgroup
udev            2.0G  4.0K  2.0G   1% /dev
tmpfs           396M  356K  395M   1% /run
none            5.0M     0  5.0M   0% /run/lock
none            2.0G  1.1M  2.0G   1% /run/shm
none            100M     0  100M   0% /run/user
/dev/xvdb2       36G   11G   23G  32% /var/vcap/data
tmpfs           1.0M   36K  988K   4% /var/vcap/data/sys/run
/dev/loop0      120M  1.6M  115M   2% /tmp
/dev/xvdg1       40G  108M   38G   1% /var/vcap/store
/dev/loop1       36G   17M   34G   1% /var/vcap/data/baggageclaim/volumes
cgroup          2.0G     0  2.0G   0% /tmp/garden-/cgroup

Who
Not me

Seems like the 50G disk definition is working already and there's no need for more space on persistent disk.


Testing branching method vs forking.

Changed skin import that always prompted file dialogue
fixes #4

And I think you there is an option to delete the source branch upon merging.


LobbyScreen: small css tweaks to get closer to mock

on iphone, this is what the loginlobby screen looks like:

Changing the game content container to not having an additional 8px of padding on the right and left side (as well as the 40>20 px top padding) makes the screen closer to the mock. Also note that copy has changed in the new mock last week to be shorter and more succinct.

also important to double check colors. I am not sure if a color picker was used, but it sometimes distorts readings based on your monitor settings, and can throw off from real colors. The real colors are all in zep (double checked this morning !)

also I just noticed this is different from the player version of the screen, so lets just make sure to note this when making fixes to this.
Decider:

player:

Mockups in zeplin show slight difference in the UI and copy for the decider and the players in the game lobby--in current build, the two lobby screens are identical

Made separate issue for back buttons, closing for copy change - tested as fixed.


Select after insert causes problems when using read replica DBs

In the skipMultiServer() method of the Event class, the current code fires a select query right after an insert. Due to Laravel's support for read and write PDOs on the same connection object, this can create inconsistencies like so:

prod.ERROR: exception 'ErrorException' with message 'Undefined offset: 0' in jdavidbakr\MultiServerEvent\Scheduling\Event:108

My recommendation to avoid this issue is as follows:
public function skipMultiserver() {
	$this->key = md5($this->expression . $this->command);
	// Delete any old completed runs that are more than 10 seconds ago
	DB::table($this->lock_table)
		->where('mutex', $this->key)
		->where('complete', '<', Carbon::now()->subSeconds(10))
		->delete();

	$gotLock = true;
	// Attempt to acquire the lock
	try {
		DB::table($this->lock_table)
				->insert([
				'mutex' => $this->key,
				'lock' => $this->server_id,
				'start' => Carbon::now()
		]);
	} catch (\PDOException $e) {
		$gotLock = false;
	}

	return $gotLock === false;
}

This not only saves an extra query but also solves the issue at hand

Fixed in https://github.com/jdavidbakr/MultiServerEvent/commit/e5b471abfd88359834b6770445723dbd93a47c40


Convert Readme from rst to md

Closes #10 .

Hey @Mordax thanks very much for taking on this conversion.
#9 added some content to the README.rst, would you be able to rebase your branch and convert these additions over as well?

Done ✌

Awesome! Thanks very much, @Mordax :shipit:


Add hrefs to the respective websites of open source events and hackathons.

We are planning to do that.
Would you like to take up this issue!

Ya I would like to take this.

Ya I would like to take this.

Ya I would like to take this.

Ya I would like to take this.


profiler.sh doesn't show any errors if write to file failed

I've tried to run profiler.sh and write output to file which I don't have permission to write.
Script didn't any errors.
It would be nice for troubleshooting and make user experience better to show error if creating/writing output file failed.
covstaging@covstaging [2020-03-18 19:21:34]:/tmp/async-profiler-1.7-linux-x64$ ./profiler.sh -d 60 -f profile.svg 10051
covstaging@covstaging [2020-03-18 19:24:02]:/tmp/async-profiler-1.7-linux-x64$ ls
build  profiler.sh
covstaging@covstaging [2020-03-18 19:24:03]:/tmp/async-profiler-1.7-linux-x64$

After I added permission, all worked fine
covstaging@covstaging [2020-03-18 19:24:24]:/tmp/async-profiler-1.7-linux-x64$ ./profiler.sh -d 60 -f profile.svg 10051
covstaging@covstaging [2020-03-18 19:25:30]:/tmp/async-profiler-1.7-linux-x64$ ls
build  profiler.sh  profile.svg
covstaging@covstaging [2020-03-18 19:25:30]:/tmp/async-profiler-1.7-linux-x64$

Output file is written by the target JVM process, not by the profiler script. If the file cannot be opened, the error message is printed to stderr of the target process (JVM console):
Could not open profile.svg

Unfortunately, the agent library (loaded into JVM) does not have a simple way to communicate its status back to the profiler script. Some kind of IPC would be needed. I was thinking of communicating through a pipe, but this may be tricky, given that the target process can be launched in a different namespace, under a different user etc. I will consider improving IPC on the next iteration of refactoring of the launcher.

I think we can improve Troubleshooting section in readme. It was not clear for me that profiler prints something to stderr of target JVM.


feat: initial implementation

Codecov Report

Merging #1 into master will decrease coverage by 23.33%.
The diff coverage is 76.66%.

@@             Coverage Diff             @@
##           master       #1       +/-   ##
===========================================
- Coverage     100%   76.66%   -23.34%
===========================================
  Files           1        1
  Lines           2       30       +28
  Branches        0       14       +14
===========================================
+ Hits            2       23       +21
- Misses          0        7        +7

Impacted Files
Coverage Δ

src/index.js
76.66% <76.66%> (-23.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3715527...772df71. Read the comment docs.


Incompatible install in (You are running Setuptools on Python 2, which is no longer supported and >>> SETUPTOOLS WILL STOP WORKING <<< in a subsequent release (no sooner than 2020-04-20). Please ensure you are installing Setuptools using pip 9.x or later or pin to setuptools<45 in your environment. If you have done those things and are still encountering this message, please follow up )

Prerequisites

[x] Python 2 is required for this application.
[x] I maintain the software that installs Setuptools (if not, please contact that project).
[x] Setuptools installed with pip 9 or later.
[x] Pinning Setuptools to setuptools<45 in the environment was unsuccessful.

Environment Details

Operating System and version:
Python version:
Python installed how:
Virtualenv version (if using virtualenv): n/a

Command(s) used to install setuptools (and output):

Output of pip --version when installing setuptools:

Other notes

@pganssle, since both you and @jaraco agree that these should be closed and flagged as invalid, should I stop commenting Could you please provide further details? and could you please close these issues since none of them ever responded?

@McSinyx I probably would stop, yeah. We should probably get rid of this template and whatever is encouraging people to submit it blank.

Thanks, and for the context, as per GH-2094, it seems that users (mistakenly) use the template to report that they've encountered the warning.  I found 734eec6e3fca725c6b18cad2fffbd1f3e3a56fa7 but couldn't find the discussion behind it.

Right - I made that change (summarily, without discussion), in the hopes of ferreting out any more details about users encountering the warning. As it turns out, the type of user who is encountering these errors appears to be users inexperienced with open source and incapable of reading the directions.
I do believe it's time to drop support for Python 2 (break the users), but I'll first want to update that bit.ly link to point to some page giving users guidance on what to do if they encounter the warning (now) or the error (after dropping support).


415 Error on POST with Request Object

Framework version: 1.3.2
Implementations: Jersey
OS: Windows 10

Scenario
I want to implement a POST requests that expects a JSON object in the Request Body like in the Pet Store example. To verify I checked out the Pet-Store jersey sample, but it doesn't work either.
Expected behavior
The Request body should be mapped to the Method Parameter of the POST method.
Actual behavior
When an Custom Object is expected as parameter the application returns an 415 Unsupported Media Type Status Code. Expecting a String works. It also works when I run an Unit test that does the request, but not when it is locally deployed using SAM.
Steps to reproduce

Check out and run the Jersey Pet Store example
Do a POST Request to add a Pet

Full log output
* Preparing request to http://localhost:3000/pets/
* Using libcurl/7.57.0-DEV OpenSSL/1.0.2o zlib/1.2.11 libssh2/1.7.0_DEV
* Current time is 2019-09-27T10:11:37.598Z
* Disable timeout
* Enable automatic URL encoding
* Disable SSL validation
* Enable cookie sending with jar of 0 cookies
* Found bundle for host localhost: 0x1a39a0b9680 [can pipeline]
* Re-using existing connection! (#4) with host localhost
* Connected to localhost (<IP_ADDRESS>) port 3000 (#4)

> POST /pets/ HTTP/1.1
> Host: localhost:3000
> User-Agent: insomnia/6.6.2
> Content-Type: application/json
> Accept: */*
> Content-Length: 135

| {
|     "id": "bfbfbb42-2198-4e5d-99b9-03533a09c123",
|     "breed": "Dalmatian",
|     "name": "Bella",
|     "dateOfBirth":<PHONE_NUMBER>188
|   }

* upload completely sent off: 135 out of 135 bytes

< HTTP/1.1 415 Unsupported Media Type
< Content-Type: application/json
< Date: Fri, 27 Sep 2019 10:11:40 GMT
< Content-Length: 0

* Connection #4 to host localhost left intact

Is this running through the SAM CLI @ssindelar?
Jersey returns 415 (as per the Jax Rs specifications) when it cannot find a resource method that matches the the request content type - ie has a @Consumes annotation that matches the request's content type. The sample clearly has the correct annotation and your request is sending the correct Content-Type header. This leads me to believe that for some reason Jersey does not have access to the request headers. Up until not too long ago, there was a well documented issue with SAM CLI not supporting API Gateway's new multiValueHeaders property. The fix for this was released in version 0.17.0 of SAM CLI.
The whole long detour is to say: If you are using SAM CLI, could you make sure that you are running at least version 0.17.0?

I'm sorry. I followed the README.md and installed SAM through npm. But instead of a new version it installed 0.2.11.
With the current SAM version it works fine.


Upgrade to openfeign 10.2.0

https://github.com/OpenFeign/feign/releases/tag/10.2.0

Minor needs to wair for Hoxton

feign-core in version 10.2.0 fixes a bug for the encoding of some characters like the '+'. Have you an idea of when you will upgrade ? Thanks

It will be part of our Hoxton Release, for release dates please see https://github.com/spring-cloud/spring-cloud-release/milestones

@spencergibb  and @ryanjbaxter, we just release 10.2.3, with additional bug fixes reported by @OlgaMaciaszek.  I recommend using that version.
https://github.com/OpenFeign/feign/releases/tag/10.2.3

Yes @kdavisk6 , I am planning on upgrading it this week. It will fix https://github.com/spring-cloud/spring-cloud-openfeign/issues/143

Done in gh-185.


Disable bold font (text)

OS being used:
Ubuntu 18.04, on X11
It's not really an issue, it just that I want to disable the bold font. I know it's a silly question.
But, I've tried to search similar issue about disabling bold text (font), sadly what I found,  it was about setting bold text color.
In the end I created new issue here (I hope I didn't re-post) .
So, what should I do to disable the bold font (text)?
Thank you.

You should be able to use a non-bold style for the bold font config.

Sorry for the late reply.
Changing the bold config font into regular font fixed the issue. I'll close this issue.
Thanks a lot.


feat(autoware_adapi_v1_msgs): add geometry shape message

Signed-off-by: Takagi, Isamu<EMAIL_ADDRESS>Description
Add geometry shape message. See the document for details.
https://github.com/isamu-takagi/autoware_adapi_msgs/blob/feat/geometry-shape/autoware_adapi_v1_msgs/geometry/shape.md
Related links
https://github.com/autowarefoundation/autoware/issues/3225
Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Which API is used this shape.msg for what purpose?

Which API is used this shape.msg for what purpose?

I assume the following:

detection area
detected object
visualization (Because I hear that the size of MarkerArray is large for some applications)

I assume the following:
detection area
detected object
visualization (Because I hear that the size of MarkerArray is large for some applications)

Thank you!
Can you give me some more details?
What is the API for detection area and detected object?
I think we should organize requests a bit more.

What is the API for detection area and detected object?

For remote control and cooperation, applications need to know the status of Autoware to display the operator. These API will be used for that purpose.
It is under consideration here.

https://github.com/autowarefoundation/autoware/issues/3225
https://github.com/autowarefoundation/autoware/issues/3226
https://github.com/autowarefoundation/autoware/issues/3232

I think is the shape is common, we also can use this for the object recognition
https://github.com/autowarefoundation/autoware.universe/pull/2887

@yukkysaito @tkhmy
Changed the message to be more structured.

@isamu-takagi
I feel that controls and values are quite hard to understand, why don't we use dimension and footprint like this
https://github.com/tier4/tier4_autoware_msgs/blob/tier4/universe/tier4_perception_msgs/msg/object_recognition/Shape.msg

@tkhmy
dimension and footprint can only be applied to some shapes, and rotation cannot be expressed.

@tkhmy dimension and footprint can only be applied to some shapes, and rotation cannot be expressed.

@isamu-takagi  I see, so the controls will set the limit of the values. values only will use to contain radius and height?
Do we plan to add width and length for defining rectangle?

@isamu-takagi I see, so the controls will set the limit of the values. values only will use to contain radius and height?
Do we plan to add width and length for defining rectangle?

Shapes currently supported only have radius and height. Since rectangle is polygon, it is specified in points. This is a trade-off between data efficiency and readability. Other method is to add new shape type and set the values to width and height, but In this case the rectangle cannot be rotated.

@tkhmy  There are two designs.

Focus on readability and add all the fields each shape needs. This is closer to visualization_msgs/msg/Marker and less data efficient.
Focus on data efficiency and send it in binary. The application need to interpret it according to the shape type.

What should I do when dealing with 3D bounding boxes?

Close because create a dedicated message for each purpose.


Bring URL preview blacklist up to par with Synapse

There's been quite a few changes in this space, and a couple security vulnerabilities closed. We should ensure we are not vulnerable to the same attacks, and bring in the same level of functionality.
Refs:

https://github.com/matrix-org/synapse/issues/5134
https://github.com/matrix-org/synapse/pull/3317
https://github.com/matrix-org/synapse/pull/4215
https://github.com/matrix-org/synapse/blob/3d26eae14a69c5a3b11c6f25b81c883dcdb2098d/synapse/config/repository.py#L263-L333

Fixed by:

e4547338007bdcc67c52608621b44481e3844529
ce7259f1e76228b580efc9ce6fc8280bb3fe7448
37d917976182ea51bc184fa38bd5ec41e9e0d3a6


Secure remote_servers section

In order to use secure tcp port(9440 by default) while running distributed queries, it's need to add secure setting in remote_servers settings.
It would be great if clickhouse-operator could do that automatically (or at least we would be able to enable it via yaml) in case of using secure ports.
        <shard>
            <weight>1</weight>
            <internal_replication>true</internal_replication>
            <replica>
                <host>example01-02-1</host>
                <secure>1</secure>
                <port>9440</port>
            </replica>
            <replica>
                <host>example01-02-2</host>
                <secure>1</secure>
                <port>9440</port>
            </replica>
       <shard>

Also it would be great to have support for inter-server cluster secret.
https://github.com/ClickHouse/ClickHouse/pull/13156

I also hit this. Needs to be possible to set this to secure in the hostTemplates, or somewhere similar.

Supported since https://github.com/Altinity/clickhouse-operator/releases/tag/release-0.20.0


Configuration merger - YAML support

Adding YAML support for the Configuration merger example.

Will the Configuration Merger eventually be released as a standalone versioned package on PyPi? Trying to understand how to integrate just the utility (not the entirety of deploymentmentmanager-samples) :

manually copy files
symlinks into this a local clone of this repo
git submodule / subtree

and still get fixes and enhancements.

Will the Configuration Merger eventually be released as a standalone versioned package on PyPi? Trying to understand how to integrate just the utility (not the entirety of deploymentmentmanager-samples) :

manually copy files
symlinks into this a local clone of this repo
git submodule / subtree

and still get fixes and enhancements.

At the current stage the Configuration Merger is hardcoding your configuration file structrure and naming convention. This was not meant to be as a "perfect" implementation, it should be tailored to your organizations requironements.
I'm afraid this is not a generic enough implementation to provide it as a package. ( Versioning and changelog is a good idea, I will add those in the furutre.)
I'm happy to hear any more feedback.

How about allowing the file structure to be overridden?
class ConfigContext:
    configs = {}

    def __init__(self, context, module):
        self.configs.update(context)
        for c in self.loadConfigs(module):
            update(self.configs,c)

    def loadConfig(self, fileName, path):
        return {} # stubbed

    # override
    def loadConfigs(self, module):
        return [
            self.loadConfig('org_config', ''),
            self.loadConfig('department_config', ''),
            self.loadConfig('system_config', ''),
            self.loadConfig("envName", 'envs'),
            self.loadConfig(module, 'modules'),
            self.loadConfig(module, "envName")
        ]

class CompanyConfigContext(ConfigContext):
    def loadConfigs(self, module):
        return [
            self.loadConfig("envName", 'envs'),
            self.loadConfig(module, "envName"),
            self.loadConfig(module, 'modules')
        ]

Does PyPi philosophy encourage modules as small as ConfigContext (ala npm):

recursive merge
context.properties DM assumptions
get_conf debugger


Just keep one condition for each program object

All of the code assumes that only the last condition counts.  However, that's not how conditions work.  This change modifies our behavior so that we only maintain the one (most recent) condition for each program object, which is a step toward the resolution of issue #430.
Part of the solution is to create a common updateCondition() function for the bpfd-operator that is used for all program types which removes some code duplication and is a small step toward the resolution of issue #709
This also removes code duplication in xdp-program_test.go, which is a small step toward the resolution of issue #710.

Shoot I forgot about https://github.com/bpfd-dev/bpfd/blob/main/bpfd-operator/pkg/helpers/helpers.go#L308
can you update all those helpers to not play the "look for last position" dance?

Shoot I forgot about https://github.com/bpfd-dev/bpfd/blob/main/bpfd-operator/pkg/helpers/helpers.go#L308
can you update all those helpers to not play the "look for last position" dance?

Thanks for pointing that out.  I updated the code and moved the repeated condition-checking logic into an isProgLoaded() function.

I changed the logs and made a few other changes too.

I removed the hold.  It's waiting on @Billy99 to ack the changes.


ViewStore.publisher doesn't seem to work as expected in 0.21.0

Describe the bug
I can see from the release notes that 0.21.0 changes the behaviour of ViewStore.publisher but I can't see how it is causing the issue I'm seeing. For some reason it seems to publish just a single change even though I know the state is changing.
We have some integration tests that need to log the user in to our app - we do this by creating a ViewStore around a real store with some live dependencies and sending actions that simulate the process of a user logging in. We then sink on the ViewStore.publisher around our root App Store to wait for the necessary state change that would indicate that the user is logged in. This worked fine with 0.20.0 and no longer works with 0.21.0.
To Reproduce
A simplified representation of our app state:
struct AppState: Equatable {
  var session: SessionState
}

enum SessionState: Equatable {
  case loggedOut(LoggedOutState)
  case loggedIn(LoggedInState)
}

The login functionality is managed inside the LoggedOut domain. Our integration test code does something similar to this:
let loggedOutStore = app.appStore.scope(
  state: { extract(case: SessionState.loggedOut, from: $0.session)! },
  action: { AppAction.session(.loggedOut($0)) }
)

let viewStore = ViewStore(loggedOutStore)

// send a bunch of actions to viewStore that simulate the user entering their login details and
// hitting the login button. Tapping the login button will start a bunch of async effects that make
// various API requests.

// Now wait for the `AppState.session` to flip from `.loggedOut` to `.loggedIn`:

ViewStore(store)
  .publisher
  .compactMap { extract(case: SessionState.loggedIn, from: $0.session) }
  .prefix(1)
  .sink(receiveValue: callback) // callback is passed into the helper function that encapsulates this behaviour
  .store(in: &cancellables)

Expected behavior
In 0.20.0, when the login completes the session state changes to .loggedIn and this triggers the callback function above to be executed. In 0.21.0 this never happens. In fact, if I simplify the above to:
ViewStore(store)
  .publisher
  .sink { print($0) }
  .store(in: &cancellables)

Then the .sink is only called once - I don't see any intermediate state changes (and there should be quite a few changes within the loggedOutState while the login process happens).
Environment

TCA 0.21.0
Xcode 12.5.1
OS: iOS 14.

@lukeredpath Is it possible for you to cook up a failing test case? Without having a fuller picture of your setup it's hard to know what the exact problem may be.
The associated change from 0.20.0 to 0.21.0 is from this pull request: https://github.com/pointfreeco/swift-composable-architecture/pull/624/files
Does anything in that diff stand out to you?

Nothing is immediately jumping out. I think I've managed to get a failing test case in an example project though.
TCABugTestProject.zip
I'm using .debug() on the reducer and you can see in the console output that the state does indeed change to .loggedIn after a second but the .sink is never called and the expectation is not fulfilled.

Right - I managed to figure this out. The problem is that the ViewStore is being deallocated. If I assign ViewStore(store) to a local variable in that test first, then it passes. This appears to be the same problem in my actual app.
I'm curious as to why this worked before - it seems like previously something in the previous publisher implementation was retaining a strong reference to the ViewStore and it no longer does. I wonder if this has the potential to break anything else.

@lukeredpath Ah interesting! This makes sense as previously the publisher had an independent lifecycle, but in order to minimize extra calls to removeDuplicates it is now a dependency of the view store. We're open to ideas of how to restore this functionality, but want to avoid introducing a retain cycle.

(@mbrandonw and I have been chatting about this for awhile, but we think sharing ViewStore across SwiftUI and UIKit has been a bit of a bumpy ride, and this is just another example. We think there may be something to having separate concepts in the future.)

IMO I think its fine (and arguably more correct) for the API contract to specify that the caller needs to retain a reference to a ViewStore if they intend to do things like sinking on the .publisher, it would be good to call this out in the documentation though so it's clear.

@lukeredpath We think ownership should be pushed to the "leaves" of the system, which is why a view store holds onto its parent store, and so we think a store publisher should somehow hold onto its view store. @mbrandonw and I are working on a fix now.


[Star Wars Saga Edition] Fixed minor CT and checkbox issues

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Changed color of checkboxes and radio buttons
Fixed CT so that it synced and displayed on both PC and NPC sheets

Character Sheet Info Roll20 Internal Use only.


🐛 [firebase_messaging] Firebase Installations Service is unavailable. Please try again later. and Topic sync or token retrieval failed on hard failure exceptions: FIS_AUTH_ERROR. Won't retry the operation.

E/FirebaseInstanceId( 6476): 	at java.lang.Thread.run(Thread.java:923)
E/FirebaseInstanceId( 6476): Caused by: com.google.firebase.installations.FirebaseInstallationsException: Firebase Installations Service is unavailable. Please try again later.
E/FirebaseInstanceId( 6476): 	at com.google.firebase.installations.remote.FirebaseInstallationServiceClient.createFirebaseInstallation(FirebaseInstallationServiceClient.java:208)
E/FirebaseInstanceId( 6476): 	at com.google.firebase.installations.FirebaseInstallations.registerFidWithServer(FirebaseInstallations.java:536)
E/FirebaseInstanceId( 6476): 	at com.google.firebase.installations.FirebaseInstallations.doNetworkCallIfNecessary(FirebaseInstallations.java:390)
E/FirebaseInstanceId( 6476): 	at com.google.firebase.installations.FirebaseInstallations.lambda$doRegistrationOrRefresh$3$com-google-firebase-installations-FirebaseInstallations(FirebaseInstallations.java:375)
E/FirebaseInstanceId( 6476): 	at com.google.firebase.installations.FirebaseInstallations$$ExternalSyntheticLambda2.run(Unknown Source:4)
E/FirebaseInstanceId( 6476): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
E/FirebaseInstanceId( 6476): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
E/FirebaseInstanceId( 6476): 	... 1 more

(HTTPLog)-Static: isSBSettingEnabled false
E/FirebaseInstanceId( 6476): Topic sync or token retrieval failed on hard failure exceptions: FIS_AUTH_ERROR. Won't retry the operation.
E/flutter ( 6476): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: [firebase_messaging/unknown] java.io.IOException: FIS_AUTH_ERROR
E/flutter ( 6476): #0      StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:653
E/flutter ( 6476): #1      MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:296
E/flutter ( 6476): <asynchronous suspension>
E/flutter ( 6476): #2      MethodChannel.invokeMapMethod
package:flutter/…/services/platform_channel.dart:499
E/flutter ( 6476): <asynchronous suspension>
E/flutter ( 6476): #3      MethodChannelFirebaseMessaging.getToken
package:firebase_messaging_platform_interface/…/method_channel/method_channel_messaging.dart:224
E/flutter ( 6476): <asynchronous suspension>

@HencyPithadiya
You can try the following steps to see if this may help with the error:

This may be caused by having the wrong configuration file in your app (for example, if you switched Firebase projects). You can try doing Build > Clean Project then Build > Rebuild Project to make sure that the build cache is clean and the correct config file is used.
Make sure your device or emulator has Google Play Services added.
Make sure your device or emulator is connected to wifi or any ISP.

In addition, these references may provide more insights about this issue:
E/FirebaseInstanceId: Failed to get FIS auth token
Android Error when communicating with the Firebase Installations server API
https://github.com/FirebaseExtended/flutterfire/issues/3163
Closing from here, as this is a plugin issue, but could be setup / config or server issue. You may also reach out to firebase support for further resolution.


groupby(by).size() implementation

Describe the problem

df.groupby(col).size() is implemented using pandas, but it is not warning the user. Also, this operation returns a pandas.Series, which should never happen in Modin. This can be easily implemented based on the existing implementation.
There are also no tests for DataFrameGroupBy.size, which is related to this issue.
Source code / logs
https://github.com/modin-project/modin/blob/e9bae1967ed3eddabc66241e73cc3cb6695fcd8d/modin/pandas/groupby.py#L321-L322

Pushing to next release to prioritize bugfixes

Size implementation in #1534 is correct, but it relies on _groupby_reduce which currently is unable to produce a DataFrame of different size from the original. Some work is required to correctly calculate columns for _groupby_reduce result DataFrame, it is also required to fix #1520 and #1516.


GET /headers

https://ethereum.github.io/beacon-APIs/#/Beacon/getBlockHeaders

[ ] headers
[ ] headers by block_id

can i take on this ?

hey @mahmudsudo, you can take this one!

on it

Hey @mahmudsudo sorry for the bad timing, but yesterday EOD i found one of my current priorities depend on this: #1324.
I would tackle this as part of that PR, so maybe you can look instead at: #563 or #562, LMK what you think?

BTW, right now just the headers/head is a prereq for #1324, so optimistically you could work on the other endpoints, likeheaders and headers/{block_id} but I'm not sure i would end up needing those too, so that's why i think the others are a better option.


Remove duplicate tiers created for Collectives of open source flow

When creating a Collective from github, we are generating the tiers twice:

Two tiers in the top level method createFromGithub
and other two similar tiers on the method addHost that's called by createFromGithub.

This causes the generation of duplicated tiers.
fixes https://github.com/opencollective/opencollective/issues/1534

Coverage decreased (-0.003%) to 67.664% when pulling a38f288312ba121150d64e00870da13065c03aef on fix-1534/duplicated-tiers into 15c561b9104dac41657bc8d88cd96b85e3e603fa on master.


⚠ ClamAV has degraded performance

In f81c1f6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 441 ms

Resolved: ClamAV performance has improved in f78d64b after 5 minutes.


fix(strm-1575): set data subject field in the create event contract request

:tada: This PR is included in version 2.14.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#4189 added :throws: directive to user guide for core/Config

You're using spaces as separators ... use tabs.
Also, the message should be reduced to:

If no (valid) configuration file is found

... and that should really be applied to the docblock in the actual PHP file as well, I guess I missed that the first time around.

Sorry, but you've barely addressed anything ... I actually didn't notice that you used spaces for indentation, wasn't talking about that.
I'll leave inline comments.

"If no (valid) configuration file is found"
Exactly as I wrote it; no additions or changes to it

If no (valid) configuration file is found

... both places.


Promoting downstream from control-flow stage doesn't work

Description
When clicking the truck icon on a control-flow stage (one that doesn't have any promotion mechanisms), the UI doesn't highlight any Freight as promotable, so I am unable to promote to all the downstream stages with one click. I'm not sure if this is a UI problem or a backend problem.
The following video shows "Promote downstream" working for staging, but not for prod.
https://github.com/user-attachments/assets/4efacd6d-a763-4b9f-8482-35e1ce52f15d
Here is the live object of the prod Stage:
metadata:
  name: prod
  namespace: kargo-advanced
spec:
  subscriptions: {}
  requestedFreight:
    - origin:
        kind: Warehouse
        name: guestbook
      sources:
        direct: false
        stages:
          - ab-test-a
          - ab-test-b
status:
  phase: NotApplicable
  observedGeneration: "2"
  freightSummary: 0/1 Fulfilled

Steps to Reproduce
Create the kargo-advanced example and try to promote downstream from prod stage.
Version
v0.8.7

I was able to reproduce. Then tried to check if this is UI bug, I don't know the reason but UI logic says if stage has only 1 downstream subscriber then don't let promote. I changed that to let it promote but then saw something in downstream promotion API
https://github.com/akuity/kargo/blob/main/internal/api/promote_downstream_v1alpha1.go#L137-L139
// Avoid creating a Promotion if the downstream Stage has no
// PromotionMechanisms, and is a "control flow" Stage.

In your example @jessesuen , prod stage has no promotion mechanism and for that reason even if we have UI fixed, API won't let promote.
@krancour can you please chime in.

I will look at this today.

I don't know the reason but UI logic says if stage has only 1 downstream subscriber then don't let promote.

It's because of https://github.com/akuity/kargo/issues/2247
Truck deliberately only appears if there are multiple downstream Stages.
I'm not sure that's related to the issue at hand.
So far I cannot find anything in the back end that would explain this.
@jessesuen are there any any errors in the JS console when this happens?

prod can't send freight to downstream because it doesn't have any freight available.
prod can't have freight because ab-test won't downstream for 2 reasons

UI interpretation - No downstream in 1:1, only allows for 1:N if N > 1. Event if UI lets downstream, the operation won't happen because the API code I linked would disallow downstream promotion if stage doesn't have promotionMechanism which is the case for prod.
UI interpretation - No upstream freight for prod because it doesn't have promotionMechanism (Now I don't know the reason for this interpretation but this could be the UI bug if the interpretation is wrong)

We could reach to the solution if my theory for 2nd reason is correct.
It looks like to me that control-flow is just concept and at some point with some breaking changes, UI lost the definition of what control-flow is. @krancour you are the best person to enlighten on this.

It looks like to me that control-flow is just concept and at some point with some breaking changes, UI lost the definition of what control-flow is.

Historically, a "control flow stage" isn't really anything except a Stage that lacks any promotion mechanisms.
For v0.9.0, this definition needs to change to "doesn't have any (legacy/deprecated) promotion mechanisms and doesn't have a promotion template."
It's quite probable that the UI is not checking for the second condition in a few places. I've occasionally been noticing places in the back-end where we are also not accounting for it.
In v1.0.0, the deprecated promotion mechanisms will be fully removed and the definition of a control flow stage will be just "doesn't have a promotion template."
All of this being said, I don't think @jessesuen's issue is related to this (or at least not directly), as he opened this issue prior to the support for promotion template / steps being merged.

Ok... this was a UI bug introduced way back in #2298.
That PR deprecated stage.status.currentFreight and in the same PR, @rbreeze created a getCurrentFreight() func in the UI that gets the current Freight from the top of the stage.status.freightHistory stack.
It seems this func or calls made on its results are not adequately handling control flow stages that never have any freight.

This was fixed by https://github.com/akuity/kargo/pull/2497 and is available in release greater than 0.8.7 but I am still checking for anomalies will close this if everything looks correct

Closing this issue
https://github.com/user-attachments/assets/dd6f98eb-3c0a-4b31-b521-c465ea0f596a


Leaf nodes now indent with empty placeholder always

Testing #44364
Leaf nodes with no icons are now indented regardless of whether or not other leaf nodes have icons.

This should instead have basic indentation and no placeholder.

Closing this as the indentation is completely reverted


Implement basic element/slice indexing

Implement basic, non-strided indexing as described here.

[ ] Element tensor indexing: tensor(i).

This returns an element tensor, whose shape is tensor.shape.tail.

[ ] Subtensor indexing (i.e. "slicing [in the first dimension]"): tensor(range).

This returns a tensor slice, whose shape is [range.length] + tensor.shape.tail.

Tensor.apply should be adapted for these indexing strategies (rather than the current scalar indexing behavior).
These indexing strategies add expressivity: they enable minibatching and interesting recursive functions:
def print(separator: String = ", ") = {
  if (isScalar) printf("%f", this.data(0))
  else {
    // Recurse over element tensors.
    printf("[")
    for (i <- 0 until this.shape(0): Rep[Range]) {
      this(i).print(separator)
      printf(separator)
    }
    printf("]")
  }
}

Both element tensors and slices should probably be cost-free views into the data of their parent tensor. Otherwise, indexing large tensors (for minibatching) will be highly inefficient. We can implement copy-on-write semantics.

I am working on this but there is some problem with range selection.
If I have apply(i: Rep[Int], j: Rep[Int]) to select a range, the (j-i+1) is actually a Rep[Int], which conflicts with the design that dimensions are not Rep type.
However, this is related to a more general problem, which is the fact that Lantern cannot yet support unknown dimensions (normally used for batch, which is variable). I think if we add unknown dimensions, it will be Rep[Int] (for batch dimension).
What do you guys think? @dan-zheng  @TiarkRompf @GSAir

Let's first be sure of the goal. Rep typed range/slicing allows slicing at runtime, but static range/slicing is only slicing at stage time. What is the goal? Is it slicing with known indexes at stage time, or slicing with indexes unknown at stage time?

tensor(0 until 3)(0)(1 until 2)(0) looks nice.
What exactly is the key use case for unknown dimensions? Is it because we want to increase batch size during training?
How does XLA deal with it, I think they also require static fixed shapes?
In general I think switching shapes from Array[Int] to Array[Rep[Int]] is defensible but we should be clear about why we need it and make sure it doesn't cause any performance regressions.

That's a good question. I'm not sure which is better, but stage-time indexing seems fine to me.
The more important factor regarding performance is to ensure that element tensors and slices have copy-on-write semantics, e.g. they reuse the data of their parent tensor until they're first written to. Otherwise, indexing will cause full element/slice copying every time, which is expensive.

Runtime slicing is useful for RNN, whose input is 3D tensor of shape (timeStep, batch, dimension). At each cycle i, we process input(i) with the last hidden state, and produce the next hidden state.
Runtime ranging may not be useful (I don't know), I choose to skip it for now.
Staging time slicing and ranging may be useful (I have not encountered any. Normally for minibatching, we get a mini-batch of tensor directly, without the need to slice a minibatch out)
I am not sure how to implement copy-on-write (some guidance link is helpful). I think for runtime slicing (like the RNN case), no copy at all makes sense.

Let's make sure that anything we do has a concrete use case in one of the benchmark apps. If it's not on the critical path for at least one of them then:

it's not the best use of our time right now
we may not sufficiently understand all the requirements

For example, a good COW scheme takes significant work to get right (in particular, to not slow down read-only uses) so we should approach this only when necessary.

I totally agree that implementing COW is not a best use of our time.
(The primary purpose is to enable "value semantics for tensors", e.g. tensor(i) is a new Tensor value that can be modified without affecting tensor.)
If we decide it is a good use of time to implement indexing, we can implicitly let element/slice tensors have reference semantics and share their parents' memory. The only consequence is that writing to element/slice tensors will change the value of their parents, which may be counterintuitive. The actual indexing code will simply perform pointer arithmetic, just like the current slice method.

Makes sense. Again, let's decide based on what we encounter in the various models.


Connection timed out errors

I'm getting:
2019/01/17 21:38:32 [error] 4213#4213: *12683 upstream timed out (110: Connection timed out) while connecting to upstream(proxy_connect), client: <IP_ADDRESS>, server: , request: "CONNECT registry.npmjs.org:443 HTTP/1.1", host: "registry.npmjs.org"

When trying to do an npm install through the proxy.  What happens is, I will get may a hundred or so successful upstream connections, and then this error will start to appear and npm will never recover.
Both my systems are on AWS EC2.  My nginx.conf file looks like this:
worker_processes 1;

error_log /var/log/nginx/error.log info;

pid /run/nginx.pid;

events {
  worker_connections 1024;
}

http {
  include mime.types;
  default_type application/octet-stream;
  sendfile on;
  keepalive_timeout 65;

  server {
    listen 3128;
    resolver <IP_ADDRESS> ipv6=off;
    resolver_timeout 30s;

    # Forward proxy for CONNECT requests
    proxy_connect;
    proxy_connect_allow 443;
    proxy_connect_connect_timeout 30s;
    proxy_connect_read_timeout 30s;
    proxy_connect_send_timeout 30s;

    # Forward proxy for non-CONNECT request
    location / {
      proxy_pass http://$host;
      proxy_set_header Host $host;
    }
  }
}

I found I had to add the ipv6=off or the I'd get this error almost constantly.  Apparently there is a race condition with the DNS server sometimes returning an IPv6 record before the IPv4 one.

TODO: optimize error log to show  connect-timedout IP address

I have solved similar problem by adding
proxy_connect_timeout 600;
proxy_send_timeout 600;
proxy_read_timeout 600;
send_timeout 600;

in nginx.conf, just have a try

Hi @chobits do you have an update on this?
I'm seeing something similar: I see a bunch of these upstream timeout errors in logs, but in the access log they don't always show up as 504s. Do you have any ideas as to the disparity between the error logs and the access logs for these timeouts?

Hi @chobits do you have an update on this?
I'm seeing something similar: I see a bunch of these upstream timeout errors in logs, but in the access log they don't always show up as 504s. Do you have any ideas as to the disparity between the error logs and the access logs for these timeouts? I'm wondering if the proxy module tries to reconnect a few times before giving up.

Response status will be 200 not 504 if CONNECT tunnel has been established with backend server and then the timedout error occurs.
Will modify some error message to show these details.

hi @jrgp

Im wondering if the proxy module tries to reconnect a few times before giving up.

No, proxy_connect modules does not reconnect a few times.
And note that only error message including proxy_connect string is generated by proxy_connect, other error messages may be generated by nginx upstream(http proxy).

Error log messages has been updated in https://github.com/chobits/ngx_http_proxy_connect_module/pull/121.
For doc of error log message, see readme/error log

Just as an additional data point, we switched to using Tengine instead of vanilla nginx and have not seen this issue.  @chobits It is my understanding that you merged this module into Tengine.  Is there something different about it in the Tengine code base?  With this module and nginx we would see this timeout error downloading npm modules regularly.  We have never seen with Tengine.

hi @jlyonsmith

It is my understanding that you merged this module into Tengine.

Yes

Is there something different about it in the Tengine code base?

Tengine core base has something different about nginx. However, proxy_connect module code base has nothing diffrerent with them.  Hard to explain the diffrence.
Maybe new error log messages can help to locate this problem. It shows backend address and dispart connect/read syscall.

Hi @chobits thanks for adding the additional debugging messages. I just upgraded to the latest master rev and I'm now seeing the additional information, with the error classified as a read timeout:
2019/08/08 19:10:05 [error] 11765#0: *471838 proxy_connect: upstream read timed out (peer:[REDACTED]:443) while connecting to upstream, client: REDACTED, server: , request: "CONNECT REDACTED:443 HTTP/1.1", host: "REDACTED:443"

I'm using nginx 1.12.2. Do you think there are improvements in the nginx core between 1.12.2 and 1.16.0 which could help this problem, or is it more likely to be a networking/config problem on my end?
Also, are the proxy timeout config options in vanilla nginx relevant here or do only the proxy_connect_* options this module provides matter?

Also, are the proxy timeout config options in vanilla nginx relevant here or do only the proxy_connect_* options this module provides matter?

For backend timeout, proxy_connect_* works.

hi @jrgp

proxy_connect:  upstream read timed out

It means  proxy_connect tries to read data from backend server, but the backend server does not send data back during timeout set by proxy_connect_read_timeout occurs. Try to increase the value of timeout.

Hi @chobits. Thanks for the info. Bumping that setting much higher (30s to 60s) made most of the error messages go away. Now I need to determine why the timeout needs to be set so high :)

Hi all, I'm closing this issue, because this TODO item (error log optimization) has been completed.

If still having some issues about error_log, you can comment on this thread.
For other questions, feel free to open a new issue.

hello,how can I reslove this problem?now i ,meet the same issus
nginx/1.16.1
user nginx;
worker_processes auto;
error_log /var/log/nginx/error.log;
error_log /var/log/nginx/debug.log debug;
pid /run/nginx.pid;
Load dynamic modules. See /usr/share/doc/nginx/README.dynamic.
include /usr/share/nginx/modules/*.conf;
#load_module /usr/local/nginx/modules/ngx_http_proxy_connect_module.so;
events {
worker_connections 1024;
}
http {
server {
listen      <IP_ADDRESS>:80;
server_name  localhost;
resolver       <IP_ADDRESS> ipv6=off;
resolver_timeout 5s;
# forward proxy for CONNECT request
proxy_connect;
proxy_connect_allow            all;
proxy_connect_connect_timeout  600s;
proxy_connect_read_timeout     600s;
proxy_connect_send_timeout     600s;

proxy_connect_timeout 600s;
proxy_send_timeout 600s;
proxy_read_timeout 600s;
send_timeout 600s;

#include conf.d/ip_allow.ini;
auth_basic  "secret";   #添加此配置
auth_basic_user_file  /etc/squid/passwd; #加载生成的密码文件

# forward proxy for non-CONNECT request
location / {
    #proxy_pass http://<IP_ADDRESS>:3128;
    # these two lines here
        #proxy_http_version 1.1;
        #proxy_set_header Connection "";

    proxy_pass http://$http_host;
        proxy_set_header Host $host:$http_host;
}

}
}

2021/04/15 02:35:11 [error] 965#0: *143 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT ogs.google.com:443 HTTP/1.1", host: "ogs.google.com:443"
2021/04/15 02:35:13 [error] 965#0: *145 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT apis.google.com:443 HTTP/1.1", host: "apis.google.com:443"
2021/04/15 02:35:17 [error] 964#0: *137 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT adservice.google.com:443 HTTP/1.1", host: "adservice.google.com:443"
2021/04/15 02:35:17 [error] 964#0: *127 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT www.google.com:443 HTTP/1.1", host: "www.google.com:443"
2021/04/15 02:35:18 [error] 965#0: *153 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT github.com:443 HTTP/1.1", host: "github.com:443"
2021/04/15 02:35:20 [error] 965#0: *161 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT github.githubassets.com:443 HTTP/1.1", host: "github.githubassets.com:443"
2021/04/15 02:35:20 [error] 965#0: *155 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT github.githubassets.com:443 HTTP/1.1", host: "github.githubassets.com:443"
2021/04/15 02:35:22 [error] 964#0: *141 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT ogs.google.com:443 HTTP/1.1", host: "ogs.google.com:443"
2021/04/15 02:35:22 [error] 964#0: *45 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT play.google.com:443 HTTP/1.1", host: "play.google.com:443"
2021/04/15 02:35:23 [error] 964#0: *147 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT github.githubassets.com:443 HTTP/1.1", host: "github.githubassets.com:443"
2021/04/15 02:35:27 [error] 965#0: *111 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:35:27 [error] 965#0: *169 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT google.com:443 HTTP/1.1", host: "google.com:443"
2021/04/15 02:35:27 [error] 964#0: *167 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT google.com:443 HTTP/1.1", host: "google.com:443"
2021/04/15 02:35:47 [error] 964#0: *173 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT content-autofill.googleapis.com:443 HTTP/1.1", host: "content-autofill.googleapis.com:443"
2021/04/15 02:35:47 [error] 965#0: *171 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT content-autofill.googleapis.com:443 HTTP/1.1", host: "content-autofill.googleapis.com:443"
2021/04/15 02:37:08 [error] 965#0: *181 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT content-autofill.googleapis.com:443 HTTP/1.1", host: "content-autofill.googleapis.com:443"
2021/04/15 02:37:08 [error] 964#0: *179 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT content-autofill.googleapis.com:443 HTTP/1.1", host: "content-autofill.googleapis.com:443"
2021/04/15 02:37:20 [error] 965#0: *149 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT avatars.githubusercontent.com:443 HTTP/1.1", host: "avatars.githubusercontent.com:443"
2021/04/15 02:37:20 [error] 964#0: *185 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:37:20 [error] 965#0: *183 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:38:25 [error] 964#0: *191 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:38:53 [error] 965#0: *195 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT avatars.githubusercontent.com:443 HTTP/1.1", host: "avatars.githubusercontent.com:443"
2021/04/15 02:39:03 [error] 964#0: *193 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT avatars.githubusercontent.com:443 HTTP/1.1", host: "avatars.githubusercontent.com:443"
2021/04/15 02:39:21 [error] 964#0: *151 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT github.com:443 HTTP/1.1", host: "github.com:443"
2021/04/15 02:40:24 [error] 964#0: *199 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT play.google.com:443 HTTP/1.1", host: "play.google.com:443"
2021/04/15 02:40:24 [error] 965#0: *187 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:40:24 [error] 965#0: *197 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT play.google.com:443 HTTP/1.1", host: "play.google.com:443"
2021/04/15 02:41:27 [error] 965#0: *205 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:41:27 [error] 964#0: *202 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"
2021/04/15 02:44:28 [error] 964#0: *209 proxy_connect: client read timed out while connecting to upstream, client: <IP_ADDRESS>, server: localhost, request: "CONNECT beacons.gcp.gvt2.com:443 HTTP/1.1", host: "beacons.gcp.gvt2.com:443"


testadd test join case4

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Datetimes

Coverage increased (+0.4%) to 97.711% when pulling a91e390b1be81c2aac57ca8561e2eb50a0816ea2 on datetimes into 472e3e89e0e41d64db76fa128c6365fb8b6f2b30 on master.

Travis failed on a technicality...


Evaluation on public dataset

Hi, great work!
I'm trying to reproduce the results on public datasets. However, I only found the training codes, where the model was evaluated on the eval set (or you don't use train/eval/test spilt, only train/test split?). I’d like to know if you partitioned the public dataset into a test set, and whether the results reported in the paper correspond to the test set or the eval set.
If I want to partition a test set, should I set ignore_last_n=0,1,2 when loading the test, eval and train dataset? For example:
train_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=2,
      chronological=chronological,
)
eval_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=1,
      chronological=chronological,
)
test_dataset = DatasetV2(
      ratings_file=dp.output_format_csv(),
      padding_length=max_sequence_length + 1,  # target
      ignore_last_n=0,
      chronological=chronological,
)

hello i'm reading this code and i think you should set all ignore_last_n to 0. if you store the different datasets in separate file, you need to set different filename for 'ratings_file' as you need. hope it helps.

Thanks for your interest in our work! Please check https://github.com/facebookresearch/generative-recommenders/issues/8


expand by column: expandable={false} not working while column is custom format

click the cell with button or badge still can expand the row
settingFormatter(cell, row){
    return (

        <Button role='button' className="btn btn-outline-info" onClick={() => this.props.loadOffSideBar(true, ACT_TYPE_EDIT, row.id, row.name, row.text)} ><FontAwesome name='pencil' /></Button>
        <Button role='button' className="btn btn-outline-danger ml-3" onClick={() => this.props.deleteEvent(row)} ><FontAwesome name='times' /></Button>

    );
  }
  statusFormatter(cell, row){
    return (

        {row.isPublish ?
          <Badge color='success' className="p-2">Published</Badge>:
          <Badge color='warning' className="p-2">Draft</Badge>
        }

    );
  }
<TableHeaderColumn dataField="status" dataAlign="center" expandable={ false } dataFormat={this.statusFormatter}>
                Status
              </TableHeaderColumn>
              <TableHeaderColumn dataField="setting" dataAlign="center" expandable={ false } dataFormat={this.settingFormatter}>
                {this.renderCustomHeader()}
              </TableHeaderColumn>

@StanleySong, sorry, do you configure options.expandBy as column?

yes, i did

@StanleySong sorry, the expandable={ false }  still work well with dataFormat, could you please show me your entire example to minimal repo? Or did you forgot to tell me some configuration? thanks

Hi, I just reproduced this error and found out why it's happening.
In TableRow, on the rowClick method, when it's attempting to get the cellIndex (Line 16 as of now) if the dataFormat adds another html tag, a div, a span or whatever, when it tries to find the cellIndex is going to return undefined.
One possible solution would be to loop back through the .parentNode of the e.target to get the first td element, and then get the cellIndex of that.

@Fenicio nice catch 👍  But for your PR https://github.com/AllenFang/react-bootstrap-table/pull/1622/files   a while loop is seems like to danger, but I'll keep to find another better solution, thanks

@AllenFang @Fenicio Thank you guys, good job. sorry for looking into it late


Create a wrapper for .find

.trash(null)
.areas(false)
.published(null)

This wrapper would be specifically used in the pages module and should
probably be a method of that. There are a lot of places where we need a
more back-endy set of defaults.
On Wed, Jul 22, 2015 at 3:03 PM, Samantha Combs<EMAIL_ADDRESS>wrote:

.trash(null)
.areas(false)
.published(null)
—
Reply to this email directly or view it on GitHub
https://github.com/punkave/apostrophe/issues/315.

--
*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com


ibtool not found

The installation instructions I guess need a little more detail:
% ./runme
+ mypy ./src
Success: no issues found in 8 source files
+ rm -fr ./dist
+ python setup.py py2app --alias
/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  warnings.warn(
running py2app
running build_py
creating build
creating build/bdist.macosx-10.15-x86_64
creating build/bdist.macosx-10.15-x86_64/lib
creating build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/test_model.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/notifs.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/quickapp.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/__init__.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/pommodel.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/cli.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/storage.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
copying src/pomodouroboros/mac_gui.py -> build/bdist.macosx-10.15-x86_64/lib/pomodouroboros
creating /System/Volumes/Data/root/src/Pomodouroboros/build/bdist.macosx-10.15-x86_64/python3.10-standalone
creating /System/Volumes/Data/root/src/Pomodouroboros/build/bdist.macosx-10.15-x86_64/python3.10-standalone/app
creating /System/Volumes/Data/root/src/Pomodouroboros/build/bdist.macosx-10.15-x86_64/python3.10-standalone/app/collect
creating /System/Volumes/Data/root/src/Pomodouroboros/build/bdist.macosx-10.15-x86_64/python3.10-standalone/app/temp
creating /System/Volumes/Data/root/src/Pomodouroboros/dist
creating build/bdist.macosx-10.15-x86_64/python3.10-standalone/app/lib-dynload
creating build/bdist.macosx-10.15-x86_64/python3.10-standalone/app/Frameworks
Add paths for VENV /usr/local/pyenv/pyenv/versions False
*** creating application bundle: Pomodouroboros ***
Copy '/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/apptemplate/prebuilt/main-x86_64' -> '/System/Volumes/Data/root/src/Pomodouroboros/dist/Pomodouroboros.app/Contents/MacOS/Pomodouroboros'
compile IBFiles/GoalListWindow.xib -> /System/Volumes/Data/root/src/Pomodouroboros/dist/Pomodouroboros.app/Contents/Resources/GoalListWindow.nib
xcrun: error: unable to find utility "ibtool", not a developer tool or in PATH
Traceback (most recent call last):
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 42, in _get_ibtool
    gTool = check_output(["/usr/bin/xcrun", "-find", "ibtool"])[:-1]
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/util.py", line 718, in check_output
    raise subprocess.CalledProcessError(xit, command_line)
subprocess.CalledProcessError: Command '['/usr/bin/xcrun', '-find', 'ibtool']' returned non-zero exit status 72.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 2275, in build_alias_executable
    copy_resource(src, dest, dry_run=self.dry_run, symlink=1)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/util.py", line 132, in copy_resource
    converter(source, destination, dry_run=dry_run)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 62, in convert_xib
    _run_nibtool(source, destination)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 26, in _run_nibtool
    xit = subprocess.call([_get_ibtool(), "--compile", destination, source])
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 44, in _get_ibtool
    raise IOError("Tool 'ibtool' not found")
OSError: Tool 'ibtool' not found
error: Tool 'ibtool' not found
Traceback (most recent call last):
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 2275, in build_alias_executable
    copy_resource(src, dest, dry_run=self.dry_run, symlink=1)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/util.py", line 132, in copy_resource
    converter(source, destination, dry_run=dry_run)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 62, in convert_xib
    _run_nibtool(source, destination)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 31, in _run_nibtool
    raise RuntimeError("ibtool failed (%r -> %r)" % (source, destination))
RuntimeError: ibtool failed ('IBFiles/GoalListWindow.xib' -> '/System/Volumes/Data/root/src/Pomodouroboros/dist/Pomodouroboros.app/Contents/Resources/GoalListWindow.nib')
Traceback (most recent call last):
  File "/System/Volumes/Data/root/src/Pomodouroboros/setup.py", line 22, in <module>
    setup(
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
    return distutils.core.setup(**attrs)
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 148, in setup
    return run_commands(dist)
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
    dist.run_commands()
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
    self.run_command(cmd)
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/dist.py", line 1214, in run_command
    super().run_command(command)
  File "/usr/local/virtualenvs/tmp-6d1a0d409417d94/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
    cmd_obj.run()
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 964, in run
    self._run()
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 1192, in _run
    self.run_alias()
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 1095, in run_alias
    dst = self.build_alias_executable(target, target.script, extra_scripts)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/build_app.py", line 2275, in build_alias_executable
    copy_resource(src, dest, dry_run=self.dry_run, symlink=1)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/util.py", line 132, in copy_resource
    converter(source, destination, dry_run=dry_run)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 62, in convert_xib
    _run_nibtool(source, destination)
  File "/System/Volumes/Data/root/src/Pomodouroboros/.eggs/py2app-0.28-py3.10.egg/py2app/converters/nibfile.py", line 31, in _run_nibtool
    raise RuntimeError("ibtool failed (%r -> %r)" % (source, destination))
RuntimeError: ibtool failed ('IBFiles/GoalListWindow.xib' -> '/System/Volumes/Data/root/src/Pomodouroboros/dist/Pomodouroboros.app/Contents/Resources/GoalListWindow.nib')

Oh. You need an actual Xcode installation. Since this is a mac app, the command-line tools don't cut it.

@nedbat I closed it with that commit but please let me know if more detail would be useful (or if installing Xcode doesn't make it work for you right away)


Set the url value manually

I read that the url props was replaced by videoId, but is there still some way to set the url manually ? The reason is that I want to use the search query (https://www.youtube.com/embed?listType=search&list=QUERY)

You can set the list and listType through the playerVars option of the youtube iframe api: https://developers.google.com/youtube/player_parameters?playerVersion=HTML5#list
<YouTube
  videoId="2g811Eo7K8U"
  opts={{
    list: 'QUERY',
    listType: 'search',
  }}
  onReady={this._onReady}
/>

@tjallingt is that videoId necessary ? It doesn't work when I delete the videoId, from the documentation, I think that the videoId won't be necessary if using search

Great to hear that!


Binding Select list with value from database

The problem - I need to fill a select list from one table (in this case U.S. States) but I need to set the default value equal to a field brought back from a call to web api that brings back user info and the State of the user's office.  The database designer did not name the fields the same and, I quote, he "doesn't believe in foreign keys".  The field in the State table that holds the State abbreviation is callled vchStateID  (and it is the key field), and the field with the value I need to show in the select list which comes from the user info is called vchOfficeStateID.  Is it possible to get this to work?

This sounds like a general support question. Please, use one of the appropriate support channels for these types of questions.
GitHub issues are reserved for bug reports and feature requests.
Thx !


Document list of ignored files / clean up properly after error.

I spent over one hour to understand what that error message exactly means and why my code wasn't searched.
Please spare others these hour! Thanks!
And consider ignoring the ignore list, when folders are explicitly added. I know, that's a little bigger than one hour.
Proposed Changes

Document ignored files list.
Try removing empty tmpstrings directory after error.

Besides these: Thanks so much for this great tool!

@tladesignz Thank you for reporting these two points. As for the tmpstrings folder, as far as I know, BartyCrouch is already trying to clean it up, maybe we need to add it to more places. Please note that I'm planning a larger rewrite for BartyCrouch soon(ish), I will consider this feedback there.
As for improving documentation, can you make a suggestion where exactly having it documented would have saved you the time you wasted now? As you were just recently affected, can I ask you to post a PR with the adjustments to the REAMDE.md file? I would happily review it, but having someone affected make the suggestion and maybe even the phrasing could make this more effective than if I try to guess which parts would be actually read. I sometimes fear to put too much information and to overwhelm new users, so if you just add the right amount in the right place, it would be 💯 . 👍

@tladesignz SwiftLint is failing due to whitespaces in CommandLineActor.swift, can you please fix them? Then I will merge.
You can prevent this kind of trailing whitespaces in Xcode by the way by adjusting the settings like this (just in case):

Thanks for that hint! Good now?

@tladesignz Yeah, looks good now, thank you. 👍  Merging. 🎉

@tladesignz This was just released in 4.9.0. 🎉  Thank you again! 💯

This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!


Enable dependabot for dependency updates

### Tasks
- [x] Check and update all dependency libraries to the workable latest versions.
- [ ] Integrating Dependabot

Reopening for dependabot enabling


Bot starts but does nothing

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

compile
run bat
bot starts, comes online and does nothing
See error

Expected behavior
Bot to turn on create channels and send the startup messages such as ip
Screenshots

Desktop (please complete the following information):
Windows 11
python version 3.10.11
Additional context
Add any other context about the problem here.

All intents are on by the way


Parinfer

No idea how possible this is, but support for Parinfer (https://github.com/eraserhd/parinfer-rust) would be great. I think it should be as simple as loading the dynamic library and mapping the various functions onto Lua functions. Awesome project btw :)

Seems to be a good fit for a plugin but it would require a rewrite in Lua. Using a dynamic library with mapping is adding too much engineering complexity to be justified for this application IMHO.

Ah okay. I don't have enough Lua experience to do that sadly. If anyone else wants to try implementing it in future that would be great!

this probably could and should be done completely with a plugin. Use this issue if something is needed from the core application to make such a plugin possible.
Also if anyone starts hacking on this plugin, please tell.

I guess we should remove the labels "enhancement" and "help wanted" because this should be a plugin so we are not supposed to work on that within the "lite-xl" repository. Normally I guess that as soon as we agree that it should be a plugin we add the label and we can close the issue.
It is important to close the issues when there is no work to do on them within the repository. Even if the issue is closed everyone can continue adding comments to continue the discussion.

yeah, i was thinking about what to do with plugins. I don't know if it is possible to move issues from this repo to the plugins repo, you know? Maybe it would also be a good idea to collect both the plugin-repo and this one under an organization here on github, i think that will make things like this easier, it will at least be easier to refer to cross repo issues and such.


📦 NEW:  limit functionality to cli

Implements the feature described in https://github.com/ahmadawais/corona-cli/issues/16

Definitely, we should only use absolute positive values.

I suggest using something like
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/abs
Just turn the negative value to positive one.

Thanks for the PR. Can you please update the PR in light of the latest release.
🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0
🔗 https://www.npmjs.com/package/corona-cli

Looks like some pretty major changes were made, and I'm not sure I'm the right person to fix this, even though I did the changes...

I gave it a go. Have a look and see if you agree with the changes.

Oh dang, again needs to be rebased.

Rebased again..

No worries, I had rebased them on my end already.

Thank you!
🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.6.0
🔗 https://www.npmjs.com/package/corona-cli
I chose -l as the alias.

The help text is off:
   --limit, -n          Limit output to N entries

The alias is still displayed as -n, -l works.

Dang it. I thought I had removed it.
🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.8.4
🔗 https://www.npmjs.com/package/corona-cli
npm i -g corona-cli


Unable to use S3 Path Style Access S3 URL

Describe the bug
We are using Minio which has S3 Functionality, by default the URL is minio.blah.randomurl.com/bucketname/, however, when we provide that URL the AWS S3 SDK falls over, it looks like other libraries (Java for example) allow you to use this bucket formatting with things like withPathStyleAccessEnabled but I can't see that on the AWS .net API__
Expected Behavior
Able to use either bucketname.minio.blah.randomurl.com/ or minio.blah.randomurl.com/bucketname/ as a URL for S3 Storage with the AWS API
Current Behavior
1: Prefixes the bucket name into the ServiceURL which doesn't resolve DNS as it doesn't exist
2: No bucket name is provided and an exception is thrown because a bucketname is a required field
System.ArgumentException: BucketName is a required property and must be set before making this call. (Parameter 'GetObjectRequest.BucketName')
   at Amazon.S3.Model.Internal.MarshallTransformations.GetObjectRequestMarshaller.Marshall(GetObjectRequest getObjectRequest)
   at Amazon.Runtime.Internal.Marshaller.PreInvoke(IExecutionContext executionContext)
   at Amazon.Runtime.Internal.Marshaller.InvokeAsync[T](IExecutionContext executionContext)
   at Amazon.Runtime.Internal.CallbackHandler.InvokeAsync[T](IExecutionContext executionContext)
   at Amazon.S3.Internal.AmazonS3ExceptionHandler.InvokeAsync[T](IExecutionContext executionContext)
   at Amazon.Runtime.Internal.ErrorCallbackHandler.InvokeAsync[T](IExecutionContext executionContext)
   at Amazon.Runtime.Internal.MetricsHandler.InvokeAsync[T](IExecutionContext executionContext)

Reproduction Steps
Have the following confiig line for an AWS Store (Customized to your relevant Minio URL)
awsOptions.DefaultClientConfig.ServiceURL = "minio.blah.randomurl.com/bucketname/";
Possible Solution
No response
Additional Information/Context
No response
AWS .NET SDK and/or Package version used
AWSSDK.S3 3.7.309.2
Targeted .NET Platform
Net 8
Operating System and version
Docker Container Built on Windows running on Linux

@Edstub207 Good morning. Thanks for opening the issue. Are you unable to use AmazonS3Config.ForcePathStyle in AWS .NET SDK? Please confirm.
Kindly note that we do not support using AWS .NET SDK with 3rd party AWS simulated services. SDK might work for certain scenarios, however, there are always some edge cases.
Thanks,
Ashish

@ashishdhingra thanks for the reply, an ex-colleague pointed me towards some reference code which I missed when looking into this and that's solved my problem!


Remove --verbose argument from canonical sandbox run.sh script

There was a bug fix change in #434, when --version  was changed to --verbose  in  sandbox/canonical/run.sh.
Maybe we need to remove this argument for default behavior to clear console output from a large amount of text (according to the #434 issue)?

@Graur I also think it would be better to clear the console output.
We can change to sandbox/canonical/run.sh --verbose?
So --verbose is not required
@Graur and @yegor256 What do you think?

@marceloamadeu I agree. It took me a while to figure out what was going wrong when I ran this script for the first time.

@Graur done in 0196d63e thanks!


Uncaught Error: Cannot find module 'space-pen'

[Enter steps to reproduce below:]

...
...

Atom Version: 1.6.0
System: Ubuntu 15.10
Thrown From: merge-conflicts package, v1.3.7
Stack Trace
Uncaught Error: Cannot find module 'space-pen'
At module.js:338

Error: Cannot find module 'space-pen'
    at Module._resolveFilename (module.js:336:15)
    at Function.Module._resolveFilename (/opt/atom/resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (/opt/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/pld/.atom/packages/merge-conflicts/lib/view/merge-conflicts-view.coffee:1:13)
    at Object.<anonymous> (/home/pld/.atom/packages/merge-conflicts/lib/view/merge-conflicts-view.coffee:1:1)
    at Module._compile (/opt/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .coffee] (/opt/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/opt/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Object.<anonymous> (/home/pld/.atom/packages/merge-conflicts/lib/main.coffee:3:24)
    at Object.<anonymous> (/home/pld/.atom/packages/merge-conflicts/lib/main.coffee:1:1)
    at Module._compile (/opt/atom/resources/app.asar/src/native-compile-cache.js:103:30)
    at Object.defineProperty.value [as .coffee] (/opt/atom/resources/app.asar/src/compile-cache.js:208:21)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (/opt/atom/resources/app.asar/src/native-compile-cache.js:50:27)
    at Package.module.exports.Package.requireMainModule (/opt/atom/resources/app.asar/src/package.js:720:27)
    at Package.module.exports.Package.activateConfig (/opt/atom/resources/app.asar/src/package.js:220:12)
    at PackageManager.<anonymous> (/opt/atom/resources/app.asar/node_modules/settings-view/lib/package-manager.js:55:14)
    at PackageManager.packageHasSettings (/opt/atom/resources/app.asar/node_modules/underscore-plus/node_modules/underscore/underscore.js:658:63)
    at PackageCard.module.exports.PackageCard.hasSettings (/opt/atom/resources/app.asar/node_modules/settings-view/lib/package-card.js:611:34)
    at PackageCard.module.exports.PackageCard.initialize (/opt/atom/resources/app.asar/node_modules/settings-view/lib/package-card.js:205:17)
    at PackageCard.View [as constructor] (/opt/atom/resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:184:25)
    at new PackageCard (/opt/atom/resources/app.asar/node_modules/settings-view/lib/package-card.js:22:48)
    at InstallPanel.module.exports.InstallPanel.addPackageViews (/opt/atom/resources/app.asar/node_modules/settings-view/lib/install-panel.js:280:41)

Commands

Config
{
  "core": {
    "disabledPackages": [
      "language-swift",
      "language-swift",
      "language-swift",
      "minimap-find-and-replace",
      "minimap-git-diff",
      "minimap-pigments",
      "minimap"
    ]
  }
}

Installed Packages
# User
autocomplete-atom-api, v0.10.0

# Dev
No dev packages

I notice that merge-conflicts doesn't appear in your "Installed Packages" summary, which strikes me as odd. Was the installation interrupted or corrupted somehow?
Try deleting the ~/.atom/packages/merge-conflicts directory and re-running apm install merge-conflicts.

ok reinstall worked, thx ;)


WTFPL

Popular license and valid alternative to public domain.
OpenStreetMap editors Potlach2 and iD are two examples of software with this license.
(I'm pulling this for the lulz, I don't think it will be merged :-) )

https://github.com/github/choosealicense.com/pull/210 which also implements, is currently open for discussion.


Metadata editor allows defining editor-only metadata

Godot version
4.0.alpha (c630c2001)
System information
Fedora 34, GeForce GTX 1080 (NVIDIA 510.60.02)
Issue description
The new metadata editor allows defining editor-only metadata, but not reading it. This is probably confusing and should be disallowed (although setting editor-only metadata from code should remain allowed).
Steps to reproduce

Add a node.
Select the node in the Scene tree dock, go to the inspector and click Add Metadata at the bottom.
Add metadata with the name _test.
Notice that the metadata doesn't appear in the inspector.
Attach a script to the node, with print(has_meta("_test")) in the _ready() function.
Run the project. Notice that it prints true since the metadata is defined – it's just not visible in the editor.

Minimal reproduction project
test_editor_only_metadata.zip

Here's a relevant code:
https://github.com/godotengine/godot/blob/c630c2001dbe2e25e0d372bd22ce85cdc2822eb0/editor/editor_inspector.cpp#L3717-L3723

Can i work on this issue? I would like to solve this issue as my first open source contribution !

Can i work on this issue? I would like to solve this issue as my first open source contribution !

Sure :slightly_smiling_face:

I think I know what happens.
Here is line 2589
} else if (p.name.begins_with("metadata/_") || !(p.usage & PROPERTY_USAGE_EDITOR) || _is_property_disabled_by_feature_profile(p.name) || (restrict_to_basic && !(p.usage & PROPERTY_USAGE_EDITOR_BASIC_SETTING))) {
	// Ignore properties that are not supposed to be in the inspector.
	continue;
}

So if the property's name start as "metadata/", it skips rendering the property. Remove it will make it the property show in the inspector. But I think the programmer who do this intends to hide metadata starts with "" in the inspector, as the inspector automatically remove "_" and replace it to space if appropriate (just like how export var a_variable will becomes "A variable"), this will causes the metadata _test (display as "Test") appears same as test (display as "Test")
Here is a picture to show what I am describing:

the first metadata is test, the second one is _test, while the third one is __test.
I suggest that to forbid using "" as the first character in naming metadata. Well, "" as the first character when naming variable (by convention) means that it is a private variable but metadata aren't suppose to be private, and to be read by the script that is append to the node.
And this is my first open source contribution, I am glad to contribute my beloved game engine!


implement CaseInsensitive#column_for_order(asc_or_desc).

It returns an Arel::SqlString for use in .order()

@glebm I'm going to merge this so I don't get blocked, but please add comments if anything needs to be tweaked and I will fix in a new PR.