[BUG] Unable to access docker daemon

Describe the bug
Oxker will not start.
To Reproduce

oxker
See the screen with the message and auto exit.

Trying to run oxker with no-gui for debugging results in a permanent hang with no messages printed after
2023-07-19T15:35:29.173577Z  INFO oxker: in debug mode

Expected behavior
A screen similar to that which is in the README screenshot. Essentially oxker should be aware of docker contexts, but must be aware of $DOCKER_HOST if set.
Screenshots

Desktop (please complete the following information):

OS: macOS
Virtualization Solution: OrbStack without the symlinked socket

My socket is in ~/.orbstack/run/docker.sock.
Additional context
Setting $DOCKER_HOST does not help.
$ docker context ls
NAME          DESCRIPTION                               DOCKER ENDPOINT                                  ERROR
colima-vz-8   colima [profile=vz-8]                     unix:///Users/austin/.colima/vz-8/docker.sock
default       Current DOCKER_HOST based configuration   unix:///var/run/docker.sock
orbstack *    OrbStack                                  unix:///Users/austin/.orbstack/run/docker.sock

Yeah, oxker should definitely correctly read and handle the $DOCKER_HOST env.
As for the debug mode, again, yes it should force quit(?) if a docker connection cannot be achieved.
In the mean time, I think you should be able to use the DockerHub/ghcr image, but mount your custom socket instead of the default:
docker run --rm -it -v ~/.orbstack/run/docker.sock:/var/run/docker.sock:ro --pull=always mrjackwills/oxker
Although obviously this isn't a good long term solution.
Unfortunately I am away from my computer for at least another week, so I can't test, or implement, any fixes at the moment. Rust 1.70 has just been released, and I usually try to follow the same six week release schedule with oxker.

@halostatue I've just pushed a branch fix/host, which I think should solve the issue. A new cli arg is available, --host, to set the docker host path. However, it'll also check for a $DOCKER_HOST env, at the moment the cli arg takes priority over the env - do you think this is the correct order?
Secondly, when in debug mode, it should exit with code 1 if there are any errors - amazed that this hasn't come up before and that I missed this.
If you are unable, or unwilling, to build from source, let me know and I can upload a binary here.

I’ll need to come back to this in a couple of days, but I can try it from source.

Sorry for the long delay, but the fix/host branch works when setting $DOCKER_HOST. Ideally, oxker should work such that it can query the Docker contexts to find the current list and get the socket directly:
$ docker context ls --format '{{ . | json }}' | jq -s '.[] | select(.Current == true) | .DockerEndpoint'
"unix:///Users/austin/.orbstack/run/docker.sock"

But this can be considered closed because it now works with $DOCKER_HOST.

@halostatue Thank you for taking the time to check that it works. I wasn't really aware of the Docker context before you submitted the issue. I should probably read the docs further to make sure I fully understand it, to make oxker find the context automatically and correctly as you suggest.
One final note, did you manage to test the --hostname cli arg, and if so did that work correctly?
Thanks again

It does:
$ oxker --host (docker context ls --format '{{ . | json }}' | jq -r -s '.[] | select(.Current == true) | .DockerEndpoint')

(I use fish, so that’s why the lack of $.)

Perfect thanks, I'll merge the branch, and probably wait til rust 1.72.0 on August 24th before publishing a new version. Will do some testing about auto context finding that can be terminal agnostic.

I’ve done a bit more research, and I think that there’s an opportunity for a crate here to improve Docker context support across Rust projects. I suspect that there’s explicit code that could be translated from Go in the docker command-line itself, but here’s what I have seen:

contexts are external to the Docker API, managed entirely in ~/.docker.
the current context is found via [~/.docker/config.json].currentContexst
contexts themselves are defined in ~/.docker/contexts/meta/*/meta.json; the directory between meta/ and meta.json appears to be some sort of UUID-ish value (it might be a hashed value of the context name)
the contents of meta.json is incomplete compared to docker context inspect --format json CONTEXT

meta.json:
{
  "Name": "orbstack",
  "Metadata": {
    "Description": "OrbStack"
  },
  "Endpoints": {
    "docker": {
      "Host": "unix:///Users/austin/.orbstack/run/docker.sock",
      "SkipTLSVerify": false
    }
  }
}

docker context inspect --format json orbstack
[
  {
    "Name": "orbstack",
    "Metadata": {
      "Description": "OrbStack"
    },
    "Endpoints": {
      "docker": {
        "Host": "unix:///Users/austin/.orbstack/run/docker.sock",
        "SkipTLSVerify": false
      }
    },
    "TLSMaterial": {},
    "Storage": {
      "MetadataPath": "/Users/austin/.docker/contexts/meta/2d89b732b01a00a2d1675ed3cee9fd0f965daadf90603c989dd3afd4569c6896",
      "TLSPath": "/Users/austin/.docker/contexts/tls/2d89b732b01a00a2d1675ed3cee9fd0f965daadf90603c989dd3afd4569c6896"
    }
  }
]

Ignoring the fact that docker context inspect --format json returns an array, there are two additional keys TLSMaterial (unknown contents, empty in my context) and Storage (which is constructed from the discovered file paths themselves).
I’m not good enough with Rust to build such a crate, nor do I really have an interest in maintaining such a crate (my interest in Docker and related tools is as a user, not someone who wants to build tools for Docker), but this is what I have found.

Thank you, highly informative and helpful.
oxker uses a crate called bollard to communicate with Docker. They actually have an open issue at the moment that I think might be related (I still haven't read enough into the Docker context, it's on my todo list) https://github.com/fussybeaver/bollard/issues/310

The issue isn’t related to contexts, but is related to automatic resolution of $DOCKER_HOST if it isn’t pointing to a Unix socket, if I’m reading it correctly. That said, bollard is probably the right place to add this functionality, since it’s where connections are resolved.
If I were to weigh in on that, I would suggest:

Docker::connect_with_context_defaults() - follows the Docker CLI behaviour ($DOCKER_HOST overrides any context, checks the currentContext value and resolves that if not default, falls back to Docker::connect_with_socket_defaults() otherwise)
Docker::connect_with_context() - parameterized context start, which I believe would ignore $DOCKER_HOST, but I’m not sure.

Those could also be simplified as Docker::connect_with_defaults() or Docker::connect(), but I’m not sure that the creator of bollard would want that, based on the comments there.
If you decide to implement this independently of bollard, you would basically be getting the EndPoints.docker.Host value and using Docker::connect_with_socket() if it does not start with tcp:// and Docker::connect_with_ssl() if it starts with tcp:// and SkipTLSVerify is false (the default).


A few questions about the real experiment of pensieve

Hi hongzi, I have trained a model and found it performs well in test traces. I tend to apply it into real experiment and implement a presentation effect like that in the beginning your video, namely two videos are being played and the bitrates are showed in lower right corner. However, I am not fully understand what I should do according to your README.md.

According to the REAME.md, I need to setup a server, then the video file should be put in local? Or I can open a specific website to download the video?
What are the files like 'myindex_BB.html' used for ? Each of them may just have a empty video player? Or I need this to play the video?

I would appreciate it if you can give some tips or some more detailed steps. Thanks you !

Please follow the Running experiments over Mahimahi section in README.md. The network is emulated using mahimahi, therefore server and client can both be on your local machine. Alternatively, you can run experiments over the real network. To do that, follow Real-world experiments in README.md.

myindex_BB.html is using "buffer-based" ABR algorithm. They actually load a video provided in video_server. To massively run the experiment, we load video in a virtual display. Details can be found in README.md.

I did follow the README.md step by step, but I get stuck in this instrcution modify url in run_video.py to the server address. Maybe the server address points to the apache2 server ? I referred to some tutorials to setup an apache2 server, but they seemed to be not useful. For this project, is there any suitable tutorials to set a server ? By the way, is there any limitations for video format ? Or just a .mp4 file is OK ?

I think I am gradually familiar with the environment and can make the video played in the virtual browser. But I still have a question: when I do real world experiments, what limit the transmission speed? If I want to limit the speed according to my settings, I need to restart the apache2 server, which may interrupt the video playing...


Extend the findForEditing method so that excluding future-dated posts…

… in the frontend by default does not wreck the editing experience

Should be merged after the corresponding PR in apostrophe.


lcov targets fail with Ninja

The same example provided in issue #6 shows that also the support for lcov is failing when using the Ninja generator.
$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DENABLE_COVERAGE=ON ..
$ ninja -v foo
[1/2] /usr/bin/c++    -g    -O0 -g -fprofile-arcs -ftest-coverage -MD -MT CMakeFiles/foo.dir/test.cc.o -MF CMakeFiles/foo.dir/test.cc.o.d -o CMakeFiles/foo.dir/test.cc.o -c ../test.cc
[2/2] : && /usr/bin/c++  -g  -O0 -g -fprofile-arcs -ftest-coverage CMakeFiles/foo.dir/test.cc.o  -o foo   && :
$ ./foo
Hello World!
$ ninja -v foo-genhtml
[1/8] cd /home/giaco/tmp/lcov-cmake/build && /usr/bin/geninfo --quiet --base-directory /home/giaco/tmp/lcov-cmake --initial --gcov-tool /usr/bin/gcov-7 --output-filename /home/giaco/tmp/lcov-cmake/build/CMakeFiles/foo.dir/test.cc.info.init --no-external /home/giaco/tmp/lcov-cmake/build/CMakeFiles/foo.dir/test.cc.gcno
geninfo: WARNING: could not open /home/giaco/tmp/test.cc
geninfo: WARNING: some exclusion markers may be ignored
[2/8] cd /home/giaco/tmp/lcov-cmake/build && cat /home/giaco/tmp/lcov-cmake/build/CMakeFiles/foo.dir/test.cc.info.init > /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info.raw
[3/8] cd /home/giaco/tmp/lcov-cmake/build && /usr/bin/lcov --quiet -a /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info.raw --output-file /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --base-directory /home/giaco/tmp/lcov-cmake --initial && /usr/bin/lcov --quiet -r /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --output-file /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --initial
FAILED: lcov/data/init/foo.info
cd /home/giaco/tmp/lcov-cmake/build && /usr/bin/lcov --quiet -a /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info.raw --output-file /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --base-directory /home/giaco/tmp/lcov-cmake --initial && /usr/bin/lcov --quiet -r /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --output-file /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info --initial
lcov: ERROR: no valid records found in tracefile /home/giaco/tmp/lcov-cmake/build/lcov/data/init/foo.info.raw
ninja: build stopped: subcommand failed.

At least the first error (geninfo: WARNING: could not open /home/giaco/tmp/test.cc) can be fixed passing ${CMAKE_BINARY_DIR} instead of ${CMAKE_SOURCE_DIR} to the --base-directory option of geninfo. This because Ninja works with paths relative to the binary directory.
Everything works fine with the Makefile generator, which works with absolute paths.

Could you provide a patch for this issue? I can reproduce the issue, but unfortunately I'm not familiar with ninja.

Me neither :-) but I'll try. Give me a few days.

There a number of potential issues with using the CMake-codecov library with Ninja in its current form which you might be encountering.  The first is that when you perform in source builds with Ninja via CMake even if you pass paths in absolute form Ninja will convert them to relative form (this is a problem because the library in its current form generated GCov information with relative paths), see details here: https://gitlab.kitware.com/cmake/cmake/-/issues/13894
Craig Scott proposed the correct solution here: https://gitlab.kitware.com/cmake/cmake/-/issues/20001.  That is the Gcc supports a flag, -fprofile-abs-path, which ensures that coverage information store absolute paths in the resulting *.gcno & *.gcda file.  See the details of this flag here: https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Instrumentation-Options.html.  This can be tested for and appended to the current coverage flags by testing for support first as is already done within the library:
            set(__coverageFlags --coverage)
            check_cxx_compiler_flag(-fprofile-abs-path HAVE_fprofile_abs_path)
            if(HAVE_fprofile_abs_path)
                list(APPEND __coverageFlags -fprofile-abs-path)
            endif()

The next potential issue and the one it looks like you are encountering here is that geninfo will only generate info for files from the *.gcda files that it finds in the path of the --base-directory passed in when invoking geninfo.  The geninfo documentation explicitly mentions this scenario in its documentation and say if this happens to just call geninfo multiple times (with the --ignore-errors flag to silence errors) with different base directories and then to combine using the -a (I assume though it does not say that this part means when calling the lcov executable to append info).  One common scenario this happens (and the one I ran into) is where your project created generated file which are wrote to the binary directory, in which case geninfo must be called again with the binary directory in the --base-directory flag to extract coverage information for generated source files.
If any of this is not clear or you have questions then let me know.  It would be great to see these issues resolved in the library.


Remote video feed does not render

Description
Hello,
We used programmable video iOS SDK (version: 1.3.7) for the multiparty video call. The problem is whenever we do a multiparty video call, the call gets connected and sound transmitted well but remote video feed does not render on remote view.
We debug the code to see whats wrong, we found that no delegate method of the 'TVIRoomDelegate' is getting called. Also, we check Twilio VideoQuickStart (version: 'TwilioVideo', '~> 1.4') demo app but the same result.
We facing this issue from yesterday only, before it was worked properly.
Expected Behavior
Remote video feed should render on remote view.
Actual Behavior
Remote video feed does not render on remote view.
Reproduces How Often
The issue occurs with every video call that we have raised.
Logs
Please find logs from below URL:
(https://docs.google.com/document/d/1fO6f42Qyyl7eyZ_nDOqcp7KwS5MxwaxchTCCvEUy77k/edit?usp=sharing)

Versions
'TwilioVideo', '~> 1.4'
Video iOS SDK
1.4 via CocoaPods

Actually, we have set video codec H.264 on our programmable video console setting, and we used iOS 1.x SDK, that only supports VP8 (and VP9). So we changed codec H.264 to VP8 & H.264 and it's working.

Good morning @nfasate,
Investigating this ticket was the first thing on my agenda for this morning and I see that you already resolved it. Yes, the 1.x version of the SDK doesn't support H.264. The 2.x releases have been GA'd a few weeks ago and offer this support. Is there a reason why you haven't investigated moving to the latest release? We won't be adding any new features to the 1.x version, so I would suggest at least trying out the 2.x version so you can benefit from any new features and bug fixes that we release.
If you have any further questions, please don't hesitate to reach out.
Ryan


Add transform-runtime to .babelrc

By including the transform-runtime babel plugin, we make sure that the libary itself doesn't require any babel dependencies after it has been built as per the discussion in #50

Coverage remained the same at 86.772% when pulling f348d79bb2afb288030f2b560d57c25c30c50b19 on unfold:client-schema-loader-transform-runtime into da351717603ca53b3e7ce3f4f5faaab539e708d2 on mattkrick:master.

failing on node version 4 since transform-runtime is not found. Do we need to add it to the dependencies?

Coverage remained the same at 87.179% when pulling d17808db8aa271ace6e179e5d174f1d8afe6a9da on unfold:client-schema-loader-transform-runtime into c5251d9127302b9dee5ef2f324dc1b7c64394613 on mattkrick:master.

@mattkrick I added the missing dependencies now

up on npm at v0.11.2. Thanks @simenbrekken!


Scoring: continuous dist against a scalar

_ Is refactor
x Is new feature
_ Concerns documentation

Description of suggestion:
Score a continuous distribution when the question resolves to a scalar.

I imagine this will be pretty simple, might do discrete at some time.

This went into #521 but the interface for the squiggle user was punted to a later story.


Don't assume all LSP clients provide "textDocument/semanticTokens/full"

When using https://github.com/zbirenbaum/copilot.lua, GitHub Copilot runs as an LSP client in the buffer alongside other LSP providers (e.g. idris2-lsp), and doesn't provide the functionality this plugin expects. Is there perhaps a way to handle such errors gracefully, or to not request functionality from the wrong LSP clients in the first place?
What happens whenever the plugin runs alongside any such clients:
Error executing vim.schedule lua callback: /usr/share/nvim/runtime/lua/vim/lsp.lua:1018: not found: "textDocument/semanticTokens/full" request handler for client "copilot".
stack traceback:
        [C]: in function 'error'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1018: in function 'request'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1485: in function 'fn'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:164: in function 'for_each_buffer_client'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1484: in function 'buf_request'
        ...te/pack/packer/start/idris2-nvim/lua/idris2/semantic.lua:8: in function 'request'
        ...m/site/pack/packer/start/idris2-nvim/lua/idris2/init.lua:18: in function '_on_attach'
        ...ck/packer/start/nvim-lspconfig/lua/lspconfig/configs.lua:273: in function '_setup_buffer'
        ...ck/packer/start/nvim-lspconfig/lua/lspconfig/configs.lua:183: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

The relevant code:
https://github.com/ShinKage/idris2-nvim/blob/fdc47ba6f0e9d15c2754ee98b6455acad0fa7c95/lua/idris2/semantic.lua#L5-L9

I will work on it during the May IDM. I already have an idea on how to solve the issue, but I also want to do some refactoring.

@gekoke Can you check if #18 solves the issue?


Change chat warning msg / delay

Players think i'm a bot when chat warning msg's are turned on and they are attempting to kick their bot. I personally feel they are too frequent and would love the option to be able to adjust the warning frequency.

Pazer is no longer updating the program. If you would like custom messages or want to change the message frequency, consider using Sleepy's build.

Thank you! Their updated build works great


TypeScript setup

Did my best!
I added src and dist folders and set up so that it should update src files to dist files.

Looks good to me! Can someone else also check this one! :)

Good job. We can work with this.


Feature Request: Command browser (like in ISE)

It would be nice if there was a simple way to:

Find a command that does what you want
View usage instructions for the command
View documentation for the command

In Powershell ISE, this is accomplished through the "Commands" sidebar. In Visual Studio for C#, this is accomplished through the "Object Browser" window. It would be great if poshtools had something similar.

@AndreSayreMSFT @adamdriscoll
I've started some work on this. At the moment it's functional but not yet feature complete.
Things it can do:

List all PowerShell command grouped by module. (local machine only)
Search PowerShell commands by name.
Dragging a command from the list onto the code window, which will insert the command. (No parameter support yet but planning on adding this)
Show some basic help for a command. (Of which the formatting could still do with a little work)
I've kept all the code separate from the current code base, I've only added a reference to this package to the PoshTools package.

See image below for an impression.
I'm still continuing to work on this, but please let me know if you are interested in adding this and I'll send a pull request.

@erwindevreugd This is great! I like how it's looking so far. ISE parity is important to PoshTools so this is a great addition. Not sure how you have the code laid out right now but I'm sure you could add it to the core PoshTools either through a seperate project or just by including it as a tool window in the PowerShellTools.csproj.

At the moment its a separate project to which I've added a reference in PowerShellTools project.
I've wanted to keep the code bases separate (at least for the moment) so as to not introduce any unexpected code changes for you guys. It doesn't contain a lot of duplicate code anyway.
My fork is here: https://github.com/erwindevreugd/poshtools/tree/command-explorer

Very cool!


Sequence type update via api endpoint

It'd be great if we could update the sequence type field with the api endpoint since this doesn't seem to be possible currently.
I've added the field to the update_sequence call itself in the api route, as well as in the db layer. Then in the sequence table definitions, I've added sequence type to the updaters and fields so it should get included with the update query when this is called.
@illusional do you think these changes will enable this field to be changed? Thanks!

Codecov Report
Patch coverage: 33.33% and project coverage change: -0.02 :warning:

Comparison is base (cac0d54) 67.78% compared to head (5732472) 67.77%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #426      +/-   ##
==========================================
- Coverage   67.78%   67.77%   -0.02%
==========================================
  Files          72       72
  Lines        5849     5852       +3
==========================================
+ Hits         3965     3966       +1
- Misses       1884     1886       +2

Impacted Files
Coverage Δ

api/routes/sequence.py
47.88% <ø> (ø)

db/python/layers/sequence.py
80.45% <ø> (ø)

db/python/tables/sequence.py
84.23% <33.33%> (-0.70%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

not sure where all these other commits came from, I think because I branched from main not dev.
Anyway, I think they can be ignored for now, if the change is good i'll branch it properly from dev and create a PR to merge back into dev.


:wrench:  enable eslint commented rules

Description
Enable remaining eslint rules previously commented.
Checklist

[x] My changes follow the contributing guidelines of this project.
[ ] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[ ] New and existing unit tests pass locally with my changes.

coverage: 94.207% (+0.02%) from 94.191% when pulling 5321353d8fbcdf3429befca1cdcfecfcdbc044f0 on chore/eslint-enable-unused-rules into 61a214b61b010eaf7eb79b1783a36565ad2d804e on main.


No Healthy Upstream Issue : After deploying everything using Microsoft Docs - Traffic splitting with Application Gateway for Containers - Gateway API

Type of issue
Code doesn't work
Feedback
I have followed everything using MS docs as given below but errors out stating : No healthy upstream
https://learn.microsoft.com/en-us/azure/application-gateway/for-containers/how-to-traffic-splitting-gateway-api?tabs=byo
Even Tried adding Custom Health Probe HealthCheckPolicy  as suggested below
https://github.com/MicrosoftDocs/azure-docs/pull/115624
Custom HealthCheckPolicy deployment errors out stating below
strict decoding error: unknown field "spec.default.http.port", unknown field "spec.default.http.protocol"
Here is my yaml ,
apiVersion: alb.networking.azure.io/v1
kind: HealthCheckPolicy
metadata:
name: gateway-health-check-policy
namespace: test-infra
spec:
targetRef:
group: ""
kind: Service
name: aks-helloworld-one
namespace: test-infra
default:
interval: 5s
timeout: 3s
healthyThreshold: 1
unhealthyThreshold: 1
protocol :  HTTP
port: 3000
http:
path: /
match:
statusCodes:
- start: 200
end: 299
Please suggest !!!
Page URL
https://learn.microsoft.com/en-us/azure/application-gateway/for-containers/how-to-traffic-splitting-gateway-api?tabs=byo
Content source URL
https://learn.microsoft.com/en-us/azure/application-gateway/for-containers/how-to-traffic-splitting-gateway-api?tabs=byo
Author
Microsoft Docs
Document Id
azure-docs

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 003fe55f-38fe-535c-42dd-a4af94e2efe9
Version Independent ID: b4304b2c-82fd-d816-47fc-11ea6e904a16
Content: Traffic Splitting with Application Gateway for Containers - Gateway API
Content Source: articles/application-gateway/for-containers/how-to-traffic-splitting-gateway-api.md
Service: application-gateway
Sub-service: appgw-for-containers
GitHub Login: @GregLin
Microsoft Alias: greglin

@tonycesta2628
Thanks for your feedback! We will investigate and update as appropriate.

Hi @tonycesta2628
I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1)
Thank you for your time and patience throughout this issue.


Update fast-sha256 dependency

Is your feature request related to a problem? Please describe.
When building Angular 14 application with reference to angular-oauth2-oidc, the following warning occurs:
\node_modules\angular-oauth2-oidc\fesm2015\angular-oauth2-oidc.mjs depends on 'fast-sha256'. CommonJS or AMD dependencies can cause optimization bailouts.
fast-sha256 dependency is a CommonJS library which  prevents bundlers and minifiers from optimizing an application (according to Angular official doc)
Describe the solution you'd like
Replace fast-sha256 library with any other suitable counterpart which is built using ECMAScript modules feature.

Will be resolved in next version.


Pasting value may drop information without user noticing

Example 1
Field with formatting NumeralFieldFormatter(",", ".", 2) will format

1200.049 → 1,200.04 (rounding issue)
1.200,00 → 1.20 (wrong symbols in input)

Example 2
Field with formatting CustomStringBlockFormatter.Builder().blocks(3, 3, 3).delimiters("-") will format

123 456 789 → 123- 45-6 7 (spaces taken as characters)

Example 3
Field with formatting IBANFormatter.fromIBANLength(18) will format

GB29 NWBK 6016 1331 9268 19 → GB29 NWBK 6016 1331 92 (dropping last numbers due to limited length)

Improvement idea
As generic solution, component should recognize if inputted characters are cut out. This is mainly an issue when pasting in values.
Component could also indicate if user is trying to type in a field that has already reached the max number of characters.

After investigation, the javascript library cleave.js doesn't give any hook or any solution to see if the value has been stripped or not.
That would require to change the javascript and that doesn't seem to be easy to do.


Unable to Register a Passkey Using a PIN Code

Describe the issue
Environment: Devices that cannot use biometric authentication  (macOS Ventura 13.2.1 clamshell mode and Android emulator virtual terminal Pixel 7 Pro API 33)
Click and press the "Register" button in the SimpleWebAuthn Example Project  and try to register passkey, the following error response is returned.
 "error": "User verification required, but user could not be verified"
The settings for the authenticator are set as follows
authenticatorSelection: {
    authenticatorAttachment: "platform",
    residentKey: "preferred",
    userVerification: "preferred"
}

In addition to this, I tried several other patterns with different settings for userVerification and residentKey, and the same error occurred.
Reproduction Steps
Expected behavior

I expected to be asked for a PIN code or password to unlock the screen lock, and after entering it, I would register a passkey

Code Samples + WebAuthn Options and Responses

Dependencies

macOS Ventura 13.2.1
Chrome 120

SimpleWebAuthn Libraries

$ npm list --depth=0 | grep @simplewebauthn
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS># ...

Additional context

Hello @Yoichiro-Y, thank you for creating an issue about this. Fortunately this is very similar to https://github.com/MasterKale/SimpleWebAuthn/issues/477, which I fixed almost an hour ago in #500. Can you pull down the latest master branch and try again? I tested myself on my own MacBook Pro in clamshell mode and was able to complete both registration and authentication without being prompted for my system password (since biometrics are of course unavailable in this configuration.)

@MasterKale , thank you for your reply. I tried it with the latest master branch and it works as expected in clamshell mode!


Could not build Objective-C module 'flutter_freshchat'

This is happening since version 1.3.0.
info flutter.tools <unknown>:0: error: could not build Objective-C module 'flutter_freshchat'

Desktop (please complete the following information):

OS: Mac
Device: IOS Simulator
Version: 13.4

I am also facing the same in version 1.3.0. I can't even run the sample app.

I made a version comparison https://github.com/fayeed/flutter_freshchat/issues/34

@krel024 take a look at issue #31 it should resolve this issue and I am closing this.


nwg-hello: init at 0.1.6

Description of changes
Closes: https://github.com/NixOS/nixpkgs/issues/279709
Might try working on module right away to use it.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Sorry, missclicked!


Feature/public groomer profile

Description
IN PROGRESS: Updated view of the public facing groomer file page. Shows rating, hours of operation, about section, address, location, and services.
Type

[ ] This is a bugfix.
[x] This is a new feature.
[ ] This is part of a feature.

Organization

[ ] Have you linked this pull request to a Trello card?
[x] Have you named the branch in the format of feature/describe_feature_or_change OR bug/describe_bug_this_is_fixing

Review

[x] Is this a work in progress?
[ ] Is this ready to be reviewed?
[ ] Have you added two reviewers to this pull request?

 GroomerSearchResults needs to be renamed, it is the public facing groomer component, and it should display services offered and hours

 GroomerSearchResults needs to be renamed, it is the public facing groomer component, and it should display services offered and hours

 GroomerSearchResults needs to be renamed, it is the public facing groomer component, and it should display services offered and hours

 GroomerSearchResults needs to be renamed, it is the public facing groomer component, and it should display services offered and hours


added youtube completion

#1295
Added bash completion for youtube-dl

The file you added pretty much looks like 1:1 copy from the youtube-dl repo's completion file - I really don't want to duplicate this here.
When you install youtube-dl, it should automatically install its own Bash completion script into your Bash environment (at least this happened for me on macOS with Homebrew - the completion is in /usr/local/etc/bash_completion.d). From there, you can load it using the system completion component in Bash-it - does this work for you?

@nwinkler I agree what you say
but its not Cross Platform
in my OS youtube completion is stored in /usr/etc/bash_completion.d/youtube-dl.bash-completion

This PR may help newbies to enable completions from bashit framework easily :smile:

So i am closing this PR right now


Refresh and use user token's endpoints for openstack api call.

Why do we have this PR:
We are now using admin token to get service endpoints(compute, network, identity..)
The normal way should be using the user token. 2 benefits:

The passed-in user token should not be used directly, since it may be expired in a very short time(eg. < 1s), but the operation takes a longer time. So we need to refresh a new user token and do the following works with it.
We can get service endpoints directly from user token's catalogs, instead of assembling it from admin tokens.

I do not know this part of code very well, but I have a general question: Is it appropriate for us to refresh user's keystone token? Will the previous token become invalid, after we refreshing it?

Refreshing a token means using the given token to retrieve a new token. The two tokens are different ones. And the later token is new with full expiration time.

the default time for a token is 1 hour? if i remember correctly. what's more, that is also configurable in keystone.  Have no idea why we need to refresh for a new token inside our code.  If a token provided is expired, shouldn't we ask for a valid token instead?

I do not know this part of code very well, but I have a general question: Is it appropriate for us to refresh user's keystone token? Will the previous token become invalid, after we refreshing it?

Refreshing a token means using the given token to retrieve a new token. The two tokens are different ones. And the later token is new with full expiration time.

Will the old token become invalid, when the new one is generated?

the default time for a token is 1 hour? if i remember correctly. what's more, that is also configurable in keystone. Have no idea why we need to refresh for a new token inside our code. If a token provided is expired, shouldn't we ask for a valid token instead?

The expiration time is decided by keystone(default is 1 hour).
The token user provides may expire in the middle of the operation(e.g. create port/virtual server..). We have no way to ask the user to input a new token, but fail and exit.
Refreshing a token can guarantee the operation done, since we have accurate expire time thus(token is new).

I do not know this part of code very well, but I have a general question: Is it appropriate for us to refresh user's keystone token? Will the previous token become invalid, after we refreshing it?

Refreshing a token means using the given token to retrieve a new token. The two tokens are different ones. And the later token is new with full expiration time.

Will the old token become invalid, when the new one is generated?

The old one is user's, it'll not become invalid, it is owned by user and has its own expire time.

if the token provided by the user expires in a short time period(e.g.  several seconds) , we should let it fail and reports an error   because refreshing for a new one  is out of our scope.  I don't think we need to refresh for a new one in order to ensure the success.

if the token provided by the user expires in a short time period(e.g. several seconds) , we should let it fail and reports an error because refreshing for a new one is out of our scope. I don't think we need to refresh for a new one in order to ensure the success.

It sounds like more that it fails because our operation takes too long the time, not because user's token is nearly expired.
User may say that "the token I give you is valid, why do you give me an error saying invalid token...".
Refreshing the token, at the same time, is the way to validate the old token.

are you suggesting if any api of those project(e.g. nova, glance, heat etc) takes a relatively longer time to finish,  that api should include a refresh-token logic inside it because the token might expire ?       Anyway,  i think we should not bring any NOT-MUST-HAVE logic into our code and try to keep our code as simple as possible, so I still don't see the necessity for that.  Also, I doubt there is such kind of refresh-token logic in other openstack projects.  Go ahead and merge it if you still think you want this part.

are you suggesting if any api of those project(e.g. nova, glance, heat etc) takes a relatively longer time to finish, that api should include a refresh-token logic inside it because the token might expire ? Anyway, i think we should not bring any NOT-MUST-HAVE logic into our code and try to keep our code as simple as possible, so I still don't see the necessity for that. Also, I doubt there is such kind of refresh-token logic in other openstack projects. Go ahead and merge it if you still think you want this part.

To me, I prefer to make the code as stable as possible when we notice the very issue, even only a possible issue.

I do not know this part of code very well, but I have a general question: Is it appropriate for us to refresh user's keystone token? Will the previous token become invalid, after we refreshing it?

Refreshing a token means using the given token to retrieve a new token. The two tokens are different ones. And the later token is new with full expiration time.

Will the old token become invalid, when the new one is generated?

The old one is user's, it'll not become invalid, it is owned by user and has its own expire time.

I feel this idea is to generate a new token from a existing token provided by user, and the new token will be used by our app to manipulate openstack resources. If the existing token will not be impacted, that can be an idea. And we may also consider to revoke this new token appropriately, since it is a new resource created by us. Another thing which should be consider is the scope of the token. The new token should be a project scope token, because our app might not manipulate system scope resources. However, the token input by user may be a system scope token. For example, an admin who has a system scope token hope to modify an ADC in a user's project. We will need to generate a new token for this specific project scope from admin's token. I am not quite sure if keystone supports that.

I do not know this part of code very well, but I have a general question: Is it appropriate for us to refresh user's keystone token? Will the previous token become invalid, after we refreshing it?

Refreshing a token means using the given token to retrieve a new token. The two tokens are different ones. And the later token is new with full expiration time.

Will the old token become invalid, when the new one is generated?

The old one is user's, it'll not become invalid, it is owned by user and has its own expire time.

I feel this idea is to generate a new token from a existing token provided by user, and the new token will be used by our app to manipulate openstack resources. If the existing token will not be impacted, that can be an idea. And we may also consider to revoke this new token appropriately, since it is a new resource created by us. Another thing which should be consider is the scope of the token. The new token should be a project scope token, because our app might not manipulate system scope resources. However, the token input by user may be a system scope token. For example, an admin who has a system scope token hope to modify an ADC in a user's project. We will need to generate a new token for this specific project scope from admin's token. I am not quite sure if keystone supports that.

Currently, we only have project-scoped token.
And currently, we have no scenario to need admin token to do something.
Maybe in the future. What's good is:
For admin token in our code, we already have a project scope admin token(refer to resolvedAdminToken). All of our API requests are in project scope.

I see this code change will refresh user token for every api call. Is that right? If true, I think that will generate too much useless data in keystone. If the purpose of this change is to avoid token expiration problem during a time-cost operation. We may need to identify which operation does require to refresh token.

generate too much useless data in keystone
How much? Do you have a precise measurement on that? meaningless concern to this point, I think.
Keystone would be broken down because of too many users login in public cloud?
Does WAFAAS will be trigger thousands of times in 1 sec? WAFAAS will crash earlier before keystone crash, is it right?
"We may need to identify which operation does require to refresh token." how to identify?
Do you know how much complexity does it add to our code?

Why do we have this PR:
We are now using admin token to get service endpoints(compute, network, identity..)
The normal way should be using the user token. 2 benefits:

The passed-in user token should not be used directly, since it may be expired in a very short time(eg. < 1s), but the operation takes a longer time. So we need to refresh a new user token and do the following works with it.
We can get service endpoints directly from user token's catalogs, instead of assembling it from admin tokens.

To my understanding this change set hope to address two different topics:

Using user token instead of admin token to interact with OpenStack.

Refresh user token, if we really need to refresh it.

For topic 1, I will vote 'yes'. That seems to be a bug.
For topic 2, it seems to be an nice-to-have enhancement. And its code change might be a little more complex the the code change for topic 2.
If you can propose two separated change set at the beginning, that would be a little better. We may review and approve the code change for topic 1 a little easier.
And my questions for topic 2 is which API will require us to refresh keystone token. Maybe we will have 3 cases:

If an API handler does not interact with OpenStack, it only need to validate the tenant information of existing user token. That means it never need to refresh the token.

If an API handler only need to call OpenStack API once, and will do that immediately, it needn't to refresh the token.

If an API handler need to call OpenStack API several times, and there will be big intervals between those calls, it may need to refresh the token, if the token is very close to be expired. We know such kind of problems a lot in ancient years. Since nova or neutron did not improve it, we would see some "token expired" problem in stress testing. I am glad to see someone would improve it, but we may need to scope this improved behavior under specific circumstances.

Why do we have this PR:
We are now using admin token to get service endpoints(compute, network, identity..)
The normal way should be using the user token. 2 benefits:

The passed-in user token should not be used directly, since it may be expired in a very short time(eg. < 1s), but the operation takes a longer time. So we need to refresh a new user token and do the following works with it.
We can get service endpoints directly from user token's catalogs, instead of assembling it from admin tokens.

To my understanding this change set hope to address two different topics:
1. Using user token instead of admin token to interact with OpenStack.

2. Refresh user token, if we really need to refresh it.

For topic 1, I will vote 'yes'. That seems to be a bug.
For topic 2, it seems to be an nice-to-have enhancement. And its code change might be a little more complex the the code change for topic 2.
If you can propose two separated change set at the beginning, that would be a little better. We may review and approve the code change for topic 1 a little easier.
And my questions for topic 2 is which API will require us to refresh keystone token. Maybe we will have 3 cases:
1. If an API handler does not interact with OpenStack, it only need to validate the tenant information of existing user token. That means it never need to refresh the token.

2. If an API handler only need to call OpenStack API once, and will do that immediately, it needn't to refresh the token.

3. If an API handler need to call OpenStack API several times, and there will be big intervals between those calls, it may need to refresh the token, if the token is very close to be expired. We know such kind of problems a lot in ancient years. Since nova or neutron did not improve it, we would see some "token expired" problem in stress testing. I am glad to see someone would improve it, but we may need to scope this improved behavior under specific circumstances.

You even have the wrong understanding to the original code and this change. How can you review the code?
We never use admin token to operate on OS, can you please check from the code again.
How can we use admin token to operate on OS and how can you endure that if we do it?
To the issue this PR locates, I consider it as a bug and you think that's an enhancement.
I don't think it's an enhancement. It's an indeed existing possible problem because we have several sub operations in our API call. If the token expires in the middle of operations, it will make chaos that we can not easy to handle.
Neutron nova do solve it but we do, I don't understand where's the problem?
I also don't understand why do we need to compare their shortages and lean to be consistance with that?
At last, could you please check, check and make the code understood before you start the review?
How can we dare to use admin token to do operations?
All the functions parameters are using 'userToken', haven't you seen it?

Why do we have this PR:
We are now using admin token to get service endpoints(compute, network, identity..)
The normal way should be using the user token. 2 benefits:

The passed-in user token should not be used directly, since it may be expired in a very short time(eg. < 1s), but the operation takes a longer time. So we need to refresh a new user token and do the following works with it.
We can get service endpoints directly from user token's catalogs, instead of assembling it from admin tokens.

To my understanding this change set hope to address two different topics:
1. Using user token instead of admin token to interact with OpenStack.

2. Refresh user token, if we really need to refresh it.

For topic 1, I will vote 'yes'. That seems to be a bug.
For topic 2, it seems to be an nice-to-have enhancement. And its code change might be a little more complex the the code change for topic 2.
If you can propose two separated change set at the beginning, that would be a little better. We may review and approve the code change for topic 1 a little easier.
And my questions for topic 2 is which API will require us to refresh keystone token. Maybe we will have 3 cases:
1. If an API handler does not interact with OpenStack, it only need to validate the tenant information of existing user token. That means it never need to refresh the token.

2. If an API handler only need to call OpenStack API once, and will do that immediately, it needn't to refresh the token.

3. If an API handler need to call OpenStack API several times, and there will be big intervals between those calls, it may need to refresh the token, if the token is very close to be expired. We know such kind of problems a lot in ancient years. Since nova or neutron did not improve it, we would see some "token expired" problem in stress testing. I am glad to see someone would improve it, but we may need to scope this improved behavior under specific circumstances.

You even have the wrong understanding to the original code and this change. How can you review the code?
We never use admin token to operate on OS, can you please check from the code again.
How can we use admin token to operate on OS and how can you endure that if we do it?
To the issue this PR locates, I consider it as a bug and you think that's an enhancement.
I don't think it's an enhancement. It's an indeed existing possible problem because we have several sub operations in our API call. If the token expires in the middle of operations, it will make chaos that we can not easy to handle.
Neutron nova do solve it but we do, I don't understand where's the problem?
I also don't understand why do we need to compare their shortages and lean to be consistance with that?
At last, could you please check, check and make the code understood before you start the review?
How can we dare to use admin token to do operations?
All the functions parameters are using 'userToken', haven't you seen it?

Hi, you pr description said the code uses admin token...

Why do we have this PR:
We are now using admin token to get service endpoints(compute, network, identity..)
The normal way should be using the user token. 2 benefits:

The passed-in user token should not be used directly, since it may be expired in a very short time(eg. < 1s), but the operation takes a longer time. So we need to refresh a new user token and do the following works with it.
We can get service endpoints directly from user token's catalogs, instead of assembling it from admin tokens.

To my understanding this change set hope to address two different topics:
1. Using user token instead of admin token to interact with OpenStack.

2. Refresh user token, if we really need to refresh it.

For topic 1, I will vote 'yes'. That seems to be a bug.
For topic 2, it seems to be an nice-to-have enhancement. And its code change might be a little more complex the the code change for topic 2.
If you can propose two separated change set at the beginning, that would be a little better. We may review and approve the code change for topic 1 a little easier.
And my questions for topic 2 is which API will require us to refresh keystone token. Maybe we will have 3 cases:
1. If an API handler does not interact with OpenStack, it only need to validate the tenant information of existing user token. That means it never need to refresh the token.

2. If an API handler only need to call OpenStack API once, and will do that immediately, it needn't to refresh the token.

3. If an API handler need to call OpenStack API several times, and there will be big intervals between those calls, it may need to refresh the token, if the token is very close to be expired. We know such kind of problems a lot in ancient years. Since nova or neutron did not improve it, we would see some "token expired" problem in stress testing. I am glad to see someone would improve it, but we may need to scope this improved behavior under specific circumstances.

You even have the wrong understanding to the original code and this change. How can you review the code?
We never use admin token to operate on OS, can you please check from the code again.
How can we use admin token to operate on OS and how can you endure that if we do it?
To the issue this PR locates, I consider it as a bug and you think that's an enhancement.
I don't think it's an enhancement. It's an indeed existing possible problem because we have several sub operations in our API call. If the token expires in the middle of operations, it will make chaos that we can not easy to handle.
Neutron nova do solve it but we do, I don't understand where's the problem?
I also don't understand why do we need to compare their shortages and lean to be consistance with that?
At last, could you please check, check and make the code understood before you start the review?
How can we dare to use admin token to do operations?
All the functions parameters are using 'userToken', haven't you seen it?

Hi, you pr description said the code uses admin token...

admin token to get service endpoints(compute, network, identity..), use admin token for what? have you read it carefully?


KAFKA-13279: Implement CreateTopicsPolicy for KRaft

Should we also change the integration test CreateTopicsRequestWithPolicyTest to support KRaft mode? the change LGTM.

Should we also change the integration test CreateTopicsRequestWithPolicyTest to support KRaft mode? the change LGTM.

I do want to do this but I think we'll need a separate PR for it. We have to restructure the base classes for the test a bit due to the complex web of inheritance it's embedded in.


Fix checking the completion of one frame data in RTSP RTP stream

Codecov Report

Merging #1611 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #1611      +/-   ##
===========================================
- Coverage    68.76%   68.75%   -0.01%
===========================================
  Files           96       96
  Lines        40614    40616       +2
===========================================
  Hits         27927    27927
- Misses       12687    12689       +2

Impacted Files
Coverage Δ

trunk/src/app/srs_app_rtsp.cpp
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7e980...df3ec15. Read the comment docs.


Links suggestions missed some files

🐛 Describe the bug
I have a 00. Home/🏡 Homepage.md file in my specified vault folder, but when I type [[Homepage, it didn't suggest it. It missed the file or Is it what it supposed to be?

Thanks in advance.
Versions
NVIM v0.8.3
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by builduser
Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/share/nvim"
Run :checkhealth for more info
1.8.0%

I'm guessing it's an issue with the spaces or emojis in the file name. Let's try to narrow it down. Can you see if it works for a file without an emoji in the name, within the same folder?

I'm guessing it's an issue with the spaces or emojis in the file name. Let's try to narrow it down. Can you see if it works for a file without an emoji in the name, within the same folder?

Hmm it didn't work for Homepage.md or Homepage1.md in the same folder 00. Home too.

It didn't work with folder 00.Home (without the middle space) too.

It didn't work in vault root folder too

Hmm... do these notes not have frontmatter?

I was able to reproduce this when aliases was not defined or set to an empty list [] in the frontmatter. #103 fixes that case. Let me know if you're still having issues after that and I'll reopen.

I was able to reproduce this when aliases was not defined or set to an empty list [] in the frontmatter. #103 fixes that case. Let me know if you're still having issues after that and I'll reopen.

Thanks a lot for your time.
It's now getting the files already but it produces weird aliases for files with no (or empty) aliases in the frontmatter.

Duplicated file name as aliases:

Couldn't get Homepage1.md if Homepage1.md is empty or have a few characters (like page below).

Get headings of notes into aliases (is this intended?). The | should be # for heading though. (Items is a heading in Content Hub)

Duplicated file name as aliases

That should be a quick fix.

Couldn't get Homepage1.md if Homepage1.md is empty or have a few characters (like page below).

That's odd. I'll try to repro that.

Get headings of notes into aliases (is this intended?). The | should be # for heading though. (Items is a heading in Content Hub)

Obsidian will assume the first H1 heading is the title of the note, so this is intended. But you should also get something like [[Content Hub|Content Hub]] as a suggestion. If not, that's a bug.

Ah, Homepage1.md isn't coming up because the search only searches file content, not file names. Should be straightforward to do both.

Duplicated file name as aliases

That should be a quick fix.

Couldn't get Homepage1.md if Homepage1.md is empty or have a few characters (like page below).

That's odd. I'll try to repro that.

Get headings of notes into aliases (is this intended?). The | should be # for heading though. (Items is a heading in Content Hub)

Obsidian will assume the first H1 heading is the title of the note, so this is intended. But you should also get something like [[Content Hub|Content Hub]] as a suggestion. If not, that's a bug.

Is it the first H1 heading or the first heading? Items is the first H2 heading of my note. But it would be fine if it also suggests [[Content Hub]] so I would choose that anyway and ignore those redundancies.

Ok just opened #104 to fix those issues.

Thanks so much. It works fine now. Really appreciate.

No problem!


Turn on REST_FUNCTION_CALL option for only 3 nodes

Change summary:

Turn on REST_FUNCTION_CALL option for only 3 nodes

Thanks for the review! Now merging..


Fix DeprecationWarning from collections

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working.
fixes #126

Coverage increased (+0.07%) to 84.054% when pulling 1f2f63a9282f6535c1f4159eda6c1d1dbd975f29 on jkwill87:patch-1 into 3633d43fa3e97bc9f92ea83a749925bbad215393 on reclosedev:master.

+1 looks good. Failing travis is because Python 2.6 tests are failing. Once Python 2.6 has been dropped, this should be all-green.


Bug#954 Take latitude/longitude from picture taken seconds after

Fixes bug #954

Codecov Report

Merging #1150 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1150      +/-   ##
=========================================
- Coverage    3.98%   3.92%   -0.07%
=========================================
  Files         123     124       +1
  Lines        5568    5663      +95
  Branches      536     545       +9
=========================================
  Hits          222     222
- Misses       5331    5426      +95
  Partials       15      15

Impacted Files
Coverage Δ

...java/fr/free/nrw/commons/upload/ShareActivity.java
0% <0%> (ø)
:arrow_up:

...nrw/commons/upload/SimilarImageDialogFragment.java
0% <0%> (ø)

...e/nrw/commons/category/CategorizationFragment.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe964d...3a7b888. Read the comment docs.

I checked your code and looks good to me. However I don't have such photos to test unfortunately. @misaochan @nicolas-raoul do you have photos that matches criteria of related issue?

@neslihanturan one way to get samples is to click pictures by turning geotagging on and off. Open Camera let's you do that.

Thanks for the great tips, will collect some samples today

@harisankerPradeep it works grreat, and I really liked using this feature while playing with it for test purpose. Thank you for implementation and @nicolas-raoul for the idea.
Some minor questions:

User is able to dismiss the question by clicking outside (and does not copy location info as expected). Do we want to let this happen, or force the user to answer.
If user says no, code re-asks the question on category screen also (same thing happens if user clicks outside of the screen also). Is this a bug or a feature? It seems like our code doesn't accept "no" as an answer:D

@neslihanturan  I personally don't think the user should be forced to answer.
As for the second issue, I have fixed it in the last commit. Thanks for pointing it out! 👍

Thanks @harisankerPradeep :)

@nicolas-raoul @neslihanturan @misaochan  Thanks!


API Manager 3rd party KM integration is not working as per the documentation

Description:
Chanaka Fernando reported as follows:
@WSO2 Documentation Shall we update the documentation with an updated GitHub repository[1]?
[1] https://github.com/chanakaudaya/surf-oauth-demo
Affected Product Version:
API-M 2.6.0, 3.0.0

Updated in [1].
[1] https://docs.wso2.com/display/AM260/Configuring+a+Third-Party+Key+Manager

@tgtshanika ,  we need the Git repo updated for 3.0.0

@bhathiya , we need the Git repo updated for 3.0.0

The 3.0.0 documentation has been updated in [1].
[1] https://apim.docs.wso2.com/en/latest/install-and-setup/deploying-wso2-api-manager/distributed-deployment/configure-a-third-party-key-manager/


Publish properties not recognized for WPF ClickOnce Package in GitHub Action

Hello,
I have a WPF application (.NET Framework, v4.8). I have setup GitHub Action for creating ClickOnce package. Below is the build step.
 # Setup MSBuild
    - name: Setup MSBuild
      if: always()
      uses<EMAIL_ADDRESS>
    # Build WPF app
    - name: Build WPF app
      id: build_wpf_app
      if: always()
      run: msbuild ${{env.Solution_Path}} /target:publish /p:Configuration=Release

The above snippet works as expected and generates a ClickOnce package.
Now, when I update the build command as below:
msbuild ${{env.Solution_Path}} /target:publish /p:Configuration=Release;BootstrapperEnabled=true;Install=true;
I am getting below error:
Time Elapsed 00:00:31.62
BootstrapperEnabled=true: D:\a\_temp\5e67135b-dc47-445c-84a4-10cd3b8aa0f5.ps1:2
Line |
   2 |  … /p:Configuration=Release;BootstrapperEnabled=true;Install …
     |                                         ~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'BootstrapperEnabled=true' is not recognized as a name of a cmdlet, function, script file, or
     | executable program. Check the spelling of the name, or if a path was included, verify that the path is
     | correct and try again.

Now, if I update the build command as below:
msbuild ${{env.Solution_Path}} /target:publish /p:Configuration=Release;Install=true;
I am getting below error:
Time Elapsed 00:00:27.07
Install=true: D:\a\_temp\48ec9f79-b111-4610-88cc-d8959b6b4095.ps1:2
Line |
   2 |  … /target:publish /p:Configuration=Release;Install=true
     |                                                             ~~~~~~~~~~~~
     | The term 'Install=true' is not recognized as a name of a cmdlet, function, script file, or executable
     | program. Check the spelling of the name, or if a path was included, verify that the path is correct
     | and try again.

Looks like the publish properties (https://docs.microsoft.com/en-us/visualstudio/deployment/building-clickonce-applications-from-the-command-line?view=vs-2022) are not supported or I am missing something silly.
Can anyone please help how to fix the issue?
Thanks in advance.

This is better to be logged in the dotnet/msbuild repo rather than here -- this repo is only for the GitHub action and not for the msbuild tool itself.


i am getting this error while testing the function

@Nareshkadali Hi, can you please provide more information about what document you are referring to? Thanks.

Hi @Nareshkadali Since we haven't heard back, we will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it with the URL of the documentation this issue concerns and we will gladly continue the discussion.


Fetch changelog from GH or atomicexplorer.com using API

Currently Agama uses hardcoded changelog for in-app display. Would be nice if Agama would fetch the changelog from online from github or atomicexplorer.com
In this case, we can update changelog with required changes anytime and Agama can fetch latest always.

then this does mean that old agama versions will displays new changelog
might be confusion if users is on old version and they saw the changelog showing the new version


Remember me not properly aligned

Describe the bug
On the login page the remember me checkbox and label is not properly aligned

hey I would like to fix this issue. Can you please assign it to me?

Does this look good to you?

Hi @MauryanKansara I am not the maintainer of this repo
please reach out to
@vedant-jain03 @Prerna-0202

@Prerna-0202 @vedant-jain03 can I work on this issue?

@MauryanKansara  this issue is already raised #3252  and the PR for this is under review!

hey @aashimawadhwa, If this issue is still open , can you assign it to me?

completed


Add integ test execution as part of PR Github checks

Is your feature request related to a problem? Please describe
Currently unit tests are executed as part of PR checks. https://github.com/opensearch-project/opensearch-build/tree/main/.github/workflows
We want to add integ test execution so that developers do not need to manually run it.
Describe the solution you'd like
Integ test runs in PR check.
Describe alternatives you've considered
No response
Additional context
No response

FYI we didn't include any actual OpenSearch tests in GHA in this project because of hardware requirements; those run in Jenkins jobs

Closing this issue as we do not plan to run integration tests as part of GitHub CI checks.


Padding added to the body when opening a Modal

[x] The issue is present in the latest release. (4.9.5)

I've search the issues and this is related to a lot of issues, including this one => https://github.com/mui-org/material-ui/issues/10000
Current Behavior 😯
In my application, I sometimes get a padding-right added to the body when a Modal is opened.
Steps to Reproduce 🕹
I haven't find a way to reproduce this yet and it happens randomly.
Your Environment 🌎

Tech
Version

Material-UI
v4.9.5

Browser
Chrome v80

So I've investigated on this behavior, and adding the following css fixes it :
html {
    overflow: hidden;
}

It's really weird and seems to be a problem with the navigator. Sometimes when rendering a modal, the html tag gets a scrollbar.
This causes the ModalManager to add a padding based on this scrollbar width => https://github.com/mui-org/material-ui/packages/material-ui/src/Modal/ModalManager.js

The scrollbar appears beetween the moment the modal is rendered and the moment when the opacity is set to 1. This causes the isOverflowing in the ModalManager to return true

This is what happens in the sandbox from this comment.
I'm not sure what we should do about it though. Should we just provide the css fix in the documentation ?

The issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


Report relative path for overlapping outputs

when caching has been disabled.

@lptr PTAL! Good call about RelativePathFileResolver, I didn't know this existed.


BUG: The library documentation should clearly state which search parameters require being posted as a JSON payload

NOTE: THIS APPEARS TO BE AN API BUG, not A LIBRARY BUG
For example, the documentation at https://m2x.att.com/developer/documentation/v2/device#Search-Devices does not mention that the tags search parameter requires being posted as a bodyParam, but all the other parameters in this list are simple parms which are turned into query strings.

@azarc3 actually tags and all the other parameters are accepted via query parameters. Do you have an example of what doesn't work so we can debug it?
Thanks!


Make sure stale data is not served when rebuilding state

When ingest version is upgraded (expingest.CurrentVersion++) Horizon will clear all state-related tables and rebuild the state using state pipeline. At this step ledger pipeline is not run waiting for the state ingestion to complete.
It seems possible that during state ingestion a stale data connected to ledger entries can be served (/accounts, /offers, /paths). It seems not dangerous when all endpoints are migrated to the new system but now it can break some use cases (ex. comparing the current balance of an account with transactions since last check).

Maybe the best thing is just to report the endpoint as unavailable until ingestion is caught up.

If the ingest version is upgraded the last ingested ledger in the db is set to 0:
https://github.com/stellar/go/blob/master/services/horizon/internal/expingest/main.go#L232-L244
The requiresExperimentalIngestion() middleware actually checks that the last ingested ledger is greater than 0.
However, this check by itself isn't sufficient because the code which sets the last ingested ledger to 0 is wrapped in a transaction and that transaction is only committed at the end of the state pipeline.

However, this check by itself isn't sufficient because the code which sets the last ingested ledger to 0 is wrapped in a transaction and that transaction is only committed at the end of the state pipeline.

Yes, @tamirms is right, this is exactly the case. None of Postgres isolation levels allow reading uncommited changes. Maybe we can add another value to key store, ex. exp_state_building. Before state pipeline is started we create a new DB transaction (by cloning DB session), change the state_building value to true and commit right away. Then in middleware we check exp_state_building value instead of exp_last_ingested_ledger.

Alternatively, we can compare exp_last_ingested_ledger with the last ledger in core. This will solve stale data in state endpoints as well as history endpoints but also prevent serving stale data when ingestion is lagging.

Closed in #1847.


Remove outdated theming documentation

Resolves Issue #8
Removes outdated documentation left over from client extraction

@amanji, The branch needs to be updated before it can be merged.


Activating 'Memory recall' button narrator announces information twice.

A team member will update this issue with more details soon.

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.


AutoFormerV2 - Flops

Thank you for sharing your codes.
While I try to use your codes, I found something weird.
There are performance graphs on README.md of AutoFormerV2.
And at the first graph, the scale of axis x is million.
But it looks wrong, right?
I think it should be changed to GFlops.

Thanks for pointing out this mistake. We will fix it in a later revision.


The second step of training

When I'm doing the second step of training, do I need to change "pretrained_model_sceneflow.ckpt" to "checkpoint_000063.ckpt" ?
Thank you !

yes

When I'm doing the second step of training, do I need to change "pretrained_model_sceneflow.ckpt" to "checkpoint_000063.ckpt" ? Thank you !

How to get checkpoint_000063.ckpt


Installing SAP HANA, express edition with Docker - ERROR: Insufficient permissions on /hana/mounts. Required permissions: rwx

Tutorial URL: https://developers.sap.com/tutorials/hxe-ua-install-using-docker.html
I have an issue at Step 8: Start SAP HANA, express edition Container, when I execute the command:
docker run -p 39013:39013 -p 39017:39017 -p 39041-39045:39041-39045 -p 1128-1129:1128-1129 -p 59013-59014:59013-59014 -v /data/saphana:/hana/mounts \
--ulimit nofile=1048576:1048576 \
--sysctl kernel.shmmax=1073741824 \
--sysctl net.ipv4.ip_local_port_range='40000 60999' \
--sysctl kernel.shmmni=524288 \
--sysctl kernel.shmall=8388608 \
--name saphanaexpress01 \
store/saplabs/hanaexpress:<IP_ADDRESS>.20180925.2 \
--passwords-url file://data/masterpwd.json \
--agree-to-sap-license

Error message: ERROR: Insufficient permissions on /hana/mounts. Required permissions: rwx
======== Starting HANA container run script ========
Started at: Mon Feb 11 12:09:24 UTC 2019
Script parameters: --passwords-url file://data/masterpwd.json --agree-to-sap-license
HANA version: <IP_ADDRESS>.1535711040
Linux kernel version: 4.9
New host: '19eddacfba7f'
Setting HANAs host name to '19eddacfba7f' ...
Checking allowed mountpoints ...
ERROR: Insufficient permissions on /hana/mounts. Required permissions: rwx

Tryings, which don'4 work:

I tried execute command in name of root
I tried execute command in name of non-root user
I modified the permission of /data/saphana to 777
I modified the permission of masterpwd.json to 777

Please help me to solve this issue.
Other information:

Base OS: Ubuntu 18.04 LTE (WSL on W10)
Docker version: 18.09.1, build 4c52b90

Feel free to get in touch with any questions.
Thank you for your help in this matter.

Try to change:
-v /data/saphana:/hana/mounts --passwords-url file://data/masterpwd.json
==>
-v /data/saphana:/hana/mounts --passwords-url file:///hana/mounts/masterpwd.json

Hi,
Thank you for your response.
I made the changes but the result is same:
======== Starting HANA container run script ========
Started at: Wed Feb 13 08:14:17 UTC 2019
Script parameters: --passwords-url file://hana/mounts/masterpwd.json --agree-to-sap-license
HANA version: <IP_ADDRESS>.1535711040
Linux kernel version: 4.9
New host: 'b0efcf7ab7da'
Setting HANAs host name to 'b0efcf7ab7da' ...
Checking allowed mountpoints ...
ERROR: Insufficient permissions on /hana/mounts.
Thank again.

@the1bit
file://hana/mounts/masterpwd.json
==>
file:///hana/mounts/masterpwd.json
(file:///, 3 '/' , you could consider it as file:// + /hana/mounts/masterpwd.json )

Great. I executed the fixed script and the result is same:
======== Starting HANA container run script ========
Started at: Wed Feb 13 09:54:08 UTC 2019
Script parameters: --passwords-url file:///hana/mounts/masterpwd.json --agree-to-sap-license
HANA version: <IP_ADDRESS>.1535711040
Linux kernel version: 4.9
New host: 'd57491bc0345'
Setting HANAs host name to 'd57491bc0345' ...
Checking allowed mountpoints ...
ERROR: Insufficient permissions on /hana/mounts. Required permissions: rwx

maybe redundant check, could you execute
ls -l  /data
ls -l  /data/saphana
Also the tutorial link mentioned two related operations, I assume you also tried before trying 777
sudo chmod 600 /data/<directory_name>/<file_name>.json
sudo chown 12000:79 /data/<directory_name>/<file_name>.json

I executed these:
sudo chmod 600 /data/<directory_name>/<file_name>.json
sudo chown 12000:79 /data/<directory_name>/<file_name>.json

Results:
ls -l /data
total 0
-rwxrwxrwx 1 12000 79   49 Feb 11 13:08 masterpwd.json
drwxrwxrwx 1 12000 79 4096 Feb 11 13:09 saphana

ls -l /data/saphana
total 0
-rw------- 1 12000 79 49 Feb 11 13:09 masterpwd.json

Nevertheless the docker result is same:
======== Starting HANA container run script ========
Started at: Wed Feb 13 13:13:31 UTC 2019
Script parameters: --passwords-url file:///hana/mounts/masterpwd.json --agree-to-sap-license
HANA version: <IP_ADDRESS>.1535711040
Linux kernel version: 4.9
New host: '554cff20c68e'
Setting HANAs host name to '554cff20c68e' ...
Checking allowed mountpoints ...
ERROR: Insufficient permissions on /hana/mounts. Required permissions: rwx

I was able to use the URL option to get the install to work. I used http://myjson.com to store the snippet of JSON containing the password and then used the following:
docker run -p 39013:39013 -p 39015:39015 -p 39041-39045:39041-39045 -p 1128-1129:1128-1129 -p 59013-59014:59013-59014  -p 39030-39033:39030-39033 -p 51000-51060:51000-51060  -p 53075:53075
-h hxehost
--ulimit nofile=1048576:1048576
--sysctl kernel.shmmax=1073741824
--sysctl net.ipv4.ip_local_port_range='60000 65535'
--sysctl kernel.shmmni=524288
--sysctl kernel.shmall=8388608
--name express_edition
store/saplabs/hanaexpressxsa:<IP_ADDRESS>.20190115.1
--agree-to-sap-license
--passwords-url https://api.myjson.com/bins/1844hs/
It takes quite a while (~30 minutes) but succeeded eventually.

Hi @rericsson,
I tried your solution and it seems work. :-)
Nevertheless the official documentation is different and this is my biggest pain point. So thank you so much for your help. I am waiting for a working documentation. ;-) I am sure @TerryNing will be able to support me and the community.
Thank you for all of your help.

Hi All,
Finally I stepped back to the original command (of course I used @rericsson's example) and I got rid of "-v" part of script.
 :-)
@TerryNing: Colud you please help me to understand why it goes to fail the command when we use "-v /data/saphana:/hana/mounts"?
Thanks in advance.

The -v option is for bind mounting to a folder on the host.  I'm not sure why it would fail but I always got a permissions problem on the password JSON file. I suppose it has something to do with the user accessing the file, but I could never get it to work even after opening the file to world+dog, so I tried the http option and that worked so I didn't pursue it. Maybe someone more steeped in the ways of docker bind mounting would know offhand.
Rob

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
Feel free to continue the discussion in the SAP Community or in the SAP Questions & Answers.
https://www.sap.com/community.html
https://answers.sap.com/index.html

Hi,
The installation does not work according to documentations.  From that point of view the issue is not solved.
I would like to ask you to update the documentation.
Thank you for your help.
BR,
TB

@JCurrie27 @TerryNing Can you address?
@the1bit When you say the documentation needs fixing, which documentation? Link?

@thecodester: The documentation in question is cited earlier in this thread. The bind mounting command
... -v /data/saphana:/hana/mounts ...
works for some users and fails for others -- this requires further investigation by @TerryNing's team before the tutorial https://developers.sap.com/tutorials/hxe-ua-install-using-docker.html can be updated with either an updated command, or a workaround for users with a particular environment.

I am having the same issue with using -v , even though my json is remotely located. If this continues how can we actually mount the data to SAPHANA DB? how would we be able have permanent data?

Confirm that the string with mount is an absolute path. I resolved my issue by putting the right path after -v e.g. this how that line looks like in my setup"
 -v /drive/docker/volumes/HXE_DOCKER1:/hana/mounts

hi experts,
Even i am trying as per tutorial and getting same error.
sudo docker run -p 39013:39013 -p 39017:39017 -p 39041-39045:39041-39045 -p 1128-1129:1128-1129 -p 59013-59014:59013-59014 -v /data/dockersapexpr:/hana/mounts
--ulimit nofile=1048576:1048576
--sysctl kernel.shmmax=1073741824
--sysctl net.ipv4.ip_local_port_range='40000 60999'
--sysctl kernel.shmmni=524288
--sysctl kernel.shmall=8388608
--name express_Edition3
store/saplabs/hanaexpress:<IP_ADDRESS>.20200121.1
--passwords-url https://api.myjson.com/bins/xxxx
--agree-to-sap-license
And still  getting same error. can you please guide how to fix it ?
regards,
aditya

Hi aditya: Could you please post this error scenario on the HANA Express Q&A page? That page is actively monitored by experts, and by the user community:

Go to https://answers.sap.com/questions/ask.html
Add a title. Add the details cited above
In the Select a Primary Tag field, search for "express" and select "SAP HANA, express edition"

Many thanks.

I encountered the same, any update?

Still happening here, too.

I had the problem, fixing it setting chmod -R 777 /data/hana
It seems that all the content in the folder needs to be rwx

Still happening here, too.
In my case, a SELinux issue:
rule chcon -Rt svirt_sandbox_file_t /data got it working.

This saved me. Got me working on Fedora 34. Thanks.

To fix this issue, just change the owner of /data/hana to the id of user used inside the container:
sudo chown 12000:79 /data/hana


unexpected error piping to gzip

I'm trying to do the python sh equivalent of:
echo hello | gzip > file.gz

Here's my attempt:
import sh

sh.gzip(sh.echo("hello", _piped=True), _out="file.gz")

and the result:
---------------------------------------------------------------------------
ErrorReturnCode_1                         Traceback (most recent call last)
<ipython-input-16-17a5c91e2a9a> in <module>()
----> 1 sh.gzip(sh.echo("hello", _piped=True), _out="file.gz")

~/envs/sra-pipeline-i02dZRQF/lib/python3.6/site-packages/sh.py in __call__(self, *args, **kwargs)
   1425             stderr = open(str(stderr), "wb")
   1426
-> 1427         return RunningCommand(cmd, call_args, stdin, stdout, stderr)
   1428
   1429

~/envs/sra-pipeline-i02dZRQF/lib/python3.6/site-packages/sh.py in __init__(self, cmd, call_args, stdin, stdout, stderr)
    772
    773             if should_wait:
--> 774                 self.wait()
    775
    776

~/envs/sra-pipeline-i02dZRQF/lib/python3.6/site-packages/sh.py in wait(self)
    790
    791             else:
--> 792                 self.handle_command_exit_code(exit_code)
    793
    794                 # if an iterable command is using an instance of OProc for its stdin,

~/envs/sra-pipeline-i02dZRQF/lib/python3.6/site-packages/sh.py in handle_command_exit_code(self, code)
    813             exc = exc_class(self.ran, self.process.stdout, self.process.stderr,
    814                     ca["truncate_exc"])
--> 815             raise exc
    816
    817

ErrorReturnCode_1:

  RAN: /usr/bin/gzip

  STDOUT:

  STDERR:
gzip: standard output is a terminal -- ignoring

It says standard out is a terminal, yet I explicitly set _out to be a filename.
What am I doing wrong?
This is with sh 1.12.14 and python 3.6.0 on macOS High Sierra 10.13.6 (17G65).
UPDATE: Figured it out, you have to pass the -f flag to gzip to tell it to compress anyway, even if (it thinks) that standard output is a terminal:
import sh

sh.gzip(sh.echo("hello", _piped=True), "-f", _out="file.gz")

Not sure if this is a bug in sh or not. Leaving this here in case others run into the same problem.
If it's not an sh bug you can close it. I guess I expected the presence of _out would somehow clue the gzip process into knowing it's writing to a file.

This was indeed a subtle bug. It's been fixed with 56e18cff5a82c7a3253a0dfe8792a44ae7050aae and will go out with the next release. I tested locally with gzip, and your example works with that change without the -f flag. Basically it's as you assumed, sh wasn't being smart enough when it detected that it was writing output to a file.


Add definition for Ruby 2.3.4

Refer: https://www.ruby-lang.org/en/news/2017/03/30/ruby-2-3-4-released

Thanks always


Fix facebook login exceptions

Fixed an exception caused by "Username" being empty when registering user information when logging in with Facebook.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: Jerry<EMAIL_ADDRESS>


Add support for prepare-commit-msg hooks

I want to modify the default commit message a user sees when opening the commit message editor. Specifically I want to replace some placeholder in the commit-template with a string extracted from the current branch name and display the resulting text to the user without modifying the original commit template file.
Can this be done using overcommit and if so how and using which hook? pre_commit or prepare_commit_msg?

Would this help? https://robots.thoughtbot.com/better-commit-messages-with-a-gitmessage-template

Hey @siwica,
You are right that a prepare-commit-msg hook is the correct way to go here since you want to pre-populate a commit message with dynamic content before allowing the user to edit the commit message.
Overcommit does not yet support prepare-commit-msg hooks, but we'd happily accept a pull request adding support!

I might take a look at it, if I find some time. Haven't done anything in Ruby for quite a while though.
Could you shortly outline what would need to be done in order to add support for prepare-commit-msg  hooks?

You can see what went into adding support for pre-rebase hooks in #165.
According to the prepare-commit-msg documentation, it will need to support one to three arguments, so you'll want to expose helpers for accessing these arguments in the Overcommit::HookContext::PrepareCommitMsg class you will create.
The Overcommit::HookContext::PrepareCommitMsg class you create will need to provide a way to edit the commit message, similar to the Overcommit::HookContext::CommitMsg class.

Alright, thank you!

What should a helper return when an argument can only be one out of a finite number of options (in my case: message, template, squash or commit). Return the raw string 'message'', or rather a symbol :message?
How should a helper behave if an argument is not set (prepare-commit-msg takes a variable number of arguments) and is thus not available? Raise an error or return nil?

Sorry for the delay in response, @siwica.
For the first question, since there are a finite number of options a symbol seems appropriate. Another approach however is to instead expose methods like message?, template?, squash?, or commit? which indicate which type we are dealing with. At the end of the day the former seems simpler than the latter, and just as powerful.
For the second question, the type from the first argument should be used by hook authors to dictate whether other arguments can be queried. For example, we could define a template_file method which raises an exception if the type is not template.
Hope this helps.

@siwica I had the same need myself, and I used a custom post-checkout hook to write a commit.template file. I took the time today to write it as a Overcommit hook, and you can see the result here.
@sds If you think this branch is something that could be merged, please let me know so I can open a PR.

Implemented in #520


azure: use our version of terraform-render-bootkube

Signed-off-by: Mateusz Gozdek<EMAIL_ADDRESS>

Yeah, I didn't want to run this with latest commit, but align it to other providers we support first. Update should be done separately and tested.

That's a valid reason. Approved the PR.

Tested that deployment works, so I'm merging.

And the award of the fastest PR to be shipped goes to :fire:


To add Statistics section with [z-test]

I would like to create a statistic section which will have [Z-test]

@sairish2001 I would like to work on this issue.

Go ahead
Deadline 11 May,2021


dhcp: Update config.guess in bundled BIND source tree

Motivation for this change
The ISC DHCP source contains a tarball of BIND 9.11.14 which the Makefile will untar and build. The autoconf config files in the tarball (config.guess, config.sub) are outdated, preventing compilation on newer platforms (riscv64).
There is an option to use our own libbind (--with-libbind), but the API has changed and the version we are shipping is no longer compatible (I've tried). Resistance is futile - Just accept the ancient tarball of BIND that is also sitting right in their git repo :vomiting_face: I never knew this was a thing, and now I can't unsee it.
Tested to build on riscv64 and x86-64.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 126434 at e4ef2290 run on aarch64-linux 1

2 packages marked as broken and skipped:

spring
springLobby

340 packages skipped due to time constraints:

adapta-gtk-theme
almanah
apostrophe
arc-theme
arx-libertatis
asciidoc-full
asciidoc-full-with-plugins
astroid
balsa
bibata-cursors
...

42 packages built successfully:

appgate-sdp
dhcp
flatpak
geoclue2
glib-networking (gnome.glib-networking ,gnome.glib_networking)
gnome-network-displays
gnome.gnome-clocks
gnome.gnome-disk-utility
gnome.gnome-settings-daemon (gnome.gnome_settings_daemon)
gnome.mutter334 (pantheon.mutter)
networkmanager-vpnc (gnome.networkmanager-vpnc)
networkmanagerapplet (gnome.networkmanagerapplet)
libnma
libproxy
libquvi
libsForQt5.alkimia (libsForQt515.alkimia ,plasma5Packages.alkimia)
libsForQt5.kdelibs4support (libsForQt515.kdelibs4support ,plasma5Packages.kdelibs4support)
libsForQt5.networkmanager-qt (libsForQt515.networkmanager-qt ,plasma5Packages.networkmanager-qt)
libsForQt514.kdelibs4support
networkmanager
networkmanager_dmenu
nm-tray
ostree
pantheon.elementary-dpms-helper
pantheon.elementary-settings-daemon
pantheon.gala
pantheon.switchboard-plug-mouse-touchpad
pantheon.switchboard-plug-network
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.wingpanel
pantheon.wingpanel-indicator-bluetooth
pantheon.wingpanel-indicator-keyboard
pantheon.wingpanel-indicator-network
pantheon.wingpanel-indicator-nightlight
pantheon.wingpanel-indicator-notifications
pantheon.wingpanel-indicator-power
pantheon.wingpanel-indicator-session
pantheon.wingpanel-indicator-sound
python38Packages.python-dbusmock
semantik
sublime-music

Should target staging

Ok, rebased against staging.

Is this still needed after https://github.com/NixOS/nixpkgs/pull/166456? Dhcp has updated BIND to 9.11.36.


feat(job): update failfast schema

In addition, this commit adds few unit test cases
Signed-off-by: AmitKumarDas<EMAIL_ADDRESS>

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[576] Migrate the publish locations index

Context

https://trello.com/c/giOu9OOk/576-migrate-locations-locations-list

Changes proposed in this pull request

Migrate over locations index page from the locations section here https://qa.publish-teacher-training-courses.service.gov.uk/organisations/2GU/2022
Editing/Adding a location in a follow up ticket
Clean up redundant visa routes

Guidance to review
publish/organisations/2AT/2022/locations
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Migrate Locations - Locations list


Fixing missing use statement

Current coverage is 14.28%

Merging #5 into master will not affect coverage as of 799b861

@@            master      #5   diff @@
======================================
  Files            1       1
  Stmts           49      49
  Branches         0       0
  Methods         15      15
======================================
  Hit              7       7
  Partial          0       0
  Missed          42      42

Review entire Coverage Diff as of 799b861

Powered by Codecov. Updated on successful CI builds.


Page Views and Unique Hits

It would be nice to be able to see how many times a unique visitor revisits a page (total page views).
It appears that currently YOURLS only tracks unique hits, Is it possible to also have stats to track total page views too?

is there a way to track unique clicks ??


Unable to install coreclr-debug on Elementary OS

Moved from https://github.com/Microsoft/vscode/issues/9780:

VSCode Version: Version 1.3.1 and Version 1.4.0-insider
OS Version: Elementary OS Freya 0.3.2

Steps to Reproduce:

Install Elementary OS
Install Visual Studio Code
Install C# extension
Load a .NET Core project
Attempt to debug the project

Able to see the error log when the developer console is open within Visual Studio Code.
Should this not install correctly even if using Elementary OS?
Elementary OS is built on Ubuntu 14.04.
Thanks very much.

@kieferrm if Elementary OS is based on Ubuntu 14.04, hopefully this is just a tweak to this switch statement. If you are interested, we would happily take a PR. Otherwise, if you want to paste in the output of cat /etc/os-release I can try to send you a private .vsix which will send us down that way.

Here is my output from cat /etc/os-release
$ cat /etc/os-release
NAME="elementary OS"
VERSION="0.3.2 Freya"
ID="elementary OS"
ID_LIKE=ubuntu
PRETTY_NAME="elementary OS Freya"
VERSION_ID="0.3.2"
HOME_URL="http://elementary.io/"
SUPPORT_URL="http://elementary.io/support/"
BUG_REPORT_URL="https://bugs.launchpad.net/elementary/+filebug"

I have fixed the issue locally on my PC, I'd be more than happy to make a pull request.
Change is pretty straight forward.
Thanks very much for your help

I have created pull request for this feature here: https://github.com/OmniSharp/omnisharp-vscode/pull/628

@Firaenix Thanks again!

You might want to reopen this issue: the value of ID was changed.
Here is my output from cat /etc/os-release
$ cat /etc/os-release
NAME="elementary OS"
VERSION="0.4 Freya"
ID="elementary"
ID_LIKE=ubuntu
PRETTY_NAME="elementary OS 0.4 Loki"
VERSION_ID="0.4"
HOME_URL="http://elementary.io/"
SUPPORT_URL="http://elementary.io/support/"
BUG_REPORT_URL="https://bugs.launchpad.net/elementary/+filebug"

So it sounds like it is now VERSION instead of VERSION_ID?

Yes. Sorry for delay

@yehudag I am attaching a version of the C# extension which I think will fix your issue. Would you mind giving it a quick try?

Save the file
Remove the '.renamed.zip' extension
Open the file in VS Code
You should see the file install, when prompted, restart VS Code

csharp-1.5.0-dev5.vsix.renamed.zip

Yes that worked. Thanks


RStudio Package Name Correction #1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Side not: You are able to both have a ShortDescription and a Description. You don't need to remove the Description in order to add a ShortDescription.


supply method to edit/reapply evaluation

provide a ui so that the user may create, edit, delete, import, export evaluation criteria by selecting from a list of unique metadata keys (BRNG, TOUT, etc) and an operator such as average, count of frames greater than X (or equal to, less than, etc),

This is for when files have been evaluated by a configured summarization, but then the summarization's configuration has been updated. So it should be reapplied to existing file data.

I think current policy, filter function page does what it is asking here... If it is something else, please let me know.


Rename create data object task to modify-data-object

What this PR does / why we need it:
Rename create data object task to modify-data-object
After adding the delete option to create-data-object, the name is not accurate.
/hold merge after https://github.com/kubevirt/kubevirt-tekton-tasks/pull/176
Release note:
Rename create data object task to modify-data-object

/hold cancel


Add finetuning model to keytotext

Is your feature request related to a problem? Please describe.
Its difficult to use it without fine-tuning on new corpus so we need to build script to finetune it on new corpus

from keytotext import KeytotextTrainer

model = KeytotextTrainer()
model.from_pretrained(model_name="t5-small")
model.train(data_df=df,batch_size=4, max_epochs=3, use_gpu=True)
model.save_model()

Trainer added


updated import code

Couldn't pass tests locally with previous code, please test it, works well on my local drive.

Worked fine. Passed all the tests


Modifications to gemm_plot

Small update. Will now auto parse all files that end with *.gemm, adds labels and whatnot.

Thanks, I think I stole what I needed to drop-in replace the gnuplot script.


Add a logging interceptor

We do a fair bit of logging for each gRPC call, in particular errors. However, to ensure that we don't forget to log in certain places we should add a logging interceptor so that all gRPC calls and errors are logged in a single place.
See grpc-ecosystem/go-grpc-middleware for reference.

It would also be helpful if each logged gRPC call contains relevant context, e.g., the course code (dat320), user ID or name, etc. We might provide custom logging functions that include such context, or the context could be added to the base logger's context along with stuff like the date, time, method, line number, and so on.
This context will be useful for searching in the log.

Here are two blogs related to this issue.

Using Go's 'context' library for making your logs make sense
Distributed Request Logging in Go with Context API