lavalink: Fix deserializing LoadedTracks responses for playlists without a selected track

Fixes #1303.

Would it be worth it to make this perform custom serialization to handle the -1 case, in exchange for this not being breaking?

Codecov Report

Merging #1304 (4822403) into next (4d8b07a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1304   +/-   ##
=======================================
  Coverage   31.03%   31.03%
=======================================
  Files         366      366
  Lines       14591    14591
=======================================
  Hits         4529     4529
  Misses      10062    10062

Impacted Files
Coverage Δ

model/src/application/callback/mod.rs
44.00% <0.00%> (-1.34%)
:arrow_down:

http/src/routing/route.rs
5.76% <0.00%> (ø)

http/src/routing/route_display.rs
10.66% <0.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8b07a...4822403. Read the comment docs.

Would it be worth it to make this perform custom serialization to handle the -1 case, in exchange for this not being breaking?

I would prefer this so that we can target this at main instead.

Added a quick "deserialize_with" shim and retargetted the PR at main.

A test would be good

added. PTAL.


iOS App Crash on reconnect to device.

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[] Android
[] tvOS
[] macOS
[] .NET Standard
UWP IS NOT SUPPORTED DURING THE BETA PERIOD - ONLY PRs ARE WELCOME FOR NOW

Version of OS(s) listed above with issue
iOS 10.2.1
Version of Library
5.3.1
Expected Behaviour
Connect and Reconnect to same device to work each time
First time connection (when app runs) works as expected.
Actual Behavior
On my app, when reconnecting to the same previous device, the app crashes.
When trying using the provided sample app, essentially the same behavior. (some times on the first re-connect, but always the second reconnect)
App crashes as shown in the attached image.

Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

Please include the full stacktrace.  That NRE doesn't help me at all.
Also, please answer my question in #103.  I spent time looking into a potential issue for you only to have it closed without any explanation

You need to provide more info than this.  I have been trying to reproduce this without any luck.

No feedback and insufficient info.  Tests and demo app all work for me.


ladybird: unstable-2022-09-29 -> unstable-2023-01-17

Description of changes

update
work around https://github.com/SerenityOS/serenity/issues/17062

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1751


hcm: move StreamInfo and filter creation into FM

Moves the ownership of the StreamInfoImpl into the FilterManager, exposed via an accessor to allow the ActiveStream to
still modify/read the StreamInfo.
Moves the interaction with the FilterChainFactory into the FilterManager, as well as ownership over the access logs created
via the factory callbacks.
Risk Level: Medium
Testing: Existing tests
Docs Changes: n/a
Release Notes: n/a
Part of #10454

An alternative approach would be to keep the StreamInfo at the AS level but pass a mutable ref to the filter manager via its ctor, which might be better? Open for suggestions here


input & output only show up when declared in metadata array

Input & Output only show up on the info panel when they're declared in the directive metadata array like so:
@Component({
  inputs: ['hero'],
  outputs: ['deleteRequest'],
})

but not when they're specified using decorators:
@Input() hero: Hero;
@Output() deleteRequest = new EventEmitter<Hero>();

I spoke to @sumitarora about this, it appears that we cannot proceed until reflection in angular2 exposes this @Input/@Output.

Fixed: https://github.com/rangle/augury/pull/479 with support of Reflect.getOwnMetadata('propMetadata' type)


I want to know where I can set the jdk package in my code, because I want to make an rpa application, but I don't want users to go to amazon to download OpenJDK

Hi @lmh87883819, OpenJDK is only needed if you use visual automation or keyboard() function. Otherwise no need.
Also, if users' PCs already have Java, may not need to install OpenJDK separately. You can try if it works on their PCs.


Fixes issue #422 - Multiarrow can be picked up

Tested with and without infinity.
Affects only the extra arrows from MultiArrow.
Single primary arrow can still be picked up if the bow does not have infinity.

Thanks for the PR.


Add chef_data_bag_item to Cheffish DSL methods

This method is included in the docs: https://docs.chef.io/resource_chef_data_bag_item.html and Cheffish's README: https://github.com/chef/cheffish but was missed when we made chef-provisioning and cheffish lazy-load in 010392858c2a3a036578b681085704ed1971ab21
@chef/client-core

👍  whack merge when green

fixes #5111


Regenerate the Service Bus SDK

👋 hey Azure SDK for Go team!
I've been going through trying to upgrade us to v9 of the SDK - and noticed a blocker 😞
When previously dry-running the SDK upgrade - I'd commented out a breaking change in the Service Bus SDK, where the Location field has been removed from the Response models. Unfortunately this meant that I'd only reported 1 of the 2 issues with the Service Bus SDK, which means we're currently unable to upgrade to v9 of the Azure SDK for Go 😞
I was hoping that we may be able to work around this by not posting the Location field at Creation/Update time - but unfortunately it's a required field. I've opened a PR to the Rest API Specs Repository which fixes this - once this is merged, would it be possible to re-generate and re-release the SDK?
Could we also add this to the list of breaking changes in v9 too until this is resolved?
Thanks!

Thanks for taking care of submitting a PR the API Specs Repo! Given that this is strictly additive to what exists in v9, we may as well add it in as a v9.1.0. We're going to turn our sights to v10 shortly, but given how useful it would be to v9 to have this added back in, we'll try to include it in both.

Hi @marstr
Is there any ETA on 9.1? We are currently waiting on it to support web_apps in terraform
Thanks
Paul

@marstr I'm not sure if it's helpful or going to cause a ton of pain with the v10 release - but I had some spare time tonight and ended up attempting this in #601 :)

Fixed!


Move contrib/pdqsort from submodule to source

Motivation:
Some users build ClickHouse from .tar.gz without submodules. And pdqsort is not available as a separate library in any OS.


Fix for babyman/quick-tabs-chrome-extension#363

A quick and simple fix, I've been using it for about 2+ weeks now with great results. The issue is gone, and I did not notice any other issues (though while I do use quite a lot of app shortcuts, I have not tested it extensively with pop-out dev tools windows (which are handled specially by chrome), only a bit at the start where they seemed to work)
Fixes #363

Works well under heavy use ever since then, no issues noted so far.

@Wizek - Thank you so much for doing this. This bug has really reduced the usefulness of the extension for me, as I use the Google Chat web app, and the MRU just gets stuck on that and stops working. However, this does not seem to be in production yet. Is this correct?
@babyman Is this just awaiting your review? If so, please can you review and merge as this is the biggest flaw in what is otherwise a basically perfect extension

@rb-109 thanks for flagging this, I have merged the code but I already submitted the update for 2024.11.24 for review.  Seems that withdrawing that and resubmitting may slow down the review process :|.  I'll push this once the current update clears.
@Wizek, thanks for finding and fixing this bug, I tweaked the code a little after the merge but the behaviour should be the same.  Let me know if you have any concerns :)

Uploaded the update today for review, hopefully it should be live in a couple of days.


suggestion: settings flag for missing context variables

Apologies if this is the wrong place to suggest something.
Would you be open to a pull-request for the creation of a settings flag for making checking missing context variables optional? We've a well established project and encounter missing context occasionally (indeed, sometimes intentionally... we've had lots of developers...).  I REALLY like the speed-up for startups you package provides.  But the reports of missing context make using this a no-deal.
Fingers crossed you'd be happy for a pull request :)

An access of a variable that does not exist in the context without first checking if it exists with {% if something %} (or even better the fastdev tag {% ifexists %}) is a bug though.


Update documentation

Documentation corrections an updates as mentioned in https://issues.apache.org/jira/b…rowse/LOG4J2-3429
Corrected typo in builder method 'withtFilter' -> 'withFilter'

The "with" style is old, the "set" style is new.

This was closed automatically by Github because we renamed the release-2.x branch to 2.x. Feel free to resubmit to the 2.x branch.


Update workload-rebalancer.md

/kind documentation

generally looks good, thanks for your effort, your improvement helped me understand good English writing.

Thank you, appreciate it!


Performance of String decoding

It seems that parsing UTF-8 strings takes up too much CPU in the decode process.
I've done some research and it might be possible to optimize it here. 🤔

/assign @wbpcode

I've been working on this recently and will try to submit a PR when I'm done.

Merged #11


Navigation: Onboarding Update

Behaviour Q: is the "follow one or more categories" always present on the categories screen? (Considering you can't click "next")


camera distortion

Hi, I find this work very interesting, as i wish to figure out exactly where my markers are on a non-coplanar ArUco board. I am looking through the code, and am wondering the following:

I see you use the camera_matrix in calls to cv2.solvePnP() but not distortion coefficients. Should i undistort my images before using them with the map builder?
I also see that your project function doesn't take distortion parameters. For the cv2.solvePnP() calls i could just add them, for this function as you wrote it yourself its more complicated. Could it be replaced with OpenCV functions like cv2.projectPoints() so that distortion coefficients can be used?

Thanks!

Ah, first paragraph of your readme :p

Super cool stuff, got it to work. Do you welcome pull requests? I changed show_map.py to use a 3D plot when plotting a 3D map, can send that your way.

Ok, and a last question. For a single marker, cv2.solvePnP() has an ambiguity (see, e.g. https://github.com/opencv/opencv/issues/8813). One can get both solutions by calling ret, rvecs, tvecs, reprojectionError = cv2.solvePnPGeneric(objectPoints, imgPoints, cameraMatrix, distCoeffs, flags=cv2.SOLVEPNP_IPPE_SQUARE), whereas  cv2.solvePnP() only returns the "best" one of the two. Would the built map be better if both solutions are taken into account, and consistency in poses between markers in the various images used to prune the wrong solutions returned by the PnP solver? I don't  yet understand the logic and math of the method code, so am not able to help.

Hi @dcnieho, sorry for the late response. I'm glad you got everything to work!
Yes a pull request is welcome. The only concern is if it pulls in a massive dependency on a new third party library.
As for your second question, I'm not sure. When building maps, an image with a single marker contributes no information to the map. For live inside out tracking, you may end up with a camera frame with just a single marker (or no markers) during camera movement. In these scenarios, it could be a good idea to try both solutions and see which one is more consistent with the previous known camera pose.


Memory leak/zombie object

How to free the memory here:
var parsedData : Test = try Test.parseFromData(data)
It looks that I get a zombie object - memory is never released

There is definately a huge leak in parseFromData. Please take a look at it

I need  "proto" file example.

I have
required string name = 1;
required bytes dt = 2;
Look what I found, I'm not 100% sure yet but it looks that the leak is gone if I replace CodedInputStream.swift:44  with: buffer = NSMutableData(bytesNoCopy: UnsafeMutablePointer<Void>(aData.bytes), length: aData.length, freeWhenDone: false)

or at least is much smaller, still needs fixing though

I can't find memory leaks. In my profiler all working fine. Maybe, you have screenshots or "step by step" example, how to reproduce?


prohibit the use of T.{untyped,noreturn} as values

This change ensures that T.{untyped,noreturn} are only used as types, not values.
Motivation

Fixes #3426
Fixes #3428
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IHvMwfNZNU8IUC

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IHvfAIF4fTTtpw

One suggestion on naming (because half the point of this change is to make it so that Untyped always implies "we're talking about types" and never "we're talking about values")

I made the UntypedNil change, reverted UntypedType, and changed the all_bug.rb test to use T.unsafe(nil).  I might have a go at fixing things to use RaiseUnimplemented in a different PR tomorrow.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_IHw7Zsab5USzLS


Add a link to the spec to the GitHub repo

I found https://rawgit.com/slightlyoff/IntersectionObserver/master/index.html on blink-dev but I can't find it from the readme.
Bonus points: make it the repo's website. (See e.g. the headline at https://github.com/whatwg/html at the top of the page.) I think only @slightlyoff can do that though.

I updated the readme. to @slightlyoff to either close or update further, thanks.


feat: dont make CROWDIN_ORGANIZATION a secret, because it isnt

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 12.17%. Comparing base (df748a0) to head (3328d6f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   12.12%   12.17%   +0.05%
==========================================
  Files           7        7
  Lines         231      230       -1
  Branches       38       38
==========================================
  Hits           28       28
+ Misses        202      201       -1
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add support for PHP 8

Let me know if you want me to change anything or if you have better suggestions. Merci!

Hello Alexandre,
now that PHP 8 is released, I changed .travis.yml but is seems that they only have PHP 8 in nightly. I also reverted the phpspec dependency.
Let me know if there is something I can do to make this happen.
Thanks!

I'm waiting for it

Is the some news about this pr?

Is the some news about this pr?

@winzou , are you here?)

@winzou , are you here?)

*shy +1*

@winzou how can we help you?

Thanks for your PR! And sorry for the delay.
I've tagged version 0.4.1: https://github.com/winzou/state-machine/releases/tag/0.4.1

Thank you very much @winzou !
No worries at all for the delay, I hope you're doing well.


Add prompt caching to JS SDK

Problem
Currently, on every call to langfuse.getPrompt(*) a GET request is initiated to the /prompts endpoint. This PR implements SDK-level caching of prompts. Cache TTL can be set via cacheTtlSeconds property in an optional third options param in langfuse.getPrompt. If not specified, a default cache TTL is used (currently 60 seconds).
In case there is an expired prompt cache but fetching the fresh prompt fails, the stale prompt will be returned from langfuse.getPrompt to enable failover.
Changes

Introduces prompt caching to the JS SDK
Default cache TTL set to 60 seconds
Enables failover to stale prompt cache when fetching the fresh prompt fails
Optional third param added to langfuse.getPrompt(*) to customize cache TTL through the cacheTtlSeconds property

Release info Sub-libraries affected
Bump level

[ ] Major
[X] Minor
[ ] Patch

Libraries affected

[ ] All of them
[X] langfuse
[ ] langfuse-node

Changelog notes

Added support for SDK-level caching of prompts

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Excess error logs upon termination

Description
Observed Behavior:
Occasionally Karpenter will print logs with log.level error during shutdown due to context cancellation, e.g.,

getting messages from queue, receiving sqs messages, RequestCanceled: request context canceled
caused by: context canceled

Expected Behavior:
Normal operations should not produce error logs. On the other hand, there might be issues where the context is cancelled due to network timeouts, so simply omitting errors here is not a likely option.
Reproduction Steps (Please include YAML):
Versions:

Chart Version:  0.36.1

Kubernetes Version (kubectl version): v1.30.1

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

It makes sense to me that we would emit this log on shutdown. What logs are you trying to not emit that are being emitted? Is it just the shutdown logs?


[Snyk] Fix for 7 vulnerabilities

Snyk has created this PR to fix 7 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

website/package.json
website/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Uncontrolled resource consumption SNYK-JS-BRACES-6838727
  696

Denial of Service (DoS) SNYK-JS-WS-7266574
  696

Path Traversal SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
  691

Information Exposure SNYK-JS-FOLLOWREDIRECTS-6444610
  646

Cross-site Scripting (XSS) SNYK-JS-SERIALIZEJAVASCRIPT-6147607
  626

Inefficient Regular Expression Complexity SNYK-JS-MICROMATCH-6838728
  589

Template Injection SNYK-JS-DOMPURIFY-6474511
  586

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Uncontrolled resource consumption
🦉 Cross-site Scripting (XSS)
🦉 Path Traversal

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove Twitter Implementation

The bot still has code and NPM packages relating to the Twitter functionality which we used to have. This can all now be removed.

do you mean these resources?
import Twitter from "twitter";
import { TWITTER_ID } from "../config.json";
import TwitterStreamListener from "../interfaces/TwitterStreamListener";
class TwitterService {


Global functions cannot be accessed within a repeat.for loop

Accessing a global function in a template such as ${ encodeURI(uri) } works fine; however, this does not work inside a repeat.for loop. In the below code, neither attempt at using a global function works:

    ${ encodeURI(image.media.m) }

Actually, what I wrote above is wrong. Global functions aren't accessible ever.. I just happened to make it work in testing code.... Will close and recreate issue.


RC Spot Check: Number Line: Integers 1.1.0-rc.2

@KatieWoe, @kathy-phet, and @amanda-phet - number-line-integers/1.1.0-rc.2 is ready for RC testing.  This release is
phet brand only.  This is the 2nd RC on this release branch, and the testing for the first one found two issues, both of
which have been resolved.  I have therefore set this issue up as a spot check where the two issues should be verified, and
some other basic sanity testing done.
Assigning to @KatieWoe and @kathy-phet for prioritization.

General RC Test

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book
for a list of query parameters.)
Download HTML on Chrome and iOS.
Make sure the iFrame version of the simulation is working as intended on all platforms.
Make sure the XHTML version of the simulation is working as intended on all platforms.
Complete the test matrix.
Don't forget to make sure the sim works with Legends of Learning.
Test the Game Up harness on at least one platform.
Check this LoL
spreadsheet and notify AR or AM if it not there.
If this is rc.1 please do a memory test.
When making an issue, check to see if it was in a previously published version
Try to include version numbers for browsers
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
there is a problem.

Focus and Special Instructions
The focus for this testing should be on verifying that the issues found during testing of the most recent RC have been
adequately addressed.

Issues to Verify

[x] CT should not be in this situation if controller is always locked to a point

Though this issue was initially caught by CT, there are two sets of descriptions in the issue for how to duplicate
the problem manually, and these should be tested as well as doing fuzz testing.

[x] Longer strings go out of bounds

Link(s)

Simulation
iFrame
XHTML

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Please mark testing time in the above comment

Spot check looks good. @jbphet let me know if you want more device coverage, otherwise I think this one is done

Cool, thanks.  Moving forward with publication.


linux mint 19 - execution fails - please advise

Also in linux mint 19 I get the following error when trying to invoke any az command:
az login
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/home/steve/lib/azure-cli/lib/python2.7/site-packages/azure/cli/main.py", line 9, in
from knack.completion import ARGCOMPLETE_ENV_NAME
File "/home/steve/lib/azure-cli/local/lib/python2.7/site-packages/knack/init.py", line 6, in
from .cli import CLI
File "/home/steve/lib/azure-cli/local/lib/python2.7/site-packages/knack/cli.py", line 10, in
from .invocation import CommandInvoker
File "/home/steve/lib/azure-cli/local/lib/python2.7/site-packages/knack/invocation.py", line 11, in
from .parser import CLICommandParser
File "/home/steve/lib/azure-cli/local/lib/python2.7/site-packages/knack/parser.py", line 6, in
import argparse
File "/usr/lib/python2.7/argparse.py", line 86, in
import copy as _copy
File "/usr/lib/python2.7/copy.py", line 52, in
import weakref
File "/usr/lib/python2.7/weakref.py", line 14, in
from _weakref import (
ImportError: cannot import name _remove_dead_weakref

python --version
Python 2.7.15rc1

Please file a bug report with the engineering team: https://github.com/azure/azure-cli/issues/


Civet Extension produces error typescript(6056)

File 'w:/vault/libs/nest/src/index.ts' is not under 'rootDir' 'w:\vault\apps\server\auth\'. 'rootDir' is expected to contain all source files.
All I know is that Civet Extension throws this error on nx monorepo due to ignoring paths in tsconfig.base.json
To replicate it you can
pnpm create nx-workspace (integrated, apps)
pnpm i -D @nrwl/nest
pnpm exec nx g @nrwl/nest:app my-app
pnpm exec nx g @nrwl/nest:lib my-lib

Open /my-monorepo/apps/my-app/src/app/app.module.ts and import lib you created it should be located in tsconfig.base.json
This will reproduce error

Finding this issue was quite a hellish job neither useful info nor there was a clue to extension

#921 added support for TypeScript's paths alias in the LSP. I'm still getting the same error, but I assume it's now something to do with nx configuration.... See https://github.com/nrwl/nx/issues/5952 and https://github.com/nrwl/nx/issues/10773


Expose Markdown-It for Adaptive Cards

Please, do you have any idea when this issue can be published? Thanks.


Markers position when zooming

Marker moves out when I zoom in or out, the position moves around, how can I keep it in the same coordinates? Is this spected? Tried OpenMaps and MapBox.
UPDATE:
This is only reproduce when using non "square" marker proportions...
new Marker(
  width: 180.0,
  height: 60.0,
...

Using square width and height seems to solve this issue.

This could be a math / rounding issue with coordinates. Can you make sure you are setting the pin position correctly and not to the center of the icon?

@johnpryan  I dont understand the question, the coordinates are ok, always comparing with a google maps pinned marker.
I have tried with widgets other than an Icon, Card for example, in order to be more descriptive about the marker inside the map, but got the same issue.
The marker itself seems to be pinned at the choosen widgets's center o bottom center, not sure, but in a squared size little Icon the bug isn't noticeable.

Sorry - I meant to say did you try setting the AnchorPos attribute of the marker? https://github.com/apptreesoftware/flutter_map/blob/master/lib/src/layer/marker_layer.dart#L70

I believe I have a fix for this, please bear with me a few days to prepare a PR.

@johnpryan AnchorPos solve this issue (Having non-square Marker), thank you.

cool, thanks for filing an issue!


Issue #33, toBeFunction

What

Why

Notes
Housekeeping

[ ] Unit tests
[ ] Documentation is up to date
[ ] No additional lint warnings
[ ] Add yourself to contributors list (yarn contributor)

Just test descriptions need updating. Good job!

Good job @mprencipe


add nebula algorithm

You may refer to https://github.com/vesoft-inc/nebula-spark-utils/pull/84/files and make some optimization.


How to set MinimumResultsForSearch for AddEqualityFilter?

I want to hide search box form the EqualityFilter which his based on  EnumEditor but i could not found any option to set MinimumResultsForSearch.
lkeVoucherMismatch = AddEqualityFilter<EnumEditor>(Fields.IsAmountMatch,
options: new EnumEditorOptions { EnumKey = "Enum.Accounting.MismatchAmount" });
but this is available in LookupEditor -
lkeVoucherStatus = AddEqualityFilter<LookupEditor>(Fields.Status,              options: new LookupEditorOptions { LookupKey = ApprovalStatusRow.LookupKey, MinimumResultsForSearch = 10 });
How to set MinimumResultsForSearch for AddEqualityFilter?

You can't, subclass enumeditor if you need.


Ncurses support

creates new blits that are used by commit  4f944f810d082f30f81caaabe4ddf54a04158b18 on urbit / vere

ok, have shortened all lines to <= 80
removed all line numbers
the wid that defaults to 80 is overwritten by term.c which has function u3_term_ef_winc() which is triggered by SIGWINCH and which injects new data in via u3v_plan()

Neat, thanks!

which injects new data in via u3v_plan()

I have no idea how u3v_plan works, but maybe window re/size should be an explicit event (either now or in future revisions, don't let me scope-creep you too hard). That would allow dill to notify userspace to force a re-draw accounting for the new size.

I have no idea how u3v_plan works, but maybe window re/size should be an explicit event (either now or in future revisions, don't let me scope-creep you too hard). That would allow dill to notify userspace to force a re-draw accounting for the new size.

u3v_plan() is how the C code injects an event into Arvo.
the event that gets injected is [ $blew [80 25] ] (or whatever the actual screen resolution is)
and this seems to get processed in dill.hoon in ++call where it is dispatched to ... I'm not exactly sure where, bc my arvo knowledge is not complete.

Ohhh, I see now. That makes total sense, and it looks like %blew already works as a CLI event then. (Pretty sure dill sends it off to whoever has running sole subscriptions.) Perfect, no work needed there! Thanks for explaining, @BernardoDeLaPlaz. (:

I gather that this is still a work in progress but I was so excited to try it out that I couldn't stop myself :)
I think that the last commit has introduced some typos (Lines 181 and 272) but after fixing them

L181: |=:able -> |=  git/gift:able
L272: :*  [hen %pass /heft/ames %a %wegh ~ ~] -> :*  [hen %pass /heft/ames %a %wegh ~]

I get a nest-fail & %load-lost after doing a |reset, not sure where the error is or means...

@yosoyubik, that error most likely means that the state of dill is changed incompatibly by the |reset (ie, the type of the old state does not nest in the type of the new state, preventing the +load arm - whereby the state is "installed" in a vane - from being called in a type-safe manner).
The compatible way to fix this is add a conversion from the old state to the new state in the +load arm, the easy way is just to make a new pill without loading the vane into a running ship, and then boot into that (turning off automatic vane loading with |autoload, copying in the changed sys/ files, and making a new pill with +solid). See https://github.com/urbit/urbit/blob/master/CONTRIBUTING.md for some more details.
As for this state of this PR: I owe it a review ...

Thanks @joemfb I oversaw the instructions @BernardoDeLaPlaz added here: https://github.com/urbit/urbit/pull/1228#issue-263270629

I've asked for but gotten zero bug reports / feature requests.

Woah hey hang on! I listed a bunch of things on urbit/urbit#1228. Are those not valid bug reports?

someone to coordinate the two PRs

These should just go on @jtobin's personal next list.
I'd be happy to help out with these PRs, since I too would love to get them in. I think I'll have some time available for this soon, but have a healthy fear of the Vere changes for this. Am talking with @vvisigoth today and will bring it up.

I've asked for but gotten zero bug reports / feature requests.

Woah hang on! I certainly did report a list of bugs on urbit/urbit#1228. Don't those count?

(b) someone to coordinate the two PRs

I think this falls into @jtobin's hands? He'll have to put this on his next list once it's ready.
Since I, too, would love for this to make it in, I'd be happy to help out where I can. I think I should have some time available for this on the short term. Vere seems a little scary here, but maybe it's not that bad. Am talking with @vvisigoth today and will bring it up.

@Fang-  my apologies; I was heads down when those went in and didn't see them!

@jtobin
I wrote the C and Hoon code before I knew about breaching vs non-breaching changes.  The upshot is that the project is not easy to roll out.  Also, I've heard from a few people that they'd like it to work in manner X or manner Y. ... but X and Y are not well defined.
So the upshot is that
(a) it may or may not be what people want.  I've asked for but gotten zero bug reports / feature requests.
(b) it can only be merged in as a breaching change, coordinating the Arvo and Urbit PRs.
So, yes, it's stagnating.
I'd LOVE to push it across the finish line, but the next steps ( (a) - crisp bug reports or a stated willingness to accept it as is; (b) someone to coordinate the two PRs ) are things that I need someone else to do.
Also, I'm currently bogged down in nix / gdb hell on the 64 bit vere project, and don't feel like I can take my eyes off of that right now.
Thoughts?
cc @vvisigoth

@BernardoDeLaPlaz Roger.  Given that this seems to need a bit more work, and that it appears it might not actually be wrapped up for some time, for now I think the best thing to do is to close the active pull request.  Feel free to just reopen it or submit a different one when you reckon the work is about ready to be merged.
Re: coordinating PRs, fear not: just fire them at the requisite repos and I will sort them out for you. 😄

But I imagine these PRs will remain the primary location for discussion of the actual dev happening here? Kinda weird to do that in a closed PR imo. Oh well.


Catch error message when portal item cannot be loaded

I added an early return for when fetching a webscene item fails (e.g. when the webscene items has been deleted), so it does not try to load it from a layer as well (which will fail too).
This fixes: https://zrh-web.esri.com/jira/browse/UP-3352

Closing this. Waiting for public Logger API.


[BUG]: Cannot access 'webhookEvents' before initialization

What version of drizzle-orm are you using?
0.29.3
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
Cannot access 'webhookEvents' before initialization
    at Object.webhookEvents (/Users/kate/Developer/react/aperturs/aperturs-t3/packages/db/src/schema/logs.ts:1:1)
    at Object.get [as webhookEvents] (/Users/kate/Developer/react/aperturs/aperturs-t3/packages/db/src/schema/logs.ts:14:45)
    at Object.get [as webhookEvents] (/Users/kate/Developer/react/aperturs/aperturs-t3/packages/db/src/index.ts:16:45)
    at Object.<anonymous> (/Users/kate/Developer/react/aperturs/aperturs-t3/packages/db/src/index.ts:23:6)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._compile (/Users/kate/Developer/react/aperturs/aperturs-t3/node_modules/.pnpm/drizzle-kit@0.20.14/node_modules/drizzle-kit/bin.cjs:8644:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Object.newLoader [as .ts] (/Users/kate/Developer/react/aperturs/aperturs-t3/node_modules/.pnpm/drizzle-kit@0.20.14/node_modules/drizzle-kit/bin.cjs:8648:13)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)

Expected behavior
I am getting this error while I was trying to run migration generate for postgress
here are my files
import {
  boolean,
  jsonb,
  pgTable,
  text,
  timestamp,
  varchar,
} from "drizzle-orm/pg-core";

import { createUniqueIds } from "..";

export const webhookEvents = pgTable("webhookEvent", {
  id: varchar("id", { length: 191 })
    .primaryKey()
    .$defaultFn(() => createUniqueIds("wbhk")),
  createdAt: timestamp("createdAt", { mode: "date" }).notNull().defaultNow(),
  eventName: text("eventName").notNull(),
  processed: boolean("processed").default(false),
  body: jsonb("body").notNull(),
  processingError: text("processingError"),
});

import type { Config } from "drizzle-kit";

export default {
  schema: "./src/schema/*",
  driver: "pg",
  out: "./drizzle",
  dbCredentials: { connectionString: process.env.DATABASE_URL + "" },
} satisfies Config;

Environment & setup
 System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 66.41 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh

solved nvm

solved nvm

what was the problem? i am currently facing the same error

solved nvm

how did you solve the issue, facing same issue.

solved nvm

how did you solve the issue, facing same issue.

I think i solved this by removing the imports from other files. For some reason when ts files are imported that doesn't include table definitions it throws an error similar to that one. At the top of my file i had imports to import tables and there was one other import that was importing enums. After removing that it worked normallyagain


Stale ASCompletion FileCache may cause crashes

Related to #2710.
FD is still crashing on me.
Steps to reproduce:

Open the test project (see below)
Open App.hx
Line 21 - click on HeaderField and press F4. The Header.hx from tink_http library opens, then FD crashes with stack overflow. This happens to me when running under VS debugger. I haven't tried without the debugger.

Test project: https://ufile.io/rczcn
FD version: 49eef1c6
Haxe version: d477e6a (a recent nightly newer than 4.0.0-rc.1)
Note: using lix (haxeshim) for managing libraries and haxe versions
Setup:

npm install lix -g
cd fd-issue-1
lix download
FD Settings: HaxeContext -> Installed Haxe SDKs -> Add > Path: %AppData%\npm
The SDK should be detected by FD as "Haxe Shim" (version doesn't matter)
Make sure the project uses this SDK
Restart FD just in case

So in my case, deleting Data/ASCompletion/FileCache had cured the issue.
Maybe FD should clear the cache under some conditions (any FD update, or particular updates involving changes to the completion-related code)?


Feature request: add NUT-15 Multinut payments to CLNRestWallet

It would be great to have MPP with CLN as well. Here is how it works with LND: https://github.com/cashubtc/nutshell/blob/61cf7def24fa7104d2d195f0cb5105ee8687773f/cashu/lightning/lndrest.py#L198

I'm confused: doesn't CLN always use MPP if not specifically disabled in the settings? Maybe you just mean support for partial invoice payments for CLN
Also, doesn't this check prevent partial payments entirely?
https://github.com/cashubtc/nutshell/blob/d80280e35d8947ee866df6c15dec810767bf30b2/cashu/mint/ledger.py#L769-L775

I take it that in NUT-15, Alice creates a single bolt11 invoice for a certain amount, which is her amount across all the different mints. So then when she supplies that invoice and the proofs that correspond to a partial amount on a single mint, doesn't this check (NUT-5) prevent partial payments entirely?
https://github.com/cashubtc/nutshell/blob/d80280e35d8947ee866df6c15dec810767bf30b2/cashu/mint/ledger.py#L769-L775

Ok I was confused now I managed to understand this anyway, thanks.


Bogged down CPU with Visual Studio 2017 and a C++ project

Hi,
After loading a C++ project, even just a simple one, the CPU keeps running constantly at around 70%. How should I go about to help find out the cause? I've created a minidump if that helps.
In regards to the selected features of the Visual Studio installation, I have chosen only a small subset for C++ desktop development, if that information is of interest.

Hello. Yes, I noticed but I'm not using this extension actively on C++ projects anymore. I discovered the old method I used to set the global property is now causing a some loop inside VisualStudio and it's probably bugged/not supported anymore. The old method was clean in a sense and dirty in another. I will end setting the macro as a per project property: this should also handle the invalidation of the single projects better, without the tricks I was using (which are not the cause of the loops).

Ok... so I am unsure how to understand your answer: do you plan to fix it by not setting the macro as a per-project property or file it under 'not gonna fix for C++ projects'?

I'm gonna fix it. Please have a little patience

Can you test the attached release on VS2017?
Can you also test a sample project on VS2013 or VS2015?
SolutionConfigurationName.zip

A sample test project is the extension source[1]. Read the txt in the folder.
https://github.com/ceztko/SolutionConfigurationName/tree/master/Resources/Test

I tested the .zip with VS2017 and VS2015:

the CPU runs normal
the test projects compile/link (though the one for VS17 crashes on my side due to the VS17 installation being C++ only)
however: the $(SolutionConfiguration) macro is gone - is this expected?

How do you test that the macro is gone? Can you make a simple script and test for it? The macro should still be there even if you don't see it in the macro editor. Unfortunately, I had to remove the macro from the global properties for c++ projects because that was causing issues, so it's possible that it's no more reported in the macro editor. Which is not so good. I think it's time to proper request the feature to Microsoft. https://visualstudio.uservoice.com/

Please vote https://visualstudio.uservoice.com/forums/121579-visual-studio-ide/suggestions/19819036-make-available-solutionplatform-and-solutionc

Please vote https://developercommunity.visualstudio.com/content/problem/75339/extensions-setting-global-property-on-c-projectcol.html

Please test on VS2015 the attached extension with test project: should compile correctly, Release/Debug bin directories should be full, $(SolutionConfiguration) should be visible in the macro editor;

Please test on VS2017 the attached extension with test project: should compile correctly, Release/Debug bin directories should be full, $(SolutionConfiguration) should be not visible in the macro editor.

This is the best I can do, for now. If everything is ok, I will release this version.
SolutionConfigurationName.zip

I test it the following ways:

verify whether macro is visible/available when defining project properties (like the output directory and include paths)
set output directory of the .exe to $(SolutionDir)$(Platform)\$(SolutionConfiguration)\,

verify whether VS's property evaluator shows the expected path
verify files are really placed there

Now I noticed the following interesting behavior:

VS2015

macro isn't visible in the property editor
macro actually works

VS2017

macro isn't visible in the property editor
macro works sometimes, but not always, especially when switching between solution configurations and platform (x86, x64) - though I couldn't find a real pattern yet

While it is kind of unfortunate the property editor/evaluator doesn't pick the macro up, it's something one could live with).
But I am surprised the final evaluation doesn't always work - seems like a refresh issue

VS2015: macro isn't visible in the property editor
Ok, my conjecture about visibility of the property editor was wrong, and I only have VS2017 installed atm. Sorry, there's nothing I can do about it without intense exploring of VS internals with memory debuggers, which I already did in the past just to support VS2013 and later. It is not worth the effort for this visual feature.
VS2017: macro works sometimes, but not always
I got it once, me neither I found a pattern to reproduce it yet. I may have to find a different logic to invalidate the projects after.

Unfortunately VS is destroying the per project macros I'm adding in a unpredictable way. Actually, the way I was using for all VS versions, that is setting a global property in the VC++ ProjectCollection[1] was avoiding this problem nicely, but this is causing the high cpu usage and I can't do anything about it. Possible solutions would be:

Wait for MS to fix the bug with global properties on C++ projects ProjectCollection;
Find the new location of the global properties for C++ projects and have a way to access it/add values;
Find the proper moment before adding per-project global properties, after being reset by VS but before build.

I spent a lot of time in 3) without results and I don't have time for further investigations now so I officially pulled support for C++ projects in the extension running in VS2017.
[1]  https://msdn.microsoft.com/en-us/library/microsoft.build.evaluation.projectcollection.aspx

Hi Francesco,
thank you so much for investigating this!
That's of course very unfortunate, as I am relying on this little macro - as VS allows one to set solution and project configuration independently it's IMHO actually the only proper way to e.g. set the output and include directories to the solution configuration.
But let's see how it goes, a solution to this specific problem might come along, and I'm gonna (re)open a feature request as well.

Can you test the update extension attached? With VS2017 first.
SolutionConfigurationName.zip

I tested it on VS2017 and VS2015 and it is working!
The only thing I noticed with VS2017:
sometimes (though not really reproducible) when quickly rebuilding after switching configuration/platform following output would appear:

Build started ...
Build Failure. Error: Cannot begin a transaction while already in a transaction.
========== Build: 0 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========
Calculating project dependencies...

On a side note it would be helpful if you created a VS17 (test) branch? And perhaps even leave the old code paths for earlier VS versions, since they worked?

Yes, changes are tested in the vs15mef branch. The old code path for previous VS versions is fully preserved. About your "transaction" issue with VS2017: I can't reproduce, but can you test the attached version? I just put a lock that should ensure projects are updated with the macros before starting a new build.
SolutionConfigurationName.zip

It's hard to tell the difference whether the lock you put in has some effect. I think we'll see how it's going.
The bigger issue now is that VS15 works with a simple solution, but crashes with a 'system argument exception' after loading one of my solutions - which is still very simple, but contains e.g. unit test and installer projects...

Are you able to provide a full call stack?

If there is none, this is a good guide to get one by debugging an external devenv.exe with VS itself.

I am able to produce two useful callstacks and dump files and I have a simple solution to reproduce the crash. What's the best way to share them with you?
It's basically very simple: SolutionConfigurationName can't deal with projects grouped under a solution folder (i.e. one can add solution folders and move projects, but when reopening the solution VS crashes). Steps to reproduce:

Create a solution with a C++ project
Add a solution folder
Add an empty C++ project to the solution folder
Reopen the solution

I was able to reproduce. The fix was to not invalidate the project with a save operation during loading. It works for me. Can you test the attached version?
SolutionConfigurationName.zip

Do you have any feedback on the latest test release?

I have it in use since a week and it's working great!
The only issue I experienced is that the extension doesn't recognize when a solution configuration gets renamed, but that's probably an entire other thing/feature?

Solution configuration renamed: yes, this is not handled and it's a new feature. As far as I know there's no easy hook for that, but at some point I may investigate the matter better.
I would like to officially release 1.0.8 with C++ support reenabled in VS2017 but I don't have VS2013/VS2015 at hand for testing. Are you able to briefly test the sample project with the attached release candidate? I removed the dependency on .NET sdk. Thanks
SolutionConfigurationName.zip

I tested the extension again on VS2015 with your test solution plus one of my production ones, and it is working as expected.
Also, the dependency on MSBuild instead of CoreEditor/.NET was a perfect idea, and apparently solved the installation issue - it's presenting the installation dialog instantaneously!

Thank you, I deployed 1.0.8. It's the same package attached here, it shouldn't pop new updates on VS if you have it installed. Thanks for the testing.


Added support to pass --host argument

Having the ability to supply an optional host domain argument from the command line and get it passed through to our custom test code that loads data based on host is needed when multiple test runs are batched.  For example:
$ magellan --host=testus.acme.com
$ magellan --host=testuk.acme.com
$ magellan --host=testca.acme.com

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Clark Hamilton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I am retired now and ill. Sorry I will not be able to comply.
Clark Hamilton
On Aug 13, 2019, at 8:39 AM, CLAassistant <notifications<EMAIL_ADDRESS>wrote:
[CLA assistant check]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla-assistant.io%2FTestArmada%2Fmagellan-mocha-plugin%3FpullRequest%3D7&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549649383&sdata=JtQm5q5I7E0XJmWJcutMbN2wFn6DtCc9PbChK4l%2F4iI%3D&reserved=0
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreementhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla-assistant.io%2FTestArmada%2Fmagellan-mocha-plugin%3FpullRequest%3D7&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549659400&sdata=NjCEUQphAeVEZ7NkLown2ZDHXkYBmghnwlbx64tK55s%3D&reserved=0 before we can accept your contribution.

Clark Hamilton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your accounthttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Farticles%2Fwhy-are-my-commits-linked-to-the-wrong-user%2F%23commits-are-not-linked-to-any-user&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549669404&sdata=iWUyhrrbE7jDYrmdEg8Ls825zzXEK7PrNqHqXPARDwI%3D&reserved=0.
You have signed the CLA already but the status is still pending? Let us recheckhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcla-assistant.io%2Fcheck%2FTestArmada%2Fmagellan-mocha-plugin%3FpullRequest%3D7&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549679409&sdata=rDHX3Z91DNfw6B1U6f%2BzHhjPt7z%2BDi%2FG1lJvMiWzruE%3D&reserved=0 it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTestArmada%2Fmagellan-mocha-plugin%2Fpull%2F7%3Femail_source%3Dnotifications%26email_token%3DAC3RJCBO3T62FG4KO3QRA7DQELISBA5CNFSM4CACP422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GCDHQ%23issuecomment-520888734&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549689420&sdata=kX1Zzd7ByB9E6KrvlzOzdJB%2FkQhJpWeS%2BSDsiPLliMA%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAC3RJCAXXHOH2T3NS5SCOWDQELISBANCNFSM4CACP42Q&data=02|01||03811838fc8d4ef101e908d7200464e7|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637013075549699424&sdata=vcnz4hwE%2F1r%2BYhCQxJ%2FH1A3G2mY3a8nhF48XZoUk5uE%3D&reserved=0.


Port mapping: collision not handled

It looks like port collisions are not detected by vagrant-libvirt.
How to reproduce the bug:

Start box1, map port 8080 of the box to port 8080 of the host
Start box2, map port 8080 of the box to port 8080 of the host
Access port 8080 on the host system

Outcome: the service running on box1 is being accessed.
Expected outcome: vagrant notices the port collision, notifies the user and if auto_correct is enabled uses a different port on the host for the service running inside of box2.

I am not providing a patch at this time, but a bit more information.  The root cause appears to be that the port maps are implemented using the -L option to an ssh to create a tunnel.  The ssh commands succeeds no matter what, so vagrant-libvirt isn't seeing an error.  We need to check the ssh output for the line (something like) bind: Address in use and trap on that.

hm. that sounds awful. Also bad, but maybe programmatically easier is to either bind() on the port yourself and see whether that works or to connect() to the port to see whether there is anything listening on it.

You can make it fail if you use the ssh option ExitOnForwardFailure=yes


Is there a way we can pass in a custom source into vector store?

For example, lets say I have a big txt file (WhatsApp chat export). Now when I'm storing it as embeddings in the vector store, I think the source_document is set as the <name_of_file>.txt which is fine. But what I want is to attribute a finer source. Like say, the person(s) who said this particular keyword, datetime and so on.
Is this currently supported in Langchain?

I assume that you'd need to first parse the chat export and split it into individual messages.
there's a document loader for that:
https://python.langchain.com/en/latest/modules/indexes/document_loaders/examples/whatsapp_chat.html

I'm already using the abstraction of WhatsAppChatLoader. But when ask a query with RetrievalQAWithSourcesChain, it returns the source as (say) /files/whatsapp_chat_export.txt. Not the exact message.

well, you can adjust it to produce each message as a separate document (or use a sliding window over several messages)
e.g. something like this (disclaimer: totally untested)

     docs = [ ]
     for line in lines:
            result = re.match(
                message_line_regex,
                line.strip(),
            )
            if result:
                date, sender, text = result.groups()
                text_content = concatenate_rows(date, sender, text)

               metadata = {"source": str(p), "sender": sender, "date": date}
               docs.append(Document(page_content=text_content, metadata=metadata)

    return docs


Issue-171: Error using iOS OpenVPN

As @fyellin in the comments, there is some chatter on other groups that some OpenVPN implementations cannot handle client keys that are encrypted with RSA.
If the client key is encrypted, we might re-encrypting the current client key using 3DES.
This commit will convert user client key to 3DES in command pivpn -a
P/S: All credits to @fyellin. Many thanks to him.

LGTM. Have you tested this? @cfcolaco: what do you think?

@redfast00 TBH till the end of the year I will be probably struggling to keep my nose on top of the water ... so many stuff to do .. barely have time to breathe ... =/

@redfast00 yes, I use it on my RPi3 before making a PR :)


Secrets are not populated

Describe the bug
The coredns pod that is created by the server fails to start and goes into CrashLoopBackOff. According to the logs, this is because there is no token in the serviceaccount secret. From the kubernetes side, everything looks correct. Looking in more detail at the actual docker container, reveals that the directory on the host that is supposed to contain the secret (the directory that is bind mounted into the container) is empty.
I'm not sure which component is responsible for populating this directory, but something seems to cause it to not be properly populated. That results in no token for coredns, which results in no dns in the cluster, making traefik fail to start.
To Reproduce
See #73 for information about my setup. RancherOS on a Rpi3B, running k3s server and k3s agent as separate containers on the system-docker.
Expected behavior
I expected the directory to be populated with data from the serviceaccount secret.
Additional context
The agent is logging messages about containers that does not exist during startup, but I can't see which containers it is complaining about, or any that are obviously missing.

@mortenlj I think it's not going to be possible to use system-docker to run k3s and have k3s use the user docker.  I have a couple PRs in right now to fix k3s on RancherOS. We should produce a rc that you can test with on Monday.  But we haven't been able to get it to work running k3s in the "system" scope.

That's too bad, I kind of liked the separation. I'll try to purge everything and retry using user docker and see how that goes.

When using user docker it seems this problem goes away, so I'm closing it. If you feel you want to investigate further, feel free to reopen.


Change the sed command to use GNU extended regex so we don't have backslash hell going on

Pretty much as it says. Tested it, and it works. Feel free to clone my repo and put it through more rigorous tests.

Doesn't really seem worth adding a dependency on GNU sed just to have a very slightly prettier regex expression.


Adding if statement to deal with fewer than two columns in dat$Z

When trying to run the code for susie-rss, I noticed that I was getting a strange error which said that I was trying to access an invalid index of susie_tb_ls. I then noticed that this was due to the assumption that there are multiple columns for the dat$Z matrix. In order to deal with this I added a conditional, so that this portion of the code only runs if the susie_list list has more than one element. This allowed for me to bypass that error

Thanks @floutt this makes sense to me although I suspect there might be a more elegant way to do it. @hsun3163 could you take a look and if you think it is proper merge it? If you have other improvements you can make that after you merge.


feat: add support for incremental_predicates

Description
Feature #157. Add support for incremental_predicates.
Models used to test - Optional

Checklist

[x] You followed contributing section
[x] You kept your Pull Request small and focused on a single feature or bug fix.
[ ] You added unit testing when necessary
[ ] You added functional testing when necessary

@nicor88 @Jrmyy Let me know if this is looking good so far. If so, I'll start adding tests.

I'm trying to understand why the temp table during iceberg merges is created as an iceberg table. It'd be faster if it were a regular parquet table.
there could be data types mismatch between iceberg and parquet, I generally agree with you using parquet as tmp and then inserting from that to the final iceberg table might be faster. It's something to explore again if it's really a bottleneck - let's leave the scope of this one narrows down to what is necessary.

I found it complicated in Jinja to test a variable for a list so I created this helper function but let me know if you'd rather stick with Jinja logic:
I left a suggestion have a look :)

Also, please create a relative docs pr in https://github.com/dbt-athena/dbt-athena.github.io to add the necessary explanation on how to use that. It's important to document for example how to refer to "source" (src) and target table I think that the examples that you use are quite good.

Relative docs PR opened at https://github.com/dbt-athena/dbt-athena.github.io/pull/9

@chrischin478 regarding docs question for now we are in supporting both.
@jessedobbelaere @Jrmyy @mattiamatrix what is your take here?

@Jrmyy could you have a look too? It looks  good to me.

I started working on unit and functional tests so should have that committed in the next few days.

One final comment and we are good to go. Can you also consider adding what you did to our documentation repo ?

@Jrmyy I created this PR in the documentation repo. Let me know if this is what you're referring to.

I made a review in the documentation repo, a minor comment and then we are good to go.


optimize:the property bean may not be initialized while reading config value

Ⅰ. Describe what this PR did
The property bean may not be initialized while reading config value,so it will cause timeout problem while connecting registry center.like Consul.This PR did a optimization for the problem.
Ⅱ. Does this pull request fix one issue?

fixes #3006
Ⅲ. Why don't you add test cases (unit test/integration test)?
Unit test provided.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3316 (0d3cfd0) into develop (08fbcef) will increase coverage by 0.05%.
The diff coverage is 93.18%.

@@              Coverage Diff              @@
##             develop    #3316      +/-   ##
=============================================
+ Coverage      51.56%   51.62%   +0.05%
- Complexity      3341     3347       +6
=============================================
  Files            616      617       +1
  Lines          20243    20228      -15
  Branches        2541     2494      -47
=============================================
+ Hits           10439    10442       +3
+ Misses          8752     8713      -39
- Partials        1052     1073      +21

Impacted Files
Coverage Δ
Complexity Δ

...ing/boot/autoconfigure/SeataAutoConfiguration.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...gure/provider/SpringBootConfigurationProvider.java
60.71% <96.87%> (+21.82%)
8.00 <0.00> (ø)

.../boot/autoconfigure/PropertyBeanPostProcessor.java
100.00% <100.00%> (ø)
5.00 <5.00> (?)

...ta/spring/boot/autoconfigure/StarterConstants.java
100.00% <100.00%> (ø)
1.00 <1.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

... and 33 more

I think it's better to get the configuration directly from the Environment in the springboot project.

I think it's better to get the configuration directly from the Environment in the springboot project.
What if the environment variables of Seata conflict with those of other software?

I think it's better to get the configuration directly from the Environment in the springboot project.

What if the environment variables of Seata conflict with those of other software?

If configuration conflict is considered, all components integrated with springboot will have a headache. Therefore, this issue is generally not considered.


How to download a specific split of the dataset?

Is there a way to use the huggingface APIs to only download a portion of the dataset? I see that the parquet files are named with validation, validation_unique, test, train, etc. prefixes, but when trying to download a single split, it seems to download the entire dataset:
load_dataset(
    DATASET_NAME,
    cache_dir=CACHE_DIR,
    split='validation',
)

I'm not sure how huggingface datasets works -- i.e, is there some metadata file that huggingface can use to map "split" to "files in that split"

Yes, use streaming=True, so you don't download the entire dataset.

Closing. @vedantroy feel free to reopen if it did not work out.


Feature Request: Support for ETag

It would be awesome if we could get support for ETag and If-Match with REST operations to support concurrency.

For now, at least, isn't this available in the OpenAPI metadata?

Unfortunately, no. The server has to return it for starters: https://hajekj-dab.labs.tntg.cz/data-api/rest/product and then has to implement it with upsert operation.

Ouch. Could you walk me through a use case that could not otherwise be accomplished?

ETags are important for concurrency control, for example performing "locks" on data, simultaneous updates, eg. someone changes the record before me, and I attempt to update it with older data, etc.

Plus one on this request.
Etag and if-match support would be of great help handling concurrent update requests.


AddSign and PowerSign optimizers for contrib.opt

Added optimizers with update rules from https://arxiv.org/pdf/1709.07417.pdf

Can one of the admins verify this patch?

I signed it!

Thanks @kdubovikov for this PR, and for your interest in the paper!
It's worth noting that Irwan (the paper author) is already mostly done with a change to add these optimizers to GitHub.  I would be happy to take this change, but it is complicated due to the fact that most of our supported optimizers require C++ fused implementations for speed and distributed training reasons.
Given that this work is almost done, would you be okay if we closed this PR in favor of the C++ version that is coming soon?

Hi! Great news! I thought to develop C++ code later, but it’s clear that the author of the paper will manage this perfectly. Hope I’ll implement something more useful further along

Great, I'll close it for now, but if we can't get the C++ changes in by the end of the month, I'll reopen.


[varLib] Designspace rules cannot easily be chained

It is hard (impossible?) to make overlapping Designspace rules where subsequent rules refine earlier substitutions.
The reproducers are described on https://github.com/daltonmaag/designspace-rules-reproducers, particularly

var-test.designspace contains the rules as I'd like to have them working.
var-reference.designspace contains the manually cut up rules that make it actually work. See the README over there for an explanation of the rule setup.

What I expect to happen:

What actually happens:

From what I have gathered so far, there seem to be two issues at play:

Rule lookups may end up in a different order than in the Designspace, making it hard (impossible?) to make rules that build on each other. In the var-test.ttf font, the rules bracket1 and bracket2 are switched in the GSUB lookup list. Not a problem here, but can be with more substitution chains.
Automatic de-overlapping may misfire under certain conditions and create a new set of conditions and registered lookups that do not match what you'd have to write by hand. In the var-test.ttf font, overlaps are not dealt with at all.

I tracked the rule data flow of var-test.designspace to https://github.com/fonttools/fonttools/blob/5e6b12d12fa08abafbeb7570f47707fbedf69a45/Lib/fontTools/varLib/featureVars.py#L122 and found that the return value (and the resulting font) looked analogous to this (TTX dump here):
# Lookups, with wrong order
bracket0 = {'A': 'A.stack', 'a': 'a.stack'}
bracket2 = {'a.stack': 'a.break'}
bracket1 = {'A.stack': 'A.break'}

# Feature variations:
[
    ({"HGHT": (0.75, 1.0), "STCK": (0.0, 0.0)}, [bracket1]),
    ({"HGHT": (0.45, 1.0), "STCK": (0.0, 0.0)}, [bracket2]),
    ({"STCK": (0.0, 0.0)}, [bracket0]),
]

When I changed the TTX dump manually to order lookups like the DS rules and register the lookups of shadowed condition sets, it worked as expected (TTX dump here):
# Lookups
bracket0 = {'A': 'A.stack', 'a': 'a.stack'}
bracket1 = {'A.stack': 'A.break'}
bracket2 = {'a.stack': 'a.break'}

# Feature variations:
[
    ({"HGHT": (0.75, 1.0), "STCK": (0.0, 0.0)}, [bracket0, bracket1, bracket2]),
    ({"HGHT": (0.45, 1.0), "STCK": (0.0, 0.0)}, [bracket0, bracket1]),
    ({"STCK": (0.0, 0.0)}, [bracket0]),
]

Humm. Yeah I don't think any of us expected chained rules to work. If they are indeed well-defined, we can try to make it work. The overlap resolver might just work if we remove a couple of sorted() or adjust the keys. Maybe not...


Backport branch does not install

Hi,
I cannot install backport branch on my Anroid Api 17 device. It force closes and its mainly related to SVG xml files

Hi, backport is still a work in progress so that's expected. Thanks for filing, I should probably update the readme to that effect.


Implement blob storage images seed

Solves:

https://github.com/MangoInstantMessenger/MangoMessengerAPI/issues/464
https://github.com/MangoInstantMessenger/MangoMessengerAPI/issues/481

Re-opened at https://github.com/MangoInstantMessenger/MangoMessengerAPI/pull/482


Add django project structure and apps

Currently, we are done with the front end as of now and build a proper backend structure with apps
Coding easy ---->auth
|----->courses
|------>home
like this , you don't have to run the whole project just create a proper structure and make a route for homepage only .

@Snehaa1203  @7saikat7 please look into this issue

Who is working on this?

@Snehaa1203  currently no one but this is a urgent issue so if no contributor is taking this up , you  and @7saikat7 can make a basic structure...
one more thing @7saikat7 please create some more simple issue regarding backend

Okay, will see to it.

assign me

@Atif0604 make  a new PR for this


Implement direct calls to cloud functions. https://firebase.google.com/docs/functions/callable#call_the_function

#238

Closed by #238.


Chromium Framework (Mac) Infected

The latest build on the Mac came up with a system warning under High Sierra stating a checksum error and possible malware. In scanning individual files with VirusTotal the Chromium Framework file AegisLab detection found the Trojan.Win32.IRCBot.l3vP trojan in the Chromium Framework file.

Hello, this is probably my build you're referring to, I'm guessing 81.0.4044.92-2
I repeated your test and got the same result: one (AegisLab) of 60 virus engines finds a potential threat called Trojan.Win32.IRCBot.l3vP in Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/81.0.4044.92/Chromium Framework
The only other mentioning of this specific threat I could find was in a forum post from the MacInTouch Community, which gave me the idea to test other binaries of the same release version.
I also tested the same release versions (.92) from FreeSMUG and Marmaduke/ungoogled as mentioned on chromium.woolyss.com and got the same warning for the Marmaduke/ungoogled binary but not for the FreeSMUG binary
Given the same result for the two ungoogled binaries built on different machines makes it unlikely that my build system has been compromised. Rather it seems that compiling ungoogled chromium for macOS produces a pattern in the binary that is recognized by one anti-virus engine as possible threat.
I would guess this alarm refers to a Windows trojan, as for the Win32 in the name, maybe the Backdoor.Win32.IRCBot, the TROJAN.WIN32.IRCBOT, or the Backdoor:Win32/IRCbot.BH – anyway, a very Windows specific piece of binary code that could not perform the same actions on a macOS system.
Therefore, given that it's detected only by one out of 60 anti-virus engines, in two different binaries of ungoogled chromium built on different systems, it seems most likely to me that this is a false positive result of the AegisLab engine on VirusTotal, i.e. no actual infection with Trojan.Win32.IRCBot.l3vP and hopefully no other malware…
You got me scared a bit there, but it's always a good idea to run some extra tests (like scanning for viruses in the binaries)

Perhaps it's a false positive, but the same framework from the FreeSMUG build and Google's build don't trigger any false positive so that gives me concern to why this is occuring.

Anti-virus systems are always susceptible to false-positives. I bet they are probably doing some pattern matching on the machine code or assembly.
If you are really concerned about this, I'd advise you to contact VirusTotal why this occurs (or find a way to build ungoogled-chromium yourself in a trusted environment). I think @kramred's explanation is sufficient here.

@Sonny-Fox, note also that the two versions (ungoogled vs. FreeSMUG/Google) are quite different in size: the binary of the ungoogled framework is ~170 MB whereas the FreeSMUG binary is about 260 MB
The binary pattern that is (falsely) recognized in the ungoogled version is not (fully) present in the much larger version as there is other code interspersed or surrounding it.
Also, only one out of 60 anti-virus engines generates a warning (which is for a very different operating system).
Therefore I would raise your "perhaps it's a false positive" to a "most likely it's a false positive"
As we don't know the pattern that triggers the warning it's difficult to argue using the binaries. But if you have access to a macOS build system or we get the GitHub Actions build working you can use a build you trust more and upload it to VirusTotal and most likely you will get the same result, as I got for the Marmaduke-ungoogled binary - which should confirm it's a false positive as you can/could inspect all the source code and there is no code for the Trojan.Win32.IRCBot.l3vP


Can't find file: 'bx_timeline_hot_track' (errno: 2 - No such file or directory)

Database error
Query:
SELECT event_id FROM bx_timeline_hot_track
Mysql error:
Can't find file: 'bx_timeline_hot_track' (errno: 2 - No such file or directory)
Location:
The error was found in fromCache function in the file /home/username/public_html/modules/boonex/timeline/classes/BxTimelineDb.php at line 356.
collation_connection:
utf8mb4_unicode_ci

It maybe you are using some old version of Timeline module, please check if you are using latest version.


[Key Request] Table 6661 "Return Receipt Line" - Two new keys

For page sorting we need two new keys with Standard fields only. Currently it is not passible to use a table Extension to create new keys on existing tables.
The new keys are:
1. First key
Sell-to Customer No.,Type,No.
2. Second key
Bill-to Customer No.,Type,No.

We are going to deliver possibility for partners to add table keys soon. Closing this old request for now.


Support for Node v6

Already said here: https://github.com/strongloop/fsevents/issues/122#issuecomment-221005180
Now I understood better:
From Electron v.1.1.0, they use Node v.6.1.0 (https://github.com/electron/electron/releases/tag/v1.1.0)
Now they are at Electron: 1.2.1 Node: 6.1.0 (http://electron.atom.io/)
When I run, first it don't find the needed FSEvents package.
In node_modules/fsevents/lib/binding/Release, for the file fse.node, it exists node-v47-darwin-x64, but it needs node-v48-darwin-x64 (for node v6  I guess).
If I try to rename (copy/paste) into ...v48... it sais, obviously, into console.log :  Error: Module version mismatch. Expected 48, got 47.
So I guess fsevents don't yet support node v6?
Or am I doing something wrong?
I tried npm rebuild fsevents --build-from-source and npm rebuild fsevents --update-binary. All methods will download only v47, not v48.

fsevents supports node v6.  There are no prebuilt binaries yet but building from source should work.
I don't think prebuilt binaries would have helped in your case though.  Electron says it's ABI compatible with v6 here (NODE_MODULE_VERSION == 48) but v6 ships with V8 5.0 whereas electron ships 5.1.  That's not going to work.

+1

I'm waiting for node-pre-gyp 0.6.29 to actually be published (https://github.com/mapbox/node-pre-gyp/issues/218), then will publish a new fsevents with it.
Should help with node v6.1.0 - although electron builds seem to still be complicated in some cases.

thanks

So I just got the same issue... I cannot install fsevents because I'm running Node 6.2.2

@es128 it's released

Looks like this has been pulled - can fsevents be version bumped so it can be npm installed? Don't mean to step on any toes, sorry if I am. Just excited to use NPM 6 and can't without this :(

Just published 1.0.13 with the latest node-pre-gyp. Sorry for the delay.

I'm getting Module version mismatch. Expected 49, got 46 with these versions:

node v6.3.0
electron v1.3.3
fsevents v1.0.14
node-pre-gyp v0.6.29

I ran ./node_modules/node-pre-gyp/bin/node-pre-gyp install --build-from-source from within Electron.
These bindings exist within fsevents/lib/binding/Release:

electron-v1.3-darwin-x64
node-v11-darwin-x64
node-v46-darwin-x64
node-v47-darwin-x64

Any advice on getting v49 instead of v46?

@aleclarson I'm going to guess that you install using node, then try to run the result in electron?
You will have to consult the node-pre-gyp documentation on how to override the node_abi variable because auto-detection is going to fail in that scenario.  npm install fsevents --runtime=electron may do the trick but you will have to check that.


Add stack traces

Explore using buidler.dev
Note: We have done some work previously with sol-trace: https://github.com/AragonMesh/0x-dev-tools

This needs aragonOS to be updated to solidity v0.5


logviewer support for configurable storm.log.dir

but fall back to hardcoded mesos-sandbox path.
Notably, storm.log.dir is the configuration parameter in storm for choosing the log directory to be used (it's set in the logback (storm-0.9.x) & log4j 2 (storm-0.10.0+) config files).

@dsKarthick @jessicalhartog @DarinJ : please review at your convenience

@DarinJ & @dsKarthick : thank you for the review, I just pushed a change.
NOTE: I also noticed some setting of storm.log.dir to the mesos sandbox in the Docker command line shim methods, and in the marathon config file, and in the README:
% git grep MESOS_SANDBOX
README.md:MESOS_SANDBOX path, and running the container. For example:
README.md:$ docker run -i --net=host -e PORT0=10000 -e PORT1=10001 -e MESOS_SANDBOX=/var/log/storm -t mesosphere/storm ./bin/run-with-marathon.sh
bin/run-with-marathon.sh:    ./bin/storm ui -c ui.port=$PORT0 -c nimbus.thrift.port=$PORT1 -c storm.log.dir=$MESOS_SANDBOX/logs ${STORM_UI_OPTS:-}
bin/run-with-marathon.sh:  ./bin/storm-mesos nimbus -c mesos.master.url=zk://${MESOS_MASTER_ZK}:2181/mesos -c storm.zookeeper.servers="[\"${MESOS_MASTER_ZK}\"]" -c nimbus.thrift.port=$PORT1  -c storm.log.dir=$MESOS_SANDBOX/logs  ${STORM_NIMBUS_OPTS:-}
storm-shim-10x/src/main/java/storm/mesos/shims/DockerCommandLineShim.java:        " && /bin/cp $MESOS_SANDBOX/storm.yaml conf " +
storm-shim-10x/src/main/java/storm/mesos/shims/DockerCommandLineShim.java:        "-c storm.log.dir=$MESOS_SANDBOX/logs%s",
storm-shim-9x/src/main/java/storm/mesos/shims/DockerCommandLineShim.java:        " && /bin/cp $MESOS_SANDBOX/storm.yaml conf " +
storm-shim-9x/src/main/java/storm/mesos/shims/DockerCommandLineShim.java:        "-c storm.log.dir=$MESOS_SANDBOX/logs%s",
storm/src/main/storm/mesos/util/MesosCommon.java:      return System.getenv("MESOS_SANDBOX") + "/logs";

For now I'm going to ignore this, but it probably needs to be readdressed later.

So I said I'm going to ignore the Docker command line references, but now I'm thinking that I'll handle it by changing the MesosCommon.getStormLogDir() method to take a String which will be the default logDir to return.  And then I'll pass the appropriate default from the Docker shims as well as the LogViewerController.
NOTE: as an aside, I wonder why the docker command lines have log.dir set explicitly like this, but the non-docker ones do not.

And that latest plan is hitting a roadblock:  MesosCommon is not reference-able from within the storm-shim-9x/storm-shim-10x source code. :_(

Ah looked a bit at the docker code here.  I think the goal here is to keep the logs from being written to the container.  This has a few advantages.  One it keeps the container size from growing (I've seen that fill /var/lib/docker when people throw logs in there). Two it keeps people from having to exec in to look at logs.  I think this might be desired behavior in all real cases.
I'll look at the shim though to see what changes we could make to allow the majority of the code be visible from the shims.  Likely this will involve refactoring anything not calling the shims to a common sub-project.

@DarinJ

Thanks for the explanation about docker -- I don't have any experience with really running docker containers under mesos.  What you said makes sense (I think!).
Regarding "replacing LocalState with a Map":  the only thing we use the LocalState mechanism for today (post #106) is simply:

storage of the framework ID onto disk, so that when we restart MesosNimbus it can reference that value and appear as the same instance of the framework when MesosNimbus reconnects with Mesos.
So perhaps instead of a memory-based Map, we should just write the ID to a file.

The file path can just be: the localDir + /storm-mesos_framework-id, or some such ish.

NOTE: From my observations, localDir is the cwd of the MesosNimbus process on startup, followed by storm-local/nimbus/inimbus/.  Here is how storm constructs localDir.

If we do the above, it's probably ok to rip out all the hard work you did for the shims / modules, since as you said the command line construction is probably relatively to do at runtime somehow (just swapping storm for storm.py afterall!).

@erikdw sounds fine, if you want me to look at anything let me know.  A bit swamped right now, but should be able to look things over and provide comments.

@DarinJ : great, I'm also swamped (as always :wink: ), but I'll "at" you on the PR when I send it for a cursory review.

Sooo.... I'm planning to just close this without fixing it.
Reasoning:

The auto-launching of logviewer is totally broken in storm-mesos even with this fix.  See this comment in #6, this other comment in #6, and STORM-1342 for more info.
The work proposed above is a lot for minimal gain given the previous explanation about logviewer being totally broken anyways.
It would be a PITA to upgrade from the storm-mesos version prior to the proposed fix above to the one with the proposed fix.  i.e., if people wanna keep their framework running, then we'd have to tell them how to extract their framework ID out of the storm-local binary blob file and put it into whatever other file we are using.


chore(deps): update common-dev-assets digest to c87742a

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
2adb44e -> c87742a

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.41.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TechDocs: Stream files directly from AWS S3 instead of buffering and sending

closes #4141

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Thanks! Need to update the mock aws library test.

Thanks! Need to update the mock aws library test.

@ParthS007 Hi! Gentle ping - can we help somehow?

Hi @freben , Thanks for ping. Sorry for the delay, I am occupied with things at work for the moment.
For the PR, I think I need to read the AWS S3 Docs for streaming as some of the methods like createReadStream() and on() are not defined here similar to GCS.
Please correct me if I am wrong and let me know any resource which will be helpful.

Sorry I'm not familiar with the details of that API either :)

oh okay, I will have a look at it. If this PR is blocking something, backstage team can take over. :)

Closing since this is done in https://github.com/backstage/backstage/pull/4434/files#diff-c6eb397b95095a19c7ffdd8b1422ae6b00f31b80dffe957a224ad24fd38c6e98R187 :)


[stable/cockroachdb] Additional parameters for cockroachdb

What this PR does / why we need it:
Currently it is not possible to provide advanded command line arguments for cockroachdb or to provide additional secrets for the cluster members.
This PR introduces two variables:

ExtraArgs to provide additional command-line arguments
ExtraSecretMounts to mount arbitrary secrets

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @a-robinson

/assign @a-robinson

/cc @robert-s-lee

This adds a new feature so it should bump the "middle" number in the version: 2.1.0

@Miouge1 rebased and amend bump version commit

/lgtm
/approve


Bugfix merge sorter might div zero when block bytes less than block rows

Proposed changes
Issue Number: close #xxx
If block bytes are bigger than the corresponding block's rows, then the avg_size_per_row would be zero. Which would end up diving zero in the following logic.
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.29 seconds
load time: 560 seconds
storage size:<PHONE_NUMBER>8 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230112095621_clickbench_pr_78803.html

LGTM


Identity e2e WebJobs tests fail

https://github.com/Azure/azure-sdk/issues/902#issuecomment-1569598341

We've automated this testing via Web Apps. Manual testing no longer needed.


2149 add websocket tests for newheads

Added websocket test for block content, fixed the JSON response and the design document.
Related issue(s): #2117
Fixes #

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.15%.  Consider uploading reports for the commit ae12d3a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   75.15%   75.15%
=======================================
  Files          13       13
  Lines         644      644
  Branches      118      118
=======================================
  Hits          484      484
  Misses        115      115
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Addressed in PR #2225


SQL Server Failover Support

I am looking for information regarding the SQL Server Failover Support option for the SQL Server connection to know what it does.  From my testing, it is sending ApplicationIntent=ReadOnly which causes the query to be passed to a SQL AG read-only replica. You might add this information if it is true.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e77b6456-8d48-b1fc-cba3-993d1f8d5cae
Version Independent ID: 0ca84a81-e16e-a2f7-1cac-00082cf0d86b
Content: Power Query SQL Server connector - Power Query
Content Source: powerquery-docs/connectors/sql-server.md
Service: powerquery
GitHub Login: @bezhan-msft
Microsoft Alias: bezhan

Hi @propellor
Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Build project failure

I tried to build the project  in vs 2017 but I keep getting errors (assembly testing fake). Can you please build the project and release it, otherwise this is a useless repo.

Can you please provide more details about what is happening when you build?

Error relating to Microsoft.QualityTools.Testing.Fakes. Can you publish an install package of hotcakes?

This may be an issue with what version of visual studio you are running.  https://www.visualstudio.com/vs/compare/
fakes is for use with enterprise, so if you run professional you won't be able to build this project
this is  a reference for anyone else who might end up here

@kurtwilbies @kingjordan We've always been using VS Enterprise, so it was far too easy to include an incompatible feature.  Do you have any suggestions to make it more compatible with other VS editions?

I have only used professional and I have never tried to work on an enterprise solution from an outside source, so I don't think I can help you here

Well, we'll keep this open for now to see if anyone comes up with a suggestion.  We didn't intend for there to be any features that are incompatible with other editions of VS, so we'd like to address that as soon as we can.

@BhawanaPokhariya Could you please provide specific details about the errors you're receiving?  If they're different than what you see in this issue, please provide those details in a new issue.  And, yes, Hotcakes works in DNN 8 and 9.

VS2019 Community
Hotcakes Core 03.02.00 Release
This is the output of errors when Rebuilding the solution:

Error	CS0234	The type or namespace name 'Fakes' does not exist in the namespace 'DotNetNuke.Entities.Profile' (are you missing an assembly reference?)	Hotcakes.Commerce.Tests	D:\Eigene Docs\Visual Studio 2019\Projects\Hotcakes-core-releases-03.02.00\Libraries\Hotcakes.Commerce.Tests\ContactService\AffiliateTest.cs	29		Active
Error	CS0234	The type or namespace name 'QualityTools' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)	Hotcakes.Commerce.Tests	D:\Eigene Docs\Visual Studio 2019\Projects\Hotcakes-core-releases-03.02.00\Libraries\Hotcakes.Commerce.Tests\ContactService\AffiliateTest.cs	35		Active
Error	CS0234	The type or namespace name 'Fakes' does not exist in the namespace 'Hotcakes.Commerce.Data.EF' (are you missing an assembly reference?)	Hotcakes.Commerce.Tests	D:\Eigene Docs\Visual Studio 2019\Projects\Hotcakes-core-releases-03.02.00\Libraries\Hotcakes.Commerce.Tests\HotcakesApplicationTest.cs	28		Active
Error	CS0234	The type or namespace name 'QualityTools' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)	Hotcakes.Commerce.Tests	D:\Eigene Docs\Visual Studio 2019\Projects\Hotcakes-core-releases-03.02.00\Libraries\Hotcakes.Commerce.Tests\HotcakesApplicationTest.cs	30		Active
Warning		The referenced component 'Hotcakes.Commerce.Dnn.Fakes' could not be found.	Hotcakes.Commerce.Tests
Warning		The referenced component 'Microsoft.QualityTools.Testing.Fakes' could not be found.	Hotcakes.Commerce.Tests
Warning		Could not resolve this reference. Could not locate the assembly "Hotcakes.Commerce.Dnn.Fakes". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.	Hotcakes.Commerce.Tests
Warning		The referenced component 'Hotcakes.Commerce.Fakes' could not be found.	Hotcakes.Commerce.Tests
Warning		The referenced component 'DotNetNuke.<IP_ADDRESS>.Fakes' could not be found.	Hotcakes.Commerce.Tests
Warning		Could not resolve this reference. Could not locate the assembly "Microsoft.QualityTools.Testing.Fakes". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.	Hotcakes.Commerce.Tests
Warning		Could not resolve this reference. Could not locate the assembly "DotNetNuke.<IP_ADDRESS>.Fakes". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.	Hotcakes.Commerce.Tests
Warning		Could not resolve this reference. Could not locate the assembly "Hotcakes.Commerce.Fakes". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.	Hotcakes.Commerce.Tests
Warning		Found conflicts between different versions of the same dependent assembly. In Visual Studio, double-click this warning (or select it and press Enter) to fix the conflicts; otherwise, add the following binding redirects to the "runtime" node in the application configuration file: 	Hotcakes.Modules

@Navilois Hotcakes only builds with Enterprise versions of Visual Studio, due to usage of Fakes, which are an enterprise feature. At some point these should be removed, since most OSS developers will not have access to visual studio enterprise.

You can work around this by not including the tests project in the build process.


Feature Request: certain extend for indexable interface

Search Terms
indexable interface
Suggestion
Add a method to extends an indexable interface with certain fields, So we get constrain from indexable interface, also get exact field constrain.
So we want a new way to extends indexable interface.
Use Cases
If we define reducers like this:
interface Reducer<S> {
  [key: string]: (payload: any, state: S) => S
}

interface CertainReducer extends Reducer<State> {
  setName(payload: string, state: State) => State
}

const store = createStore({ reducer: CertainReducer }) // Ok
// when to use this...
declare const reducer: CertainReducer
reducer.whatYouWant // oop, should get error but it passed

If not extends, the reducers wouldn't be recognized a reducer.
Examples
for implement keyword like this:
interface Reducer<S> {
  [key: string]: (payload: any, state: S) => S
}

interface CertainReducer implement  Reducer<State> {           // any other words is ok
  setName(payload: string, state: State) => State
}

const store = createStore({ reducer: CertainReducer }) // Ok, it's a reducer

declare const reducer: CertainReducer
reducer.whatYouWant // error, `whatYouWant` didn't exists in interface `CertainReducer`

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

interface Reducer<S> {
  [key: string]: undefined|((payload: any, state: S) => S)
}

?

interface Reducer<S> {
  [key: string]: undefined|((payload: any, state: S) => S)
}

?

Looks good. But const t: Reducer = {a: undefined} will also pass typing check

Just replacing interface into type works fine.


[RFC] kprobe: Refactor kprobe handling and add naming validation

[BREAKING] Remove the need to pass an event name during initialization; instead, generate a random event name within KprobeAttach to allow running the same kprobe program simultaneously.
Add regular expression checks to ensure that event and function names comply with valid kernel naming conventions.
Extend tests to cover the new functionality and validation.

resolves #47

Really sorry I have submit this patch by mistake


Olympus h2 console in a hosted environment (webAllowOthers)

Sorry, remote connections ('webAllowOthers') are disabled on this server.
Figure out to fix this.

See SecurityConfig class.  Added two static classes extending WebSecurityConfigurerAdapter (one to disable csrf and one for other config).  May be a better way but this works and was simpler than added a RequestMatcher that examines each request, determining whether to enforce csrf or not.