Limit of zero returns all documents instead of just the metadata

If limit is set to zero, all documents are returned instead of none.
This used to work earlier (at least till version 1.0.13) but
recent updates seems to have changed the behavior.

@rpkale Thanks. I will check and get back today.

@rpkale @aravindnc it seems to be a mongoose library bug

@fernandolguevara Yes. You seems to be right. It seems to be the default behavior of mongodb.

@rpkale May be we can try for other alternatives. Can you tell me your use case ?

I did not update my mongodb/mongoose version but existing unit tests in our app started
failing after updating only mongoose-paginate-v2 to latest version. I had a unit test that was
testing the 'limit=0' case.
This is the way mongodb/mongoose always behaved but mongoose-paginate-v2 was designed
to behave differently. The documentation also reflected that:
'You can use limit=0 to get only metadata:' (now removed from Readme?)
Earlier version of this module's code (July 18) implemented this by always doing a
'count' promise but doing the 'docs' promise only if limit > 0.
Though the documented API changed, only the patch version got bumped up.
This may cause surprises to other users or introduce subtle bugs in their apps.
We use this module to provide pagination for our REST API. Zero was a supported 'limit' parameter
for our API. The unit tests verified that it worked as intended.  I can put a fix in our app
to have a workaround for the limit = 0  case (skipping the use of pagination module and getting
the count manually). Else I will have to change the API for our app and not allow users to use
a limit of zero. We don't want our REST API users to inadvertently retrieve thousands of documents.
It would be best if this module fixed this internally and provide the original behavior.
I think this is a useful 'feature' this module provides (an efficient way to retrieve the count of documents
without doing a full query).

@rpkale No worries, I can fix it today. Can you share me the expected outcome while doing limit=0 query. A sample JSON output would be appreciated.
Thanks.

@rpkale The issue is resolved. You can use limit=0 to get metadata only. Thanks for pointing out.
Please update to the latest version v1.0.23


Empty staticMembers

We got reports about staticMembers returning the empty list in a case where there are actually several static members; apparently, the expected mirrors are available if an instanceInvokeCapability is included, which would be a bug because that area is covered by various kinds of StaticInvokeCapability. Details are currently being exchanged via email.

Awaiting further information about the situation that creates the issue.

This program shows the issue:
import 'package:reflectable/reflectable.dart';

class MyReflectable extends Reflectable {
  const MyReflectable() : super(staticInvokeCapability);
}

const myReflectable = const MyReflectable();

@myReflectable
class A {
  static const List<String> foo = const ["apple"];
}

main() {
  InstanceMirror instanceMirror = myReflectable.reflect(new A());
  print(instanceMirror.type.staticMembers);
}

Transformed it prints:
{}

Untransformed it prints:
{foo: _MethodMirrorImpl('Instance of '_SyntheticAccessor'')}

Thx, this immediately revealed a bug, fixed in https://github.com/dart-lang/reflectable/issues/36.

Landed in a4686098f8db6aa4dc9cfe9e1d452ba2e01ccd4a.


Extend wallet connector package to include some minimal to connect the wallet UI

What
In order to select the wallet and handle the wallet connection errors - create minimal React UI components inside the govtool-wallet-connector package.
How
Using the UI should be optional - meaning that govtool-wallet-connector should be working on its own without the need of using the implemented UI to perform the connection.
Components should follow the Intersect/Govtool design system.
Components should not include any hard-coded or predefined labels making them adjustable via prop by the components consumers.
Components should be stateless to make them able to use in th SSR solution.

Moving issue to TODO after review

Moved changes introduced with this issue to proper wrapper on govtool-assembly - link to Pull Request: https://github.com/IntersectMBO/govtool-assembly/pull/1

@bosko-m It would be great to have someone from Proposal discussion pillar to review this pull request. Who in your opinion should it be assigned to?

@MSzalowski Os this still relevant considering the discussion about the wrapper yesterday? CC @teske00 @vpaunovic


Fix incorrect role on navigation components

Context
We are using role=tab in our navigation components. We shouldn’t be doing this as links in these components do not behave like tabs (i.e. switching a view within a page). We can however use aria-current to indicate which item in a set of items is currently selected.
Changes proposed in this pull request

Guidance to review
@adamsilver Value for aria-current: page or true? Can we have two navigation lists with the same aria-current value (I believe you can as current is relative to sibling links).
Link to Trello card

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] New environment variables have been added to the Azure config

aria-current: page is correct 👍


Error when loading session

This plugin error occurred when I tried to load the session. This happened after I updated my neovim and git.
Current neovim (nightly):
NVIM v0.9.0-dev-987+g371a74e4e
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

git version 2.39.2
Error:
E5108: Error executing lua ...site/pack/lazy/opt/persisted.nvim/lua/persisted/init.lua:68: attempt to concatenate field 'branch_separator' (a nil value)
stack traceback:
	...site/pack/lazy/opt/persisted.nvim/lua/persisted/init.lua:68: in function 'get_branch'
	...site/pack/lazy/opt/persisted.nvim/lua/persisted/init.lua:75: in function 'get_current'
	...site/pack/lazy/opt/persisted.nvim/lua/persisted/init.lua:103: in function 'load'
	[string ":lua"]:1: in main chunk

Okay thanks for this. Could you share your config too?

This is my config: https://github.com/latipun7/dotfiles/blob/main/home/dot_config/exact_lvim/exact_lua/exact_latipun/exact_plugins/persisted.lua

I'm sorry. Closed this as it turns out the error caused by lazy.nvim not loading this plugin on module call. 🙏


pin icons are hidden under other icons.

Describe the bug
When using the wfrp4e system, pin icons are hidden under other icons.
(The display area is very small, but it can be clicked.)
To Reproduce
Reproduce anytime in this environment.
Foundry vtt v9 build269
system: wfrp4e-core 5.2.0
mod: DFreds Chat Pins 1.1.0
libWrapper <IP_ADDRESS>
Expected behavior

It would be best to be able to see the icon and click on it.
It would be nice to have another way to view pinned messages.

Screenshots
File attached.

Okay, thanks. I guess wfrp4e overwrote how these buttons are displayed. I'll fix it


Pending Channel.

I opened the channel with 20k satoshi and its been 3 days and it hasnt changed. I chosen the slow fee.
https://blockstream.info/tx/fd52a3ec3bca423507077bb4639db9335b3a84fba99d7326162aa83006588a64
Actual Behavior

Zap version:
Operating System and version:

@crippercrisp yeah, fees have been high lately so it's probably going to be a while until your transaction confirms.

@crippercrisp yeah, fees have been high lately so it's probably going to be a while until your transaction confirms.

any idea on how long it'll take?

@crippercrisp no idea. Could take weeks or longer if fees don't go down quickly enough. See here for current fee estimates: https://twitter.com/CoreFeeHelper

@crippercrisp no idea. Could take weeks or longer if fees don't go down quickly enough. See here for current fee estimates: https://twitter.com/CoreFeeHelper

dang well thanks.

my transaction has been dropped from the mempool but zap still shows it as pending... How do I cancel and get my bitcoin back?

I have same issue - attempted to open channel(s) and have been pending for over a week
Is there really no way to cancel the channel open request to free up the funds?

Is there really no way to cancel the channel open request to free up the funds?

No, you broadcast a bitcoin transaction. You can't unbroadcast it.

my transaction has been dropped from the mempool but zap still shows it as pending... How do I cancel and get my bitcoin back?

If your transaction was dropped from the mempool, you may need to try to run abandonchannel against your lnd node in order for it to unlock the funds.
https://api.lightning.community/#abandonchannel

I am just using the zap desktop wallet, I don't see any option to run commands anywhere?

@brandoncollins7 you can not run the commands from Zap itself, you will have to run them from LND (you may need to install it yourself if you haven't already).

i have the same issue. it's been pending since Feb 17. new to lighting network and getting mynode setup. had no idea it would take this long. my fee was set to slow...$0.15.
this is the current rate 1wk:
11.0 sat/byte  $1.31
Min:   5.0 sat/byte  $0.59.
any thoughts on how long it would take to clear with $0.15. is there a way to check if it's stuck or cancel the channel Funding.

DONE.
Okay. I found a way to return our funds.
if your funds are stuck like mine, I mean you send them from Zap (on-chain) wallet to Zap Lightening and is stuck on Pending.
What you need is to copy your recovery words, download new app on a different PC and recover (!) your wallet from the seed numbers you copied before. if you don't have a different PC you can use virtualization software like virtualbox (https://www.virtualbox.org) to create a virtual PC and install Zap on it.
After that, when you open your Zap on that new PC you will see all your coins on On-Chain, it means you can send it back to your original account/address or any other address

Has anyone tried this?
Wouldn't that amount to a double spend if the open channel transaction is still in the mem pool?
Thanks

It would be nice to know (and see in the zap UI) how many confirmations an opening transaction has received. I can see for example in mempool, that I have 2 confirmations on the channel funding transaction, while zap still show's (just) a pending open notification.
A more nice experience would be if the UI informs me what's the condition of changing that state ("waiting for confirmtion of another x ...")

Might be related or duplicates #3702


Issues with Intel GPU

Game version: 1.17.2 release
Bicubic version: 3.1-dev
GPU: Intel HD graphics 520
Resolution: Regular/no clouds
Result:

are you using bicubic shaders version 3.1 dev?  if so, just ask me again what the problem is, because I am the creator of this 3.1 dev release.

Yes, I was using 3.1 dev. I've tried it on both 1.16 and 1.17 and blocks just does not render. It's probably because of my GPU is unsupported rn. I think, it is caused by waterbump because everything works fine when it's turned off

Yes, thank you for the report, I will fix the shaders later


Hide partitions from users

PR that hides the partitions from the users. Users can now scroll through the dataset through a next/previous buttons.
In addition, a small changes was made to the statistics pages. Previously it had a mix of both local and global statistics which made it confusing. Now it's only restricted to global statistics.
https://github.com/ml6team/fondant/assets/47530815/05a32c54-7fbe-45c3-b7ba-d13e976674e2

Thanks @PhilippeMoussalli!
I think it's a bit confusing what the difference is between the previous / next buttons you added and the pagination of the dataframe view.

Thanks @PhilippeMoussalli!
I think it's a bit confusing what the difference is between the previous / next buttons you added and the pagination of the dataframe view.

I agree, I removed the pagination completely so it should be good if we keep the default rows to display at 20


infinite loop on watch when require the output of generated css in app.js

Laravel Mix Version: (1.6.1)
Node Version (v8.8.1):
NPM Version (5.5.1):
OS: macOS High Sierra 10.13.1

Description:
I tried to require app.css file from app.js, because I have more than one language using import or require
Steps To Reproduce:
first i install new laravel project from
composer create-project --prefer-dist laravel/laravel blog
after that i run npm install
then edit blog/resources/assets/js/app.js
and add require('../../../public/css/app.css');
https://webpack.github.io/docs/stylesheets.html#using-css
then run npm run watch
the infinite loop on watch will start
how can i fix that

You should fill the ISSUE_TEMPLATE in order to get proper community support.

Your setup will definitely cause an infinite loop. Maybe look over the mix instructions one more time.

@devcircus I’m using default setup

@Qanah
Nope you don't have default installation.
Remove this line
require('../../../public/css/app.css');

and then try to reproduce the issue.

@ankurk91 & @devcircus Thanks for response but if i have case like this i need from the webpack including my assets is there any way to do something like this

@Qanah
I am trying to understand, what is the content of ./public/css/app.css.
Does this file include your custom css code?
Can you change this file location to something like ./public/custom/app.css.
Why cant you relocate this file to ./resources/assets folder.

got the same problem now since i upgrade the node to newer version 9.11

close it I am sorry this miss understanding from me

close it I am sorry this miss understanding from me


Allow users to override the font-properties of a font

After testing a particularly screwy font (Bebas Neue) we found that we may need a way for users to override the font-properties generated by Pixi so that we can manually tweak the layout.
Font properties include:
ascent - the space above the baseline
descent - the space below the baseline
fontSize - the sum of the ascent and descent.

I'm trying to think through how best to do this. Setting it in the style sheet object seems obvious at first, but the font-properties are really a product of the font-family and the font-size so it might require a lot of repeating oneself for different font-sizes or instances of the font. Setting it in options based on the font-family would be the other choice but the font-size is not known to the options object.
A combination would be to set the ascent and descent as percentages of the font-size. So to get a 40px font to have an ascent of 25px and a descent of 15px, you would set the value to {ascent: 0.625, descent: 0.375 }. fontSize wouldn't need to be included. Come to think of it, you would only really need ascent since descent would be 1.0 - ascent.
So maybe what we need is something in the options object that maps font-family to an ascender-to-descender (baseline) ratio...
// options
{
baselineRatio: { "Bebas Neue" : 0.625 }
}
That is probably the most  technically correct way to do it but I don't know if that's super logical from a user perspective?

So the way I handled it in the past (which probably won't work for PTT) was that all my text had a box model, which allowed me to add spacing on top and bottom to give the place for the letters to render.
None of what you have laid out here is going to be terribly understandable to a user. But then again, I don't really know what would be. I think like your second way much better than the first.

whatever you decide, hoping you figure out a way to add it

I've opened a ticket with Pixi.js to fix the root cause of this bug. But of course your baseline override feature would be appreciated in case they never get around to fixing it. https://github.com/pixijs/pixijs/issues/8020

@rizen
I've implemented this as an additional mapping of fonts to baseline offset in the options object. Basically, if you find "Bebas Neue" is misaligned by 10px, you can add:
adjustFontBaseline: { "Bebas Neue": 10 }
to your options object. So all pieces of text that use that font will be adjusted.
I tried some other options while I was working, like changing the ascent and descent in the styles object, and none of them seemed to be ideal.
Since it's been a while since this issue came up, can you take a look when you can and let me know if this is solving the problem you were having in a way that makes sense?

also, if you look at the demo html file, you will find a commented out demo of this feature near the bottom.

Is there any way we can attach this to the style rather than as an option?

@rizen Let me see what I can do. I'm a little rusty on why I chose to do it this way.

@rizen If I can just add vertical padding to the bounding box of each word, would that do it for you?

That's what I've already built into my app using https://pixijs.download/dev/docs/PIXI.TextStyle.html#padding
How would what you are saying be different?

Oh, I didn't realize you've already built that. In fact, I didn't realize there was already a padding property in Pixi if I'm being honest.
Would it make more sense to just add adjustFontBaseline as a style property then?

if we can adjust the position of the baseline it will help people who are using 2 different fonts get them to line up correctly, and then they can use the padding to solve the boundary issues.

I'll add adjustFontBaseline to the styles and also keep it in the options on a per-font basis.
They will be independent values so if they are both set, they will be added together.


Azure App Configuration configuration store docs

Signed-off-by: cmendible<EMAIL_ADDRESS>Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Read the contribution guide
[x] Commands include options for Linux, MacOS, and Windows within codetabs
[x] New file and folder names are globally unique
[x] Page references use shortcodes instead of markdown or URL links
[x] Images use HTML style and have alternative text
[x] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Azure App Configuration configuration store docs
Issue reference
Please reference the issue this PR will close: #2660

@cmendible thanks for the contribution. Since this won't be live until 1.9, would you be able to change the target branch from 1.8 top 1.9?


Java ResultSet to Python ResultSet

This task consists of two parts:

Verifying the behavioral equivalence between a vendor-provided Python library and our module
Verifying querying interface

MySQL

The first is done
The second is NOT DONE

Presto

The first is in progress
The second is NOT DONE

This is the related pull request: https://github.com/mozafari/verdictdb/pull/297

This has been done for Presto and MySQL. The support for other databases will be discussed in a separate issue.


Allow subscription to custom Photoshop "4-char" events

generator.onPhotoshopEvent('save',function(){ console.log('document saved'); });

Callback is never fired. Instead Generator prints warning:
Warning: unable to parse JavaScript message response 'save' as JSON. Error: SyntaxError: Unexpected token s`

But I guess event subscription works as this warning is called exactly when I save document. I know that save is not typical generator event but it would be cool to be able to subscribe to custom photoshop events though. Even if they don't return any data I think that callback should be fired. Or maybe I am doing something wrong?

@joelrbrandt With regards to "imageChanged", I noticed that it fires in other scenarios other than when a file is saved. For example, it fires whenever the active document changes, or when I make staged changes to the file without having saved it yet (such as a crop/rotate).
Is there any way to limit the scope of "imageChanged" to only fire when an actual save occurs? Or is there another event that I can listen to which will fire on save and provide me with JSON data about the saved file?

"imageChanged" is sent whenever the document is modified. The event comes with a json object describing what actually happened to the image. If you're just interested in file saves, look for a "file": entry in the json, (the value is the path of the file). There's more info in the wiki here: https://github.com/adobe-photoshop/generator-core/wiki/JSON-event-format

Hey @timothynoel, thanks for you quick response. I did see that I could rely on the presence (or lack) of a "file" attribute in the payload to determine whether I need to react to the event. The issue I am still having is that I see a "file" attribute in that payload even when tabbing between docs in PS. It seems that "imageChanged" is firing on the same trigger that "currentDocumentChanged" fires. Is there any way to single out actual saves from tabbing between opened files (or opening new files)?
Thanks!

Okay, I understand.  This may not be a perfect way to do it, but you could just filter out "imageChanged" with "active" : true, as that should only happen when the front document is switched

It appears that they all come in as "active": true. For instance, if I switch between two opened documents, the one I switch to fires "imageChanged" with "active" set to true because it's now the active doc. The payloads look exactly the same on file open (or when I make it the active doc) when compared to a save.

When a file is saved, it should have "file":[pathname], but not "active":true (because that indicates that the document is becoming active, not that it is being saved).  Or maybe there's still something I'm missing (?)


Test TPCH queries and expect plans same as on testing cluster

@findepi comments addressed

@kokosing Travis failure (checkstyle, didn't investigate the others. Others may be legit failures already present on the CBO)

Superseded by https://github.com/starburstdata/presto/pull/20


Undefined column error

Selecting the Budget phase element on the Budget phase dimension throws an error
Error: undefined columns selected In call: `[.data.frame`(dt, variables)

you can check here

This was due to selecting attributes that are not existent in the requested subset of data. A new property (bound) has been introduced and implemented in DAM and indigo so that it does not let you select such an attribute.
In due time, all inputs will have such restrictions.
http://apps.openbudgets.eu/cube/analytics/budget-athens-expenditure-2006__97b39/descriptive_statistics/facts

It seems that I can still make the request with no complain here
However it is hidden from the indigo GUI.

You are not supposed/expected to craft arbitrary request URLs while using the GUI.
You do get an error message although not that friendly. Do you think @kleanthisk10 should provide sth else?

I think that the request should be cut before it reaches the computation server, with an appropriate error message.
Also I think that these kind of errors should be handled by DAM, so there would be a unified handling. I mean that DAM should check for query validation and if it passes then it should send the request to the according algorithm server.


Would be better if there is an example

Hi, I feel it is a bit confusing to understand well the relationship between the owner/distribution groups/organisation/user. Even with some experience about HockeyApp, I still read a couple of times to understand the description of distributing groups on HockeyApp and AppCenter. It would be much better if there is an example. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c65235df-7ae9-6cde-24fe-c570c0191086
Version Independent ID: 9401ae78-7fc9-e168-db7b-7101b1928cb5
Content: Distribute - Visual Studio App Center
Content Source: docs/transition/distribution.md
Service: vs-appcenter
GitHub Login: @daadam
Microsoft Alias: daadam

@tigerlily777 what kind of example do you have in mind?

@tigerlily777 please check the comments in this issue which link to existing documentation describing all these features: https://github.com/MicrosoftDocs/appcenter-docs/issues/739#issuecomment-564883179
Since HockeyApp is no more, and we have docs describing how App Center works, I will close this issue now.


Adds link to GitHub on main page and contributing page in docs site.

There was no obvious link to GitHub on the main page.  I eventually found it in the linting badge, but it was very non-obvious there.  Everything else in the docs just links to various places besides the GitHub repository.
The Contributing page also was conspicuously missing any link to the GitHub repository.

Thanks for your contribution @MicahZoltu ! I had to open a new PR with your changes as main had its history changed.


Gracefully handle the potential for missing attributes

As described in GH-515

@patriksvensson just pushed another set of changes.

Looks good to me :+1:

@patriksvensson I have kicked the Travis build, in the hope that it will work this time.  If so, can you merge? Thanks!

@gep13 It failed again so I restarted it. Will merge after CI finish.

@patriksvensson woot! This finally passed, can you merge? Thanks!

@gep13 Merged :+1:


Fix ssh key logins at one more place

Extending fix to issue #8 partially fixed in b40717e. Found one more place
where password on ssh login was expected, so fixing it the same way as before.
Signed-off-by: Michal Hrusecky<EMAIL_ADDRESS>

Thanks @miska! I'm going to merge.


Property 'amount' is missing in type '{}' but required in type 'MyValueResponse'.ts(2741)

Can anyone help me with this, as I am pretty new with nodejs
Issue
Hi there, my code was working fine, then I upgrade the node-fetch version from v2->v3 after receiving the npm audit warning. And, now it complaining about Property 'amount' is missing in type '{}' but required in type 'MyValueResponse'.ts(2741)
The amount is declared under another file and here it's source code:
export interface MyValueResponse {
  amount: number[];
}

Need more context (code example)
I assume you do something like: response.json() somewhere and it returns a Promise<unknown> or something?
you have to convert the type to MyValueResponse somehow.


Add Scheduler.forkJoin builder

The Scheduler.computation builder that we have had until now, piggy-backing on top of a ForkJoinPool is in fact not integrated with Scala's BlockingContext. Which can be good, given that this integration means extra overhead and it's not necessarily what you want for CPU-bound tasks.
However we need a Scheduler.forkJoin builder that is responding well to blocking requests, just like Scala's global.

It's merged on master.


Add documentation

Adding documentation in an emacs package is as simple as writing a INFO file and adding a docs directory. Emacs will automatically identify this INFO file and available as documentation. See modus-themes as inspiration

Updated colour palette so I am unsure if this is still an issue. If it is I will reopen issue.

Will do. would you like to be co-author on commit?

Thank you for asking. I don’t think it’s necessary.


Integration issue with @fortawesome/react-fontawesome

Environment

https://codesandbox.io/s/l44kwqnjqm
CodeSandbox environment (it won't let me run that command, let me know if there's more I can do)
Reproduction
https://codesandbox.io/s/l44kwqnjqm
Steps to reproduce
Use { FontAwesomeIcon } from @fortawesome/react-fontawesome, and wrap it in the styled() function. Pass a prop down in the DOM like logoColor that is camelcased, and use it to set a css property.
Expected Behavior
No error message appears, which is the behavior shown if I pass this down to any other component wrapped in styled() (shown with the
Actual Behavior
styled-components throws an error:
Warning: React does not recognize the `arrowColor` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `arrowcolor` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

I'm thinking this could definitely be a problem with @fortawesome/react-fontawesome, but I thought I'd get more information if I put this here.

Hey @ryandrew14, as you've stated it's probably an issue with the FontAwesome component's interface. Did you post an issue on the react-fontawesome repo?
Fortunately you can still work around this warning with lowercase props, or ignore it and it'll still work (on your sandbox, you're currently passing arrowColor instead of the expected iconColor).

Please refer with usage questions to Stack Overflow, as you're more likely to get quicker and helpful answers there ❤ Repository issues on GitHub are great for that, issues, things that need to be resolved in the library itself, or can't be resolved by anyone but the maintainers. While I (and many others on other repos) are happy to eventually answer usage questions, styled-components is a busy repo and mostly stable and slow moving towards new releases, so you're not likely to get fast responses here


Tune files saved to the same directory on the smurf-server

Just noticed that all tune-files are being saved to the same directory on the smurf-server. This can be really bad, especially if multiple slots are tuning at the same time, in which case it's possible that one slot overwrites the tune for another.
@dpdutcher do you know if princeton has seen any issues of this with multi-slot streaming?
Easiest way to fix this is probably to change the tune_path in the pysmurf-config so it's different for each slot, but that is another thing to keep track of and remember to change. Really these should just go into the pysmurf-output folder, since we're not actively removing those from systems.

No we haven't seen issues with this, though it has always struck me as a bit strange there isn't at least a stream_id subdivision in that folder like there is for the pysmurf outputs.

I think the big thing is making sure we're still able to find tune files after they've been made. My memory of pysmurf is that things like S.load_tune() just looks in the tune folder and loads the most recent one (if the path isn't specified). I might say lets put them in tune/stream_id/ instead of the dated folders (which is what I think you mean by pysmurf-output folders). Because these are special enough that we want them to be easy to find.
Especially if we start needing to delete things in the pysmurf-output folders, it will be nice to have a clear distinction of what's easily deleteable and what's not. Tune files and channel assignments are the things that we might want to reference on the smurf server weeks/months after we've made them.

This PR should fix the issue when merged: https://github.com/slaclab/pysmurf/pull/721

Looks like the pysmurf issue just got merged, what else needs to be done on our side?

sounds like this is complete now.


Does not update correct editor when there are multiple editors on the page.

I have a page with 2 tinymce editors on it.  And just installed your code editor plugin (which is very nice, BTW).  If I try to use the code editor plugin on the first editor, when I click Save, it overwrites the contents of the second editor with the value instead of updating the first.  It appears that tinymce.activeEditor is not always returning the editor that the plugin was called from.  I hacked around it by passing the editor variable to displayToxEditorModal and setting the id of the editor as a data attribute on the modal, which I then read back in saveContent()... But I'm sure there's probably a cleaner way to do it.
function displayToxEditorModal(e, display = true) {
  let el = document.getElementById('tox-codeeditor-wrap');
  if (display) {
    el.dataset.editor = e.id;
    el.style.display = "flex";
    el.focus();
    document.body.classList.add('tox-codeeditor__disable-scroll');
  } else {
    e = e || tinymce.get(el.dataset.editor);
    el.style.display = "none";
    document.body.classList.remove('tox-codeeditor__disable-scroll');
    e.focus();
  }
}

function saveContent() {
  let el = document.getElementById('tox-codeeditor-wrap');
  let e = tinymce.get(el.dataset.editor);
  e.focus();
  e.undoManager.transact(function() {
    e.setContent(aceEditor.getValue())
  });
  e.selection.setCursorLocation();
  e.nodeChanged();
  displayToxEditorModal(e,false);
}

@sanelson2000  I don't think this plugin is maintained any further. For anyone landing here in future, Try  supercode plugin that I created for tinyMCE editor. It fixes all these issues and offers more.


environment types

Addresses https://github.com/sillsdev/serval/issues/178

This change is

machine/jobs/settings.yaml line 29 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
What deployment environment is this being used in? I think the deployment environment would be a better name, i.e. "qa".

staging.

Codecov Report
All modified lines are covered by tests :white_check_mark:
see 12 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


Reminder sokol_gfx_imgui.h: assert failure when on window resize when image panel open.

This generally happens when trying to bind "stale" resource handles. The proper behaviour should be a non-fatal(?) validation warning, and the following draw calls must be dropped.
Happens at least here:
https://github.com/floooh/sokol/blob/7aa584f861f1dbf191b0d28277d710ae7f248957/sokol_gfx.h#L8826
and here:
https://github.com/floooh/sokol/blob/7aa584f861f1dbf191b0d28277d710ae7f248957/sokol_gfx.h#L8842

Fixed.


csharp migration to use open-api

Fixes
A short description of what this PR does.
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] Run make test-docker
[ ] Verify affected language:

[ ] Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
[ ] Run make test in twilio-go
[ ] Create a pull request in twilio-go
[ ] Provide a link below to the pull request

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the Contribution Guidelines and my PR follows them
[ ] I have titled the PR appropriately
[ ] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Failed go-client-test with EXIT code 1
java-test completed successfully
node-test completed successfully
csharp-test completed successfully


Extend DRY support into trust-manager official Helm chart

This PR introduces tpl  support for app.webhook.tls.approverPolicy.certManagerNamespace and app.trust.namespace
the changes allow these values to be dynamically set using helm templating, if not provided ,they default to the release namespace

Hi Team,
Request you to please review the PR, since the DCO signoff: yes

Hi Team,
Could you please check on this PR once

Hi Team,
Request you to please review the PR, since the DCO signoff: yes

@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓
I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far.....

@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓
I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far.....

Hello Erik (@erikgb),
I am Asif's team lead on this item. From what I see, the task of add some DRY (Don't Repeat Yourself) support has been misunderstood.
He will rollback his changes and come back with a proper implementation...
Our intent is that, because we are using cert-manager and trust-manager into an umbrella chart, we want in our chart to default the app.trust.namespace and app.webhook.tls.approverPolicy.certManagerNamespace parameters to "{{ .Release.Namespace }}" so all the namespaces involved are in sync whatever the value of the --namespace option is. In order to do so, we need to introduce the tpl function where these 2 parameters are used in the templates.

Hi Erik,
I have reverted the changes which were earlier done, and have made new changes which can avoid repetition of the same parameter multiple times

Ok, I understand the use case better now. Thanks for explaining @Ceddaerrix! I am personally not a big fan of the proposed changes, but we will discuss this in the maintainer team.
@Asif-git03 Can you please update the PR title and description, and revert irrelevant changes in the PR diff?

Sure Eric :)


[WIP] Add support for restoring etcd snapshot

What this PR does / why we need it:
This is a first step towards enabling cluster migration flows, where a hostedcluster can state can be saved, then restored on another management cluster.
The flow I'm attempting to enable is something like:

Pause reconciliation
Scale apiserver deployments to zero
Snapshot etcd for each statefulset replica, push the result somewhere (e.g to S3)
Create a pre-signed URL for each etcd snapshot
Set the URLs in the restoreSnapshotURL API added here in the saved HC resource
Apply the modified HostedCluster resource, restore the etcd snapshot on first startup of the etcd containers

This is related to https://issues.redhat.com/browse/HOSTEDCP-263
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[x] This change includes docs.
[ ] This change includes unit tests.

/cc @csrwng this is a step towards enabling the cluster migration flow as previously discussed - feedback welcome on this first step (I'm scripting most of the other steps for now until the e2e PoC process is proven)

/test verify

Ok the restore is working Ok now, you can pass a pre-signed URL to a snapshot stored in S3, and it's successfully restored.
I'm now trying to figure out the process for restoring dumped resources, in particular:

How do we determine the exact subset of resources that should be applied to the new management cluster vs those which should be regenerated?
The saved resources will have an ownerReference that references a HCP resource that won't exist on creation of a new HC, how do we handle that to ensure the resources don't get immediately GC'd (we could remove the ownerReference, but we want them to be adopted and owned by the "new" HCP/controller right?)

@csrwng I know you had thoughts on this process so when you get a moment I'd welcome any suggestions, thanks! :)

/retitle Etcd backup/restore (manual process)

/cc @csrwng PTAL when you get a moment, thanks!

/test ci/prow/unit

/test unit

/test verify

/retest

/hold
Marking WIP again since I partially added the condition change mentioned by @enxebre - the condition is not yet set on the HCP object by hostedcontrolplane_controller.go though - I'll add that final piece next week but any reviews in the meantime are welcome :)

/hold cancel
This is ready for another review pass I think. @enxebre @csrwng PTAL thanks!

Thanks @hardys. No objections from me other than https://github.com/openshift/hypershift/pull/1239#discussion_r901509918

/retest

@enxebre this is ready for another review pass when you get a moment, thanks!

/retest

thanks @hardys, needs rebase, otherwise lgtm.
/approve

thanks @hardys, needs rebase, otherwise lgtm. /approve

Thanks - now rebased, let me know if you'd like me to adjust the way etcdRestoredCondition returns the condition :+1:

/test e2e-kubevirt-gcp-ovn

/lgtm


Dpl 048 1 fix root sample ids

Script to run in the Rails console. Tested locally. Basically just takes the original ID from the CSV file, searches for it in the DB and if it exists, replaces it with the new ID from the CSV file.

Looks good to me.  Don't worry about linting etc.  This is a one off script and not getting merged into the code base.


yum install fails on Amazon Linux

Using Amazon Linux AMI release 2016.03
 [root@XXXX]# yum install httpie
Loaded plugins: priorities, update-motd, upgrade-helper
951 packages excluded due to repository priority protections
No package httpie available.
Error: Nothing to do

Am I missing something?

I think you might need to add the EPEL repo or something like that. AFAIK the default AL repositories are very limited.

In which EPEL repo can we find httpie tool ?

Hello @cmoulliard  I tried to do the
sudo yum install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm

However, after I installed it I get:
[ec2-user@ip-10-10-10-149 ~]$ http --version
Traceback (most recent call last):
  File "/usr/bin/http", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 3049, in <module>
    @_call_aside
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 3033, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 3062, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 658, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 972, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.6/dist-packages/pkg_resources/__init__.py", line 858, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'httpie==0.9.4' distribution was not found and is required by the
 application

Did you ever get this to work on Amazon Linux?

amazon-linux-extras enable epel
yum install epel-release
yum install httpie


Feature: Hide transactions with no confirmations, labels/notifications sync

This PR closes #786, by:

adding a mocked transaction

Also closes #536, by:

syncing notifications with mocked tx in tx list

Also closes #552, by:

disabling reject/accept button when the other action is being triggered

Finally closes #535, by:

setting the pending status to the mocked txs
and adapting changed made in #778

@fernandomg sorry didn't notice that you started working on it, I just wanted to create a pR for fetchTransactions refactor :) Will move onto different ticket then

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

@fernandomg are you taking this or I should continue?

bump @fernandomg

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Unfortunately I am unable to connect a wallet in this builld.
Tried with Metamask and WalletConnect on Chrome and Opera. After choosing the wallet option (and scanning the QR), it shows the "Wallet connected" notifications, but there is actually no wallet connected.

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Didn't fix the wallet connecting issue, unfortunately.

Didn't fix the wallet connecting issue, unfortunately.

@lukasschor yes :facepalm:, now it should be fixed. Sorry for the delay

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Not sure if related to this PR or not: transactions tab on safe with 0 transactions will display loading spinner forever

The TX was 0.01 ETH

Got this error when making a transaction

@mikheevm, thank you so much for the feedback!
I'll be working on fixes and I'm looking forward to your reply.

Not sure if related to this PR or not: transactions tab on safe with 0 transactions will display loading spinner forever

yes! totally related to this PR. Thing is I forgot to add back the mocked safe creation tx.

About the approach we've chosen to implement pending actions:
When I started working on it I thought about using async/await and maintaining status property on the transaction model in redux store, similar to the approach you've chosen. Now I think this is not ideal, because:

This is one more difference in data models between redux and history service we have to maintain
Difficult to persist
Nested updates with immutable.js are not optimal in terms of performance (e.g if the action is finished, we need to update the transaction, a new transaction will be returned, many parts of app will be re-rendered), also nested updates are generally harder

What I'm suggesting now and want to hear your opinion:
My initial thought - let's store transactions submitted from user wallet with some context payload and use reselect to calculate transaction status, this way we don't have to update transaction stored in redux and thus less re-renders, something like that:
// Add this to `currentSession` reducer
{
  "0x000": {
    "pendingTransactions: {
       "txHash": "0x111",
       "payload": {
          type: 'TRANSACTION_CONFIRMATION"
          safeTxHash: '0x222'
       }
  }
}

What I think after looking at your pr:
We can add a new reducer called pendingActions with a structure similar to the following:
{
  "pendingActions": {
    "0x000": {
       "txHash": "0x111",
       "type": "TRANSACTION_CONFIRMATION",
       "safeTxHash": "0x222"
    },
    "0x333": {
       "txHash": "0x444",
       "type": "TRANSACTION_REJECTION",
       "safeTxHash": "0x555"
    }
  }
}

What do you think @fernandomg?

@mikheevm, so far there are several changes and fixes.

several types were added
wrapped generateBatchRequest
converted some const into enums
converted FetchTransaction class into a module, and used for incoming and outgoing txs
fixed the ETH transfer default values
defaulted some immutable getters
simplified some safe's selectors
added a hardcoded safeTxHash to the createTx. I also added the chevron to expand/collapse its details.

pending:

now mocked tx have no safeTxHash, so it will be opened by default, but I'm working on the fix.
then will have a look at your comments about pending txs rethinking approach and the tx status in a separated component

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

About the approach we've chosen to implement pending actions:
When I started working on it I thought about using async/await and maintaining status property on the transaction model in redux store, similar to the approach you've chosen. Now I think this is not ideal, because:

This is one more difference in data models between redux and history service we have to maintain
Difficult to persist
Nested updates with immutable.js are not optimal in terms of performance (e.g if the action is finished, we need to update the transaction, a new transaction will be returned, many parts of app will be re-rendered), also nested updates are generally harder

What I'm suggesting now and want to hear your opinion:
My initial thought - let's store transactions submitted from user wallet with some context payload and use reselect to calculate transaction status, this way we don't have to update transaction stored in redux and thus less re-renders, something like that:
// Add this to `currentSession` reducer
{
  "0x000": {
    "pendingTransactions: {
       "txHash": "0x111",
       "payload": {
          type: 'TRANSACTION_CONFIRMATION"
          safeTxHash: '0x222'
       }
  }
}

What I think after looking at your pr:
We can add a new reducer called pendingActions with a structure similar to the following:
{
  "pendingActions": {
    "0x000": {
       "txHash": "0x111",
       "type": "TRANSACTION_CONFIRMATION",
       "safeTxHash": "0x222"
    },
    "0x333": {
       "txHash": "0x444",
       "type": "TRANSACTION_REJECTION",
       "safeTxHash": "0x555"
    }
  }
}

What do you think @fernandomg?
EDIT: Kent C. Dodds recently released a somewhat related arcticle - kentcdodds.com/blog/dont-sync-state-derive-it

I'm linking this approach. Actually I moved all the tx state to the store as I found it really unnecessary to re-calculate statuses that will never change. Thinking also in the pagination approach, and assuming that we'll be extending the store with the newly requested pages (no recalculating every page tx status every time we request a list).
But I wasn't aware of the reselect memoization and I like the idea of having information being calculated in the selectors.

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Ok, so far I feel that this PR is ready to be reviewed. I'm proposing a "stop-changes" (except that a bug is found), so we can move forward.
This PR met it's expectations, as it displays a Pending status when a tx is being mined, prevents displaying transactions that have no confirmations, and synchronize the tx status with the notifications.
@mikheevm, @lukasschor. Thoughts?
Things done so far:

refactored how we calculate and structure transactions and outgoingTransactions. I moved most of the statuses into the store, so we don't have to calculate every single status across the app. Note: we have a most flexible approach with reselect, but I prefer to leave that for a different PR.
avoid const web3 = web3ReadOnly
type most of the new functions
replace consts with enums where possible
wrap generateBatchRequest call inside a most descriptive function
clean code (// @flow and //)
use notSetValue for Immutable getters
calculate safeTxHash client-side
fetch safe and safeTokens simultaneously
change FetchTransactions OOP approach and migrate it to a module

Things derived from this PR:

Identicon. I set a default ZERO_ADDRESS to get going // this is failing on development, better solve it in a separate PR
rethink ADD_OR_UPDATED_TRANSACTIONS reducer/action // split it into ADD_TRANSACTIONS and UPDATE_TRANSACTION. Probably nice to have it done in a separate PR
Use interface instead of type for BatchProcessTxsProps // in a different PR. So far this works and wasn't able to come with a quick fix.
loadIncomingTransactions // abstract and reuse logic. Different PR?

Things that can be worked in a different PR when implementing component/selector + reselect approach:

updateStoredTransactionsStatus // unexpected side effect of processProviderResponse
storeTx and removeTxFromStore // too generic and prone to error
actually transactions' status and all the related code can be refactored with this approach.

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

We currently don't show the creation transaction for new Safes. Only after the first transaction is mined and after refresh, the creation transaction appears in the list.

Seems like owner changes are not properly decoded / data is not correctly displayed in the details.

Good Job! 🚀 💯

We currently don't show the creation transaction for new Safes. Only after the first transaction is mined and after refresh, the creation transaction appears in the list.

@lukasschor, just tested this in development. Same behavior, no creation tx until I refresh the screen.

Seems like owner changes are not properly decoded / data is not correctly displayed in the details.

@lukasschor, fixed https://github.com/gnosis/safe-react/pull/897/commits/8e75e999ef6b0a45872e8a9f80a491edb630bd36
Thanks!

Travis automatic deployment:
https://pr897--safereact.review.gnosisdev.com/app

I have a safe 1.0.0 that got stuck in the "Awaiting Execution" step

https://pr897--safereact.review.gnosisdev.com/app/#/safes/0x55C1a91291956Eab87227d4184A26e6F80A771d5/transactions
This is the Tx. https://rinkeby.etherscan.io/tx/0xea7c007c1d94e4577f1997c09ca4ac2570227a8ad634b9257f89225e8ddea00b
According to metamask everything went through just fine.

I have a safe 1.0.0 that got stuck in the "Awaiting Execution" step

pr897--safereact.review.gnosisdev.com/app/#/safes/0x55C1a91291956Eab87227d4184A26e6F80A771d5/transactions
This is the Tx. rinkeby.etherscan.io/tx/0xea7c007c1d94e4577f1997c09ca4ac2570227a8ad634b9257f89225e8ddea00b
According to metamask everything went through just fine.

Ok, this is quite interesting.
If you load the safe in https://safe-team.dev.gnosisdev.com/app/#/safes/0x55C1a91291956Eab87227d4184A26e6F80A771d5/transactions you'll see a tx with nonce 0 in a pending status. So you won't be able to execute the tx with nonce 1 until you execute that pending tx.
Then, the executed tx you shared, is for the owner's wallet, but not a Safe's tx.
Then, the Safe's tx is in its right state, "awaiting execution", but without buttons, as "There are older transactions that need to be executed first" like the legend says.
Now, the reason why you're not seeing the nonce 0 transaction in this PR's instance, is because we're only requesting txs with 'confirmations'. So we're not seeing that pending tx.
@mikheevm, Probably we should decide if we use the has_confirmations=true query param only if the safe supports off-chain signatures?

I've tried different type of tx and I had no issues.

1 owner
2 or more owners
Add/removing/replacing owner tx's
Send funds
Using the apps tab (locking DAI with the compound app)
Check the notifications to be in sync with the status showing at the moment (Pending when is pending, the "successful tx" notification when is  done
Check the "Pending" label
Confirm/Reject buttons are not shown once the owner signed

So besides the issue reported in the previous comment the rest looks good to me

Tried again the Tx for the safe 1.0.0 and this time I was able to sign, but every time I do an error pop's up in the console and it shows an error notification on the site

Now all tx passed just fine. tried sending funds and replacing owners, all show the same error even with the tx being executed sucesfully.
The safe:
https://pr897--safereact.review.gnosisdev.com/app/#/safes/0xeca13481F8514752dC08106c7A265c85caFa563E/transactions
This is the latest tx, but it happened with all of them:
https://rinkeby.etherscan.io/tx/0x9c881f0a1df021871f938ea078af95728982cdf22bf13ba01f6f12d7c52c6d75

The issue I reported previously was fixed
Looks good to me

I have a safe 1.0.0 that got stuck in the "Awaiting Execution" step

pr897--safereact.review.gnosisdev.com/app/#/safes/0x55C1a91291956Eab87227d4184A26e6F80A771d5/transactions
This is the Tx. rinkeby.etherscan.io/tx/0xea7c007c1d94e4577f1997c09ca4ac2570227a8ad634b9257f89225e8ddea00b
According to metamask everything went through just fine.

Ok, this is quite interesting.
If you load the safe in https://safe-team.dev.gnosisdev.com/app/#/safes/0x55C1a91291956Eab87227d4184A26e6F80A771d5/transactions you'll see a tx with nonce 0 in a pending status. So you won't be able to execute the tx with nonce 1 until you execute that pending tx.
Then, the executed tx you shared, is for the owner's wallet, but not a Safe's tx.
Then, the Safe's tx is in its right state, "awaiting execution", but without buttons, as "There are older transactions that need to be executed first" like the legend says.
Now, the reason why you're not seeing the nonce 0 transaction in this PR's instance, is because we're only requesting txs with 'confirmations'. So we're not seeing that pending tx.
@mikheevm, Probably we should decide if we use the has_confirmations=true query param only if the safe supports off-chain signatures?
edit: now that I'm thinking, it's strange that a tx has a rejection tx but no confirmations at all :/

Sorry I missed it. It looks like the confirmation/signature wasn't posted to the service.

@mikheevm, Probably we should decide if we use the has_confirmations=true query param only if the safe supports off-chain signatures?
No, it would work the same way even with the off chain signatures, if the signature is not posted to the service

How come a created transaction has no confirmations (neither from the Owner who created it), but there's a cancellation Tx?
What problem do you see with that? Cancellation transaction = tx with no data, 0 value, and safe address as a recepient. It's possible to create such a transaction

Cancellation transactions are not tied to any particular transaction on the backend, it's a regular transaction

Cancellation transactions are not tied to any particular transaction on the backend, it's a regular transaction

I was talking about the creation tx, the one pointed with red

Fix to the issue #981 was added in this PR.
Now tx's render themselves without the need of refreshing the page manually. It works fine


Temporary docker container1.16

What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
Fix https://github.com/redhat-developer/kam/pull/233 unit test job failure

This changes has no effect on the CI run. Merging the changes into master forcefully, so that pr https://github.com/redhat-developer/kam/pull/233 will consume it.


Imms active at date of encounter don't load because they are "inactive"

OSEHRA>zwrite ^%wd(17.040801,2,5,"load","immunizations",130,*)
^%wd(17.040801,2,5,"load","immunizations",130,"log",1)="code is: 62"
^%wd(17.040801,2,5,"load","immunizations",130,"log",2)="code system is: http://hl7.org/fhir/sid/cvx"
^%wd(17.040801,2,5,"load","immunizations",130,"log",3)="effectiveDateTime is: 2016-06-20T03:23:55-04:00"
^%wd(17.040801,2,5,"load","immunizations",130,"log",4)="fileman dateTime is: 3160620.032355"
^%wd(17.040801,2,5,"load","immunizations",130,"log",5)="hl7 dateTime is:<PHONE_NUMBER>2355-0400"
^%wd(17.040801,2,5,"load","immunizations",130,"log",6)="reference encounter ID is : a051a5c9-ae0b-4098-95f5-8d269497e07b"
^%wd(17.040801,2,5,"load","immunizations",130,"log",7)="visit ien is: 115"
^%wd(17.040801,2,5,"load","immunizations",130,"log",8)="HL7 DateTime is:<PHONE_NUMBER>2355-0400"
^%wd(17.040801,2,5,"load","immunizations",130,"log",9)="Provider NPI for outpatient is:<PHONE_NUMBER>"
^%wd(17.040801,2,5,"load","immunizations",130,"log",10)="Location for outpatient is: #12 GENERAL MEDICINE"
^%wd(17.040801,2,5,"load","immunizations",130,"log",11)="Calling IMMUNUPD^ZZDHP61 to add immunization"
^%wd(17.040801,2,5,"load","immunizations",130,"log",12)="Return from data loader was: -1^Immunization is inactive"
^%wd(17.040801,2,5,"load","immunizations",130,"parms","DHPLOC")=12
^%wd(17.040801,2,5,"load","immunizations",130,"parms","DHPPAT")="9618611252V573609"
^%wd(17.040801,2,5,"load","immunizations",130,"parms","EVENTDT")="20160620032355-0400"
^%wd(17.040801,2,5,"load","immunizations",130,"parms","IMMPROV")=9990000348
^%wd(17.040801,2,5,"load","immunizations",130,"parms","IMMUNIZ")=62
^%wd(17.040801,2,5,"load","immunizations",130,"parms","VISIT")=115
^%wd(17.040801,2,5,"load","immunizations",130,"status")="-1^Immunization is inactive"
^%wd(17.040801,2,5,"load","immunizations",130,"status","loadMessage")="-1^Immunization is inactive"
^%wd(17.040801,2,5,"load","immunizations",130,"status","loadstatus")="notLoaded"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","code")=62
^%wd(17.040801,2,5,"load","immunizations",130,"vars","codeSystem")="http://hl7.org/fhir/sid/cvx"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","effectiveDateTime")="2016-06-20T03:23:55-04:00"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","encounterId")="a051a5c9-ae0b-4098-95f5-8d269497e07b"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","fmDateTime")=3160620.032355
^%wd(17.040801,2,5,"load","immunizations",130,"vars","hl7DateTime")="20160620032355-0400"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","resourceType")="Immunization"
^%wd(17.040801,2,5,"load","immunizations",130,"vars","visitIen")=115

OSEHRA>ZWRITE ^AUTTIMM("C",62,*)
^AUTTIMM("C",62,1062)=""

OSEHRA>zwrite ^AUTTIMM(1062,*)
^AUTTIMM(1062,0)="HPV, QUADRIVALENT^^62^^3^^1^^^^^^^^^^^^^0"
^AUTTIMM(1062,.5)=""
^AUTTIMM(1062,2,0)="^^1^1^3151102"
^AUTTIMM(1062,2,1,0)="HUMAN PAPILLOMA VIRUS VACCINE, QUADRIVALENT"
^AUTTIMM(1062,3,0)="^9999999.143^1^1"
^AUTTIMM(1062,3,1,0)="CPT"
^AUTTIMM(1062,3,1,1,0)="^9999999.1431^1^1"
^AUTTIMM(1062,3,1,1,1,0)=90649
^AUTTIMM(1062,3,1,1,"B",90649,1)=""
^AUTTIMM(1062,3,"B","CPT",1)=""
^AUTTIMM(1062,4,0)="^9999999.144P^3^3"
^AUTTIMM(1062,4,1,0)=10
^AUTTIMM(1062,4,2,0)=9
^AUTTIMM(1062,4,3,0)=53
^AUTTIMM(1062,4,"B",9,2)=""
^AUTTIMM(1062,4,"B",10,1)=""
^AUTTIMM(1062,4,"B",53,3)=""
^AUTTIMM(1062,5,0)="^9999999.145^1^1"
^AUTTIMM(1062,5,1,0)="GARDASIL"
^AUTTIMM(1062,5,"B","GARDASIL",1)=""
^AUTTIMM(1062,6)="Y"
^AUTTIMM(1062,7,0)="^9999999.147A^1^1"
^AUTTIMM(1062,7,1,0)="HPV"
^AUTTIMM(1062,7,"B","HPV",1)=""
^AUTTIMM(1062,88)="^HPV4"
^AUTTIMM(1062,100)="N"
^AUTTIMM(1062,"TERMSTATUS",0)="^9999999.1499DA^2^2"
^AUTTIMM(1062,"TERMSTATUS",1,0)="3151102.135341^1"
^AUTTIMM(1062,"TERMSTATUS",2,0)="3171228.122227^0"
^AUTTIMM(1062,"TERMSTATUS","B",3151102.135341,1)=""
^AUTTIMM(1062,"TERMSTATUS","B",3171228.122227,2)=""
^AUTTIMM(1062,"VUID")="5197687^1^"

Could not replicate. Will reopen if we could.


Issue #SB-19351 fix: create mentor can create only one batch on multi…

…ple clicks of create

this.disableSubmitBtn = true; use this variable to disable the button so that click event will not be triggered

this.diableSubmitBtn is not disabling the button


[Bug Report][Windows] crash on some devices

Edit by @alexmercerind:
We are unable to replicate the crash on the number of Windows devices we tested project upon. If you are facing this issue, please reach us out so that we can identify the root cause & resolve the issue as quickly as possible.
Original comment:
I'm on Windows 10. The player keeps crashing with no error message when trying to play a video on the Demo Windows app.
Steps to reproduce on Windows 10.

Download the available demo on the README
Try to play any video

Maybe it's just my system but it used to work with previous versions.

It's still working on my machine. May you please build the media_kit_test by cloning the repository?
It'd be great to resolve the issue as quickly as possible.

If preferred, we may have an exchange in regards to fixing this at our Discord server: https://discord.gg/h7qf2R9n57

I have the same results when building the media_kit_test folder after cloning the repo, no error message:

If you do prefer it I can show you my screen when doing it.

Hi @Quackdoc!
Would you like to share some of your experience?
https://github.com/alexmercerind/media_kit/releases/download/media_kit-v0.0.5/media_kit_test_win32_x64.7z
Are you also facing crash with the latest build of test application?

I tested app and compiled locally no issues. things to check off hand would be

flutter sdk version

and

mpv's logs since it might be crashing (can grab them by passing log-file location\log.txt to libmpv)

@Kylart if you are comfortable bisecting, you can make sure you are in the main repo, use the command git bisect bad then run git checkout HASHHERE you can grab the hash of any point in the repo, or if you know a specific tag, you can check via that too.
for instance if you think it worked on tag v0.0.4 you can do git checkout --force git checkout media_kit-v0.0.4 --force
then compile and run the test application,
if it doesn't work go to an even older commit or tag, and try that. keep going until one works. continue to the next step when it does
if it worked, go back to the top of the repo, run git bisect good you will automatically change to a new commit, and should see something along the lines of
Bisecting: ... (roughly 5 steps)

recompile and run the app, if it works, type git bisect good if it fails, run git bisect bad
keep doing this until you reach the end, it will spit out a commit log, at the top of it you will see commit information, we want the data that approximately looks like this
252cf5d4d9c4b7ab29301cdcdbbcf3c82220ae35 is the first bad commit
commit 252cf5d4d9c4b7ab29301cdcdbbcf3c82220ae35
Merge: 9d5baf5 7fbe2fe
Author: birros<EMAIL_ADDRESS>Date:   Wed Apr 12 16:30:00 2023 +0200

    Merge branch 'main' into feat/resize

copy that info here, sorry if I am less then coherent, it's 4:30 am

From Discord:

Alright I'm back home. I reset-ed my Windows and now it does not crash anymore. 🤷

The cause of crash was some unknown issue within the O/P's Windows installation/configuration. Issue could not be reproduced on any of Windows machines I could arrange.


cannot set tf.Variable as model input

Tensorflow: 2.1.0
I intend to utilize a pre-trained model and input a trainable input noise. but it is not allowed in tensorflow 2.0. want to find out whether it is a bug or by design.
init_value = tf.random.normal((1, 512, 512, 3))
noise_input = tf.Variable(init_value, trainable=True)

pretrained_vgg19 = tf.keras.applications.VGG19(include_top=False, input_shape=(512, 512, 3))
pretrained_vgg19.predict(noise_input)

@w19787, tf.Variable is used for trainable variables such as weights (W) and biases (B) for your model. Tensor is given as input to model. Working code:
import tensorflow as tf
init_value = tf.random.normal((1, 512, 512, 3))
pretrained_vgg19 = tf.keras.applications.VGG19(include_top=False, input_shape=(512, 512, 3))
pretrained_vgg19.predict(init_value)

@w19787, tf.Variable is used for trainable variables such as weights (W) and biases (B) for your model. Tensor is given as input to model. Working code:
import tensorflow as tf
init_value = tf.random.normal((1, 512, 512, 3))
pretrained_vgg19 = tf.keras.applications.VGG19(include_top=False, input_shape=(512, 512, 3))
pretrained_vgg19.predict(init_value)

The above code is working for normal predict case. but if we want to use pretrained vgg model to trained a noise input, it is not the solution. Actually, we expect the input tf.Variable to be trainable.  I believe in tensorflow 1.0, tf.Variable as model input can be trainable, but it seems that it is not the case in 2.0.

Was able to run the code without any issues with TF v2.0.
Facing an error stating ValueError: Failed to find data adapter that can handle input: <class 'tensorflow.python.ops.resource_variable_ops.ResourceVariable'>, <class 'NoneType'>, while running with TF v2.1 and TF-nightly. Please find the attached gist. Thanks!

@w19787 Can you provide a reproducible case of tensorflow 1.0 showing tf.Variable as model input can be trainable. Thanks!

@w19787 Can you provide a reproducible case of tensorflow 1.0 showing tf.Variable as model input can be trainable. Thanks!

You can refer to the below project training file:
https://github.com/LouieYang/deep-photo-styletransfer-tf/blob/master/photo_style.py
the line 228 create the input image as tf.Variable and line 291 to optimize/computing the gradients only on this input image.
thanks in advance.

@w19787 This is fixed with latest tf-nightly version ''2.2.0-dev20200418' as well TF 2.2.0-rc3. Thanks!

I have tried in colab with TF version 2.3-rc1 and nightly versions(2.4.0-dev20200709) and was able to reproduce the issue.Please, find the gist here.Thanks!

I have tried in colab with TF version 2.3.0, nightly version(2.4.0-dev20200729) and was able to reproduce the issue.Please, find the gist here.Thanks!

@w19787 Closing this issue since it was the intended behavior.Thanks!


Unicorn Plugin

As previously mentioned in https://github.com/angr/cle/issues/22#issuecomment-221132785, a Unicorn Engine plugin is in progress. Thought it would make sense to open up a GitHub issue in the proper repo so other people are aware.
@isra17 recently posted a neat benchmark showing angr vs. Unicorn. https://github.com/isra17/emu_test

(As a clerical note, it looks likely at this point that we will not release
the unicorn support until after the CGC in August)
On Sunday, June 26, 2016, David Manouchehri<EMAIL_ADDRESS>wrote:

As previously mentioned in angr/cle#22 (comment)
https://github.com/angr/cle/issues/22#issuecomment-221132785, a Unicorn
Engine http://www.unicorn-engine.org/ plugin is in progress. Thought it
would make sense to open up a GitHub issue in the proper repo so other
people are aware.
@isra17 https://github.com/isra17 recently posted a neat benchmark
showing angr vs. Unicorn. https://github.com/isra17/emu_test
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/angr/simuvex/issues/29, or mute the thread
https://github.com/notifications/unsubscribe/ACYg9eC-MY_47pwdrVxQaNLCuygLboVqks5qPstKgaJpZM4I-nde
.

Yep, we're definitely working on it! It won't quite match @isra17's unicorn benchmarks (because we need to hook memory accesses to sync the state back into angr), but it'll be a lot faster than emulating VEX with python. Some preliminary benchmarks show runtime increases of 600x for certain workloads.

Exciting stuff! Looking forward to the release after you win CGC. =)

I guess we will release it even if we don't win CGC :D

nice to hear, and looking forward to your release this Unicorn support :-)

For anyone following this, Unicorn support has been completed but not pushed to the repo yet.

cool, cant wait! but exactly how Unicorn is used there?

As per @zardus's previous comment, it's used instead of emulating VEX with Python.

The main use cases of unicorn right now are the following:

The data currently being operated on is concrete. Symbolic emulation isn't necessary so we jump into unicorn and let unicorn/qemu execute until symbolic data would be touched or introduced.
There is something we haven't implemented (weird vex instruction, syscall etc). In these cases I believe it is better to run the part angr can't handle with unicorn. We lose the symbolic relationship, but at least we can continue execution in a sane state

Looks like it's been pushed!

It's been pushed for the last two weeks! The big thing, though, is that our fork of Unicorn is now pushed, to https://github.com/angr/unicorn.
The changes we've made are all pending pull requests to upstream. They're mostly bug fixes and minor features, the biggest thing is that it overhauls the python setup process to do things like actually work correctly without manually copying files around, and also packaging the library headers so simuvex can build against it.
Basically, you should just be able to python setup.py install in the bindings/python directory and it should Just Work. (You can also run the setup.py in the repo root but that's just a compatibility shim until it's distributed on pip)


Vulnerability Check

What this PR does / why we need it:

Upstream it seems the related worklflow is not up to date and fails.
Go sec team has a new tool for vulnerability detection. More here and here.
Sample run here for Serving 1.8 against go 1.18.x and 1.19.6.

Note: might move upstream as well.
Which issue(s) this PR fixes:
JIRA: NONE
Does this PR needs for other branches:
Yes.
Does this PR (patch) needs to update/drop in the future?:
JIRA: NONE

This fails because 1.18.x has several vulnerabilities. Even 1.19.6 has a couple.

/cherry-pick 1.10
/assign @nak3

/cherry-pick main

As upstream has https://github.com/knative/actions/pull/136, I think we do not need to add it on downstream.
govulncheck ./... || true always makes the result green, nobody cares about it. And even if we investigate it, the conclusion will be "it will be fixed when we Go version is updated", right?

/assign @ReToCode
I am fine with either merge or unmerge.

Since govulncheck ./... || true always makes the result green, nobody cares about it in general. Then, even if we investigate it, the conclusion will be "it will be fixed when Go version is updated by production team", right? (because upstream and downstream have Go version diff only.)

It is a way to check what are our current vulnerabilities on that specific branch, we should care before we do a release. It is not always that a new GO version will fix it because there might be a dependency that requires an update as the tool fetches info for packages as well check for example this issue: https://pkg.go.dev/vuln/GO-2023-1631. If that exists in our import path and the version is vulnerable the tool will let us know.

/lgtm
/appove
Hmm.. Okay, I see. If somebody takes care of it, no problem.

By the way, upstream's check also keeps failing https://github.com/knative/serving/actions/runs/4938564386/jobs/8828498001#step:4:131

/hold

Interesting we have one vulnerability upstream to fix.  Btw the database used does not contain only issues for the golang repo and that is the benefit I described above (I chose another issue more appropriate).

Btw the database used does not contain only issues for the golang repo and that is the benefit I described above (I chose another issue more appropriate).

Hmm... I mean if non-Go issue was detected, upstream should have been fixed, right? Because upstream and downstream uses the same code. Then, downstream will detect only Go issue...


Timed queues

General notes:

Periodic dispatch
Would allow implementing smth like cronjobs
Take advantage of a current_time metadata key on clients w/ routing queries

This would be best implemented as a plugin.


Possibility to use Tiberius with different runtimes

It would be great if we'd be able to use Tiberius with other runtimes than Tokio. This means no spawning, and it also means the underlying transportation protocol should be possible to inject into the connection. TcpStream and TlsStream must be able to be chosen by the user, as long as the streams implement AsyncRead and AsyncWrite from the futures crate. The Tokio counterparts can deal with the abstractions by using Tokio's compat module.
For making it easier for the user, we could provide separate crates:

tiberius-tokio
tiberius-async-std

Or additionally this can be handled with feature flags.
The other part needing replacement is the use of tokio_codec. futures_codec is a good replacement using the standard AsyncRead and AsyncWrite.
One should take into consideration of replacing the bytes crate while doing the refactoring, due to bytes being quite unsafe and triggering segmentation faults if using it wrong. One crate to experiment with is byte_pool, being a safe replacement for bytes. Be aware of writing the corresponding byte extensions to the SqlReadBytes.

@esheppa should have some preliminary research and work done already for this.

There are a few trade-offs either way, however the changes should be fairly targeted - so if we do choose one way, it shouldn't be too hard to change to the other.
If we go down the path of using a type parameter for the TcpStream then we probably need to provide multiple crates as mentioned. This style is used by tokio-postgres (partially, it provides a feature runtime, which can be turned off, and then the connect_raw function must be used and a stream from the user provided.
Positives:

Anyone can implement support for another runtime without needing to fork the project

Negatives:

Have to maintain the core crate plus one crate for each supported runtime (albeit these crates would be very minimal)
The current state of implementation also depends on async-trait - this could potentially be removed but it would make implementation less ergonomic. However we could also change the trait into just a regular async function similar to how tokio-postgres handles this
To do this properly requires another abstraction over the various versions of ToSocketAddrs as the current test implementation is simply using a String

If we use feature flags then there only needs to be a single crate and the user can specify which runtime they would like to use. This style is used by SQLx here. They also use a compiler error to make runtime choice mutually exclusive. There is some good discussion here.
Positives:

Can use spawning when required (but this must be implemented for each runtime)

Negatives:

For a new runtime to be supported it must either be a change in this crate, or the user would have to fork the crate to implement by themselves (however there is not currently a large number of runtimes)

Also:

Smol runtime has recently been merged into async-std - however the Async<std::net::TcpStream> is wrapped by async-std's so we would still need to maintain support for both smol and async-std
It would be nice to add support for  may also.

Current Thoughts

I'm going to rewrite the test implementation using feature flags as it seems that they have less downsides for now - it also seems that there is not such a large number of runtimes so the maintenance overhead shouldn't be too large. This may also make it easier to do #28 as there would be access to spawning.
While doing the above I'll investigate replacing bytes with byte_pool or equivalent
Currently using async-native-tls which works nicely across multiple runtimes
Might also add in async-tls to allow use of rustls

I'm fine with the feature flag approach. Maybe the tcp stuff can be boxed in this case, so the user don't need to deal with type parameters, especially when the parameters are different depending on the feature flags.
Or, would it even be possible to do something like:
#[cfg(feature = "async-std")]
stream: async_std::TcpSTream,
#[cfg(feature = "tokio")]
stream: tokio::TcpStream,

Would the crates be similar enough we could work this out without using traits? Otherwise I see a solution that goes
stream: Box<dyn TcpStreamish>,

instead of having the trait as a type parameter for the Client (Connection doesn't really matter due to it being an internal type).

Stjepan thinks it's better to inject the stream to the crate and have separate crates for tokio and async-std.

Thank you @esheppa for implementing this!


Log search, hoping for highlighting

Through the quickwit grafana plugin, we use it for log search and hope to highlight text that matches the search content

Hi @yangshike
That's an interesting and wanted feature. I don't know yet when we can plan this.


Geoportal Server Catalog Map Window under filter not showing or working

I'm using 2.5.2 Geoportal code with some UI modification

couple questions:

are you seeing errors in the browser console?
it looks like the map itself is not showing. What do you use as the map service for the spatial search facet?

I'm seeing CORS origin error
I didn't modify anything in the spatial search facet.

FYR

Also

hmmm. can you test this?
in /geoportal/app/context/app-config.js look for the searchMap element and then within that change what is there to:
_basemap: "streets",
basemapUrl: "https://services.arcgisonline.com/arcgis/rest/services/World_Street_Map/MapServer",

this changes the reference to the basemap used in the map facet from a named basemap to an actual map service link. You will also see the link referencing https, not http.

After modifying the map facet in /geoportal/app/context/app-config.js the map window is working now.
Thank you Marten.


no-multiple-resolved wrongly reports reject in try/catch block

From #382, which I think wasn't fully fixed
try {
    resolve(someThrowingFn())
} catch (error) {
    reject(error)
}

still errors for me. It doesn't error if I do this:
try {
    const data = someThrowingFn()
    resolve(data)
} catch (error) {
    reject(error)
}

But those two are identical and should behave same way?

This issue has apparently already been resolved as I am not able to replicate. Closing though feel free to comment further as needed.


How can I hide Recently played?

How can I hide the Recently played button? It doesn't do anything on my setup and I don't see it in the documentation. Thank you!
KSS 3.3.0 on HA 2022.9.2

Hi,
There was no option and to be honest, I forgot this part when reviewing the layout of the card. Now fixed with version 3.4.0. Can you confirm it works as expected?

It works, the layout is a bit weird but fine and working, thanks!

Hi,
I know the layout isn't really good. I wanted to solve it quick but I'm not proud of the design :-)
If you have an idea for a better one, don't hesitate!

I think the previous one with three rows (1 search field, 2 search and clear, 3 recently added) was fine :)

The thing is that I have 2 other controls: recently played and the action mode. And grouping the 'recent' controls make sense when you display everything.

Hi, just published a 3.4.2 beta with a better layout. You can try it.


"Support" was mispelled as "Suppprt"

@CheesecakeCG : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thank you for your contribution, @CheesecakeCG !!!


Fixes initialization of AVM1 data/frames for buttons.

(Possible regression after #2261)
Fixes animation in SWF 386, 395, 478

/botio test

Review status: :shipit: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

src/flash/display/MovieClip.ts @ r1

Comments from the review on Reviewable.io


Extension make Intelisense Slow

Hello,
if i Have Installed this Extension Intelisense is very slow.
In the Extecute Extension window is then Comment
Unresponsive

.

Hello @jnissen,
we're currently working on the new AL XML Documentation extension, version 2.0, which will be based on a new core. The new core currently looks much faster in our projects so we hope to solve this issue with the update as well.
Could u pls give me some additional infos? When does the unresponsive appear? While initialization or while editing? We recognized some unresponsive while editing large files (like "Sales-Post" Codeunit)
Thanks!
/chris

Hello,
Installation works fine.
If the Extension ist installed All Intelisense Help are slow.....
If I press Strg+Space it´s appears "Loading" but nothing happens.... Also in Small Codeunits...
If it helps, I can test your Extension ....

Thanks for your update! Sure, I'll let this issue stay open, until it's fixed and will get back to you as soon as our new extension version is ready for testing.

@sirhc101 ,
1st of all, ty for the utility provided by the extension.
I was wondering though, is this optimization still work in progress? Having the extension enabled is eating all my resources. Had to disable the extension to even be able to work properly. (No IntelliSense at all, delayed compilation of written code, ...)

@ZepposBE Yes, it's still a work in progress, but right now I have only little time to work on it.

I think there is a general design fail to use to much regex on the whole source file. I think performance would be much better, when reading file line by line and creating the structures while reading the file.
I just used an awk - script to generate an AL- source file of 6 MB size it takes about one second to process, because it is reading the source line by line and creates internal structures, and at the end it writes the whole AL in one run.
If AL- XMLdocumentation is enabled, it crashes the AL- Extensionhost on every start.

Sorry, currently I do not find the time to work on the new version! 🙁 I hope that I will find time over Christmas and New Year to finish the new version. Then all open issues, including the performance issue will be fixed.


Resolution date and time not adjusting for market creators timezone when MC is ahead of New York time

Prevents MC from being able to create the market due to the error message
Issues so far are with Finance and sports templates

On the screenshot below the conversion to UTC time should be 9pm, not 10pm

Works now. closing

all looks correct


No changelog for 0.2

The changelog was not updated for 0.2 (changes are still under unreleased).

@sfackler :+1:


[BUG] Decimal separator issue

Hi,
If I use the fr_CH or fr_FR locale (with , as decimal separator), I can't add a new gas entry.
It's saved as a "0" value.
If I switch to en_US (with . as separator), it works
Yeah localization is a mess :-(

which field? using fr_FR I'm able to enter decimals with "," as separator

Version?

European locale is supported by the app as long as it's configured correctly. Will be closing this issue since it's not a bug.


Fixes #32 by only aggregating category_averages if there are any for …

…the given review

verified by unittest
consider django 1.10 in tox
make tox pass

@nschlemm Thanks!

You're welcome and thanks for the new release!


Need .Msixbundle in Releases

If the .Msixbundle is given in every Releases, I can add it in microsoft/winget-pkgs

I will update releases with the msixbundle shortly after they go live on the Microsoft Store.

I will update releases with the msixbundle shortly after they go live on the Microsoft Store.

ok thank you

@Reset12138 The msix for v0.9.0 is now uploaded for the v0.9.0 release.

got it. Thanks for your reminding.
-------- 原始信息 --------
发件人： Yair Aichenbaum<EMAIL_ADDRESS>日期: 2020/5/27 02:34 (GMT+08:00)
收件人： files-community/files-uwp<EMAIL_ADDRESS>抄送： 谭源<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>主题： Re: [files-community/files-uwp] Need .Msixbundle in Releases (#847)
@Reset12138https://github.com/Reset12138 The msix for v0.9.0 is now uploaded for the v0.9.0 release.
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/files-community/files-uwp/issues/847#issuecomment-634201691, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJUQWTZVEG7ORUTBULBCPHLRTQDSPANCNFSM4NJ7B26A.


Batched  Broyden

NNlib dependency is needed to handle the batched matrix multiply properly. Also needs https://github.com/SciML/DiffEqBase.jl/pull/875

I made it into an extension but I am not sure why the extension is not loading even if I do using NNlib (on julia 1.9 beta4)

LBroyden doesn't need any other dependency. Will add it in a different PR


fmt: get wrong data when using "%.30f" in fmt.Sprintf

What version of Go are you using (go version)?

$ go version

go playground.  and. go version go1.16.6 darwin/amd64
Does this issue reproduce with the latest release?
unknown,  reproduce in go playground and  go version go1.16.6 darwin/amd64
What operating system and processor architecture are you using (go env)?
go env Output
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/xxx/Library/Caches/go-build"
GOENV="/Users/xxx/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/xxx/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/xxx/go"
GOPRIVATE=""
GOPROXY="https://goproxy.io,direct,https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.16.6/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.16.6/libexec/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.6"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/v8/lqjftghd06x4bdc946hl2gsc0000gn/T/go-build4061609802=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?

fmt.Println(fmt.Sprintf("%.30f", 5.400000*float64(0.400000)))
https://play.golang.org/p/o4ARzVQfsw_0
What did you expect to see?
get.  2.160000000000000000000000000000
What did you see instead?
get  2.160000000000000142108547152020

Floating points are limited in accuracy and cannot represent all numbers


Include support for JSON Schema in YAML format

JSON is already unnecessarily verbose, and JSON Schema definitions don't make it any better. I would like to see support for JSON Schema validation against definitions in YAML format instead of JSON, so we can forget about the format entirely.

oops wrong repo


Update docs or fix node n flag

Describe the bug
Flag option -n or --n is unknown flag, but all docs is using it instead of node flag.
In gateway, kubernetes, zdb and others.

Screenshots
On development_1.0.0_release

Verified Devnet,
Docs were updated and count replaced n, It works fine now.

And n flag was fixed on other deployment.


@padding not autocompleting for the new (buf)*feature objects

probably due to not being in their documentation

actually, the padding is not there at all - but it shows in the 'curves' - we need to think about that (although I am comfortable with no padding for the slicers)

Yes, this was an explicit decision we all made when we added padding to the descriptors objects.

I don't remember that decision but I am happy the parameter is there, and we should add a short entry in the documentation so it shows there too.

Apparently in a sync meeting 30 March 2021, looking back over the PR in Bitbucket that introduced @padding

ok - so I think we are saying the same thing:

I remember padding is not there in slicers and this is the right decision
I remember we thought of padding being important for all descriptor

re-reading trying to understand our 'disagreement' I think that my title is wrong. it is autocomplete for the new *features that is not there. I've edited the title - sorry for the confusion

Ok, then this should transfer to flucoma-docs


Fix Issue 15615: Creating a Variant with a const primitive type doesn't compile

ping @apz28 . What is the state of this PR?


Issue 178 - Renaming widgets

I changed all the names in the interface to what was asked. @aPeter1 do you think we should go and change variable names to reflect those changes, or is it ok as is?

Looks good to me!


Cherry-pick llvm/llvm-project@58839f2e2913

Fixes https://github.com/openxla/iree/issues/13478, which is a compilation correctness issue.

Thanks for the quick reviews, @stellaraccident! :D