DNS challenge support

To enable wildcard support and get around some other issues I've been having with a specific case, DNS challenge support has been added. It does not introduce any breaking changes, and action must be taken to enable it. Included is a reference implementation using AWS Route 53 in the new project FluffySpoon.AspNet.LetsEncrypt.Aws.
The Azure persistence strategy has been updated to support wildcard certificates when deciding which domains/sites to bind to.

Wow thank you so much for this! You're on a coding-spree!
I'll take a look at this once you and I have resolved #12.

Wow thank you so much for this! You're on a coding-spree!
I'll take a look at this once you and I have resolved #12.

There are a number of changes I want to make based on your feedback on #12.

Alright, #12 was merged. There are now some conflicts here as well, and you said something about additional changes being wanted?
Awaiting your reply. Thank you once again 🙇

Excellent. I've made the changes I wanted to following your feedback on #12, and resolved the conflict above. Ready for your review.

@ffMathy Tests with Route 53 have started failing, I need to figure out why. Please hold off merging for now.

@ffMathy Tests with Route 53 have started failing, I need to figure out why. Please hold off merging for now.

It looks like something's gone a bit wrong with merging, possibly related to having made a bit of a mess of my fork, so some changes I made have reverted. I'll have to work on repairing it tomorrow.

I've located the missing commit. It's now passing tests again.

I've responded/resolved as appropriate. Hopefully we're not too far off now!

I'm a bit busy these days, and headed to a conference until next week. I haven't forgotten this PR though, and will get back!

Have fun! There's another PR in the works, once I've replaced my fork, to fix a problem with the existing Azure implementation around binding of certificate to domains (they don't get bound if a certificate exists). I'll continue testing in the meantime.

In commit 61ee54a I've looked into what it would take to remove the differentiation of DNS challenge persistence, separating out the responsibility for persisting challenges from persisting certificates. This is purely an experiment, and introduces breaking changes for anyone using Entity Framework persistence or any completely custom implementations. Quite happy to revert it either permanently, or for a future PR.

Oh, and there's a conflict too.

Very impressive work, and once again thanks!
Perhaps I should add you as an official co-contributor. All I ask is that we can still tag each other as reviewers once in a while.

Very impressive work, and once again thanks!
Perhaps I should add you as an official co-contributor. All I ask is that we can still tag each other as reviewers once in a while.

You're quite welcome. By making this library available you saved me quite a bit of time over rolling my own and saved my employer and our customers a fair bit of money by effectively making Lets Encrypt available on Azure (which doesn't have the free certificates that AWS does). I'm happy to be a co-contributor.

Not anymore it would seem:
https://azure.microsoft.com/en-us/updates/secure-your-custom-domains-at-no-cost-with-app-service-managed-certificates-preview/
But I still like your contributions either way.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 10:39:29 on 2023.06.09
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 4, errors out: 0
Original problem ID: 28469
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=28469

Problem has been resolved in 9m 0s at 10:48:29 on 2023.06.09
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 28469


Cleaner imports in Bot.java

Just a quick PR

This is intentionally done because wildcard imports are bad practice.

Can you elaborate on that? Do wildcards possibly cause issues, or is to just code style?

@Artuto


Update scala-library to 2.12.18

About this PR
📦 Updates org.scala-lang:scala-library from 2.12.14 to 2.12.18
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #297.


ClientLanguageResources bug fix

Added the fix for the client language resources being empty in the browser.

Adina is testing at the moment.

ja/client-language-resources works! This fixes #31
:shipit:

Note that there is overlap with the work done in this PR and issue #48. Should remove the Localization logic out of Startup.cs, create a simple class that holds the BuildClientResources function, even though it is currently a skeleton method that returns a fixed string.

I've done some refactoring, this should be ready to merge now :shipit:


Sync performance improvements

PR description
This PR is a different implementation of this old one https://github.com/hyperledger/besu/pull/5679. It has exactly the same goal, i.e avoid validating twice transactionsRoot and receiptsRoot during sync.
CPU profiling
Before this PR

With this PR

Fixed Issue(s)
https://github.com/hyperledger/besu/issues/7581
Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[x] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[x] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

The same improvement was implemented in this PR https://github.com/hyperledger/besu/pull/7646


Remove internal logs from user

Please describe the bug
Users are shown log information that is unrelated to the simulations
Please describe how to reproduce the bug
Steps to reproduce the behavior:

Go to the runBiosimulations application and start a job
When complete, view the error log
Error log will contains text such as the following

--2020-12-13 18:45:30--  https://dispatch.biosimulations.dev/run/5fd6a799f802dc34cdf6e7c9/download
Resolving dispatch.biosimulations.dev (dispatch.biosimulations.dev)... <IP_ADDRESS>
Connecting to dispatch.biosimulations.dev (dispatch.biosimulations.dev)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 18735 (18K) [application/octet-stream]
Saving to: '/home/FCAM/crbmapi/nfs/biosimulations/simulations/5fd6a799f802dc34cdf6e7c9/in/BIOMD0000000297.edited-ssa.omex'

     0K .......... ........                                   100%  570K=0.03s

2020-12-13 18:45:30 (570 KB/s) - '/home/FCAM/crbmapi/nfs/biosimulations/simulations/5fd6a799f802dc34cdf6e7c9/in/BIOMD0000000297.edited-ssa.omex' saved [18735/18735]

How should BioSimulations have behaved
This information should not be displayed as it is implementation information rather than simulation information.

@gmarupilla Could you please work this? Create a PR specific to this issue.
Here is the approach.

Edit the sbatch template to write some sort of separator to the log such as "-----END-BIOSIMULATORS-INTERNAL-LOG------"
after it calls all the setup steps (module loading, downloading file) etc. but before it calls the singularity image.

Edit the method that implements the /logs endpoint to only return the lines in the log after the separator when reading the log file.

The only changes made should be to the sbatch.service.ts file in the dispatch-service and the app.controller.ts file in the dispatch-api

Here's another approach:
We're only getting these unrelated logs while downloading the omex. What if we replace wget <OMEX URL> with wget <OMEX URL> 1>/dev/null 2>&1 ?
I think this should solve our problem?

I originally thought this was the easier approach. Only problem, this would
prevent us from being able to view the logs internally to debug issues.
Currently, there are a few jobs missing omex files, and the logs are needed
to determine if the download worked or not.
On Mon, Dec 14, 2020 at 11:49 PM GMarupilla<EMAIL_ADDRESS>wrote:

Here's another approach:
We're only getting these unrelated logs while downloading the omex. What
if we replace wget  with wget  1>/dev/null 2>&1 ?
I think this should solve our problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/biosimulations/Biosimulations/issues/1723#issuecomment-745050221,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHX4FIHRZOBFSM3VWMWDR3TSU3TGFANCNFSM4UZ47BVQ
.

This doesn't seem like a critical issue to address. I think the modern approach (e.g., GitHub actions, Read the Docs, Circle CI) is for users to get complete logs that encompass logs related to the application itself. Following this has the added advantage of not requiring any work.

To clarify, I don't think this is a bug. In fact, it could be considered a feature. The current logs are a feature in that they show exactly what runBioSimulations did. One could argue this is good for reproducibility.
Building on this, perhaps we should display to users exactly the commands we used to run the simulation. This is inspired by GitHub actions, CircleCI, etc. which display the exact steps they executed. E.g.,
docker pull {image}:{tag}
docker run ...
``

This makes sense. We would need to have some change to the display at
least, as currently even successful downloads appear as red errors. That
was the what initially caught my eye as a potentially confusing message for
the end user
On Mon, Dec 14, 2020 at 11:58 PM Jonathan Karr<EMAIL_ADDRESS>wrote:

To clarify, I don't think this is a bug. In fact, it could be considered a
feature. The current logs are a feature in that they show exactly what
runBioSimulations did. One could argue this is good for reproducibility.
Building on this, perhaps we should display to users exactly the commands
we used to run the simulation. This is inspired by GitHub actions,
CircleCI, etc. which display the exact steps they executed. E.g.,
docker pull {image}:{tag}
docker run ...
``
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/biosimulations/Biosimulations/issues/1723#issuecomment-745052854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHX4FIAKWQHGAR7YEBHG5YLSU3UITANCNFSM4UZ47BVQ
.

I agree with that. This is similar to what I had in mind with #1626.
For now, we could change the color of the error output to reduce the emphasis on stderr that aren't problematic errors.
Another thing that could be done is to store logs separately for each step similar to what GitHub actions does. This would help users make sense of where errors are coming from.

I think this will be addressed by #1733 and #1851.

I think this will be addressed by #1733 and #1851.


Related movies in "user view"

Hi, first of all, such a great work !!!! Really ;P
I have some ideas so i'll open one issue by idea.
First one ;P
Is it possible to add related movies (which are available with movie attached on the server) when you open a detail movie screen ?

Glad you like Streama! And thanks for making one post per feature, that's really helpful.
Related movies on the detail screen should be possible.


Bump the nose multiprocess timeout

For the first time I've seen some nose.plugins.multiprocess.TimedOutException being raised on travis-ci ... so I've bumped up the --process-timeout
We might have been on the edge with the current timeout of 250 seconds and introducing the thread-safe plotting may be pushing it just over the edge (plus also given the variable load on travis-ci)

obsoleted by #2207


:bug: Use informer in KCP space provider

Summary
This PR will change KCP space provider to use LogicalCluster informer instead of watch API call which is unstable.
Related issue(s)
Fixes #
https://github.com/kubestellar/kubestellar/issues/964

/lgtm

/approve


ApiModelProperty defaults, custom metadata and more

Hi!
Our team has been integrating with swagger using springfox for a while and we find it a really useful tool, especially the plugin compartment is making our lives good and allows us to do some crazy stuff reasonably easily :D
Unfortunately there are a couple of bits and bobs that are not supported by the current version of springfox, some of which are:

It's not possible to set a default value for an ApiModelProperty (actually several fields are taken out compared to the swagger 2 specs)
It would be nice to be able to add custom metadata to parameter objects

We are fiddling with the idea of forking the project and implementing these features ourselves, but we also wonder if it would be possible for you to implement these requirements if sponsored by us.
We have sponsored/paid a couple of open source projects to add features which would ideally go back to the main trunk of the project. We are not interested in IP ownership or having our logo on your page or any junk like that. We would just like the feature added :)
Let me know if this is something you would be interested in doing?
If possible please contact me at lukasz[at]billforward[dot]net.

It's not possible to set a default value for an ApiModelProperty (actually several fields are taken out compared to the swagger 2 specs)

Its not taken out as much as its not been asked for since its evolution from swagger 1.2 So if you do find something that is missing, would love to create issues for it.

It would be nice to be able to add custom metadata to parameter objects

I believe parameters now support vendor extensions to allow customization.
I don't believe making both of your observations involves considerable effort. I'd be happy to incorporate them and better still would love PRs for them.

We are fiddling with the idea of forking the project and implementing these features ourselves, but we also wonder if it would be possible for you to implement these requirements if sponsored by us.

The answer is it depends. I've only done one such work for supporting springfox in grails framework. I did take it up because I think it was in line with the direction of the library, and it worked out pretty well. However, I grossly underestimated the effort :) Im certainly open to it. I'll DM you on gitter.


[Test] Sox windows

The code should work if there is libsox dll, but it seems only static libraries are available for libsox. closing


MinSize MaxSize dont work on vertical direction

Hi,
I am trying to set a minSize for a vertical direction split area, but it does not.
does it work at all for vertical mode?
Refer to the following example:
https://stackblitz.com/edit/angular-dhzydt
<as-split direction="vertical" unit="percent"> 		<as-split-area size="25" minSize="20">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tiam, quis nostrud exercitation 				ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in 				voluptate velit esse cillum dolore eu fugiat nulla pariatur.
 		</as-split-area> 		<as-split-area size="75" minSize="20">
Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam 				rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt 				explicabo.
 		</as-split-area> 	</as-split>

Your code uses version 2 but minSize and maxSize are introduced in version 3.
it seems that it works as expected in version 3. https://stackblitz.com/edit/angular-zvqrzg

ohhhh my bad. Thanks!


Sheets having unexpected behaviour on Android

Describe the bug
Sheets component will either not show/load when prompted (whenmodal set to true) or when set to false the sheet will show but prompting to close will then still show the sheet.
To Reproduce
Clone the starters-next-expo-solito example, run yarn native and run on a physical android device.
Press the up chevron button and nothing will happen.
Change the modal prop to false and press again, this should then show the sheet but then pressing the close button will then not close the sheet.
System Info (please complete the following information):
Android Device:
Xiaomi Poco F3, Running on Android 12.
System:
    OS: macOS 12.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 1.54 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 3.2.3 - ~/.nvm/versions/node/v16.15.1/bin/yarn
    npm: 8.13.2 - ~/.nvm/versions/node/v16.15.1/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 105.0.5195.125
    Safari: 15.2
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.18.9
    @manypkg/cli: ^0.19.1 => 0.19.1
    @types/react: ^18.0.15 => 17.0.21
    @types/react-native: ^0.69.5 => 0.69.5
    eslint: ^8.21.0 => 8.21.0
    prettier: ^2.7.1 => 2.7.1
    turbo: ^1.4.2 => 1.4.2
    typescript: ^4.7.4 => 4.7.4

Fixed in latest release :)


[ENH] Deprecate bin_numeric params and allow kwargs

PR Description
This PR pertains to the bin_numeric function.

Deprecate num_bins in favour of bins parameter.
Remove labels parameter, and open **kwargs to the end user. As a result, we defer the len(labels) == num_bins check to pandas, don't do this check within pyjanitor.
Add an additional test case to ensure retbins is not included in kwargs. Raise error if it is passed in. (Because retbins changes the output signature of pd.cut; we have to ensure only the pandas dataframe is returned.

This PR resolves #969 .
PR Checklist

Please ensure that you have done the following:

[X] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[X] If you're not on the contributors list, add yourself to AUTHORS.rst.

[X] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

@samukweku, @nvamsikrishna05, or @loganthomas, whenever either of you have a moment, please feel free to do the honors here! :tada:


Implement Database model

Codecov Report

Merging #80 (5f97547) into master (f2d4de0) will decrease coverage by 1.11%.
The diff coverage is 48.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
- Coverage     76.84%   75.74%   -1.11%
- Complexity      491      504      +13
============================================
  Files            78       79       +1
  Lines          1490     1550      +60
  Branches        152      156       +4
============================================
+ Hits           1145     1174      +29
- Misses          309      340      +31
  Partials         36       36

Files
Coverage Δ

src/main/java/seedu/address/model/Database.java
48.33% <48.33%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Question] Why not use React Native?

Hi,
I see this repo today and have some questions.
Why not using React Native?
I think with react native more people can contribute and we have a single code base between Android and iOS.

For example mattermost deprecate native version and start new react native version here: https://github.com/mattermost/mattermost-mobile

If we switch to react native we can also use awesome tools like this:
https://github.com/FaridSafi/react-native-gifted-chat

@cyclops24 Thanks for your question. That's actually a question everybody does when starting a new app. We do think that there's more contributors in the world that knows Java/Android than React Native right now. That's the main reason we choose using the native language instead of the using a 3rd part one.
Also, we do believe that developing native applications by using its native language are better in terms of receiving new features quickly, bug fixes, features in the development environment, etc.
That's our opinion right now, we are not "fixed" to it, so maybe in the future we want to change, or use both at the same time, like some big apps are doing today.
This answer is also true for our iOS native app, that's currently being developed in Swift, here: https://github.com/RocketChat/Rocket.Chat.iOS.
Thanks for asking!


Added text based item scope

Fixes #357
Fixes #566
Fixes #418
Fixes #441
Fixes #294
If we replace the language based implementation with the text based one like we did for string we can close a lot of language specific issues with item
Checklist

[x] I have added tests

Performed git surgery.  Original branch at https://github.com/cursorless-dev/cursorless/tree/bak/textTheBasedItemScope; feel free to delete if this branch looks ok

@pokey The tests are now clearing locally

plan:

[ ] Remove "item" scope type from tree-sitter defs for languages that have comma-separated items
[ ] Leave "arg" as is in those languages
[ ] Duplicate "arg" tests for those languages with plaintext as lang and "item" as scope
[ ] Leave languages alone that don't have comma-separated lists

@pokey All languages that can are now relying on the text based implementation and I have added a bunch of new tests

[ ] File issue for trailing comma with "chuck all arg", esp Python

Support "item" within strings

I have now added python specific implementation for item in import list

@pokey Your latest change requests are now implemented


fix(runner): suite options do not propagate to nested suites (fix: #3467)

fix #3467

To be said, this is my first time contributing here, so after I run pnpm install, seems like pnpm-lock.yaml got updated for some reason.
Besides, two dts files are auto-generated during dev process.
Should I commit those changes as well or they should be ignored at all?

@sheremet-va Thanks for reviewing and sorry to bother you as I know you are busy, but can you please just briefly confirming with me whether I should ignore those auto-generated files and Lockfile change (really a lot of content changed in lockfile for no reason), so I know what to do next time. Appreciate it❤


Tezos faucet not working

I've tried to fund the token to my wallet address multiple times but I don't receive any TEZ tokens. Multiple people are facing the same issue. Please help regarding this.

Can you provide more detail please? are you using the browser method and which test network please?
We've tried all four test networks and received funds.

Yes. I'm using the site: https://faucet.ghostnet.teztnets.com/ and ghostnet testnet network. When I try to fund the tokens to my Temple wallet, I don't receive any tokens even after some time.

I had a similar problem with Temple over the weekend. It cannot read balances from rpc.ghostnet.teztnets.com. It can read balances from rpc.ghostnet.tzboot.net but doesn't seem to be able to transact. I've asked the Temple team to look at this - the last update I had was there was a potential bug.
I would suggest that you go to tzstats.com, switch to ghost net and check your wallet address there. If the balance is still not what you expect on the block explorer, please ping me back here. I will need your public key hash (do not share your secret key).

The explorer shows me the expected balance. This is the Temple wallet issue. Thank you so much for helping me with this!


handle event container created in audit service

Handle the event ContainerCreated in the audit service.

Just one remark: Should we rename Container to Folder or is there a difference?

Good question. I guess it would be clearer to read Folder created


Allows Atom to manage font-size.

Does not automatically set editor font to 12px, and instead allows for Atom to dictate font size.
Before:

After:

Does this fix the Font size changing problem? If the syntax theme is in molokai-slate I can't change the font size, it simply won't effect. I was using shortcut keys to size up or down.

@the-c0d3r It does indeed. Glad it helped.

I cannot to change font size by the Atom config.
@synchronizing Thank you for your pull request. I have fixed this problem by remove such lines in order to allow Atom to manage font size.

@mildronize Not an issue. Hopefully @hamxiaoz see this and merges the fix.

thans @synchronizing
Sorry it was kind of late :(


Remove return from the loop

Remove a return from the loop. As we may need to bind cell on next iteration

Also in CollectionViewSectionDiff. 🤦♂


Update Email.php

prevents error of not initializing the variable $message, when we do not send attachments.

Im closing this PR since the previously merged PR https://github.com/snipworks/php-smtp/pull/16 should have fixed this as well.


phpmyadmin/sql-parser dependency has a 'viral license'

Larastan Version: v2.2.0
--level used: N/A
Pull request with failing test: N/A

Description
Larastan uses phpmyadmin/sql-parser in PhpMyAdminDataTypeToPhpTypeConverter through the SquashedMigrationHelper, which is used in the ModelPropertyExtension. This package has a so called Viral license (GPL-2.0-or-later). Because of the 'viral' aspect of this, AFAIK this means that we are actually unable to use Larastan in a closed source project.
Would it be possible to 'easily' remove this dependency and would you be willing to do so?
I would really like to contribute if this is necessary. Could you point me to what's need to be changed?

I just came across this license dependency as well. I think that, because of the phpmyadmin/sql-parser dependency, larastan as a library is actually not allowed to be licensed under MIT.
Still, as long as you use larastan as a development dependency only, it should be fine to use it in a commercial/closed-source project I believe. This, as the application itself is then not actually linked against the library and the library is not used at runtime.
I'm not an expert on this subject at all though so please do correct me if I'm wrong!

Feel free to try this instead: https://github.com/SQLFTW/sqlftw

Oh, I did not know our library was used here. Nothing we can do @ibennetch ?

@williamdes and @ibennetch cool to see this got your attention. I hope you can offer a solution at the license level, which would avoid changing this codebase.

I've forked larastan and replaced phpmyadmin/sql-parser with iamcal/sql-parser. All tests pass and I've tested the changes against our repository, but I don't consider that a large enough data set. I'd really like others to try these temporary fix.
https://github.com/alu-/larastan/tree/eliminate-viral-licenses
To try this yourself you can modify composer.json to include:
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/alu-/larastan"
    }
],
"require-dev": {
    "nunomaduro/larastan": "dev-eliminate-viral-licenses",
}

@williamdes and @ibennetch cool to see this got your attention. I hope you can offer a solution at the license level, which would avoid changing this codebase.

Why was this even added? With all due respect (and I respect people working on this great package a lot), adding a new dependency without understanding its license seems like a mistake. Expecting it to change feels a bit too optimistic.
Looks like someone already forked to fix this on their own. Any chance we can pull those changes into the main branch?
For now I'm reverting to the deprecated package.

It's been almost 2 years since this has been reported. I get that changing the phpmyadmin/sql-parser license would take a long time. But why hasn't Larastan taken any effort to resolve this in a different way?
AFAIK quite a few repositories are violating licenses because of it, as they would need to use the same license

Larastan itself (as it's MIT licensed)
https://github.com/nunomaduro/collision/blob/v8.x/LICENSE.md
https://github.com/laravel/pint/blob/main/LICENSE.md
1200 packages on packagist, of which a lot use a MIT license https://packagist.org/packages/larastan/larastan/dependents?order_by=downloads

And yes, larastan in a closed source application would mean the source needs to be disclosed.

Update from our side, LGPL/GPL dual licensing seems to be a path.
Awaiting news on Conservancy, I am sending them a ping email today.
Ref: https://github.com/phpmyadmin/sql-parser/issues/395#issuecomment-1479279462

And yes, larastan in a closed source application would mean the source needs to be disclosed.

This is not true. The majority of (if not all) the projects using Larastan are using it as a dev dependency for static/code analysis. This means that Larastan and its dependencies (including the GPL sql-parser package in question) are not included in the production build or distributed as part of the production application thereby not invoking the viral aspect of the GPL's copyleft provisions.


drivers: ipm: Add support for NXP i.MX rev2 MU

With a number of the i.MX SoCs (e.g., the i.MX8M Plus), NXP has moved to supporting the
integrated Cortex-M cores with the MCUXpresso SDK (MCUX). As a result, certain Zephyr
drivers (such as the IPM driver) need to be updated to utlize this new MCUX-based SDK.
This change adds support for the MCUX Messaging Unit driver pulled in by this PR:
https://github.com/zephyrproject-rtos/hal_nxp/pull/130
Additionally, this change enables the new IPM_IMX_REV2 config for the mimx8ml8_m7 SoC
target which utilizes this new revision of the driver.
Signed-off-by: Chris Trowbridge<EMAIL_ADDRESS>

This change adds support for the MCUX Messaging Unit driver pulled in by this PR:
zephyrproject-rtos/hal_nxp#130

Did the manifest (west.yml) get updated to point to the new SHA in hal_nxp?

@carlescufi: yes - The revision for hal_nxp in west.yml was updated to 9629f15fd80169cc9669e3fbb1260467c3aeb175 in PR https://github.com/zephyrproject-rtos/zephyr/pull/42270, and taking a look at mcux/hal_nxp.cmake at that revision, you can see that the support for this new config (CONFIG_IPM_IMX_REV2) is present:
...
include_driver_ifdef(CONFIG_ADC_MCUX_ADC12		adc12		driver_adc12)
include_driver_ifdef(CONFIG_ADC_MCUX_ADC16		adc16		driver_adc16)
include_driver_ifdef(CONFIG_IPM_IMX_REV2		mu		driver_mu)
include_driver_ifdef(CONFIG_CAN_MCUX_FLEXCAN		flexcan		driver_flexcan)
include_driver_ifdef(CONFIG_COUNTER_MCUX_PIT		pit		driver_pit)
...

@trowbridgec-laird  these pending changes were the ones I was looking for the past two weeks (though I have a different board).
Thank you very much for that.


az login --identity tries to connect to host <IP_ADDRESS> port 80 and fails because there is no host there.

This is autogenerated. Please review and update as needed.
I am trying to login to  https://msazure.visualstudio.com/LSG-linux/ with a PAT.
Describe the bug
v-sijeff@ovlvm102:~$  az login --identity
The command failed with an unexpected error. Here is the traceback:
HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-version=2018-02-01 (Caused by NewConn             ectionError('<urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host',))
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/urllib3/connection.py", line 160, in _new_conn
(self._dns_host, self.port), self.timeout, **extra_kw)
File "/opt/az/lib/python3.6/site-packages/urllib3/util/connection.py", line 80, in create_connection
raise err
File "/opt/az/lib/python3.6/site-packages/urllib3/util/connection.py", line 70, in create_connection
sock.connect(sa)
OSError: [Errno 113] No route to host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/urllib3/connectionpool.py", line 603, in urlopen
chunked=chunked)
File "/opt/az/lib/python3.6/site-packages/urllib3/connectionpool.py", line 355, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/opt/az/lib/python3.6/http/client.py", line 1262, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/opt/az/lib/python3.6/http/client.py", line 1308, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/opt/az/lib/python3.6/http/client.py", line 1257, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/opt/az/lib/python3.6/http/client.py", line 1036, in _send_output
self.send(msg)
File "/opt/az/lib/python3.6/http/client.py", line 974, in send
self.connect()
File "/opt/az/lib/python3.6/site-packages/urllib3/connection.py", line 183, in connect
conn = self._new_conn()
File "/opt/az/lib/python3.6/site-packages/urllib3/connection.py", line 169, in _new_conn
self, "Failed to establish a new connection: %s" % e)
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/opt/az/lib/python3.6/site-packages/urllib3/connectionpool.py", line 641, in urlopen
_stacktrace=sys.exc_info()[2])
File "/opt/az/lib/python3.6/site-packages/urllib3/util/retry.py", line 399, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-ver             sion=2018-02-01 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 215, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 654, in execute
raise ex
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 718, in _run_jobs_serially
results.append(self._run_job(expanded_arg, cmd_copy))
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 711, in _run_job
six.reraise(*sys.exc_info())
File "/opt/az/lib/python3.6/site-packages/six.py", line 703, in reraise
raise value
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 688, in _run_job
result = cmd_copy(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 325, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 776, in default_command_handler
return op(**command_args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/command_modules/profile/custom.py", line 137, in login
return profile.find_subscriptions_in_vm_with_msi(username, allow_no_subscriptions)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/_profile.py", line 345, in find_subscriptions_in_vm_with_msi
msi_creds = MSIAuthenticationWrapper(resource=resource)
File "/opt/az/lib/python3.6/site-packages/msrestazure/azure_active_directory.py", line 592, in init
self.set_token()
File "/opt/az/lib/python3.6/site-packages/msrestazure/azure_active_directory.py", line 600, in set_token
token_entry = self._vm_msi.get_token(self.resource)
File "/opt/az/lib/python3.6/site-packages/msrestazure/azure_active_directory.py", line 649, in get_token
token_entry = self._retrieve_token_from_imds_with_retry(resource)
File "/opt/az/lib/python3.6/site-packages/msrestazure/azure_active_directory.py", line 685, in _retrieve_token_from_imds_with_retry
result = requests.get(request_uri, params=payload, headers={'Metadata': 'true', 'User-Agent':self._user_agent})
File "/opt/az/lib/python3.6/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/opt/az/lib/python3.6/site-packages/requests/api.py", line 60, in request
return session.request(method=method, url=url, **kwargs)
File "/opt/az/lib/python3.6/site-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/opt/az/lib/python3.6/site-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/opt/az/lib/python3.6/site-packages/requests/adapters.py", line 516, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-             version=2018-02-01 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host',))
To open an issue, please run: 'az feedback'
v-sijeff@ovlvm102:~$
Command Name
az login
Errors:
Here is the traceback:
HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-version=2018-02-01 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host',))
Traceback (most recent call last):
python3.6/site-packages/urllib3/connection.py, ln 160, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw)
...
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=80): Max retries exceeded with url: /metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-version=2018-02-01 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f001af856d8>: Failed to establish a new connection: [Errno 113] No route to host',))

The problem, of course, is that for some reason, the az login command thinks there is a server at <IP_ADDRESS> and there isn't.
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login --identity

Expected Behavior
Environment Summary
Linux-5.3.0-51-generic-x86_64-with-debian-buster-sid
Python 3.6.10
Installer: DEB

azure-cli 2.9.1

Extensions:
azure-devops 0.18.0

Additional Context
I tried 2 different PATs, one for msazure.visualstudio.com and one for AzureCSI-SE and az login fails the same way for both of them.
I would love to know how to override the value of envar AZURE_DEVOPS_EXT_PAT from the command line.

Hi @v-sijeff , thanks for reporting, we will look at it.

Hi @v-sijeff , as I can't reproduce your problem in my environment, could you please help provide more information. What's the exact IP address of your login url in the VM ? Could you please try to check the /etc/hosts file or run tracepath <host> command to check why the url is direct to a wrong IP ?
And I'm not sure why you need to override AZURE_DEVOPS_EXT_PAT ? It seems that in cli login process, we will not use the env variable ?

Hi @v-sijeff , I will close this issue first as it seems to be an environment issue. If you still meet this or have other problems, you can reopen or submit a new one. Thanks

same shit, good job Microsoft

@Zeka13, az login --identity is for managed identity login. According to How to use managed identities for Azure resources on an Azure VM to acquire an access token, <IP_ADDRESS> is a special IP address where the managed identity endpoint is hosted.
azcopy is another command line tool, different from Azure CLI az. If you have any question regarding azcopy, please feel free to create an issue at https://github.com/Azure/azure-storage-azcopy. Our developers will gladly assist you with it.


Reporting to log [file] no longer shows time of day.

Which version are you using?
v0.9.11
Describe the problem
.Log reporting to file no longer shows time of day when connections/requests are made. Stdout still prints time, but log file doesn't. To get around this for now I am just piping stdout to file.
Has any thought be given to integrating syslog? https://golang.org/pkg/log/syslog/
Thanks.

Two features will be added:

ability to customize log format
a log destination to syslog, so all the cases should be covered

The enhancements have been moved here: https://github.com/aler9/rtsp-simple-server/issues/83
The bug will be fixed soon.

added in v0.914


Implement replace_css_class action

This PR implements the replace_css_class action.
I ended up not using the suggested replace() function from the issue, because I didn't saw a way to use it with multiple classes.
The downside of my implementation is, it could change the order of the classes.
But I think that shouldn't be a big problem, since the order of the classes shouldn't matter.
closes #52

Hey @leonvogt, thanks for this pull request!
I'm wondering if we should just limit this action to one class in the from and to.
The classList.replace() function has some nuances which are currently not respected in this implementation. While in most cases the outcome is/should be the same, the classList.replace() only replaces the class when the element has the from class. Your implementation would add the to class in any case.
There might be an opportunity in TurboPower Rails to make it easier to use and to account for multiple classes. In that case the Rails helper could just return multiple <turbo-stream action="replace_css_class"></turbo-stream> tags in the same string. Or alternatively, we could provide another replace_css_classes that more or less does what you were doing here.
Technically it would be fine to implement it like you have it here, but since we are trying to stay as close as possible to the native web APIs I think we should change the replace_css_class to just take in one class.

Hey @marcoroth, thanks for the feedback!
I think your concerns are valid. I didn't thought about the fact that the replace method only replaces the class if the element has the from class.
I've updated the PR to only replace one class at a time.


GCE metadata instanceId is an unsigned long, which Json.net v9.0.1 doesn't handle

GCE metadata instanceId is an unsigned long - see doc here.
On desktop we currently use Json.net v7.0.1, which handles this OK using a BigInteger.
On NetCore we use Json.net v9.0.1, which does not handle this, but throws a FormatException instead.
We need to upgrade to Json.net v9.0.2-beta, which does support using BigInteger on NetCore.
This dependency is buried deep down in Google.Api.Core's project.json.

Closing as obsolete - we're using a more recent version of Json.NET now (and hope to move away from it entirely in the future...)


Update DefaultJdbcPrepareStatementStrategy.java

Support Chinese

I'm from mobile so I could be wrong

We only support US ASCII characters for the name placeholder.

Sorry we cannot accept this.


Missing documented property of StyleClass on VisualElement

The styles documentation uses a styleClass property that doesn't seem to exist on any of the view objects.
I'm keen to do a PR to add it, so:

The underlying property is on VisualElement so I'm guessing we need a new entry in Xamarin.Forms.Core.Json under Xamarin.Forms.VisualElement
The underlying control is an IList<string> but the docs suggest a simple string, so should I be splitting the F# string or similar when applying to the underlying control ?
How do I run the generator ?  It doesn't seem to run as any of the fake targets, and running from the CLI or VS Mac leads to a Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'FSharp.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. error

Hi @davidglassborow
Thanks for your interest in Fabulous. :)
styleClass is indeed missing.
Based on your remarks, I've fixed a few things with the generator. (see https://github.com/fsprojects/Fabulous/pull/206 - pending merge)

No more missing FSharp.Core
FAKE target to run the generator (docs here : https://github.com/fsprojects/Fabulous/pull/206/commits/b868fe8fd0118a68ac3bee05ef26d60d66ac7f89)

The underlying property is on VisualElement so I'm guessing we need a new entry in Xamarin.Forms.Core.Json under Xamarin.Forms.VisualElement

Yes, exactly.

The underlying control is an IList but the docs suggest a simple string, so should I be splitting the F# string or similar when applying to the underlying control ?

I think splitting the string would not be the best option.
It would be better to use a list of string, but what the docs of Fabulous suggest is also a valid option (easier to write).
eg.
View.Label(text = "Hello", styleClass = "myStyle")
View.Label(text = "Hello", styleClass = [  "myStyleA"; "myStyleB" ])

You can take a look at how Margin is implemented (supports both string and Thickness)
https://github.com/fsprojects/Fabulous/blob/df42a6dfd6f5e94cab20daf0bc1ff0319cb159b8/tools/Generator/Xamarin.Forms.Core.json#L148-L152
Basically, inputType would be string list, modelType would be string[], and convToModel would be a new converter function with a pattern matching for string and string list.
For example, you will find makeThickness in ViewConverters.fs inside the Fabulous.Core project.
https://github.com/fsprojects/Fabulous/blob/df42a6dfd6f5e94cab20daf0bc1ff0319cb159b8/src/Fabulous.Core/ViewConverters.fs#L158-L162
Unfortunately based on what I saw, the Generator will create invalid code for string list.
It assumes every list should be of type ViewElement list.
So the generator need to be updated before to support that scenario.
https://github.com/fsprojects/Fabulous/blob/df42a6dfd6f5e94cab20daf0bc1ff0319cb159b8/tools/Generator/Program.fs#L434-L435

Thanks @TimLariviere that's very helpful.
I've raised PR with my initial attempt at getting this working, including an example styled label added to the about page on AllControls.
Hopefully this is good to merge, shout if you think my approach is wrong.

fixed by #209


Refactoring composition rdbms ingestion

Refactoring on rdbms_ingestion composition to improve code reusability:

Added rdbms_ingestion_to_raw_vault_phrase.
Removed rdbms specific phrases, moving the jdbc parameters to each ingestion builder method.

Improvements on rdbms ingestion examples:

Add mysql_sakila_ingestion_yamless: rdbms ingestion example without the usage of yaml files for environment and composition configuration, and table schema definition.

Updated postgresql_sakila_ingestion_daily: added descriptions to first_name and last_name fields at actor table schema, and description to name field at category table schema; add max_active_runs  to dag_parameters  at composition yaml file.

Approved after presentation and PR meeting!


TextField input isn't associated with an aria-label

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When inspecting (inspect element) the input of a TextField (I've tried in Edge (chromium) and firefox) then going to the accessibility tab, you can see that the input itself isn't associated with a label.

Expected Behavior 🤔
The input element for TextField component should have an aria-label property

Steps to Reproduce 🕹

Steps:

Create a TextField component
Using Inspect Element tool in devtools, inspect the TextField component's input element.
Under the Accessibility tab, you will see the aria attributes that associated with the element.

Context 🔦
for better accessibility and also when testing using React-Testing-Library, we are able to use the getRoleBy("textbox", {name: "Some Label"}) function.

Your Environment 🌎

`npx @material-ui/envinfo`
  System:
    OS: Windows 10 10.0.19042
  Binaries:
    Node: 15.14.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - C:\Program Files\nodejs\yarn.CMD
    npm: 7.7.6 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.423.0), Chromium (89.0.774.68)
    Firefox: Developer Edition 88
  npmPackages:
    @material-ui/core: ^4.11.3 => 4.11.3
    @material-ui/icons: ^4.11.2 => 4.11.2
    @material-ui/lab: ^4.0.0-alpha.57 => 4.0.0-alpha.57
    @material-ui/styles:  4.11.3
    @material-ui/system:  4.11.3
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react: ^17.0.3 => 17.0.3
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.2.3 => 4.2.3

Okay I guess accessibility issues is a support request for mui-org. Got it 👍

@ninoM Please follow our issue template

In case anyone else is also having trouble with this (especially with getByRole from testing library). You need to provide an id to the TextField for the label to associate itself with the input.
Here's the part of the doc that talks about accessibility: https://finance-manager-amber.vercel.app/

Rolfchen's solution didn't work for me. I solved this by setting an "aria-label" manually on inputProps (notice lower case i).
inputProps={{
  "aria-label": "Search bar",
}}

The docs


Convert from JS -> TS

Implement conversion from JS -> TS

For some reason I cannot get it to work :-(

For some reason I cannot get it to work :-(
On the action run I get the errors:
Run blackjacx/backlog-notifier@typescript-conversion
/home/runner/work/_actions/blackjacx/backlog-notifier/typescript-conversion/index.ts:1
import { Octokit } from "@octokit/rest";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1033:15)
    at Module._compile (node:internal/modules/cjs/loader:106[9](https://github.com/Blackjacx/ghtest/actions/runs/4428724214/jobs/7768219128#step:3:10):27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:[10](https://github.com/Blackjacx/ghtest/actions/runs/4428724214/jobs/7768219128#step:3:11))
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:[12](https://github.com/Blackjacx/ghtest/actions/runs/4428724214/jobs/7768219128#step:3:13))
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:[17](https://github.com/Blackjacx/ghtest/actions/runs/4428724214/jobs/7768219128#step:3:18):47

You can try this.

I close this "experiment" as it makes this action unneccessarily complex.


File not Found error

As of this morning, the robocopy task is failing with the following error. I confirmed the file is not present on disk. There's only 3 files in a 1.1.3 directory: icon.png, robocopytask.ps1, and task.json.
2020-05-05T13:30:24.6981461Z ==============================================================================
2020-05-05T13:30:24.6981800Z Task         : File System - Robocopy
2020-05-05T13:30:24.6982055Z Description  : Use Robocopy to perform a copy action.
2020-05-05T13:30:24.6982282Z Version      : 1.1.3
2020-05-05T13:30:24.6982470Z Author       : Jungerius IT
2020-05-05T13:30:24.6982720Z Help         :
2020-05-05T13:30:24.6982965Z ==============================================================================
2020-05-05T13:30:24.7226321Z ##[error]File not found: 'D:\DevOps\A1\_work\_tasks\Robocopy_7db26114-8ee0-4460-b1e6-e5fbd3a9a583\1.1.3\ps_modules\VstsTaskSdk\VstsTaskSdk.psd1'

Due to changes and automation of the build/release pipelines this issue could have come up. Just release 1.1.4 which hopefully resolves this issue. Please let me know.

Thank you for the quick response. It looks like 1.1.4 is having the same issue:
2020-05-05T13:57:54.7567430Z ==============================================================================
2020-05-05T13:57:54.7567778Z Task         : File System - Robocopy
2020-05-05T13:57:54.7568059Z Description  : Use Robocopy to perform a copy action.
2020-05-05T13:57:54.7568287Z Version      : 1.1.4
2020-05-05T13:57:54.7568478Z Author       : Jungerius IT
2020-05-05T13:57:54.7568688Z Help         :
2020-05-05T13:57:54.7568925Z ==============================================================================
2020-05-05T13:57:54.7805708Z ##[error]File not found: 'D:\DevOps\A1\_work\_tasks\Robocopy_7db26114-8ee0-4460-b1e6-e5fbd3a9a583\1.1.4\ps_modules\VstsTaskSdk\VstsTaskSdk.psd1'

Followed this comment and updated accordingly for release 1.1.5.

We had the same problem with 1.1.3 and 1.1.4, but it is resolved in 1.1.5.

It looks like 1.1.5 is working correctly. I appreciate the quick turnaround!

This change has caused our builds to fail. Is there anyway we get notified before deploying new changes to extension? or is there any option not to deploy the changes automatically against Orgs.
Please suggest

Is there an ETA for when release 1.1.5 will be made available?

When I queued a new build yesterday, 1.1.5 was used automatically.


Small fixes to comments and tests

I suggest reviewing each commit separately.

If find_parent_list_item will now return the passed child_handle as a possible result, we might want to find a name that reflects this change.


The VS is crash after clicking the Debug tab.

Environment

Steps to Reproduce

Create a new project
Click the "Debug" tab

Expected behavior
The debug drop-down list is displayed correctly.
Actual result
The VS is crash and restart automacticlly.

Error events log
Error.zip

@int19h
Without any other steps to repro, only create a project and click the "Debug" tab.
Here is the Python version I have installed.

On today's build, this issue is not repro.

Since it's the same version of PTVS, but different version of VS, it's almost certainly a VS issue that they have fixed since then. Please re-open if this comes up again.


Type import broken with TS nodenext

Describe the bug
Could not find a declaration file for module '@uploadcare/upload-client'.

I guess, it might be caused by the types being defined like this in upload-client/package.json
  "types": "./dist/types.d.ts",
  "exports": {
    ".": {
      "node": "./dist/index.node.js",
      "browser": "./dist/index.browser.js",
      "default": "./dist/index.browser.js"
    }
  }

This is not valid in TS' ESM-support mode (NodeNext). The types field is only used for legacy projects. New TS > 4.7 projects with nodenext mode expect the types to be at ./dist/index.d.ts.
In case you want to leave the types at their current location, you additionally need to add the types definition within the exports block, as described here:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
Also important:

Note that the "types" condition should always come first in "exports".

Expected behavior
TS type imports should work in TS >= 4.7 & NodeNext mode. I assume you intend to support NodeNext, as you moved the package to ESM-only anyway.
Code / screenshots

Environment

Library version: 5.1.0
Language/framework version: Node.js v16.18.0 & TS: 4.8.4

@nickluger Thank you!
Yeah, you're right, we missed types field inside exports.
I added types fields and renamed types.d.ts to index.d.ts but still left an explicitly declared types path.
See v5.1.1

Yes, seems to work!

still left an explicitly declared types path.

Yes, perfect for backwards compatibility.
Thank you for fixing it. 💙


refactor: use destructuring

Just simplify sample codes.

Coverage remained the same at 100.0% when pulling c121a404a81a050ea664a8b153545e44db7f7b75 on chafel:master into fbfecac6b92fa0545eced7f9da388e9740a2860e on halt-hammerzeit:master.

Yeah, that's shorter and clearer


Fix: modify syncWorkflowStatus

Description of your changes

🤖 Generated by Copilot at 73112e1
Summary
🐛🚫🛠

Fix a bug that could create invalid workflow CRDs by skipping empty revisions. The change affects the pkg/apiserver/domain/service/workflow.go file.

CR name is blank
Skip workflow revision now
Fixes bug in fall

Walkthrough

Skip workflow revisions with empty CR names to avoid creating invalid workflow CRDs (link)

Fixes #6244
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Would you please give more details about how to reproduce the bug?


Fix CI errors

@nesquena sorry for the multiple PRs 🥴 This one should get the CI passing.
More work would be required to resolve issues running test suite with Ruby 3.

Okay np thanks for contributing!

Argh, well the CI still needs some work. I guess the image needs updated to cimg/ruby.


pageInterval=day component onPageChange triggers always start of month

Its always rendering same time which is start of month
also onDateSelect is not triggers how to know when the date change ?
      <Calendar
        pageInterval="day"
        theme={{ todayIndicatorDotColor: 'blue', inactiveOpacity: 0.5 }}
        ref={calendarRef}
        currentDate={currentDate}
        DayComponent={DayComponent}
        selectedDate={selectedDate}
        // currently showing 1 november if you go previous page like october than it shows 1 october etc.
        onPageChange={(date)=>alert(date.toDateString())}
        monthAnimCallbackNode={monthAnimCallbackNode}
      />

tested in https://snack.expo.dev/@computerjazz/react-native-swipe-calendar

@computerjazz hey, i'm having the same problem as @batuhansahan
same thing happens on pageInterval="month", the onPageChange returns the first day of the month, however it seems like the date just changes correctly when swiped nth the amount the weeks of the given month
 LOG  change 2022-11-01T04:04:09.328Z
 LOG  change 2022-12-01T04:04:09.328Z
 LOG  change 2022-12-01T04:04:09.328Z
 LOG  change 2022-12-01T04:04:09.328Z
 LOG  change 2022-12-01T04:04:09.328Z
 LOG  change 2022-12-01T04:04:09.328Z
 LOG  change 2023-01-01T04:04:09.328Z
 LOG  change 2023-01-01T04:04:09.328Z
 LOG  change 2023-01-01T04:04:09.328Z
 LOG  change 2023-01-01T04:04:09.328Z
 LOG  change 2023-02-01T04:04:09.328Z
 LOG  change 2023-02-01T04:04:09.328Z
 LOG  change 2023-02-01T04:04:09.328Z
 LOG  change 2023-02-01T04:04:09.328Z
 LOG  change 2023-03-01T04:04:09.328Z
 LOG  change 2023-03-01T04:04:09.328Z

Fixed in 0.0.21


Move all QA-related scripts into qa subdirectory

[test]

[test]

[test]

[test]

[test]

[test]

[test]

[test]

[test]

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   79.87%   79.87%
=======================================
  Files           2        2
  Lines         154      154
=======================================
  Hits          123      123
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9fa1b...e4b25c2. Read the comment docs.

@tisnik Your image is available in the registry: docker pull MISSING_REGISTRY_NAME/MISSING_IMAGE_NAME:SNAPSHOT-PR-86


PHP 7.2 Support

Are you going to make release with mdanter/ecc v0.5.0 which support php 7.2?

I got the same issue.

Have to downgrade to php7.1.

This would be useful considering PHP 7.2 has some improved security and support of Argon2 (https://wiki.php.net/rfc/argon2_password_hash)


New look & feel of readme.md

[x] 1. Add Javlain logo
[x] 2. Snapshot badge
[x] 3. Discord online users badge (?)
[x] 4. Cleanup links
[x] 5. Gradle Kts compatible snippet
[ ] 6. Update examples, provide more up-to-date approach
[x] 7. Reference plugin ecosystem

[x] 7.1 Show some examples, like e.g. smooth integration of OpenApi, SSL, templates

[ ] 8. Link repository with sample projects (or even list some of them)

I'll close this and track it with the rest of the Javalin 6 todos in #2035


Entrega do "Product Backlog" - Dia 03/10/2024

[x] https://moodle.ufcspa.edu.br/mod/assign/view.php?id=50422

Product Backlog MSSQ-Short.pdf
Envio do Producr Backlog no dia 03/10.


Doesn't support latest hugo v0.127.0

The problem is that .Get and .Param are not officially supported methods for map variables and they are not documented in Hugo (reference). Hugo removed these methods recently, but they are widely used in this plugin, which makes all codes like $ctx.Param "image.type" broken.
Part of the error log
Watching for changes in /home/aris/projects/garywei.dev/{archetypes,assets,content,data,layouts,package.json,static,themes}
Watching for config changes in /home/aris/projects/garywei.dev/config/_default, /home/aris/projects/garywei.dev/config/production, /home/aris/projects/garywei.dev/themes/responsive-images/config/_default, /home/aris/projects/garywei.dev/go.mod
Start building sites …
hugo v0.127.0+extended linux/amd64 BuildDate=unknown

ERROR Hugo Responsive Images:
Page resource image %!s(<nil>)/images/academic_profile.jpg not found
Built in 34 ms
Error: error building site: render: failed to render pages: render of "home" failed: "/home/aris/projects/garywei.dev/layouts/index.html:5:7": execute of template failed: template: index.html:5:7: executing "main" at <partial (print "body/" . ".html") (merge $params (dict "data" $data))>: error calling partial: execute of template failed: template: partials/body/cover.html:56:13: executing "partials/body/cover.html" at <partial "img" (dict "ctx" . "src" "/images/academic_profile.jpg" "width" 300 "alt" "Test image")>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/img.html:1:3": execute of template failed: template: partials/img.html:1:3: executing "partials/img.html" at <partial "hri/img" .>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/img.html:1:3": execute of template failed: template: partials/hri/img.html:1:3: executing "partials/hri/img.html" at <partial "hri/private/image" (merge . (dict "partial" "img"))>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/image.html:31:21": execute of template failed: template: partials/hri/private/image.html:31:21: executing "partials/hri/private/image.html" at <partial "hri/private/params/image.html" $params>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/params/image.html:29:14": execute of template failed: template: partials/hri/private/params/image.html:29:14: executing "partials/hri/private/params/image.html" at <partial "hri/private/params/image-general" .>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/params/image-general.html:12:118": execute of template failed: template: partials/hri/private/params/image-general.html:12:118: executing "partials/hri/private/params/image-general.html" at <$ctx.Param>: Param is not a method but has arguments

Thanks Gary I'll get started on it.
On Wed, 26 June 2024, 5:25 am Gary Wei, @.***> wrote:

The problem is that .Get and .Param are not officially supported methods
for map variables and they are not documented in Hugo (reference
https://github.com/gohugoio/hugo/issues/10862#issuecomment-1614763108).
Hugo removed these methods recently, but they are widely used in this
plugin, which makes all codes like $ctx.Param "image.type" broken.
Part of the error log
Watching for changes in /home/aris/projects/garywei.dev/{archetypes,assets,content,data,layouts,package.json,static,themes} http://garywei.dev/{archetypes,assets,content,data,layouts,package.json,static,themes}Watching for config changes in /home/aris/projects/garywei.dev/config/_default, /home/aris/projects/garywei.dev/config/production, /home/aris/projects/garywei.dev/themes/responsive-images/config/_default, /home/aris/projects/garywei.dev/go.modStart building sites … hugo v0.127.0+extended linux/amd64 BuildDate=unknown
ERROR Hugo Responsive Images:Page resource image %!s()/images/academic_profile.jpg not foundBuilt in 34 ms
Error: error building site: render: failed to render pages: render of "home" failed: "/home/aris/projects/garywei.dev/layouts/index.html:5:7": execute of template failed: template: index.html:5:7: executing "main" at <partial (print "body/" . ".html") (merge $params (dict "data" $data))>: error calling partial: execute of template failed: template: partials/body/cover.html:56:13: executing "partials/body/cover.html" at <partial "img" (dict "ctx" . "src" "/images/academic_profile.jpg" "width" 300 "alt" "Test image")>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/img.html:1:3": execute of template failed: template: partials/img.html:1:3: executing "partials/img.html" at <partial "hri/img" .>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/img.html:1:3": execute of template failed: template: partials/hri/img.html:1:3: executing "partials/hri/img.html" at <partial "hri/private/image" (merge . (dict "partial" "img"))>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/image.html:31:21": execute of template failed: template: partials/hri/private/image.html:31:21: executing "partials/hri/private/image.html" at <partial "hri/private/params/image.html" $params>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/params/image.html:29:14": execute of template failed: template: partials/hri/private/params/image.html:29:14: executing "partials/hri/private/params/image.html" at <partial "hri/private/params/image-general" .>: error calling partial: "/home/aris/projects/garywei.dev/themes/responsive-images/layouts/partials/hri/private/params/image-general.html:12:118": execute of template failed: template: partials/hri/private/params/image-general.html:12:118: executing "partials/hri/private/params/image-general.html" at <$ctx.Param>: Param is not a method but has arguments
—
Reply to this email directly, view it on GitHub
https://github.com/future-wd/hugo-responsive-images/issues/67, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ARTWGA6ON5VCY7SIHHO6ARTZJG72FAVCNFSM6AAAAABJ4O4MACVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TGNBYGU2TAMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi @garywei944  I just ran the test site (clone the repo and there is a test site folder with a npm script to run a server) with Hugo 1.27.0 and had no error.
I couldn't see any use of .Get for params. I couldn't a reference to .Param being deprecated?
This module could do with some work on how to throw a decent error when I file is missing, or the wrong kind of file is provided.
Do you think that's the issue, or am I off track?

Hi Sean, thanks for your quick follow-up. Let me come back to the issue later today.

I figured out that the issue is the images path must include assets/ at the beginning for global resourcs. Otherwise the ctx will be set to null at some point and break everything.
Thanks again for the quick response!
However, I encountered a few other bugs that I'm not sure if it's caused by new version of go/hugo.

specify widths in the site-wise params.toml somehow convert list(slice) of int to list of string and throw the following error.

Here is the template I use
{{ partial "figure"  (dict
  "ctx" .
  "src" "assets/images/projects/astronaut/cs590g_p1_start.jpg"
  "attr_link" "http://www.author-page.com"
  "figcaption_title" "Boat x54"
  "caption" "My favourite boat"
  "link" "https://www.google.com"
  "alt" "Academic Profile"
  )
}}

and in params.toml
[image]
widths = [480, 768, 1440]

Here is the error message

I don't know why but neither the link nor attr_link is rendered?

FYI, I'm using hugo v0.127.0 with extension and go 1.22.4. Also, I personally found that debugging hugo scripts is painful because I didn't find a way to add breakpoints and debug like using gdb to debug C programs.

Thanks for your help!
On Thu, 27 June 2024, 10:57 am Gary Wei, @.***> wrote:

Closed #67 https://github.com/future-wd/hugo-responsive-images/issues/67
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/future-wd/hugo-responsive-images/issues/67#event-13305762370,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARTWGA4NDR7QVYIC4BV3HPLZJNPQ5AVCNFSM6AAAAABJ4O4MACVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGMYDKNZWGIZTOMA
.
You are receiving this because you commented.Message ID:
@.***
com>

@garywei944  if you have any breaking changes for a v2 wish list please let me know


FIX: Allow Maestro to work on Android API levels 25 and lower (Android 7.1.1 and lower)

Proposed Changes

Refactor  AndroidDriver#startInstrumentationSession so that if the Android API level is 25 or lower, we omit the -m flag from the ADB command that is run. The -m flag is only added when it is API level 26 or above.

Testing
I built and ran locally and this small change allowed the sample Wikipedia android flow to run and pass successfully on both an android device  > API 26 and another Android 7.1.1 (API 25) device I have.
Issues Fixed
This fix allows Maestro to work on Android API level lower than 26 :+1:

I tried to run this on an API 25 virtual device and the advanced flow fails on the second step with the following exception
Running on emulator-5554

 ║
 ║  > Flow
 ║
 ║    ⏳  Run subflows/onboarding-android.yaml
 ║      ✅  Launch app "org.wikipedia"
 ║      ⏳  Tap on id: org.wikipedia:id/fragment_onboarding_forward_button
 ║      🔲 Tap on id: org.wikipedia:id/fragment_onboarding_forward_button
 ║      🔲 Tap on id: org.wikipedia:id/fragment_onboarding_forward_button
 ║      🔲 Tap on id: org.wikipedia:id/fragment_onboarding_done_button
 ║    🔲 Tap on id: org.wikipedia:id/search_container
 ║    🔲 Run scripts/getSearchQuery.js
 ║    🔲 Input text ${output.result}
 ║    🔲 Assert that "${output.result}" is visible
 ║
Exception in thread "pool-4-thread-1" java.lang.Error: java.io.IOException: Command failed (tcp:7001): closed
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1155)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:750)
Caused by: java.io.IOException: Command failed (tcp:7001): closed
        at dadb.adbserver.AdbServer.send$dadb(AdbServer.kt:99)
        at dadb.adbserver.AdbServerDadb.open(AdbServer.kt:138)
        at dadb.forwarding.TcpForwarder.handleForwarding$lambda-1(TcpForwarder.kt:64)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        ... 2 more

Thanks for checking this, I admit I only tested this with the simple flow.
I will try to find some more time to dig into this.

@NyCodeGHG I've made an additional tweak.  It seems AccessibilityNodeInfo hintText is not in API 25 and lower.
I don't have my API 25 device on hand at the moment, so if you get a chance it would be great if you could test again with the advanced flow.  Many thanks.

Thanks, I did accidentally revert my previous changes.
Can I ask how you are building? In Logcat I see this exception...
2023-10-23 14:24:51.221 32687-663   AndroidRuntime          dev.mobile.maestro                   E  FATAL EXCEPTION: grpc-default-executor-0
                                                                                Process: dev.mobile.maestro, PID: 32687
                                                                                java.lang.NoSuchMethodError: No virtual method getHintText()Ljava/lang/CharSequence; in class Landroid/view/accessibility/AccessibilityNodeInfo; or its super classes (declaration of 'android.view.accessibility.AccessibilityNodeInfo' appears in /system/framework/framework.jar:classes2.dex)
                                                                                at dev.mobile.maestro.ViewHierarchy.dumpNodeRec(ViewHierarchy.kt:123)
                                                                                at dev.mobile.maestro.ViewHierarchy.dumpNodeRec$default(ViewHierarchy.kt:111)
                                                                                at dev.mobile.maestro.ViewHierarchy.dump(ViewHierarchy.kt:71)
                                                                                at dev.mobile.maestro.ViewHierarchy.dump$default(ViewHierarchy.kt:27)
                                                                                at dev.mobile.maestro.Service.viewHierarchy(MaestroDriverService.kt:167)
                                                                                at maestro_android.MaestroDriverGrpc$MethodHandlers.invoke(MaestroDriverGrpc.java:805)
                                                                                at io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
                                                                                at io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:355)
                                                                                at io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:867)
                                                                                at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
                                                                                at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
                                                                                at java.lang.Thread.run(Thread.java:761)
2023-10-23 14:24:51.224 32687-663   System.out              dev.mobile.maestro                   I  <----------------log for bug15315 killProcess() start pid = --------------->32687
2023-10-23 14:24:51.224 32687-663   Process                 dev.mobile.maestro                   E  jiangning stack
                                                                                java.lang.RuntimeException: here
                                                                                at android.os.Process.killProcess(Process.java:1167)
                                                                                at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:111)
                                                                                at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1068)
                                                                                at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1063)
2023-10-23 14:24:51.225 32687-663   System.out              dev.mobile.maestro                   I  <----------------log for bug15315 killProcess() end--------------->
2023-10-23 14:24:51.225 32687-663   Process                 dev.mobile.maestro                   I  Sending signal. PID: 32687 SIG: 9

but my change has made it use getHintOrFallback instead of node.hintText so it's like the error is not picking up the new change made in ViewHierarchy of the maestro-android module.

Can I ask how you are building?

I just used the maestro script in the project root

Sop that script does ./gradlew :maestro-cli:installDist -q && ./maestro-cli/build/install/maestro/bin/maestro "$@"
I don't think it includes my changes in ViewHierarchy.kt in the maestro-android module that can generate the MaestroAndroid and MaestroServer APKs

java.lang.NoSuchMethodError: No virtual method getHintText()Ljava/lang/CharSequence; in class Landroid/view/accessibility/AccessibilityNodeInfo; or its super classes (declaration of 'android.view.accessibility.AccessibilityNodeInfo' appears in /system/framework/framework.jar:classes2.dex)
                                                                                at dev.mobile.maestro.ViewHierarchy.dumpNodeRec(ViewHierarchy.kt:123)

line 123 with my changes does not refer to the hintText line, it refers to the one above, so the error is definitely talking about ViewHierarchy without my changes in it.  I am having a bit of a hard time running with my latest changes in ViewHierarchy included. I'm pretty sure this fixes it but struggling to verify that.

So I do not think the ./matesro script is including my changes made in ViewHierarchy.,kt
java.lang.NoSuchMethodError: No virtual method getHintText()Ljava/lang/CharSequence; in class Landroid/view/accessibility/AccessibilityNodeInfo; or its super classes (declaration of 'android.view.accessibility.AccessibilityNodeInfo' appears in /system/framework/framework.jar:classes2.dex)
                                                                                at dev.mobile.maestro.ViewHierarchy.dumpNodeRec(ViewHierarchy.kt:123)

line 123 with my changes does not refer to the hintText line, it refers to the one above, so the error is definitely talking about ViewHierarchy without my changes in it.  I am having a bit of a hard time running with my latest changes in ViewHierarchy included. I'm pretty sure this fixes it but struggling to verify that.
@axelniklasson do you know how I can build and test this locally with my changes in ViewHierarchy.kt in the maestro-android module included when I build and run please? I've had a look at possible gradle tasks to run but it still seems my ViewHierarchy changes are not being included.
There are very little / no docs on building locally. Thanks.
It looks like (and a comment is included) that ViewHierarchy in the maestro-android module is very similar to AccessibilityNodeInfoDumper, with some modifications, one of them being this node.hintText addition.  AccessibilityNodeInfoDumper is what UiAutomator2 uses, which works fine on API 25 and lower.

@artem888 can you please work with @testifyqa and help him test his changes out? Thanks!

Hi there, I have a physical device with API 25 on hand now and also have emulators set up.  My specific issue is that my changes made in ViewHierarchy do not seem to be included in any builds I do locally. Can I please get help on that?

I got it working with ./gradlew assemble assembleAndroidTest, then using the maestro script to run and it successfully ran the advanced sample flow on API Level 25 🥳 .
Also got a lot of warnings because of gradle task dependency issues, seems like this should be improved so the APKs in the resources folder actually get rebuild on changes when using the maestro script

Excellent!! Thanks so much @NyCodeGHG. I went to deep and over looked simply running ./gradlew assemble assembleAndroidTest :facepalm:
This would be really great to get merged in, not only for my team where I work, but also it will allow many more users to make use of Maestro on lower Android versions.

I've tried this also on API 24 which worked fine, but it starts to fail on 23 with this exception
Stacktrace
java.io.IOException: pm list packages --user 0 dev.mobile.maestro
	at maestro.drivers.AndroidDriver.shell(AndroidDriver.kt:917)
	at maestro.drivers.AndroidDriver.isPackageInstalled(AndroidDriver.kt:905)
	at maestro.drivers.AndroidDriver.uninstallMaestroDriverApp(AndroidDriver.kt:872)
	at maestro.drivers.AndroidDriver.installMaestroDriverApp(AndroidDriver.kt:833)
	at maestro.drivers.AndroidDriver.installMaestroApks(AndroidDriver.kt:867)
	at maestro.drivers.AndroidDriver.open(AndroidDriver.kt:75)
	at maestro.Maestro$Companion.android(Maestro.kt:595)
	at maestro.cli.session.MaestroSessionManager.createAndroid(MaestroSessionManager.kt:266)
	at maestro.cli.session.MaestroSessionManager.createMaestro(MaestroSessionManager.kt:149)
	at maestro.cli.session.MaestroSessionManager.access$createMaestro(MaestroSessionManager.kt:49)
	at maestro.cli.session.MaestroSessionManager$newSession$session$1.invoke(MaestroSessionManager.kt:82)
	at maestro.cli.session.MaestroSessionManager$newSession$session$1.invoke(MaestroSessionManager.kt:81)
	at maestro.cli.db.KeyValueStore.withExclusiveLock(KeyValueStore.kt:37)
	at maestro.cli.session.SessionStore.withExclusiveLock(SessionStore.kt:74)
	at maestro.cli.session.MaestroSessionManager.newSession(MaestroSessionManager.kt:81)
	at maestro.cli.session.MaestroSessionManager.newSession$default(MaestroSessionManager.kt:58)
	at maestro.cli.command.TestCommand.call(TestCommand.kt:136)
	at maestro.cli.command.TestCommand.call(TestCommand.kt:46)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1933)
	at picocli.CommandLine.access$1200(CommandLine.java:145)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2332)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2326)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2291)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2159)
	at maestro.cli.DisableAnsiMixin$Companion.executionStrategy(DisableAnsiMixin.kt:22)
	at picocli.CommandLine.execute(CommandLine.java:2058)
	at maestro.cli.AppKt.main(App.kt:117)
Caused by: java.io.IOException: Command failed (shell,v2,raw:pm list packages --user 0 dev.mobile.maestro): closed
	at dadb.adbserver.AdbServer.send$dadb(AdbServer.kt:99)
	at dadb.adbserver.AdbServerDadb.open(AdbServer.kt:138)
	at dadb.Dadb$DefaultImpls.openShell(Dadb.kt:43)
	at dadb.adbserver.AdbServerDadb.openShell(AdbServer.kt:118)
	at dadb.Dadb$DefaultImpls.shell(Dadb.kt:36)
	at dadb.adbserver.AdbServerDadb.shell(AdbServer.kt:118)
	at maestro.drivers.AndroidDriver.shell(AndroidDriver.kt:915)
	... 26 more

Interesting, for my work I only need it working for API level 25 as the lowest.
Can look at fixing it for API 23 as a separate PR possibly and rename the title/description of this one. I would really love to get this one merged as is to unblock us on part of my test strategy.

Great point, I'm away this weekend but when back home I can change that. If it's an easy fix for API level 23, and API 22 and 21 are the same commands as API 23 then I can see about including that in here possibly.

I've tried this also on API 24 which worked fine, but it starts to fail on 23 with this exception

This seems to be related: https://github.com/mobile-dev-inc/dadb/issues/50

This seems to be related: https://github.com/mobile-dev-inc/dadb/issues/50

Just had a look, this is indeed the issue for API 23 (Marshmallow) and below.
For this PR, I've updated the build.gradle line to represent the minSDK as 24 and above.

This would be great to add more support for older Android versions! 🏆

Any updates on getting approved and merged please? Would do wonders for my test teams.

@testifyqa Can you also generate commit the apks with ./gradlew assemble assembleAndroidTest
As of now we don't do it automatically.
After that we'll run a few tests to make sure existing flows don't break and then we can merge.

Thanks @ArthurSav will do that now

@testifyqa I'm getting the following error when trying to run ./maestro test samples/android-advanced-flow.yaml
io.grpc.StatusRuntimeException: INTERNAL: {
            this.hintText
        } must not be null
        at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:271)
        at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:252)
        at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:165)
        at maestro_android.MaestroDriverGrpc$MaestroDriverBlockingStub.viewHierarchy(MaestroDriverGrpc.java:641)
        at maestro.drivers.AndroidDriver.callViewHierarchy(AndroidDriver.kt:275)
        at maestro.drivers.AndroidDriver.callViewHierarchy(AndroidDriver.kt:289)
        at maestro.drivers.AndroidDriver.callViewHierarchy$default(AndroidDriver.kt:273)
        at maestro.drivers.AndroidDriver.contentDescriptor(AndroidDriver.kt:264)
        at maestro.ViewHierarchy$Companion.from-c1iYVAs(ViewHierarchy.kt:29)
        at maestro.Maestro.viewHierarchy-prqvCes(Maestro.kt:412)
        at maestro.Maestro$findElementWithTimeout$element$1.invoke(Maestro.kt:437)
        at maestro.Maestro$findElementWithTimeout$element$1.invoke(Maestro.kt:436)
        at maestro.utils.MaestroTimer.withTimeout(MaestroTimer.kt:16)
        at maestro.Maestro.findElementWithTimeout(Maestro.kt:436)
        at maestro.orchestra.Orchestra.findElement(Orchestra.kt:849)
        at maestro.orchestra.Orchestra.findElement$default(Orchestra.kt:831)
        at maestro.orchestra.Orchestra.tapOnElement(Orchestra.kt:752)
        at maestro.orchestra.Orchestra.executeCommand(Orchestra.kt:239)
        at maestro.orchestra.Orchestra.executeSubflowCommands(Orchestra.kt:581)
        at maestro.orchestra.Orchestra.runSubFlow(Orchestra.kt:622)
        at maestro.orchestra.Orchestra.runFlowCommand(Orchestra.kt:490)
        at maestro.orchestra.Orchestra.executeCommand(Orchestra.kt:268)
        at maestro.orchestra.Orchestra.executeCommands(Orchestra.kt:201)
        at maestro.orchestra.Orchestra.runFlow(Orchestra.kt:111)
        at maestro.orchestra.Orchestra.runFlow$default(Orchestra.kt:75)
        at maestro.cli.runner.MaestroCommandRunner.runCommands(MaestroCommandRunner.kt:185)
        at maestro.cli.runner.TestRunner$runSingle$result$1.invoke(TestRunner.kt:54)
        at maestro.cli.runner.TestRunner$runSingle$result$1.invoke(TestRunner.kt:51)
        at maestro.cli.runner.TestRunner.runCatching(TestRunner.kt:145)
        at maestro.cli.runner.TestRunner.runSingle(TestRunner.kt:51)
        at maestro.cli.command.TestCommand$call$1.invoke(TestCommand.kt:177)
        at maestro.cli.command.TestCommand$call$1.invoke(TestCommand.kt:136)
        at maestro.cli.session.MaestroSessionManager.newSession(MaestroSessionManager.kt:101)
        at maestro.cli.session.MaestroSessionManager.newSession$default(MaestroSessionManager.kt:58)
        at maestro.cli.command.TestCommand.call(TestCommand.kt:136)
        at maestro.cli.command.TestCommand.call(TestCommand.kt:46)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1933)
        at picocli.CommandLine.access$1200(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2332)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2326)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2291)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2159)
        at maestro.cli.DisableAnsiMixin$Companion.executionStrategy(DisableAnsiMixin.kt:22)
        at picocli.CommandLine.execute(CommandLine.java:2058)
        at maestro.cli.AppKt.main(App.kt:117)

@ArthurSav I can have a look a bit later, I think the PR is old and needs a rebase as I think new src files were added in to maestro-android since

@ArthurSav I rebased and reassembled the apks and ran the same command on my API 25 device and it ran successfully, can you try again please? Unable to repro locally at the minute.

Ignore that, able to repro after cleaning the project also I think, investigating

Using Emulator with API 33

Able to repro on more recent API versions locally now, investigating

@ArthurSav Fixed!! I tested on API 25, 30 and 33. The fix was to fallback to empty string if hintText is null on api level 26+ also as not everything has a hintText value.

Woohoo thanks everyone :D


Add JSON for crossfeed

Adds two JSON files for https://github.com/Code-dot-mil/crossfeed-web and https://github.com/Code-dot-mil/crossfeed-agent.

Approved without Travis build since it is only code.json additions, will monitor live deploy


Propose an automated update script

I wrote a little script to handle automatic update to latest release .. hope it could be usefull

I appreciate you writing up the script, but I'm not sure about this. If you wanted to propose the script itself for docker/compose and then it got accepted, then maybe we could use it. As it is now, we can't document a script based off someone's fork. It's a security problem. @shin- what do you think?

How have I to propose it in docker/compose ? Which is the right place for it?

An alternative could be to simply insert the script code in the README? So anybody can simply C&P it and use .. it would be secure enough IMHO

You can check in https://github.com/docker/compose and look in the contributor guidelines there. It doesn't make sense to put a script like this in the readme in the docs repo, because that readme is all about how to build the docs themselves. Thanks!


fixes fhamborg/news-please#66

This will mostly fix the issue, not sure tho if it's the best approach, but I was able to fix #66 with it.
References:
1

Hey @fhamborg any idea when this is going to be merged?

Hi, thank you for the PR. I'm sorry, but I haven't had the time yet to investigate the changes fully. Besides, removing the six import statement makes the code only usable in either 2.7 or 3.x, which is not in line with the goals of news-please (which is to support both Python versions). So, despite that I need to investigate whether the other SLOCs have any other side effects, the PR cannot be merged in its current form.


Avoid duplicating work in .xsl and .py

THE EXAMPLE WE IDENTIFIED IN THE 2022-07-29 MEETING
There may be others?
The 001_02 stylesheet constructs an RT IRI using the RT ID along with information about which platform the RT will be loaded to passed from a param:
[...]
<rdf:Description
            rdf:about="{concat('https://api.', $platform, 'sinopia.io/resource/', $rt_id)}">
[...]

003_batch_load_RTs.py reconstructs the RT IRI, using the RT ID and information about which platform the RT will be loaded to passed from a param.
[...]
new_URI = f"https://api.{platform}sinopia.io/resource/{RT_id}"
[...]

Changes made in output_multiple_props branch, see commit 8a1dfcc


Remove -a from go build

@stack72 Same as other comments - No option on sidebar to add you as a reviewer, you have merge rights here, right? Could you check if engineers have write permissions to the repo?

@AaronFriel yes, I can't merge this pull request :(
@stack72 could you please check my permissions to the repo?

same as other provider


Verbose output with line numbers/stack

Summary of the new feature/enhancement
This is primarily for scripts, but could work with binary modules.  Often I use Verbose output to help diagnose why something isn't working (like our build.psm1 module).  It would be very helpful if Verbose output also wrote out the script file and line number.
Proposed technical implementation details (optional)
Possibly add a new VerbosePreference of "ContinueIncludeCallSite"
Current example output:
VERBOSE: Using configuration 'Debug'
VERBOSE: Using framework 'netcoreapp3.1'
VERBOSE: Using runtime 'win7-x64'
VERBOSE: Top project directory is D:\PowerShell\src\powershell-win-core
Run dotnet restore D:\PowerShell\test\tools\Modules --runtime win7-x64 /property:SDKToUse=Microsoft.NET.Sdk.WindowsDesktop --verbosity quiet
Done restoring D:\PowerShell\test\tools\Modules
Name='SelfSignedCertificate', Version='0.0.4', Destination='D:\PowerShell/test/tools/Modules'
VERBOSE: $env:POWERSHELL_TELEMETRY_OPTOUT = 'yes';$env:PSModulePath = 'D:\PowerShell\test\tools\Modules;'+$env:PSModulePath;Set-ExecutionPolicy -Scope Process Unrestricted; Import-Module 'D:\PowerShell\src\powershell-win-core\bin\Debug\netcoreapp3.1\win7-x64\publish\Modules\Pester'; Invoke-Pester -OutputFormat NUnitXml -OutputFile C:\Users\slee\test\pester2.xml -ExcludeTag @('Slow') -Tag @('CI','Feature') 'D:\PowerShell\test'

proposed opton (line numbers made up):
VERBOSE: (@ .../build.psm1:30) Using configuration 'Debug'
VERBOSE: (@ .../build.psm1:31) Using framework 'netcoreapp3.1'
VERBOSE: (@ .../build.psm1:32) Using runtime 'win7-x64'
VERBOSE: (@ .../build.psm1:38) Top project directory is D:\PowerShell\src\powershell-win-core
Run dotnet restore D:\PowerShell\test\tools\Modules --runtime win7-x64 /property:SDKToUse=Microsoft.NET.Sdk.WindowsDesktop --verbosity quiet
Done restoring D:\PowerShell\test\tools\Modules
Name='SelfSignedCertificate', Version='0.0.4', Destination='D:\PowerShell/test/tools/Modules'
VERBOSE: (@ .../build.psm1:115) $env:POWERSHELL_TELEMETRY_OPTOUT = 'yes';$env:PSModulePath = 'D:\PowerShell\test\tools\Modules;'+$env:PSModulePath;Set-ExecutionPolicy -Scope Process Unrestricted; Import-Module 'D:\PowerShell\src\powershell-win-core\bin\Debug\netcoreapp3.1\win7-x64\publish\Modules\Pester'; Invoke-Pester -OutputFormat NUnitXml -OutputFile C:\Users\slee\test\pester2.xml -ExcludeTag @('Slow') -Tag @('CI','Feature') 'D:\PowerShell\test'

This sounds more like debug messages rather than verbose. The end user wouldn't get any benefit if they saw that information. End users are the primary target for verbose messages.

I would agree with that. This is likely to be a better fit for -Debug, and actually a great way to distinguish use of -Debug from -Verbose now that the default DebugPreference when using -Debug is now Continue.

The Verbose stream is for the end-user of a command. It's intended to provide additional information about how the command is proceeding but isn't intended to be a debugging stream for the developer of the command. As the others have observed, that's what the Debug stream is for. Now historically I don't believe Debug has been used very much. Perhaps we should encourage it's use a bit more (and obviously make sure it works the way users expect.)

I think that's the basic problem, even the PowerShell team doesn't use write-debug.  Updating title to reflect this should be for write-debug.  Getting people to use that cmdlet is a separate issue.

I've avoided Write-Debug because it paused execution.  That always seemed like a conflation of concerns to me.  I really wanted Write-Debug to just write to the debug stream.  Guess that works as expected now. I need to try that, having flipped the bozo bit on Write-Debug years ago.  :-)
Having the extra data (file:line:col) on debug stream messages would be nice.


SO-61

User profile account with functionality to edit personal information including profile name, email and change password option.
Show user details (name, email)

Email support is TBD as a separate task.


Auto insert integration tests

Tracks adding basic integration tests for documentation comments from on autoinsert

https://github.com/dotnet/vscode-csharp/blob/main/test/integrationTests/onAutoInsert.integration.test.ts


New helper

insert helper classes for change direction (ltr & rtl) for make this framework mote usable for all languages

https://github.com/Dogfalo/materialize/pull/4391


differentiate Element#visible? and Element#present?

This PR is a spec update only. I'm still figuring out git submodules; I might not want to be referencing a watirspec commit that isn't yet in master (The intent is for Travis CI to see and run it). Even if this works, I expect I will need to rebase it before merging.

@titusfortner I believe you can just push such things on your own, we usually use pull requests for things that require discussion/review.

Hey Alex, thanks. I was using it to better understand how the process we use works with coveralls and travis ci and the watirspec submodule. I'll see about getting watirspec access as well to facilitate commits like these.

I’ve added you full access to watirspec.
I also think that there is no point in having separate teams for different repos, but that’s a topic to discuss at watir-development.=

close/open to fix watirspec submodule pointing issue

trying again

Well, it won't let me reopen since I did a force push on the branch in my local repo (good to know I guess). So, I just merged it instead.


Create 0000-01-02-manjam.md

Made some changes in my-slide branch and comitted them. I would line to commit this change into the main branch.

Very interesting the merge review procedure.


⚠ Bofrost.at has degraded performance

In 1059e64, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2484 ms

Resolved: Bofrost.at performance has improved in 9b76dbe after 6 minutes.


ADD trace method for peerconnection

ugly but...

@ggarber can you rebase on master?

uh. By now you'll have to do it in the module version