Blank Screen After Upgrade to DS 1.6 SP2

After Upgrade to SP2 our DS.Applikation does not render anymore. Blank screen is shown. Firebug reports error in microchart library. We use MicroBulletChart and JSON object in our dashboard.

You can reproduce the issue: Just add component BULLETMICROCHART to a new dashboard using DS 1.6 SP2. Attached the browser log from preview.
SP2_microchart.txt

We have reported the issue to SAP support and got this answer today:
"Dear customer,
the issue is fixed. It will be part of Design Studio 1.6 SP 3.
So far there is an easy workaround, stay on Design Studio 1.6 SP 1 until SP 3 is out.
I expect that you found this regression in your test system and thus this should not be a problem to stay on the older release until the issue is relesed.
One background information: the UI sample controls which are not part of an official SAP shipment make use of UI5 components which we do not guarantee to ship with our product. In orders words internal code coming with Design Studio is used that is not released for public usage.
It is always a risk to do this and we cannot guarantee that we stay compatible. And furthermore we do not test this kind of usage.
1.6 SP 2
http://localhost:63105/aad/resources/~20160613172221~/sap/suite/ui/commons/library.js
/*!
*

SAP UI development toolkit for HTML5 (SAPUI5)
(c) Copyright 2009-2015 SAP SE. All rights reserved

*/
jQuery.sap.declare("sap.suite.ui.commons.library");
jQuery.sap.require("sap.ui.core.Core");
jQuery.sap.require("sap.ui.core.library");
=> jQuery.sap.require("sap.suite.ui.microchart.library");
jQuery.sap.require("sap.m.library");
sap.ui.getCore().initLibrary({
library.js exists but is nt loaded from here: (local mode)
com.sap.suite.suite-ui-microchart_1.34.12.jar\META-INF\resources\sap\suite\ui\microchart\library.js
404 http://localhost:63105/aad/resources/~20160613172221~/sap/suite/ui/microchart/library.js"
Actually we need to upgrade to SP2 asap, because it fixes an issue with integrated planning which we need for a different project on BI platform. Is there any option to adapt sdkpackage in a way that it can be used with SP2 already?

it would require to include this code in SDK package to get this running again. I will check in next 2 days how much effort it is.

we will keep this issue for some while and close in few weeks once SP2 P1 is used and someone of you will confirm the corrections.
correction commented by #129

mas far I know fix on DS side is already released. can someone confirm that we close this?

Hi everyone,
I included some MicroBulletCharts with the KpiTile component today myself and corrected the coding accordingly for the new sapui5 library. As of the DS1.6 SP2 you can now use all of the MicroChart types once our new SCN repos built is published.
@KarolKalisz : The neccessary changes got me a little confused because during my first tests the new microchart lib was already loaded. Some further testing showed that this is not always the case. To be 100% sure I updated your sapui5 include code. Please check if that makes sense to you going forward.
Kind regards
Martin


Clean up reference section

Fix and changes with respect to the issue - Tidy reference section
#22385
Proposed solution mentioned there

make sure that every item in the left-hand navigation is referenced in the main text of the reference section (not counting the autogenerated list)
For this , I tried restructure based on my own preference and combined what is mentioned I already did a PR with quite hundreds of files changes which is recommended to be split and to address for other locals.Kindly help me refer a PR for such kind i can have a look and try or I can take a screenshot of my proposed changes (UI pages and content links) and I will attach it here.

set no_list: true in the front matter of content/en/docs/reference/_index.md
(Done)

/retitle Clean up reference section

@sftim  - Sure tim.I would like to show you sketch of it (Screeshot) with re-arrange hierarchical order or combine them wherever and modify the main section accordingly.
Once you are fine with those , i will apply those changes

Please find the screenshot with the name changes and grouping in the left [navigation.]

Accordingly , I will refer them in the main section (I will update and show you screenhot for main/Overview section as well).
Please let me know if you are fine with first navigation and grouping.

@sftim  - Any thoughts above re-grouping in reference section.

Hi @raghvenders
I wasn't able to imagine the changes you wanted to describe.
So long as the final PR includes links that are in the autogenerated list, that's probably OK. If necessary we can tweak what goes into what group in a subsequent pull request.

@sftim  - have done the updates just comparing reference link and main overview section.
I am not sure why PROW didn't build with the updates yet.

BTW the tool that builds the website is “Netlify”, not “Prow”. Prow does have other roles though.
My review from https://github.com/kubernetes/website/pull/24727#pullrequestreview-517194534 stands @raghvenders - every page that's in the autogenerated list must survive this edit.

/lgtm

Thanks @sftim

thanks @tengqm

I'm worried that these changes represent a regression, because we're removing some links. Readers on a mobile device won't know what they're missing.
@raghvenders if it helps I can provide a line-by-line review of the existing set of links and whether they're retained. If you can do that check yourself, that's even better.

@sftim  - can you please be specific on link readers in mobile device.
Actually we are not removing any specific link rather moving tools.md - > tools/_index.md like every other links under reference section , otherwise correct me if i am missing anything here.

I haven't had time yet to list what needs fixing. Sorry about that.

Page previews:
https://deploy-preview-24727--kubernetes-io-master-staging.netlify.app/docs/home/
https://deploy-preview-24727--kubernetes-io-master-staging.netlify.app/docs/reference/
https://deploy-preview-24727--kubernetes-io-master-staging.netlify.app/docs/reference/using-api/

I recommend more cleanup. @raghvenders do you have any question(s) following @kbhawkey's most recent comments?
/lgtm cancel

@sftim - Sure , I will respond to that Tim.

@kbhawkey @sftim  - changes are done. Please do the review and let me know. I will rebase with the master.

@sftim  - I will work on those review comments. I did a re-base yesterday, but I see PROW needs a re-base.
what is "Superseded"?

Superseded

means the review is no longer relevant because changes since the review make it out of date

@sftim and @kbhawkey Addressed all the review comments mentioned above - https://github.com/kubernetes/website/pull/24727/commits/0541b52b470fd21a85d6b8678ca5ef54b17c95b7
https://github.com/kubernetes/website/pull/24727#discussion_r541133574
while addressing this in the overview section I had removed API reference and made those "Kubernetes API reference v1.20" and "Well-Known Labels, Annotations and Taints" to do that, I had to remove _index.md.Sorry If i understood this wrong , i do revert.

Hi @raghvenders
Would you have time to rebase this PR against the latest master branch?

@sftim  - completed rebasing.

Hi @raghvenders .
Would you have time to rebase (against the master branch)? The docs/reference/kubernetes-api directory has been updated recently. I'd like to see your changes move forward. Thanks!

Hi @raghvenders .
Are you still working on this PR? Do you need a hand to move forward?

@kbhawkey - I did a rebase with the website master and merged changes. Let me know if you any issues. Looks like my laptop clock was on Feb-22 for 2b6074e, but git log --oneline see my HEAD as "2b6074e8e (HEAD -> patch-3, origin/patch-3) changes".

Thanks @raghvenders . I requested some minor changes to the headings. 🎉

Thanks @raghvenders . 👍
I think the changes are fine. If needed, more changes can be added in a follow-up PR.
/lgtm

Let's merge this and follow up with an issue to address the remaining concerns
/approve


Fix Localization problem: https://github.com/CPFL/Autoware/issues/693

FIx https://github.com/CPFL/Autoware/issues/693
1)Fix initializing measurement_range
2)Add Error handring to removePointsByRange()
3)Refactoring performance of removePointsByRange()
Please review.

OK. I modified value to 200m.
And did other refactoring for performance improvement.


Provide error: JSON not recognised

Enhancement
Provide error: JSON not recognised

JSON Validation errors => The Crossref JSON itself is invalid (it's not a JSON string; but garbled data)

For context, see epic #1091
Success criteria
Whenever we can resolve the DOI but the JSON is not recognised, I see an error toaster. See implementation suggestions.
Implementation suggestion
Publications

To be adapted:

The route to other import options (now just a link)
The error code

            DOI import
            404

        <button class="close" type="button" data-dismiss="toast" aria-label="Close">

        </button>

The publication could not be imported.

The DOI was recognised, but the metadata could not be retrieved because of a problem with  Crossref's service.

Try again later, or use a different import option.

Datasets

To be adapted:

The route to other import options (now just a link)
The error code

            DOI import
            404

        <button class="close" type="button" data-dismiss="toast" aria-label="Close">

        </button>

The dataset could not be imported.

The DOI was recognised, but the metadata could not be retrieved because of a problem with DataCite's service.

Try again later or manually add your dataset.

@mietcls About the error message DOI is recognized but .. -> I am not sure if one can make that distinction. If there is something wrong with crossref, then crossref probably won't be able to do any database lookups (or return a result)

This is based on a conversation with @netsensei: https://github.com/ugent-library/biblio-backoffice/issues/1088#issuecomment-1533113247
Does this make sense?

ah Record Validation errors => the CrossRef JSON is valid; but fields are empty, or data is missing) ...?
If a resource returns valid json, but the schema/structure of that json does not make any sense (missing fields),
I would label that also as a json validation error. You expect a certain format, right? Anyway we do no have a
crossref schema available to validate the records first?

@netsensei worded it like this in the discussion (also mentioned in the issue above)"

JSON Validation errors => The Crossref JSON itself is invalid (it's not a JSON string; but garbled data)
Do we still need the crossref schema to fix this one?

This error we will not fix, you can read more about it in the epic:

"Record Validation errors => the CrossRef JSON is valid; but fields are empty, or data is missing)

To be revisited


Add error-prone warnings

This is a WIP, do not merge yet
Using google's error-prone javac plugin we can generate warnings for common bugs, similar to findbugs.

Configured it to fail builds in the case of unused imports.
Configured error-prone to require an @Nullable annotation in order to make return null; work.

Annotated all functions that can return null with @Nullable
Made getMage throw rather than return null, as it was recently annotated @Nonnull. Should we just fix the annotations back to @Nullable?

I can also configure it to require @Nullable on fields, but considering most of the existing code relies on null fields, this would probably be fairly pointless. I guess we should just annotate fields that are always guaranteed to be non null with @Nonnull and other fields @Nullable for new code, and ignore old code for now.
Another thing I ran into is the common pattern of returning null when arguments are invalid. This leads to a lot of things being @Nullable for only that reason, which makes it not as useful as a tool as it could be.
Anyways, this will hopefully improve the quality and maintainability of the codebase. And make my IDE go less crazy with warnings :P. If you have further suggestions for warnings I should configure, I would be glad to do so. (As of now I only raised the severity of two patterns from http://errorprone.info/bugpatterns to make the build fail)
In a future PR I might also look into using something like checkstyle to keep the style more consistent. (Damn tabs everywhere)

Wow, this looks like a ton of work, thanks for doing all of that. Sorry to see that there are already conflicts...
And oops yeah I forgot about the getMage() case of not being loaded yet- I really thought it couldn't return null. Sorry .. yeah I think a throws is a good call there, leave it up to the caller (which is often some other plugin in the case of being called before initializing). I guess if it ends up being an issue we can remove the annotation, but the intention with getMage is that you can rely on it returning a Mage.
As for the style.. yeah I am a tabs guy :P   But I am also a
{
matched brackets
}
guy so I guess there's a special place in Java hell for me.
I would not be opposed to making git annotate a bit harder to use in exchange for a mass reformatting at some point, maybe whenever you're ready to add checkstyle. I'd just need to make sure my IDE was set up to follow the style.

I guess I should've merged this one before the import cleanup :(

This is not ready yet. I just did the imports first so the heavy lifting was out of the way.

Understood, I just meant maybe I should've waited on the imports since it looks like it caused some merge conflict hell here.

Just a bit of manual labor, just like adding @Nullable all over the place ;)

Added in b7a4065

Awesome, thank you.
What would you say to me doing a global tabs->spaces commit?

Um well I was gonna just use my IDE but I like that regex, that'll only do them at the start of a line?

Nope

Oh, duh, right the s is just the sed format. I would just do "\t" -> "    " using a global search and replace in my IDE but I think it'll amount to the same thing. I already did it in MagicWorlds and other than nuking the first level of commit history for every file it seemed to work fine.
I have turned on whitespace in my IDE and indeed I am ashamed by what an insane mix of tabs and spaces are in all these files :(

I guess a global find and replace will work fine, make sure to pull first of course ;)

Am I reading your sed line wrong, or were you suggesting to replace tabs with 1 space? I want 4, right... ?


Range-ify std.path.filenameCmp()

100% unit test coverage
The behavior changes here:

decode only if case insensitive or the arguments are different string encodings
if decoding, treat invalid UTF encodings as if they were replacementDchar's, rather than throwing an exception

This has the effect of making the function:

faster
nothrow and @nogc

Being a low level function, of course this affects everything up the call stack.

Wouldn't this cause odd behaviour if given two strings with invalid encodings in the same positions, thus causing unequal strings to compare equal?

There are 3 options with invalid encodings:

throw exception
terminate program with some sort of error or assert
replace with replacementDchar

Each has advantages and disadvantages. There is no correct solution other than validating your data beforehand. Consider also that floating point NaNs are regarded as equivalent even though they can have different bit patters.
I tend to favor the one with the lowest runtime cost, which is (3). It is far more practical for the programmer to add extra checks if he wants (1) or (2) than it is if he wants to remove them. In fact, to remove them he'd have to reimplement these routines.

lgtm modulo the unnecessary assert(0)

Auto-merge toggled on


Fix Jason's image formatting

Changed the format for Jason's image to lowercase to try to complete "website adapted" on TP dashboard

lgtm


set_once in entities

Is seems that the functionality of set_once constraints has been swept away by the latest wave of changes in the validation library.
This should be checked. If the functionality is indeed broken, we should restore the check. The set_once option only makes sense when changing entity states. Thus, we should add it somewhere around Transaction and Entity.updateState(..)

Resolved.


Cannot reply to groups

If a group_id is given and the message type of "group" passed in, it fails to send a message to anybody and returns a 200.

In case of a single user message
'other_user_fbid' : recipient_id,
In case of a group message
'thread_fbid' : recipient_id,
that seems to do it, at least for me

@kasem123 Know how to fix this for GetThreadInfo?

Facebook has changed a lot of things, and fbchat has been updated, so I'm assuming this is outdated ;)


Laravel 5.2 and PHP 7 Update

This pull request updates the composer dependencies to sync with Laravel 5.2's dependencies. It raises the required PHP version to 5.5.9.
Also, for Travis CI, PHP 7 is no longer an allowed failure.
Suggest creating a new Laravel 5.2 branch for compatibility reasons.

Please merge it!

@publiux thank you for this PR! Sorry missed this one. Does that grants backward-compatibility with 5.1? In that case we won't have to create a new branch for this one.

@publiux any idea if this will remain working for 5.1? @vovanmix did you try it out ?

+1 merge please <3

@canfiax would love to, just wondering if it breaks backward compatibility with 5.1. Sorry for taking long on this but I won't have the time to to try things out so if someone can please let me know so that I merge.

After taking a keen look at the code, it only breaks compatibility with PHP -5.5.9 which is acceptable. Merging.


feat: updated faq with new data

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Do a quick check before the merge.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #1604
[x] Updated some old entries, added new entries and fixed some links

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/faq>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases

Had issue bounty label ?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI, a screenshot is best to understand changes for others.

Perfect, I’ve sent the payout https://kusama.subscan.io/extrinsic/0x08210c3f9ad5f2cac225d8a7eb7dddd841504a33bb00322710707d1052c4a12f
Let’s grab another issue and get rewarded!
https://github.com/kodadot/nft-gallery/issues/


Show bottom right icon optionally

The icon at the bottom right is annoying. It would be very nice if you would add an option to hide it and keep only the extension icon in the navigation bar

Great suggestion

@horczech just added this to v16 of the extension, and I'm awaiting publishing to the store now. I found I had to set the feature as the inverted label of "Hide icon in page" due to the nature of the default data store for the options. Basically new non-existent options don't flag specifically as "false", and instead they are just non-existent when false, so I have to only track "true" when set explicitly. I don't know if that was intended when this extension was created, but I ran with the model I inherited for the time being. Maybe one day I can rewrite it to explicitly store 'false', but I think it works well. Just let me know!


How to download anime/manga on pc

I don't see the download button but there is a downloads section on the app

download is not yet available on desktop, i forgot to remove it. But it'll be available soon.

ok thank you


Optional linked_files - only create symlink if file exists - do not throw error

Has this been discussed already? We would like to link our Symfony file config_local.yml, so its the same between all deployment folders. Although on other environments of the same project, this file is not needed at all.
Workaround: we create an empty config_local.yml on all other environments.
Would be nice if set :linked_files could have an "only if file exists" option.
Thanks,
Kim

Why not add your own set :optional_linked_files with a simple task? We designed Capistrano to be extensible and self-documenting, just add something like this:
    desc "Symlink linked files"
    task :linked_files do
      next unless any? :linked_files
      on release_roles :all do
        execute :mkdir, "-p", linked_file_dirs(release_path)

        fetch(:linked_files).each do |file|
          target = release_path.join(file)
          source = shared_path.join(file)
          next if test "[ -L #{target} ]"
          execute :rm, target if test "[ -f #{target} ]"
          execute :ln, "-s", source, target
        end
      end
    end
  end

Taken from here https://github.com/capistrano/capistrano/blob/f79a386aadc5da27647a57014051098f5a1eba61/lib/capistrano/tasks/deploy.rake#L131-L146 to your own script and define your own behaviours.
Checking if the file exists is also done in deploy.rake and is trivially applied to your own use-case:

https://github.com/capistrano/capistrano/blob/f79a386aadc5da27647a57014051098f5a1eba61/lib/capistrano/tasks/deploy.rake#L85-L97


Indicator about whether image tiles are still loading for current view state

User story
User is panning and zooming on slow internet connection. It is unclear when the highest level (with respect to the current zoom level) of the image pyramid has loaded for all pixels/tiles in the spatial viewport.
Preferred solution
At any given time, indicate:

the (lowest of the viewport for any tile?) level of resolution that has currently been loaded
whether there are higher (than the highest in the viewport for any tile?) levels of resolution

Possible alternatives

At the very least, indicate the current (lowest?) level of resolution, like how higlass does it: http://higlass.io/app
Show a small spinner in the corner of the spatial view when any tile is still loading for the current viewport.

Related to https://github.com/vitessce/vitessce/discussions/1231

Duplicate of https://github.com/vitessce/vitessce/issues/1129


[Autotvm] Fix autotvm customized template

Fix the issue that autotvm customized template cannot get the config from dispatcher.
see details: https://discuss.tvm.ai/t/autotvm-error-in-the-conv2d-auto-tuning-tutorial-cannot-find-config-for-target-cuda-workload-none-etc/5919

cc @comaniac @merrymercy @ZihengJiang

@comaniac Yes, I think _regsiter_task_compute, _regsiter_task_schedule, _regsiter_customized_template should not be user facing APIs. We should use register_topi_compute, register_topi_schedule, template instead.

@comaniac Yes, I think _regsiter_task_compute, _regsiter_task_schedule, _regsiter_customized_template should not be user facing APIs. We should use register_topi_compute, register_topi_schedule, template instead.

I see. Make sense to me.

Thanks @icemelon9 @comaniac


How to use Graph layers as feature extractor?

Hello, I am new to this library and struggling to understand two things:
So, for example, if I have graph data such as :
adj matrix ( A ) => [ node x node ]
Feature matrix => [ node x feats ]

My first question is regarding the input data, so GCN layer and other layers in PyG takes
conv1(x, edge_index)
Where x is feature matrix ( Please correct me if I am mistaken ) and second is edge_index, so how can I feed adj matrix to this layer? Is there any function to transform the adj matrix to edge_index for input to GCN?
My second question is related to multi-modal learning, so I am assembling different networks to get features and contacting them at the end, such as :
network_a_output  = network_a()
network_b_output  = network_b()
image_net_output  = imagenet()
gcn_net_output      = gcn_net()
final_output = concat ( [ network_a_output, network_b_output , image_net_output, gcn_net_output ] )

Previously I was using this Layer as a GCN feature extractor :
class GraphConvolution(nn.Module):
    """
    Simple GCN layer, similar to https://arxiv.org/abs/1609.02907
    """

    def __init__(self, in_features, out_features, bias=False):
        super(GraphConvolution, self).__init__()
        self.in_features = in_features
        self.out_features = out_features
        self.weight = Parameter(torch.Tensor(in_features, out_features))
        if bias:
            self.bias = Parameter(torch.Tensor(1, 1, out_features))
        else:
            self.register_parameter('bias', None)
        self.reset_parameters()

    def reset_parameters(self):
        stdv = 1. / math.sqrt(self.weight.size(1))
        self.weight.data.uniform_(-stdv, stdv)
        if self.bias is not None:
            self.bias.data.uniform_(-stdv, stdv)

    def forward(self, input, adj):
        support = torch.matmul(input, self.weight)
        output = torch.matmul(adj, support)
        if self.bias is not None:
            return output + self.bias
        else:
            return output

    def __repr__(self):
        return self.__class__.__name__ + ' (' \
               + str(self.in_features) + ' -> ' \
               + str(self.out_features) + ')'

And my network looks like this:
class Multimodel(torch.nn.Module):
    def __init__(self):
        super(Multimodel, self).__init__()

        self.n_a  = network_a(100)
        self.n_b  = network_b(100)
        self.n_i  = imagenet (1024)

        # two Graph con layers

        self.gc1  = GraphConvolution(in_features = 768,  out_features = 1024)
        self.gc2  = GraphConvolution(in_features = 1024, out_features = 768)

        self.relu = nn.LeakyReLU(0.2)

        # where feature matrix is    [ nodes x features] numpy array
        self.Graph_features  = Parameter(torch.from_numpy(feature_matrix).float(),requires_grad=True)

        # where adj_d is adj file of [ nodes x nodes ] numpy array
        self.A    = Parameter(torch.from_numpy(_adj).float(),requires_grad=True)

    def forward(self, input_data):

        network_a_output = self.n_a(input_data['data_a'])
        network_b_output = self.n_b(input_data['data_b'])
        network_b_output = self.n_i(input_data['data_c'])

        # graph output
        x = self.gc1(self.Graph_features, self.A)
        x = self.relu(x)
        x = self.gc2(x, self.A)

        # final output
        logits = torch.cat( (network_a_output, network_b_output, network_b_output, x), 1 )
        return logits

model = Multimodel()
model.to(device)

# Now model training and loss etc...

How can I replace this GraphConvolution with PyG GCN layer? Can I directly use it like am I using current implementation ?
Again, Thank you for this awesome package! :)
EDIT :
I tried my custom implementation and pyg implementation of the simple Conv layer, the result is quite different even setting the seed, please check am I using the module correctly?
import torch
import torch.nn.functional as F
from torch_geometric.nn import GCNConv
import torch
torch.manual_seed(12345)

import numpy as np
np.random.seed(100)

class GraphConvolution(torch.nn.Module):
    """
    Simple GCN layer, similar to https://arxiv.org/abs/1609.02907
    """

    def __init__(self, in_features, out_features, bias=True):
        super(GraphConvolution, self).__init__()
        self.in_features = in_features
        self.out_features = out_features
        self.weight = torch.nn.Parameter(torch.Tensor(in_features, out_features))
        if bias:
            self.bias = torch.nn.Parameter(torch.Tensor(1, 1, out_features))
        else:
            self.register_parameter('bias', None)
        self.reset_parameters()

    def reset_parameters(self):
        stdv = 1. / math.sqrt(self.weight.size(1))
        self.weight.data.uniform_(-stdv, stdv)
        if self.bias is not None:
            self.bias.data.uniform_(-stdv, stdv)

    def forward(self, input, adj):
        support = torch.matmul(input, self.weight)
        output = torch.matmul(adj, support)
        if self.bias is not None:
            return output + self.bias
        else:
            return output

    def __repr__(self):
        return self.__class__.__name__ + ' (' \
               + str(self.in_features) + ' -> ' \
               + str(self.out_features) + ')'

# input

a = np.array([[0,0],[1,0]])                           # 2 x 2
b = np.array([[0.87,0.2,0.3,0.4], [0.9,0.8,0.4,0.3]]) # 2 x 4

def convert_numpy_to_coo(a,b, type_):
  adj = torch.Tensor(a)
  feat = torch.Tensor(b)

  adj81 = sparse.coo_matrix(adj)
  row = torch.from_numpy(adj81.row).long()
  col = torch.from_numpy(adj81.col).long()
  edge_index = torch.stack([row,col],dim=0)

  if type_ == 'pyg':
    return feat, edge_index
  else:
    return feat, adj

feat, index = convert_numpy_to_coo(a,b, 'pyg')
feat, adj   = convert_numpy_to_coo(a,b, 'gcn')

gcn_m = GCNConv(4,2)
print(gcn_m(feat, index))
print("\n\n")
print(GraphConvolution(4,2)(feat, adj))

You can convert your adjacency matrix into a list of indices representing non-zero values via:

edge_index = adj.nonzero(as_tuple=False).t()

Your code is correct. Note that the output is different since weights in GCNConv and GraphConvolution are initialized differently, and the message passing flow is in reverse direction. This is fixable via:

from torch_geometric.nn import GraphConv

gnn = GraphConvolution(4, 2)
gcn_m = GraphConv(4, 2)
gcn_m.lin_l.weight.data = gnn.weight.data.t()
gcn_m.lin_l.bias.data = gnn.bias.data.squeeze()
gcn_m.lin_r.weight.data.fill_(0)
print(gcn_m(feat, index))
print("\n\n")
print(gnn(feat, adj.t()))

thank you for the quick response.
Which one is better for my use case? should I do the preprocessing of weight and bias as you mentioned above or take directly the logits from GraphConv output and concat with other features?


Inplace volumes: Create enums of columns names

Right now there is a lot of strings flying around related to column names in the inplace_volumes module. This makes us vulnerable for typing errors e.g. STOIIP vs STOOIP
We should make some enums instead.
https://github.com/equinor/fmu-dataio/blob/32cb40631244a0d9d0025962f5da7f4ff93c386c/src/fmu/dataio/export/rms/inplace_volumes.py#L28-L71

Suggest that these be moved to a separate module, like _definitions.py. Then these can be used elsewhere, such as in the results schema, without the need to check and import roxar/rmsapi


Updated demo section of README.md to reflect proper steps to get spree_essential_blog running.

Summary of changes:

after_migrate.rb.sample moved. https://github.com/citrus/spree_essential_blog/commit/6f720bd00805d20382a0a806079e075a733a78b1
bundle exec rake db:migrate because 'dummier' only sets up the test database.
bundle exec rake db:sample:blog to load sample posts.
bundle exec rails s
visit http://localhost:3000/blog

One thing though, the after_migrate.rb hook should run the migrations and seeds for you:
# test/dummy_hooks/after_migrate.rb.sample
rake "db:migrate db:seed db:sample:blog", :env => "development"

Did it not work?
-Spencer


[Attempt 2] Implement FileManager.url{s,}(for:…) and NSSearchPathForDirectoriesInDomains.

This re-proposes the patch at #1456 — see there for discussion.
Unlike that patch, this one changes the test setup and build so that NS_FOUNDATION_ALLOWS_TESTABLE_IMPORT is defined iif the build product can be used in a @testable import expression, and conditionalizes white-box tests to the presence of that flag. That flag is never available if DEPLOYMENT_RUNTIME_OBJC, since macOS's Foundation will never be usable with @testable import.

@swift-ci please test

This fixes the issues that caused the revert at #1596.

cc @rudkx @shahmishal

I have locally tested this built in Debug and Release on Darwin.

It looks like this still isn't making it past the CI builders. https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/4421/
Perhaps a difference in your configuration vs. the builders?
I'll need to revert ASAP as this will hold other PR testing.

It's passing PR testing, so it could also be an an incremental vs. clean build issue.


Document invocant in method signature

Add documentation on setting invocant in method signatures, using type
constraints to define class and object methods, and using multi
declarator for defining same-name class and object methods.
Fixes #1121.

Took a bit longer than I expected, as I realized it needs documenting the concept of invocant first, and a slight peek at type constraints, to better illustrate the entire concept.
Let me know if it needs more tuning, or more :pizza:

Thanks again @moritz !

Thank you for your contribution @zakame! You should have received an invitation to the "perl6" team, which allows you to push to the doc repo (and others) directly.

Yep, just saw it, many thanks! 😸

Suggestion: the new patch should be in a separate section titled/labeled "Class and Instance methods" after the "method" and "self" sections.  I think having a new section better fits the structure of the surrounding pieces of the OO document.

@ronaldxs yeah I was mulling that too, thanks for suggesting 👍


Updating data list on Angularjs is not reflecting in Frontend

Hi guys, I have a little problem, everytime I update the data list in my controller is doesnt reflect the change in frontend, im doing this.
In this function I just want to remove an item in a list if its added in the table, but the change is not 'working'
$scope.checkNoNormasDerogadaReglamentada = function (id_norma, listaDatos) {
        var count = listaDatos.length;

        for (var i = 0; i < count; i++)
        {
            if (id_norma == listaDatos[i].Id)
            {
                listaDatos.splice(i, 1);
                break;
            }
        }
    }

I did this but it doesnt work
$('select[chosen]').trigger('chosen:updated');

This is my Html
<select chosen options="listaNormasAll" class="form-control" ng-model="norma.reglamentaNorma" ng-options="item as item.Nombre for item in listaNormasAll">
                                <option value="">---</option>
                            </select>

I hope listaDatos is attached to the $scope or this of the controller.
or just change it to this: (if this makes sense in your use case)
$scope.checkNoNormasDerogadaReglamentada = function (id_norma) {
        var count = listaDatos.length;

        for (var i = 0; i < count; i++)
        {
            if (id_norma == $scope. listaNormasAll[i].Id)
            {
                $scope.listaNormasAll.splice(i, 1);
                break;
            }
        }
    }

If that doesn't work; is the entire UI under the same controller? If not that could also be the issue. Maybe the digest cycle was never triggered on the other controller and only when you clicked the drop did it execute the digest cycle and it got updated. Try $rootScope.$apply(). Not sure if that will work either.

Omg thank you so much, that works for me!

Happy to help. Closing this issue. :)


Plan to use ruflin/elastica version 8?

Hi,
First of all thank you for this library :-)
I am wondering if it is planned to use version 8 of ruflin/elastica, and if so when more or less?
Many thanks

We would be happy to see Pull Request about this yes. Can you work on this?
Some difficulties could arise:

the connections pool is now based on Elasticsearch custom https://github.com/elastic/elastic-transport-php - so our Symfony HttpClient bridge must probably be changed;
it will probably stop working with OpenSearch, see https://github.com/elastic/elasticsearch-php/issues/1347 (not tested)

I would love for our project to be compatible with both 7 and 8.

Thank you @damienalexandre for your quick feedback! Sure I can invest some time to try & contribute :slightly_smiling_face:

also I forgot to mention that I am not sure if we can make it work with both versions, as the namespace for different classes (e.g. Client) has changed between 7 and 8.

The 8.0.0 version is now released https://github.com/ruflin/Elastica/releases/tag/8.0.0

Thanks @VincentLanglet for the update!
@damienalexandre so I started to work on it and now I get following error message for many of the PhpUnit tests:
Elastic\Transport\Exception\NoNodeAvailableException: Exceeded maximum number of retries (1)
I am missing anything, should I set some environment/configuration value?

The tests are running against a real Elasticsearch.
You can run this:
make start
make test
make stop

It will boot a ES node via Docker and expose port 9999 (we don't use the default 9200 port to avoid touching any real Elasticsearch node you may have on your computer).

I had actually tried to start the docker ES node as I saw the makefile, however I still get exactly the same error message :disappointed: any other idea?

hi @damienalexandre so I tried once again to make this work without success, would you have any other hint?

Could you show the console output?
Can you run docker ps?

sure, here it is:
console output (just an extract)

docker ps

Can you open http://<IP_ADDRESS>:9999/ in a browser?
What does curl http://<IP_ADDRESS>:9999/ get you?

This is what I get when opening this in a browser:

And with curl (essentially the same):

I don't know what's happening but:

you have a working php
you have a working elasticsearch

Is there something we don't know? Do you have a proxy?
Can you go to http://<IP_ADDRESS>:9999/_cluster/health?pretty and paste the result?

Thanks for taking the time to help :pray:
Here is the outcome of that URL:
{
"cluster_name": "docker-cluster",
"status": "green",
"timed_out": false,
"number_of_nodes": 1,
"number_of_data_nodes": 1,
"active_primary_shards": 0,
"active_shards": 0,
"relocating_shards": 0,
"initializing_shards": 0,
"unassigned_shards": 0,
"delayed_unassigned_shards": 0,
"number_of_pending_tasks": 0,
"number_of_in_flight_fetch": 0,
"task_max_waiting_in_queue_millis": 0,
"active_shards_percent_as_number": 100
}

Status green, it should work!
You test from "master" or with your updated dependencies? It looks like the Elastica client is not properly configured, that may be a regression from version 8.

aaah got it, it is indeed an issue from version 8! I reverted my changes and it works fine :tada: alright then, I need to investigate further :sweat_smile:  thanks again so much for your support :pray:
ps: if anyone sees this and wants to help too, please do :slightly_smiling_face:

thanks @jderusse I have actually also just noticed the same while trying to run the tests with elasticsearch without updating the docker image :+1:
@damienalexandre I am making some progress, now some more tests are green :tada:

short update, now I have all tests green besides the one for the HttpClientTransport where I might need some help - I'll do as much as I can :slightly_smiling_face:

Hi @jmariller ! Are you still working on this? Maybe I can help on the HttpClientTransport issue

hi @GaryPEGEOT! no, at the moment I do not have capacity unfortunately. So if you could help it would be great - you can check out my PR and work directly on it if you want :slightly_smiling_face:  thanks!

Hi @damienalexandre!
Correct me if I'm wrong, but it looks like JoliCode\Elastically\Transport\HttpClientTransport will not have much sense with ruflin's Elastica v8:

AbstractTransport is gone
Elastic\Transport\Transport is a final class

And maybe more importantly, we don't really need it anymore, as you can specify $config['transport_config']['http_client'] directly, and provide it with your own Symfony\Component\HttpClient\Psr18Client.
We could update ElasticallyExtension so that given a client it automatically create the PSR client.

You are absolutely right, and what you suggest looks good, thanks :+1:

I'm creating a PR on damien's fork to remove the transport while adding test to make sure you can specify your own PSR Compliant client if you want to. This will be a BC break tho, so I guess we need to target a new branch like next instead of master?

This can be shipped as a new major Elastically version. Can we make sure update the documentation as well?

I'm creating a PR on damien's fork

Wouldn't it better to do it directly on this repo ?

I have some clean up to do before a release. For example we must remove OpenSearch from supported products :disappointed:

Version 2.0 of Elastically, with Elastica 8, is now available! Thanks everyone!


OC Project pod was not successful. Ask for help ~

~/Desktop/libTool/demo   master  pod install
Analyzing dependencies
Downloading dependencies
Installing ZIPFoundation (0.9.8)
Installing iOSDFULibrary (4.3.0)
[!] Unable to determine Swift version for the following pods:

ZIPFoundation does not specify a Swift version and none of the targets (demo) integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.
iOSDFULibrary does not specify a Swift version and none of the targets (demo) integrating it have the SWIFT_VERSION attribute set. Please contact the author or set the SWIFT_VERSION attribute in at least one of the targets that integrate this pod.

Please, use the latest version of dfu library, which is 4.4.2.


Migrate from make to npm scripts

Need to merge at the same time as this PR: https://github.com/melange-re/melange-for-react-devs-template/pull/4

@jchavarri Great catches, thx! Fixed both in https://github.com/melange-re/melange-for-react-devs/pull/23/commits/87ca72e2c07939a4c4480e51465854a8d8ebb487


load checkpoint got error when channel_values have null values

https://github.com/tjni/langgraph-checkpoint-mysql/blob/46a2599af9db0c36d6988e96f088e20dbeb61c22/langgraph/checkpoint/mysql/utils.py#L10
channel_values may have null values

so, the method shoud add none check before base64 decode, fix :
def decode_base64_blob(base64_blob: MySQLBase64Blob) -> bytes:
    if not base64_blob:
        return None
    _, data = base64_blob.rsplit(":", 1)
    return base64.b64decode(data)

Confirming this as well on my end.

Thank you @asanger for fixing this! I merged it and released 2.0.3.


CH: linkage between company and project seems to be failing everywhere

Although I see countries in the DB, as facts
@cperry

Working now


NavInsID enum is hard to extend

Designed as a toolbox, Ragger classes are most of the time easily extendable and reconfigurable. This is true for backends, navigation, screen and such.
NavInsID, however, is difficult to extend, as it inherits from the Python enum.Enum type which is not subclassable (for good reasons).
This means that one could not just extend the NavInsID enumerator with custom IDs, but has to re-defined the enum, and the callbacks. This is redundant and could lead to frequent rewrite of the code as the NavInsID are used in code portion where isinstance() or direct comparison are made, which could lead to unforeseen errors, or dirty tricks to comply with the Ragger code.
We should think of some mechanism to give more flexibility to users.

This commit 87d3179 kinda solves this by adding a BaseNavInsID mother class, inherited by NavInsID, but which could also be inherited by any custom class while still being compatible with Ragger inner code.
NavInsID still can't be extended by I guess that's not too much of a burden. Developers willing to add their own custom instructions can bare to duplicate some.


gather community/leadership input regarding the textual annotations involved in study/consortium

https://github.com/microbiomedata/nmdc-schema/pull/1098

We can merge this PR now and change it's textual annotations (mappings, labels, etc.)later without a migration. @emileyfadrosh @mslarae13  @lamccue
After populating the study_category for all Studys in MngoDB, we can switch that to a required slot, and s migration shouldn't be required.
However, it will become necessary for the Submission Portal to ask whether the thing that is being submitted is a more like a study or more like a consortium. @jeffbaumes @naglepuff @marySalvi

We chatted about this in the study page squad. My suggestion, we assume a study is a study and any consortiums or umbrella studies we want to add, we'll evaluate on a case by case basis for now.
Implementing this language into the submission portal now is likely to confuse the community and we should popularize it first.
Leave this issue open, as a reminder for when we're ready to tackle identifying study type on the submission portal. Until then, backlog.


Default income shock for newborns

cc @mnwhite
So, when we simulate an IndShockConsumerType and newborns arrive, we have to set initial permanent and transitory income shocks.
Current, it's sort of a weird situation. Transitory income shocks are initially set to 1.0 (the mean) but permanent shocks are set to a random draw from the permanent income distribution. So why/what/when?
It seems to me that this code was introduced #38 where we have these lines
https://github.com/econ-ark/HARK/blame/9d0b1f4b2c883c562f60624df08636257c785562/ConsumptionSaving/ConsIndShockModel.py#L1566
As you can see, both shocks are initialized to 1.0, and then we update the shocks from there according to their distribution.
Then, in a commit that has no PR associated to it, the code changes to
https://github.com/econ-ark/HARK/commit/b4b473cc0c68ecadad096aee8a1d872a36a4db76#diff-b74561b6ba933aa9634d9b609ac72f36R2023
Now, both shocks come from their distribution from the first period.
And then, in a commit related to StickyE, and in the commit message it says
https://github.com/econ-ark/HARK/commit/fce7d45bb400aa6a56e404a813b7586fb0abb7b5#diff-b74561b6ba933aa9634d9b609ac72f36R1858
The SOE-Markov model is working in StickyE.  Had to give newborns 1.0
for TranShkNow, else change in log consumption was crazy.  Added
IdentityFunction to HARKinterpolation, which is a copy-paste from a
private MNW branch.  Will clean up the main file to make it a bit more
elegant.  Everything should be set for HA-DSGE versions, will do
tomorrow.

And transitory shocks are once again initialized to 1.0.
My reading of this history is that at some point it was initialized to the mean, then it was changed to a draw (I guess to get a more interesting default data set), but then it was reverted because of the specific use-case in StickyE. This seems like something that should have only happened in the StickyE-specific folder/code. Or is there a more general reason that we want to initialize everyone with the same transitory income?

@mnwhite

for reference: https://github.com/econ-ark/HARK/pull/499

This was resolved a while ago, and will be further improved by HARK 1 revisions to the time structure.


UI Tests for the extension (in nodejs)

Re-write of https://github.com/microsoft/vscode-python/issues/4692
The original UI Tests were written in Python (that solution had issues due to the use of selenium driver).
The new version will be based on nodejs using the Chrome devtools protocol (puppeteer).
Broken into the following stages:

[x] Refactor pipelines into stages https://github.com/microsoft/vscode-python/pull/7430
[x] Add command to display the language server output panel https://github.com/microsoft/vscode-python/issues/7459
[x] Add ability to hide the process execution info displayed in output panel #7463
[x] Decrease refresh rate of progress icon (when tests are running) (currently it updates too fast and UI tests fail - CSS query fails). #7465
[x] Provide a way to disable experiments https://github.com/microsoft/vscode-python/issues/7410
[ ] Smoke tests are broken due to the re-enable insiders prompt https://github.com/microsoft/vscode-python/issues/7535
[ ] Add UI Tests to run smoke tests (enable just the smoke tests) #7456.
[x] Add UI Tests to run UI Tests (enable just the stable UI Tests) https://github.com/microsoft/vscode-python/pull/6717
[ ] Add UI Tests to run UI Tests for other tests (there are a number of UI tests that are disabled).

Any updates on this?

I have updated what has been completed.

Removing myself from this issue as I've completed majority of the requirements.


Move to the Go community slack

The go community is very active over Slack.. I believe we can benefit from moving to Slack :D
Slack: gophers.slack.com
(invite)
cc: @abourget

done.
Invited both of you to the channel.
On Wed, Mar 30, 2016 at 1:16 PM, Almog Baku<EMAIL_ADDRESS>wrote:

The go community is very active over Slack.. I believe we can benefit from
moving to Slack :D
Slack: gophers.slack.com
(invite https://gophersinvite.herokuapp.com/)
cc: @abourget https://github.com/abourget
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/elazarl/goproxy/issues/151


Add pdf icon

Add pdf icon from nerd font: ;
(Ignore the Github rendering, this is not a dollar sign.)

whoops I believe I added an extra semicolon

thanks ;)


Want to persist state reference

I am using this module conveniently.
I stored two arrays in state.
One is shop, another is discount setting.
Discount setting has a reference to shop.
After persisted state, reference will be changed to object.
I wanted the way to preserve the reference.

This is all up to you and your application architecture and is not related to this plugin


Add function for Min/Mean/Max when stacking

Not sure how useful this will be in general, but might be interesting for transits.
ref: https://www.cloudynights.com/topic/919617-freeware-to-stack-in-maximum-or-minimum/


Search not case-insensitive for non-ascii characters (e.g. German Umlauts)

Behavior for ASCII characters:
echo -e "uber\n Uber\n"|fzy
> u
uber
 Uber

When you search for lowercase "u", both "uber" and "Uber" are shown.
Behavior for non-ASCII characters:
echo -e "über\n Über\n"|fzy
> ü
über

When you search for lowercase "ü", only "über" is found.

Similarly, Arabic has a few letters that should match each other, e.g. ا == أ for searching purposes.

Similarly, Arabic has a few letters that should match each other, e.g. ا == أ for searching purposes.


Error in Syntax ?

is "OPTION <query_hint> " optional ?
And for the <query_hint> clause,  is
"<query_hint> ::=
{
MAXDOP
}
"
correct ?
How about the statement :
"CREATE TABLE [wwi].[fact_Purchase]
WITH
(
DISTRIBUTION = HASH([Purchase Key]),
CLUSTERED COLUMNSTORE INDEX
)
AS
SELECT * FROM [ext].[fact_Purchase]
OPTION (LABEL = 'CTAS : Load [wwi].[fact_Purchase]')
;
"
Is it of correct syntax ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d789618-4d39-1977-a4f3-520308f4f675
Version Independent ID: a4e034e8-fc72-dd9b-c575-1ef81528c5cd
Content: CREATE TABLE AS SELECT (Azure SQL Data Warehouse) - SQL Server
Content Source: docs/t-sql/statements/create-table-as-select-azure-sql-data-warehouse.md
Service: sql-data-warehouse
GitHub Login: @julieMSFT
Microsoft Alias: jrasnick

@luomoyuyi -- Yanzhe, thank you for your feedback.  It appears you have an issue with your algorithm or implementation, rather than with the documentation itself.  You may find an answer here:

Transact-SQL - MSDN forum
Reddit - general discussion about SQL Server

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


fix: changed javascript for renovate bot config

fixes https://github.com/GoogleCloudPlatform/point-of-sale/issues/104
https://docs.renovatebot.com/configuration-options/#js

I'm merging this with one failing test (completely unrelated to this change).


Initial functionality.

Initial functionality:

generation of keys via Ursa and Ed25519.

Ready to be merged into master.

Commit signed-of


Load list of video files

Hello sir, How can i load list of video files??
Good Job!!!

I didn't quite understand your question. Why do you want to load multiple video files for trimming?
Do you want to trim multiple files at the same time? I don't think it is a good decision to do that.
If you still want to achieve that kind of functionality, then you can try to use this package or modify it as per your need.

if i want share videos after trimming like whats app, then how can i do that??

You can access the file by its path and then you can perform any operation upon it.

I did it by passing the video file in trimmer.loadvideo() function instead of selecting from gallery..
Thank you so much sir....

Great! Closing this as the issue is fixed.


fix: invalid examples/documentation in parquet_derive doc

Which issue does this PR close?

Closes #5687
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Perhaps we could change ignore to no_run to ensure these examples are kept up to date?


Kiosk should have a closure component

a closure component is the final step on how a demo will end such as showing a printed animation ticket

will not implement this


Deprecate prepare_module

In version 1.13, prepare_module was deprecated.
This PR adds a deprecation warning and removes it from all the library, using dataset_module_factory or metric_module_factory instead.
Fix #3165.

Sounds good, thanks !


Archive lab.

Archived labs are read-only, and they can be moved back out of the archives, if there is interest in reviving them.
Signed-off-by: Tracy Kuhrt<EMAIL_ADDRESS>

@tkuhrt Thanks for the housekeeping. I'm planning to submit patches within this month, so I'd like to put this suggestion on hold for a while.

@shimos : Thank you for the update. We have been asked to archive labs that are no longer active (defined as not having a contribution to the repository in more than 3 months). We are happy to keep the lab open, but we request that you consider how to ensure that the lab remains active so we do not cause additional noise for both yourself and the lab stewards.


(GH-18) Add author key to all configs

Prior to this commit, the PCT Config files for all templates were missing the author key. This is necessary to comply with the namespacing architecture for templates.
This commit adds the author key to every template in this repository with the value set to puppetlabs.
Resolves #18.

@sanfrancrisko I think that's covered in #17, no?

@sanfrancrisko I think that's covered in #17, no?

It is indeed. By bad


Closes: #1 Add first letter username validation

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


ServiceRegistryJpaImplTest.testIgnoreHostsInPriorityList regularly fails

Building the service registry regularly fails on its tests. I've seen this multiple times, both locally and on our test servers.

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.116 s - in org.opencastproject.serviceregistry.impl.OsgiIncidentServiceTest
[INFO] Running org.opencastproject.serviceregistry.impl.ServiceRegistryJpaImplTest
20:55:45 ERROR (ServiceRegistryJpaImpl:639) - Job with Id 1 cannot be deleted: Not found.
[ERROR] Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.328 s <<< FAILURE! - in org.opencastproject.serviceregistry.impl.ServiceRegistryJpaImplTest
[ERROR] testIgnoreHostsInPriorityList(org.opencastproject.serviceregistry.impl.ServiceRegistryJpaImplTest)  Time elapsed: 2.125 s  <<< FAILURE!
java.lang.AssertionError
        at org.opencastproject.serviceregistry.impl.ServiceRegistryJpaImplTest.testIgnoreHostsInPriorityList(ServiceRegistryJpaImplTest.java:342)

[INFO] Running org.opencastproject.serviceregistry.impl.JobTest
20:56:03  WARN (ServiceRegistryJpaImpl:551) - Creating a job from http://localhost:8080, which is currently in maintenance mode.
20:56:03 ERROR (ServiceRegistryJpaImpl:1047) - originalJob.getProcessorServiceRegistration() is null
[INFO] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.49 s - in org.opencastproject.serviceregistry.impl.JobTest
[INFO] Running org.opencastproject.serviceregistry.impl.DispatchableComparatorTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 s - in org.opencastproject.serviceregistry.impl.DispatchableComparatorTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   ServiceRegistryJpaImplTest.testIgnoreHostsInPriorityList:342

I can take a look at this eventually, so I'll grab it. If someone wants to tackle this before I get to it feel free
/assign me

Did you already find time to take a look at this? I've again seen this multiple times (once just now) on our test systems causing builds to fail.

I have not, but can take a look tomorrow.

@lkiesow is there a version where you noticed this starting to happen more often?

No idea when this first popped up

@gregorydlogan, are you still working on this? I've seen this break two builds again today. If you stopped working on this and you are reasonably sure that it's misbehavior of the test, I suggest we drop the test.

I'm reasonably certain there is a very rare bug deep in the SR dispatch code, but I cannot get it to reproduce in my dev setups.  I do see it from time to time in my local buildbot infrastructure, but that's not exactly helpful for debugging.  Let's ignore the test for now, and when (if?) I get to building more unit tests I'll try and fix it then.

@lkiesow  and @gregorydlogan we were looking at that odd Travis CI ServiceRegistryJpaImplTest fail last September 2019. The fails appear to be race conditions associated to the build up and tearing down of test resources around each test in that class. As far as I know, no one outside the "Travis CI" environment is getting errors on that test. I think It might help if the core resources for that testing class were built and kept between each test, only cleaned in-between tests, but not torn down in-between test. Then only tear down all resources at the end of the testing class. I can try this in a testing pull.

Certainly welcome to try @karendolan.  The frustrating part I've found is that this happens rarely enough that you think you've fixed it, but then you find out that it's broken somewhere else.  Don't expect the PR to be quick to accept :)

@lkiesow  In the description you said you saw this test fail locally? Do you  remember if that was on a standalone system and if anything else was building concurrently on that system when you saw the failure?

A build on my i7-7700 powered workstation caused me to create this issue if I remember correctly. So, it's appearing on all kinds of systems. Just on some, it seems to be more frequent.
Builds on Travis CI should also not happen in parallel on the same machine. If I remember correctly, a separate VM is launched for every build.

@lkiesow thank you for that information. I think I see the race condition in some of the tests: The ServiceRegistry loop attempts to dispatch jobs at intervals, the JobBarrier loop tests the state of the job. During the ServiceRegistry loop, a queued job is put in an "optimistic" dispatching state with a processing host. The job goes back to its queued state when it cannot dispatch. The junit tests assumes certain jobs are not dispatchable so it throws an assumption error when the job is in that optimistic dispatching part of the loop. It's odd this race condition doesn't show up more.
I'm going to shortened the start-delay for the ServiceRegistry thread and add a huge interval delay (or otherwise ensure the ServiceRegistry only executes once, for certain tests), the JobBarrier timeout should be Ok as twice the ServicerRegistries start-delay.
As @gregorydlogan said, I'm not sure this is worth the effort, but, as for now, this ServiceRegistry job dispatch is core to Opencast. The tests are needed if only to help explain what's going on in the code to an interested developer.


Allow users to reference conversationId property

conversationId property is currently set to private here. Users cannot reconnect to an existing conversation or handle ConnectionStatus.ExpiredToken state.
Change the access modifier to public to allow users to store conversationId externally in a db/localstorage.
This can be overcome by starting the conversation ourselves on the backend and passing streamUrl, token and conversationId to Directline constructor, but as of this code, the refreshToken loop will not be run by directline and users have to manually handle it.

That sounds right. Care to file a PR?

Gladly :)

We are tracking the resume story at #124, which will fix this issue.

See #124 for updates on this workstream


Parquet writer should default to writing pages with DataPageV1 for better compatibility with other Parquet readers

Hello,
I am investigating a parquet-cpp issue where the data in a file written by the parquetjs library is not readable by the parquet-cpp library. This also seems to be related to another open issue in the parquetjs library: https://github.com/ironSource/parquetjs/issues/75 .
This is happening since parquetjs writes data pages using the DataPageV2 format, which doesn't appear to have widespread support among most Parquet readers, like parquet-cpp. I have opened a pull request in parquet-cpp to improve its DataPageV2 support here.
I see that there is some logic in parquetjs' writer.js to write DataPageV1 pages instead, but this is only accessible through the ParquetEnvelopeWriter API. It would be better if the ParquetWriter class could also default to writing DataPageV1 pages to improve compatibility with other Parquet readers.

BigQuery also does not support data page v2


Style/Add Material.UI components

Some requests:

change the name of the file: client/src/containers/Jamroom.jsx to client/src/containers/Jamroom.jsx
Put this code into the top of client/src/index.jsx

import injectTapEventPlugin from 'react-tap-event-plugin';

// Needed for onTouchTap
// http://stackoverflow.com/a/34015469/988941
injectTapEventPlugin();


Error: Cannot find module 'stylus'

This is my first time using Rails 3.1 asset pipeline and seeing this error when trying to include a .styl file.
I've included gem 'stylus' in the Gemfile, run "bundle install", and install Stylus with "npm install -g stylus".

Hi,
What does your NODE_PATH looks like? You can also install stylus on the working folder of your app (just skip the -g flag) and the gem will push it to the node 'load path'.

Ooooh...didn't realise I need to "npm install stylus" in the Rails root.
Also, I realised the name needs to be foo.styl, not foo.styl.css. It's
working now, thanks.
On Fri, Oct 14, 2011 at 3:09 PM, Lucas Mazza <
<EMAIL_ADDRESS>
Hi,
What does your NODE_PATH looks like? You can also install stylus on the
working folder of your app (just skip the -g flag) and the gem will push
it to the node 'load path'.
--
Reply to this email directly or view it on GitHub:
https://github.com/lucasmazza/ruby-stylus/issues/8#issuecomment-2406951


Deprecate/raise error for PVSystem "pass-through" properties

~Closes #xxxx~
[x] I am familiar with the contributing guidelines
[x] Tests added
Updates entries to docs/sphinx/source/api.rst for API changes.
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Trying out the idea suggested in https://github.com/pvlib/pvlib-python/pull/1176#discussion_r584745688: for the values that used to be PVSystem attributes but have been moved down to Array, emit a deprecation warning for systems with only one Array and an error if more than one.
Note to reviewers: I was guided more by test failures than by a solid understanding of the emerging PVSystem+Array architecture.  Wouldn't be surprised if I've missed something here.

I think this is ready for review.  It feels risky to me to use system.arrays[0] in places where we expect, but don't verify, that the system has only one Array.  Maybe worth adding a PVSystem.array convenience property that returns self.arrays[0] if len(self.arrays) == 1 and raises an error otherwise?

It feels risky to me to use system.arrays[0] in places where we expect, but don't verify, that the system has only one Array. Maybe worth adding a PVSystem.array convenience property that returns self.arrays[0] if len(self.arrays) == 1 and raises an error otherwise?

Can you elaborate? The tests pass and the diff is straightforward. We also have the property PVSystem.num_arrays. I'm open to to adding a property like PVSystem._has_single_array, but maybe that is a case of too much indirection.
I'm +1 on this PR. Would be good to hear any comments/concerns from others before moving forward.

It feels risky to me to use system.arrays[0] in places where we expect, but don't verify, that the system has only one Array. Maybe worth adding a PVSystem.array convenience property that returns self.arrays[0] if len(self.arrays) == 1 and raises an error otherwise?

Can you elaborate? The tests pass and the diff is straightforward. We also have the property PVSystem.num_arrays. I'm open to to adding a property like PVSystem._has_single_array, but maybe that is a case of too much indirection.

Yes, sorry for not being clear.  My concern is that code like this, which does not check that len(self.arrays) == 1, puts the onus on the caller to verify that it is appropriate to call that method.  Right now that contract is fulfilled, but I could see myself missing that requirement in some future refactor and accidentally introducing a subtle bug.  I'd encourage us to put assumption checks like if self.num_arrays == 1 as close as possible to the code that makes the assumption.  My PVSystem.array property suggestion in the previous comment is in the spirit of pandas's item(), which is a convenient way to perform the length==1 check and element retrieval in one step.  If nobody else is particularly concerned about this then I'll drop it :)

It's not clear to me why codecov is flagging the diff coverage.  When I calculate coverage locally it shows line 961 (really, 956) in modelchain.py covered as expected.
@wholmgren ready for you to review when you get a chance.

Also a handful of problems in pvsystem.rst. I think you'll want to bring your branch up to date before tackling those.

@cwhanse ok to merge?

There one warning in modelchain.py from codecov about a ValueError line not being hit, but it looks to me that the ValueError should have been raised by this test.
Other than that, LGTM.

There one warning in modelchain.py from codecov about a ValueError line not being hit, but it looks to me that the ValueError should have been raised by this test.

I'm not sure what I did wrong when I checked coverage earlier in the thread, but I now agree with codecov that the ValueError was not exercised.  I checked coverage in pvlib==0.8.1 and it's not covered there either.  The test you linked is for a similar but distinct error.  62a549e makes that test more specific and adds a test for the uncovered error as well.

Merge when green!


Reconciliation : Left panel "Services" bounce

When clicking on "Services", the panel is "closing" but immediately "reopening" like it bounce.
To Reproduce

Adding a new reconciliation service
Click on the services title or on the label icon
The panel is "moving" left normally
The panel automatically "move" to the right

Current Results
All the filed behind the panel are hidden
Expected Behavior
The panel should stay "closed"
Screenshots

Versions

Operating System: macOS Mojave 10.14.6 (18G4032)

Browser Version: Firefox 79.0 Firefox Release July 28, 2020

JRE or JDK Version:

java version "1.8.0_74"
Java(TM) SE Runtime Environment (build 1.8.0_74-b02)
Java HotSpot(TM) 64-Bit Server VM (build 25.74-b02, mixed mode)

OpenRefine: Version 3.4-beta-327-g0645c2a (1)

Hi @pyrog Yes this is a known issue #1658 , so marking as duplicate.  Hopefully we get this resolved soon in an upcoming release.


Add multiple_signatures test

This tests that we can re-use operation IDs (if we want the same constraints), but switching around the inputs and outputs.

It works for me


Fixed bug with closed SSH modal dialog and entered but not saved SSH …

…key. https://github.com/oVirt/ovirt-web-ui/issues/448
@mareklibra please review.

This change is

@mareklibra removed unnecessary function setEventHandlers, please review.


pass col_offset through to add_message

This should fix #14

Coverage remained the same at 89.565% when pulling 116a1fb05acf2bbfb645ba177eb5ddb24dbf61b2 on col-offset into 96f4b1f7f3438735f0f22662b1e56e3936687751 on master.


[Bug] suggest() of EagleStrategyDesigner will raise AttributeError: 'float' object has no attribute 'flatten'

My search space has two float parameters. When I use suggest() of EagleStrategyDesigner, I receive an AttributeError: 'float' object has no attribute 'flatten'. The full error log is as follows:
Traceback (most recent call last):
  File "test.py", line 54, in <module>
    suggestion = designer.suggest(count=1)[0]
  File "anaconda3/lib/python3.10/site-packages/vizier/_src/algorithms/designers/eagle_strategy/eagle_strategy.py", line 209, in suggest
    return self._scaler.unmap(scaled_suggestions)
  File "anaconda3/lib/python3.10/site-packages/vizier/pyvizier/converters/embedder.py", line 151, in unmap
    parameters[name] = param_converter.to_parameter_values(value)[0]
  File "anaconda3/lib/python3.10/site-packages/vizier/pyvizier/converters/core.py", line 697, in to_parameter_values
    return [self._to_parameter_value(v) for v in list(array.flatten())]
AttributeError: 'float' object has no attribute 'flatten'

I think it is because value parameter is considered as ndarray type, as annotated in to_parameter_values function in line 692 of vizier/pyvizier/converters /core.py. But the value of the parameter is actually a float.

Can you please past the code to replicate your setup?

Thanks! This will be fixed on the next release!


missed an instance of cncf import

not sure how this was missed. might have been causing our build crazyness.

LGTM


Do not overscroll

If scrolling to a section would scroll the ListView further than normally possible, prevent this and scroll to the maximum possible y-coordinate instead.

This should have been fixed with<PHONE_NUMBER>884ff99fe993396cb90e0f35446701


bundle validate - service account name cannot match service account defined for deployment spec in CSV

Bug Report
What did you do?
When running
operator-sdk bundle validate ./bundle
or by using the Makefile
make bundle
the validation fails when having a service account defined which needs to exist in order to run a deployment.
Our setup consists of the deployment for the Operator itself and an additional deployment for a mutating webhook.
Since the webhook needs a separate service account for running properly we create it in our manifests and reference it for the kustiomization files.
When having that SA defined in the manifests and using it in the deployment the bundle validation fails with the following error msg:
ERRO[0000] Error: Value <service_account_name>: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV
Environment
Operator type:
/language go
operator-sdk version: "v1.12.0",
commit: "d3b2761afdb78f629a7eaf4461b0fb8ae3b02860",
kubernetes version: "v1.21",
go version: "go1.17",
Additional context
Example repo here:
https://github.com/Dynatrace/dynatrace-oneagent-operator

The issue still does not seem to be fixed
https://github.com/open-telemetry/opentelemetry-operator/pull/450
~/projects/opentelemetry/opentelemetry-operator(bump-operator-sdk*) » operator-sdk version                                                                                1 ↵ ploffay@fedora
operator-sdk version: "v1.13.1", commit: "1659ab58a073999463e6dcdf18bdc359a315e091", kubernetes version: "1.21", go version: "go1.16.8", GOOS: "linux", GOARCH: "amd64"
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/projects/opentelemetry/opentelemetry-operator(bump-operator-sdk*) » operator-sdk bundle validate ./bundle                                                                                ploffay@fedora
ERRO[0000] Error: Value opentelemetry-operator-controller-manager: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/projects/opentelemetry/opentelemetry-operator(bump-operator-sdk*) »t spec in CSV
make: *** [Makefile:219: bundle] Error 1

The files of the above project is:

https://github.com/open-telemetry/opentelemetry-operator/blob/43904c41a3ff6e7863a8[…]dle/manifests/opentelemetry-operator.clusterserviceversion.yaml
https://github.com/open-telemetry/opentelemetry-operator/blob/43904c41a3ff6e7863a8[…]dle/manifests/opentelemetry-operator.clusterserviceversion.yaml
https://github.com/open-telemetry/opentelemetry-operator/blob/2f1df9ac09144abaf630[…]pentelemetry-operator-controller-manager_v1_serviceaccount.yaml

@estroz since you check out and solve the issue https://github.com/operator-framework/operator-sdk/pull/5282 could you please give a hand on this one?
Re-opening this one for we are able to check.

does that mean that the mentioned bundle failure is valid/expected and therefore not a bug?

@dirgim it was a bug that was fixed in v1.13.1

I don't get why it should be removed. After removal it is referenced from other objects via serviceAccountName: opentelemetry-operator-controller-manager

@pavolloffay adding to what @varshaprasad96 said above, OLM creates this service account (and any other referenced in your CSV's deployment spec/permissions) for your operator, so there's no need to include its manifest.

Crosslinking this comment here, because after removing SA manifests from the bundle, OLM didn't create service accounts and our app failed to get installed.


Add ci workflow

Description of change
Contributes to https://github.com/meroxa/product/issues/301
(once we have this one running, we should safely remove CircleCI)
Type of change

[ ]  New feature
[ ]  Bug fix
[x]  Refactor
[ ]  Documentation

Closing for now to signal we're not actively looking into this. I'll revisit this shortly.


Push Google.Cloud.DevTools.Common 1.0 or untag it

(This is a "middle of the night" worry that I need to address first thing on Monday morning; it's a placeholder to avoid me forgetting.)
We've got a release tag for Google.Cloud.DevTools.Common v1.0, but no corresponding nuget package.
We should only be bumping version numbers as part of the release process - so the time between "tag created" and "package released" should be very small.
There have been commits to the source code since the tag - we need to review those and see whether or not they should be in a release of the package. If not, and if everything else is ready, we can build and release 1.0. Otherwise, we should remove the 1.0 tag while we work out when we do want to release 1.0.

(cc @benwulfe @chrisdunelm @Deren-Liao)

@iantalarico has some ideas about making this automated in a way that would prevent this and other holes that currently exist.
we should talk about it next week once you are back.  Do you know who owns this package?  Can this be addressed monday if no one plans on releasing before then?

Yes, it can wait until Monday. I just didn't want to forget about it, and not having any reminder over it was causing me to lose sleep. We shouldn't be releasing anything on the weekend anyway, IMO :)
Deren wrote the code, but there's no "ownership" concept of the code here... if something needs doing, anyone can do it.
I'm all for automation helping with things, but unless it would have stopped the package version from being updated in apis.json to 1.0 prematurely (which it was - that shouldn't have happened until we were starting the release) this could still have been a problem. Let's talk about it next week.

Thanks Jon for taking care of this.
I changed the version because I saw Chris' PR that change the version. Then I changed apis.json too for it would cause build failure without changing that.  I guess there is an automated process somewhere that publish the "release"?
I should have waited you or Chris that took a look at the changes. Fortunately, I think this hasn't caused big problems.
Thanks again for spotting this and fixed the problem.

No problem. The creation of a GitHub tag/release is done by tagreleases.sh which Ben did as part of a different project. Basically we only change the version number just before the release, normally. We'll get better at automating this over time...


Feature cognitive health

Description: This change adds an agent to the Azure Cognitive Services toolkit for identifying healthcare entities
Dependencies: azure-ai-textanalytics (Optional)

@baskaryan can we rerun CI/CD?

thank you @jwbeck97!


Adding abort-percentage and abort-http-status HTTP filters

Title: Add capability to control abort-percentage & abort-http-status settings using HTTP headers
Context: At Lyft, we have plans to run client-side fault injection tests. These tests would allow engineers to gain visibility into how our apps actually behave in degenerate conditions such as backend service mesh outages and connectivity loss. Some example use cases include:

Simulating client-side app behavior when a series of endpoints or service goes down.
Identifying client error-handling issues for specific request error status code.

Proposal:
Our plan is to add the following capabilities to http/fault/fault_filter.cc:

Specify a % of ingress requests that should be aborted
Specify the HTTP status code that should be returned for aborted requests

These capabilities are already available as fault injection runtime settings. We have an example of similar settings being controlled using HTTP headers - see  x-envoy-fault-throughput-response and x-envoy-fault-delay-request HTTP headers that were implemented as part of this Github Issue.
We propose to add support for the following two HTTP headers:

HTTP Header
Type
Associated Runtime Setting

x-envoy-fault-abort-percentage
int (percentage between 0 and 100)
fault.http.abort.abort_percent

x-envoy-fault-abort-http-status
int (status codes e.g. 504, 404, etc.)
fault.http.abort.http_status

Thanks for opening! Whatever we implement we should definitely do as part of the current filter filter.
My only real question is whether the percentage header as value? Couldn't the client just calculate its own percentage? Or do you want this for simplicity? I don't feel strongly about it one way or the other.

Thanks for the feedback! I updated the issue to reflect only adding to the current fault filter.
Yes, the client can calculate the fault-abort-percentage on its own. We wanted to expose this header for both simplicity (less client-side logic) and to ensure platform consistency.

Yes, the client can calculate the fault-abort-percentage on its own. We wanted to expose this header for both simplicity (less client-side logic) and to ensure platform consistency.

SGTM

we can default to 100% in case x-envoy-fault-abort-percentage HTTP header is missing.

The support for x-envoy-fault-abort-request HTTP header was added in https://github.com/envoyproxy/envoy/pull/10294.
It's x-envoy-fault-abort-request and not x-envoy-fault-abort-http-status as it was originally proposed since x-envoy-fault-abort-request seems to follow the existing HTTP header scheme names better (Envoy supports x-envoy-fault-delay-request and x-envoy-fault-throughput-response headers too).

I think that we can close this issue now. The support for x-envoy-fault-abort-request header has been already added in https://github.com/envoyproxy/envoy/pull/10294 (per my message above) and I opened a separate issue for the proposal of addition of 3 HTTP headers that would allow us to control the percentage of requests faults are injected into - the issue cab be found here https://github.com/envoyproxy/envoy/issues/10648.


Remove weight text files after linmos in spectral line flow

The channel-wise linmos procedure creates many small text files when computing the channel weights. This PR introduces a new option to remove them when linmos has completed. This required some small changes to the helper function in the linmos call.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (9946a0e) to head (515a794).

Files with missing lines
Patch %
Lines

flint/coadd/linmos.py
33.33%
16 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   60.48%   60.41%   -0.08%
==========================================
  Files          35       35
  Lines        6135     6151      +16
==========================================
+ Hits         3711     3716       +5
- Misses       2424     2435      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Component context is slow

We use an associated object to attach a bag of values to the component:
https://github.com/ocrickard/Theodolite/blob/master/Theodolite/Core/Component/InternalTypedComponent.swift#L46
This is called constantly in the component construction, layout, and mounting phase. We need to make this dramatically faster, since it's currently a major bottleneck.
One option is to expose a concrete super class, but I couldn't get the syntax to look nice using a parent class, and then we'd have to stop using protocol extensions.
Is there some way to avoid this? Should we just create local caches in the hot code paths?

Fixed by moving to a component context mixin you have to add in your component. That introduces more boilerplate, but this issue it fixed.


Additional features in complex calculations

Hey @sairish2001 was thinking about adding some additional features in complex calculations , namely:
Absolute value, Square root, complex exponentiation and also giving the Division option as a part of GSSOC' 21.
Thanks!

Great👍
Go ahead
Feel free to ask your doubts, if any
Deadline 23 March,2021 (11:59 PM IST)


Make use of tree-sitter's incremental parsing

Tree-sitter supports incremental parsing, which can be accessed via tree.edit. But {Syntax Highlighter} just parse the code and generate a new tree every time. This will lost the efficiency advantage from tree-sitter.
Also, instad of rebuild every time, buildDecor should be done incrementally.
https://github.com/EvgeniyPeshkov/syntax-highlighter/blob/5cfdaf7f4c545d49417bb157b6ea73b16fa253b0/src/extension.ts#L200

This tree-sitter extension works well on updating tree-sitter's tree:
https://github.com/georgewfraser/vscode-tree-sitter/blob/26dbce4d3c8cf42f9b7894fbff14ca6f3d97b5b8/src/extension.ts#L106

Hello @Menci,
Initially I utilized partial updates of syntax tree. But sometimes it broke highlighting after multi-line edits (formatting or copy-pasting), like for example in #19 and #20. So I've descided that it's will be better to update entire syntax tree 7495135.
I'll look into this, maybe issue is resolved and partial updates will not break highlighting. Thank you for reminding.

I'm currently working on porting your highlighter from vscode to monaco-editor, in order to have fancy highlights in the web. I built a demo here. I used tree.edit and I didn't find any issue with multi-line editing.
Maybe it's a bug in tree-sitter and already be fixed? Or maybe it's a vscode bug?

Initially I utilized partial updates of syntax tree. But sometimes it broke highlighting after multi-line edits (formatting or copy-pasting), like for example in #19 and #20.

should be reported to tree-sitter ...

So I had decided that it would be better to update entire syntax tree 7495135.

as a "less brutal" solution,
we could use incremental parsing for "small" updates (say +-5 characters per edit),
and full parse on "large" updates (more than 5 characters were changed)
i guess it should be possible to estimate the size of a changeset, as produced by monaco-editor

could be fixed in tree-sitter 0.20.1


Add

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, the collection of statistics is off by default. This means that any statistics-based optimization will not do anything.
Describe the solution you'd like
Introduce a setting for the collection of statistics, so it can be enabled by the user/consumer.
Describe alternatives you've considered
Additional context

Hit the same thing on #3774 too 😄


How to drop an unnamed unique constraint

We want to drop the uniqueness constraint on TaskV2.source - since it will become a nullable column that we can later fully remove (after we decide no "old" workflow are to be imported any more).
The schema migration seems to work with postgres, but fails with sqlite:
ValueError: No such constraint: 'uq_taskv2_source'

See https://github.com/fractal-analytics-platform/fractal-server/actions/runs/11255197263/job/31294225873

Alembic can not find the constraint when we migrate an already populated sqlite database, created before the naming convention.
This is a workaround
def upgrade() -> None:

    try:
        with op.batch_alter_table("taskv2", schema=None) as batch_op:
            batch_op.drop_constraint("uq_taskv2_source", type_="unique")
    except BaseException as e:
        if op.get_bind().dialect.name != "sqlite":
            raise e
        import sqlite3
        import logging

        logger = logging.getLogger("alembic.runtime.migration")
        logger.warning(
            f"Using sqlite, with {sqlite3.version=} and "
            f"{sqlite3.sqlite_version=}"
        )

        logger.warning(
            "Could not drop 'uq_taskv2_source' constraint; this is expected "
            "when the database was created before the naming convention "
            "was added."
        )
        logger.warning(
            "As a workaround, we recreate the constraint before dropping it."
        )
        with op.batch_alter_table("taskv2", schema=None) as batch_op:
            batch_op.create_unique_constraint("uq_taskv2_source", ["source"])
            batch_op.drop_constraint("uq_taskv2_source", type_="unique")

def downgrade() -> None:
    # ### commands auto generated by Alembic - please adjust! ###
    with op.batch_alter_table("taskv2", schema=None) as batch_op:
        batch_op.create_unique_constraint("uq_taskv2_source", ["source"])


mhz16: Initial implementation

This library implements support for the MHZ16 CO2 sensor.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>Signed-off-by: Zion Orent<EMAIL_ADDRESS>

Thanks! Merged and closing.


Add gss as NativeFramework on OSX to support System.Net.Security.Native.a linking

When using features from CoreFX that rely on System.Net.Security.Native.a, the 'gss' Framework needs to be linked in on OSX.
I'm not sure if this should go here automatically, but I guess there shouldn't be any downsides to providing the Framework link if it isn't used.

@dotnet-bot test Windows_NT Debug and CoreCLR tests please


Embedded replicas encryption test

When run with:
cargo test -F encryption --package libsql-server --test tests embedded_replica::embedded_replica_with_encryption

Fails with:
running 1 test
2024-03-04T13:28:35.019664Z ERROR tests::embedded_replica: sqlite error 21: API call with invalid database connection pointer
2024-03-04T13:28:35.019716Z ERROR tests::embedded_replica: sqlite error 21: misuse at line 180340 of [17129ba1ff]
2024-03-04T13:28:35.599894Z ERROR tests::embedded_replica: sqlite error 1555: abort at 15 in [INSERT INTO user (id) VALUES (1), (1);]: UNIQUE constraint failed: user.id
2024-03-04T13:28:35.604323Z ERROR tests::embedded_replica: sqlite error 21: API call with invalid database connection pointer
2024-03-04T13:28:35.604336Z ERROR tests::embedded_replica: sqlite error 21: misuse at line 180340 of [17129ba1ff]
2024-03-04T13:28:35.762028Z ERROR tests::embedded_replica: sqlite error 11: database corruption at line 96148 of [17129ba1ff]
2024-03-04T13:28:35.762057Z ERROR tests::embedded_replica: sqlite error 11: statement aborts at 4: [] database disk image is malformed
2024-03-04T13:28:35.762071Z ERROR tests::embedded_replica: sqlite error 11: database disk image is malformed in "PRAGMA journal_mode='WAL'"
2024-03-04T13:28:35.765014Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /private/var/folders/_y/nj5hcsh93l12tmsszxgx7ntr0000gn/T/.tmp9VBWrV/dbs/foo/data
2024-03-04T13:28:35.766108Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /private/var/folders/_y/nj5hcsh93l12tmsszxgx7ntr0000gn/T/.tmp9VBWrV/dbs/foo/data
2024-03-04T13:28:35.767147Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /private/var/folders/_y/nj5hcsh93l12tmsszxgx7ntr0000gn/T/.tmp9VBWrV/metastore/data
test embedded_replica::embedded_replica_with_encryption ... FAILED

failures:

---- embedded_replica::embedded_replica_with_encryption stdout ----
thread 'embedded_replica::embedded_replica_with_encryption' panicked at libsql-server/tests/embedded_replica/mod.rs:283:15:
called `Result::unwrap()` on an `Err` value: Replication(Injector(Sqlite(SqliteFailure(Error { code: DatabaseCorrupt, extended_code: 11 }, Some("database disk image is malformed")))))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    embedded_replica::embedded_replica_with_encryption

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 52 filtered out; finished in 0.75s

error: test failed, to rerun pass `-p libsql-server --test tests`

You can see in the CI of this PR:
        FAIL [   1.078s] libsql-server::tests embedded_replica::embedded_replica_with_encryption

--- STDOUT:              libsql-server::tests embedded_replica::embedded_replica_with_encryption ---

running 1 test
2024-03-04T13:41:36.059349Z ERROR tests::embedded_replica: sqlite error 21: API call with invalid database connection pointer
2024-03-04T13:41:36.059414Z ERROR tests::embedded_replica: sqlite error 21: misuse at line 180340 of [17129ba1ff]
2024-03-04T13:41:36.787345Z ERROR tests::embedded_replica: sqlite error 1555: abort at 15 in [INSERT INTO user (id) VALUES (1), (1);]: UNIQUE constraint failed: user.id
2024-03-04T13:41:36.795702Z ERROR tests::embedded_replica: sqlite error 21: API call with invalid database connection pointer
2024-03-04T13:41:36.795732Z ERROR tests::embedded_replica: sqlite error 21: misuse at line 180340 of [17129ba1ff]
2024-03-04T13:41:37.110236Z ERROR tests::embedded_replica: sqlite error 11: database corruption at line 75586 of [17129ba1ff]
2024-03-04T13:41:37.110325Z ERROR tests::embedded_replica: sqlite error 11: statement aborts at 4: [] database disk image is malformed
2024-03-04T13:41:37.110369Z ERROR tests::embedded_replica: sqlite error 11: database disk image is malformed in "PRAGMA journal_mode='WAL'"
2024-03-04T13:41:37.113899Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /tmp/.tmpQDqhpr/dbs/foo/data
2024-03-04T13:41:37.114704Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /tmp/.tmpQDqhpr/dbs/foo/data
2024-03-04T13:41:37.115352Z ERROR tests::embedded_replica: sqlite error 28: file unlinked while open: /tmp/.tmpQDqhpr/metastore/data
test embedded_replica::embedded_replica_with_encryption ... FAILED

failures:

failures:
    embedded_replica::embedded_replica_with_encryption

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 53 filtered out; finished in 1.06s

--- STDERR:              libsql-server::tests embedded_replica::embedded_replica_with_encryption ---
thread 'embedded_replica::embedded_replica_with_encryption' panicked at libsql-server/tests/embedded_replica/mod.rs:289:15:
called `Result::unwrap()` on an `Err` value: Replication(Injector(Sqlite(SqliteFailure(Error { code: DatabaseCorrupt, extended_code: 11 }, Some("database disk image is malformed")))))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

   Canceling due to test failure: 3 tests still running


Test please ignore. ywdlam

Test please ignore. ywdlam

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.naknikim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature/docker image

Closes #11

Dockerfile had been tested and worked well locally.
Github workflow will use Dockerfile to automatically build the image and publish it on Github (https://github.com/orgs/Unity-Developer-Community/packages).
Only issue is that we need to find a way to send custom to the bot.
Solutions:

Stop using JSON and instead use ENV variables.
Have the config file be read somewhere like in /var/config/udcbot.settings.json and use a mounted volume to provide the file.

Checking https://hub.docker.com/_/nginx which have the same problematic as us, they use volumes to share config between the host and the container.
That seems a very good and easy solution.


Improve testing framework and existing test coverage

OMF v1 library included some tests, but they were minimal and tacked on at the end. These should be updated and improved so feature development for v2 can follow test-driven development practices easier.

See #63


Add perf tests for newly created/updated functions to_timestamp and make_date

Is your feature request related to a problem or challenge?
Related to

pull #9040 (https://github.com/apache/arrow-datafusion/pull/9040#discussion_r1471926068) and issue #9024
pull #8886 and issue #5398

Describe the solution you'd like
add perf tests using the existing perf test framework.
Describe alternatives you've considered
No response
Additional context
No response

closing, tests merged.


numerics error when training：tensorflow/core/kernels/check_numerics_op.cc:185] abnormal_detected_host @0x7fe33cd1f300 = {1, 0} error occur

Numerics error happens frequently during training. Is there any solutions except catching this error in your code？Could you please provide the version of your CUDA, cudnn, and other packages needed for this project？Thanks a lot.

Have you slove these problems?what the version of tensorflow?

Have you slove these problems?what the version of tensorflow?

same question

same question

same question. Do you solve it ? @sywh @havefunbb @cyjouc @FuxiCV


Pass dsym_imports to apple_dynamic_framework_import in xcframeworks

For vendored frameworks distributed as xcframeworks consumers might want to also propagate pre-generated .dSYM files.
This is a valid attribute we were not populating in apple_dynamic_framework_import.

FYI holding this while I investigate a different issue and might be easier to commit the fix here as well

Resolved here: https://github.com/bazel-ios/rules_ios/pull/504