ABAP highlighter, added keywords

(Original issue 1227 created by jorgt on 2016-04-07T09:46:57.271378+00:00)
Hi,
Cataloguing some missing things in the ABAP lexer as I was writing an article on string expressions. //edit: I'll try to fix and submit a pull request sometime. In the meantime, cataloguing some missing words:

FIELD-SYMBOL
REFERENCE INTO.
expressions: { my_variable }
String literals: |string| and `string`.
embedded expressions like |my age is { my_age * 10 }|
String chaining operator: '&&'
String expressions with formatting options: |{ my_variable CASE = UPPER }|.
Literal operator: &.
CALL TRANSFORMATION ... RESULT XML DATA(xml).
find options: FIND REGEX, RESPECTING CASE, IGNORING CASE, MATCH COUNT, MATCH OFFSET, MATCH LENGTH, SUBMATCHES,

Some of these look tricky.
Thanks for adding ABAP.

(Original comment by jorgt on 2016-04-07T11:00:18.685705+00:00)
Not sure how to add my_string = | string { variable CASE = UPPER }|.. Needs to exclude the stuff between curly brackets but include everything else between pipes (or backticks). Suggestions welcome :-)

(Original comment by birkenfeld on 2016-04-14T06:21:05.641829+00:00)
This could be solved with dedicated lexer states.

(Original comment by schferbe on 2017-01-10T11:44:36.843536+00:00)
Some of these should be fixed in pull request #689

(Original comment by schferbe on 2017-01-19T08:44:03.634484+00:00)
I updated my pull request #689 to include all your suggestions. Would be nice if someone could take a look at it. The pipe operators I solved with this tiny regex:
#!python

(r"([\|\}])([^\{\}\|]*?)([\|\{])", bygroups(Punctuation, String.Single, Punctuation)),

So it's basically a String started by } or | and ended by { or |.


Hotfix: Webpack config directory

Pull Request Test Coverage Report for Build 30

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 25:
0.0%

Covered Lines:
29

Relevant Lines:
29

💛  - Coveralls


[create] update snapshots doesnt scaffold test files

The update snapshots command in create doesn't seem to scaffold test files for page-one and page-main:

Running the actual generator itself with either npm init @open-wc or npm run start (inside the project) does scaffold these files:

EDIT:
seems to be a problem with the scaffoldFilesFor flag when running the generator itself, see:
npm run build && node ./dist/create.js \
  --destinationPath . \
  --type scaffold \
  --scaffoldType app \
  --features linting testing demoing building \
  --buildingType rollup \
  --scaffoldFilesFor testing demoing building \
  --tagName scaffold-app \
  --writeToDisk true \
  --installDependencies false

see also #1040 which is tangentially related

Also see #966

Was this fixed with https://github.com/open-wc/open-wc/pull/966?


Refactor rng state so that simulation classes maintain internal rng

As discussed in https://github.com/quantumlib/Stim/pull/346 and https://github.com/quantumlib/Stim/pull/352, we want to have simulation and sampling classes own their rng. This impacts FrameSimulator and TableauSimulator. DemSampler already maintains its own rng. Fix for TableauSimulator will be in https://github.com/quantumlib/Stim/pull/346 and fix for FrameSimulator will be in the PR for https://github.com/quantumlib/Stim/issues/306.

I think there is a non trivial decision to make here. Do we want our random numbers generated via mersenne_twister_engine( result_type value ); or mersenne_twister_engine( Sseq& s );?
Seeding with result_type values is easier to implement because we are just passing around a 64 bit value, and can initialize our std::mt19937_64 during simulation constructors.
Currently, we are using mersenne_twister_engine( Sseq& s ); which adds entropy to the seeds themselves. If we want to keep doing this and have the simulation classes own their RNG, then we are going to need to either one of two things.

pass around std::mt19937_64 objects directly. I don't think this is ideal, since they are implemented like this: struct { result_type _M_x[state_size]; size_t  _M_p;}. Everything is allocated on the stack. This means that every time we need to pass a std::mt19937_64 we need to do a 2.5kB copy which isn't ideal. If instead the state was on the head, we would at least be able to move them around and only pay the cost for copying a pointer.

Pass around a reference to a std::seed_seq (or maintain one globally :sweat_smile:). This feels the same as passing around references to std::mt19937_64  objects anyway (although, cheaper).

On a more philosophical level, i'm not really convinced we need to use std::seed_seq for scientific applications. Without coupling with an external information source, there is no way to distinguish between a good pseudorandom number generator and a real entropy source. Since we are doing physical simulations, we don't really care if someone is able to "crack" our generator.

We can use std::unique_ptr if we need to pass the generator around a lot and want to have cheap move semantics. In general I would expect the generator to be created with the simulator, so there wouldn't be much passing around.
Keep in mind most of these simulators allocate a simd_bit_table and the minimum size of that thing is 256x256 bits = 8 KiB. A 2.5KiB copy at initialization is no big deal. We can try to arrange things so that the compiler is able to figure out it can do construction in-place with no copying, but even if it doesn't recognize that it's a negligible cost compared to the actual simulations. Like, taking a million shots from a distance 21 surface code run for 21 rounds will produce a terabyte of data. We don't have to care about an extra kilobyte of copying during setup in that context.

yes, that makes a lot of sense. I was overthinking the amount of copying required. Easy to have it so that the Constructors copy and all associated static functions take references.

removing rng sharing for TableauSimulator breaks TableauSimulator.correlated_error, but everything else is fine!

hmm, not exactly sure what would be best approach for handling methods like PauliString::random, other stabilizer randomization methods and the corresponding python classes. Do we want to initialize a new std::mt19937_64 every time one of those static methods is called?

One-shot methods should still take a reference. When calling them from python, use an externally seeded RNG.

Anyway, @viathor has dibs on this, since he got the ball rolling with exposing rng to the TableauSimulator python object. Thanks for all the discussion about it! Very informative


chore: remove support for |- as an alternative to ⊢

This causes inconveniences in mathlib, because Lean parses |-a| incorrectly
the Zulip thread (note: doesn't have much discussion yet)

@fpvandoorn It is fine to remove |-, but could you please add some ASCII alternative for ⊢ ? See Sebastian's comment in the Zulip thread.

Ok, I'll do that.

I think this is good to go. I added a test that fails on current master.


Assign user to user groups in cognito

Currently configuring commands that have to be run through lambda.

Stuck on same error.


[SB-1626] Add more metadata-related functionality

Round out the CompatibleOgmiosAuxiliaryData functionality, making it fully JSON and DynamoDB-compatible.

This PR isn't strictly necessary. I just figured I should be a good steward and get everything up to par with the other compatibility structs.


feat(subnav): add <rh-subnav>

What I did

Add <rh-subnav>
Closes #703

Todo

[x] finalize styles
[x] implement roving tab index
[ ] add spec tests
[ ] add changeset

Testing instructions

See deploy preview demo
Test in different browser resolutions (ie mobile)

Reviewer Notes
Ensure correct token usage, and please look for any accessibility issues.

This needs a changeset

@zeroedin Is part of this PR to add rh-sub-nav to ux dot?

@zeroedin Is part of this PR to add rh-sub-nav to ux dot?

if you mean "implement the element page IA changes using sub-nav" then no, that's https://github.com/RedHat-UX/red-hat-design-system/pull/638
if you mean "add a new component page for sub nav" then also no, it doesn't manually add a new docs page, however, once this lands and work continues on #638, we'll eventually move all the component pages from /docs/components/**/*.njk to /elements/*/docs/*.md


ngOptions with “group by” show double results in IE 11

I'm noticing something weird in Angular 1.4.8 and 1.5.0 RC0 but only for IE 11.  This doesn't happen in Chrome or Firefox
I have a select box that has the following ngOptions value:
 test.value as test.label group by test.group for test in model

Because I have the group by clause, all of the options are doubled. There are some other weirdnesses with adding and removing values from model and having them not disappear from the select box as well.
I built a quick example to show what I mean
Angular 1.4.8: http://codepen.io/anon/pen/LGzRmy
Angular 1.4.7: http://codepen.io/anon/pen/LGzRJL
Html:

	<select style="height: 200px; width: 100px;" multiple ng-options="test.value as test.label group by test.group for test in model" ng-model='selected'></select>
	<select style="height: 200px; width: 100px;" multiple ng-options="test.value as test.label for test in model" ng-model='selected'></select>

JavaScript:
angular
  .module('test',[])
  .controller('testCtrl', function($scope){

  $scope.selected=[]
  $scope.model = [
    {
      value: 'test1',
      label: 'Test 1',
      group: 'test'
    },
    {
      value: 'test2',
      label: 'Test 2',
      group: 'test'
    },
    {
      value: 'test3',
      label: 'Test 3',
      group: 'test'
    },
    {
      value: 'foo',
      label: 'Foo',
      group: 'bar'
    }]
})

Here is a picture of what I'm seeing in IE 11

Angular 1.4.7 and newer do not have this issue.

This will be fixed in 1.5.0-rc.1 and 1.4.9. Releases are next Tuesday.


updated package.json

updated package should from 11.1.1 to 11.2.1
Npm link :  https://www.npmjs.com/package/should
Repository link : https://github.com/shouldjs/should.js/releases

Thanks for the update.


Dockerhub?

Since I see that the project has changed maintainers, will the aacebedo version be made available on Dockerhub?

That's the case :)
https://hub.docker.com/r/aacebedo/dnsdock/


New "outputCapture" node2 launch config prop warns "is not allowed"

Needs to be added to the config registration in vscode-node-debug

We could add to the description that this is only supported for "inspector" protocol.


Add babel plugin rewire

Swapping out rewire for babel-plugin-rewire to get ES6 module support.
Also updated copyrights from Cyan -> Ciena

:+1:

I've changed the coveralls setting to require a decrease of 0.1% before failing the test.


invalid timestamp error in iphone login

EADERS
flutter:   {connection: keep-alive, date: Tue, 12 Sep 2023 06:49:14 GMT, content-length: 46, strict-transport-security: max-age=15768000; includeSubDomains, access-control-expose-headers: CB-Token-ExpirationDate, Date, content-type: application/json; charset=utf-8, server: nginx/1.25.0}
flutter: BODY
flutter:   {"errors":{"timestamp":["invalid timestamp"]}}
flutter:
flutter: Login error ResponseException: 422: {"errors":{"timestamp":["invalid timestamp"]}}
flutter:   POST https://api.connectycube.com/session
flutter: HEADERS
flutter:   {Content-type: application/json, ConnectyCube-REST-API-Version: 0.1.1, CB-SDK: Flutter 2.8.0, CB-Token: }
flutter: BODY
flutter:   {"application_id":"7266","auth_key":"cKYHfvnvsHqX6JX","nonce":"620887497","timestamp":"1696748323","signature":"4480f623a7f9f332f64a965572c429235d66aa11","user":{"login":"Richa","password":"Brain@2023"}}
flutter:   {"errors":{"timestamp":["invalid timestamp"]}}
@TatankaConCube , please tell me how to resolve this issue

Got u Thanks @TatankaConCube

@TatankaConCube, What if we users has to continue with custom timezone only? there is no other way?

because it is a blocker for us

unfortunately, we can't disable it on the shared server because it is one of the parts of the security system. this config can be changed only on the dedicated server

@TatankaConCube what do you mean by dedicated server ?  should we install connectycube on our server?

you have this option, but it costs some money, you can contact our sales team<EMAIL_ADDRESS>for more details. the basic pricing provided here

@TatankaConCube  Retention policy , can u explain me a bit?  in ur plans

what do you mean? this is the server-specific config and we can't change it for all users

no i didnt mean that.

@TatankaConCube  , with custom time zone i am not getting error in andorid but in iphone , so why is that? can we connect for this via call today or tomorow ? we have few queries

@TatankaConCube  , let me know also can u explain me in detail why custom time is issue for u guys?

unfortunately, I don't have this info, it is the server-side decision and we on the client side just accept this fact. the back end has a long history and I suppose it was necessary due to the requirements of that time


Can't resolve 'p5.js-speech/lib/p5.speech in '.../node_modules/voxlens/dist'

Currently when trying to utilize voxlens anywhere in a React project, specifically with this import statement import voxlens from "voxlens" I am unable to actually utilize it. I keep being met with the following error: Can't resolve 'p5.js-speech/lib/p5.speech in '.../node_modules/voxlens/dist'.
I've attempted to install various p5 libraries, but to no help. Was wondering if this was a known issue, if I've made a mistake, or if there's a work-around for it?

@aleenaloves thanks for reporting the issue. fixed via https://github.com/athersharif/voxlens/commit/447b7b5d86d9a3b5b7be7896c02e3480e100f122 and released in https://github.com/athersharif/voxlens/releases/tag/1.2.0. please update the voxlens version in your package.json file to 1.2.0 and run npm i to update the node modules.

Thank you! That got rid of the error I was seeing before, but now i'm running into a new issue. This probably has to do with a mistake on my part in how to implement the voxlens feature.
Currently i'm using this library for ChartJS (https://react-chartjs-2.js.org/) - all this should be doing is taking care of the canvas creation and handling, so it shouldn't cause issue with it being used with voxlens.
This is my code for initiating the voxlens:
voxlens(
    "chartjs",
    document.getElementById("chart"),
    MapDataToMappedData(graphData),
    voxlensOptions
  )

This is my code for the voxlensOptions:
{
    x: "month",
    y: "chickens",
    title: "number of chickens saved by month"
  })

This is what my MappedData looks like:
[{
    "month": "Jul",
    "chickens": 6
}, ...]

And this is the error i'm currently getting:

I'm currently messing with it on my end as well, but since it had to do with the p5.js library, i didn't want to rule out anything that may have been changes from this PR as well.

@aleenaloves: three quick things:

can you share the html/jsx where you're calling the element?
are you able to share the code with me somehow? i can take a quick look at the setup and summarize it here for anyone else running into the same issue.
have you taken a look at the examples? (https://github.com/athersharif/voxlens/tree/main/example)

thanks, that's helpful! if you're able to share the repo, i can dig deeper into it. also, as a quick check, can you double check to see if the id prop on Graph is being passed on to the underlying component?

Thank you Ather! What ended up being the issue was that the canvas was being drawn after the voxlens initialization, so it didn't have a chart to grab onto. Was able to fix it - my fix was quite hacky, but it worked in my case with the library i was using. Pasting here if it helps you with other people in the future - and thanks again for all your help :)


Hit the API

I use the API to create a new game with my chosen name.
Make sure that you saved the ID of your game that will be returned by API.
I implement the "Refresh" button that will get all scores for a game created by me from the API (receiving data from the API and parsing the JSON).
I implement the form "Submit" button that will save a score for a game created by you (sending data to the API).
I use arrow functions instead of the function keyword.
I use async and await JavaScript features to consume the API.

@IngDavidTM Hi! Can you help me please I tried a lot but all in vain... If you will help me I will be thankful to you.

@IngDavidTM Hi! Can you help me please I tried a lot but all in vain... If you will help me I will be thankful to you.

Hi @Ashnaali3255, I noticed that you are not adding the code that the first game sent to you in the URL. For example instead of using this https://us-central1-js-capstone-backend.cloudfunctions.net/api/games/ you should use https://us-central1-js-capstone-backend.cloudfunctions.net/api/games/4tfml0QLmgKTloHBYIf5/scores/'
Here  you can find an example of what I did in my Leaderboard

@IngDavidTM  where i get this link from "4tfml0QLmgKTloHBYIf5/scores/"???

@IngDavidTM where i get this link from "4tfml0QLmgKTloHBYIf5/scores/"???

You should generate it only once using the information from the API

In the example that I sent to you, I did it in setNewGame.js

@IngDavidTM Thank you so much. It really means a lot.


does not write extension config file on darwin

using darwin and filesystem storage, gocfl does not create the folders necessary to write extension config

seems to be a problem with subfilesystems on any platform

extension SetFS with create flag for init


Refactor pihole integration

Breaking Change:
This change will require existing configuration for the pi_hole component to be split into configuration level and sensor platform level
Description:
Refactors the pi_hole component from a single sensor to an integration with a sensor platform. This allows services, switches, and possibly other entities to be added to the integration in a future pull request.
Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10097
Example entry for configuration.yaml (if applicable):
pi_hole:
  host: pi.hole

sensor:
  - platform: pi_hole

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Notes for reviewer: This change is intended to lay the ground for future functionality i intend to add to the integration. shortly after approval. This change itself introduces no new functionality to the integration.

You can use discovery to setup sensor from component without need a config for this

Quick update: I'm still working on working out the tests portion of this change. My day job has been demanding this past week

@fabaff @balloob @MartinHjelmare @pvizeli I believe I have addressed all the concerns raised

@MartinHjelmare Requested changes have been made and are ready for re-review

Can be merged when build passes.

Please update the config example and breaking change paragraph in the PR description. Please describe briefly what changed and what the user needs to do to cope with the breaking change.

We don't require a sensor platform config after this PR. We set up the sensor platform via discovery from the pi_hole component module. I've updated the breaking change paragraph.


Could someone explain to me how i'm supposed to run it. I have Mongo setup and i have Node.js. I'm confused on to how to run it on commands. I have config setup. Please and thank you.


Integration Test - Release - 2021/10/03 22:07:52

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign PRMergerTest2

#reassign NonAllowedUser

#please-close

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.


Add --sync-exif option to push changes to exif without updating Photos

Something I have done with a lot of photos is to tweak the time because the internal clock was off.
This makes me wonder whether options like push-Photos-time or push-Photos-zone might not be useful. In this case the exif data would be changed to match what's in Photos without changing the Photos database at all.
Along with this a report that showed where the exif data differed from the Photos data would be great.
Originally posted by @Jmuccigr in https://github.com/RhetTbull/photos_time_warp/discussions/13

It might be better to have optional bidirectional sync, e.g.:

--push-exif [all|datetime|timezone]
--pull-exif [all|datetime|timezone]


API Key Environment Variable doesn't behave as expected in Python

This is my first time interacting with this particular library, and I'm still learning about API's, so please pardon my ignorance.
If I use Postman, I'm able to interact with the Dashboard API without issues. When using Python, the environment variables don't work as expected.
Development Environment

Dell Inspiron Laptop
Ubuntu 20.04 - fresh install
Python 3.8
VSCode
Postman
bash for shell, using the default terminal with Ubuntu

Expected behavior

Exporting an environment variable within the terminal, and validating it from the output of the env command, should result in the variable being passed through to the instantiated object via the os.environs.get() method, which is present in init.py as witnessed here:

Actual behavior

Environment variable is not passed into the object, resulting in a 401 'Invalid API Key' error
This behavior is present whether through the IDE (VSCode), executed from a terminal or directly through the interactive Python interpreter.

Steps to fix
Use one of several methods to manage the API token

Export the variable in the shell's .bashrc file and use os.environ.get(). --- This shouldn't be required as the code is already present in the init, so this is duplicate effort
Leverage the python-dotenv library. This involves creating a .env file in the same directory as the code, adding it to .gitignore and adjusting file permissions accordingly to secure access to only the user. -- Secure, but inconvenient
Manually defining the API token into the code as plaintext -- least secure, most convenient
Write a separate bash script to handle managing the API token -- requires additional bash scripting knowledge above and beyond Python and shouldn't be necessary

Requested response from developers

Can the documentation be updated to reflect the most preferred method, or clarify that additional steps are needed to manage the environment variable? The current documentation is sparse and simply assumes that exporting will work without any further steps.

I'm not able to reproduce this on Ubuntu or Windows. Do you have any other
steps to reproduce?
On Thu, Mar 11, 2021 at 10:04 AM Kadar Anwar @.***>
wrote:

This is my first time interacting with this particular library, and I'm
still learning about API's, so please pardon my ignorance.
If I use Postman, I'm able to interact with the Dashboard API without
issues. When using Python, the environment variables don't work as expected.
Development Environment

Dell Inspiron Laptop
Ubuntu 20.04 - fresh install
Python 3.8
VSCode
Postman
bash for shell, using the default terminal with Ubuntu

Expected behavior

Exporting an environment variable within the terminal, and
validating it from the output of the env command, should result in
the variable being passed through to the instantiated object via the
os.environs.get() method, which is present in init.py as witnessed
here:

[image: Screenshot from 2021-03-11 12-54-21]
https://user-images.githubusercontent.com/11323060/110832108-f09d9180-8268-11eb-99e9-3ea23febf11c.png
Actual behavior

Environment variable is not passed into the object, resulting in a
401 'Invalid API Key' error

Steps to fix
Use one of several methods to manage the API token

Export the variable in the shell's .bashrc file and use
os.environ.get() this shouldn't be required as the code is already
present in the init, so this is duplicate effort
Leverage the python-dotenv library. This involves creating a .env
file in the same directory as the code, adding it to .gitignore and
adjusting file permissions accordingly to secure access to only the user. secure,
but inconvenient
Manually defining the API token into the code as plaintext lease
secure, most convenient
Write a separate bash script to handle managing the API token

Requested response from developers

Can the documentation be updated to reflect the most preferred
method, or clarify that additional steps are needed to manage the
environment variable? The current documentation is sparse and simply
assumes that exporting will work without any further steps.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/meraki/dashboard-api-python/issues/150, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA5EUKXZK6CIAHB5S75OV5TTDDZ3FANCNFSM4ZAYFFUA
.

Hi there,
I'm not entirely sure what happened, but while trying to reproduce this for a friend today at work, I couldn't re-create the behavior. I spun  up a fresh Ubuntu VM to see if I can reproduce it, but I can't. I think what may have happened is the environment variable wasn't being read into VSCode until I restarted VSCode. I may have also re-sourced my .bashrc file, which probably made that variable "active" within the environment, allowing VSCode to then retrieve it and pass it along into the API call.
If this happens again, I will be sure to detail exactly what I did to produce the error. Thank you.


Include resource metadata in audit log

Will help with https://github.com/Innablr/revolver/issues/288

This PR produces audit.csv logs like (reasons removed for brevity):
TIME,ACCOUNT_ID,ACCOUNT_NAME,PLUGIN,DRIVER,TYPE,ID,ACTION,STATUS,REASON,METADATA
2024-04-03T07:22:43.067Z,554096786507,innovation,powercycleCentral,ec2,ec2,i-05b5bb371c57ad174,stop,pretend,"...",{}
2024-04-03T07:22:43.067Z,554096786507,innovation,powercycleCentral,ec2,ec2,i-072c8e335cb9f8f0b,stop,pretend,"...",{}
2024-04-03T07:22:43.067Z,554096786507,innovation,powercycleCentral,ec2,ec2,i-0930fe0f7516764e2,stop,pretend,"...",{}
2024-04-03T07:22:43.067Z,554096786507,innovation,powercycleCentral,ec2,ec2,i-06e62ca5472d8ba12,stop,pretend,"...",{}
2024-04-03T07:22:43.067Z,554096786507,innovation,powercycleCentral,rdsCluster,rds,cloudsnooze-test-rds-cluster,start,pretend,"...","{""members"":[""cloudsnooze-rds-instance2"",""cloudsnooze-rds-instance1""]}"


Roll Flutter Engine from b35153d00b2e to 0eb7b109f0f2 (1 revision)

https://github.com/flutter/engine/compare/b35153d00b2e...0eb7b109f0f2
2024-02-02<EMAIL_ADDRESS>Reverts "Add the focus state related methods to the platform dispatcher" (flutter/engine#50268)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add support for sizeof(u32), sizeof(u16), etc

I have a code snippet like this where I want to find out the number of words in a buffer.
    public bool work_with_buffer(c_array<u8> buffer, u32 size)
    {
        math.unsafe_mode();

        u32 num_words = size / 4; <-- How to use sizeof(u32) instead of 4 ?

In C, I would normally use sizeof() (rather than the literal 4, but I couldn't find a way to do it. I think it would be helpful to have a way to get the size of types like u16, u32 so that we can do math with them.

Ready in next release.
We have basic support here: https://github.com/fin-language/fin/commit/06bc318c6e0bedb95474c522a84ae09cb82b2e1c#diff-7d36356b5db22267786da0c86a4c91c57798a404f44895b63a7c2a3e6922dc16
You can use it on fin integer primitive variables like this: mem.size_of(my_u8).
You can can get size of fin integer types like this: u8.SIZE
There's no support yet for getting the size of class objects. Needs some thought as it isn't cross platform. The size of a class/struct depends on compiler and architecture...
To avoid issues with sizeof() on pointers, we get a bit lazy: https://github.com/fin-language/fin/blob/5df03e6d0ad3591d9207cc669bef231c201d201f/src/test/ExSln2/c99/gen/hal_SizeOfEx.c#L18
uint8_t hal_SizeOfEx_calc_param_refs_sizes(uint8_t * a, int32_t * b)
{
    return sizeof(uint8_t /*a*/) + sizeof(int32_t /*b*/); // note generated doesn't return size of pointer
}

I think it looks OK though for now.


⚠ Samsung has degraded performance

In 94d4793, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2132 ms

Resolved: Samsung performance has improved in db7344d.


Add support for Listen It

Add support for Listen It.

Hey Anutrix, it is up to the dev of Listen It to add support for Lyrically. They need to add a broadcasts with 'com.android.music.metachanged' and 'com.android.music.playstatechanged'.


nimble/ll: Fix scanner init on HCI Reset

mempool shouldn't be initialized on HCI Reset as it may affect other
pools. Instead initialize it only on init and cleanup on HCI Reset.

requires https://github.com/apache/mynewt-core/pull/1030
should fix https://github.com/apache/mynewt-nimble/issues/46


dependabot pull requests does not starts

Hi!
Sometimes, dependabots created pr does not starts.
The webhook payload is accepted (200) but returns null
Example: https://github.com/nextcloud/viewer/pull/151

What can I do to debug this?
I'm using drone.io

:wave: hey there, per our issue template, for end-user support please use one of our support channels, such as our chatroom or our mailing list. You can also find information regarding builds not starting in this thread.


model_dropout

What is the architecture of the model for emotion detection(model corresponding to model_dropout.hdf5) or how does it work.
@juan-csv .

hi, this is the architecture of the code model, then I will upload a script to retrain the emotion detection model.
instantiate model
model = Sequential()
1 - Convolution
model.add(Conv2D(64,(3,3), padding='same', input_shape=(48, 48,1)))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))
2nd Convolution layer
model.add(Conv2D(128,(5,5), padding='same'))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))
3rd Convolution layer
model.add(Conv2D(512,(3,3), padding='same'))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))
4th Convolution layer
model.add(Conv2D(512,(3,3), padding='same'))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))
Flattening
model.add(Flatten())
Fully connected layer 1st layer
model.add(Dense(256))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(Dropout(0.25))
Fully connected layer 2nd layer
model.add(Dense(512))
model.add(BatchNormalization())
model.add(Activation('relu'))
model.add(Dropout(0.25))
model.add(Dense(num_classes, activation='softmax'))
model.summary()

Hello,Thank you so much for the detailed reply.
Can you share what are the baseline models in case of emotion detection and what to refer to find more about that

model_baseline_v1
model_v1
model_baseline_dropout
model_dropout
model_baseline_tf_learning
model_tf_learning

Again ,Thanks a lot.

At this moment I do not have enough time to organize the information about the architecture of the other models, for now you can go to https://www.kaggle.com/ashishpatel26/facial-expression-recognitionferchallenge/kernels and review other implementations for the detections of emotions.

Sure and thanks @juan-csv .


Advice on setting up a hybrid Java and Python devcontainer

I want to setup a devcontainers environment for a Django Python project.  I was curious about using the SonarLint extension.
SonarLint has a dependency on the JRE11+ being installed.
What is the best approach to take in setting up a devcontainer for this type of project?
What am I trying?
At the minute I am unsuccessfully trying to look at the following folders to try and set my own Dockerfile and devcontainer.json up.
https://github.com/devcontainers/images/tree/main/src/java
https://github.com/devcontainers/images/tree/main/src/python
This uses the mcr.microsoft.com/devcontainers/base:bullseye.  My thoughts were to copy the Dockerfile instructions as per the Java Dockerfile then trying to install Python 3.11 separately.
RUN arch="$(dpkg --print-architecture)" \
  ...

 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     && apt-get -y install --no-install-recommends python3.11 python3-pip

Which yields the following problems in the log file:
#0 5.837 E: Couldn't find any package by glob 'python3.11'
#0 5.837 E: Couldn't find any package by regex 'python3.11'

I've attached by feeble attempt at this for the devcontainer.json and docker file.
devcontainer.json.txt
Dockerfile.txt

Hi @andez2000 👋
Could you try with this Dev Container config 👇 ?
{
	"image": "mcr.microsoft.com/devcontainers/python:3.11",
	"features": {
		"ghcr.io/devcontainers/features/java:1": {
			"version": "11"
		}
	}
}

I had a play the other night.  I decided to use the Python bullseye as the base image - and install java as per the example in the repo.

    },
    "features": {
        "ghcr.io/devcontainers/features/java:1": {
            "version": "none"
        },
        "ghcr.io/devcontainers/features/common-utils:1":{
            "installZsh": "true",
            "username": "vscode",
            "uid": "1000",
            "gid": "1000",
            "upgradePackages": "true"
        },
		"ghcr.io/devcontainers/features/python:1": "none",
        "ghcr.io/devcontainers/features/node:1": "none",
        "ghcr.io/devcontainers/features/git:1": {
            "version": "latest",
            "ppa": "false"
        }
    },
    "containerEnv": {
        "JAVA_HOME": "/usr/lib/jvm/msopenjdk-current"
    },
    "overrideFeatureInstallOrder": [
        "ghcr.io/devcontainers/features/common-utils"
    ],
    "customizations": {
        "vscode": {
            "settings": {
				"python.defaultInterpreterPath": "/usr/local/bin/python",
				"python.linting.enabled": true,
				"python.linting.pylintEnabled": true,
				"python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8",
				"python.formatting.blackPath": "/usr/local/py-utils/bin/black",
				"python.formatting.yapfPath": "/usr/local/py-utils/bin/yapf",
				"python.linting.banditPath": "/usr/local/py-utils/bin/bandit",
				"python.linting.flake8Path": "/usr/local/py-utils/bin/flake8",
				"python.linting.mypyPath": "/usr/local/py-utils/bin/mypy",
				"python.linting.pycodestylePath": "/usr/local/py-utils/bin/pycodestyle",
				"python.linting.pydocstylePath": "/usr/local/py-utils/bin/pydocstyle",
				"python.linting.pylintPath": "/usr/local/py-utils/bin/pylint"
			},
            "extensions": [
                "vscjava.vscode-java-pack",
				"ms-python.python",
				"ms-python.vscode-pylance"
            ]
        }
    },
    "remoteUser": "vscode"
}

@samruddhikhandale - thanks for the info - will check it out a little more.  Does this require a dockerfile at all?

@samruddhikhandale - thanks for the info - will check it out a little more. Does this require a dockerfile at all?

@andez2000 Nope, just a .devcontainer/devcontainer.json file with the above contents.

Wow... So it does work :)  Thanks a lot
{
	"image": "mcr.microsoft.com/devcontainers/python:3.11",
	"features": {
		"ghcr.io/devcontainers/features/java:1": {
			"version": "11"
		}
	}
}

🎉 🎉
Feel free to re-open if you have any other questions!


Refactor starter and simplify deployments

Organize into platform and app config folders.
Standardize folder names and *.tfstate file names to match.
Ensure deployments are simple and can be deployed in a reasonable timeframe.

I see that the sandpit with pipelines doesn't reflect the new folder structure of caf-terraform-landingzones.
My recent try on 2106 + starter branch of the caf-terraform-landingzones-starter don't work from on devops. Pipeline reference folder like caf_foundations or caf_shared_services

Thanks


Lints, enhancements and bug fixes

Hello, great package!
I needed a couple of things so I took some time to give some love to this package.
First of all, I updated a couple of dependencies (async and vector_math) I don't think it was 100% needed, but still did it just in case the package can take advantage of any improvements done there.
Then I added flutter_lints, I thought it would help get more pub.dev points! And also solved all over 300 issues (warnings) that came with it.
Then I added a simple improvement, the column size for DataColumn2 is very helpful, but very limited to be honest, so, I added a couple of optional parameters to it.
The first one is ratio. With it you can se any custom ratio (other than the ones set for S, M and L)
The second is absoluteSize. This one is a fixed size for the width of the column, this is very useful for those columns that have small content (like just one icon representing some status like active/inactive) and you don't want it to take too much space, so a fixed size makes sense.
I also needed to fix a few other things:

#30 I found the issue, it was a simple fix
#80 This one was a hard one to find, but had a simple fix too.

All tests are passing, I'll be adding tests for the absoluteSize and ratio properties I added to DataColumn2
Have a great day!

Oh! I just remembered I also have to add documentation for https://github.com/maxim-saplin/data_table_2/pull/87/commits/a300fc86dc106704a391ef00fd4afe2e4b5c7016

Hi there! Somehow I missed you PR... And did a number of upgrades (Dart 2.17, Flutter 3.0, lints) by myself.
Could you please, close this PR, take the most recent master version and open new PRs for each of the 2 issues (#30, #80)?
Besides, I'm not quite sure what #80 is about - could you please elaborate in the issue?

Hello @maxim-saplin sure thing, I'll do that!
#80 basically happens because of this param that should be nullable, since not always we want to give a gesture to the rows, if we don't have any gesture set, there's no need to set a onSelectChanged callback, However, if you see this line you're forcing the onSelectChanged to have a callback, in the case the actual onSelectChanged from the widget is null, you force it to be () => null which can be considered a no-op and does nothing, yet, because it's not a null callback and its forced here to add an TableRowInkWell we have hover highlight regardless of the gestures we set (or not set in this case)
The fix was simple, make the onSelectChanged for the _buildDatCell method nullable and change the condition to this:
    } else if (onRowTap != null || onSelectChanged != null) {
      label = GestureDetector(
        child: TableRowInkWell(
          child: label,
          overlayColor: overlayColor,
          onTap: () {
            onRowTap?.call();
            onSelectChanged?.call();
          },
          onDoubleTap: onRowDoubleTap,
          onLongPress: onRowLongPress,
        ),

Also, when calling _buildDataCell instead of forcing the callback, make it like this:
        onSelectChanged: row.onSelectChanged != null ? () => row.onSelectChanged!(!row.selected) : null,

That ensures not only that we have an actual onSelectedChanged callback being called only when it's not null but also doesn't add an unnecessary InkWell to the Row.

Thanks! Let's move the discussion of #80 to the ticket itself. I'm still not sure what is the trouble. Regarding the nullable onSelectChanged, there might be reason why it is not so, need to investigate. What I do remember is that in the stock widgets there was no row level tap events and I had to do some tricks to have it added.
Closing this PR and waiting for 2 new PRs.


MNT: Re-render the feedstock [ci skip]

Hi! This is the friendly conda-forge-admin automated user.
I've re-rendered this feedstock with the latest version of conda-smithy (1.3.2) and noticed some changes.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).
Remember, for any changes to the recipe you would normally need to increment the version or the build number of the package.
Since this is an infrastructural change, we don't actually need/want a new version to be uploaded to anaconda.org/conda-forge, so the version and build/number are left unchanged and the CI has been skipped.
Thanks!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Need to re-render with conda-smithy version 1.3.3. Closing so that this can either be manually re-rendered or a new automated re-rendering can be generated.


Add exercise: sieve

trues(limit) instead of fill(true, limit) would work here as well. It creates a BitArray instead which uses less memory. Not really relevant for this exercise, though, but might be helpful to know.
Thanks for adding this exercise!

@SaschaMann I thought about BitArray, but went further without using it. Thank you!

Could you adjust the indentation for this one, too? Thanks!

Done! Please check it out.

Looks good, thank you.


Remove depreciated call to sendJavaScript for more recent method

I tried to apply this patch, but it looks like webView.post and webview.evalutaeJavascript are not available in the last version of cordova-android (4.0.0)

I'm using Cordova version 4.3.0 and it's working fine. This change is quite common on Cordova plugins, the same source code exists and works. Which error do you get and when ? Which Android SDK version do you have ?

My cordova version is 5.0 and my cordova-android version is 4.0.0. Note that cordova lib differs from cordova android although we use both to build for Android. The last version of cordova-android is 4.0.3, and they are developing 4.1.0 now.
My Android SDK is API 21.
You can find your cordova-android version by looking at the top of your cordova.js file in the platform project (cat platforms/android/assets/www/cordova.js | grep PLATFORM_VERSION_BUILD_LABEL works for me)

Ok i'm still using cordova-android 3.7.1 - for good reasons - but it shouldn't break the code anyway...

Yes it does.. In this commit https://github.com/apache/cordova-android/commit/087ec11e6abc61acde4e2860f8ee363f3daba578 they refractored the way the WebView is loaded, and made CordovaWebView to act as an interface.
It looks like we have to go to org/apache/cordova/engine/SystemWebView.java to find those methods... probably we could just cast CordovaWebView. getEngine() and cast it to SystemWebView?

Other official plugins use "this.cordova.getActivity().runOnUiThread(new Runnable() { ..."
see: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;a=blob_plain;f=src/android/InAppBrowser.java;hb=HEAD

Your solution still needs to use evaluateJavascript() from android.webkit.WebView

Got it!
I recently updated to Cordova 5.1.1 so i could fix this error. You should see the new commit for this pull request, the solution is coming from other official Cordova plugins. It's compiling with gradle now.

I got here from Google and don't know a thing about what this repo is about. But the last commit for Cordova 5 (3a0d5e3) doesn't make any sense. Not only you reverted back to sendJavascript, but also there's a useless check for KitKat that is not needed at all. sendJavascript is deprecated in CordovaWebView, but whether it works or not does not depend on the Android OS version.

The test for the API version is mandatory because it's the old style method for sending back JS commands. Better to leave it or it won't compile for these old devices. This commit make the JS work for all versions, this code is also used on many other cordova plugins. It could be imrproved but should still work for all devices.

@mysegfault sendJavascript does indeed compile before KitKat (but will throw an exception during plugin initialization with the last Cordova 5.1). What I mean is, why not just using loadUrl for all OS versions? I think the KitKat check is a carryover from the older code when you needed to call evaluateJavascript.

loadUrl is depreciated for security purposes, you shouldn't use this method on recent devices. I think there is now a cleaner method for what we need, by keeping the reference to the callbackContext and use the sendPluginResult method.


"Jaro Distance" and "Selection Sort" solutions

Alright, I think I'm doing this properly now. I decided to just reset my branch to the latest commit and then do a neat commit of all my files instead of the mess I had before.

Looks great! Thank you!


Magento 2 - Outdated generated code

Deployer version: 7.3.1
Deployment OS: Ubuntu 18.04

For us it often happens that the files in generated/code are outdated. It seems like these are generated on basis of the release before.
Is this a known issue? Is there any reason why https://deployer.org/docs/7.x/recipe/magento2#magentoset_cache_prefix is only part of the artifact deployment?

Ho @torhoehn
The cache_prefix is not part of the artifact deployment so you should be able to use it without artifacts. There's a couple of fixes coming in the next release of deployer though for it. We've seen occasional issues like you;ve described which is why I built the cache_prefix setup.
I'd strongly advise you check it on a staging site before deploying to a production environment though just to make sure
Like i said though, might be best to wait for the next release

@valguss Thanks for keeping us updated here.
Ah now I see that there was a change between master and latest released version. In the latest released version it depends on the variable use_redis_cache_id which is only checked during artifact deployment, but this was changed in master.

@valguss While using deployer/deployer:dev-master I receive the following error:
Error  in magento2.php on line 474:
Class "Symfony\Component\VarExporter\VarExporter" not found

Is it correct that symfony/var-exporter is a dev requirement or should this be moved to require section?
https://github.com/deployphp/deployer/blob/master/composer.json#L62

Think I had it in there but was removed. Let me add back in again


Working on extending displayz to other platforms.

Hi,
I'm working on a Rust, cross-platform (Windows, macOS, Linux/BSD) profile-based display output manager. It's event-based but also can be controlled with JSON-RPC.
displayz looks perfect for Windows, but I found myself duplicating efforts in my usage of this crate.
I thought, maybe, it might be a good idea to work on creating a generic DisplayOutput trait for displayz, that, when combined with the target_os attribute, can provide platform-specific implementations of the display outputs.
To give you an idea of how I picture a DisplayOutput trait, here's some code I wrote, and then realized I was duplicating efforts, for automon:
pub type Resolution = (usize, usize);
pub type Position = (usize, usize);

pub trait DisplayOutput {
    pub fn is_primary(&self) -> bool;
    pub fn is_active(&self) -> bool;
    pub fn get_pos(&self) -> Position;
    pub fn get_res(&self) -> Resolution;
}

I'd really like to work on adding the modern API (but also maintaining backwards-compatibility, if possible) with you, and extending the scope of displayz to macOS, Linux, and BSD.
What do you think?
Have a great weekend! :)

@michidk I've pushed my branch to my fork and created a draft PR to collab on.
I wasn't sure what API you wanted to use for #1, so I need some input before I work on abstracting it away. The abstracts are currently in crate::common. It's very barebones right now and needs documenting.
I wanted a cross-platform display output manager, and with autorandr/kanshi, I felt two configs were duplicating the same purpose. And then I thought, I dual-boot with Windows, so why not make a unified manager? Made sense to me.
The display models are vaguely similar on Linux - I don't own a Mac.

I wasn't sure what API you wanted to use for https://github.com/michidk/displayz/issues/1, so I need some input before I work on abstracting it away. The abstracts are currently in crate::common. It's very barebones right now and needs documenting.

Don't worry regarding #1. I have to investigate this first, but I think it has not changed too much.

The display models are vaguely similar on Linux - I don't own a Mac.

Then let's focus on Linux and Windows.
I added some comments to your draft PR.

Hi @shymega / @michidk
Just chiming in to say great work so far, the proposal looks nice.
Some additional input from me, i like the central trait which all os/managers share. If any of them have specific functions which is specific to that os, we could structure it like the std library has it with e.g. metadata.
I might be interested in doing the linux/x11 implementation if that is ok with you @shymega. This might be just the thing i need for my personal project :)

Also i don't know if that would be in the scope of this issue/pr, but i would also like to have a "write" api.
pub trait DisplayXXX {
    fn set_active(&mut self) -> Result<(), ...>;
    fn set_resolution(&mut self, resolution: (usize, usize))

    ...
}

Hi @shymega / @michidk
Just chiming in to say great work so far, the proposal looks nice.
Some additional input from me, i like the central trait which all os/managers share. If any of them have specific functions which is specific to that os, we could structure it like the std library has it with e.g. metadata.
I might be interested in doing the linux/x11 implementation if that is ok with you @shymega. This might be just the thing i need for my personal project :)

Thank you, I like the idea of that std trait approach. We could definitely do something like that, but the idea behind my proposal was for a deterministic API exposed on supported platforms, that doesn't require special handling. Although I suppose that is a tight requirement, so I'm not necessarily opposed to Ext traits.
With regards to Linux/X11, you can see in 043a77b, there's flags for X11 and Wayland. I'm open to you working on X11 - I can grant you access to a branch on my fork, where I can test your changes, and rebase them into the refactor branch - if that works for you.
You should be able to see the abstractions in the linux subdirectory. It would be nice to support the BSDs, but that's at another stage. I think BSDs don't use Wayland, so perhaps I should rename the linux subdirectory.

Also i don't know if that would be in the scope of this issue/pr, but i would also like to have a "write" api.
pub trait DisplayXXX {
    fn set_active(&mut self) -> Result<(), ...>;
    fn set_resolution(&mut self, resolution: (usize, usize))

    ...
}

I think it is within the scope. I would be open to having this available in the API, but maybe we should focus on the "Read" API first, then writing.

Turns out FreeBSD supports Wayland, so I've renamed linux module -> unix, and updated the cfg attrs & Cargo.
I'm currently working on Wayland support. I'm using this tool (Shikane) as a guidelines, but not all of it. It's something I took inspiration from, as well as kanshi for my display output manager.

OK, so I rebased the PR a little, gonna squash some things soon.
@michidk @Shemnei I've granted you both access to my fork as collaborators. Please let me know if you rebase on the refactor branch so I can pull those changes in.
I've got rust-analyzer working with the Wayland crate, so I can begin adding the implementation. I need some input on the common API, so it's consistent across macOS (I know that's not being worked on right now), Unix (Linux/BSDs), and Windows.
Thanks!

Sorry, haven't worked on this for a bit. I'm trying to decide on the best way to define the common API module. I'm also working on a cross-platform WM. This fits in well with displayz, automon - I'm aiming for tight integration.

Update from my end - I've recently discovered that some, but not all compositors, use a different set of APIs. I've found that wlroots has the WLR output management protocols - that's one. Then, there's KDE and GNOME. KDE have Rust bindings; haven't found any for GNOME yet.
I'm wondering if there's more upstream work that needs to happen...


Swipe Up/Down etc

Thanks for making this, it's great.
One thing I think is missing, and I don't know if you intend to add it or not, is to be able to Swipe Up/Down/Left/Right to display some sort of view.
For example, Swipe Down to show an information panel about the currently playing video.  fully interactive panel so you can change settings etc.  Just the mechanics to display the panel would be ideal. how it looks down to the developer.  Thanks

This project's intention is to just provide the VLC rendering layer to SwiftUI, not any sort of overlay.


"Feeling Lucky" Attempts to play non video files

The "Feeling Lucky" feature sometimes attempts to play non video files. This just downloads the file without playing anything. Its also possible to select a non video file to play and it hangs.

It now searches only torrents in ThePirateBay's "Video" category. This should be enough.


feat: change method of reading files

feat: change method of reading files
Fix : #89

@zqq454224016 the 2nd commit should be prefixed with feat/fix/docs... . pls refer to  https://kubebb.github.io/website/docs/contribute#pr规范


feat(triggers): introduce triggers parsing utility

Needed for tooltips / popovers as described in:
https://github.com/ng-bootstrap/core/issues/8#issuecomment-225168469

Probably should be a test to test it handling strings with newline characters appropriately as well.

Probably should be a test to test it handling strings with newline characters appropriately as well.

I don't think ng2 allows new lines in attribute values (HTML5 spec probably doesn't allow them either).

It does - I actually implemented that to fix an issue reported against lack of support against that.

@wesleycho you are right! Will add a test for newline characters case. Thnx!


oh-git

Change Summary
Git is hard, screwing up is easy, and figuring out how to fix your mistakes is impossible. Git documentation is difficult to find solutions to the thing you need to know about in order to fix your problem.
So here are some bad situations solutions.
Checklist
If you haven't fulfilled the below requirements or even delete the entire checklist, your PR won't be reviewed and will be closed without notice.
General

[x] This Pull Request is all my own work. (You'll be blacklisted if you are caught for plagiarism.)
[x] I've read CONTRIBUTING.md
[x] I've made some valid changes to the CheatSheet, and they are not just minor changes.

Changes

[x] I've read and followed the Solution Template

Note: To mark the checkbox, put an x inside the [ ] (like this: [x]).

Hi @saurabhtopthon01 , Glad to see your pr.  But we already have a git cheatsheet available.
https://github.com/aryankashyap7/CheatSheets-for-Developers/blob/main/CheatSheets/git-cheatsheet.md

Hi @saurabhtopthon01 , Glad to see your pr. But we already have a git cheatsheet available.
https://github.com/aryankashyap7/CheatSheets-for-Developers/blob/main/CheatSheets/git-cheatsheet.md

Yes I have seen it, but its content is different from what I have made a pull request for. This file contains solutions related to common git issues. So please reconsider Or if you want I can change the file name to be "git-problem-solution-cheatsheet".

@saurabhtopthon01 That sure seems a good idea. But instead of creating a new cheat sheet, you add a section to the existing git cheatsheet as Common Problems Resolution. There you can add all these changes you have mentioned here.
Once done, create a new PR, I would accept that 🙂


期待您的开源♪(･ω･)ﾉ

Sorry for the late reply, the code has been released.
Thank you for your waiting, please feel free to contact me via email since may not check the github frequently.

你好，我现在有事不在，你的信我已经收到，谢谢！


Doesn't work

Should rename the file wifi_disconnector.sh because that's all it does

The script works fine for me. Can you verify which version of macOS you are using?

I'm using MacOS 10.15, thanks for your reply

It's entirely possible that the script no longer works as intended in macOS Catalina either as a result of a change in the bash version being used or a bug in the most recent betas. Unfortunately, I have been unable to test the script with the newest versions of macOS as I'm still on Mojave but will be sure to when the public release happens later this year.
In the meantime, feel free to fiddle with the script. As the error shows, the problem seems to be a simple syntax error, so adjusting line 190 may fix the problem.

Hi there. I've been able to successfully test the script with the most recent version of macOS Catalina (10.15.1) and have not run into the same issue as you.
Would you be able to try again on the newest version of macOS? If the issue persists, I think it could be a result of the newly implemented zsh shell. If you are using the zsh shell, try switching back to bash to see if that solves your problem.

I'm getting the same error btw

Are you sure that the app works? I see only "[*] Captured beacon frame, waiting for handshake..." all the time.
I run it it under zsh and under bash, I have MacOs 12.1
While it running I turn off my phone and turn on after that in order to make handshake it. how I can debug it?

Hi @Sepuka, unfortunately I no longer actively maintain this project so I can only offer limited guidance.
As the message says, the script is waiting for a handshake to be captured using the command on line 247. If you would like to debug the sniffing stage manually, read through this blog post which goes through the capturing process step-by-step.
Either way, I would recommend checking out WiFiCrackPy which I developed as the successor to this project. The new script is much more streamlined and does not capture handshakes in the same way.


Add a test that 'rmi' works with truncated image IDs

Add a test to ensure that 'buildah rmi' works if passed a truncated version of an image's ID.  (This really should have been part of #360, but I didn't think to add it there.)

LGTM
@rh-atomic-bot r+


Address sanitizer fixes

Some memory leaks in xdg shells, rootston output and x11 backend
A use after free in wayland backend.

I'm not 100% happy with my use-after-free fix, if someone has a better idea to access the wlr_wl_pointer from the output destroy handler. At first I wanted to add another output event handler listener to the pointer itself but since the wayland backend can have many outputs and a single pointer (at least with the current design, how does it handle being started from a rootston with multiple seats?) it was more straight-forward to cleanup from output, but I'm sure this can be done better.

Did you find the leaks with an automated tool? If so, what command did you use so I can verify?

What is up with your system clock that these commits report being from December 2017?

Did you find the leaks with an automated tool? If so, what command did you use so I can verify?

I run with address sanitizer, which can be enabled with meson -db_sanitize=address, then just running the program as usual. The leaks will be displayed on stderr so it might be a good idea to redirect that to a file.

What is up with your system clock that these commits report being from December 2017?

My system clock works fine, thank you very much. The first commit was really authored on December 30 but only rebased and pushed recently with the other. The other commits are more recent. You can see the commit date with git log --format=fuller, blame github for being silly with what it displays.

:+1:


Request for ability to wrap lines or faster sidways scroll

Thanks for making this.  I have been searching for something like this for ages.
The only issue is that you need to scroll with the arrow keys to see long lines in the right-hand window. It would be nice if there was an option to wrap long lines.
If that is too difficult, could there be a faster sideways scroll; something akin to pageup/pagedown but for sideways scrolling?

You can use the scrollbar. You can also hold shift and scroll with the mouse wheel / gesture.

I have the same need，Line breaks are more convenient

I understand why wrapping is off by default for the main view, but the side view should have wrapping by default imo!


[ZEPPELIN-707]Automatically adds %.* of previous paragraph's typing

What is this PR for?
Automatically adds %pyspark in the code area after paragraph created, if previous paragraph's typing is %pyspark.
What type of PR is it?
New Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-707
How should this be tested?
unit test
Run-time checking

Zeppelin automatically adds new paragraph when last paragraph runs.
Isn't it make sense to add %.* to this auto added paragraph?

I agree with you. This commit is too hasty.
I'm so sorry. I'm looking in that.

@Leemoonsoo
I change some code. Could you mind if I request to review this?

Isn't it possible not to have any front-end code for that?
Why not just include the %.. in the empty note in the backend?

The purpose of this front-end code is to track the recent usage of the interpteter(by the users).
Okay. include the %... in the empty note.

Does this work when the user has not included %interpreter in the previous paragraph? (ie. using the default interpreter)

@felixcheung
Yes, it works.
If user doesn't any %interpreter in previous paragraphs, %..(default interpreter) will be added.
If user add %interpreter in previous paragraphs, %interpreter will be added.
e.g.)
paragraph-1 (no interpreters) -> paragraph-2 (no interpreters) -> paragraph-3 (%.. will be added.)
paragraph-1 (%sh) -> paragraph-2 (no interpreters) -> paragraph-3 (%sh will be added.)

Is there anything wrong?

@mwkang CI is failing now, you probably need to check in zeppelin-webapp what does ./grunt jshint complain about.

For me, same comment as before.
There is no need for any front-end code.

@bzz Thank you for your review.
@corneadoug Okay, I will change the code does not use a front-end code.

@corneadoug I have a question. If User doesn't run paragraph, Always add %... Because I couldn't know what is recent usage of the interpreter(by the users). Is it okay?

If we create a new empty paragraph, we should add the %.. (default, or previous).
So this should be working for: running the last paragraph of the note + adding a new paragraph

I change my code it is use only backend. I force push my remote branch. So remove previous commit.

@corneadoug
Could you review this?

@mwkang
I found 2 problems:

Content of the first line is copied instead of interpreter sign only, for example:

%md hello

Will copy  %md hello to the new paragraph, instead of %md

Default interpreter is not copied
If you type code using the default interpreter, it will add the previous paragraph interpreter sign instead.
So If you have:

Paragraph 1
%md
hello

Paragraph 2
println("Hello")

The new paragraph will have %md

@mwkang Do you have time to fix this PR?

@corneadoug
Yes, Sorry for delay.

@corneadoug
I fixed that problems.
Could you mind if I request review to you?

I'm so sorry. CI was failed.
I'll try to fix it.

@mwkang no problem
It seems some tests and selectors are broken with the new changes.
I will try the branch again and post if I find what is breaking at the same time

@corneadoug @Leemoonsoo Yeah! I passed all test.

@mwkang
Sorry for late answer, I tested again and have 2 comments:

When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead?
After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)

@corneadoug
Thank you for your comment.
I am sorry I don't understand clearly.
Could you explain more?
What is the meaning get the default interpreter from back-end and insert it instead?

I don't remember if there was a way to change the default interpreter.
But at least without config, it uses '%spark' by default, so
sc.version == %spark sc.version
In our case, if we try running
%..
sc.version

You will get a: %.. interpreter not found

@corneadoug
Oh... I don't consider about that.
Thanks for mention that,
I will fix my code.

[ ] When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead?
[ ] After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing)

@corneadoug
Hello, I have a question.
Only after running a query, the cursor go to line end in new paragraph.
If It is added manually, the cursor doesn't go to line end.
Added manually meaning is using paragraph add menu or click add button between two paragraphs.
Is it Okay?
Or Have I to make the cursor go to line end without exception?

Since the cursor is moving in the text editor of the new paragraph, it should also go at the end of the line

@corneadoug I fix whole issue. Can you check my code?

@mwkang I still get %.. when I create a new note, is it normal?
Could you also add a space after the %interpreter when you add it to the note?
That way we can start typing directly without having to add that space
@jongyoul If you could test that using some jdbc or other interpreters cases, that would be nice :)

It works well with another default interpreter except %spark. See the below.

But I also don't think it's good idea to display %.. by default. It would be better display actual default name of interpreter like %spark or %jdbc. It prevent new users from confusing and trying to understand what that means.
@mwkang Could you please try to fix it? and OccupiedInterpreter looks redundant because it stores noteId-interpreterName map only and returns interpreterName with noteId. This can be parsed from InterpreterFactory or another class directly. What's the benefit to create OccupiedInterpreter class?
I also think it's simple to choose default interpreter when we create notebook and store it into note.json and use it.

Okay. I am going to fix it.
I show real interpreter name instead of '%..'
@jongyoul I think about single responsibility. But if you have thought it is redundant, I will change code.
You think it is redundant, don't you?
(It's redundant.. And I think I lack of develop experience. So I sometimes have a mistake. But I have a can-do attitdue to learn from other's opinion.)

I'll fix after this branch rebases onto develop.

@jongyoul @corneadoug
Can you review my codes?
(I had rebased my branch because branch had conflict)
(Um.. CI is failed. :cry: )

@mwkang Could you please re-trigger this PR? Close and reopen this issue.

There's no test case for your implementation. Could you please add some test cases on your feature? I think NoteTest is one of the best point to write tests

I am not sure that this test case is you expected

@mwkang Those tests are enough. I've tested it and LGTM. Thanks for contribution.

@mwkang I have one more question. See below.

Can you fix the case of wrong interpreter name? Or do you have any idea to deal with?

@jongyoul If user enter wrong name, I ignore that name. Is it okay?
Or do I try to figure similar name out ?

@mwkang Could you please re-trigger test once again?

I reopened this PR. But I think I have to fix some test case.

[ ] https://travis-ci.org/apache/zeppelin/jobs/138874097
ZeppelinSparkClusterTest.sparkRTest:90

[ ] https://travis-ci.org/apache/zeppelin/jobs/138874103

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.235 sec - in org.apache.zeppelin.integration.ZeppelinIT

Results :

Failed tests:
  ParagraphActionsIT.testTitleButton:343 After Show Title : The title field contains
Expected: "Untitled"
     but: was ""

Tests in error:
  ParagraphActionsIT.testRemoveButton:143->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout
  ParagraphActionsIT.testMoveUpAndDown:180->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout
  ParagraphActionsIT.testCreateNewButton:75->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout

Wow thanks for your patience. This PR is a long period and lots of comments. I'll keep on trying my best.


Change method name color for API/Component methods

Test Plan:
Old:

New:

By analyzing the blame information on this pull request, we identified @Andreyco and @caabernathy to be potential reviewers.

I am just going to land this so I can cherry-pick this and the NavigationExperimental tutorial into 0.29 -- and then we can officially close this lockdown out, I think :)

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


[MBL-1294] Add unit tests for rewards selection viewmodel

📲 What
Add unit tests for rewards selection viewmodel
🤔 Why
Testing is good and we want them
Story 📖
MBL-1294

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.17%. Comparing base (1f9f6bd) to head (6ae2c15).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1993      +/-   ##
============================================
+ Coverage     67.87%   68.17%   +0.30%
- Complexity     2004     2024      +20
============================================
  Files           359      359
  Lines         21895    21895
  Branches       3073     3073
============================================
+ Hits          14861    14928      +67
+ Misses         5398     5309      -89
- Partials       1636     1658      +22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


small change for easier input for chatGPT to parse

Was experimenting with the code base and saw that the input had some words that were combined and new lines that were not addressed.
Take a look at the change, very minor thing but might improve results

This is great! Just tested it out and you're right, better results. Thank you for the contribution and I hope you have an amazing rest of your week.


Build server cannot start if build.sc import file with backtick

Version : 0.11.0-M6
For example
import $file.`a-b`

Then the bsp server says
File not found /path/to/`a-b`.sc

Seems the backtick is not removed from the path.

Thanks for the report.
The affected code path is rather new and uses a pretty trivial regex. The best solution would be to correctly parse the import as it is done in Ammonite.

We're in the process to completely rework the processing of build.sc files.

#2377

This change will also use a parser almost equal to the one used in Ammonite, so I think this issue will also resolve once we finish.


refactor: remove pull number input

:pencil: Description
Removes the pull_number input in favor of the context.issue.number available in the github context.

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


2022.03.0 release

Do you think we have to mention anything about the change in release versioning? Or will people just kinda understand? (Note about how it should correspond with same versions of RAJA/CHAI?)


ion-input password clears password on focus again

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ x] bug report
[ ] feature request

Current behavior:

ion-input type password is clearing password when you type once and then again come back to this field and type something. it will clear password field
Expected behavior:

It should not clear previous password. This feature is used by many other libraries like 1 password. so those libraries will not work with it
Steps to reproduce:

Create 1 password field
Put any random password there.
get out of that field. Click on any place outside that field
Get to that field again. Start typing something.
. It will clear previous password.

Related code:

insert short code snippets here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

@kshaaban- you are correct! closing issue

its not present in document. I think we should add this in documents

Perfect.


Tutorial for static builds on windows?

Can't seem to find any guide for building staticically on windows.
https://github.com/twistedfall/opencv-rust/issues/104#issuecomment-1348780057
@twistedfall left a message in that comment with a link to https://github.com/twistedfall/opencv-rust#static-build but it does not exist anymore unfortunately.
My current attempt uses the following env vars
[env]
LIBCLANG_PATH="C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\Llvm\\x64\\bin"
OPENCV_INCLUDE_PATHS="C:\\tools\\opencv\\build\\include"
OPENCV_HEADER_DIR="C:\\tools\\opencv\\build\\include"
OPENCV_LINK_PATHS="C:\\tools\\opencv\\build\\x64\\vc16\\lib"
OPENCV_LINK_LIBS="opencv_world4100.lib"
OPENCV_MSVC_CRT="static"

but it still looks for a dll on startup

Possible found the answer here: https://github.com/spoorn/media-to-ascii/blob/a01017fbb3dc883a89b0a1aff237c69b072542b2/.github/workflows/build.yml
Will reopen it if it does not work.

I've moved the installation guide into a separate file, so this is now the correct link: https://github.com/twistedfall/opencv-rust/blob/master/INSTALL.md#static-build
I haven't really tried building and linking statically on Windows myself, so if you have success please share and I'll link to your comment in the readme, thanks!

@twistedfall ended up getting it to work, but only using vcpkg.
I used https://github.com/mcgoo/cargo-vcpkg
Added the following to my Cargo.toml file in the root of the project:
(I removed llvm because it was creating 50gb+ build files and I didn't need it).
[package.metadata.vcpkg]
git = "https://github.com/microsoft/vcpkg"
rev = "94a50e8"

[package.metadata.vcpkg.target]
x86_64-pc-windows-msvc = { triplet = "x64-windows-static", dependencies = ["opencv4[contrib,nonfree]"] }

Then create a cargo config file in project_root/.cargo/config.toml and add the following.
[env]
OPENCV_INCLUDE_PATHS= { value = "target\\vcpkg\\installed\\x64-windows-static\\include", relative = true }
OPENCV_LINK_PATHS= { value = "target\\vcpkg\\installed\\x64-windows-static\\lib", relative = true }
OPENCV_LINK_LIBS="opencv_core4.lib,opencv_imgproc4.lib,zlib.lib"
OPENCV_MSVC_CRT="static"
VCPKG_CRT_LINKAGE="static"
VCPKG_LIBRARY_LINKAGE="static"
VCPKG_BUILD_TYPE="release"
VCPKG_TARGET_ARCHITECTURE="x64"

Then run cargo vcpkg build to build opencv. Once that completes you'll be able to use cargo as normal. Eg cargo build, cargo build --release etc.

opencv4[contrib,nonfree]

@twistedfall ended up getting it to work, using a mix of vcpkg and choco.
I used choco install llvm
I used https://github.com/mcgoo/cargo-vcpkg
Added the following to my Cargo.toml file in the root of the project:
[package.metadata.vcpkg]
git = "https://github.com/microsoft/vcpkg"
rev = "94a50e8"

[package.metadata.vcpkg.target]
x86_64-pc-windows-msvc = { triplet = "x64-windows-static-release", dependencies = ["opencv4[contrib,nonfree]"] }

Then create a cargo config file in project_root/.cargo/config.toml and add the following.
[env]
OPENCV_INCLUDE_PATHS= { value = "target\\vcpkg\\installed\\x64-windows-static-release\\include", relative = true }
OPENCV_LINK_PATHS= { value = "target\\vcpkg\\installed\\x64-windows-static-release\\lib", relative = true }
OPENCV_LINK_LIBS="opencv_core4.lib,opencv_imgproc4.lib,zlib.lib"
OPENCV_MSVC_CRT="static"

Then run cargo vcpkg -v build.
Once that completes you'll be able to use cargo as normal. Eg cargo build, cargo build --release etc.

Hello, cargo vcpk -v build success,but i add
[dependencies]
opencv="*"

show below error
  === OpenCV library configuration: Library {
      include_paths: [
          "D:\\projects\\rust\\opencv4\\target\\vcpkg\\installed\\x64-windows-static-release\\include",
      ],
      version: Version {
          major: 0,
          minor: 0,
          patch: 0,
      },
      cargo_metadata: [
          "cargo:rustc-link-search=D:\\projects\\rust\\opencv4\\target\\vcpkg\\installed\\x64-windows-static-release\\lib",
          "cargo:rustc-link-lib=opencv_core4",
          "cargo:rustc-link-lib=opencv_imgproc4",
          "cargo:rustc-link-lib=zlib",
      ],
  }
  thread 'main' panicked at D:\software\cargo\registry\src\rsproxy.cn-8f6827c7555bfaf8\opencv-0.89.0\build.rs:346:9:
  Unsupported OpenCV version: 0.0.0, must be from 3.2, 3.4 or 4.x branch

@adminSxs your version of opencv is outdated. Use 0.92.0

An alternative workflow.
Used a modified version of https://github.com/twistedfall/opencv-rust/blob/master/ci/install-windows-vcpkg.sh
#!/bin/bash

set -xeu

export VCPKG_ROOT="$HOME/build/vcpkg"
export VCPKG_DISABLE_METRICS=1

# Remove the existing VCPKG_ROOT if it's not a git repository
if [[ -e "$VCPKG_ROOT" && ! -e "$VCPKG_ROOT/.git" ]]; then
    rm -rf "$VCPKG_ROOT"
fi

# Clone the vcpkg repository if it doesn't exist
if [ ! -e "$VCPKG_ROOT" ]; then
    git clone https://github.com/Microsoft/vcpkg.git "$VCPKG_ROOT"
fi

pushd "$VCPKG_ROOT"

# Fetch the latest changes
git fetch --all --prune --tags
git status
git checkout .

# Bootstrap vcpkg
./bootstrap-vcpkg.sh -disableMetrics

# Set build type in various triplets
echo "set(VCPKG_BUILD_TYPE release)" >> triplets/x64-windows.cmake
echo "set(VCPKG_BUILD_TYPE release)" >> triplets/x64-windows-static.cmake
echo "set(VCPKG_BUILD_TYPE release)" >> triplets/x86-windows.cmake
echo "set(VCPKG_BUILD_TYPE release)" >> triplets/community/x64-windows-static-md.cmake

export VCPKG_DEFAULT_TRIPLET=x64-windows-static

# Install OpenCV with the desired features
(
    set +e
    which cmake
    cmake --version
    if ! ./vcpkg install --clean-after-build --recurse "opencv[contrib,nonfree,ade]"; then
        for log in "$VCPKG_ROOT/buildtrees"/**/*out.log; do
            echo "=== $log"
            cat "$log"
        done
        exit 1
    fi
)

# Remove build artifacts to save CI cache space
rm -rf "$VCPKG_ROOT/downloads" "$VCPKG_ROOT/buildtrees" "$VCPKG_ROOT/packages"

popd

Ran the above with Git Bash https://git-scm.com/downloads
Then set the following system env variables.
OPENCV_INCLUDE_PATHS=C:\Users\MY_USER\build\vcpkg\installed\x64-windows-static\include
OPENCV_LINK_PATHS=C:\Users\MY_USER\build\vcpkg\installed\x64-windows-static\lib
OPENCV_MSVC_CRT=static

Then set my config.toml to the following
RUSTFLAGS = ["-C", "target-feature=+crt-static"]

[env]
OPENCV_LINK_LIBS="absl_bad_any_cast_impl.lib,absl_bad_optional_access.lib,absl_bad_variant_access.lib,absl_base.lib,absl_city.lib,absl_civil_time.lib,absl_cord.lib,absl_cordz_functions.lib,absl_cordz_handle.lib,absl_cordz_info.lib,absl_cordz_sample_token.lib,absl_cord_internal.lib,absl_crc32c.lib,absl_crc_cord_state.lib,absl_crc_cpu_detect.lib,absl_crc_internal.lib,absl_debugging_internal.lib,absl_decode_rust_punycode.lib,absl_demangle_internal.lib,absl_demangle_rust.lib,absl_die_if_null.lib,absl_examine_stack.lib,absl_exponential_biased.lib,absl_failure_signal_handler.lib,absl_flags_commandlineflag.lib,absl_flags_commandlineflag_internal.lib,absl_flags_config.lib,absl_flags_internal.lib,absl_flags_marshalling.lib,absl_flags_parse.lib,absl_flags_private_handle_accessor.lib,absl_flags_program_name.lib,absl_flags_reflection.lib,absl_flags_usage.lib,absl_flags_usage_internal.lib,absl_graphcycles_internal.lib,absl_hash.lib,absl_hashtablez_sampler.lib,absl_int128.lib,absl_kernel_timeout_internal.lib,absl_leak_check.lib,absl_log_entry.lib,absl_log_flags.lib,absl_log_globals.lib,absl_log_initialize.lib,absl_log_internal_check_op.lib,absl_log_internal_conditions.lib,absl_log_internal_fnmatch.lib,absl_log_internal_format.lib,absl_log_internal_globals.lib,absl_log_internal_log_sink_set.lib,absl_log_internal_message.lib,absl_log_internal_nullguard.lib,absl_log_internal_proto.lib,absl_log_severity.lib,absl_log_sink.lib,absl_low_level_hash.lib,absl_malloc_internal.lib,absl_periodic_sampler.lib,absl_poison.lib,absl_random_distributions.lib,absl_random_internal_distribution_test_util.lib,absl_random_internal_platform.lib,absl_random_internal_pool_urbg.lib,absl_random_internal_randen.lib,absl_random_internal_randen_hwaes.lib,absl_random_internal_randen_hwaes_impl.lib,absl_random_internal_randen_slow.lib,absl_random_internal_seed_material.lib,absl_random_seed_gen_exception.lib,absl_random_seed_sequences.lib,absl_raw_hash_set.lib,absl_raw_logging_internal.lib,absl_scoped_set_env.lib,absl_spinlock_wait.lib,absl_stacktrace.lib,absl_status.lib,absl_statusor.lib,absl_strerror.lib,absl_strings.lib,absl_strings_internal.lib,absl_string_view.lib,absl_str_format_internal.lib,absl_symbolize.lib,absl_synchronization.lib,absl_throw_delegate.lib,absl_time.lib,absl_time_zone.lib,absl_utf8_for_code_point.lib,absl_vlog_config_internal.lib,ade.lib,archive.lib,bz2.lib,charset.lib,flatbuffers.lib,gif.lib,iconv.lib,jpeg.lib,leptonica-1.84.1.lib,libcrypto.lib,libcurl.lib,libhdf5.lib,libhdf5_hl.lib,libpng16.lib,libprotobuf-lite.lib,libprotobuf.lib,libprotoc.lib,libsharpyuv.lib,libssl.lib,libszip.lib,libwebp.lib,libwebpdecoder.lib,libwebpdemux.lib,libwebpmux.lib,libxml2.lib,lz4.lib,lzma.lib,opencv_aruco4.lib,opencv_bgsegm4.lib,opencv_bioinspired4.lib,opencv_calib3d4.lib,opencv_ccalib4.lib,opencv_core4.lib,opencv_datasets4.lib,opencv_dnn4.lib,opencv_dnn_objdetect4.lib,opencv_dnn_superres4.lib,opencv_dpm4.lib,opencv_face4.lib,opencv_features2d4.lib,opencv_flann4.lib,opencv_fuzzy4.lib,opencv_gapi4.lib,opencv_hdf4.lib,opencv_hfs4.lib,opencv_highgui4.lib,opencv_imgcodecs4.lib,opencv_imgproc4.lib,opencv_img_hash4.lib,opencv_intensity_transform4.lib,opencv_line_descriptor4.lib,opencv_mcc4.lib,opencv_ml4.lib,opencv_objdetect4.lib,opencv_optflow4.lib,opencv_phase_unwrapping4.lib,opencv_photo4.lib,opencv_plot4.lib,opencv_quality4.lib,opencv_rapid4.lib,opencv_reg4.lib,opencv_saliency4.lib,opencv_shape4.lib,opencv_stereo4.lib,opencv_stitching4.lib,opencv_structured_light4.lib,opencv_superres4.lib,opencv_surface_matching4.lib,opencv_text4.lib,opencv_tracking4.lib,opencv_video4.lib,opencv_videoio4.lib,opencv_videostab4.lib,opencv_wechat_qrcode4.lib,opencv_xfeatures2d4.lib,opencv_ximgproc4.lib,opencv_xobjdetect4.lib,opencv_xphoto4.lib,openjp2.lib,quirc.lib,tesseract54.lib,tiff.lib,turbojpeg.lib,utf8_range.lib,utf8_validity.lib,zlib.lib,zstd.lib"
OPENCV_MSVC_CRT="static"


USB streaming is corrupted on Atlys

With firmware build v0.0.3-730-gf9c031d and FX2 firmware (hdmi2usb.hex) from v0.0.2-81-gd0d3aea (as well as a locally built one from HEAD) we get this over the USB stream.

The source is the Debian stretch background

Reproduced with v0.0.3-745-g4242bb5 and a hdmi2usb.hex built from timvideos/HDMI2USB-fx2-firmware@8359b974242ec81fe93627053f70e4d10c2d8844 with BOARD=atlys

It appears to be broken in the first 0.0.3 build (v0.0.3-664-gfab22b9), again with hdmi2usb.hex from v0.0.2-81-gd0d3aea. Tested by generating the firmware.bin from firmware.fbi dd if=firmware.fbi of=firmware.bin bs=1 skip=8 and loading this with flterm.

hardware version info
===============================================
           DNA: 0137ce976e3a3dec
           MAC: Unknown

gateware version info
===============================================
      platform: atlys
        target: HDMI2USB
      revision: fab22b9b3252d5ea8b7cf1cfd1d14d86929fd82e

firmware version info
===============================================
      platform: atlys
        target: hdmi2usb
    git commit: fab22b9b3252d5ea8b7cf1cfd1d14d86929fd82e
    git branch: master
  git describe: 0.0.3-664-gfab22b9-dirty
    git status:
    --
     M ../../../../third_party/litepcie
     M ../../../../third_party/litesata
     M ../../../../third_party/liteusb
    --

         built: Mar 17 2017 00:23:17
        uptime: 00:04:31
-----------------------------------------------

Verified the issue is still present in 840e634e, which is 8 commits after Atlys support was added to the nextgen branch. So, it's been there since the beginning.
@enjoy-digital: Any suggestions on approaches to debug it?

@enjoy-digital
Is this likely to do with the fact that the CPU or DDR is running at different clock rate than on the Opsis?
You also don't have an Atlys board, right?

@mithro: i don't think so since we have an async fifo. I would says it could come from a timing constraint that is not correctly applied on the usb clock domain. What is the difference with the code that was running before on the atlys? (not sure i followed everything)

@enjoy-digital - As far as we can see, the encoder in the Atlys has never work with the firmware that uses LiteX rather MiSoC -- so a huge amount has changed!


CLI cannot run WDL if cwltool is not on path

Describe the bug
Dockstore relies on cwltool to run CWLs, but it turns out it also relies on it to run WDLs. We refer to cwltool as an optional component in our quick start installation instructions, not as a dependency, so it shouldn't be getting used at all. It seems that dockstore is trying to get the version of cwltool regardless of what is actually being run, resulting in an error.
To Reproduce (not recommended)

Have hardware issues with your work laptop and drop it off at UCSC ITS -- my issue involved the screen and USB-C ports, but feel free to get creative here
Realize your backup only has the contents of things like /Documents, not any actual programs
Install the Dockstore CLI on your loaner laptop
Don't install cwltool, as you generally work with WDLs
Attempt to run a WDL

Expected behavior
The WDL to run.
Actual behavior
CBSELoaPD96HV29:~ aofarrel$ dockstore tool launch --entry Documents/GitHub/analysis_pipeline_WDL/assoc-aggregate/assoc-aggregate.wdl --json Documents/GitHub/analysis_pipeline_WDL/assoc-aggregate/assoc-aggregate-local-fast.json
[##################################################] 100%
problems running command: cwltool --version
15:06:06.869 [main] ERROR io.dockstore.client.cli.ArgumentUtility - java.lang.RuntimeException: problems running command: cwltool --version
at io.cwl.avro.Utilities.executeCommand(Utilities.java:96)
at io.github.collaboratory.cwl.cwlrunner.CWLToolWrapper.checkForCWLDependencies(CWLToolWrapper.java:39)
at io.dockstore.client.cli.Client.checkForCWLDependencies(Client.java:459)
at io.dockstore.client.cli.nested.CwltoolLauncher.initialize(CwltoolLauncher.java:32)
at io.dockstore.client.cli.nested.BaseLanguageClient.launchPipeline(BaseLanguageClient.java:156)
at io.github.collaboratory.cwl.CWLClient.launch(CWLClient.java:289)
at io.dockstore.client.cli.nested.AbstractEntryClient.launchCwl(AbstractEntryClient.java:1257)
at io.dockstore.client.cli.nested.AbstractEntryClient.launch(AbstractEntryClient.java:1217)
at io.dockstore.client.cli.nested.AbstractEntryClient.processEntryCommands(AbstractEntryClient.java:296)
at io.dockstore.client.cli.Client.run(Client.java:720)
at io.dockstore.client.cli.Client.main(Client.java:619)
Caused by: org.apache.commons.exec.ExecuteException: problems running command: cwltool --version (Exit value: -559038737)
at io.cwl.avro.Utilities.executeCommand(Utilities.java:92)
... 10 more
Desktop (please complete the following information):

Mac OS Big Sur
Version: 1.11

┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-1938
┆Sprint: Backlog
┆Issue Type: Story

I think you need to add --descriptor WDL -- it's assuming it's CWL, your file extension not withstanding.
~/git/dockstore/dockstore$ dockstore tool launch

 ____             _        _
|  _ \  ___   ___| | _____| |_ ___  _ __ ___
| | | |/ _ \ / __| |/ / __| __/ _ \| '__/ _ \
| |_| | (_) | (__|   <\__ \ || (_) | | |  __/
|____/ \___/ \___|_|\_\___/\__\___/|_|  \___|

---------------------------------------------
See https://www.dockstore.org for more information

Usage: dockstore tool launch --help
       dockstore tool launch [parameters]

Description:
  Launch an entry locally.

Required parameters:
  --entry <entry>                     Complete entry path in Dockstore (ex. quay.io/collaboratory/seqware-bwa-workflow:develop)
   OR
  --local-entry <local-entry>         Allows you to specify a full path to a local descriptor instead of an entry path

Optional parameters:
  --json <json file>                  Parameters to the entry in Dockstore, one map for one run, an array of maps for multiple runs
  --yaml <yaml file>                  Parameters to the entry in Dockstore, one map for one run, an array of maps for multiple runs
  --descriptor <descriptor type>      Descriptor type used to launch workflow. Defaults to CWL
  --local-entry                       Allows you to specify a full path to a local descriptor for --entry instead of an entry path
  --wdl-output-target                 Allows you to specify a remote path to provision output files to ex: s3://oicr.temp/testing-launcher/
  --uuid                              Allows you to specify a uuid for 3rd party notifications
  --ignore-checksums                  Allows you to ignore validating checksums of each downloaded descriptor

On my previous laptop, which had cwltool installed, I don't believe I ever used --descriptor, but I might be misremembering.
That said I did forget to use --local-entry instead of --entry, and --local-entry (without --descriptor) does seem to be running cromwell without throwing the error. If it turns out my using --entry was the issue as it didn't know how to parse the local path and therefore defaulted to cwl, that's on me and this can be closed.

I'm going to close then.
One could argue that it should first check that the entry exists and fail there. But the flip-side would be why check for an entry if you don't have the runner installed. :)


panic: runtime error: invalid memory address or nil pointer dereference

s3put crashes right away after start.
Ubuntu 14.04 system:
$ ./s3put_linux_amd64 -k $AWS_ACCESS_KEY_ID -s $AWS_ACCESS_KEY_SECRET -b $bucket put date.txt
2017/03/07 09:02:19 Starting 10 goroutines...
2017/03/07 09:02:19 Transfering (Prefix: /home/ask/tmp/static/prod) /home/ask/tmp/static/prod/date.txt...
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x28 pc=0x405a34]

goroutine 15 [running]:
panic(0x7f2960, 0xc8200100a0)
    /Users/surma/.homebrew/Cellar/go/1.6/libexec/src/runtime/panic.go:464 +0x3e6
main.CopyItems.func1(0xc8200113b0, 0xc82005e1e0, 0x0, 0x0, 0x455f00)
    /Users/surma/src/github.com/surma/s3put/storage.go:217 +0x174
created by main.CopyItems
    /Users/surma/src/github.com/surma/s3put/storage.go:229 +0x18a

Ubuntu 16.04 system:
$ ./s3put_linux_386 -k $AWS_ACCESS_KEY_ID -s $AWS_ACCESS_KEY_SECRET -b $bucket put .
2017/03/07 09:00:34 Starting 10 goroutines...
2017/03/07 09:00:34 Traversing /home/i/tmp...
2017/03/07 09:00:34 Transfering (Prefix: /home/i/tmp) /home/i/tmp/index.html...
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x18 pc=0x804cc8c]

goroutine 15 [running]:
panic(0x8369e00, 0x18724030)
    /Users/surma/.homebrew/Cellar/go/1.6/libexec/src/runtime/panic.go:464 +0x326
main.CopyItems.func1(0x1877db20, 0x18714fc0, 0x0, 0x0, 0x8095300)
    /Users/surma/src/github.com/surma/s3put/storage.go:217 +0x12c
created by main.CopyItems
    /Users/surma/src/github.com/surma/s3put/storage.go:229 +0x13d

Both the linux 386 and amd64 versions crash. I downloaded the binaries from your release section @ https://github.com/surma/s3put/releases

Sorry for taking so long to address this, I was quite swamped. I’m investigating now.

Okay, so it’s not a bug per se, it’s just that I didn‘t handle malformed bucket URLs gracefully.
I fixed it in 3.0.3 (commit 4b8bc5db58c17206031b8e41531b54ab0d12f4c2) and updated the README. I’m uploading new binaries as well.
Please take a look and try again. Closing this for now, but feel free to re-open if the problem persists :)


Implemented the updated AssemblyListener Interface in KotlinExample.kt

Just a quick fix to the new Kotlin Example.
Background: New methods in the AssemblyListener interface had to be implemented.

I configured also the build.gradle from the examples module to support Kotlin Files /
Examples. This is needed for out of the box support

Nice going!


Interpreter not updating when done signal of the group is directly assigned

The interpreter does not run the updates in the group if the done signal is assigned true. Thus, the done signal of the group needs be given indirectly with a register in the current state. This needs to be fixed so that the done signal of the group gets assigned 1 after all the updates are done even it is directly given  1'd1.
A code that compiles but does not work with the current interpreter
  wires {
    group cond<"static"=0> {
      lt0.left = const0.out;
      lt0.right = const1.out;
      cond[done] =  1'd1;
    }

A code that compiles and works with the current interprete   wires {     group cond<"static"=0> {       reg0.write_en = 1'd1;       lt0.left = const0.out;       lt0.right = const1.out;       reg0.in = lt0.out;       cond[done] = reg0.done;     }

@EclecticGriffin does the new interpreter have this issue/similar issue?

I'm pretty sure the current iteration of the interpreter does not suffer this issue

Closing since this issue is no longer present/relevant


Add elif directive to shader preprocessor

Added one of the missing features of the shader preprocessor requested in https://github.com/godotengine/godot-proposals/issues/5062 (+ removed some unused code):

Any chance of backporting to 3.x?


request for contextual address functionality

sed allows for a contextual address(regex) which selects all of the pattern spaces that match the address. A command with no address selects every pattern space.
So, in sed you can do this:
sed -n '/styles-min/p' file.html

which results in say,
<link rel="stylesheet" href="assets/css/styles-min.2ac224ec.css" />

This is equivalent to
search 'styles-min' file.html

You can also do this with sed:
sed -n '/styles-min/ s/\.css/.min.css/p' file.html

yielding:
<link rel="stylesheet" href="assets/css/styles-min.2ac224ec.min.css" />

There is no equivalent in replace that does this to my knowledge. Would something like this be possible? Something to the effect of
srep 'styles-min' '\.css' '.min.css' file.html
or
srep  '\.css' '.min.css' --c 'styles-min' file.html

closing


Remove the dollar sign used as a prefix in code sections

File: engine/install/debian.md
Remove the dollar sign used as a prefix in code sections. It prevents triple-click to select line then copy & paste in console. With the dollar sign present, we have to double-click a word, than select each word, where horizontal scrolling can also happen just to copy-paste in a console.
Bad:
$ sudo apt-get remove docker docker-engine docker.io containerd runc

Good:
sudo apt-get remove docker docker-engine docker.io containerd runc

Duplicate of #11695


WalletConnect BSC Error - PollingBlockTracker using Custom Rpc | WEB3MODAL

Describe the bug
I've set-up the v1 of the web3modal following the repo and some github issue, to use walletconnect/we3-provider.
In the options i've setup a custom rpc (quicknode) for the Binance smart chain, it connects correctly to the wallet but when i connect an error appears.

After this error if i open up the console i see this error looped:

Below you can check my code (i replaced the quicknode rpc with binance to not showing the endpoint, but also with this bsc dataseed rpc it's not working, same error as the quicknode rpc):
const providerOptions = {
walletconnect: {
package: WalletConnectProvider,
options: {
rpc: {
56: 'https://bsc-dataseed.binance.org/',
},
network: 'binance',
chainId: 56,
},
},
};
const web3ModalInstance = new Web3Modal({
  disableInjectedProvider: false,
  network: 'mainnet',
  theme: 'dark', // optional
  cacheProvider: true, // optional
  providerOptions, // required
});

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


ARROW-7514: [C#] Make GetValueOffset Obsolete

Add an [Obsolete] attribute to BinaryArray.GetValueOffset

ListArray.GetValueOffset already has the [Obsolete] attribute, so it is not changed

Avoid using GetValueOffset in the product source code

As a precaution, I added tests for ValueOffsets and left tests for GetValueOffset.

@eerhardt do you have time to review?

@kou @eerhardt
Thank you both!
I responded to feedback.

I'm going to merge this to move this PR forward. If we want to tweak the GetBytes implementation separately, I think we can do that in a separate PR.


Fix learning rate to actually be one fifth of 0.1

:) thanks @PeterC-DLS - sorry this took so long, but it is actually corrected now!