Package the sbt launcher in such a way that it can easily be installed by coursier

cf the discussion below.

Would you be interested in making this change (cs setup installs the official sbt launcher) happen?

I just tried, and it turns out it's a little bit more complicated. The scripts in the sbt archive seems not to work in a standalone fashion. The sbt and sbt.bat scripts need sbt-launch.jar and java9-rt-export.jar alongside them. Which breaks what I had in mind and could have mostly worked right now, that is just picking sbt or sbt.bat from the archive, and put that in the PATH.
(I'm not sure what was the point of keeping java9-rt-export.jar separate. Its 3 classes could just have been folded in sbt-launch.jar… And sbt-launch.jar could actually be appended to sbt and sbt.bat, so that these scripts don't need to look for external files.)
To work around that, cs could maybe extract the full archive, instead of picking just one file, and have the script it generates itself (the one actually put in the PATH) call the right file from the extracted archive. But that needs a bit of work… Or maybe we could do some ad hoc post-processing just for sbt, so that we can merge java9-rt-export.jar and sbt-launch.jar ourselves, append the result to sbt or sbt.bat, and change a few strings in them so that they use themselves as JAR instead of looking for external files.
Originally posted by @alexarchambault in https://github.com/scala/scala-lang/issues/1209#issuecomment-779761887

Sounds like a plan. If folding java9-rt-export.jar into the launcher helps that seems like a relatively small adjustment we should make.

The relevant repos:

https://github.com/sbt/java9-rt-export
https://github.com/sbt/launcher

I've updated Launcher to use Scala 2.12 (https://github.com/sbt/launcher/pull/82) as opposed to Scala 2.10, and brought in java9-rt-export https://github.com/sbt/launcher/pull/84

did this get resolved by changes on the Coursier side instead...?

Good point, this is now solved! I am closing the issue.


Support group and user quota

What would you like to be added:
Why is this needed:
In our scenario, we mount JuiceFS into a directory local to Linux, one for each department.  The department directory is a directory for each member of the department, and we want JuiceFS to support group or user quotas

Group and user quota is part of our roadmap (after 1.0).
Have your used group or user quotas with other product? That will be helpful if you can provide more details on how to use the group and user quotas.

Here i will show two scenario in our platform:
First:
Linux flie system quota
support

Limit the maximum disk quota for a user (using user limits)

Limit the maximum disk quota for a group (using group limits)

Limits the maximum disk quota for a directory (directory,project)

limit

Ext cannot set quotas for a single directory.  XFS can use the Project model to set disk quotas

The Linux kernel must support quota

XFS file system quota Settings

Set quotas for Uids, Gids, and projects

You can use a capacity limit or file number limit (block or inode)

Soft and hard rules

Hard has a higher limit than soft

Grace Time  :Soft replaces hard when the limit is exceeded

Configuration method
For example, in the Linux file system, each user has its own directory. In this example, user= Bob groups=atlas is used as /home/bob
xfs_quota -x -c "limit -u bsoft=250M  bhard=300M  bob" /home   xfs_quota -x -c "limit -g bsoft=950M  bhard=1G    atlas" /home
Example Set a directory quota
Suppose we want to set the quota for the /home/myquota directory with the project name myquotaProject and the project ID 11
echo "11:/home/myquota" >>  /etc/projects echo "myquotaproject:11" >> /etc/projid xfs_quota -x -c "project -s myquotaproject" xfs_quota -x -c "limit  -p bsoft=450M  bhard=500M   myquotaproject"  /home

Second:
Lustre quota
Each user has its own user name, uid, GID, and the group to which it belongs. In our scenario, we create a common directory for each group, and the group to which the directory belongs is the user's group, for example
id person1
uid=1000(person1) gid=1000(person1) groups=1000(person1),1033(g1)

drwxrwx--x  37 person1   g1 4096 Feb 25 11:43        /data/partment1
drwxrwx--x  22 person2     g2    4096 Mar 18 10:18  /data/partment2

@davies @SandyXSD

It would be a great adition to also add --capacity to mount option as one could mount any --subdir with a specific --capacity.

Here is a design draft at the very beginning: Quota.md


[Bug]: No error given when non-constant variable reference is used in the namespace uri of xmlns

Description
There should be an error when a non-constant variable reference is used to set the namespace uri in an xmlns declaration.
Steps to Reproduce
Consider the following case,
final string x = "a";

xmlns x as ns;

Based on the spec this should give an error.
Affected Version(s)
2201.8.4
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This issue is a duplicate of #41988.


Flaky tests (panic: Fail in goroutine) in v1.3.4 discovered by Ubuntu autopkgtest

Ubuntu autopkgtest of the latest github.com/xtaci/smux v1.3.4 (Debian package golang-github-xtaci-smux/1.3.4+ds-1) fails Ubuntu autopkgtest on ppc64el:

http://autopkgtest.ubuntu.com/packages/golang-github-xtaci-smux/eoan/ppc64el

(Special thanks to @LocutusOfBorg for telling me about this issue over IRC on #ubuntu-devel as this apparent test regression is preventing golang-github-xtaci-smux's migration to Eoan, i.e. Ubuntu 19.10.)
Further tests reveal that:

It is not limited to ppc64le (ppc64el); I was able to reproduce the same errors on my amd64 computer.
It is found in both v1.1.0 and v1.3.4 (master as of this writing)
It happens randomly, and I need to run loops like below to trigger the errors:

$ while go test -vet=off -p 1 github.com/xtaci/smux; do go clean -testcache; done
ok  	github.com/xtaci/smux	8.712s
ok  	github.com/xtaci/smux	8.677s
ok  	github.com/xtaci/smux	9.041s
ok  	github.com/xtaci/smux	8.803s
ok  	github.com/xtaci/smux	8.756s
ok  	github.com/xtaci/smux	8.800s
ok  	github.com/xtaci/smux	8.742s
ok  	github.com/xtaci/smux	8.719s
--- FAIL: TestIsClose (0.00s)
    session_test.go:36: accept tcp <IP_ADDRESS>:44465: use of closed network connection
FAIL
FAIL	github.com/xtaci/smux	8.796s

Another run:
$ while go test -vet=off -p 4 github.com/xtaci/smux; do go clean -testcache; done
ok  	github.com/xtaci/smux	8.734s
ok  	github.com/xtaci/smux	8.719s
ok  	github.com/xtaci/smux	8.691s
ok  	github.com/xtaci/smux	8.705s
ok  	github.com/xtaci/smux	9.074s
ok  	github.com/xtaci/smux	9.369s
panic: Fail in goroutine after TestSessionDoubleClose has completed

goroutine 2106 [running]:
testing.(*common).Fail(0xc000d66100)
	/usr/lib/go-1.12/src/testing/testing.go:565 +0x11e
testing.(*common).Error(0xc000d66100, 0xc000090660, 0x1, 0x1)
	/usr/lib/go-1.12/src/testing/testing.go:654 +0x79
github.com/xtaci/smux.setupServer.func1(0x8e3a20, 0xc000010058, 0x8e99e0, 0xc000d66100)
	/home/foka/go/src/github.com/xtaci/smux/session_test.go:36 +0xbc
created by github.com/xtaci/smux.setupServer
	/home/foka/go/src/github.com/xtaci/smux/session_test.go:33 +0xf9
FAIL	github.com/xtaci/smux	1.814s

and also:
panic: Fail in goroutine after TestCloseThenOpen has completed

goroutine 1430 [running]:
testing.(*common).Fail(0xc000184100)
	/usr/lib/go-1.12/src/testing/testing.go:565 +0x12c
testing.(*common).Error(0xc000184100, 0xc0001100d0, 0x1, 0x1)
	/usr/lib/go-1.12/src/testing/testing.go:654 +0x70
github.com/xtaci/smux.setupServer.func1(0x104af340, 0xc0000a8068, 0x104b52c0, 0xc000184100)
	/home/foka/go/src/github.com/xtaci/smux/session_test.go:36 +0xbc
created by github.com/xtaci/smux.setupServer
	/home/foka/go/src/github.com/xtaci/smux/session_test.go:33 +0xd0
FAIL	github.com/xtaci/smux	2.360s

Thanks for looking into the issue.
/cc @rogers0

and for this, it's mostly due to running out of max open files limit,trying to find and Close fds

it's due to incorrect reporting of test error.

https://github.com/xtaci/smux/releases/tag/v1.3.5

if there are more errors, feel free to open issues .


Sending whisper doesn't appear to be working.

When trying to use the SendWhisper method it completes successfully but the user never receives the whisper.
When looking at the events, it looks like the message was sent out to Twitch correctly.
ChatClient_OnSentOccurred: PRIVMSG #archonaut_ :.w trezthemodgod  trezthemodgod - this is a test
Is that command correct or should it be:
PRIVMSG #archonaut_ :/w trezthemodgod  trezthemodgod - this is a test

Ok.. I see that using the dot and not the slash is the correct format.  Very odd that the bot is unable to whisper people.

There's also a LOT more nuances to Twitch whispers than there are on Mixer. There's limit issues, settings that block whispers, permission issues, etc. and error messaging is not are rich on Twitch.
EX: https://twitter.com/TwitchSupport/status/1042873432382160896

It seems like they are a bit hit or miss when being sent by the bot.  I am not seeing any errors or data coming back via notifications showing that something is wrong.  Sometimes it sends... sometimes it doesn't.   Gotta love Twitch IRC API stuff.

Yea, there's definitely going to be some feeling out time for adjusting to Twitch with stuff like this. I have yet to see any packets get sent back on a failed whisper and I don't see any way to get that information specifically. My general recommendation has been to avoid whispers unless absolutely necessarily, it's reason why we're phasing them out from normal Mix It Up usage unless explicitly set by the streamer.

I was using it very infrequently previously, so gives me a reason to start avoiding it.


Ubuntu-trusty: APT whitelist requset for libnetfilter-queue-dev,iptables-dev

Resolves: travis-ci/apt-package-whitelist/issues/4039
Add packages: libnetfilter-queue-dev, libnetfilter-queue1, libnetfilter-queue1-dbg, iptables-dev

Sorry, but we cannot accept PRs without the tests. Please read https://github.com/travis-ci/apt-package-whitelist#package-approval-process and follow the process. Thanks.


Add AzureEventGrid Infra

Add AzureEventGrid Infra for cloudevent-azureventgrid-test
Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO)

Related to # https://github.com/kedacore/keda/pull/5606

Please, execute terraform fmt --recursive, commit & push the changes.

I have no idea about the required resources, could you confirm that these are correct?

A ServiceBus topic in the main ServiceBus:  keda-e2e-receive-event-grid-topic
A ServiceBus topic in the alternative ServiceBus (we use it for podidentity impersonation test):  keda-e2e-receive-event-grid-topic
A new ServiceBus namespace: keda-e2e-servicebus-namespace-event-grid including

Azure Service Bus Data Owner role asignment
An authorizartion rule
A topic keda-e2e-receive-event-grid-topic

An EventGrid subscription
An EventGrid topic

I have no idea about the required resources, could you confirm that these are correct?

A ServiceBus topic in the main ServiceBus:  keda-e2e-receive-event-grid-topic

A ServiceBus topic in the alternative ServiceBus (we use it for podidentity impersonation test):  keda-e2e-receive-event-grid-topic

A new ServiceBus namespace: keda-e2e-servicebus-namespace-event-grid including

Azure Service Bus Data Owner role asignment
An authorizartion rule
A topic keda-e2e-receive-event-grid-topic

An EventGrid subscription

An EventGrid topic

Yes. What I want is creating a new event grid and a serviceBus topic to receive events.

Yes. What I want is creating a new event grid and a serviceBus topic to receive events.

Okey! In the future, I think that we can include a flag to deploy the topic or support providing the topics as input, but as topics don't have cost IIRC, we can continue with the PR as it is


Don't fetch all article headers when changing feeds

Currently, all available article headers are loaded when switching feeds. Instead, only fetch the unread ones, and maybe just a subset of those.

Fixed in 17cb22e


feat(autocomplete): add md-autocomplete classes to overlay panel

Transfers any classes added to md-autocomplete to the resulting panel, allowing for easier styling similarly to md-menu.
Fixes #4196.

Related https://github.com/angular/material2/pull/6618. And would it be possible to support NgClass syntax?

I would rather keep it simple and in line with md-menu. It can be added later if people ask for it.

Ok cool! Also does it support removal of classes? It looks like you can only add classes, though I haven't tested.

It doesn't, but the intention here is just to allow styles to be overridden. My worry with making it more dynamic is that people may end up putting it in a state where it interferes with the panel being toggled correctly.

Merging this in but it includes an md- in the comment, can you send another PR that removes md-autocomplete and changes it to autocomplete or mat-autocomplete?


[Feature] value for wait should be optional

Problem Statement
I would like to check if filed: .status.loadBalancer.ingress[0].ip is set. I don't want to check the value.
I ended up with
        - script:
            env:
              - name: namespace
                value: ($namespace)
            content: |
              kubectl wait ingresses.v1.networking.k8s.io --for=jsonpath={.status.loadBalancer.ingress[0].ip} --all -n $namespace --timeout 1m0s

but would be great to execute this with wait DSL:
            apiVersion: networking.k8s.io/v1
            timeout: 1m
            kind: Ingress
            for:
              jsonPath:
                path: "{.status.loadBalancer.ingress[0].ip}"

Solution Description
Implment a way to wait for presence of a field, without checking contents.
Alternatives
Use script/command as in the description above.
Additional Context
No response
Slack discussion
No response
Research

[X] I have searched other issues in this repository and mine is not recorded.

Thanks for reporting, will be fixed by #1887


Feature Request: Allow 1 row terminal dimension

Hey everyone, first of all, thankyou so much for making the coolest thing I've seen in a terminal in a long time. The gallery is stunning :-)
That aside, I'm haven't been able to have this print to a single row, due to a divide by zero error, and just wondering if a single row print could be implemented? I tried messing around with bottom: int = 1 in terminal.py but I think the effect is using row height and looking at the effects code was like reading gibberish, as I'm just starting out with python. Here's the error:
  File "/media/storage/Streaming/Software/scripts/dev/services/test.py", line 10, in <module>
    for frame in effect:
  File "/home/user/.venvs/lib/python3.12/site-packages/terminaltexteffects/engine/base_effect.py", line 88, in __iter__
    return self._iterator_cls(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.venvs/lib/python3.12/site-packages/terminaltexteffects/effects/effect_slide.py", line 143, in __init__
    self._build()
  File "/home/user/.venvs/lib/python3.12/site-packages/terminaltexteffects/effects/effect_slide.py", line 147, in _build
    final_gradient_mapping = final_gradient.build_coordinate_color_mapping(
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.venvs/lib/python3.12/site-packages/terminaltexteffects/utils/graphics.py", line 180, in build_coordinate_color_mapping
    fraction = row_value / max_row
               ~~~~~~~~~~^~~~~~~~~
ZeroDivisionError: division by zero

Can you post the lines of your code in which you modify the effect.terminal_config or effect.effect_config? I'll get this fixed. Thanks.

Hey @ChrisBuilds thanks for the response :-)
I think the error will show up with any code where you specify the dimensions with terminal_dimensions, I started out with the example you have in the wiki and added the line:
from terminaltexteffects.effects.effect_slide import Slide

text = ("EXAMPLE" * 10 + "\n") * 10

effect = Slide(text)
effect.effect_config.merge = True
effect.terminal_config.terminal_dimensions = (50, 1)
with effect.terminal_output() as terminal:
    for frame in effect:
        terminal.print(frame)

I got the same result using --terminal-dimensions with the above values in the terminal. I found a hacky solution around it in the meantime by using print(frame.split('\n')[0], end='\r') lol

I've released the patch for this with 0.9.1. In addition to fixing the division by zero, the terminal_config.terminal_dimensions argument has been split into terminal_config.terminal_width and terminal_config.terminal_height args. This enables automatic detection of each dimension independent of the other. So for a single line of variable length, you can do the following:
from terminaltexteffects.effects.effect_slide import Slide

text = ("EXAMPLE" * 10 + "\n") * 10

effect = Slide(text)
effect.terminal_config.terminal_height = 1
with effect.terminal_output() as terminal:
    for frame in effect:
        terminal.print(frame)

In this example, the width is automatically detected and the height is manually set to 1. Let me know if this works for your use case. If you don't have any additional issue related to single line output, I will close this issue.

I just gave it a try and it appears to be working perfectly; thanks for the help with that :-)


Update LICENSE

bro , according to the website we still need a name?
https://opensource.org/licenses/MIT

Yea. Need to add Bryan Lim into it it seems


Address missing email on vm creds

Context: https://centrepopgen.slack.com/archives/C018KFBCR1C/p1659419725749609?thread_ts=1659332662.921389&cid=C018KFBCR1C

Codecov Report

Merging #263 (4be22c1) into dev (b986880) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #263   +/-   ##
=======================================
  Coverage   63.59%   63.59%
=======================================
  Files          65       65
  Lines        4862     4862
=======================================
  Hits         3092     3092
  Misses       1770     1770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b986880...4be22c1. Read the comment docs.


fix(ts-error): add JSX.Element type option in addition to dep React.C…

fix componentType by adding option for JSX.Element on renderRow/LeftButton/Header etc.
should replace ComponentType with ElementType in future but did not fix for me
should fix #642

any chance we can push this through? @bell-steven

There were also type errors when referencing an object instead of directly inline passing the object. I have added a fix for this in the second commit.

This change would be very helpful!  @bell-steven please merge this when you get a chance

Thank you @rgordon95.  I will get to this as soon as I have a chance.

I would love to see this fixed. This is such a great library, and having accurate type defs would be awesome! :+1:

@rmessenger  I have basically no experience with typescript, so I can't give an opinion here.
@rgordon95 can you address these points?


Update azure-arc-vm-management-prerequisites.md

Adding leading period to domain name example

@ksurjan
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#in-progress

As per Varun, what is in the current doc is OK. Hence closing off the PR. #please-close


Support TLSv1.1 and TLSv1.2

Connections fail when TLSv1 is disabled.
Testing (from http://prosody.im/doc/advanced_ssl_config#protocol)
Running prosody with:
ssl                    = {
                           key         = "...";
                           certificate = "..";
                           options     = {"no_sslv2", "no_sslv3", "no_tlsv1" };
                           }

fails.
Should really be trying to connect using TLSv1.2 and TLSv1.1
S.

How do I solve this? -> TLS support is not compiled in


[WIP] Add some text to the README

Here's some updates to the README.
I would like to fill the resource section a little, can you share your favourite ones? /cc @rust-community/events-team

I'll merge it, thanks!


How to use packages written in commonjs on the server

I'm hitting a wall trying to make my server do the stuff I need it to do with packages that are written in commonjs using require.
I'm not super familiar with vite's bundling process so there's little I can investigate here.
The error I'm getting is:
[vite] Internal server error: require is not defined

Hi @Angelelz
Thanks. I'll try to fix this issue later.
The same problem: https://github.com/mugi-tech/honox-blog-template/issues/1

I found a workaround / solution:
ssr: {
  external: ["adm-zip", "mssql", "sanitize-filename"],
},

Add that to the backend packages that use require on the server part of vite.config.ts

Feel free to close the issue. It's working fine for me.

Hi @Angelelz
This error comes from the lack of CommonJS support by Vite. It is better to write the appropriate package name in ssr.external as you did.

I am facing the similar issue with jsPdf library, and above suggestion didn't work for me.
https://www.npmjs.com/package/jspdf
3:26:09 pm [vite] Internal server error: Cannot use import statement outside a module


#overview seems to have extraneous dependencies.

We're not sure what the dependencies are, but they seem to be very big projects, which doesn't seem correct.

Is building .#overview blocked on validator-nu (on a non x86_64-linux machine) or on pretalx? For the latter, you can drop these lines:
https://github.com/ngi-nix/ngipkgs/blob/84f90068258507753acc67449f211d807c0a62d9/projects/Pretalx/service.nix#L134-L140

Can we factor out the static files attribute into a passthru? Something that doesn't require changing the interface but avoids the expensive build...

It's not clear to me which dependencies this is about. I added validator-nu with the intention of making sure that we do not produce bad HTML.

validator-nu was only cached for x86_64-linux on Hydra (https://hydra.nixos.org/eval/1806741?filter=validator-nu&compare=1806726&full=), so if anyone is on aarch64-linux or darwin, they'll have to build it themselves. I opened https://github.com/NixOS/nixpkgs/pull/317390 for that.

Okay, so it's a derivation dependency on .#pretalxFull that we are talking about here.
$ nix why-depends .#overview .#pretalxFull
'git+file:///home/lorenz/src/github.com/ngi-nix/ngipkgs#overview' does not depend on 'git+file:///home/lorenz/src/github.com/ngi-nix/ngipkgs#pretalxFull'

$ nix why-depends --derivation .#overview .#pretalxFull
/nix/store/is8a59fb78wcfq3pr1kmjb08zz2jw8hk-overview.drv
└───/nix/store/bdyf0ziwmbyps7w3fng84ap3kap1rlsw-overview.html.drv
    └───/nix/store/63vgrk61sq14i0dsvsgw7kvwzm2njn3f-pretalx-2024.1.0.drv

$ nix run nixpkgs#nix-tree -- --derivation .#overview
[browse dependency tree]

TBH I do not understand why the derivation of .#overview depends on .#pretalxFull, and not on other packages in this repo. I have a suspicion that it is this wrapper:
https://github.com/ngi-nix/ngipkgs/blob/84f90068258507753acc67449f211d807c0a62d9/projects/Pretalx/service.nix#L51-L60

More likely it's indeed the cfg.package in the example, since that's rendered.

I only discovered the workaround in my first comment after noticing that services.ngi-pretalx.filesystem.static is the only option on https://ngi-nix.github.io/ngipkgs/ that defaults to a store path. But since overview only needs .default.text, we can simply pass a defaultText to get around that. So #260 should fix the issue.

Oh wow, that's a hack. Can't we just rework the option?

I'd say that this can be closed as fixed by #260.
$ git rev-parse HEAD
5cf02536124e27db576d6fec05333b0e015c33ce
$ nix why-depends --derivation .#overview .#pretalxFull
'git+file:///home/lorenz/src/github.com/ngi-nix/ngipkgs#overview' does not depend on 'git+file:///home/lorenz/src/github.com/ngi-nix/ngipkgs#pretalxFull'


Full Annotation Framework

This PR contains a full Annotation Framework
There are 5 different types of annotations:

Superset Annotations. The annotations introduced in  #3521
3.Events Annotations. Events are a list of dates with descriptions. They will be displayed as vertical lines. Their description will show up in the tooltips if you hover over them. They are fetched from a "table" slice, that contains the data. You can pick the time and description columns.
Interval Annotations. Just like Events but having a start and end date, they are rendered as a range.
Time Series Annotations. Timeseries are are added as an additional line on the line chart. The name and the display properties can be configured. The data is fetched from any timeseries slice.
Formulas Annotations. Formulas are added as an additional line to the chart. You will be able to enter a mathematical expression, that will be evaluated on the client side using "mathjs". You will be able to specify display properties. You will be able to specify any mathematical formula e.g

y = 500  (horizontal line)
y = 0.2x (line with inclination of 0.2)
y = x^2 (parabola)

Check out the new demo video:
https://www.youtube.com/watch?v=-0CgA3q39KI&feature=youtu.be
Couple screenshots:
Superset Annotations Config:

Configuring Interval Annotation

Dashboard with annotations:

Context Aware tooltips:

Error handling:

Loading indicators for annotations:

Coverage decreased (-0.07%) to 69.467% when pulling 9a252c153f4d046ceb0c5a9f46f3cb9e622b42a1 on tc-dc:fmenges/annotations into 255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master.

Maybe it makes sense to rename all of this from: annotations => overlays

Coverage decreased (-0.07%) to 69.467% when pulling 44e3444b61d0b960a9348a9ec0f27033c5a39b8a on tc-dc:fmenges/annotations into 255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master.

Nice, so these annotations would be stored inside the slice's json?
We'll need to make things clear and cohesive here between the server-side time "Annotations Layers"  https://github.com/apache/incubator-superset/pull/3521 and the other types of markers or annotations that would live on the slice itself. I'll try to get Eli (our designer) to chime in here.

No, it can handles both. Formula overlays are client side (I would have had to do too much plumbing work for server side, b.c. they probably should be datasources then).
The slice annotations are server side, but read only. Basically it assumes you have a table with annotations in SQL (e.g. your deploy history from jenkins, teamcity, ....). You can now create a regular table slice in Superset with (timestamp and event) and then have these superimposed on your line chart as horizontal lines.

Coverage decreased (-0.2%) to 69.327% when pulling 65040f91c0556e908a5e1bab80ea35e9c1c1c4c8 on tc-dc:fmenges/annotations into 255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master.

Coverage decreased (-0.2%) to 69.327% when pulling 65040f91c0556e908a5e1bab80ea35e9c1c1c4c8 on tc-dc:fmenges/annotations into 255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master.

Coverage decreased (-0.2%) to 69.327% when pulling 65040f91c0556e908a5e1bab80ea35e9c1c1c4c8 on tc-dc:fmenges/annotations into 255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master.

Bringing some of the comments from my last comment here https://github.com/apache/incubator-superset/pull/3521

using table viz slices as input for annotation is fragile, I'd like to see a new time_annotations viz which would be similar to table viz, but enforce having a time column, clearly point to columns for short and long descriptions, perhaps even a onClick link (optional) that defines where to go when click on the annotation. That viz could also look good on its own, as well as be used as input for other slices
can we break down the data driven annotations to a different PR?
I'm all for formula, vertical, and point markers, though I think we need a bit of a plan as to how all of these annotations come together. The Popover you have here is a very good starting point for this. I'd like to see the Popover have a dropdown for the type marker first, and then alter the form to only show the relevant options in that context.
for the data-driven annotations, there are considerations around whether they are fetched independently asynchronously or whether they become part of the existing data payload. If async, things get more complex on the visualization interface, having to deal with promise and such. Sounds like in many cases we can't render the markers until the actual data has landed.

BTW, I'm excited we got the ball rolling on all this and grateful for all the work that you're doing @fabianmenges. This is HUGE for Superset.

@mistercrunch

using table viz slices as input for annotation is fragile

I'm using 'table viz' for horizontal lines and intervals,
I'm using 'line viz' for point markers and line overlays,
You will be able to pick your column for title and description in the 'Annotation overlay' configuration.  Things like onclick should be handled in a separate PR, you would probably need to support some templating for this anyways.
If you still think we need a special slice for it, feel free to create one, I'll hook it up.

can we break down the data driven annotations to a different PR? ...

All the annotations types but Formula are data driven. Are you asking me to support only Formulas for now? This would result in deleting a whole bunch of code and make some of the architecture look pretty useless.

I'm all for formula, vertical, and point markers, though I think we need a bit of a plan as to how all of these annotations come together...

I'm making the popover dynamic for each Annotation type right now.
It already is, if you consider that when its a Formula you can enter the formula, but when it is any other type it is a "Slice Selector." For the slice selector you will be able to pass down 'Since' and 'Until', there is even more things we could pass down, e.g. (Filters, Mapping)
This is also where you could specify a 'Tilte' and 'Description' and 'Link' coloumn  for a dropdown of a list of all columns, but I probably won't be able to get that stuff into this PR.

for the data-driven annotations, there are considerations around whether they are fetched...

Fetching them independently, asynchronously and on the client has many advantages.

We can fetch all annotation layers in parallel (async), I did not see anything in your current python project configuration that would allow me to do this in a reasonable way in python, (e.g. no gevent, etc). I feel very strongly about not doing this synchronously.
Separation of concerns: Your charts will still load fast even if there is something wrong with your annotations that might be stored on a different system. Even if we would implement this in python asynchronously we would still have to wait for the timeout of each annotation layer before we could return data.
If AnnotationLayers are hidden and you 'unhide' them you only have to load the missing data and not all the data

to make all of this comprehensive, we'll need a s-ton of tooltips

I can take care of this. Would like to get that into a 2nd PR.
This will get deployed to our production environment by Friday. It would be great if we could nail out the architecture questions beforehand.

BTW, this library http://d3-annotation.susielu.com/ is only available for d3-v4, going to punt on point annotations, for now

Coverage decreased (-0.3%) to 69.905% when pulling 296b9c1275d091283c92476b8170008ccb5a60bd on tc-dc:fmenges/annotations into 03e2af8bd923dbdebbc70213b359d36fe89d7b42 on apache:master.

Coverage decreased (-0.3%) to 69.905% when pulling 296b9c1275d091283c92476b8170008ccb5a60bd on tc-dc:fmenges/annotations into 03e2af8bd923dbdebbc70213b359d36fe89d7b42 on apache:master.

@mistercrunch I addressed the issues you've brought up:

integrated the annotations from  #3521
columns for time, title and description are configurable are not hard coded, everything is configureable
tooltips and validation everywhere

I'm still fetching everything asynchronously but I've done extensive testing and error handling around this. I think the state is stable and polished enough for you to check it out...

Coverage decreased (-0.3%) to 69.905% when pulling dc204e01429f933a33f2f39dc6709e3d6a92d37e on tc-dc:fmenges/annotations into 03e2af8bd923dbdebbc70213b359d36fe89d7b42 on apache:master.

Coverage decreased (-0.1%) to 70.049% when pulling 5b23d7426cd06b81cf42879ed8cd40c551c4a127 on tc-dc:fmenges/annotations into 03e2af8bd923dbdebbc70213b359d36fe89d7b42 on apache:master.

BTW, if you want to go forward with this, I will need to write a migration script or some other logic to handle the current annotation_layer formData variable.

Coverage decreased (-0.1%) to 70.033% when pulling 70507486e423581ba15e8e6d5e12c602b9f7263a on tc-dc:fmenges/annotations into 18e459e19e83851f83e75b5987f3eb59fec9a5c8 on apache:master.

Coverage decreased (-0.1%) to 70.033% when pulling 70507486e423581ba15e8e6d5e12c602b9f7263a on tc-dc:fmenges/annotations into 18e459e19e83851f83e75b5987f3eb59fec9a5c8 on apache:master.

@fabianmenges this looks great, any plans when it will be ready?

@fabianmenges this looks great! :)

Bringing this revision up to date. Looking for some more feedback.

Any updates?
This is a really great Pull request! I am going to build tc-dc:fmenges/annotations today.

We just synced on this and are hoping to get this merged in the next couple of weeks.
After this core feature set is added we will continue to iterate on additional annotation functionality from there into 2018.

This would be unbelievable for us (I work in the Airbnb Trust team). We currently use Tableau to annotate both events on specific dates, as well as dynamic date ranges (e.g. today() - 2.weeks), and we'd love to have parity on our Superset slices.

I pulled the branch over and this is looking really solid at this point. I think we should get this in as soon as a few things are ironed out.
A few things:

looked like the "range filter" option is not compatible with the "Superset Annotation" type, meaning as the x axis range change the annotation doesn't move along with it. This is a bug prior to this PR too, maybe the solution is to disable annotations when Range Filter is selected, even to raise and say "range filter isn't compatible with annotations at the moment" when users combine both

i set up a wide "Superset annotation" and it doesn't show the rectangle (only the left bound), which makes me think we should add some annotations in load_examples for demo and user testing purposes (not sure if it has to be in-scope for this PR though)

I looked into mathjs before and other alternatives like safe-eval, evel and others. Eventually I'd like to add a new permission called coder or something and allow people that have that to write JS functions as part of chart definitions. We should have only one of these libs, not sure which one is best. If math.js is a subset of safe-eval we can probably refactor later

Awesome. Looking forward to getting this in.

I'm having trouble reproducing the 'range filter' bug. When I apply additional filters on the time axis (x-axis) in the 'Filter' section it changes the location of an 'Event' and 'Interval' annotation correctly. It also applies the range correctly when I change the dates in the Time sections. Do you mind sending me a screenshot or something else that shows me how to reproduce this?
You probably selected an 'Event' annotation which will only use the start_dttm of the annotation in the annotation table. If you want to see the 'rectangle' you will need to select 'Interval' annotation.
I think those should be different annotation types. mathjs allows people that can not code and only know math to configure these annotations, which is part of our use case. We want to empower PMs to build their own dashboards. That said, I like the idea of having a more powerful JS eval in addition to this.

This is awesome, thanks for all the hard word and for the value this is adding to Superset. Hoping to be able to work more closely in the future and provide feedback in a more timely fashion.

Thanks!

@fabianmenges I'm so excited for this! huge win all around! 🎉

Lovely!


Rework HashTable implementation

Description

Constructors are now aligned with .NET as all other methods.
Remove unnecessary properties related with load factor.
Add parameter checks that were missing in most methods.
Improve several methods and constructors.
Add IDictionaryEnumerator to follow .NET.
Move hot path methods to native.
Improve comments for Intellisense.
Add more Unit Tests.

Motivation and Context

Need to align with .NET and more important improve performance.

How Has This Been Tested?

Add more unit tests.

Execution comparison running Unit Tests in an ESP32 WROVER KIT
Ctor_IDictionary: 3040ms -> 486ms
Ctor_Int: 640ms -> 460ms
Add_ReferenceType: 20ms -> 8ms
Add_ClearRepeatedly: 40ms -> 27ms
AddRemove_LargeAmountNumbers: 12460ms -> 2400ms
Clone: 2170ms -> 1000ms
Clone_IsShallowCopy: 150ms -> 46ms
Clone_HashtableCastedToInterfaces: 840ms -> 345ms
ContainsKey: 1750ms -> 731ms
ContainsKey_EqualObjects: 20ms -> 16ms
Keys_ModifyingHashtable_ModifiesCollection: 1010ms -> 474ms
Values_ModifyingHashtable_ModifiesCollection: 1020ms -> 480ms
Hashtable_Add_Contains_Remove_Test1: 160ms -> 58ms
Hashtable_Add_Clear: 130ms -> 68ms
Hashtable_CheckKeys: 150ms -> 40ms
Hashtable_CheckValues: 260ms -> 134ms
Hashtable_Count: 150ms -> 51ms
Hashtable_Duplicate: 270ms -> 66ms
Hashtable_CopyTo: 390ms -> 115ms
Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[ ] New feature (non-breaking change which adds functionality to code)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[x] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[ ] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project (only if there are changes in source code).
[x] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[x] I have read the CONTRIBUTING document.
[x] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[x] I have added new tests to cover my changes.

Unit Tests are failing because WIN32 nanoCLR version is behind this.

Yeap! This is one of those that breaks pretty much everything. 😅


Wrong indentation level of repeat/until loop directly under case option label

I'd expect to write and see something like this:
codeunit 50100 Test
{
    trigger OnRun()
    var
        Customer: Record Customer;
    begin
        Customer.FindSet();

        case true of
            true:
                repeat
                    Message(Customer.Name);
                until Customer.Next() = 0;
        end;
    end;
}

but the autoformatter changes it to this:

That makes no sense.
The bug seems only to affect repeat, and not manifest if some other if condition or a redundant begin/end are added:

VS Code 1.55.2
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 7.1.441584
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

This formatting issue also applies to code in IF... THEN BEGIN... END statements:

This is whilst running AL Language extension v.9.3.642746.

I have never seen that. Did it just start in a new version?

I have the same problem:

Please solve this quick!!
If this remains we cant use Visual Studio Code anymore (mayby Notepad++ in the meantime)

@geertsj If this behavior is new, then you can also downgrade the AL Language extension to a working version.

@NKarolak I have downgraded to v9.2.639332. But I restart VSC this extension is autonatically upgraded to v9.3.642746. How can I skip that?

That's weird. So far, it has always worked for me.
Did you downgrade that way?

@NKarolak  I have found a setting like this:

Or check your: c:\Users<username>\AppData\Roaming\Code\User\settings.json
"extensions.autoCheckUpdates": false

BTW are you running the latest version of VS Code? Mine is 1.68.1

Mine is version: 1.68.1

If you do not set:
"extensions.autoCheckUpdates": false
(or it is true) thenwhen you starts VSC or restarts the estension AL Language is automatically updated from v9.2.639332 to v9.3.642746. Normally no problem but in this case the version should stay v9.2.639332 while this problem is not solved by MS.

I am using VSC 1.68.1.  I rolled back the AL Language extension to v.9.0.615906 (for additional reasons).  Code formatting works fine in that build.
One can also control the way that extensions are updated from the Extensions panel:

So, this issue from April 2021 has been accepted 4 days ago, and it broke the situation even more...?
I followed the tips above from @NKarolak and I rolled back to version 9.2.639332 from 1 week ago, and now this is back to normal.
Hopefully this will be fixed soon, and not in Aug 2023.

@markborges Indeed, we are a week further and Microsoft still hasn't released a hotfix for this extension "AL Language". I think this is a major issue (all over the world?).

@geertsj:
At least one has the option to roll back to a prior version as a stopgap.

@geertsj @markborges @bernalfr @NKarolak they rolled out an update 22hrs ago. Looks like fixed to me.

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 42990 and VS Code Extension Version 10.0.645962.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


Not capable with Version Control Mode:Perforce

Overview
when i use perforce as version control, the MR toolkit will always show "Enable Visiable MetaFiles" dialog. Actually, perforce is using Visiable MetaFiles.
Expected Behavior
won't show that dialog
Actual Behavior
always show "Enable Visiable MetaFiles" dialog
Steps to reproduce
(Links to sample github project preferred)
Just using Perforce as version control.
the code in HoloToolkit.Unity.EnforceEditorSettings.cs
Line 41 will check the version control state.
Please change to  if (!EditorSettings.externalVersionControl.Equals("Visible Meta Files")&&!EditorSettings.externalVersionControl.Equals("Perforce"))
Unity Editor Version
2017.4.2f2
Mixed Reality Toolkit Release Version
2<IP_ADDRESS>

Closing issues older than 180 days. If this is still an issue, please reactivate with recent information.


Added support for line comments between :deps

Now line comments don't "break" the loop in CodeBlock::from_original_user_code.
Augmented one of the integration tests with a line comment interleaving the commands like :dep.

Arguably, it would be better to add a test instead of augmenting an existing one. However, I decided not to do it because the test suit already runs somewhat slow.

Thanks @JohnScience !
Looks like clippy is complaining
error: this `if` has identical blocks
Error:    --> evcxr/src/code_block.rs:217:46
    |
217 |               } else if line.trim().is_empty() {
    |  ______________________________________________^
218 | |                 // Ignore blank lines, otherwise we can't have blank lines before :dep commands.
219 | |             } else if line.starts_with(r"//") {
    | |_____________^
    |
    = note: `#[deny(clippy::if_same_then_else)]` on by default
note: same as this
   --> evcxr/src/code_block.rs:219:47
    |
219 |               } else if line.starts_with(r"//") {
    |  _______________________________________________^
220 | |                 // Ignore comments
221 | |             } else {
    | |_____________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else

error: could not compile `evcxr` due to previous error
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

I don't object to that clippy lint being turned off if you think it's unreasonable.

Thanks @JohnScience !
Looks like clippy is complaining
error: this `if` has identical blocks
Error:    --> evcxr/src/code_block.rs:217:46
    |
217 |               } else if line.trim().is_empty() {
    |  ______________________________________________^
218 | |                 // Ignore blank lines, otherwise we can't have blank lines before :dep commands.
219 | |             } else if line.starts_with(r"//") {
    | |_____________^
    |
    = note: `#[deny(clippy::if_same_then_else)]` on by default
note: same as this
   --> evcxr/src/code_block.rs:219:47
    |
219 |               } else if line.starts_with(r"//") {
    |  _______________________________________________^
220 | |                 // Ignore comments
221 | |             } else {
    | |_____________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else

error: could not compile `evcxr` due to previous error
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

I don't object to that clippy lint being turned off if you think it's unreasonable.

It's reasonable, believe.


Removed duplicate License badage from README.md

Removed duplicate text.

Doesn't notice that on your last PR, thanks @geekcom, greetings from Peru.


Browser query (MATCH_ALL)

Describe the feature request?
The old SDK allowed setting the MATCH_ALL flag for the browser query. Enabling this resolved most of the reports we were getting for the SDK failing to find a browser.
I don’t see this option with this new SDK (please correct me if I’m wrong). Are the issues with finding browsers going to come back?
New or Affected Resource(s)
No idea
Provide a documentation link
No response
Additional Information?
No response

I think we've fixed most issues with browser compatibility by default in the new SDK! So I don't expect you'll need to customize that flag.  Please give it a try and let me know.
The new SDK is actually far more configurable, so I can point you in the direction of how to customize it if you find you need to.

That's great to hear! We won't know for sure until it's tested in production. If we start getting lots of those reports again I'll raise a new issue.


Crash to desktop after adding C# script to node then deleting, then readding+re-deleting a few times (3.2.4 rc5 mono)

Godot version:
Godot_v3.2.4-rc5_mono_win64

OS/device including version:
Win10 Nvidia 1650

Issue description:

Stumbled across this issue by adding ,then deleting then readding a c# sscript to a 3d node
Steps to reproduce:
1)Create a new blank project
2)Add a spatial 3D (dunno if this exact type of node is required, but this is how i stumbled on it)
3)Save project and make the node the default 'main' scene
4)add c# script to it. Save it close. Save project again.
5)run the project.
6)Click the node and remove the script. Save the Project
7)Move the c# script to the trash from the file editor.
8)run the project.
9)Repeat steps 4 to 8 a few times. It will crash on run eventually
Minimal reproduction project:

It will work on any new project.
here is a pastebin of the mono  log
https://pastebin.com/MPiUfrSd

@rick551a Can you reproduce this in 3.2.3?

Yes, this issue is present, 100% reproducible, in 3.2.3 mono stable also.
On windows7 it says "Godot has stopped working" before crash, on win10 it just crashes without warning.
Here is the event log error message:
'''
Faulting application name: Godot_v3.2.3-stable_mono_win64.exe, version: <IP_ADDRESS>, time stamp: 0x00000000
Faulting module name: Godot_v3.2.3-stable_mono_win64.exe, version: <IP_ADDRESS>, time stamp: 0x00000000
Exception code: 0xc0000005
Fault offset: 0x0000000002b63414
Faulting process id: 0xa40
'''

Reproduces for me on Windows 10, 3.3-rc7. Also on a build of b076150b086a5001b190a9a20a425d1bc842fe21 (3.x tip).
I simplified the repro:

New project, make a 3d scene, save it.
Create/attach a C# script to the node.
Save.
Click "Build".
Detach the script from the node.
Save.
Delete the script in the Godot file browser.
Click "Build".
Create/attach a C# script to the node. (Any name--same as the first script or not.)
Save.
Click "Build"
Crash!

[0] GDMonoClass::get_nesting_class (c:\proj\godot\modules\mono\mono_gd\gd_mono_class.cpp:102)
[1] GDMonoClass::get_name_for_lookup (c:\proj\godot\modules\mono\mono_gd\gd_mono_class.cpp:90)
[2] CSharpLanguage::reload_assemblies (c:\proj\godot\modules\mono\csharp_script.cpp:802)
[3] _GodotSharp::_reload_assemblies (c:\proj\godot\modules\mono\mono_gd\gd_mono.cpp:1404)
[4] MethodBind1<_GodotSharp,bool>::call (c:\proj\godot\core\method_bind.gen.inc:867)
[5] Object::call (c:\proj\godot\core\object.cpp:919)
[6] MessageQueue::_call_function (c:\proj\godot\core\message_queue.cpp:250)
[7] MessageQueue::flush (c:\proj\godot\core\message_queue.cpp:299)
[8] SceneTree::idle (c:\proj\godot\scene\main\scene_tree.cpp:543)
[9] Main::iteration (c:\proj\godot\main\main.cpp:2123)
[10] OS_Windows::run (c:\proj\godot\platform\windows\os_windows.cpp:3440)
[11] widechar_main (c:\proj\godot\platform\windows\godot_windows.cpp:162)
[12] _main (c:\proj\godot\platform\windows\godot_windows.cpp:184)
[13] main (c:\proj\godot\platform\windows\godot_windows.cpp:196)
[14] __scrt_common_main_seh (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[15] BaseThreadInitThunk

Exception thrown: read access violation.
**this** was nullptr.

Might be related, same method name on call stack: https://github.com/godotengine/godot/issues/46777.

Repros on master, too. (f96392a2b5ee1ebd9c14c92bdcd24d25e8b7774b) If I add a null check specific to what's happening here, I can't get it to repro, and things seem to behave normally: PR https://github.com/godotengine/godot/pull/47691.

Fixed by #47691.


CTRL-C doesn't work with py-rattler

Hello, I made a script that uses py-rattler and it seems like I can't stop the script using CTRL-C. Or at least the rattler.solve function can't be cancelled with CTRL-C.
Is there any trick to make it work is is this a bug?
Thanks!

Good find! We actually made the solver "cancellable" so in theory this should work fine. But the CTRL+C behavior with bindings is always a bit tricky.
https://pyo3.rs/main/faq#ctrl-c-doesnt-do-anything-while-my-rust-code-is-executing
We should be able to use Python::check_signals to handle CTRL+C that is caught by the Python process. We need to find a mechanism to wire this up to our long-running functions (e.g. downloading, solving, ...).

Interestingly, the new async solve on main solves the problem. I only saw that after spending a couple of hours trying what you suggested...

great!

Just tried with py-rattler 0.6.0 and it seems to be fixed now. I'm going to close this.

Great!

Btw. if you want to try a lightning fast experience, you can try the conda-forge channel from https://fast.prefix.dev/conda-forge. That uses the sharded repodata (but packages still come from the regular Anaconda server).


Modal doesn't close on the first click on the overlay after click on elements containing event.stopPropagation() inside modal

Summary:
When opening a second modal from within a first modal, closing the second modal results in the first modal not closing on the first click on the overlay. Instead, it requires a second click to close. This issue is similar to issue #958. However, the solution provided there is not really suitable for our cross-platform project, which uses components from react-native, and I would like to avoid creating separate button components for the web modal, in which event.stopPropagation() would be removed, in order to achieve the correct behavior.
Steps to reproduce:

Open the provided code sandbox: https://codesandbox.io/s/react-modal-layout-issue-xgfsvk
Click on the "Open Modal" button to open the first modal.
Click on the icon in the top left corner of the first modal to open the second modal.
Close the second modal by clicking on the overlay or close button.
Attempt to close the first modal by clicking on the overlay.

Expected behavior:
The first modal should close after the first click on the overlay.
Link to example of issue:
https://codesandbox.io/s/react-modal-layout-issue-xgfsvk
Additional notes:
This issue also occurs when closing a modal by clicking on the close button, then reopening it and attempting to close it by clicking on the overlay. The modal only closes after the second click, not the first. This is a kind of standard behavior, so you can reproduce the problem for both the first and second modals. Below are the steps to reproduce the problem for the first modal.
Steps to reproduce:

Open the provided code sandbox: https://codesandbox.io/s/react-modal-layout-issue-xgfsvk
Click on the "Open Modal" button to open the first modal.
Click on the icon in the top right corner of the first modal to close it.
Click on the "Open Modal" button again to open the first modal.
Attempt to close the first modal by clicking on the overlay.

I would like to propose a simple solution to this issue:
In the handleOverlayOnMouseDown method (src/components/ModalPortal.js:321), add this.shouldClose = null; to allow the modal to close in cases where the mouse press started on the overlay. Then, in the handleContentOnMouseDown method (src/components/ModalPortal.js:331), add event.stopPropagation(); as otherwise, there's an issue where the modal would close if OnMouseDown was called within the modal content, but OnMouseUp was called in the layout. I wanted to create a PR with these changes, but I don't have the necessary permissions.
Both of these fixes seem logical to me – if a user clicks on the layout, they likely want to close the modal. Propagation through the content to the layout doesn't seem to provide any benefits, and it appears reasonable not to trigger layout events when clicking on the content.
I would also like to note that I have already applied these changes to our project via a patch, and after testing, our QA reported that the issue was resolved, and no new issues were discovered.

@ErikDeviashin can i solve this issue ?

@msubham193 If you have a right to push in repo, of course you can.
@diasbruno Can you have a look to this issue please?

@msubham193 go for it! Let me know if you need anything.

@msubham193 Good day! Have you seen my comments in the PR? Can you please correct what is indicated in the comments?

@diasbruno Ok, his no react 5 days already, what should I do to make this small fix? It's already third issue with same problem, I really want to solve it and move on

I faced with the same problem. Do we have any workaround before fixing it?

I have the same problem. In my case I don't have a second modal but I have a drag handler inside my modal content and when I trigger a drag event using the mouse it then requires two clicks on the overlay to close the modal.
I haven't looked into it deeply but I guess it's the same handleOverlayOnMouseDown / handleContentOnMouseDown issue reported by @ErikDeviashin above.

From what I saw, the issue is actually is that either (or both) components - overlay and content, are receiving an event that is not theirs and they are setting up the flags incorrectly.
The ideal solution is to only act if the event has the event.currentTarget = overlay or content.

I've assigned to me to test the lateral buttons...but now I can't remove.
This issue is free to anyone who want to work on it.


[stable/sentry] Fix inconsistent SENTRY_SECRET_KEY among the pods when not set explicitly.

What this PR does / why we need it:
Make Deployment and Job pods dependent on secret.yaml content (especially SENTRY_SECRET_KEY when it is not set explicitly) follow the Secret changes in sync. Symptoms were (after some deployments cannot log in, after some deployments cannot accept errors). Also, document the ability to set SENTRY_SECRET_KEY explicitly.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ x ] DCO signed
[ x ] Chart Version bumped
[ x ] Variables are documented in the README.md
[ x ] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/lgtm


V0.2.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7ea9558) 100.00% compared to head (b22aff9) 100.00%.
Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines           97        99    +2
=========================================
+ Hits            97        99    +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


How often do you refresh the list?

Hi there,
I added react-component tag to my library more than one day ago but it's still not indexed. Is there something else what I missed?

Hi @Kureev, we're moving from manual submissions to automated data retrieval. At the same time, we are working on a new section for react components for web, and reviewing a lot of stuff manually.  Having said that, I just included your package now :wink: It should be on the site now. Thanks for your contribution.

Thanks for that! :wink:


Failures on [cfe] Handle member access on extension type receivers

There are new test failures on [cfe] Handle member access on extension type receivers.
 Kind of a runtimeType call was previously InstanceAccessKind.Object, but it's now InstanceAccessKind.Instance. If this is intentional I'll update the code generator.

I'm fixing this in https://dart-review.googlesource.com/c/sdk/+/334460. We don't really care about the kind of an instance get so I removed the kind check. I will be updating other places where we check the instance invocation (or get, set) kind.

Thanks @osa1. This was an unintentional change, I'll look into it.


Workbench broken after startup

reopened a workspace this morning and the bottom panel was broken, console shows error below

  ERR Cannot read property 'setViewVisible' of undefined: TypeError: Cannot read property 'setViewVisible' of undefined
    at O.setPanelHidden (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6737:611)
    at Object.hidePart (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6685:609)
    at _.resetActiveComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6552:609)
    at _.hideComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6551:529)
    at e.hideComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6690:467)
    at e.onDidChangeActiveViews (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6689:321)
    at e.onDidRegisterPanels (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6687:917)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6689:651
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:96:67)
    at l.registerComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3147:308)
    at l.registerPanel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4162:391)
    at k.registerPanel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6039:533)
    at k.registerViewletOrPanel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6038:777)
    at k.onDidRegisterViewContainer (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6032:365)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6030:59
    at Array.forEach (<anonymous>)
    at new k (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6030:43)
    at d._createInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1682:519)
    at d._createServiceInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1684:540)
    at d._createServiceInstanceWithOwner (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1684:65)
    at d._createAndCacheServiceInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1683:756)
    at d._getOrCreateServiceInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1683:44)
    at Object.get (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1681:596)
    at O.initLayout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6712:220)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6781:907
    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1681:465)
    at O.startup (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6781:758)
    at q.open (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7941:911)
workbench.desktop.main.js:1700   ERR No application in the Launch Services database matches the input criteria.: Error: No application in the Launch Services database matches the input criteria.

@sbatten related/duplicate:

Maximum call stack size when opening panel #105288
Bottom panel sometimes blank when opening a new window #103886
Cannot read property 'setViewVisible' of undefined #101650
TypeError: Cannot read property 'setViewVisible' of undefined #90836

setViewVisible is a grid method and this seems coming from layout which I do not have any clue.

Based on the stack and investigation, this happens when the restored panel is empty and we try to hide the panel in that case but the workbench is not fully initialized. I don't have a good way to reproduce it so I've just prevented hiding the panel before the workbench is initialized and hopefully this is sufficient.

I've not seen this for the last week, marking verified


Documentation to test and publish to OperatorHub.io is inconsistent

I'm trying to release a new version of our WildFly Operator but I'm not able to test it.
The doc assumes that I'm using a legacy manifest format for the operator.
However OLM does not provide OperatorSource anymore (It's not in the 0.13.0 version mentioned in the doc).
I'm not sure how we are now supposed to test our upstream operators before publishing to operatorhub.io.

Is the doc up to date with OLM and OperatorHub.io submission process?
Are we required to provide operator bundle?
If not, is there a valid configuration for using a CatalogSource that would point to my app registry on quay.io?

@jmazzitelli, please check https://github.com/operator-framework/community-operators/blob/master/docs/using-current-test-suite.md

@jmesnil @J0zi Here is an update: https://github.com/operator-framework/community-operators/pull/2579
Let me know what you think on that PR.


Completed Task 1

successfully completed my CSEDGE task-1 i.e Landing page in Web Development internship

I have completed my task-1

successfully completed my CSEDGE task-2 i.e Gallery in Web Development internship

successfully completed my CSEDGE task-3 i.e portfolio in Web Development internship

successfully completed my CSEDGE task-4 i.e Student Enrollment Form
in Web Development internship

I have completed all the tasks successfully.

Hello @Hariteja11 We've seen your video on YouTube..!

Yaah I have posted a video is there any problem with it?
On Sun, 2 Jun 2024, 9:00 pm CSEdge, @.***> wrote:

Hello @Hariteja11 https://github.com/Hariteja11 We've seen your video
on YouTube..!
—
Reply to this email directly, view it on GitHub
https://github.com/CSEdgeOfficial/Web-Development-Internship/pull/26#issuecomment-2143900667,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5LF6GDXQLDJYOBIGTOTDDLZFM3BNAVCNFSM6AAAAABIIZJUSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHEYDANRWG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Hariteja11 Not at all!  If you'd like to make another video, you can! We've even updated our tasks. Check them out in the new repositories, which have also been updated on the website. There are exciting new things coming soon!

Awesome, thank you so much!
On Thu, 6 Jun 2024, 11:13 am CSEdge, @.***> wrote:

@Hariteja11 https://github.com/Hariteja11 Not at all! If you'd like to
make another video, you can! We've even updated our tasks. Check them out
in the new repositories, which have also been updated on the website. There
are exciting new things coming soon!
—
Reply to this email directly, view it on GitHub
https://github.com/CSEdgeOfficial/Web-Development-Internship/pull/26#issuecomment-2151454174,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5LF6GENKODXUTAXCQ4CKVDZF7ZGRAVCNFSM6AAAAABIIZJUSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRGQ2TIMJXGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Allow force delte for npm metadata

Only when CHECK_CACHE_ONLY is true, we can bypass the readonly for hosted repo.

LGTM.

@sswguo the 404 is caused by the getSpecialPathInfo which miss the second param. by default, it use maven. pls review again.


MRG, MAINT: Smaller PNGs during doc build

Also modernizes our inclusion of backrefs, and considates CircleCI apt-get to a single line.

Manually killing Travis and Azure non-style because they are not relevant

Seems to work, in it goes

did you quantify the gain?

In the Sphinx-gallery PR I did some testing suggesting you could get 20-25% gains with little added build time, but didn't actually test here. Looking at the mne-tools.github.io right now, we have du -hs of dev/_images of 98M and the last couple builds took 1:21:55 and 1:28:04. The master build from merging this PR timed out on plot_mne_dspm_source_localization, so we'll have to wait for another hour and a half to see the sizes and times now...

I was wrong about the times above, should have listed them as 1:45:40 and 1:53:23. CircleCI finished and uploaded, looks like before/after:

dev/_images size decreases from 98M to 79M (thumbs only: 2.9M to 2.4M)
Build time increases from 1:53:23 to 2:00:30

There is a lot of variability in the build times, so this could actually be a bit better or worse. But it doesn't look like it's going to end up being too bad.

ok so a 20% decrease roughly

yeah


OCSP responder returns bad HTTP status code (http://ocsp.int-x3.letsencrypt.org): 400

This looks like a different issue from #70
This is a permanent issue, happening on multiple servers. We are running version 0.11.0-1 of lua-resty-auto-ssl and we do have a resolver set in the nginx config. Our setup works, except for the OCSP errors in the logs. We originally thought this was only happening for one domain, so we deleted it and got a new cert, but the issue happens still on every domain.
I tried to debug the fullchain_der and ocsp_req from auto-ssl/ssl_certificate.lua but it is binary. The req.body from the OCSP endpoint also contains binary, so something looks wrong.
Has anyone else had this issue? It started happening a few months ago, we didn't have it before. Any idea how to debug that issue? Thanks
Edit: Here's the full error line from the log:
2017/07/10 17:21:24 [error] 19066#0: *6 [lua] ssl_certificate.lua:221: set_cert(): auto-ssl: failed to set ocsp stapling for example.com - continuing anyway - failed to get ocsp response: OCSP responder returns bad HTTP status code (http://ocsp.int-x3.letsencrypt.org): 400

OCSP encodes the requests and responses as ASN.1, which encoded in the binary DER format most of the time. Seeing a binary request and response is therefore normal. Even though I doubt that ocsp.create_ocsp_request would generate invalid requests: can you please share the value of ocsp_req as hex dump or base64 with us? That should be possible using ngx.encode_base64.

Thanks for your answer
Here's the ocsp_req as base64 for a test domain: MFMwUTBPME0wSzAJBgUrDgMCGgUABBR+5mrncpqz/PiiIGRsFqEtYHEIXQQUqEpqYwR93brm0Tm3pkVl7/Oo7KECEgPm9BFOzTXMq27x5uEc1aZpoQ==
I can reproduce the 400 from Let's Encrypt's OCSP server with the following curl request (with any data as the POST body):
curl -v -H 'Content-Type: application/ocsp-request' http://ocsp.int-x3.letsencrypt.org --data "anything"

As you probably know 400 just means "Bad Request". Since anything isn't remotely a valid OCSP request, the let's encrypt server rightfully responds with, well, "Bad Request".
The big question is why it does that for a seemingly valid request generated by openresty/auto-ssl. I checked the base64 data you provided. It's at least valid ASN.1, seems to match the schema for OCSP requests. @GUI any ideas?

Are we the only ones getting this issue? Thanks :)

@gregkare: Apologies for the delay. I've just checked the last week of our production logs to see if we've experienced any failures like this, but I only found one failure of a 503 response during this Let's Encrypt partial outage. So if you're seeing this consistently, I'm not exactly sure what would be causing it, but let's see if we can figure out what's going on...
As a first step to debugging this, could you see if you're able to get a successful OCSP response using the openssl command line tool? On the server where this certificate is located, you can do this by:

Extract the OCSP URL from the certificate:
sudo openssl x509 -in /etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/cert.pem -noout -ocsp_uri

Run the openssl ocsp command using the OCSP URL found:
sudo openssl ocsp -no_nonce \
  -issuer /etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/chain.pem \
  -verify_other /etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/chain.pem \
  -cert /etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/cert.pem \
  -url OCSP_URL_HERE -header "Host" "OCSP_HOST_HERE"

The last line should be something like -url http://ocsp.int-x3.letsencrypt.org -header "Host" "ocsp.int-x3.letsencrypt.org" (note the url includes http:// while the Host header does not). Interestingly, I do get 400 responses back if I mess up the Host header, but that may be a red herring, since I'm not sure how that would be incorrect in our request.

If that command succeeds, you should see something like:
Response verify OK
/etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/cert.pem: good
	This Update: Jul 22 16:00:00 2017 GMT
	Next Update: Jul 29 16:00:00 2017 GMT

If the command succeeds, then that might help pinpoint the issue to something lua-resty-auto-ssl is doing that's different from the request OpenSSL makes. But if the command fails, then that might point to some other issue that's specific to this environment (eg, like some proxy in the network environment munging the binary data on the outgoing OCSP request).

Thanks for your reply. I just got a successful response when running the openssl ocsp command. I'll try to debug the resty-auto-ssl request

Well, at least that helps narrow things down. If you're comfortable hacking on the source code, a few other ideas for debugging:

Add a line to log the length of the ocsp_req variable (ngx.log(ngx.ERR, "ocsp_req len: " .. #ocsp_req)
create_ocsp_request accepts a max_len argument, which "usually defaults to 4KB." I think that should be plenty big for the OCSP request data, but you could try explicitly setting this in case the default in your environment is somehow smaller (or if the logged length is right at 4KB already). So you could change this line to something like local ocsp_req, ocsp_request_err = ocsp.create_ocsp_request(fullchain_der, 8192). (Although, in reviewing nginx's tests, it looks like it should actually return an error if the buffer size is too small, so this might not be it.)
If you can share what domain you're experiencing this on, I can also try to debug this, since OCSP only involves the public certificate (you're also welcome to email me directly if you'd prefer not to share the domain here).

Similarly, if you want to share the contents of the /etc/resty-auto-ssl/letsencrypt/certs/YOUR_DOMAIN/fullchain.pem (and again, this would be your public certificate only, not your private key), then we could put together a very simple test case, since that should be the only input required for our OCSP stapling (we translate it to DER format, and then that should be the only input).

I've seen this happen during the latest LetsEncrypt outage as well, but no longer.

I am having same problem.

@GUI I have been able to successfully run the same request that resty-auto-ssl is doing using curl with the same binary data (I printed it as Base64 in ssl_certificate.lua and then decoded it into a file). The test domain is 5stage.karekinian.com, the ocsp_req len is 85. The base64 encoded OCSP request is MFMwUTBPME0wSzAJBgUrDgMCGgUABBR+5mrncpqz/PiiIGRsFqEtYHEIXQQUqEpqYwR93brm0Tm3pkVl7/Oo7KECEgNRX8zEHuS3GQWUu1yiv3Q4Fg==. Changing the max_length didn't change anything, since the ocsp_req is small.
For reference here's my successful curl request with the oscp_req saved as test.bin:
curl -v -H 'Content-Type: application/ocsp-request' http://ocsp.int-x3.letsencrypt.org --data-binary @test.bin

I don't see anything wrong with the httpc:request_uri call in https://github.com/GUI/lua-resty-auto-ssl/blob/v0.11.0/lib/resty/auto-ssl/ssl_certificate.lua#L141, so it looks like something about the binary data itself is wrong, even though it works with my request using curl
Here's the fullchain for this domain:
-----BEGIN CERTIFICATE-----
MIIGDTCCBPWgAwIBAgISA1FfzMQe5LcZBZS7XKK/dDgWMA0GCSqGSIb3DQEBCwUA
MEoxCzAJBgNVBAYTAlVTMRYwFAYDVQQKEw1MZXQncyBFbmNyeXB0MSMwIQYDVQQD
ExpMZXQncyBFbmNyeXB0IEF1dGhvcml0eSBYMzAeFw0xNzA4MjcxMzM0MDBaFw0x
NzExMjUxMzM0MDBaMCAxHjAcBgNVBAMTFTVzdGFnZS5rYXJla2luaWFuLmNvbTCC
AiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAK+fVbJOnoeNoI1x3hwenw3N
a7vc4Z0ec+lIqpnvXvSMumeaD/SlnxdowIBrLhy1nLDIon6IKxpYrcjC2ac/HdHT
vi4JNg5rfSBgtATpw+EQ1Ut9ss+Tq9DVQKu4YttmMQH0dgfLCBYDDmtRrzIst92I
JOX3W6ulTYJpkOI4GvBFWqLnqyOxCJzf5Hjy6ABC5PepW5LkitEB1oBc65lrbAuR
sIGeb7TUSQDc8GMl0OimuYIg2HjytSJOT9bIu6u9rl3yuoX7W/OxTTdFMvk2kPfI
Rojb3nl3YFKLe08yuHylw87VacV9s3h/83LCajfd5NA/NWMEQGDoJE74aqzdNGLk
RTZ8P0VuLFl8LoY1GNmQzosvsuSvYCJLb94CE1c3aPGODY0yN7YtGlE7A96dnyUE
otn59Wz40QNXXtG04cHbPkBF2YF1rY3LIknGizuGYIQF/3kaa5lBWpwdHvDcHNcU
2WKl4d3xtG3eGMoptdu0KakMPqyPISqmMJu9zODdLLblENMPnKrhChICgV7tuEEJ
szqcxxgTwnuPjYo4sBF3NADIcoEJeKVIXlQvGX+RAVCl9f564ShhQ6E3v5kmyVQP
0vkbM0JORxO8QZbS3CSuyA02rc897Ua+Y3N6L73m/JXYOXf5PPnE/XmZJdvNLE6h
Qc0vdvIrWCELnCnlQcADAgMBAAGjggIVMIICETAOBgNVHQ8BAf8EBAMCBaAwHQYD
VR0lBBYwFAYIKwYBBQUHAwEGCCsGAQUFBwMCMAwGA1UdEwEB/wQCMAAwHQYDVR0O
BBYEFDAWPdVQWDpduNb/DzPf0xtGgKiIMB8GA1UdIwQYMBaAFKhKamMEfd265tE5
t6ZFZe/zqOyhMG8GCCsGAQUFBwEBBGMwYTAuBggrBgEFBQcwAYYiaHR0cDovL29j
c3AuaW50LXgzLmxldHNlbmNyeXB0Lm9yZzAvBggrBgEFBQcwAoYjaHR0cDovL2Nl
cnQuaW50LXgzLmxldHNlbmNyeXB0Lm9yZy8wIAYDVR0RBBkwF4IVNXN0YWdlLmth
cmVraW5pYW4uY29tMIH+BgNVHSAEgfYwgfMwCAYGZ4EMAQIBMIHmBgsrBgEEAYLf
EwEBATCB1jAmBggrBgEFBQcCARYaaHR0cDovL2Nwcy5sZXRzZW5jcnlwdC5vcmcw
gasGCCsGAQUFBwICMIGeDIGbVGhpcyBDZXJ0aWZpY2F0ZSBtYXkgb25seSBiZSBy
ZWxpZWQgdXBvbiBieSBSZWx5aW5nIFBhcnRpZXMgYW5kIG9ubHkgaW4gYWNjb3Jk
YW5jZSB3aXRoIHRoZSBDZXJ0aWZpY2F0ZSBQb2xpY3kgZm91bmQgYXQgaHR0cHM6
Ly9sZXRzZW5jcnlwdC5vcmcvcmVwb3NpdG9yeS8wDQYJKoZIhvcNAQELBQADggEB
AI1HKdB3gQP9zSzMSIp3zGPumQc6sD3xqoG2b0IPNWDzeQjN+41mrKWq8FuDG5sG
kpH9Z2W5vfTmemU4WD7hyWpewAZLueVDgXKSu5rry64fz9Wyj+kGhrYM1jSG59Wf
1rRjIWfytjjpiW7VoW/bvud2JHJpBiQM/PjLUVVLHgqjX52mRwylMdDPSuIlPym4
wu4s2IyCcZjI6Xz/cC6HZW/geftJqLEmRgDX2Y9yMjF4N3m0Y8kx99/O/nhn5u33
4nAKXP8Ju03HFjvB17LgyMIj/pBmTFNgmtq4AtleFSWIIw/yFVJiVGuTns9295Jl
L23LOTQypOfyDVJ7FCFZvTo=
-----END CERTIFICATE-----
-----BEGIN CERTIFICATE-----
MIIEkjCCA3qgAwIBAgIQCgFBQgAAAVOFc2oLheynCDANBgkqhkiG9w0BAQsFADA/
MSQwIgYDVQQKExtEaWdpdGFsIFNpZ25hdHVyZSBUcnVzdCBDby4xFzAVBgNVBAMT
DkRTVCBSb290IENBIFgzMB4XDTE2MDMxNzE2NDA0NloXDTIxMDMxNzE2NDA0Nlow
SjELMAkGA1UEBhMCVVMxFjAUBgNVBAoTDUxldCdzIEVuY3J5cHQxIzAhBgNVBAMT
GkxldCdzIEVuY3J5cHQgQXV0aG9yaXR5IFgzMIIBIjANBgkqhkiG9w0BAQEFAAOC
AQ8AMIIBCgKCAQEAnNMM8FrlLke3cl03g7NoYzDq1zUmGSXhvb418XCSL7e4S0EF
q6meNQhY7LEqxGiHC6PjdeTm86dicbp5gWAf15Gan/PQeGdxyGkOlZHP/uaZ6WA8
SMx+yk13EiSdRxta67nsHjcAHJyse6cF6s5K671B5TaYucv9bTyWaN8jKkKQDIZ0
Z8h/pZq4UmEUEz9l6YKHy9v6Dlb2honzhT+Xhq+w3Brvaw2VFn3EK6BlspkENnWA
a6xK8xuQSXgvopZPKiAlKQTGdMDQMc2PMTiVFrqoM7hD8bEfwzB/onkxEz0tNvjj
/PIzark5McWvxI0NHWQWM6r6hCm21AvA2H3DkwIDAQABo4IBfTCCAXkwEgYDVR0T
AQH/BAgwBgEB/wIBADAOBgNVHQ8BAf8EBAMCAYYwfwYIKwYBBQUHAQEEczBxMDIG
CCsGAQUFBzABhiZodHRwOi8vaXNyZy50cnVzdGlkLm9jc3AuaWRlbnRydXN0LmNv
bTA7BggrBgEFBQcwAoYvaHR0cDovL2FwcHMuaWRlbnRydXN0LmNvbS9yb290cy9k
c3Ryb290Y2F4My5wN2MwHwYDVR0jBBgwFoAUxKexpHsscfrb4UuQdf/EFWCFiRAw
VAYDVR0gBE0wSzAIBgZngQwBAgEwPwYLKwYBBAGC3xMBAQEwMDAuBggrBgEFBQcC
ARYiaHR0cDovL2Nwcy5yb290LXgxLmxldHNlbmNyeXB0Lm9yZzA8BgNVHR8ENTAz
MDGgL6AthitodHRwOi8vY3JsLmlkZW50cnVzdC5jb20vRFNUUk9PVENBWDNDUkwu
Y3JsMB0GA1UdDgQWBBSoSmpjBH3duubRObemRWXv86jsoTANBgkqhkiG9w0BAQsF
AAOCAQEA3TPXEfNjWDjdGBX7CVW+dla5cEilaUcne8IkCJLxWh9KEik3JHRRHGJo
uM2VcGfl96S8TihRzZvoroed6ti6WqEBmtzw3Wodatg+VyOeph4EYpr/1wXKtx8/
wApIvJSwtmVi4MFU5aMqrSDE6ea73Mj2tcMyo5jMd6jmeWUHK8so/joWUoHOUgwu
X4Po1QYz+3dszkDqMp4fklxBwXRsW10KXzPMTZ+sOPAveyxindmjkW8lGy+QsRlG
PfZ+G6Z6h7mjem0Y+iWlkYcV4PIWL1iwBi8saCbGS5jN2p8M+X+Q7UNKEkROb3N6
KOqkqm57TH2H3eDJAkSnh6/DNFu0Qg==
-----END CERTIFICATE-----

I think the issue was resty-http after all. We were on a really old version (0.0.4), updating to 0.11.0-0 seems to have fixed the issue on our staging server

@gregkare: Ahh, I hadn't thought of the lua-resty-http dependency version. Sorry for the trouble, but thanks so much for debugging this and getting to the bottom of it! I'll try to do some further testing of lua-resty-http to figure out what our minimum version is and bump our rockspec file to ensure we have the appropriate version.

@GUI No problem! We're now running this in production, OCSP stapling is now working with the latest resty-http


[keymgr] Reorganize diversification inputs

Description
One thing that bothers me about the organization of Keymgr RTL diversification constants/secrets is that it does not properly divide the input domain with respect to KMAC calls.
The idea behind diversification (a.k.a. domain separation) is that, when a user makes different KMAC calls for different use cases, each use of KMAC function can be interpreted as if a different (random) function. There are mainly three use cases (if not more) for Keymgr:

Generate HW-backed keys (such as AES, KMAC or OTBN).
Generate SW-backed keys for generic purposes
Compute another keymgr key in order to advance the state

Domain separation should guarantee that it should not be possible to construct the same KMAC message, so that we can argue that a collision of keys from different use cases is pure luck (e.g. as unlikely as for random functions).
Here is a visual description of how Keymgr constructs the message payload for different operations. Capitalized variable names represent the netlist constants that are used for diversification. Notice that the last advance call does not have proper diversification:

I would suggest the following:

Add another diversification constant for the 3rd advance call as the first 256-bit.
Move REVISION_SEED to the second 256-bit block. I also wonder if it makes sense to reuse this value for all advance calls as the second 256-bit block.
sw_binding register value is moving around a lot during different advance calls. It might be better to fix its location as well (which might give SW ability to diversify further).

To recap, at the moment, it is hard to argue that KMAC call from the 3rd advance call is separated from any of the other KMAC calls in the same stage.
cc: @johannheyszl @moidx @jadephilipoom

I see value in adding an owner third stage seed for diversification purposes, but rate the priority for that change as P2-P3. @timothytrippel for visibility on the provisioning side.
Using a gate level constant for diversification in the third stage SGTM as well. I am not sure if this is a P2 or P3. @johannheyszl to flag this for further discussion.
We need to prioritize this against other cryptolib and pentesting work as @ballifatih would have to absorb both RTL and DV changes.

A correction: With the default synthesis parameters, CREATOR_ADV_SEED and OWNER_ADV_SEED from the drawing above are coming from flash, but not OTP.
For clarification, what I need is a way to be able to separate different KMAC calls from each other, but not necessarily secret values. I think the answer from the following post explains what I meant better:
https://crypto.stackexchange.com/questions/66969/what-is-meant-by-domain-separation-in-the-context-of-kdf
The smallest effort here is to keep these two flash secrets as inputs but use additional netlist constants as the first 256-bit chunks of the diversification data. In other words, add further 256-bit prefixes to advance payloads.
Without this change, I think it is hard to justify the correct use of KMAC for different purposes.

Further details and/or arguments are summarized in the following OT doc:
https://docs.google.com/document/d/1YgrDGzkzv7ADkuwWWvStbqzcmrZywWxGYiaxI34FS6I

What about integrating support for #22296 as part? It can provide complementary approach for key gen of FIPS key by swapping key & context when using KMAC.
I'd also prefer to use full 256-bit (vs. 224 bit with version for which I have no good use cases) when using KEYMGR for software generated keys.
As for diversification, it can be just 8-bit being added as part of label in SP800-108 $K_{OUT} = KMAC(K_{IN}, Context, L, Label)$ implicitly, depending on the destination.

What about integrating support for #22296 as part? It can provide complementary approach for key gen of FIPS key by swapping key & context when using KMAC.

I think this issue you are referring to is also important, but unlike this one, the HW changes and DV effort is large for that one. This issue in particular is low effort, because it only requires reorganizing hard coded variables in an array.

I'd also prefer to use full 256-bit (vs. 224 bit with version for which I have no good use cases) when using KEYMGR for software generated keys.

In this diagram, this value corresponds to salt. The size for this is already 256-bit in HW. 224-bit restriction is later imposed at SW level. We can discuss this further on cryptolib API level, if having 224-bit is really that inconvenient.

As for diversification, it can be just 8-bit being added as part of label in SP800-108 KOUT=KMAC(KIN,Context,L,Label) implicitly, depending on the destination.

I agree that diversification constants do not need to be large, and in ideal world, they would be just label input of KDF-KMAC and short for simplicity. However, the interface between Keymgr and KMAC cannot handle this flexibility at this moment. Also even if we use 8-bit diversification, message payloads are rounded up to multiples of 64-bits by 0-padding.
So overall I would say this issue tries to get rid of one of the potential problems with an emphasis on minimum HW modification effort.

As mentioned in #22624, it would also be nice to have another (at least) 32-bit diversification for key_mode. For HW keys, this is useful to distinguish between different OTBN use cases. For SW keys, it allows cryptolib to ensure that different keys do not get mixed up.

Just discussed in the triage meeting, and we agreed to move this to future release

Can we consider the alternative fix #22878 for this issues @vogelpi @andreaskurth? To recap what #22878 does:

For the 1st advance calls, moves REVISION_SEED to the beginning of the message payload.
For the 2nd and 3rd advance calls, reuses REVISION_SEED as the first prefix, such that all advance calls start with the same 256-bit value.
Does not add a new RTL constant (hence no extra gates cost).
The purpose of REVISION_SEED is defined as:
https://github.com/lowRISC/opentitan/blob/7c92d49f77576a13a20fe6a508e47effca6193a2/doc/security/specs/identities_and_root_keys/README.md?plain=1#L158-L159
hence, the purpose is to include another revision-specific secret as part of DICE. Reusing this secret should not be a concern.

For future reference, the relevant standard section can be found in Section 6.5, Point 2 of SP 800-108r1.

Closing this issue as the merged PR resolves it.
For the record, this is what we converged on a as a solution:

The relevant docs are not yet updated, but they are tracked in a dedicated issue https://github.com/lowRISC/opentitan/issues/23323.


WCMS-548 Added redirect model and embedded it in page edition

Don't merge this yet. I'm going to add a scope.


Should be a class variable rather than a constant, direct translation of the BrakingCalculation class in Java

Hi,
I'm sorry you've done this translation work unecessarily! I've decided to retire the Braking exercise - it was just too complicated. I'm replacing it with a new exercise - Leaderboard - which has the same purpose but achieves it with less code and complexity. I'm very open to a Ruby translation of that one instead :-)
Emily

Dear Emily,
No problem at all. These things happen I suppose. I'll happily translate
your LeaderBoard work, and then refactor my own translation as an exercise!
:-)
I attempted the Train Reservation and Tennis refactoring katas. I enjoyed
the former particularly: it was very useful as I develop codes that talk to
JSON APIs in my day job as a Rails developer. I'm using your katas to
improve my design and refactoring skills, just develop good habits. The
Racing Car kata is the one I'd like to work on next.
Yours sincerely,
Hemal
Hemal Varambhia
16 Devonshire Road,
Mill Hill,
London,
NW7 1LL
On 30 May 2015 09:06, "Emily Bache"<EMAIL_ADDRESS>wrote:

Hi,
I'm sorry you've done this translation work unecessarily! I've decided to
retire the Braking exercise - it was just too complicated. I'm replacing it
with a new exercise - Leaderboard - which has the same purpose but achieves
it with less code and complexity. I'm very open to a Ruby translation of
that one instead :-)
Emily
—
Reply to this email directly or view it on GitHub
https://github.com/emilybache/Racing-Car-Katas/pull/6#issuecomment-107007080
.


WES CLI improvements

Fixes directory traversal to find files to load into the workflow_attachment
Adds a flag to let the WES Launcher know if a descriptor is a local entry or not

Coverage increased (+0.06%) to 76.416% when pulling af15a3f46fe6547200e934a0da6419090335cb4f on feature/wes-cli-improvements into abceab0f5b6527d1be82fdced1d62b8aec09aa64 on release/1.6.0.

Coverage increased (+0.06%) to 76.416% when pulling af15a3f46fe6547200e934a0da6419090335cb4f on feature/wes-cli-improvements into abceab0f5b6527d1be82fdced1d62b8aec09aa64 on release/1.6.0.

Coverage increased (+0.06%) to 76.416% when pulling af15a3f46fe6547200e934a0da6419090335cb4f on feature/wes-cli-improvements into abceab0f5b6527d1be82fdced1d62b8aec09aa64 on release/1.6.0.


Add a test suite for Gradient

Gradient can be tested now that ClassDB-based tests are functional.

Thanks!


SecHub Client - Cancel job

Problem
The user should be able to cancel a job from the SecHub CLI.
User scenario:

The user started a job
The user realized it was a mistake (file to big, wrong branch etc.)
The user user has to wait until the job ended

Solution
The user should be able to stop an ongoing scan by providing the job uuid.
sechub -jobUUID 72e00a5a-52c6-470c-b24f-1bad4fe6958b stopScan

This is especially important for webScan or other scans which take several minutes or even hours.

Can be implemented as soon as the SecHub server supports the use case "user cancels job".
Currently only admins can cancel jobs,

Closing this issue for now.
We'll have to wait until the SecHub server supports cancelling.
Once the server feature is implemented then the client will also support this.


fix(migration): release storage locks

Describe your changes
Closes #4344. Hat tip to @erwanor for spotting the omission.
Issue ticket number and link
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

Code change fixes migration behavior, so is very relevant to not breaking consensus.

Testing/review
This change is a bit tricky to test manually, but the rationale in #4344 is sound. I'd like to get it in, so we can rebase #4337 on top of it, and go back to debugging #4340.

Non-blocking, but, wouldn't dropping the Storage be a more RAII-like way to release the lock?

@hdevalence we can't await aborting tasks using RAII, the problem is that releasing resources happens after the handle has been dropped


RVA_020: Provide additional context for Ssccfg

The privileged specification includes a chapter about "Smcdeleg" Counter Delegation Extension, Version 1.0.0 that includes the description of Smcdeleg and Ssccfg.
For clarity / ease of finding the the details, update the RVA_020 requirement to include a reference to Smcdeleg.
Closes: #19

This was intentional. The Platform specification is written to provide the requirements that the privilege levels less than M can expect. We have not placed any mandates on the M-mode ISA in the Server Platform or the Server SoC specification. I notice we have Smcntrpmf which I think should also be removed.

@ved-rivos Thank you for taking a look.
The reason for adding smcdeleg was that there is confusion about ssccfg - folks have complained about not being able to find its description. Even the chapter describing it only includes smcdeleg. I've seen ssccfg being incorrectly referred to in many places as sscfg (one example[0]) which obviously then makes it even harder to find.
I just had a look to confirm the content of smcntrpmf - it seems to be implied if smcdeleg/ssccfg is implemented. So dropping it should be ok. Though I hope this indirect requirement doesn't get missed by any implementation.
For my learning - I was wondering what is the rationale for the platform specification targeting privilege levels less than M. Is there a downside to having M mode extensions also in the list?

For my learning - I was wondering what is the rationale for the platform specification targeting privilege levels less than M. Is there a downside to having M mode extensions also in the list?

The RVA profiles, server SoC specification, and the server platform specification are written to specify requirements as perceived by the S-mode and lower. This is to ensure we can support a single binary OS distribution on compliant platforms. An implementation that claims support Ssccfg should provide that extension as perceived by the S-mode. We are presently not placing mandates on the M-mode ISA - in fact none of these specifications even require the M-mode ISA to be implemented - for instance the machine mode may be an emulator.

The smcdeleg and smcntrpmf should be remove from the list.

I've pushed an updated patch doing this.


refactoring and facebook attachment management

I've done a lot of changes. In details:

I've changed the facebook-chat-api dependency in order to get the latest code with attachment fixes.
Retrieved the friend list from facebook in order to map names with ids
managed fb messages containing  attachments, forwarding them as simple urls
some little refactorings

I hope it will be useful !
Marco

Hi @silemarc ,
Thank you for the PR and for the work 👍


Use .new rather than method call for Component rendering

Use .new() rather than method call for Component rendering
It was raising warning when running tests.
Link to Trello card
N/A
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

Thank you for doing something from my TODO list! 👍


refactor: added a statement for sort operation

Related issue(s)
#667

@kanumalivad Hi! Thanks for contribution! Unfortunately you have still code smell - https://sonarcloud.io/project/issues?id=asyncapi_generator&open=AXw6OsbhiXOsm5cm9b-w&pullRequest=669&resolved=false&types=CODE_SMELL
I suggest you to return sorted array immediately from function without local variables, something like:
return Object.keys(configParams).map(param => [levenshtein(wrongParam, param), param]).sort(sortInt)[0][1];

@magicmatatjahu Thank you so much for suggestion.

@kanumalivad Thanks for contribution!


Revert adding "leaks" based lit run key

This seems to cause some trouble on some CI configurations and we have not enabled it for good yet.

@swift-ci please smoke test

How to smoke test @swift-ci ?


partial revert

self.http does not exist. Reverting to self.headers['user-agent'], which works.

This was to go with a change in discord.py.  Update your lib.


Fixed IAM security token refresh issues and added precacheAuth method.

Pushed to rebase off the current main branch.


Update Kafka docs for 0.12.0

After #4815 the Kafka indexing service changed how it generates segments, in a way that invalidates the "On the Subject of Segments" section of kafka-indexing.md. This is great since the new way is better! But, the docs need to be rewritten.
/cc @pjain1 @dclim

I can modify the docs


Custom Cloudbase Configuration Options

Hello,
I wonder if it's possible to pass configuration options to the Cloudbase-Init installer during New-WindowsOnlineImage? I want to configure several options in the cloudbase-init.conffile.

Hello,
This is a feature already on the 'To do' list but is not yet implemented.
However, you can easily define your custom scripts that change the cloudbase-init config options using the hook RunAfterCloudbaseInitInstall.ps1 . More details here or in the config.ini generated file: https://github.com/cloudbase/windows-openstack-imaging-tools/blob/experimental/Config.psm1#L68
Thank you,
Adrian Vladu

Is also very easy to modify the config files (which are ini file) using a crudini like powershell approach. As the custom_scripts will be copied over to the running instance to C:\UnattendedResources\CustomScripts you can easily import the module https://github.com/cloudbase/windows-openstack-imaging-tools/blob/experimental/UnattendResources/ini.psm1 using a custom script RunAfterCloudbaseInitInstall.ps1 which looks like this:
#ps1
Import-Module ../ini.psm1
Set-IniFileValue -Path ""-Section "DEFAULT" -Key "verbose" -Value "true"

This issue is solved by PR #288


If you do not allow access to the camera, it will be in English

Bug Report
I use this plugin.
I want to take picture.so,
When I select Don't allow in modal permission,and this message
「"Access to the camera has been prohibited; please enable it in the Settings app to continue.」.
This message is English, but I want to change Japanese.
Plese teach me how to chage Language.
Information

this plugin source
cordova-plugin-camera/src/ios/CDVCamera.m
// Denied; show an alert
dispatch_async(dispatch_get_main_queue(), ^{
UIAlertController *alertController = [UIAlertController alertControllerWithTitle:[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleDisplayName"] message:NSLocalizedString(@"Access to the camera has been prohibited; please enable it in the Settings app to continue.", nil) preferredStyle:UIAlertControllerStyleAlert];
[alertController addAction:[UIAlertAction actionWithTitle:NSLocalizedString(@"OK", nil) style:UIAlertActionStyleDefault handler:^(UIAlertAction * _Nonnull action) {
[weakSelf sendNoPermissionResult:command.callbackId];
}]];

Dupe of #392

I want to try this method
please teach me　in detail

https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPInternational/LocalizingYourApp/LocalizingYourApp.html

@timbru31 thanks.
I try this Method,but don't work.
After,My project build.
Look at the attached capture.
Not included in directory ''Localizable.strings''.
Why?
I'm using .xcworkspace file.

Hi,
I'm currently facing the same error.
When I create the Localization files for the pods and importing the .strings file, the next time, when I run pods install they are removed again.
What's the solution for that?
Do I have to import them somewhere that the pod consider them?
Help would be nice.


Change Schema before executing Queries.

In Native JDBC we can use setCatalog() to change schema. Is there any alternative here in Sql2o to execute queries over different schemas.

You can set the schema directly on the underlying jdbc connection. Example:
try (Connectio con = sql2o.open()) {
    con.getJdbcConnection.setCatalog("theCalalog");

    con.createQury(sql).addParameter("param", var).execute...();
}

Thanks. That helped a lot.


Avoid error when you execute pod install or pod update

Avoid error when you execute pod install or pod update because treat download git from other link...

Thank you very much for contributing!

You Welcome!