Properly bump the LLVM version and fix a dependency problem [phab:D2091]

Created by zarko at 2017-12-09 01:03:08:
Also don't pass builtin headers as explicit includes, because that
doesn't make sense.

fromberger accepted this revision at 2017-12-09 01:04:11

zarko closed via commit 282b4fca8d880bc40a497f8810a937d342cdd57e at 2017-12-09 01:06:14

shahms commented inline (context lost during migration) at 2017-12-12 00:11:15:
Did you test this on macOS? Pretty sure the removal of this will break the extractor tests there.

zarko wrote at 2017-12-12 00:37:23:
I did not, but it's not correct for that line to be there (and in fact it obscured the fact that we were generating a missing set of builtins after the most recent Clang bump). I'm checking the tests now. If they fail, fixing them will be a separate issue.

shahms wrote at 2018-02-07 22:17:26:

! In (earlier comment), zarko wrote:
I did not, but it's not correct for that line to be there (and in fact it obscured the fact that we were generating a missing set of builtins after the most recent Clang bump). I'm checking the tests now. If they fail, fixing them will be a separate issue.

Unless we want to check in a copy of a C++ standard library somewhere, I think the original change was correct.  Without this, if the compiled extractor/indexer don't have the same search path as the platform toolchain the tests which rely on finding a system header will fail. This is mostly an issue on macOS, but still.
$ bazel-bin/kythe/cxx/extractor/cxx_extractor -E -xc++ - -v
...
#include "..." search starts here:
#include <...> search starts here:
/usr/local/include
/kythe_builtins/include
/System/Library/Frameworks (framework directory)
/Library/Frameworks (framework directory)
End of search list.
clang -E -xc++ - -v
#include "..." search starts here:
#include <...> search starts here:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/8.1.0/include
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks (framework directory)
End of search list.
The "right" option is likely to compile llvm/clang such that the default search path is the same as the platform search path, but that seems like more messing with CMake than is good for one's health.


fix(shared): Re-use common type for infinite Pagination params

Description

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/backend
[ ] @clerk/chrome-extension
[ ] @clerk/clerk-js
[ ] @clerk/clerk-expo
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] @clerk/localizations
[ ] @clerk/nextjs
[ ] @clerk/clerk-react
[ ] @clerk/remix
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/themes
[ ] @clerk/types
[ ] build/tooling/chore

@panteliselef could you add a description?


Add Locate User Location

https://docs.mapbox.com/mapbox-gl-js/example/locate-user/

Another thought I've had would be to save the user's last location in localstorage and center on that during page load.
Carries most of the benefit of geolocation for the user but without the prompt from the browser on each load.

Latest thoughts on user location:
User can center the map on their location after pressing a ‘center on location’ button.
After user requests location, ask the browser for location permission
if permission granted, center location. Store permission for later use.
if no permission granted, do not center location. user can press location button again to retry
Until the user pans on the map, the user location remains centered on the map (following)
While location is centered and not panned, location centering button disappears.
After user pans, centering button reappears.
Set map center at a coarse resolution in order to crudely smooth location jitter. (?)
Stretch idea:
As user enters location enters new hexes, automatically select that hex and show its uplink lines and details.
Is user ‘minimizes’ the info pane, remember that state and only show uplink lines on the map.
If info pane is open, adjust map center to be the viewable map area
on mobile, (100vh - infopaneHeight)/2
on desktop, (100vw - infopaneWidth)/2
Alternate stretch idea:
For the centered hex, highlight it in some way. Color, border, etc. Giving the user a clear ‘center’ for their location.
OR
Draw an icon at the user location.

I'm gradually working through some UI for this which should clarify implementation.

Closed via #72


Support for Hyper

Would be nice if I could open projects with Hyper.
https://hyper.is

Any news on this?

I'd love to have it as well !

Last I checked Hyper did not support applescript https://github.com/fitztrev/shuttle/issues/205

if hyper supports applescript I can look into supporting it.


Add oe-selftest for aktualizr ptest run on qemu

Still has some failures at the moment, also the full output is often cropped for some unknown reason (the summary of which tests are passing and which aren't still appears in full)

Annoyingly, a test using lshw fails because /usr/sbin is not put into $PATH when launching ptest-runner directly through ssh.

Softlink it manually in the oe-selftest code before calling ptest?

Looks fine, but in my case I see a few more errors:
The following tests FAILED:
[ERROR_MESSAGE]
Problem opening file: /usr/lib/aktualizr/ptest/build/Testing/Temporary/LastTestsFailed.log

Cannot create log file: LastTestsFailed.log
[HANDLER_OUTPUT]
	  4 - test_utils (Failed)

	 18 - test_uptane (Failed)
	 26 - test_fetcher (Failed)
[ERROR_MESSAGE]
Errors while running CTest

The first you already know:
[ RUN      ] Utils.getHardwareInfo
sh: lshw: command not found
[2019-03-25 09:32:09.614242] [0x000000000563df00] [warning] Could not execute lshw (is it installed?).
/usr/src/debug/aktualizr/1.0+gitAUTOINC+2e3ccbbdd4-7/git/src/libaktualizr/utilities/utils_test.cc:52: Failure
Expected: (hwinfo) != (Json::Value()), actual: {} vs {}
/usr/src/debug/aktualizr/1.0+gitAUTOINC+2e3ccbbdd4-7/git/src/libaktualizr/utilities/utils_test.cc:53: Failure
Value of: hwinfo.isArray()
  Actual: true
Expected: false
[  FAILED  ] Utils.getHardwareInfo (602 ms)

The second:
/usr/src/debug/aktualizr/1.0+gitAUTOINC+2e3ccbbdd4-7/git/src/libaktualizr/uptane/uptane_test.cc:755: Failure
Expected equality of these values:
  http->system_info_count
    Which is: 0
  1
[  FAILED  ] Uptane.ProvisionOnServer (1844 ms)

fetcher_test.cc appears to be breaking due to a valgrind complaint:
==420== 184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in loss record 1,015 of 1,050
==420==    at 0x4835753: malloc (vg_replace_malloc.c:299)
==420==    by 0x516E590: g_malloc (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x51861C2: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x5156C5D: g_hash_table_new_full (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x5142CB0: g_get_language_names_with_category (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x515E49B: ??? (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x51602FC: g_key_file_new (in /usr/lib/libglib-2.0.so.0.5800.3)
==420==    by 0x4E81369: ostree_repo_reload_config (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x4E8243B: ??? (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x4E826E1: ??? (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x4E82761: ostree_repo_open_at (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x4EAC874: ??? (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x4EAE8B6: ostree_sysroot_load_if_changed (in /usr/lib/libostree-1.so.1.0.0)
==420==    by 0x1DA78C: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x1DD2CE: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x1B0CA2: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x13EB58: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x54B496E: ??? (in /usr/lib/libstdc++.so.6.0.25)
==420==    by 0x4AC4F04: start_thread (pthread_create.c:486)
==420==    by 0x568DBAE: clone (clone.S:95)
==420==
==420== 400 bytes in 1 blocks are possibly lost in loss record 1,035 of 1,050
==420==    at 0x48379A2: calloc (vg_replace_malloc.c:752)
==420==    by 0x40113E1: allocate_dtv (dl-tls.c:286)
==420==    by 0x4011D2D: _dl_allocate_tls (dl-tls.c:532)
==420==    by 0x4AC5AE6: allocate_stack (allocatestack.c:621)
==420==    by 0x4AC5AE6: pthread_create@@GLIBC_2.2.5 (pthread_create.c:669)
==420==    by 0x54B4BF4: std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (in /usr/lib/libstdc++.so.6.0.25)
==420==    by 0x13FBC3: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x141C6C: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x21A8E9: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x211779: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x2118C7: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x2119A4: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x211E9B: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x21ADF9: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x211FCB: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x13CBE7: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==420==    by 0x55BDB6A: (below main) (libc-start.c:308)

I think your second problem comes from not being able to run lshw as well. I've pushed a fix.
I now have:
[ RUN      ] AktualizrCertProviderTest.DeviceCertParams
created: /tmp/aktualizr-0fb7-9361-9758-c87b/0a95-8c81-dir
/usr/src/debug/aktualizr/1.0+gitAUTOINC+56a0c04aff-7/git/src/cert_provider/cert_provider_test.cc:256: Failure
Expected: (openssl.lastStdOut().find(expected_key_str)) != (std::string::npos), actual:<PHONE_NUMBER>3709551615 vs<PHONE_NUMBER>3709551615
[  FAILED  ] AktualizrCertProviderTest.DeviceCertParams (74 ms)

Oh and the problem with fetcher is more than a memory leak I think:
34: [ RUN      ] Fetcher.PauseBinary
34: created: /tmp/aktualizr-3646-0ac6-3181-0dcc/b7bb-8ff2-dir
34: Bootstraping DB to version 19
34: No file 'large_file' with matched hash in the database
34: progress callback: 1
...
34: terminate called after throwing an instance of 'std::future_error'
34:   what():  std::future_error: Promise already satisfied
34: ==286==
34: ==286== Process terminating with default action of signal 6 (SIGABRT)
34: ==286==    at 0x55CC6FA: raise (raise.c:51)
34: ==286==    by 0x55B8523: abort (abort.c:79)
34: ==286==    by 0x5481972: ??? (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x5487895: ??? (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x54878D0: std::terminate() (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x5487B02: __cxa_throw (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x548391C: ??? (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x14CDC5: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/package_manager/t_fetcher)
34: ==286==    by 0x54B096E: ??? (in /usr/lib/libstdc++.so.6.0.25)
34: ==286==    by 0x4AC3F04: start_thread (pthread_create.c:486)
34: ==286==    by 0x5689BAE: clone (clone.S:95)

Fixes in https://github.com/advancedtelematic/aktualizr/pull/1173 and https://github.com/advancedtelematic/aktualizr/pull/1174.
The valgrind leak however remains, I'd suggest that we'd still merge this soon if possible.

The valgrind leak however remains, I'd suggest that we'd still merge this soon if possible.

I don't want to merge if it still breaks, but I'd also like to get it in soon. Can we skip that test for now or do something quick and dirty until we fix it for real?

I thought about merging it now since it doesn't run with the other oe-selftests, as it is in its own .py file.
But ok I can take a last quick look.
Quick solution would be to run with NO_VALGRIND=1, that I've added in the aktualizr test suite but I don't like it since it would apply to the complete suite.

Ok I think the leak was introduced here: https://github.com/ostreedev/ostree/commit/21ebc7d21edd00c3fe0ce80ea68ba3f8f5e41ae3, which adds a new char* into the OstreeRepo object but didn't add it to the cleanup function.

Oh my bad that's a completely different leak, only in master! It looks like the one mentioned earlier has been fixed there actually.

At this point everything looks fine except for fetcher_test:
==741== 184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in loss record 1,017 of 1,054
==741==    at 0x4835753: malloc (vg_replace_malloc.c:299)
==741==    by 0x516E5C0: g_malloc (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x51865C2: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x5156C8D: g_hash_table_new_full (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x5142CE0: g_get_language_names_with_category (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x515E4CB: ??? (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x516032C: g_key_file_new (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x4E81369: ostree_repo_reload_config (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4E8243B: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4E826E1: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4E82761: ostree_repo_open_at (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4EAC874: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4EAE8B6: ostree_sysroot_load_if_changed (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x1DA78C: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x1DD2CE: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x1B0CA2: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x13EB58: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x54B196E: ??? (in /usr/lib/libstdc++.so.6.0.25)
==741==    by 0x4AC4F04: start_thread (pthread_create.c:486)
==741==    by 0x568ABAE: clone (clone.S:95)
==741==
==741== 400 bytes in 1 blocks are possibly lost in loss record 1,037 of 1,054
==741==    at 0x48379A2: calloc (vg_replace_malloc.c:752)
==741==    by 0x40113E1: allocate_dtv (dl-tls.c:286)
==741==    by 0x4011D2D: _dl_allocate_tls (dl-tls.c:532)
==741==    by 0x4AC5AE6: allocate_stack (allocatestack.c:621)
==741==    by 0x4AC5AE6: pthread_create@@GLIBC_2.2.5 (pthread_create.c:669)
==741==    by 0x54B1BF4: std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)()) (in /usr/lib/libstdc++.so.6.0.25)
==741==    by 0x13FBC3: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x141C6C: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x21A8E9: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x211779: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x2118C7: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x2119A4: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x211E9B: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x21ADF9: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x211FCB: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x13CBE7: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x55BAB6A: (below main) (libc-start.c:308)
==741==
==741== 400 bytes in 1 blocks are possibly lost in loss record 1,038 of 1,054
==741==    at 0x48379A2: calloc (vg_replace_malloc.c:752)
==741==    by 0x40113E1: allocate_dtv (dl-tls.c:286)
==741==    by 0x4011D2D: _dl_allocate_tls (dl-tls.c:532)
==741==    by 0x4AC5AE6: allocate_stack (allocatestack.c:621)
==741==    by 0x4AC5AE6: pthread_create@@GLIBC_2.2.5 (pthread_create.c:669)
==741==    by 0x51B2A2F: ??? (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x519148E: ??? (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x5191537: g_thread_new (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x5169CB3: ??? (in /usr/lib/libglib-2.0.so.0.5800.3)
==741==    by 0x4FA65F6: ??? (in /usr/lib/libgio-2.0.so.0.5800.3)
==741==    by 0x4FA69B4: g_task_get_type (in /usr/lib/libgio-2.0.so.0.5800.3)
==741==    by 0x4FA6B78: g_task_new (in /usr/lib/libgio-2.0.so.0.5800.3)
==741==    by 0x4ECEE73: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4ECFF5F: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4ECD0AE: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4E94A64: ??? (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x4E9D0D5: ostree_repo_pull_with_options (in /usr/lib/libostree-1.so.1.0.0)
==741==    by 0x1DDBE4: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x1B0CA2: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x13EB58: ??? (in /usr/lib/aktualizr/ptest/build/src/libaktualizr/uptane/t_fetcher)
==741==    by 0x54B196E: ??? (in /usr/lib/libstdc++.so.6.0.25)
==741==    by 0x4AC4F04: start_thread (pthread_create.c:486)
==741==    by 0x568ABAE: clone (clone.S:95)

Is that what you see as well?

Yes it's a very frustrating one, as I get it on yocto and my Debian system but not on the docker CI, even when trying the same ostree versions.
Will try a little bit more.

On ostree master (89c00e7eb72ddc5aaee3469f281fb5560ff7bd5d):
32: ==3671==
32: ==3671== HEAP SUMMARY:
32: ==3671==     in use at exit: 180,461 bytes in 2,401 blocks
32: ==3671==   total heap usage: 47,558 allocs, 45,157 frees, 14,887,354 bytes allocated
32: ==3671==
32: ==3671== 184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in loss record 1,863 of 1,951
32: ==3671==    at 0x483577F: malloc (vg_replace_malloc.c:299)
32: ==3671==    by 0x5204900: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x521C882: g_slice_alloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x51ECD3D: g_hash_table_new_full (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x51D8CF0: g_get_language_names_with_category (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x51F458B: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x51F622C: g_key_file_new (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.5800.3)
32: ==3671==    by 0x4EF6A1E: reload_core_config (ostree-repo.c:2835)
32: ==3671==    by 0x4EF7BD9: ostree_repo_reload_config (ostree-repo.c:3158)
32: ==3671==    by 0x4EF8188: ostree_repo_open (ostree-repo.c:3280)
32: ==3671==    by 0x4EF3424: repo_open_at_take_fd (ostree-repo.c:1243)
32: ==3671==    by 0x4EF34B7: ostree_repo_open_at (ostree-repo.c:1269)
32: ==3671==    by 0x4F30E32: ensure_repo (ostree-sysroot.c:782)
32: ==3671==    by 0x4F312F1: ostree_sysroot_load_if_changed (ostree-sysroot.c:871)
32: ==3671==    by 0x4F30DC4: ostree_sysroot_load (ostree-sysroot.c:771)
32: ==3671==    by 0x186D6C: OstreeManager::LoadSysroot(boost::filesystem::path const&) (ostreemanager.cc:338)
32: ==3671==    by 0x18B8CB: OstreeManager::pull(boost::filesystem::path const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, KeyManager const&, Uptane::Target const&, api::FlowControlToken const*, std::function<void (Uptane::Target const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>) (ostreemanager.cc:75)
32: ==3671==    by 0x18CCEE: OstreeManager::fetchTarget(Uptane::Target const&, Uptane::Fetcher&, KeyManager const&, std::function<void (Uptane::Target const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, unsigned int)>, api::FlowControlToken const*) (ostreemanager.cc:239)
32: ==3671==    by 0x130473: operator() (fetcher_test.cc:83)
32: ==3671==    by 0x130473: __invoke_impl<void, test_pause(const Uptane::Target&, PackageManager)::<lambda()> > (invoke.h:60)
32: ==3671==    by 0x130473: __invoke<test_pause(const Uptane::Target&, PackageManager)::<lambda()> > (invoke.h:95)
32: ==3671==    by 0x130473: _M_invoke<0> (thread:244)
32: ==3671==    by 0x130473: operator() (thread:253)
32: ==3671==    by 0x130473: std::thread::_State_impl<std::thread::_Invoker<std::tuple<test_pause(Uptane::Target const&, PackageManager)::{lambda()#1}> > >::_M_run() (thread:196)
32: ==3671==    by 0x5572B2E: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
32: ==3671==    by 0x4ADEFA2: start_thread (pthread_create.c:486)
32: ==3671==    by 0x574E82E: clone (clone.S:95)

It could come from some version of glib...

Ok, we're not alone https://salsa.debian.org/debian/flatpak/commit/5880a6923f26caf8cadf840b54322047790cf373

This should help: https://github.com/advancedtelematic/aktualizr/pull/1179

This should help: advancedtelematic/aktualizr#1179

Indeed. It passes when I build with that branch. If only that branch succeeded on Travis...

Travis finally passed :)

Travis finally passed :)

Great! If you bump aktualizr's version here, I'll approve and we can merge this. Finally!


add: Ahsankhalid618

Description
I have added my profile to devFind. kindly add me
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@Ahsankhalid618 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


ITI-119 quality of match

2:<IP_ADDRESS>.2.4 Quality of Match

The Patient Demographics Supplier shall convey the quality of each match based on strength of the particular result to the supplied Patient Resource. The mechanism for determining the confidence of match is considered a product specific feature and is not specified in this transaction. When doing so, it shall represent the confidence of a particular match within the bundle as a score attribute. See FHIR Relevance section http://hl7.org/fhir/R4/search.html#score

All the examples in 2:<IP_ADDRESS>.3 Expected Actions refer to the match-grade extension, but I don't see it referred to in the response expected actions.  I see it in the profile for the response, so I think there just needs to be a link to that somewhere in the response expected actions to say it has to conform to that profile

Make sure we explicitly state the response shall conform to the response message.

Updated the response message semantics to explicitly require that the message conform to the PDQm Match Output Bundle Profile


Build takes forever performing image-metadata check on external images

OT version: 2.2.4
Transformation type: extension of the HTML5 transformation
Platforms: Mac OS X (local) and UNIX (Jenkins)
Part of our docset references some 1200 images directly by URL rather than maintaining duplicate copies that are likely to become out of date. When I build locally, the image-metadata check generates many errors like the following:

Failed to read image https://www.webassign.net/images/Ihat.gif metadata: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

This happens even though I can access the images in question using the same URL in my browser.
When I build on our Jenkins server, the build keeps running (stuck at this step) for over 12 hours until we abort it.
I can work around the problem (tested locally only) in either of two ways:

set the noImagelist property to skip the image-metadata check altogether
change all the "https" protocols to "http" in the DITA source

These workarounds should not be needed. The image-metadata step should handle this situation more gracefully. Some ideas that occur to me:

omit checking external images altogether
omit checking external images after a certain number of such checks have failed or timed out
omit checking external images based on a build parameter
check external images using http if https fails (and notify in the log)
always check external images using http (and notify in the log if the DITA source uses https)

Note: Changing the DITA source to use "http" did not fix the build problem on the Jenkins server.


Localization prototype

So the steps to adding a new string are:

Add it to Resources.resx
use it by name as a key passed to the translate service

Can we have a build step that generates typing information for TS?

Do we need typing information for intellisense?
Anyway we can't use intellisense in html templates where most of strings
steps to adding new string:

Add it to Resources.resx in AzureFunction.
Rebuild AzureFunction project
Use it by name as a key passed to the translate service in AzureFunction.Client.

Intellisense in the html is really just a matter of tooling for angular2. I thought it was on their roadmap to support validation of templates.
It'll be nice if there is a class that's auto-generated that encapsulate all these constants

I added typing auto-generation for resources on post-build. I think PR is good to merge in dev. Any objections?


Call assemble after setStateVariableValues to satisfy constraints

Address issue #617

Looking for feedback on:

If states file should contain constrained coordinates (so other code using this e.g. in tools doesn't ned to assemble)
If we call assemble only in cases where the model contains constraints
If this interacts with the fix to issue #540

@aymanhab  are these changes in latest sourceforge GUI download?

AFAICT #617 was not fixed in OpenSim 85d9741-2018-03-22. I still see the patella in space.

No, they're just on a branch PR, if they look ok to you I can merge them.

Local build with the fix shows patella in right place as expected.
Retested model and motion from 540 and they were still displaying correctly.
Waiting for review or suggested optimizations if any

I believe the fix will work and will not break #540.

@aymanhab yes, if you just verified, then go ahead and merge.

Thanks @aseth1 we should have the build from ci shortly, or you can pull the GUI master


feat: add v2 delete tweet

Add method to delete tweet based on API doc at Delete tweet
PS: I'll like to add a test case for this after Post tweet   is merged, if a test is required

Thank you :)


Problem with java method invocation.

Hello!
Sorry for bothering you again, but I think this is the last issue I'm disturbing you =)))
I'm unable to invoke any Java method from JavaScript, using your isomorphic application.
In general it must be like this:
var MyJavaClass = Java.type('my.package.MyJavaClass');
var greetingResult = MyJavaClass.sayHello('John Doe');
print(greetingResult);

But when I'm implementing something like this, I'm getting an error:
Uncaught ReferenceError: Java is not defined     at Object.<anonymous> (bundle.js:10401)     at __webpack_require__ (bundle.js:20)     at Object.<anonymous> (bundle.js:10596)     at Object.module.exports.bPageLine (bundle.js:10616)     at __webpack_require__ (bundle.js:20)     at module.exports (bundle.js:66)     at bundle.js:69
What should I do? =((
p.s.
I mentioned one interesting thing. If you purposely provide a wrong java class name, like this:
var MyJavaClass = Java.type('my.package.MyJava**Calss**');
compiler will throw an error like: java error: Class my.package.MyJavaCalss' not found!
Many thanks you in advance!!!

UPD:
Looks like I found one possible solution =)
I'll try to implement it, and if it works, I'll close the issue soon.
Sorry for disturbance =)))

No. Still doesn't work =(
Please help if it's possible!
Thank you!


Problems with talents

When you launch Foundry VTT V9, and opening the tree talents of a specialization, the talents in it didn't display the type of it. It displayed (activation) and not Passive, incidental, action, manouver, etc... I need to change the type of a talent to display his real type.
Can you fix it, pls ?
A huge thanks by advance :)

I'm seeing this as well. If you manually drag a talent from the Compendium into a character sheet, it shows the right type of action. But if you attain it by buying it in a specialization's talent tree, it always lists it as a Passive talent.

I don't see this happening in the latest version of the system. Please update Foundry and the system. If you still see the issue, feel free to refile the issue and I'll take another look.


Deployment with Docket doesn't work

This lib uses sounddevice and it wouldn't work on the cloud FYI

Yeah, this was a conscious choice - I wanted maximum flexibility locally, so I figured it wouldn't work in docker/etc.

Just wanted to correct this comment. Deployment with Docker does work (I've been running it in docker for the past couple of months with great results!)
Generating audio without playback features works fine. It's only when playback on device is used that this issue appears.

Interesting - do you have any more details on how it doesn't work when trying to select a playback device? Maybe an error log?
Also, try doing sounddevice.query_devices(). It should give you a list of every device, with corresponding IDs.


Serif font being used tab hover

atom -v
1.0.12-dev-87b412c

This should be fixed if https://github.com/atom/atom/pull/8817 gets merged.

This should be fixed on master already since those changes were reverted. :sparkles:


Invalid arguments (lyd_find_path()) in  operation

$ yanglint --version
yanglint SO 1.9.22
$ sysrepoctl --version
sysrepoctl - sysrepo YANG schema manipulation tool, compiled with libsysrepo v1.4.96 (SO v5.6.12)
$ netopeer2-server -V
netopeer2-server 1.1.49
Hi Michal,
We have an issue with get requests .
Say, we have openconfig-interfaces.yang model installed in sysrepo, however it applies to any model.
At this time our back-end application have no sysrepo subscriptions for openconfig-interfaces.yang.
No configuration change subscription, no state data subscription, no rpc subscription.
There are no objects (interfaces) configured in openconfig-interfaces.yang model - neither startup nor running.
Now, doing get-config we get a reasonable empty data set:
> get-config --source running --filter-xpath=/openconfig-interfaces:*
DATA

>

However get returns an error:
> get --filter-xpath=/openconfig-interfaces:*
ERROR
        type:     application
        tag:      operation-failed
        severity: error
        message:  libyang error

>

The log messages are not really helpful, even with max log level for netopeer2-server:
Jan 13 19:46:40.712252 A8-C7 err netopeer2-server[709]: Invalid arguments (lyd_find_path()).
Jan 13 19:46:40.712749 A8-C7 err netopeer2-server[709]: Failed to send an RPC (User callback failed).

Could you please clarify if this is expected behavior or is it a bug?
I agree that such use case might look strange, but we have same get error also in regular use cases, when subscriptions from applications are there. I just cannot yet provide a detailed scenario.
BRGDS,
Ilja.

Hi Michal,
Sorry to disturb.
If possible, could you please comment on this issue?
Thanks in advance,
Ilja.

Hi Michal,
Sorry to disturb.
If possible, could you please comment on this issue?
Thanks in advance,
Ilja.

Sorry, too much work and issues. Should be fixed now.

Sorry, too much work and issues. Should be fixed now.

Thanks a lot!

Thanks a lot!


Can't run android build command!

when run
> npm run cordova-android

i get this error
<EMAIL_ADDRESS>replace-relative-paths D:\nuxt-cordova-app
> replace '/nuxtfiles/' 'nuxtfiles/' dist --recursive && replace '/assets/' 'nuxtfiles/' dist --recursive && replace '(href|src|"href"|"src")="/' '$1="../' dist --recursive && replace '(h
ref|src|"href"|"src"):"/' '$1:"../' dist --recursive

'src' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 255
npm ERR<EMAIL_ADDRESS>replace-relative-paths: `replace '/nuxtfiles/' 'nuxtfiles/' dist --recursive && replace '/assets/' 'nuxtfiles/' dist --recursive && replace '(href|src|"hre
f"|"src")="/' '$1="../' dist --recursive && replace '(href|src|"href"|"src"):"/' '$1:"../' dist --recursive`
npm ERR! Exit status 255
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>replace-relative-paths script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! code ELIFECYCLE
npm ERR! errno 255
npm ERR<EMAIL_ADDRESS>cordova-android: `npm run build-spa && npm run replace-relative-paths && npm run copy-cordova && npm run run-android;`
npm ERR! Exit status 255
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>cordova-android script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Are you on Mac OX or Windows?

@sts-ryan-holton
I'm on windows

This is likely a Windows problem. After some initial searching, take a look at the replace package, it sure has some other issues on Windows. I've used my own project here on Mac OS several times. Beyond this, please ensure to read the README file as it states that Xcode is required and that's what this project is built up with, both:

iOS
Android

As you'd want to release your app in several places.


Fix doc build

Fix doc builds found in https://github.com/gtk-rs/gtk/pull/622
cc @GuillaumeGomez , @sdroege

Great, thanks!

Seems comments this need be moved to lgpl-docs.
Any comment about text or format?

Not really. Should I?

Strange: docs generated, but no docs for IntoRawFd or no link from  new_from_fd for me (windows).
Also link for windows specific IntoRawSocket wrong (maybe because I build under nightly).
Finally no This is supported on Windows only. on new_from_socket like on https://doc.rust-lang.org/std/os/windows/io/trait.IntoRawSocket.html :sob:
So doc comments only stays in source file.

 :'(

Anyway CI passed

Thanks!


Depth of field blur combined with transparent materials

Godot version:
3.1
OS/device including version:
Windows 10, Intel CPU, RTX 2070 GPU
Issue description:
Transparent materials are being blurred as if affected by the DOF effect. They are within the range where they should take no blur from the DOF effect.
Steps to reproduce:
Create a material with transparency
Enable depth of field far blur
Note blurred material when not in blur range

Minimal reproduction project:

Object with transparent material
Environment with DOF enabled
DofFail.zip

A hacky way to resolve this is setting SpatialMaterial->Paramters->DrawDepth->OpaquePrePass, I'm trying to solve this problem.


OSV.dev downstream users have a clearly defined user journey to make corrections to OSV records served by OSV.dev with minimal overhead by all parties

Problem statement
OSV.dev users often file issues in against OSV.dev about records that OSV.dev is merely redistributing, and is not the originator of (what I call the "Don't shoot the messenger problem") and this is discussed in https://google.github.io/osv.dev/faq/#ive-found-something-wrong-with-the-data
The user experience of an OSV.dev user should be such that they are nudged as much as possible to the authoritative source (i.e. the home database) of a record so that they can make a correction or provide feedback where it can be most efficiently handled.
It's neither a good user experience nor a good use of limited resources for OSV.dev team members to act as an intermediary.
Desired outcome
Make the UX around OSV.dev record correction as optimal as possible.

The approach taken with #2821 currently falls down for the following existing OSV.dev sources, which lack a readily determinable human_link value:
[ ] Android
[ ] Bitnami
[ ] Chainguard
[ ] Haskell
[ ] Malicious Packages
[ ] OSS Fuzz
[ ] Python Software Foundation
[ ] PyPI
[ ] R
A large number of these are GitHub repositories, so I'm currently considering additional treatment of such cases to nudge the user towards making a pull request against the source data (but this assumes the user knows what needs to be fixed as opposed to just reporting feedback, and this may be an unreasonable assumption)

Current status:

It would be great to direct users to the original source for any records that OSV doesn't maintain. This will help prevent unnecessary issues in the OSV.dev repository and make maintenance easier. Thanks to Andrew for the UX change!

nudge the user towards making a pull request against the source data

Malicious Packages
OSS Fuzz
PyPA
R

all expressly invite pull requests, but deep linking to the specific record's file edit workflow in GitHub is complicated by the repo structures including additional things in the path, e.g.

Malicious Packages

https://github.com/ossf/malicious-packages/edit/main/osv/malicious/crates-io/littest/MAL-2023-8429.json

OSS Fuzz

https://github.com/google/oss-fuzz-vulns/edit/main/vulns/apache-commons-configuration/OSV-2022-871.yaml

PyPA

https://github.com/pypa/advisory-database/edit/main/vulns/aim/PYSEC-2021-839.yaml

R

https://github.com/RConsortium/r-advisory-database/edit/main/vulns/haven/RSEC-2023-5.yaml


Feat: return a PotaTween object from Initialize

Improve the usability of PotaTweenPreset.

Now the Initialize method returns the PotaTween component created

ex:
PotaTween tween = preset.Initialize(gameObject, 0);
tween.Play()

This PR is conflicting with master. Probably you need to git pull origin master to your branch

This PR is conflicting with master. Probably you need to git pull origin master to your branch

Yeah, no problem, @GabrielCapeletti . I'll tackle that tonight.
Thanks for the approve. Soon I'll also document the usage of the preset.


Fix minor typo in README.md

The word "bottom" is used when it seems "top" is intended to push "onto" a stack.

Thanks!


Create finding a perfect number

To find that a given number is a perfect number or not

Thanks for opening this pull request! Please be sure that you have checked out our contributing guidelines.

you're welcome, yeah I have checked out.

Please star this repository to show your support, in the meantime I am reviewing your code.

Please star this repository to show your support, in the meantime I am reviewing your code.

Done ,Okay you check

Congrats on merging your first pull request!

Thankyou


Inconsistent behavior when switching languages in Alfred & Spotlight

On macOS Sierra when you use Kawa, you can't seem to switch input sources when Spotlight or the launcher called Alfred are invoked. It will ignore the change until you leave the launcher and come back.
I contacted the Alfred folks about this and they thought that Alfred and Spotlight's standard mode of operation being a floating window was something Kawa didn't seem to be dealing with properly, but Alfred has a Compatibility Mode which changes Alfred from a floating window or non-activating panel to behaving like an app, taking focus when you show it.
What's weird is if I switch between the two input sources I have repeatedly, eventually it works. In both Alfred and Spotlight, although it took about 6 times before it worked in Spotlight.
I don't think this is an issue on OS X El Capitan, I couldn't reproduce on there this morning.
My settings in Kawa are:
U.S. : ⌥Space
Hiragana (Japanese) : ⌘Space

Duplicated with #10. The input source API provided by Apple has a bug in CJK layouts.

I'll try a workaround in #11.


Upgrade cargo_toml to v0.10.3

The current version of cargo_toml (0.9.2) has been yanked from crates.io and 0.10.3 was the next version I could find.

I have tested the changes in a private test copy of xh and can confirm that it works. You can also see the workflow logs here

cargo_toml 0.10.3 has now been yanked from crates.io. Fortunately, --locked can be used to ensure reproducible builds.


Call stored procedure from diesel?

Setup
Versions

Rust: rustc 1.43.0-nightly (564758c4c 2020-03-08)
Diesel: 1.0.0
Database: MariaDB '8.0.19'
Operating System: Microsoft Windows 10 PRO Build 18363

Feature Flags

diesel: mysql, chrono

Problem Description
I want to call a stored procedure with diesel
What are you trying to accomplish?
Calling a stored procedure with diesel, ex: CALL get_user(1);
What is the expected output?
user = User {
    id: 1,
    name: "Christoffer",
    created_at: 2020-03-22T19:28:46,
}

What is the actual output?
thread 'main' panicked at 'Couldn't get result: DeserializationError("No metadata exists")'
Are you seeing any additional errors?
No
Steps to reproduce
See the following git repo
Checklist

[x] I have Googled, but I haven't found anyone with the same error, only reference I find is in the source (ofc)
[x] Googled stored procedure in diesel and found the following gitter discussion

Maybe it's not possible?

Your stored procedure does not return anything. That means there is nothing that could be loaded by get_results there. In such cases prefer to use .execute.

Your stored procedure does not return anything. That means there is nothing that could be loaded by get_results there. In such cases prefer to use .execute.

Hello
So, if I understand you correctly I cannot use a stored procedure for a select?
Regarding using execute for a stored procedure, looking at this
"When asking the database to return data from a query, load should probably be used instead."
I thought about using a view; but I need to be able to use parameters.
I also thought about including the query from a .sql file and populating the parameters with the bind param; but I couldn't find anywhere where I could use a named param for binding.
Would you be able to point me in the right direction?

Your stored procedure does not return anything. That means there is nothing that could be loaded by get_results there. In such cases prefer to use .execute.

Hello
Thank you for replying so quickly!
So there is no way for me to return the rows of a select statement in a stored procedure? (like with some NodeJS libraries)
I need to return the rows, is it better to just load in the query as a str and bind the params instead?
Thanks in advance!

So there is no way for me to return the rows of a select statement in a stored procedure? (like with some NodeJS libraries)

There is nothing preventing that, as long as libmysqlclient is giving us the required information about the result set. (If this query returns something then there is an bug in libmysqlclient, as it has no metadata about the structure of the result.) Then using .load/.get_results` is the right way.
As I'm never used any nodejs library I cannot say you what they can do and how it's done there.

I need to return the rows, is it better to just load in the query as a str and bind the params instead?

I probably would just go that way. Basically just do sql_query(include_str!("your_query.sql")).bind("whatever").load(…). So you have the sql query in a separate file and your editor can do syntax highlighting/linting/… there.

So there is no way for me to return the rows of a select statement in a stored procedure? (like with some NodeJS libraries)

There is nothing preventing that, as long as libmysqlclient is giving us the required information about the result set. (If this query returns something then there is an bug in libmysqlclient, as it has no metadata about the structure of the result.) Then using .load/.get_results` is the right way.
As I'm never used any nodejs library I cannot say you what they can do and how it's done there.

I need to return the rows, is it better to just load in the query as a str and bind the params instead?

I probably would just go that way. Basically just do sql_query(include_str!("your_query.sql")).bind("whatever").load(…). So you have the sql query in a separate file and your editor can do syntax highlighting/linting/… there.

Thank you! Yes I ended up doing the "your_query.sql" thing :)
Cheers


Added entries for Winzip.

Added entries for WinZip 64-bit and 32-bit exe files to treat them as floating applications.

[ ] I have formatted applications.yaml with komorebic fmt-asc.

Note: Since I use komorebi on my work laptop, I couldn't use that to raise this PR due to organization policy and had to use my Mac to raise this PR, which is why I was unable to run the formatter.

You forgot to put the float_identifiers

I will add that. Thanks for pointing it out.

Side note: Why not use 7-Zip/NanaZip instead which is completely free and open-source?

Work laptop 😆. I have no control over what comes bundled with it.


hash/maphash: Document whether used hash algorithm is stable across future versions

The new hash/maphash package in Go 1.14 doesn't make any statement about whether the hash results can differ in future versions or not.
At worst people will just assume they won't differ and store those hash values expecting to be able to repeat the hashing given the same values and seeds in the future.
I would sleep better when this was made more explicit in the documentation.
What version of Go are you using (go version)?

$ go version
go version go1.14beta1 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/me/.cache/go-build"
GOENV="/home/me/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/me/sources/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/4962"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/4962/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/user/1000/go-build057059169=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Read documentation of new package https://tip.golang.org/pkg/hash/maphash/
What did you expect to see?
Documentation on whether the hash function will always deliver the same hash across all Go 1 versions in the future given the same seed and bytes to be hashed.
What did you see instead?
No statement whether I can assume this or not.

I agree this should be called out in the packages documentation.
As this is using the runtime hash which has different implementations (non-AES vs AES) it can differ even using the same binary depending on cpu feature detection. It seems https://golang.org/cl/205069  dropped this part of the documentation which outlines that hashes are not even guaranteed to be equal between processes using the same binary:
// Two Hash instances with the same seed in different processes are
// not guaranteed to behave identically, even if the processes share
// the same binary.
@randall77 @rsc

It now says:
// Each Seed value is local to a single process and cannot be serialized
// or otherwise recreated in a different process.

There's no way to transfer a seed between processes (including the same binary across time).
So you can't observe a different algorithm because you can't use the same seed.

@randall77 Repeating such a statement in the packages overview section and maybe the relevant release notes section might help setting the expectations straight in more prominent places.


Use net-scp rather than unison

Since our file watcher tells us exactly which files have changed, we could drop the unison dependancy and just use the net-scp gem to scp the changed files over.
This should also make the sync faster.

Bidirectional sync of some sort would be hot. Even NFS is nothing like running code in the VM's native FS.

latest version of plugin (reachable here http://github.com/dmatora/vagrant-unison )
does realtime bidirectional folder sync


Create Models for new unified cyhy db schema

💡 Summary
Future versions of crossfeed require data from all cyhy teams, this requires a complete db overhaul to store all relevant data and relationships.
Motivation and context
Creating these models in Crossfeed will allow us to generate the new db through the ORM and will fast track the code to link Crossfeed to this new db in the future.

@DJensen94 and @schmelz21 I believe, and please correct me if I am wrong, you are referring to the ASE data lake, and not the Crossfeed application database, in this issue, is that correct?
All of our disparate assessment resources data will be funneled into the ASE data lake, where various tools, like Crossfeed (and others), will drink from and satiate themselves with information pertinent to the application's role in our technology portfolio.


added check for thunk before resolving as payload

After replacing the next calls with dispatch, the resolved payload can go through the whole middleware stack which is cool
const action = () => ({
 type: "FOO",
 payload: {
  promise: Promise.resolve({ payload: 'goes through middleware earlier in stack' })
 }
})

But we assume these resolved values are either a payload or an action, so this change also checks for thunks or well... functions... if we find a function has been resolved, we dispatch it.. instead of only checking for payload or meta and then trying to dispatch the resolved value as a payload.
So now this should work too:
const action = () => ({
 type: "FOO",
 payload: {
  promise: Promise.resolve((dispatch, getState) => { // resolve a thunk!
   dispatch({ payload: 'goes through middleware earlier in stack' })
   dispatch({ more: "things" })
   dispatch(updateRoute('/happy-composition-town'))
   doSomethingNaughtAfterDispatchingEverything(getState())
  })
 }
})

Looks good :+1: Feel free to merge

Can we get this in a version bump on NPM please? :)

Yup. I'll get to it tonight.
On Nov 25, 2015 8:29 PM, "Thomas"<EMAIL_ADDRESS>wrote:

Can we get this in a version bump on NPM please? :)
—
Reply to this email directly or view it on GitHub
https://github.com/pburtchaell/redux-promise-middleware/pull/30#issuecomment-159784786
.

Alright, this is released as<EMAIL_ADDRESS>

I'm thinking it would also make sense to have this same functionality on rejected actions. I could see it being used there as well. Thoughts?

Yes that makes sense, it would be simple enough to check the rejected/error value and pass it to the dispatch if it looks like an action or thunk :)


Payment and shipping methods sync with Magento

https://github.com/DivanteLtd/vue-storefront/issues/691

@akbarik great job; please add the notification after user selects any other method than cashondelivery to just notify that the work is underway for implementing the real payment methods as planned on https://github.com/DivanteLtd/vue-storefront/issues

@pkarw, have you had a chance to test this PR yet?

Not, yet I'll try to do this soon!

@akbarik as we discussed on slack - in generall this is cool BUT we need to debug the network request multiplication + errors on empty cart (add to cart -> remove all products)


feature request: connect to MySQL over SSL with client certificate

I'm setting up and evaluating Teletraan for our primary deployment manager. In our infrastructure requirements, we have to connect to MySQL over SSL with a client certificate and a self-signed server certificate. I looked for ways to do this for a while, but there seems to be no ways.
So it would be great if there ware a way to connect to MySQL over SSL.
(I joined<EMAIL_ADDRESS>but it doesn't seem to be active; If GitHub Issues is not appropriate place to do feature request, please close this and point me an appropriate place. )

I don't think it comes  out of box. Per my understanding, it just needs some options to be enabled in connection string. But it shouldn't be too hard to add it. Probably just change MysqlDataSourceFactory.java . Do you have a sample connection string you want to use?

Nope.  I'm not familiar with JDBC and also Java.  As I read Connector/J documentation, the parameter would looks like &useSSL=true&requireSSL=true&verifyServerCertificate=true&clientCertificateKeyStoreUrl=/path/to/client-cert.jks&clientCertificateKeyStoreType=JKS&trustCertificateKeyStoreUrl=/path/to/server-cert.jks&trustCertificateKeySToreType=JKS
An alternative MySQL client command line to intended to make same connection is mysql -u user -p --ssl-cert /path/to/client-cert.pem --ssl-key=/path/to/client-key.pem --ssl-ca /path/to/server-ca.pem
The transformation to JSK from PEM is done by converting PEM to DER using openssl, then import it to JKS keystore using keytool.

I have made a change so you can pass connection properties, for ex,
db:
DB backend type. Allowed values are: embedded, mysql.
type: mysql
Mysql instance configurations
host: ${TELETRAAN_DB_HOST:-localhost}
port: 3306
userName: root
password:
connectionProperties:
useSSL: true
verifyServerCertificate: true
...
https://github.com/pinterest/teletraan/pull/364

Merged

Thank you for your quick support!  I'll try the latest revision in next few days.


Add access your deployments docs

Updates

feat: Add docs for accessing user deployments
feat: Mention access_your deployment in sidebar
feat: Update playground/home.md to match sidebar

Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/1925

Duplicated


Update reporter_darwin.go

I don't see any changes to code here besides an empty line? Am I missing something?

just remove the conflict message from the code comments, nothing wrong with the code itself :)

Thanks!


Add LD_LIBRARY_PATH into search paths for libmxnet.so.

By convention, dynamic objects like libmxnet.so are searched in LD_LIBRARY_PATH on POSIX platforms. Python seems to ignore this convention, which requires extra hack on the user side, such copying libmxnet.so file for each training project.
I add LD_LIBRARY_PATH into search paths, making libmxnet.so act more like a standard library.

setup.py also rquires libinfo.py to report the proper path to libmxnet.so at packaging. Similar to the case that train_mnist.py is run for veryfying Python environment, intallation exists if libmxnet cannot be found in the default path.
I follow the guildes on readthedoc, spliting my installation into two parts: 1) building libmxnet.so; 2) buiding "dapaters" for various languages. I really admire the separation of "libs" (maintained by adminstrators) and "lib callers" (maintained by users). However, rather than linking at runtime, Python's setup.py makes a copy of libmxnet.so into local dir, which may misses potential updates.

This seems to be nice, can we make sure the priority of the path is maintained, e.g. First local path, then the LD_LIBRARY_PATH.
The main purpose is that most users may not know how to install libmxnet, so we need to make sure things is correct for them. The most common use case is actually not doing installation at all and setup the PYTHONPATH, which enables quick updates of versions

My modification adds LD_LIBRARY_PATH after curr_path and api_path. Libs in curr_path and api_path will be selected in priority as long as dll_path is searched in order. I run some tests to prove that system-wide and local libmxnet.so can co-exist, and the local one will be picked first.
I got to support various users too. My experiences are:

Build a stable/verified/high-performance lib and install it system-widely. So the users don't bother to build them from scratch. For examples, atlas, openblas and mxnet.
Users can customize their virtual environment in $HOME. virtualenv-like tools are essential. I favor it a lot more rather than sudo pip.
For advanced users, they can build everything (compilers, linkers, libs...) from scratch in $HOME.

As mxnet is still in fast iteration, administrators hold the responsibility to update the system-wide libmxnet.so to date.

sounds good, this is merged.


Add Sather in Available languages section in readme file.

I want to take up this issue, can you pleas assign to this me


Shutdown and Sleep Timers

Description of the new feature / enhancement
Please create a timer tool, where at a specified time or after a certain duration, to put the machine to sleep.
Scenario when this would be used?
I would like to set my system to sleep after 45 minutes, knowing I have a file transfer that takes about 39 minutes.
Supporting information
The sleep tools and command line shutdown tools are far too limited. I cannot find reasonable command line methods to put my machine to sleep after a timer, and I would like to see some kind of timer on my screen counting down. It would be extra sick if I could just hit a big Cancel button via UI

/dup https://github.com/microsoft/PowerToys/issues/28490


feat: calculate stability window slots count in wallet

Context
The stability window must be calculated to determine which confirmed transactions might be subject to rollback.
The formula to calculate this window is 3k/f (where k is the security parameter in genesis, and f is the active slot co-efficient parameter in genesis that determines the probability of amount of blocks created in an epoch.)
Once NetworkInfo includes the parameters, it should be used to calculate the stability window and use it instead of the hardcoded value.
Proposed Solution
Apply the stability window formula on the client (wallet) and provide the value as observable where it is needed.
Important Changes Introduced

extend createTransactionReemitter with stabilityWindowSlotsCount$
apply the formula to calculate stabilityWindowSlotsCount value
update marble tests

Now it's located as suggested: src/util/stabilityWindowCalc.ts - 95f44ec92b502271f276ef2fb8792be2220519ac @rhyslbw

Rebased with master, commits are squashed and the commit is marked as breaking change. (raised by @mirceahasegan here)


Strictest Possible Content Security Policy?

Has anyone done the brain damage on how to craft the strictest possible content security policy for an app using this lib?
Here's the config I was using for my app:
"ContentSecurityPolicyConfiguration": {
"DefaultSrc": [
"'self'"
],
"ScriptSrc": [
"'self'",
],
"StyleSrc": [
"'self'",
"'unsafe-inline'",
],
"FontSrc": [
"'self'",
"data:"
],
"ConnectSrc": [
"'self'",
"https://login.microsoftonline.com/",
"https://graph.microsoft.com/"
],
"FrameSrc": [
"'self'",
"https://login.microsoftonline.com/"
],
"BaseUri": [
"'none'"
],
"BlockAllMixedContent": "true",
"UpgradeInsecureRequests": "true",
"ReportUri": ""
},
However, I kept getting script-src violations (unsafe inline) in the "#access_token=" callback. My app worked in spite of this violation being blocked so maybe there's a setting to turn this off?
I'm also curious if the urls above are guaranteed not to change?

Is no one else implementing CSP in their app?


DM-39621: Adopt nox for running tasks in the monorepo

This PR replaces tox with nox. The goal is to have a more flexible test orchestrator that can run CI tasks for both the client and server components of the repo. This is something we haven't been able to do with tox; right now there's a separate tox configuration for both the client/ and server/ directories. Some of these issues were anticipated in SQR-075, and developing Squarebot further underscored the challenges of using tox in a monorepo. With nox there's a single nox configuration.
Since nox uses Python for its configuration, it's also a great deal more flexible than tox. In fact, I've been able to roll all the make targets into the noxfile.py. Here are the nox sessions:
* lint -> Run pre-commit hooks.
* typing -> Run mypy.
* test -> Run pytest.
* docs -> Build the docs.
- docs-linkcheck -> Linkcheck the docs.
- scriv-create -> Create a scriv entry.
- scriv-collect -> Collect scriv entries.
- update-deps -> Update pinned server dependencies and pre-commit hooks.
- dev-init -> Set up a development venv.
- run -> Run the application in development mode.

@rra Sending this your way because you might be generally interested and because I know that make update-deps is a bit of an API for neophile (is that right?). I'm not ready to say we should go all-in with nox (it doesn't have a docker plugin, for instance), but it is pretty nice and flexible.

That's a good point. I think I'll split dev-init into two sessions that hopefully use the same logic: one for just installing the app into the current environment, and another for setting up a virtual environment as well.
I also used to use virtualenvwrapper. Using venv directory is much the same, just that now the virtualenvs are centralized typically put in the project directory (.venv) rather than being centrally managed by virtualenvwrapper. The shell prompt, for me at least, works identically whether it's a virtualenvwrapper or venv. I made the switch because I got tired of pruning and managing those centralized virtualenvs, but I'll still use it ocassionally to build virtual envs not tied around a specific development project.


Upgraded MUI and some improvements to contributing file

closes #32

MUI to beta 22
React to 16.2 (YAY for fragments)
Changed the fork updating procedure to use pull instead of merge.

@JesseRWeigel See #33 there is some discussion

Thanks @pantharshit00 !


Partial Build [Possibly due to parallelization]

The screenshot below shows a partial build of the Language docs, even though the build log shows them built. Visiting the missing pages directly gave a 404.
This issue may or may not have been caused by 8d83f42b857fb4725de552c16ffdf90df72e081f that added parallelzation. We undid it in d41f52ec5680ed140ccda17180049aa202875143 and the docs built fine.
Some more testing needs to be done with the parallelzzation feature turned on.

I would not have --parallel enabled for whatever auto-builds the docs for docs.perl6.org. I believe my code is correct, but Rakudo just doesn't implement it well enough (yet). On my machine it's actually still faster to just run with --parallel a couple times until it completes, versus running it serially, but unless the script loops until the exit status is ok I'd leave it on the old behavior for the website.

The parallel code causes SEGVs and other oddities. A barebones version of htmlify that exhibits the issue is on the coke/bughunt branch

jnthn++ fixed the issues I had golfed down on the coke/bughunt branch - need to investigate what issues are left with --parallel now.

The remaining one I know about is the code-gen for NEXT phasers in while/until/loop has issues, which show up under recursion of concurrency. There may be further problems in htmlify.p6 and its related modules beyond those I already fixed, however. Guess we'll see after the NEXT bug is addressed.

@jnthn ticket id?

What's the current status of this? If I got this correctly, parallelization is turned off but we would like to turn it on for, among other things, speed up test, right?

It looks like this issue has been addressed and is no longer needed. I'll close it, please clarify and reopen it if necessary.


chore: bdd-nh-1586357969 to 0.0.1

chore: Promote bdd-nh-1586357969 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Performance issues in flink-ai-flow/ (by P3)

Hello! I've found a performance issue in flink-ai-flow/: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.
Detailed description is listed below:

ai_flow/test/util/model_util/iris_data_utils.py /: .batch(batch_size)(here) should be called before dataset.map(_parse_line)(here).
examples/wide_and_deep/dependencies/python/code/census_dataset.py/: dataset.batch(batch_size)(here) should be called before dataset.map(parse_csv, num_parallel_calls=5)(here).

Besides, you need to check the function called in map()(e.g., parse_csv called in dataset.map(parse_csv, num_parallel_calls=5)) whether to be affected or not to make the changed code work properly. For example, if parse_csv needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).
Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf , if you have the interest on this performance issue, go ahead to create a PR to fix it.


Delete mutiple stash entries

Currently you can delete the stash entries one at-a-time or all of them. It would be good if you could shift + select many stashes and delete them

Thanks for your suggestion @sketchbuch, I do like it. If I recall correctly multiple items cannot be selected on tree views (need to investigate), however there's multi-select support on option pickers, so mostly sure this will be added as a feature hopefully soon.


Fix leader master priority always 0

What changes are proposed in this pull request?
Reopen pr #14156
Why are the changes needed?
Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

@ggezer @jenoudet I mistakenly deleted the origin branch, sorry about that, create a new pr, PTAL!

Codecov Report

Merging #14171 (81692f1) into master (4087a38) will decrease coverage by 25.95%.
The diff coverage is 2.08%.

@@              Coverage Diff              @@
##             master   #14171       +/-   ##
=============================================
- Coverage     43.23%   17.28%   -25.96%
+ Complexity     9258     2702     -6556
=============================================
  Files          1436     1436
  Lines         83067    83104       +37
  Branches      10050    10052        +2
=============================================
- Hits          35917    14367    -21550
- Misses        44163    67485    +23322
+ Partials       2987     1252     -1735

Impacted Files
Coverage Δ

...alluxio/master/journal/raft/RaftJournalSystem.java
0.00% <0.00%> (-56.38%)
:arrow_down:

...ava/alluxio/multi/process/MultiProcessCluster.java
0.00% <0.00%> (-60.17%)
:arrow_down:

...n/java/alluxio/multi/process/PortCoordination.java
0.00% <0.00%> (-94.45%)
:arrow_down:

...common/src/main/java/alluxio/conf/PropertyKey.java
97.89% <100.00%> (-1.51%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 679 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cded4...81692f1. Read the comment docs.

alluxio-bot, merge this please


Fix multiple recent Bullet physics crashing issues.

Fixes #40311
Fixes #40840
As elaborated on here and here, #39726 has caused multiple crashing issues (such as #40311 and #40840) which are not being fully resolved with #40252 (see comment) #40886 or #41067 (see comment) Furthermore, it did not solve #30027 for which it was created. Therefore this PR reverts #39726, which also requires reverting #40252.
Note: This PR also includes three additional commits:

Improves #40127 (using the change from #40186) instead of #40252.
The fix for #40508 included in #40252; but extended to include dampening.
A fix for #41040 that also relied on a #39726.

Finally I've confirmed it does not revert the fix for #40506.

The benchmark code is this:
extends Node

var count = 0

var shapes_per_frame := 2000
var shape := BoxShape3D.new()
var t1

func _ready():
	t1 = OS.get_ticks_msec()
	_do_test()

func _physics_process(delta):
	if count < 3:
		var t2 = OS.get_ticks_msec()
		count += 1
		print("Frame ", count, ": ", t2 - t1, "ms")
	else:
		get_tree().quit()

func _do_test():
	print("Test start")
	for i in range(0, shapes_per_frame):
		var rb = RigidBody3D.new()
		var c = CollisionShape3D.new()
		c.set_shape(shape)
		rb.add_child(c)
		add_child(rb)
		if i % 50 == 0:
			print("Added: ", i)

This is the benchmark result obtained by this PR on my pc:
Test start
Added: 0
Added: 50
Added: 100
Added: 150
Added: 200
Added: 250
Added: 300
Added: 350
Added: 400
Added: 450
Added: 500
Added: 550
Added: 600
Added: 650
Added: 700
Added: 750
Added: 800
Added: 850
Added: 900
Added: 950
Added: 1000
Added: 1050
Added: 1100
Added: 1150
Added: 1200
Added: 1250
Added: 1300
Added: 1350
Added: 1400
Added: 1450
Added: 1500
Added: 1550
Added: 1600
Added: 1650
Added: 1700
Added: 1750
Added: 1800
Added: 1850
Added: 1900
Added: 1950
Frame 1: 8618ms
Frame 2: 22686ms
Frame 3: 34715ms

This is the result obtained using the current master branch:
Test start
Added: 0
Added: 50
Added: 100
Added: 150
Added: 200
Added: 250
Added: 300
Added: 350
Added: 400
Added: 450
Added: 500
Added: 550
Added: 600
Added: 650
Added: 700
Added: 750
Added: 800
Added: 850
Added: 900
Added: 950
Added: 1000
Added: 1050
Added: 1100
Added: 1150
Added: 1200
Added: 1250
Added: 1300
Added: 1350
Added: 1400
Added: 1450
Added: 1500
Added: 1550
Added: 1600
Added: 1650
Added: 1700
Added: 1750
Added: 1800
Added: 1850
Added: 1900
Added: 1950
Frame 1: 34ms
Frame 2: 8914ms
Frame 3: 13978ms

This is flame graph extracted by the perf of this PR:

This is flame graph extracted by the perf of master branch:

Rebased following #42061.

Superseded by #42639. I've created #42649 and #42650, and reopened #40186 and #40187 to address the issues addressed by this PR, but not addressed by #42639.


Add parameter to filter between donors or receivers on /listings

Resolved in https://github.com/OrganIA/organia-server/pull/107


[DDC-3661] Fix count in Doctrine\ORM\LazyCriteriaCollection

Fix Doctrine\ORM\LazyCriteriaCollection::count() when Criteria::$maxResults defined
ps. I have no idea how to write test for it :speak_no_evil:

well, I even not sure that it is a right way to fix it

Requires a test case first, @Fedik


Add help text to 'more options' in command palette

Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.
Using the data template approach, we now have no need for the
HasNestedComandsVisibilityConverter, so that set of files is now
deleted. The logic to detect nested commands was moved to the template
selector.
PR Checklist

[ ] Addresses #7908 better

Validation Steps Performed
Tested using NVDA.

("tested using nvda" - did we test with narrator as well? It's inbox, so we must.)

("tested using nvda" - did we test with narrator as well? It's inbox, so we must.)

Tested with narrator too. It works, but you need to specifically request the help text.
NVDA automatically reads the help text for you.
That's not ideal, but I think it comes down to narrator's "philosophy" vs NVDA's. Injecting "more options" into the name (automation property) is specific guidance we've been told to avoid too.

Huh.


Extension XUnit

This PR extends XUnit in the following ways:

Extend the function combine_test_metrics  to return the parent that has been modified internally.
Extend the function create_test_metrics  to allow more flexible instantion of test_metrics.

@mdashti how about now? I will merge at your approval. Thanks a lot!


fix: Fix unicode error on binary files

If a unicode decode error is raised
while trying to compile a file as a Jinja2 template,
and the templates suffix is empty,
we fallback to copying this file as is.
Fixes #433.

Codecov Report

Merging #436 (5fb0ad2) into master (2fe3072) will decrease coverage by 16.20%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           master     #436       +/-   ##
===========================================
- Coverage   96.33%   80.13%   -16.21%
===========================================
  Files          39       39
  Lines        2456     2461        +5
===========================================
- Hits         2366     1972      -394
- Misses         90      489      +399

Flag
Coverage Δ

unittests
80.13% <42.85%> (-16.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

copier/main.py
92.92% <42.85%> (-1.85%)
:arrow_down:

tests/test_complex_questions.py
17.73% <0.00%> (-82.27%)
:arrow_down:

tests/test_prompt.py
14.86% <0.00%> (-72.98%)
:arrow_down:

tests/test_vcs.py
36.00% <0.00%> (-64.00%)
:arrow_down:

copier/user_data.py
56.79% <0.00%> (-37.38%)
:arrow_down:

tests/test_templated_prompt.py
76.92% <0.00%> (-23.08%)
:arrow_down:

tests/conftest.py
69.23% <0.00%> (-23.08%)
:arrow_down:

copier/tools.py
79.51% <0.00%> (-13.26%)
:arrow_down:

tests/test_updatediff.py
88.09% <0.00%> (-11.91%)
:arrow_down:

tests/test_migrations.py
92.91% <0.00%> (-7.09%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe3072...5fb0ad2. Read the comment docs.

Erm, of course, I'm re-raising, not copying the file, the message is completely wrong! Thanks for noticing :sweat_smile:

Please squash and merge, there's only one real commit, the rest are fixups.


[OSD-19188] remove the backplane url checks from cloud subcommands

What type of PR is this?
(cleanup)
What this PR does / Why we need it?
With the previous changes, the backplaneConfiguration should always have the URL value set, if not, it will return with error earlier.
Pre-checks (if applicable)

[ ] Ran unit tests locally
[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f3b8df7) 45.93% compared to head (f193949) 45.98%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   45.93%   45.98%   +0.04%
==========================================
  Files          53       53
  Lines        3753     3749       -4
==========================================
  Hits         1724     1724
+ Misses       1754     1750       -4
  Partials      275      275

Files
Coverage Δ

cmd/ocm-backplane/cloud/console.go
22.91% <ø> (+0.46%)
:arrow_up:

cmd/ocm-backplane/cloud/credentials.go
62.50% <ø> (+1.68%)
:arrow_up:

/lgtm


Resource Group documentation has markup instead of items

The page shows:
Parameters
filter
[str](https://docs.python.org/3/library/stdtypes.html#str)
Required
The filter to apply on the operation.:code:
:code:>><<<br>You can filter by tag names and values. For example, to filter for a tag name and value, use $filter=tagName eq 'tag1' and tagValue eq 'Value1'. Default value is None.

under list
and
Parameters
resource_group_name
[str](https://docs.python.org/3/library/stdtypes.html#str)
Required
The name of the resource group to create or update. Can include alphanumeric, underscore, parentheses, hyphen, period (except at end), and Unicode characters that match the allowed characters. Required.

parameters
[ResourceGroup](https://learn.microsoft.com/en-us/python/api/azure-mgmt-resource/azure.mgmt.resource.resources.v2020_10_01.models.resourcegroup?view=azure-python) or <xref:IO>

under create_or_update

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f00ea74c-a548-5e71-da54-db1ba63b452e
Version Independent ID: 4db759e0-94a2-4a73-ecf7-32294fc9e168
Content: azure.mgmt.resource.resources.v2020_10_01.operations.ResourceGroupsOperations class
Content Source: docs-ref-autogen/azure-mgmt-resource/azure.mgmt.resource.resources.v2020_10_01.operations.ResourceGroupsOperations.yml
Service: azure-resource-manager
GitHub Login: @lmazuel
Microsoft Alias: lmazuel

Thanks for the feedback, we’ll investigate asap.

Hi, @andre-qumulo
I have checked the documentation, for the problem mentioned under list, it may caused by invalid characters included in the swagger. An issue has been opened to request for an update.
Yet for it under create_or_update, I didn't find any incorrectness there. If you mean that there are repeated Parameters characters., the Parameters above is for create_or_update method, and the next parameters stands for the information of resource group need to be provided. Or if not, please provide more information about it.

I'm confused by the  or <xref:IO> at the end of the line under the parameter

I'm confused by the  or <xref:IO> at the end of the line under the parameter

Thanks for pointing it out!
The <xref:IO> may supposed to be redirected to this reference https://docs.python.org/3/library/io.html#module-io, but for some reason the hyperlink doesn't work well. An issue has been opened for suggestions.
In short, it means you could send your requests in a json-like object like this sample.

Another recommendation I would have is to list the verbs we can use in the
filter or link to a page that has them.
Other filters allow 'beginswith' or 'substringof' but the error response
when I used them was somewhat confusing.
I was trying to get resource groups with a partial name match but now it
looks like I need to pull all of them and filter client side.  The nature
of our product is that we have two resource groups per customer so we
expect to have hundreds/thousands at some point.
Clearly calling out what we can or can't use in the filter would be greatly
appreciated.
On Tue, Aug 15, 2023, 11:53 PM ChenxiJiang333 @.***>
wrote:

I'm confused by the or xref:IO at the end of the line under the
parameter
Thanks for pointing it out!
The xref:IO may supposed to be redirected to this reference
https://docs.python.org/3/library/io.html#module-io, but for some reason
the hyperlink doesn't work well. An issue has been opened for suggestions.
In short, it means you could send your requests in a json-like object like
this sample
https://github.com/Azure/azure-sdk-for-python/wiki/Common-issues-about-Python-SDK#different-ways-to-set-body-parameter-of-an-operation
.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/azure-sdk-for-python/issues/31647#issuecomment-1680061168,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4OQ323NGRRN4ZCW5GU5D3LXVRU63ANCNFSM6AAAAAA3QI5GTI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Agree with you that service team shall provide more info about how to use the filter. Could you make an issue in https://github.com/Azure/azure-rest-api-specs/issues? After service team updates swagger, SDK team will release a new version to adopt the change.

I opened this issue:  https://github.com/Azure/azure-rest-api-specs/issues/25389

Hope we could get positive feedback from service team.

Given this is a swagger issue, please use https://github.com/Azure/azure-rest-api-specs/issues/25389 to track the issue.


Waypoints in SharePoint

Sadly, SharePoint screws up pageYOffset and pageXOffset leaving it as 0 (the only one I care about it pageYOffset). So this.adapter.scrollTop() always equals 0. In both jquery.waypoints.js and waypoints.js, this is faults and errors out. In jQuery, jQuery('selector').offset().top works for the top.
I would really love help in fixing this in a couple ways:

Add an event to hook into, trigger, and/or over-ride the waypoint check. There is probably way to do this as I haven't had the time to do a deep dive yet. In SharePoint, since the pageYOffset and pageXOffset always remain 0, the scroll.waypoints and resize.waypoints never trigger.
Create a hack patch to get me through this hiccup that works either with the noframework or jQuery scripts.

Please feel free to reach out to me for more information and/or an environment to have this reproduced and testing.

I have no experience with SharePoint, so the following suggestions are out of thin air. If you would like to share with me a link to the actual site produced, you have my email.

Is the window/body/html the element being scrolled? If, perhaps, the scrolling element isn't the window but some other scrollable element consider setting the context option.
The way adapters work you can redefine what "scrollTop" ends up running on the element. You could either fork one of the existing adapters and modify it for whatever SharePoint's proprietary offset needs are, or use an existing adapter and override the adapter definitions, e.g. Waypoint.Adapter.prototype.scrollTop = function() { ... }

Thanks for the help. I had to create a custom Adapter, only over-riding 2 prototype functions, and re-assign the context option. I'll add this to my fork soon.

I am facing similar issue can you provide me hack you have applied?

@Suresh-Lakum I do not have access to the code, and I failed to upload a PR or a demonstration. However, if memory serves me correctly, it has something to do with how SharePoint handles window.pageXOffset and window.pageYOffset. I will get my old computer and see if I can dig it back up, but I doubt I can.

@Suresh-Lakum Check out this gist: https://gist.github.com/wpsmithtwc/d448f7edaed4646b7070d956abf720fb
It contains the code I ran in production. I dumped all files that I thought my be relevant. I have the entire sln folder for Visual Studio but I left that world in 2015 and have frankly forgotten much of it. But if you are good with JS and know SharePoint JS best practices (e.g., wrap all functions in a SP object, use _EnsureJSNamespace & SP.SOD, etc), then you will be fine.

Thanks bud for response. I have solved that issue. But still your code is useful to me and many more like me. Cheers bud.


Failed build after latest SDK update

Description:

I'm failing to make a build after updating the npm version to 3.2.2. I get
No Unknown class method found for selector setExternalUserId:
No Unknown class method found for selector removeExternalUserId:
Environment

What version of the OneSignal React-Native SDK are you using? 3.2.2
How did you add the SDK to your project (eg. npm) npm

Steps to Reproduce Issue:

Update the OneSignal SDK with npm to 3.2.2
Build the project in Xcode

Anything else:
(crash stacktraces, as well as any other information here)
No Unknown class method found for selector setExternalUserId:
No Unknown class method found for selector removeExternalUserId:

would this be fixed if running pod update && pod install under ios folder?

We've released a new version. Please update and try again

Closing due to no response. (Note: we have update the SDK to version 3.4.0)


Training setup + Validation results

Hi,
thanks for this great work.
I have a question about the training setup for SemanticKITTI to train from scratch the models with image resolutions $(64\times1024)$ and $(64\times2048)$. Is it the same of the model with images $(64\times512)$ ?
Moreover, could you please provide the results on the validation set of the models with higher image resolutions ?
Thanks

Hi @SiMoM0
For Q1:  Yes. You can keep the same lr setting. For me, the train setting just limited by GPU Cost. So train 30 epochs for 1024&2048. You can also adjust it as it is not optimized by searching.
For Q2：I‘m not sure your meaning. 1024&2048 model has been released. Maybe you can get better performance with higher resolution like Tornado-net and KPRNet.

Ok, so the only way to train the models with images $(64\times1024)$ and $(64\times2048)$ is to use the pretrained model with resolution $(64\times512)$. Otherwise, I would not be able to replicate the results reported in the paper, correct?
Oh, thank you for clarifying that. I had assumed they were related to SalsaNext based on the name.

Same here, I was not able to reproduce the results in the paper with fine tuning.
At the end of the 64x512 cycle I get around 61mIoU on validation which is apparently normal. But then 63.3 with 1024x64 and 62.8 with 2048x64.
Strange thing is, when resuming the model is better initially (checkpoint trained on half resolution) than at the end of the first epoch. Is the lr_schedule still cosine with an initial ramp during fine-tuning ?

Same here, I was not able to reproduce the results in the paper with fine tuning. At the end of the 64x512 cycle I get around 61mIoU on validation which is apparently normal. But then 63.3 with 1024x64 and 62.8 with 2048x64.
Strange thing is, when resuming the model is better initially (checkpoint trained on half resolution) than at the end of the first epoch. Is the lr_schedule still cosine with an initial ramp during fine-tuning ?
Hi,
thanks for this great work.
1、May I ask how can I obtained the result of Article 64.7 MIOU? I followed the readme provided by the author, but no matter what, I couldn't achieve it, and the effect was only around 62. May I ask if you need any additional strategies and training techniques? Can you teach me?
2、If you use validation sets to optimize the model to improve accuracy, what are the specific optimization operations. Or other training techniques, could you please let me know?
We look forward to your reply
Best

Hi~@IKUNLOVER-FAN  Thanks for your attention and report. Sry for long time passed. I forgot some details.
For finetune, I just merge train and val set here and use low lr (e.g. 1e-5? sry i forget it) train 3~5 epochs.
https://github.com/huixiancheng/CENet/blob/9a84103d186a1f93637cae3d96426760deb04140/modules/trainer.py#L63-L65
However, this is an intuitive setup and trick. Unable to find optimal policy. Probably improve 1.5-2 miou on the test set.
Maybe you could find better policy in other newly SOTA papers.

Thank you very much for the follow up.
BTW your code is pleasure to work with when coming from the abomination that is mmdetection ;-) !


Perform YAML validation of config files

I have had YAML formatting problems numerous times that resulted in the storage driver not starting correctly.  Troubleshooting was able to narrow it down to invalid characters etc in the YAML files.
It would help the user experience a lot when configuring new and more complex drivers to perform a basic validation of the config.yml file prior to attempting a service start with it.

Hi @clintonskitson,
I agree this is a good idea, and I've even looked into it in the past, but Viper has always failed gracefully, ignoring bad content, when loading files. To that end I've just submitted a PR to Gofig that can be used to validate YAML. See the test TestValidateYAML.

Very nice @akutz.  I just did some basic testing with it and it is going to help a lot.  The package looks to be pretty verbose with errors.  Maybe we should add in a brief blurb into the docs in the configuration section about taking the config to yamllint.com if there are errors in their configs.
 line 4: found a tab character that violate indentation

Hi @clintonskitson,
Well, I'm not controlling content of said errors. To what type of verbosity are you referring? Also, I had no intention of necessarily printing out the direct errors. We could always catch the error and print out to the user that they should take the YAML and submit it to yamllint.com themselves. We can't expect to have network access to do it programmatically, but we can let them know to do it on error.

Yah exactly.  I was actually just thinking about calling it out with a couple of sentences in the docs themselves.  But an explicit comment to verify it online or with a lint would work as well.
What would be your concern with repeating the errors that YAML returns?

I have no such concern; from your comments above it seemed you did regarding the errors' verbosity.

Nope, I believe they would be very helpful for people configuring the service.

The package looks to be pretty verbose with errors. Maybe we should add

The declaration of verbosity followed by a recommendation seems to me to indicate "Because it does this, we should do that as a counter/enhancement."
Just a case of intent and tone lost in text communication :)

Yeah, I missed the "I like this" part. =)

@akutz Is this something we are comfortable with introducing into 0.3.2?


Introduce turbo:before-morph and re-purpose turbo:morph

Follow-up to 9944490
Related to #1083
Related to @hotwired/turbo-rails#533
The problem
Some client-side plugins are losing their state when elements are morphed.
Without resorting to MutationObserver instances to determine when a node is morphed, uses of those plugins don't have the ability to prevent (without [data-turbo-permanent]) or respond to the morphing.
The proposal
This commit introduces a turbo:before-morph event that'll dispatch as part of the Idiomorph beforeNodeMorphed callback. It'll give interested parties access to the nodes before and after a morph. If that event is cancelled via event.preventDefault(), it'll skip the morph as if the element were marked with [data-turbo-permanent].
Similarly, this commit re-purposes the new turbo:morph event to be dispatched for every morphed node (via Idiomorph's afterNodeMorphed callback). The original implementation dispatched the event for the  element as part of MorphRenderer's lifecycle. That event will still be dispatched, since  is the first element the callback will fire for. In addition to that event, each individual morphed node will dispatch one.
This commit re-introduced test coverage for a Stimulus controller to demonstrate how an interested party might respond. It isn't immediately clear with that code should live, but once we iron out the details, it could be part of a @hotwired/turbo/stimulus package, or a @hotwired/stimulus/turbo package that users (or
@hotwired/turbo-rails) could opt-into.

This does ease handling morphing inside of a Stimulus controller. I keep going back-and-forth on whether Turbo should just trigger an event like this, or if the generic concept of "you were just morphed" should live inside of Stimulus.
Consider this: I create a 3rd party Stimulus controller that, on mutates the HTML in same way - maybe just adding a hidden class when the user clicks something. When Turbo morphs, that hidden class would be removed. My Stimulus controller needs to be aware of the morph and "re-add" the hidden class (based on some internal state the controller keeps track of that says "you should be in the hidden state").
This could be handled with this event - e.g.
toggler->resetState">. However, that leaves 2 "not idea" things:

This data-action needs to live in userland code. I can't make my 3rd party Stimulus controller be "morph-ready" out-of-the-box (unless I decide to register the listener manually in the controller).
I believe... the resetState state would be called multiple times - if there were multiple elements morphed in the controller? If I'm correct, that's not... ideal, and it seems like it would be hard to de-dup that.

Also, since other libraries - HTMX, Livewire & Symfony Live Components - use morphing, it would be great to have a way that those could "hint" to Stimulus controllers that they are being morphed and then have the same behavior as when Turbo morphs.
Again, I go back-and-forth on this, but part of my thinks a morphed() method in Stimulus would be more usable (or perhaps this PR and that).
Thanks :)

Thumbs up. The turbo:before-morph event is also a solution to be able to initialize Alpine.js on the new nodes.

I would like to bring @seanpdoyle's PR hotwired/stimulus#460 back to the table. This was something that was supposed to be added to Stimulus but never merged. In my opinion it is quite common to create observers in Stimulus controllers and that need will only increase with Turbo morphing. What do you think?

I've played around with the whole morphing thing and I think there going are to be some issues with current approach, that maybe should be accounted before hand? So the whole problem starts with scripts that modify DOM on execution and append content to the end of the body or after the morphed element. Firstly, the scripts are not re-evaluated because of morph, which I think will need a solution, but more importantly, if for say a stimulus controller appends elements to the body on connect, like a global tooltip or select dropdown, the morph still removes them because in order of processing the nodes it firstly processes the Stimulus controller that appends the elements, e.g. to the end of the body, then it continues forward to those elements and decide that they should be removed because they do not match the new content from the new body, e.g.:
before morph:

on morph:

after morph (no matter if cleanup or not):

if it makes sense. This would also be the problem with script tags if they start to re-evaluate that modify the dom. From hindsight probably the stimulus controllers need to reconnect after the whole DOM was fully morphed.

@jorgemanrubia @afcapel I've expanded this change to include a turbo:before-morph-attribute event to afford stateful elements (like HTMLDetailsElement, HTMLDialogElement, TrixEditorElement, or a Stimulus controller with [data-*-value] attributes) an opportunity to partially opt out of the morph changes.

@jorgemanrubia prior to the introduction of these events, what strategies have you been using to support Trix and Stimulus controllers in a morph-compatible way?

I've opened https://github.com/hotwired/turbo-site/pull/159 to document these new events.

@jorgemanrubia prior to the introduction of these events, what strategies have you been using to support Trix and Stimulus controllers in a morph-compatible way?

We haven't found issues with Trix, I think because we aren't using a Trix instance in scenarios where a page refresh happens 🤔 . In the calendar, there is a single case where we used a stimulus value-change callback to prevent an unintended change in an attribute. It hasn't been a commong/recurring issue for us.

Just wondering if there was ever any progress on a tighter integration with morphing in stimulus? I know I'll have many cases of incompatibility as I go through my controllers and test them out, but one simple one is a button that starts off hidden and the connect() method shows the button once everything has booted up because I'm using static get shouldLoad(){} to check if the controller should load at all.
Right now as soon as the page is morphed the button disappears again but the connect method never re-runs. It's almost as if there needs to be another version of connect() such as morphed() or even just a reconnect(). It's so hard because the logic will be application specific. Sometimes you might actually want the updated values coming in from the morph, but you might also want to keep the ones that the browser has calculated.
It'd almost be better to have some kind of 'in-useflag on a controller and have the morph strategy either ignore updates from that controller node downward if it's in use, or otherwise mutate and callconnect()` again.

@brendon if still relevant, then you can try a bit different approach
connect() {
  this.element.addEventListener("turbo:before-morph-element", this.reconnect.bind(this))
  ...
}
reconnect(event) {
  this.element.replaceWith(event.detail.newElement)
}

this also works nice for updated values and connects your element back again since it gets added to the dom.

@brendon if still relevant, then you can try a bit different approach
connect() {
  this.element.addEventListener("turbo:before-morph-element", this.reconnect.bind(this))
  ...
}
reconnect(event) {
  this.element.replaceWith(event.detail.newElement)
}

this also works nice for updated values and connects your element back again since it gets added to the dom.

That's an interesting approach :) I've managed to iron out all my controllers now but will try this out next time I have an issue.
I found that if I only blocked updates of certain attributes (like class if a certain class currently exists like active) then I could maintain the state of the controller (e.g. a user has opened a dropdown menu) while still allowing the morphs to update the actual content of the dropdown menu.
I'm sure some smart cookie will come up with a clean way to describe these interactions in the future if turbo sticks with morphing :D


Support 1M+ scores starting with ABCDE, and level 30+

Done in https://github.com/timotheeg/nestrischamps/pull/13


Downloads page using https prefixed links, even if not using https

Hi,
I am running RTD inside a container, and I currently don't have and want HTTPS activated. Unfortunately after building html, epub and zip html archive, the build download page lists  all the links with https prefixed and so links from the download page are broken.
Here is the rendered html:

			latest PDF

			latest HTMLZip

			latest Epub

Looking at the code I don't see anywhere where this is added. Project model should return a relative path (//<PRODUCTION_DOMAIN><path>).
Any idea how I can change this behavior ?
Thanks,

The relevant code can be found at:
https://github.com/rtfd/readthedocs.org/commit/0425016d3c1931da7d07b7a0a27c953755ba3d52#L369-L380
But this is returning links without schemes, so there might be something else going on in your setup. If you have luck, a test case might be helpful here.

CLosing this, as we don't have enough information to debug it.


Organize project folder

Add a src directory for the lilypond files
Explain how the config.ly is generated by build.config.

Done!