Angular 1.6 - Change .success and .error to use .then promise for

Per
https://github.com/angular/angular.js/commit/b54a39e2029005e0572fbd2ac0e8f6a4e5d69014
and
https://toddmotto.com/angular-1-6-is-here#http-success-and-error
.success and .error are removed in v1.6 of Angular

Before I pull this change in can you confirm this change will be backwards compatible with older AngularJS versions?

Hi there,
Yes, it is backwards compatible. Using .then calls is part of the standard Promise API in angular. https://docs.angularjs.org/api/ng/service/$q
Just to be sure I tested it back to v1.0.1 and .then is defined and behaves as I’d expect.
https://codepen.io/anon/pen/NdqdGw
Most of the code was taken from this example $q example in the link above.
Let me know if you have any other questions.
Best Regards,
Jared Germano
—
Jared Germano
Q/A Developer
+1(603) 641-3900 Main
[4d-CADLearning-coobrand signature email]http://www.cadlearning.com/
From: Stephen Brannan<EMAIL_ADDRESS>Sent: Friday, January 6, 2017 12:54 PM
To: kinstephen/angular-azure-blob-upload<EMAIL_ADDRESS>Cc: Jared Germano<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [kinstephen/angular-azure-blob-upload] Angular 1.6 - Change .success and .error to use .then promise for (#14)
Before I pull this change in can you confirm this change will be backwards compatible with older AngularJS versions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/kinstephen/angular-azure-blob-upload/pull/14#issuecomment-270962077, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXyd336VuZP8CQU4Sc-xYVXGS0IJX6Upks5rPn_OgaJpZM4Lcx6v.


Fix array size in sycl SOA

After resize _arrays still had a size of 0. Because of this, there were problems with MergedTable in benchmarks

/intelci: run

/intelci: restart

/intelci: run


dart compile jit-snapshot giving incorrect script path

The dart compile jit-snapshot command executes a training run of the code. During this training run, Platform.script returns the path of the Dart source file that's being compiled. However, at runtime, Platform.script correctly returns the path of the compiled JIT snapshot. This inconsistency seems like incorrect behaviour.
Dart 2.15.1 on Windows 10

This is working as intended. Platform.script returns path to the file that was used to start the current isolate.


Fix darwin cross-build ldflags handling

Fixes https://circleci.com/gh/sdurrheimer/node_exporter/42 error

:+1:


Add empty verify pipeline

Signed-off-by: skeshari12<EMAIL_ADDRESS>
Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

This is already done here https://github.com/chef/corefoundation/blob/main/.github/workflows/unit.yml#L16

Hi Rishi, we want to run test on ruby 2.7, 3.0 and 3.1 using the PR verify pipeline As we are doing it for all the other managed repositories.

This is already done here https://github.com/chef/corefoundation/blob/main/.github/workflows/unit.yml#L16


[BUG] Can't start the script sometimes

Summary
A simple summary of the bug.
when i launch the script it crashes sometimes
Reproduction Steps
How did you make it happen?

start the script

Code
Relevant code that shows the bug.
future: <Task finished name='Task-8' coro=<ConnectionState._delay_ready() done, defined at /home/kouranio/.local/lib/python3.9/site-packages/discord/state.py:418> exception=IndexError('list index out of range')>
Traceback (most recent call last):
  File "/home/kouranio/.local/lib/python3.9/site-packages/discord/state.py", line 465, in _delay_ready
    self.call_handlers('ready')
  File "/home/kouranio/.local/lib/python3.9/site-packages/discord/state.py", line 234, in call_handlers
    func(*args, **kwargs)
  File "/home/kouranio/.local/lib/python3.9/site-packages/discord/client.py", line 284, in _handle_ready
    str(guild.channels[0].id): [
IndexError: list index out of range

Expected Results
What is supposed to happen?
the script starts normally
Actual Results
What is currently happening?
it crashes but when i start the script again and again it works sometimes
System Info
Run python -m discord --version and paste the information below.
- Python v3.9.5-final
- discord.py v1.8.1-final
- aiohttp v3.7.4.post0
- system info: Linux 5.12.12-arch1-1 #1 SMP PREEMPT Fri, 18 Jun 2021 21:59:22 +0000

Checklist
Let's make sure this issue is valid!

[x] I am using the latest released version of the library.
[x] I am using a user token.
[x] I have shown the entire traceback and exception information.
[x] I've removed my token from any code.

Additional Information
Put any extra context, weird configurations, or other important info here.

Add this to the endless list of things fixed by the next update :P


Bug - Editor not appearing

Category

What is the current behavior?

What is the desired behavior?

Additional information

I'm having issues simply opening the desktop GitBook editor - I am able to download the package from this page but actual application will not open. I have tried opening it both from the command line with gitbook-editor and directly in the Ubuntu Software Center but I get no response and no loading symbol to indicate it is attempting to start up.
I don't see any additional information in this Issue as to which OS is being used by my issue is on Linux.


Update 9-templating.md

Change file name 'Renderable' to 'Engine' because the interface is not found by Auryn Auto Loader as it finds classes/interfaces by their file names.

no prob


I would like to inquire about a solution to the following problem.

below code
my laptop specs : mac m1 max 64GB, macOs : 14.5
The code below is a test code that loads the model and generates for fine tuning.
from mlx_lm import generate, load
import os
os.environ["HF_TOKEN"] = 'hf_'
model, tokenizer = load("google/gemma-1.1-2b-it")
Generating without adding a prompt template manually
prompt = """
Why is the sky blue?
""".strip()
An error occurs in this part.
response = generate(
model,
tokenizer,
prompt=prompt,
verbose=True,  # Set to True to see the prompt and response
temp=0.0,
max_tokens=256,
)
This is the error message printed out.
"""
Prompt: Why is the sky blue?
libc++abi: terminating due to uncaught exception of type std::runtime_error: [metal::Device] Unable to build metal library from source
program_source:1079:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1104:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1130:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1157:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1185:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1214:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1244:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1275:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
program_source:1300:14: error: cannot initialize a variable of type 'bfloat16_t' (aka 'bfloat') with an rvalue of type 'float'
bfloat16_t tmp_B = 1.414062;
^       ~~~~~~~~
"""
I don't know why this error occurs, but I would like to ask for help if there is a solution.

Dupe of https://github.com/ml-explore/mlx/issues/1166


unable to install pandas-profiling: neither 'setup.py' nor 'pyproject.toml' found

I am trying to install pandas profiling on my new Macbook pro M1 (have used pandas profiling on other pcs and it worked amazingly). However, I have tried installing using pip, from git, and from the source, and all requests returned the same output below:
Defaulting to user installation because normal site-packages is not writeable
Collecting pandas_profiling
Using cached pandas_profiling-3.1.0-py2.py3-none-any.whl (261 kB)
Collecting seaborn>=0.10.1
Using cached seaborn-0.11.2-py3-none-any.whl (292 kB)
Collecting tangled-up-in-unicode==0.1.0
Using cached tangled_up_in_unicode-0.1.0-py3-none-any.whl (3.1 MB)
Collecting PyYAML>=5.0.0
Using cached PyYAML-6.0.tar.gz (124 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: pandas!=1.0.0,!=1.0.1,!=1.0.2,!=1.1.0,>=0.25.3 in ./Library/Python/3.8/lib/python/site-packages (from pandas_profiling) (1.4.1)
Requirement already satisfied: matplotlib>=3.2.0 in ./Library/Python/3.8/lib/python/site-packages (from pandas_profiling) (3.5.1)
Collecting markupsafe~=2.0.1
Downloading MarkupSafe-2.0.1-cp38-cp38-macosx_10_9_universal2.whl (18 kB)
Collecting visions[type_image_path]==0.7.4
Using cached visions-0.7.4-py3-none-any.whl (102 kB)
Collecting pydantic>=1.8.1
Using cached pydantic-1.9.0-cp38-cp38-macosx_11_0_arm64.whl (2.4 MB)
Collecting requests>=2.24.0
Using cached requests-2.27.1-py2.py3-none-any.whl (63 kB)
Collecting missingno>=0.4.2
Using cached missingno-0.5.1-py3-none-any.whl (8.7 kB)
Requirement already satisfied: jinja2>=2.11.1 in ./Library/Python/3.8/lib/python/site-packages (from pandas_profiling) (3.0.3)
Requirement already satisfied: numpy>=1.16.0 in ./Library/Python/3.8/lib/python/site-packages (from pandas_profiling) (1.22.3)
Collecting phik>=0.11.1
Using cached phik-0.12.1.tar.gz (600 kB)
ERROR: phik>=0.11.1 from https://files.pythonhosted.org/packages/02/9c/812ffada4a026ad20ad30318897b46ce3cc46e2eec61a3d9d1cf6699f79a/phik-0.12.1.tar.gz#sha256=63cf160c8950ec46da7a33165deef57f27d29f24b83cf4dd028aa0cb97b73af6 (from pandas_profiling) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.
Has anyone seen similar errors?

Same on this new M1 mac: pip install pandas_profiling errors out with
❯ pip install pandas-profiling
Collecting pandas-profiling
  Using cached pandas_profiling-3.1.0-py2.py3-none-any.whl (261 kB)
Requirement already satisfied: pandas!=1.0.0,!=1.0.1,!=1.0.2,!=1.1.0,>=0.25.3 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (1.4.1)
Requirement already satisfied: matplotlib>=3.2.0 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (3.5.1)
Requirement already satisfied: seaborn>=0.10.1 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (0.11.2)
Collecting multimethod>=1.4
  Using cached multimethod-1.7-py3-none-any.whl (9.5 kB)
Collecting htmlmin>=0.1.12
  Using cached htmlmin-0.1.12.tar.gz (19 kB)
  Preparing metadata (setup.py) ... done
Requirement already satisfied: scipy>=1.4.1 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (1.8.0)
Requirement already satisfied: missingno>=0.4.2 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (0.4.2)
Requirement already satisfied: jinja2>=2.11.1 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (3.0.3)
Requirement already satisfied: numpy>=1.16.0 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (1.22.3)
Collecting tangled-up-in-unicode==0.1.0
  Using cached tangled_up_in_unicode-0.1.0-py3-none-any.whl (3.1 MB)
Requirement already satisfied: requests>=2.24.0 in ./.venv-3.10.3-eda/lib/python3.10/site-packages (from pandas-profiling) (2.27.1)
Collecting PyYAML>=5.0.0
  Using cached PyYAML-6.0-cp310-cp310-macosx_11_0_arm64.whl (173 kB)
Collecting visions[type_image_path]==0.7.4
  Using cached visions-0.7.4-py3-none-any.whl (102 kB)
Collecting phik>=0.11.1
  Using cached phik-0.12.1.tar.gz (600 kB)
ERROR: phik>=0.11.1 from https://files.pythonhosted.org/packages/02/9c/812ffada4a026ad20ad30318897b46ce3cc46e2eec61a3d9d1cf6699f79a/phik-0.12.1.tar.gz#sha256=63cf160c8950ec46da7a33165deef57f27d29f24b83cf4dd028aa0cb97b73af6 (from pandas-profiling) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

Any help appreciated.

same problem on arm
its phik problem, install phik==0.11.1 before install pandas-profiling would help

@ellieyuyw There was an issue with the source distribution missing required files. KaveIO/PhiK#49 fixes the issue and adds wheels for ARM MacOS.

@RUrlus  @ellieyuyw @Wh1isper
confirming pandas-profiling-3.1.0 is installing now successfully using phik-0.12.2-cp310-cp310-macosx_11_0_arm64.whl
thanks everyone for the quick fix

problem solved! Thanks everybody :)


ms command-settings to access the display > graphics > standard graphics settings

Hello everyone, I need a command for quick access
(ms-settings) to access the display > graphics > standard settings graphics

Hi @vlad11z. Which version of Windows are you using. I do not see a "Display | Graphics | Standard Graphics" page on the latest builds of Windows 11, although the available pages can vary depending on device hardware. The ms-settings URIs support most standard configurations. There are a couple of graphics shortcuts available:

ms-settings:display-advancedgraphics --> This one launches "System | Display | Graphics"
ms-settings:display-advancedgraphics-default --> This URI launches "System | Display | Default graphics settings"
ms-settings:display-advanced --> On some supported hardware, this will launch the "System | Display | Advanced display settings" page, otherwise it defaults to "System | Display"
ms-settings:display --> This URI opens "System | Display" on all devices

There is no ms-settings shortcut available to launch a page named Standard graphics settings.
If you would like to suggest a new URI, you can submit product feedback through the Feedback Hub app in Windows.
There is also the community of experts and Microsoft Engineers over at Microsoft Q&A, who offer timely answers to a multitude of technical questions surrounding windows-dev-docs.
If you do create a thread over at Microsoft Q&A, we would appreciate if you could share that link here so we can track the progress and incorporate any technical details into our documentation. Though I'm marking this Issue as closed now, please treat this thread as an open thread for follow-ups. Thanks!


Implement equality methods

'red'.paint == 'red'.paint #=> false, should be true

Implemented by eef5e4f and 3fd2480.


Instrumentation for user survey

Report a count of

sites on which no consent dialog has been seen

sites where the consent dialog was delayed

for a user survey.

cc @chsiang

Count

occurrences of hiding the consent dialog

manual actions (block, unblock)

For now, you will be able to go to a (hidden, not linked to) page to see these counts.
In future this info will be hooked up to telemetry.


[bug]: unable to get local issuer certificate

Describe the bug
PS C:\Users\mr63\OneDrive my-app> npx shadcn@latest init
✔ Preflight checks.
✔ Verifying framework. Found Next.js.
✔ Validating Tailwind CSS.
✔ Validating import alias.
Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.
request to https://ui.shadcn.com/r/styles/index.json failed, reason: unable to get local issuer certificate
Affected component/components
all
How to reproduce
npx shadcn@latest init
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
windows

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

I am also facing the same issue

After running below it started working
For CLI
set NODE_TLS_REJECT_UNAUTHORIZED=0
For PS
$env:NODE_TLS_REJECT_UNAUTHORIZED=0

Hi @muhammad-anser ,
wouldn't it be an issue, if I am using these below commands on my work laptop ? it's kind a asking me to bypass my security certs. is it means that shadcn/ui is not safe enough to use in big organizations?
For CLI
set NODE_TLS_REJECT_UNAUTHORIZED=0
For PS
$env:NODE_TLS_REJECT_UNAUTHORIZED=0


Cycle through search results when reaching the bottom

Info

Operating System:
Shell:
Terminal:
nvim --version:
fzf --version:

[ ] The issue is reproducible with minimal_init.lua

fzf-lua configuration

require('fzf-lua').setup({
})

Description
Is there an option or something to cycle through search results similar to telescope?
Here's a video where I just keep on pressing <C-j> and it goes back to the top of the list
https://user-images.githubusercontent.com/10972027/173167870-73d623b3-42e7-472f-b263-05bf1d49b0eb.mp4

This behavior is controlled by the fzf binary, this should do what you want:
-- can also be added to 'setup' for convenience
require'fzf-lua'.files({ fzf_opts = { ['--cycle' = '' } })

Thanks for the fast response!


Collection#aggregate does not support options

I have found no way to pass options to the Collection#aggregate method as explained here: http://docs.mongodb.org/manual/reference/method/db.collection.aggregate/ for example to allowDiskUse for external sort operations.
Maybe a patch like this should be considered?
http://stackoverflow.com/questions/23302047/adding-allowdiskuse-parameter-to-db-collection-aggregate-query-using-mongoid

+1

+1

+1

+1

+1
Same issue as @topac , would like to pass options to the Moped::Collection#aggregate method.
http://docs.mongodb.org/manual/reference/method/db.collection.aggregate/#db.collection.aggregate (see the option cursor)

+1
would like to have a possibility to run explain on aggregate

Same here. So huge data can't even be queried from mongoid . This makes it useless.

+1

I just monkeypatched it in a Rails initializer to work around this:
# config/initializers/moped_aggregate.rb
require "moped"

if !defined?(Moped) || Gem::Version.new(Moped::VERSION) > Gem::Version.new('2.0.7')
  raise 'Moped has been updated or removed. Please confirm that '\
        '`config/initializers/moped_aggregate.rb` is still needed.'
end

module Moped
  class Collection
    # Mongo 3.6 requires a `cursor` option be passed as part of aggregate queries.  This overrides
    # `Moped::Collection#aggregate` to include a cursor, which is not provided by Moped otherwise.
    #
    # Per the [MongoDB documentation](https://docs.mongodb.com/manual/reference/command/aggregate/):
    #
    #   Changed in version 3.6: MongoDB 3.6 removes the use of `aggregate` command *without* the `cursor` option unless
    #   the command includes the `explain` option. Unless you include the `explain` option, you must specify the
    #   `cursor` option.
    #
    #   To indicate a cursor with the default batch size, specify `cursor: {}`.
    #
    #   To indicate a cursor with a non-default batch size, use `cursor: { batchSize: <num> }`.
    #
    def aggregate(*pipeline)
      # Ordering of keys apparently matters to Mongo -- `aggregate` has to come before `cursor` here.
      extract_result(session.command(aggregate: name, pipeline: pipeline.flatten, cursor: {}))
    end

    private

    def extract_result(response)
      response.key?("cursor") ? response["cursor"]["firstBatch"] : response["result"]
    end
  end
end


argument-parsing section

It seems that it tries to parse the arguments using a for loop with positional parameters (${!i}). However, this isn't correctly iterating through arguments because it doesn't handle paired arguments (e.g., -c followed by country).

Thank you for this. I apologize for the delayed response. Still dealing with internet availability issues.
From what I can tell this is more in line with best practices than the "creative" way I handled it. Also, thanks for adding the the missing error handling for '-c' without an argument. The big difference is I didin't shift the arguments out, I just iterated through them in place. I handled the argument after '-c' like this:
j=$((i+1)) # when argument at position i is '-c' we assign the next argument (i+1) to local variable 'j'

However, it's called "best practices" for a reason. I will update this.


Is it possible to have listCollections with option to list only missing documents?

Suppose there is 100000 documents in collection and there was 10 missing documents with subcollection we need to handle, it would be more practical to list only those 10 docs instead of going through all 100000 docs for just 10
So if it possible please expose some API to handle this scenario

Hi! This is currently not supported by our backends. We hope that we can alleviate some of your concerns with improvements that we are planning for our Query API, but since most of the development here is in the early stages, I don't have much to share at this point.
Sorry that I don't have better news for you.


method result is not logged

Seems to me the most interesting information is missing

I solved this to my satisfaction. Check out the PR, or follow my notes at the top of the readme:
https://github.com/Roustalski/rich-logger-decorator/blob/master/README.md


Add support for choosing branch

Closes #211
Count lines from a specific branch by using the ?branch= query string. If ?branch= is not specified, the default HEAD branch will be used.
For example,
[![Master](https://tokei-rs.onrender.com/b1/github/mazznoer/csscolorparser-rs?branch=Master)](https://github.com/mazznoer/csscolorparser-rs)

Live Demo
Repo: https://github.com/mazznoer/csscolorparser-rs

Issues
Currently more prone to 504 Gateway Timeouts on GitHub. Could be affected by the speed limitations of the free tier of Render I'm using?

Thank you for your PR!


Heads up about color dependency

I haven't actually tested this in your repo (sorry, fairly busy), but independently I found that using the color dependency in the Tailwind config seems to interfere with Tailwind's ability to correctly evaluate arbitrary color-values.
Specifically, I found that calling the color() function on a named CSS color—dodgerblue, say—would cause classes like text-[dodgerblue] and bg-[dodgerblue] to return invalid rgb syntax (just for named CSS colors that I called color() on). I imagine there's some shared-dependency mutation thing going on.
You might want to test for this problem in your project. I ended up switching to chroma.js.

Thanks for opening the issue! I appreciate you looking out for me (I had no idea this could be a problem with color().
The good news is that named colors work with this plugin (I guess the version of color that I use handles the named colors? 🤷🏼♂)
I actually happen to have an example of it being used in my personal site here.
I'll go ahead and close this since this plugin handles that case.

@RyanClementsHax
Just to clarify the problem that I encountered: it's not that color-values defined using syntax like color('dodgerblue') weren't working, but rather that any named CSS-color I called with color() could no longer be successfully used in a Tailwind arbitrary-value class.
So for example, if I called color('dodgerblue') in my Tailwind config (without even doing anything with the returned value!), then arbitrary-value utility-classes like text-[dodgerblue] and bg-[dodgerblue] would subsequently fail.
To test if this is a problem in your project, you'd want to call color('dodgerblue') somewhere in your Tailwind config, and then see what happens when you try using the text-[dodgerblue] utility-class in a component.
Cheers


3D pH pickup for pkg/DIC calcite saturation

What changes does this PR introduce?
Read and write a pickup for 3D pH field for use when #define DIC_CALCITE_SAT
What is the current behaviour?
3D pH is initialized from a first guess cold start each time, requiring iterations of the carbonate solver over the full model domain.
What is the new behaviour
A new pickup file
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:
Moved some 3D silicate initialization from S/R DIC_SURFFORCING_INIT to S/R DIC_INI_FORCING.
Suggested addition to tag-index
o 3D pH pickup for calcite saturation calculation

@mjlosch Thanks for the comments.
@seamanticscience I would suggest that we check together few things here and see what is the best way to finish this PR. Will email you to check when you are available. In the mean time, could wait a little bit before making new changes.

@jm-c I made a few changes, but I will hold off committing them until we talk next week.

@seamanticscience After we chat a bit about this PR, I took a look at how to make a single dic pickup file and realized that we would need to make some changes to the initialization routines (in line with what @mjlosch suggested):
If we want the 3D pH to be initialized outside dic_surfforcing_init.F (e.g., a more logical place would be in dic_ini_forcing.F or dic_init_varia.F), we cannot keep the call to DIC_READ_PICKUP there.
I could make these changes (i.e., initialization + single pickup file) in this PR. My current preference would be to call all dic initialization S/R from dic_init_varia.F instead of from gchem_init_vari.F).
However, we could also decide to have a second (short) PR with your first commit
(git hash: c062a96): "Fix up calcite dissolution code, with bugfix in Keir rates H/T @jahn"
which is independent of the 3D pH restart. There is also an inconsistent use of externForcingCycle + externForcingPeriod (in dic_surfforcing_init.F) vs DIC_forcingCycle + DIC_forcingPeriod (in dic_fields_load.F) that could also be fixed in this short PR (or in this PR).
@seamanticscience what do you think ?

@jm-c OK, let's do a bugfix P/R and then tackle the broader issues of pkg/dic restarts in a separate P/R.

Will keep this PR open but not work on it since:

PR #759 contains the fix/improvement for carbonate dissolution (the first commit in this PR branch), so it is not needed here anymore.
the cleaning and reordering of pkg/dic initialisation (from PR #757) will facilitate the implementation of 3-D pH pickup,
so that it would be better to wait for 757 to be merged-in before revisiting this PR changes. At that time, could decide to
finish this PR (after merging updates) or move most of the changes here to a new PR.

Picking up from where @jm-c left off from #757

Ok, so I think this is working! I can:

Successfully initiate a run using a pickup_dic file with only pH (surface) read in, so pH3D is initialized internally;
Successfully write pickup_dic files with pH3D; and
Successfully pick up a run with 3D pH.

For the last point I cobbled together restart tests for the so_biogeo_box example: I ran the caSat0 and caSat3 experiments for 5 timesteps to generate pickups and used testreport to restart the runs for an additional 5 timesteps, comparing the results to the last 5 timesteps of the original output in the results directory (by manually deleting the first 5 timesteps in the text files). caSat0 uses the default pH solver and caSat3 uses the SolveSAPHE routines. I can upload these files if needed.

Y Y Y Y 10 16 16 16 16 16 16 16 16 16 16 14 16 16 16 14 16 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 pass  so_box_biogeo
Y Y Y Y 10 16 16 16 16 16 16 16 16 16 16 14 16 16 16 14 16 16 11 16>12<16 16 16 11 16 16 16 16 16 16 16 16 16 16 16 16 pass  so_box_biogeo.caSat0
Y Y Y Y 10 16 16 16 16 16 16 16 16 16 16 14 16 14 16 14 14 16 16 16>16<16 16 16 16 16 16 16 16 14 16 16 16 16 16 16 16 pass  so_box_biogeo.caSat3
Y Y Y Y 10 16 16 16 16 16 16 16 16 16 16 14 16 16 16 14 16 16 16 16>16<16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 pass  so_box_biogeo.saphe

The SolveSAPHE pH scheme is really accurate (test so_box_biogeo.caSat3), whereas the default pH solver (test so_box_biogeo.caSat0) is slightly less accurate, but still does an acceptable job, judging by the "pass" it received.

@seamanticscience Thanks for finishing this. I will take a look in the next few days and let you know what I find,

With the latest fix, the test "so_box_biogeo.caSat0" is now "passing" (12 digits) whereas it was failing before (7 digits) on my Linux Fedora laptop:

latest:
Y Y Y Y 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 11 16>12<16 16 16 11 16 16 16 16 16 16 16 16 16 16 16 16 pass  so_box_biogeo.caSat0
previous:
Y Y Y Y 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16  7 11> 7<16 16 12  7 16 16 16 16 16 16 16 16 16 16 16 16 FAIL  so_box_biogeo.caSat0

And was all 16 with current master branch.
Curiously, I don't see any noticable changes for "so_box_biogeo.caSat3" test (when compared with master branch), nothing in the ptracers monitor and tiny diff in dynStDiag.0000000000.txt.

The SolveSAPHE pH is really stable, but it internally iterates so perhaps it's not surprising that only a handful of CALC_PCO2_APPROX iterations does not perform as well. Perhaps if you try increasing nIterCO3 you might get more decimal places?
If you're happy with the restart tests, is that everything completed?

@seamanticscience I made a little adjustment to always call CALCITE_SATURATION at the first time-step (I think it's safer this way). Will generate (and commit) a new refenence output for ""so_box_biogeo.caSat0" test soon.

From my side, everything is good here,  run the restart test ("do_tst+2+2")  and all good, so could think of merging this PR soon.
@seamanticscience Do you want to add something here ? and if not, could you do a last check and confirm that it's good for merging ?

LGTM!

@seamanticscience Thanks for this contribution. Will merge this PR soon (tomorrow or Friday).


Using SDK in frontend : "Can't resolve 'fs'"

Describe the bug
SDK imports utils which uses the node module fs. This causes some issues for frontend integrations.
Current solution is to put the following in package.json:
  "browser": {
    "fs": false,
    "path": false,
    "os": false
  },

We need to see if we can shake this dependency from the SDK.

closing as dupe


Fix page title

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Hi @aliozgur, thanks for the pull request! Can you sign the CLA and then I'll review it?


"Butoiu de Sus", "Măgura", "Valea Dadei" are listed in the drop-down menu

Description:
When user writes ”Butoiu de Sus”, "Măgura" and "Valea Dadei" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Butoiu de Sus"

Expected results
The location appears in the drop-down menu as "Sat Butoiu de Sus, DÂMBOVIȚA (Hulubești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Măgura"

Expected results
The location appears in the drop-down menu as "Sat Măgura, DÂMBOVIȚA (Hulubești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Valea Dadei"

Expected results
The location appears in the drop-down menu as "Sat Valea Dadei, DÂMBOVIȚA (Hulubești)".


Optimise inference time

Thanks for the great work. you are all doing a great contribution to community.
However, is there any idea to reduce inference time, thanks,
Regards

报一下你现在硬件配置、视频尺寸和推理时间. 也许我可以给你一些建议。

Hi @zhangziliang04
I use 1 GPU Tesla T4 16GB, video Avatar size 832x960 (width, height).
To generate 8s video, it took 390 second in total.
Any idea to improve this, thanks

这个项目，默认有一个缓冲机制，第二次同一个驱动视频，会服用第一次训练的结果，具体对应1-4步骤，你可以看具体看一下。

Thanks understood, Step 6 always took most of inference time, any idea to speed it up, regards.

Yes, the Lip Synthesis (step 6) is taking 2 min for a 30s audio for 360x640 resolution video on an RTX 4090 24GB

Thanks understood, Step 6 always took most of inference time, any idea to speed it up, regards.

Did you find any solution for Speed ?

@KartavyaBagga  did you find yet?  same question for @truongnhat-ryo  @zhangziliang04 , how to make it faster ??

前面几步是有缓存，第二次用统一形象会有节约时间
但是，第六步占总时间的70～80%左右，是优化的关键
还需要多研究研究这步


On iOS MaterialCard doesn't show properly when has isvisible="false" elements inside

Sorry for my bad english, I tried to explain the best I can do it.
Describe the bug
On iOS, MaterialCard doesn't show properly when has isvisible="false" elements inside. In the first "charge" of the view shows irregular height for the cards.
To Reproduce
Steps to reproduce the behavior:

Create ListView with MaterialCards
Set some random labels with property "isVisible" with binding parameter in the ViewModel
Some of these binding parameters in false state

Expected behavior
show entire card with isvisible labels inside.
Screenshots

Smartphone (please complete the following information):

Device:  iPhone6s Plus
OS: iOS 12.1.4
Version Nuget XF.Material 1.4.1

Did you solve this issue?


Dynamic queries using a default FHIR module

Thanks @rcrichton this is looking great! just have some minor comments, The main one is the RelatedPerson module which we can remove, but is depended upon by doc-manifest. You've mentioned a solution to the identifier object/array issue which was the other one needing to be fixed. But overall looking awesome!


Decouple from Django/Flask

this looks like an interesting improvement to celery , but the django/flask requirement is annoyingly limiting.
since the only thing you rely on from these packages is their cache, have you considered using a standalone caching library like Dogpile ( https://pypi.python.org/pypi/dogpile.cache ) ?

@winhamwr I need to get JobTastic to use a separate cache from the Django default one because we want to switch our default cache from shared redis to local redis for performance reasons. This seems like the best approach to fixing it. Are you still interested in a pull request?

One problem with using the Celery Result Backend(s) as the cache is that the Result Backend doesn't expose the expiry/timeout as a parameter to set() - it is set for the Backend instance as a whole and read from self.expires, and you can't use the underlying client very easily because of the different syntax that the Memcache and Redis clients use.

Are you still interested in a pull request?

Very much so, yes.
Does the jobtastic_cache API I proposed seem like it would meet your use case?

Yes, perfectly - if I can work out how to use the Celery Backends with a custom expiry on each set() command.

After examining the Celery Backends code, I have concluded that:

We can't use the Celery Backend without changing the Celery to allow the expiry to be passed to set() as a parameter
Even if we could get that change accepted upstream, it would make JobTastic dependent on very recent Celery, and would probably inconvenience a lot of existing users.
Therefore reusing the Celery backends, however attractive, is not going to work.

I think our next best alternative is to create a jobtastic.backends.BaseBackend that defines an API suitable for use by JobTastic (get/set/delete/lock (as a context manager)) and some specific implementations (Django Cache or Flask with Redis or Memcache) and a way to set the correct one using the Celery app.conf.
That way, we can deliver the existing functionality with a better API to allow users to provide a custom cache class if necessary.

@winhamwr given that we can't use the Celery backends directly because we can't control the timeout on the set, I have create a new cache module. It contains get_cache which attempts to find a cache from the Celery app.conf - using a JOBTASTIC_CACHE setting if it exists but falling back to the Django default cache if Django is installed, or the default Celery backend if Werkzeug is installed and the Celery default backend is using Memcached or Redis. This is roughly the same as the existing functionality (except that Werkzeug + Redis should work).
Because the JOBTASTIC_CACHE setting can be a subclass of jobtastic.cache.BaseCache it should be easy for users to add new cache providers.
There is also a jobtastic.cache.WrappedCache which should be capable of wrapping any cache provider that supports get/set (with timeout)/delete and either an atomic add or a distributed lock.
As part of this I have incorporated the locking mechanism described in #6.
I also think it would help with #59, although if Task-level cache busting is required then the solution there is preferable and could also be incorporated.
My initial code is at https://github.com/kimetrica/jobtastic/commit/8fe51330041d0b3d6e1eedcccfd70abeea452d20 - please can you take a look and give some feedback. I'll look at tests, etc. once I know you are happy with the general approach.

@rhunwicks your approach sounds perfect. A great combination of backwards-compatibility and forward flexibility. I also like the movement of the locking logic to the cache module. :+1: from me

@winhamwr should all tox tests pass? Even running in @master I get errors on all the py27-celery31 test runs, regardless of the Django version.

should all tox tests pass?

Only the combinations specified in .travis.yml should pass, but I think that should include  py27-celery31.
At this point, there's no reason to keep supporting all of the super-old versions of Django and celery and I'm sorry that you've had to deal with that. I'll see if I can throw together a PR to drop support for py2.6 and Django before 1.8 (the current LTS).

Looks like there are some non-obvious problems with the build. I'll have to take another run at fixing it tomorrow. I have #62 going as a PR to drop support for all of the old versions.

I'd prefer to leave support for Django 1.6 / Python 2.7 for the time being - and I have coded this issue such that  both 1.6 and 1.7+ should work without any deprecation warning.

I'd prefer to leave support for Django 1.6 / Python 2.7 for the time being

That's enough to convince me. Is dropping support for Celery earlier than 3.1 acceptable?

If you merge master in to your branch, you should now have a passing tox run. Sorry about that.

@winhamwr I've merged master into my branch and all tox runs pass.
Do you have any ideas on how to write tests to check that the cache config is being picked up?
I have tried to write tests with CELERY_ALWAYS_EAGER=False so that I can inspect the cache to see that the default cache is empty, and the cache specified by JOBTASTIC_CACHE contains the thundering herd key, but doing so leaves stuff in the cache and makes the other tests fail.
Because of the way tox runs I don't seem to be able to drop into pdb during a test run. Can you give me a pointer on how to run the tests outside of tox.

As an example, here is a new file jobtastic/tests/test_settings.py that should check that the Django default cache is used by default, and that the JOBTASTIC_CACHE setting can be used to override the cache used.
from __future__ import print_function
from unittest import skipIf
from celery import Celery, states
import django
from django.conf import settings
from django.core.cache import caches
from django.test import TestCase, override_settings
from .test_broker_fallbacks import ParrotTask

@skipIf(django.VERSION < (1, 7),
        "Django < 1.7 doesn't support django.core.cache.caches")
class DjangoSettingsTestCase(TestCase):

    def setUp(self):
        self.task = ParrotTask
        self.kwargs = {'result': 42}
        self.cache_key = self.task._get_cache_key(**self.kwargs)

    def test_sanity(self):
        # The task actually runs
        with self.settings(CELERY_ALWAYS_EAGER=True):
            async_task = self.task.delay(result=1)
        self.assertEqual(async_task.status, states.SUCCESS)
        self.assertEqual(async_task.result, 1)

    @override_settings(CELERY_ALWAYS_EAGER=False)
    def test_default_django_cache(self):
        app = Celery()
        app.config_from_object(settings)
        ParrotTask.bind(app)
        app.finalize()
        async_task = self.task.delay(**self.kwargs)
        self.assertEqual(async_task.status, states.PENDING)
        self.assertTrue('lock:%s' % self.cache_key in caches['default'])

    @override_settings(CELERY_ALWAYS_EAGER=False,
                       JOBTASTIC_CACHE='shared',
                       CACHES = {'default': {'BACKEND': 'django.core.cache.backends.locmem.LocMemCache',
                                             'LOCATION': 'default'},
                                 'shared': {'BACKEND': 'django.core.cache.backends.locmem.LocMemCache',
                                             'LOCATION': 'shared'}})
    def test_custom_django_cache(self):
        app = Celery()
        app.config_from_object(settings)
        ParrotTask.bind(app)
        app.finalize()
        async_task = self.task.delay(**self.kwargs)
        self.assertEqual(async_task.status, states.PENDING)
        self.assertTrue('lock:%s' % self.cache_key in caches['shared'])
        self.assertTrue('lock:%s' % self.cache_key not in caches['default'])

If I run this test file against current master, I am expecting the test for the JOBTASTIC_CACHE setting to fail (because that code isn't in master), but everything else should work.
If I run this code manually, it works:
source .tox/py35-django1.8.X-celery3.1.X/bin/activate
cd test_projects/django/
DJANGO_SETTINGS_MODULE=testproj.settings nosetests ../../jobtastic/tests  --verbosity=3

...

FAIL: test_custom_django_cache (jobtastic.tests.test_settings.DjangoSettingsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/.tox/py27-django1.8.X-celery3.1.X/local/lib/python2.7/site-packages/django/test/utils.py", line 196, in inner
    return test_func(*args, **kwargs)
  File "/home/roger/git/jobtastic/jobtastic/tests/test_settings.py", line 50, in test_custom_django_cache
    self.assertTrue('lock:%s' % self.cache_key in caches['shared'])
AssertionError: False is not true

...

Ran 23 tests in 3.997s

FAILED (failures=1)

But if I run it using tox it all fails:
tox -e py27-django1.8.X-celery3.1.XGLOB sdist-make: /home/roger/git/jobtastic/setup.py
py27-django1.8.X-celery3.1.X inst-nodeps: /home/roger/git/jobtastic/.tox/dist/jobtastic-1.0.0a1.zip
py27-django1.8.X-celery3.1.X installed: amqp==1.4.9,anyjson==0.3.3,billiard==<IP_ADDRESS>,celery==3.1.23,Django==1.8.13,django-nose==1.4.3,django-picklefield==0.3.1,funcsigs==1.0.2,jobtastic==1.0.0a1,kombu==3.0.35,linecache2==1.0.0,mock==2.0.0,nose==1.3.7,pbr==1.10.0,psutil==3.4.2,pytz==2016.6.1,six==1.10.0,traceback2==1.4.0,unittest2==1.1.0
py27-django1.8.X-celery3.1.X runtests: PYTHONHASHSEED='869036002'
py27-django1.8.X-celery3.1.X runtests: commands[0] | /home/roger/git/jobtastic/.tox/py27-django1.8.X-celery3.1.X/bin/python setup.py test
running test
nosetests /home/roger/git/jobtastic/test_projects/django/testproj/../../../jobtastic/tests  --verbosity=1
Creating test database for alias 'default'...
......F...FFFFFF........
======================================================================
FAIL: test_custom_django_cache (jobtastic.tests.test_settings.DjangoSettingsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/.tox/py27-django1.8.X-celery3.1.X/local/lib/python2.7/site-packages/django/test/utils.py", line 196, in inner
    return test_func(*args, **kwargs)
  File "/home/roger/git/jobtastic/jobtastic/tests/test_settings.py", line 50, in test_custom_django_cache
    self.assertTrue('lock:%s' % self.cache_key in caches['shared'])
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:a1d0c6e83f027327d8461063f4ac58a6
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_eager_bad_channel (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 148, in test_delay_or_eager_bad_channel
    self.assertEqual(async_task.status, states.SUCCESS)
AssertionError: 'PENDING' != 'SUCCESS'
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:02e74f10e0327ad868d138f2b4fdd6f0
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_eager_bad_connection (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 142, in test_delay_or_eager_bad_connection
    self.assertEqual(async_task.status, states.SUCCESS)
AssertionError: 'PENDING' != 'SUCCESS'
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:02e74f10e0327ad868d138f2b4fdd6f0
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_fail_bad_channel (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/.tox/py27-django1.8.X-celery3.1.X/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 125, in test_delay_or_fail_bad_channel
    self.assertEqual(async_task.status, states.FAILURE)
AssertionError: 'PENDING' != 'FAILURE'
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:c4ca4238a0b923820dcc509a6f75849b
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_fail_bad_connection (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/.tox/py27-django1.8.X-celery3.1.X/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 119, in test_delay_or_fail_bad_connection
    self.assertEqual(async_task.status, states.FAILURE)
AssertionError: 'PENDING' != 'FAILURE'
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:c4ca4238a0b923820dcc509a6f75849b
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_run_bad_channel (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 136, in test_delay_or_run_bad_channel
    self.assertTrue(was_fallback)
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:02e74f10e0327ad868d138f2b4fdd6f0
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: test_delay_or_run_bad_connection (jobtastic.tests.test_broker_fallbacks.BrokenBrokerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/roger/git/jobtastic/jobtastic/tests/test_broker_fallbacks.py", line 130, in test_delay_or_run_bad_connection
    self.assertTrue(was_fallback)
AssertionError: False is not true
-------------------- >> begin captured logging << --------------------
root: INFO: Current status: PENDING
root: INFO: Setting herd-avoidance cache for task: jobtastic.tests.test_broker_fallbacks.ParrotTask:02e74f10e0327ad868d138f2b4fdd6f0
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 24 tests in 0.160s

FAILED (failures=7)
Destroying test database for alias 'default'...

doing so leaves stuff in the cache and makes the other tests fail.

Both of these options are kind of hacky, but probably worth doing:

We could write a setUp/tearDown methods to explicitly clear the cache
We could also use a per-test custom cache prefix

Another hacky way to change the settings might be to define different testproj.settings_foo modules (e.g. settings_with_custom_django_cache.py), then modify the testrunner to switch between different DJANGO_SETTINGS_MODULE's. This would be the most hacky of the 3 options, though, and I hope we can avoid it.

What I can't understand is why it works when I run the tests by activating the virtualenv manually and then running the nosetests command - but doesn't work when I run tox -e py27-django1.8.X-celery3.1.X.
What's different about running through tox?

What's different about running through tox?

Maybe it's some of the other requirements that tox installs/loads? Perhaps in test.txt?

It was to do with state being remembered in ParrotTask which was imported from another module. I switched to defining the task in setUp() and it all works. I have created a PR,

Thanks so much @rhunwicks! We just merged in #63 and cut a Jobtastic 1.0 release.


TF: prevent model compilation

Hi!
I ran into an issue with N2V: since it uses a custom loss, loading the model using tf.keras.models.load_model throws an error when the model has been compiled and saved as a SavedModel. The same method is used when validating a SaveModel in bioimageio.core.
One way around this is to pass compile=False (see that line), avoiding the compilation of the model after loading. If I am not mistaken, the compilation is only required for training (compiling loss, metrics, optimizer etc.), it is not needed for the purpose of the bioimage.io model validation (inference).
The model can still be loaded and compiled by users provided they have access to the custom methods. I tested that with N2V and it solves the error.
Happy to know more if there are things that I overlooked!

Hey! It's the same with some of the ZeroCostDL4Mic notebooks. So yes, you would need to export it without compiling it, and then, when loading it into the N2V framework, you could also load the weights only into a compiled architecture.

Hey! It's the same with some of the ZeroCostDL4Mic notebooks. So yes, you would need to export it without compiling it, and then, when loading it into the N2V framework, you could also load the weights only into a compiled architecture.

Yes, within the n2v that's also not really an issue because can we can load it with custom_objects.
But since there is no need to compile the model to run the inference for the model validation in bioimage.io (as far as I can tell), I thought it would make more sense for the model validation to avoid this error, hence the PR. Although this is an edge case, that lifts slightly the constraints on the uploaders' side.
Now, maybe that's not a good choice because it would then force users/consumers to also load with the compile=False parameter. In which case, maybe there should also be a TF example for saving models (e.g. here) to help people avoid the issue?
Finally, the CI seems to fail on my PR during dependency installation for TF and TF-legacy. Any clue why? Out of curiosity. :)
Feel free to close the PR :)

I am not familiar enough with keras to see the implications of this right away. It would be good to have the CI going over this, since this could potentially be an impactful change. Unfortunately our legacy tf 1 environment is not working again...
Maybe it's time to drop that one in favor of a maintainable tf 2 one?? cc @FynnBe

While not too familiar with keras, I see no issue with adding the compile=False flag on loading 👍
CI should pass though, which looks unrealdated (somewhow in the tf 3.7 env py 3.10 is present...).

relates to #319


Hello! Left and right edit scrolling is out of sync.

For details, please see:
Hello! Left and right edit scrolling is out of sync.
https://github.com/stateful/vscode-runme/issues/768
VSCode 1.81
Windows10

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

@mjbvz Hello! I submitted this issue to the extension team, the extension team does not have permission to resolve this issue and directed this issue to you, please read the details carefully.
related extension
runme

Hey @mjbvz, this issue might need further attention.
@zhouxinghong, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@mjbvz
Hello! Left and right edit scrolling is out of sync.
Hello! Left and right edit scrolling is out of sync. Hope you can fix this in the next version. Thank you very much!
Windows10
runme latest version

Runme Markdown left and right editing scrolling cannot be synchronized
https://github.com/stateful/vscode-runme/assets/54253524/36369486-b7b1-466f-a142-267d86fb0745
VSCode Markdown left and right editing scroll synchronization
https://github.com/stateful/vscode-runme/assets/54253524/f93041b9-cb5b-4812-b39a-890dbc5a5217


Anyone used Plop to help generate useful git commit messages?

Was considering writing a small script to help ensure our devs (including myself) always include pertinent information in their commit messages in an expected format. Has anyone used plop for something like this, as far as you know?

I have not heard of anyone do that, but it sounds very interesting! I suppose you could use a childprocess to then trigger the git commands from a custom action function. If you end up doing this, please let me know how it goes! sounds really cool :-)


 : Adding test for timer runThisEvery.

Checklist

[ ] New Extension
[x] New Test
[ ] Changed more than one extension, but all changes are related
[x] Trivial change (doesn't require changelog)

          2 Warnings

:warning:
EZSwiftExtensionsTests/TimerTests.swift#L36: result of call to ‘runThisEvery(seconds:handler:)’ is unused
        Timer.runThisEvery(seconds: 1) { (timer) -> Void in

:warning:
EZSwiftExtensionsTests/TimerTests.swift#L36: result of call to ‘runThisEvery(seconds:handler:)’ is unused
        Timer.runThisEvery(seconds: 1) { (timer) -> Void in

          2 Messages

:book:
Executed 154 tests, with 0 failures (0 unexpected) in 4.400 (4.652) seconds

:book:
Executed 142 tests, with 0 failures (0 unexpected) in 4.520 (4.844) seconds

  Generated by :no_entry_sign: danger

@Khalian  you have to use this:  _ = Timer.runThis.....

Current coverage is 37.72% (diff: 100%)

Merging #328 into master will increase coverage by 0.23%

@@             master       #328   diff @@
==========================================
  Files            46         46
  Lines          2097       2097
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            786        791     +5
+ Misses         1311       1306     -5
  Partials          0          0

Powered by Codecov. Last update bbfbfa0...37ad9e8


Compatibility with MotherDuck connection string

I see that this current repo works with local duckdb server. Is there on the roadmap any plans for a connection to a duckdb server that is hosted on Motherduck using the connection string?

does there exist a connection string on Motherduck?

Yes, there is a share option that I saw that when clicked, would give a connection url.

have you successfully attached it to your local DuckDB?
I tried on My mac m2, got an error
Running query in 'duckdb:///'
(duckdb.InvalidInputException) Invalid Input Error: Initialization function "motherduck_init" from file "/Users/m2max/.duckdb/extensions/v0.8.1/osx_arm64/motherduck.duckdb_extension" threw an exception: "IO Error: Failed to download "http://api.motherduck.com/extension_version". Status code "403": Success" [SQL: ATTACH 'md:_share/my_db/<string_of_generated_numbers_and_digits>'] (Background on this error at: https://sqlalche.me/e/14/f405)

@williamong68  here is a Chinese article about how to connect with MotherDuck through duckdb_fdw


Need description of configuring announcement.

Looking for description on configuring announcement.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 23680488-ddfe-6f27-da45-e46392a014ed
Version Independent ID: 265c61c6-2e9e-0e61-a716-040cbb51e594
Content: Response Groups Group
Content Source: Skype/SfbServer/help-topics/help-lscp/response-groups-group.md
Product: skype-for-business-itpro
GitHub Login: @kenwith
Microsoft Alias: kenwith

Thank you for this feedback and for contributing to the wellness of the content! This is a good idea and we have added it into our backlog for triage and prioritization

@tseward Is investigating this.

Hi
You can find that information here https://docs.microsoft.com/en-us/skypeforbusiness/deploy/deploy-enterprise-voice/create-an-announcement Thanks


fix: Update react-virtual with patch to support React 18

Description
This PR introduces a temporary workaround to address the compatibility issue with React 18 in the react-virtual package, a dependency of @cloudscape-design/components. The core of the issue is that react-virtual specifies peer dependencies that do not include React 18, leading to an unmet peer dependency error in environments using the latest version of React:
└─┬ @cloudscape-design/components 3.0.0
  └─┬ react-virtual 2.10.4
    └── ✕ unmet peer<EMAIL_ADDRESS>|| ^17.0.0": found 18.2.0

Given that the library maintainer has yet to release a version of react-virtual with official support for React 18 (TanStack/virtual#278, TanStack/virtual#568), this PR implements a patch as a temporary measure.
Changes:
Patch File Creation (react-virtual.patch): A new patch file has been created that modifies the package.json of react-virtual to include || ^18.0.0 in the peerDependencies section for React. This allows the library to recognize React 18 as a valid peer dependency.
Patch Diff:
diff -ruN node_modules/react-virtual-original/package.json node_modules/react-virtual/package.json
--- node_modules/react-virtual-original/package.json	2023-11-22 15:29:57
+++ node_modules/react-virtual/package.json	2023-11-22 15:35:43
@@ -44,7 +44,7 @@
    "@reach/observe-rect": "^1.1.0"
  },
  "peerDependencies": {
-    "react": "^16.6.3 || ^17.0.0"
+    "react": "^16.6.3 || ^17.0.0 || ^18.0.0"
  },
  "devDependencies": {
    "@babel/core": "^7.8.6",

Modification to package.json: The project's package.json has been updated to include "postinstall": "patch-package". This addition ensures the patch is applied automatically post-installation.
New Dependency (patch-package): The patch-package package has been added to the project. This package allows us to apply patches to node modules easily, facilitating this temporary workaround.
Rationale:
Implementing this patch allows us to continue using @cloudscape-design/components with React 18 without waiting for an official update from react-virtual. It's a straightforward, low-risk solution to maintain compatibility and ensure smooth project progress.
Next Steps:
We will monitor the upstream react-virtual repository for an official release that includes React 18 support. Once available, we can revert this patch and update the dependency accordingly.
Related links, issue #, if available: n/a
How has this been tested?

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hello, just to close up on this thread, the proposed change does not fix anything. It updates our own PR build process, but changes nothing in the output artifacts, because your build pulls the original react-virtual instance from NPM registry in any way.
To fix installation issues you can use npm install --force to resolve peer dependencies issue. This is how we do that in our own builds:
https://github.com/cloudscape-design/actions/blob/eec641612542360339a84cef3cd578c698b80e0b/.github/workflows/release.yml#L33


Retrieving entites that do not exist returns blank but valid entity

Bug description
When retrieving entities, if entity does not exist, an empty entity with ID of 0 is returned.
Expected behaviour
An exception should be thrown, or null should be returned.
Additional info
This happens due to WOLF protocol returning top level success status code, but the entity in a dictionary has "code" with error code instead of actual properties. JSON.Net doesn't see this as an error, and just deserializes that entity even though data is missing.

Fixed in 1d5b1e16abb7dfc72c920a00209bea0f337f859b - will be part of next release (probably a patch-only one).
Still debating whether marking user and group ID properties as required for JSON, and making JSON.Net throw exceptions instead.

Fixed in 1d5b1e16abb7dfc72c920a00209bea0f337f859b - will be part of next release (probably a patch-only one).
Still debating whether marking user and group ID properties as required for JSON, and making JSON.Net throw exceptions instead.

Fixed in v1.1.1 - PR #15

Fixed in v1.1.1 - PR #15


adding random quote js,html and css files

Hey @parth93QA , Please make your project in the directory: ProjectName/USERNAME
, And give me PR again.
Thank You! :)

closing and adding new PR with changes


chore: add Zulip emoji merge delegate workflow

Quick note: you will need to document the new script in scripts/README.md; this is why the lint-style job is failing.

Let's try this!
bors merge


feat: Upgrade CIM to 6.0.0

Added changes based on CIM 6.0.0 and CIM 5.3.2 changes
Added Session ID in Authentication Model: https://cd.splunkdev.com/EnterpriseSecurity/sa-commoninformationmodel/-/merge_requests/545
Signature field description change in Intrusion Detection Model: https://cd.splunkdev.com/EnterpriseSecurity/sa-commoninformationmodel/-/merge_requests/542
Protocol Version description change in Network Traffic Model: https://cd.splunkdev.com/EnterpriseSecurity/sa-commoninformationmodel/-/merge_requests/544
Power field description change in Performance Model: https://cd.splunkdev.com/EnterpriseSecurity/sa-commoninformationmodel/-/merge_requests/543

:tada: This PR is included in version 5.4.0-beta.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


question

想问一下代码啥时候能开源呢？

I'm planing to release the code at November.

hi jinghao!
非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?
best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXSQ7Y#issuecomment-544155775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBPOFPBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA
.

Hi,
Sorry for my words. I WAS orginally planning to release the code at the end of November, but my tutor later told me that I shall not release it now. The whole framework is relatively straitforward though, you may try to implement yourself. If you have any questions, I'm very happy to help you with it.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date:  Nov 30, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject:  Re: [shallowtoil/DROL] question (#1)
hi jinghao!
非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?
best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXSQ7Y#issuecomment-544155775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBPOFPBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

我不是很清楚你在你的算法里面的裁剪方式，因为atom的裁剪函数(sample_patch)和pysot的裁剪函数（get_subwindows）不一样的，你是怎么选择的。另外如果方便的话可否加我微信聊(微信号:
wxid_p06nz8ojbb3o22 )，不方便也没事的。我就在信上面请教一下了。
在 2019年12月2日星期一，Jinghao Zhou<EMAIL_ADDRESS>写道：

Hi,
Sorry for my words. I WAS orginally planning to release the code at the
end of November, but my tutor later told me that I shall not release it
now. The whole framework is relatively straitforward though, you may try to
implement yourself. If you have any questions, I'm very happy to help you
with it.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Nov 30, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [shallowtoil/DROL] question (#1)
hi jinghao!
非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?
best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXSQ7Y#issuecomment-544155775>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AKF2SBPOFPBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBPRLRN4IEI4N34DCZLQWRV4LA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFR7DGI#issuecomment-560198041,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBOQMWLMTPGLQMTZ7BTQWRV4LANCNFSM4JBFDSIA
.

我不是很清楚你在你的算法里面的裁剪方式，因为atom的裁剪函数(sample_patch)和pysot的裁剪函数（get_subwindows）
不一样的，你是怎么选择的。另外如果方便的话可否加我微信聊，不方便也没事的(微信号:wxid_p06nz8ojbb3o22)。我就在信上面请教一下。
在 2019年12月2日星期一，Jinghao Zhou<EMAIL_ADDRESS>写道：

Hi,
Sorry for my words. I WAS orginally planning to release the code at the
end of November, but my tutor later told me that I shall not release it
now. The whole framework is relatively straitforward though, you may try to
implement yourself. If you have any questions, I'm very happy to help you
with it.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Nov 30, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [shallowtoil/DROL] question (#1)
hi jinghao!
非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?
best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/shallowtoil/DROL/issues/1?email_source=
notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNF
SM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2Z
LOORPWSZGOEBXSQ7Y#issuecomment-544155775>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKF2SBPOF
PBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBPRLRN4IEI4N34DCZLQWRV4LA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFR7DGI#issuecomment-560198041,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBOQMWLMTPGLQMTZ7BTQWRV4LANCNFSM4JBFDSIA
.

Hi,
As discribed in paper, we use the 255*255 search area similar to siamese network setting as the input for online classification subnet. We do not use sample_patch in ATOM.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date:  Dec 3, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject:  Re: [shallowtoil/DROL] question (#1)
我不是很清楚你在你的算法里面的裁剪方式，因为atom的裁剪函数(sample_patch)和pysot的裁剪函数（get_subwindows）
不一样的，你是怎么选择的。另外如果方便的话可否加我微信聊，不方便也没事的(微信号:wxid_p06nz8ojbb3o22)。我就在信上面请教一下。
在 2019年12月2日星期一，Jinghao Zhou<EMAIL_ADDRESS>写道：

Hi,
Sorry for my words. I WAS orginally planning to release the code at the
end of November, but my tutor later told me that I shall not release it
now. The whole framework is relatively straitforward though, you may try to
implement yourself. If you have any questions, I'm very happy to help you
with it.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Nov 30, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [shallowtoil/DROL] question (#1)
hi jinghao!
非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?
best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/shallowtoil/DROL/issues/1?email_source=
notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNF
SM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2Z
LOORPWSZGOEBXSQ7Y#issuecomment-544155775>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKF2SBPOF
PBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBPRLRN4IEI4N34DCZLQWRV4LA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFR7DGI#issuecomment-560198041,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBOQMWLMTPGLQMTZ7BTQWRV4LANCNFSM4JBFDSIA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

hi jinghao，
另外在模板更新那一块儿，你的z’ 选择是根据下面的公式(8)来的，其中的
[image: image.png][image:
image.png]我不是很理解，我的理解是代表第N帧中用Zs作为模板和第N帧中的搜索区域卷积得到的最大的score得分，和相应的边框，还有一个Z1就是用第一帧作为模板和第N帧中的搜索区域做卷积得到的最大的score和相应的边框，那在跟踪部分初始化参数之后在def
track()这个函数里面岂不是要算两次分类得分和相应的回归得分，一次是第一帧的模板和第N帧搜索区域做卷积得到score和reg，还有一次是Zs和第N帧搜索区域做卷积得到score和reg？可以说一下你当时的思路吗？
[image: image.png]
期待回复！
祝好！
Jinghao Zhou<EMAIL_ADDRESS>于2019年12月4日周三 下午11:18写道：

Hi,
As discribed in paper, we use the 255*255 search area similar to siamese
network setting as the input for online classification subnet. We do not
use sample_patch in ATOM.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Dec 3, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject: Re: [shallowtoil/DROL] question (#1)
我不是很清楚你在你的算法里面的裁剪方式，因为atom的裁剪函数(sample_patch)和pysot的裁剪函数（get_subwindows）
不一样的，你是怎么选择的。另外如果方便的话可否加我微信聊，不方便也没事的(微信号:wxid_p06nz8ojbb3o22)。我就在信上面请教一下。
在 2019年12月2日星期一，Jinghao Zhou<EMAIL_ADDRESS>写道：

Hi,
Sorry for my words. I WAS orginally planning to release the code at the
end of November, but my tutor later told me that I shall not release it
now. The whole framework is relatively straitforward though, you may try
to
implement yourself. If you have any questions, I'm very happy to help
you
with it.
Regrads,
Jensen
------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Nov 30, 2019
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>

Subject: Re: [shallowtoil/DROL] question (#1)
hi jinghao!

非常感谢百忙之中能查看这封信，你的论文写的很精彩，但是在这之中我还是有些细节没法很好把握，很想研读你的代码细节，现在也已经是11月底了，是否打算在这两天开源你的代码?

best！
在 2019年10月19日星期六，Jinghao Zhou<EMAIL_ADDRESS>写道：

I'm planing to release the code at November.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/shallowtoil/DROL/issues/1?email_source=
notifications&email_token=AKF2SBORTPI3TPI7OFX6PPDQPMOCLA5CNF
SM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2Z
LOORPWSZGOEBXSQ7Y#issuecomment-544155775>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKF2SBPOF
PBNHZSWSN2YQ73QPMOCLANCNFSM4JBFDSIA>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBPRLRN4IEI4N34DCZLQWRV4LA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFR7DGI#issuecomment-560198041>,

or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AKF2SBOQMWLMTPGLQMTZ7BTQWRV4LANCNFSM4JBFDSIA>

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/shallowtoil/DROL/issues/1?email_source=notifications&email_token=AKF2SBMRGFOTC7DKN7LIFN3QW7C2ZA5CNFSM4JBFDSIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5LVJA#issuecomment-561691300,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKF2SBPFQJXBLCPYWSYYWT3QW7C2ZANCNFSM4JBFDSIA
.

The code is now available!

The code is now available!

thanks


ModuleNotFoundError

ModuleNotFoundError: No module named "'config"   on  heroku

Could you please follow the issue template to provide us with more information? It would be helpful to give more information about your environment as well as the full stack trace.

@joseGabriel06 please, provide a full traceback log.
heroku logs

Having said that, many years ago, when I was beginning in the development world, someone recommended me to read this text: http://www.catb.org/esr/faqs/smart-questions.html

-----> Installing requirements with pip
-----> $ python manage.py collectstatic --noinput
Traceback (most recent call last):
File "manage.py", line 30, in
execute_from_command_line(sys.argv)
File "/app/.heroku/python/lib/python3.6/site-packages/django/core/management/init.py", line 364, in execute_from_command_line
utility.execute()
File "/app/.heroku/python/lib/python3.6/site-packages/django/core/management/init.py", line 308, in execute
settings.INSTALLED_APPS
File "/app/.heroku/python/lib/python3.6/site-packages/django/conf/init.py", line 56, in getattr
self._setup(name)
File "/app/.heroku/python/lib/python3.6/site-packages/django/conf/init.py", line 41, in _setup
self._wrapped = Settings(settings_module)
File "/app/.heroku/python/lib/python3.6/site-packages/django/conf/init.py", line 110, in init
mod = importlib.import_module(self.SETTINGS_MODULE)
File "/app/.heroku/python/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 978, in _gcd_import
File "", line 961, in _find_and_load
File "", line 936, in _find_and_load_unlocked
File "", line 205, in _call_with_frames_removed
File "", line 978, in _gcd_import
File "", line 961, in _find_and_load
File "", line 936, in _find_and_load_unlocked
File "", line 205, in _call_with_frames_removed
File "", line 978, in _gcd_import
File "", line 961, in _find_and_load
File "", line 948, in _find_and_load_unlocked
ModuleNotFoundError: No module named "'config"
!     Error while running '$ python manage.py collectstatic --noinput'.
See traceback above for details.
You may need to update application code to resolve this error.
Or, you can disable collectstatic for this application:
$ heroku config:set DISABLE_COLLECTSTATIC=1
https://devcenter.heroku.com/articles/django-assets
!     Push rejected, failed to compile Python app.
!     Push failed

@joseGabriel06 have you made any changes to the project since its creation?

@webyneter  do not

I guess, it might have something to do with #1467. @ddiazpinto what do you think?

I'm going to check

what is the output of
heroku run ls -la

@luzfcb
total 104
drwx------  9 u38534 dyno 4096 Feb  6 19:41 .
drwxr-xr-x 15 root   root 4096 Jan 23 18:33 ..
drwx------  3 u38534 dyno 4096 Feb  6 16:41 config
-rw-------  1 u38534 dyno   26 Feb  6 16:41 CONTRIBUTORS.txt
-rw-------  1 u38534 dyno   98 Feb  6 16:41 .coveragerc
drwx------  2 u38534 dyno 4096 Feb  6 16:41 docs
-rw-------  1 u38534 dyno  485 Feb  6 16:41 .editorconfig
-rw-------  1 u38534 dyno  746 Feb  6 16:41 env.example
-rw-------  1 u38534 dyno   12 Feb  6 16:41 .gitattributes
-rw-------  1 u38534 dyno 4389 Feb  6 16:41 .gitignore
drwx------  4 u38534 dyno 4096 Feb  6 16:41 .heroku
-rw-------  1 u38534 dyno    1 Feb  6 16:41 LICENSE
-rw-------  1 u38534 dyno 1041 Feb  6 16:41 manage.py
-rw-------  1 u38534 dyno   39 Feb  6 16:41 Procfile
drwx------  2 u38534 dyno 4096 Feb  6 16:41 .profile.d
-rw-------  1 u38534 dyno  257 Feb  6 16:41 .pylintrc
-rw-------  1 u38534 dyno   54 Feb  6 16:41 pytest.ini
-rw-------  1 u38534 dyno 2206 Feb  6 16:41 README.rst
drwx------  2 u38534 dyno 4096 Feb  6 16:41 requirements
-rw-------  1 u38534 dyno  151 Feb  6 16:41 requirements.txt
-rw-------  1 u38534 dyno   12 Feb  6 16:41 runtime.txt
-rw-------  1 u38534 dyno  206 Feb  6 16:41 setup.cfg
-rw-------  1 u38534 dyno  579 Feb  6 16:41 .travis.yml
drwx------  2 u38534 dyno 4096 Feb  6 16:41 utility

Works fine on my end, I've run the following bash script:
#!/bin/bash

cookiecutter https://github.com/pydanny/cookiecutter-django --no-input --overwrite-if-exists \
use_heroku=y \
js_task_runner=None \
use_sentry_for_error_reporting=n \
use_pycharm=n \
project_name='Heroku Tests'

cd heroku_tests

git init
git add .
git commit -m "Initial commit"

heroku create

heroku config:set \
DJANGO_ADMIN_URL='^staff/' \
DJANGO_SETTINGS_MODULE=config.settings.production \
DJANGO_SECRET_KEY='ebeez6qua3uzaeSoogoo1shah7mang6eesh1bees' \
DJANGO_ALLOWED_HOSTS='*' \
DJANGO_AWS_ACCESS_KEY_ID='fake' \
DJANGO_AWS_SECRET_ACCESS_KEY='secret' \
DJANGO_AWS_STORAGE_BUCKET_NAME='my-stuff' \
DJANGO_MAILGUN_API_KEY='svjsaj' \
<EMAIL_ADDRESS>\
MAILGUN_SENDER_DOMAIN='example.com'

heroku addons:create heroku-postgresql:hobby-dev

git push --set-upstream heroku master

heroku run python manage.py migrate

heroku open

And here is the resulting app:
https://murmuring-fjord-52109.herokuapp.com/
What are the answers you gave to the cookiecutter questions?

@joseGabriel06, closing this as "works for us". Please start over from scratch, and record what you put in for Cookiecutter values. If you run into the same problem, follow the issue template and post as @browniebloke just did.


haskellPackages.patat: Apply commit from main branch relaxing bounds

Description of changes
patat is broken because of unnecessary upper bounds in the release currently tracked by nixpkgs.

Things done
Applied a commit from main branch of patat relaxing the upper bounds causing the build to fail.

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Thanks a lot.  Looks like it is at least building on x86_64-linux.
Feel free to send a follow-up PR adding yourself as a maintainer if this is a package you'd always like working.


Fix GetEvaluationHistory from clause.

Summary
Fix GetEvaluationHistory from clause.
Change Type

[X] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Manual tests.
Review Checklist:

[X] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[X] Checked that related changes are merged.

coverage: 52.658% (-0.008%) from 52.666%
when pulling 72f5a1c96bf649e5010a065a44fccb96067a83e6 on fix/get-eval-history-by-id-from-clause
into a50982b7048d3ad6a62d4d37b89f794713e6667d on main.


Add PeakGroupSet table class

FEATURE DESCRIPTION
Feature Inspiration
We need a way to track the provenance of imported PeakGroup data, both for error checking and later lookup. Also, there is potentially some value in the grouping of PeakGroup data provided by a single AccuCor file (data analysis session). For example, if a researcher performs a second analysis of the same MSRun data, adding new compounds to the data, we currently have no way to tell that some PeakGroups were added separately from the original PeakGroup import.
Feature Description
Add a PeakGroupSet class that tracks the filename and import time of a given AccuCor file, and associate the PeakGroups with that PeakGroupSet record.
Alternatives Considered
We had discussed tracking simply the filename, though tracking the time of import seems simple enough to add.
We also discussed tracking the researcher that uploaded the data, but since we have not incorporated the user model yet and are not providing uploads via the web interface, this will be implemented later if needed.
Comment

# Track the source of PeakGroup data
PeakGroupSet
-
id PK int
filename string
imported_timestamp datetime

PeakGroup
-
id PK int
name string     # Compound or isomer group name
formula string  # Molecular formula
compound_id int FK >-< Compound.id
peak_group_set_id int FK >- PeakGroupSet.id
ms_run_id int FK >- MSRun.id
# Additional computed values
# total_abundance
# enrichment_fraction
# enrichment_abundance
# normalized_labeling

ISSUE OWNER SECTION
Assumptions

The basename of the filename will be parsed presumably from --accucor-file

Requirements

--accucor-file is already a required argument

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected/Changed Components

load_accucor_msruns.py parsing the basename from --accucor-file, and passing it along
utils.py AccuCorDataLoader, accepting the basename from keyword args
PeakGroup and PeakGroupSet model additions
possible test changes/additions

DESIGN
GUI Change description
Input APIs and usage remain unchanged. Views and queries would presumably adjust to use this data.
Code Change Description (Pseudocode optional)
use os.path.basename
Tests
A test should be planned for each requirement (above), where possible.

Note: this will likely require and database flush for these migrations, if PeakGroupSet is required

@lparsons @hepcat72 @fkang-pu Regarding filename, are there any constraints to this table? ( i.e. is filename unique ?).  Asking because it is easy to add a single/cached PeakGroupSet for a single run of load_accucor_msruns.py , but if you run it multiple distinct  times with different peak sets but potentially the same filenames, things might be a little tricky to interpret afterwards.  Just asking for a first-pass specification, because load_accucor_msruns.py wasn't really coded with the "add new peak groups to previously loaded/inferred msruns" mindset (#65).

I guess I will just insert 1, no matter the name, and hope for the best

I don't see a big concern right now about constraints. I think ultimately, we'd want to store that file somewhere for provenance.
As for load_accucor_msruns.py, I would probably make the assumption that the filename was unique and do a get_or_create using the filename as a lookup. At least, to me, that would work for a while. Please let me know if you have an alternate suggestion though, I think you've probably thought about this more deeply than I at this point.

It is just that with the imported_timestamp presumably defaulting to "now" in the model (e.g. this load_accucor_msruns.py execution), then we should proabably never "get"/retrieve a previous one, because that was a different time and potentially a different file (albeit with a shared name).

Good point @jcmatese. Would it make you more comfortable to add the unique constraint on the filename? That seems reasonable to me.

Nah, that is ok, as long as everyone is ok with the interpretation (always report as "this file at this date time")

It's a good idea to add unique constraint on the filename.

OK, I can add it if you all want.

@lparsons @fkang-pu @hepcat72 regarding foreign-key/attribute naming conventions, do you have a strong preference going forward on how to name columns/methods such as the existing
PeakGroup.ms_run referencing MsRun class (i.e. added underscore),
https://github.com/Princeton-LSI-ResearchComputing/tracebase/blob/e9be74d48cc5b66eb5d112193fe177f7f18070f9/DataRepo/models.py#L216-L222
or the presumptive addition in this issue of
either PeakGroup.peakgroupset or PeakGroup.peak_group_set for the foreign key from PeakGroup to  PeakGroupSet

May want to add a note on cocoding/naming styles going forward, if a consensus decision is made.

Generally, camelcase to underscore seems to be the more popular representation.

Good question John. I would prefer we be consistent with how other fields and relationships are named. I believe that would be using underscores (_), so probably PeakGroup.peak_group_set. I'm fine with updating those notes, but I'd prefer they live in the repository in git and not on nplcadmin docs (e.g. CONTRIBUTING.md or README.md).

Using understore is fine with me - easy to read. So far, I can retrieve the value(s) for foreign keys as long as I use the field names defined for that model class.

Just noting that to add this non-nullable foreign key to PeakGroup, I will probably need to revert to an earlier version of the database/model, and make migrations from there...
$```
python manage.py migrate DataRepo 0003
Operations to perform:
Target specific migration: 0003_auto_20210402_1105, from DataRepo
Running migrations:
Rendering model states... DONE
Unapplying DataRepo.0011_peakdata_help_test... OK
Unapplying DataRepo.0010_merge_20210504_1613... OK
Unapplying DataRepo.0009_auto_20210429_1433... OK
Unapplying DataRepo.0008_changed_unique_constraints_coding... OK
Unapplying DataRepo.0007_peakdata_validator... OK
Unapplying DataRepo.0006_msrun_researcher... OK
Unapplying DataRepo.0006_auto_20210503_1855... OK
Unapplying DataRepo.0005_auto_20210421_1054... OK
Unapplying DataRepo.0004_PeakGroup_Data... OK

Had to go back even farther.
$ python manage.py makemigrations --name PeakGroupSet DataRepo
Migrations for 'DataRepo':
  DataRepo/migrations/0002_PeakGroupSet.py
    - Create model Animal
    - Create model MSRun
    - Create model PeakGroupSet
    - Create model Protocol
    - Create model Study
    - Create model Tissue
    - Alter field hmdb_id on compound
    - Create model Sample
    - Create model PeakGroup
    - Create model PeakData
    - Add field protocol to msrun
    - Add field sample to msrun
    - Add field studies to animal
    - Add field tracer_compound to animal
    - Create constraint unique_peakgroup on model peakgroup
    - Create constraint unique_peakdata on model peakdata
    - Create constraint unique_msrun on model msrun

Adding any non-nullable foreign key can be an issue, migration wise.  Not certain of the best approach, and this may certainly come up again with Animal.treatment

Any reason not to regenerate the migrations completely at this point? Going forward, if we have to do this with real data, we there needs to be a method to set the field (either default or by lookup).

We could regenerate completely, I suppose.  The issue with these non-nullable foreign key additions is that you might first have to create the model (PeakGroupSet). Then insert the initial default value (say filename=NA). Then add the default to the dependent model (PeakGroup with that id=1 default).  At least, I think that is how you might have to do it, and that would see like a custom edited migration file, I think (because of the insert, and stepwise additions).  I am just reverting back (above), because it doesn't really matter now, but if the database every had values we wanted to keep, we would have to figure out the appropriate protocol to pull this off.

Good point, I do think they would require some custom migrations in order to be applied cleanly on top of existing records.

I ended up in kind of a mess.  Had to drop the database and re-init, here.  Wasn't what I intended, but that is what happened...

Very good issue documentation!  Clear and concise.


little layout-improvements

first i didn't want to mention it, since they are just a little - maybe personal - preference... but at least with #206 it got a little bit serious:
i don't get it why the servings have to be the farthest away from the ingredients...?

[ ] for me the servings correlates with the ingredients and in conjunction with the "big solution" for #193 moving them there would be the best solution.
--> this will also release some space, maybe for moving the difficulty level https://github.com/RyanNoelk/OpenEats/issues/206#issuecomment-314058324 beside the times...

[x] but for a quick and easy improvement please at least invert the order in the table, since the servings next to the ingredients would be better, then the next step is the preparation and the last is cooking.

This makes a ton of since. I'm defiantly not a UX expert, so I welcome any changes like this.

as you see i tried the quick improvement myself, but sadly i have no idea of GUI development and i'm neither an expert... :disappointed:

Fixed with #214


Remove canary check for OpenTelemetry versions

OT API keeps getting breaking changes, remoting canary check until OT code is stable, this is causing build issues
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=731707&view=results

/azp run js - monitor - ci


feat(Combinatorics/SimpleGraph): Some lemmas about walk, cycle and Hamiltonian cycle

These lemmas are separated from the meow-sister/BondyChvatal branch and will be needed for the proof of the Bondy-Chvátal theorem.

[x] depends on: #15536
[ ] depends on: #16294

Can you merge master and adapt to use the lemmas in #16294 ?


Add back cache-key input

The cache-key input is currently not being used. Fix action.yml cache step.

Fixed with #6


Escape \u0007 in shell integration and escape both property and command line

Context: https://github.com/microsoft/vscode/pull/145610#issuecomment-1076354864
We want to assume \u0007 in a property shows up as <ST>, similar to the existing how we escape the command line:

Verify this via code review

PR is already reviewed


Cron and Cron_d resource weekday property fixes

Signed-off-by: antima-gupta<EMAIL_ADDRESS>
Description

Cron resource symbols for weekday are broken.
Fixed weekday property for cron_d and cron resources
It will support weekday values: 0-7, mon-sun, monday-sunday, or * .
Also weekday property will be full name and or short name in a Symbol or String(for ex:-  :mon, 'mon', 'monday', :monday etc..)

Related Issue
Fixes: #3351
#7060
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Let's take this to the next level. We introduced resource partials in Chef Infra 16 that let us clean this up further without the need for helpers.
We did this with the git/subversion resources here:
https://github.com/chef/chef/tree/master/lib/chef/resource/scm
We can create a cron directory that contains the cron and cron_d resources and a new _cron_shared.rb resource partial that includes the common properties and common validators. Then you just include it with use like we do here: https://github.com/chef/chef/blob/master/lib/chef/resource/scm/git.rb#L24

Let's take this to the next level. We introduced resource partials in Chef Infra 16 that let us clean this up further without the need for helpers.
We did this with the git/subversion resources here:
https://github.com/chef/chef/tree/master/lib/chef/resource/scm
We can create a cron directory that contains the cron and cron_d resources and a new _cron_shared.rb resource partial that includes the common properties and common validators. Then you just include it with use like we do here: https://github.com/chef/chef/blob/master/lib/chef/resource/scm/git.rb#L24

@tas50 Command property has different parameters like In cron resource we have identity parameter and in cron_d resource we have required parameter.We can add both parameters in cron as well as cron_d resource but If we add required parameter then it will become mandatory earlier for cron resource command property was not mandatory it can be nil so it will through exception i.e. Chef::Exceptions::ValidationFailed: command is a required property
Do we need to make command property common or keep it as currently?

I was wondering the other day why command wasn't mandatory. It really should be. It's probably just a historical thing. When we added that resource originally we probably didn't have the ability to make properties required.

@antima-gupta can you rebase this so we can see if the kitchen test will pass now that we fixed the issue you're hitting in testing

@tas50 I have rebase this branch.I still need to work on move the helpers into this resource partial.Currently I am working on priority task i.e. Chef Workstation 2020 Testing after finish this, I'll continue on this.

@tas50 I have moved validations into the partial file.Please have a look and let me know if any changes required.

I pulled this locally, rebased it and merged it to master. Thanks @antima-gupta

@tas50 I have fixed chef_spec failure for cron resource in the PR: 990. Please have a look.

I realized that moving the validators into the partial was actually the wrong call since we use those in chef_client_cron and we don't want to include the extra properties there. I opened a new PR with these changes but I reverted that last part. I'm going to merge that once the tests pass. Sorry for the extra work there. I forgot all the consumers of those validators.

Thanks @tas50 for update.


train

For each timestep:
observations
- images
- cam_high          (480, 640, 3) 'uint8'
- cam_low           (480, 640, 3) 'uint8'
- cam_left_wrist    (480, 640, 3) 'uint8'
- cam_right_wrist   (480, 640, 3) 'uint8'
- qpos                  (14,)         'float64'
- qvel                  (14,)         'float64'
action                  (14,)         'float64'
"""

data_dict = {
    '/observations/qpos': [],
    '/observations/qvel': [],
    '/observations/effort': [],
    '/action': [],
}

May I ask if qvel and effort are used in the training phase? What about in the inference phase? What would happen if qvel and effort are missing during the training phase?

Hi,
qvel and effort are logged but we haven't tried including them in training/inference. Missing these fields should not matter at all.
Tony