Maps clouded by Region rendering

Maps could use some attention

Maps are sluggish and become generally unusable after a few scrolls/UI actions
Rendering of region could be re-imagined
Integration of table resource view and google maps viewport could be improved
maintaining code for separate resource listings in list tab vs map tap is undesirable (extra credit for reusable component for resource listings across all of HydroShare)
Map loading experience/reactivity could be improved
z-index and conflict between region and cluster/marker clicks leads to unusable situations

I appreciate this new focus on Discover maps.  See #1361 and #1755 for prior ideas on this.  In particular in https://github.com/hydroshare/hydroshare/issues/1755#issuecomment-274372087 I generated quite a long list of suggestions for improving the map aspects of Discover that may be helpful as you re-imagine this.

Issue resolved as a part of the Discover redesign


Output summary explanation

In the below what exactly is the figure in the first column after assertions?
I had assumed it was the number of assertions in code and compiled into the test binary, and thus that it would be constant from one run to the next, but in our CI test job that keeps failing this is an apparently random number, it might be 671 one run, and the next 633, then 710, etc.  I'm just trying to get a clue as to what on earth might be going on.
2021-10-05 15:20:16 - INFO     - | 1: ===============================================================================
32812021-10-05 15:20:16 - INFO     - | 1: [doctest] test cases:    100 |     88 passed |     12 failed |      0 skipped
32822021-10-05 15:20:16 - INFO     - | 1: [doctest] assertions:    671 |    659 passed |     12 failed |
32832021-10-05 15:20:16 - INFO     - | 1: [doctest] Status: FAILURE!
32842021-10-05 15:20:16 - INFO     - | 1/1 Test #1: my_tests .................***Failed   67.52 sec

It cannot be the number of assertions in the binary - it's the number of encountered assertions during the run of the tests. If a test case exits prematurely then all assertions after it will not have been encountered.
If this number varies between runs without any changes to your code then there is something non-deterministic about your tests.


User information stored in database needs to be encrypted

I been suggesting a shorter circuit is from here
https://github.com/Code4HR/okcandidate/blob/develop/api/controllers/SurveyResponse.js#L8-L11
we could anonymize this by replacing the emails Survey with
<EMAIL_ADDRESS>or 757-555-555 before its returned since no one will ever have to get it out.
I suggested to @ttavenner we could directly query postgres or just do a one time CSV dump when we want to send the alert on May 5th with @MFogleman


Unable to send JSON list using @json annotation

I needed to post a JSON list and ran into difficulty using @json and Body.  The code seems to assume that a json body will always be a dictionary and tries to loop over the items.  Specifically, in decorators.py the old_body will be a list instead of the expected dictionary.
    @classmethod
    def set_json_body(cls, request_builder):
        body = request_builder.info.setdefault("json", {})
        old_body = request_builder.info.pop("data", {})
        for path in old_body:
            if isinstance(path, tuple):
                cls._sequence_path_resolver(path, old_body[path], body)
            else:
                body[path] = old_body[path]

As a workaround I found that I could just pass json.dumps as a converter-
    @headers({"Content-Type": "application/json"})
    @post("/collections/{name}/documents", args={"name": Path, "documents": Body(json.dumps)})
    def send_documents(self, name, documents):
        '''Send some documents'''

and then things will work
data = ["one", "two", "three"]
service.send_documents("testing", data)

@kyrrigle, Sorry about that! Fortunately, this should be a quick fix, which I'm tracking with #104.
Here's a little background, in case you're interested: the loop in set_json_body is mainly responsible for resolving any nested JSON field references. Namely, such a reference is possible with the Field annotation. For example, consider a Update User API endpoint that expects a JSON body in the following format:
{
    "user": {
        "name": "username"
    }
}

We could send a username update request using the following method (note the argument of Field is a tuple):
@json
@post("/user", args={"name": Field(("user", "name")})
def update_username(self, name):
    """Update the current user's username"""

Finally, when processing the request body, the set_json_body method loops over the body to resolve these JSON field references.
Anyways, the fix I'm working on would skip the loop if the body is not an instance of collections.Mapping. This change should be live in a couple of hours, barring any complications. If you want to try it out beforehand, you can install the branch directly using pip:
$ pip install https://github.com/prkumar/uplink/archive/hotfix/v0.5.5/json-list-as-body.zip

Thanks again!

@kyrrigle, the fix is included in v0.5.5 release. When you get the chance, please upgrade. Thanks for filing a ticket.


Make High DPI Monitors work properly with Hazel!

This is the changes from previous merges plus #335.

@TheCherno mentioned that he would look at this, but he didn't do it yet. He said it looked good, but he also mentioned he's not a fan of high dpi monitors :D I'll leave it here for now...

Font points are vertical measurements for fonts. Why does this patch take the horizontal screen scaling factor?

Font points are vertical measurements for fonts. Why does this patch take the horizontal screen scaling factor?

That's an oversight on my behalf, i'll fix it soon.

This will hopefully be the last change...
I have changed the windowswindow.cpp to use yscale instead of xscale, but this is getting pretty tedious because i don't have a github app, so i do everything via commandprompt which is anything but ideal!
But look at this pull request instead: #372.


feat(synapse): add circleci.yml in new main branch

Signed-off-by: Gabriel Jimenez<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


added HTL Eisenstadt

One of the related courses is "Angewandte Informatik und fachspezifische Informationstechnik" (applied informatics and field specific information technology), see "Stundentafel der Mechatronik" at https://www.htleisenstadt.at/en-us/ABTEILUNGEN/MECHATRONIK/Stundentafel (Sorry for the non existing translations there, although they have this flag suggesting a proper translation. Doesn't do anything besides changing the date format.)

@scheriam First stage of verification passed, official domain is htleisenstadt.at as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@scheriam Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Redirect all requests to GitHub source

As part of #126 (ampbench shutdown), redirect all requests to the GitHub.
Surprisingly, it looks like it's necessary to run a nodejs server to do this?? Is there any way around this?
/cc @juliantoledo @sebastianbenz

This is staged at:
https://ampbench-staging.appspot.com/

Probably you could do it statically with JS to avoid running a server:
https://stackoverflow.com/questions/1058119/how-to-redirect-all-urls-with-google-app-engine/24089287#24089287
On Tue, Feb 4, 2020 at 4:34 PM Michael Stillwell<EMAIL_ADDRESS>wrote:

This is staged at:
https://ampbench-staging.appspot.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ampproject/ampbench/pull/136?email_source=notifications&email_token=AAOU57CEUZ2LINQORJ7JGHTRBICRJA5CNFSM4KQBRCV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZW7QY#issuecomment-582184899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOU57EEC3RVT73REXS7ORLRBICRJANCNFSM4KQBRCVQ
.

--
-- Julián Toledo


Possibility of using the export to pdf/excel functionality

Is it possible to use the export to pdf/excel function outside of the datatable plugin context ?
I need to use it on a simple table.
How can I proceed ?

Yes, I think someone has a solution for this on closed issues.
See https://github.com/yajra/laravel-datatables/issues/808. Thanks!


Usb accessory Troubleshooting.

Hi ,
I am trying to put Nexus 5 in usb accessory Mode using Raspberry Pi .
I am able to launch the app by using Intent and I am able to communicate with 0 endpoint as it is returning the version of Usb accessory mode i.e 2.0 but I am not able to communicate using bulk endpoint.
Same thing I have done with Motorola phone . I am able to communicate using Bulk endpoint.

Not all devices can support accessory mode and host mode simultaneously. This is up to the device manufacturer.

But my Nexus 5 is going into Usb accessory Mode as its PID and VID get changes to google accessory PID and VID . Its means I can communicate with control_transfer endpoint but not able to communicate with Bulk end point.


Chemical Fixation - Instrument Wattage field is different here...

The Instrument Wattage field on the High Pressure Freezing module has a set of arrows off to the right to increase/decrease numbers.
The Instrument Wattage field on the Chemical Fixation page doesn't have this (and there are two of these fields for some reason).
We should be consistent - I think I prefer the option with the arrows as it indicates that a number goes there. Please make this change here.
Can you also find any additional instances of Instrument Wattage and make the change there if needed?
And could you also check the code for the double Instrument Wattage fields and see if there's any indication as to what the repeat field is actually meant to be? If there's no indication of something else, then please remove the second one.

The reported problems were identical in 'Chemical Fixation', 'Rinsing' and 'Incubation'. No hints in the code why the fields have been duplicated in these particular cards. The issues have been fixed and are deployed in localhost:3002 and can be reviewed

reviewed all instrument wattage fields mentioned above. all look good.

closed as part of merge request #22


Modals: Fix modal background parent container.

This commit changes where the backdrop of our bootstrap modal
component is rendered. The issue was that our modal component
was being rendered after the .app div which contains the contents
of the application. This was causing a problem in webkit browsers
on mobile where the z-index of the backdrop was being read as being
higher than that of the modal contents.
Fixes #11509
See https://chat.zulip.org/#narrow/stream/6-frontend/topic/Problem.20with.20catch.20up.20overlay.20on.20mobile.20site

Testing Plan:
GIFs or Screenshots:

I'm really not excited about patching bootstrap for this; I'd rather work on migrating the bankruptcy modal to some other sort of banner instead (which we've talked about doing).  It's not actually good UI for it to be a modal.

Tbh with you I 100% agree. Neither is the language clear on what clicking the buttons will do ( I’ve used it multiple times thinking it will take me through my unread messages and instead what it does is clear them all out. It’s also very annoying since it pops up each time.
Moving it to a banner is a better idea. Let me know if you’d like me to work on that.

Thanks for working on this, armaanahluwalia!
The model has now been replaced with a banner. Closing this PR.


Add recruitment/create-requisition profile

Description

This PR adds recruitment/create-requisition profile along with mock and lever provider maps.
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@tmladek is it still worth finishing this task? Do you have capacity to finish the review or should I close it?

We no longer have any demand for the 'recruitment/create-requisition' profile.


Fixed incorrect retrieval of 'error' state

My last pull request contained a mistake 🙁
Sorry for that...

Ah, typical thing a review should catch! There should be tests on that code, too :)


duplicate token: token address

I am unable to proceed with my pull request due tho the this error; duplicate token: token address is already used.
How do I locate this duplicate? As it won't allow me to successfully make my request with auto-merge.
#9112

@keone could you help me take a look at this please, and thank you.

you already added it in https://github.com/solana-labs/token-list/commit/5f9e9ba18608626c068b881717583da8cdd49792

I appreciate the response @keone your right I have, but not sure how to close that as I have made a new one. I didn't realise creating this new one will been seen as a duplicate. could you help me with this please?

it's just a text file: make the diff that you want to get the file into the correct state, commit that, and open a PR

@keone I made the difference already in my new pull request but, it is still telling me it is a duplicate. If possible I would like to delete all created files under MANSA MUSA and start again but I'm also unsure how to do that apologies if I seem simple.

i'm sorry, but there are too many PRs for maintainers to make changes for you or instruct you on how to use git. figure that out or get a friend to help you and link a PR

@keone  thank you


[All Hosts] (coding) include file about how to support IE with post-E…

…S5 JavaScript

Docs Build status updates of commit d1f90bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/add-in-development-best-practices.md
:white_check_mark:Succeeded

docs/develop/common-coding-issues.md
:white_check_mark:Succeeded

docs/includes/es5-support.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 14456d3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/add-in-development-best-practices.md
:white_check_mark:Succeeded

docs/develop/common-coding-issues.md
:white_check_mark:Succeeded

docs/includes/es5-support.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 21e317c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/concepts/add-in-development-best-practices.md
:white_check_mark:Succeeded

docs/develop/common-coding-issues.md
:white_check_mark:Succeeded

docs/includes/es5-support.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Private Key

First of all thank you for your great job! The UI and UX are really great!
I understand you want to keep the app as simple as possible, but it would be great to allow advanced users to import / export their private keys.
I would update the fees and I can't with this wallet. So either you allow the users to update them or allow them to use another wallet to configure the fees if needed.
Best

Your twelve word seed is the equivalent to your private key. Most wallets can import the seed phrase the same way they can import a priv key.

You can use the BIP39 phrase to convert to a private key using widely available online tools if this is of interest to you.


raidboss: DSR Thordan location callout.

This is a pretty simple addition. It will call out Thordan's location before he spawns during Strength of the Ward by referencing the knight that spawns early in his opposite position. Ideally this trigger allows players to be able to move quicker with the knowledge of where Thordan will re-appear. The trigger its using doesn't actually matter, its just for proper timing on the overlay call.
The hard coded x/y checks are pretty nasty, I'm open to any recommendations on how to make that less ugly. I tested this on 10 of my logs tonight and it had correct predictions for each, but IIRC Overlay Handler calls can be unreliable on the emulator. Real world testing probably required.

I believe this is similair to pr: https://github.com/quisquous/cactbot/pull/4362 specifically DSR Dragon's Rage trigger, not sure which is more useful. I'll leave that up to you all.

Turns out, moving the trigger to 63D6 - Heavy Impact 1 allows you to fine thordans spot up to 10 seconds before he comes down!

I believe this is similair to pr: #4362 specifically DSR Dragon's Rage trigger, not sure which is more useful. I'll leave that up to you all.

The trigger in that referenced PR named DSR Dragon's Rage does call out Thordan's location, but it uses Thordan's real combatant, and so the soonest it can call out is when Thordan appears +- some delay in OverlayHandler updating combatant data.
Looking back at my VoDs, I do see that the Marauder knight, Ser Hermenost, spawns right after the Spiral Thrusts and then Thordan appears to spawn on the opposite side each time. I never realized that was also a way to determine where Thordan will be. I think switching to Ser Hermenost is a good idea since the player can also realistically get that info at that time as well. Also looks like it does not currently compete with any other callout, although I think given it is some time before Thordan appears, maybe it would need some durationSeconds added just to match up to a little after the boss appears.
I think there are multiple Ser Hermenost combatants, at least that's what fflogs is showing. The one thing that I don't know you can get in the raidemulator is how much delaySeconds is needed to get the position data once Ser Hermenost is in position, and in my experience getting that value has required trial and error.

I have code written to switch to using Ser Hermenost, would just need to determine how much delaySeconds it's going to need which I can get later.
Would you mind if I committed this change to my PR?

The hard coded x/y checks are pretty nasty, I'm open to any recommendations on how to make that less ugly.
Regarding hard coded checks here: I am using some code I've borrowed from previous commits (both myself and others) that just does some trigonometry on X / Y coordinates which avoids the issue with getting minor fluctuations in floating point values across runs and also allows us to do modular arithmetic to get card/intercard values and then use a hashmap to quickly translate output strings.

Typically it's like this for the 8 cards/intercards
const matchedPositionToDir = (combatant: PluginCombatantState) => {
  // Positions are moved up 100 and right 100
  const y = combatant.PosY - 100;
  const x = combatant.PosX - 100;

  // During Thordan, knight dives start at the 8 cardinals + numerical
  // slop on a radius=23 circle.
  // N = (100, 77), E = (123, 100), S = (100, 123), W = (77, 100)
  // NE = (116.26, 83.74), SE = (116.26, 116.26), SW = (83.74, 116.26), NW = (83.74, 83.74)
  //
  // Starting with northwest to favor sorting between north and south for
  // Advanced Relativity party splits.
  // Map NW = 0, N = 1, ..., W = 7

  return (Math.round(5 - 4 * Math.atan2(x, y) / Math.PI) % 8);
};

There are similar code for headings too that get commonly used. I think it's also been proposed at one point to have some sort of standard function in cactbot for these calculations.

Would you mind if I committed this change to my PR?

This is just a general suggestion, but I think it's better to split changes up so that PRs can land earlier and not keep getting added to incrementally preventing all the earlier changes from landing until those changes are also resolved.

The one that is giving off the position of Thordan isn't giving me the data until Thordan is visible... but maybe I am just getting the wrong combatant.

To add, I am just getting 1 combatant in overlayHandler, so maybe some difference with raidemulator makes it possible to get the data early? It's odd though why I can't get the position data earlier as theoretically a player could.

To add, I am just getting 1 combatant in overlayHandler, so maybe some difference with raidemulator makes it possible to get the data early? It's odd though why I can't get the position data earlier as theoretically a player could.

Oof, that's not good. I wonder why that is, I'm about to start raiding so i'll try and get some data as well.


Fix TGI issues with ROCm

Not all models were tested in https://github.com/huggingface/text-generation-inference/pull/1764.
Fixing some more issues (notably starcoder2) here, the full CI will come shortly once we split build.yml in two

Will merge as a hotfix due to time constraints, once nvidia integration tests pass. We will need to properly refactor this.


Wiki fix .then() syntax build function

Made changes to the .then() example on the Wiki home page.
I chose to bind to publisher just because most of the other examples throughout the wiki are now using publisher.fn() syntax for examples.

did not see all those other commits on this branch.


Error #01: assignment to entry in nil map when trying to set headers

Hi,
Currently we are using Krakend latest docker image and we are using krakend-lua plugin to transform the request and response, with the request everything seems to be fine, but when we try to set response header we are getting the error below:
Error #01: assignment to entry in nil map
goroutine 83 [running]:
github.com/yuin/gopher-lua.(*LState).PCall.func1(0x22b7ec0, 0xc000160780, 0xc0009170e0, 0x0, 0x0, 0x0)
        /go/pkg/mod/github.com/yuin/gopher-lua@v0.0.0-20190206043414-8bfc7677f583/state.go:1634 +0x601
panic(0x1f747e0, 0x251a0e0)
        /usr/local/go/src/runtime/panic.go:967 +0x15d
github.com/devopsfaith/krakend-lua/proxy.(*response).headers(0xc0005a80b0, 0xc000ecaa60, 0x1, 0xc000ecaa60)
        /go/pkg/mod/github.com/devopsfaith/krakend-lua@v1.1.0/proxy/response.go:86 +0x17c
The error can be reproduced using the setup below in the post section of the plugin configuration in any backend:
"post": "local resp = response.load(); resp:headers('Content-Type', 'application/json');"

This is fixed after setting the encoding to no-op.


Signed-off-by: pandax381<EMAIL_ADDRESS>

Thanks! LGTM!


Installs libembree.so despite OSPRAY_USE_EXTERNAL_EMBREE:BOOL=ON

I delete ospray/embree-v2.7.1 and set OSPRAY_USE_EXTERNAL_EMBREE:BOOL=ON, yet it still installs libembree:
-- Installing: /usr/ports/graphics/ospray/work/stage/usr/local/share/doc/OSPRay/README.md
-- Installing: /usr/ports/graphics/ospray/work/stage/usr/local/lib/libembree.so.2.12.0
-- Installing: /usr/ports/graphics/ospray/work/stage/usr/local/include/ospray/OSPConfig.h

It is binary identical to /usr/local/lib/libembree.so, so it must be copying it from there.
And the same with libtbb:
Installing ospray-1.1.1...
pkg-static: ospray-1.1.1 conflicts with tbb-2017.1 (installs files into the same place).  Problematic file: /usr/local/lib/libtbb.so

Yes, this is a bug we like to fix in the next release.


Demo web stand alone

Why the trained faces on the browser are all black?

Hi @itas109 - I'm confused why you submitted @cowbjt's fork as a PR to ask them about a bug and am closing this PR.
-Brandon.


[WIP] Fixed has_one associations to VmdbMetrics table

Purpose or Intent
Applied fixes to has_one associations in VmdbTable and VmdbIndex models to fetch max(latest) performance metric from VmdbMetrics.
Previously has_one associations to latest VmdbMetrics values in VmdbTable and VmdbIndex models were fetching random number of records to display in UI DB Configuration Tables and Indexes tabs.
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1339638
Steps for Testing/QA
Settings => Configuration => Database (accordion) =>  Select Tables or Index tab, proper number of entries should be displayed matching Per Page pagination controls' value.

LGTM Just fix the rubocop warnings.

/cc @dclarizio

@GregP Why is this WIP?

@Fryguy Adding specs, just did.

@Fryguy @dclarizio @h-kataria Ready for review.


Add ssl passthrough support for annotations

#491

@sadlil  Why FoundTLS has to be true if HAProxy is not offloading SSL ?


Should include documentation in this repository.

Original report by Anonymous.

Updated (by Aaron)
Migrate [developerWorks](https://www.ibm.com/developerworks/community/wikis/home?lang=en#!/wiki/IBM i Technology Updates/page/Toolkit for i APIs) iToolkit API docs to this repo in /docs/README.md.
Original
Consists of two parts:

Move from its current home at http://youngiprofessionals.com/wiki/index.php/XMLSERVICE/Python
Include better documentation of the itoolkit-lite package and how to get it.

Closing after merging PR #58


Allow setting alternative avatar or transparency color for bluesky

I bridged my fedi account to bluesky, it filled transparency with white, either automatically or by jpeg-ing it.

Would be nice to either have an ability to upload an alternative version of the avatar or set the color which will replace transparency instead.

Fascinating request! I definitely get it.
I'm unlikely to start processing or hosting images in Bridgy Fed directly, but it's interesting to think about how users could specify an alternate avatar image.

I'm unlikely to start processing or hosting images in Bridgy Fed directly, but it's interesting to think about how users could specify an alternate avatar image.

Doesn't it upload fedi avatar to bluesky when creating the profile?

There's no image download or upload. Bridgy Fed is its own PDS, it manages its own blobs, and it does that by using the original image URLs from your fediverse instance directly.


Patch deployment resource constraints

Summary

Patch deployments so you can change resource limit/requests in our settings and have them applied automatically.  Previously, any limit/requests settings would require each deployment to be deleted/recreated either manually or by manually restarting the orchestrator.
Pods will still be restarted when the deployment is patched but there is no need to manually delete the deployment.

Details

Monitors pod deployment specs from kubernetes (a second monitoring thread - first did pods, this second one does deployments, each with different API endpoints)
Detect when the desired resource constraints (requests/limits) doesn't match the current specs
Patch any deployments not matching desired values

Honors changes made in our UI/configure_server_settings.rb/our settings.yml.
Rollback any request/limits changes made outside of manageiq, such as through kubernetes/oc edit deploy

Alter the existing scale patch mechanism to use the same logic so we track both replica and resources
Handle comparison problems

Millicores: "1" == "1000m" (valid and equal - shouldn't trigger patch_deployment)
Gibibytes/Mebibytes comparisons: "1024Mi" == "1Gi" (shouldn't trigger patch_deployment)
Decimal CPU: "0.5" == "500m" (valid and equal - shouldn't trigger patch_deployment)

Example logging

When scaling the deployment:

[----] I, [2020-12-08T16:50:05.218922 #8:2b1de6d25968]  INFO -- : MIQ(MiqGenericWorker.sync_workers) Workers are being synchronized: Current #: [1], Desired #: [2]
[----] I, [2020-12-08T16:50:05.241662 #8:2b1de6d25968]  INFO -- : MIQ(ContainerOrchestrator#patch_deployment) deployment_name: 1-generic, data: {:spec=>{:replicas=>2}}

When a change in requests / limits is detected:

[----] I, [2020-12-08T16:52:53.806163 #8:2b1de6d25968]  INFO -- : MIQ(MiqServer#sync_deployment_settings) Constraints changed, patching deployment: [1-generic]
[----] I, [2020-12-08T16:52:53.810591 #8:2b1de6d25968]  INFO -- : MIQ(ContainerOrchestrator#patch_deployment) deployment_name: 1-generic, data: {:spec=>{:template=>{:spec=>{:containers=>[{:name=>"1-generic", :image=>"jrafanie/manageiq-base-worker:patch-deploy5", :resources=>{:limits=>{:memory=>"600Mi", :cpu=>"1000m"}, :requests=>{:memory=>"500Mi", :cpu=>"150m"}}}]}}}}

Fixes: #20727
TODO:

[x] Finish writing specs
[x] Rewrite commits specifying https://github.com/ManageIQ/manageiq/issues/20727

@jrafanie This is a little backwards from what I expected.  If Kubernetes is the source of truth, then I expected that we would include the deployments as seen by Kubernetes (that is, monitored via watches).  From what I can tell, this code seems to store the desired state (that is, what our application told Kubernetes), and then compare that value.  But, if a users messes with something on the Kube side, we would never know.

@jrafanie This is a little backwards from what I expected. If Kubernetes is the source of truth, then I expected that we would include the deployments as seen by Kubernetes (that is, monitored via watches). From what I can tell, this code seems to store the desired state (that is, what our application told Kubernetes), and then compares that value. But, if a users messes with something on the Kube side, we would never know.

I can do that as mentioned here.  The concern is this is running every 15 seconds or so based on how much other work there is in the monitor loop so I wanted it local to avoid conversions of their format to ours in order to do comparisons with our "desired" state".  I can look to see how much work that is.

Tests are failing due to red master currently.

This is ready for review again.

Since this included some refactoring, I labeled this for kasparov but not jansa.

Since this included some refactoring, I labeled this for kasparov but not jansa.


Single-use encryption key for every photo / file

Flagging this here, @andrewxhill mentioned a protocol he came across that creates a keypair for each file and thought it could possibly solve some issues for us... what was is called?

so the primary one is DAT, where they use the link to the file as the password itself

Dug into DAT pretty far, super cool project! There's a bunch of these: https://livingthing.danmackinlay.name/synchronising_files.html
Of course, since we're IPFS based, our file links are predetermined. We could definitely construct our own links / protocol layer for easy sharing like DAT... which seems like a killer idea

renamed this issue to reflect the work, also gave a v2 label so we can group these tasks under a common design goal.


Bug: can't translate a certain section in GitLocalize

Steps to reproduce the problem

Go to https://gitlocalize.com/repo/7494/pt/notebooks/intro/what-is-quantum.ipynb
Scroll down to the double slit experiment section
Normally I just click the text and it will allow me to edit that text section. Not this time though

What is the current behavior?
Can't edit section in GitLocalize
What is the expected behavior?
when clicked, it should allow one to edit the text translation.
Screenshots
No response
Device
laptop
OS
MacOS 10.15
Browser
Chrome
Additional information
No response

So, this is what the Gitlocalize support said just now:

Hi Omar, aparently this is a bug, and I've forwarded this to our dev team. Sorry for the long wait. May I suggest you try contributing in a different file?

@omarcostahamido Thank you for pointing this. This is a very well known gitlocalize bug so please DM me for the further issue.


Android: Target API level 28

We received the following warning from Google Play regarding the target API level. This task is to investigate and resolve

Your app currently targets API level 27 and must target at least API level 28 to ensure it is built on the latest APIs optimized for security and performance.
From August 2019, new apps must target at least Android 9.0 (API level 28).
From November 2019, app updates must target Android 9.0 (API level 28).
Change your app's target API level. Learn how.
https://developer.android.com/distribute/best-practices/develop/target-sdk.html

Had significant issues once I updated the target SDK to API 28 with it being no longer able to communicate with the metro blunder. Followed solution outlined at https://github.com/facebook/react-native/issues/22024 to fix the problem. Also updated gradle and build tools.
4edff38039325d63a8d758d600c0ca534608da1b

Thanks for the update Vishant. We are going to explore the RN 0.59 upgrade first and revisit this after that conversation.

Completed in #541


topic policys not effective

Describe the bug
Not allowed to set/get topic policy for a partition

But use the partition name to get the policy

Should be revised to：
TopicName cloneTopicName = topicName;
if (topicName.isPartitioned()) {
cloneTopicName = TopicName.get(topicName.getPartitionedTopicName());
}

Should be revised to： TopicName cloneTopicName = topicName; if (topicName.isPartitioned()) { cloneTopicName = TopicName.get(topicName.getPartitionedTopicName()); }

Ah , this is broker side internal to update topic policy. it's ok, because it registers as brokerService.getPulsar().getTopicPoliciesService()                     .registerListener(TopicName.getPartitionedTopicName(topic), this);
But it doesn't allow user to set different partition with different policies.


Error while trying to connect to a Google Cloud SQL instance using ssl.

We are hosting our MySQL instance in Google Cloud SQL and we use ssl. Our pool is configured like this:
pool = tormysql.ConnectionPool(
    max_connections = 20, #max open connections
    idle_seconds = 7200, #conntion idle timeout time, 0 is not timeout
    wait_connection_timeout = 3, #wait connection timeout
    host = "{GCP_SQL_IP}",
    user = "user",
    passwd = "pass",
    db = "production",
    charset = "utf8",
    ssl = {
        "ca": "/path/to/server-ca.pem",
        "key": "/path/to/client-key.pem",
        "cert": "/path/to/client-cert.pem",
        "check_hostname": False
    }
)

The error out of tornado is:
Traceback (most recent call last):
  File "app.py", line 34, in <module>
    ioloop.run_sync(test)
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/ioloop.py", line 582, in run_sync
    return future_cell[0].result()
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/concurrent.py", line 260, in result
    raise_exc_info(self._exc_info)
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/gen.py", line 1107, in run
    yielded = self.gen.throw(*exc_info)
  File "app.py", line 24, in test
    tx = yield pool.begin()
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/gen.py", line 1099, in run
    value = future.result()
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/concurrent.py", line 260, in result
    raise_exc_info(self._exc_info)
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/gen.py", line 1107, in run
    yielded = self.gen.throw(*exc_info)
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tormysql/helpers.py", line 203, in begin
    connection = yield self.Connection()
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/gen.py", line 1099, in run
    value = future.result()
  File "/home/cory/.local/share/virtualenvs/tortest-C-kyhIye/lib/python2.7/site-packages/tornado/concurrent.py", line 260, in result
    raise_exc_info(self._exc_info)
  File "<string>", line 3, in raise_exc_info
pymysql.err.OperationalError: (2003, "Can't connect to MySQL server on {GCP_SQL_IP}:3306 (OperationalError(2013, 'Lost connection to MySQL server during query'))")

And the error in the SQL logs is:
{
    severity:  "ERROR"
    textPayload:  "2018-04-03T18:33:14.500739Z 166871 [Note] Aborted connection 166871 to db: 'production' user: 'cory' host: '<IP_ADDRESS>' (Got an error reading communication packets)"
    timestamp:  "2018-04-03T18:33:14.500917Z"
}

I can make a successful query if don't use ssl
I can make a successful query if I use ssl and only pymysql without tormysql's connection pool, but configure it in the same way.
Originally discovered with tormysql==0.3.6 and tornado==4.5 but also confirmed for 0.3.7/5.0

So my guess is that there is a bug with how tormysql uses ssl when it creates a connection pool of pymysql connections.

Thanks, I will test it.

Already fixed, you can follow the new version and thanks for feedback.

Thank you so much for the quick turn around.
Currently we are still on Tornado 4.5. If you wanted to back patch this to 3.6.1 I would love it. But we have a plan to get to 5.0 soon so we'll get there eventually.


Notification of Husqvarna: use Event-format-V2

Hi,
I just received a notification from Husqvarna related to their phasing out of Event-format-V1

Dear User of Husqvarna Group Developer Portal. We want to inform you that we will launch our new IoT-backend in March 2025. Our current solution has grown old and earned its retirement. This will be a breaking change for those who are using our current solution, and you will need to change your apps according to the below information. The updated solution will be available from 20th December 2024. We will simultaneously run both solutions until 28th February 2025. After this the current version will be removed and only the updated version will be running. Please see the new event format here: Event-format-V2

Is the current plugin version already using the new event format ?
Best regards,
Michel
Environment:

Plugin Version: Event-format-V2
Homebridge Version: v1.8.5
Node.js Version: v20.17.0
Operating System: macOS / hb-service

It is not, and I got the same email. Looks like I’ve got some work to do. My mower is parked for the winter too, so I can’t test it either.
Thanks for reaching out, I’ll start digging in.

And mine is at the shop for yearly maintenance. Bad timing from Husqvarna to phase out in the winter 😟😟

Finally started to dig into this, unfortunately due to Husqvarna using version 1 for both their V1 and V2 versions of the same API, the plugin is likely going to have to break, and be released after they roll out the new version. They're touching both the normal APIs as well as their streamed updates and the two likely won't be compatible with each other.
Best case scenario is update the code early, test it after they've released their change, and then release my update with the changes in place. Given my mower will be parked until spring, I'll be limited to a preview release but that's it.
If they'd done a v2 endpoint with all the v2 changes isolated, we wouldn't be forced to break but alas that isn't the case and there's nothing I can do about it.

Wow, that is not cool of Husqvarna :-( Having read (quickly) https://app.qa-developer-portal.dss.husqvarnagroup.net/apis/automower-connect-api?tab=websocket v2 I thought only the WebSocket stuff will be migrated (from WebSocket to WebSocket V2), and that in the transition period (from 20-dec-2024 till 1-mar-2025), both events (deprecated and v2, for instance "positions-event" and positions-event-v2) will be transmitted simultaneously, allowing the client applications to use the one they are able to process (so if the application understands already v2, it uses that one); for me the approach of not creating a new v2 endpoint was done to be able for applications to gradually implement the new events, without the need to do the whole move at once. Seems I was a bit too confident about how they implemented the move I guess :-(

Yeah they didn’t only change their streaming events, the public API also changed to match some of their new event models and it’s just not worth trying to support both at once for only a few months when I can’t test it anyway.
The V1 of their API can return either V1 model or V2 model which isn’t compatible with V1. They didn’t version their API routes to v2 either so I’d just be guessing where the data is located for a very short runway.
I’m just working to jump straight to V2 at this point and not support both simultaneously.

OK, that seems to be the best approach. I am here for testing, but I do not know when I will get back my mowers (usually, the shop prepares them around end of January, but I need anyway to wait March for starting them. So, take your time and enjoy end of year quality time !!


control_camera topic

Is camera_control topic working correctly ? According to
https://media.readthedocs.org/pdf/bebop-autonomy/latest/bebop-autonomy.pdf
to  move  Bebop’s  virtual  camera I should  publish  a  message  of  type  geometry_msgs/Twist  to
camera_control topic. But then the topic requires a message of type std_msgs/Empty that does not allow to control the camera
~/catkin_ws$ rostopic info /bebop/camera_control
Type: std_msgs/Empty
Publishers: None
Subscribers:

/bebop/bebop_driver

I can not reproduce the issue locally. Could you please list the steps to reproduce the bug (incl. the target platform, firmware and driver version)?

I am simply trying to take off and then to move the camera in order to look the ground. So the command is:
rostopic pub -r 1 /bebop/camera_control geometry_msgs/Twist -- '[0.0, 0.0, 0.0]' '[0.0,0.5,0.0]'
This seems not possible since the camera_control topic requires Empty messages.
bebop drone with software 2.0.57
driver bebop autonomy 0.5.1
linux ubuntu 14.04 - Ros Indigo
thanks

It is a bit odd. Could you please:

Share the result of rosnode info on bebop driver node?
Share a picture of your ROS computation graph using rqt_graph?

Did you have a chance to confirm the issue?

This is fixed in d43463c44775fced1c6277aa5bf3c9ba95a490ec


Fix rendering for meshes that uses transparent textures

The image below speaks itself

Tested with several maps, looks good!


Carousel binding on current_slide is called twice with the same value

Versions

Python: 2.7.15
OS: Arch Linux (seen also on Android)
Kivy: v1.11.0.dev0, git-a95d67f, 20190316
Kivy installation method: pip

Description
A callback binded on Carousel.current_slide is called several times with the same widget, but a property binding should not call again a callback if its value didn't change.
Code and Logs
from kivy.app import App
from kivy.uix.carousel import Carousel
from kivy.factory import Factory
import sys

class TestBinding(App):

    def build(self):
        self.last_slide = None
        carousel = Carousel(direction='left',
                            loop=True)
        carousel.bind(current_slide=self.on_current_slide_change)
        for i in range(4):
            src = "http://placehold.it/480x270.png&text=slide-%d&.png" % i
            image = Factory.AsyncImage(source=src, allow_stretch=True)
            carousel.add_widget(image)
        print("TEST SUCCEEDED")
        sys.exit(0)

    def on_current_slide_change(self, __, new_slide):
        print("new_slide: {}".format(new_slide))
        if new_slide == self.last_slide:
            print("TEST FAILED (slide {} added twice)".format(new_slide))
            sys.exit(1)
        self.last_slide = new_slide

TestBinding().run()

Already addressed in PR #6055
See https://github.com/kivy/kivy/pull/6055/files#diff-a9976c886d7dcfe267c69353a5a433f8

@tito cool :). Should I close the ticket, or let it until it's merged so we can try the test script?

I'm letting the script open to convert it as a unittest :)


fix .NET Denial of Service Vulnerability

https://msrc.microsoft.com/update-guide/vulnerability/CVE-2022-21986

:white_check_mark: Build TheIdServer 4.3.2-ci.1+21.build.1887 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/8bfb2c206d by @aguacongas)


diffs are not present in HC light theme

set color theme to be HC light
make some changes in a file
see gutter decorations, but none in the editor
switch themes, see the diffs

https://github.com/microsoft/vscode/assets/29464607/867fd555-d2ac-42cd-82c3-b9470df1ca13

actually, I just noticed they are. But they're extremely hard to see...


Create memberships

Create membership model and controller for the athletes-boxes relationship.
Todo:

[ ] Tests for memberships (add tests to athletes and boxes, too)
[x] Membership types (Owner, Coach, Member, Guest)

For Membership Types, I was thinking that I will need to create another model (MembershipType) that holds the various type. I will need to look into this more to see if there is a better approach.

I think it would be best to use an enum for this. A model is overkill for what is needed.

For Membership Types, I was thinking that I will need to create another model (MembershipType) that holds the various type. I will need to look into this more to see if there is a better approach.

I think that it would be best to use an enum for this. A model is overkill for this.

I also went ahead and added permission levels. This will mainly be for use by the coaches (if you want a coach to adjust due dates or just see due dates). The basic level will be for guests and members.


[Question]: How llama-index can handle a large table?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I use llama-index for the Table QA task and have some questions about that.
Case: When I use embedding table by OpenAI, my table contains about 44k tokens. But when I ask the question with function as_query_engine(), I analyst that my question just 40-50 tokens but in my Usage in OpenAI recognize that my question is 2000-2050 tokens. Also, I see that llama-index has default_prompts.py, which contains various prompt, but when I analyst my question + default_prompts ~ 2050 tokens.
Question: So how OpenAI notices my table?

@hoangpnhat for QA on tables, you could probably use - Text2SQL approach - https://docs.llamaindex.ai/en/stable/examples/index_structs/struct_indices/SQLIndexDemo.html

@ravi03071991 thank you for noice my question. But I just want to know where and how LLama-index push my table into content for LLM (in my case is OpenAI) to answer my question.

@dosu-bot , The token from my table is around 44000 tokens.

@hoangpnhat You can count the tokens with the help of callback manager - https://docs.llamaindex.ai/en/stable/module_guides/observability/callbacks/token_counting_migration.html


X-axis Date Overlap

Hi fellow developer!
Before sending an issue, please consider Stack Overflow.
Tag your question with swiftcharts: http://stackoverflow.com/tags/swiftcharts/info.
Also, check https://github.com/gpbl/SwiftChart#common-issues-and-solutions
Thanks!
Hi,
I pass the date like one date of 2015 and more than 8 date of 2016 year with the spacing of 2 days.
On the chart I get the half of the chart with value of 2015 and in another half it shows the value of 2016. This make the UX inappropriate. Please look a screenshot in attachment.

I am getting something very similar to this, if this can be explained as soon as possible, that would be great

@RichAppz, @AshYadav1, @gpbl
Have you guys found a solution to this?


Flame On does not display result

Hi, I'm testing flame_on on my local server but it doesn't display profiling result and it uses too much memory.
Dependencies
      {:phoenix, "~> 1.6"},
      {:phoenix_ecto, "~> 4.0"},
      {:phoenix_live_dashboard, "~> 0.6.5"},
      {:flame_on, "~> 0.3"},
      {:telemetry_metrics, "~> 0.4"},
      {:telemetry_poller, "~> 0.4"}

Environment

Macbook M1
Elixir: 1.13
Erlang: 24.1.4

It uses too much memory

Capturing timeout

Some strange output on console
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :return_to, {Jason.Encode, :map_naive_loop, 3}, {1647, 489616, 144705}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :return_to, {Jason.Encode, :map_naive_loop, 3}, {1647, 489616, 144706}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :gc_minor_start, [wordsize: 2, old_heap_block_size: 196650, heap_block_size: 28690, mbuf_size: 1168, recent_size: 187, stack_size: 155, old_heap_size: 81714, heap_size: 28534, bin_vheap_size: 105, bin_vheap_block_size: 46422, bin_old_vheap_size: 5583, bin_old_vheap_block_size: 46422], {1647, 489616, 145129}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :gc_minor_end, [wordsize: 28251, old_heap_block_size: 196650, heap_block_size: 28690, mbuf_size: 0, recent_size: 1354, stack_size: 155, old_heap_size: 81811, heap_size: 1354, bin_vheap_size: 12, bin_vheap_block_size: 46422, bin_old_vheap_size: 5619, bin_old_vheap_block_size: 46422], {1647, 489616, 145130}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :return_to, {Jason.Encode, :map_naive_loop, 3}, {1647, 489616, 145134}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :return_to, {Jason.Encode, :map_naive_loop, 3}, {1647, 489616, 145135}}
[info] Received unexpected trace event: {:trace_ts, #PID<0.4454.0>, :return_to, {Jason.Encode, :map_naive_loop, 3}, {1647, 489616, 145136}}

Do I miss any configuration to make it work?
Thanks

https://github.com/DockYard/flame_on/issues/7
I believe your issue is also related.  Can you increase the timeout to 60000 and see if it works or if you get different log outputs? The :gc_ and :return_to entries are not problems and can be ignored.  Also can you verify if any .bggg files are generated in your project after running it?

@gaslit Can you post any log entries that happen when the bggg file is created successfully (you can omit :gc_ and :return_to lines).

@bluzky how large of a call are you profiling? Can you increase the timeout to 60000 and see if it works or if you get different log outputs? The :gc_ and :return_to entries are not problems and can be ignored. Also can you verify if any .bggg files are generated in your project after running it?

I tried capturing default cowboy_handler and change timeout to 60_000 but it still not display result.
I checked I saw that a<PHONE_NUMBER>062327-eflambe-output.bggg was generated it's only 1.3MB

@bluzky how large of a call are you profiling? Can you increase the timeout to 60000 and see if it works or if you get different log outputs? The :gc_ and :return_to entries are not problems and can be ignored. Also can you verify if any .bggg files are generated in your project after running it?

I tried capturing default cowboy_handler and change timeout to 60_000 but it still not display result. I checked I saw that a<PHONE_NUMBER>062327-eflambe-output.bggg was generated it's only 1.3MB

Hi are you able to open it in speedscope.app? Does it render correctly?
I have a suspicion it has to do with the LiveComponent but nothing conclusive despite digging into a local copy of the library.

Hi are you able to open it in speedscope.app? Does it render correctly?
I have a suspicion it has to do with the LiveComponent but nothing conclusive despite digging into a local copy of the library.

Thank you for helping.
I create a new Phoenix project and Flame_on works. Maybe there are some issue with my existing umbrella project.
I will investigate more on my project.

I'm having the same issue (M1 but no umbrella app), I'm having various unexpected trace events, like
Received unexpected trace event: {:trace_ts, #PID<0.1073.0>, :return_to, {Enum, :"-map/2-lists^map/1-0-", 2}, {1648, 206716, 484641}}
Have not yet investigated with a fresh phoenix project.

I'm having the same issue (M1 but no umbrella app), I'm having various unexpected trace events, like
Received unexpected trace event: {:trace_ts, #PID<0.1073.0>, :return_to, {Enum, :"-map/2-lists^map/1-0-", 2}, {1648, 206716, 484641}}
Have not yet investigated with a fresh phoenix project.

Update: on a fresh phoenix liveview project it works (tracing some dummy liveview mount/3 function). Very weird, the liveview versions are the same.

I did have the same problem in my app, so I tried with a fresh Phoenix 1.6.6 project. The flame graph is shown but I do see a lot of warnings.  Just a heads up that I am currently working on #11 which should either resolve these issues directly or give us the tools to be able to diagnose them. I will return to check with you all on this issue once that work is complete.

@bluzky @jaimeiniesta @dvic @gaslit I have a PR (#12) up for the engine rewrite. If you have a chance, could you update your deps and let me know if you have success on the new branch?
      {:flame_on, github: "DockYard/flame_on", ref: "mb-engine-rewrite"},

It works for my usecase without any errors! Niceeee 👍

Superb. Works perfectly. Many thanks for your hard work.
Quick question: Is it possible that you do not delete the generated bggg files as having a local copy will be tremendously useful. For simplicity, you can select the most recent one in the directory for rendering. I doubt many will object.
Thank you for your kind consideration.

Thanks @TheFirstAvenger - it works much better now, I don't see any warnings when profiling a controller.
However I see crashes when profiling one of our LiveViews. It works with other views, but it crashes on this one with this:
https://gist.github.com/jaimeiniesta/0fc76270edfa4d39b6a147e1f79ef76f

@gaslit Good question. With the new engine, there is no .bggg file. In the old engine, eFlambe would capture the trace and generate the .bggg file, then FlameOn would read, parse, and display the data from the file. The new engine skips this altogether and captures the data directly from the trace. I have added #13 as an enhancement request to generate a .bggg file from a Flame On capture. I will tackle that once the engine rewrite is released.

@jaimeiniesta Thanks for the issue report. I have pushed a fix to the branch that should resolve that error. Please update and let me know if that specific LiveView now renders correctly.

@TheFirstAvenger thanks for the update! That error is now gone, but now I see a different error, I've added it as crash2.txt in the gist.

@TheFirstAvenger sure, I added it as crash3.txt in the gist. It was a huge log, I just pasted the latest lines.

@jaimeiniesta Ok try now. :set_on_spawn was enabled, causing tracing to happen in secondary processes, which broke the stack, as return_to's didn't match in linear order with calls. I disabled it, which means you will only see a flamegraph for the primary process (and a :sleep block if it is waiting on a receive). If we do decide to do something with graphing secondary processes, it will need a design pass to architect it in a useful way (if that is even possible with a flamegraph... 🤔 ).

@TheFirstAvenger hey thanks, it now works! This live view doesn't make it crash anymore. 🚀


Declaring a function with name ''then" makes vitest runner to halt

Describe the bug
It seems that some special names some special function names cause vitest to halt the test run.
In this case the problem is a function called then but I think that the problem also happens with names like it and others that I can't remember. I also think that the problem happens with any identifier: variables, classes, functions, etc
Reproduction

Go ahead and clone https://github.com/pbalenzuela/vitest-problem/commits/main/
install dependencies using pnpm

run pnpm vitest
test runs and passes

reset to the commit that shows the problem

git reset --hard 7d4a9d002e754e0ee7ffea6f2625afb623d75a0f
run pnpm vitest
test runners does't provide any feedback, gets stuck and doesn't finish

System Info
System:
    OS: macOS 15.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 67.91 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.16.0 - ~/.nvm/versions/node/v20.16.0/bin/node
    npm: 10.8.1 - ~/.nvm/versions/node/v20.16.0/bin/npm
    pnpm: 9.12.3 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 130.0.6723.91
    Safari: 18.1
  npmPackages:
    vitest: ^2.1.4 => 2.1.4

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Duplicate of https://github.com/vitest-dev/vitest/issues/5122, see https://github.com/vitest-dev/vitest/issues/5122#issuecomment-2406488169.

do you have no way to do anything but an infinite loop at this point? a test suite that silently hangs on an internal error is failing at its one job

it may be important to note that it works perfectly fine in non-vitest scenarios

Vitest transforms the static imports into dynamic ones when run on Node. When you run script below on NodeJS, you can see how weirdly even Node works when you have named export then:
import { writeFileSync } from "node:fs";

writeFileSync("./first.mjs", `export const example = "first"`);
await import("./first.mjs").then((mod) => console.log("First:", mod));

writeFileSync(
  "./second.mjs",
  `
export const example = "second";
export async function then() {};
`
);

await import("./second.mjs").then((mod) => console.log("Second:", mod));

$ node index.mjs
First: [Module: null prototype] { example: 'first' }
# Where's second?

It's recommended to follow MDN's advice and not export then from modules: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import#module_namespace_object

do you have no way to do anything but an infinite loop at this point?

Not sure about that, maybe not. But at least on Node v22 you should see following warning:
$ node index.mjs
First: [Module: null prototype] { example: 'first' }

Warning: Detected unsettled top-level await at file:///x/x/x/repros/then/index.mjs:23
const second = await import("./second.mjs");


Add Mem0 docs

Why are these changes needed?

Related issue number

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

@microsoft-github-policy-service agree company="Mem0"

@Dev-Khant thanks for the PR. we would love to have this implementation in a notebook. can you please put the working code on the notebook.

Hi @Hk669, Thanks for reviewing the PR. I have added the colab notebook link, please check.
Let me know if any more changes are required. Thanks!

Hi @Hk669, Thanks for reviewing the PR. I have added the colab notebook link, please check. Let me know if any more changes are required. Thanks!

thanks for adding in the link, we would love to have the notebook in the repository. this should help you: https://github.com/microsoft/autogen/blob/main/notebook/contributing.md#how-to-get-a-notebook-displayed-on-the-website

love mem0 and taranjeet tools :-)

Hey @Hk669 I added the notebook.

Hey @Hk669 I added the notebook.

pre-commit to fix the code formatting. thanks

Hey @Hk669 I added the notebook.

pre-commit to fix the code formatting. thanks

Sorry, I forgot about it. It's done now.

@Dev-Khant  -- can you also please improve the description of this PR to explain what this PR is doing. Useful to do that in general to speed up the review process.

Thank you @Dev-Khant for the PR. I've two quick questions.

Why there are changes to autobuild_agent_library.ipynb and lats_search.ipynb?
Can we add memory to Mem0 inside a chat conversations? In the examples, it looks like we can only retrieve memory. Would you like to add support to adding memory automatically? I believe that would bring more value to the users.

Hi @thinkall Thanks for reviewing the PR. Answers for your questions:

autobuild_agent_library.ipynb and lats_search.ipynb were affected because of pre-commit checks. Do you want me to remove these files?
Yes we actually wanted to do that but the issue we faced was right now it's not easy to directly alter with input messages for agents, for that we have to update the ConversableAgent class methods to support Mem0. We still wanted to explore the best way to integrate Mem0 with Autogen so we prepared this base example for users to get started.

Please share any feedbacks or suggestions on how can we use Mem0 inside chat conversations.

@Dev-Khant -- can you also please improve the description of this PR to explain what this PR is doing. Useful to do that in general to speed up the review process.

Sorry my bad, should have written proper description. Will take care of this from now on!

@thinkall We were already planning to extend the ConversibleAgent class itself, but still, we wanted to explore the best way to integrate Mem0 with Autogen so we prepared this base example for users to get started.

@gagb Please let me know if anything is pending from my side for the PR. Thanks!


Affiliates

Affiliates done. 100% coverage, events covered as well.
Also fixed js tests issues due to migration to hardhat and set correct objects where LoanClosings was used: now it is split into LoanClosingsBase and LoanClosingsWith, both behind the proxy, but needs to be applied to other branches that had been checked out before.

moved over to https://github.com/DistributedCollective/Sovryn-smart-contracts/tree/affiliates_v2


Fix broken Mynewt BOOTUTIL_ -> MCUBOOT_ mapping

Fix mapping of syscfg.yml BOOTUTIL_* vars to C #defines, which was broken
on most .c files for lacking inclusion of mynewt "config.h"

I'm merging this because it's a straight-forward change, which fixes a broken Mynewt build when using signing.


DOC: wrong prompt hub link

Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:

reduce_prompt = hub.pull("rlm/map-prompt")
reduce_prompt

https://python.langchain.com/v0.1/docs/use_cases/summarization/#option-2-map-reduce
hub.pull("rlm/map-prompt")  should be hub.pull("rlm/reduce-prompt")
Idea or request for content:
No response

I'd like to tackle this!


Stacking / grouping items from same collection in explorer / bundles / spammy collection

In explorer when we are showing items, it's pretty useless for user to see many same items from one collection and it acts as visual spam.  "antispam card"
I propose these filters in particular order

using same IPFS hash - that classify definitely will be same visual item
same price - indicates from one serial mint - if someone sets same price from minting, whatever.
only one transfer (can still be some kind of airdrop from whitelist/allowlist)
any other filters?

📟 @vikiival I guess we would need resolver for this kind of inspection on explorer to get reply faster from squid?
Design

we are going to replace multiple duplicated content with one card

updated explore v0.9 figma: https://www.figma.com/file/OwAEyE0QDPn3tHXZbyot1o/Explore-v0.9?node-id=0%3A1&t=ezFOQUs4vhM0Txeu-1

Basics

since we don't have a listings tab, this card will be only visible in explore/items
card will show the name of the duplicate nft - when nft would be the same (img, description...) except name (Name #.23 and name #.45) is it possible to use this card as well - but without the number at the end?
how many times the nft is duplicated
floor price of all the same nfts
collection name, the imgs are from
visit button
there is also small card:

used only on smaller previews
absence of floor price, otherwise working similarly

Functionality

the nft card will work the same as other nft card
stroke to the most contrast color in the mode + opacity overlay
if you click the nft img, it will redirect you to the collection
same with collection name and view
basically it's a shortcut to collection

I would propose start doing this globally or at least on rmrk and rmrk2 as there is massive amount of spam items and we want to highlight good collections

can test with
https://beta.kodadot.xyz/rmrk2/u/DkjzQrt7U5WN66STqXmXeQYZkcd2mZuUqzncjXwDCck2wUQ?tab=collection

Lmk if you have any questions 🚀

Yes please open issue in kodadot/loligo as this needs to be implemented across indexers

kodadot/loligo#4

Can be tested with this one for example

https://beta.kodadot.xyz/rmrk2/gallery/15872737-9ea8d4ad827797a01e-LEGENDS-MYSTERIOUS_INVITATION-00000030
https://beta.kodadot.xyz/rmrk2/gallery/15872737-9ea8d4ad827797a01e-LEGENDS-MYSTERIOUS_INVITATION-00000031

🥹

https://canary.kodadot.xyz/rmrk2/gallery/17434649-3cdf41f721e728d969-GEAR-HONGKONG-nft-00000121

https://opensea.io/collection/metaline-mysterybox
https://opensea.io/assets/arbitrum/0x3ecc587ef402b5e00a9767d6f9670b463de2e177/8589934603

https://github.com/kodadot/stick/pull/31

Grouping by same IPFS link pls?

https://kodadot.xyz/ahk/explore/items?listed=true&page=2

@exezbcz  what about "buy now" / "list now" on stacked cards?
my guess is these buttons shouldn't be on stacked card since it isn't representing a single item
wdyt?

what about "buy now" / "list now" on stacked cards?

I would personally take the cheapest from the stack.

my guess is these buttons shouldn't be on stacked card since it isn't representing a single item

its representing multiple "same items"

its showing the floor price as well.

I would keep all the button same as with normal item

when clicking cart - It will add the cheapest one in the stack - I think this could be added in V2, I will also create a visual indicator for the stacked card
when clicking buy now - open modal with cheapest item

with listing, I would enable this as well.
On profile, its showing items you own, imagine you have like 300 of them (no matter whether you are the owner or creator + owner), you want to list them.

When clicking this stacked img, that represents all the items you own and are the same, all the item that don't have price will be added into mass list popup.
then the flow is the same

wdyt?

reopen if this got merged?

https://github.com/kodadot/nft-gallery/pull/7482

Yep. I'm working on reimplennting it on the indexer side, so we can have sensibly query

PR coming soon

Thanks @vikiival
Fe pr is about a day away
After that next steps will be to implement indexer side on kusama


fix documentation of composite-merge (x1,y1), (x2,y2)

This fixes a disconnect between the documentation, which says (x1, y1), (width, height), and the behavior of the function, which treats the input as (x1, y1), (x2, y2). This changes the documentation to match the current behavior.

Thank you for the update. Merging.


decide how to show profile

page? modal? part of the overview?

I would like to integrate it into the overview page with a flag.


Review logs, save spawner and backend docker logs

Dont forget to do it in v2  with the change spawner --> flow initiator

But we don't have a platform pipeline in v2 yet (?)


Add wordbreak character support [RTL-8689]

Pull Request Checklist

Components modified

[ ] copy-service
[x] html-evaluator
[x] plain-text-evaluator
[x] react-evaluator

Version change
We use Semantic Versioning 2.0

[ ] Major - Non-backwards compatible changes
[ ] Minor - Backwards compatible changes
[ ] Patch - Backwards-compatible bug fix
[ ] None - Internal changes

Procedural Steps
All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/NextCapital/copy-service/blob/main/CONTRIBUTING.md#dco-sign-off-methods
Notes:
TODO: Fill in

Putting this up to get some eyes on it since I'm not the most familiar with this project
A few key things that already arose in this PR between what me and Mike had handed off this morning

Originally we had wanted to use \w for this instead of \b. However as I was developing, copy kept blowing up because \w is not recognized by javascript. I used \b for this since it seemed like it was not a frequently used escape character but I'm open to other suggestions for what I should use
I'm not totally sold that this is the approach we should take. I was seeing the <wbr> tag in the chrome dev console but it didn't seem to have an impact on this. This is a public repository so I can't link the screenshot but I can DM it

Seems fine to me.

Hmmm I'm not sure what I'm doing wrong here with the builds and tests. Both commands are working for me locally


Av1an aomenc buffer overflow

Describe the bug
When encoding a video with av1an the default aomenc encoder always crashes with a bufferflow error. SVT-AV1 works fine with the same file.
WARN [av1an_core::broker] Encoder failed (on chunk 0):
encoder crashed: signal: 6 (SIGABRT) (core dumped)
stdout:

stderr:
        Warning: automatically updating bit depth to 10 to match input format.
        *** buffer overflow detected ***: terminated

Steps To Reproduce
Steps to reproduce the behavior:

open nix shell on commit hash 5e0ca22929f3342b19569b21b2f3462f053e497b, because of Rust 1.80 issues
av1an -i <any_video_file> -o test.mkv
Wait through scene analysis and watch it break when starting encoding.

Expected behavior
The video is encoded without issue.
Additional context
I tried to reproduce it in an arch linux container, but the arch package works without issue. So it seems this is a nix issue. Aomenc itself works fine with y4m generated ffrom ffmpeg.
Notify maintainers

@getchoo
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.3-xanmod1, NixOS, 24.05 (Uakari), 24.05.20240806.21cc704`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/pi3i4rcxl8iadwxpyyx481ycnyxm856b-source`

Add a :+1: reaction to issues you find important.

I'd imagine this is an issue with our build of libaom itself (or an upstream bug) rather than av1an, especially since you mention other encoders work fine and the log here is also blaming the encoder

I did some further testing and can reproduce the buffer overflow just with aomenc, by just inputting a webm file like so aomenc test.webm -h 2160 -w 3840  -o test_out.webm. This is especially strange as aomenc is not intended to be used that way. You are normally supposed to input y4m files. However, the aomenc inside this arch container will do it anyway, while the nix version crashes with the buffer overflow.

I should probably add libaom maintainers as well. @primeos @kiloreux @dali99


[WIP] Overhaul of CART Chapter

This PR aims to improve the lecture slides of the CART chapter.
It should include (not exhaustive):

[x] Better and replicable visualizations
[x] A general style and contents overhaul
[ ] A summarizing "In a nutshell" chunk that can serve as both, a primer and a summary

Tree overhaul for all chapters apart discussion including new graphics and visualization files


App fails...in spanish version? (or other languages)

I have tried in english and spanish version and in spanish fails for all the versions. This is the message:
"Revit no puede ejecutar aplicación externa "Application WhatTheDynamo". Solicite asistencia a su proveedor.
Información proporcionada a Revit sobre su identidad:
Design Tech Unraveled, http://designtechunraveled.com.
System .NullReferenceException
System.NullReferenceException: Referencia a objeto no establecida como instancia de un objeto.
en WhatTheDynamo.App.OnStartup(lJlControlledApplication a)
Autod esk.Revit.lJl .RevitM anagedAppStartupAgency .RevitManagedAppStapControlledApplication, AString* assemblyName, AString* className,AString* exceptionName, AString* ExceptionMessage)"

You can solve with a dictionary i gess...
// Create a dictionary to map names in different languages
Dictionary<string, string[]> names = new Dictionary<string, string[]>()
{
    { "English", new string[] { "Manage", "Visual Programming", "Dynamo" } },
    { "Spanish", new string[] { "Gestionar", "Programación Visual", "Dynamo" } },
    // More languages...
};

// Get current user interface language
string currentLanguage = // Code to get the current language...

// Search for the button by name in the current language
string[] buttonNames = names[currentLanguage];
RibbonItem button = null;
foreach (var language in names.Keys)
{
    buttonNames = names[language];
    button = Utilities.GetButton(buttonNames[0], buttonNames[1], buttonNames[2]);
    if (button != null)
    {
        break;
    }
}

Thanks for reporting! I will probably go ahead and look at hardcoding the tab and panel id instead of the name. Localization for other languages was on my todo list anyway, so I will make this part of that effort.

This is fixed in v1.0.2 and is available on the Gumroad page here: https://johntpierson.gumroad.com/l/whatTheDyn
Also includes localization now with other languages in the UI!


x/tools/cmd/guru: definition doesn't look up the function references in the same package if modules are enabled

What version of Go are you using (go version)?

go version go1.12.4 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build666000922=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Given the files a.go and b.go defined in the same package, guru definition isn't able to find the method that is defined in the same package but in different file if go.mod is present and the project is outside of GOPATH.
a.go
package a

func TestA() {
	// do nothing
}

b.go
package a

func TestAA() {
	TestA()
}

Then with if the files are in the $GOPATH/src/test/guru_mod_files/a/ the command
guru definition /home/user/go/src/test/guru_mod_files/a/b.go:#30

returns
/home/user/go/src/test/guru_mod_files/a/a.go:3:6: defined here as func TestA()

however if the package is moved out of $GOPATH, then it doesn't work as expected:
guru definition /home/user/tmp/guru_mod_files/a/b.go:#30
guru: no object for identifier

What did you expect to see?
Proper function definition from the other file in the same package.
What did you see instead?
guru: no object for identifier

Some quick fix to consider, at the first glance it works ( tested on several modules I tried so far ). And looks pretty logical, given that CreateFromFilenames is meant to take several files.
diff --git a/cmd/guru/guru.go b/cmd/guru/guru.go
index 8dea3b53..f4c2fb26 100644
--- a/cmd/guru/guru.go
+++ b/cmd/guru/guru.go
@@ -20,6 +20,8 @@ import (
 	"go/types"
 	"io"
 	"log"
+	"os"
+	"path"
 	"path/filepath"
 	"strings"

@@ -164,7 +166,24 @@ func importQueryPackage(pos string, conf *loader.Config) (string, error) {
 		// Can't find GOPATH dir.
 		// Treat the query file as its own package.
 		importPath = "command-line-arguments"
-		conf.CreateFromFilenames(importPath, filename)
+		dirPath := path.Dir(filename)
+		dir, err := os.Open(dirPath)
+		if err != nil {
+			return "", err
+		}
+		defer dir.Close()
+		fis, err := dir.Readdir(-1)
+		if err != nil {
+			return "", err
+		}
+		files := make([]string, 0, 1)
+		for _, fileinfo := range fis {
+			if fileinfo.IsDir() {
+				continue
+			}
+			files = append(files, path.Join(dirPath, fileinfo.Name()))
+		}
+		conf.CreateFromFilenames(importPath, files...)
 	} else {
 		// Check that it's possible to load the queried package.
 		// (e.g. guru tests contain different 'package' decls in same dir.)

CC @ianthehat

As mentioned on the linked cl, we have chosen not to convert guru to work with modules because we feel the effort required is too large and are focusing on gopls as a better solution instead.
If anyone wants to contribute a true port of guru to modules please to re-open this bug and send us the changes.

You can simlink things around, based on that go mod tidy or go get produces. To w/a this issue I created a bash snippet https://gist.github.com/bogdando/d15cf014f3171a9ae06b83cd9c9b1c26 and it seems working for me, more or less...

not to convert guru to work with modules
https://github.com/bogdando/gogetguru a script that workarounds that issue. This time it works much better, I hope.


Updates comments regarding the reference pool that were inaccurate

Thanks for cleaning up my mess and sorry for missing these.

no worries! probably at some point we'll need to a full review of the docs for gil-refs stuff 😬


Fix on upload with external storage

Issue:91191
Given that UploadCachedFile keeps the absolute path of images that are uploaded on PrivateTempStorage of the external storage (so that it can distinguish between local disk images and external storage images), SetParameterMultimedia can receive values like these:
image_gxi = "GalaxySII.jpg" and image="gxupload:a31246ece3dd4899ae76599920bf5015"
where the image is translated to p.e. "https://genexus.blob.core.windows.net/myprivatecontainer/PrivateTempStorage/a39af8dd-8cf9-463b-a3bf-94aad44acbf4.tmp?sv=2018-03-28&sr=b&sig=a%2BwhZB6xJGAnfLUgQwmhKJy1YfQcHut3h1mwwlMgvzg%3D&st=2021-09-18T13%3A02%3A42Z&se=2021-09-19T13%3A02%3A42Z&sp=r"  which is an absolute URL. So it must make a relative URL to pass to the copy method (which expects an objectName)
Fix TryGetObjectNameFromURL to remove queryString (case of private files).

Some Google Storage Test are failing. I don't know if this is random or is a side effect?

I'll chek.


update translation counting-sort

added implementation code

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


chore: add macos-latest, ubuntu-latest, windows-latest to pr-check workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: AndrewTriesToCode sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


WIP: Added scripts for running stress-ng workloads

CAN MERGE: Added a basic script that should run stress-ng workloads for better energy validation

This can be merged now. It will be used by the ssh to run stress test.


[FEATURE] Adding Heron's formula for area of any triangle

Heron's Formula for Area of any (valid) triangle.
Description
Adding heronArea.js and adding the corresponding entry in tag_database. More info on Heron's formula (and why it works) here: https://en.wikipedia.org/wiki/Heron's_formula. This is exceptionally helpful for simplifying any math being done inside your JS, and abstracts away any altitude calculations being done before the (1/2)bh calculation often used instead.
PR Type

[x] Snippets, Tests & Tags (new snippets, updated snippets, re-tagging of snippets, added/updated tests)
[ ] Scripts & Website & Meta (anything related to files in the scripts folder, how the repository's automated procedures work and the website)
[ ] Glossary & Secondary Features (anything related to the glossary, such as new or updated terms or other secondary features)
[ ] General, Typos, Misc. & Meta (everything else, typos, general stuff and meta files in the repository - e.g. the issue template)

Guidelines

[x] I have read the guidelines in the CONTRIBUTING document.

Thanks for contributing 👍 I see this snippet as a good example for absolute beginners but other than that I see no real-world use case for this.
@skatcat31 @Chalarangelo could you give your opinion on this one? I am not against merging it, I just do not see real value in here - I might be wrong though.

My opinion is that it probably belongs in the archive, but I'll have to investigate a bit before concluding.

Having snippets like these might not be the best fit for the current website but as you said they should belong to the archive. By adding them there, we can definitely use it later down the road.
I vote +1 for adding this to the archive. 👍

Hey, @kylebegovich could you move your snippet to snippets_archive before I merge this? Thanks

Moved the code snippet and removed the line from the tag_database. Lmk if there's anything else for me to do!


Logic for adding id to list in createSuccess

Logic for adding id to list within createSuccess mutation

I am sorry, but it was a design decision, that create action does not append to the list. Usually the collection of items is sorted in some way and one does not always want to have a newly created record at the bottom. You can just fetchList again if you want to see your item in the collection.


Using HTTPS URL to clone

I faced this.

Please check out this, Cloning with HTTPS is a way recommended by Github.
https://help.github.com/articles/which-remote-url-should-i-use/
Thanks for the nice work 👍

@lockys Thanks for the fix and the screenshot on the conversation.


KAFKA-5098: KafkaProducer.send() should validate topic name before sending

KafkaProducer.send() should check topic name before sending the record.

@ijuma  @guozhangwang  A minor change. Please review. Thanks in advance.

@ijuma addressed your comments. Please review again. Thanks

Thanks for the comments. Review please.

Review again, please

As I said in the JIRA:
Onur Karaman correctly asked about the potential performance impact of doing this check for each producer record. I did some micro-benchmarking and it could be significant (particularly if the topic name is long). I reverted the change for now until we have a chance to verify its impact via `ProducerPerformance`.
I also submitted a PR that improves the performance of `Topic.validate()`.

I left a comment #3234 without realizing this is already being added :) As I said I think moving forward auto topic creation will be disabled by default and even obsoleted so I'm less worried that this will be a common issue.


Fix typo. K8s - > Kubernetes

Make a word complete

Coverage remained the same at 19.452% when pulling 534b0498b293803ce14279680bb90c39a96ed84b on fix/typo into<PHONE_NUMBER>8dcd954f27a4db67e6c3c78c9b4c14 on master.


3 terms missing rdfs:isDefinedBy triples

I'm writing some basic Best Practice-checking code, and in the process I noticed that there are just 3 terms (from the 289 terms in gist) that are missing rdfs:isDefinedBy triples, namely:

gist:_day
gist:_millisecond
gist:_minute

I assume this is just a minor oversight (as the other 14 owl:NamedIndividual instances do include that triple). And it's easy to fix up by just adding the missing triples.

I looked into this and found the issue. When generating the rdfs:isDefinedBy assertions, onto-tool has two settings--a default 'strict' setting and an 'all' setting. With the strict mode enabled, it only adds the assertions for entities that belong to certain classes (including owl:Thing). These three duration units are missing explicit owl:Thing type assertions, which caused them to be filtered out. Adding the missing owl:Thing assertions will resolve the issue for future releases.

In the discussion for PR #783 it looks like instead of adding owl:Thing assertions, @rjyounes suggested changing the onto_tool config to address this issue.

Modify our bundle.yaml file to use all rather than strict. Are there any negative consequences to doing so?

@Jamie-SA @dylan-sa Should we keep this in the Feb. release?

This sounded easy... but I can't see a way to get the current version of the onto_tool to use the all mode. The way we are currently adding the definedBy property does not support the all option, and the only action that does is the export which looks like it does other things we don't want.
To get this functionality it looks like a change to the onto_tool would be required.
So I guess maybe we move this to the next release.

We'll do this as a short-term workaround until onto_tool is fixed.

Fixed in PR #927 but not closed because this isn't the default branch. So I'm closing it now.


Rely on ?? operator at call site instead of passing default values to Get-methods

Would pull request https://github.com/OfficeDev/PnP/pull/433 be accepted if I re-submit it based on the dev branch?
The pull request changes the external core interface, but for one of the two methods the behavior isn't working anyway.

Hi Ronnie,
We've discussed this and we're not going to change this cause it's not really adding additional and complicates things as the web property bag methods are widely used...would not want to update the signature for those.

Remember to fix the use of the default value. It's not used by accident in one of the methods.

Got it...nice catch. I've just updated


[question] Upgrade from 3.4.0 to newest version

Hello, Im new to all this.. I have successfully installed zwavejs2mqtt on my Raspi4 via the method
git clone https://github.com/zwave-js/zwavejs2mqtt
cd zwavejs2mqtt
yarn install
yarn run build
yarn start
Now, Id like to upgrade to the newest version, yet not sure of which would be the best steps to take...
My configuration is working and I would not like to break anything..
Thank you for your help.
Martin

git pull
yarn build
yarn start


Confusing log for pub-mac-be

I can't make sense of this log for the pub-mac-be bot. It looks like the tests are running successfully until all of a sudden there's @@@STEP_FAILURE@@@ with no further explanation.

See also #28875.


v2: There's no bundling + tree shaking without minify-ing?

As far as I understand last weeks.. There's no way to make a bundle that will have "tree shaking" enabled without the minifying? It not looks cool to me. I tried bundling without minifying and it seems it is not tree-shaked.
Or if it is possible, how? Some examples? I'm talking for v2.

As far as I know, the tree shaking only happens in minifying. In normal bundle, you can see the part of code has been marked as unused harmony export, but it is still there.
Technically it can be done.

As far as I know, the tree shaking only happens in minifying.

Exactly.

In normal bundle, you can see the part of code

Yea, seen that.

Yeah I confirm, tree shaking results can be seen during final build for production.
In development, to see if three shaking is working, what I usually is to try to export a fake function from a module that you are already using:
import { fakeFunc } from './myModule'  console.log(fakeFunc)
And you should get a warning from webpack inside the console

You could also use --display-used-exports, which display information about tree shaking in the output

Omg, seriously. I know it is wokring, that's not the case. The case is that I want tree-shaked bundles without minifying - intentionally.
@sokra

display information about

What information? First it seems it does nothing for me, output is absolutely the same; Second don't want "information", I want real working bundle :D
~/code/foobar master ✓ ✗
% ❯ webpack --entry ./index.js --output-filename bundle.js --target node                               December 13, 16:58:04
Hash: 9567831ddc533348d9a4
Version: webpack 2.1.0-beta.27
Time: 307ms
    Asset     Size  Chunks             Chunk Names
bundle.js  29.7 kB       0  [emitted]  null
  [15] ./index.js 2.73 kB {0} [built]
    + 15 hidden modules
~/code/foobar master ✓ ✗
% ❯ webpack --entry ./index.js --output-filename bundle.js --target node --display-used-exports        December 13, 16:58:38
Hash: 9567831ddc533348d9a4
Version: webpack 2.1.0-beta.27
Time: 303ms
    Asset     Size  Chunks             Chunk Names
bundle.js  29.7 kB       0  [emitted]  null
  [15] ./index.js 2.73 kB {0} [built]
    + 15 hidden modules
~/code/foobar master ✓ ✗
% ❯


[Bug] Failed to read Firebase options from the app's resources (). Either make sure GoogleService-Info.plist is included in your build or specify options explicitly. Firebase.AppUtil:PollCallbacks() Firebase.Platform.FirebaseHandler:Update()

[REQUIRED] Please fill in the following fields:

Unity editor version: _2019.4.5f1
Firebase Unity SDK version: 7.0.0
Source you installed the SDK: unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component:  Auth, Analytics, Dynamic Links (Auth, Database, etc.)
Other Firebase Components in use:  (Auth, Database, etc.)
Additional SDKs you are using: Facebook, Admob(Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Mac (Mac, Windows, or Linux)
Platform you are targeting: iOS and Android (iOS, Android, and/or desktop)
Scripting Runtime: Mono (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
Getting "Failed to read Firebase options from the app's resources (). Either make sure GoogleService-Info.plist is included in your build or specify options explicitly. Firebase.AppUtil:PollCallbacks() Firebase.Platform.FirebaseHandler:Update()" When i launch iOS build.
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Steps to reproduce:

Launch the app

Logs

Failed to read Firebase options from the app's resources (). Either make sure GoogleService-Info.plist is included in your build or specify options explicitly. Firebase.AppUtil:PollCallbacks() Firebase.Platform.FirebaseHandler:Update()
App ID, API key, and Project ID must be specified in App options. Firebase.AppUtil:PollCallbacks() Firebase.Platform.FirebaseHandler:Update()

Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?
What's the issue repro rate? (eg 100%, 1/5 etc)
100%
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.

Facebook SDK version is 9.0.0
Admob version 5.4.0
I know there are duplicate issues of this issue, but I didn't get any solution or I couldn't understood the solution.
Before marking it has a duplicate of any issue please send me proper solution.

Hi @surajsk1812,
It seems that you're facing an issue similar to what's described in #862. Using SDK version 7.1.0 or higher should resolve this.
With that, I'll be closing this ticket for now. Let me know if you have any other questions or if your scenario is different from what I described.


High level actions humanoid

Motivation and Context
This PR allows to control humanoids using high level skills. We currently only provide an oracle navigation skill
for navigation and Noop skills for pick and place actions.  It works both with PDDL policies as well as with trained policies.
The PR updates the humanoid controller to enable good navigation. In particular it corrects the rotations that happen to the humanoid because of gait to enable a smooth path.
How Has This Been Tested
Works using a PDDL-based policy.
Works using Trained Policy. Tested checking video.
Types of changes

[Docs change] Addition to changes in documentation.
[New feature] (non-breaking change which adds functionality)
[Development] A pull request that add new features to the habitat-lab task and environment codebase.

Checklist

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I addressed all the comments, let me know what you think.
I simplified the config structure, but I didn't find a way to delete an action that had been defined in a config before. This is why I created a rearrange_easy_base.yaml that is exactly like the previous rearrange_easy.yaml but without the arm_action, and changed rearrange_easy to derive from it and add an arm_action. I am not sure if there is a simpler way to do this.

See above comments.

Thanks for the feedback! I think I addressed all the issues. Let me know.


Plugin integration with NRE fails to return values

While extending Nile with plugins works well with CLI, one issue I've stumbled upon is returning values in the NRE. For simplicity, consider this plugin example:
# plugins/do_something.py

@click.command()
def do_something():
    click.echo("AHHHHHHHH")
    return 5

And let's say we have this script:
# scripts/do_something.py

def run(nre):
    x = nre.do_something()
    print(x)

Running the script will print AHHHHHHHH but the expected return value 5 is returned as None; therefore, the logic is being executed, but the values are not being returned.

Interesting. @franalgaba could you look into this?

Hi @andrew-fleming !
Glad to see you are using plugins. I reproduced the error you are having and diving into the NRE and how the plugins work there does not seem to be anything wrong.
Then, I looked at how click works internally for handling commands and... that's where the issue is. If you check the click documentation about Command Return Values you will see something like this:

When a Click script is invoked as command line application (through BaseCommand.main()) the return value is ignored unless the standalone_mode is disabled in which case it’s bubbled through.

So, how to solve the issue? When you are using the plugin in a programmatic way with the NRE you have to pass the standalone_mode argument like this in order to retrieve the return value from the click command:
# scripts/do_something.py

def run(nre):
    x = nre.do_something(standalone_mode=False)
    print(x)

Just tried it and it works as expected. Hope it helps :)

Haha amazing, works perfectly! I was trying to set standalone_mode in the actual plugin click method. I wonder if we can somehow abstract this out so users don't have to worry about including it; nevertheless, thank you @franalgaba! Very much appreciated :)

Caught wet abstract it?

Yes, definitely. It is possible to inject the parameter in the command call that happens underneath I think. It should be very straightforward. I will open a PR to handle this :)

Thanks!

Thanks!

Just opened a PR with the fix :)


test packages removed from build dependencies

Hi,
This PR removes test packages such as HUnit, tasty,tasty-hunit from build dependencies as they are not required. Build and tests run properly using resolver as lts-13.19.
Please let me know if I need to make any further modifications or changes.

Ah! I haven't worked on this in a very long time! Merging it since the patch looks OK and it works for you @abiduzz420. Thanks!


Bitwarden

Hey can you collaborate with the folks over at bitwarden so they can become an encryption provider?

Hi! Can you describe what you mean by "encryption provider"? For example, are you looking to be able to log in to Bitwarden from ESC via OIDC? Or are you looking for the ability to fetch secrets stored in Bitwarden via ESC?

Hey I am looking to fetch secrets stored in Bitwarden. Especially their Secrets Manager:
https://bitwarden.com/products/secrets-manager/

yes please.,


Cannot print booleans

print <- true doesn’t output anything.

In the same vein, printing nil also gives no output:
print <- nil, "\n"      // => no output

Sort of fixed. For now, it will print 1 for true and 0 for false. Since bool is effectively u1, this is (for now) correct behavior.


get Property 'length' does not exist on type error inside if Array.isArray block

Bug Report

The Operand is a union type, but after tested by Array.isArray, the get Property 'length' does not exist on type error message still displayed.

🔎 Search Terms
Array.isArray

🕗 Version & Regression Information

This is a crash
This changed between versions ______ and _______
This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
I was unable to test this on prior versions because _______

⏯ Playground Link

Playground link with relevant code
💻 Code

  if (Array.isArray(operands[i])) {
    const length = operands[i].length;

🙁 Actual behavior

Error message displayed.
Run properly in stackblitz.
But got runtime error while run by ts-node
    return new TSError(diagnosticText, diagnosticCodes, diagnostics);
           ^
TSError: ⨯ Unable to compile TypeScript:
calc24.ts:241:30 - error TS2339: Property 'length' does not exist on type 'Operand'.
  Property 'length' does not exist on type 'false'.

241   const length = operands[i].length;

🙂 Expected behavior

No error should display

Duplicate of #52014 and many many many many others. This definitely should be added to the FAQ.

Seems like it's a regression issue?

It's always been like this.