AnimationGroup: optimized interpolate() and fixed alpha bug on finish()

Overview: What does this pull request change?

In AnimationGroup.build_animations_with_timings(), the start times and end times of each animation are now calculated in a vectorized way: now AnimationGroup.anims_with_timings is a NumPy array with custom type (object, float, float), instead of a list of tuples. This allows for vectorization and fancy indexing in the next point.
AnimationGroup.interpolate() was vectorized thanks to the previous changes. Not only that: instead of updating all the animations, now only "ongoing" animations (those which have started and not yet finished) are updated. The ongoing animations are fancy-indexed from the now-ndarray anims_with_timings attribute. All of this results in a major speedup for AnimationGroup.interpolate().
There was a bug where, if you used a "reverse" rate_func which intended to make the submobjects reach an alpha == 0 state, when AnimationGroup.finish() gets called, it would call all of its subanimations' finish() method which would make all the submobjects be reset to an alpha == 1 state instead. To fix this, an AnimationGroup.interpolate(1) was added to the AnimationGroup.finish() method.

Motivation and Explanation: Why and how do your changes improve the library?
Consider this scene:
class ChaosGame(Scene):
    def construct(self):
        L = 8
        h = L * np.sqrt(3) / 2
        vertices = np.array([[0, h/2, 0], [-L/2, -h/2, 0], [L/2, -h/2, 0]])

        N = 1000
        points = np.empty((N, 3))
        choices = np.random.randint(3, size=N)
        colors = [RED, YELLOW, BLUE]
        points[-1] = [0, 0, 0]
        for i in range(N):
            points[i] = (points[i-1] + vertices[choices[i]]) / 2

        dots = [Dot(p, color=colors[ch], radius=0.02) for p, ch in zip(points, choices)]

        self.wait()
        self.play(AnimationGroup(*[FadeIn(dot) for dot in dots], lag_ratio=0.5, run_time=20))
        self.wait(5)

When an AnimationGroup has too many subanimations (like in this example), performance gets a hit. Therefore, I optimized AnimationGroup for that scenario.
This specific example was extreme, and so is its corresponding optimization: a speedup of almost 150x in AnimationGroup.interpolate()! Other scenarios may not benefit that much, but it's still a huge advancement.

Before
After

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

I realized that my implementation creates a bug when there are too many mobjects, as self.ongoing_anim_bools and new_ongoing won't always intersect, and there might be animations in between which would be skipped by this.
I'll make this a draft meanwhile, I hope that I can fix this soon.
@behackl, about your AnimationGroup implementation you talked about last night: maybe it would be a good idea to integrate those changes now that we're on it. May I pull your changes into my branch? Or is it possible that you could push them?

I fixed the issue. In the end I reverted my implementation to do the same thing you did, Benjamin: to compute when animations have started and finished, rather than being just "ongoing".
I also made AnimationGroup.update_mobjects() update only the ongoing animations (i.e. started and not finished), just like you did.

I tried to implement the other changes and see what happened. It didn't go well. :(
For my ChaosGame, the FadeIn animations expect their begin() method to be called in the beginning, because that's how they create the target and starting mobject, where the starting mobject is invisible at first. Not doing this right at the beginning (like what you do with AnimationGroup.begin(): it's just a pass) messes everything up, as all mobjects are immediately present on scene and they barely blink when their animation actually begins. (Now that i think of it, it sounds more of an AnimationGroup issue, as in "why are you adding all the Mobjects preemptively")
Implementing all those changes is gonna be more complex than it looks, and it definitely should be done in another PR ;)


Had problems running Script '51 syslog Name.ps1' in ESXi 6.0 - Script should report if either Syslog host and/or Syslog Directory does not contain the propriate value

By the way there were some changes accdording logging starting with ESXi 5.x
Dont get confused about  $SyslogDir = "[] /scratch/log"
You see the same in WebClient for this value.
This modified content works in my environment
  # Start of Settings
  # The Syslog server which should be set on your hosts
  #
  # First, ccording to KB2004773 and KB2003322 the AdvancedSetting Parameter for Syslog has changed
  # and therfore the statement has to be corrected. Second, there is a logical error in the last
  # 'and' compare, which should be an 'or': Either SyslogServer OR SyslogDir differences (-ne) should report an error"
  #
  $SyslogServer = "tcp://www.xxx.yyy.zzz"
  $SyslogDir = "[] /scratch/log"
  # End of Settings

  # ORIGINAL STATEMENT # @($VMH | Where-Object {$_.ExtensionData.Summary.Config.Product.Name -eq 'VMware ESXi'} | Select-Object Name,@{Name='SyslogServer';Expression = {($_ | Get-VMHostSysLogServer).Host}},@{Name='SyslogSetting';Expression = {($_ | Get-AdvancedSetting -Name Syslog.Local.DatastorePath).Value| Where-Object {$_ -ne $NULL}}} | Where-Object {$_.SyslogServer -ne $SyslogServer -and $_.SyslogSetting -ne $SyslogServer})
  #
  @($VMH | Where-Object {$_.ExtensionData.Summary.Config.Product.Name -eq 'VMware ESXi'} | Select-Object Name,@{Name='SyslogServer';Expression = {($_ | Get-VMHostSysLogServer).Host}},@{Name='SyslogSetting';Expression = {($_ | Get-AdvancedSetting -Name Syslog.global.logDir).Value| Where-Object {$_ -ne $NULL}}} | Where-Object {$_.SyslogServer -ne $SyslogServer -or $_.SyslogSetting -ne "$SyslogDir"})

  $PluginCategory = "vSphere"
  $Title = "Syslog Name"
  $Header = "Syslog Issues"
  $Comments = "The following hosts do not have the correct Syslog settings which may cause issues if ESXi hosts experience issues and logs need to be investigated"
  $Display = "Table"
  $Author = "Jonathan Medd"
  $PluginVersion = 1.1

Thanks, I'll check this out and update at some point.

Tested this at the VMworld Hackathon and worked great for me, will commit after the event!

Oh yeah...totally forgot to commit this -_-
Looking forward to seeing what came from the Hackathon!

It's not exactly elegant, but using the following line (and setting $SyslogServer to your desired Syslog.global.logHost value) will also check that the correct port is specified. The downside is that if no Syslog.global.logHost is configured on the host, the check will show it set to ":".
@($VMH | Where-Object {$_.ExtensionData.Summary.Config.Product.Name -eq 'VMware ESXi'} | Select-Object Name,@{Name='SyslogServer';Expression = {($_ | Get-VMHostSysLogServer).Host + ":" + ($_ | Get-VMHostSysLogServer).Port}},@{Name='SyslogSetting';Expression = {($_ | Get-AdvancedSetting -Name Syslog.global.logDir).Value| Where-Object {$_ -ne $NULL}}} | Where-Object {$_.SyslogServer -ne $SyslogServer -or $_.SyslogSetting -ne "$SyslogDir"})
And to help people who may not know what your desired syslog values are, the comments value could be:
$Comments = "The following hosts do not have the correct Syslog settings which may cause issues if ESXi hosts experience issues and logs need to be investigated. For reference, SyslogServer (Syslog.global.logHost) should have a value of " + $SyslogServer + ", and SyslogSetting (Syslog.global.logDir) should have a value of " + $SyslogDir


iOS12

Ios12 has a flash back when running the program. Is there a way to resolve it

A bit more details would help :), what is a flash back ?


Kill Code Helper. Sucking up all the memory and CPU

All previous duplicated threads have been disabled. So here's another...
How do I disable code helper? This is sucking up all the memory and all the CPU. Shut it down!
#51776 and #11096

Please see our wiki page with details on how to provide info for performance issues 🙂  https://github.com/microsoft/vscode/wiki/Performance-Issues
/needsMoreInfo


  I recommend the next group starts here.
F17 OK: 200 XP


feat: dynamic height radio group widget standardization

Description

Wrapped the RadioGroup default component in the React.forwardedRef so that the incoming ref from the parent widget can be hooked up to the RadioGroupContainer.
Hooked the BaseWIdget contentRef to the RadioGroupContainer component via RadioGroup Widget.

Fixes #13050
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feature/dh-stdzn-radio-group-widget

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.49 (0.02)
37.98 (0.05)
36.27 (0.08)
56.71 (0.01)

:red_circle:
app/client/src/actions/reflowActions.ts
75 (-10.71)
100 (0)
20 (-30)
63.64 (-16.36)

:green_circle:
app/client/src/ce/constants/messages.ts
78.05 (0.05)
100 (0)
35.08 (0.14)
82.34 (0.1)

:green_circle:
app/client/src/components/ads/Checkbox.tsx
90.24 (63.41)
56.82 (43.18)
88.24 (88.24)
88.89 (58.33)

:green_circle:
app/client/src/pages/Editor/MainContainerLayoutControl.tsx
88.89 (0.25)
81.25 (0)
80 (0)
90.48 (0.24)

:sparkles: :new:
app/client/src/pages/Editor/ReflowBetaCard.tsx
82.86
68.18
25
82.86

:red_circle:
app/client/src/pages/Editor/Explorer/Files/index.tsx
76.32 (0.13)
33.33 (5.55)
40 (-10)
80.56 (1.07)

:green_circle:
app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx
34.7 (0.17)
25.77 (0)
0 (0)
36.02 (0.04)

:red_circle:
app/client/src/pages/Editor/QueryEditor/index.tsx
27.61 (-0.42)
5.33 (0)
5.26 (-0.3)
29.27 (-0.24)

:green_circle:
app/client/src/pages/common/CanvasArenas/hooks/useCanvasDragging.ts
83.64 (0.1)
67.05 (0.13)
84.38 (0)
84.19 (0.1)

:green_circle:
app/client/src/reducers/uiReducers/applicationsReducer.tsx
16 (0.76)
27.27 (7.27)
12.24 (0.48)
14.43 (0.57)

:red_circle:
app/client/src/reducers/uiReducers/reflowReducer.ts
58.33 (-25)
100 (0)
25 (-25)
54.55 (-28.78)

:green_circle:
app/client/src/reflow/reflowHelpers.ts
94.94 (0.33)
64.77 (5.95)
100 (0)
95.57 (0.54)

:red_circle:
app/client/src/reflow/reflowUtils.ts
79.55 (-0.6)
69.65 (-0.8)
84.31 (-0.31)
79.61 (-0.69)

:red_circle:
app/client/src/resizable/resizenreflow/index.tsx
53.57 (-1.24)
54.46 (-3.09)
40 (0)
51.91 (-1.26)

:red_circle:
app/client/src/sagas/ModalSagas.ts
36.27 (-0.34)
19.44 (1.02)
23.08 (0)
37.23 (-1.01)

:sparkles: :new:
app/client/src/sagas/ReflowSagas.ts
24.24
7.14
33.33
28.57

:green_circle:
app/client/src/sagas/index.tsx
93.44 (0.11)
57.14 (0)
100 (0)
96.49 (0.06)

:red_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0)
70.59 (-1.96)
100 (0)
93.33 (0)

:red_circle:
app/client/src/utils/storage.ts
34.04 (-0.14)
11.11 (-4.68)
7.14 (-2.24)
27.01 (0.74)

:green_circle:
app/client/src/widgets/BaseWidget.tsx
80 (0.16)
48.94 (0)
76.47 (0)
79.2 (0.17)

:green_circle:
app/client/src/widgets/RadioGroupWidget/component/index.tsx
52.38 (5.01)
28.57 (0)
0 (0)
55 (5)

Completed Regression testing of Radio Group Widget on the above dp provided. Moving to Done.


docs: pin the prerequisite link to release-0.2

The documentation on released versions should be pinned to the specific version to avoid the instructions from the future releases.

/lgtm
/approve

/approve

/label docs-approved
/label qe-approved
/label px-approved


Add eslint to solid examples

TODO

[ ] lint all
[ ] run pnpm i to update pnpm-lock.yaml

Current:
C:\workspace\vite-plugin-ssr\examples\solid-ssr-v1\renderer\+onRenderClient.tsx
  26:23  warning  Forbidden non-null assertion                                  @typescript-eslint/no-non-null-assertion
  46:3   error    Do not use "@ts-ignore" because it alters compilation errors  @typescript-eslint/ban-ts-comment
  48:3   error    Do not use "@ts-ignore" because it alters compilation errors  @typescript-eslint/ban-ts-comment

C:\workspace\vite-plugin-ssr\examples\solid-ssr-v1\renderer\Link.tsx
  7:67  error  Use `undefined` instead of `null`  unicorn/no-null

C:\workspace\vite-plugin-ssr\examples\solid-ssr-v1\renderer\types.ts
  3:25  error  Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead  @typescript-eslint/ban-types

C:\workspace\vite-plugin-ssr\examples\solid-ssr-v1\renderer\usePageContext.tsx
  11:8   warning  The reactive variable 'props.pageContext' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored  solid/reactivity
  12:35  warning  The reactive variable 'props.pageContext' should be used within JSX, a tracked scope (like createEffect), or inside an event handler function, or else changes will be ignored  solid/reactivity

✖ 7 problems (4 errors, 3 warnings)

@typescript-eslint/ban-ts-comment will be removed with VPS v1.
Some help is needed to others.

Thanks for PR.
In genreal, the idea of /examples/ is to be minimal and to showcase only one particular aspect. So I'm inclined to not add ESLint to the examples. But we're woking on Solid boilerplates and  we can then add ESLint over there.
Let's close in the meantime and let's continue the conversation once the boilerplates are ready.


Add keycloak provider

Adding integration of keycloak provider based on forgotten PR https://github.com/bitly/oauth2_proxy/pull/366/files
Solves https://github.com/pusher/oauth2_proxy/issues/127
How Has This Been Tested?
Tested manually. I set up keycloak and reference it in configuration of oauth2_proxy using this provider.

[x] My change requires a change to the documentation or CHANGELOG.
[x] I have updated the documentation/CHANGELOG accordingly.
[x] I have created a feature (non-master) branch for my PR.

Excellent, thank you for taking the time to do this :-)

LGTM :+1: - @JoelSpeed do we have any additional processes that need completing when adding a new provider?

@Ofinka Do you mind adding yourself to the owners file for future changes? https://github.com/pusher/oauth2_proxy/blob/master/.github/CODEOWNERS#L12

Has this one stalled now, as it seemed to be close to getting merged 😃

Hi guys, I'm sorry but I'm afraid I do not have enough time to be part of another project :(
Would definitely appreciate if anyone else could take the responsibility.

Understood. I think we should merge this as is.

Would love to see this move along.

If we can fix @JoelSpeed's comment above, then I can get this merged.

The author of the pull request has not responded since August 19, not sure when or if they will.

I have fixed the CHANGELOG error. Just need to get it re-reviewed by @JoelSpeed or @steakunderscore

Thank you and congrats on your first contribution! :tada:

Thanks for your help!!


test command fails when the expected deploy manifests are missing

Bug Report

What did you do?
I created e2e tests as per this doc and on running them got errors:
$ operator-sdk test local ./test/e2e
2018/11/04 17:13:39 could not find role manifest: open deploy/role.yaml: no such file or directory

I removed the default role.yaml file because it's not needed for my operator. I create a service account and rolebinding.
Creating an empty role.yaml file and running results in a panic:
panic: interface conversion: interface {} is nil, not map[interface {}]interface {} [recovered]
	panic: interface conversion: interface {} is nil, not map[interface {}]interface {}

goroutine 47 [running]:
testing.tRunner.func1(0xc000254700)
	/usr/local/go/src/testing/testing.go:792 +0x387
panic(0xff8220, 0xc00056d770)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
github.com/darkowlzz/operator/vendor/github.com/operator-framework/operator-sdk/pkg/test.setNamespaceYAML(0xc0001e8095, 0x19f, 0x19f, 0xc00004818f, 0x12, 0xc000426400, 0x0, 0x0, 0xc00045a780, 0xc000353800)
	/home/darkowlzz/go/src/github.com/darkowlzz/operator/vendor/github.com/operator-framework/operator-sdk/pkg/test/resource_creator.go:58 +0x27b
github.com/darkowlzz/operator/vendor/github.com/operator-framework/operator-sdk/pkg/test.(*TestCtx).createFromYAML(0xc0002b6040, 0xc0001e8000, 0x754, 0x954, 0x900, 0xc000426400, 0x0, 0x104a640)

This happens due to the empty yaml section in the generated deploy/test/namespace-manifests.yaml file
apiVersion: v1
kind: ServiceAccount
metadata:
  name: operator-sa
  namespace: default

---

---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
...

What did you expect to see?
The tests run as expected.

Environment

operator-sdk version: v0.1.0

Are you writing your operator in ansible or go? Go.

Possible Solution

The test command should not fail, but maybe raise warnings when the expected files are missing. And a check on the file content before appending it with the other manifests.

Thanks for reporting this bug. The most immediate fix for this bug would be manually creating your namespaced manifests yaml file with the correct manifests and using the --namespaced-manifest flag for the test (See https://github.com/operator-framework/operator-sdk/blob/master/doc/sdk-cli-reference.md#test).
I do agree that it would be better for the tests command to simply print a warning when a manifest file is not found and not crash if there is an empty section in the manifests file. I will try to get a fix up for those 2 issues soon.


Dev/min sdk24

Pull Request Template
Types of changes
What types of changes does your code introduce to Woosmap Geofencing?
Put an x in the boxes that apply

[] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Documentation Update (if none of the other choices apply)

Checklist
Before you submit a pull request, please make sure you have to following:

[X] I've read contributing guidelines
[X] My code contain tests relevant for the problem I'm solving
[X]I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)

Testé sur simu android 7 et téléphone android 8, cela semble marcher (collecte, carte et notification)


[Question] Get user available scopes in controller method

Hello,
Is there way to just check if user has scope?
For example i want to set default include for transformer if user has some kind of scope

As in OAuth scopes? Dingo just uses the tokens scopes, so if you're using the bridge package then you can grab the authorizer instance and use the hasScope method.
app('oauth2-server.authorizer')->hasScope('foo');

Thank you. That's what i was looking form


Add Mixnode HTTP API

To get metrics
To have a right way to check if the process is ready

I'm closing this for now. We don't have clear metrics that need to be exposed. Let's revisit this after the mixnet spec is finalized.


Sale Grammar School - Higher Education

Sale Grammar School - Higher Education
Official website https://www.salegrammar.co.uk/

@dhhyey-desai Pull request merged. Thank you!


Allow passing in context when using 0RTT

Hi there,
My team is trying to utilize the 0RTT feature from QUIC.  We use context cancellation in our code. However, I have noticed that quic-go provides DialAddrContext but no DialAddrEarlyContext. Is it possible that we can add another method for DialAddrEarly that can take in a context?

That seems consistent with what we have now. Want to send us a PR that adds those two methods?

Great! Yes, I will put up a PR for adding DialAddrEarlyContext

Would be great if you could also add a DialEarlyContext, so we context for all variants of dial functions.


Fix utf8 clen fast path pointer arithmetic issue

See discussion: https://github.com/svaarala/duktape/issues/530#issuecomment-171654860

This is very odd.  Bitwise AND is by definition commutative.

Here's a description of the underlying issue: https://github.com/svaarala/duktape/issues/530#issuecomment-171697759
Instead of switching the bitwise AND order, the better fix is to cast to size_t instead of (u)intptr_t which doesn't rely on the AND ordering. To be fixed in the commits.


Save swapchain HDR state for trimmed captures

Problem
Trimmed traces did not replay in HDR mode.
Solution
Track SetColorSpace1 and SetHDRMetaData during capture if trimming is enabled. Then write it out to file so that replay can properly setup HDR as it was during live app.
Testing
Trimmed trace replays in HDR mode.

CI gfxreconstruct build queued with queue ID 285479.

CI gfxreconstruct build # 5163 running.

CI gfxreconstruct build queued with queue ID 285494.

CI gfxreconstruct build # 5164 running.

CI gfxreconstruct build # 5164 passed.


Does this coverage tool can detect the code coverage of the web application code

Hi there,
I am the beginner of this coverage tool and I have this question:

We have a web application which is written in python, and deployed onto the AWS cluster.
Now from my local, I have created UI automated test cases by selenium & python in the BDD format.
Now If I was to run my testing as

coverage run -m behave  X1..feature
coverage report -m

What code coverage would be reported ?  The % usage of my local python selenium script ? OR the % of this web application ?
I was hoping the later one, right ?  If not, can someone give me the direction how I may achieve this ?
Thanks a lot !
Chun

That will record the coverage of your local selenium script.  If you want to record the coverage of the web application, then you need to use coverage to run the web application.  Coverage.py doesn't have special facilities to do this.  Typically, you wouldn't measure the coverage on a production site like AWS anyway: you would run your tests in a more local configuration.

Thanks for the tips.


Update change-address-contact-and-more.md

Added Teams Org switches to the list

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/1743


Publish Vundle in apt repositories

I like to automatically provision my dev environments. It would be sweet if I could apt install vundle.

If using Infrastructure as Code to automatically provision you could just
apt install git && git clone https://github.com/VundleVim/Vundle.vim.git ~/.vim/bundle/Vundle.vim

in your .yml file, probably in dependencies category.


Add an annotation to keep resources around after "helm delete"

In helm classic there was an annotation "helm-keep" that allowed chart admins to mark a resource to be kept around even after a release was deleted.
We should add this back.
An example use case is when users create PVCs for databases and want them to be kept around for manual inspection/deletion after the helm release is deleted.

I'd prefer something like a helm.sh/resource-policy: keep sort of syntax, based on @viglesiasce 's suggestion in Slack. Are there other states we know we want for sure?

Based on what I'm seeing in 2.0.0, PVCs are already being left automatically when helm delete is ran.  I'm actually looking for a built-in mechanism for removing them when the release is destroyed.

@aegixx I could not reproduce that behavior. What version of kubernetes are you on? Are you still seeing that behavior?
If we "keep" a resource, does that mean the release still exists? Do we detach the release from the resources at that point?
What should happen if there is a keep annotation but the purge flag is added to the delete command?

Should the helm status output of a deleted release show the resources that are left and their statuses?

What (if any) kind of feedback should the helm delete command give to the user if resources are being kept?

Closed by #1652


数据库中的数据都是空的，如何造一些测试数据呢

You can try random some data in your database according to the data format in the repo layer.
Sorry for not being able to provide the real data. 😭

怎样造一些测试数据呢，可以看一下吗，老师

The value is 0 after sunset and peaks at noon

The value is 0 after sunset and peaks at noon

您好，可以求个包含数据的sql文件吗，自己不知道怎样构造，感觉数据集很庞大。

Sorry, we can't.


Set default Buildkit output mode to plain

As mentioned in #256, if you use Buildkit the default output can create a bunch of erroneous log output groups.
This change sets the default Buildkit output to plain to avoid this.
Fixes #256

One thing I didn't consider, is that people still need to set DOCKER_BUILDKIT=1 environment variable?
Which means, either:

We could just add a buildkit: true option to the plugin, which sets both of the environment variables for them
We could leave it as-is, but only set BUILDKIT_PROGRESS conditionally if DOCKER_BUILKIT == "1"

I think I'd prefer version 1. What do you think @jayco & @niceking?

Hey @toolmantim! Totally keen to pair on this!!

One thing I didn't consider, is that people still need to set DOCKER_BUILDKIT=1 environment variable?
Which means, either:

We could just add a buildkit: true option to the plugin, which sets both of the environment variables for them
We could leave it as-is, but only set BUILDKIT_PROGRESS conditionally if DOCKER_BUILKIT == "1"

I think I'd prefer version 1. What do you think @jayco & @niceking?

I prefer 1 too! Nicer to be explicit rather than doing sneaky we-assumed-this-because-you-did-this things that we may forget about later!

Another thing to note, is that it turns out there's a little more to this than we thought — there's also parts of the output that we'll need to modify if buildkit is set to true, it's not just about setting the output mode to plain.

Turns out this doesn't actually solve the problem people were having after all, so let's close this for now.


Document how to use Silex without the phar

Right now, the documentation only documents how to use Silex with the phar. It's really convenient, but we should also document how to use Silex without it for several reasons: first, using a phar comes with a lot of problems, then, it's now that complex to bypass the phar and have more flexibility about how you manage your dependencies and their upgrades.

For people experiencing issues with the phar file, you can easily extract it and include it like normal.
 $phar = new Phar('silex.phar');
 $phar->extractTo('./silex'); // extract all files

Once you've done that, simply include the autoload.php file in your project, and you're good to go.

@jaywilliams worth noting that requires that phar actually be usable on the system you're on, which has been problematic for many.

@damianb a better way is to clone the repo from github to get the source code instead of extracting it from the phar archive created from the git repo content.

@stof indeed

And for those who only want to have better autocompletion in their IDE: follow the instructions provided by @AD7six but do this outside of your project directory. Then add the Silex directory as an external library to your project (this works very well in PhpStorm and Eclipse).

also works for Komodo Edit && Komodo IDE - you can clone it into a separate directory and then add that as an "include directory" for docblock info etc.


GET_VERSION unit test

The GET_VERSION unit test should include at least one test that triggers LIBSPDM_STATUS_INVALID_MSG_SIZE.

I will check it.


Rust: Enable Benchmark in PR

@dabreegster can I fiddle with the repo setting to get enable the the permission to comment on PRs in trusted forks?

Sure, feel free
On Sat, Mar 26, 2022, 8:56 AM droogmic @.***> wrote:

@dabreegster https://github.com/dabreegster can I fiddle with the repo
setting to get enable the the permission to comment on PRs in trusted forks?
—
Reply to this email directly, view it on GitHub
https://github.com/a-b-street/osm2lanes/pull/109#issuecomment-1079643622,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMWLF4E5ZSQYCVITILBXD3VB3GLFANCNFSM5RQZEUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Issues with Split Handler

Hi, this might be more of a support request than anything else, but I'm struggling to get the split handler to work with my Cloudflare worker. I'm just trying to get my worker to forward incoming requests to the listed host(s). Here's my index.js:
const Proxy = require('cloudworker-proxy');

config = [{
    handlerName: 'split',
    options: {
        host: 'public.server:9500/hooks/test'
    },
}];

const proxy = new Proxy(config);

async function fetchAndApply(event) {
    return await proxy.resolve(event);
}

addEventListener('fetch', (event) => {
  event.respondWith(fetchAndApply(event));
});

I can see the requests going through to the worker, and sometimes the worker logs a few subrequests, however the requests aren't hitting my public.server. Just hoping someone could point me in the right direction if I'm doing something blatantly wrong here.
I have the dependency in my package.json as well:
"dependencies": {
    "cloudworker-proxy": "^1.16.1"
  }

And here's my wrangler.toml for good measure:
name = "cloudflare-webhook"
type = "webpack"
account_id = "xxx"
workers_dev = true
route = ""
zone_id = ""

No errors reported by the worker. I'm kinda new to Cloudflare workers, so bear with me. Also - it was unclear to me from the documentation, but can you specify multiple hosts in the config? IE, can you forward one request to the worker to multiple endpoints?

Hi @crockk !
I've been using this in the past to split webhook-requests to multiple endpoints with a config like this:
{
    "path": "/webhook",
    "method": ["POST"],
    "host": "example.com",
    "handlerName": "split",
    "options": {
      "host": "split.example.com"
    }
  },

After the split handler a separate request will be passed down the handler-pipeline which is identical but with a different hostname. This split request is fire-and-forget so no return values will be passed back to the client.
To better see how it works you can add a logger handler after the split handler and it should generate two log entries for each inbound request.
To make an outbound call for the split request you need to add for instance a loadBalancer handler that matches the split hostname like this:
{
   "host": "split.example.com",
   "path": "/:file*",
   "method": ["POST"],
   "handlerName": "loadbalancer",
   "options": {
     "sources": [
       {
         "url": "https://some.other.website.com/webhooks/doStuff"
       }
     ]
   }
 },

I guess it should work to have the request fall through to the origin as well, but I haven't tested it :) I think one issue with current configuration you're using is that the host parameter only handles host and not any path (no sure about port.. might work).
Let me know if you're still having issues.

Thanks for the quick response!
After further deliberation, I don't think I had the use case right for the Split handler. As I understand, it splits an incoming request into two, redirecting it to another specified host. What I needed to do was receive an incoming request, validate it, and if valid, arbitrarily send out n requests to n endpoints (greater than 2). I came up with my own custom configuration to achieve this.

Ok, then I'll go ahead and close this issue


Release against 2.12.0-M3-dc9effe

Hi @rickynils!
As part of our 2.12 development, we're just about the switch to the new encoding of traits which is binary incompatible. To bootstrap our way through this change, we've released a Scala version 2.12.0-M3-dc9effe, which we will use as the new reference compiler until the release of 2.12.0-M4.
Our binaries will be in Maven Central within a few hours, but can be used immediately from Sonatype OSS in SBT with:
> set resolvers += Opts.resolver.sonatypeReleases

Could you please release "org.scalacheck" % "scalacheck_2.12.0-M3-dc9effe % "1.11.6" against this build? That will allow us to update the Scala build to use 2.12.0-M3-dc9effe while still being able to run our Scalacheck tests.
Note: during the release of 2.12.0-M3-dc9effe, we built our own copy of scalacheck_2.12.0-M3-dc9effe, but we only published this to an internal repository. So we don't anticipate any problems getting Scalacheck to build here.

@retronym The release should be up now!

Thanks!


fix: Sanitize bucketing col names

Relates

#2153

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: f8ee80758efe18b5bb82ace83c29916165e75312
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Registrator

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/91479
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" 787ee066284ac216fcbcbe36e1b5ceec8876324f
git push origin v0.1.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/94383
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.3 -m "<description of version>" 4bf89fb152d3c7fd411dc54717ff3973c74b3a25
git push origin v0.1.3

Also, note the warning: Version 0.1.3 skips over 0.1.2
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/94383
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.3 -m "<description of version>" f6b0ae6f5774ba9de580cbd4a1db74608b1b588e
git push origin v0.1.3

Also, note the warning: Version 0.1.3 skips over 0.1.2
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/94549
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>" bee0a7ce361d9e8d9ae1b73a2fe01970c60a0db8
git push origin v0.1.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/115924
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.3 -m "<description of version>" d5db7fc1eb8b9e48cbb6c004711a92325498aed1
git push origin v0.1.3


Adding fix for the menu builder and the bootstrap menu

Currently when editing menus from the Menu builder it will occasionally be blank in the modal and you will have to close it and open it again. This is because if you click on the text inside the 'Edit' button the e.target does not register and grab the data attributes for that menu item. Instead e.currentTarget needs to be used so the action of the button stays consistent.
I've also added a fix for the current bootstrap menu. Adding a dropdown and caret icon if it is a dropdown 👍

@marktopper @fletch3555 or @handiwijoyo Whenever you guys get a chance to merge this that would be great. I don't think we are merging our own PR's correct?
I wanted to add this fix because when I go to create a Bootstrap menu and implement it in a default laravel install, the dropdown didn't work, so I added a quick fix for that so that way I could create the Voyager Menu Screencast and show it working with the default bootstrap template.
Also, I added a fix to the builder when you go to edit a menu item :)
Thanks a ton.

Correct, we shouldn't be merging our own pull requests.  I'll review in a bit after I get home, unless someone else beats me to it.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/58330

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/95086

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/107374


Added metadata for Visual Basic Structures article

Added metadata for Visual Basic Structures article
Fixes #8915
I don't know that the metadata I've added will actually make the article surface when using the filter.
//cc @KathleenDollard

Closing, since the metadata doesn't really need to be updated.


If geom in first row returned by a sql statement with a function on the geom is NULL, all geoms become NULL

Eg. running a negative buffer on a file where the geometry for the first geometry that results in NULL will result in getting NULL for all geometries in the output file.
In the script below it is illustrated that

in the first sql_stmt, the geom in the first row becomes NULL and this results in all rows getting a NULL geometry
in the second one, the order by makes sure the first row is not NULL, which results in a correct output.

The issue boils down to gdal.
from pathlib import Path

import geofileops as gfo
import geopandas as gpd
from shapely import Polygon

# Prepare test data
data = [
    {
        "descr": "polygon1",
        "geometry": Polygon([(0, 0), (0, 5), (5, 5), (5, 0), (0, 0)]),
    },
    {
        "descr": "polygon2",
        "geometry": Polygon([(0, 0), (0, 15), (15, 15), (15, 0), (0, 0)]),
    },
]
input_gdf = gpd.GeoDataFrame(data=data, crs=31370)  # type: ignore

tmp_path = Path("C:/temp")
input_path = tmp_path / f"test.gpkg"
gfo.to_file(input_gdf, input_path)
layer = gfo.get_only_layer(input_path)
distance = -5
sql_stmt = f"""
    SELECT ST_CollectionExtract(
               ST_Buffer({{geometrycolumn}}, {distance}, 5), 3
           ) AS geom
          {{columns_to_select_str}}
      FROM "{layer}" layer
"""

# If first row becomes NULL due to the function, all geometries become NULL.
result_path = tmp_path / f"test_select_null.gpkg"
gfo.select(
    input_path=input_path,
    output_path=result_path,
    sql_stmt=sql_stmt,
)
result_gdf = gfo.read_file(result_path)
print(result_gdf)

# When the rows are ordered so the first row is not NULL, result is OK.
result_path = tmp_path / f"test_select_null_ordered.gpkg"
sql_stmt = f"SELECT * FROM ({sql_stmt}) ORDER BY geom IS NULL"
gfo.select(
    input_path=input_path,
    output_path=result_path,
    sql_stmt=sql_stmt,
)
result_gdf = gfo.read_file(result_path)
print(result_gdf)

Issue opened in gdal: #308

Fixed in gdal >= 3.8


Update Komenci to the new version

Description
Deployed new version of Komenci on Alfajores

@codyborn I've deployed this version to all the clusters today and everything went well. Would you lend me your approve? 😂

@codyborn I've deployed this version to all the clusters today and everything went well. Would you lend me your approve? 😂


Prevent Confirm Form Resubmission Pop Up

Prevent browsers from resubmitting post data so that reload clears the page

being fixed by #39


update service not working

The updates on owl-schema don't appear in the ontology service, see for instance
http://purl.bdrc.io/ontology/core/langBCP47Lang
while it's defined in this commit

I made sure that models were reloaded for all request sent after the update process. Seems to be working fine now.
However, the ontology browser doesn't show domain and range info and labels and comments for properties. Fixing that now.

props display fixed as of commit 89bee3a


Question to the example picture "With provided image"

Sup @xguitoux how did you manage to get Last completed: 5 days ago like in your example picture?

Did you change the js or am I missing an option in your configuration to do so?

Hello @Pr0mises, the last completed attribute is already present in the code, just use this : last_completed (that said Bosh interface has to provide it yet, I'm not able to test atm)


Added enabled attribute to clients

Clients can be enabled o disabled.

Pull Request Test Coverage Report for Build 77

13 of 23 (56.52%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 65.494%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/Entity/ClientEntity.php
5
6
83.33%

lib/Repositories/ClientRepository.php
3
4
75.0%

lib/Services/DatabaseLegacyOAuth2Import.php
0
2
0.0%

lib/Services/DatabaseMigration.php
1
7
14.29%

Totals

Change from base Build 75:
-0.4%

Covered Lines:
484

Relevant Lines:
739

💛  - Coveralls


What is the version of beam-runners-flink-1.11 which support JDK 17

What needs to happen?
Need to know version of beam-runners-flink-1.11 which support JDK 17
Issue Priority
Priority: 1
Issue Component
Component: beam-community

Like #22041, please ask on<EMAIL_ADDRESS>


Add Dockerfile and Makefile rule for nodeagent-k8s image.

The binary file path is nodeagent_k8s and the image name is nodeagent-k8s.
make docker.nodeagent-k8s will generate nodeagent-k8s image.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
Assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @wattli


Issue calculating static polarizability using RSH exchange-correlation functionals

Hello, everyone. I need to have access and freedom to work with the A and B matrices from coupled-perturbed KS. So, I'm trying to use the following code together with the CAM-B3LYP functional for static polarizability. However, the code doesn't work for this functional or any other RSH tested. It is curious since the code works properly for any other XC functionals, e.g., GGA, Hybrids, etc. I see someone with a similar issue and the fix was to change from LibXC to XCfun. But, this is not working for me. Can someone help me, please?
Results using the attached code:
Static polarizability from reference: 1.4907486930182852 (the right answer)
Static polarizability is: 1.3051766863495733
PS1: I also tried "a, b = tddft.TDDFT(mf).get_ab()". I still have the same issue with RSHs.
PS2: Using "rks.Polarizability(mf).polarizability()" works with RSH functionals (that's how I debug the results, i.e., reference). However, I don't know how to or if I have access to A and B using this code.
Thanks.
cpks.zip

RSH was not considered in get_ab. This issue has been fixed in the latest commit.

It worked. Thank you very much.


Add more options to define environment variables (global/project/step)

It would be very cool to have an option to define environment variables on a global level and project level in the pipeline file.
Buildkite had that option in version 2 to have global env vars but they removed it in v3 for some reason.
I have something in mind that could look like this:
projects:
  - label: project-xyz
    path: path/to/my/project
    env:
      THIS_IS_A_PROJECT_SCOPED_ENV_VAR: def456

env:
  - THIS_IS_A_PIPELINE_GLOBAL_ENV_VAR: abc123

steps:
  - label: ":docker: build - "
    command: echo "this is a build step"
    env:
      THIS_IS_A_STEP_SCOPED_ENV_VAR: xyz999

Buildpipe could already take care of the double dollar signs needed for some of those variables depending on where they are defined in the pipeline.

Makes sense @mowies. Care to make a PR :-)?

Yes, I'm gonna try this weekend :)


Xvbf fails to start with Host RHEL 9.3 + Docker 25.0.3 + Cypress Base Image

After upgrading our Build Servers to RHEL 9.3 our Gitlab CI/CD Steps running Cypress Tests started to fail.
[FAILED] Cypress Version: 13.6.6
Cypress failed to start.
This may be due to a missing library or dependency. https://on.cypress.io/required-dependencies
Please refer to the error below for more details.
----------
[31:0322/115354.489665:ERROR:bus.cc(407)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
[31:0322/115354.873807:ERROR:ozone_platform_x11.cc(240)] Missing X server or $DISPLAY
[31:0322/115354.873822:ERROR:env.cc(255)] The platform failed to initialize.  Exiting.

After lots of trail and error I could pinpoint the issue to Xvfb as it did even fail after starting Xvfb manually with
Xvfb -ac :99 -screen 0 1280x1024x16 &
export DISPLAY=:99

I tried lots of different cypress images include cypress/base:latest and cypress/browsers:node-20.9.0-chrome-118.0.5993.88-1-ff-118.0.2-edge-118.0.2088.46-1.
We could verify that this is a problem with the combination of RHEL 9.3, Docker and the cypress base image, as we could get it to run again by using ubuntu:latest and installing the requirements, so there is probably some incompability between RHEL 9.3 and the cypress base images.

@whlucky care to share your setup or functioning Dockerfile if you can, please? 🙏
I am running into similar issues and I could use some guidance.

@podlesny-j sure:
FROM ubuntu:latest
RUN apt-get update
RUN apt-get install -y curl
RUN curl -fsSL https://deb.nodesource.com/setup_21.x | bash
RUN apt-get install -y nodejs
RUN apt-get install -y libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libnss3 libxss1 libasound2 libxtst6 xauth xvfb

Just the latest ubuntu image with all cypress dependencies installed.

@whlucky
Are you still experiencing this issue? If yes, then please try with latest Cypress Docker images which are now based on Debian 12.5.
The workaround you posted in https://github.com/cypress-io/cypress-docker-images/issues/1028#issuecomment-2037126432 uses ubuntu:latest which would be Ubuntu 24.04 at this time. Note that if you are using this version of Ubuntu, then a different set of Ubuntu dependencies for Cypress applies (see Linux Prerequisites).  Also Node.js 21 reached end-of-life on June 1, 2024 and is no longer supported by Cypress (see Node.js).

Closing.
We can re-open if there is new information available.


AP-4399: Rename organisation columns part 1

What
Alias organisation attributes prior to rename
Link to story
These names are clearer descriptions of their data content and
purpose as well as what is currently returned from LFA's
organisation endpoints.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

Have approved as the pr looks fine. Not really sure about the naming; on the one hand I see the logic of ccms_type_code and ccms_type_text as they will be part of the ccms injection payload on the other hand ccms_type_text is something we will display to our users so will also have a meaning in apply (especially if we ever move away from ccms!) Think this option is fine though plus as you say consistent with the changes made in LFA.

thanks 👍 , yes ccms_type_description or type_description make sense for the second attribute too, but feel icky in other ways. naming things is hard, but at least consistency and grepability will be achieved with these names.


fix(font): replace removed characters with valids

Some nerd-font characters have been removed. I fix them using nerdfix.

Thanks for that!


add some demo scripts ~

demo scripts like : show cdrs, setup a quickcall .

@kevinlovesing Howdy, thanks for the examples.  We are working on a tool to build a documentation site from the doc folders in our various projects.  If the examples are not present there then they would not be included, so would you mind moving these to https://github.com/2600hz/kazoo-php-sdk/tree/master/docs/Examples and re-issuing the PR?

ok,i will issue a nee PR.


new tag?

Thanks for merging the pull requests!
I'm not religious about it, but it would be better to reference a KVC tag, rather than a git hash. Care to consider rolling out one? Thanks

https://github.com/etrepum/kvc/releases/tag/v1.7.0

Thanks!
On Sat, Mar 12, 2016 at 11:15 PM, Bob Ippolito<EMAIL_ADDRESS>wrote:

https://github.com/etrepum/kvc/releases/tag/v1.7.0
—
Reply to this email directly or view it on GitHub
https://github.com/etrepum/kvc/issues/12#issuecomment-195818550.

--
andreineculau.com http://www.andreineculau.com


Errors running 3 way genome comparison

Hi
I am trying to run plotsr but get the following error:
Traceback (most recent call last):   File "/home/FCAM/alotter/miniconda3/envs/py38/bin/plotsr", line 4, in <module>     __import__('pkg_resources').run_script('plotsr==0.5.2', 'plotsr')   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/pkg_resources/__init__.py", line 656, in run_script     self.require(requires)[0].run_script(script_name, ns)   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/pkg_resources/__init__.py", line 1460, in run_script     exec(script_code, namespace, namespace)   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/plotsr-0.5.2-py3.8.egg/EGG-INFO/scripts/plotsr", line 6, in <module>   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/plotsr-0.5.2-py3.8.egg/plotsr/main.py", line 54, in main   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/plotsr-0.5.2-py3.8.egg/plotsr/plotsr.py", line 161, in plotsr   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/site-packages/plotsr-0.5.2-py3.8.egg/plotsr/func.py", line 824, in validalign2fasta   File "/home/FCAM/alotter/miniconda3/envs/py38/lib/python3.8/posixpath.py", line 142, in basename     p = os.fspath(p) TypeError: expected str, bytes or os.PathLike object, not _io.TextIOWrapper

Based on this error message, it is difficult to say why you are getting this error. Is this the entire error message or was there something more? Could you please also share the command that you used as well as the genomes.txt?

Hi
Here is the command I used:
plotsr \         --sr v2_eghap.out \         --sr eghap_euhap.out \         --sr euhap_v2syri.out \         --chrord chrord.txt \         --genomes genomes.txt \         -o egv2_eg_eu.svg
And the genomes.txt
#file   name    tags eg.v2.chr.fasta EGRv2   lc:#C00000 eg.chr.fasta    EGR     lc:#00B050 eu.chr.fasta    EUR     lc:#1E6CD1
That is the entire error message.

The input filename reads 'v2_eghap.out' and not 'v2_eghapsyri.out'. Is this the correct input filename? Other than that everything looks fine, so unfortunately I don't have any obvious reasons why this could be happening.
Have you tried plotting the example sample? Maybe try that to see whether the issue is with plotsr or how your files are setup.
Also, please make sure that the columns in genomes.txt are separated by tabs and not spaces.
Could you generate the plot with two samples? Maybe, test different combinations of two samples. Also, try without using the --chrord option. Otherwise, do you have a minimalist example (genomes fasta, syri.out, and genomes.txt) that you can share for me to check.

Hi
I do not have an example file, but used the plotsr previously with syri before this version was released where multiple alignments are possible (it worked then with only two). I am running the example files now as well as syri again and will see how it goes.

Hi,
I found a bug in one of the error-handling lines. It is fixed now. You can update plotsr using the following commands:
git clone https://github.com/schneebergerlab/plotsr.git
cd plotsr
python setup.py install

However, as the bug was triggered by an error, I would assume that it would still not work out-of-the-box for your data.
The error is happening because alignment coordinate is more than the chromosome length in the genome fasta. This is obviously not possible, suggesting inconsistencies. So, you would have to check for that.
Best
Manish

Hi
So, it seems that it is fine with the first two files, but the third is an issue. I even reran with SyRI v1.5 (although the number of rearrangements differ then, which I assume could be due to not running nucmer as well to use as input for mummer) and it still gave an error. The third plot was supposed to be going back to the original first reference i.e. the first line overall, which is a bit bigger in size than the other two assemblies.
I also have a question about the visualization because using the original output files, the number of duplications seem a lot higher than when I used plotsr that was still part of SyRI? I think it has to do with the line width being larger so the events seem clearer.
Kind regards

I just realised that you have three comparisons (AvsB, BvsC, CvsA) so that would require 4 genomes (A, B, C, A) in the genomes.txt file. Sorry for not noticing that earlier.

the number of duplications seem a lot higher than when I used plotsr that was still part of SyRI?

I cannot think of any changes being made that would increase the number of duplications compared to the earlier versions. Nevertheless, plotsr does not call duplications, so as long as all the plotted duplications are in the input file, I would consider this to be ok.

Also some previous translocation (green) changed to duplications and vice versa. Does it handle the information differently?

For highly repetitive regions, syri uses some heuristic which could result in this. Or do you mean that with the same input plotsr plotted different translocations/duplications? If the changes are happening in syri output, then it is OK; if they are happening in plotsr then possibly a bug.

Hi
I meant the plotting looks different with the new plotsr package using the same syri input file for example
syri plotsr python script

vs
new plotsr version

This is the same chromosome and same syri.out file used
Adding the 4th fasta file worked. Thanks :). For interest sake, would it still work if comparison in the syri.out file was in the wrong order for the visualization (i.e. switched reference and query)?

Hi,

would it still work if comparison in the syri.out file was in the wrong order for the visualization

It is possible to visualise AvsB, BvsA, AvsB and so on, the requirement is that the order of genomes in comparisons is same as that in genomes.txt. So, in this case, the genomes.txt would need to have genomes A,B,A and B. I hope this makes it clear.
I agree, the plots do look different. I guess that curved paths are just more visible making it look like there are more SRs. The translocation/duplication switch in the middle is weird though. Can you please check in the syri.out what is the correct annotation? I suspect a bug, not sure whether it was in the old version or new :D
Best
Manish

Yeah, it seems syri called it an INVDPAL, so it is a duplication then. I wonder why then the old plotsr saw it as a translocation.

Yes thanks I am all clear with the explanation.

Great! I will close this issue then.


[Indigo] [Integration] Adapt UI Library with the needs of other UI teams and add needed documentation.

Description
We are going to make UI consistent by adapting our UI component library to the needs of other UI teams, so they can use it directly.
After doing the adaptation, we can merge it into main so other teams can import them directly.
Component Adaptation

[ ] BPDropdown
[ ] BPCheckboxGroup
[ ] BPButton
[ ] BPTable (if needed)

Documentation

[ ] Intro
[ ] Usage
[ ] Examples

The changes will be in branch indigo-137-ui-adaptation.

Documentation is located at https://indigo.lingxi.li/

Will Add BPTable if needed in the future.


Add linux64-ncurses6-nopie bindist

I build this on an up2date Archlinux 64bit machine. See https://github.com/commercialhaskell/stack/issues/3268 for some of the discussion relating to this. Eventually it would also be nice to have this hosted in the same repo as all the other bindists but I’m fine with hosting it myself for now.

Any chance of this being merged or someone telling me what is needed to get it merged? Without this, stack is sadly still broken by default (i.e. without installing unsupported ncurses ccompatiblity packages) on Archlinux.

Yes please. I am watching this issue and hoping it gets fixed soon. Action from the maintainers would be much appreciated.

@cocreature Sorry about that, apparently I wasn't watching this repo so I didn't get any notification for this PR.  I've uploaded your bindist to https://github.com/commercialhaskell/ghc/releases/download/ghc-8.0.2-release/ghc-8.0.2-x86_64-arch-linux-ncurses6-nopie.tar.xz.  Can you update the URL?

I was able to update it in the URL when I tried it. thank you!
$ stack setup --ghc-variant=arch-linuix --ghc-bindist=https://github.com/commercialhaskell/ghc/releases/download/ghc-8.0.2-release/ghc-8.0.2-x86_64-arch-linux-ncurses6-nopie.tar.xz
and
$ stack install --ghc-variant=arch-linuix
success
info:
$ uname
4.12.3-1-ARCH

$ stack --version
Version 1.5.0 x86_64

@borsboom I just updated the url.

Great, thanks!

If you have any time to build bindists for 8.2.1 and 7.10.3 that would be awesome.  I'll get them merged much faster next time!

It’s on my list of things to do but I can’t make any promises when I’ll get to it. Thanks for merging!

why there is no more 8.2.2 for linux64-ncurses6-nopie
No information found for ghc-8.2.2.
Supported versions for OS key 'linux64-ncurses6-nopie': GhcVersion 8.0.2, GhcVersion 8.2.1

There never was a bindist for 8.2.2 for this flavor. When I made these bindists 8.2.1 was the latest release. I'm sure if someone makes bindists for 8.2.2 the maintainers will be happy to accept them.
Am 23. Dezember 2017 15:08:20 MEZ schrieb Daniel Yu<EMAIL_ADDRESS>
why there is no more 8.2.2 for linux64-ncurses6-nopie
No information found for ghc-8.2.2.
Supported versions for OS key 'linux64-ncurses6-nopie': GhcVersion
8.0.2, GhcVersion 8.2.1

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/fpco/stackage-content/pull/26#issuecomment-353727900

@cocreature Pinged you in https://github.com/commercialhaskell/stack/issues/3636#issuecomment-353786065.  Wondering whether ncurses6 should still be needed for Arch Linux since in my tests the tinfo6 build seems to work.


Zhenhui lgb

Description

Add LightGBM application for Recommenders on a sample data from CRITEO, please refer to "notebooks/00_quick_start/lightgbm_tinycriteo.ipynb".
Additionally, there are some utils file added to "reco_utils/recommender/lightgbm" and related package like "lightgbm==2.2.1" and "category_encoders>=1.3.0".
Related Issues

None.
Checklist:

[x] My code follows the code style of this project, as detailed in our contribution guidelines.
[x] I have added tests.
[x] I have updated the documentation accordingly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: motefly sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Updated README.md - Added Streamlit based Web App 👨✅

Hi @mftnakrsu ,
Kudos to you for your work on Auto. NPR. I worked on developing a simple streamlit based web app for this as an extended version and I think it will be fruitful to have it as a part of README here as the motivation behind developing this came from your work 😄!
Title: Streamlit based Automatic Number Plate Recognition
Github Repo: https://github.com/prateekralhan/Streamlit-based-Automatic-Number-Plate-Recognition
Happy opensourcing!

Good work ☺👍

@mftnakrsu Thank you! 😀


The leaderboard is missing in https://paperswithcode.com/sota/speech-recognition-on-common-voice-7-0-15

We found the leaderboard is removed recently by the official, thus we choose to close this issue for now.


Reverse Z Projection matrix to Infinity

I needed this for my game, and thought, since this is a math library for games, I would share.
Reverse Z is common place now in OpenGL to improve depth precision. I made use of that by extending the far plane into infinity. This function conveniently does both.

Ill take a look at this when i get home :)

Looks fine to me, although if we want to include it we should probably also write a quick test. I just wonder if it's commonplace enough to include in the library vs. just letting people write it themselves, but that's @StrangeZak's call.
We'll also want to do a quick style clean-up before merging.

Looks good, @JesseRMeyer wanna write a quick test for it in the unit test file. If not i can do it!

Sorry, I don't currently have the time this week to write the test.

Necro'ing here. Are there standards for tests? A good test for a projection matrix of this kind sounds like quite the task.

@JesseRMeyer Here's how the Perspective function is currently tested: https://github.com/HandmadeMath/Handmade-Math/blob/master/test/categories/Projection.h#L16-L36. It's probably not thorough enough, as you can see, but it's a good sanity check at least.
The other option would be to just verify a correct projection matrix and hardcode its values into a test. Not the most elegant, but since this is a math library, there should only be one right answer.

Also, since the original branch is over a year old (!) you might consider rebasing your work onto the latest master from this repo.

All sensible points. Thanks. I'll look into this this weekend.

Closing this PR. If you ever wanna merge this feel free to open a new one :)


add coveralls

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a99db84). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   68.36%
  Complexity        ?       66
=========================================
  Files             ?       28
  Lines             ?      196
  Branches          ?        8
=========================================
  Hits              ?      134
  Misses            ?       56
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99db84...20cc2a9. Read the comment docs.


institut saint jean school

@wilfried-djoum First stage of verification passed, official domain is institutsaintjean.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@wilfried-djoum Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Cannot fetch HMAC secret code

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 2.6.0
Current Behavior
My HMAC credential name is get from iPhone's identifierForVendor, e.g. 26DE073B-7835-48AD-917C-8E9F34E6A217
In case I try to get credential, but return {"message":"Not found"}
curl -X GET http://kong:8001/consumers/email}/hmac-auth/26DE073B-7835-48AD-917C-8E9F34E6A217

Expected Behavior
Should return as bellow
{"secret":"xxxxxxxxxxxxxx","username":"26DE073B-7835-48AD-917C-8E9F34E6A217","consumer":{"id":"ac654f30-5a10-43ec-8196-xxxxxxxxxxxxxx"},"id":"e44cfbad-4b34-4c91-9177-xxxxxxxxxxxxxxxx","created_at":1637628953,"tags":null}

Steps To Reproduce
1.  I think you folks encountered issues like this before, what was our solution at the end?

Dear contributor,
We're closing this issue as there hasn't been any update to it for a long time. If the issue is still relevant in the latest version, please feel free to reopen it. We're more than happy to revisit it again.
Please have a look at our pledge to the community for more information.
Sincerely,
Kong Gateway Team


Redesign site + adds logo

Adds a new front-page as well as a new logo licensed by CC0.

A lot to take in a lot happening here.
Essentially, a massive redesign of the website as well as the introduction of a new (licensed by CC0) logo.
In order to test this out / preview it:

Install Jekyll
Pull down this branch
jekyll serve .

Otherwise, you can find a preview of the new front-end / logo:

ping @kadel @surajnarwade @surajssd @pradeepto

Comments as per discussion on chat.

Going to merge this in as-is so we can have a live-preview and have people comment on it / make PR's for any changes.

It would be nice, to sum up what you have talked about or better paste chatlog or at least say where the chat took place :-(
I wasn't able to find it :-(


Collapse to week

Hi, would it be possible to collapse the calendar view to see only the week instead of the whole month? This way there would be more space for content.
Something similar to this from FSCalendar:

Thank you

I was wondering the same thing!! Maybe just the week view without the toggle option... is there any way to do that from the source code?

It's possible but it would take a lot of labor to write the code for that. When I initially wrote the library, I didn't think of adding flexibility to the actual calendar view component. There's a lot of flexibility in the custom view component however.


Support for .NET 4.6.2?

Is this project going to support .NET 4.6.2?
David

LINQKit does not use any special features from .NET 4.6.2 , so a new build or NuGet is not needed. NuGet will automatically use 4.6.1

Well I had to back all of my projects back down to 4.6.1 due to switching to 4.6.2 made LINQKit break compiling. Moving to 4.6.1 fixed the compile. Did it now pull down the correct version maybe?

I created a NET 4.6.2 project in VS2015 and I had no problems installing + compiling LinqKit or LinqKit.Core.

@RealDotNetDave does this answer your question ? Or so you still need help?


@Api - Value is ignored

Hello,
I've recently upgraded from 2.20 to 2.4.0, after upgrading I've noticed that the value I have in the API annotation is being ignored.
@Api(value = "pet", description = "describes pets")
public class PetRestController
{
...
}

The generated tag in the JSON is:
...
"tags": [
    "pet-rest-controller"
]
...

I would have expected Swagger to have picked up on my value defined in the API annotation.
I have achieved what I wanted with the snippet below, but is it a bug that value is no longer used to create a default tag and can anyone else replicate this? If not, I would have expected it to be deprecated like other attributes of the annotation
@Api(value = "pet", description = "describes pets", tags="pet")

Closing - as this is a duplicate of #1229


Launching UWP app with activated args

When UWP app is able to start with URI "registered" in the OnActivated method, is it somehow possible to specify this URI for example in DeviceCapabilities?
In my case I would like to bypass an identification screen which requires additional input which I don't have when writing unit test.
It's kind of similar to issue/question #29

Hi @Pebin,
Since v1.0-RC release. Windows Application Driver can now launch an application with command line arguments. Below is an example of starting Microsoft Edge on a given URL specified as launching parameter.
DesiredCapabilities appCapabilities = new DesiredCapabilities();
appCapabilities.SetCapability("app", "Microsoft.MicrosoftEdge_8wekyb3d8bbwe!MicrosoftEdge");
appCapabilities.SetCapability("appArguments", "about:blank");
WindowsDriver<WindowsElement> session = new WindowsDriver<WindowsElement>(new Uri(CommonTestSettings.WindowsApplicationDriverUrl), appCapabilities);

The snippet above is taken from CreateSessionWithArguments_ModernApp test scenario. Would you please give it a try and reopen if you encountered any issue?


Auto-adjust images orientation using EXIF data

Proposed fix to auto-adjust images orientation using EXIF data. Requires a gregwar/image library upgrade.

Need to wait for https://github.com/Gregwar/Image/pull/109 to be merged

Upstream PR merged, we now need to wait for a release unless we want to use the latest develop of that library. Last release was 1 year ago, need to check if a release is planned in the near term or not.

Crazy we haven't merged this one yet.
I propose we just fix the dependency to the latest commit which is all about fixOrientation anyway.
When you have a moment, @flaviocopes, could you sync and update this PR to:
"gregwar/image": "master#72568cfbeb77515278f2ccb386fc344e874b7ae8"

Then we just go ahead and merge it in, I don't foresee any release anytime soon, at least we can move on with this issue. Whenever a release happens we can just revert to the versioning reference.
// commit ref. 72568cf

Ok slightly modified the approach. Uses a system configuration option which defaults to false, to avoid changing how images currently work.
Once that setting system.images.auto_fix_orientation is enabled, any image will be processed and cached even if they don't have any processing options, and orientation will be automatically fixed on them.
Going to merge soon if you don't have any objection.

(have corresponding language translation ready for Admin)


Write function to generate API key for each user

This would probably be a long-running token on Auth0.

Research how to do this with Auth0 and suggest a specific solution. Discuss this as a group.
Write a simple function to generate an authentication token that won't expire within 30 days at least.

Do you think we should use auth0 or our own token system for this?
I'm not sure if we're really supposed to use Auth0 here, if they have a decent system set up.
Some possible relevant links:
https://auth0.com/docs/api-auth/dynamic-client-registration

We are going to get foretold JWT token for Agent by Auth0 each time when it needed. @OAGr How do you think?

On the staging and prod new env are set.

I think we may be thinking of different things. I was thinking something like what's discussed in task #100.


Crash while loading a song .json

Describe your bug here.
I played a song in freeplay menu, and i get this error

Command Prompt/Terminal logs (if existing)
Note.hx (line 158)
PlayState.hx (line 2498)
PlayState.hx (line 1086)
flixel/FlxGame.hx (line 637)
flixel/FlxGame.hx (line 724)
flixel/FlxGame.hx (line 677)
flixel/FlxGame.hx (line 545)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Uncaught Error: Null Object Reference
Please report this error to the GitHub page: https://github.com/ShadowMario/FNF-PsychEngine

> Crash Handler written by: sqirra-rng

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

I fixed it, nevermind


Add iu.edu.tr (Istanbul University)

Add Istanbul University (ogr.iu.edu.tr)

@kadircanerergun I am sorry, the domain ogr.iu.edu.tr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


How to switch between different spectra?

When I have two different files open in the same session, how to I switch between them?

Do you mean open as in you have two files loaded in Pyfocal (visible in the top left list), or open as in you have two plot windows open?

So, I have two plot windows. But then I click the "maximize" button on one of the plots. Now I can't find a way to switch to the other one. Clicking the layer of the other one does not switch the display.

Actually, I can't even get to the layers of the other one in another try. Clicking its name under "Data" does not switch out the layers.

I see. This would require connecting the selection event of the layer item to the "set active" function of the sub window object.
Currently, you'll have to un-maximize the sub window and select the other one manually.

This is what I see (Anaconda, Qt4) when it is maximized. I cannot figure out how to un-maximize it. :see_no_evil:

Weird, this is what I see with PyQt5:

And with PyQt4:

This may be a linux issue. What distro are you running?

Standard STScI RHEL6 machine. Should be the same as one of the science clusters if you want to test under Linux yourself.


Wayland: Assume 96 DPI if physical size is <= 0

This fallback is similar to the one performed in the "X11: Assume 96 DPI if RandR Monitor Size is zero" commit: https://github.com/glfw/glfw/commit/e96dc5d2199032d565b55c4177820ab28b1d67c9
Nicolas Caramelli

Thanks! This indeed helps on projectors and other outputs which don’t have an intrinsic size.

Would it be possible to do this in outputHandleGeometry in wl_monitor.c instead of having it as a separate pass?

The outputHandleGeometry() callback is called before the outputHandleMode() callback which provides width and height
But yes we can do something in the outputHandleMode() callback, that's another solution!
I created another pull request if you prefer to use this method: https://github.com/glfw/glfw/pull/1792


ios  cannot open

Describe your problem here.
When I installed and turned on 0.7.2psych, it blinked
Are you modding a build from source or with Lua?
I am not modding
What is your build target?
iOS
Did you edit anything in this build? If so, mention or summarize your changes.
I didn't do anything

Give more info please

Give more info please

It's okay, I was able to open lol normally after disconnecting the network lol

I'll make Check For Updates disabled for iOS


How is indexing supposed to work?

I've been trying to understand the indexing evaluation code, and so far I'm mostly failing. The ast looks like the following
rhai> ["ab", "cd"][0][1]
=> 'b'

rhai> astu
[snip]
            Index(
                Array([snip]),
                Index(
                    IntegerConstant(0, (1:14),),
                    IntegerConstant(1, (1:17),),
                    (1:16),
                ),
                (1:13),
            ),
[snip]

with a literal interpretation of the tree being we are indexing the constant 0 with the constant 1, instead of a tree like
            Index(
                Index(
                    Array([snip]),
                    IntegerConstant(0, (1:14),),
                ),
                IntegerConstant(1, (1:17),),
            ),

I also don't believe that the evaluation rules are currently implemented as intended, since they apparently change depending on how values are created:
rhai> "cat"[print("b")]

"cat"[print("b")]
      ^ Indexing into an array or string expects an integer index

rhai> {"cat"}[print("b")]
b
=> [()]

So what is the intended evaluation order?

Expanding on my general expectations, where a, b, c, and d are arbitrary expressions I would expect
a[b][c][d] = Ast(Index(Index(Index(a, b), c, d))

and evaluation order to go
a_val = evaluate a
b_val = evaluate b
i1_val = evaluate Index(a_val, b_val)
c_val = evaluate c
i2_val = evaluate Index(i1_val, c)
d_val = evaluate d
i3_val = evaluate Index(i2_val, d)

I get the impression that this is not the order the code is intending to evaluate things in, but I do not understand why.

You're picking the hornet's nest!  Indexing is the most complicated part of the entire thing.
The core reason being: indexing and dotting (they are pretty much the same things) are bound to the right instead of to the left.  So:
a[b][c][d] = Ast(Index(a, Index(b, Index(c, d)))

In order to evaluate this expression, you recurse into the chain, first getting index b of a, then recurse to get index c of the result a[b], then further recurse to get the index d of a[b][c].
Binding to the left, and your intuition goes, is easiest for evaluation -- i.e. reading a value.  Binding to the right, however, is necessary if you want to assign a value into the chain.
For example:
a[b][c][d] = x;

Think how you can actually update the nested array which sits all the way in a down the left side of the chain -- all the levels of indexing (and dotting) are merely operators that act on the value of a.  If a sits at the end of a recursion chain, you're going to have problems.
Thus, indexing and dotting bind to the right.

{"cat"}[print("b")]

Unfortunately, this is actually two statements:
{
    "cat"
}
[ print("b") ]

The first one is a block statement returning "cat".  The second statement is an array with one element which is the result of print("b"), thus [()].

I get the impression that this is not the order the code is intending to evaluate things in, but I do not understand why.

You're correct.  That's not the order, and it is because when you're doing an assignment (i.e. updating), you need to act on the ultimate root value itself.
eval_indexed_chain in engine.rs evaluates down an indexing chain to get the values of all indexing expressions.  You can base your evaluation code on this.
Once you get a StaticVec of values that represent the result of each indexing expression, you can use them to index into the root variable.  Check out eval_dot_index_chain.

Thanks for the explanation! After that and a fair bit of playing with code it makes sense :)
For the next person who comes along, this really is the key part:

let a = [9, 8, 7];
a[ { a = [1, 2, 3]; 0 } ]

If we try to evaluate a before we evaluate any part of the index chain, then we need to hold a mutable reference to it the whole time. Since we are holding a mutable reference to a variable we can't modify it (and without a lot of work, we actually can't modify any variables).
Rust solves this problem and uses the naive evaluation order by using the borrow checker to prevent modification of a. Python solves this problem by using the naive evaluation order and making a just a pointer to an object, and not caring/dropping the object if we change what a refers to before we mutate it. Since we don't have a borrow checker and haven't wrapped everything in pointers, we are "stuck" being a bit more clever.
To re-iterate the proper execution order at the bottom of the issue instead of in the giant walls of text above:
in a chain a.b[c].d:

Evaluate the expressions except the first one (a) in left to right order, (b, c and then d)
Evaluate the first expression (a)
Evaluate indexing/dot operators in left to right order (obj = a.b, obj = obj[c], and then obj = obj.d).

Thanks again!

This is a good summary.  Something to add about why this evaluation order is needed:
Indexing is not an operation on a piece of data.  It does not convert some value to another.  It refers to a portion of a piece of data.  In other words, it is a referencing operator.  Therefore, an assignment into an indexing chain means overwriting the portion of the data as specified by the "coordinates" which are the index values.
Make sure when you evaluate a chain, you need to make sure that you don't unnecessarily copy data around.  For example:
a[b][c][d]

Means that a is a multi-dimensional nested array structure, and you're referring the piece of data located at coordinates b,c,d.  The bad thing to do is to first take temp = a[b], which is actually a nested array itself.  You need to make sure you don't copy this array into temp - which may be large.  Once you get this sub-array, you then take temp2 = temp[c], yet another array, and again you don't want to copy it into temp2.
What you really want is to build a reference based on these coordinates, and then simply offset into the root array structure and directly access/update the location.


[SPARK-24709][SQL][FOLLOW-UP] Make schema_of_json's input json as literal only

What changes were proposed in this pull request?
The main purpose of schema_of_json is the usage of combination with from_json (to make up the leak of schema inference) which takes its schema only as literal; however, currently schema_of_json allows JSON input as non-literal expressions (e.g, column).
This was mistakenly allowed - we don't have to take other usages rather then the main purpose into account for now.
This PR makes a followup to only allow literals for schema_of_json's JSON input. We can allow non literal expressions later when it's needed or there are some usecase for it.
How was this patch tested?
Unit tests were added.

Merged build finished. Test PASSed.

Test build #97605 has started for PR 22775 at commit 2705aa8.

This should be targeted to 2.4 .. otherwise we should describe the behaviour change at migration note.

Test build #97605 has finished for PR 22775 at commit 2705aa8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97605/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4128/
Test PASSed.

Test build #97610 has started for PR 22775 at commit 2705aa8.

Test build #97610 has finished for PR 22775 at commit 2705aa8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97610/
Test FAILed.

The latest Python failure looks relevant to this PR.
AnalysisException: u"cannot resolve 'schemaofjson(`value`)' due to data type mismatch: The input json should be a string literal and not null; however, got `value`.;;\n'Project [schemaofjson(value#2191) AS json#2194]\n+- LogicalRDD [key#2190L, value#2191], false\n"

Yup, will fix.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4141/
Test PASSed.

Test build #97631 has started for PR 22775 at commit 9cb0b94.

Test build #97631 has finished for PR 22775 at commit 9cb0b94.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97631/
Test FAILed.

Ah.. let me rebase and sync the tests

Test build #97640 has started for PR 22775 at commit c132407.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4149/
Test PASSed.

Test build #97640 has finished for PR 22775 at commit c132407.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97640/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4155/
Test PASSed.

Test build #97646 has started for PR 22775 at commit c132407.

Test build #97646 has finished for PR 22775 at commit c132407.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97646/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4158/
Test PASSed.

Test build #97649 has started for PR 22775 at commit c132407.

Test build #97649 has finished for PR 22775 at commit c132407.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97649/
Test FAILed.

retest this please

Test build #97661 has started for PR 22775 at commit c132407.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4169/
Test FAILed.

Merged build finished. Test FAILed.

Test build #97661 has finished for PR 22775 at commit c132407.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97661/
Test PASSed.

@cloud-fan, mind taking a look please?

Test build #97905 has started for PR 22775 at commit dbf9cab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4395/
Test PASSed.

Test build #97905 has finished for PR 22775 at commit dbf9cab.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97905/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4398/
Test PASSed.

Test build #97910 has started for PR 22775 at commit dbf9cab.

Test build #97910 has finished for PR 22775 at commit dbf9cab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97910/
Test PASSed.

Merged build finished. Test PASSed.

retest this please

@cloud-fan, looks we are going to start another RC. Would you mind if I ask to take a quick look before the new RC?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4463/
Test PASSed.

Test build #98001 has started for PR 22775 at commit dbf9cab.

Test build #98001 has finished for PR 22775 at commit dbf9cab.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98001/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4469/
Test PASSed.

Test build #98008 has started for PR 22775 at commit dbf9cab.

Test build #98008 has finished for PR 22775 at commit dbf9cab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I think I'm not qualified to make the decision here, as I don't fully understand the use case.
It looks to me that one use case would be to run schema_of_json on a column and manually figure out what's the final schema, and then use this schema in from_json. If schema_of_string only accepts literal, I'm not how users would use it.

Actually, that usecase can more easily accomplished by simply inferring schema by JSON datasource. Yea, I indeed suggested that as workaround for this issue before. Let's say, spark.read.json(df.select("json").as[String]).schema.
I know it's not super clear about the usecase of schema_of_json and actually that's also partly why I want to allow what we need for this expression now.
@rxin, WDYT? This PR tries to allow what we only need for now. Let's say disallow:
schema_of_json(column)

and only allow
schema_of_json(literal)

because the main usecase is:
from_json(schema_of_json(literal))

and
from_json(schema_of_json(column))

is already not being supported. My judgement was schema_of_json(column) doesn't have to be exposed for now and actually want to have a talk with @MaxGekk about this when he comes back from his vacation.

Maybe I am too much careful about it but I am kind of nervous about this column case. I don't intend to disallow it entirely but only for Spark 2.4. We might have to find a way to use column column with from_json but I want to defer to 3.0.

I agree it should be a literal value.

Test build #98066 has started for PR 22775 at commit e2ca651.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4520/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4522/
Test PASSed.

Merged build finished. Test PASSed.

Test build #98067 has started for PR 22775 at commit 03f34d9.

Test build #98066 has finished for PR 22775 at commit e2ca651.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98066/
Test FAILed.

Yup, yup .. I should sync the tests

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4527/
Test PASSed.

Test build #98078 has started for PR 22775 at commit 8e6b97a.

thanks, merging to master! can you send a new PR for 2.4? it conflicts

Sure!

Actually this is not that hard. The conflict comes from the fact that in 2.4 schema_of_json doesn't take option parameter.
I've fixed the conflict and pushed to 2.4. You can take a look at the commit and see if there is something wrong. I ran the touched tests locally to verify it.

Yea, but I meant a bit complicated but I'm okay in that way @cloud-fan. Thanks for doing that. I planed to do it today (now) :).

Oh you mean the conflict fixing is not that hard. Thanks for doing this @cloud-fan. I planned to do this today .. :-).

This change seems like a step back from the original version introduced in #21686.
I have a DataFrame with a JSON column. I suspect the JSON values have an inconsistent schema, so I want to first check whether a single schema can apply before trying to parse the column.
With the original version of schema_of_json(), I could do something like this to check whether or not I have a consistent schema:
df.select(schema_of_json(...)).distinct().count()

But now I can't do that. I can't even wrap schema_of_json() in a UDF to get something like that, because it returns a Column. It seems surprising from an API design point of view for a function to only accept literals but return Columns. And it seems inconsistent with the general tenor of Spark SQL functions for a function not to accept Columns as input.
Can we revisit the design of this function (as well as that of its cousin, schema_of_csv())?
Alternately, would it make sense to deprecate these functions and instead recommend the approach that @HyukjinKwon suggested?

Actually, that usecase can more easily accomplished by simply inferring schema by JSON datasource. Yea, I indeed suggested that as workaround for this issue before. Let's say, spark.read.json(df.select("json").as[String]).schema.

This demonstrates good Spark style (at least to me), and perhaps we can just promote this as a solution and do away with these functions.
For the passing reader, the Python equivalent of Hyukjin's suggestion is:
spark.read.json(df.rdd.map(lambda x: x[0])).schema

@nchammas, thanks for some input here.

I could do something like this to check whether or not I have a consistent schema:
df.select(schema_of_json(...)).distinct().count()

I wanted to make the expression only for the specific usecase and avoid to have multiple ways for the same thing. Other cases can be easily worked around. For the case you mentioned, it can be worked around as below:
spark.read.json(df.select("json").as[String]).schema == StructType.fromDDL(...)

I think it is fine to have an expression that takes literals to return a column to support a missing usecase requested multiple times.


[filter_box] Fix show time column in filter_box

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[x] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
This bug was introduced from #8636. the params name for time grain and time column is so hard to tell which is which :(
TEST PLAN
CI and manual test.
REVIEWERS
@etr2460 @kristw

Codecov Report

Merging #8740 into master will increase coverage by 6.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8740      +/-   ##
==========================================
+ Coverage   65.67%   72.04%   +6.36%
==========================================
  Files         482      122     -360
  Lines       24102    12815   -11287
  Branches     2767        0    -2767
==========================================
- Hits        15828     9232    -6596
+ Misses       8094     3583    -4511
+ Partials      180        0     -180

Impacted Files
Coverage Δ

superset/assets/src/components/Checkbox.jsx

.../assets/src/dashboard/reducers/dashboardFilters.js

...ets/src/dashboard/components/dnd/DragDroppable.jsx

superset/assets/src/components/EditableTitle.jsx

...src/explore/components/controls/VizTypeControl.jsx

...t/assets/src/components/InfoTooltipWithTrigger.jsx

.../src/dashboard/components/UndoRedoKeylisteners.jsx

...ts/src/explore/components/ExploreActionButtons.jsx

.../src/dashboard/components/FilterTooltipWrapper.jsx

...sets/src/dashboard/components/DashboardBuilder.jsx

... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f637e...852bbed. Read the comment docs.