Fix usage example in README

There is no bk pipelines, it should be bk pipeline.

(ping @pda)

Thanks for the fix, and the reminder ping! I totally missed it the first time. 🙏🏼


feat(pipelines/pingcap/tidb/latest): add plugin test step for build job

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

tested in https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/ghpr_build/17939/


What files are given to Syncplay for TLS when acme.sh is used instead of certbot?

With certbot I just copied all files and pointed Syncplay to the directory, but acme.sh gives me a separate set of files.

certbot gave me: README  cert.pem  chain.pem  fullchain.pem  privkey.pem
acme.sh gives me: ca.cer         relpda.mikaela.info.cer   relpda.mikaela.info.csr       relpda.mikaela.info.key fullchain.cer  relpda.mikaela.info.conf  relpda.mikaela.info.csr.conf

Which of them do I give to Syncplay and will it understand them directly or do I have to rename them?

Does https://github.com/Syncplay/syncplay/wiki/TLS-support answer your question?

The furtherst I got was:
cp $CERTDIR/fullchain.cer /opt/syncplay/ssl/chain.pem
cp $CERTDIR/relpda.mikaela.info.key /opt/syncplay/ssl/privkey.pem
cp $CERTDIR/relpda.mikaela.info.cer /opt/syncplay/ssl/cert.pem

Which results to:
ERROR:  Secure connection failed. The server uses an invalid security certificate. This communication could be intercepted by a third party. For f
urther details and troubleshooting see here.
ERROR:  Disconnected from server

If I replace $CERTDIR/relpda.mikaela.info.cer with $CERTDIR/relpda.mikaela.info.csr I get ERROR:  This server does not support TLS

Did you check if the .cer files are actually in the PEM format? Maybe they need to be converted instead of just renamed...

Looking through readme at https://github.com/Neilpang/acme.sh/blob/master/README.md#3-install-the-cert-to-apachenginx-etc there is explanation how to install certificates with formats and paths similar to what Syncplay expects. At very least this should be a serviceable workaround.
Personally I'm thinking that some way of specifying arbitrary names for PEM files in Syncplay might be worth exploring after all.

I should read documentations better. However even with those instructions, Syncplay stays unhappy.
 The server uses an invalid security certificate. This communication could be intercepted by a third party. For f
urther details and troubleshooting see here.

I have git pulled both client and server to 0f284e7329eed6a86ecbfd9a2d3a3c392bfbedc3.

Running the following command should give detailed info about what exactly is going on:
openssl s_client -connect relpda.mikaela.info:8999 <<< "Q"

I changed the command to openssl s_client -connect y.relpda.mikaela.info:14404 and it only says CONNECTED(00000003) and hangs.
The certificate is valid for relpda.mikaela.info, ds.relpda.mikaela.info, nat.relpda.mikaela.info, y.relpda.mikaela.info.
relpda.mikaela.info is the main domain, but it's IPv6-only, so I also have ds. and nat., y. is for Yggdrasil and requires special software for accessing, and I don't have this issue with Mumble or ZNC connected to the same domain.
I also have another Mumble user whom I think to connect to ds.relpda.mikaela.info.

I tried connecting directly to relpda.mikaela.info:14404. Are you on freenode or something else where I could give you the password in case you can see something more useful?

On IRC @daniel-123 figured that I was passing the wrong arguments to acme.sh.
My script now says:
 $ACMESH --cert-file $SYNCPLAYDIR/cert.pem --key-file $SYNCPLAYDIR/privkey.pem --ca-file $SYNCPLAYDIR/chain.pem
expanded:
/root/.acme.sh/acme.sh --install-cert -d relpda.mikaela.info --cert-file /opt/syncplay/ssl/cert.pem --key-file /opt/syncplay/ssl/privkey.pem --ca-file/opt/syncplay/ssl/chain.pem
The issue was that Syncplay expected acme.sh's --ca-file instead of --fullchain-file.

@daniel-123

Personally I'm thinking that some way of specifying arbitrary names for PEM files in Syncplay might be worth exploring after all.

I tend to agree with you, but I believe this is just not feasible in our CLI-based current configuration system. I am in favor of @alxpettit idea to use a config file (perhaps an INI file) for our server in the future.

Some other application use --key --cert --ca arguments to pass the path directly ?
Will that not be a good way to do it ?

Thanks for your work in helping us understand these issues. We are trying to avoid further complicating the Syncplay codebase, especially when it comes to TLS-related features. As such, while we will link to this issue from https://syncplay.pl/guide/server/ so that those with similar issues can understand what is happening, no changes to the Syncplay code are currently anticipated. In the future more information on this topic might be integrated into the guide at: https://github.com/Syncplay/syncplay/wiki/TLS-support at which point the reference to this issue could become redundant.

Hello,
I am using Lego for requesting certificates from Let's Encrypt.
Could you clarify what PEM data the three files needed by Syncplay should contain?
From my personal understanding:

chain.pem -> CA intermediate + root certificate
cert.pem -> single level server certificate
privkey.pem -> private key

I tried:

server certificate in cert.pem and intermediate+root certificate in chain.pem
server certificate in cert.pem server+intermediate+root certificate in chain.pem
server+intermediate+root certificate in cert.pem and root certificate in chain.pem
server+intermediate+root certificate in cert.pem and server+intermediate+root certificate in chain.pem

All combinations result in the server printing "TLS support is enabled." and in the client printing "Secure connection failed. The server uses an invalid security certificate. This communication could be intercepted by a third party. For further details and troubleshooting see here." - unfortunately neither of these messages indicate what the issue is. Of course, my certificate is valid (not expired, matching SAN and trusted by the client system's root CA store).
Would appreciate any input.

Hopefully you will find https://github.com/Syncplay/syncplay/wiki/TLS-support of assistance.

Also be aware that if you are connecting to yourself as localhost then that might cause the TLS to fail. Test with a remote connection.

Thanks for your reply! I checked the article you linked, and attempted one more combination:

server certificate in cert.pem and only intermediate certificate in chain.pem

Unfortunately it did not change the behavior of the program either.
Of course, I am connecting using the external domain name which is included in the SAN's of the certificate.

Even if connecting to the external domain, if you are connecting to yourself then there can be problems because your router might end up just making it a loopback, but this isn't my specialty so I could be wrong. If you are connecting via a loopback then you shouldn't need TLS. You ideally want someone who is on a completely different network to the server to connect to your server for testing purpose.

This is over the internet, so TLS is necessary.
As said, if I proxy it through a separate application like stunnel the TLS handshake is established.

@tacerus Exact files and their contents that Syncplay expects are the same as old certbot produces by default:

privkey.pem containing the private key
cert.pem containing the signed leaf certificate (the one with CN/SAN equal to domain name you use)
chain.pem containing the intermediate certificate and after it, the root certificate.

In case of current Let's Encrypt certificates, the intermediate certificate will be the R3 and the root is ISRG Root X1. This is how current public servers are set up, so this should also work for you.

Thank you very much for the insight, @daniel-123!
This is very useful if using different ACME clients.


Java based fact gathering

WIP
I'm still working on resolving a few differences between facter and oshi (e.g. "EDT" vs "America/New_York" and the like) but wanted to put up the current code.

[x] resolve differences between facter and oshi
[x] test oshi 3.4.4 on all of the build nodes (windows, centos, fedora, etc etc) Facter 3.4.3 had an issue on centos 6 that was resolved by dropping down to 3.4.0, but I see resolved bug reports that 3.4.4 might have fixed it a different way.
[ ] run the diff code from system-test/basic on various nodes to make sure there aren't any further differences to work on

This is a fascinating issue where I'm discovering that there (apparently) aren't tried and true approaches to discovering things like the primary network address (what does it mean to be "primary"?) and number of physical CPUs (in one case oshi says 2 while facter says 1, and in another oshi says 1 while facter says 16).  Never mind more minor issues like "linux" vs "gnu/linux" or "utc" vs "etc/utc".
I'm trying to come up with sane (and cross platform) ways to resolve some of these.  Others we may just need to decide if we're willing to live with the differences.

👏


Deobfuscation

hello i want deobfuscate a plugin but i have this error

My config:

that is no error

Don't check "verify", and use stringer.StringEncryptionTransformer. Also please use the issue tracker in deobfuscator: https://github.com/java-deobfuscator/deobfuscator

And remove detect check


Fix unicode conversion error

Fixes https://github.com/msaraiva/surface/issues/77
From the documentation:

Notice that this function (iodata_to_binary/1) treats integers in the given IO data as raw bytes and does not perform any kind of encoding conversion. If you want to convert from a charlist to a UTF-8-encoded string, use chardata_to_string/1 instead. For more information about IO data and chardata, see the "IO data" section in the module documentation.

@MrYawe thanks! ❤


zk-dump: add --unpaired options

By default, zk-dump will wait for a reply from the server
to be seen and then it'll pair that with the request that
it saw before.
This new option, --unpaired, prints reqs, reps & evts as soon
as they are seen. This loses the order, but can be helpful
to debug certain timeouts & other scenarios.
Note, note, note: we are still subject to the whatever ordering
pcap sees from the Kernel. So absolute ordering, as what's seen
through the wire, isn't assured (but it probably gets close enough).
Signed-off-by: Raul Gutierrez S<EMAIL_ADDRESS>

Coverage decreased (-1.18%) to 62.16% when pulling 2e900640b5eb78b58214f3747e77870cb6e59b1c on rgs1:add-unpaired-opt-to-zkdump into 89f724929514ee33830748e0842bdf532cd53a92 on twitter:master.


why P(y=1|c=i, x)=v_i?

Hi, author:
I found it's confused to understand why P(y=1|c=i, x) can be defined as v_i. In my opinion, the memory related variable (K, v, a, h) is global and have no direct relation with x. So i cant understand why.

Actually, P(y=1|c=i, x) is value v_i multiplied by posterior  P(c=i|x)
P(y=1|c=i, x) = P(y=1|c=i) P(c=i|x) = v_i P(c=i|x)
Once you have vMF component (or memory index) c,
P(y=1|c=i) is automatically determined as the value v of c-th memory slot.
This relation makes P(y=1|c=i) = v_i hold.
One possible cause of the confusion is notation x.
You might want to consider P(c=i|x) as an arbitrary function that estimates posterior.
In our case, we define the estimator with a inference network mu(x) and some exponential computation exp(kappa K_imu(x)) / sum_j exp(kappa K_jmu(x))


Aggregate PR

Aggregate of the following PRs:
https://github.com/wildfly/wildfly/pull/15051
https://github.com/wildfly/wildfly/pull/15042
https://github.com/wildfly/wildfly/pull/15041
https://github.com/wildfly/wildfly/pull/15037
https://github.com/wildfly/wildfly/pull/15000
https://github.com/wildfly/wildfly/pull/14928
https://github.com/wildfly/wildfly/pull/14412
https://github.com/wildfly/wildfly/pull/14243

All PRs merged


Wireguard through Phantun,peers see each orther,but no internet sharing.

Hello ,Dear all experts. I try to use Phantun in my case, I read the instructions carefully. yep,I can create two-way peer-to-peer links. But the client cannot share the server's internet service. I tried for days, but still couldn't find the root of the problem.I am so stupid.I would like to get some guidance from everyone.
The circumstances are as follows:
Step 1.
Server (@ubuntu 22.04.1 LTS )& Client(@ubuntu 18.04.6 LTS) : net.ipv4.ip_forward=1 ---check
Step 2. firewall rules ---check
Server:
server@instance:~# iptables -L -t nat -v
Chain PREROUTING (policy ACCEPT 20187 packets, 806K bytes)
pkts bytes target     prot opt in     out     source               destination
102  5624 DNAT       tcp  --  ens3   any     anywhere             anywhere                                                                                tcp dpt:https to:<IP_ADDRESS>
Chain INPUT (policy ACCEPT 20187 packets, 806K bytes)
pkts bytes target     prot opt in     out     source               destination
Chain OUTPUT (policy ACCEPT 24011 packets, 2051K bytes)
pkts bytes target     prot opt in     out     source               destination
Chain POSTROUTING (policy ACCEPT 24574 packets, 2090K bytes)
pkts bytes target     prot opt in     out     source               destination

Client:
client@instance:~# iptables -L -t nat -v
Chain PREROUTING (policy ACCEPT 362 packets, 61371 bytes)
pkts bytes target     prot opt in     out     source               destination
Chain INPUT (policy ACCEPT 20187 packets, 806K bytes)
pkts bytes target     prot opt in     out     source               destination
Chain OUTPUT (policy ACCEPT 24011 packets, 2051K bytes)
pkts bytes target     prot opt in     out     source               destination
Chain POSTROUTING (policy ACCEPT 24574 packets, 2090K bytes)
pkts bytes target                prot opt in     out     source               destination
34   1496  MASQUERADE  all    --    any   eth0  <IP_ADDRESS>     anywhere
Step 3. Wireguard Configuration
Server:
[Interface]
PrivateKey =
Address = <IP_ADDRESS>/32
ListenPort = 51822
MTU = 1300
PreUp = RUST_LOG=info phantun_server --local 443 --remote <IP_ADDRESS>:51822 &> /var/log/phantun_server.log &
PostDown = killall phantun_server || true
[Peer]
PublicKey =
AllowedIPs = <IP_ADDRESS>/32

Client:
[Interface]
PrivateKey =
Address = <IP_ADDRESS>/32
MTU = 1300
PreUp = RUST_LOG=info phantun_client --local <IP_ADDRESS>:4567 --remote :443 &> /var/log/phantun_client.log &
PostDown = killall phantun_client || true
[Peer]
PublicKey =
Endpoint = <IP_ADDRESS>:4567
AllowedIPs = <IP_ADDRESS>/32
PersistentKeepalive = 25

Connections:
peers can see each orther, ping both way is fine. But only for <IP_ADDRESS> or <IP_ADDRESS>，Neither side can access the other's intranet.
Server at 10.0.0.x intranet ; client at 192.168.1.x intranet.They can't get to each other's LANs. Including Internet.
Am I missing the most basic things? Please Help me.

googe "wireguard how to share networking".U can ping earch other,so not phantun's issue.

You should try to get your tunnel working without Phantun first, as long as sudo wg shows successful handshake, Phantun is functioning correctly.


Automatic Scroll to the Top

Issue Type: Feature Request
Please, folks, add the automatic scroll to the top feature that opera browser has for its tabs. It´s simple, but would be very useful.
VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:46:01.075Z)
OS version: Windows_NT x64 6.2.9200
Restricted Mode: No

How does it work?

Clicking into the tab of one page when you have already scrolled down body content automatically makes the browser return to the top of that page. Honestly, I haven't found out if there is an extension that already does that, but it would be great to have it in Code natively.

For the community. This could be an option activated from the settings for those who feel more comfortable to reviewing code only with the mouse.

For the community. This could be an option activated from the settings for those who feel more comfortable to reviewing code only with the mouse.

can be done by keyboard shortcut or double click on tab too.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Adding the issue type to the output.

Signed-off-by: Jason Joyce<EMAIL_ADDRESS>

The type is in verbose output - can you delete it there?


requiresMainQueueSetup Warning

Hi,
Thanks for this module. Great work!
I'm getting the following debugger error:

RCTLog.js:48 Module RCTPagedContactsModule requires main queue setup since it overrides constantsToExport but doesn't implement requiresMainQueueSetup. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

I looks like a fix similar to https://github.com/wix/react-native-navigation/pull/1983/files#diff-b8c48202d12fa78c4c377e5a3225c298 would do the trick, but my Obj C isn't the best to handle the update on my own.
Let me know if this is easily fixed for a future release.
Thanks again!

@auval Please add the following code to the module.m file:
+ (BOOL)requiresMainQueueSetup
{
	return YES;
}

Just so we don't get crashes.

@LeoNatan added
On Mon, Feb 12, 2018 at 6:09 PM, Leo Natan<EMAIL_ADDRESS>wrote:

@auval https://github.com/auval Please add the following code to the
module.m file:

(BOOL)requiresMainQueueSetup
{
return YES;
}

Just so we don't get crashes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/wix/react-native-paged-contacts/issues/16#issuecomment-364971365,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKJsJqNwcxKTmhOqXbJavm-zB6h4M41_ks5tUGJXgaJpZM4Rv1LZ
.

Great!

Awesome. Thank you both!


go.mod: Do not remove other dependencies

If Dependabot updates ie. github.com/golang/protobuf from 1.4.3 to 1.5.1  and the repo contains some auto-generated code or unused ones then Dependabot will remove all dependencies.

Package manager/ecosystem
go:modules

Manifest contents prior to update
module github.com/my-org/my-repo

go 1.15

require (
	github.com/golang/protobuf v1.4.3
	github.com/grpc-ecosystem/grpc-gateway/v2 v2.2.0
	google.golang.org/genproto v0.0.0-20210207032614-bba0dbe2a9ea
	google.golang.org/grpc v1.36.0
	google.golang.org/protobuf v1.25.0
)

Updated dependency
-module github.com/my-org/my-repo
-
-go 1.15
-
-require (
-	github.com/golang/protobuf v1.4.3
-	github.com/grpc-ecosystem/grpc-gateway/v2 v2.2.0
-	google.golang.org/genproto v0.0.0-20210207032614-bba0dbe2a9ea
-	google.golang.org/grpc v1.36.0
-	google.golang.org/protobuf v1.25.0
-)

What you expected to see, versus what you actually saw
It would be nice if Dependabot updates only actual dependency and do not remove other ones.
It is easy to fix by telling Dependabot to create a temporary file ie. dependabot.go and copy all deps from original go.mod to dependabot.go:
// +build dependabot

package tools

import (
	_ "github.com/golang/protobuf"
	_ "github.com/grpc-ecosystem/grpc-gateway/v2"
	_ "google.golang.org/genproto"
	_ "google.golang.org/grpc"
	_ "google.golang.org/protobuf"
)

and after that run update and create a new diffs for go.mod and go.sum.

Images of the diff or a link to the PR, issue or logs

Thanks @mdreizin, I guess this happens because we run go mod tidy after the update.
We actually already create such a file if no .go file is present in the root. We could always do that, but the downside is that if you do normally run go mod tidy, we no longer clean up dependencies that are unused after the update.
I think if you commit the file you mention to the repo, that would also work. Another option would be to make go mod tidy optional, but it seems like a good default. wdyt?

@jurre Thank you for the instant reply. I am going to use that temporary workaround, but it would be nice to have that approach out of the box.

Please keep the current default of running go mod tidy... it keeps my life sane. I can't really envision a scenario where it wouldn't make sense to do that. Probably if someone is having an issue with the output, they should really be filing an issue against go mod tidy behavior and not against dependabot.

Closing, as I don't see us moving away from executing go mod tidy, . Beyond providing sane defaults, it also does some error checking that lets us know if things might be in a broken state as we prepare the upgrade.


Django 1.10 compatibility

Heya!
I made the SilkyMiddleware compatible with the new Django 1.10 middleware and also fixed the broken tests (typo with content_type not being a field on Response).
Thanks!
Remco

Don't know why that specific test is failing in that specific deploy :( any ideas?

@shanx That unit test might be inconsistent with when it breaks. It is something I had on the back of my mind to address. Either way I have merged your pull request.
Thanks again for the contribution!


[In progress] Beacons and Users modules

What
This is the initial creation of a beacons module. The only action currently is to create a beacon. Other operations such as updating and deleting will come later. An additional module called 'users' is included because the beacons module will depend on it in order to select users.
@ngmiller this is currently untested and still in progress. I wanted to open this to get some feedback and input about how POST/PUT type requests flow through the flux architecture.

+1


Push PopupMenu's animation code into its build function and use trans…

…itions.
Also add intervals and curves to AnimationPerformance, which affect all
variables used by the performance.
I'm curious what you think about this approach. My goal is to (1) eliminate as much bookkeeping as possible in maintaining animation variables in client code (PopupMenu here), and (2) move all the logic associated with widget layout into the build() function.

OK, ready for another look.

LGTM


History is been deleted in the sidebar after opening session in editor

VS Code Version: 1.79.2
OS Version: macOS 13.1
Logs: -

Steps to Reproduce:

Open Session in Editor
Close View in Editor

Now the session/history is been deleted in the sidebar.

I don't follow, can you give some more detail about what exactly you see here

Now the session/history is been deleted in the sidebar.

I would expect that after opening the session in the editor, the history wouldn't be deleted:
https://github.com/microsoft/vscode-copilot-release/assets/39196535/287d30a6-45a1-495a-9802-f6f8d7269328

You opened it in the editor, then closed the editor. You can get it back from the history list by clicking the "show history" button in the view title toolbar


As a volunteer coordinator, I want to change the name of the event

so that I can update an event with the correct name

eedit


Can install with buildout

When buildout downloads the package from pypi it can not be installed cause setup.py references README.rst which is not include in the .tar.gz

Should be fixed.


Consider adding a button to launch Rails server in a terminal

Currently, we just display a warning mentioning that the Rails server is not running to users. But it would be very nice if we could associate commands in the extension activation event.
For example, if the server is not running, we display a start server button. If the app_uri.txt file doesn't exist yet, we display a restart server button and perform the actions for the user.
This does have downsides though. Letting extensions return commands from activation events means these commands must exist in vscode-ruby-lsp, but we certainly don't want to implement commands for every extension that might be created.
Maybe we can treat ruby-lsp-rails as a special case and allow only it to register buttons?

Now that we launch Rails automatically via rails runner, this is no longer relevant.


Update auto-configuration to use @Configuration(proxyBeanMethods=false)

This is a performance enhancement.
See https://github.com/spring-projects/spring-boot/issues/9068

I would like to take this one if it's still available


Missing Images in InLoc Dataset

Within the pairs-query-netvlad40.txt, the file DUC_cutout_113_240_0.jpg is mentioned as being part of a pair. However, I downloaded the InLoc dataset with the following commands:
git clone https://github.com/HajimeTaira/InLoc_dataset
cd InLoc_dataset
./extract_db_all_mirror.sh
./extract_query_mirror.sh

And it does not contain this file.
I have attached a comprehensive list of the files downloaded.
downloaded_files.txt

After some investigation is seems that the mirror file for DUC2 https://www.dropbox.com/s/t2izj3dkzk81jg4/DUC2.tar.bz2?dl=1 has an issue. Uncompressing it with tar -jtvf DUC2.tar.bz2 gives:
bzip2: Data integrity error when decompressing.
        Input file = (stdin), output file = (stdout)

It is possible that the compressed file(s) have become corrupted.
You can use the -tvv option to test integrity of such files.

You can use the `bzip2recover' program to attempt to recover
data from undamaged sections of corrupted files.

tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

This results in 711 cutout images missing compared to the original dataset, including DUC_cutout_113_240_0.jpg. Tagging @HajimeTaira who may be able to help here.
@half-potato in the meantime could you try downloading with extract_db_all.sh ?

Thank you for sharing the issue. I reproduced the problem and found something happens when downloading from Dropbox. The original bzip2 file uploaded to the server (and still being synced) actually includes DUC_cutout_113_240_0.jpg but downloaded file somehow loses the image. One potential reason would be that wget seems once to be terminated by the server, after one hour has passed. I'm now uploading the original file to Dropbox server again. If it won't solve the problem, I'll try to divide the file into two or more separated file so one can download the whole file without termination.

Awesome, thanks for the timely reply!

I've succeeded to construct full DUC2 image set from two separated tar.gz files. These files cause no problem while downloading, whereas re-uploaded original file still corrupts. So could you try to download the database images again, using the lines above?
I'll merge these changes to master soon, after dividing other large floors into separated files.

This download link works: http://www.ok.sc.e.titech.ac.jp/INLOC/materials/cutouts/DUC2.tar.bz2

@half-potato Good to hear that the original link works for you. For more speedy and stable downloading from dropbox, I also prepared several sub-files for large floors. https://github.com/HajimeTaira/InLoc_dataset/pull/6
Thank you again for sharing the issue and sorry for the inconvenience.

Thanks @HajimeTaira for fixing this. Closing this issue then.


Generating an empty changelog

I'm running releasetool start against master in nodejs-common:
https://github.com/googleapis/nodejs-common/
It's popping up an empty change log, even though there are many changes.
nodejs-common (master) $ releasetool start
Which language (python, python-tool, nodejs)?: nodejs
o/ Hey, beckwith, let's release some stuff!
> Determining basic context.
GitHub Repo: JustinBeckwith/nodejs-common
> Figuring out the package name.
Looks like we're releasing nodejs-common.
> Figuring out what the last release was.
The last release was 0.20.3.
> Gathering changes since 0.20.3
Cool, 1 changes found.
> Opening your editor to finalize release notes.

And the changelog it generates:
-

### Implementation Changes

### New Features

### Dependencies

### Documentation

### Internal / Testing Changes

The actual changes:
3894cf4 chore: update renovate config (#202)
beda6c2 fix: make ServiceObject#id protected to allow subclass access (#200)
3004afa refactor: remove circular imports (#201)
3f764bf fix: special JSON.stringify for for strictEqual test (#199)
dbddd19 chore: assert.deelEqual => assert.deepStrictEqual (#196)
ba0f858 chore: move mocha options to mocha.opts (#195)
be06c73 chore(deps): update dependency gts to ^0.8.0 (#192)
94afcdf chore: cut out code split into other modules (#194)
46c910a Update config.yml (#191)
3d74038 fix: drop support for node.js 4.x and 9.x (#190)

Duplicate of #8.

Err, #9, but related to #8.


can't run lwaftr without reassembly yang config container

Removing reassembly {} from icmp_on_fail.conf produces error:
diff --git a/src/program/lwaftr/tests/data/icmp_on_fail.conf b/src/program/lwaftr/tests/data/icmp_on_fail.conf
index 6ad1b5f5..69e7f9e6 100644
--- a/src/program/lwaftr/tests/data/icmp_on_fail.conf
+++ b/src/program/lwaftr/tests/data/icmp_on_fail.conf
@@ -143,8 +143,5 @@ softwire-config {
     error-rate-limiting {
       packets 600000;
     }
-    reassembly {
-      max-fragments-per-packet 40;
-    }
   }
 }

It isn't related to having max-fragments-per-packet set or not in that stanza, because it still runs fine with just 'reassembly {}' in the internal-interface and external-interface group. But if you remove reassembly, it breaks.
Another note: it is ok to remove the rror-rate-limiting container from the config. That still works. So there seems to be some dependency on the presence of reassembly{}, which IMHO shouldn't be.
sudo ./src/snabb lwaftr run --reconfigurable --conf src/program/lwaftr/tests/data/icmp_on_fail.conf --on-a-stick 04:00.0
Warning: the --reconfigurable flag has been deprecated as the lwaftr is now always reconfigurable.
src/program/lwaftr/tests/data/icmp_on_fail.conf: loading source configuration
src/program/lwaftr/tests/data/icmp_on_fail.conf: wrote compiled configuration src/program/lwaftr/tests/data/icmp_on_fail.o
Migrating instance 'test' to '04:00.0'
lib/ctable.lua:177: mmap failed: Invalid argument
file not found: core/main.lua: No such file or directory
file not found: core/app.lua: No such file or directory
file not found: core/app.lua: No such file or directory
file not found: apps/config/follower.lua: No such file or directory
file not found: core/histogram.lua: No such file or directory
file not found: core/main.lua: No such file or directory
line not found

Stack Traceback
===============
(1) Lua function '?' at file 'core/main.lua:168' (best guess)
	Local variables:
	 reason = string: "lib/ctable.lua:177: mmap failed: Invalid argument"
	 (*temporary) = C function: print
(2) global C function 'error'
(3) Lua upvalue 'calloc' at file 'lib/ctable.lua:177'
	Local variables:
	 count = number: 0
	 byte_size = number: 0
	 mem = nil
(4) Lua method 'resize' at file 'lib/ctable.lua:219'
	Local variables:
	 self = table: 0x421f4a28  {size:0, max_displacement:0, type:ctype<struct 1980 [?]>, hash_seed:cdata<unsigned char [16]>: 0x421f8798 (more...)}
	 size = number: 0
	 old_entries = nil
	 old_size = number: 0
	 old_max_displacement = number: 0
(5) Lua field 'new' at file 'lib/ctable.lua:154'
	Local variables:
	 params = table: 0x421f4920  {max_occupancy_rate:0.9, key_type:ctype<struct 1834>, value_type:ctype<struct 1969> (more...)}
	 ctab = table: 0x421f4a28  {size:0, max_displacement:0, type:ctype<struct 1980 [?]>, hash_seed:cdata<unsigned char [16]>: 0x421f8798 (more...)}
	 params = table: 0x421f4a50  {initial_size:0, value_type:ctype<struct 1969>, min_occupancy_rate:0, key_type:ctype<struct 1834> (more...)}
(6) Lua field 'initialize_frag_table' at file 'apps/lwaftr/ctable_wrapper.lua:41'
	Local variables:
	 params = table: 0x421f4920  {max_occupancy_rate:0.9, key_type:ctype<struct 1834>, value_type:ctype<struct 1969> (more...)}
(7) Lua method 'new' at file 'apps/lwaftr/ipv6_apps.lua:47'
	Local variables:
	 self = table: 0x4191ab10  {cache_fragment:function: 0x41917ab8, push:function: 0x4191b5c0, new:function: 0x4191ab88 (more...)}
	 conf = table: 0x403f5698  {max_ipv6_reassembly_packets:0, max_fragments_per_reassembly_packet:0}
	 max_ipv6_reassembly_packets = number: 0
	 max_fragments_per_reassembly_packet = number: 0
	 (*temporary) = table: 0x421f0000  {counters:table: 0x421efd08}
(8) Lua function '?' at file 'core/app.lua:342' (best guess)
	Local variables:
	 name = string: "reassemblerv6"
	 class = table: 0x4191ab10  {cache_fragment:function: 0x41917ab8, push:function: 0x4191b5c0, new:function: 0x4191ab88 (more...)}
	 arg = table: 0x403f5698  {max_ipv6_reassembly_packets:0, max_fragments_per_reassembly_packet:0}
(9) Lua field 'apply_config_actions' at file 'core/app.lua:369'
	Local variables:
	 actions = table: 0x40cb2e78  {1:table: 0x4192ad10, 2:table: 0x4192c460, 3:table: 0x4192dcc0, 4:table: 0x4192fbb8 (more...)}
	 ops = table: 0x40cb2ec0  {unlink_output:function: 0x40cb2f08, stop_app:function: 0x411b0260, free_link:function: 0x40cb2fa0 (more...)}
	 remove_link_from_array = Lua function '?' (defined at line 289 of chunk core/app.lua)
	 (for generator) = C function: builtin#6
	 (for state) = table: 0x40cb2e78  {1:table: 0x4192ad10, 2:table: 0x4192c460, 3:table: 0x4192dcc0, 4:table: 0x4192fbb8 (more...)}
	 (for control) = number: 5
	 _ = number: 5
	 action = table: 0x403f4280  {1:start_app, 2:table: 0x403f5bb0}
	 name = string: "start_app"
	 args = table: 0x403f5bb0  {1:reassemblerv6, 2:table: 0x4191ab10, 3:table: 0x403f5698}
(10) Lua method 'commit_pending_actions' at file 'apps/config/follower.lua:50'
	Local variables:
	 self = table: 0x41927048  {pending_actions:table: 0x419270d0, channel:table: 0x419272d8, output:table: 0x41927a08 (more...)}
	 to_apply = table: 0x40cb2e78  {1:table: 0x4192ad10, 2:table: 0x4192c460, 3:table: 0x4192dcc0, 4:table: 0x4192fbb8 (more...)}
	 should_flush = boolean: true
(11) Lua method 'handle_actions_from_leader' at file 'apps/config/follower.lua:62'
	Local variables:
	 self = table: 0x41927048  {pending_actions:table: 0x419270d0, channel:table: 0x419272d8, output:table: 0x41927a08 (more...)}
	 channel = table: 0x419272d8  {ring_buffer:cdata<struct 1477 *>: 0x7f106a7b3000}
	 (for index) = number: 1
	 (for limit) = number: 4
	 (for step) = number: 1
	 i = number: 1
	 len = number: 4
	 action = table: 0x40cb2df8  {1:commit, 2:table: 0x40cb2e38}
(12) Lua local 'method' at file 'apps/config/follower.lua:73'
	Local variables:
	 self = table: 0x41927048  {pending_actions:table: 0x419270d0, channel:table: 0x419272d8, output:table: 0x41927a08 (more...)}
(13) Lua global 'with_restart' at file 'core/app.lua:96'
	Local variables:
	 app = table: 0x41927048  {pending_actions:table: 0x419270d0, channel:table: 0x419272d8, output:table: 0x41927a08 (more...)}
	 method = Lua function '?' (defined at line 70 of chunk apps/config/follower.lua)
	 status = nil
	 result = nil
	 (*temporary) = boolean: true
(14) Lua upvalue 'thunk' at file 'core/app.lua:506'
	Local variables:
	 (for index) = number: 1
	 (for limit) = number: 1
	 (for step) = number: 1
	 i = number: 1
	 app = table: 0x41927048  {pending_actions:table: 0x419270d0, channel:table: 0x419272d8, output:table: 0x41927a08 (more...)}
(15) Lua local 'breathe' at file 'core/histogram.lua:98'
	Local variables:
	 start = number: 448530
(16) Lua field 'main' at file 'core/app.lua:461'
	Local variables:
	 options = table: 0x41927ea0  {}
	 done = nil
	 no_timers = nil
	 breathe = Lua function '?' (defined at line 96 of chunk core/histogram.lua)
(17) Lua field 'run_worker' at file 'program/lwaftr/setup.lua:583'
	Local variables:
	 scheduling = table: 0x41924d70  {pci_addrs:table: 0x41924dd0, ingress_drop_monitor:flush}
	 app = table: 0x419a3ec8  {test_skipped_code:43, app_table:table: 0x419a3f58, link_table:table: 0x400a8120 (more...)}
	 myconf = table: 0x41926b70  {links:table: 0x41926bf8, apps:table: 0x41926b98}
(18) main chunk of [string "require('program.lwaftr.setup').run_worker({[..."] at line 1
(19) Lua function '?' at file 'core/main.lua:58' (best guess)
	Local variables:
	 expr = string: "require('program.lwaftr.setup').run_worker({[\"pci_addrs\"]={[1]=\"04:00.0\"},[\"ingress_drop_monitor\"]=\"flush\"})"
	 f = Lua function '?' (defined at line 0 of chunk "require('program.lwaftr.setup').run_worker({[..."])
(20) global C function 'xpcall'
(21) main chunk of file 'core/main.lua' at line 230
(22)  C function 'require'
(23) global C function 'pcall'
(24) main chunk of file 'core/startup.lua' at line 3
(25) global C function 'require'
(26) main chunk of [string "require "core.startup""] at line 1
	nil

In case you wonder: the 'file not found' errors go away when running snabb from the src directory. Interesting enough, they don't show when running with a config containing reassembly{}

Thanks for the report!

Fixed.
Now it's possible to leave reassembly container blank. If it isn't set, its children attributes: max-fragments-per-packet and max-packets are set to 0.
$ sudo ./snabb config get -s snabb-softwire-v2 lwaftr /softwire-config/internal-interface/ | tee log
allow-incoming-icmp false;
error-rate-limiting {
  packets 600000;
}
reassembly {
  max-fragments-per-packet 0;
  max-packets 0;
}


snail complete.

Coverage increased (+0.5%) to 91.531% when pulling fe345e896f95d92e8598c71b9596ffcfbc99bd5c on snail into 7a5a91311ef13c74439c945ae24c599896890d9e on master.


Allow custom IP addresses and the app subnet in the storage account

Purpose
Changes the network settings in the storage account to enable public access only from:

The app subnet
Custom public IP addresses

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone https://github.com/Yvand/functions-quickstart-typescript-azd.git
cd functions-quickstart-typescript-azd
git checkout allow-subnet-in-storage
npm install
azd provision

Test the code

What to Check
Verify that the following are valid
Go to the Azure portal > storage account > Networking:
Public network access is set to "Enabled from selected virtual networks and IP addresses", and:

The subnet "app" is added
Specified IP addresses are allowed

Other Information

Thank you for this @Yvand. A request: could this be updated to follow the same that was done for the .NET and the Java HTTP quickstart samples and introduce a SKIP_VNET setting, for consistency? Here are the relevant PRs for your reference:

For the .NET one https://github.com/Azure-Samples/functions-quickstart-dotnet-azd/pull/14
For the Java one https://github.com/Azure-Samples/azure-functions-java-flex-consumption-azd/pull/6

@nzthiago thank you for your reply. I can do what you request, although it means that I need to rework on already outdated code in my repo.
So before I commit to that, please clarify what I should expect in terms of responsiveness for contributions to this repo.
Because My PR went unanswered for a long time. Meantime, I made many other changes, including changes to make it SFI-compliant (the vnet was really just a start).
I am willing and happy to contribute to this repository, but I need to know if I can expect a better responsiveness.
Right now, I'm afraid my repo has already diverged so much that I would have to re-fork your repo, to submit multiple PRs for each change, insteaf of a single big PR.
Thank you

Thank you. Unfortunately at this stage you can expect a similar response time, as these are samples that get reviewed over time and not a production system. We definitely do want to keep them updated and with best practices in mind, and once Flex Consumption GAs the team will be more responsive with sample reviews and likely would be less than 2 weeks. This is an optional request of course, I can add the SKIP_VNET setting based on the other language PRs and you could propose other updates once that's done if it makes things easier on your part.

Ideally when SKIP_VNET is false (which should be the default) the storage account would be configured with a private endpoint and have public networking access completely off, that's how we had it on the other samples I shared above. I noticed you are using a service endpoint instead, is private endpoint possible for you?

I understand that allowing the vnet app to the storage network duplicates the job done by adding the private endpoint, I did it because:

If param allowedIpAddresses is set, the networking access should be allowed to allow those IPs (regardless of SKIP_VNET)
As is, code is easy to read. I'm a bit concerned it becomes messy, if it allows the network access only if allowedIpAddresses is set or SKIP_VNET is false

Actually, is the private endpoint truly necessary? I guess it allows a more secure configuration, as it allows storage's networking access to be fully off 🤔
Please let me know what you think

Yes, the reason we went with private endpoints on the other samples is that it allowsstorage networking access to be fully off.

With this in mind, and considering that the private endpoint is always created, do we need SKIP_VNET at all?
What about:

If param allowedIpAddresses is set, networking access is allowed, only for those IPs (not adding the vnet)
If param allowedIpAddresses is not set, networking access is off

This guarantees that networking access is allowed only if there is a genuine reason, and if enabled, it does not duplicate what the private endpoint achieves

Aha, the idea with SKIP_VNET is for customers that don't want VNET as part of the solution, maybe they're just getting started and identity-based connections are sufficient before they move to all that VNet brings. This is one of the quickstart that we link to from the public documentation so looking to cater to all customers - for example this one is described and linked to from here. Note that the default for SKIP_VNET on the other repos defaults to false so by default the VNet will be included.
For the private endpoint question, yes usually each resource needs its own private endpoint configured.

I took the time to test the .NET project:
If param skipVnet is true, no vnet or private endpoint is created, and the storage account accepts all network connections.
Well, not only does it make much deeper changes than its name suggests, it also very significantly degrades the security of the resources. Its name should really be more something like skipSecurity
I am working hard to make this template SFI-compliant, so it is simply impossible to permit this on my template.
Please let me know your thoughts, if you really want this param skipVnet, this PR probably makes no sense at all, since either a vnet or a private endpoint must be created, to allow connections only from some IPs + ensuring the functions can also connect.

I want to clarify, these samples are public and for the general public. I agree with you that the best / most secure version of it is with the VNet in the mix. That's why skipVnet is false by default in the samples, so by default it will include the VNet and public endpoints. Even with skipVnet = true, the storage account has key-based access disabled (allowBlobPublicAccess=false, allowSharedKeyAccess=false) and only managed identity will work which is still configured by the sample even without a VNet. We added skipVNet as an option for customers just getting started on their security journey in case they want to see the sample without it first and then add VNet later. You can and should of course make your own internal apps as secure as possible, and with VNet.


[TextField] datetime-local input clears if no time is specified

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When the user inputs the date without time in an Input type datetime-local and he moves the focus out of the input, the input will be cleared.

Expected behavior 🤔
When the user inputs the date without time in an Input type datetime-local and he moves the focus out of the input, the input maintains the state.
Steps to reproduce 🕹
Steps:

The user enters a date without time in the MUI Input type datetime-local
The user moves the focus out of the input
The input state is cleared

codesandbox: https://codesandbox.io/s/mui-materialui-bug-input-datetime-local-clears-qcms0o
Context 🔦
To maintain the input state when if the input loses focus. (just like in the native HTML5 input implementation)
Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: macOS 12.2.1
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 1.08 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/.asdf/installs/nodejs/16.13.2/bin/node
    Yarn: 1.22.15 - ~/.asdf/installs/yarn/1.22.15/bin/yarn
    npm: 8.1.2 - ~/.asdf/plugins/nodejs/shims/npm
  Managers:
    Homebrew: 3.3.14 - /usr/local/bin/brew
    pip3: 21.3.1 - ~/projects/alpha/.direnv/python-3.9.9-venv/bin/pip3
    RubyGems: <IP_ADDRESS> - /usr/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 4.2.1 - /usr/bin/gcc
    Git: 2.35.0 - /usr/local/bin/git
    Clang: 13.0.0 - /usr/bin/clang
  Servers:
    Apache: 2.4.51 - /usr/sbin/apachectl
  Virtualization:
    Docker: 20.10.12 - /usr/local/bin/docker
  IDEs:
    Nano: 2.0.6 - /usr/bin/nano
    Vim: 8.2 - /usr/local/bin/vim
    Xcode: /undefined - /usr/bin/xcodebuild
  Languages:
    Bash: 5.1.16 - /usr/local/bin/bash
    Java: 11.0.14 - /Users/jesus.gonzalez/.asdf/installs/java/zulu-11.54.23/bin/javac
    Perl: 5.34.0 - /usr/local/bin/perl
    Python: 3.9.9 - /Users/jesus.gonzalez/project/.direnv/python-3.9.9-venv/bin/python
    Python3: 3.9.9 - /Users/jesus.gonzalez/project/.direnv/python-3.9.9-venv/bin/python3
    Ruby: 2.6.8 - /usr/bin/ruby
  Databases:
    SQLite: 3.36.0 - /usr/bin/sqlite3
  Browsers:
    Chrome: 98.0.4758.102
    Safari: 15.3

May you assign this problem to me.

I checked the basic  <input           type="datetime-local"           onChange={(e) => console.log("HTML " + e.target.value)}         />
When the input is partial field onChange is not triggered. It is triggered when the field is fully filled.
https://codesandbox.io/s/mui-materialui-bug-input-datetime-local-clears-forked-hroj94?file=/src/Demo.tsx
I think this is not related to MUI.

@abhinav-22-tech, the problem is the input content/state is cleared. You are referring to when the change event is triggered, which is not related to the issue currently raised.

Okay, I understand your issue. I will try to solve this problem.

@Jesus-Gonzalez I have come across this issue as well. It seems the behavior changed @mui/lab": "^5.0.0-alpha.56 onwards. Going back to version alpha.55 does not cause this behavior.

Any progress fixing this one?

@abhinav-22-tech has there been any progress regarding this issue?

Hey guys, I found a workaround for this.
You need to supply a default value for the TextField, like an empty string: value || ""
<TextField
    type="datetime-local"
    onChange={(event) => setValue(event.target.value)}
    value={value || ""}
/>

If you do this, it will prevent it from getting cleared when you click away.
Sandbox: https://codesandbox.io/s/mui-materialui-bug-input-datetime-local-clears-forked-wywsv8?file=/src/Demo.tsx


code typo in Getting_Started.md

I figured that
Variable Declarions
should've  been
Variable Declarations
I'm pretty new to all this, so I apologize if there's anything uncool about what/how I did.
Thanks for all the mods, and EXTENSIVE documentation.  Very educational!

Merged, thank you for your contribution.


Windows 11 Context menus.

Description of the new feature / enhancement
It would greatly be appreciated, if you would include a feature allowing us to turn back on the original context menus. In Windows 11.
Scenario when this would be used?
When I wanted to switch to it. For a more proficient work flow.
Supporting information
No response

Press Shift+F10 or the bottom item in the menu.

"Windows 11 context menus: How to fix the new right-click menus | PC Gamer" https://www.pcgamer.com/amp/windows-11-context-menu-fix-right-click/

Thank you, for the response. I have fixed now and am on my way to being a
happy customer again.
On Sun, Jan 9, 2022 at 5:54 PM Jay @.***> wrote:

"Windows 11 context menus: How to fix the new right-click menus | PC
Gamer"
https://www.pcgamer.com/amp/windows-11-context-menu-fix-right-click/
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/15312#issuecomment-1008449717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGPGRMDYWZCCU2PFRHSIE3UVIN5HANCNFSM5LOSUPMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

@crutkas do you think it's possible/worth to create a UI for small (often registry) tweaks like this? This one could fit under File Explorer, but there could be countless of these small things for many different areas...

I would totally like to see a feature of that nature. However, I don't know
how registry listings compare to Android build.prop listings, when it comes
to the fact that it is somewhere in source code. No matter what, I would
believe that at least explorer.exe would have to be restarted. After
anything is added or changed in the registry. Still trying to figure out
how non Microsoft employees are able to figure out what you need to put in
the registry to accomplish these types of scenarios. If it was AOSP it
wouldn't be a problem to do these things, but windows is closed source.

On Mon, Jan 10, 2022 at 9:55 AM Jay @.***> wrote:

@crutkas https://github.com/crutkas do you think it's possible/worth to
create a UI for small (often registry) tweaks like this? This one could fit
under File Explorer, but there could be countless of these small things for
many different areas...
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/15312#issuecomment-1009018879,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABGPGRKPR4KVK2WHC7INL4LUVL6O7ANCNFSM5LOSUPMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Still trying to figure out
how non Microsoft employees are able to figure out what you need to put in
the registry to accomplish these types of scenarios. If it was AOSP it
wouldn't be a problem to do these things, but windows is closed source.

So some registry keys are documented. And the ones who aren't documented get found out by try and error. I mean all registry keys have a name, so you can guess what they do

Could be something that could be put into PowerToys?

Hey all, just popping in a (admittingly general) comment here. Just came across a video of Thio Joe where he quickly shows a number of apps, regarding tweaking Windows: https://www.youtube.com/watch?v=n7lykL7ZELQ
Not promising everything here, but it might help you on your way! :)


Browsing to open offer fails [Bug]

What happened?
When I attempt to view an offer by clicking browse in the GUI, I receive this error: ENOENT: no such file or directory, stat ''
However, when I drag and drop an offer file from an explorer window, it opens as expected. Both of these cases are shown in the following video:
https://github.com/Chia-Network/chia-blockchain-gui/assets/69756004/d0d82793-72fd-407e-9eb1-dff11c9c8562
Version
2.1.0rc3 (binary installation)
What platform are you using?
Windows
What ui mode are you using?
GUI
Relevant log output or stacktrace
No response

@lipalong Can you take a look at this one? I can repro in 2.1.0-rc4. We can apply a fix to main


[cookies] Containers JSON should be opened as utf-8

Closes #7797
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at a3edb74
Summary
🐛🆕🦊

Fix cookie extraction bug with non-ASCII characters and add support for Firefox containers. Modify yt_dlp/cookies.py to use 'utf8' encoding when reading containers_path.

open with utf8
Fixes bug for containers
Autumn leaves cookies

Walkthrough

Add support for Firefox containers in cookie extraction feature (yt_dlp/cookies.py)

Modify open function to specify encoding as 'utf8' when reading containers_path file (link)

Can merge for now.
It's such a common mistake. Maybe we should make a util like devscripts.utils.read_file?


How can control the time delay before the inputOptions pops up?

There is a small delays before inputOptions are popup. Is there a way to control the delay interval?

Hi @horaceho! Currently this isn't customizable. The delay is 0.3 seconds, see setupInputOptionsConfiguration method. I will make this customizable in a future release.

Thank you!


Update checkstyle reference to 5.0.1

[INFO] Cosmic Plugin - Hypervisor OracleVM3 .............. SUCCESS [18.931s]
[INFO] Cosmic Plugin - Hypervisor KVM ....................
For now I'm directing these builds to the bubbles, and will then recreate the normal slaves with extra disks

go build

@bheuvel the build was failing because we need to merge the PR that adds the distribution management first. I've opened that PR from the branch that was already there, and it includes this change.
Closing this.


queryOne: does now return self instead of nil if nothing is found

What was the rationale for the change?

Woo... too much time passed. Sorry! don't know why I didn't answer you. I agree the change doesn't make sense. It was proposed in issue #10 and the wrong rationale might be this: I supposed when no result is found, anyway the doBlock was evaluated with $err in the reply.
queryOne: aMongoQuery
	aMongoQuery doBlock: [:each |
		^(each includesKey: '$err')
			ifTrue: [ MongoQueryError signalFor: each ]
			ifFalse: [ each ] ].
	aMongoQuery chunkSize: 1.
	(MongoCursor new
		root: self;
		query: aMongoQuery;
		execute).
	^nil


chore: bump API category for RTF fix

Description of changes
Bump the amplify-category-api to v3.1.7

Reverted runtime filter for subscription
Removed searchable migration tests

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10847 (9449b31) into dev (2b17187) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10847   +/-   ##
=======================================
  Coverage   47.43%   47.43%
=======================================
  Files         673      673
  Lines       33274    33274
  Branches     6724     6724
=======================================
  Hits        15782    15782
  Misses      15803    15803
  Partials     1689     1689

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

We can merge this since that test was failing on dev before this PR.