ControlNets unload every step (very slow performance)

The extension seems to do something that breaks controlnet usage even when no AITemplate loaders are in use.
The attached image contains a workflow (modified straight from a ComfyUI controlnet example, so it should be pretty minimal) that works when AIT is not in the custom_nodes folder, and breaks when it is.

The error it fails with is:
Error occurred when executing KSampler:

Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)

  File "/home/sd/git/ComfyUI/execution.py", line 151, in recursive_execute
    output_data, output_ui = get_output_data(obj, input_data_all)
  File "/home/sd/git/ComfyUI/execution.py", line 81, in get_output_data
    return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
  File "/home/sd/git/ComfyUI/execution.py", line 74, in map_node_over_list
    results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
  File "/home/sd/git/ComfyUI/nodes.py", line 1207, in sample
    return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise)
  File "/home/sd/git/ComfyUI/custom_nodes/AIT/AITemplate/AITemplate.py", line 175, in common_ksampler
    samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
  File "/home/sd/git/ComfyUI/custom_nodes/AIT/AITemplate/AITemplate.py", line 308, in sample
    samples = sampler.sample(noise, positive_copy, negative_copy, cfg=cfg, latent_image=latent_image, start_step=start_step, last_step=last_step, force_full_denoise=force_full_denoise, denoise_mask=noise_mask, sigmas=sigmas, callback=callback, disable_pbar=disable_pbar, seed=seed)
  File "/home/sd/git/ComfyUI/comfy/samplers.py", line 727, in sample
    samples = getattr(k_diffusion_sampling, "sample_{}".format(self.sampler))(self.model_k, noise, sigmas, extra_args=extra_args, callback=k_callback, disable=disable_pbar)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/k_diffusion/sampling.py", line 539, in sample_dpmpp_sde
    denoised = model(x, sigmas[i] * s_in, **extra_args)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/samplers.py", line 317, in forward
    out = self.inner_model(x, sigma, cond=cond, uncond=uncond, cond_scale=cond_scale, cond_concat=cond_concat, model_options=model_options, seed=seed)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/k_diffusion/external.py", line 125, in forward
    eps = self.get_eps(input * c_in, self.sigma_to_t(sigma), **kwargs)
  File "/home/sd/git/ComfyUI/comfy/k_diffusion/external.py", line 151, in get_eps
    return self.inner_model.apply_model(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/samplers.py", line 305, in apply_model
    out = sampling_function(self.inner_model.apply_model, x, timestep, uncond, cond, cond_scale, cond_concat, model_options=model_options, seed=seed)
  File "/home/sd/git/ComfyUI/comfy/samplers.py", line 283, in sampling_function
    cond, uncond = calc_cond_uncond_batch(model_function, cond, uncond, x, timestep, max_total_area, cond_concat, model_options)
  File "/home/sd/git/ComfyUI/comfy/samplers.py", line 235, in calc_cond_uncond_batch
    c['control'] = control.get_control(input_x, timestep_, c, len(cond_or_uncond))
  File "/home/sd/git/ComfyUI/comfy/controlnet.py", line 161, in get_control
    control = self.control_model(x=x_noisy.to(self.control_model.dtype), hint=self.cond_hint, timesteps=t, context=context.to(self.control_model.dtype), y=y)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/cldm/cldm.py", line 283, in forward
    emb = self.time_embed(t_emb)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/home/sd/git/stable-diffusion-webui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/sd/git/ComfyUI/comfy/ops.py", line 18, in forward
    return torch.nn.functional.linear(input, self.weight, self.bias)
Queue size: 0
Extra options

AITemplate must move something to the wrong device at some point, but I haven't been able to figure out where it happens.

Ah just seeing it break it everywhere now. I'll merge #41 so this won't be an issue. Just a little worried it feels unfinished. The TODO here is getting the controlnets to not unload every step

I renamed this issue to be in line with the current bug.

@FizzleDorf I have this patch locally to just completely skip unloading and things work at sane speeds:
diff --git a/AITemplate/AITemplate.py b/AITemplate/AITemplate.py
index 74f4664..b2a76b4 100644
--- a/AITemplate/AITemplate.py
+++ b/AITemplate/AITemplate.py
@@ -411,7 +411,6 @@ class ControlNet(ControlBase):
                 context = torch.cat(cond['c_crossattn'], 1)
                 y = cond.get('c_adm', None)
                 control = self.control_model(x=x_noisy, hint=self.cond_hint, timesteps=t, context=context, y=y)
-                comfy.model_management.unload_model_clones(self.control_model_wrapped)
         else:
             # AITemplate inference, returns the same as regular
             control = self.aitemplate_controlnet(x_noisy, t, cond, self.cond_hint)

But I'm pretty sure that's just a memory leak that papers over the performance problem, so I haven't made a PR for it.

@FizzleDorf I have this patch locally to just completely skip unloading and things work at sane speeds:
diff --git a/AITemplate/AITemplate.py b/AITemplate/AITemplate.py
index 74f4664..b2a76b4 100644
--- a/AITemplate/AITemplate.py
+++ b/AITemplate/AITemplate.py
@@ -411,7 +411,6 @@ class ControlNet(ControlBase):
                 context = torch.cat(cond['c_crossattn'], 1)
                 y = cond.get('c_adm', None)
                 control = self.control_model(x=x_noisy, hint=self.cond_hint, timesteps=t, context=context, y=y)
-                comfy.model_management.unload_model_clones(self.control_model_wrapped)
         else:
             # AITemplate inference, returns the same as regular
             control = self.aitemplate_controlnet(x_noisy, t, cond, self.cond_hint)

But I'm pretty sure that's just a memory leak that papers over the performance problem, so I haven't made a PR for it.

prob dumb question How do I patch it for my comfy
just want to start using this flow but the only issue
Error occurred when executing KSampler:
Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1211, in sample
return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\custom_nodes\AIT\AITemplate\AITemplate.py", line 175, in common_ksampler
samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image,
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack\modules\impact\hacky.py", line 22, in informative_sample
raise e
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Impact-Pack\modules\impact\hacky.py", line 9, in informative_sample
return original_sample(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\custom_nodes\AIT\AITemplate\AITemplate.py", line 308, in sample
samples = sampler.sample(noise, positive_copy, negative_copy, cfg=cfg, latent_image=latent_image, start_step=start_step, last_step=last_step, force_full_denoise=force_full_denoise, denoise_mask=noise_mask, sigmas=sigmas, callback=callback, disable_pbar=disable_pbar, seed=seed)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py", line 676, in sample
samples = uni_pc.sample_unipc(self.model_wrap, noise, latent_image, sigmas, sampling_function=sampling_function, max_denoise=max_denoise, extra_args=extra_args, noise_mask=denoise_mask, callback=callback, variant='bh2', disable=disable_pbar)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 880, in sample_unipc
x = uni_pc.sample(img, timesteps=timesteps, skip_type="time_uniform", method="multistep", order=order, lower_order_final=True, callback=callback, disable_pbar=disable)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 730, in sample
model_prev_list = [self.model_fn(x, vec_t)]
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 421, in model_fn
return self.data_prediction_fn(x, t)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 403, in data_prediction_fn
noise = self.noise_prediction_fn(x, t)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 397, in noise_prediction_fn
return self.model(x, t)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 329, in model_fn
return noise_pred_fn(x, t_continuous)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\extra_samplers\uni_pc.py", line 297, in noise_pred_fn
output = model(x, t_input, **model_kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\k_diffusion\external.py", line 98, in predict_eps_discrete_timestep
return (input - self(input, sigma, **kwargs)) / utils.append_dims(sigma, input.ndim)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in call_impl
return forward_call(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\k_diffusion\external.py", line 125, in forward
eps = self.get_eps(input * c_in, self.sigma_to_t(sigma), **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\k_diffusion\external.py", line 151, in get_eps
return self.inner_model.apply_model(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py", line 311, in apply_model
out = sampling_function(self.inner_model.apply_model, x, timestep, uncond, cond, cond_scale, cond_concat, model_options=model_options, seed=seed)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py", line 289, in sampling_function
cond, uncond = calc_cond_uncond_batch(model_function, cond, uncond, x, timestep, max_total_area, cond_concat, model_options)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py", line 241, in calc_cond_uncond_batch
c['control'] = control.get_control(input_x, timestep, c, len(cond_or_uncond))
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\controlnet.py", line 162, in get_control
control = self.control_model(x=x_noisy.to(self.control_model.dtype), hint=self.cond_hint, timesteps=t, context=context.to(self.control_model.dtype), y=y)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\cldm\cldm.py", line 283, in forward
emb = self.time_embed(t_emb)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\container.py", line 217, in forward
input = module(input)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl
return forward_call(*args, **kwargs)
File "K:\AI ART UNIVERSE\COMFY-UI\ComfyUI_windows_portable\ComfyUI\comfy\ops.py", line 18, in forward
return torch.nn.functional.linear(input, self.weight, self.bias)

@TheMindExpansionNetwork just updating AIT should get rid of that exception. My patch just deals with the slowness.
If you want to use it, you should be able to copy the patch as-is to a text file and use "git apply" in the AIT repository to apply it, but you should know that doing so means you'll have to deal with your local version of AIT being different from what's on github, and the patch may interfere with updating the nodes if a conflicting change is introduced.


Workspace - Crash upon inputting number both on Manage members and Invite new member pages

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
and login
Create a workspace
Go to Workspace Settings > Manage members
Input any incorrect number in search field
Click Invite
Input any incorrect number, mark it and Click Invite

Expected Result:
Error message, that number is incorrect and cannot be added.
Actual Result:
Crash upon inputting number both on Manage members and Invite new member pages
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/225482469-b30dec00-99c5-423c-8065-aa3a817df881.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Have to re-assign as I have been swamped under Ops chores, sorry!

Unable to reproduce, this behaves correctly for me in staging.new.expensify.com in Chrome:
https://user-images.githubusercontent.com/59587260/225513442-f1b09056-4ab1-4c1d-ba68-939aa8cd22cd.mp4


worker: Add outputs to job and renames thing to match Saturns concept

Bit of refactoring to adapt with what we spoke about the config.
Also hit a bug where test where taking way longer than they should because of a sleep in the Scheduler. I created a TasksGroup class to handle what the sleep tried to do.

lgtm


Enable express vulnerability assessment at scale

Hello,
At the section 'Enable express vulnerability assessment at scale' the following is stated:
If you have SQL resources that don't have Advanced Threat Protection and vulnerability assessment enabled, you can use the SQL vulnerability assessment APIs to enable SQL vulnerability assessment with the express configuration at scale.
So I understand that deploying SQL vulnerability assessment express only works via API's and is not available in ARM or bicep?
When will it be available ARM or bicep?
Thank you for your response!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 40dacaf4-56e4-a2e8-6aad-d03b10ef4d43
Version Independent ID: 60a60be3-0dbe-ad5f-db8b-86ddb30d5164
Content: Enable vulnerability assessment on your Azure SQL databases using Microsoft Defender for Cloud
Content Source: articles/defender-for-cloud/sql-azure-vulnerability-assessment-enable.md
Service: defender-for-cloud
GitHub Login: @bmansheim
Microsoft Alias: benmansheim

@neok-g
Thanks for your feedback! We will investigate and update as appropriate.

@bmansheim
Can you please check and add your comments on this doc update request as applicable.

Hi @neok-g . Please content support to see if they can give you information about product timelines.
#please-close


New module loading changes break loading in Firefox

After updating to the commit at https://github.com/source-academy/frontend/pull/2904, the frontend is no longer loading properly for me, but only for my Firefox browser (124.0.2). Everything works fine when I tried loading it in Safari.

These are the network and console logs at this commit:

These are the network and console logs before this commit:

Other things that may be relevant:
-Firefox 124.0.2
-Safari 16.6
-Macbook on M2 chip, ventura 13.5.2
-Python 2.7.18 used for gl build
-backend used = true under .env settings
-I note that this issue occurred while working on my pull request at https://github.com/source-academy/frontend/pull/2856, which I merged master into.

Resolved via source-academy/js-slang#1656


Stuck indexing when adding more than one project folder

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description
Stuck indexing when adding more that one project folder to atom-beta
Steps to Reproduce

$ atom-beta ./<project>
Atom opens - Cmd+T, Fuzzy window works fine
$ atom-beta --add ~/<path>/<project> - another project added to atom
In atom - Cmd+T, Fuzzy window shows:

Note! This steps are reproducing the bug only in atom-beta. In atom this bug appears for some other reason sometimes.
Expected behavior: Both projects successfully indexed and possible to open file using Fuzzy window.
Actual behavior: Stuck while indexing
Versions
Atom:
$ atom -version
Atom    : 1.7.3
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

Atom-beta:
$ atom-beta -version
Atom    : 1.8.0-beta3
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

Can you reproduce the issue in Safe Mode? To launch Safe Mode:

Completely exit all instances of Atom
Launch Atom with the command atom --safe

Yes, same issue in save mode. And since the issue seem to be for atom-beta only the command is atom-beta --save or atom-beta --save --add ~/<path>

It is safe mode, not save mode.

@50Wliu Sorry for typos. Tested again, and same issue.

@frenchbread Would you mind reopening this Issue on the https://github.com/atom/fuzzy-finder repository? It will make tracking some things easier.

Sure.
For reference: https://github.com/atom/fuzzy-finder/issues/205

Thanks very much @frenchbread :grinning:


fetch pdf file from host and store in object storage

https://www.tsa.gov/foia/readingroom

Interesting, thanks for the repo and issues, let me know when you have something for me to review ...

two most recent pdf files on website

pdfs scraped and written to object storage

associated dates added to processed_dates lookup

Interesting, thanks for the repo and issues, let me know when you have something for me to review ...

will do. I should have a pr in the next day or two.


fmt: Scanf supports %X for integers but not strings. [Patch+Tests included]

The fmt Documentation states two things:

Firstly, for Printing:

String and slice of bytes (treated equivalently with these verbs):

%s	the uninterpreted bytes of the string or slice
%q	a double-quoted string safely escaped with Go syntax
%x	base 16, lower-case, two characters per byte
%X	base 16, upper-case, two characters per byte

Secondly, for Scanning:

The formats behave analogously to those of Printf with the following exceptions:

%p is not implemented
%T is not implemented
%e %E %f %F %g %G are all equivalent and scan any floating point or complex value
%s and %v on strings scan a space-delimited token
Flags # and + are not implemented.

(Note how %X is not listed among the exceptions)
So given the following:
var (
    hex = "48C3A43F"
    b   []byte
    i   int
    s   string
)

fmt.Sscanf(hex, "%X", &b)
fmt.Sscanf(hex, "%X", &i)
fmt.Sscanf(hex, "%X", &s)
fmt.Println("Bytes:  ", b)
fmt.Println("Integer:", i)
fmt.Println("String: ", s)

one would assume that b, i and s now respectively contain byte and integer representations of the hex-value 48C3A43F. However, this is not the case! Instead, the following output is generated:
Bytes:   []
Integer:<PHONE_NUMBER>
String:

Only the integer variable gets correctly assigned.
But: Substituting "%X" with lower-case "%x" in the example above gives the desired output:
Bytes:   [72 195 164 63]
Integer:<PHONE_NUMBER>
String:  Hä?

I conclude that this behavior is a bug. Either the verb "%X" should be explicitly listed as an exception in the Scanning-documentation or it should be fully supported for all relevant types.
I therefore submit the following patch (including additional relevant tests) which adds support for upper-case "%X" when scanning into []byte or strings:
diff --git a/src/fmt/scan.go b/src/fmt/scan.go
index e3e0fd0..68cb8bb 100644
--- a/src/fmt/scan.go
+++ b/src/fmt/scan.go
@@ -813,7 +813,7 @@ func (s *ss) scanComplex(verb rune, n int) complex128 {
 // convertString returns the string represented by the next input characters.
 // The format of the input is determined by the verb.
 func (s *ss) convertString(verb rune) (str string) {
-	if !s.okVerb(verb, "svqx", "string") {
+	if !s.okVerb(verb, "svqxX", "string") {
 		return ""
 	}
 	s.skipSpace(false)
@@ -821,7 +821,7 @@ func (s *ss) convertString(verb rune) (str string) {
 	switch verb {
 	case 'q':
 		str = s.quotedString()
-	case 'x':
+	case 'x', 'X': // s.hexString() supports both upper and lower-case hex strings, so we can support both verbs here.
 		str = s.hexString()
 	default:
 		str = string(s.token(true, notSpace)) // %s and %v just return the next word
diff --git a/src/fmt/scan_test.go b/src/fmt/scan_test.go
index 334c4a6..1924c02 100644
--- a/src/fmt/scan_test.go
+++ b/src/fmt/scan_test.go
@@ -255,12 +255,14 @@ var scanfTests = []ScanfTest{
 	// Strings
 	{"%s", "using-%s\n", &stringVal, "using-%s"},
 	{"%x", "7573696e672d2578\n", &stringVal, "using-%x"},
+	{"%X", "7573696E672D2558\n", &stringVal, "using-%X"},
 	{"%q", `"quoted\twith\\do\u0075bl\x65s"` + "\n", &stringVal, "quoted\twith\\doubles"},
 	{"%q", "`quoted with backs`\n", &stringVal, "quoted with backs"},

 	// Byte slices
 	{"%s", "bytes-%s\n", &bytesVal, []byte("bytes-%s")},
 	{"%x", "62797465732d2578\n", &bytesVal, []byte("bytes-%x")},
+	{"%X", "62797465732D2558\n", &bytesVal, []byte("bytes-%X")},
 	{"%q", `"bytes\rwith\vdo\u0075bl\x65s"` + "\n", &bytesVal, []byte("bytes\rwith\vdoubles")},
 	{"%q", "`bytes with backs`\n", &bytesVal, []byte("bytes with backs")},

Normally patches are sent on Gerrit. https://golang.org/doc/contribute.html

Thanks will do

Submitted: https://go-review.googlesource.com/#/c/15689/


Load Google fonts over https

Necessary to fix this mixed content error:
Mixed Content: The page at 'https://<app-name>.herokuapp.com/invite' was loaded over HTTPS, but requested an insecure stylesheet 'http://fonts.googleapis.com/css?family=Lato:300,400,700,900,700italic|Open+Sans:700italic,400,600,300,700,800'. This request has been blocked; the content must be served over HTTPS.

Hello,
I modified the http to https, waiting for the master validate.
Thanks.

resolved in #43


Refactoring

@kul3r4 PTAL

Could you please give a small description of the goals of this refactoring?

It's three small refactorings. Each is described in the respective commit.

Ok sorry I missed them!
LGTM.


Update kafka-clients to 6.0.0-ce

Updates org.apache.kafka:kafka-clients from 2.6.0 to 6.0.0-ce.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.kafka", artifactId = "kafka-clients" } ]

labels: library-update, semver-major

Keeping Apache Kafka dependency for kafka-clients


Localisation

A system needs to be added to allow all built-in text to be translated to other languages or customised for any other reason. This system should also be usable by non-built-in components, allowing for easier translation of bots. The current locale should be a guild-specific setting, and locales should implement the Loader/Loadable functionality (depends on #196).

As promised, I'm working on that issue and have made some design decisions:

I use https://github.com/i18next as it already has a Loader/Loadable system and is feature rich, however it will be possible to integrate our own loader system later on. Bot owners may load and afterwards reload localization files even the ones which did not exist on initialization time.

I18next can be used for the whole bot, not only for commando. However, it will be possible to create a whole new instance, so there are no conflicts between commando translations and other ones.

Commando uses the language dev for its builtin strings, so one can define own strings for en, fallback language will be dev.

Language can be set same as the prefix, means global and per guild which will override the global one for messages on that guild.

The bot can't use the guild.language in DM mode so commando will try to translate into the language defined by user.locale but that may be different than guild.language. It's possible to configure fallback language for each user.locale  (see https://www.i18next.com/principles/fallback) so when user.locale equals es it's possible to fallback to fr instead of using the builtin translation.

The property used for the global language is named defaultLanguage and for guilds language, e.g. client.defaultLanguage and msg.guild.language.

Commandos builtin strings are defined in a javascript object instead of a json file. so one does not need to setup a path with localization files.

No breaking changes - it will be possible to start commando without additional setup/configuration required, so there are no breaking changes.

Use without translation - one can choose to define strings as normal, or use translations. Both variants will work. Also it will be possible to translate only selected strings into another languages. For the others, the default strings will be used.
example: description: new CommandoTranslatable('command.help.description') will work and translates the description description: 'my hard coded description' will also work, of course without translation

Update: I'm almost done. I've implemented the feature on my private bot and everything seems to work.
Only the translations for the type validations are missing.

Any news when this will be implemented officially?
Thanks

@perzeuss : 10 months later, is it still "almost done" ? Something can be done to help you achieve this ?
What is the roadmap to merge this into an official release (with documentation ^^) ?
thx :)

@Torbraw  @Kaon68 Please look at the PR for this issue: https://github.com/discordjs/Commando/pull/324#issuecomment-780927084
@Gawdl3y did not like my solution and I started to rewrite it but I had not time yet to complete that rewrite, because I've other work to do with higher priority.


Added the Forum page for open discussions

Changes:

New Feature: Introduced the Forum page accessible from the main navigation.
Backend Integration: Implemented secure storage and retrieval of forum discussions.
User Interaction: Enabled users to create threads and also reply to discussions

Benefits:

Collaboration: Enhances collaboration through open discussions on scheduling-related topics.
Community Engagement: Fosters a sense of community by encouraging active user participation.
User Support: Provides a platform for users to seek and offer assistance, improving the overall user experience.

Merging the Forum module in the application.


app_init.sh not linked to wyze_hack.sh?

I was trying to disable the stream_hack to debug an issue and noticed that editing /configs/wyze_hack.sh did not do anything.
Any particular reason why /system/init/app_init.sh is not a symbolic link to /configs/wyze_hack.sh like the standard WyzeHacks install.

I just noticed that link today. I guess I was using a very old version of wyze hacks on my V2 cameras.
I’m still not happy with install.sh. I’d like a version that works on v2 and v3 and whether or not wyze hacks is installed.
I also noticed wyze changed their logging with the new firmware, so my old way of looking at iCamera output doesn’t work anymore.

On Apr 19, 2021, at 7:09 PM, mrlt8 @.***> wrote:
I was trying to disable the stream_hack to debug an issue and noticed that editing /configs/wyze_hack.sh did not do anything.
Any particular reason why /system/init/app_init.sh is not a symbolic link to /configs/wyze_hack.sh like the standard WyzeHacks install.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/FiveLeavesLeft/WyzeCameraLiveStream/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATVGDMRKGRPNR6QOGERTX2TTJTO5XANCNFSM43HFK3WQ.

In the latest release, the stream hack is integrated into WyzeHacks, I think this addresses this issue.


NRE after playing the video and navigating back

Using nuget version 2.2.0, get following runtime exception after playing video and then navigating back to previous page.
at Xamarin.Forms.Platform.iOS.ViewRenderer`2[TView,TNativeView].SetNativeControl (TNativeView uiview) [0x00041] in <7ebe39ff6b6a406098d4f53a5ff873cb>:0
  at Octane.Xamarin.Forms.VideoPlayer.iOS.Renderers.VideoPlayerRenderer.OnElementChanged (Xamarin.Forms.Platform.iOS.ElementChangedEventArgs`1[TElement] e) [0x0006c] in <57157d21d2404e4b81ad31d1fd3e7438>:0
  at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__6_0 (System.Object state) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:1023
  at Foundation.NSAsyncSynchronizationContextDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/Foundation/NSAction.cs:178
  at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
  at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:79
  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0002c] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:63

Hi
I get the error with version 2.2.0 on Xamarin.Forms 4.0. The same error happen if I pause the videoplaying before navigate back.
Best Tino

Also experiencing the same error on a physical device, iOS 12.2, Xamarin Forms 4, when navigating away from a Page with a VideoPlayer

Full error:
System.NullReferenceException: Object reference not set to an instance of an object
  at Xamarin.Forms.Platform.iOS.ViewRenderer`2[TView,TNativeView].SetNativeControl (TNativeView uiview) [0x00041] in <db147fad2aa9412c845ff0ead92dfe20>:0
  at Octane.Xamarin.Forms.VideoPlayer.iOS.Renderers.VideoPlayerRenderer.OnElementChanged (Xamarin.Forms.Platform.iOS.ElementChangedEventArgs`1[TElement] e) [0x0006c] in <57157d21d2404e4b81ad31d1fd3e7438>:0
  at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__6_0 (System.Object state) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:1023
  at Foundation.NSAsyncSynchronizationContextDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/Foundation/NSAction.cs:178
  at at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
  at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:79
  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0002c] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:63

Page transition shortly before error:
...

void OnButtonPress(object sender, System.EventArgs e)
{
  MoveToNextPageAsync();
}

private async void MoveToNextPageAsync()
{
  if (!App.IsAppPassed())
  {
    await Navigation.PushAsync(new QuizIntroPage());
    Navigation.RemovePage(this);

  }
}

...

@adamfisher Have you managed to have a look at this / reproduce? It's preventing us deploying our app.

To be clear - can I take it you won't be looking at this issue then by way of 'open sourcing' the previously paid-for component?

i just updated 3.1.0 but still getting same exception at the end of video: Also i see
FormsVideoPlayer.Init();  does not take VideoPlayerKey now and can play longer video.
at Xamarin.Forms.Platform.iOS.ViewRenderer`2[TView,TNativeView].SetNativeControl (TNativeView uiview) [0x00041] in <7c3717ccc8b0481ab4edf04001284160>:0
 at Octane.Xamarin.Forms.VideoPlayer.iOS.Renderers.VideoPlayerRenderer.OnElementChanged (Xamarin.Forms.Platform.iOS.ElementChangedEventArgs`1[TElement] e) [0x0006c] in <d5eb4d4f9f524895a08721b7561379f7>:0
 at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__6_0 (System.Object state) [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/mcs/class/referencesource/mscorlib/system/runtime/compilerservices/AsyncMethodBuilder.cs:1023
 at Foundation.NSAsyncSynchronizationContextDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/Foundation/NSAction.cs:178
 at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
 at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:79
 at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x0002c] in /Library/Frameworks/Xamarin.iOS.framework/Versions/<IP_ADDRESS>/src/Xamarin.iOS/UIKit/UIApplication.cs:63

To fix this, I downloaded the source code and manually copied the source code into my standard and iOS project.  The problem is in the VideoPlayerRenderer.cs file, OnElementChanged method.  OnElementChanged() is being called while the renderer is being disposed.
To fix:
-- I added an _isDisposing variable:
private bool _isDisposing = false;
-- Set it in the Dispose method:
protected override void Dispose(bool disposing) {
_isDisposing = disposing;
-- Added _isDisposing check to the OnElementChanged method (I also added a try / catch):
base.OnElementChanged(e);
if (_isDisposing) return;

@victordscott - can you generate PR so the @adamfisher  can merge ? That way it will be available to all community.

@adamfisher / @victordscott what's the best way to get this fix merged?

@adamfisher @victordscott  @paul-muckypuddle  After updating to Xamarin.forms 4.1 the issue seems to be fix now. so not sure the issue is from the component or Xamarin.form. But its now working!


Registry landing page could be more helpful

Going to https://registry.buildpacks.io leads me to a UI that's not terribly descriptive about what I'm supposed to do now. Why am I here? What's a buildpack even?

Some kind of link to docs on buildpacks.io could go a long way.

Ill take this one on.

There is a link to the docs at the top of the page, but it sounds like it wasn't obvious. We could add a sentence or two of text below the search bar that says what this page is all about.

Fixed by #46


Error with curl

I have this installed but i get and google doesnt say anything
{ text: 'Hello Google Home' }
Error: connect EHOSTUNREACH 192.168.*.*:8009
error
Living room Home will say: Hello Google Home

My bad, forgot my vpn router is in front of my wifi


rename create to upsert for decision and plan, update sampling for app insights

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.41%. Comparing base (36580e3) to head (a76ebce).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #97   +/-   ##
=========================================
  Coverage     89.41%   89.41%
  Complexity      695      695
=========================================
  Files           118      118
  Lines          2116     2116
  Branches        112      112
=========================================
  Hits           1892     1892
  Misses          176      176
  Partials         48       48

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support for Async Fn in Trait?

As async_fn_in_trait is stable on nightly, is there plans to support it in the generated code? I recognized it would be a significant refactor, but it would be nice to avoid having to Box futures.

Hey, thanks for your interest! Yes, I have a branch that uses async_fn_in_trait on nightly (it probably needs some updates, as it's about 10 months old now). Once async_fn_in_trait is released on stable, I'll merge to master.

Wonderful, thanks!

I think this was fixed by https://github.com/google/tarpc/pull/413 :)


Styling

Changes Unknown when pulling 227449b56c931bcd316f4142e8fc6f3425b7ce70 on styling into ** on development**.

Changes Unknown when pulling f77eaf36e650c0ca75fdc0b0971a8e6dc40a280f on styling into ** on development**.


feat: add EllipticSigner that returns string

This PR adds a new signer EllipticSinger which is similar to SimpleSigner but returns a string instead of a signature object. It also adds support for string signatures in SignerAlgorithms when using ES256K.
Replaces #90

Thanks @mirceanis 🙏


Adding references about memory one strategies

After discussion on https://github.com/Axelrod-Python/Axelrod/issues/170 I've added these two references about memory one strategies:

Stewart, Alexander J and Plotkin, Joshua B: Pnas
Press, William H and Dyson, Freeman J: Pnas

Oh, I already added the Freeman & Dyson paper! So I guess we'll be doing PRs here too from now on.

OK, I reverted so this will go through smoothly.

Oh, I already added the Freeman & Dyson paper! So I guess we'll be doing PRs here too from now on.

Assuming you're happy with that? At some point I guess it would be good to discuss/decide what the paper is about?

Have opened #2


Error: exit status 128 with<EMAIL_ADDRESS>

Hello I am getting the error "Exit status 128", fatal: reference is not a tree.
From the logs:
git "checkout" "6a02fas4d53a4d2f415e733565e4c09a1fddcb25"
fatal: reference is not a tree: 6a02fas4d53a4d2f415e733565e4c09a1fddcb25
ERROR: checkout (6a02fas4d53a4d2f415e733565e4c09a1fddcb25): checkout failed (6a02fas4d53a4d2f415e733565e4c09a1fddcb25), error: exit status 128
I use the integration with Gitlab available under the "account settings"
The last working version was 4.0.18.
Can you help? Or how can I provide you more information?
Regards.

Hi @emans
Thank you for reaching out to Bitrise Support.
I want to let you know that our engineers are looking into this issue.
We will let you know the update soon.
Thanks
Chaitanya

HI @emans. Please try increasing the clone depth on the git-clone step to 10 or possibly 50 and see if that resolves the issue.

Hi @emans. This is a known issue. We have filed a bug report with the devs.

@mjones-droid hi, thanks for help before everything.
so I did what you suggested with the clone depth and it worked. it fails first then it works.
First the error:
git "checkout" "8c225e4d6f30c7a1c112ce0faa6e043943247336"
fatal: reference is not a tree: 8c225e4d6f30c7a1c112ce0faa6e043943247336
Checkout failed, error: exit status 128

Then with the depth:
Unshallow...
git "fetch" "--unshallow"

Thanks for the help. If I can help somehow tell me or PM me :)
Regards.

I'll close this issue, as it seems to be solved, but if you need more info/help just let us know by opening a new one!


[Home Assistant] Error: Protocol "http:" not supported. Expected "https:"

Extension
https://github.com/raycast/extensions/blob/ea0de2a3c9ac5822f89e358d1d1d93cb704637b9/extensions/homeassistant/README.md
Description
Recently (not sure when) I found that I could not interact with my Home Assistant entities anymore without getting the error:

Error: Protocol "http:" not supported. Expected "https:"

I assume this is because I was using the local IP of my HASS server, which by default is only http. I currently have a reverse proxy setup, so it was a pretty easy fix for me, but for less technical users this might be difficult to setup I would assume. My gut would be to allow http as that is all home assistant support (as far as I can tell) in its default configuration.
Steps To Reproduce

setup home assistant with a http url.
attempt to change an entity via raycast
error!

Current Behaviour
nothing happens, get an error.
Expected Behaviour
command goes through.

Seeing this on my instance as well.

Confirmed reverting ea0de2a3 from https://github.com/raycast/extensions/pull/4906 resolves the error.
@ofalvai Do you have some time to see if you can update your fix to still support non-HTTPS installs?

Hey @rspeicher ,
I will fix that.

@rspeicher @chrisdrackett #5385 should fix the issue. You can try it out.

Hey @tonka3000, thank you for the quick fix and sorry about the issue. I can confirm the latest version still works on my HTTPS setup too!

Hey @ofalvai . No big deal, bugs happen. Thanks for making the PR for my extension.


paket pack with CLI CPP projects

Description
I can't create nuget package using paket.exe from CLI C++ library
Repro steps
I have ./.paket/ in my PATH environment variable

Create empty C++ project (I used VS2015)
run paket init (I actually run ../other-project/.paket/paket init)
run paket.bootstrapper
run paket install
add paket.template with content type project
run paket pack output .

Expected behavior
Paket creates "empty" nuget package
Actual behavior

$ paket pack output .
Paket version <IP_ADDRESS>
Paket failed with:
Unable to find Release output path node in file C:\projects\paket-cpp\ClassLibrary1\ClassLibrary1\ClassLibrary1.vcxproj for any known platforms

Related information

Latest Windows 10 (Red stone)
.NET 4.6.1

Attached project (without binaries or paket.exe)
paket-cpp.zip

how would you detect the output path in that file?

I changed outdir in project options and now I have this change in .vcxproj:

By default it is $(SolutionDir)$(Platform)\$(Configuration)\

So after the changes it pack works?
Am 23.08.2016 1:16 nachm. schrieb "pavelhritonenko" <
<EMAIL_ADDRESS>
I changed outdir in project options and now I have this change in .vcxproj:
[image: image]
https://cloud.githubusercontent.com/assets/2510026/17890029/12aa484a-693c-11e6-8610-e397f96d1661.png
By default it is $(SolutionDir)$(Platform)$(Configuration)\
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/1870#issuecomment-241700279,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNCCCiLmSS40crjDEMfkJMw6jn4Krks5qitaRgaJpZM4Jqzpq
.

No, it doesn't (even if I specified OutDir node for all possible platforms)

I'm pushing a fix which would also check for OutDir (currently we look for OutputPath), but I guess we can't use the default. Not sure how we would do this

can you please retry?

First, thanks for instant reaction, it's amazing.
Next error was related to absent <AssemblyName /> tag in the .vcxproj file, I've added it manually and now I get this when run paket pack output . buildplatform x64:
$ paket pack output . buildplatform x64
Paket version <IP_ADDRESS>
Paket failed with:
        The input sequence was empty.
Parameter name: source

can you please upload zip again?

the newly changed one I mean

https://github.com/pavelhritonenko/paket-cpp - I noticed there is unnecessary level of folders however I decided to not touch it.

and another release. please give it a try

Version from repository I linked:
$ paket pack output . buildplatform x64
Paket version <IP_ADDRESS>
Paket failed with:
        Index was outside the bounds of the array.

Since I can't build your project. Please commit output binaries as well
Am 23.08.2016 17:45 schrieb "pavelhritonenko"<EMAIL_ADDRESS>
Version from repository I linked:
$ paket pack output . buildplatform x64
Paket version <IP_ADDRESS>
Paket failed with:
Index was outside the bounds of the array.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/issues/1870#issuecomment-241777970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNG_HNRNxKBVOu1A8z4ud-FbtpBK_ks5qixWIgaJpZM4Jqzpq
.

so that a clean checkout would produce that error

I commited binaries. Did you mean that?
Khritonenko@khritonenko MINGW64 /C/projects/paket-cpp (master)
$ git clean -fXd
Removing .paket/paket.exe

Khritonenko@khritonenko MINGW64 /C/projects/paket-cpp (master)
$ git clean -fxd

Khritonenko@khritonenko MINGW64 /C/projects/paket-cpp (master)
$ paket.bootstrapper.exe
Checking Paket version (downloading latest stable)...
Copying version 3.15.2 from cache.
Done.

Khritonenko@khritonenko MINGW64 /C/projects/paket-cpp (master)
$ paket pack output . buildplatform x64
Paket version <IP_ADDRESS>
Paket failed with:
        Index was outside the bounds of the array.

sorry for playing pingpong. with latest version (just released) I now see:

this seems to be correct, right?

"Missing: Authors"


Fix typo Initilize -> Initialize

Linked Issue
Closes #2917
Description
Easy enough to spot. Fix typo Initilize -> Initialize
Changsets
Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.
Checklist
Please read and apply all contribution requirements.

[x] This PR targets the dev branch (NEVER master)
[x] Documentation reflects all relevant changes
[x] Branch is prefixed with: docs/, feat/, chore/, bugfix/
[x] Ensure Svelte and Typescript linting is current - run pnpm ci:check
[x] Ensure Prettier linting is current - run pnpm format
[x] All test cases are passing - run pnpm test
[x] Includes a changeset (if relevant; see above)

Thanks for the quick turnaround @phamduylong


A index does not match NOAA Space Weather value

The A index sensor value does not match the value on the NOAA Space Weather website.  For example, the current value reported by NOAA is 36 but the value I see in HA is 9.
I have restarted HA with debug and will post updates if any relevant info is noted.
Thanks for this integration, BTW.  I was starting to gather sources to build something on my own and then stumbled across this - WIN!
73,  Tim

Also, it seems the Planetary K index is off as well.  I am seeing 0 while the NOAA site reports it as 1.  Solar flux is close; NOAA: 176, HA: 167.  What is the timing of the updates?

swpc.get_standard() by default seems to return the first item from a list (for K, there is one measurement per minute over a period of 4 hours). So you get the value from 4 hours ago, not the current one.
I created a couple of PRs that update this:
https://github.com/tcarwash/swpclib/pull/8
https://github.com/tcarwash/home-assistant_noaa-space-weather/pull/34

Awesome, I'll take a look when I get a chance

In looking at this more closely it looks like maybe only K-index was backward (the NOAA APIs aren't standardized for 0th entry = newest data and I missed K-index)
I fixed K-index in swpclib v4.2.0 so it should return the newest data now. Fixing it at the library level will let us continue to take the first data point in swpc.get_standard() as normal. I'll just need to make a new version of this component that points at that version of v4.2.0 and we'll be getting the most recent data for all endpoints
Let me know if I'm missing something!

I think any outstanding incorrectly indexed endpoints are corrected in v2.0.1
Going to close this issue, let me know if I've got something wrong.
Thank you very much for your input!


WIP : Update of Data Validation and binding in general

I originally set out to implement the system in #529 but it turned out to be a lot more difficult than I expected :) In the end this has ended up being quite a major refactoring of our binding infrastructure, but hopefully for the better.
The changes on the whole follow the outline in #529, but I added a few other features too:

Added an error adornment for TextBox
Added support for validating Data Annotations
Improved the way errors are logged (this may still need some work though)
Data validation is currently only supported for direct properties
Data validation is now automatic for properties that support it:

How it will look to a control implementer
Data validation will be enabled per-property. In addition, for the moment data validation will only
be available on direct properties. To enable data validation on a property, set the
EnableDataValidation flag on property registration:
public static readonly DirectProperty<TextBox, string> TextProperty =
    AvaloniaProperty.RegisterDirect<TextBox, string>(
        nameof(Text),
        o => o.Text,
        (o, v) => o.Text = v,
        enableDataValidation: true);

private string _text;

public string Text
{
    get { return _text; }
    set { SetAndRaise(TextProperty, ref _text, value); }
}

Once data validation is enabled on a property, any binding to that property will have data
validation enabled, however nothing is done with the validation information by default: as mentioned
before, it is "pay to play" so nothing gets stored unless the control decides to. Instead, the
framework calls the UpdateDataValidation method each time a validated binding value is received.
In the example below, we use that information to set the :error pseudoclass on the control
depending on the validation state:

protected override void UpdateDataValidation(AvaloniaProperty property, BindingNotification status)
{
    // Set the ":error" pseudoclass if the error status is anything but "none".
    if (property == TextProperty)
    {
        ((IPseudoClasses)Classes).Set(":error", status.ErrorType != BindingErrorType.None);
    }
}

Other than the naming of StartListeningCore and StartListening this looks good to me!
There's some other features that I'd like to add to it, but considering the massive size of this PR those should wait until after this is merged.


A few issues while trying to rerun swe-bench-lite with aider

In the README.md Installation instructions, there is a naked pip install requirements.txt, without mention of creating a venv or other kind of environment. People should take care to avoid this, but better to smooth it.
The suggestion to read SWE-Bench docker docs to ensure docker images are built or pulled is confusing: pulls happen automatically, don't they? would be helpful to understand how harness.py relates to that repo. If there is a reason why not, I haven't gotten to that stage yet.
The Running the benchmark harness says to edit and run harness.py. I've run into the following issues with that:
The import of get_lite_dataset is commented out, when that's what I was trying to use, looks like an autofix to appease a linter due to commenting out the call to it, probably better to import all of them and put a noqa comment.
just_devin_570 (which I didn't want to do, since running lite) is turned on and used in two ways:

a condition filters out the dataset immediately
also it is threaded through process_instances to filter out predictions. Isn't this redundant with the previous? the predictions need to be adapted to the dataset whether it is lite, full or 570?

I just turned it to False, hoping that works.
After that, I just ran harness.py, and got an error of "NotImplementedError: Loading a dataset cached in a LocalFileSystem is not supported." This seems to possibly be a bug in datasets or fsspec (which would be pure bad luck on my part), but possibly improved by providing a frozen requirements file.

Reading more about the SWE-Bench-docker, I'd recommend adding to the Installation section (possibly with some disclaimers) something like:
SWE-bench-docker/scripts/pull_docker_images.sh SWE-bench-docker/docker/ aorwall

Ok, pip install -U datasets package resolved that issue.
Recommend to add mkdir chat-logs to the running instructions (or fix the code to auto-make), because:
Traceback (most recent call last):
  File "/home/danielv/System/Software/aider-swe-bench/./harness.py", line 482, in <module>
    status = main()
  File "/home/danielv/System/Software/aider-swe-bench/./harness.py", line 385, in main
    process_instances(
  File "/home/danielv/System/Software/aider-swe-bench/./harness.py", line 450, in process_instances
    chat_history_dname.mkdir(exist_ok=True)
  File "/usr/lib/python3.10/pathlib.py", line 1175, in mkdir
    self._accessor.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: 'chat-logs/testing---gpt-4o'

With that, benchmark is running, will report back after repro is done.

Run killed partway though (due to oai limit errors), trying to run ./report.py predictions/testing---gpt-4o.

Because DEVIN_570 was hard coded True in report.py, had 0 filtered predictions, so got error message:

  File "/home/danielv/System/Software/aider-swe-bench/./report.py", line 147, in preds_to_jsonl
    model_name_or_path = list(predictions.values())[0]["model_name_or_path"]
IndexError: list index out of range

Because didn't have directory logs, got: FileNotFoundError: [Errno 2] No such file or directory: 'logs/testing---gpt-4o'.
My relevant env is using python 3.10, so had to change swe-agent-docker to not use TaskGroup. Might be worth giving a warning that explains the issue, but not a big deal.
report is hardcoded to pass the FULL_DATASET_FNAME to run_evaluation, but that file is not in the aider_swe_bench repo. Using instead the LITE file, which is.
the directory predictions/full is assumed to pre-exist

After dealing with all of these, report.py completes, will mention that in separate comment.

I fully agree with @daniel-vainsencher; running this repo is not that smooth.
BTW, many thanks to Daniel's running log, it's really helpful.

@RenzeLou I appreciate it.
BTW, my report ended up looking very bad, because for many instances the logs are missing. Looking back, there is some issue writing the logs to /opt/logs, but I haven't debugged it yet. If anyone has seens this and has a fix, would be happy to hear about it.

I have gone through the testing scripts of this repo, it basically uses the log file to decide whether the instances are resolved (i.e.,  the *.eval.log files are required, otherwise the final test score will become zero). Someone can also check the resolve score calculation here:
https://github.com/princeton-nlp/SWE-bench/blob/8b1265b7817cf3cba114c56e7a5b98bba3f9979d/swebench/metrics/report.py#L328
However, I didn't find any .eval.log files after running this repo (as also mentioned by @daniel-vainsencher), where there are only  .md and .json files under the output dir.
@paul-gauthier Could you answer these questions? Where the .eval.log files are saved? Or, is there anything we missed?
I would very much appreciate it if you could help on this issue.

The workflow for working with SWE Bench in general is 2 steps:

Run your agent on the problems to produce predictions, which are a series of json records that get bundled up into a jsonl file.
Evaluate the predictions jsonl file using the acceptance tests. This produces the .eval.log files that I think you are asking about.

This repo is for running and evaluating aider on SWE Bench. As described in the README, it consists of 2 scripts:

The harness.py script will run aider on all the problems and produce predictions. It does not do any acceptance testing. It does run any pre-existing tests that were part of the problem's repo, but never runs any acceptance tests. This script produces a bunch of predictions as individual json files in predictions/<DIRNAME>/<instance_id>.json.

The report.py script consumes all those predictions and turns them into predictions/<DIRNAME>/all_preds.jsonl. It then feeds that jsonl file through the SWE Bench evaluation and reporting scripts to produce logs/<DIRNAME>/<instance_id>...eval.log files as well as a summary report in predictions/<DIRNAME>/results.json.

Let me know if that was helpful?

Thanks for your reply @paul-gauthier!
I am running the SWE-bench Lite, where I think I have correctly set the dataset (get_lite_dataset in harness.py).
After several instances had been predicted by Aider (I didn't run the full Lite bench), I ran the report.py, but there was no results.json or any .eval.log files generated.
Here is the info printed on the terminal:
...
LnB5IiwgInRlc3RzL3Rlc3RfZXh0X2F1dG9kb2NfY29uZmlncy5weSJdLCAidGVzdF9jbWQiOiAidG94IC1lcHkzOSAtdiAtLSB0ZXN0cy9yb290cy90ZXN0LWV4dC1hdXRvZG9jL3RhcmdldC9hbm5vdGF0aW9ucy5weSB0ZXN0cy90ZXN0X2V4dF9hdXRvZG9jX2NvbmZpZ3MucHkifQ== -e LOG_DIR=/opt/logs -e TIMEOUT=1800 -e LOG_SUFFIX= aorwall/swe-bench-sphinx-doc_sphinx-testbed:3.4
2024-06-05 16:11:50,583 - swebench_docker.run_docker - WARNING - Stdout - /bin/sh: docker: command not found

2024-06-05 16:11:50,583 - swebench_docker.run_docker - WARNING - Stderr - None
Processing predictions: 100%|████████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [00:00<00:00, 10871.71it/s]
==> log_dir: logs/lite---gpt-4o
sorted(resolved_instances): []
len(generated_minus_applied): 4
generated_minus_applied: django__django-13315* django__django-15061* django__django-16041* sphinx-doc__sphinx-8435*
len(with_logs_minus_applied): 0
with_logs_minus_applied: set()
len(no_apply): 0
no_apply:
predictions/OLD/lite---gpt-4o.240605-161150 predictions/lite---gpt-4o
len(chosen): 0
No predictions

I don't know what's going on. Could you provide any hints on this issue? Thanks so much.

@RenzeLou I would start from
/bin/sh: docker: command not found
Do you have docker installed?

@RenzeLou another thing: keep in mind that this is a very new repo, and that the task it attempts to do closely coordinates 4 repos (not counting mere libraries):

Aider
this repo
The SWE-Bench-docker repo
The SWE-Bench repo

This is a complicated integration piece, so it starting out imperfect is totally understandable. This is not for the feint of heart, its still a bit the wild west. If you are not ready to do serious debugging, I'd recommend waiting and seeing if they stabilize.

@paul-gauthier two things:

I'd like to have running LITE just work in harness and report, requiring the user to either change the code in a single place or pass arguments. Let me know if you'd like me to create a PR for that based on the changes I've already made.
The issue I am encountering with logs seems to be due to improperly set permissions with the original images in the aorwall namespace. Did you have to rebuild the docker images? any notes on what you did to fix them?

For posterity: part of the issue I was encountering with permissions is probably because I was using rootless docker, but I haven't completely resolved them. Switching to rootless podman solved some problems, created others :/
I am not sure the current approach to isolation is optimal.


Fixes post_service example by adding TLS

Introduces hyper-native-tls and adds a TLS client to the adapter, fixing
an "Invalid scheme for Http" error that was introduced by a breaking
change to hyper 0.10.0 (which no longer includes TLS out-of-the-box).

Oops! That was a mistake. I'll fix that and re-push.
On Tue, Sep 3, 2019, 13:01 Austin Bonander<EMAIL_ADDRESS>wrote:

@abonander commented on this pull request.
In examples/post_service.rs
https://github.com/abonander/anterofit/pull/18#discussion_r320404665:

@@ -67,10 +69,15 @@ unsizeable!(PostService);

fn main() {
// Navigate to this URL in your browser for details. Very useful test API.

let url = Url::parse("https://jsonplaceholder.typicode.com").unwrap();

let url = Url::parse("http://jsonplaceholder.typicode.com").unwrap();

Dropping the https seems redundant with adding NativeTlsClient.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/abonander/anterofit/pull/18?email_source=notifications&email_token=AAA4QS7OUYXHXH25YKNE7ATQH2RAJA5CNFSM4ITBCMS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDQMQAY#pullrequestreview-283166723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA4QS56KXHMOKKWN6BYA7TQH2RAJANCNFSM4ITBCMSQ
.


[i2c, dv] Add i2c_fifo_watermark test for rx_fifo and fmt_fifo

The main point of this test is to create specific stimuli in order to directly
trigger watermark interrupts which can be predictable and usable for DV

Add i2c_watermark_vseq to test fmt_fifo and rx_fifo watermark interrupt
Update test description which is provided in i2c_testplan.hjson
Update i2c_testplan.hjson to replace rx_fifo_watermark and
fmt_fifo_watermark tests by a unified fifo_watermark test
Update constraints in i2c_base_vseq
Update i2c_env_pkg and tb.sv to refect intr_trans_complete interrupt
Code clean

Signed-off-by: Hoang Tung<EMAIL_ADDRESS>

Update fifo_watermark to handle the case in which rx_watermark could be disabled (e.g. fifo_ctrl.rxilvl register is programmed to [5:7])


Builds fail on GCC 12+

Describe the bug
Builds fail on GCC 12+ (as is shipped with Fedora 36+) but not GCC 11.x (RHEL 9, Fedora <35).
On GCC 12+, builds fail with this error:
[ 57%] Building C object CMakeFiles/sysmon.dir/sysmonCommon/usage.c.o
[ 58%] Building C object CMakeFiles/sysmon.dir/sysmonCommon/parsecommandline.c.o
[ 59%] Building C object CMakeFiles/sysmon.dir/sysmonCommon/printSchema.c.o
[ 59%] Building CXX object CMakeFiles/sysmon.dir/sysmonCommon/xml.cpp.o
/tmp/SysmonForLinux/sysmonCommon/xml.cpp: In member function 'HRESULT RuleBuilder::AddData(PVOID, ULONG)':
/tmp/SysmonForLinux/sysmonCommon/xml.cpp:232:42: error: comparing the result of pointer addition '(((PBYTE)((RuleBuilder*)this)->RuleBuilder::blob) + ((sizetype)((RuleBuilder*)this)->RuleBuilder::blobSize))' and NULL [-Werror=address]
  232 |                 if( (PBYTE)blob+blobSize == 0 ) {
      |                     ~~~~~~~~~~~~~~~~~~~~~^~~~
cc1plus: all warnings being treated as errors
make[2]: *** [CMakeFiles/sysmon.dir/build.make:1018: CMakeFiles/sysmon.dir/sysmonCommon/xml.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:133: CMakeFiles/sysmon.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
Error: building at STEP "RUN LD_LIBRARY_PATH=/usr/local/lib make": while running runtime: exit status 2

To Reproduce
Dockerfile for a build that fails using Fedora 36, 37, 38 (shipping GCC 12+) but succeeds with Fedora 35 (shipping GCC 11.3.1). To reproduce and test across Fedora releases, just change the container tag in the first line:
FROM registry.fedoraproject.org/fedora:38 as buildbin

# Configure Sysmon Git tag here
ARG VER='<IP_ADDRESS>'

# Prereqs (ones I worked out)
RUN dnf install -y clang cmake g++ gcc git llvm mono-devel monodevelop-devel dotnet-sdk-6.0

# Prereqs (from Rocky 9 instructions at: https://github.com/Sysinternals/SysmonForLinux/blob/main/BUILD.md)
RUN dotnet tool install --global dotnet-t4 --version 2.3.1
RUN dnf install -y gcc gcc-c++ make cmake llvm clang elfutils-libelf-devel rpm-build json-glib-devel python3 libxml2-devel gtest-devel gmock gmock-devel glibc-devel.i686

# Clone SysinternalsEBPF source
RUN git clone https://github.com/Sysinternals/SysinternalsEBPF.git /tmp/SysinternalsEBPF
RUN mkdir /tmp/SysinternalsEBPF/build
WORKDIR /tmp/SysinternalsEBPF/build

# Build SysinternalsEBPF
RUN cmake ..
RUN make

# Install SysinternalsEBPF
RUN make install

# Clone SysmonForLinux source
RUN git clone --recurse-submodules --branch ${VER} https://github.com/Sysinternals/SysmonForLinux.git /tmp/SysmonForLinux
RUN mkdir /tmp/SysmonForLinux/build
WORKDIR /tmp/SysmonForLinux/build

# Build SysmonForLinux
RUN cmake ..
# (we need to specify LD_LIBRARY_PATH here so that the make process for Sysmon finds the .so we built and installed
# earlier for SysinternalsEBPF)
RUN LD_LIBRARY_PATH=/usr/local/lib make

Sysmon version
<IP_ADDRESS>
Distro/kernel version
Tested not working:

Fedora Rawhide (GCC 13.1.1)
Fedora 38 (GCC 13.0.1)
Fedora 37 (GCC 12.2.1)
Fedora 36 (GCC 12.0.1)

Tested working:

Fedora 35 (GCC 11.3.1)
Rocky 9 (GCC 11.3.1)

Additional context
I can't be sure this is definitely due to the change in GCC version but since that's specifically a compiler error that's where my suspicion lies. Seems like this is either down to the change in compiler version (or possibly some additional compiler hardening flags that were added in Fedora 36 onwards, but I can't find specific evidence of that with a cursory search).

Hi - thanks for reporting this. This should now be fixed.


Wrong namespace fix for symfony tests

The following directories structure is in accordance to current Symfony conventions:
.
└── tests
    └── Bar
        └── Foo.php

This is how namespace should be declared in Foo.php according to 2nd example in manual:
<?php

namespace Tests\Bar;

class Foo
{
}

Running php-cs-fixer fix --level=symfony . changes namespace casing which breaks some functionalities:
namespace tests\Bar;

@cprn
Are you using the PSR-0 fixer?
Noticed this problem a while ago when the PSR-0 fixer was still enabled by default.
Disabling it solved the problem.

Yeh, this issue can be safely closed. Your codebase is not PSR-0, so please don't run the PSR-0 fixer. I have written a PSR-4 for us (well, I say I wrote it, while my name is on the PR, the code is pretty similar to the PSR-0 fixer, so thanks to the original contributors ;D).

@GrahamCampbell @localheinz But shouldn't --level=symfony disable PSR-0 and make sure PSR-4 is enabled for me?

Yes, that's the case in 2.x. We can't change it in 1.x for BC reasons.

Closing due to discussion


add type hints to public functions #434

Hi! These changes should address #434. I kept the syntax compatible with Python 2 but didn't really keep py2 types in mind (it's deprecated after all).
The only way to formally test these changes would be to run mypy or pyright, but those will throw many errors until the whole library is actually typed, so I feel that this isn't practical for now.
Let me know if you see anything you would like changed!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good! Thanks for the contribution.


Update README.md

Corrected elastic ips link; previous returns 404

Thanks!

No worries! Happy to help!


Please review Apache Ignite Client

Guys,
I've created https://github.com/brianfrankcooper/YCSB/pull/1118 with Apache Ignite Client on 29th of March.
Could you please take a look at this PR?

hi!
At the moment all my YCSB time is going towards getting a 0.14.0 release out (#1117). Any help folks can provide in testing for that release will get me reviewing other contributions sooner.
That said, at the moment there are two different PRs for ignite support, #1118 and #1081. I've already started reviewing #1081 a few months ago, but it looks like things stalled out. It would substantially simplify the review process (and thus speed it up) if you and the author of that PR could come to a consensus on what should end up in YCSB.

Thanks for your response!
You suggested a great plan. I've written a comment in https://github.com/brianfrankcooper/YCSB/pull/1081.

@busbey
Please take a look at this comment https://github.com/brianfrankcooper/YCSB/pull/1081#issuecomment-394735216
Let's continue with https://github.com/brianfrankcooper/YCSB/pull/1118
How can help you with 0.14.0?

great to hear!
The 0.14.0 release tracking issue #1117 has a link to the current Release Candidate as well as a recent (as of yesterday) list of things left to be tested. From that list I think any additional datastore binding tests will be nice-to-have and the windows testing will be need-to-have.

@busbey I've finished work with the PR https://github.com/brianfrankcooper/YCSB/pull/1118. Please take a look.

thanks! I'll take a look later this coming weekend.

Great! Thanks!

@busbey did you have a chance to look at #1118? Maybe I can help you with current contribution testing?

Sadly not yet. Busy with the holiday week and day job. Should have time today or tomorrow.

Got it. Thank you!

thanks for your patience!