Improve Performance With Multithreaded Kill Unused Segments Task

Description
In KillUnusedSegmentsTask unused segments are deleted in serial. The proposal is to use an ExecutorService to kill the segments in parallel. A numThreads parameter will be added to the task spec with a default to 1 so that existing functionality is not changed. This parameter is also exposed in the URL parameters used by the UI, e.g. /coordinator/v1/datasources/wikipedia1?kill=true&interval=1000/3000&numThreads=10
A  fork and test results will be added here soon.
Motivation
In deployments with very large numbers of segments, deleting unused segments can be painfully slow. This is particularly noticeable in large HDFS deployments as each request to the cluster could be parallelized in a straightforward way. This was a client request and it would be nice to hear from others with similar issues.

Hi @kroeders thank you for raising the issue. Can you tell me what the benefits of using multiple threads are vs issuing multiple kill tasks? In Druid's indexing service, the resource allocated per task is abstracted as the task slot. Multiple task slots can be configured per middleManager and a task occupies one task slot when it is assigned to a middleManager. This model is to simplify resource control and management.

hi @jihoonson thank you for the feedback, I think this is the key design issue here. For some context, we run an internal fork of Druid where the users are in another team. From the user perspective they're regularly cleaning up stale data. At a high level the problem statement is that a logical kill operation (e.g. delete all traffic from the last day) leads to thousands of segments being deleted in serial which is visibly slow.
So, we could check the segment count and issue multiple kill tasks (specifying a batch size parameter instead of a thread count parameter) or even one task per segment. As a general rule I want to use existing concurrency features whenever possible, but if I understand Tasks properly they seem pretty heavyweight, being launched into other processes and visible in the ingestion window. I didn't want to end up in a degenerate case where there was one task per segment, so we looked at a more lightweight approach to speeding up this task. From a user perspective, parallelizing inside the task keeps the UI output in synch with the user input and uses minimal overhead
I'm new to both Druid and this team, but we have a pretty large existing cluster with HDFS deep storage. Delete should just be issuing a request to HDFS and a pretty lightweight operation for Druid when configured this way - local storage will be a different story.
I should have access to a dev cluster shortly where I can provide metrics and try different approaches.

I think the task slot model( a task per process) is too heavy.
Issuing multiple tasks simultaneously reaches the same goal as an executor service proposed here, but the problem of task slot is the number of task slots are fixed at the configuration file level. As the datasources grows, and the index task grows, there're less task slots left to do the compact or kill tasks. If we want to balance it, we have to enlarge the number of task slots and reboot the middle manager. This is the problem, if druid could provide a configuration center, to change the number of slots would not involve rebooting middle managers.
In this scenario, operators could breaks down the kill task by smaller intervals to utilize multiple task slots. But from the user's view, user should not care about how to utilize these task slots, they just want to that job finishes ASAP, so the break down should leave to druid. I think this is why this proposal is here.
Considering the task model here, maybe another viable way is the overlord breaks down the kill task into smaller tasks, each of which perform a kill in a smaller intervals.

@kroeders thanks for more context. Out of curiosity, does the auto kill feature of the coordinator not work for you (druid.coordinator.kill.on, https://druid.apache.org/docs/latest/configuration/index.html#coordinator-operation)? I'm wondering why you are issuing kill tasks manually.
@kroeders @FrankChen021 I believe the task slot model is better in terms of usability in those cases you mentioned. If we allow users a fine-grained resource control, such as explicitly setting cpu cores, number of threads, memory usage, disk I/O, etc per task, the operators should be responsible for managing the cluster resource and allocating it to each task efficiently. I don't believe this is ideal, it should be managed automatically by Druid.
I think it could probably be better if the kill task can employ multiple subtasks so that each of them can run in parallel on different middleManagers (or even in the same middleManager). This is more scalable and fits better to the current task resource management model. The missing part is resource scheduling, like how to allocate the cluster resource to tasks to maximize the ingestion performance while effectively performing cluster operation jobs such as compaction, cleaning up stale segments, etc. However, this should be an independent issue and discussed separately.

I opened https://github.com/apache/druid/issues/10002.

@jihoonson I agree with you, it's druid's responsibility to break down a large task into smaller tasks and schedule these tasks simultaneously.
One of what limits this idea is the static configuration of number of task slots. Can the numbers of subtasks plus the number of task being executed exceed the number of task slots ? If can't, what if there's only one task slot left at the time a large kill task is submitted? It involves many details.

One of what limits this idea is the static configuration of number of task slots. Can the numbers of subtasks plus the number of task being executed exceed the number of task slots ? If can't, what if there's only one task slot left at the time a large kill task is submitted? It involves many details.

It can't. All those problems should be addressed and handled properly by the resource scheduler. The current resource scheduler of Druid is FIFO-style, that is, the first issued task is executed before later tasks. We can improve this algorithm to also take task priority, task type, current available resource, etc into account.

@a2l007 @jihoonson   This is the problem I worry about. Number of task slot is fixed at configuration level. Currently, there's no way to enlarge the number of task slots without rebooting middle managers to take the new number in effect, which means tuning the number is not easy in production. And In order not to block the index tasks, a complicated algorithm is needed.
I think threading model is a simple enough way but without violating any current design principles.
Task slots provides a way to parallelize the task between middle managers, threading model provides a way to parallel the task inside a task. They're not conflict.

Hi again @a2l007 @jihoonson @FrankChen021 I got access to our staging cluster and put together a prototype and did some testing and so I wanted to share what I found.
The test cluster is reasonably large with some datasources in the TB range. I did tests up to around a few hundred GB and segments up to 500MB and did tests up to a few thousand segments per datasource. I did scaled down testing with local storage as well. I found that the delete times were very fast and for HDFS not proportional to segment size - which makes sense as an HDFS delete is a namenode operation. I saw an expected speedup running in parallel, but overall the deletes were very fast, around 10ms to delete a segment in our cluster.
In cases where there is more of a delay I saw the expected speedup, but I had to put an artificial delay to see an appreciable difference. I'm still investigating with users whether anyone is still experiencing the original issue, but it looks like changes at the HDFS layer have improved the situation dramatically.
Regarding the discussion about resource scheduling, I think that delete segments would be a different type than the parallel subtask for indexing. These deep storage tasks are delegating to another service so I think it makes sense to let them run in parallel, even for local storage cases.
For the kill task specifically, I also saw the discussion with problems related to a very large number of segments aside from accumulated deep storage delays. I noticed in the parallel indexing tasks, we still end up with task items in the ingestion UI. It would be pretty straightforward to set a threshold/batch size and just reissue independent kill tasks without introducing a new subtask framework. Maybe these are two general "dials" in a general resource management framework, number of segments per task and number of concurrent deep storage operations?
Jihoon, regarding your question on druid.coordinator.kill.on - I asked our users and they indicated kill tasks are issued manually primarily for policy reasons. Apparently, under certain situation there are rules regarding the retention of data so there are regular schedules for pulling and deleting data.

migrating over to the other issue


Update webcodecs support for Firefox desktop

WebCodecs are targeting Firefox 130 see https://bugzilla.mozilla.org/show_bug.cgi?id=1908572
Fx Android is not supported yet.

Confirmed, thanks!


dialect/sql/schema: fix no change condition in atlas

Closed with #2374, I added you as a co-author of the PR.


.jpg Update by List

Instead of going through every single .mp3 file trying to update it, just update either by a list of .mp3 files or a list of .jpg files.

update_img_tags function might now be useless


doc/go1.17: document go/parser changes for Go 1.17

+pkg go/parser, const SkipObjectResolution = 64                                                           +pkg go/parser, const SkipObjectResolution Mode
The SkipObjectResolution mode was added to allow skipping the object resolution phase of parsing.
CC @griesemer

This one also doesn't seem to have gone through the proposal process.  The issue discussing it is #45104.

Indeed. @griesemer and I did discuss making a proposal at the time, and thought it wasn't warranted. If you or anyone feels differently, I don't mind unexporting the API and waiting for 1.18.

Agreed. This is a just an additional mode, and nothing will break if the mode is ignored.

This is not directly needed for generics. As a side-effect of the refactoring I was doing anyway, this optimization, which is desirable for some users, became trivial.
We can unexport this mode value and make a proposal for 1.18. Users can experiment with it in 1.17 by copying the mode value into their project.

It's OK to make it a proposal for 1.17 if you like.  I don't think it would take long to approve.  Thanks.

Thanks, I've filed #46485 for the proposal. If the discussion there is one-sided we can perhaps get it in for 1.17, but I don't want to rush it.
For now I'll un-export the new mode to close this release blocker.

I discussed this issue with @golang/release today, and consensus was that it can be marked okay-after-beta-1. Reverting the mode is trivial and safe if #46485 is not approved.  Leaving the mode in the release for now allows users to more easily experiment with it.
Depending on the outcome of the proposal, I will either document or revert this mode in ~2 weeks.


Unable to connect Sparrow to electrs via local connection or Tor

Describe the issue
Stuck trying to connect Sparrow desktop wallet to electrs (https://raspibolt.org/guide/bitcoin/desktop-wallet.html#connect-to-electrs).
bitcoind, electrs, and nginx are running without errors. Indexing completed.
error when trying to connect via local connection:
"Could not connect:
Retries exhausted"
error when trying to connect via Tor:
"Could not connect:
SOCKS: Host unreachable. Check if the proxy server is running."
I tried the troubleshooting in the guide, making sure my computer is not connected to any “guest" network, and deleting the existing certificates that are stored within the certs folder. But, still unable to connect.
Location in guide
(https://raspibolt.org/guide/bitcoin/desktop-wallet.html#connect-to-electrs)
Environment

Raspberry Pi 4 B
Operating system: Raspberry Pi OS 64bit
Version: Debian GNU/Linux 11 (bullseye)

I set log_filters = "DEBUG" in electrs.conf, restarted the service.
running "sudo journalctl -f -u electrs" while trying to connect:
May 01 16:52:51 raspi electrs[1770]: [2023-05-01T23:52:51.809Z ERROR electrs::server] 6: disconnecting due to failed to send response: "{"id":3,"jsonrpc":"2.0","result":{"height":782590,"hex":"0000c020fd4b4b7c34983310f187a14106292c288660df6dbd8e020000000000000000007396eb361ae715d6069048e77e752740930887cef866c21aa003c9be76e2c9a8f01a20643e020617413ea70a"}}\n"
May 01 16:52:51 raspi electrs[1770]: [2023-05-01T23:52:51.809Z WARN  electrs::server] 6: failed to shutdown TCP connection Transport endpoint is not connected (os error 107)
running "sudo journalctl -f -u electrs | grep :server" while trying to connect:
May 01 16:49:55 raspi electrs[1770]: [2023-05-01T23:49:55.828Z ERROR electrs::server] 5: disconnecting due to failed to send response: "{"id":3,"jsonrpc":"2.0","result":{"height":780590,"hex":"00805320795ae2eb6a52f8cf757469b182d31eb850ed1c64153d01000000000000000000f9a40be591ef086d82ffe2740567ff2c2fe69df179cb185de37c558f0236145dabdb0e6481760617400620d6"}}\n"
May 01 16:49:55 raspi electrs[1770]: [2023-05-01T23:49:55.828Z WARN  electrs::server] 5: failed to shutdown TCP connection Transport endpoint is not connected (os error 107)

And you checked that the elctrs port is enabled in ufw?
Although it should work with tor anyway..

Try connecting with Electrum. Electrum worked for me, but I had intermittent issues with Sparrow for some reasons.
That's why I decided to move to Fulcrum.

Strange, for me its working, i also tested it with the newest sparrow version again..

@zynos yes I double checked this step:
$ sudo ufw allow 50002/tcp comment 'allow Electrum SSL'
@dutu I tried connecting with Electrum as well, same problem.

What is your version of BTC Core? Mine is 23.
You can also have a look here:
https://community.getumbrel.com/t/sparrow-wallet-desktop/6898/24

@zynos v24.0.1, I tried switching to 23.1 but had the same issue, so I switched back to 24.0.1 again.
I tried running the RaspiBolt System Overview and it gets stuck at loading Electrum Server Data

Running sudo journalctl -f -u electrs | grep :server with the log_filters = "DEBUG" in electrs.conf file while trying to connect using Sparrow shows this:

On the Sparrow side:

Any ideas what could be causing this? Seems to me like it's an issue with my electrs.

It might be because my compaction isn't complete in electrs. I'll try again once that's done.

Okay yeah that was the problem. I feel stupid, but hope this helps someone running into the same issue. Once electrs finished compacting it worked.


Fixed wrong Fibonacci Tester

Fibonacci series starts with 0, but the testing method was working with 1 as the starting number of the series, thus causing issues with the tests.

OK!


<EMAIL_ADDRESS>has incorrect peer dependency "webpack@2 | 3 | 4".

Getting:
warning " ><EMAIL_ADDRESS>has incorrect peer dependency "webpack@2 | 3 | 4".

But I already have:
$ cat node_modules/webpack/package.json | grep version
  "version": "4.6.0",

Great work btw.

Hey @damianobarbati , thanks!
Need to check this 👍


Parameter names

In DuckDB when you set a query parameter name, all other providers I use (SQLite, SQL Server, Oracle, MySQL, etc.) are forgiving if you include the SQL prefix when defining the parameters (e.g., you can pass $PARM1 as the parameter name) and it works OK, however DuckDB requires that the name exclude the prefix (e.g., PARM1).

Can you send a PR for this if you have fixed it as you mentioned in another issue?

Actually I did not fix the DuckDB code, I just modified my code to conform to DDB expectations.

From: Giorgi Dalakishvili @.>
Sent: Monday, June 24, 2024 3:43:39 PM
To: Giorgi/DuckDB.NET @.>
Cc: Chris Wilson @.>; Author @.>
Subject: Re: [Giorgi/DuckDB.NET] Parameter names (Issue #203)
Can you send a PR for this if you have fixed it as you mentioned in another issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/Giorgi/DuckDB.NET/issues/203#issuecomment-2187460731, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFIQZM3SRWRAYX4CBQLQF6DZJCHIXAVCNFSM6AAAAABJ2HRF46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGQ3DANZTGE.
You are receiving this because you authored the thread.Message ID: @.***>


Translation for the cardHolderNameRequired not working as expected

I would like to thank you for working on this productive library!
I have faced an issue while using it though that I would like you to look into and give it a fix:
CURRENT BEHAVIOR
I have the following translation object passed to the credit card form component:
<CreditCardForm
          LottieView={LottieView}
          horizontalStart
          overrides={{
            labelText: {
              marginTop: 16
            }
          }}
          translations={{
            cardNumber: 'Numéro de Carte',
            cardHolderName: 'Titulaire de Carte',
            nameSurname: 'Nom et Prénom',
            mmYY: 'MM/AA',
            expiration: 'Expiration',
            securityCode: 'Code de Sécurité',
            next: 'Suivant',
            done: 'Terminer',
            cardNumberRequired: 'Numéro de Carte est obligatoire.',
            cardNumberInvalid: 'Ce numéro de carte est invalide.',
            cardHolderNameRequired: 'Nom de titulaire de la carte est obligatoire.',
            cardHolderNameInvalid: 'Ce nom de titulaire de la carte est invalide.',
            expirationRequired: "Date d'Expiration est obligatoire",
            expirationInvalid: "Cette date d'expiration est invalide.",

            securityCodeRequired: 'Code de Sécurité est obligatoire.',
            securityCodeInvalid: 'Ce code de Sécurité est invalide.'
          }}
        />

Every field gets translated as expected except the cardHolderNameRequired which displays the cardNumberRequired instead of its own value.
So, I attempt to skip the card number, they tell me that the card number is required. And I provide it, but when I reach the cardholder's name and attempt the skip, they tell me that the cardholder number is required instead of telling me that the cardholder's name is required. That affects the user experience because it confuses the user.
EXPECTED BEHAVIOR
The right corresponding validation message of the cardholder's name should be displayed instead of the incorrect one.

Thanks for logging the issue @placideirandora! It appears I've made a mistake on this line: https://github.com/halilb/rn-credit-card/blob/9528e26df3cda48a23a7f45a1dbcad2e7b7e652b/src/components/CreditCardForm.tsx#L150
This looks like a great first issue. Would you like to fix that and open a PR? I'd gladly merge that. Or I can make the change and test it sometime later this week.

Thanks for recognizing the issue. So, I can make a fix and raise a PR since a minor change and I have time! Let me know if there a documentation to refer to before any contribution. @halilb

Thanks for recognizing the issue. So, I can make a fix and raise a PR since a minor change and I have time! Let me know if there a documentation to refer to before any contribution. @halilb

I'm afraid there is no contribution guideline but this should be pretty straightforward as it's a small change. Please let me know if anything goes wrong.

Sure. This will be straightforward. I will keep you posted.

Thanks for recognizing the issue. So, I can make a fix and raise a PR since a minor change and I have time! Let me know if there a documentation to refer to before any contribution. @halilb

I'm afraid there is no contribution guideline but this should be pretty straightforward as it's a small change. Please let me know if anything goes wrong.

I have raised a PR that fixes the issue. You will review it and give it a merge and any feedback for what's not right.

Just merged it and published version 1.0.2. Thanks again @placideirandora!


Power sensor provides power measurement not ON/OFF

A power sensor returns de amount of power being measured and not a state of ON/OFF (that would be a power switch).

What's wrong with template binary sensors?

It would take an extra HA entity to fit this use case
This is a functionality that used to exist in the "old" component


Experience Event data limits

Issue in ./help/profile/guardrails.md
These guardrails seem to outline the profile record data limits. But no mention is made of experience event limits or guardrails.
For example the docs says there is a 1mb limit on profile size. But the number of experience events for a profile far exceeds 1mb.

Tracking in https://jira.corp.adobe.com/browse/PLAT-84329

The guardrails documentation has been updated to better address these limits: https://experienceleague.adobe.com/docs/experience-platform/profile/guardrails.html?lang=en


Add Dockerfile and instructions

@JGulbronson the update to ConfigModule.kt is to allow for reading the YAML file from inside a JAR.

Hit merge for you @maniksurtani to avoid any more merge conflicts.


Fix accumulation of passes rendering percentage

 --- beginning rendering pass 1 ---
 rendering, 25.0% done
 rendering, 50.0% done
 rendering, 75.0% done
 rendering, 100.0% done
 wrote checkpoint for pass 1.
 --- beginning rendering pass 2 ---
 rendering, 125.0% done
 rendering, 150.0% done
 rendering, 175.0% done
 rendering, 200.0% done
 wrote checkpoint for pass 2.
 --- beginning rendering pass 3 ---
 rendering, 225.0% done
 rendering, 250.0% done
 rendering, 275.0% done
 rendering, 300.0% done
 wrote checkpoint for pass 3.
 --- beginning rendering pass 4 ---
 rendering, 325.0% done
 rendering, 350.0% done
 rendering, 375.0% done
 rendering, 400.0% done
 wrote checkpoint for pass 4.
 --- beginning rendering pass 5 ---
 rendering, 425.0% done
 rendering, 450.0% done
 rendering, 475.0% done
 rendering, 500.0% done
 wrote checkpoint for pass 5.
 --- beginning rendering pass 6 ---
 rendering, 525.0% done
 rendering, 550.0% done
 rendering, 575.0% done

It should be between 0 and 100%.

Duplicate of #864.


feat(mocha-framework): Move mocha test framework to seperate package

Move mocha test framework to its seperate package. This should prevent confusion about the state of the mocha test framework plugin. It only works with the stryker-mocha-runner test runner plugin at the moment, so it will downgrade coverageAnalysis: 'perTest' to coverageAnalysis: 'all' when another test runner is used.
BREAKING CHANGE: Users with testRunner: "mocha",testFramework: "mocha" should now also install "stryker-mocha-framework".

I don't know why travis is not cooperating. I'll open a new PR.


Errors

I spent today evaluating options for error reporting. I came up with a custom SubstancError class.
var Err = require('substance/util/Error');

throw new Error('DocumentStore.CreateError', {
  message: 'Could not create document. '+ documentId +' already exists',
  info: 'some additional context info can go here'
});

message and info are optional. So in many cases we will just throw new Error('MyClass.WhatHappened').
Now we will use DocumentStore.CreateError will be used as the error name. So we will see messages like "Uncaught DocumentStore.CreateError: Could not create document. 'foo' already exists.". We can use the custom error name to map it via i18n. However we should on each layer introduce custom errors, so implementation details are not exposed to the client.
Let's look at the next layer, and an example where we take an error triggered by a low-level API and wrap it in a new custom error object.
  this.deleteDocument = function(documentId, cb) {
    this.documentStore.deleteDocument(documentId, function(err, doc) {
      if (err) {
        return cb(new Err('DocumentEngine.DeleteDocumentError', {
          cause: err
        }));
        cb(null, doc);
      }
    });
  };

The SubstanceError constructor takes a cause option, which can hold the error that caused the error thrown/emitted. That's a nice thing as we still have access to the original stacktrace and SubstanceError.toString will print both error messages for a better context.
Here are some files that use the new API already:
Callback API's: https://github.com/substance/substance/blob/master/collab/DocumentStore.js
Promise API's: https://github.com/substance/notes/blob/master/server/UserStore.js#L70-L77
We can use those more specific errors for testing known error scenarios.
https://github.com/substance/notes/blob/master/test/server/UserStore.test.js#L57-L64
Let me know what you think.

Let's try!

That's done.


fix violations of Sonarqube rule java:S2184

Hello,
This PR fixes 8 violations of Sonarqube Rule java:S2184 : 'Math operands should be cast before assignment'.
For more details, please see
MITRE, CWE-190 - Integer Overflow or Wraparound
CERT, NUM50-J.- Convert integers to floating point for floating-point operations
CERT, INT18-C. - Evaluate integer expressions in a larger size before comparing or assigning to that size
The patch was automatically generated using the ViolationFixer tool.

I can't see the point of changing. These values would not be able to overflow.


validate_install error

When run python scripts/validate_install.py：
PermissionError: [Errno 13] Permission denied: '/tmp/tmp13yl3329/Minecraft/launchClient.sh'
How can I solve this problem?

same problem here

Try using sudo(?) or just using chomd to change the permission

Did anyone manage to fix it? I am really struggling with this right now.

Did anyone manage to fix it? I am really struggling with this right now.

don't use pip install -e .   just pip install minedojo.  Maybe it can help.

I encountered the same problem.
Is this still unsolved?


'Generate MSRV Badge ' workflow times out

The 'Generate MSRV Badge' has been timing out systematically since the last release.

I'll look into this. Looking into cargo-msrv, it looks like the --bisect search isn't as thoroughly tested, so I wonder if that's causing the timeout. A linear search is theoretically slower, though (but neither should be 6+ hours IMO).

Yeah, just tried both default behavior and --bisect with cargo msrv on onefetch and it seemed to hang up on Rust 1.42.0 for some reason. I'll update this to just be linear.
The linear search actually isn't much of a time loss either, considering that onefetch targets a fairly high Rust version.


chore(ci): add informational Codecov status checks

Hi, Tom from Codecov here. I noticed that you were using Codecov but weren't actually getting any notifications on pull requests. I figured it would be useful to get some idea if code being changed is being tested, but also not blocking CI/merging. Let me know if this makes sense or if we can do something that would be helpful.

thanks, but we deliberately turned those off, as we find them a bit too noisy. We prefer to manually check the codecov website from time to time.

ok I said we, but should have probably said I. If other fonttools devs think otherwise, feel free to reopen this.

@thomasrockhu-codecov what I find noisy is the email notification which distracts the conversation. If there's a way to see some status/check in the PR page without also getting the email notification I'd be in favour of this.

I find codecov an utter nuisance, and I agree with closing.

@anthrotype that makes sense! I don't think the status check sends any email notifications, but the comment does (this is a GitHub restriction).
Right now the reason the status check isn't popping up on this PR is that the GitHub app isn't installed.
@justvanrossum if you have the time, do you mind talking about that more? Is this generally a problem with our product that we can fix?

@thomasrockhu-codecov so do you confirm this PR will not trigger any additional comments from the codecov bot with accompanying email notifications, but only an informational (non-blocking) status check?

@thomasrockhu-codecov I just did that, care to try? thanks


Remove node 6 from matrix and reenable engine checks

Completes work from #55 and #52.
Node v6 was marked as no longer supported by a downstream dependency, removing it from the build matrix also removes it from official support for this project, and negates the need for the --ignore-engines flag when executing yarn install.

@mcataford I've rebased your PR against master. I'm going to merge before April ends.
Thank you for contributing 👏 !


BUG: No window is displayed if minimum or maximum bounds is set on windows width and height on macOS

What OS are you using (uname -a, or Windows version)?
macOS Mojave 10.14.6, Apple clang version 11.0.0 (clang-1<IP_ADDRESS>), Target: x86_64-apple-darwin18.7.0
What programming language are you using (C/C++/Go/Rust)?
C with GCC - Apple clang version 11.0.0 (clang-1<IP_ADDRESS>).
What did you expect to see and what you saw instead?
I compiled and ran webview_c.
Expected
Be able to set the minimum and and maximum window size using WEBVIEW_HINT_MIN and WEBVIEW_HINT_MAX
Issue
No window is displayed at all when WEBVIEW_HINT_MIN and WEBVIEW_HINT_MAX is passed to webview_set_size
Notes

No errors on compilation.
WEBVIEW_HINT_NONE and WEBVIEW_HINT_FIXED work as expected.

Maybe I have the same problem in Windows.
After building and running, nothing shows up.
BTW I ...
0. run Windows 11

installed conform https://webview.dev instructions:

Windows SDK via Visual Studio Installer
C++ support via Visual Studio Installer

installed conform https://github.com/webview/webview instructions:

TDM-GCC from http://tdm-gcc.tdragon.net/download

executed (because I got errors from the loader):
<EMAIL_ADDRESS>used the program source mentioned below "Getting started:  on:
https://github.com/webview/webview
build the exec using this command:
go build -ldflags="-H windowsgui" -o senv.exe
as instructed on:
https://github.com/webview/webview

@thewebdev, did you specify both WEBVIEW_HINT_MIN and  WEBVIEW_HINT_MAX in the same call to webview_set_size or did you call the function multiple times? Can you show an example?

webview_t w = webview_create(0, NULL);
webview_set_title(w, "Webview Example");
webview_set_size(w, 480, 320, WEBVIEW_HINT_MAX);
webview_bind(w, "sayHello", myFunc, NULL);
webview_set_html(w, "<title>WebView</title><button onclick='sayHello(\"Hello World\")'>Click Me</button>");
webview_run(w);
webview_destroy(w);
return 0;

You must to set the window's default size, using WEBVIEW_HINT_NONE before/after setting the max or min size.
Example (cpp):
int main() {
    webview::webview w = webview::webview(true , nullptr);
    w.set_title("hello W");
    w.set_size(400, 500, WEBVIEW_HINT_NONE);
    w.set_size(300, 500, WEBVIEW_HINT_MIN);
    w.set_html(getHTML());
    w.run();
}


[BUG] Document Stores - Confluence: "Please fill in mandatory fields."

Describe the bug
When trying to save a Confluence Document Store Loader the application says
"Please fill in mandatory fields."
even if all mandatory fields are set.
To Reproduce
Steps to reproduce the behavior:

Go to Document Stores
Click on a newly created Store
Click on Add Document Loader
Click on Confluence
Fill in all mandatory fields
See error

Expected behavior
Expect to work :)
Screenshots

Flow
If applicable, add exported flow in order to help replicating the problem.
Setup

Installation: docker
Flowise Version: 1.7.1
OS:  Linux
Browser: Chrome

should be fixed in this PR, will push new version shortly

should be fixed in latest v1.7.2, please try redeploy/pull the latest changes again


Sensor Support missing or not working (Camera, gyro, accelerator, ....)

I have Games that use the Gyroscope and i cant play them. Also Camera is not working for me. (Surface Pro 8)

I haven't played with this firsthand, but if it's usb this may work for you? https://devblogs.microsoft.com/commandline/connecting-usb-devices-to-wsl/


Snippet / Modeladmin / settings forms should use validation_error helper

See #3440, which introduces a new validation_error helper to ensure that validation errors on the page edit form - both field-specific, and non-field errors - are displayed appropriately. After this is merged, we should update the other admin views that work with user-defined forms so that they're also using this helper:

snippets
ModelAdmin
wagtail.contrib.settings

As part of this task, we should make sure that validation error handling is covered by unit tests - i.e. for each of these modules, there should be at least one test similar to https://github.com/wagtail/wagtail/pull/3440/files#diff-509186d17133395aafeb7c62930e9881R3964 which posts an invalid form and confirms that the form is redisplayed with the expected error message included. (There's no need to go through all permutations of field and non-field errors, since that's already covered by #3440.)

Hi @gasman, do you know if the solution implemented for pages / proposed here will surface non-field errors from InlinePanel instances too?

@ababic I suspect it won't... ClusterForm.is_valid recursively checks the is_valid of the associated formsets, so it will at least recognise that validation has failed. However, to actually report the errors we'd have to make the errors dict of the child forms/formsets bubble up to the top level (or alternatively, have the validation_error helper dig in to form.formsets['foo'].errors, but that seems like a bad idea - validation_error should ideally not have any special case logic for ClusterForm, and certainly shouldn't have to interface with it at such a low level).
I guess the correct behaviour for "how should errors in child formsets be surfaced in form.errors" has never been defined - Django doesn't have an answer to that, because child formsets are a modelcluster-specific concept - so that would be the first thing to address. Two possibilities spring to mind:

extend the error dict object to have a CHILD_FORM_ERRORS property alongside NON_FIELD_ERRORS and the per-field keys, something like:
  event_form.errors = {
      'title': ["This field is required"],
      'NON_FIELD_ERRORS': ["End date must be after start date"],
      'CHILD_FORM_ERRORS': {
          'speakers': {
              0: {'NON_FIELD_ERRORS': "Speaker must agree to the T+Cs"}
          }
  }

treat formsets as equivalent to fields of the top-level form (since that's basically what happens when accessing the ClusterForm object itself) - this way we're not customising the error dict API, so any existing code that talks to the error dict (e.g. the validation_error helper) will continue to just work:
  event_form.errors = {
      'title': ["This field is required"],
      'NON_FIELD_ERRORS': ["End date must be after start date"],
      'speakers': ["Speaker must agree to the T+Cs"],
  }

I'm not sure what we do about field errors within the child forms (e.g. "Speaker name is required"), though...

Thanks @gasman for the full and prompt reply. Having reviewed the changes in #3440 more fully, and considering the above, I have a few thoughts.
Do child form errors need to be surfaced so fully in validation_error for the parent? I feel like it could be enough to render a generic error message about child form errors at the parent level, such as:
One/two/three/several speakers are not valid
Then each child form would have it's own validation_error to combine / display errors for that form in the same fashion as the parent.
Structurally,  I suppose the parent form error structure could look something like:
   event_form.errors = {
      'title': ["This field is required"],
      'NON_FIELD_ERRORS': ["End date must be after start date"],
      'CHILD_FORM_ERRORS':  {
          'speakers': [0, 2, 5]   # indexes of invalid child forms / fieldsets,
      }

This does feel like we're making a special case for ClusterForm, but I think that's only because a ClusterForm / InlinePanel combination is currently the only way in wagtail to define interfaces that suit related objects being defined together in such a way. But, that is really only a limitation for the time being. Conceptually speaking, any form should be able to have children forms (even children), so having a validation_error implementation to support that consistently makes sense.

@ababic Good point - I think we only need a generic message in the top-level validation_error, since the more specific error can be shown inline on the child object. (In the case of a NON_FIELD_ERROR on the child object this probably needs some new code, but that's doable.) In that case, do we really need any special-casing on the top-level error dict? It seems to me that we can just say:
event_form.errors = {
  'title': ["This field is required"],
  'speakers': ["Three speakers are not valid"],
  'NON_FIELD_ERRORS': ["End date must be after start date"],

}

Thanks @gasman. I do like the simplicity of that. However, mixing them in with bona-fide Field errors  doesn't feel as pythonic to me. I imagined validation_error would do the string representation bit, but the error dict itself could provide something more useful (For example, it would be possible to create a custom validation_error that contained same-page anchor links to the invalid children)

I feel I may have been a little vague above. To clarify, when I said:

However, mixing them in with bona-fide Field errors doesn't feel very pythonic to me

What I meant was, I feel like errors is really data for developers, so distinguishing between different types of errors there provides fuller picture of what is happening, and reduces ambiguity about where the values came from. validation_error exists to render consistently formatted errors for end users, so to me, that feels like a more natural place to generate the "Three speakers are not valid" string.


Compatible version of Stheno?

I've been trying to move some intensive neural process work from python to julia, but this package doesn't seem to support the latest version of Stheno's kernel functions (i.e. Matern52 no longer exists, in favor of using Matern52Kernel).
I'd like to get some of the examples of this package working, and was curious what version of Stheno was used in the given examples? Additionally, are there plans to update the package to work with the latest version of the dependencies?
Thanks for all your work!

Hey @nmearl! I'm afraid that this package hasn't had any updates in a long while, so unfortunately it still depends on some very old versions on some of its dependencies.
I believe that the version of Stheno used in the package was a version when it still shipped its own kernel functions instead of relying on KernelFunctions.jl. Unfortunately and very frustratingly, I don't have anything that points to the precise version anymore...
There are more dependency issues. For example, the package also still relies on Tracker.jl rather than using a more recent AD like Zygote.
It would be great of update all of these dependencies. However, I unfortunately don't have the bandwidth right now to this on. :( (We are working on a Python version of the package, which, contrary to this package, is in active development, though that may not suit your needs as you're looking to move away from Python.)
If you're still intending on trying to get some of the examples working, I think the easiest way forward may be simply upgrading to the latest version of Stheno, as the package only depends on a few features of Stheno which should be easily upgraded. Upgrading from Tracker to Zygote, however, will be a substantial amount of work, so I would recommed going with Tracker.


How to use applicationinsights when processing EventHubs messages?

I have a stack which works like this:

Python function app 1 sends messages to EventHubs
Node.js function app 2 gets triggered for batches messages from EventHubs

I want to achieve distributed log correlation via the operation_id field.
What seems to work:
The Python function app, I assume, correctly sends tracing data to EventHubs. I assume tracing data is attached correctly because I can see a link between the Python function app and the EventHubs instance in the Azure portal, in the Application Insights Application Map. Moreover, if I inspect the context received by the Node.js function app, I can tracing information in this field: context.bindingData.propertiesArray[<index>]["Diagnostic-Id"] . For each message in the payload, there will be a corresponding Diagnostic-Id here. Diagnostic-ID's look like this: "00-60de00e3807c0132a958f6cddd015503-ce57ff6768dcc932-01". The value 60de00e3807c0132a958f6cddd015503 is the value of the operation_Id field for the log entry emitted by the Python function app.
What I want to do:
When processing each of those messages in the batch, if an error is encountered, I want to log a message which will have the same operation_Id as the log messages emitted by the Python function app which pushed that particular message to EventHubs.
What I tried:
// eventhub-nodef1/index.js
// This is the EventHubs trigger handler
const instrumentationKey ='aaaaaaaa-aaaa-4444-aaaa-aaaaaaaaaaaa';

const appInsights = require('applicationinsights');
appInsights
    .setup(instrumentationKey)
    .setDistributedTracingMode(appInsights.DistributedTracingModes.AI_AND_W3C)
    .setAutoCollectPerformance(false);

appInsights.defaultClient.config.samplingPercentage = 100;

appInsights.start();

const {addEventHubDistributedTracingContext} = require('../poc-common/Common')

const FUNC_NAME = 'poc9-node-trigger';

const theEventhubsTriggerFunc = async function (context, eventHubMessages) {
    let ai = appInsights;
    // I don't expect to be able to correlate the messages logged here
    context.log(`${FUNC_NAME} called for message array ${JSON.stringify(eventHubMessages)}`);
    context.log(`${FUNC_NAME} called with context ${JSON.stringify(context)}`)

    eventHubMessages.forEach(
        (message, index) =>
            addEventHubDistributedTracingContext(context, appInsights, index,
                () => {
                    // but I DO EXPECT to be able to correlate these logged messages
                    context.log(`${FUNC_NAME} processing ${JSON.stringify(message)}`);
                    if (message && message.fail) {
                        context.log(`${FUNC_NAME}: failing because the message was: ${message}`)
                        throw new Error(`${FUNC_NAME} Life's too short to always succeed, ${message.name}`)
                    }
                }
            )
    )
};
module.exports = theEventhubsTriggerFunc

And this is the code for addEventHubDistributedTracingContext
function addEventHubDistributedTracingContext(context, appInsights, msgIndex, callback){
    const diagnosticId = context.bindingData.propertiesArray[msgIndex]['Diagnostic-Id'];
    const diagnosticIdComponents = diagnosticId.split('-');
    const longId = diagnosticIdComponents[1];
    const shortId = diagnosticIdComponents[2];
    const tinyId = diagnosticIdComponents[3];

    // the context for an EventHubs trigger doesn't look like the one for an HTTP trigger
    // I tried to create a fake context, with data from the Diagnostic-ID field, filling in for tracing data that an HTTP trigger would have
    // ...so tried like this and it didn't seem to work
    const spanContextAdapter = {
        traceId: longId,
        spanId: shortId,
        tracestate: tinyId,
    }
    // and also like this and it also didn't seem to work
    const traceparentContextAdapter = {
        traceContext: {
            traceparent: diagnosticId,
            tracestate: shortId,
        }
    }

    // const adapterContext = spanContextAdapter;
    const adapterContext = traceparentContextAdapter;
    const correlationContext = appInsights.startOperation(adapterContext, 'request-string-dunno-hope-it-worx');

    return appInsights.wrapWithCorrelationContext(
        callback,
        correlationContext
    )();
}

Here's my host.json
{
  "version": "2.0",
  "logging": {
    "applicationInsights": {
      "samplingSettings": {
        "isEnabled": true,
        "excludedTypes": "Request"
      }
    }
  },
  "extensionBundle": {
    "id": "Microsoft.Azure.Functions.ExtensionBundle",
    "version": "[1.*, 2.0.0)"
  }
}

Any my function.json
{
  "bindings": [
    {
      "type": "eventHubTrigger",
      "name": "eventHubMessages",
      "direction": "in",
      "eventHubName": "poc9-eventhub",
      "connection": "some_connection_name",
      "cardinality": "many",
      "consumerGroup": "$Default"
    }
  ]
}

What happens is that when logging, I just get new tracing information, with a new operation_Id.
So any ideas of what I'm missing? (FYI, javascript is not my main language, please be kind :P )
Thanks a lot :) ^^

@vladiibine are you using Open Census SDK in Python side?, if you do correlation would be handled automatically in Azure Functions and you can just add code to handle it we have in readme, I'm not seeing the code where Application Insights Node.js SDK is actually sending the telemetry in the code you shared, can you check SDK version property in your query?, just want to be sure the telemetry you are comparing is coming from this SDK and not .NET SDK, I would expect some appInsights track calls here, I believe context.log will end as a trace in .NET SDK


eta setting for different models/datasets

Hi Hanting Chen,
Could you show the used hyper-parameters eta for {resnet20, resnet50} on {cifar10, cifar100, imagenet}, respectively? is there any suggestions for setting this value?

eta is set as 0.2 by linear search for 0.01-10.


Bump version to 1.0.6

Remove 27.2 from test matrix

@psibi does this mean pull requests removing code targeting unsupported versions are welcome?
https://github.com/rust-lang/rust-mode/blob/master/rust-rustfmt.el#L68

@psibi does this mean pull requests removing code targeting unsupported versions are welcome?

It is welcome. Even better if someone is able to fix the CI issue that is happening with 27.2.

What was the issue? It seems the logs have been deleted
https://github.com/rust-lang/rust-mode/actions/runs/9155379317/job/25167625954

Some issue related to nix installation of that specific Emacs.
On Sat, 31 Aug 2024, 11:09 am Javier Olaechea, @.***>
wrote:

What was the issue? It seems the logs have been deleted
https://github.com/rust-lang/rust-mode/actions/runs/9155379317/job/25167625954
—
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rust-mode/pull/552#issuecomment-2322783027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFUBRK4HTBZTPRH3WZESADZUFJJ5AVCNFSM6AAAAABM5FXMNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSG44DGMBSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


made ascii string encoding faster

In local testing this made the StandardMessageCodec_string benchmark go from 0.51338 µs to 0.34857µs (33% decrease).
Don't land before https://github.com/flutter/flutter/pull/101767
Test coverage already exists, this is just a performance change.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Dart also provides Utf8Encoder.startChunkedConversion, which sends each chunk of UTF-8 byte data to a sink interface without doing a memcpy.
However, that probably won't work for StandardMessageCodec because StandardMessageCodec's output format writes the length of the UTF-8 string before the string data.  So there is no way to avoid accumulating all the data into an intermediate buffer before writing it to StandardMessageCodec's output stream.

In theory you could arrange things such that we accumulate the utf8 bits after leaving a spot for a length, while measuring the length, then go back and write it in.

In theory you could arrange things such that we accumulate the utf8 bits after leaving a spot for a length, while measuring the length, then go back and write it in.

We are using variable width sizes so you can't know how much space to reserve, except you could probably just choose the max size (5 bytes).  You'd have to double check that the decoders would support that.


locateOnScreen flickery on Ubuntu

locating an image on screen caused a serious annoying screen flickering on Ubuntu. I understand it's intended visual effect emulating taking a snapshot. How to disable that?

That looks to be a Gnome setting as discussed here.
Try running this:
gsettings set org.gnome.gnome-screenshot flash false

Conversely, you can use Gnome Tweaks:
sudo apt install -y gnome-tweaks
# GNOME Tweaks > Keyboard & Mouse > Screenshots > Flash screen


Add KDE-based outlier detection.

All Submissions Basics:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you checked all Issues to tie the PR to a specific one?

New Model Submissions:

[x] Have you created a .py in ~/pyod/models/?
[x] Have you created a _example.py in ~/examples/?
[x] Have you created a test_.py in ~/pyod/test/?
[x] Have you lint your code locally prior to submission?

This PR implements Kernel Density Estimaion (KDE) for unsupervised outlier detection.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

119 of 121 (98.35%)  changed or added relevant lines in 2 files are covered.
20 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.005%) to 95.931%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyod/models/kde.py
30
31
96.77%

pyod/test/test_kde.py
89
90
98.89%

Files with Coverage Reduction
New Missed Lines
%

pyod/test/test_mad.py
1
99.36%

pyod/models/cd.py
2
90.0%

pyod/models/ecod.py
3
88.0%

pyod/models/lof.py
5
87.18%

pyod/utils/data.py
9
95.11%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
6908

Relevant Lines:
7201

💛  - Coveralls

this appears to be great. thank you! I will merge it and make necessary changes for documentation. thanks again.


Instructions for data2text-macro-plan-py

Hi @ratishsp,
Thanks for providing the code for your paper. I am trying to learn more about this method and run the code, but I do not see many instructions like the other repos such as https://github.com/ratishsp/data2text-plan-py.
I just wonder how can I run the inference pipeline?
I can see the structure is quite similar with https://github.com/ratishsp/data2text-plan-py.
So if I want to run the code, shall I follow the same instructions?
Many thanks

Hi Tong,
Thanks for the interest in the project.
The code structure is indeed similar to https://github.com/ratishsp/data2text-plan-py but with differences too (two stage model, newer code etc.)
I had got busy with another work, I will push code into this repository over the next few days. And will update the README accordingly.
If you are interested in model outputs to compare with your own outputs, I have added them in the google drive link https://drive.google.com/drive/folders/1jJjq5IvuBKNLTAe7fuwlDYParrxpK-WD?usp=sharing

Hi,
Thanks for your kind reply.
That will be really helpful.
Best wishes
Tong

Hi Tong,
I have updated the README with the instructions for RotoWire dataset. The instructions for MLB dataset will follow soon.
Regards,
Ratish

Hi @ratishsp ,
Thanks a lot for your contribution.
That is really helpful

The repo has been updated with instructions for MLB dataset too.


Emojis Broken Image Source

I have tried showdown 1.0.9 with and without showdown-emoji 1.0.5 and can not get emojis to work.
Without showdown-emoji I just get the text:

emoji :smile:

And with showdown-emoji the image links appear to be broken:
emoji
https://github.global.ssl.fastly.net/images/icons/emoji/smile.png?v5 is not found?
Am I missing something? Thanks

I got it working without showdown-emoji but adding emoji: true.
Whoops!

Glad you figure it out. :)


Cleaner  code in installer

commit
8d27eb9
Proposed change
There is a terrible mess introduced into INSTALL.sh when travis CI was attached to the repo.

@Setnea Once your work on the installer is done, please make the pull request to the install-on-travis branch, since it is prepared for runnning INSTALL.sh on travis.

Despite using ./INSTALL.sh -p /$HOME/db/ -t 1 -y, travis build fails.

@Setnea  3c349a3 removed the unbound variable error as you can see in this travis build

Despite sourcing .bashrc and successful tests.test.PathTests, the virtualenv must be activated with separate command on travis.
tests.test.ConfigTests now use config file separate test file. It should be identical with mothulity.config in the repo during development.

resloved with #30


VPN: Add support for custom DNS

Task/Issue URL: https://app.asana.com/0/488551667048375/1207500898026382/f
Description
See attached task description
Steps to test this PR
https://app.asana.com/0/0/1207531536629227/f

#4637  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karlenDimla and the rest of your teammates on  Graphite


Update readme.md

Description of the change:
Reason for the change:
Link to original source:

Closes #

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@scoyne - we can get this merged in when you sign the CLA!


Deprecated Plexus @Component annotations are removed

This PR removes the deprecated @Component annotations from the Quarkus extension and Maven Convention Develocity extension sample. They have been replaced with a dedicated file at src/main/resources/META-INF/plexus/components.xml instead.

@etiennestuder after having a shift in priorities, this is ready for review once more.

Merging as it's the same changes as were made to CCUD Maven. There should be no surprises here.


Bad wrapping/overflow in docs

Found at least one instance where the API docs render poorly with long property or event names:
https://elements.polymer-project.org/elements/paper-slider

auto-moving this issue to PolymerElements/iron-doc-viewer#45 and closing this one

Thanks for this! The documentation should be rendered via PolymerElements/iron-doc-viewer, so moved this to there.


FIrebird chokes on the first insert statement into databasechangelog table

Environment
Firebird container built using: https://github.com/jacobalberty/firebird-docker
v. 3.0.6
Liquibase Version:
4.0.0
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
CLI
Liquibase Extension(s) & Version:
Database Vendor & Version:
Firebird 3.0.6
Operating System Type & Version:
Mac for local system
Docker container for db
Description
Liquibase is attempting to do an update but chokes right away on inserting a row into DATABASECHANGELOGLOCK
Steps To Reproduce

Create a firebird container, I used the following commands
-- docker pull jacobalberty/firebird
-- docker run --name pd13 -e ISC_PASSWORD=datical -e FIREBIRD_DATABASE=testdb -e FIREBIRD_USER=datical -e FIREBIRD_PASSWORD=datical -p 3050:3050 jacobalberty/firebird
Create a liquibase.properties file (like the one below)
Create dbchangelog.sql
Run liquibase update

liquibase.properties

changeLogFile: dbchangelog.sql
url: jdbc:firebirdsql://localhost:3050//firebird/data/testdb
username: datical
password: datical
driver: org.firebirdsql.jdbc.FBDriver
classpath: ../drivers/jaybird-full-3.0.6.jar
logLevel: DEBUG

dbchagelog.sql

-liquibase formatted sql
--changeset bob:1
CREATE TABLE "DEPARTMENT" ("ID" INTEGER, "NAME" STRING, "ACTIVE" BOOLEAN);

Actual Behavior
You get the following error:
[2020-08-10 20:16:03] FINE [org.firebirdsql.logging.JulLogger debug] readStatusVector arg:isc_arg_gds int: 0 Unexpected error running Liquibase: conversion error from string "0" [SQLState:22018, ISC error code:335544334] [Failed SQL: (335544334) INSERT INTO DATABASECHANGELOGLOCK (ID, LOCKED) VALUES (1, 0)] For more information, please use the --logLevel flag [2020-08-10 20:16:03] SEVERE [liquibase.integration] Unexpected error running Liquibase: conversion error from string "0" [SQLState:22018, ISC error code:335544334] [Failed SQL: (335544334) INSERT INTO DATABASECHANGELOGLOCK (ID, LOCKED) VALUES (1, 0)] liquibase.exception.LockException: liquibase.exception.DatabaseException: conversion error from string "0" [SQLState:22018, ISC error code:335544334] [Failed SQL: (335544334) INSERT INTO DATABASECHANGELOGLOCK (ID, LOCKED) VALUES (1, 0)] 	at liquibase.lockservice.StandardLockService.acquireLock(StandardLockService.java:294) 	at liquibase.lockservice.StandardLockService.waitForLock(StandardLockService.java:212) 	at liquibase.Liquibase$1.run(Liquibase.java:188) 	at liquibase.Scope.lambda$child$0(Scope.java:159) 	at liquibase.Scope.child(Scope.java:170) 	at liquibase.Scope.child(Scope.java:158) 	at liquibase.Scope.child(Scope.java:137) 	at liquibase.Liquibase.runInScope(Liquibase.java:1790) 	at liquibase.Liquibase.update(Liquibase.java:183) 	at liquibase.Liquibase.update(Liquibase.java:179) 	at liquibase.integration.commandline.Main.doMigration(Main.java:1543) 	at liquibase.integration.commandline.Main$1.lambda$run$0(Main.java:316) 	at liquibase.Scope.lambda$child$0(Scope.java:159) 	at liquibase.Scope.child(Scope.java:170) 	at liquibase.Scope.child(Scope.java:158) 	at liquibase.Scope.child(Scope.java:137) 	at liquibase.Scope.child(Scope.java:183) 	at liquibase.Scope.child(Scope.java:187) 	at liquibase.integration.commandline.Main$1.run(Main.java:315) 	at liquibase.integration.commandline.Main$1.run(Main.java:166) 	at liquibase.Scope.child(Scope.java:170) 	at liquibase.Scope.child(Scope.java:144) 	at liquibase.integration.commandline.Main.run(Main.java:166) 	at liquibase.integration.commandline.Main.main(Main.java:145) Caused by: liquibase.exception.DatabaseException: conversion error from string "0" [SQLState:22018, ISC error code:335544334] [Failed SQL: (335544334) INSERT INTO DATABASECHANGELOGLOCK (ID, LOCKED) VALUES (1, 0)] 	at liquibase.executor.jvm.JdbcExecutor$ExecuteStatementCallback.doInStatement(JdbcExecutor.java:398) 	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:82) 	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:154) 	at liquibase.executor.jvm.JdbcExecutor.execute(JdbcExecutor.java:134) 	at liquibase.lockservice.StandardLockService.init(StandardLockService.java:127) 	at liquibase.lockservice.StandardLockService.acquireLock(StandardLockService.java:251) 	... 23 more Caused by: java.sql.SQLException: conversion error from string "0" [SQLState:22018, ISC error code:335544334] 	at org.firebirdsql.gds.ng.FbExceptionBuilder$Type$1.createSQLException(FbExceptionBuilder.java:532) 	at org.firebirdsql.gds.ng.FbExceptionBuilder.toFlatSQLException(FbExceptionBuilder.java:302) 	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readStatusVector(AbstractWireOperations.java:138) 	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.processOperation(AbstractWireOperations.java:202) 	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readSingleResponse(AbstractWireOperations.java:169) 	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readResponse(AbstractWireOperations.java:153) 	at org.firebirdsql.gds.ng.wire.AbstractFbWireDatabase.readResponse(AbstractFbWireDatabase.java:183) 	at org.firebirdsql.gds.ng.wire.version10.V10Statement.execute(V10Statement.java:326) 	at org.firebirdsql.jdbc.FBStatement.internalExecute(FBStatement.java:1357) 	at org.firebirdsql.jdbc.FBStatement.executeImpl(FBStatement.java:840) 	at org.firebirdsql.jdbc.FBStatement.execute(FBStatement.java:826) 	at liquibase.executor.jvm.JdbcExecutor$ExecuteStatementCallback.doInStatement(JdbcExecutor.java:394) 	... 28 more Caused by: org.firebirdsql.jdbc.FBSQLExceptionInfo: conversion error from string "0"
Expected/Desired Behavior
Update to complete, table to get created.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Maybe I didn't create my database correctly with the right settings?  I just used:
create database testdb;

Hi @ro-rah Thanks for taking the time to document the recreation steps and bringing this issue to our attention.  I have reproduced the error and will add it to the list of issues we are processing.

@ro-rah This is a duplicate of #1303

Hey, i think the Issue was fixed until 4.4.2 and comes back with version 4.4.3.

@jproples Issue looks like it broke in 4.6.x as well

Hi there!
Looks like it got fixed for 4.11. Things i did to be aware of:

Used the latest jacobalberty/firebird container version

Downloaded the connector-api-1.5.jar from Maven Central

I substituted string for varchar on the changelog (looks like firebird doesnt have string as a default datatype anymore?)

Added a - on the begining of the changelog  (prob a Ctrl+C error from @ro-rah, but just in case i wanted to point it out)

If the issue persist, let me know
Testing Environment:
OS: Windows 10
Liquibase Build: [Core: //master/2708/0a9d6d/2022-05-23 15:17+0000, Pro: master/1291/728a05/2022-05-19T14:28:39Z]
Java 11.0.15


Return decoded text strings for title and html.

See discussion on #165 - this essentially takes the inverse approach to #304 so that titles and html source are text strings rather than byte strings which makes writing tests feel much more natural.

@lrowe thank you!


Try to run failsafe tests in parallel

I'm not sure tests actually run in parallel here... build time is about the same as on master and all About to run logs appear on thread "main" :thinking:


stake-ui: Unlock all button

Currently, the Lockup page's unlock button allows a user to withdraw/unlock all tokens from a single vesting account. We should add an additional button that does this for all available vesting accounts, automatically, instead of requiring the user to go through each vesting account one by one.

👋🏻 Good day, mate.
I make the following utilities based on Solidity & Rust with powerful frontend demonstration.
💻Dapps(Swap, Staking, Referral, Farm, Pool, Presale, Reflection, DAO ...)
💻NFT marketplaces (Opensea, Rarible, Metaplex)
💻Backend software
Leave msgs if you are in the demand of me.


deleteIn fails for Set within Map

I would expect this code to work:
new Map().set("decks", new Set([1, 12, 2])).deleteIn(["decks", 12])

instead it throws: Uncaught Error: invalid keyPath

+1. Since Set and Map both expose a delete function, I would expect this to work. Even if it doesn't though, it should return a more descriptive error. Something like:
Uncaught error: deleteIn invalid for type Set

This bug is over a year old and remains unacknowledged and unfixed... any comment from the devs would be appreciated.


clean X-Crawlera-* headers when crawlera is disabled

The problem
Users of this middleware may have settings like this in their spiders:
custom_settings = {
    'DEFAULT_REQUEST_HEADERS': {
        'X-Crawlera-Profile': 'desktop',
        'X-Crawlera-Debug': 'ua',
    }
}

Or, what's even more difficult to track, their spiders can be full of requests passing Crawlera headers such as:
yield Request(fancy_url, headers={'X-Crawlera-Profile': 'desktop'})

If, for some reason, they disable Crawlera via crawlera_enabled = False, the middleware does nothing with the request and such headers will be exposed to the website, which may not be the desired outcome.
The fix
This PR fixes the issue by cleaning all the headers whose name start with X-Crawlera- when Crawlera is disabed.

@stummjr can you please fix the failing checks? I just starting reviewing the PR btw, I'll come back with some comments. Thank you

@eLRuLL just fixed the coverage.


Fix the bug when matching pattern tree using multi-wildcard

Description
When matching **.xx with a node, we need to push two times.

One push for xx and node.children();
the other push for **.xx and node.children().

Before this change, if the xx cannot match node.children, the second push is lost. This PR fix this scenario.

Coverage increased (+0.03%) to 54.145% when pulling d320ea5d1ea9b158b72271bf72b6766e715823ae on xingtanzjr/fix_schema_tree_match into b2520b31b02902921dad83926c9bba6eaafffabe on master.


featureOnly query can use local cache when reading remote files.

Proposed changes
Issue Number: close #13864
Problem summary
When calling select on remote files, download cache files to local disk.
When calling alter table on remote files, read files directly from remote storage. So if tablet is too large, it will not take up too many local disk when creating local cache file.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.89 seconds
load time: 611 seconds
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221101114536_clickbench_pr_37306.html


Quantum Circuit Learning implementation

Hi, with this commit I have included Quantum Circuit Learning implementation according to the paper https://arxiv.org/abs/1803.00745.
Additionally, docs with simple regression and classification examples are included.
Since, the execution of the program is quite long (there are many expectation values to be calculated for predictions and gradients), the code is adjusted only to QVM.
Feel free to drop any remarks.

@dawidkopczyk Awesome! Thank you for the PR! I'll try to get to leaving some remarks in the next few days - looking forward to playing with this code!


Add getzola.zola 0.17.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This package is expecting arguments:
A fast static site generator with everything built-in

Usage: zola.exe [OPTIONS] <COMMAND>

Commands:
  init        Create a new Zola project
  build       Deletes the output directory if there is one and builds the site
  serve       Serve the site. Rebuild and reload on change automatically
  check       Try to build the project without rendering it. Checks links
  completion  Generate shell completion
  help        Print this message or the help of the given subcommand(s)
...

@wingetbot waivers Add Validation-Executable-Error


[New game]: CSS Select

🎮 Game Request
CSS Select is a fun game where we make our CSS concepts stronger in a gamified way.
Point down the features

Fun
Challenging
Educational
Addictive

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Sriparno08 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Sriparno08 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Explore binding between DOM elements in VS Code to the smoke test DOM element selectors

Currently it is difficult to know if any of the DOM elements touched during a development work are used in the smoke test.
Continuation of https://github.com/Microsoft/vscode/issues/25291#issuecomment-302704524.
One example:
This following change lead to the smoke test failure because DOM element attribute was changed:
https://github.com/Microsoft/vscode/commit/eac49a321b84cb9828430e9dcd3f34243a3480f7
This attribute was used in the smoke test to grab the contents of SCM part in status bar:
https://github.com/Microsoft/vscode/commit/0aec2d6838b5e65cc74c33b853ffbd9fa191d636

Exploration done and decision was made not to do any binding due to overhead and restrictions from the core code point of view.
Instead, log of smoke test failures should be created and maintained to understand common scenarios where tests fail because of loose binding or some other problems.


traduccion al Español Latino

se adjunta traduccion al Español latino

Pull Request Test Coverage Report for Build 454

2 of 8 (25.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.09%) to 42.291%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/locales.js
2
8
25.0%

Totals

Change from base Build 453:
-1.09%

Covered Lines:
129

Relevant Lines:
257

💛  - Coveralls

please do not add as buildin locales. and add the testease.


feat(errors): add errors

What this PR does
Add errors pkg.
why we need it
Currently, errors is not ready to use.
This PR will make a standard error which should be used in future.
Special notes for your reviewer:

Coverage increased (+1.4%) to 54.846% when pulling a46fae18b3119df3e74eb347fc43484fff1e3145 on walktall:errors into fcc6b2d4e13d9f94b983a03ae1183579ab9b870e on caicloud:master.

Coverage increased (+1.3%) to 54.645% when pulling 7cef8eda0060d5a39f8fbe361faa166415875081 on walktall:errors into 2a0eea7838c9644315015155b75b0bb75f275d93 on caicloud:master.

Coverage increased (+1.3%) to 54.645% when pulling 7cef8eda0060d5a39f8fbe361faa166415875081 on walktall:errors into 2a0eea7838c9644315015155b75b0bb75f275d93 on caicloud:master.

Coverage increased (+1.3%) to 54.645% when pulling 386b844a94f8d82544579c6c72169d4986175e02 on walktall:errors into 2a0eea7838c9644315015155b75b0bb75f275d93 on caicloud:master.

Coverage increased (+1.3%) to 54.645% when pulling ffb3acad86ba0232d232965eba818a93b3f9a9aa on walktall:errors into 2a0eea7838c9644315015155b75b0bb75f275d93 on caicloud:master.

@walktall please update the PR as discussed offline.

We need to provide well-defined errors to regulate error usage, e.g. https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go. To allow custom error message, you can leave a formatter method as discussed.
Flexibility comes with a cost of breaking things. I want error types to be well established.

@ddysher I don't think so, a Factory is enough to restrict the error format and control it.
And a formatter method is not enough since format string is paired with reason.
Code will be like this if we add formatter and reason setter:
func (f Factory) SetReason(r Reason) *Factory {
	f.reason = r
	return &f
}

func (f Factory) SetFormat(s string) *Factory {
	f.format = s
	return &f
}

var BadRequest = NewFactory(400, Reason("badRequest"), "user need to check this field when they are using provided errors.BadRequest")

// In user's pkg, they still need to write
var BadRequest = errors.BadRequest.SetReason("events:badRequest").SetFormat("${name} mismatch")
// which is much more confused than
var BadRequest = errors.NewFactory(400, errors.Reason("events:badRequest"), "${name} mismatch")

The actually error should not be set by a web framework, it is business staff. https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go this is error just for k8s but not for other cases and we are making a web framework but not another k8s repo.
Usage for errors pkg should be like this:
// User writes an error pkg in their own repo which import nirvana/errors, and

var BadRequest = errors.NewFactory(400, errors.Reason("events:badRequest"), "${name} mismatch")

If we want to control the format globally, we can create a caicloud/errors only used in our cases.

Usage in my mind:
var ApplicationIsNotFound = errors.EntityNotFound.Factory("app-admin:application-module:application-not-found","server can't find application {applicationName} in partition {partitionName}")

func GetApplication() (*Application, error) {
    return ApplicationIsNotFound.New("mongodb", "test")
}

func main() {
    _, err := GetApplication()
    if ApplicationIsNotFound.Equal(err) {
        // Do something.
    }
}


Request: shortcuts for checking box and "patch game" button, and more

I like to speed up the game 500% when I die in a boss and gonna have  to wait 30s in the "you died" screen, plus loading, plus walking from the check point to the boss room and slow the game back to the default speed when I enter fight is going to start.  The box is unchecked, I patched the game but the camera behavior still is "patched". Tried to close the game and reopening it and didnt manage to revert the game back to the default camera behavior. I will check a bit more and post here if anything changes about that.

This PR should fix the camera auto rotate disable not working: https://github.com/uberhalit/EldenRingFpsUnlockAndMore/pull/111

For my own use, I've hacked in a hotkey to toggle the game speed adjustment.  The diff is below (although it won't apply automatically with patch due to unrelated factoring I did nearby).  If there is interest, I could make the key customizable and submit a PR.
diff --git a/EldenRingFPSUnlockAndMore/MainWindow.xaml.cs b/EldenRingFPSUnlockAndMore/MainWindow.xaml.cs
index e3b3b95..5762826 100644
--- a/EldenRingFPSUnlockAndMore/MainWindow.xaml.cs
+++ b/EldenRingFPSUnlockAndMore/MainWindow.xaml.cs
@@ -15,6 +15,8 @@ using System.Management;
 using System.Text.RegularExpressions;
 using System.Collections.Generic;
 using System.Security.Principal;
+using System.Windows.Input;
+using System.Windows.Interop;

 namespace EldenRingFPSUnlockAndMore
 {
@@ -69,6 +71,17 @@ namespace EldenRingFPSUnlockAndMore
         internal readonly DispatcherTimer _dispatcherTimerGameCheck = new DispatcherTimer(DispatcherPriority.Send);
         internal readonly BackgroundWorker _bgwScanGame = new BackgroundWorker();

+        /// <summary>
+        /// True if the speed toggle hotkey is registered.
+        /// </summary>
+        internal bool _registeredHotKey = false;
+
+        // Hotkey registration functions.
+        [DllImport("user32.dll")]
+        private static extern bool RegisterHotKey(IntPtr hWnd, int id, uint fsModifiers, uint vk);
+        [DllImport("user32.dll")]
+        private static extern bool UnregisterHotKey(IntPtr hWnd, int id);
+
         public MainWindow()
         {
             InitializeComponent();
@@ -85,6 +98,21 @@ namespace EldenRingFPSUnlockAndMore
                 Directory.CreateDirectory(appdir);
             _path_logs = Path.Combine(appdir, "logs.log");

+            // Register a global hotkey (F4) to toggle the speed change in-game.
+            IntPtr myWindowHandle = new WindowInteropHelper(this).Handle;
+            if (RegisterHotKey(myWindowHandle, 1 /*id*/, 0, 0x73 /*F4*/))
+            {
+                _registeredHotKey = true;
+
+                // Arrange to intercept the resulting WM_HOTKEY messages.
+                HwndSource source = HwndSource.FromHwnd(myWindowHandle);
+                source.AddHook(new HwndSourceHook(WndProc));
+            }
+            else
+            {
+                LogToFile("RegisterHotKey failed");
+            }
+
             var mutex = new Mutex(true, "ErFpsUnlockAndMore", out bool isNewInstance);
             if (!isNewInstance)
             {
@@ -142,6 +170,25 @@ namespace EldenRingFPSUnlockAndMore
                 }
                 catch { }
             }
+
+            if (_registeredHotKey)
+            {
+                IntPtr myWindowHandle = new WindowInteropHelper(this).Handle;
+                UnregisterHotKey(myWindowHandle, 1 /*id*/);
+            }
+        }
+
+        // Intercepted window message handler.
+        private IntPtr WndProc(IntPtr hwnd, int msg, IntPtr wParam, IntPtr lParam, ref bool handled)
+        {
+            const int WM_HOTKEY = 0x0312;
+            if (msg == WM_HOTKEY)
+            {
+                ToggleGameSpeed();
+                handled = true;
+            }
+
+            return IntPtr.Zero;
         }

         /// <summary>
@@ -812,6 +859,13 @@ namespace EldenRingFPSUnlockAndMore
             return true;
         }

+        // Toggle the game speed checkbox, then re-patch.
+        private void ToggleGameSpeed()
+        {
+            cbGameSpeed.IsChecked = !cbGameSpeed.IsChecked;
+            PatchGameSpeed();
+        }
+
         /// <summary>
         /// Checks if the user has called this application as administrator.
         /// </summary>


OpenSense Sensor data

Hi, I'm trying to build my first Apple Watch app based on your project. I want to eventually add more features, so that user can choose the base station (or better yet data is served from closest one). I would like to use sensors from opensensemap. They have a simple API which I can query successfully from Postman, but I don't have experience getting data with swift.
I can't read these two values: lastMeasurement.value and lastMeasurement.createdAt
Could you please give tips on how to modify the KrakowPiosDataLoader.swift so that it would work with a basic JSON? Thank you.

Hey!
Is the structure of the JSON objects under sensors always the same? I mean, do they always have the same set of fields e.g. icon as string, lastMeasurement with value as string and createdAt etc? I'm asking because this new Codable API I've used is kind of hard to use for objects of variable field structure.
If it's always the same, you just need to modify the structure used to parse data into (Response / ResponseData / DataSeries / DataPoint) and replace it with something that models your data: e.g. a Response object that has let sensors: [Sensor], where a Sensor struct has fields title, unit etc., and then it has a let lastMeasurement: Measurement, where again the Measurement is another sub-type that has just two fields value and createdAt. And then in the end you parse the response using the JSONDecoder and extract response.sensors[0].lastMeasurement.value.
Alternatively, you can take the older version from https://github.com/mackuba/SmogWatch/blob/d53a1c786c88bc02d400046727a79b4dcffbb52d/SmogWatch WatchKit Extension/KrakowPiosDataLoader.swift and do it as it's done there: for every step on the way, pick a field from a dictionary and cast it with as? either to a String/Int or another [String:Any].
Here are some intros to Codable:

https://medium.com/xcblog/painless-json-parsing-with-swift-codable-2c0beaeb21c1
https://blog.pusher.com/swift-4-decoding-json-codable/

And a more advanced and complete article with some more complex stuff: https://benscheirman.com/2017/06/swift-json/


z3 never terminated

OSX 10.10.5
Z3 version 4.4.0
When I invoke for example
dist/build/emna/emna --prover=z examples/Reverse.hs

emna proves the property properly and exits, but z3 continues running in the background eating up CPU until killed.

I just pushed a commit which make z3 time itself out, do you still have this problem?

Seems to have been fixed, works perfectly so far!


[AutoDiff] Fix TBDGen issues for derivative dispatch thunks and method descriptors.

Add DispatchThunkDerivative and MethodDescriptorDerivative as link entities. The derivative functions of initializers, subscripts, properties, and methods are all methods, so we don't need other link entities for this purpose.
Mangle dispatch thunks and method descriptors. Make AutoDiffFunction a context node since it can be nested.

Resolves SR-13866 (rdar://71318828) and SR-13125 (rdar://65240599).

@swift-ci please test

@swift-ci please test

@swift-ci please test and merge

@swift-ci please test and merge

Build failed
Swift Test Linux Platform
Git Sha - e90498895115bf0e52bbac20f0aa2207ab011c02

Build failed
Swift Test Linux Platform
Git Sha - e90498895115bf0e52bbac20f0aa2207ab011c02

Build failed
Swift Test OS X Platform
Git Sha - e90498895115bf0e52bbac20f0aa2207ab011c02

Build failed
Swift Test OS X Platform
Git Sha - e90498895115bf0e52bbac20f0aa2207ab011c02

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge

@swift-ci please test and merge


LogFileStats to return record counts by tool and flutter channel count

Currently we have a total aggregate count of all records across all tools, it would be good to also return a count by each tool.
For example:
20 total records

12 flutter-tools
5 dart-tools
3 language-server

We should also extend this logic so that we are collecting which channels recorded which events for flutter
For example:
20 total records

12 stable (flutter channel)
5 beta (flutter channel)
3 master (flutter channel)

Completed in #117


Dataset Viewer issue for gsarti/flores_101

Link
https://huggingface.co/datasets/gsarti/flores_101
Description
It seems like streaming isn't supported for this dataset:
Server Error
Status code:   400
Exception:     NotImplementedError
Message:       Extraction protocol for TAR archives like 'https://dl.fbaipublicfiles.com/flores101/dataset/flores101_dataset.tar.gz' is not implemented in streaming mode. Please use `dl_manager.iter_archive` instead.

Owner
No

Related to https://github.com/huggingface/datasets/issues/4562#issuecomment-1166911751
I'll assign @albertvillanova

I'm just wondering why we don't have this dataset under:

the facebook namespace
or the canonical dataset flores: why does this only have 2 languages?

fwiw: the dataset viewer is working. Renaming the issue


quick-lint-js: 3.0.0 -> 3.2.0

Description of changes
https://quick-lint-js.com/releases/#3.2.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Done in #294657.


Fixed an issue that a bot found with my changes

Fixed an issue that a bot found with my changes
in r344626 & recommitting.  Original commit msg:
Simplify LocateDSYMInVincinityOfExecutable by moving
some redundant code into a separate function,
LookForDsymNextToExecutablePath, and having that function
also look for .dSYM.yaa files in addition to .dSYM
bundles.
Differential Revision: https://reviews.llvm.org/D53305
rdar://problem/40406580
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@344646 91177308-0d34-0410-b5e6-96231b3b80d8
(cherry picked from commit 7f559d6cde804f40a18902fca6a5193aaccdf592)

@swift-ci test and merge

@swift-ci test and merge

@swift-ci test and merge

@swift-ci test and merge

@swift-ci test and merge


Fix analyzer tests on wasm

What was wrong?
https://github.com/ethereum/fe/issues/466#issuecomment-871809090
How was it fixed?
Instead of hashing the attributes directly with the Hash trait, we now hash the Debug string. This gives consistent hash values on wasm and linux/x86.
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #475 (71fda74) into master (5df2f51) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 71fda74 differs from pull request most recent head 634f9fb. Consider uploading reports for the commit 634f9fb to get more accurate results

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   87.31%   87.31%
=======================================
  Files          75       75
  Lines        4966     4966
=======================================
  Hits         4336     4336
  Misses        630      630

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df2f51...634f9fb. Read the comment docs.


Marks supports-color as an optional peer dependency

This diff adds supports-color as an optional peer dependency. Optional peer dependencies don't trigger warnings when users omit them. They are supported by all package managers, including npm.
Adding these lines will prevent package managers from incorrectly hoisting supports-color in a way that would prevent debug from accessing it.

It was optional and many people decided not to read the documentation on how to use it.

Ping @Qix-? This approach is a strict improvement with zero downsides, is there a blocker?

@arcanis Yes, I do OSS in my free time and I've been swamped at work lately. I need to vet this and do some research before I form a conclusion.

No worry 🙂
If that makes your work easier, here are some pointers:

Original RFC: https://github.com/yarnpkg/rfcs/pull/105
Implemented in Yarn 1.13, Dec 2018: https://github.com/yarnpkg/yarn/pull/6671
Implemented in pnpm 3.2.0, Apr 2019: https://github.com/pnpm/pnpm/issues/1486
Implemented in npm 6.11.0, Aug 2019: https://github.com/npm/cli/pull/224
Last bug fixed directly on the npm server in october, retroactive effect.
Documentation: peerDependenciesMeta.optional

Various projects adopted it: create-react-app, typescript-eslint, Sindresorhus' packages, etc...

Ping? Just for context, I lead Yarn's development, and I can assure you there is no negative side effect to adding this field - neither on Yarn nor npm nor pnpm.

Ping 🙂

Duplicate of #709?

Ping. Starting from next week debug won't print colors on Yarn unless you merge and release this PR.

I'll merge and release, but let it be known: Yarn is not the standards comittee for package.json. I'll let it by this once, but I'm not going to add a bunch of extra meta information to the package.json just to appease each of the 10 different package managers.
These companies really need to get together and agree on a format because the package.json bloat over the last decade has been absurd.

These companies really need to get together and agree on a format because the package.json bloat over the last decade has been absurd.

Yarn is no company - we're a pure community-based open-source project. Additionally, this particular field got introduced two years ago after bringing both npm and pnpm people into the discussion.
I personally made the implementation PRs for both Yarn and npm, and made a few followup revisions to the design in order to make it easier for implementors such as you to start using it without it being painful for your users. I even went ahead and made the PRs on those projects to let you know about it before it had any chance to be noticed by your users - does that often happen?
Overall, I find your assessment quite unfair.

Close #709

@arcanis

Yarn is no company - we're a pure community-based open-source project.

It doesn't matter. You and NPM are two competing organizations who share a single data structure and cannot seem to agree to keep the scope in check or agree on the features. Further, nobody wants to break anyone in order to improve it, so every little thing that isn't quite right results in a new field or some weird bandaid patch - and us maintainers get hundreds of PRs to update it.

I even went ahead and made the PRs on those projects to let you know about it before it had any chance to be noticed by your users - does that often happen?

If my well-defined package breaks because you decided to change the way your project behaves, that's less to do with my project and more to do with either your project or the data structure you claim to control.
package.json has been flawed from the ground-up for years. After the npm@5 release, lockfiles, the endless torrent of bugs and headache that introduced, I have very little patience for any sort of modifications to package.json.
Sorry if I seem annoyed. It's because I'm annoyed.

Thanks for the reminder @zypA13510; done.

Published as 4.2.0 under the beta dist-tag. Please test and make sure nothing has broken for you before I send to latest.