[BUG] Helm2 install error: 'lookup' function not defined in validate-psp-install.yaml

Describe the bug (🐛 if you encounter this issue)
When attempting to install Longhorn using Helm2, the following error is encountered:
Error: parse error in "longhorn/templates/validate-psp-install.yaml": template: longhorn/templates/validate-psp-install.yaml:1: function "lookup" not defined

To Reproduce
Steps to reproduce the behavior:
git clone -b v1.4.3-rc2 https://github.com/longhorn/longhorn.git
cd longhorn

Run the command helm install --namespace longhorn-system --name longhorn ./chart with Helm2.
Observe the error mentioned above.

Expected behavior
The installation of Longhorn using Helm2 should not encounter any errors and should proceed successfully.
Log or Support bundle
If applicable, add the Longhorn managers' log or support bundle when the issue happens.
You can generate a Support Bundle using the link at the footer of the Longhorn UI.
Environment

Longhorn version:
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm 2
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s

Number of management node in the cluster: 1
Number of worker node in the cluster: 3

Node config

OS type and version:
CPU per node:
Memory per node:
Disk type(e.g. SSD/NVMe):
Network bandwidth between the nodes:

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal):
Number of Longhorn volumes in the cluster:

Additional context
Add any other context about the problem here.
Possible Solution
One possible solution is to drop the support for Helm2 or remove the lookup function that is causing the error. This should be discussed further to determine the best course of action.

We probably need to remove helm 2 support.

Discussed elsewhere as well, but for complete information in this issue:
I agree that we should remove Helm 2 support. If we do, we should declare support for Helm v3.1+ (excluding Helm v3.0, since it doesn't have the lookup function either).

https://github.com/helm/helm/issues/9167
https://github.com/helm/helm/commit/d564d4bf2d6c6a9781439db231c4aaa1d7a916f8

+1 for dropping Helm2 support.

@roger-ryao Please check if helm v2 support info has been removed from the release note of the installed chart and doc. If yes, close the issue.

Verified on master-head 20231225

longhorn master-head https://github.com/longhorn/longhorn/commit/fe9dc3c5530f58b80085686718e351a8e4634229
website master-head https://github.com/longhorn/website/commit/d52be78467ecd57078df111ae33f30d392f5b261

Result Passed

require/doc : https://github.com/longhorn/longhorn/pull/7434 & https://github.com/longhorn/website/pull/822

Hi @innobead
After reviewing the pull request, everything looks good. This issue has been highlighted since v1.4.3. I suggest backporting it to https://github.com/longhorn/longhorn/pull/7434 and https://github.com/longhorn/website/pull/822 for v1.5.x and 1.4.x. This way, users won't mistakenly think that v1.5.x and 1.4.x still support Helm 2.
Do you think fixing the documentation from v1.6.0 onward is sufficient?

Sounds good to me. This issue was introduced into 1.5.0 and 1.4.1, https://github.com/longhorn/longhorn/issues/5339, so let's update that doc as well.
For the chart, let's update to 1.6.0, 1.5.x (1.5.4), and 1.4.x (1.4.5).

For v1.6.0, we have two pull requests:

[x] 1.  https://github.com/longhorn/longhorn/pull/7437
[x] 2.  https://github.com/longhorn/website/pull/824

All related pull requests have been merged; close the ticket


WIP: Doing re-org of the kafka config folders

Proposed Changes

like eventing "core", and I guess serving, I am doing sub directories and symlinks for the yamls

I am not really sure I see a lot of value in this, tbh - but let's see if others like it or not
/assign @n3wscott
/assign @vaikas

/hold

/close


Revert "Move repository create to RepositoryService (#2632)"

Summary
The implementation didn't pass a provider name + ID and this broke staging
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 46.697% (-0.3%) from 47.019%
when pulling b4ba16e46a8ef0eb5dd40d82fc41ce8e4fb8e5b4 on revert-repo-issue
into 8035c66b5449b08fd65cb14766f4f3e64c3a19e8 on main.


CODEQL File Enhancements

This pull request introduces CodeQL workflows for code scanning in the repository. The changes include the addition of two workflow files, .github/workflows/code.yml and .github/workflows/codeql.yml, which configure the CodeQL analysis for various programming languages.
CodeQL Workflow Configuration:

New CodeQL Workflow Files:

Added .github/workflows/code.yml to configure CodeQL analysis on main branch pushes, pull requests, and a weekly schedule.
Added .github/workflows/codeql.yml to configure CodeQL analysis on main branch pushes, pull requests, and a different weekly schedule.

These workflows initialize CodeQL tools, set up the analysis matrix for supported languages, and handle the analysis process, including custom build steps if necessary.### Motivation and Context
Description

Contribution Checklist

[

### Tasks
``` ] I have built and tested the code locally and in a deployed app
- [ ] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
- [ ] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
- [ ] I didn't break any existing functionality :smile:

This pull request introduces two new GitHub Actions workflows for CodeQL analysis. These workflows are designed to automatically scan the codebase for security vulnerabilities and errors. The most important changes include the addition of the .github/workflows/code.yml and .github/workflows/codeql.yml files, which define the parameters and steps for running CodeQL analysis on different languages.
New GitHub Actions Workflows for CodeQL Analysis:

.github/workflows/code.yml: Added a new workflow for CodeQL analysis that runs on pushes and pull requests to the main branch, as well as on a weekly schedule. It includes configurations for different languages and build modes, and initializes and performs the CodeQL analysis.

.github/workflows/codeql.yml: Added another workflow for CodeQL analysis with similar configurations and scheduling as code.yml. This file also sets up the analysis for different languages and includes steps for initializing and performing the analysis.


IE book duplication

When right clicking on Engineer's manual from ie I spawn a copy of it in my inventory instead of opening it.

It was even worse, it took the place of my ender pouches from ender storage so they disappeared. Were quite fond of them...but at least I got more books to read...even though I had already read the first edition.


Fix spelling

Seems this fix was laying around a few months and I forgot to push it. Flushing buffers now before this repo gets merged into the monorepo.

jekyll installation issue. Should be easier to resolve on Debian Stretch or similar when CI tests are changed.

I suppose that the change is minimal, so I'll merge it even with the Travis-CI error. The issue on Travis is probably due to the change from Ubuntu Precise to Ubuntu Trusty environment.
I don't plan to merge the webpage in the monorepo, at least not yet. The monorepo needs to be cleaned up and restructured first.


recast timer for skills

just a timer for the recast time like the screenshot. maybe for Adrenaline too

duplicate of #37
copying the screenshot over there for reference


fix: use PROGMEM macro

Some platforms now throw the error: 'const void*' is not a pointer-to-object type with PIO in Linux.
It appears they handle PROGMEM differently.
This PR adds a macro resolves "pointer-to-object" errors in those platforms.

PGM Macro:
#if defined(ESP8266) |              \
    defined(ARDUINO_SAMD_MKRZERO) | \
    defined(ARDUINO_SAMD_ZERO) |    \
    defined(ARDUINO_SAM_DUE) |      \
    defined(ARDUINO_ARCH_ARC32) |   \
    defined(__TC27XX__) |           \
    (defined(TEENSYDUINO) && (TEENSYDUINO < 139))
#undef pgm_read_ptr
#define pgm_read_ptr(addr) (*(const void **)(addr))
#endif

src: https://github.com/SlashDevin/NeoGPS/issues/112

Example Build Error:
In file included from /home/circleci/.platformio/packages/framework-arduinoespressif8266/tools/sdk/libc/xtensa-lx106-elf/include/string.h:163:0,
from /home/circleci/.platformio/packages/framework-arduinoespressif8266/cores/esp8266/Arduino.h:33,
from .piolibdeps/bip39_ID5886/src/util.h:13,
from .piolibdeps/bip39_ID5886/src/dictionary/english_str.h:4,
from .piolibdeps/bip39_ID5886/src/dictionary/english.h:4,
from .piolibdeps/bip39_ID5886/src/bip39.cpp:2:
.piolibdeps/bip39_ID5886/src/bip39.cpp: In function 'int BIP39::{anonymous}::get_word_index(const char* const*, const string&)':
.piolibdeps/bip39_ID5886/src/bip39.cpp:52:28: error: 'const void*' is not a pointer-to-object type
strcpy_P(w, (char*)pgm_read_ptr_far(&(lexicon[i]))); // NOLINT
^
/home/circleci/.platformio/packages/framework-arduinoespressif8266/tools/sdk/libc/xtensa-lx106-elf/include/sys/string.h:32:57: note: in definition of macro 'strcpy_P'
#define strcpy_P(dest, src)          strncpy_P((dest), (src), SIZE_IRRELEVANT)
^
.piolibdeps/bip39_ID5886/src/bip39.cpp: In function 'BIP39::word_list BIP39::create_mnemonic(std::vector<unsigned char>&, BIP39::language)':
.piolibdeps/bip39_ID5886/src/bip39.cpp:106:31: error: 'const void*' is not a pointer-to-object type
strcpy_P(word, (char*)pgm_read_ptr_far(&(lexicon[position]))); // NOLINT
^
/home/circleci/.platformio/packages/framework-arduinoespressif8266/tools/sdk/libc/xtensa-lx106-elf/include/sys/string.h:32:57: note: in definition of macro 'strcpy_P'
#define strcpy_P(dest, src)          strncpy_P((dest), (src), SIZE_IRRELEVANT)
^
*** [.pioenvs/esp8266/src/test/.piolibdeps/bip39_ID5886/src/bip39.cpp.o] Error 1

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   94.22%   94.22%
=======================================
  Files           6        6
  Lines         225      225
=======================================
  Hits          212      212
  Misses         13       13

Impacted Files
Coverage Δ

src/bip39.cpp
94.38% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab4b4a...3233e45. Read the comment docs.

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   94.22%   94.22%
=======================================
  Files           6        6
  Lines         225      225
=======================================
  Hits          212      212
  Misses         13       13

Impacted Files
Coverage Δ

src/bip39.cpp
94.38% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab4b4a...3233e45. Read the comment docs.


docs: update required spark and python version on website doc

Related Issues/PRs

#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?

[ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

[ ] No. You can skip this section.
[ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

[ ] No. You can skip this section.
[ ] Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.0/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.1/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.2/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.4/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.5/about.md
94
100
72
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

/azp run

Codecov Report

Merging #1812 (248e315) into master (4c8d2e9) will decrease coverage by 80.50%.
The diff coverage is n/a.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thank you for your feedback @Mike-Soukup

/azp run

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.0/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.1/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.2/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.4/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.5/about.md
94
100
72
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

website/docs/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.0/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.1/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.10.2/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.4/about.md
100
100
100
link
:white_check_mark:

website/versioned_docs/version-0.9.5/about.md
94
100
72
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx


Login History on My Account Settings doesn't work

Login history on client's My Account Settings page doesn't work - might be good to remove this for now

will fix

Fixed in #172


paper

hello,Would you mind showing me your paper? I looked for it for a long time but I couldn't find it.

This was a little research mini-project for a module in my MSc, and hasn't resulted in a published paper.  Here is the report though, I hope it helps.


RESTEASY-1636 Part2

Remove documents on skeleton-key and OAuth modules
Add security modules deprecation document
Move login-module to security-legacy directory

@asoldano Thanks for the advice, it's much better! I've made the modifications for you to check.


Delete Group

I have accidentally created a Group and turns out that you can't delete it.

Um, good point 🤦♂For now, if you go into the DB and set the "deleted_at" timestamp on the group it won't show


DallasTemperature implements functions which should be part of OneWire

Several functions operate on the entire OneWire bus or apply to all OneWire devices. They should be part of either OneWire or a OneWire extension class.
getAddress()
readPowerSupply()
getDeviceCount()
Addresses would also benefit from being a class.
Removing the functions from DallasTemperature is likely to break things so unfortunately they have to be retained but should be deprecated and should be rewritten so that they call the replacement OneWire functions. As an intermediate step I am writing a OneWire extension class.
class OneWireExtra : public OneWire {
...
}

It should be possible to write an Address class that can be dropped in and used interchangeably with the uint8_t* approach. I have made a start on that and it looks promising.

Why not propose these changes directly to maintainer of OneWire class?  (pjrc.com)

Why not propose these changes directly to maintainer of OneWire class? (pjrc.com)

I will be doing but first I would like to see the discussion of getAddress, see #166, progress further. I have some ideas on that and will make the suggestions there.

As I have too much work at the moment it is hard for me to participate , sorry

Following the useful discussion on #166 I have come to the conclusion that these methods, at least in their present form, do not really belong in DallasTemperature or OneWire.

DallasTemperature because it only handles the DS18 series of devices and near relatives.
OneWire because it only handles devices on a single pin.
Accordingly I have started work on a OneWireManager that will keep track of device index, device address and which OneWire they are connected to. It will also make provision for initialising and storing that information.

OneWireManager::getAddress(deviceIndex);
OneWireManager::getOneWire(deviceIndex)
OneWire::readPowerSupply(deviceAddress)
OneWire::readPowerSupply() // for the bus as a whole which is usually what is required
OneWireManager::readPowerSupply(deviceIndex)
Deprecate getDeviceCount() and replace with an iterator
I have started coding and it is all falling into place quite nicely which is a goo sign. When it has progressed a bit further I will publish it via github.

Good action, (I try to keep reading your posts)
Please keep in mind that for the Arduino platform a lot of people are at beginner level.
Good to make a sophisticated level, but do not forget those who can just walk and are not able to run yet :)


This file isn't playable. That might be because the file type is unsupported, the file extension is incorrect, or the file is corrupt.

After I running inference_single.py. It generated this video https://drive.google.com/file/d/1sJNC_3rjy1Op8aKz4cKBBgbpvkOIlYAx/view?usp=sharing
I have debugged the code it stuck here  subprocess.call(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) and never reach this line print("succeed output results to:", outfile_path)

me too ，but on cloab  sucess


Support for Ubuntu 20.04

The goal of this task is to provide support for Ubuntu 20.04. Currently only Ubuntu 18.04 is officially supported.

[ ]  Verify that the right deb docker repository is used. Currently we are targeting bionic (18.04).
[ ] Add e2e tests for Ubuntu 20.04.
[ ] Verify that nothing else in the cloud-init config should be changed.
[ ] Update supported OS matrix.

/remove-lifecycle stale

/remove-lifecycle stale

xref: https://github.com/kubermatic/machine-controller/issues/839

xref: https://github.com/kubermatic/machine-controller/issues/839


Let's promote this?

Hey--several people have commented on this project/how cool it is. If I'm not mistaken/missing something it's useful out-of-the-box to non-Zalandos. So, let's promote? I can do the README and promo ... if you want other resources, LMK and we can try to make something happen during the FOSS Clinic (March 4, all day).

yes! it's a real proper piece of code :)

OK, let's set up 20 minutes to collect all the README essentials. You got time today/Friday?

so... i was out-of-office on Friday. But anyway, I think we should wait for Dmitriy with this, because this is really his code, and I only made some nitpicking changes to the readme. I think Dima is back from his vacation next week.

Sounds good! I've got plenty to work on :)


Implement storage data retention for accounts

Description
Make sure that blockchain data are not kept forever. Perform a regular cleanup of the data used in the storage.
Space reclaim process has to be performed on the following databases:

Accounts

Motivation

Proper data retention allows to control the amount of disk space used for storing blockchain data

Acceptance Criteria

Older data is deleted
Disk space is reclaimed

This issue does not need to be solved as Lisk Service does not store accounts by default. The new concept changes the approach for storing data; there is no need to implement it.


typing model: Don't reset on DEAD_QUEUE

We don't clear other server data on DEAD_QUEUE, plus there's already a client-side component that makes this feature fail gracefully in the presence of stale server data (a timeout to clear typing indicators).
Fixes-partly: #5605

Thanks for this cleanup! Looks good; merging.


[SPARK-8126] [build] Make sure temp dir exists when running tests.

If you ran "clean" at the top-level sbt project, the temp dir would
go away, so running "test" without restarting sbt would fail. This
fixed that by making sure the temp dir exists before running tests.

Merged build triggered.

Merged build started.

Test build #34847 has started for   PR 6805 at commit 12d7768.

Test build #34847 has finished for   PR 6805 at commit 12d7768.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


AFNetworking 2.0 in AFHTTPRequestOperationManager how to pass HTTPBody tag

I am using AFNetworking 2.0, in this I want to pass raw text (NSString ) in body part, How to pass HTTP Body in AFHTTPRequestOperationManager.
In AFNetworking 1.0, there is a scope for this  [request setHTTPBody:data]; but in 2.0 I am not find this method.
AFHTTPRequestOperationManager *manager = [AFHTTPRequestOperationManager manager];
NSDictionary *parameters = @{@"foo": @"bar"};
NSURL *filePath = [NSURL fileURLWithPath:@"file://path/to/image.png"];
[manager POST:@"http://example.com/resources.json" parameters:parameters constructingBodyWithBlock:^(id<AFMultipartFormData> formData) {
    [formData appendPartWithFileURL:filePath name:@"image" error:nil];
} success:^(AFHTTPRequestOperation *operation, id responseObject) {
    NSLog(@"Success: %@", responseObject);
} failure:^(AFHTTPRequestOperation *operation, NSError *error) {
    NSLog(@"Error: %@", error);
}];

I'd disagree a bit (not on the this not being a support forum part though). This, to me, is a fairly obvious regression in functionality. Or minimally, a common use case that has regressed in obviousness in how to implement.


public_send attribute assignment

pls guys let's just revert it to using send back again and release 4.5.1
i have to agree with @dnagir's comment on a pull request wich was closed before https://github.com/thoughtbot/factory_girl/pull/646
Factory Girls is not supposed to test any functionality. It's supposed to create blueprints fast. If you want to test that some assignment is working correctly you should write an extra spec.
This change for example breaks the possibility to assign a custom id to an activerecord model (because it's private) and now tons of specs at our codevase are broken


Update devtools remote debugging articles

What's changed, or what was fixed?

Update https://developers.google.com/web/tools/chrome-devtools/remote-debugging/local-server and https://developers.google.com/web/tools/chrome-devtools/remote-debugging to align with the latest Chrome's behavior.

Target Live Date: ASAP

[ ] This has been reviewed and approved by (NAME)
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 2 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/chrome-devtools/remote-debugging/imgs/discover-usb-devices.png - Try to keep files below 500K, was 561K
src/content/en/tools/chrome-devtools/remote-debugging/index.md#L105 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/chrome-devtools/remote-debugging/index.md#L105 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen

Thanks Eiji @agektmr! The changes look great.
A small request if possible(on page: /tools/chrome-devtools/remote-debugging/), could we have screenshots of browser window with... less open tabs? It would be cleaner. :D

@chybie Updated images.

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/chrome-devtools/remote-debugging/index.md#L105 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen


Add export map support for node v13

Preact added an export map, which broke our ability to require('preact/package.json') ("package.json" is not an export export in the export map, so disallowed by Node v13). Snowpack is now broken on Node v13 as a result.
/cc @MylesBorins just in case this is a regression / unintended side effect. The work around wasn't terrible, but does feel a bit hacky. A way to resolve a package root would be nice. Let me know if any of this should be turned into an issue/discussion anywhere.
User-reported issues:

https://www.pika.dev/npm/snowpack/discuss/67
https://www.pika.dev/npm/snowpack/discuss/68

Merging this now to get Node v13 back into a good state

I sent an upstream PR to explicitly add the package.json to the map. We (modules team) decided to not treat package.json special with the map. Perhaps that should be revisited, but at the very least you can rest assured this was expected behavior 😅

Oof, yea that's definitely a tough call. For example, a tool like Snowpack wants to read the package.json of ALL packages. Does that mean that all packages need to add the file to their import map just because that's my use case? 🤷♀
As long as it's expected and known behavior, then I'm confident the problem is in good hands :)


[Custom Trainer] Add import checks

Description

Add import check for optional dependencies

Changes

Describe the changes you made

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which refactors the code base)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist

Ensure that you followed the following

[ ] I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas (If applicable)
[ ] I have made corresponding changes to the documentation (If applicable)
[ ] I have added tests that prove my fix is effective or that my feature works (If applicable)

@djdameln can you check if you are still having issue on your end?


gc: Update to 8.0.0

I want just to inform about #1454, which I noticed for i686 (not tested for x86_64).
For me it sounds if 8.0.0 is still experimental stage. On next update please have a look if guile is working too. Thanks.


Update parquet-go

This PR includes the following parquet-go changes: https://github.com/segmentio/parquet-go/compare/edd371b528ff...8b4d4260d8, and will allow us to run in CPUs without BMI2 instructions or MOVBE support, such as older CPUs and some hypervisors
Test plan
[javierhonduco@computer frostdb]$ go test .
ok  	github.com/polarsignals/frostdb	(cached)

lgtm


IGAPP-935: Prefix yarn before Commands

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.
This will fix running commands on windows. @Cmd190 please also test this.

Again updated this branch as we found something else not working. yarn cross-env ${buildConfig} seems to have swallowed the react-native run-android command. Setting the env variables beforehand for the whole shell  seems to have finally fixed the issue. @Cmd190  please check this out again.


Fix crash due to shadow map camera setup

Added GVRCamera argument to GVRShadowMap constructor allowing the camera to be set up before the shadow map. This fixes a crash in the renderer caused by having the camera not set up for a few frames.
Disabled logging in lights.
This fixes one of the crashes in gvr-simple physics.
GearVRF DCO signed off by Nola Donato<EMAIL_ADDRESS>

Looks good. Will merge in the afternoon.


Get Object Changes from Activity

I wanted to get the object changes from an activity. I was hoping this was stored in a column but it appears not. Is this something that can be done currently?
If it currently can't be done, I think I could easily create a PR to add this changes column. Let me know if you'd be interested in merging something like this.

You can store them manually in the parameters column which gets serialized, but if you are looking for something to track changes to your models there's a better suited gem for that: https://github.com/airblade/paper_trail


NNVM Deployment on C++

Hi All,
I just started with NNVM and TVM from past week, now ran into below issue.
NNVM produce a graph(json), module (lib) and params which can be imported into any language as in example get_started.py.
fcreate = tvm.get_global_func("tvm.graph_runtime.create")
ctx = tvm.gpu(0)
gmodule = fcreate(loaded_json, loaded_lib, ctx.device_type, ctx.device_id)
set_input, get_output, run = gmodule["set_input"], gmodule["get_output"], gmodule["run"]
set_input("x", tvm.nd.array(x_np))
gmodule["load_params"](loaded_params)
run()
out = tvm.nd.empty(shape)
get_output(0, out)
print(out.asnumpy())
To use it with native C++ I couldn't find corresponding API @ http://docs.tvmlang.org/doxygen/namespaces.html
Also I referred from TVM howto examples library preparation and it has an entry function definition which is accessed as function pointer to call the module function.
# Compile library as dynamic library
fadd_dylib = tvm.build(s, [A, B], "llvm", name="addone")
dylib_path = os.path.join(base_path, "test_addone_dll.so")
fadd_dylib.export_library(dylib_path)
I see some difference in the library interfaces in above two cases.
Am I missing something here ?
Regards,
Siva

All APIs available are in the namespace topi.
BTW, you can make your text more readable by turning them into code blocks.

sorry about the readability, I didn't see it while copy paste.
topi has the Tensor API for TVM.
I am looking for C / C++ API for below python code.
fcreate = tvm.get_global_func("tvm.graph_runtime.create")
ctx = tvm.gpu(0)
gmodule = fcreate(loaded_json, loaded_lib, ctx.device_type, ctx.device_id)
set_input, get_output, run = gmodule["set_input"], gmodule["get_output"], gmodule["run"]
set_input("x", tvm.nd.array(x_np))
gmodule["load_params"](loaded_params)
run()
out = tvm.nd.empty(shape)
get_output(0, out)
Siva

Check out these links:
https://github.com/dmlc/nnvm/blob/master/include/nnvm/c_api.h
https://github.com/dmlc/tvm/blob/master/include/tvm/runtime/c_runtime_api.h

Thanks for the info.
Finally I found the sample implementation @ https://github.com/dmlc/nnvm/blob/master/docs/how_to/deploy.md
Siva


Please remove Microsoft Entra SSO integration with Jisc Student Voter Registration

Please remove "Microsoft Entra SSO integration with Jisc Student Voter Registration" page, as the service has now been decommissioned.  See https://www.jisc.ac.uk/student-voter-registration
Contact<EMAIL_ADDRESS>[or direct to me<EMAIL_ADDRESS>if you need anything further from us on this.
Kind regards,
Jon

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8d403758-8fc7-4942-bbc3-76280fee8e9c
Version Independent ID: 6b4d7a2d-731c-dabc-0d03-7a110364d168
Content: Tutorial: Microsoft Entra SSO integration with Jisc Student Voter Registration - Microsoft Entra
Content Source: articles/active-directory/saas-apps/jisc-student-voter-registration-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@jagland
Thanks for your feedback! We will investigate and update as appropriate.


influxdb module: collectd.port is now called bind-address

Motivation for this change
with the influxdb release we have packaged (and newer releases)
collectd.port has been streamlined to bind-address which takes a string
instead of a number.
ref: https://github.com/influxdata/influxdb/blob/master/services/collectd/README.md
Things done

Built on platform(s)

[ ] NixOS
[ ] macOS
[x] Linux

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Fits CONTRIBUTING.md.

Does this also affect 17.03?

it does but due to the fact that the port is default the behavior will not change. this is mostly for reference when you want to re-configure the service to listen on a different port.

Yes it does.


The application could not be installed: INSTALL_PARSE_FAILED_MANIFEST_EMPTY

I clone the repo and try to run it then it shows
Installation did not succeed.
The application could not be installed: INSTALL_PARSE_FAILED_MANIFEST_EMPTY
List of apks:
[0] 'D:\AndroidStudioProjects\SampleKotlinBase\android-showcase\app\build\outputs\apk\debug\app-debug.apk'
[1] 'D:\AndroidStudioProjects\SampleKotlinBase\android-showcase\feature_album\build\outputs\apk\debug\feature_album-debug.apk'
[2] 'D:\AndroidStudioProjects\SampleKotlinBase\android-showcase\feature_favourite\build\outputs\apk\debug\feature_favourite-debug.apk'
[3] 'D:\AndroidStudioProjects\SampleKotlinBase\android-showcase\feature_profile\build\outputs\apk\debug\feature_profile-debug.apk'
Installation failed due to: 'null'
may be I miss something.
Android Studio 4.

Hard o say, but this can be dependent on he version of the Android Studio.
Can you try clean checkout and run the project on AS 4.2 Beta 4 (or newer?)

I had a similar issue once when the app was already installed on the device - I had to manually uninstall it before installing/running from AS.
Besides this, I can't really reproduce this nowadays, so I will close this for now.


Update language for sql-boot

@mgramin thanks!

Job gh:yegor256/elegantobjects.github.io#71 is not assigned, can't get performer

This job is not in scope


write string in Querybuffer

in hooks QueryBuffer: after reading with buffer.readString () how to write it back into the buffer? same length or different length possible?

It's not intended to write strings, you can write method yourself if needed.


[#162] Historical Market Data Service error message:No historical market data for EUR/CASH@FXSUBPIP Last 1d

error retrieving FX cash historical data (i.e. EUR.USD).
Interactive Brokers does not disseminate TRADES data for cash FX. You need to use a different value for whatToShow than the default.
solution:
def requestHistoricalData(...):
    self.ibConn.reqHistoricalData(
                tickerId       = tickerId,
                contract       = contract,
                endDateTime    = end_datetime,
                durationStr    = lookback,
                barSizeSetting = resolution,
                whatToShow     = data, <<<<<
                useRTH         = int(rth),
                formatDate     = int(format_date)
            )

if contract.m_secType in ['CASH', 'CFD'], then override whatToShow=="MIDPOINT" or "BID" or "ASK", instead of "TRADES"

The parameter data is changeable... Just use:
ibConn.requestHistoricalData(..., data='MIDPOINT')

That being said, I've updated the method to default to MIDPOINT when requesting data for CASH/CFD.


Chore: new doc deployment

Since you are on it. We can also change package.json's legally command to only show a summary.

Hmm would be good if we create an index.html file to redirect to the latest release as part of this commit. Simply
<!DOCTYPE HTML>

        <meta charset="UTF-8">
        <meta http-equiv="refresh" content="0; url=http://example.com">

        <title>Page Redirection</title>

        If you are not redirected automatically, follow this link to example.

will do the job.
https://stackoverflow.com/questions/5411538/redirect-from-an-html-page

Looks awesome! There's only one tiny optional review request

Btw why don't we merge this to master directly and make a new release?


Add data nodes nuh

Please do not merge it yet. Waiting for confirmation from Hossam on where to add data nodes exactly. I'll update the name when it is ready to merge.

It's ready to be merged.


[Feature][Connector-V2] WebHook Sink Connector

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Implement a WebHook Sink Connector use the SeaTunnel Sink API.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I want to try it.

I want to try it.

Ok

cc @Hisoka-X

Hi all guys, I think this work I should implement http sink using new connector api, right? If not, do you have some help imformation about it? @EricJoy2048 @Hisoka-X

Hi all guys, I think this work I should implement http sink using new connector api, right? If not, do you have some help imformation about it? @EricJoy2048 @Hisoka-X

Yep, use new connector api to implement it.

pr #2348, please review. @CalvinKirs @EricJoy2048 @Hisoka-X


"S" : Stag all unstaged files, doesn't work

"S": Stag all unstaged files, doesn't work

Works fine for me. Can you may provide more details?

I work for mine too.
Actually, my keyword was changed to some other language, that's why it didn't work.
Sorry for creating this issue.


[Doc] Enhance Documentation for Inviting Users to Set Password During User Creation

Describe the issue:
The current documentation titled "Invite user to set password" lacks detailed information on the full path of inviting a user to set a password during the user creation process. The documentation mentions prerequisites but does not provide step-by-step instructions on how to complete the flow.
Doc: https://is.docs.wso2.com/en/next/guides/account-configurations/user-onboarding/invite-user-to-set-password/
2:In the current documentation titled "Invite user to set password," there is a misalignment between the content of the "Parameters" table and the provided screenshot.
Related to : IS 7.0 Onprem

The detailed information on the full path of inviting a user to set a password during the user creation process is available at the manage users doc. Please refer https://is.docs.wso2.com/en/next/guides/users/manage-users/#onboard-users


[silgenpattern] Fix two ASAN errors.

rdar://problem/49609717

@swift-ci asan test

NOTE: The second commit doesn't have any added tests since the tests we already have were asserting with asan enabled.

@swift-ci smoke test

I tested this with asan locally. Everything passed. Merging!


Map new repo structure to existing files

I've created an excel table to map out the new repo structure to existing files on both repos:
https://thealanturininstitute-my.sharepoint.com/:x:/g/personal/gaitkenhead_turing_ac_uk/EbjW3Llz1YhFkrjU-USjSCoBcmqokPYnWWhUFRcLo54Y5A?e=kozsPl
Take a look when you're ready @BrainonSilicon, @Islast
HackMD here: https://hackmd.io/5h3WMC3kT1u_nVKLPURTKw
Due by 31st August

There are a whole lot of technical files in different places on the AutSPACEs repo I'm not sure how to map or organise

I think this will probably be a substantial piece of work as we will need to update all the links as we go and a lot needs updating. But it will be great to have a new, neat and well organised repo, not just for ongoing co-working but for posterity!

Closing this issue as it is a duplicate created by transferring issues across repos


Job configuration page layout and JS issue in Chrome

Here's how the page looks like here:

The error while trying to parse dates is:

vue:6 TypeError: Cannot read property 'length' of null
at wn.eval (eval at Ya (vue:6), :3:3901)
at wn.e._render (vue:6)
at wn.r (vue:6)
at fn.get (vue:6)
at new fn (vue:6)
at vue:6
at wn.$mount (vue:6)
at wn.$mount (vue:6)
at wn.t._init (vue:6)
at new wn (vue:6)

Caused by this:
https://github.com/bamotav/Hangfire.RecurringJobAdmin/blob/master/src/Hangfire.RecurringJobAdmin/Dashboard/Content/css/JobExtension.css#L4

I've got the same problem and it seems that the fix can solve it

I also have the same problem.


[android] 'Stop and Delete Data' from Transfers does not delete .torrent file

Tested on
FW Basic 1.6.8 build 227, Samsung S4/Android 5.0.1 with no SD Card. Downloading to Internal, Folder Downloads & default.
FW Plus build 226 & 228, Sony Xperia Z2/ Android 5.1.1. Downloading to SD Card & Internal default locations
Behavior
Choosing 'Stop and Delete Data' from Transfers does not delete .torrent file
Steps to Reproduce

Tap Download on anything from BitTorrent
Go to Transfers
Tap on actively downloading file & select 'Stop and Delete Data' >  tap OK on 'Are you sure you want to cancel this download (downloaded data so far will be erased)?

Additional Observations

The same thing happens on both phones
The same thing happens when downloading to SD Card or Internal Memory
Cloud Downloads delete correctly

Duplicated, coping this description to Issue #41


lack of semi-colons breaks bootstrap js files when tethering

When using bootstrap across a tethered connection at least one js file stops working.
The reason is that many providers (o2, t-mobile, vodafone) across the world embed another js script into web pages. The script is called bmi.js.
This file helps compress many separate js requests into the main page.
The lack of semi-colons in the dropdown js file causes this compression to break, and the dropdown menus stop working on any device if the device is tethered.
The fix is simple: just use semi-colons.  The line that breaks is
    clearMenus()
    !isActive &&  ...

Are you saying your compressor doesn't add semicolons? that's crazy. You should use a new one! (yui, google closure, uglify.js)

Just to be clear: it is not my compressor.
The bmi script is inserted by our evil mobile ISPs - there is nothing one can do to prevent it!  (Other than VPN).
So it definitely is worth fixing if you want bootstrap end users to be able to use bootstrap while they are tethered.

if your js isn't being compressed, then the following is valid:
  clearMenus()
  !isActive && ....

Oh wait... i'm just now understanding... hm... so these devices inject a javascript file which does on the fly "compression" -- and this "compressor" isn't adding semicolons, but is removing new lines?

I'm running into the same issue with the default JS min for Java's WRO.
I don't see why semi-colons aren't used to begin with. Your point isn't invalid (that a good compressor should account for this when removing line breaks) but I can't for the life of me see why you would avoid semi-colon usage here.
You're trading the stability of the framework in unknown environments for a couple hundred (if that) bytes of space saved. Is there some other reason semi-colons aren't being used?

Stylistically it may be a preference, syntactically it may be perfectly valid, but in practice it causes real-world issues. I would appreciate re-consideration on your semi-colon policy.

I'm just curious why this issue get closed.
Is it solved, or invalid?

The reason it was closed is because semicolons were added to the end of lines in 1.4. In 2.0 we removed them again when we introduced the downloader as it safely concats and minifies these files for you.

Please don't take them out again. Stylistic preference or not, it would seem the wiser choice is to use them in a library meant for such a broad audience. I'm really glad to see you've reached the same conclusion for this particular issue.

+1 for semicolons

our distributed JS files contains semicolons @elimin8r 😉


Remove -XX:+PerfDisableSharedMem

@uschi2000

Coverage remained the same at 99.408% when pulling 6c8524c415a3b2dc6ff3b340fec590812bef7b6a on me/say-no-to-perf into 9b239a385a24c7c3c4bba9fce906219eb279b51a on develop.

+1


Add 'stalled' tag

For use in cases when admins lost contact with event's host, or for TTT
events that are no longer running.
WIP: we need to remove stalled events from EventQuerySet filter for unpublished events. So this PR is depending on #567.

What's the UI for adding a tag?  I.e., where and how do I do it once
these is merged?

In here:

(Event edit form)

+1

@gvwilson review, please and thanks!

@gvwilson I just thought about something. Do you only want a "stalled" tag, or do you want an interface for viewing people from stalled events too?
If you only need to see all the events marked as "stalled" (and perhaps "TTT"), you'll be able to do so on All Events page thanks to filters.

@gvwilson "Instructors with Issues" ( ;) ) now shows stalled trainees too.

I'm having trouble following the logic here - if Jane did instructor training at an event in January 2014 (now marked as "we're giving up"), and also took part in instructor training in July 2015 (which is not marked as "we're giving up"), but does not yet have an instructor badge, she should show up as "we need to contact her to see if she's going to complete".  On the other hand, if she only took part in the January 2014 event, she should not show up as "we need to contact her".  Does this PR do that?

@gvwilson:

[…] Does this PR do that?

Probably not yet, so let me implement that!

@gvwilson can you please check if this is what you want?

:+1:


Is there equivalent methods for Universal platform as LoadLibrary to load KMDF coinstaller?

WdfPreDeviceInstallEx is marked as targeting Universal platform. However, LoadLibrary() only supports Desktop platform.
Is there equivalent methods for Universal platform as LoadLibrary to load KMDF coinstaller?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df54170d-d7eb-e83a-1bea-1428063bd329
Version Independent ID: f7ebdef3-8cc3-058d-2184-0d7b51764843
Content: WdfPreDeviceInstallEx function (wdfinstaller.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdfinstaller/nf-wdfinstaller-wdfpredeviceinstallex.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Which OS version(s) will your driver support?

I am working to make a pure Universal project. It includes driver/service/UWP. Hopefully to be compliant to Win10 S-mode and future universal Win10.
I ran APIvalidator on my console app with LoadLibrary and it didn't report error on LoadLibrary. It seems it is Universal. However, I ran APIvalidator on WdfCoInstaller01011.dll and it reports dependency on several SetupApi functions and result is not-universal.
Is WdfCoInstaller01011.dll really Universal?

So will the driver only support Win10 and later?

Yes.

Hi @guliteb, to support Win10 and later, we recommend using KMDF 1.15 without coinstaller. You should not need to reference WdfCoInstaller01011.dll from a universal driver.

@tedhudek , I am looking for a way to install/load non-PnP driver using an installer application. From the docs, it is recommended to use wdfcoinstaller to install non-PnP driver. Is there a new way in KMDF 1.15 to install non-PnP driver without using wdfcoinstaller?
This is the link I refer to:
https://docs.microsoft.com/en-us/windows-hardware/drivers/wdf/installing-a-non-pnp-driver

You should be able to use the same approach as https://github.com/Microsoft/Windows-driver-samples/tree/master/general/ioctl/kmdf, but simply remove all the co-installer references, for example:
#define NONPNP_INF_FILENAME  L"\\nonpnp.inf"
#define WDF_SECTION_NAME L"nonpnp.NT.Wdf"

LoadWdfCoInstaller
UnloadWdfCoInstaller

PFN_WDFPREDEVICEINSTALLEX pfnWdfPreDeviceInstallEx;
PFN_WDFPOSTDEVICEINSTALL   pfnWdfPostDeviceInstall;
PFN_WDFPREDEVICEREMOVE     pfnWdfPreDeviceRemove;
PFN_WDFPOSTDEVICEREMOVE   pfnWdfPostDeviceRemove;

For non-pnp KMDF driver, simply call SCM API to create service is good enough.
I'll update https://docs.microsoft.com/en-us/windows-hardware/drivers/wdf/installing-a-non-pnp-driver with this info soon.


proxy: fix stats deadlock caused by await code

specifically the WSTAT_DECR in proxy_await.c's return code could potentially use the wrong thread's lock

This is why I've been swapping c with thread as lock/function arguments all over the code lately; it's very accident prone.
Am reasonably sure this causes the deadlock but need to attempt to verify more.

There're two paths for this bug:

Wrong thread lock is used, which could cause the number to go weird.
Thread changes inbetween the lock and unlock calls, so it would lock one mutex then never unlocked it, or unlock a previously locked mutex.

I got it to reproduce off of next once synthetically but it's not happening a second time. Hoping to get it reproducing a bit better so I can validate the patch before merge...

Finally reproduced on next. fix seems to be holding so far.

Fixed another bug I found while trying to reproduce the initial bug...


Add postponed requeuing and credentials exist status condition

RequeueAfter the configurable period if the credentials secret or the trusted CA configmap not found. This helps to greatly reduce the number of repeating error logs.
CredentialsSecretExists status condition is added to signal a missing secret.
Bonus: bug in the platform detection - error if the check for the operator.openshift.io API group fails

/lgtm

Just a squash of the commits

/lgtm

/assign @quarterpin

/retest
Infoblox temporary licences expired, had to recreate the test instance.

/retest

/retest
Wrong grid hostname was setup on the test Infoblox.

/retest
Self signed certificate didn't have infoblox DNS in SAN.

/lgtm

/label qe-approved

/label docs-approved

/label px-approved


It would be better to update the record of csv file preview in Release Notes because of adding delimiter control in tabular preview

Storage Explorer Version: 1.29.0
Build Number: 20230425.6
Branch: rel/1.29.0
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.3.1 (Apple M1 Pro)
Architecture: ia32/x64/arm64
How Found: ad-hoc testing
Regression From: Not a regression
Steps to Reproduce

Open Release Notes -> Go to 'In-App Preview Improvements' part.
Observe the record of preview csv file.

Expected Experience
It would be better to update the record because of adding delimiter control in tabular preview.
Actual Experience
Can't see the delimiter control from current record.

Verified this issue on the build 20230426.6. Fixed. So, we are going to close it.


Database

Remove json and replace it with a sqlite database using Diesel. Create, Read and Delete works. Only thing left to do is Update(with ui etc).
Why am I doing a pull request when I can just merge this directly in my terminal?
Sometimes you gotta confuse yourself to stay sharp

remove dotenv later, and use dirs crate to put db in home directory....


Allow Optimizers as input to VQEProgram

Summary
Fixes #289.
Details and comments
Dictionaries are still supported since some tutorials first need to be updated to use optimizers.

So this is a feature rather than any bug fix then. I see you put a high priority label on the issue which is why I am asking. As a feature this would go out in the next release unless somehow its creating critical problems/issues out there now. I assume you will be updating the optimization repo equivalently. If we need these to stay the same out there so users can use the one in Nature and/or the one in Optimization the same way then I guess things need to be coordinated/sorted out, since I presently would have expected a Nature release in advance of the next Optimization one - unless we start talking bug fix releases.

It would be better to get this out before the next feature release, right, so it seems more like a bugfix 😉 I synced with @pbark and looks like we can do a minor release soon.


Parity bug on Jumper

Describe the bug
PARITY BUG. movement does not work on console, only on web editor.
To Reproduce
Steps to reproduce the behavior:

https://sprig.hackclub.com/gallery/Jumper
run on hardware, press a key to start game, and press I to select "start"
Press w
run on web, and repeat 2/3
observe difference in behavior

Expected behavior
The player should move between the 3 rows as on the web version.
Actual behavior
The player is stuck within the bottom row.
Screenshots
If applicable, add screenshots to help explain your problem.

@Sheepy3 Per our conversation the other day, this issue is not accepted as it does not meet the criteria for an actionable issue - this could simply be a flaw in the application's coding as opposed to an actual parity concern.  Please feel free to reopen if after investigating further one finds a specific actionable parity issue, I just do not want to get into the habit of implicitly trusting that app parity issues are platform bugs, necessarily.


Sidebar works on iOS, but fills the entire screen on Android

Describe the bug
When I start my Android app, the entire thing is filled with the sidebar
To Reproduce
Steps to reproduce the behavior:

Create app with sidebar
Run it on Android

Screenshots

Platform:

OS: Android
React Native version: .62?
Library Version: 1.3.2

It was due to setting my menu at 999 zIndex, which apparently didn't cause an issue on iOS but did on Android


allow assignment in condition for fgetcsv

Bug Description
fgetcsv reads the file line by line, thus we need to assign the data to a variable in the condition like:
while ( ( $data = fgetcsv( $handle, 0, ',' ) ) !== false ) {

However this triggers:
WordPress.CodeAnalysis.AssignmentInCondition.Found
Variable assignment found within a condition. Did you mean to do a comparison?
Minimal Code Snippet
while ( ( $data = fgetcsv( $handle, 0, ',' ) ) !== false ) {
    echo $data;
}

Tested Against develop branch?

[x] I have verified the issue still exists in the develop branch of WPCS.

@kkmuffme IMO, this is not an issue.

The sniff actually has a separate error code for while conditions so if there are good reasons for it, you can selectively exclude that specific error message.
This code can be rewritten to a do-while construct without assignment in condition.

thanks I am aware I can disable a rule, however for fgetcsv it ALWAYS has to be disabled in a while loop.
I think this cannot be rewritten without making the code longer & ugly. Bc in a do while loop the reading would happen after the first iteration, thus be empty & not the same thing.

The handbook now contains the rule that assignments in conditions are not allowed.
It's perfectly fine if you don't want to comply and you clearly know how to exclude a rule, but that is not a reason to adjust the sniff.

So there is no valid way to process files/csv with fgetcsv, if you want to adhere to the WPCS?
Isn't this clearly a bug?

@kkmuffme There are perfectly valid ways to do this, such as the do ... while I suggested, which may be a little more verbose, but will work perfectly fine. In other words: this is not a bug.


Make SignatureBouncer tests independent

They are currently using a before block and thus share the same Bouncer instance. Naively changing before to beforeEach results in broken tests, so there must be some interdependence.

Closing as duplicate of #1021.


Build site to /workers prefix

Build gatsby application and run a postbuild step to nest every URL to /workers.  This has been tested on
https://workers-docs.cloudflare-docs.workers.dev, and I've verified that the sitemap.xml file generated by Gatsby also nests URLs correctly.
BTW, this is a simplified version of what we have in https://github.com/cloudflare/workers-docs 👍

Marking this as a draft until we have a working deployed demo at https://workers-docs.cloudflare-docs.workers.dev/workers/.

This is ready for review and testing @adamschwartz @davidtsong @rita3ko

Going to be pushing up a new branch to replace this shortly.


[Proposal] Ordering Traits

Lets say I've included two traits within my class and I want to order them by name.
Before:
use SerializerTrait, DispatchesJobs;

After:
use DispatchesJobs, SerializerTrait;

Don't know if this will be a problem PHP-wise? Otherwise it would make a good feature.

I think this might change the behavior of the code if 2 traits are defining a method with the same name

If two traits insert a method with the same name, isn't a fatal error is produced? If the conflict is not explicitly resolved?
http://stackoverflow.com/a/25064632/4801875

I would like to see trait equivalents of MultipleUseFixer and OrderedUseFixer (namespace usages).
use SerializerTrait, DispatchesJobs;

// After MultipleUseTraitFixer
use SerializerTrait;
use DispatchesJobs;

// After OrderedUseTraitFixer
use DispatchesJobs;
use SerializerTrait;

Yeah a fatal error is thrown so the order of the traits shouldn't have an impact.

:+1: for feature, but it also must support aliasing and resolving conflicts.

bit similar but we could also order the interfaces a class implements by name...

Bump

@JarJak the best way of getting this implemented is to have a crack at it yourself! If you need any pointers feel free to as in the Gitter chat


Anchore Engine Analysis reporting vulnerabilities in the sink and not source of the issue

Is this a request for help?:

Is this a BUG REPORT or a FEATURE REQUEST? (choose one):
BUG REPORT

Version of Anchore Engine and Anchore CLI if applicable:
Anchore- CLI - v 0.8.2
What happened:
We are building Kafka enablers for the microservice to consume as a dependent jar to enable websocket connection.
Kafka enabler i.e. Kafka-enabler-SNAPHOT-0.0.1.jar uses Confluent rest-util package as dependency which in turn uses Jersey v2.29, Jetty v9.4.30, and Hibernate Validator.
When running Anchore scan post building an image from the Kafka enabler, Anchore Engine, does not report any vulnerabilities in the jars used by the enabler itself. Report Output below:

Method used to convert Kalfka enabler jar to Image for Anchore scanning:

When Anchore scan is run against the microservice e.g. Test client which consumes the enabler, it reports following vulnerabilities:

Vulnerabilities reported are valid i.e. true positive
What did you expect to happen:
We expected that when we build an image from Enabler and run Anchore scan, Anchore should have reported the vulnerabilities as it reported when enabler was added as dependency to another microservice. Reason being the vulnerable jars are actually dependencies in Kafka enabler which is the true source of the vulnerabilities.
Any relevant log output from /var/log/anchore:
What docker images are you using:
openjdk:8-jre-slim
How to reproduce the issue:
Step 1: Create a jar using confluent rest-utils package v6.1.1
Step 2: Convert to docker image as shown above and trigger an Anchore Scan.
Step 3: Add the jar created in step 1 to any microservice's build.gradle file as a dependency.
Step 4. Build new jar from Step 3.
Step 5: Create a docker image from jar created in step 4 and trigger an Anchore scan
Anything else we need to know:
The remediation to the issue is also interesting:
Case 1: When Jetty, Jersey related jars were upgraded in Kafka enabler which is the source of the vulnerability, Anchore still reported the vulnerabilities in microservice i.e. Test Client and none in Kafka enabler
Case 2:  When Jetty, Jersey related jars were upgraded in Test client i.e. microservice which consumes the enabler, Anchore stopped reporting the vulnerabilities in microservice i.e. Test Client and none as usual in Kafka enabler:
In order to fix the vulnerabilities, all the microservice consuming this enabler have to modify thier build.gradle to below screenshot. Instead of the Kalfka enabler who is the source of the vulnerabilities.

@zhill - Kindly look into the issue

@swetan27 Can you clarify what version of anchore-engine you are using? I see for version you put
Anchore- CLI - v 0.8.2

To clarify is that the version of the cli or engine?
If it is the version of engine, we have since made a number of changes/enhancements to our image analysis. Most notably as of engine v0.9.0 we use syft for the bulk of our image content analysis. We also have fixed some issues related to java analysis in patch releases since v0.9.0 so an update to the most recent release version of v0.10 could resolve the issue if you are using v0.8.2


: fix compile failed on jdk15

Codecov Report

Merging #39 (faa7a5e) into release-1.1.0 (b471d61) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-1.1.0      #39   +/-   ##
================================================
  Coverage            27.57%   27.57%
  Complexity             141      141
================================================
  Files                   53       53
  Lines                 1922     1922
  Branches               139      139
================================================
  Hits                   530      530
  Misses                1349     1349
  Partials                43       43

Impacted Files
Coverage Δ
Complexity Δ

...ross/account/service/account/UniversalAccount.java
13.76% <ø> (ø)
4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b471d61...faa7a5e. Read the comment docs.

Codecov Report

Merging #39 (faa7a5e) into release-1.1.0 (b471d61) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-1.1.0      #39   +/-   ##
================================================
  Coverage            27.57%   27.57%
  Complexity             141      141
================================================
  Files                   53       53
  Lines                 1922     1922
  Branches               139      139
================================================
  Hits                   530      530
  Misses                1349     1349
  Partials                43       43

Impacted Files
Coverage Δ
Complexity Δ

...ross/account/service/account/UniversalAccount.java
13.76% <ø> (ø)
4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b471d61...faa7a5e. Read the comment docs.


Region selection issues after most recent update

It seems that some users are having issues being connected to the correct OBA server, which I believe started after the most recent app update was pushed out.
We're seeing messages from users that are getting directed to the OBA Tampa "Contact Us" email address, while the user's location in the email is in Puget Sound.  This shouldn't be happening, since if the below location was used to choose the region, then the email should have been directed to OBA Puget Sound's "Contact Us" email address.  I'm guessing the app is setting the region based on a bad first location fix, and then populating the email with a location that it grabs later.
Example feedback:

When I try to look up a stop that I use frequently, the app is saying that the stop isn't found. And when I look up stops by number, the app says that they are out of the service area.
App Version: 2.2.1
Device: iPhone5,3
iOS Version: 7.0.4
Current Location: 47.732867, -122.292577

My app keeps reporting out of service area even though it's been updated. Suggestions?
App Version: 2.2.1
Device: iPhone6,1
iOS Version: 7.1.1
Current Location: 47.633476, -122.341165

cc'ing @haneys @sheldonabrown

calling this fixed for now after 2.4.1.


Remaining Problems on Binary Search #919

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
Problems:

Frequency of an element in a sorted array.
Find the number of times array has been rotated.
Find the element in the rotated sorted array.

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Issue: #919
Fill up the DCP form
If you are a part of DCP 21, fill up this form after the PR is merged.
The links provided in the form will be checked thoroughly, if someone tries fooling around, strict actions will be taken against the individual.

Please review @smv1999


[BUG]not a bug, ask for solution：ppo zero3+offload generate too slow

Hi, when I ran ppo with llama-13b (prompt_len=256, answer_len = 512) with zero stage 3 and offload (8*V100-32G), it seems the generation time is too slow (average about 20s-300s). Currently, I consider the reason of generating slowly is using zero stage 3 with open synced_gpus, but it consumes a lot of resource if I do not use this. Is there any solution for solving this problem? Thanks a lot!

same problem


Add reinstall script

Fixed #148

Download:
Environment: QT=5.12, ARCH=64, PYTHON_PATH=C:\Python35-x64
installer/autoinstall.zip
installer/trik-studio-installer-master-x86_64.exe
trik-studio-master_qt5.12_x86_64.zip
Environment: QT=5.12, ARCH=32, PYTHON_PATH=C:\Python35
installer/autoinstall.zip
installer/trik-studio-installer-master-i686.exe
trik-studio-master_qt5.12_i686.zip

Download:
Environment: QT=5.12, ARCH=64, PYTHON_PATH=C:\Python35-x64
installer/trik-studio-installer-master-x86_64-auto.zip
installer/trik-studio-installer-master-x86_64.exe
trik-studio-master_qt5.12_x86_64.zip
Environment: QT=5.12, ARCH=32, PYTHON_PATH=C:\Python35
installer/trik-studio-installer-master-i686-auto.zip
installer/trik-studio-installer-master-i686.exe
trik-studio-master_qt5.12_i686.zip


feat: liking users

Implemeting liking users endpoint.
See Twitter Announce here

Currently having 404 when adding user field parameters.
See issue on the twitter forum here


Introduce suite generate repo <repo_name>

It will be nice to have a command that you can run to initialize a new monorepo environment.
This command will generate boiler plate and setup the environment according to our microservices-suite file structure with an initial server and frontend up running on 2microservices.
The command will be as simple as suite generate repo
The command will be interactive just like npx create-react-app

This feature has now been added in our latest version. Users can now scaffold a new monorepo interactively with suite generate


Disallow reading from Delta Lake tables in hive connector

why?

why?

because it works anyway, just in a cryptic way

@findepi I assume you meant to say that it fails?

@findepi I assume you meant to say that it fails?

It depends. For partitioned tables it will return 0 results (as partition information is hold in transaction log). For non-partitioned tables it will fail while executing query (in metastore table doesn't have serde defined so it defaults to SEQUENCEFILE).


Putting a dead mob in a mob duplicator crashes the server

Industrial Foregoing Version: 1.12.13
TeslaCoreLib Version: 1.0.15
Crashlog (If Any): crash-2019-12-08_21.45.06-server.txt
If you use a mob imprisonment tool on a dead mob, it will store a mob with 0HP. If you put the MIT into a mob duplicator, it will crash the server then and whenever the server restarts with it active from that point.

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.


Yarpviz imported in yarp

Yarpviz has been imported in YARP on devel branch.
It will be available on master from release 2.3.72.
More information on how to compile it inside YARP can be found here.
Enjoy :wink:

One day we should provide an easy way to install the Graphiz on Windows x64, possibly through vcpkg.

Relative vcpkg issue: https://github.com/Microsoft/vcpkg/issues/737 .


Caffe data layer to MXIter converter

Supply prototxt for caffe model's data layer and it is created with an MXNet data iterator interface.  In additioin, added caffe-converter-tool converted caffe model to json file loading in caffe_net.py

@piiswrong @HrWangChengdu could you please have a look?

Note: I also have made changes to CMakeLists to optionally:

build the caffe plugin
build caffe if it is in directory "caffe" under mxnet (i.e. by a symbolic link)
These are not part of this review but I can push those as well, if desired.

Caffe plugin option for cmake is good and should be added.
Building caffe together with mxnet will cause users to ask us about caffe build errors... Let's keep them separate for now.

Comments addressed

Addressed comments except the ProdShape() ones that I didn't understand

I will add caffe plugin CMakeLists.txt changes in a separate review after this review


create or patch rbac objects

What this PR does / why we need it:
In our monitoring stack, we've been noticing that each reconciliation from the fluentbit controller results in three 409 errors. See image below:

I believe this change fixes that, though understand you might have different thoughts on implementation, so happy to hear them!
Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

In our monitoring stack, we've been noticing that each reconciliation from the fluentbit controller results in three 409 errors. See image below:

Nice catch @HarleyB123
Are the metrics from the fluent operator itself? scraped from which path?

In our monitoring stack, we've been noticing that each reconciliation from the fluentbit controller results in three 409 errors. See image below:

Nice catch @HarleyB123 Are the metrics from the fluent operator itself? scraped from which path?

Thanks! This is from the fluent operator itself, path is port :8080/metrics, the failed HTTP requests is the rest_client_requests_total, but filtered where the code !2** (not a 2xx HTTP response)


Support CUDA version>121

Hi,
Got error message of
/opt/conda/envs/ptca/bin/python: Error while finding module specification for 'onnxruntime_genai.model.builder' (ImportError: libcublasLt.so.11: cannot open shared object file: No such file or directory)

Replicate:
Install wheel:
pip install onnxruntime-genai-cuda --pre --index-url=https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/onnxruntime-genai/pypi/simple/

CUDA Version: 12.2
Command: python -m onnxruntime_genai.model.builder --help
When using CU118, there's no such issue, do we support CU12+?
Thanks.
FYI:
/usr/local/cuda-12.1/lib64//usr/local/cuda-12.1/lib64/libcublas.so.12

The current pre release version (rc4) and the version we plan on releasing (0.1.0) will have support only for cuda 11.8.
You will need to build from source if you want support with cuda 12+.

Do you know when 0.1.0 will be released ? Thanks

Probably early next week.

Great! Thanks.

@baijumeswani , from PyPI, I can only find cpu version of package onnxruntime-genai==0.1.0, will we also publish cuda version one, like onnxruntime-genai-cuda==0.1.0? Thanks!

You can also find the instructions here: https://onnxruntime.ai/docs/genai/howto/install.html


sweethome3d: fix startup issue and upgrade JDK

Description of changes
Fix SH3D startup issue caused by inability to find libGL.
Fixes #270010
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 284982 run on x86_64-linux 1

3 packages built:

sweethome3d.application
sweethome3d.furniture-editor
sweethome3d.textures-editor


Cash on tflite::Interpreter::AllocateTensors()

I'm trying to make an audio classifier as android YAMNet with C++ language on JNI, however, I got the crash on tflite::Interpreter::AllocateTensors. And my tflite version maybe 2.3.
Here is my code snippet
  bool YAMNet::Classify(const std::vector<float> &wave_data, const int sample_rate,
                          const int top_k, std::vector<Recognition> &recognitions) {

        static const int kDefaultSampleRate = 16000;// Hz
        if (kDefaultSampleRate != sample_rate) {
            Trace_Err("Error: YAMNet input must be 16kHz.");
            assert(false);
            return false;
        }

        std::vector<int> input_tensor_indices;
        input_tensor_indices = interpreter_ -> inputs();
        interpreter_->ResizeInputTensor(input_tensor_indices[input_index_of_wave_],
                                        {1, (int)wave_data.size()});

        interpreter_->AllocateTensors();
...

And then, I got the crash as following:
2021-01-27 18:15:36.478 20012-20012/com.tomato.ketchup A/libc: Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x28 in tid 20012 (.tomato.ketchup), pid 20012 (.tomato.ketchup)
2021-01-27 18:15:36.839 20012-20055/com.tomato.ketchup E/ketchup: ###### CSeedUdp::ProcessSend sendto() failed, errno=101(Network is unreachable), fd=58
2021-01-27 18:15:36.859 20105-20105/?  A/DEBUG: Build fingerprint: 'xiaomi/wayne/wayne:9/PKQ1.180904.001/V<IP_ADDRESS>.PDCCNXM:user/release-keys'
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG: Revision: '0'
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG: ABI: 'arm64'
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG: pid: 20012, tid: 20012, name: .tomato.ketchup  >>> com.tomato.ketchup <<<
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG: signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x28
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG: Cause: null pointer dereference
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x0<PHONE_NUMBER>000000  x1<PHONE_NUMBER>000000  x2  0000007c4b800000  x3<PHONE_NUMBER>000004
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x4<PHONE_NUMBER>000096  x5  0000007c633a3848  x6  00003e8000000001  x7  00003e8000000001
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x8<PHONE_NUMBER>000000  x9  0000007c3abfe358  x10<PHONE_NUMBER>0000d9  x11 0000007c4b896650
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x12<PHONE_NUMBER>000008  x13<PHONE_NUMBER>000000  x14<PHONE_NUMBER>000011  x15<PHONE_NUMBER>000001
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x16 0000007c4fa760f0  x17 0000007c4f973910  x18 00000000ffffffff  x19<PHONE_NUMBER>000000
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x20<PHONE_NUMBER>000000  x21 0000007c4b86ff80  x22 0000007c4fa25993  x23<PHONE_NUMBER>000000
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x24<PHONE_NUMBER>000000  x25<PHONE_NUMBER>000000  x26 0000007cf1aaa5e0  x27 0000007c4fa71a08
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     x28 0000007c3abfe360  x29 0000007fdb66e470
2021-01-27 18:15:36.859 20105-20105/? A/DEBUG:     sp  0000007fdb66e410  lr  0000007c4f974fc4  pc  0000007c4f975018
2021-01-27 18:15:37.182 20105-20105/? A/DEBUG: backtrace:
2021-01-27 18:15:37.182 20105-20105/? A/DEBUG:     #00 pc<PHONE_NUMBER>235018  /data/app/com.tomato.ketchup-V1Z97Zn_3BrgXuDk3RSqeA==/base.apk (offset 0xedbb000) (tflite::Subgraph::ModifyGraphWithDelegate(TfLiteDelegate*)+252)
2021-01-27 18:15:37.182 20105-20105/? A/DEBUG:     #01 pc<PHONE_NUMBER>238b98  /data/app/com.tomato.ketchup-V1Z97Zn_3BrgXuDk3RSqeA==/base.apk (offset 0xedbb000) (tflite::Interpreter::AllocateTensors()+220)

Dose anyone have any idea on this?

Could you try the tf-nightly version instead to follow the original blog post?

Could you try the tf-nightly version instead to follow the original blog post?

Hi Sun,
This mem segfault issue is likely fixed by https://github.com/tensorflow/tensorflow/commit/849682d6a03d571df1cb3c854c2aa44806afe381, could you try a version beyond this commit? like tf-nightly? It looks like this fix isn't included in tf2.4 release based on the 2.4 branch code

Hi Sun,
This mem segfault issue is likely fixed by https://github.com/tensorflow/tensorflow/commit/849682d6a03d571df1cb3c854c2aa44806afe381, could you try a version beyond this commit? like tf-nightly? It looks like this fix isn't included in tf2.4 release based on the 2.4 branch code

Well cool, 2.4 branch solved the problem. However, there are some performance problems being arise. I'm trying to struggle with them, and I will call for help on other issue if I need, thanks for all.


ci: use repository owner for e2e builds

Signed-off-by: Thomas Schuetz<EMAIL_ADDRESS>

Codecov Report

Merging #330 (63c8f81) into main (a8f58a4) will increase coverage by 0.30%.
The diff coverage is 66.66%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #330      +/-   ##
========================================
+ Coverage   5.03%   5.34%   +0.30%
========================================
  Files          9      11       +2
  Lines        794     936     +142
========================================
+ Hits          40      50      +10
- Misses       749     879     +130
- Partials       5       7       +2

Impacted Files
Coverage Δ

scheduler/pkg/klcpermit/permit.go
0.00% <0.00%> (ø)

operator/controllers/common/interfaces.go
45.83% <100.00%> (ø)

operator/controllers/common/spanhandler.go
70.00% <100.00%> (ø)

scheduler/pkg/klcpermit/workflow_manager.go
11.23% <0.00%> (ø)

Flag
Coverage Δ

scheduler
4.52% <0.00%> (+4.52%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.


Not working with Angular 6

After upgrading from Angular 5 to Angular 6 this directive stopped working. All I see in the log is dat it depends on specific (older) module versions. This was already the case when using Angular 5 and there the tooltips worked fine. Is there anything I can do to make de directive work with Angular 6?

@Bram77 please try version 2.1.5


Files with ansi character code 0x80 to 0x9F in file name can not be retrieved

If I add the file meshes/goldbarrel01œ.nif to a ansi.BSA and load the BSA with the library, the file can not be retrieved.
Pseudo-code:
    bsa::tes4::archive bsa;
    const auto version = bsa.read("ansi.BSA");
    const auto file = bsa["meshes"]["goldbarrel01œ.nif"];
    // file is NULL

I debugged the _map and the file is there but for some reason the hash in the map seems to be different than the one calculated for the input filename. This is how the hash in the bsa::tes4::archive looks, note how 'last' and ' last2' don't correspond to the filename.
◢ | first | {_hash={last=0x73 's' last2=0xb1 '±' length=0x0d '\r' ...} _name={ index=2, value={d=0x000001abcad90054 "goldbarrel01œ.nif" f=shared_ptr {_handle={file=0x000000000000025c file_mapping_object=0x0000000000000260 base_address=0x000001abcad90000 } ...} [0x00000006 strong refs, 0x00000001 weak ref] [make_shared] } } } | const bsa::components::key<bsa::tes4::hashing::hash,&bsa::tes4::hashing::hash_file_in_place>
  | ◢ _hash | {last=0x73 's' last2=0xb1 '±' length=0x0d '\r' ...} | bsa::tes4::hashing::hash
  | last | 0x73 's' | unsigned char
  | last2 | 0xb1 '±' | unsigned char
  | length | 0x0d '\r' | unsigned char
  | first | 0x67 'g' | unsigned char
  | crc | 0xc5e4b8c0 | unsigned int
  | ▶ _name | { index=2, value={d=0x000001abcad90054 "goldbarrel01œ.nif" f=shared_ptr {_handle={file=0x000000000000025c file_mapping_object=0x0000000000000260 base_address=0x000001abcad90000 } ...} [0x00000006 strong refs, 0x00000001 weak ref] [make_shared] } } | std::variant<std::basic_string_view<char,std::char_traits<char>>,std::string,bsa::detail::istream_proxy<std::basic_string_view<char,std::char_traits<char>>>>

NOTE: it looks like this ONLY affects characters with Codes between 0x80 and 0x9F, other files like meshes/goldbarrel01à.nif can be retrieved, in the following map the first two entries can't be retrieved, the last one can:
▶ | [{_hash={last=0x73 's' last2=0xb1 '±' length=0x0d '\r' ...} _name={ index=2, value={d=0x00000262f5c00074 "goldbarrel01œ.nif" f=shared_ptr {_handle={file=0x0000000000000258 file_mapping_object=0x000000000000025c base_address=0x00000262f5c00000 } ...} [0x0000000e strong refs, 0x00000001 weak ref] [make_shared] } } }] | {...} | std::pair<bsa::components::key<bsa::tes4::hashing::hash,&bsa::tes4::hashing::hash_file_in_place> const ,bsa::tes4::file>
▶ | [{_hash={last=0xac '¬' last2=0xb1 '±' length=0x0d '\r' ...} _name={ index=2, value={d=0x00000262f5c00086 "goldbarrel01€.nif" f=shared_ptr {_handle={file=0x0000000000000258 file_mapping_object=0x000000000000025c base_address=0x00000262f5c00000 } ...} [0x0000000e strong refs, 0x00000001 weak ref] [make_shared] } } }] | {...} | std::pair<bsa::components::key<bsa::tes4::hashing::hash,&bsa::tes4::hashing::hash_file_in_place> const ,bsa::tes4::file>
▶ | [{_hash={last=0xe0 'à' last2=0xb1 '±' length=0x0d '\r' ...} _name={ index=2, value={d=0x00000262f5c00098 "goldbarrel01à.nif" f=shared_ptr {_handle={file=0x0000000000000258 file_mapping_object=0x000000000000025c base_address=0x00000262f5c00000 } ...} [0x0000000e strong refs, 0x00000001 weak ref] [make_shared] } } }] | {...} | std::pair<bsa::components::key<bsa::tes4::hashing::hash,&bsa::tes4::hashing::hash_file_in_place> const ,bsa::tes4::file>

Please see this note about utf-8 inputs. The game can't retrieve this file either.

To be clear, this is not a bug in this library. The game engine has an 18 year old bug where extended ascii characters (0x80-0x9F) produce junk hashes. The game will never be able to retrieve these file paths, and any user facing application should reject non-ascii file paths.

Thanks for your quick answer, so the library just replicates the buggy engine code? Does it mean ansi characters from code points 0×A0 to 0xFF do work also in the engine or is it just by chance, the last2 character also seems to be wrong, see above, but the file can be retrieved via the library

This library does what Bethesda's code is supposed to do, if it weren't bugged. Files names with characters in the extended ascii range absolutely do not work in Bethesda's virtual file system. Their archive tool, and the game engine will generate different hashes for the same file paths (with extended ascii characters). The hash generated can also vary across versions of the game due to the nature of the bug. Any hashes generated by the game, or the archive tool for these file paths should be considered garbage.

I believe file hashes are stored inside esp files, so loose files will probably encounter the same issue; that being the creation kit and the game will generate different file hashes for the same file name (with extended ascii characters).

I should also clarify that this only affects characters in the range 0x80-0xFF. Bethesda's algorithm to remap characters to lowercase for case insensitive hashing assumes ascii inputs, but it is at least consistent in how it remaps 'positive' (0x00-0x7F) characters.


[1.11.2] Storagedrawers and Mekanism crash

Placing a Drawer next to a Mekanism Mechanical Pipe crashes the server.
crash log: https://hastebin.com/gijinejifa.cs
Mekanism-1.11.2-<IP_ADDRESS>5
forge-1.11.2-<IP_ADDRESS>0
StorageDrawers-1.11.2-4.2.7

Report to StorageDrawers.


Example of Infi in yolov3

Hi, I just read your paper in ACM MobiCom ’22, It's a very impressive work. Now I am looking for a way to compress the YOLO model in our work, and the data in your work is attractive.
Could you provide an example code of implementing Infi in YOLOV3? It would definitely help me a lot  : )

I can provide an example using yolov3, which dataset do you prefer to test? If no preference I will use release a video clip used in our previous evaluations.

@yuanmu97 Thanks for your reply! I don't have a preferred dataset, you can post any example, mainly because I just want to see how the Yolo model can be linked to the infi framework.

You're welcome. This is my first time maintaining an open-source project, thank you very much for using it! I will update an example this week.

I just updated an example with YOLOv3 on video frames, please check examples/video*.
I sampled 1k frames for this example and you can download it from https://drive.google.com/file/d/11kkeuLd4PRYL7rpjal5ralAqxrr-hr7W/view?usp=sharing
Hope it can help.

Thanks for your example, it did help.


js_match.test is not a function

Hello,
I've just configured express-minify an i get the following error:
Express server listening on port 3001
/foo/node_modules/express-minify/index.js:66
      } else if (js_match.test(contentType)) {
                          ^

TypeError: js_match.test is not a function

My conf is:

var minify = require('express-minify');
var myUglifyJS = require('uglify-js');
var myCssmin = require('cssmin');

app.use(cookieParser());
app.use(compress());
app.use(minify({
    uglifyJS: myUglifyJS,
    cssmin: myCssmin,
    js_match: config.root + '/public/js/',
    css_match: config.root + '/public/css/',
  }));

I believe to be a bug with express-minify, but i'm also new to js, so i might not be right.
Thanks!

Hi, you need to specify a regular expression for js_match and css_match.
In addition, those two options (including other xxx_match as well) match content-types instead of URLs, which means it will minify any URLs ended with .js or .css.


terminal errors when using webpack with mysql

Trying to use Webpack with the mysql package results in webpack doing very curious things that cause it to terminate:

require-all is not supported by webpack, because it's not statically analysable.
This could be addressed by the mysql package author, but I think the mysql package would still not be browser-compatible.

If possible, seeing that reason reflected in the error/warns would be quite welcome, so that users understand why things are going wrong and have agency to figure out ways around it, rather than not understanding what's really going wrong.

@Pomax There is going to be a good deal of modules that will not run in a browser, mysql is one of them. As certain operations don't have a functional equivalent in the browser, net, tls and fs which are typically provided by Node.js on the server and which the error above indicates: Cannot resolve module.

right, so: it would be a great idea to make sure that webpack generates a useful error in these cases, instead of saying "critical dependencies" and "unknown token". Those are not the kinds of error that let users figure out what's wrong so they can fix the problem themselves.

@Pomax What error messages would you suggest? Keeping in mind, webpack only knows it cannot resolve the module or the module you're trying to load isn't valid JS.
It doesn't know that the module you're trying to load isn't web compatible. I think it is a fairly safe assumption that a developer using mysql should know that MySQL does not run in a web browser and it's not webpack's responsibility to inform users of that.

Hm, those are two different errors.

"cannot resolve module" error when the module doesn't resolve makes sense,
2."invalid JS encountered for bundling: [module name] - server-side/binary modules are not supported" when it hits JS that relies on binaries or non-browsers APIs?

"invalid JS encountered for bundling: [module name] - server-side/binary modules are not supported" when it hits JS that relies on binaries or non-browsers APIs?

Currently when it hits invalid JS the error says: "You may need an appropriate loader to handle this file type". As it is possible to load non-JS files, you just need an appropriate loader that can convert the file to valid JS. Such as one could readmeContents = require('md-loader!./readme.md').
So we can't assume any invalid JS the user is trying to load is a server-side/binary module that isn't supported.

We actually totally can: those loaders need to kick in for require calls with an extension that is not .js, as requires without extensions and requires ending in .js are plain module imports. So it should be entirely possible to throw one kind of error when the js branch (implicit or not) goes wrong, and the "you need a loader" error for when the "with-extenion" branch goes wrong.

Loaders are not based upon the file extension. I can do require('md-loader!./readme.js') or require('md-loader!./readme').
In addition, there are shorthands omitting the file extension and third party modules do not use file extensions require('some-package').
As well as the user can also set a loader based upon their own regex (not the file extension):
module: {
  loaders: [
    { test: /matchThisRegex/, loader: 'md-loader' }
  ]
}

So all webpack can do is try and load the module then throw when it fails to parse.

right, but this error is cropping up for regular requires, so it doesn't make a lot of sense to use loaders as a reason not to add a more specific error during parse runs where this can be detected. Full solution? No. Better solution than now? Most definitely.

I'm totally with you on better error reporting, I think that would be great. I'm just failing to help you understand that what you're asking for is not technically possible.
Just for fun, I opened up Firefox and tried to do: <script src="node_modules/mysql/index.js"></script>. It gave me the error "ReferenceError: exports is not defined". Not a very helpful error. Should it be Firefox's responsibility to let me know the script I'm trying to load isn't compatible with the browser? Or is that error message technically impossible and as a developer, I should just know better?
Maybe I'm totally wrong though. Feel free to send a PR that can check if a module is web compatible and delivers a better error message indicating so. Cheers!

I'm confused, why are you firing up Firefox? This is about errors in the terminal, during the webpack compile step...? We never even get to a point where we can even look at something in the browser.

Is this issue relevant still?

Hm, no idea. Although I've clearly not run into it for almost two years so my guess is "no".

Ok, let's close then.


Test protocol version 2

Change the default protocol version, so that we get a CI run. Not to be pushed yet! Not until the new storage version has been rolled out to all regions and we are confident we will not need to roll back anymore.

In case something will not go well we would have to revert image which is labor-intensive. May be rather set that setting as a default value for some region for a few days? That way we quickly revert that behavior (still would need to restart bunch of pods, to pick up old value, but that is more or less straightforward).
Id suggest following:

enable new proto on staging in all regions: https://console-stage.neon.build/admin/regions/aws-us-east-2/settings, wait 2 days
start enabling it in prod regions east to west

Yeah, I'm not suggesting to merge this PR, this is just to get a CI run with the new protocol version. Agreed that rolling out region-by-region is a good plan.

PR #7377 was closed, and the testing with this PR is done. Closing.


docs: removed period from headline

Description

As already discussed, removed the period from headline.
Removed a second level heading from blogs index.
Added a bit of margin to the heading as it wasn't looking very spacious after eliminating the subheading.
This is what it looks like now:

Fixes #471

Thank you @sambhavsaxena , code LGTM 🚀


Write a C++ program to implement selection sort

Description
Write a C++ program to implement selection sort
Selection sort is a sorting algorithm that selects the smallest element from an unsorted list in each iteration and places that element at the beginning of the unsorted list.
Pseudocode
procedure selection sort
   list  : array of items
   n     : size of list

   for i = 1 to n - 1
   /* set current element as minimum*/
      min = i

      /* check the element to be minimum */

      for j = i+1 to n
         if list[j] < list[min] then
            min = j;
         end if
      end for

      /* swap the minimum element with the current element*/
      if indexMin != i  then
         swap list[min] and list[i]
      end if
   end for

end procedure

Example
Input  : [8, 5, 2, 6, 9, 3, 1, 4, 0, 7]
Output : [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

How to contribute

Comment !assign to assign this issue to yourself
Fork this repository
Create a new branch
Save the solution in program/program/implement-selection-sort/ImplementSelectionSort.cpp
Commit the changes
Create a pull request

!assign

!assign

!assign

!assign


Dosen't do anything

As in the title, launching the wrapped instance does absolutely nothing diffrent from vanilla, inf-20100325 blackscreens after pressing "Create" in the world generation screen, same with any version before it, sometimes the world loads but any movement attept makes it go to the blackscreen.
EDIT:
After updating GPU drivers (Nvidia, game ready driver) if minecraft is left on the black screen for too long (earlier nothing happend) it starts trying to render something, when that eventually fails it crashes and soon the whole computer follows, with an error code that seems to refernece some issue with graphics buffer/GPU RAM

Hi @Miki200v2, is the crash a vanilla bug, and does it still happen with the latest version of RetroWrapper? I don't think RetroWrapper has any patches for graphics bugs, but I could look into some new patches.

Hi @Miki200v2, is the crash a vanilla bug, and does it still happen with the latest version of RetroWrapper? I don't think RetroWrapper has any patches for graphics bugs, but I could look into some new patches.

I'll check when I'm back home, that is, in around 2 hours

No problems! Let me know when you can.

Hey @Miki200v2 and @StereoMadnessss, as this issue is fairly old and I can't reproduce it, I'm closing it as stale. If this is still an issue with the latest version of RetroWrapper, please re-open this issue! I'd especially like to know if this is a vanilla bug, and the contents of the Minecraft logs. Even if it's a vanilla issue, I'd be happy to make a patch for it if I knew some more details about it.


Added support for Emby Media Server

Description:
Added support for the Emby media server. The file is based off of the plex support, as the 2 systems are very similar.
Pull request in home-assistant.io with documentation (if applicable): https://github.com/home-assistant/home-assistant.io/pull/732
Example entry for configuration.yaml (if applicable):
:media_player
  platform: emby

Thanks for putting this together, I've been hoping for native Emby support for a little while now.  Putting the formatting issues aside, I just tested this out and all seems to work fine.  It would be nice to add the host and api-key fields into the configuration.yaml rather than needing an external file though.

I completely agree that it would be nicer to have it in configuration.yaml, and I will probably update it when I get more into python and HA. At the time I made this plugin, I had installed HA the day before, and this plugin was my first experience with Python.
The code is mostly from the Plex plugin. I merely made the EmbyRemote class to call the Emby api's instead of Plex.
I have other plugins in mind that I will be creating, but those are for hardware devices which aren't very popular, so they'll likely only be used by myself. But you never know.. Anyway the point being that I plan to get very acquainted with HA and python, and by that time, I will probably revisit this plugin (although I don't really know what I'd change that I don't know how to at the moment, as you said - it's working).

By the way, I recently noticed that I'm not showing any picture when playing TV episodes. I will probably correct that soon.

@Inrego This pull request appears to be stale, so I am closing it. Please re-open it if you plan to fix the above mentioned issues. Thanks!