Vega.jl not run in Julia 0.6

julia> Pkg.test("Vega")
INFO: Computing test dependencies for Vega...
INFO: Installing DataArrays v0.6.2
INFO: Installing DataFrames v0.10.0
INFO: Installing FileIO v0.5.1
INFO: Installing GZip v0.3.0
INFO: Installing RData v0.1.0
INFO: Installing RDatasets v0.2.0
INFO: Installing SortingAlgorithms v0.1.1
INFO: Testing Vega
WARNING: deprecated syntax "abstract AbstractVegaType" at C:\Users\user.julia\v0.6\Vega\src\primitives/definetypes.jl:2.
Use "abstract type AbstractVegaType end" instead.
ERROR: LoadError: LoadError: UndefVarError: call not defined
Stacktrace:
[1] include_from_node1(::String) at .\loading.jl:569
[2] include(::String) at .\sysimg.jl:14
[3] include_from_node1(::String) at .\loading.jl:569
[4] include(::String) at .\sysimg.jl:14
[5] anonymous at .<missing>:2
while loading C:\Users\user.julia\v0.6\Vega\src\primitives/definetypes.jl, in expression starting on line 3
while loading C:\Users\user.julia\v0.6\Vega\src\Vega.jl, in expression starting on line 30
ERROR: LoadError: Failed to precompile Vega to C:\Users\user.julia\lib\v0.6\Vega.ji.
Stacktrace:
[1] compilecache(::String) at .\loading.jl:703
[2] _require(::Symbol) at .\loading.jl:490
[3] require(::Symbol) at .\loading.jl:398
[4] include_from_node1(::String) at .\loading.jl:569
[5] include(::String) at .\sysimg.jl:14
[6] process_options(::Base.JLOptions) at .\client.jl:305
[7] _start() at .\client.jl:371
while loading C:\Users\user.julia\v0.6\Vega\test\runtests.jl, in expression starting on line 3
================================[ ERROR: Vega ]=================================
failed process: Process('C:\Users\user\AppData\Local\Julia-0.6.0\bin\julia.exe' -Cx86-64 '-JC:\Users\user\AppData\Local\Julia-0.6.0\lib\julia\sys.dll' --compile=yes --depwarn=yes --check-bounds=yes --code-coverage=none --color=yes --compilecache=yes 'C:\Users\user\.julia\v0.6\Vega\test\runtests.jl', ProcessExited(1)) [1]
================================================================================
INFO: Removing DataArrays v0.6.2
INFO: Removing DataFrames v0.10.0
INFO: Removing FileIO v0.5.1
INFO: Removing GZip v0.3.0
INFO: Removing RData v0.1.0
INFO: Removing RDatasets v0.2.0
INFO: Removing SortingAlgorithms v0.1.1
ERROR: Vega had test errors

Yes, this is known from #130 as well as on the README. If this is something you are interested in fixing, I'd happily accept a pull request

Hello, i don't know how i'd be process and what do i do

The process is to make a fork of this repository into your own account, fix all the issues that Julia complains about until it runs again. However, if you're not familiar with this process, this might not be the best issue to start with, as the code Julia is complaining about is a bit low-level and hard to understand

I pushed the necessary fixes to master, will tag a new version for METADATA when the testing scripts pass

you're right, i'm unfamiliar with the process and I'm just starting to learn, I needed to work with graphics and I want to use Vega.jl, however i'll try to learn more about it, thanks a lot


Verify implementation against security proofs

What & Why
As a first step on formally verifying the correctness of our Hydra Head implementation, we want to create property tests corresponding to the security proof in the paper to test various parts of the implemented protocol using the same rationale.
TBD

At what level in our testing strategy?
Which proofs exactly / scope?

Maybe we should start with a spike on this one to understand better what we could possibly do in this regards.


[Image Build Phase] Modularize dependencies.sh for faster builds

Is your feature request related to a problem? Please describe.
During stage base, the script _build/images/base/scripts/dependencies.sh gets executed with a single RUN statement.
This means that if the script fails at some point, the whole script has to be re-executed without any partial result caching.
In the current state, the script is quite long running, containing tasks like:

Basic APT setup
Adding Firefox PPA
Preparations for VSCode (add APT repo)
Install additional APT Packages (add APT repo)
APT Update/Upgrade
Git Proxy Setup
Download/build/install Boost from source
Download/build/install OpenROAD
Install PIP packages
Cleanup to minimize image size

Describe the solution you'd like
By modularizing the dependencies.sh script into multiple RUN invocations, build and debugging times can be drastically sped up.
Directory _build/images/base/scripts/dependencies contains:

apt_base_install.sh
apt_add_firefox_repository.sh
apt_add_vscode_repository.sh
apt_update_upgrade.sh
apt_additional_pkg_install.sh
git_proxy_setup.sh
boost_install.sh
openroad_install.sh
pip_pkg_install.sh
cleanup_image.sh

If this is of interest and a go, I'd suggest we schedule this refactoring after the pending commits or PRs are merged, to avoid conflicts.

I agree on this, we should modularize the base package dependency.sh script.
Altough I think we should still keep a rather small number of run commands in the Dockerfile, or else we just make a lot of quasi-empty layers. More or less should there be a separate "RUN" in the Dockerfile for each long running command of the dependencies.sh, so we can make use of caching efficiently.
My suggestion:
base_setup.sh includes the quick stuff before the huge apt install, like repo adding etc. Maybe also install git here and configure the proxy if needed.
apt_install_upgrade.sh does the long running apt install. and update/upgrade stuff.
install_<pkg>.sh for each base package, I suggest a separate script. Debugging those package builds can otherwise be a huge hassle.
finalize.sh contains the rest of the stuff.

I merged https://github.com/iic-jku/IIC-OSIC-TOOLS/pull/26 so we could do a try.
Before we start, one question to the Docker experts here: If we do the cleanup step in a different RUN step, is the stuff really removed from the final image? We should not have a situation where we add stuff in one layer, remove stuff in another layer, and the image still as the later-removed contents.
For the further builds this is no large issue, as we selectively copy things into the final image/layers, but for the base there should not be things blowing up the download or image size.
2nd, we should name the stages like
10_base_setup.sh
20_apt_install_upgrade.sh
3x_install<pkg>.sh
40_finalize.sh
so there is really no confusion about the sequence :-)

If we do the cleanup step in a different RUN step, is the stuff really removed from the final image?
It is definitively not visible in the final image, but AFAIK if files are created in one run, and deleted in another, they are still in the lower layer, but marked as deleted in the upper layer.
For that, I suggest we distribute the steps from finalize, that cleanup files to the corresponding script where those files are created.

Is someone already working on this
I can start doing it now, as I'm currently working on repairing some builds that require changes in the base package.

I finished the modularization of the base installs. It is in the next_release branch.


Improve token address page

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind backend-change
/kind ui-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #1664

Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Please change page title to
"{Token Name} ({Symbol}) Token Tracker | iotexscan"


15092 - add more restoration endpoints

Issue #: /bcgov/entity#15092
Add the following endpoints:

/limitedRestorationToFull
/limitedRestorationExtension
/fullRestoration
/limitedRestoration

By separating restorations to different endpoints, we can keep the code cleaner and easier to read.
Caution, this change will break existing functionality until business-filings-ui makes a similar change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Looks fine but why are we doing this? How will it keep the code cleaner and easier to read?

It's becoming clear that limited restorations conversions will have different logic from limited restoration extensions.  For example, as Karim has mentioned in 455, limited restoration extensions require a call to the stateFiling endpoint.  We could add multiple v-if but I think it would be better to use separate endpoints and separate the logic flow once at the route level.

Looks fine but why are we doing this? How will it keep the code cleaner and easier to read?

It's becoming clear that limited restorations conversions will have different logic from limited restoration extensions. For example, as Karim has mentioned in 455, limited restoration extensions require a call to the stateFiling endpoint. We could add multiple v-if but I think it would be better to use separate endpoints and separate the logic flow once at the route level.

I like that answer 👍


UI: better alignment of overview-screen

Reference: https://dashtalk.org/threads/v12-testing-thread.5484/page-96#post-61259
Before:

After:

Works for me just like it shown above but only when there is a "watch-only" column, otherwise looks a bit different, but still ok imo

I know, but you can't tell CSS whether "watch-only" is there or not. We have to live with that, at least for now.

Yep, not complaining, just making a note :)


wsl2 won't start working?

Version
Microsoft Windows [版本 10.0.19044.1387]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
When I type wsl in the windows power shell, the following error pops up, how do I fix it?

Expected Behavior
Working correctly
Actual Behavior
nsenter: failed to parse pid: '77
78'
[已退出进程，代码为 1]
Diagnostic Logs
No response

Do you have some custom script which runs after WSL2 distro starts?

@cuixing158: Are you using https://github.com/arkane-systems/genie ?

Sorry for the late reply to you guys, I've fixed the problem by restarting now. I did install this systemd script before this in order to install the gnome desktop, I don't know if this affected it.

Yes, this is being caused by the unsupported systemd script you are using.

Sorry for the late reply to you guys, I've fixed the problem by restarting now. I did install this systemd script before this in order to install the gnome desktop, I don't know if this affected it.

我也用了这个，然后一样的报错。请问您如何解决的，只需重启wsl就行吗


Prevent iD Editor in restore page, dialog Leave page? doesn't work

Please prevent iD Editor in restore page, I pressed by mistake F5 and dialog window Leave page? doesn't prevent from restoring page. Thanks

Hey @AF-HAF-KARTOGRAF it sounds like this is an issue for https://github.com/openstreetmap/id. I will close it here. Please add a new issue over there. Please add a step by step of what is wrong in your opinion and how it should behave, that will make it easier to understand your ticket.


Add WAL Projections

This pull request introduces changes to support WAL (Write-Ahead Log) projections in the Sequin system. The main updates include:

Added WAL projection functionality to the message handler, allowing it to process and store WAL events alongside existing consumer events.

Modified the WalEvent schema to use wal_projection_id instead of source_replication_slot_id and source_table_oid.

Updated the Replication module to support listing and managing WAL events for specific projections.

Refactored the Health module to include WAL projections as a new entity type for health checks.

Updated database migrations to create the wal_projections and wal_events tables with the new schema.

Modified tests to reflect the new WAL projection structure and functionality.

These changes enable the system to handle WAL projections alongside existing consumer types, providing a more flexible approach to data replication and event processing.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#353
#352  👈
#350
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


Automatic after open html.com pletion. AttributeDefaultValue tip failure

Automatic after open html.com pletion. AttributeDefaultValue tip failure

Can you please explain more what the problem is?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


feature request: generic replacement for the paperclip emoji?

As mentioned in the blog post announcing this effort, the paperclip emoji was omitted as, since it was based on Clippy, it couldn't be released for legal reasons.
However, the lack of metadata could cause problems for other projects using this repository as a source of checked/production-ready metadata and it's somewhat unfortunate to have a missing emoji; therefore, would it be possible to include a generic variant instead (possibly based on the dual-paperclip emoji)?
(Side note, but thank you so much for letting us use these wonderful emoji sets 😄)

I think a generic replacement for the technologist emoji would be nice too. Just removing the Windows logo would remove the legal issues.

Thanks for the suggestions - this is definitely being considered.


Hello, kata name Highest and Lowest bug

My python code:
def high_and_low(numbers):
num_list = list(map(int, numbers.split()))
return print(f"'{max(num_list)} {str(min(num_list))}'")
When im tested this code all logs same with answers, but test not passed... wish this will fix.

Kata specific issues should be reported in kata discourse (here, not here on this board. This board is used for tracking issues related to Codewars platform, and not specific kata.
Your code is incorrect. Your last line does not return what it should return. Kata is good, your solution is wrong.
Regards

You can read this paragraph of FAQ for some hints. One of bullet points there describes your problem.
Also read this part of manual on how to post your code.

I told you i'm started from:
return max(num_list), min(num_list)
to:
print(f"'{max(num_list)} {str(min(num_list))}'")
yes i fogot "" but its still dosent work! log with answers is same !!!
try it by your self and watch log!

@IvanShadrin-97 You're confusing print and return - please see this StackOverflow post for the difference between the two.
Anyway, as @hobovsky mentioned, Kata-related questions and/or issues should be directed to the Discourse page of the Kata itself instead of this GitHub repo.


Status is being reported as "0" in emails (Old 336)

In gitlab by @A-Lawrence on Aug 31, 2015, 01:07
Whenever status is output, it's displayed as 0, rather than ACTIVE.

In gitlab by @A-Lawrence on Aug 31, 2015, 01:11
Resolved.  Database edits.
ALawrence66 - 2015-08-25T00:07:06.433518+00:00

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #292

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #293

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #294

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #295

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #296

In gitlab by @A-Lawrence on Aug 31, 2015, 01:18
mentioned in issue #297


Support __half in histogram

This PR addresses the following issue. Since there's another histogram related PR, I've tried to keep changes to the dispatch layer minimalistic.

Approved pending minor fixes and retesting.


Try macos-14

Good to see you’ve jumped on this!
The process I used to run (see my last cross-compilation script) used an x86_64 base compiler (standard sources) to build a cross-compiler x86_64-x-aarch64 from iains’s sources, then to use that to build the native aarch64 compiler. I don’t do that now, because I already have an aarch64 compiler (here’s one, if it’s useful).
The script above is a little outdated.
Please ignore the above if you’re well past this point!
I noticed that the build is using Xcode 15.0, which may well fail to link; and until we have GCC 14, Xcode 15.1 may result in misbehaving exception handling. See my fix.

I’ve always used contrib/download_prerequisites to install gmp &c sources with the compiler and build in-line. Avoids issues with which arch to use!

@simonjwright
I guess Fabien will do the actual build, but I can't resist trying :)

@simonjwright Did you get something like this ? I've got this during linking of gprbuild :(

ld: library not found for -lcrt0.o

I'm wondering whether it thinks it's built a cross-compiler? the "failed command" should have included `-lSystem"

I think it’s to do with gprbuild’s Makefile thinking it’s building in a cross- environment. See the 'Notes/Other sources' section in this README -- I’m not sure about the Xml/Ada changes, they don’t seem to have been needed.
I never reported these Makefile issues, but then the lack of response on gprbuild issue #141 isn’t encouraging. Still, may as well try ...

I just rebuilt GCC 13.2.0 & Gprbuild 24.0.0 without any of my patches and there were no problems.
Mind you, I used an updated build script for GCC ...

I've just downloaded the build, and I see you're well ahead of me! Congratulations!

this was merged upstream :partying_face:


Revendor swarmkit to 4bdf7c0506c37bcb19b9a48693909be01e85e53c

This fix revendor swarmkit to 4bdf7c0506c37bcb19b9a48693909be01e85e53c
The following PRs in swarmkit and docker are related:
https://github.com/docker/swarmkit/pull/1271 (docker PR #24993)
https://github.com/docker/swarmkit/pull/1766
https://github.com/docker/swarmkit/pull/1767
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

TestCleanupMountsAfterDaemonAndContainerKill failure is tracked in https://github.com/docker/docker/issues/28687
https://jenkins.dockerproject.org/job/Docker-PRs-experimental/27192/console

#28728 updates to newer version and already in merge status :)
@yongtang thanks!


Unable to recognize element type in a tuple when the tuple is built from zip

 Environment data

Language Server version: 2023.4.10
OS and version: darwin arm64
Python version: 3.9.12 (miniconda py39_4.12.0)
python.analysis.indexing: true
python.analysis.typeCheckingMode: off

 Code Snippet

def func(i: int):
    # return the integer, and whether it is an even number
    return i, (i % 2 == 0)

nums, evenQ = zip(*[
    func(i) for i in range(10)
])

 Expected behavior
The type of nums and evenQ should be recognized as tuple[int, ...] and tuple[bool, ...], respectively.
 Actual behavior
But Pylance only label them as tuple[int | bool].

You can see the type definition for zip by right clicking on it and selecting Go to declaration. This will take you to the typeshed stub builtins.pyi. Note that zip is an overloaded function, so it has multiple signatures.
Unfortunately, the Python type system isn't able to fully express the behavior of zip in all cases. The type definition handles most cases, but there are situations when the star operator is used where it causes type checkers to produce the wrong results. This is a known issue, but it's not clear that there's any good solution short of making changes to the Python static type system.


Only /hello as command

Everything worked until the command. When I type "/" it does not come "givemebadge" but only "hello". When I type "/hello", the links also come, as seen in the video. However, I do not get the status that I have collected the badge, but it is still output that I am not authorized.

huh?

As you can see in the tutorial video, when you start the bot over the terminal, you can write /givemebadge in you discord server as an command in chat. But when my bot is running, I can use only /hello instead of /givemebadge. Anyway when I trigger /hello the same messages arrive in the chat window as you can see in the tutorial video when your using /givemebadge. But when Im clicking the link https://discord.com/developers/active-developer there is still the message "You are not eligible for the Active Developer Badge".

Fair enolugh, I need to fix my video to only show /hello then, but that one you have to ask in https://discord.gg/discord-developers as the script is made to do the job, however if the Discord system says otherwise, that is sadly out of my control.

Well than I don't get this. I thought I just need to follow the introductions an than I can claim it. I made everything as me told in the video.
Thanks anyway for your effort!


"does not contain bitcode" on openSSL

Hey, after adding the /include/ folder to the Header Search Paths I got this beautiful thing here:
ld: '/Users/Alex/Desktop/Folder/Project/RMStore/Optional/openssl-1.0.1e/lib/libcrypto.a(asn1_lib.o)' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture armv7
I know it's rather openSSL-related and there are even issues on that on some SSL gits but all you guys must've come across this once so I thought you might know what's going on here.
Any ideas on that? And I don't really plan to deactivate bitcode for my whole project --___--
Cheers
Alex

You don't need OpenSSL if you're not doing receipt verification. If you don't need receipt verification, remove it and it should be good.
If you do need receipt verification, you'll have to disable bitcode for your project. It's a downside of importing OpenSSL.

Is this still true? I have an app that uses WatchKit, and thus needs to have Bitcode enabled. Does that mean RMStore just isn't going to work for me?

Try utilizing the code here that was refactored to be able to use dynamic frameworks in swift (which should enable bitcode support as well) :
https://github.com/robotmedia/RMStore/pull/178
However, I get the feeling this project isn't seeing too much activity these days. While it still works, I wouldn't expect support on issues unless the community has found a way around it and published the fix (like in that PR).

Just build OpenSSL for iOS yourself, I don't like the idea for this repo providing them as binary to start with anyway.
Here is what I did:

I downloaded OpenSSL-for-iPhone.
Build using: ./build-libssl.sh --version=1.0.1e --archs="arm64 armv7 armv7s i386" --noparallel modify architectures as needed.
Replaced the libraries that come in this repo.

Hope it helps!
Sal


Correct delivery_mode typo in properties list

Just a simple typo fix for the list of available properties in the Message docstring.

Thanks!


Column aliases ignored when distinct is used

Describe what is not working as expected.
Consider the following query:
var efforts = await (from se in _context.StudentEfforts
  join te in _context.TeacherEfforts on se.ReportingPeriodClassId equals te.ReportingPeriodClassId
  join ef in _context.Efforts on se.EffortId equals ef.Id
  join tt in _context.Teachers on te.TeacherId equals tt.Id
  join rpc in _context.ReportingPeriodClasses on se.ReportingPeriodClassId equals rpc.Id
  join cc in _context.Classes on rpc.ClassId equals cc.Id
  where rpc.ReportingPeriodId == periodId
    && se.StudentId == studentId
  select new {
      Teacher = tt,
      ClassId = cc.Id,
      ClassName = cc.Name,
      Effort = ef.Name,
      EffortId = ef.Id,
      TeacherGraded = te.Grade,
      StudentGraded = se.Grade
  }).Distinct().GroupBy(ef => ef.ClassId).ToListAsync();

Will generate the following SQL Code in which the aliases are ignored in the outer select, causing an invalid column name error.
exec sp_executesql N'
SELECT [t].[Id], [t].[Code], [t].[DateOfBirth], [t].[Email], [t].[FirstName], [t].[Gender], [t].[GenderId], [t].[IdentityId], [t].[LastName], [t].[MiddleName], [t].[Mobile], [t].[Title], [t].[ClassId], [t].[ClassName], [t].[Effort], [t].[EffortId], [t].[TeacherGraded], [t].[StudentGraded], [t].[Id], [t].[Name], [t].[Name], [t].[Id], [t].[Grade], [t].[Grade]
FROM (
    SELECT DISTINCT [tt].[Id], [tt].[Code], [tt].[DateOfBirth], [tt].[Email], [tt].[FirstName], [tt].[Gender], [tt].[GenderId], [tt].[IdentityId], [tt].[LastName], [tt].[MiddleName], [tt].[Mobile], [tt].[Title], [cc].[Id] AS [ClassId], [cc].[Name] AS [ClassName], [ef].[Name] AS [Effort], [ef].[Id] AS [EffortId], [te].[Grade] AS [TeacherGraded], [se].[Grade] AS [StudentGraded]
    FROM [StudentEfforts] AS [se]
    INNER JOIN [TeacherEfforts] AS [te] ON [se].[ReportingPeriodClassId] = [te].[ReportingPeriodClassId]
    INNER JOIN [Efforts] AS [ef] ON [se].[EffortId] = [ef].[Id]
    INNER JOIN [Teachers] AS [tt] ON [te].[TeacherId] = [tt].[Id]
    INNER JOIN [ReportingPeriodClasses] AS [rpc] ON [se].[ReportingPeriodClassId] = [rpc].[Id]
    INNER JOIN [Classes] AS [cc] ON [rpc].[ClassId] = [cc].[Id]
    WHERE ([rpc].[ReportingPeriodId] = @__periodId_0) AND ([se].[StudentId] = @__studentId_1)
) AS [t]',N'@__periodId_0 int,@__studentId_1 int',@__periodId_0=2,@__studentId_1=610

However removing the Distinct() from the query generates working SQL code

@ajcvickers Sorry, I have corrected the query and added the Distinct() where it should have been.


Deployment Stack - Resource deletion order

Bicep version
Bicep CLI version 0.28.1 (ba1e9f8c1e)
Describe the bug
Running a command like Remove-AzSubscriptionDeploymentStack -Name 'imageStack' -DeleteAll -Verbose -Force for a Deployment Stack of the same name seems not to consider certain contraints when it comes to the order of resource deletion.
In the given case I'm deploying (amongst other things) a User-Assigned Identity + an Image Template to which the same is attached. When removing these resources again, it is vital that the User-Assigned Identity is removed after the Image Template as the same otherwise ends up in a non-removable state. This looks like this:

In the terminal you get a stuck command (which does not respond to cancelation keys like Ctrl + C) like
> Remove-AzSubscriptionDeploymentStack -Name 'imageStack' -DeleteAll -Verbose -Force
VERBOSE: Performing the operation "Deleting Deployment Stack ..." on target "imageStack".

This is just one example of many and the reason why we implemented a very specific removal order & logic in the AVM CI.
Naturally, I do not know how Deployment Stacks handle removals in the background as suspect it just runs a removal on the Resource Group or similar. Regardless, the logic may need to be update to be more granular (and ideally also handle purge protection, etc.). Happy to talk through some of the things we identified in CARML & AVM over the years and logic we implementated for the same.
Until these issues are not addressed we won't be able to replace our current removal logic with Deployment Stacks.
To Reproduce
Steps to reproduce the behavior:
It should be enough to deploy the MSI + Image Template (alongside any required resource) - OR - if you want to test with the full example, deploy this template with updated parameters for unique resources like the ACR & StorageAccount, and using the command New-AzSubscriptionDeploymentStack -Name 'imageStack' -Description 'This is a first test deployment using Deployment Stacks' -Location 'WestEurope' -TemplateFile '(...)\constructs\azureImageBuilder\deploymentFiles\sbx.image.bicep' -Verbose -TemplateParameterObject @{ deploymentsToPerform = 'All' } -DenySettingsMode 'None', followed by the eventual removal command.
Additional context
PS: Fundamentally a very cool feature though (:

@AlexanderSehr Do you have a Correlation ID of the DELETE request?
If I understand the scenario correctly, the DELETE of the image template fails because the managed identity is already gone - is that correct? If so, does that make logical sense to you as a customer? I'm asking because I'm not very familiar with image templates, but I would have expected the image template deletion to succeed regardless of MSI state.

Hey @snarkywolverine,
I hope you're well. You can find the deployment of the original stack via this correlation ID: 83067d53-1a92-4d07-ad22-13f6b4ce4490. Note that it shows an unrelated error at the late stage of the deployment, which is due to a networking issue and is not linked to the issue I describe above.
Instead, the issue came up following the deployment by running the Deployment Stack removal.
It may appear I did not do a great job in describen the order of events in my original posting, leading to some confusion. Sorry for that, but I shall try again:
For context: The ImageTemplate resource takes a user-assigned identity and effectively uses it to create some Azure resources to build an image and that's it. It's the only requirement it really has.
 If that happens the following things are true:

The Image Template cannot be deleted (anymore)
It shows an error message that it cannot find the MSI (see above)
If you try to remove it you just get stuck in a loop and eventually Azure gives you a timeout
To unblock this state you have to run a specific CLI command that unassigns the original MSI from the resource (az image builder identity remove) and then you can remove it like nothing happens
Alternatively, you can simply remove the Image Template first - and then the MSI.

Does that make sense to me as a customer? No, certainly not 😄. It's just the way the resource is implemented and sure it would be nice if the corresponding PG 'fixes' that issue. However, it's just one of many many resources that face similar issues (e.g., diagnosticSettings, container-groups, role assignments, etc.) in that the order of removal and that they're explicitely removed matters. It's the sole reason we put so much work in our own CI in the BRM repository and declared an explicit order for resources that we know must be removed in set order.

@snarkywolverine do we know if the RG delete algorithm accounts for some of these behaviors and/or does Bulk Delete allow for any sequencing?

The behavior I know when it was previously explained to me is that the order does not matter as deployment stack retries deletion operation multiple times until succeeds or certain time out is reached. So if you have dependent resources eventually their dependencies (if present in the stack) will get deleted. The above error sounds like the RP implemented some custom logic that requires resources to be deleted in some order in order to be able to delete them. This is not something RPs should implement.


Updated return types for some of the ob_ functions

Some of the inspection plugins (e.g. EA Extended) will emit a warning if the type casting is not necessary, which will generate false warning in cases for the signatures updated here, like this one:

Function descriptions already contain "... or false if ...", just the type itself does not include it.
Also, false is a valid return type to use, but I've noticed that just bool is used in other similar cases, hence string|bool here, too. I'd prefer string|false though, because true will never be returned.

Although I'm not a fan of |false unit type, I think it's the correct one for internal PHP functions (that return falseon error and never return true otherwise). Using |bool breaks static analysis (PHPStan) as both true and false would have to be covered.

@Majkl578 Agreed. Would you prefer to have these updated as string|false then (not sure if the comment was meant to be a requirement or just a note)?

+1 for |false

Note that using |true/|false is explicitly allowed by phpDoc. :blush:


io.flutter.raster (9): EXC_BAD_ACCESS when using ExternalTexture on Mac

Hi,
while trying to implement my FlutterWebGL plugin on Mac which uses an external texture I ran in this exception here:

It only happens on current master and dev channel
´´´
[✓] Flutter (Channel master, 2.1.0-11.0.pre.122, on macOS 11.2.1 20D74 darwin-arm, locale de-DE)
• Flutter version 2.1.0-11.0.pre.122 at /Users/escmoteur/Entwicklung/flutter
• Framework revision 8a1204f0b6 (6 days ago), 2021-03-04 23:34:03 -0500
• Engine revision 299eb3e710
• Dart version 2.13.0 (build 2.13.0-104.0.dev)
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.4, Build version 12D4e
• CocoaPods version 1.10.0
´´
you can reproduce by cloning this repository and running the example
https://github.com/FlutterGL/flutter_web_gl/tree/EXC_BAD_ACCESS-in-objc_retain

@escamoteur Is this a Metal validation error? It has been fixed on master and it should go away locally if you disable Metal API validation in the Xcode run scheme. If, OTOH, you are able to reproduce this without API validation, then we may be looking at a separate issue.

@escamoteur I suspect that https://github.com/flutter/engine/pull/24995 might have solved the issue, can you try again on master please? Thanks!

Fixed!! Awesome


Rename ClientService to CommandService

@armiol PTAL

@dmdashenkov please see my comment.

Current coverage is 77.49% (diff: 100%)

Merging #179 into stand-in-memory will increase coverage by 1.10%

@@           stand-in-memory       #179   diff @@
=================================================
  Files                  138        137     -1
  Lines                 5235       5133   -102
  Methods                  0          0
  Messages                 0          0
  Branches               574        565     -9
=================================================
- Hits                  3999       3978    -21
+ Misses                1126       1050    -76
+ Partials               110        105     -5

Powered by Codecov. Last update 2eee97d...1989a93

@armiol PTAL

@dmdashenkov LGTM.


Added YAML Test Cases - Jan 19th

Adding following YAML testcases:
1.TC-BRAC-1.1
2.TC-ETHDIAG-1.1
3.TC-ETHDIAG-2.1
4.TC-PS-1.1
5.TC-SWTCH-2.1
6.TC-SWTCH-2.2
7.TC-WIFIDIAG-1.1
8.TC-WIFIDIAG-3.2
Executed all YAML test scripts, attached logs for reference:
Execution_log.zip

/rebase

Fast tracking, given adding tests


Merge master into feature/89-Email-Enhancement

This pull request was automatically generated because an automated merge hit a merge conflict

feature/89-Email-Enhancement is stale and should probably be deleted. In any case, please don't merge master into it, I just rebased feature/89-Email-Enhancement-jhilyard on master so it would be mess if this was ever merged back to master after having master merged into it.


Dev

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 21 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 77.494%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1902

Relevant Lines:
2400

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 77.449%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1896

Relevant Lines:
2394

💛  - Coveralls


Screen capture area selection & ability to reset area without restarting

Currently you need to input coordinates and height/width for owocr to scan a particular area of the screen. It would be much more convenient if it was possible to simply drag a rectangle instead.
Another quality of life change would be the ability to change these coordinates (also via mouse drag) with a hotkey without having to close and restart the app.

I agree but it’s very annoying to implement unfortunately, i tried to mess around with a pyqt example last year at first but i couldn’t get it to work with two monitors and it had some other issue so i gave up

Instead of a full on drag and drop having the user click twice and calculating an area using those two points might be enough.

+1


i fixed unityengine.networking.Types in 2022.3.7f1!!!!!!!

i fixed it, i only replaced unityengine.networking.Types with this:
using UnityEngine.Networking.PlayerConnection;
using System.Net.Cache;
using System.Net.NetworkInformation;
using System.Net.Mime;
using System.Net.Mail;
using System.Net.Http;
using System.Net.Security;
using System.Net.Sockets;
using System.Net.WebSockets
using UnityEngine.Networking;
and now i can run the game, walk, jump etc.

Are you in the discord? If not, go there so there's no implementation problems and to help add this fix to the asset.

@perrylets can not join. got banned for saying the github link is not under one of the two videos about etra's starter assets.
but it is not under the videos. whats your discord name?


[TOB-OPYN-013] return 0 instead of absolute value if isExcess is false

Audit-fix: [TOB-OPYN-013] return 0 instead of absolute value if isExcess is false
High Level Description
This PR update the getProceed() to return 0 when there is no excess in the vault instead of returning the absolute net value.
Code

[x] Unit test 100% coverage
[x] Does your code follow the naming and code documentation guidelines?

Documentation

[x] Is your code up to date with the spec?
[x] Have you added your tests to the testing doc?

Can u add test for this line?

Can u add test for this line?
kind of dumb but don't want to see the coverage drops lol

Will do in another PR


OAuth

Hook in https://github.com/reddit/reddit/wiki/OAuth2

Got the Auth working...but the json calls that this gem uses is get requests to a json endpoint. I'll revisit if I have time. I don't want to over complicate the gem since the gem will ave to keep track if the token get expired or not.


Better random

Generate random strings in a cryptographically safe way
Ensure there are no collisions when using only few bits of randomness

I don't think it's important that the random string is high quality, but the new code is certainly simpler than the old weird approach of "generate some mysterious amount of randomness and hexify it", and the collision thing is a bad bug, so thanks for fixing it. If you comment on the mysterious-to-me b & 0xff I will merge it.

I've removed the & 0xff since I couldn't find what it was for. Given that it's operating on Uint8Array entries, it should indeed be a no-op. To my shame, I admit that that part of the code was copied from StackOverflow.
I tested using reduce, and this indeed also work:
bytes.reduce((s, b) => s + ('0' + b.toString(16)).slice(-2), '')

(note no += is needed.) I find map+join slightly clearer. My intuition was that it would also be faster... but apparently no:
const usingMap = bytes => Array.prototype.map
    .call(bytes, (b) => ('0' + b.toString(16)).slice(-2))
    .join('');
const usingReduce = bytes => bytes.reduce((s, b) => s + ('0' + b.toString(16)).slice(-2), '');

bytes = new Uint8Array(65000);
crypto.getRandomValues(bytes);
let timeForMap = timeForReduce = 0;
for (let i = 0; i < 1000; ++i) {
  const d0 = new Date();
  const a = usingMap(bytes);
  const d1 = new Date();
  const b = usingReduce(bytes);
  const d2 = new Date();
  if (a !== b) throw "oops";
  timeForMap += d1 - d0;
  timeForReduce += d2 - d1;
}
console.log(`map took {timeForMap} ms, reduce took {timeForReduce} ms.`);

Prints map took 12592 ms, reduce took 5638 ms. on my machine.
Thus changed to using reduce.

OK, this looks good and I'll merge it in a bit when I am available to deploy the cloud function change.

Unfortunately this had to be reverted. The crypto api works in modern browsers, but not in node. Code in the common directory needs to be able to run on the client and server.

Apparently crypto.getRandomValues was added in node v15.0.0; do you have to use an older version?
https://nodejs.org/api/webcrypto.html#cryptogetrandomvaluestypedarray


Use spf13/cobra for docker push and docker pull

Moves image command pull and push to api/client/image/pull.go and api/client/image/push.go and use cobra  🐍.
/cc @dnephin @thaJeztah @LK4D4 @cpuguy83
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

LGTM

LGTM and needs rebase

LGTM


Document: Broken Link Bicep playground

[Enter feedback here]
Broken Link for the "Bicep playground"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52b19fce-dfd5-f3b0-0974-fda218ed4c70
Version Independent ID: e28ee608-7955-b12f-ff4d-b4aac66c6979
Content: Decompile ARM template JSON to Bicep - Azure Resource Manager
Content Source: articles/azure-resource-manager/bicep/decompile.md
Service: azure-resource-manager
Sub-service: bicep
GitHub Login: @mumian
Microsoft Alias: jgao

@aujla0991 - thank you for reporting the issue.  The broken link has been removed.  You can use the Bicep tool to decompile a JSON template.
#please-close


PLNSRVCE-534: depend on IfNotPresent being default (consistent with other steps) and use of specific sha's

see https://github.com/redhat-appstudio/build-definitions/pull/186#issue-1327280582

e2e's clean


Fixing min and max rule for string type

Replace strlen with mb_strlen to gives correct string length as suggested by @DenislavParvanov at #48

Thanks for the fast repsonse. I see same problem in Rules\Between.php, Rules\Required.php and Validation.php


Stability of WGANs

I noticed some issues with the WGANs, I noticed a few things that could do with changing, I'm working on a fix now. Will update on progress

Stale issue, closing. v0.2 implemented GANs functional.


App 1229 - 2-way integration documentation

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Codecov Report

Merging #118 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #118   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files          36       36
  Lines         819      819
  Branches       87       87
=======================================
  Hits          728      728
  Misses         59       59
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263eb2c...3df8f5a. Read the comment docs.

Build triggered. sha1 is merged.

Build started sha1 is merged.

@campidelli  + @rsanchez-daitan  - made some adjustments here. Can you please take one more look at confirm it looks right? Once merged, this needs to go into our 1.5RC as well.

Build finished.


[WIP] restructure

@seanfarmar @bording this is one opinion on how the templates could look. I've only changed the NServiceBusWindowsService template so far.

The build is failing because I haven't updated the approval tests, but I'd like this to be reviewed before proceeding any further.

@bording I amended the commit to remove the addition of .editorconfig.

I amended the commit to remove the addition of <LangVersion>latest</LangVersion> to ParticularTemplates.csproj.

I pushed a fixup to change the lang version to C# 7 and updated the approved files. This is still a WIP because the ScAdapterService is yet to be changed.

I pushed another fixup to fix line endings 🙄

@seanfarmar and I worked on this this morning and we extracted the common endpoint setting into a file which should ultimately be shared with all endpoints.

One other thing to consider, though perhaps in another PR, The ServiceBase class is now available for .NET Core when running on windows: https://www.nuget.org/packages/System.ServiceProcess.ServiceController/4.5.0-preview1-25914-04
So we could extend this template to work with netcoreapp2.0 as well. Maybe it would be better to wait until the package is not prerelease?

@adamralph I've taken another look at the EndpointConfigurationExtensions class, and I'm 👎 for keeping it. The fact that the second parameter has the learning transport baked is worrying, since that's one more place users would have to modify.
I think we'd be better off moving all of that back into the single place, and we can have another comment that says something about considering sharing the configuration if they have more than one endpoint.

The fact that the second parameter has the learning transport baked is worrying, since that's one more place users would have to modify.

@bording that's a valid point and, on reflection, I don't like it either. I'm changing my opinion on the EndpointConfigurationExtensions and given that we now have a majority 👎 vote, I'm going to remove it.

I've pushed another fixup. Note that ScAdapterService is still unchanged in this PR so it also needs work to close this out.

I've pushed another fixup. Note that ScAdapterService is still unchanged in this PR so it also needs work to close this out.

Given that very few users is expected to use the ScAdapter I'd say we treat this as a separate PR

@mauroservienti seems like your comments have been addressed?

I've pushed another fixup. Note that ScAdapterService is still unchanged in this PR so it also needs work to close this out.

Do we want to address ScAdapterService in this PR? I'm 👎, we should raise another PR.

seems like your comments have been addressed?

yup, approved.

@mauroservienti Since this PR is from @adamralph's fork, If he didn't give us rights to push back to his branch, we might need to open a new PR to deal with additional changes.
Alternatively, we go ahead and merge this as-is, and then fix the remaining items in a new PR.

Adam is off this week so lets merge and fix in a separate PR?

Looks like I was able to push changes to his fork, so I went ahead and fixed up the final items.

One additional minor tweak: Since the template engine replaces all instances of "NServiceBusWindowsService", the endpoint name also gets changed, so there's no need for the "My" in the name.


build trtllm very slow

System Info

GPU： NVIDIA H100 80G
TensorRT-LLM branch main
TensorRT-LLM commit: 535c9cc6730f5ac999e4b1cb621402b58138f819

Who can help?
@byshiue @Superjomn
Information

[x] The official example scripts
[ ] My own modified scripts

Tasks

[x] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
apt-get update && apt-get -y install git git-lfs
git lfs install

git clone https://github.com/NVIDIA/TensorRT-LLM.git
cd TensorRT-LLM
git submodule update --init --recursive
git lfs pull
BUILD_WHEEL_ARGS="--trt_root /usr/local/tensorrt --python_bindings --benchmarks --cuda_architectures 90 -j8" python3 scripts/build_wheel.py ${BUILD_WHEEL_ARGS}

Expected behavior
build in less than one hour
actual behavior
build slow more than 2 hours

[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/kernelDispatcherFp16Int8GroupwiseColumnMajorFalse.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/kernelDispatcherFp16Int8GroupwiseColumnMajorInterleavedTrue.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/kernelDispatcherFp16Int8PerChannelColumnMajorFalse.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/kernelDispatcherFp16Int8PerChannelColumnMajorInterleavedTrue.cu.o
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/kernels/quantization.cu(280): warning #780-D: reference is to variable "i" (declared at line 260) -- under old for-init scoping rules it would have been variable "i" (declared at line 265)
              smemBuffer[i] = vec;
                         ^
          detected during instantiation of "void tensorrt_llm::kernels::invokePerTokenQuantization(QuantT *, const T *, int64_t, int64_t, const float *, float *, float *, tensorrt_llm::common::QuantMode, cudaStream_t) [with T=float, QuantT=int8_t]" at line 354

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/kernelDispatcherFp16Int8PerChannelColumnMajorTrue.cu.o
[100%] Built target context_attention_src
[100%] Linking CUDA device code CMakeFiles/cutlass_src.dir/cmake_device_link.o
[100%] Linking CXX static library libcutlass_src.a
[100%] Built target cutlass_src
[100%] Linking CUDA device code CMakeFiles/gemm_swiglu_sm90_src.dir/cmake_device_link.o
[100%] Linking CUDA static library libgemm_swiglu_sm90_src.a
[100%] Built target gemm_swiglu_sm90_src
[100%] Built target selective_scan_src

additional notes
lots of process when compiling, with ptxas -arch sm_80 which is unrelated to sm90 even when I use --cuda_architectures 90
ps.txt

it raised an error
[  0%] Generating .check_symbol
[  0%] Generating .check_symbol_executor
[  0%] Generating .check_symbol_internal_cutlass_kernels
[  0%] Built target gemm_swiglu_sm90_src
[  0%] Built target fb_gemm_src
[  0%] Built target check_symbol
[  0%] Built target check_symbol_executor
[  0%] Built target check_symbol_internal_cutlass_kernels
[  0%] Built target cutlass_src
[  1%] Built target selective_scan_src
[  2%] Built target common_src
[  2%] Built target layers_src
[  3%] Built target moe_gemm_src
[  4%] Built target fpA_intB_gemm_src
[  4%] Building CXX object tensorrt_llm/runtime/CMakeFiles/runtime_src.dir/tllmRuntime.cpp.o
[  5%] Built target decoder_attention
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp: In function ‘void {anonymous}::setWeightStreaming(nvinfer1::ICudaEngine&, float)’:
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp:113:16: error: ‘class nvinfer1::ICudaEngine’ has no member named ‘setWeightStreamingBudgetV2’; did you mean ‘setWeightStreamingBudget’?
  113 |         engine.setWeightStreamingBudgetV2(budget);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                setWeightStreamingBudget
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp: In constructor ‘tensorrt_llm::runtime::TllmRuntime::TllmRuntime(const tensorrt_llm::runtime::RawEngine&, nvinfer1::ILogger*, float, bool)’:
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp:242:41: error: ‘class nvinfer1::ICudaEngine’ has no member named ‘getDeviceMemorySizeV2’; did you mean ‘getDeviceMemorySize’?
  242 |     auto const devMemorySize = mEngine->getDeviceMemorySizeV2();
      |                                         ^~~~~~~~~~~~~~~~~~~~~
      |                                         getDeviceMemorySize
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp: In member function ‘nvinfer1::IExecutionContext& tensorrt_llm::runtime::TllmRuntime::addContext(int32_t)’:
/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/cpp/tensorrt_llm/runtime/tllmRuntime.cpp:284:13: error: ‘class nvinfer1::IExecutionContext’ has no member named ‘setDeviceMemoryV2’; did you mean ‘setDeviceMemory’?
  284 |     context.setDeviceMemoryV2(mEngineBuffer->data(), static_cast<int64_t>(mEngineBuffer->getCapacity()));
      |             ^~~~~~~~~~~~~~~~~
      |             setDeviceMemory
gmake[3]: *** [tensorrt_llm/runtime/CMakeFiles/runtime_src.dir/build.make:527: tensorrt_llm/runtime/CMakeFiles/runtime_src.dir/tllmRuntime.cpp.o] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:1935: tensorrt_llm/runtime/CMakeFiles/runtime_src.dir/all] Error 2
gmake[2]: *** Waiting for unfinished jobs....
[ 23%] Built target decoder_attention_src
[ 63%] Built target kernels_src
[ 98%] Built target context_attention_src
gmake[1]: *** [CMakeFiles/Makefile2:1537: tensorrt_llm/CMakeFiles/tensorrt_llm.dir/rule] Error 2
gmake: *** [Makefile:218: tensorrt_llm] Error 2
Traceback (most recent call last):
  File "/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/scripts/build_wheel.py", line 434, in <module>
    main(**vars(args))
  File "/home/work/xingwuFileSystem/qserve_trtllm/TensorRT-LLM/scripts/build_wheel.py", line 208, in main
    build_run(
  File "/usr/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'cmake --build . --config Release --parallel 192 --target tensorrt_llm nvinfer_plugin_tensorrt_llm th_common bindings   executorWorker  ' returned non-zero exit status 2.

Thank you to report the issue. It is a bug at https://github.com/NVIDIA/TensorRT-LLM/blob/main/cpp/tensorrt_llm/kernels/CMakeLists.txt#L25. We should replace SRC_CU by SRC_CPP. We will fix it ASAP.

change this will fix which bug? compiling is slow, or the error?

It fixes the slow compiling.
For the error, please create another bug if it is not related to the issue above.


drain all of udp packets and make sure PollCont run before UDPNetHandler

Since we don't schedule the recv event anymore (callback by nethandler), we should walk through the recv queue and handle every udp packet.

Hi @maskit
Could you please review again.

[approve ci autest]

👍


fix: remove nvim-treesitter dependency

This plugin actually uses Neovim's core API and doesn't depend on nvim-treesitter's legacy API (which will be removed).
I have

Replaced the only place where nvim-treesitter is needed to use Neovim's core API to check for a parser on the runtimepath.
Updated the reamde to clarify that this plugin doesn't depend on nvim-treesitter (there are multiple ways to install parsers).

Thanks!


Switch device name to peripheral

Peripheral makes more sense in the context of BLE devices.

This library has been deprecated. Please update to use this new library:
https://github.com/adafruit/Adafruit_Blinka_bleio
If you continue to have this issue, please open a new issue in that repo.


Adding flavor as a has one on VM

I basically want to search Vms like
vms = Flavor.joins(:vms).where(:flavors => {:name => 't2.micro'})
so that in the api we can filter by flavor name
http://localhost:3000/api/vms?filter[]=flavor.name='t2.micro'
Fixes BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1596069

@gtanzillo Hey Greg,
Not sure if this is the correct way to fix this BZ. What do you think?

Also this breaks the tests :(

@miq-bot assign @gtanzillo

This seems to be almost generating the correct query.
But I don't want flavours.id to equal vms.id :(
SELECT DISTINCT COUNT(DISTINCT "vms"."id") FROM "vms" LEFT OUTER JOIN "flavors" ON "flavors"."id" = "vms"."id" AND "flavors"."name" = $1 WHERE "vms"."type" IN ('Vm', 'VmServer', 'ManageIQ::Providers::InfraManager::Vm', 'ManageIQ::Providers::CloudManager::Vm', 'VmXen', 'ManageIQ::Providers::Kubevirt::InfraManager::Vm', 'ManageIQ::Providers::Redhat::InfraManager::Vm', 'ManageIQ::Providers::Microsoft::InfraManager::Vm', 'ManageIQ::Providers::Vmware::InfraManager::Vm', 'ManageIQ::Providers::Amazon::CloudManager::Vm', 'ManageIQ::Providers::Azure::CloudManager::Vm', 'ManageIQ::Providers::Google::CloudManager::Vm', 'ManageIQ::Providers::Openstack::CloudManager::Vm', 'ManageIQ::Providers::Vmware::CloudManager::Vm') AND "vms"."template" = $2 AND ("flavors"."name" = 't2.micro') AND ("flavors"."name" = 't2.micro')

@juliancheal @gtanzillo Can this be gaprindashvili/yes and fine/yes?

@simaishi Yes, I think so.

@miq-bot add_label gaprindashvili/yes

@miq-bot add_label fine/yes

Gaprindashvili backport details:
$ git log -1
commit 54ec113077d242bb804770698601291a040deb80
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed Jul 18 16:46:18 2018 -0400

    Merge pull request #17692 from juliancheal/filter_by_flavor_api

    Adding flavor as a has one on VM
    (cherry picked from commit fb7a26da221d315639bf6851d646522db54f5d17)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1607441

Fine backport details:
$ git log -1
commit 937f733bbe21cf6bd99b46155f3b27eaab78cd99
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed Jul 18 16:46:18 2018 -0400

    Merge pull request #17692 from juliancheal/filter_by_flavor_api

    Adding flavor as a has one on VM
    (cherry picked from commit fb7a26da221d315639bf6851d646522db54f5d17)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1607442


Use lookup tables on figures

The dropdowns in the shiny app use the lookup tables, but the actual figures still use the abbreviations.


[ENHANCEMENT] Add help command

Add an help command to explain all functions.

🚧 I'll work on this now.

✔ Done.


Error training controller

/home/boucher/.virtualenvs/worldmodels/lib/python3.5/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Using TensorFlow backend.
['mpirun', '-np', '2', '/home/boucher/.virtualenvs/worldmodels/bin/python', '05_train_controller.py', 'car_racing', '--num_worker', '1', '--num_worker_trial', '2', '--num_episode', '16', '--max_length', '1000', '--eval_steps', '25']
/home/boucher/.virtualenvs/worldmodels/lib/python3.5/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
/home/boucher/.virtualenvs/worldmodels/lib/python3.5/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Using TensorFlow backend.
Using TensorFlow backend.
assigning the rank and nworkers 1 0
assigning the rank and nworkers 1 0
2018-04-18 18:30:08.922363: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2018-04-18 18:30:08.927218: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2018-04-18 18:30:09.084787: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:898] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2018-04-18 18:30:09.085010: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1344] Found device 0 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.683
pciBusID: 0000:01:00.0
totalMemory: 10.91GiB freeMemory: 9.47GiB
2018-04-18 18:30:09.085020: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1423] Adding visible gpu devices: 0
2018-04-18 18:30:09.085433: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:898] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2018-04-18 18:30:09.085774: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1344] Found device 0 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.683
pciBusID: 0000:01:00.0
totalMemory: 10.91GiB freeMemory: 9.47GiB
2018-04-18 18:30:09.085783: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1423] Adding visible gpu devices: 0
2018-04-18 18:30:09.224535: I tensorflow/core/common_runtime/gpu/gpu_device.cc:911] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-04-18 18:30:09.224562: I tensorflow/core/common_runtime/gpu/gpu_device.cc:917]      0
2018-04-18 18:30:09.224566: I tensorflow/core/common_runtime/gpu/gpu_device.cc:930] 0:   N
2018-04-18 18:30:09.224701: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 9110 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:01:00.0, compute capability: 6.1)
2018-04-18 18:30:09.228563: I tensorflow/core/common_runtime/gpu/gpu_device.cc:911] Device interconnect StreamExecutor with strength 1 edge matrix:
2018-04-18 18:30:09.228578: I tensorflow/core/common_runtime/gpu/gpu_device.cc:917]      0
2018-04-18 18:30:09.228597: I tensorflow/core/common_runtime/gpu/gpu_device.cc:930] 0:   N
2018-04-18 18:30:09.229018: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1041] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 253 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:01:00.0, compute capability: 6.1)
size of model 867
size of model 867
(1,2mirr1)-aCMA-ES (mu_w=1.0,w_1=100%) in dimension 867 (seed=205998, Wed Apr 18 18:30:09 2018)
('process', 0, 'out of total ', 1, 'started')
('training', 'car_racing')
('population', 2)
('num_worker', 1)
('num_worker_trial', 2)
('num_episode', 16)
('max_length', 1000)
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
Traceback (most recent call last):
  File "05_train_controller.py", line 461, in <module>
    main(args)
  File "05_train_controller.py", line 410, in main
    master()
  File "05_train_controller.py", line 319, in master
    send_packets_to_slaves(packet_list)
  File "05_train_controller.py", line 233, in send_packets_to_slaves
    assert len(packet_list) == num_worker-1
AssertionError
(1,2mirr1)-aCMA-ES (mu_w=1.0,w_1=100%) in dimension 867 (seed=250130, Wed Apr 18 18:30:09 2018)
('process', 0, 'out of total ', 1, 'started')
('training', 'car_racing')
('population', 2)
('num_worker', 1)
('num_worker_trial', 2)
('num_episode', 16)
('max_length', 1000)
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
Traceback (most recent call last):
  File "05_train_controller.py", line 461, in <module>
    main(args)
  File "05_train_controller.py", line 410, in main
    master()
  File "05_train_controller.py", line 319, in master
    send_packets_to_slaves(packet_list)
  File "05_train_controller.py", line 233, in send_packets_to_slaves
    assert len(packet_list) == num_worker-1
AssertionError
Traceback (most recent call last):
  File "05_train_controller.py", line 460, in <module>
    if "parent" == mpi_fork(args.num_worker+1): os.exit()
  File "05_train_controller.py", line 429, in mpi_fork
    subprocess.check_call(["mpirun", "-np", str(n), sys.executable] +['-u']+ sys.argv, env=env)
  File "/usr/lib/python3.5/subprocess.py", line 581, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['mpirun', '-np', '2', '/home/boucher/.virtualenvs/worldmodels/bin/python', '-u', '05_train_controller.py', 'car_racing', '--num_worker', '1', '--num_worker_trial', '2', '--num_episode', '16', '--max_length', '1000', '--eval_steps', '25']' returned non-zero exit status 1

Not exactly sure what the problem is here. I had to lower the number of workers to run on my gpu without running out of memory, but playing around with that number and the num_worker_trial I wasn't able to get it past this error.

If I disable that assertion I end up getting this error:
Traceback (most recent call last):
  File "05_train_controller.py", line 461, in <module>
    if "parent" == mpi_fork(args.num_worker+1): os.exit()
  File "05_train_controller.py", line 430, in mpi_fork
    subprocess.check_call(["mpirun", "-np", str(n), sys.executable] +['-u']+ sys.argv, env=env)
  File "/usr/lib/python3.5/subprocess.py", line 581, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['mpirun', '-np', '2', '/home/boucher/.virtualenvs/worldmodels/bin/python', '-u', '05_train_controller.py', 'car_racing', '--num_worker', '1', '--num_worker_trial', '2', '--num_episode', '16', '--max_length', '1000', '--eval_steps', '25']' returned non-zero exit status 1

Similarly, reverting to tensorflow on the cpu fails with the given invocation

It's probably related to this:
https://gist.github.com/ozooxo/9280304
It's already wrong by this point:
assigning the rank and nworkers 1 0
assigning the rank and nworkers 1 0

This should read (for 1 slave, 1 master - as per your setup)
assigning the rank and nworkers 2 1
assigning the rank and nworkers 2 0

So for some reason comm.Get_size() always returns 1
and comm.Get_rank() returns 0 on your machine, hence the error.
Try the fix in the above post and see if that helps.

Thanks, just went out of town, will test it out when I get back.

Ok, I was looking in the wrong place. I've gotten further and am now stuck on an out of memory error, so I'll work on that for a while and close this issue.

Let me know if the memory error persists - I fixed a bug on this a while back so ensure you have the latest version of the repo

Thanks, I was able to get it running, but the box2d simulation runs extremely slowly, is that normal? I left it running overnight and it's still going; the actual rendering on screen is like 1 frame every 10 seconds.

I have reduced the worker number to 1 and the worker_trial number to 2 (which is the minimum number that I can set). But I still got the out of memory error, even if I used 4 Titan X GPUs, could you tell me how to fix the memory error?

Run watch -n 1 nvidia-smi and see if memory is still being used after error.
If it is run pkill -9 python and try again,
Seems like when it errors out python stays open so gpu memory stays full

@boucher
I am receiving the same error as yours. Did you resolve the issue?
In fact, the suggestion from @davidADSP did not help me.
Any other suggestion for the following error:
(worldmodels) baheri@aerodrome:~/WorldModels$ python 05_train_controller.py car_racing --num_worker 1 --num_worker_trial 1 --num_episode 4 --max_length 1000 --eval_steps 25 /home/baheri/.virtualenvs/worldmodels/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type.   from ._conv import register_converters as _register_converters Using TensorFlow backend. ['mpirun', '-np', '2', '/home/baheri/.virtualenvs/worldmodels/bin/python', '05_train_controller.py', 'car_racing', '--num_worker', '1', '--num_worker_trial', '1', '--num_episode', '4', '--max_length', '1000', '--eval_steps', '25'] /home/baheri/.virtualenvs/worldmodels/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type.   from ._conv import register_converters as _register_converters /home/baheri/.virtualenvs/worldmodels/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type`.
from ._conv import register_converters as _register_converters
Using TensorFlow backend.
Using TensorFlow backend.
assigning the rank and nworkers 1 0
assigning the rank and nworkers 1 0
2018-10-16 07:47:14.706938: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2018-10-16 07:47:14.732364: I tensorflow/core/platform/cpu_feature_guard.cc:140] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
('process', 0, 'out of total ', 1, 'started')
('training', 'car_racing')
('population', 1)
('num_worker', 1)
('num_worker_trial', 1)
('num_episode', 4)
('max_length', 1000)
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
('process', 0, 'out of total ', 1, 'started')
('training', 'car_racing')
('population', 1)
('num_worker', 1)
('num_worker_trial', 1)
('num_episode', 4)
('max_length', 1000)
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
Traceback (most recent call last):
File "05_train_controller.py", line 522, in
Traceback (most recent call last):
File "05_train_controller.py", line 522, in
main(args)
File "05_train_controller.py", line 472, in main
main(args)
File "05_train_controller.py", line 472, in main
master()
File "05_train_controller.py", line 351, in master
master()
File "05_train_controller.py", line 351, in master
solutions = es.ask()
File "/home/baheri/WorldModels/es.py", line 180, in ask
solutions = es.ask()
File "/home/baheri/WorldModels/es.py", line 180, in ask
idx_a = np.random.choice(elite_range)
File "mtrand.pyx", line 1126, in mtrand.RandomState.choice
idx_a = np.random.choice(elite_range)
File "mtrand.pyx", line 1126, in mtrand.RandomState.choice
ValueError: a must be non-empty
ValueError: a must be non-empty
Primary job  terminated normally, but 1 process returned
a non-zero exit code.. Per user-direction, the job has been aborted.

mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:
Process name: [[45559,1],0]
Exit code:    1
Traceback (most recent call last):
File "05_train_controller.py", line 521, in
if "parent" == mpi_fork(args.num_worker+1): os.exit()
File "05_train_controller.py", line 491, in mpi_fork
subprocess.check_call(["mpirun", "-np", str(n), sys.executable] +['-u']+ sys.argv, env=env)
File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['mpirun', '-np', '2', '/home/baheri/.virtualenvs/worldmodels/bin/python', '-u', '05_train_controller.py', 'car_racing', '--num_worker', '1', '--num_worker_trial', '1', '--num_episode', '4', '--max_length', '1000', '--eval_steps', '25']' returned non-zero exit status 1.
`


.crdownload will pass the verification with {contains: true}

When downloading a file in google Chrome the ending .crdownlaod gets appended to the downloaded file and removed when the file is downloaded completly. The file is already in the downloads folder when first downloaded.
Example
01_01_22_text.txt.crdownload will pass cy.verifyDownload('text.txt', {contains: true, timeout: 10000, interval: 250}); even though it is still downloading the file.
Expected behaviour
Only let files pass that are fully downloaded to ensure they are really downloaded. After the validation with the plugin the contents of the file can be validated.

Hey @PhilipAllStar,
Thanks for filling the issue. It's definitely a bug. I'll create a fix for that and publish it later today.

I've fixed and released it in the 0.1.9 version. So, update the package and enjoy. Also, don't forget to hit the star button for the project.


Fix notice check

This reworks the notice_check.py to use git ls-files and exclude some things from that. It also reworks the logic for checking for the license lines to be a bit more robust in the face of formatting.

Nice, are any of these changes worth upstreaming to CCF?

I wouldn't think they're urgent but maybe eventually.


Enable view-based panning and zooming

Description
This PR introduces view-based panning and zooming

What was changed in this pull request?

If the Browser supports window.requestIdleCallback() updates to the values scale (if there are any) are now applied based on the visible part of the data instead of the visible tiles. 1D and 2D tracks that have a value scale are supported (except BedLikeTrack, Horizontal1DHeatmapTrack and MultivecTrack for now).
The minimal and maximal visible values of the tracks have to be computed efficiently since they are recomputed on every zoom event. The modules DenseDataExtrema1D and DenseDataExtrema2D have been developed for this purpose. They precompute minimums and maximum in each tile on a regularly subdivided grid and use these precomputations to efficiently obtain extrema for arbitrary subsets. Note that 2D extrema are computed only approximately for performance reasons. The additional storage requirements per tile are small.
Once a value scale change has been detected the track is scheduled to be rerendered. The BackgroundTaskScheduler module handles the task list and makes sure that only the latest version of a track is rerendered when there is capacity to do so.
Tracks with locked value scale are supported as well. Left and right tracks can now also be vale scale locked, which did not work before.

Why is it necessary?

This is an enhancement to the current tile-based panning and zooming

Remarks

Currently this is active as soon as the browser supports requestIdleCallback. We could make it optional via the viewconf. In a scenario with one heatmap and a few 1D tracks I don't see a noticeable performance difference compared to what we have, but maybe you have a different experience.
There is a lot of room for performance improvements when value scales are locked. The onValueScaleChange() method rerenders every track in a lock group but is also called for every track that is locked in a view (e.g. on brushMoved()). This leads to a quadratic number of rerenders in the number of locked tracks. Optimally this should only be called only once per lock group. What would be an elegant way to achieve this? A track would need to know that onValueScaleChange() will be called by another track in the same lock group.
Minor issue: On high zoom levels you can see pixels vanishing from time to time. This is not a problem with the PR but due to the fact that the extrema are computed more accurately and the background color is the same as the color for pixels with the lowest value.
I did not add tests yet, but will add some once I have your feedback.

Fixes #846 #813
Checklist

[x] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[ ] Unit tests added or updated
[ ] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[x] Screenshot for visual changes (e.g. new tracks or UI changes)
[ ] Updated CHANGELOG.md

I have one question and one micro comment:

How does that impact the CPU/GPU load? Especially during drastic panning or zooming
Do you mind if I rename this PR to view-based-scaling or pixel-precise-scaling? The current name doesn't make sense to me because we support view-based panning and zooming since v0.0.1 :)

Thanks. I renamed it.
In a scenario where there are no value locked scales, I did not experience a significant difference in the user experience or CPU/GPU load. When there is a lot of zooming we need to compute the minimums and maximums very often, but this is quite fast. The rerenders are of course much more expensive. However, drastic zooming doesn't just add more and more rerenders to the task list. A certain track is only added to the task list once, therefore drastic zooming does not necessarily lead to a significantly higher load. Typically drastic zooming request new tiles all the time, which I think is more expensive than these rerenders.
When tracks are value scale locked, there is probably a higher CPU/GPU load than now. I couldn't use requestIdleCallback() as tracks wouldn't always sync correctly. From a user experience point of view, I don't think there is a huge difference (when a moderate number of tracks is locked), but this case can certainly be optimized.

But of course this continuous scaling is not free. There are a lot more rerenders than before even though most of them should happen during 'idle time'.

This looks great! I'll take a closer look this evening but in the meantime, would you mind posting a link to the viewconf you used here? Export views as link.

Sure, the example from up: http://higlass.io/l/?d=Rlk1N86YSbSgydiv8MGCyA
And one with locked 1D tracks: http://higlass.io/l/?d=Q3TftOL8RPmqhPZ4hK-AuQ
Note that ignoreOffScreenValues must be set to true in order to see a difference for value scale locked tracks (default is false).

Thank you for your helpful comments. I have integrated your suggestions and added tests.

Continuous scaling is not supported for MultiVec and HorizontalHeatmapTracks currently. This still has to be done.
I was looking for libraries for the efficient computation of the extrema that we need here, but could not find any.

Will do some time next week. Please ping me if I forget 😇

So far the LeftTrackModifier.zoomed function only called the draw of the original track. However, I need it to call the zoomed function of the original track because there we determine if a rerender due to a new value scale is required.
I didn't want to change the behavior of existing track types that don't have numerical values or don't support continuous scaling (e.g. HorizontalHeatmapTrack). leftTrackDraw is simply the draw function of the original track. If it is implemented the LeftTrackModifier.zoomed calls draw instead of zoom as it has been the case so far.

OK, I think that makes sense. The default behavior for LeftTrackModifier.zoomed should be to call originalTrack.zoomed unless originalTrack has a leftTrackDraw method.
I'm not sure why we originally had LeftTrackModifier.zoomed calling originalTrack.draw.

Thank you for the review.
The precomputations of the extrema could indeed be done on the server. The problem is that this would only eliminate the functions computeSubsetNonZeroMinimums and computeSubsetNonZeroMaximums in the DenseDataExtrema modules which are doing exactly that. We would still need functions that compute the precise extrema from these precomputed values. That's what getMaxNonZeroInSubset is doing and what needs to remain in the viewer. Therefore, not a lot of complexity can be moved to the server this way and splitting up that logic is probably not a good idea, since it would be harder to maintain.
I tried just writing one module for 1D and 2D but gave up since it became too complicated, especially since I wanted slightly different behavior. I think it is easier to understand now.


I touched base w Em and the initial lottery Figma has it in Doorway partners but with Doorway styles - and partners Doorway right now doesn't have Doorway styles, it looks like core - I'm not sure if (1) the core version should have increased weight or (2) the design should change to be the lower core weight, but will update when I know 🫡


PHP CodeFormatter is broken after latest updates

CodeFormatter is broken after latest updates ... it require php 5.6 ... but formatted is not right ...
EX : when I try to formate this code:
outputData['css'] = array(
            base_url() . 'assets/css/about.css'
        );
		$this->load_view('public/about_us');

	}
}

IT BECOMES :
outputData['css'] = array(
            base_url() . 'assets/css/about.css',
        );
        $this->load_view('public/about_us');

    }
}

TOTALLY WRONG ... what is going on??

You've  update settings for CodeFormatter?

I forgot ... updating right now ...

Yes ... I added the path to php executable ... still broken ...

Here are php settings :
"codeformatter_php_options": {
"syntaxes": "php", // Syntax names which must process PHP formatter
"php_path": "/usr/bin/php", // Path for PHP executable, e.g. "/usr/lib/php" or "C:/Program Files/PHP/php.exe". If empty, uses command "php" from system environments
"format_on_save": false, // Format on save
"psr1": true, // Activate PSR1 style
"psr1_naming": true, // Activate PSR1 style - Section 3 and 4.3 - Class and method names case
"psr2": true, // Activate PSR2 style
"indent_with_space": 4, // Use spaces instead of tabs for indentation
"enable_auto_align": true, // Enable auto align of = and =>
"visibility_order": true, // Fixes visibiliy order for method in classes - PSR-2 4.2
"smart_linebreak_after_curly": true, // Convert multistatement blocks into multiline blocks
// Enable specific transnformations. Example: ["ConvertOpenTagWithEcho", "PrettyPrintDocBlocks"]
// You can list all available transnformations from command palette: CodeFormatter: Show PHP Transformations
"passes": [],
// Disable specific transnformations
"exclude": [],
},
I am using Ubuntu 14.04 ... path to php : /usr/bin/php

Open console and copy here CodeFormatter error

I am not getting any error ...  I run the command ... it runs ... maybe I am doing something wrong ... but I don't see what ... I update php to 5.6 and set the path to settings file (user) ...  if it helps you debugging  I can give you my teamviewer ID ... everything was perfect until this morning updates.

works perfect ... is just when the class name is 'Public' .. is treated line 'public'  FROM public function(){}
Thank you very much for your answers ...


[typo] transcation -> transaction

[x] I have searched the issues of this repository and believe that this is not a duplicate.

我想这是一个单词拼写错误,应该是transaction吧
https://github.com/seata/seata/tree/develop/serializer/seata-serializer-protobuf/src/main/resources/protobuf/io/seata/protocol/transcation

查了一下这个单词，看起来单词意思是：更新数据。

拼写错误。感谢反馈。后续会优化一下。


fix: /etc/rancher/%s/registries.yaml marshalling

Issue:
https://github.com/rancher/rancher/issues/39199
Problem
When marshalling /etc/rancher/%s/registries.yaml file it is being encoded as JSON, but the expected (seeing the file extension) and the doc is to be YAML.
Solution
Add yaml annotations for struct - even if yaml marshal support json annotations (readability) - and change the serializer to yaml one.
Engineering Testing
Manual Testing
In one local cluster, I checked that using YAML encoding the rancher is capable of understanding the file.
Additional context
This was suggested here but I didn't have time to fix the pipeline and it ended up being abandoned. I'm suggesting it again here with the intention of finalizing the patch.

@GeertvanHorrik @Oats87 we talked about this in the past, but it was not clear for me the reasons why the CI was failing. It is still failing here. Do you have some guidance on it for me to try to fix?


Details of  ConfigAudit

Hello,
Thanks for this exporter.
I need to use ConfigAudit details but it is not possible on the helm (unlike vulnerabilityReports)
configAuditReports:
enabled: true
vulnerabilityReports:
enabled: true
targetLabels:
# - image_namespace
# - image_repository
# - image_tag
# - vulnerability_id
I saw on the controllers that the details are not exposed
var metricLabels = []string{
"report_name",
"resource_name",
"resource_namespace",
"severity",
}
It would be very interesting to add this possibility.
Translated with www.DeepL.com/Translator (free version)

Hi @ilyassikai, welcome :wave:
What is your use case / what would your ideal metrics look like? The ConfigAuditReport controller does not currently expose details like the VulnerabilityReport controller does because we hadn't found them useful yet, but if someone wants to implement it we might be open to aligning the two controllers.

Hi,
My use case, I would like to see the report config details on a readable format
I can export on a json format  with trivy k8s but  it's not a freindly format.

In case it helps: If you are running trivy-operator in a cluster, you can also use the reports directly (VulnerabilityReport, ConfigAuditReport) or convert them to PolicyReports and view them nicely with policy-reporter.
As for metrics -- this feature is low priority for our customers' use cases right now, but we are open to accepting contributions adding it.
We are also planning to return to this exporter and expand it to include the new report types supported by Trivy operator. So this project will be getting some new attention soon. We might be able to implement ConfigAuditReport metrics as part of that effort, if there are no contributions first


Tag keys to be inherited before synthesis, fixes #31

By design, a synthesized value will override an inherited value for a key, but in some cases the intent is actually to only synthesize a value when there is no inherited value. This provides early termination of transforms for such keys.
Example:
- net.layer2.name:
  - inherited: ~
  - synthesize: "#[chassis.nic.name]"

The code looks good, albeit not particularly obvious for those of us not fluent in Ruby. A few minor nits to be picked:

I'd prefer it if the rule was called inherit, to match the others, which are verbs in the imperative.
Full documentation should be at the top of transforms.yaml, next to that for the synthesizing methods, and in the same style as them. The documentation by the example can then be shortened and made more specific to the example.
The full documentation should mention that the value after inherit(ed): is ignored.

I explicitly picked inherited instead of inherit, to reflect that it doesn't actually do anything to the key but rather describes a property of the key. But I can change name and/or semantics (to make it simply assign the inherited value, and drop the catch/throw magic).


Concurrent mount may result in success with no secret(s) in the volume

Describe the bug
I have a chart that will create 2 deployments at the same time. Both of these deployments mount a secret from Key Vault using AAD Pod Identity (MSI) authentication. The secrets are mounted into the same relative location in each pod.
Using v0.0.10 of the FlexVolume mounts both secrets without issue. However, updating to 0.0.11 of the FlexVolume may result in only one secret being mounted in one pod. The other pod will not receive the secret and will subsequently fail at runtime as the secret is required.
In this scenario, both pods were initially scheduled on the same Linux node. Deleting the pod which did not receive the secret re-scheduled it on a second node which then received the secret correctly and started as expected.
The below log appears to be missing the "write" log message for the first pod, which is the pod that failed. There appear to be 2 messages for every other step as expected (including 2 successes), but only 1 write message is shown and it is for the pod GUID that did successfully start.
Mon Aug 12 04:23:20 UTC 2019 INFO: {"status": "Success", "capabilities": {"attach": false}}
Mon Aug 12 04:27:47 UTC 2019 ismounted | not mounted
Mon Aug 12 04:27:47 UTC 2019 ismounted | not mounted
Mon Aug 12 04:27:47 UTC 2019 PODNAME: <POD-1>
Mon Aug 12 04:27:47 UTC 2019 PODNAME: <POD-2>
Mon Aug 12 04:27:47 UTC 2019 mount
Mon Aug 12 04:27:47 UTC 2019 mount
Mon Aug 12 04:27:47 UTC 2019 /etc/kubernetes/volumeplugins/azure~kv/azurekeyvault-flexvolume -logtostderr=1 -vaultName=<VAULT-NAME> -vaultObjectNames=<SECRET-NAME> -vaultObjectAliases= -resourceGroup=<RESOURCE-GROUP> -dir=/var/lib/kubelet/pods/<POD-1-GUID>/volumes/azure~kv/kv-flexvol-0 -subscriptionId=<SUBSCRIPTION-ID> -cloudName= -tenantId=<TENANT-ID> -aADClientSecret= -aADClientID= -usePodIdentity=true -podNamespace=<POD-NAMESPACE> -podName=<POD-1> -vaultObjectVersions= -vaultObjectTypes=secret
Mon Aug 12 04:27:47 UTC 2019 /etc/kubernetes/volumeplugins/azure~kv/azurekeyvault-flexvolume -logtostderr=1 -vaultName=<VAULT-NAME> -vaultObjectNames=<SECRET-NAME> -vaultObjectAliases= -resourceGroup=<RESOURCE-GROUP> -dir=/var/lib/kubelet/pods/<POD-2-GUID>/volumes/azure~kv/kv-flexvol-0 -subscriptionId=<SUBSCRIPTION-ID> -cloudName= -tenantId=<TENANT-ID> -aADClientSecret= -aADClientID= -usePodIdentity=true -podNamespace=<POD-NAMESPACE> -podName=<POD-2> -vaultObjectVersions= -vaultObjectTypes=secret
I0812 04:27:47.388245   20202 keyvaultFlexvolumeAdapter.go:32] azurekeyvault-flexvolume 0.0.11
I0812 04:27:47.388315   20202 keyvaultFlexvolumeAdapter.go:41] starting the azurekeyvault-flexvolume, 0.0.11
I0812 04:27:47.388355   20202 oauth.go:138] azure: using pod identity to retrieve token
I0812 04:27:47.389811   20203 keyvaultFlexvolumeAdapter.go:32] azurekeyvault-flexvolume 0.0.11
I0812 04:27:47.389879   20203 keyvaultFlexvolumeAdapter.go:41] starting the azurekeyvault-flexvolume, 0.0.11
I0812 04:27:47.389928   20203 oauth.go:138] azure: using pod identity to retrieve token

 accesstoken: <EXTRA REDACTED>

 clientid: <EXTRA REDACTED>
I0812 04:28:02.666908   20203 oauth.go:138] azure: using pod identity to retrieve token

 accesstoken: <EXTRA REDACTED>

 clientid: <EXTRA REDACTED>
I0812 04:28:02.853566   20203 keyvaultFlexvolumeAdapter.go:71] retrieving secret <SECRET-NAME> (version: )
I0812 04:28:02.963212   20203 keyvaultFlexvolumeAdapter.go:102] azure KeyVault wrote secret <SECRET-NAME> at /var/lib/kubelet/pods/<POD-2-GUID>/volumes/azure~kv/kv-flexvol-0/<SECRET-NAME>
Mon Aug 12 04:28:02 UTC 2019 INFO: {"status": "Success"}
Mon Aug 12 04:28:22 UTC 2019 INFO: {"status": "Success"}

Steps To Reproduce

Deploy a cluster with AAD Pod Identity and Key Vault FlexVolume 0.0.11
Create/Apply 2 deployments which both mount the same secret from the same vault to the same relative location in each pod

Sample volume mount:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    app: {Name}
  name: {Name}
spec:
  replicas: 1
  selector:
    matchLabels:
      app: {Name}
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 10%
    type: RollingUpdate
  template:
    metadata:
      labels:
        aadpodidbinding: MSI
        app: {Name}
    spec:
      containers:
        image: {Image}
        imagePullPolicy: IfNotPresent
        name: {Name}
        volumeMounts:
        - mountPath: /run/certs
          name: kv-flexvol-0
          readOnly: true
      nodeSelector:
        beta.kubernetes.io/os: linux
      volumes:
      - flexVolume:
          driver: azure/kv
          options:
            keyvaultname: {VaultName}
            keyvaultobjectnames: {SecretName}
            keyvaultobjecttypes: secret
            resourcegroup: {ResourceGroupName}
            subscriptionid: {SubscriptionId}
            tenantid: {TenantId}
            usepodidentity: "true"
        name: kv-flexvol-0

Expected behavior
Both pods have their secrets mounted and available by the time the pod's container starts.
Key Vault FlexVolume version
0.0.11
Access mode: service principal or pod identity
Pod identity
Kubernetes version
1.14.5

@ankrause Thank you for reporting the issue. I'll take a look.

@ankrause I'm unable to reproduce this. I've 2 pods landing on the same node, requesting the same secret from same keyvault. The mount and the subsequent write seem to work as expected. Are you able to reproduce this consistently or is this behavior intermittent?

Thanks for the quick fix!


uint8_t won't typically hold 1,000

change to uint32_t
uint32_t temp_read_interval = 1000;  // This is in milliseconds

That's a good point, thanks!


Expose autoscaling controls like minScale, maxScale, and scale-to-zero-grace-period on Knative deployers

As a riff user I would like to deploy long-running apps or apps which don't receive input requests using a Knative deployer. Currently this is difficult because of autoscaling to zero after a 30s default idle time.
See also #1340 and Knative Serving docs

Suggest following RFC process to evaluate design alternatives e.g. new CLI flags or alternative kustomization.

Added min and max scale flags to the cli for the knative deployer:
https://github.com/projectriff/cli/pull/174


Target branch never built

OPS Build status updates of commit fbafde7:
:clock10: Pending: waiting for processors (51 builds ahead of you)
:warning: OPS Build is busy, currently there are 51 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

OPS Build status updates of commit fbafde7:
:clock10: Full build: the average full build time is 10 min(s) 6 sec(s), this is based on the last 4 build(s) for this repository.
:warning: This is a FULL build due to the 'branch-never-built' branch being a new branch in Open Publishing service and is still building. No action is required on your part. For more detailed info, please click here.

OPS Build status updates of commit fbafde7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

tester/1/index - Copy (2).md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit fbafde7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

tester/1/index - Copy (2).md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


The search bar at https://jestjs.io/en/ is broken

Nothing happens when you hit Return after entering search criteria.

Duplicate of #6640


Ability to ignore static secrets

Is your feature request related to a problem? Please describe.
Support skipping static secrets when creating certificates. This feature would allow having static and dynamic SSL certificates in the same ingress.
Describe the solution you'd like
Annotation on the static secret to inform cert-manager to ignore the secret.
apiVersion: v1
data:
  tls.crt: LS0tLS1C...
  tls.key: LS0tLS1C...
kind: Secret
metadata:
  name: static-certificate-foo
  namespace: infra
  annotations:
    certmanager.k8s.io/ignore: true
type: Opaque

Additional context
The ingress could mix both types of secrets. In the following example, cert-manager will only manage lets-encrypt-certificate-bar secret.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    certmanager.k8s.io/acme-http01-edit-in-place: "true"
    certmanager.k8s.io/cluster-issuer: letsencrypt-staging
  name: ingress
spec:
  rules:
  - host: foo.com
    http:
      paths:
      - backend:
          serviceName: foo
          servicePort: 80
        path: /*
  - host: bar.com
    http:
      paths:
      - backend:
          serviceName: bar
          servicePort: 80
        path: /*
  tls:
  - hosts:
    - foo.com
    secretName: static-certificate-foo
  - hosts:
    - bar.com
    secretName: lets-encrypt-certificate-bar

/kind feature

Have you considered just manually creating your Certificate resources instead of using ingress-shim? ingress-shim is supposed to allow basic usage of cert-manager without having to create Certificate's. I feel like introducing this sort of mechanic into the main certificate's controller doesn't really hold much value except for when using ingress-shim like you've described, and in those instances, you can quite easily manually manage your Certificate resource.
In terms of the actual implementation here, it'll be a slightly more complex thing to implement as right now, ingress-shim never actually touches/reads Secret resources at all. It simply creates Certificate resources for each secret.spec.tls[].secretName entry.

@munnerz haven't considered it, it's a great option.
Testing the suggested approach worked well for the Let's Encrypt Certificate resource, although for the static certificate it could not initialize the CA issuer. Which Issuer type should I use or the static Certificate resource?
Name:         custom-certificate-nginx
Namespace:    ...
API Version:  certmanager.k8s.io/v1alpha1
Kind:         Issuer
Spec:
  Ca:
    Secret Name:  custom-certificate-nginx
Status:
  Conditions:
    Last Transition Time:  2019-03-13T23:42:52Z
    Message:               Error getting keypair for CA issuer: certificate is not a CA
    Reason:                ErrInvalidKeyPair
    Status:                False
    Type:                  Ready
Events:
  Type     Reason             Age                 From          Message
  ----     ------             ----                ----          -------
  Warning  ErrInitIssuer      17m (x28 over 43m)  cert-manager  Error initializing issuer: Error getting keypair for CA issuer: certificate is not a CA
  Warning  ErrInvalidKeyPair  2m (x43 over 43m)   cert-manager  Error getting keypair for CA issuer: certificate is not a CA

@munnerz Your suggestion worked great, ignore the previous comment.
The solution is comprised by:
(1) Remove the ingress-shim from Ingress
(2) Create manually a Certificate resource for the lets encrypt certificate
(3) Create manually a simple Secret containing "crt" and "key" for the static certificate
(4) Map on the Ingress tls the hosts and secrets
To load a the static certificate on GKE Ingress mapping a simple secret is enough.
Thank you.


Some version numbers in commit message are wrong

For example, I have the following commit messages:
Update redis from 3.2.2 to 0.6.1
Update sass from 3.4.21 to 3.3.6
The to version number should be higher but it's lower in these cases.

This is due to the way the updated version is being parsed:
updated_version = `bundle list | grep #{gem[:name]}`.split('(')[1].split(')')[0]

You are relying on grep, which is not enough because grepping for sass will also find a match in bootstrap-sass, which is where it got 3.3.6 in my case.

Ah, thanks for the report and the debugging. I'm going to do some improvements to that regex now and release 0.0.7.

https://github.com/lpender/bummr/pull/9


fix(versions): update Activiti/activiti-cloud-application-chart versions

UpdateBot pushed helm dependency: activiti-cloud-notifications-graphql to: 7.0.20

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-notifications-graphql 7.0.20

/test this
/approve


Bump pyadditive version for 24.2 release

We will do a patch release at the end of the week @pkrull-ansys


operator kubecost-operator (v2.4.1)

Cloud Workflow: Don't run this again. CSV has no directives. Highest version in channel wins, and this version disappears.


ci: allow git tag and config.process.release to differ

This is useful for rare hot-fix releases, where we need to update the version of the code, but we don't want to run the upgrade through the protocol!
As a bonus, the --build part of the release script now works on macOS.

Yeah, I don’t see a good way to test this :(