vi/vim.basic does not responds to keyboard input.

Your Windows build number:  (Type ver at a Windows Command Prompt)
16193
Does not occur in 15063 and 16188.

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)
Launch vi does immediately hang. no longer responds.
If killed vi process, returned terminal will not responds.
But, react to kill -HUP.
Does not occur using vim.tiny or vi -u NONE.

What's wrong / what should be happening instead:
Can edit file.

Strace of the failing command, if applicable:  (If <cmd> is failing, then run strace -o strace.txt -ff <cmd>, and post the strace.txt output here)
https://gist.github.com/0xbadfca11/00a1efe36b690dc1927fd844355a125e/raw/e1c50b41c59f594ab557ebb1ae73736e05366f08/strace.txt

Don't worry, we already have for this committed and on it's way up :)

Yep, that's just caught me out. No worries... any idea how long before the next flight? I could do with a day away from coding :-)

@Warblefly unfortunately there's basically no way for me to predict how long it'll take the code to get out, sorry.

Fair enough. I understand the release schedule is decided elsewhere. Just so you and the team know, I use this subsystem every day for compiling lots of code, and its output is a vital part of my work at a major British university. The compilation still works and I can use another editor beside vim for now. It'll be nice when it's back.

@Warblefly - First, let me acknowledge that breaking vi is something that we are definitely not proud of. We understand the pain. The issue is fixed internally in our dev branch and we would like to fast-track it. But, we can use your and others help with that. If more people want the fix faster, its easier for us to justify the fast-track. So, if this is important to you and anyone else, please chime in here.
We are always happy to hear when someone tells us that WSL is useful within the education industry. And, we are glad you can use this as your daily driver.

True. I try to take things lightly, but vim is my standard editor for a lot of professional work in and out of university. To have it not working is going to affect development seriously. I hope you can let the release people know that. Are there any workarounds, other than disabling all the vim features I use every day?

I have a workaround because this bug has, unfortunately, become mission-critical this morning.
Use sshd.

Start your Bash shell on Ubuntu under Windows as normal.
Make the privilege separation directory for sshd:
sudo mkdir /var/run/sshd
Control its permissions:
sudo chmod 0755 /var/run/sshd
If you're willing to use password authentication instead of public/private key, edit /etc/ssh/sshd_config to allow this (use the pico editor to change "PasswordAuthentication" from "no" to "yes")
Start sshd:
sudo start-stop-daemon --start --pidfile /var/run/sshd.pid --exec /usr/sbin/sshd -- -p 22

Now use something like PuTTY to log into localhost (<IP_ADDRESS>) and Vim, in all its colours, works. You will need to login with your Ubuntu on Windows username and password (i.e. the password with which you set-up Ubuntu on Windows when you first installed it). You did make a note of that password, didn't you?
Bizarrely, the console as displayed by PuTTY.exe feels more responsive than the native console window.

If you don't need fancy terminal features, setting TERM to something like vt100 works.  E.g.:
TERM=vt100 vi ~/.bashrc

If more people want the fix faster, its easier for us to justify the fast-track. So, if this is important to you and anyone else, please chime in here.

Consider this me chiming in, although I'm very grateful to @aledell for the workaround or else I'd be using ed or (gasp!) emacs.

If more people want the fix faster, its easier for us to justify the fast-track. So, if this is important to you and anyone else, please chime in here.

Breaking the default editor should be enough to fast track, no? Anybody using git is likely experiencing.
Anyway, this is my +1 to please fast track this fix.

This is very disappointing and is causing me significant inconvenience. I am always trying to evangelise WSL and this bug doesn't help the cause. Getting the fix out quickly is paramount.

Could this be related to console changes (and not specifically bash) in latest insider build?
Since latest Windows insider build, vim doesn't work anymore. Under bash it hangs like described here, and when ran under normal CMD prompt, display gets empty and it seems to hang too (but I cannot see because display is empty).
This did not happen with previous builds.

@warpdesign Yes this is a console change that broke this. We had a pretty high code delta that this bug was introduced in. These kinds of issues are expected with Insider's builds.
I'm not positive that this will work, but based on what the fix for this bug was, it might be possible to get around this bug:
I believe that if you immediately start hitting a key on the keyboard after launching vi (eg, spamming 'enter'), then you'll avoid the bug case, and vi will work normally. It might not work on faster (normal) PC's, but it does work on my VMs. The key is to have some input in the input queue as vi is launching.

@zadjii-msft Thanks for the wordaround. I found out that any app using the console (like VSCode) is also impacted by the bug. For now I found that checking "use legacy mode" in the prompt window fixes the problem in both cmd.exe and any app using the concole like VSCode (but it prevents the use of bash).
I hope this bug will get fixed quickly.

PhD student in astrophysics chiming in!
Even though half of my work goes over SSH, eg. running simulations on supercomputers, vim is essential to get the other half of the work done: writing papers.
I found the suggestion of @aledell to work well:
echo "export TERM=vt100" >> ~/.bashrc

Found this after a lot of head-banging (including removing and reinstalling WSL). I'm using an alias to workaround this (alias v='TERM=vt100 vim' - Thanks @aledell!). Would love for this to get bumped up in priority. I'm not looking forward to using emacs for a while. 😆

Chiming in for the fast-track request. I can live with the TERM workaround or using nano for the time being to touch files. Where this bites me is that with vim as the default editor, I'm hitting this as other programs (today it's kubectl) invoke it for editing & those are ignoring my hacks :)

Here is a convenient summary of the workarounds. You can do this on the command line or update your ~/.bashrc

Set the TERM to vt100 by @aledell

export TERM=vt100

Create an alias for vim by @JoBrad

Do this if you don't want to universally set the TERM to vt100.
alias v='TERM=vt100 vim'

Set your default editor to something else or set the TERM env var to vt100

export EDITOR=nano
# or...
export EDITOR='TERM=vt100 vim'

@all - Thanks all for chiming in. With your support, the bug has been approved for fast-track.

@sunilmut Great! What does fast-track exactly mean? Can we expect a fix in the next insider build?

I hope this will be sooner than later, because I might go back to Linux over the weekend. This bug is really frustrating.

@warpdesign If all goes according to plan, it'll likely be in next week's Insider fast-ring build. That's as fast as it can move up and out.

For those complaining, DO NOT USE FAST RING IF YOU'RE UNWILLING TO SUFFER SOME CONSEQUENCES!!!!
I look forward to this getting fast tracked.
I simply changes my term via an alias to get around it. Used nano for a bit too.
Good job Microsoft. Keep it up.

I have installed build 16199 from yesterday and unfortunately the problem with vim is still there: the moment vi is ran, display gets empty & it locks.
Back to legacy mode again ;)

Running on fast-ring this is something we should expect. But is there any change to get this fix via WU? I do understand that it might be a dependency hell to get it work (resulting basically in a new insider-build), but i would be nice not having to wait for the next insider release to fast, since it obviously did not hit in 16199.
Anyway, keep up the good work :-)

Running through the MinTTY/wslbridge doesn't have this problem either - simpler workaround than enabling SSH...

FWIW adding my $.02 to fast track this.

The problem is indeed related to any xterm related TERM variable.
I am on Microsoft Windows [Version 10.0.16199.1000] from an update today, and it is not yet fixed.

Did the fix get delayed to next weeks release?

Any idea when this will be pushed?

@nickperry @Warblefly @mdavidsen & others: A polite notice:
I appreciate that this issue is a significant impediment at best, and a major PITA at worst, but I would like to point out that:

As was pointed out above, this issue has been fixed.
The fix is bubbling up our build tree and will emerge into insiders builds ~3 weeks after the fix is checked-in. Hopefully, it'll be in the next fast-ring insiders build.
We try to deliver fast-ring insiders builds most weeks.
We do not service Insiders builds via Windows Update since that's actually a slower process than delivering fast-ring builds, due to WU's additional scrutiny & process overhead.

Also, its important to understand the following:

Fast-ring Insiders builds are ~weekly snapshots of Windows as it is being built and, as such, the occasional issue/error will escape, despite our considerable efforts to not break users while we develop the next version of Windows. This is the cost you accept while signing-up for fast-ring updates.
WSL itself is a beta feature, as clearly stated both in the optional components dialog

... and in the first-run distro setup process

If you can tolerate a smaller amount of disruption, please adjust your settings to subscribe to slow-ring updates where fewer issues will appear.
If you cannot tolerate even a small amount of disruption, please do not use Insider builds: Fully released versions of Windows are likely your best option.
Thanks everyone for your support: Your bug reports and feedback is enormously valuable, but we do ask for a little patience and understanding as we progress through each release cycle.

Another workaround which doesn't loose all the syntax highlighting, screen switching, etc., goodies is to switch to neovim - note you should copy / link your ~/.vimrc to .config/nvim/init.vim, and configure git, $EDITOR etc, to use nvim instead of vim.
@bitcrazed I believe this is actually a console bug (Git bash hangs the same way for me), not a WSL bug, thus the fact that WSL is in beta is not relevant :) - but yes, your general point is valid. Part of the problem is that workflow-breaking bugs like this are fairly rare, (Ctrl-C breaking is the only one bigger at least for this for this crowd I can remember, the 100% CPU bug not nearly as big - pretty good for 2 years of fast-paced builds) and slow ring builds are very slow, perhaps a 3-5 a release? Presumably the windows build team has lots of improvements to this they would like to do but are not worth the engineering effort, just like every other team :)

Other terminal capability files may work better, if people are still having this issue.
I set my terminal to pcansi-43 and vi(m) is fine. I.e., in ~/.bashrc:
export TERM=pcansi-43
This should still support colour output for syntax highlighting.

On Wed, May 31, 2017 at 10:09 AM, dhorsley<EMAIL_ADDRESS>wrote:

Other terminal capability files may work better, if people are still
having this issue.
I set my terminal to pcansi-43 and vi(m) is fine. I.e., in ~/.bashrc:
Unfortunately, page up/down keys stop working with this TERM value :-(

I hope very much the fix makes it into the next Insider Build. This is
becoming a serious nuisance and is a work-halting regression, here.

Yes, even with workarounds (I generally use hjkl for movement in vi) you would still have other issues around pass-through of environmental variables. For example, using ssh from a 'worked-around' terminal, may pass on your new TERM setting to a remote workstation which doesn't understand the Windows/PC-compatible settings you had to use manually.
Either way, it needs a fix sooner rather than later. UoW is a pretty great facility, and has already helped free up resources on plenty of sysadmin and developer machines where I work with no real need any more to spin up a VM except for testing something environment-specific.  It would be a shame to have to take a step back from that over what I am guessing is most likely a very small bug fix in the console.

@sunilmut 21 days ago:
@ALL - Thanks all for chiming in. With your support, the bug has been approved for fast-track.

3 weeks and counting. 😞

@djensen47 - It should be fixed in the next release. Sometimes things do get held up for reasons outside our direct control. Apologize for the delay and the inconvenience caused. And, thanks for your patience.

We fixed an issue resulting in VIM being broken for Windows Subsystem for Linux (WSL) users in result flights.
https://blogs.windows.com/windowsexperience/2017/06/08/announcing-windows-10-insider-preview-build-16215-pc-build-15222-mobile/

Note,  This build also fixes the same issue I had opening Git for Windows bash, it seems like it was a conhost.exe bug, not WSL specific, maybe?

@simonbuchan - Yes, it was a conhost bug, not WSL specific.

PS: fixed in today's update!

How to update this fix?

@zyf0330 - Install Insider build 16215

Was so looking forward to this, but 16215 broke my start menu.  Thanks for the workaround @aledell

@AndyGauge I see that newest version in insider is 16193, so where did you get it?

@zyf0330 I rolled back to 16199.1000 delivered through fast ring Windows Insider Program. Looks like 16226 wants to install today.

I'm observing the same vim.basic hanging behavior now. Keys do not respond in that shell any longer. I can run it in tmux. 1 pane responds while the pane with vim does not.

@offero Considering the initial issue described by this thread was confirmed fixed over a year ago, what you're seeing is almost certainly a new issue. Could you open a new issue on this repo to track and debug what you're seeing now (rather than necro'ing an old thread)?


Run diff command on mssql output a lot of column "defaultValueConstraintName changed" messages

Environment
Liquibase Version: 4.3.2
Liquibase Integration & Version: CLI
Liquibase Extension(s) & Version: NA
Database Vendor & Version: MSSQL 2016
Operating System Type & Version: All
Description
When execute exact same table DDL on two MSSQL servers, the MSSQL engine will generate column default value constraint name with pattern DF__<table name>__<column name>__<random string>, see examples below:
DF__T1__lastLoginDat__3FA7F1A5

In such case, use liquibase diff command will generate a lot of messages about column changed similar to the following:
Changed Column(s):
     dbo.T1.lastLoginDate
          defaultValueConstraintName changed from 'DF__T1__lastLogi__3FA7F1A5' to 'DF__T1__lastLogi__41903A17'

The table structure and all column default values are actual same, but I cannot find a way to avoid these noise messages from diff.
Steps To Reproduce

Prepare 2 mssql server databases.
Execute the following DDL on each databases:

create table T1
(
	lastLoginDate bigint default 0
)
go

Inspect the default value constraint name generated on each databases, they should looks like the following:

# database 1:
DF__T1__lastLoginDat__3FA7F1A5
# database 2:
DF__T1__lastLoginDat__41903A17

Run liquibase diff against 2 databases

Actual Behavior
We inspect the messages similar to the following from diff command output
Changed Column(s):
     dbo.T1.lastLoginDate
          defaultValueConstraintName changed from 'DF__T1__lastLogi__3FA7F1A5' to 'DF__T1__lastLogi__41903A17'

Expected/Desired Behavior
I think we should have a way (or a configuration) smart compare default value constraint name, or exclude it in some way.
Screenshots (if appropriate)

Additional Context
I find there is a global configuration diffColumnOrder, maybe we should exclude the defaultValueConstraintName in same way.

Created PR #1729 for reference.

Thanks. We have some scattered code around to handle often auto-generated names better in diff comparisions. It may be worth trying to unify and codify that all a bit better. I think people tend to either care about those auto-generated names or not. (usually not).

Thank you @nvoxland, totally agree, user may not care some of non-business database object during diff. If we can design a unified flag allow us turn this off, will be awesome.

Thanks @MatrixDai for writing up this issue with such clarity and the PR to fix your issue.  We will add this to our list of issues to process.

@molivasdat
This issue has being bother me for over a year, do we have a plan to fix this issue?
I'm trying to maintain the PR #1729 up to date several times, so your team have a clear vision how the change impact the whole Liquibase product.


Fixes that SA1100 does not support base indexer calls

Fixes #1247

:question: Shouldn't the regression test fail before the fix?

:+1: The regression tests fail for me locally when run specifically on the first commit (before the fix).


Create HTML Form processing utilities - CSRF protection

In addition to being able to render forms more easily, request parsing that can handle form/multipart/etc data needs to be implemented. Again, the strategy is to not leave the user on their own to implement the functionality.

Done


Could not find type LuauVM in the current scope

Godot version
4.0.3
godot-cpp version

System information
Macos
Issue description
I installed and compiled the plugin and still get the issue

GDLuau probably supports only 4.1/4.2/4.3 versions of Godot, I never tested it on 4.0.x


Upgrade to Scala 3.3.3

Generally, Indigo has been at the bleeding edge of Scala / Scala.js versions. I'm wondering though if it would be sensible to stay on the LTS version rather than upgrading to 3.4.x.... Indigo's development has never been particularly sensible though... :thinking:

Having mulled this over, I think our libs should go LTS. Scala's tooling story needs all help it can get...

Soo we had a bit of a group discussion, and the view was that actually Indigo should live on the bleeding edge until 1.x.x is released (so... 2035-ish). Tyrian and Ultraviolet are lined up for 3.4.1 now. and Indigo will follow.


Question: Does this action support workflow_dispatch events that are triggered via API call?

Exactly as the question says, I'm running a job that is triggered via workflow_dispatch event from an API call. Just wanted to know if it would be compatible or not.

From the looks of it here, only the "push" and "pull" events are supported: https://github.com/byu-oit/github-action-disallow-concurrent-runs/blob/master/index.js#L12

This action is being deprecated as GitHub Actions now supports this natively: https://docs.github.com/en/actions/using-jobs/using-concurrency


How to chain inline svg loader with babel?

It looks like vue-svg-loader outputs es6 code. Is it possible to chain babel to process the output of that plugin?

For anyone coming after me, this worked:
    const oneOfInline = config
      .module
      .rule('svg')
      .oneOf('inline')
    oneOfInline.uses.clear()
    oneOfInline
      .use('babel-loader')
      .loader('babel-loader')
      .end()
      .use('vue-svg-loader')
      .loader('vue-svg-loader')
      .options({ svgo: false })

Can use this command to inspect the webpack output vue inspect --rule svg

Might be nice to add an option to include babel here?


docs: image layers' path in aufs-driver.md

Please help review it since I double check on ubuntu 14.04.
Fix typo in file path for image layers.
Signed-off-by: bjcheny<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:companycy/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM
(note, however, that this section is going to change in 1.10 due to the new content-addressable storage, see https://github.com/docker/docker/pull/19240 for a work-in-progress)


Avoid measuring video streaming in background

As a Mediapulse analyst I am only interested in foreground video playback. Background video playback without visible experience (<50% of the video image size seen) should not be measured.
After a Q&A session with MediaPulse and comscore teams, it appears that we should not use Analytics.notifyUxActive methods.
Acceptance criteria

comScore analytics are paused while playing video content in the background.
No changes for CommandersAct
Remove notifyUxActive / notifyUxInactive

Tasks

[ ] Remove Analytics.notifiyUxActive calls.

Background detection doesn't suffice, for exemple, a player is playing and when closing the Activity player and continuing playing, it goes back to the "main" application with maybe a little player UI telling user something is playing. In this case, the application isn't in background, but the player should not be tracked with comscore.
Possible solutions:

Track Player surfaceSize changed. When 0 mean no video surface attached. But some issue with value has been discovered when used with MediaController / MediaBrowser. The width and height send 0 or -1 never the real size.

Last ComScore validation ask to not track media playback when the video surface isn't visible.


MediaPipe CodeLabs Samples Image Generation Android: App Crash on Initialization (GPU Memory?)

logcat.txt
I have attempted the codelabs tutorial in full, as well as attempted to build the full plugin app available in the non codelab samples directory. I have converted the models and loaded them into data/tmp/image_generator/bins/.
I have downloaded the test apk from google apis, and it works at any resolution below 512.
I have attempted to lower the resolution of the generation in both the unbuilt projects I have access to,
running the android profiler, it appears to be a GPU memory overflow.
I would appreciate any assistance, or a link to the project file that was used to build the apk that is currently at:
[https://storage.googleapis.com/mediapipe-tasks/image_generator/imagegenerator.apk] so that I can compare the code.
The built apk is definitely handling the coroutines differently or offloading or downscaling the bitmap or something, i tell you hwat.

OnePlus12 Snapdragon8Gen2 16GB of RAM
this pipeline honestly looks like a mess, I've been reading the other issues, it seems like a different error basically every time.
If the demo apk is opensourced now can I have the project file that built that apk exactly? I can probably figure it out from there. Paul please, i know ur busy but my dude, plz

runtime error :


add array to parameter's options

Add array to parameter's options and update html template.

Was looking for this option just today...
My current workaround is declaring the parameters like this:
with_options scope: [:fulfillable_items, " "], required: true do
  parameter :order_id, "The Order the items belong to."
  parameter :item_ids, "The Items to be fulfilled. "\
                                    "Must all belong to the same Order."
end

and then do the request with explicit params
my_params = { fulfillable_items: [item_1, item_2, ..., item_n] }
do_request(my_params)

The docs output looks something like this:
fulfillable_items[ ][order_id]    The Order the items belong to.

@jorgeaguirre would your PR make this a little more elegant, or is it about something completely different?

Closing due to age.


503 Service Unavailable backend error

Web.xml with the servlet markup make the API fail

I am not sure it was that


update builders for 1.17.0 stable release

Update refs regex and recipe to use for stable builders and delete the now deprecated hotfix builders.

Hmm, validate_config says that:
Error: the following files need to be regenerated: luci/commit-queue.cfg.
  Run `lucicfg generate "./config/main.star"` to update them.

when running that I get no diff on commit-queue.cfg though, and I don't see why there should be...

This PR has no diff on that file and when running locally I still get no diff on commit-queue.cfg though. It also seem to me that given my change, there shouldn't be...

Okay, this is a problem in master, will fix separately...


Consider adding an adt-by-cell matrix to Figure S2

In Figure S2, the current legend text describes that both a gene-by-cell matrix and an adt-by-cell matrix are produced and read into R: https://github.com/AlexsLemonade/ScPCA-manuscript/blob/51b1cdc8f97e738e358ed689e0b863b9faa357b4/content/100.figure-table-legends.md?plain=1#L141-L145
But, the figure itself does not show an adt-by-cell matrix, only the gene-by-cell matrix.
This issue is meant to a) discuss whether we should add it to the figure, and b) if so, track adding it in. Noting that one reason to not include it is that it may make the figure too crowded, and there's already a lot going on in it.

I would say add it, and I don't think we need to discuss it further.

I think I should be able to add this myself in Illustrator!

Here's a screenshot of how I've redesigned the figure. Any thoughts before I update pdf/png? @allyhawkins


Add option to limit expired moments

Add a boolean configuration setting to limit the number of expired moments kept.
This will keep very long running games from slowing down and reduce save bloat at the cost of breaking the visited family of functions.
Tasks

[ ] Add the Config.history.limitExpired boolean property (default: false).  When enabled, expired moments will be limited to some TBD amount—probably the default max states or twice that; i.e., 40 or 80.
[ ] Make the visited family of functions throw with an appropriate error message when the above setting is enabled.
[ ] Loudly warn, in its documentation, that enabling the setting will break the visited family of functions and that it should not be changed mid-project, since it drops history.

Maybe

[ ] Make State.expired immutable.
[ ] Add warnings about the setting to the documentation of the visited family of functions?

If Config.history.limitExpired can only be boolean and State.expired is immutable, then it's impossible to set a precise amount the user want.
My preference is have State.expired be immutable(or even all of the undocumented stuff immutable) but let history.limitExpired be a number instead of boolean. Safety can be implemented to check against invalid values(like negative or float) and the user can be warned against stupidly low values in the docs.

Don't know. Maybe the user want to track some statistics based on the passage names of the last 1000 visits. Maybe someone's passage need the player to visit the same passage 100 times in a row and the only way out depends on previous().
I know these can be implemented/achieved in a better way by the player. Point is this is an arbitrary limit(40/80 or infinite) when it could've been easily be a tunable number. The explaination about have it be just small or have it be infinite can be in the docs and guide the users there. Maybe a "don't touch unless you are experiencing this issue and have pinpointed the cause to this" too.
I sincerely doubt there will be a flood of report/complaints about game being broken because of incorrect use of a feature buried in the Config API section of the docs.

The more I think about this the more I think this idea is unneeded. The edge cases this feature would help are so rare, and I think for most users, deactivating session storage as a means to squeeze more performance out makes more sense than allowing users to get rid of the expired history.
On a philosophical level, maybe users should have this setting, but on a practical level, no one who is writing good code should really need it.

Here's the problem.
In a moment of weakness, (on Discord) I provided a solution to a user for an issue they were having.  I say in a moment of weakness because I exposed an engine implementation detail that I'm normally loath to do—I blame lack of sleep.
Stupid, yes, but no big deal and the whole interaction should have gotten buried in the channel as normal.  That should have ended it, done, finito.
It didn't end there though.  Several hours later it was brought back up.  That got a few people's attentions and it snowballed from there.  Code was refined, explanations were made.
I'm not blaming anyone but myself, to be clear.  The point is that the cat is out of the bag.    Please do not start doing this as a general thing.  It's a dirty hack that I gave to someone who was experiencing issues with their published game.
If you're not having flaming pitchforks thrown at you by your players, do not preemptively break your game's history.

They're going to anyway.  You know they are.
I don't want to add this setting, or anything like it, but I also don't want to see State.expired splicing hacks.  Especially when people are never going to tell you they're using the damn hack in the first place.
I just want to turn back time at this point.

I think I'm just going to delete the #sugarcube channel and forget this shitshow ever happened. 😏

I've deleted my discord messages containing that code and explanation, how it helps 😟

You didn't need to do that.  As I said, I'm not blaming anyone but myself for this fiasco.
I do appreciate the effort though.


Phi K correlation variable order

For me all correlation plots show variables in the (domain-specific sensible) order of the columns in my data frame.
Only Phi K shows them in some other order.
Is this a bug or a feature?
Is there a setting to get the "good" order?
This is with pandas 1.3 and pandas-profiling 3.0.0

The correlation variables should have the same order, so this is a bug.
Anyone who is interested, feel free to dig in to see where the issue is.
Starting point

@sbrugman Can I give this a shot? ✌🏻

@abhicantdraw Of course, many thanks!

The issue is that selcols is a set which is unordered?
And the solution would be to instead use a list or dict to preserve order?

@cdeil Yup exactly, that's what this PR's doing.


Support standard url param called 'route' besides configurable router links

Currently we generate url commands of configurable link out from object i.e { route: 'product' }. But such an object is also a valid Angualr's url command which is equivalent to url: /;route=product.
Not to hijack the word route, we should use more specific key like { cxRoute: 'product' }. But then the usage with the cxUrl pipe will look strange:
<a [routerLink]="{ cxRoute: 'product', params: item.product } | cxUrl">

It leads into the question: maybe we should generate configured URL segments one layer deeper (in the extended Angular's Router.createUrlTree method) and just simply pass an object to the routerLink without the pipe:
<a [routerLink]="{ cxRoute: 'product', cxPrams: item.product }">

(Relative links would be only when passed string before object in array, ie. [ './', { cxRoute: ... } ])

route should be renamed to cxRoute. Perhaps in other ticket (or in this one if time allows) remove cxUrl pipe and do the logic one layer deeper (in extended Router)


Crash on writing to stream

What version of gRPC and what language are you using?
grpc 1.41.1, C++17
What operating system (Linux, Windows,...) and version?
Linux Ubuntu 18.04 and 20.04 (fully updated) on x86
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc 9.3.0
The full build environment environment can be found in the Docker image: cogment/orchestrator-build-env:v2.0.0
What did you do?
When a ServerReaderWriter.Write() is done (on the server) and the client has closed the stream (possibly in an abnormal way), instead of returning "false", a SIGSEGV signal is generated.
What did you expect to see?
Not crashing and the Write() function to return "false".
What did you see instead?
Crash with SIGSEGV
Anything else we should know about your project / environment?
Stack trace
01:  pure virtual method called
02:  terminate called without an active exception
03:  myprog(+0xc95403)[0x561bb2435403] _ZN12_GLOBAL__N_115sigsegv_handlerEi
04:  /lib/x86_64-linux-gnu/libc.so.6(+0x46210)[0x7f9d847dd210] killpg
05:  /lib/x86_64-linux-gnu/libc.so.6(abort+0x213)[0x7f9d847bc941]
06:  /lib/x86_64-linux-gnu/libstdc++.so.6(+0x9e911)[0x7f9d84b91911] __cxa_throw_bad_array_new_length
07:  /lib/x86_64-linux-gnu/libstdc++.so.6(+0xaa38c)[0x7f9d84b9d38c] _ZSt17rethrow_exceptionNSt15__exception_ptr13exception_ptrE
08:  /lib/x86_64-linux-gnu/libstdc++.so.6(+0xaa3f7)[0x7f9d84b9d3f7] _ZSt9terminatev
09:  /lib/x86_64-linux-gnu/libstdc++.so.6(+0xab155)[0x7f9d84b9e155] __cxa_pure_virtual
10:  myprog(_ZN4grpc15CompletionQueue5PluckEPNS_8internal18CompletionQueueTagE+0xc8)[0x561bb24b8b0e]
11:  myprog(_ZN4grpc8internal22ServerReaderWriterBodyIN10playAPI18ActorRunActInputENS2_19ActorRunActOutputEE5WriteERKS3_NS_12WriteOptionsE+0x1b3)[0x561bb24d5e81]
12:  myprog(_ZN4grpc18ServerReaderWriterIN10playAPI18ActorRunActInputENS1_19ActorRunActOutputEE5WriteERKS2_NS_12WriteOptionsE+0x33)[0x561bb24d591b]
13:  myprog(_ZN4grpc8internal15WriterInterfaceIN10playAPI18ActorRunActInputEE5WriteERKS3_+0x52)[0x561bb24d2614]
14:  myprog(_ZN7play2ServerStream5writeERKN10playAPI18ActorRunActInputE+0x2f)[0x561bb24d5831]

The crash seems to happen if the client closed the stream (possibly abnormally). It is reproducible, but requires many runs because it is timing dependent (I guess). We also could not reproduce with sanitizer, in a debugger, in valgrind or any other similar utilities we tried. It does reproduce with a debug build though. We did not go to the extent of producing a dump and analysing it.
Specifics
Server and client running on the same machine in different docker containers.
Server is in C++, client is in Python.
Python uses asyncio to run multiple streams "simultaneously".
C++ uses multi-threading to run multiple simulateneous streams.
We get a similar crash on a ClientReaderWriter.Finish() call (C++ is client, Python is server) possibly when the server has closed the stream.
We haven't tested if the same thing happens on ClientReaderWriter.Write() when the server has closed the stream.
Relevant Server C++ code to interpret stack trace:
// SIGSEGV signal is caught and a stack trace is output (starting at line 03 above).  Lines 01 and 02 seem to come from grpc (definitely not from our code).
// If Write or Read return false, we stop using that stream.
// If Write throws an exception, we stop using that stream.
// Writes and reads are in different threads.
// There is only one Write and one Read for each stream (i.e. no MP conflicts).

namespace play {
class ServerStream {
  bool write(const playAPI::ActorRunActInput& data) override { return m_stream->Write(data); }

  grpc::ServerReaderWriter<playAPI::ActorRunActInput, playAPI::ActorRunActOutput>* m_stream;
};
} // namepsace

Relevant proto to interpret stack trace:
package playAPI;
service ClientActorSP {
    rpc RunAct(stream ActorRunActOutput) returns (stream ActorRunActInput) {}
}

Some new/more information from valgrind. Without trying, we managed to crash while running in valgrind.  Hopefully it can help.
Invalid read of size 8
  at 0xE23C99: grpc::CompletionQueue::Pluck(grpc::internal::CompletionQueueTag*) (completion_queue.h:332)
  by 0xE412C2: grpc::internal::ServerReaderWriterBody<playAPI::ActorRunActInput, playAPI::ActorRunActOutput>::Write(playAPI::ActorRunActInput const&, grpc::WriteOptions) (sync_stream.h:766)
  by 0xE40D86: grpc::ServerReaderWriter<playAPI::ActorRunActInput, playAPI::ActorRunActOutput>::Write(playAPI::ActorRunActInput const&, grpc::WriteOptions) (sync_stream.h:801)
  by 0xE3D609: grpc::internal::WriterInterface<playAPI::ActorRunActInput>::Write(playAPI::ActorRunActInput const&) (sync_stream.h:125)
Address 0x191cf7e8 is 840 bytes inside a block of size 1,456 free'd
  at 0x483CFBF: operator delete(void*) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xF1FE09: grpc::Server::SyncRequest::~SyncRequest() (server_cc.cc:370)
  by 0xF2062E: grpc::Server::SyncRequest::ContinueRunAfterInterception() (server_cc.cc:451)
  by 0xF2028B: grpc::Server::SyncRequest::Run(std::shared_ptr<grpc::Server::GlobalCallbacks> const&, bool) (server_cc.cc:421)
  by 0xF20B28: grpc::Server::SyncRequestThreadManager::DoWork(void*, bool, bool) (server_cc.cc:791)
  by 0xF343A5: grpc::ThreadManager::MainWorkLoop() (thread_manager.cc:215)
  by 0xF3387A: grpc::ThreadManager::WorkerThread::Run() (thread_manager.cc:44)
  by 0xF33705: grpc::ThreadManager::WorkerThread::WorkerThread(grpc::ThreadManager*)::{lambda(void*)#1}::operator()(void*) const (thread_manager.cc:36)
  by 0xF33729: grpc::ThreadManager::WorkerThread::WorkerThread(grpc::ThreadManager*)::{lambda(void*)#1}::_FUN(void*) (thread_manager.cc:36)
  by 0x1334F62: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&)::{lambda(void*)#1}::operator()(void*) const (thd_posix.cc:140)
  by 0x1334FB0: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&)::{lambda(void*)#1}::_FUN(void*) (thd_posix.cc:145)
  by 0x4856608: start_thread (pthread_create.c:477)
Block was alloc'd at
  at 0x483BE63: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xF20B5B: grpc::Server::SyncRequestThreadManager::AddSyncMethod(grpc::internal::RpcServiceMethod*, void*)::{lambda()#1}::operator()() const (server_cc.cc:798)
  by 0xF247EB: std::_Function_handler<grpc_core::Server::RegisteredCallAllocation (), grpc::Server::SyncRequestThreadManager::AddSyncMethod(grpc::internal::RpcServiceMethod*, void*)::{lambda()#1}>::_M_invoke(std::_Any_data const&) (std_function.h:285)
  by 0x1067F65: std::function<grpc_core::Server::RegisteredCallAllocation ()>::operator()() const (std_function.h:688)
  by 0x1066FA2: grpc_core::Server::AllocatingRequestMatcherRegistered::MatchOrQueue(unsigned long, grpc_core::Server::CallData*) (server.cc:410)
  by 0x10642A5: grpc_core::Server::CallData::PublishNewRpc(void*, grpc_error*) (server.cc:1288)
  by 0x1064527: grpc_core::Server::CallData::StartNewRpc(grpc_call_element*) (server.cc:1329)
  by 0x1064623: grpc_core::Server::CallData::RecvInitialMetadataBatchComplete(void*, grpc_error*) (server.cc:1353)
  by 0xF5A978: grpc_core::Closure::Run(grpc_core::DebugLocation const&, grpc_closure*, grpc_error*) (closure.h:245)
  by 0x1050A79: post_batch_completion(batch_control*) (call.cc:1240)
  by 0x1050B2C: finish_batch_step(batch_control*) (call.cc:1255)
  by 0x1051A12: receiving_initial_metadata_ready(void*, grpc_error*) (call.cc:1527)

I found out that under some weird conditions we seem to have a stream->Write being done after:
grpc::WriteOptions options;
options.set_last_message();
stream->Write(data, options);

Which causes a crash.
I understand that this does not make sense, but it should still not crash. Either an std::exception should be thrown or ideally the Write should return false.
Also, the reading of the stream should still be possible after the set_last_message write. I could not test this.

Probably not related to above crash, but here is a crash that happens without any abnormal stream closing from the client:
myprog(+0xc97403)[0x563cf9a67403]
/lib/x86_64-linux-gnu/libc.so.6(+0x46210)[0x7effbb5ce210]
myprog(_ZN4grpc8internal4Call10PerformOpsEPNS0_18CallOpSetInterfaceE+0x18)[0x563cf9ae93e8]
myprog(_ZN4grpc8internal22ServerReaderWriterBodyIN10playAPI18ActorRunActInputENS2_19ActorRunActOutputEE4ReadEPS4_+0x75)[0x563cf9b07bf5]
myprog(_ZN4grpc18ServerReaderWriterIN10playAPI18ActorRunActInputENS1_19ActorRunActOutputEE4ReadEPS3_+0x2b)[0x563cf9b078c1]

I thought that maybe we were closing the stream, then trying to read. But even then it should not crash. An exception maybe, a false return yes, but not crash. Similarly if a stream was closed (normally or not) while blocked on a read, it should not crash.

Another crash similar without abnormal stream closing:
E1207 20:59:59.608023276      74 call.cc:1934]               assertion failed: grpc_cq_begin_op(call->cq, notify_tag)
myprog(+0xc97403)[0x55e24c2ef403]
/lib/x86_64-linux-gnu/libc.so.6(+0x46210)[0x7f3683a2e210]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x213)[0x7f3683a0d941]
myprog(+0xf496a0)[0x55e24c5a16a0]
myprog(grpc_call_start_batch+0x106)[0x55e24c5a19b3]
myprog(_ZN4grpc11CoreCodegen21grpc_call_start_batchEP9grpc_callPK7grpc_opmPvS6_+0x43)[0x55e24c450e21]
myprog(_ZN4grpc8internal9CallOpSetINS0_17CallOpRecvMessageIN10playAPI19ActorRunActOutputEEENS0_8CallNoOpILi2EEENS6_ILi3EEENS6_ILi4EEENS6_ILi5EEENS6_ILi6EEEE32ContinueFillOpsAfterInterceptionEv+0x16e)[0x55e24c3908b0]
myprog(_ZN4grpc8internal9CallOpSetINS0_17CallOpRecvMessageIN10playAPI19ActorRunActOutputEEENS0_8CallNoOpILi2EEENS6_ILi3EEENS6_ILi4EEENS6_ILi5EEENS6_ILi6EEEE7FillOpsEPNS0_4CallE+0xac)[0x55e24c390680]
myprog(_ZN4grpc6Server16PerformOpsOnCallEPNS_8internal18CallOpSetInterfaceEPNS1_4CallE+0x36)[0x55e24c46b8de]
myprog(_ZN4grpc8internal4Call10PerformOpsEPNS0_18CallOpSetInterfaceE+0x3d)[0x55e24c37140b]
myprog(_ZN4grpc8internal22ServerReaderWriterBodyIN10playAPI18ActorRunActInputENS2_19ActorRunActOutputEE4ReadEPS4_+0x75)[0x55e24c38fb4f]
myprog(_ZN4grpc18ServerReaderWriterIN10playAPI18ActorRunActInputENS1_19ActorRunActOutputEE4ReadEPS3_+0x2b)[0x55e24c38f81b]

I'm sorry this slipped through the cracks but can you please provide code for this in a gist maybe if this issue still exists? That would allow us to reproduce this.

I have the same issue with grpc v1.64.2 in android.


Caching on windows?

Hi! when I run the jobs on windows, ubuntu and macos, every windows build last as about the same time that the first time build of ubuntu/macos (~15min) so it seems to me that this action doesn't support some windows caching (I saw some caching steps in the log). Is that the case? is windows just  consistently slower? or am I running into a problem?
In comparison, every other macos/ubuntu build takes around 1min after the first build.

Can you share a build log? It sounds like you are inferring cache-misses based on build time, and you may be right, but we can see in the blog if caching actually missed or not.
I don't know of any intentional lack of cache support on windows. It would just be a bug if it's not working.

I suppose they're cache misses, but I'm not that sure

To investigate, you can expand the build step and look at the 2 (dependencies, then build) actions/cache steps. You want to check the key argument to see what key each was looking for, then the actual logs to see which cache was restored. If they match exactly that means a full cache hit and there should be no build necessary. If there is some cache restored, but the restored key doesn't match exactly, that means a partial cache hit and there should be some artifact reuse but also some compilation necessary -- depending on the actual change.
Linux:
Run actions/cache/restore@v3
  with:
    ...
    key: Linux-stack-deps-8b72ccca296d7557c917e1851110ce53a526bc0ea2c13e007ba6c4faefa3398d-4b6f817aa80b26f02cebe7e9791a3b5378f463eb482b016cc5630da090c6fa9f
    ...

...
Cache restored from key: Linux-stack-deps-8b72ccca296d7557c917e1851110ce53a526bc0ea2c13e007ba6c4faefa3398d-4b6f817aa80b26f02cebe7e9791a3b5378f463eb482b016cc5630da090c6fa9f

Run actions/cache/restore@v3
  with:
    ...
    key: Linux-stack-build-8b72ccca296d7557c917e1851110ce53a526bc0ea2c13e007ba6c4faefa3398d-4b6f817aa80b26f02cebe7e9791a3b5378f463eb482b016cc5630da090c6fa9f-d1827f44053ae294876f28993b22bbdb780f209e5c37708c3dec9c905c74be87
    ...

...
Cache restored from key: Linux-stack-build-8b72ccca296d7557c917e1851110ce53a526bc0ea2c13e007ba6c4faefa3398d-4b6f817aa80b26f02cebe7e9791a3b5378f463eb482b016cc5630da090c6fa9f-12aa29b99ad8817e5a753798dcf47e8a1e295e4d82d85902bdd069ccd0bccd56

Windows:
Run actions/cache/restore@v3
  with:
    ...
    key: Windows-stack-deps-5e2e8ac5295e547248aa5c37d8d78f5e8d2d2eec6eda0e19285e6e8d7f2a5445-e7a5ab2e2fb3775e618b645236d4ef2a1dc5233f175ec7b0055c73ec20659ecc
    ...

...
Cache restored from key: Windows-stack-deps-5e2e8ac5295e547248aa5c37d8d78f5e8d2d2eec6eda0e19285e6e8d7f2a5445-e7a5ab2e2fb3775e618b645236d4ef2a1dc5233f175ec7b0055c73ec20659ecc

Run actions/cache/restore@v3
  with:
    ...
    key: Windows-stack-build-5e2e8ac5295e547248aa5c37d8d78f5e8d2d2eec6eda0e19285e6e8d7f2a5445-e7a5ab2e2fb3775e618b645236d4ef2a1dc5233f175ec7b0055c73ec20659ecc-564a422d9fc8ce73f475a8eba307ff4832cf616de2848545be742d5f6f0a8e45
    ...

...
Cache restored from key: Windows-stack-build-5e2e8ac5295e547248aa5c37d8d78f5e8d2d2eec6eda0e19285e6e8d7f2a5445-e7a5ab2e2fb3775e618b645236d4ef2a1dc5233f175ec7b0055c73ec20659ecc-978a713f414ba4774ad25464f70169712e7229748e187717555c6f108b91a2d9

Both of these are behaving the same: the dependencies cache was a full hit (so there should be no need to install GHC or any dependency packages), but we have only a partial cache hit on the build step (indicating this commit has some source differences from the one that produced that cache). Depending on what actually changed, there may be some building necessary. In this case, I see the commit contains a non-Haskell change so I would still expect no building.
The Linux build behaves correctly and doesn't build anything, but the Windows build proceeds to do all the work again.
Unfortunately, I'm not sure where to go from here. The action seems to behaving correctly, but either actions/cache is storing something invalid or stack is misbehaving (or some combination) when used on Windows. It seems unlikely there is a bug in our action, although there may be some workaround we could implement, but I'm just not sure how to debug it further. If you're motivated, my only idea would be to make a workflow that performs the underlying caching and build steps of our action then see if it reproduces. If so, it would be possible to inject logging or other debugging mechanisms at that point.

Sorry for the late response... I forgot about this.
I think I just assumed that there was no cache hit on Windows because stack built everything from scratch, unlike the builds from the other OS'es. Anyways, I think I'm gonna leave it here. Thanks anyway!


Fix dependency version of symfony 4

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

Fixed tickets
~

License
MIT

Doc PR
~

Fix the invalid version of symfony/config dependency when the Symfony 4 is used.

A new inspection was created.

The inspection completed: No new issues


default shared object suffix on UNIX system should be .so (not .os!)

Looks like GCC implementation fixed this but when using cython/pyext which uses default createCFileBuilders this is not getting fixed alone the path.
This causes when using cython/pyext Tools file to create object file ending with ".os" instead of ".so".
Or if I ".os" has ever being a valid shared object output suffix which I am completely not aware of ...

SHOBJSUFFIX is for the object output from compiling, not for a shared library and thus the usage of .os and not .so
I'm looking at your: PythonObject builder and there's no action.
What are you trying to do?
Ideally you'd bring this discussion the scons users mailing list.

https://stackoverflow.com/questions/22560662/os-file-unrecognized-while-building-glibc
OK, I found one reference out there and this is the first time I know a object file can be named ".os" instead of just ".o".
Yes I got it wrong, thanks.

Bring your issue to the scons users mailing list and perhaps someone there can help you sort it out?

By the way, the PYEXTCC builder builds the .c file into .os file, which is then linked into a shared library (.so) file. I override now the .os to ".o" which is making more sense for me.

The reason for using ".os" for SharedObject is to prevent accidentally linking /fPIC object files with non-pic, which would cause runtime errors. If you know that's not going to happen in your build, you can just set SHOBJSUFFIX to ".o".

Thanks Gary.
This explains the motivation! I will keep using ".os" instead.
Also found a detailed explanation on PIE/PIC and when to use what, hope
this could help someone else:
https://lists.debian.org/debian-devel/2016/05/msg00309.html
For people like me come from embedded world, I almost always use no-pie
exclusively because the tiny extra performance always beats the relocation
needs.
On Mon, Mar 12, 2018 at 10:26 PM, GaryO<EMAIL_ADDRESS>wrote:

The reason for using ".os" for SharedObject is to prevent accidentally
linking /fPIC object files with non-pic, which would cause runtime errors.
If you know that's not going to happen in your build, you can just set
SHOBJSUFFIX to ".o".
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/pull/3105#issuecomment-372468333, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABmYxi6ZxciMvqu_K6D7M0KwFqfVTfSHks5tdughgaJpZM4Sl2SI
.

Indeed I had a client with some software in a HPC space. And shared library builds cost them 5-10% performance.  So devel builds were shared, but release were static.

Interesting. in HPC definitely it worth it even more than embedded world.
On Mon, Mar 12, 2018 at 11:01 PM, William Deegan<EMAIL_ADDRESS>wrote:

Indeed I had a client with some software in a HPC space. And shared
library builds cost them 5-10% performance. So devel builds were shared,
but release were static.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/SCons/scons/pull/3105#issuecomment-372477496, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABmYxnYAQZAGiBkmO3TJmOg8UT_h3U1iks5tdvAsgaJpZM4Sl2SI
.


Feature code style check GitHub Action

After a few alterations to the my suggested GitHub Action, it should now work properly.
I also ran npx prettier on all .js and .css files not in a /lib/ folder.

I believe the problem is that since dotnet format is ran on ubuntu-latest it does not like Windows new lines.
Could be fixed with changing it to windows-latest but that seems to increase the time the job takes by quite the bit.
Is there a better fix? I tried Googling but to no avail.

Looks like a good patch...  one request:  can we have the code formatting run first and have the Build and Test .NET project tasks run after the code cleanup?
Let's have the Build and Test actions depend on the code formatting job

Also:  this doesn't look like its updating the files in the repository when its done formatting them.
I think we want this only running when a pull-request is opened, and then update the source files in the remote repository so that we know they match our format when they're eventually merged

Also: this doesn't look like its updating the files in the repository when its done formatting them.

I touched on this in the issue that the idea was to make a "checker" rather than a "formatter" but I can work on it.
One thing I noticed while testing is that dotnet format doesn't like to fix naming rule violations:
> dotnet format .\src\TagzApp.sln --include .\src\TagzApp.Web\Pages\Error.cshtml.cs
Unable to fix IDE1006. Code fix NamingStyleCodeFixProvider doesn't support Fix All in Solution.


[2.2] Implement Abort(ConnectionAbortedException) override

This overload was added in ASP.NET Core 2.1 and doesn't invoke existing Abort() overrides.

This overload was added in ASP.NET Core 2.1 and doesn't invoke existing Abort() overrides.


Feature: multi-instance mode

Love this tool :heart:
❯ chatgpt -n
Error: Another chatgpt instance is running, chatgpt works not well with multiple instances, please close the other one first.
If you are sure there is no other chatgpt instance running, please delete the lock file: /tmp/chatgpt.lock
You can also try `chatgpt -d` to run in detach mode, this check will be skipped, but conversation will not be saved.

How (much effort) would it be to support multiple insances?
Would be amazing :)
Ready to throw a sunday at it (at some point this year :sweat_smile:)

oops, wrong repo. There are so many :sweat_smile:
https://github.com/j178/chatgpt/issues/92


Cannot use fongo in OSGi environment

Would be great to make it usable also within OSGi container.
For this to work, only two changes are needed, I believe:

Use maven-bundle-plugin to enrich the MANIFEST.MF

org.apache.felix
maven-bundle-plugin
2.4.0

avoid using package 'com.mongodb', i.e. move the 3 classes to another package

@lichtin any news ?

Sorry I didn't pursue this any further. Using fongo only outside of OSGi currently.


Resolve: unable to load footage

Describe the bug
Is it not possible to load footage into resolve
I can load single frames, but not video or frame sequence footage. Important to note that my footages do not start from 1, but 1001, or any other arbitrary number. This is the error I get.

resolved by https://github.com/pypeclub/OpenPype/pull/1422


arc-gtk-theme-git: 2016-06-02 -> 2016-06-06

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Although the Travis build fails, it seems to be because of Travis itself, as it has been reporting the cannot run configure or autogen.sh in other PRs too, although the scripts are there and have execution permissions.
It works locally for me.


AWS SQS/SNS setup questions

Hi,
As far as I understood MassTransit will create SQS and SNS queues and topics itself (that's why we have to have IAM role setup to allow this).
Questions:

Is it possible that I create and control SQS and SNS outside of MS and configure it just to use the existing infrastructure? (as opposed to MS creating necessary queues and topics). Basically I want devops to be responsible for AWS infrastructure.
If I needed more control over SQS/SNS configurations (like I must support encryption etc.) - how would I do it? Is this supported?

Thanks!

MassTransit requires permissions to create topics and queues, without it, the bus will likely fail to start or fail in ways that will be hard to diagnose later during program execution.

Thanks for your reply!
Could you give a quick hint about othe questions I've had there? I could not find anything related in the documentation, but it's really crucial for me. I would really appreciate!
Thanks.

Well, I feel like I answered the first one, the answer is no.
The second one, for each topic and queue, you can specify both attributes and tags as part of the configuration. There are some methods that will set the attributes as well, for certain known attributes.
To define attributes on a topic, you’d use the publish topology, whereas for a queue when configuring the receive endpoint.

@phatboyg we are running into a related issue - where the application is not allowed to create any queues and topics.  The thought is inline with AWS's least privilege.
It obviously makes sense to ensure that the queues and topics are created before the bus starts; we could start with checking if the topic/queue exists - and if it does - no need to create it; if it doesn't - the the app creates it.
In controlled environment like ours - if the queues and topics do  not exists, the service will fail to start (because the queue creation failed) - which is a fine as the we are required to create the queues and topics beforehand.


Allow for passphrase to be passed for SSL certificate

Simple change to allow the passphrase to be passed in for certificates.

Is this really necessary and are there multiple people that need this?

I don't know how to answer how many people need it.  But it was necessary for my situation at work.  We use certificates generated by a corporate certificate authority and they require an ssl passphrase.  This was a real world feature that I needed in order to be able to use Laravel echo server at work.

Ok thanks for the feedback. Let's make that one change and then I'll get this merged.

Removed the changes to the cli setup prompts.

Thanks, look forward to seeing this in 1.3.1.


Wrong conversion of 4e88ef386c93b9dceb98121d9457edbf

This
4e88ef386c93b9dceb98121d9457edbf

is wrongly to

And I should limit the binary convert to a certain number of digits.

Limited to Number.MAX_SAFE_INTEGER now in v1.1.2.


GH-37655: [C++] Allow joins of large tables in Acero

PR 35087 introduced an explicit fail in large joins with Acero when key data is larger than 4GB (solving the problem reported by issue 34474). However, I think (but I'm not sure) that this quick fix is too restrictive because the total size condition is applied to the total size of tables to be joined, rather than to the size of keys. As a consequence, Acero fails when trying to merge large tables, even when the size of key data is well below 4 GB.
This PR modifies the source code so that the logical test only verifies whether the total size of key variable is below 4 GB.

Rationale for this change
In the current situation, joins with arrow fail when the tables to be joined are jointly larger than 4GB, even if the key data is smaller than 4GB. This is due to the fact that the test on the size of key data is erroneously applied to the size the tables to be joined.
What changes are included in this PR?
I modify slightly the C++ code so that the test on the size of key data does not apply any more to the size the tables to be joined.
Are these changes tested?
Not so far.
Are there any user-facing changes?
No.

Closes: #37655

@oliviermeslin Thanks for this. This probably can't be tested efficiently in the test suite unfortunately, due to the test size required.

@raulcd : I think I solved the problem (I forgot to remove a trailing whitespace). Can you please re-launch the checks?

@oliviermeslin I agree it's too big to test in any kind of reasonable unit test.  have you run any tests manually with payloads larger than 4GB and confirmed the results are correct?

@raulcd : I think I solved the problem (I forgot to remove a trailing whitespace). Can you please re-launch the checks?

I've pushed a minor lint change, I do think that this should fix it. GitHub UI did not allowed me to propose the change to remove a trailing whitespace, that's why I just pushed myself.

Thanks @westonpace ! I already prepared some tests (one using artificial data, the other one using real data). Unfortunately, I could not install arrow as an R package from my own fork, because installing a development version of arrow seems to be quite complicated (see this issue). I'll try my best to find a solution and I'll let you know the result.

Hey @oliviermeslin, I ran your example from https://github.com/apache/arrow/issues/37655 w/o this patch and got the expected error after the script printed "Doing the join with 9 variables":

! Invalid: There are more than 2^32 bytes of key data.  Acero cannot process a join of this magnitude

I then built libarrow and the R package off your patch and actually got a segfault. Full output below:

Output with segfault
❯ Rscript acero-join-test.R
Welcome to R :)
This session's PID is 2890
Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.

Attaching package: ‘arrow’

The following object is masked from ‘package:utils’:

    timestamp

Attaching package: ‘dplyr’

The following objects are masked from ‘package:stats’:

    filter, lag

The following objects are masked from ‘package:base’:

    intersect, setdiff, setequal, union

[1] "Doing the join with 2 variables"
[1] "id"        "variable1"
[1] "Doing the join with 3 variables"
[1] "id"        "variable1" "variable2"
[1] "Doing the join with 4 variables"
[1] "id"        "variable1" "variable2" "variable3"
[1] "Doing the join with 5 variables"
[1] "id"        "variable1" "variable2" "variable3" "variable4"
[1] "Doing the join with 6 variables"
[1] "id"        "variable1" "variable2" "variable3" "variable4" "variable5"
[1] "Doing the join with 7 variables"
[1] "id"        "variable1" "variable2" "variable3" "variable4" "variable5"
[7] "variable6"
[1] "Doing the join with 8 variables"
[1] "id"        "variable1" "variable2" "variable3" "variable4" "variable5"
[7] "variable6" "variable7"
[1] "Doing the join with 9 variables"
[1] "id"        "variable1" "variable2" "variable3" "variable4" "variable5"
[7] "variable6" "variable7" "variable8"

 *** caught segfault ***
address 0x7ed0457b20, cause 'invalid permissions'

 *** caught segfault ***
address 0x7f6676b420, cause 'invalid permissions'

 *** caught segfault ***
address 0x7ed8992de0, cause 'invalid permissions'

 *** caught segfault ***
address 0x7ee948e360, cause 'invalid permissions'

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x)

Traceback:

Traceback:
 1: Table__from_ExecPlanReader(self) 4: as_arrow_table(reader)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader) 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
 5:  1:
as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x) 4:
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)Table__from_ExecPlanReader(self)
 2: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, data(all_of(vars_temp),     all_of(vars_temp)), by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...

10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())(x$read_table())()
 6: as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: })
tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)

 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {
 5: as_arrow_table.arrow_dplyr_query(x)
 6:     augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...
as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, "Doing thes"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...
11: compute.arrow_dplyr_query(left_join(data, vars_temp(), by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...

 *** caught segfault ***
address 0x7f6ecc2520, cause 'invalid permissions'

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...

 *** caught segfault ***
address 0x7f5e1daf00, cause 'invalid permissions'

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...

 *** caught segfault ***
address 0x7ee0f0bac0, cause 'invalid permissions'

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...

 *** caught segfault ***
address 0x7ecb394000, cause 'invalid permissions'

Traceback:
 1: Table__from_ExecPlanReader(self)
 2: x$read_table()
 3: as_arrow_table.RecordBatchReader(reader)
 4: as_arrow_table(reader)
 5: as_arrow_table.arrow_dplyr_query(x)
 6: as_arrow_table(x)
 7: doTryCatch(return(expr), name, parentenv, handler)
 8: tryCatchOne(expr, names, parentenv, handlers[[1L]])
 9: tryCatchList(expr, classes, parentenv, handlers)
10: tryCatch(as_arrow_table(x), error = function(e, call = caller_env(n = 4)) {    augment_io_error_msg(e, call, schema = schema())})
11: compute.arrow_dplyr_query(left_join(data, select(data, all_of(vars_temp)),     by = c(id = "id")))
12: compute(left_join(data, select(data, all_of(vars_temp)), by = c(id = "id")))
13: FUN(X[[i]], ...)
14: lapply(1:nb_var, function(n) {    print(paste0("Doing the join with ", n + 1, " variables"))    vars_temp <- c("id", vars[1:n])    print(vars_temp)    data_out <- compute(left_join(data, select(data, all_of(vars_temp)),         by = c(id = "id")))    return("Success!")})
An irrecoverable exception occurred. R is aborting now ...
fish: Job 1, 'Rscript acero-join-test.R' terminated by signal SIGSEGV (Address boundary error)

@amoeba : I could finally install arrow with my patch (on Linux/Ubuntu). I re-ran my my patch with using the gdb debugger and got the same error as you. The debugger output is the following:
arrow::acero::RowArrayMerge::CopyVaryingLength (target=<optimized out>, source=..., first_target_row_id=<optimized out>, first_target_row_offset=<optimized out>, source_rows_permutation=0x7ffcc8052020) at /home/onyxia/work/arrow/cpp/src/arrow/acero/swiss_join.cc:605
605             *target_row_ptr++ = *source_row_ptr++;

Line 605 of swiss_join.cc is part of the following loop, where the content of source rows is iteratively added to target rows:
for (uint32_t word = 0; word < length / sizeof(uint64_t); ++word) {
  *target_row_ptr++ = *source_row_ptr++;
}

As I am completly new to C++, I'm not sure what this bug means.  My intuition is that we're trying to add too much to the target_row_ptr pointer given its type. Would you or @westonpace have any clue on what is going wrong?

Hi @oliviermeslin @amoeba , I was trying to help on the issue you met. After looking a bit, I'd say it's unfortunately an inherent problem of the fix. In other words, the original issue just transfers to a later place and explodes in a more implicit fashion (the segfault).
Please see my comment on the changed code about what is actually happening. Thanks.

PR #43389 fixed the issue in a more thorough way so I'm closing this one. Thanks.


notnull, primary, unique constraints test added

To set up the foreign key tests:

I refract ForeignKey class and add column offset info for src and sink table
I add more options to TransactionTestsUtil::CreateTable to make it easier for foreignkey tests
I implement the foreign key check in data_table.cpp
A simple ForeignKeyInsertTest on two tables added

Thanks @jarulraj for the comments and suggestions. I have merged @yudun's commits on key constraints. Please note that, this PR contains the following changes:

implement key constraints;
optimize tuple allocation;
optimize OCC with speculative read.

In fact, this PR should be divided into three different PRs. However, as these three PRs are highly dependent, sending them independently may cause compilation failure to the master branch. This problem can be addressed once the codebase for storage and transaction manager becomes stable.
Any further comments are welcome. Thanks.


Column contents change

Hi
I want to add the column contents.
default column contents is [name, from data, to date].
I want change column  contents be [name, from data, to date, original].
Can I do it ??

Yes, with the "table plugin"
https://www.angular-gantt.com/plugins/table/

thanks @nnachi.
I try it!!


Prefix ([0] [1]) randomly missing

Description:
I'm usign concurrently for my azure fucntions node.js project.  I need to compile my typescript and run the azure functions at the same time.
here is my package.json script
"start": "concurrently --kill-others \"tsc -w\" \"func start\"",
Problem is that randomly the prefix is missing from the logs.  Which misalign my data in the logs which can be pretty annoying sometimes:

I tried to remove the prefix (since I don't really need it) but setting it to an empty string brings back the [0] and [1].   I also tried setting it to a radom caracter like "-" but still have the same issue
Expected Behavior:

Do not skip some prefix
Be able to remove the prefix by setting it to empty string

Environment
Node.js v18.19

Thanks for the report.
I'm pretty sure that your command must be writing multiple lines without a line break at the end, e.g. process.stdout.write('hello\nworld').
How this has been a bug for so long is beyond me.
https://github.com/open-cli-tools/concurrently/blame/v8.2.2/src/logger.ts#L238-L239

Hey! This is now fixed in v9.0.0.
https://github.com/open-cli-tools/concurrently/releases/tag/v9.0.0


local web-ui

Requested Feature
As I was trying to debug https://github.com/spotDL/spotify-downloader/issues/2067, I of course tried to fix my own web-ui at least temporarily by editing the web-ui files. That's when I realized the web-ui is downloaded every time spotdl web is invoked. This means the web-ui can't really be modified as it will just be overwritten again. It's also probably not very fast.
Possible implementation
It might be useful to check for the presence of the web-ui files before attempting to download them from the github repo. This would allow users to make changes to their own web-ui.
There could be an option to specify a path to web-ui files (--ui-source) so an advanced user could easily have it point to an alternative ui.

This is from the perspective of a self-hosting user that would be hosting spotdl on docker for other users.

added in v4.2.6


intro.rst: Correct first example app link

The first example on the doc site was redirecting to a page within the read the docs site due to the link target and text being swapped.

Whoops, thank you!


build: reduce image size

Fixes #14

Replacing the full anaconda installation with a miniconda installation reduces the container size from 12.4GB to 6.24 GB:
$ docker images --filter "reference=provideq-toolbox-backend"
REPOSITORY                 TAG       IMAGE ID       CREATED         SIZE
provideq-toolbox-backend   latest    49e227d3e6a5   5 minutes ago   6.24GB

The largest remaining components are:

the base image: 455 MB
GAMS installation: 3.56 GB in total
Anaconda: ~480 MB in total
python installation, incl. packages: ~1.1 GB in total

Image size is now at 6.09 GB

Image size is now at 3.64 GB

Image size is now at 3.34 GB. The remaining build steps that contribute > 100 MB to the image size are the following:

GAMS: 1.78 GB
Miniconda: 300 MB
Conda python env with GAMS packages: ~400 MB
Python packages required for our scripts: 613 MB

I think we can't get the image size much smaller without putting large amounts of efforts into it.


[feat] Emit -N in Slurm job script

Closes #1057

Hello @rsarm, Thank you for submitting the Pull Request!

In the file reframe/core/schedulers/slurm.py:

Line 111:17: E126 continuation line over-indented for hanging indent

Do see the ReFrame Coding Style Guide

I will remove the environment variable. It's a bit confusing. I will only keep the configuration parameter.

Codecov Report

Merging #1356 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1356   +/-   ##
=======================================
  Coverage   91.65%   91.66%
=======================================
  Files          83       83
  Lines       12599    12612   +13
=======================================
+ Hits        11548    11561   +13
  Misses       1051     1051

Impacted Files
Coverage Δ

reframe/core/schedulers/slurm.py
56.63% <100.00%> (+0.51%)
:arrow_up:

unittests/test_schedulers.py
91.82% <100.00%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b9a94...c01465d. Read the comment docs.


Update font-hermit to 1.21

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Merged as 192b61037fc0f36861b3983c79e5f8c50c5fbc9c.


does not contain package github.com/opensibyl/sibyl2/pkg/server/docs

keep a empty doc package

0.15.3


SCSS Compiling Issue / Components Not Importing

Hello!
Thank you for FoundationPress! Its my fave.
Having an issue with compiling SCSS. SCSS components are not importing or compiling when I edit them.
gulp V 3.9.0
Currently the compiler is stuck on the following error...
assets/scss/foundation.scss
Error: It's not clear which file to import for '@import "../components/foundation-sites/scss/vendor/normalize"'.
Candidates:
../components/foundation-sites/scss/vendor/normalize.scss
../components/foundation-sites/scss/vendor/normalize.css
Please delete or rename all but one of these files.
on line 14 of stdin

@import '../components/foundation-sites/scss/vendor/normalize';

I have not been able to clear this error by adding .scss to the end of 'normalize'. I've also tried renaming the file to _normalize.scss. Not working.
An example of a component not importing is _title-bar.scss. When I edit this SCSS file nothing compiles in the terminal.
I'm stumped...any and all help is so greatly appreciated. Thanks Ole and all!
Here is what my foundation-sites.scss file looks like:
@import 'scss/foundation';

@include foundation-everything;

Here is my _foundation.scss file:
/*
  Foundation for Sites components:
  Import the building blocks you need for your project.
  Reducing the number of imported components will optimize page speed.
  ---------------------------------------------------------------------
  The Foundation framework is built by Zurb
  Licensed under MIT Open Source
*/

// Third-party libraries
@import '../components/foundation-sites/scss/vendor/normalize';
@import '../components/fontawesome/scss/font-awesome.scss';
@import '../components/motion-ui/motion-ui.scss';

// Sass utilities
@import '../components/foundation-sites/scss/util/util';

//  Settings and wp-override styles:
@import "global/settings"; // Default settings file. Uncomment each setting you need to change
@import "global/wp-admin"; // Fix issues with wp-admin bar positioning
@import "global/wp-overrides"; // Override the default WordPress styling for some elements

// Global variables and styles
@import '../components/foundation-sites/scss/global';

// Components
@import '../components/foundation-sites/scss/grid/grid';
@import '../components/foundation-sites/scss/typography/typography';
@import '../components/foundation-sites/scss/forms/forms';
@import '../components/foundation-sites/scss/components/visibility';
@import '../components/foundation-sites/scss/components/float';
@import '../components/foundation-sites/scss/components/button';
@import '../components/foundation-sites/scss/components/button-group';
@import '../components/foundation-sites/scss/components/accordion-menu';
@import '../components/foundation-sites/scss/components/accordion';
@import '../components/foundation-sites/scss/components/badge';
@import '../components/foundation-sites/scss/components/breadcrumbs';
@import '../components/foundation-sites/scss/components/callout';
@import '../components/foundation-sites/scss/components/close-button';
@import '../components/foundation-sites/scss/components/drilldown';
@import '../components/foundation-sites/scss/components/dropdown-menu';
@import '../components/foundation-sites/scss/components/dropdown';
@import '../components/foundation-sites/scss/components/flex-video';
@import '../components/foundation-sites/scss/components/label';
@import '../components/foundation-sites/scss/components/media-object';
@import '../components/foundation-sites/scss/components/menu';
@import '../components/foundation-sites/scss/components/off-canvas';
@import '../components/foundation-sites/scss/components/orbit';
@import '../components/foundation-sites/scss/components/pagination';
@import '../components/foundation-sites/scss/components/progress-bar';
@import '../components/foundation-sites/scss/components/reveal';
@import '../components/foundation-sites/scss/components/slider';
@import '../components/foundation-sites/scss/components/sticky';
@import '../components/foundation-sites/scss/components/switch';
@import '../components/foundation-sites/scss/components/table';
@import '../components/foundation-sites/scss/components/tabs';
@import '../components/foundation-sites/scss/components/title-bar.scss';
@import '../components/foundation-sites/scss/components/top-bar';
@import '../components/foundation-sites/scss/components/thumbnail';
@import '../components/foundation-sites/scss/components/tooltip';

// These styles are applied to <meta> tags, which are read by the Foundation JavaScript
.foundation-mq {
  font-family: "#{-zf-bp-serialize($breakpoints)}";
}

@mixin foundation-everything {
  @include foundation-global-styles;
  @include foundation-grid;
  @include foundation-typography;
  @include foundation-button;
  @include foundation-forms;
  @include foundation-visibility-classes;
  @include foundation-float-classes;
  @include foundation-accordion;
  @include foundation-accordion-menu;
  @include foundation-badge;
  @include foundation-breadcrumbs;
  @include foundation-button-group;
  @include foundation-callout;
  @include foundation-close-button;
  @include foundation-drilldown-menu;
  @include foundation-dropdown;
  @include foundation-dropdown-menu;
  @include foundation-flex-video;
  @include foundation-label;
  @include foundation-media-object;
  @include foundation-menu;
  @include foundation-off-canvas;
  @include foundation-orbit;
  @include foundation-pagination;
  @include foundation-progress-bar;
  @include foundation-slider;
  @include foundation-sticky;
  @include foundation-reveal;
  @include foundation-switch;
  @include foundation-table;
  @include foundation-tabs;
  @include foundation-thumbnail;
  @include foundation-title-bar;
  @include foundation-tooltip;
  @include foundation-top-bar;
}

// Include all foundation components
@include foundation-everything;

/*
  My custom styles:
  Add your scss files below to structure your project styles
*/

// Modules
@import "modules/topbar";
@import "modules/footer";
@import "modules/sidebar";

// Custom SCSS
@import "custom/custom";
@import "custom/mediaqueries";

// Components
@import "components/buttons";
@import "components/featured-image";
@import "components/dividers";
@import "components/off-canvas";

// Templates
@import "templates/front";
@import "templates/kitchen-sink";
@import "templates/page-default";
@import "templates/page-sidebar-left";
@import "templates/page-full-width";
@import "templates/single-post";

Here's my gulpfile.js:
/*jslint node: true */
"use strict";

var $           = require('gulp-load-plugins')();
var argv        = require('yargs').argv;
var gulp          = require('gulp');
var browserSync = require('browser-sync').create();
var merge       = require('merge-stream');
var sequence    = require('run-sequence');
var colors      = require('colors');

// Enter URL of your local server here
// Example: 'http://localwebsite.dev'
var URL = '';

// Check for --production flag
var isProduction = !!(argv.production);

// Browsers to target when prefixing CSS.
var COMPATIBILITY = ['last 2 versions', 'ie >= 9'];

// File paths to various assets are defined here.
var PATHS = {
  sass: [
    'assets/components/foundation-sites/scss',
    'assets/components/motion-ui/src/'
  ],
  javascript: [
    'assets/components/jquery/dist/jquery.js',
    'assets/components/what-input/what-input.js',
    'assets/components/foundation-sites/js/foundation.core.js',
    'assets/components/foundation-sites/js/foundation.util.*.js',

    // Paths to individual JS components defined below
    'assets/components/foundation-sites/js/foundation.abide.js',
    'assets/components/foundation-sites/js/foundation.accordion.js',
    'assets/components/foundation-sites/js/foundation.accordionMenu.js',
    'assets/components/foundation-sites/js/foundation.drilldown.js',
    'assets/components/foundation-sites/js/foundation.dropdown.js',
    'assets/components/foundation-sites/js/foundation.dropdownMenu.js',
    'assets/components/foundation-sites/js/foundation.equalizer.js',
    'assets/components/foundation-sites/js/foundation.interchange.js',
    'assets/components/foundation-sites/js/foundation.magellan.js',
    'assets/components/foundation-sites/js/foundation.offcanvas.js',
    'assets/components/foundation-sites/js/foundation.orbit.js',
    'assets/components/foundation-sites/js/foundation.responsiveMenu.js',
    'assets/components/foundation-sites/js/foundation.responsiveToggle.js',
    'assets/components/foundation-sites/js/foundation.reveal.js',
    'assets/components/foundation-sites/js/foundation.slider.js',
    'assets/components/foundation-sites/js/foundation.sticky.js',
    'assets/components/foundation-sites/js/foundation.tabs.js',
    'assets/components/foundation-sites/js/foundation.toggler.js',
    'assets/components/foundation-sites/js/foundation.tooltip.js',

    // Motion UI
    'assets/components/motion-ui/motion-ui.js',

    // What-input
    'assets/components/what-input/what-input.js',

    // Include your own custom scripts (located in the custom folder)
    'assets/javascript/custom/*.js'
  ],
  pkg: [
    '**/*',
    '!**/node_modules/**',
    '!**/components/**',
    '!**/scss/**',
    '!**/bower.json',
    '!**/Gruntfile.js',
    '!**/package.json',
    '!**/composer.json',
    '!**/composer.lock',
    '!**/codesniffer.ruleset.xml',
    '!**/packaged/*'
  ]
};

// Browsersync task
gulp.task('browser-sync', ['build'], function() {

  var files = [
            '**/*.php',
            'assets/images/**/*.{png,jpg,gif}'
          ];

  browserSync.init(files, {
    // Proxy address
    proxy: URL,

    // Port #
    // port: PORT
  });
});

// Compile Sass into CSS
// In production, the CSS is compressed
gulp.task('sass', function() {
  // Minify CSS if run wtih --production flag
  var minifycss = $.if(isProduction, $.minifyCss());

  return gulp.src('assets/scss/foundation.scss')
    .pipe($.sourcemaps.init())
    .pipe($.sass({
      includePaths: PATHS.sass
    })
      .on('error', $.sass.logError))
    .pipe($.autoprefixer({
      browsers: COMPATIBILITY
    }))
    .pipe(minifycss)
    .pipe($.if(!isProduction, $.sourcemaps.write('.')))
    .pipe(gulp.dest('assets/stylesheets'))
    .pipe(browserSync.stream({match: '**/*.css'}));
});

// Combine JavaScript into one file
// In production, the file is minified
gulp.task('javascript', function() {

  var uglify = $.uglify()
    .on('error', function (e) {
      console.log(e);
    });

  return gulp.src(PATHS.javascript)
    .pipe($.sourcemaps.init())
    .pipe($.concat('foundation.js'))
    .pipe($.if(isProduction, uglify))
    .pipe($.if(!isProduction, $.sourcemaps.write()))
    .pipe(gulp.dest('assets/javascript'))
    .pipe(browserSync.stream());
});

// Copy task
gulp.task('copy', function() {
  // Motion UI
  var motionUi = gulp.src('assets/components/motion-ui/**/*.*')
    .pipe($.flatten())
    .pipe(gulp.dest('assets/javascript/vendor/motion-ui'));

  // What Input
  var whatInput = gulp.src('assets/components/what-input/**/*.*')
      .pipe($.flatten())
      .pipe(gulp.dest('assets/javascript/vendor/what-input'));

  // Font Awesome
  var fontAwesome = gulp.src('assets/components/fontawesome/fonts/**/*.*')
      .pipe(gulp.dest('assets/fonts'));

  return merge(motionUi, whatInput, fontAwesome);
});

// Package task
gulp.task('package', ['build'], function() {
  var fs = require('fs');
  var pkg = JSON.parse(fs.readFileSync('./package.json'));
  var time = $.util.date(new Date(), '_yyyy-mm-dd_HH-MM');
  var title = pkg.name + time + '.zip';

  return gulp.src(PATHS.pkg)
    .pipe($.zip(title))
    .pipe(gulp.dest('packaged'));
});

// Build task
// Runs copy then runs sass & javascript in parallel
gulp.task('build', function(done) {
  sequence('copy',
          ['sass', 'javascript'],
          done);
});

// Default gulp task
// Run build task and watch for file changes
gulp.task('default', ['build', 'browser-sync'], function() {
  // Log file changes to console
  function logFileChange(event) {
    var fileName = require('path').relative(__dirname, event.path);
    console.log('[' + 'WATCH'.green + '] ' + fileName.magenta + ' was ' + event.type + ', running tasks...');
  }

  // Sass Watch
  gulp.watch(['assets/scss/**/*.scss'], ['sass'])
    .on('change', function(event) {
      logFileChange(event);
    });

  // JS Watch
  gulp.watch(['assets/javascript/custom/**/*.js'], ['javascript'])
    .on('change', function(event) {
      logFileChange(event);
    });
});

Hi, Did you installed the bower components using bower install

I close this because of lack of response. Please reopen if this is still an issue


Don't hardcode gcc compiler flags

I would ask that you please do not hardcode gcc-specific compiler flags

Coverage remained the same at 96.68% when pulling 719a94ef0becad57dd339be840c4bb7077b256de on sthomen:patch-1 into 7d20205c36b29f49664419a2924612736b5d179e on fgimian:master.


[google_sign_in] Inconsistent login behavior in development and production

Hello, I am using the google_sign_in plugin to handle user login. Everything works fine in the emulator and also on locally build .apk installed on device. Exactly same code/configuration, but build as .abb and installed via Google Play cannot log in (I am uploading now a new version to gather more information, like possible exceptions).
However, any idea what could provoke such a behavior?
Thank you
Kras

@kkondarev
Would be good to get an error log or exception log that will help to debug further.

Yes, waiting for the next app update to be approved in Play Store... takes a bit...
Locally everything works flawlessly, this is what bugs me - both in emulator and as locally installed apk the login works without any issue, only when coming from Play Store - not.
Was asking if anyone has experienced such strange behavior and can point me in some direction.

@kkondarev
Maybe you can try to run flutter run --release and then try to login and see if it throws any log ?
Check if this for reference : https://github.com/firebase/flutterfire/issues/7435

Thanks for the reply. Nope, this works - building a release app (.apk) and testing it (also on a phone) works perfectly fine.
Meanwhile the app was approved on Play Store (lucky coincidence it happened today!), so I was able to find out, that during login the following exception was raised: PlatformException(sign_in_failed, com.google.android.gms.common.api.b: 10: , null, null)
I double-checked my SHA-1, scopes, etc - all good. Long story short, after a lot of googleing I found out, that the issue is caused by the Play Store's app signing. Replaced the SHA-1 in the API console with the one generated by Play Store and now everything works awesomely again.


Add descriptions of new features to UserGuide.adoc

New features added: m-show & m-route
Modify on the format

Coverage remained the same at 90.914% when pulling 4d44307d436157a04faafd399b849088bf442068 on dalessr:userguide_new_features into 3b64cf422d18e0f0112557d3d1a176d253a73485 on CS2103AUG2017-W09-B3:master.


Fix authorization issue - when request is denied return forbbiden exist code (403).

- What I did
When request is rejected by authorization plugin, replace status code 500 (internal server error) with 403 (forbidden). Based on discussion in #2242
- How I did it
Used errors.NewErrorWithStatusCode when authorization plugin rejects requests
- How to verify it
New integration test for API
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Fix outdated documentation on response modification in authorization
Return 403 (forbidden) when request is denied in authorization flows
(including integration test)
Fix #22428

Signed-off-by: Liron Levin<EMAIL_ADDRESS>

Thanks @thaJeztah, fixed both issues (also refactored network errors to use NewRequestForbiddenError)

Thanks @liron-l  - sorry, I just thought of this, but can you move the documentation changes to a separate PR? I have a cherry-pick PR to update the docs and having a separate PR makes it easier for me to cherry-pick just those changes (https://github.com/docker/docker/pull/22421) in case we do an update of the documentation before the next release

owww, erm.. looks like using the "errors" in a package wasn't a good idea :cry: :blush:
11:49:23 ---> Making bundle: validate-pkg (in bundles/1.12.0-dev/validate-pkg)
11:49:24 These files import internal code: (either directly or indirectly)
11:49:24  - pkg/authorization/authz.go imports github.com/docker/docker/errors

Thanks @thaJeztah, removed the reference from pkg, but kept the one in daemon.
I've also removed the documentation section and will update those in a separate PR (after this PR will pass)

oh looks like there's a gofmt issue now (well, at least we have managed to trigger all checks 😜)
12:37:25 ---> Making bundle: validate-gofmt (in bundles/1.12.0-dev/validate-gofmt)
12:37:25 These files are not properly gofmt'd:
12:37:25  - pkg/authorization/authz.go
12:37:25
12:37:25 Please reformat the above files using "gofmt -s -w" and commit the result.

Thanks @thaJeztah , I think everything is fixed now.

Yes, looks okay now. win2lin failure is not related
LGTM

Minor nit, but the commit message still references the doc change which got pulled into a separate PR.

Thanks @lblackstone, I've updated the commit message.

LGTM


Hotfix: Update Input Styles in Dark Mode

WHAT DOES THIS PR DO?

Fixes the input dark mode colors on login/registration
Update profile margin on mobile screen

WHAT ISSUES ARE RELATED TO THIS PR?

#98

HOW DO I TEST OUT THIS PR?

Goto web directory and run npm i then npm run dev and go to the login or registration page. The input fields should look different when dark mode is enabled.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (89e750d) 91.56% compared to head (ae0e06f) 91.56%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   91.56%   91.56%
=======================================
  Files          29       29
  Lines         830      830
  Branches        6        6
=======================================
  Hits          760      760
  Misses         70       70

Flag
Coverage Δ

web
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create git tag for release

There’s version 1.0.0 on RubyGems, but no tag v1.0.0 in this repo.

Thanks for pointing that out. That probably means the rake release task wasn't used for the release. We should definitely add it.
We should also document how to do a release in a releasing section in the README so we get it right in the future.

The release task is already defined.

I know, it just wasn't used.
I added an enhancement to create a discrete commit for the tag, which I like to use as it makes the history easier to understand. I also documented how to perform a release. See https://github.com/asciidoctor/jekyll-asciidoc/commit/f0da8e35592de946e58ee1a0132c4a8d4c997339.

Creating an empty commit doesn’t make any sense for me, it creates just a noise in the repo history. The commit with version bump (i.e. change in the version.rb file) is IMHO perfectly sufficient for this.
You should also change the version number to something like 1.0.2.dev after releasing a new version and it’s better to do it in a separate commit, so then you end up with three commits per release.
Bump version to 1.0.2
Release 1.0.2
Prepare for next development iteration

Agreed on the version number bump.
If you think it's better not to create an empty release, I'm fine with that. I'll remove the extra logic then.

Well, I personally don’t see any benefit for the empty commit and also haven’t seen it anywhere else. Why do you consider it easier to understand?

I think it was all in how the commit messages are written. When I came into Asciidoctor, the commit message was "prepare for 1.5.2 release" and that was the commit that was tagged. I didn't like that the tag message said "prepare" and not just "release". Now I can see that we should just put the commit message we want in the release when updating the version number.
Thus, the README should propose a commit message format when setting the version number.

I didn't like that the tag message said "prepare" and not just "release".

I understand, I’ve also used to have exactly the same problem! This “Prepare for x.y.z” style is a (bad) habit from Maven. Then I’ve somewhere seen “Release x.y.z” and found it better. :smiley_cat:


Add proper support for module.paths.

Fixes #898. Eslint is using private module APIs, so let's add them to Jest.
We are using a private API from the module module (heh!) so we'll guard it with a try-catch in case it ever breaks. We could also lift the API into Jest itself but I don't see a point in recreating it. I added a test that will undoubtedly fail if the API starts breaking in node and when that happens, we can fix it accordingly :)

@facebook-github-bot import

@facebook-github-bot import


Fix code scanning alert - Incomplete string escaping or encoding

Tracking issue for:

[x] https://github.com/microsoft/SandDance/security/code-scanning/2

Fixed in PR #725


Add PUG Roma

Coverage remained the same at 45.161% when pulling 26e90247555c48dfad48c21c847b7d618b40b468 on pug-roma:master into fb6fa2715aa73194b7782e20aeb1df989872a9d8 on phpcommunity:master.