New features not available

Hi @peterdemin ,
I just installed the latest pip-compile-multi v. 2.4.1 which should include the --extra-index-url option, but I cannot find it, nor do I see the --live or --no-live options that should have become available with this version.
https://pypi.org/project/pip-compile-multi/
I cannot execute the command with the extra option, and I don't see it when I run pip-compile-multi --help.
Can you see what happened?
Thanks,
Erik

Weird, can you try repeating this experiment?
$ python3.6 -m venv venv36
$ source venv36/bin/activate
$ pip install pip-compile-multi
Collecting pip-compile-multi
  Downloading https://files.pythonhosted.org/packages/4b/72/bcc7b6018e6cecc7aa0f9682026f37569e0691db49981485c71526e9bc1f/pip_compile_multi-2.4.1-py2.py3-none-any.whl
Collecting pip-tools>=5.2 (from pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/fd/e3/2dd1d62dfa3d524bf68e07bc19942ad9def6579c90efb9b60a9d7b15916a/pip_tools-6.0.1-py3-none-any.whl
Collecting toposort (from pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/f2/7d/55784e894ee0cde2474fb977ffd1651e74e840a9f92e1d847f7e3115d5ec/toposort-1.6-py2.py3-none-any.whl
Collecting click (from pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/d2/3d/fa76db83bf75c4f8d338c2fd15c8d33fdd7ad23a9b5e57eb6c5de26b430e/click-7.1.2-py2.py3-none-any.whl
Collecting pip>=20.3 (from pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/fe/ef/60d7ba03b5c442309ef42e7d69959f73aacccd0d86008362a681c4698e83/pip-21.0.1-py3-none-any.whl
Collecting pep517 (from pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/2f/5b/9afe177c8cc801ad9342488f8509c3e237f7c9ec161b7fccb1d61d6d0716/pep517-0.10.0-py2.py3-none-any.whl
Collecting toml (from pep517->pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/44/6f/7120676b6d73228c96e17f1f794d8ab046fc910d781c8d151120c3f1569e/toml-0.10.2-py2.py3-none-any.whl
Collecting zipp; python_version < "3.8" (from pep517->pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/0f/8c/715c54e9e34c0c4820f616a913a7de3337d0cd79074dd1bed4dd840f16ae/zipp-3.4.1-py3-none-any.whl
Collecting importlib_metadata; python_version < "3.8" (from pep517->pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/99/8f/b0ac918b2234848ec5bd2a887d2be7d6686355fcb22d7a0efe878d5c1555/importlib_metadata-3.10.0-py3-none-any.whl
Collecting typing-extensions>=3.6.4; python_version < "3.8" (from importlib_metadata; python_version < "3.8"->pep517->pip-tools>=5.2->pip-compile-multi)
  Using cached https://files.pythonhosted.org/packages/60/7a/e881b5abb54db0e6e671ab088d079c57ce54e8a01a3ca443f561ccadb37e/typing_extensions-<IP_ADDRESS>-py3-none-any.whl
Installing collected packages: pip, click, toml, zipp, typing-extensions, importlib-metadata, pep517, pip-tools, toposort, pip-compile-multi
  Found existing installation: pip 18.1
    Uninstalling pip-18.1:
      Successfully uninstalled pip-18.1
Successfully installed click-7.1.2 importlib-metadata-3.10.0 pep517-0.10.0 pip-21.0.1 pip-compile-multi-2.4.1 pip-tools-6.0.1 toml-0.10.2 toposort-1.6 typing-extensions-<IP_ADDRESS> zipp-3.4.1
$ pip-compile-multi --help
Usage: pip-compile-multi [OPTIONS] COMMAND [ARGS]...

  Recompile

Options:
  --extra-index-url TEXT          Add additional package index URL to search
                                  for package versions. Can be supplied
                                  multiple times.

  --live / --no-live              Print debug output from pip-compile live.
  --skip-constraints              Remove constraints from "via" comments.
  --autoresolve / --no-autoresolve
                                  Automatically resolve cross-file conflicts.
  -s, --allow-unsafe              Whether or not to include 'unsafe' packages
                                  in generated requirements files. Consult
                                  pip-compile --help for more information

  -h, --header TEXT               File path with custom header text for
                                  generated files.

  -n, --only-name TEXT            Compile only for passed environment names
                                  and their references. Can be supplied
                                  multiple times.

  -t, --only-path TEXT            Compile only for passed input paths and
                                  their references. Can be supplied multiple
                                  times.

  -P, --upgrade-package TEXT      Only upgrade named package. Can be supplied
                                  multiple times.

  --upgrade / --no-upgrade        Upgrade package version (default true)
  -g, --generate-hashes TEXT      Input file name (base.in,
                                  requirements/test.in, etc) that needs
                                  packages hashes. Can be supplied multiple
                                  times.

  -p, --forbid-post TEXT          Environment name (base, test, etc) that
                                  cannot have packages with post-release
                                  versions (1.2.3.post777). Can be supplied
                                  multiple times.

  -c, --compatible TEXT           Glob expression for packages with compatible
                                  (~=) version constraint. Can be supplied
                                  multiple times.

  -d, --directory TEXT            Directory path with requirements files.
  -o, --out-ext TEXT              File extension of output files.
  -i, --in-ext TEXT               File extension of input files.
  -u, --use-cache                 Use pip-tools cache to speed up compilation.
  --annotate-index / --no-annotate-index
                                  Add the index URL to generated files
                                  (default false).

  --help                          Show this message and exit.

Commands:
  verify  For each environment verify hash comments and report failures.

The new options are at the top of the list:
  --extra-index-url TEXT          Add additional package index URL to search
                                  for package versions. Can be supplied
                                  multiple times.

  --live / --no-live              Print debug output from pip-compile live.

Hi @peterdemin ,
There was a problem with my (Conda) environment. (I'm installing all my requirements into an empty Conda environment using pip.) Somehow there was a reference to a file pip-compile-multi in my ~/.local/bin folder which messed things up. I needed to uninstall pip-compile-multi from my base system, completely remove my conda environment and rebuild it, and now it works just fine :-).
Sorry for the confusion, thanks for the help!
Best regards,
Erik Jan

You're welcome.


Add page on versioning of extensions

@carlopi LMK if this looks good

I will add something on how to interpret the error messages that you might encounter (and land on that page), your call if you want to merge and go on or wait a day.

Let's move fast! I'll merge and you can base your fork/PR on that.


h button needs to be pushed twice to show help and can not hide it afterwards

When I want to enable the help in watch mode I need to push the h twice. Same behaviour with ?.
Once the help is shown I would expect to hide it with another push on h or ? or maybe ESC, but nothing happens. I help myself by pushing ENTER which refreshes the view.

Buchungsstreber 2.4.0
Ubuntu 18.04.5
Ruby ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu] with

curses 1.3.2
rb-inotify 0.10.1

Ah, pushing h and then click with the mouse into the Buchungsstreber terminal window also shows the help. :smile:


Skip sending IWants based on received IDontWants

We use IDontWant followed by the actual message transmission to minimize redundant large message transmissions.
We can also skip sending IWant for a msgId if we have already received N number of IDontWants for the same msgId

https://github.com/vacp2p/nim-libp2p/issues/1101


set up Sentry Exception Monitoring

Description
remove logo.svg and serviceWorker.js as not needed at the moment
modify .gitignore to ensure .env files are ignored
install sentry
modify index.js to:

initialize sentry if in production
notify if in mode other than production (will be removed later)
modify App.js to clean HelloWorld page

Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, ready to review and merge

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] My changes generate no new warnings
[x] There are no merge conflicts

I forgot to update the App.test.js file from the default to check for "hello world" instead. Hence the prior testing failures 😅. Modified tests to check for the correct text. Testing now passes as expected.


Possibly broken generics when using #[island]

trait SomeTrait {}

// Works
#[component]
pub fn TestComponent<S: SomeTrait>(_some_trait: PhantomData<S>) -> impl IntoView {}

// Errors
#[island]
pub fn TestIsland<S: SomeTrait>(_some_trait: PhantomData<S>) -> impl IntoView {}

error[E0412]: cannot find type `S` in this scope
  --> main.rs:26:58
   |
26 | pub fn TestIsland<S: SomeTrait>(_some_trait: PhantomData<S>) -> impl IntoView {}
   |                                                          ^ not found in this scope
   |
help: consider importing one of these items
   |
1  + use crate::views::html::S;
   |
1  + use leptos::html::S;
   |

Might be related to https://github.com/leptos-rs/leptos/pull/1636, that's what I used for reference.
Leptos Dependencies
(With cargo update)
leptos_axum = { git = "https://github.com/leptos-rs/leptos", features = ["experimental-islands"], optional = true }
leptos = { git = "https://github.com/leptos-rs/leptos", features = ["nightly", "experimental-islands"] }
leptos_meta = { git = "https://github.com/leptos-rs/leptos", features = ["nightly"] }
leptos_router = { git = "https://github.com/leptos-rs/leptos", features = ["nightly"] }

I would not expect generics to work on an island. I can try to work on a better error message at some point. If you need a generic island you can use a generic component that's used by multiple concrete islands. But because each island needs to be separately callable from JS there isn't really a way for generics to work on them.

Got it, thanks!


Inflectional class is not shown properly

What is shown is not the inflectional class (or its relabeling), but rather that of V and AI, which is wrong.  cf.

What should be shown here is the relabeling of the single string VAI-1, for which the relabelings are:

linguistic: vowel-final animate intransitive verb (VAI-1)
plain English: like: nipâw
nêhiyawêwin: tâpiskôc: nipâw

This is how it works in the production version:

This may be due to an incorrect implementation in the backend.

One contributing factor may be that an inflectional class is shown both for the entry head-word as well as the inflected word-form (when these are distinct), cf.

In the production server, the inflectional class is only shown for the entry, not the inflected word form (for good reasons).

I don't see all the required information in the API. The Plain English and Linguistic categories are present, but not Nêhiyawêwin. The inflectional class will no longer be shown in the outer search section, that is no big deal to implement.


Board Review<EMAIL_ADDRESS>

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: Azure Cognitive Language
Main contacts: @deyaaeldeen
Expected code complete date: 07/07/2022
Expected release date: 07/12/2022

About the Service

Link to documentation introducing/describing the service: https://docs.microsoft.com/en-us/azure/cognitive-services/language-service/
Link to the service REST APIs: https://github.com/Azure/azure-rest-api-specs/blob/cognitiveservices-Language-2022-04-01-preview/specification/cognitiveservices/data-plane/Language/preview/2022-04-01-preview/textanalytics.json
Link to GitHub issue for previous review sessions, if applicable:  https://github.com/Azure/azure-sdk/issues/3774

About the client library

Name of the client library: @azure/ai-text-analytics
Languages for this review: JavaScript

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
.NET

APIView Link:
Link to Champion Scenarios/Quickstart samples:

Java

APIView Link:
Link to Champion Scenarios/Quickstart samples:

Python

APIView Link:
Link to Champion Scenarios/Quickstart samples:

TypeScript

APIView Link: https://apiview.dev/Assemblies/Review/553ca3650d3542d4b044c6a2857addfc?diffRevisionId=8d2db565871249f8b196da18851b7524&doc=False&diffOnly=False&revisionId=ef82472497e34bae87b8caa5dd072d5e
Link to Champion Scenarios/Quickstart samples: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/textanalytics/ai-text-analytics/samples-dev

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

Scheduled for 6/20

Rescheduled for 6/23

Recording (MS INTERNAL ONLY)


Fix min/max date for Android DatePicker

Previously, we had missed a crucial detail: local time zone offset is of course relative to a specific timestamp, as offset changes over time. Luckily java.util.TimeZone gives us a way to get the default timezone's offset easily. All of this is necessary as android.widget.setMinDate/setMaxDate take time in the device's default timezone.
Fixes https://github.com/fusetools/ManualTestApp/issues/373.

forced push a small typo fix ("subtracing" -> "subtracting")


File IO with KQueue crashes with a TypeError

#!/usr/bin/env ruby

$LOAD_PATH << "ext"

require_relative 'lib/io/event'

require 'fiber'

require 'io/nonblock'
selector = IO::Event::Selector::KQueue.new(Fiber.current)

events = Array.new
io = File.open("reproduction.rb")

fiber = Fiber.new do
	events << :wait_readable

	selector.io_wait(Fiber.current, io, IO::READABLE)

	events << :readable
end

events << :transfer
fiber.transfer
events << :transfer
fiber.transfer

pp events == [:transfer, :wait_readable, :transfer, :readable]

This crashes with no implicit conversion from nil to integer (TypeError), and while you can just workaround it with a if (NIL_P(result)) … at https://github.com/socketry/io-event/blob/main/ext/io/event/selector/kqueue.c#L351 I am not sure if that is the best solution?

Thanks for this detailed report and spending time investigating the implementation. I'll take a look and hope to fix this tonight. I also think it's funny I used the one file /dev/zero that has different semantics from every other file. Haha.

Yeah, that and /dev/null were the only reasonable ones I tried that it failed on. TTYs and other actually useful devices work fine.


How is the Nearest Neighbor method implemented?

Thank you for your work.
The paper mentions the use of two methods, Nearest Neighbor and Linear Classification.
In the published code, I only found the implementation of Linear Classification and couldn't find how Nearest Neighbor is implemented. Is this part not disclosed?

I found this, too

Hi, ccdou. I find this problem, too. Do you get the answer?

Hi, ccdou. I find this problem, too. Do you get the answer?

no,I don't use this method in my work

Hi, ccdou. I find this problem, too. Do you get the answer?

no,I don't use this method in my work

Okay, it seems I have no choice but to do it myself.


Sidebar Images in Gmail

How can we reproduce this bug?
Grab the basic sidebar inky test from Foundation. Insert two larger than column width images in the main column and a sidebar.
Write out the HTML (or Inky code) that causes the issue.
<container>
  <row>
    <columns large="7">

    </columns>
    <columns large="5" class="sidebar">

    </columns>
  </row>
</container>

What did you expect to happen?
The width shouldn't cause the page to scroll horizontally in Gmail (Explorer, Firefox) or Google Apps (Explorer, Firefox) according to a Litmus test.
Is this how it should work? Seems incorrect to me, but I wanted to verify that this isn't a bug.
What happened instead?
The page scrolls horizontally in certain browsers. The images seems to widen the page.
What email clients does this happen in?
Gmail (Explorer, Firefox) or Google Apps (Explorer, Firefox) according to a Litmus test.
Here is a test image from Litmus:

You'll want the images to match the container width as much as possible. You should add a width="580" to contrain it

The framework should handle this if it's a necessity to constrain images to specific widths. Also part of the build process is image optimization, so why does the image optimization not constrain the width of an image to a set max? There are a lot of issues open related to making images expand the full width of their container and it seems this is being casually cast aside. I wonder how many people have opened up the Zurb Foundation, tried to use it, realized that images aren't being handled correctly and just move on to another framework.

The image optimization packages that the template gets run through are there only for optimizing image file size for emails; I know of no node package that can check your HTML table width and then resize image(s) used in that table to the exact size. As @rafibomb said, the easiest is to use an attribute (it'll fix Outlook desktop, too, and you can even use it to have retina images).
Regarding the horizontal scrolling in Google email clients, the images are not constrained to the parent's width because the CSS to do so is inside a @media query - Gmail, and pretty much any Google email app ignore media queries.

This appears to be a major flaw with this library. A scenario that I would like, is to put an image in a column, and simply have it take up as much width as the column. I don't want it to grow the column, I don't want to care how big the image is, I just want it to fit the column's width.
Am I missing something or is this not possible?

Well, it actually does. But not in email clients that do not support @media queries.
On the other hand, maybe moving this code outside of the @media query from scss/components/_media-query.scss would be better?
table.body img {
  width: auto;
  height: auto;
}

Gmail will be supporting media queries, so we might be in luck.
Here's the announcement: http://googleappsdeveloper.blogspot.com/2016/09/your-emails-optimized-for-every-screen-with-responsive-design.html
Would this help address the issue?

Closing as we did not receive further feedback.


Create Project Refactor

Additions:

Revamped Create Projects screen
Pagination for coaches in create projects
Pagination for skills in create projects
Filters (backend) for skills & coaches in create projects
Markdown support for info field
Project preview
Editing markdown checkboxes from the projects page
Masonry wall fixes + masonry wall source file
Rewrote most of the skillStore
Rewrote part of the projectStore
Removed ProjectTableSkill model
Fixed expand button in projectslist

Codecov Report

Merging #419 (c294e87) into main (2827ec2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   94.78%   94.78%
=======================================
  Files          12       12
  Lines         824      824
=======================================
  Hits          781      781
  Misses         43       43

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

If the project name is unrealistically long it overflows out of the preview box, but I think this is a won't fix because nobody would a project with this long of a name.
Very smart to add the "Supports markdown"! Well done!

Is this better?


Require shellwords in master join command

Seems like there's some differences between ruby versions if shellwords is loaded by default or not.
(maybe best to require it in command.rb)

Fixed in #1103


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=398674451
https://github.com/Azure/azure-cli-extensions/commit/86720dc12c21ad9bedb27c9f8381a06c154c76a1

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature/prepare documentation

This PR adds the technical specification of CV32E20 to the documentation. The original documentation of Ibex is kept and subject to future work.
Also, a readme.md was added in the doc directory, which has the instructions for building the documentation.

Please see if you are able to build the documentation using the instructions in the Readme.

@christian-herber-nxp could not build on windows. Will try on linux

@christian-herber-nxp due to a problem on my computer I was not able to test the linux build, will be able to do that tomorrow. However I noticed you are missing the .readthedocs.yaml configuration file in the top level of the repo. You can copy this one https://github.com/openhwgroup/core-v-mcu-devkit/blob/main/.readthedocs.yaml. Can you please push that in, then we will merge this PR and see if it builds on the read the docs site.

@christian-herber-nxp due to a problem on my computer I was not able to test the linux build, will be able to do that tomorrow. However I noticed you are missing the .readthedocs.yaml configuration file in the top level of the repo. You can copy this one https://github.com/openhwgroup/core-v-mcu-devkit/blob/main/.readthedocs.yaml. Can you please push that in, then we will merge this PR and see if it builds on the read the docs site.

Thanks, updated the PR

LGTM @christian-herber-nxp.  I will defer to @DBees for the final merge.


Focus and VerticalScroll panels issue

Hi,
I'm not entirely sure if it's a minor bug, or if i'm doing something wrong or a feature request to be honest :)
The problem is: when I'm making a custom list using a PanelOverflowBehavior.VerticalScroll panel as the container, it doesn't seem possible to bring it to focus (so you don't have to hover the mouse on top of the scrollbar to use the wheel and scroll through the list). The user has to click inside the panel itself first to achieve that, which is quite impractical, especially if the panel is filled with sub elements.
I tried setting the panel's IsFocused property to true, and even tried the same with the attached scrollbar to no effect. Any idea?
Sample code
With that code, either the player has to hover the scrollbar, or try finding an empty spot in the PeopleList panel to click onto before using the wheel.
PeopleList = new Panel(new Vector2(0, 450), PanelSkin.ListBackground, Anchor.AutoCenter)
{
   PanelOverflowBehavior = PanelOverflowBehavior.VerticalScroll
};
SettlerScreen.AddChild(PeopleList);
foreach (var agent in agents)
{
    // settlerlist item is just a custom sub-panel containing npc info
    var item = new SettlerListItem(agent, new Vector2(580, 60), Anchor.Auto);
    PeopleList.AddChild(item);
}
PeopleList.IsFocused = true;
// tried with and without that v
if (PeopleList.Scrollbar != null)
    PeopleList.Scrollbar.IsFocused = true;

(edit: latest nuget build. windows)
Thank you for your time.
Cheers.

Hi @SerialKicked, thank you for the report!
Are the items on panel clickable? Or just for show?
If you don't need to click them as a temporary patch you can set their ClickThrough property to true.
This is kinda tricky problem I think so I'll probably be able to look at it this weekend..

No, they are clickable. Otherwise, yes indeed, it would have been an okay workaround.
No hurry, we're not going to release anything publicly before a couple months. And if you don't feel like adding that to the GUI's code base for a reason or another, I'll be perfectly happy with a dirty hack to add on my side.
Thanks :)

OK I finally had time to take a look, sorry for keeping you waiting ;)

First I tried to reproduce the "not focused on click issue". Since I don't have your custom class, SettlerListItem, I tried to reproduce with the following code:

var PeopleList = new Panel(new Vector2(0, 450), PanelSkin.ListBackground, Anchor.AutoCenter)
{
    PanelOverflowBehavior = PanelOverflowBehavior.VerticalScroll
};
panel.AddChild(PeopleList);
for (int i = 0; i < 100; ++i)
{
    // settlerlist item is just a custom sub-panel containing npc info
    var item = new Panel(new Vector2(0, 100), PanelSkin.Fancy, Anchor.Auto);
    item.AddChild(new Button("dasdsa"));
    PeopleList.AddChild(item);
}

But it works, eg when I click anywhere inside the panel (doesn't matter if its on the button, internal panels, or background) it focus properly on the scrollbar and I'm able to scroll with the mouse midbutton. I even tried setting ClickThrough to false and true - still works.
So I think maybe there's something wrong with your custom panel, SettlerListItem. Perhaps you are overriding some update functions and forgot to call the base class update?

About focusing on the panel upfront so you won't have to click inside to start scrolling - setting focus doesn't work, however the following does:

UserInterface.Active.ActiveEntity = PeopleList;
Unfortunately it seems like if you set it before calling the first Update call it doesn't work (a bug, I need to check it out), so try to set  UserInterface.Active.ActiveEntity = PeopleList; only after your update loop is called at least once with the panel visible..
Let me know if it worked, I'll try to check it out and see if there's an easy fix for it too.
Thanks!

Ah must've misunderstood you :)
Please let me know if it worked when you get to work on it, so I can close the ticket.
Thanks!

Ok, I just applied the workaround. It's working perfectly.
Thank you for the continued support on GeonBit.UI. It's appreciated.


Applicants not clear why passport number is being asked for twice during online verification process

Where?
https://work-in-gov.herokuapp.com/v2/pre-interview/3rd-cycle-matching
1)
Add the question “Do you have a UK passport?”
If yes - then the box appears to input number and the explanatory text below it.
If no - then should allow candidate to progress to next page
2)
Remove the “I don’t have a UK passport link”
3)
Move text:
Above text input.
Change from:
If you have a UK passport, we'll take a photo of you at your interview and automatically check it against your passport photo.
Change to:
By entering your passport details below, you are giving permission to access your details with her Majesty’s Passport Office (HM Passport Office). We will take a photo of you on the day of your interview and compare it with these details to confirm your identity.
The photo will not be stored and will be deleted as soon as the comparison is completed.

@wnialloconnor Is this still an issue?


Add offline mode

As title, after #235 is implemented, we can add offline mode for these tracks.
Workflow :

Check cache folder for current track, if found, just play it, if no, go 2.
Search from the online service to get the real source and play. (Auto-cache if the pref is on)

Our service highly relies on network and I can't see the benefit here to support offline, close first.


Repeated socket failures after ENOTCONN

FeatherS2 with ESP32S2
6.2.0-beta.0 on 2021-01-22
adafruit-circuitpython-bundle-6.x-mpy-20210122
This is intermittent, so it's hard to demonstrate, but after only two of these errors (I would have expected the threshold to be four) mixed among successful HTTPS GETs:
Traceback (most recent call last):
  File "code.py", line 621, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 564, in request
  File "adafruit_requests.py", line 562, in request
  File "adafruit_requests.py", line 477, in _send_request
  File "adafruit_requests.py", line 468, in _send
  File "adafruit_requests.py", line 466, in _send
OSError: [Errno 128] ENOTCONN

all subsequent GET attempts yield:
Traceback (most recent call last):
  File "code.py", line 621, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 559, in request
  File "adafruit_requests.py", line 454, in _get_socket
RuntimeError: Repeated socket failures

ENOTCONN arises quickly, <0.005 seconds after the GET.
Only workaround found so far is to reload.

@anecdata Do you have a time.sleep() in your code? see  https://github.com/adafruit/circuitpython/issues/4061

@anecdata Do you have a time.sleep() in your code? see  https://github.com/adafruit/circuitpython/issues/4061

@anecdata how rapidly are you making the send calls? I recently did some work to make the internals of Socket non-blocking, which might have resulted in some mis-identified errors if calls were made too fast. I'm still wrangling a bit with the error conventions of the Socket module, so I'm afraid I'm not sure how to go about addressing this problem without further info.

@anecdata how rapidly are you making the send calls? I recently did some work to make the internals of Socket non-blocking, which might have resulted in some mis-identified errors if calls were made too fast. I'm still wrangling a bit with the error conventions of the Socket module, so I'm afraid I'm not sure how to go about addressing this problem without further info.

Maybe Requests isn't catching the ENOTCONN and needs to try and recreate the socket as a result.

Maybe Requests isn't catching the ENOTCONN and needs to try and recreate the socket as a result.

@jerryneedell @hierophect There are no time.sleep() calls in the main loop of my 'production' code. When it starts up, there are three GET requests somewhat in sequence, but after that, it's minutes between GET requests. The ENOTCONN has arisen even after successful startup sequence, seemingly randomly in later loops. I'll try to gather more data.

@jerryneedell @hierophect There are no time.sleep() calls in the main loop of my 'production' code. When it starts up, there are three GET requests somewhat in sequence, but after that, it's minutes between GET requests. The ENOTCONN has arisen even after successful startup sequence, seemingly randomly in later loops. I'll try to gather more data.

Just a small tidbit of information... I put some code in before every network action that tests for connection by checking wifi.radio.ipv4_address (and connects if necessary). wifi.radio.ipv4_address should be None after a connection drops, it's the best check I've found to passively test connection to the AP without risking an exception.
Looks like when I get ENOTCONN either time, the connection still shows as active right before the GET:
Connected? True
Traceback (most recent call last):
  File "code.py", line 639, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 564, in request
  File "adafruit_requests.py", line 562, in request
  File "adafruit_requests.py", line 477, in _send_request
  File "adafruit_requests.py", line 468, in _send
  File "adafruit_requests.py", line 466, in _send
OSError: [Errno 128] ENOTCONN
Try GET #2 timeout 2s...
Connected? True
2021-01-26T11:08:04-06:00 200 bytearray(b'OK') 1.385s

Just a small tidbit of information... I put some code in before every network action that tests for connection by checking wifi.radio.ipv4_address (and connects if necessary). wifi.radio.ipv4_address should be None after a connection drops, it's the best check I've found to passively test connection to the AP without risking an exception.
Looks like when I get ENOTCONN either time, the connection still shows as active right before the GET:
Connected? True
Traceback (most recent call last):
  File "code.py", line 639, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 564, in request
  File "adafruit_requests.py", line 562, in request
  File "adafruit_requests.py", line 477, in _send_request
  File "adafruit_requests.py", line 468, in _send
  File "adafruit_requests.py", line 466, in _send
OSError: [Errno 128] ENOTCONN
Try GET #2 timeout 2s...
Connected? True
2021-01-26T11:08:04-06:00 200 bytearray(b'OK') 1.385s

@anecdata as noted in the other thread, this is almost certainly related to Send() erroneously reporting this error as ENOTCONN and is actually probably a non blocking or other timing problem. I'd be updating in that other thread as I work on it since I don't think it has anything to do with Requests.

@anecdata as noted in the other thread, this is almost certainly related to Send() erroneously reporting this error as ENOTCONN and is actually probably a non blocking or other timing problem. I'd be updating in that other thread as I work on it since I don't think it has anything to do with Requests.

@hierophect OK, thanks, just ruling out disconnection. I have a row of FeatherS2 boards with 6.1, 6.2, etc. so testing changes will be easy.

@hierophect OK, thanks, just ruling out disconnection. I have a row of FeatherS2 boards with 6.1, 6.2, etc. so testing changes will be easy.

@anecdata great, thanks a bunch for helping out with all this. Proper error handling and socket closing is still my biggest struggle on the low level.

@anecdata great, thanks a bunch for helping out with all this. Proper error handling and socket closing is still my biggest struggle on the low level.

Behavior is changed, but still present. Using today's artifacts from today's #4049 commits (6.2.0-beta.1-29-gaf92db28b on 2021-02-01) on multiple FeatherS2 with ESP32S2, I get this intermittently after some successful GETs:
  File "code.py", line 638, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 564, in request
  File "adafruit_requests.py", line 562, in request
  File "adafruit_requests.py", line 477, in _send_request
  File "adafruit_requests.py", line 468, in _send
  File "adafruit_requests.py", line 466, in _send
OSError: Failed SSL handshake

Then, after any two of those:
Traceback (most recent call last):
  File "code.py", line 638, in http_get
  File "adafruit_requests.py", line 595, in get
  File "adafruit_requests.py", line 559, in request
  File "adafruit_requests.py", line 436, in _get_socket
  File "adafruit_requests.py", line 433, in _get_socket
RuntimeError: Out of sockets

I would need to see your code to debug this any further. Based on the other issue, SSL failure can occur due to a timeout, but potentially from other problems as well. Running out of sockets will happen anytime you do not close a socket properly. I can track where these occur with LWIP_DEBUG and mp_printf/gdb but I'd need my hands on the code, or a subset of it that makes the issue occur (I don't get it with jerryn's anymore).

Note that we haven't fixed Requests yet, which doesn't properly close the socket unless you make the modifications I discussed in the other thread, so maybe the out of sockets problem related to that?

@hierophect Can you please point to the Requests modification you're referring to? I'm tracking about 20 networking issues and PRs right now, and I'm drawing a blank.

@anecdata Oh sure, sorry. It's number two on this list, https://github.com/adafruit/circuitpython/issues/4061#issuecomment-770274825, broken into this issue: adafruit/Adafruit_CircuitPython_Requests#67. An except that only catches _SendFailed needs to be made more generic so that sockets are closed properly.

If I modify Requests to also catch OSError along with _SendFailed, I don't get the RuntimeError: Out of sockets. I don't know if this is the right solution generally (for example, are there OSErrors that we shouldn't catch).
It looks like now OSError: Failed SSL handshake happens in my code when there have been no GET request for several minutes. But then it's immediately retried and works fine.

Side note: something is now broken with HTTP?:
import sys
import time
import socketpool
import ssl
import wifi
import secrets
import adafruit_requests as requests
from secrets import secrets

wifi.radio.connect(secrets["ssid"], secrets["password"])
print("RSSI", wifi.radio.ap_info.rssi)

socket = socketpool.SocketPool(wifi.radio)
http = requests.Session(socket, ssl.create_default_context())

URL = "http://wifitest.adafruit.com/testwifi/index.html"  # doesn't work
# URL = "http://httpbin.org/get"  #  doesn't work
# URL = "https://httpbin.org/get"  # works

while True:
    print("-" * 40)
    try:
        response = http.get(URL)
    except (OSError) as e:
        sys.print_exception(e)
    except (RuntimeError) as e:
        sys.print_exception(e)
        # unrecoverable, even with reload:
        """
        Traceback (most recent call last):
          File "code.py", line 26, in <module>
          File "code.py", line 24, in <module>
          File "/lib/adafruit_requests.py", line 597, in get
          File "/lib/adafruit_requests.py", line 560, in request
          File "/lib/adafruit_requests.py", line 429, in _get_socket
        RuntimeError: Sending request failed
        """
    try:
        print(response.status_code, response.reason)
        trash = response.text
        trash = None
        response.close()
    except (NameError) as e:
        sys.print_exception(e)
    time.sleep(5)

OK, I'm finally able to reproduce it with a public URL. I've modified adafruit_requests as described in the previous comment, and also added sys.print_exception(e). It appears that some state is retained from the prior request, and that is interfering with the subsequent request in a way that manifests as a Failed SSL handshake:
import sys
import time
import socketpool
import ssl
import wifi
import secrets
import adafruit_requests as requests
from secrets import secrets

# issue seems correlated to longer response bodies
URL = "https://api.coindesk.com/v1/bpi/currentprice.json"
# issue seems correlated to lack of a {"connection": "keep-alive"} header
#     ...hard to find in the wild, so force no keep-alive
HEADERS = {"Connection": "close"}
# delay to trigger the issue varies depending on server / response
#     ...in the coindesk case, no delay is necessary
DELAY = 0

wifi.radio.connect(secrets["ssid"], secrets["password"])
print("RSSI", wifi.radio.ap_info.rssi)

socket = socketpool.SocketPool(wifi.radio)
https = requests.Session(socket, ssl.create_default_context())

print(DELAY, "-" * 40)
for _ in range(0, 5):
    try:
        response = https.get(URL, headers=HEADERS)
    except (OSError) as e:
        sys.print_exception(e)
    except (RuntimeError) as e:
        sys.print_exception(e)

    try:
        print(response.status_code, response.reason, response.headers, end=" ")
        trash = response.text
        print(len(trash))
        trash = None
        response.close()
    except (NameError) as e:
        sys.print_exception(e)
    time.sleep(DELAY)

results in:
code.py output:
RSSI -47
0 ----------------------------------------
200 bytearray(b'OK') {'Content-Length': '677', 'Access-Control-Allow-Origin': '*', 'Date': 'Tue, 02 Feb 2021 19:03:12 GMT', 'X-Amz-Cf-Pop': 'ORD51-C2', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': 'VdlXBG50Iro5wh8eoH4gCvePNvA9pBw4gxuhHPBc0AJH4OPRHXphgg==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 7bae3892a4b9b7cb601b5d663d98de74.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '5', 'Expires': 'Tue, 02 Feb 2021 19:04:07 UTC'} 677
Traceback (most recent call last):
  File "/lib/adafruit_requests.py", line 563, in request
  File "/lib/adafruit_requests.py", line 493, in _send_request
  File "/lib/adafruit_requests.py", line 469, in _send
  File "/lib/adafruit_requests.py", line 467, in _send
OSError: Failed SSL handshake
200 bytearray(b'OK') {'Content-Length': '677', 'Access-Control-Allow-Origin': '*', 'Date': 'Tue, 02 Feb 2021 19:03:12 GMT', 'X-Amz-Cf-Pop': 'ORD51-C2', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': 'QVwyEh8LNK8LO-V8cLi5N5cf4PYxXOlEyGUjmnGYMAFY78FnDDbXWw==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 6aec8f1aa09edf6116ef0f638212a7c6.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '5', 'Expires': 'Tue, 02 Feb 2021 19:04:07 UTC'} 677
Traceback (most recent call last):
  File "/lib/adafruit_requests.py", line 563, in request
  File "/lib/adafruit_requests.py", line 493, in _send_request
  File "/lib/adafruit_requests.py", line 469, in _send
  File "/lib/adafruit_requests.py", line 467, in _send
OSError: Failed SSL handshake
200 bytearray(b'OK') {'Content-Length': '677', 'Access-Control-Allow-Origin': '*', 'Date': 'Tue, 02 Feb 2021 19:03:12 GMT', 'X-Amz-Cf-Pop': 'ORD51-C2', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': 'lsJX0sBdNAPaiWcWt5Slanu7XJb95u-SsLJ4lUaY8DE3_VGpz5MhEg==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 9f453aa625f8fca7ca79ca9f2de01aaf.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '6', 'Expires': 'Tue, 02 Feb 2021 19:04:07 UTC'} 677
Traceback (most recent call last):
  File "/lib/adafruit_requests.py", line 563, in request
  File "/lib/adafruit_requests.py", line 492, in _send_request
  File "/lib/adafruit_requests.py", line 469, in _send
  File "/lib/adafruit_requests.py", line 467, in _send
OSError: Failed SSL handshake
200 bytearray(b'OK') {'Content-Length': '677', 'Access-Control-Allow-Origin': '*', 'Date': 'Tue, 02 Feb 2021 19:03:12 GMT', 'X-Amz-Cf-Pop': 'ORD51-C2', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': 'XmMaly1HblL_yhwwsro0mkYZ3BGM-xfhFEXXIA49XRPwrKfBOoosYA==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 ac7135d7082fee948afa4d75bab8e0e1.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '7', 'Expires': 'Tue, 02 Feb 2021 19:04:07 UTC'} 677
Traceback (most recent call last):
  File "/lib/adafruit_requests.py", line 563, in request
  File "/lib/adafruit_requests.py", line 493, in _send_request
  File "/lib/adafruit_requests.py", line 469, in _send
  File "/lib/adafruit_requests.py", line 467, in _send
OSError: Failed SSL handshake
200 bytearray(b'OK') {'Content-Length': '677', 'Access-Control-Allow-Origin': '*', 'Date': 'Tue, 02 Feb 2021 19:03:12 GMT', 'X-Amz-Cf-Pop': 'ORD51-C2', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': 'HwkbkE9vaGUvmOI0tH5QaYUDRVZLy8fZciddrfoE5QZ2LRYCRNRBhA==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 cf1ea76a2398f8d5f0e0d97f61992ee8.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '8', 'Expires': 'Tue, 02 Feb 2021 19:04:07 UTC'} 677

In the pre-ESP32-S2 days, Requests was HTTP/1.0 and we sent no countermanding Connection header, so each HTTP connection would get closed after the response (by client and server).
In HTTP/1.1 (newly supported in Requests in conjunction with ESP32-S2) HTTP connections are presumed persistent (keep-alive) unless the server sends a Connection: close header, or the client does and the server must comply.
Requests doesn't currently take any action on the presence or absence of a Connection header, and as far as I can tell, always tries to close the socket after a Response is received (this is HTTP/1.0 default, or Connection: close, behavior), but we do not send a Connection: close header. Presumably, the server will eventually timeout its connection. Our subsequent connections to the same server will use new sockets.
The timing differences are a mystery too... why some servers / responses fail immediately and some fail only after specific amounts of time have lapsed.

I'm closing this since the original repeated socket failures / out of sockets issue was resolved. The OSError: Failed SSL handshake will still lurk in the background under some circumstances, but PR 70 will mask it from the user by closing the offending socket and retrying with a new one.

@anecdata I think the reason the SSL handshake occurs every other request (as it did with Jerry's code too) is because of how the socket fails - on the first use, it sees there's no socket and creates one, on the second, it sees there already is one and attempts to use it, but fails, and closes it. Then, because the socket has been closed, it just creates a new one on the next request and has no error again, creating the appearance of alternating failures. Does that make any sense?

the second fails why... because in the core or IDF it has timed out and been closed out from under Requests?

@anecdata it actually happens even lower than the core, it's an error returned by esp_tls_conn_new_sync which is from the esp-idf, part of Mbed TLS. It's possible that the timeout that Requests has set up is not aligned with the timeout in MbedTLS.

Saola1w/Wrover 6.2.0-beta.0 on 2021-02-11
adafruit-circuitpython-bundle-6.x-mpy-20210211
code from https://github.com/adafruit/Adafruit_CircuitPython_Requests/issues/63#issuecomment-771909006
This is still happening behind the scenes (I edited Requests to print the exceptions), now showing up as ENOTCONN again. 1st and odd GET tries successful, even GET tries ENOTCONN.
code.py output:
RSSI -42
0 ----------------------------------------
200 bytearray(b'OK') {'Content-Length': '679', 'Access-Control-Allow-Origin': '*', 'Date': 'Thu, 11 Feb 2021 18:48:10 GMT', 'X-Amz-Cf-Pop': 'ORD52-C1', 'X-Powered-By': 'Fat-Free Framework', 'X-Amz-Cf-Id': '_7D0BVwz4AISAZztEn-Zw4A_b20UpF9odFYVJDckBXA0GX9OBfL4iw==', 'Server': 'nginx/1.14.1', 'Content-Type': 'application/javascript', 'Connection': 'close', 'Via': '1.1 dbac66991c4a77b037591a50df7b35d8.cloudfront.net (CloudFront)', 'X-Cache': 'Hit from cloudfront', 'Cache-Control': 'max-age=15', 'Age': '4', 'Expires': 'Thu, 11 Feb 2021 18:49:07 UTC'} 679
Traceback (most recent call last):
  File "/lib/adafruit_requests.py", line 570, in request
  File "/lib/adafruit_requests.py", line 486, in _send_request
  File "/lib/adafruit_requests.py", line 474, in _send
  File "/lib/adafruit_requests.py", line 471, in _send
OSError: [Errno 128] ENOTCONN

DEBUG log:
W (6580316) wifi: got ip
I (6580516) esp-x509-crt-bundle: Certificate validated
E (6581446) esp-tls-mbedtls: write error :-80:
I (6581596) esp-x509-crt-bundle: Certificate validated
E (6582516) esp-tls-mbedtls: write error :-80:
I (6582676) esp-x509-crt-bundle: Certificate validated
E (6583606) esp-tls-mbedtls: write error :-80:
I (6583766) esp-x509-crt-bundle: Certificate validated
E (6584706) esp-tls-mbedtls: write error :-80:
I (6584866) esp-x509-crt-bundle: Certificate validated

It's not fatal to user code since Requests catches the exception and retries once, but it indicates that something is consistently not happening as we would expect, and could manifest in other ways with different applications or libraries.


Filter out duplicate EIP-6963 providers does not filter out Metamask Mobile

Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Describe the bug
This is a follow-up issue to the functionality introduced in PR #4343 (thank you @tmm!).
Metamask Mobile uses the io.metamask.mobile rdns. This means that using wagmi via the metamask browser on mobile with multiInjectedProviderDiscovery and the metamask connector initialized will still result in duplicated Metamask connectors.
Link to Minimal Reproducible Example
https://wagmi-tests-2.vercel.app/
Steps To Reproduce

Open Metamask Mobile on iOS or Android
Open https://wagmi-tests-2.vercel.app/
Two metamask connectors show up instead of one, because the io.metamask.mobile rdns is not filtered.

What Wagmi package(s) are you using?
wagmi
Wagmi Package(s) Version(s)
2.12.31
Viem Version
2.21.45
TypeScript Version
5.3.3
Anything else?
Can find the code for the reproducible example here: https://stackblitz.com/edit/new-wagmi-pddqi8

Nice find! If someone wants to work on this, all they need to do is add readonly string[] to rdns and update a few places in createConfig.ts and hydrate.ts (follow the type errors).

Thank you for the quick turnaround @starc007 and @tmm !


Is this available in the App Store?

Hi there, this is a great project! However I am unable to find it in the App Store.
Has it been removed, or restricted to certain countries>

idk
:>>

@fahimrahmanbooom ?

I’m sorry. It’s still not on the AppStore because this cryptocurrency is currently not on the apple’s list. However if you have a mac you can install the app.

I’m sorry @ryanfortner . It’s still not on the AppStore because this cryptocurrency is currently not on the apple’s list and apple rejected the app. However if you have a mac you can install the app.

Do you mean that you can use a Mac to install it on an iOS device, or you can only install it on macOS?

I’m sorry @ryanfortner . It’s still not on the AppStore because this cryptocurrency is currently not on the apple’s list and apple rejected the app. However if you have a mac you can install the app.

Do you mean that you can use a Mac to install it on an iOS device, or you can only install it on macOS?

Using a macOS you can install the app on your iPhone through Xcode.


generic log filtering context manager

@mambocab would love some comment when you've got a few!

trying a full trunk dtest run with this in place, over here: http://cassci.datastax.com/view/Dev/view/knifewine/job/knifewine-trunk_dtest_log_contextman/1/

+1 after my nits, looks awesome

CI looks good, and confirmed with a little bit of local smoke testing. Merging, thanks @mambocab for the context manager idea and help along the way!


Command Center customization

I want to have ability to add/edit action/tools/buttons(with icons) on the Command Center, near by navigation buttons

I't be nice if you'd provide more details about what kind of use-case you have and what you might want those buttons to be able to do, and why you'd rather have that rather than use some other shortcut mechanism like keyboard shortcuts.
Related on Stack Overflow: How I can add tools/actions/buttons to the Command Center of VS Code

Here are some potential use cases and reasons why having customizable buttons/tools in the Command Center panel can be beneficial not only for me, but for all developers also:

Streamlined Workflow: Custom buttons/tools can provide quick access to frequently used commands or actions, allowing developers to streamline their workflow. Instead of navigating through menus or remembering keyboard shortcuts, they can have dedicated buttons/tools readily available in the Command Center panel.

Visual Accessibility: Some developers might prefer visual cues and icons over text-based shortcuts. Custom buttons/tools can make it easier for visually-oriented individuals to locate and execute specific commands quickly.

Discoverability: The Command Palette is a powerful feature in VS Code for discovering and executing commands. However, not all users may be aware of its existence or know the exact command names. Custom buttons/tools can serve as visual prompts, making it easier for users to discover and access specific functionality without searching through the Command Palette.

Non-Standard Commands: While VS Code offers an extensive set of predefined commands, developers may have custom scripts or extensions with specific commands tailored to their development environment or workflow. Custom buttons/tools provide a way to expose these non-standard commands directly in the Command Center panel, enhancing accessibility and convenience.

User Interface Consistency: Custom buttons/tools in the Command Center panel can help maintain a consistent user interface across teams or organizations. By providing a centralized and customizable location for frequently used commands, everyone can have access to the same set of tools, ensuring a uniform experience.

Ultimately, the goal is to provide developers with more flexibility and customization options to tailor their development environment to their specific needs, preferences, and workflows.

this is mostly https://github.com/microsoft/vscode/issues/9285

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Please invite me to the community

Name
Lim
Additional Context
I'd like to join your organization.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is an open source solution for serverless platforms, it is designed for developing solutions and enhancing creators to create their infrastructure 💻 Great to have you in our community ✨ Looking forward to your valuable contributions! 🤓 You can also check our community ✨ Github ✨ LinkedIn 💜 You can also share our community with other folks who want to learn about development, DevOps, tech, and contribute together and with us 👉💜👈


Improve Sellsy API Client

Handle tooManyRequestsException
Improve logging in Sellsy API

Hi @Annouar , any chance to merge this PR ?

Hey guys!
Sorry for the late and thank you for the PR! Just let me take a look on it this weekend ;)
I'll let you know as soon as possible!
Best regards

Hey @Annouar ,
any updates on this PR?

@Annouar ping about this PR


OpenShift - Projects - Search - not functioning

Describe the bug
I've struggled to get the search to return any results, I've tried multiple records using Name or Label but no results are ever returned.
To Reproduce

Login to OpenShift
Click Home and then Click Search
See the screenshots below to see the search criteria I was using, first adding in APIRequestCount and clicking search does not return any results (although this is valid)
Selecting multiple resources and then searching for either Label or API doesn't seem to return any valid results
When you enter in a value to search and click enter, the value is also removed

Expected behavior
The search functionality should be useful to the end user, personally I found it very difficult to use and provide any value.
Screenshots

Additional context
Add any other context about the problem here.

OpenShift bug, not related to the workshop

https://issues.redhat.com/browse/OCPBUGS-43617


misc cytokinesis

inviable branched, swollen vegetative cell
abolished protein localization to actin cortical patch, with protein mislocalized to nucleus
abolished protein localization to actin cortical patch, with protein mislocalized to cytoplasm
delayed onset of cell separation after cytokinesis

1-3 PMID:11076964, 4 PMID:16864655

which fig is this one:

inviable branched, swollen vegetative cell
(I thought the branched  inviable phenotype occurred was necessarily multiseptate and elongated...but I couldn't see any branching in the figs...)

...unless they are "T" shaped (but that isn't a cytokinesis defect, and is viable)

got it....yep, I don't think we have previously identified these as "branched" but I can see they are trying to branch (they are probably the ones that got pooled in misshapen inviable, but  Jacky said looked like a potato!)

yeah, I couldn't tell from the pic whether the poster-child cell was elongated or septated; new term is neutral w.r.t. both features to play it safe

inviable branched, swollen vegetative cell FYPO:0006794
abolished protein localization to actin cortical patch, with protein mislocalized to nucleus FYPO:0006795
abolished protein localization to actin cortical patch, with protein mislocalized to cytoplasm FYPO:0006796
delayed onset of cell separation after cytokinesis FYPO:0006797
edit file: 7f2d16e4ed45ac80b176a33ac6ab4a8678e08b44
release: 0fc00696a9019019ef398758b4d662feed919770


Document support for K8s 1.21

GitHub issues:

Integrating with Docker-shim https://github.com/rancher/rancher/issues/31943
Disable default backend by default for ingress-nginx https://github.com/rancher/rancher/issues/30356
Point of contact: Kinara

After talking to Kinara, it sounds like no documentation are required regarding the fact that the default backend is now disabled by default for ingress-nginx.
The default backend won't run as a deployment anymore, but the /healthz endpoint continues to work. If you enable the default backend, the deployment will show up, and if you disable it, it won't. But the behavior is the same from an end user's perspective, so no docs change is required. If users want anything extra, they need to pass in their own backend.


Add link to Project Code in GitHub

Tutorial is good as a step-by-step, but it would be nice to also link to a fully working solution for users that want to dive in any play with the code or need a sample app.
Or link to something similar:

https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/data/ef-rp/intro/samples/cu50

Or link to a 3rd party:

https://github.com/jbogard/ContosoUniversityDotNetCore-Pages

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ad06677-5842-c1aa-153f-7993a9660dfa
Version Independent ID: 8daf79df-eac4-358b-e6f0-6def45bd54da
Content: Tutorial: Get started with EF Core in an ASP.NET MVC web app
Content Source: aspnetcore/data/ef-mvc/intro.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@ppittle  thanks for the suggestion. we've done that in the past but the code is built for the documentation rendering and is not very friendly to view. I'll try something like that in my RP update. See https://github.com/dotnet/AspNetCore.Docs/pull/21576
We don't like to maintain multiple versions.
We've also found most customers who want to try the sample app don't want the complexity of the completed app, they prefer something before inheritance.
We typically don't link to 3rd party samples.
We'll reconsider this if we get enough interest.


32bit windows support

Added path for windows kit in x86 windows.

LGTM. I'm not sure what's wrong with the CI build for node 6, but it's unrelated to this change, and the CI passed on the other node versions.


How the setup will be ?

Hi BSI,
I have Open5Gs and UERANSIM each on separate VMs and able to establish the PDU session. Further I am looking forward to do SCAS testing on existing setup. Could you please suggest how can use your scripts to run the SCAS testing?
I am fine to go ahead with new setup too in case if above setup is not suitable to SCAS scripts, please share how will be the setup ?
Thanks in advance!
Appreciate your efforts on SCAS and looking forward to hands on this.
Best Regards,
Rajinder Singh

Hi Rajinder,
in order to run the tests with VMs, you need to implement your own device interfaces. Have a look at https://github.com/BSI-Bund/pySCASso/tree/main/scas/device_interfaces
You could basically take the existing specific implementations for Open5GS and UERANSIM and adapt all the methods like start, stop, perform and so on. Another important method is create_capture. You should create your own Capture-class that is able to trace at your VMs interfaces. Also, adapt the Configuration-Classes to your needs.
Best Regargs

Thanks for the reply.
Trying to be more clear on this. Following two methods to follow:-

Need to configure the device interfaces as per Open5GS and UERANSIM VMs in the following files ? https://github.com/BSI-Bund/pySCASso/tree/main/scas/device_interfaces.  such as SMF_IP = IP address and SMF_PORT = portnumber, etc.  Is it ?
Or Make an another setup using the existing specific implementations for Open5GS and UERANSIM and adapt all the methods.
please share the link for Open5GS and UERANSIM ? I will create a new setup using default device interfaces.
To run the 'pySCASso' solution, do need to create an separate VM or can install on existing 'Open5GS and UERANSIM' VMs ?
Could you please share the example of start, stop, perform, create_capture methods ?

Apology as I am just the beginner so might asking basic questions.
Thanks alot :)P

Hi BSI,
Morning, I managed to execute a few AMF test cases using the Open5gs and UERANSIM, but none of the enodeb and gnodeb test cases in all releases is executable. Most of enodeb and gnodeb test cases Skipped with cause 'Not Implemented'. Could you please suggest further how to fix the problem with gnodeb and enodeb test cases ? For reference attached the image.

Hi Rajinder,
there are no eNodeB/gNodeB test implementations, just test stubs.
We only implemented a few test cases for some network functions to work as an example.
If you have a look at those implemented test cases, you should be able to adapt them and develop eNodeB/gNodeB test cases.
kind regards


Doc: Broken link https://godoc.org/github.com/go-redis/redis#Multi

Hi, I am new to go-redis. When I read the homepage (README.md) and try to figure out how to use transactions. The link provided is https://godoc.org/github.com/go-redis/redis#Multi which is borken. There is no #Multi on the doc. Should I use TxPipeline? right? Thanks a lot.

Yes, i've fixed the link

@vmihailenco Thanks a lot for your quick fix. Since I don't find a gitter channel for this project, can I ask a question here? I am new to both redis and go-redis. For pipeline (or transaction), can I do something like the following?
pipe := redisdb.Pipeline()

a, _ := pipe.Incr("pipeline_counter").Result()
aStr := strconv.FormatInt(a, 10) + "something"
b, _ := pipe.Incr("pipeline_counter"+aStr).Result()
bStr := strconv.FormatInt(b, 10) + "something"
c, _ := pipe.Incr("pipeline_counter"+bStr).Result()

_, err := pipe.Exec()

Because the commands are queued, I don't know if I can trust the order and the result returned and use the result in another command from the same pipeline.
And is this the same behavior to transaction (TxPipeline) too?
Thanks a lot.

You can't call Result before Exec, but you can save commands and call Result later:
pipe := redisdb.Pipeline()
a := pipe.Incr("pipeline_counter")
_, err := pipe.Exec()

_, _ := a.Result() // get the result after commands are executed

@vmihailenco Thank you very much for the quick answer. OK, I got it. So I can't group/pipeline commands if any of them requires the result from a command inside the same pipeline.


How we do with using glyphicon uregent please help where we put  ng2-datetime-picker .

       <input class="form-control" # type="text" placeholder="Choose date"   ng2-datetime-picker  date-only="true">

First of all, your question is unclear to me. Please create a plunker example or any other example to illustrate, I say illustrate, your issue.
Without seeing it, I do not understand your problem.

ng2-datetime-picker  with icon I wanted to do but its take only from a text when I click on text how we do with the icon.when I click on the icon then the date will be displayed in text.

It was hard to understand your question.
I assume that you want to click an icon, then you want to see datetime picker.
If so, you can simply  add (click) function to your glyphicon that triggers click of your input field
a working example is here:  https://plnkr.co/edit/osIhs8?p=preview

Hi,
This plunker example is not working,can you check that once.
https://plnkr.co/edit/osIhs8?p=preview


Testing GitHub

Just trying to figure out how this all works.

Leaving a second comment to continue testing.


Pull in prevalence estimates from another source rather than rolling our own

An example might be https://covid19-projections.com/us-ca. We would need to look into their methodology and decide if we like/trust this source.

I just checked California. They think 630,000 people are currently infected, of which half are actively infectious = 315,000. We think there were 38,485 reported cases in the past week, and multiply by 8 to get 307,880 infections. Close enough IMO! For the US as a whole we estimate 2.33 million active infections, relative to their 2.04 million.
I haven't read the full analysis on https://covid19-projections.com/estimating-true-infections/, but if we trust it, we could import their formula: true-new-daily-infections = daily-confirmed-cases * (16 * (positivity-rate)^(0.5) + 2.5)

I've been using the covid19-projections data for a visualization and it works pretty well, but it does tend to lag during a new outbreak. I think this is because it minimizes error on the deaths timeseries which is lagged by 20-30 days, then runs the model forward to today. So this will underestimate infections at the beginning of a new outbreak because it's still using "old" parameters. The empirical model you mention above might actually perform better because it's based on more recent test positivity data.
IHME's estimated infections suffer from a similar problem, spot checks I've done continuously underestimate cases during new outbreaks (even though they seem to use hospitalizations as a leading indicator of deaths). This might just be because they don't pull new data into their model as often, but right now their estimate for new infections in Wisconsin is 1,320. This is less than the 1,408 confirmed cases yesterday, which is probably a 4-10x undercount because cases are growing rapidly.
Another group that's providing an estimate of prevalence is cmmid. I don't know enough to evaluate their approach, but this tool adapted it to estimate local prevalence. Or you could just keep using your current approach, it seems to perform well when compared to seroprevalence studies, and it probably won't miss new outbreaks because it's based on reported cases. The only concern I have is that the correlation between test positivity and the CAR might not hold if places ramp up their testing capabilities differently.

proposal: use the estimates from https://covidestim.org/?

http://localhost:3000/paper/14-research-sources#basic-method-underreporting-factor we use https://covid19-projections.com/estimating-true-infections-revisited/ now.


Integration test failing in Product APIM

Description:
It looks like the integration tests are filing after bumping the https://github.com/wso2-extensions/apim-km-wso2is/ version in the product and the suspected PR is https://github.com/wso2-extensions/apim-km-wso2is/pull/55
Hence reverted the above PR with https://github.com/wso2-extensions/apim-km-wso2is/pull/59
Need to check why the tests areafiling.

Closing and tracking through the original issue https://github.com/wso2/product-apim/issues/11374


Match the right pgid when restarting the datastore

https://ocd.appscale.com:8080/job/Daily Build/956/


[FX-995] Add receipt for Balance Inquiry Flow

What

Displays a formatted receipt in the Balance Inquiry flow instead of just dumping the response.
Forks Payments API models like Balance, Card, PaymentMethod, and creates POS-specific ones that have unique properties for POS flows

Why

Linear ticket

Note that some of this PR also relates to FX-972.

Now that the responses from Payments API differ for POS vs online only, we'll start getting runtime errors. We use retrofit to generate data accessors for the Payments API responses and we declare what fields those responses should and won't have. However, POS returns certain fields that are not present in online-only. This was the motivation for forking what were previously shared data models and to start maintaining separate models for POS.

Test Plan
Tested this on the POS Terminal visually and by printing and it works. Also see demo below
Demo
https://github.com/teamforage/forage-android-sdk/assets/12377418/ebb9478d-91c5-404d-9665-57c07d0a8ed1

How
Can be released as is

Current dependencies on/for this PR:

main

PR #188   👈

This stack of pull requests is managed by Graphite.

Closing this in favor of #205


⚠ Processors has degraded performance

In fc82aa1, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: Processors performance has improved in 930a361.


Update menu connected close on action

A new props to choose if menu close or not on click elements in the menu
Improve the menu to be more flexible

Codecov Report

Merging #884 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   99.76%   99.73%   -0.03%
==========================================
  Files         282      282
  Lines        7173     7170       -3
  Branches     1757     1755       -2
==========================================
- Hits         7156     7151       -5
- Misses         17       19       +2

Impacted Files
Coverage Δ

src/components/menu/MenuActions.ts
100% <100%> (ø)
:arrow_up:

src/components/menu/MenuReducers.ts
100% <100%> (ø)
:arrow_up:

src/components/menu/MenuConnected.tsx
96.42% <75%> (-3.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5f0c8...e246d1a. Read the comment docs.


Admin Delete Workflow RPC and request

Please add corresponding protobuf changes as well

Ah, nevermind... It is not in this repository.


Loading div into dialog

Hi,
I've found many lightboxes allowing me to load an existing div into a lightbox, however I haven't found anything like yours capable of using bootstrap grid system to make the dialog box width responsive...
How would you advise over getting an existing div from my page (hidden by a parent div) into a dialog?
Cheers,
Yann

you can do it like so,
var existingDivContent = $('.div').html();
$.confirm({
    content: existingDivContent
});

i hope this helps. 👍


'Content' cannot be used as a JSX component.

I am trying to use the components like Content, Message, and Sidebar to return some JSX code, but I am encountering an error saying that it cannot be used as a JSX component. I have attached a screenshot of the issue.

Please post the code associated with this issue


TLS Handshake Failed: NoCipherSuitesInCommon Error

What Operating System are you seeing this problem on?
Rocky8
What Hardware is this system running?
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              12
On-line CPU(s) list: 0-11
Thread(s) per core:  2
Core(s) per socket:  6
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
BIOS Vendor ID:      Intel(R) Corporation
CPU family:          6
Model:               158
Model name:          Intel(R) Xeon(R) E-2286G CPU @ 4.00GHz
BIOS Model name:     Intel(R) Xeon(R) E-2286G CPU @ 4.00GHz
Stepping:            10
CPU MHz:             4601.359
CPU max MHz:         4900.0000
CPU min MHz:         800.0000
BogoMIPS:            8016.00
Virtualization:      VT-x
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            12288K
NUMA node0 CPU(s):   0-11
KumoMTA version
2024.05.23-11841789
Did you try the latest release to see if the issue is better (or worse!) than your current version?
Yes, and I updated the version box above to show the version that I tried
Describe the bug
I encountered a TLS handshake failure while attempting to send an email using kumomta. The error log indicates that the peer is incompatible due to no common cipher suites. Below are the details of the error:
Jun 25 16:02:39  kumod[892323]: 2024-06-27T16:02:39.069254Z DEBUG  smtpsrv-8 run{socket=PollEvented { io: Some(TcpStream { addr: , peer: ...:6100, fd: 19 }) }}:process: kumod::smtp_server: TLS handshake failed: peer is incompatible: NoCipherSuitesInCommon
To Reproduce
No response
Configuration
Lua file
kumo.on('init', function()
kumo.set_diagnostic_log_filter 'kumod=debug'
kumo.start_esmtp_listener {
listen = '0:2525',
hostname = 'kumomta.domain.io'
}

kumo.start_esmtp_listener {
	listen = '<IP_ADDRESS>:587',
	hostname = 'kumomta.domain.io',
	tls_certificate = '/opt/kumomta/etc/ssl/kumomta.domain.io.cert.pem',
	tls_private_key = '/opt/kumomta/etc/ssl/kumomta.domain.io.key.pem',
	max_recipients_per_message = 10
}
kumo.start_http_listener {
	listen = '<IP_ADDRESS>:8000',
	hostname = 'kumomta.domain.io',
	use_tls = false,
	tls_certificate = '/opt/kumomta/etc/ssl/kumomta.domain.io.cert.pem',
	tls_private_key = '/opt/kumomta/etc/ssl/kumomta.domain.io.key.pem',
}

kumo.define_spool {
	name = 'data',
	path = '/var/spool/kumomta/data',
	kind = 'RocksDB',
}

kumo.define_spool {
	name = 'meta',
	path = '/var/spool/kumomta/meta',
	kind = 'RocksDB'
}

kumo.configure_local_logs {
	log_dir = '/var/log/kumomta',
	headers = { 'Subject', 'X-Tracking-Id' },
	meta = { 'received_from','tenant','received','domain','routing_domain' },
}

kumo.configure_bounce_classifier {
	files = {
		'/opt/kumomta/share/bounce_classifier/iana.toml',
	},
}

kumo.configure_log_hook {
	name = 'amqp',
	headers = { 'Subject', 'X-Tracking-Id' },
	meta = { 'received_from','tenant','received','domain','cid','pool_id','server_id' ,'email_domain','received_at','from_email','routing_domain'},

}

end)
Expected Behavior
No response
Anything else?
No response

The client is using a set of incompatible cipher suites.
You should either:

Strongly Preferred: upgrade your client to use a more modern TLS implementation and cipher suite,
or: disable TLS in the configuration of that client. Note that legacy cipher suites are generally broken/compromised and should not be used; they are generally equivalent to clear text anyway, so disabling TLS in that case is not a material reduction in the privacy of the connection.


Need to support CRI v1 and v1alpha2 at the same time

See https://github.com/cri-o/cri-o/pull/4408
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows us to support both CRI implementations at the same time by using the internal types to glue the functionality together.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Add support for CRI v1 protocol side by side to the existing v1alpha2

LGTM!

LGTM!


KittopiaTech for 1.2

Apparantly this wasn't updated yet.
Closes #4900

LGTM, Merging with thanks!


added copy address icon & functionality on displayAddress

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

Alright!

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

@yukigesho  how do you see these below

In this way, we impact all addresses. I suggest moving the copy as a separate component and reusing it

@yukigesho  here I just added an optional prop to displayAddress to either show the copyAddressIcon or not, so we could get a better look


Adaptive_lighting calls async_forward_entry_setup for integration, which is deprecated

Home Assistant Adaptive Lighting Issue Template
Bug Reports
If you need help with using or configuring Adaptive Lighting, please open a Q&A discussion thread here instead.
Before submitting a bug report, please follow these troubleshooting steps:
Please confirm that you have completed the following steps:

[x] I have updated to the latest Adaptive Lighting version available in HACS.
[x] I have reviewed the Troubleshooting Section in the README.
[x] (If using Zigbee2MQTT) I have read the Zigbee2MQTT troubleshooting guide in the README.
[x] I have checked the V2 Roadmap and open issues to ensure my issue isn't a duplicate.

Required information for bug reports:
Please include the following information in your issue.
Issues missing this information may not be addressed.

Debug logs captured while the issue occurred. See here for instructions on enabling debug logging:

Logger: homeassistant.helpers.frame
Source: helpers/frame.py:184
First occurred: 07:49:11 (1 occurrences)
Last logged: 07:49:11

Detected that custom integration 'adaptive_lighting' calls async_forward_entry_setup for integration, adaptive_lighting with title: Woonkamer and entry_id: 1e0fa32772dd229b002bda8055ffd761, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/adaptive_lighting/__init__.py, line 69: hass.async_create_task(, please create a bug report at https://github.com/basnijholt/adaptive-lighting/issues

Your Adaptive Lighting configuration:

Not relevant.

(If using Zigbee2MQTT), provide your configuration files (remove all personal information before posting):

devices.yaml
groups.yaml
configuration.yaml ⚠; Warning REMOVE ALL of the PERSONAL INFORMATION BELOW before posting ⚠;

mqtt: server:
mqtt: user:
mqtt: password:
advanced: pan_id:
advanced: network_key:
anything in log_syslog if you use this

Brand and model number of problematic light(s)

Not relevant.

Describe the bug and how to reproduce it:

Steps to reproduce the behavior:

Already exists


Implementing AwsProfileRegionProvider Autoconfiguration using profile.

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring

:scroll: Description
This PR fixes https://github.com/awspring/spring-cloud-aws/issues/70
Autoconfigure AwsProfileRegionProvider based on spring.cloud.aws.region.profile.name property configuration.
:bulb: Motivation and Context

:green_heart: How did you test it?
Implemented unit test to verify the registration of AwsProfileRegionProvider based on profile properties configuration.
:pencil: Checklist

[ ] I reviewed submitted code
[x] I added tests to verify changes
[ ] I updated reference documentation to reflect the change
[x] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

Awesome, thanks a lot @sivaprasadreddy!


Add soft delete to existing objects (after events)

Set IsActive field to false and ensure stored procs don't return any data where IsActive is false

This will involve adding delete functionality to existing entities (reunions, addresses, events)


feat: integrate elrond

📝 Description
Integrate WalletApi adapter for elrond family
❓ Context

Impacted projects: common
Linked resource(s): https://github.com/LedgerHQ/wallet-api/pull/133

✅ Checklist

[x] Test coverage
[ ] Atomic delivery https://github.com/LedgerHQ/wallet-api/pull/133
[x] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

Closing due to https://github.com/LedgerHQ/ledger-live/pull/3004#issuecomment-1479745770


Generate teams in the CI

I think the workflow file cannot be triggered until it gets merged into main


Use box-drawing characters.

Replace - and | with box drawing characters to further beautify the ascii-tree.
In response to Issue- #1
Trees in README.md and example/small_tree have been modified.
A typo was corrected in ascii_tree/ascii_tree

Thanks. I appreciate this. But I don't like that this introduces global state into the draw module. I'm going to refactor the draw module to accept a character set, which should also handle some other use cases as well.

Thank you for the feedback.
I felt that the usage of global variables would not be received well when the same can be accomplished using a return statement, and it was indeed the case.
Nevertheless, this was a good learning experience. Thanks.


Clean up and renames

- Description of the problem which is fixed/What is the use case

use new namespace name and refer to new quay.io repository
We should adhere to the naming convention in OpenShift and use
the default namespace openshift-sandboxed-containers. The same goes for
the quay.io user/repository we use. Use the new
quay.io/openshift_sandboxed_containers instead of
quay.io/isolatedcontainres.

delete example configmap for payload. We don't have a payload any more.

- What I did
This cleans up README and example files to use the namespace
openshift-sandboxed-containers instead of sandboxed-containers-operator-system.
- How to verify it
Follow the README descripton to install/uninstall and make sure all steps work.
- Description for the changelog
Use new namespace openshift-sandboxed-containers and refer to new quay.io organisation quay.io/openshift_sandboxed_containers

I pushed another update. The biggest change is that we're now using openshift-sandboxed-containers**-operator** as the namespace. It matches the other openshift operators.

Apparently I'm not a collaborator. Sill approving, for what it's worth ;-)


Dropdown search

Ability to search in dropdown without opening the dropdown list. When the focus is on the control list item to be selected based on the user input. If user inputs T the list to search and select first item based on that character and further search by up/down arrow from the current position in list . Somewhat like this

Bumping this issue, this is a major user experience issue for our users who are used to normal browser dropdowns 'jumping' to the typeahead characters that they type.  Right now, for dropdowns without search/filter capability, no amount of typing one of the valid values results in that value being selected.  You can use the arrows to 'arrow down' to the value you want, but that is not great UX and definitely not accessible.

Bumping this as there is a fix in a fork since June 15th 2022
This is a breaking feature for many CRUD applications. Many users will navigate CRUD pages with only the keyboard, being able to choose items in a dropdown by typing their first few letters is a standard feature that has been around for years.

Already supported


email verification stub

stubs for request passcode:
https://github.com/hmrc/email-verification#post-request-passcode
and verify passcode:
https://github.com/hmrc/email-verification#post-verify-passcode


1.add vanjee lidar driver

添加万集激光雷达驱动

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

重新提交


The NVDA is not announcing the control type for the "Microsoft" and "Ratings" controls.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11yMAS;#A11yTCS;#VisualStudioCode-Win32-Apr2021;#Visual Studio Code Client;#A11ySev2;#WCAG4.1.2;#Benchmark;#DesktopApp;#Win10;#NVDA;#JAWS;
Environment Details:
Visual Studio Code
Azure Function
Operating System: Windows 10 Pro 21H1
Steps to Reproduce:

Launch the Visual studio code.
TAB to on "Extension" button and search for "Azure Functions" and select it using ENTER key.
"Azure Function" screen should open.
Start NVDA and TAB to "Microsoft" control.
Observe the announcement for "Microsoft" control.

Actual:
The NVDA is only announcing "Clickable Microsoft" but it does not announce the control type for this "Microsoft" control.
Same issue is also observed with "Ratings" control.
This issue is also observed with JAWS.
Expected:
The NVDA should announce the appropriate control type for "Microsoft" and "Ratings" controls.
User Impact:
Screen reader users won't be able to know control type of "Microsoft" and "Ratings" controls.

@12-shweta what control type are you suggesting that "Microsoft" and "Ratings" should be?

For "Microsoft", control type should be button and for "Rating", it should be link as after clicking we got redirected to web browser.

@12-shweta this makes good sense, thank you for your suggestion. I have pushed a fix.

Verified the bug in the VS code Insiders.
Issue is fixed and now the NVDA announces control type for the controls.
But for the "Microsoft" control it also announces "Microsoft button publisher name"

@isidorn
Logged an external bug for the unnecessary announcement of "Publisher Name" while navigating the "Microsoft" button
microsoft/vscode#134262

Ok, thanks! I will comment on that one.

Github Tags:#Closed;


Add support for new --show-percentiles arg to get more granular percentiles instead of just median to all commands

Follow up to #40.
This PR chooses a hard-coded set of percentiles 10, 25, 50 (median), 75, 90, previously discussed with @oandregal. This is also what is commonly used for HTTP Archive queries by that team, and we have also used that set of percentiles in our own HTTP Archive queries (e.g. this one).
In the future we can maybe make the concrete percentiles controllable by the argument, but that doesn't seem necessary at this point. The above percentiles are a good baseline to get a more representative impression of the overall accuracy of the values.
Testing this PR

Run each of the 4 commands prior to this change (for any URL / any WebPageTest result).
Switch to this PR branch.
Run the same commands as above again.

For the wpt-* commands, make sure the median results are the same.
For the benchmark-* commands, make sure the median results are roughly similar (they won't be the same because it's different runs).

Run the same commands again, but now include the --show-percentiles flag in each one.

For the wpt-* commands, make sure the p50 results are the same as the previous median results.
For the benchmark-* commands, make sure the p50 results are roughly similar to the previous median results (they won't be the same because it's different runs).
For any command, do a quick sanity check on whether percentile values look right, e.g. if you use 8 runs for your command, the p25 value should be the value of the 2nd lowest run result, or if you use 10 runs, the p90 value should be the 9th lowest / 2nd highest run result. This sanity check can be done for any of the commands, since the underlying percentile calculation logic is the same in all of them.

@felixarntz code is good for me, and I've functionally tested and all of the commands and percentile/non percentile applications work as expected.
So really just looking for feedback on whether we need to alter --output to be inline with the --format usage as it is for the wpt-metrics and wpt-server-timing commands.
This applies to the benchmark-server-timing and benchmark-web-vitals commands.
Aside from that, good to go from my end thank you!

@mukeshpanchal27 Could you give this a review some time this week?


[Serious] Graphql api draft option not working for unpublished documents

Bug Report
I found our draft articles and unpublished articles are shown in prod env.
Steps to Reproduce

Open pages list in demo site and publish the first article

Publish the second article and then unpublish it directly

Open the graphql-playground:
https://demo.payloadcms.com/api/graphql-playground

Input this query and execute:
# Write your query or mutation here
query getPages {
  Pages(draft: false) {
    docs {
      slug
      _status
      updatedAt
    }
  }
}

Other Details

Your understanding in your second comment is correct - the draft: true argument replaces any docs in your main collection with their newest drafts, which would be stored in the _versions collection.
We do have docs about this - take a look here:
https://payloadcms.com/docs/versions/drafts#controlling-who-can-see-collection-drafts
Basically, the draft argument alone does not restrict who can see drafts. If you need that, you need to do that with access control. The draft arg simply does what is stated above.
Does that make sense? I will convert this to a discussion as I don't believe there's anything actionable to be done here. What do you think?