- (minus) is failing parser, including parsing negative number literals

Recently i have updated to:
    "eslint": "^8.2.0",
    "eslint-plugin-jsdoc": "^37.0.3",
    "@typescript-eslint/eslint-plugin": "^5.4.0",
    "@typescript-eslint/parser": "^5.4.0",

Several previously valid types started to fail, including the ones with -1 as a value for param, property or return.
Below is the list of failing and passing case. No workaround found.

Errors:
@param {-1} negativeOne
@param {(-1)} negativeOneInParens
@param {-Infinity} negativeInfinity
@param {null|-1} doesNotHaveToBeFirst
@returns {(-1|0|1)} comparatorUnion

@property {-1} alsoFails

@typedef {-1} alsoFails

Passes:
@param {'-1'} becauseThisIsString
@param {1} one
@param {42} fortyTwo
@param {Infinity} infinity
@param {NaN} nan
@returns {(0|1|2)} positiveUselessUnion

@typedef {1} perfectlyFine

Sure, there are two workarounds, but they involve bypassing parser completely:
const MINUS_ONE = -1; // eslint-disable-line no-unused-vars
/**
 * @typedef {typeof MINUS_ONE | 0 | 1} ComparatorReturn
 */

or just use typedef import from d.ts

@c69-addepar thanks for the report! I will look into this and other issues over the next weeks.

:tada: This issue has been resolved in version 2.0.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


fmw_jdk --> uninitialized constant Chef::Resource::FmwJdkJdkLinuxRpm

Hey guys,
I've tried this with both custom and pre-built vagrant boxes (CentOS, RHEL 6) and with each I get this error with the fmw_jdk cookbook.  I have logged into the box and confirmed that the jdk package does indeed exist in the directory it's looking for.  Don't see anyone else having the issue so I'd hate to call it a bug but I can't seem to get around it.
kitchen.yml and system info below
Error:
   NameError
   ---------
   uninitialized constant Chef::Resource::FmwJdkJdkLinuxRpm

   Cookbook Trace:
   ---------------
     /tmp/kitchen/cache/cookbooks/fmw_jdk/resources/jdk_linux_rpm.rb:22:in `block in class_from_file'
     /tmp/kitchen/cache/cookbooks/fmw_jdk/recipes/install.rb:71:in `block in from_file'
     /tmp/kitchen/cache/cookbooks/fmw_jdk/recipes/install.rb:68:in `from_file'

   Relevant File Content:
   ----------------------
   /tmp/kitchen/cache/cookbooks/fmw_jdk/resources/jdk_linux_rpm.rb:

    15:  default_action :install
    16:
    17:  # Java home folder, this is the folder where the jdk will be installed
    18:  attribute :java_home_dir, kind_of: String, required: true, name_attribute: true
    19:  # Linux JDK source file, it should be a file with .rpm as extension.
    20:  attribute :source_file,   kind_of: String, required: true, callbacks:
    21:            {
    22>>             'source should have a valid JDK extension' => ->(extensions) { Chef::Resource::FmwJdkJdkLinuxRpm.validate_source_file(extensions) }
    23:            }
    24:
    25:  state_attrs :java_home_dir
    26:
    27:  attr_accessor :exists
    28:
    29:  VALID_JDK_EXTENSIONS =
    30:    ['.rpm']
    31:

.kitchen.yml
driver:
  name: vagrant
  provider: virtualbox

provisioner:
  name: chef_solo

platforms:
  - name: centos-6.7
    driver_config:
      customize:
        memory: 2048
        cpus: 1
      synced_folders:
         - ["/data01/software", "/software"]

suites:
  - name: rpm
    run_list:
      - recipe[fmw_jdk::install]
      - recipe[fmw_jdk::rng_service]
    attributes:
      fmw:
        java_home_dir:    "/usr/java/jdk1.7.0_79"
      fmw_jdk:
        source_file:      "/software/jdk-7u79-linux-x64.rpm"
    excludes:
      - debian-7.2.0
      - windows-2012r2
      - windows-8.1
      - solaris-11.2
      - solaris-10

System Info:
Kitchen=1.15.0
Vagrant=1.9.3
VirtualBox=5.1.20r114628
chef_version=13.0.118
platform=centos
platform_version=6.7
ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
program_name=chef-solo

Hi,
thanks for reporting.
I guess it is because of chef 13 ( this is an auto install  with kitchen),  Probably I need to change this to  version 12 or 11.
This is developed & tested for chef 11  & 12. So there are probably some breaking changes. I don't know if I can make it work for all chef versions. Maybe I need to release a separate 13 version.
thanks Edwin

That was it.  Added the below line to my .kitchen.yml (to restrict it to the latest 12.x), and it ran successfully this time.  Thanks for the quick response Edwin (and for your work on this).  Much appreciated.
provisioner:
  name: chef_solo
  require_chef_omnibus: 12

good to know this. There is still some work to do.

So I started the work on chef 13 ( started on fmw_jdk ) ,that works but I had to remove the support for chef 11.

Works great!  Just tested it on 13.  Thanks Edwin.


Template: Magazine Article - Related Articles

Business Value
As a content author, I want to add a 'Related Articles' component to individual articles, improving user retention and engagement by offering relevant content suggestions, increasing page views, and enhancing overall user experience.
Description
A block that shows 3 articles related to the current one will be developed to be used in the #211 - Template: Magazine Article.

Acceptance Criteria

[ ] The block follows the design shown on Magazine Article - Figma.
[ ] The block can be added to the #211 - Template: Magazine Article.

Kamino cloned this issue to hlxsites/vg-volvotrucks-us


utils: copy static libraries for Android SDK

Update the SDK deployment to include the static libraries as well. This is primarily needed for the C++ interop libraries.

@swift-ci please smoke test


Pydot considers dotted strings like "1.4.0" to be numeric

@pktpls wrote:

Have had the same problem with version numbers in node properties, which end up as e.g. ipkVersion=1.4.0, while they should actually be wrapped in quotes

Ooh, that's a different problem. The regular expression used to detect numeric values accepts periods (because, decimal points), but really it should only accept a SINGLE period at most. We'll have to change that from
re_all_numeric = re.compile(r"^[0-9\.]+$")

to something like...
re_all_numeric = re.compile(r"^([0-9]+\.?[0-9]*|[0-9]*\.[0-9]+)$")

Originally posted by @ferdnyc in https://github.com/pydot/pydot/issues/178#issuecomment-2504157116

Nice, thanks a lot :-)


RegExp and capture group in host entry, usable to target headless services

I've been redirected here coming from this issue.
I have some StatefulSet that is accessible through a headless service. Then I want to target each specific instance of that service (clients would know what service from a redirect request). That service would have N instances at any given time.
It's something like this:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: myservice
  namespace: somens
spec:
  rules:
  - host: ~^baseaddr-(?<srv_host>\d+)\.example\.com$
    http:
      paths:
      - backend:
          serviceName: myservice-$srv_host.myservice.somens
          servicePort: 80

I ended up just changing the nginx-template and added hard-coded server entries for all my cases, but it feels quite hacky. And it only works with nginx, ofc.
So I'm here to present this use-case for your analysis.

/kind user-story

Ingress v1 spec removes validation of paths to support different regex engines and to support the use-case mentioned in this issue: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190125-ingress-api-group.md#path-as-a-prefix
cc @robscott

xref https://github.com/kubernetes/kubernetes/issues/41881

/remove-lifecycle stale
Removing stale for now. I wonder whether it might be better to address this use case with some sort of controller that automatically generates routes from a service selector, rather than opening the regex can of worms ...

/remove-lifecycle stale

/assign @jpeach

This issue was raised in the WG office hours and there were concerns about the regex compatibility across different implementations and whether different proxies would be able to implement this.
I agree with the comment from rkatz that this could be implemented with a custom controller that creates gateways or ingresses based on mapping existing services.
Another approach could be adding a custom route type (which is probably a similar approach to the the controller in practice) to do the hostname expansion. In this case, though, I don't see a reasonable way to add the route type without integrating it into a specific ingress controller implementation.

This issue was raised in the WG office hours and there were concerns about the regex compatibility across different implementations and whether different proxies would be able to implement this.

The consensus for this discussion was to (for now) add validation to make using a regex here invalid.

@jpeach that's regretful. I would argue that any implementation that now does not implement sufficient regex compatibility should be forced to add it and this should be allowed. And I only argue that because the use case is quite valid and recurrent whenever we have traffic being routed to StatefulSets and said traffic is also stateful (or, at least, it must reach a specific pod and not any pod). I see operators like Kafka and the likes creating a service and then an ingress for each such pod, and that feels hacky to me.

I see operators like Kafka and the likes creating a service and then an ingress for each such pod, and that feels hacky to me.

You don't have to create an ingress for each pod. It's possible in service-api to have a single gateway that pulls in routes CRDs by label. The operators can create a route for each mapped hostname and the gateway selector will pull them in.
It's not as automagic as a regex-based solution, but it's arguably an improvement over what you can do with ingress.

This is a valid uncommon use-case and it is quite difficult to incorporate it into the current API in a way that would be supported by multiple implementations (an important goal for this project).
There are two options:

Use extension points in the API to implement this functionality. We have added extension points throughout the API to support such use-cases which although being valid, are not common.
Work with implementers of this API to introduce this feature in a specific implementation

For now, I'm going to go ahead and close this issue. If anyone comes across a better solution for the problem here, please feel free to re-open the issue to continue the discussion further.
/close

This is a valid uncommon use-case and it is quite difficult to incorporate it into the current API in a way that would be supported by multiple implementations (an important goal for this project).
There are two options:

Use extension points in the API to implement this functionality. We have added extension points throughout the API to support such use-cases which although being valid, are not common.
Work with implementers of this API to introduce this feature in a specific implementation

For now, I'm going to go ahead and close this issue. If anyone comes across a better solution for the problem here, please feel free to re-open the issue to continue the discussion further.
/close


[Do not merge] Try out Github Actions

The Docker test is passing, should we add test.py just as part of the python test action?


Update mm-google-step6-migrate-monitor.md

Stressed the idea Migration will not delete content on at Google Workspace

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Plot Legend list arrows are broken

Wave SDK Version, OS
Mac, wave 22
Actual behavior
When there is a plot with legend and too many line plots, the legend allows for scrolling (yellow arrows).
These arrows work one way (next), but no the other way (previous) so once you scroll to last portion of legend, you cannot get back to the first portion of it

Steps To Reproduce
Create plot with many Line plots
from h2o_wave import main, app, Q, ui, data

@app('/')
async def serve(q: Q):
    rows = [
        [0, "plot_label_1", 0],
        [0, "plot_label_2", 10],
        [0, "plot_label_3", 20],
        [100, "plot_label_1", 0],
        [100, "plot_label_2", 10],
        [100, "plot_label_3", 20],
        [0, "plot_label_4", 40],
        [0, "plot_label_5", 50],
        [0, "plot_label_6", 60],
        [100, "plot_label_4", 40],
        [100, "plot_label_5", 50],
        [100, "plot_label_6", 60],
    ]
    d = data(fields=["step", "type", "val"], rows=rows, pack=True)

    viz = ui.visualization(
        plot=ui.plot(
            [
                ui.mark(
                    type="line",
                    x_title="step",
                    x_scale="linear",
                    y_scale="linear",
                    x="=step",
                    y="=val",
                    color="=type",
                )
            ]
        ),
        data=d,
        interactions=["brush"],
        height="calc((100vh - 275px)*0.42)",
        width="560px",
    )

    q.page["charts"] = ui.form_card(box='1 1 20 20', items=[viz])

    await q.page.save()

This is a bug in the underlying plotting library, tracked in https://github.com/antvis/G2/issues/2549.
Reasoning: G2 lib supports 2 types of renderers - canvas and SVG. Wave uses SVG to leverage the power of CSS variables for theming. Unfortunately, the legend pagination is broken for this type of renderer.


Black Screen until interaction

https://stackblitz.com/edit/sveltekit-hegre9?file=src/routes/index.svelte
I'm not entirely certain but I believe this is not rendering the texture after it loads but rather waiting on a change to show the mesh.

i clicked your link and it seemed to load just fine.

On windows, both chrome and edge show me a black screen until after I interact with it.

It stays this way for me until I drag, still appears to be the case though.

I do confirm this happens on every browser I tested under macOS. One way to reliably test it is to disable cache and add some throttling.
It seems to render it without the texture (black) and once it is loaded it does not re-render the scene, unless a render is forced when a variable changes, interacting with it or just resizing the browser.
This seems to be related to the "no re-render until specified" nature of svelte-cubed, however I think when a texture is loaded it should call a frame render.


Add quick "Add" buttons

Users have reported confusion in creating offers and requests for help. Lets add some fast action buttons in a prominent place, e.g. top of the page or on a home page

Offer Help - opens a popup to create an offer to help
Request Help - opens a popup to pick a person who needs help and to add the details of what they need (i.e. a need request where you pick the person in the popup)

Completed


Pod installation gets too much of time and nothing happened

Summary
I followed the given instructions on the page
After completing the given instructions, I execute the pod installs and it gets too much time. already it took 2 hours. Still nothing happened.
Reproducible sample code
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '13.0'
install! 'cocoapods', :deterministic_uuids => false

target 'example' do

  config = use_native_modules!

  # Flags change depending on the env values.
  pod 'react-native-config/Extension', :path => '../node_modules/react-native-config'
  pod 'Firebase', :modular_headers => true
  pod 'FirebaseCoreInternal', :modular_headers => true
  pod 'GoogleUtilities', :modular_headers => true
  pod 'FirebaseCore', :modular_headers => true
  pod 'react-native-blob-util',
    :path => '../node_modules/react-native-blob-util'

  flags = get_default_flags()

  use_react_native!(
    :path => config[:reactNativePath],
    # Hermes is now enabled by default. Disable by setting this flag to false.
    # Upcoming versions of React Native may rely on get_default_flags(), but
    # we make it explicit here to aid in the React Native upgrade process.
    :hermes_enabled => true,
    :fabric_enabled => flags[:fabric_enabled],
    # Enables Flipper.
    #
    # Note that if you have use_frameworks! enabled, Flipper will not work and
    # you should disable the next line.
    :flipper_configuration => FlipperConfiguration.enabled,
    # An absolute path to your application root.
    :app_path => "#{Pod::Config.instance.installation_root}/.."
  )

  permissions_path = '../node_modules/react-native-permissions/ios'
    pod 'Permission-Camera', :path => "#{permissions_path}/Camera/Permission-Camera.podspec"

    pod 'Google-Maps-iOS-Utils', :git => 'https://github.com/Simon-TechForm/google-maps-ios-utils.git', :branch => 'feat/support-apple-silicon'

    rn_maps_path = '../node_modules/react-native-maps'
    pod 'react-native-google-maps', :path => rn_maps_path

  target 'exampleTests' do
    inherit! :complete
    # Pods for testing
  end

  post_install do |installer|
    react_native_post_install(
      installer,
      # Set `mac_catalyst_enabled` to `true` in order to apply patches
      # necessary for Mac Catalyst builds
      :mac_catalyst_enabled => false
    )
    __apply_Xcode_12_5_M1_post_install_workaround(installer)
    installer.pods_project.targets.each do |target|
      if target.respond_to?(:product_type) and target.product_type == "com.apple.product-type.bundle"
        target.build_configurations.each do |config|
            config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
        end
      end
    end
  end
end

Steps to reproduce
Follow the instructions given in the installation instruction page
Expected result
Pre-downloading: Google-Maps-iOS-Utils from https://github.com/Simon-TechForm/google-maps-ios-utils.git, branch feat/support-apple-silicon
/Users/lussi/example/node_modules/react-native-fbsdk-next/react-native-fbsdk-next.podspec:4: warning: already initialized constant Pod::FBSDKVersion
/Users/lussi/example/node_modules/react-native-fbsdk-next/react-native-fbsdk-next.podspec:4: warning: previous definition of FBSDKVersion was here
Actual result
pod installation should get success
React Native Maps Version
1.3.2
What platforms are you seeing the problem on?
iOS (Apple Maps)
React Native Version
0.70.6
What version of Expo are you using?
Not using Expo
Device(s)
All the iPhone devices.
Additional information
No response

same issue
Removed  "pod 'Google-Maps-iOS-Utils', :git => 'https://github.com/Simon-TechForm/google-maps-ios-utils.git', :branch => 'feat/support-apple-silicon'" and tried then it crashed.


Update CMake standard

So apparently leaphttp and leapipc depend on autowiring now. And Autowiring 1.0.3 had the bug of losing fat binary support.
So now we need to update to the latest leapmotion/standard for Autowiring 1.0.4 in order to get the other repos fixed (since they wouldn't be able to link with a non-fat binary autowiring even when they update to the latest leapmotion/standard).

[x] Updated leapmotion/standard/master

AutowiringTest works fine.


Show current narrow in page title

If a user has multiple browser tabs open to different narrows, there's no way to tell the tabs apart without manually switching to each tab in turn.  This could be fixed by describing the narrow in the page title.

(originally proposed by @meereeum)

I can try to tackle this one. What should the format of the new page title be?

I would propose <stream-name> - Zulip

(or other type of "narrowed" tab - essentially, the text following the last slash in the URL)

Yeah, that makes sense to me.

So currently we have title as e.g. "example.com - Zulip" where example.com is the name of the realm.
Including the realm domain in the title is good for the case where a user has accounts on multiple Zulip realms, which probably will be less the common case in the new everyone-runs-their-own-Zulip-server world, but is probably still something we should think about.  I'd probably favor a title that looks like:
 - example.com - Zulip
if that doesn't wind up being too verbose; if it does, maybe I'd only show the example.com in the case that it's a multi-realm server.
In terms of how to describe the narrow, you may want to look at the logic in static/js/tab_bar.js for how we display the describe for a narrow; it might make sense to reuse that logic for the title bar.

I'm thinking of also changing the tab title so that it only shows the number of new messages within that narrow. So if you were in a stream with 30 new messages, but you had 100 new messages in total, the tab title for that stream would show 30 rather than 100. Does that seem reasonable?

Hmm, I think that's something where different people might want different things; e.g. for folks who use a single pinned tab and sometimes leave the window narrowed, I think they'd be sad to have the count only show that narrow...
@wdaher do you think this is a place where an option makes sense?

(Also just edited my previous comment to not have some of the content missing due to GitHub formatting)

I like the idea of showing the narrow's name in the title bar, but I would strongly prefer to show the global unread count (not the narrowed count) in the title bar.
I'm not enthusiastic about making it a user-visible configuration option because more configuration = worse UX, and I take the opinionated stance that a bunch of individually open tabs narrowed to different streams is not the ideal way to use Zulip.
If I'm wrong, and lots of people want to use Zulip this way, I'm definitely open to revisiting this point, but I'd really love to see lots of folks chime in before we make this switch.

I can only speak to my own experience, but I tend to use Zulip by having one tab opened to the global stream, as well as additional tabs for particular streams I am following - so would personally enjoy having this option.

:+1: to showing the narrowed count.  (See also #158.)  My usage model: a pinned browser tab which is open to the global stream (checked irregularly), plus tabs for individual topics I want to watch more closely.  The current unread-count behavior seems unhelpful to me; e.g., it'd be surprising if your email program could only show the number of unread messages in your entire account, while you were looking at an individual folder.

Hm, ok. Sounds like we're all in agreement on the title text and are discussing the unread count, so let's move this discussion over to #158 for posterity's sake :)

The fix for this was merged via #244 a while ago!


Fc/feat/lvae3d

Description
TBU !!!

What: Clearly and concisely describe what changes you have made.
Why: Explain the reasoning behind these changes. What problem are you solving? Why is this change necessary?
How: Describe how you implemented these changes. Provide an overview of the approach and any important implementation details.

Changes Made

Added: List new features or files added.
Modified: Describe existing features or files modified.
Removed: Detail features or files that were removed.

Related Issues
Link to any related issues or discussions. Use keywords like "Fixes", "Resolves", or "Closes" to link to issues automatically.

Fixes #
Resolves #
Closes #

Breaking changes
Describe any breaking change.
Additional Notes and Examples
Include any additional notes or context that reviewers should be aware of, including snippets of code illustrating your new feature.

Please ensure your PR meets the following requirements:

[ ] Code builds and passes tests locally, including doctests
[ ] New tests have been added (for bug fixes/features)
[ ] Pre-commit passes
[ ] PR to the documentation exists (for bug fixes / features)

Can you update the description? Impossible to review otherwise. :)

@federico-carrara Thanks for the review, updates some things, some were already fixed after you reviewed. I have a couple of questions though. Could you please take a look again


libpostal: 1.0.0 -> 1.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libpostal/versions.
meta.description for libpostal is: "A C library for parsing/normalizing street addresses around the world. Powered by statistical NLP and open geo data"
meta.homepage for libpostal is: "https://github.com/openvenues/libpostal"
meta.changelog for libpostal is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.1 with grep in /nix/store/04lkpzxad9qg1pkdmx4prhghwg5p28s5-libpostal-1.1

directory tree listing: https://gist.github.com/7a723dd0ebc314871fc06eb82cd3644e

du listing: https://gist.github.com/66a05d9492e50c22acd5d45dd358670e

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
libpostal
osmscout-server

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/04lkpzxad9qg1pkdmx4prhghwg5p28s5-libpostal-1.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libpostal https://github.com/r-ryantm/nixpkgs/archive/b2031fbfb20f3e62123d548b5794bf2cdcab381a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/04lkpzxad9qg1pkdmx4prhghwg5p28s5-libpostal-1.1
ls -la /nix/store/04lkpzxad9qg1pkdmx4prhghwg5p28s5-libpostal-1.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

libpostal
osmscout-server

Maintainer pings
cc @Thra11 for testing.

Result of nixpkgs-review pr 116014 at b2031fbf run on aarch64-linux 1

1 package skipped due to time constraints:

osmscout-server

1 package built successfully:

libpostal


Do research on Google Maps / Places API

As in requirements, we should use Google Maps API for location related properties in our application. There're many APIs inside Maps API, but I think the one related to our use case is Places. There're both client (Android, JS) and server-side libraries for Places API. https://developers.google.com/maps/documentation/ All three teams should discuss how are we going to integrate Places API in our application.
P.S. We can clarify which API we're supposed to use with Meriç as well.

As backend team, we're expecting frontend and Android teams to send us city and disctrict information of the event location so that we can enable users to filter events based on location. (il ve ilçe) #88
In addition to this, you should decide how user will select the location of event on UI. (For referance, you might use something like this.)
I think Google Places API is suitable for our situation if event locations will be specific places. (For example, you can select a theater, cafe or any specific venue easily with Google Places API and then it'll have a unique ID provided by Google. We can store the name of the place and ID in our database. However, if you believe that events can be at any location --which seems weird to me-- Google Places API won't be enough.)

@atifemreyuksel Could you examine some example usages of Google API for our system?

Okay, I will search some examples for frontend.

As backend team, we expect frontend and android teams to come up with a common data fields. If you are planning to use Google API, it should be trivial.

We already use places api in showing event page. Also, we can use reverse geocoding api in google in create event. Hence, we can take the latitude and longitude of the event place with marker. Then, we convert it to related address. Is it useful for backend?

For location model, we now have city, disctrict, google_place_id, name, lat, lng fields. Android team should also use these fields for location-related things for events.
Special thanks to @atifemreyuksel, for his guidance about this issue.


Test to validate that duplicate egress rule overrides default

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/1604
Description of changes:
New test test_create_with_vpc_egress_dups_default_delete should validate whether or not an egress rule that duplicates the default egress rule (allowing all traffic) is created correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Looks good now. I like the stuff with the markers, very interesting way to make dynamic fixtures.
/lgtm


Draw edge to nested node from other hierarchy level

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[] Other... Please describe:

Is there a way to draw edges to nested nodes as in the elk docs?
Current behavior
Providing the nested node as edge target does not work - the edge will not show.
Expected behavior
Would be best to just provide the id of the node and edges are automatically also drawn towards nested elements.
Example
nodes={[
  {
    id: '1',
    text: '1'
  },
  {
    id: '2',
    text: '2'
  },
  {
    id: '2.1',
    text: '2.1',
    parent: '2'
  },
  {
    id: '3',
    text: '3'
  }
]}
edges={[
  {
    id: '1-2',
    from: '1',
    to: '2.1'
  },
  {
    id: '2-3',
    from: '2',
    to: '3'
  }
]}

What is the motivation / use case for changing the behavior?
I would like to display nested nodes within one node and nodes from the "outside" should directly impact these nested nodes. Therefore, I need to display a direct edge towards the nested nodes.
Since we provide a parents (and no children) property, maybe we should resolve this by using the id of the nested node directly. ELKs approach is to traverse by the parents until the child is reached like edge source -> outside.inside.n1, but i think their approach is not feasible for us, no?
@amcdnl could you share some thoughts on this? If you think this is a good "first ticket", i will try to implement it.

Oh interesting - I've never thought about this use case until now.
Absolutely - if you would like to tackle this I'd welcome the change - fair warning though its going to be a little tricky. Here is some code spots that might help you get started:

Layout: https://github.com/reaviz/reaflow/blob/master/src/layout/elkLayout.ts
Top Level Edge Render: https://github.com/reaviz/reaflow/blob/master/src/Canvas.tsx#L347
Child Level Edge Render: https://github.com/reaviz/reaflow/blob/master/src/symbols/Node/Node.tsx#L362

I'm not entirely sure how this implementation would work off the top of my head. Its possible it could "just" work w/ a few layout tweaks but I'm not sure.
I've never seen those ELK Doc demos - that would have been so helpful as I was mostly guessing attributes for the longest time! LOL

Cool, thanks for giving me some spots to start on. I will give it a try.

I've never seen those ELK Doc demos - that would have been so helpful as I was mostly guessing attributes for the longest time! LOL

Haha, glad to share them with you! While evaluating ELK for my project, I discovered your Repo :)

After some debugging i found out, that the start and endpoint of the edge are not calculated, so i did some research at elk.
I figured out in another issue, that to achieve the desired behaviour we can just pass 'elk.hierarchyHandling': 'INCLUDE_CHILDREN' into the layoutOptions of a Canvas.
Maybe we should include an example with this prop in the stories.
Example:
The layout is not yet perfect. The edge into the nested edge has a unnecessary bezier turn instead of going directly into the node, but better than nothing for now.

<Canvas       layoutOptions={         {           'elk.hierarchyHandling': 'INCLUDE_CHILDREN'         }       }       nodes={[         {           id: '1',           text: '1'         },         {           id: '2',         },         {           id: '2.1',           parent: '2',           text: '2.1'         },         {           id: '3',           text: '3'         }       ]}       edges={[         {           id: '1-2.1',           from: '1',           to: '2.1'         },         {           id: '1-3',           from: '1',           to: '3',         }       ]}     />

This is nice - can you add a storybook story for it?

Will do 👍
btw, just figured out that the edge is still "behind" the node. I styled the node to have some opacity to visualize the problem. If opacity is 100%, the tip of the edge is not shown at all because of the fill of the node. Using the z-index did not help unfortunately.

Sigh - yes there is no zindex in SVGs. They are rendered in order of dom position. If you make a storybook story w/ the example, I can try and tweak it and see if I can make it layer correctly by re-arranging some of the dom.
In the past I've done this link type thing but its not great cuz it duplicates the elements. https://github.com/reaviz/reaviz/blob/master/src/VennDiagram/VennSeries.tsx#L205-L212

PS: It would be great to have a example of what you built there in the stories for testing and docs.

Sure, i can do that. Do you mean like the exact example i posted above? Because I am using some material-ui components, which we need to integrate into the project then.

I noticed this issue is not as simple as it initially looked like.
Following issues arised:

Already elaborated the issue with hidden tips of the edge behind nodes
The additional bezier turn in the edge towards a nested node does only occur for direction='DOWN' or direction='UP'.
Major issue for my use case:
Edges are rendered incorrectly if there are edges pointing into a nested node AND there are also edges within the nested node towards other nested nodes.
e.g. the badly rendered edge should be between 2.1 and 2.2

<Canvas     layoutOptions={       {         'elk.hierarchyHandling': 'INCLUDE_CHILDREN'       }     }     direction='RIGHT'     nodes={[       {         id: '1',         text: '1'       },       {         id: '2',       },       {         id: '2.1',         parent: '2',         text: '2.1'       },       {         id: '2.2',         parent: '2',         text: '2.2'       },       {         id: '3',         text: '3'       }     ]}     edges={[       {         id: '1-2.1',         from: '1',         to: '2.1'       },       {         id: '2.1-2.2',         from: '2.1',         to: '2.2'       },       {         id: '2.2-3',         from: '2.2',         to: '3'       },     ]}   />

@amcdnl maybe we should split these concerns into separate issues to handle them individually. As said, for me it is crucial to fix the last issue.

The Left-to-right layout needs some TLC w/ alignment of things. I think I have a issue for alignment but it doesn't call this out directly. We should make a ticket calling out the specific issues.
Ah good catch - I didn't even think about that. That was kind of a hack I took from react-flow and has some other issues too - there is a ticket for some alignment issues but we should make a separate ticket for this issue.
In your example, I think you need to include the parent on that edge.

@amcdnl thank you so much! 🎉  I did not notice so far, that edges have a parent property as well.
So I will extract the other two problems into separate issues and create a storybook story for my example from above - then we can close this issue.

Created these issues: #31 #32


fix: SetOrClear implementation

Overview
By default the SetNillable* functions are not setting updating the field if the value is nil.
In case of optional fields we should rather clear (set to null) the field.
This helper allows us to implement this logic.
Source: https://github.com/ent/ent/issues/1119

Gosh, I suppose we didn't notice before as most entities are immutable once created... Thanks 👍

Thanks, but the credit goes to @hekike, I was just the hand executing the change (he encountered this issue with the Customer implementation).


Include handler for payment_pointer.web_montization webhook event in Mock ASE

Context
The Mock ASE currently does not handle payment_pointer.web_monetization webhook events. Since it should also serve as a reference for actual integrators, all webhook events should be handled.
Note: As of the creation of this issue, it is still called payment_pointer. However, we are in the process of changing this to wallet_address.
Todos

[ ] include handler here
[ ] handle event case here

Hi @manulpatel , it's yours 🙂

Hey team, @sabineschaller @manulpatel,
Can I take this one, if this issue is still open?

Currently the docs indicate calling the WithdrawEventLiquidity endpoint in this webhook handler. However, this handler is being deprecated and the new WithdrawOutgoingPaymentLiquidity resolver should be used instead.
Currently this webhook never fires. We might be able to manually test by doing:

changing walletAddressService.create to do something like this: https://github.com/interledger/rafiki/commit/70a03ad05bb2798f42b2b24cde654848db348b6c
create a new wallet address via postman
call triggerWalletAddressEvents via postman which should trigger handleWalletAddressWebMonetization


The ios-deploy fails on step ios-deploy-tests

Builder ios-deploy hasn't been run over the past year. Now it complains:
*** If you believe this error represents a bug, please attach the result bundle at /Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-ghmaxqjqzwrddrcdlyhaingvldnr/Logs/Test/Test-ios-deploy-tests-2022.07.28_10-37-23--0700.xcresult

2022-07-28 10:37:29.794 xcodebuild[40408:854322]  IDETestOperationsObserverDebug: Failure collecting logarchive: Error Domain=NSCocoaErrorDomain Code=4099 "The connection to service named com.apple.testmanagerd.control was invalidated: failed at lookup with error 3 - No such process." UserInfo={NSDebugDescription=The connection to service named com.apple.testmanagerd.control was invalidated: failed at lookup with error 3 - No such process.}
2022-07-28 10:37:29.795 xcodebuild[40408:854248] [MT] IDETestOperationsObserverDebug: 0.023 elapsed -- Testing started completed.
2022-07-28 10:37:29.795 xcodebuild[40408:854248] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2022-07-28 10:37:29.795 xcodebuild[40408:854248] [MT] IDETestOperationsObserverDebug: 0.023 sec, +0.023 sec -- end

Test session results, code coverage, and logs:
	/Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-ghmaxqjqzwrddrcdlyhaingvldnr/Logs/Test/Test-ios-deploy-tests-2022.07.28_10-37-23--0700.xcresult

Testing failed:
	ios-deploy-tests:
		The test runner encountered an error (Failed to establish communication with the test runner. If you believe this error represents a bug, please attach the result bundle at /Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-ghmaxqjqzwrddrcdlyhaingvldnr/Logs/Test/Test-ios-deploy-tests-2022.07.28_10-37-23--0700.xcresult. (Underlying Error: Couldn’t communicate with a helper application. Try your operation again. If that fails, quit and relaunch the application and try again. The connection to service named com.apple.testmanagerd.control was invalidated: failed at lookup with error 3 - No such process.))

** TEST FAILED **

Example build: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/ee6bd5e65a8f527ca2f91db97f223735186664dfa6e9513335cd66dd54dbb82e/+/build.proto?server=chromium-swarm.appspot.com
@christopherfujino could you help take a look?
Related: https://github.com/flutter/flutter/issues/36019

looking

Looks like it's the same error as https://github.com/flutter/flutter/issues/101721, so I don't think it's specifically related to this builder? Interestingly, on that issue it was believed to be arm related, however this build ran on intel. cc @jmagman

I can't really pick out exactly what failed, there's
rsync: delete_file: rmdir "/opt/s/w/ir/x/w/src/_Frameworks/MobileDevice.framework" failed: Directory not empty (66)
rsync error: some files could not be transferred (code 23) at /System/Volumes/Data/SWE/macOS/BuildRoots/b8ff8433dc/Library/Caches/com.apple.xbs/Sources/rsync/rsync-55/rsync/main.c(996) [sender=2.6.9]

but that could be stray logging and not fatal.
@keyonghan  Can we get the xcresult directory it says has all the logging?
Test session results, code coverage, and logs:
	/Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-ghmaxqjqzwrddrcdlyhaingvldnr/Logs/Test/Test-ios-deploy-tests-2022.07.28_10-37-23--0700.xcresult

Not sure it will have everything we need since it says Failure collecting logarchive.

A new example build: https://ci.chromium.org/swarming/task/5c74113ddfb78810?server=chromium-swarm.appspot.com, with logs appended.
Test-ios-deploy-tests-2022.08.01_14-11-54--0700.xcresult.zip

Unfortunately that xcresult bundle just says

The test runner encountered an error (Failed to establish communication with the test runner. If you believe this error represents a bug, please attach the result bundle at /Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-ghmaxqjqzwrddrcdlyhaingvldnr/Logs/Test/Test-ios-deploy-tests-2022.08.01_14-11-54--0700.xcresult. (Underlying Error: Couldn’t communicate with a helper application. Try your operation again. If that fails, quit and relaunch the application and try again. The connection to service named com.apple.testmanagerd.control was invalidated: failed at lookup with error 3 - No such process.))

We keep seeing versions of this https://github.com/flutter/flutter/issues/100639 https://github.com/flutter/flutter/issues/101721, it seems to be related to how we are running these tests.
I see SO question https://stackoverflow.com/questions/67688130/run-macos-test-cases-on-the-jenkins-pipeline
We started digging into this in https://github.com/flutter/flutter/issues/101721#issuecomment-1117643193

Where are we running tests over SSH?

Maybe that wasn't the right way to put it, I thought these tests weren't running with the window server running (a user actually logged into the GUI)? It's one of the reasons we think the Safari tests won't launch on newer versions of Xcode.

Tried running the test locally on mac11:

checkout ios-deploy
xcodebuild -configuration Release SYMROOT=build -arch x86_64

Hit

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

And did sudo xcode-select -s /opt/flutter/xcode/13f17a/XCode.app/Contents/Developer to workaround

xcodebuild test -scheme ios-deploy-tests -configuration Release SYMROOT=build -arch x86_64

I am hitting the same error: test.log

I can't tell what failed, unfortunately, can you upload the bundle it logs like /Users/swarming/Library/Developer/Xcode/DerivedData/ios-deploy-gohpowxwnhiuvffwdnjfdhryzpde/Logs/Test/Test-ios-deploy-tests-2022.08.04_16-19-40--0700.xcresult

Here it is: Test-ios-deploy-tests-2022.08.04_16-19-40--0700.xcresult.zip

Grrr yeah same thing.
Are you seeing the same thing if you open the project in Xcode and run the tests there (Product -> Test).

Grrr yeah same thing. Are you seeing the same thing if you open the project in Xcode and run the tests there (Product -> Test)?

Validated running from xcode succeeded.

I'm not sure what's going on with Xcode here, but stepping back, do we need to run ios-deploy-tests?

I'm not sure what's going on with Xcode here, but stepping back, do we need to run ios-deploy-tests?

The ultimate test would be devicelab ios tests, I'm ok with skipping these XCtests.

Cool. I will skip ios-deploy-tests for now.


silencing share gist info message on quietSync

Short description of what this resolves:
Prevents cmd.updateSettings.info.shareGist from showing as a vscode information message during auto upload when quietSync is enabled.
Changes proposed in this pull request:

Adds condition to if statement that displays message requiring quietSync to be false to display.
Only effects the information message statement. No other code lines would be effected.

Fixes: #1033
How Has This Been Tested?

I have not been able to test this personally. I am having trouble running the extension in the debugger so I have not verified operation. Hoping to elicit some help on Slack or here to consider this done since I'm thinking the solution takes priority over my education. :)
Screenshots (if appropriate):
N/A
Checklist:

[x] I have read the contribution guidelines.
[ ] My change requires a change to the documentation and GitHub Wiki.
[ ] I have updated the documentation and Wiki accordingly.

Adds condition to if statement that displays message requiring quietSync to be false to display.

Thank you for the PR, but this dialog has nothing to do with quietSync.
The intend to show this dialog is only on upload, when the user selects Share Settings with Public Gist from Sync : Advance Settings and choose to upload the settings into new gist. This dialog shouldn't show on normal upload process.
It would be great if you can debug the code of Share Settings with Public Gist and see what parameters it is sending for the upload.

I have fixed it in the commit https://github.com/shanalikhan/code-settings-sync/commit/e150b2d788f97ca78a73e26aae4652f0583450eb
Can you verify if it's working for you by installing the attached package of extension? (that is scheduled for upcoming release)
code-settings-sync-3.4.3.zip

VERIFIED! It does not show the prompt.
Steps I took:

Made a settings change
Verified status bar showed change and prompted upload in 20 seconds.
Waited 20 seconds ;)
Verified status bar showed uploading took place.
Verified no info box loaded up.

Thank you very much!

I have marked it as fixed and scheduled for next release. Meanwhile if you find the error in the above feel free to report :)


Issue #49 - fix long cable read delay on DHT sensor with RPI 1

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

Describe the scope of your change--i.e. what the change does and what parts
of the code were modified.  This will help us understand any risks of integrating
the code.

Describe any known limitations with your change.  For example if the change
doesn't apply to a supported platform of the library please mention it.

Please run any tests or examples that can exercise your modified code.  We
strive to not break users of the code and running tests/examples helps with this
process.

Thank you again for contributing!  We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request.  There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request.  Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.

verified by multiple users in real world tests:
https://github.com/adafruit/Adafruit-Raspberry-Pi-Python-Code/issues/49


add .gitignore

this is just the stuff that was clearly wrong :) try to search for templates or use mine :) https://github.com/JLarky/react-lazily/blob/main/.gitignore

Done in https://github.com/fabiospampinato/flimsy/commit/f6ccca86e32d6cf419c2641d376c1560db6b1d4b, thanks.


IPAddress filter condition

Hello,
I am not understanding how to properly add IpAddess or IpNetwork conditions to a filter. Here is what I have tried, but I get
error C2664: 'wfp::conditions::ConditionIp::ConditionIp(const wfp::conditions::ConditionIp &)': cannot convert argument 1 from '_Ty' to 'const wfp::conditions::ConditionIp &'
1>        with
1>        [
1>            _Ty=std::unique_ptr<wfp::conditions::ConditionIp,std::default_delete<wfp::conditions::ConditionIp>>
1>        ]

                const wfp::IpAddress ipaddr = wfp::IpAddress(L"<IP_ADDRESS>");
                const wfp::conditions::IStrictComparison& comparison = wfp::conditions::CompareEq();

                conditions.add_condition(
                    std::make_unique<wfp::conditions::ConditionIp>(wfp::conditions::ConditionIp::Remote(ipaddr, comparison)));

Is there an example I can reference?
Thank you.

// I incorrectly used it:

                conditions.add_condition(
                    wfp::conditions::ConditionIp::Remote(ipaddr, wfp::conditions::CompareEq()));
```

Additionally, most methods that are used to construct conditions will use CompareEq by default:
https://github.com/mullvad/libwfp/blob/697621037e84051e429a7f8d3c0e066d698ec9b2/src/libwfp/conditions/conditionip.h#L27
So you can emit that argument in calling code.


Make binarynode not negateable, less agressive rewrite

Binary Nodes can't be re-written without losing fidelity on original statement necessary for other runtimes (elasticsearch)
ie:
NOT (x > y)
# DOES NOT EQUAL
x <= y

Because missing field on left hand side

So why are the two expressions different NOT (x > y) and x <= y?
It seems that for either expression to actually evaluate with a "missing" x or y, the missing argument would need to be reified as the zero value.
Where does a semantic difference actually manifest?

The difference turns out that other VM's (elasticsearch) needs the full un-collapsed AST of the UrnaryNot{Binary{x>y}}  in order to evaluate correctly while qlbridge vm doesn't.
the ES looked like:
                  "bool": {
                    "filter": [
                      {
                        "range": {
                          "date_registration_dt": {
                            "gte": "1459206000000"
                          }
                        }
                      }
                    ]
                  }

vs
                        "bool": {
                          "must_not": {
                            "range": {
                              "date_registration_dt": {
                                "lt": "1459206000000"
                              }
                            }
                          }
                        }


Call FoloISPN2CassandraMigrationAction from REST

The folo migration breaks when the dat is big (23G on prod) and cluster will reboot indy if it takes too long. I change it to call from MaintenanceHandler directly via REST.

Cool, looks good for me.


Added NodeJS workflow

For GH actions, only on PRs to master for now
Please make sure the below checklist is followed for Pull Requests.

[ ] Travis tests are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[ ] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

@MathieuAA : nice job here. I'd like you have your opinion about GH actions. Do you plan to remove Travis ? Stay with GH actions only ? What about Azure Pipelines ?

@pascalgrimaud Hi! My short-term goal was to try it (check!), and remove the Travis checks but keep Azure pipelines for the time being.
What do you think?

I'd like you remove Travis for all our organization.
Then, use GH actions for repo where the CI is simple (npm install, build, test).
Azure should be use only when there is some generation + configs, so when the CI is complex
Thanks for adding this, it will help me to start understanding GH actions :)

I'll try. Gotta do a major release today for JCore and update the docs before I'll be able to play with actions a bit more.

So I can remove the Azure check here too then?

Let's wait a little bit to see how GH actions works. If it works well, then yes, let's remove Travis and Azure.
For Azure, I'll do it, because I need to delete jhipster-core in Azure orga first.

Roger that


db push crashes on SQL Server because of Error: There is already an object named 'Post_authorId_fkey' in the database.

Just happened during a repro, makes no sense:

Create project for sqlserver
Add simple model to schema:model User {
  id   Int    @id
  name String
}

npx prisma db push
Modify schema to something more complicated:model User {
  id    Int     @id @default(autoincrement())
  email String  @unique
  name  String?
  posts Post[]
}

model Post {
  id        Int      @id @default(autoincrement())
  title     String
  content   String?
  published Boolean  @default(false)
  author    User?    @relation(fields: [authorId], references: [id])
  authorId  Int?
}

npx prisma db push
Observe crash:administrator@44528 m1-sql-server % npx prisma db push
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db" - SQL Server
Error: There is already an object named 'Post_authorId_fkey' in the database.
   0: sql_migration_connector::sql_database_step_applier::apply_migration
             at migration-engine/connectors/sql-migration-connector/src/sql_database_step_applier.rs:11
   1: migration_core::api::SchemaPush
             at migration-engine/core/src/api.rs:161

Running db push again succeeds though:
administrator@44528 m1-sql-server % npx prisma db push
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db" - SQL Server

The database is already in sync with the Prisma schema.

✔ Generated Prisma Client (3.1.1) to ./node_modules/@prisma/client in 764ms

I can reproduce this as well:

I have the same error with mysql, it happens if I execute "npx prisma db push" after I delete manually all the tables of the database, It only works again if I delete the entire database and not only the tables.
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": MySQL database "demodatabase" at "localhost:3306"
Error: Table 'demotable' already exists
   0: sql_migration_connector::sql_database_step_applier::apply_migration
             at migration-engine/connectors/sql-migration-connector/src/sql_database_step_applier.rs:11
   1: migration_core::api::SchemaPush
             at migration-engine/core/src/api.rs:161

@MarcioBarrientos That is a very different error - can you please open a new issue and provide all the information the issue template asks for? I think we should investigate this in isolation from this problem here. THanks.

I identified the cause, PR is coming. From my test:
// Root cause: redefining a table recreated all the foreign keys pointing to that table, but if we
// were creating them for the first time in the migration in the first place (here: new table), the
// foreign key is created twice and that conflicts.


Login v2 for Ionic-Auth

@sararob Can you verify this builds?

@mcdonamp Can you verify this builds?

@davideast looks like it does to me


Convention for field order in AST types

I opened #6391 to re-order fields on some types so they're in source order. I had assumed:

Our convention is that AST type fields are ordered in order they appear in source.

@Boshen replied:

In source or runtime order? This should be documented.

Opening this issue to resolve question of what is our convention, so that we can document it.
A couple of questions:

What does "runtime order" mean exactly? The order of runtime evaluation?

Are there any cases where source order and runtime order are different? I can't immediately think of any, but JS is weird - there may well be some obscure cases where they're different.

Evaluation order defined in the spec. For types, we look at how it's defined in tsc.

Reopening this just for the action point of adding this info to the docs.


Iam Role has invalid property Tags

CFN-Lint flagged a template I generated (my code adds tags to any resource that has a Tags prop)
Invalid Property Resources/RedshiftRole/Properties/Tags
I see that you have Tags on the Role object-
https://github.com/cloudtools/troposphere/blob/master/troposphere/iam.py#L85
but AWS does not-
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html
If this is valid I'd be happy to send in a PR to update it.

This was added via #1441 by @jpvowen where he observed it being supported. But yes, I see the docs and spec files indicate it isn't supported. I just used the below to test and it did show the Tags in the IAM UI.
from troposphere import Template, Ref, Tags
from troposphere.iam import Role

from awacs.aws import Allow, Statement, Principal, PolicyDocument
from awacs.sts import AssumeRole

t = Template()
cfnrole = t.add_resource(Role(
    "CFNRole",
    AssumeRolePolicyDocument=PolicyDocument(
        Statement=[
            Statement(
                Effect=Allow,
                Action=[AssumeRole],
                Principal=Principal("Service", ["ec2.amazonaws.com"])
            )
        ]
    ),
    Tags=Tags(foo="bar"),
))

print(t.to_json())

So what is the approach? In general, would we expect Troposphere to follow the published docs, or not? Either way is fine of course!
If this is intended, feel free to close. In that event, should I be making a PR against the cfn-lint repo possibly?

I try to follow the specs/docs as closely as possible. However, these are frequently out of date or incorrect. So I try to balance "doing the right thing" to have what is appropriate for users to get their jobs done. In this case I can see that Tags works for IAM Role and likely is being used. I try to funnel these back to the CloudFormation team in the hope it gets corrected. For cfn-lint, I know there is an override mechanism for the spec files that they implemented. I'd suggest submitting a patch to support this there as well.

Sounds good


Fix duplicated input types error

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fix for a duplicated input types error.

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fix for a duplicated input types error.


Update documentation on previews permissions

The help center should be updated following #27783.

Related PR: #26839


Create an upgrade doc for OpenEBS on Lokomotive

$subject so that we don't have to repeat the steps in every release notes like this: https://github.com/kinvolk/lokomotive/blob/master/CHANGELOG.md#openebs.

https://github.com/kinvolk/lokomotive/pull/1095#issue-505808452


Revert "Clang function types v2: Electric Boogaloo (parsing + printing)"

Reverts apple/swift#28737

This broke the macOS, Linux, Windows builder, revert until it can be re-tested.

@swift-ci please smoke test

CC: @varungandhi-apple

Oh shit, I forgot there was an intersecting part which was not tested together. Yes, let us revert this.


Index with downloading channel

Please add channel downloading with index ( descending order ).

What do you mean? do you want to append the index to the file name? You can do that using the "file name pattern" feature. Take a look at Help->File name pattern tab.


Ability to dynamically change InstanceMetric inputs + grammar metrics

Ariel, I'm not sure about the generic part change.   It breaks unitxt concepts.
The task_data defines the fields of the task which should be shared by all metric.
So it's not a place to pass specific field names to specific metrics..

@yoavkatz The task fields are still shared across all metrics. But there are many use cases - specifically, reference-less ones - where you want to apply an existing metric but use a different field (an input field, which is still one of the task fields). I don't think it makes sense to create a new metric for every possible field that one would want to pass.
@elronbandel

I see the point.  Some points to consider:

There is an implicit conversion to list  - which will be hard to keep track of.  And will cause problems when passing references which are lists (e.g. when the "references" are a list of  of context_ids, for example).

So I do not have the full picture, but regarding both 2 and 3 my feeling is that the real underlying issue is that the different types of metric classes do not really share methods, which is something that should probably be improved regardless of this specific question. Once the different types of metrics have more methods in common, things like the field modification I did here and the type checking can both happen in a more centralized place, which will solve most of the issues you mention.
I do understand what you are saying about complicating the API. But since tasks -- even similar ones -- often differ in the name of their input fields, my feeling is that the cost of having a separate metric for every possible field name will very quickly blow out of proportion, which is also a serious problem. In other words, the API may be simpler but the catalog will be more complicated.

@arielge - it think it's not only a matter of which filed to use  We should also give clear score names
right now we
char_edit_distance
chat_edit_distance_accuarcy
But the second needs to be something like
char_edit_distance_from_original_text
to be differentiated .

I agree, this is what I was aiming for with this issue https://github.com/IBM/unitxt/issues/737.
Now, if this is done not via overwrite, then you will need to add a metric to the catalog for char_edit_distance_from_original_text, and for another task you would add char_edit_distance_from_input, and for another you would add char_edit_distance_from_document, when they all do exactly the same calculation.

I see.   Today we have the explicit way of doing this:
metric = MetricPipeline(
main_score="score",
preprocess_steps=[
ListFieldsValue(fields=["task_data/original_text"], to_field="references", use_query=True)
],
metric=metrics["metrics.char_edit_distance"],
postpreprocess_steps=[
RenameFields(field="score/global/chat_edit_distance",to_field="score/global/chat_edir_distance_from_original_input"
use_query=True)
],
)
add_to_catalog(metric, "metrics.char_edit_distance_from_original_text", overwrite=True)
I agree it would be nicer to have it shorter.
metrics.char_edit_distance[reference_field=original_text, score_name=char_edit_distance_from_original_input]
We need to make sure:

We always encapsulate reference_field in a list - to get consistent behavior. If we have need multiple references, we should have a explicit option like:

metrics.char_edit_distance[multiple_references_field=original_text, score_name=char_edit_distance_from_original_input]

Add the functionality to the base  Metric class.

That sounds good to me


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:17: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:23: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:44: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:51: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:51: missing_description: The recipe is missing a description
ERROR: /tmp/abs_04iasm94t9/clone/recipe/meta.yaml:51: missing_dev_url: The recipe is missing a dev_url
Errors were found


Fetching from index returns wrong result

OrientDB Version, operating system, or hardware.

v2.2 SNAPSHOT

Operating System

[x] Linux
[x] MacOSX

Expected behavior and actual behavior
I tried to fetch some data from my database and faced with problem.
orientdb {db=mydb}> select count(*) from Movie where releaseDate is null
+----+-----+
|#   |count|
+----+-----+
|0   |128  |
+----+-----+
1 item(s) found. Query executed in 1.104 sec(s).
orientdb {db=mydb}> select count(*) from Movie where releaseDate is null order by releaseDate
+----+-----+
|#   |count|
+----+-----+
|0   |0    |
+----+-----+
It seems "order by" changed result rows for this request. According to "explain" command I found out that second request uses index, so I tried to rebuild this index, but it didn't help me.
orientdb {db=mydb}> REBUILD INDEX Movie_releaseDate
Rebuilding index(es)...
Rebuilt index(es). Found 16332 link(s) in 2.265000 sec(s).
Index(es) rebuilt successfully
orientdb {db=mydb}> select count(*) from Movie where releaseDate is null order by releaseDate
+----+-----+
|#   |count|
+----+-----+
|0   |0    |
+----+-----+
Then I tried to recreate index and this helped me.
orientdb {db=mydb}> DROP INDEX Movie_releaseDate
Removing index...
Dropped index in 0.017000 sec(s).
Index removed successfully
orientdb {db=mydb}> CREATE INDEX Movie_releaseDate On Movie (releaseDate) NOTUNIQUE
Creating index...
Created index successfully with 16332 entries in 1.868000 sec(s).
Index created successfully
orientdb {db=mydb}> select count(*) from Movie where releaseDate is null order by releaseDate
+----+-----+
|#   |count|
+----+-----+
|0   |128  |
+----+-----+
First time this index was created through the createIndex method of OClass from java application.
movie.createIndex("Movie_releaseDate", OClass.INDEX_TYPE.NOTUNIQUE, "releaseDate");
Expected behaviour - fetching from index should return correct result

Hi @syzdykov
it seems to be a bug. From what I see, probably the first time the index was incorrectly configured to ignore null values and it was (again incorrectly) used to optimize the count().
This index behavior was the default in v 2.1, but it was changed in 2.2.
I'm checking it, I'll let you know asap
Thanks
Luigi

Hi @syzdykov
I tried to reproduce che problem with a test case, but without success:
  @Test
  public void testIndexWithNullValues() {
    OSchemaProxy schema = database.getMetadata().getSchema();

    final OClass cls = schema.createClass("testIndexWithNullValues");
    cls.createProperty("releaseDate", OType.DATE);
    cls.createIndex("testIndexWithNullValues_releaseDate", OClass.INDEX_TYPE.NOTUNIQUE, "releaseDate");

    database.command(new OCommandSQL("insert into testIndexWithNullValues set name = 'foo', releaseDate = null")).execute();
    database.command(new OCommandSQL("insert into testIndexWithNullValues set name = bar")).execute();

    //test with index created from Java
    List<OIdentifiable> result = database.query(
        new OSQLSynchQuery<OIdentifiable>("select count(*) from testIndexWithNullValues where releaseDate is null order by releaseDate"));
    Assert.assertEquals(result.size(), 1);
    Assert.assertEquals(((ODocument)result.get(0)).field("count"), 2L);

    //test with index created from SQL
    result = database.query(
        new OSQLSynchQuery<OIdentifiable>("select count(*) from testIndexWithNullValues where releaseDate is null order by releaseDate"));
    Assert.assertEquals(result.size(), 1);
    Assert.assertEquals(((ODocument)result.get(0)).field("count"), 2L);
  }

I'm on 2.2.x branch and everything seems to work fine.
Is it possible that you are using a DB that you created with an old version (eg. a 2.1.x)?
Thanks
Luigi

Hi @luigidellaquila
I am not sure about what orientdb version was used for creating this index (it can be 2.1, I am going to ask my colleagues about this).
But using index which ignores null values to this request looks like a bug

Yes, it was 2.1 when we create index first time

Ok, thanks for confirming this. So I have only one bug to fix ;-)
Thanks
Luigi

Hi @syzdykov
I just pushed a fix on 2.2.x branch, it will be released with 2.2.11.
Closing, please reopen if you see any related problems
Thanks
Luigi


add scale to EDA's display labels

This will address https://github.com/VEuPathDB/web-monorepo/issues/450.
It was hard to find where the scale info (metadata) is used but at least I could manage to find one study, Mal-ED study. After checking the codes carefully, I realized that an easy solution was to change variableDisplayWithUnit() so that all (or most) Vizs show scale info at various display labels such as axis title, legend title, variable coverage table etc. Below are screenshot with Scatterplot for before and after this PR.
I saw that there were cases where units are empty while scale exists. In that case, I just used scale with parenthesis: e.g., Polio serotype... in the "After" screenshot.
- Before

- After

Overall, this looks good. I added a suggested change, to simplify the code. Let me know what you think. Thanks!

Hi again @dmfalke 👋 Thank you for your review and suggestion! I saw the technique, array.filter(Boolean), somewhere before and I think it would work quite well in this case. Will check it out next week 👍

@dmfalke I have addressed your feedbacks. It would be great if you can check it out 👍

Thank you for your review @dmfalke 👍


Some in place refactoring must mostly comments as TODOs

@scanon I figured that ToDo's in a PR was as good a way to discuss ideas as any. I'll keep updating the PR as we discuss

@scanon I implemented several of the changes in this PR but want to avoid blowing it up too much. Once this is merged I have another queued up


fix: add CORS methods and headers for lazyCompilation

What kind of change does this PR introduce?
fix #15120
Did you add tests for your changes?
Small change, no test
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No

Thanks


Wavesurfer.js Microphone does not show waves when multiple device is connected on safari.

Wavesurfer.js version(s):
<EMAIL_ADDRESS>Browser and operating system version(s):
macOS Mojave(10.14.6), Safari Version 14.0 (146<IP_ADDRESS>.9)
Use behaviour needed to reproduce the issue:
When we connect external bluetooth device and try to access "https://wavesurfer-js.org/plugins/microphone.html" we do not see the wavelines.

@bgakash93 please use wavesurfer.js 4.1.1 or newer, you're using an ancient version. Please re-open if issue still exists.

@bgakash93 please use wavesurfer.js 4.1.1 or newer, you're using an ancient version. Please re-open if issue still exists.

@thijstriemstra Verfied on updated version 4.1.1 also, facing the same issue.


Print first N lines of a failed build's stderr

Now we request users to always go and look into the stored stderr. It'd be more convenient if we printed the first N lines (N could be configurable).

We could use something like that: https://docs.python.org/3/library/reprlib.html#module-reprlib to handle the representation of the error message and print the initial lines.

I don't think we need reprlib and all the machinery around it. We do have the output already, we simply need the first N lines.


How to start raw socket device without InitDPDK?

Hi, I'm trying to run nff-go with raw socket devices in kubernetes daemon-set.
I follow the example here, first calling SystemInit then using SetReceiverOS and SetSenderOS.
But I have some problem with using it inside daemon-set,
```------------***-------- Initializing DPDK --------***------------
EAL: Detected 1 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: No free hugepages reported in hugepages-2048kB
EAL: No free hugepages reported in hugepages-1048576kB
EAL: FATAL: Cannot get hugepage information.
EAL: Cannot get hugepage information.
panic: assignment to entry in nil map [recovered]
        panic: assignment to entry in nil map```

And check code, the SystemInit there's a low.InitDPDK call that caused these error messages.
https://github.com/intel-go/nff-go/blob/048b92a8284baee035a75c57c9f86923d3e71208/flow/flow.go#L621

If we want to run raw socket device, can we ignore the SystemInit call?
If we can't ignore the SystemInit, is there other way to init the flow system without InitDPDK?
Or anything else suggested?

When we run a docker container we specify --privileged and -v /sys/kernel/mm/hugepages:/sys/kernel/mm/hugepages among other options. Can you organize huge pages for your application?
Currently NFF-Go relies heavily on DPDK memory management libraries, so even if you don't use DPDK ports, it is still necessary to initialize DPDK.

@guesslin How critical is the dependency on DPDK for your app? Can you use what Gregory suggested? Is this because of usage inside K8s?

@gshimansky about the hugepages we're trying to make it work inside K8s now.
@aregm the major reason for us want to try raw socket is that we expect the raw socket can just run without any DPDK dependency, that way we can run our app in all naive k8s clusters.

At the moment raw socket allows working without network ports bound to DPDK and therefore avoid exclusive system's network card usage by a single container, so a kubernetes pod may receive individual packets NATed to it.
DPDK initialization cannot be avoided yet.

@aregm Yes, it's about running nff-go in K8S without DPDK. The problem is that Managing Hugepages was introduced in K8S with version 1.8, but using this version configuring kubelet is required to enable it, which most managed K8S installations AFAIK don't allow (e.g. AKS). This leaves us effectively with requiring K8S version 1.10 which was released around one year ago.
@gshimansky Do you have a K8S YAML with a running hugepages configuration for nff-go?

@marcusschiesser Have you tried the section 6.3.4 of this document https://builders.intel.com/docs/networkbuilders/adv-network-features-in-kubernetes-app-note.pdf ?

@marcusschiesser @guesslin Any update? Were you able to run K8s?

@aregm we have that on hold for now as we're building our own rawsocket based implementation now (without hugepages dependencies) - we'll send you our findings this week

@aregm we tried the the rawsocket in k8s but there's some error, and we can't get packets from it
------------***-------- Initializing DPDK --------***------------
EAL: Detected 2 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: No free hugepages reported in hugepages-1048576kB
EAL: Probing VFIO support...
EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using unreliable clock cycles !
------------***------ Initializing scheduler -----***------------
DEBUG: Scheduler can use cores: [0 1]
------------***---------- Creating ports ---------***------------
------------***------ Starting FlowFunctions -----***------------
DEBUG: Start SCHEDULER at 0 core
DEBUG: Start STOP at scheduler 0 core
DEBUG: Start new instance for OS receiver1
DEBUG: Start new clone for OS receiver1 instance 0 at 1 core
DEBUG: Start new instance for segment1
WARNING: Can't start new clone for segment1 instance 0

I setup the hugepages in the daemonset like
         resources:
           limits:
            cpu: "4"
             memory: 200Mi
            hugepages-2Mi: 100Mi
           requests:
            cpu: 200m
             memory: 200Mi
            hugepages-2Mi: 100Mi
         volumeMounts:

It looks like your scheduler is limited to just 2 CPU cores, which are not enough to run all of the flow functions. Did you specify anything in CPUList field of initialization parameters?

@gshimansky no, I don't specify anything in CPUList, should I specify with minimum 4 cores?

I try to specify CPUList in flow.Config,
       log.Println("Initiating nff-go flow system")
        flowConfig := &flow.Config{
                CPUList:      "0,1,2,3", // https://github.com/intel-go/nff-go/blob/v0.8.0/common/common.go#L32
                HWTXChecksum: true,
        }
        flow.SystemInit(flowConfig)
       log.Println("Initiated nff-go flow system")

and fix my Daemonset deployment yaml to request 4 CPUs from k8s host
        resources:
          limits:
            cpu: "4"
            memory: 200Mi
            hugepages-2Mi: 100Mi
          requests:
            cpu: "4"
            memory: 200Mi
            hugepages-2Mi: 100Mi

But then all my pods keep Pending status, the result of describing pod says Warning FailedScheduling 54s (x41 over 25m) default-scheduler 0/2 nodes are available: 1 node(s) didn't match node selector, 2 Insufficient CPU.
We run our application in AKS Cluster with standard VM size Standard DS2 v2 Azure VM size ref which we expected the application should run.

@gshimansky I think the issue here is that AKS, without any configuration, uses VMs that have 2 CPUS, each 2 cores, see:
$ cat /proc/cpuinfo | grep 'cpu cores'
cpu cores       : 2
cpu cores       : 2

So the expectation would be that the raw socket, being the fallback, works on the AKS standard configuration.

Current implementation of send/receive flow functions via raw socket is not very different from DPDK send/receive implementations. Scheduler treats them in the same way, and allocates entire CPU core for each flow function. So it is necessary to change scheduler so that it would let flow functions share one CPU core. Maybe @ifilippov can add more information.

Have anyone succeeded to initialize NFF-Go app on K8s?


Add code and instructions for running ORB_SLAM3 in Docker

Results from running the example benchmark twice. Shows the real-time result.
2022-09-27_07-04-42
2022-09-27_07-10-15

Third run, changed the example to show the post-processed track.
figures
figures-z-axis


Add a route to add a review to a salon.

Route added.
app.put('/postReview', function (req, res) {/* ... */});


Instrumentation Design

How should instrumentation look like? What data would the visitor need?
To uniquely identify a location, one would need the index of an instruction in the function as discussed in #2 .
One can uniquely identify if an instruction has to be instrumented as indicated by the InstrumentType enum.
On the first scan of the .wat, we can change InstrumentType to associated value. Second scan as we hit one of this, we do the instrumentation, and then change it back to InstrumentType::NotInstrumented and look for the next one that has a InstrumentType value that is not NotInstrumented.

This is now working!


Only one post on start page

I try to setup anubis2 with a fresh hugo page.
I used the full config example.
When I copy over the post from my old blog, only one post is shown on the home page. In the archive, all posts ar shown.

Hi, thanks for using Anubis2, can you share your blog so I can debug it?


Scratches Pattern Issues

Material Maker version:
0.92
OS/device including version:
Linux (Ubuntu 20.04)
Issue description:
Scratches nodes produces wrong ends and some scratches are under-sampled.

Steps to reproduce:

Create Scratches Node
Play with settings a little (length and angle)

@somefoo This should be fixed now (can be tested with a dev build if you want).

Yup, works great now :)


CSS issues with toolbars

CSS of the toolbars look off and partially hidden.  Not sure what is causing this
I tried creating a tabs panel and had a similar issue of the top toolbar looking partially hidden

I just built from scratch on master and can't reproduce this.
Could you try doing these steps:
rm -rf node_modules
npm install
npm run clean
npm run build:all
jupyter lab

A clean build from scratch resolved this issue.


add avj to readme

ajv and json-schema-to-ts play super nicely together, and it's very popular so I added it to the readme as an option.

Hi @imcodingideas !
I'm ok with mentioning more ajv example but not in the section that you modified, which compares json-schemas versus other validation solutions. Maybe you can provide an example of ajv + json-schema-to-ts in a new faq page ?


Upgrade AWS SDK to 1.12.261+

Type: High Security Vulnerabity
Component:

AWS SDK
Describe the bug
Please upgrade AWS SDK To 1.12.261+
Origin: https://github.com/aws/aws-sdk-java/security/advisories/GHSA-c28r-hw5m-5gv3
Release Date: 2022-07-15
Vulnerability Details

The AWS SDK for Java enables Java developers to work with Amazon Web Services. A partial-path traversal issue exists within the downloadDirectory method in the AWS S3 TransferManager component of the AWS SDK for Java v1 prior to version 1.12.261. Applications using the SDK control the destinationDirectory argument, but S3 object keys are determined by the application that uploaded the objects. The downloadDirectory method allows the caller to pass a filesystem object in the object key but contained an issue in the validation logic for the key name. A knowledgeable actor could bypass the validation logic by including a UNIX double-dot in the bucket key. Under certain conditions, this could permit them to retrieve a directory from their S3 bucket that is one level up in the filesystem from their working directory. This issue’s scope is limited to directories whose name prefix matches the destinationDirectory. E.g. for destination directory/tmp/foo, the actor can cause a download to /tmp/foo-bar, but not /tmp/bar. If com.amazonaws.services.s3.transfer.TransferManager::downloadDirectory is used to download an untrusted buckets contents, the contents of that bucket can be written outside of the intended destination directory. Version 1.12.261 contains a patch for this issue. As a workaround, when calling com.amazonaws.services.s3.transfer.TransferManager::downloadDirectory, pass a KeyFilter that forbids S3ObjectSummary objects that getKey method return a string containing the substring .. .
Publish Date: 2022-07-15
URL: CVE-2022-31159

Thanks for letting us know. Will make a release but keep in mind that you can bump AWS dependencies independently from Spring Cloud AWS, as described in docs.

thank you, i agree we can override the dependencies but would rather prefer to use spring-cloud-aws-dependencies

Closed in #460


[BUG] RuntimeError: Unknown model

Describe the bug
can't load the CLIP-convnext_xxlarge
To Reproduce
My code is model, preprocess_train, preprocess_val = open_clip.create_model_and_transforms('hf-hub:laion/CLIP-convnext_xxlarge-laion2B-s34B-b82K-augreg-soup') and my timm version is the latest 0.6.13.
The Traceback is:
  File "/mnt/jiaming/code/CLIP_Finetune/models/clipNet.py", line 18, in __init__
    model, preprocess_train, preprocess_val = open_clip.create_model_and_transforms(self.name, pretrained=None)
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/open_clip/factory.py", line 269, in create_model_and_transforms
    model = create_model(
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/open_clip/factory.py", line 188, in create_model
    model = CLIP(**model_cfg, cast_dtype=cast_dtype)
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/open_clip/model.py", line 188, in __init__
    self.visual = _build_vision_tower(embed_dim, vision_cfg, quick_gelu, cast_dtype)
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/open_clip/model.py", line 89, in _build_vision_tower
    visual = TimmModel(
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/open_clip/timm_model.py", line 53, in __init__
    self.trunk = timm.create_model(model_name, pretrained=pretrained, **timm_kwargs)
  File "/home/jiaming/anaconda3/lib/python3.9/site-packages/timm/models/factory.py", line 67, in create_model
    raise RuntimeError('Unknown model (%s)' % model_name)
RuntimeError: Unknown model (convnext_xxlarge)

Process finished with exit code 1

@jiamingzhang94 as per README you need a development version of timm for latest model arch, so a 0.8.x release not a 0.6 (stable), pip install --pre  timm


Post JD for volunteer lawyer to help us avoid major potholes

[ ] Draft JD for legal volunteer to do due diligence into legal safeguards
[ ] Which country does this even fall under?
[ ] Can we tap on Ines' Cornell networks?

After doing due diligence in Singapore, our takeaways were:

Current legislation does not exist. Every lawyer seems to have a differing opinion on what stablecoins and cryptoassets are even classified as.

We should put very clear notices to ensure that lenders are aware of all risks. We should communicate this as clearly as possible, including risk of Ines' default, smart contract risks.

We should hold the Ines Fund crowdfund in (possibly) a Singapore company for liability purposes, to prevent developers from having individual responsibility


⚠ Exoticaz has degraded performance

In 39031b3, Exoticaz ($EZ) experienced degraded performance:

HTTP code: 200
Response time: 7084 ms

Resolved: Exoticaz performance has improved in bab61f8.


add pufferfish to the list of forks

There are more places this needs updating, so if you could find those places that would be great. If not, just wait until we get around to updating everything

superseded by https://github.com/PurpurMC/PurpurDocs/commit/e574c7a


Converted some sub components in Access folder to use hooks

Converted the following components:

AccessList
AccessListItem
AccessTable
AssignAccess
RevokeAccess

@jSylvestre Should be fixed in this push ^^^


make syntax for pantheons sheet more compact

gfe, fest exclusive | 234, 235, 236, 237, 238, 239, 240, 241, ...

Closing cos we just did this


Add workflow_ref to Portfolio CRUD

Adding the workflow_ref attribute to Portfolio so it can be passed in as in attribute from the UI

@lindgrenj6 please review

cc @Hyperkid123 @lgalis


Consider adding some sort of highlight around the selected node

If I have a bunch of sshds, and the graph is moving around beneath me, it sometimes becomes unclear to which node the details panel is referring.

Fixed by #473


Curator job: fix new curator job using non existing resource pool

In latest release (v23.0.0), a new job called curator is using a non existing resource pool. Template generation with spiff is broken.
I have fixed spiff generation by updating the templates.
A new resource pool have been added: logsearch_curator.

This PR looks sane to me - https://gist.github.com/dpb587/051ad80070b10980c1b8


Is it possible to have ImgBot closes/delete the branch after PR merged?

After we merge a PR fromImgBot, I have to make sure whichever team member it was also deletes the imgbot branch. Otherwise, It prevents imgbot from submitting another PR next time it should. So can it actually handle this instead? Maybe throw it into a configuration setting so it can be turned off but it be on by default?

Great idea. What would you call the config setting? Any ideas?

Prunebranchaftermerge?
On Thu, Mar 15, 2018 at 1:29 PM Dan Butvinik<EMAIL_ADDRESS>wrote:

Great idea. What would you call the config setting? Any ideas?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dabutvin/ImgBot/issues/82#issuecomment-373459043, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKeM169ch4OOEW87VP20QMITVMJ5MnR6ks5teqTYgaJpZM4Sshp_
.

awesome.  Because this changes behavior for existing installs, I think keeping it off by default would be better for now.

could be that you indicate it for a month on PRs so that people are aware. But really I'd say that the change is fairly harmless. If I have a configuration file to schedule once a day, I would want it to be able to delete the branch once merged or add to the PR at the scheduled time if that PR still hasnt merged.

Yeah, I see what you are coming from.
Adding another commit to an existing PR is an interesting case

Is this an available option yet? I would like for ImgBot to delete its branches after I merge them

Hi @RohanNagar thanks for finding this stale issue!
Let's reactivate and get this in 'todo'
We can add a webhook to listen for 'imgbot' branch getting integrated and send a branch delete.
I think having this on by default would probably be fine after all. Having old imgbot branches hanging around has caused problems in the past anyways

Don't think this is stale yet :smile:

@dabutvin maybe you should configure stale-bot to ignore certain issue which are labeled (e.g. with "help-wanted") or similar

@staabm I want help on almost everything around here lol
We can always dig the stale issues out of the closed bin https://github.com/dabutvin/ImgBot/issues?q=is%3Aissue+label%3Awontfix+is%3Aclosed

This is a nice implementation I've seen folks pairing with ImgBot to solve this problem
https://github.com/apps/delete-merged-branch
https://github.com/SvanBoxel/delete-merged-branch

Dependabot deletes the Branch when merged

As @mrmajik45 pointed out, you can take a look at dependabot who closes the branches after it got merged by either someone or the bot itself (note: it would be cool if it could also auto-merge it, say when the checks goes green).

yeah @dependabot-bot  is awesome!
We should do this! We have hooks on the imgbot branch already, if we see it merged, we can totally issue a delete.
Good idea about the auto-merge option, I opened #231 to track that - feel free to chime in if there's anything i missed

Can we reopen and fix this?

:+1:

I got #314 open to start doing this automatically

thanks all for pushing for this improvement.
It is now live in production

https://github.com/dabutvin/ImgBot/issues/82#


Script requires authentication on TV every time we run the code.

This is more of a question?
Is there a way we can skip that part, I have a piece of code using which I want control the TV but it seems that every time I run this code, I will have to authenticate (press Yes) on the TV screen prompt. Is that how it is or is there a way around?

Duplicate of https://github.com/supersaiyanmode/PyWebOSTV/issues/35.
You need to store the credentials after you're done with the registration for the first time. In the second run, provide a dictionary-like object to the register function, the function will inspect the incoming object to see if there's an existing credential, if so uses it silently without invoking authorization.

Please re-open this issue (and attach minimal, reproducible code), if you didn't follow the README or the linked issue. We want to improve it, if the instructions are not readily apparent.

Please re-open this issue (and attach minimal, reproducible code), if you didn't follow the README or the linked issue. We want to improve it, if the instructions are not readily apparent.

Works like a charm :) Thank you so much..

Duplicate of #35.
You need to store the credentials after you're done with the registration for the first time. In the second run, provide a dictionary-like object to the register function, the function will inspect the incoming object to see if there's an existing credential, if so uses it silently without invoking authorization.

Works like a charm :) Thank you so much..


fail if two lock files are detected

When the build starts, if there are two lock files present, the build should fail immediately. This is done in the npm and yarn buildpacks.

Tested this with pack locally, we'll need to add testing for errors and error exit codes later.


Crash when using version 1.2.4 with Minecraft 1.21.1

latest.log: https://mclo.gs/dj3qtFW
Version 1.2.4 despite being marked as compatible with Minecraft 1.21.1, causes a crash with it. This version shows on the top of the list for 1.21.1 versions. Therefore, I request that, in order to avoid confusion, it shouldn't be marked as such.

Thanks for reporting the issue. Could you tell me if 1.2.3 works with Minecraft 1.21.1 on your computer? There should be no difference between 1.2.3 and 1.2.4 appart from the list of supported versions.

On my machine, I am able to launch Minecraft 1.21.1 with Better Game Mode Switcher 1.2.4. This will need more investigation to understand what exactly causes the issue on your machine.

Thanks for reporting the issue. Could you tell me if 1.2.3 works with Minecraft 1.21.1 on your computer? There should be no difference between 1.2.3 and 1.2.4 appart from the list of supported versions.

Yes, 1.2.3 works completely fine.

On my machine, I am able to launch Minecraft 1.21.1 with Better Game Mode Switcher 1.2.4. This will need more investigation to understand what exactly causes the issue on your machine.

Hmm, that's weird..

I released a new version: 1.2.5, which adds support for Minecraft 1.21.4. It should be compatible with all previous version of Minecraft, starting at Minecraft 1.20.5. Can you tell me if it works on your machine with Minecraft 1.21.1?

I released a new version: 1.2.5, which adds support for Minecraft 1.21.4. It should be compatible with all previous version of Minecraft, starting at Minecraft 1.20.5. Can you tell me if it works on your machine with Minecraft 1.21.1?

Crashes on my machine on Minecraft <IP_ADDRESS> if I use either 1.2.4 or 1.2.5, only 1.2.3 works

Could you send a crash report when using Better Game Mode Switcher 1.2.5 with Minecraft 1.21.1?

Could you send a crash report when using Better Game Mode Switcher 1.2.5 with Minecraft 1.21.1?

crash-2024-12-15_22.25.49-client.txt

Better Game Mode Switcher versions 1.2.4 and 1.2.5 are no longer marked as supporting Minecraft versions 1.20.5, 1.20.6, 1.21, and 1.21.1 on Modrinth and GitHub.


Switch from using app.progress to app.url for passing web launch urls

@jonahwilliams this relates to comments made at:
https://github.com/flutter/flutter/pull/44263#pullrequestreview-312420847
The current mechanism tries to use app.progress to pass the web url back, but the message is dropped. I did add it back, but it feels unnatural to use app.progress and the daemon spec says message is not supplied for finished events.
This changes the sendNotification method to be a generic sendEvent and adds a new event for web.url instead.
Does this seem reasonable? @devoncarew @pq will IntelliJ ignore events it doesn't know about, or would this be breaking?

I assume it doesn't make sense to reuse either the app.debugPort event or the app.started event?
I don't know the timing of when the app url would be available, and if it could be sent as a field on app.started.
If we want to keep the separate app.url event, we should update the docs (or the event name) to clarify that it's only for flutter web launches, and returns the url the app is being served from.

We can't use app.debugPort or app.started because Flutter may be sat waiting for a connection from the debug extension in order to continue, so they won't come until you've opened this URL and clicked the extension button.
I did think of making a web.something event name (we could use web. for the stuff in https://github.com/flutter/flutter/pull/44271 too) but I wasn't sure if it would be strange since this is related to an app launching (I have no preference at all for the names, so I'm happy to go with any suggestions).
Will IntelliJ ignore the event silently if we send it there?

We can't use app.debugPort or app.started because Flutter may be sat waiting for a connection from the debug extension in order to continue, so they won't come until you've opened this URL and clicked the extension button.

gotcha.

I did think of making a web.something event name (we could use web. for the stuff in #44271 too) but I wasn't sure if it would be strange since this is related to an app launching (I have no preference at all for the names, so I'm happy to go with any suggestions).

app.serverUrl? app.webLaunchUrl? app.webServerUrl?
I have not strong opinions here, but 'url' is a bit generic, and without other context, it's not immediately clear that it's the url that you could hit for the server that serves up the compiled flutter web app.

Will IntelliJ ignore the event silently if we send it there?

Yes, it should.

app.serverUrl? app.webLaunchUrl? app.webServerUrl?

The middle one sounds most specific to me (it's the url to launch the app at) and will be less confusing if we end up with other servers running in there (for ex. if we ran devtools in there).
I'll change to that and add some tests.

@jonahwilliams I've added tests to ensure this even comes through for both Chrome and WebServer. I had to use ChromeDevice() directly (since the event is fired inside ChromeDevice() and using mockWebDevice meant it wouldn't run that code). Please check whether this all looks reasonable.
This might cause some conflicts with https://github.com/flutter/flutter/pull/44263, but I'll rebase that over this if it's ready to land first.

I rebased this since it had conflicts. Had to make some tweaks to the tests for recent changes - they're in 414fbea2f90bf14db64c5a0c6e512152f4714a21.


Change display to enabled at label options

The property display doesn't exists, the correct property is enabled

Current docs are correct. The docs in master are for the upcomming V2 release and not the current V1. In the migration guide thats also in master this is stated:

enabled option was replaced by display in the callout configuration of label annotation, in the label configuration of line and box annotations and in the arrow heads configuration of line annotation to have the same option on all elements.


Make default account type VASP

This PR does a couple things:

Makes the default account type the VASP account type
Allow account types to be specified in functional tests
Makes association accounts empty accounts
Adds a module that signifies if we are in testnet in order to gate travel-rule checking, and other functionality. This should be useful for the prover team.

:umbrella: The latest upstream changes (presumably 38a5bbbf62724f549442f6d4a3750f545c57f665) made this pull request unmergeable. Please resolve the merge conflicts.

:umbrella: The latest upstream changes (presumably e3aade41d51b009a19d48b5fbebd2f782cac88e2) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=sblackshear

:pushpin: Commit 938eb9f has been approved by sblackshear

:lock: Merge conflict

@bors-libra r=sblackshear

:pushpin: Commit c416cf1 has been approved by sblackshear

:hourglass: Testing commit c416cf1a645fd5e8d3dc8c2128e2accecfe09f37 with merge 31d46c864360ed7de4e7372f1d1e80a987348145...

:broken_heart: Test failed - checks-actions_land_blocking_test

@bors-libra r=sblackshear

:pushpin: Commit 9d71069 has been approved by sblackshear

:hourglass: Testing commit 9d71069064de7f333c3cf2314186790a83a0a482 with merge ae25fa8419ab7407df33168d3c04f3c314e37b66...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing ae25fa8419ab7407df33168d3c04f3c314e37b66 to master...