AIO reads same value for all analog pins since v0.9.6

Since v0.9.6 the AIO reads the same value for all the analog pins off the Intel Edison Arduino board. This means that the value of A0 is returned when reading A1 for example.
At the moment we've found a temporary solution which avoids using the Aio read function. This method is basically accessing the kernel files directly using normal file I/O.
The file that needs to be read to get an analog value directly from the kernel is shown below.
/sys/bus/iio/devices/iio:device1/in_voltage0_raw where the voltage0 is the value of A0 and voltage1 is A1, and so on. This works for both the C++ and javascript environment.
Please note that this solution will always read an integer value. So to get a float, the read value needs to be divided by the maximum value (1024 for 10-bit ADC and 4096 for 12-bit ADC).
Hope this helps!

C++ solution in a function that takes the analog pin number as argument and returns the read value as integer.
#include <iostream>
#include <fstream>
#include <unistd.h>
#include <stdint.h>
#include <string>
...

int readAnalogPin(uint8_t pin)
{
	std::string filePath = "";
	switch (pin) {
	case 0:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage0_raw";
		break;
	case 1:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage1_raw";
		break;
	case 2:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage2_raw";
		break;
	case 3:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage3_raw";
		break;
	case 4:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage4_raw";
		break;
	case 5:
		filePath = "/sys/bus/iio/devices/iio:device1/in_voltage5_raw";
		break;
	default:
		std::cout << "ERROR: Unspecified analog pin number.";
		return (-1);
		break;
	}

	if (filePath != "") {
		std::ifstream inFile(filePath.c_str());

		if (inFile.is_open()) {
			std::string line;
			getline(inFile, line);
			inFile.close();
			int readVal = std::stoi (line ,nullptr, 10);
			return (readVal);
		} else {
			std::cerr << "ERROR: Could not open file" << inFile << "\n";
			return (-1);
		}
	}

	return -1;
}

So we definately have a bug there I think introduced from subplatforms, I'm hunting now.
Note that what you're doing is a really bad idea because there's pinmuxing involved, doing so will not work in many configurations and is also very platform dependant. This is the fix, bug was introduced with firmata merge, I'll make sure nothing breaks with this and merge it later today.
diff --git a/src/aio/aio.c b/src/aio/aio.c
index 8ebf7c0..58a8883 100644
--- a/src/aio/aio.c
+++ b/src/aio/aio.c
@@ -122,14 +122,15 @@ mraa_aio_init(unsigned int aio)
         }
     }

+    dev->channel = board->pins[pin].aio.pinmap;
+    dev->value_bit = DEFAULT_BITS;
+
     // Create ADC device connected to specified channel
     mraa_aio_context dev = mraa_aio_init_internal(board->adv_func, aio);
     if (dev == NULL) {
         syslog(LOG_ERR, "aio: Insufficient memory for specified input channel %d", aio);
         return NULL;
     }
-    dev->channel = board->pins[pin].aio.pinmap;
-    dev->value_bit = DEFAULT_BITS;

     if (IS_FUNC_DEFINED(dev, aio_init_pre)) {
         mraa_result_t pre_ret = (dev->advance_func->aio_init_pre(aio));

Fixed properly :/ Not on form today


Investigate Electron 3.0.x

WIP (for #52629), not to be merged until Electron 3.0.x is declared stable and we are happy with it.
Changelog:

Chrome: 61 => 66
node.js 8.9.1 => 10.2.0
libuv 1.15.0 => 1.20.3

VSCode Exploration Builds with Electron 3.0.x:

macOS: Download
Linux: Download
Windows: Download

I think we can wait for Chrome 70. that version is a big upgrade.

@NateLing we're trying to keep up to date with Electron. If we waited for a Chrome 70 Electron and jumped to that, it would be a lot harder to stabilize as it's jumping 9 Chromium versions.

I updated to Electron 3.0.0-beta.5

Build fails with: Module not found: Error: Can't resolve ./api/git

@bpasero Thanks. Since last merge of master branch this issue is fixed during building. :+1:

@bpasero Setting the window style to native causes this:

@beastdestroyer thanks, but that is unrelated to Electron. it should be fixed tomorrow

@Astrantia no, we are 2-3 months away from landing this.

@bpasero Electron 3.0.0 was released yesterday: https://electronjs.org/releases#3.0.0

@bpasero Now that electron v3 is stable, are we still looking at 2-3 months release time? 😀

Yeah thats a good guess.

@NateLing he still needs to test many things to ensure that Electron 3.0.x will work, such as storage, autocomplete, menus etc. Plus he said it would take roughly 2 - 3 months to ship in insiders meaning we could see an electron 3 insiders in november or in 2019. I believe the team also said there won't be a december update too.

Exploration builds will probably be updated to use Electron 4.0 and continue to be Electron version +1 in the future.

@beastdestroyer  @bpasero  thx, i use VSCode from first version. now it is my main IDE, sometimes use idea. i love VSCode.

@beastdestroyer well, depends what you mean. Extensions will run in an environment that matches that node version but for compiling VSCode you would not have to install node 10.2.0

Ah I see, because Node.js 10 went LTS today so I was thinking that VSCode might have to ctach up, thanks for the info/

@bpasero I know you're probs aware of this but there is<EMAIL_ADDRESS>now

@bpasero is it possible to build (release) the electron 3 branch by myself using azure?

@shizonic yes if you follow https://github.com/Microsoft/vscode/wiki/How-to-Contribute from the electron-3.0.x branch

This happened to my terminal after your commit @bpasero

@beastdestroyer looks like this? https://github.com/Microsoft/vscode/issues/57803


Allow use in Docker

It would be nice if there was a resource-level override for "yes I know I'm inside Docker but I promise everything will be okay". My current hack is more fragile than I would like.

+1 I'm using docker for test-kitchen integration tests and it'd be awful nice to be able to use runit services in our cookbooks without hackery.

New URL to my hack is https://github.com/poise/poise-service-runit/blob/master/lib/poise_service/runit/provider.rb#L101-L112

+1 For this

Looks like the main issue was introduced here:
https://github.com/hw-cookbooks/runit/pull/61
There are no tests for this that I can see, and I'm not sure the issue that it was trying to solve for is still relevant - I can run within docker easily enough.
Because this check is skipped by default though, it introduces a race condition when running chef inside of docker (or really, any container) that is quite annoying.
I would suggest getting rid of this docker check altogether, as there's no valid reason why runit wouldn't work inside docker. By just setting the 'inside_docker?' to return false always, my chef run continues along happily.
If we're worried about compatibility, we could at least add a flag like "node['runit']['poll_supervise_files']" that would force this, even if in docker.

FYI, my 'fix' for this is here https://github.com/dalehamel/runit/commit/97b072c7728a10139945c51a367545f5e6712b5b


Transferring Global Name to different user, Still points to old Address

Transferring a Global name works now to a username, however the Point to Address when global name was created still points to the old address and all transactions still direct to the old address!

This isn't updated, because you have no idea what they will change address to once received.

The person who buys it should provide the Point to Address as well as the Username to transfer to
It does not as far as I can find a way to update the Point to Address after transfer to a different user
This has to be done from the original owner sending
I have tested this myself transferring it between myself so I know it doesn't work and it's still an error


Missing changelog

We are using v 5.42.3
Usually when upgrading to the tip one wants to know if there are breaking changes, what changed since then. Do you have a changelog available for your major releases?

Please have a look at #3540


Navigating to Project Pipeline Settings breaks GUI

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Create a new project
Add a test user to the project with role "Project Member"
Login as test user and in browser navigate to Project->Tools->Pipelines

Expected:
Pipeline page displayed
Actual:
GUI stuck in loading. No way to cancel or navigate away.
Other details that may be helpful:

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.2.4
Installation option (single install/HA): HA

v2.2.4
I have reproduced exactly as described in the issue description.
master-head
I also reproduced in latest master.

Version: master-head (v2.3) (9/11/19)
Now the test user (project member) can navigate to the Tools> Pipelines page without any errors and the UI loads properly. They do not have permission to create a pipeline so the expected banner is shown on this page:


Redirects for Reference URLS with #

Increasing Access
This will increase the number of legacy links that work with the new site.
Most appropriate sub-area of p5.js?
Reference
Feature request details
Currently, Reference page URLs that have a # in the link lead to the basic reference page.
Here is an example of a link that doesn't work as desired: https://p5js.org/reference/#/p5.TypedDict
Whereas on the legacy site, this led to the specific entry: https://archive.p5js.org/reference/#/p5.TypedDict
The equivalent link for the new site would be: https://p5js.org/reference/p5/p5.TypedDict/
When encountering an empty hash, the page should redirect to the same URL with 'p5' in place of the hash '#'. If a contributor wants to take this on, it could be a relatively small change. It is also possible that some unexpected complexity is encountered and if this is the case, I'd be happy to help work through it.
Some helpful resources on redirects in Astro for anyone considering taking it on:

Configured redirects
Dynamic redirects

Hi @stalgiag, I want to work on this issue, can you assign me with this

@AbhishekSingh198 Done! Thanks for volunteering. Let me know if you need any help or reviews.


dataset

Dear author，I want to ask how your training dataset is obtained through blender and sceneCity, such as how your 23000  images and jason files are obtained.Can you explain the specific steps or provide relevant codes?
Thanks!

The code is at https://drive.google.com/u/0/uc?export=download&confirm=Bnzn&id=1-TABJjT4-_yzE-iRD-n_yIJ9Kwzzkm7X. Also see #8.

Thank you very much!


segfaulting when trying to request undefined route type

experienced this when building the sample application, I had a http_add_route_DELETE endpoint, and when accidentally using a POST request to that endpoint the server crashed. So I'm assuming if client sends the wrong request to an endpoint it's not handled properly.

fixed in 6a3a601755db4bf63574ad09916459722afc033f


Added more Diff.merge tests

Kind of related to #1002. I'd like to eventually add a test where the diff options flags are not set to 1024 (IGNORE_CASE) but as of right now that test would fail. This is more to prove to myself that it is possible to merge a diff from a commit into a diff from the workdir and index and vice versa.

Always love more tests. Thanks @smith-kyle


Can't put breakpoints on "unrecognized" instructions.

I can do it without the plugin so I see no reason why it's not possible.

I only use it for looking at generated assembler code.
It has other rough edges as well but is enough for this purpose.
Feel free to open a pull request.


[Test-1] Add test cases for MethodDesc

Ⅰ. Describe what this PR did
Add test cases for MethodDesc
Ⅱ. Does this pull request fix one issue?

fixes #193
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #559 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #559      +/-   ##
=============================================
+ Coverage      31.79%   31.88%   +0.08%
- Complexity       769      773       +4
=============================================
  Files            200      200
  Lines           7914     7914
  Branches         937      937
=============================================
+ Hits            2516     2523       +7
+ Misses          5141     5134       -7
  Partials         257      257

Impacted Files
Coverage Δ
Complexity Δ

...ar/spring/annotation/GlobalTransactionScanner.java
43.95% <0%> (+1.09%)
10% <0%> (+1%)
:arrow_up:

...m/alibaba/fescar/spring/annotation/MethodDesc.java
60% <0%> (+60%)
3% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8db36...107ebd2. Read the comment docs.


Able to move 'Merge' button to the overflow menu

Added the ability to move the 'Merge' button on the manga details page to the overflow menu, addresses issue https://github.com/jobobby04/TachiyomiSY/issues/553

Why was this closed?

Why was this closed?

Odd, not sure. Did I do something that accidentally close it?

Maybe you deleted the branch/fork or something?

Maybe you deleted the branch/fork or something?

Oh, that would be it. Didn't realise doing that closes it

I'll just open a new pr, make it easier.


Monochromatic tray icon

Love the app! Could you maybe implement a monochromatic tray icon? As of now, Whatsie is the only colorful application in my tray and this inconsistency bothers me a little.

The hicolor icon theme has a color icon named "com.ktechpit.whatsie" in five different sizes as well as scalable, but also a monochrome icon named "com.ktechpit.whatsie-symbolic".
So it would be super, if this symbolic icon could be used in systray optionally.


Issue with the sample bicep file

The sample bicep shared in this article is not working as expected. The property name "shardCount" under nodeGroupSpecs was not getting recognized.

The deployment was successful after changing the property name to "nodeCount".
Referred Document: https://learn.microsoft.com/en-us/azure/templates/microsoft.documentdb/mongoclusters?pivots=deployment-language-bicep#:~:text=%3A 'Shard'-,nodeCount%3A int,-sku%3A 'string
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bd52e966-71b4-d0a6-4d27-67d30d9b627f
Version Independent ID: 9c4561a9-a3f0-421a-e8be-7070a3b29985
Content: [Quickstart: Deploy a cluster by using a Bicep template

Azure Cosmos DB for MongoDB vCore](https://learn.microsoft.com/en-us/azure/cosmos-db/mongodb/vcore/quickstart-bicep?tabs=azure-cli)

Content Source: articles/cosmos-db/mongodb/vcore/quickstart-bicep.md
Service: cosmos-db
Sub-service: mongodb-vcore
GitHub Login: @gahl-levy
Microsoft Alias: gahllevy

@tonytomyatmicrosoft
Thanks for your feedback! We will investigate and update as appropriate.

@tonytomyatmicrosoft
It has been already updated to nodeCount. I think the issue is resolved. Please tag me if there are any changes need to be done in the document or there are any issues in the document.

@tonytomyatmicrosoft
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


create vae on pytorch

All Submissions Basics:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

[ ] Have you created a .py in ~/pyod/models/?
[ ] Have you created a _example.py in ~/examples/?
[ ] Have you created a test_.py in ~/pyod/test/?
[ ] Have you lint your code locally prior to submission?

thanks for this -- please submit the PR to the development branch :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

11 of 89 (12.36%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 93.006%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyod/models/vae.py
11
89
12.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
9016

Relevant Lines:
9694

💛  - Coveralls

thanks for this -- please submit the PR to the development branch :) @lizakapranova


Utilize googleapis repo

Because we don't have the vcpkg package for googleapis (googleapis/cpp-cmakefiles), I set -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_PROVIDER=external in the windows build.

This change is

@coryan I think this PR is ready for merging. Note that now the windows test is setting -DGOOGLE_CLOUD_CPP_GOOGLEAPIS_PROVIDER=external because we don't have the vcpkg package yet.
Filed #2895


Upgraded profile version

Please confirm that all of the itwinjs-core tests pass when run against an addon build containing these changes.

@pmconne, apart from the failing tests Keith mentioned, all the tests are passing. I compared the failing tests with the unfixed code and no new test is failing after these code changes.
@calebmshafer, Colin gave me the OneNote file and I've updated it with the new profile version and what changes have been done in it.

@pmconne, apart from the failing tests Keith mentioned, all the tests are passing. I compared the failing tests with the unfixed code and no new test is failing after these code changes.

Do you know why those tests are failing? Who can fix them?

Do you know why those tests are failing? Who can fix them?

I'm looking into it now.


Typo in ComputeMSE_ (DirectXTexMisc.cpp)

Hello,
I was opening this issue when you did last commit...
However, at https://github.com/Microsoft/DirectXTex/blob/31b6c9309c489ed90a012a06d2915f2b4c256d25/DirectXTex/DirectXTexMisc.cpp#L129
I think that the code
if (flags & CMSE_IMAGE2_X2_BIAS)
{
	v1 = XMVectorMultiplyAdd(v2, two, g_XMNegativeOne);
}

should be
if (flags & CMSE_IMAGE2_X2_BIAS)
{
	v2 = XMVectorMultiplyAdd(v2, two, g_XMNegativeOne);
}

It's probably a "copy-and-paste" issue...
Regards
mlpmil

Thanks! Great spot!

Fixed in commit 52aead71d7c086f4750ab206d9be8846e84085b3

Fix included in the July 2017 release


Tile background offset initally

Evening!
So tonight I've been playing with calling ".setTileBackgroundColor();" but noticed when called with:
.setImage(
              // image source,
              // image bitmap
          );

The background color flashes before the image is shown. Poking around it looks like it's maybe drawn a little under where it's supposed to be (perhaps when the preview bitmap is drawn) and then correctly once the full image is subsampled.
Cheers!

There was a glitch in the matrix.

Cheers!


folder creation vmware

Default behaviour is to create your cluster in a cluster named folder in VMware, however this becomes an issue in VMware clusters where you have no permissions to do so - e.g. you have access to one absolute folder and that's that (you can't create any sub folders underneath it).
Older versions of this playbook had a folder_absolute_path you could set, which avoided this behaviour.
What's the easiest way to turn off folder creation and just have VMs deploy to a base folder you set?

So far I've achieved this (I think partially as I keep breaking things) by setting these in the ./clusters/cluster.yaml file:
  parent_folder: "...."
  folder_absolute_path: '....'

Then in the ./roles/vsphere_vm/tasks/main.yml by adjusting the vSphere folder creations:
    - name: Create the vCenter folder by the same name as the cluster, only if it doesn't exist
      community.vmware.vcenter_folder:
        hostname: "{{ vcenter.ip }}"
        username: "{{ vcenter.username }}"
        password: "{{ vcenter.password }}"
        datacenter_name: "{{ vcenter.datacenter }}"
        validate_certs: no
        folder_name: "{{ item[0] }}"
        folder_type: vm
        parent_folder: "{{ item[1] if item[1] not in ['', '/'] else omit }}"
        state: present
      loop: "{{ path_pairs }}"
  when: 0 > 1
    #when: vcenter.parent_folder is defined and vcenter.parent_folder is string

- name: Create the vCenter folder by the same name as the cluster, only if it doesn't exist
  community.vmware.vcenter_folder:
    hostname: "{{ vcenter.ip }}"
    username: "{{ vcenter.username }}"
    password: "{{ vcenter.password }}"
    datacenter_name: "{{ vcenter.datacenter }}"
    validate_certs: no
    folder_name: "{{ cluster }}"
    folder_type: vm
    parent_folder: "{{ parent_folder | default(omit) }}"
    state: present
  when: 0 > 1

Is there an easier, better, safer way of accomplishing this?


Double spend

If I create multiple transactions that are exactly the same without mining them, unspent transactions will be reused and lead to double spend

I'm gonna check that. This shouldn't be hard to fix.
Thanks!

Fixed in 57b011a60db84641377ef1174bf3861cb3a3f8b7
I still need to add two improvements.

If the user tries to double spend, the miner will mine the block but the block will never be added to the blockchain thus locking the miner (it will try to mine the same block again)
When creating a transaction check if that unspent output transaction doesn't already have a transaction using it (Not sure though)

Good enough?

Hey,
Now in d96154a8a85e2898358637190b89904649a5fd01, I added the feature to the miner to avoid invalid transactions, thus not locking it anymore.
Best


Fix erroneous environment() type definition

Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check.
Contributing a feature

[x] I have opened a new issue for the proposal, or commented on an existing one, and ensured that the bicep maintainers are good with the design of the feature being implemented
[x] I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
[x] I have appropriate test coverage of my new feature

Fixes #1525

Any idea why we had locations in the first place?

Any idea why we had locations in the first place?

It's a complete mystery to me - clearly I was not thinking straight at the time :). I checked our docs + the ARM code and couldn't find any reference to it!

Can you check in ARM code history? My main worry is that is existed before and a breaking change snuck in :(

Maybe around the time the original definition was committed?


Support for sticky routes / controls state preservation per tab

I haven't tried this package yet, but it looks very promising. Does it support stateful/sticky routes, similar to Angular's ui-router-extras?. For the best UX, form inputs, scroll state, text selection etc. should be preserved when navigating back to a route. iron:router doesn't yet support this. If tabs does, it would be a major distinguishing feature to add to the About heading of the README.

I believe it does. The mechanism for changing tabs is jQuery's .hide() rather than a .remove().

Nice. A demo and mention in the README would be great.

Will add a demo very soon. For now I'm adding it to the README.

Live example link added to README.

:+1:


Wrong url

Link to "What is hybrid Identify?" in the Next Steps section seems to be incorrect

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aad82713-d562-5778-fbf8-035e24f9c470
Version Independent ID: 6370cca0-c78e-4738-ba67-8fb14594b0f2
Content: What is password hash synchronization with Azure AD?
Content Source: articles/active-directory/hybrid/whatis-phs.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@prawin2k Thanks for reporting the issue. PR has been created to update the doc.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Cron isn't runnig anymore

Hello,
since the newst update my cron isn't runnig anymore.
Thanks for your help!

Sorry. I hadn't the latest version.


Upgrade issues

2.6.1 upgrade to 3.0 / swagger- ui.html But it doesn't work. Is it backward compatible?

@configuration
@EnableOpenApi
@EnableSwagger2
public class Swagger2Config {
@Bean
public Docket createRestApi() {
return new Docket(DocumentationType.SWAGGER_2)
.select()
.apis(RequestHandlerSelectors.basePackage("com"))
.paths(PathSelectors.any())
.build();
}
}

spring boot version is "'2.1.6.RELEASE'" He seems to need it spring-boot-plugin 2.0.0.
Demo Version  is spring boot 2.3.1 .It's so new

@chinausers Here are the release notes (updated with compatibility). Also please read the documentation on [how to migrate(http://springfox.github.io/springfox/docs/current/#migrating-from-existing-2-x-version). I believe it should work with 2.1.6 but its not been tested. Would love feedback on how to improve it.

Same question #3401. he seems to need to solve this problem.

Good. Thank You.

He has solved the problem. Swagger ui is available at /swagger-ui/index.html going forward.


Fix containerSecurityContext for init-container

Description
Documentation states that containerSecurityContext should also affect the init-container, this patch should actually apply this previously missing feature.
Documentation already contains this as a NOTE under https://github.com/grafana-operator/grafana-operator/blob/master/documentation/deploy_grafana.md#configuring-the-deployment
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[ ] Verified independently on a cluster by reviewer

Verification steps
Ensure that deployment.containerSecurityContext is propagated to initContainer.
grafana.yaml
apiVersion: integreatly.org/v1alpha1
kind: Grafana
metadata:
  name: grafana
spec:
  client:
    preferService: true
  ingress:
    enabled: False
  config:
    log:
      mode: "console"
      level: "error"
    log.frontend:
      enabled: true
    auth:
      disable_login_form: False
      disable_signout_menu: True
    auth.anonymous:
      enabled: True
  service:
    name: "grafana"
    labels:
      app.kubernetes.io/name: grafana
      type: "grafana"
  dashboardLabelSelector:
    - matchExpressions:
        - { key: app, operator: In, values: [grafana] }
  resources:
    limits:
      cpu: 200m
      memory: 200Mi
    requests:
      cpu: 100m
      memory: 100Mi
  deployment:
    containerSecurityContext:
      allowPrivilegeEscalation: false

thanks @marulkan


How to add spacing in each cell of horizontalbar with dynamic data

Hi,
Am using HorizontalBar of chartjs in which when the data exceeds the limit 10 there is no spacing between individual cells as my data is dynamic it is from the api i cant set height and width to horizontalbar statically by setting maintainAspectRation false
Also cannot use barThickness because the data is dynamic so if there is larger amount of data there will be no space between cells
So is there any possible solution for this to set equal spacing between each cells irrespective of data

You can calculate how much space one label / row takes and update your container using JS to fit that number of rows

Please ask questions on StackOverflow: https://stackoverflow.com/questions/tagged/chart.js


Add initial Spark profiler and persistence of profiling data to S3.

Issue #, if available:
https://github.com/awslabs/emr-workload-profiler/issues/2
https://github.com/awslabs/emr-workload-profiler/issues/8
Description of changes:
Collects Spark application metrics and save them in json in text files in S3.
Example data:
[ {
"id" : "application_1513902991647_0002",
"name" : "Spark shell",
"attempts" : [ {
"startTime" : "2017-12-22T21:51:52.535GMT",
"endTime" : "2017-12-22T21:52:37.416GMT",
"lastUpdated" : "2017-12-22T21:52:37.451GMT",
"duration" : 44881,
"sparkUser" : "hadoop",
"completed" : true,
"endTimeEpoch" :<PHONE_NUMBER>416,
"lastUpdatedEpoch" :<PHONE_NUMBER>451,
"startTimeEpoch" :<PHONE_NUMBER>535
} ]
}, {
"id" : "application_1513902991647_0001",
"name" : "Spark shell",
"attempts" : [ {
"startTime" : "2017-12-22T21:50:18.436GMT",
"endTime" : "2017-12-22T21:51:06.417GMT",
"lastUpdated" : "2017-12-22T21:51:06.459GMT",
"duration" : 47981,
"sparkUser" : "hadoop",
"completed" : true,
"endTimeEpoch" :<PHONE_NUMBER>417,
"lastUpdatedEpoch" :<PHONE_NUMBER>459,
"startTimeEpoch" :<PHONE_NUMBER>436
} ]
} ]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vinayaktAWS I updated the PR per my comments. Would love to get your feedback.

@vinayaktAWS Thank your for the awesome feedback.
I addressed all of your comments and pushed another commit to address them. Let me know if it looks good.  :sunny:


Core Elements documentation

Added specific documentation for the scenario_selector, scenario, scenario_dag and data_node_selector controls.

Remove TODOs from the Core Elements home page and RelNotes.

run-time => runtime everywhere

@FabienLelaquais Can we delete the branch ?


Broken link on resources/whoami/

Docs page where broken link appears: https://www.balena.io/docs/reference/api/resources/whoami/
Sentence containing broken link:
Improve this doc (lol)
Broken url: https://github.com/balena-io/docs/edit/master/pages/reference/api/resources/whoami.md

This is a bigger issue than a simple broken link.  Any selected resource results in the same thing.  Not sure if this needs to be reclassified to Intermediate.  @vipulgupta2048

Hello @toochevere I checked this out for some time when Jasmine opened it. Currently the API documentation is generated from this file https://github.com/balena-io/docs/blob/master/config/dictionaries/resource.json, it might be a good idea for the Improve the docs button to point to this file instead. We are not there yet on the automatic generation of the API documentation. They still are updated manually. Additionally don't worry about the classification, it was only for the release party.
Do let me know if you like to help us out with automatic generation of the API documentation, @thgreasi would be the happiest person if you do

Resolve with #2362


Trim white space

This fixes the problem where unrelated content was showing for a phrase. I needed to trim the white space on the search terms.

@tzarebczan I would like you to review the related content results with this change. I can let you connect to my local instance with your app and give your thoughts before we merge and switch back IPs.


Insertion date != Observation date

Is there a way in quantum leap to distinguish between insertion date and observation date?
STH has the difficulty that for instance the querying API uses the insertion date as the basis for time related queries. This leads for instance to issues when replaying historical data to get it up to date - in these cases the insertion date is not very relevant. Basically insertion date only has operational uses, it's the observation date that most people will be interested in when looking up historical series.

Hi there!
There are many dates in the nature of the problem and things can get a bit confusing quite easily (for me at least).
For the queries, QuantumLeap will use the time_index column. Which date field that column persists is something you can configure and it's explained (hopefully) in the Time Index part of Data Insertion in the docs. If something is confusing there, let's make it better!
In short, for historical reasons QL started being developed using the dateModified attribute (a special attribute Orion Injects in the notifications if you ask for that). That is always available, but for some use-cases can be far from when the measurement was done. So, QL extended support for times added by the agents, etc.
Some NGSI models have a specific attribute to indicate the date where the observation was made (dateObserved). If that's your case, you could instruct QL to use that attribute with the use of the Fiware-TimeIndex-Attribute headers (see first option listed there in the docs). NOTE: I've seen dateObserved used as a range ("timestamp1/timestamp2"), but for now QL supports only a single valid DateTime (1 point in time).

Thanks that's a clear answer. It would be nice if QL would support ranges, or would at least have a way to handle them, because the NGSI datamodel also supports them but for us it's not a must.


Feature: Git integration

What feature or improvement do you think would benefit Files?
Integration with git is something that may add value for developers. We're inviting the open-source community to share feedback on which git features they would find useful in a file manager and how it would enhance their workflow. Design concepts are welcome as well.
Requirements
Phase 1

Display the branch name in the status bar, this will let the user know which branch is active.

Phase 2
Depending on how phase 1 is received, we can look into additional options and see which one's users are interested in. It's important to note that we don't intend for Files to be a git client. The main goal of this integration is to provide context for the user when they are working in a git repo.

Pull, it might be useful to know if there are commits on the remote branch.
Push
Sync
Switch/Create branch

Files Version
v2.4.21
Windows Version
Windows 11
Comments
No response

Fyi @onein528

I think the bare minimum would be support for switching branches. This can be achieved by adding a button/flyout to the status bar.

You mean if you open the repository in Files, you will be able to perform Git operations, such as change branch, commit, push, sync?

Push uncommitted changes

This requires UI for a commit message, not impossible but would require a lot of thought.

Git commit tree viewing in preview pane or something

A possibility but curious how it would fit into users workflow and how the UI could be integrated.

Pull
Sync

I might add these to the minimum

I'll look what I can do and try to find what can be implemented.

Could show the changes of a file in the preview pane when selected. If it isn't too much having a separate "changes" pane to show them all would properly be good too. Ideally it would look like GitHub with the addition and removals of each line.

This would be very useful

We should probably enable/disable this in settings to not clog the app for non-devs

Properly wont need a setting since outside of a directory with a GitHub link it shouldn't be shown

To create this feature, Files must have git.exe binary module.
How can I add it? Just copy? @yaira2

Is it possible to use the one already installed on the system?

@onein528 instead of "branch:", maybe we can show an icon instead (similar to Visual Studio)

Files source code is very hard to understand... I couldn't implement.
FYI
Requirements:

Use C# Git lib named LibGit2Sharp.
Even if you open the repository subfolder, Files have to display Git status.

I'm currently working on this feature. There are a couple of things we need to decide before I can continue my work.
Checkout Menu

How do you access the checkout menu? Should we use a separate button? I think that clicking on the branch name should open the menu (like in VS)?
What kind of menu should we use? A flyout or a modal?
What actions should be there? I was thinking of choosing the branch and creating a new one (what about inlcuding delete and rename?)

User's Credentials

Should we prompt users each time they try to push or pull? Should we save a token (GitHub Desktop, FluentHub) so that they don't need to log in each time?
If we choose the token option, how should we handle it? I think we might prompt users if they aren't logged in. We should also include a section in settings to allow them to log in and log out

Checkout Menu

Phase 1 shouldn't have a checkout menu, I think we should wait for feedback on phase 1 before making these decisions.

So phase 1 will be:

Pull
Push
Sync
See branch name

Overview of authentication via OAuth
Since password authentication method has already been deprecated, there’s only one way to authorize OAuth app; use Personal Access Token.
Credentials of committer
There’s no need to be authorized by GitHub. We have to show a modal to prompt a user to enter username/password. And commit and push by using libgit2sharp.
https://stackoverflow.com/questions/25084890/how-to-commit-and-push-in-libgit2sharp

Phase 1 shouldn't have a checkout menu, I think we should wait for feedback on phase 1 before making these decisions.

Since I've already written some of the code related to phase 2, should I comment that out in the PR?

Would it be possible to copy that work into a separate branch?

I updated the requirements for phase 2.

How should we differentiate the active branch in the menu? Should we put it on top? Should it be bold?

What do you think @yaira2?

Looks amazing! Can you add a fixed height and width to the flyout (200 x 200 is probably good)?

Can you customize Flyout padding?
+--------------------+
| Branches           |
| +----------------+ |
| | pr-202         | |
| +----------------+ |
| +----------------+ |
| | hotfix         | |
| +----------------+ |
|  ...               |
+--------------------+

Branches label is styled strong text block style.

Like this?

Shouldn't Branches, main, pr/12302 labels aligned in the same line?

I updated the requirements for phase 3.

Support for creating new branches, the button is already implemented in the UI. Clicking the new branch button should open a content dialog that allows the user to enter the branch name.

I'll start to work on this part of the feature

(what's the best way to display the list of changes?)

I highly recommend to use Preview Pane.

should the user be able to choose the base branch for the new one?

Yes

I'm wondering if we can implement the support for viewing the contents of a branch without actually checking out it.
I always want to check the diff between two branches or copy a file from one branch to another, but git itself doesn't support it so I always end up duplicating the whole project directory and checking out them to different branches.

We can use 'compare' of GitHub API. https://stackoverflow.com/questions/64202547/how-to-compare-two-branches-in-github-with-graphql

I'm wondering if we can implement the support for viewing the contents of a branch without actually checking out it. I always want to check the diff between two branches or copy a file from one branch to another, but git itself doesn't support it so I always end up duplicating the whole project directory and checking out them to different branches.

I can see this being useful in multipane mode, the files would have to be read only as well but this is something we can look into once we finish with the fundamentals.

Phase 4 is ready to build, this is also the final stage before we are ready to release the changes to stable.

What about deleting local branches?

What about deleting local branches?

That could be one of the actions we display in #12440


Some error messages with logs and bind mounts

Just found your project via https://noted.lol/doku-docker-disk-usage-dashboard/
great work!
Tried it in my home lab, get some error messages:

bind mounts seems to work, everything is shown but still message No access to some mounted files or directories Doku doesn't have access to some mounted files or directories and can't calculate the size of these files. appears
logs message: No access to the log files Although log files of the containers are present, the top-level directory (/) on the host machine has not been mounted into the Doku container. Therefore Doku doesn't have access to log files and can't calculate the size of these files.
nothing is shown there

my system:
Linux xxx 5.10.0-16-amd64 #1 SMP Debian 5.10.127-1 (2022-06-30) x86_64 GNU/Linux
Docker version 20.10.17
compose:
doku:
  container_name: doku
  image: amerkurev/doku
  environment:
    - BASIC_HTPASSWD=/opt/docker/doku/htpasswd
  labels:
   - ${WATCHTOWER_TRUE}
   - traefik.enable=true
   - "traefik.http.routers.doku.rule=Host(`doku.${HOSTNAME}`)"
   - traefik.http.routers.doku.entrypoints=web-secure
   - traefik.http.routers.doku.tls.certresolver=le
   - traefik.http.routers.doku.tls=true
   - traefik.http.routers.doku.priority=2
   - traefik.http.routers.doku.tls.options=default
   - traefik.http.routers.doku.middlewares=doku
   - traefik.http.middlewares.doku.headers.customresponseheaders.X-Robots-Tag=noindex,nofollow,nosnippet,noarchive,notranslate,noimageindex
   - traefik.http.services.doku.loadbalancer.server.port=9090
  networks:
   - web
  restart: always
  volumes:
   - ${TIMEZONE}
   - ${LOCALTIME}
   - /var/run/docker.sock:/var/run/docker.sock:ro
   - /:/hostroot:ro
   - ${DOCKER_PATH}/doku/htpasswd:/opt/docker/doku/htpasswd

happy to share more info if necessary

For 1. Do you have any network shares mounted directly in containers? I have that same error and assumed this was why.

@BadCo-NZ: no network shares mounted in my case

Stranger things... Okay, I'll see to it.

Same no.1 message here. In log:
level=error msg="failed to get mounted file or directory" err="readdirent /hostroot/proc/1/map_files: permission denied"
So I think there's no real problem, except the error message itself. Any way to get rid of it?

Getting the same 2 errors and results - on one machine. On another with the exact same docker-compose, it works fine with no warning messages. Both are running in WSL2.
doku:
    image: amerkurev/doku:latest
    container_name: dev-docker-doku
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - /:/hostroot:ro
    ports:
      - "9090:9090"

Hello!
Same issue on Debian 12 Swarm:
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | doku v0.0.16-5eb6b55-20230220T18:49:35
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:13Z" level=info msg="docker engine API (1.41)"
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:13Z" level=info msg="calculating size of volumes..."
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:13Z" level=info msg="starting http server at <IP_ADDRESS>:9090"
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:14Z" level=error msg="failed to get mounted file or directory" err="readdirent /hostroot/proc/1/map_files: permission denied"
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:15Z" level=error msg="failed to get mounted file or directory" err="stat /hostroot/var/run: no such file or directory"
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:41:34Z" level=error msg="failed to get mounted file or directory" err="lstat /hostroot/var/lib/docker/overlay2/a1b4cd87ad317f97c5a9b03039c946358d71d5ea15d1bad4d16477ca13c28349/merged/proc/1/fd/8: no such file or directory"
doku_docu.1.bt5d5a3qw3rn@vs-docker-dev-cn03    | time="2024-08-12T17:42:29Z" level=error msg="failed to get mounted file or directory" err="readdirent /hostroot/proc/1/map_files: permission denied"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | doku v0.0.16-5eb6b55-20230220T18:49:35
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:34Z" level=info msg="docker engine API (1.41)"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:34Z" level=info msg="calculating size of volumes..."
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:34Z" level=info msg="starting http server at <IP_ADDRESS>:9090"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:35Z" level=error msg="failed to get mounted file or directory" err="readdirent /hostroot/proc/1/map_files: permission denied"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:36Z" level=error msg="failed to get mounted file or directory" err="stat /hostroot/var/run: no such file or directory"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:02:45Z" level=error msg="failed to get mounted file or directory" err="lstat /hostroot/var/lib/docker/overlay2/28646a610660ad8cc66f0e75f944d1630d3602a78b917c639ff2443c0bcb754a/merged/proc/1/fd/8: no such file or directory"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:04:03Z" level=error msg="failed to get mounted file or directory" err="readdirent /hostroot/proc/1/map_files: permission denied"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:41:11Z" level=info msg="gracefully http server shutdown"
doku_docu.1.894klvfnl6d4@vs-docker-dev-cn03    | time="2024-08-12T17:41:11Z" level=info msg=goodbye

version: "3.9"
services:
  docu:
    image: amerkurev/doku:latest
    ports:
      - 9100:9090
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - /:/hostroot:ro

docker info
Client: Docker Engine - Community
 Version:    26.1.3
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.14.0
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.27.0
    Path:     /usr/libexec/docker/cli-plugins/docker-compose
  scan: Docker Scan (Docker Inc.)
    Version:  v0.23.0
    Path:     /usr/libexec/docker/cli-plugins/docker-scan

Server:
 Containers: 49
  Running: 15
  Paused: 0
  Stopped: 34
 Images: 25
 Server Version: 26.1.3
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: active
  NodeID: p288ckeau2auud16di6vs90j7
  Is Manager: true
  ClusterID: o5vbw61rqshravp5tw0s31p2v
  Managers: 3
  Nodes: 3
  Default Address Pool: <IP_ADDRESS>/8
  SubnetSize: 24
  Data Path Port: 4789
  Orchestration:
   Task History Retention Limit: 5
  Raft:
   Snapshot Interval: 10000
   Number of Old Snapshots to Retain: 0
   Heartbeat Tick: 1
   Election Tick: 10
  Dispatcher:
   Heartbeat Period: 5 seconds
  CA Configuration:
   Expiry Duration: 3 months
   Force Rotate: 0
  Autolock Managers: false
  Root Rotation In Progress: false
  Node Address: <IP_ADDRESS>
  Manager Addresses:
   <IP_ADDRESS>:2377
   <IP_ADDRESS>:2377
   <IP_ADDRESS>:2377
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 8b3b7ca2e5ce38e8f31a34f35b2b68ceb8470d89
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  apparmor
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 5.10.0-30-amd64
 Operating System: Debian GNU/Linux 11 (bullseye)
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 15.62GiB
 Name: vs-docker-dev-cn03
 ID: 021618bd-1c80-49d0-903a-a8f750e61b4c
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

docker version
Client: Docker Engine - Community
 Version:           26.1.3
 API version:       1.45
 Go version:        go1.21.10
 Git commit:        b72abbb
 Built:             Thu May 16 08:33:47 2024
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          26.1.3
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.21.10
  Git commit:       8e96db1
  Built:            Thu May 16 08:33:47 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.32
  GitCommit:        8b3b7ca2e5ce38e8f31a34f35b2b68ceb8470d89
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0


[WiP] Solid OIDC tests

Companion to https://github.com/pdsinterop/php-solid-auth/pull/29
Working on issues found with https://inrupt.github.io/solid-oidc-tests/

We should at least improve the error message to say 'Client ... is not registered'.

Closing this for now, follow-up in #104


feat(document): make changes to text component (DEV-1147)

resolves DEV-1147

also you'll need to fix the tests 🥳

Changes are carried out including white content on black background menu.

All done.


982 Fix Documentation for upgrade steps on a Rancher 2.6 air-gapped (originally installed and upgraded with helm template)

Fixes #982
Addresses a problem that arose with https://github.com/rancher/rancher-docs/issues/808
Reminders

See the README for more details on how to work with the Rancher docs.

Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

If the pull request is dependent on an upcoming release, make sure to target the release branch instead of main.

Description

Adds advice for users who installed Rancher with helm template. The helm template command is known to cause issues with upgrades under certain circumstances, and this is called out in our Release Notes (but see Comments below). #808 replaced commands containing helm template with helm install -- however, that still left users who had previously used helm template on the (web)hook when they attempt to upgrade Rancher and encounter an UPGRADE FAILED error. Since v2.5 wasn't affected by #808, I copied the first two lines of the upgrade command from that document, which includes the --no-hooks flag required to prevent the error from occurring. I included edits for v2.6, v2.7, and v2.8, because presumably this affects all Rancher versions going forward from v2.5.
Comments
Oddly, the information in our release notes about this includes links to dead issues in the docs repo.

Requirements for air gapped environments:
When installing or upgrading Rancher in an air gapped environment, add the flag --no-hooks to the helm template command, to skip rendering files for Helm's hooks. See #3226.
If using a proxy in front of an air-gapped Rancher instance, you must pass additional parameters to NO_PROXY. See the documentation and related issue #2725.

I'm guessing these originally linked to the old repo and got deleted at some point. I'll look into whether they were transferred to this repo later.

@btat helm template caused a problem for the helm Job that set the bootstrap password on initial install in Rancher v2.6+, but will not cause an issue on upgrade. Pending a migration path, it is therefore OK to advise users to upgrade with helm template where they previously installed Rancher via this method and are unable to use helm upgrade, my only feedback on the PR here is to remove the note The helm template command can cause problems with Helm hooks. since this is not applicable to the upgrade.

I copied the first two lines of the upgrade command from that document, which includes the --no-hooks flag required to prevent the error from occurring. I included edits for v2.6, v2.7, and v2.8, because presumably this affects all Rancher versions going forward from v2.5.

Adding those two lines is essentially reverting the changes from #828 (to address #808) and going back to telling users to use helm template, which is not what we want due to the issues the helm template + --no-hooks combo brings. The goal is to document a migration path to allow users that previously used helm template to use helm upgrade.

@btat
The PR doesn't remove anything. The other code block is left alone.
It adds a section named after the error a user would encounter if they had previously installed Rancher with helm template, and presents the code they would need to resolve it.


[ffigen] Use Apple's libclang and update doc

@mannprerak2 @liamappelbe Would any of you happen to remember why we tell people to install llvm via homebrew? If we don't need it, we should fix our documentation!

@dcharkes I'm not sure, maybe it was missed somehow. If we're sure this exists we should indeed update the documentation and the resolution paths.

Originally posted by @mannprerak2 in https://github.com/dart-lang/native/issues/1014#issuecomment-2006382085
@liamappelbe You're working with FFIgen and Apple's clang a lot, could you take a look at this?

People should only be using xcode's clang. I updated the docs a while ago to capture this: https://github.com/dart-lang/native/pull/1081. Is there something else that needs doing?

Probably not, I just went through open issues and thought this might not yet have been addressed.


Feature/ci

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Questions on pretrained weights

Hello,
I'd like to know for how many epochs the different feature extractors have been trained on COCO.
And if you know what is the mAP on COCO for these weights. Is the 42.1 on the README about Yolov2?
Thanks!

@alessandro-montanari I stop the training when the validation loss stops improving (3 grace epochs).
42.1 is the score achieved by the weight released by darknet. 28.6 is the score achieved by my implementation. You may want to refer to https://github.com/tensorflow/models/blob/master/research/object_detection/g3doc/detection_model_zoo.md for other relative comparisons.

I see, thanks.
I was wondering if you could share also the weights for the last layer for COCO. I'd like to try the network to detect the classes person and cow and see how it performs with pre-trained weights.
Also, if I want to fine tune for those two classes using my images, is it better to keep the index of the labels the same or it doesn't matter? For example, I think that we you trained on COCO person had index 0 in the list of labels. I am just wondering if somehow the network learns that people are mapped to index 0 and changing the index of the label to fine-tune the last layer would be counterproductive.
Thanks a lot!

@alessandro-montanari I only have the weights to predict 80 classes. Do you still want?

Yes, that would be nice.

@alessandro-montanari I lost the weights of Full Yolo and Tiny Yolo. Do you want other backends (MobiletNet, Inceptions, ...)?

@experiencor I want the multi class weights I am not able to perform multi class detection using the tiny-yolo-raccoon.hr5
ValueError: Cannot feed value of shape (30,) for Tensor u'Placeholder_41:0', which has shape '(35,)'
This is the error if you have the weights can you please share it with me.


Add support for Counter-Strike 2

Would it be possible to support the native version of Counter-Strike 2?

Unless it has Reflex support built-in, no. Anything else involves direct binary hooking which is indistinguishable from a cheat.

The new installment of Counter-Strike does indeed have Nvidia Reflex support, "naturally" you can only use it on Windows, on Linux the option is unavailable.

And it follows that the only way LFX can possibly work is by running on Proton, although I have no idea if they support VAC there.

I see, the game can apparently be ran on Proton and work with VAC as long as the entire Steam is installed via Flatpak.
I don't think many players will be interested in playing Counter-Strike via Proton however.
Thanks for the answer!

I am seeing the Nvidia Reflex option showing in game. Running native with nvidia rtx 3070. No latencyflex installed or running. Can anyone give any info on whether it's actually working?


Match Swagger spec with AccountState enum for list accounts API

Signed-off-by: Samuel Dacanay<EMAIL_ADDRESS>
What this PR does / why we need it: Links up Swagger Spec to the actual validation happening in the list_accounts API
Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes #603
Special notes:

curl -u admin:foobar 'http://localhost:8228/v1/accounts?state=enabled'
[
  {
    "created_at": "2020-08-04T16:59:36Z",
    "email": "admin@myanchore",
    "last_updated": "2020-08-04T16:59:36Z",
    "name": "admin",
    "state": "enabled",
    "type": "admin"
  }
]


Error when using Python-based tokenizers

Traceback (most recent call last):
  File "/net/vast-storage/scratch/vast/evlab/asathe/code/composlang/lmsurprisal/notebooks/extract_surprisals.py", line 73, in <module>
    main()
  File "/net/vast-storage/scratch/vast/evlab/asathe/code/composlang/lmsurprisal/notebooks/extract_surprisals.py", line 57, in main
    surprisals = [
  File "/net/vast-storage/scratch/vast/evlab/asathe/code/composlang/lmsurprisal/surprisal/model.py", line 133, in extract_surprisal
    surprisals = self.surprise([*textbatch])
  File "/net/vast-storage/scratch/vast/evlab/asathe/code/composlang/lmsurprisal/surprisal/model.py", line 184, in surprise
    tokens=tokenized[b], surprisals=-logprobs[b, :].numpy()
  File "/home/asathe/om2-home/anaconda3/envs/surprisal/lib/python3.9/site-packages/transformers/tokenization_utils_base.py", line 240, in __getitem__
    raise KeyError(
KeyError: 'Indexing with integers (to access backend Encoding for a given batch index) is not available when using Python based tokenizers'

Needs replication. What model was used? What tokenizer was used?

stale


Fix parsing of private fields

Q
A

Bug fix?
yes

Breaking change?
no

New feature?
no

Deprecations?
no

Spec compliancy?
yes

Tests added/pass?
yes

Fixed tickets

License
MIT

Do not parse computed and literal keys for PrivateClassProperties. By looking at the spec it should always be an Identifier afaics. This also removes the computed key as it will always be false, and it is not mentioned in the spec.
so this should not work I think:
class B {
  #"x";
  #1;
  #["as"];
}

Little unrelated:
I also noticed that our spec and types say, that key for ClassProperties (non-private) is an Identifier, but the current official spec says it is: StringLiteral | NumericLiteral | Identifier | ComputerProperty so I went with Expression, same as ClassMethod.
This all parses fine and I think it is correct:
class A {
  "b" = 1;
  3=4;
  ["as"+"s"];
}

@littledan should review the expression, we might be allowing more use cases than the expect intended

@diervo Looks like the key for a ClassMethod is an Expression. This should be the same as whatever the key of a class method is. With hindsight, Babel might've gone for a more restrictive choice that more closely encodes the grammar, so that transforms can operate with a little more confidence and determinism, but Expression is a reasonable choice that expresses the possibilities.


[Bug] tensor parallel run error

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 5. Please use English, otherwise it will be closed.

Describe the bug
python3 -m sglang.bench_latency --model meta-llama/Meta-Llama-3-8B --batch-size 1 --input 128 --output 8 --tensor-parallel-size 2
[19:01:01 TP0] Init nccl begin.
[19:01:01 TP1] Init nccl begin.
NCCL version 2.20.5+cuda12.4
Failed: Cuda error /workspace/csrc/custom_all_reduce.cuh:307 'peer access is not supported between these two devices'
Failed: Cuda error /workspace/csrc/custom_all_reduce.cuh:307 'peer access is not supported between these two devices'
[rank1]:[W924 19:01:01.260102563 CudaIPCTypes.cpp:16] Producer process has been terminated before all shared CUDA tensors released. See Note [Sharing CUDA tensors]
[rank0]:[W924 19:01:01.260656038 CudaIPCTypes.cpp:16] Producer process has been terminated before all shared CUDA tensors released. See Note [Sharing CUDA tensors]
Reproduction
python3 -m sglang.bench_latency --model meta-llama/Meta-Llama-3-8B --batch-size 1 --input 128 --output 8 --tensor-parallel-size 2
in 4xH100 GPU machine
Environment
CUDA available: True
GPU 0,1,2,3: NVIDIA H100
GPU 0,1,2,3 Compute Capability: 9.0
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.0, V12.0.140
CUDA Driver Version: 525.105.17
PyTorch: 2.4.0+cu121
sglang: 0.3.1.post3
flashinfer: 0.1.6+cu121torch2.4
triton: 3.0.0
transformers: 4.44.2
requests: 2.32.3
tqdm: 4.66.5
numpy: 1.26.4
aiohttp: 3.10.5
fastapi: 0.115.0
hf_transfer: 0.1.8
huggingface_hub: 0.25.1
interegular: 0.3.3
packaging: 24.1
PIL: 10.4.0
psutil: 6.0.0
pydantic: 2.9.2
uvicorn: 0.30.6
uvloop: 0.20.0
zmq: 26.2.0
vllm: 0.5.5
multipart: 0.0.10
openai: 1.47.1
anthropic: 0.34.2
NVIDIA Topology:
GPU0    GPU1    GPU2    GPU3    CPU Affinity    NUMA Affinity
GPU0     X      PHB     PHB     PHB     0-183           N/A
GPU1    PHB      X      PHB     PHB     0-183           N/A
GPU2    PHB     PHB      X      PHB     0-183           N/A
GPU3    PHB     PHB     PHB      X      0-183           N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
Hypervisor vendor: KVM
ulimit soft: 524288

adding --enable-p2p-check according to https://github.com/sgl-project/sglang/issues/991 seems to resolve the issue


Health Check Failing

Describe the bug
After deployment of the software sensor v27.13.1 AMI into the autoscaling group, the current settings for the health check determines the instance to be unhealthy. The autoscaling group is set to a minimum instance size of 1 so the EC2 traffic is still being successfully mirrored albeit to an "unhealthy" sensor.
Reproducing the Bug
Steps to reproduce the behavior:

Using terraform version 1.5.7
With the latest module version
AWS provider version v5.68.0
Software Sensor AMI v27.13.1

Expected Behavior
The target group health check should be able to validate the sensor is up and running through the monitoring port via the HTTP request on port 41080 https://github.com/corelight/terraform-aws-sensor/blob/main/load_balancer.tf#L16
Screenshots

Any Additional Context
N/A

Issue was fixed in #8 and https://github.com/corelight/terraform-config-sensor/pull/9


[Umbrella][KPIP-4] Support to submit batch job

Describe the proposal
See the proposal in https://github.com/apache/incubator-kyuubi/discussions/2304

Task list

[x] #2305 @turboFei
[x] #2306 @turboFei
[x] #2307 @turboFei
[x] #2308 @turboFei
[x] #2309 @turboFei
[x] #2373 @turboFei
[x] #2374 @turboFei
[x] #2375 @zhaomin1423
[x] #2376 @turboFei
[x] #2573 @ulysses-you
[x] #2377 @ulysses-you
[x] #2378
[x] #2556 @turboFei
[x] #2379 @turboFei
[ ] #2322
[x] #2628 @lightning-L
[x] #2632 @ulysses-you
[x] #2643 @lightning-L
[ ] #2646 @ulysses-you
[x] #2661 @turboFei
[x] #2674 @turboFei
[x] #2697 @turboFei
[x] #2715 @turboFei
[x] #2719 @turboFei
[x] #2765 @lightning-L
[x] #2820 @turboFei
[x] #2834 @turboFei
[x] #2859 @turboFei
[x] #2880 @ulysses-you
[x] #2911 @turboFei

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

API Design
GET /batches
Returns all the active batch sessions.
Request Parameters

Name
Description
Type

from
The start index to fetch sessions
int

size
Number of sessions to fetch
int

Response Body

Name
Description
Type

from
The start index of fetched sessions
int

total
Number of sessions fetched
int

sessions
Batch list
list

POST /batches
Request Body

Name
Description
Type

resource
The resource containing the application to execute
path (required)

proxyUser
User to impersonate when running the job
string

className
Application Java/Spark main class
string(required)

jars
jars to be used in this session
list of strings

files
files to be used in this session
list of strings

name
The name of this session
string

conf
Configuration properties
Map of key=val

args
Command line arguments for the application
list of strings

Response Body
The created Batch object.
GET /batches/{batchId}
Returns the batch session information.
Response Body
The Batch.
GET /batches/{batchId}/state
Returns the state of batch session
Response

Name
Description
Type

id
Batch session id
tring

state
The current state of batch session
string

DELETE /batches/{batchId}
Kills the Batch job.
GET /batches/{batchId}/log
Gets the log lines from this batch.
Request Parameters

Name
Description
Type

from
Offset
int

size
Max number of log lines to return
int

Response Body

Name
Description
Type

id
The batch id
string

from
Offset from start of log
int

size
Number of log lines
int

log
The log lines
list of strings

Batch

Name
Description
Type

id
The session id
string

appId
The application id of this session
string

appInfo
The detailed application info
Map of key=val,such as submitssion command,submission time.

log
The log lines
list of strings

state
The batch state
string

The livy Multi node HA for batch sessions

cc @SteNicholas  has created ticket for flink

Hi , I am interested in it , could you assign 2375-2379 to me?

Hi , I am interested in it , could you assign 2375-2379 to me?

Thanks.
You can try to take them one by one.
Because I am focus on this in my company recently, so, I need implement it in a planning time window.

Can I read the table list and table field list under the Flink catalog database?

Can I read the table list and table field list under the Flink catalog database?

It is not the goal of this umbrella, you might need interactive session instead of batch.


TLSv1.2 SNI hostname works in 1.1.0h, not in 1.1.1 master (as of 18-Aug)

I've been building & testing 1.1.1 as a MSYS2/MinGW package for use/testing in Ruby, both in Ruby's OpenSSL & Digest and also with two popular Ruby gems, Puma & EventMachine.
Current EventMachine has an SNI hostname test using TLSv1.2, which passes with 1.1.0h.  That test fails using both TLSv1.2 & TLSv1.3 when building with 1.1.1.
I'm not a strong c type, and I've seen the wiki info, so I'm not sure if this is intentional.
All the OpenSSL tests pass, and all of Ruby's OpenSSL tests pass.  I've also got the build logs if they would be helpful (I could post just the warnings), as MSYS2/MinGW is currently using gcc 8.2.0.
Thanks again, Greg

It's not intentional. We would expect SNI to work the same in both 1.1.0 and 1.1.1.
I know nothing about Ruby or the Ruby OpenSSL bindings. We might need a Ruby person to help identify where the problem lies.

@mattcaswell

We would expect SNI to work the same in both 1.1.0 and 1.1.1.

Thanks, as that was the main thing I wanted to verify.  I suspected as much, but didn't know.  I'm a Ruby person, and I seem to be able to build things, but I'm not not a serious c type.
Ruby's OpenSSL tests have the following two asserts:
def test_verify_hostname
  assert_equal(true,  OpenSSL::SSL.verify_ ("www.example.com", "*.example.com"))
  assert_equal(false, OpenSSL::SSL.verify_hostname("www.subdomain.example.com", "*.example.com"))
end

Both are passing with 1.1.0 & 1.1.1, but I'm not sure if they're client side or server side.  The EM tests appear to be server side, as in 'whom are you asking for?' calls.
For now, I'll assume this is a problem with the gem/repo EventMachine (EM).  It has it's own OpenSSL bindings, and does not use Ruby's (another popular gem Puma does the same).  I believe the EM file with all the OpenSSL calls is ssl.cpp.
I can ask one of the c types from EM to help.  Conversely, I don't know if they have access to 1.1.1, and I don't know if they're a windows user.  Hence they may not be able to repo the issue.
I'll check with them, and close this if they can't help...

https://github.com/eventmachine/eventmachine/blob/master/ext/ssl.cpp#L584 implies that this code might be called both during and post-handshake, in which case the changes in 1c4aa31d79821dee9be98e915159d52cc30d8403 may be relevant.  Are you in a position to try reverting that commit (and a75be9fd34b5d66f349186f21cd8d063d2fa87a4, which will need to be reverted first)?

@kaduk
Thanks for the reply.   I'll have a look tomorrow.

implies that this code might be called both during and post-handshake

I believe the test is calling it post handshake.  I've never worked with SNI, but what I've found about it implied that the more normal use would be to call it during the handshake.  But that's just my newbie  guess...

Are you in a position to...

I'll either revert the two, or build from just before the earlier commit.  And also review your notes in the two commits...

@kaduk
Well, not sure if it's good or bad news, but I tested with the two commits reverted on top of the current master (7d38ca3f), and SNI works in EventMachine as it does with 1.1.0.  Tested with both TLSv1.2 & TLSv1.3.
FYI - it is a Windows MSYS2/MinGW 64 bit build, gcc 8.2.0.
Thanks, Greg

@openssl/omc I think we need to come to consensus on what the post-handshake behavior of SSL_get_servername() should be.  That is, whether it reflects whether SNI was negotiated in the handshake, or whether it blindly reports what the client sent (and thus requiring the application to track whether SNI was successfully negotiated).  The current docs in master say only:

SSL_get_servername() returns a servername extension value of the specified
type if provided in the Client Hello or NULL.

which seems to support the latter version.

It seems fairly pointless to have a function that returns what the client asked for if we didn't then negotiate it?

Please to don't introduce a breaking change in SSL_get_servername().
SSL_get_servername may be called before the certificate is actually created, so before any negotiation (when intercepting TLS), for example.

We expect the use case of it to be selecting the correct
certificate. That would be during the negotation. The current
change in behaviour is after the negotation, where we didn't
expect it to be used.

@kaduk
Sorry, been busy with some (failing) CI issues elsewhere.  Thank you for looking at the EventMachine code.
I reported this simply as a change in behavior I noticed in testing another app that passed with 1.1.0, and failed one test with 1.1.1.  I've never set up a server with SNI hostname requirements, but I did try to read what I could on the subject.
Re 'after negotiation' use, if one had a single cert covering sub-domains via a wildcard, one wouldn't need to select a cert during negotiation, but might want the hostname afterward?
Again, I probably have this all wrong, so please don't go to the trouble of writing a response, a simple "it doesn't quite work that way" will suffice...
Thanks, Greg

It seems fairly pointless to have a function that returns what the client asked for if we didn't then negotiate it?

I disagree. Why would we hide the client data, regardless of the negotiation?
The client provided SNI may be used further up the chain, just like a source ip address, port or other client provided data. For routing/ACL'ing/logging/statistical purposes.
It is my understanding that haproxy can access SSL_get_servername() anytime, to provide that information in the proxy protocol (V2), to put it into a HTTP header, to log or ACL' it:
https://github.com/haproxy/haproxy/blob/master/src/ssl_sock.c#L5790
The SNI value the client asked for is not in our control, the negotiation of it on the other hand IS in our control. So my conclusion would be that the information we need from the library is what is not in our control, as opposed to the result of a negotiation.
I have never herd of a webserver logging the "negotiated" Host header as opposed to the Host header received from the client.
Note that I'm not saying I have a specific testcase which broke haproxy, I'm merely explaining why we would need to client provided SNI value as opposed to other things.

Even though the expectation was that it be used for certificate selection, and not after negotiation, the reality is that it was available after negotiation in prior releases (1.1.0 specifically). Which means that this is a behavior change between ABI-compatible releases. Undefined behavior becomes defined once released.

@MSP-Greg can you please test https://github.com/openssl/openssl/pull/7115 (and undo the previous reverts you did, if applicable)?

I have a few thoughts on this topic:

The function's behaviour should not be tied to implementation details of what we do or don't store in sessions. If the client sent an SNI hint, it should be available whether or not it was "negotiated".
IMHO when a server provides no SNI callback (effectively ignoring the client's SNI for certificate selection), it may still legitimately use the SNI value for other purposes.
One might even take the view that ignoring the SNI and returning a fixed certificate is a legitimate form of "negotiation". In which case perhaps the default when no callbacks are defined should not be SL_TLSEXT_ERR_NOACK, but that's for another day.
Why aren't we always returning the SNI value from the current handshake? The one in the session is relevant for determining whether the session can/can't be resumed, but does not otherwise seem relevant. When do we expect to find SNI set in the session but not in the current handshake?

Why aren't we always returning the SNI value from the current handshake? The one in the session is relevant for determining whether the session can/can't be resumed, but does not otherwise seem relevant. When do we expect to find SNI set in the session but not in the current handshake?

I started with this topic because we "originally" (i.e., before I started looking) were writing the received SNI value in the ClientHello directly into the SSL_SESSION, and then doing subsequent conditional adjustment in final_server_name().  This behavior was thread-unsafe, and I wanted to switch to putting the value from the wire in the SSL object only, and only writing to the SSL_SESSION when (1) SNI was actually negotiated for that session, and (2) the SSL_SESSION was safe to write to (i.e., being created for the current connection).  Remaining references to the SSL_SESSION in SSL_get_servername() are due to an attempt to minimize behavior changes as a result of the implementation change to behave in a thread-safe manner.

I think the correct solution is to always and only return the SNI value from the current handshake, and session book-keeping is an internal matter. Users who want the SNI value for the session can call an appropriate session accessor (if/when available).

Something like that is probably the best option, though I note that we had to apply  a75be9f to use the session's value for resumptions, to fix observed breakage.  That is, we cannot always only return the value from the SSL, if we want to avoid breaking existing applications.

@kaduk Something like that is probably the best option, though I note that we had to apply a75be9f to use the session's value for resumptions, to fix observed breakage. That is, we cannot always only return the value from the SSL, if we want to avoid breaking existing applications.

Why exactly would one expect resumption to work with the original SNI left out?  The server is free to ignore resumption at any time, and do a full handshake instead, and if the SNI is missing, the handshake may not lead to the same logical peer being established.  So a client that drops the SNI extension should not expect to be able to re-establish a previous session where SNI was used.  What am I missing?
What breaks if we don't "restore" missing SNI from resumed sessions?

Are we addressing client-side or server-side behaviour here?  On the client, the server name is originally set during the handshake, and then cleared if the server does not ACK. On the server I would not expect to find it set in the first place.

What breaks if we don't "restore" missing SNI from resumed sessions?

The referenced commit explictily says "this fixes the boringssl tests"

Are we addressing client-side or server-side behaviour here?

server-side behavior

The referenced commit explictily says "this fixes the boringssl tests"

Perhaps the right reaction is to allow the test in question to "fail". The test may not be portable, or appropriate.  What's the real problem?

Perhaps the right reaction is to allow the test in question to "fail". The test may not be portable, or appropriate. What's the real problem?

The failing tests are from the "ServerNameExtensionServer" case in ssl/test/runner/runner.go, which sets resumeSession: true to attempt the resumption.  I don't currently have great visibility into the underlying mechanics, but I do remember spending time thinking about whether it's correct to just disable this test when I did #6792 (and obviously I concluded that it was not correct to disable this test).

@kaduk
I added the patch on top of 'openssl req: don't try to report bits'.
Bad news is that both SNI tests (TLSv1.2 & TLSv1.3) failed.  null/nil was returned.
Thanks, Greg

The failing tests are from the "ServerNameExtensionServer" case in ssl/test/runner/runner.go, which sets resumeSession: true to attempt the resumption. I don't currently have great visibility into the underlying mechanics, but I do remember spending time thinking about whether it's correct to just disable this test when I did #6792 (and obviously I concluded that it was not correct to disable this test).

Understood, but it may, at some point, be useful to have a record of that analysis, so we understand what we're really doing, beyond making some black-box test pass...

@kaduk
So much for multi-tasking.  I work with a few build systems, and the above message about the patch not working is incorrect.  I'll rebuild & test again.  Sorry for the mistake, Greg

@MSP-Greg thanks for the update, and don't worry about the delay -- the discussion on that PR is going to take some time to resolve anyway.
(When you do report back, please include the commit hash(es) that you used, as that PR did get multiple updates today.)

I've managed to recreate this issue. I ran tests with the patch from #7115 applied (I think that is necessary to fix the issue too). The problem is here:
https://github.com/openssl/openssl/blob/cd3b53b8f85ad66336936073d822b3315e0ddd4f/ssl/ssl_lib.c#L3553-L3570
This code was introduced by PR#3783 in an attempt to clear any SNI that was incorrectly set on the server at configuration time. Unfortunately doing it in SSL_do_handshake() is just the wrong place - it can get called multiple times during the course of the handshake, and therefore any SNI gets cleared mid-handshake.

@kaduk's original fix has been merged (which is needed). An additional fix for this is in #7149.

@kaduk @vdukhovni @mattcaswell
Thank you for your work on this.  The four main Ruby items building/compiling with OpenSSL (Ruby master/trunk, Ruby OpenSSL gem, EventMachine, & Puma) are building and passing all tests.
This was using a build from master done after:
f01344c  Do not reset SNI data in SSL_do_handshake()

Fantastic!

We are facing an issue related with SSL_CTX_set_tlsext_servername_callback() API not getting fired for TLS1.3 client-hello even server_name extension present in client-hello message.
Accoring Openssl man page https://www.openssl.org/docs/man1.1.1/man3/SSL_get_servername.html.
SSL_CTX_set_tlsext_servername_callback() should work for all versions(TLS1.3 also).
Please revert back if someone has any knowledge.

The callbacks work fine in Postfix:
https://github.com/vdukhovni/postfix/blob/master/postfix/src/tls/tls_misc.c#L1043-L1046
You'll need to look more closely at your application code.


allow "test" to be anywhere in a filename

by default, nose looks for a file with "test" at the beginning of the
name, or anywhere in the filename after a word boundary like underscore
or dot.
http://nose.readthedocs.org/en/latest/api/config.html

Would it maybe work just to copy-paste that regexp? In #27 it was said that (?:^|[b_.-])[Tt]est) is Nose's regex, but I see here that it's a bit more complex. I decided to use a simpler (less permissive) regex, but maybe I shouldn't have tried to be a smartass and I should have just used Nose's regex directly.

I'm not sure what the equivalent vim regex syntax would be.  The nose regex actually has a \b to match word boundaries and also includes the operating system directory separator (/ for unix, \ for windows).  I decided to make my pull request just look for the word "test" because it seemed simpler.
I've always named my test files as example_test.py so that bash's tab complete is easier.  Any regex that works with that is ok with me.  :)

Vim's regexes should work like POSIX regexes if you add \v at the beginning. Could you maybe update the regex to Nose's one? I think then we can be certain.

Thanks!


populate_db: Limit user_profiles for private messages to zulip realm.

These are used for creating huddles and private messages (and some UserPresence objects). It'd be really weird, and potentially create some Messages that break our assumptions, for this to end up involving users in multiple realms.
I believe currently this hasn't been happening, because when this line runs, there are only users in "zulip" realm and system bots in "zulipinternal" - but the query has been excluding bots already.
Still, this query should be explicit about grabbing users from a single realm. This will also be helpful for the work adding the denormalized Message.realm field - so that the realm of Message objects that get manually created in generate_and_send_messages can be simply set to "zulip" with confidence that it's correct.

Nice, merged, thanks @mateuszmandera!


Support different widths for left and right side menus

I'm working on an app where both left and right menus must be available, but with different widths.
So basically I've created 2 instance vars to set the width of each side separately.
Feel free to comment, thanks :)

Hi @frimoldi,
Thanks for suggesting these changes.
One of the goals of SideMenu was to build an extremely simple yet highly flexible control that developers could drop into their project and get running with little to no effort.
While your suggested changes offer up greater configuration flexibility, they come at a cost of making the existing configuration more complicated. Now, instead of setting a single side menu width, developers have to set them both individually. My assumption is that most developers would want both sides to be the same width as the most simplistic and straight-forward option. For this reason, I'm not going to merge this PR.
If a developer wanted to add this functionality without modifying the library, it is already possible through subclassing UISideMenuNavigationController and setting the menuWidth property on viewWillAppear of each menu.
Feel free to reply with your thoughts to this.

Fair enough. I'm not sure if I agree that the most common scenario is to have both menus of the same size, but I get your point :)


RuntimeError: invalid argument 4: Index tensor must have same dimensions as input tensor at /pytorch/aten/src/THC/generic/THCTensorScatterGather.cu:16

Hi!  When I ran "python train_transmitter.py", I had the following problem:

Configuration: python 3.7.9, pytorch 1.0.1, torchvision 0.5.0
Set up the environment according to the instructions you gave.
Thanks for your help!

@leyi-123 It's wired. Could you print the values of pos_seq_len_expand here?

@leyi-123 It's wired. Could you print the values of pos_seq_len_expand here?

Sorry I could't understand what "pos_seq_len_expand" means. If it refers to the error, it will be shown as follows :
Traceback (most recent call last):
File "train_transmitter.py", line 145, in
TrainLoop(opt).train()
File "/home1/zhenli/Persona-Dialogue-Generation/parlai/scripts/train_model.py", line 512, in train
world.parley()
File "/home1/zhenli/Persona-Dialogue-Generation/parlai/core/worlds.py", line 663, in parley
batch_act = self.batch_act(agent_idx, batch_observations[agent_idx])
File "/home1/zhenli/Persona-Dialogue-Generation/parlai/core/worlds.py", line 636, in batch_act
batch_actions = a.batch_act(batch_observation)
File "/home1/zhenli/Persona-Dialogue-Generation/agents/transmitter/transmitter.py", line 858, in batch_act
self.init_cuda_buffer(batchsize)
File "/home1/zhenli/Persona-Dialogue-Generation/agents/transmitter/transmitter.py", line 854, in init_cuda_buffer
raise e
File "/home1/zhenli/Persona-Dialogue-Generation/agents/transmitter/transmitter.py", line 843, in init_cuda_buffer
sc = self.model(input_dummy, None, None, output_dummy, None)[1]
File "/home1/zhenli/anaconda3/envs/p2bot/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in call
result = self.forward(*input, **kwargs)
File "/home1/zhenli/Persona-Dialogue-Generation/agents/transmitter/gpt/model.py", line 99, in forward
last_state = hidden_states.gather(dim=1, index=pos_seq_len_expand).squeeze(dim=1)
RuntimeError: invalid argument 4: Index tensor must have same dimensions as input tensor at /pytorch/aten/src/THC/generic/THCTensorScatterGather.cu:16

@leyi-123 find the 99th line in Persona-Dialogue-Generation/agents/transmitter/gpt/model.py, and print the value of the size of pos_seq_len_expand and hidden_states as:
print(hidden_states.shape)
print(pos_seq_len_expand.shape)

And post the log here.

@leyi-123 find the 99th line in Persona-Dialogue-Generation/agents/transmitter/gpt/model.py, and print the value of the size of pos_seq_len_expand and hidden_states as:
print(hidden_states.size())
print(pos_seq_len_expand.size())

And post the log here.

hidden_states.size():
torch.Size([102, 40516])
pos_seq_len_expand.size():
torch.Size([2, 1, 768])

@leyi-123 Could you check again if you have uninstalled the official transformers lib and installed the custom one from https://github.com/SivilTaram/transformers.git ? The size of hidden_states in my environment is as torch.Size([2, 258, 768]).

@leyi-123 Could you check again if you have uninstalled the official transformers lib and installed the custom one from https://github.com/SivilTaram/transformers.git ? The size of hidden_states in my environment is as torch.Size([10, 258, 768]) in default setting.

It's working! Thank you very much!

@leyi-123 Glad to hear that!


Dynamically create dataset setting validation.

#1292 made it easier to validate new dataset settings. If we add a new dataset we will have to:

add the dataset's working tables to pc.PUDL_TABLES
add the dataset's working partitions to pc.WORKING_PARTITIONS
create a settings class by calling NewDatasetSettings = create_dataset_settings("new_dataset")
Add any additional validation methods to NewDatasetSettings.
Add NewDatasetSettings to DatasetSettings.

This isn’t that bad but I think we could improve in a few areas:

When a user adds a new dataset they will have to specify the table schemas. For each dataset, pc.WORKING_TABLES could be inferred from the dataset table schemas.
Instead of calling create_dataset_settings(dataset_name) for every dataset in pc.WORKING_PARTITIONS, we could just loop over each dataset in WORKING_PARTITIONS.
DatasetSettings could be dynamically generated by finding all Subclasses of GenericDatasetSettings.

Some of these improvements are covered in #1409 and #1410

I haven't interacted with the pydantic settings classes in a while. I'm not sure if these proposals are still relevant.


Complex usage with draggable items id collision

Hey! I’m from @httpie and we are currently working on enhanced d&d in the app. I met one case and want to discuss it here.  What we have: there are items inside collections and they should be able sorted. Also we should be able to move items from one collection to another one. The problem that we can have two instances of the same collections on the screen in the same time.
I prepared sandbox with the similar case: https://codesandbox.io/s/exciting-lena-9cf8f7. Here we can sort items inside collections and can move item from the second collection to the first one: it works only for the second instance on the right side. Also there is bug with the overlay. And the nature of both is the same: items should have unique IDs in the same DndContext according to the documentation.
We can solve it by providing some unique prefix to items, for example and it’ll fix overlay: https://codesandbox.io/s/competent-bash-3iery1, but break item drag between collections with different prefixes. As I understand it’s because active still has old item id, with the wrong prefix and it don't match with any item in the updated collection.
So the final questions:

is it correct way to achieve what we want (I mean using prefixes)?
How we can update active data during drag and should we? Is there any other option?

I think the prefixes is the right way to go. Regarding the other issue, would it be possible for you to extend your onDragOver and/or onDragEnd logic to ensure the correct element is moved to all appropriate collections no matter the prefix? Because you have full control over how the data for all collections changes on the dragOver and dragEnd events, I'm just wondering if the solution might be in extending the logic there rather than updating the active data.

I use onDragOver here for moving item from one collection to another one and onDragEnd here for reordering items inside collection. When I move item from collection in the sidebar (which has prefix sidebar) to the collection on the right side (which has prefix main) reordering stops working. It looks like react re-renders collections and appended item on the right side now has id: main-${id} while active element still has sidebar-${id} id and that's why it breaks collision detection. And collision detection works with the active which is stored inside of DndContext component. This is my assumption and I'm trying to understand how to better solve it and get necessary result.

@clauderic It's really rude to mention you and I'm sorry for that, but I really need help here. It seems only you can know how to properly handle such case, since you are an author


[670] Fix error stying on outcome date

Context
https://trello.com/c/d4eLaHp9/670-errors-on-the-conditional-date-are-showing-on-the-parent-not-the-item-with-the-error
Changes proposed in this pull request
Errors regarding the outcome date field for appear on the date field itself, rather than the radio button group as a whole.

Guidance to review

Visit /trainees/:id/outcome-details/outcome-date
Select 'On another day' and enter either an invalid date or leave it empty
Check that the error text appears just about the date field, and that the date field itself is styled red.

 Errors on the conditional date are showing on the parent, not the item with the error


Remove JLine as dependency

Fixes #104
(Made this a separate PR from #105 in case there are conflicts due to project restructuring)

Closed via https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/commit/c10206d41bf1d3b85e7ef0290c740232ca68a1d9


[BUG] widget gets placed in the wrong spot in the dashboard

Environment
Self-Hosted (Docker)
System
Docker version 24.0.5
Version
Dashy version 3.1.0
Describe the problem
on the 3rd row the widget skips 2 columns. when i dont think it should be doing that.
Additional info

Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

Could you upload your conf.yml?


Preview do not run

After having installed aglio and trying to launch the preview, here is the errors i have :
build@ – Cannot find module '/home/<user>/.atom/packages/api-blueprint-preview/node_modules/pathwatcher/build'
build@ – Cannot find module '/home/<user>/.atom/packages/api-blueprint-preview/node_modules/pathwatcher/node_modules/runas/build'

(those path exists)
api-blueprint-preview 0.7.0
atom 1.6.1

Fixed by rebuilding package & restarting Atom


duplicate errors are reported

Some errors appear in duplicate on the CLI and in the IDE. I have no idea if this is new or unexpected, but I never noticed it before.
For example, if you change class HashMap to class XHashMap, you get (among others):
./source/ceylon/collection/HashMap.ceylon:123: error: could not determine type of function or value reference: 'bucket'
                    store[index] = bucket.clone();
                                   ^
./source/ceylon/collection/HashMap.ceylon:123: error: could not determine type of function or value reference: 'bucket'
                    store[index] = bucket.clone();
                                   ^

and

fixed.


Performance under Tensorflow is almost 3x slower than Caffe

Could you give some performance tuning document?
I used the LMDB data for TensorFlow. 30% time was spent on data queueing.
I tired NCHW and performance is 2x slower than NHWC baseline.

hi @CFAndy,
any advance / more info on this?


link parameters omission

hey, i like bb.intercept, i just have one question,
i have a link tag which uses 'example.com/a?page=1' as a href,
when i start bb.intercept and click the link, i get navigated to: 'example.com/a' is there a way  to get navigated to the whole uri?

I'll look into this. It might be a bug. Thanks @elgubenis !

Resolved in #22


Misc fixes

I have updated (hopefully) a few parts of the website.
Questions remaining:

Do we need pages/faq.md?
I believe that pages/comprehensive.md should be reworded or even rewritten. The wording in the table doesn't flow well.
I believe that pages/drop-in-admin.md could be replaced by a direct link to the Padrino Admin guide or there could be some way to reuse that part in the guide itself.
Is Padrino Admin ORM agnostic the same way Padrino is (ie. are ORM adapters available for Padrino available for Padrino Admin as well?)

@nesquena Mind taking a look at this too? I'd like to keep working on docs for now until the new site is up (any ETA on that?).

Is Padrino Admin ORM agnostic the same way Padrino is (ie. are ORM adapters available for Padrino available for Padrino Admin as well?)

No. It only understands these:
:activerecord
:minirecord
:datamapper
:couchrest
:mongoid
:mongomapper
:sequel
:ohm
:dynamoid

For Padrino 0.12.x default renderer is Slim.
For Padrino ~> 0.13.0 default renderer is None with supported Ruby Stdlib ERB.

It should be fine now.


Agreement Holder is able to initiate and get desired amendments to staff

Applies to all amendment types

[ ] option visible to start amendment
[ ] AH can edit plan (any content open to AH)
[ ] option to save draft of amendment
[ ] option to submit the amendment

[ ] prompts for explanation of amendment
[ ] opportunity to select amendment type
[ ] language is clear on difference between amendment types

[ ] signature gathering workflow initiated

[ ] multi AH sub-workflow initiated if relevant

[ ] option to change mind before submitted and clear it out of the system (completely delete it)
[ ] immediately after "submit" option selected it is clear that an amendment is being created (no spinning wheel or other processing indicator makes user want to click repetitively)
[ ] immediately after submit successful the header bar changes to indicate the amendment creation/status (so AH knows it has happened)

Specific to Minor amendments

[ ] once signed by all the amended version becomes current legal version (could be "undone") -- easy to identify as current
[ ] option to recall an amendment after it has been submitted to staff but before it enters staff review)

Specific to Mandatory amendments

[ ] amendment is "draft" and no change is made to current legal version
[ ] AH able to respond to feedback from staff related to the amendment
[ ] feedback/update/approval process as for initial plans functions

@LisaMoore1 Is there a reason you closed this?

Because the other epic (#471) with the associated issues is probably more useful at this point. Feel free to do whatever makes the most sense to you.

@LisaMoore1 Oh gotcha, I didn't see that. Can you copy the checkboxes you put in this issue into #471? I found them pretty helpful.

@calebissharp Done.


Tests

add tests for logic to make sure we don't break things on accident

Pretty sure this has been done too

not really, the only thing we test is a very specific set of settings and we just make sure 2 different runs with the same seed+settings produce the same spoiler log

#579 is a step towards this