Issue updating from 5.0.0 to 6+

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
It's probably not a bug or feature request but we encounter difficulties updating the package.
We didn't find any kind of migration guide - That's why I opened as feature request.
We updated from version 5 to version 6.0.1 as part of an update to .net6.
We managed to do most of the crossover to the new version but there is 1 thing we still cannot seem to find how to do.
We we’re using the function MapVersionedODataRoute like so:

And we can’t seem to find how to recreate this.
What we found was something to do with AddRouteComponents, along the lines of:

but this code is called from the ConfigureServices function that does not have access to the model builder that we need for the EDM model, as opposed to the old code that ran in the Configure function and did have access to it. Our EDM model is complicated and is edited in many places so the examples of creating a GetEdmModel function in the same file that creats the model is not a possibility for us at this time. We need some way to access the model that is created elsewhere, like the old version.
Any change you can point me to somewhere that will help us solve this?
Thanks
Describe the solution you'd like
Direction about the changes need to be made or a guide about changes need to be done for the upgrade
Additional context
No response

Good question. The common configuration is still expected to be through IModelConfiguration, but - just as before - you don't have to use them. The VersionedODataModelBuilder is still a service registered in the container, but it's less obvious where you would retrieve it can continue to configuration. This is now accessible via ODataApiVersioningOptions.ModelBuilder:
// add OData services and global configuration
// note: AddRouteComponents here will be ignored
builder.Services
       .AddControllers()
       .AddOData( options => options.UrlKeyDelimiter = ODataUrlKeyDelimiter.Parentheses );

builder.Services
       .AddApiVersioning()
       .AddOData( options =>
        {
           // options.ModelBuilder.GetEdmModels() would be equivalent, but there is intentionally
           // no way to pass down the EDM models because it's not necessary. if you need to further
           // configure the EDM, the simplest approach is to use the post-creation callback that has
           // always been there
           options.ModelBuilder.OnModelCreated = ( builder, edm ) =>
           {
               // this will be called once for each non-empty EDM per API version
           };

           // you MUST register version-specific OData routes here. the OData team didn't take
           // any of my feedback to make their design extensible, which ultimately led down a
           // a path where I had to reimplement parts of the setup because it's impossible to get
           // in front or change what OData does by default. I kept many names and setup similar
           // to the built-in OData method so that it feels familiar to an OData user
           options.AddRouteComponents( "{projectName}/odata/v{version:apiVersion}" );
        } );

I suspect that should cover most scenarios, but if you really need to get in front of creating the EDMs, then you would have to extend VersionedODataModelBuilder, override GetEdmModels, and replace it the DI container.
I have an issue tracking the lack for documentation for some of the 6.0+ changes that I hope I'll be able to tackle in the near future. This affects OData the most because OData 8.0+ itself is quite different.

Which paths? Do you have a repro? You've only shared fragments of the configuration, which makes it difficult to troubleshoot. You should be able to find which path is incorrect from the error to give you a clue. The OData OpenAPI example provides an end-to-end example of how to set combine all of the pieces together.

Checking in one more time. Were you able to resolve your issue?

No 😊,
We wanted to dig more and provide more information,
First - We encounter kind of duplications in the models and the API descriptions.
Let's start with our dependencies:
<ItemGroup>
  <PackageReference Include="Asp.Versioning.OData.ApiExplorer" Version="6.1.0" />
  <PackageReference Include="LinqKit.Core" Version="1.2.2" />
  <PackageReference Include="Microsoft.AspNet.OData" Version="7.6.3" />
  <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="2.2.0" />
  <PackageReference Include="LaaS.ServiceFabric.Configuration" Version="1.0.4" />
  <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.20.0" />
  <PackageReference Include="Microsoft.ApplicationInsights.ServiceFabric" Version="2.3.1" />
  <PackageReference Include="Microsoft.ApplicationInsights.ServiceFabric.Native" Version="2.3.1" />
  <PackageReference Include="Microsoft.ApplicationInsights.SnapshotCollector" Version="<IP_ADDRESS>" />
  <PackageReference Include="Microsoft.AspNetCore.OData" Version="8.0.11" />
  <PackageReference Include="Microsoft.AspNetCore.ResponseCompression" Version="2.2.0" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="5.0.14" />
  <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="5.0.14">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>
  <PackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="5.0.1" />
  <PackageReference Include="Microsoft.ServiceFabric" Version="7.2.445" />
  <PackageReference Include="Microsoft.ServiceFabric.AspNetCore.Kestrel" Version="4.2.445" />
  <PackageReference Include="Microsoft.ServiceFabric.Services.Remoting" Version="4.2.445" />
  <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />
  <PackageReference Include="ProjectServiceGateway" Version="1.1.20" />
  <PackageReference Include="Swashbuckle.AspNetCore.Annotations" Version="5.6.3" />
</ItemGroup>

In order to make swagger work we needed to use the c.CustomSchemaIds(type => type.FullName + type.GetHashCode());

After that it loads but we see the dups..

and

(This is just part of the app - we have multiple APIs and models)
We have an odataController which all the controllers inherits from:
using System.Linq;
using DataSearch.Common.Authorization;
using DataSearch.Contexts;
using DataSearch.Models;
using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore;
using Microsoft.AspNetCore.OData.Routing.Controllers;
using Microsoft.AspNetCore.OData.Query;

namespace DataSearch.WebApi.V1
{
    [Produces("application/json")]
    public class ODataController<T> : ODataController where T : class, IHaveProjectName
    {
        protected readonly DataSearchContext Context;

        protected ODataController(DataSearchContext context)
        {
            Context = context;
        }

        [HttpGet]
        [Authorize(Role.Reader)]
        [EnableQuery(MaxExpansionDepth = 4, MaxNodeCount = 1000)]
        public virtual IQueryable<T> Get()
        {
            Context.GlobalSearchMode = false;
            var res = Context.Set<T>().AsNoTracking();
            return res;
        }
    }
}

Do you have any idea about the duplications and the $count?
Thanks for checking if it was resolved

The first issue I see is that you're referencingMicrosoft.AspNet.OData (7.6.3). That package is for ASP.NET Web API. You should be getting warnings from NuGet about that package. I suspect no part of it is actually used, but it shouldn't be there nevertheless.
There should be no need to use CustomSchemaIds. It's possible that your OData routes are incorrect. I recommend adding:
if ( app.Environment.IsDevelopment() )
{
    app.UseODataRouteDebug();
}

And then you can navigate to ~/$odata. That will show the OData route table. If you see a route listed as non-OData, then you know the configuration is incorrect. I've run into that many times.
I don't have a lot more to go one. Sharing the relevant configuration might be helpful. A simple, stripped down repro would be best. Let's start with that.

This is sample of the Odata Route table

Also ...
I've used the AssemblyQualifiedName and it looks weird - 2 schemas for each model

By looking on those images any chance you can point me why it can happens ?
Those dups started only after updating the packages and minor changes in the code.

Maybe the model configuration file will give a clue ...
using System;
using System.Linq.Expressions;
using DataSearch.Models;
using Asp.Versioning.OData;
using Microsoft.OData.ModelBuilder;
using Asp.Versioning;

namespace DataSearch.Contexts
{
    public class ModelAllConfigurations : IModelConfiguration
    {
        public void Apply(ODataModelBuilder builder, ApiVersion apiVersion, string routePrefix = null)
        {
            if (apiVersion != new ApiVersion(1,0))
            {
                return;
            }

            builder
                .AddEntityWithOptions<Bucket>()
                .AddEntityWithOptions<Activity>();
        }
    }

    public static class ODataModelBuilderExtensions
    {
        public static ODataModelBuilder AddEntityWithOptions<T>(this ODataModelBuilder builder, Expression<Func<T, dynamic>> keyDefinitionExpression = null, string nameOverride = null) where T : class
        {
            var name = string.IsNullOrEmpty(nameOverride) ? typeof(T).Name : nameOverride;
            var entityTypeConfiguration = builder.EntitySet<T>(name)
                .EntityType;
            if (keyDefinitionExpression != null)
            {
                try
                {
                    entityTypeConfiguration.HasKey(keyDefinitionExpression);
                }
                catch (Exception)
                {
                    Console.WriteLine($"Entity Name: {name}");
                    throw;
                }
            }

            entityTypeConfiguration
                .Filter() // Allow for the $filter Command
                .Count() // Allow for the $count Command
                .Expand(4) // Allow for the $expand Command
                .OrderBy() // Allow for the $orderby Command
                .Page() // Allow for the $top and $skip Commands
                .Select(); // Allow for the $select Command
            return builder;
        }
    }
}

When I comment the whole class I get just the models without the V_<version>_<guid>.DynamicModels and the  options.ModelBuilder.OnModelCreated = (builder, edm) => {} is not called
We also using entity framework if it has any connection...
So I didn't catch if what I need is those with the V_ or the others...
Sorry for the amount of questions ... trying to figure it out because before we changed to .net 6 and updating the nuggets it worked well
Thanks!

This looks right, but something still seems to be missing. The model should only be substituted if the specific type doesn't match the EDM. This usually happens by applying .Ignore which I don't see. The other thing that is strange is that your configuration only applies if the API version is 1.0. That is allowed, but then it should be impossible to get multiple models. The only other possibility is that have different configurations for API version and route prefix. This was implied by the route templates I saw above. I haven't tried mixing different EDMs with the same entity shape. If the same type, and hence name, are useful from multiple sources in the same API version that will always be a problem for OpenAPI. The names in the schema have to be unique. If they are exactly the same name and configuration, in theory, that should work, but I've never tried such a combination.
What does the configuration for
builder.Services.AddControllers().AddOData();

and
builder.Services.AddApiVersioning().AddOData();

look like? I'll be surprised if there isn't any issue there.
You also still didn't mention how you are using annotations or if it's just referenced. Any other source of API Explorer information or input to Swashbuckle has the potential to provide incorrect or overriding information.

            services.AddControllers(options =>
            {
                options.InputFormatters.RemoveType<XmlSerializerInputFormatter>();
                AddFilters(options, filterTypes);
            })
            .AddOData(options =>
            {
                options.UrlKeyDelimiter = ODataUrlKeyDelimiter.Parentheses;
            })
            .AddJsonOptions(opt =>
            {
                opt.JsonSerializerOptions.PropertyNamingPolicy = null;
                opt.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter());
                opt.JsonSerializerOptions.IgnoreNullValues = true;
            });
            services.AddApiVersioning(options => options.ReportApiVersions = true)
            .AddOData(options =>
            {
                options.ModelBuilder.OnModelCreated = (builder, edm) =>
                {
                    // this will be called once for each non-empty EDM per API version
                    var aaa = 1;
                };
                options.AddRouteComponents("{projectName}/odata/v{version:apiVersion}");
            })
            .AddODataApiExplorer(options =>
            {
                // add the versioned api explorer, which also adds IApiVersionDescriptionProvider service
                // note: the specified format code will format the version as "'v'major[.minor][-status]"
                options.GroupNameFormat = "'v'VVV";

                // note: this option is only necessary when versioning by url segment. the SubstitutionFormat
                // can also be used to control the format of the API version in route templates
                options.SubstituteApiVersionInUrl = true;

            });

Good news 😊
I found that there was two controllers which had [Route("something")] - We did it because there was OdataRoutePrefix before
When I removed those attributes the duplicates disappeared
hope this issue will help someone in the future
Thanks a lot.
We just stayed with the $count routed which we eliminated somewhere in the process of the initialization


[Feature Request] OpenAI organization account setting

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

Motivation

Solution
Currently, I am utilizing an organizational account with OpenAI. However, I have encountered an issue where there seems to be no option available to configure my organizational account settings as outlined in the OpenAI documentation. Below is the code snippet I am using:
        self.client = OpenAI(
            api_key=get_config("openai", "api_key"),
            organization=get_config("openai", "organization_id")
        )

Could you please consider adding support for the organizational API in future updates? This feature would greatly enhance usability for organizational account holders. Thank you!
Alternatives
No response
Additional context
openai official document:
https://platform.openai.com/docs/api-reference/authentication
section:https://platform.openai.com/docs/api-reference/organizations-and-projects-optional

close this issue since the setting can be done by using environment variables


Fall back to ENV['RAILS_ROOT'] and Dir.pwd

Fixes https://github.com/bkeepers/dotenv/issues/155
/cc https://github.com/rails/rails/issues/14620

:+1:

Great, thanks! Would be good to wrap this up into a point release.

Thanks! Just wanted to confirm that a near-fresh Rails 4.2 app had the "no method #join for nil" issue, and the 2.0.0.beta released fixed it.


VLAZ: Watch 11xplay

VLAZ requests the watch of the watch_keyword 11xplay. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

11xplay has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Path of Glouphrie - Not all combos of values valid for transfer

Currently the helper believes that all combinations of lower-value shapes are valid outputs of the exchanger, so long as they equal the input value. Unfortunately it seems that that's not the case, for example for an input of 10, the only outputs I could produce were:

Orange square + circle
Violet circle + red triangle
Yellow triangle + red circle
Orange pentagon
Indigo circle + green circle
Orange tri + green circle

The helper at the time was trying to get me to get a blue circle/red pentagon, which technically could exist due to 5 + 5, but didn't appear in over 100+ attempts.
At some point we should validate the potential outputs of each value input.

Just confirming this, I've started building up a list of what shapes can actually be traded in, testing one exchange at a time (with a little debug shell to actually keep track of what's been seen)
		// Welcome to the RuneLite Development Shell
// Everything executed here runs on the client thread by default.
// By default client, clientThread, configManager and log are in scope
// You can subscribe to the Event Bus by using subscribe(Event.class, ev -> handler);
// and you can access things in the global injector module with var thing = inject(Thing.class);
// Press Ctrl+R or F10 to execute the contents of this editor

private int getWidgetItemId(int groupId, int childId)
{
    var widget = client.getWidget(groupId, childId);
    if (widget == null)
    {
        return -1;
    }

    return widget.getItemId();
}

public void onGameTick(final GameTick ignoredEvent, HashMap<Integer, HashSet<List<Integer>>> xd)
{
    var exchangeInput = getWidgetItemId(849, 8);
    var exchangeResultTL = getWidgetItemId(849, 21);
    var exchangeResultTR = getWidgetItemId(849, 24);
    var exchangeResultBL = getWidgetItemId(849, 27);
    var exchangeResultBR = getWidgetItemId(849, 30);

    if (exchangeInput == -1) {
        return;
    }

    var exchange = new ArrayList<Integer>();
    if (exchangeResultTL != -1) {
        exchange.add(exchangeResultTL);
    }
    if (exchangeResultTR != -1) {
        exchange.add(exchangeResultTR);
    }
    if (exchangeResultBL != -1) {
        exchange.add(exchangeResultBL);
    }
    if (exchangeResultBR != -1) {
        exchange.add(exchangeResultBR);
    }

    if (exchange.isEmpty()) {
        return;
    }

    xd.computeIfAbsent(exchangeInput, sv2 -> new HashSet<>());
    var res = xd.get(exchangeInput).add(exchange);

    if (!res) {
        return;
    }

    for (var entry : xd.entrySet()) {
        var inner = new ArrayList<String>();
        System.out.format("xd.put(%d, new HashSet<>(List.of(", entry.getKey());
        for (var innerEntry : entry.getValue()) {
            inner.add(String.format("List.of(%s)", innerEntry.stream().collect(StringBuilder::new, (builder, n) -> builder.append(',').append(n), (x, y) -> x.append(',').append(y)).substring(1)));
        }
        System.out.format("%s)));\n", inner.stream().collect(Collectors.joining(", ")));
    }
}
var xd = new HashMap<Integer, HashSet<List<Integer>>>();

subscribe(GameTick.class, ev -> onGameTick(ev, xd));

So far I've captured all exchanges from 18 of the 28 discs.


Enable collision of SM created from RMC

to enable collision, SM must have a valid SectionInfoMap for each SM sections.
Now you can enable the 'Use Complex Collision As Simple' option!!
(you could merge bunch of code blocks of mine and the above for-loop)

Ok, so I accepted this PR but did a bit more work to it. First it wouldn't compile in engines 4.13 or older, due to a change in the materials that wasn't accounted for.  Also I took it a step further to go ahead and reconfigure the bodysetup to enable collision by default. I'll do some additional work soon to support simple collision with some of the upcoming work on that.


AQCU-661: Axis issues when different parameter than primary

Coverage decreased (-1.4%) to 86.447% when pulling bbfa2db88b6a1d972e1208cca8e66a3f5bd3de37 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

checking this out now..

will keep looking tomorrow, have to go for now and didn't get through it all.

Coverage decreased (-1.5%) to 86.315% when pulling 601367022ba09f2d08cccc8e81698188f48e0924 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

Coverage decreased (-1.6%) to 86.216% when pulling b27715b28848cea14446a3d193a5e8d04ae6595c on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

Coverage decreased (-1.7%) to 86.161% when pulling 1d477ddddcc7d93d1af408fffb6b6a93985742e0 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

Coverage decreased (-1.7%) to 86.161% when pulling 1d477ddddcc7d93d1af408fffb6b6a93985742e0 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

Coverage decreased (-1.7%) to 86.171% when pulling 724992aa3991b5cd401155692fe041d67d1630b9 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.

Coverage increased (+0.4%) to 88.289% when pulling 4ecb61946f2e20b73e19393f46b7c32be4ae9950 on zmoore-usgs:feature/third-y-axis into 941de8f845ced1de2fe3807cdeb971a9b9dfa7f6 on USGS-R:master.


rectangles: update with 1xN, Nx1, 1x1 cases

In the final canonical test case for this exercise, we count rectangles whose sides have length 1. Such rectangles have slightly odd-looking representations:
++
++

+-+
+-+

++
||
++

etc.
I updated the example to include a rectangle of this type to avoid an unpleasant surprise at the end of the exercise. Thoughts?

Adding tests for 1 by x rectangles would be a good idea.

Good call! Should I take care of that in this PR or a separate one?

I would not object to it going in this PR. Personally, I have in the past separated PRs if I thought all of the following were true:

The README change will go through quickly
The JSON change might not (it might need more review, etc.)
It is desirable to merge the README change ASAP because not doing so causes confusion for students, etc.

Ok, thanks for the guidance! I'll add those tests and we can iterate from there 👍

@petertseng @Insti revised with new canonical test data :)

The last canonical test for which track?  The last canonical test I see is here so I am a little confused.  Or is it the last isosceles triangle test (that isn't optional)?

@kotp this is the rectangles exercise, not the triangle exercise! I think you may have replied to the wrong thread.

See, I told you I was :confused: !

Feel free to squash these commits... I think it is :+1:


Remove timezone migration

Details
Removes a migration that was causing issues in the following PR: https://github.com/Expensify/Expensify.cash/pull/2040
Fixed Issues

Fixes https://github.com/Expensify/Expensify.cash/pull/2040#issuecomment-808354538
Tests/QA

Log into E.cash
Open the JS console navigate to Application, select Local Storage, and search for myPersonalDetails
Manually modify your timezone in your myPersonalDetails so that it's a string like so
OLD

"timezone": {
  "automatic": true,
  "selected": "America/Los_Angeles"
}

NEW
"timezone": "America/Los_Angeles"

Refresh the page and confirm you don't see any errors in the JS console and the page loads as anticipated.

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots
N/A no UI changes

For some reason I am unable to record my screen at the moment but I can confirm that this works on staging

Got screen recording working 🎉
https://user-images.githubusercontent.com/16747822/112695575-96442980-8e41-11eb-8fe6-63612651e826.mov

Nice! Need me to test it on my side too?

Can't hurt 😅  I'd rather be safe than sorry here

Oh no 😟

app-6abeeedf7b640e20646e.bundle.js:57 Uncaught TypeError: Cannot read property 'login' of null
    at Zs (app-6abeeedf7b640e20646e.bundle.js:85)
    at n.value (app-6abeeedf7b640e20646e.bundle.js:85)
    at ve.onKeyDown (app-6abeeedf7b640e20646e.bundle.js:1)
    at Object.s (app-6abeeedf7b640e20646e.bundle.js:57)
    at f (app-6abeeedf7b640e20646e.bundle.js:57)
    at app-6abeeedf7b640e20646e.bundle.js:57
    at b (app-6abeeedf7b640e20646e.bundle.js:57)
    at at (app-6abeeedf7b640e20646e.bundle.js:57)
    at ot (app-6abeeedf7b640e20646e.bundle.js:57)
    at st (app-6abeeedf7b640e20646e.bundle.js:57)

@isagoico While that's not good, it looks to me like you're using the production website

Yep I think the production "set up password" link is broken. I also updated on the staging results for this one here https://github.com/Expensify/Expensify.cash/pull/2040#issuecomment-808552770


python310Packages.zha-quirks: 0.0.85 -> 0.0.86

Description of changes
https://github.com/zigpy/zha-device-handlers/releases/tag/0.0.86

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 200832 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.homeassistant_sky_connect
home-assistant-component-tests.homeassistant_yellow
home-assistant-component-tests.zha
python310Packages.zha-quirks
python39Packages.zha-quirks


[Bug]: gitlab integration in a self hosted environment behind a firewall causes internal error because cs.appsmith.com can't be reached

Is there an existing issue for this?

[X] I have searched the existing issues

Description
If you try to set up gitlab integration for an app while behind a firewall without external internet access you get:
INTERNAL ERROR
Internal server error while processing request
Steps To Reproduce

install self-hosted appsmith behind a firewall without external internet access to cs.appsmith.com
try to set up gitlab integration
you get:
INTERNAL ERROR
Internal server error while processing request

Looking at the server logs,
/usr/lib/appsmith/stacks/logs/backend/backend-bbc5791b431d.log shows:
[2024-01-03 22:16:32,349]<EMAIL_ADDRESS>sessionId=acae5b50-32b1-40c2-bfda-d8cf5775c1d9, thread=reactor-http-epoll-1, requestId=6367e241-c12a-4dd9-b222-11136f22e552 -
org.springframework.web.reactive.function.client.WebClientRequestException: cs.appsmith.com: Name or service not known
at org.springframework.web.reactive.function.client.ExchangeFunctions$DefaultExchangeFunction.lambda$wrapException$9(ExchangeFunctions.java:136)
Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Error has been observed at the following site(s):
*__checkpoint ⇢ Request to GET null [DefaultWebClient]
*__checkpoint ⇢ Handler com.appsmith.server.controllers.GitController#connectApplicationToRemoteRepo(String, GitConnectDTO, String) [DispatcherHandler]
Even if you decide you don't want to allow self-hosted instances without phoning home, the error could be handled better.
Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Appsmith Community v1.9.41

@mp-gh yes we could potentially handle this better. Right now we don't support air-gapping in the community edition and you will need to write to<EMAIL_ADDRESS>to get access to an airgapped instance.


Avoid Rails autoloading issues by inherit directly

We had an issue with rails lazy loading in development. We fetch the pdf on an internal path and "our" ApplicationController took precedence over yours. We fixed this by inheriting directly with the module itself.

@sandelius is this still useful ? #cleaningup

Probably not since Rails uses another autoloader now.


Thank you for your interesting work. I want to ask when you will release the code.

Thank you for your interesting work. I want to ask when you will release the code.

Hello, thank you for your interest in our work! We have released our code, and you're welcome to check it out.


YARN-11709. NodeManager should be marked unhealthy on localizer config issues

Description of PR
The startLocalizer step didn't have the same error checks as the normal container launch. Updated the code to mark the NM unhealthy if the container-executor has config issues.
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 42s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 41s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 28s

trunk passed

+1 :green_heart:
shadedclient
39m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 2 new + 101 unchanged - 1 fixed = 103 total (was 102)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

-1 :x:
javadoc
0m 35s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 1 new + 195 unchanged - 0 fixed = 196 total (was 195)

-1 :x:
javadoc
0m 32s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05 generated 1 new + 195 unchanged - 0 fixed = 196 total (was 195)

+1 :green_heart:
spotbugs
1m 29s

the patch passed

+1 :green_heart:
shadedclient
40m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 31s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

187m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ef77a0d433b7 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e5d80601e3ad2e24fad6e3078d23e03552bf94fa

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/1/testReport/

Max. process+thread count
562 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 31s

trunk passed

+1 :green_heart:
compile
1m 47s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 44s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 54s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 55s

trunk passed

+1 :green_heart:
shadedclient
45m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 35s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javac
0m 24s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/buildtool-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
The patch fails to run checkstyle in hadoop-yarn-server-nodemanager

-1 :x:
mvnsite
0m 23s
/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.

-1 :x:
javadoc
0m 24s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_422-8u422-b05-1~20.04-b05.txt
hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05.

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

-1 :x:
shadedclient
4m 51s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
38m 51s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch passed.

-1 :x:
asflicense
0m 32s
/results-asflicense.txt
The patch generated 4 ASF License warnings.

160m  7s

Reason
Tests

Failed junit tests
hadoop.yarn.server.nodemanager.containermanager.TestContainerManager

hadoop.yarn.server.nodemanager.containermanager.resourceplugin.TestResourcePluginManager

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6e510cdbb700 5.15.0-119-generic #129-Ubuntu SMP Fri Aug 2 19:25:20 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e2d0786c7c14222481f9995935fa8b6cb5bf5882

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/3/testReport/

Max. process+thread count
553 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 18s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 28s

trunk passed

+1 :green_heart:
shadedclient
39m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 28s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 101 unchanged - 1 fixed = 101 total (was 102)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 32s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
40m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 30s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

170m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux dc7d10aaaf50 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e2d0786c7c14222481f9995935fa8b6cb5bf5882

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/2/testReport/

Max. process+thread count
533 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LGTM +1.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 19s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
checkstyle
0m 40s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 29s

trunk passed

+1 :green_heart:
shadedclient
40m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 20s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
javac
1m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 29s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 0 new + 101 unchanged - 1 fixed = 101 total (was 102)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 35s

the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05

+1 :green_heart:
spotbugs
1m 27s

the patch passed

+1 :green_heart:
shadedclient
40m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m 30s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

170m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7043

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6c4d375b47da 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e26571b945692b692964e5c6be46f66bc43b2b60

Default Java
Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/4/testReport/

Max. process+thread count
584 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7043/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @slfan1989 for the review, merged to trunk.


Support CLI options for kvrocks server

It closes #1034

wow, so speedy.

I test with ./build/kvrocks --unknown k and it starts well. I'm thinking of whether we should fail if the config key is unknown.

If you put an unkown k in the config file, it will also start well.

Thanks all. Merging...


IdentityAndConsentManagement meeting notes 2023-10-04

What type of PR is this?

documentation

What this PR does / why we need it:
MoM of the call held in 2023-10-04
Which issue(s) this PR fixes:
None.

Any other comments?
(CC @rartych)

Since there are no other comments from last week. @rartych , if possible, could you provide your review and approval as code owner to be able to merge the meeting minutes. Thanks in advance!


Alfred unable to get applications

.status command results in the error:
-There was an error. Gabo says Unable to get applications

Fixed in https://github.com/rhit-corridg/AlfredBot/commit/8715cf411ced3ecd24198c5da0f7ac2fd4e1ce38


Typo in config parameter

While working on the documentation I have noticed, that there's a typo for the Bidcos-RF parameters here. It should be bidcos instead of bidos.
As I don't know which effect changing this will have for our existing testers, I chose not to fix this yet. Perhaps we should do this once the time has come to migrate the project into the real Home Assistant when everybody has to redo the configuration anyways.

Good catch.
That can be fixed now. It's used in the ConfigFlow, but not written to the config entry.


Tooltips are not announced by screen readers

Describe the bug
Tooltips are not announced when you tab and focus on them.
How to reproduce
https://clarity.design/documentation/tooltips
Steps to reproduce the behavior:

Using a screen reader, tab to any of the tooltip links and observe that you do not hear the tooltip text when it appears.

Expected behavior
A clear and concise description of what you expected to happen.
Versions
App

Angular: [e.g. 6]
Node: [e.g. 8.10.0]
Clarity: [e.g. 0.12.5]

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes
This is due the the tooltip being inside the link that triggers and not using aria-describedby.
Separate the tooltip from the link and use aria-describedby to use the tooltip to describe the link.
See the following:
https://github.com/clane/Angular-A11y-Examples/blob/master/src/app/tootip/tootip.component.html
and
http://w3c.github.io/aria-practices/#tooltip

@chlane
Please see included screen recording. VoiceOver is reading tooltips just fine. What am I missing?
ScreenReaderReadsTooltips.mov.zip

@mathisscott
The issue can be reproduced with MacOS/Safari/VoiceOver and Windows 10/JAWS 2019/IE 11.
I recommend we follow the implementation at
http://whatsock.com/tsg/Coding Arena/Tooltips/Tooltip (Internal Content)/demo.htm#
which uses aria-describedby with the following structure:

                	What is the greatest secret known to man?

"It is a mistake to think you can solve any major problems just with potatoes.", Douglas Adams
"

From digging into the guts of that tooltip, it looks like we want to change our HTML to look more like...
I am describing this thing

    <clr-icon shape="info-circle" size="24" title="Lorem ipsum sit"></clr-icon>
    Lorem ipsum sit

As I see it, this would be a non-breaking change that could be backported – largely adding static attributes to the clr-tooltip and also an input to force the user-provided id. If no id is provided... 🤔
Note the following comments in that code:
When an A tag is used as the triggering element, it must adhere to the following:
1. If the element contains no link text and no Img element, then the link should include an informative Title attribute. (This is only valid if there is no link text at all)
2. If the element contains an Img tag and no link text, then the Img tag should include an informative Alt attribute and Title attribute, both of which should match.
3. The A tag must include an Href attribute, to ensure keyboard accessibility.

This will ensure the highest level of accessibility for both screen reader and keyboard only users.

We will need to reflect this in our examples as well as our documentation... ☝

@chlane
Look good to you? ☝

     <clr-icon shape="info-circle" size="24" title="Lorem ipsum sit"></clr-icon>     Lorem ipsum sit

Lorem ipsum sit

This issue is actually occurs with the Angular component version of the tooltip. See the updated steps to reproduce below.

Using VoiceOver/Safari, go to http://cx-guidelines.vmware.com/clarity-test-app2/
Activate the 'Tooltip Demos' link
Tab the tooltip icon under the "Angular Component" heading
Observe that the text "Lorem" is visually displayed, but not announced by VoiceOver. The icon is instead announced as a 'group'.


WIP: Do not include deprecated global config for HostedCluster

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

Thank you @csrwng. After testing, it looks like populateDeprecatedNetworkingFields is causing issues as well. Cannot update the below fields:
spec.networking.clusterNetwork[]
spec.networking.machineNetwork[]
spec.networking.serviceNetwork[]

/close


Edge Side Include (ESI) and/or Server Side Includes (SSI) support

Describe you feature request
Since FrankenPHP is integrated by default on the Symfony Docker environment, what is its progress status on ESI / SSI? Are these features implemented, and if so, how do you use them ?

ESI are supported by adding the extra cache-handler Caddy module, which, under the hood, relies on Souin.
We'll add it by default when it will be more mature, but more work as to be done on Souin side first (especially, extracting the adapters to 3rd party cache systems in dedicated modules to prevent adding too many dependencies).


[FLINK-19415][hive][docs] Move Hive document to Table & SQL Connector…

…s from Table API & SQL

What is the purpose of the change
Move hive connector docs to Table & SQL Connectors
Brief change log

Move hive docs
Update links

Verifying this change
NA
Does this pull request potentially affect one of the following parts:
NA
Documentation
NA

Attached is a screenshot of the doc structure after this change


Appex 136 Adding in Themes V3 Endpoints

What?
Adding in Themes V3 endpoints.
Tickets / Documentation

APPEX-136
https://developer.bigcommerce.com/api-reference/bffe6839dcabb-themes

Testing
Tested endpoints, in demo file and on postman for (theme file upload)

cc @bigcommerce/gta-dt

Hey @bc-nekisham, did you mean to combine the Theme commits with the Customers commits? We typically don't want to clutter new PR's with commits from PR's that have already been merged. I recommend creating a new branch where the top of the branch is the latest commit on main, and adding these Theme commits from there.

Hey @bc-nekisham, did you mean to combine the Theme commits with the Customers commits? We typically don't want to clutter new PR's with commits from PR's that have already been merged. I recommend creating a new branch where the top of the branch is the latest commit on main, and adding these Theme commits from there.

Oh nope I did not - want to do that, let me fix this! Thanks! @matthewvolk


loggerd: single lock file per segment

The qlog/rlog is always closed last, one .lock file in logger.cc is enough

I support this, but let's formalize it a bit more. Maybe just make a single .lock file in the directory and remove the rlog and qlog lock files?

Maybe loggerd itself should make the lock? We want to make sure the cases where either the rlog or cameras don't rotate are handled.

Think it's safer to create/remove lock in loggerstate

I didn't realize that these locks are used in a bunch of other places besides openpilot's uploader, such as the connect web app. This should stay as it is.


Setup alpha documentation site

TODO

[ ]

Outcomes
Deliverables
Estimated Effort

[ ] XS: 1 to 2 hours
[ ] S: half a day
[ ] M: 1-2 day
[ ] L: 1 week
[ ] XL: Move to an epic

Out of scope

fill it up with content

Get update on Monday sync

@ethanWallace to tackle publishing workflow


Remove suggestions

How can I remove suggestions that were created due to typos?
I have a trailing cd after many autosuggestions.

z-asug finds suggestions from your zsh history. You'll need to remove the entries from your histfile. This may be helpful: http://stackoverflow.com/questions/7243983/how-to-remove-an-entry-from-the-history-in-zsh


Speed up Travis build

Modify to use standard mode and directory cache for Travis CI build

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Output of travis build
From next build it will be quicker


Recommended approach to backslash escaping?

I'm trying to parse a JSON-like language and am having difficulty figuring out a good way to parse strings that contain escaped versions of their delimiters.
This snippet, from the json.rs, only seems to support strings with letters and numbers; punctuation and whitespace appear to be illegal:
named!(string<&str>,
  delimited!(
    tag!("\""),
    map_res!(escaped!(call!(alphanumeric), '\\', is_a!("\"n\\")), str::from_utf8),
    tag!("\"")
  )
);

I tried replacing alphanumeric above with is_not_s!("\""). This permits a variety of characters, but still does not allow me to have escaped quote characters in string. (e.g. "An 8\" sub sandwich"). The escaped quote " becomes \", which still contains a ".
Is there a prescribed approach for achieving this in 2.0? Or would I need to roll my own solution somehow?
Thanks! nom is really impressive!

I have difficulties understanding what you're trying to achieve here. Which quote is escaped? There are two versions: escaped! recognizes a string with escaped chars, escaped_transform! recognizes the string and replaces the escaped chars by their real version.

Ah, escaped_transform! appears to be what I want. Thanks!


flux cannot connect to ssh

https://github.com/onedr0p/cluster-template/blob/ee8326898f4320e558f62094b8174115f52812f6/config.sample.yaml#L128
This line should be
For a private repo use the 'ssh://' URL (e.g<EMAIL_ADDRESS>
This is because Flux expects after ':' to find a port number.
Same issue was also raised here
https://github.com/fluxcd/flux2/discussions/4592

Thanks!


Add abi handling to sway-fmt-v2

WIP

[x] #2061 merged first
[ ] Add indentation handling

Closes #2043

Review was requested but looks like this is in draft mode? Don't forget to hit "Ready for review" when ready!

Review was requested but looks like this is in draft mode? Don't forget to hit "Ready for review" when ready!

It's still a work in progress, my bad!

@kayagokalp @mitchmindtree having some trouble figuring out why the indentations aren't sticking for abi but seem to work for enum. Could use a review, thanks!

@kayagokalp I think for now it's okay, since the formatter is still a WIP. I will tackle fn next!


Runaway search processes should be killed when pressing Escape

Testing #16416
I was trying to see if there's any handling for regexes that lead to catastrophic backtracking. Catastrophic backtracking in regexes is a quite fun topic. Read more at http://www.regular-expressions.info/catastrophic.html

open the vscode repo
search for ^(.*?,){11}P
observe 100% CPU on all cores ;)
press Escape

observe 100% CPU on all cores does not stop

The same thing happens in stable, just with one process running away instead of several. I can't kill the processes because they need to clean up their open file descriptors. They must be stuck on a single 8k chunk because they would notice that they're canceled as soon as they go back to fs.read. So I'm not sure how to fix this.

Is it typical to encounter this on accident? Maybe it's ok to expect people to restart vscode in this case, as they would have to now on stable?

@roblourens I think killing the worker processes will cause the OS to release the file descriptors (I think it's part of the OS's job, together with freeing RAM, etc. but maybe I am mistaken).
I don't think anyone would often run into this, I just thought that since these processes are stateless workers and we have the chance to kill them when they are unresponsive, we should do so. Not a critical issue and feel free to close as designed if you wish to.

Note that this problem also occurs without regular expressions when searching in a directory with many files.
I poke at the Chromium source code using Visual Studio Code, and sometimes perform a search across all files by accident. I either have to wait a minute or so for the search to complete, or kill Visual Studio Code.
I just encountered this issue a few times today (maybe my coffee isn't working...), and felt frustrated enough to see if an issue exists. :)

Ripgrep search will be enabled by default for he March release, and isn't susceptible to catastrophic regex backtracking, and I kill the process as soon as esc is pressed.


Added new condition to GovernorMockEnv invariant

Added a check that local and public root peers are disjoint. Also tried very hard to extend some more governor properties with my new found insights from modelling the Governor with Alloy, and all that I found was this extra harmless check.
Trace properties already check for the validity of the PeerSelectionStatee, so we can be confident that at least the state is not corrupted after a certain amount of time. I also thought about adding consistency checks for each possible action (i.e. checking if there's no starvation of a particular action), but I am not sure if the livelock check covers that.

Seems like I found a slight bug on the generator, hopefully it is fixed now

Just for reference, the thing I "fixed" was actually intended to be that way, so I'll revert and document the reason for it!


Having ErrImagePull when trying to pull a private docker image

Environmental Info:
K3s Version:
k3s version v1.20.4+k3s1 (838a906a)
go version go1.15.8
Node(s) CPU architecture, OS, and Version:
Master: Linux dev-1 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Worker: Linux dev-2 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:
1 master, 1 worker
Example deployment manifest (I use krane to deploy)
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: account-deployment
  labels:
    app: account-app
spec:
  replicas: 2
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 0
  selector:
    matchLabels:
      app: account-app
  template:
    metadata:
      labels:
        app: account-app
    spec:
      imagePullSecrets:
        - name: gitlab-credentials
      containers:
        - name: account
          image: <%= registry_image %>:<%= commit_short_sha %>
          envFrom:
            - configMapRef:
                name: account-config
            - secretRef:
                name: account-secret
          env:
            - name: VERSION
              value: "<%= commit_short_sha %>"
          command: ["gunicorn", "main:app", "-b", "<IP_ADDRESS>:5000", "-w", "4"]
          resources:
            requests:
              memory: "128Mi"
              cpu: "250m"
            limits:
              memory: "196Mi"
              cpu: "500m"
          ports:
            - containerPort: 5000
          livenessProbe:
            httpGet:
              path: /status
              port: 5000
            initialDelaySeconds: 3
            periodSeconds: 3
          readinessProbe:
            httpGet:
              path: /status
              port: 5000
            initialDelaySeconds: 5
            periodSeconds: 5

Describe the bug:
I am using gitlab's private docker registry to deploy my application to k3s.
With the above deployment I'm unable to pull the image to my master node for some reason (ErrImagePull error). It works fine for my worker node. Before I updated to 1.20 it was the other way around, my master node can pull the image but my worker node can't.
During the deployment if it happens to deploy to the master node, the pod is stuck there for a while (until timeout), and if I delete that stuck pod, the deployment went through because it automatically rolls out a new pod on the other node. For example, if the pod is stuck on the master node, and I delete it, there will be a new node deployed to the worker node (which happens to be the working node now)
Steps To Reproduce:
I installed k3s using this command curl -sfL https://get.k3s.io | sh -s - --docker
Not sure how to replicate this because it happens kinda random
Expected behavior:
Pulling a private docker image should work consistently
Actual behavior:
At the moment, the master node is not able to pull the private docker image, and the worker is able to pull the private image.
Additional context / logs:
I have no ideas which logs are necessary to debug this one, feel free to ask for it and I will try to provide as much as I can

If you're using the docker runtime, docker is responsible for pulling the image. Check the docker logs, and try pulling the image using the docker cli tool?

If you're using the docker runtime, docker is responsible for performing the image pull. Check the docker logs, and try pulling the image using the docker cli tool?

Thank you, it works now, I wonder what is the purpose of imagePullSecrets?  Do I even need it if I have to configure the docker daemon to work with my private registry?

I'm closing this one. The issue is that I was deploying the gitlab-credentials outside of krane. And because krane automatically prunes all resources of the given namespace, the docker-registry secret is pruned as well. Deploying it via krane fixes this :)


version 2 UI for seed restore

closes #505

Please rebase this branch and also just noticed when you enter the words while recovering the wallet it does not automatically take use to password ntry automatically after the success of veryfying the words. I had to click that button.


Offsore pump not highlighting valid placements when "Left-Click: put into cursor"

Problem Description
When playing the latest version of space age (2.0.13) the offsore pumps are not highlighting valid placement locations when being selected from the compact view. This happens on both Vulcanus (for lava) and Nauvis (for water). I'm assuming it's broken everywhere.
Reproduction

Add offsore pump to factory plan
Left click to put it in cursor
Don't see valid placements

Hm that's a tricky one. It's not really a bug actually. When you put an item into your cursor through the mod, it generates a one-entity blueprint for it. That way, it can set a recipe or pre-insert modules. This mode doesn't show the placement locations. The Q-picked entities do show them, but they can't have recipes/modules configured, so I can't really use that one by default.
I potentially could choose which system to use depending on the entity I guess. Which has potential to be confusing too since the two modes work a bit differently. But maybe if there is not recipe or modules, I use the pipette mode. I'll add it to the list of things to look into, thanks.

Had a look at this, and implemented it like I said: It'll check whether it can use pipette-mode, and use it if so, otherwise fall back to blueprints. So offshore pumps will use pipette, and thus show the placement indicators. Thanks again for the suggestion.


terminal: pasting causes cursor to go to end of line

E.g. imagine I have a line
foo baz

and I have my cursor on the space and bar  in the clipboard. Pasting will properly modify the line, but will move my cursor to the end (i.e. to the z in baz), rather than, as expected, the end of the paste (the space in bar ).

FYI @tadad @dr-frmr (not sure who owns this part of terminal).

fixed in develop!


Inference

Hi, have you tested your inference code, including the greedy search and beam search parts? Thanks.

Hi calmevtime， I have test inference code, and the greedy search and beam search,  it works fine. Have you encountered any problems?


Android Roadmap.

What do you think if you use this library for native Android: https://github.com/Dimezis/BlurView

do not use the Android's build-in BlurView as the official RN Blur package does. The performance issues make it completely unusable

@baronha thanks for starting this convo.
That library looks good to me, I'm not familiar with Kotlin and would need help implementing this for Android. I'm happy to review any PR's and keep this library maintained.
The other RN library @FluffyDiscord is talking about is https://github.com/Kureev/react-native-blur. I agree regarding the performance on Android and it has inconsistency issues across iOS major versions.

Android is now live in the latest version.


[Proposal] SOAR-0001 Improved OpenAPI -> Swift name mapping

Motivation
Encoding a string would help distinguish types properly. For eg. both a b and a_b would be rendered as a_b. This change would make it render a_space_b and a_b respectively. Adding a proposal as its not a trivial change, as recommended by the contribution guidelines.
Modifications
Added proposal document - SOAR-0001.md
An initial draft of the proposed implementation is at https://github.com/apple/swift-openapi-generator/pull/89. Any suggestions or improvements for the proposal are welcome.

Ok, let's move this proposal into the next stage (a reminder, the proposal process is documented here, but this is the first proposal going through it, so we'll adjust as needed after this review period).
Marking this proposal as In Review, and the review period runs from today until July 10 (a little over 7 days as some of us are on vacation).
Reviewers are encouraged to leave feedback here or on the Swift forums (I'll create a post there shortly).
Thank you! 🙏
cc @denil-ct @simonjbeaumont

Forums thread: https://forums.swift.org/t/proposal-soar-0001-improved-openapi-swift-name-mapping/65890

Changed the label and you can change the PR to a draft for now, @denil-ct 🙏
Details: https://forums.swift.org/t/proposal-on-hold-soar-0001-improved-openapi-swift-name-mapping/65890/21

This proposal is back In Review, for details see https://forums.swift.org/t/proposal-in-review-soar-0001-improved-openapi-swift-name-mapping/65890/22

This proposal has been moved forward to Ready for Implementation: https://forums.swift.org/t/proposal-in-review-soar-0001-improved-openapi-swift-name-mapping/65890/23

Shall I mark this PR as ready for review then?

Sure, but we'll land it with the status updated to Accepted only once the impl PR lands as well.

Ah okay. Then let be in draft.

Ok, the PR #89 landed, so the feature is in main, disabled by default, hidden behind the feature flag proposal0001.
Let me see if we should update the proposal template, to add a field for feature flags, to have a state for "in main but disabled behind a feature flag".

Proposing here: https://github.com/apple/swift-openapi-generator/pull/161
That'd allow us to move this proposal to that state, and merge this PR. We'd update the status to Accepted once the feature flag is enabled in 0.2.0.

@denil-ct Okay, so we have a new proposal field and state, landed in https://github.com/apple/swift-openapi-generator/pull/161
Can you update your proposal by adding the feature flag name as a field to the top, and changing the state to In Preview? Then we'll be able to land this.


Add initial F# examples

This PR is for initial F# code samples.  Given a potential change to the project structure, I've created a separate top level FSharp language folder and accompanying temporary solution.  The solution simply links to the Bot.Builder and Bot.Connector C# projects rather than referencing the Nuget Packages - to aid with feature development and exploration.  Once the new code sample structure is in place the F# project can be lifted out and into a target language folder and have it's project references updated.

Hi @WilliamBerryiii, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

Closing as CLA bot did not recognize org linked account.  Will attempt a re-submit.


feat: allow spectral rules to be defined in the validaterc

ref: https://github.ibm.com/arf/planning-sdk-squad/issues/2170
followup of: https://github.com/IBM/openapi-validator/pull/195
These changes allow spectral rules to have their severity level changed in the .validatrc and allow custom rules defined in a .spectral.yaml file to not be overridden by the .defaultsForSpectral.yaml. Although the .defaultsForSpectral.yaml will still override the .spectral.yaml severity level of any existing rule .defaultsForSpectral.yaml defines a severity for, including the extended rules.

@rmkeezer I'm not sure if my suggestion to use loadRuleset vs mergeRules broke something, but I pulled your fork locally and wasn't able to overwrite the severity level of our rules using the validaterc file.

@jorge-ibm Ah, apparently spectral.mergeRules does not work but using the mergeRules function from the spectral ruleset does. I've updated the PR with that change, it should now correctly override the severity again.

Looks like everything is working as expected now, though I still think some tests would be helpful. The only thing I think should be fixed before merging is this duplicate message displaying whenever the validaterc file isn't present:
JorgeWoComputer:openapi-validator-rkeezer jrangel$ lint-openapi -p test/spectral/mockFiles/oas3/enabled-rules.yml
[Warning] No .validaterc file found. The validator will run in default mode.
To configure the validator, create a .validaterc file.
[Warning] No .validaterc file found. The validator will run in default mode.
To configure the validator, create a .validaterc file.

I'm assuming we want to add documentation on how to enable/edit our spectral rules from the validaterc file. @dpopp07 what are your thoughts?

I updated the PR with @dpopp07 's suggestions for using the defaultObject instead of calling config.get() inside the spectral run. This worked well! I also updated the unit test to using jest.spyOn to replace the file URL and the returned config file with their respective spectral changes. So the test does not need to run sequentially anymore!

:tada: This PR is included in version 0.31.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SAK-31558 Improve speed of test when VM doesn’t have ok rnd.

Checking to see if this makes travis any faster.

@buckett  do you want this merged?

It would be helpful for us as our build server has bad randomness, but I'll create it as a Jira so it can get merged back.

@buckett how did you go with a Jira?

I think this needs to only activate through a profile as it's a linux fix.

I've created SAK-31558 and I'll put this in a profile so it only gets activated on linux.

Profile activation done and linked to jira.

Conflicts 😭

Fixed conflicts.


Can't apply style on RadioButtons

Using the same configuration that work for input and checkbox fields, it won't work on radiobuttons or radiogroups.
Obs.: This issue is hapening when trying to set it through the "theme" property

Can you be more specific or provide some code to reproduce the issue? Make sure that you're using the latest version or try directly from the dev branch. I can't see anything wrong right now


tree2array: propagating statistical errors

Hi,
I'm having a conceptual problem with dealing with statistical errors.
Let's say that I have some tree with a bunch of events. I need to select certain events and then pass them into a histogram. However, I have plenty of shared cuts: effectively, I'm trying to divide one sample into a pass and fail category.
Selecting the brach to split on with the pass/fail in tree2array and then using numpy's arrays is much faster than e.g. running TTree::Draw twice: i.e.
pass = arr[ arr['foo'] == 0]
fail = arr [ arr['foo'] == 1]

However, how to I assign the statistical errors properly to the histograms that I create this way? Is there a simple procedure to keep track of this somehow that I have completely overlooked?
Cheers,
Geert-Jan

Just a side note that you can definitely pass in a selection straight into the root2array/tree2array functions (https://rootpy.github.io/root_numpy/reference/generated/root_numpy.root2array.html) so you can just only grab those entries you care to TTree::Draw.
Depending on how you assign the errors, it might be easy to do errors = calculate_error(arr['branch_of_interest']) which creates an array and then loop over that to set the errors separately:
   for(int i=0; i<11; i++){
      h1->SetBinContent(i,1.5-i/10);
      h1->SetBinError(i,0.5*i);
      h2->SetBinContent(i,10.5-i/10);
      h2->SetBinError(i,0.7*i);
   }

for example.

Hi @kratsg ,
Thanks for the very quick reply! I'm aware that I can do a selection, and I'm fact I'm using that already :)  However, subdividing a sample 4-way (real-pass, real-fail, fake-pass, and fake-fail) is much slower than selecting the more inclusive kinematic cuts and then doing that split on the numpy arrays.
I'm not sure that I understand your example. What is this meant to do?

@gbesjes the statistical errors will still be set appropriately by ROOT when you fill your arrays into your histograms, no matter what path those arrays took on their way to being chopped up into your various analysis regions. Just use fill_hist on each slice, as you would normally, and those histograms will have the statistical errors set correctly. fill_hist also accepts weights, that should be sliced up the same way as your main array.


Combine Cached Data with New Data using max_cache_seconds

Is your feature request related to a problem? Please describe.
Yes, when using the max_cache_seconds feature in read_sql_query, it only returns the cached results from S3. While this is efficient, it doesn't provide me with any new data that has been added since the last cached result.
Describe the solution you'd like
I'd like an enhancement to the max_cache_seconds functionality where:

If a matching cached result is found, it's returned.
The system then fetches any data added or updated since the last cached result.
Both the cached and new data are combined and returned to the user.

Describe alternatives you've considered
One alternative would be to manually manage the data retrieval process: first fetching the cached data and then running a separate query to get the new data. However, this approach is cumbersome.
Additional context
This enhancement would be particularly beneficial for datasets that have frequent updates. It ensures users always have access to the latest data without the need to re-fetch the entire dataset, optimizing both performance and data freshness.

Hi @flowtrader2016 you should use max_cache_seconds to tune caching to the approximate frequency of data updates. Also unfortunately it would not be possible to tell the records that were added/updated without reading the full result set.


Fix links with targets outside of book

Some books (Cargo, Rust Reference, etc.) link to content in other books hosted on the same domain using relative paths that escape the hosted book root. It should be possible to fix these such that they link to the hosted versions, provided a URL to the hosted book is provided.

Implemented in #66


Add a command "ipconfig" to show details of the user who interacts with the terminal.

Every terminal has an ipconfig command which shows the user ip address local address and network ( like jio, Airtel ) . It's an additional command that makes the terminal realistic.
If you assign me then i can do it for you. ✨

Go for it 👍


Tesla too slow for phase detection

See https://gathering.tweakers.net/forum/list_message/75395864#75395864.
detection-25.zip
After 11 seconds the Tesla is still not drawing any power; this version is patched to wait for 25 seconds for testing....
detection-25.zip

Commit d1d6866


always skip the CellMarker line

When collapse all cell inputs is enabled, the first line under the CellMarker (# %%) shows in the interactive window to help you easily identify a particular cell, but once you put something after it. The CellMarker line will show instead. This makes each cell hard to identify if you happen to use the CellMarker line as a separator

I hope you guys could pls consider adding a toggle to always skip the CellMarker line or maybe even to let users select how many lines of code they wanna see when  collapse all cell inputs is enabled:

@StevenLi-DS we are working on porting the interactive window to use built-in VS Code UI. We have an outstanding issue tracking allowing showing the first code line when collapsing cell input in the new built-in UI https://github.com/microsoft/vscode/issues/119776#issuecomment-873483243 but we already skip the cell marker line in this implementation:

@joyceerhl Thanks for the info and this is shocking to me since I'm not a fan of this UI at all (so far). So the jupyter extension will eventually use this UI???

For context, the goal of porting the interactive window to use built-in UI is so that VS Code themes, keybindings, snippets etc. will work in the interactive window.
The UI is still a work in progress and we would love to hear how we can make this UI work better for you. We are already aware of several problems, e.g.

Input box to be larger https://github.com/microsoft/vscode/issues/126415#issuecomment-875721427
Toolbar to show only icons https://github.com/microsoft/vscode/issues/125551
Interactive cell code to be collapsed https://github.com/microsoft/vscode/issues/119776#issuecomment-873483243

@joyceerhl Thank you. I tried it yesterday, and it seems like lots of basic feature is still missing currently the current UI used in the extension, and I'll try it out from time to time along its development.

If you spot any missing features, they are most likely unintentionally omitted and we will be implementing them this month. Please file bug reports on this repo so we can ensure they are added back: https://github.com/microsoft/vscode-jupyter/issues?q=is%3Aissue+is%3Aopen+label%3Ainteractive-window
Additionally, if there are any aspects of the UI that you don't enjoy, please let us know as well. We really want to ensure that the interactive window becomes even more enjoyable to use for our existing users after this transition is complete, and your early feedback helps us identify and resolve issues. Thank you so much 😊


License

Hi Sebastian,
Is the code under any license? It would be cool to use it for other projects.
Thanks in advance.

Hi, this code is free to use in personal or commercial projects.


Add PhoneBrowse.app latest version

Free to explore and browse iPhone, iPad, iPod touch file system and use your iPhone, iPad, iTouch as USB flash drive without jailbreaking. http://www.imobie.com/phonebrowse

Looks good, thanks! :+1:


fix(config): path to primary entrypoint

Fixes #721

Summary
index.js is now nested in dist/src on build. This PR fixes the path in "main" property for package.json.

I just emailed my signed CLA.

@cla-bot check

Thanks @kylejb .. we will merge the alternate PR and cut a release.

It would still be good for you to sign and submit a CLA for any future contributions.


Add initial tests for Horovod

Add the initial Open-CE tests for Horovod.

Testing in Horovod has changed between 0.19.* and 0.20.. Let's wait until we update Horovod to 0.20. before adding tests.


Add overlord revision

Overlord revision 2

The tests on this are awesome, but the implementation is getting more complicated with the revisions. You should sit with Danila and work through these things to find a much less complicated solution.


Add QQ Bot with Bull to Readme

Thanks a lot for this powerful, robust and easy-to-use library!

Thanks! 🙏


Describing conditions that will cause an error response

This is for Swagger.next
With Swagger we can define error responses but there is no way to describe what will cause an error response. Things like auth, missing or invalid parameter can easily described in the specs. Should we have a way for such description in Swagger?

FWIW, this could also be defined by specifying HTTP status codes which occur for the given errors (401/403 for auth, 400 for validation errors etc).
#236 seems to address the perceived need for more error-specific handling of responses, let's look at it from that perspective.


handle ArticleExtractor error on empty html returns

Mandatory

[x] I read the documentation (readme and wiki).
[x] I searched other issues (including closed issues) and could not find any to be related. If you find related issues post them below or directly add your issue to the most related one.

Related issues:

https://github.com/fhamborg/news-please/issues/66

Describe the bug
An empty html reponse (for various reasons, like https://github.com/fhamborg/news-please/issues/66) is passed as it is from_urls() in __init__.py
html = SimpleCrawler.fetch_url(url, timeout=timeout)
results[url] = NewsPlease.from_html(html, url, download_date)

leading to pipeline/extractor/extractors/newspaper_extractor.py:article.parse() which triggers newspaper.ArticleException
This is even more problematic when using threaded mode, as then the scraping job is often stuck at thread.join()

traceback:

In [17]: NewsPlease.from_url(url)
connection/timeout error: https://thegrayzone.com/2020/07/17/us-taiwan-lied-warning-world-health-organization-coronavirus/ ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
---------------------------------------------------------------------------
ArticleException                          Traceback (most recent call last)
<ipython-input-17-7489d1909aef> in <module>()
----> 1 NewsPlease.from_url(url)

/home/arcolife/.local/lib/python3.6/site-packages/newsplease/__init__.py in from_url(url, timeout)
     92         :rtype: NewsArticle, None
     93         """
---> 94         articles = NewsPlease.from_urls([url], timeout=timeout)
     95         if url in articles.keys():
     96             return articles[url]

/home/arcolife/.local/lib/python3.6/site-packages/newsplease/__init__.py in from_urls(urls, timeout)
    116             url = urls[0]
    117             html = SimpleCrawler.fetch_url(url, timeout=timeout)
--> 118             results[url] = NewsPlease.from_html(html, url, download_date)
    119         else:
    120             results = SimpleCrawler.fetch_urls(urls)

/home/arcolife/.local/lib/python3.6/site-packages/newsplease/__init__.py in from_html(html, url, download_date)
     77         item['download_date'] = download_date
     78         item['modified_date'] = None
---> 79         item = extractor.extract(item)
     80
     81         tmp_article = ExtractedInformationStorage.extract_relevant_info(item)

/home/arcolife/.local/lib/python3.6/site-packages/newsplease/pipeline/extractor/article_extractor.py in extract(self, item)
     51
     52         for extractor in self.extractor_list:
---> 53             article_candidate = extractor.extract(item)
     54             article_candidates.append(article_candidate)
     55

/home/arcolife/.local/lib/python3.6/site-packages/newsplease/pipeline/extractor/extractors/newspaper_extractor.py in extract(self, item)
     28         article = Article('')
     29         article.set_html(item['spider_response'].body)
---> 30         article.parse()
     31         article_candidate.title = article.title
     32         article_candidate.description = article.meta_description

/home/arcolife/.local/lib/python3.6/site-packages/newspaper/article.py in parse(self)
    189
    190     def parse(self):
--> 191         self.throw_if_not_downloaded_verbose()
    192
    193         self.doc = self.config.get_parser().fromstring(self.html)

/home/arcolife/.local/lib/python3.6/site-packages/newspaper/article.py in throw_if_not_downloaded_verbose(self)
    527         """
    528         if self.download_state == ArticleDownloadState.NOT_STARTED:
--> 529             raise ArticleException('You must `download()` an article first!')
    530         elif self.download_state == ArticleDownloadState.FAILED_RESPONSE:
    531             raise ArticleException('Article `download()` failed with %s on URL %s' %

ArticleException: You must `download()` an article first!

To Reproduce
from newspaper import  ArticleException

url = "https://thegrayzone.com/2020/07/17/us-taiwan-lied-warning-world-health-organization-coronavirus/"
try:
    NewsPlease.from_url(url)
except ArticleException:
    print("NO article downloaded")

Expected behavior
should just give me an empty article maintext / other relevant fields in the object returned.
Log
connection/timeout error: https://thegrayzone.com/2020/07/17/us-taiwan-lied-warning-world-health-organization-coronavirus/ ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
NO article downloaded

Versions (please complete the following information):

OS: Ubuntu 18.04.4 LTS
Python Version: 3.6.9
news-please Version: commit c79e8c35950dbfd30e1d5f4f3d291d97de488bad (HEAD -> master, origin/master, origin/HEAD)

I also get this when extracting WARCs from news-crawl.
2021-02-08 07:40:53 [newsplease.crawler.commoncrawl_extractor] ERROR: <traceback object at 0x7f874b007548>
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/dist-packages/newsplease/crawler/commoncrawl_extractor.py", line 257, in __process_warc_gz_file
    filter_pass, article = self.filter_record(record)
  File "/opt/coviddash/ingress/covidmarch.py", line 31, in filter_record
    passed_filters, article = super().filter_record(warc_record, article)
  File "/usr/local/lib/python3.7/dist-packages/newsplease/crawler/commoncrawl_extractor.py", line 121, in filter_record
    article = self._from_warc(warc_record)
  File "/usr/local/lib/python3.7/dist-packages/newsplease/crawler/commoncrawl_extractor.py", line 233, in _from_warc
    return NewsPlease.from_warc(record, decode_errors="replace" if self.__ignore_unicode_errors else "strict")
  File "/usr/local/lib/python3.7/dist-packages/newsplease/__init__.py", line 49, in from_warc
    article = NewsPlease.from_html(html, url=url, download_date=download_date)
  File "/usr/local/lib/python3.7/dist-packages/newsplease/__init__.py", line 83, in from_html
    item = extractor.extract(item)
  File "/usr/local/lib/python3.7/dist-packages/newsplease/pipeline/extractor/article_extractor.py", line 53, in extract
    article_candidate = extractor.extract(item)
  File "/usr/local/lib/python3.7/dist-packages/newsplease/pipeline/extractor/extractors/newspaper_extractor.py", line 30, in extract
    article.parse()
  File "/usr/local/lib/python3.7/dist-packages/newspaper/article.py", line 191, in parse
    self.throw_if_not_downloaded_verbose()
  File "/usr/local/lib/python3.7/dist-packages/newspaper/article.py", line 529, in throw_if_not_downloaded_verbose
    raise ArticleException('You must `download()` an article first!')
newspaper.article.ArticleException: You must `download()` an article first!


The apollo playground can't access

Describe the bug
The Apollo playground can't access.
To Reproduce
Steps to reproduce the behavior:

Click on  Apollo playground link in readme.
See error

Screenshots

Desktop (please complete the following information):

Browser [chrome]

@NikoManiac should be fixed now, please check it again.


Unable to login using Rainloop

Hi,
I configured a mail server on Debian Jessie. Its working fine using thunderbird email client. The mail server doesn't uses any database for users, users are added as system users. I installed rainloop but am unable to login using email address and password. what could be the issue?

I guess you have figured out to use the mapping plugin to map e-mail to username?


Meaning of viewBox should be clearer

It's not clear what exactly the viewBox means.

Must an implementation clip drawing operations outside the viewBox? (Hopefully not, clips are expensive.)
May an implementation drop drawing operations outside the viewBox? (Different implementations would have different renderings.)
May a drawing draw outside the viewBox?
Should an implementation honour the viewBox aspect ratio when rendering the image?

You're right that this needs to be explicitly said in the spec. To your specific questions:

Must an implementation clip drawing operations outside the viewBox? (Hopefully not, clips are expensive.)

That's the intention.
I thought that clipping to axis-aligned rectangles is pretty cheap, especially as rasterizers have to do that anyway to avoid overflowing the destination pixel buffer. Let me know if I'm mistaken.

May an implementation drop drawing operations outside the viewBox? (Different implementations would have different renderings.)

It's must, not may, and different implementations should agree, because (as above) it's a clip. Or am I misunderstanding your question?

May a drawing draw outside the viewBox?

Individual path nodes can certainly be outside the viewBox. Entire paths can also be outside of the viewBox, but they should then be entirely clipped out (no-ops).

Should an implementation honour the viewBox aspect ratio when rendering the image?

Aspect ratio is only a hint. Implementations are allowed to draw a "naturally 3:2" IconVG into a 1:1 space.

I thought that clipping to axis-aligned rectangles is pretty cheap, especially as rasterizers have to do that anyway to avoid overflowing the destination pixel buffer. Let me know if I'm mistaken.

There's not always a way to know if the output buffer is axis-aligned, though. Assuming the user wants anti-aliased clipping in the rotated case, this means the IconVG renderer has to pro-actively use a saveLayer-based clip (in Skia terms), which is the expensive kind.

this means the IconVG renderer has to pro-actively use a saveLayer-based clip (in Skia terms)

I may very well be misunderstanding the Skia API, but https://fiddle.skia.org/c/@Canvas_clipRect does a non-axis-aligned rectangular clip while only calling canvas->save(), not canvas->saveLayer().

Yeah, if you don't have to deal with colour bleed you can do it with only the medium-expensive clips and can skip the saveLayer call. My point is more that if you could avoid clipping entirely you'd be saving a bunch of cycles potentially. Obviously that's a trade-off (and IconVG is not intended to optimize for raw rendering speed above other considerations like file size or convenience).

I still think I'd like the IconVG viewBox to implicitly clip. (Does SVG do this? I'd have to check...)
I certainly want to avoid "different implementations would have different renderings".
If clips turn out to be noticably expensive, I suppose that IconVG implementations could make two passes over the vectors (the path nodes). The first pass just calculates a convex hull, which is a very cheap computation. The second pass does the actual rendering but between the two, we could skip the clipRect call if the rectangle entirely contains the convex hull.

Clipping is definitely a reasonable choice.

(FWIW in the Dart implementation I just made it configurable and defaulted to a hard (fast but no AA) clip.)

I still think I'd like the IconVG viewBox to implicitly clip. (Does SVG do this? I'd have to check...)

IconVG doesn't blindly follow SVG in all its complexity, but for what it's worth, the SVG 1.1 spec section 14.3.3 The ‘overflow’ and ‘clip’ properties gives 7 bullet points for how overflow works (cross-referencing CSS2) and then concludes with:

As a result of the above, the default behavior of SVG user agents is to establish a clipping path to the bounds of the initial viewport

It then goes on to note that, in SVG, viewport is not the same as viewBox. If I'm reading section 14.3.4 Clip to viewport vs. clip to ‘viewBox’ properly, if viewport and viewBox differ then the default clip is to the viewport and shrinking that to the viewBox requires an explicit clip property somewhere.

(FWIW in the Dart implementation I just made it configurable and defaulted to a hard (fast but no AA) clip.)

Out of curiosity, does "the Dart implementation" mean a Dart SVG implementation, or does it mean some sort of Dart/Flutter canvas widget, with programmable vector graphics but not a full SVG implementation?

does "the Dart implementation" mean...

Oh, I just saw https://github.com/google/iconvg/pull/25

I definitely wouldn't follow SVG here, clipping and overflow in the CSS/SVG world is order of magnitude more complex than all of IconVG put together...


Fixes #653 Start services in Yarn Application Master and register it's U...

...RL as the trackingURL

This is quite there - I'm getting an error when the GearPump services tries to show the UI as shown below. Still debugging this.

Hi Kam,
Have you set the the following config correctly in service UI?

  ##############################
  ### Required to change!!
  ### You need to set the ip address or hostname of this machine
  ###
  akka.remote.netty.tcp.hostname = "<IP_ADDRESS>"

You can simplily override the gear.conf by providing a java property. like this:
-Dakka.remote.netty.tcp.hostname=my_hostname_or_ip_of_ui_server

It seems to be related to how the trackingURL is set - in the YARN UI - clicking on the trackingURL goes through a proxy that looks like http://ip-10-10-10-217.eu-west-1.compute.internal:8088/proxy/application_1426259233511_0045/#/cluster/master
even though I set the trackingURL to the correct services URL.

The web proxy may not work.
As we have REST call and long connection call, I am not sure it will still work when the YARN rewrite the REST URL in web page.

Another trick I use when I used before is to add a jump page.
In the jump page, it will use window.location="new url" to redirect to actual UI server address.
You may want to give a try on this.

This now works - the problem was we were not correctly setting restapiRoot
diff --git a/services/dashboard/views/dashboard.js b/services/dashboard/views/dashboard.js
index aff0b20..fa52249 100644
--- a/services/dashboard/views/dashboard.js
+++ b/services/dashboard/views/dashboard.js
@@ -30,7 +30,7 @@ angular
updateChartInterval: 2000,
updateVisDagInterval: 2000,
restapiAutoRefreshInterval: 2000,

restapiRoot: '/api/v1.0',

restapiRoot: location.pathname + 'api/v1.0',
webSocketSendTimeout: 500
})

You can now select the trackingURI in the YARN RM UI and it will bring up the GearPump UI!

Hi Kam,
Is this ready for merge?

see PR https://github.com/intel-hadoop/gearpump/pull/702


[BUG] not working in chrome

Describe the bug
I built it( npm install & npm build), I installed it.
and i checked it installed
To activate WEBuffet, press and hold anywhere inside the page for just 1 second. But there is no response.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
it working
Screenshots

Chrome version

v74.0.3729.169 (64bit)

Additional context
Add any other context about the problem here.

We changed the way of activating it.
A menu will be shown in the context menu when you right-click on the page.
Thank you for your issue.