Something went wrong! Message format incorrect: extra keys not allowed @ data['actions'][0]['service_data'] Response error: 400

Alarmo Version
1.9.4
HA Version
2022.7.7
Bug description
When trying to create notify phone alerts it says
Something went wrong! Message format incorrect: extra keys not allowed @ data['actions'][0]['service_data'] Response error: 400
Steps to reproduce
No response
Relevant log output
No response

I think you updated to v1.9.5 but the browser still shows v1.9.4.
You should clear the browser cache if this is the case.

yes, it fixed it. thanks!


Implement Pyth Tradingview API

Implement the TradingView price API provided by pyth
Description

Remove the subgraph queries to fetch historical candle data
Add endpoint for Pyth's TradingView API
Implement logic to query Pyth for timeframes below 1H

Larger timeframes have gaps in the historical data which aren't present in the subgraph data

Refactor utility functions for candle data

@platschi Can you test this version? I confirmed it's sending requests above 1H to Satsuma. Requests 1H and below will be fetched from the Pyth TradingView API endpoint.
I still noticed some gaps in data for 30M and 1H when scrolling farther back, but not bad enough to avoid merging the change.


update exercises instructions and difficulties

update instructions (specify name of function to implement for easy and medium exercises, add hints when seemed approriate) fixes #45
update difficulties level fixes #46

maybe this grew pretty big as PR, but thanks to github pretty nice interface maybe still reviewable, I can split it smaller ones if needed.

No, this will be fine. I will review it tomorrow.


date issues

date of my .xlsx is convert in number in the Chart but i want it to remain in the type data if somebody have an answer

Please this is big issue as the date column reading it as number when it uses in the chart


Update dependencies to work with phoenix 0.9.0

I've also added support for google by adding the scope parameter

@atbyrd you should be able to pass the scope into the params map for the request.
Example:
AuthCode.authorize_url(strategy, %{redirect_uri: "https://example.com/auth/callback", scope: "email"})

The scope param is not something I believe belongs in the strategy itself, but rather one level up in some code that would abstract the details of Google's specific requirements.
Feel free to revert those scope related commits and I'll look into merging the dependency updates.
Let me know if you need any more help.

I rolled back the scope changes, thanks

Hey @atbyrd I've just merged #10 as it updates the plug dependency to a more recent version. Sorry I didn't get around to reviewing your PR sooner.


Kanban-Board Group Project Setup

Here is the link to our project as required "https://github.com/Zuwairanajma/Javascript-Capstone_AlbertandJuw/projects/1".
2 students will implement the project since I have only one coding partner this week, all tasks have been assigned accordingly.

Hi @Zuwairanajma,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Good job using the recommended template board :1st_place_medal:
Nice work using Kanban board with filled-in tasks :+1:

Required Changes ♻

[ ] Nice work using the recommended template board :+1: However it would be nice to assign each card to a team member. Your cards should have a circle with the team's avatar on it. See the example below:

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi @Zuwairanajma  ,
Approved 🟢 🟢
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Used correct Kanban board template💯
Cards correctly assigned to students👍 👍

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add copy / paste

As we work toward the "longer term future" as described in https://github.com/xi-editor/druid/issues/16, a pasteboard (the Mac word) / clipboard (the Windows word) would very nice to have!
One possibility is to rely on the Clipboard crate. In fact, it seems like it's not totally necessary for this functionality to be inside druid-shell or even druid? To my understanding, the winit project declared clipboard functionality out of scope for this reason.
In the longer term, I would expect a clipboard that supports data types beyond text, or a non-global pasteboard, will be important for apps like Runebender. But maybe that's running before we can walk.

I'm going to hijack this issue to track copy/paste more generally; we're going to need to copy and paste paths for runebender, and if we're doing that within the app we should take the time to get it working with the rest of the system. For paths this means converting them to postscript.
Not sure about what the API for this will look like, but at the very least we should try to support text, rich text, images (at least png+jpg), and paths.

I don't have strong feelings whether support is in druid-shell proper or not. It seems like there's benefit to having it hook the event loop. But yes, a valuable feature, and also valuable to support types beyond plain text (including vector graphics), as they're directly useful for Runebender.
As we've discussed on Zulip, it's unclear whether EPS or PDF are a better type for vector paths. The former is deprecated but possibly more widely implemented in other tools that we care about interop with.

I think this will require druid-shell support, because the exact mechanics of the pasteboard (such as how the type of data is communicated) will be dependent on the platform.


vulnerability with terser-webpack-plugin

Vulnerability: https://npmjs.com/advisories/565
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Regular Expression Denial of Service                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ ssri                                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=6.0.2 <7.0.0 || >=8.0.1                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ razzle [dev]                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ razzle > terser-webpack-plugin > cacache > ssri              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/565                             │
└───────────────┴──────────────────────────────────────────────────────────────┘

It looks like the terser-webpack-plugin package has fixed this as of v6.0.2 (released on Apr 7th, 2021), but it looks like Razzle is currently on 2.x.
This would be quite the version bump, so I'll let you guys mull over the consequences of this.

Looking at the changelog (https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md) release 5.0.0 dropped support for webpack 4. Razzle still supports both 4.x and 5.x from what I can see..

I am thinking about doing a razzle 5.0 that has just webpack 5 support since yarn 2 etc. is more strict about deps. But keep features mostly in sync with razzle 4.0. Then people that want all the newest stuff can use  5.0.

Hello, is there any chance of this getting fixed soon? I've been updating dependencies of my Razzle project and finding more and more are using things like the optional chaining operator, which older versions of terser crash on. Bumping terser-webpack-plugin would solve the problem.


Vertex AI - Endpoint Call with JSON - Invalid JSON payload received

I successfully trained and deployed a Tensorflow Recommender model on Vertex AI, Tensorflow 2.8.
Everything is online and to predict the output. In the notebook I do:
loaded = tf.saved_model.load(path)
scores, titles = loaded(["doctor"])

That returns:
Recommendations: [b'Nelly & Monsieur Arnaud (1995)'
 b'Three Lives and Only One Death (1996)' b'Critical Care (1997)']

That is, the payload (input for the neural network) must be ["doctor"]
Then I generate the JSON for payload (the error is here):
!echo {"\""instances"\"" : [{"\""input_1"\"" : {["\""doctor"\""]}}]} > instances0.json

And submit to the endpoint:
!curl -X POST  \
-H "Authorization: Bearer $(gcloud auth print-access-token)" \
-H "Content-Type: application/json" \
https://us-west1-aiplatform.googleapis.com/v1/projects/my_project/locations/us-west1/endpoints/123456789:predict \
-d @instances0.json > results.json

... as seen here: https://colab.research.google.com/github/GoogleCloudPlatform/vertex-ai-samples/blob/master/notebooks/community/vertex_endpoints/tf_hub_obj_detection/deploy_tfhub_object_detection_on_vertex_endpoints.ipynb#scrollTo=35348dd21acd
However, when I use this payload, I get error 400:
code: 400
message: "Invalid JSON payload received. Expected an object key or }. s" : [{"input_1" : {["doctor"]}}]} ^"
status: "INVALID_ARGUMENT"

This below don't work either:
!echo {"inputs": {"input_1": ["doctor"]}} > instances0.json

Even with validated JSON Lint, it does not return the proper prediction.
Running:
!saved_model_cli show --dir /home/jupyter/model --all

I get:
MetaGraphDef with tag-set: 'serve' contains the following SignatureDefs:

signature_def['__saved_model_init_op']:
  The given SavedModel SignatureDef contains the following input(s):
  The given SavedModel SignatureDef contains the following output(s):
    outputs['__saved_model_init_op'] tensor_info:
        dtype: DT_INVALID
        shape: unknown_rank
        name: NoOp
  Method name is:

signature_def['serving_default']:
  The given SavedModel SignatureDef contains the following input(s):
    inputs['input_1'] tensor_info:
        dtype: DT_STRING
        shape: (-1)
        name: serving_default_input_1:0
  The given SavedModel SignatureDef contains the following output(s):
    outputs['output_1'] tensor_info:
        dtype: DT_FLOAT
        shape: (-1, 10)
        name: StatefulPartitionedCall_1:0
    outputs['output_2'] tensor_info:
        dtype: DT_STRING
        shape: (-1, 10)
        name: StatefulPartitionedCall_1:1
  Method name is: tensorflow/serving/predict

Concrete Functions:
  Function Name: '__call__'
    Option #1
      Callable with:
        Argument #1
          input_1: TensorSpec(shape=(None,), dtype=tf.string, name='input_1')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: True
    Option #2
      Callable with:
        Argument #1
          queries: TensorSpec(shape=(None,), dtype=tf.string, name='queries')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: True
    Option #3
      Callable with:
        Argument #1
          input_1: TensorSpec(shape=(None,), dtype=tf.string, name='input_1')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: False
    Option #4
      Callable with:
        Argument #1
          queries: TensorSpec(shape=(None,), dtype=tf.string, name='queries')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: False

  Function Name: '_default_save_signature'
    Option #1
      Callable with:
        Argument #1
          input_1: TensorSpec(shape=(None,), dtype=tf.string, name='input_1')

  Function Name: 'call_and_return_all_conditional_losses'
    Option #1
      Callable with:
        Argument #1
          input_1: TensorSpec(shape=(None,), dtype=tf.string, name='input_1')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: False
    Option #2
      Callable with:
        Argument #1
          queries: TensorSpec(shape=(None,), dtype=tf.string, name='queries')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: True
    Option #3
      Callable with:
        Argument #1
          queries: TensorSpec(shape=(None,), dtype=tf.string, name='queries')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: False
    Option #4
      Callable with:
        Argument #1
          input_1: TensorSpec(shape=(None,), dtype=tf.string, name='input_1')
        Argument #2
          DType: NoneType
          Value: None
        Argument #3
          DType: bool
          Value: True

The point is: I'm passing an array and I'm not sure if it must be in b64 format.
This Python code works, but returns a different result than expected:
import tensorflow as tf
import base64
from google.protobuf import json_format
from google.protobuf.struct_pb2 import Value
import numpy as np
from google.cloud import aiplatform
import os
vertex_model = tf.saved_model.load("gs://bucket/model")

serving_input = list(
    vertex_model.signatures["serving_default"].structured_input_signature[1].keys()
)[0]

print("Serving input :", serving_input)

aip_endpoint_name = (
    f"projects/my-project/locations/us-west1/endpoints/12345567"
)
endpoint = aiplatform.Endpoint(aip_endpoint_name)

def encode_input(input):
    return base64.b64encode(np.array(input)).decode("utf-8")

instances_list = [{serving_input: {"b64": encode_input(np.array(["doctor"]))}}]
instances = [json_format.ParseDict(s, Value()) for s in instances_list]

results = endpoint.predict(instances=instances)
print(results.predictions[0]["output_2"])

['8 1/2 (1963)', 'Sword in the Stone, The (1963)', 'Much Ado About Nothing (1993)', 'Jumanji (1995)', 'As Good As It Gets (1997)', 'Age of Innocence, The (1993)', 'Double vie de Véronique, La (Double Life of Veronique, The) (1991)', 'Piano, The (1993)', 'Eat Drink Man Woman (1994)', 'Bullets Over Broadway (1994)']

Any ideas on how to fix / encode the payload ?

Looks like the base64 encoding of the sample notebook is not right. This works perfectly:
def encode_64(input):
    message = input
    message_bytes = message.encode('ascii')
    base64_bytes = base64.b64encode(message_bytes)
    base64_message = base64_bytes.decode('ascii')
    return base64_message

instances_list = [{serving_input: {"b64": encode_64("doctor")}}]
instances = [json_format.ParseDict(s, Value()) for s in instances_list]

results = endpoint.predict(instances=instances)
print(results.predictions[0]["output_2"][:3])

['Nelly & Monsieur Arnaud (1995)', 'Three Lives and Only One Death (1996)', 'Critical Care (1997)']

You have extra curly braces around your input data. Try something like:
!echo {"\""instances"\"" : [{"\""input_1"\"" : ["\""doctor"\""]}]} > instances0.json

Assuming you are using a GCP prebuilt container, this is endpoint launches the equivalent of a TF Serving container and you can test your model locally with a container before pushing to an endpoint to make sure everything is working. Take a look at this notebook.


throwError complains

Version
nuxt-security: 0.14.3
nuxt: 3.6.3
Steps to reproduce
add throwError to a routeRule and notice that it will complain about throwError not being a type
What is Expected?
to add throwError and not have it add a red squiggly from typescript.
What is actually happening?
The types are missing from the respective middleware types that you can add throwError to

RequestSizeLimiter
RateLimiter
XssValidator

Hey, thanks for creating this issue!
It is indeed a bug on the module side. I will review the PR and merge it soon ;)

Closing the issue as this bugfix was released in 0.14.4 version :)
Thank you!


Fix: text-wrapping and code scrolling in chat views

CLOSE https://github.com/sourcegraph/cody/issues/3863
This PR improves text wrapping and scrolling behavior in the chat views:

Enables text wrapping in chat message content by adding 'text-wrap: wrap' CSS rule. This allows long messages to wrap instead of overflowing.

Adds 'overflow: scroll' to <pre> tags in message content to enable scrolling for code blocks. Previously code blocks could overflow container.

Sets 'overflow: auto' on chat cell content containers. This enables scrolling when content overflows cell.

Moves 'white-space: pre-wrap' to human message containers for nicer text wrapping of human messages.
These changes improve the readability and scrolling behavior of long chat messages and code blocks. Text will wrap instead of overflowing, and scrolling will be enabled where needed.

PR generated by Cody ;)
Test plan

Manual testing:

Ask Cody a question that requires Cody to generate a code block
Shrink the chat view to see if the text are wrapped correctly, and the code blocks are scrollable

Before
There is no scrolling for code block and messages, and long texts are cut off and hidden when in a small window:

Thank you!

PR generated by Cody ;)

Tell me more!!

Thank you!

PR generated by Cody ;)

Tell me more!!

custom command, as shown in the screenshots attached to the PR 😆


Comment time

Fixed: #146
Added time in comments
Screenshot

@sanjay270899 @Tejas1510  Please view my PR

@EkjotKaur It would be better if we show the time after name. What your thoughts about it?

Okay, I'll do it.

Changed the position.
@sanjay270899  please view it


Level files don't store Lens data

There should be lens coordinates contained in the JSON, and the code in the Level class to handle the generation

Level files now contain a lens_coordinate_list field


runtime(java): Recognise the {@snippet} documentation tag

Remember that ‘code fragments are typically Java source
code, but they may also be fragments of properties files,
source code in other languages, or plain text.’  Therefore,
with these changes, markup tags are highlighted in the Java
source files (as external snippets) and in the {@snippet}
tags.
Also:

Improve matching of the multi-line {@code} documentation
tag with any contained balanced braces.
Recognise the {@literal} documentation tag.
Highlight stray blanks in comments.

Related to an enhancement proposal for PCRE-like callouts
discussed at https://github.com/vim/vim/issues/11217.
References:
https://openjdk.org/jeps/413
https://docs.oracle.com/en/java/javase/21/docs/specs/javadoc/doc-comment-spec.html

thank you!


CC3

Description
CC3 ground state energy.
Todos

[x] Add functions for CC3 t-equations.
[x] Test and check the results with Psi4.
[x] Merge the single-precision branch if that pull request will be merged first.

Status

[ ] Ready to go

Codecov Report

Merging #46 (8dd59f6) into main (80a6a30) will increase coverage by 0.50%.
The diff coverage is 91.47%.

could we add one more test to test_031_cc3_ecc.py? a slightly bigger basis set would be good. if it takes too much time, you could use H2 instead of H2O.

Yes, how about H2 with aug-cc-pVDZ (or aug-cc-pVTZ). It will not take long (tested on my laptop). There's also H2O with cc-pVDZ commented out in the test that passed on my laptop. It might take a bit longer but still pretty quick.


⚠ SceneTime has degraded performance

In 04225f6, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 9805 ms

Resolved: SceneTime performance has improved in 733dfe4.


det1.py error

hai sir.im currently using ur repository to make face recognition.i run the program using ubuntu and python. ive follow all requirement needed for the process. but when i run some program in aligning face i couldn't find the path or directories containing the det1.py. ive got an error of ioerror even the path that should contained the det1. py do existed in that directories. how do i solve this problem?

Make sure you set your working directory to the right path if you're using an IDE. All paths are relative to the working directory.


Pictures that are not a power of 2 cannot be displayed

https://github.com/playcanvas/playcanvas-gltf/blob/72329941357d51399324adcfbfb828ae7c826715/src/playcanvas-gltf.js#L291
i think the problem is here.

The width of this texture is a power of 2,but height is not

Thanks for reporting this! I have fixed it.


⚠ Bofrost.de has degraded performance

In 04ab875, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 882 ms

Resolved: Bofrost.de performance has improved in f656cb1.


Java generation: remove unused ByteString, HashMap imports

ByteString: Imported in PublisherApi but not used.
HashMap: Imported in LoggingServiceV2Api but not used.

Future APIs:

PathTemplate: any API with no key=value patterns in their URLs.

This is fixed now.


Re-adding Sorting and Rating UI

Per issue: https://github.com/opencfp/opencfp/issues/285
Sorting UI was removed and a different one added instead. I don't believe this was done on purpose, but merely product of an older version of OpenCFP being worked on. This PR re-adds the sort UI that has sort direction arrows.
Also, the up and down vote rating icons are being re-added in this PR.

Sorry about that @jakefolio. Hope all is well. Thanks!


Reject callx r10

r10 is the stack pointer and generally points in the stack memory region.
callx can only jump to addresses in the program memory region.
The two memory regions don't overlap so there is no point in using callx r10.

We should probably featurize this


Support m4 quoted strings in interface call arguments

Required for escaped strings, that would otherwise be replaced by m4, e.g. "interface":
filetrans_pattern(foo_t, bar_run_t, baz_run_t, dir, ``"interface"'')

Replaces: #289
Note: in contrast to #289 here the syntax is
``"interface"''

instead of
"``interface''"

Is there a reason we can't do both this and #289?  My inclination is to say that SELinux doesn't want to force either syntax on users, so it would be nice to handle both nesting options with quotes.  I haven't tried putting them together, but it looks like both PRs would be compatible with each other.

I like this approach. https://github.com/SELinuxProject/selint/pull/289 was a low effort which would allow to parse "interface''" but it would parse also "interface"  which is not correct. I've closed it.
I'm going to propose using ``"interface"'' in fedora-selinux/selinux-policy as suggested in this PR. It looks better for me.
I'm also working on sepolgen-ifgen patch which would be based on this idea - https://github.com/bachradsusi/SELinuxProject-selinux/commit/22b908e76f17851dac5f49dd4394068147c0b567

If the syntax here works for you, I think that's fine with me.  I don't want selint to be overly particular on matters of parsing - but that applies to what policy is used in practice rather than in theory.  This version is certainly nicer from an SELint perspective, and wrapping the m4 quotes outside seems to me to make more sense anyways.
I'll go ahead and merge this.  If anyone ever decides they actually want the syntax from #289 in practice, I'm happy to revisit that.  From an SELint parser perspective, it's nice to parse too much rather than too little, since parser errors are non-recoverable as SELint exists today.


Cross-crate windows only links are broken

Consider the following page:
https://docs.rs/tokio-stream/0.1.5/x86_64-pc-windows-msvc/tokio_stream/wrappers/struct.CtrlBreakStream.html
The links to CtrlBreak are broken because they link to the unix docs of the tokio crate, but the type is only available on windows.

Original discussion: https://discord.com/channels/442252698964721669/541978667522195476/840892995199827988

I think the proper fix is to add {target} to the --extern-html-root-url we pass to rustdoc.


docs: Add Notebook Tutorial for Equation Discovery

Copy & Paste Tutorial Notebook from autora-theorist-bms branch to autora branch
Description
closes #523
Type of change
Delete as appropriate:

docs: Documentation only changes

Linking to AutoRA Project #523

added_noise

also need to update the function name from experiment_runner to run, which i think i handled successfully in latest commit.

oh, i guess there's actually an error with the last cell under 6. Plot the Results for the Polynomial Regressor (no attribute model_, which is not included in the __init__ for that class). can we just delete the cell trying to print poly_model.model_?

@younesStrittmatter I am not sure why but merging is blocked because of your request for changes but it isn't saying I can re-request your review. Is there anything you can do on your end?

@younesStrittmatter anything you see still needing to be changed for this PR?


Custom Code

Is there a way to have the aurebesh JavaScript code executed other than window.alert(1)?
For example, the Greek π='',β=!π+π,ε=!β+π,γ=π+{},μ=β[π++],τ=β[φ=π],θ=++φ+π,λ=γ[φ+θ],β[λ+=γ[π]+(β.ε+γ)[π]+ε[θ]+μ+τ+β[φ]+λ+μ+γ[π]+τ][λ](ε[π]+ε[φ]+β[θ]+τ+μ+"(π)")() runs window.alert(1) when put into the console. Is there a way to make it do something else, like for example document.body.contentEditable = 'true'; document.designMode = 'on'; void 0 making the content editable?

Hello! Tanks for the aurebesh.js.
As DaCuteRaccoon asks ,I need also custom code to be converted .

Have a look at https://aem1k.com/transliterate.js/
and check out the source here: https://github.com/aemkei/transliterate.js
This tool will convert your input into an obfuscated script that uses symbols of foreign alphabets such as Kanji (零壱弐), Karian (𐊣𐊦𐊧) or even Hieroglyphs (𓅂𓂀𓁄).

Thanks @aemkei 👌. I never thought you would create a site also ❤💯.
I watched you on YouTube, in js conferences talking about js competitions, jsfuck, js globe. Very cool staff @aemkei. 🌟. Thank you.


chore: bdd-nh-1587639510 to 0.0.1

chore: Promote bdd-nh-1587639510 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Lora On All Linear Layers?

The Qlora paper suggests that tuning all linear layers is important to achieve results equivalent to full finetuning.  Your work suggests that the embedding layer and norm layer are needed for using Lora to extend context.
Do you do this as well or instead of what QLora does?
My understanding is that the following modules are targeted, either with lora or full finetuing:
"embed_tokens","input_layernorm","post_attention_layernorm","norm","q_proj", "k_proj", "v_proj", "o_proj".
Missing a few from all linear:
'v_proj', 'k_proj', 'lm_head', 'o_proj', 'down_proj', 'gate_proj', 'up_proj', 'q_proj'

Hi,
I have tried to include 'down_proj', 'gate_proj', 'up_proj' for lora fine-tuning. It makes little effects.
Based on my experience, 'lm_head' is a bit helpful. But its effect will be smaller if embed_tokens  is fine-tuned.
Regards,
Yukang Chen

Thanks for the response.
Can you confirm that the other modules I listed are correct?
With "embed_tokens","input_layernorm","post_attention_layernorm","norm" being used with full finetuning?

Yes. It is corrected.

Thanks!


Pre-release broken

Using
Name: Remote Repositories
Id: ms-vscode.remote-repositories
Description: Remotely browse and edit git repositories
Version: 0.27.2023012401
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-vscode.remote-repositories

Seeing,
notificationsAlerts.ts:40 TypeError: TelemetrySender.sendEventData must be a function
    at Function.validateSender (vscode-file://vscode-app/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:92:38355)
    at Object.createTelemetryLogger (vscode-file://vscode-app/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:117:31905)
    at new BaseTelemetryReporter (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/github.remotehub-0.48.0/dist/extension.js:25:2062)
    at new TelemetryReporter (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/github.remotehub-0.48.0/dist/extension.js:28:1158)
    at new _TelemetryService (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/github.remotehub-0.48.0/dist/extension.js:326:21044)
    at Object.registerVirtualProviderService (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/github.remotehub-0.48.0/dist/extension.js:826:4539)
    at vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/ms-vscode.remote-repositories-0.27.2023012401/dist/extension.js:405:10398
    at ensureProvidersRegistered (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/ms-vscode.remote-repositories-0.27.2023012401/dist/extension.js:405:10502)
    at openRepository (vscode-file://vscode-app/Users/jrieken/.vscode-insiders/extensions/ms-vscode.remote-repositories-0.27.2023012401/dist/extension.js:276:22608)
    at s.h (vscode-file://vscode-app/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:96:108033)

From the logs above you have stable GitHub Repositories v0.48.0. Switching to prerelease GitHub Repositories should resolve this error.


hanging on pingSevers

Initially found via https://github.com/sindresorhus/speed-test/issues/13#issuecomment-137872255, but also happening in the example README code. Seems like it gets stuck in the pingServers function.
Changing https://github.com/ddsol/speedtest.net/blob/master/index.js#L260 to <=todo allows it to progress and return a result.

This is not a solution. This code works normally fine, so it's not a off-by-one error. Also looking closely at that code this is not where the issue is. Errors and successes alike are counted towards done. Maybe pingServer doesn't return or something else is amiss.
The reason it works when you change the <todo to <=todo is because it'll just go ping another server so if one server is not responding it will simply not wait for it. That seems like an okay thing to do, except it makes it so in all cases one more server is pinged than requested. I don't think it's a good idea make the ping count 'advisory'.
If someone feels like implementing it, it would be easy to make pingServer itself time out with an error after 5 seconds. This would work great.
That said, I don't really have time to work on it now. I'll be happy to merge pull requests, though.

Yeah I thought the code must have been that way and working for a while; just trying to pin down where it got stuck. I'll put up a PR for the timeout error.


Sia.js

I published 0.1.0 of sia.js, the node wrapper for siad, earlier. This pr uses it in place of daemonManager.js

Going to have to wait for #146 to convert the Hosting plugin

boop @DavidVorick @lukechampine

looks like a nice cleanup, my only concern is with the multiple calls to Siad.configure. Can you explain each of them?

Each plugin imports/requires an instance of the siad wrapper. They ask the UI through ipc for the siad settings:
"siad": {
		"path": "/home/ming/Github/ui/Sia",
		"address": "http://localhost:9980",
		"command": "siad",
		"headers": {
			"User-Agent": "Sia-Agent"
		},
		"running": false
	}

To update their own wrapper instances with. None of these properties are really needed unless the user hosts siad on a different address or something.

ah. Seems a little awkward to have to replicate that everywhere Siad is used...maybe we can think of a better solution.


component: suggestion UI

Input field with dropdown driven by filter on the

fixed list
API
mix of few APIs and fixed list

Will be added to Material custom-element suite. Resides in https://github.com/EPA-WG/custom-element-dist/tree/main/src/material


List Comprehension and For Loop One Liner in Python

For Loop One-Liner.
List Comprehension One-Liner.

Thanks :D


Gitlab CI pipeline

In GitLab by @ksiero on Jun 24, 2019, 10:28
If we want to use a CI on gitlab we need to create a CI pipeline. My proposition: CI_pipeline.pdf.
This structure will give several docker images. Some users may want to have only PDI core features or maybe just one plugin. In case they want to build their images we should give them the smallest image possible. My goal is that user can run container simply typing in Dockerfile:
FROM registry.gitlab.maisondelasimulation.fr/jbigot/pdi/pdi:latest
or
FROM registry.gitlab.maisondelasimulation.fr/jbigot/pdi/hdf5:latest
or
FROM registry.gitlab.maisondelasimulation.fr/jbigot/pdi/pdi_core:latest

We can also think about different compilers (for example icc). This case would double our pipeline.

In GitLab by @ksiero on Jul 26, 2019, 10:55
closed

In GitLab by @ksiero on Jul 26, 2019, 10:55
We have agreed that for now docker should be only used for tests purpose. Continued in #152.


Fix get chain

In methods like forward_kinematics or jacobian, we need to access the kinematic tree that goes from the base frame to the end-effector. To get this kinematic chain I use the method get_chain (from urdf_parser_py), which returns the sequence of the kinematic tree as [...-link-joint-link-joint-...]
Sometimes a link and a joint may have the same name.
Before I was just checking that an element in the chain is in the joints list, supposing that links and joints could not have the same name. For example, if a joint and a link are named right_elbow, the check would return that both the elements are in the joints list.
To solve this issue I'm allowing the method get_chain to return only the joints in the chain.
Changing:
chain = self.robot_desc.get_chain(self.root_link, frame)
...
if item in self.robot_desc.joint_map:

with
chain = self.robot_desc.get_chain(self.root_link, frame, links=False)

I'm using this PR also to allow the creation of a link list with only links with inertial properties. With this modification, no fictitious zero inertia is needed. (See https://github.com/ami-iit/ADAM/pull/23#issuecomment-1157637342)

Thanks @FabioBergonti!


Memory leak on TF2.1 model.fit

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.3
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.1.0
Python version: 3.7.5
GPU model and memory: No GPU

Describe the current behavior
Fitting a simple LSTM model causes memory leak
Standalone code to reproduce the issue
import os
import psutil

import numpy as np
from tensorflow.keras.layers import (
    LSTM,
    Bidirectional,
    Dense,
    Input,
)
from tensorflow.keras.models import Model
from tensorflow.keras.optimizers import Adam

def dummy_model(n_classes, n_features, seq_length):
    input = Input(shape=(seq_length, n_features))
    main = Bidirectional(LSTM(128, return_sequences=False))(input)

    prediction = Dense(n_classes, activation="softmax")(main)
    optimiser = Adam(lr=1e-3)
    model = Model(inputs=[input], outputs=prediction)
    model.compile(optimiser, "categorical_crossentropy", metrics=["accuracy"])
    return model

def fit_model():
    x_train = np.random.random_sample((1000, 50, 100))
    x_train = x_train.astype(np.float32)
    y_train = np.zeros((1000, 10), dtype=np.float32)
    model = dummy_model(n_classes=10, n_features=100, seq_length=50)
    model.fit(
        x_train, y_train, epochs=1,
        validation_split=0.1, batch_size=64,
        verbose=0
    )

if __name__ == "__main__":
    process = psutil.Process(os.getpid())
    n = 20

    for i in range(n):
        fit_model()
        print(f"#--- Run {i + 1} of {n} memory used (MB): {process.memory_info().rss / 1e6}")

Other info / logs
#--- Run 1 of 20 memory used (MB): 731.81184
#--- Run 2 of 20 memory used (MB): 991.137792
#--- Run 3 of 20 memory used (MB): 1027.985408
#--- Run 4 of 20 memory used (MB): 1089.724416
#--- Run 5 of 20 memory used (MB): 1127.616512
#--- Run 6 of 20 memory used (MB): 1165.471744
#--- Run 7 of 20 memory used (MB): 1211.96544
#--- Run 8 of 20 memory used (MB): 1247.653888
#--- Run 9 of 20 memory used (MB): 1272.410112
#--- Run 10 of 20 memory used (MB): 1289.478144
#--- Run 11 of 20 memory used (MB): 1298.57536
#--- Run 12 of 20 memory used (MB): 1317.429248
#--- Run 13 of 20 memory used (MB): 1346.781184
#--- Run 14 of 20 memory used (MB): 1369.145344
#--- Run 15 of 20 memory used (MB): 1402.55232
#--- Run 16 of 20 memory used (MB): 1409.634304
#--- Run 17 of 20 memory used (MB): 1413.599232
#--- Run 18 of 20 memory used (MB): 1419.091968
#--- Run 19 of 20 memory used (MB): 1450.14784
#--- Run 20 of 20 memory used (MB): 1468.604416

Issue also appears to occur with 2.2.0rc3
Explicitly setting the following (as was recommended in this blog post - http://gregoryzynda.com/python/tensorflow/memory/leak/rnn/lstm/2019/10/17/lstm-memory-leak.html) appears to help mitigate this (although memory still increases):
tf.config.threading.set_intra_op_parallelism_threads(2)
tf.config.threading.set_inter_op_parallelism_threads(5)

As does explicitly running garbage collection gc.collect() after each iteration.

I was able to reproduce the issue in colab with TF 2.1.0 , 2.2.0rc3 . Please, find the gist here.Thanks!

Sorry, is it related with this? or not?
https://github.com/tensorflow/tensorflow/issues/38617

@alimhanif I think #38617 is a different (that is specific to 2.2rc3 and related to distributed gpu training). This issue seems like it is due to the LSTM layer, I do not see the same memory increase without it

Thanks for reporting the issue. I did following experiments with latest tf-nightly 2.2.0.dev20200503, and it seems that it might be a issue for TF runtime.

I change to create model and data only once (move them from fit_model to be above the for loop before training), and the increasing of the memory usage still occurs.

I change the model structure to remove the LSTM and Bidirectional wrapper, and only use the Dense layer, and increasing of the memory usage still occurs.

With this observation, I will send this to someone of TF core team for further investigation.

Did one more test, it seems that the memory increase was greatly reduced with validation_split is not used. This indicates that keras model might have some leak when creating the validation dataset under the hood.

Thanks @qlzh727
I tried removing the validation_split (both creating the split manually and turning off validation altogether) using TF 2.2.0rc3 and the memory still increases in a similar way to the notebook shared by @ravikyram above.
I also tried changing the model structure to remove the LSTM and can confirm what you reported above, the memory usage still increases.
Please see the following colab notebook.

Could you try calling tf.keras.backend.clear_session() on every iteration?

@kkimdev Yes, calling tf.keras.backend.clear_session() does not appear to help

@qlzh727 I just tried this again with TF 2.2.0 on Ubuntu 18.04.3. I used the same script as in the original post but create the training/validation data once outside of the loop and use this instead of validation_split (same as the final cell of this notebook. There still appears to be an increase in memory which I do not see if I run in a colab notebook.

@dannyfriar. Thanks for the update.
I updated your code to also create the model outside of the for loop, which is the more standard behavior. With that there isn't much memory leak.
Having said that, the memory leak still appears when validation_split is used. I will focus on that.
/Users/scottzhu/tf-2.2/bin/python /Users/scottzhu/Library/Preferences/PyCharmCE2018.1/scratches/scratch_17.py
2020-06-01 20:50:38.363168: I tensorflow/core/platform/cpu_feature_guard.cc:143] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2020-06-01 20:50:38.385048: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x13b428490 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-06-01 20:50:38.385063: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
#--- Run 1 of 20 memory used (MB): 424.79616
#--- Run 2 of 20 memory used (MB): 431.009792
#--- Run 3 of 20 memory used (MB): 433.84832
#--- Run 4 of 20 memory used (MB): 434.60608
#--- Run 5 of 20 memory used (MB): 435.093504
#--- Run 6 of 20 memory used (MB): 436.195328
#--- Run 7 of 20 memory used (MB): 437.420032
#--- Run 8 of 20 memory used (MB): 437.837824
#--- Run 9 of 20 memory used (MB): 438.714368
#--- Run 10 of 20 memory used (MB): 439.410688
#--- Run 11 of 20 memory used (MB): 440.037376
#--- Run 12 of 20 memory used (MB): 440.000512
#--- Run 13 of 20 memory used (MB): 440.000512
#--- Run 14 of 20 memory used (MB): 439.865344
#--- Run 15 of 20 memory used (MB): 440.037376
#--- Run 16 of 20 memory used (MB): 441.430016
#--- Run 17 of 20 memory used (MB): 441.430016
#--- Run 18 of 20 memory used (MB): 441.28256
#--- Run 19 of 20 memory used (MB): 441.704448
#--- Run 20 of 20 memory used (MB): 441.704448
Process finished with exit code 0

With fix in https://github.com/tensorflow/tensorflow/commit/ce2f9824eee904d60fdc0444ac8a82b217ea9149, the memory usage for validation_split is reduced.
Please note that I update the snippet to defined the model only once, and fit within the for loop. This is more aligned to normal workflow by user.
If you need to define multiple model in a loop, you might want to use keras.backend.clear_session() to remove unused the models in the keras global graph.

Memory log before change:
#--- Run 1 of 20 memory used (MB): 420.94592
#--- Run 2 of 20 memory used (MB): 455.458816
#--- Run 3 of 20 memory used (MB): 480.89088
#--- Run 4 of 20 memory used (MB): 504.799232
#--- Run 5 of 20 memory used (MB): 465.563648
#--- Run 6 of 20 memory used (MB): 485.797888
#--- Run 7 of 20 memory used (MB): 506.544128
#--- Run 8 of 20 memory used (MB): 526.76608
#--- Run 9 of 20 memory used (MB): 547.782656
#--- Run 10 of 20 memory used (MB): 487.981056
#--- Run 11 of 20 memory used (MB): 508.862464
#--- Run 12 of 20 memory used (MB): 528.904192
#--- Run 13 of 20 memory used (MB): 549.933056
#--- Run 14 of 20 memory used (MB): 570.032128
#--- Run 15 of 20 memory used (MB): 510.455808
#--- Run 16 of 20 memory used (MB): 530.501632
#--- Run 17 of 20 memory used (MB): 551.559168
#--- Run 18 of 20 memory used (MB): 571.408384
#--- Run 19 of 20 memory used (MB): 529.518592
#--- Run 20 of 20 memory used (MB): 549.376
Memory log after change:
#--- Run 1 of 20 memory used (MB): 441.933824
#--- Run 2 of 20 memory used (MB): 463.753216
#--- Run 3 of 20 memory used (MB): 465.801216
#--- Run 4 of 20 memory used (MB): 466.366464
#--- Run 5 of 20 memory used (MB): 467.0464
#--- Run 6 of 20 memory used (MB): 467.709952
#--- Run 7 of 20 memory used (MB): 468.668416
#--- Run 8 of 20 memory used (MB): 468.62336
#--- Run 9 of 20 memory used (MB): 474.35776
#--- Run 10 of 20 memory used (MB): 474.353664
#--- Run 11 of 20 memory used (MB): 474.472448
#--- Run 12 of 20 memory used (MB): 474.648576
#--- Run 13 of 20 memory used (MB): 474.697728
#--- Run 14 of 20 memory used (MB): 474.750976
#--- Run 15 of 20 memory used (MB): 474.804224
#--- Run 16 of 20 memory used (MB): 474.800128
#--- Run 17 of 20 memory used (MB): 474.857472
#--- Run 18 of 20 memory used (MB): 474.918912
#--- Run 19 of 20 memory used (MB): 475.086848
#--- Run 20 of 20 memory used (MB): 475.348992


fix failing workflow run

Description
the last workflow run for osm failed. this was caused by a case mismatch in the name of the osm binary
This PR fixes #
https://github.com/layer5io/meshery-smp-action/runs/4264742948?check_suite_focus=true
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@s1ntaxe770r Where do we use the mesh_deploy script?

oops , that was meant to be a fix for #20

@s1ntaxe770r still engaged here?

Yes

@s1ntaxe770r We should also switch the scripts used in the workflows with this new script, test and make sure it is working as intended. Any issues in mesheryctl that prevents this should be fixed.

@s1ntaxe770r I'm confused about the current status, there are same code changes mesh_deploy in https://github.com/layer5io/meshery-smp-action/pull/25/files. Can you please make this PR to only for fixing osm worflow, and move mesh_deploy codes to #25

PR abandoned.


DbContext.X.Where().Include(x => x.Y) may load Y as added entity

Hi,
I have 2 classes (X and Y) with INotifyPropertyChanged
Somethink like:
public class X : INotifyPropertyChanged
{
    public Y YRef {
            get { return ...; }
            set { ... = value; NotifyPropertyChange(...); } // NotifyPropertyChange is important!
    }
    // some PK + properties

}
public class Y : INotifyPropertyChanged
{
    // some PK + properties
}

When I execute:
dbContext.Xs.Where<X>(x => x.ID == 1).Include(x => x.YRef).ToArray();

everything is OK...I have 2 entries in unmodified state...BUT:
dbContext.Xs.Single<X>(x => x.ID == 1); // it's cache instance in entry
dbContext.Xs.Where<X>(x => x.ID == 1).Include(x => x.YRef).ToArray();

Instance (type Y) in YRef property has Added state.
I mean, that YRef call PropertyChanged and StateManager start tracking entity...and because entry is Detached...state is set to Added.
Is it understandable? Thx.
PS: sry...my English is not perfect :)

@ajcvickers did you see this? Seems interesting.

Any news/progress? :)


Sort stac_extensions

During post processing of STAC Items (currently in the handler, when the task name and version are added), the stac_extensions should be sorted. This will ensure consistent output files that only differ in the order in which extensions were added.

newer versions of pystac do this automatically for Item

newer versions of pystac do this automatically for Item

Do they? I can't find where that happens, but maybe I'm missing it.


Consider exporting @data from Moshi.Data and @match from Moshi.Match

I think it'd be good if by default Moshi.Data exported @data and Moshi.Match exported @match. Then a user in the REPL can quickly write in one line
using Moshi.Data, Moshi.Match

This way, @data and @match still aren't exported from Moshi itself by default, but there's an easy way to bring them into the namespace with less typing.

See #12. I don't like exporting things by default, but I can consider supporting using Moshi.Prelude, which exports all public APIs into namespace.
cc: @jariji

I really disagree with the idea of not exporting things. IMO, expected APIs should be exported because it's very useful for the REPL and other interactive use-cases.
It should be the responsibility of packages to avoid regular using and instead write things like
using Moshi.Data: Data, @data

Also, we don't need to necessarily export @data and @match from Moshi, we can just export them from Moshi.Data and Moshi.Match.

I really disagree with the idea of not exporting things. IMO, expected APIs should be exported because it's very useful for the REPL and other interactive use-cases.

I'm afraid I have to disagree with this. People are lazy by default. Exporting things by default would encourage downstream package authors to write a lot of using XXXX instead of using XXXX: abc. This has been something quite annoying maintaining MLStyle-based packages. It has been proven to be the case when collaborating within many packages, people just tend to be lazy and use excuse that I will come back. And the people being lazy here includes myself.
I do not see Moshi serving primarily for REPL. I build the package for more serious and much larger projects. It makes sense for a package primary serve for low-code development and notebook to export a lot of things by default, which is when using XXX exports a lot of names makes sense.
Thus I have to insist on the idea of no export by default unless extra words are being typed for a developer focused package like Moshi. And I believe Moshi.Prelude (if supported) does what you want in REPL with fewer types than using Moshi: @data, @match. But having this interface indicates the existence of the names @data, and @match inside Moshi.
See how interfaces are created here: https://github.com/Roger-luo/Jieko.jl


multiple functionNames

Closes #23

Updated from develop. NB, the tests are currently failing due to the bug in #32

I think I prefer the object syntax:
{
	__(args, locale) {
		return ...
	},
	_s(args, locale) {
		return ...
	},
}

OK, can do! Couple of quick questions:

Do you want to continue allowing localizeCompiler to be a function? Or should it always be an object
What should happen if I specify an object for localizeCompiler and pass a functionName? Just error?

https://github.com/privatenumber/webpack-localize-assets-plugin/pull/24/commits/6fff992edb23ce4de2413b79ff90275239704166, let me know what you think!

I haven't released localizeCompiler yet so it can be replaced to only accept an object
Yep, error

62fe797

Hey, just following up on this. Have you had a chance to review the current code? Thanks!

Thanks so much for your contributions @benjamin-hodgson
Happy to invite you as a maintainer if you would like to help!

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Batching submission calls

At this moment we do 1 api request pr student for fetching submissions.
This could be batched into just one call instead to improve efficiency.

Already implemented.


Why is the first padding vector in embedding layer updated during training

Hello!
I have some confusion about the weight updates for embedding layer, and wondering if someone could shed some light. (It could be a mechanism that I don't understand or could be something missing in my setup)
My original code is lengthy, but here is a summary of the major setup.

I have a vocabulary of V, where the first token gets mapped to index 1.

Therefore the input_dim to the Embedding layer is (V + 1). Because the 0-th index is for sequence padding. For example three sentences of various length, and say max length is 5.
[40,20] [19,17,15] [5] Would be padded as [40,20,0,0,0] [19,17,15,0,0] [5,0,0,0,0]

Let's say with the 0-th index the embedding matrix is called my_embed. and has  (V+1) rows. With the 0-th row being all zeros, the rest initialized from glove word vectors. The Embedding layer is defined as below.
embed_layer = Embedding(input_dim=V+1, output_dim=200, weights=[my_embed],mask_zero=True)

In brief, an input sequence goes through the Embedding layer, and then a MeanPooling(or MaxPooling) layer, and then normal dense layer etc. (Parts after that are not important for the discussion here)

And say after the training is done, and loaded the saved model. I got a embedding matrix called my_adapted_embed which should be different from my_embed, due to back propagation. What I expected is that my_adapted_embed[0] should stay intact to be all zeros. Because they corresponding to the padding 0-th index, where masking should have kept it from updating.  But what I found is my_adapted_embed[0] actually changed.
Could someone shed light here, what is it I don't understand about masking?
Thanks a lot for your help!

Hello,
Nice catch.
I'm not an expert on masking at all. But here is what probably going on with masks.
In most layer implementations we are not using the mask variable in the function call of the layer. Probably because it would be quite expensive to do so, for very marginal gain.
So we end-up using masked values when we do some things like temporal pooling, so the gradients will end-up modifying.
In addition, most layers don't recompute the mask (by overloading compute_mask) using the appropriate border_mode (to keep track of mask-tainted values) and just transfer from the previous mask to the next layer. It's not quite clear that using the same border_mode would be the required behaviour (take for example the case of one very short sequence) which if we compute mask using a border_mode will probably get completely masked, and therefore it will be impossible to learn any short sequence)
    #in _Pooling1D(Layer): we don't use the mask variable inside call

    def call(self, x, mask=None):
        x = K.expand_dims(x, 2)   # add dummy last dimension
        output = self._pooling_function(inputs=x, pool_size=self.pool_size,
                                        strides=self.st,
                                        border_mode=self.border_mode,
                                        dim_ordering='tf')
      return K.squeeze(output, 2) # remove dummy last dimension`

And this is why your value get modified, and you probably shouldn't worry :)

Okay I see. Thanks a lot for your quick response!


Fix some typos (found by codespell)

Signed-off-by: Stefan Weil<EMAIL_ADDRESS>

@bertsky, I think this one is ready for merging now.


[Feature Request] RNTP with expo-av support

What is the need and use case of this feature?
My company's app needs RNTP and expo-av to be compatible with one another. We use expo-av for playing small audio clips on button-presses. We need this to happen separate from any long-form audio content that's already playing. So...we need multiple audio instances running at the same time.
The RNTP Queue format would be burdensome for playing the short audio clips. But the RNTP Queue format also makes managing our long-form audio very easy. So ideally, we have RNTP to manage our long-form and expo-av to manage our short clips.
However, after setting up both systems, it doesn't appear possible for RNTP's lockscreen controls to work (they don't appear at all) when expo-av is enabled with background mode. If you keep expo-av background mode disabled, the RNTP lockscreen controls work but background audio does not.
I know that both can coexist because I was previously using expo-ev with react-native-music-control (RNMC), and the RNMC lockscreen controls worked fine when expo-av background mode was enabled. Unfortunately, RNMC is poorly maintained and never made the updates necessary to support Android 12.
Describe the ideal solution
So, the ideal scenario is that my company can continue to use expo-av for playing short clips, and RNTP for playing long-form audio, while maintaining the functionality of lockscreen controls and background mode.
Describe alternatives you've considered
I've considered trying to patch RNMC, but my company isn't large enough yet to maintain such a project. I've considered using other methods (like react-native-sound) for playing short clip audio, rather than expo-av; and I will be exploring this further.
How I can Help
At the moment, I can provide feedback and help debugging. But I can't provide much developer support for another year or so, as we are a very early startup. If all goes well, I can dedicate developer hours to helping maintain RNTP at that time.

Same use case here. We have a lot of short audio clips (1-10 secs) and longer podcast-style audio (10-30 minutes). We currently use expo-av for both, but would like to use this library for our longer form audio (so that we can utilise the lock screen controls).
Unfortunately both libraries use different versions of ExoPlayer, and this library seems to use a custom build of ExoPlayer -- https://github.com/doublesymmetry/ExoPlayer (com.doublesymmetry.exoplayer) which prevents the Android app from building (due to duplicate classes) and dependency resolution was somewhat challenging beause of custom symbols (com.google.android.exoplayer2.ui.PlayerNotificationManager. PrimaryActionReceiver)
The following Android config seems to build and not crash on startup with the following packages:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Can't guarantee stability between packages (because expo-av is using exoplayer 2.13.3 and react-native-track-player is using a custom version of exoplayer 2.17.2)
// android/app/build.gradle

configurations.all {
    resolutionStrategy.dependencySubstitution {
        substitute(module("com.google.android.exoplayer:exoplayer"))
                .using(module("com.github.doublesymmetry.Exoplayer:exoplayer:r2.17.2")).because("Duplicate dependency")
        substitute(module("com.google.android.exoplayer:exoplayer-core"))
                .using(module("com.github.doublesymmetry.Exoplayer:exoplayer-core:r2.17.2")).because("Duplicate dependency")
         substitute(module("com.google.android.exoplayer:exoplayer-common"))
                .using(module("com.github.doublesymmetry.Exoplayer:exoplayer-common:r2.17.2")).because("Duplicate dependency")
    }
}

@jamsch @russriser as of v3.1.0 we no longer use a custom fork of Exoplayer.

Great, thank you. That should resolve the Duplicates problem so I don't need my ConfigPlugin anymore.
I don't think it resolves this issue though. It is still not possible to use expo-av and RNTP while having both background audio and lockscreen controls enabled.

@russriser Try using expo-av's setAudioModeAsync to set the audio mode prior to audio playback
import { Audio, InterruptionModeAndroid, InterruptionModeIOS } from "expo-av";
import TrackPlayer, { Track } from "react-native-track-player";

function setAudioMode() {
  Audio.setAudioModeAsync({
    allowsRecordingIOS: false,
    staysActiveInBackground: true,
    interruptionModeIOS: InterruptionModeIOS.DoNotMix, // Audio.INTERRUPTION_MODE_IOS_MIX_WITH_OTHERS,
    playsInSilentModeIOS: true,
    shouldDuckAndroid: true,
    interruptionModeAndroid: InterruptionModeAndroid.DuckOthers,
    playThroughEarpieceAndroid: false,
  });
}

function play() {
  // Configures audio options (iOS mostly needs this so that media center controls work correctly)
  await configureAudioMode();
  // Add the track
  await TrackPlayer.add(track);
}

@jamsch is the issue resolved for you now?

It appears the solution was to add the interuptionModeIOS. Working for me now.
So maybe this could be added to the documentation somewhere? I don't know where since its not really expo-av nor RNTP specific.

There does seem to still be a remaining problem on Android. The app crashes when trying to play audio clips with expo-av when RNTP is installed. Seems to maybe be a conflict with exoplayer version or something.
@jamsch do you have the same problem?
here's the log:
Your app just crashed. See the error below.

java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/exoplayer2/Player$EventListener;
at expo.modules.av.player.PlayerData.createUnloadedPlayerData(PlayerData.java:192)
at expo.modules.av.AVManager.lambda$loadForSound$1$expo-modules-av-AVManager(AVManager.java:427)
at expo.modules.av.AVManager$$ExternalSyntheticLambda1.run(Unknown Source:8)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7870)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
at Caused By dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:259)
at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
at expo.modules.av.player.PlayerData.createUnloadedPlayerData(PlayerData.java:192)
at expo.modules.av.AVManager.lambda$loadForSound$1$expo-modules-av-AVManager(AVManager.java:427)
at expo.modules.av.AVManager$$ExternalSyntheticLambda1.run(Unknown Source:8)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7870)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

@russriser Yep, I had the same issue. It looks like expo-av uses an older version of ExoPlayer (v2.13.3) while this lib uses ExoPlayer 2.18.1. ExoPlayer doesn't follow semver and seems to have a lot of breaking changes across minor versions.
So I've whipped up a patch for expo-av to use the latest ExoPlayer. I have very little Java knowledge, but just briefly tested some short audio and video clips which seems to be working OK.
/patches/expo-av+12.0.4.patch
diff --git a/node_modules/expo-av/android/build.gradle b/node_modules/expo-av/android/build.gradle
index 767db05..e36aa50 100644
--- a/node_modules/expo-av/android/build.gradle
+++ b/node_modules/expo-av/android/build.gradle
@@ -151,7 +151,7 @@ dependencies {
   extractHeaders 'com.facebook.fbjni:fbjni:0.2.2:headers'
   extractJNI 'com.facebook.fbjni:fbjni:0.2.2'

-  api 'com.google.android.exoplayer:exoplayer:2.13.3'
+  api 'com.google.android.exoplayer:exoplayer:2.18.1'
   api 'com.google.android.exoplayer:extension-okhttp:2.13.3'

   api "com.squareup.okhttp3:okhttp:3.14.9"
diff --git a/node_modules/expo-av/android/src/main/java/expo/modules/av/player/SimpleExoPlayerData.java b/node_modules/expo-av/android/src/main/java/expo/modules/av/player/SimpleExoPlayerData.java
index 8f1b9ed..6494d10 100644
--- a/node_modules/expo-av/android/src/main/java/expo/modules/av/player/SimpleExoPlayerData.java
+++ b/node_modules/expo-av/android/src/main/java/expo/modules/av/player/SimpleExoPlayerData.java
@@ -13,12 +13,12 @@ import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;

 import com.google.android.exoplayer2.C;
-import com.google.android.exoplayer2.ExoPlaybackException;
 import com.google.android.exoplayer2.MediaItem;
+import com.google.android.exoplayer2.PlaybackException;
 import com.google.android.exoplayer2.PlaybackParameters;
 import com.google.android.exoplayer2.Player;
 import com.google.android.exoplayer2.SimpleExoPlayer;
-import com.google.android.exoplayer2.source.ExtractorMediaSource;
+import com.google.android.exoplayer2.source.ProgressiveMediaSource;
 import com.google.android.exoplayer2.source.LoadEventInfo;
 import com.google.android.exoplayer2.source.MediaLoadData;
 import com.google.android.exoplayer2.source.MediaSource;
@@ -36,8 +36,8 @@ import com.google.android.exoplayer2.upstream.DataSource;
 import com.google.android.exoplayer2.upstream.DataSpec;
 import com.google.android.exoplayer2.upstream.DefaultBandwidthMeter;
 import com.google.android.exoplayer2.upstream.RawResourceDataSource;
+import com.google.android.exoplayer2.video.VideoSize;
 import com.google.android.exoplayer2.util.Util;
-import com.google.android.exoplayer2.video.VideoListener;

 import java.io.IOException;
 import java.util.Map;
@@ -47,7 +47,7 @@ import expo.modules.av.AudioFocusNotAcquiredException;
 import expo.modules.av.player.datasource.DataSourceFactoryProvider;

 class SimpleExoPlayerData extends PlayerData
-  implements Player.EventListener, MediaSourceEventListener, VideoListener {
+  implements Player.Listener, MediaSourceEventListener {

   private static final String IMPLEMENTATION_NAME = "SimpleExoPlayer";
   private static final String TAG = SimpleExoPlayerData.class.getSimpleName();
@@ -92,7 +92,6 @@ class SimpleExoPlayerData extends PlayerData
         .build();

     mSimpleExoPlayer.addListener(this);
-    mSimpleExoPlayer.addVideoListener(this);

     // Produces DataSource instances through which media data is loaded.
     final DataSource.Factory dataSourceFactory = mAVModule.getModuleRegistry()
@@ -312,7 +311,7 @@ class SimpleExoPlayerData extends PlayerData
   }

   @Override
-  public void onPlayerError(final ExoPlaybackException error) {
+  public void onPlayerError(final PlaybackException error) {
     onFatalError(error.getCause());
   }

@@ -325,7 +324,7 @@ class SimpleExoPlayerData extends PlayerData
     // Source: https://google.github.io/ExoPlayer/doc/reference/com/google/android/exoplayer2/Timeline.Period.html
     // So I guess it's safe to say that when a period transition happens,
     // media file transition happens, so we just finished playing one.
-    if (reason == Player.DISCONTINUITY_REASON_PERIOD_TRANSITION) {
+    if (reason == Player.DISCONTINUITY_REASON_AUTO_TRANSITION) {
       callStatusUpdateListenerWithDidJustFinish();
     }
   }
@@ -366,9 +365,11 @@ class SimpleExoPlayerData extends PlayerData
   // region VideoListener

   @Override
-  public void onVideoSizeChanged(final int width, final int height, final int unAppliedRotationDegrees, final float pixelWidthHeightRatio) {
+  public void onVideoSizeChanged(VideoSize videoSize) {
+
+    // final int width, final int height, final int unAppliedRotationDegrees, final float pixelWidthHeightRatio
     // TODO other params?
-    mVideoWidthHeight = new Pair<>(width, height);
+    mVideoWidthHeight = new Pair<>(videoSize.width, videoSize.height);
     if (mFirstFrameRendered && mVideoSizeUpdateListener != null) {
       mVideoSizeUpdateListener.onVideoSizeUpdate(mVideoWidthHeight);
     }
@@ -405,7 +406,7 @@ class SimpleExoPlayerData extends PlayerData
       case C.TYPE_HLS:
         return new HlsMediaSource.Factory(factory).createMediaSource(MediaItem.fromUri(uri));
       case C.TYPE_OTHER:
-        return new ExtractorMediaSource.Factory(factory).createMediaSource(MediaItem.fromUri(uri));
+        return new ProgressiveMediaSource.Factory(factory).createMediaSource(MediaItem.fromUri(uri));
       default: {
         throw new IllegalStateException("Content of this type is unsupported at the moment. Unsupported type: " + type);
       }
diff --git a/node_modules/expo-av/android/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java b/node_modules/expo-av/android/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java
index d127b7f..f86e3a6 100644
--- a/node_modules/expo-av/android/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java
+++ b/node_modules/expo-av/android/src/main/java/expo/modules/av/player/datasource/CustomHeadersOkHttpDataSourceFactory.java
@@ -9,6 +9,7 @@ import com.google.android.exoplayer2.upstream.HttpDataSource;
 import com.google.android.exoplayer2.upstream.TransferListener;

 import java.util.Map;
+import java.util.HashMap;

 import okhttp3.CacheControl;
 import okhttp3.Call;
@@ -28,16 +29,19 @@ public class CustomHeadersOkHttpDataSourceFactory extends HttpDataSource.BaseFac
     mCallFactory = callFactory;
     mUserAgent = userAgent;
     mCacheControl = null;
-    updateRequestProperties(getDefaultRequestProperties(), requestHeaders);
+    updateRequestProperties(requestHeaders);
   }

-  protected void updateRequestProperties(HttpDataSource.RequestProperties requestProperties, @Nullable Map<String, Object> requestHeaders) {
+  protected void updateRequestProperties(@Nullable Map<String, Object> requestHeaders) {
     if (requestHeaders != null) {
-      for (Map.Entry<String, Object> headerEntry : requestHeaders.entrySet()) {
-        if (headerEntry.getValue() instanceof String) {
-          requestProperties.set(headerEntry.getKey(), (String) headerEntry.getValue());
+      Map<String, String> headers = new HashMap<>();
+      for (Map.Entry<String, Object> entry : requestHeaders.entrySet()) {
+        Object value = entry.getValue();
+        if (value instanceof String) {
+          headers.put(entry.getKey(), entry.getValue().toString());
         }
       }
+      setDefaultRequestProperties(headers);
     }
   }

Just install patch-package and place the above in /patches/expo-av+12.0.4.patch and it should apply the changes.

Closing this issue as it looks like it's resolved by the comment above.

@jamsch Thank you!

Hey guys, has anyone found a way how to recover lockscreen audio controls that react-native-track-player provides after playing Video via Expo-AV? Expo-AV surely overrides something and the lockscreen audio controls cannot be shown afterwards. Running setupPlayer second time won't probably do anything because there is already instance existing, right? I am on nightly.

@russriser Try using expo-av's setAudioModeAsync to set the audio mode prior to audio playback
import { Audio, InterruptionModeAndroid, InterruptionModeIOS } from "expo-av";
import TrackPlayer, { Track } from "react-native-track-player";

function setAudioMode() {
  return Audio.setAudioModeAsync({
    allowsRecordingIOS: false,
    staysActiveInBackground: true,
    interruptionModeIOS: InterruptionModeIOS.DoNotMix, // Audio.INTERRUPTION_MODE_IOS_MIX_WITH_OTHERS,
    playsInSilentModeIOS: true,
    shouldDuckAndroid: true,
    interruptionModeAndroid: InterruptionModeAndroid.DuckOthers,
  });
}

async function play() {
  // Configures audio options (iOS mostly needs this so that media center controls work correctly)
  await setAudioMode();
  // Add the track
  await TrackPlayer.add(track);
}

This saved me after hours of struggling, thank you!
For future folks the key is the interruptionModeIOS value above

Hey guys, has anyone found a way how to recover lockscreen audio controls that react-native-track-player provides after playing Video via Expo-AV? Expo-AV surely overrides something and the lockscreen audio controls cannot be shown afterwards. Running setupPlayer second time won't probably do anything because there is already instance existing, right? I am on nightly.

I am facing the same issue. When using expo-av audio controls in lock screen are overwritten and gone.


Parse and mul functions

A possible solution to multiplication of infinite numbers and extensions to the parse function to support infinity better.
See issue #5

ok, sorry I had exams so did't have time to properly look at this.
This only test that now fails is i * Infinity which "should" be NaN but is now imaginary infinity.
Would be happy to extend the test suit to properly test infinite values if you are happy with the new behaviour.

I like your pull request and I think I'm happy with the change. The question I'm still struggling with is how we should represent complex infinity. I think INF/INF isn't the best implementation for that. What do you think?
From my perspective, it's totally fine to make i*Infinity NaN. One last question about your code:
How does
          P['im'] = a['arg'] === 0
             ? 0
             : a['abs'] * Math.sin(a['arg']);

make any difference? Am I missing something?

INF/INF

I represented ComplexInfinity this way as it did not require adding an extra property to complex objects.
I also tried giving each object a Boolean flag and even a completely distinct type to represent infinity but both ended up more complicated.
The mul function is the uglyist function by far - every other function that I looked at requires only minor changes to support infinities in this way.
toString could do some formatting so that the user wouldn't need to know that ComplexInfinity is represented as INF/INF.

i*Infinity

If 1 * Infinity is supported by complex.js then I think it follows that i * Infinity should also be supported.
Wolfram defines ComplexInfinity to have indeterminate or unkwon argument and so i * Infinity cannot be ComplexInfinity so I thought it made sense to have it as an imaginary infinity.

Parsing
 P['im'] = a['arg'] === 0
             ? 0
             : a['abs'] * Math.sin(a['arg']);

Is there to convert { abs: Infinity, are: 0} to { re: Infinty, im: 0 }.
With out this conditional: abs * sin(arg) === Infinity * 0 === NaN.

INF/INF

The Question is, if INF/INF is the best way to do this. I'm not completely sure yet, but maybe 0/INF is a better option (from a mathematical standpoint). From a technical point of view, it would be nice if we could reduce the amount of code needed to handle these cases. But for now it's ok.
I'm not in favor of a boolean flag for infinity.
I think many functions handle the Infinity case correctly already. Question is, if we should fix all the trig functions as well - which would require loads of code addition
Yep, toString definitely should handle the infinity case to make it pretty.

i*Infinity
Makes sense
Parsing
Makes sense. Could you please add a small comment on the reasoning to the code?

At the moment 0/INF represents imaginary infinity.
Currently a complex object can either be:

Finite.
Plus or minus {re: Infinity, im: 0}.
Plus or minus {re: 0, im: Infinity}.
{re: Infinity, im: Infinity} aka ComplexInfinity .

Values like {re: 5, im: Infinity} get coverted to ComplexInfinity.
As far as I can tell, most functions do handle it correctly.
Trig is tricky. sin(Infinity) oscillates but sin(i * Infinity) would tend to (real) Infinity.
Maybe just return ComplexNaN.

I have entirely re-written the mul function.
Now:

First the function checks if the result will be NaN.
Otherwise carries out the multiplication coercing all NaN values to zero.
Constructing a new Complex object will then convert value like 5 + ∞i to ComplexNaN.

This is pretty nice! Thanks for the heavy work on this subject. I really like the current version :)


Config isn't validating for missing protocol before saving

Probably the same underlying issue as https://github.com/openziti/ziti-console/issues/524

Should be resolved now as part of changes for #562


use froms

there a plan to display forms~

This project already have function to display panel form by call this
Application.showForm(new YourPanelForm());

I  an idea and cannot load the xxx.form. I  very sad

You mean file .form in netbeans ?
It's not for use it's for netbean only, this file essentially represents the design and structure of your GUI in a structured format that NetBeans understands.


navbar spill?

Looks very nice, congrats! Is there an issue with the navbar (spillover) and breakpoint/widths [790px, 1024px]..?  Just noticing.. This is probably not systemic, just a matter related to the logo width, or perhaps a matter of adjusting breaks?  See image:

Thank you so much for your kind words and for taking the time to provide feedback.
You've made a good catch between the breakpoints of 790px and 1024px. It's not a systemic issue but rather a specific scenario that can occur due to the logo width not being fully responsive or breakpoint adjustments being slightly off.
I'm currently in the process of refining grid system, which should address these types of responsive design challenges. Alongside that, I am also focusing on enhancing our documentation to make the implementation as clear as possible for all users.
I'm aiming to roll out updates in next iteration, which will include a more robust solution to this. I'll keep you posted on the progress, and I would love to hear any further suggestions you may have as we move forward.
Thanks again for your support and contribution to improving MinimaCSS.

This issue in demo page is Fixed Now.   #32ea278


is this an error：num_steps += (t + 1)   ？

Is this an error in file core/agent.py line 59:  num_steps += (t + 1)   ?

This is not as if the agent only takes one step, t is still 0


Build error when value of key is only http url

Environment

Operating System: Darwin
Node Version:     v16.12.0
Nuxt Version:     3.9.3
CLI Version:      3.10.0
Nitro Version:    -
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      head, css, components, router, buildModules, modules, site, device, env, i18n, sitemap, robots, io, axios, proxy, server, serverMiddleware, googleFonts, htmlValidator, intercom, rootDir, buildDir, build, telemetry, imports
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    @nuxt/typescript-build, @nuxtjs/stylelint-module

Reproduction
If the value of a key is fully a link, it will throw the error
[plugin:unplugin-vue-i18n] Invalid linked format (error code: 10) in **path-to-project**/assets/lang/en.js
  target message: https://www.google.com/maps/contrib/103353472332847156387/place/ChIJsaMZ6QG5uIkR-BJEAg3EifU/@44.6194791,-45.0197211,4z/data=!4m6!1m5!8m4!1e1!2s103353472332847156387!3m1!1e1?hl=en-US&entry=ttu
  target message path: buy_cs2_skins.most_trusted_trading.review_1.link

Describe the bug
Put full link on a value of a key
Additional context
No response
Logs
No response

close in-activity.
If you have still an issue, please open as new issue.
thanks!


Required attribute doesn't work as expected

If I put the required attribute, and a validate de form, it works, but if I select a value, and then delete thee selection, it doesn't works

Hi @sebrojas14,
could you maybe prepare a codepen example of this issue such that I can reproduce it easily? There was an other issues dealing with this: #5. Therefore an example on how you do the validation would be useful to have a look at it.
Thanks and regards,
Guy

A soon as I have a free minute

Hi @sebrojas14,
are you able to provide a codepen? If not I will close the issue and you can reopen it when you got some time again. Is that ok for you?
Thanks and regards,
Guy


bump edge-containers to include containerd fix

Bumps edge-containers library, which includes latest containerd, which contains the fix for zombie goroutines.

Eden has spoken! Merging.


livox lidar type and feature extract explanatory text

Qusention1：
livox lidar type is horizon？
Qusention2:
Have you understand feature extract detail？I miss in code，and I want apply it to Mid-70

Qusention1：
yes
Qusention2:
I don't know much about this. Its feature extraction is based on Lio livox. You can go to their home page.

Hi chenxianbo,
Thanks for your interest in this repo.
Q1:  Yes.
Q2: The feature extraction part is not our main focus. You may refer to the original one for more details. If you just need to apply this repo for one new sensor setting, I would suggest that you might need to check out the differences between Mid-70 and Horizon first.  Since we do not have Mid-70 available, no detailed help could be offered.
Bests


Type 'Node' is not generic.

Version 1.0.3
Have an error during the build command:
npm ERR! ../../unist-util-find/index.d.ts(16,33): error TS2315: Type 'Node' is not generic.
npm ERR! ../../unist-util-find/index.d.ts(28,33): error TS2315: Type 'Node' is not generic.
npm ERR! ../../unist-util-find/index.d.ts(28,83): error TS2315: Type 'Node' is not generic.

Quick fix:
Add "skipLibCheck": true, to compilerOptions section of tsconfig.json file

New versions are fixed!


Update request: amazon-ssm-agent  3.0.755.0 → 3.2.815.0

Package name: amazon-ssm-agent
Latest released version: 3.2.815.0

Current version on the unstable channel: 3.0.755.0
Current version on the stable/release channel: 3.0.755.0

[x] Checked the nixpkgs pull requests

Notify maintainers

The version packaged is affected by CVE-2022-29527.

Note for maintainers: Please tag this issue in your PR.
@copumpkin

Note that we applied the patch for CVE-2022-29527 in #204876, the security issue should be mitigated.
An upgrade would be nice, I do not remember why but it was not trivial.

Note that we applied the patch for CVE-2022-29527 in #204876, the security issue should be mitigated.
An upgrade would be nice, I do not remember why but it was not trivial.

I think it is due to the patches applied against the package. I was looking at trying to upgrade it in #226960.


User defined spam action

Add a user defined action for selecting a mail as spam.
Example:

Forward as attachment to a fixed address (e.g<EMAIL_ADDRESS>Mark as read
Move to trash

what do you think about that?

I'd rather not include this in K-9 Mail directly. But making it possible for third-party apps to do this is something we could do. See #1508.


docs: init mkdocs project

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.83%. Comparing base (462a2a7) to head (6576b0c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #32   +/-   ##
========================================
  Coverage    95.83%   95.83%
========================================
  Files           17       17
  Lines          336      336
========================================
  Hits           322      322
  Misses          14       14

Components
Coverage Δ

core
100.00% <ø> (ø)

api
88.52% <ø> (ø)

tests
100.00% <ø> (ø)


duplicate symbols for architecture x86_64

After dragging the AirMaps and AirGoogleMaps folders into my xcode project and running react-native run-ios, I get
ld: 175 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

** BUILD FAILED **

Full output here: http://pastebin.com/td7gRy9g
Anyone else have this issue or just me?

Have you managed to solve this? I also have this issue when trying to run it for adhoc on a device.

I'm running into this too. Were either of you able to resolve it yet?

@palmsey nope it wasn't resolved yet. I'm still waiting for other people who might have encountered this too and resolved. And I've been trying things but to no success.

No, I haven't resolved it. I am just using Apple maps on iOS for now. feelsbadman.jpg

I have resolved it, this is my pod file below

# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

target 'App' do
  # Uncomment this line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for NearBy

  pod 'React', path: '../node_modules/react-native', :subspecs => [
  'Core',
  'RCTActionSheet',
  'RCTGeolocation',
  'RCTImage',
  'RCTLinkingIOS',
  'RCTNetwork',
  'RCTSettings',
  'RCTText',
  'RCTVibration',
  'RCTWebSocket'
  ]

  pod "HockeySDK", :subspecs => ['AllFeaturesLib']
  pod 'GoogleMaps'

end
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!

First I made sure that react-native link goes on without an error.
Do the pod install with the above podfile edited with right project
Moved AirGoogleMaps and AirMaps to ios project by dragging.
Removed Airmaps.xcodeproj and libairmaps if it exist in Libraries folder and Build Settings respectively.

i have the exact same error too, also on xcode 8

ok i successfully installed the whole thing by react-native init a new project. I use option 1, I'm on xCode 8, RN 0.36 and node v7, you have to be very careful with each step.
When you drag the folders

make sure that it is "create group" rather than "create folder reference"
use the xcworkspace file instead of .xcodeproj.
if you want googleMap support then import googleMap.h  and add your apikey to your delegate.m file. Screwing one of the steps in option 1 screws up a lot of stuff.
Hope that helps.

Same issue here (175 duplicate symbols, too)
Node 4.5, RN 0.35, xCode 8
Have tried all methods above, not working. Not sure if version matters.
This problem did not exist 5 days ago

@jojonarte
Removing Airmaps.xcodeproj cause missing library during build on my machine.

I resolved this issue and succesfully implemented GMaps on IOS simulator by the followings:
(ref.: http://stackoverflow.com/questions/24298144/duplicate-symbols-for-architecture-x86-64)

Open Xcode > Pods > Targets Support Files > Pods-{TARGET-NAME}
find "OTHER_LDFLAGS" and remove only "-ObjC" in these two files:
Pods-{TARGET-NAME}.release.xcconfig & Pods-{TARGET-NAME}.debug.xcconfig

Go to project main target > Build Settings > Other Linker Flags:
Make sure no "-ObjC" is left in the value

I deleted the build/Build folder in ios and run-ios again. It works now.

Also make sure you have enable Google Maps SDK for iOS on Google APIs console (only enabling API key will not success)

Side effects from the link above: the app may become larger as there may be duplicated symbols during compile
Hope can help you.
P.S. Not yet try on real device

I have same error too...175 duplicate
@knkevinlai  I am unable to remove "-ObjC" because of "$(inherited)" in Build Settings > Other Linker Flags, it will include "-ObjC "

but now I got another error....I got 'GoogleMaps/GoogleMaps.h" file not found compile error

in my case these duplicate errors were occurring because I have .m files for these objects twice in xcode.
Once because "pod install" has added AirMaps.xcodeproj to my project. And another because the react-native-maps instructions told me to drag the AirMaps files into my project. (https://github.com/airbnb/react-native-maps/blob/master/docs/installation.md)
I'm not sure why the instructions tell you to copy the files over - they're already there!
I resolved it simply by not copying the AirMaps folder into my project.

I got the same error and thanks to @jojonarte this step solved my problem:
Removed Airmaps.xcodeproj and libairmaps if it exist in Libraries folder and Build Settings respectively.

getting the same error here =(,
@hossamghareeb when you say: 'Removed Airmaps.xcodeproj and libairmaps if it exist in Libraries folder and Build Settings respectively.
where in the Build Settings?

@arthurnn As far as I remember its in Build Phases not Build Settings under Compile Sources or Link Binary With Libraries

So, now the question is, why the docs say to drag-n-drop the project in xcode, if it will be referenced already on the link binary option.
Should we change the docs to not say to drag-n-drop the project anymore?

So, now the question is, why the docs say to drag-n-drop the project in xcode, if it will be referenced already on the link binary option.
Should we change the docs to not say to drag-n-drop the project anymore?

I have ld: framework not found React error after @jojonarte steps. What should I do?

I was able to fix this issue by following @hzalaz instructions on this following (https://github.com/auth0/react-native-lock/issues/3).
In summary, the duplication issue because you a linking RCT**** Libraries twice, once in your PodFile and again in your SubProjects.

@tonygriv my solution might not anymore be relevant with the latest update as it was way back a few updates ago.

Look at your Podfile, take a note of all the modules declared in there and remove those exact modules in Xcode under Libraries. This helped for react-native: 0.41.2.

Just chiming in, I finally got around the duplicate symbols problem on all build configs (Debug/Release/Archive) with the following steps:
Versions:

react-native v42
react-native-maps v0.14.0

If you have an existing project, clear out any modifications to your Podfile that you've made while following the install instructions/GH issue comments
Remove any and all AirMaps and/or AirGoogleMaps Libraries/References from your XCode Project / Workspace
Make sure the default React xcodeprojects are listed under your XCode Libraries, as they won't be added to the Podfile (see screenshot 1 below).

Install and link the regular react-native-maps module without using Pods!
npm install --save react-native-maps
react-native-link react-native-maps
At this point you should have the AirMaps.xcodeproj under your Libraries folder in XCode (screenshot 1), and libAirMaps.a and the default React libs are in your Linked Frameworks and Libraries (screenshot 2)

Now the fun stuff
Drag the AirGoogleMaps folder from node_modules/react-native-maps/lib/ios into the top most level of your Xcode Project, and select add as 'Create Groups' when the popup appears after dropping the folder.
AirGoogleMaps needs the React headers, so add $(SRCROOT)/../node_modules/react-native/React to your Header Search Paths (under Build Settings in Xcode) and make it recursive. Double check the AirMaps path is in there as well (Screenshot 3)

Now AirGoogleMaps should be completely linked, the GoogleMaps pod just needs to be installed.
Go to the Podfile, and add pod 'GoogleMaps', and run pod install (Screenshot 4)

Now run Run/Build/Archive, and it should all compile without duplicate symbols!

Successfully tested on a real iOS device with a Google Map and custom styles (just to really confirm it was a GMap rendering).

--
Please let me know if this works for anyone else, if it fixes the problem for everyone then I'll make a PR to update the install documentation

@se1exin thanks lot it works.
UPDATE DOCUMENTATION.
Please create PR.

@AshokICreate awesome, glad to hear it was helpful. I'll make a PR for the docs tonight after if finish work.

Weird! For me, @knkevinlai solution worked but not @se1exin 's one.
My podfile:
source 'https://github.com/CocoaPods/Specs.git'

platform :ios, '8.0'

target 'gmp' do
  use_frameworks!

  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'React', path: '../node_modules/react-native', :subspecs => [
    'Core',
    'RCTActionSheet',
    'RCTGeolocation',
    'RCTImage',
    'RCTLinkingIOS',
    'RCTNetwork',
    'RCTSettings',
    'RCTText',
    'RCTVibration',
    'RCTWebSocket',
    'BatchedBridge',
    'DevSupport'
  ]
  pod 'GoogleMaps'  # <~~ remove this line if you do not want to support GoogleMaps on iOS

end

I am kind of concern about size increase due to duplicated symbols but since I have been struggling on that for days, I'll keep it that way for now.
Using react-native: 0.45.1 and react-native-maps 0.15.3.
So, basically for me: just delete -Objc flags as described previously.

@se1exin It's not working for me on 0.47.1, is that correct?

Hey @se1exin!
Thank you so much for your instructions! Do you have to add your Gmaps api key anywhere though? I ran your steps explicitly on a new react native project and it all worked great, but now I'm scratching my head about the API key stuff :)
Thanks again!!

@RWOverdijk @peterp  - Sorry for the delayed reply, but I'm glad it has been of help!
@peterp - Yep you need to add your API Key to AppDelegate.m. Checkout step 5 of the GMaps iOS setup guide.

@se1exin your solution worked for me aswell.
Thanks!

Followed @se1exin guide, but getting the error message about the missing AirGoogleMaps directory :(

If anyone is still having problems I followed this walkthrough and it worked perfectly. Very easy to follow and has step by step instructions. https://medium.com/@kswanie21/react-native-google-map-with-react-native-maps-572e3d3eee14

@knkevinlai I just wanted to say thank you- your solution is still helping people a year later :)

@8of I can also confirm that this works when you have Libraries and Pods together in one React Native project (any project with a similar structure).

For me the issues was related to frameworks. So I was added explicitly google frameworks in frameworks folder. After removing it, error is gone

Yarn clear worked for me

If you came here not for the maps concrete issue but for a general duplicate symbols for architecture x86_64 error, try @nikolakanacki solution, it worked for me after days of following dead ends.
I think that the error may have been produced by executing pod update. In my case it added
pod 'rn-fetch-blob', :path => '../node_modules/rn-fetch-blob' pod 'react-native-image-picker', :path => '../node_modules/react-native-image-picker'
to my Podfile but I had linked them previously when installing for the first time so they were duplicated.

We were running into similar issues and the only thing that worked for us was first unlinking the libraries we previously linked using react-native link <lib>. This has some more information https://sandstorm.de/de/blog/post/react-native-managing-native-dependencies-using-xcode-and-cocoapods.html

i have linker error it says 240 duplicates for x86_64. i have implemented react native maps and several other pods. Here is my podfile:
Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'Routes' do
rn_path = '../node_modules/react-native'
rn_maps_path = '../node_modules/react-native-maps'
# See http://facebook.github.io/react-native/docs/integration-with-existing-apps.html#configuring-cocoapods-dependencies
pod 'yoga', path: "#{rn_path}/ReactCommon/yoga/yoga.podspec"
pod 'React', path: rn_path, subspecs: [
  'Core',
  'CxxBridge',
  'DevSupport',
  'RCTActionSheet',
  'RCTAnimation',
  'RCTGeolocation',
  'RCTImage',
  'RCTLinkingIOS',
  'RCTNetwork',
  'RCTSettings',
  'RCTText',
  'RCTVibration',
  'RCTWebSocket',
]
# React Native third party dependencies podspecs
pod 'DoubleConversion', :podspec => "#{rn_path}/third-party-podspecs/DoubleConversion.podspec"
pod 'glog', :podspec => "#{rn_path}/third-party-podspecs/glog.podspec"
# If you are using React Native <0.54, you will get the following error:
# "The name of the given podspec `GLog` doesn't match the expected one `glog`"
# Use the following line instead:
#pod 'GLog', :podspec => "#{rn_path}/third-party-podspecs/GLog.podspec"
pod 'Folly', :podspec => "#{rn_path}/third-party-podspecs/Folly.podspec"

# react-native-maps dependencies
pod 'react-native-maps', path: rn_maps_path
pod 'Firebase/Core'
pod 'RNVectorIcons', :path => '../node_modules/react-native-vector-icons'
pod 'react-native-google-maps', path: rn_maps_path  # Uncomment this line if you want to support GoogleMaps on iOS
pod 'GoogleMaps'  # Uncomment this line if you want to support GoogleMaps on iOS
pod 'Google-Maps-iOS-Utils' # Uncomment this line if you want to support GoogleMaps on iOS

end
post_install do |installer|
installer.pods_project.targets.each do |target|
if target.name == 'react-native-google-maps'
target.build_configurations.each do |config|
config.build_settings['CLANG_ENABLE_MODULES'] = 'No'
end
end
if target.name == "React"
target.remove_from_project
end
end
end

screenshot of error is also pasted please help me with this.

@hafizmuhammadshoaib react-native unlink react-native-maps; cd ios; pod install;

@alvelig Thankyou it works like a charm

did this work with react native 0.58 ?
i try to make it work since two days, create a new blank project (with init) and fail with all kind of error.
Did some one have a example project with react 0.58 and maps ?
thank you

i just had to remove libairmaps.a from the search of build phases ;)

i just had to remove libairmaps.a from the search of build phases ;)

It works for me

If you first linked using react-native-maps and then try to use maps with cocoaponds you should make following from @alvelig

@alvelig worked for me as well! Thanks!!!

Try to add code at the very end of Podfile:
post_install do |installer|
  installer.pods_project.targets.each do |target|
    if target.name == "React"
      target.remove_from_project
    end
  end
end

It worked for me,  very Thanks

thanks @alvelig

for me, I solved by keeping podfile as simple as possible below
target 'vexere' do
  platform :ios, '9.0'
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  ...your pod

  pod 'GoogleMaps'  # Remove this line if you don't want to support GoogleMaps on iOS
  pod 'Google-Maps-iOS-Utils'
end

Simply delete (remove reference) 2 folder: AirMaps + AirGoogleMaps in project root then add again
Then add HAVE_GOOGLE_MAPS=1 like here

This issue is already alive for 3 years. "react-native-maps": "^0.24.2", the same problem.

This issue is already alive for 3 years. "react-native-maps": "^0.24.2", the same problem.

@Luckygirlllll  have you followed my solution?
I was able to solve it

Yeah, this helped!
react-native unlink react-native-maps
cd ios
pod install
However, when I will need to make a build for Android I will need to link map again, then unlink for IOS....

In this case you should fully manual linking, no pod, no react-native link

I had a exactly same issues, then I resolved it after I removed all the related Frameworks in project sidebar because it is already linked. It causes a duplicated symbols.

Basically you need to go through your libraries and remove them using the lipo command. Not sure, if this helps but I tried using the steps here https://redflowerinc.com/how-i-solved-the-duplicate-symbols-issue-when-integrating-google-frameworks-sdk-for-ios/