[SPARK-35809][PYTHON] Add index_col argument for ps.sql

What changes were proposed in this pull request?
This PR proposes adding an argument index_col for ps.sql function, to preserve the index when users want.
>>> psdf
   A  B
a  1  4
b  2  5
c  3  6
>>> ps.sql("SELECT * from {psdf} WHERE A > 1", index_col="index")
       A  B
index
b      2  5
c      3  6

Otherwise, the index is always lost.
>>> ps.sql("SELECT * from {psdf} WHERE A > 1")
   A  B
0  2  5
1  3  6

Why are the changes needed?
Index is one of the key object for the existing pandas users, so we should provide the way to keep the index after computing the ps.sql.
Does this PR introduce any user-facing change?
Yes, the new argument is added.
How was this patch tested?
Add a unit test and manually check the build pass.

Test build #141379 has started for PR 33450 at commit 8babef0.

Test build #141379 has finished for PR 33450 at commit 8babef0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141379/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45895/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45895/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45895/

Test build #141392 has started for PR 33450 at commit 1615bd6.

Test build #141392 has finished for PR 33450 at commit 1615bd6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141392/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45910/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45910/

Test build #141461 has started for PR 33450 at commit 63c8f4b.

@itholic Could you also update the description?

Test build #141461 has finished for PR 33450 at commit 63c8f4b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141461/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45980/

@itholic Could you also update the description?

Just updated. Thanks

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45980/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45980/

Let me fix the doctest

Test build #141470 has started for PR 33450 at commit 9bac117.

Test build #141470 has finished for PR 33450 at commit 9bac117.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141470/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45988/

Merged to master and branch-3.2.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45988/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45988/


fix(componenet-sidebar): change the order of items as it appears

Closes nothing
📝 Description
This fix reorders the links of the components as presented in the docs.
⛳ Current behavior (updates)
When navigating from MEDIA AND ICONS section, from the Image component to the next component, you get to Transition, which isn't the first component in the OTHER section.

so the current NEXT order is:
Image-> Transitions -> Portal -> Show/Hide -> Close Button
🚀 New behavior
Fix the order to be sequential.
new NEXT order is:
Image -> Close Button -> Portal -> Show/Hide -> Transitions
Just like in the visual presented order

💣 Is this a breaking change (Yes/No):
NO
📝 Additional Information
NO

LGTM. Nice catch, @eliyabar!


sbt in interactive mode hangs in git for windows bash

Steps

Download a windows git version from https://git-scm.com/download/win .
During install check Use mintty (the default terminal of MSys2).
Run git-bash.exe
Run sbt
Type tasks and press enter

Problems

Console hangs, and only can exit with Ctrl+C

Expectations

Console should return sbt tasks

Moved to sbt-launcher-package https://github.com/sbt/sbt-launcher-package/issues/95

There is a fix merged, but for ease of use:
https://github.com/sbt/sbt-launcher-package/pull/96/commits/92a06fc5da81ce05a28ee1239e3a99752e067218
 case "$os" in
 CYGWIN*) return 0 ;;
 MINGW*) return 0 ;;
 *)  return 1 ;;
esac


Statusline view in search mode or command line mode

When using cmp-cmdline in search mode (/ or ?), the custom entries menu is displayed vertically, which obscures the buffer when searching -- especially when using incsearch. This new view opens the entries in the statusline, similar to wilder.nvim, which solved the issue.
Some design choices:

Enabled by setting experimental.horizontal_search = true
Only the abbr field for each item is used
Items are separated by |
Fuzzy matches etc are highlighted using cmp highligh groups
the selected item is highlighted using CursorLine, as I don't think statusline supports blending hlgroups.

There might be some bugs, but I have been using it for a while.
Cheers.

@hrsh7th
Regarding not using the statusline: is there any benefit to using a float other than blending highlighting groups?

@tzachar could you send a screenshot?

@max397574
here you go

@hrsh7th
I moved the PR to using a floating window.

@hrsh7th
Any chance of getting this merged?

@hrsh7th
I've been using this PR for the past month. It really made a difference for me.
What more is required to get this merged? You mentioned something about configuration change, but did not elaborate.
Thanks.

Hm...  I think the feature should be configurable.
And the title should be Statusline view in search mode or command line mode.

I'll check it. Sorry for the late.

My random thoughts are here. I want to discuss these points.
The configuration option shouldn't be experimental
I think if we ship this feature, we don't plan to remove this. So it isn't experimental.
But I can't think reasonable option for this. Please let me your ideas.
It should be worked in insert-mode and normal cmdline-mode.
I don't think it's useful that it's worked in insert-mode. But it's consistent.
UI should be the same as native wildmenu.
But it's depending on to the personal preferences...
cmp.setup {
  ...
}

cmp.setup.cmdline('/', {
  ...
  some_reasonabole_option = true
  ...
})

BTW, It's useful :)

BTW, It this behavior intented? It isn't the same as native wildmenu but not bad. It's interesting.
https://user-images.githubusercontent.com/629908/151798718-64c9b904-1201-4b16-aa30-a37dbbc3fc2b.mp4

which behaviour do you refer to?

My random thoughts are here. I want to discuss these points.
The configuration option shouldn't be experimental
I think if we ship this feature, we don't plan to remove this. So it isn't experimental. But I can't think reasonable option for this. Please let me your ideas.
It should be worked in insert-mode and normal cmdline-mode.
I don't think it's useful that it's worked in insert-mode. But it's consistent.

If its not useful then why support it?

UI should be the same as native wildmenu.
But it's depending on to the personal preferences...

Can you be more specific?

cmp.setup {
  ...
}

cmp.setup.cmdline('/', {
  ...
  some_reasonabole_option = true
  ...
})

UI should be the same as native wildmenu.
But it's depending on to the personal preferences...

Can you be more specific?

The following screencast uses native wildmenu.
The native wildmenu is

Does not contains | chars.
The items are separated by two spaces.
The default highlight is StatusLine (maybe... I can't find actual one from vim help)
The active item highlight is WildMenu.

https://user-images.githubusercontent.com/629908/151822440-03ace504-9d2c-4c3a-92fd-22cee5ad88af.mp4

Hm... But I think we shouldn't use wildmenu highlights. We should use pum highlights.

I will merge it once and organize it. Is that okay?

I think its ready to be commited now.
Config is like you suggested:
  view = {
    entries = 'custom'
  }

and in cmdline:
cmp.setup.cmdline('/', {
  view = {
    entries = 'wildmenu',
    separator = '|',
  },
}

I think the separator is needed only for entries and the value of wildmenu. So it's should be contained to the { name = 'wildmenu', separator = '|' }
cmp.setup {
  view = {
    entries = { name = 'wildmenu', separator = '|' } -- the user can also specify the `wildmenu` literal string.
  }
}

I think the separator is needed only for entries and the value of wildmenu. So it's should be contained to the { name = 'wildmenu', separator = '|' }
cmp.setup {
  view = {
    entries = { name = 'wildmenu', separator = '|' } -- the user can also specify the `wildmenu` literal string.
  }
}

done

LGTM.

@hrsh7th
On last thing I forgot: what about adding some documentation, pointing users to the new feature?

Does this change address the issue of the "normal" vertical menu crossing over the status line?

probably. It overlays the status line with the entries.

Hm. Sounds like a different issue then. I want the ("normal") vertical completion menu, but to have it render above the status line.


Restyle invalid organization page.

This restyles the invalid_realm.html template that displays when
a subdomain does not lead to a valid organization.
Fixes: #6667.

Merged, thanks @brockwhittaker!


How to Test this on a Single Custom Image?

It may be too late, but I've been trying out the model recently. Here's the 590 epoch checkpoint model on my dataset:

Modify the dataset.py file to load your image. I don't think the h-sample in the test_tasks.json works for testing. However, you do need to have the right raw_file directory.


Update source_code script buffer with change

Fixes this bug:
https://github.com/godotengine/godot/issues/65450
The script editor when using tools, would not fetch the source_code. That's because it did not get updated in real time.

I just realized the bug is with 3.5 and 4.0 beta.  fixed it in 4.0 beta master. It needs to be back ported to 3.5. What does the back port process to 3.5 entail?

I am building a tool to read/manipulate the source code of any script file in the godot project.  T
I cannot make this tool if I cannot read the source code correctly. The original bug report #65450 contains a small project to demo the problem. But here is the essence of the code that does not work below:
func _show_script():
	var ef=EditorPlugin.new().get_editor_interface()
	var se:ScriptEditor=ef.get_script_editor()
	var sc=se.get_current_script()
	print("Source code: ",sc.source_code)	 #<-- does not retrieve the latest source code typed into editor window.


Notification close button icon is broken

Overview of the problem
Oruga version: [0.8.7]
Vuejs version: [3.4.21]
OS/Browser: Windows 11, Firefox
Description
close button not showing properly
<ONotification v-if="contactSuccess" :message="contactSuccess" iconSize="medium" variant="success" closable
			aria-close-label="Close notification" />

Steps to reproduce

add closable to
the close icon will look weird

Expected behavior

Actual behavior

Hello @zhaolinlau , are you using the latest theme-bulma version?
https://github.com/oruga-ui/theme-bulma/issues/80#issuecomment-1969640932


mdsvx fails autoimport

I tried to use mdsvx and unplugin-svelte-comonent, but because of the order of the process, the autoimport didn't work for markdown files.

When I made unplugin-svelte-component, I didn't think about using mdsvx. So it's okay if it doesn't work right now. I know it would be helpful, but I can't add it right now. Maybe I can add it later, but not soon. If you want to help, you can send me a PR :)


[Feature Request] A raw data image viewer such like 7yuv.exe

There is an application called 7yuv on Windows. That application can load any pure bytes images with different pixel format and size. It is very useful for an engineer working on Video Decoding or Picture Decoding.

Hi,
DevToysMac is now archived and deprecated. We just released DevToys 2.0 for Windows, Mac and Linux. This issue may or may have not been addressed in the new version. If the issue persist, we encourage to open a new issue on https://github.com/DevToys-app/DevToys or https://github.com/DevToys-app/DevToys.Tools
See more information about DevToys 2.0 here: https://devtoys.app/blog/announcing-devtoys-2.0-preview


check array index exist.

cc @yingliu-google

https://github.com/google/ReCAPTCHA/pull/16 https://github.com/google/ReCAPTCHA/pull/13

I believe this should be resolved in v1.1, however if you spot something then please resubmit. There's a new contribution process and I'm watching PRs.


Improved behavior of expect_near_rel

Summary
Improved the behavior of expect_near_rel as proposed in #1656.
Wherever a tolerance of type double was used, there is a new struct relative_tolerance that gathers relative (tol) and minimal tolerance (tol_min). The final tolerance is computed as std::max(tol * fabs(x), tol_min) where x is either an exact value to be tested against (I will use this in the precomputed tests) or average of the two values to be compared (this is what expect_near_rel uses).
To make the transition easy relative_tolerance has an implicit constructor from double (which is treated as relative tolerance), I instructed the linter to be quiet about it.
Default tol_rel is 1e-8 and default tol_min is std::max(tol_ * tol_, 1e-14). The tol_min default is slightly weird but it is a compromise between a desire to be strict by default while acknowledging that 1e-16 tolerance is almost impossible to achieve in many cases.
Tests
There is a test for relative_tolerance - since the tolerance code is decoupled from expect_near_rel it can be tested more directly than in the previous version.

Side Effects
Most tests got stricter or stayed the same for all/most values, but some test/value combinations got a bit more relaxed. Specifically:

Any test that had  tol > 1e-7 and the tolerance was not explicitly touched in this PR is stricter for fabs(value) < tol and the same for fabs(value) > tol.
Any test that had  1e-14 < tol < 1e-7 and the tolerance was not explicitly touched in this PR is stricter for fabs(value) < tol, slightly relaxed for tol < fabs(value) < 1e-14/tol and the same for fabs(value) > 1e-14/tol.
In tests I touched I always aimed to got stricter somewhere, i.e. if I had to increase tol_min above it's default, I would decrease tol or vice versa. Mostly tests that modified their tolerance actually needed to modify tol_min and not tol.
The default relative tolerance for hessian_hessian_ and hessian_fvar_hessian_ used to be 1e-3. I noticed that this was necessary primarily because of bad behaviour around zero. The new default is tol = 1e-4, tol_min = 1e-3, so those tests got stricter above 1e-1 and weaker between 1e-3 and 1e-1.

Most places where I had to tweak the tolerance already had tolerance tweaked before. The exceptions are

test/unit/math/mix/fun/matrix_exp_test.cpp
test/unit/math/mix/fun/quad_form_diag_test.cpp

where I had to slightly increase tolerances for at least one test_ad call that used default tolerance before. This was due to the change in default tolerance described above.
I also removed functions relative_diff and expect_near_relative from test/unit/math/rev/fun/util.hpp and replaced their use (only in 1 file) by expect_near_rel.
Checklist

[x] Math issue #1656

[x] Copyright holder: Institute of Microbiology of the Czech Academy of Sciences

By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

So I checked the coding guidelines and I realized relative_tolerance should have really been a class, so I changed it to one. Also added some accessor/modifier functions while I was at it. I briefly documented the changes at https://github.com/stan-dev/stan/wiki/Testing-framework but I mostly link to code as this will be less stale.

@bob-carpenter tests are passing, should be ready for re-review


README Specs

Coverage remained the same at 96.765% when pulling f9d0df5ae444881e051553f034d6a5fdba8b0d59 on georgeu2000:README into 5998269b057f7ec8c7f201b1d2969cae4c9fe2c4 on igrigorik:master.

Coverage remained the same at 96.765% when pulling f9d0df5ae444881e051553f034d6a5fdba8b0d59 on georgeu2000:README into 5998269b057f7ec8c7f201b1d2969cae4c9fe2c4 on igrigorik:master.


Tweet favorite failed. Error was

Tweet favorite failed. Error was:
{"name":"Exception"}
options were:
{"method":"POST","payload":"id=1269419297157365761","headers":{"Authorization":"OAuth oauth_consumer_key="XXXXXX", oauth_nonce="XXXXXXX", oauth_signature="XXXXXX%XXXXX%3D", oauth_signature_method="XXXX-XXXXX", oauth_timestamp="XXXXX", oauth_token="XXXXX-XXXXX", oauth_version="1.0""},"escaping":false}
I get this error when trying to retweet or like anything

Fix here https://github.com/neojato/T-Hawk/pull/13/files

Fix here https://github.com/neojato/T-Hawk/pull/13/files

See #12 for the latest on issues with the Twitter library used.


[SPARK-45742][CORE][FOLLOWUP] Remove unnecessary null check from ArrayImplicits.SparkArrayOps#toImmutableArraySeq

What changes were proposed in this pull request?
The implementation of the mmutable.ArraySeq.unsafeWrapArray function is as follows:
  def unsafeWrapArray[T](x: Array[T]): ArraySeq[T] = ((x: @unchecked) match {
    case null              => null
    case x: Array[AnyRef]  => new ofRef[AnyRef](x)
    case x: Array[Int]     => new ofInt(x)
    case x: Array[Double]  => new ofDouble(x)
    case x: Array[Long]    => new ofLong(x)
    case x: Array[Float]   => new ofFloat(x)
    case x: Array[Char]    => new ofChar(x)
    case x: Array[Byte]    => new ofByte(x)
    case x: Array[Short]   => new ofShort(x)
    case x: Array[Boolean] => new ofBoolean(x)
    case x: Array[Unit]    => new ofUnit(x)
  }).asInstanceOf[ArraySeq[T]]

The first case of match is null, there is no need to do another manual null check, so this PR removes it.
Why are the changes needed?
Remove unnecessary null check from ArrayImplicits.SparkArrayOps#toImmutableArraySeq
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test cases, such as ArrayImplicitsSuite.
Was this patch authored or co-authored using generative AI tooling?
No

Merged into master for Spark 4.0. Thanks @dongjoon-hyun


server failier passes

The server code is optimistic and it doesn't handle all possible failure cases such as when
1- a subset of queries to Google Maps API fail
2- the key is missing

this is resolved by #22


Use generic host for GarnetServer

Feature request type
enhancement
Is your feature request related to a problem? Please describe
Using the generic host https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host will simplify how we bootstrap the server
Describe the solution you'd like
wire up using DI the dependencies that are created manually.
Describe alternatives you've considered
No response
Additional context
see the manual configuration https://github.com/microsoft/garnet/blob/main/libs/host/GarnetServer.cs#L151C13-L210C57

Mostly addressed by https://github.com/microsoft/garnet/pull/614 - feel free to create PR if you have more ideas in this space.


Update minimatch to version 3.0.5 to fix vulnerability

Updated package minimatch from 3.0.4 to version 3.0.5.
Related issue: https://github.com/microsoft/azure-pipelines-task-lib/issues/832

/azp run

@mmrazik Could you please review this PR

@kirill-ivlev please bump package version for further release as well

This should help to fix https://github.com/microsoft/google-play-vsts-extension/issues/342 also (minimatch vulnerability).

/azp run

/azp run

@mmrazik could you please take a look at this PR?


Strip the CPU from the flutter basename when determining host basename

This makes it a little easier to run flutter with a local engine.

@liamappelbe do you want to continue with this PR? Could you expand on the description a bit, if so? How does it improve the workflow?

Currently if you build a local engine with a specific --android-cpu, eg android_debug_unopt_x86, the hostBasename will be deduced as host_debug_unopt_x86. But the host engine doesn't specify the CPU, so the tool will error saying the host directory doesn't exist.
The usual fix is for the developer to manually symlink host_debug_unopt_x86 -> host_debug_unopt, which seems like an unnecessary hassle to me. This change just means you don't have to make the symlink.

Also see: https://github.com/flutter/flutter/pull/27765

https://github.com/flutter/flutter/pull/27765 is submitted, so this PR is unnecessary.


Modal from sample v1.0.0-alpha.3 not working

I created a sample .html page w/ the following code from the documentation (http://next.materializecss.com/modals.html). However, when the Modal button is clicked the modal window is not displayed. Both the .css and .js files are being loaded.
The Modal page in the documentation does work.
<!DOCTYPE html>

  <link type="text/css" rel="stylesheet" href="./dist/materialize/css/materialize.css" media="screen,projection" />

  Modal


Support attribute routes on Razor Pages and Page Models

Based on feedback, we want to support customizing Razor Pages routes using attribute routing. This will require we discover and compile all pages ahead of building the route table
On Pages
Would rely on #6562 to allow attributes to be specified in the Razor Page file. E.g.:
@page
@attribute Route("custom")

@* GET /custom *@
Hello, World!

On Page Models
The attributes could be placed on the PageModel class directly, and/or on the handler methods, with very similar behavior to attribute routing on controllers and actions (cascading, overriding, composition, etc.). The routes would be additive to the implied routes (we can debate that). E.g.:
[Route("custom")]
public class MyPageModel : PageModel
{
    // GET /custom/handler/foo
    [HttpGet("handler/{param}")]
    public IActionResult CustomHandlerMethod(string param)
    {
        ...
    }
}

The function-like syntax is weird little bit. It would be nice & simpler if we can use:
@page
@route "custom"

@* GET /custom *@
Hello, World!

So we plans to support using "~/Foo" and /Foo as overrides. So any page can have full control over its route.

I fully support adding routing to the PageModel and to the form itself, because I have routes that I would like to use which inject a dependency into the route path.
For example.  A route of:    [Route("path/to/{userId}/page_name/{itemId}")]    -> this passes in userId and itemId as parameters to the method.
Currently there is no way that I've found to inject userId into a Razor Page.  This is important because we have dependent "pages" that need userId (for example) to be further up the path.
This forces me to have to go down to utilizing Controllers/Views as opposed to Razor Pages (which would work in 90+% of the time).

Currently there is no way that I've found to inject userId into a Razor Page. This is important because we have dependent "pages" that need userId (for example) to be further up the path.

@ahazelwood, you can use AddPageRoute on RazorPagesOptions.Conventions to do this. For e.g. https://github.com/aspnet/Mvc/blob/47287c508ee43c4f30b8000400fda1b01f68bfe2/test/WebSites/RazorPagesWebSite/Startup.cs#L23

The problem is that I would like to be able to do this within the Razor Page itself as this is cleaner in my opinion having the route information tied to where the work is being done.  This way as we add/remove functionality in the future, this is handled automatically.

@DamianEdwards Thanks for adding this in 2.1.0.  This helps out tremendously.
For anyone that finds this in the future, you can now define routes on the @page directive.  For example:  @page "/some/unrelated/{routeid}/child"  and references to /some/unrelated/blah/child will work correctly.


Remove wrong connect_xxx_notify

Part of https://github.com/gtk-rs/gir/issues/510
Also strange situation: set call notify https://github.com/GNOME/gdk-pixbuf/blob/master/gdk-pixbuf/gdk-pixbuf.c#L1307, but called only in constructor.
cc @GuillaumeGomez. @sdroege

👍

@sdroege Please look at this PR

:+1:


Please update ModularFlightIntegrator to version 1.1.5

1.1.5 fixed a critical bug that prevented me from using it in Kopernicus. Users who got Kopernicus through CKAN will get version 1.1.3, and therefor, they get the bug.

Fixed in KSP-CKAN/CKAN-meta#1187

UnfortunatelyThe latest version of MFI is not marked as compatible with KSP 1.1.3, so adding it as a dependency will make Kopernicus disappear for KSP 1.1.3 installs, due to KSP-CKAN/CKAN#1695.


 Skype4J has no native code that would use JNI.
Either way, samczsun isn't really working on Skype4J at the moment (there are 31 open issues).

But everything else loads

even if it is a skype4j issue not getting fixed anytime soon ;l


More fallbacks for Open Graph and Twitter images

I have added more fallback options for the current page images for Open Graph and Twitter as requested at #24

I added ->first()  to $page->cover()->first()->toFile() to select the first image if "cover" has mulitple images.


Jetpack Compose example

I saw that Compose-jb now was an experimental example for LWJGL/GLFW using ComposeScene.
Is possible, with this new API from Compose, be able to use with JWM? If so, would be awesome to see a code sample.

Should be possible, yes. Do you want to make a PR with an example?

I don't know JWM enough to do that, I think. I could try.

Great places to start is https://github.com/HumbleUI/JWM/blob/main/docs/Getting Started.md and https://github.com/HumbleUI/JWM/blob/main/examples/dashboard/java/Example.java. Let me know if you have any questions. I’d do it myself but I am not sure how long it might be delayed because of conflicting priorities

cc @smallshen

Had a look at that example l, am pretty sure you could integrate it easily.
You need access to three things for this to work:

OpenGL Surface
Window handle

Here is what it should look like:
fun main() {
    var width = 640
    var height = 480

    // Initialize JWM OpenGL
    // Then:
    var surface = // get JWM GL Surface
    val windowHandle = //get JWM GL Window Handle

    val glfwDispatcher = GlfwCoroutineDispatcher() // a custom coroutine dispatcher, in which Compose will run
    glfwSetWindowCloseCallback(windowHandle) { glfwDispatcher.stop() }

    lateinit var composeScene: ComposeScene

    fun render() {
       // You might need to change this call, not sure what the proper code is to get the canvas from the surface
        surface.canvas.clear(Color.WHITE)
        composeScene.constraints = Constraints(maxWidth = width, maxHeight = height)
        composeScene.render(surface.canvas, System.nanoTime())

        context.flush()
        glfwSwapBuffers(windowHandle)
    }

    val frameDispatcher = FrameDispatcher(glfwDispatcher) { render() }

    val density = Density(glfwGetWindowContentScale(windowHandle))
    composeScene = ComposeScene(glfwDispatcher, density, invalidate = frameDispatcher::scheduleFrame)

    glfwSetWindowSizeCallback(windowHandle) { _, windowWidth, windowHeight ->
        width = windowWidth
        height = windowHeight
        surface.close()
        surface = createSurface(width, height, context)

        glfwSwapInterval(0)
        render()
        glfwSwapInterval(1)
    }

    composeScene.subscribeToGLFWEvents(windowHandle)
    composeScene.setContent { App() }
    glfwShowWindow(windowHandle)

    glfwDispatcher.runLoop()

    composeScene.close()
    glfwDestroyWindow(windowHandle)

    exitProcess(0)
}


Add basic support for browse categories

Note: Included the commit that fixes the build from the other PR.

This looks pretty great, thanks! Everything looks good at a glance, just give me another day or so to merge give a more thorough once over these and we'll be good to go.


Add Cupertino Countdown Timer Picker

@doxuanviet1996  See https://github.com/flutter/flutter/pull/20653 for pending work to match iOS accessibility behavior. Not done yet, but worth checking out to make sure this implementation behaves.


Suppress hidden arguments from completion scripts

Resolves #264.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

@swift-ci Please test

@swift-ci Please test


[CT-941] NO ISSUE

This ticket is a placeholder for the rare changelog entries that do not have an associated ticket. if you're unsure if you should make a ticket or not, make one!

Killing that one too! @McKnight-42 I should be opening these for each PR as you need them from now on ;)


#263: extract method and make cacheable

#263 Extract map method creator and make it cacheable.

@lautarobock Thanks, I will ask someone to do a code review here, thanks for your pull request

@carlosmiranda please review, thanks

@davvd @carlosmiranda any news here?

@lautarobock Apologies for the delay. Please see my comments above.

@carlosmiranda done, please check the update

@rultor good to merge

@rultor good to merge

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@lautarobock no tests? how do you know it works?

@yegor256 the test was there and I've made only a inner refactor. But I've added a test for checking cache.

@carlosmiranda @yegor256 Anybody saw the last commit?

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 14min)

@elenavolokhova please, review this task for compliance with our quality rules

@rultor please deploy

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 7min)

@carlosmiranda
According to our quality rules:

Comments were mostly about design problems, not cosmetic issues.

There were mostly cosmetic issues found during review. Try to pay attention to bigger design problems and the overall quality of the code.
Please confirm that this new rule is clear.

@elenavolokhova All is clear, thanks.

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks a lot, next time everybody should try to make it better

@carlosmiranda just added 10 mins to @elenavolokhova (for QA), payment ID is 59513908... Much appreciated! 18 mins was added to your account, payment ID 59513917, time spent is 166 hours and 44 mins... you're getting extra minutes here (c=3)... added +18 to your rating, now it is equal to +4134


Default case of keys

Expected Behaviour
I think most .NET developers expect CamelCase to be the default case for the JSON output.
SnakeCase is not frequently used in .NET.
{
    "coldStart": true,
    "xrayTraceId": "1-642af4b6-0555809140745f2e5909d47b",
    "functionName": "ThreeSimpleWaysToLog",
    "functionVersion": "$LATEST",
    "functionMemorySize": 256,
    "functionArn": "arn:aws:lambda:us-east-1:694977046108:function:ThreeSimpleWaysToLog",
    "functionRequestId": "296334a4-ab82-4a0c-8c30-1eb394029921",
    "timestamp": "2023-04-03T15:45:58.9092348Z",
    "level": "Information",
    "service": "service_undefined",
    "name": "AWS.Lambda.Powertools.Logging.Logger",
    "message": "Hello logging"
}

Current Behaviour
{
    "cold_start": true,
    "xray_trace_id": "1-642af483-1193cc91237b822377040707",
    "function_name": "ThreeSimpleWaysToLog",
    "function_version": "$LATEST",
    "function_memory_size": 256,
    "function_arn": "arn:aws:lambda:us-east-1:694977046108:function:ThreeSimpleWaysToLog",
    "function_request_id": "ed4f8815-bd75-4a0b-a24a-4112cc040a52",
    "timestamp": "2023-04-03T15:45:08.2042471Z",
    "level": "Information",
    "service": "service_undefined",
    "name": "AWS.Lambda.Powertools.Logging.Logger",
    "message": "Hello logging"
}

Code snippet
[Logging(LogEvent = true)]
public void FunctionHandler(string input, ILambdaContext context)
{
...
}

### Possible Solution

_No response_

### Steps to Reproduce

Create a .NET Lambda function with

[Logging(LogEvent = true)]
public void FunctionHandler(string input, ILambdaContext context)
{
...

Deploy and invoke.

### AWS Lambda Powertools for .NET version

latest

### AWS Lambda function runtime

dotnet6

### Debugging logs

_No response_

hey @bjhogan thank you for taking the time to create an issue. This is intentional hence not being a bug :) You can change that by setting the Output case to Pascal: https://awslabs.github.io/aws-lambda-powertools-dotnet/core/logging/#configure-log-output-casing
/**
 * Handler for requests to Lambda function.
 */
public class Function
{
    [Logging(LoggerOutputCase = LoggerOutputCase.CamelCase)]
    public async Task<APIGatewayProxyResponse> FunctionHandler
        (APIGatewayProxyRequest apigProxyEvent, ILambdaContext context)
    {
        ...
    }
}

But wait, why is that not the default?
We've learned from the majority of our customers (80%) that they use multiple languages across their business. This means, using Powertools for .NET, Java, TypeScript, or Python will not impact their logging analytics across applications (e.g., search for cold_start will always work). In other cases (20%), we've learned from customers that they already have a predefined standard for logging keys that they'd like to keep - this is currently a gap in our .NET implementation.
Hope that helps!
Thank you!

Thanks @heitorlessa


Correct yes? or no?

Current situation:
prompt.yes?('Are you alien?')
# Are you alien? (Y/n)
=> nil

prompt.no?('Are you alien?')
#Are you alien? (Y/n)
=> true

Now:
prompt.yes?('Are you alien?')
# Are you alien? (Y/n)
=> true

prompt.no?('Are you alien?')
# Are you alien? (y/N)
=> true

Thanks for fixing, will merge shortly.

Thanks again for the fix!


Seamless Token Refresh and Redirection

Note
This issue can also be checked when user logins the launchpad from one instance and try to open the app in which the user is logged in with some different instance.
Description
The current user experience when a token expires and the user attempts to open an application from the launchpad results in a disruptive "Login failed" screen. To improve this experience, an enhancement can be implemented to seamlessly refresh the expired token without interrupting the user's flow.
Additional information
https://jam.dev/c/5d5a52d7-45e5-4d21-b72e-b6e2781d6412

@ravilodhi is there a known solution for this? Or will this require discussion? if so lets try to get it discussed this week.


Update go-jose. Fixes #607

@andrewpmartinez is working on getting the library updated in zitiadel.


Add Tharindu and other new volunteer names to the About Us section of the Elixir website

@anjula-sack to provide names of volunteers not added.

I would like to work on this.

I would like to work on this.

Awesome! Please go ahead.


Adding bindings. Arguments added to initialize & with-init.

Adding bindings
set-window-attribute
set-monitor-user-pointer
get-monitor-user-pointer
set-window-icon
get-window-frame-size
maximize-window
focus-window
request-window-attention
set-window-maximize-callback
set-window-content-scale-callback
wait-events-timeout
raw-mouse-motion-supported-p
get-key-name
get-key-scancode
create-cursor
create-standard-cursor
destroy-cursor
set-cursor
set-char-mods-callback
set-drop-callback
get-joystick-hats
get-joystick-guid
set-joystick-user-pointer
get-joystick-user-pointer
joystick-is-gamepad-p
set-joystick-callback
update-gamepad-mappings
get-gamepad-name
get-gamepad-state
get-timer-value
get-timer-frequency
*-userpointer are not exported from %glfw.
Initialize gets arguments
(initialize)->(initialize &key atts...)
(with-init &body body)->(with-init (&rest keys...) &body body)
In this PR, with-init-window's argument doesn't change because of complexity of adding init-hint, such as whether (w-i-w init-hints window-hints body) or (w-i-w window-hints init-hints body) is better when adding init-hints, etc.
Additional example
icons-test is added cl-glfw3-examples. it uses images.
Renaming work-area->workarea
get-monitor-work-area is renamed get-monitor-work-area. I matched with binding-name rules. Now get-monitor-work-area calls get-monitor-workarea and warns not recommended.

I tested create-cursor on windows sbcl and there is no problem, but when tested on ubuntu sbcl the colors may not display properly. For example, colocr-checkcursor shows all colors correctly, but yellow and blue created in the same way show different colors than intended.
set-window-icon handles image-structure as well, but it worked fine on both windows and ubuntu.


TASK: Read Input

Define software and hardware to detect 8 shades of grey on paper.

Not quite 8, but we are doing 5 quite well. This task has been completed (in spirit)


g_vkTransferQueue error when context menu spawns a new platform window

May be same as #773 but filing a separate ticket until we're sure

Appears to only happen when a scope is triggering at the same time?


doc referencing pub(crate) const

The documentation is referencing a pub(crate) const, and thus the link is broken on docs.rs.
see: link, in which links to Self::ZERO and Self::LAST are dead.

fixed by: bb6fbb3


New package: IUCNRedList v0.7.2

Registering package: IUCNRedList
Repository: https://github.com/jdiaz97/IUCNRedList.jl
Created by: @jdiaz97
Version: v0.7.2
Commit: 4f4fcdd30f4c2c71b0daacb65de95936cf572f0f
Reviewed by: @jdiaz97
Reference: https://github.com/jdiaz97/IUCNRedList.jl/issues/2
Description: API Wrapper for the IUCN Red List.

Superseded by #73157 (had you kept the same version number, this pull request would have been updated instead of creating a new one, as explained in the message above)


@Provided -> @Provider typo fix

Description
IIUIC the note refers to https://jakarta.ee/specifications/platform/9/apidocs/jakarta/ws/rs/ext/provider as described in paragraph https://jakarta.ee/specifications/restful-ws/3.0/jakarta-restful-ws-spec-3.0#automatic_discovery

@happylynx Do you intend on signing the contributor agreement ?


Server not reloading on non-js file save

I have my script setup as
"dev": "cross-env NODE_ENV=development nodemon app"
When I save .js files, it works fine, but when I save anything else, it doesn't and I have to restart the server to see the updates.

Ok so doing some research I figured out a solution:
I replaced this:
"dev": "cross-env NODE_ENV=development nodemon app"
with this:
"dev": "cross-env NODE_ENV=development nodemon -e 'hbs,env,css,js'"
Also, before I did this, morgan wasnt working either, but after the change it's working as well.
Before or on closing, can someone explain to me what I may be missing?  I don't see where my code is different.


fix(material/core): Use aria-checked for checkbox option

The aria-selected attribute is applied to checkboxes within mat-select multiple selection, which creates a visual and semantic discrepancy, as well as causing problems for screen readers that does not announce aria-selected status. This has resulted in a number of accessibility bugs being reported in the past.
Mat-select is implemented as a listbox. According to ARIA: listbox role,

It is highly recommended using the HTML select element, or a group of radio buttons if only one item can be selected, or a group of checkboxes if multiple items can be selected

Therefore, it makes more sense to use role='option' for single selection mode and role='checkbox' for multiple selection mode. For checkboxes, we can use aria-checked to mark selection status, and for options, we can use aria-selected.
This is a demo recorded on Chrome + VO with the change of aria-checked,
Mat-select demo.webm

Some clarifications:

The aria-selected attribute is applied to checkboxes within mat-select

I don't think this is quite accurate- the component applies aria-selected correctly to role="option". It uses a visual indicator of selection that looks similar to a checkbox. If this visual indicator is the source of the bugs you're seeing, I would be more inclined to change the indicator than the actual interaction pattern / state model.

Mat-select is implemented as a listbox

Also not fully accurate- MatSelect is implemented as a combobox. From ARIA 1.2:

Authors MUST ensure the popup element associated with a combobox has a role of listbox, tree, grid, or dialog.

So for select, IMO only listbox and dialog make sense here, and I strongly suspect combobox + listbox is the most frequently encountered and best supported option.

Thanks! Update the description to be more accurate.

This PR is based on an offline discussion, and there was a previous attempt to fix the issue.

@clamli we would also need to test

Safari + VoiceOver
Firefox + NVDA
Firefox + JAWS
TalkBack

I tested with VO + Safari, but I was unable to move the focus to the option inside mat-select to make it announced, record is attached below. This appears to be a known issue: https://github.com/angular/components/issues/24390, and the workaround is to navigate to the options, however, I was not sure how I could navigate to option.
AM-select issue.webm
It works well if I test the same combination on a native select.
Native-select demo.webm

Hello @clamli ,
Thank you for taking initiative on this. @jelbourn and I talked about this today. We believe that using aria-checked may be the right thing to do. Jeremy is going to reach out and get more information about this. We'll leave this PR open in the meantime.
-Zach

Hi Zach,
Thanks for following up!
I'm putting this on hold for now, as both of the options I proposed have problem. I'm happy to share my findings so far and would love to hear your thoughts!
Option 1
@Component({
  selector: 'mat-option',
  host: {
    '[attr.role]': 'option',
    '[attr.aria-selected]': '_getAriaSelected()',
    '[attr.aria-checked]': '_getAriaChecked()'
  },
})

_getAriaSelected(): boolean | null {
    return this.multiple ? null : this.selected;
  }

_getAriaChecked(): boolean | null {
   return this.multiple ? this.selected : null;
}

This attempt uses aria-checked property for multiple selection mat-option, but VoiceOver seems to have difficulty recognizing aria-checked status inside an option, instead, it keeps looking for aria-selected, since that is not provided, it reads out "not selected" for all options regardless of their selection status.
Option 2
@Component({
  selector: 'mat-option',
  host: {
    '[attr.role]': '_getRole()',
    '[attr.aria-selected]': '_getAriaSelected()',
    '[attr.aria-checked]': '_getAriaChecked()'
  },
})

_getRole(): string {
    return this.multiple ? 'checkbox' : 'option';
  }

_getAriaSelected(): boolean | null {
    return this.multiple ? null : this.selected;
  }

_getAriaChecked(): boolean | null {
   return this.multiple ? this.selected : null;
}

This attempt uses role='checkbox' with aria-checked property, and role='option' with aria-selected. The screen reader results look good as posted in the description.
However, according to WAI-ARIA listbox, "option" is a required owned element of any element with role="listbox". Since mat-select is a combobox implemented as a listbox, we have to set role="option" for the option inside.

Closing since this is way out of date and it looks like the discussion didn't end up anywhere.


docs(subscription): fix broken links to pubsub methods

Fixes #685

[x] Tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

@anguillanneuf well this is embarrassing

LGTM!


title attributes for market category links

This allows users to read market categories that are truncated without having to click them.

Coverage remained the same at 66.592% when pulling a964f195301e9958c65d49452bb0311a4a7fcc23 on kevinreilly:market-category-link-title-attribute into 4b7749b4c54a3c0f3d9519164b6c1df7a9a4677e on AugurProject:master.


[de] - add sentence to cover: "Fahre xyz hoch" / "Fahre xyz herunter"

the cover_HassTurnOff.yaml should include the sentence:
Fahre <device> (im <area>) herunter
variation:
Fahre <device> (im <area>) runter
the cover_HassTurnOn.yaml should include the sentence:
Fahre <device> (im <area>) hoch
variation:
Fahre <device> (im <area>) rauf

coming in next release (see linked PR)


update slider styling

closes #40

Tested on Edge and Firefox: works with sliderthumb border.

Testest on Chrome: sliderhtumb border does not work (also not an existing property according to MDN)

Disabled style and check mark as select icon

Tested in Firefox:

[ ] Transparency issue with checkboxes
[ ] Disabled state does change the thumbcolor

Fixed issues in Firefox.

Checkboxes and sliders have been succesfully reviewed.
As you can see in the screenshot @MariaBee3 submitted, the borders/shadows of the inputs besides the sliders are blue instead of gray. I have changed it.
Disabled version

Open version:


[Feature] Make decision on infastructure

Describe the solution you'd like
Currently there are 3 possible infrastructure choices.

firebase - https://firebase.google.com/docs

most familar with, feature rich, google-backed

vercel + ably - https://ably.com/blog/next-js-vercel-link-sharing-serverless-websockets

clearest pricing model
clear api
no database?

vercel + convex - https://docs.convex.dev/getting-started/

no clear pricing, limitations, clear api

digital ocean (full-stack app)

complete control most work

Will close this issue once a decision is made.

Going with vercel+ably for now.
See:
https://ably.com/blog/next-js-vercel-link-sharing-serverless-websockets


[WIP] Change static blob schema format to JSON

I'm not 100% sure about the JSON format here. This is the most concise way I could think of to represent a directory structure with only the folder/file names. However, it does mean that file names are object keys with a null value. Is there a different format preferred?
{
    "samples": {
        "file1.txt": null,
        "file2.txt": null,
        "file3.txt": null,
        "folder": { "childFile.txt": null },
        "folder2": {
            "child": { "descedant4.txt": null }
        }
    },
    "random": {
        "file.txt": null,
        "folder": { "emptyFolder": {} }
    }
}

Once we're happy with the format I'll add documentation to this PR.

How about
{
    "samples": {
        "files": [
            "file1.txt",
            "file2.txt",
            "file3.txt"
        ],
        "folder": {
            "files": [ "childFile.txt" ]
        },
        "folder2": {
            "child": {
                "files": [ "descedant4.txt" ]
            }
        }
    },
    "random": {
        "files": [ "file.txt" ],
        "folder": {
            "emptyFolder": {}
        }
    }
}```

Don't know if that's any better, mind you.

Yet another alternative is that we optionally capture the blob type: -
{
    "samples": {
        "file1.txt": null,
        "file2.txt": { "type" : "blockblob" },
        "file3.txt": { "type" : "blockblob" },
        "folder": { "childFile.txt": { "type" : "pageblob" } },
        "folder2": {
            "child": { "descedant4.txt": { "type" : "blockblob" } }
        }
    },
    "random": {
        "file.txt": null,
        "folder": { "emptyFolder": {} }
    }
}

If you leave it as null we just take default of blockblob.

@isaacabraham
The first alternative doesn't allow a folder called files so I guess it's not viable... Maybe an empty string instead of "files"?
The second one could work. I suppose it's an extension to what I've already got and it makes sense if we need to capture the blob type. Is there any chance that in the future we could need to capture extra information about the folders? If so, we should have a design that allows us to add this in a nice way without making a breaking change.

In the proposed model, how do you distinguish between an empty folder and a file?

Can you also confirm if with this model you can create "empty" containers (the current schema doesn't support this).

I think we've settled on this structure: -
{
	"samples": {
		"file1.txt": null,
		"file2.txt": null,
		"file3.txt": null,
		"folder/": {
			"childFile.txt": null },
		"folder2/": {
			"child/": {
				"descedant4.txt": null }
		}
	},
	"random": {
		"file.txt": null,
		"folder/": {
			"emptyFolder/": null }
	}
}

All folders must end with '/'. The "value" of a file or folder can be null or { }, and for files can also contain the type of blob (this is an added feature so by default the existing code won't support that).

That format looks good. I've made the changes to use that now.


Migrated IniFileConfigStore to @configu/integrations

Closes #516

@SanchitMahajan236 please let us know if you're still working on this PR, if not let us know and we will make the issue available to other contributors 🙏🏻

Hi @RichardAkman , I have done the changes to the code as mentioned by you and working on the readme file.

Hi @RichardAkman , I have merged the updates requested.

Hi @SanchitMahajan236 ,
Here are the details for claiming your Hacktoberfest prizes! 🎉 Check out #465  (comment) for more information or simply fill out the form here: Claim Your Swag.
Remember, you only need to fill out the form once for all your PRs. 😊


Using Steam Audio spatialization on a UWP device (Hololens)

I am in the process of creating an app targeting the Hololens 2, and need the ability to spatialize and simulate realistic sounds from a given source. I need the benefits that come from occlusion, ray tracing, material transitivity, and more. However, it looks like steam audio does not officially support UWP platforms.
Still I would like to see how much of it actually works on the device, and how much of it breaks. To get this, I want to basically force steam audio to run its spatialization algorithms.
Currently, when an audio is spatialized with steam audio, there is not sound. When using the Steam Audio Manager, there is an error stating the platform is not supported. Is there any way to bypass these restrictions?

@DivinorWieldor While Steam Audio does not currently ship with UWP binaries as part of our release process, the full source code is available, and with slight modifications, it should be possible to get it working on UWP devices. See, for example, the following pull request: https://github.com/ValveSoftware/steam-audio/pull/349.
Briefly, you will have to make changes to the core Steam Audio SDK (phonon.dll), and the plugins for whatever game engine and/or audio middleware you're using. You'll have to modify the CMake scripts to add appropriate compiler flags for compiling in UWP, and potentially update various platform-dependent #define directives at various places in the code.
Since Steam Audio can also build all of its dependencies from source code, it should also be possible to make a minimal set of dependencies run on UWP.

I would like to note my findings here for anyone in the future looking to run steam-audio on the Hololens.
There is a simple way to force load steam-audio onto the Hololens (UWP), and that is by simply going to Build.cs (Assets\Plugins\SteamAudio\Scripts\Editor) and adding NamedBuildTarget.WindowsStoreApps under the NamedBuildTarget[] supportedPlatforms array. The result of this, however, is that while the HRTF sonification works as expected (similar to Microsoft Spatializer), the reverberations and the results of ray tracing from source do not work. I'm not sure if this requires further edits within the scripts, dependencies, and the underlying code, or whether ambisionic decoding is simply not supported in the Hololens.
A simple workaround to this problem, however, is to run the desired app with holographic remoting. This is similar to developing on VR, where you can run the app on your PC but stream the image to your headset. Holographic remoting supports having the program run under a Windows architecture (you can choose standalone as the build target), while the headset reports all inputs, movements, and interactions to the PC.


Does this work on pages?

Hi, does this script work for pages and only posts?
I've run a few export.xml files thru it--all content and just pages-- and it does not seem to convert theme

same here.. looks like it processes posts only

Correct, only posts (and images). Other content is beyond the scope of this script.


Use node module resolution for @types even when targeting non-node modules

TypeScript Version:  nightly (2.1.0-dev.20160923)
Code
<EMAIL_ADDRESS>export declare class A {}

<EMAIL_ADDRESS>import {A} from "a";
export declare class B extends A {}

tsconfig.json
{
    "compilerOptions": {
        "module": "es2015"
    }
}

src/foo.ts
May leave this empty.
Expected behavior
<EMAIL_ADDRESS>can reference<EMAIL_ADDRESS>Actual behavior
node_modules/@types/b/index.d.ts(1,17): error TS2307: Cannot find module 'a'.
Quick fix
This may be fixed by adding "moduleResolution": "node" to tsconfig.json.

I am sure we had another issue for this, but can not seem to find it.

@andy-ms we should get a fix for this soon as well.

The quick fix doesn't solve the problem when developing AMD-based projects. All modules defined in the project are in AMD format. If moduleResolution is set to node then these modules can't be imported properly.

This will also enable scenario of using Rollup.js for bundling and npm link for linking components / solution projects
(rollup requires ES6 modules, and right now emitting ES6 modules breaks Node module resolution)

@cnshenj What is your workaround for now? We have the same problem with momentjs and knockout-decorators

@ViceIce Just keep using typings to get all declaration files for AMD-based projects. Have to wait for TypeScript 2.1 to switch from typings to @types.

@cnshenj If you use relative path then it will work. That's the workaround for me.


Separate shield for Hungary primary routes

In Hungary, there are two separate shields for motorway and primary routes, however they use the same network value.  Motorway shields use a ref with an "M" prefix.  Since these shields are the exact same style, just with different colors, we can use the same type of code that we use for the special Georgia routes (may require re-coloring the SVG to be black as a base).

I forgot to add that there are also some trunk routes which start with M, which can be seen in this list.
https://hu.wikipedia.org/wiki/Sablon:Magyarország_autópályái
Autópályák = Motorways
Autóutak = Expressways
the rest isn't interesting because they are only either planned or they are dropped plans.
The only important thing is that those which start with M are blue (M3, M25 etc), the rest are green like 3, 24, 222.

In Hungary, there are two separate shields for motorway and primary routes, however they use the same network value. Motorway shields use a ref with an "M" prefix. Since these shields are the exact same style, just with different colors

Has anyone considered creating separate networks of routes that connect? This approach was taken in Vietnam (#190) for essentially the same situation, and it hasn’t led to any problems that I’m aware of.

Currently this project gives all network=HU:national routes a blue shield, even though most of the relations are main roads that should have a green shield. We should remove support for network=HU:national until there’s a way to reliably distinguish the two networks.
https://github.com/ZeLonewolf/openstreetmap-americana/blob/e5fe35be2653a0cf96acec634e49fe3df829dce1/src/js/shield_defs.js#L3385-L3393

Shield support to be removed in #702.


Bump Jinja2 dependency to 3.0.1

Description
Bumps jinja2 to 3.0.1.
Part of inmanta/infra-tickets#143
Self Check:

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches iso4 in 705b3057c7cc33d09223388c426e9011c0300a77


Add logging test playbooks/roles to master

created telemetry_logging and qe_common roles to enable logging tests in zuul.

closing merge request.


Input fields with validation should not use color alone to show validation state

Currently we only change the border color of the input field. This would cause an accessibility issue as screen readers aren't able to read style changes. We need to provide a way to show validation besides changing the color of an input field.

It might not be really necessary in this case because the query won't be used unless the user focuses the input box and presses enter. And when the focus the input box, they will see the error message.

Since our input boxes don't have a border by default and a border is added when there is focus + validation, this actually does not become an accessibility issue as the shape is included for showing meaning. I'll close this issue.


document.createElement is undefined when using Chrome debugger

[I fixed the issue and have a resolution; just documenting it here for future guidance.]
In my main app file I had two requires:
var NativeModules = require('NativeModules');
var React = require('react-native');

This caused a problem because requiring NativeModules would end up requiring ExecutionEnvironment down the road, whose job it is to check if the DOM is available by testing for document.createElement. In order to force this test to fail - since React Native usually doesn't have the DOM available - InitializeJavaScriptAppEngine sets document.createElement to null. Back to the problem: this means InitializeJavaScriptAppEngine must run before ExecutionEnvironment.
The solution is to always require React before any other Facebook-provided JS, and an easy way to do that is to extract Facebook modules from React via destructuring:
var React = require('react-native');
var {
  // This pattern ensures NativeModules is not required before react-native
  NativeModules,
} = React;

cc @amasad -- we've hit this internally a few times as well and maybe we could have a way to pull in InitializeJavaScriptAppEngine at the top with the polyfills.

Yeah it has come up a few times on twitter as well

Yeah seems like it should be part of polyfills. @frantic any objections to making InitializeJavaScriptAppEngine a polyfill module?

@amasad would be awesome!

@amasad  I'm still having this issue, when using react-native 0.4.4.  Here is a very simplified example which reproduces the error:
'use strict';

var React = require('react-native');
var {
  NativeModules,
  AppRegistry,
  StyleSheet,
  Text,
  ListView,
  View,
} = React;

document.createElement('div');

When I run this in the chrome, debugger, I get the error: document.createElement is not a function
What am I doing wrong?

@oveddan document.createElement is not supported within React Native. The bug here was that we were trying to use it at all; we shouldn't attempt to.

Thanks for the clarification @spicyj
My actual use case is to use jQuery to parse/scrape some downloaded html.  I'm not using it with the intention of creating any dom nodes or elements.
When I require('jquery') without the chrome debugger it works fine, but when opening the chrome debugger, I get the error: "document.createElement is undefined"
Simple example:
'use strict';

var React = require('react-native');
var {
  NativeModules,
  AppRegistry,
  StyleSheet,
  Text,
  ListView,
  View,
} = React;

var jquery = require('jquery');

Yes, unfortunately you can't use jQuery out of the box on React Native. Maybe you can use it in conjunction with jsdom, but I don't know anyone who has tried.

@spicyj  I ended up getting jquery to work within react-native for scraping/parsing with a slight modification to it.  See the issue I created within jquery here.  let me know your thoughts!

@oveddan: the proper fix is to remove window.document.createElement = null; altogether. It was used to make sure that ExecutionEnvironment.canUseDOM is false, but we modified this file and it is now false.

Having the same issue when using firebase.

@olivierlesnicki can you please provide a code sample?

Given that I am having exactly the same problem using React Native 0.5.0, and having Chrome Inspector open...

'use strict';

var React = require("react-native");
var Firebase = require("firebase");

var {
    AppRegistry,
    Component,
    StyleSheet,
    Text,
    View,
} = React;

var styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#000000',
  }
});

class App extends Component {
    construtor(props) {
        super(props);
    }

    componentWillMount() {
        var backend = new Firebase("https://whatsthat.firebaseio.com");

        debugger;
    }

    render() {
        return <Text>Testing...</Text>;
    }
}

AppRegistry.registerComponent('whatsthat', () => App);

Including and initializing an instance of Firebase is enough to replicate the issue (consistently)

FWIW, we'll be releasing a fix for the Firebase client shortly (hopefully today) that addresses this.  The client was basically assuming that if document exists, then document.createElement will exist and work, but react-native violates this under the Chrome debugger.

@mikelehen thanks dude!

@mikelehen when are we open-sourcing firebase js library :-p

@mikelehen can you link to the code that fixes this in the firebase library, just for reference for a fix for jquery?

@mikelehen Thanks a mil for 2.2.7.  And I 2nd oveddan's request.  I want to use Google Maps API, and the same problem ("document.createElement is not a function") is occurring...

@mikelehen  If you want to see the temporary solution I came up with for jquery - check this out: https://github.com/jquery/jquery/issues/2349
The issue exists because these libraries believe there is a fully functioning document available, since it's attached to window.document in the chrome or safari debugger. I'm working on a possible solution that will remove document from the global window.
You can see more on that here: #1473


NOS-937, Implement PackageContentAccessResource for NPM

Hi, John
There seem some conflicts couldn't merge automatically, I'm not sure if it will be ok after nos-936 PR be merged. let me know any issue for the PR code or mege stuff.
Thanks.

@yma88 Sorry, I merged this too soon. That was my mistake. Could you take a look at my comments above, and maybe try to work them into your next PR? Or, if I'm not understanding things as well as I should, maybe just let me know where I'm going wrong.


Update sync.yml

I set up a new release, but unfortunately it won't be able to go out just yet. In the meantime, I realized some files were missing from the sync.yml and I hadn't updated it.
I'll keep updates on #300 . Will send out manual updates later once the source GHA's rate limiting problem is fixed.

Going to attempt to return to an earlier version of BetaHuhn/repo-file-sync-action/ for now to avoid rate limit issues.

Let's try this!

Okay. Let's see if this works.


about code

Dear sir:
Do you complete the code like loss ...
looking forward your reply and help
thank you

Hi!
Sorry, but I'm no longer maintaining this repository.
This was an effort to add a new baseline to our paper, but we ended up deciding not to include it.
Feel free to contribute or to use the existing code to finish the implementation. I'll make sure the license is permissive.
Thanks!
Cadar


i am finding an error in visual studio code, here when i run my programs on react, those will give problems to display my program in chrome i am getting a texual examination for all the programs i write so what can i do?

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Repro steps

The log given by the failure

Desired functionality

Mention any other details that might be useful

import React from 'react';
class App extends React.Component {
render() {
var myStyle = {
fontSize: 100,
color: '#FF0000'
}
return (

Header

);
}
}
export default App;
import React from 'react';
class App extends React.Component {
constructor() {
super();
this.state = {
data:
[
{
"id":1,
"name":"Foo",
"age":"20"
},
{
"id":2,
"name":"Bar",
"age":"30"
},
{
"id":3,
"name":"Baz",
"age":"40"
}
]
}
}
render() {
return (

{this.state.data.map((person, i) => )}

);
}
}
class Header extends React.Component {
render() {
return (

Header

);
}
}
class TableRow extends React.Component {
render() {
return (

{this.props.data.id}
{this.props.data.name}
{this.props.data.age}

);
}
}
export default App;
how to merge the above two codes?
Sent from Mail for Windows 10
From: Alan Agius
Sent: Friday, November 30, 2018 11:17 PM
To: angular/angular-cli
Cc: Srigowri Deogirikar; Author
Subject: Re: [angular/angular-cli] i am finding an error in visual studiocode, here when i run my programs on react, those will give problems todisplay my program in chrome i am getting a texual examination for all theprograms i write so what can i do? (#13107)
Closed #13107.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


reorganizer for the RTA

Can it me removed from here?
It this the right place for it?
There are issues I solved in the hiperta_stream repo and should solve here as well otherwise...

How should we proceed then ?

The RTA workflow uses the hiperta_r0_to_dl1lstchain stage (instead of the r0_to_dl1 lstchain stage), and within this stage we also perform the reorganisation;  (line 10 and line 86 of hiperta_r0_to_dl1lstchain).

If we move if from here, we would need to include it in HiPeRTA and thus add the HiPeRTA lib as dependency of the LST_script project...

The reorganiser shouldn't be removed from here (hiperta workflow uses it), but a "homogenisation" of the script must be done (some features added in the hiperta_stream mod that are not included here)


Typescript 3.7 emits .js && .map files for each ts file

TypeScript Version:  3.7.2
Search Terms:
js map files
Code
{
  "compilerOptions": {
    "module": "es2015",
    "moduleResolution": "node",
    "allowJs": true,
    "target": "es5",
    "noImplicitAny": false,
    "sourceMap": true,
    "allowSyntheticDefaultImports": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "noEmitOnError": false,
    "typeRoots": [
      "./node_modules/@types"
    ],
    "lib": [
      "es2015",
      "dom"
    ],
    "baseUrl": "./src/js/",
    "paths": {
      "@projectTypes/*": ["types/*"],
      "@interfaces/*": ["interfaces/*"]
    },
    "skipLibCheck": true,
    "rootDir": "."
  },
  "exclude": ["node_modules", "node-exec", "public", "target", "*.js"]
}

Expected behavior:
When using typescript 3.7, webpack and ts-loader complier shouldn't create js and js.map file for each ts file. Reverting to 3.5.3 fixes issue.
Actual behavior:
Typescript 3.7 create all js and map files for each ts file causing constant reloads using Intellij, where 3.5.x didn't create them at all and live reload worked correctly. I have completely no idea how to force ts to stop emitting those files.

Intellij Issue, no longer valid.

@yadue How I can fix it in Intellij ?

Just uncheck compile ts files in IntelliJ typescript config


Accessibility permissions not working despite being granted

First time on GitHub please bear with
I've loaded everything up as shown, but each time I've attempted to use it, the app asks for accessibility permissions
I hear someone else has also had this issue with Barrier (another app) here: https://apple.stackexchange.com/questions/455212/application-would-like-to-control-this-computer-using-accessibility-features-d
Not sure if it's app specific with this issue, but would like to try using this app if possible. Haven't had this permissions problem with regular apps so far.
Feel free to close if this issue isn't relevant

It worked for me by removing and readding accessibility permission. In fact I do it every time when i do a full recompile and reinstall the application. Not sure why it isn't working on your machine.

Is it possible that Ventura's latest update could contribute to this? It does feel like whatever is preventing the app from functioning is acting silently.
If you aren't having trouble on the latest Ventura (13.2.1) then I'm also unsure. Will update if I find what works

My mac is currently still on Monterey. I will need to update OS to test

a quick search lead me to this reddit post which leads to this article. Not sure if this helps

a quick search leads me to this reddit post which leads to this article. Not sure if this helps

no success with this method. My best guess is related to updated security with Ventura which is more likely with the proposed fix being unsuccessful. Will continue to search for a fix


Add FailWorkflow decider

Test seems to be failing due to an unrelated test?

reran the test, passed.


CUDA perf tweaks

WIP; DO NOT MERGE
This PR is addressing the following issues: https://github.com/deeplearning4j/nd4j/issues/884

This PR also addresses CUDA IsMax implementation and CUDA concat implementation


Fix "sourceRoot" hardcoded to author's computer.

I believe this fixes the issue of source files not being mapped to the correct location when using the .map in chrome/firefox. This fix worked on my work laptop, but having a second person confirm it before merging would be appreciated.
All that should be changed is the "sourceRoot" key/val at the end of both .maps now use "../" to point at the main bower directory relative to current position rather than a path specific to the original author's computer.

This won't solve the problem you mention, as those files are generated automatically with the gulp task: gulp build. Therefore the fix should be done in the task and not on the files that will be overridden with each release.

Ahhh I see now. Thanks for the explanation.

You don't have to close the PR, you can try by setting the sourceRoot option in the source maps generation in the gulp file, following: https://github.com/floridoo/gulp-sourcemaps#write-options

I guess something like sourcemaps.write('./', {includeContent: false, sourceRoot: '/src'})


Print Rubrics Cube Motor Bracket (2 copies)

Two copies of the Rubrics Cube motor bracket need to be printed. The file is RubricsCubeMotorBracketExtended.STL located in the google drive To print folder.

Both copies have been printed successfully, I didn't see the first one, but the second was as nice a print as I've seen


TypeScript typings

Handlebars contains TypeScript typings which totally get lost by using this module. Could you add typings that extend handlebars?

You can do it if you want, and submit a PR ;)

Hi, for people like me who can't bear using an any-typed library :
declare module 'handlebars-async-helpers' {
    import * as hbs from 'handlebars';

    type Handlebars = typeof hbs;

    function asyncHelpers(handlebars: Handlebars): asyncHelpers.AsyncHandlebars;

    namespace asyncHelpers {
        // At least an empty namespace is necessary for allowing "import * as" when allowSyntheticDefaultImports is
        // false. But we'll export our custom types too, so they can be imported too, they can be useful.

        type AsyncTemplateDelegate<Context> = (context: Context, options?: hbs.RuntimeOptions) => Promise<string>;

        interface AsyncHandlebars extends Handlebars {
            // CompileOptions is not explicitly imported because it's transient in the scope due to how it's declared in
            // Handlebars.
            compile<Context = unknown>(input: any, options?: CompileOptions): AsyncTemplateDelegate<Context>;
        }
    }

    export = asyncHelpers;
}

Put this in a .d.ts file that your TypeScript tsconfig.json is configured to read, ex:
{
  "include": ["./stubs/**.d.ts"]
}

If you have allowSyntheticDefaultImports enabled: import asyncHelpers from 'handlebars-async-helpers';
If not: import * as asyncHelpers from 'handlebars-async-helpers';
Note to the author: I don't have time to make a PR but feel free to include this in your project if you want. Basically you'll just have to add a types entry pointing to the .d.ts in your published package.json.


secure="true" ignored on TextField

Secure input is ignored.
      <TextInputLayout
          class="form-input"
          hint="{{ user.passwordHint }}"
          hintAnimationEnabled="true"
          hintTextAppearance="SpecialTextInputLayout"
          [tintColor]="textInputLayout.tintColor"
          [lineColor]="textInputLayout.lineColor"
          [selectedTitleColor]="textInputLayout.selectedTitleColor"
          [selectedLineColor]="textInputLayout.selectedLineColor">
            <TextField
              #passwordTextField
              id="passwordTextField"
              [editable]="!isLoading"
              [(ngModel)]="user.password"
              autocorrect="false"
              autocapitalizationType="none"
              secure="true"
              returnKeyType="done"
              returnPress="submit()">
            </TextField>
        </TextInputLayout>

The secure="true" does not work with textinputlayout added.

I also have this issue on iOS 11.0.3
Works fine on android.

The issue here might be that you are not using a single TextInputLayout tag for iOS as described in the instructions.

@chuckmitchell I tried making it the bare minimum on iOS:
a single TextInputLayout tag and a single secure TextView… and it does not resolve the issue. Moreover, If I do a single TextInputLayout tag, I cannot set the hint for each TextView individually anymore. I am not sure te documentation says you should use a single tag for iOS. I think it just means a single child tag.

There should NOT be a nested TextField with iOS. The docs are very explicit about that:
https://github.com/bradleygore/nativescript-textinputlayout#ios
<TIL:TextInputLayout
    hint="{{ hint }}"
    isEnabled="{{ isEnabled }}"
    disabledColor="#c3c3c3"
    error="{{ error }}"
    text="{{ demoText }}"
    title="{{ title }}"
    color="{{ error ? '#aa0000' : '#d745ff' }}"
    tintColor="#d745ff"
    lineColor="#d745ff"
    selectedTitleColor="#ff45ca"
    selectedLineColor="#7a45ff"
    lineHeight="1.25"
    selectedLineHeight="3.5" />

@benjaminhorner - also, you can set the hint for each TextInputLayout individually (providing your variables backing the value are individualized...) as they are individual instances and in no way relating to one another... Please review the demo - there are multiple fields all with different hints in the demo app.

@bradleygore : thanks for your response. My bad.
However, the secure="true" still does not work on iOS. Here is the layout I am using.
        <!-- username text input -->
        <TextInputLayout
            #usernameTextField
            id="usernameTextField"
            class="form-input form-textfield"
            [hint]="user.usernameHint"
            hintAnimationEnabled="true"
            hintTextAppearance="SpecialTextInputLayout"
            [tintColor]="textInputLayout.tintColor"
            [lineColor]="textInputLayout.lineColor"
            [selectedTitleColor]="textInputLayout.selectedTitleColor"
            [selectedLineColor]="textInputLayout.selectedLineColor"
            [editable]="!isLoading"
            [(ngModel)]="user.username"
            autocorrect="false"
            autocapitalizationType="none"
            returnKeyType="next"
            returnPress="focusSecond">
        </TextInputLayout>
        <!-- /username text input -->
        <!-- Instance name text input -->
        <TextInputLayout
            #instanceTextField
            id="instanceTextField"
            class="form-input"
            hint="{{ user.instanceNameHint }}"
            hintAnimationEnabled="true"
            hintTextAppearance="SpecialTextInputLayout"
            [tintColor]="textInputLayout.tintColor"
            [lineColor]="textInputLayout.lineColor"
            [selectedTitleColor]="textInputLayout.selectedTitleColor"
            [selectedLineColor]="textInputLayout.selectedLineColor"
            [editable]="!isLoading"
            [(ngModel)]="user.instanceName"
            autocorrect="false"
            autocapitalizationType="none"
            returnKeyType="next"
            returnPress="focusThird">
        </TextInputLayout>
        <!-- /Instance name text input -->
        <!-- Password text input -->
        <TextInputLayout
            #passwordTextField
            id="passwordTextField"
            class="form-input"
            hint="{{ user.passwordHint }}"
            hintAnimationEnabled="true"
            hintTextAppearance="SpecialTextInputLayout"
            [tintColor]="textInputLayout.tintColor"
            [lineColor]="textInputLayout.lineColor"
            [selectedTitleColor]="textInputLayout.selectedTitleColor"
            [selectedLineColor]="textInputLayout.selectedLineColor"
            [editable]="!isLoading"
            [(ngModel)]="user.password"
            autocorrect="false"
            autocapitalizationType="none"
            secure="true"
            returnKeyType="done"
            returnPress="submit()">
        </TextInputLayout>

I suppose in a way this is related to my other question here. For exampl if I wanted to add padding to the TextView (or on iOS on the TextInputLayout).

Styling issue is separate, so I'll only address secure here: The ios version of this simply inherits from the nativescript TextField (see here). If the TextField supports secure on iOS, then great - this should too just as it supports the text property. I am not sure why it would not support it exactly the same.

@benjaminhorner - was this closed because it ended up working, or some other reason?

@bradleygore yes it works. So does the styling… partially. Padding does not work.


DOC Update eagerLoad() docblock

Issue https://github.com/silverstripe/silverstripe-framework/issues/10826

Updated


New schema for attributes

#[repr(...)] related queries are now using the new Attribute schema from the updated adapter (https://github.com/obi1kenobi/trustfall-rustdoc-adapter/pull/5). This allows to solve problems such as https://github.com/obi1kenobi/cargo-semver-check/issues/104. For now, only the #[repr(...)] related queries and their tests have been updated as they were the main reason for this issue.
Queries require the new adapter https://github.com/obi1kenobi/trustfall-rustdoc-adapter/pull/5 to work correctly.

I added tests according to the above comments and did some small refactoring. Knowing that the recent PRs, especially #203 changed a lot in the project structure / how the tests work, I now have the following questions/ideas:

Could we separate adding the as_string output for some lints into a dedicated issue, as well as expanding it with general lint refactoring / adjusting as the issue's target?
I don't know if it would be easier to first merge the mentioned PR, then solve the merge conflict and merge this, or to create a separate branch for rewriting the tests to avoid an avalanche of merge conflicts? What works better in your opinion?

I feel guilty for leaving this PR inactive for too long, hopefully we can merge it (or whatever it's fate is) as soon as the new adapter is released!

Happy to save the lint query changes for a future PR, good suggestion. I merged #203 since it was good to go and was huge and difficult to keep reviewing. Sorry to make you have to resolve a complex merge.

After all, the merge wasn't really that complex - turned out to be more of a refactoring one. As soon as the new trustfall-rustdoc release comes out, including the new schema for attributes, this PR should instantly pass the checks.
For now, I have 2 side notes / questions:

in the enum_repr_int_changed test crate, there also were cases against it mistakenly reporting a removal of an attribute as a change (and vice-versa for the enum_repr_int_removed test crate). Since we now run every lint on all test cases, this resulted not only in the two aforementioned files being almost identical, but also their test outputs. I thus decided to remove the duplicate code, but if the testing strategy was due to change in the future, I can bring the files back to their original form.
the two files mentioned above also share a portion of cases that just rearrange the attributes rather than changing or removing them. With the new crate test system, these could be separated to form an error-free crate (potentially representing a wise user that gracefully avoided semver violations), potentially introducing a new test scenario (more of these could be added in the future as well). Once again, depending on the future testing strategy, should I bring this idea to life or leave things as-is?

in the enum_repr_int_changed test crate, there also were cases against it mistakenly reporting a removal of an attribute as a change (and vice-versa for the enum_repr_int_removed test crate). Since we now run every lint on all test cases, this resulted not only in the two aforementioned files being almost identical, but also their test outputs. I thus decided to remove the duplicate code, but if the testing strategy was due to change in the future, I can bring the files back to their original form.

I'm generally not that worried about duplicate test cases in different crates: there just isn't much damage that this can do in practice, as far as I can tell. Would you agree?
If so, let's not worry about duplicate test cases. But also if you are sure you didn't accidentally deduplicate code that looked similar but wasn't identical, there's no need to revert, either.

the two files mentioned above also share a portion of cases that just rearrange the attributes rather than changing or removing them. With the new crate test system, these could be separated to form an error-free crate (potentially representing a wise user that gracefully avoided semver violations), potentially introducing a new test scenario (more of these could be added in the future as well). Once again, depending on the future testing strategy, should I bring this idea to life or leave things as-is?

Either way is fine. I'm not opposed to the idea, I just don't think these kinds of changes are particularly high-impact: our users won't notice them, and it doesn't seem like it would make us particularly more effective either. So I would personally pick something else.

if the testing strategy won't change, should I also look through all of the tests to remove duplicate cases / separate cases that don't break semver into their own crates?

Same as above. Not opposed to it, just doesn't seem to me like it makes that big of an impact so I would advise picking something else.

What's changed:

enum_repr_int_changed received additional tests for all permutations of old_attr -> new_attr with u64, i64, usize, isize as one of either attributes. The missing mirror comment from old version was also copied to new version,
all of the _removed lints affected by this PR (enum_repr_c_removed, enum_repr_int_removed, struct_repr_c_removed, struct_repr_transparent_removed) have received an addition of old_attr: raw_attribute @output line to help with potential debugging in the future (templated error messages have not been changed). I decided to add this output for all of the lints mentioned above to keep the output somewhat uniform using the new schema for attributes. Hopefully it's ok this way!

Looks great! I'll publish the underlying changes this needs in the adapter, and then merge this right after.
Should be able to release a new cargo-semver-checks tonight 🤞


Missing Font

From "File->Open Folder->" or "File->Open File" or "File->Open Workspace" Instead of showing the text of my Files and Folders, every character is replaced by a Blank square. I suppose this is due to a missing Font. However i only have this visual bug while i'm in the browse/open file/window. Any other menu or tooltip within VSCodium works as intended. I freshly installed VSCodium through Snap. My Os is Fedora 33

Is it reproducible in installation ov VS Code https://code.visualstudio.com/Download ?
Issue tracker for VSCodium is in different repo.

/gifPlease

Trying to install VSCode through snap or package manager didn't gave me this visual bug, so it must be related to the snap version of VSCodium. I'm closing this Issue


BigNumber needed for trading form

Clubhouse Story
create-market-form-liquidity-charts container needed props that MarketOutcomeCharts view needed
and minPrice and maxPrice needed to be BigNumber.
trading form needed to take in BigNumber instead of number
Submitter checklist

[x] Test covering functionality added/fixed in
Check the linked story includes the following:

[x] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass

Enjoy, this is needed so creat market doesn’t vomit


[http] Validate request parameters

Validate that request parameters and body values are within the accepted ranges. For example, getting some members from a guild can only get at most 1000 at a time. This will help prevent as many 400s as we can.

Still missing, but is not a blocker

Closed by #167


Wrong documentation

Documentation states that Unity 2019 or higher is required for the plugin, but FigmaToolkitWindow.Files.cs scritps makes use of  IStyles.textOverflow which only exists in Unity 2020 (see also Unity 2019)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18e28461-f92f-9dc2-d7da-3fbaf06294f4
Version Independent ID: 656f2e72-15c0-b971-9a38-4a1d40410379
Content: MRTK Figma Bridge for Unity - Mixed Reality
Content Source: mixed-reality-docs/mr-dev-docs/design/figma-unity-bridge.md
Product: mixed-reality
Technology: mr-dev
GitHub Login: @DongPark
Microsoft Alias: dongpark

Hey can I have a look at this?


Possible fix for #539

Thanks! I think the issue was that I had to narrow that * function no avoid ambiguity warnings, and it ended up excluding dates. This does the trick though.


Command to create new terminal with the same profile as the active instance

We have commands to spawn new terminal: Terminal: Create New Terminal and Terminal: Create New Terminal (With Profile).
Would love to have a simple new one to create a new terminal with the same profile as the active terminal instance. For instance, the command Terminal: Kill the Active Terminal Instance references the specific terminal.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Envoy 1.31 regression fails TLS connection with "Different CRL scope"

Title: Envoy 1.31 regression fails TLS connection with "Different CRL scope"
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.
Envoy 1.31.2 has regression in establishing TLS connection where CRL file is provided to validation_context (see the attached crl-issue-google.txt line 157):

validation_context:
...
    crl:
      filename: /var/envoy/crl/crl_chain.pem

The following error appears into envoy proxy log (see the attached actual_proxy_logs_envoy_1.31.2_with_CRL.txt line 435):
[2024-11-13 14:33:18.824][15][debug][connection] [source/common/tls/cert_validator/default_validator.cc:321] verify cert failed: X509_verify_cert: certificate verification error at depth 0: Different CRL scope

Result is that no TLS connection is established, as server certificate can not be validated. Envoy proxy returns error 503 (see attached actual_proxy_logs_envoy_1.31.2_with_CRL.txt line 448):
[2024-11-13 14:33:18.824][15][debug][http] [source/common/http/conn_manager_impl.cc:1825] [Tags: "ConnectionId":"0","StreamId":"5841265069824858706"] encoding headers via codec (end_stream=false):
':status', '503'
'content-length', '216'
'content-type', 'text/plain'
'date', 'Wed, 13 Nov 2024 14:33:18 GMT'
'server', 'envoy'

If CRL file configuration is not provided to validation_context there is no error (see attached actual_proxy_logs_envoy_1.31.2_no_CRL.txt line 447).
[2024-11-13 14:42:01.183][13][trace][router] [source/common/router/upstream_request.cc:271] [Tags: "ConnectionId":"0","StreamId":"14230748880180077114"] end_stream: false, upstream response headers:
':status', '200'
'date', 'Wed, 13 Nov 2024 14:42:01 GMT'
'expires', '-1'
'cache-control', 'private, max-age=0'
'content-type', 'text/html; charset=ISO-8859-1'
'content-security-policy-report-only', 'object-src 'none';base-uri 'self';script-src 'nonce-NJ5E4KyZLBE29ZYiBezs2w' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp'
'accept-ch', 'Sec-CH-Prefers-Color-Scheme'
'p3p', 'CP="This is not a P3P policy! See g.co/p3phelp for more info."'
'server', 'gws'
'x-xss-protection', '0'
'x-frame-options', 'SAMEORIGIN'
'set-cookie', 'AEC=AZ6Zc-XEwlxjpirTEJx5gJ4UIVn8G3mN0nHijcPZ5d8lRVcbaDYmzGdw-QE; expires=Mon, 12-May-2025 14:42:01 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax'
'set-cookie', 'NID=519=nGIjYZ_v4s8KJus5KCRULXonjVTICQf66Qd_4j0uywQm8unJSIq7nc_yDrJAQUEKeZ6FXDFoNAL5SFqSHC4HSatjteSAMgq69nK33HeTYHeqF-m4Rxy6xoHzR5PHvqYhsrFqwOsoLZcEHRCoQRQuFdmCV7k5JKZn33JvzDdmzqE; expires=Thu, 15-May-2025 14:42:01 GMT; path=/; domain=.google.com; HttpOnly'
'accept-ranges', 'none'
'vary', 'Accept-Encoding'
'transfer-encoding', 'chunked'

There is also no error using previous Envoy proxy version 1.30.6 with CRL configuration (see attached actual_proxy_logs_envoy_1.30.6_with_CRL.txt line 446)
[2024-11-13 14:39:52.733][14][trace][router] [source/common/router/upstream_request.cc:264] [Tags: "ConnectionId":"0","StreamId":"8873189177633692968"] end_stream: false, upstream response headers:
':status', '200'
'date', 'Wed, 13 Nov 2024 14:39:52 GMT'
'expires', '-1'
'cache-control', 'private, max-age=0'
'content-type', 'text/html; charset=ISO-8859-1'
'content-security-policy-report-only', 'object-src 'none';base-uri 'self';script-src 'nonce-mc8usyGmjnlf31OLrXOZVA' 'strict-dynamic' 'report-sample' 'unsafe-eval' 'unsafe-inline' https: http:;report-uri https://csp.withgoogle.com/csp/gws/other-hp'
'accept-ch', 'Sec-CH-Prefers-Color-Scheme'
'p3p', 'CP="This is not a P3P policy! See g.co/p3phelp for more info."'
'server', 'gws'
'x-xss-protection', '0'
'x-frame-options', 'SAMEORIGIN'
'set-cookie', 'AEC=AZ6Zc-W_XqHKI4Tkk50edDQJJyZMvB6rFld0E8SR4zp1ZFCu6oF12q6_hjE; expires=Mon, 12-May-2025 14:39:52 GMT; path=/; domain=.google.com; Secure; HttpOnly; SameSite=lax'
'set-cookie', 'NID=519=AyURhoiAGI-_-4_fPzs5hFWz0_cq40cVn09F1pcU40Z6f3D7SvlC-_7yKhBV75Fv7d22330PsNk-5HN2unEdkn5_mk6OMztiDlQblrwCasuMFfbuNp5JYnYN6yT9lRSABMGxvxrMpjb-xeCuCx_7zuaLgk-2sRVfZIoAVVk1neE; expires=Thu, 15-May-2025 14:39:52 GMT; path=/; domain=.google.com; HttpOnly'
'accept-ranges', 'none'
'vary', 'Accept-Encoding'
'transfer-encoding', 'chunked'

It is expected that Envoy proxy 1.31.x can establish TLS with provided CRL file, as the previous Envoy proxy version 1.30.6 can!
Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.
Issue can be reproduced by:

Deploy the attached crl-issue-google.yaml.txt file to any k8s cluster.
Bash into the sleep pod:

kubectl exec --stdin --tty sleep-<id-of-the-pod> -n default-- /bin/sh

Execute cURL command:

curl -v http://localhost:10000/test-crl

Expected output is:

~ $ curl -v http://localhost:10000/test-crl
* Host localhost:10000 was resolved.
* IPv6: ::1
* IPv4: <IP_ADDRESS>
*   Trying [::1]:10000...
* connect to ::1 port 10000 from ::1 port 40434 failed: Connection refused
*   Trying <IP_ADDRESS>:10000...
* Connected to localhost (<IP_ADDRESS>) port 10000
* using HTTP/1.x
> GET /test-crl HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/8.11.0
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 200 OK
< date: Wed, 13 Nov 2024 14:32:19 GMT

Actual output is filed request:

~ $ curl -v http://localhost:10000/test-crl
* Host localhost:10000 was resolved.
* IPv6: ::1
* IPv4: <IP_ADDRESS>
*   Trying [::1]:10000...
* connect to ::1 port 10000 from ::1 port 47248 failed: Connection refused
*   Trying <IP_ADDRESS>:10000...
* Connected to localhost (<IP_ADDRESS>) port 10000
* using HTTP/1.x
> GET /test-crl HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/8.11.0
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 503 Service Unavailable
< content-length: 216
< content-type: text/plain
< date: Wed, 13 Nov 2024 14:33:18 GMT
< server: envoy
<
* Connection #0 to host localhost left intact
upstream connect error or disconnect/reset before headers. reset reason: remote connection failure, transport failure reason: TLS_error:|268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED:TLS_error_end

You may find the different outputs described in details at the attached results_console.txt.

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

no private data attached

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

no private data

Config:

Include the config used to configure Envoy.
See the attached crl-issue-google.yaml.txt line 74, and line 145

Logs:

Include the access logs and the Envoy logs.
See the attached files: actual_proxy_logs_envoy_1.31.2_with_CRL.txt; actual_proxy_logs_envoy_1.31.2_no_CRL.txt; actual_proxy_logs_envoy_1.30.6_with_CRL.txt

Note: If there are privacy concerns, sanitize the data prior to
sharing.

no private data

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

no crash

actual_proxy_logs_envoy_1.31.2_no_CRL.txt
actual_proxy_logs_envoy_1.31.2_with_CRL.txt
crl-issue-google.yaml.txt
results_console.txt
actual_proxy_logs_envoy_1.30.6_with_CRL.txt

cc @ggreenway

@ggreenway Can we expect fix at Envoy, so CRL check do work also for Envoy versions > 1.30.x? At the issue above we setup Envoy cluster endpoint to google.com, but it fails TLS with CRL check also for other domains.

    clusters:
        - name: google_service
          type: STRICT_DNS
          dns_lookup_family: V4_PREFERRED
          load_assignment:
            cluster_name: google_service
            endpoints:
              - lb_endpoints:
                  - endpoint:
                      address:
                        socket_address:
                          address: www.google.com
                          port_value: 443

@ditenev nobody is currently investigating this any further. Unless someone investigates how to fix this and proposes a solution, you should not expect a change/fix for this.