End day Display

Description
Update on End Day Display Feature Implementation
I've made significant progress on the End Day Display feature for our game, focusing on several key areas to enhance user interaction and visual appeal at the end of each game day. Here’s a breakdown of what has been implemented:
Implemented Features:

Displaying Money:
Implemented an animated display of the money earned during the day. The animation smoothly counts up from zero to the day's total earnings, providing immediate feedback on player performance.
Customer Lists:
Added real-time updates to the customer lists. As players interact with the game, the customer list is updated to reflect new additions or changes throughout the day, ensuring that players have up-to-date information on their customer interactions.
Integration with Level System:
Successfully integrated the End Day Display with the game's level system. Now, the display is triggered seamlessly at the end of each level, providing a natural transition from gameplay to the summary screen.
UI Enhancements:
Bird and Dot Animations: Added animations of birds and dots flying across the screen, which not only enhances the visual appeal but also provides a dynamic background that changes as the day progresses.
Money Animation: Beyond the numeric display, the coin images animate, contributing to an engaging visual effect that captures the player's earnings in a more vivid manner.
Customer List Updates: Ensured that the customer list component is not only updated in real time but also includes smooth transitions and animations as the list changes.

Dependencies
List any features on which this ticket relies. If there is already an existing ticket, reference it using #xx. If a feature needs to be implemented and the issue does not already exist... make a new ticket and leave it unassigned for someone else to take on.
e.g. Random game mode relies on random map seed generation(#xx).
Milestones
List of sub-features you intend to have done and in Master by the end of the sprint.

[ ] Goal 1 (Aug. 20)
[ ] Goal 2 (Aug. 23)
[ ] Goal 3 (Aug. 26)
[ ] Goal 4 (Aug. 28)

Completion Deadline: Aug. 30
Extras (optional)

[ ] Extra components that you may implement if you get time.
[ ] ...

Documentation

Main description of feature
User documentation
...

Members

Name (GitHub Username) (Slack Handle) -- only one is needed if they are the same.
e.g. Richard (@AppleByter) (Richard Thomas)

#248


Patch 5

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PR cancelled, was supposed to be done to a fork and not the main repo

PR cancelled, was supposed to be done to a fork and not the main repo


Evaluation errors missing context while syntax errors have them

When I encounter an evaluation error, I am not given any context, e.g. method name, line, etc.
$ python3 test.py .vela.star
Traceback (most recent call last):
  File "/Users/colin/Source/myproject/python-poetry/test.py", line 10, in <module>
    print(s.eval("main([])"))
starlark_go.errors.EvalError: unknown binary op: NoneType | dict

I am given this information for syntax errors:
$ python3 test.py .vela.star
Traceback (most recent call last):
  File "/Users/colin/Source/myproject/python-poetry/test.py", line 8, in <module>
    s.exec(input_file.read())
starlark_go.errors.ResolveError: <expr>:140:1: if statement not within a function

Perhaps the user can be given the context.

If you catch the EvalError, is there anything in the .backtrace property? That should map to<EMAIL_ADDRESS>

Yes!
from starlark_go.errors import EvalError
try:
    print(s.eval("main([])"))
except EvalError as e:
    print(e.backtrace)

produces
$ python3 test.py .vela.star
Traceback (most recent call last):
  <expr>:1:5: in <expr>
  <expr>:143:10: in main
Error: unknown binary op: NoneType | dict

when I inject an error. I fixed the original error; there was a missing return statement ;-)
Could the top of that stack be added to the EvalError message text?

Probably, it looks like EvalError exposes a CallStack full of CallFrames, each of which has a syntax.Position.
We would probably want to add function_name, line, and column members to the Python EvalError, add additional parameters to hold them to the C wrapper for its constructor, and then populate them from either the first or the last CallFrame when an EvalError is raised. Not sure what the right thing to do would be if the CallStack is empty, probably just "unknown", 0, 0.


Add WIM detailed data to son-gtkwim

We need to have more detailed data on each one of the WIMs. This data must be made visible on the Gatekeeper, so that the BSS can choose the location.

See also #637

Closed, as #637 has also been closed: data and API exists


Computational requirements of HIPPO greedy algorithm

Hi Jakub,
Thank you for sharing this very interesting work. I would be interested to know how computationally expensive it is to run the HIPPO greedy algorithm on a WSI with N tiles.  And what hardware was required for what time frame? How does this scale with an increase in tiles?
Thank you already!
Lydia

hi @lely475 - thanks for reaching out. the greedy search algorithm is approximately O(n^2).
i used an nvidia A100 and i set torch.set_float32_matmul_precision("high") to increase the speed. it can take several hours to run a slide with a few thousand patches. what i do in practice is run it on 5% of the patches, to find the most important 5% patches.
i am alo working on a version where K patches are removed at each iteration. that will greatly decrease the running time.

i am closing this issue. please re-open if you wish.


Define file subtype value behavior/expectations

Is your feature request related to a problem? Please describe.
Not clear if the CFE_FS_InitHeader SubType needs to be one of the FS enums or if it can be user defined by apps.  Note there is no longer a shell file created by ES:
https://github.com/nasa/cFE/blob/e80aae94e0f56b868657daba965c590766a4dc57/modules/core_api/fsw/inc/cfe_fs_extern_typedefs.h#L101-L108
Describe the solution you'd like
Need to determine if FS should define all file subtypes, or treat it as an extendable field (or whatever).  That will affect if the SHELL subtype gets removed or renamed (since there is still an app that would create it).  Note right now apps don't even use CFE_FS_InitHeader, but they do currently set unique values.
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC

Could add context (app name) to the header to deconflict subtype when extended.

CCB:2021-04-21 DISCUSSED

The SubTypes defined within the cFE FS header are cFS framework only, and apps are allowed to extend.  Could be future work issue to add app context to the header to avoid conflict.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/go-sdk-core/v5
require
minor
v5.17.5 -> v5.18.0

github.com/IBM/platform-services-go-sdk
require
patch
v0.69.2 -> v0.69.3

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.40.4 -> v1.41.1

Release Notes

IBM/go-sdk-core (github.com/IBM/go-sdk-core/v5)
v5.18.0
Compare Source
Features

IamAssumeAuthenticator: introduce new authenticator type (#229) (df85f15)

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.69.3
Compare Source
Bug Fixes

build: bump go core to 5.18.0 (#359) (5d1ad83)

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.41.1
Compare Source
Bug Fixes

deps: update gomod (#885) (092ec2a)

v1.41.0
Compare Source
Features

Increase default stack poll time to 60sec and expose as option (#883) (b31c896)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

1 additional dependency was updated

Details:

Package
Change

github.com/IBM-Cloud/power-go-client
v1.8.1 -> v1.8.3

/run pipeline

:tada: This PR is included in version 1.28.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: switch to universe-domain endpoint for ComputeEngineCredentials

for context: b/339455969

Added do-not-merge flag to confirm status before merging this.


wrong path for screenshot attachments for all but first device after downloading report from CI

Affected Version
1.6.1
Repro steps

Generate test result bundles for multiple devices on a CI machine.
Run xchtmlreport on the CI machine passing multiple result bundles

resultBundlePath="/Users/$(whoami)/Library/Caches/output/testResult"
xchtmlreport -r $resultBundlePath/test1 -r $resultBundlePath/test2 -r $resultBundlePath/test3

Download the full result bundle directory from the CI machine, that includes the index.html report created by xchtmlreport.
Open the downloaded index.html.
Observe the paths for screenshots for test1 are correct but subsequent tests are incorrect.

Expected:
Paths for screenshots are correct
Actual:
Paths for screenshots are only correct for the first test/device.
(Ex. valid path from test1)
file:///Users/<local_user>/Downloads/test-result-c116b6e5-a19f-4da9-a379-74dfaa49e69b/test1/1_Test/Attachments/Screenshot_2ED1B455-01F5-410F-9A35-F7B92F31D9FA.jpg
(Ex. invalid path from test3)
file:///Users/<ci_machine_name>/Library/Caches/output/485E6A64-A799-4B69-9D10-0E5456B8CB89/test3/1_Test/Attachments/Screenshot_FD4F06B9-4D92-4648-8E81-74B6A65D586C.jpg

@TitouanVanBelle : This is an issue on 1.6.1 as well.

@ripunjayasaran @algrubb
Could you guys build xchtmlreport from source on the branch 83_fix_use_absolutepaths and see if that works for you?

Hi @TitouanVanBelle
I've installed the xchtmlreport using "83_fix_use_absolutepaths" branch. But still I'm unable to see the screen shots for devices except first one.
bash <(curl -s https://raw.githubusercontent.com/TitouanVanBelle/XCTestHTMLReport/83_fix_use_absolutepaths/install.sh)


chore(main): release react 0.0.6-experimental

:robot: I have created a release beep boop
0.0.6-experimental (2024-11-03)
🧹 Chore

release main (bcbb7b4)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/open-socket/js-sdk/releases/tag/react-v0.0.6-experimental :sunflower:


selection issues in code cells

If you select code in one cell, then select code in another cell the first selection is still highlighted and it is confusing.

I agree, this does seem counter to how text areas work on the web
http://jsfiddle.net/v0q9by0e/

+1


Treat Coach slot as a spectator

Hey!
Is it possible to treat the coach as a spectator? So that he does not appear in the team?
It's very confusing that he spawns with the team at the start of the round and is then "killed".
We tried it as Spectator and in the team with .coach t or .coach ct.

Thanks and best regards
Anni

Hey!
Sadly it is not possible to treat coaches as spectators, because CS2 doesn't have a coach slot yet.
So this is a workaround that we are using where treat coach as a player and kill them when the freezetime ends.
Hopefully CS2 introduces the coach slot soon so that we don't have to use this workaround and it can become same as CSGO
Thanks!

Hey!
Ahhhh, I see. Okay, thanks a lot :)
Anni


clone repository and install the project on your device

Installed Flutter
Configured FLutter on my machine
Installed vs code
Inslatedd Android studio
Installed extensions for flutter and dart
Installed Android drivers for windows


submission

Great work! I encountered some errors when submitting the pkl file, I am not sure if it is a script error or a parameter error.
My test script:
bash ./tools/dist_test.sh projects/openlanev2/configs/baseline_large.py work_dirs/baseline_large/epoch_24.pth 8  --eval bbox --eval-options dump=True dump_dir=work_dirs/baseline_large
My test data config:
    test=dict(
        type=dataset_type,
        data_root=data_root,
        meta_root=meta_root,
        collection='data_dict_subset_A_val',
        pipeline=test_pipeline,
        test_mode=True),

After submitting the result.pkl:
Traceback (most recent call last):
  File "/code/scripts/workers/submission_worker.py", line 500, in run_submission
    submission_metadata=submission_serializer.data,
  File "/tmp/tmpigcmv59_/compute/challenge_data/challenge_1925/main.py", line 58, in evaluate
    raise Exception(f'The submission file size is limited to 500 MB.')
Exception: The submission file size is limited to 500 MB.

Thanks for your help!

Hi, the error message indicates that your submitted file is too large. Maybe consider some measures like reducing the number of points which describe a centerline or reducing the number of prediction for a single frame.

Thanks for your suggestion!
To submit on evalai, I should upload the result of the test set?  I encountered some errors on test set, I am not sure whether I use the right script args?
My test script:
bash ./tools/dist_test.sh projects/openlanev2/configs/baseline_large.py work_dirs/baseline_large/epoch_24.pth 8 --format-only --eval-options dump=True dump_dir=work_dirs/baseline_large/
My test data config: change 'val' to 'test'
    test=dict(
        type=dataset_type,
        data_root=data_root,
        meta_root=meta_root,
        collection='data_dict_subset_A_test',
        pipeline=test_pipeline,
        test_mode=True),

Part of error logs:
  File "./tools/test.py", line 260, in <module>
    main()
  File "./tools/test.py", line 236, in main
    outputs = multi_gpu_test(model, data_loader, args.tmpdir,
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/mmdet/apis/test.py", line 107, in multi_gpu_test
    for i, data in enumerate(data_loader):
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 521, in __next__
    data = self._next_data()
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1203, in _next_data
    return self._process_data(data)

  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "mmdetection3d/mmdet3d/datasets/custom_3d.py", line 433, in __getitem__
    return self.prepare_test_data(idx)
  File "mmdetection3d/mmdet3d/datasets/custom_3d.py", line 245, in prepare_test_data
    input_dict = self.get_data_info(index)
  File "mmdetection3d/projects/openlanev2/baseline/datasets/openlane_v2_dataset.py", line 292, in get_data_info
    input_dict.update(self.get_ann_info(index))
  File "mmdetection3d/projects/openlanev2/baseline/datasets/openlane_v2_dataset.py", line 301, in get_ann_info
    gt_lc = np.array([lc['points'] for lc in frame.get_annotations_lane_centerlines()], dtype=np.float32)
TypeError: 'NoneType' object is not iterable

Thanks for your help!

I think that is cause by empty prediction, maybe you can filter them out.

Is my test script right? the error logs seem happened in the loading annotation step, got None without annotation in the test set. Could you provide a sample script for evalai submission?
Thanks for your help!

Hi, I just notice that you use --format-only, please use --eval * instead.

use--eval * requires annotations when loading the test set in get_ann_info.
However, the test set does not have annotations.
data loader error logs:
TypeError: Caught TypeError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File " anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 287, in _worker_loop
    data = fetcher.fetch(index)
  File " anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File " anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File " BEV/mmdetection3d/mmdet3d/datasets/custom_3d.py", line 433, in __getitem__
    return self.prepare_test_data(idx)
  File " BEV/mmdetection3d/mmdet3d/datasets/custom_3d.py", line 245, in prepare_test_data
    input_dict = self.get_data_info(index)
  File "BEV/mmdetection3d/projects/openlanev2/baseline/datasets/openlane_v2_dataset.py", line 292, in get_data_info
    input_dict.update(self.get_ann_info(index))
  File "BEV/mmdetection3d/projects/openlanev2/baseline/datasets/openlane_v2_dataset.py", line 301, in get_ann_info
    gt_lc = np.array([lc['points'] for lc in frame.get_annotations_lane_centerlines()], dtype=np.float32)
TypeError: 'NoneType' object is not iterable

Do you also include --eval-options dump=True dump_dir=/PATH/TO/DUMP to save the result?

Yes, my test script is as follows:
bash ./tools/dist_test.sh projects/openlanev2/configs/baseline_large.py work_dirs/baseline_large/epoch_24.pth 8 --eval * --eval-options dump=True dump_dir=work_dirs/baseline_large/
The error seems to happened before evaluate:
[                                                  ] 0/4816, elapsed: 0s, ETA:Traceback (most recent call last):
  File "./tools/test.py", line 260, in <module>
    main()
  File "./tools/test.py", line 236, in main
    outputs = multi_gpu_test(model, data_loader, args.tmpdir,
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/mmdet/apis/test.py", line 107, in multi_gpu_test
    for i, data in enumerate(data_loader):
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 521, in __next__
    data = self._next_data()
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1203, in _next_data
    return self._process_data(data)
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1229, in _process_data
    data.reraise()
  File "anaconda/envs/openlanev2/lib/python3.8/site-packages/torch/_utils.py", line 425, in reraise
    raise self.exc_type(msg)
TypeError: Caught TypeError in DataLoader worker process 0.

Hi, I think just comment this line would help.

Hi, the results are stored at this line, which is before the line 360. You can just ignore the error.

Hi, for evaluation, we use 11 points for each certerline. As for the performance, you can try that out on the val set.


Adds WalletConnect adapter pkg

Adds a new package to wrap WalletConnect and expose SignClient and utils
This adapter/wrapper allows us to pin WalletConnect to a version for use with FCL.
It exposes initWcAdapter and additional utils to consumers.
Passing a projectId and optional metadata will initialize and return a SignClient for use in connecting to a Flow enabled WalletConnect wallet. This Adapter will be updated to support WalletConnect api and utils as needed.
EXPECT BREAKING CHANGES
This adapter can be passed to FCL config and used by the application and FCL to connect, authenticate, authorize, and sign messages.
Init adapter/client and add to config
import * as fcl from '@onflow/fcl'
import * as fclWC from '@onflow/fcl-wc'
import { initWcAdapter, getSdkError, QRCodeModal } from '@onflow/fcl-wc'

const wcAdapter = fclWC.initWcAdapter({
  projectId: WC_PROJECT_ID,
  metadata: {
    name: 'FCL WalletConnect',
    description: 'FCL DApp for WalletConnect',
    url: 'https://flow.com/',
    icons: ['https://avatars.githubusercontent.com/u/62387156?s=280&v=4']
  }
})

fcl
  .config()
  .put('wc.adapter', wcAdapter)

Get client from fcl.config
const { client, QRCodeModal } = await fcl.config.get('wc.adapter')

client.on('session_update', ({ topic, params }) => {
  const session = client.session.get(topic)
  console.log('EVENT', 'session_update', { topic, params, session })
})

await client.disconnect({
  topic: session.topic,
  reason: getSdkError('USER_DISCONNECTED')
})

Working on updates to include a Service Strategy plugin for FCL

Waiting on the first publishing.

Updated with ServicePlugin and initial serviceStrategy. Initialization will now create services for any existing pairings.


Adding Behavior to Map Multiple Keys at Once

Coverage remained the same at 100.0% when pulling 6a2c9c21756931e75f1881df7fe359d2caa4ca99 on jimdelois:feature-batch-mapping into ea1ca2ed5a56db18354a596bd0ca6c26c346516c on improvframework:master.


Put wrapper sources in tmp on windows

Small behavioural regression from #282

As pointed out by @jneira I misread the code from here: https://github.com/haskell/hie-bios/blob/0213509d32f394ebe1c8a56a3b37597a45b151c1/src/HIE/Bios/Cradle.hs#L503


client, etcdserver: propagate status code of auth related error

Current v2 auth API doesn't propagate its error code. This commit let
the API propagate and allow client to judge the status.
Fixes https://github.com/coreos/etcd/issues/5894
/cc @bluepeppers @xiang90

@bluepeppers btw, this change adds IsAuthNotFound(), not IsRoleNotFound() because APIs related to auth and role share same error struct and both of not found cases use the error code 404. So clients need to judge what wasn't found by their context. I think it isn't critical, is this suitable for your use case?

Can we just compare the error message instead of comparing the status code?

@xiang90 it is possible but I think utilizing the status code in the struct would be simpler. Because the approach based on string parsing introduces a possibility that rules can match to newly added error messages in the future.

@xiang90 or do you mean exact matching of string error message?

yes. matching the exact error message.

@xiang90 I found the error message of v2 role get contains role name:
$ ETCDCTL_API=2 bin/etcdctl role get r1
auth: Role r1 does not exist.

regex matching is required. If regex is acceptable, I'll change this PR. How do you think?

@xiang90 ok, I'll try it and update this PR later.

@xiang90 updated for parsing error string. I used regexp matching because I felt using string matching and not distinguishing non existence of role and user is a little bit odd.

@xiang90 updated for regex compilation in init() func, PTAL

@xiang90 @bluepeppers updated for simplifying regexp compile in init(), PTAL

lgtm


Forward slash character in path incorrectly rejected on Windows

Summary
Nuitka is now checking for illegal characters in specified paths, such as (in my case) using the --include-data-dirs option. However, this checking is overly restrictive, and prevents Python's cross-platform / conversion.
I believe the simple fix would be to remove the / character from the list of illegal characters defined here. I am happy to make this change and submit a PR, but I didn't want to jump to that as I'm not currently near a Windows computer for testing and wasn't sure if there were other implications.
Minimal reproducable sample
The following works on Linux, but would fail on Windows (my apologies for the bash syntax in file creation):
touch app.py
mkdir -p resources/locale
touch resources/locale/app.po
nuitka app.py --onefile --include-data-dir=resources/locale=resources/locale

You can see the output from my GitHub action with the actual files here. The relevant error message is:
Nuitka-Options: Used command line options: --onefile --include-data-dir=resources/locale=resources/locale --include-data-files=resources/stitcher-icon.ico=resources/stitcher-icon.ico --include-package-data=pdf_mangler --output-file=pdfstitcher.exe --windows-console-mode=disable --windows-icon-from-ico=resources/stitcher-icon.ico --assume-yes-for-downloads --output-dir=build --script-name=pdfstitcher/gui/app.py
Nuitka: Starting Python compilation with Nuitka '2.4.4' on Python '3.8' commercial grade 'not installed'.
FATAL: Error, cannot add data file with 'resources/locale\babel.cfg' path, as 'contains illegal character '/''

Relevant template questions and answers

Nuitka version, full Python version, flavor, OS, etc. as output by this exact command.

python -m nuitka --version

I am running the Nuitka Action on GitHub's hosted windows-2019. I am unable to run this exact command, but the following information was printed as part of the run:
Collecting nuitka
Cloning https://github.com/Nuitka/Nuitka.git/ (to revision main) to c:\users\runneradmin\appdata\local\temp\pip-install-jhfm3g1f\nuitka_626ff6d1289c462f94118c5d7b75e9d4
Running command git clone --filter=blob:none --quiet https://github.com/Nuitka/Nuitka.git/ 'C:\Users\runneradmin\AppData\Local\Temp\pip-install-jhfm3g1f\nuitka_626ff6d1289c462f94118c5d7b75e9d4'
Running command git checkout -b main --track origin/main
branch 'main' set up to track 'origin/main'.
Switched to a new branch 'main'
Resolved https://github.com/Nuitka/Nuitka.git/ to commit c3b1c131c785553b582b362d5b1414d1000dff5d
Running command git submodule update --init --recursive -q
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'done'
Requirement already satisfied: ordered-set>=4.1.0 in c:\hostedtoolcache\windows\python\3.8.10\x64\lib\site-packages (from nuitka) (4.1.0)
Requirement already satisfied: zstandard>=0.15 in c:\hostedtoolcache\windows\python\3.8.10\x64\lib\site-packages (from nuitka) (0.20.0)
Building wheels for collected packages: nuitka
  Building wheel for nuitka (pyproject.toml): started
  Building wheel for nuitka (pyproject.toml): finished with status 'done'
  Created wheel for nuitka: filename=Nuitka-2.4.4-cp38-cp38-win_amd64.whl size=3401016 sha256=3e28c03ea9838c3fc3a44159bc668968459bb73af28331a64c9e4e9eef0db5aa
  Stored in directory: C:\Users\runneradmin\AppData\Local\Temp\pip-ephem-wheel-cache-ukr1kc2m\wheels\[71](https://github.com/cfcurtis/pdfstitcher/actions/runs/10167847381/job/28121117326#step:5:74)\9e\d0\f505e86d3117e0b9bf4d57c59df42f91ea732fb3980b600661
Successfully built nuitka
Installing collected packages: nuitka
Successfully installed nuitka-2.4.4

How did you install Nuitka and Python?
Using GitHub actions, specifically:
- name: Install Python
      uses: actions/setup-python@v5
      with:
        python-version: "3.8" # needs to be 3.8 to support Windows 7

- uses: Nuitka/Nuitka-Action@main
      with:
        nuitka-version: main

Note if this is a regression
Yes, this is a regression. The workflow successfully ran in June here

If you'd like to make a PR, then
normalizing the path would be the way to go

I am a git bash user myself and like the use of / to avoid quoting madness too. Also Windows normally just treats / in paths well in some places of Python, but not in the end.

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback on whether this is working is very welcome. Please do not share plans to do it; only confirm or deny that it is working.

Confirmed working on factory branch 2.5rc3!

This is part of the latest hotfix.


Pink video

I flashed a Wyze V3 with the latest Thingino and I get pink hues on the video. I saw there was a commit yesterday (https://github.com/themactep/thingino-firmware/commit/b88cb7262dd3667e816868cdd624a1362045fb6a) that changed the order of the ircut pins. I actually had to swap it back to
gpio_ircut=52 53
to get the image to look correct. I'm not sure if some Wyze V3 have them backwards or what.

thanks for the report, fixed in https://github.com/themactep/thingino-firmware/commit/8d17117c31b9889635cbc7b7451501253007a68f


Houssem dellai patch 1

I've added a link and image to youtube video demonstration (https://youtu.be/jeZCOqAvd0A).

Good to see some content around terratest, but unfortunately, we currently don't promote third party content on the terratest docs.

Good to see some content around terratest, but unfortunately, we currently don't promote third party content on the terratest docs.


Cannot drag advancements from a class in the Classes SRD compendium as a player

Steps to reproduce:

create a new Actor of the "character" type
create a new Class directly on the actor
give Owner permission to the actor to a player
login as the player
edit the class and switch to the Advancement tab
click on the locked icon to change to Configuration Enabled
open the Classes SRD compendium pack and then one of the classes (I tested with Druid but I don't think it matters)
switch to the Advancement tab and try and drag/drop one of the advancements (I used the 4th-level ASI) from the SRD class to the class on the actor

After following the steps, I cannot drag any of the advancements from the SRD actor to the sidebar actor. If I try the same steps when logged in as the GM, it works. Normally when I drag something I see what I dragged attached to the cursor to indicate that I started dragging something. I don't even see that when logged in as a player.

I tested w/ Foundry 11.313 and dnd5e 2.3.1

Probably because the default canDrag method checks to see if the item is editable.


uprev notify to 5.0.0-pre.16

ref https://github.com/notify-rs/notify/issues/249#issuecomment-1214363722

Add notify::Config as Confgi::default() to watcher initialization.
Also PollWatcher now has the default interface, as all watchers now take a Config (with only the pollwatcher config), thus enabling one config for all possible backends.
(And if you want the debouncer, as the only way to enable some features on init.)

Add notify::Config as Config::default() to watcher initialization. Also PollWatcher now has the default interface, as all watchers now take a Config (with only the pollwatcher config settings currently), thus enabling one config for all possible backends.
(And if you want the debouncer, as the only way to enable some features on init.)

Thanks, done I think.
Config::new(delay, compare_contents) would be much more use friendly than Config::default().with_poll_interval(delay), would you consider adding new()?

The idea was to allow extending this in the future. Your idea would break semver if I'd add more settings.

Ye I see that, rust's lack of default/optional/keyword arguments bites again.

You can actually do
Config {
delay: 1,
..default()
}

But that's cumbersome and doesn't require (AFAIK) you to actually do the default call, so would break semver. (I've got the feeling I'm missing some better option.)

You can actually do

Yes, I thought about exactly that, but if you do
let config = Config {
    poll_interval: delay,
    compare_contents: whatever,
    ...Default::default(),
};

(adding the ...Default::default() so new fields don't break the code)
I think clippy would complain that ...Default::default() can be removed.


Reset undo history when opening a file

Currently, because of first time initialization of a buffer with nvim_buf_set_lines it creates an undo point

:help clear-undo


"directed" parameter is not working

Setting directed equals True or False results in the arrowheads being showed in the graph.

`import streamlit as st
from streamlit_agraph import agraph, Node, Edge, Config
st.title('Opa')
nodes = []
edges = []
nodes.append(Node(id="A1",
size=5)
) # includes **kwargs
nodes.append( Node(id="A2",
size=5)
)
edges.append( Edge(source="A1",
label="",
target="A2",
type="-"
# **kwargs
)
)
config = Config(directed=False,
width=1000,
height=1000,
# **kwargs
)
return_value = agraph(nodes=nodes,
edges=edges,
config=config,
)`
Results on that

The result should be a line without the arrowhead

Hey @ViniciusgCaetano ,
did you figure it out yet? Actually it took me a few secs to figure it out myself.
The solution is actually quite simple. Just pass edges configs to the config with "arrows":"none".
config = Config(width=750, height=750, edges={"arrows":"none"} )

If it solves your problem, feel free to close the issue.


YouTube Audio Quality - Removed or Bug?

I sometimes save the audio version (M4A) of some YouTube videos as they work just as fine as the MP3 (without the hassle of converting them).
But I've noticed that the M4A with the highest bitrate 256 kbps is gone.
If I'm not mistaken the itag of the 256 kbps M4A was 141, but I can't find the 256 kbps version on any videos.
Has YouTube dropped the support for this format or is this a bug with youtube-dl?

>youtube-dl http://www.youtube.com/watch?v=a9LDPn-MO4I -F
[youtube] a9LDPn-MO4I: Downloading webpage
[youtube] a9LDPn-MO4I: Downloading video info webpage
[youtube] a9LDPn-MO4I: Extracting video information
[youtube] a9LDPn-MO4I: Downloading MPD manifest
[youtube] a9LDPn-MO4I: Marking watched
[info] Available formats for a9LDPn-MO4I:
format code  extension  resolution note
...
141          m4a        audio only DASH audio  274k , m4a_dash container, mp4a.40.2@256k (44100Hz), 1.83MiB
...

Sure, that video has the format available, but it's a rare video.
Try it on a few music videos and you'll see that none of them have 141 available.

Post an example URL.

Take Gangnam Style for example: https://www.youtube.com/watch?v=9bZkp7q19f0
It's the same thing for all other music videos, try it yourself.
Also, please open the issue again, because there's something wrong/missing with either YouTube or youtube-dl.

YouTube player itself uses 137+140 and 248+251 for this video. There may be some additional formats in mpd manifest but there is no known way to fetch manifests with ciphered signature.

Ah, that's interesting!
Do you mind sharing how you find out which audio formats YouTube's player uses?
Also, do you know where to find the URL to the ciphered manifest?
I might be able to find a solution which I can share with the community.

Right click on player, statistics for sysadmins.
Here.

Right, I never noticed that it showed the itags.
I'll take a look at the manifests.
There must be a way to decipher them.
Also, do you have any info on how the audio WebMs work?
My theory is that they might be the same quality as the 256 kbps M4A, but instead of having a constant bitrate it's a varying bitrate which gives an optimal file size and at the same time the same audio quality as 256 kbps M4A.

This is very possible.

This sudden audio quality drop happened for me suddenly about 3 days ago, from the highest m4a bitrate being 253 kbps to 125 kbps. Note that for many of these 125 kbps tracks, they are also the highest quality audio available, so there's doesn't appear to be a webm equivalent of the old 253 kbps m4a versions. I have several dozen examples if you want them.


Configure optional properties for kubernetes membership scheme that are supported by hazelcast

Describe the issue:
It should be possible to configure the other properties that hazelcast supports[1], currently, we only have the option to configure namespace, service-name, and service-port[2]
config.getNetworkConfig().getJoin().getMulticastConfig().setEnabled(false);
config.getNetworkConfig().getJoin().getKubernetesConfig().setEnabled(true)
.setProperty("customproperty", "custompropertyvalue")
In previous versions of Identity server with the previous implementation of the kubernetes membership scheme properties such as KUBERNETES_API_SERVER, KUBERNETES_SERVICE_HOST etc were configurable however after the upgrade these properties cannot be configured.
The default implemenation of hazelcast which is being used in newer versions of the identity server seems to have these properties[2] however they are not configurable because only a fixed set of properties are read[2].
Need to provide a way to configure the properties that are supported by hazelcast[1] and update the documentation[3]
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [6.1.0]

[1]https://docs.hazelcast.com/hazelcast/5.3/kubernetes/kubernetes-auto-discovery#:~:text=There are several properties to configure%2C all of which are optional.
[2]https://github.com/wso2/carbon-kernel/blob/4.9.x/core/org.wso2.carbon.hazelcast/src/main/java/org/wso2/carbon/hazelcast/kubernetes/KubernetesMembershipScheme.java#L83-L91
[3]https://is.docs.wso2.com/en/6.1.0/deploy/deployment-guide/#clustering-related-configurations:~:text=Optionally%2C a Kubernetes token or basic authentication can be used to authenticate with the Kubernetes api server. The following properties can be set under [clustering.properties] accordingly.

Any optional property that is mentioned in https://docs.hazelcast.com/hazelcast/5.3/kubernetes/kubernetes-auto-discovery#:~:text=There are several properties to configure%2C all of which are optional should be configurable.

This is addressed in following PR.

https://github.com/wso2/carbon-kernel/pull/3993


CASSANDRA-16640 added five new unit test for standard commands that were not previous…

…ly covered
Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:
<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@bschoening I was doing some code greping and ran across this PR... I'm unclear, is this still relevant or should this be closed as well?


Initial commit for plotting functionality clean-up

<Please replace this paragraph by a description of what this PR does and alter the TODO-list below to what applies here. Please make a 'draft PR' to begin and then only mark it as ready for review once all the relevant points are done.>

[x] Tests added
[x] Documentation added
[x] Example added (in the documentation, to an existing notebook, or in a new notebook)
[ ] Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/benmsanderson/METEOR/pull/XX>`_) Added feature which does something)

Since this is pre-alpha I'm not bothering with changelogs yet. Also, initially thought I would add the CMIP6-download functionality in this one, but it's cleaner to do the plotting move in one, and then do another one for the CMIP6-download, but I'd prefer to keep the branch around for that PR as well, so don't delete the branch.

Notebook is runnning fine, but I'm getting errors on testing after clean install, python3.9:
File "/Users/sanderson/code/METEOR/venv/lib/python3.9/site-packages/pluggy/_manager.py", line 342, in _verify_hook
raise PluginValidationError(
pluggy._manager.PluginValidationError: Plugin 'nbval' for hook 'pytest_collect_file'
hookimpl definition: pytest_collect_file(path, parent)
Argument(s) {'path'} are declared in the hookimpl but can not be found in the hookspec
make: *** [test] Error 1


chore(deps): update common-dev-assets digest to 588b0ac

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
32674f3 -> 588b0ac

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SQL server sample dbs and code samples

I am trying to get access to code examples and sample databases for Sql Server 2014. I cannot find what I am looking for. Any help or guidance will be appreciated.
Thanks in advance,
RK42
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3caf351-18c6-5211-f2a2-bbdef5918629
Version Independent ID: f13ef5fe-c17a-ecd1-2a2b-55b3b101da07
Content: .NET samples and tutorials
Content Source: docs/samples-and-tutorials/index.md
Product: dotnet
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@roadkill42 Here are some sample databases: https://github.com/Microsoft/sql-server-samples/releases/tag/adventureworks

Got them and thanks.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Genevieve<EMAIL_ADDRESS>Sent: Thursday, February 11, 2021 10:51 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [dotnet/docs] SQL server sample dbs and code samples (#22644)
Closed #22644https://github.com/dotnet/docs/issues/22644.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/docs/issues/22644#event-4320897987, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZENCNNQSAYC7MPEMKQWUDS6QDKDANCNFSM4XB3HGSQ.


[Suggestion] Allow updating the IRC token so Conn uses a valid token at Reconnect

Auth tokens can expires as early as 4 hours after their creation. So reconnecting the IRC client after a few hours is doom to fail unless you can programmatically update the token in Conn to a recently refreshed token.
https://github.com/Adeithe/go-twitch/blob/e09217ee922080aa2837c172e8a804c2ed5b6978/irc/conn.go#L16-L20
So it may be a good idea to either:

Allow SetLogin to set the credentials even if there's an existing connection, knowing that this new credentials would only be used until a reconnect happens
Or add a new function like SetLoginForReconnect(username, token string) to make it more explicit 🤷♀

Btw congrats on the new Release 🎉

Authorization tokens generated via the implicit grant flow generally don't expire and are best suited when running a bot. You can put together the link for this yourself or log in using TwitchApps TMI and grab the token from there if you'd rather skip building the link.

They are, and in real production application you will never use implicit flow, because you want your tokens up to date. So, that issue is correct, and IMO it should be done somehow.
I'd like to suggest introduce some function with callback, GetOauthToken, for example, which will be called for getting token on initial connection, and on reconnections.
Otherwise when reconnection happening and token is expired - bot crashing,

Also for example https://github.com/gempir/go-twitch-irc just throwing error on client.Connect() function, and you can do infinity loop with getting token inside of.
I'm not like that way and leaning to callback way.

@sainoba do you somehow fixed this?
I mean i need example for proper reconnect with new token, because my production application already lost chat connection because of token expiration.


Support for third-party generator blueprints

I actually have no experience with this feature on Ember, but I see that ember-cli has it and I think would be a great boon to angular-cli: the ability for the user to generate code from their own blueprints, or to use third party ones installed via npm. I guess this could be part of the "add-ons" functionality I've heard rumors about. ;)
Example use cases would be generating routes for UI-Router, generating stores for ngrx or Redux, generating GraphQL endpoints for use with angular2-apollo, generating style guides or other kinds of documentation, and on and on - the imagination of the GitHub community would be the limit. :)
Note: I realize Yeoman can already accommodate some use cases, but it's not really designed to deal with existing projects, it can't use/extend the angular-cli API, and in all likelihood anyone using angular-cli won't give it a second look.

This is on our radar for the addon system actually.

@filipesilva awesome, glad to hear it. :)

I'd like to add support for routing with ui-router-ng2.  What are the current ideas for how third party support might be implemented?

Heya @christopherthielen! There isn't a public plan available for third party blueprints yet. It's mostly a post 1.0 concern at the moment.
I think the best you can do currently is provide some instructions on how to modify a newly generated project to use ui-router-ng2. Let me know if you have any trouble doing it.

Any news on this matter?
Is it being actively worked on or still in the drawer?

Support for custom blueprints was added in https://github.com/angular/angular-cli/pull/7090, available in 1.4.0-beta.1 and up. It's based on @angular-devkit/schematics: https://github.com/angular/devkit/tree/master/packages/schematics/angular.
We don't yet have documentation and examples of how you can make your own but @Brocco is working on it.

Any schedule you might be working on for the release of a stable 1.4.0 version? Perhaps within the next 30 days? Just curious.
Thanks! 😃

@CesarD yeah most likely. It's in rc.2 right now so it shouldn't take long at all.

Hi is there any further news on this? I would love to be able to automate my new components being added to my router and also to set some defaults to my generated constructors, I would also like every component to be able to utilize my main stylesheet.

Support for custom blueprints was added in #7090 , available in 1.4.0-beta.1 and up. It's based on @angular-devkit/schematics : https://github.com/angular/devkit/tree/master/packages/schematics/angular .

Documentation on how to use it? Anywhere?????

Yeah plz.


Add a fully loaded RViz

We can also breakaway from the dependency that we have for RViz in nav2_bringup

done!


Reference Images for Forced Photometry

Loving this program, it's very helpful, and I'm using it now with great pleasure.
Given the fact that this is forced photometry I'm wondering if is possible to see a reference image to make sure that you are properly locked onto the star. The reason I say this is because I'm currently working on a star that depending on the catalogue is located at xx:xx:xx.xx -xx:xx:xx.5 or xx:xx:xx.xx -xx:xx:xx.6 (i.e. a 100 mas difference) makes a small, but significant, difference in the light curve (see attached).
This is the Dec=X.5
dec=x.5.pdf
This is the Dec=X.6
dec=x.6.pdf
Specifically of interest is the dip at MJD~59000, where though visible in both files, the Dec=X.6 one shows the dip in both filters, where as Dec=X.5 shows it only in the o filter. It would be nice to validate that you've selected the right location, by seeing an ATLAS postcard (be it 250x250 pixels or something like this... enough that it works as a finder chart) with a cross at the specified location.
Kind regards,
Dirk

Hi Dirk. Thanks for the feedback. I agree that this feature would be a nice addition, but might not be so straightforward for me to implement on my own (I handle the web interface part). I'll discuss it with @genghisken and see if we can get it added in at some point.

@dmvandam, I've added new image request buttons that will provide a ZIP file constaing FITS images and JPEGs for the first 500 exposures in the forced photometry results. If you get a chance to try it out, please let me know if this is helps to resolve your targeting problem.

@lukeshingles this is fantastic, this is great and works really well. Really nice feature that you've included the ability to download the images on an old query. I'm really happy with the addition and how quickly you were able to pick this up!


Delete unused code.

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

Codecov Report

Merging #4178 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   26.82%   26.77%   -0.05%
==========================================
  Files        1163     1163
  Lines       25428    25426       -2
  Branches     3691     3691
==========================================
- Hits         6820     6807      -13
- Misses      18000    18013      +13
+ Partials      608      606       -2

Impacted Files
Coverage Δ

.../java/org/apache/skywalking/oal/rt/OALRuntime.java
0% <ø> (ø)
:arrow_up:

.../core/remote/ServiceAndEndpointRegisterClient.java
31.46% <0%> (-13.49%)
:arrow_down:

...walking/apm/agent/core/context/TracingContext.java
58.2% <0%> (-0.5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b15e6...ac9ffa5. Read the comment docs.


python3Packages.mlxtend: fix tests

Description of changes

Updated the pytest configuration & added missing dependencies to fix the mlxtend build.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 217278 run on x86_64-linux 1

1 package failed to build:

python310Packages.mlxtend

Thanks, fixed.

Hey, uh, any updates on this PR?

I have no use for mlxtend currenty, so I can't really test/proceed. Feel free to pick it up.

Tried to pick it up but tensorflow errored out.


Use MutationObserver to picturefill img elements as they are inserted

Instead of running picturefill in a timer, we could use MutationObserver (if supported) and picturefill an img element when it is inserted to the document. This would maybe have less overhead and less lag, and also work post-onload.
Relatedly, it might be good to implement http://www.whatwg.org/specs/web-apps/current-work/multipage/embedded-content.html#relevant-mutations which also needs MutationObserver (could fall back to mutation events).

Ping @aFarkas to see if, a) this made it into 3.0 or 2.4, or b) a different approach was decided upon. I didn't see any MutationObserver stuff in 3.0, but I was only skimming.

It is here:
https://github.com/scottjehl/picturefill/blob/afarkas-pf3-proposal/src/plugins/mutation/pf.mutation.js
It also adds some IDL attributes and makes fun:
img.srcset = 'data:,a 300w, data:,b 600w';


[5.7] Updates vue preset to use latest stable build.

This pull request updates the version of vue to 2.6.7 (latest stable version) in the Vue preset command. I've also explicitly added the 'vue-template-compiler' => '2.6.7' package to prevent vue and vue-template-compiler version compatibility errors when compiling assets after using this preset.

Laravel Mix should auto install the vue-template-compiler package automatically.
https://github.com/JeffreyWay/laravel-mix/blob/c3d0ffd653343e65dd68466822a9919c803f12ad/src/components/Vue.js#L10

Has conflicts. Please re-submit.

Laravel Mix should auto install the vue-template-compiler package automatically.
https://github.com/JeffreyWay/laravel-mix/blob/c3d0ffd653343e65dd68466822a9919c803f12ad/src/components/Vue.js#L10
The caret ^ sign in version scheme already allows npm to install latest version

Its weird that even after running npm update on my app that it didn't update my vue version at all (I was looking forward to the new slotProps syntax). And when I manually updated vue version from my package.json file I received an error with vue-template-compiler not being compatible. Hmm..


URL::previous sometimes returns undesirable URLs

Laravel Version: 5.5
PHP Version: 7

Description:
Sometimes URL::previous returns me unexpected and highly undesirable things like favicon.ico or random nonexisting URLs. This seems to happen because StartSession is happy to invoke storeCurrentUrl before learning content type of response and even before finding out whether it succeeded or not.
This behavior is non-intuitive and makes that method largely useless (because I can not control order of HTTP requests, made by browser). I'd like URL::previous to return only URLs, associated with successfull requests to proper routes.
Steps To Reproduce:
Not clear yet.
For now I am going to use an additional Middleware, that wil check content type and error code of response after everything else finishes processing.

Why do you execute the StartSession middleware for non-dynamic requests, like the favicon?

Please ask on the forums, this repo is for bug reporting only. You can use https://laracasts.com/discuss or https://laravel.io/forum which are forums with a very large community of developers helping each other.


Update link to design principles

The document had moved from the kubernetes/kubernetes repo to kubernetes/community but this link had yet to be updated.
Thanks!

This change is

Thanks much, @gilesvangruisen. Please sign the CLA so that this can be merged.

@gilesvangruisen: Ping on CLA.

Also, the doc has moved to:
https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/concepts/overview/what-is-kubernetes.md

@gilesvangruisen Please sign the CLA when you get a chance. Also, /docs/whatisk8s.md has moved to /docs/concepts/overview/what-is-kubernetes.md, so please apply your changes there. Thx

@gilesvangruisen Thanks for the contribution. I'm going to apply these changes to docs/concepts/overview/what-is-kubernetes.md. Cheers


Fails on Dailymotion

youtube-dl 'http://www.dailymotion.com/video/x6wzpl_50-ans-de-l-ihes-marc-chemillier_tech'

Fails with the following message:
ERROR: unable to extract title

Which youtube-dl version are you using? This works fine for me (from Germany) with youtube-dl 2012.02.26.

You're right: it works with the latest Git version.


Missed icons

There is no icons in sidebar and top panel after update from 20.06.16.

is "custom.work.useIconsOfCustomWork": true

It was false, my bad. Thank you.


Regression: Creator & Project fields no longer set for new tickets

We have a couple of Zaps  - One that sends a message to chat when a new ticket is created, and another that sends one when a ticket is updated.
During a previous update to the Zapier integration, we lost the "Creator" and "Project" fields for new ticket notifications; they're always blank now, including when the sample data is fetched during Zap setup:

I can't see any other fields that contain the same data; perhaps i'm missing something?

We have the same issue, we need the project name to sync Issues with Clockify using Zapier.


Server side rendering, defining fallback HTMLElement and HTMLSelectEl…

…ement
Changes filter/dateFilter to allow server side rendering...

I'll add these declarations in a future release. I'll add them to our TS files so I wont accept the PR as it stands, but thank you for raising this.
As I say, it will be in the available next release of ag-grid

Ag grid currently still don't support SSR right?

Same question, just confirming the SSR is not yet supported, correct?


Add rate limit restriction

Would be great to add an option to use rate limiter to avoid ip block for a lot of API requests. Just a thought.

OK, thanks. I will keep that in mind for the next versions.


Feature Request: Add ability to search only on new tracker when tracker is added

Requesting for the ability to search all torrents on a new tracker when a new tracker is added in the config. I think it would be best to also have it set as a boolean in the config.
This way when we join a new tracker we can start cross-seeding much easier. Currently, when I join a new tracker, I just delete the .db file and let it search all trackers when I add a new one. But with this feature we can greatly reduce the load put on the trackers and potentially decrease the search time.

this is already supported in v4.4. Just add the tracker and turn down excludeRecentSearch


pythonPackages.pyvmomi: init at <IP_ADDRESS>8.12

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build python2Packages.pyvmomi python3Packages.pyvmomi

Build for me on Linux 5.0.0-27-generic #28-Ubuntu SMP x86_64 GNU/Linux.
Result of nix-review pr 68109 1

2 packages were built:

python27Packages.pyvmomi
python37Packages.pyvmomi

@peterhoeg @wd15 thanks!


Correct common path

I noticed this link doesn't work and I believe this should fix it.

Super, thanks - those relative links are tricksy!

Thank you!


Added Memory Matching Game

PR Description 📜
Added New Game That is Memory Matching Game which is very fun to play
Fixes #4467

Mark the task you have completed ✅

[ ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ ] I have performed a self-review of my own code or work.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you @Saipradyumnagoud ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43  Can you please review the pull request so that I can work on the another pull request

@kunjgit please review the pull request it is ready for merge
can you please review it soon so that i can work on the another issues in your repo

Thank you  @Saipradyumnagoud , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Tag old version

For BC and as @kelunik is bringing a totally new approach to be used in this library, create a tag for the latest version before these changes, I guess, up to this commit: https://github.com/amphp/injector/commit/378753e1a8afc83791d7a5a182b213bb72640bfd
This is especially important for those who wish to keep using the PHP 8 version of auryn as well as those who see that it's deprecated and forwarded to this library.

Please keep using rdlowrey/auryn for the old version. It won't be tagged in this repository.


community: fix roles search filter

Requires https://github.com/inveniosoftware/invenio-communities/pull/662


Get data out mock data from Magento GraphQL response.

Was trying out the reference project and setup on Adobe IO Runtime.
I have following Raw json response from Magento GraphQl, similarly I want it from Adobe IO endpoint.
How we use it in place of already existing RAW  JSON ?
{
"data": {
"products": {
"items": [
{
"__typename": "ConfigurableProduct",
"id": 278,
"color": null,
"sku": "SKUID01",
"name": "Mountain Kit",
"description": {
"html": "Description"
}
]
}
}
}

Hello. Well I'm not quite sure what you want to do: if you already have Magento, then you don't need to do any 3rd-party integration unless you want to customise responses or just want to see how it works.
The mock responses are currently "hard-coded" at https://github.com/adobe/commerce-cif-graphql-integration-reference/blob/master/src/common/ProductsLoader.js#L62-L135 for different search options. In a real integration, this entire method would be replaced by some (REST or GraphQL) calls to the e-commerce platform.
I'm still not so sure what exactly you want to do with your Magento response. Do you want to return this response in the Adobe I/O integration?

Thanks @cjelger, Got it!
Just wanted to customize the response coming from Magento in Reference project. I am able to do it now using Catalog.js.
Awesome customization!

ok good. Please close this issue if your problem is solved.


Lots of suggestions!

I LOVE your mod, I can't play without it and I would like to make some suggestions inspired on other mods that I think would fit very well with your take. I'm just brainstorming so take my approaches with all the salt you need. Here are some of them:
Undead category.

Every adult and baby zombie: They know how to climb ladders and also will properly hide from the sun, waiting for the next moon.

Every baby zombie: Their playfully evil nature would make them steal the items the player is holding.

Zombies:

Now, they have different AIs, giving them more personality: they are slower, but will always gain a speed boost if they burn and if Fabric/Forge: Zombie Horse Spawn is installed. Also, brainless zombies now can spawn as neutral who will wander around aimlessly.
Their lust of blood let heal themselves on a succesful attack to the player, on the same proportion the damage they deal. Also, they have natural knockback resistance.
Zombie siege ones will try to reach their target, destroying any wooded door/fence gate in their path.

Baby zombies:

The most unpopular mob now will pounce to their targets, like spiders, because of their size and will try to "parkour", jumping blocks to reach you. And so, they have a reduced knockback resistance.

Baby drowned:

They will have the chance to spawn as a guardian jockey.

Adult husks:

Masters of the cursed sands, they have a chance to bury the player on a sand block, making them collapse underground. Or optionally, they surround the player with sand columns, instead of pulling.
In an ideal situation, they would remove the 3x3x3 blocks below the player, leaving the 3x1x3 sand blocks around the player is standing on, making a hole on the ground to be impossible for the player to escape. This wouldn't work for a layer below Y<48.

Zombie villagers:

They show their grudge to the living targeting every animal and every crop (except beetroots because no one cares about them lol, giving them an actual advantage). If they attack a horse, it will transform to a zombie horse. And if they land a succesful attack on the player, they will give the Bad Omen effect.

Zombified piglins:

Rarely, if a player enters in their nearby area (2, 3 blocks away) they will absolutely berserk.
In the overworld, they will haunt pigs aggressively to transform them into one of their kind. Their ultimate purpose will be to destroy their natural enemies: pillagers and villagers, transforming the latter into their zombie variation.
In the same line of villagers, now they can be dezombified but with a golden carrot.

Skeletons:

They can follow you underwater, because why they wouldn't?
Normal skeletons have a low probability of carrying glow arrows with them, ensuring every other enemy knows you are there.
Spider jockeys have an increased chance to appear and will bring instant damage tipped arrows with them, prioritizing the needs of their undead allies if their health is too low.
The dreadful skeleton horseman which appear during a thunderstorm are now faster and will occasionally shoot thunder arrows at you, having no place to you to hide.
NEW: Baby skeleton: normal skeletons with normal arrows. They shoot quick volleys at you, reducing the charge between shots at the price of less accuracy. Oh, and they have a chance of spawn as bat jockeys.

Wither skeletons:

Every skeleton who reach the nether will transform to a wither skeleton.
Demons incarnated, now they are fire resistant and hold netherite swords. Run.

Arthropods

Every arthropod: No damage from falling and aggro for every fleshy villager.

Every larvae: They're twice as fast.

Spiders: nothing at all. You made them perfect <3

Cave spiders:

Ancient workers died because they couldn't escape from these horrifying bugs, giving them poison, weakness, nausea and mining fatigue. Deeper means deadlier.

Silverfish:

They plagued the underground and now live everywhere. Watch out yourself.
If by any mean they reach The End, they will addopt their endermite cousin appereance.

Endermites:

They will appear in chorus trees forest; this chance is increased if you break infested chorus trees, which will fall from them.
Having sucked chorus fruits since eternity, now they have the power to teleport you at a random near location.
And least and most important, if they manage to stand on a purpur variant block for a moment, they will grow from their larva stage to an indefinite Shulker pupa.

 And don't think to try it while they're closed, they will take no damage.

Slimes:

Every slime:

Their chunky bodies will negate fall damage and reflect projectiles.
The bigger they are, the slower but stronger, and viceversa.

Slimes:

Depending on their size, they will fling the player away on hit.
Their mucus will inflict slowness, stacking this effect with every hit. Nasty.
Dealing damage with you weapon have the chance that it will stack on their body. Killing them will return your item back.
They will absorb magma blocks to transform to their nether variant.

Magma blocks:

Made of magma, they will ignite the player on contact.
Biggest ones will melt every stone block where they land, turning them to a magma block.
When killed, they will spread a small amount of lava.
They will cool down if they land on a slime block or fall in water, returning them to their regular form.

Ghost-like:

Every ghost-like: Because of their incorporeal body, they're immune to mundane weapons. Enchanted weapons will be the only way to inflict them damage.

Phantoms:

Coming from the above dimension, their natural home is located in The End. They're nests are located in end cities, where they spawn more frequently.

Vexes:

They wander in the dark... I mean, the dark forest.
These tricksters inflict darkness on hit to steal your gear.
Fortunately, invocated vexes will with their evoker master.

I will continue if you like to hear more from my ideas. Thank you so much! <3

Wohhh! That's a lot, you didn't lie 😆
I love your ideas, all of them. I'm not gonna lie too, it's going to take some time but I will definitely add them. I'm going to start very soon, but first I may split some in order to keep track of what I'm doing and where I'm going. We can totatlly talk about more ideas if you have, don't hesitate to join my Discord to talk about it with me and maybe some other members 😉
But with all of those changes, I guess I will need to rework again the configs and offer some config presets to be less a pain to set up ^^

Many suggestions were added to v1.7 and some other may come in the next update but as you're written down those suggestions on the discord server, I will close the issue there and make some other in the future with features I may add later =)


Make QueryGET() and FmtQueryGET() send GET instead of POST

I found this issue when using EpochCommittees() which should send a GET but was sending a POST because of the misleading FmtQueryGET() helper function.
I have not checked whether any functions that should be sending POSTs were using those two functions and will be broken after this patch.


Initial board saves its size like SZ[19:19]

If you open Sabaki, maybe play a few moves, and save, the file will have its size saved in the long format, e.g. SZ[19:19]. This doesn't happen if you ever select "New".
For compatibility with older SGF editors, it would be better not to save the long format where possible.
Update: I think I can fix this actually... it's very minor changes to sabaki.getEmptyGameTree:
let sizeProperty = size[0] + (size.length > 1 ? ':' + size.slice(-1)[0] : '')

And then use that inside the template...
`SZ[${sizeProperty}]`,

If you agree, I can make a pull request if you wish, but it's a simple enough change we could avoid it...

Yeah, I came across this during my preact rewrite and fixed it there already.


python3 compat; pep8 linting

Using Python 3.5.1 so had to change all print functions to use parens and import print_function from future.   Should at least allow you to install now w/ python3.  Also ran a linter on the files I edited for PEP8.

You are correct in that with your change the code will compile; however, this alone will not work.
Python3 changed the semantics of division. All of the integer division operations need to be changed from "/" to "//".

Good call.  Running the tool 2to3 on everything should catch those sort of things and potentially other issues.

I tried that, actually; however, 2to3 doesn't properly catch the division issue.
I've started working on a port on my fork of this repo. It seems to work; however, I cannot find any test cases so I cannot be certain it's 100% working.
Maybe if I get some time tonight I'll test it by running the set of examples.

Just spent a bit of time on this. In the main body of code getting things python 3 happy are pretty straightforward: stuff that 2to3 catches, plus a few integer division bits. The more complex issues are in sound.py, which does a lot of work to provide wrappers for scikit.audiolab functions if the latter is missing. Quite a bit of this is using strings as bytes, which has changed under python 3 (but is easily updated).
However, the fallback wav code was extremely slow for me (~10 m to write a 1m wav file!), and it doesn't seem as if the audiolabs stuff has much prospect of ever being py3 compatible. What I've done on my local repo is rewrite the sound.py functions with pysoundfile instead, which seems to work (although I'm not yet sure if I haven't broken anything else in the process).


Bug: aliasConfig not available immediately

After an alias is successfully added, the . ~/.bash_aliases does not execute in the script as expected, and so the user must execute . ~/.bash_aliases manually.

Could incorporate shell.js to replace the asynchronous shell execution commands.


Online

After installing the plugin "TCPShield" online players stopped showing on my site, how can I fix this problem? Sorry for bad english, i use google translate :)

This is most likely because you haven't finished your configuration. Please follow our checklist on our docs.
https://docs.tcpshield.com/troubleshooting/setup-checklist

This is most likely because you haven't finished your configuration. Please follow our checklist on our docs.
https://docs.tcpshield.com/troubleshooting/setup-checklist

I think everything is set up correctly:

Blocks direct IP connections
I can log into the server only by domain
The game shows the number of players
The number of players is not displayed, only on my personal site

I think everything is set up correctly:

Blocks direct IP connections
I can log into the server only by domain
The game shows the number of players
The number of players is not displayed, only on my personal site

@Ev1LOFF Our discord is better suited for these conversations. Feel free to open a ticket in there and we can discuss.
This is a hard to cover because it can be so many variables. My only tip is just make sure your implementation of the minecraft protocol is entirely accurate.

@Ev1LOFF Our discord is better suited for these conversations. Feel free to open a ticket in there and we can discuss.
This is a hard to cover because it can be so many variables. My only tip is just make sure your implementation of the minecraft protocol is entirely accurate.


Incorrect downlevel emit or missing compiler error when unconditionally calling super() inside a branch with useDefineForClassFields enabled

Bug Report
The TypeScript compiler accepts the following code, which behaves incorrectly at runtime when --useDefineForClassFields is enabled:
class Base { }

class Derived extends Base {
    private _p: string | undefined;

    constructor() {
        (1 + 2 === 3) ? super() : super();
    }
}

var d = new Derived();

When the target is ES2021, this emits as:
"use strict";
class Base {
}
class Derived extends Base {
    constructor() {
        Object.defineProperty(this, "_p", {
            enumerable: true,
            configurable: true,
            writable: true,
            value: void 0
        });
        (1 + 2 === 3) ? super() : super();
    }
}
var d = new Derived();

Since there is a call to Object.defineProperty that reads this before the super() call, the line var d = new Derived() throws an exception at runtime. On Chrome M93, the exception message is:

ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor

If the super() call was not inside a ternary / if-else, it would have been emitted before the Object.defineProperty call. If --useDefineForClassFields was not enabled, there would be no Object.defineProperty call, so there would be no error at runtime. This issue seems like it might be related to #45377.
🔎 Search Terms
"useDefineForClassFields", "super"
🕗 Version & Regression Information
This is the behavior in every version I tried (back to 3.7.5, where --useDefineForClassFields was introduced), and I reviewed the FAQ for entries about class fields and super.
⏯ Playground Link
Playground link with relevant code (v4.4.2, with target ES2021 and --useDefineForClassFields enabled)
💻 Code
(see above)
🙁 Actual behavior
The downleveled JavaScript code throws an error when constructing an instance of Derived.
🙂 Expected behavior
Either:

The TypeScript compiler rejects the code for not having an unconditional not-inside-a-branch call to super() at the start of the constructor for Derived
Or, the code is downleveled such that the inside-a-branch super() call appears before the Object.defineProperty call and hence is correct at runtime.

I'm getting this same exact error. I don't really know what to do.


JavaScript syntax highlighter mistakes

From @qifeng0748 on May 19, 2016 3:53

VSCode Version: 1.1.1

OS Version: Windows10 x64 10586.318

This example, wrong.

Remove new, right.

Add (), right.

Copied from original issue: Microsoft/vscode#6515

Fixed by #257


As a user with inactive clients, I want to be able to delete such clients permanently so that I can remove them from my database and free up space.

fixed in #118


JSON Format pre-commit hook

Describe your changes
Add pre-commit hook for json format linter.
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Lint and apply fixes to your code by running lintrunner -a
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
[ ] Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

/azp run


Phaser demo is lose file

Can you provide some Creature file from json for Phaser v2.6
now can not running

Hello,
You can grab a sample JSON file here:
http://creature.kestrelmoon.com/Ue4_export.zip
Cheers

Thanks


fix(HLS): Fix variant synchronization in HLS after selectVariantTrack

Fixes https://github.com/shaka-project/shaka-player/issues/5849

Hi. This magic number has been touched upon in changes quite recently. Will returning a smaller value cause problems?
From what I understand in the code, the adaptation variable needs to be true until segment from new variant not appended with appendBuffer. Currently this variable can be reset after appendBuffer for the currently selected variant

Yes, I had other streams who have the same problem. This change is safe.


Add compileMustacheDirCustom

adds compileMustacheDirCustom which allows arbitrary extension names for those who don't like to type out .mustache

Bumps Stackage version to 9.5 & MegaParsec to 6.1.1 (Bugfixes only)

By the by, it seems your travis checks are borked.

Please note that current master passes the tests.

I made the requested changes, will investigate the CI and more thoroughly check everything tomorrow.

It is now passing CI, and two minor descriptions have been altered to be more accurate.
If you have anything else you would like to see then let me know.

Thank you, with minor corrections I have applied your work as 2a6f8384afc0c74a89636f4766ee814aa2582850.


Add support for Priority in Configuration Methods

Hi,
This is a feature that we have been asked by many of our users for years now. And I thought that it might be easier to create a pull request to start the discussion. The code is not ready and lacking allot of test. I just wanted to push a draft that shows that it is possible without to much effort.
Priority on configuration methods is something our users have requested from us for long time, today many of our user control the order by the naming of the methods, but I think it would be much nicer to to reuse the support that already exists in TestNg for Test Methods and I can not see any problem of adding such functionality. Many of our users can have over 50 before/after methods and adding dependency between them make it very complicated to maintain. much easier if the users can group the methods with different priorities.
What is your opinion about adding Priority support for Configuration Methods, if you are ok I will continue with this PR.
I expect it to work in similar way as for Test Annotation.
I tried to bring this up in the forum many years ago, but did not get much response. So I will try here instead.
https://groups.google.com/g/testng-dev/c/qSZFOYRWHkY/m/JzcswgrnAAAJ

Hi, I'm not sure if I understand your concern. In my test I don't see that behavior that you mention.
Are you sure the priority is on suite level, because if that was the case I guess my test would have a totally different behavior.
The only problem I have is to get my unit test working when I add the test to "testng-core/src/test/resources/testng.xml"
Then I get a different behavior when I run the test with "gradle build" then it seems that priority is not working at all.
/Martin

In fact, I've really no idea what will be the behavior of the test engine if you add a dependency feature on configuration methods because they don't share the same logic as test methods.
From the functional point of view, I don't know what will be the expected behavior because priority is suite scoped, not class scoped. It means all configuration methods will be considered when edges will be created.
I think the feature won't be easy to add and need a lot of tests.
@krmahadevan thought?

The priority is not a global feature, it will, e.g. it will sort the method within the same annotation type. E.g. It allows you to sort which BeforeSuite or BeforeMethod should be executed first, today many users solves this by name the so they are sorted in correct order. I don't think this will conflict with any other features either.

The priority is not a global feature, e.g. it will sort the method within the same annotation type. E.g. It allows you to sort which BeforeSuite or BeforeMethod should be executed first, today many users solves this by name the so they are sorted in correct order. I don't think this will conflict with any other features either.

@martinaldrin  To be honest, I dont think there are a lot of users who establish dependency amongst configuration methods. In the close to a decade of being part of TestNG and responding to different queries on different forums (Github, LinkedIn, Stackoverflow, Google forums) I have seen people ask about dependencies between tests, but dependency between configurations is something that i have not heard of. Also this solution/alternative of users resorting alphabetising their configurations in order to get the order right is not documented anywhere to the best of my knowledge and I have not seen too many users who dig into the code to that level to find out this information.
I second what @juherr said that this feature of adding a priority to configuration methods is not something that is going to be easy to solve.
Today TestNG has a notion of method interceptors which are basically invoked by TestNG wherein it allows the testng user to order the tests to whatever order they want. Maybe we can consider building a method interceptor for configurations as well, wherein we just let the testng user tell us what is the order in which they would like to run the test. That way, it needn't be just priorities or alphabetical ordering by names. It could be anything. That functionality would ensure that the customisation or configuration method ordering is externalised with minimal changes. The test method interceptor AFAIK only extracts out independent methods and gives it to the user for ordering. So the same behaviour would be expected for configurations as well.
But before all that, we would need to first define what this capability actually means.
Are we trying to order the configurations of the same type based on some order? What should the scope be for that. Should it be confined to within a <test> or should it be confined to within a <suite>.
What should the behaviour be when this ordering is coupled with hard dependencies (dependsOnGroups and dependsOnMethods)

Hi @krmahadevan , thanks for the reply

@martinaldrin To be honest, I dont think there are a lot of users who establish dependency amongst configuration methods. In the close to a decade of being part of TestNG and responding to different queries on different forums (Github, LinkedIn, Stackoverflow, Google forums) I have seen people ask about dependencies between tests, but dependency between configurations is something that i have not heard of. Also this solution/alternative of users resorting alphabetising their configurations in order to get the order right is not documented anywhere to the best of my knowledge and I have not seen too many users who dig into the code to that level to find out this information.

We use configuration methods allot, so for us it is important. No we have not digging in to the code to find that out the sorting mechanism, that was just something we figured out. I cloned TestNg for the first time 3 weeks ago, before I have just been a regular user.

I second what @juherr said that this feature of adding a priority to configuration methods is not something that is going to be easy to solve.

Maybe I don't have the full picture, but I got exactly the behavior I expected by adding priority for the configuration methods. Ordering and everything is already handled by TestNg, this was just a feature that I enabled. So no code needs to be changed due to that.

Today TestNG has a notion of method interceptors which are basically invoked by TestNG wherein it allows the testng user to order the tests to whatever order they want. Maybe we can consider building a method interceptor for configurations as well, wherein we just let the testng user tell us what is the order in which they would like to run the test. That way, it needn't be just priorities or alphabetical ordering by names. It could be anything. That functionality would ensure that the customisation or configuration method ordering is externalised with minimal changes. The test method interceptor AFAIK only extracts out independent methods and gives it to the user for ordering. So the same behaviour would be expected for configurations as well.

Yes, I know there is other ways to solve this, like intercept the methods in the order we want to run them. But that is much more complicated way of doing it, And most of our users just prefer the standard way using TestNg.
We have also already investigated if it would be possible to implement this in our Framework in a easy way by adding a Priority annotation,  but our conclusion was that it got to complicated to do it in our Framework and the best would be to get the support in TestNg.

But before all that, we would need to first define what this capability actually means.
Are we trying to order the configurations of the same type based on some order? What should the scope be for that. Should it be confined to within a <test> or should it be confined to within a <suite>.

Before Suite is on  level, and the other methods are on  level, no changes should be made

What should the behaviour be when this ordering is coupled with hard dependencies (dependsOnGroups and dependsOnMethods)

In my view, everything should work as it does with the dependsOnGroup/Methods, should not be any difference. The only thing that priority will do is to sort the method in a different order compared to the default alphabetic order. Which enable users to control the order in a very easy way with standard api:s.
The concept of dependsOnGroup/Method already exist and works perfect together with priority on Test Methods, And I showed that also in my PR #2664
I'm not sure I fully understand your concerns her, since this is just a feature that allows to sort the methods in a different way. Support already exist in TestNg, It will not interfere with dependsOnGroups/Methods, since dependsOn have higher priority than a user defined priority.
But I think we first need to focus on restoring #2664 since is a blocker for us for uplifting to TestNg and it is a blocker for this PR as well.

@martinaldrin

We use configuration methods allot, so for us it is important. No we have not digging in to the code to find that out the sorting mechanism, that was just something we figured out. I cloned TestNg for the first time 3 weeks ago, before I have just been a regular user.

Sure. Not discounting the fact that this feature is important to you folks. This was more of a general observation based on what I have seen as user questions/issues etc., over the period of time.

Maybe I don't have the full picture,

What me and @juherr are trying to state here is that, we dont have a historic understanding of what this functionality is supposed to do. So we would need to ensure that while we enable this feature, we also don't break any of the existing tests and to be honest I dont know what all other functionalities/deviations exist with this feature that can break and can surface just like it surfaced with you folks.

Yes, I know there is other ways to solve this, like intercept the methods in the order we want to run them. But that is much more complicated way of doing it, And most of our users just prefer the standard way using TestNg.
We have also already investigated if it would be possible to implement this in our Framework in a easy way by adding a Priority annotation, but our conclusion was that it got to complicated to do it in our Framework and the best would be to get the support in TestNg.

To be honest there's no complications. Once we have an interception mechanism for configuration methods, we can basically expose call backs at the following levels (which testng users will consume via listeners)

Suite Level configurations
Test level configurations
Group level configurations
Class level configurations
Method level configurations wherein TestNG passes the BeforeMethod configs that belong to the same class

Now within the listener, you would just need to find out how you would want to order the methods. It could be via a custom configuration such as @Priority which in your test project you can define and based on that, sort the methods and give back the result back to TestNG.
I personally feel that this is a lesser invasive change into TestNG wherein we aren't adding anything extra, but just exposing the capability of defining the order of configuration methods.
The one pitfall with this approach would that a user would be able to order ONLY independent methods and not the ones that have the below attributes:

dependsOnGroups
dependsOnMethods

I'm not sure I fully understand your concerns here.

Since this is a lesser documented feature when compared to all the other functionalities of TestNG, I am just concerned that we may perhaps not have enough tests that will vet out all of the expected behaviours so that at-least now we would have a benchmark of what the functionality works like. I am saying this more from a maintainer's perspective.
If you could help add as many tests as possible which can cover all the possibilities of this functionality (with and without priorities), that would be a great help here.
I hope that adds clarity to where I am coming from.

I personally feel that this is a lesser invasive change into TestNG wherein we aren't adding anything extra, but just exposing the capability of defining the order of configuration methods.

Now this PR also contains changes that is required for #2664,  This was needed so I was able to write unit tests in expected order. Lets focus on #2664 first and then we can continue with this discussion after that.


Feedback | Add Stamp to PDF | Sign | Save form inputs

Hi,
just some points i found in 0.23.1:
Add Stamp to PDF
I use the function with a picture.

At the next call the value for the stamp is picture but the rest of the paramters are from Text.

Sign
I drop one file from my folder to the browser window. It shows that i had done this with two files, but that wasn't the case.

If i drop 3 files it shows that i have droped 6 files and the preview ist bottom up.

In the second file picker it also shows the 6 files.

Save form inputs
I checked the box to save my inputs. Some inputs are saved (see above the value for the stamp text) but the path to my stamp picture is not saved. It would be nice if the filepath also would be saved, perhaps with the full path maybe only in the popup if i move my mouse over.

Thx Joe

filepaths cant be saved, not something browsers support sorry!
signature etc should not support multiple files, ill remove that and only allow single file thanks!
for your first issue i didnt fully understand due to language sorry

sorry for the late answer
The first point [Add Stamp to PDF] was, that you select [Stamp Type] Image, choose an image on proceed the PDF with the option to save the configuration in the form. At the next time when you go to [Add Stamp to PDF] the value for [Stamp Typ] ist Image, but the next value is [Stamp Text] witch does not correspond to the typ Image.

Wrong one

Right one if you change the value in [Stamp Typ] to Text and then back to Image.

This is still in 0.26.0
Hope this time it is understandable :-)


Handle errors for responses outside successful status codes

The request method now includes a call to .validate(), faulting to the failure block for any response outside the 200..299 range. In the request handler, we now switch on the response type, and pass through a JSON error that includes a response status code when available.
Previously, the failure handler would throw a bad access exception at this line by forcefully unwrapping the userInfo["NSLocalizedDescription"]. This uses the Alamofire Result enum's Failure value to safely access the objects localized description.

Hello Dominic, than you for your contribution!
I just came back from vacation so i will test your PR as soon as possible.

I have xctool DVTAssertions: ASSERTION FAILURE on Travis CI, so need to sort that out first...

CI is now passing on master

Fixed the missing nil check around error. Should be good to merge now.

Great, thank you Dominic! I'm going to merge your PR and push new CocoaPods version.


Android- App auto close on imageStream

whenever I use the app with  faceDetector in debug, profile, or release mode it works fine but when i build the app and start it the app automatically close after the camera stream starts

another note this crash happens only when I build the apk with flutter build apk --split-per-abi and install the app-armeabi-v7a-release.apk but with flutter build apk --release the app works fine is it normal?

@X-SLAYER: any update on this? did flutter build apk --release solve your issue?

yes flutter build apk --release solved the issue


fix generate shlp + messagepopover

Thanks! Made the call of the function module dynamic that it can be installed also on abap_cloud.

The follwowing type is not always on every abap system:
shlp_descr
It is not found in a cloud system, so it will create a syntax error:

Can you copy the type of shlp_descr to a local type and define the variable ls_shlp with this local type instead?

ill try,
maybe ill use your help making it to work properly

shlp_descr.txt
here is my se38 test case for this...
cant seem to get it to work properly.. not sure even why..

never mind, got it to work.. ill update this pull request

thanks for the adjustments!
i added some fixes and there is now just one problem left:

Do you now why there are type problems here and can you fix this?
Seems that a structure is written into a table.

ill check it, maybe i missed something adjusting the new types..

the FS - <fs_isshlp_fielddescr>
is assigned to the table FIELDDESCR from the structure LS_SHLP,
its actually a table that is getting assigned then...

I separated the definition of the field-symbol now and defined it as a standard table. Did not check the functionality, but hope it still works.


refactor(@vtmn/css): change rem/px units for some properties

Subject
In order to have a consistent Design System, we must define which properties are dependent of the root font size.
Typically, margin, padding are dependent of the root font size whereas borders, shadows are not.

Completely agree

What do you think about this stackoverflow answer ?
Respecting User Preferences
Browser zoom has changed a lot over the years. Historically many browsers would only scale up font-size, but that changed pretty rapidly when websites realized that their beautiful pixel-perfect designs were breaking any time someone zoomed in or out. At this point, browsers scale the entire page, so font-based zooming is out of the picture.

Respecting a user's wishes is not out of the picture. Just because a browser is set to 16px by default, doesn't mean any user can't change their preferences to 24px or 32px to correct for low vision or poor visibility (e.x. screen glare). If you base your units off of rem, any user at a higher font-size will see a proportionally larger site. Borders will be bigger, padding will be bigger, margins will be bigger, everything will scale up fluidly.

If you base your media queries on rem, you can also make sure that the site your users see fits their screen. A user with font-size set to 32px on a 640px wide browser, will effectively be seeing your site as shown to a user at 16px on a 320px wide browser. There's absolutely no loss for RWD in using rem.

@lauthieb @xavhan
Basically, we shouldn't put borders padding in px and the font with rem in order to keep the design consistent if the user chooses a different root size from his browser.
Concrete example, If you set your default browser font size at 50px, the font size root will cascade for all the rem props but the borders, that can be 1px wide will remains 1px wide if we don't use rem on border property. So The user will probably not see the borders.

I have tested the behaviour of all the components with 500% zoom in, I saw nothing anoying about sizes.
I would say to let the units in px while using the rem() postcss function.
@lauthieb any feedback on this ?