Fix typo

Fix typo: variables

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:martencassel/infrakit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM, thanks for the fix


Install using system libsqlite3-dev rather than compiling from source

Thanks for this library, it's very easy to use. I don't know much about node-gyp so please forgive me if I've got some kind of configuration problem, but from what I can tell, installing this package with npm install means compiling a fresh copy of SQLite from the source provided in better-sqlite3/deps/sqlite3.tar.gz. Is there some way to install better-sqlite3 using a system installation of libsqlite3-dev? This would accelerate build times and make it easier to audit the code in better-sqlite3. Currently I just have to take the maintainer's word that the bundled tarball is an authentic copy of SQLite ...

Currently I just have to take the maintainer's word that the bundled tarball is an authentic copy of SQLite

You can verify the tarball by running:
git clone git@github.com:JoshuaWise/better-sqlite3.git
cd better-sqlite3
git checkout v5.4.0
tar -xzf deps/sqlite3.tar.gz
SUM1="$(md5sum sqlite3.c)"
sh deps/download.sh
tar -xzf deps/sqlite3.tar.gz
SUM2="$(md5sum sqlite3.c)"
printf "$SUM1\n$SUM2\n"

If the two printed md5 checksums match, the copy of SQLite3 being used is authentic. Of course, you'll also need to verify that deps/download.sh isn't doing anything malicious, but it's a simple bash script so it's pretty easy to verify.
better-sqlite3 cannot use libsqlite3-dev because libsqlite3-dev doesn't have the required compile-time options. However, you can use your own, personally provided copy of the SQLite3 source code, by following the instructions here.

Thank you very much for the verification instructions and pointer to the --sqlite3 flag. It looks like I might be able to use this to build nodegit against the SQLite source supplied by the system, by running sudo apt build-deps sqlite3 && apt source sqlite3 and building the amalgamation myself.
Thanks also for the explanation, I can see how bundling a source tarball is the easiest way to do things from better-sqlite3's perspective. I'll look further into the node build system and the required compile-time flags, and see if I can come up with a good way of caching the build.

@splintax Each of the compilation flags used by better-sqlite3 can be omitted. There are two required flags, but those will automatically be added during the build process whether you like it or not (see: reference). As for what each flags does, yes you'll have to consult the SQLite3 documentation, which is also linked to from the better-sqlite3 docs.

I'll close this issue with a brief summary of why each compile-time flag is included in the default build of better-sqlite3:
SQLITE_THREADSAFE=0
- This flag disables multithreading. Node.js is single-threaded, so we don't need multithreading.
- Disabling multithreading improves SQLite3's performance

SQLITE_OMIT_PROGRESS_CALLBACK
SQLITE_DEFAULT_MEMSTATUS=0
- These features are not used by better-sqlite3, so we disable them with these flags
- This improves SQLite3's performance

SQLITE_OMIT_DEPRECATED
- The SQLite3 docs state that removing deprecated parts of SQLite3 is "the right thing to do"

SQLITE_OMIT_TCL_VARIABLE
SQLITE_OMIT_GET_TABLE
- These features are not used by better-sqlite3, so we omit them to achieve a smaller binary

SQLITE_TRACE_SIZE_LIMIT=32
- This changes the behavior of better-sqlite3's "verbose" option
- With this flag, it will only log the first 32 characters of strings bound to prepared statements

SQLITE_DEFAULT_FOREIGN_KEYS=1
- SQLite3 normally disables foreigns key constraints by default, for backward compatibility
- With this flag, foreign keys are enabled. We assume most users want this.

SQLITE_DEFAULT_CACHE_SIZE=-16000
- This increases the default cache size used by SQLite3 to 16MB.
- Node.js is typically not used on embedded systems, so being more liberal here is okay.

SQLITE_DEFAULT_WAL_SYNCHRONOUS=1
- This significantly increases the performance of WAL mode
- Most Node.js applications should be using WAL mode
- Most Node.js applications don't care about the tiny amount of durability lost by using this flag
- See: https://github.com/JoshuaWise/better-sqlite3/blob/master/docs/performance.md

SQLITE_ENABLE_UPDATE_DELETE_LIMIT
SQLITE_ENABLE_STAT4
SQLITE_ENABLE_FTS3_PARENTHESIS
SQLITE_ENABLE_FTS3
SQLITE_ENABLE_FTS4
SQLITE_ENABLE_FTS5
SQLITE_ENABLE_JSON1
SQLITE_ENABLE_RTREE
SQLITE_INTROSPECTION_PRAGMAS
SQLITE_SOUNDEX
- These each enable various optional features of SQLite3 that some users may need.
- For information about each feature, see here: https://www.sqlite.org/compile.html

SQLITE_USE_URI=1
SQLITE_ENABLE_COLUMN_METADATA
- These are the only two flags actually required by better-sqlite3
- The first is needed to open *named* in-memory databases, via the "memory: true" option
- The second is needed for the statement.columns() method

Thank you very much for that summary – I'm still pretty new to libsqlite and it's helpful even aside from its relevance to better-sqlite. The fact that foreign key constraints are disabled by default explains some weirdness I've seen in the past.


ui: gracefully handle 500 responses on PHP errors

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Not sure how and why this started but now we get empty 500 responses on PHP errors at least for static pages. It might be better to print some boilerplate 500 page with the error embedded so it can be reported more easily.
To Reproduce
Add error to 22.7 static PHP page. Get 500 empty response.
Expected behavior
See a page with the error at least.

Hi. isn't this "on purpose" (debug vs. production mode?) ;)
https://github.com/opnsense/core/blob/04cc8489dea88f1f53a1900a7e3585cd563de56a/src/opnsense/service/templates/OPNsense/WebGui/php.ini#L28

@kulikov-a Aha, this should at least include development as well then. But I’m not sure what gain this has on production to be silent about errors (actual errors only now)

not sure what gain this has on production to be silent about errors (actual errors only now)

can redirect 500 errors to /crash_reporter.php on lighty for "product" mode? (but I don't see much benefit either)

Actually that might be a nice thing to do: redirect to crash reporter page in case of 500 error? It’ll display the error in any case.

nothing smarter than https://github.com/kulikov-a/core/commit/6e3ed08812a51dfdeb79526a91a0613eddaa3d44 from me )

@kulikov-a thanks I committed slightly adjusted version: we redirect on production/development but not on debug where display_errors is on. I'd really like to see (fatal) errors rendered in the page for development but display_errors has the nag to display ALL "errors" as defined by the error level which makes turning on display_errors useless as pages could break like they did in the past writing errors to HTML.

@kulikov-a ok this was worse than expected... did some other things to avoid breaking API 500 returns ;(

@fichtner yes, I tried it and it seems to be what needed . the only question is do we still need a static  status-500.html in this case :)

nope, gone :)


could not find a package configuration file provided by "freenect2" but already have libfreenect2

I'm getting a similiar, but not exactly the same, problem to #231, where after the command:
catkin_make -DCMAKE_BUILD_TYPE="Release"
，there was a error:
CMake Error at iai_kinect2/kinect2_bridge/CMakeLists.txt:22 (find_package):
Could not find a package configuration file provided by "freenect2" with
any of the following names:
freenect2Config.cmake
freenect2-config.cmake

Add the installation prefix of "freenect2" to CMAKE_PREFIX_PATH or set
"freenect2_DIR" to a directory containing one of the above files.  If
"freenect2" provides a separate development package or SDK, be sure it has
been installed.
I have the path pointing to my libfreenect2 directory, but what seems to be an issue is that I can't even find either of the two cmake files anywhere in the directory. So where would I get these two cmake files to resolve the issue?
Thanks!

Hey I have this same issue.
Did you find any solution for the same ?
Thanks in advance !

Hi,
Is there anyone solve the problem yet? Please, help


Pipeline limitations for multi-stage scenarios are not documented

Pipeline limitations in general and more importantly, any limitations related to stages should be documented. It should be mentioned that having an extensive amount of stages and a complex flow, fan-in scenarios (when multiple stages are configured to be prerequisite of a consecutive stage) have limitations, i.e. the maximum number of lines in conditions field of the JSON structure backing the pipeline is limited to 2000. With about 20 stages, this can be easily hit.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4266f72c-c774-0046-4593-d01eb775d3c3
Version Independent ID: f20827aa-a6c5-96a8-5969-e576ffbc2e38
Content: Stages in Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/process/stages.md
Product: devops
Technology: devops-cicd
GitHub Login: @vijayma
Microsoft Alias: vijayma

@RoopeshNair , My customer – who faced these undocumented limitations of Azure pipelines – would like to know if there’s anything happening in this space. In the meantime, I think I could provide more details.
The customer has a Release pipeline, where they are using quite a lot of stages to run certain Pester tests in parallel (this is an automated testing framework to validate Azure Policies with Pester scripts).
After ALL the parallel stages finished running, there has to be an “integration” stage that waits for all the results (success or failure, doesn’t matter) of all the preceding stages. This is essentially a fan-in scenario.
When we tried to set this up, we received an error message that was basically stating that the “dependsOn” field of the “integration” stage can’t have more than 4000 characters. The exact error message is: “The property Conditions length cannot exceed 4000 characters.” I know that for the first sight, this seems to be a reasonably big number, but this particular solution operates with quite lengthy stage names, and having 40+ stages adds up quickly.
We managed to work around this limitation, by using “collector” stages that aren’t doing anything essentially (see below), but this solution is not too elegant.
The customer would like to know if this is a known/expected limitation and not a bug, and if so, why it is not documented. Additionally they would like to see all the pipeline limitations documented, that would help them avoid hitting any of these in the future.
Can you confirm that this limitation is known/expected and that efforts are going to be taken to document these in the near future?
Thanks a lot for your help in advance.

Thank you for sharing this. It does look like there is a cap on 'dependsOn'. will take a look at this. However, currently we are working on features/issues that affect broader set of customers. It will take a while before we can get to this. We know this is important for you. we will continue to track this.

In general, are the limitations documented? What if we have dozens, up to hundreds of different environments? Are there guidelines/best practices for scalability?

We're likely going to run into a similar issue. We're going to have many stages ourselves. We'll be fanning out with ephemeral environments to perform some operations in parallel.


"Mătăsaru" is listed in the drop-down menu

Description:
"Mătăsaru" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Mătăsaru" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Mătăsaru, DÂMBOVIȚA".


Timeline is not re-rendered after adding a new event to timelineData model

When a new event is dynamically added to $scope.timelineData nothing happens since the data watch in the timeline directive does not check for model equality. When there is a third parameter of this function set to true it fixes the issue, however, this solution could lead to performance issues.

Yes you're right, angular does not check the nested object properties as soon as the object reference is still the same. Angular documenation states that :

When` objectEquality == true, inequality of the watchExpression is determined according to the angular.equals function. To save the value of the object for later comparison, the angular.copy function is used. This therefore means that watching complex objects will have adverse memory and performance implications.

For performance reasons, i'd prefer not using this option (my project has big timelines).
To solve your problem, you could create a copy of your object, update it with new data, and replace your timelineData with it (so that object reference is changed). Or you may fork the project and add the 'true' argument to the watch ;)
Thanks for the suggestion anyway.

When the new event is added , the event is added on the timeline but media(video) is not rendered.Can you suggest something?


Using resize_to_limit instead of resize_to_fit everywhere.

resize_to_fit would scale up if an image is too small, which I don't think we necessarily want for the medium and small versions.

:+1:


PeerJ R2C13

Section 4/5
I would be interested in two additional statistics: the country of affiliation of the first author (US centric?) and the distribution over the research application domains.

We have added a figure and paragraph describing the country of author affiliations for all authors, so we can just respond saying this. However, getting the research domains is much harder... while we plan to incorporate some tagging to help with this, we do not have a good way to categorize at the moment.
My draft response:

We have added a new Figure 8 that shows the country of all author affiliations, and a paragraph describing these data on page 15. Currently, 47% of authors come from the US, and 40% from Europe.
Regarding the research domains, we plan to incorporate some basic tagging of articles that includes both programming language and some keywords to help label the domain. However, we do not currently have this information, and thus categorizing articles based on domain would be very challenging.

suggestion:

We have added a new Figure 8 that shows the country of all author affiliations, and a paragraph describing these data on page 15. Currently, 47% of authors come from the US, and 40% from Europe.
We have not track research domains, and manually categorizing articles based on domain would be very time consuming.  In the future, we plan to begin requiring keywords on programming language and research domain in new articles.

sorry, I should redo this since there is so much mentioning of tagging elsewhere in the response.  How about instead:

We have added a new Figure 8 that shows the country of all author affiliations, and a paragraph describing these data on page 15. Currently, 47% of authors come from the US, and 40% from Europe.
We have not tracked research domains, and manually categorizing articles based on domain would be fairly time consuming. In the future, we plan to begin requiring tagging of new articles, including both programming language(s) and keywords to help label the domain.


Updating access token while application is not running

Hi,
I need help understanding how do I get a notification about token expiration while the application is not running (killed). I am struggling with this issue where the application was killed and during that state the token was expired. Now if another user tries to call, he will get "Call ended" since the target user has no valid token.
Is there anyway to get a notification for a token update, maybe in a similar way as TwilioAccessManager works, only also while the application is killed?

Hi @shshalom
This is a good question.
Actually the mobile will still be able to receive incoming call push notifications as long as the registration is still valid. The application in this case will launch automatically upon receiving the VoIP push, and it should be able to accept the call using a special beidge token embedded in the notification payload.
Unless the applications explicitly call the unregister method or the VoIP token itself has expired, the registered binding of the identity should continue to receive pushes.
-bobie

Hey @bchen-twilio, so just to validate what you're saying,  if my application was killed, and wasn't reopened during  the access token lifetime, an Incoming call would still be able to wake up the application, allowing the call to occur?
Another question if I may, is this also true for Android?
-shalom

Hi @shshalom

The concept of the access token, for the Programmable Voice mobile clients, is for operation authentication, e.g. (un)registering or making a call. The token needs and only has to be inside valid TTL at the time making the method calls.
It's slightly different but similar for incoming calls, just that this time the SDK will be using a special bridge-token embedded in the notification payload sent by the Twilio Voice service in order to accept and connect the call. No access token involved this time.
Apple's PushKit framework makes sure the app is woken up if it was killed, in this case, upon receiving the VoIP push notification and guarantees the application enough time to start everything even if the it is still in the background.

I am afraid I am not expert of Android but I will definitely reach out to them and let you know the expected behaviors.
cheers
-bobie

Thanks @bchen-twilio, that helped a lot 👍

@shshalom any time!
Please feel free to reopen or file a new ticket in case you run into any issue in the future.
Looking forward to seeing your awesome Voice apps!


irmin-pack: Move some signatures to irmin-pack.unix

The #1783 PR introduced irmin-pack.unix by moving code out of irmin-pack. This commit goes further by moving more code.
Partially extracted from #1832

LGTM too.

Can be merged when CI is green


fix: bug 1508

1508: Edit existing action.  Delete a required entity and the "save" button is still disabled

:tada: This PR is included in version 0.307.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Singly Linked List - Python

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Implemented all basic features of Singly Linked List in Python.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

Programs works fine and LGTM :)
Please add one example test case input and its output in the comment form below the code section, it would be better for the reader to understand. For this particular code, try to run all the conditions and paste the output below the code in commented form.

I have added the sample input and output.

I would like you to add a simple yet effective feature,
would you write some script that can take an array input from the user and convert that to a linked list instead of inserting some nodes step by step?
That will save time right.

I personally don't feel that using an array would be a better option. It might save time but the purpose of this code is to use Linked List.


Unevenly spaced text [Pending Chrome Fix]

Here is how the scenery.nodes.Text are showing up for Energy Skate Park: Basics control in Win8/Chrome.  Am I doing something wrong?  Note the letters don't seem too evenly spaced.

In https://github.com/phetsims/bending-light/issues/335 @elisemorgan identified kerning issues in this platform:
Test device: Chromebook, Chadwick
Operating System: Chrome 47.0.2526.80 (64-bit)

@jonathanolson can you take a look?

@phet-steele @ariel-phet @lmulhall-phet @jonathanolson have we had any kerning problems during QA lately?  I'm not aware of any and I'm inclined to close this issue.

@lmulhall-phet please do a quick check (or delegate) a quick check in the nearish future. If all looks good, feel free to close. If not reassign to me.

The space between the M and the o in "Motion" is not normal.

Taken on Chadwick. This is in the HTML5 version of ESPB on the website. Will post a comparison picture from Chrome on macOS.

Here is it is on Chrome/macOS...

OK, here's what it looks like in the Chrome app...

And here's what Bending Light looks like on the website...

And here's what Bending Light looks like in the Chrome app...

Thanks @lmulhall-phet!
Agreed that things are a tad off using Chrome on Chromebook but the issues no longer seem egregious enough to warrant much attention.
@lmulhall-phet if you see anything in testing that you feel is illegible or confusing or chromebook, please open a new issue specifically about kerning issues on Chromebook. Closing this issue for now.


update workflow to newer version for node compatibility

The newer version of the checkout action avoids a deprecation of an old version of node.js

This one is hard to test because it's a workflow that runs on a schedule.  It is setup to run on demand from the Actions so I could push this as a branch on the upstream rather than the fork and that should enable testing.

Withdrawn in favor of #219


Trouble at startup docz dev

Bug Report
Describe the bug
Trouble at startup docz dev. Frozing at emitting (95%) Manifest Plugin.
To Reproduce

'yarn docz dev'
See bug

Expected behavior
I wait for launch docz dev env
Environment

OS: [Windows 10 Pro]
Node/npm version: [Node 10.9.0 / npm 6.2.0 / yarn 1.9.4]

Additional context/Screenshots
// doczrc.js
export default {
  port: 8000,
  typescript: true,
  themeConfig: {
    mode: 'dark'
  }
};

TypeScript [3.0.3]
docz [0.11.0]

#304
This doesn't work for me, because I use Next.js. Using @babel/present-env in .babelrc, I get an error.


Enhancement: Introduce a "Close all tabs" button that closes without clearing data

I am not quite sure if this is a good idea, but it would be helpful if there is an option to close all the tabs without clearing data.
Current scenario
Currently there is an option to close each tab individually, without clearing the data. This can done done by following the steps below:

Open multiple websites on multiple tabs.
Login into them.
Click on the tabs icon at the top right, to the left of the three dots menu icon.
Find X mark to close each tab, on the right of each tab.

Enhancement request
Take this one step forward and introduce an option to close all these tabs in one go, by using a master X button to close all tabs.
This will not be the same as the Clear data icon to the right of the search bar/address bar.

This is a good idea, indeed. I'm going to be making a change in this area this week anyway, so I'll add this functionality in too assuming no one in the team objects to the idea.
Thanks for raising this.

Implemented in #340. I'll be releasing this to beta today/tomorrow and it'll be in production in the next release.

Excellent news. 🎉


[greasyfork] Add Greasy Fork rating badges

This is a separate PR from #8080 to discuss the possibility of adding rating badges for Greasy Fork which has a somewhat unique rating system (see https://github.com/badges/shields/pull/8080#discussion_r897278144)

Alternative layout

This represents how ratings are displayed on their website with counts for Good, OK, and Bad ratings. When rating scripts, you select one of these 3 categories.

OpenUserJS has a positive/negative rating system which is also different from most badges currently supported and can possibly be added to this PR after #8081 is merged.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @DenverCoder1!

  Generated by :no_entry_sign: dangerJS against e9da43856a0c7c026483dbb57d66ba20a4bbade9

Thanks for following up. Obviously the collection of all 3 data points are something that's common and familiar to users of the service, so I think this is really more a question of how to best serve up the data. I gather from a cursory read of the issue you opened upstream for the underlying score that it's unlikely that data point will ever be made available which limits (though not necessarily precludes) our ability to provide a more standard formatting rating badges.
Some options we can consider, not mutually exclusive:

3 individual badges with respective counts
1 aggregated badge e.g.
Aggregated in star format (ultimately driven off something we could break down into a percentage)

I'd have some reservations about doing the latter, particularly depending on upstream contexts, but also wouldn't strongly oppose if it's something our users would desire.
What are your thoughts?

Of course I'd be fine with option 1 and leaving it as is, but I think the second option sounds good. It would keep it pretty simple.

I've simplified it to the second option, can always go back if necessary

Want to let this one sit for a bit to see if any of the other maintainers want to weigh in

I know the other maintainers have been quite busy of late, but I don't think they're likely to have strong opinions one way or another. I think the best foot forward is to probably start with the combo badge. As you noted, these aren't mutually exclusive, so if there ends up being demand for the individual count badges we can always circle back to them.
Sound good?

Also, the render function is on the verge of being sufficiently "non-trivial" as to warrant serious consideration for some unit tests. Have you seen/written any such tests for service class members before? If not I can share some examples that may serve as a helpful reference

I've added tests based on examples I found

I've added tests based on examples I found

Awesome thank you. I realize there's at least potentially an open question about if we'll be able to move forward with these badges based on the openuserjs discussion, but I think it would probably be best to continue operating under the assumption as if we will move forward with these greasyfork badges anyway (however, let me know if you'd rather wait, which certainly be understandable).
The tests you added actually raise some interesting questions for me relative to the coloring, and I confess I'm ambivalent about it myself. Colors for these combo-types of badges can inherently be tricky, and I think the closest thing we'd have to an analog is probably the test result summary badges. However, even still those are easier because any non-zero number of test failures is an unequivocal failure/critical type of thing; with ratings/feedback, it's definitely not that clear cut.
In this context, the only scenarios that would have obvious color representations in my opinion would be brightgreen if all the ratings were positive, or red if all the ratings are negative. The tricky territory is the obviously common set of scenarios with mixed sets of feedback. I appreciate the balance you've tried to strike with your current implementation, but would you mind elaborating on your thinking and the "why" behind the color scale your proposing (not pushing back on it at this point, just curious to understand your reasoning)

would you mind elaborating on your thinking and the "why" behind the color scale your proposing

Bad rating aren't really something you can get rid of, if people have an issue while using the userscript and give bad feedback, only the user who gave the bad feedback can change the rating. Because of that I don't think it would make sense that having any amount of bad ratings should cause it to be red.
If the majority of the ratings are good, I would consider that a good script, so it should be green. If majority are bad, it should be red. And following the pattern, to keep things simple, if majority are ok, I make it yellow.
In case of a tie, it favors the better color (green if good is involved, yellow if ok is involved).

I realize there's at least potentially an open question about if we'll be able to move forward with these badges based on the openuserjs discussion

I don't think they're related as GreasyFork and OpenUserJS are independent platforms.
I also didn't get the impression that they had any intent to not have OpenUserJS included, but rather it seems they have a point in general about the handling of limits for all supported sites.
As a side note, it seems they don't take well to strict moderation, continuing to push that does not seem like an effective strategy as it could only cause more conflict. I understand that shields.io has the right to moderate comments, but stretching out long arguments won't resolve things.

Bad rating aren't really something you can get rid of, if people have an issue while using the userscript and give bad feedback, only the user who gave the bad feedback can change the rating. Because of that I don't think it would make sense that having any amount of bad ratings should cause it to be red.
If the majority of the ratings are good, I would consider that a good script, so it should be green. If majority are bad, it should be red. And following the pattern, to keep things simple, if majority are ok, I make it yellow.
In case of a tie, it favors the better color (green if good is involved, yellow if ok is involved).

Thanks. The code behavior is straightforward but it's helpful to know the thinking behind it. For example, how would you view a script that had received two ratings, one good and one bad? I ask because such a 50/50 split would be assigned a color of yellow (or yellowgreen) in our other badges. This is different though in the sense that on other platforms with ratings what's left by reviewers is a scaled value (e.g. 1-10 number or x stars or whatever) so I think there's potentially room to do something different here

Possibly it could average the colors together and round to the nearest integer:
eg. Math.round((good*1 + ok*2 + bad*3)/(good + ok + bad))
If the result is 1 then green, if 2 then yellow, if 3 then red.
What do you think of that idea?

What do you think of that idea?

I was also thinking about some sort of calculation like this which took all the ratings into effect. I think that sounds reasonable, though I'd also tack on the far ends of the scale too (all positive = brightgreen, all negative = red)

// from color-formatters.js
function floorCount(value, yellow, yellowgreen, green) {
  if (value <= 0) {
    return 'red'
  } else if (value < yellow) {
    return 'yellow'
  } else if (value < yellowgreen) {
    return 'yellowgreen'
  } else if (value < green) {
    return 'green'
  } else {
    return 'brightgreen'
  }
}

score = (good*3 + ok*2 + bad*1)/(good+ok+bad) - 1,
color = floorCount(score, 1, 1.5, 2)

How's this?
If all ratings are bad it will be red, if all ratings are good it will be brightgreen.
Everywhere in between:
(0, 1) - yellow
[1, 1.5) - yellowgreen
[1.5, 2) - green
Could possibly use 2/3, 4/3, 2 to make it more balanced?
Only question is what to do when there are no ratings?

I don't think they're related as GreasyFork and OpenUserJS are independent platforms.

Fair enough, just somewhat confusing as there's been a lot of cross talk about the two on the respective implementations for them, especially for someone like me who's never heard of either service apart from a name drop in a feature request.

As a side note, it seems they don't take well to strict moderation, continuing to push that does not seem like an effective strategy as it could only cause more conflict. I understand that shields.io has the right to moderate comments, but stretching out long arguments won't resolve things.

Thanks for sharing your perspective. I appreciate that you're probably most interested in a peaceful resolution, and would like to see the badges come to fruition (especially since you've spent so much time on them!). I share that goal, however, I am also responsible for ensuring another goal.
It's not simply that we have the right to moderate, but that we have the obligation to do so, the obligation to enforce the rules of our community. I've never lost a minute's sleep over something a stranger says to or about me on the internet, but I take the responsibility of maintaining the health and culture of the communities I'm a part of (and at least partially responsibly for) very seriously, as do my fellow maintainers.
The code of conduct and community management aspects of open source maintenance are often a source of difficult conversations, but they exist for a reason. A lot of studies, and even past anecdotal experience in this project, have shown that the failure to curb negative behavior can have long term negative impacts on your community. This is why we have to enforce our rules and put a stop to inappropriate behavior, even if the person on the receiving end of that behavior didn't notice or didn't care (for example, you may not have cared at all at how that person was speaking to you in response to some of your questions, but it's still incumbent upon us to stop it regardless).
It's not my intent to "stretch out long arguments", and that's a part of why I'd previously terminated the debate. However, when it became clear we'd have to re-engage conversations with the person, it became necessary to establish the issue at hand, our authority in this context, and the associated bounds for future discussion. We just cannot allow someone to assert authority or bully their way through our rules, even if that would be the path of least resistance in the moment.

Only question is what to do when there are no ratings?

I think we do something like a grey/inactive color in these scenarios with a message to the same effect, e.g. 'no ratings' but I'd need to double check.
The rest of the proposal for the calc looks good as well :+1:

I am probably not going to have time to give this a final pass tonight, so just be aware that today's the day of the week when we apply dependency updates so there may be a number of merges that get in front of this one

That sounds reasonable to me. If you could update the branch whenever you get a chance that'd be great. I'll do a final pass over this after work but I think this should be good to go


New version: MasterPackager.MasterPackager version 23.2.8474.0

Result: Installation Successful

Manifest
Add/Remove Programs

Name
Master Packager
Master Packager

Version
23.2.8474.0
23.2.8474

Publisher
Master Packager Ltd.
Master Packager

ProductCode

{E5CEF406-9838-48AB-A9ED-A3A6C25B857F}

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 6667
Microsoft Reviewers: Open in CodeFlow

@vedantmgoyal2009 @stephengillie  Hi, could you please tell me why the latest version was not added automatically? Should I manually create PR?
Thank you!

@EdijsPerkums I'm making updates to the automation. The new version will be created by the day after tomorrow.


changes in driverless.c file to list IPPS printers

Currently driverless list only IPP printers . Adding _ipps._tcp argument to driverless.
The below command would list  the driver URIs and metadata for all available IPPS printers supporting driverless printing.
driverless _ipps._tcp
Fixes #251
EDIT: Now, driverless shows IPPS queues whenever the printer supports it and IPP queues when the printer does not support IPPS.
driverless _ipps._tcp shows only IPPS printer URI
driverless _ipp._tcp shows only IPP printer URI.
I have tested with ippeveprinter and it was giving results as expected.

Thanks for this pull request, but this is not actually what I need.
It is useful for development and debugging, as you can find printers in the network which accept jobs encrypted via IPPS, but it does not improve the practical day-to-day use of "driverless" and so does not add to the user experience.
In my first e-mail, to introduce you into your work, in the section "3. Fax support" I have explained you how the "driverless" utility is used by CUPS to discover driverless IPP printers and to easily allow to set up print queues for them with any printer setup tool. The expected user experience is now that each physical printer is listed exactly once,  NOT two times if it supports both IPP and IPPS, and the one listing of the printer uses the more sophisticated protocol, meaning IPPS if both are supported. So all available IPP printers get listed, the ones which support ONLY IPP and NOT IPPS are listed as IPP, the ones which support IPPS are ALWAYS listed as IPPS, independent whether they also support IPP. PPD generation should always work, independent if the IPP URI used is IPP or IPPS (as long as the printer supports it). This way CUPS (or the printer setup tool) should create queues with the "better" protocol.
So your task here is to modify "driverless" so that when used with CUPS you get IPPS queues whenever the printer supports it and IPP queues when the printer does not support IPPS. Please test this with CUPS.
For testing most physical printers support IPPS, the sample Printer Application of PAPPL and the PCL example Printer Application also. IPP-over-USB with ipp-usb does not support IPPS.

Thank you very much for the new patch, but there are several things which I do not like:

Do not use temporary files for the two printer lists. One can easily drop them in some array (you are reading them into arrays anyway, why not dropping the items into arrays directly?)
Temporary files should never have static (predictable) names for security reasons and they should be dropped into some temporary file directory (when solving (1) this item gets irrelevant anyway)
Do not use arrays with static amount of items (101 here). To create dynamic arrays you do not need to re-invent the wheel by using the CUPS arrays of libcups (see cups/array.h in the source code of CUPS). We are using libcups anyway in cups-filters, so no problem to use the CUPS arrays. With CUPS arrays you can even easily sort the output, find and reject duplicates, ... (with a well-selected comparison function you could easily reject the IPP version of a printer if the IPPS version is already there).

Could you fix these points?

Sure,but I want to clarify following points:
For first part(1)-  In int list_printers() function ,I have to read the output  from child process and if I store the output( printer uris) in some array,it would not get saved as after the exit of child process,any changes made to that array would be lost(any memory allocated to child process would be destroyed).Is there any way by which I could restore the changes made to that array?How could I then drop printer list in some array so that changes won't be lost?
and second thing is I am copying only service_name in arrays not service_uri because if we run driverless list ,it would list the metadata also ,because of which I would have to allocate about 10^4 Bytes  of memory(calculated based on the varibale size of service_uri,service_hostname ...declared) for single printer.Would it be feasible to allocate this much memory?

You can already see in the original utils/driverless.c how the output of ippfind is caught. driverless forks into two processes, one runs ippfind and directs the output into stdout, the other grabs this output via stdin. The two processes are connected in a way that stdout of the first process is piped to stdin of the second process. So one process is running ippfind while the other is processing the output. This second process can, instead of sending its results finally to stdout, store them in some variable/array.
You will have a main process, which forks out an auxiliary process. The auxiliary process runs ippfind to get the IPPS entries, the main process receives ippfind's output via pipe. The results of processing it stores in an array. When ippfind finishes, the auxiliary process terminates. The main process stays running and forks out an auxiliary process for a second time, this time letting the auxiliary process run ippfind for the IPP entries. The main process again processes the output and adds the results to the array, but only the ones which do not already exist from the IPP round. It depends on the user-requested tasks which ippfind calls are actually done.

I have merged your changes. Thank you very much.
When testing I found the following issues:
Please let driverless not issue the CUPS log messages (DEBUG: ...) when calling in a terminal. These messages should only be issued if CUPS is calling the program.
I have the following URIs available:
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/
ipp://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipp._tcp.local/
ipp://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D%20(USB)._ipp._tcp.local/

In this case driverless (without arguments) should show
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/
ipp://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D%20(USB)._ipp._tcp.local/

as the second in the above list is the IPP version of the first. What it actually shows is only
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/

Please let driverless not issue the CUPS log messages (DEBUG: ...) when calling in a terminal. These messages should only be issued if CUPS is calling the program.

I would set debug = 0 for driverless in my next pull-request.

as the second in the above list is the IPP version of the first. What it actually shows is only
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/

Could you please also test and confirm me if driverless  _ipps._tcp  and driverless _ipp._tcp gave the expected results or not. (This would help me for better debugging until I got my printer).

Yes, set debug = 0 for manual calls, like driverless without arguments and not detecting running CUPS by SOFTWARE env variable.
On my system I get (DEBUG: messages removed):
$ ippfind _ipps._tcp
ipps://HP18602408C229.local:443/ipp/print
ipps://till-x1yoga.local:631/printers/snap-ps
$ ippfind
ipp://HP18602408C229.local:631/ipp/print
ipp://till-x1yoga.local:60000/ipp/print
ipp://till-x1yoga.local:631/printers/snap-ps
$ ./driverless _ipps._tcp
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/
$ ./driverless _ipp._tcp
ipp://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipp._tcp.local/
ipp://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D%20(USB)._ipp._tcp.local/
$ ./driverless
ipps://HP%20OfficeJet%20Pro%208730%20%5B08C229%5D._ipps._tcp.local/
$

The URI with (USB) is the IPP-over-USB version of my printer, provided via ipp-usb. ippfind shows it as ipp://till-x1yoga.local:60000/ipp/print.
The URI ipp(s)://till-x1yoga.local:631/printers/snap-ps which shows only in the ippfind output is a CUPS queue which is intendedly filtered out by driverless.


Question: How to get the binding for an {x:Bind} in code?

I want to discover the binding of a property so I can check the property validation and focus the control.  I could do this with regular bindings in WPF.  The control validation can clearly perform the query of the viewmodel validation for the property.  Is there a way to surface this functionality?

@omnilogix are you asking about a binding object?  x:Bind is implemented by generated code, and doesn't have an associated object.

Yes, that is what I wanted to confirm.  Is there any other mechanism to determine what property in the ViewModel is associated with a particular control via {x:Bind}?

From the ViewModel author's perspective?  From the app author's perspective you would know because you authored the x:bind. @RealTommyKlein are there debugging tools available?

You can debug through the generated x:Bind code for your page.  The x:Bind logic is located in a generated file in your obj folder based on the page's name, e.g. a MainPage.xaml generates to a MainPage.g.cs for C#.  From there you can look at the x:Bind implementations for the specific x:Bind you're interested in.  As an example, a {x:Bind ViewModel.FirstName} would have its logic handled by the Update_ViewModel_FirstName method

From the ViewModel author's perspective? From the app author's perspective you would know because you authored the x:bind. @RealTommyKlein are there debugging tools available?

No, from the view perspective.  With WPF, I would discover that the ViewModel validation fails, and find the control in the view that is bound to the failed validation.  Then, the view could navigate to, and focus the offending control.  This is about providing a great UX with minimal navigation required by the user in an error condition.

You can debug through the generated x:Bind code for your page. The x:Bind logic is located in a generated file in your obj folder based on the page's name, e.g. a MainPage.xaml generates to a MainPage.g.cs for C#. From there you can look at the x:Bind implementations for the specific x:Bind you're interested in. As an example, a {x:Bind ViewModel.FirstName} would have its logic handled by the Update_ViewModel_FirstName method

I have already done this while waiting for a response to the original question.  I see there is no binding information, but there could be if Microsoft felt that the information is important, which is why I was asking.  I had hoped that there would have been a dictionary or something that provided the link between view control and veiwmodel property.    Without this information, I either need to add an attached property declaring the property name (which requires me to declare the property path again - which is extra work and error prone), or my users go without this nice functionality in my v-Next app.  Both solutions are a step back.


Vite Fails to Resolve Entry for Package "muigui"

Problem Description
When using Vite to build my project, I encountered the following error:
[vite] Internal server error: Failed to resolve entry for package "muigui". The package may have incorrect main/module/exports specified in its package.json.
Environment Information

Operating System: Windows 10
Vite Version<EMAIL_ADDRESS>Node.js Version: v20.12.2
muigui Version<EMAIL_ADDRESS>
Steps to Reproduce

Initialize the project:
npm i muigui

2.Relevant Code Snippet
`import GUI from 'muigui';
/**

this is test code.
*/
const start = () => {
const gui = new GUI();
};

start();`
Additional Information
I suspect that the issue might be due to incorrect configuration of the main or module fields in muigui's package.json.
If you need further information, please let me know.
Thank you for your help!
Temporary fix

Yep, I run into this as well.


Home Assistant dashboard

Hi!
Does anyone have some lovelace dashboards showing the Nibe status?
Care to share them?
Thank you!

This is not really an issue we wan't here.


sporadic double sync issue with y-partykit

not sure if this is just in development but for some reason every once in a while i'll get into a state where onSync is getting called twice at the same time which is messing up my logic to de-dupe and registering all my logic twice
i can only get this to fix when i do a hard refresh in the browser (killing and restarting the partykit server doesnt seem to help here)
relevant code:
yprovider.on("sync", (connected: boolean) => {
  if (!connected) {
    console.error("Issue connecting to yjs...");
  }

  setupElements();
});

and I'm using the standard persistent y-partykit server

update: getting this quite consistently on hot reload. I'm using vite + partykit if that helps at all.

Oh interesting, is this only in dev with hot reload? Does it happen in prod?

Oh interesting, is this only in dev with hot reload? Does it happen in prod?

i haven't been able to reproduce in prod so i think it might just be on dev

This is a super helpful clue, maybe we can solve it with a module.hot hook

in the meanwhile, can you try setting server: {hmr: false} in your vite config to see if it 'fixes' the issue?


Update to  channels 2

geis does not work with channels2 and never will be (it has to be python now)
pytest
rewrote cache system
use username instead of pk for admin user in tests

See #3784

If I don't here anyhing from you, I will merge this tomorrow

Ok, please merge and let's talks about the remaining remarks on Wednesday.


Add /pt-br/docs/reference/glossary/deployment

Added translation for portuguese of the glossary term deployment.

/lgtm

/cc @edsoncelio

Thanks!
/approved

/approve


Download input and upload output directly, as opposed to using FUSE

This PR makes it so that PPS no longer uses FUSE for job execution.  Rather, it downloads input data directly to disk, and writes output data directly to disk before uploading it.  In a benchmark, this shortens job execution times by 4x.
Fixes #701, #777, #755 #780, #781
Caveats:

Currently we don't handle the failure mode where a node doesn't have enough disk space to store input/output data.  This will be handled in a future PR.

How hard would it be to get rid of the fuse in /pfs/fuse/prev? That seems like a kind of ugly wart to me and like it would only require a small modification to the fuse layer to allow mounting a single commit of a single repo as a single directory rather than having an extra layer of directories in between

@jdoliner comments addressed

Also fixes #573 I think.


CLI: unexpected token '?'

Description
Hi guys,
just created a new project and it is throwing this error when doing archive on iOS and when doing build on Android
Showing Recent Messages

/usr/local/bin/node /Users/hardik/Documents/GitHub/ReactNApp/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output /Users/hardik/Library/Developer/Xcode/DerivedData/ArcedirovNew-cdkamivgjmneqpgzgxxedswjccki/Build/Intermediates.noindex/ArchiveIntermediates/ReactNApp/BuildProductsPath/Release-iphoneos/main.jsbundle --assets-dest /Users/hardik/Library/Developer/Xcode/DerivedData/ReactNApp-cdkamivgjmneqpgzgxxedswjccki/Build/Intermediates.noindex/ArchiveIntermediates/ArcedirovNew/BuildProductsPath/Release-iphoneos/ArcedirovNew.app

/Users/hardik/Documents/GitHub/ReactNApp/node_modules/@react-native-community/cli/build/index.js:156
cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val), typeof opt.default === 'function' ? opt.default(rest[0]) : opt.default);

Please advice how to fix this. thanks
Version
0.70.1
Output of npx react-native info
System:
OS: macOS 13.0
CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
Memory: 365.09 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
Yarn: 1.17.3 - /usr/local/bin/yarn
npm: 8.5.5 - ~/.nvm/versions/node/v16.15.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK:
API Levels: 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33
Build Tools: 29.0.2, 29.0.3, 30.0.1, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 33.0.0
System Images: android-21 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Android TV Intel x86 Atom, android-24 | Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-25 | Google APIs ARM EABI v7a, android-25 | Google APIs Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Intel x86 Atom, android-27 | Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom_64, android-29 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom_64, android-30 | Google Play Intel x86 Atom, android-31 | Google Play Intel x86 Atom_64, android-N | Android Wear ARM EABI v7a, android-N | Android Wear Intel x86 Atom, android-N | Intel x86 Atom, android-N | Intel x86 Atom_64
Android NDK: 21.3.6528147
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9014738
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
Languages:
Java: 18.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.1 => 0.70.1
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Trying to build on Android
Archive on iOS for app store upload
Snack, code example, screenshot, or link to a repository
https://pasteboard.co/jF639A0h1o6b.png

I am getting this Error in Xcode while building & Archive.
/node_modules/@react-native-community/cli/build/index.js:156
    cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val), typeof opt.default === 'function' ? opt.default(rest[0]) : opt.default);
                                          ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:1072:16)
    at Module._compile (internal/modules/cjs/loader.js:1122:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)

+ [[ '' != true ]]
+ cp /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/main.jsbundle /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/ReactNative.app/
cp: /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/main.jsbundle: No such file or directory
+ BUNDLE_FILE=/Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/ReactNative.app/main.jsbundle
+ [[ false != true ]]
+ [[ ! -f /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/ReactNative.app/main.jsbundle ]]
+ echo 'error: File /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/ReactNative.app/main.jsbundle does not exist. This must be a bug with React Native, please report it here: https://github.com/facebook/react-native/issues'
error: File /Users/saravanakumar/Library/Developer/Xcode/DerivedData/ReactNative-exomamucwknejgecicizjaevjbgd/Build/Products/Release-iphonesimulator/ReactNative.app/main.jsbundle does not exist. This must be a bug with React Native, please report it here: https://github.com/facebook/react-native/issues
+ exit 2

Output of npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 12.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 72.03 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    Android SDK:
      API Levels: 23, 26, 28, 30, 31, 33
      Build Tools: 22.0.1, 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0
      System Images: android-R | Google APIs Intel x86 Atom, android-R | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7678000
    Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.13 - /Library/Java/JavaVirtualMachines/jdk-11.0.13.jdk/Contents/Home/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: ^0.70.1 => 0.70.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

/Users/hardik/Documents/GitHub/ReactNApp/node_modules/@react-native-community/cli/build/index.js:156
cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val), typeof opt.default === 'function' ? opt.default(rest[0]) : opt.default);

Hi @harrymash2006
Thanks for reporting this issue.
It seems like this issue is related to the CLI. Can I ask you to open another issue against this other repository:
https://github.com/react-native-community/cli/issues
Please link against this one and we'll sort things out.

same bug after updating to react 0.70.1 from 0.67.4
if i do npx react-native info, the cmd return me: Unexpected token '?'

I also ran into this! The issue at least in my case was the node export was pointing to the default installed version on the Mac, NOT the nvm managed version. On iOS this can be seen by a log Node found at: ${NODE_BINARY}.
This was due to not having a .xcode.env file (whoops RN updating and missed this) and not having my NVM_DIR set in my bash path settings (since Xcode uses bash instead of zsh), which I did via these instructions.
This might not be the exact issue observed here, but maybe it helps somebody!

Update note js to 16 resolve this problem

Update to NodeJS 16 is the solution for SyntaxError: Unexpected token '?' and not i am able to build the App using XCode.

Yes, I'm seeing this as well... I tried these node versions:
nvm use 16.13.1
nvm use 16.17.1
nvm use 18.9.1
[!] Invalid `Podfile` file: 859: unexpected token at 'info Run CLI with --verbose flag for more details.
'.

 #  from /Users/neo/Projects/vatom-inc/wallet/apps/wallet/ios/Podfile:44
 #  -------------------------------------------
 #    use_expo_modules!
 >    config = use_native_modules!
 #
 #  -------------------------------------------
Couldn't install Pods. Updating the Pods project and trying again...
Command `pod install` failed.
└─ Cause: Invalid `Podfile` file: 859: unexpected token at 'info Run CLI with --verbose flag for more details.
'.

 #  from /Users/neo/Projects/vatom-inc/wallet/apps/wallet/ios/Podfile:44
 #  -------------------------------------------
 #    use_expo_modules!
 >    config = use_native_modules!
 #
 #  -------------------------------------------

I confirmed the node -v is in my path as well:
➜  node -v
v16.13.1
➜  which node
/Users/neo/.nvm/versions/node/v16.13.1/bin/node

Also seeing this exact issue after upgrading RN from 0.69.4 to 0.70.1
Node 16 is installed via nvm. Everything worked perfectly until now.

I had the exact same issue. Running npx react-native run-android worked fine. Opening the upgraded project in Android Studio on my Ubuntu 22.04 machine resulted in the mentioned error.
In my case, I figured out, that i had two versions of node installed:

Node 12 (!!) via package manager (/usr/bin/node) in version
NVM managed Node 17.2.0 (~/.nvm/versions/node/v17.2.0/bin/node)

Gradle seemed to use v12 from the package manager, because it doesn't pick up the NVM Paths. So i removed it from the system via apt remove nodejs.
Opening the project again in Android Studio now resulted in an error, because node was not found:
Caused by: java.io.IOException: Cannot run program "node" (in directory "/home/chris/documents/my-app/android"): error=2, File or directory not found
Finally I manually linked the "system node binary" to my NVM installed version:
ln -s $(which node) /usr/bin/node
Now my project is building fine. Maybe that helps.

Closing as this issue is related to local environment setup

Fixed this by creating a .nvmrc containing the desired node version in the home directory.

Update note js to 16 resolve this problem

Thanks. It works on me.  If the advice is useless for someone, please make sure that you had changed the default version of node on Terminal rather than Zsh or anything else

I had it fixed by starting my app with npx react-native start instead of react-native start.
I had one react-native installed with volta at ~/.volta/bin/react-native.
Versions:

react-native-cli: 2.0.1
react-native: 0.70.9

After upgrading react-native from 0.69.0 to 0.70.0 I started getting this error when I tried to start my application with react-native start:
cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val) [...] SyntaxError: Unexpected token '?'.
For some reason the Metro of my globally installed react-native wasn't using the node 18 I have globally installed. I checked for other node versions but they weren't there. So I removed the react-native installed with volta with volta uninstall react-native-cli and started using npx to force the react-native from within my project's node_modules to be used.
PS: I did not needed to remove my globally installed react-native, only did it to avoid confusion in the future if I forget to add the npx suffix.

Either update node to >v16 or patch the file

I had the exact same issue. Running npx react-native run-android worked fine. Opening the upgraded project in Android Studio on my Ubuntu 22.04 machine resulted in the mentioned error.
In my case, I figured out, that i had two versions of node installed:
* **System-wide Node 12** (!!) via package manager (/usr/bin/node)

* **Locally NVM managed Node 17.2.0** (~/.nvm/versions/node/v17.2.0/bin/node)

Gradle seemed to use the system-wide Node 12 from /usr/bin/node, because it doesn't pick up the NVM Paths. So i removed it from the system via apt remove nodejs.
As expected, opening the project again in Android Studio now resulted in an error, because node was not found: Caused by: java.io.IOException: Cannot run program "node" (in directory "/home/chris/documents/my-app/android"): error=2, File or directory not found
Finally I manually linked the "system node binary" to my NVM installed version: ln -s $(which node) /usr/bin/node
Now my project is building fine. Maybe that helps.

Thank you, worked for me

update to veroisn 18.18.2 and the issue was gone. i was using 13.2.1

Error :  Caused by: java.lang.Exception: /home/icsl027/Documents/ics-rn-wave-rider-app/node_modules/react-native/node_modules/@react-native-community/cli/build/index.js:119    cmd.option(opt.name, opt.description ?? '', opt.parse || (val => val), typeof opt.default === 'function' ? opt.default(rest[0]) : opt.default);                                          ^SyntaxError: Unexpected token '?'    at wrapSafe (internal/modules/cjs/loader.js:915:16)    at Module._compile (internal/modules/cjs/loader.js:963:27)    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)    at Module.load (internal/modules/cjs/loader.js:863:32)    at Function.Module._load (internal/modules/cjs/loader.js:708:14)    at Module.require (internal/modules/cjs/loader.js:887:19)    at require (internal/modules/cjs/helpers.js:74:18)    at Object. (/home/icsl027/Documents/ics-rn-wave-rider-app/node_modules/react-native/cli.js:13:11)    at Module._compile (internal/modules/cjs/loader.js:999:30)    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
i tried with node v18.16.0 and v16.15.0 but still facing issue
my React native version : 0.71.4
React version : 18.2.0

Try and it may work:

remove node_module, yarn install
./gradlew --stop
./gradlew clean & ./gradlew assembleRelease

Thanks @qilovehua, you've actually helped me figure out what was happening.
I've migrated a project from a Mac to a Linux machine and started facing this error, on a project that was fine.
So, apparently Android Studio wasn't aware of node location. I've made a symbolic link from nvm installation to /usr/local/bin/node

I solve this issue by using the correct version of Java, for my end I used Java 17 using sdkman.

use this nvm alias default 18 fixed my issue


Duplicate Deprecated Annotation

Hello from DroidCon! Here's the schema snippet I promised to post, that allows a generated class to be created that has multiple @Deprecated annotations, preventing compilation. It's also not a correct representation of the schema, since the @Deprecated annotation should be on the enum value that was deprecated, not the overall class.
The workaround is to remember to remove the deprecated enum values from the schema, each time the schema is updated (which is quite a bit since we're still in active development of both server and clients).
{
  "kind": "ENUM",
  "name": "Platform",
  "description": "A list of platforms the client will specify to the API",
  "fields": null,
  "inputFields": null,
  "interfaces": null,
  "enumValues": [
    {
      "name": "iOS",
      "description": "Mobile iOS platforms",
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "Android",
      "description": "Mobile Android platforms",
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "SmartTV",
      "description": "TV platform",
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "AppleTV",
      "description": "TV platform",
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "AndroidTV",
      "description": "TV platform",
      "isDeprecated": false,
      "deprecationReason": null
    },
    {
      "name": "BigScreen",
      "description": "",
      "isDeprecated": true,
      "deprecationReason": "BigScreen is no longer used. Use SmartTV, AndroidTV, or AppleTV"
    },
    {
      "name": "Mobile",
      "description": "",
      "isDeprecated": true,
      "deprecationReason": "Mobile is no longer used. Use iOS or Android"
    }
  ],
  "possibleTypes": null
},

And here's the generated class:
package example.graphql.type;

import java.lang.Deprecated;
import javax.annotation.Generated;

/**
 * @deprecated BigScreen is no longer used. Use SmartTV, AndroidTV, or AppleTV
 * @deprecated Mobile is no longer used. Use iOS or Android
 * A list of platforms the client will specify to the API
 */
@Generated("Apollo GraphQL")
@Deprecated
@Deprecated
public enum Platform {
  /**
   * Mobile iOS platforms
   */
  iOS,

  /**
   * Mobile Android platforms
   */
  Android,

  /**
   * TV platform
   */
  SmartTV,

  /**
   * TV platform
   */
  AppleTV,

  /**
   * TV platform
   */
  AndroidTV,

  BigScreen,

  Mobile
}

What version of library are you using? I tried to reproduce it with no luck. And we have a test for the deprecation and it's seems valid, the strange part in your example is that deprecation annotation is added on class level not on value. But again I couldn't replicate this case. Could you pls provide any additional info or clues how to replicate it.

I can reproduce this on 0.4.0, and I just tried 0.4.1 after deleting the top-level build and app/build folders, and I get the same result. Our full schema is about 12k lines, but I could perhaps email it to you if the snippets aren't working to reproduce the bug.
We have this under the directives block of the schema, does it provide a clue?
        {
          "name": "deprecated",
          "description": "Marks an element of a GraphQL schema as no longer supported.",
          "locations": [
            "FIELD_DEFINITION",
            "ENUM_VALUE"
          ],
          "args": [
            {
              "name": "reason",
              "description": "Explains why this element was deprecated, usually also including a suggestion for how to access supported similar data. Formatted in [Markdown](https://daringfireball.net/projects/markdown/).",
              "type": {
                "kind": "SCALAR",
                "name": "String",
                "ofType": null
              },
              "defaultValue": "\"No longer supported\""
            }
          ]
        }

pls email me that I can try to reproduce it<EMAIL_ADDRESS>

I think I found the issue


Updating requirements.txt to use hashes; updated lxml to 4.6.1 to resolve XSS vulnerability.

This branch updates requirements.txt to use hashes in validating package consistency across install. The lxml dependency was also updated to 4.6.1 to resolve an XSS vulnerability found by security check. Steps to update requirements.txt were added under the README.md file.

Need to update the install section to adjust parts mentioning editing requirements.txt, also need to add another line for upgrading pip in cases where installing requirements fails due to an out of date pip install.

Instructions have been updated for install/troubleshooting. Let me know if any other edits are needed.

Also needs someone with a Mac to test the updated instructions. I mimicked the other commands for MacOS install, but I can't test them myself since I don't have a Mac.


Updating to latest version of doorbot

This PR pulls in the latest<EMAIL_ADDRESS>that includes some authentication fixes and improvements. I also dropped the default retries from 15 to 5, ideally with the latest authentication improvements the retries aren't even needed :)

@davglass - i thought i had bumped the requirement to 3.0.1 earlier today! i didn't drop the retries, so i just did that. can you see if i am out of sync with you? thanks!

@mrose17 the only diff now is that I'm using ^3.0.1 in the package.json instead of 3.0.1. This way if I release any changes your users get them without you having to release a module update :)

thanks we should be in sync!

Awesome, thanks!


Huge differences of SparseGPT Reproduction on LLaMA-2-7B

At 80 sparsity, LLaMA-2-7B's ppl is around 100 with the pruning of SparseGPT on wikitext2, and Wanda also reported 1e2 while you wrote 53.20 in your paper. Could you tell me why the difference is so big?

Thank you for the question and your interest in our work. The difference between the reported perplexity, as you have highlighted, is due to the fact we only pruned the first 50% of the decoder layers in our experiments (for a balance between demonstrating the effectiveness of our method and computational resources), as we mentioned in the experiments Section in our paper. In addition, we would like to point out the current version of the released code does not  have the restriction to only prune the first 50% of the decoder layers.


fix(names): better names

Fixes #3979
As suggested By @VaibhavUpreti i changed the names

cc @VaibhavUpreti @tachyons

please fix on the original PR instead of creating new PR for each feedback

@tachyons my gitpod workspace inwhich previous pr branch exist deleted automatically due to inactivity so i can not able to access that branch ,thats why i make this pr throiuhg new branch.


Set s3_secret_access_key as sensitive option

Checklist

[ ] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[ ] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary.

Motivation and Context

Secret key is represent as "Password", then we should'not display it.
Description

Following options "api_key" and "git_private"
Testing Steps

@Peelz Thanks for making this PR! Do you mind agreeing to the CLA so we can get this merged in? 😊

@Peelz Thanks for making this PR! Do you mind agreeing to the CLA so we can get this merged in? 😊

https://github.com/fastlane/fastlane/pull/18737#issue-650605456
already send new pull request


Region Configuration Mismatch After Maintenance

Package Name:  azureml-sdk, MSAL
Package Version:  1.43.0, 1.21.0
Operating System: Ubuntu 18.04
Python Version:  3.8.13

Describe the bug
I'm running a voila (0.2.16) app on Azure App Service plans and after a maintenance, the following error showed up.

I tried a downgrading the MSAL version since I was told the region is configured in that package but I haven't gotten any results. What is correct way to fix this warning and correctly configure the region?
Expected behavior
Correctly configured regions.

Thank you for the feedback @Nephdz . We will investigate and get back to you asap.
cc @azureml-github

Closing as obsolete


Upgrading to Rails 5.0

Requires upgrading autoprefixer-rails and jquery-rails and adding the rails-controller-testing gem
These gem changes are not enough to resolve the test failure in the "should not allow me to use a token without a user" test in spec/controllers/promo_codes_controller_spec.rb.  (The expected result is code 401, but code 200 is received instead.)

Completed


Use Drag and Drop in a grid layout

Is this support only single columns as of now? Is there a way to pass in grid layout parameters ([row, cols]) to manage Drag and Drop in a grid layout?
Or this should be achieved via changes to CSS and the functionality?

@vkumara this can be achieved, just stack it as columns.


Indy: Add a completion check to the indy-node Ansible role

The Ansible role for creation indy-node stewards should contain a task which checks that all steward indy-node pods have successfully started before the play can continue. We can use k8s_facts Ansible module in a loop with a reasonable timeout (replays x delay).

Closed by #107


warning NU1603: NEST 5.5.0 depend on Newtonsoft.Json (>= 10.0.0 && < 11.0.0)，but not found Newtonsoft.Json 10.0.0

NEST/Elasticsearch.Net version:5.5.0
Elasticsearch version:5.5.2
Description of the problem including expected versus actual behavior:
Steps to reproduce:

get NEST 5.5.0 via nuget on vs 2017 update 4, .net core 2.0.2 project
build
found a warning like title

Provide ConnectionSettings (if relevant):
Provide DebugInformation (if relevant):

Describe the feature:

This has been fixed in https://github.com/elastic/elasticsearch-net/pull/2865 and will be in the next 5.x release.


Update for 0.12

Seems pretty similar to #4.
@natefaubion please could you merge one of these 🙏

...and make a release 😄


New simplified interface

Have a dialog for connection information, the default database should be autoperf on brix and should always be available for demo purposes.
Add a new interface that fits in a fixed size page and uses scrollable widgets. For example, the list of applications can be arbitrarily long, but should fit in a fixed-height widget (scrollable). All list-based widgets should also have filtering options (plain text matching for now).
When a user first connects to the front page, there should be default values for all required user input so that they see some result without having to do anything.

Default metric should be TIME, and if not available, the first available metric
Default value to show for multiple thread experiments should be the "Mean" of all threads.

Some progress on 2 and 3, committed in 30a9de3ad29ca1664d2bae8b8e1e31311f649a26.


Title and icon missing in sandbox page

see the /sandbox page is missing the title and icon

This has been fixed https://explorer.hiro.so/sandbox/deploy?chain=mainnet
thanks for the report


TextInputType.phone keyboard doesn't delete typed text when the keyboard is switched to extra symbols on Android

I think that Flutter is missing a concept in our key handling: we don't make a distinction between a lock key (NumLock, ShiftLock, or ScrollLock) being currently pressed, and the "lock" state being on/off.
I think Flutter should keep its current behavior with respect to key presses in that it should show when the key is actually being pressed, and add some API to ask if a lock state is currently enabled.
This might be hard to implement on macOS, where the lock keys don't send one of the key press events (key up, I think?) but should still be possible to detect based on waiting for a repeat event (if we don't get a repeat event within a timeout, send a key up anyhow).
Related to https://github.com/flutter/flutter/issues/60922
cc @dkwingsmt @stuartmorgan

I would say it's easier to implement the state on macOS since we have the source of truth. It's harder to implement the events, but the least we could do is to follow a down with an immediate cancel, and precede an up with an immediate sync.
For other systems though, we might have to track the states, which is prone to losing sync.

Ahh, yes, the cancel/sync events would help here.  GTK also has a clear understanding of the state of the lock, with gdk_keymap_get_num_lock_state(), et al.

Is there any update on this one? It's crucial to our app that user can enter their phone number without getting confused, when they lets say enter '+' twice per accident and want to delete the last char then. It's in particular important for us since the phone number is required during the registration process.
Would be outstanding if somebody can fix that.
Thanks flutter team!

The demanded API has been added as lockModesEnabled. There's no plan to add them to RawKeyboard.
@garlicPasta I'm not sure what your exact problem is, but can you check if any errors occur in the latest version? (If there's a problem in the stable channel, check out the master channel.)


Suggestion

Wouldn't it make sense to create 3 sub packages, something like
Net.Codecrete.QrCodeGenerator.WindowsDrawing
Net.Codecrete.QrCodeGenerator.SkiaSharp
Net.Codecrete.QrCodeGenerator.ImageSharp
they could already have references to the relevant nuget packages they require.
Or is this more of a temporary solution until ImageSharp is out of beta

Thanks for the suggestion. This is indeed a reasonable option, and I've done so in a similar project.
The only aspect I'm a unsure about is if most people use the library for plain QR codes (quadratic pixels, foreground and background color). Then these sub packages make sense. Or if they create fancy QR codes with modified pixel shapes, color gradients, images in the center etc. Then the packages are less useful as the code needs to be modified anyway.
I will certainly consider it.

PS, to be clear, I added both SkiaSharp and SkiaSharp.NativeAssets.Linux, since I needed it to work on windows and linux


runtime: make([]byte, n) becomes much slower compared with go 1.11.1

What version of Go are you using (go version)?
go version devel +2e9f081 Tue Oct 30 04:39:53 2018 +0000 linux/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/lni/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/lni/golang_ws"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build682632202=/tmp/go-build -gno-record-gcc-switches"
What did you do?
I tried the devel version of go for both devel +80b8377 and devel +2e9f081, my go program became slower.  When checking the benchmarks, I noticed that make([]byte, n) accessed in parallel is much slower when compared to go 1.11.1
package makebenchmark

import (
  "testing"
)

func benchmarkMakeByteSliceInParalell(b *testing.B, sz int) {
  b.RunParallel(func(pb *testing.PB) {
    for pb.Next() {
      m := make([]byte, sz)
      if len(m) != sz {
        b.Errorf("unexpected len")
      }
    }
  })
}

func BenchmarkMakeByteSliceInParalell512(b *testing.B) {
  benchmarkMakeByteSliceInParalell(b, 512)
}

func BenchmarkMakeByteSliceInParalell8(b *testing.B) {
  benchmarkMakeByteSliceInParalell(b, 8)
}

go 1.11.1:
go test -count=1 -v   -benchmem -run ^$ -bench=BenchmarkMakeByteSliceInParalell
goos: linux
goarch: amd64
pkg: github.com/lni/goplayground/makebenchmark
BenchmarkMakeByteSliceInParalell512-40    	10000000	       239 ns/op	     512 B/op	       1 allocs/op
BenchmarkMakeByteSliceInParalell8-40      	300000000	         4.08 ns/op	       8 B/op	       1 allocs/op
PASS

go version
go version go1.11.1 linux/amd64

go version devel +2e9f081  and devel +80b8377 reported similar results
/home/lni/src/go/bin/go test -count=1 -v   -benchmem -run ^$ -bench=BenchmarkMakeByteSliceInParalell
goos: linux
goarch: amd64
pkg: github.com/lni/goplayground/makebenchmark
BenchmarkMakeByteSliceInParalell512-40    	 3000000	       564 ns/op	     512 B/op	       1 allocs/op
BenchmarkMakeByteSliceInParalell8-40      	300000000	         5.09 ns/op	       8 B/op	       1 allocs/op
PASS

/home/lni/src/go/bin/go version
go version devel +2e9f081 Tue Oct 30 04:39:53 2018 +0000 linux/amd64

What did you expect to see?
make([]byte, n) has similar ns/op when compared with 1.11.1
What did you see instead?
make([]byte, n) is much slower

A git bisect would be very helpful.
Also, for reference the actual commit links for  2e9f081  and 80b8377.

/cc @mknyszek @aclements

also noticed that 9108ae7 made make([]byte, 512) slower as well. not sure whether it is a feature or a bug  ;)
/home/lni/src/go/bin/go test -bench .
goos: linux
goarch: amd64
pkg: github.com/lni/goplayground/makebenchmark
BenchmarkMakeByteSliceInParalell512-40    	10000000	       241 ns/op
BenchmarkMakeByteSliceInParalell8-40      	500000000	         4.00 ns/op
PASS
ok  	github.com/lni/goplayground/makebenchmark	5.013s

/home/lni/src/go/bin/go version
go version devel +a2a2901 Tue Oct 2 20:35:19 2018 +0000 linux/amd64

/home/lni/src/go/bin/go test -bench .
goos: linux
goarch: amd64
pkg: github.com/lni/goplayground/makebenchmark
BenchmarkMakeByteSliceInParalell512-40    	 5000000	       308 ns/op
BenchmarkMakeByteSliceInParalell8-40      	300000000	         4.07 ns/op
PASS
ok  	github.com/lni/goplayground/makebenchmark	3.476s

/home/lni/src/go/bin/go version
go version devel +9108ae7 Tue Oct 2 20:35:20 2018 +0000 linux/amd64

Thank you @reusee for the biest !

There were also some changes to runtime.makeslice. Modifying the benchmark to do no allocation in runtime.mallocgc shows the expected speed-up between go1.11.1 and tip. So its likely the slowdown to originates in runtime.mallocgc or below.
var LenVar = 0

func BenchmarkMakeSliceCallInParalell(b *testing.B) {
	b.RunParallel(func(pb *testing.PB) {
		for pb.Next() {
			m := make([]byte, LenVar)
			if len(m) != LenVar {
				b.Errorf("unexpected len")
			}
		}
	})
}

name                       old time/op  new time/op  delta
MakeSliceCallInParalell-4  3.50ns ± 5%  3.24ns ±10%  -7.35%  (p=0.000 n=17+20)

only see a smaller slow down for 512byte and speedup for 8byte on my laptop 2-core/4-thread for go1.11.1 vs go tip. So it is likely easier detectable with higher thread counts:
name                          old time/op    new time/op    delta
MakeByteSliceInParalell512-4     101ns ± 4%     118ns ± 7%  +16.54%  (p=0.000 n=19+19)
MakeByteSliceInParalell8-4      11.0ns ±18%    10.4ns ±15%   -5.50%  (p=0.003 n=18+18)

As reusee@ sleuthed out, it's probably my commit (07e738e). Thank you everyone for looking into this.
I took some time to dig in and understand exactly what was going on. This benchmark exercises the case where we're allocating size-segregated spans with object size 512, which we then free, and re-allocate from. At first, I thought that the regression might have been the result of span allocation having to traverse the treap, instead of walking over a fixed-size array. But, CPU profiling shows that it's more likely a result of freeing spans. Before my change, freeing these size-segregated spans was a very fast operation: indexing into an array followed by a linked list insertion at head. Now, one needs to traverse a treap, allocate a treap node out of a SLAB, and rebalance it. While all of these operations should be reasonably fast, it's definitely more work than what was being done before. I think the regression in performance we see as a result of a higher GOMAXPROCS arises out of the fact that the heap lock is held when a span is freed, and my change causes this benchmark to spend more time holding the heap lock.
So, for a microbenchmark like this which really hammers on the GC and the allocator, it makes sense to me why my change had such an impact.  I quickly ran github.com/dr2chase/bent (which runs a number of benchmarks from actual Go programs in the wild) with my change and without it and I haven't yet seen any significant change there either. However, I will run those benchmarks with more iterations and report back with actual numbers.
The motivation behind my change was that it really simplified a number of changes I just landed today for #14045. I'm erring on the side that it was worth it, as it seems as though in practice the performance impact of my change appears to be relatively small.

Here are the numbers I promised: https://perf.golang.org/search?q=upload:20181031.2
The "before" is e508a5f072 (my commit's parent) and the "after" is 07e738ec32 (my commit).

@mknyszek , thanks for the above benchmark results and the explanation on 07e738ec32
I had a quick look at those numbers, it seems that they were probably generated using small GOMAXPROCS value (8)?
Below is the throughput results (in million ops/sec) of my library, I tried 4 different go versions and report the results of three runs. Sadly the library is not open sourced yet so I fully understand that these numbers are probably not very convincing/useful - just another data point to demonstrate the problem I am facing.
84b96c21
6.18, 6.12, 6.14
07e738e
6.26, 6.21, 6.23
e508a5f072
6.66, 6.46, 6.48
go 1.11.1
6.70, 6.57, 6.54
Given that freeing spans are now more expensive, I am trying to further reduce my allocations. It is not always easy as some of them are caused in code auto generated by 3rd party libraries, e.g. Colfer in my case. I just have the feeling that now users have to pay more attention to all allocations.

Yeah GOMAXPROCS was at 8, and that's a good point. I've re-run the benchmarks with GOMAXPROCS=32. https://perf.golang.org/search?q=upload:20181102.1 The performance does indeed degrade, but not by that much.
Thanks for sharing some of your numbers, and for letting me know it's impacting your application/library directly. Would you be willing to share a GC trace for each of the 4 revisions? (GODEBUG=gctrace=1)

@lni do you mind trying out this patch with your application/library? (https://go-review.googlesource.com/c/go/+/151538)
The original numbers are a little harder to reproduce now as it seems other runtime/compiler improvements are hiding the original performance regression a little bit, but in some preliminary benchmarking it looked like the change above helped with your original benchmark.
I still need to start some longer runs for better statistical significance so I'll update here with those soon.

@mknyszek , thanks for the patch!
I didn't tag my library used for those initial benchmarks, my bad. Using the latest version of my library and slightly different configurations, I tried it on the following 3 Go revisions. Results below are in million op/sec.
It seems to me that the patch improved its performance.
go1.11.2
8.85, 8.72, 8.78
3ed46a7   (the new patch)
8.70, 8.74, 8.78, 8.88, 8.78, 8.79
57c8eb9    (before the patch)
8.45, 8.81, 8.37, 8.49, 8.66, 8.78

@mknyszek / @lni / @aclements can this be closed now? The regression fix for the real world usage has been merged.
The issue seems to be understood well enough that the fix for the GC is correct and confirmed.
Also the effect of the regression was about GC and neither the compiler nor slice support of the runtime was causing it.

Yeah closing this probably makes sense at this point. @lni feel free to reopen if you're still seeing issues for Go 1.11 -> Go 1.12, or a new bug if you're seeing problems with Go 1.13.


High Level Tweak for Nukes, Napalm, Clusterbombs

Disables the use of Nukes, Napalm, Clusterbombs on Spawners on Levels >10000
Burn and Bomb Bosses instead on Levels >10000

This can also be considered tested on 4.9.0 is flawless and closes #284, #291 and perhaps #264

This is unnecessary now.


Mac OS 10.12

Hi, I have configured my VPN Gateway for P2S with RADIUS authentication.  My Windows clients are successfully able to authenticate and they get access to the resources on the Azure VNet.
However, my Mac clients are not able to.  I have IKEv2 enabled on the Gateway and I've installed the mobileconfig file.   When I click connect the profile just bounces up to the top.   Can anyone provide some troubleshooting steps or a log file I can look at on the Mac?   I've tailed the system.log but don't see anything there.    Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b6b0c96-9319-59ac-4756-b0fd5e419051
Version Independent ID: 5d27c030-3f19-d737-9a18-5f2b0bca9b46
Content
Content Source
Service: vpn-gateway

Thanks for your feedback. We will investigate and update on it soon.

@timmayg This will require some deeper analysis. Can you please file a support request @
https://aka.ms/azsupt? If you do not have access to a support plan, please reach out<EMAIL_ADDRESS>with a link to this Doc/Issue as well as your subscription ID and we can help get the support ticket opened for this issue.

@amanarneja,  I've opened a case with Azure support.  The engineer was helpful with following the directions in the doc but that's it.
When using Wireshark I can see the Mac sending ISAKMP traffic to my VPN Gateway but the tunnel does not come up.   Please see this screen shot.
https://www.dropbox.com/s/kg8n6p1j8hhhvmq/wireshark-1.jpg?dl=0
Thanks for any troubleshooting help you can provide!
Tim


Vendor information is missing in lint definition

Describe the bug
A clear and concise description of what the bug is.
This library is build with older version of dependencies. New versions needs vendor information.
com.kozaxinan.android.checks.IssueRegistry in /Users/t.cunha/.gradle/caches/transforms-3/0d3624e1c094ac0508235e5f7173dfee/transformed/android-lints-0.5.1/jars/lint.jar does not specify a vendor; see IssueRegistry#vendor
Expected behavior
A clear and concise description of what you expected to happen.
Release a new version of the library with up to date dependencies.

Fixed in 0.6 release.


fix: generation of release notes

Test Plan

How do we know the code works?

Release notes are generated for the next release.
What is missing in the previous PR is that tags are not fetched by default on Github Actions

Codecov Report

Merging #1005 into master will decrease coverage by 0.85%.
The diff coverage is 56.29%.

@@             Coverage Diff              @@
##             master    #1005      +/-   ##
============================================
- Coverage     81.71%   80.86%   -0.86%
- Complexity      687      698      +11
============================================
  Files           212      219       +7
  Lines          3845     3976     +131
  Branches        586      606      +20
============================================
+ Hits           3142     3215      +73
- Misses          393      446      +53
- Partials        310      315       +5


How did you make it real-time?

Hey, nice work; I wanted to know how you made it in real time. Did you try converting the model to onnx format?

Thanks!
The mask generating capability of the model is already real time, there aren't any significant optimizations in this repo (yet).
This is part of the original SAM model design and is possible because the image encoding and mask generating happen on separate models. The image encoding is slow, but only happens once on start-up, whereas the mask generating (and prompt encoding) is fast and can run in real time on every change to the input prompts (i.e. can update to match mouse hovering).
I haven't tried exporting to onnx yet, since I still need to clean up some of the model implementation details. However, I do plan to make an export script in the near future.
For now, if you wanted onnx versions, you can create them with code like:
import torch
from lib.make_sam import make_sam_from_state_dict

# Export the image-encoder component of SAM
_, sammodel = make_sam_from_state_dict("/path/to/model.pt")
torch.onnx.export(
    model=sammodel.image_encoder,
    args=torch.randn((1, 3, 1024, 1024), dtype=torch.float32),
    f="sam_image_encoder.onnx",
    input_names=["input"],
    output_names=["output"],
    export_params=True,
    do_constant_folding=True,
    opset_version=14,
)

This just creates an onnx version of the image encoder (not the whole model), and it currently gives a bunch of warnings, but it is usable. You can test the onnx model with code like:
import cv2
import numpy as np
import onnxruntime

# Load image, size to 1024x1024 and convert to RGB
img_bgr = cv2.imread("/path/to/image.jpg")
img_onnx = cv2.resize(img_bgr, dsize=(1024, 1024))
img_onnx = cv2.cvtColor(img_onnx, cv2.COLOR_BGR2RGB)

# Apply model RGB normalization make shape: 1x3x1024x1024
mean_std = np.float32([58.395, 57.12, 57.375])
mean_rgb = np.float32([123.675, 116.28, 103.53])
img_onnx = (np.float32(img_onnx) - mean_rgb) / mean_std
img_onnx = img_onnx.swapaxes(0, 2)[None, :]
onnx_input = {"input": img_onnx}

# Run the onnx model
ort_session = onnxruntime.InferenceSession("sam_image_encoder.onnx")
onnx_output = ort_session.run(None, onnx_input)
print("Num outputs:", len(onnx_output))
print("Example output shape:", onnx_output[0].shape, "DType:", onnx_output[0].dtype)

At some point I'll make a more convenient version that builds the image pre-processing directly into the model and have exports for other model components.

Thank you so much for the detailed answer. @heyoeyo

Hey, @heyoeyo, btw, the above code works for both, right? SAM1 and SAM2?

Yes, the image encoder of both SAM v1 & v2 take the same inputs and the make_sam_from_state_dict function will figure out which version (and size) to load based on the model weights that are given, so the code should work for either version and any size model.
However, the outputs of the v1 & v2 models are different. V1 outputs a single tensor, while v2 outputs a list of 3 differently sized tensors (and 3 positional embeddings, though I'll be removing that in a future update). So the resulting onnx models are not interchangeable.


Statuses/Errors structure for specific objects accessed direclty

I think I will never see the error, we had a little discussion with @faboweb about this, I'll open an issue where we can develop
Here the loaded status is shared across getProposals and getProposal, when you access a proposal that proposalId is going to the proposals dictionary, but loading, loaded and error are promiscuous, same happen for transactions etc..
We were thinking of changing the priority in TmPage so error rule, and error in this case should not come from proposals.error but from either:

proposals.statuses[proposalId] if we want a structure with {loading, loaded, error}
proposals.errors[proposalId] if we want to store just errors

All this apply only to proposals that got accessed directly from URL, the others won't mind, they are already in the store thanks to getProposals and adding a bunch of true false null for every proposal scanned is not really useful I think, so we should expect those flags to be also undefined in case of succesfully fetched proposals
This shuold be generic so we can replace the word proposal with transaction etc..
Originally posted by @sabau in https://github.com/cosmos/voyager/pull/2066/review_comment/create

yes, you are correct. right now, users will not see this error. we need to use the error properties per module and per item to trigger the proper in-app-error components (instead of notify). same applies for loading.
i would consider this fairly high priority, as this has a huge impact on user experience and usability.

relates to #2121

We also need a global error:
as there might be an issue with "loading all txs" and "loading one tx"

My opinion is that an item with an error or on loading state shouldn't prevent you form accessing others.
This discussion from which option should we use needs to be done per module, for some might not be important to have all the individual statuses

This discussion from which option should we use needs to be done per module

I would rather have a standard so thinking about modules is easier and accessing them from the components is easier.

This shuold be generic so we can replace the word proposal with transaction etc..

items

Maybe we don't need the states if we use a modern connection library like GraphQL