Support for GET option in SET command

Are there any plans for adding support for new GET option in SET command?
It was added in redis version 6.2.
Documentation link.

Hey @iatsiuk , have you tried redis.set('foo', 'bar', 'GET')? It should work as expected as long as the server is >= 6.2.

Hi @luin , here is my test code:
`
const Redis = require("ioredis");
const client = new Redis("localhost:16379");
(async () => {
const info = await client.info();
console.log(info.match(/redis_version.+$/m)[0]);
await client.set("foo", "bar", "PX", 100, "NX", "GET");
})();
`
Here is my output:
`
% node ./index.js
redis_version:6.2.2
/Users/me/Devzone/redis-test-get/node_modules/redis-parser/lib/parser.js:179
return new ReplyError(string)
^
ReplyError: ERR syntax error
at parseError (/Users/me/Devzone/redis-test-get/node_modules/redis-parser/lib/parser.js:179:12)
at parseType (/Users/me/Devzone/redis-test-get/node_modules/redis-parser/lib/parser.js:302:14) {
command: { name: 'set', args: [ 'foo', 'bar', 'PX', '100', 'NX', 'GET' ] }
}
`
Am I miss something?

I think the reason is just the syntax is not accepted by Redis. ioredis doesn't do any magic things but just pass arguments to Redis directly. You may want to try on redis-cli first to confirm whether the syntax is correct or not. Remove PX and NX works for me.

Looks like combination of options NX and GET are not allowed.
<IP_ADDRESS>:6379> set foo1 bar PX 500 NX
OK
<IP_ADDRESS>:6379> set foo1 bar PX 500 XX GET
(nil)
<IP_ADDRESS>:6379> set foo1 bar PX 500 NX GET
(error) ERR syntax error
<IP_ADDRESS>:6379>

Thanks for your help!


sensor stats endpoint

Description
Added sensors//stats api endpoint
Look & Feel
You should start getting smth like this when requesting http://localhost:5000/api/v3_0/sensors/{sensor_id}/stats
{   "max_event_start": "Thu, 27 Jun 2024 21:00:00 GMT",   "max_value": 18.0,   "mean_value": 10.104166666666666,   "min_event_start": "Thu, 04 Apr 2024 22:00:00 GMT",   "min_value": 4.0,   "status": 200,   "sum_values": 2425.0 }
How to test
Go to stats page for some sensor, check you get response like from above
Further Improvements

Related Items

[x] I agree to contribute to the project under Apache 2 License.
[x] To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

I believe we could add the number of values as well?

@nhoening I'm not able to merge this PR, so you would need to merge it.


Custom Dimensions and metrics in one dispatch

Thanks for fantastic work!
Is there any way to send the custom dimension and custom metrics in on dispatch??

Hi @zsajjad. This is currently not supported. A lot of extra methods have been PR'd in to support crazy ways of sending custom dimenions/metrics in the same call as other things.
Honestly, if I had the time, I'd deprecate those old methods, and write a new API to allow the custom stuff be sent alongside whatever else you may want to track. Ref. #65


iOS scrollbars should briefly show when page appears

To match native iOS behaviour, scrollbars should briefly appear to indicate to the user that the content is scrollable.
You can see this behaviour in native iOS settings app:

Use case
When navigating to a new page, iOS has for as long as I remember (possibly since v1?) briefly flashed the scrollbar to the user can clearly see the content is overflowing and scrollable. It also gives a hint as to how much content is hidden.
Proposal
When navigating to a new page, a primary scroll view with a CupertinoScrollbar should briefly show the scroll indicator. This should also happen when coming back from another page.
I'd argue scrollbars should do this by default, but developers should at least have a way of doing this.

Very interesting. Didn't know this was a thing. Will take a look.

Something like this should be called upon appearance: https://github.com/flutter/flutter/blob/4acc79025219363661f321efa1630207215330da/packages/flutter/lib/src/cupertino/scrollbar.dart#L327


Record stable build operation interfaces in trace

We currently store only implementation class names for the details and the result of a build operation.
https://github.com/gradle/gradle/blob/856ee7e72f068029cdf37f98d2b5c126f6e60d06/platforms/core-runtime/build-operations-trace/src/main/java/org/gradle/internal/operations/trace/SerializedOperationStart.java#L45
As a result

Types recorded as part of the trace are not stable even when there is a stable build operation they represent
When checking for the presence of a build operation by type we have to resort to loading the classes (and it breaks when the implementation class is no longer available)

Large number of build operations are stable, but tracing and the fixtures around it are not taking advantage of that.
We have fragile and not trivial to discover pieces of code like this:
https://github.com/gradle/gradle/blob/2e1738412275cda3f16d078f0d6cbeb3e1e1fccf/testing/smoke-test/src/smokeTest/groovy/org/gradle/smoketests/SmokeTestGradleRunner.groovy#L92-L98

Related to this, it seems for a long time we wanted to make running build operations in a more type-safe manner. This might be a required step to address this issue so that there is a link between the instances of details/result and the BuildOperationType they relate to
https://github.com/gradle/gradle/blob/95f7a9b437297353ae9cd7b3e8cfde215f8dcf8b/platforms/core-runtime/build-operations/src/main/java/org/gradle/internal/operations/BuildOperationType.java#L25-L26


Remake typographic scale [Feature]

The typographic scale is currently too restrictive and not enabled for REM sizing. This is a new one.
The scale here is proposed to enable 3 sizes at each tag with improved flexibility, responsiveness and accessibility
No other options needed

As per meeting discussion y
Step 1:

Add the typographic scale to the theme file

--admiralty-font-size--3: 0.688rem;
--admiralty-font-size--2: 0.75rem;
--admiralty-font-size--1: 0.875rem;
--admiralty-font-size-0: 1rem;
--admiralty-font-size-1: 1.375rem;
--admiralty-font-size-2: 1.5rem;
--admiralty-font-size-3: 1.75rem;
--admiralty-font-size-4: 2rem;
--admiralty-font-size-5: 2.25rem;
--admiralty-font-size-6: 2.75rem;
--admiarlty-font-size-7: 3.5rem;

Step 2:

Add the typographic scales to everything in the design system providing override varaibles

font-size: var(--admiratly-expansion-heading-font-size, var(--admiralty-font-size-2));

Step 3:

Do the same as above for colours as we missed it out

background-color: var(--admiralty-button-background-colour, var(--admiralty-colour-primary));

Step 4:

Repeat Step 1 and 2 for font weights

--admiralty-font-weight-normal: 300;
--admiralty-font-weight-medium: 400;
--admiralty-font-weight-bold: 700;

font-weight: var(--admiralty-expansion-heading-font-weight, var(--admiralty-font-weight-medium));

Okay Ignore Step 3, Step 3 should be a separate issue

PR: Feat: Remake typographic scale

Fixed by #286


Weird code snipet in preprocess.md

Describe the bug
Hi, may I know what this means in preprocess.md ? It doesn't show anything on my terminal and I couldn't get it. (I guess there is no sd command either?)

It works for me. What are you trying to achieve , this is just a sample/example file.


Fix Git subscription for Helm charts with no git path subscription annotation defined or the git path is the current repo

Signed-off-by: Mike Ng<EMAIL_ADDRESS>

/lgtm

The e2e is failing because the hub and managed cluster setup by registration operator makefile contains a manifestwork controller or an invalid manifestwork crd that doesn't handle delete properly. Will have to wait for foundation team to take a look.

/lgtm


No module named 'kantts'

from modelscope.pipelines import pipeline
from modelscope.utils.constant import Tasks
p = pipeline('text-to-speech', 'damo/speech_ptts_autolabel_16k')
`raceback (most recent call last):
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/utils/import_utils.py", line 433, in _get_module
return importlib.import_module('.' + module_name, self.name)
File "/root/miniconda3/envs/modelscope/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/models/audio/tts/sambert_hifi.py", line 27, in
from .voice import Voice
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/models/audio/tts/voice.py", line 13, in
from kantts.datasets.dataset import get_am_datasets, get_voc_datasets
ModuleNotFoundError: No module named 'kantts'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "", line 1, in
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/pipelines/builder.py", line 140, in pipeline
return build_pipeline(cfg, task_name=task)
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/pipelines/builder.py", line 56, in build_pipeline
return build_from_cfg(
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/utils/registry.py", line 184, in build_from_cfg
LazyImportModule.import_module(sig)
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/utils/import_utils.py", line 457, in import_module
importlib.import_module(module_name)
File "/root/miniconda3/envs/modelscope/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/pipelines/audio/text_to_speech_pipeline.py", line 9, in
from modelscope.models.audio.tts import SambertHifigan
File "", line 1075, in _handle_fromlist
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/utils/import_utils.py", line 416, in getattr
module = self._get_module(self._class_to_module[name])
File "/root/miniconda3/envs/modelscope/lib/python3.10/site-packages/modelscope/utils/import_utils.py", line 435, in _get_module
raise RuntimeError(
RuntimeError: Failed to import modelscope.models.audio.tts.sambert_hifi because of the following error (look up to see its traceback):
No module named 'kantts'`

I met the same problem, how to solve it?  orz

I met the same problem, how to solve it? orz

try   pip install kantts -f https://modelscope.oss-cn-beijing.aliyuncs.com/releases/repo.html


Bare bones for differential fuzzing

What was wrong?
Needs fuzzing of contracts.
How was it fixed?
It consists of the fuzzing setup for the erc20.fe and erc20.sol and has the rearrangements for the compiler tests as an independent directory to avoid circular dependency and it will also decrease the test execution time as it doesn't require rebuilding the dependencies again.
To run the fuzzer - cd fuzz && cargo +nightly fuzz run erc20_target --features solc-backend
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

Codecov Report

Merging #421 (94298fd) into master (ddd4f0a) will decrease coverage by 0.08%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   86.32%   86.23%   -0.09%
==========================================
  Files          68       69       +1
  Lines        4109     4380     +271
==========================================
+ Hits         3547     3777     +230
- Misses        562      603      +41

Impacted Files
Coverage Δ

test-utils/src/lib.rs
85.23% <88.88%> (ø)

compiler/src/lowering/names.rs
70.96% <0.00%> (-3.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd4f0a...94298fd. Read the comment docs.

ohh sorry @sbillig I should have mention this in the readme. It only works with the feature flag i.e solc-backend

Ha! Somehow I didn't think of that, despite using --all-features all day long to run other tests. Thanks.


Gravity compensated on the gripper but not in the objects

Good morning:
First of all, congratulations on your amazing work.
I'm trying to create a new simulation with a new gripper and I read on your thesis that "Gravity is compensated on the gripper, but not the objects.". I've taken a look at the codes but I'm not able to fully understand how you are doing it.
Could you provide some insights on it?
Thanks a lot.
Ignacio

This means that gravity is not acting on the gripper.  But the gravity is acting on the objects. I think in the code I simply command position of the gripper in the 3d space. Nothing extra is done.


DRAFT PR : Undo/Redo Feature

Motivation
The Undo/Redo feature is intended for users to revert or bring back changes made to their EIP flow diagrams. The reason this was implemented was for user usability and more freedom with manipulating the graph.
Details
Added the Zundo library to implement the undo/redo features
added undo / redo buttons
added the temporal middleware to the appstore and partialized it to only track certain state variables.
created a useTemporalStore object to access the zundo features.
Tested
created flow diagrams and undo/redoed the state in order to see proper use of functionality.
Image of the new undo/redo buttons

Bugs
When redoing a layout orientation change the graph moves to the original location but the screen doesn't update to fit the view.

It seems that new external libraries are being used, but the package.json is unchanged. Did you add them with npm install?

Also, it would be good if we could map the undo/redo actions to the standard keyboard keys (Ctrl+Z and Ctrl+Shift+Z).

I'm still seeing a bunch of typescript errors. Did you try running the linter?
npm run lint

To fix the linting issue when ignoring fields from the Node object , you can add the following rule at the end of the rules object in .eslintrc.cjs:
diff --git a/ui/.eslintrc.cjs b/ui/.eslintrc.cjs
index 57ed21a..9ee680d 100644
--- a/ui/.eslintrc.cjs
+++ b/ui/.eslintrc.cjs
@@ -27,6 +27,18 @@ module.exports = {
       { allowConstantExport: true },
     ],
     "@typescript-eslint/switch-exhaustiveness-check": "error",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        "args": "all",
+        "argsIgnorePattern": "^_",
+        "caughtErrors": "all",
+        "caughtErrorsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "ignoreRestSiblings": true
+      }
+    ]
   },
   settings: {
     react: {


Disabled output formats are still used when extension is specified

For example, disabling XML output in the Admin console does not prevent XML from being output on requesting http://api.frapi/resource.xml
Not sure if this should return the default format or 404.

This should be a 412 Precondition Failed; the same as when we cannot satisfy the Accept header — given that we're using the extensions as a poor mans Accept header.
Using a 404 for something like: /resource/:id.xml makes it awkward to figure out if :id is not found, or if the format is not found.

agreed - 412 it is.


IPv6 Support

Are there any plans to Support IPv6 tunneling?

Hi.
It's not something I'm currently looking at, but I'm happy to accept pull requests if it's something you'd consider working on.

Okay, I was already considering implementing it. However, I cannot make a promise to when I'll have the time to do so.


UserAccountsDrawerHeader.otherAccountsPictures touch target too small

Touch targets for the secondary accounts displayed in the top right of the UserAccountsDrawerHeader are too small. They are 40x40, but should be 48x48.

Fixed by https://github.com/flutter/flutter/pull/20266


"How to: Distribute code snippets" - wrong path in HelloWorldVB.pkgdef

The document instructs to put in HelloWorldVB.pkgdef file following content
// Visual Basic
[$RootKey$\Languages\CodeExpansions\Basic\Paths]
"HelloWorldVB"="$PackageFolder$"

The problem is that than the selection the path from snippet selection menu is 1.0/HelloWorldVB/...

The content of the file should be
// Visual Basic
[$RootKey$\Languages\CodeExpansions\Basic\Paths]
"HelloWorldVB"="$PackageFolder$\HelloWorldVB"

(the HelloWorldVB text is added to the string) and when this content is used the path from snippet selection menu is HelloWorldVB/...

The idea is taken from:
https://github.com/madskristensen/HtmlSnippetPack/blob/master/src/Snippets/snippets.pkgdef

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c60cdeb-c3af-ebb1-80e7-1ec682896734
Version Independent ID: 04010067-02f9-548e-467b-fa4efa391860
Content: Distribute code snippets as an extension - Visual Studio (Windows)
Content Source: docs/ide/how-to-distribute-code-snippets.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@TerryGLee -- Terry, please review this update in private PR 9635.

By my opinion the wrong content is still present on the page Add the .pkgdef file

@TPIvan -- thank you for your followup.  I am updating this article.


Run-time error with bad ipfs path input

 IpfsPath::from_str("\u{0}\u{1}U\u{0}\u{1}\u{0}/+") should return Err instead of Ok and the current behavior makes posterior  operations panic at run-time because of wrong assumptions.
There are likely to be more bad inputs but this particular one threw "thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: MissingProtocolP2p', src/p2p/swarm.rs:227:69"
use ipfs::{Ipfs, IpfsPath, TestTypes, UninitializedIpfs};
use std::str::FromStr;
use tokio::task;

#[tokio::main]
async fn main() {
    let path = IpfsPath::from_str("\u{0}\u{1}U\u{0}\u{1}\u{0}/+").unwrap();
    let (ipfs, f): (Ipfs<TestTypes>, _) = UninitializedIpfs::default().await.start().await.unwrap();
    task::spawn(f);
    let _ = ipfs.get_dag(path.sub_path("0").unwrap()).await;
}

That panic is mitigated in https://github.com/rs-ipfs/rust-ipfs/pull/335, though we're not yet 100% sure if we should not solve it some other way (the initial assumption that led to the panic makes sense).

@ljedrz Thanks
The error won't happen in this scenario with #335 so I am going to close this issue for now


Refresh token is null after one usage

Insomnia currently does not maintain the refresh token after its usage, if response for a new access token request does not include one. As in: Refreshing Access Tokens
https://github.com/getinsomnia/insomnia/blob/4a50ad149682f6facd9504d4d3c3732516385f6f/packages/insomnia-app/app/network/o-auth-2/refresh-token.js#L67-L72

I'm not motivated to fork to propose such a little commit... but from what I've read, I think that between lines 76 and 78,
https://github.com/getinsomnia/insomnia/blob/4a50ad149682f6facd9504d4d3c3732516385f6f/packages/insomnia-app/app/network/o-auth-2/refresh-token.js#L75-L78
would just suffice to put a conditional like:
if (results[c.P_REFRESH_TOKEN] === null) {
  results[c.P_REFRESH_TOKEN] = refreshToken;
}

Thanks for reporting this!
I just took a look at the OAuth 2.0 RFC and can confirm that issuing a new refresh token is optional:

The authorization server MAY issue a new refresh token, in which case the client MUST discard the old refresh token and replace it with the new refresh token.  The authorization server MAY revoke the old refresh token after issuing a new refresh token to the client.  If a new refresh token is issued, the refresh token scope MUST be identical to that of the refresh token included by the client in the request.

I'll get this fixed!

WOW! That's what I call a fast response. Thank you for this, Insomnia is awesome!


feat: 1.4.0 release

BREAKING CHANGE a48a238: fix: remove @supabase/ui as dependency. If you are using the Auth component, please make sure to install @supabase/ui separately in your project and import Auth from there. Fixes #39; Fixes #64; Fixes #69;

BREAKING CHANGE ecdc5a2: fix: rename withMiddlewareAuthRequired to withMiddlewareAuth and move it to @supabase/supabase-auth-helpers/nextjs/middleware. Closes #59; Fixes #90

19f53c3: feat: adds withPageAuth [docs] and deprecates withAuthRequired.

8888b41: feat: adds withApiAuth [docs] and deprecates withAuthRequired.

df984d0: fix: automtically refresh tokens. Fixes #72; Fixes #77; Fixes #83; Fixes #84; Fixes #85;

862acf8: fix: refresh token automatically when user is updated. Fixes #62

@mrmartineau you're right, based on https://semver.org/#semantic-versioning-200 this should have been a major version change. sorry about that!


Scripture Forge account signup validation -- link expired

Sorry, your registration link has expired. line 570 /var/www/scriptureforge.org/htdocs/models/commands/UserCommands.php
JsonRpcServer.php line 69, call_user_func_array(Array, Array)

old issue.  User needed to re-validate email.  Email validation is now "secondary" to sign-up.


fixing typos in samples

bors r+

bors r+

bors r+

I've rebooted the system that caused the last test hang. Really odd.

@dmitsh 🎉


Add string interpolation

Closes #1073

This is gonna be harder in Myxal

It can still be used as a second character, like ∑Π, but it's not currently used as a first character. I will remove that

But that's gonna be a pain to change to make it never be used as a first character, but still as a second to not break old code. The dictionary probably won't be changed in v2 to be big enough to use Π anyway...


Support set query string.

Fixed #31
Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling e1f9223de6aafc3e729d3cb412f4170f14d4a2b1 on query into 94499e3cbaae6b93ca0e39f44100effb80eb69d2 on master.

[Current coverage][cc-pull] is 100% (diff: 100%)

Merging [#32][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #32   diff @@
===================================
  Files           1     1
  Lines         107   116     +9
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits          107   116     +9
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update [94499e3...9ced11f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/appleboy/gofight/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/appleboy/gofight/compare/94499e3cbaae6b93ca0e39f44100effb80eb69d2...9ced11f201c4f7a2a45c7b98d2b8789535ac9f27?src=pr
[cc-pull]: https://codecov.io/gh/appleboy/gofight/pull/32?src=pr

Coverage remained the same at 100.0% when pulling 6336a52177a07d98e0d63ed1f09614712a3f106c on query into 94499e3cbaae6b93ca0e39f44100effb80eb69d2 on master.

Coverage remained the same at 100.0% when pulling 73b702895e08f641c643cb8f6bd48559ff4960de on query into 94499e3cbaae6b93ca0e39f44100effb80eb69d2 on master.


To enable an entity for SLA

The instructions to enable an entity for SLA is confusing and incomplete.  There are now two ways to enable SLAs.  One is thru the legacy UI (from 2010-ish) and the other is through the Power Apps UI.  This content should be updated to reflect the more recent/modern experience.  There should be screenshots to assist.

Make sure that you have the System Administrator or System Customizer security role or equivalent permissions.  << This link is for on-premises and isn't appropriate for these instructions.

Go to Settings > Customizations. >> WHERE?  Is this in an App?  This is where a screenshot would help, as it is referencing the legacy UI, which not everyone is familiar with.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a11842df-d11e-8f73-760b-bcbc78f525da
Version Independent ID: 4aa43482-3bd3-8ca9-0d32-81c499fd47a0
Content: Enable entities for service level agreements (Dynamics 365 Customer Service)
Content Source: ce/customer-service/enable-entities-service-level-agreements.md
Service: dynamics-365-customerservice
GitHub Login: @Soumyasd27
Microsoft Alias: sdas

Thanks for your comment, @KittyDreadful. This issue has been assigned to the doc author for review.

@KittyDreadful : The Enable entities for service level agreements (Dynamics 365 Customer Service) topic has been updated with the latest information. Closing the issue.


acl_add always skipped due to only_if

Hi!
I was trying to add permission to my certificate key file using this:
windows_certificate certificate_thumbprint do private_key_acl ['NT AUTHORITY\NETWORK SERVICE'] action :acl_add end
The permissions were never added. I noticed in the log that the action to set permissions was being skipped due to only_if.
I am new to ruby and new to chef but in action :acl_add do this does not seem right:
code_script = guard_script = ''
if your then setting guard_script like this:
guard_script << cert_exists_script(hash)
Actually I also don't understand how only_if guard_script could possibly work. I would love to fix this myself but as I said I am not sure what I am doing.
As a workaround from myself I am removing only_if altogether

Here is what that resource does: if certificate_thumbprint is an existing file path:
if ::File.exist?(new_resource.source)
It creates an X509Certificate and adds it to the node's certificate store
code_script = guard_script = cert_script(false)
If it is not an existing file, it is assumed to be a thumbprint of an existing certificate and the guard script then just ensures that the cert is present:
def cert_exists_script(hash)
  <<-EOH
$hash = #{hash}
Test-Path<EMAIL_ADDRESS>EOH
end

I'm betting that your issue is related to the fact that you are missing a store_name attribute. So it looks in the root where I'm pretty sure it will never find them.
Try adding the store_name and if things still do not work try validating on the node by running:
Test-Path Cert:\LocalMachine\<store name>\<thumbprint>

If things work, I'd say the bug here is bad (no) error messaging. And the fix would be to add some more validation and useful messaging.
So report back and I'd be happy to point you in the right direction to add that if you were interested or make sure it happens on my end.

I validated all powershell scripts and they all return what is expected.
Actually if you do this in this sequence (which is what happens when you specify a thumbprint):

code_script = guard_script = ''
code_script << acl_script(hash)
guard_script << cert_exists_script(hash)

Because of that first assignment, guard_script will be a concatenation of '' + acl_script + code_exists_script.
Also I don't know how only_if  will work anyway... Shouldn't it be ruby code there?

That's actually the code that runs if a file path is given and not a thumbprint. Guards can have different interpreters and powershell is the default interpreter for the powershell_script resource.
If you are passing a thumbprint, the guard will not coverage the resource if it can't find the cert in the store.

Thanks for the explanation!
I reverted back my workaround and I can no longer reproduce the issue. I am puzzled by I see no point in keeping this issue.
Thanks again!

I got to reproduce the problem again when I ran the recipe with chef-client version 11.16.4. I cannot reproduce it with chef-client 12.3.0.
I still think code_script = guard_script = '' should not be used because, event thou it works, this makes the guard_script a concatenation of both code_script and what the guard_script should be. Therefore code_script is being executed twice. Can I propose a fix?

You can absolutely propose a fix, but is that related to this issue? Do you think that is why your acl_add is incorrectly being skipped? I thought you were using a thumbprint.

No. It's something I found during debugging this issue but it is not related to this issue. Closed!


Canalplus extractor

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.05.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
canalplus.com extractor dosent work.
By the way, when I was reading  the code I've noticed that in the extractor(canalplus.py), the _VALID_URL dosent  seem to be ok. For your information, the new domain name of Canalplus is canalplus.com  (the old one mycanal.fr redirect to canalplus.com)
* verbose log edited
Verbose log
[debug] Command-line config: ['-vU', 'https://www.canalplus.com/divertissement/tpmp-week-end-le-beforeemission-du-13-mai-2022/h/17039434_50013?episodeId=18785284_50013']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d52355]
[debug] Python version 3.10.0 (CPython 64bit) - macOS-10.16-x86_64-i386-64bit
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg 5.0.1 (setts), ffprobe 5.0.1
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2020.06.20, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.2
[debug] Proxy map: {}
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [generic] Extracting URL: https://www.canalplus.com/divertissement/tpmp-week-end-le-beforeemission-du-13-mai-2022/h/17039434_50013?episodeId=18785284_50013
[generic] 17039434_50013?episodeId=18785284_50013: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] 17039434_50013?episodeId=18785284_50013: Downloading webpage
[generic] 17039434_50013?episodeId=18785284_50013: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://www.canalplus.com/divertissement/tpmp-week-end-le-beforeemission-du-13-mai-2022/h/17039434_50013?episodeId=18785284_50013
Traceback (most recent call last):
  File "/Users/anass/anaconda3/envs/home_media/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1395, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/anass/anaconda3/envs/home_media/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1465, in __extract_info
    ie_result = ie.extract(url)
  File "/Users/anass/anaconda3/envs/home_media/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 642, in extract
    ie_result = self._real_extract(url)
  File "/Users/anass/anaconda3/envs/home_media/lib/python3.10/site-packages/yt_dlp/extractor/generic.py", line 4031, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.canalplus.com/divertissement/tpmp-week-end-le-beforeemission-du-13-mai-2022/h/17039434_50013?episodeId=18785284_50013

Related / duplicate of #461


IMAP operations get stuck and never time out

Expected behavior

IMAP operations should work
If IMAP operations are having network issues, they should time out in a reasonable time

Actual behavior
Sometimes when I sync the inbox and when I send mail the operations get stuck. Inbox sync seems to eventually time out, although this can take many minutes and very rarely I believe this takes hours. Mail sending is much more prone to not timing out at all, I've just had it sit there trying to send a message for 2.5 hours. The issue is obviously more severe with sending email as my recipient has not received what may well be an important message.
I am running Dovecot on the server end with STARTTLS. I configured Samsung's email client to talk to the same server and it has no network issues - when K-9 gets stuck I open Samsung's email client and it works. I've never had Samsung's client get stuck since I started using it in parallel with K-9 some weeks ago.
Steps to reproduce

Pull down to refresh the inbox

OR

Compose an email
Click send

Environment
K-9 Mail version: 5.203
Android version: 6.0.1
Account type (IMAP, POP3, WebDAV/Exchange): IMAP (Dovecot) with STARTTLS

I have more or less the same problems with k9 version 5.207 (also with the previous versions during at least one year) but only when I'm using my 2g/3g/4g connection. It never occurs with the wifi.
When it occurs, I 'simply' swap out the k9 app from the list of apps, launch k9 again then k9 works normally until the next problem.

This has been ongoing since the first version of k9mail.

I don't really want to add more options to configure connection timeouts. It would be far better just to set some more reasonable values (or indeed any - I suspect it just never does in some scenarios).

A simple button to stop the sync could 'solve' this issue?
When the times seems to be too long, the user could stop the sync and launch it again more later.
The 'stop' button could be the same that the 'sync' button.

FWIW I have not had this issue recently (last several months, I would say).

I always have this very annoying issue (k9 version 5.208).

I've been seeing this for months.  K-9 still has the killer aliases feature that I can't find anywhere else, but getting stuck synchronizing is really obnoxious.  I generally have to either kick the service with:

throw away the app UI
switch to another app
launch K-9 again
hope it loads one more message
repeat the above until it gets unstuck

Or I have to kill the app and service from App Info, and restart it, repeating several times until it gets over the problem.
My email server is Dovecot, if that makes any difference.

This happens on a daily basis, multiple times per day with me.  I'm currently in a weak cell area, and quite literally I have to daily:

open K-9, see it is stuck
go to apps -> k-9 -> force stop
go back to K-9
drag down to re-kick message pull

Quite literally, I must do this 10 or 20 times per day.
Note that even mail clients like Thunderbird support setting a manual limit on a variety of network timeouts...

I have the same issue. It seems to happen more often when on mobile data but also on wifi. I got used to it on my devices that i have to quit K9mail and restart several times per day. But my dad keeps thinking there are no new messages on his android-tablet when in fact it is K9mail that hast decided to stop working again. Is there any way I can help debug this?

@sicherist Install a debug version and use adb to collect the logs https://github.com/k9mail/k-9/wiki/LoggingErrors

I had something that felt like the same issue today as this.  I am using K9 with Dovecot using IMAP.  It turned out Dovecot somehow munged it's cache.  For me, these cache files were inside /home/username/mail/.imap/INBOX/{dovecot.index,dovecot.index.cache}.  Removing these cache files and restarting dovecot worked wonders for me.  There are a few other of these cache files around in .imap/, you might be blocking on one of the other folders.

I had something that felt like the same issue today as this.  I am using K9 with Dovecot using IMAP.  It turned out Dovecot somehow munged it's cache.  For me, these cache files were inside /home/username/mail/.imap/INBOX/{dovecot.index,dovecot.index.cache}.  Removing these cache files and restarting dovecot worked wonders for me.  There are a few other of these cache files around in .imap/, you might be blocking on one of the other folders.

Some here;
Oneplus8, Android 12
K9mail 6.000
When I "Pull down to refresh the inbox", it stays loading for ever. Only interrupted when leaving the app or when the display goes to sleep.
I don't see any connection coming in to the imap server.
Only way to get it work again is by killing the app.
Don't see anything special in the logs;
06-19 09:40:28.083  4800  5362 V ConnectivityManagerApi24$networkCallback: Network available: 4301
06-19 09:40:28.085  4800  5356 V AccountPushController: AccountPushController(5767ade9-ed1d-48e6-9fac-d7e158b6a5bf).reconnect()
06-19 09:40:28.085  4800  5356 V ImapBackendPusher: ImapBackendPusher.reconnect()
06-19 09:40:28.085  4800  5356 V ImapFolderPusher: Stopping ImapFolderPusher for Websluce / INBOX
06-19 09:40:28.085  4800  5356 V RealImapStore: ImapStore.closeAllConnections()
06-19 09:40:28.085  4800  5356 V ImapBackendPusher: ImapBackendPusher.updateFolders(): [INBOX]
06-19 09:40:28.086  4800  5356 V ImapFolderPusher: Starting ImapFolderPusher for Websluce / INBOX
06-19 09:40:28.088  4800  5356 V PushController: PushController.updatePushers()
06-19 09:40:28.089  4800  5356 V PushController: ..Running PushControllers: [5767ade9-ed1d-48e6-9fac-d7e158b6a5bf]
06-19 09:40:28.093  4800 16528 V ImapFolderPusher$start: Starting ImapFolderPusher thread for Websluce / INBOX
06-19 09:40:28.093  4800 16528 V AndroidPowerManager$AndroidWakeLock: AndroidWakeLock for tag ImapFolderPusher-Websluce-INBOX / id 548: Create
06-19 09:40:28.110  4800 16528 V AndroidPowerManager$AndroidWakeLock: AndroidWakeLock for tag ImapFolderPusher-Websluce-INBOX / id 548: acquired with no timeout.
06-19 09:40:28.111  4800  5356 V PushServiceManager: PushServiceManager.start()
06-19 09:40:28.111  4800  5356 V PushServiceManager: ..PushService already running
06-19 09:40:28.111  4800  5356 V BootCompleteManager: Enable BootCompleteReceiver
06-19 09:40:30.982  4800  4808 I com.fsck.k9: Background young concurrent copying GC freed 39846(27MB) AllocSpace objects, 0(0B) LOS objects, 34% free, 31MB/48MB, paused 174us,8.920ms total 43.365ms
06-19 09:40:32.935  4800  4808 W com.fsck.k9: Suspending all threads took: 5.380ms
06-19 09:40:32.951  4800  4808 I com.fsck.k9: Background young concurrent copying GC freed 39322(27MB) AllocSpace objects, 0(0B) LOS objects, 33% free, 32MB/48MB, paused 129us,5.642ms total 30.300ms
06-19 09:40:33.624  4800  4800 V AndroidPowerManager$AndroidWakeLock: AndroidWakeLock for tag K9 MessagingController.checkMail / id 549: Create
06-19 09:40:33.625  4800  4800 V AndroidPowerManager$AndroidWakeLock: AndroidWakeLock for tag K9 MessagingController.checkMail / id 549 for 120000 ms: acquired
06-19 09:40:57.865  4800  4808 W com.fsck.k9: Suspending all threads took: 6.193ms
06-19 09:40:57.875  4800  4808 I com.fsck.k9: Background young concurrent copying GC freed 53376(37MB) AllocSpace objects, 0(0B) LOS objects, 18% free, 45MB/55MB, paused 1.257ms,6.470ms total 40.556ms
06-19 09:41:05.196  4800  4800 I Quality : Skipped: true 3 cost 34.102814 refreshRate 0 processName com.fsck.k9
06-19 09:41:10.984  4800  4800 I Quality : Skipped: true 1 cost 17.047915 refreshRate 0 processName com.fsck.k9
06-19 09:41:25.147  4800  4800 W Choreographer: Frame time is 0.06781 ms in the future!  Check that graphics HAL is generating vsync timestamps using the correct timebase.
06-19 09:41:31.965  4800  4800 I Quality : Skipped: true 2 cost 24.839624 refreshRate 0 processName com.fsck.k9
06-19 09:41:51.462  4800  4800 I Quality : Skipped: true 3 cost 38.63872 refreshRate 0 processName com.fsck.k9
06-19 09:41:53.609  4800  4800 I Quality : Skipped: true 1 cost 17.008505 refreshRate 0 processName com.fsck.k9
06-19 09:42:11.872  4800  4800 W Choreographer: Frame time is 0.004998 ms in the future!  Check that graphics HAL is generating vsync timestamps using the correct timebase.
06-19 09:42:18.492  4800  4800 I Quality : Skipped: true 1 cost 22.494293 refreshRate 0 processName com.fsck.k9
06-19 09:42:38.243  4800  4800 I Quality : Skipped: true 1 cost 30.410984 refreshRate 0 processName com.fsck.k9


Connection error with --json does not return json

It would be really nice if in the case of error, the output was in the format requested.  In particular, when the system can't get the config (because the net connection is down or bad), and I've requested json output, that the result was json.
I looked into the code and was thinking about updating this
    printer('Retrieving speedtest.net configuration...', quiet)
    try:
        speedtest = Speedtest()
    except (ConfigRetrievalError, HTTP_ERRORS):
        printer('Cannot retrieve speedtest configuration')
        raise SpeedtestCLIError(get_exception())

with something like
    printer('Retrieving speedtest.net configuration...', quiet)
    try:
        speedtest = Speedtest()
    except (ConfigRetrievalError, HTTP_ERRORS):
        if machine_format:
            print_error_in_machine_format("Cannot retrieve config")
        else:
            printer('Cannot retrieve speedtest configuration', )
        raise SpeedtestCLIError(get_exception())

Before I go down that road, I thought I'd just see how you felt about a change like that.  It seems like (in the json case), you could add a status or success field field in the reponse that indicated the status and maybe a message field that could be used in the case of error.  I'm not sure how this would go for a csv output.
Any thoughts?  I may try to do a little coding and submit a PR.  But if you have already thought about this, I'd love to hear your thinking so my solution might fit into the project.
Thanks for building the script.

You should be using the exit code to determine success and not store or use the returned data if the exit code is not 0
Should you want more flexibility, I suggest using the python API directly and not calling as a script


[Showcase] Add FingerFrame app

By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Hey, I'm really sorry for the churn, but we are changing up how the showcase works, and just focusing on apps that have some media presence or technical blog posts / other content. So I appreciate the spirit behind this pull request but I think we should close it.

Hi Kevin,
Well, I've worked alone on this app for almost 6 months as a side project
so i was counting on this showcase to get a little media presence
precisely....so I'm just disappointed to not have a chance to get a bit of
exposure. I understand the spirit behind this move but I think you should
do not forget that react native is living because of its passionate
community...
Thanks to send me an explanation on this close anyway.
Best,
Guillaume
On Tue, Jun 21, 2016 at 7:57 PM, Kevin Lacker<EMAIL_ADDRESS>wrote:

Hey, I'm really sorry for the churn, but we are changing up how the
showcase works, and just focusing on apps that have some media presence or
technical blog posts / other content. So I appreciate the spirit behind
this pull request but I think we should close it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/8185#issuecomment-227519863,
or mute the thread
https://github.com/notifications/unsubscribe/ARGNgvrjbToWh9-FKflznKKMW94fRiQFks5qOCYQgaJpZM4I4aoA
.

 IMO the most effective way to get some media presence based on your tech stack is to write a blog post along the lines of "7 cool things I learned about React Native - the 5th one will surprise you" and then post to Hacker News. And then we could link to that from the showcase too ;-)


chore(main): release 2.5.8

:robot: I have created a release beep boop
2.5.8 (2024-12-22)
Bug Fixes

优化逻辑处理 (4ead9ab)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/rainbowwarmth/KazuhaBot/releases/tag/v2.5.8 :sunflower:


Handle requests in a non-blocking fashion

This means that long-running handler methods (if they are long-running due to a long await) will not prevent further incoming requests from being handled. This means your RPC handlers can use idiomatic Python (just await the thing you're waiting for, and return the result when you have it), rather than having to return as quickly as possible and schedule some notification to be sent back to the client when the result is available.
We still wait for all handlers to complete on shutdown.
Fixes #48

Hi @sersorrel ,
Thank you for the submission and willingness to contribute.
I'm currently inclined to decline this PR, as #48 is not a real issue (has clear workarounds as seen in the discussion there), and risk, testing for the potential side-effects, and breaking-changes  (especially for code currently assuming the current behaviour) for the changes here outweigh the benefits of being slightly more idiomatic.
At the least this change needs to be feature flagged (e.g. a variable passed to WebsocketRPCEndpoint.__init__) so code already utilizing this library won't be affected by the change.
I'll review this again later this week with more attention, to consider how and if this can be accepted.

No worries. I'm currently testing this with my own application, and am running into some slightly tricky issues (unsure whether there's a bug in the application or in this code), so probably best to leave it for the moment regardless.


error on assertWarns - test_base_model.py

The assertion test in test_base_model.py fails:
with self.assertWarns(pybamm.ModelWarning):
    model.check_well_posedness()

might be related to this bug:
https://bugs.python.org/issue29620
turned off this warning test for now, but need to figure out why this fails. The check_well_posedness raises the expected warning, but then unittest itself throws an error

does it work locally but not on travis for you? works locally for me

yea, it works fine locally for me, I only see it on travis, which makes it difficult to debug.


Fix ovs-monitor-ipsec support for strongSwan >= version 5.7.0

Starting from version 5.7.0, strongSwan no more supports specifying a
configuration parameter with the path delimited by dots in a
configuration file. This commit fixes the strongSwan configuration
parameters that ovs-monitor-ipsec writes, to comply with the new
strongSwan format.

I found out I should send the patch to<EMAIL_ADDRESS>Will do that after I figure out how.

Hi. Thanks for the patch, but there is already similar patch proposed here: https://github.com/openvswitch/ovs/pull/315
It'll be great if you can help with review/testing.
BTW, we do accept pull requests, but, yes, mail-list is a primary way of submitting patches right now.

Ok. PR #315 makes exactly the same change with mine. So let me close this one.
Thanks for the letting me know!


https?

Should be easy to do.
Refs:

https://blog.github.com/2018-05-01-github-pages-custom-domains-https/
https://help.github.com/articles/troubleshooting-custom-domains/#https-errors
https://help.github.com/articles/securing-your-github-pages-site-with-https/
https://help.github.com/articles/using-a-custom-domain-with-github-pages/

Basically, all you need to do is update the A records to the ones mentioned in the second link (the same as the ones for ncase.github.io) or just use a CNAME record, and enable «Enforce HTTPS» in repo settings (if such a setting is present).
Atm, accessing https://ncase.me results in ERR_CERT_COMMON_NAME_INVALID error.
And that's what some people try to use, e.g. with EFF HTTPS Everywhere addon enabled.

Oh that's amazing!  I was disappointed when I first found out Github Custom Domains couldn't do HTTPS, so this is especially happy news for me :) I'll implement it in the next couple weeks! (trying to take a work-break for a bit after just launching a big project)

Alright I finally did it!  https://ncase.me/ same for all the projects on the site, too.  Thanks again for alerting me to Github Pages finally allowing https on custom domains!


fix chart test

Signed-off-by: Frank Bernhardt<EMAIL_ADDRESS>

I added you all as reviewers to have a quick look how I introduced chart testing.
Basically there is a kind cluster set-up in the pipeline and the helm tests are running against the test-wise installed chart.
Had to introduce readiness checks , otherwise helm does not now, when to start testing.

implements hyperledger-labs/business-partner-agent#4444


Specific scan results in host history are not addressable

You can't address a specific scan result in the host history tab, and if you attempt to view the whole scan result of something that gets cut off, it'll take you to the most recent scan result instead. We need to figure out how we're going to address individual scan results so that we can access historical data more completely.

Closed in 19bfd5e which has now been merged to master.


set bound for debt

Solves Issue #223 Borrow money digits reach infinity

Coverage increased (+0.005%) to 91.712% when pulling 283271920c020e022f1da6e4a4b52fa864ded0d4 on jelneo:bug_fixes into 41a0d296c3cfa9e4853174a3a53e26e2ca5207d6 on CS2103AUG2017-T17-B1:master.

Coverage increased (+0.2%) to 91.906% when pulling 0b93736a01202ac26eb554600d814fab563f8686 on jelneo:bug_fixes into 41a0d296c3cfa9e4853174a3a53e26e2ca5207d6 on CS2103AUG2017-T17-B1:master.

Coverage increased (+0.005%) to 91.936% when pulling c4c76a333e91af5af28d90d0525b2b8308b2ee4c on jelneo:bug_fixes into 7f0f1bc2bf2ab43f554f87ca89e7b8b394dba83d on CS2103AUG2017-T17-B1:master.


add logic that triggers the initial cd pipeline run as final step of the da

Description
Tracks remaining steps for https://github.com/terraform-ibm-modules/terraform-ibm-rag-sample-da/issues/12#issuecomment-2059424798

Hi @vburckhardt - Could you please provide some more inputs here?
With the above information, my understanding is to create a webhook upon completion of the CI so as to trigger a new workflow (CD workflow) which should be triggered only if CI result was successful.
I am surely missing something here. Could you please fill me in so that I can take up this issue?


terminal always activate my conda env, can't stop it

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.80.1
OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

Open a project using VS Code

Open a new terminal(which in my case is zsh by default)

conda info -e

conda deactivate

@karrtikr Sure, After restart my PC, it recovered, thanks.


refactor: Move some common files out of rdsn directory

https://github.com/apache/incubator-pegasus/issues/1053

move rdsn docs to ./docs
move common *.thrift to ./idl
move thrift compilation scripts to ./scripts

[ RUN      ] meta_bulk_load_http_test.start_compaction_test
got signal id: 11
Segmentation fault (core dumped)

Seems bulkload has some bugs.

start_compaction_test

not related to this pr, we tracked it by issue, https://github.com/apache/incubator-pegasus/issues/1060


empy arc identifier in feature's arc list

I'm getting empty arcs in geometry definitions (so not in the arcs element, but in the array of arc ids for a feature).
I'm investigating whether anything in my input data is causing this. Docs and issues I've been able to find talk about input data problems and missing or empty arcs in the actual arcs array, but I couldn't find anything about what causes it in the identifiers array on a feature. So I wanted to ask, is there any known cause for this? See highlighted below:
{
    "type": "Topology",
        "objects": {
            "countries": {
                "type": "GeometryCollection",
                "geometries": [
                {
                    "type": "MultiPolygon",
                    "properties": {
                        "id": "1586",
                        ...
                    },
                    "arcs": [
                        [
                        [
                        0
                        ]
                        ],
                    [
                        [
                        1
                        ]
                    ],
                    [
                        [
                        2
                        ]
                    ],
>>>>            [],          <<<<
                    [
                        [
                        3
                        ]
                    ],
                    [
                        [
                        4
                        ]
                    ],
                    [
                        [
                        5
                        ]
                    ]
                    ]
               }
                ]
            }
        },
        "arcs": [

ok, it looks like my affected geometries cross 180 degrees, so maybe the issues relating to the arcs array are relevant for this too.

Hard to say without seeing the input data, and without knowing if you’re using pre-quantization, simplification, filtering, etc. There are ways that coincident points get collapsed, leading to arc removal, but I’m not sure exactly what is going on here and whether or not that is the expected behavior.


Safe error wrapper

This PR aims to fix two issues:

Sometimes Sequel raises a Sequel::ConstraintViolation, when a database constraint is violated. I can't reproduce this locally (Mac OS), but it happens on CI and in general on Linux.
ROM::Sql::Commands::ErrorWrapper uses internally ERROR_MAP with #[]. This is dangerous because in case of non-mapped errors, instead of raising a generic error it raises nil, which causes a TypeError. I changed it with #fetch which falls back to the generic error (ROM::Sql::Error).

@solnic @flash-gordon I've added a test to prove that the code works. Can you please review? Thanks! 😉

LGTM, @solnic?

Yes this is a good change. Could you clean up commits though? There are some commits from master that are not needed here, this should be just one commit.

I force-pushed the branch, but now it fails because of https://github.com/codeclimate/ruby-test-reporter/commit/52760d13430865c0cfc3618fae09f3c815939c73 Need to update codeclimate integration master, I'll fix it today. Specs are passing locally

@solnic @flash-gordon Please make sure this will be part of the next release. Thanks! 😄

That's the plan :)
On 5 November 2016 at 4:51:19 PM, Luca Guidi<EMAIL_ADDRESS>wrote:

@solnic https://github.com/solnic @flash-gordon
https://github.com/flash-gordon Please make sure this will be part of
the next release. Thanks! 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rom-rb/rom-sql/pull/86#issuecomment-258620201, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAEKniPEoZ7Qyl0LDOyg50aGLRYFbviks5q7KX3gaJpZM4J5sww
.


Some incompatible games i've found and a list of games that worked. (for v1.2.1)

Here's a short list of games that i've found to be not working.
Soviet Strike (PAL FRENCH) (Original BIN/CUE) (NOW FIXED ON v1.2.1, it just takes quite a bit of time to boot)
V-Rally 2 (PAL MULTI) (PARADOX PAL/NTSC Selector + Anti Debug Protection Removed) (Still doesn't work as of v1.2.1, stuck on initializing CD)
Both of these end up stuck on "Initializing CD" or "Starting" sometimes. never got them to boot successfully.
it would be great if someone else other than me could try them, just in case it's a fluke, but i'm pretty sure both of these aren't compatible.
So far i've tested the following games with great success :
Alien Trilogy (PAL ENGLISH) (PAL/NTSC Selector and +31 Trainer by Paradox) (Footage: https://youtu.be/TEobsLmi48s)
Syphon Filter (PAL) (+5 Trainer by Dedok197)
GTA 2 (PAL MULTi) (PAL/NTSC Selector +3 Trainer by KALISTO)
Die Hard Trilogy (PAL MULTi) (With Guncon45 support patch)
LSD Dream Emulator (NTSC-J) (With English translation patch)
Digimon World (PAL UK (?) ) (With PAL/NTSC Selector and +? Trainer by Paradox)
Vib-Ribbon (PAL MULTi) (Original BIN/CUE)
007 Demain Ne Meurt Jamais (007 Tomorrow Never Dies FRENCH) (Original BIN/CUE)
Dino Crisis 2 (PAL UK) (PAL/NTSC Selector by B.A.D)
GTA London (PAL MULTi) (Original BIN/CUE)
Thank you very much for this awsome exploit by the way, i had a very hard time doing anything with the swap trick (FMV and music kept skipping using this method)
My PSOne's model : SCPH-102 (PAL, French)
EDIT: changed results as i just tried v1.2.1
EDIT 2 : Updated compatibility list.
(If you want to make a list of known compatible games, feel free to use this issue by the way)

I cannot find the V-Rally 2 patch from Paradox to attempt running it. Unless you have it there's no way I can check what's wrong.

I cannot find the V-Rally 2 patch from Paradox to attempt running it. Unless you have it there's no way I can check what's wrong.

I have the fully patched ISO, but you can find the patch on console copy world : https://consolecopyworld.com/psx/psx_patches_v.shtml
You will need a PAL iso for it to work.


WIP update to latest Jupyter widgets package.

This is definitely still a work in progress.

This PR relies on https://github.com/jupyter-widgets/ipywidgets/pull/1476 being merged.


Evaluation Plan - Quantitative Metrics for Success

such as accuracy, perplexity, or other performance metrics relevant to your project.

Accuracy: Percentage of support tickets correctly categorized.  We aim for an initial accuracy rate of over 85%.


Add more unit tests for InvokeBindingAsync

Description
Added two unit tests:

Invoke Binding Async with  custom data and validate payload deserialization
Invoke Binding Async with  Null custom data and validate payload deserialization

Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #550
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

@mukundansundar - do you plan to finish this?

Closing in favor of #751


How do I adjust the panel divider size and color

I have moved the Favorites to the left, and changed the background and font color to match the default notebooks/tags panel. Somehow this has created a thick divider between the Favorites.

Unfortunately this is nothing which is caused by the plugin. It is the Apps default behavior. Which places between each panel an empty white space (splitter) for resizing the panel widths and heights.
In the "Change application layout" view you can see where these splitters are added by the app.

You could only try to change the background color of this splitter by with custom css.

As a workaround the following code could be pasted into userchrome.css:
/* remove white border (~5px, right) from columns with one panel */
.rli-root > .resizableLayoutItem > div {
  width: 100% !important;
}
/* remove white border (~5px, right, below) from columns with two or more panels */
.rli-root > .resizableLayoutItem > .resizableLayoutItem > div {
  height: 100% !important;
  width: 100% !important;
}
/* remove small border (1px, below) plugin iframes */
div.resizableLayoutItem iframe {
  border-bottom: none !important;
}

That got rid of the dividers, but now the favorites panel is only half as wide as the notebook panel:

That got rid of the dividers, but now the favorites panel is only half as wide as the notebook panel:

Just remove width: 100% !important; in the second rule to be:
.rli-root > .resizableLayoutItem > .resizableLayoutItem > div {
  height: 100% !important;
}


<?= PHP opening tag throws css(css-ruleorselectorexpected) error

<?php opener does not throw errors, however <?= short open/echo tag does.

VSCode Version: 1.42.1
OS Version: Windows 10 x64 1909

Steps to Reproduce:

Create index.php file with HTML and CSS Style in it
Add PHP code in the style header using the <?= tag.

<!DOCTYPE html>
<title>Test</title>

<?="Hello world";?>

Does this issue occur when all extensions are disabled?: No

please file against php extension


Question, Piano Layout

Hi,
It is possible to change the piano layout to a thumb piano?
https://galactic.ink/piano/
I would like to teach this instrument and give the students a place so they can see the classes without having to buy the program. I am willing to work on the code although I am not an expert, I know a little programming, or pay if necessary.

That's a separate project that uses MIDI.js. It's not part of this project.


pdb: reconcile all old pdbs

This change removes stale PDBs created by virt-controller < 0.41.1 which
had minAvailable permanently set to 2.
Func test also added.
Signed-off-by: Antonio Cardace<EMAIL_ADDRESS>Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2019453

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

remove stale pdbs created by < 0.41.1 virt-controller

/retest

/retest

/retest

/test pull-kubevirt-e2e-k8s-1.21-sig-storage

/retest

/cherry-pick release-0.44

@acardace was this backported to 0.41?

/cherry-pick release-0.41

@acardace was this backported to 0.41?

Created the cherry-pick now.


Handle tsconfig.json verbatimModuleSyntax errors

When using "verbatimModuleSyntax": true in tsconfig.json I get 74 errors using your amazing package.
All like this one:
Error: 'Genders' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.
import Omocodes from "./enums/omocodes.enum";
import Genders from "./types/genders.type";

I think the solution is to change imports like this:
import Genders from "./types/genders.type";

to this:
import type Genders from "./types/genders.type";

Am I right?

Dear @Marketto,
I opened this issue because in a new React or Svelte or Solid project (where the tsconfig is not decided by me but is written by a generator), if I use your project (@marketto/codice-fiscale-utils) I get 74 typescript errors of various types, like these:
c:\web\node_modules\@marketto\codice-fiscale-utils\src\date-utils\date-day.type.ts:6:16
Error: An 'export default' must reference a value when 'verbatimModuleSyntax' is enabled, but 'DateDay' only refers to a type.

export default DateDay;

c:\web\node_modules\@marketto\codice-fiscale-utils\src\date-utils\date-month.type.ts:3:16
Error: An 'export default' must reference a value when 'verbatimModuleSyntax' is enabled, but 'DateMonth' only refers to a type.

export default DateMonth;

c:\web\node_modules\@marketto\codice-fiscale-utils\src\date-utils\multi-format-date.type.ts:1:10
Error: 'Moment' is a type and must be imported using a type-only import when 'verbatimModuleSyntax' is enabled.
import { Moment } from "moment";

...

and I'm importing your project like this:
import { Parser, Validator } from '@marketto/codice-fiscale-utils';

So to continue using it I opened a PR that would fix the problems not only with future projects but also with past ones (since in any case if you release a new major version or a feature version the user who updates knows that there are new features). (And in any case I don't see why old projects shouldn't be updated as well).
If you tell me that the problem is in my project and you are not willing to find a solution, our team will have to find an alternative solution unfortunately.
In any case: sorry if I bothered you.

I cannot import it like this neither:
import CodiceFiscaleUtils from '@marketto/codice-fiscale-utils';

because of:
Module '"c:/web/node_modules/@marketto/codice-fiscale-utils/src/index"' has no default export. ts(1192)

Hi @carmelone ,
Those changes break the unit tests and make the lib not backward compatible with non-verbatim projects.
A verbatim project doesn't need verbatim dependencies
Using VermatimModuleSyntax you just need to import as follows
import CodiceFiscaleUtils from '@marketto/codice-fiscale-utils';
import type {BelfiorePlace, DateDay, DateMonth, Genders, MultiFormatDate} from '@marketto/codice-fiscale-utils';

No Changes are needed to the source code
I will add this import hint in the README.MD
I tried a demo project with success, please let me know if it solves your issue

Thanks for answering me.
Even if I use:
import * as CodiceFiscaleUtils from '@marketto/codice-fiscale-utils';

I'm still getting those typescript errors.
I created a reproduction for you. Steps:

Open https://stackblitz.com/edit/sveltejs-kit-template-default-deqtfq

Run npm run check in the Terminal

You should see the typescript errors in Terminal

I don't understand why you don't want to add those changes.
Can we fix the unit tests?

Ok, problem found and managed, the fix will be available in the next release (I'll try to release in the next days)
Sorry for the misunderstanding.


CDN-backed GEOJSON Files for Maps

Create a public listing of common GEO JSON files, and consume those in the Map (name tbd) component

Some listed in https://docs.evidence.dev/components/area-map/#map-resources


Install.md instructions wrong

$ ./build.sh cli build output
using target cli
using command build
using output directory output
Unknown Command cli

Try this instead: ./build.sh fbsimctl build output
I've created a pull request to update the documentation.

@bootstraponline  Looks like your PR will fix this issue, Thanks!
Closing now as this will be fixed in the PR.


Project dead?

Is this project now defunct? I don't see any crate on crates.io.

This was written as a proof-of-concept, and an excuse to include the gif in the Readme.
Do you want to use it? You'll need t update it to the latest clap 3 pre-release, but the code is pretty simple.

Hah, no problem. I was considering it, but may go for the man-page generator. Thanks for the tip.

Cool! Let me know if you need any help, I've been meaning to continue to work on this for a while now :)
(closing issue since the original question is answerd. feel free to open new ones or ping me on discord/irc!)

Okay, sounds good, thanks!

For anyone else who finds this, it seems the maintained equivalent is clap_markdown:
https://www.reddit.com/r/rust/comments/11eisnd/announcing_clapmarkdown_automatically_generate/
https://docs.rs/clap-markdown/latest/clap_markdown/
https://github.com/ConnorGray/clap-markdown

Depending on the use case, another interesting route is term-transcript to make an SVG from clap's help output with styiling


Labels with Select

Discussed in https://github.com/melt-ui/melt-ui/discussions/194

Originally posted by alexnguyennz July 13, 2023
Hi is it possible to use labels with Select? Like on this page but with Select e.g. where clicking on labels gives focus to normal selects. Thanks.

Agreed. I can tackle this if you haven't already? @TGlide

Agreed. I can tackle this if you haven't already? @TGlide

No worries, I'm on it!


Abrupt spec abort with no errors reported with a combination of :isolated_environment and cli spec behavior

Some of the examples seem to be silently swallowed by RSpec in some circumstances.
I've reduced it to:
# spec/rubocop/config_loader_spec.rb
RSpec.describe RuboCop::ConfigLoader do
  include FileHelper

  include_context 'cli spec behavior'

  before do
    described_class.debug = true
    # Force reload of default configuration
    described_class.default_configuration = nil
  end

  after { described_class.debug = false }

  describe '.configuration_from_file', :isolated_environment do
    subject(:configuration_from_file) do
      described_class.configuration_from_file(file_path)
    end

    context 'when a new cop is introduced' do
      def cop_enabled?(cop_class)
        configuration_from_file.for_cop(cop_class).fetch('Enabled')
      end

      let(:file_path) { '.rubocop.yml' }
      let(:cop_class) { RuboCop::Cop::Metrics::MethodLength }

      before do
        create_file('~/.rubocop.yml',
                    <<~YAML)
                      Metrics/MethodLength:
                        Enabled: complete_nonsense
                    YAML
        create_file(file_path, config)
      end

      context 'no errors' do
        let(:config) { '' }
        it('nothing to fail') {}
      end

      context 'when not configured explicitly' do
        let(:config) { ['inherit_from: ~/.rubocop.yml'] }

        it 'is disabled' do
          expect(cop_enabled?(cop_class)).to eq 'pending'
        end
      end
    end
  end
end

The culprit is this line (mistake in the config file):
Enabled: complete_nonsense

Expected behavior
The underlying failure is reported.
Actual behavior
$ rspec --format documentation spec/rubocop/config_loader_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 36379

RuboCop::ConfigLoader
  .configuration_from_file
    when a new cop is introduced
      no errors
        nothing to fail
      when not configured explicitly

Finished in 0.04127 seconds (files took 4.97 seconds to load)
2 examples, 0 failures

Randomized with seed 36379

$ rspec --format documentation spec/rubocop/config_loader_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 48762

RuboCop::ConfigLoader
  .configuration_from_file
    when a new cop is introduced
      when not configured explicitly

Finished in 0.01265 seconds (files took 1.77 seconds to load)
1 example, 0 failures

Randomized with seed 48762

Steps to reproduce the problem
Replace spec/rubocop/config_loader_spec.rb with the contents above.
Run the following command several times. Notice different number of examples executed being reported.
 rspec --format documentation spec/rubocop/config_loader_spec.rb

RuboCop version
$ [bundle exec] rubocop -V
0.78.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.5 x86_64-darwin18)

The different number of examples that get run is due to random order of examples. I can trigger the two orders on my system by adding --order rand:0 or --order rand:1 to the rspec call.
Making the console output visible like this
diff --git a/spec/support/cli_spec_behavior.rb b/spec/support/cli_spec_behavior.rb
index 59dc649a8..354bf0433 100644
--- a/spec/support/cli_spec_behavior.rb
+++ b/spec/support/cli_spec_behavior.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true

 RSpec.shared_context 'cli spec behavior' do
-  include_context 'mock console output'
+  # include_context 'mock console output'

   include FileHelper

reveals
Randomized with seed 55055

RuboCop::ConfigLoader
  .configuration_from_file
    when a new cop is introduced
      when not configured explicitly
configuration from /tmp/d20191224-19344-qc68ry/work/.rubocop.yml
Inheriting configuration from /tmp/d20191224-19344-qc68ry/home/.rubocop.yml
Property Enabled of cop Metrics/MethodLength is supposed to be a boolean and complete_nonsense is not.

That error message leads to
https://github.com/rubocop-hq/rubocop/blob/b0c6efdc5f542e4901e3b75a104edd95d40c55e8/lib/rubocop/config_loader.rb#L254-L257
which "terminates execution immediately". That explains why RSpec stops running further examples. This should probably be replaced by raising some exception.


Full-screen layout with overlay control panels

This is really nice. I'd suggest switching the main bootstrap container to a container-fluid to match the full-screen feel of the app.


feat(goal_planner): extend pull over lanes inward to extract objects

Description
The current algorithm expands the pull over lane only outward and extracts objects in it. In this case, if an object exists without overlapping the narrow shoulder lane, the object is not extracted. For example, since the object does not overlap the shoulder lane at 8509, it is not included in the collision check. As a result, the route is generated ignoring the object, and it gets stuck.

In this PR, pull over lanes are expanded inward so that objects can be extracted regardless of the width of the lane. The length to be expanded is determined by the goal search area. the extraction plygon is the sky blue one.

Related links
psim
https://evaluation.tier4.jp/evaluation/reports/41bd57af-9931-5c32-ae12-bbb927ad0dd8?project_id=prd_jt&state=failed
4133/4136
baseline: 4132/4136(2024/09/03)
Parent Issue:

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

about: remove_self_intersection

Shifting the bound of a lanelet inward can cause self-intersections line gray line.

To prevent this, add the self-intersected point to the bound instead. After the modification, the blue line is shown below.


MINOR: Ensure that DisplayName is set in all parameterized tests

This is a follow-up to https://github.com/apache/kafka/pull/14687 as we found out that some parameterized tests do not include the test method name in their name. For the context, the JUnit XML report does not include the name of the method by default but only rely on the display name provided.
Example:

The testDescribeQuorumReplicationSuccessful part was not there before.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

I tried this in IntelliJ and I see the test name included in the individual test variation output. Looks great!


Get DOFs of values at boundaries in DG

Suppose I have a DG finite element space setup with Gauss Lobatto points and I ensure that the integration for the Mass or derivative matrices are done at the Gauss Lobatto points so that the mass matrix is diagonal.
The gridfunctions generated on this finite element space therefore have values at the boundaries of the elements, since the Gauss Lobatto points include the boundaries. Is there a way to get the DOF number of the values that are only on the boundaries of each elements?

The interior dofs are numbered last, both on element and global level, so you can just skip them?

Thanks. I will have a look. Will close this for now and reopen if I have further questions.


Provide ability on when to actually rotate expired nodes

Tell us about your request
I'd love to have the ability on a Provisioner to configure when expiration/rotation of nodes should actually occur. The idea would be to have the the ability on when to mark a node as expired versus when to actually rotate the nodes (default to once expired).
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Many of the applications I support are not able to run in HA modes and require sticky sessions. But, most of those systems currently restart once a day, early in the morning, when they have very little traffic. While the app team loves the idea of automatically rotating nodes to ensure their nodes are running the latest AMIs, they worry the expiration might happen during a bad time and impact users.
Are you currently working around this issue?
Currently, we're planning to not use expiration on those nodes but then use our own job that runs during the maintenance window and deletes nodes, effectively managing our own expiration time.
Additional context
Not that I can think of currently.
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Hey @mikesir87 thanks for writing this up. I'm definitely interested in supporting some sort of "maintenance window" for scaling down. We've talked in the team about the idea of a NodeDisruptionBudget that would work similarly to a PDB, but we could add additional fields like maintenance windows.
For your use case, there may be an easy alternative. Karpenter respects Pod Disruption Budgets as well as GraceTerminationSeconds. When node termination is triggered, the node is cordoned, and the pods evicted. PDBs prevent eviction, and Karpenter will never force terminate a pod, instead delegating to GraceTerminationSeconds. Do you think these existing mechanisms are suitable for your use case?
I'd be happy to discuss either of these ideas further, either here or in the https://github.com/aws/karpenter/blob/main/WORKING_GROUP.md

@ellistarn - Good to know about those options. But, I don't think they'll work for this use case, as we may not always know what value the grace period should have. Imagine the scenario in which a node expires at noon, but we want to rotate it at 3am. But, a scale-up event occurs that adds another node that will cause a node to expire at 4pm. Recognizing that there are a few sliding windows time-wise, anything second-based will start to drift over time and doesn't ensure the nodes will rotate in the correct window (without something else monitoring the values and adjusting them).
And thanks for pointing me to the working group. I'll have to swing by and say hello to the team! 😄

Yeah this makes sense to me. What I'm hearing is that while it would be nice to specify everything at the pod level, it's important for the ops team to be able to protect dev teams with broadly applied policy.  Thoughts on the NodeDisruptionBudget approach?

Yeah... if we (as a platform/ops team) are going to automatically expire and rotate nodes, we want to make sure it doesn't occur during a time that affects our customers.
I'll have to see what a NodeDisruptionBudget might look like, but the hypothetical sounds reasonable so far.

Closing in favor of #1738

solved with https://github.com/kubernetes-sigs/karpenter/pull/849


Assertion failure when defining malformed sum type

See the following example:
type test (t:Type0) =
  | Test: unit

It gives the following error:
(Error 18) ASSERTION FAILURE: firstN
F* may be in an inconsistent state.
Please file a bug report, ideally with a minimized version of the program that triggered the error.

The root cause is same as #2522. I have a fix in aseem_misc2, will push.

Fixed in master, thanks for the report!


🎨 Code format and linting config update

Description
This PR updates a couple of the configuration files responsible for code formating, linting, etc.
This brings the project closer to the currently established best practises from mqt-core.
Checklist:

[x] The pull request only contains commits that are related to it.
[x] I have added appropriate tests and documentation.
[x] I have made sure that all CI jobs on GitHub pass.
[x] The pull request introduces no new warnings and follows the project's style guidelines.

The failure here will be resolved by #405


'when' helper method

With Laravel's convenience methods and the rapid development it offers, it makes  traditional if/else statements often feel lengthy and bloated.
The when helper accepts an input, a truthy, and a falsy output (outputs can be closures that will be evaluated when needed). It also takes a strict parameter, to determine if the value should be strictly checked as true.
A very crude example of where this helper would come in handy would be something like the below:
$createUser = (bool)$request->input('create');

if ($createUser) {
  $user = User::create();
} else {
  $user = User::make();
}

With the when helper, this can be refactored to:
$user = when($request->input('create'), fn() => User::create(), fn() => User::make());

The value provided is also passed into each callback and mixed values are accepted for both the truthy & falsy response making the possible outputs flexible.
There's many cases for this method being very useful. I've had this helper in my projects for some time now and thought it'd be useful to PR it as I often find myself reaching for it and I feel like other users of Laravel will too.
I'd be happy to write up some tests for this if it's something you'd consider merging in.
Thanks!

$user = (bool)$request->input('create') ? User::create() : User::make();

@miki131 of course - it was a simplistic example 😅
Much more that can be done with it that's not so easy just to run as a ternary.

I feel like this has been PR'ed a few times, and each time it doesn't make sense for the framework to maintain it.
Ternaries and conditionals aren't really broken; nothing wrong with this readability of this:
$user = $request->input('create')
    ? User::create()
    : User::make();

This wouldn't be so relevant, and if it were, it would need the opposite: unless, as the Conditionable trait offers.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


fatal error: 'windows.h' file not found on macOS when using electron-rebuild to rebuild native-reg in Electron apps

Hi,

We are using native-reg in our Electron project in Windows OS versions only, while we don't use it in macOS versions.
Electron-builder now is using electron-rebuild to rebuild the native dependencies (https://github.com/electron-userland/electron-builder/pull/7196), but when re-building native-reg, Here is the error I got:

/Users/omaralfroukh/Desktop/project/node_modules/node-addon-api/napi.h:32:6: error: Exception support not detected.       Define either NAPI_CPP_EXCEPTIONS or NAPI_DISABLE_CPP_EXCEPTIONS.
    #error Exception support not detected. \
     ^
../reg.cc:4:10: fatal error: 'windows.h' file not found
#include <windows.h>
         ^~~~~~~~~~~
2 errors generated.
make: *** [Release/obj.target/reg/reg.o] Error 1
  ⨯ node-gyp failed to rebuild '/Users/omaralfroukh/Desktop/project/node_modules/@aabuhijleh/native-reg'.
For more information, rerun with the DEBUG environment variable set to "electron-rebuild".

I'm not an expert in the native modules, but I think to fix that issue we have to add a condition to using this library on Windows OS only, here is the fix that needs to add to binding.gyp file:

"conditions": [
        [
          "OS==\"win\"",
          {
            "sources": ["reg.cc"]
          }
        ]
      ],

So binding.gyp file should be something like this:

{
  "targets": [
    {
      "target_name": "reg",
      "dependencies": [
        "<!(node -p \"require('node-addon-api').gyp\")"
      ],
      "include_dirs": [
        "<!@(node -p \"require('node-addon-api').include\")",
      ],
      "conditions": [
        [
          "OS==\"win\"",
          {
            "sources": ["reg.cc"]
          }
        ]
      ],
      "msvs_settings": {
        "VCCLCompilerTool": {
          "AdditionalOptions": [
            "/std:c++17"
          ],
          "ExceptionHandling": 1
        },
      }
    }
  ]
}

Thanks a lot!

Thanks for the report. This has gone back and forwards a bit, ideally there simply isn't any build or source files in the package as we can feasibly prebuild them for every platform supported by Windows, since this is N-API so there's no reason to rebuild it.
I'll have to refresh myself to make sure I'm not breaking any of these earlier changes, but your suggested change looks good. I'm certainly happy to publish it as a @next tagged build for now.

Hi @simonbuchan I'm using @aabuhijleh/native-reg v0.3.4, I didn't notice there are tags on this rep, I'll re-check v1.0.0 and I'll get back to you.
Thanks!

1.1.0 is the current latest tag, but it looks like you would be fixed by 0.3.6, which fixed #23. That looks like a dup of this, fixed via the rather brute-force method of simply removing the binding.gyp 👌

The same issue on the latest version 1.1.0 on macOS while adding that conditions to the binding.gyp file also fixed the issue. I checked v0.3.6 seems it's OK, can we use that version or it has a bugs?

Right, looks like 1.1.0 restored binding.gyp to fix Windows ARM, which re-broke #23. Only difference is from 0.3.6 to 1.0.0 is it drops earlier node support, so take your pick of those in the short term.

Ok I've published 1.1.1 with your condition change in the @next tag - let me know if it works for you!

Ok I've published 1.1.1 with your condition change in the @next tag - let me know if it works for you!

Hi @simonbuchan,
Yes, v1.1.1 is OK on both Windows and macOS, thanks for the publish.

Good to hear! I'm mark it as latest then.


[DOMA] Add schema for domains

closes #285.
Additionally, I fixed some inconsistencies I (and our verification) missed in the review...

#287 should fix the JSON validation.
The markdown link checks reported https://abapgit.org/was broken. This does not seem to be the case. ;)

I've retriggered the links check, ok now

#287 is not related to the issues reported in this PR. Anyhow it is good to have it, too. ;)
The JSON validation fails, because the schema was generated with string fields instead of boolean. Furthermore, the originalLanguage was set to upper case. I'll fix this later today.

Need to update the JSON Schema accordingly.

What do you mean? Did I miss anything?


OPS: Set up Prettier in the Angular project and integrate with pre-push hooks

Set up Prettier in the Angular project and integrate with pre-push hooks
Description
Ensure the code is consistently formatted before being pushed to the repository. To achieve this, Prettier should be installed in the Angular project and configured to run automatically via a Git pre-push hook.
Tasks

Install Prettier:

Add Prettier as a development dependency in the project.
Create or update the Prettier configuration file (.prettierrc or equivalent) with the desired formatting rules.

Add formatting scripts to package.json:

Add a script to manually format the code. Example:"scripts": {
  "format": "prettier --write \"src/**/*.{ts,html,scss}\""
}

Set up Git pre-push hooks with Husky:

Install Husky and set up Git hooks.
Create a pre-push hook that automatically formats the code using Prettier before pushing.

Integrate Prettier with ESLint (if applicable):

Ensure Prettier works seamlessly with ESLint by installing and configuring eslint-config-prettier to prevent rule conflicts.

Acceptance Criteria

Prettier is installed and correctly configured in the project.
A pre-push hook automatically formats the code using Prettier before a push.
Formatting scripts in package.json allow for manual code formatting.
Configuration supports .ts, .html, and .scss files.
No conflicts exist between Prettier and ESLint.

Hints for Implementation

Installing Prettier:

Run the following command:npm install --save-dev prettier

Create a .prettierrc file with initial settings, such as:{
  "singleQuote": true,
  "trailingComma": "all"
}

Setting up Husky for Git Hooks:

Install Husky:npm install --save-dev husky

Initialize Husky and add a pre-push hook:npx husky install
npx husky add .husky/pre-push "npm run format"
git add .husky/pre-push

Integrating Prettier with ESLint:

Install the necessary dependency:npm install --save-dev eslint-config-prettier

Update the .eslintrc.json file to extend Prettier’s rules:"extends": ["eslint:recommended", "plugin:@angular-eslint/recommended", "prettier"]

https://dev.to/seanbh/how-to-setup-eslint-and-prettier-in-an-angular-project-30bd
https://stackoverflow.com/questions/46799828/tslint-type-trivially-inferred-why-is-it-bad-practice-to-include-the-type-he


markup mess appearing at the bottom of "all chapters" page

In the "All chapters" section here: http://learnosm.org/en/beginner/all-chapters/
At the very bottom of the page after "Happy Mapping!" there's a bit of unrendered markup mess

I've removed 'all chapters' from the site at the moment. I'll shortly be producing .odf & .pdf files of the new beginners section, and a combined file, so they can be downloaded.
If the 'all chapters' was needed for some other purpose, let me know.

Closing this - has not been a problem since removed in July 2015


client/pull: fix label being put on snapshot instead of content

The uncompressed label should be placed on content instead of snapshots. Currently the uncompressed label is getting passed into as a label option for apply, which is used to commit snapshots. The content is already committed, but after apply the uncompressed diff digest is verified and can be reliably used to update the content with the label.

Codecov Report

Merging #2237 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2237   +/-   ##
=======================================
  Coverage   41.14%   41.14%
=======================================
  Files          66       66
  Lines        7755     7755
=======================================
  Hits         3191     3191
  Misses       4060     4060
  Partials      504      504

Flag
Coverage Δ

#windows
41.14% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7833fb4...d608e3d. Read the comment docs.

LGTM


updated hero images on a few pages

Docs Build status updates of commit 4120ebb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/app-patterns-landingpage.md
:white_check_mark:Succeeded
View

mixed-reality-docs/core-concepts-landingpage.md
:white_check_mark:Succeeded
View

mixed-reality-docs/design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/development.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/01_MixedReality.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/02_MixedRealitySlashMixedReality.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/03_Design.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/04_InteractionFundamentals.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/05_CoreConcepts.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/06_AppPatterns.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/07_Development.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/08_Tutorials.png
:white_check_mark:Succeeded
View

mixed-reality-docs/index.md
:white_check_mark:Succeeded
View

mixed-reality-docs/interaction-fundamentals.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mixed-reality.md
:white_check_mark:Succeeded
View

mixed-reality-docs/tutorials.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Enhancement: accept a parser function as a third argument of CircularJSON.parse

The idea is to add a new argument to the parser API:
CircularJSON.parse(string, reviver, parser)

If specified this parser function will be used instead of JSON.parse during parsing.
This will make possible to use none standard parser with circular capabilty such as JSON-js or JSON.parseMore.
Please tell me if you are Ok with such an enhancement, if so I can create a PR.

I'm not sure I understand what's the goal, or the advantage, of this proposal:

this module works very well with the way JSON works and I don't want to maintain random parsers
you can use the reviver already to do what you want with values while these are being parsed

can you please elaborate a bit more?

The use case:
I need to handle not only circular references but also NaN and Infinity parsing which are not part of JSON specification. On the other hand JSON.parseMore handles such use case.

using reviver:
This will not work as JSON.parse('{"v":NaN}'), reviver will rise an exception before calling the reviver, because the original string is not a valid JSON.

The current hack:

    var originalParser = JSON.parse;
    JSON.parse = parseMore;
    var res = updateVm(CircularJson.parse(rawVm));
    JSON.parse = originalParser;

This, though ugly, will give me a parser with both NaN, Inifinity nad circular reference capability.

I don't understand ... if you parse circular references, these must have been produced with CircularJSON, right? Since CircularJSON.stringify would not produce NaN or Infinity results, this proposal seems a half backed, disaster prone, because it introduce a way out but not a way in, and I'v eno idea why you're parsing JSON that is not JSON with this module ... you shouldn't, it's not encouraged.
However, using a different parser than JSON itself looks like a reasonable requirement.
How about exposing a parser property instead that would point to JSON object but could be replaced with anything that simulate the exact same API that JSON has ?

I got your point: in fact I am generating circular JSON from C# code in Neutronium. This data is then read on the javascript side using CircularJSON.parse. So as I have the full hability to produce Nan and Infinity output, the idea is to get back this values on the javascript side: https://github.com/NeutroniumCore/neutronium-vue/issues/4
Regarding your second point, this proposal will be perfect for my use case. Tell if it is ok if I submit a PR with this changes.

Thanks @WebReflection for the discussion and the very quick enhacement. Work like a charm!


Document how to validate a JSON Schema

Adding a snipped of documentation on how to validate a JSON Schema.
This has come up a few times (#287, GG).

I'm fine with that. 👍

This should be merged considering there are no code changes or conflicts.

I've tweaked this slightly and merged manually. Thanks @coffeejunk


Support for NuGet CPM option from within VS IDE

Support for NuGet CPM option from within VS IDE

This feature is now part of the following releases:
CLI Templates:

VijayAnand.BlazorTemplates - v4.2.0 (Unified package)
VijayAnand.WindowsForms.Blazor - v4.2.0
VijayAnand.Wpf.Blazor - v4.2.0

VS Extension:
Blazor Desktop Templates - v<IP_ADDRESS>


#8 - math: Fix functions' names across whole module

This fixes linker error of 'undefined reference to p_..._f32'
in math module.
This commit fixes #8

So, I've found that header/impl. differs in two more details:

p_abs.c:17:6: error: conflicting types for ‘p_abs_f32’
../../include/pal_math.h:83:6: note: previous declaration of ‘p_abs_f32’ was here

and

p_exp.c:18:6: error: conflicting types for ‘p_exp_f32’
../../include/pal_math.h:119:6: note: previous declaration of ‘p_exp_f32’ was here

which after closer look appeared to be additional const qualifiers in impl. files.

Thanks for cleaning up my mess! Go ahead and remove the const for now. We'll add the optimization crud later.


Move polyfil into pxtlib so it’s part of the runner.

We recently had an issue where Math.imul was breaking decompilation of any multiplication on IE. This issue was fixed in the worker by polyfilling Math.imul.
Unfortunately, that wasn't the entire fix. The runner (for docs / tutorials) also calls decompilation and needs the polyfill.
I'm moving the polyfill into pxtlib. Currently adding it at the bottom of the hexfile.ts (the file which uses the method). I don't like this, and am open to recommendations of where to place it. I didn't see any other logical place to put it in pxtlib.
@pelikhan
Note: this is going into stable5.1 so we can release a patch fix, but will have cherry-picked to master once it's in.
Fixes https://github.com/Microsoft/pxt-adafruit/issues/856
Tested on Chrome and IE.

Moved to it's own file in pxtlib. which means it's also available for pxtsim. I see no harm. @pelikhan? Or I can place it in its own file in pxtcompiler..
I personally would rather all polyfills be one file in pxtlib. Sure they'll be included in places where they're not necessary but it's clearer.

Agreed to have them all in one place. All polyfill are guarded so it's fine to have them loaded in all places.

Since this is a hot fix, I'll keep it small. Will move the rest of the polyfills into this file at a later point :)


Update/Add PHP to version 7.4.19 and 8.0.6

Tool information

Tool name: PHP
Tool license:
Add or update? update
Desired version: 7.4.19 / 8.0.6
Approximate size:
If this is an add request:

Brief description of tool:
URL for tool's homepage:
Provide a basic test case to validate the tool's functionality:

Area for Triage:
PHP
Question, Bug, or Feature?:
PHP 7.4.18 and 8.0.5 have a bug that affects Laravel users: https://github.com/php/php-src/pull/6801
PHP 7.4.19 release notes: https://www.php.net/releases/7_4_19.php
PHP 8.0.6 release notes: https://www.php.net/ChangeLog-8.php#PHP_8_0
Virtual environments affected

[X] Ubuntu 16.04
[X] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Can this tool be installed during the build?
Not sure. Running apt-update && apt install -y --upgrade php7.4-cli does not updates it to the latest version (7.4.19)
Tool installation time in runtime
Should be quick.
Are you willing to submit a PR?
Yes

Closing since package from ondrej ppa already contains the patch to revert the bug.


Appstudio update test-component-pac-uvzq

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-uvzq-on-pull-request has failed.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

❌ Failed
0 seconds
build-container

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/test-component-pac-uvzq-on-pull-request has failed.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

❌ Failed
0 seconds
build-container

✅ Succeeded
5 seconds
show-summary