Inconsistency when running the keras-io/examples/timeseries/timeseries_classification_transformer.py

Running the example shows inconsistency in number of parameters and model performance compared to what is displayed.
It seems that the global average pooling should take data_format to "channel_first" to reach the same number of parameters and the accuracy performance consistent with the displayed console log (tried with google colab).
https://github.com/keras-team/keras-io/blob/2ac94c4c4da54c1f7c80fea7f18832fd54c6be28/examples/timeseries/timeseries_classification_transformer.py#L115
But then there is no pooling, just removing the feature dimension => Maybe another layer should be used.

Experienced the same problem:
with
    x = layers.GlobalAveragePooling1D(data_format="channels_last")(x)

the number of parameters are (only show the last few rows that differ):
...
 global_average_pooling1d (Glob  (None, 1)           0           ['tf.__operators__.add_7[0][0]']
 alAveragePooling1D)

 dense (Dense)                  (None, 128)          256         ['global_average_pooling1d[0][0]'
                                                                 ]

 dropout_8 (Dropout)            (None, 128)          0           ['dense[0][0]']

 dense_1 (Dense)                (None, 2)            258         ['dropout_8[0][0]']

==================================================================================================
Total params: 29,258
Trainable params: 29,258
Non-trainable params: 0

And the training stop very quickly with bad result:
45/45 [==============================] - 24s 545ms/step - loss: 0.6922 - sparse_categorical_accuracy: 0.5208 - val_loss: 0.6952 - val_sparse_categorical_accuracy: 0.4799
42/42 [==============================] - 4s 91ms/step - loss: 0.6930 - sparse_categorical_accuracy: 0.5159

While on page: https://keras.io/examples/timeseries/timeseries_classification_transformer/
it shows:
│ global_average_poo… │ (None, 500)       │       0 │ add_7[0][0]          │
│ (GlobalAveragePool… │                   │         │                      │
├─────────────────────┼───────────────────┼─────────┼──────────────────────┤
│ dense (Dense)       │ (None, 128)       │  64,128 │ global_average_pool… │
├─────────────────────┼───────────────────┼─────────┼──────────────────────┤
│ dropout_12          │ (None, 128)       │       0 │ dense[0][0]          │
│ (Dropout)           │                   │         │                      │
├─────────────────────┼───────────────────┼─────────┼──────────────────────┤
│ dense_1 (Dense)     │ (None, 2)         │     258 │ dropout_12[0][0]     │
└─────────────────────┴───────────────────┴─────────┴──────────────────────┘
 Total params: 93,130 (363.79 KB)
 Trainable params: 93,130 (363.79 KB)
 Non-trainable params: 0 (0.00 B)

Hi , @fchollet
https://github.com/keras-team/keras-io/blob/8ec940273419cd5a61f056f462753ba4ac0c9590/examples/timeseries/timeseries_classification_transformer.py#L115

This line need to be changed to channel_first to see the good result on:
https://keras.io/examples/timeseries/timeseries_classification_transformer/
Can you make this change? can also add explanation why channel_first is need instead of channels_last?
The input training data's shape is (3601, 500, 1), i.e channels_last for sure; but why we need to set channel_first to see the good training result?
Thanks.


Publish webhook body versus Unpublish webhook body.

Brief bug description
The webhook body Kentico Kontent sends when publishing an item versus unpublishing an item, is different.

Publish --> only the actually published item id is in the webhook body (makes sense).
Unpublish --> not only actually unpublished item id is in the webhook body, but all content item id's that use this unpublished item id as well.

The problem now is the Gatsby build seems to fail because the body contained more as one item id.
Repro steps
Unpublish an item that is used in several other content items.
Check the webhook body.
Check the Gatsby build process (error).
Expected behavior
As a quick fix, to remain backward compatible, the Kontent Gatsby module could drop all content items except the first one.
Screenshots / Description (PDF)
VBS-286703736-020821-1230-256.pdf

Hello @hderoeck,
The unpublish functionality is not handling the webhook body properly in the source plugin for this use case. I have probably missed the information that items might contain more items in case for ubpublish operation.
In the docs https://docs.kontent.ai/reference/webhooks-reference#a-item-objects, there is a description:

About the first item in the items array
When the notification's type is content_item_variant and its operation is archive, restore, publish, or unpublish, then the first item in the items array designates the content item that caused the notification to be sent. For example, if the operation is unpublish, then the first item in the array was unpublished and the other items were affected by this operation.

I guess I can start with option 2b but I am not 100% sure about the behavior of the affected items - I think it should perform the update out for the box without the necessity to process all items in an array because I am using GraphQL reference fields among Gatsby nodes (in this case  - content items variants).
Then I can release another beta version with option 2b on the top of the the version 7.1.0-beta.0 released from #184 (#185). Then you can test it out if it is OK and all items are properly updated - if not we can move to option 2a - sounds good @hderoeck?

Option 1 is out of the scope of this repository. (I have seen your conversation in Intercom, so this request should be processed via this channel).

That would be great! Thanks @@.***>!
(I’m adding my colleagues Sandra and Ken to this thread as well. I’ll be switching to another job at the end of the month and I want to make sure they are in the loop).
Henri De Roeck
Digital Enterprise Architect
<EMAIL_ADDRESS>+32 473 56 18 01tel:+32 473 56 18 01
www.the-reference.comhttps://www.the-reference.com
[https://trmailsignature.blob.core.windows.net/referencemail/logo%402x.png]
[https://trmailsignature.blob.core.windows.net/referencemail/facebook%402x.png]https://www.facebook.com/agencythereference    [https://trmailsignature.blob.core.windows.net/referencemail/twitter%402x.png] https://twitter.com/thereference       [https://trmailsignature.blob.core.windows.net/referencemail/instagram%402x.png] https://www.instagram.com/reference.be/      [https://trmailsignature.blob.core.windows.net/referencemail/linkedin%402x.png] https://www.linkedin.com/company/the-reference
[https://trmailsignature.blob.core.windows.net/referencemail/banner2021.png]https://www.the-reference.com
From: Ondřej Chrastina @.>
Sent: maandag 2 augustus 2021 15:13
To: Kentico/kontent-gatsby-packages @.>
Cc: Henri De Roeck @.>; Mention @.>
Subject: Re: [Kentico/kontent-gatsby-packages] Publish webhook body versus Unpublish webhook body. (#189)
Hello @hderoeckhttps://github.com/hderoeck,
The unpublish functionality is not handling the webhook body properly in the source plugin for this use case. I have probably missed the information that items might contain more items in case for ubpublish operation.
In the docs https://docs.kontent.ai/reference/webhooks-reference#a-item-objects, there is a description:
About the first item in the items array
When the notification's type is content_item_variant and its operation is archive, restore, publish, or unpublish, then the first item in the items array designates the content item that caused the notification to be sent. For example, if the operation is unpublish, then the first item in the array was unpublished and the other items were affected by this operation.
I guess I can start with option 2b but I am not 100% sure about the behavior of the affected items - I think it should perform the update out for the box without the necessity to process all items in an array because I am using GraphQL reference fields among Gatsby nodes (in this case - content items variants).
Then I can release another beta version with option 2b on the top of the the version 7.1.0-beta.0 released from #184https://github.com/Kentico/kontent-gatsby-packages/issues/184 (#185https://github.com/Kentico/kontent-gatsby-packages/pull/185). Then you can test it out if it is OK and all items are properly updated - if not we can move to option 2a - sounds good @hderoeckhttps://github.com/hderoeck?

Option 1 is out of the scope of this repository. (I have seen your conversation in Intercom, so this request should be processed via this channel).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Kentico/kontent-gatsby-packages/issues/189#issuecomment-891015576, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APJPMEW3LCIRPAOYAG2CNSTT22KVJANCNFSM5BMWCT3Q.

Hello @hderoeck,
could you send me the Raw Logs from the Gatsby Cloud?
I have checked the code and the webhook processor should just raise a warning and process the first item already.
So I have tested your scenario and I might found a problem in RichTextElement component that is probably not ready to have some linked items empty, so I would like to compare the error messages. Mine is:

Error in function eval in ../../packages/gatsby-kontent-components/dist/rich-text-element/index.js:46
Cannot read property 'system' of null

Here you go (attachment).
Snip of the error:
@.***
Henri De Roeck
Digital Enterprise Architect
<EMAIL_ADDRESS>+32 473 56 18 01tel:+32 473 56 18 01
www.the-reference.comhttps://www.the-reference.com
[https://trmailsignature.blob.core.windows.net/referencemail/logo%402x.png]
[https://trmailsignature.blob.core.windows.net/referencemail/facebook%402x.png]https://www.facebook.com/agencythereference    [https://trmailsignature.blob.core.windows.net/referencemail/twitter%402x.png] https://twitter.com/thereference       [https://trmailsignature.blob.core.windows.net/referencemail/instagram%402x.png] https://www.instagram.com/reference.be/      [https://trmailsignature.blob.core.windows.net/referencemail/linkedin%402x.png] https://www.linkedin.com/company/the-reference
[https://trmailsignature.blob.core.windows.net/referencemail/banner2021.png]https://www.the-reference.com
From: Ondřej Chrastina @.>
Sent: dinsdag 3 augustus 2021 9:41
To: Kentico/kontent-gatsby-packages @.>
Cc: Henri De Roeck @.>; Mention @.>
Subject: Re: [Kentico/kontent-gatsby-packages] Publish webhook body versus Unpublish webhook body. (#189)
Hello @hderoeckhttps://github.com/hderoeck,
could you send me the Raw Logs from the Gatsby Cloud?
I have checked the code and the webhook processor should just raise a warning and process the first item already.
So I have tested your scenario and I might found a problem in RichTextElement component that is probably not ready to have some linked items empty, so I would like to compare the error messages. Mine is:
Error in function eval in ../../packages/gatsby-kontent-components/dist/rich-text-element/index.js:46
Cannot read property 'system' of null
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Kentico/kontent-gatsby-packages/issues/189#issuecomment-891614357, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APJPMERNE2ULPGHCCCYJ7YLT26MR5ANCNFSM5BMWCT3Q.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.
14:16:54 PM:

info Running Inc Build CLI v1.0.6
14:16:54 PM:

success createSchemaCustomization - 0.037s
14:16:54 PM:

verbose<PHONE_NUMBER>7 Handling unpublish from delivery_production API
14:16:54 PM:

warning Webhook contains more than one item! - contains (3)
14:16:55 PM:

info sourceNodes webhookBody: {"data":{"items":[{"id":"46af4a33-74fa-4326-8836-dd9b6c83ecab","codename":"this_is_a_reusable_text_block","language":"en","type":"text_block","collection":"default"},{"id":"03697541-16b9-447e-8fb1-16add0c0b1c9","codename":"test_pages","language":"en","type":"page","collection":"default"},{"id":"a94dc97d-fa27-475d-b538-2a9c698ef47f","codename":"sandra_s_test_page","language":"en","type":"page","collection":"default"}],"taxonomies":[]},"message":{"id":"19300e16-d269-47c1-8f8d-db2b9e625d4e","project_id":"02e4f0f4-5261-0177-6b6c-ce0b13bbce67","type":"content_item_variant","operation":"unpublish","api_name":"delivery_production","created_timestamp":"2021-08-02T12:16:46.7865599Z","webhook_url":"https://webhook.gatsbyjs.com/hooks/data_source/publish/fe5d3432-cc22-484b-807a-a36970f8729e"}}
14:16:55 PM:

success Refreshing source data - 1.093s
14:16:59 PM:

success rebuild schema - 3.827s
14:16:59 PM:

success Reprocessing static & page queries - 0.002s
14:16:59 PM:

verbose<PHONE_NUMBER>07 PROCESSING_DATA triggered
14:16:59 PM:

info Running createPages
14:16:59 PM:

success Creating homepage - 0.155s
14:16:59 PM:

success Creating articles - 0.042s
14:16:59 PM:

success Creating faculties - 0.042s
14:16:59 PM:

success Generating top data - 0.040s
14:16:59 PM:

success Creating pages - 0.141s
14:17:00 PM:

success Creating events - 0.360s
14:17:00 PM:

success Creating programmes - 0.432s
14:17:00 PM:

verbose<PHONE_NUMBER>8 Emitting CREATE_PAGE_END
14:17:00 PM:

verbose<PHONE_NUMBER>44 query run triggered 5
14:17:00 PM:

info {"newPages":[],"deletedPages":[]}
14:17:00 PM:

success createPages - 0.542s
14:17:00 PM:

verbose<PHONE_NUMBER>53 running static queries(1):["sq--src-static-queries-use-site-urls-ts"]
14:17:00 PM:

verbose<PHONE_NUMBER>8 PROCESSING_DATA triggered
14:17:00 PM:

verbose<PHONE_NUMBER>18 running page queries(4): ["/nl/faculties/martin-weiss","/en/test-pages/sandra-s-test","/en/test-pages","/sitemaphtml/"]
14:17:00 PM:

success run static queries - 0.069s
14:17:00 PM:

success run page queries - 0.390s
14:17:00 PM:

success Reprocessing static & page queries - 0.469s
14:17:00 PM:

success write out requires - 0.003s
14:17:01 PM:

failed Building static HTML for pages - 0.969s
14:17:01 PM:

error Building static HTML failed for path "/en/test-pages"
14:17:01 PM:

  48 |         if (isLinkedItem(domNode)) {
14:17:01 PM:

> 50 |             const linkedItem = linkedItems.find(item => item.system.codename === codeName);
14:17:01 PM:

  49 |             const codeName = (_a = domNode.attribs) === null || _a === void 0 ? void 0 : _a['data-codename'];
14:17:01 PM:

     |                                                              ^
14:17:01 PM:

  51 |             return resolveLinkedItem(linkedItem);
14:17:01 PM:

  53 |     }
14:17:01 PM:
14:17:01 PM:

  52 |         }
14:17:01 PM:

  WebpackError: TypeError: Cannot read property 'system' of null
14:17:01 PM:

14:17:01 PM:

  - index.js:50
14:17:01 PM:

  - index.js:50
14:17:01 PM:

<EMAIL_ADDRESS>   js:50:44
14:17:01 PM:

14:17:01 PM:

14:17:01 PM:

  - index.js:74
14:17:01 PM:

<EMAIL_ADDRESS>   js:50:62
14:17:01 PM:

14:17:01 PM:

<EMAIL_ADDRESS>   js:74:31
14:17:01 PM:

    [vlerick]/[html-react-parser]/lib/dom-to-react.js:38:1
14:17:01 PM:

  - dom-to-react.js:38
14:17:01 PM:

14:17:01 PM:

    [vlerick]/[html-react-parser]/index.js:26:1
14:17:01 PM:

14:17:01 PM:

  - index.js:26
14:17:01 PM:

  - cache-common.esm.js:7
14:17:01 PM:

<EMAIL_ADDRESS>   js:73:48
14:17:01 PM:

14:17:01 PM:

  - index.js:73
14:17:01 PM:

    ***@***.***/cache-common/dist/cache-common.esm.js:7:1
14:17:01 PM:

  - cache-common.esm.js:10
14:17:01 PM:

14:17:01 PM:

  - cache-common.esm.js:16
14:17:01 PM:

    ***@***.***/cache-common/dist/cache-common.esm.js:10:1
14:17:01 PM:

14:17:01 PM:

    ***@***.***/cache-common/dist/cache-common.esm.js:16:1
14:17:01 PM:

14:17:01 PM:

14:17:01 PM:

    ***@***.***/cache-common/dist/cache-common.esm.js:15:10
14:17:01 PM:

  - cache-common.esm.js:15
14:17:01 PM:

14:17:01 PM:

  - client-common.esm.js:26
14:17:01 PM:

  - cache-common.esm.js:26
14:17:01 PM:

  - static-entry.js:263
14:17:01 PM:

14:17:01 PM:

    ***@***.***/cache-common/dist/cache-common.esm.js:26:1
14:17:01 PM:

    vlerick/.cache/static-entry.js:263:20
14:17:01 PM:
14:17:01 PM:

14:17:01 PM:

    ***@***.***/client-common/dist/client-common.esm.js:26:1

Thanks @hderoeck,
I can see the same error in your log:

WebpackError: TypeError: Cannot read property 'system' of null
@.***/gatsby-kontent-components/dist/rich-text-element/index.    js:50:44

for next time, could you use GitHub UI directly for a reply instead of email? The Email integration on GitHub is not great and it is hard to find anything in the reply. And if you want - feel free to clear out the log for any sensitive info, because it is publicly available on https://github.com/Kentico/kontent-gatsby-packages/issues/189.

@hderoeck, I have found a route cause of this issue.
When the Webhook processor is handling the Deletion (Unpublish) of the Node it uses deleleteNode method as described in Gatsby documentation.
Current Gatsby behavior is that GraphQL node is deleted and for all references on it are replaced with null:
{
// ...
"bio": {
              "modular_content": [
                null, // HERE WAS THE LINK
                {
                  "system": {
                    "codename": "simply007_kontent_gatsby_benchmark"
                  },
                  "elements": {
                    "name": {
                      "value": "Simply007/kontent-gatsby-benchmark"
                    },
                    "url": {
                      "value": "https://github.com/Simply007/kontent-gatsby-benchmark"
                    }
                  }
                }
              ],
              "value": "VALUE OF THE RICH TEXT ELEMENT"
}

This was not expected in the RichTextElement so that no check for null was made and I will need to ask why this happens on Gatsby's side.
I have implemented the null check and if the item is null I can pass null to resolveLinkedItem and you could handle the behavior yourself - what should happen if the item is not in the modular_content. - https://github.com/Kentico/kontent-gatsby-packages/pull/185/commits/3a3f21813aa036abad5fd034cfe795dccc905f69
To prevent you get null in resolveLinkedItem source plugin is calling upsert to all items but the first in items property and this should correctly remove nulls in the modular_items array. - https://github.com/Kentico/kontent-gatsby-packages/pull/185/commits/6ec2ed77026465957597b1bc93e8b3dec8fbe35d

Hey @hderoeck - I have release version 7.2.0-beta.0 for both packages (source plugin and components).
Could you test it out and give me feedback?

Just a heads-up I am on vacation from 2021-08-05 to 2021-08-08 so I will be available next week.

Hey @Simply007 , it seems to work as intended! Thanks.

Thanks @hderoeck, I will aim to finish the test and release the 7.2.0 version next week.

Thanks, @Simply007 . Once again, we experience the great support from Kentico Kontent!

Fix and tests are ready to be released in version 7.2.0.

Released in https://github.com/Kentico/kontent-gatsby-packages/releases/tag/7.2.0


wrong SKE cluster creation example

The provided example for SKE cluster creation is wrong and needs some fixing
resource "stackit_ske_cluster" "example" {
  project_id         = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
  name               = "example-name"
  kubernetes_version = "1.25"
  node_pools = [
    {
      name               = "np-example"
      machine_type       = "b1.2"
      os_version         = "3510.2.5"
      minimum            = "2"
      maximum            = "3"
      availability_zones = ["eu01-3"]
    }
  ]
  maintenance = {
    enable_kubernetes_version_updates    = true
    enable_machine_image_version_updates = true
    start                                = "01:00:00Z"
    end                                  = "02:00:00Z"
  }
}

The os_version must be updated to 3510.2.7, the current one doesn't work
The name is unacceptable according to the regex used to verify it is 12 characters long and the regex says it must be at most 11
The used regex allows - at the end but the error message says it doesn't allow them
The regex allows - in the name but the SKE API doesn't allow them and it looks like that it doesn't have a 11 character size limit.

The v08.0 release removes the cluster name regex validation (which is now done solely by the SKE API). The example was also updated.


JIT - Channel Fee: LSP Flow

Follow-up ticket from #577
LSP flow: there is work on Bolt X (TBD) which says that nodes may accept payments smaller than amounts in the invoice. Once this is done, we can subtract a channel fee from the payment amount same as Breez does. This is defined in LSPS2 of the upcoming LSP Spec and will find its way into bolts and all implementations soon. https://github.com/get10101/10101/issues/393

Might work once we upgrade to 0.116 of LDK: https://github.com/lightningdevkit/rust-lightning/issues/1999


Nudge.app path

where should it go?
I'm thinking /Applications/Utilities

Makes sense, any reason not to just use the normal /Applications/?

People will delete things in /Applications. Let's just say it's going to /Applications/Utilities


feat(color): add data viz color palette

Summary
Added data viz color palette subcomponent under foundation color palette component.
Figma Link
https://www.figma.com/design/9NrpK3rmbOk0lhlFkEPSaO/Data-Viz-Component-Library?node-id=1365-884&node-type=frame&m=dev
ADO Story or GitHub Issue Link
https://dev.azure.com/Kyndryl/Shidoka - Bridge Design System/_workitems/edit/1931328
Checklist

[x] Used Conventional Commit messages as outlined in the contributing guide.

[x] Noted breaking changes (if any).

[ ] Documented/updated all props, events, slots, parts, etc with JSDoc.

[x] Ran the analyze command to update Storybook docs.

[ ] Added/updated Stories with controls to cover all variants.
[ ] Ran test locally to address any failures.
[ ] Added/updated the Figma link for the Story's Design tab.

Screenshots

In sequence 01
Observed that color code is 01-10 in figma and preview its 01-01 for the same color
Same must be checked in all other sequence!!


Flutter tool should print adb error

When adb fails during a flutter run, we print the non-descriptive error:
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Running 'gradle assembleDebug'...                    10.5s
Built build\app/outputs/apk/app-debug.apk (21.7MB).
Installing build\app/outputs/apk/app.apk...           0.8s
Error: ADB exited with exit code 1

adb itself has more descriptive errors:
adb.exe install C:\Users\mit\tmp\app200\build\app/outputs/apk/app-debug.apk
Failed to install C:\Users\mit\tmp\app200\build\app/outputs/apk/app-debug.apk:
Failure [INSTALL_FAILED_INSUFFICIENT_STORAGE]

Can we print those?

cc @tvolkert @jason-simmons

Yep, we should be able to get the stderr from the process and print it upon failure.


RubyTime object is not Logstash::Timestamp

It appears that the JDBC plugin is grabbing timestamps correctly, but it's only converting them to RubyTime objects, which is not the same thing as a Logstash::Timestamp.  This conversion should be possible without resorting to a ruby{} filter.
See: https://discuss.elastic.co/t/logstash-date-filter-question/33663

A temporary workaround:
ruby {
  code => "event['event_date'] = LogStash::Timestamp.new(event['event_date'])"
}

Bad news Aaron, I'm getting an error with your workaround:
Ruby exception occurred: uninitialized constant Logstash::Filters::Ruby::Logstash {:level =>:error, :file=>"logstash/filters/ruby.rb", :line=>"41", :method=>"filter"}

My apologies, I transcribed "LogStash::Timestamp.new" as "Logstash::Timestamp.new". When I capitalized the "S" your code worked. Thanks again.

Excellent!  I'll close this now.

I meant your workaround code works. The jdbc input plugin is still indexing date fields as strings.

Right. Oops :smile:

This has been fixed in #83


Cop idea: assign variable directly to result of if/unless block

I often encounter a pattern where developers set some variable to nil, and then set it again inside an if/unless block. The same can be achieved by simply assigning the result of the if block directly to the variable.
# bad
result = nil
if cond?
  result = foo(...)
end

# good
result = if cond?
  foo(...)
end

You don't even need to have the variable outside, you can also do this:
if cond?
  result = foo(...)
end

Regardless of if the branch is entered, the result variable will be defined after. Though I agree that the second one looks cleaner

Can you first open a proposal in the style guide to discuss the merits and demerits of this style?
https://github.com/rubocop/ruby-style-guide


[docs] CONTRIBUTING is not read by default

One more click might improve the review experience.

Let's try :microscope:.


Integrate encoding and encryption

Encoded iris codes into polynomials (encoded module).
Encrypt them.
Multiply a code and a query.
Decrypt the result including inner products.
Compare to threshold in plaintext.

This comment from Bryan about resolutions might be helpful here:
https://github.com/Inversed-Tech/eyelid/issues/37#issuecomment-2148045822


SFTP loading icon

The plugin works great connects fine upload files no problem then every so often when going to upload a file it seems to get stuck
Bottom left I have SFTP and the animated squares any ideas? this is the same on both laptop and pc
VS Code 1.35.1
SFTP v 1.12.7

Do you read the FAQ?

[ ] Yes.
[ ] I am going to read now.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Run command '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Mac, Win, Linux]
VSCode Version [e.g. 1.27.0]
Extension Version [e.g. 1.7.0]

Extension Logs from Startup - required

Open User Settings.

On Windows/Linux - File > Preferences > Settings
On macOS - Code > Preferences > Settings

Set sftp.debug to true and reload vscode.

Reproduce the problem, get the logs from View > Output > sftp.


[Event Change] Report 699 - Calculate Plan - Req. Wksh. - OnAfterOnOpenPage

Hi al-team,
can you please add the following parameters to the Publisher OnAfterOnOpenPage?
        trigger OnOpenPage()
        begin
            MfgSetup.Get;
            UseForecast := MfgSetup."Current Production Forecast";
            // NEW FromDate, ToDate
            OnAfterOnOpenPage(FromDate,ToDate);
        end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterOnOpenPage(var FromDate: Date; var ToDate: Date)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[ERROR] Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.

Describe the bug
A clear and concise description of what the bug is.
I am getting this error message:
[ERROR] Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
Version of dependency-check used
The problem occurs using version X.X.X of the ____ (cli, gradle plugin, maven plugin, etc.)
I am using Jenkins plugin for dependency check version 5.3.2
I am passing the following arguments to the dependency check:
--disableAssembly  true
--disableNodeJS  true
Log file
When reporting errors, 99% of the time log file output is required. Please post the log file as a gist and provide a link in the new issue.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Facing same issue too

Same here.

Any chance someone can provide a sample project, a log file, etc.?

Any chance someone can provide a sample project, a log file, etc.?

Is this of any help?
2020-09-03 10:32:58,864 org.owasp.dependencycheck.App:208
ERROR - Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
2020-09-03 10:32:58,865 org.owasp.dependencycheck.App:209
DEBUG - unexpected error
org.owasp.dependencycheck.analyzer.exception.SearchException: Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
        at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:209)
        at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:133)
        at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzePackage(NodeAuditAnalyzer.java:303)
        at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzeDependency(NodeAuditAnalyzer.java:186)
        at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
        at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
        at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:834)
2020-09-03 10:32:58,865 org.owasp.dependencycheck.utils.Settings:722
DEBUG - Deleting ALL temporary files from `/tmp/dctempa6bf8001-496e-495a-b4d6-bcbac6b1bf0f`
2020-09-03 10:32:58,884 org.owasp.dependencycheck.App:82
DEBUG - Exit code: -14

Specifically, there is a section that lists what is sent for analysis. Unfortunately, it is not clearly labelled in the log - but it is generated by:
                LOGGER.debug("----------------------------------------");
                LOGGER.debug("----------------------------------------");
                LOGGER.debug(packageJson.toString());
                LOGGER.debug("----------------------------------------");
                LOGGER.debug("----------------------------------------");

Thanks for your comments. My issue turned out to come from package-lock.json which was generated from yarn.lock with synp. It used to work but broke with dependency changes to fix CVEs.

What was the specific problem with the generated package-lock.json?

What was the specific problem with the generated package-lock.json?

We could not conclude - it broke in our CI but I could not reproduce it locally. CI is Drone-based, high volume disposable build envs. Generated package-lock.json are already gone but I've got a full, packed log line if you're interested.
Fix was to drop synp and generate package-lock.json for scan with npm directly from package.json rather than through yarn && synp. Yarn is still used for build. In addition, dependency-check parameters we adjusted according to your recommendation.

Hey guys,
Locally the error does not occur, but when I run it in a controlled environment, it bursts the error
DEBUG - Invalid payload submitted to Node Audit API. Received response code: 400 Bad Request
2020-09-21 19:47:36,170 org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer:326
ERROR - NodeAuditAnalyzer failed on /owaspdc/package-lock.json
2020-09-21 19:47:36,170 org.owasp.dependencycheck.AnalysisTask:90
WARN  - An error occurred while analyzing '/owaspdc/package-lock.json' (Node Audit Analyzer).
2020-09-21 19:47:36,171 org.owasp.dependencycheck.AnalysisTask:91
DEBUG -
org.owasp.dependencycheck.analyzer.exception.SearchException: Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:209)
at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:133)
at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzePackage(NodeAuditAnalyzer.java:304)
at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzeDependency(NodeAuditAnalyzer.java:187)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
2020-09-21 19:47:36,172 org.owasp.dependencycheck.Engine:708
and
ERROR - Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
2020-09-21 19:49:48,420 org.owasp.dependencycheck.App:209
DEBUG - unexpected error
org.owasp.dependencycheck.analyzer.exception.SearchException: Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API.
at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:209)
at org.owasp.dependencycheck.data.nodeaudit.NodeAuditSearch.submitPackage(NodeAuditSearch.java:133)
at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzePackage(NodeAuditAnalyzer.java:304)
at org.owasp.dependencycheck.analyzer.NodeAuditAnalyzer.analyzeDependency(NodeAuditAnalyzer.java:187)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
2020-09-21 19:49:48,420 org.owasp.dependencycheck.utils.Settings:747
DEBUG - Deleting ALL temporary files from /tmp/dctemp3ef3dd9b-53c2-489a-ad32-a9555ede4021
2020-09-21 19:49:48,447 org.owasp.dependencycheck.App:82
DEBUG - Exit code: -14
The controlled environment machine has free internet access!
this was extracted from the --log odc.log
Can anyone help solve this?

@Sysobas What package manager are you using?

I am using package 6.0.1

Using 6.0.3 seeing the same error. I am using synp to generate the lock file from yarn's lock file. Here is the Node Audit Analyzer section of the debug log.
owaspDebug.log

At the moment yarn.lock is still not supported.  The work around of using synp works for many. However, the output from synp does not appear to match what npm itself creates. Some specific examples:

In the yarn/synp example output provided by @ssthom there are sha1 digests whereas using npm itself we get sha-512. I doubt this is the cause of the error though.
yarn/synp appears to provided nested dependencies - whereas using npm these are flattened:

using yarn/synp
        "@apollo/client": {
            "version": "3.3.6",
            "integrity": "sha1-81lkYwgWfzjVvEmN/CNEyIhAAJM=",
            "requires": {
                "@graphql-typed-document-node/core": "^3.0.0",
                "@types/zen-observable": "^0.8.0",
                "@wry/context": "^0.5.2",
                "@wry/equality": "^0.3.0",
                "fast-json-stable-stringify": "^2.0.0",
                "graphql-tag": "^2.11.0",
                "hoist-non-react-statics": "^3.3.2",
                "optimism": "^0.13.1",
                "prop-types": "^15.7.2",
                "symbol-observable": "^2.0.0",
                "ts-invariant": "^0.6.0",
                "tslib": "^1.10.0",
                "zen-observable": "^0.8.14"
            },
            "dependencies": {
                "symbol-observable": {
                    "version": "2.0.3",
                    "integrity": "sha1-W1IdPQekPDUQVfpDuDVbYtM/0Wo="
                }
            }
        }

using npm
        "@apollo/client": {
            "version": "3.3.6",
            "integrity": "sha512-XSm/STyNS8aHdDigLLACKNMHwI0qaQmEHWHtTP+jHe/E1wZRnn66VZMMgwKLy2V4uHISHfmiZ4KpUKDPeJAKqg==",
            "requires": {
                "@graphql-typed-document-node/core": "^3.0.0",
                "@types/zen-observable": "^0.8.0",
                "@wry/context": "^0.5.2",
                "@wry/equality": "^0.3.0",
                "fast-json-stable-stringify": "^2.0.0",
                "graphql-tag": "^2.11.0",
                "hoist-non-react-statics": "^3.3.2",
                "optimism": "^0.13.1",
                "prop-types": "^15.7.2",
                "symbol-observable": "^2.0.0",
                "ts-invariant": "^0.6.0",
                "tslib": "^1.10.0",
                "zen-observable": "^0.8.14"
            }
        },
        "symbol-observable": {
            "version": "2.0.3",
            "integrity": "sha512-sQV7phh2WCYAn81oAkakC5qjq2Ml0g8ozqz03wOGnx9dDlG1de6yrF+0RAzSJD8fPUow3PTSMf2SAbOGxb93BA=="
        }

As always - PRs are welcome. In the meantime I would suggest using yarn audit - which in reality will likely give the exact same results as using the current version of ODC.

@jeremylong Taking an initial look at what it would take to support yarn. Would I just need to update NpmPayloadBuilder.java with different logic depending on the lockfile type.

@jeremylong Any guesses to when 6.0.6 is going to be released?

@jeremylong Any guesses to when 6.0.6 is going to be released?

relatively soon - likely this weekend.

Hi - did anyone ever fix this?  I am running into the same issue as of today.  npm audit works fine, but this fails.  I also have open Internet Access...

the same issue :-(

in our case, removed some duplicate deps and did some clean ups. In our  dependencies in package.json, We had duplicates in devdependencies and dependencies. that helped.

I'm still getting this issue. I'm not using yarn or synp and it's not consistent across projects. I have 2 and the package lock was built with npm 9.5.0, one works fine and the other doesn't. The full log is below for the one that doesn't. Also, running npm audit works just fine.
dependency-check.log

In Jenkins Global Tools Configuration, add NodeJs version of 10.19.0. This solved my issue. Initially i added the latest version, I think you should try it for other versions too. But in my case i use NodeJs 10.19.0


Minor improvement on cbloader & Rename api.load() arg data to options

Little changes...
Motivation
I use cbloader and the data of representation object is required but the tool did not pass it.
Implementation
Add one line to extract data from representation and pass to api.load.
Also, I noticed that instead passing the ObjectId of representation to api.load, directly pass the representation object can reduce one database query, since the function get_representation_context which been used here, is able to accept both form.

Correct me if I am wrong, in my understanding, api.load is officially require representation id to acquire context, so that it can pass context to Loader.load.
And the one who responsible to acquire context from representation id is the function get_representation_context, which currently work as follow pseudo code:
def get_representation_context(representation):
    if isinstance(representation, (str, ObjectId)):
        representation = io.find_one({"_id": ObjectId(str(representation))})

    # acquire context
    ...
    return context

def load(Loader, representation, namespace=None, name=None, data=None):
    ...
    context = get_representation_context(representation)
    ...

The argument representation is actually able to be accepted as str or ObjectId or dict.
Thus, api.load should be able to accept representation dict directly as well, and prevent one extra unnecessary database query.

The data argument is intended for tool specific input, e.g. with_selection=True or animation=False. Almost like settings/options.

Sounds like we have different future use case on this ?
Is the tool you refer is Colorbleed's in-house tool ?

but it has no function if it's used for the data that is housed in the database on the representation.

Yes, but I did write something to the representation["data"] with my extractor plugins, and those data is required for my loaders to process representations.
Thanks for the reply @BigRoy :)
Please let me know what you think

Hey, I am back on this :)
But I am still not quite understand on this :

I wouldn't explicitly pass data from the representation if it's in the representation anyway.

Isn't that right the data of the representation should be accepted by the Loader by default ?
Since the field data is from the Avalon integrator plugin.
Thanks!

I think what Roy is saying is that the data= of a representation isn't the same as the data passed here. Maybe we should rename this data= argument to avoid confusion in the future. That argument is for tool options. Maybe options= or opts=?
The reason it isn't passed at the moment, is because there aren't any options for this particular tool, is that right @BigRoy? Does that make sense @davidlatwe?

The reason it isn't passed at the moment, is because there aren't any options for this particular tool, is that right @BigRoy?

Yes, that is what I meant.

Thus, api.load should be able to accept representation dict directly as well, and avoid one extra unnecessary database query.

If it technically works it's fine with me - I just recalled that the API wasn't intended to function that way but might have assumed wrong and jumped the gun on the answer.

The issue regarding the data is that it's indeed not clearly passed from the get go as "data" or "representation" - however the data is present even without explicitly passing it so you don't need to pass it yourself.
You can find it in the load function in the context argument, specifically:
representation = context["representation"]
data = representation["data"]

That's what I meant with the fact that you wouldn't need to pass that explicitly, that particular data is already available to you in the load method. Making this change in code redundant, correct?
Does that help?

Ah ah! I see now !
Thanks for your help @mottosso & @BigRoy . :)
Let me try this on my plugins

Renaming data to options seems to be logical, since avalon.api.create has the same param interface, it has both options and data with different purposes.
"""
Arguments:
        name (str): Name of subset
        asset (str): Name of asset
        family (str): Name of family
        options (dict, optional): Additional options from GUI
        data (dict, optional): Additional data from GUI
"""

I did not take too much attention on Creator Plugin, knowing that there are options param already exists on api.create, starting to make more sense now.

I tweaked my PR, added argument renaming (data -> options on api.load).
Works on my end, should also maintained backward compatibility.
What do you think ?

Sorry, I thought I replied to this. This looks good to me if it works. :) Just commented on one minor typo.
@aardschok what do you think?

@davidlatwe Nice work!

I have no objections to this, nice work!

Thanks !  I got them fixed :P

Sphinx's latest release 1.8.0  will fail the document build.
Lock version to 1.7.9 for now.

Are these latest commits supposed to be part of the same PR?

Sorry, that should be separate.
I'll reset it and do the right thing.

Okay it's done, I'll put that (pin sphinx==1.7.9) in next PR alone, sorry for the trouble :cry:

Please merge #338 first and I will rebase this PR so the travis will pass :)

Thanks @davidlatwe!


Allow custom image and font URL helpers

Proposing this as a solution to #730.
Closes #730

I'd expect it to be documented as part of https://github.com/alphagov/govuk-frontend/blob/doc-updates/docs/installation/installing-with-npm.md#import-images, but waiting for that branch to be merged first.

Going to merge this and we can add the docs later.


remove redundant parantheses

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@fivetwentysix

Please sign the CLA here.

Thank you for the PR, but as @btm mentioned this is really just a style tweak.

Removing the space between the parens and the method would definitely fit into a larger style cleanup though.


Controls: Remove timer-based auto-render system

This issue tracks discussion/PRs related to removal of the automatic render system.
Problem: After adding data to a Plot in a user control, that control's Render() must be called to display the change. Currently there is an auto-render system which periodically checks the number of plottable objects and calls Render() if it changes. This timer system is prone to memory leaks and may also result in unwanted renders at inopportune times (#1117).
formsPlot1.Plot.AddScatter(xs, ys);
formsPlot1.Render(); // <-- this line is required if automatic renders are disabled

Upgrading: If the auto-render functionality is removed, users who upgrade will have to add the Render() line themselves. To make this more obvious an error message will be displayed on the plot when the debugger is attached if the control is displayed but the user never called Render() on start-up.

Sorry but for me it's not clear how update my code 🤔
First I initialize the plot by setting some properties and adding my 'signalplot' values, then I call the Render method (at the end of all the plot initialization).
Probably the problem on my side is that, when update the values data of my plot, I'm using the RenderRequest of the WpfPlot control.
If instead to use the RenderRequest I'm using the Render method the warning message disappear and the plot is shown correctly.
Is it wrong to use the method RenderRequest?

@gigios thank you for reporting this! This is a bug and I'll track its progress in #1251
A temporary fix is to disable the warning
formsPlot1.Configuration.WarnIfRenderNotCalledManually = false;


Update the metadata editor with new component

The metadata editor should be updated using this component: https://koumoul-dev.github.io/vuetify-jsonschema-form/latest/

Closed via #564


Rich text output

If possible we should build an API which allows one easily write nice colored and styled text.
Styles are not a requirement I think, but at least a single rich style should be enough.

Implement a tool which allows writing ANSI escape code with ease, but it will be limited to the project needs.


Odd behavour with Handlebars helper

I have this helper function that switches out glyphs based on data object
handlebars.registerHelper('getIconClass', function () {
  var chassisType = data.data[0].chassisType.toLowerCase();
  if (chassisType === 'laptop') {
    return 'fas fa-laptop fa-7x';
  } else if (chassisType === 'desktop') {
    return 'fas fa-desktop fa-7x';
  } else {
    return 'fas fa-question fa-7x'; // default icon if model doesn't match any case
  }
});

I use this in my HTML here

Elsehwere on my dashbaord i have another seperate dynamictext panel that has a glyph that doesnt call this helper but is changed whenever the helper is run. Why is that?

@craftzneko Handlebars Helpers are global, they are not limited to the specific panel.
I don't really understand the questions. Could you please add details what is changing and how.

It actually is working now after changing the logic, I must have made a mistake.

@craftzneko Thank you for confirming.
We released a new version of the Dynamic Text which was just updated in the Grafana Catalog.


Can I use named components multiple times ?

route.js
<Route path='/' component={App}>
  <IndexRedirect to='/react'/>
  <Route path='react' components={{sidebar: Sidebar, main: Main}}>
    <IndexRoute component={ArticleList}/>
    <Route path='function-bind' component={FunctionBind}/>
    <Route path='react-component-with-es5-es6-es7-syntax' component={Table}></Route>
    <Route path='dynamic-inline-style' component={DynamicInlineStyle}></Route>
    <Route path='refs-to-component' component={Ref}></Route>
    <Route path='stateless-functional-component' component={StateLessFunctionalComponent}></Route>
    <Route path='this-props-children' component={ThisPropsChildren}></Route>
    <Route path='inherit-component' component={InheritComponent}></Route>
  </Route>
  <Route path='react-router' components={{sidebar: Sidebar, main: Main}}>
    <IndexRoute component={ArticleList}/>
    <Route path='call-react-dom-render-in-parent-component' component={CallReactDOMRenderInParentComponent}/>
  </Route>
</Route>

App.react.js
const {main, sidebar} = this.props;

When I reach the react path, the named components sidebar and main components worked fine. But when I reach the react-router path, I got main and sidebar undefined.  Webpack build is valid, Chrome console throw no error.
I want react and react-router and siblings route have same sidebar and main named components. How to do that?

Those will come through on this.props.children. I'm not sure how your App component is working with one route, as that line should be:
const { main, sidebar } = this.props.children


"Cannot set headers after they are sent to the client" when visiting home logged in

Fix: https://github.com/cirosantilli/Conduit_NodeJS/commit/0099adfba42729cb7632f2b7e081c2b3269ef213#diff-30caa90706d3a2cdb7be281b1f0ca6d5b613c60326e5f2ebb5544edbfb904c0eR277
Because two res.json were called when there are no followers.
    (node:196962) UnhandledPromiseRejectionWarning: Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
        at ServerResponse.setHeader (_http_outgoing.js:558:11)
        at ServerResponse.header (/home/ciro/git/Conduit_NodeJS/node_modules/express/lib/response.js:771:10)
        at ServerResponse.json (/home/ciro/git/Conduit_NodeJS/node_modules/express/lib/response.js:264:10)
        at module.exports.getFeed (/home/ciro/git/Conduit_NodeJS/controllers/articles.js:299:33)

Fixed the issue and also updated the error messages. 👍


fix: throw an error if .poll or .element wasn't awaited

Description
If expect.poll().to* or expect.element().to* is not awaited, the test will now fail. The stack trace leads to the line where it's called.

TODO:

[x] Test
[x] Docs update

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa this was pretty easy to do 😄

I was bitten by this many times :sweat:
good stuff to have this

should we do the same with .resolves and .rejects? 🤔

Does this means we remove recordAsyncExpect trick for auto await? I would prefer the change as it would be more well-defined behaviors for users. I guess technically that would be breaking change though.

should we do the same with .resolves and .rejects? 🤔

Does this means we remove recordAsyncExpect trick for auto await? I would prefer the change as it would be more well-defined behaviors for users. I guess technically that would be breaking change though.

Hm, I am not sure what is better 🤔 I like to be stricter, but I don't know if we can enforce it now 🤔 The expect.resolves basically implicitly becomes expect.soft.resolves right now, and it's documented

I think maybe we should also throw an error or show a warning if locator methods were not awaited:
getByRole('button').click()
expect(button).toHaveText('123')

React shows a warning if React.act wasn't called, and we can maybe do the same instead of failing the test 🤔


Delete statement

This PR adds GenerateDelete() to Statement Generator.
This function generates the DELETE_STATEMENT for one of the tables from the context or based on the randomly generated table references.
What's more, this PR removes .github/workflows/_extension_deploy.yml file and updates .github/workflows/MainDistributionPipeline.yml to use the _extension_deploy.yml from the extension-ci-tools instead of a local copy, as @samansmink recommended to do. Also the wasm_mvp;wasm_eh;wasm_threads and windows_amd64_rtools are skipped for now.

@Tmonster could you please review this PR?

Looks like the duckdb submodule is being updated? Is that still necessary? It should point to v1.0.0 already right?

You are right, through that commit out

LGTM, can you resolve the merge conflicts?


remove SkipPublisherCheck switch

It is not necessary to enable the switch.

-SkipPublisherCheck
Allows you to install a newer version of a module that already exists on your computer. For example, when an existing module is digitally signed by a trusted publisher but the new version isn't digitally signed by a trusted publisher.

@sethmanheim
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Implement new design for the TUI

Make a UI design for the TUI in a design software like Figma, Adobe Xd, or Sketch.
We're looking for a design where we can accommodate a search bar, a list view of the available templates, and a preview of the boilerplate repository if possible. Any further additions are welcome.
Give a link to your design file in the README while making the PR, and make sure the link that you give is made public. (You may also include screenshots of the design in the PR if you wish)

Hello, this took me 5-10 minutes to ideate and make, love this, I'll learn some rust and try to contribute
:link: : Figma Link
I think showing some repo stats is a good idea, I'd love to know about the number of open issues and stars atleast
Screenshot:

I'll make this a PR if I'm short on hacktoberfest contributions :wink:

Lol. They look great! Thanks a lot for the contribution! You can go ahead and open a PR with just the figma link, and we'd be happy to accept it :)

Should I put it in the readme?

Yes, definitely! BTW, If you could add some colour in the designs, would be great!

Yes, definitely! BTW, If you could add some colour in the designs, would be great!

sure, should I go with hacktoberfest theme?

closing as complete.


Backport "HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC (#5145)" to branch-2.4

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
branch-2.4 passed

+1 :green_heart:
compile
0m 53s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
3m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  9s
hbase-logging in the patch passed.

+1 :green_heart:
unit
168m 10s
hbase-server in the patch passed.

191m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 15de84c219d2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 81671f2b3f

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/testReport/

Max. process+thread count
2515 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
branch-2.4 passed

+1 :green_heart:
compile
0m 46s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
5m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 12s
hbase-logging in the patch passed.

+1 :green_heart:
unit
222m 25s
hbase-server in the patch passed.

248m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 9e37b360413b 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 81671f2b3f

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/testReport/

Max. process+thread count
2306 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 28s
branch-2.4 passed

+1 :green_heart:
compile
2m 33s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 40s
branch-2.4 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 40s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  2s
the patch passed

+1 :green_heart:
compile
2m 33s
the patch passed

+1 :green_heart:
javac
2m 33s
the patch passed

+1 :green_heart:
checkstyle
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
23m  3s
Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

43m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
dupname asflicense spotless javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 03176e1dae13 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 34b5d64ae0

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 26s
branch-2.4 passed

+1 :green_heart:
compile
0m 47s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
4m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  7s
hbase-logging in the patch passed.

+1 :green_heart:
unit
157m 47s
hbase-server in the patch passed.

179m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 5919082d3bf8 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 34b5d64ae0

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/2/testReport/

Max. process+thread count
3087 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  1s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s
branch-2.4 passed

+1 :green_heart:
compile
2m 25s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 42s
branch-2.4 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 42s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
2m 25s
the patch passed

+1 :green_heart:
javac
2m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 43s
Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

41m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
dupname asflicense spotless javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 8de7911bd6e3 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 34b5d64ae0

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  0s
branch-2.4 passed

+1 :green_heart:
compile
0m 44s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
4m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  8s
hbase-logging in the patch passed.

+1 :green_heart:
unit
158m  0s
hbase-server in the patch passed.

179m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux f66f8a29748a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 34b5d64ae0

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/testReport/

Max. process+thread count
2637 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 31s
branch-2.4 passed

+1 :green_heart:
compile
0m 44s
branch-2.4 passed

+1 :green_heart:
shadedjars
3m 32s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
branch-2.4 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
shadedjars
3m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m  9s
hbase-logging in the patch passed.

+1 :green_heart:
unit
173m  4s
hbase-server in the patch passed.

193m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5187

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 02f27f35835c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 34b5d64ae0

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/testReport/

Max. process+thread count
2292 (vs. ulimit of 30000)

modules
C: hbase-logging hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5187/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[Feature Request] Option to highlight certain fish in spearfishing

Not a necessary change at all, but I think it would be a nice QoL to be able to select which fish you're interested in spearfishing and those be highlighted in a different color or something.

Not included by design.


Change engines to >=16 to enable node 18 tests/usage

Change-type: patch

@balena-ci I self-certify!

@balena-ci rebase


ARROW-11129: [Rust][DataFusion] Use tokio for writing parquet

Inspired by PR https://github.com/apache/arrow/pull/9086 from @jorgecarleitao
Seems better to use  task::spawn_blocking to set an upper limit on the nr. of threads (512 by default) using tokio and get better error handling as well.

Two CI jobs are hanging indefinitely, I canceled them.

Two CI jobs are hanging indefinitely, I canceled them.

Note that this is hanging in the CI, which I think is unrelated with the CI itself.

Note that this is hanging in the CI, which I think is unrelated with the CI itself.

Locally seems to work now thanks @andygrove . Seems CI jobs are in queue for quite some time

Locally seems to work now thanks @andygrove . Seems CI jobs are in queue for quite some time

I swear Github showed that all the CI checks were green when I merged this PR.... but now they are now showing as still running...

I swear Github showed that all the CI checks were green when I merged this PR.... but now they are now showing as still running...

And now they do show as green. WTF guthub?

And now they do show as green. WTF guthub?


RDF2MARC from Share-VDE Data - a question?

I am looking at some Share-VDE results of a search in stage, and we are currently able to copy that data into a template of our choice. This makes sense in theory. The issue we run into of course is that little if any of the SVDE triples are mapped to Sinopia RTs (made even more problematic by the fact that each institution has does so much with customized RTs - even in the same resource formats). My question is: What is the overhead required to develop a INTERNAL converter that converts SVDE data w/o having to map to Sinopia? I am guessing it is significant, but I want to put the question out there to the community.
PS: I will test the results of a SVDE URI via the EXT converter just to see what that looks like.

Given the current SVDE data that we have at our disposal, the level of effort would be significant (~1 month). Might be worth revisiting after SVDE produces some new data (since it might align more closely with Sinopia templates), but closing for now.


Caddyfiles read from STDIN have empty server types

1. What version of Caddy are you running (caddy -version)?
0.9.1
2. What are you trying to do?
Use a config file from STDIN.
3. What is your entire Caddyfile?
:2016 {
     root /var/www/public
}

4.  What did you expect to see?
Caddy running
6. What did you see instead (give full error messages and/or log)?
2016/09/05 18:25:03 no action found for directive 'root' with server type '' (missing a plugin?)

7. How can someone who is starting from scratch reproduce this behavior as minimally as possible?
echo -e ":2016 {\n root /var/www/public \n}" | caddy -conf stdin -log stdout

I’ve found and fixed the problem; basically files parsed from STDIN do not have a server type associated with them, so HTTP plugins/directives are not correctly parsed.
I’m attaching a Pull Request which fixes this bug.

Thanks! Really appreciate your contribution. :smile:


Create scale-font.py

Script to change UnitsPerEm of a Font
USAGE:
scale-font.py path/to/inputFont.ttf targetUPM path/to/outputFont.ttf
Only works on .ttf (no CFF) for now

@anthrotype:

Another way would be doing like the subset or merge module do, i.e. dynamically assign methods to existing classes defined elsewhere using decorators (but it's ok at this stage if keep it simple).

I'm not a fan of that method (pun intended), and I wonder: wouldn't functools.singledispatch() be a better approach these days?

I also like singledispatch

How about, instead of passing UPM and target_UPM around as fuction arguments, you make a UpemScaler class that holds them as attributes, then make those scale* functions into instance methods of that class, each taking a table or subtable object as a parameter?
Another way would be doing like the subset or merge module do, i.e. dynamically assign methods to existing classes defined elsewhere using decorators (but it's ok at this stage if keep it simple).

Right.  I also think something using visitor pattern and list of fields to rescale...  Def not acceptable all the repetition.

Maybe out of scope for this, but what happens if the font is hinted? At least the cvt and cvar table values (all of them?) would need to be scaled as well. Other hinting instructions may also refer to font unit measurements.

Yeah hinting cannot uséfully be scaled.  Same about cvt.

I made a script that uses fontMath to scale a whole UFO and change its unitsPerEm, I put it here in case other may find it useful:
https://gist.github.com/anthrotype/62d0bfe1d38b8f11a199bd3b66574bcc
Of course that only works if one has a UFO source to work with, so it doesn't completely replace a tool for scaling a binary font's UPEM. But working on the sources does make things a bit easier.

Nice! Compact and clean, will be very useful when sources UFO are available!
I am not forgetting the scale-font project for TTF fonts but need to find and take the time for finishing it.

This should be done similar to merge.py.  I'm putting together design for a unified "processor" that should also be used for this.

I'm not a fan of that method (pun intended), and I wonder: wouldn't functools.singledispatch() be a better approach these days?

Interesting.  I'll check that out.

I'm not a fan of that method (pun intended), and I wonder: wouldn't functools.singledispatch() be a better approach these days?

Interesting. I'll check that out.

I'll use it.  It's essentially the same as what I'm doing, just implemented in the standard library now.  So I'll embrace it.

I'll use it. It's essentially the same as what I'm doing, just implemented in the standard library now. So I'll embrace it.

FWIW in varLib I was doing very similar.  Ie. not adding methods to the classes, but registering them for dispatch somewhere else.  It's very similar to singledispatch.

FWIW in varLib I was doing very similar. Ie. not adding methods to the classes, but registering them for dispatch somewhere else. It's very similar to singledispatch.

Humm.  I don't think I can reuse it though, since we need inheritance in a way that singledispatch doesn't allow.  If you check fontTools.varLib.merger you see what I mean, eg. AligningMerger is inherited by others.
The module I'm proposing is a similar to singledispatch implemented for our fonts; ie. it uses more information than just that.  I'll review singledispatch to inform my design.  I'll create a new request for discussing the design and will link from here.

this all sounds good @behdad, in the meantime I have made some improvements to my base

@behdad I like the idea of centralizing all the code in subset/merge/varLib that deals with traversing a font object hierarchy to do interesting stuff with it.

I don't think I can reuse it though, since we need inheritance in a way that singledispatch doesn't allow.

Python 3.8 has functools.singledispatchmethod to make single-dispatch generic instance methods which should work with inheritance
https://docs.python.org/3/library/functools.html#functools.singledispatchmethod
There's also a backport for pythons < 3.8 on PyPI
A separate project called multipledispatch also allows to do the dispatching on instance methods with inheritance, and has a nicer API than built-in singledispatch; plus, as the name tells, it can displatch on multiple arguments' type, not just one (though maybe we don't need that). Though I don't know if we want to add a third party dep for this. Still worth having a look.
Ok we are digressing. We should discuss this in a separate issue, sorry Jeremie :)

just a quick correction to my previous post: singledispatchmethod does not play well with inheritance https://bugs.python.org/issue36457
So we either use mutilpledispatch or whatever behdad comes up with.

It's ok Cosimo :) it is interesting stuff! I hope my base will be of some help for this upcoming task. It was a time-consuming reverse-engineering task to get the relevant scalable data parsed in the tables and in GPOS lookup in particular.

definitely, thanks for that @JeremieHornus 👍

I've finally sketched a fontTools.misc.visitor and how this scale-font would look like using it, so far just the GPOS part:
https://github.com/fonttools/fonttools/pull/2718/files

@ScalerVisitor.register(otTables.ValueRecord)
def visit(visitor, obj):
    attrs = ['XAdvance', 'YAdvance', 'XPlacement', 'YPlacement']
    for attr in attrs:
        v = getattr(obj, attr, None)
        if v is not None:
            v = visitor.scale(v)
            setattr(obj, attr, v)
    return False

@ScalerVisitor.register(otTables.Anchor)
def visit(visitor, obj):
    attrs = ['XCoordinate', 'YCoordinate']
    for attr in attrs:
        v = getattr(obj, attr)
        v = visitor.scale(v)
        setattr(obj, attr, v)
    return False

That's a lot less code than writing custom code for each lookup type.

Closing in favor of the other PR, which handles variable-fonts as well:
https://github.com/fonttools/fonttools/pull/2718#issuecomment-1215739512


feat!(flame-bloc): updating flame bloc to bloc 8

Description
Updated the bloc version inside flame bloc to the latest bloc version.
This is a breaking change in terms that the user will need to update their dependency as well, but no code change will be required if they already moved their blocs to the new API.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples.

Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change. (Indicate it in the Conventional Commit prefix with a !,
e.g. feat!:, fix!:).
[ ] No, this is not a breaking change.

Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database.
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx

The PR will already be connected to flame_bloc so you don't have to put that in the scope. :)


replace_or_add multiple lines

Hi,
I have a file with the following contents:
# comment line 1
# comment line2
# comment line X
some random text

I want to use the replace_or_add command to make it add several lines IF they DO NOT EXIST and skip it if the lines are already there.
So I tried this:
replace_or_add 'blahblah' do
  path '/path/to/file'
  line 'SOMELINE 1'
  line 'SOMELINE 2'
end

What it did is replaced all lines from the file with SOMELINE 2.
Is it possible to specify multiple lines in one replace_or_add block?
THe final result I want to achieve is for it to look like below regardless of how many times it is execute:
# comment line 1
# comment line2
# comment line X
some random text
SOMELINE 1
SOMELINE 2

Please help. Thanks in advance.

Ok, I was able to do it like this:
%w{STRING1 STRING2}.each do |i|
  replace_or_add 'blahblah' do
    path '/path/to/file'
    pattern "#{i}"
    line "#{i}"
  end
end

But this would work only without any special characters and empty spaces.
It would be nice to have the cookbook assume that if no pattern is specified then the pattern is the line itself and also for it to allow to use multiple line properties in one replace_or_add block.
Thanks

Hey @izghitu if you can make a PR to fix this we'd graciously receive it.
However right now I'm inclined to just put this in case in the README.

I think the append_if_no_line resource might be closer to what you're looking for?
%w(STRING1 STRING2).each do |i|
  append_if_no_line "add #{i}" do
    path '/path/to/file'
    line i
  end
end

This resource escapes the string before matching, so it doesn't matter if you have special regex characters in your string. It's important to name resources within a loop uniquely by incorporating the iterator in the name, or the resources start overwriting each other and notifications stop working.

@ccrebolder thanks, this works better

Thanks @ccrebolder! I'm going to go ahead and close this issue now.
Glad this is sorted :)


Rename source_document_id to sdoc_id

The most api routes use sdoc_id but some (e.g. create adoc) use source_document_id to describe the same concept. This should be made uniform in the api (and backend in general).

in api endpoints, i could not find a mention of source_document_id. In the rest of the backend, we would have to change too much (including database schema) to change to sdoc_id.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.wled

[ ] [E019] Invalid repository URL: https://github.com/DrozmotiX/ioBroker.wled. Expected: git+https://github.com/iobroker-community-adapters/ioBroker.wled.git

Thanks,
your automatic adapter checker.

Thanks, that all bugs have been fixed.


Fix snapshot so prepare only launches devices that are being tested this batch

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
prepare_simulators_for_launch is called before every simulator batch run (Xcode 8 before every individual device, concurrent Xcode 9 before every batch of tests).
However prepare_simulators_for_launch was running preparation (media setup + erase/localize/uninstall) for every device in the device list.
This has two undesirable effects:

Generally snapshot is very inefficient, pointlessly re-processing every single simulator on every run even when it is not going to be used: An (A, B) run will "Prepare A, Prepare B, Test A, Prepare A, Prepare B, Test B" instead of just "Prepare A, Test A, Prepare B, Test B"
In concurrent mode, because simulators are not shut down after they are processed this results in all the devices in the list being left open even when not used sometimes resulting in failures due to system resources running out

Description
This fixes both these issues by only preparing the simulator(s) that are about to be tested.
Fixes #10457 and #10185

Sounds great, thanks for your contribution, have you tested this change locally and ensured it works as expected?

I've tested it with Xcode 9, it works great.
I don't have Xcode 8 installed anymore, however the changes made for Xcode 8 are similar to the changes made for Xcode 9 and are based on patterns already used elsewhere in the file (other parts of the Xcode 8 code were already passing [device_type] in places where the Xcode 9 code passed devices, so I just did the same) so it should work fine there too.


will need ssr eventually, probably worth converting to next.js

@benawad is this open to work or are you working on this?

I'm not working on this right now (and won't for a while), you can give it a try if you want but I think it will be tricky

I will give it a try.

Why? Apps that are mostly hidden behind auth usually don't need SSR

DogeHouse doesn't need it now, but in the future more things will be public

Oh, an "anonymous" mode can indeed be added.

I believe this should be closed now that this is in motion. What do you say, @benawad?


Error: Could not find command 'git'

Hi guys,
This is probably not a Boxen error, but I can't find out why this error is occurring. It seems that boxen can't find my git installation, though git is installed and working..
Any ideas?
Cheers!
stefan.vermaas at macbook in ~
○ git --version
git version 2.4.3

stefan.vermaas at macbook in ~
○ which git
/usr/local/git/bin/git

stefan.vermaas at macbook in /opt/boxen/repo on master
± ./script/boxen
--> Preparing to auto-update...
--> Complete! Nothing new from upstream.
Fact file /opt/boxen/repo/facts.d/example.yaml was parsed but returned an empty data set
Notice: Compiled catalog for macbook in environment production in 2.39 seconds
Error: Could not find command 'git'

I recommend uninstalling your version of git and ensuring you have CLT installed before running Boxen. If that doesn't fix it, please reopen.


Unsupported characters kept on the value after blur

Hi fellows!
First of all, nice work, is always good to have people in a private companies opening usefull codes for a community
I'm looking for a input mask to use on my project, and testing your demo, I found a strange behavior, for example:
On car plate, first 3 characters must be a letter, if I type a number, and get out the focus of the component, the number stayed on field... I'm not sure if the number still on value var, but is weird to see a number instead a letter.

Maybe this problem is on keyDown event: el.addEventListener('keydown', inputHandler), maybe is better keyUp event. But is just a shot, I really dont know the code ;)
Well is it.

Thanks @guilhermewaess , the tab was working, I can reproduce the problem with direct click on another field.
Already pathed: https://github.com/moip/awesome-mask/pull/9


Paginate previous networks

Like the homepage. These can get out of hand if you're using DIGITS a lot.

Closed in 66d8404713b0fa94f84a33a2cf4031fa20e6aa3c.


feat: add Dark theme support for LoginActivity

This is something that should be PRed to upstream if at all. This fork should not be any more different than upstream than necessary for it's purpose. Thanks regardless


feat(logger): add option to remove and get correlation_id

Issue #, if available:

https://github.com/awslabs/aws-lambda-powertools-python/issues/518

Description of changes:

Call remove_keys["correlation_id"] when the correlation_id is set to None.
Add get_correlation_id call

from aws_lambda_powertools import Logger

logger = Logger()
logger.set_correlation_id("Foo")
assert "Foo" == logger.get_correlation_id()
logger.set_correlation_id(None)
assert logger.get_correlation_id() is None

Checklist

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #516 (902f8c3) into develop (43b828e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #516   +/-   ##
========================================
  Coverage    99.90%   99.90%
========================================
  Files          107      107
  Lines         4280     4282    +2
  Branches       212      213    +1
========================================
+ Hits          4276     4278    +2
  Misses           1        1
  Partials         3        3

Impacted Files
Coverage Δ

aws_lambda_powertools/logging/logger.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b828e...902f8c3. Read the comment docs.

@heitorlessa should we go ahead with this feature?

I've just added a comment in the RFC.
TL;DR: Definitely yes for Getter, perhaps even a generic one to grab any key. Not yet for the remove correlation ID method.

@heitorlessa  made the changes. the diff is much more minimal, but still meet the needs of the original RFC

Thanks a lot again @michaelbrewer !


Adding unit tests for components

Run yarn test to run the unit tests.
Unit test step is added to the CI pipeline

Your suggestions are applied.


LNBits SQLite to PostgreSQL migration

New installations with PostgreSQL configuration, existent data with SQLite.
convert script needs a full start of LNBits prior migrating the old sqlite db's.
User can migrate from raspiblitz menu.

Was able to migrate on one machine but not on another with a very old database.
The conversion script stucks with
admin@<IP_ADDRESS>:/home/lnbits/lnbits((0.9.4)) ₿ sudo -u lnbits ./venv/bin/python tools/conv.py
Selected path:  /mnt/hdd/app-data/LNBits
Traceback (most recent call last):
  File "/home/lnbits/lnbits/tools/conv.py", line 208, in <module>
    check_db_versions(file)
  File "/home/lnbits/lnbits/tools/conv.py", line 61, in check_db_versions
    raise Exception(
Exception: sqlite database version (1) of tpos doesn't match postgres database version 3

Maybe not all databases are easy to migrate or outdated in some way that lnbits cant fix it yet.

Have to check if postgresql is just an option or somewhere mandatory. Because once its podtsgresql we might cannot migrate back, right?

TODO: a quick disclaimer in the cli hlep there should be a disclaimer: "migrate back to sqllite might not be possible"

It is possible to migrate back. In the last commit i added a migrateMsg function with commands to execute to revert the migration back to the old backuped sqlite database.
sudo systemctl stop lnbits
sudo mv /mnt/hdd/app-data/LNBits /mnt/hdd/app-data/LNBits_backup
sudo tar -xf /mnt/hdd/app-data/LNBits_sqlitedb_backup.tar
sudo sed -i "/^LNBITS_DATABASE_URL=/d" /home/lnbits/lnbits/.env
sudo sed -i "/^LNBITS_DATA_FOLDER=/d" /home/lnbits/lnbits/.env
sudo bash -c "echo 'LNBITS_DATA_FOLDER=/mnt/hdd/app-data/LNBits' >> /home/lnbits/lnbits/.env"
sudo chown lnbits:lnbits -R /mnt/hdd/app-data/LNBits
sudo systemctl start lnbits

Did a lot more improvements for several circumstances i tested. Should be kind of bullet proof at this point. No risk at all and a beautiful dialog behaviour :)
Test Error behaviour:

Set your usr string as LNBITS_ADMIN_USERS in .env
Increase your balance amount to 21000000
Start migrate with Tag 0.9.4

This got fixed here. Hopefully we can see a new LNBits Tag 0.9.5. soon. We should not migrate prior v0.9.5.

Merged into 3411-lnbits feature branch further testing on issue #3505


Benchmark Java Serialisation / Deserialization Speeds Against ActiveJ Serialisation

To ensure this is actually "Fast" Binery Encoding please benchmark serialisation speeds against https://serializer.activej.io/

We're not competing with native language serialize RS, because we're cross platform and cross wire.
The fastest serialize will be memcpy(sizeof(MyStruct)) in C++ :-)

Colfer serialisation (https://github.com/pascaldekloe/colfer) is the fastest cross platform serialisation which you can use for benchmarking. But it would be worth while to see how you hold up with language specific implementations also.

It was easy to benchmark the same model as Colfer serialization does for testing the serialization performance.
bench.fbe:
package bench
version 1.0

struct Benchmark
{
    int64 key;
    string host;
    int32 port;
    int64 sise;
    uint64 hash;
    double ratio;
    bool route;
}

serialize_bench.cpp:
#include "benchmark/cppbenchmark.h"
#include "../proto/bench_models.h"

class SerializationFixture
{
protected:
    FBE::bench::BenchmarkModel writer;
    std::vector<bench::Benchmark> benchmarks;
    size_t index{0};
    size_t size{4};

    SerializationFixture()
    {
        benchmarks.emplace_back(bench::Benchmark(1234567890, "db003lz12", 389, 452, 0x488b5c2428488918, 0.99, true));
        benchmarks.emplace_back(bench::Benchmark(1234567891, "localhost", 22, 4096, 0x243048899c24c824, 0.20, false));
        benchmarks.emplace_back(bench::Benchmark(1234567892, "kdc.local", 88, 1984, 0x000048891c24485c, 0.06, false));
        benchmarks.emplace_back(bench::Benchmark(1234567893, "vhost8.dmz.example.com", 27017, 59741, 0x5c2408488b9c2489, 0.0, true));
    }
};

BENCHMARK_FIXTURE(SerializationFixture, "Serialize")
{
    // Reset writer stream
    writer.reset();

    // Serialize
    writer.serialize(benchmarks[index++ % size]);
}

BENCHMARK_MAIN()

deserialize_bench.cpp:
#include "benchmark/cppbenchmark.h"
#include "../proto/bench_models.h"

class DeserializationFixture
{
protected:
    FBE::bench::BenchmarkModel writer;
    FBE::bench::BenchmarkModel reader;
    bench::Benchmark deserialized;
    size_t index{0};
    size_t size{4};

    DeserializationFixture()
    {
        std::vector<bench::Benchmark> benchmarks;
        benchmarks.emplace_back(bench::Benchmark(1234567890, "db003lz12", 389, 452, 0x488b5c2428488918, 0.99, true));
        benchmarks.emplace_back(bench::Benchmark(1234567891, "localhost", 22, 4096, 0x243048899c24c824, 0.20, false));
        benchmarks.emplace_back(bench::Benchmark(1234567892, "kdc.local", 88, 1984, 0x000048891c24485c, 0.06, false));
        benchmarks.emplace_back(bench::Benchmark(1234567893, "vhost8.dmz.example.com", 27017, 59741, 0x5c2408488b9c2489, 0.0, true));

        for (const auto& benchmark : benchmarks)
            writer.serialize(benchmark);
        assert(writer.verify() && "Model is broken!");
        reader.attach(writer.buffer());
        assert(reader.verify() && "Model is broken!");
    }
};

BENCHMARK_FIXTURE(DeserializationFixture, "Deserialize")
{
    // Deserialize
    reader.deserialize(deserialized);

    ++index;

    // Reset reader stream
    if (index == size)
        reader.attach(writer.buffer());
}

BENCHMARK_MAIN()

Serialization benchmark results:
Phase: Serialize
Average time: 31 ns/op
Minimal time: 37 ns/op
Maximal time: 39 ns/op
Total time: 2.667 s
Total operations: 86009850
Operations throughput: 32239885 ops/s

Deserialization benchmark results:
Phase: Deserialize
Average time: 18 ns/op
Minimal time: 21 ns/op
Maximal time: 22 ns/op
Total time: 1.871 s
Total operations: 101784438
Operations throughput: 54389865 ops/s


Support private bitfields

Sorry, new to rust, and I might have missed something, but would it be possible to add private bitfields if they don't already exist?
pub mod foo {
    #[bitfield(u8, default = 0x00)]
    pub struct bar {
        #[bit(0, r)]
        pub cool: bool,

        #[bits(1..=4, r)]
        hotness: u4, // I want this to be private

        #[bits(5..=7, r)]
        pub weirdness: u3,
    }

    impl bar {
        pub fn hotness(&self) -> u8 {
            8 * self.hotness().value() // So hotness can be a multiple of 8
        }
    }
}

Sorry for the late response.
I think if I were to start over, that's probably how I would design this nowadays. But given that everything's public right, I am not sure how we could migrate to it as it's quite an API change.


labyrinth terminal

Make that you can turn off the option of dont clicking in panels because you cant do the labyrinth terminal in necrons third phase

This has been fixed in dev, Please get experimental build in my discord. Check pin in #skyblockcatia channel.

Fixed in 1.0.13.