Versionize V2

Breaking Changes

--skip-commit now only skips the commit. Not the tag.
remove deprecated --proj-version-bump-logic.
remove --changelog-all cli option in favor of changelog options in the .versionize file.
remove support for netcoreapp3.1, net5.0, and net6.0. Now only supports net7.0 and net8.0. The long-term plan is to support the latest 3 dotnet versions. net9.0 is coming out soon so that's why we're removing net6.0 support a little early.
TagOnly no longer completely skips making a release commit. It only skips reading from and writing to the version bump files. Use SkipCommit if you don't want a commit to be made.

Other Changes

refactor codebase (logic is a mess)

modularize logic into distinct steps
organize files into folders
abstract the csproj logic behind a BumpFile interface to open the possibility of handling other project types such as Unity and nodejs

add --skip-changelog option
update dependencies
update docs to reflect changes
update roadmap in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

547 of 581 (94.15%)  changed or added relevant lines in 31 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 93.371%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

Versionize/CommandLine/CommandLineUI.cs
5
6
83.33%

Versionize/Lifecycle/ChangeCommitter.cs
33
34
97.06%

Versionize/Lifecycle/ReleaseTagger.cs
23
24
95.83%

Versionize/Versioning/InvalidPrereleaseIdentifierException.cs
1
2
50.0%

Versionize/BumpFiles/Projects.cs
12
14
85.71%

Versionize/Lifecycle/ChangelogUpdater.cs
39
41
95.12%

Versionize/Lifecycle/BumpFileProvider.cs
35
38
92.11%

Versionize/Lifecycle/VersionCalculator.cs
40
43
93.02%

Versionize/Program.cs
6
9
66.67%

Versionize/Config/ConfigProvider.cs
82
86
95.35%

Files with Coverage Reduction
New Missed Lines
%

Versionize/Versioning/InvalidPrereleaseIdentifierException.cs
2
33.33%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.4%

Covered Lines:
1310

Relevant Lines:
1394

💛  - Coveralls

@RemiCELLARD First of all, thanks for taking the time to review!

Hi,
I think you forgot to edit the .NET version in the release.cmd file.

Oh, that file doesn't seem to be used anymore. I assume it was used by the original maintainer and then eventually migrated the logic to the publish workflow.


chore(package): update babel-cli to version 6.22.1

Closes #257
https://greenkeeper.io/

Storybook Hub is building storybooks for every commit in this PR.
Latest Storybook: https://79646907-c8ac-4c97-bc23-add272699eca.sbook.io/
( Visit here for more info )

This comment is automatically added by Storybook Hub


numpy and scipy autocomplete doesn't work .

VSCode Version: Code 1.19.3 (7c4205b5c6e52a53b81c69d2b2dc8a627abaa0ba, 2018-01-25T10:32:23.601Z)
OS Version: Linux x64 4.13.0-32-generic
Extensions:

Extension
Author (truncated)
Version

terminal
for
0.0.10

Python-autopep8
him
1.0.2

Go
luk
0.6.73

python
ms-
0.9.1

(1 theme extensions excluded)

Steps to Reproduce:

Reproduces without extensions: Yes/No

numpy and scipy autocomplete doesn't work.
python version : 3.6.3
numpy version : 1.14.0
jedi version : 0.11.1


Request for the webserver to be hosted as in process host to improve performance

My understanding of the current architecture

The browser runs in a  process (Say Process 1)
The asp.net core web server runs in a process (Say Process 2)
The asp.net core web server listens in a port (Say port 8003)

Request

Run the browser in a  process (Say Process 1)
Run the asp.net core web server in the same process (that is Process 1)
Host the web service as in process host. (Link below)
https://blogs.msdn.microsoft.com/webdev/2017/12/07/testing-asp-net-core-mvc-web-apps-in-memory/

Advantages

In the current approach the server is running as a separate process and is listening on a open port, this could be a security gap. When you host as "in process" there is no open port, and only code running within the process can access the web server.

In the current approach, there is interprocess communication happening over a socket that gets estabilished between the asp.net core server and the browser. Inter process communication is slow as data has to be transferred between processes using IPC. When you run as in-process, there is no inter process communication.

In the current approach, there are multiple processes running for the desktop app, when you host as in-process, there will be only one process.

Further note:

It may take lot of time to get a in process web browser.
It may be that it's not at all possible in a cross platform.

Regards,
Nachiappan
<EMAIL_ADDRESS>

It may take lot of time to get a in process web browser.
What do you mean by "lot of time"? -- Do you mean a lot of time to write the code, or a lot of time during the app start up for the browser to initialize?

Related https://github.com/ElectronNET/Electron.NET/issues/22

In Electron.NET 8.31.1 we incease the startup time and we continue to work hard to get it even better.


Migrate to Travis-ci.com

Travis-CI.org is shutting down at the end of the year. We have been encouraged to migration to travis-ci.com

Hi there!
As you’ll no doubt have noticed, Travis CI has, for some time, been split between travis-ci.com and travis-ci.org. This was initially planned to enable open-source and commercial/private projects to be distinctly separate, but back in May 2018, we announced that open source builders would have the opportunity to build and test their projects under travis-ci.com, meaning your public and private repositories could be managed under one domain with a consistent interface and build environment.
In an effort to ensure that all of our users - whether you build open-source, public or private repositories - receive regular feature updates, security patches and UX/UI enhancements, we are announcing that travis-ci.org will be officially closed down completely on December 31st, 2020, allowing us to focus all our efforts on bringing new features and fixes to travis-ci.com and all of our awesome users like yourself on the travis-ci.com domain.
What this means for you
The main thing to expect is that your projects will be built and tested with the same speed and robustness as you’ve come to expect from Travis CI - but also with great new features such as support for AWS Graviton2 which is only available on travis-ci.com. Open-source projects will be free as they always have, with lighting fast builds provided by partners like Packet.
We encourage you to migrate your existing repositories that are currently on travis-ci.org over to travis-ci.com as soon as possible, enabling you to identify any additional changes required to your code or configuration well in advance of the December 31st deadline. We’ve documented everything you need to know in order to migrate your repositories, and of course, you can reach out on the community forum for any additional help.
If you have any questions or concerns, please feel free to contact our support team who will be happy to talk through any migration queries you may have!
Happy building on travis-ci.com!
The Travis CI Team

I think this just needs @Undo1 to push some buttons on travis or maybe in the ms-deploy repo.

Taking this opportunity to move to GH Actions.

Moved the deploy job to GitHub Actions: https://github.com/Undo1/metasmoke-deploy/commit/9d948e55427b9b1b880e8231c628af45b8777dc8
Dashboard: https://github.com/Undo1/metasmoke-deploy/actions
Deploys from metasmoke will now trigger the GH action, which should be about 9000% more reliable than whatever crazy business Travis had going.


MWPW-142069 - Cache control via URL parameter

Calls to fragments, json (placeholders, charts, etc.) are heavily cached client-side. While this is helpful for page load times, it can cause uncertainty in the authoring workflow over whether or not your latest changes have been published successfully. This feature puts control over usage of the client-side cache into explicit terms via a cache URL parameter.
Under the hood, this feature simply applies caching rules based on the Request interface. In order to force bypassing the local cache and requesting/storing a new version from the server, add cache=off to your URL parameters (for example: https://main--milo--adobecom.hlx.page/?martech=off&cache=off)
Currently, this cache control is applied to requests for the following:

Fragments
Placeholders
Icons
Chart data

NOTE: This feature does NOT preview your document changes for you. As an author, you will still need to preview/publish your document changes in order for them to be force-retrieved (via this feature) from the server.

Resolves: MWPW-142069
Test URLs:

Before: https://stage--milo--adobecom.hlx.page/docs/library/kitchen-sink/icon-block?martech=off
After: https://ebartholomew-cache-control--milo--adobecom.hlx.page/docs/library/kitchen-sink/icon-block?martech=off&cache=off

Stage was out of sync with main, so I force pushed stage - you'll need to rebase onto stage!

@overmyheadandbody Fair point, this has been updated accordingly

@JasonHowellSlavin The tests have been updated and are passing successfully 👍


OpenType 1.9: add "(OpenType 1.8.4) to titles in OT 1.8.4 pages

Addressed in OpenType 1.9. Closing.


Docker not prompting user for auth on pull / making bad decision to fallback to /v1

Summary
"Error: image not found" on docker pull when using private registry and token auth. It seems to be a login / authorization problem, because docker login "fixes" it.
This is a huge problem for me, because my environment forbids me from saving LDAP credentials in an unencrypted file on disk (the notorious #10318). I was planning on using the work-around I described here, which is ln -sf /dev/null ~/.docker/config.json. However, this would prevent me from ever being able to pull an image from my private registry.
Related
This seems similar to #15759, but there's a not of chaff there, regarding S3, and tdterry's comment shows logs that don't match mine.
Also possibly related to docker/distribution#884.
Configuration / Versions
Docker: 1.8.2-fc22
Private registry (local file storage): registry github.com/docker/distribution v2.1.1
Portus (token auth server): Portus-20151027090209-1.1.x86_64
Problem Demonstration
Clear auth:
$ rm ~/.docker/config.json

Try to pull:
$ docker pull docker-reg.example.com/jreinhart/busybox:1.0
Trying to pull docker-reg.example.com/jreinhart/busybox ... not found
Error: image jreinhart/busybox:1.0 not found

Registry Log (abbreviated):
GET /v2/  --> 401 "authorization token required"
GET /v2/  --> 401 "authorization token required"
GET /v1/repositories/jreinhart/busybox/images --> 404

Portus log (abbreviated):
Started GET "/v2/token?scope=repository%3Ajreinhart%2Fbusybox%3Apush%2Cpull&service=docker-reg.example.com" for <IP_ADDRESS> at 2015-12-16 10:17:13 -0500
Processing by Api::V2::TokensController#show as JSON
Parameters: {"scope"=>"repository:jreinhart/busybox:push,pull", "service"=>"docker-reg.example.com"}
Denied access on these grounds: not allowed to  this nil
Completed 401 Unauthorized in 10ms (ActiveRecord: 1.3ms)

Description of Problem(s)

Docker should have aborted when it got the 401 from Portus (the auth server).
Docker should have prompted the user for creds when it realized ~/.docker/config.json didn't have creds for the given auth server.
Docker should not have fallen back to /v1 in this case (because /v2 did not 404).
Docker should not have given an incorrect error message like Error: image jreinhart/busybox:1.0 not found.

Simply running docker login makes docker pull work again, but this of course requires saving my network creds unencrypted, which is unacceptable.
It's kind of mind-boggling that such an obvious scenario behaves so poorly.
cc @stevvooe @dmp42

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@GordonTheTurtle Yes, I know you're a bot. Yes I know there are thousands of open issues against Docker, and this is certainly an effort to mitigate that.  My bug report was extremely thorough, so other than adding the text BUG REPORT INFORMATION, I'm ignoring this.

@JonathonReinhart Calm down. No sense yelling at the bot. We just delete the Gordon messages if they don't make sense.
The fallback situation is non-ideal. We are slowly phasing out v1 support, so the fallbacks are becoming less and less aggressive as this happens.
In this particular case, one cannot tell the difference between a 401 not being authorized and 401 not authorized because v2 is not supported. Yes, arguably /v2/ returning a 401 should be considered a /v2/ endpoint, especially if there is a version header present. This is problematic when running a dual v1/v2 setup, if I remember correctly.
@aaronlehmann Any thoughts here?

If I understand correctly, this isn't about overly aggressive v1 fallback as much as a feature request for docker pull and docker push to prompt for credentials if none were provided previously with docker login. I don't think that would be very hard to implement, assuming there's no controversy about turning docker pull and docker push into possibly interactive commands.

@aaronlehmann docker push is already interactive:
$ docker push docker-reg.example.com/jreinhart/busybox
The push refers to a repository [docker-reg.example.com/jreinhart/busybox] (len: 1)
fc0db02f3072: Image push failed

Please login prior to push:
Username: jreinhart
Password:
Email<EMAIL_ADDRESS>WARNING: login credentials saved in /home/jreinhart/.docker/config.json
Login Succeeded
The push refers to a repository [docker-reg.example.com/jreinhart/busybox] (len: 1)
fc0db02f3072: Image already exists
5c5fb281b01e: Image already exists
8.0: digest: sha256:ddd04870d28de86975649ca115f037c31ad9816506e1317af790bd325e306357 size: 3213

I didn't realize that. In that case, pull should definitely behave similarly.

I've got about 40 servers pulling from a v2 registry, and one refuses to. Basically it starts to pull all the images and at some point it checks /v2/ gets the 401 and then checks /v1/ and gets 404 and then stops downloading all image layers and states that it is not found.
I cannot reproduce on any other system at the moment (thankfully)
Docker version 1.9.1, build a34a1d5

@ekristen: I'd suggest filing a separate issue for this. If you are able to reproduce it, running the Docker daemon with -D (debug) and capturing the daemon log during one of these pulls would be helpful.

@aaronlehmann Is this still an issue?

I think so. But the issue author says:

This is a huge problem for me, because my environment forbids me from saving LDAP credentials in an unencrypted file on disk (the notorious #10318)

and now there are workaround for this (identity tokens, and registry credential stores)

@aaronlehmann I still think that we should have that for symmetry. Leaving open.

@aaronlehmann would https://github.com/docker/docker/pull/26354 help for this?

No, I don't think it's really relevant. As I understand that PR, it's a tweak to the credential store functionality that avoids the need for Docker to keep track of which registries the user has logged into. The existing credential store functionality already makes it possible to avoid storing passwords in plaintext.

@thaJeztah @aaronlehmann is correct, my change only alters the behavior of native stores.


refactor: modified JoinHashMap build order for HashJoinStream

Which issue does this PR close?

Closes #8130.
Rationale for this change

The least harmful way of allowing HashJoinStream to process probe-side batch records in original order -- is to adjust build-side input to produce FIFO hash map as a result of update_hash, using current data structure without any modifications, and this can be achieved by reverse iteration over build-side input.
What changes are included in this PR?

collect_left_input iterates over collected batches in reverse order
update_hash and build_equal_condition_join_indices now accept fifo_hashmap argument, which determines the iteration order for input batches (SymmetricsHashJoin execution has not changed)
default implemenations for update_from_iter & get_matched_indices in JoinHashMapType trait -- to unload join helper functions from HashMap-specific code

Are these changes tested?

assert_batches_sorted_eq replaced with assert_batches_eq for Inner / RightSemi / RightAnti non-partitioned join test cases to validate that join output preserves input(s) order.
Are there any user-facing changes?

No.

Hi @korowa, this is a great extension. I suggest adding explanations in the code base, including docstrings for the mechanism and updating the docstring of the hashjoin. You can use https://textik.com, which is a great tool for drawing diagrams in docstring.

@metesynnada thank you!
Regarding explanations -- I've added extended explanation of how build phase works in HashJoinExec docstring -- hope with this description of "the whole picture", the other modified / added comments will make more sense.
Regarding performance -- benchmark results are
--------------------
Benchmark tpch_mem.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃   master ┃ hash_join_build_order ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 156.09ms │              155.86ms │     no change │
│ QQuery 2     │  36.49ms │               36.30ms │     no change │
│ QQuery 3     │  70.99ms │               71.59ms │     no change │
│ QQuery 4     │  61.01ms │               58.94ms │     no change │
│ QQuery 5     │ 104.64ms │              101.76ms │     no change │
│ QQuery 6     │  16.71ms │               16.67ms │     no change │
│ QQuery 7     │ 274.75ms │              283.66ms │     no change │
│ QQuery 8     │  65.54ms │               65.67ms │     no change │
│ QQuery 9     │ 103.82ms │              104.10ms │     no change │
│ QQuery 10    │ 123.52ms │              123.01ms │     no change │
│ QQuery 11    │  28.87ms │               27.55ms │     no change │
│ QQuery 12    │  50.39ms │               52.08ms │     no change │
│ QQuery 13    │  59.11ms │               58.02ms │     no change │
│ QQuery 14    │  21.04ms │               18.94ms │ +1.11x faster │
│ QQuery 15    │  47.09ms │               46.57ms │     no change │
│ QQuery 16    │  32.32ms │               33.87ms │     no change │
│ QQuery 17    │ 150.53ms │              140.37ms │ +1.07x faster │
│ QQuery 18    │ 324.83ms │              322.20ms │     no change │
│ QQuery 19    │  46.00ms │               45.74ms │     no change │
│ QQuery 20    │  83.35ms │               83.45ms │     no change │
│ QQuery 21    │ 261.97ms │              265.00ms │     no change │
│ QQuery 22    │  28.01ms │               25.16ms │ +1.11x faster │
└──────────────┴──────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (master)                  │ 2147.08ms │
│ Total Time (hash_join_build_order)   │ 2136.50ms │
│ Average Time (master)                │   97.59ms │
│ Average Time (hash_join_build_order) │   97.11ms │
│ Queries Faster                       │         3 │
│ Queries Slower                       │         0 │
│ Queries with No Change               │        19 │
└──────────────────────────────────────┴───────────┘

(faster queries probably are no more than outliers)

I've noticed that with each new row addition, the previous row indices need to be scanned, making the addition complexity linear instead of constant.

Could you, please, recheck or point the LOC where scanning takes place? If I got it right -- the problem should be in JoinHashMap::update_from_iter, but the worst case for insertion there seems to be

obtain currently stored index index in hashmap for hash value
place it at specific position in next vector
update hashmap with a new index
which should not produce linear complexity :thinking: (at least it definitely shouldn't perform worse than before)

However, are the JoinHashMap struct comments relevant after this change?

@metesynnada, yes, the PR is only related to the JoinHashMap input -- all its internals remains as they were before so all docs and comments for both JoinHashMap and moved pieces of code are still relevant. The only comment modification is related to missing offset argument in update_from_iter as its caller responsibility to provide correct row indices in iterator.

Failed tests look like related to chrono-tz 0.8.5 + https://github.com/eggert/tz/commit/1d0ae801a6fa85ba824ca6c017f75eab54657eba :thinking:

Pushed separate PR cause new chrono-tz release will affect test run on any branch.

Thank you @korowa  -- both for this PR and for debugging https://github.com/apache/arrow-datafusion/pull/8677


diacritic check summary

I try to reformulate what was said in the meeting yesterday for the diacritic check.
I'll update this to-do with more details

[ ] #3293
[ ] #3296
[ ] #1861
[ ] #3322
[ ] #3328
[ ] #3490

it is OK to have a summary issue like this to track progress on a set of things. But it's important that the details are discussed in the individual issues for each of these new check proposal. Please post an issue for "WARN top-comb accents have _top and top anchors to allow multiple combining accents"

[ ] WARN Diacritics are used consistently (#3296)

I would propose a FAIL status for this one.

@RosaWagner mentioned on chat "For the problem with GDEF table and confusion between legacy accents and comb accents, I can confirm that fixing Radio Canada is fixing this display issue on the API. It seems therefore more ans more important to implement [this issue]"

FYI, all the Tiro Indic families have a GDEF table warning;
⚠ WARN: Check mark characters are in GDEF mark glyph class. (com.google.fonts/check/gdef_mark_chars)
⚠ WARN The following mark characters could be in the GDEF mark glyph class:
acutecomb (U+0301), brevebelowcomb (U+032E), brevecomb (U+0306), candrabinducomb (U+0310), caroncomb (U+030C), cedillacomb (U+0327), circumflexcomb (U+0302), commaaccentcomb (U+0326), dieresisbelowcomb (U+0324), dieresiscomb (U+0308) and 9 more.
This is the consequences of such issue in GF:

@davelab6 I don't know if the warn should be a fail, or if GF should stop displaying glyphs that are actually not encoded in the font.
cc @vv-monsalve @m4rc1e

Adding this issue to bump up priority on this list of check, this is the example of a font that shouldn't have passed QA: https://github.com/google/fonts/issues/6226


Bug with clearing a ComplexContainer

Hi
I came across a bug in this library:
If I call the method clear() or removeAllItems() on a Class which extends your ComplexContainer,
the assert in the Method ComplexContainer.orphan() fails.
All you need to reproduce this are these 3 lines of code:
Panel p = new Panel();
p.add(new Button());
p.clear();
I use the following versions:
GWT 2.7
Code downloaded as Zip here on github

Thx for reporting. Will have a look


Fix a crash in autocompletion

This commit fixes a crash in autocompletion, when a comma character is entered before any valid sql keyword, e.g.,
database_name> asd,Exception in thread Thread-309:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/local/lib/python2.7/dist-packages/prompt_toolkit/__init__.py", line 466, in run
    CompleteEvent(text_inserted=True)))
  File "/usr/local/lib/python2.7/dist-packages/pgcli/pgcompleter.py", line 92, in get_completions
    document.text_before_cursor)
  File "/usr/local/lib/python2.7/dist-packages/pgcli/packages/sqlcompletion.py", line 46, in suggest_type
    return suggest_based_on_last_token(last_token, text_before_cursor, full_text)
  File "/usr/local/lib/python2.7/dist-packages/pgcli/packages/sqlcompletion.py", line 83, in suggest_based_on_last_token
    return suggest_based_on_last_token(prev_keyword, text_before_cursor, full_text)
  File "/usr/local/lib/python2.7/dist-packages/pgcli/packages/sqlcompletion.py", line 61, in suggest_based_on_last_token
    token_v = token.value
AttributeError: 'NoneType' object has no attribute 'value'

Note for future refence: Whenever find_prev_keyword() is used, a check should be made in case None was returned.

Thank you!
:koala:


Data files as of 2024-08-21

@btylerburton This one is ready for merging whenever you can. Thank you!


chore(deps): update dependency autoprefixer to v6.7.7

This PR contains the following updates:

Package
Type
Update
Change
References

autoprefixer
devDependencies
minor
6.3.6 -> 6.7.7
source

Release Notes

postcss/autoprefixer
v6.7.7
Compare Source

Fix order for non-digit values.

v6.7.6
Compare Source

Fix font-kerning (by Chi Vinh Le).

v6.7.5
Compare Source

Fix text-decoration-skip in iOS (by Chi Vinh Le).
Fix clip-path (by Chi Vinh Le).

v6.7.4
Compare Source

Improve browsers option perfomance.
Update CoffeeScript compiler.

v6.7.3
Compare Source

Fix compatibility with “Intrinsic & Extrinsic Sizing” spec update.

v6.7.2
Compare Source

Do not prefix grid/flexbox in @supports on grid: false/flexbox: false.

v6.7.1
Compare Source

Update Browserslist with last n version fix.

v6.7.0
Compare Source

#### Electron Support
Electron is a framework to build desktop applications with JS and CSS. It is used in Atom text editor and Hyper terminal. Electron is based on Chromium, but have different versions. For instance, Electron 1.4 is based on Chromium 53.
@Kilian made a npm package and Electron-to-Chrome versions mapping. Browserslist 1.6 uses this npm package to covert Electron version to Chrome:
browserslist('Electron >= 1.3') //=> ["chrome 53", "chrome 52"]

Autoprefixer 6.7 uses new Browserslist version, so you could write Electron versions in your browserslist section of package.json.
Also new Browserslist fixes inconsistency of Can I Use data to prevent errors like:
BrowserslistError: Unknown version 0 of and_chr

flex-flow
Autoprefixer converts flexbox syntax to support 2012 and 2009 flexbox specification. Unfortunately, not all properties could be converted to 2009 spec.
Oldest specification doesn’t support flex-flow too, so previous Autoprefixer releases ignore this property.
.foo {
    flex-flow: row
}

But flex-flow is just a shortcut of [flex-direction] [flex-wrap] and flex-direction could be converted to two properties in 2009 specification.
Autoprefixer 1.7 converts row, column, row-reverse and column-reverse values of flex-flow too.
.foo {
    -webkit-box-orient: horizontal;
    -webkit-box-direction: normal;
    -webkit-flex-flow: row;
        -ms-flex-flow: row;
            flex-flow: row;
}

Note, that wrap, wrap-reverse and nowrap values still not supported.
v6.6.1
Compare Source

Add metadata to use Autoprefixer in JSS tests (by Chi Vinh Le).

v6.6.0
Compare Source

This release uses Browserslist 1.5 and is focused on sharing browsers with babel-preset-env and create-react-app.
package.json
We know that many developers hate the current mess of config files in the project root.
With Autoprefixer 6.6 you can specify browsers in package.json to reduce config files:
{
  "private": true,
  "devDependencies": {
    "autoprefixer": "^6.6.0",
    "postcss": "^5.2.6"
  },
  "browserslist": [
    "last 2 versions",
    "ie 9"
  ]
}

Note that we highly recommend specifying browsers in browserslist config or in package.json instead of Autoprefixer option. In this case many other tools will share browsers list, including Stylelint and babel-env-preset.
Environments
In most cases, you should use same browsers list for Autoprefixer in development and production. But right now Autoprefixer share browsers list with many other tools including babel-env-preset.
To improve development performance developers might want to use different target browsers in development.
So both Browserslist config now supports environments:
[development]
last 1 version

[production]
last 2 version
> 1%

  "private": true,
  "devDependencies": {
    "autoprefixer": "^6.6.0",
    "postcss": "^5.2.6"
  },
  "browserslist": {
    "development": [
      "last 1 version"
    ],
    "production": [
      "last 2 version",
      "> 1%"
    ]
  }

Autoprefixer will use env option, BROWSERSLIST_ENV or NODE_ENV to detect current environment.
Custom Browser Statistics
In addition to > 1% and > 1% in US, Browserslist supports > 1% in my stats to select popular versions according your visitors statistics.
To do it you need save JSON data from Google Analytics.
Autoprefixer 6.6 support standard name for this usage data file browserslist-stats.json and will load it automatically, without need to pass stats options.
It is especially useful if you share browsers with other tools without stats option support.
v6.5.4
Compare Source

Fix unitless 0 basis in IE10/IE11 shorthand flex (by Google).

v6.5.3
Compare Source

Add error for popular mistake with browser option instead of browsers.

v6.5.2
Compare Source

Clean prefixes data (by Reinaldo Schiehll).

v6.5.1
Compare Source

Fix selectors with :-- prefix support.

v6.5.0
Compare Source

Autoprefixer 6.5 brings defaults keyword and fixes Grid support.
defaults
Autoprefixer 6.5 includes Browserslist 1.4 with defaults keyword. So now you could extend default browsers list:
postcss([
  autoprefixer({ browsers: ['defaults', 'ie 9'] })
])

Also don’t miss new tool to check what browsers will be picked by Browserslist: browserl.ist.
CSS Grid Layout
With Autoprefixer small subset of coming CSS Grid Layout will works in IE by adding a -ms- prefix and change the syntax (as we do for Flexbox). In 6.5 we fixed some cases with -ms-grid-row-align.
.container {
    display: grid;
    grid-template-columns: auto 1fr;
}
.element {
    align-self: stretch;
    grid-column-start: 1;
    grid-column-end: span 3;
}

.container {
    display: -ms-grid;
    display: grid;
    -ms-grid-columns: auto 1fr;
    grid-template-columns: auto 1fr;
}
.element {
    -ms-grid-row-align: stretch;
    align-self: stretch;
    -ms-grid-column: 1;
    grid-column-start: 1;
    -ms-grid-column-span: 3;
    grid-column-end: span 3;
}

Flexbox
align-self has same syntax in final and 2009 Flexbox specification.
In 6.5 we fixed when Autopefixer removed -webkit-align-self even if final spec is still in requirements.
v6.4.1
Compare Source

Fix node cloning after some PostCSS plugins.

v6.4.0
Compare Source

Autoprefixer 6.4 brings :any-link and text-decoration-skip support.
New Support
New Autoprefixer will compile:
:any-link {
    text-decoration-skip: ink;
}

to:
:-webkit-any-link {
  -webkit-text-decoration-skip: ink;
          text-decoration-skip: ink;
}
:-moz-any-link {
  text-decoration-skip: ink;
}
:any-link {
  -webkit-text-decoration-skip: ink.;
          text-decoration-skip: ink;
}

Transition
Autoprefixer 6.4 support reverse parameters in transition:
.foo {
    transition: 200ms color;
}

Also we fix transition prefixing in Opera 12.
Other

Fix -webkit- prefix for backface-visibility.
Fix rad unit support in gradients (by @gucong3000).
Removed Safari TP Grid prefixes support.

v6.3.7
Compare Source

Fix rare Cannot read property 'constructor' of null issue.

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

diff master.css branch.css had no differences -> ✅

:tada: This PR is included in version 2.67.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Debian package management support

For example, will rules_distroless contain parts of the upstream distroless project related to downloading/extracting .deb files in order to install custom dependencies from upstream debian mirrors?
In our case, we can build off of pre-existing distroless contains (like cc, static or java_base) to add our dependencies and applications on top, so many of the rules in this repo are unnecessary. However the ability to install additional dependencies is absolutely a requirement.

We are working on this actively. See: #16

This is now supported. https://github.com/GoogleContainerTools/rules_distroless/pull/16


fix(asset): fix empty string error on Linq filter for assets

Pull Request
🤨 Rationale
The query location fails on empty strings when comparing direct values due to preprocessing on the backend. In order to fix this, I will change the expression to use LINQ that's also supported by the API
👩💻 Implementation

Manual testing
Updated Unit tests

🧪 Testing

✅ Checklist

[x] This PR has a title that follows the commit message format.

:tada: This PR is included in version 3.34.1 :tada:
The release is available on:

v3.34.1
GitHub release

Your semantic-release bot :package::rocket:


Unable to open :(

@romainguy Yes. Is the dmg signed and notarized ? -> https://github.com/JetBrains/compose-multiplatform/blob/ef04feee54f1d757114f0811c59052447c584767/tutorials/Signing_and_notarization_on_macOS/README.md

No it's not and I won't do this unfortunately.

@romainguy Then I think there's no point sharing a dmg file 😬 . Can you share the jar file? That shouldn't have this issue.

It can be opened, you first need to right click > Open then confirm again by clicking Open in the dialog. But like mentioned in the README file you need to first make sure you have set ANDROID_HOME and KOTLIN_HOME. I just double-checked on a different computer where I never compiled/ran the app and it works just fine with the latest macOS. Alternatively you can run KOTLIN_HOME=/opt/homebrew/Cellar/kotlin/1.9.0/libexec open /Applications/Kotlin\ Explorer.app from a terminal for instance.


Multiple security issues

There are multiple security issues from both a packaging and operational security perspective.
Issues upon invoking hb-service install

Adding a system user that has access to a shell.
Modifying /etc/sudoers.
Adding files/folders throughout the system:

systemd service file
/etc/hb-service directory

The generated systemd service has excessive permissions granted to it, e.g. CapabilityBoundingSet/AmbientCapabilities options. It also needs a fair amount of security hardening to prevent privilege escalation.

Issues at run-time

Providing a sudo configuration option and not respecting it.
Invoking npm via sudo. Just don't use sudo.
Invoking npm with deprecated flag --unsafe-perm.
Invoking npm install with --global flag. Apart from the glaringly obvious security concerns, this pollutes the global namespace that users aren't aware of.

General issues

Assuming every Linux distribution follows Debian-specific guidelines. The directory /etc/default does not exactly exist on other Linux distributions, nor does run-parts.
Upstream systemd has stated that the EnvironmentFile directive should not have been implemented in the first place, and to prefer using the Environment=Key=Value directive in systemd service files.
Updating Node.js. For a project like this, that's massively out of scope. Leave that up to the distribution or let the sysadmin manage it via alternative implementations such as nvm, pm2, etc.

Solutions/Mitigations

Don't use sudo. Ever.
System accounts should use per-user global npm installs.
Don't modify /etc/sudoers.
Set the system user's home directory to /var/lib/homebridge.
Don't pollute the global namespace, keep all generated files/directories within the system user's home directory.

adding systemd service file

hb-service is a managed setup, it is expected to create a system service including a systemd service file to operate as expected.
The alternative is having users create their own systemd services etc. which caused no end of issues for new users.

Invoking npm via sudo. Just don't use sudo.
System accounts should use per-user global npm installs.
Invoking npm install with --global flag.

I agree this is less than ideal. The use of sudo on Linux is required to maintain backwards compatibility with existing installs from before the hb-service installer existed. Unfortunately there are too many plugins and guides that tell users to install plugins manually with sudo npm install moving away from this will be challenging.
This is a trade off as I don't want to get bombarded with questions and issues regarding things not working.

Providing a sudo configuration option and not respecting it.

The sudo option is hidden when running with hb-service as it's a managed setup. If you choose not to use hb-service as a service manager, then the sudo config option is respected.

Invoking npm with deprecated flag --unsafe-perm

This is required for any plugin that has native modules, as of npm 7 it's deprecated, and is the default behaviour so removing it will not change anything here.

Updating Node.js. For a project like this, that's massively out of scope. Leave that up to the distribution or let the sysadmin manage it via alternative implementations such as nvm, pm2, etc.

Before adding this feature about half of issues users raised came down to updating Node.js in an incorrect way, often resulting in multiple copies of Node installed etc. The installer attempts to install using the same method the user originally used to install (NodeSource for most systems, binary for arm32v6 as NodeSource does not support this architecture).
Since adding this feature, such issues have reduced to near zero.

Assuming every Linux distribution follows Debian-specific guidelines. The directory /etc/default does not exactly exist on other Linux distributions, nor does run-parts

Agree, we would add distribution checks before proceeding. The install guides only exist for Debian-based, RedHat-based and Arch Linux systems which do include these things as part of a base install.

This issue needs to stay open until all these concerns are resolved.

I think this would be better addressed as pull requests for each individual issue raised that is feasible to resolve.


Update print format of a VibrationalStructureResult

Summary
I updated the format of the output when printing a VibrationalStructureResult.
The output now contains the excited state energies.
The occupied modals are now printed together with the corresponding excited state energy.
Details and comments
Example output:
=== GROUND STATE ===

* Vibrational ground state energy (cm^-1): 2534.621084885806
The number of occupied modals is
- Mode 0: 0.9999999999999992
- Mode 1: 0.9999999999999992
- Mode 2: 0.9999999999999992
- Mode 3: 0.9999999999999992

=== EXCITED STATES ===

*   1: Vibrational excited state energy (cm^-1): 3177.549427345762
The number of occupied modals is
- Mode 0: 0.9999999999999992
- Mode 1: 0.9999999999999992
- Mode 2: 0.9999999999999992
- Mode 3: 0.9999999999999992

*   2: Vibtational excited state energy (cm^-1): 3184.993112554999
The number of occupied modals is
- Mode 0: 1.0000000000000027
- Mode 1: 1.0000000000000027
- Mode 2: 1.0000000000000027
- Mode 3: 1.0000000000000027

...

Fixes #401
Fixes #402

@mrossinek I listed the occupied modals in the most straightforward way, and like this the output gets quite long. I tried some alternatives (e.g. using two columns), but they look more cluttered than the example output above.
Do you have an idea how the output format could be improved?

Except maybe two rows instead of columns?

I was also thinking about a table or something similar. One drawback may is that the length of the rows will be dynamic. Having more modes will lead to longer rows and could result in line breaks.
What I could to is to add rows like in the suggestion above and then go to the next line after x modes.
For example like this
=== GROUND STATE ===

* Vibrational ground state energy (cm^-1): ...
The number of occupied modals is
 Mode | 0     | 1     | 2     | 3     |
------|-------|-------|-------|-------|
 Occ. | 0.999 | 0.999 | 0.999 | 0.999 |

 Mode | 4     | 5     |
------|-------|-------|
 Occ. | 0.999 | 0.999 |

What I could to is to add rows like in the suggestion above and then go to the next line after x modes.

Yes, that could be a good idea. What do you think, @woodsp-ibm @pbark?
Or does this overcomplicate things? :thinking:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 18 (16.67%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 85.527%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_nature/results/vibrational_structure_result.py
3
18
16.67%

Files with Coverage Reduction
New Missed Lines
%

qiskit_nature/drivers/psi4d/psi4driver.py
1
85.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
9526

Relevant Lines:
11138

💛  - Coveralls


Change on_guild_join for loop to executemany

this also changes import typing to from typing import x,y,z instead

<3


Add support to complete 3DS 2 transactions

A new endpoint transactions/{token}/complete has been added to be able to complete a
3DS 2 transaction (https://docs.spreedly.com/reference/api/v1/transactions/). The SDK cannot reach that endpoint right now so a new method like the one below should be added to src/Transaction.php
    /**
     * Can be used to Completes a 3DS 2 transaction in the device fingerprint stage
     * See docs for more information.
     *
     * <code>
     *		// Completes a 3DS 2 transaction in the device fingerprint stage.
     *		Spreedly::transaction($transactionToken)->complete();
     * </code>
     *
     *
     * @return mixed
     *
     * @throws Exceptions\MissingTransactionTokenException
     */
    public function complete()
    {
        if (!$this->transactionToken) {
            throw new Exceptions\MissingTransactionTokenException();
        }

        return $this->client->post('v1/transactions/'.$this->transactionToken.'/complete.json');
    }

Thanks :)

Thanks, is it possible to tag the release, please? 😄

Sorry about that, for some reason the tag wasn't pushed with the commit. Fixed now


Retrieving WaveAnalyticAssetCollection from Org Browser Throws Error: Missing metadata type definition in registry for id 'waveanalyticassetcollection'

Summary
In VS Code, using the Salesforce extensions, specifically the Org Browser, I am trying to retrieve the "WaveAnalyticAssetCollection", which seems to be recently introduced (a month ago, in August 2024). I am trying to retrieve this against a normal developer sandbox org, created from a production environment.
However, it fails with error Missing metadata type definition in registry for id 'waveanalyticassetcollection'.
I don't expect to provide a repository, when it is the available Org Browser, from the VS Code extension, that provides this functionality.
Steps To Reproduce

Open VS Code
Once all extensions have loaded, click the Salesforce cloud icon to open the Org Browser
Scroll to the bottom and click to retrieve the "WaveAnalyticAssetCollection"

Expected result
Expected that the collection (specifically from screenshot that the "My_Dashboards" is retrieved
Actual result
Error thrown:  Missing metadata type definition in registry for id 'waveanalyticassetcollection'.
Additional information

System Information
I have ensured that latest CLI version and VS Code version is used

Version: 1.93.1 (user setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

Which shell or terminal are you using? (bash, zsh, powershell 7, cmd.exe, etc)

Not sure. I am on a Windows 11 machine, and just running the Terminal

Paste the full output of the sf version --verbose --json command below
{
  "architecture": "win32-x64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v20.17.0",
  "osVersion": "Windows_NT 10.0.22621",
  "rootPath": "C:\\Users\\ntorstensson\\AppData\\Local\\sf\\client\\2.58.7-ed27925",
  "shell": "powershell",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.2.2 (core)",
    "@oclif/plugin-commands 4.0.13 (core)",
    "@oclif/plugin-help 6.2.10 (core)",
    "@oclif/plugin-not-found 3.2.18 (core)",
    "@oclif/plugin-plugins 5.4.6 (core)",
    "@oclif/plugin-search 1.2.7 (core)",
    "@oclif/plugin-update 4.5.5 (core)",
    "@oclif/plugin-version 2.2.11 (core)",
    "@oclif/plugin-warn-if-update-available 3.1.13 (core)",
    "@oclif/plugin-which 3.2.12 (core)",
    "@salesforce/cli 2.58.7 (core)",
    "apex 3.4.8 (core)",
    "api 1.2.1 (core)",
    "auth 3.6.54 (core)",
    "data 3.6.5 (core)",
    "deploy-retrieve 3.12.3 (core)",
    "info 3.4.3 (core)",
    "limits 3.3.29 (core)",
    "marketplace 1.2.25 (core)",
    "org 4.5.7 (core)",
    "packaging 2.8.2 (core)",
    "schema 3.3.26 (core)",
    "settings 2.3.16 (core)",
    "sobject 1.4.33 (core)",
    "source 3.5.18 (core)",
    "telemetry 3.6.10 (core)",
    "templates 56.3.17 (core)",
    "trust 3.7.27 (core)",
    "user 3.5.29 (core)"
  ]
}

Thanks for reporting @nickytorstensson - I'm transferring this over to the VS code issue repo, the SDR library already supports this type - so I'm hoping it's an easy dependency bump for that team, or VSC update for you


added missing method call

Codecov Report

Merging #38 (643a8a1) into master (dc278c2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage     70.59%   70.62%   +0.02%
- Complexity      338      339       +1
============================================
  Files            50       50
  Lines          1078     1079       +1
  Branches        179      179
============================================
+ Hits            761      762       +1
+ Misses          221      218       -3
- Partials         96       99       +3

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/kaufland/CoachBaseBinderProcessor.kt
94.11% <100.00%> (+0.36%)
6.00 <0.00> (ø)

.../java/com/kaufland/processing/model/ModelWorker.kt
50.00% <0.00%> (ø)
7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc278c2...643a8a1. Read the comment docs.


Docs: Ionic Generate Error Message

kind of related to another issue: https://github.com/driftyco/ionic-cli/issues/696
when you run ionic g somethingsomething,
the error message was confusing that it catches every exception and blamed the ionic version not match.
the code is at this line: https://github.com/driftyco/ionic-cli/blob/v2-beta/lib/ionic/generate.js#L68
I think return the exception message and the stack would be helpful for debugging.
if you do want to hide the exception from general users, perhaps printing the help message ?

Thanks for opening the issue. It seems that issue has been resolved. I am going to close this issue but please feel free to reopen another issue if this occurs again.


Research Chat Library for Chat SDK

https://github.com/GetStream/stream-chat-android

I added comments to Project Chat Brief based on information found during a research.
TL;DR
It's extended SDK for many platform with numerous amount of chat features. Definitely, we could leverage them into Chat SDK but on the later stages of development, when we're close to beta or rc.


fix(react): switch to supported react router imports

Our fixture breaks with the newest version of React Router (v4.4.0) due to this statement:
https://github.com/untool/untool/blob/1621634bdac34f377af23d11c67c0fbb11d04f31/tests/fixtures/untest/index.js#L3
The relevant change was apparently introduced around React Router v4.4.0-beta2. Additionally, warnings are emitted for our other deep imports from React Router, e.g.:
https://github.com/untool/untool/blob/1621634bdac34f377af23d11c67c0fbb11d04f31/packages/react/lib/runtime.js#L5
This PR addresses these issues

Travis status is red because the canary checks against hops are failing - almost certainly because of the very same changes to React Router we are dealing with in this PR.


The image building process in arm testing needs to be fixed

https://github.com/hwameistor/hwameistor/actions/runs/11523153280/job/32080574953
#3 [internal] load metadata for docker.io/library/rockylinux:8
#3 sha256:00fc02241fa9e8de244828e6d07676d546fa03a6f128386134262f76aac3a8b3
#3 ERROR: unexpected status code [manifests 8]: 403 Forbidden
------
 > [internal] load metadata for docker.io/library/rockylinux:8:
------
error: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: unexpected status code [manifests 8]: 403 Forbidden
make[1]: *** [Makefile:61: build_ldm_image_arm64] Error 1
make[1]: Leaving directory '/home/github/actions-runner/_work/hwameistor/hwameistor'
make: *** [Makefile:488: e2e-test] Error 2

Upgraded docker version from 20.10 to 23.0.6


Fix flag marker anchor

Fixes https://github.com/guytepper/1km.co.il/issues/59

@guytepper Could you please review?

Hey, sorry for the delay.
Thank you :-) This will heal a lot of headaches experienced by our visitors and support staff since launch.
Can you share how did you get to this number?

Hey, sorry for the delay.
Thank you :-) This will heal a lot of headaches experienced by our visitors and support staff since launch.
Can you share how did you get to this number?

Thanks!
Theoretically it's the pixel of the base of the flagpole, but I did some trial and error


ci_script broke ceph playbook

After [1] merged I've been unable to use the ceph playbook in a standalone context as documented in the cifmw_cephadm
role readme [2]. Instead I get:
  Permission denied: '/root/ci-framework-data/artifacts'

I can't even override it easily by passing something like:
  -e cifmw_basedir=/home/ceph-admin

I tried adding a pre_task to ensure cifmw_cephadm_basedir (and cifmw_cephadm_basedir/artifacts) exists but this lead my down a rabbit hole of having to create other directories for it until it mysteriously failed.
TASK [cifmw_cephadm : Run cephadm bootstrap output_dir={{ cifmw_cephadm_basedir }}/artifacts, script={{ cifmw_cephadm_bin }} \
{% if not cifmw_cephadm_default_container %}--image {{ cifmw_cephadm_container_ns + '/' + cifmw_cephadm_container_image + ':' + cifmw_cephadm_container_tag|string }} \{% endif %}
bootstrap \
--skip-firewalld \
--skip-prepare-host \
--ssh-private-key /home/{{ cifmw_cephadm_ssh_user }}/.ssh/id_rsa \
--ssh-public-key /home/{{ cifmw_cephadm_ssh_user }}/.ssh/id_rsa.pub \
--ssh-user {{ cifmw_cephadm_ssh_user }} \
--allow-fqdn-hostname \
--output-keyring {{ cifmw_cephadm_admin_keyring }} \
--output-config {{ cifmw_cephadm_conf }} \
--fsid {{ cifmw_cephadm_fsid }} \
{% if cifmw_cephadm_registry_url|length > 0 %}--registry-url {{ cifmw_cephadm_registry_url }} \{% endif %}
{% if cifmw_cephadm_registry_username|length > 0 %}--registry-username {{ cifmw_cephadm_registry_username }} \{% endif %}
{% if cifmw_cephadm_registry_password|length > 0 %}--registry-password {{ cifmw_cephadm_registry_password }} \{% endif %}
{% if cifmw_cephadm_spec_on_bootstrap %}--apply-spec {{ cifmw_cephadm_spec }} \{% endif %}
{% if cifmw_cephadm_assimilate_conf_stat.stat.exists %}--config {{ cifmw_cephadm_assimilate_conf }} \{% endif %}
{% if cifmw_cephadm_single_host_defaults %}--single-host-defaults \{% endif %}
--skip-monitoring-stack --skip-dashboard \
{% if cifmw_cephadm_extra_args|length > 0 %}{{ cifmw_cephadm_extra_args }} \{% endif %}
--mon-ip {{ cifmw_cephadm_first_mon_ip }}
] ***
task path: /home/fultonj/ci-framework/ci_framework/roles/cifmw_cephadm/tasks/bootstrap.yml:48
The full traceback is:
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 147, in run
    res = self._execute()
  File "/usr/lib/python3.6/site-packages/ansible/executor/task_executor.py", line 665, in _execute
    result = self._handler.run(task_vars=variables)
  File "/home/fultonj/ci-framework/ci_framework/plugins/action/ci_script.py", line 148, in run
    t_name = re.sub(r'([^\x00-\x7F]|\s)+', '_', self._task._name).lower()
  File "/usr/lib64/python3.6/re.py", line 191, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object
fatal: [<IP_ADDRESS>]: FAILED! => {
    "msg": "Unexpected failure during module execution.",
    "stdout": ""
}

[1] https://github.com/openstack-k8s-operators/ci-framework/commit/0df6fa4cef78a8147405e40d3ebaa9672040846b
[2] https://github.com/openstack-k8s-operators/ci-framework/blob/main/ci_framework/roles/cifmw_cephadm/README.md#examples

I read that ci_script runs a given script remotely
All roles in ci-framework which use it [2] are in plays which run either against localhost or the cifmw_target_host [3].
That paradigm is different in how the ceph playbook works where it's designed to be run from the localhost but to run the ceph bootstrap command on a remote host. I'm not sure the ceph playbook is a good candidate for CI script action. We have had ceph bootstrapping fine for years without ci_script and using shell in TripleO CI. If we really need something like this, then let's collaborate more closely and get a working version. For now I think we should revert until that point.
My bad for initially approving the PR initially without testing. I assumed it would be transparent.
[1] https://github.com/openstack-k8s-operators/ci-framework/blob/main/ci_framework/plugins/action/ci_script.py
[2]
[fultonj@hamfast roles{fix}]$ grep -R ci_script | awk -F / {'print $1'} | uniq
artifacts
cifmw_cephadm
copy_container
edpm_deploy
edpm_kustomize
edpm_prepare
libvirt_manager
openshift_provisioner_node
os_must_gather
set_openstack_containers
[fultonj@hamfast roles{fix}]$
[3]
[fultonj@hamfast playbooks{fix}]$ grep hosts *
01-bootstrap.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
02-infra.yml:  hosts: "{{ ('virthosts' in groups) | ternary('virthosts', cifmw_target_host | default('localhost') ) }}"
02-infra.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
03-build-packages.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
04-build-containers.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
05-build-operators.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
06-deploy-edpm.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
06-deploy-edpm.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
07-admin-setup.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
08-run-tests.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
99-logs.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
ceph.yml:  hosts: localhost
ceph.yml:  hosts: edpm
ceph.yml:  hosts: edpm
ceph.yml:  hosts: localhost
ceph.yml:  hosts: edpm[0]
ceph.yml:  hosts: localhost
hooks.yml:  hosts: "{{ cifmw_target_host | default('localhost') }}"
[fultonj@hamfast playbooks{fix}]$

Thanks for merging the revert.


Incorrect line breaks.

RFC 2045 defines CRLF as line break sequence - https://tools.ietf.org/html/rfc2045#section-2.1 .
So when it says in "Base64 Content-Transfer-Encoding" section that

The encoded output stream must be represented in lines of no more  than 76 characters each.
it implies CRLF as line break to use.

Or maybe line break sequence can be added as additional param to encode?
(decode can be left as-is should ignore all line breaks and characters outside base 64 alphabet anyway).
I'm creating this issue mostly because when Base64 line break is inconsistent with rest of the email (for example created with Email::MIME that uses CRLF by default) it causes weird edge cases for DKIM canonicalization algorithms described in http://www.ietf.org/rfc/rfc6376.txt.

RFC 6376 mandates that you "network normalize" the mail before applying canonicalization:

3.4.  Canonicalization
Canonicalization simply prepares the email for presentation to the signing or verification algorithm.  It MUST NOT change the transmitted data in any way. Canonicalization of header fields and body are described below.
NOTE: This section assumes that the message is already in "network normal" format (text is ASCII encoded, lines are separated with CRLF characters, etc.).  See also Section 5.3 for information about normalizing the message.

I am interpreting it like this:

There's no reason to do anything special about line breaks during decoding.
When decoding, first canonicalize à la section 5.3, then verify, then decode. You can optimize the combination of canonicalization and verification, though I'm not sure whether such an optimization would be worth the additional code complexity.

I see no reason for a parameter in either direction.
Disclaimer: I haven't read the pertinent RFCs in their entirely, so I may be missing relevant aspects.

You interpreted the RFC correctly. You can "network normalize" (RFC 6376 section 5.3) both received and outgoing message to be sure canonicalization is applied correctly in both directions. However this is quite expensive operation both in terms of CPU and memory - the fastest method in Perl 6 is split + join that takes 0.03s per 100KB Base64 encoded content (benchmarked on i7 4770K) to convert LF -> CRLF. May seem low, but for example in my Perl 5 $dayjob we're sending about 100_000_000 emails daily. That means if we want to switch to Perl 6 then just fixing LF would cost us... 34 days of CPU time per day :)
My point is that network normalization can be entirely avoided if message is composed already in RFC 2045 complaint way - with CRLF endings - and DKIM signed before passing through any SMTP transport that may break those endings.

(oO 100 mio mails per day - what kind of legitimate business would do this? ... well nvm, just wondering...)
If you're sending mails, I'm not sure where exactly you'd be doing duplicate work, or what kind of change you're proposing.

Im sorry about very late reply.
I work at GetResponse.com email marketing company - legitimate business that allows you to contact your subscribers easily, personalize emails, create automation workflows, etc. And the sending volume makes it a crazy job in terms of scaling - for example if after some changes single email is being sent 0.001s slower that means wasting 27 CPU hours per day.
As for the gist of this issue: LF endings instead of CRLF endings force DKIM signer (which I'm working on right now: https://github.com/bbkr/EmailDKIM ) to apply expensive network normalization. This can be entirely skipped if Base64 MIME part is constructed in RFC 2045 compliant way and it is used by tool that also uses CRLF endings (like https://github.com/retupmoca/p6-Email-MIME ). My proposal is to simply add optional line ending param MIME::Base64.encode-str("foo", eol => "\x0D\x0A") just like Perl 5 version of MIME::Base64 has. This way it won't be necessary to "fix" message for DKIM right after composing it.

Proposal implemented in version 1.2.3


UserWarning from geopandas' to_file() with GeoSeries.notna()

I'm seeing a UserWarning with geopandas-1.0.0 while using the to_file() method.

/tmp/py310/lib/python3.10/site-packages/pyogrio/geopandas.py:523: UserWarning: GeoSeries.notna() previously returned False for both missing (None) and empty geometries. Now, it only returns False for missing values. Since the calling GeoSeries contains empty geometries, the result has changed compared to previous versions of GeoPandas.
Given a GeoSeries 's', you can use '~s.is_empty & s.notna()' to get back the old behaviour.
To further ignore this warning, you can do:
import warnings; warnings.filterwarnings('ignore', 'GeoSeries.notna', UserWarning)
has_z_arr = geometry[geometry.notna() & (~geometry.is_empty)].has_z

And checking the code here:
https://github.com/geopandas/pyogrio/blob/af292e579572a6a33a22a6403873b8e7b0a9d7f6/pyogrio/geopandas.py#L523
A simple fix would be to apply the suggestion from the warning.
has_z_arr = geometry[~geometry.is_empty & geometry.notna()].has_z

Thanks!
The snippet won't fix it as it just inverts the order of conditions but notna() will emit the error anyway. We shall suppress the warning here.

Thanks for the tips, makes sense to follow the second suggestion. I can prepare a test and PR for this one.


Allow window rules to specify a workspace tile direction

Description
Request
Allow window rules to open matching windows in a specific workspace in the top right while still being tiled.
Maybe something like:
windowrulev2 = workspace 1 silent tr, class:^(bevy.+)$

The logic for the placement would be similar to layoutmsg preselect tr but limited to the workspace.
Considered alternatives
I could use hyprctl dispatch layoutmsg preselect tr as described here: https://wiki.hyprland.org/Configuring/Dwindle-Layout/#layout-messages , but this requires me to have control over what is launching the window which isn't always the case.
I could make a bash script to detect when the matching window is created, but I think my only option is to call movewindow dispatcher but this doesn't have an option to move it within the workspace, so depending where my windows are it could end up in the wrong workspace, requiring even more scripting to accomplish this.
Thanks
Loving Hyprland so far! Looking for alternatives to KDE because many of their window rules are broken on Wayland.
Opened this because it sounded like a feature others could could find useful. If you disagree, don't worry about it, I can figure something out for my use case.

Other possible implementations:
windowrulev2 = preselect tr, class:^(bevy.+)$

Or
windowrulev2 = move tr, class:^(bevy.+)$

Which would allow it to be also be used without specifying a workspace. As long as there's a way to make sure it stays in a workspace those would work for me too.

I don't think I understand?

I wanted to have a window rule so that when a matching window is opened it would be tiled but prefer being placed in the top right corner of my second monitor. I haven't found a way to do this, perhaps I'm missing something?
Will close for now, probably not worth the effort if it isn't obvious to others what my suggestion would do from the examples.


Gradle v6.7

Rationale
Good to keep up to date.
Changes

Update gradle version

I would recommend we target release20.11-SNAPSHOT. Or backport once merged. In theory, Gradle 6.7 is required for JDK 15 support. (Though in practice, the previous Gradle version seems to work fine.)

I would recommend we target release20.11-SNAPSHOT. Or backport once merged. In theory, Gradle 6.7 is required for JDK 15 support. (Though in practice, the previous Gradle version seems to work fine.)

OK.  Still trying to figure out how to get over that problem with TeamCity's pickMssql.

Yep, I get it. I have faith in you :)


Release 0.8.0

These should probably not be here:
  selinuxd-image-mapping.json: |
    [
        {
            "regex":"(.*)(CoreOS).*([\\d+])\\.8[\\d+]\\.(.*)",
<<<<<<< HEAD
            "imageFromVar":"RELATED_IMAGE_SELINUXD_EL8"
        },
        {
            "regex":"(.*)(CoreOS).*([\\d+])\\.9[\\d+]\\.(.*)",
            "imageFromVar":"RELATED_IMAGE_SELINUXD_EL9"
=======
            "image":"quay.io/security-profiles-operator/selinuxd-el8:latest"
        },
        {
            "regex":"(.*)(CoreOS).*([\\d+])\\.9[\\d+]\\.(.*)",
            "image":"quay.io/security-profiles-operator/selinuxd-el9:latest"
>>>>>>> v0.8.0
        }
    ]

In general I would suggest to also cherry-pick https://github.com/kubernetes-sigs/security-profiles-operator/commit/4766d36667343e02b419075d75482c7e54564419 to the branch you're merging from. We have that patch applied in this fork so we should not lose it.

/lgtm

@xiaojiey @sheriff-rh given the commit above, could we get QE and doc approved?

/label doc-approved

/label docs-approved

/hold
$ oc get pod/security-profiles-operator-b59778747-672m6   -n security-profiles-operator -o=jsonpath={.spec.containers[0].resources} | jq -r
{
"limits": {
"cpu": "500m",
"memory": "128Mi"
},
"requests": {
"cpu": "250m",
"memory": "50Mi"
}

$  oc get sp profile1 -o=jsonpath={.metadata.annotations.syscalls} -n my-namespace
[{"names":["arch_prctl","brk","capget","capset","chdir","clone","close","dup3","epoll_create1","epoll_ctl","epoll_pwait","execve","exit_group","faccessat2","fchdir","fchmodat","fchownat","fcntl","fstat","fstatfs","futex","getdents64","getpid","getppid","gettid","getuid","keyctl","mkdirat","mknodat","mmap","mount","mprotect","munmap","nanosleep","newfstatat","openat","openat2","pipe2","pivot_root","prctl","pread64","read","readlinkat","rt_sigaction","rt_sigprocmask","rt_sigreturn","sched_getaffinity","sched_yield","seccomp","set_robust_list","set_tid_address","setgid","setgroups","sethostname","setsid","setuid","sigaltstack","statfs","symlinkat","tgkill","umask","umount2","unlinkat","unshare","utimensat","write"],"action":"SCMP_ACT_ALLOW"}]

/unhold


support django-csp

remove inline js

Sorry, I'm not sure what you're asking. Please provide enough details if there's something you need.

@FlipperPA this script will not run when using a secure CSP
https://github.com/FlipperPA/django-tempus-dominus/blob/master/tempus_dominus/templates/tempus_dominus/widget.html#L18
Inline JS should be moved into a static file, and templated variables in JS should use the https://docs.djangoproject.com/en/2.2/ref/templates/builtins/#json-script template tag and loaded with document.getElementById


chore: update npm to current version

What type of PR is this?

What this PR does / why we need it:
Update NPM version to current version
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

feel free to reopen without using a fork if needed


fix(emacs) README

Signed-off-by: Jerome Simeon<EMAIL_ADDRESS>

Coverage remained the same at 99.584% when pulling ec7f9b416a33f26434e746aa01b9aa7b1ac7ea1a on jeromesimeon:js-feature-emacs-mode into a37658ae6c63ae0dbecd0af90dc7ca1f2018154a on accordproject:master.


oraclejdk: deprecate oraclejdk 10

Motivation for this change
Oracle JDK 10 is no longer supported in favor of JDK 11. Oracle JDK 11 is not free of charge, and free users are guided to use OpenJDK 11.
Should we just remove the oraclejdk10 package rather than warning existing users?
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

I would say we should remove unsupported versions. There is still oraclejdk8, which is an LTS version.

Let's merge this and backport to the release branches for now. We can continue the removal discussion in #47375.


createCustomBlock is not working in JavaScript project, but works in TypeScript project which is shown in demo

Based on Documentation:
https://github.com/zalify/easy-email/blob/master/packages/easy-email-core/readme.md
I tried adding a new custom block in the demo (https://github.com/zalify/easy-email)
But, the same approach is not working in JavaScript project. The demo uses TypeScript project

Please provide more detailed information. There will not be a situation where only typescript is supported but not JavaScript.

hey sorry, that was my mistake where I forgot to import the Custom Block Component declaration into the Editor component. That's why its not loaded and couldn't get it.


clinicadl 'generate' crashes if called without argument

Expected behavior: it would be good to have the same behavior as other pipelines (i.e an error is raised with information on which argument is missing)

Actually this issue will be addressed while closing #136 .
I close this issue to only let the first one.


refactor options

PTAL @zhangjinpeng1987 @andelf

Great work. Much clear now.
Please fix the conflict.

PTAL @BusyJay

LGTM


allow numbers in the package name

I am toying with the idea of making karm8s
See https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/6#issuecomment-1557022947

I'm actually not personally going to pursue this, but I posted what I coverted from proto in case someone is interested. Unless I made a mistake, a huge model is fairly slow to use even if there aren't many fields serialized. https://gist.github.com/codefromthecrypt/e6b13bd2de275dc20be5b8847328efd3

good luck with your final months of school! see ya!


Errors with "manual" compilation

I can now compile Rust to WASM using wasm-bindgen, with rustc called by cargo. This even works when I call rustc manually from a terminal. However, I've been failing to compile wasm-bindgen to WASM using carnix (https://nixos.org/nixpkgs/manual/#compiling-rust-crates-using-nix-instead-of-cargo) instead of cargo.
The following command doesn't produce the same results when called in a nix builder and in a terminal, and I don't understand why:
rm -Rf target
mkdir -p target/deps
rustc --crate-name wasm_bindgen src/lib.rs --target wasm32-unknown-unknown --crate-type lib \
  -C debuginfo=2 -C codegen-units=1 -C metadata=146444cfc827e146 \
  -C extra-filename=-146444cfc827e146 --cfg 'feature="std"' --cfg 'feature="spans"'  \
  --cfg 'feature="default"' --out-dir target/deps --emit=dep-info,link -L dependency=target/deps \
  --extern wasm_bindgen_macro=/nix/store/jhq7z1f7v7982p3b1wkx3360js4z8kkv-rust_wasm-bindgen-macro-0.2.28/lib/libwasm_bindgen_macro-422c4f93025079cd.so \
  --cap-lints allow

The output of running this command with RUST_LOG=debug shows only marginal differences (involving only times in microseconds, after removing timestamps).

However, when run in nix-build, I get a different libwasm_bindgen-146444cfc827e146.rlib (the WAT is different). I can still compile and link my "Hello world" crate, but then running wasm-bindgen on the result yields "thread 'main' panicked at 'assertion failed: idx >= self.imports', /path/to/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-wasm-interpreter-0.2.28/src/lib.rs:290:9".

I know I'm the only one to blame here, for not using standard tools, but the pipeline the NixOS community has been developing around Carnix is starting to be quite usable, and makes it easy and fast to deploy Rust code to a server (using tools like NixOps).
I guess this is more a question than a bug report, but what steps can I take to debug this? I've tried using env -i, comparing the debugging outputs, but I'm quite stuck.

The bug is that two invocations of rustc with the same files yield different results, one of which is not usable.
Could there be for instance files (shared libraries? data?) that wasm_bindgen_macro is trying to access and fails silently in one of the contexts for some mysterious reason? Maybe an environment variable?

Also, I'm sort of stuck because since RUST_LOG=debug produces the same output in both instances, I don't know what to use to debug.

There's various environment variables that are read, but afaik no shared library state is used. Can you minimize the difference between the two environments to see what change causes the issue?

process didn't exit successfully: rustc -vV (exit code: 127)
--- stderr
/home/user1/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc: symbol lookup error: /home/user1/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/../lib/../lib/librustc_save_analysis-96d845528e8efb0e.so: undefined symbol: ZN4core3fmt3num53$LT$impl$u20$core..fmt..LowerHex$u20$for$u20$u32$GT$3fmt17h51d6c265e3c71e67E
The command used was :

cargo build --target wasm32-unknown-unknown

any idea whats that, this is new error today, getting it for the same newbie examples that compiled few days back.

process didn't exit successfully: rustc -vV (exit code: 127)
--- stderr
/home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc: symbol lookup error: /home/user/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/../lib/../lib/librustc_save_analysis-96d845528e8efb0e.so: undefined symbol: ZN4core3fmt3num53$LT$impl$u20$core..fmt..LowerHex$u20$for$u20$u32$GT$3fmt17h51d6c265e3c71e67E
The command used was :

cargo build --target wasm32-unknown-unknown

any idea whats that, this is new error today, getting it for the same newbie examples that compiled few days back.

The above error i mentioned , its gone now, probably since Rustlang got a new update which means new features must be getting in the nightly for the next release. But the weird errors are gone for now after i updated cargo nightly.
but there may be new problem now, the command "wasm-bindgen sample.wasm –no-modules –out-dir ." is not working, give errror "Invalid arguments."
Good i didnt start new issue here, since i dont have much idea what i am doing, will take time to learn all these cryptic steps, but am deeply committed to ruin JavaScript, and will reach there by any means possible.
:-)

I'm gonna close this since I think it's a bit stale, but feel free to resubmit if it resurfaces!


What's the typographer option?

mentioned in the docs, and how do I activate it?
Thanks!
Jun

You cant i realized by your ticket that i did not enable this feature. Fill fix this as soon as possible.

This is now enabled by default in version 2.0.
If you want to disable it do it like this.

<Markdown markdownit={MarkdownIt({
      typographer: false,
    })} >{markdownText}</Markdown>


markdown.nanorc: don't mark .t(e)xt files as Markdown

.txt and .text are generic plain text extensions that are not necessarily formatted using Markdown. This prevents extraneous highlighting from showing up when this is in fact the case.

I concur, I never really noticed or worried about this before, but it may annoy some people, so we shall change it!


docs: Update comment on valid PR title

As the deletion of the comment about wrong PR title format won't work as we want, as is the message is gone but the page needs to be reloaded 🤔 , let's update the comment instead with a message that the title is now valid
To test: change the title of the PR(remove/add fix/feat etc) and see what comments will be shown

Nice! Just a thought - since it doesn't matter that much what features or bug fixes we publish until the first major release to NPM, should we enable this action only when the package version reaches 1.0.0?

Do you mean when we only have main left and no alpha? I don't mind. I just wanted this feature to be useful. If it is not until 1.0.0 then there is no point to add it before

Nice! Just a thought - since it doesn't matter that much what features or bug fixes we publish until the first major release to NPM, should we enable this action only when the package version reaches 1.0.0?

Do you mean when we only have main left and no alpha? I don't mind. I just wanted this feature to be useful. If it is not until 1.0.0 then there is no point to add it before

I believe this would apply to the main branch if we decide to skip the next/alpha branch development pattern after the first major release. Wdyt?


deps: add minimum version constraint for sqlglot to 19.9.0

This shouldn't be necessary, as sqlglot is only used as a transitive dependency through ibis-framework, but in setting the constraints, we can have greater assurance that sqlglot is upgraded alongside bigframes in existing environments.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #315 🦕

prerelease failures appear to be due to new pandas release pandas==2.2.1. We need to fix our tests for pandas 2.2.x still (internal issue b/322845272)


added contributors file

Related Issue
Fixes #2
Changes Proposed
Added contributors file
Additional Information
Use live server to see the result as used fetch api
Files Changed
Contributors/contributors.html - created
Contributors/contributorStyle.css - created
Contributors/contributors.json - created
Checklist
Check all the boxes [X] that applies

[X] I have asked/communicated about the issue before opening a PR
[X] I have checked that there are no existing PR open for the same issue
[X] I have tested the code locally before submission
[X] My submission doesn't break any existing component or feature
[X] I have updated the documentation accordingly {if needed}
[X] I have added my name and username to Contributors.md { provided my name and username was not added before}

Screenshots

Note to the Maintainers/Reviewers
Use live server to see the result as used fetch api

@atharva0300 please review this PR


add requred checkbox to dob

add requred checkbox to dob like in
https://github.com/unaio/una/issues/1130

It was fixed already

https://github.com/unaio/una/issues/1479


there is no install.sh file in unitree_sdk2

there is no install.sh file in unitree_sdk2 repo, while sudo ./install.sh in readme file.

你解决了吗

there is no install.sh file in unitree_sdk2 repo, while sudo ./install.sh in readme file.

The previous version of Unitree_Sdk2 was installed using install.sh. This method is no longer used in the new version. See https://github.com/unitreerobotics/unitree_sdk2
We have fixed this probled in the latest commit.


Visual Studio 2019 is version 16, not 15

@benmcmorran : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


OL with bing maps and 2 cluster layers adds 100MB to app runtime

I'd like to use OL in my cordova app and noticed that it adds about 100MB (on Android).
const mapLayer = new ol.layer.Tile({
      preload: Infinity,
      source: new ol.source.BingMaps({
        culture: "de-de",
        key: 'XXXXXXXXXXXXXXXXX',
        imagerySet: "Road"
      })
    })

    this.map = new ol.Map({
      view: new ol.View({
        center: ol.proj.fromLonLat([props.center.longitude, props.center.latitude]),
        zoom: props.zoom ? props.zoom : 16
      }),
      loadTilesWhileInteracting: true,
      controls: [],
      logo: false,
      layers: [
        mapLayer,
        retailerLayer,
        garageLayer
      ]
    })

I am using 2 cluster layers, where at the moment, only one has 16 icon/text features in it.
The viewport is 320x200 pixels.

Some browsers unpack images when storing them. In such cases, you may want to compile OpenLayers with a smaller tile cache max size. The default is ol.DEFAULT_TILE_CACHE_HIGH_WATER_MARK = 2048;
See #3816 for a related discussion, and #4702 for a suggestion to make the tile cache size configurable in a simpler way.

See also #3778

Fixed with #4805


multimethod.DispatchError

Checklist

[X] I've read the contribution guidelines.
[X] I've confirmed the issue is certainly related to this repository. If not, please consider to make a new issue in https://github.com/tier4/caret/issues

Description
hi, i record data form one machine. and analyze data on another machine。
when i run ros2 caret check_ctf -d xx, i met the follow error.
do you have any idea?

i record data on ubuntu20.04 ， and analyze data on ubuntu22.04 (python3.10)，i run ros2 caret create_architecture_file /path/to/ctf-based_recorded_data -o /path/to/destination/architecture.yaml , the error again


Add support for to_openqasm with param and create prerelease draft for all whl

Seems that we do not yet support from_openqasm()?


Remove ascii-superset dependency

Hi, thanks for using the ascii library! This was the first time I've ever pushed a release that prompted a Stackage issue :smile: I was interested to see how it was being used, so I took a look at redis-glob. I see the only thing you needed ascii-superset for was conversion to Word8. This seems like a simple and common enough task that it should just get incorporated into the much smaller ascii-char package. I've published that as ascii-char-<IP_ADDRESS>, so can now reduce your dependency set a bit if you raise the ascii-char lower bound to 1.0.1.

@chris-martin, I appreciate your foresight and diligence!
Thank you very much for making the change to ascii-char and sending me this PR.


Security and Privacy

The goal for this PR is to implement as much security checks we can.

Since this is a rabbit hole we need to flush these every few commits
so we don't make it impossible to review them.

typo in one of the commit msgs: validatation

Directory: fix broken directory-signature parsing

Why was it broken?

Directory: fix broken directory-signature parsing

Why was it broken?

Added to the commit msg


Address duplicate override.json

Docs is pointing to: https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/main/override-json-file/override.json
Tests are using: https://github.com/terraform-ibm-modules/terraform-ibm-mas/blob/main/tests/resources/override.json

In order to avoid drift and only maintaining in single location, we can do the following:

Delete tests/resources/override.json
Create symlink:

cd tests/resources
ln -s ../../override-json-file/override.json override.json

Update the pr_test.go:realTerraformDir := "./resources"
tempTerraformDir, _ := files.CopyTerraformFolderToTemp(realTerraformDir, options.Prefix)
files.CopyFile("../override-json-file/override.json", tempTerraformDir + "/override.json")

PR: https://github.com/terraform-ibm-modules/terraform-ibm-mas/pull/115


Alternative download source

Great to see this tracker-free app has been revived!
Would you consider offering the Android APK outside the Play Store – e.g. by getting it added to F-Droid, or tagging releases and attach the APK there? For those who cannot use Play, or prefer not to (to avoid being tracked there), that would be great. Thanks in advance!

Good idea! I have started adding release binaries here.
https://github.com/C-D-Lewis/dashboard/releases/tag/v4.15

Cool! Glad you like the idea. I took the freedom to add it to my repo (should show up here with the next sync in about 5-6 hours) to make it easier to be discovered and kept up-to-date – my updater will grab new versions within 24h of your attaching the APK to a new tag, and people using my repo with the F-Droid app will then be notified the same way as you know it from the Play Store app.
Now that the app is available outside of Play Store I think about trying it myself. Just wondering what it might need GMS for (my devices all run LineageOS without GApps). Is that essential? I see it's for location services (implementation 'com.google.android.gms:play-services-location:17.0.0'). What feature is that connected to? Does it act based on location somehow? Would Dashboard still work if GApps are not present on the device?

That's cool! Always good to make older apps more freely available.
The location permission is requested related to making Hotspot toggle work on newer Android versions (see recent PR from a fellow contributor). It shouldn't stop other features from working, so please give it a try and see how far you can get when denying it.

Thanks! Just added that (abstract, linked here for full details) to the description. Will give it a try soon now that the last doubts have been addressed :smile:
Real tin-foils use a firewall. As no functionality is affected, they can try to block the app from accessing the internet. Luckily my tin foil isn't that thick (I don't say behind every tree is a spy – I just say behind every tree could be one :rofl:) Will block location, though. Just to see if that causes any trouble. I haven't used hotspot more than once in about 5 years, so that's not essential to me.

OK, two nice pics for you – and two not so nice:

This is how it currently looks in the F-Droid client. As you can see, I've just installed your app. Denied the location permission, no crash :smile: But then, I tried to install the Pebble app. Note that I don't have the Pebble app running on my device (never had), but use Gadgetbridge:

No way to install the PBW as I cannot get hold of it. Tapping the button only offers web browsers (probably there's the store link behind it). It lacks a link to the PBW file, so Gadgetbridge's installer would pop up. Could you at least call the store page with the developer parameter (?dev_settings=true worked on the Pebble store, not sure if Rebble picked that up – oh, they did, good!), so the direct download link becomes visible there.

Success! Now I'll play with it a bit the next days… Big thanks again!

Another PS: Any idea why XPrivacy reports Dashboard tried to use Tracking?

And what seems a bug: whatever sound I chose for "find phone", as soon as I press "OK" Dashbord shows it as "Current" but doesn't use it – tapping "choose sound" again shows it was reset to "None". If I try "Default", it only gives a toast "no file chosen, or was unavailable" – and then gives only a little "tock" not really suitable to find the phone unless it's right in front of you. In case it matters: BQ Aquaris X5 Plus running LineageOS 14.1 (Android 7.1.1), no GApps (but microG).

@C-D-Lewis I've split off the two problems into separate issues, so you can address them separately. Gets too confusing here otherwise :wink:

Hey, I'm also a Gadgetbridge user who used to use Dashboard (one of my favorite pebble apps, the find phone functionality has saved my phone a few times) but recently (perhaps when I upgraded to android 10?) it stopped working. On opening dashboard it just shows the dashboard icon in the middle of a black screen on the watch and nothing which stays there forever (I've tried this with the android app open and have reinstalled both the android and pebble apps). I assumed this was just a GB issue with an app which hasn't been updated for ages, but now setting that this is back in development and that another GB user has it working I thought I'd ask: have you ever experienced something like this before, or do you know if there is some way to get logs to see what issue is occurring?
Thank you!

@p4t44 it starts up fine for me, and seems to work completely (except for the two points mentioned above). Maybe try to install the watchapp fresh? Use the trick I've mentioned (adding &dev_settings=true at the end of the URL generated from the "INSTALL/UPDATE" button), then tap the "PBW" button on the bottom of the web page to download, and finally the download notification to install via GB's installer.
If that works for you, I'd be interested to know whether you also have the sound-issue with "find my phone"…

@IzzySoft Yep, I'd done that before but just to be sure I did this now:

Deleted Dashboard from both watch and cache.
Deleted Dashboard app
Restarted Gadgetbridge
Installed Dashboard from your repo in Aurora Droid
Download and install watchapp from the Rebble store with dev settings on
Run app on the watch and phone at the same time and get the eternal loading screen once again.

Unless there's something in here that I'm missing or some setting in GB that could fix it I think I'll try with the Pebble app (just for testing, I'll go back to GB afterwards) and, if the problem persists, open a new issue here.
Are you on Android 10? Given that it used to work for me through Gadgetbridge, that seems like the most likley issue cause for me.

Nope, the device I use with my Pebble still runs Nougat (the Oreo update has been promised for 2 years now but never arrived). May I suggest you open a new issue and include device details (Pebble + Android + GB), @p4t44? That seems to be a separate problem, and we shouldn't use this issue here as "catch-all" (to set a good example, I've already split off my two problems left into separate issues as well). If the watchapp hangs at that phase, I doubt that has anything to do with the Android part, though – and it might be hard to get logs from the watch (I never tried).


layer name change

In https://github.com/meta-flutter/meta-flutter/commit/07e0773a94a4804ad8efc05c6c7c1bf20268b8ea#diff-22294624f20f807485d85b0f15eac2e1dac979796d77182b94b4896eb103c243R16(for kirkstone, but master is affected as well) the BBCOLLECTION name was changed to flutter-layer. This broke all of our BBFILES_DYNAMICsettings in multiple layers (plus likely, I haven't checked, someLAYERDEPENDS_`).
As we don't have a mono repo, would it be an option to add
BBFILE_COLLECTIONS += "meta-flutter"
BBFILE_PATTERN_meta-flutter = "${BBFILE_PATTERN_flutter-layer}"
LAYERSERIES_COMPAT_meta-flutter = "${LAYERSERIES_COMPAT_flutter-layer}"

for a grace period so we can update our layer settings?

Done.  How much time would you like?
b06036b9ecbf45b381d3ab697773da7a195b9d47
2b3889e99f266299f7734da744527329e8f5f48c

Noted


Proposal for run argument in bot.json

During the development of a bot, it would be useful for me (and I assume for others) to build the same .exe for different bots; and then to be able to test those using the game engine.
The engine can make this possible if I can give it an argument to pass on to the exe that identifies the bot on my side.  The bot.json file  seems to be a good place for me to specify this.
Maybe a new entry called RunArgument can be added -- like so:
{
    "Author":"John Doe",
<EMAIL_ADDRESS>    "NickName" :"John",
    "BotType": "CSharp",
    "ProjectLocation" : "",
    "RunFile" : "Reference\\bin\\Debug\\Reference.exe"
    "RunArgument": "variationZ"
}

Then, your bot will receive three arguments for every round in the game:

Your player key registered in the game
The directory for the current game files
The value of RunArgument  (if it is not an empty string)

Hi codespear,
We made the changes for this feature and will include it with the next release.


do not override .hostname() or .domain() from builder with parsed URI

painstakingly addresses #257

I think the docs will need to be updated to reflect this change as well

I think the docs will need to be updated to reflect this change as well

can you help me understand how your vision? for example:
    let connection = Connection::builder()
        .container_id(container_id)
        .domain(relay_domain) // extra -relay
        .hostname(relay_domain) // extra -relay
        .tls_connector(tls_connector)
        .alt_tls_establishment(true)
        //.open_with_stream(ws_stream)
        .open(connection_string.as_str())
        .await
        .unwrap();

.open(connection_string is its own host
in order to do an override, i would've thought .hostname overrides the host for the container
i'm down for a .host() non-breaking (or we can just close this), i just know this is something rhea suppots
https://github.com/search?q=repo%3Aamqp%2Frhea host&type=code

rhea showing it configurable: https://github.com/amqp/rhea/blob/8fa5eb545e52732ee95e4a88597e19b7ec62bf05/lib/frames.js#L142

Closing in favor of #276


Add FFI methods for fetching exchange rates over Tor

We fetch exchange rates on the Rust side of the FFI instead of exposing a direct URL GET method, in order to enable fetching from multiple sources simultaneously to make better use of Arti's async nature.

Force-pushed to pull in the latest Rust crate changes (which include ZIP 320 bugfixes), and do some other updates.


Updates polyline position/scale when GPS location is updated

When GPS location (coordinates or altitude) changes, apply the same scaling logic to Polylines as we already do to Annotation nodes
This allows polylines to scale on par with annotation nodes when the location or altitude changes rapidly, such as in an automobile or elevator.
Breaking Changes
Polyline is now a subclass of LocationNode (as LocationAnnotationNode node already is).  This should probably not break anything, but we should be on the lookout.
Meta

Tied to Version Release(s):

Checklist

[x] Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
[ ] Documentation has been added to all open, and public scoped methods and properties.
[x] Changelog has been updated
[ ] Tests have have been added to all new features. (not a requirement, but helpful)
[ ] Image/GIFs have been added for all UI related changed.

Screenshots

Also - there are merge conflicts that need to be resolved.  Let me know if you need help with it.

Don't worry about the broken CI - I'll be fixing that.


Add is_curie() and is_uri() methods as helper functions

Compression and expansion are not the only use cases for curies, we sometimes just want to know if a string is a curie or not. I keep writing wrappers with curies.parse... methods and it would be nice if this was somehow natively supported.

Related https://github.com/cthoyt/curies/issues/77

@matentzn can you add some details on places where you would like to use this functionality?

In OAK, the relationships are randomly curies when the URI prefix is known (is in the map) and URIs otherwise. For certain applications, I just want to skip all cases where the relationships don't have a valid entry in the prefix map.
But there are a lot of applications for example in data validation, where I want to spit a warning when something is a URI but should be a curie.


[Question] is it support 20.1 ?

Thanks, Good job ! is it support 20.1 ?

Hello @XuJinNet
Yes, it does. It supports 20.10 and 20.04.
I'm already previewing 21.04, I believe it will be ready when it launches.


lib: add copy option to set manifest type

Closes #161

Can you add a link showing what valid values of this string are; and perhaps a test?


problem with google.golang.org/api/compute/v1

Apologies if this is not the correct method to reports something like this, but at godoc.org/google.golang.org/api/compute/v1 I see:
The documentation displayed here is incomplete. Use the godoc command to read the complete documentation.
As of now, the page is not very useful.
Thanks

This must be because that package documentation has grown larger than the max size currently allowed by gddo.
See #175 and #467 for related issues. /cc @shantuo

Hopefully it is fixed soon, but judging by the lack of attention from the referenced issues... I have my doubts.


Fix dropping_references warning

Please do review this carefully.  I'm not confident this (the fix and the test) is correct.  Note there is unsafe in impl Drop for Vec which is the backend data structure for LinearMap.
A couple CI failures will still occur, see #387.

omg there's also a tsan test failing


Cannot connect to the IP address

I am running Windows 7 and I can't seem to connect to that machine from other devices. Is it some bug in the program or do I need to manually change some network visibility options?

If both devices are on the same local network and can ping each other, I'm not sure what the issue could be here. To my knowledge, this isn't happening on any of the other major platforms. Windows 7 is no longer supported by Microsoft so I won't be looking into this. However I will leave this open and would be happy to look at any PRs that solve this.

i had to manually set the specific port open for all connections in windows firewall. that was the issue


How to switch focus to another window?

What are you trying to achieve?
I am trying to login to my app but via social login i.e. facebook or google
steps:

open login url(where various login options present i.e. inbuilt login of app, login via facebook/google)
click on 'login via facebook'
a new window open where you have to enter facebook login id and password
question is : how to switch focus to facebook login window now??

What do you get instead?
is there something like 'switchToNextTab' for switch window as well

Provide console output if related. Use --verbose mode for more details.

# paste output here

Provide test source code if related

// paste test

Details

CodeceptJS version: 1.4.6
NodeJS Version: 5.6.0
Operating System: macOS
Protractor || WebDriverIO || Nightmare version (if related) : protractor
Configuration file:

# paste suite config here

@govindn have you tried https://codecept.io/helpers/WebDriver#switchtonexttab

@govindn In case the solution proposed by @PeterNgTr is not sufficient I would suggest having a look over wdio switchWindow and implement it through a helper
https://webdriver.io/docs/api/browser/switchWindow.html