[SPARK-15593][SQL]Add DataFrameWriter.foreach to allow the user consuming data in ContinuousQuery

What changes were proposed in this pull request?

Add DataFrameWriter.foreach to allow the user consuming data in ContinuousQuery

ForeachWriter is the interface for the user to consume partitions of data

Add a type parameter T to DataFrameWriter

Usage
val ds = spark.read....stream().as[String]
ds.....write
         .queryName(...)
        .option("checkpointLocation", ...)
        .foreach(new ForeachWriter[Int] {
          override def open(version: Long): Unit = {
             // prepare some resources for a partition
          }

          override def process(value: Int): Unit = {
              // process data
          }

          override def close(): Unit = {
             // release resources for a partition
          }
        })

How was this patch tested?
New unit tests.

/cc @rxin @marmbrus @tdas

Test build #59438 has started for PR 13342 at commit cda6ca3.

Test build #59438 has finished for PR 13342 at commit cda6ca3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait ForeachWriter[T] extends Serializable
class ForeachSink[T : Encoder](writer: ForeachWriter[T]) extends Sink with Serializable

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59438/
Test FAILed.

Merged build finished. Test FAILed.

@zsxwing What about python API? How do we do call ForeachWriter in python API?

Maybe we should do scala/java for now and think about Python later, since it is more complicated to do udfs in python.

Its fine that we dont implement it in 2.0, it would be nice to have a abstract idea how it can be done. Ideally, the python way and the scala/java way should look similar.
Possible solution 1: Python will also have a class ForeachWriter, and a Java wrapper ForeachWriter will call the Python ForeachWriter.
Possible solution 2: Similar to udfs, some of the registration by name, where Java writer can be registered and referred to from Python.

Updated ForeachWriter as per discussion with @tdas. I will add more tests for open and close once we all agree with the ForeachWriter APIs.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59510/
Test FAILed.

Test build #59511 has started for PR 13342 at commit 427f900.

Test build #59511 has finished for PR 13342 at commit 427f900.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59511/
Test PASSed.

Merged build finished. Test PASSed.

Test build #59703 has started for PR 13342 at commit ada4422.

Test build #59703 has finished for PR 13342 at commit ada4422.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59703/
Test FAILed.

Test build #59713 has started for PR 13342 at commit 80c06bd.

Test build #59713 has finished for PR 13342 at commit 80c06bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59713/
Test PASSed.

Test build #59754 has started for PR 13342 at commit 40b2508.

Test build #59754 has finished for PR 13342 at commit 40b2508.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ForeachSinkSuite extends StreamTest with SharedSQLContext

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59754/
Test FAILed.

Test build #59757 has started for PR 13342 at commit d2b19b7.

I'm okay with this interface, though I think we will probably need to add a less batch oriented version in the future.  Can you update the description?

Test build #59763 has started for PR 13342 at commit 56bf805.

Test build #59757 has finished for PR 13342 at commit d2b19b7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DefaultSource extends StreamSourceProvider with StreamSinkProvider
class DataFrameReaderWriterSuite extends StreamTest with BeforeAndAfter
class ForeachSinkSuite extends StreamTest with SharedSQLContext
  case class Open(partition: Long, version: Long) extends Event
  case class Process[T](value: T) extends Event
  case class Close(error: Option[Throwable]) extends Event

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59757/
Test FAILed.

Merged build finished. Test FAILed.

Test build #59768 has started for PR 13342 at commit d6bb884.

Test build #59763 has finished for PR 13342 at commit 56bf805.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59763/
Test FAILed.

Test build #59768 has finished for PR 13342 at commit d6bb884.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DefaultSource extends StreamSourceProvider with StreamSinkProvider
class DataFrameReaderWriterSuite extends StreamTest with BeforeAndAfter

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59768/
Test PASSed.

Test build #60077 has started for PR 13342 at commit 529f3d4.

Test build #60077 has finished for PR 13342 at commit 529f3d4.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class ForeachWriter[T] extends Serializable

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60077/
Test FAILed.

Merged build finished. Test FAILed.

Test build #60078 has started for PR 13342 at commit 6279486.

Test build #60078 has finished for PR 13342 at commit 6279486.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60078/
Test PASSed.

Merged build finished. Test PASSed.

Test build #60254 has started for PR 13342 at commit 42286b0.

Test build #60260 has started for PR 13342 at commit 2f2e9b3.

Test build #60254 has finished for PR 13342 at commit 42286b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60254/
Test PASSed.

LGTM, except a few minor nits.

Test build #60260 has finished for PR 13342 at commit 2f2e9b3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60260/
Test PASSed.

Test build #60274 has started for PR 13342 at commit 8cb7aa5.

Test build #60274 has finished for PR 13342 at commit 8cb7aa5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60274/
Test PASSed.

Merged build finished. Test PASSed.

Merging this to master and 2.0


Refactor inferFooOp functions to use Type/TypeRange instead of Value/ValueRange

Originated from the comment on #1019.
This will simplify the infer interface by using the least possible amount of information which is sufficient to drive the type inference and thereby enable reuse of these methods.

This can be done for "almost all" ops, with the exceptions including (but not limit to):

SetDimensionSizeOp: https://github.com/openxla/stablehlo/pull/1029
(by Eugene) groups C and D in https://github.com/openxla/stablehlo/issues/867

Assigning to Xin, since this falls into the overall theme of providing a public API for StableHLO.


Remove regexp_parser dependency

json_schemer doesn't seem to directly require or depende on regexp_parser. It requires ecma-re-validator, which uses regexp_parser vicariously. So we should only require on ecma-re-validator, and allow it to require on its upstream dependencies correctly.
(The current dependency is too strict and is preventing us from using regexp_parser 1.6.0 via other gems.)

Additionally, the gem dependencies are probably too strict — to avoid the same problem with shared dependencies a pessimistic dependency on the minor version is probably better:
https://github.com/sj26/json_schemer/compare/remove-transitive-dependency...relax-dependencies

Thanks for the PR @sj26!
regexp_parser is used here: https://github.com/davishmcclurg/json_schemer/blob/926dfffc5fa0621140840a2996ad1558fcc548b0/lib/json_schemer/schema/base.rb#L547-L549
Good catch on me missing the require. I added it and relaxed the dependencies as you suggested in cd02b7688ef46a45fd32a7681a41f69937da2cdd and 926dfffc5fa0621140840a2996ad1558fcc548b0.
Released in 0.2.2

Ah, sorry I missed that, thanks @davishmcclurg!


favicons not included in bundle using Windows build

I'm using Windows 10.
I just downloaded the project and need to use it on a windows computer. After installing cross-env to solve the Windows environment variable (from this issue](https://github.com/ctrlplusb/react-universally/issues/412), I could call:
npm run develop or npm run start
Unfortulnatelly the icons are not being shown. Looking at the bundle\client folder  I can't see the icons being built from webpack.
I need help to build the bundle in my Windows 10 environment and make it run. Thanks for the support.
SOLVED:
In fact nothing to do with the bundle. I have to change the following parameter:
`  // The host on which the server should run.
host: EnvVars.string('HOST', '<IP_ADDRESS>'),`
to
`  // The host on which the server should run.
host: EnvVars.string('HOST', 'localhost'),`

Or just set HOST=<IP_ADDRESS> to your dotenv file.

Got this problem too, along with the counter increment demo app being broken, showing Failed to load resource: net::ERR_ADDRESS_INVALID in the console. The EnvVars fix solved it.


Why pss::Signature implement TryFrom<&[u8]> but don't raise any error ?

Hello,
I have a question concerning the implementation of pss::Signature when we try to build a new signature from raw bytes.
Signature implement TryFrom<&[u8]> for that, indicating that it may fail but the implementation always return Ok.
Is there a reason for Signature to impl TryFrom<&[u8]> and not From<&[u8]> ?
https://github.com/RustCrypto/RSA/blob/40069a5408dc9eb531d68a50b3ada5c9ab47466d/src/pss/signature.rs#L35-L44

A TryFrom<&[u8]> bound is required by the SignatureEncoding trait.
It doesn't mandate an error type though, so Infallible and with it the blanket impl of TryFrom for types which impl From) should be allowed.
However, it would probably make sense to set an upper bound on the size of a PSS signature (e.g. 2048-bytes) to prevent it from parsing some extremely large value as a BigUint.

Thank you for the clarification, I'll close this issue since my question was answered :smile:


Provide a function to compare pointers and references for equality

Currently, Rust lacks a nice way to compare two values of type &T or Cell<T> for identity of references (as opposed to identity of the stored values). With a, b having type &T, one has to write a as *const _ == a as *const _, which is not exactly discoverable nor nice to look at.
We (eddyb, kimundi and me) discussed this on IRC, kimundi made the following proposal:
 fn ptr_eq<T>(a: *const T, b: *const T) -> bool { a == b }

Thanks to coercions, in the above scenario, we can now write "ptr_eq(a, b)". eddyb was opposed to a function providing "reference" equality on &T, due to the difference of references in Rust and other languages (in particular, involving zero-sized types).
I think some nice way of comparing pointers (references) for equality should be provided, that does not force the user to manually write down a cast to a "dangerous" raw pointer (though of course the usage above is completely safe).

ptr_eq is very useful due to type inference and coercions. I had a tiresome comparison of *mut T to &T and this function coerces both sides correctly unlike plain ==.
The ptr_eq function also makes sure you compare pointers with the same destination type.

At the moment I use as_unsafe_cell() of RefCell to do the same thing. It works in my use-case because the data is already enclosed in an RefCell, but this feature would be a non-unsafe replacement.

@Columbus240 You can implement ptr_eq or compare raw pointers (comparing *const RefCell<T> in your case) directly, don't need unsafe.

I noticed that too, I misunderstood the concept of raw pointers in Rust, this is the first time I use them.
ptr_eq would be a nice abstraction instead of manually checking the equality.

The ref_eq crate now provides this (implementation taken from an old version that was deleted from the standard library)

https://github.com/rust-lang/rust/pull/35992 implements this.


Docs(NCarousel) Remove autoplay from non-autoplay examples

I found the autoplaying confusing as to what was different between these.
I think the autoplay should be left for only the autoplay example so you can explore the specific differences of the other examples.

I think the example should indicate that users can try as many combinations as possible, rather than controlling variables to find different ones. Sorry, my English is not very good. I'm not sure if you understand me.

I think the example should indicate that users can try as many combinations as possible, rather than controlling variables to find different ones. Sorry, my English is not very good. I'm not sure if you understand me.

Your English is good 👍
I understand your concerns, but I see akioni already merged this. For this example though I found the autoplay to be very distracting. Maybe we could have other combinations that do not include autoplay?


Adding one extra conversion test.

@sougou this is the case I was referring to, finally found it.

LGTM


Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.
You can use import() statements if you configure your tsconfig.app.json to use "module": "esnext",, but setting up lazy loading manually is not trivial.

Ok thanks, but is there any way I can resolve this, if any will be appreciated.


requestPermissions always return true [iOS]

When I'm tried using requestPermissions on iOS I'm getting issue it's always return true. When the user click Don't Allow it shows up an alert like this and then return true. After that, I tried using function isAuthorized and it always returns true.

Anyone can help me resolve this issue?

TLDR: Unfortunately this is the default behaviour from iOS, check workaround.
Apple restricts basically every permission authorization in a similar way. The first time you call the method you will receive false which implicates "User has not been asked for permissions" and any subsequent call will return true, meaning "User has been asked for permissions".
Basically every iOS app developer (no matter Swift/ObjC or React Native) faces that issue, but it's Apple's way to restrict this popup screen you have on the screenshot.
Workaround
I'm currently using this flow and it's basically what everyone does in a way.

Check if user has been asked for permissions

const hasBeenAsked = await Fitness.isAuthorized(permissions)

Request permissions, if you can

if (! hasBeenAsked) {
  await Fitness.requestPermissions(permissions)
}

Check if you can get some data

const stepsYesterday = await Fitness.getSteps({
  startDate: moment().subtract(1, 'day').format(),
  endDate: moment().format(),
})

If you couldn't get data
if (stepsYesterday.length === 0) {
  ...
}

This implicates some issue, it might be user has no data for that period, or has not shared permissions with your app.
At this point, most apps show a popup alert or a styled modal window instructing the user what to do.
Which is:

Open the Health app
Go to Profile -> Privacy -> Apps -> Your App
Press Turn All Categories On

If you could get data
All is good, no need to worry.
Closing thoughts
Dealing with this is a small pain for the developer, but big pain for the user. Unfortunately I didn't find a better workaround and I'm not sure there is another one.
What can I suggest is that you perform that check on every app start and/or state change (when app goes to background and then active again), because the users can disable this the same way you told them to enable it.
Also, you can take a look and inspiration from other fitness apps and how they handle this kind of situation.
Hope this helps!

@dmitov Thanks for your help! I think that is the only way to check permission on iOS!


[lsp] Markdown not fully rendered

Hi @hrsh7th
I have noticed that completion documentation coming back from css lang server (your other repo) has some escape characters printed out. Please see screenshot below.

I have noticed that you are using your own implementation of Markdown renderer (Vital). There is one built in in Neovim, I believe, that is being worked on by @mjlbach, perhaps using it would simplify compe's code? Just a thought.
https://github.com/neovim/neovim/issues/14032
https://github.com/neovim/neovim/pull/14073

I think this problem should be fixed by #249

vim-vital-vs is used by vim-lsp/nvim-compe/vim-lamp. So it should be improved for me.
But if the neovim's fancy float would be accurately handled markdown, I will change to it.
Currently, it can be done by the simple patch, I think.
IMO, The LuaJIT is incredibly fast so we can parse markdown and generate detailed highlight for markdown (this way has a benefit that is enabling accurately calculate floating window sizes. Currently, we can't it because concealed characters.

Ah, alright then. Will wait for #249 and keep this issue open for now. Thanks for all your effort once again!

FYI currently what we are doing in core is just adding a custom syntax file and setting the conceal level (to 2) in the floating markdown window which hides the escape characters. I made a PR that strips escape characters when parsing the return from the language server, but IMO the syntax rule + conceal approach is more flexible.

@mjlbach Thank you for your FYI.
I've implemented escape chars/html entities as https://github.com/hrsh7th/vim-vital-vs/blob/master/autoload/vital/vital/VS/Vim/Syntax/Markdown.vim#L10
IMO, the conceal approach can't calculate the correct floating window sizes but it is enough solution.

@hrsh7th great work with improve branch. Thanks!
I have noticed that markdown breaks words into new line. Like here:

Also would be good to avoid that extra indentation in last paragraph.

Hm... I was investigating it but the current approach can't solve it.
We should add the padding sub-window for it but it needs to fix neovim itself first.

I see! Since original issue is solved feel free to close that issue, unless you would like to keep it open for that last problem I mentioned.

Thank you.
If neovim improve floating window composition, I will try to fix it.

Bfredl is currently working on borders which would let us remove the padding operation we currently do, the indentation in the paragraph above may be due to conceal rules applied to nbsp, not sure.

Hm... the documentation data is following (it has no &nbsp...
[
  ' ```lua function pcall(f: function, arg1?: any, ...) ',
  '   -> success: boolean ',
  '   2. result: any ',
  '   3. ... ``` ',
  ' --- ',
  '  ',
  '  ',
  ' Calls the function `f` with the given arguments in *protected mode*. This means that any error inside `f` is not propagated; instead, `pcall` catches the error and returns a status code. Its first result is the status code (a boolean), which is true if the call succeeds without errors. In such case, `pcall` also returns all results from the call, after this first result. In case of any error, `pcall` returns `false` plus the error object. ',
  '  ',
  '  ',
  '  ',
  ' [View documents](http://www.lua.org/manual/5.1/manual.html#pdf-pcall) '
]

Current approach uses &breakindent and &wrap combination. I guess this problem relates to linebreak behavior.

Hm... we shouldn't use wrap and should use manual linebreak implementation...?


The structure of the wizard is not proper, aria-labelledby is referencing the id of one of the tab content header, instead of the wizard header

Describe the bug
This is an issue with accessibility. We got a report from AccessLevel where they note that the structure of the wizard is not proper. aria-labelledby is referencing the id of one of the tab content header, instead of the modal header for better context.
Because the dialogs title is often visually apparent but may be difficult to locate using assistive technology such as screen readers, a title must be provided through a proper accessible manner to ensure that the purpose of the modal dialog is understood.
Ensure that proper heading is referenced via aria-labelledby from the element representing the dialog.
How to reproduce
Steps to reproduce the behavior:

Go to https://clarity.design/documentation/wizards
Scroll down to 'Code & Examples'
Click on 'X-Large Wizard'
Inspect the wizard
See that the dialog element has aria-labelledby attribute that is referencing the id of the tab content header, instead of the wizard title.

Expected behavior

<clr-wizard-title>XL Wizard (Default)</clr-wizard-title>

Versions
App

Angular: [9]
Node: [10.16.1]
Clarity: [3.0.0]

Device:

Type: [PC]
OS: [Windows 10]
Browser [chrome]
Version [81]

Hi is this a VMware product report? If so, this was done purposefully and should probably not be considered an issue, but it would be best work with the accessibility contact to resolve this report.

Hi is this a VMware product report? If so, this was done purposefully and should probably not be considered an issue, but it would be best work with the accessibility contact to resolve this report.

Hi!
The report is from an external vendor (Level Access). The VPAT severity of the issue is 8, that is A-level defect and is blocker to people with disabilities. It is not an option to resolve it as 'not an issue'.

Hi, I understand Level Access did the testing, but was the testing done for a VMware product? If so, we have a process to handle these reports that should be handled through the accessibility team for traceability and verification. It is difficult to know for sure over GitHub, which is why I asked.
This is an example of a functionality that was implemented under the guidance of the accessibility team, which means it challenges their previous recommendation. If this not a VMware product, then I'll have to review it with our accessibility team.

Yes, the testing was done for a VMware product - Site Recovery Manager 8.3

The Wizard dialog actually has 2 titles. Fortunately, aria-labelledby can accept multiple values e.g. aria-labelledby="title1 title2". I recommend referencing both titles with aria-labelledby. See https://www.w3.org/TR/wai-aria-1.1/#aria-labelledby.

Clarity cares deeply about accessibility, and we work with our accessibility team to identify and triage issues. We have an internal tracking system to identify and verify accessibility issues, which has captured this already. Some issues with Clarity Angular are difficult to solve without causing side effects or breaking changes, and we have to balance concerns with fixing issues and breaking changes. As we build out Clarity Core, we are able to address these root cause accessibility issues and recommend adopting the Clarity Core implementations as they become available. We are closing this issue as we have the issues tracked internally. Please follow our development and releases to see when we release relevant Clarity Core components to make this possible.


Fixed null ruleset if package is not available

fix for #89
If a package is defined in the composer.lock and specified as dev package the composer loader will crash if composer install is executed without dev libraries because ->loadPackageRuleSet() returns null.

This worked for me. I no longer have to specify location(s) to check...
Checking your application for deprecations - this could take a while ...

Loading RuleSet...

RuleSet loaded.

Parsing files & Searching for deprecations...

Finished searching for deprecations.

Rendering output...

+---+-------+------+---------+
| # | Usage | Line | Comment |
+---+-------+------+---------+
Your project contains invalid code:
Finished rendering output.

There are no violations - congratulations!
Checked 136 source files in 466.045 seconds, 57.25 MB memory used

I know my code is broken. ;)


Refactor unit tests in proxy pkg

1 - removed unused func convertTestName from proxy.go
2 - moved fileToString from proxy.go to jmeter.go where it's actually used
3 - moved test related to loadTest.validate() from proxy_test.go to jmeter_test.go
4 - restructured and extended existing unit tests for proxy.go and jmeter.go

+1

+1


"Something happened while injecting into Final Fantasy XIV"

Using 1.3.6. Every time I run the program, I get that message and the program halts.
This prints in the Error.Log.
2019-06-20 11:01:57.0544 Injection Failed! newmem: 0x7F77FFB0000, inject: 0x0 System.BadImageFormatException: An attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
at PaisleyPark.Common.AsmjitCSharp.Native_Assembler(String input, IntPtr& addr, Int32& size)
at PaisleyPark.Common.AsmjitCSharp.Assemble(String input)
at PaisleyPark.ViewModels.MainWindowViewModel.InjectCode()

Do you have a 32-bit OS?

Running Windows 8 Pro 64-bit and DX11 of FFXIV.

Can you try downloading a fresh copy of 1.3.6 and try again?  I just did so myself, and had no issues running and injecting into FFXIV.

Tried a fresh copy on that computer, no luck, same error.
Tried it on a different computer (Win 8.1 64-bit, DX11), no issues.
So not sure why my main computer for playing FFXIV is causing issues and hoping you have an idea.

It's hard to say, but your error is specifically about architecture types being mismatched, which is why I asked you about if you had a 32-bit OS.  Is there any chance you can upgrade to Windows 10?  I can't really ensure that Windows 8 will function properly as I have no way of testing that operating system.


One line DKIM entry

Generating our own DKIM entry as it is easy to do without opendkim-genzone and single line is easier to copy-paste for admins who are using DNS providers with bad web interfaces that require copy-pasting DNS values into single-line fields.
Based on #186

What's the state of this PR? I changed the base branch to main, as we merged #186... but this branch contains the outdated https://github.com/deltachat/chatmail/pull/187/commits/cd3aa73beea61f7c5bfc20912e0b5c748f52a165 commit and would work better without it, I guess?

Hm, the zonefile is not written properly, nsd throws an error in the CI: https://github.com/deltachat/chatmail/actions/runs/7717289390/job/21036055628?pr=187
but https://github.com/deltachat/chatmail/commit/cece3dc14f8c746c3038692c8bec48c589b5f5ce is no proper fix either, it results in this faulty DNS record:
$ dig @ns.testrun.org TXT opendkim._domainkey.staging.testrun.org

; <<>> DiG 9.18.18-0ubuntu<IP_ADDRESS>-Ubuntu <<>> @ns.testrun.org TXT opendkim._domainkey.staging.testrun.org
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 37353
;; flags: qr aa rd; QUERY: 1, ANSWER: 1, AUTHORITY: 1, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;opendkim._domainkey.staging.testrun.org. IN TXT

;; ANSWER SECTION:
opendkim._domainkey.staging.testrun.org. 300 IN	TXT "v=DKIM1"

;; AUTHORITY SECTION:
staging.testrun.org.	300	IN	NS	ns.testrun.org.

;; Query time: 52 msec
;; SERVER: <IP_ADDRESS>#53(ns.testrun.org) (UDP)
;; WHEN: Wed Jan 31 00:26:08 CET 2024
;; MSG SIZE  rcvd: 105

Ah, that was because it didn't use quotes, and then nsd treats the ; as a comment.


[Aliases] Possible bug in aliasing code

Context
Please revise, you might find it useful for some other related issues:
Original text 1:
Since `extra` was converted to a 2d array for the propagation of aliases, the following check to see whether a currently selected column value for a form as stored in `WizardProperties` will always fail:
* [WizardProperties#_updateForm](https://github.com/bloomberg/cartodb/blob/blp_dev/lib/assets/javascripts/cartodb/models/wizard.js#L357)

Note that the resolution of this issue is contingent upon the structure of `extra` being finalized in https://github.com/CartoDB/cartodb-bloomberg/issues/245.

Original text 2:
In many cases, the `extra` values, or allowed values/options of a form contain both flat strings e.g. "None" to indicate no selection or an array of names/aliases when the choices are columns, such as:

extra = [ "None", ["col_name", "col_name", "alias"], ... ];

As per [FormSchema#_fillColumns](https://github.com/bloomberg/cartodb/blob/blp_dev/lib/assets/javascripts/cartodb/models/wizard.js#L84), this is the case when `extra_default` is set on the forms. A couples examples are:
* https://github.com/bloomberg/cartodb/blob/blp_dev/lib/assets/javascripts/cartodb/table/menu_modules/carto_wizard_forms.js#L59
* https://github.com/bloomberg/cartodb/blob/blp_dev/lib/assets/javascripts/cartodb/table/menu_modules/carto_wizard_forms.js#L247

You should be able to observe this on creating a new map with an empty dataset and stepping through the `_fillColumns` code.

I haven't directly observe a bug resulting from this structure. However, on our call yesterday, Josh agreed that this didn't seem like the intended behavior of the `extra` values, in which case I think it should be investigated further to ensure that it works as designed and that the current behavior cannot cause any issues.

@coyle5280, the second one has been resolved by them. Could you review? https://github.com/bloomberg/cartodb/pull/183/files

So after some research I think I understand what is happening here with the 'None' value.  In the wizards certain drop downs or 'Select' fields need a null/empty/None field for the selection.  In order to offer this choice to the user the 'None' value needs to be injected into the list of possible choices or columns.  If you look at the label field for the simple wizard you will see that the default choice is None.  If I understand there code they would remove this option from the list of choices. This might break the wizard by not allowing you to remove the label field.  If it's not broke don't fix it!!  But if they insist on the array being homogeneous then I would say we make the change you see in branch 179_possible_bug.  I tested this out and did not see any issues with this implementation.  I would not recommend there implementation without testing wizards. Especially the label fields or any field that uses a 'None' value.

Thanks, I forwarded your comments to Bloomberg. If you can write comments on https://github.com/bloomberg/cartodb/pull/183/files directly, feel free to do so. For this one I just quoted you (with a bit of changes here and here), but just write on those lines directly next time :)

Do you have any input on "Original Text 1"?


Add support OpenBSD and NetBSD and HP-UX parisc/ia64 cpu

Patch add support for OpenBSD and NetBSD OS's and for HP-UX parisc/ia64 32/64 bit data models.

Merged.


Creating triangles instead of squares

This might be a hastile bug (probably not though).
Go to a polygon map and see that we get clipped squares - that is, triangles clipped out of squares.
Steps to reproduce in:

wget http://localhost:8080/demographics/21/1894655/1287446.mvt

readMvt "./1287446.mvt"

... {polyPoints = [(2176,-128),(2176,2176),(-128,2176),(2176,-128)] ...
That forms a triangle - should be [(2176,-128),(2176,2176),(-128,2176),(-128,-128)]

However,

wget http://localhost:8080/demographics/21/1894655/1287446.json

readLayer "./1287446.json" config

... polyPoints = [(2176,-128),(2176,2176),(-128,2176),(-128,-128)] ...
That is the right answer.

Config is:

config = mkConfig "foo" 21 (1894655,1287446) (Pixels 128) (Pixels 2048)

How does that go wrong?

Looks like a problem with the vectotile library - write a test - encode - decode with quickcheck.

The answer was repeat the last point at the head of the list - completes the polygon.


docker-compose up fails ERROR: for prometheus

Just started playing with this today. After creating the docker-compose.yml I ran: docker-compose --profile monitoring up -d && docker-compose logs -f
Everything pulled fine but I got an error at "Creating surrealdb-prometheus ... error"
After everything was done pulling and creating, this was the error it gave:
ERROR: for prometheus  Cannot start service prometheus: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/my/path/to/surrealdb/config/prometheus.yml" to rootfs at "/etc/prometheus/prometheus.yml": mount /my/path/to/surrealdb/config/prometheus.yml:/etc/prometheus/prometheus.yml (via /proc/self/fd/6), flags: 0x5001: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
I went into config and noticed that all of the following were directories instead of files: pd.rules.yml, prometheus.yml, tidb.rules.yml, tikv.rules.yml. I'm assuming these are supposed to be regular yml configuration files but they got created as directories for some reason.
Any thoughts on how to fix this? Or point me to what those yml files are supposed to contain and I'll recreate them and try again.
Thanks!

Also just tried running docker compose without the monitoring by, docker-compuse up -d && docker-compose logs -f, and I get a bunch of log outputs of :
surrealdb-grafana | GF_PATHS_CONFIG='/etc/grafana/grafana.ini' is not readable.
surrealdb-grafana | You may have issues with file permissions, more information here: http://docs.grafana.org/installation/docker/#migration-from-a-previous-version-of-the-docker-container-to-5-1-or-later
surrealdb-grafana | t=2023-01-06T15:48:39+0000 lvl=crit msg="Failed to parse /etc/grafana/grafana.ini, open /etc/grafana/grafana.ini: no such file or directory"

I also ran into the above issue.  I also noticed that all the local files were created as root rather than the local user.  Wiped out the directories, updated the userns-remap and verified that even when the files are created as my local user; the prometheus bit fails since everything in config is a directory.


Refactor Sort

Codecov Report

Merging #51 (0f6fb73) into master (38c0535) will decrease coverage by 12.23%.
The diff coverage is 90.19%.

@@             Coverage Diff             @@
##           master      #51       +/-   ##
===========================================
- Coverage   78.29%   66.05%   -12.24%
===========================================
  Files          49       49
  Lines        4413     4384       -29
  Branches      555      538       -17
===========================================
- Hits         3455     2896      -559
- Misses        732     1314      +582
+ Partials      226      174       -52

Impacted Files
Coverage Δ

...elasticmagic/serde/serialization/JsonSerializer.kt
48.83% <0.00%> (-15.45%)
:arrow_down:

...in/kotlin/dev/evo/elasticmagic/serde/Serializer.kt
35.48% <ø> (ø)

...onMain/kotlin/dev/evo/elasticmagic/query/Script.kt
88.88% <83.33%> (+44.70%)
:arrow_up:

...mmonMain/kotlin/dev/evo/elasticmagic/query/Sort.kt
89.52% <96.77%> (+24.52%)
:arrow_up:

...kotlin/dev/evo/elasticmagic/serde/StdSerializer.kt
76.74% <100.00%> (+0.55%)
:arrow_up:

...in/dev/evo/elasticmagic/serde/jackson/JsonSerde.kt
0.00% <0.00%> (-100.00%)
:arrow_down:

.../evo/elasticmagic/compile/UpdateMappingCompiler.kt
0.00% <0.00%> (-96.67%)
:arrow_down:

...otlin/dev/evo/elasticmagic/compile/BulkCompiler.kt
0.00% <0.00%> (-92.43%)
:arrow_down:

...otlin/dev/evo/elasticmagic/ElasticsearchCluster.kt
0.87% <0.00%> (-89.48%)
:arrow_down:

...c/commonMain/kotlin/dev/evo/elasticmagic/Result.kt
9.72% <0.00%> (-88.89%)
:arrow_down:

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c0535...0f6fb73. Read the comment docs.


Update the Spec to v0.6

Will be updating the spec to v0.6 when available -- At this point it will freeze as we attempt to communicate in a single client testnet and then between artemis.

I think this can be closed @GregTheGreek


Portal dies when restarting after reboot

The Cockpit Portal on be-scale-1 failed to restart after a  reboot with following error:
load actor /opt/jumpscale8/apps/portals/portalbase/system/system__atyourservice/
'utf-8' codec can't decode byte 0xf3 in position 16: invalid continuation byte

It turned out to be related to MongoDB
For more details check with @nicolas_krassas (Telegram)

Verify/fix on 8.2.0

can not reproduce


Dask not communicating to all workers in the cluster

Hi Team and @mrocklin ,
I am trying to configure dask distributed cluster from this https://distributed.readthedocs.io/en/latest/setup.html. And I did successfully with Scheduluer and 2 worker nodes. In each worker node I have created local test.csv file and code looks like
worker1 test.csv:
X,Y
x1,2
x2,3
x1,1

worker2 test.csv:
X,Y
x4,2

Code Running in Master node :
from dask.distributed import Client
import dask.dataframe as dd
client = Client('scheduler-address:8786')
df = dd.read_csv('*.csv')
df = client.persist(df)
df.head()

Output of above code:
X,Y
x1,2
x2,3
x1,1

But Expected output:
X,Y
x1,2
x2,3
x1,1
x4,2

From the above observation, if run the above code it is contacting only single worker node. I have removed Worker-1 from the cluster  then I ran the df.head() and interestingly I got Worker2 data,
X,Y
x4,2

I am not sure what I was missing here ?

This is expected behaviour. When you do df = dd.read_csv('*.csv'), the paths are resolved in the client, and sent to workers - in this case, just the one file, so one loader task is generated. It so happens that each worker has such a named file locally, so which data you get depends on which worker executes your one task.
What you actually want is a common file-system (on the cluster or remote) for the whole cluster, so you can find files on the client and read them from workers and be sure you are referring to the same thing. You could make custom delayed function that loads data from a known location on each worker machine and then use dd.from_delayed() to create your dataframe, but you will need to figure out how to ensure that the task gets executed exactly once on each worker. This is not a typical workflow.
Suggest to close as not a bug.

Thank you for detailed information, Earlier I was thought dask will provide data locality but yesterday myself I did some research and found exactly what you said, Ofcourse dask relays on pandas to read_csv. I am looking for each worker node contains some data and client starts computation then each worker collect their own data and compute it then result send back to the client.


Date argument not being correctly handled

Date is always being resolved to have a 00:00:00 time.
sat himawari --skipempty --date 2016-02-12 8:30:00 +0000 --debug
Creating undefined in /Users/joel/sat ...
[Himawari] Resolving date...
[Himawari] Date resolved Fri Feb 12 2016 00:00:00 GMT+0000 (WET)

What if you wrap the date in quotes?

That's the problem, you need to wrap your date in quotes.
bin/cli.js --skipempty --date "2016-02-12 8:30:00" --debug
Creating undefined in /Users/jkelley/Repos/himawari.js ...
[Himawari] Resolving date...
[Himawari] Date resolved Fri Feb 12 2016 08:30:00 GMT-0800 (PST)


chore(deps): vite ddd5c5d

#147  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Ensure server parameter 'log_checkpoints' is set to 'ON' for PostgreSQL Database Server

Possible check to target the following resource

[ ] azurerm_postgresql_configuration

closing, tracking in spreadsheet

closing, tracking in spreadsheet


Publish Stage

Closes #920
Swap Tool: Limit available balance to 8 decimals. Closes https://github.com/osmosis-labs/osmosis-frontend/issues/1346
LayerSwap: use Coinbase to deposit USDC instead of Kado
New Pools Page! includes infinite scroll. Closes #1349 #1248 #1175 #1057

Testing

Axelar deposit/withdraw ETH, GLMR, AVAX, MATIC, FTM, BNB

Depositing: since these are gas tokens being transferred, make sure the gas cost is calculated and properly deducted from the transfer amount when clicking max. Make sure there's enough gas to click confirm, to prevent metamask from blocking us since it claims we don't have enough gas token to pay gas fees.

Axelar deposit withdraw non-wrapped asset
Connecting/disconnecting Metamask
Ensure links to satellite work properly; for deposit/withdraw, and the proper assets/networks are present on satellite
Only show swap route vis in home page, not in pool detail page
Deposit USDC from Coinbase via LayerSwap

----------------------------------------WIP-----------------------------------
Testing

[x] Auto-wrap native assets

Axelar deposit/withdraw non-wrapped asset

ETH
[ ] deposit***** issue being track
[x] withdraw
GLMR
[ ] deposit
[ ] withdraw
AVAX
[x] deposit
[x] withdraw
MATIC
[x] deposit
[x] withdraw
FTM
[x] deposit
[x] withdraw
BNB
[ ] deposit *****  issue being track
[x] withdraw

Depositing: since these are gas tokens being transferred

[x] make sure the gas cost is calculated and properly deducted from the transfer amount when clicking max.

[x] Make sure there's enough gas to click confirm, to prevent metamask from blocking us since it claims we don't have enough gas token to pay gas fees.

[x] Connecting/disconnecting Metamask

[x] Ensure links to satellite work properly; for deposit/withdraw, and the proper assets/networks are present on satellite

[x] Only show swap route vis in home page, not in pool detail page

[x] Swap Tool: Limit available balance to 8 decimals. Closes https://github.com/osmosis-labs/osmosis-frontend/issues/1346

[x] Deposit USDC from Coinbase via LayerSwap

New Pools Page

[x] Incorrect APR sorting #1248
[x] Redesign pools page #1175 infinite scroll
[x] Pools Tabs shouldn't stay in 0. #1057


osd posX and posY does not work

Changing osd posX and posY does not affect on label position, I tried different positive and negative values.
majestic version: master+37ff773, 2021-06-17

It seems the bug appeared when we made the transition to yamlStyle naming in config
Please check the latest build, issue has been resolved on my camera

Yep, works normal in master+5e05922, 2021-06-20


Textures added from Sollumz Material panel appear black

Adding texture/changing textures from the Texture Parameters panel appears black or not updated at all in the Blender viewport. (screen1)
Export seems to work fine (screen2)
Another thing I noticed is that adding the same texture creates a 'duplicate' in the Blend file unnecessary bloating Blend file size and a mess (screen3)

Pushing a fix for the first issue mentioned. When you set the texture path, it's not creating a new image, but just changing the path of the image data block being used by the Image Texture node. So if the image exists in the file already you would want to delete the currently used image and select the desired image using the dropdown in the image texture node (the one you have open in the last screenshot).


Added support for fortran and yaml filetypes

Not strictly necessary since the &commentstring option gives valid comment characters (but then, that seems to be true of most other filetypes supported).
(Thanks for an awesome plugin, by the way).

Fork notice: With the upstream project sitting stale after nearly 8 months since the last activity, 71 outstanding pull requests, no comments from the original developer, and dozens of developers duplicating efforts while scratching their own itches, I've decided to step in and run a fork for a while. Hopefully the original developer will eventually consider picking this plugin up again or adding more maintainers so that the user base doesn't end up fragmented, but for now I would invite anyone interested in the latest updates to consider installing from and contributing pull requests to my fork.
About this PR: I have merged this PR as is. Please consider installing the plugin from alerque/nerdcommenter for this and (so far) over two dozen other updates.

Great, thanks for taking over!

Change of plans. Thanks to scrooloose who has added me as a maintainer to this repo, I'll be going through and taking care of business here instead of in a fork. This PR has been merged directly upstream.
Thanks for your contribution @pbugnion.

That's even better. Thanks.


[feature] Add an outline sidebar for  classes, methods, and functions.

It would be perfect if there were an outline sidebar for classes, methods, and functions.

Can you link me an example of what you are looking for?

Probably like this:


50k issue

Song Name
hide away
Artist Name
synapson
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=yah039oS2sM
Direct File Link
No response
Song ID
2023
Extra
Hide away

accept


[vm/mac] Error is wrong type: OS Error: Connection reset by peer, errno = 54

There are new test failures on [pkg:vm_service] ignore four deprecated member references...[CFE] Remove unreachable/unused code in constant evaluator.
The tests
standalone/io/https_unauthorized_test RuntimeError (expected Pass)

are failing on configurations
dartk-weak-asserts-mac-debug-x64

Failure: Error is wrong type: OS Error: Connection reset by peer, errno = 54 - might be an infrastructure flake.

Failed once again:
/==============================================================================================================\
| dartk-strong-mac-debug-x64:standalone/io/https_unauthorized_test broke (Pass -> RuntimeError, expected Pass) |
\==============================================================================================================/

--- Command "vm" (took 11.000594s):
DART_CONFIGURATION=DebugX64 xcodebuild/DebugX64/dart --sound-null-safety --ignore-unrecognized-flags --packages=/opt/s/w/ir/.packages /opt/s/w/ir/tests/standalone/io/https_unauthorized_test.dart

exit code:
255

stdout:
Client failed
  stdout:

  stderr:
Unhandled exception:
ExpectException: Error is wrong type: OS Error: Connection reset by peer, errno = 54
#0      expect (file:///opt/s/w/ir/tests/standalone/io/https_unauthorized_client.dart:20:5)
#1      runClients.<anonymous closure> (file:///opt/s/w/ir/tests/standalone/io/https_unauthorized_client.dart:36:7)
#2      _RootZone.runUnary (dart:async/zone.dart:1450:54)
#3      _FutureListener.handleError (dart:async/future_impl.dart:160:20)
#4      Future._propagateToListeners.handleError (dart:async/future_impl.dart:708:47)
#5      Future._propagateToListeners (dart:async/future_impl.dart:729:24)
#6      Future._completeError (dart:async/future_impl.dart:537:5)
#7      Future._asyncCompleteError.<anonymous closure> (dart:async/future_impl.dart:593:7)
#8      _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#9      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#10     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:120:13)
#11     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:185:5)

stderr:
Unhandled exception:
Expect.fail('Client subprocess exit code: 255')
#0      Expect._fail (package:expect/expect.dart:704:5)
#1      Expect.fail (package:expect/expect.dart:282:5)
#2      main.clientProcess.<anonymous closure> (file:///opt/s/w/ir/tests/standalone/io/https_unauthorized_test.dart:62:16)
#3      _RootZone.runUnary (dart:async/zone.dart:1450:54)
#4      _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#5      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#6      Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#7      Future._completeWithValue (dart:async/future_impl.dart:529:5)
#8      Future.wait.<anonymous closure> (dart:async/future.dart:414:23)
#9      _RootZone.runUnary (dart:async/zone.dart:1450:54)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:567:7)
#15     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#16     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#17     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:120:13)
#18     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:185:5)

--- Re-run this test:
python tools/test.py -n dartk-strong-mac-debug-x64 standalone/io/https_unauthorized_test

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8864045545036903984/+/steps/test_results/0/logs/new_test_failures__logs_/0


proposal: reflect: add generic type arg info to reflect.Type

I'm not sure if this has been discussed already (I couldn't find a prior issue),  but currently reflect.Type has no direct methods to retrieve the type arguments of generic types.
The only way to retrieve these type arguments is by parsing the string returned by Type.Name() which includes fully qualified package names and could look something like this in a complex case: MyGenericType[some/package.Foo, map[string]other/package.Bar]. This string is not easy to parse because of the possibility of nested type arguments, maps, slices, etc.
I propose adding methods to reflect.Type to retrieve these type arguments programmatically:
NumTypeArg() int
TypeArg(i int) Type

I'm not sure TypeParam is the right name here.  The type parameters are the parameters that appear in the type definition.  I think that what you are describing is what we usually call the type arguments.

@ianlancetaylor Those terms are not the ones I know from my youth. We used to talk about formals and actuals, which carry a distinct meaning already. Modern computing's use of the terms parameters and arguments results in a domain-specific redefinition of true synonyms in normal English. However, I admit that redefinition is not unique to Go.
I wonder why this terminology shift happened.

Adding methods to reflect.Type would be a breaking change.

@icholy reflect.Type has unexported methods, so every type which implements it is in package reflect and can be updated along with the interface. Is there another sense in which it would be a breaking change to add methods to reflect.Type?

@robpike That's true, now that you mention that I remember "formal" and "actual" as well.  But today even the Go spec speaks of "function parameters" and "function arguments".

FWIW I also learned "formals" in school but have tended to use "parameter" and "argument" in my writing for at least the last decade or so because that seems (anecdotally) to be the current familiar jargon across various different language specs and tutorials.
It is unfortunate that in plain English "parameter" and "argument" are not clearly differentiated in the way that is intended in this context, but that seems to be a common characteristic of plain words adopted as jargon. The dictionary tells me that "formal" as a noun means "an evening gown" and that "actual" isn't a noun at all, so those words don't seem to be obviously better cognates. I think it's beneficial to go with the flow here and use terms that people are likely to have encountered in other languages and in tutorials. (even though this sort of jargon evolution does make me notice my age.)

Interestingly, one of the first tutorials I found when looking for examples -- the "Functions" section of A Tour Of Go -- seems at first read to be using these terms without defining them and switching somewhat carelessly from one to the other without explaining their relationship:

A function can take zero or more arguments.
In this example, add takes two parameters of type int.

As a reader who already knows the common meanings of "arguments" vs. "parameters" I probably wouldn't noticed this if I wasn't explicitly looking for examples. Perhaps what we can learn from this example is that the terms "argument" and "parameters" are so familiar to programming language learners that explicit definition and distinguishing remarks felt unnecessary here. (I'm assuming that a non-trivial number of people have successfully learned Go in part by following this tour.)

Seems about the same difference between variables and values to me.
Parameter is to variable what argument is to value.

Happy to switch this proposal to TypeArgument, TypeArg or even TypeActual. What do people prefer?
Does the proposal otherwise sound reasonable?

It should probably be
NumTypeArg() int
TypeArg(i int) Type

I've changed this proposal to use TypeArg for now. That seems reasonable. Happy to change to a different naming if people prefers otherwise.

@aaronc NumTypeArgs should be NumTypeArg to match the rest of the relect.Type methods.

@aaronc NumTypeArgs should be NumTypeArg to match the rest of the relect.Type methods.

Updated

Note that if you have a local defined type declared within a type-parameterized function, then that function's type parameters are also implicit type parameters of the defined type.
For example:
func F[X any]() any {
    type T int
    return T(0)
}

then F[X].T is implicitly parameterized by X.

Is there any chance this issue will be revisited?

@jonbodner This proposal remains on the incoming queue.


Seeking Clarification on prepare_redpajama.py

Hi,
Actually, I'm relatively new to the world of NLP, and I've been exploring prepare_redpajama.py.
I've noticed a configuration on Line 144 : checkpoint_dir: Path = Path("checkpoints/stabilityai/stablelm-base-alpha-3b").
I'm wondering why this particular checkpoint (3b) is being used? especially that the pretraining code is specifying a different directory (7b) : --checkpoint_dir checkpoints/meta-llama/Llama-2-7b-hf/
I would like to know if it is acceptable to mix weights of different sizes, such as 3b and 7b?
looking forward to your guidance!

Hi there, these are good questions. So the model you are seeing there as checkpoint_dir is just the one used be default if a user doesn't specify which one they want to use -- I suppose we defaulted to the 3B one here because it's reasonably small to run on most hardware but big enough to get some good results.
Regarding the mixing ... it's recommended to call the prepare_* scripts for each type of model you are using since the tokenizer might be different. If you use a 7B and 70B model from the same model family like Llama 2, I suppose it should be fine if you don't prepare the dataset again via this script, but I'd say it's just a good practice to reprepare it. You can save the prepared datasets to different folders so that you can reuse them later if you are switching between models.
There's also a bit more info here if useful: https://github.com/Lightning-AI/lit-gpt/blob/main/tutorials/prepare_dataset.md

I think this can be closed, but let me know if you have any follow-up questions!


Exchange permissions are not set correctly

Hi,
when deploying an Exchange 2013 CU 13 DAG (2 nodes), the permissions for the NMMBackupUser are not set correctly. I don't know which permission is missing, but the NMM Exchange Admin Configuration Tool fixed it (I'm loving this tool :)).
Just run the tool on both nodes -> Configure Admin User -> Configure existing user -> enter nmmbackupuser and it will set all necessary permissions.
Unfortunately, it does not display which permission is missing when running the check.
Marcel

Running labbuildr version 2016-3rd Anniversary on branch : master

marcel, they removed the cli tool do do so from the beta. this is a manual task to do unfortunately, as som stuff is stored in the local registry :-(


Nested-closure totally messed up

try compiling this
main: func{
    a : Int = 1
    b := func{
        a = 2
        c := func{
            a = 3
            d := func{
                a = 4
            }
            d()
        }
        c()
    }

    b()

    if(a != 4) Exception new("%d vs 4" format(a)) throw()
}

In fact I can not understand the current variable collection flow of closure.
We are searching in travis, and add each undefined variable to the functiondecl in travis. This clearly generates unexisting vardecl.

fixed


Convert Resnet100 from MxNet to Caffe

Platform (like ubuntu 16.04/win10): ubuntu 16.04
Python version: 2.7
Source framework with version (like Tensorflow 1.4.1 with GPU):MxNet 1.2.0
Destination framework with version (like CNTK 2.3 with GPU):
Pre-trained model path (webpath or webdisk path):
Running scripts:
I ran this command to convert my mxnet model to IR model:
python -m mmdnn.conversion._script.convertToIR -f mxnet -n /home/sll/zl/resnet-100-symbol.json -w /home/sll/zl/resnet-100-0197.params -d resnet100 --inputShape 3 112 112
This is the error trace I got.
[10:01:07] src/nnvm/legacy_json_util.cc:209: Loading symbol saved by previous version v1.1.0. Attempting to upgrade...
[10:01:07] src/nnvm/legacy_json_util.cc:217: Symbol successfully upgraded!
Warning: MXNet Parser has not supported operator one_hot with name one_hot0.
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/_script/convertToIR.py", line 186, in
_main()
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/_script/convertToIR.py", line 181, in _main
ret = _convert(args)
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/_script/convertToIR.py", line 99, in _convert
parser.run(args.dstPath)
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/common/DataStructure/parser.py", line 22, in run
self.gen_IR()
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/mxnet/mxnet_parser.py", line 265, in gen_IR
self.rename_UNKNOWN(current_node)
File "/home/sll/.local/lib/python2.7/site-packages/mmdnn/conversion/mxnet/mxnet_parser.py", line 377, in rename_UNKNOWN
raise NotImplementedError()
NotImplementedError

Hi @321zhangli123. One_hot is always used in the preprocess. MMdnn can only convert the architecture of a network, so the preprocess is skipped. Can you remove the preprocess part?

I have met this problem, have you solved this?

Hi @xuguozhi ,One_hot is always used in the preprocess. MMdnn can only convert the architecture of a network, so the preprocess is skipped. Can you remove the preprocess part?


nginxModules.vod: 1.31 -> 1.32 and patch MAX_CLIPS

Description of changes
Changelog 1.31 -> 1.32
The change with MAX_CLIPS is necessary because the default limit is quite small and breaks some applications. For example Frigate also patches the file before compiling their own nginx: build_nginx.sh#L31
And according to the upstream of nginx-vod, one should just patch this themself when a bigger value is needed.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Maybe put the reasoning into the commit message, so it isn't lost on GitHub at some point.


Fix link to getting started doc

Thanks!  That said, we really ought to point the README to the new docs site instead :)


Use Curve255719 for this Encryption

Hello, look like this Encryptions Algorithm use NIST curve. As I known, in 2013, Bernstein was discovered that the NSA had potentially implemented a backdoor into the P-256 curve based Dual_EC_DRBG algorithm. So I think Curve255719 is better to use on SIDH

Nope, it doesn't.


✨ Update package categories format in pyosmet update workflow to produce a better packages.yml file [Python programming]

Currently, the workflow in this repo will create an output file called packages.yml that is a data file.
This data file drives our websites packages listing here. . The data file template for a single package is below.
Output packages.yml file currently looks something like this (NOTE that i've edited the categories format manually - a separate issue to be opened):
Note in the yaml file below the categories often have two works with a space in between Data munging and sometimes there are capital letters. However for the website we need the categories to be lower case and using dashes rather than spaces. data-munging. I've been updating this manually but we should just update the code to fix the category style returned in the packages.yml file.
- package_name: xclim
  package_description: Climate indices computation package based on Xarray
  submitting_author:
      name: Trevor James Smith
      github_username: Zeitsperre
  repository_link: https://github.com/Ouranosinc/xclim
  version_submitted: v0.40.0
  categories:
    - Data munging
    - Reproducibility
    - Geospatial

✋ I would like to work on this one.

closing this now in favor of #20


Maps to comma don't work

Hey,
It's some time since I've used Obsidian, and I appreciate the work you've put into this plugin since then! However, I have a bug where mappings to comma don't work, such as
map , o
or
noremap , i
Is this easily fixed?

Same with these:
nmap k <C-d> nmap . <C-u>
In the inspector Console tab, there are no error messages. When using the commands manually, they work. Is it possible that these mappings are being overwritten by a later mapping?

This is hopefully fixed in 0.5.2 which I just released, can you upgrade and verify?

Hey esm7, I updated to 0.5.2 and sadly none of the issues have been resolved

This is strange, all of these mappings work for me.

Could it be that the plugin doesn't work for you at all? Do you have other mappings in your Vimrc that do work?
Are you using the Obsidian legacy editor or the new one?
Can you screenshot your plugin configuration page or attach the settings json file?
Which version of Obsidian?
Although you already noted you see no errors in the console tab, can you screenshot or copy it so I can see the other (non-error logs?

I have a large number of mappings in my vimrc and most do work!
I tried both legacy and non-legacy and I still run into the issue on both.
Here's the config file under ~/obsidian/.obsidian/config:

{"pluginEnabledStatus":{"file-explorer":true,"global-search":true,"switcher":true,"graph":true,"backlink":true,"command-palette":true,"markdown-importer":true,"word-count":true,"open-with-default-app":true,"file-recovery":true},"promptDelete":false,"enabledPlugins":["obsidian-vimrc-support"],"vimMode":true,"hotkeys":{"editor:toggle-fold":[{"modifiers":["Mod"],"key":"T"}],"editor:insert-link":[{"modifiers":["Mod"],"key":"Y"}],"command-palette:open":[{"modifiers":["Mod"],"key":"'"}]},"theme":"moonstone"}

I'm using version 0.13.19 (the latest one)
It's empty, but here's what it looks like after trying the keys I tried to map to.

Also, here's my ~/obsidian/.obsidian.vimrc:
nmap , o
nmap a j
nmap e k
nmap i h
nmap o l
nmap j ;
nmap r i
nmap l e
nmap L E
nmap H B
nmap h b
nmap n a
nmap N A
nmap t w
nmap T W
nmap w ^
nmap ; $
nmap b t
nmap R I
nmap B T
nmap j n
nmap < O
nmap <C-,> <
nmap <C-.> >
nmap Y y$n
nmap D d$
nmap C c$
nmap Q @
nmap = .
nmap <C-j> J
nmap J N
nmap P ^
nmap <BS> x
nmap m ge
nmap M gE
nmap + .
nmap = %
nmap _ >
nmap - <
nmap <C--> <C-x>
nmap <C-=> <C-a>
nmap <M-,> <C-o>
nmap <C-M-,> <C-i>
nmap <C-;> A
nmap k <C-d>
nmap . <C-u>

Reset my vault and found it worked- my vimrc was likely placed in the wrong location!


[bugfix] Fix inconsistency in release name for template rendering during lint

What this PR does / why we need it:
Right now, we have some Helm charts that include a little template function to validate that a resource name (being the result of several different computed values from different places) looks like we expect it to.
Recently, we found out that if that resource name contains $.Release.Name, then when our template tries to validate it during a helm lint run, it always fails no matter what we set our expected name to. A simplified example follows
Our template looks like this:
{{- $name = printf "%s-%s-%s" $.Release.Name $.Values.thing $.Values.stuff -}}
{{- if ne $name $.Values.expectedName -}}
  {{- fail (printf "expected name: %s; got: %s" $.Values.expectedName $name) -}}
{{- end -}}

Our values file looks like this:
thing: brandon
stuff: willett
expectedName: test-release-brandon-willett

Then a call to helm lint always fails with this error:
fail: expected name: test-release-brandon-willett; got: RELEASE-NAME-brandon-willett

But then when we change expectedName to RELEASE-NAME in the values file, it flips and still errors:
fail: expected name: RELEASE-NAME-brandon-willett; got: test-release-brandon-willett

Hunted around in your code for a bit and it seems to stem from an inconsistency between these two template renderings:
https://github.com/helm/helm/blob/main/pkg/lint/rules/template.go#L69
https://github.com/helm/helm/blob/main/cmd/helm/template.go#L68
So, this PR tries to patch the inconsistency. Let me know if this is an acceptable fix, thanks!
Special notes for your reviewer:
(none)

Hi @brandon-dd. Sorry for not getting back to this sooner. Looks like this slipped through the cracks. Sorry!
Can you please address the failing tests? It looks like the tests expected the prior release name, so I am concerned that changing the name will inadvertently affect something or someone.

ping.

closing as abandoned


<Redirect/> is not documented

This is about:

Undocumented code

Problem
The <Redirect/> element is not mentioned at all in the router section: https://yew.rs/next/concepts/router
Questionaire (Optional)

I'd like to write this documentation

Feel free to PR this documentation!


fix(chat): fix last message check (Issue #910)

Description:
Fix last message check
Issues:

https://github.com/epam/ai-dial-chat/issues/910

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review


Minimap

Description
Implement the Minimap. This works by taking the NSAttributedString from the STTextView, doing some parsing, and displaying it in a ZStack with a ton of offsets and frames.
Not implemented in this PR:

Moving to a line when clicking on the minimap
Not having the minimap overlap with the text (@wdg help)
Reported cursor position varies from line number in STTextView (#230) fixed in #232

Related Issue

#42
#122
#208

Checklist

[x] Scrolling the minimap when the STTextView is scrolled
[ ] Cache some minimap results to avoid very bad lag

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[ ] Review requested

Screenshots

Converting this PR to a draft since there are ongoing conversations about changing the text view.


ChromeApp: Missing files

I was trying to setup ChromeApp but I think there is some issue with files.
In "index.html"
one JS file is referred that is "scripts/readium-js-viewer_all_CHROMEAPP.js" but there is no such file and "scripts" folder.
Favicon icons referred from "images" folder but there is no such folder exists.
CSS files referred from the folder "CSS" but the folder doesn't exist.
There is one more entry in the manifest.json "default_locale" : "en_US", but no _locale folder exists.
I have cloned the repository from "https://github.com/readium/readium-js-viewer.git".
I am using Chrome Dev Editor.
It would be great if someone can guide me to setup ChromeApp.

Please follow the build instructions in https://github.com/readium/readium-js-viewer/blob/develop/README.md
(I think you are looking at the raw code, you need to compile the app first)


Fix overlap & scroll in short windows

On certain window resolutions, a scrollbar appears when it's not needed.

On certain shorter window resolutions, there is text overlap.

@galactic-src This was my bad. I'm glad to fix it unless you want to. It's my fault! Just putting it in here so we don't forget.

hi, is someone assigned to this? i can help

I think it's .home {flex; align-items: center} causing overflow.
I thought of a couple of ways forward:

keep it vertically centered and hide the overflow, and show a scrollbar
keep the content at the top of the page with {align-items: flex-start} (I guess the page might look a bit empty for larger sizes)
or the behaviour could change depending how tall the screen is using a media query (but then we need to remember to test at the breakpoint in future)

@crunchydosa123 your help would be much appreciated, go for it!
You might have some better possibilities to add
@hayleyw7 any preference?


Pageserver start/init and config

Ansible script to init pageserver and systemd unit to run pageserver now looks like that (ops/pageserver/pageserver.yml in console repo):
  - name: init pageserver
    shell:
      cmd: |
        sudo -u pageserver {{ansible_env.HOME}}/zenith/target/debug/pageserver --init --workdir /var/db/pageserver
    args:
      chdir: "{{ansible_env.HOME}}/zenith"
      creates: "/var/db/pageserver/timelines"
    environment:
      ZENITH_REPO_DIR: "/var/db/pageserver"
      POSTGRES_DISTRIB_DIR: "{{ansible_env.HOME}}/zenith/tmp_install/"
      PATH: "{{ansible_env.HOME}}/zenith/tmp_install/bin/:{{ ansible_env.PATH }}"
      LD_LIBRARY_PATH: "{{ansible_env.HOME}}/zenith/tmp_install/lib/"
    become: true

  - name: create systemd service
    copy:
      dest: "/etc/systemd/system/pageserver.service"
      content: |
        [Unit]
        Description=Zenith pageserver

        [Service]
        Type=simple
        User=pageserver
        Environment=ZENITH_REPO_DIR=/var/db/pageserver POSTGRES_DISTRIB_DIR={{ansible_env.HOME}}/zenith/tmp_install/ PATH={{ansible_env.HOME}}/zenith/tmp_install/bin/ LD_LIBRARY_PATH={{ansible_env.HOME}}/zenith/tmp_install/lib/
        ExecStart={{ansible_env.HOME}}/zenith/target/debug/pageserver -l <IP_ADDRESS>:6400
        ExecReload=/bin/kill -HUP $MAINPID
        KillMode=mixed
        KillSignal=SIGINT
        TimeoutSec=0

        [Install]
        WantedBy=multi-user.target

Some problematic areas:

PATH and LD_LIBRARY_PATH are not actually needed -- we may set them to POSTGRES_DISTRIB_DIR/bin and POSTGRES_DISTRIB_DIR/lib correspondingly when launching wal-redo postgres.
mix of env vars and cli keys during init
necessity to set env variables during usual start

I suggest to change this to following:

Init creates necessary data directories and pageserver.toml inside workdir. Workdir is required param. Each config option can be overridden by optional key. Like that:

// creates pageserver.toml and necessary subdirs in /my/path. POSTGRES_DISTRIB_DIR
// would be set to some default value (/usr/local/wal-redo-postgres?) as well as host:port
pageserver init --workdir /my/path

 // same, but in current directory
pageserver init --workdir .

// override default config values
pageserver init --workdir .  --postgres-distrib /path/to/pg --listen-address <IP_ADDRESS>:1234

Pageserver run requires only --workdir and read all the stuff from pageserver.toml:

pageserver run --workdir /my/path
pageserver run --workdir /my/path --daemonize

(opinion or other suggestions are welcomed)

On a second thought, it seems quite weird to require 'run' keyword. Original idea was that we can allow all config-overwriting keys (--postgres-distrib, --listen-address, ...) only for init and keep run keyword clean. However, it is also handy sometimes to force running with some config option set in cli without editing config file. So what about following:
// init and set specified keys to config
pageserver --workdir .  --init  --postgres-distrib /path/to/pg --listen-address <IP_ADDRESS>:1234

// run pageserverver and override listen-address (cli key priority higher than config file entry)
pageserver --workdir .  --listen-address <IP_ADDRESS>:1234

IMO looks slightly cleaner than previous suggestion. It also would be handy to set workdir to '.' by default.

Closing with #261


perhaps a settings option in editr for no show grid

me moderates these issues so me no need use gud grammer

ah forget this its so useless anyways


Add Sketch topic

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[ ] Suggesting edits to an existing Topic page
[x] Curating a new Topic page

EDITING AN EXISTING TOPIC PAGE
I'm suggesting these edits to an existing topic:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

Please explain why these changes are necessary:
CURATING A NEW TOPIC PAGE

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:
Sketch is an extremely popular tool in the user interface design community. Sketch users primarily use GitHub to share and work on Sketch plugins.

Congrats on being the first merged community-curated topic! 💟 ✨

Thanks @max !!

This topic is now live on GitHub https://github.com/topics/sketch thanks again! 🎉


Update retention-cmdlets.md

Fixed links in table that went to the wrong cmdlet resource pages  Adjusted wording in the top section to be a little more clear that retention policies need rules. Updated some descriptions in the table to be a little more user-friendly and removed types

Learn Build status updates of commit a5a8e75:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/retention-cmdlets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 80c8e7e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/retention-cmdlets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Fixed issues, merging


Add license 1

added Original answer since the returned answer was of lower case

Can you please revert the changes?
I think just word.capitalize() would do and no need to make any changes as you submitted.

I am absolutely sorry.
I am kind of new to this
That's why I messed it up
I will delete and revert the changes.
Regards,
Aravind
On Thu, Feb 11, 2021, 11:08 PM Ramsri Goutham Golla <
<EMAIL_ADDRESS>wrote:

Can you please revert the changes?
I think just word.capitalize() would do and no need to make any changes as
you submitted.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ramsrigouthamg/Questgen.ai/pull/13#issuecomment-777666657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIRZVR6LP2777TVPCVQINZ3S6QIXXANCNFSM4XLSGVCQ
.

@aravind-812
No worries! Just letting you know that string capitalize will do the job.
https://www.w3schools.com/python/ref_string_capitalize.asp


iOS example app does not seem to work

When I run the app from the example folder on https://github.com/KasemJaffer/receive_sharing_intent/tree/master/example on iOS it does not seem to work.
When sharing an image:

You see the app in the list

Then for a split second you see this window pop up

Then nothing happens

I tested this on an iPhone 15 Pro Max emulator running iOS 17.4

me to 😢
I tested this on an iPhone 14 Pro actual machine

me to
Any new developments?

me to 😢
I checked again and again to see what I might have done wrong. Has anyone found a solution?

My biggest concern at the moment is reliability of this feature / package. It has been 2 weeks without reply to this issue. I am holding back to use this package for now. If I use this in production and it breaks, I do not want to risk to have a broken feature for weeks.

I managed to get it to work. While the package publisher could have provided clearer instructions, it's important to understand some key points when adding packages to your application. After trying many forked versions of this package and examining the package codes, I've gained full experience with it. The issue is actually quite simple. Here are the key steps:
Pay attention to the Info.plist files. Insert the required codes correctly.
Provide the host and extension IDs in the correct format.
After filling in the ShareViewController content, be sure to run pod install in the iOS directory before running the application.
Follow the cycle described by the publisher carefully.
If you are not using custom IDs, fill them in manually in the Info.plist table.
The original package works fine and is more compact than other packages. It also has a supportive community.
I hope this helps others who are facing similar issues.

@olerhan did you make it work for the newest version or versions prior 1.6.0 ?

For me what made it work is filling the custom IDs manually for the Runner and Share Extension under Build Settings, what @olerhan suggested above.

for me what made it work is adding the custom IDs manually for both Runner and Sharing Extension under Build Settings, what @olerhan suggested above.

Same here. I cloned the example and it doesn't work for iOS either. The app doesn't receive the shared files. Confirmed on iOS 17.5 simulator.

I think the issue is not caused by the configuration, but by this:

#294

For me everything still works fine. Everyone just needs to be more careful about using the package. This issue (296 or 294) is not a real issue…

For me everything still works fine. Everyone just needs to be more careful about using the package. This issue (296 or 294) is not a real issue…

hey, can u provide the ShareViewController.swift?


[feature request] ability to display the values in the network module in bytes/megabytes per second

If you mean using bytes as an alternative to using octets as the unit/symbol e.g. 25MB/s instead of 25Mo/s, then I would be interested in adding it.

@excellentname waybar currently displays it in Mbit/s by default, but I would like it to display it in MB/s instead of Mbit/s.
Example: instead of displaying 100Mbit/s...in MB/s it should be 12,5 MB/s.

@jdbm8992 I assume you're talking about the {bandwidthDownBits}/{bandwidthUpBits} format replacements?

@excellentname yeah exaclty

@jdbm8992 so you can use {bandwidthDownOctets}/{bandwidthUpOctets} which is the same thing as bytes per second but the symbol will be 'o/s' not 'B/s'. So to use your example, {bandwidthDownBits} would give 100Mb/s and {bandwidthDownOctets} would give 12.5Mo/s.
Currently there is no way to use 'B/s', but I would like to add an option or something to be able to use 'B/s' instead of 'o/s'. I hope that made sense.

@excellentname I've changed it now and now it's showing in octets. Should I close the issue?


Object.defineProperty doesn't define properties on 'this'

// @ts-check

class C {
  constructor() {
    Object.defineProperty(this, "x", { value: "hello" });

    this.x.toLowerCase();
  }
}

Expected: No error.
Actual: Property 'x' does not exist on type 'C'.

Unfortunately it doesn't work in TS as well,
if you run this in TS playground (I guess it has the latest TS version)
let obj = {};
Object.defineProperty(obj, "x", { value: "hello", writable: false });

obj.x.toLowercase();

then it will show only one error message:
"Property 'x' does not exist on type '{}'"
but I expected to get different error like "Property 'toLowercase' does not exist on type 'string'" as was described in https://devblogs.microsoft.com/typescript/announcing-typescript-3-2/#objectdefineproperty-declarations-in-javascript

@DanielRosenwasser  See https://github.com/Microsoft/TypeScript/issues/14650

@tokland This is about JavaScript analysis, not TypeScript.

I'm running in to this one.  Anyone know of a workaround?

n/m, workaround for above is something like this:
// @ts-check

class C {
  constructor() {
    /** @type {Readonly<string>} */
    this.x = undefined;
    Object.defineProperty(this, "x", { value: "hello" });

    this.x.toLowerCase();
  }
}

You need to add definite assertion assignment to property 'x: string'.
class C {
  x!: string;  // definite assertion
  constructor() {
    Object.defineProperty(this, 'x', {value: 'hello'});
    this.x.toLowerCase();
  }
}

@akornatskyy I think the source is assumed to be JavaScript in this issue and there is no definite assignment assertion syntax there as far as I can tell.


Linux Kernel Sockets

Adding Linux Kernel Sockets to this LKM rootkit, so that this rootkit acts as an all-rounder. Both, as a LKM rootkit as well as stealthy C2 Server.

posting here as well, just to make sure it comes across - what do you specifically want kernel sockets to achieve? :)
https://github.com/reveng007/reveng_rtkit/issues/11#issue-1559846247

Sorry for being vague.
Actually that would be C2 client, so that our C2 server listening on target gets automatically connected to the lkm whether it comes online.
Does this sound familiar now?

Yes I think that makes sense now, (+1 for mentioning the revshell ) thanks! if I have more questions I'll ask.


fix: fedavg algo

The previous global weights were not reset before new global weights
are computed in each round. This caused loss value increase over
rounds. This error is fixed.

lgtm


fix(script): Enabling core dump for ndm daemon-set (cherry-pick #219)

when env GOTRACE was used, the ndm daemon set was not receiving the environment variable. Now we export the variable so that it is set in the environment where ndm daemon-set binary is run.
cherry-pick #219

Codecov Report

Merging #226 into v0.3.x will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           v0.3.x    #226      +/-   ##
=========================================
+ Coverage   50.76%   51.1%   +0.33%
=========================================
  Files          43      43
  Lines        1769    1769
=========================================
+ Hits          898     904       +6
+ Misses        804     800       -4
+ Partials       67      65       -2

Impacted Files
Coverage Δ

cmd/probe/eventhandler.go
46.93% <0%> (+12.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caaa512...1311881. Read the comment docs.


[BUG] Rectangular mounts not calculated constrained movement of riders correctly

Module Version: MountUP: v3.2.24, TA: 4.4.5, TokenZ: 0.6.5, LibWrapper 0.8.0
Describe the bug
When a rider is smaller in grid units than a mount, there is a wonderful feature that allows constrained movement on the mount itself.
There is a bug when a mount in not a square grid shape, where if the mount is rotated, the constrained movement is allowed in the original shape of the token and not the rotated state.
To Reproduce
Steps to reproduce the behavior:

Create an actor token "the mount" whose grid shape is 3x5 [i used a vehicle actor in PF2E system, and then set the length to 25 and the width to 15 (in this case a BOAT)].  NOTE: as far as I know FoundryVTT will never let you make a token that does not have a rectangular shape.. this bug is just referencing when a shape is rectangular, but not square.
Create an actor token "the rider" whose gride shape is 1x1 [i used a player character in PF2E system who was size medium]
Get both tokens onto a scene
Mount up the Rider to the Mount via MountUp module
Move the rider around the 3x5 mount and everything works as expected.
Move the rider to the top right corner grid on the mount (x=1,y=1 of the mount)
Rotate the mount 90 degrees, causing the mount to have a shape that is 5x3 [at least visually]
(Mount up and Token Attacher work wonderfully calculating where the rider should be)
now move the rider around the mount (you will notice that it can only be moved to areas represented by the original shape and you cannot move it back to the location it started at when step 8 began)

Expected behavior
The constrained movement grid should match the new shape of "The Mount"
it would be great if the grid would calculate on 0, 45, 90,135 (and all of their mirrors 0 is the same as 180, 45 is the same as 225, 90 is the same as 270, 135 is the same as 315) to determine where the rider can go on the mount,   (where 0 represents any rotation from 338.01 to 23 degrees (338.01-359.99 and 0-23), 45 represents any rotation from 23.01 to 68 degrees, 90 represents any rotation from 68.01 to 113, and 135 represents any rotation from 113.01 to 158 ... etc)
BUT if calculating the appropriate grid would be overly complicated at non-right angles, then it would still be beneficial if the grid was calculated

as "Normal" when the mount rotation is between 315-45 (315-359.99 or 0-45) or 135-225,
or calculated it as "Turned Sideways" when not (causing the grid that the rider can move around in to be the shape of Y,X of the mounts grid units)

Screenshots
If applicable, add screenshots to help explain your problem.
Browser:
M$ Edgium 103.0.1264.44
Foundry Version:
9.269
Game System:
PF2e <IP_ADDRESS>
Additional context
Add any other context (like other modules installed) about the problem here.

THIS MODULES IS DEPRECATED ON V11 IN FAVOR OF Rideable


PREFIX does not change the installation path

run make install PREFIX=../../build/LSOracle I find that it is trying to install to the hardcoded path of /usr/local/bin/lsoracle

User error; this can be closed.


⚠ Bofrost.at has degraded performance

In b8982e5, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2301 ms

Resolved: Bofrost.at performance has improved in 2370649 after 20 minutes.