Added -4 -6 Switches and default tcp46 fixes #13

See #13 for more information
As *BSD defaults to use IPv6 only sockets and Linux to IPv4 mapped IPv6
sockets, switches to support explicit binding address families are required.
Now set explicitly if you want IPv6 only, IPv4 only or mapped IPv4.
Caveat:
OpenBSD explicitly states to not support IPv4 mapped IPv6 via setsock-API
Discussions needed:

Configuration Naming okay?
Is a specific ipv4 mapped ipv6 switch needed?
Default to IPv6Only to be compliant with OpenBSD?
Has Solaris IPV6_V6ONLY sockopt?

Reasoning

First I've come up with
Didn't include one as other software also doesn't do this and would complicate option parsing further
Normally you want to listen on v4 v6 anyway, was default behaviour in previous version.
Doing A on Linux and B on *BSD as default would complicate code and UX.
{Net,Open,Free}-BSD has it, Illumos has it, chances are high

Tested on Arch Linux (Linux 5.0.5), Ubuntu 18.{04,10}, Ubuntu 16.04 and FreeBSD 12 (fresh VM install)

Thanks, you did this beautifully! This is the sort of PR I love to get.

The configuration naming looks good.

You mean something like a "-0" switch? I'm fine with this being a
silent default and not an explicit option.

Yeah, I think that's fine. As you noted, this is what was already
happening anyway.

It does, but none of the standard feature test macros expose it, so
it requires -D__EXTENSIONS__. I've noted this in README.


Fix types ordering

Fixes #869

@mcollina, we should also order a ts union/enum types.
declare interface Foo {
    id?: string;
    status: "attached" | "detached" | "destroyed"; // <- this one also always changes the order
}

@ivan-tymoshenko I'll fix in https://github.com/platformatic/platformatic/pull/871.
Is this good to go otherwise?


feat(vnets) add a subnet for ci.jenkins.io controller in the sponsored subscription

Ref. https://github.com/jenkins-infra/helpdesk/issues/3908#issuecomment-1892555342
This PR adds a dedicated subnet for ci.jenkins.io controller in the new subscription

(note the IP change is because I've updated my public IP as I'm in the train: no problem to have terraform rollback my manual change)!


JSON Type not allowed on application schema

Currently when I set the field type to Json in the application schema I get Error: Field rules: Couldn't find type Json. However this type works in the database schema

You should be able to add scalar Json to your final schema, but I'm not sure how to add the corresponding resolver.

@davidyin1212 is this still an issue for you or was this solved by the newest version?


Is there a way to prevent the user from scrolling through previous months?

I only want the user to be able to scroll / view dates in future months, not previous months. Do you have any suggestions ?

sorry, didn't notice the DataSource methods that cover this. Please add to the README.md when you can !

Readme.md had metioned this, read it with care:


Rasterization miscolors disabled components on Safari

Discovered in https://github.com/phetsims/wave-interference/issues/514.  Brief summary: when using Node.rasterized or the PhET Menu => Screenshot button, the disabled stopwatch rewind button is much darker.  Note: this happens on Mac/Safari but not Mac/Chrome.
In this screenshot, the top is the live sim and the bottom is the screenshot.  Please ignore the yellow highlight:

If the problem were just this sim, I wouldn't say it is a blocking problem (for Waves Intro context).  It's not a usability problem or buggy. However, I recommend we mark as high-priority or blocking until we better understand the scope and cause.
@jonathanolson can you please take the lead?  Feel free to adjust the priority as you recommend.

I'm curious about whether this is a new-Safari thing, I swear I had tested Safari for filter color issues previously.
scenery/tests/filter-tests.html shows a comparison of filter handling for different configurations, for instance in Chrome:

Note the darker Canvas "filter" columns, which appear that way now because we're using that for performance in https://github.com/phetsims/scenery/issues/1139.
However now Safari 14.0.2 is showing:

I'm curious about whether this is a new-Safari thing, I swear I had tested Safari for filter color issues previously.
scenery/tests/filter-tests.html shows a comparison of filter handling for different configurations, for instance in Chrome:

Note the darker Canvas "filter" columns, which appear that way now because we're using that for performance in https://github.com/phetsims/scenery/issues/1139.
However now Safari 14.0.2 is showing:

So it seems specifically that a DOM CSS filter on an element that contains SVG and Canvas content will behave differently than a DOM CSS filter that just has SVG content.

So it seems specifically that a DOM CSS filter on an element that contains SVG and Canvas content will behave differently than a DOM CSS filter that just has SVG content.

In phet-io meeting we decided that this isn't a blocking issue. Before we close as wontfix, we should collect more examples of this issue to make sure they are all as minor as the rewind button in the StopwatchNode.
@KatieWoe when please be on the lookout for issue in Safari in all QA tests. I'll go ahead and add this issue to the open QA issues.

In phet-io meeting we decided that this isn't a blocking issue. Before we close as wontfix, we should collect more examples of this issue to make sure they are all as minor as the rewind button in the StopwatchNode.
@KatieWoe when please be on the lookout for issue in Safari in all QA tests. I'll go ahead and add this issue to the open QA issues.

Here's another example with the rewind button in https://github.com/phetsims/QA/issues/599
This is from just taking a selection of my screen with my Mac

This is from using the actual screenshot button within the simulation

Here's another example with the rewind button in https://github.com/phetsims/QA/issues/599
This is from just taking a selection of my screen with my Mac

This is from using the actual screenshot button within the simulation

I test this for https://github.com/phetsims/QA/issues/596 (Atomic Interactions) but I wasn't able to produce the same result
This is a pic from the live sim

This is screenshot from my Mac

Besides the live sim screenshot being a little grainy, the disabled buttons appear to be the same color for both.

I test this for https://github.com/phetsims/QA/issues/596 (Atomic Interactions) but I wasn't able to produce the same result
This is a pic from the live sim

This is screenshot from my Mac

Besides the live sim screenshot being a little grainy, the disabled buttons appear to be the same color for both.

Second example from https://github.com/phetsims/QA/issues/599.

Second example from https://github.com/phetsims/QA/issues/599.

Seen in https://github.com/phetsims/QA/issues/600, but nothing alarming yet

Seen in https://github.com/phetsims/QA/issues/600, but nothing alarming yet

Just noting that this is still an issue with mac + safari. I'm currently using macOS 12.3.1 and safari 15.4

Seen in https://github.com/phetsims/qa/issues/823.


Shortfin LLM CI Fails on export after IREE nightly 1227

Shortfin LLM CI fails in sharktank.examples.export_paged_llm_v1 with error:
TypeError: get(): incompatible function arguments
Supported: get(value: str, context: mlir.ir.Context | None = None) -> iree.compiler._mlir_libs._mlir.ir.FlatSymbolRefAttr

when
            iree-base-compiler==3.1.0rc20241227 \
            iree-base-runtime==3.1.0rc20241227 \
            iree-turbine==3.1.0rc20241227

@nithinsubbiah mentions in slack that this issue also seems to affect SDXL export functionality
To resolve this:

Pin IREE to version 1226 temporarily
Address IREE 1227 compatibility issue

This is likely due to iree-org/iree and not iree-turbine: iree-turbine has not been committed to between Dec 20 and Dec 30. IREE had a llvm version bump on Dec 26

Slack thread: https://xilinx.slack.com/archives/C077FDT0002/p1735374494332789?thread_ts=1735374062.079439&cid=C077FDT0002

https://github.com/nod-ai/shark-ai/actions/runs/12550021461?pr=730
Pinning the iree-base-compiler, iree-base-runtime, and iree-turbine verisons to 1226 fixes the export failure but the server still fails to start.
Also, almost all of the sharktank tests fails when i do this.


Values not passed properly while executing Users#PUT with swagger

Describe the bug
Instead of userId provided in endpoint params in Swagger UI, '0' is used.
To Reproduce
Steps to reproduce the behavior:

Authenticate to swagger-ui as administrator
Execute User#PUT

Expected behavior
Request should pass without any error
Observed behavior
Error of Could not find object of type 'USER' with business key '0'" is returned
Screenshots

Additional context
N/A

Closed in https://github.com/servicecatalog/oscm-rest-api/pull/178


Add "Sign up with Google" button

💻 Environment
Platform: macOS/Windows/Linux
📒 Description
Add "Sign up with Google" button below the Sign up" button.
"Select Country" should be a required field and "I agree to terms of service and privacy policy" should be checked. E-mail and password fields are not used.
⭐ Why do you want this?
We should allow our users to sign up with Google directly from the desktop app.

macOS and Linux part moved to #3278 and #3279.


PostgreSQL - SET DATESTYLE crashes connection

Description
DBeaver 22.3.4
Steps to reproduce:

Connect to PostgreSQL database
Open a new sql editor
Execute the command: SET DATESTYLE = 'german'

Now the editor looses connection and tries to invalidate connection again and again.
DBeaver Version
22.3.4
Operating System
Mac
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Thank you for bug report

@JamesInform Hi, it is similar to https://github.com/dbeaver/dbeaver/issues/4244, and looks like the driver issue. Which driver version is used?

@JamesInform Looked into the issue a bit deeper. Unfortunately, the driver requires ISO, which is expected behavior because it can't maintain the session with Datestyle='german'. Not sure we can do anything about it.

@Destrolaric can we detect it and do not reconnect endlessly. Also showing some message about what is happening wrong would be beneficial.

@E1izabeth Tried on the Postgre database, it stopped constantly reconnection after 30 secs.

Closing as third party issue, driver unfortunately doesn't support German Datestyle and we can't resolve this issue on the DBeaver site.


WIP - Support random uid

Initial attempt at supporting non-root user

@bparees ptal ... it's my naive first shot at running as non-root

does this work as is?  @jhadvig indicated there were problems writing the PID file, but maybe it's writing it to one of the paths you chmod'd.

it does work as is... however not ideal... because the sti build still happens as root. However, the resulting image can be run as any user

@bparees - ready for a more serious review. Made the change to rhel image and updated tests to try with a random uid. Requires https://github.com/openshift/source-to-image/pull/177

@bparees after looking at the sti-perl repo, I think a better approach is to simply comment out what we don't need from the base httpd.conf and merge the one in the contrib directory. That way I can be more consistent with both projects.

updated to use an external .sed file for common httpd.conf replacements

[test]

lgtm but would like to sort out why it seems to be failing the sti-php test build (possibly just the bad STI version issue you mentioned)

rerunning the test here:
https://ci.openshift.redhat.com/jenkins/view/Image Verification/job/sti-php/10/
hopefully that picks up the new AMI that should have your STI changes.


Anvil reading only works with certain worlds in certain places

Description
At the current state of reading Anvil, it only seems to support certain worlds with certain features, specifically ones that contain all the data for all the sections (all 16 of them). This is due to the primary bit mask currently being hard-coded as 0b1111111111111111, which indicates that every chunk section is present in the array, when in reality, this isn't always true, and assuming this defeats the point of even having that field in the first place.
Steps to reproduce

Start the server, and give it a world that contains chunks that don't have 16 sections
Join the server
See that you are completely unable to move, and that if you press F3+G, the chunk where you are supposed to be is far from where you actually are.

Expected behaviour
The primary bit mask is set correctly by calculating a mask from the amount of chunks set in the section, and so chunks that have less than 16 sections are loaded correctly
Details

Server version: Krypton 0.7
Java version: 11

Other information
N/A

I fixed this ages ago, must've forgot to close this.


Certain notification sounds doesn't play

Currently when one wants tries to play notification sounds via Personal settings -> Notifications, some sounds won't play.
Opening the static sound files produces different formats.
Bad sound
Good sound
This currently affects safari on MacOS.

CZO thread

Hey @Joelute  @alya  I would like to work on this issue. Can you assign it to me?

hey @alya @Joelute I would like to work on this issue. Can you assign it to me.


Line endings to CRLF

Currently in a bad state.

Now in a better state. Just need to make sure @SirCmpwn fixes his IDE settings now.


[Feature Request] Add todo from VPS link

When browsing the VPS for updates, it may not be a proper time for downloading assets (VPU limit reach for instance), so with right click add an automatic TODO comment with the link for download

Done in 3.9

After click on menu link, a //TODO link is inserted

Fixed with 3.9.0


Put query is failing on large json zng file

@nwt: This is related to #3881. Large JSON files shown in this issue are present in #3881.
I am using zq from main branch after #3881 is present. Unfortunately, the -version is showing unknown.
Update.zed:
over arr | switch id (
case 2 =>  put level0.level1.value:="2-changed"
default => pass
)
| merge id
| arr:=collect(this)
$ ~/go/bin/zq -I update.zed 500mb.zng | zq -Z 'over arr | id==2' -
stdio:stdin: format detection error
zeek: line 1: bad types/fields definition in zeek header
zjson: line 1: invalid character 'O' looking for beginning of value
zson: zson syntax error
zng: zngio: uncompressed length exceeds MaxSize
zng21: zng type ID out of range
csv: record on line 1023: wrong number of fields
json: invalid character 'O' looking for beginning of value
parquet: auto-detection not supported
zst: auto-detection not supported
The same issue is observed for 100MB file too. However the above query works for 10MB zng file.
10mb.zng.zip
Interestingly, cut operation like below works on 1GB zng file too.
$ ~/go/bin/zq -z -i zng 'over arr | where id==101 | cut level0.level1' 1gb.zng
Are there any commandline parameters I can tweak to make this query work on large files?

The auto-detector can't handle the large files and it's the second zq in the pipeline above causing the problem.  You can avoid the auto-detector with -i.  If you run this it should work:
~/go/bin/zq -I update.zed 500mb.zng | zq -i zng -Z 'over arr | id==2' -

We should probably improve the ZNG auto-detector...

@mccanne: With -i option, I dont see the error anymore. But I dont get any output printed on stdin from second zq.
Also, I missed to call, the latest zq binary, the second time. Fixed the query and ran this.
~/go/bin/zq -I update.zed 500mb.zng | ~/go/bin/zq -i zng -Z 'over arr | id==2' -
Can you try this at your end to see if it works for you? I see no output for all these files.
100mb
500mb
1gb

@muthu-rk: The reason you're seeing no output is because there's no records in the input files where the id field is equal to 2, so the non-output is a correct reflection of "no matches" in that == expression. The following shows the lowermost id values for each file start much higher.
$ for file in 100mb.zng 500mb.zng 1gb.zng ; do   echo "${file}:";   zq -I update.zed -i zng $file | zq -i zng -f table 'over arr | count() by id | sort id | head 5' -;   echo; done

100mb.zng:
id    count
30828 1
30829 1
30830 1
30831 1
30832 1

500mb.zng:
id     count
270834 1
270835 1
270836 1
270837 1
270838 1

1gb.zng:
id     count
570834 1
570835 1
570836 1
570837 1
570838 1

So targeting those id values should show what you seek.
$ zq -I update.zed -i zng 100mb.zng | zq -i zng -Z 'over arr | id==30828' -
{
    id: 30828,
    next: 30829,
...

@philrz: Interesting.
Could you help me understand how I get the output for below query? This suggests that value with id=2 is present in that zng file. Is my understanding correct?
$  ~/go/bin/zq  -i zng -Z 'over arr | id==2' 500mb.zng
{
    id: 2,
    next: 3,
    _id: "625664e3ea574290b931f172",
    index: 0,
    guid: "e300c649-6f2c-4a60-9b51-bc1be08d0a14",
    isActive: false,
    balance: ",764.44",
    picture: "http://placehold.it/32x32",
    age: 38,
    eyeColor: "brown",
    name: "Hart Kline",
    gender: "male",
    company: "LUNCHPAD",
    email<EMAIL_ADDRESS>    phone: "+1<PHONE_NUMBER>",
    address: "643 Clara Street, Groveville, North Carolina, 4785",
    registered: "2015-11-02T04:02:38 -06:-30",
    latitude: 82.284556,
    longitude: -53.359112,
    tags: [
        "ex",
        "duis",
        "commodo",
        "et",
        "ad",
        "voluptate",
        "cupidatat"
    ],
    friends: [
        {
            id: 0,
            name: "Bradford Shaffer"
        },
        {
            id: 1,
            name: "Monroe Kent"
        },
        {
            id: 2,
            name: "John Carey"
        }
    ],
    greeting: "Hello, Hart Kline! You have 9 unread messages.",
    favoriteFruit: "strawberry",
    level0: {
        tags: [
            1,
            2,
            3
        ],
        value: "0",
        level1: {
            tags: [
                1,
                2,
                3
            ],
            value: "1",
            level2: {
                tags: [
                    1,
                    2,
                    3
                ],
...

@muthu-rk: Indeed, it looks like there's something wrong with collect() such that it's only gathering together a subset of records into the array and your one with id==2 happens to be one that's getting dropped.
To piece this apart, I made a variation of your "update" Zed script to skip the collect() step.
$ cat update_dont_collect.zed
over arr | switch id (
case 2 => put level0.level1.value:="2-changed"
default => pass
)
| merge id

Using this to turn the 100mb input file into individual records, we get an even count of 60k.
$ zq -i zng -I update_dont_collect.zed 100mb.zng > 60k.zng

$ zq 'count()' 60k.zng
{count:60000(uint64)}

However, if I then assemble those individual records into an array and output its length, it comes up way short.
$ zq 'arr:=collect(this) | yield len(arr)' 60k.zng
29173

I'm guessing some memory limit is being hit it and it's silently giving bad results rather than erroring out, but I can't say for sure. Someone who knows the code like @mccanne, @nwt, or @mattnibs could hopefully speak to that.

Ah yes. Even with my novice abilities to peek at the code, I'm reminded of #1813 and #1494 that speak of limits that likely come into play here. The comment in the code says:

For now we silently discard entries to maintain the size limit.

Speaking for my own experience, the "silent" part made this pretty hairy to debug. Not sure if other changes in Zed in the interim might have made it easier to raise/eliminate the limit altogether. As before, hopefully the core Zed dev team can chime in.

Oops.  Yeah memory limit in collect.  We'll fix this!
@muthu-rk thanks for helping us QA.  We haven't tested extensively enough on large values like yours as most the use cases to date have involved large numbers of smaller values, but this is an important area for us so we appreciate the help.

@mccanne : Thanks for response. Kindly let me know if you need more info. I would be glad to help out.

@mccanne: This issue is a blocker to continue large json tests. Can you tell when will this get fixed?
Thanks.

Of the two bullets in the most recent comment above, the first was addressed via #3921 and new issue #4102 has been opened to track the second. Therefore i'm closing this issue.


Random traffic

It could be good to mix vehicles performing mission with some random traffic. This creates some noise, leading to less predictable transportation times, which would make planning etc. more challenging.

This could be expressed as a specific mission, which specifies the behavior currently implemented by the vehicles. I.e., in the next step, choose a random route, and with some probability also include going into destination nodes.


Maven plugin replacement

The maven plugin is a pain to keep up-to-date. Let's delete it. This will also allow us to migrate from Maven to Gradle.
If we delete it, we can implement a simple mechanism in the assignments repository to download the jar from the internet the latest jar and use it! Or bring assignments to this project, make it one of the modules, and the dependency will naturally work.

Maven plugin support was removed in #174. We should still do something to allow students to easily run Andy. That can be via a script that launches a temporary docker container, or one which launches Andy directly, or both!

The README should be updated to reflect the changes.


Please, clarify WebSocket description

Current description for class dart:io:WebSocket is quite short.
Please, specify the following:

The WebSockets specification and version (probably some draft) which is implemented by dart:io:WebSocket class. This is important for heterogeneous communications. The other side (which might be not Dart) should know what expect.
Which protocols and extensions are supported?
Whether messages (especially List<int>) are transfered without splitting or joining with another messages
The WebSocket life cycle, like readyState (?) is CONNECTING after call to connect, OPEN after future returned by connect completes, etc. (BTW CONNECTING seems to be redundant in this case).
How the readyState of paired instance is affected, when WebSocket is closed or closing
If done event is received on WebSocket (which implements Stream) is it necessary to close the WebSocket explicitly?
Will peer instance receive done event after call to close?
WebSocket implements StreamSink, however only String and List<int> are allowed as events, which  formally violates contract of StreamSink. What will happen if events other than  String and List<int> are supplied to method add? Why it is not possible to send events of some simple types like int, bool, Map, etc?

Additional questions:

if  only String and List are allowed as events, then which types are allowed as errors?
WebSocket is a single-subscription Stream. If some listener have subscribed to WebSocket and then unsubscribed, is it necessary to call close explicitly? or it is called implicitly?


Daniel/update sanic 21.12

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

Closed in 10862


Update index.md

This is Andrew Wetmore (andreww), Editor for the Infrastructure team, with some suggestions to improve readability.
line 7: changed 'overview' to lower case, and the style from H3 to H2, to match the other title's style and capitalization
line 12: recieved => received
line 16: added comma; set external link to open in new browser tab.
line 18: moved a phrase to improve readability
line 19: adjusted "sponsors and donors" to "sponsors' and donors'" to get the plural possessive in place
line 31: pay => payments. Changed "treasurer" to "Treasurer" to match use elsewhere.

Thanks for all of the suggestions and pull requests!  I am on vacation this
week, but will definitely be digging in when I return.
Craig McClanahan
Treasurer, The Apache Software Foundation
On Mon, Jul 11, 2022 at 6:19 AM Andrew Wetmore @.***>
wrote:

This is Andrew Wetmore (andreww), Editor for the Infrastructure team, with
some suggestions to improve readability.
line 7: changed 'overview' to lower case, and the style from H3 to H2, to
match the other title's style and capitalization
line 12: recieved => received
line 16: added comma; set external link to open in new browser tab.
line 18: moved a phrase to improve readability
line 19: adjusted "sponsors and donors" to "sponsors' and donors'" to get
the plural possessive in place
line 31: pay => payments. Changed "treasurer" to "Treasurer" to match use
elsewhere.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/treasurer-site/pull/3
Commit Summary

7441f24
https://github.com/apache/treasurer-site/pull/3/commits/7441f2453c8c747e7a0cf4c2886126effe0c4d54
Update index.md

File Changes
(1 file https://github.com/apache/treasurer-site/pull/3/files)

M content/pages/index.md
https://github.com/apache/treasurer-site/pull/3/files#diff-04a04fd3e244b6e21d9d6232cc755de5f686b470b84b376e9e56de616122657d
(12)

Patch Links:

https://github.com/apache/treasurer-site/pull/3.patch
https://github.com/apache/treasurer-site/pull/3.diff

—
Reply to this email directly, view it on GitHub
https://github.com/apache/treasurer-site/pull/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA7ZLRKUEFIIPYUBJJJKYTVTQNPJANCNFSM53HPV3TA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi; have you had a chance to review these pull requests? I think most of the changes are straightforward and make the pages easier to read without changing the message.


Add canvas text drawing optimizations

Canvas fillText can be slow (see note at https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Optimizing_canvas  it says "Avoid text rendering whenever possible.")
This tries to optimize this by using an offscreen tileset of pre-rendered canvas letters
This change produces pre-rendered text tiles in black and white
It also fixes #75 by adding an empty autorun to watch variables that were going out of scope, the exact behavior was a bit hard to nail down but additional discussion here https://github.com/mobxjs/mobx/discussions/3911

closed for now, texture


Feature/888

#888
NOTES
This implements basic uses cases for desktop browsers, shown are examples of a back button, page title, and page actions including a "More" contextual menu.
The icon font has also been recompiled to include the backarrow icon.

Ready for review in branch feature/888 at http://localhost:3030/action-bar. See notes above.

is the back arrow is still not visible?

@saadmhybris I'm seeing the new back arrow — https://github.com/SAP/techne/pull/978/files#diff-269648d1bd33699db8e308496fc0537dR22. Remove your local branch and check it out again. I had to force push some changes so maybe you have something old locally.

Looks good from code.
on a side note, something wrong with the icons test page. it does not show the right icon. I'll open a ticket for it.

@xak
Looks great.
2 things:

What font weight are you using for the button labels?

I updated margins and padding for this to match the the Title Bar, Table, and Tree spacing. Should be a small update for this.

Otherwise looks great.

@LeoT7508 The button text looks bold, and what margin and padding did you update?

@xak
Ok, I think we can go with bold and see how it works. If it seems too heavy we can bring it down in weight.
I updated the left & right margins, and the spacing from the back arrow icon and the page title. Its all up on Zeplin if you need to see it in more detail.

@LeoT7508 The problem with the 20px margin is that the large icon button (Back button) uses 28 pixels on each side. That's what the button has. So I either need to ...

pull the button over 8px to simulate the margin,
create a special back button type just for this one button, or
change all large icon button to use 20px padding left and right.

What do you propose?

@xak
Well it depends on which section you want to patch together. Because if we don't use 20px padding for the action bar, then the icons in the title bar will have to be adjusted because that padding is 20px for those icons. Additionally, the icons and options in the tables and trees won't align if we use a different padding. So which creates less work for you is the real question?

@LeoT7508 The titlebar uses medium (standard) buttons which already have 20px. The tree I believe uses small buttons which use 16px.

@xak
"The titlebar uses medium (standard) buttons which already have 20px. The tree I believe uses small buttons which have 16px."
This is correct.

@LeoT7508 I recommend changing the padding of large icon buttons to 20px. This is the only instance we have so far of this button. If I try to pull it over 8px the hit area will potentially overlap with the sidebar, which is not ideal.

this PR is ready to be merged once we get a green light from @LeoT7508

@xak
We can change the icon large icon only buttons to 20px so 20px margins will work.
All good here. Ill update my sheets and upload them to Zeplin.

@LeoT7508 The background color here should be it's own color in the palette. It's a major part of the page so it doesn't make sense to use a lighter version of another color. It's not intuitive that changing a neutral color would affect the background for a large part of page.
The lighter and darker options should only be used when a base color is being modified, like for a :hover or :active state. That makes sense so when I create a new button with red text I don't have to then code separate values for the states. But in this instance the background is the base color. This should be part of backgrounds.

@xak
You are right about the color for the tool bar. I didn't use a percentage I added a background color I just didn't push it to Zeplin. Thats my miss, sorry about the confusion. The color is Background 2 #f0f5ff.
About the percentages, what approach do you suggest to substitute for this?

@LeoT7508 For the darken and lighten functions we use now the differences are minor, 5% here, 10% there. I think if we stick to the hovers and active states it should be ok. I found a tool that shows the SASS functions — http://jackiebalzer.com/color — but its not very useful since you can't input a hex value.
I also tried several other SASS functions but none produced the exact colors in that hex color tool. I'll need to investigate more to see what method would work best or how you can simulate the SASS effects in Photoshop to accurately see the colors.
This was a surprised to me when I stated looking at it. Colors are complicated, apparently. 😄

@xak
Ok so we will stick with percentages for the time being and try to find a solution.
Thanks.


Set-Emoji -Value @{} should set Emoji NoteProperties

Since extended properties on a single Emoji are persistent in memory as long as the module is loaded, we can keep that data for later use in the form of noteproperties.
Therefore Set-Emoji should set noteproperties, if provided a [Collections.IDictionary] value.

Upon further reflection, this is redundant (it can already be a variable with any value).


getting "install.py" in the right spot on the raspberry

i am in no way, shape, or form a linux user so i am crazy noob status here, but id like to set up oscar for my girlfriend. i have not been able to install the "install.py". my question is where exactly does it have to be on the system for the easy install to recognize it? when i type "sudo easy_install install.py" it ends up saying "no local or download links found for install.py" i have went to the website on the raspberry pi and downloaded directly and also carried over from a flash drive. halp! please. and thanks in advance...

You need to ensure you are running easy install from a git checkout as a starting point...


Add create_user_group attribute to Useradd provider

Add a create_user_group attribute to Chef::Provider::User::Useradd.
The default value is nil, so there's no change in existing behavior.
But setting it to true or false will append the -U or -N
optional arguments, respectively, to the useradd commandline.
This may or may not be compatible with all useradd(1) variants (it
works on Ubuntu 12+ and CentOS 6+, at least), so additional OS/distro
compatibility testing may be desirable.

kind of worried that because of the existing awfulness with useradd as the base class that this will troll solaris and aix.  might work better to build this on top of current master where the linux_user resource + provider are broken out for exactly this kind of purpose -- but the while the class has been broken out the hard work of refactoring the code is not done.

i also wonder if we just shouldn't have a command_options property so that users can inject arbitrary flags into the useradd/userdel command and be done with it all for good...

I'm fine with the command_options or extra_args attribute idea, but I would like not to kick the can down the road for too long.

this will troll solaris and aix

I'm not sure what you mean by this.

you're editing the base class which is inherited by aix and solaris, which means you're injecting code into those, which may blow up -- possibly in our build system that you (unfortunately) don't have any visibility into that runs all the tests on solaris and aix boxes.  adding arbitrary options to the commands would be more general and something i'd be more likely to support going into the base class.

Who gets to make the UX/behavioral decision here?

With the chef 12.14.x changes to the user provider the useradd provider is now the base class only for solaris and aix (with a future TODO to eliminate the base class entirely).  The lib/chef/provider/user/linux.rb file is now where this code lives and it should be much easier to patch it now (and easier to read and reason about) and not have to worry about clobbering inherited code on other operating systems (which aren't tested enough in travis).

Hi,
the route we've been discussing for other providers that can take a bunch of arguments (mdadm is the stand out one) is to allow them to take an options hash. I agree with Lamont that that's the better option here, too - and that's what I'd like to see for us to accept this PR.
Thanks for the submission!

the route we've been discussing for other providers that can take a bunch of arguments (mdadm is the stand out one) is to allow them to take an options hash. I agree with Lamont that that's the better option here, too - and that's what I'd like to see for us to accept this PR.

I'm not super opposed to this, since such an attribute can help operate as a last option to cover missing provider functionality.  But even if such an option existed, I might have proffered a PR for this anyway: one of the main benefits of Chef is to provide an abstraction layer between the user and the underlying implementation.
So I think it totally makes sense to support a new attribute anyway, since the question of whether to use a user-private-group (UPG) scheme is a site or machine policy that Chef can help enforce.  How it does it under the covers is an implementation decision that may vary across OSes, and the translation between policy and implementation is just the sort of thing we use Chef for.

@charlesjohnson do you have an opinion here?

As discussed, we're not happy with adding more options to useradd, and so are closing this PR. Thanks for your contribution!


Find and fix panic during configuration update

❯❯❯ landscaper package move --target-env=Prod --pkg=C4CIntegration
Transporting C4CIntegration to Prod...
2022/02/05 22:09:44 {"error":{"code":"Not Found","message":{"lang":"en","value":"Requested entity could not be found."}}}
2022/02/05 22:09:46 panic occurred: runtime error: invalid memory address or nil pointer dereference
2022/02/05 22:09:49 panic occurred: runtime error: invalid memory address or nil pointer dereference
2022/02/05 22:09:55 panic occurred: runtime error: invalid memory address or nil pointer dereference
№       ArtefactId                                      Version Package                         Transferred to Prod     Deployed
1       Service_Ticket_API_C4CPROD                   1.0.0   C4CIntegrationPROD        true                    false
2       Replicate_Service_Tickets_to_C4CPROD         1.0.3   C4CIntegrationPROD        true                    false
3       Replicate_Service_Tickets_from_C4CPROD       1.0.6   C4CIntegrationPROD        true                    false


astroid mail sending is broken

Describe the bug
The astroid mail client is no longer able to send mail.
Astroid from release-21.11 still works and its version has not been updated since then, so I assume this is caused by some sort of Gnome/GTK bloatcancer.
Steps To Reproduce
Steps to reproduce the behavior:

Edit .config/astroid/config and set accounts: …: sendmail: to something like a script that can be verified if its been invoked.
Open astroid and send a mail

Expected behavior
The sendmail command is invoked.
[10:00:00] [0x00007fa076142b40] [M] [info] mw: yes-no: got yes!
[10:00:00] [0x00007fa076142b40] [M] [info] em: sending message..
[10:00:00] [0x00007fa076142b40] [M] [info] msg: loading message from file (mid supplied<EMAIL_ADDRESS>[10:00:00] [0x00007fa076142b40] [M] [warning] charset: not defined.
[10:00:00] [0x00007fa076142b40] [M] [info] cm: sending (threaded)..
[10:00:02] [0x00007f9ff61ff640] [M] [warning] cm: sending message from account: ########
[10:00:02] [0x00007f9ff61ff640] [M] [warning] cm: message sent successfully!

Actual behavior
[09:44:45] [0x00007fe68dc33b40] [M] [info] mw: Really send message?
[09:44:46] [0x00007fe68dc33b40] [M] [info] mw: yes-no: got yes!
[09:44:46] [0x00007fe68dc33b40] [M] [info] em: sending message..
[09:44:46] [0x00007fe68dc33b40] [M] [info] msg: loading message from file (mid supplied<EMAIL_ADDRESS>[09:44:46] [0x00007fe68dc33b40] [M] [warning] charset: not defined.

** (astroid:44115): CRITICAL **: 09:44:46.095:
unhandled exception (type Glib::Error) in signal handler:
domain: gtk-icon-theme-error-quark
code  : 0
what  : Icon 'mail-send' not present in theme Adwaita

[09:44:46] [0x00007fe68dc33b40] [M] [info] mw: yes-no: got yes!
[09:44:46] [0x00007fe68dc33b40] [M] [info] em: sending message..
[09:44:46] [0x00007fe68dc33b40] [M] [info] msg: loading message from file (mid supplied<EMAIL_ADDRESS>[09:44:46] [0x00007fe68dc33b40] [M] [warning] charset: not defined.

** (astroid:44115): CRITICAL **: 09:44:46.099:
unhandled exception (type Glib::Error) in signal handler:
domain: gtk-icon-theme-error-quark
code  : 0
what  : Icon 'mail-send' not present in theme Adwaita

Notify maintainers
@bdimcheff @SuprDewd
Metadata

system: "x86_64-linux"
host os: Linux 5.15.32, NixOS, 22.05 (Quokka)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.8.0pre20220313_7abce04
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Related? #163107

Related to astroidmail/astroid#715 which is fixed in astroidmail/astroid#716.


perf benchmark: ractive blows hot and cold

In a nonsensical benchmark described here:
http://www.stefankrause.net/wp/?p=191
they measure 1000 rows created, updated and a row removal.
Interestingly Ractive is the fastest at updating 1000 rows and slowest at removing a row ;-)
Thoughts?

I haven't looked in-depth, but I do know that edge was way faster than 0.7.3 on several of our internal rendering benchmarks last time I checked.

Ractive.js is quite extreme. It’s the fastest when all rows are updated and the slowest in the “remove row” benchmark.

Possibly attributed to the fact that Ractive "surgically" updates the DOM. It tries its best to recycle DOM and only update what's necessary. An earlier wave of benchmarks were done using DB monster. @Rich-Harris did one for Ractive here https://github.com/Rich-Harris/ractive-dbmonster

Why is Ractive so fast?

Ractive uses similar techniques to Glimmer - it parses the template into a structure such that it's very easy to identify which DOM nodes need to be updated when data changes. This is different to how React (for example) handles DOM updates, which involves re-rendering everything and then running a diff.

Here's some demos:

Ember https://dbmonster.firebaseapp.com/
React http://run.plnkr.co/plunks/Wwgjjpl9NHMO5Nd1TUyN/
Ractive http://www.rich-harris.co.uk/ractive-dbmonster/
Paperclip (afaik, the fastest) http://paperclip-dbmonster.herokuapp.com/

On the other hand, implementation isn't usually "equal". There's a possibility that some are optimized for the task while some aren't. For instance, Ractive's rows are defined inline to the main component, while React's are defined in an entirely different component. What if Ractive used a component for the rows? What if React used inline rows? It could make the difference.
I'd say the DBMonster benchmarks were closer to "fair" as the framework authors themselves wrote the apps towards the same goal using a common data source. They could have thrown in everything to make their version really fast.

Running the test locally in edge shows edge is quite a bit faster than 0.7.3, but only in the things 0.7.3 is already good at, updates ;-)
Initial rendering of 1000 rows and deleting a row is where ractive doesn't shine so brightly.
Although nonsensical, sometimes these micro benchmarks highlights low hanging fruit. Whether it is worth pursuing those gains is another matter of course.
Wrt to the benchmark, I can understand ractive taking a bit of time in the create 1000 rows" test, it probably does more work upfront setting up the virtual dom etc. For example, running the "create 1000 rows" test on my machine takes 1000ms, on the first run. On the second run it takes 130ms, since it reuses the existing dom that was created I assume.
I am surprised with the "delete 1 row" test though. That takes 500ms. Maybe their ractive test is borked? They essentially do this to remove a row:
Template:
 {{#each store.data}}

{{/each}}

Code:
new Ractive({
delete: function(id) {
    var index = findIndex(id);
 startMeasure();
  ractive.splice('store.data', index, 1);
  endMeasure();
   ...
}

That is normally how I delete rows as well ;-)
Not sure why it would take so long to remove a row? Doesn't matter if you delete the first or last row.

I just tried it with edge, and the initial render is a bit slow still. The remove is down to 1ms, though, and every other benchmark is ~30ms. Here's what I get on my machine:

test
0.7.3
edge

create
850ms, 152ms, 131ms, 125ms, 131ms
903ms, 108ms, 95ms, 96ms, 94ms

add 10
80ms, 84ms, 78ms, 80ms, 82ms
27ms, 39ms, 30ms, 33ms, 36ms

update 10
71ms, 74ms, 72ms, 70ms, 72ms
21ms, 21ms, 21ms, 22ms, 23ms

remove first
806ms, 359ms, 353ms, 304ms, 311ms
1ms, 1ms, 1ms, 1ms, 1ms

remove last
22ms, 17ms, 18ms, 18ms, 19ms
1ms, 1ms, 1ms, 1ms, 1ms

remove middle
189ms, 191ms, 193ms, 189ms, 189ms
1ms, 1ms, 1ms, 1ms, 1ms

The times each represent a click, with the first being the first click. 0.7.3 remove performance varies wildly from start and end because it has to mark everything after the altered element due to the ways its caching works. @martypdx really nailed splicing with the model approach in edge.
So the only place 0.7.3 wins is in initial render. After that, edge wins all around, sometimes quite resoundingly. My current Ractive play issue is conditional directives and attributes, but once I get that settled, I'll look into initial render performance. It's been biting me a little in one of my projects that can use edge anyhow.

Hmmm... I apparently wan't paying close enough attention to what was happening, because the remove doesn't actually remove with edge. I suspect the slightly wonky way that the data manipulation is done in the test is the issue.

Nods, in the file 'main.es6.js' they do this:
this.data.splice(idx, 1);

To make it work with edge I changed it to:
ractive.splice('store.data', idx, 1);

Btw, I left out an important bit when I posted the example template above. They have an expression on the table row:
{{#each store.data}}

{{/each}}

Removing that expression and ractive removes row in 170ms, instead of 500ms. Adding a second expression in the repeated section and remove time goes up to 1400ms.

A quick profile shows a ton of time in resolveAmbiguousReference. Making all references unambiguous (.id vs id) cuts the time to a fifth of what it was on my machine.

Seems Ractive rebinds all expressions when the array is sliced? If the expressions referenced the row index, I can understand rebinding is needed but here it seems unnecessary? Ractive doesn't need to do anything really, just zap the dom?

I think there should be a note somewhere about resolveAmbiguousReference. it's really important to understand that
in our projects, I updated all {{foo}} to {{.foo}} or {{~/foo}} depending on the context. now I don't trace any more ambiguous references, so that sped up everything 2-8x

From what I can gleam so far is that resolveAmbiguousReference eventually calls:

RootModel.prototype.get, which calls
RootModel.prototype.extendChildren

extendChildren then iterates all the model's computations, checks if the computation is an expression before invoking a callback function, if it is not.
There are 1000 computations in the model at this stage and since there are 1000 rows, we loop over the model computations, 1 000 000 times. For this benchmark, all the computations are in fact expressions and we end up looping 1 000 000 times for no reason, except to chew up time ;-)
Seems like there is some optimizations we can do in repeating sections, some caching maybe?
As @evs-chris noted, using absolute references speeds things up quite a bit as it skips this extendChildren bit, however using {{foo}} is much nicer than {{.foo}}

@sabob true, but if you had something like this:
Ractive.extend({
  id: 'something',
  data: {
    list: [{one: 1, two: 2}, {two: 11}, {one: 1}],
    one: "yay"
  },
  template: `
    {{#each ~/list}}
      {{one}} {{.two}}\n
    {{/each}}
  `
})

then the output would be:
1 2
yay 11
1

see, the '.' tells to look in any scopes below it for the same name. it's by design. it is annoying, I know - but once you get it, it's powerful.
perhaps it could be cool to flip it around and say that {{foo}} and {{.foo}} (for sake of backward compatibility) and {{?foo}} or {{foo?}} relsolves the ambiguous reference
it would be cool if {{foo}}.

@heavyk you may have left a "not" out of your explanation.

did I? I didn't test the code... which not? I don't understand.
I'll make a fiddle. one moment

works as expected: http://jsfiddle.net/bxaeqb5a/

@heavyk thanks for the example. My comment on "{{foo}} nicer than {{.foo}}" is not that the feature isn't a good one, but rather I don't want to change all my references to {{.foo}} because of performance.

@evs-chris great work on #2372.!
Here are some numbers, before and after:

Test
Before #2372
After

Create 1000 rows
1 485ms
770ms

Add 10
39ms
30ms

Update 1000 rows
126ms
124ms

Update every 10
66ms
66ms

Remove first row
1390ms
260ms

Select row
26ms
26ms

There is also a follow up to the benchmark as other projects are also busy optimizing ;-)
http://www.stefankrause.net/wp/?p=283
I'll do some more profiling, mostly to learn about JS optimizations. Is Chrome profiler the best available at the moment or it subjective?

@sabob can you run the whole bechmark (all frameworks) to see how ractive compares to others now? I tried here, but npm is not in a good mood in this machine I'm using.

@guilhermeaiolfi I cannot get all the tests to run either, probably Windows issues. I can run Angular, Angular2, Ember, Ractive and React. I can sort of deduce which one is the fastest in each category:

Test
Ractive before #2372
Ractive after
Best

Create 1000 rows
1 485ms
770ms
320ms Vidom (Angular 2 is 404ms but vidom seems to be 20% faster)

Add 10
30ms
20ms
12ms Angular2

Update 1000 rows
126ms
124ms
124ms Ractive

Update every 10
66ms
66ms
25ms Angular 2

Remove first row
1390ms
260ms
141ms Angular 1

Select row
26ms
26ms
6ms Angular 2

Add another 10
30ms
30ms
30ms Ractive (Angular2 is 100ms.)

The test "Add another 10 rows" is my own benchmark, where I add 1000 rows and then another 10 on top of that. I cannot determine which one is best.

@heavyk You said:

see, the '.' tells to look in any scopes below it for the same name

.foo restricts to the current scope, but hopefully that is already clear to anyone else reading the thread.
http://docs.ractivejs.org/edge/references#restricted-references

Setting "modifyArrays" to false, shaves off a couple of ms:

Test
Default
ModifiyArrays: false

Select
26ms
18ms

Ouch, I made a mistake in my test. For the Ractive tests I accidentally added an expression which the other frameworks didn't have. Here are the revisited numbers:

Test
Ractive before #2372
Ractive after
Best

Create 1000 rows
1 080ms
740ms
320ms Vidom (Angular 2 is 404ms but vidom seems to be 20% faster)

Add 10
17ms
15ms
12ms Angular2

Update 1000 rows
126ms
124ms
124ms Ractive

Update every 10
26ms
26ms
25ms Angular 2/Ractive Close enough to be a tie

Remove first row
750ms
230ms
141ms Angular 1

Select row
15ms
15ms
6ms Angular 2 (Ractive with modifyArray false: 11ms)

Add another 10
27ms
27ms
27ms Ractive (Angular2 is 100ms.)

@woodlandhunter you're right. I edited my post to say it properly. I don't really remember what happened that night; I might have been stoned at the time :/
@sabob I didn't expect modifyArray: false to have any effect on select times. does anyone know why? I do a lot of array operations in our projects so I imagine that I'll be doing some benchmarks tonight. cheers! thanks for the tip :)

@heavyk I need to do a PR for the modifyArray speedup. As for why it would speed things up by a couple of ms is:
for the select benchmark, ractive loops every item in the array (1000 items) and checks if it's ID is equal to the selected one. If it is, it it highlights the row. So for this select operation, ractive uses an O(n) algorithm. The more items in the array the slower the select will take. For every loop ractive performs certain operations, one of which is to adapt the value based the registered adaptors. modifyArrays is a default adaptor registered by ractive.
The Model.prototype.adapt method has this line:
const keypath = this.getKeypath();

which in a tight loop chews a couple of ms. By setting modifyArrays: false the adapt method guts should be bypassed, however as it stands the line above line is still executed, since the adapt method doesn't bail immediately if there are no adaptors. We could change adapt to:
adapt () {
    const adaptors = this.root.adaptors;
    const value = this.value;
    const len = adaptors.length;
    if (len === 0) return;
    // slow code below
    const keypath = this.getKeypath();
    ...

However this is splitting hairs. Probably not really worth adding this tweak.

well explained. that sounds reasonable to me. I didn't know it did that... I think it's worth it and I'd definitely put up a PR for the early return with no adaptors. even though it's likely that someone is going to have at least one adaptor installed, at least that gives the option to someone for a performance boost in exchange for magic. for me, it's little effort to change the way I use my arrays and would gladly make the change.

I have noticed by writing a standard for loop and replacing .forEach not only compresses the library further (as when it is compressed over head is one letter instead of .foreach e()) & is much faster. I will fork Ractive later today with a few changes like this. For example instead of doing .length use a function this will compress it and performance will remain virtually the same. However the .length change is more for the compression gains. Also removing this old isArray method with the native isArray seems to be a better choice for the compression gains off the rip. I'm looking to make changes to the library that focuses on all MODERN browsers. Will provided findings and results as the days go by. Cheers!

@tomekmarchi: Just to add my 2 cents, I personally favor good code readability and good browser support. ...and consider gaining a few nanoseconds counter-productive if it hinders either of these aspects. Ractive's performance is more than enough. In almost all cases, the browser will spend most of the time in the layout engine or other places anyway.

Edge is now in the latest version of the benchmark results.. We're not exactly leading the pack due to the complexity of creating and removing massive amounts of DOM, but we're doing decently well at an overall 1.69x pure js, which is toward the front of the middle of the pack.
I've looked into speeding up the creation and removal time, but I can't come up with a way to do it nicely with how Ractive works, and honestly, I'm not sure that it's worth it for this particular case. It's probably not the best idea to throw 10,000 rows at a user. Even 1,000 is probably pushing it. If you do need to do stuff like that, don't get bootstrap css anywhere near it, cause it apparently murders performance.
So I'm going to close this. Edge, which will hopefully be 0.8.0 very soon, is anywhere from 30 to 500% faster than 0.7.3 on the tests in this benchmark that are heavy.


feat: updated CSS to respect row in subnav

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
Deleted flex-col and sm:flex-row in CSS for the subnav in mobile view as opposed to adding code.
Replaced with only flex-row for the subnav to display horizontally in mobile view.

Related Tickets & Documents

fix #221
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@KrisMannino  Looks better! Can you set a smaller text on the smaller break-point, so that the nav links also fit well even on a smaller screen? 😀
Preview in smaller screen rn:

LGTM


Unicode monospace width issues for '⬤'

The '⬤' unicode character (U+2B24 - Black Large Circle) does not seem to be displayed correctly in my recording, it takes up more width than it should: screenshot, recording
I tried both using Chrome on Ubuntu 20.04 and Chrome on Android 12.
Interestingly, when I use the image preview embedding from asciinema, the width is correct but instead the colors are not shown correctly:

The color issue may be due to the fact that I'm using 24-bit colors?

The recently release 3.7.1 version of the player got several improvements around rendering accuracy, mostly fixing positioning and alignment of various character groups (ascii drawing, block elements, Powerline symbols, CJK, emoji). It should look much better than before now.
Those fixes were also applied to the SVG previews in asciinema server, they should look consistent in most cases.
The first recording you linked still doesn't look as it's supposed to, but the 2nd one seems to be ok. This is how it looks for me now:


chore(io/tcp/unix): improve performance, and closed handle/server condition

Signed-off-by: azjezz<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

58 of 66 (87.88%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 99.751%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Psl/TCP/Server.php
30
34
88.24%

src/Psl/Unix/Server.php
28
32
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3204

Relevant Lines:
3212

💛  - Coveralls


reduce code coverage requirements

Closing this for now as our overall code coverage should still be 70% ideally. At reviewers discretion, ensure reasonable code coverage (still ideally 70%) for new code committed


Tap and Click

I've seen the following issues with tap and click using the "Thumbs Gallery With Two-way Control" demo.  On an HP ENVY 15t under Windows 8.1, I'm testing tap on the touch screen, then mouse  click on thumbs to ensure it selects a slide in the main gallery:
Chrome 40.0.2214.115
tap works     click does nothing
IE 11.0.9600.17631
tap does nothing   click works
Firefox 35.0.1
tap works     click works
Safari 5.1.7 (7534.57.2)
tap works     click works
I also tested IE and Chrome on an ASUS T200 tablet and saw the same results

You have ie device with both touch and mouse inputs?

Yes, the HP Envy laptop has a touch screen and the ASUS is a tablet with a detachable keyboard.
From: Vladimir Kharlampidi
Sent: Tuesday, February 24, 2015 8:54 AM
To: nolimits4web/Swiper
Cc: lesarnott
Subject: Re: [Swiper] Tap and Click (#1115)
You have ie device with both touch and mouse inputs?
—
Reply to this email directly or view it on GitHub.

Could you please try it with latest dev version

This should be fixed in dev version, could you please check it?

Sorry for the delay, I had to install nodejs etc to do the build.  Thanks for the fix.   Yes, both tap and click are now working on Chrome but tap is still not working on IE.
Testing IE, I set a breakpoint at line 1175 in swiper.js
        // Tap, doubleTap, Click
        if (s.allowClick) {

I tapped on a thumb, it hit the breakpoint and I changed s.allowClick from false to true and then the tap worked ok.
Anything else you'd like me to try?
Les

Thanks. By not working tap you mean when you tap gallery thumb with finger over screen?

Yes,  I'm only talking about problems with tap/click on the thumbs gallery to select a photo in the main gallery.  After your fix the only remaining problem I'm seeing is on IE when tapping with a finger on a thumb gallery photo.

Any update on this?   More evidence of the problem - in IE none of the demos on your web site respond to taps on the next/prev arrows, pagination, or carousel selection but they all respond to swipes.  With Chrome all demos respond to swipes and taps.

Fixed right now in dev version


Ability to hide error messages inside

There are instances where I do not want show default error messages but a customized one that too based on custom logic. Hence, it would be great if this enhancement is added.

Did you figure this out?

This functionality seems like it would be covered under Custom Error Messages. Can you explain further if it isn't?

I am able do a workaround with following snippet
<bfv-messages [ngStyle]="{'display':'none'}"></bfv-messages>
Custom Error Messages won't solve my use case. I have my own custom validations and handling for each fields


Implement refresh and access token system in backend

Description:
Develop a robust refresh and access token system in the backend to enhance application security.
Tasks:

Modify authentication service to generate both access and refresh tokens
Update login and registration processes
Implement token refresh endpoint
Update middleware for token validation
Implement token revocation system

Acceptance Criteria:

[ ] Modify the signAndSetCookie function to generate both access and refresh tokens
[ ] Update the login, register, and OAuth callback functions to use the new token system
[ ] Create a new endpoint for token refresh (/auth/refresh-token)
[ ] Update the requireAuth middleware to validate access tokens
[ ] Implement token revocation on logout
[ ] Update error handling to return appropriate responses for token-related errors
[ ] Implement rate limiting on token-related endpoints to prevent abuse
[ ] Update the passport JWT strategy to work with the new token system
[ ] Ensure all routes that require authentication use the new token system

Additional Information:

Consider using JSON Web Tokens (JWT) for implementing the token system.
Ensure that refresh tokens have a longer expiry time compared to access tokens.
Implement proper encryption for storing refresh tokens if needed.
Update the auth.service.ts file to include functions for handling the new token system.
Modify the auth-routes.schema.ts to include validation for the new token endpoints.

Related Dependencies or References:

Hey @dileepainivossl, would you be interested in working on this issue?

Hey @dileepainivossl, would you be interested in working on this issue?

Sure, can you assign it to me? for this Github user

Nice @dsmabulage 🚀

Any updates on this @dsmabulage

Any updates on this @dsmabulage

added a pr #162


feat(data): Add IntoJson

Cherry pick f0aece981c01573b0a2d415c3e30570b4d52ce66 (#293)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 51.835%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/snapbox/src/data/mod.rs
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
1342

Relevant Lines:
2589

💛  - Coveralls


feat: include errors in worldgen's system interfaces

fixes https://github.com/latticexyz/mud/issues/757
only errors, events are not only an antipattern but wouldn't even work for any non-root system, since those aren't delegatecalled

Do we wanna add an example system to the examples dir for now to demonstrate this working?

Do we wanna add an example system to the examples dir for now to demonstrate this working?

Yes, but I'm setting up a separate folder for integration tests, this can serve as a nice first example for them

Or is there a way to write automated tests for this?

I'm thinking of trying to access an error's selector in a test. It will fail if the selector doesn't exist


Orfs153 implement script to run se command for secure erase

This script is to implement disk erasing functionality.
hdparm, scrub, sg_format tools are integrated. sg_sanitize is also integrated but less likely to be run as many drives doesn't support.
Erasing will run in async-mode so multiple disk erasing time consumed should be the same as the slowest disk.
For each disk, a log file will be created under home directory named disk name. This can help us to understand what happened during erasing and is intended for getting erasing status.
An example to run this script:
sudo python secure_erase.py -t scrub -o nnsa -d "/dev/sdx,/dev/sdy,/dev/sdw"
-t: specify tools to be used
-o: specify erase option under a specified tool
-d: a string contains all disks to be erased.

@RackHD/corecommitters @WangWinson @linlynn

Coverage decreased (-0.07%) to 91.046% when pulling b68b3759f79abfff2d2a4f41a6a5e29998644f7d on pengz1:orfs153-Implement-script-to-run-se-command-for-secure-erase into 3e07d56a5462d77a17acf9350351d6a0167c096c on RackHD:master.

Coverage decreased (-0.02%) to 91.13% when pulling fc2c67f675c9c42a39f2d834a0a2ff635bd5f4f0 on pengz1:orfs153-Implement-script-to-run-se-command-for-secure-erase into 878482f0ab8adcdb05d681e3cbbf9a06d94e737b on RackHD:master.

Coverage decreased (-0.02%) to 91.13% when pulling fd3c9db112abff53cc0f48c6121d5658d40461f3 on pengz1:orfs153-Implement-script-to-run-se-command-for-secure-erase into 878482f0ab8adcdb05d681e3cbbf9a06d94e737b on RackHD:master.

Coverage decreased (-0.02%) to 91.075% when pulling 5a1adc38388480f0f32d24976693690c0c669627 on pengz1:orfs153-Implement-script-to-run-se-command-for-secure-erase into 874756b10e8aede2708114c79637f656e0382880 on RackHD:master.

+1

:+1:

:+1: with Winson's comments

:+1:


add artifact and label client

This PR adds two separate clients, one for the artifact and one for the label endpoint of the harbor API.
Unfortunately, not all features of the artifact client can be implemented right now, as https://github.com/goharbor/harbor/issues/13468 is blocking the GetAddition() and GetVulnerabilitiesAddition() endpoints.
Affected methods are included in this PR, but only as code comments.
Part of https://github.com/mittwald/goharbor-client/issues/106

Hello, may I ask when this PR can be merged? I now need to manipulate artifacts, thank you!


Update logout endpoint to be per project on Masthead

Update logout endpoint to be per project on Masthead

I talked with @jamestalton and down the road, we may abstract the Masthead component to receive those project specific details as props or another solution, right now adding this one as to allow log out using Hub, and to keep traceability when changing this later on.


⚠ Bofrost.de has degraded performance

In e0853d8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1312 ms

Resolved: Bofrost.de performance has improved in aa4f138.


Test v4.0 with WP 4.9.x

v4.0 requires WP 5.0+ because we're using the wp-hooks script, mostly for postMessage changes in complex fields like typography etc, but also to init these complex fields.
As a fallback I added that script in the compatibility package and it will be enqueued in case the user in on an older WordPress version.
We need to test that implementation and make sure it works.

Test on Wordpress 4.9.4:
2019/08/19 23:48:42 [error] 2273#2273: *174 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Error: Class 'Kirki\Compatibility\URL' not found in /var/www/html/wordpress4/wp-content/plugins/kirki/packages/kirki-framework/compatibility/src/Scripts.php:50
Stack trace:
#0 /var/www/html/wordpress4/wp-includes/class-wp-hook.php(286): Kirki\Compatibility\Scripts->register_scripts('')
#1 /var/www/html/wordpress4/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)
#2 /var/www/html/wordpress4/wp-includes/plugin.php(453): WP_Hook->do_action(Array)
#3 /var/www/html/wordpress4/wp-includes/script-loader.php(1435): do_action('wp_enqueue_scri...')
#4 /var/www/html/wordpress4/wp-includes/class-wp-hook.php(286): wp_enqueue_scripts('')
#5 /var/www/html/wordpress4/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)
#6 /var/www/html/wordpress4/wp-includes/plugin.php(453): WP_Hook->do_action(Array)
#7 /var/www/html/wordpress4/wp-includes/general-template.php(2614): do_action('wp_head')
#8 /var/www/html/wordpress4/wp-content/themes/astra/he" while reading response header from upstream, client: <IP_ADDRESS>, server: <IP_ADDRESS>, request: "GET /wordpress4/test-15/ HTTP/1.1", upstream: "fastcgi://unix:/run/php/php7.2-fpm.sock:", host: "<IP_ADDRESS>", referrer: "http://<IP_ADDRESS>/wordpress4/wp-admin/post.php?post=3128&action=edit&lang=pl"


Translations update from Hosted Weblate

Translations update from Hosted Weblate for Collision/Collision.
Current translation status:

Wow, so weblate locked up for a month due to a linguas change...


Error checking for introspection failures

Add error checking in the getLogger method. Some applications are
seeing Java exceptions (no such field) from the nativeGetLogger method.

thiz is the jobject passed in as parameter. It can be named anything no?


Why Card cannot be inverted ?

As the title says, why is it not possible to make the card have inverted attrbiute ?

You can use a ui segment with inverted colors if you want, which gives you the similar look with inverted variant?

I can but segment does not have properties like card does to arrange items ? Event if I wrap the card in an inverted segment it looks like there is a white hole in the segment so it won't inherit the inverted properties of segment.
The Card can be colored but the color is for the border not the fill.

Hi @cemremengu, because the .inverted variation doesn’t exist; it’s a known enhancement: #3478. There’s a comment there that might help you to implement it in your project, it’s a bit confusing if you’re not fluent with SUI structure and how to work with the source, so please let me know if you need help with that—but if you do, please use either this thread, or our Gitter chatroom.

You can use a ui segment with inverted colors if you want, which gives you the similar look with inverted variant?

but when we use it with the  raised+link  class it got overwritten and the whole card turns into white color on hover...

The active community fork Fomantic-UI has got an inverted variant for the card element already since 2 1/2 years
https://fomantic-ui.com/views/card.html#inverted


test

Coverage remained the same at 79.474% when pulling 43be2106316b158330203029850aa5ea64c286e8 on reevenneal:patch-2 into 17a60a6857856c64f3cbfccb4e97d9d6b6c8c8e7 on tableau:master.


docs: reference page for KeptnApp

This PR:

Creates the KeptnApp reference page using information that was in the concepts/app file.
Deletes the concepts/app file

This page needs more content but this is a start.

This PR is corrupted so I am closing it.  It is replaced by https://github.com/keptn/lifecycle-toolkit/pull/1391


Dart 3 support (null safety)

Added support for dart 3 by implementing null safety. Light refactoring as well.

fix for issue #52


Prompt

I dont see a button to accept the prompt,also after the first prompt I can't seem to be able to make an additional prompt

I've added a send button and you can now send additional prompts after the first one


Add bikramnehra to Kubeflow org

This change is

/lgtm
/approve
FYI i need to manually sync after this is submitted which I do once a week so it won't take effect immediately. Watch out for a GitHub invitation in the next week or so.


How to use the entity2src.tsv to query the corresponding concepts

Hi, thank for sharing this great task. But I want to ask how can I use entity2src to get the corresponding concepts. For example : Gene::100129669	[Hetionet] Biomedical knowledge graph https://het.io/about/	[STRING] https://string-db.org/, does this mean the identifier 100129669 are the same with Hetionet and STRING?

The file entity2src.tsv maps the entities/nodes to the list of data sources they appear in (we use seven different data sources to construct the DRKG). Regarding the IDs, we use the following rules to assign IDs to the entities:
(i) Compound entities are mapped to the Drugbank ID and if not possible to the Chembl ID. If a compound can not be found to either of the two we use the native ID space and we include the name of the source as part of the entity’s name.
(ii) Gene entities are mapped to the Entrez ID.
(iii) Disease entities are mapped to the MESH ID space.
(iv) The remaining biological entities appear only in a single data source and hence we use the data source’s ID.


Allow custom chef run list

In certain situations there is a need to run a custom run list. For example, if you need to put an nginx proxy in maintenance mode,  you can use a custom recipe with this option to achieve that.

LGTM

LGTM


Can I just refund an amount not an item?

for example, I have an order with phone and ipad. total is $1000. I just want to refund $50, Any ways I can do it? For now, when I change refund amount to all 0. I can't refund any more. I have to refund some amount from an item, but the amount refunded will be 1 or something.

Hi @lYesterdaYl ,
As of now you can refund only shipping amount without refunding items, but its good point and should be implemented
so we need to add one more button to update totals like like we have update quantities and accordingly we can add this feature  like:

@rahulcs0082 do you have any update on this enhancement?

@rahulcs0082 do you have any update on this enhancement?

@rahulshukla-webkul do you have any update on this enhancement?

@rahulshukla-webkul do you have any update on this enhancement?

Hi @ghermans @lYesterdaYl
Right now, this thing is not in our product.
As this is a user specific requirement so a user can customise it accordingly.

Hi @ghermans @lYesterdaYl
Right now, this thing is not in our product.
As this is a user specific requirement so a user can customise it accordingly.


Unclear how to pattern match names, pat.vars, etc

The only way to do that is to write q"${_: Term.Name}" and the like in the pattern, and that's really non-obvious from quasiquote.md.
This kind of pattern matching is also sort of unpleasant. It would be nice if we could come up with a nicer notation here.

Fixed in https://github.com/scalameta/scalameta/pull/272 via a series of changes to quasiquotes.md. @ValentinRutz, could you verify that it's now clear?


Question: Webapi not necessary for Beaker?

Hi, I created a website with Beaker and installed Homebase on my server - webapi is disabled. When I update my website it gets synchronized with homebase. I wonder what the webapi is for. The doc says:

Set to true to enable the Pinning Service API, which enables publishing to Homebase with Beaker, the Dat CLI, or any other client that supports the Pinning Service API.

When I enable the webapi in homebase nothing changes.

That API is there so that tools like dat-store can connect to your homebase instance and add Dats instead of having to open homebase in your browser each time.


Warn when CXX and CUDA host compiler do not match.

On some systems, this can cause problems if the two compilers are tied
to different glib versions. At linking time (esp. for examples or
tests), it is then possible that some symbols are not found.
Closes #605

@upsj is correct, if CUDA_HOST_COMPILER is not set manually, it is not available here. I get the following output if I specify nothing (while setting CXX=gcc-10 during cmake):
  The CXX compiler is /usr/local/bin/gcc-10 with version 10.2.1.

  The CUDA host compiler is .

Interesting, thanks for the info. I had not checked without passing the variable as my system requires this.

I cannot really find a way to identify which compiler nvcc will use by default, so if for some reason it is not set (at least when setting GINKGO_CUDA_DEFAULT_HOST_COMPILER) then I do not print anything.

@thoasm

I could not find a way to get the cuda host compiler either.
Having this is definitively better than not having.

For reference, I found that you can find the host compiler by compiling some source code with nvcc and using the flag --verbose. Though it doesn't seem practical to extract the host compiler information from there (you need ot recognize the host compilation line, extract the command out of it, etc...).


UI: fix create tags for LB rules

Description
This PR fixes the issue when create tags for load balancing rules.
without this change

with this change it works.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6475 (SL-JID-1773)


Issue with webpack statically extracted dependencies

I'm submitting a ...  (check one with "x")
[x] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

Current behavior
Throwing a warning that is turned into a hard error with static files build.
WARNING in ./~/ng2-translate/bundles/ng2-translate.js
Critical dependencies:
1:2208-2215 require function is used in a way in which dependencies cannot be statically extracted
1:2254-2261 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/ng2-translate/bundles/ng2-translate.js 1:2208-2215 1:2254-2261

Which leads to this output in the console with static files:
Uncaught TypeError: Cannot read property 'resolve' of undefined
Uncaught TypeError: Cannot read property 'forRoot' of undefined

Reproduction of the problem
git clone git@github.com:angular/angular2-seed.git
cd angular2-seed
npm install
npm install --save ng2-translate

In src/vendor.browser.ts
import 'ng2-translate';

In src/app/app.module.ts
import { TranslateModule } from 'ng2-translate'; // <<<<<<<<<<<<<<<<<<<< <  added

@NgModule({
  declarations: [AppComponent, About, RepoBrowser, RepoList, RepoDetail, Home],
  imports     : [
    BrowserModule,
    FormsModule,
    HttpModule,
    RouterModule.forRoot(rootRouterConfig),
    TranslateModule.forRoot() // <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< <added
  ],
  providers   : [Github, {provide: LocationStrategy, useClass: HashLocationStrategy}],
  bootstrap   : [AppComponent]
})
export class AppModule {

}

Please tell us about your environment:

ng2-translate version: 3.1.0

Angular version: 2.0.0

Browser: [Chrome 53]

Can you change import { TranslateModule } from 'ng2-translate' to import { TranslateModule } from 'ng2-translate/ng2-translate' and see if it works?

Tried it and it doesn't work infortunately.
This gives a hard error:
ng2-translate.js:1Uncaught SyntaxError: Unexpected token import
bootstrap f8a9cd9…:50Uncaught TypeError: Cannot read property 'call' of undefined

Used the 'ng2-translate/ng2-translate' in both the vendor and app.module.
And when only using the ng2-tralate/ng2-transate in app.module.ts there is a hard error, the warning given by webpack is still there and the output in the console is:
[WDS] Warnings while compiling.
client:68./~/ng2-translate/bundles/ng2-translate.js
Critical dependencies:
1:2208-2215 require function is used in a way in which dependencies cannot be statically extracted
1:2254-2261 require function is used in a way in which dependencies cannot be statically extracted
 @ ./~/ng2-translate/bundles/ng2-translate.js 1:2208-2215 1:2254-2261
ng2-translate.js:1Uncaught SyntaxError: Unexpected token import

Hi,
I had the same problem. For some reason webpack doesn't like the package. I tried everything, but I finally solved it forking the project, and including in the packages.json the git path. Then with webpack you can import the ts file directly from node_modules and webpack will take care of everything else.
Let me know if you find a better solution!
Cheers
Fabio

having exact same issue, has anyone found a solution that doesnt require forking and hacking?

are you using webpack1 or webpack2? i had problem with webpack1, but with webpack2 it is working...

Using Webpack 2.1.0-beta.22
On Mon, 10 Oct 2016 at 16:47 Peter Luptak<EMAIL_ADDRESS>wrote:

are you using webpack1 or webpack2? i had problem with webpack1, but with
webpack2 it is working...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ocombe/ng2-translate/issues/273#issuecomment-252661303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE82kv-jvq28Ug8EQCNKBFwaIZhn9xlks5qyl33gaJpZM4KRFo3
.

+1
I can't get ng2-translate 3.x.x to work with webpack, either. I get the same errors and warnings as @gamazeps.

I'm also facing these issues. Using ng2-translate 3.1.0 and Webpack 1.13.2.

im using webpack 1.12.14, still same issue

Not sure if related, but I get
SyntaxError: import declarations may only appear at top level of a module
vendor.js:1
TypeError: ng2_translate_1.TranslateModule is undefined

when updating to 3.1.0

not great... in order to make the typings work I have to install oCombe package, then 'typings i npm:ng2-translate' and then remove his package from packages.json and replace it for my git repo. Basically a rubbish hack from my behalf!!

Just wanted you guys to know that it works out-of-the-box using this starter. However, that starter does a lot of things differently to what I have been doing, so I haven't been able to pin down whats the breaking change between them yet though.

@ocombe any ideas?

I have the same issue, any solution ?

+1 any non-hacky solution?

On angular 2.0.2 I tested ng2-translate version 3.0.0 through 3.1.2 (which I tested with angular 2.1.0), with no resolution. The last working version for me is 2.5.0.

Same, I was able to work with the 2.5.0,with others i have the same issue

Hi, I have the same issue :
WARNING in ./~/ng2-translate/bundles/ng2-translate.js Critical dependencies: 1:2208-2215 require function is used in a way in which dependencies cannot be statically extracted 1:2254-2261 require function is used in a way in which dependencies cannot be statically extracted  @ ./~/ng2-translate/bundles/ng2-translate.js 1:2208-2215 1:2254-2261
For me it's not a big problem, my application run perfectly with this warning (angular v2.0.1, webpack 1.13.2, ng2-translate 3.1.0).
But this kind of messages are always ugly in compilation logs.

I tried with a test project generated with angular-cli and worked perfectly
well out of the box, but I can't get it to work with angular universal
without my dirty hack
On Fri, 14 Oct 2016, 07:54 Morgan<EMAIL_ADDRESS>wrote:

Hi, I have the same issue :
WARNING in ./~/ng2-translate/bundles/ng2-translate.js
Critical dependencies:
1:2208-2215 require function is used in a way in which dependencies cannot
be statically extracted
1:2254-2261 require function is used in a way in which dependencies cannot
be statically extracted
@ ./~/ng2-translate/bundles/ng2-translate.js 1:2208-2215 1:2254-2261
For me it's not a big problem, my application run perfectly with this
warning (angular v2.0.1, webpack 1.13.2, ng2-translate 3.1.0).
But this kind of messages are always ugly in compilation logs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ocombe/ng2-translate/issues/273#issuecomment-253723551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADE82lEGyidaIW9UnAwu1sg-6k9qCoPGks5qzycQgaJpZM4KRFo3
.

Unfortunately, the current example in examples/webpack runs with version 2.4.1 of ng2-translate and doesn't work as stated in issue #258... Maybe someone with a working example can open a pull request? I would do it myself, but I have yet to find a solution...

I had the same issue. Solution:

Replace all import { ... } from 'ng2-translate'; to import { ... } from 'ng2-translate/ng2-translate';
Add babel loader for js files because node_modules/ng2-translate/ng2-translate.js file has ECMA 6 syntax.

Here is my webpack loader configuration:
{
    test: /\.js$/,
    include: /ng2-translate/,
    loader: 'babel',
    query: {
        presets: ['es2015']
    }
}

Thanks for the suggestion@Redigast13. I actually just re-used the typescript loader so I wouldn't have to add babel. Here's the loader configuration I added:
      {
        test: /\.js$/,
        include: /ng2-translate/,
        loader: 'awesome-typescript-loader'
      },

Thanks @rlopez4 . It really works!!

I created the pull request #285, which uses the solution from @Redigast13. I couldn't get it to work with awesome-typescript-loader, like @rlopez4 suggested.

I've been playing around with the different build systems, trying to fix those bugs.
I think I'm gonna revert the build to commonjs as it was before, and build an additionnal umd package for people who are looking for smaller packages (tree shaking ftw).

@ocombe see my fix for ng2-formly https://github.com/formly-js/ng2-formly/pull/126

Ahh perfect @aitboudad I almost had the good setup, all I was missing was libraryTarget: 'umd' in the output config !
By the way with your setup you embed all the code of the external rxjs libs instead of just referencing it, my external config is much simpler: externals: [/^\@angular\//, /^rxjs\//] with this the bundle goes from 109ko (with your config) to 35ko with mine !
I'll publish a new version soon, I tested with the angular 2 seed and it works perfectly

ok the new build (using webpack instead of systemjs) should be working with you guys, I'm just waiting on travis to pickup the build so that it releases a new version, but it's a bit delayed because of github connections issues today :)

That's good to know. thanks!

Ok version 3.1.3 has been released, let me know if that's ok now

Hi,
I'm still having an issue with version 3.1.3 and webpack 1.13.3:
Uncaught SyntaxError: Unexpected token export
at Object. (http://localhost/js/vendor.js:3587:2)
at webpack_require (http://localhost/js/polyfills.js:51:30)
at eval (eval at  (http://localhost/js/vendor.js:3581:2), :10:1)
at Object. (http://localhost/js/vendor.js:3581:2)
at webpack_require (http://localhost/js/polyfills.js:51:30)
at Object. (http://localhost/js/vendor.js:6:19)
at webpack_require (http://localhost/js/polyfills.js:51:30)
at webpackJsonpCallback (http://localhost/js/polyfills.js:22:20)
at http://localhost/js/vendor.js:1:1
localhost/:38 Uncaught TypeError: Cannot read property 'forRoot' of undefined(…)
In the NgModule :
`
import {TranslateLoader, TranslateStaticLoader, TranslateModule} from "ng2-translate/ng2-translate";
TranslateModule.forRoot({
provide: TranslateLoader,
useFactory: (http: Http) => new TranslateStaticLoader(http, ResourceService.RESOURCE_URL, '.jsonProperties'),
deps: [Http]
}),
`
in my vendor.ts:
import 'ng2-translate/ng2-translate';
and finally I'm using the translateService in my component:
import {TranslateService} from "ng2-translate";
Do you have an idea?

Change all 'ng2-translate/ng2-translate' to 'ng2-translate'

Thanks :)

Version 3.1.3 is working for me, too. Thanks!

Cool, it solves the problem also in Angular Universal. Thanks @ocombe


Failed to allocate memory for tensor_info, 1320 bytes required

@tensorflow/micro
Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
NAME="Ubuntu"
VERSION="18.04.3 LTS"
ID=ubuntu
PRETTY_NAME="Ubuntu 18.04.3 LTS"
VERSION_ID="18.04"
Python versionL 2.7.15+
Target platform : K64F
Describe the problem
I have build a GRU model in python and converted to a bin format for ARM K64F board. When I flash the binary I get the following error message in the serial console.  How can I fix it? Any help is appreciated.
`Failed to allocate memory for tensor_info, 1320 bytes required
AllocateTensors() failed
++ MbedOS Fault Handler ++
FaultType: HardFault
Context:
R0   : 00000000
R1   : 00000000
R2   : 00000000
R3   : 20013FE8
R4   : 00000000
R5   : 00000000
R6   : 00000000
R7   : 20002368
R8   : 20002364
R9   : 00000000
R10  : 00000000
R11  : 00000000
R12  : 000000B0
SP   : 20013F10
LR   : 00008E89
PC   : 000010E4
xPSR : 61070000
PSP  : 20013EA8
MSP  : 2002FFC0
CPUID: 410FC241
HFSR : 40000000
MMFSR: 00000000
BFSR : 00000004
UFSR : 00000000
DFSR : 00000008
AFSR : 00000000
Mode : Thread
Priv : Privileged
Stack: PSP
-- MbedOS Fault Handler --
++ MbedOS Error Info ++
Error Status: 0x80FF013D Code: 317 Module: 255
Error Message: Fault exception
Location: 0x10E4
Error Value: 0x1FFF0400
Current Thread: main Id: 0x200013E8 Entry: 0x3F07 StackSize: 0x10000 StackMem: 0x20004010 SP: 0x20013F10
For more info, visit: https://mbed.com/s/error?error=0x80FF013D&tgt=K64F
-- MbedOS Error Info --
= System will be rebooted due to a fatal error =
= Reboot count(=7) reached maximum, system will halt after rebooting
`

This is the expected error if you are trying to load a model and your tensor arena is too small.  If you have extra memory, you can increase the tensor arena size.  If not, you will either need to compress your model and required tensors via quantization, or select a more compact model.

Apologies for the delay.  It's strange that you're seeing that error - as far as I know that's a sanity check to ensure that the memory planner has found valid lifetimes for each tensor in the graph - i.e. for each tensor it has a valid start and end.  I'm guessing you may be running into this error as a side-effect of something else going wrong.  Perhaps try further increasing arena size (we have seen some issues with marginal arena sizes) and make sure you allocate the arena in a valid way. Avoid allocating large arenas on the stack to avoid stack overflow issues.  Also make sure you aren't overrunning any structures in your application, since that could also cause memory corruption.
When it comes to quantizing float tensors, we mainly support int8 quantization on TFLite Micro.  You should be able to quantize your model using the TFLite converter with OPTIMIZE_FOR_SIZE along with providing a representative dataset.  Note that we do not support running hybrid quantized models on TFLite Micro, hence needing a representative dataset at conversion time.

I'm going to close this, since it's been a while since any update. Please reopen if this issue persists, or if new information is available.


Automated cherry pick of #5518

Cherry pick of #5518 on release-5.24.

#5518: Re-read state after it is updated in leaveChannel

/cc  @agarciamontoro

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 04eaf49dbb685acf8db15b47b982b89dcc25fd7f


Add error message when callable is string and cannot be instantiated

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues

👍


Fixes issues and tests on indexes

This PR :

updates indexes after each way to upload or delete a package
adds some tests on update indexes function
adds tests on duplicate upload, with and without force flag
adds some tests on repodata.json file after deleting a package

Codecov Report

Merging #555 (6a41176) into main (bee4a48) will decrease coverage by 1.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   82.87%   81.47%   -1.40%
==========================================
  Files          78       78
  Lines        5973     5977       +4
==========================================
- Hits         4950     4870      -80
- Misses       1023     1107      +84

Impacted Files
Coverage Δ

quetz/main.py
86.70% <100.00%> (+0.50%)
:arrow_up:

...s/versions/53f81aba78ce_use_biginteger_for_size.py
56.25% <0.00%> (-18.75%)
:arrow_down:

quetz/database.py
70.83% <0.00%> (-16.67%)
:arrow_down:

...ns/versions/30241b33d849_add_task_pending_state.py
80.00% <0.00%> (-13.34%)
:arrow_down:

quetz/pkgstores.py
42.45% <0.00%> (-11.60%)
:arrow_down:

...ons/a3ffa287d074_case_insensitive_channel_names.py
68.75% <0.00%> (-6.25%)
:arrow_down:

...s/versions/8d1e9a9e0b1f_adding_download_metrics.py
72.22% <0.00%> (-5.56%)
:arrow_down:

...ions/versions/8dfb7c4bfbd7_new_package_versions.py
80.95% <0.00%> (-4.77%)
:arrow_down:

quetz/database_extensions.py
56.36% <0.00%> (-3.64%)
:arrow_down:

quetz/dao.py
88.91% <0.00%> (-2.18%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee4a48...6a41176. Read the comment docs.

Thank you @brichet this looks great!


Retain filters on triggers screen if navigated to another screen and come back

Problem 1: The Triggers screen for pipelines has filters based on few trigger properties, but filters reset by refreshing the page or click on some trigger and coming back by clicking back button. I need to add that same filter again and again if I navigate to another screen for a while.
Solution 1: Please provide support for persistent filters on triggers screen like we already have the persistent group by tag feature on pipelines screen.
Problem 2: there is no search option in bock runs page
Solution2: There should be search on block runs screen at least based on trigger

@johnson-mage Please check this issue and keep me posted on the progress for this ticket.


added configuration to provide API keys to location providers

fixed #3

Looks like the code also needs a cargo fmt some files have 2 space indent in use.

fixed


ref return struct instead of struct ptr

Describe the solution you'd like
Currently using ILCreateFromPath requires having unsafe user-code. Ideally having a friendly overload of

ref ITEMIDLIST ILCreateFromPath(string path)

would be appreciated.
This allows using S.R.CS.Unsafe.IsNullRef() for further checks whether returned value is indeed null.
My current implementation requires creating a separate method with different name, as there is a signature collision due to C# not taking ref return value into account.
/// <inheritdoc cref="ILCreateFromPath(PCWSTR)"/>
public static unsafe ref ITEMIDLIST ILCreateFromPath2(string pszPath)
{
    fixed (char* pszPathLocal = pszPath)
    {
        ITEMIDLIST* __result = ILCreateFromPath(pszPathLocal);
        return ref *__result;
    }
}

Describe alternatives you've considered
Using ITEMIDLST* directly, but that requires annotating a method with unsafe or using unsafe blocks.
Additional Context
ILCreateItemFromPath^1 returns PIDLIST_ABSOLUTE which, per documentation^2, needs to be freed with ILFree.
Assuming that the returned ITEMIDLIST pointer needs to be freed, instead of its value, ILFree would need to change as well:
From:
public static unsafe void ILFree(ITEMIDLIST? pidl)
{
	ITEMIDLIST pidlLocal = pidl.HasValue ? pidl.Value : default(ITEMIDLIST);
	ILFree(pidl.HasValue ? &pidlLocal : null);
}

to either or both option:
public static unsafe void ILFree(ref ITEMIDLIST pidl)
{
    fixed (ITEMIDLIST* pidlLocal = &pidl)
    {
        ILFree(pidlLocal);
    }
}
public static unsafe void ILFree(in ITEMIDLIST pidl)
{
    fixed (ITEMIDLIST* pidlLocal = &pidl)
    {
        ILFree(pidlLocal);
    }
}

Avoiding unsafe isn't a goal of CsWin32, as interop is fundamentally unsafe anyway. And unsafe C# code is often easier to read and get right than "safe" code anyway. Just look at pointers vs. IntPtr uses in interop code.
That said, ref return is an interesting idea. But case in point, if a null result is expected, checking for null is much harder to discover with ref return per your example than if a pointer were returned. It also looks like you just have a reference to a struct, which doesn't scream "you might need to free this" to avoid a memory leak. So I'm honestly seeing more negatives than positives with this proposed change.

After figuring out what I really want with this proposal I think it really is not really viable, and requires specific, project dependent code to work properly.
Like this struct^1 which can be used as a container, just like SafeHandles could, but without the need to generate heap objects. Requires IL manipulation and some quirks to get around, but can be used with "safe" code.
Maybe went too far to get C++/WinRT-style *_handle-types in C#.
Though I think I prefer handle types to behave more like this^2 (without the assignment/conversion magic), which can be used rather easily^3.
Closing here, unless there is some viability to the latter option, which I don't think will happen (as it is niche to the project I'm using it in).


⚠ Samsung has degraded performance

In e2be0eb, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1832 ms

Resolved: Samsung performance has improved in 65a99b2.


error due to absolute paths in distributed package

Issue Description
Module not found: Can't resolve '/Users/johniak/Projects/react-web-gifted-chat/node_modules/@babel/runtime/helpers/esm/assertThisInitialized' in '/home/katie/repos/ampere/walnut-web/node_modules/react-web-gifted-chat/dist'

Thanks, there was problem with babel building, fixed in 0.0.6


item cooldown visuals break sometimes

Description

Reproduction

No idea how to reproduce it 100% of time, just use some item with cooldown multiple times. It often breaks when using bible.
Screenshots

Additional context

ive had this happen with bike horn before too, thought it got fixed


Trying to add more command on meitrack but end with error on traccar-web

hello...
i'm trying to add a new custom command to Meitrack device, but it end with 404 page not found on sending command at traccar-web
here is the screenshot:

here is my modification:
model/Command.java
...
public static final String TYPE_DOORLOCK_OPEN = "doorLockOpen";
public static final String TYPE_DOORLOCK_CLOSE = "doorLockClose";
...

protocol/MeitrackProtocol.java
public MeitrackProtocol() {
        super("meitrack");
        setSupportedDataCommands(
                Command.TYPE_POSITION_SINGLE,
                Command.TYPE_ENGINE_STOP,
                Command.TYPE_ENGINE_RESUME,
                Command.TYPE_ALARM_ARM,
                Command.TYPE_ALARM_DISARM,
                Command.TYPE_REQUEST_PHOTO,
                Command.TYPE_SEND_SMS,
                Command.TYPE_DOORLOCK_OPEN,
                Command.TYPE_DOORLOCK_CLOSE);
}

protocol/MeitrackProtocolEncoder.java
protected Object encodeCommand(Command command) {

        Map<String, Object> attributes = command.getAttributes();

        switch (command.getType()) {
            case Command.TYPE_POSITION_SINGLE:
                return formatCommand(command, 'Q', "A10");
            case Command.TYPE_ENGINE_STOP:
                return formatCommand(command, 'M', "C01,0,12222");
            case Command.TYPE_ENGINE_RESUME:
                return formatCommand(command, 'M', "C01,0,02222");
            case Command.TYPE_DOORLOCK_CLOSE:
                return formatCommand(command, 'M', "C01,0,21222");
            case Command.TYPE_DOORLOCK_OPEN:
                return formatCommand(command, 'M', "C01,0,20222");
            case Command.TYPE_ALARM_ARM:
                return formatCommand(command, 'M', "C01,0,22122");
            case Command.TYPE_ALARM_DISARM:
                return formatCommand(command, 'M', "C01,0,22022");
            case Command.TYPE_REQUEST_PHOTO:
                return formatCommand(command, 'D', "D03,1,camera_picture.jpg");
            case Command.TYPE_SEND_SMS:
                return formatCommand(command, 'f', "C02,0,"
                        + attributes.get(Command.KEY_PHONE) + "," + attributes.get(Command.KEY_MESSAGE));
            default:
                Log.warning(new UnsupportedOperationException(command.getType()));
                break;
        }

        return null;
    }

after this modification i compile the traccar using "mvn package"
any idea?

I suspect that there is some incompatibility between your back-end and web app.


Node.js 12 actions are deprecated

When using this action as part of a workflow, the following deprecation notice is generated:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16<EMAIL_ADDRESS>
And this:
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

could you update all your dependencies to the latest version?

Thanks for reporting this. I have updated the dependencies accordingly.