History works wrong.

Your description here
Expected outcome
History in order
What should happen?
Actual outcome
History not in order
What happened?
Versions
App: <IP_ADDRESS>9-stable
Chrome: 54.0.2840.71
Platform: Windows (10)
Steps to reproduce

Hi,
Thank you for the issue report.
Can you provide the screenshot of the history where it's ordered wrong? I'm can't reproduce order issues

This dates ar wrong, this requests shown are at least 6 month old.
If its usefull as to track the bug, the problem began just after the update.

I'm not sure if I can fix it now. It looks like the history items do not have time signature attached and therefore are pushed to the top of the list (as Indexed db would order it). For some reason during the update the time wasn't passed to new objects.
Each of this list items should have an hour of execution displayed (like the two in the middle).
I'll try to correct it somehow but I'm not sure why it hasn't time in the first place.
Can you debug the app as show me a structure of one of this items in the data explorer? It should be here:

Note that it might be the latest item in the datastore. It would help me with more debugging.

Alternately you can try to run this command in the console:
chrome.storage.local.remove('upgrades')

And restart the app. this will remove all data in the new databases and recreate the data from the old database
It means that if you have saved some data since the upgrade they will be removed. But you may ise import / export options to saved data to file.

Hope it helps

chrome.storage.local.remove('upgrades') --> I used it. After starting the app again it downloads the update again and same problem.

I'm really sorry but I've pasted wrong database screenshot. History data that is showed on the history list is in the _pouch_history-requests database. I'am only interested if object has updated property set to a number (timestamp) and if the first part of the key is a number (something like<PHONE_NUMBER>000).

The updatedproperty is important because the app is sorting data on this property. The it uses first part of the key to compute header for history section.
I may have an explanation if the updated property is not set in the database. But if it is it may mean something different. So can you please send it again for right database?

jarrodek tomorrow ill send you the screen shot, i am in a dificult day today!!

Believe you were right, the problem is the updated url

Thank you for the update. It looks like there was an issue during the update and the app didn't moved properties as designed. I'll try to find a fix for this issue very soon.

Hi,
Two things.
I've managed to fix the issue in the code. Now it will check if the updated property exists before showing the data. It will use created instead if now. It's not that accurate like updated but there might be difference between minutes / hours because the history object is created once per day.
The fix will be published soon.
If you'd like to do it manually (meaning faster), you can use gist that I've  prepared for you: https://gist.github.com/jarrodek/ff0bedf1e006a215485898b22339a701
It will update the updated value if required.
Fix will be published soon.


Failures of XSS e2e-tests on Saucelabs

Challenge tests for XSS3 and XSS4 (which inject the alert script via REST API and then go to the attacked screen to verify success) are very brittle. They work fine locally but fail very often on SauceLabs.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6303548-failures-of-xss-e2e-tests-on-saucelabs?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6283055&utm_medium=issues&utm_source=github).

Did not occur for quite a while, at least not noticably. Re-open if problem returns.


Discussions

This issue is specially opened for discussion. Here, you can feedback some problem such as install problem when you install FATE or new feature which you think is important for you.
Finally， hope to use English to ask your questions.
Thanks.
dylanfan

When you installed FATE ,  What was the worst experience?

For some cooperative partners, docker for cluster is necessary, because they have to ask for more physical computers. This may cost more time and resources for them but just experience FATE they want.

@dylan-fan
hi,can you give a sketch to explain the relationship between the various components in the cluster mode? I don't quite understand how to deploy a cluster.

After installed the packages, I tried to run  "sh run_logistic_regression_standalone.sh". But it is extremely slow. it keeps printing something like
cat: /fate/examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/workflow.log: No such file or directory
please wait or check more info in /fate/examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/workflow.log
In general, how lone does it takes to run the program? Is there any way to accelerate the process? Thanks.

@cacoderquan It should be completed in one minute. If not, could you please check logs in this path: /fate/examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/   and see if there is a status_tracer_decorator.log file exist and see if there is error in it? Or, is there any error info in nohup file in your current path?

@tanmc123 Thanks. But could you tell me how to go to /fate/examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/
I type cd examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/  but got errors like
root@f94b7a1fdfe7:/fate# cd examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/
bash: cd: examples/homo_logistic_regression/../../logs/logistic_regression_example_standalone_20190528090656/: No such file or directory
r

@cacoderquan well, in your current path, you can just type cd ../../logs/logistic_regression_example_standalone_20190528090656/

Thanks. But I type cd ../../logs/hetero_logistic_regression_example_standalone_20190529012020/
it does not work(I use another container)
root@45c7dd1d05a1:/fate# cd ../../logs/hetero_logistic_regression_example_standalone_20190529012020/
bash: cd: ../../logs/hetero_logistic_regression_example_standalone_20190529012020/: No such file or directory

find there is a new logs directory, but could not find any results under it.

root@45c7dd1d05a1:/fate# ls
Dockerfile  arch  data  examples  federatedml  logs  requirements.txt  workflow
root@45c7dd1d05a1:/fate# cd logs
root@45c7dd1d05a1:/fate/logs# ls
root@45c7dd1d05a1:/fate/logs#

@tanmc123

You should be able to see three nohup files in your example/homo_logistic_regression folder. Please see if there is any error info in one of them.

config path is /fate/examples/hetero_logistic_regression/conf/guest_runtime_conf.json_hetero_logistic_regression_example_standalone_20190529012020
jobid is hetero_logistic_regression_example_standalone_20190529012020
Traceback (most recent call last):
File "/fate/arch/api/utils/file_utils.py", line 40, in load_json_conf
with open(json_conf_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/fate/arch/conf/server_conf.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "../../workflow/hetero_lr_workflow/hetero_guest_workflow.py", line 22, in
from workflow.workflow import WorkFlow
File "/fate/workflow/workflow.py", line 52, in
from workflow import status_tracer_decorator
File "/fate/workflow/status_tracer_decorator.py", line 30, in
server_conf = file_utils.load_json_conf("arch/conf/server_conf.json")
File "/usr/local/lib/python3.6/site-packages/cachetools/init.py", line 46, in wrapper
v = func(*args, **kwargs)
File "/fate/arch/api/utils/file_utils.py", line 43, in load_json_conf
raise EnvironmentError("loading json file config from '{}' failed!".format(json_conf_path))
OSError: loading json file config from '/fate/arch/conf/server_conf.json' failed!

seems there is some error on loading json file config

@tanmc123  this confuses me because I look at server_conf.json which has no problem (as below)
{
"servers": {
"roll": {
"host": "localhost",
"port": 8011
},
"federation": {
"host": "localhost",
"port": 9394
},
"manager": {
"host": "localhost",
"http.port": 9380,
"grpc.port": 9360
},
"servings": [
"<IP_ADDRESS>:8000"
],
"proxy": {
"host": "localhost",
"port": 9370
}
}
}

@tanmc123 I tried to debug it, but could not find any solutions. Could you give me some hint/suggestions ? Thanks a lot!

@cacoderquan Have you add /fate into you PYTHONPATH enviroment?
Like
export $PYTHONPATH=/fate

I have added /fate into my PYTHONPATH enviroment but still get the same error
root@d28bbf5328ac:/fate/examples/hetero_logistic_regression#  echo $PYTHONPATH
/fate
root@d28bbf5328ac:/fate/examples/hetero_logistic_regression# ls
conf  kill.sh  run_arbiter.sh  run_guest.sh  run_host.sh  run_logistic_regression.sh  run_logistic_regression_cluster.sh  run_logistic_regression_standalone.sh
root@d28bbf5328ac:/fate/examples/hetero_logistic_regression# sh run_logistic_regression_standalone.sh

@tanmc123

Hello, I am running the test with 'sh ./federatedml/test/run_test.sh', the error is as follows：
File "project/FATE/arch/api/standalone/eggroll.py", line 104, in _open_env
return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=10_737_418_240)
SyntaxError: invalid syntax
When I changed the code at FATE/arch/api/standalone/eggroll.py", line 104 to ‘    return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=(10_737_418_240))’，The error has become ‘ File "/project/FATE/arch/api/standalone/eggroll.py", line 104, in _open_env
return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=(10,737,418,240))
TypeError: unorderable types: tuple() >= int()’
So I would like to ask you what is the reason, thank you!

Hello, I am running the test with 'sh ./federatedml/test/run_test.sh', the error is as follows：
File "project/FATE/arch/api/standalone/eggroll.py", line 104, in _open_env
return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=10_737_418_240)
SyntaxError: invalid syntax
When I changed the code at FATE/arch/api/standalone/eggroll.py", line 104 to ‘ return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=(10,737,418,240))’，The error has become ‘ File "/project/FATE/arch/api/standalone/eggroll.py", line 104, in _open_env
return lmdb.open(path, create=True, max_dbs=1, max_readers=1024, lock=write, sync=True, map_size=(10,737,418,240))
TypeError: unorderable types: tuple() >= int()’
So I would like to ask you what is the reason, thank you!

@wkzsgxxn Can you tell me the python version?  It seems that python env is a litter old, which does not support  "map_size=10_737_418_240". To support this syntax it should be update to python 3.6 or higher.

config path is /fate/examples/hetero_logistic_regression/conf/guest_runtime_conf.json_hetero_logistic_regression_example_standalone_20190529012020
jobid is hetero_logistic_regression_example_standalone_20190529012020
Traceback (most recent call last):
File "/fate/arch/api/utils/file_utils.py", line 40, in load_json_conf
with open(json_conf_path) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/fate/arch/conf/server_conf.json'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "../../workflow/hetero_lr_workflow/hetero_guest_workflow.py", line 22, in
from workflow.workflow import WorkFlow
File "/fate/workflow/workflow.py", line 52, in
from workflow import status_tracer_decorator
File "/fate/workflow/status_tracer_decorator.py", line 30, in
server_conf = file_utils.load_json_conf("arch/conf/server_conf.json")
File "/usr/local/lib/python3.6/site-packages/cachetools/init.py", line 46, in wrapper
v = func(*args, **kwargs)
File "/fate/arch/api/utils/file_utils.py", line 43, in load_json_conf
raise EnvironmentError("loading json file config from '{}' failed!".format(json_conf_path))
OSError: loading json file config from '/fate/arch/conf/server_conf.json' failed!

Do you fix that? I got same problem with you.

@wwwwww1020
Thank you very much for your feedback. This is an omission. We have submitted a PR to fix it. If it is more urgent, we can do this:

Delete the generated docker container and image.
2, pull the code.
Modify the build_standalone_docker.sh code and change "git archive -o ./docker/standalone/fate.tar $(git rev-parse HEAD) arch/api federatedml workflow examples" to "git archive -o ./docker/standalone /fate.tar $(git rev-parse HEAD) arch federatedml workflow examples".
Rebuild a docker.
Try again, thank you

@wwwwww1020
Thank you very much for your feedback. This is an omission. We have submitted a PR to fix it. If it is more urgent, we can do this:

Delete the generated docker container and image.
pull the code.
Modify the build_standalone_docker.sh code and change "git archive -o ./docker/standalone/fate.tar $(git rev-parse HEAD) arch/api federatedml workflow examples" to "git archive -o ./docker/standalone /fate.tar $(git rev-parse HEAD) arch federatedml workflow examples".
Rebuild a docker.
Try again, thank you


logLevel:'debug'  does not take effect in vue-cli5

Checks

[X] I understand project setup issues should be asked on StackOverflow or in GitHub Discussions.
[X] I updated to latest http-proxy-middleware.

Describe the bug (be clear and concise)
In the Vue project created by vue-cli5, I configured the proxy's loglevel: 'debug', but it did not print any logs on the console.Proxy is actually in effect.
I try to print in the source code.It can print.However, this.logger.debug method does not print.
this.prepareProxyRequest = async (req) => {
            // https://github.com/chimurai/http-proxy-middleware/issues/17
            // https://github.com/chimurai/http-proxy-middleware/issues/94
            req.url = req.originalUrl || req.url;
            // store uri before it gets rewritten for logging
            const originalPath = req.url;
            const newProxyOptions = Object.assign({}, this.proxyOptions);
            // Apply in order:
            // 1. option.router
            // 2. option.pathRewrite
            await this.applyRouter(req, newProxyOptions);
            await this.applyPathRewrite(req, this.pathRewriter);
            // debug logging for both http(s) and websockets
            if (this.proxyOptions.logLevel === 'debug') {
                const arrow = (0, logger_1.getArrow)(originalPath, req.url, this.proxyOptions.target, newProxyOptions.target);
                console.log('[HPM] %s %s %s %s', req.method, originalPath, arrow, newProxyOptions.target);
                this.logger.debug('[HPM] %s %s %s %s', req.method, originalPath, arrow, newProxyOptions.target);
            }
            return newProxyOptions;
        };

Step-by-step reproduction instructions
1. Configure agent in vue-cli5 project logLevel: 'debug'
2. Start project and request interface

Expected behavior (be clear and concise)
When I configure loglevel: 'debug', I should print the relevant logs on the console when I call the interface through inversion.
  devServer: {
    https: false,
    proxy: {
      '/container-api': {
        target: 'http://***.***.***.204:30080',
        pathRewrite: { '^/container-api': '' },
        changeOrigin: true,
        logLevel: 'debug'
      },
    }
  },

How is http-proxy-middleware used in your project?
Configure the proxy directly in the Vue project created by vue-cli5

What http-proxy-middleware configuration are you using?
const { defineConfig } = require('@vue/cli-service')
module.exports = defineConfig({
  transpileDependencies: true,
  devServer: {
    https: false,
    proxy: {
      '/container-api': {
        target: 'http://***.***.***.204:30080',
        pathRewrite: { '^/container-api': '' },
        changeOrigin: true,
        logLevel: 'debug'
      },
    }
  },
})

What OS/version and node/version are you seeing the problem?
chrome. windows 10 and Node 16.8.0

Additional context (optional)
No response

console.debug is only visible with node --inspect
Explained in: https://stackoverflow.com/a/47147123/3841188
Logging has been improved in v3 (still in beta) of http-proxy-middleware. And will only use info, warn and error for better compatibility: https://github.com/chimurai/http-proxy-middleware/blob/master/src/logger.ts

Closing stale issue.
Feel free to re-open.


[mBART/BART] finetuned model is much bigger than pretrained model.

🐛 Bug
Hi,
I'm using mBART from fairseq and the file size of finetuned mBART is way bigger than I expected. Does anyone know why finetuned mBART is a lot bigger than pretrained mBART?

Model
Description
# params
Download

mbart.CC25
mBART model with 12 encoder and decoder layers trained on 25 languages' monolingual corpus
610M
mbart.CC25.tar.gz

pre-trained mBART size:  5.7G
finetuned mBART size: 8.8G

I'm observing similar issue with BART-large finetuned on CNN/DM dataset.
My own fine-tuned checkpoint is bigger than the checkpoint provided by the authors.
Also inference time seems to be slower when using my own fine-tuned checkpoint than when using the checkpoint provided by the authors.
Any idea where it comes from ? And how to fix ?
@ngoyal2707 @yinhanliu

Checkpoint files usually include the optimizer state, which for Adam is 2x the number of model parameters, thus the larger file sizes. We usually strip these from the released models since the optimizer state is only needed if you’re going to continue pretraining.


Obitools first version

Hi GTN!
A first draft version of Obitools eDNA / metabarcoding tutorial, from this history: https://ecology.usegalaxy.eu/u/ylebras/h/tuto-obitools

Ready for review!

I deploy the tuto on gitpod here https://4000-yvanlebras-trainingmater-jrjwol3w7sv.ws-eu32.gitpod.io/training-material/topics/ecology/tutorials/Obitools-metabarcoding/tutorial.html if it can help ;)

I got stuck with obigrep (failing) but I guess that's mostly because I don't fully understand the tutorial (not my topic)!

in fact there is missing parameter for input datasets on several tool steps! I fix it! Here you need to take illuminapairedend output file BUT there is a comment box to say that if you can't select it on the input sequence file parameter of obigrep, you need to use fastq GROOMER to change fastq to fastqsanger datatype for illuminapairedend output file...

obitools_team seems to be undefined, maybe add them at the very end of the CONTRIBUTORS.yaml, there's a couple other "group" entities there and someday I'll move them to another file

obitools_team seems to be undefined, maybe add them at the very end of the CONTRIBUTORS.yaml, there's a couple other "group" entities there and someday I'll move them to another file

yes, I sent an e-mail to obitools colleagues but no answers for now... So I think in a first appraoch I can "just" put<EMAIL_ADDRESS><EMAIL_ADDRESS>....

Sounds good!

I don't find github username for colleagues... I found a gitlab one for Eric https://git.metabarcoding.org/coissac do you have any suggestion / help / comment on how to add contributors if they don't have a github account ?

It's fine if they don't have a github username, if they don't just put github: false when you add them to the CONTRIBUTORS.yaml (and make up a 'username' for them.)

c'est vert!! Wonderful!

Hey hey! It appears to me I adressed all comments, thank you so much Anne, Cristobal !!!!

it appears I have an issue with an URL:
(https://pythonhosted.org/OBITools/welcome.html) is an invalid URL
Any idea @hexylena ? Do you think we an merge afterthat?

Congrats @yvanlebras et al!

:tada:


The DataTable keeps rerender when y use a component

The DataTable keeps rerender when y use a component in a column
Describe the bug
As the title says if y use a component in the column the database will keep rerender when y scroll up/down
To Reproduce
Y can use the code in the example to reproduce the error
  import { Center, Text } from "@mantine/core";
  import { DataTable } from "mantine-datatable";
  import { useEffect, useState } from "react";

  function App() {
    const [companies, setCompanies] = useState<any>([]);

    useEffect(() => {
      Array.from({ length: 100 }).forEach((_, index) => {
        setCompanies((data: any) => [
          ...data,
          {
            id: Math.random(),
            name: `Company ${index}`,
            streetAddress: `Street Address ${index}`,
            city: `City ${index}`,
            state: `State ${index}`,
          },
        ]);
      });
    }, []);
    return (
      <Center w={"100%"} >
        <DataTable
          height={"50vh"}
          idAccessor={"id"}
          columns={[
            {
              accessor: 'name',
              render: ({ name }) => <TextTranslate i18nKey={name} />,
            },
            {
              accessor: 'streetAddress'
            },
            {
              accessor: 'city'
            },
            {
              accessor: 'state'
            }
          ]}
          records={companies}
        />
      </Center>
    );
  }

  export default App

  export type TextTranslateProps = {
    i18nKey: string;
  }
  export function TextTranslate({ i18nKey }: TextTranslateProps) {
    console.log("Render TextTranslate");
    return (
      <Text >
        {i18nKey}
      </Text>);
  }

Sorce code https://github.com/Kenya-DK/mantine-datatable-bug
Expected behavior
I am not sure what the expected behavior is, but the database should not keep rerendering when y scroll up/down the DataTable component
Screenshots
https://i.imgur.com/rAkDfQk.gif
Desktop (please complete the following information):

OS: Windows 11
Browser Brave Happens in Tauri as well
Version Version 1.69.153 Chromium: 128.0.6613.85 (Officiel version) (64-bit)
Node v20.9.0

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

Download https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU In the installer menu, select "gcc."

And that is

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

Download
https://mega.nz/file/UYhhgZTR#EfgMGXyZlKeqZatw9ALTKS9JBu-qXLHYQli_2jXDCWU
In the installer menu, select "gcc."

I have the same issue with v7.11.3

I just tested it out today and I can also experience this issue. Components used inside the table keeps rerendering on scroll

Reported this in #625 but there's been no response, it's likely due to the recent merge with row reordering but not entirely sure, if you revert back to v7.11.2 it should be good for now.

@mehdiraized and @MohdAhmad1, can you please have a look at this?
Thanks a lot!

This and #625 should be fixed in v.7.12.3.
Please note that some rerendering is expected to happen when scrolling, though (i.e. when the underlying scroll area is scrolled to top to to bottom).


feat: add css-3d-progress

Please add it to the miscellaneous category as there are no other components for the same type.


Support and test fma, fma and fmna for complex number

Fix #387

@JohanMabille no compilation issue ;-)


Add Windows support

[x] Upgrade FindMathematica to version 3.2.5.
[x] Upgrade linenoise to linenoise-ng as submodule.
[ ] Update the documentation to mention using git submodule update --init.
[ ] The linenoise-ng contains multiple licenses and I added it as a submodule, maybe the LICENSE file need not be copied to the root directory.
[x] Also could you test it under macOS or Linux to make sure it doesn't break?

Hi @rljacobson , I wonder if you can help me with the last two items?

Awesome! It seems to work on my Macs.
I think we should add popl and FindMathematica as a submodules, too, while we're at it. I'll do that as a separate commit along with the license and README changes you suggested. Good ideas.


fix for dev web server

this breaks production builds -- closing

Thanks @hellofornow for trying something here! Yeah it's weird - some browser-sync config thing.


Use Kafka as message broker inside our stack, with an mqtt bridge for outside communication

Is your feature request related to a problem? Please describe.
Using Vernemq or emqx leads to various problems inside our stack, due to there unreliability.
Also using Kafka removes the need for us to buffer incoming messages, per microservice and instead lets Kafka do that.
Subissues:

[x] #677
[x] #639
[ ] #640
[x] #670
[ ] #692
[x] #743
[ ] #724

Blocker

[x] #674

Move together with #625 and use it as next version v0.8.0 (instead of database, #629 )
v0.8.0

one Helm chart
incl. Kafka
incl. kafka microservices as preview
fully working
basically kafka doing nothing

Move together with #625 and use it as next version v0.8.0 (instead of database, #629 )
v0.8.0

one Helm chart
incl. Kafka
incl. kafka microservices as preview
fully working
basically kafka doing nothing

Let's use the existing kafka-to-blob as testing. v0.8.0 is working when we can set it up, it shows no errors and stores images in the blob storage for 2 days in a row without crashing. Even if it crashes no messages are lost.


[MI-2032]: Used separate goroutines to delete users when encryption secret is being changed

PR is made on the mattermost #145


Fix AuthMethodPickerActivity title being "ui_flow" instead of app name

We want it to be overridden.

Hey, we should probably document this since we're requiring an app_name string to override the library's. Is the best idea for usability, though?

@SUPERCILEX there was no behavior change in recent versions regarding app_name right?

@samtstern Nope, we've always used app_name because it's the default thing for AppCompat. We should probably put it on our mental list of stuff to fail the build in v3.0 if the dev doesn't supply it.


Validate Ingress before adding it to the cache: Avoid duplicated domains

/hold waiting to verify it works as expected.

/hold
needs to be on its own line 😬

oh! maybe not anymore?!?!

oh! maybe not anymore?!?!

I wasn't sure! but the bot actually added the do-not-merge/hold :)

/test pull-knative-net-kourier-integration-tests
TestUpdate failed. Retrying to get more info.

/unhold

/lgtm
/approve


WIP: Docker open ldap

Releated issue.

[x] working OpenLDAP in docker container
[ ] working Slurmdb in docker container
[ ] directory management

Update to slurm docker
I have fiddle around with  https://github.com/giovtorres/slurm-docker-cluster to provide containers as slurm cluter for app. I managed to get the app work to add/list users in the slurmdb. However I need to write an extra docker compose and DockerFile inherting from the Dockerfile and compose file of https://github.com/giovtorres/slurm-docker-cluster .
Reasons

Need for static IP address on docker container. Our app needs that for the head node address.
Need to augment Docker image https://github.com/giovtorres/slurm-docker-cluster by OpenSSH daemon and ensure generating ssh host keys, and root user with know password of docker container. Our app connects via ssh !
Need to ensure spec Account=student exits in slurmdb before adding user.

Try accessing container via internal hostname (i.e. service name in docker compose).

Try accessing container via internal hostname (i.e. service name in docker compose).

Is not possible by default from the host to a docker container. By default only docker container can address each other via hostname or container name. Hostnames however are not visible to host machine. Would need separated dns service started or adjusted host file on host machines. Static ip address, assigned via docker compose file, works just fine.

Problems with implementing user directory management in the docker container for development

setquota does not work because I can not get any mount point mounted with the required mount options
for disk quota !
Creating directory for user does not work because there is no local unix user in a docker container.

Suggestion to the problem
These are the following workarounds:

Do not implement user management system in development environment. The PR would be considered done at this point.
Do implement without setting quota in development environment and
create local Unix user over ssh before creating directory, because
It could take a while until it works with pulling user from LDAP db in LDAP docker container for the Linux PAM system.


Heos by Marantz and Denon

It doesn't appear to work with HEOS.

What is not working ? Please define your steps...
Anything helpful in your logs that give me a clue ?

I had a quick peek at the source code of the Heos integration in HA and that should theoretically work fine with Music Assistant. So it would really help if you provide a step for step walkthrough what you did and where it went wrong and if you see any errors somewhere.

@chrismdann can you share some more info what is not working otherwise I'll have to close this report

closed due to no response


stopping nomad with SIGKILL

Hi Brian!
I've noticed that in here you are stopping nomad with SIGKILL signal.
Is it a recommended way to stop nomad?

Hi!
That's probably a holdover from older times and should be fixed.
By default, any signal to a Nomad agent (interrupt, terminate, kill) will cause the agent to forcefully stop anyway. I need to handle termination with leave_on_interrupt or leave_on_terminate in the server configuration and fix up that init script.
Sorry for huge lag; I was not watching this repo 😬

Fixed in release 1.4.5
Thanks again for the report!


replacement: query params

https://github.com/ef4/tracked-params
not sure how official this is though

not sure -- all the router stuff is kinda up in the air and opaque to me -- I watch discord like a hawk, but no one is saying anything

supposedly there is a meeting, but I've yet to be invited. Although I'm not that important, so 🤷🏼

I'd just like to see some sort of meeting notes :sweat_smile:
what's happening?
what's being explored?
what's planned?
what are folks deciding that the requirements are?
etc


Update .gitignore to ignore Makefile-created files.

Please consider the attached patch. This updates .gitignore so that "git status" will be empty after building a model following the README. Thanks.

Accepted.  Please switch to the main repository for future work: https://github.com/chipsalliance/Cores-SweRV


Frontend API explanation missing

In this document it says frontend API related more explanation is available in the documentation linked here. But there's no such explanation.
It's better if we can have a explanation in the mentioned page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 76ca8cff-348b-5595-1c3a-f319d606f82e
Version Independent ID: 5930a3f8-45f7-e782-f917-0235601f873b
Content: Tutorial - Import and publish your first API in Azure API Management
Content Source: articles/api-management/import-and-publish.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@slahirucd7
Thanks for your feedback! We will investigate and update as appropriate.

@slahirucd7 Frontend API has been clearly described in https://learn.microsoft.com/en-us/azure/api-management/api-management-terminology#term-definitions and for more info link is about how to import and publish an API (i.e., Frontend API) in APIM.

@dlepow I think it may be good to change with better description. Your thoughts?

@slahirucd7 We will proceed to close this thread and feel free to add a comment for any other questions. Thanks again for sharing the feedback.


dnn_models directory

Should there be a standardized location in dlib, or perhaps an associated dlib_models repository, for users to share common published SOTA DNN network definitions?  This would essentially be a collection of header files containing matched training and inference template definitions for a particular model that could be used in custom apps or as alternative models within the existing tutorial examples.
Users will likely want to copy and tune models for their needs, but having a collection of common model definitions would be useful as a starting point for prototyping and code reuse.  I was implementing a couple mobile friendly models recently, and thought they might be of interest to other users, but didn't really see a good place to put them in dlib.  These don't illustrate any new core functionality, and don't seem to warrant adding a new example, but they could be used as alternatives within the existing examples, such as dnn-imagenet_train_ex.

You could submit to https://github.com/davisking/dlib-models

dlib-models is currently lacking a directory for the associated network definitions, so perhaps we could add something like dlib-models/dlib/dnn_models/some_model_name.h (or similar).
The main issue I see with using dlib-models for this, is that the serialized model weights tend to be large, of course, and there are already serialized models stored in git at that location.  If we store both the network definition header files (<= 4K) and the serialized model weights (1 MB - 500 MB) in the same git repo, I can see the size overhead making that location somewhat less user friendly from the perspective of having a package of pre-defined network definitions that can be used easily in our projects.
I was thinking of supporting a use case from CMake like this (similar to dlib):
find_package(dlib_dnn_models CONFIG REQUIRED)
target_link_libraries(my_app dlib::dnn_models) # or whatever name is preferred

which would be our closest C++ option to the import that is typically used to grab common network definitions in the python oriented deep learning frameworks.
In main.cpp, we would do something like this:
#include <dlib/dnn/trainer.h>
#include <dlib_contrib/squeezenext_1_23v5.h> // or whatever name is preferred
#include <dlib_contrib/resnet_50.h> // etc

// <SNIP>

int main(int args, char **argv)
{
    // train with squeezenext_1_23v5_train

    // predict w/ squeezenext_1_23v5_test, or whatever template alias naming convention makes sense
}

For that use case, it seems a different repo, or possibly a top level directory in the main dlib repository might be preferable.  If you prefer to keep model definitions out of the main repo, it might make sense to start something like dlib_contrib where the lightweight network definitions could be stored, and the associated large binary serialized models could be placed in GitHub asset storage (outside of git).  If you still prefer adding the headers to dlib-models, I think it would still be a good start.

@fourier79 : Have you seen @reunanen 's #1600 ?

I don't really want to get into the business of hosting models for people.  My general take on this is that people who want the models can download them and then stick them into whatever source/data control system they want to use, and that is up to them.
It's also possible to download individual files from a github repo.  You don't have to grab them all.

Although I should clarify, people can submit models to this repository.  But I don't want to be on the hook for people's build/data management systems.


Use v3 of codecov GitHub action

I'm observing a lot of:

Error: Codecov: Failed to properly upload: The process '/Users/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255

recently. Unfortunately, this seems to be a hard to reproduce bug, as it sometimes happens and sometimes not. Reading through some codecov issues:

https://github.com/codecov/codecov-action/issues/ 837
https://github.com/codecov/codecov-action/issues/ 598

(remove the space that was added to not spam those issues)
Updating their action to v3 was mentioned as a possible solution.

Ready for review @skops-dev/maintainers


[CSSimplify] Adjust isBindable to reject binding if it's directly t…

…o a type variable
Although inference doesn't allow direct bindings to type variables,
they can still get through via matchTypes when type is a partially
resolved pack expansion that simplifies down to a type variable.

@swift-ci please smoke test

@swift-ci please smoke test Linux platform


Support for related records

As a user, I would like to be able to select an existing point/polyline/polygon in the geoform map, and have the form capture a new record against this feature (i.e. in a related table).

Use-cases:
Capturing public feedback about areas of land
Capturing asset assessments against an asset feature
I am aware that this workflow is available in Collector and Survey123, but requirements here are for a web app.
More specific background:
Client has a web app built in app builder.
This allows users to

Search for areas of land they want to comment on (via a layer level search setup on the webmap)
From the popup, launch their geoform to record feedback.

What the client wants:
Update geo-form to automatically match extents, centre the base map and pre-select the land parcel within the Application Form to match the selected parcel in the app home page.
This will streamline the workflow to avoid users having to re-navigate back to the parcel of land that they selected when they first decided to proceed to the expression of interest page.
Related Issues:
#177
#351

I'd love this functionality as well.

👍


Fix for candidate journey tracker export

Context
This report is broken in production.
https://sentry.io/organizations/dfe-bat/issues/2067746769/?environment=production&project=1765973&query=is%3Aunresolved
This is due to missing audit entries that this report depends on to work out the received_at value for provided references.
Changes proposed in this pull request
This is a workaround that adds some defensive code to handle missing audit entries. Follow up investigation needed to find out why they are missing.
Guidance to review
Does this look like a reasonable workaround? Is there anything else we can do to handle missing audit entries?
Link to Trello card
https://trello.com/c/ZmyAYz38/2652-fix-and-investigate-why-candidate-journey-tracker-export-is-broken
Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

my bad sorry about that!

Not at all. Was a reasonable assumption and may have flagged an issue with the audit log.


Feat(style): match with tc 39 website

Thanks for the suggestion, but I don't think we want to change the styling at this time.


Add_a_gcp_sumologic_module_for_cloudlogging

This PR introduces a module for sending project wide logs from Google Cloud Platform to Sumologic.
The code has been tested and is actively being used in both GCP and
SumoLogic.
I was not sure about two thngs:

Where to put the examples. Normally they would
reside inside the module as a subfolder but I can move them to the main
"examples" folder.
Do I need to push a change regarding a new release for this module.

Looking forward to collaborating with you!
Thank you!

Changes look good, thanks for adding the GCP support.

You are correct, examples normally go within the module sub folder. We will eventually move all the examples into similar structure so you can keep the example with in the module.
I will create a new release once the changes are merged.

Thank you @arunpatyal !
I will do some more testing to ensure that the module is behaving as its supposed to.
There might be some subsequent small PRs/Changes if there's an issue.
Again, thank you for your support!


Error code: Wsl/Service/CreateInstance/CreateVm/0x8007000d in windows 11

Windows build number:
22499.rs_prerelease.21105-155
Your Distribution version:
20.04
Your WSL versions:
wsl --version
Versão do WSL: <IP_ADDRESS>
Versão do kernel: <IP_ADDRESS>
Versão do WSLg: 1.0.45
Versão do MSRDC: 1.2.3575
Versão do Direct3D: 1.606.4
Versão do DXCore: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows versão: 10.0.22499.1010
PS C:\Users\neuberfran> wsl -l
Distribuições do Subsistema do Windows para Linux:
Ubuntu-20.04 (Padrão)
Debian
My issue(specifications):
I have windows 11 here with issue:
(Look pic)
Error code: Wsl/Service/CreateInstance/CreateVm/0x8007000d
(Look pic)
When I change date to 14.09.2022 I solved this issue.
But that's not what I want
I can't update my windows because I have i7 2600. I can't reinstall too
How to solve my issue?
Pls

You are on a quite old prerelease build - you'll have to either install a retail build or update.

@benhillis I can't update. I tried several things here


Create gomalle

@vsma-gomalle Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Sklearn update changes

This PR accommodates for all changes made in latest sklearn version (1.2.0)

n_init param added to KMeans initialisation.
normalise parameter is no longer supported in LinearRegression, so removed.
load_boston dataset deprecated, hence replaced with fetch_california_housing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 93.106%

Files with Coverage Reduction
New Missed Lines
%

src/sklearn_evaluation/telemetry.py
2
96.92%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2323

Relevant Lines:
2495

💛  - Coveralls


update to version v2

Module changed to github.com/canonical/edgex-snap-hooks/v2
edgex-go const values changed to v2

@tonyespy - I've added go.sum, removed "go.sum" from .gitignore and updated the comment about [Trigger].

@tonyespy - I've pushed an update with CSV support


Defer loading of instances.

Summary:
The loading of instance in LaunchQueueActor can be deferred until the
TaskInstanceTracker is ready.

We had the case in this build. The LaunchQueueActor failed to load and never recovered.

It would be interesting to know, why we had a akka.stream.AbruptStageTerminationException: GraphStage when the actor tried to recover.

Probably because the actor context is being used to materialize the stream, so it is effectively a child of the actor that is crashing. When the actor crashes, it tears down all of its children.


Automated cherry pick of #10418: fix(telegraf): megactl raid  add rebuild status

Cherry pick of #10418 on release/3.6.
#10418: fix(telegraf): megactl raid  add rebuild status

Codecov Report

Merging #10419 (9da3910) into release/3.6 (b9d30c0) will increase coverage by 2.20%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release/3.6   #10419       +/-   ##
================================================
+ Coverage         5.86%    8.07%    +2.20%
================================================
  Files              828      107      -721
  Lines           129133    13006   -116127
================================================
- Hits              7577     1050     -6527
+ Misses          120876    11836   -109040
+ Partials           680      120      -560

Flag
Coverage Δ

aFlag
8.07% <0.00%> (+2.20%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/apigateway/handler/auth.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/auth_totp.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/idp.go
1.84% <0.00%> (ø)

pkg/apigateway/handler/misc.go
0.00% <0.00%> (ø)

pkg/apigateway/handler/resource.go
0.00% <0.00%> (ø)

pkg/monitor/alerting/eval_context.go
34.25% <0.00%> (-3.89%)
:arrow_down:

pkg/monitor/alerting/rule.go
1.86% <0.00%> (-1.03%)
:arrow_down:

pkg/multicloud/esxi/manager.go
0.61% <0.00%> (-0.09%)
:arrow_down:

pkg/multicloud/esxi/host.go
0.77% <0.00%> (-0.01%)
:arrow_down:

pkg/multicloud/esxi/vnic.go
0.00% <0.00%> (ø)

... and 613 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4cddc...9da3910. Read the comment docs.


Graph view changes (font, temperature text alignment..)

Change font to Mulish Regular on graph view
Add padding to temperature text and make it the same size as numbers
Add current temperature/humidity/pressure

@andreevdenis Date is not fitting in the reserved space with new font

Max font size on my phone

I've increased space for captions and it should be fine for case above. But Samsungs have possibility to set font size to insane level so please don't go there ;)

1.14.5

1.14.5 @andreevdenis

Parentheses around last value seem unnecessary.
Is 12:00 AM same as 00:00 ?
is 24hour time an option?
hh:mm_AM (i.e. space after mm)  should be between values
12:00AM_12:00AM_ 12:00AM
IMHO day is nicer zero padded i.e.  10/01.
Y axis for humidity should always be nn.n. i.e. 29 should be 29.0 .

Is beta version available?

@DG12 it's in internal testing for now but soon it should go to alpha testing.

Discussed, looks like the AM PM 12h time is not going to work in charts.
Instead, we should always use 24h and override the system setting.
Let's also see that 24h is used elsewhere, like in Data Forwarding.

QA passed


Issues when cloning this github to directory

i am not well versed with github, and am not sure if this is an issue on my end or within the repo even after a few online searches for similar problems  I am on a windows x64 machine.
i am following the README for OpenROAD-flow-public to install, and i am getting the following error when cloning the openroad-flow-public to my directory using the command below from the README

git clone --recursive https://github.com/The-OpenROAD-Project/OpenROAD-flow-public.git

Error:

error: invalid path 'src/FastRoute/third_party/pdrev/src/aux.h'
Submodule path 'tools/TritonRoute': checked out '83cf3047e9a401889b710ee54397d8b269b9f516'
Submodule path 'tools/yosys': checked out 'ff4ca9ddc3fe3a0ef93feb295bf135ebff03b3df'
Unable to checkout '07a33a2f65f3af21c1962322b6a4de0bec557438' in submodule path 'tools/OpenROAD'

Cloning seems okay. the checkout of OpenROAD is where there is issue.
Any help would be appreciated.
for further information. i have attempted the clone with github desktop and using git clone --recurse-submodules to no success and get the same error
when i use git ls-tree to look at the .git file in the tools/OpenROAD path i see that the src/FastRoute/third_party/pdrev/src/aux.h path does not exist.  the path src/FastRoute/src/pdrev/src/aux.h is available

@eder-matheus @jjcherry56

Since I can checkout both the master and openroad branches of the openroad repo this is not an openroad repo issue. It is an openroad-flow issue.

Thanks for your response.
When i try your third command

git checkout openroad

i still get the below error

error: invalid path 'src/FastRoute/src/pdrev/src/aux.h'

Im going to try on a different machine. But, this should work on windows, correct? i would like to ultimately work directly on my machine.

As I recall windows doesn't like files named aux.  From https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file
Do not use the following reserved names for the name of a file:
CON, PRN, AUX, NUL, COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8, COM9, LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, and LPT9.
Thank DOS.
We should just rename the file to avoid this issue.

@maliberty I will update it now

Btw, nobody has ported openroad to windows, or plans to, so I expect you'll have a lot more trouble after this.  I suggest using WSL2  on windows to run ubuntu (that's what I do).

Btw, nobody has ported openroad to windows, or plans to, so I expect you'll have a lot more trouble after this. I suggest using WSL2 on windows to run ubuntu (that's what I do).

Thanks i will look that up. I did not see any os recommendations in the readme or docs, but that makes sense.


Add  Crypto Crawler to get the current coin price.

Description

add crypto price crawler by crawling coinmarketcap.

Type of change

New extension

Screencast

https://user-images.githubusercontent.com/11360957/138125063-3535e89c-7958-48da-88c7-5e67d4194289.mp4
Checklist

[ ] I read the documentation about publishing

20211024 Update : search the crypto price at first page
https://user-images.githubusercontent.com/11360957/138565698-37cb9948-9de1-47f0-9f03-7c50793aea99.mp4

Hey @moojing we just found out that icon in your extension is JPG even though it's named as PNG.
Do you mind updating it to proper format (PNG) and make sure it's at least 512x512 px size ?
Thanks in advance.

@grzegorzkrukowski  sure. but do you know  how can I make sure that the image is really in a png format ??
because in my file inspector it shows me the png format with this icon image file.

Sure ! You can for example check it in Terminal straight away:
file --mime-type ./assets/coinmarketcap-icon.png
coinmarketcap-icon.png: image/jpeg

@grzegorzkrukowski  updated here !
https://github.com/raycast/extensions/pull/320


Add ability to patch match string via invoke task to git tags so

we can get specific agent version tags and avoid others

Codecov Report

Merging #2719 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
- Coverage   57.13%   57.12%   -0.02%
==========================================
  Files         382      382
  Lines       24289    24289
==========================================
- Hits        13878    13875       -3
- Misses       9510     9514       +4
+ Partials      901      900       -1

Impacted Files
Coverage Δ

pkg/logs/client/connection_manager.go
44.82% <0%> (-3.45%)
:arrow_down:


Leetcode Question Number 234

Leetcode Question Number 234 soultion needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

I want to work on this issue!


Build failed on MacOS 13 with Xcode 14.1

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: One line description
Build failed on MacOS 13 with Xcode 14.1
Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
external/v8/src/base/platform/platform-darwin.cc:56:22: error: 'getsectdatafromheader_64' is deprecated: first deprecated in macOS 13.0 [-Werror,-Wdeprecated-declarations]
    char* code_ptr = getsectdatafromheader_64(
                     ^~~~~~~~~~~~~~~~~~~~~~~~
                     use getsectiondata()
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/mach-o/getsect.h:130:14: note: 'getsectdatafromheader_64' has been explicitly marked deprecated here
extern char *getsectdatafromheader_64(

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: The Envoy_collect tool
gathers a tarball with debug logs, config and the following admin
endpoints: /stats, /clusters and /server_info. Please note if there are
privacy concerns, sanitize the data prior to sharing the tarball/pasting.

Admin and Stats Output:

Include the admin output for the following endpoints: /stats,
/clusters, /routes, /server_info. For more information, refer to the
admin endpoint documentation.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Config:

Include the config used to configure Envoy.

Logs:

Include the access logs and the Envoy logs.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Call Stack:

If the Envoy binary is crashing, a call stack is required.
Please refer to the Bazel Stack trace documentation.

@envoyproxy/wasm-dev will there be an upstream V8 change we can pull in to fix this?

actually @dio is working on upgrading and fixing macos issue on wasm/v8 https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/310

Seems like that deprecation is very new :). Probably adding -Wno-deprecated-declarations in your user.bazelrc could help for now. Since that code is still on v8 main branch: https://github.com/v8/v8/blob/85e384960c27406aac93d88bcffcbe80a1020e9a/src/base/platform/platform-darwin.cc#L56.
build:macos --copt='-Wno-error=deprecated-declarations'


How to get CUstream object from numba cuda stream?

Usecase is -
s = cuda.stream()
SomeCfunc(... s)

The cuda steam is bound via ctypes, you can access a c_void_p to the stream from the instance's handle attr.
from numba import cuda
s = cuda.stream()
print(s)
print(s.handle)

gives e.g.:
<CUDA stream 30338928 on <CUDA context c_void_p(30367744) of device 0>>
c_void_p(30338928)

Thanks @stuartarchibald , closing


How to dynamically create a CSS mixin?

I've had a number of users ask how to do this. I tried digging into the internal styling API, but it's very complex. Rather than spending a day figuring it out, I'm sure somewhere here knows better.
Can we come up with a snippet so we have it "documented".
@sorvell @kevinpschaaf @sjmiles

I hacked together a solution that uses getComputedStyle and creates a dynamic <style is="custom-style"> that gets added to the main page. Also works under native shadow dom.
http://jsbin.com/xujimarale/edit?html,output (warning: uses es6 features)
This is extremely hacky! Namely, getComputedStyles returns all applied styles, which most certainly means you'll get extra styles from the main page. It also injects ALL css properties.

Ping


Commenting ability locked after attempting to add self reviewer

After trying to add myself as a reviewer on a Diff, I got a Validation error with the comment: The author of a revision can not be a reviewer.. After switching my action back to Comment, I am still receiving this error.
Tried switching to a Chrome Incognito window, signing in, and commenting: problem still persists. I seem to have screwed myself out of being able to comment on my Diff at this point :D

Tracking in https://secure.phabricator.com/T6989


entry.is_published() throws an exception

this line of code in resource.py throws an exception:
return bool(self.sys.get('published_at', False))
'bool' object is not callable

published_at = entry.sys.get('published_at', False)
if published_at:
do what ever - ex. entry.unpublish()

Hey @iroth,
Looks like a bug, let me check onto it and I'll get back to you ASAP.
Cheers

Hey @iroth,
I've looked into it, it's not a bug.
is_published is a property. Therefore not called with parenthesis, which is why it's returning an error when you're trying to call a bool object. https://github.com/contentful/contentful-management.py/blob/master/contentful_management/resource.py#L326RL330
Cheers

thanks @dlitvakb - my bad, working now!


WRO-2899: Update migration guide for enact 4.5

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
As we release the official version of 4.5.0, we need to update the 4.5 migration guide documentation.
Resolution
Update docs based on the review from #3045.
Additional Considerations
Links
WRO-2899
Comments
Enact-DCO-1.0-Signed-off-by: Mikyung Kim<EMAIL_ADDRESS>

LGTM


Unity 2023:  As Unity 2023 reaches LTS, the SF should be updated to address upgrade warnings.

Reality Collective - Service Framework Bug Report
Describe the bug

When using the SF with Unity 2023, there are several "warnings" (non-critical) related to Find methods and other features marked for deprecation.
These should be updated to fully support Unity 2023

Resolved with: https://github.com/realitycollective/com.realitycollective.service-framework/pull/85


landing page showing non validating nodes in Validators section

Description
On the Governance app landing page, the validator section is listing / counting nodes that are not validators

Tasks

Update all 'counts' to include only validator nodes

[ ] 'n active nodes'
[ ] 'n consensus nodes'
[ ] 'And n more...'

[ ] Review appropriateness of 'active nodes' label and revise if necessary i.e. should it be 'active validator nodes' / 'active validators'
[ ] Review appropriateness of 'consensus nodes' label and revise if necessary i.e. should it be 'consensus validator nodes' / 'consensus validators'
[ ] Only show logos for validator nodes
[ ] Review with stakeholders
[ ] Update automated regression tests to verify correct behaviour
[ ] Exploratory testing

Background / Notes
https://vegaprotocol.slack.com/archives/C02KUFHDYAC/p1685721092816569

Relevant intel in Edd's equivalent ticket here https://github.com/vegaprotocol/frontend-monorepo/issues/4155


feat(cast run): try custom error decode from openchain signature database

Motivation

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

contract OwnerControlled {
    address public owner;
    uint256 private value;

    event ValueChanged(uint256 newValue);
    error Unknown(string str);

    constructor() {
        owner = msg.sender;
    }

    modifier onlyOwner() {
        if(msg.sender != owner) {
            revert Unknown("only Owner");
        }
        _;
    }

    function setValue(uint256 _newValue) public onlyOwner {
        value = _newValue;
        emit ValueChanged(_newValue);
    }

    function getValue() public view returns (uint256) {
        return value;
    }
}

in this contract, when tx revert by using custom error.
cast run result:
Executing previous transactions from the block.
Traces:
  [2462] 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9::setValue(1)
    └─ ← [Revert] custom error 7c45b126:
only Owner

Transaction failed.

Solution
I think we can make it more readable by using openchain's signature database online.
In this pr, custom err would look like:
Executing previous transactions from the block.
Traces:
  [2462] 0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9::setValue(1)
    └─ ← [Revert] Unknown("only Owner")

Transaction failed.

Why didn't I get any errors when running cargo clippy --workspace --all-targets --all-features locally? I find it very strange!


[FEAT] Add your profile

If you're a beginner in open source.
Adding your Twitter profile in this project is a great way to practice standard open source workflow.
If you want to know how to add your Twitter profile, read the readme.md of project.
Also don't worry about the merge conflicts, we will fix them.
Best of luck!

Added my profile in PR #1! 🔥⚡

Added my profile! 🔥⚡

hey Pushkaraj, I have a doubt how to get the profile picture link

hey Pushkaraj, I have a doubt how to get the profile picture link

For getting the Twitter profile picture link:
On Twitter web app: Click on the profile picture and then a popup will show up with the same profile picture then right click on it and select open in new tab.
Check the URL, and it's the link of your profile picture.

I also want to add my profile can you assign me ?

I also want to add my profile can you assign me ?

No need to get assigned.
You can just add your profile and send a PR, I'll merge it.

Done!!!
If this is valid, can you please add it in October for hacktoberfest.

Added my profile

Added my profile

Added my profile :rocket:

I Added my profile. Please Merge my pull request.

Hey!! I added my profile 🔥
Please merge it

Added my profile as well, plz review & merge the pr

Also Check Out https://xprofile.hellofaizan.me/ and add up your profile in that project also


refactor: move helper.scss

Description

I moved helpers/_index.scss from nes.scss to nes-core.scss.
Compatibility

helpers is an unreleased feature, so there are no breaking changes.
Caveats

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Separate progress metrics and stats in the UI sidebar

Writing the web app references I found it difficult to explain how the Progress and Stats metric worked. I propose to have separate symbols for Annotation progress and Overall rule metrics. The latter symbol is only visible if the Define rules mode is available. All metrics would be available in each mode.
We could also separate Mentions and Keywords into two different Symbols giving them more meaningful names than Stats. The Mentions symbol would only appear for token classification datasets.
CC @Amelie-V

@Amelie-V I assume that this issue isn't relevant after 2.0. Please, confirm if I should close it.


Allow for varying precision in Weight

In order to allow varying degrees of precision, we pass an optional third parameter to the Weight constructor:
// to store 0.5oz:
$weight = new Weight(5, Unit::OZ, 10);

Added in 5fb3108212e8d479c8e375557eaa76074f72e693 by using Fraction instead of integer for Amount.


fix: stats and data

Codecov Report
Base: 74.92% // Head: 74.84% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (cac7575) compared to base (37aa8a1).
Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head cac7575 differs from pull request most recent head 5c8aa5d. Consider uploading reports for the commit 5c8aa5d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   74.92%   74.84%   -0.08%
==========================================
  Files          15       15
  Lines         327      330       +3
==========================================
+ Hits          245      247       +2
- Misses         82       83       +1

Impacted Files
Coverage Δ

Test/test_eg.py
98.09% <50.00%> (-0.94%)
:arrow_down:

Code/num.py
97.29% <100.00%> (+0.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Linux-serial-test ported to run on nuttx

This work based on the original work of Cliff Brake<EMAIL_ADDRESS>released under the MIT license  See https://github.com/cbrake/linux-serial-test
To use this test

Build the https://github.com/cbrake/linux-serial-test on
a linux box.

Add serial_test to the DUT board's default.cmake

Connect an FTDI cable from the Linux box to the DUT's Telem port.

run ./linux-serial-test -e -b 921600 -p /dev/serial/by-id/usb-FTDI_... -c
on the linux box (Use control C to exit)

Run  serial_test -e -b 921600 -p /dev/ttyS2 -c on DUT
Use ESC or control C to exit'

If it fits you might as well add it to the default 2MB NuttX boards as well as SITL and Linux.

@dagar - we can do that later (it needs all the global inited) . This it to verify the DMA work. Please merge it.

@dagar - This is ready


Course 3 | Week 2: TfidfVectorizer has no method get_feature_names()

In the ungraded lab of week 2 in course 3 (Ungraded lab: Algorithmic Dimensionality Reduction), the method get_feature_names() for TfidfVectorizer does not exists.
According to the sklearn documentation it need to be changed to get_feature_names_out().
https://scikit-learn.org/stable/modules/generated/sklearn.feature_extraction.text.TfidfVectorizer.html
There are two occurrences with vectorizer.get_feature_names() in the notebook.

I can confirm the error
as stated by @weissmanuel use get_feature_names_out() instead of get_feature_names()
see here


Fixed timezone bug in LocaleConverter

Pull Request Test Coverage Report for Build 303

2 of 66 (3.03%) changed or added relevant lines in 2 files are covered.
236 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-13.0%) to 67.308%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-ai/src/languageTranslator.ts
0
64
0.0%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-ai/src/luisRecognizer.ts
85
3.09%

libraries/botbuilder-ai/src/languageTranslator.ts
151
1.67%

Totals

Change from base Build 295:
-13.0%

Covered Lines:
1554

Relevant Lines:
2231

💛  - Coveralls

You broke CodeFlow with too many commits :(


Issue 119: removing leftover prints from the code.

Hi @JSegrave-IBM. Trying this instead of commenting on your PR. I just replaced a print statement with logger. I think if you review and close this, it will close your PR as well. Wanna try?


Issue 8440: Inconsistent Enumerable#minmax

Changed all forms of min, max, and minmax to raise an ArgumentError when NAN is one of the arguments. Also added testing for minmax.

asterite: Good catch! I think in this case a runtime exception should happen, similar to what happens when you sort an array with NaN.

I only included a test case for minmax, but I changed all the _internal functions which affects every variant of min/max/minmax. I could add more test cases, or solve the problem by using the <=> operator instead of raising an error. I also couldn't find "runtime exception" among exceptions, so I just used the plain old ArgumentError instead.
Thank you for your patience.
Issue being referenced
EDIT: Removed frivolous information irrelevant to issue

This should not be solved by hard-coding a special case into the algorithm. Instead, it should use <=> directly which has a generic case for values that are not comparable. That way the same behaviour would work not only for Float::NAN but also for other partially-comparable types.

About the semantics: An alternative to raising ArgumentError would be to disregard values that are not comparable. That could at least make some sense in the case of Float::NAN. But it can't work for generalized partially-comparable types, which might have more complex rules than just a single value that doesn't compare with any other.
So there is probably no alternative to enforcing full comparability on the values, i.e. raising ArgumentError.

This should not be solved by hard-coding a special case into the algorithm. Instead, it should use <=> directly which has a generic case for values that are not comparable. That way the same behaviour would work not only for Float::NAN but also for other partially-comparable types.

Okay, thank you. Do I Just change it to use the <=> operator like sort then commit again? Next time around, do I also add more test cases or is just 1 for minmax enough?
I was checking other values besides NAN, and I noticed it would just raise an overload error typically. e.g comparing char with number, putting in nil, etc.

Do I Just change it to use the <=> operator like sort then commit again?

Yes. You'll need to compare the return value from <=> with 0 (and raise if it's nil).

Next time around, do I also add more test cases or is just 1 for minmax enough?

A few more tests would be great.

I was checking other values besides NAN, and I noticed it would just raise an overload error typically.

Yes, in stdlib there aren't many partially comparables. Float's NAN might actually be the only one. But it's a general API and can be used for implementing any kind of partially comparable types.

Thanks you for your patience.
I changed it to:
value = yield elem <=> max
raise ArgumentError.new("Comparison of #{elem} and #{max} failed") if value.nil?
if i == 0 || value == 1
Would this be suitable? I'll be writing test cases now!

The return value of <=> can be 0 or any positive or negative integer, so you need to check for value > 0 instead of value == 1.
And you'll probably need to add parenthesis: (yield elem) <=> max.

The return value of <=> can be 0 or any positive or negative integer, so you need to check for value > 0 instead of value == 1.
And you'll probably need to add parenthesis: (yield elem) <=> max.

Okay, thank you!  Ohh-- I was thinking it was like Ruby's <=> operator and only returned -1, 0, and 1, my bad. I started out with parenthesis then actually removed them haha-- but in hindsight that was a horrible idea. Since now I don't really know if yield elem or elem <=> max is happening first

I'm not particularly sure if you guys have a 80 line limit or something, but the line raise ArgumentError.new("Comparison of #{ele_val} and #{max} failed") if value.nil? goes a bit over.  I also think ele_val and value can be renamed for more clarity, but I kept it similar to the original code.
Another heads up, I'm not sure if this behavior was present in the original max/min/minmax (I'll have to check), but using any of these functions and its derivatives on an array with Int32 and NANs results in a segmentation fault.
[-1, Float64::NAN, -3].max_of { |x| -x }
Invalid memory access (signal 11) at address 0x0...

Is it because I'm using the comparison operator <=> on the uninitialized U?

Exactly. This code must not run if i == 0 which was previously ensured by the logical OR operator.

Is it because I'm using the comparison operator <=> on the uninitialized U?

Exactly. This code must not run if i == 0 which was previously ensured by the logical OR operator.

Done! It's pretty messy, though. Hopefully that all works out.

Yeah, that's too convoluted. I'd suggest to move the common logic into a private helper method.
each_with_index do |elem, i|
  value = yield elem
  if i == 0 || compare_min_max(value, max) > 0
    max = value
    obj = elem
  end
end

# ...
private def compare_min_max(value, memo)
  value <=> max || raise ArgumentError.new("Comparison of #{value} and #{max} failed")
end

Yeah, that's too convoluted. I'd suggest to move the common logic into a private helper method.
each_with_index do |elem, i|
  value = yield elem
  if i == 0 || compare_or_raise(value, max) > 0
    max = value
    obj = elem
  end
end

# ...
private def compare_or_raise(value, memo)
  value <=> memo || raise ArgumentError.new("Comparison of #{value} and #{memo} failed")
end

Alright, will do! That actually looks a billion times better, haha. I guess once it works, refactoring is really important too. I wonder if the circleci test is failing because I put [1, Float64::NAN, 2.0].max or if it's because of some other error

I wonder if we can add a method to comparable that is like the spaceship operator but raises argument error on nil.

I wonder if we can add a method to comparable that is like the spaceship operator but raises argument error on nil.

What should the method be called?

Maybe <==>? Or <=>!. It's going to by kind of cryptic. Or we chose an actual name such as compare_or_raise.

Maybe <==>? Or <=>!. It's going to by kind of cryptic. Or we chose an actual name such as compare_or_raise.

I actually like <=>! a lot, since that's how it's generally done in Rails, I think.
So the regular version would return nil upon failing and the ! version would raise an error, that sounds pretty reasonable and intuitive to me.

Not to mention, to use it, somebody would have to do
etc compare_and_raise etc2

No, that can't work because it's not an operator. It would just be a normal call: a.compare_or_raise(b).

Not to mention, to use it, somebody would have to do
etc compare_and_raise etc2

No, that can't work because it's not an operator. It would just be a normal call: a.compare_or_raise(b).

Ohhhh.  It makes since that you can't do that style of call, though-- come to think of it. With the implicit parentheses rule, it looks like compare_or_raise b is being passed into a, and the parser probably can't read that at all.

To make <==> readable as a method, wouldn't the lexer/parser have to be changed?

Exactly. I'm impressed that you digged all that up in the compiler source :+1:
But adding an additional method to Comparable is out of scope here. Let's focus on the fix for Enumerable#minmax using a local private method (4cec19515e81fba7221dceea65d70c622c68e7ba).
The idea for Comparable should be discussed in a new issue and we can later adapt the code for Enumerable#minmax.

Yeah, sorry for bringing that idea. It was just a thought, not something we need to do now or something that we even will end up doing.

Yeah, sorry for bringing that idea. It was just a thought, not something we need to do now or something that we even will end up doing.

It made a lot of sense and is a good idea, though. A private comparison method in enumerable.cr isn't nearly as clean as having the method in comparable.cr. But I guess that should be in a new issue-- which makes a whole lot of sense too.
Man, that was really interesting ngl. I've only been studying alone, so I've never really had to face any merge conflicts. After a lot of failed attempts at reverting, I just ended up switching to the old commit, copying the enumerable file, switching back to the current head, then pasting in the old file. I'm pretty sure that's not how it's done and there's a specific command for grabbing specific commits (git cherry-pick?), but that was lots of fun regardless.

To make <==> readable as a method, wouldn't the lexer/parser have to be changed?

Exactly. I'm impressed that you digged all that up in the compiler source
But adding an additional method to Comparable is out of scope here. Let's focus on the fix for Enumerable#minmax using a local private method (4cec195).
The idea for Comparable should be discussed in a new issue and we can later adapt the code for Enumerable#minmax.

Tried to revert back to the old commit, but pretty sure I didn't do it properly. Hope that all works out! If you guys end up implementing a new operator in the future, I'd love to see the process or try my hand at it myself if possible. I think I can look through crystal-lang's old commits when you guys added new operators before, then see what was changed to make the operators work and why.

The commit history doesn't matter too much because it's a small change that's going to be squashed anyway. But for future reference, you might want to get acquainted with git reset ;)

Also, don't worry, git is pretty complex to learn.

I just ended up switching to the old commit, copying the enumerable file, switching back to the current head, then pasting in the old file

Hehe, that's why I end up doing from time to time when I stop understanding what happened with git.

The commit history doesn't matter too much because it's a small change that's going to be squashed anyway. But for future reference, you might want to get acquainted with git reset ;)

Will do!

Thank you!

Thank you both for your patience and time. I'm sure either of you two could have done it in like 5 minutes, but thanks for taking the time out of your days to guide me in the process. I really appreciate it! Ya'll are amazing

Getting the implementation in 5 minutes would certainly be possible, but only if the final intention had be known in advance. But reaching that is the real effort behind most PRs. It's a process requiring team effort and can only be reached through collaboratively sharing and discussing ideas.


fix for ItemsView not being subscriptable in py3

Coverage remained the same at 96.26% when pulling 611f5bc6dc58da13c98039bb2610b000e640702d on rurkowce:py3 into 41235e55bcead16c7069da32722d8d3fe0a025ba on ITCase:master.

Thanks


firefox stuck at "Status: {{connectionState}}"

Hi, when I bring up http://localhost:6680/moped/#/ only the frame of the interface is displayed and "Status: {{connectionState}}" shows up in the top right corner. I'm on arch linux with mopidy 1.1.0 and moped 0.6.1, firefox 40.0. I tried to run firefox in safe-mode, doesn't help.
With chrome everything works fine.
here's the trace from the ff console
11:49:26.310 Error: An invalid or illegal string was specified
[22]</c.prototype.connect@http://localhost:6680/moped/assets/moped-0.6.1.js:9:21540
c@http://localhost:6680/moped/assets/moped-0.6.1.js:9:19545
.start@http://localhost:6680/moped/assets/moped-0.6.1.js:19:13610
@http://localhost:6680/moped/assets/moped-0.6.1.js:18:30492
e@http://localhost:6680/moped/assets/moped-0.6.1.js:13:6684
bc/this.$get</</<@http://localhost:6680/moped/assets/moped-0.6.1.js:13:27529
v/<@http://localhost:6680/moped/assets/moped-0.6.1.js:13:18291
f@http://localhost:6680/moped/assets/moped-0.6.1.js:12:22084
v@http://localhost:6680/moped/assets/moped-0.6.1.js:13:18275
h@http://localhost:6680/moped/assets/moped-0.6.1.js:13:14344
F/<@http://localhost:6680/moped/assets/moped-0.6.1.js:13:13840
_/h/</<@http://localhost:6680/moped/assets/moped-0.6.1.js:12:27771
Vc/this.$get</n.prototype.$eval@http://localhost:6680/moped/assets/moped-0.6.1.js:14:22156
Vc/this.$get</n.prototype.$apply@http://localhost:6680/moped/assets/moped-0.6.1.js:14:22381
_/h/<@http://localhost:6680/moped/assets/moped-0.6.1.js:12:27729
e@http://localhost:6680/moped/assets/moped-0.6.1.js:13:6684
_/h@http://localhost:6680/moped/assets/moped-0.6.1.js:12:27650
_@http://localhost:6680/moped/assets/moped-0.6.1.js:12:27936
$@http://localhost:6680/moped/assets/moped-0.6.1.js:12:27185
@http://localhost:6680/moped/assets/moped-0.6.1.js:16:24973
_.Callbacks/k@http://localhost:6680/moped/assets/moped-0.6.1.js:11:4633
_.Callbacks/l.fireWith@http://localhost:6680/moped/assets/moped-0.6.1.js:11:5450
.ready@http://localhost:6680/moped/assets/moped-0.6.1.js:11:7243
g@http://localhost:6680/moped/assets/moped-0.6.1.js:10:2190
1 moped-0.6.1.js:14:9432
e/<() moped-0.6.1.js:14
dc/this.$get</<() moped-0.6.1.js:13
Vc/this.$get</n.prototype.$apply() moped-0.6.1.js:14
_/h/<() moped-0.6.1.js:12
e() moped-0.6.1.js:13
_/h() moped-0.6.1.js:12
_() moped-0.6.1.js:12
$() moped-0.6.1.js:12
 moped-0.6.1.js:16
_.Callbacks/k() moped-0.6.1.js:11
_.Callbacks/l.fireWith() moped-0.6.1.js:11
.ready() moped-0.6.1.js:11
g() moped-0.6.1.js:10

Very hard to reproduce this issue. On Firefox 40, Mac everything works fine. Could you probably create a non-release build try that one out on Arch Linux? Just follow the steps under 'Development' in the Readme.rst.

I have experienced a similar issue. I have used various browsers on various computers & mobile devices, and found the following pattern: the first time I use Moped, everything works fine, and appears to continue to work unless I click "Settings" then "Verify connection" then "Save settings." After this, I get only the frame of the interface with "Status: {{connectionState}}" displayed as described in the original post.
The first time I did this I was just poking around, but I've been able to reproduce it using Firefox on and Chrome on Ubuntu, and also Android Firefox.
Clearing the browsers' application cache and cookies doesn't fix the problem.

I've tried everything I could, but I cannot reproduce this issue. It has probably something to do with the Mopidy configuration. Could you give some details? Mopidy version, OS, plugins used etc.

I was able to reproduce this in firefox 45.02. In my case it was related to the Noscript (v 2.9.011) plugin I use in combination with mDNS i believe.
It works in firefox when I access the moped server on the IP. When I try to connect it with the .local address that mDNS gives via the Ubuntu machine it is installed on it fails with the above error in Firefox with Noscript even with the .local address white listed.

I have this issue using Safari Browser on my mac.

I have been able to reproduce it by saving settings without entering a mopidy url. This will set the value of 'moped.mopidyUrl' in LocalStorage to undefined. Clearly a bug. Could you check in your LocalStorage if this is also the case?


Approaches for using fixtures with unit tests

I'm currently evaluating Carbonite (the library is extremely elegant, by the way -- thank you!).
Ideally I'd like my unit tests to catch any cases where the Carbonite.Transaction is missing, but am running into some difficulty here. In more detail:
I set up Carbonite and added a trigger to a single table (in a Phoenix 1.7 project, in the off chance that matters), and then immediately ran the unit tests. The test that creates a new record in that table fails:
** (Postgrex.Error) ERROR 23503 (foreign_key_violation) INSERT on table public.foos without prior INSERT into carbonite_default.transactions

Perfect, exactly what I was hoping to see. I updated the code that inserts a new record to call Carbonite.Multi.insert_transaction as part of the transaction, and re-ran the tests.
That test now passes, but I also have some other failures related to tests that update and delete from this table. The underlying error is the same as above, but the difference is that these tests use a fixture that first creates a record (so that the tests can modify or delete the record and then assert on the outcome).
I updated the test fixture to call Carbonite.Multi.insert_transaction as part of the transaction, and re-ran the tests.
However, they all passed... which is not what I wanted to see, because my update and delete context methods haven't been updated yet. The unit tests pass, but the production app crashes when updating or deleting records from this table.
I tried modifying the fixture to call Carbonite.Multi.override_mode instead of Carbonite.Multi.insert_transaction, like so:
Ecto.Multi.new()
|> Carbonite.Multi.override_mode()
|> Ecto.Multi.insert(:foo, foo)
|> Repo.transaction()

However, the tests still pass with this change.
From the docs:

In tests using Ecto's SQL sandbox, subsequent calls to transactional operations (even to the same operation twice) are wrapped inside the overarching test transaction, and hence also effectively call insert_transaction/3 within the same transaction.
...
Therefore, insert_transaction/3 ignores subsequent calls within the same database transaction (equivalent to ON CONFLICT DO NOTHING), discarding metadata passed to all calls but the first.

I'm assuming that the behaviour I'm seeing is because of the above?
Digging around in the source, I came across:
@doc """
Returns an `t:Ecto.Query.t/0` that can be used to select or delete the "current" transaction.

This function is useful when your tests run in a database transaction using Ecto's SQL sandbox.

## Example: Asserting on the current transaction

When you insert your `Carbonite.Transaction` record somewhere inside your domain logic, you do
not wish to return it to the caller only to be able to assert on its attributes in tests. This
example shows how you could assert on the metadata inserted.

    # Test running inside Ecto's SQL sandbox.
    test "my test" do
      some_operation_with_a_transaction()
      assert current_transaction_meta() == %{"type" => "some_operation"}
    end

    defp current_transaction_meta do
      Carbonite.Query.current_transaction()
      |> MyApp.Repo.one!()
      |> Map.fetch(:meta)
    end

...

"""

If I use override_mode when creating a record (in the fixture), then Carbonite.Query.current_transaction() |> Repo.one!() fails with:
** (Ecto.NoResultsError) expected at least one result but got none in query:

     from t0 in Carbonite.Transaction,
       prefix: "carbonite_default",
       where: t0.id == fragment("CURRVAL(CONCAT(?::VARCHAR, '.transactions_id_seq'))", ^"carbonite_default"),
       where: t0.xact_id == fragment("pg_current_xact_id()")

So I could assert on Carbonite.Query.current_transaction() returning a result in my tests, but I'd rather (with the exception of the fixtures) not need for them to know anything about Carbonite.
Which brings me to my questions... am I doing something wrong? Is there a better way to approach this?

Hello @mjrusso,
yes, you are right in transactional tests with ecto's sandbox, when you call insert_transaction multiple times nothing will happen.
When using   override_mode, keep in mind, that after calling it once for the fixtures in a test transaction it will not only be active for your fixtures, but for the rest of the test case.

If you are using Ecto's SQL sandbox for running transactional tests, this means the override is going to be active until the end of the test case. -- https://hexdocs.pm/carbonite/Carbonite.html#module-testing-bypassing-carbonite

The reason for that you can see in the trigger itself. The trigger will look at the mode and will check if the current transaction will override this mode (essentially by setting override_xact_id on the trigger, which will be rolled back only at the end of the test transaction).
This also means that when you set your mode to capture on the trigger, after calling override_mode once it will be ignore for the rest of the transaction. If you set your mode to ignorein the trigger, it will be capture after calling override mode for the rest of the transaction.
So our general advice for using carbonite with ecto sandbox is starting out with ignore and then calling override_mode, once you are done with the setup (so the factories/fixtures will be ignored).
In our codebase we even wrote a little helper for asserting a carbonite transaction was called in a certain way:
 @spec assert_carbonite_transaction(map(), function()) :: Carbonite.Transaction.t()
  def assert_carbonite_transaction(meta \\ %{}, fun) do
    Carbonite.override_mode(MyRepo)

    fun.()

    Carbonite.Query.current_transaction()
    |> MyRepo.one!()
    |> tap(fn transaction ->
      assert transaction.meta == meta
    end)
  end

We haven't generalised it yet enough to make it to carbonite, but we could eventually.
So you would do something like:
# config/test.exs
config :my_app, carbonite_mode: :ignore

And in the test:
setup :insert_fixtures

test "it inserts carbonite transactions" do
  assert_carbonite_transaction fn ->
     my_context_function()
  end
end

I hope that helps
👋
Cheers Andi

Our usual setup as @andreasknoepfle described trades the risk of the occassional slip through of a missed insert_transaction for the freedom to ignore carbonite in most tests. Although that slip (IIRC) has never happened to us in production, as usually while working on a feature you test your code in :dev and hence notice when you have missed the insert_transaction, which in turn (usually) reminds you to write a test with assert_carbonite_transaction.

Ideally I'd like my unit tests to catch any cases where the Carbonite.Transaction is missing

Our approach is equivalent to option 2 in this section in the docs. If you want to go for option 1 instead to be extra sure you never miss an insert_transaction, you would need to bypass Carbonite when inserting your fixtures. Currently, we don't have a way to "reset" the override mode, but we can add one easily, so you could write something like this:
defp my_setup_block(_) do
  with_carbonite_override_mode(fn -> insert_my_fixture() end)
end

defp with_carbonite_override_mode(fun) do
  Carbonite.override_mode()
  x = fun.()
  Carbonite.reset_override_mode()
  x
end

@andreasknoepfle and @maltoe, thank you both so much for taking the time to explain and for #80. I had read the "Testing / Bypassing Carbonite" section in the docs a few times but didn't completely grok it; I now understand this much more clearly.
I've updated my code to use #80, in conjunction with the "Bypassing change capture selectively" option and the with_ignored_carbonite helper, and it works brilliantly. I'll likely also adopt the assert_carbonite_transaction helper that @andreasknoepfle mentioned above in the cases where I want to be extra sure that the correct metadata was written.
Thanks again!

released as v0.8.0


Consider parsing comments instead of @juniper directive

Thanks for your work on this crate!
I haven't looked into the implementation to know how large a task this would be, but I thought it'd be good to offer the workflow I'm trying to implement as a use case for your crate.
The idea is to have a schema file on disk that can be used as the single source of truth for the data layout, shared between both the client and server. With this file, I'd aim to parse it with juniper-from-schema and apollo-tooling's apollo codegen:generate which produces Typescript definitions for symbols found in the schema.
Currently, the @juniper schema directive is used to communicate to the parser here (and only here, I think?) in juniper-from-schema to influence typing options for the traits generated.
Having this directive in your schema breaks editor and codegen tools that don't see definitions for the directive itself. Specifics: I'm using the IntelliJ graphql plugin, and apollo codegen. Both of these use the schema file to statically check the queries and types of the data being returned.
Both the editor plugin and codegen can be satisfied by adding something like the following to the head of the schema file:
directive @juniper(
    ownership: String, # valid values: borrowed, owned, as_ref
    infallible: Boolean,
    with_time_zone: Boolean
) on FIELD_DEFINITION

Basically I stubbed out how the directive seems to be working if it were legit but did nothing. While this fixes the editor plugin and codegen, it breaks juniper-from-schema which panics saying it doesn't support directives.
So, where does this leave me and my desired workflow? Well, I can maintain two schema files, one for each use case (which would be super annoying), or I suppose I could try to ensure I don't need to use the directive for anything (might not be possible). I suppose another, less comfortable option might be build a sed step into the codegen process that spits out a version of the schema file without the directives in it, then set the editor and codegen to refer to this derivitive file. None of this is pretty.
So, with the problem known, a possible solution might be to not rely on directives but instead parse inline comments.
By moving the trait configuration info into comments, all parties should be able to consume the file without any issue.
So, instead of writing
type Query {
    allMessages: [ChatLogEntry!]! @juniper(ownership: "owned")
}

I'd write:
type Query {
    allMessages: [ChatLogEntry!]! # juniper: ownership="owned"
}

The comments could use the juniper: prefix with key/value pairs to follow. It shouldn't require sophisticated parser work to extract this data, but I'm not sure the comments are represented in the AST in a useful way so you can relate them to the field. That could be where the effort lies, but I'm not sure.

Working around this with sed for now. I'll use a schema file in the rust project to generate one in the frontend project:
https://github.com/onelson/e2e-rs/blob/d04e9dac6cdaa133608c28d6fb32a1b81b5422bf/web-frontend/package.json#L23

The GraphQL parser we use don't include comments in the AST. See https://github.com/graphql-rust/graphql-parser/issues/18. I also personally think using directives is the right way to go. It feels like they're designed specifically for cases like this.
I think a more elegant solution than seding would be nice 😊
I guess to solve this we have to support directive declarations for the @juniper directive, like the one you posted. I guess it would also make sense to fail the build if the declaration is not present. We could possible even write it to the schema on disk if it isn't present 🤔
What do you think?

Sounds like a workable solution. Having the definition of the directive be legal across the board save me from having to wriggle to thread the needle.
I'd offer that it'd feel a little rude to have this edit the schema file on disk automatically. That might cause issues in CI for some people.
I might prefer to have an error thrown and to include a good version of the directive definition in the output. I sort of clumsily wrote that without really knowing what I'm doing ;)
I bet you would be able to improve on it. For example, I'm not sure but in Typescript you can enumerate specific strings that are legal for a param. Maybe that's something graphql also knows how to express? Maybe not.

Yeah I like that idea 👍


Update restrictions on parameters

Fixes #896.
cc @KalleOlaviNiemitalo
I do wonder whether it would be useful to introduce a term which covers all of ref/out/in parameters, but that can come later.

@jskeet:

I do wonder whether it would be useful to introduce a term which covers all of ref/out/in parameters, but that can come later.

by-ref parameters?


RumbleBridge - new selector needed on user/channel page

$dom->find('li.video-listing-entry') wasn't working for me when I tried it. (I'm a new user, today.)
Changed it to $dom->find('ol.thumbnail__grid div.thumbnail__grid--item') and that seems to do the trick.

nice nice. thanks for taking the time to fix


Attempt to make REST API wrapper around AI model

Endpoint for Fastapi API where it passes the Excel file to the program and then returns the result in JSON.
To run:

type in the terminal: python -m uvicorn main:app --reload 2) on your browser open http://<IP_ADDRESS>:8000/docs 3) click on the /process-excel/ endpoint
click on the "Try it out" button

closing with fixed PR https://github.com/production-optimiser/production-optimiser/pull/6


Code generation failure when mapping Q# namespaces to C# namespaces

Describe the bug
Consider two files A.B.qs and B.qs with namespaces A.B and B and operation Foo defined in B.qs. Fully qualified call B.Foo() in A.B.qs is valid Q# code that leads to invalid C# code,
because in C# B.Foo() is equivalent to A.B.Foo() in this case.
To Reproduce
First file:
namespace Buggy {

    operation Foo() : Unit is Adj {
    }
}

Second file:
namespace BuggyBuggy.Buggy {

    operation Foo2 () : Unit {
        Buggy.Foo();
    }
}

Expected behavior
Successful compilation of Q# program.
Actual behavior
C# compilation error
 error CS0234: The type or namespace name 'Foo' does not exist in the namespace 'BuggyBuggy.Buggy' (are you missing an assembly reference?)

System information

OS: Windows

Additional context
Not critical, the simple workaround is to avoid the situation by naming namespaces differently.

Fixed by #346


works on the acessibilty of the page add explicit width to the image …

…width and replace the  image to .svg format and defer the unused styles

Accessibility check and update

LGTM, You can merge
Good luck with your next milestone


Local state documentation

What problem does this feature solve?
Give an example of how to create and use a client to store local state in a Nuxt app. I spent a bunch of time trying to work this out without success, and found the documentation unhelpful.
What does the proposed changes look like?
Additions to the readme.

This feature request is available on Nuxt community (#c248)

I just add a local state demo, you can check out if it is the right one
https://github.com/nuxt-community/apollo-module/tree/master/test/fixture-local-state
Based on vue-cli-plugin-apollo document: https://vue-cli-plugin-apollo.netlify.com/guide/client-state.html

@kieusonlam sorry for the slow response, thanks for this! It works great!


[terra-responsive-element] Migrate docs to terra-core-docs

Summary

Migrate docs to terra-core-docs

Closes #
Deployment Link

https://terra-core-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

@saket2403 some conflicts needs to be resolved.


FormElement in dart:html missing elements property

http://www.w3schools.com/jsref/coll_form_elements.asp

It's explicitly suppressed. I don't know what the reason is.

I wonder if originally it was though that this was equivalent to children?

Just stumbled upon this as well.
It's part of the HTML5 spec
http://www.w3.org/TR/html5/forms.html#dom-form-elements
would be nice to have.


Changing some values so scaling works better

Just a few small value changes so that scaling works better, 66 * 1.25 != Z where Z is an integer value, same for 345 * 1.25
Description
When you use scaling of 125% these values will not be whole numbers.
Motivation and Context
Post about some alignment issues, couldn't replicate the issue though but changed some values that will end up rounding and added vertical alignment to the checkboxes and radiocontrols. https://github.com/microsoft/microsoft-ui-xaml/issues/1520
How Has This Been Tested?
Tested to see if much changes, looks the same which is good.
Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: salmanmkc sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I now realise I should have deleted the fork and reforked because it has a PR that was merged yesterday, sorry! Is there another way to do that?

I now realise I should have deleted the fork and reforked because it has a PR that was merged yesterday, sorry! Is there another way to do that?

I think the following link might be useful:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork

I now realise I should have deleted the fork and reforked because it has a PR that was merged yesterday, sorry! Is there another way to do that?

I think the following link might be useful:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork

cheers, I've just been managing my fork from the GitHub page, I pulled from the main repo before,  is there something I'm missing?

🦙 @salmanmkc for future reference when reviewing, it can be handy to have screenshots of the before and after cases of one of the pages too!

🦙 @salmanmkc for future reference when reviewing, it can be handy to have screenshots of the before and after cases of one of the pages too!

Yeah, I mentioned that I couldn't replicate the issue, screenshotting wouldn't have shown much or any difference for the ComboBox/RadioButtons, and wouldn't really be visible for the small value changes

I now realise I should have deleted the fork and reforked because it has a PR that was merged yesterday, sorry! Is there another way to do that?

I think the following link might be useful:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-an-upstream-repository-into-your-fork

cheers, I've just been managing my fork from the GitHub page, I pulled from the main repo before, is there something I'm missing?

I am not quite sure if one would be able to merge branches just using the GitHub page. 😅
However merging branches is something Visual Studio is capable of, so you could use that or merge  in the command line.

split into multiple PRs