Lots of "Use of uninitialized value" warnings after biber update

I updated biber to 2.17, and now I am getting many warnings (thousands of them for large bib files, which significantly slows down biber itself) from files that were clean before. The warnings all look like this:
Use of uninitialized value $opt in hash element at /usr/share/perl5/Biber/Config.pm line 977.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at /usr/share/perl5/Biber/Config.pm line 977.

Sometimes the line numbers are different (I have seen 967, 972, 977).
Any use of biber causes that warning for me, so here is an arbitrary example:
\documentclass[10pt,a4paper]{article}
\usepackage[backend=biber]{biblatex}

\addbibresource{bib.bib}

\begin{document}

\fullcite{iris}

\end{document}

With bib.bib being
@inproceedings{iris,
  author    = {Ralf Jung and
               David Swasey and
               Filip Sieczkowski and
               Kasper Svendsen and
               Aaron Turon and
               Lars Birkedal and
               Derek Dreyer},
  title     = {{Iris}: Monoids and Invariants as an Orthogonal Basis for Concurrent
               Reasoning},
  booktitle = {{POPL}},
  year      = {2015},
  doi       = {10.1145/2676726.2676980},
}

Biber (and the rest of texlive) are installed via Debian testing packages.

That's not something I can reproduce here (MikTeX on Windows 10 and TUG vanilla TeX live 2021 on Ubuntu 18.04).
Maybe it's the cache. Try deleting it as described in https://tex.stackexchange.com/q/140814/35864 and rerun.
Though I seem to recall that Debian package things differently, so your Biber may not even have a cache. In which case I suggest you get in touch with the Biber Debian maintainers, they might be in a better position to suss out what is going on here.

I get this problem even in a new empty directory with just those 2 files, so it's not the cache.
I'll make a Debian bugreport, thanks for the quick reaction!

The cache I was referring to is not a cache that caches your working directory or .bib files. It is a cache that contains the unpacked Biber binary (a little background is at https://tex.stackexchange.com/a/541494/35864). So in order to really find out if the cache is involved, you need to follow the steps in https://tex.stackexchange.com/q/140814/35864. But as I say, I think I once gathered that Debian does not use the pre-built binaries, so they might not have a cache at all.

(Yes, sorry for the initial misunderstanding about the cache. I have edited my above reply since initially posting it.)

That's not something I can reproduce here (MikTeX on Windows 10 and TUG vanilla TeX live 2021 on Ubuntu 18.04).
Maybe it's the cache. Try deleting it as described in https://tex.stackexchange.com/q/140814/35864 and rerun.

I'm able to reproduce the issue. Please note that Ubuntu 18.04 (and probably MikTeX on Win 10) has an older version of perl installed. Please be so kind to test it with the version of perl in Debian unstable / testing (5.34). Many thanks!

Since I tested the pre-built binaries, the Perl version available on my machines does not matter. The pre-built binaries bring their own compatible Perl.
I can't tell you which Perl version was used to build the x86_64 binaries for Linux (those are built by @plk), but I can tell you that I built the Linux x86_32 binaries with Perl 5.34 (fully updated at the time) and I did not encounter any such problems in all the tests I ran.

I played around with a Debian Sid installation I installed today and found that
* When I wanted to install Biber from GitHub/`master`, some dependencies were reported missing. I installed some of them, but did not manage to install all of them.

Yes, this is correct. If you look at the build log of the package, you'll notice that deps are always reported to be missing:
    !  Encode::EUCJPASCII is not installed
    !  Mozilla::CA is not installed

as both packages are not in Debian (yet). The first will be available at any time, the latter probably never, but I hope this does not cause issues.

* I then installed Biber from GitHub/`master` (ignoring the missing dependencies). That Biber worked without an issue.
* I removed the GitHub-installed Biber and the Debian one would still error (so the dependencies might not be the issue after all?).

So, maybe we "build" biber the wrong way or something is missing: would you be so kind to have a look at our build log (link see above), maybe you have an idea, what we're doing wrong. The relevant part start at a line containing dh_auto_configure -i. Many thanks!

I also see this issue under Debian testing with biber 2.17.
The only difference I notice with the biber script produced from running perl Build.PL from the GitHub source and the system /usr/bin/biber is:
--- biber	2022-03-16 21:06:32.333171804 +1030
+++ /usr/bin/biber	2022-03-16 21:30:25.240899320 +1030
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl -w

 use v5.24;
 use strict;

If I change the interpreter of /usr/bin/biber to #!/usr/bin/env perl then everything works as expected.

So the main difference is that we call perl with option "-w". After removing the option the warnings go away. Not sure if we should solve the issue this way.

Fixed in biber dev but those warnings can be ignored.

Down to two warnings now
Use of uninitialized value $tool in concatenation (.) or string at <PERLPATH>/Biber/Config.pm line 305.
Use of uninitialized value in string eq at <PERLPATH>/Biber/Internals.pm line 1507.

Fixed in biber dev but those warnings can be ignored.

Thanks for the fix! Would be nice if the two remaining warnings mentioned by @moewew could be removed too.

How are you getting these warnings? Running the test suite?

I run Biber on test-dev from https://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/testfiles/ (changed the .bcf version to match the Biber dev version). I didn't run any more extensive tests, because I don't have TeX installed on the system I use to build Biber.

Should be fixed now I believe. One was a fairly obscure edge case, the other was due to the fix put in for plk/biblatex-apa#152

The
Use of uninitialized value in string eq at <PERLPATH>/Biber/Internals.pm line 1507.

is still there for me.
All other warnings are gone.

Should be fixed - needed to update the test-dev.bcf

Yeah, that's done it.
As I say, I don't have a proper TeX live on the machine I use to build Biber, so I can't really test things "in the wild". Maybe I'll manage to run some more tests at some point.

Alright I can reproduce the warnings if I tell the perl interpreter to -warn. Specifically I get
Use of uninitialized value in quotemeta at <PERLPATH>/Biber/Config.pm line 228.
Use of uninitialized value $tool in concatenation (.) or string at <PERLPATH>/Biber/Config.pm line 307.
Use of uninitialized value in string eq at <PERLPATH>/Biber/Internals.pm line 1507.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 978.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 978.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 978.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 978.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 968.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 973.
Use of uninitialized value $opt in hash element at <PERLPATH>/Biber/Config.pm line 978.
Use of uninitialized value within %Biber::Config::CONFIG_OPTSCOPE_BIBLATEX in hash dereference at <PERLPATH>/Biber/Config.pm line 978.

from the test .bcf from Sourceforge.
I had a look at the first warning and it looks like an undeclared option is being referenced. So this is something that should be looked at on the Biber side it appears to me.

I got the same error now in Ubuntu - Texstudio. How did you solve it?

Which version of Biber are you running? The warnings discussed here were resolved in version 2.18. If your Ubuntu is not the newest version and you installed TeX Live and Biber via apt, you're very likely not running the newest version of Biber - possibly one from before the fix. As discussed above though, the warnings are mostly harmless and can be ignored.

I also see this issue under Debian testing with biber 2.17.
The only difference I notice with the biber script produced from running perl Build.PL from the GitHub source and the system /usr/bin/biber is:
--- biber	2022-03-16 21:06:32.333171804 +1030
+++ /usr/bin/biber	2022-03-16 21:30:25.240899320 +1030
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl -w

 use v5.24;
 use strict;

If I change the interpreter of /usr/bin/biber to #!/usr/bin/env perl then everything works as expected.

using #!/usr/bin/env perl solved mine.


[UX]No user facing feedback after clicking the submit button

Feature Request
After clicking the submit button, there's no feedback prompt or text of whether the time limit has been applied. Looks like there are something printed in the dev console, but it's not obvious to normal users.
Desired behavior: show a success/error message to user from UI
https://user-images.githubusercontent.com/1504463/103783518-d3e5a300-5006-11eb-8cd8-5e3f51b4bf3b.mp4

Hi, Thanks for the feedback. We will be adding a confirmation message in the next release - end of April.

This has been fixed now.


DOC add type annotations to responsibleai package

Description
Adding type annotations to the responsibleai package wherever there was anything Optional. Would we want these for the required args as well? Also fixing a few smaller formatting inconsistencies and typos in the process.
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[x] responsibleai
[ ] erroranalysis
[ ] rai_core_flask

Tests

[x] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

Codecov Report

Merging #1214 (6297434) into main (29ed9fc) will increase coverage by 8.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   66.94%   75.58%   +8.63%
==========================================
  Files          91       10      -81
  Lines        4359      258    -4101
==========================================
- Hits         2918      195    -2723
+ Misses       1441       63    -1378

Flag
Coverage Δ

unittests
75.58% <ø> (+8.63%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...i/responsibleai/managers/counterfactual_manager.py

...i/responsibleai/managers/error_analysis_manager.py

...ibleai/responsibleai/managers/explainer_manager.py

...leai/responsibleai/modelanalysis/model_analysis.py

...sibleai/responsibleai/rai_insights/rai_insights.py

responsibleai/responsibleai/_data_validations.py

raiwidgets/raiwidgets/utils.py

erroranalysis/erroranalysis/_internal/__init__.py

...sponsibleai/responsibleai/rai_insights/__init__.py

...iwidgets/raiwidgets/model_performance_dashboard.py

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ed9fc...6297434. Read the comment docs.

@gaugup if I'm understanding correctly you mean I should add type annotations for every arg, not just the optional ones. Is that correct?

@gaugup if I'm understanding correctly you mean I should add type annotations for every arg, not just the optional ones. Is that correct?

Type hints are for static checking of the code paths. So a variable being optional or not doesn't matter. We haven't enabled mypy in our builds otherwise you would see these unannotated function variables getting flagged.

@gaugup if I'm understanding correctly you mean I should add type annotations for every arg, not just the optional ones. Is that correct?
Type hints are for static checking of the code paths. So a variable being optional or not doesn't matter. We haven't enabled mypy in our builds otherwise you would see these unannotated function variables getting flagged.

@gaugup Is that a yes? :-)


[Excel](shared runtime) Adding preview docs for shared runtime

This is to add new preview docs describing shared runtime and scenarios.

Docs Build status updates of commit f1d7ed3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/authenticate-from-a-ribbon-button.md
:white_check_mark:Succeeded

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 323f10d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

_dependentPackages/CommonPlugins/tools/JoinTOC.ps1
:x:Error

Details

.openpublishing.publish.config.json
:x:Error

Details

:x:Error

Details

_dependentPackages/CommonPlugins/tools/JoinTOC.ps1

Line 82: [Error] Error happened when executing plug-in script _dependentPackages/CommonPlugins/tools/JoinTOC.ps1 at step docset_prebuild. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins or ask for help?in Docs Support teams channel. Exit code: -1073741502
Line 217: [Error] Error happened when executing plug-in script _dependentPackages/CommonPlugins/tools/JoinTOC.ps1 at step docset_prebuild. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins or ask for help?in Docs Support teams channel. Please also include the build report and the following error code for our team to troubleshoot: 1

.openpublishing.publish.config.json

Line 80: [Error] Failed to execute customized script at step docset_prebuild in docset office-js-docs-pr. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins for docset office-js-docs-pr step docset_prebuild or ask for help?in Docs Support teams channel. Please also include the build report and the following error code for our team to troubleshoot: 1

Line 138: [Error] W:\abjs-s\.optemp\packages\opbuild.scripts.1.84.4\tools\opbuild\docset.prebuild.ps1 failed to execute

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1b00f5f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

_dependentPackages/CommonPlugins/tools/JoinTOC.ps1
:x:Error

Details

.openpublishing.publish.config.json
:x:Error

Details

:x:Error

Details

_dependentPackages/CommonPlugins/tools/JoinTOC.ps1

Line 82: [Error] Error happened when executing plug-in script _dependentPackages/CommonPlugins/tools/JoinTOC.ps1 at step docset_prebuild. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins or ask for help?in Docs Support teams channel. Exit code: -1073741502
Line 217: [Error] Error happened when executing plug-in script _dependentPackages/CommonPlugins/tools/JoinTOC.ps1 at step docset_prebuild. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins or ask for help?in Docs Support teams channel. Please also include the build report and the following error code for our team to troubleshoot: 1

.openpublishing.publish.config.json

Line 80: [Error] Failed to execute customized script at step docset_prebuild in docset office-js-docs-pr. Please check your .openpublishing.publish.config.json?on the configuration of the plug-ins for docset office-js-docs-pr step docset_prebuild or ask for help?in Docs Support teams channel. Please also include the build report and the following error code for our team to troubleshoot: 1

Line 138: [Error] W:\wm1f-s\.optemp\packages\opbuild.scripts.1.84.4\tools\opbuild\docset.prebuild.ps1 failed to execute

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1b00f5f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/toc.yml
:warning:Warning

Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

docs/toc.yml

Line 0: [Warning] Invalid file link:(~/excel/authenticate-from-a-ribbon-button.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 18cd751:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/toc.yml
:warning:Warning

Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

docs/toc.yml

Line 0: [Warning] Invalid file link:(~/excel/authenticate-from-a-ribbon-button.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 35d80dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ef25012:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit baf2a84:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-the-browser-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit f7406da:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\hlis-s, target branch: master, target branch commit: 2ad9e079f590efaeb275dee3d05bee79421c920b, source commit: f7406da2b4239f904661a517efc7423e22646379.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 66ac40a:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 66ac40a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\pmuu-s, target branch: master, target branch commit: 2ad9e079f590efaeb275dee3d05bee79421c920b, source commit: 66ac40a6548ee79f0432f0b5ff7ff06b605e8116.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c5ef8fc:
:clock10: Pending: waiting for processors (5 builds ahead of you)
:warning: Docs Build is busy, currently there are 5 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit c5ef8fc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\sw13-s, target branch: master, target branch commit: 2ad9e079f590efaeb275dee3d05bee79421c920b, source commit: c5ef8fce72be59b77c6dee541d29ef3ed810953a.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6f83f56:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 6f83f56:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\rh3s-s, target branch: master, target branch commit: 2ad9e079f590efaeb275dee3d05bee79421c920b, source commit: 6f83f56b7f04d79ae0ef9e3159825ede3a50a11a.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3988343:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3988343:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/OfficeDev/office-js-docs-pr, working directory: W:\sze2-s, target branch: master, target branch commit: 2ad9e079f590efaeb275dee3d05bee79421c920b, source commit: 39883432f9e91ca04fd7c3d9a4a8cd9e526aded9.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 15a6219:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 15a6219:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/call-excel-apis-from-custom-function.md
:white_check_mark:Succeeded

docs/excel/configure-your-add-in-to-use-a-shared-runtime.md
:white_check_mark:Succeeded

docs/excel/custom-functions-shared-overview.md
:white_check_mark:Succeeded

docs/excel/run-code-on-document-open.md
:white_check_mark:Succeeded

docs/images/custom-functions-in-browser-runtime.png
:white_check_mark:Succeeded

docs/includes/excel-shared-runtime-preview-note.md
:white_check_mark:Succeeded

docs/includes/note-requires-shared-runtime.md
:white_check_mark:Succeeded

docs/reference/manifest/runtime.md
:white_check_mark:Succeeded

docs/reference/manifest/runtimes.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/share-data-and-events-between-custom-functions-and-the-task-pane-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute

Global effort to fix build validation errors
The Microsoft Skilling team is fixing build validation errors and specific brand inconsistencies in Microsoft technical documentation for the rest of FY23 Q1. This will help address various accessibility, security, and usability issues. This PR was generated using DocuTune. It includes only targeted fixes and minor formatting adjustments.
DocuTune PRs improve quality of technical content by finding and automatically correcting a broad set of issues only where the correction is suitable. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!
CorrelationId: 0df9c2d6-63f8-4d1e-8b57-b33611a06514
InitiativeId: docutune-build-validation-issues-2022-05
PointOfContact: Alex Buck

#docutune-draft

#docutune-ready

@rick-anderson @JoeStagner @wenz
Please merge the changes in this PR. For more information, see the description at the top of this PR.
Any pre-existing build validation issues or insufficient Acrolinx scores should be addressed in a separate PR.
#docutune-request-approval


Update for the 1.29.1 release

r? @ashleygwilliams
(rust_highfive has picked a reviewer for you, use r? to override)


feature[next]: Collect shifts for all nodes in TraceShift pass

Shifts are collected not only for the closure inputs, but for every iterator expression in the tree (including iterator arguments to lambdas).
The collected shifts are now represented as a set.

This PR is a prerequisite for the temporary extraction heuristics.

I'll approve once the testcase is added.


Memory Leak with option SDWebImageRefreshCached

Hi,
using the option SDWebImageRefreshCached, for example with with sd_setImageWithURL, I notice a consistent memory leak.
The leak is much more evident on the real device than the simulator.
Here's a sample code to reproduce the leak:
- (IBAction)leakButton:(id)sender
{
    NSURL *imageUrl = [NSURL.alloc initWithString:@"https://avatars1.githubusercontent.com/u/68232?v=3&s=460"];
    SDWebImageOptions options = SDWebImageRefreshCached;
    for (int i = 0; i < 100; i++)
    {
        [imageViewToLoad sd_setImageWithURL:imageUrl placeholderImage:nil options:options completed:^(UIImage* image, NSError* error, SDImageCacheType cacheType, NSURL* imageURL) {
            NSLog(@"Completed.");
        }];
    }
}

@marcovanetti the reason for the spike is that since the resource is https, it probably doesn't allow caching, so we keep downloading it every time, since that is what the SDWebImageRefreshCached is telling. You should try Allocations Instrument and see the what objects keep pilling up.


Docker container errors (at least for me) on nightly 1.5.0 (1.5.0-127-ge130553)

Hello,
Container failing to start with error that "start_vernemq" is not found in $PATH
actual fix is
https://github.com/erlio/docker-vernemq/blob/0501ac840ff068d29d0bf460e07b445f2980636f/Dockerfile#L53
needs to be change to
CMD ["bash", "/usr/sbin/start_vernemq"] which composes command bash /usr/sbin/start_vernemq
As the start_vernemq is moved to mentioned directory at https://github.com/erlio/docker-vernemq/blob/0501ac840ff068d29d0bf460e07b445f2980636f/Dockerfile#L26
Actually, the bash script is there, but shell can not find it in $PATH, so running it explicitly with bash solves it.
using bash path_to_sh_script solves the issue for those encountering such error.

Thanks for the report!
How did you build the image?

Thanks for the report!
How did you build the image?

docker build .


Pilot uses its own kube client utils

Currently, package istio.io/istio/tests/k8s is only used by pilot/serviceregistry. It's very specific since
// For Bazel sandbox we search a different location:
// Attempt to use the relpath, using the linked file - pilot/kube/platform/config

This PR moves these lines to pilot's own package.
/assign @rshriram

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b8cff50f3095cc09d2d1e550762946a72f8ef430
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Can u tell me how to use a github repository to detect imsi-catchers?
On Sat, Sep 22, 2018 at 11:34 PM codecov[bot]<EMAIL_ADDRESS>wrote:

Codecov https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=h1 Report
Merging #8913 https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=desc
into master
https://codecov.io/gh/istio/istio/commit/2fa956fee57a50a6ae2183fe2a79b3ad6a16455f?src=pr&el=desc
will decrease coverage by 1%.
The diff coverage is n/a.
[image: Impacted file tree graph]
https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=tree
@@           Coverage Diff           @@##           master   #8913    +/-   ##
=======================================- Coverage      70%     70%   -<1%
Files         416     416
Lines       38104   37914   -190
=======================================- Hits        26333   26177   -156     + Misses      10573   10532    -41     - Partials     1198    1205     +7
Impacted Files
https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=tree Coverage Δ
pilot/pkg/serviceregistry/kube/controller.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIuZ28= 52%
<0%> (-10%) ⬇
mixer/adapter/stackdriver/stackdriver.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zdGFja2RyaXZlci9zdGFja2RyaXZlci5nbw== 50%
<0%> (-4%) ⬇
pilot/pkg/serviceregistry/kube/queue.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL3F1ZXVlLmdv 84%
<0%> (-4%) ⬇
mixer/adapter/servicecontrol/distValueBuilder.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zZXJ2aWNlY29udHJvbC9kaXN0VmFsdWVCdWlsZGVyLmdv 92%
<0%> (-3%) ⬇
galley/pkg/kube/converter/proto.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-Z2FsbGV5L3BrZy9rdWJlL2NvbnZlcnRlci9wcm90by5nbw== 86%
<0%> (-2%) ⬇
pkg/mcp/server/server.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-cGtnL21jcC9zZXJ2ZXIvc2VydmVyLmdv 83%
<0%> (-2%) ⬇
mixer/adapter/kubernetesenv/cache.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9rdWJlcm5ldGVzZW52L2NhY2hlLmdv 87%
<0%> (-1%) ⬇
...ixer/pkg/protobuf/yaml/dynamic/valueTypeEncoder.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvcGtnL3Byb3RvYnVmL3lhbWwvZHluYW1pYy92YWx1ZVR5cGVFbmNvZGVyLmdv 94%
<0%> (ø) ⬇
mixer/adapter/cloudwatch/handler.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9jbG91ZHdhdGNoL2hhbmRsZXIuZ28= 87%
<0%> (ø) ⬇
mixer/adapter/memquota/memquota.go
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9tZW1xdW90YS9tZW1xdW90YS5nbw== 100%
<0%> (ø) ⬆
... and 11 more
https://codecov.io/gh/istio/istio/pull/8913/diff?src=pr&el=tree-more
Continue to review full report at Codecov
https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=continue.
Legend - Click here to learn more
https://docs.codecov.io/docs/codecov-delta
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov
https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=footer. Last
update 2fa956f...e888b1b
https://codecov.io/gh/istio/istio/pull/8913?src=pr&el=lastupdated. Read
the comment docs https://docs.codecov.io/docs/pull-request-comments.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/8913#issuecomment-423795329, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Apekrawpn4X8TRIrAgaY6QwyO5LbCzdAks5udyuMgaJpZM4W1lAQ
.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ugh.. we no longer use bazel. If possible, can you please get rid of this code and use the code that others use to get kube client?

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ccd99378f52fef35e9d506b54c1006c64f4d6ddf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fb41dcb420134350f098aec64c948437e3de78e4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
fb41dcb420134350f098aec64c948437e3de78e4
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
fb41dcb420134350f098aec64c948437e3de78e4
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@m1093782566: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Marketplace URL handler

These URLs trigger the vscode default URL handlers.
vscode:extension/ms-vscode.csharp
vscode-insiders:extension/ms-vscode.csharp

They work great when VS Code is already open: the extension ms-vscode.csharp opens up in the marketplace.
When no instance of VS Code is running, VS Code opens, but the marketplace doesn't show up.
Fixing this would allow an Open in marketplace button.
VS Code version: Code - Insiders 1.40.0-insider (3f6ed25939b8ef157a7a41e0dc43b517898d4005, 2019-10-15T05:26:04.723Z)
OS version: Linux x64 4.15.0-65-generic

also: when vscode trying to open url with extension page on marketplace, it opens browser!

Why does this keep breaking.

Very likely the same as https://github.com/microsoft/vscode/issues/73101
cc @bpasero

Actually, no... the fix for #73101 caused this issue!

@joaomoreno, can i make issue for https://github.com/microsoft/vscode/issues/82869#issuecomment-544117145 ?

also: when vscode trying to open url with extension page on marketplace, it opens browser!

What are the steps to reproduce?

@joaomoreno , write in some file vscode marketplace extension url, and open it (CTRL+Click)


Add withId so that we can give an Dom id to the input element

This allows us to do things like direct focus on the input element (using Browser.Dom).

You can already set an id attribute by:
TextInput.init "Text"
    |> TextInput.view [ id "some-id" ]

So I would suggest to do that instead

You can already set an id attribute by:
TextInput.init "Text"
    |> TextInput.view [ id "some-id" ]

So I would suggest to do that instead

This does not add the attribute to the input element - which is needed if I want to direct focus to that element.

This does not add the attribute to the input element - which is needed if I want to direct focus to that element.
EDIT: Or to be specific, it also adds it to the embedding element - id:s should be unique so must only be added to the input.

Ohh yes, you are correct. Unfortunate complexity of having composite components 🫤
But what is the actual use case of needing manual focus management? Could autofocus be an option?

This does not add the attribute to the input element - which is needed if I want to direct focus to that element.
EDIT: Or to be specific, it also adds it to the embedding element - id:s should be unique so must only be added to the input.

Ohh yes, you are correct. Unfortunate complexity of having composite components 🫤
But what is the actual use case of needing manual focus management? Could autofocus be an option?

The use case is in a search inut + dropdown for selecting items. It's desirable to keep the kbd focus on the field even after selecting items (=> Dom.focus) and it makes it easier to manage automatic closing of the dropdown - i.e. onBlur on the search field. Autofocus is obviously not an option here..

The use case is in a search inut + dropdown for selecting items. It's desirable to keep the kbd focus on the field even after selecting items (=> Dom.focus) and it makes it easier to manage automatic closing of the dropdown - i.e. onBlur on the search field. Autofocus is obviously not an option here..

I see, that sounds like a reasonable use case indeed. I do however have one concern there, how will it work in terms of accessibility? It must to be possible to use well with a keyboard only, and you need to be able to move focus freely between the elements (with your keyboard) for screen readers to work. And you should also consider the point the from link above about how moving focus around automatically can be bad for accessibility in general.
Do you think it will be fine?

The use case is in a search inut + dropdown for selecting items. It's desirable to keep the kbd focus on the field even after selecting items (=> Dom.focus) and it makes it easier to manage automatic closing of the dropdown - i.e. onBlur on the search field. Autofocus is obviously not an option here..

I see, that sounds like a reasonable use case indeed. I do however have one concern there, how will it work in terms of accessibility? It must to be possible to use well with a keyboard only, and you need to be able to move focus freely between the elements (with your keyboard) for screen readers to work. And you should also consider the point the from link above about how moving focus around automatically can be bad for accessibility in general.
Do you think it will be fine?

I'm not too familiar with screen readers but the focus changes only when selecting an item from the list, so it should work when moving the focus around generally.  In fact it could would perhaps work better as the close button will always be at a predictable place from the current focus (next button).

I'm not too familiar with screen readers but the focus changes only when selecting an item from the list, so it should work when moving the focus around generally. In fact it could would perhaps work better as the close button will always be at a predictable place from the current focus (next button).

It sounds suboptimal accessibility wise because I dont think the screen reader will announce the selected values, it will instead skip the announcement and jump to the text input and announce the text there instead. The behaviour will probably be better for mouse users tho (but keep in mind accessibility is a hard requirement).
Regarding closing, it should be possible to press Esc to close the dropdown. The focus should still be on the dropdown, and pressing space or Enter should open it again.

I'm not too familiar with screen readers but the focus changes only when selecting an item from the list, so it should work when moving the focus around generally. In fact it could would perhaps work better as the close button will always be at a predictable place from the current focus (next button).

It sounds suboptimal accessibility wise because I dont think the screen reader will announce the selected values, it will instead skip the announcement and jump to the text input and announce the text there instead. The behaviour will probably be better for mouse users tho (but keep in mind accessibility is a hard requirement). Regarding closing, it should be possible to press Esc to close the dropdown. The focus should still be on the dropdown, and pressing space or Enter should open it again.

I'll keep these things in mind; I don't think we have esc-support in any internal dropdown components at CP - I'll add it at least to the current component under development.
It would sure help a lot to have access to some screen-reader software when developing accessibility-friendly components..

I'll keep these things in mind; I don't think we have esc-support in any internal dropdown components at CP - I'll add it at least to the current component under development.
It would sure help a lot to have access to some screen-reader software when developing accessibility-friendly components..

Great! I think esc-support might have been lost. I remember we had it in one of the older components at least.
There is built-in support for screen readers on Mac and Windows (I dont know about linux), which is very useful to run through every once in a while.


Unable to get lora data to embed in a way Civitai can read - can you please an an example workflow

I've gotten everything to work so Civitai reads it on upload except for the lora data, and I'm not sure what I'm doing wrong.
Could you please add an example workflow that embed lora info?
(Also, great nodes - thanks for making this, I hated uploading to Civitai without sharing useful generation data)

to use ImpactWildcardEncode from the ComfyUI-Impact-Pack.
In my readme there is an example in the second picture. It's a png that you can drag and drop into comfy to get the example workflow.

Here it is again:


Fix tests for finding remainder in javascript challenge

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace 8956 with an issue no): Closes #8956

Description

Modified the tests for the challenge Finding a remainder in Javascript

@arun1595 thanks for fixing the test. The issue you're fixing is closely related to #8570. Can you also add this test or something similar that checks for the initialization of the variable remainder, as per discussion here?
"assert(/var\\s*?remainder/.test(code), 'message: The variable remainder should be initialized');"

Let us know if you have any issues amending the commit. You'll need to make your changes, add the file, and then use git commit --amend to make sure you keep just one commit. Thanks!

@arun1595 one more quick change, can you change the last test to have the regex /var\\s+remainder/? Otherwise, I'll be able to pass the challenge with varremainder = 11 % 3; which should be incorrect.

@arun1595 looks like your previous changes got lost somehow in your edits. I just see the change from * to +.

@arun1595 LGTM! Thanks for the PR! 👍


Implement deep-copy prototype

The deep-copy prototype is only exposed to users of oeedger8r if they specify the --experimental flag when generating their edge routines (note that this is done in our tests).
Notable lacking support is handling of deep-copied out structures. However, in structures with count > 1 (essentially arrays) are supported.
Next steps: a lot more tests, refactoring, and proper error handling.
Please review both the edge8r changes and the generated code in all_u.c, all_t.c, and all_args.h (that is, the edge routines of the oeedger8r unit tests, specifically the functions prefixed with deepcopy_).

bors try

I haven't looked at the changes to oeedger8r yet (I've got to brush up on my OCaml, it's been a while), but do your changes ever assume that the enclave can read host memory? The reason for the question is that this is not necessarily the case for OP-TEE.

I haven't looked at the changes to oeedger8r yet (I've got to brush up on my OCaml, it's been a while), but do your changes ever assume that the enclave can read host memory? The reason for the question is that this is not necessarily the case for OP-TEE.

No, I do not believe so. We're simply expanding our existing marshaling structs to marshal all the data between enclave and host.

I took an initial pass at this. Looks good. But quite hard to review since nesting/moving of functions around is being done with feature implementation. So it is very difficult to figure out which code is new and needs scrutiny vs which code is just code-nesting/movement that I can safely skim over.

I can try to undo the nesting and plumb through the parameters needed to implement --experimental, but I think it will only help a bit.

I have a general question about the use of master branch; not for this PR per se, but for many PRs I see going in now.
I am fine with using master branch as a dev branch where incomplete/in-progress code can be checked in. However, currently we just seem to be picking stuff from the master branch onto the release branch without any pull-request/code-review.
So if I were to relax review bar and accept a particular PR with the understanding that it is in dev, what part of the development process ensures that only complete and shipping quality features are pulled into the release branch?

Master branch is the development branch.
We should not be picking things randomly into release branches, we should be following the process to branch off master when it is at a reasonable state (which means when items in the v6 milestone are complete or close to it), and do PRs to the release branch whenever cherry picking changes to it (I don't believe this was followed for the last release, which means we need to improve our processes here).
I believe the part of the development process (that I'm admittedly missing here for now) is the tracking of the parts of a feature by issues/checklists in the release milestone. For this PR, that's on me to create before this can be merged as partial progress.

Thanks for the explanation. For most part, it sounds good.

PRs to the release branch whenever cherry picking changes to it (I don't believe this was followed for the last release, which means we need to improve our processes here).

Great. This makes me less nervous about the process. I think it is something we need to bring up to the team; since this was not mentioned so far in any of the release process discussions.

, we should be following the process to branch off master when it is at a reasonable state (which means when items in the v6 milestone are complete or close to it)

I still have concerns about this.  However, what is the quality bar for each feature in master before we branch? How is the branch date determined? Is it a pre-determined date (if so, there is no guarantee that the in progress features meet the quality bar) or is it gonna be determined by evaluating the quality of each feature?
@CodeMonkeyLeet I would appreciate your input into this as well.

@anakrish I plumbed ep through to avoid the reindentation of the refactoring. Sorry, I thought we'd loosely agreed to do that in this PR, but I will redo it in a second PR.
TODOs for this PR:

[ ] Notice for 3rdparty code
[ ] Check for nullptr for nested code
[ ] Undo change to OE_WRITE_IN_PARAM

I still have concerns about this.  However, what is the quality bar for each feature in master before we branch? How is the branch date determined? Is it a pre-determined date (if so, there is no guarantee that the in progress features meet the quality bar) or is it gonna be determined by evaluating the quality of each feature?

My understanding is that although a lot of this responsibility is on the chosen release manager (such as choosing a date), the quality evaluation and testing falls on all of us as a team to do while preparing a release.

Opened https://github.com/microsoft/openenclave/issues/1839 to track changes for next iteration(s).

I am waiting on permissions to propagate so I can properly record the use of code from upstream OCaml, plus an approval from a reviewer. I believe I captured all the requested changes (and more!) in #1839.

bors try

bors try

bors try

bors r+

bors r+


Increment version for keyvault releases

Increment package version after release of com.azure azure-security-keyvault-jca

/check-enforcer override


Remove implicit {}-formatting of bash app command lines.

This will be a breaking change for users with { symbols in their
existing bash_app command lines - either for getting literal {
symbols in the command line (in which case, a layer of escaping
should be removed) or to perform arg substition (the functionality)
just removed, in which case users should perform that substitution
explicitly in their bash_app code.
See issue #992

There's a test failure here that doesn't fail on my laptop - I think it's because that particular test case looks for a file to come into existence but doesn't ensure it doesn't exist before the test starts - so in a fresh run directory, the test fails, but in a directory where the test has passed in the past, it will now pass forever. I'm distracted on something higher priority now so leaving this as a note for posterity.


v3-rc0: No information on how to cleanly exit ionic serve

What version of the CLI are you using? Output of ionic --version
3.0.0-rc0
Short description of the problem:
Running ionic serve gives no information on how to cleanly exit this process. Especially for GUI users on Windows using Ctrl+C to exit a running process is not common knowledge. I think many of them have to close the command line or open a new one to get back to the shell - I know I did for a long time ;)
(Or is there even a better, cleaner way to exit ionic serve I don't know about?)
What behavior are you expecting?
Starting process build process, server and then opening project in browser. Use Ctrl+C to quit this process and go back to command line.
Post the output of ionic info below please
global packages:
@ionic/cli-utils : 1.0.0-rc.0
Cordova CLI      : 6.5.0
Ionic CLI        : 3.0.0-rc.0

local packages:
@ionic/app-scripts              : 1.3.6
@ionic/cli-plugin-cordova       : 1.0.0-rc.0
@ionic/cli-plugin-ionic-angular : 1.0.0-rc.0
Ionic Framework                 : ionic-angular 3.1.1

System:
Node       : v6.10.2
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

Thanks, that's a good bit of info to put in any long-running terminal process


Backported timer code from lwIP 1.4.1 to prevent race conditions around the etharp and tcp timers.

Pull Request checklist
Note: these are not necessarily requirements

[ ] I reformatted the code with clang-format
[X] I checked to make sure my submission worked
[X] I am the author of submission or have permission from the original author
[ ] Requires update of the PS2SDK
[ ] Requires update of the gsKit
[ ] Others (please specify below)

Pull Request description
The current timer implementation involves a real timer that wakes up a thread, which will call tcp_tmr and etharp_tmr.
However, as these timers have no critical-region protection, it is possible for a race condition to occur between the timer and tcpip threads.
By back-porting the timer code from lwIP 1.4.1, it is possible to solve this by running the timers from the tcpip thread itself (cannot have a race condition when there is only one thread). When the core locking option is enabled (it is), it is protectected by the core locking semaphore.

Related to this bug: http://lwip.100.n7.nabble.com/bug-19206-the-ARP-layer-is-not-protected-against-concurrent-access-td13033.html


General error when trying to load a visual Variable panel

Hey guys,
Looks like there's an issue displaying the varibles on panel view (works on table view)

table view:

some more data that might help from inspect options:

query details:
{
"request": {
"url": "api/ds/query?ds_type=mysql&requestId=Q199",
"method": "POST",
"data": {
"queries": [
{
"refId": "A",
"datasource": {
"type": "mysql",
"uid": "eb0ca8d0-5e93-45b7-8d10-664bcc94a678"
},
"rawSql": "SELECT CONCAT(name, ' - ', globalid) AS globalid_name\r\nFROM ******.Sites;",
"format": "table",
"datasourceId": 3,
"intervalMs": 300000,
"maxDataPoints": 1862
}
],
"from": "1720310400000",
"to": "1720913400000"
},
"hideFromInspector": false
},
"response": {
"results": {
"A": {
"status": 200,
"frames": [
{
"schema": {
"refId": "A",
"meta": {
"typeVersion": [
0,
0
],
"executedQueryString": "SELECT CONCAT(name, ' - ', globalid) AS globalid_name\r\nFROM ******.Sites;"
},
"fields": [
{
"name": "globalid_name",
"type": "string",
"typeInfo": {
"frame": "string",
"nullable": true
}
}
]
},
"data": {
"values": [
[
"DemoSite - 6",
"Nitzanim C - 9",
"Nitzanim D - 100",
"Demo5 - 5",
"Demo12 - 12",
"Demo13 - 13",
"Demo11 - 0",
"Advantec - 1",
"EC2 - 10",
"Kfar Maimon Clone - 3"
]
]
}
}
],
"refId": "A"
}
}
}
}
will you be able to assist?

@LironTectu What Grafana version do you use? How did you install the plugin?

Hi mikhail and thank you for the help!,
Here's a screenshot of the grafana info (installed on prem)

the plugin was installed via the plugins screen (you can see that it's marked as installed)

version 3.2:

@LironTectu Interesting, do you see any errors in the Browser's Console which can help us to troubleshoot the issue?
I just tested 3.2.0 on the 11.0.0 release and it works as expected. We did not receive any other reports of the problem on Grafana 11, which makes me to believe it's isolated issue to your environment.

Hi Mikhail,
I have restarted the grafana environment and looks like it solved the issue but looks like the logs have dissapeared,
however if it will occur again I will also send you the console and grafana internal logs for you to have the info, maybe it will help others
thank you for the help so far!


flutter build ios-framework --cocoapods,There is no FlutterPluginRegistrant.framework

[flutter] flutter doctor -v
[✓] Flutter (Channel dev, v1.15.3, on Mac OS X 10.14.5 18F132, locale zh-Hans-CN)
• Flutter version 1.15.3 at /Users/wunan/Documents/sankuai/flutter
• Framework revision 67826bdce5 (3 weeks ago), 2020-02-10 14:59:32 -0800
• Engine revision 6158f03ef5
• Dart version 2.8.0 (build 2.8.0-dev.8.0 514a8d4c84)
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from: https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK components.
(or visit https://flutter.dev/setup/#android-setup for detailed instructions).
If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
You may also want to add it to your PATH environment variable.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C504
• CocoaPods version 1.8.4
[!] Android Studio (not installed)
• Android Studio not found; download from https://developer.android.com/studio/index.html
(or visit https://flutter.dev/setup/#android-setup for detailed instructions).
[!] IntelliJ IDEA Ultimate Edition (version 2017.3.2)
• IntelliJ at /Applications/IntelliJ IDEA.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[✓] VS Code (version 1.42.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.8.1
[!] Connected device
! No devices available
! Doctor found issues in 4 categories.
after run flutter build ios-framework --cocoapods,the result

but official website show

how to solve？thanks

Similar to https://github.com/flutter/flutter/issues/51113
@xinghunMeng do you have Flutter plugins in your module?

No

#51113，I know why，thank you， @VladyslavBondarenko


Suggestion about backspace location on the layout

As image below, could we have an option to set the backspace button to the normal spot, because while the <>? buttons is helpful, but I (and I think many other guys) may wrong-typo on it many times.
Imgur

I've never seen a keyboard in the US w/ a backspace there.  Where're such normal?

Gboard, GO keyboard, Swiftkey, Cheetah keyboard and many other top keyboard
use that style, you could have a look on google play to verify that 😆
On Tue, Feb 26, 2019, 23:29 TPS<EMAIL_ADDRESS>wrote:

I've never seen a keyboard in the US w/ a backspace there. Where're such
normal?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/klausw/hackerskeyboard/issues/721#issuecomment-467509666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9soUanYcuYdn_i-Fl4Qiznrzity7yYks5vRWDigaJpZM4bSkNf
.

OIC! :blush:  However, 1 of the points of HK is that it's supposed to be as similar as possible to a physical PC keyboard, w/ enhancements from that framework.

I think hackers keyboard is great, however I do have a big problem with it when it is in portrait mode and being used from chat apps (eg: Whatsapp). In those cases the the touch area for the backspace key and the send button end up being separated by only a few pixels. So when my text needs a correction, or when I want to remove the entire text it sometimes happens that I inadvertently touch the send button, so that the incorrect text is send. Perhaps the other keyboard layouts were specifically created to avoid this problem?
Example (see red ellipse):

Suggestion: does hackerskeyboard know the name of the app it's called from? Would it be possible to as an option to allow the user to select apps for which hackerskeyboard uses an alternate "Send Button Save" layout (with the backspace separated from the send) button (perhaps by calling the stock keyboard app. instead)?


Unmaintained library, support this project instead !

This is an Unmaintained framework, support this framework instead!

Mate, let it go.  The project is continuing on at https://github.com/materializecss/materialize. Plenty going on at https://gitter.im/Dogfalo/materialize too.  For those of us already using the framework any thoughts of moving to a new framework are nigh on impossible.

If you say so


Fix prepend condition

If we do:
$container->getExtensionConfig('unknown')

The result will be [] and not null.

@theofidry can you fix the broken tests ?

Yeah sorry a bit busy with the moving I'll fix that in the week

Any update @theofidry?

updated @dunglas. Maybe you want to backport this to the 1.0 too?

@theofidry yes, that would be nice if you can open this PR on 1.0 branch!

#295 was merged, 1.0 will be merged in master so closing.


Regression: regulator enable GPIO glitch during boot

Describe the bug
Since commit 539d4aa6e661c9100c866d9ae0b416fc5d14303f ("drivers: regulator: add common init enable API") by @gmarull fixed regulators that are enabled by the boot loader and marked in the Device Tree as regulator-boot-on are turned off for a very short time and turned back on again immediately. This usually violates timing restrictions, causing hardware to malfunction. It can also cause brown-outs.
To Reproduce
Steps to reproduce the behavior:

Use a fixed regulator with enable GPIO in Device Tree. E.g.:oscen: oscen {
	compatible = "regulator-fixed-sync", "regulator-fixed";
	label = "oscen";
	regulator-name = "oscen";
	enable-gpios = <&gpioh 1 GPIO_ACTIVE_HIGH>;
	regulator-boot-on;
};

Enable the GPIO in the boot loader.
Boot a Zephyr based application via the boot loader.

Expected behavior
Enable GPIOs of fixed regulators with regulator-boot-on (or regulator-always-on for that matter) are kept enabled during boot until they are disabled because they are not needed; there are no glitches on the enable GPIO.
One could argue that regulator-boot-on shouldn't even be necessary ("This property is intended to only be used for regulators where software cannot read the state of the regulator.") as the state of the enable GPIO can be read by software, but that's a separate topic.
Impact
Glitches can cause random malfunction. In my case the external oscillator stopped working (fortunately reproducibly), breaking half the system.
Logs and console output
Can be provided on request.
Environment (please complete the following information):
Should not have an impact on the bug.
Additional context
The DuT is an Arduino Portenta H7 board; see boards/arm/arduino_portenta_h7/arduino_portenta_h7_m7.dts. regulator-fixed is used because fixed-clock in Zephyr does not support enable GPIOs.

Thanks for reporting @silbe. Can you check if https://github.com/zephyrproject-rtos/zephyr/pull/57320 fixes your problem?

Thanks for reporting @silbe. Can you check if #57320 fixes your problem?

It does. Thanks for the fast fix!


To Reproduce
Steps to reproduce the behavior:

Go to https://mydomain/petition/petition_id/show_signatures
Click on "Re-send confirmation e-mail to all unconfirmed"

Expected behavior
The confirmation email should be sent only to the signatories that have not confirmed their signature yet but it is sent to all the signatories.

Wow, thanks for the report, it's amazing that this went unnoticed for so long!


[BUG]

Describe the bug
On too many relays, people are putting npub keys into the 'pubkey' field of nip-11, such as wss://relay.mostr.pub/, wss://relay.current.fyi/, wss://nostr.fmt.wiz.biz/, wss://nostr.mom/ (some of those are strfry, I filed a bug there too).
To Reproduce
Steps to reproduce the behavior:
Fetch the NIP-11 for a relay and discover someone put an npub formatted key in the pubkey field.  Clients that have strong typing fail to deserialize the NIP-11 structure.
Expected behavior
A hex public key
Screenshots

(see line at 2023-07-04T19:09:07.332724Z
System (please complete the following information):

OS: unknown
Platform: unknown
Version: 1.18.0

Logs
n/a
Additional context
NIP-11 states:
An administrative contact may be listed with a pubkey, in the same format as Nostr events (32-byte hex for a secp256k1 public key)

Could you (1) validate this and error or warn, or (2) make the comments/documentation very clear on this point so people don't make this mistake?
The gossip client is using strict typing and fails to deserialize these NIP-11 JSON objects, meaning the client is not providing any interesting relay information to the user, and gossip is presuming these clients do not support NIP-11 and not utilizing them fully.
Of course I could accept npub, but I fall into the camp of people who believe we should hold the line and defend the standards lest they proliferate into too many defacto variants.

Closed by https://github.com/Cameri/nostream/pull/355


Focus the packge search input on mount

Focus the packge search input on mount, to avoid typing in underlying code cell.
Without this behaviour, you'd press the search package button, start typing, and notice you're not typing in the search input field. Then you'd focus the input, search a package, try to add it, and see it can't be added because you had messed up the underlying code cell that doesn't compile anymore. This annoyed me a few times too may.
Also, I don't think the html attribute autofocus is not doing much there, if I understand this documentation. There is no <dialog> tag, and the autofocus behaviour only happens on pageloads. And it should be the only tag with this attribute on the page, which doesn't seem to be the case. I've left it in place, as I'm not sure.

Hmmm, I re-tested, and it doesn't seem to work consistently. Sorry for the noise. If someone has a suggestion for a better phx-binding and/or JS-commands, I'll test it.

Hey @linusdm! autofocus should actually do the job, because we have this additional logic:
https://github.com/livebook-dev/livebook/blob/7584a02adbe717616838954f73d27ba66b35d4bd/assets/js/dom.js#L21-L30
I never noticed it misbehaving in Brave, and I've just checked it works in Chrome, Firefox and Safari. What browser do you use?

I'm on firefox. I recorded how it behaves on my machine.
https://user-images.githubusercontent.com/43893333/210400737-9e835888-444b-4d2c-aadc-6caea991bcbc.mov

Ahh, that's when you have the editor focused and open package search, because we force editor focus when in insert mode.

That explains the seemingly inconsistent behaviour I was seeing. So my change didn't add anything useful  🙈
I'm curious if you, or others, are also surprised by this behaviour sometimes. If not, I can perfectly let it go 🙃

I don't have a strong opinion, since I always use the sp shortcut, but in this case I think exiting insert mode automatically makes sense. Changed in 9f14beaf7b76810b932641bddcdb8fe9e4686cd5 :)

Tested it, and works like a charm! 🌈
TIL about the sp shortcut. I really like that package search dialog, as it avoids going to hex.pm and keeps me more in flow.
Thx!


(BKR-79) added deprecated warning to host defaults

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/644/
:red_circle: Test failed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/647/
:green_heart: Test passed.


localStorage table data rollback when update after refresh page twice using update query in browser

when insert some data its fine , and i try update one record its fine updated , but after refresh twice in browser , why data value back seem like before update ?  i use localStorage db

i found maybe its some trouble when i set autocommit on , when i using localStorage DB engine, if autocommit ON it value look like rollback

Please provide code that demonstrates the problem.

// app.js
angular.run(function () {
alasql.options.autocommit = true;
alasql('CREATE localStorage DATABASE IF NOT EXISTS mydb');
alasql('ATTACH localStorage DATABASE mydb');
alasql('USE mydb');
});
// controller
function queryData () {
var data = alasql('SELECT * FROM user');
$scope.dataView = data;
}
$scope.$watch('$scope.parameter', function(n,o) {
if (n !== o) {
queryData();
}
}, true);
$scope.click = function () {
}


Bug with full page.js + scroll reveal.js

Hello,
you're plugin is just awesome! But i have a problem when i use the plugin with "full page.js" by alvarotrigo. In fact, you're plugin doesn't work when i add fullpage.js to my website page. Have you got a solution? thank you a lot

@basile121 you can use it together with fullPage.js if you initialize it in the afterRender callback and if you make use of the scrollBar:true option or otherwise use the autoScrolling:false.
From the fullPage.js FAQ:

fullPage.js doesn't actually scroll the site but it changes the top or translate3d property of the site. Only when using the fullPage.js option scrollBar:true or autoScrolling:false it will actually scroll the site in a way it is accessible for the scrollTop property.

Thanks for this @alvarotrigo !


expand list of compilations to full set supported by Snaptron

making this official, since at this point it's high priority.
additional compilations which at least should be available in Snapcount are:

encode1159
mesa
ct_m_s
ct_h_s

all 4 now working.


Added Remult

Remult is a framework for type-safe CRUD from frontend to backend to database and optimal TypeScript model code sharing between frontend and backend.
and it is built entirely in TypeScript... 🥇

Merged. Thank you @yoni-rapoport!


Fixed QuickMenuManager.playerListSlots

Made QuickMenuManager.playerListSlots contain the MoreCompany player list slots

Any benefits to this?

Any benefits to this?

The new code doesn't re-add all slots each time a player joins, it just uses the same logic as vanilla.
Other mods that access QuickMenuManager.playerListSlots will have the reference to the correct player slot object instead of the hidden vanilla one


Rails request events should log more than just headers

Possible candidates:
request.origin
request.base_url
request.x_csrf_token

params[:controller]
params[:action]
params[:authenticity_token]

Although Lograge already extracts controller and action, so we could probably skip those.


Screen sharing doesn't work

Describe the bug
The video widget allegedly allows for screen sharing per the features listed here. When spinning up an instance of the app, however, screen sharing doesn't work. This behavior can be reproduced on a deployed resource.
To Reproduce
Steps to reproduce the behavior:

Clone repo and start it up using the provided steps. You can also see a deployed version here.
Enter a room and click share screen. Accept all required permissions and click share screen in the dialog that pops up. In safari, there's an icon that shows a "screen" as if the screen is being shared.

Expected behavior

I'd expect my screen to either be visible in the main grey area or in my thumbnail picture
Actual behavior: no screen is visible :(

Screenshots

Environment

OS: mac, latest
Browser: chrome. reproduced in safari. safari does show an icon that seems to symbolize that i'm using
App Version: 0.1.0
SDK Version: "twilio-video": "^2.3.0",
Node.js version: v12.16.1

Hey @imjared! Thanks for the issue, and thanks for the deployment link!
I tried your deployment link and you are correct, there does seem to be a problem. I took a look at the source maps in the browser dev tools and it looks like src/components/MainParticipant/MainParticipant.tsx has been changed. This is the code that I see in the source maps:
import MainParticipantInfo from '../MainParticipantInfo/MainParticipantInfo';
import ParticipantTracks from '../ParticipantTracks/ParticipantTracks';
import React from 'react';
import useMainSpeaker from '../../hooks/useMainSpeaker/useMainSpeaker';
import useSelectedParticipant from '../VideoProvider/useSelectedParticipant/useSelectedParticipant';
import useScreenShareParticipant from '../../hooks/useScreenShareParticipant/useScreenShareParticipant';

export default function MainParticipant() {
  const mainParticipant = useMainSpeaker();
  const [selectedParticipant] = useSelectedParticipant();
  const screenShareParticipant = useScreenShareParticipant();

  const videoPriority =
    mainParticipant === selectedParticipant || mainParticipant === screenShareParticipant ? 'high' : null;

  console.log(mainParticipant);

  return (
test
)

  // return (
  //   /* audio is disabled for this participant component because this participant's audio
  //      is already being rendered in the <ParticipantStrip /> component.  */
  //   <MainParticipantInfo participant={mainParticipant}>
  //     <ParticipantTracks participant={mainParticipant} disableAudio enableScreenShare videoPriority={videoPriority} />
  //   </MainParticipantInfo>
  // );
}

This would explain why we are seeing "test" in your screen shots. It looks like the main participant (who may be sharing their screen) is not being rendered. Reverting this file back to its normal state should fix everything for you.

🤦♂ you're a saint. had changed this yesterday to get it running while #115 was broken.
thanks for the quick reply

Not a problem! 😄👍


Possible straw.py issue for older hic versions

I'm working on developing a converter from .hic to .cool files (hic2cool) and came across a possible issue with a test file of hic version 6. The binX, binY, and counts values were not correct within the readBlock function.
The file is IMR90.hic and can be found here: https://bcm.app.box.com/v/aidenlab/folder/11235404320.
I was able to get the correct counts (i.e. ones that matched the output of juice_tools dump) by changing the lines 323 to 325 in python/straw.py. https://github.com/theaidenlab/straw/blob/65f0e94bf7cc11cfa6a9e7ddaf50205591bb6069/python/straw.py#L323-L325
Looking closely, the binX value == nRecords for i=0 in the loop over range(nRecords), which explains the problem. I changed the range of bytes read and it seems to work:
x = struct.unpack(b'<i', uncompressedBytes[(12i+4):(12i+8)])[0]
y = struct.unpack(b'<i', uncompressedBytes[(12i+8):(12i+12)])[0]
c = struct.unpack(b'<f', uncompressedBytes[(12i+12):(12i+16)])[0]
Just thought I would let you know in case this is a valid issue you want to fix.
Best,
Carl

Could you do a pull request?
On Wed, Oct 18, 2017 at 1:10 PM, carlvitzthum<EMAIL_ADDRESS>wrote:

I'm working on developing a converter from .hic to .cool files (hic2cool)
and came across a possible issue with a test file of hic version 6. The
binX, binY, and counts values were not correct within the readBlock
function.
The file is IMR90.hic and can be found here: https://bcm.app.box.com/v/
aidenlab/folder/11235404320.
I was able to get the correct counts (i.e. ones that matched the output of juice_tools
dump) by changing the lines 323 to 325 in python/straw.py.
https://github.com/theaidenlab/straw/blob/65f0e94bf7cc11cfa6a9e7ddaf5020
5591bb6069/python/straw.py#L323.
Looking closely, the binX value == nRecords for i=0 in the loop over
range(nRecords), which explains the problem. I changed the range of bytes
read and it seems to work:
x = struct.unpack(b'<i', uncompressedBytes[(12i+4):(12i+8)])[0]
y = struct.unpack(b'<i', uncompressedBytes[(12i+8):(12i+12)])[0]
c = struct.unpack(b'<f', uncompressedBytes[(12i+12):(12i+16)])[0]
Just thought I would let you know in case this is a valid issue you want
to fix.
Best,
Carl
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/theaidenlab/straw/issues/21, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWiW-qCppzdE8dwlpLTeUKKhxNoOXYRks5stjEVgaJpZM4P-DMd
.

--
Neva Cherniavsky Durand, Ph.D.
Staff Scientist, Aiden Lab
www.aidenlab.org

Certainly. https://github.com/theaidenlab/straw/pull/22

Thanks!


feat: Match target width/height

Would be nice to have a feature where it could make the element's width/height match that one of the target.
This would be useful to make things like custom Dropdowns, where you want the popping list to stick to the component while keeping the same width.

There was a PR for this a while back: #203 At this time we're not adding new features to Tether, so I'd encourage you to try that code out on a fork.


Plunker to latest version

Hi!
Please update plunker to latest versions of Angular 2 and angular2-img-cropper.
Thanks!

+1 Here is not working

new plnkr
https://embed.plnkr.co/VFwGvAO6MhV06IDTLk5W/


feat: audio preview

--- Releases ---
Android release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:android:6cf0cd5ec064fad3ffce07/releases/1v1ohhn17im8o
iOS release: https://appdistribution.firebase.google.com/testerapps/1:305132849030:ios:06ea33a95a2e0d42ffce07/releases/5a8h4ikh2ae3g

Closing this one. When we prioritize this feature again we can reopen it.


Direct Access Grafana

When accessing from Dashboard, user should not be prompted for passwords.

Not a good idea. Closing.


Add arm/bicep deployment to pipelinewitness ci

Use the pipeline-witness's deploy.ps1 script to deploy to staging and prod.
Pulling arm deployment work from #8147

/check-enforcer override
There is no PR pipeline for pipeline-witness


[release-4.16] OCPBUGS-30282: Multiple MachineConfigs in one CM

This PR is a manual cherry-pick of  https://github.com/openshift/hypershift/pull/3695 into branch release-4.16 because automatic /cherry-pick failed due to a code conflict.

/retest-required

/retest-required

/retest-required

/retest-required

/retest

You need to fix the release note :).
/approve

/jira refresh

/jira refresh

/jira refresh

@jparrill the release note is fixed now

/lgtm


[@ui-kitten/components: 5.0.0] Input, if multiline is set to true secureTextEntry does not work

As the title says, quite simple to reproduce, if an Input has the multiline prop set to true the secureTextEntry does not work (it does not hide the text).
import React from 'react';
import { TouchableWithoutFeedback } from 'react-native';
import { Icon, Input } from '@ui-kitten/components';

const AlertIcon = (props) => (
  <Icon {...props} name='alert-circle-outline'/>
);

export const InputThemingShowcase = () => {

  const [value, setValue] = React.useState('');
  const [secureTextEntry, setSecureTextEntry] = React.useState(true);

  const toggleSecureEntry = () => {
    setSecureTextEntry(!secureTextEntry);
  };

  const renderIcon = (props) => (
    <TouchableWithoutFeedback onPress={toggleSecureEntry}>
      <Icon {...props} name={secureTextEntry ? 'eye-off' : 'eye'}/>
    </TouchableWithoutFeedback>
  );

  return (
    <Input
      value={value}
      label='Password'
      placeholder='Place your Text'
      caption='Should contain at least 8 symbols'
      accessoryRight={renderIcon}
      captionIcon={AlertIcon}
      secureTextEntry={secureTextEntry}
      onChangeText={nextValue => setValue(nextValue)}

      multiline={true}
    />
  );
};

@ValterSantosMatos this should be an RN issue. See the Snack.

Hello, I guess this is not fixed yet ☺ The snack provided shows that it's not working (at least on my end).
I fixed by setting
const [secureEntry, setSecureEntry] = useState(false);
// ...
multiline = {!secureEntry}
secureTextEntry={secureEntry}


[Backport][BUG] Add support to clear archived index settings

Description
Backport PR https://github.com/opensearch-project/OpenSearch/pull/9019 to 2.x branch
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/2803
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/23298/
CommitID: 6b849f1
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

org.opensearch.indices.settings.ArchivedIndexSettingsIT.testArchiveSettings


Android performance exceptionally poor with FrameStatisticsMode.Full

Issue:
The draw fps of a very simple android app(only a background sprite and a box for darkening it) is constantly around 10-15.
Only code I have left uncommented is setting the window state to fullscreen, showing the full frame statistics and a method called on load, pasted below.
EDIT: To be noted, the app without any commented elements more UI elements was running at around 40 fps, until it randomly got to 15 even when removing most elements.
    private void addBackground()
    {
        Add(new Sprite // Background
        {
            Texture = Textures.Get("background.jpg"),
            RelativeSizeAxes = Axes.Both,
            Size = new Vector2(1, 1),
        });
        Add(testBox = new Box   // Background Opacity Mask
        {
            RelativeSizeAxes = Axes.Both,
            Colour = Colour4.FromARGB(0x88000000),
        });
    }

In this github repo you can see the full code: https://github.com/CatalinTermure/CytoidChartEditor
Frame Statistics:

Device used: Xiaomi Mi A1
Device specs:
CPU – Octa-Core 2.0GHz ARM Cortex-A53
Chipset – Qualcomm Snapdragon 625 MSM8953
GPU – Qualcomm Adreno 506

Possibly a frame synchronisation issue, or possibly hitting your devices fill rate (looks to be somewhere between 4-6GPix/s, which likely shouldn't be the case with your ~2x fill rate).
Have you tried switching on multithreading to see if it helps? Also make sure you are not building as debug.

Can reproduce, but not to the same degree (draw thread is taking ~30ms in single-threaded and surprisingly even more - circa ~70ms on multi-threaded). Investigating.

It was a debug build, so that was why it was this bad. Building on release, I got similar results with ~70 ms on both single-threaded and multi-threaded.

One thing I can say for sure right now is that setting FrameStatisticsMode to Full carries a performance penalty in itself on mobile. Using Minimal instead improves frame rate considerably (going from ~30fps with only the background showing to 60fps in single-threaded mode). I can also reproduce this in the framework sample game.
Enabling UI makes fps go down to ~16, however. Unsure what that is about but it might be just lack of optimisation.

Setting FrameStatisticsMode to Minimal was a solution, which is weird because I switched from Minimal to Full to make this report after the frames were this bad.
Regarding the UI, some parts of the UI were made specifically with lack of optimisation in mind, particularly the long notes because they are made with individual boxes, instead of a cut-off sprite. It's up to you to decide if the ~20 fps is acceptable for ~70 solid color boxes and ~20 sprites. If so, then feel free to close this issue.

Seeing that the lazer editor itself runs at ~15fps right now on android I'd say we might not be able to do better for now, although of course the goal is to improve on that result in the future.

Ok so this issue boils down to FrameStatisticsMode.Full being close to unusable on android because of the extreme frame loss, as the rest is perfectly understandable.

Probably worth further investigation at some point. That overlay shouldn't really be reducing performance. Possibilities:

The region upload is not working as efficiently as we are expecting it to on certain GPUs.
There are too many GCs happening and the little boxes showing this on the display are adding the overhead.


Change enemy size by ESL ID

Describe the feature you'd like to see added
@emoose We found out where the size of the enemies changes, we tested it in the claw and in the mega
Just change the floating point in HEX
We wanted to know if you can find out how to change the esl id or the enemy's pointer I'll leave the hex here
(values stored in float32)
Garrador 1B 0A - 70D264
Mega Salvador 20 16 - 70CA18

Different animals haven't the same offset, and the .esl file is not made for the size, there is no memory for that.


[PRCI, DCI] Approve/deny and include custom message in response to demand

A user of the DCI component should be able to provide a custom message when responding to a demand and this message should be visible to the user of the PRCI when viewing the status of their demand.

Deny
PRCI

DCI


Incorrect page title of the Stack demo page

Currently, the the title of the Stack demo page starts with BitStack which is not correct. The correct value does not have Bit at the start and should be Stack.
The line that needs to be updated is in this link:
https://github.com/bitfoundation/bitplatform/blob/4321ff327a51f2238e6114af139eb5965c4be35a/src/BlazorUI/Demo/Client/Core/Pages/Components/Stack/BitStackDemo.razor#L4

Can i take this up ?

Sure, go ahead 🚀

I already have a PR open for an existing issue, will be looking at the
‘up-for-grabs’ label next but Thanks anyways😊
On Fri, 20 Oct 2023 at 02:34, Saleh Yusefnejad @.***>
wrote:

Sure, go ahead 🚀
—
Reply to this email directly, view it on GitHub
https://github.com/bitfoundation/bitplatform/issues/5685#issuecomment-1771703817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASBJB3PDMJG6W373SIAO4LDYAGIVVAVCNFSM6AAAAAA6GYNNJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRG4YDGOBRG4
.
You are receiving this because you commented.Message ID:
@.***>


[CROSSDATA-588] Each command envelope now includes the user associated to the session.

Description
A mechanism to link session ids to user ids is needed. Since the client will be considered a trusted agent (indeed it is the client who generates the session id) and the channel integrity will be guaranteed, there is no problem in sending the user along side the session id within each CommandEnvelope message. Thus reducing the boilerplate this functionality would require if a relation table were keep at server side.

:+1:

LGTM

Coverage decreased (-0.1%) to 54.18% when pulling c8fb342b96c0cde1e0e518d22447d8e750e90d6c on pfcoperez:xd588_session_credentials into 4b4ea736024c8f043d9913272c8d05c76c73b548 on Stratio:master.


Page not found on lessons routes

Going to any c0d3.com/curriculum/* page results in 404 lesson not found error screen quickly transitioning to the correct page.

Can you reliably reproduce this issue on the prod deployment? I'm not able to.

It's sneaky, that's how it looks. I have troubles to reliable reproduce it too, but I definitely noticed it a few times in production.


First implementation

This is the first implementation of embulk-input-trino-jdbc.
This plugin extends embulk-input-jdbc.
This plugin uses trino-jdbc and supports some of the options found at https://trino.io/docs/current/client/jdbc.html.
I write following files:

README.md
build.gradle
src/main/java/com/reproio/embulk/input/trino/TrinoJdbcInputPlugin.java

Other files are auto-generated.
TODOs (create other PRs possibly):

[ ] Setup credentials to publish packages
[ ] Setup signing
[ ] Add tests
[ ] Setup CI
[ ] Setup tagpr?

See followings about Embulk plugins:

https://joker1007.hatenablog.com/entry/2021/05/28/021140
https://zenn.dev/dmikurube/articles/get-ready-for-embulk-v0-11-and-v1-0
https://zenn.dev/dmikurube/articles/what-changes-in-embulk-v0-11
https://zenn.dev/hiroysato/articles/b910af4c581bdb
https://dev.embulk.org/topics/catchup-with-v0.10.html

@joker1007 @akihiro17 Can you take a look?

I will review this tomorrow.


Invocation from WSL2 does not work

My understanding is that WSL2 should be able to invoke .exe files (e.g., I do that with cmd.exe occasionally). But if I try to run winget I get the following error:
% /mnt/c/Users/mdale/AppData/Local/Microsoft/WindowsApps/winget.exe
Failed to execute process '/mnt/c/Users/mdale/AppData/Local/Microsoft/WindowsApps/winget.exe'. Reason:
exec: Exec format error
The file '/mnt/c/Users/mdale/AppData/Local/Microsoft/WindowsApps/winget.exe' is marked as an executable but could not be run by the operating system.

I'm using WSL2/Ubuntu on the Win 10 insider ring.

Wrong repo, sorry!


Fix radar page so that it uses domains from data file (instead of hard-coded BSIMM)

Similar issue to the #99 bug

Done (fix for #99 also addressed this issue)


Feature request: Code block with filename

Commonmark doesn't have these yet. I think they can be implemented as shortcodes (like callouts?):
{% code(toml, name="config.toml" %}
[section]
value = "foo"
{% end %}

// or...

{% code(lang=toml, name="config.toml" %}
[section]
value = "foo"
{% end %}

It's a feature nice to have, but I don't have a strong will to implement it myself. If you really need this, you can try to implement it yourself or wait for other people's pr.


How resources are included?

Very good work. I consult you how resources are included (whether rooms or people / employees).
regards

It's not possible yet.
I thought about it during the v2 development and I'll probably add it later.

Ok. Thanks.
Please, some dynamic. Add columns and rows dynamically.
Regards

What do you mean by columns and rows ?

Sorry as I do not speak English very correctly I do not express myself well. I mean, add columns that list resources and be able to associate them with daily, monthly, weekly, etc. calendar information.


Add support for selective serialization/deserialization of automorphism/rotation keys

This is useful to control the memory footprint for scenarios with a large number of automorphism keys, e.g., in applications using CKKS bootstrapping. Only the automorphism keys needed for a particular computation can be loaded into the memory.

Use a separate a file for each automorphism key


Python support

Hi all,
Is there already an ETA on when python support becomes available?
Cheers,

Closed as I was too lazy to read the closed issues...


Model not loading

Hello,
I had a previous project where I was running a function with the instructor similarity to calculate the semantic similarity,
I come back to this project finding that I am unable to load the model with an error that I hadn't come across before:

TypeError                                 Traceback (most recent call last)
 in <cell line: 2>()
1 from InstructorEmbedding import INSTRUCTOR
----> 2 model = INSTRUCTOR('hkunlp/instructor-base')
/usr/local/lib/python3.10/dist-packages/sentence_transformers/SentenceTransformer.py in init(self, model_name_or_path, modules, device, cache_folder, trust_remote_code, revision, token, use_auth_token)
192
193             if is_sentence_transformer_model(model_name_or_path, token, cache_folder=cache_folder, revision=revision):
--> 194                 modules = self._load_sbert_model(
195                     model_name_or_path,
196                     token=token,
TypeError: INSTRUCTOR._load_sbert_model() got an unexpected keyword argument 'token'
I would appreciate the assistance on this issue!

Ah solved it, it was a simple dependency issue with the sentence transformers ( they updated a new version 9 hours ago) so just make sure to pip install sentence_transformers==2.2.2

Same, supporting newer transformers would be great, because e.g. nomic needs at least transformers 2.3 because of the trust_remote_code.

+1
Also, the resulting instruction embeddings using sentence-transformers=3.0.1 is different from using sentence-transformers=2.2.2 which makes sense but leaving it here for completeness.

The owners of this repository don't really update anymore, but you can try my fork here instead, which is compatible with the newest version of sentence-transformers:
https://github.com/BBC-Esq/instructor-embedding

Or you can use my fork from #115 , which contains few more additions https://github.com/racinmat/instructor-embedding/tree/main

A fork of my fork!  lol I like it.  What else did you add?

I reverted some renamings, so the class names are compatible with the version of instructor released on pypi and I added support for offline loading, so if the weights are present locally, it does not have to reach to the internet.