Simple form wrappers break with new entries

Great library!  Unfortunately it appears that when using simple_form wrappers that cocoon doesn't correctly pick up on these wrappers when inserting new elements.  I tested my problem with the demo app and replicated the problem.
E.g. in the coccoon_simple_form_demo if we replace:
      = f.simple_fields_for :people do |person|

with a built-in simple_form wrapper like horizontal_form
     = f.simple_fields_for :people, wrapper: :horizontal_form, wrapper_mappings: { select: :floating_labels_select} do |person|

the first form entry will render with the correct simple_form wrappings, but subsequent entries won't.  (See photo.)

Ha, cool, never specified the wrapper on the simple_fields_for before (just on the complete form). Let me look into that.

Looking into this, it's clear the custom SimpleForm wrappers aren't being passed.  E.g. here is the difference in the HTML:
//correct:

  <select class="custom-select select required" name="derivative_template[derivatives_attributes][0][portfolio_name]"
    id="derivative_template_derivatives_attributes_0_portfolio_name">
    <option value=""></option>
    <option value="A">A</option>
    <option value="B">B</option>
    <option value="C">C</option>
    <option value="D">D</option>
  </select>
  Client *

 // Incorrect nested form

  Client *
  <select class="form-control select required" placeholder="Select company"
    name="derivative_template[derivatives_attributes][1597275653537][portfolio_name]"
    id="derivative_template_derivatives_attributes_1597275653537_portfolio_name">
    <option value=""></option>
    <option value="A">A</option>
    <option value="B">B</option>
    <option value="C">C</option>
    <option value="D">D</option>
  </select>

The major difference being that the div is not form-label-group and the select does not have custom-select.
I suspect these reasons might be this line of code for render_association:
      render_options = received_render_options.dup

Could .deep_dup help retrieve the wrapper_mappings hash?
Following that, I could also see the issue being with how render_association builds the new form object:
    def render_association(association, f, new_object, form_name, received_render_options={}, custom_partial=nil)
      partial = get_partial_path(custom_partial, association)
      render_options = received_render_options.dup
      locals =  render_options.delete(:locals) || {}
      ancestors = f.class.ancestors.map{|c| c.to_s}
      method_name = ancestors.include?('SimpleForm::FormBuilder') ? :simple_fields_for : (ancestors.include?('Formtastic::FormBuilder') ? :semantic_fields_for : :fields_for)
      f.send(method_name, association, new_object, {:child_index => "new_#{association}"}.merge(render_options)) do |builder|
        partial_options = {form_name.to_sym => builder, :dynamic => true}.merge(locals)
        render(partial, partial_options)
      end
    end

Seeing this I tried to throw arguments to received_render_options here using this code, but it didn't work, e.g.:

      <%= f.simple_fields_for :derivatives,
        wrapper: :floating_labels_form,
        wrapper_mappings: {
          select: :floating_labels_select
        } do |d| %>

          <%= render 'derivative_fields', f: d %>

      <% end %>

        <%= link_to_add_association 'add derivative', f, :derivatives, {wrapper: :floating_labels_form, wrapper_mappings: {select: :floating_labels_select} } %>


Simplify README example

Have a basic, and an advanced example
The basic example will require us to move the load data function to auto_ml proper, not the test suite. But make it super, super simple.
Then, have a blatant showing-off-more-features example that includes stuff like saving, nlp, maybe even verify_features, etc.

Examples I want to show in the README:

[ ] .score(verbose=3)
[ ] timing individual predictions
[ ] saving to disk, loading in from disk, and getting predictions
[ ] nlp example
[ ] verify_features?
[ ] XGBRegressor/classifier
[ ] LGBMRegressor/Classifier
[ ] optimize_final_model=True
[ ] perform_feature_selection=False


Globe Widget Spams Log with Rate Limited Errors

Describe the bug
When booting a node in some locations (for example SE Asia?), we get
Mon 21:46 kino_updates:sys: Failed to parse location: Object {"error": Bool(true), "message": String("Visit https://ipapi.co/ratelimited/ "), "reason": String("RateLimited")}

To Reproduce
Unclear, some nodes work, others don't
Expected behavior
Less log spam at least, to make debuggin things on this node easier.

No such thing as a free lunch...
I'll add a failure tracker that instructs the widget to give up if it can't get a response from the API in a few tries. Sorry about that. Can uninstall:app_store:sys kino_updates:sys as needed for now.

Limit added

I have created this feature request ticket pitching IPinfo: https://github.com/kinode-dao/kinode/issues/555
IPinfo provides up to 1,000 requests per day without any access token from individual unique IP addresses.


Where to get test cases

Summary
Where to get test cases
Description:
May I know where I should obtain the test cases for both lab 1 and exercise 1?
Code Snippets
Attach code snippets (if any)
Screenshots
Screenshots (if any)

I think you can submit the code into CodeCrunch and see the resulting output.

I think you are supposed to write them yourself typing in the terminal:
vim exampleinput.in
then create your own set of inputs.

the page with the problem has some of the test inputs and expected outputs already at the bottom of the page I think those should suffice for testing

Alternatively, you can create some of your own test cases as a sanity check.
For example, this below checks that it can basically function.
1
1.0 1.0

And I create this to check if the leaving is handled correctly.
1
1.0 1.0
1.5 1.0

Once I am all done, I create larger test cases, or borrow them from the task themselves.


Make ConvBNReLU a subclass of ConvBNAct to keep backward compatibililty

Why is that code in init.py ?
Good suggestions, thanks. It was added there while ConvBnRelu was a function, but since it's a subclass now it make sense to move to separate file. Done


Specify lint-versions and fix docker build issues due to nvidia-384

Description
Specify and fix pylint as well as cpplint versions in order to provide a consistent behaviour. Otherwise, new slaves (having no docker cache present) might use a newer version of linting and produce different results. Linting reports for the latest version have been fixed in #9660.
Due to Nvidias update regarding the spectre vulnerability, we were not able to use the nvidia-384 package inside our Dockerfiles. Instead, we're now switching to the cuda-8-0 package, which matches our general CI setup to support CUDA 8.0.
 I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Set CppLint to 1.3.0
Set PyLint to 1.8.2
Get CUDA stubs in build_cuda from cuda-8-0 instead of nvidia-384.

Comments

@cjolivier01 @reminisce @zheng-da As soon as this PR is merged, you will again be able to make changes to the dockerfiles without failing with the nvidia-384 error.
@szha @eric-haibin-lin

Can this be merged?


Fastlane Throws me into Playground Console

New Issue Checklist

[*] Updated fastlane to the latest version
[*] I have read the [Contribution Guidelines]

Issue Description
I just updated to the latest (2.1.3) version of fastlane and it always throws me into the playground when I run a spaceship command:
➜  mytours-ios git:(develop) ✗ bundle exec fastlane spaceship build
Logging into to iTunes Connect (business@***.com)...
Successfully logged in to iTunes Connect

Logging into the Developer Portal (business@***.com)...
Successfully logged in to the Developer Portal

---------------------------------------
| Welcome to the spaceship playground |
---------------------------------------

Enter docs to open up the documentation
Enter exit to exit the spaceship playground
Enter _ to access the return value of the last executed command

Just enter the commands and confirm with Enter

From: /Users/barnacle/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/fastlane-2.1.3/spaceship/lib/spaceship/playground.rb @ line 63 Spaceship::Playground#run:

    58:
    59:       # rubocop:disable Lint/Debugger
    60:       binding.pry(quiet: true)
    61:       # rubocop:enable Lint/Debugger
    62:
 => 63:       puts "" # Fixes https://github.com/fastlane/spaceship/issues/203
    64:     end
    65:
    66:     def docs
    67:       url = 'https://github.com/fastlane/fastlane/tree/master/spaceship/docs'
    68:       `open '#{url}'`

Any ideas of why?
Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.2

Ruby
2.3.1

Bundler?
true

Git
git version 2.11.0

Installation Source
~/.rbenv/versions/2.3.1/bin/fastlane

Host
Mac OS X 10.12.2 (16C67)

Ruby Lib Dir
~/.rbenv/versions/2.3.1/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2

System Locale

Variable
Value

LANG
en_NZ.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
fastlane_require 'byebug'

fastlane_version "1.111.0"

default_platform :ios

APP_SETTINGS = nil

platform :ios do
  before_all do
    APP_SETTINGS = JSON.parse(File.read('../Bundle/Updates/app.json'))
    cocoapods
  end

  desc "Create certificate and provisioning profiles"
  lane :provision_app do
    cert(output_path: './downloads/certificates')

    app_id                = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
    watchkit_app_id       = "#{CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)}.watchkitapp"
    wathckit_extension_id = "#{CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)}.watchkitapp.watchkitextension"

    produce( app_name: APP_SETTINGS["name"],                         skip_itc: true, app_identifier: app_id)
    produce( app_name: "#{APP_SETTINGS["name"]} Wathckit App",       skip_itc: true, app_identifier: watchkit_app_id)
    produce( app_name: "#{APP_SETTINGS["name"]} Wathckit Extension", skip_itc: true, app_identifier: wathckit_extension_id)

    sigh( app_identifier: app_id,                 force: true, output_path: './downloads/provisioning_profiles', filename: "#{app_id}.mobileprovision" )
    sigh( app_identifier: watchkit_app_id,        force: true, output_path: './downloads/provisioning_profiles', filename: "#{watchkit_app_id}.mobileprovision" )
    sigh( app_identifier: wathckit_extension_id,  force: true, output_path: './downloads/provisioning_profiles', filename: "#{wathckit_extension_id}.mobileprovision" )

  end

  desc "Build a new version for the App Store"
  lane :build do
    app_id                = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
    gym(scheme: "MyTours", output_directory: './downloads/builds', output_name: "#{app_id}.ipa")
  end

  desc "Deploy a new version to the App Store"
  lane :release do
    app_id = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
    produce( app_name: APP_SETTINGS["name"], skip_itc: false, skip_devcenter: true, app_identifier: app_id)
    deliver
  end
end```
</details>

<details><summary>`./fastlane/Appfile`</summary>

```ruby
app_identifier "com.mytoursapp.kroad" # The bundle identifier of your app
apple_id<EMAIL_ADDRESS># Your Apple email address

team_id "3EUQ5Y2B6L"  # Developer Portal Team ID
# itc_team_id 118293679

fastlane gems

Gem
Version
Update-Status

fastlane
2.1.3
✅ Up-To-Date

credentials_manager
1.0.0
✅ Up-To-Date

spaceship
1.0.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.2

bundler
1.13.6

io-console
0.4.6

rake
12.0.0

CFPropertyList
2.3.4

i18n
0.7.0

json
1.8.3

minitest
5.10.1

thread_safe
0.3.5

tzinfo
1.2.2

activesupport
<IP_ADDRESS>

public_suffix
2.0.4

addressable
2.5.0

babosa
1.0.2

byebug
9.0.6

claide
1.0.1

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.0.0

cocoapods-deintegrate
1.0.1

cocoapods-downloader
1.1.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.0.0

netrc
0.7.8

cocoapods-trunk
1.1.2

cocoapods-try
1.1.0

colored
1.2

escape
0.0.4

fourflusher
0.3.2

molinillo
0.4.5

nanaimo
0.2.3

xcodeproj
1.4.2

cocoapods
1.0.0

coderay
1.1.1

highline
1.7.8

commander
4.4.2

dotenv
2.1.1

excon
0.54.0

multipart-post
2.0.0

faraday
0.10.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.10.1

fastimage
2.0.1

gh_inspector
1.0.2

jwt
1.5.6

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

hurley
0.2

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.0.15

representable
2.3.0

retriable
2.1.0

google-api-client
0.9.20

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.2.0

rubyzip
1.2.0

security
0.1.3

slack-notifier
1.5.1

terminal-notifier
1.7.1

unicode-display_width
1.1.2

terminal-table
1.7.3

word_wrap
1.0.0

rouge
1.11.1

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

credentials_manager
1.0.0

httparty
0.14.0

method_source
0.8.2

mini_portile2
2.1.0

nokogiri
<IP_ADDRESS>

slop
3.6.0

pry
0.10.4

pry-byebug
3.4.2

zip
2.0.2

generated on: 2016-12-21

@fastlane-bot Nope - This happens even when we are just trying to use cert to generate a cert to start with.

Hey @barnaclebarnes, thanks for submitting your issue. Sorry, but I'm not sure that I follow. I just tried it on spaceship 0.39.0 and it has the same behaviour - both cert and build are not spaceship commands. If you just want to run a fastlane lane, running fastlane cert or fastlane build is enough.

@milch In my Fastfile I have the cert command. So I'm running:
bundle exes fastlane spaceship provision_app
And my Fastfile has:
 desc "Create certificate and provisioning profiles"
 lane :provision_app do
   cert(output_path: './downloads/certificates')
  # ... (produce, sign)
 end

Does this make sense? It seems to login to the developer portal and get no further.

@barnaclebarnes Sorry about the confusion, but running bundle exec fastlane provision_app should be enough. You don't need the spaceship in there.

@milch OK - This is an easy (maybe...) fix then. The warning you get when you run bundle exec spaceship provision_app is:
[WARNING] You are calling spaceship directly. Usage of the tool name without the `fastlane` prefix is deprecated in fastlane 2.0
Please update your scripts to use `fastlane spaceship provision_app` instead.
``

So that warning needs to change.

@barnaclebarnes No, the warning is correct, you can't run spaceship directly anymore. So to fix your issue, Instead of running bundle exec spaceship provision_app you need to run bundle exec fastlane provision_app. Hope this helps!

@milch But the warning you get says to "Please update your scripts to use fastlane spaceship provision_app instead:" It incorrectly states that you have to include the spaceship command when you don't.

So yes - I now have it working but others will probably run into the same issue if they follow the warning instructions?

But the warning you get says to "Please update your scripts to use fastlane spaceship provision_app instead:" It incorrectly states that you have to include the spaceship command when you don't.

In the case of the command you ran originally (spaceship provision_app), the message is correct, albeit maybe a bit confusing since running spaceship with any parameters doesn't do anything. We can't really do much about that though, since at the stage where we output the warning we don't know anything about the context of the parameters of the tools and including that knowledge would require too much coupling.

Ok - Closing then. Cheers for helping me sort out the correct command line to use. 👍


[rt.openssl.org #3971] install_sw target broken with no-engine

Migrated from rt.openssl.org#3971 (status was 'new')
Requestors:

<EMAIL_ADDRESS>
From<EMAIL_ADDRESS>on 2015-07-30 20:41:01:
Hi there!

The install_sw target of current master branch [1] is broken if no-engine
is provided.
Same works with 1.0.2d!

Steps:
$ ./Configure --prefix=/tmp/test no-engine shared linux-x86_64
[...]

$ make depend
[...]

$ make
[...]

$ make install_sw
making install in engines...
make[1]: Entering directory '/XXX/openssl/engines'
installing 4758cca
cp: cannot stat 'lib4758cca.so': No such file or directory
Makefile:96: recipe for target 'install' failed
make[1]: *** [install] Error 1
make[1]: Leaving directory '/XXX/openssl/engines'
Makefile:524: recipe for target 'install_sw' failed
make: *** [install_sw] Error 1

Best regards
  AndrÃ© Klitzing

[1] 3df16cc2e27f75eac2c0991248b0c294e2c847b5

Doesn't seem to be the case anymore.


Option in storage does not default to None

When using an Option in storage, it is presumed that the Option should be None until it is assigned. Currently, the default is Some of whatever type default is wrapped in the Option.
In the following example, calling return_u64 in the SDK results in Some(0):
storage {
    u64_test: Option<u64>,
}

impl MyContract for Contract {
    #[storage(read)]
    fn return_u64() -> Option<u64> {
        storage.u64_test
    }
}

In the following example, calling return_identity in the SDK results in Some((Address(0000000000000000000000000000000000000000000000000000000000000000)):
storage {
    identity_test: Option<Identity>,
}

impl MyContract for Contract {
    #[storage(read)]
    fn return_identity() -> Option<Identity> {
        storage.identity_test
    }
}

Storage is initialized to zero, and the Some variant is the zeroth one, so that behavior isn't unexpected.
https://github.com/FuelLabs/sway/blob/dec4bd84a96ae2d6dffc59583b3dd5435a814623/sway-lib-std/src/option.sw#L15-L18
I believe @mohammadfawaz and @sezna had mentioned there was some logic in the compiler to handle non-zero initializers when introducing storage.

The default of Some can be problematic, especially in cases where the owner of a contract is set to None. Somewhat defeats the purpose of using an Option for ownership instead of the zero address besides when explicitly setting it.

Yep, that's actually exactly why storage initializers exist: not every type should have all-zeroes be its "default" value!
You should be able to manually set the initial storage value to Option::None for each such slot as an immediate workaround in the absence of anything more sophisticated.

Should the order be switched so that None is first?

One can argue that using storage variables without initializing them first (via direct initializers or via regular reassignment) is undefined behaviour even for storage variables, for this exact reason above: zero initialization is not always the same as default initialization. That's all we have for now because we don't have default initializers. We may want to introduce those in the future though.

How about we close this issue an open a new one to forbid not having an explicit initializer for all storage fields?


Can the authorizer be made optional, incase I am trying to set this gateway for a public website

I would still need the edge optimisation, throttling, logging but not the authorisation.
It needs to be public

Agree, removing the annotarion of client arn doesnt make the APIG methods public.
Any chance of implementing this>

I've forked and eliminated Auth by default: you can compile it at: https://github.com/branst/amazon-apigateway-ingress-controller

+1 for this.  Use case is to handle Cognito-based authentication at the load balancer.


[IE8] Position of tooltip is off if the content change after qtip initialization.

If I initialize qtip with a dynamic content.
(function() {
var ele = $("");
qtip({content: function { return ele;}});
ele.append("a").append("b").append("c");
})();
Then I change the content inside element.  The position is off when the tooltip is shown.  This issue only happens on IE8.

qTip can't detect when you're changing the content unless you use the .set() syntax provided by the library. Either use that or call reposition() when you're done updating it:
elementWithQtip.qtip('reposition');


Bugfix/version contol

This commit make it easier to review: https://github.com/lihaoyi/mill/pull/192/commits/09e04c4e604441efc4f3d253c433683f47d4b16e

@lihaoyi thanks, just wanted to merge


[Docs] Spelling Mistake in configureStore Method

What docs page needs to be fixed?

Section: Redux Toolkit Example
Page: Getting Started

What is the problem?
counterSlice object doesn't have a property called "reducer"
What should be changed to fix the problem?
Change the spelling from "reducer" to "reducers"

Appreciate the issue, but the counterSlice does have a property called reducer, because that's what createSlice generates:
https://redux-toolkit.js.org/api/createSlice#return-value


How do you use it?

Forgive me, but how do you use this plugin? Do I have to put something in the YAML in every file? If so, can you provide an example template?

Same

To use this plugin, you need to :

enable it
Verify the settings are up to your liking
Save a file, and the updated & created time should appear !

Is it compatible with mobile?


Document SilkTouch

Should add some SilkTouch docs, about the .editorconfig options, the Diagnostics it outputs etc.

https://discord.com/channels/521092042781229087/587346162802229298/937014360683974676

This is now mandated as part of the development plan added in #539, so this will be done as the project develops. This is no longer relevant right now.


Cleanup app.json and old ENV variables

And enable one-click deploys for curious people again!

selfie


Eslint terminated with an error: [object Object]

.eslintrc.json:
{
  "parser": "babel-eslint",
  "extends": "airbnb",
  "env": {
    "browser": true
  }
}

package.json:
{
  ...
  "devDependencies": {
      ...,
      "babel-eslint": "^7.1.1",
      "eslint": "^3.10.2",
      "eslint-config-airbnb": "^13.0.0",
      "eslint-plugin-import": "^2.2.0",
      "eslint-plugin-jsx-a11y": "^3.0.1",
      "eslint-plugin-react": "^6.7.1",
      ....
    },
    ...
}

Might be relevant:
$ npm list --depth=0
...
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>...

npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>
Brackets throws:
ESLint terminated with an error: [object Object]
Running eslint . --ext .js,.jsx works fine.

Can you give result of npm ls -g --depth=0 on the machine?

No problem:
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>

You have eslint-plugin-jsx-a11y installed globally, but not in the project. That's why eslint . --ext .js,.jsx passes, but extension fails. Extension actually uses what you've installed inside the project, not globally.

Although I admit the error message should be better, I'll try to replicate and fix it soon.

I do have eslint-plugin-jsx-a11y installed, it just was version 3.0.1, which didn't met<EMAIL_ADDRESS>required by eslint-config-airbnb. Anyway, I was trying to uninstall it and install it with the required version, now eslint list --depth=0 prints:
...
+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>...

Without the peer dependency error.
The error still persists.
Could it be because of the versions mismatch between local and global installs?

Try putting this to your package.json scripts:
"scripts": {
 "lint": "eslint . --ext .js,.jsx"
}

and run npm run lint, that should execute eslint from project resources, not from global

or you can do ./node_modules/.bin/eslint . --ext .js,.jsx too I think?

eslint, its configs or plugins should be really installed globally, from my experience it causes problems when switching between projects that use different versions

npm run lint worked. I tried to uninstall local eslint, configs and plugins, and brackets now throws:
ESLintError: You need to install ESLint in your project folder with npm install eslint (didn't touch global installations)

I've tried to recreate what you posted above but my error is different, can you give me a sample I can clone/download to replicate this?

Btw be sure to be using latest version (1.8 http://brackets.io/ or 1.9 https://github.com/zaggino/brackets-electron/releases)

I'm running 1.8 brackets.
I've added you as a collab to my project so you could clone it.

git clone https://github.com/papigers/Drones
cd Drones
npm install

got 3 warnings
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

open with Brackets, switch project to the directory, open a jsx file:

Change package.json:

Then in shell:
Zaggi@ZAGGI-PC MINGW64 /d/dev/Drones (master)
$ npm run test

><EMAIL_ADDRESS>test D:\dev\Drones
> eslint . --ext js,jsx

D:\dev\Drones\node_modules\eslint-config-airbnb\rules\react-a11y.js:
        Configuration for rule "jsx-a11y/anchor-has-content" is invalid:
        Value "" is the wrong type.

Referenced from: airbnb
Referenced from: D:\dev\Drones\.eslintrc.json
Error: D:\dev\Drones\node_modules\eslint-config-airbnb\rules\react-a11y.js:
        Configuration for rule "jsx-a11y/anchor-has-content" is invalid:
        Value "" is the wrong type.

Referenced from: airbnb
Referenced from: D:\dev\Drones\.eslintrc.json
    at validateRuleOptions (D:\dev\Drones\node_modules\eslint\lib\config\config-validator.js:115:15)
    at Object.keys.forEach.id (D:\dev\Drones\node_modules\eslint\lib\config\config-validator.js:162:13)
    at Array.forEach (native)
    at Object.validate (D:\dev\Drones\node_modules\eslint\lib\config\config-validator.js:161:35)
    at load (D:\dev\Drones\node_modules\eslint\lib\config\config-file.js:522:19)
    at configExtends.reduceRight.e (D:\dev\Drones\node_modules\eslint\lib\config\config-file.js:391:36)
    at Array.reduceRight (native)
    at applyExtends (D:\dev\Drones\node_modules\eslint\lib\config\config-file.js:362:28)
    at load (D:\dev\Drones\node_modules\eslint\lib\config\config-file.js:529:22)
    at configExtends.reduceRight.e (D:\dev\Drones\node_modules\eslint\lib\config\config-file.js:391:36)

To me it seems like extension is consistent with the script.

Any idea why you see the error properly and I don't?
Also, could you try:
npm uninstall --save-dev eslint-plugin-jsx-a11y
npm install --save-dev<EMAIL_ADDRESS>
And check for me if that solves the problem, please?

What node version are you using? Brackets 1.8 contains Node 6.3.1, my pc is 6.9.1. Anything else then 6.x will probably cause different results.

npm uninstall --save-dev eslint-plugin-jsx-a11y
npm install --save-dev<EMAIL_ADDRESS>
Fixed the issue. You can read more about it here: https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/116
$ npm test

><EMAIL_ADDRESS>test D:\dev\Drones
> eslint . --ext js,jsx

D:\dev\Drones\components\App.jsx
   3:1   error  'navbar' should be listed in the project's dependencies. Run 'npm i -S navbar' to add it  import/no-extraneous-dependencies
   3:20  error  Unable to resolve path to module 'navbar'                                                 import/no-unresolved
   3:20  error  Missing file extension for "navbar"                                                       import/extensions
   5:8   error  's' is defined but never used                                                             no-unused-vars
   7:16  error  Component should be written as a pure function                                            react/prefer-stateless-function
   7:49  error  Missing space before opening brace                                                        space-before-blocks
  16:2   error  Unnecessary semicolon                                                                     no-extra-semi
  16:3   error  Newline required at end of file but not found                                             eol-last
...

It also fixed the issue in brackets, be sure to have Node 6 installed on your system.

Updating node solved the problem, thanks!

Hello, I'm running Brackets 1.9 and just updated Node, still have the issue.
I can give more info, just ask!

@zaggino I am also having this issue. Running Brackets 1.13, and npm 6.4.1

@Semaho I don't maintain this project anymore.


Multicolumn sort works incorrect

Multicolumn sort reset after clicking any column for sort.

@andrew-svirin Seems to work fine here: https://jsfiddle.net/aks9800/4p5h3sfu/
could you create a jsfiddle to demonstrate this?
closing till a reproducible fiddle is created.

@andrew-svirin Seems to work fine here: https://jsfiddle.net/aks9800/4p5h3sfu/
could you create a jsfiddle to demonstrate this?
closing till a reproducible fiddle is created.

Hi, @xaksis
Thank you for quick answer.
When i setup default value for multicolumn sort, then on table there are multiple blue arrows visible.
But when i clicking any of sortable column, then reaction like there were not any predefined sort values.

Hi, @xaksis
Thank you for quick answer.
When i setup default value for multicolumn sort, then on table there are multiple blue arrows visible.
But when i clicking any of sortable column, then reaction like there were not any predefined sort values.


HomePage module

Look into making an HomePage module that would provide the Part to define it on content items, and also register the route on Startup instead of defining it in the router middleware.

Integrated in the AutoroutePart : https://github.com/OrchardCMS/Orchard2/pull/339


Several components don't display correctly (or at all) in the Pencil Firefox extension

Seems that svg elements with filters on them do not render in the Firefox extension version of Pencil.

The extensions does not work on the latest version of Firefox. I am not sure when it will be updated. So its better to stick with the actual application rather using the extension.

Solution found: in the View menu, make sure Hide Heavy Elements is unchecked.


Add health_check django command (#217)

In this PR we try to resolve this issue https://github.com/KristianOellegaard/django-health-check/issues/217 which looks interesting in some environments.

It's always a pleasure to contribute on a neat project ;) One more reason why I should use it. LGTM ?

Released in 3.12.0 🎉


Node update from advertisement test

This PR introduces:

implementation of a fake crdClient for testing purpose
virtual node update from advertisement test

Hi @mLavacca! This PR is really nice! Thanks for this! I think that you could explain a bit better the refactoring you did in the advertisement client and in particular the new interface for the client.

/rebase

/rebase


Add monitor clause for Cobalt in Monitor plugin

Added monitor clause for Cobalt in Monitor Plugin
https://jira.rdkcentral.com/jira/browse/METROL-61
To test this you need the following buildroot branch
https://github.com/WebPlatformForEmbedded/buildroot/tree/development/METROL-61

https://jenkins.code.rdkcentral.com/job/github-triggered/1346/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1348/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1437/ started


IndedxedDB Creates Database Storage

IndedxedDB Creates Database Storage
User Story
AS A developer
I WANT to create notes or code snippets with or without an internet connection
SO THAT I can reliably retrieve them for later use
Acceptance Criteria
GIVEN a text editor web application
WHEN I open the text editor
THEN I find that IndexedDB has immediately created a database storage

Database storage has been added to the local storage in the browser using a jate indexDB.


How to change ActionBar color?

Hi,
Is there any way that I can change the action bar color of FilePickerActivity? Right now it's purple, but I want to change to black action bar, thank you!

@incomingflyingbrick did you find solution ?
I also want to change that color to black.

Yeah! how to customize it according to my app's colors


fix: computeRowlenByContent function, skip hidden columns

The computeRowlenByContent function performs calculation for hidden columns too and it's affect on view

Thanks


Update splitting-a-subfolder-out-into-a-new-repository.md

git remote set-url  reports no remotes set up for current working folder. Exchanging git remote add add resolves and allows commit to the new split out repo.

Why:
The published instructions were incomplete and not usable.
Closes [issue link]

What's being changed:

Check off the following:

[X] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[X] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@MMitsialis
Thanks so much for opening a PR! I'll get this triaged for review :zap:

git remote set-url

Hi @MMitsialis 👋🏻 thank you for opening this pull request ✨ We won't be making the change at this time, but if you continue having difficulty, please reach out to GitHub Support. We really appreciate you contributing to the community. 🎇


Add lmdb to CI scripts

Description
Add lmdb in both Nix and Windows.

Current dependencies on/for this PR:

master

PR #4352

PR #4341

PR #4342

PR #4343

PR #4316
PR #4344

PR #4366

PR #4363

PR #4391

PR #4417

PR #4424

PR #4449   👈

This comment was auto-generated by Graphite.


HMR middleware does not recognize file changes if the path includes brackets

Title
HMR middleware does not recognize file changes if the path includes brackets
Functional impact
Changes to files do not trigger a webpack recompile and consequently no changes are propagated to browser.
Minimal repro steps
Create a directory with brackets e.g. ("c:\temp\test\With (Brackets)") and run "yo aspnetcore-spa" with React/Redux and CSPROJ setting. Load project in Visual Studio, run it, change Home.tsx and the change will not propagate to the browser. This is despite the browser showing [HMR] connected.
Change the directory name to "NoBrackets" and the identical project will work flawlessly.
Expected result
Changes should be propagated to the browser regardless of brackest.
Actual result
The browser is not refreshing the view and showing the old version.
Further technical details
Unfortunately if you link a business Dropbox to your personal Dropbox it changes the personal Dropbox path to "Dropbox (Private)" which is where this issue popped up for me.

Thanks very much for reporting this, and for the clear repro steps!
I was able to reproduce the issue. However, it's not specific to ASP.NET Core. I was also able to repro the same issue using this standalone react boilerplate (when it's cloned into a dir without brackets, it works, when the dirname has brackets it doesn't).
So, if you want to get this fixed, you might need to work out whether the issue is inside Webpack or something React-specific (e.g., react-transform-hmr), and then report it to the relevant project maintainers.
Hope that's OK. I know it would be easier if we were able to track down and solve all the issues in this repo, but since we're taking dependencies on so many OSS components, we don't have the capacity to track down and fix issues in all of them. Sorry for the inconvenience!

Thanks Steve, understood - I think having the issue here is already beneficial for people troubleshooting and searching. I'll try to get around finding out which specific component is at fault.

Quick update for those coming across this:
Root cause seems to be the npm module is-glob used by chokidar (event emitter for file changes). Chokidar still uses 2.0 but the brackets bug has been fixed in is-glob version >= 3.0.
This tracked by this issue: https://github.com/paulmillr/chokidar/issues/533
Until a new version of chokidar is released you can either use "npm shrinkwrap" functionality to manually direct choikdar to use 3.0 (this approach failed due to some errors in @types directory - a bug for another day).
My approach that worked was:

npm install is-glob
Manually edit package.json in node_modules/chokidar and change ^2.0.0 dependency on is-glob to ^3.0.0.
Then go ahead and delete the is-glob 2.0 directory from node_modules/chokidar/node_modules/is-glob.
(n.b. This is a classic "works-on-my-machine" patch, but should get you going again.)

See also:

https://github.com/webpack/watchpack/issues/42

That's really impressive debugging! Thanks for letting us know the outcome.
I guess the problem will go away on its own eventually :)


ARTEMIS-4924 Do not allow sending messages directly to store-and-forward queues

I think we already have a way to prevent sending with rbac if that is the problem.
But we may just need to make use of a dlq for invalid messages in this case. This cause seems like a good match for a dlq as it blocks the head.

@gtully @jbertram I've upated the PR. Now when a cluster connection is activated, a Role is added so that when security is enabled any client will be denied of sending messages to store and forward queues. When security is disabled, or user overrides the role in security settings, messages are sent to snf queue will be moved to DLQ during delivery time.

I'm running the whole test suite now. if it's good it LGTM.
@gtully let me know what you think... I will post the results for the test suite here. We should probably merge this before the release if it's all good.

I'm running the whole test suite now. if it's good it LGTM.
@gtully let me know what you think... I will post the results for the test suite here. We should probably merge this before the release if it's all good.

Thanks @clebertsuconic

@gtully PR updated. I added a bit documentation.

I think the commit message needs to be  updated to better reflect what it is now doing.

@gtully I've updated the commit messages as well as the jira title. Thanks!


localsearch does not rebuild when posts change

Currently, it tries to depend on some sitemap internals, but it fails. (Site has enabled sitemaps and works fine.) It could easily depend on timeline_changes instead.

This doesn’t actually occur in the latest version of the plugin.


ADR: Namespace strategy

We need to describe our namespace strategy in a separate ADR.

This was investigation on behalf of a larger epic, which was not planned for the next several months, closing this.


Update buildx reference docs

relates to https://github.com/docker/buildx/pull/91 and https://github.com/docker/buildx/pull/506
This brings in more detailed command-line reference for the buildx subcommands; some enhancements were made to the template to add support for linking flag descriptions to a section on the page (or possibly an URL).
For example; the flag names in the "options" table on this page is now clickable; https://deploy-preview-12092--docsdocker.netlify.app/engine/reference/commandline/buildx_bake/#options

Which allows users to click to scroll to the relevant section on the page, for example, the section describing the --progress flag; https://deploy-preview-12092--docsdocker.netlify.app/engine/reference/commandline/buildx_bake/#progress

@usha-mandya @tonistiigi @dieucao @chris-crone ptal

Pushed one more commit to update the "working with buildx" page

also added the missing pages for docker buildx install and docker buildx uninstall (these commands are hidden, but were referenced in the "work with buildx" introduction

@thaJeztah Thanks for the PR. Looks good overall. Left some minor suggestions.

@usha-mandya I addressed your comments; I have a PR pending upstream with those changes (https://github.com/docker/buildx/pull/583) but already regenerated the yaml files with those applied and updated this PR (so should be ready for review/merge)

Thanks!


Convert zperf to use socket services API

I converted the zperf library to use socket services API in order to save memory. After the conversion, in my test setup (qemu_x86) 2836 bytes (ram) were saved.
For the zperf library and sample, the savings look like this:
main zperf rom_report 13602 ram_report 10120
pr   zperf rom_report 14081 ram_report  6184
                      =====            =====
                       -479             3936

So slight increasing for ROM usage, but quite substantial savings for RAM. The socket service implementation needs also memory so the total savings are a bit smaller.

Added a way to tweak the socket service dispatcher thread priority, this way it is possible to get best performance out of the stack.

Fixed the CI warning


Workflows waiting for synchronization lock cannot be filtered as "pending" in ui and CLI

Summary
What happened/what you expected to happen?
After implementing synchronization in the workflow level, I cannot filter for "pending" workflows in the UI and in the CLI
Diagnostics
What Kubernetes provider are you using?
GKE
What version of Argo Workflows are you running?
3.0.7
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
kubelet
Did this work in a previous version? I.e. is it a regression?
Dont know
Are you pasting thousands of log lines? That's too much information.
 ~ ▓▒░ argo3 list  --running                                                                                ░▒▓ ✔ | 4s |  
NAME                                           STATUS    AGE   DURATION   PRIORITY
XX  Pending   29m   0s         0
XX  Pending   29m   0s         0
XX   Pending   29m   0s         0

 ~ ▓▒░ argo3 list  --status pending                                                                                ░▒▓ ✔ |
No workflows found

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

can you provide what is the current state of the workflows argo list and workflow controller logs?

When time passes pending workflows starts and/Users/arnon/Downloads/argo-logs.txt complete... the current state of argo list workflow depends on the the workflows...
argo-logs.txt
argo list
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Pending     10m    0s         0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0
WF-XXX-TTT        Running     10m    10m        0

@sarabala1979
I have similar issue. I have set synchronization to 1 but the workflows (of a cron) are not running and are in pending state.
Here is workflow controller logs

time="2021-07-13T14:10:01Z" level=info msg="Enforcing history limit for 'v-dim-prod-item'" namespace=argo workflow=v-dim-prod-item
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-sf7dv message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-wm4qm message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-v7xgp message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60071827 workflow=wf-joe-v-cost-sf7dv
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60063871 workflow=wf-joe-v-cost-wm4qm
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-sjr7p message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60067801 workflow=wf-joe-v-cost-v7xgp
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-n2bx4 message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60050830 workflow=wf-joe-v-cost-sjr7p
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-gzj9d message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60055364 workflow=wf-joe-v-cost-gzj9d
time="2021-07-13T14:10:02Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-flx47 message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:02Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60076131 workflow=wf-joe-v-cost-n2bx4
time="2021-07-13T14:10:03Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60081407 workflow=wf-joe-v-cost-flx47
time="2021-07-13T14:10:03Z" level=warning msg="Workflow processing has been postponed due to concurrency limit" key=argo/wf-joe-v-cost-fvttm message="Waiting for argo/ConfigMap/wf-joe-v-cost-config-map/workflow lock. Lock status: 1/1 "
time="2021-07-13T14:10:03Z" level=info msg="Workflow update successful" namespace=argo phase= resourceVersion=60085507 workflow=wf-joe-v-cost-fvttm
time="2021-07-13T14:10:03Z" level=warning msg="Workflow 'v-stg-db2-ad-excp-price-jkfkj' from CronWorkflow 'v-stg-db2-ad-excp-price' completed"

@sarabala1979 Am able to replicate the issue. Willing to pick this up. Let me know.

Possible that the two issues above are separate, will look into both.

Sure, please go ahead to submit PR
Sent from my iPhone

On Sep 11, 2021, at 8:57 AM, Kriti Kathuria @.***> wrote:

Possible that the two issues above are separate, will look into both.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

@arnonki can you please try these command - argo list  --status Pending or argo list  --status Pending,Running


Add pxd files for imaging observers

To inherit the imaging observers class defined in pyx files, I created equally name pxd files.

I also fixed the value of the default pixel parameter because it was different from what is written in docstring.

Some of the commits change the default pixels dimensions. Could you please remove the offending lines?

I changed them following the docstrings default values. Should I restore them and modify docstrings?

Re-implemented and extended to all observers. See abe708bba00585699ee3a13f885e1e1c25db6c1d.


Update apiVersion to apps/v1 for tasks/debug-application-cluster

This change is

/assign @janetkuo

Could you please review that recommendation and update these PRs to include min-kubernetes-server-version in the front-matter of the various documents?

/assign
/hold

@liubin 👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/docs/...).


Add splint rule for barrel files

These can cause performance issues for tooling. Especially in a monorepo. It's possible this eslint rule also works with biome?

It doesn't seem to have a biome rule. Test out the cost of running eslint just for this https://x.com/passle_/status/1751627382962741256?s=46&t=dSnpuDjRyCeP-XtJli_oAg

Moved to docs


Boolean variant prop no longer working

Previously for things like textStyles I could add <Comp myTextStyle /> and it would be applied. This was great for toggling on and off multiple text styles.
It doesn't appear that this works after upgrading to v3 with variants. I have to do <Comp textStyle="myTextStyle" /> but this doesn't appear to be documented in the changelog.

Ah I see it on the release page. However not in the actual change log. This was a feature I enjoyed :(
Ensure boolean props are not used for variant styles, including:
buttonStyle
textStyle
colors


Fix broken VTx detection

I completely broke it yesterday...
Signed-off-by: David Gageot<EMAIL_ADDRESS>

LGTM


[23.1.0] Unable to find truffle-api/polyglott in embedded assembly

Hi,
We are building a full assembly with GraalJS embedded in it. I created a simple project that easily reproduce the problem.
To summarize:

when executed through maven with mvn -q exec:java, it works (meaning the dependencies are correctly declared).
when executed through the command line on the full assemply with java -jar  target/polyglott-full-embedded.jar, it crashes.

When launched with -Dpolyglotimpl.TraceClassPathIsolation=true, the output is:
[class-path-isolation] Start polyglot class-path isolation
[class-path-isolation] Collected 1 class-path entries from java.class.path system property
[class-path-isolation] Class-path entry: target/polyglott-full-embedded.jar
[class-path-isolation] No truffle-api and/or polyglot found on classpath.
Exception in thread "main" java.lang.IllegalStateException: No language and polyglot implementation was found on the class-path. Make sure at last one language is added on the class-path. If you put a language on the class-path and you encounter this error then there could be a problem with isolated class loading. Use -Dpolyglotimpl.TraceClassPathIsolation=true to debug class loader islation problems. For best performance it is recommended to use polyglot from the module-path instead of the class-path.
        at org.graalvm.polyglot.Engine$PolyglotInvalid.noPolyglotImplementationFound(Engine.java:2071)
        at org.graalvm.polyglot.Engine$PolyglotInvalid.createHostAccess(Engine.java:2057)
        at org.graalvm.polyglot.Engine$PolyglotInvalid.createHostAccess(Engine.java:2023)
        at org.graalvm.polyglot.Engine$Builder.build(Engine.java:753)
        at ch.astorm.Main.main(Main.java:9)

One can see that truffle-api and/or polyglot is not found in the jar, but the classes are present in the assembly, hence there seems to be no reason to not to be found.
As a side note, this was perfectly working in 23.0.1 (by using the old maven artifacts).
Thanks & best regards.

This issue has nothing to do with graal-js. It is a failure of the initialization of Polyglot SDK.

One can see that truffle-api and/or polyglot is not found in the jar, but the classes are present in the assembly, hence there seems to be no reason to not to be found.

The failure is not about the classes themselves. It is about some module-related meta-data that your approach does not satisfy.
I will let @chumer to comment on whether this something that we support still and how.

It seems I found a way to circumvent this problem in assembly:
java -Dpolyglotimpl.DisableClassPathIsolation=true -jar target/polyglott-full-embedded.jar

This is an issue for me too.
When running my app with -Dpolyglotimpl.DisableClassPathIsolation=true I got this error message:
Exception in thread "main" java.lang.NoSuchMethodError: 'org.graalvm.polyglot.Value org.graalvm.polyglot.impl.AbstractPolyglotImpl$APIAccess.newValue(org.graalvm.polyglot.impl.AbstractPolyglotImpl$AbstractValueDispatch, java.lang.Object, java.lang.Object)'
        at com.oracle.truffle.polyglot.PolyglotImpl.initialize(PolyglotImpl.java:164)
        at org.graalvm.polyglot.Engine.loadAndValidateProviders(Engine.java:1654)
        at org.graalvm.polyglot.Engine$1.run(Engine.java:1668)
        at org.graalvm.polyglot.Engine$1.run(Engine.java:1663)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:319)
        at org.graalvm.polyglot.Engine.initEngineImpl(Engine.java:1663)
        at org.graalvm.polyglot.Engine$ImplHolder.<clinit>(Engine.java:186)
        at org.graalvm.polyglot.Engine.getImpl(Engine.java:438)
        at org.graalvm.polyglot.Engine$Builder.build(Engine.java:736)

The only workaround I've found is using graal-sdk version 23.0.1.

I fear the Maven assembly plugin merges all dependencies into a single uber jar by default.  Uber jars won't work with optimizations enabled since the optimizing runtime needs to run as a named module. The module information gets lost when creating the uber jar. The reason we need to run as a named module is that we need to access VM internals to perform optimizations and that is only possible when running as a named module. If you cannot use something else than an uber jar I fear the only option is to use -Dpolyglotimpl.DisableClassPathIsolation=true and run without optimizations enabled.
If you are using zip assemblies with a regular class path everything should work fine.
We generally recommend running using the module path for best performance if possible.


Output cropped words

I have a project similar to recaptcha where I need humans to type words instead of computer ocr. Is there a way for tesseract to split an image into words and output the words as separate image files?

Please use tesseract forum for asking support: https://github.com/tesseract-ocr/tesseract/wiki/FAQ#rules-and-advice


Feature Request: Set non-zero exit code on error

Most if not all CI environments use the exit code to determine failure status. Currently even in a failing scenario ansible-role-tester returns 0. For the full, run, and test commands it would be useful to have the exit code set on error.
Here's a partial enumeration of failures, in a proposed order of importance:

Run result
Idempotence result
Docker errors (distribution not found, docker daemon couldn't connect, etc).

What do you think, @fubarhouse?

I'm for it - but because cleaning up the environment is mandated we simply cannot roll out a thing
What we could do is introduce a new global boolean and do some primitive checking to see if its true/false - or if we make that an integer we could formulate an exit code to be used unanimously - even if the value is 0, 1, 127 or 128... That would be best, however grabbing exit codes from processes isn't straight forward.
If you want to take lead on this, you're welcome to.

Also note the following example which is a good example as reference to the value of this mechanism:

https://travis-ci.org/fubarhouse/ansible-role-tester/jobs/433849384

The diff looks huge, but all I really did was add the following block on the full and install commands:
		// Analyze report and return the proper exit code.
		PostRun: func(cmd *cobra.Command, args []string) {
			util.Exit(report)
		},

where util.Exit is:
// Exit parses the AnsibleReport and sets the appropriate exit code.
func Exit(report AnsibleReport) {
	if !report.Docker.Run {
		os.Exit(2)
	} else if !report.Ansible.Syntax {
		os.Exit(10)
	} else if !report.Ansible.Run.Result {
		os.Exit(11)
	} else if !report.Ansible.Idempotence.Result {
		os.Exit(12)
	} else {
		os.Exit(0)
	}
}

Also, random note. When invoking git commit without the -m flag, the $EDITOR pops open. This allows one to set a nice short-string for the header, and detailed explanations in the body. https://chris.beams.io/posts/git-commit/

I'm updating the travis config as well, let's see if the build works...

I'm liking what I'm seeing - but obviously it's unfinished.
I look forward to your progress!

Phew. This one took a while. I pushed up the latest changes to my branch. I'll open up a PR and add comments to the commit.
High level overview:

I wrapped command creation in function in order to share scope between cobra.Run and cobra.PostRun. This allows us to read the report and set the exit code
I added tests using the goconvey framework, with some interesting hacks using monkey patching to intercept the os.Exit calls and assert that they are correct
I set the language in travis to GO, which bumps the build from golang 1.7.4 (the default on their trusty workers) to the value we set in the travis config, which is currently 1.10. I also fixed the bug where 1.10 is parsed as 1.1 in Yaml and caused an ancient version of go to get used.

I've also taken the liberty of fixing a small handful of bugs, since as I wrote the tests I kept discovering new ones.
Let me know what you think - I hope that you like the testing framework picked so far. Coverage clocks in above 50% just from adding 3 test cases to the full command, so this should give a nice safety net.
Moving forward, I think we should keep both the end to end tests currently setup, and these unit tests. Given that the matrix has 20+ repos, running travis builds will become prohibitively long if all permutations are attempted. Perhaps a smoke test for run/full/remote commands on all distros, and then the full suite on just one distro.


Extend pde2e-runner image to Mac platform

Right now we have pde2e-runner image that is part of various workflows only running on windows. We need to extend it to a mac platform.

Fixed by https://github.com/odockal/pde2e-runner/commit/917c297d5aada477c67d7ef7b068ff3f6b9713af.
Still requires testing and verification.


Add deprecation warning to router service from host

It creates a deprecation warning to #756 starting the addition of Engine Router Service.
Also, it provides suggestions for how to register the host's router as hostRouter and/or the root router as appRouter.
Deprecations page has been linked - https://github.com/ember-engines/ember-engines.com/pull/111

While this PR covers explicit importing of the host's router with the name router, we also need to deprecate accessing the host's router service via lookup, since it is unfortunately automatically injected right now. But let's tackle that in a separate PR.
@rwjblue please review when you have a chance.

@dgeb @rwjblue do you have any idea of how to overwrite this method to deprecate the access via lookup?
https://github.com/emberjs/ember.js/blob/21bd70c773dcc4bfe4883d7943e8a68d203b5bad/packages/%40ember/-internals/container/lib/container.ts#L150-L156

we also need to deprecate accessing the host's router service via lookup

@dgeb I added it as well, feel free to review it again ; )

I ran ember try locally and everything is ok. It seems a CI issue
result:
All 10 scenarios succeeded
✨  Done in 404.39s.

@rwjblue could you please review this work?

If as this discussion indicates, the host's router is NOT being automatically injected, then there is indeed no need to add the deprecation to lookup (which just returns undefined).
I'm confused because this explicitly came up during our last team meeting in which we discussed adding the deprecation to lookup because of this injection. However, if it's not happening, and the only way for the host's router service to be accessed is by explicitly injecting it, then it would seem to me that the deprecation in buildChildEngineInstance is the only one that is needed.
@rwjblue I think it was you who raised the point about automatic injection, so please let me know if I'm  misunderstanding something.

@dgeb - The issue isn't that we auto-inject service:router from the top level parent into Engines specifically (because as you mentioned, we don't do that). The issue is that the meaning of the APIs on service:router from within an Engine today is the same as it means from the top level parent (e.g. methods are not properly scoped to the engines mount point). We have to deprecate using service:router (even though it definitely gets its own engine local instance today) because if you call routerService.urlFor(...) you have to invoke it including the mount point, but we want to make it automatically scoped to the mount point. This will be a breaking change, which is why we need this deprecation (to guide folks away from the breakage).

Hmm, I tried checking where Ember registers service:router for lookup and it seems that it is only done for @ember/application's registry, which would infer that within an Engine @service router is not available unless you manually wire it through (in other words, my comment might be wrong).
Can someone confirm?

@rwjblue Yup, you are right. The router service is not available automatically within an engine.

@rwjblue @bertdeblock thanks for confirming.
@villander can you please update this PR to remove the lookup deprecation completely? Sorry for all the confusion.

Yup @rwjblue @dgeb  the service:router is not injected automatically, but many users use router:main to get the router from the host application. It's automatically injected into every engine. Also, we've been using it on #669
Do we want to deprecate the access to router:main into engines?

Could you please merge it @dgeb? I have no privilege to do it

I think we forgot to update enabled: '0.8.13',.

@bertdeblock good call - this is corrected in https://github.com/ember-engines/ember-engines/pull/774


Fix byte buf leak when a ContentTooLargeException is raised

Motivation:
There are three bugs when the size of a request exceeds the max content length:

The ResponseHeaders that are sent to the client and recorded to RequestLog are different.
The AggregatingDecodedHttpRequest is not aborted thus ByteBufs are leaked. (When HTTP/1.1 is used)
The AggregatingDecodedHttpRequest does not get through the decorators so LoggingService doesn't log the exception.

Modifications:

Send 413 responses using HttpResponseSubscriber instead of sending them from HttpRequestDecoder by aborting the response.

413 is not a protocol error so we should send it from the HttpResponseSubscriber.
If a responseHeaders is already sent, the stream is reset. (the channel is closed if HTTP/1.1)

Call ctx.fireChannelRead() if the request wasn't handed over to HttpServerHandler.

This lets the LoggingService log the ContentTooLargeException.
AggregatingDecodedHttpRequest is converted to StreamingDecodedHttpRequest not to raise an aggregate exception.

(misc) Raise a stream error instead of a connection error if it is stream level.

Result:

Fix #3803, #5180
No more leaks when the size of a request exceeds the max content length.

not to raise an aggregate exception.
Do you mind explaining what points raised an aggregate exception?

An AggregatingDecodedHttpRequest must be closed to be subscribed:
https://github.com/line/armeria/blob/871d87297e4d051241589cb1ae95641cbc83f880/core/src/main/java/com/linecorp/armeria/internal/common/stream/AggregatingStreamMessage.java#L94
However, we can just close it without fully receiving the request body.

Also, I think it will take too long for me to thoroughly review this PR.

Oh, please let me know if there're any points that you don't understand. 😉

Thanks all for the review. 😉


Moving release process to goreleaser in 0.54.x

Moving release process to goreleaser in 0.54.x
Signed-off-by: rohitagg2020<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?

Additional Notes for your reviewer:
Review Checklist:

[ ] Follows the developer guidelines
[ ] Relevant tests are added or updated
[ ] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[ ] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

@rohitagg2020 Do we still need this PR, can we resolve the conflicts if it's still required?


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dylanbright sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

test


Option to mount the entire microSD as read-only Mass Storage Device

Please add an option to mount the entire microSD as read-only Mass Storage Device to, for example, connect to a TV and play the music and videos present on the phone.

You should be able to

You mean the /storage one? Can I suggest doing this as an easier 1 button option anyway? Thanks!!!!

@Streetwalrus: When I try to se the image file I only see the normal fie manager.
How can I set the image file to the block device for my SD card?

You need a root file explorer. In the file picker, choose to pick a file with that app and you should be able to do it.


[DNM] Test publish 1.1

Base from 5b152115466ba9e0d1b9bb0df20b68990af94f65

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.1@5b15211). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             1.1     #439   +/-   ##
======================================
  Coverage       ?   54.03%
======================================
  Files          ?      128
  Lines          ?     5996
  Branches       ?      893
======================================
  Hits           ?     3240
  Misses         ?     2459
  Partials       ?      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b15211...e68600a. Read the comment docs.

/run-all-tests

/run-all-tests


Add Nominee: Internal Dashboard

Looks good to me apart from one mandatory field missing. We require either evidenceText or evidenceURL. @318anushka kindly update and then we can have this merged. You may refer to this submission as a hint. Thanks.

Thanks for reviewing!! will make changes.


Fix dock height on first load

Fixes: https://github.com/4d49/scene-library/issues/9
This also prevents shrinking the dock below the first row of thumbnails, which is similar to how the other bottom docks work.

Thank you!


Update page classes so we can use newer version of PF-next

No UI changes, this will take effect after we merge PF update in chrome.

ping @lgalis @Hyperkid123

@karelhala duplicate https://github.com/ManageIQ/service_portal-ui/pull/81 :wink:

Ooh, did not noticed. Closing.

np


(Feature request) background color for text

1. Right now there are only text color

2. Reason behind "background color"
I am making a women beauty product forum, I hope the overall mood is more of "fun & relax".
so more color( not than just black plain text) is very important.
3. Any plan on support "background color"?
I understand I may asking too much for a free open source project.
This Github issue is more of asking you guys opinion on this:

not gonna implement this because _______ (time, money, etc)
would add this soon
etc.

Any thought?
4. I am also looking through document， see if I can implement this.
Thank you very much

I am interested in this feature as well. How does one implement it to allow the users to highlight portions of text?


feat(ci): add bundle validation

Passing validation depends on getting Porter's cnab-go use (and resulting generated bundle.json files) up to spec in https://github.com/deislabs/porter/pull/505
Closes https://github.com/deislabs/porter/issues/423

Commented out the added azure pipelines script and added a TODO per https://github.com/deislabs/porter/issues/513


Official Release Checklist

[x] Is mutable-by-default the best way to deal with things?  It is slower for small vectors (size < 1 million) but faster for large vectors, and is sort of a large conceptual overhead
[x] Waiting on vector library to push haskell/vector/commit/3c51c33e0f9f5ac4abd438503458c76b5b0d2c13 to hackage
[x] parallel optimization

why haven't i released this yet?


Update msi-deployment.md

Issue #2089 - Command has been corrected now.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@voltarone @juturu OK to merge?

I pinged the 2 PMs again - @voltarone @juturu

@Lester-Hewett Hi Lester, could you please review this Pr and merge if correct. Thanks!

@scanum  Lester has moved on. Please let @LolaJacobsen follow up with the needed PMs


Import of LanguageDetectorBuilder failed

When loading the LanguageDetectorBuilder as recommended in the readme, I received the following error:
from lingua import LanguageDetectorBuilder
...
ImportError: cannot import name 'LanguageDetectorBuilder' from 'lingua'
The following worked for me:
from lingua.builder import LanguageDetectorBuilder

Hi Gerit, thanks for reaching out to me.
I'm not able to reproduce your problem. The import from lingua import LanguageDetectorBuilder works fine for me. Which Python version are you using? In which exact context are you trying to import the library? Without more information, I cannot help you.

Hi Peter,
I am using Python 3.8.10 with lingua-language-detector==1.0.1. Not sure why it throws this error. The package setup seems to be ok...

I close this issue now. There is not enough information to help you. If you get a clue what might be wrong, feel free to re-open this issue and provide your findings. Thank you.

I ran into this issue because somehow I had the lingua package installed at the same time as the desired lingua-language-detector package and python was importing the wrong one.


Improvement - SDL2 from CS:GO

As you currently link the SDL2.framework to the dylib statically it doesn't seem to be the best approach since you already have the libsdl2-2.0.0.dylib loaded through CS:GO.
For compiling the headers you could simply install SDL2 through brew:
brew install sdl2
Afterwards you can implement the SDL calls to your code like this:
#include <SDL2/SDL.h>

// ...
DECLSPEC void SDLCALL SDL_GetWindowSize(SDL_Window* window, int* w, int* h) {
    typedef void(*currFn) (SDL_Window*, int*, int*);
    static currFn SDL_GetWindowSizeFn = reinterpret_cast<currFn>(dlsym(RTLD_DEFAULT, "SDL_GetWindowSize"));

    return SDL_GetWindowSizeFn(window, w, h);
}
// ...
DECLSPEC int SDLCALL SDL_GL_MakeCurrent(SDL_Window* window, SDL_GLContext context) {
    typedef int(*currFn) (SDL_Window*, SDL_GLContext);
    static currFn SDL_GL_MakeCurrentFn = reinterpret_cast<currFn>(dlsym(RTLD_DEFAULT, "SDL_GL_MakeCurrent"));

    return SDL_GL_MakeCurrentFn(window, context);
}
// ...

The good thing about this:

You don't need to change the imgui_impl_sdl.* to your implemented calls
You don't need a third-party library/class to get your hooks
You can share your library to others without having them installed SDL2

OK, I've updated everything.
The old version can be found here.


smarty_internal_runtime_filterhandler.php warning

Latest version gives this error visible in the image page on several plugins:
include/smarty/libs/sysplugins/smarty_internal_runtime_filterhandler.php on line 63
This is visible to the user on the image page.

I don't see it! Can you give us more details? Do you have plugins activated? Specific options on Bootstrap Darkroom?

Hi!
I had a similar issue and it was caused by the PersoFavicon plugin. I changed the following:
File: PersoFavicon/main.inc.php
Line:  57
Old: function Favicon($content, &$smarty){
New: function Favicon($content){
I found an issue on the Forum page on piwigo.org which mentions this, but I'm not 100% sure.
Can we expect that all plugins will be changed like this in the near future or does it break backwards compatibilty with older Piwigo versions?
Kind regards
Jens

I am seeing this from two plugins:
Warning: Parameter 2 to add_info_photo_preT() expected to be a reference, value given in /home/ketchemr/rrkphoto.com/include/smarty/libs/sysplugins/smarty_internal_runtime_filterhandler.php on line 63
Warning: Parameter 2 to osm_insert_map() expected to be a reference, value given in /home/ketchemr/rrkphoto.com/include/smarty/libs/sysplugins/smarty_internal_runtime_filterhandler.php on line 63
These look like the plugins "Manage Properties Photos" and "OpenStreetMap". I suspect a change in piwigo-bootstrap-darkroom has caused a backwards compatibility issue.

Hi!
Yes, there are more. Could could do the following to look for the ones affected:

Login to your Server and navigate to the root directory of your installation. In your case it should be "/home/ketchemr/rrkphoto.com".
Find the affected files using the following command:
$ find . -type f | xargs grep -l "function.*smarty"
This should give you a list with all the files. You could then remove the second argument from the function, if it is "&$smarty".

The drawback is that these files get overwritten, when you install updates for your plugins, because the changes are only made locally.
Best regards
Jens
@plegall Is this a valid workaround?

That fixed it. Thanks.


Add scheduling display

Add a feature allowing dataNodes scheduling to be displayed.
May be to transform graph view to include the schedule, with accordeon

Fork from main branch

It's done (see branch issue_29).
Not yet merged into the main branch.

Thanks Ghiles, it is validated now !


Terminal context menu not hiding after running action

VS Code Version: insiders and from sources

Steps to Reproduce:

Create terminal
Right click to show context menu
Run Copy or Clear action
:bug: Context menu still visible

Regression from https://github.com/microsoft/vscode/pull/192809
cc @Tyriar

PR fixing it https://github.com/microsoft/vscode/pull/193314


Support React 17

Steps to Reproduce:

Create a project with react 17.x as a dependency
Attempt to install devextreme 20.2

Results You Received:
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/devextreme-react
npm ERR<EMAIL_ADDRESS>from the root project

Results You Expected:
Installation without warnings
NOTE: While the error talks about the issue being devextreme-react, the actual dependency is in this repo's package.json. It appears there may be an issue as enzyme-adapter-react-16 doesn't support react 17, and, not surprizing considering the name, may have to be changed out or added once https://github.com/enzymejs/enzyme/issues/2429 is closed. I have to say, their tagging scheme makes it difficult for products like this one to support multiple versions. This is the reason semantic versioning exists!

Hi @MarkG-IEL,
We fixed this issue in v.21.1.3. Please refer to this report for more information:
Popover - onClick event handlers in template elements do not work with React v17.0.0

@LexDX Is there an ETA for the release of v21.1?

@MarkG-IEL,
We have plans to release v21.1 the next week if it all goes according to plan.

This is still an issue in v21.1.3

Encountering the same issue with 21.1.3. Is there a fix?


Help please

I can no more enter my Gateway settings.....
I only want that my PS4 works before.... Since weeks i got Disconnect @ Online Games.....
I think it's this IPS thing here

IPFS is a system for sharing files, and ipfs-companion is a browser extension for Firefox and Chrome based browsers.  I believe you are looking in the wrong location at this particular part of the project doesn't target PS4.
Have you managed to install this on your PS4?  If so, try disabling or uninstalling the extension and seeing if it fixes the problem, then we will know it it's this or something else.

(assuming this is about go-ipfs crashing cheap router, if that is not the case, please provide more details, closing for now)

@Degget1986  if your consumer router is unable to handle high numbers of connections, you can set limits in go-ipfs config: https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#connmgr (try setting limits to 100-200)
If you continue to experience network issues, submit an experience report at https://github.com/ipfs/go-ipfs/issues, thanks!


use arrow functions in doctests

This change was motivated by a doctest in #99; ramda/ramda#1398 likely gave me the idea.

:arrow_forward:


Question: Map is placed over every element?

Having an issue with map placement. Seems like it places as topmost element. Even Alert is placed below.

You can have a look here #892
Very likely due to a bad handling of the GPU in SkiaSharp ...

Here is an update about this issue: https://github.com/mono/SkiaSharp/issues/1108#issuecomment-614730682

Status: This will not be fixed in the near future. This means to WPF Forms MapView is not a viable option for most applications. There will be a fix at some point. Subscribe to the issue mentioned above to stay up to date.

If you change the type of MapControl to SKCanvasView instead of using SKGL... it works like a charm on WPF too, it also solves the blank screen problem on old iMacs.
I had only a couple of lines to change in the module. see #892
The problem is you use Conditional compilation in this module ...
I departed from Mapsui due to the WPF problems, besides that, you did a really great job ! Congratulations :-)

If you leave, where did you go?

I am investigating writing my own ... I don't need all that complexity ... but I would like to cover all platforms, same if I have to design with workarounds solutions !
My mind is not set up yet :-) But thanks you all :-)

I would think Xamarin WPF is not in high demand so do not want to invest in it. It seems an easy fix to use the SKCanvasView instead but it is not so easy. It needs a separate build. If MapView was not derived from SKGLView but had it as a member like the MapControls there could be a runtime switch. That might be a solution. Still I think there are higher priority issues so let's just wait for the fix in SkiaSharp.
@sailman342  Good luck with your project. Perhaps it is possible to use part of Mapsui. You could start with a copy of the MapView or MapControl, simplify this to your own purpose and still make use of the Mapsui nuget for core functionality.

You are right, I did a separate build and I understand the complexity of changing at runtime. The SKGLView also has problems with some old iMacs. My target users are not equiped with the latest generations of computers, therefore ...
Thank you for the proposal of using Mapsui parts but Mapsui uses tons of third parties libraries so for the time being I decided to solely stick to Xamarin Forms and SkiaSharp Forms.
The usage of SkiaSharp touch as detector of pin click is also a problem, I laready mentioned the problem of the transparent hole in the standard pin resulting in map click rather than pin click. I am using very small pins and with my big fingers I most of the time get map clicks instead of pin clicks :-)
But mapsui is a very good engineered product, it outperforms in my mind most of the "native" solutions, thanks to the community, I will keep you posted. Kindest

Regarding the touch: we decided to check for clicks by really drawn pixels. So, if you want to check the hole, give this hole a color with a low opacity.
Regarding the third party libraries: which one ist to much. Perhaps we could make Mapsui much leaner.

Perhaps the Mapsui core project should be in a separate nuget without further dependencies. This was in line what I was thinking wrt the v3 roadmap. A Mapsui.Layers could have a TileLayer (depending on BruTile), VectorLayer (depending on NTS) and more like these.
About the touch. It should be optional to increase the touch area by some margin. I think the parameter is already there, just not implemented.


2 examples added

Hello,
I added 2 examples which were very helpful for me tesing and understanding your distance sensor board.
If you want to use GitHub workflow to test compile your library, have a look at my workflow script. If you like it, I can build you a fork with this script for testing.
Best regards
Armin

Hi @ArminJo , these look pretty slick (who doesn't love a plotter for distance).
Can I get you to bump the version number in library.properties up to 1.2.6 so the Arduino IDE takes note of the differences?
Also, I'm very interested in your workflow script. If you wanted to build us a fork I'd love to give it a look!
Thanks for your hard work,
Andy

Bumping is done.
Armin

And workflow script is added and running successfully :-).

Hello @AndyEngland521
I added a few commits for documentation and for covering more examples for the platforms.
I hope it is OK for you.
It is the first real live test for my build script :-)
Thanks
Armin

Hi Andy,
is there anything I can do?
Or something missing?
Armin

Hi Armin,
Sorry, things have been quite hectic around here and I was trying to get a minute to show your script to Nate.


Allow concatenation between SegStr and Seg

TODO: Update SegStr concatenation so that Seg objects can be concatenated to them (returning a new SegStr object). Similarly, allow a SegStr to be concatenated to a Seg, also yielding a new SegStr.

https://github.com/cbelth/algophon/pull/8


tests: subsys: settings: file: system.settings.file.raw fails

Describe the bug
The system.settings.file.raw fails.
Observed for nrf52840dk_nrf52840
To Reproduce
Steps to reproduce the behavior:

have nrf52840dk_nrf52840 connected
go to your zephyr dir
call ./scripts/twister -T tests/subsys/settings/file -p nrf52840dk_nrf52840 --device-testing --device-serial /dev/ttyACM0 -v --inline-logs
See console output with error

Expected behavior
Valid console output
Impact
Not clear
Logs and console output
[2023-04-26T23:12:03.573Z] ERROR   - *** Booting Zephyr OS build zephyr-v3.3.0-3164-ga0ad7b7752e6 ***
[2023-04-26T23:12:03.573Z] Running TESTSUITE settings_config
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_commit
[2023-04-26T23:12:03.573Z] PASS - test_config_commit in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_empty_lookups
[2023-04-26T23:12:03.573Z] PASS - test_config_empty_lookups in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_getset_int
[2023-04-26T23:12:03.573Z] PASS - test_config_getset_int in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_getset_int64
[2023-04-26T23:12:03.573Z] PASS - test_config_getset_int64 in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_getset_unknown
[2023-04-26T23:12:03.573Z] PASS - test_config_getset_unknown in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] TESTSUITE settings_config succeeded
[2023-04-26T23:12:03.573Z] Running TESTSUITE settings_config_fs
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] Assumption failed at ../../../../../../../../../zephyr/zephyr/tests/subsys/settings/file/src/settings_setup_littlefs.c:33: config_setup_fs: (rc == 0 is false)
[2023-04-26T23:12:03.573Z] erasing flash area [-5]
[2023-04-26T23:12:03.573Z] I: LittleFS version 2.5, disk version 2.0
[2023-04-26T23:12:03.573Z] I: FS at mx25r6435f@0:0x0 is 16 0x1000-byte blocks with 512 cycle
[2023-04-26T23:12:03.573Z] I: sizes: rd 16 ; pr 16 ; ca 64 ; la 32
[2023-04-26T23:12:03.573Z] E: ../../../../../../../../../zephyr/modules/fs/littlefs/lfs.c:1234: Corrupted dir pair at {0x0, 0x1}
[2023-04-26T23:12:03.573Z] W: can't mount (LFS -84); formatting
[2023-04-26T23:12:03.573Z] I: /fs mounted
[2023-04-26T23:12:03.573Z] START - test_config_compress_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_compress_file in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_empty_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_empty_file in 0.000 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_multiple_in_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_multiple_in_file in 0.000 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_save_in_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_save_in_file in 0.000 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_save_one_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_save_one_file in 0.000 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] START - test_config_small_file
[2023-04-26T23:12:03.573Z] SKIP - test_config_small_file in 0.001 seconds
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] TESTSUITE settings_config_fs succeeded
[2023-04-26T23:12:03.573Z] ------ TESTSUITE SUMMARY START ------
[2023-04-26T23:12:03.573Z] SUITE PASS - 100.00% [settings_config]: pass = 5, fail = 0, skip = 0, total = 5 duration = 0.005 seconds
[2023-04-26T23:12:03.573Z] - PASS - [settings_config.test_config_commit] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] - PASS - [settings_config.test_config_empty_lookups] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] - PASS - [settings_config.test_config_getset_int] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] - PASS - [settings_config.test_config_getset_int64] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] - PASS - [settings_config.test_config_getset_unknown] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] SUITE SKIP -   0.00% [settings_config_fs]: pass = 0, fail = 0, skip = 6, total = 6 duration = 0.002 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_compress_file] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_empty_file] duration = 0.000 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_multiple_in_file] duration = 0.000 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_save_in_file] duration = 0.000 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_save_one_file] duration = 0.000 seconds
[2023-04-26T23:12:03.573Z] - SKIP - [settings_config_fs.test_config_small_file] duration = 0.001 seconds
[2023-04-26T23:12:03.573Z] ------ TESTSUITE SUMMARY END ------
[2023-04-26T23:12:03.573Z] ===================================================================
[2023-04-26T23:12:03.573Z] RunID: d1bfa857dc700f5eb8791bafafc4a26f
[2023-04-26T23:12:03.573Z] PROJECT EXECUTION FAILED
[2023-04-26T23:12:03.573Z]

Environment (please complete the following information):

OS: Ubuntu 20.04.1 LTS
Toolchain Zephyr SDK 0.15.2
Commit SHA or Version used: zephyr-v3.3.0-3164-ga0ad7b7752e6

Tests are executed on Zephyr-sdk 0.16.1, on nrf52840dk_nrf52840  and this issue still occur. Below logs from tests:
2023-06-12 10:26:25,354 - twister - ERROR - *** Booting Zephyr OS build v3.4.0-rc3-1-ga17fc4ff2b71 ***
Running TESTSUITE settings_config
===================================================================
START - test_config_commit
PASS - test_config_c
TESTSUITE settings_config succeeded
Running TESTSUITE settings_config_fs
===================================================================
Assumption failed at WEST_TOPDIR/zephyr/tests/subsys/settings/file/src/settings_setup_littlefs.c:33: config_setup_fs: (rc == 0 is false)
erasing flash area [-5]
I: LittleFS verk ersion 2.0
I: FS at mx25r6435f@0:0x0 is 16 0x1000-byte blocks with 512 cycle
I: sizes: rd 16 ; pr 16 ; ca 64 ; la 32
E: WEST_TOPDIR/modules/fs/littlefs/lfs.c:1234: Corrupted dir pair at {0x0, 0x1}
W: can't mount (LFS -84); formatting
I: /fs mounted
START - test_config_compress_file
SKIP - test_config_compress_file in 0.001 seconds
===================================================================
START - test_config_empty_file
SKIP - test_config_empty_file in 0.000 seconds
===================================================================
START - test_config_multiple_in_file
SKIP - test_config_monds
===================================================================
START - test_config_save_in_file
SKIP - test_config_save_in_file in 0.000 s============
START - test_config_save_one_file
SKIP - test_config_save_one_file in 0.000 seconds
===================================================================
START - test_config_small_file
SKIP - test_config_small_file in 0.000 seconds
===================================================================
TESTSUITE settings_config_fs succeeded
------ TESTSUITE SUMMARY START ------
SUITE PASS - 100.00% [settings_config]: pass = 5, fail = 0, skip = 0, total = 5 duration = 0.005 seconds
- PASS - [settings_config.test_config_commit] duration = 0.001 seconds
- PASS - [settings_config.test_config_empty_lookups] duration = 0.001 seconds
- PASS - [settings_config.test_config_getset_int64] duration = 0.001 seconds
- PASS - [settings_config.test_config_getset_int] duration = 0.001 seconds
- PASS - [settings_config.test_config_getset_unknown] duration = 0.001 seconds
SUITE SKIP -   0.00% [settings_config_fs]: pass = 0, fail = 0, skip = 6, total = 6 duration = 0.001 seconds
- SKIP - [settings_config_fs.test_config_compress_file] duration = 0.001 seconds
- SKIP - [settings_config_fs.test_config_empty_file] duration = 0.000 seconds
- SKIP - [settings_config_fs.test_config_multiple_ion = 0.000 seconds
- SKIP - [settings_config_fs.test_config_save_in_file] duration = 0.000 seconds
- SKIP - [settings_config_fs.test_config_save_one_file] duration = 0.000 seconds
- SKIP - [settings_config_fs.test_config_small_file] duration = 0.000 seconds
------ TESTSUITE SUMMARY END ------
===================================================================
RunID: c6237b8178fe8fd81439d03d28c47759
PROJECT EXECUTION FAILED

Problem still occurs.

@katgiadla is the issue still there with the latest tree? @de-nordic are you still not able to reproduce this?

I have taken look at the problem and it seems that this is not with littlefs, it just manifest here.
The problem is with write lock being enabled to quickly after QSPI NOR erase command is issued.

Issue still occurs. Test scenario is renamed as settings.file.raw.


Sign up

Refactor AuthWorkflow
Implement sign up workflow, without testing
Allow users to cancel sign up by pressing back
Implement some unit tests for ActualSignUpWorkflow but more needed
Move the call to authService.signOut() to the action
Implement LayoutRunner for SignUpScreen

Closes #32


feat: Modify schema for teams for integration mapping api (box/box-openapi#463)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

4 of 10 (40.0%)  changed or added relevant lines in 1 file are covered.
9 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.02%) to 41.761%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/schemas/integrationMapping.generated.ts
4
10
40.0%

Files with Coverage Reduction
New Missed Lines
%

src/schemas/metadataQueryResults.generated.ts
1
54.17%

src/schemas/fileFullOrFolderFull.generated.ts
3
32.0%

src/schemas/event.generated.ts
5
42.38%

Totals

Change from base Build<PHONE_NUMBER>4:
0.02%

Covered Lines:
13342

Relevant Lines:
24876

💛  - Coveralls


When completed login: alert You should query "txHash" or "txid";

When completed login: alert You should query "txHash" or "txid";

When completed login: alert You should query "txHash" or "txid";

Not related to Lens contracts, closing this issue.


GL.GetShaderInfoLog calls return a string filled with whitespace instead of the expected log.

Summary
GL.*InfoLog calls return a string filled with whitespace instead of the expected log.
Steps to reproduce

Platform: Desktop
Framework Version: .NET Standard 2.0 / .NET Framework 472

Create a GLSL program with syntax errors
Compile it and retrieve it's compilation log using GetShaderInfoLog
GetShaderInfoLog returns string full of whitespace with no characters.

Comments
It might have to do with how the string is marshalled.

Confirmed fix in #58


escapeChar is mutually exclusive with quoteChar

Current Behaviour
I saved a TSV and made a data package. The CSV dialect produced was:
"dialect": {
                "delimiter": "\t",
                "quoteChar": "\"",                  # can't have this
                "header": true,
                "doubleQuote": true,
                "lineTerminator": "\r\n",
                "escapeChar": "\\",                 # and this
                "skipInitialSpace": true,
                "caseSensitiveHeader": false
            }

Expected Behaviour
The specs say escapeChar is mutually exclusive with quoteChar, so we shouldn't write both. We should drop escapeChar.
Your Environment

Data Curator version: 0.10.0 dev
Operating System and version: e.g. macOS High Sierra 10.13.3

We don't explicitly create those fields, so it may be an issue from tableschema.js

I thought we set the values based on what happens in our app. Are these values inferred?

Hi @Stephen-Gates
At the moment, based on previous tickets we just add quoteCharacter and delimiter.
I've gone through our code where we add quote character and removed and I can still see both quoteCharacter and escapeCharacter coming through when we call Resource.commit(). So yes, I believe that this is a ticket for datapackage-js

Thanks @mattRedBox  can you add to https://github.com/frictionlessdata/datapackage-js/issues ?

Hi @Stephen-Gates
@roll is aware:
https://github.com/frictionlessdata/datapackage-js/issues/102

Perhaps we could consider a PR to datapackage.js - change seems minor?

consider effort here in determining whether to include.

Hi @Stephen-Gates
In going through the datapackage-js unit tests, I need to check with you about business logic we expect here.
According to the spec, and within the code we can easily ensure (as in their python code)
quoteChar (" is default) is set
and no escapeChar set (this is the default).
And this also works if the user wants to set the quoteChar.
However what happens if the user wants to set the escapeChar? Atm, from what I can see the code doesn't support this (as quoteChar trumps so escapeChar won't appear)
ie: should the user be able to specify an escapeChar? And if so, should this then remove the quoteChar?

@mattRedBox I see two parts:

When we export, only write the quoteChar
When we import, only import dialects we can handle; otherwise import error.

Does that help?

Hi @Stephen-Gates
We can handle export and import I think, the problem will be the validation, but will wait and see if any movement from datapackage-js

Hi @Stephen-Gates
Think this might be OK :) to include in release


Add AVX512VL-256 for eltwise kernels

right now
LIBXSMM_TARGET=avx512_vl256_clx ./run_test.sh | grep FAIL
breaks.
This needs to be fixed before this branch can be merged.


Update get_dashboards_from_superset to utilise new API calls

In Superset v1.5 onwards, GET /dashboard/{id} doesn't return "table_name" key anymore, and it is replaced by GET /dashboard/{id}/datasets.
This addresses #9.

@sweco I strongly recommend hiding the whitespace changes here as I wrapped most of the function into try-except.