[$250] Web - Messages - Unread marker is not displayed after the messages are received

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4632530
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Preconditions:

Navigate to https://staging.new.expensify.com/
in any browser
Log in with an account
Log in with a secondary account in another device or incognito tab.

Open a 1:1 conversation with a user you have access with.
While viewing the 2 conversations at the same time
Turn off the internet connection in the device
As the secondary user - send a message to the account you're logged in the testing device
Turn on the internet connection
See the message sent from the other account

Expected Result:
The unread marker (green line and 'New' label) is displayed in the conversation after the messages are received
Actual Result:
The unread marker (green line and 'New' label) is NOT displayed in the conversation after the messages are received
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5034a743-743b-4579-be4e-d53be27a2a04
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fbab0fd3569bf04f
Upwork Job ID:<PHONE_NUMBER>689774019
Last Price Increase: 2024-09-03
Automatic offers:

brunovjk | Reviewer | 103816429

I'll review this one soon.

Still on my testing radar

Other GHs and customer tasks have been a higher priority, I'll get to this one soon.

After reviewing these steps, I don't think it's a dupe but there is a known issue with the new message banner when online. It's being addressed here: https://github.com/Expensify/App/issues/43486. I'm going to put this GH on hold and then test it again after #43486 in Production. Setting a reminder to check next week.

Heads up, I will be offline until Monday, July 8, 2024, and will not actively watch over this GitHub during that period.
If this GitHub needs an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

Still on hold for https://github.com/Expensify/App/issues/43486

No update, on hold for https://github.com/Expensify/App/issues/43486

@bernhardoj and @shubham1206agra - I believe this one is resolved by the other GH, but let me know if you disagree. Thanks!

The PR for https://github.com/Expensify/App/issues/43486 is actually reverted and the new PR hasn't been merged yet.

Thanks, I missed that there was a revert. Ok, keeping this one on hold.

Weekly Update: On hold for https://github.com/Expensify/App/issues/43486

@bernhardoj and @shubham1206agra can I get your feedback if we should close this one or move forward with the next steps? Thanks!

Chat bug, removing from wave-collect.

SO related to this Process: https://stackoverflowteams.com/c/expensify/questions/14418/14456#14456
@lanitochka17 - can you please retest this one? I added the label too. Thanks!

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Bug is still reproducible.
https://github.com/user-attachments/assets/e9ef1309-c100-4f71-a45f-626b42158d66

Thanks, I'm marking this one as external, and we are open for proposals here.

Waiting for proposals

Bumped on Slack for proposals

I just wanted to confirm, that the "unread" marker and "New" label are actually supposed to be shown when the user receives messages while still in the chat.
The marker should only be visible when the receiving device was offline, correct? Not when the sending device was offline, but the receiving device was online...
cc @alexpensify

Also i'm curious about the provided repro videos:
In the video in the issue description, the WiFi is turned off, but only the second (right) tab goes offline. When WiFi is turned on again, the "New messages" popup at the top of the chat appears, but no "unread" marker.
In this repro video, only the internet connection of the receiving device is turned off. When the tab goes back online again, there is NO "New messages" popup.
Therefore, what is the expected behavior? Whenever the (receiving) user goes offline and comes back online, there should be both...

a "New messages" popup at the top and
a "unread" marker

... or nothing at all? When the user is online, there should be no indication of unread messages, right?
cc @alexpensify

I cannot consistently reproduce [CASE 1], i only see the "New messages" banner sometimes.
Here are some of my screen recordings with different scenarios on both DEV and STG.
DEV: VIDEO
STG: VIDEO

@brunovjk - when you get a chance, can you please review the questions? Thanks!

Sure, I'll get back here ASAP.

Apologies for the delay. I'll reach out to an internal to help confirm the expected behavior.
🎀👀🎀

@tylerkaraszewski, could you help us confirm the expected behavior in this scenario? There's some confusion regarding the "New messages" popup and "unread" markers. Please take a look at @chrispader's comments for more context. Thank you :D

Next Steps
We need an internal review of this proposal
Heads up, I will be offline until Tuesday, September 3, 2024, and will not actively watch over this GitHub during that period.
If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

Excuse me @tylerkaraszewski, did you have a chance to look at chrispader's comments? Thanks.

@roryabraham - I picked you here because I feel like you'd know the answer.
I don't actually know what we expect the behavior here to be when you've been offline but come back online while the new messages are in the focused foreground window. I feel like we should not see a notification badge on the conversation, because the conversation is already loaded, but we should see the unread marker line, as this can mean many messages are delivered at once, and that line is used to indicate where you'd been in the conversation previously.
This is fairly nuanced though so I'd love a second opinion.

I'd agree with that @tylerkaraszewski, but TBC I'm not sure that this is a "bug" per-se, but a new feature.
Currently, the Unread Indicator only appears when you open a chat after having a different one open. But I agree that it makes sense to also show it if you've been offline and come back online, even if you've had the chat open the whole time 👍🏼

Alright, i'm going to set up a PR for this later today, if that's alright?
Going for this approach:

Only show a notification badge when the user is not currently in the report
Show both "New messages" popup at the top and the unread marker line when (multiple) new messages are received

Alright, i'm going to set up a PR for this later today, if that's alright?
Going for this approach:

Only show a notification badge when the user is not currently in the report
Show both "New messages" popup at the top and the unread marker line when (multiple) new messages are received

Sounds good to me, what do you think @roryabraham?

@chrispader to clarify, are you proposing to show the new message indicator when any new messages appear in a chat you're currently viewing?
I'd think that we'd only want to show the new message indicator if you were offline and come back online to new messages you haven't received. Perhaps we should discuss in slack though

Show both "New messages" popup at the top and the unread marker line when (multiple) new messages are received

@roryabraham Sorry for the confusion. Should have added "...while offline" at the end. I think we have the same approach in mind!
I wanted the "New messages" popup and unread marker to only be displayed when the user was offline or in another report

Hey @chrispader, just checking in—do you have everything needed to keep things moving forward, or is there anything I can assist with? Let me know if you need any help! Thank you :D

sounds good @chrispader 👍🏼

@brunovjk yes sorry for the delay. i have everything i need, was busy with other tasks until now, but going to fix this soon!

Not overdue, chrispader working on it.

@chrispader - any update here? Thanks!

Sorry for the delay!

No overdue, we are waiting for an update here

Created a PR for this issue in https://github.com/Expensify/App/pull/49480, but this is still WIP. Will finish by tmrw!

Awesome, thanks @chrispader for the update!

PR is ready for review! cc @brunovjk @alexpensify

Awesome, the PR is moving along

Update: PR is still under review

@chrispader - it looks like the PR is stalling based on the tests. Is that a good summary?

@alexpensify yes correct, so in the PR i assumed, the 20% decrease in render time is caused by the extra check for "offline messages"

Thanks for the update! Is there anything we can do to move forward, like starting a discussion with this team in the Slack Open Source room?

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll review it when I return online.

Update: PR is still under review

Thank you for the update!

Update: PR on staging.

The PR is failing due to its own issue #49480 - Failing with #44007. This is strange because I tested it just now, and everything seems normal to me:
https://github.com/user-attachments/assets/2a3bc082-7585-4ea6-8e7a-acac6dd2a5f3
@chrispader Do you think we missed something?

The PR is failing due to its own issue #49480 - Failing with #44007. This is strange because I tested it just now, and everything seems normal to me:
Screen.Recording.2024-11-05.at.09.37.17.mov
@chrispader Do you think we missed something?

DId you test this change on staging? I don't think there's anything wrong with this PR

Exactly, I had only tested PR. But in staging it also looks good to me:
https://github.com/user-attachments/assets/ed00f46f-5051-4ddc-9d5c-65454e2f3710

I forgot to point out that our PR was missing QA Steps 😬 I don't know if that has anything to do with it.

Since this has been merged to production, i think the deploy blocker is obsolete? @brunovjk

I think so, but I'm not sure what happened here :/ I'll ask on Slack later.

BugZero Checklist:

[x] [Contributor] Classify the bug:

Bug classification

Source of bug:

[x] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[x] 2a. Reported on production
[ ] 2b. Reported on staging (deploy blocker)
[ ] 2c. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[ ] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[x] 3z. Other: Applause - Internal Team

[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:

[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal
Precondition:

User logged into the platform with two separate accounts on different devices or browser windows.

Test:

On device A, turn off the internet connection.
On device B, send a message to the account on device A.
On device A, turn on the internet connection.
Verify if the unread marker (green line and 'New' label) is displayed after receiving the message.

Do we agree 👍 or 👎

Payouts due: 2024-11-13

[ ] Contributor: @chrispader payment handled via vendor
[ ] Reviewer: $250 @brunovjk

Upwork job is here.

All set, I've completed the payment to @brunovjk via Upwork. I'll work on the QA test prep later this week.

Not overdue

Update: Not overdue, working on the QA test. @alexpensify, do you think I can help in any way?

No, sorry, other GHs have been a priority. I'll get to the regression test soon.

With the slower week, I'll be working on the last step soon.

Closing - all set here


Fix Time on win32

cc @straight-shoota, you wrote this original code
in src/crystal/system/win32/time.cr:116: no overload matches 'Time.utc' with types Int32, UInt16, Int32, UInt16, UInt16, UInt16
Overloads are:
 - Time.utc(year : Int32, month : Int32, day : Int32, hour : Int32 = 0, minute : Int32 = 0, second : Int32 = 0, *, nanosecond : Int32 = 0)
 - Time.utc(*, seconds : Int64, nanoseconds : Int32)

    time = ::Time.utc(year, systemtime.wMonth, day, systemtime.wHour, systemtime.wMinute, systemtime.wSecond)
                  ^~~

I think that's a regression caused by #6118.

And https://github.com/crystal-lang/crystal/pull/5819, actually


Prefilter flag for MMSeqs2 missing from stratified_k_fold

Hi, I was trying to use the stratified_k_folds function with the Python API and there is an error that appears when running it with alignment_mode = 'mmseqs2' that concerns not having specified the prefilter option (whether True or False). I checked the source code and the flag is missing form the API call to the function.
I found an easy solution by changing the api.py file in the following way:

Adding in line 81: prefilter: bool = False,
Adding in line 164: "prefilter": prefilter,

I have tested it a bit and it seems to be working fine. I may be using this function in a way in which it was not intended to be used, in which case I would appreciate it if you could indicate me how to use the alternative. Otherwise, I hope this may make it easier for you to fix the issue.
To reproduce the error, I was using this call to the API:
fold_ids = stratified_k_fold(
        sequences,
        alignment_mode='mmseqs2',
        threads=threads,
        threshold=threshold,
        partitions=n_folds,
        chunks=threads,
        denominator='shortest'
        )

Regards,

Hi,
yes, that fix looks correct. The python API is still a bit rough. I'm mainly using graphpart from the commandline myself, so I probably never tested this case.
Will fix it soon.
Thanks for raising!


Messy documents

Everything is a huge wall of text (the beacon chain specs have over 5000 words), and although there are headings, there is no table of contents, so one has to read through everything just to learn the general structure of the document.
I seriously recommend that the documents are split into smaller documents, which are then grouped according to topic. I also recommend that tables of contents are added to the documents.
I also recommend that you do not solely use python scripts to explain something you propose.
Explaining should happen in plain text; Code should only be used for definitions.
I therefore recommend that you explain your concepts precisely in plain text, and provide your python code as a reference implementation.
It is way easier to find logical errors in prose than code, as code contains additional errors that happened to occur when transforming a thought into code.
Data type definitions would be way more legible if you used tables instead of pseudocode.
Cross-references within the documents would allow faster information retrieval and easier comprehension for non-maintainer readers.
I am trying to learn what your progress regarding sharding is, but it too tiring to read through your messy specification documents.
I think there are many others who feel the same way, and I am also convinced that the current state of affairs is not according to the spirit of rigorous community participation.
It would be in the best interest of the whole project to perform a clean-up of your documents, as it would also improve the outward appearance of the project.

We have shied away from extra structure in an effort to iterate rapidly on the spec. The phase 0 document is nearing the end of rapid iteration and we will begin focusing on cleaning it up from a content and structural perspective.
I expect in a months time for it to be both much more stable and more readable


EID-981 - Change to headless-rp test to use idp journey hint

We are going to need extra eIDAS tests after this.

Yep. Will add that with the next test-rp change.


opt-out PowerShell telemetry data to Microsoft

PowerShell sends basic telemetry data to Microsoft using Application Insights!
The below URL describes the telemetry collected in PowerShell and how to opt-out:
https://learn.microsoft.com/en-gb/powershell/module/microsoft.powershell.core/about/about_telemetry?view=powershell-7.4
SOLUTION:
Create persistent environment variables
https://learn.microsoft.com/en-gb/powershell/module/microsoft.powershell.core/about/about_environment_variables?view=powershell-7.4#powershell-environment-variables
about_Telemetry
Open the System Control Panel. ( appwiz.cpl )
Select System.
Select Advanced System Settings.
Go to the Advanced tab.
Select Environment Variables....

POWERSHELL_TELEMETRY_OPTOUT  = 1
Make your changes.

@jorgnord Created a new PR which does this (here's a link to it). Thanks for suggestion 😄


[Scalabrese] Improved Ollama integration

Improved Ollama
a. Added Ollama Python client
b. Fixed function for SQL extraction
c. Improved extraction in case of Mistral with squared bracket
d. Improved extraction making it case insensitive
e. Pulled the model in case is not existing
f. Added parameters such as keep_alive, num_ctx and additional parameters to be passed to the ollama server
Added Ollama as extra dependency

@zainhoda changed the codebase pulling it only at the startup. Is not necessary to check it every time :)


[UE4.18] Packaged Game Crashes

My UE4 project uses FMOD Audio banks which work properly and play when I run my project from the Editor.
However on packaging my project for deployment and playing I get the following error

This started to happen when i included the IFMODStudioModule::Get();  above the class finder in the gamemode.cpp file (As detailed in the deployment documentation for UE4).
Before doing that the packaged project would run fine but the sounds attached to the player blueprint would not play (there is no impact on the rest of the sounds in my project).
I am honestly at my wits end by this point. Any help would be appreciated.
EDIT: Added LogFile for reference
GameFile.log

Was this using the integration from here or the download from our website?
(This one wasn't up to date)

This was from the integration downloaded from the fmod website.

I believe this is caused by a change made to the FMODStudioModule::Get() function, this should fix it:
https://github.com/fmod/ue4integration/commit/2d5564e29d02112b96994f82c5fee72f32b317d4

I don't have access to my work station right now, but I will try it out first thing tomorrow!

Hey. Also getting this issue on 4.19. (Recently upgraded from 4.15 but with a fresh FMOD plugin)
Also occurring inside the Game Mode class. same exact line in AsyncLoading.cpp. I also have the latest FMOD 4.19 plugin version from a couple of days ago.
I already had a FMODStudioModule::Get() in the constructor of my GameMode, and also the Pawn class that is being loaded by the GameMode that gets this crash. It only happens on the shipping build, no issues in the editor.
Current solution is to manually load the player class elsewhere other than the GameMode class, but this makes some functionality for getting the default pawn class on client's a little messy.

Wow, that actually worked! Thanks a lot!
Anyway, I too hope this doesn't cause problems down the line, but for now the problem is solved.

I'm actually gonna leave this issue open for now.

Look at FindOrConstructDynamicTypePackage code in UE4, maybe this is how it should be done?
Package = CreatePackage(nullptr, PackageName);
if (!GEventDrivenLoaderEnabled)
{
	Package->SetPackageFlags(PKG_CompiledIn);
}


react-native run-android fails to build in RN 0.40.0 on Windows 7

:react-native-google-signin:mergeReleaseResources
C:\Users\path\to\my\app\node_modules\react-native-google-signin\android\build\intermediates\exploded-aar\com.android.support\appcompat-v7\23.0.1\res\drawable-hdpi\abc_textfield_search_default_mtrl_alpha.9.png: Error: File path too long on Windows, keep below 240 characters : C:\Users\path\to\my\app\node_modules\react-native-google-signin\android\build\intermediates\exploded-aar\com.android.support\appcompat-v7\23.0.1\res\drawable-hdpi\abc_textfield_search_default_mtrl_alpha.9.png
:react-native-google-signin:mergeReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-google-signin:mergeReleaseResources'.
> C:\Users\path\to\my\app\node_modules\react-native-google-signin\android\build\intermediates\exploded-aar\com.android.support\appcompat-v7\23.0.1\res\drawable-hdpi\abc_textfield_search_default_mtrl_alpha.9.png: Error: File path too long on Windows, keep below 240 characters : C:\Users\path\to\my\app\node_modules\react-native-google-signin\android\build\intermediates\exploded-aar\com.android.support\appcompat-v7\23.0.1\res\drawable-hdpi\abc_textfield_search_default_mtrl_alpha.9.png

Any ideas on what I can do to resolve?  I'm going to try and moveall my files to the root of my C: drive to see if it helps...

Moving my project allowed the build to complete successfuly... don't suppose the file could be renamed to something a bit smaller though....

Yes there is a limitation of the path length on Windows.. I can't do much about it.


[HEVCe] Hard code caps report for YUV422ReconSupport

@JeremyShang , why is it a draft?

@JeremyShang , why is it a draft?

Because it's not changing the current hardcode caps report value(stay as 0), this change just to make it friendly readable, not sure this PR is needed. It's under discussion.


Support react-navigation v5 (next)

Does this even work with v4?

@KestasVenslauskas  I recently updated the example with v4 and the latest RN it looks fine, except the RN bug. https://github.com/benevbright/react-navigation-collapsible/issues/62


Add support for inserting pages

I've added a change that allows pages to be inserted through an insertPage(at, options) method.
Also, when continuing pages, it will try to insert a page after the current one.
It will throw an error if option bufferPages is not set.

Thanks. We will need some tests. Also look at the review notes


Switch ColorPicker to use tracker_ref

ColorPicker currently uses strong references for its member variables that point to its template parts. The recommended approach here is to use tracker_ref to avoid reference cycles when consumed from managed code.
Our ColorPicker page in MUXControlsTestApp was hitting leaks due to this issue, because it uses VisualTreeHelper to find named template parts and registers event handlers on them.
Closes #2168

Bringing this to your attention @chingucoding as we are currently discussing changes to this control which may be affected.

Thanks for ping @mdtauk !
@kmahone Is there a reason why you sometimes check like this:
if (auto colorNameToolTip = m_colorNameToolTip.get())
{
   if (DownlevelHelper::ToDisplayNameExists())
   {
     // ...
   }
}

and sometimes like this:
if (DownlevelHelper::ToDisplayNameExists())
{
   if (auto colorNameToolTip = m_colorNameToolTip.get())
   {
     // ...
   }
}

Thanks for ping @mdtauk !
@kmahone Is there a reason why you sometimes check like this:
if (auto colorNameToolTip = m_colorNameToolTip.get())
{
   if (DownlevelHelper::ToDisplayNameExists())
   {
     // ...
   }
}

and sometimes like this:
if (DownlevelHelper::ToDisplayNameExists())
{
   if (auto colorNameToolTip = m_colorNameToolTip.get())
   {
     // ...
   }
}

No. I could probably be more consistent.

If it doesn't make a difference, I think its okay. Thought that maybe one condition would be more likely to fail and thus potentially skip through function faster.

/azp run

using System;

no changes here

Refers to: dev/ColorPicker/TestUI/ColorPickerPage.xaml.cs:4 in f6805f6. [](commit_id = f6805f62babf95e3227d21b07c9745b216c9fe76, deletion_comment = False)

I think to minimize the cost of this change we should have every local variable which stores the contents of a tracker_ref value be of type auto&&.
Having reviewed this change its pretty clear how unfriendly this code is to retemplating, virtually every part in the template is referenced from code and lots of them do no null check first, perhaps we should open an issue for tracking sake?

e the cost of this change we should have every local variable which stores the contents of a tracker_ref value be of type auto&&.

Stephen, lets file follow up work items for issues not directly related to this change.

@ranjeshj these are issues directly introduced by this change which were not present before

I see. @kmahone can you do a quick follow up change to fix these up ?


Grep Unrecognized option | BusyBox

While running the docker wrapper, the following error was observed while enumerating a BusyBox instance.
[+] Interesting files in root ........... No
grep: unrecognized option: exclude=deepce.sh
BusyBox v1.31.1 () multi-call binary.

Usage: grep [-HhnlLoqvsriwFE] [-m N] [-A/B/C N] PATTERN/-e PATTERN.../-f FILE [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file
[+] Passwords in common files ........... No

Cheers

Similar issue:
grep: unrecognized option: exclude=deepce.sh
BusyBox v1.28.4 (2018-12-31 18:05:13 UTC) multi-call binary.

Usage: grep [-HhnlLoqvsriwFE] [-m N] [-A/B/C N] PATTERN/-e PATTERN.../-f FILE [FILE]...

Search for PATTERN in FILEs (or stdin)

	-H	Add 'filename:' prefix
	-h	Do not add 'filename:' prefix
	-n	Add 'line_no:' prefix
	-l	Show only names of files that match
	-L	Show only names of files that don't match
	-c	Show only count of matching lines
	-o	Show only the matching part of line
	-q	Quiet. Return 0 if PATTERN is found, 1 otherwise
	-v	Select non-matching lines
	-s	Suppress open and read errors
	-r	Recurse
	-i	Ignore case
	-w	Match whole words only
	-x	Match whole lines only
	-F	PATTERN is a literal (not regexp)
	-E	PATTERN is an extended regexp
	-m N	Match up to N times per file
	-A N	Print N lines of trailing context
	-B N	Print N lines of leading context
	-C N	Same as '-A N -B N'
	-e PTRN	Pattern to match
	-f FILE	Read pattern from file
grep: unrecognized option: exclude=deepce.sh


Bump Dependencies #12427024990

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/12427024990

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Make PaddingScheme/SignatureScheme object safe

This commit removes the Rng generic parameter, replacing it with dyn CryptoRngCore.
By eliminating the generic parameter from the signature, the traits become object safe.
This closes #261, which suggested these traits should be object safe. The types that impl these traits were previously a PaddingScheme enum which made it easy to select variants at runtime, but that functionality was lost when they were split apart with unifying traits.
Since these traits and the types that impl them effectively represent a "dynamic API" which allows potentially many key usages, making these traits object safe further enables that dynamism.

FWIW, I went ahead and pushed up a branch based on this one which completely eliminates DummyRng: https://github.com/RustCrypto/RSA/commit/0c038fbf47a1a4e7f0074ad58bcd567ef612a005

Hmm, there's one problem with this: you can't actually pass a trait object to e.g. RsaPrivateKey::decrypt because it accepts the S parameter by value instead of reference, so it can't be ?Sized

Seems this isn't actually possible/useful because of the need to move out of self. Closing.


Multithreading STR Tree Query

I have a large tree and I would like to run multiple threads to query the tree (no insertion or deletion) using the nearest() function but using multiple threads provides no performance boost because I assume the underlying code doesn't release the GIL like some of the other code does.
Is there any way to allow for multithreading while querying an STR tree? So processes don't have to be used.
Sorry if this isn't the right place to post this.

The underlying code already releases the GIL in query() and nearest() where possible; there are some parts of that where it reacquires the GIL to create the output numpy arrays.
How are you splitting up nearest() across threads?  nearest() is a bit of a tricky one, in that depending on the configuration of your geometries stored in the tree (how much clustering / overlap), the algorithm may have to visit several for every input geometry - so splitting up the outer loop across trees may have less benefit.  Setting max_distance in query_nearest() might help cut down on how far out the algorithm looks for nearest geometries.
I think the benefit to multithreading here is when you can partition a large outer loop across threads.  i.e., trying to find the nearest geometry to each of 10,000 query geometries.  If you have a small number of query geometries but a very large tree, this doesn't benefit from multithreading that is under Shapely's control because we can't multithread the internals of GEOS to speed up searching the tree for a given query geometry.

This is the code I have that splits up the work across threads. The STR tree is filled with many triangles and I'm trying to query with a Point to find the nearest triangle. I have a large amount of points and the tree is also relatively large around 600,000 triangles.
def find_targets_STRTree(self):
    thread_count = 4
    print("Beginning search process")
    # returns a list of roughly evenly sized dictionaries containing lists of x,y points by a name
    work_by_thread = split_dict(self.targets_by_name, thread_count)
    results = []
    with concurrent.futures.ThreadPoolExecutor(max_workers=thread_count) as executor:
        futures = []
        for i in range(thread_count):
            futures.append(executor.submit(self.str_query_thread, work_by_thread[i]))
        for future in concurrent.futures.as_completed(futures):
            print("finished")
            results.append(future.result())
    #  do more work on the results goes here

  # returns a dict filled with lists of the indices found by name
def str_query_thread(self, targets_by_name: dict):
    label_indexes = {}
    print("Searching points for targets...")
    for area_name, targets in targets_by_name.items():
        # create the initial empty array for that key
        label_indexes[area_name] = []
        for target in targets:
            target = tuple(target)
            target_found = self.str_tree.nearest(Point(target))
            if target_found:
                index = target_found
                label_indexes[area_name].append(index)
    return label_indexes

The nearest() function itself is also vectorized, so it will be more efficient if you pass an array of Points to it, instead of a single Point at a time. So if you have a large amount of Points to query, I would divide those in decent size chunks, and then call query() once with such a chunk in each thread. That should ensure more time is spent inside the part of query that releases the GIL.
I didn't look in detail and so it's only a guess, but one potential explanation for that you don't see any performance improvement is that the python overhead in str_query_thread to loop over the points, create the point, ... etc is larger than query call itself, and so the bottleneck is in Python code, and thus the threading won't help.


Rearrange for cvssv3

Addresses #3823 - The useful cvssv3 javascript pop-up is certainly underutilized as it's buried down the field. Bringing it up next to severity so one is actually tempted to give findings a vector string.
Edit:

View -- re-balancing over a 3rd row

could we switch to label CVSS v3 exactly ?

Or something like that to avoid the new row?

could we switch to label CVSS v3 exactly ?

Sure.

Well that was not when I tried to do :/ got the migrations in order but the unit tests wouldn't recognize it so I tried to merge dev into this branch and got them switched.. May need to revert if that's the best idea.

Maybe just make a new one that fixes it


Use a Map, rather than an Object, internally in the Catalog.openAction getter (PR 11644 follow-up)

This provides a work-around to avoid having to conditionally try to initialize the openAction-object in multiple places; this indirectly fixes https://github.com/mozilla/pdf.js/pull/11644#issuecomment-635396349.
Given that Object.fromEntries doesn't seem to guarantee that a null prototype is used, we thus hack around that by using Object.assign with Object.create(null).

/botio unittest

Looks good!


Update fonts to version 2.138

Fixes #52 (and possibly #44).
Fonts were last updated in February 2015.
https://github.com/Purush0th/roboto-fontface-bower/commit/9d894078a2cbc1706ffd7b0bedc842b7fa0c8d98
TTF files from:

https://fonts.google.com/specimen/Roboto
https://fonts.google.com/specimen/Roboto+Condensed
https://fonts.google.com/specimen/Roboto+Slab

Converted font files from:

https://google-webfonts-helper.herokuapp.com/fonts/roboto
https://google-webfonts-helper.herokuapp.com/fonts/roboto-condensed
https://google-webfonts-helper.herokuapp.com/fonts/roboto-slab

@choffmeister

@jdanil  Sorry for delay. Will merge this tonight and release it as new minor version

All good. Thanks mate.

@jdanil Since the SVG files have been deleted, you must also remove it from the CSS.

@choffmeister I don't think any of the SVG files were deleted.
They appear differently to the other files changed as they are binary files while the SVGs are represented as XMLs.
All the red for the SVGs is because the updated files are smaller, so there are less lines.
All the SVG files should still be there.

@jdanil True. My bad

@jdanil Released as 0.9.0

Thanks @choffmeister!


Yarn certificate has expired.

getting this when trying to install with yarn:
error An unexpected error occurred: "https://registry.yarnpkg.com/connect-timeout: certificate has expired". info If you think this is a bug, please open a bug report with the information provided in "/home/bruno/Documents/Projetos/oton_contabil/api/yarn-error.log". info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Nevermind, just a datetime issue on my pc


Remove preventDefault from submit method so form has a default behaviour

What is the current behavior?
I have a form that has property action and I would like to submit a form that will redirect to a host given in action with method set in method. But I can't seem to get it to work because somewhere on the line there is preventDefault. I tried passing empty handler to onSubmit so it would override the behaviour and let the form submit normally with redirect. It doesn't seem to work
What is the expected behavior?
If i pass and empty handler form should have a default behaviour with redirect to a host set in action property of a form
Example code
const renderField = field => (
  <input {...field.input} type="text" name={field.nameField} value={field.valueField}/>
)

let RemoteSubmitForm = (props) => {
  let formFields = ''
  const fields = props.paymentFormData.WMI_FIELDS
  if (fields) {
    formFields = Object.keys(fields).map(key => (
      <Field
        name={key}
        value={fields[key]}
        nameField={key}
        valueField={fields[key]}
        component={renderField}
        key={Math.random()}
      />
    ))
  }
  return (
    <form
      action={props.paymentFormData.formAction}
      name={props.paymentFormData.formName}
      method="POST"
      style={{display: 'none'}}
    >
      {formFields}
    </form>
  )
}

RemoteSubmitForm = reduxForm({
  form: 'paymentForm',
  onSubmit: () => {}
})(RemoteSubmitForm)

What's your environment?
Firefox 59.0b7
Latest redux-form

Hi,
had the same problem and solved it by having no onSubmit at all.
You can still use redux form props like pristine, valid, etc. to define a certain behaviour (e.g. disabling the button if the form is invalid)
export const MyForm = ({ invalid }) => (
  <form method="POST" action="/action">
    <Textfield
      name="email"
      label="Email"
      validate={[required, email]}
    />
    <Textfield
      name="password"
      label="Password"
      validate={[required]}
    />
    <Button
      label="Login"
      type="submit"
      disabled={invalid}
    />
  </form>
);

export default reduxForm({
  form: 'loginForm'
})(LoginForm);

Hope this helps,
cheers


Track donations

[ ] Track donations so people can have credit for future subscription model

I made it look sicko mode


1/login signup and user model

Please fill out this template, ignore or delete the parts that are
not relevant to your code.
Solves issue Number: #1
Description
Created user model and added in login and sign up buttons
Added middleware to check authentication and user role
Added user resource controller to handle sign up and login
Todos
The following things are missing for feature completeness:

Tests scripts for the user profile
Create user profile
Add more fields to user model based on future requirements

Deploy Notes

User Model created with first_name,last_name,role,email,password
Passport has been added and the logged in user model can always be accessed from each request using req.user
User model has a function isAdmin which checked if the user has an admin or super admin role
Middlewares have been added to implement the following:
-- loggedInOnly: Forces the user to be logged in to access the route, redirects the user to login page
-- notLoggedInOnly: Redirects the user to the home page if the user is logged in
-- adminsOnly: Redirects the user to the home page if the user is an admin or super admin
-- notAdminOnly: Redirects the user to the home page if the user is not an admin or superadmin

We added the following packages or dependencies:

"method-override": "~1.0.0",
"express-session": "~1.0.0",
"passport" : "~0.1.17",
"passport-local" : "~0.1.6",
"passport-facebook" : "~1.0.2",
"passport-twitter" : "~1.0.2",
"passport-google-oauth" : "~0.1.5",
"connect-flash" : "~0.1.1",
"bcrypt-nodejs" : "latest"

Steps to Test or Reproduce

Go to /login
Go to /signup

Impacted Areas in Application
The following features or routes might be affected

The layout has been updated with signup,login and logout links

@jideokus Amazing work, thanks so much. So far it looks good to me, gonna double check in the morning and then merge. Thanks!

Sure let me know if I should go ahead to resolve the conflicts

Hi, thanks yes, @jideokus if you can solve the conflicts we can make the review faster and approve. thanks!

Sorry just seeing this. Will resolve them now.

Conflicts resolved @dvidsilva. Good to go

@jideokus looks like there was a typo on pacakge.json, must have been uncaught on the merge coz it had no conflict. And a couple linting things, fixing that and merging. Thanks :D


Move imports in aruba component to top-level

Issue: https://github.com/home-assistant/home-assistant/issues/27284
Breaking Change:

Description:
Moved import from function to top-level as requested in #27284
Related issue (if applicable): fixes #27284
Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @thaohtp,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hey @frenck , I tried running tox in local but it takes like ages to complete. Is there any better way than just running tox?

There is a better way, just try running the tests on the integration that you're updating: https://developers.home-assistant.io/docs/en/development_testing.html#running-single-tests-using-tox

For small changes like this, it's ok to just rely on the tests running when you create the PR and adjust if necessary.


Interruption Handling Notifications not working

   private func setupNotifications() {
 let notificationCenter = NotificationCenter.default         notificationCenter.addObserver(self, selector: #selector(handleInterruption), name: AVAudioSession.interruptionNotification, object: nil)         notificationCenter.addObserver(self, selector: #selector(handleRouteChange), name: AVAudioSession.routeChangeNotification, object: nil)         notificationCenter.addObserver(self, selector: #selector(playerDidFinishPlaying), name: .AVPlayerItemDidPlayToEndTime, object: nil)
    notificationCenter.addObserver(self, selector: #selector(playerDidRecieveError(_:)), name: .AVPlayerItemNewErrorLogEntry, object: nil)

     notificationCenter.addObserver(self, selector: #selector(playerDidRecieveError(_:)), name: .AVPlayerItemFailedToPlayToEndTime , object: nil)

    notificationCenter.addObserver(self, selector: #selector(playerDidRecieveError(_:)), name: .AVPlayerItemPlaybackStalled , object: nil)`

}
I added 3 more notifications for interruption handling, but seems not to be working please help with this issue @analogcode @fethica

@Kedar-27 Can you add more context on why you'd like to add the notifications? The interruptions are handled by default, and you can use the delegate interface of the RadioPlayer to add custom behaviour.

@Kedar-27 Can you add more context on why you'd like to add the notifications? The interruptions are handled by default, and you can use the delegate interface of the RadioPlayer to add custom behavior.

Yes, we have delegates, but they all detect the error at the start of playback. I wanted more precise error handling during playback


fix: remove unnecessary warnings (#1256)

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open a GitHub issue as a bug/feature request before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Edit the title of this pull request with a semantic commit prefix (e.g. "fix: "), which is necessary for automated release workflows to decide whether to generate a new release and what type it should be.
[x] Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #1256 🦕

@jenxwa Thanks for cleaning up the demo app! Once you sign the CLA, we'll take a look.

Who is this
On Thu, Nov 9, 2023, 6:23 AM Enrique López Mañas @.***>
wrote:

@jenxwa https://github.com/jenxwa , did you have the chance to check
the comments and the CLA?
Also, you need to follow the semantic PR convention.
—
Reply to this email directly, view it on GitHub
https://github.com/googlemaps/android-maps-utils/pull/1257#issuecomment-1803732612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANTYN3IOPE2LFCLUUWE3PLLYDTDLNAVCNFSM6AAAAAA6RSKHYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBTG4ZTENRRGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[backport] [ROCm 6.2.2] Conditionally define CUDA_SUCCESS only if it's not

Backport of #8793 by @HollowMan6

/test skip


Avoid using eval when parsing ansible-config dump

No longer needed apparently ast.literal_eval() is enough for our needs.


Bug (?) with non existent country file

Hi,
I tried using the plugin without an existing country file.
The callback with the async option did not work. I figured out, that the callbackIfComplete is not called, since the files are not "completly" loaded.
It works with adding:
else
    nextFile();

after row 328 https://github.com/jquery-i18n-properties/jquery-i18n-properties/blob/master/jquery.i18n.properties.js#L328
Best regards,
Fabian

When you say 'existing country file', what files do you have?


More effectively support cloudfront caching

If we set the various cache headers and head requests correctly, we can really leverage cloudfront much more effectively.

What settings would be better?

Closing as this doesn't seem to be a clear issue to fix.


[23.7.7] dhcpc6 does not receive dhcp6 advertise from ISP over PPPOE if pf is on

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
After upgrade from 23.7.6, I noticed my WAN (PPPOE) doesn't have IPv6 address nor PD for my LAN.
From the log I can see that dhcp6c keep sending dhcp6 solicit without getting answered.
I ran packet capture and confirm that is the case:
[root@router ~]# tcpdump -nn -i pppoe0 port 546 and port 547
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on pppoe0, link-type NULL (BSD loopback), capture size 262144 bytes
03:41:47.451210 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
03:41:48.551764 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
03:41:50.638706 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
03:41:54.622538 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
03:42:02.689358 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
I checked and tried different things without success, until I tried disabling pf (pfctl -d) and restarted dhcp6c. Oddly enough this time packets are received correctly.
Packet capture output:
listening on pppoe0, link-type NULL (BSD loopback), capture size 262144 bytes
03:43:30.867525 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 solicit
03:43:30.880805 IP6 fe80::200:5eff:fe00:103.547 > fe80::daff:feed:beef.546: dhcp6 advertise
03:43:30.881094 IP6 fe80::daff:feed:beef.546 > ff02::1:2.547: dhcp6 request
03:43:30.921665 IP6 fe80::200:5eff:fe00:103.547 > fe80::daff:feed:beef.546: dhcp6 reply
dhcp6c output:
...
Oct/27/2023 03:43:30: Sending Solicit
Oct/27/2023 03:43:30: a new XID (7c989a) is generated
Oct/27/2023 03:43:30: set client ID (len 14)
Oct/27/2023 03:43:30: set identity association
Oct/27/2023 03:43:30: set elapsed time (len 2)
Oct/27/2023 03:43:30: set option request (len 4)
Oct/27/2023 03:43:30: set IA_PD prefix
Oct/27/2023 03:43:30: set IA_PD
Oct/27/2023 03:43:30: send solicit to ff02::1:2%pppoe0
Oct/27/2023 03:43:30: reset a timer on pppoe0, state=SOLICIT, timeo=0, retrans=1091
Oct/27/2023 03:43:30: receive advertise from fe80::200:5eff:fe00:103%pppoe0 on pppoe0
Oct/27/2023 03:43:30: get DHCP option client ID, len 14
Oct/27/2023 03:43:30:   DUID: 00:01:00:01:2b:bd:54:2a:7c:2b:e1:13:02:0d
Oct/27/2023 03:43:30: get DHCP option server ID, len 16
Oct/27/2023 03:43:30:   DUID: fe:80:00:00:00:00:00:00:02:00:5e:ff:fe:00:01:03
...
Oct/27/2023 03:43:30: Received REPLY for REQUEST
Oct/27/2023 03:43:30: nameserver[0] 2404:8000:11:2::4
Oct/27/2023 03:43:30: nameserver[1] 2404:8000:11:3::2
Oct/27/2023 03:43:30: make an IA: PD-0
Oct/27/2023 03:43:30: create a prefix 2404:8000:1001:193d::/64 pltime=172800, vltime=259200
Oct/27/2023 03:43:30: add an address 2404:8000:1001:193d:7e2b:e1ff:fe13:210/64 on igc3
Oct/27/2023 03:43:30: status code for PD-0: success
It looks like something is blocking my ISP receiving dhcp6 solicits when pf is on.
This is very mystifying to me, as this is a straight upgrade from 23.7.6 and not a single config change made after upgrade.
I compared the rules.debug from 23.7.6 and 23.7.7 and found no discrepancy, both have auto-generated rules for DHCP6 in place:
pass in quick on pppoe0 proto udp from {fe80::/10} port {546} to {fe80::/10} port {546} label "8cd6199018ef9eb8a56a803f76d043ba" # allow dhcpv6 client in WAN
pass in quick on pppoe0 proto udp from {any} port {547} to {any} port {546} label "223a20aafe5da09a3dd93ec49dd4a20b" # allow dhcpv6 client in WAN
pass out quick on pppoe0 proto udp from {any} port {546} to {any} port {547} set prio 0 label "edcf3e218111608c15b56710f3080b8b" # allow dhcpv6 client in WAN
I even tried passing any to any IP6 rule without success.
Any idea where to look at? I'm really at a loss here.
Thanks in advance.

@spin-lock there is definitely something going on but I'm unsure what it is. nothing really stands out in the release notes but 5cb5541 is the closest it comes to influencing this. Can you try to revert it?
# opnsense-patch 5cb5541

Cheers,
Franco

Hi Franco, thanks but I tried the patch and still no dice.
Right now as a temporary fix I'm using  a cron job to detect IPv6 on my WAN and disable pf and restart dhcp6c if necessary.
Will investigate it again later when I'm free.

Thanks, appreciate all the details I can get. Still a bit baffled about this one.

I can confirm this is exactly happening in my setup as well.

Details matter, please.

This what I see in the log
<7>cannot forward src fe80:5::785d:c2ff:feb7:f7fb, dst 2a03:2880:f045:12:face:b00c:0:2, nxt 17, rcvif ixv4, outif pppoe0 |
-- | --

That’s just android phones being silly when they can’t get an IPv6 via SLAAC

ifconfig of the WAN/LAN plus /var/etc/radvd.conf would probably help.

@fichtner Ok I tried different things over the weekend before finally gave up, destroyed the WAN and recreated from scratch with same settings. It magically started working again (without having to toggle pf).
Chalk this one up as an unknown glitch.
Thanks Franco!

@spin-lock weird :) I'm not against that but if you could can you check the configuration history diff to see if maybe the settings are slightly different now?

I would appreciate that also since I'm still stuck. Will get you the details you asked for

@spin-lock weird :) I'm not against that but if you could can you check the configuration history diff to see if maybe the settings are slightly different now?

With the new config, I noticed the internal device name for my PPPOE has changed from "wan" to "opt8".
So every tag/value of "wan" in config.xml became "opt8" in the working version.
HTH.

@fichtner I edited the config of working version and changed every occurrence of "opt8" to "wan", reload new config & reboot and dhcp6c was not working again (had to toggle pf to get dhcp6 replies from ISP).
I then edited the config again and changed back every "wan" to "opt8", reload & reboot and it was working normally again.
I'm not sure what to make out of this, hope this will give you some clue, Franco.
HTH.

With the new config, I noticed the internal device name for my PPPOE has changed from "wan" to "opt8".

Ok, that is expected when redoing the interface as the "lan" and "wan" identifiers are reserved values for the console and factory reset configuration only. Think we should close then.

I'm not sure what to make out of this, hope this will give you some clue, Franco.

Funky. Can you make a diff -u of the working version vs. the non-working version of the file /tmp/rules.debug -- I think we should see an issue here.
Cheers,
Franco

Here's the excerpts of diff I picked on pppoe:

@@ -148,8 +148,8 @@
__openvpn_network = "<__openvpn_network>"
table <__opt14_network>  persist
__opt14_network = "<__opt14_network>"
-table <__opt8_network>  persist
-__opt8_network = "<__opt8_network>"
+table <__wan_network>  persist
+__wan_network = "<__wan_network>"

@@ -279,9 +279,9 @@
pass in quick on vlan01 inet6 proto udp from {ff02::/16} to {fe80::/10} port {547} label "83602f6f157b7063427dac458c3c1f17" # allow access to DHCPv6 server on VLAN50_VPN
pass in quick on vlan01 inet6 proto udp from {fe80::/10} to {(self)} port {546} label "b884b7166e5ac8d3a40d9d2b10e79bd3" # allow access to DHCPv6 server on VLAN50_VPN
pass out quick on vlan01 inet6 proto udp from {(self)} port {547} to {fe80::/10} label "f49c2bf2475cc72c935119eedd09d3f8" # allow access to DHCPv6 server on VLAN50_VPN
-pass in quick on pppoe0 proto udp from {fe80::/10} port {546} to {fe80::/10} port {546} label "699421e0b4fd390da837b84c6a8f9c15" # allow dhcpv6 client in WAN
-pass in quick on pppoe0 proto udp from {any} port {547} to {any} port {546} label "f6242abe481fee6ca8a2643f53642f7c" # allow dhcpv6 client in WAN
-pass out quick on pppoe0 proto udp from {any} port {546} to {any} port {547} label "4b266c6fc567cdaea179399d4c18b813" # allow dhcpv6 client in WAN
+pass in quick on pppoe0 proto udp from {fe80::/10} port {546} to {fe80::/10} port {546} label "15178fb2a3769d47b7e6b0b3c94cd170" # allow dhcpv6 client in WAN
+pass in quick on pppoe0 proto udp from {any} port {547} to {any} port {546} label "c671121c53904a58a4286cbb7f8500ca" # allow dhcpv6 client in WAN
+pass out quick on pppoe0 proto udp from {any} port {546} to {any} port {547} label "00cbb180fdcff7449da6542ac6da7501" # allow dhcpv6 client in WAN
@@ -383,16 +383,16 @@
pass out route-to ( gif6 <IP_ADDRESS> ) from {(gif6)} to {!(gif6:network)} keep state allow-opts label "c07d4d62dc804d56bae5a448235ab737" # let out anything from firewall host itself (force gw)
pass out route-to ( gif2 <IP_ADDRESS> ) from {(gif2)} to {!(gif2:network)} keep state allow-opts label "44ca1a6db5753db09d0a7590009f8498" # let out anything from firewall host itself (force gw)
pass out route-to ( gif1 <IP_ADDRESS> ) from {(gif1)} to {!(gif1:network)} keep state allow-opts label "33fd75a393e4c83e79ea4694f0ddf766" # let out anything from firewall host itself (force gw)
-pass out route-to ( pppoe0 <IP_ADDRESS> ) from {(pppoe0)} to {!(pppoe0:network)} keep state allow-opts label "bd9a12eff5ea112bddf6772dee0a4da9" # let out anything from firewall host itself (force gw)
-pass out route-to ( pppoe0 fe80::200:5eff:fe00:103 ) from {(pppoe0)} to {!(pppoe0:network)} keep state allow-opts label "b2279682eacf9dfa6d1d368a1cab0c89" # let out anything from firewall host itself (force gw)
+pass out route-to ( pppoe0 <IP_ADDRESS> ) from {(pppoe0)} to {!(pppoe0:network)} keep state allow-opts label "2da77f48c21d6dfc536f1fcbc2e2498e" # let out anything from firewall host itself (force gw)
+pass out route-to ( pppoe0 fe80::200:5eff:fe00:103 ) from {(pppoe0)} to {!(pppoe0:network)} keep state allow-opts label "9a5ed6991dd79497bbb7cbc22c7c0462" # let out anything from firewall host itself (force gw)
@@ -430,11 +430,11 @@
pass in quick on wg1 inet6 from {any} to {any} keep state label "695755cbead8a77dab08363e3ad1a596"
#debug:Interface opt7 not found
pass in quick on ##opt7## inet from {any} to {any} keep state label "d14c352e9def6f109eafc9d6446ec832"
-pass in quick on pppoe0 inet from $N_WAN_IN to {any} keep state label "4fa6c97fa22be9e93c682771886ec1f8"
-pass in quick on pppoe0 inet6 from $N_WAN_IN to {any} keep state label "4fa6c97fa22be9e93c682771886ec1f8"
-pass in quick on pppoe0 inet proto udp from {any} to {any} port {43580:43581} keep state label "83d91b6320d19f0559bb73309a2bb852" # Lets Encrypt renewals
-pass in quick on pppoe0 inet6 proto udp from {any} to {any} port {43580:43581} keep state label "83d91b6320d19f0559bb73309a2bb852" # Lets Encrypt renewals
-block in quick on pppoe0 inet proto icmp from !$RFC1918_NETv4 to {any} icmp-type {echoreq} label "47fd47d86c097f8e603c172f93151e5c" # Block IPv4 PING from outside
+pass in quick on pppoe0 inet from $N_WAN_IN to {any} keep state label "c35de4ed1b8fcc29e57f31417028b196"
+pass in quick on pppoe0 inet6 from $N_WAN_IN to {any} keep state label "c35de4ed1b8fcc29e57f31417028b196"
+pass in quick on pppoe0 inet proto udp from {any} to {any} port {43580:43581} keep state label "2528b5466a24cb135578005268b181f4" # Lets Encrypt renewals
+pass in quick on pppoe0 inet6 proto udp from {any} to {any} port {43580:43581} keep state label "2528b5466a24cb135578005268b181f4" # Lets Encrypt renewals
+block in quick on pppoe0 inet proto icmp from !$RFC1918_NETv4 to {any} icmp-type {echoreq} label "b88559e3aaae182895587d72fb26d189" # Block IPv4 PING from outside
I don't see any difference other than labels.

Ok, I keep going back to "weird" as the word to describe this. I don't have another idea. Maybe states problem?

I resolved mine, think it was my switch's IGMP snooping causing issues.

 Now I'm convinced it's not a switch but opnsense issue.

Enabled promiscuous mode, then disabled and then removed VLAN priority, rebooted and IPV6 is back. Totally strange. Let me know if there's anything you need to help triage this.


Test integration of BC Person Credential utilizing BC Services App on device

@nodlesh , i think we can close this as not possible? we are moving towards an app integration where BCSC will just call BCWallet with a invitation to connect deep link. We should be able to mimic the flow without BCSC app.


Can I separate customDimensions in trackEvent log?

Is your feature request related to a problem? Please describe.
I am using this trackEvent to log my app event, but anything in properties show up in the log is a object not a separate columns, so it's easier for us to track the data.
Thank you!
appInsights.trackEvent({
  name: 'some event',
  properties: { // accepts any type
    prop1: 'string',
    prop2: 123.45,
    prop3: { nested: 'objects are okay too' }
  }
});

Here's the CSV I export form appInsight --> Transaction search ---> view log ---> Export

Describe the solution you'd like
I want each object field to be their own column
Additional context
Add any other context or screenshots about the feature request here.
Version I use:
@microsoft/applicationinsights-web: "^3.0.0",

You can use project or extend KQL operators to flatten, select, and rename the properties you want, before exporting to CSV.
https://learn.microsoft.com/en-us/azure/azure-monitor/logs/get-started-queries#use-project-and-extend-to-select-and-compute-columns


Cannot decrypt model attribute with no package header! Error

I'm able to encrypt the data, an encryption header is written, but it's not detected by the plugin.
If i use the normal getter i.e. $user->name or $user->getAttribute('name'), I get the encrypted string in return.
\u0001\u0002__LARAVEL-DATABASE-ENCRYPTED-VERSION-00-01-02__\u0003\u001eversion\u0019VERSION-00-01-02\u0017\u001etype\u0019string[native]\u0017\u0004eyJpdiI6IlJndER1VWQ4ek1PVGhSRk5MRjNwWGc9PSIsInZhbHVlIjoiMXR1
if I use $user->decryptedAttribute('name'), I get the above message.
I can see that the system is looking for the wrong start and end for the header:
array:2 [▼   "start" => array:3 [▼     "int" => 1     "string" => "\x01"     "default" => true   ]   "stop" => array:3 [▼     "int" => 4     "string" => "\x04"     "default" => true   ] ]
but overriding this values with \u0001 and \u001e didn't make a difference
My db config is standard:
 'mysql' => [             'driver'    => 'mysql',             'host'      => env('DB_HOST', 'localhost'),             'database'  => env('DB_DATABASE', 'forge'),             'username'  => env('DB_USERNAME', 'forge'),             'password'  => env('DB_PASSWORD', ''),             'charset'   => 'utf8',             'collation' => 'utf8_unicode_ci',             'prefix'    => '',             'strict'    => false,         ],

Problem found: All encrypted fields need to be changed to datatype TEXT on database level
This should be added to the documentation in FAT

All my encrypted fields have the datatype TEXT and I still get this error :-/


attribute keys are CAPS sensitive

based on specification, attribute names should be case insensitive. Now it seems they are not, e.g. "Primary", "UserName" are not valid attribute names.

to specify, this was found with postman when sending scim+json information in POST or PUT

I did a bit of a deep dive today to revisit issues of case sensitivity and arrived back at the original implementation decision, unfortunately, of "very hard". Some aspects of case insensitivity (e.g. in filters) are handled but main attribute names are presently not.
Ruby provides no out-of-box way to have things like case-insensitive Hash keys and a great many of the operations that Scimitar performs on Hash and Array data for inbound payload processing become invalidated once the case of any of these entities becomes indeterminate. A lot of this kind of stuff was leant on heavily just to make the gem implementable without unreasonably vast amounts of time/resources in a moderately reliable fashion, even within the documented limitations such as those described in #6.
SCIM is a very difficult spec to implement with a lot of undocumented edge cases and deceptive amounts of deep complexity hidden in what often look like "innocent" specification examples and statements. As with many RFCs, it is a pity that the authors were not required to produce a reference implementation as this would I'm sure have gone a long way to aiding in simplification and clarification of the RFC prior to its finalisation.
I'll keep looking at this, but it's definitely an extremely large job (in the worst case, to the point of rewriting a good chunk of some of the hardest-to-implement code in the gem) and unless I have a sudden breakthrough idea on how to get it done efficiently, I can't see it happening quickly.
I would presume from the bug report that you aren't in control of the client service that's giving you non-camel-case names such as UserName and thus receiving 400 responses, so require this to be fixed in the gem for your integration to work?

So far we are testing with postman, link to test cases from azure. We have no possibility to alter our customers SCIM clients once we go operational.
It kind of sounds like "translation table" is needed, having the key as small caps and pointing to original. Possibly clients input hash keys could always be changed to small caps, as clients should be case insensitive as well

Well I'm making some headway, so watch this space :-)

The above is going through our review process now.

@Janne-ka Version 1.1.0 has been pushed to https://rubygems.org/gems/scimitar - hopefully this fixes your case sensitivity issues, though there may be other problems; fingers crossed anyway. We haven't had a chance to test with too many real-world SCIM endpoints yet.
Please let me know how you get on 👍

initial Postman tests pass, so looking good. Code looks great too.

Thanks for the update. And of course, if there are any more problems, please don't hesitate to open a new issue.


AssetLib decsription details

Some code or plugins seem not working with Godot 3.1
Please add new description details for each AssetLib plugins or code :

Godot version it was made
Date it has been added to AssetLib
Most recent Godot version someone confirm it is working
Deprecated (when it is not working with latest Godot version)

Closing, as this kind of information should be added to the asset library platform itself: https://github.com/godotengine/godot-asset-library

Deprecated (when it is not working with latest Godot version)

This is implemented in the asset library rewrite I'm working on. An asset author (or an administrator) can mark an asset as "archived".


sleek-v1.1.0-windows(setup) signature not valid?

hi,
as a paranoid I wish the .exe files are signed.
but my machine's check and also virustotal report this:
Signature verification
A certificate chain processed, but terminated in a root certificate which is not trusted by the trust provider.
pls see if anything can be done. thanks
btw, others have wished the sort will include "todo txt body", which is also my wish and is reasonable.
suppose I list out a singer:song list, currently sleek only sort "priority, context, project, due date" and this doesn't fit.
allow sort by "todo txt body" is good (like markor), further allow sorting "key" in the key:value pair  (as singer:song)
will be good, further allow sort by the "value" in the pair will be excellent.
thanks

Hi @ccchan234 thanks for your comment. I was digging into code signing certificates but discarded the idea as it's just too expensive for a private project like sleek. Plus you then we would need another certificate for the Mac files and so forth.
For a signed Windows build I would want to advice you to download sleek from Microsofts Windows App Store.
The Windows builds here are signed with a self signed certificate which of course is not accepted by any authority and will produce that warning. Maybe it helps to just remove the self signed certificate?

hi, thx for reply.

i got internet connected win10, so as you said i could dnld from windows store instead

i got several airgap-ed win10 for security issue. it will be more smooth if you could publicly announce that the signature is invalid (e.g. in releases note), and is even better if a pgp file signature(better) and/or sha1/256 checksum of the file is provided. ofcoz this depend on the time you can provide.

thanks

Ich would really love to work on sleek at the moment, but there is absolutely zero time. And when there will be again, there is quite a prioritised backlog.
We can add this to the backlog but please don't expect any work on it soon.


How to send a request at JSON format using http module to an ExpressJS server?

Two web servers are in place: one is developed using the Express.js framework to manage requests and responses, while the other is built with the HTTP module to forward requests to the former. The current requirement is to send requests in JSON format, but there is uncertainty on how to achieve this using the HTTP module.
The first server by express js:
const { Web3 } = require("web3");
const {toChecksumAddress}=require("ethereum-checksum-address");
const express=require("express");
const bodyParser=require("body-parser");

const walletMap=new Map();

const urlencodedParser=new bodyParser.urlencoded({extended:false});
const app=express();
app.use(bodyParser.json());

...

app.get("/wallet-status",function(req,res){
  try{
    const response=walletView(req.body.address);
    res.status(200).json(response);
  }catch(err){
    const errorObj={
      error:err.name,
      message:err.message
    }
    res.status(400).json(errorObj);
  }
})

...

function walletView(address){
    address=address.toString();
    if(toChecksumAddress(address)){
      if(walletMap.get(address)===undefined){
        return {"message":"The address provided has not been recorded previously"}
      }else{
        return walletMap.get(address);
      }
    }
}

The second server by http module:
const http=require("http");

let options={
    host:"<IP_ADDRESS>",
    port:2020,
    path:"/wallet-status",
    method:"GET",
    headers:{
        "Content-Type":"application/json"
    }
}

const httpRequest=http.request(options,function(response){
    console.info(response.statusCode);
})

httpRequest.end();

What modifications are needed for the second app to send JSON requests, allowing the callback function of app.get("/wallet-status",...) to receive them?

Hey @AlirezaEthDev, we do not to technical support here. Please use stackoverflow or reddit to ask general questions like this. This is for bugs, features, and otherwise improving the express project itself. Thanks.


use ns from request url or fall back to ns from tenant service

This PR is about bring back changes from previous PR merged for damensets requirments.
PR - https://github.com/fabric8-services/fabric8-oso-proxy/pull/50

[test]


Support install/uninstall addon via rosa cli

Accept rosa attribute to indicate the ROSA cli direct usage for addon installation.

/verified


Fix main page

what exactly do you mean by 'remove this' with the arrow pointing up to the black bar?


Provide actionable advice when the exchange is non-null (3.x branch)

https://github.com/square/okhttp/issues/4761

When this lands I’ll cut 3.14.1.

Cherry-picked to 4.x here:
https://github.com/square/okhttp/pull/4922/files


misdetection alert

Temporary pending of different pods is recognized as the same event and the duration exceeds 10 minutes.

https://github.com/kuoss/venti/pull/102

https://github.com/kuoss/venti/pull/102


cfp.loadingBar.status() not working

What version of angular-loading-bar are you using?
0.9.0
What version of AngularJS are you using?
1.6.1
What browsers are affected?
All
Please describe the issue
Using angular-loading-bar on my AngularJS project and I love it.
Users told me that a more visual loading-bar (I think a big spinner in the center) would be much appreciated.
Is there any way I can add a spinner which is checks the status of the angular-loading-bar to be shown or to be hidden?
I saw the Service API but that doesn't seem to work.
When I try to use cfp.loadingBar.status(), the app just does not respond.
angular.module('myApp', [cfpLoadingBar])

What did you expect to happen?
Get a status percentage using console.log(cfp.loadingBar.status()).

@chieffancypants @faceleg @PatrickJS


Need Support for FastAPI for the SoniTranslate

I am looking for FastAPi support for this project I have gone through the codebase and cannot find it. Can anyone help me with that I would be very gratefull. Or can someone guide me step by step I want to make a FastAPi that will take a video translates using coqui TTS and then dub the video on it.
Best Regards

Did you try to use gradio api?
It's ready touse, althought I'm having problems to send videos.

Did you try to use gradio api? It's ready touse, althought I'm having problems to send videos.

I tried but it very difficult I was not able to use it for my needs.

My  goal is similar to yours. I just want automate the process, sending automatically, via python a series of videos and dubbing them it into different languages.
The I am "almost there", but having problems when sending the videos. It looks there is something missing, but I can not figure out what is.

My goal is similar to yours. I just want automate the process, sending automatically, via python a series of videos and dubbing them it into different languages. The I am "almost there", but having problems when sending the videos. It looks there is something missing, but I can not figure out what is.

I saw your comment about automating the process of sending videos and dubbing them into different languages via Python. I am currently facing similar issues with sending videos. Were you able to resolve the problem? If so, could you please share some example code or insights on how you managed to solve it? Thanks in advance!

@trofimovm  Hi,
No, I am very close, but I receive erros when using the api.
If you want, we can chat directly to help each other.
Best regards,
Ubirajara


Update to new Kindle for PC App

New Kindle to PC app saves HTML file with h2', 'h3' tags instead of using 'div', hence I replaced find_all('div') with select('[class]') resulting in getting all elements with 'class' attribute
I also set utf8 encoding for opening HTML and saving md file (Polish characters caused "CRITICAL Exception: 'charmap' codec can't decode byte X in position Y: character maps to  error".
Additionally I noticed that div.string returns None, so I replaced with proper .get_text().
I am also removing \xa0 characters which added redundant spaces.

Awesome; thanks @thomaswinged!


End date should not be less than Start date

I'm using datetimepicker for two times in one form.  First for Start time and Second for End time.
I want second date should not less than first date.
Here is my code :
$("#campaign_start_time").datetimepicker({             format: 'yyyy-mm-dd hh:ii',             autoclose: true,             //startDate: new Date.UTC(),             minuteStep: 5         });          $("#campaign_stop_time").datetimepicker({             format: 'yyyy-mm-dd hh:ii',             autoclose: true,             //startDate: new Date.UTC(),             minuteStep: 5         });

I did this with a JS function onBlur() at the starttime-picker.
Just set the minDate of the stoptime-picker to the time the starttime has when you unselect it.
Like this:
$('#datetimepicker').data("DateTimePicker").minDate("date from starttime-picker");

http://eonasdan.github.io/bootstrap-datetimepicker/#linked-pickers


Windows setup for convis

Guidelines to run convis on Windows OS using WSL2
Requirements to run WSL2 to run convis locally
Setting up of Docker Desktop and enabling Kubernetes to run the convis pods

LGTM thanks!


changed key bindings for avatar facial expressions

Script link: https://hifi-content.s3.amazonaws.com/elisalj/facial_expressions/facialExpressions.js
Works best with the Artemis avatar
Test Plan

Load the script, check that the "Emotions" button is active
Switch into mirror mode (Ctrl + H)
Test out different emotions with these hotkeys:
'H' = smile
'J' = laugh
'K' = flirt
'L = sad
'V' = angry
'B' = fear
'M' = disgust
'N' = neutral

Known Issues

Blendshapes are local changes only; other users cannot see your emotions yet (addressed in https://github.com/highfidelity/hifi/pull/12584)
If the script is unloaded while an emotion is activated, the avatar's face will get stuck in that emotion

Testing.

Testing complete:
Load the script, check that the "Emotions" button is active Check
Switch into mirror mode (Ctrl + H) Check
Test out different emotions listed Check, all work perfectly on Artemis, however some avatars not so much.
Pass :)


Add support for version ranges for sbt plugins from Maven repositories

Fixes https://github.com/coursier/coursier/issues/548, https://github.com/coursier/coursier/issues/566.

Included in https://github.com/coursier/coursier/pull/581.


Use outside of nodejs

Would it be possible to use this library client side via. url?

It would be possible.
Would it be the right thing to do? No.
This library loads X number of mnist samples in the system's Heap.
What you are looking for is a node.js server which serves an individual mnist sample to your web application through http.
Your page would load for eternity trying to load the entire dataset in the browser.
You could use express.js to serve individual mnist images from your node.js application to your browser app.
here is a snippet of how you could achieve something like this with express.js:
app.get('/mnist', (req, res) => {
    const dataset = req.query.dataset;
    const id = req.query.id;
    res.send(mnist[dataset][id]);
})

You could then fetch any image from your server by providing the right ip, port & queries
curl http://IP:PORT/mnist?dataset=train&id=34

Will try! thanks for the fast reply.


Nightly Jörmungandr tests are failing

Context
https://buildkite.com/input-output-hk/cardano-wallet/builds/9809
Test Case

The jormungandr unit test suite is timing out.
The jormungandr integration tests are failing.

Failure / Counter-example

Resolution

QA

It says jormungandr-integration failed and cardano-wallet-jormungandr:test:unit timed out.
You can find logs in the "Artifacts" tab of the build.
The last thing I see in the cardano-wallet-jormungandr test logs is the Cardano.Wallet.Jormungandr.Binary Decoding tests. But they would not be the cause.

Is it possible that the jormungandr integration tests fail because they don't have built-in retrying like the shelley integration tests?

@rvl we introduced the retrying it for the Shelley integration tests because of the frequent rollbacks we had. We never had such issues on Jörmungandr because the self-node doesn't rollback as often (or rollback at all actually...). So my two cents would be: no, it is unlikely.

Tests should be passing now.


enable some warnings that rustc bootstrap enables

also use cargo-install to install josh-proxy, since the docker version cannot access SSH keys (needed for pushing)

@bors r+

:pushpin: Commit 63a3a31847ddfc9f4a6ae1408e844a0acf283f16 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 63a3a31847ddfc9f4a6ae1408e844a0acf283f16 with merge 4f051a6df22174897cbd22775f84b7c9e3cb99b6...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 4f051a6df22174897cbd22775f84b7c9e3cb99b6 to master...


Logic app integration account map

Related command
az logic integration-account
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I'd like to see the following commands added to the cli.
az logic integration-account map {create, delete, list, show, update }
Az Powershell has this but not the cli.
Describe alternatives you've considered
Az Powershell supports it. https://learn.microsoft.com/en-us/powershell/module/az.logicapp/new-azintegrationaccountmap
Additional context
n/a

route to CXP team

Non-customer reported issue. Adding Service team to look into this.

@Azure/azure-logicapps-team Please look into this.

@rguptar, could you please provide swagger here?

@yonzhan looks like this was reprioritized, can you share an updated timeline?

We plan to release it in next sprint (7/4)


Update concept-fido2-hardware-vendor.md to remove duplicate key

Removed 61250591-b2bc-4456-b719-0b17be90bb30 as it was a duplicate. All other fields matched too.

Hi, I'm receiving error "403: User is not authorized to access this URL" for the instructions and documentation.
This is the URL that gives me the error: https://review.learn.microsoft.com/.auth/login/aad/callback

@Justinha
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@DevClate thanks for the correction and sorry for delay. to work around the merge conflict, I fixed this on my side. #please-close

No problem @Justinha Glad I could help


Add VLMEval Sample Project

This PR adds the VLMEval project as a sample under the Applications folder.
Changes Made

Added cross-platform image loading to support both macOS and iOS
Implemented CIImage conversion for model input
Added macOS and iOS image handling

Implementation Details

Created loadImageAsCIImage method to handle image loading and conversion
Similar generate method like LLMEval for inference
Added security-scoped resource access for macOS image

Testing

Tested image loading on macOS
Verified CIImage conversion
Confirmed inference with processed image
Tested file permissions and security access on macOS

Related Issues

Closes #164

Screenshots

Ready for review!


[Improve][Paimon] upgrade version and add fs config

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?
debug in local

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist
Add ci label in label-scope-conf
Add e2e testcase in seatunnel-e2e
Update connector plugin_config

[ ] Update the release-note.

Hi @yoogoc , please follow the guide to open github action on your fork repository. https://github.com/apache/seatunnel/pull/8002/checks?check_run_id=32718704961

paimon 0.9.0 have a bug about handle tinyint and smallint correctly bug(pr here).
I'm not sure whether to skip e2e or wait for the new version.
@Hisoka-X

paimon 0.9.0 have a bug about handle tinyint and smallint correctly bug(pr here). I'm not sure whether to skip e2e or wait for the new version. @Hisoka-X

Thanks @yoogoc for share this information. I think we should wait for 0.9.1. Any update can not break feature we already supported.

Thank you @yoogoc  A PR should only do one thing, and upgrades and fs support should be separate.

Thank you @yoogoc A PR should only do one thing, and upgrades and fs support should be separate.

+1 It is recommended that upgrading the paimon version be a separate pr, which is a big deal.

Thanks @yoogoc,   I already support upgrade Piamon version to 0.8.2 ,  to be compatible with doris ecology.   doris-paimon

thanks, i close the pr now

Thanks @yoogoc, I already support upgrade Piamon version to 0.8.2 , to be compatible with doris ecology. doris-paimon

cool


Flaky test: ValidationFailureRejectsConnection

This test fails occasionally with the following message:
System.UnauthorizedAccessException : Access to the path '/home/aspnetagent/.dotnet/corefx/cryptography/x509stores/my' is denied.
---- System.IO.IOException : Bad file descriptor
   at System.IO.Enumeration.FileSystemEnumerator`1.FindNextEntry()
   at System.IO.Enumeration.FileSystemEnumerator`1.MoveNext()
   at Internal.Cryptography.Pal.DirectoryBasedStoreProvider.CloneTo(X509Certificate2Collection collection)
   at System.Security.Cryptography.X509Certificates.X509Store.get_Certificates()
   at Internal.Cryptography.Pal.OpenSslX509ChainProcessor.FindCandidates(X509Certificate2 leaf, X509Certificate2Collection extraStore, HashSet`1 downloaded, HashSet`1 systemTrusted, TimeSpan& remainingDownloadTime)
   at Internal.Cryptography.Pal.ChainPal.BuildChain(Boolean useMachineContext, ICertificatePal cert, X509Certificate2Collection extraStore, OidCollection applicationPolicy, OidCollection certificatePolicy, X509RevocationMode revocationMode, X509RevocationFlag revocationFlag, DateTime verificationTime, TimeSpan timeout)
   at System.Security.Cryptography.X509Certificates.X509Chain.Build(X509Certificate2 certificate, Boolean throwOnException)
   at System.Security.Cryptography.X509Certificates.X509Chain.Build(X509Certificate2 certificate)
   at System.Net.Security.CertificateValidation.BuildChainAndVerifyProperties(X509Chain chain, X509Certificate2 remoteCertificate, Boolean checkCertName, String hostName)
   at System.Net.Security.SecureChannel.VerifyRemoteCertificate(RemoteCertValidationCallback remoteCertValidationCallback, ProtocolToken& alertToken)
   at System.Net.Security.SslState.CompleteHandshake(ProtocolToken& alertToken)
   at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartReceiveBlob(Byte[] buffer, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.CheckCompletionBeforeNextReceive(ProtocolToken message, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartSendBlob(Byte[] incoming, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.ProcessReceivedBlob(Byte[] buffer, Int32 count, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.StartReadFrame(Byte[] buffer, Int32 readBytes, AsyncProtocolRequest asyncRequest)
   at System.Net.Security.SslState.PartialFrameCallback(AsyncProtocolRequest asyncRequest)
--- End of stack trace from previous location where exception was thrown ---
   at System.Net.Security.SslState.InternalEndProcessAuthentication(LazyAsyncResult lazyResult)
   at System.Net.Security.SslState.EndProcessAuthentication(IAsyncResult result)
   at System.Net.Security.SslStream.EndAuthenticateAsClient(IAsyncResult asyncResult)
   at System.Net.Security.SslStream.<>c.<AuthenticateAsClientAsync>b__43_2(IAsyncResult iar)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.HttpsConnectionAdapterTests.ValidationFailureRejectsConnection(ClientCertificateMode mode) in /_/test/Kestrel.FunctionalTests/HttpsConnectionAdapterTests.cs:line 303
--- End of stack trace from previous location where exception was thrown ---
----- Inner Stack Trace -----

Future instances of this issue will appear here.

Seems like the process being denied access to the store, but not sure why. It seems to me that is either transient or configuration based

I've also seen DoesNotThrowObjectDisposedExceptionOnEmptyConnection fail due to a similar error in AuthenticateAsServerAsync. dotnet/corefx#29746

Closing as dupe of #2204


Path completion support

It is initial support of path completion capabilities for arbitrary string literals. This completion supports Unix like systems and Windows in uniform way, only paths with normal slashes will be completed. For Windows both styles are supported: c:/Program Files and /Program Files. Unfortunately dynamic changes of working directory by setwd() aren't supported in this PR, but I am working it on.

sorry for the late reply. It's a great idea to have path-completion support. Let me know once you think that the PR for testing & merging.

I have tested PR on Mac OS 10.11.6, Windows 10 and Ubuntu MATE 16.04. Works pretty good. Let's try yourself, I believe it is ready for merge.

Awesome, I have look asap.

I took the liberty to change the completion logic a bit to also take the script file into account, and to resolve relative paths such as "./". See above commit for details. Next we would need to provide setwd support I guess.
The updated plugin was published as v1.0..9 to the plugin repo (which usually takes another day to get reviewed by jb).

Nice work, thank you! I will provide setwd support soon.

I still wonder how we could add unit test support for the completion provider?  Not just for path completion but in general. @ktisha ?


PFS: Identifiers over the three columns in protein family sorter are missing

Only the long time PATRIC user will know that the first column means Present, the second is Absent, and the third is Mixed.

Column headings are added.
However, I think they take up too much space and look verbose. We should try to come up with intuitive icons for include/exclude/dont care or use P/A/E or +/x/- add column heading with mouseover.

This has been addressed. Closing the ticket.


Introduction to Data Modeling (following discussions at LDCX on how to get more...

Introduction to Data Modeling (following discussions at LDCX on how to get more data modeling expertise in Hydra community)
Suggested by: Tom Cramer, Rob Sanderson
Presenter: possibly: Tom Johnson, Rob Sanderson, Mark A. Matienzo, Christina Harlow
Format: Workshop
Audience: Current & would-be data modelers, people who want to know what’s the deal with data modeling

More general than just PCDM.  What's the deal with it?  Is it a workshop?

a. I can confirm that I’ll help lead. Hoping to build off workshop Mark + Tom did, I hope one or both of y’all can help lead as well.
b. Stab at a proper title + synopsis (please respond to/edit/etc. Just setting this up as a strawman - put into our shared doc too):
'Data Modeling 101: What, How, and Why it’s more than PCDM’
‘This will be a half-day, hands-on workshop covering data modeling primarily in RDF. We hope to bring a diverse group of Hydra community members together to learn, discuss, and build out examples that will inform Hydra community best practices for data modeling. This modeling work will be taught in the context of helping Hydra and Fedora development, metadata, and interoperability efforts. We will discuss how model uses a number of standards, and demo the different ways to represent models. We will compare and contract data modeling with metadata standards/profiles. We will walk through modeling efforts around PCDM and its place in our work and community - this workshop will not focus on PCDM alone (this is not a PCDM or RDF workshop). We want this workshop to bring together, develop and engage a larger corps of data modelers in the Hydrasphere.'
Audience: All (audience experience and expertise diversity is welcome, as modeling is at the intersection of many systems, workflows, applications, and work area. It does’t just belong to metadataist or a handful of developers). Audience experience level aimed at beginning - intermediate.
c. Half day? Or do we need to make this a full day?
d. Space with whiteboards/chalkboards/some kind of materials to support breakout group work? Laptops with internet connection strongly recommended, no other software I can think required (protege/webprotege? that may be overkill.) Depending on how many people we have helping lead this, and if we use break out sessions, the numbers of participants seems flexible.


potential bug - only running once?

I'm trying to debug why the diff plugin isn't working and it seems it "works" once... and then the second time you call it it has a different code path.
Is the cache causing a problem potentially?
I'm still trying to debug what's happening but it should be the same path each time but the first run takes a different path and doesnt' call getPreProcessor and shouldBeProcessed isn't applied.

confirmed that the cache breaks this and causes non-determinstic behavior.
especially if you change  ESLINT_PLUGIN_DIFF_COMMIT to an earlier commit like the git init checksum.
It won't show the updated output unless you clear the cache.

I think this could potentially be fixed by moving ESLINT_PLUGIN_DIFF_COMMIT into the eslint config.
I think the problem is that eslint doesn't realize that the ESLINT_PLUGIN_DIFF_COMMIT has changed (why would it?) and then can't invalidate the cache.


[BUG] -

External SPO running XORN
Summary
If cardano-rt-view is restarted, the cardano-node processes won't reconnect. It looses its connection to the rt server, and won't try to reconnect. The issue is resolved by restarting the cardano-node processes.
Steps to reproduce

Restart cardano-rt-view
Go to cardano-rt-view web interface.
All cardano-node processes is in Idle state.

Expected behavior
The cardano-node processes should try to reconnect.
System info (please complete the following information):

OS: Ubuntu, CentOS 7, and Amazon 2.
Version Ubuntu 20.04 server LTS
Node version 1.23.0

Yes, it's a bug. The corresponding issue is already opened: https://github.com/input-output-hk/cardano-rt-view/issues/109

Thanks @denisshevchenko. Since https://github.com/input-output-hk/cardano-rt-view/issues/109 is already an open issue, I'll be closing this one in favour of that.


Edit Data on empty table shows error message

Issue

Type: Bug
Table is empty but some columns are set Not Null.  Click Edit Data and an error message bottom left complains about "commit row failed".
Azure Data Studio version: azuredatastudio-insiders 1.17.0-insider (177a58c81d39446f9724d15cff037087246d32dc, 2020-04-03T16:57:24.010Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2904)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.88GB (8.10GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.0.2

agent
Mic
0.46.0

dacpac
Mic
1.3.0

import
Mic
0.14.0

profiler
Mic
0.11.0

vscodeintellicode
Vis
1.2.1

poor-sql-formatter
WSR
0.1.0

@smartguest could you please take a look to see if this is a regression?

@kburtram This is a regression, apparently when the first cell of the empty row is selected, its normally supposed to create a new null row (for rendering purposes), however since the columns have NOT NULL in them, it causes some issues as the code cannot handle that.

This should be fixed now.


Epic 2 APIs

1)Inviting users to NPDC
Ticket:
https://www.notion.so/developforgood/b3a0d3450c3f4440bed354fcbbbbd455?v=99a42947c6f9479ca891d4f0ee3462e1&p=1dedd2178ba94239963285adddbc672b&pm=s
The configuration settings for the mail server needs to be changed in the dotenv depending on if we're using Amazon Simple Email Service or some other tool. I was using mailtrap.io for testing.
2)Users can join/leave organization
Ticket:
https://www.notion.so/developforgood/b3a0d3450c3f4440bed354fcbbbbd455?v=99a42947c6f9479ca891d4f0ee3462e1&p=9f0b34313c434b90b97c296d57cbe5b3&pm=s
3)Remove users from org/withdraw their invitation
Ticket:
https://www.notion.so/developforgood/b3a0d3450c3f4440bed354fcbbbbd455?v=99a42947c6f9479ca891d4f0ee3462e1&p=db318391f99849c488c38c0c6610ef2e&pm=s
4)Change roles of users in a partner org
Ticket:
https://www.notion.so/developforgood/b3a0d3450c3f4440bed354fcbbbbd455?v=99a42947c6f9479ca891d4f0ee3462e1&p=3cbd315ee9144897b36d476f7832dae8&pm=s

Added changes to admins not being able to demote other admins and moving code from invite_users to "add_members_to_partners".

Looks like I have to re-request review for this after fixing some merge conflicts between main and invite_users.

No problem! You're good to go.