Device ID not detected in Azure Single Sign On using MSAL 2.23.0 (Browser)

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.23.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
My app is a browser extension with MSAL 2.23.0 (browser). It had been working fine until one day IT department imposed a conditional access rule that restrict domain joined device. That is when I realize AAD had rejected the signin because it can't determine if the device is domain-joined due to missing Device ID.
I had tested my extension in Edge, Firefox, Chrome browser, same result.
Error Message
Error Code: 53001
Request Id: 8571d6f5-0981-428d-b419-beb6ad9c9300
Correlation Id: 4045aa28-6dea-4cf8-ad32-5c09f7853ea0
Timestamp: 2022-04-27T04:07:42.506Z
App name: xxx
App id: xxxxxxx
IP address: xxxxxxxx
Device identifier: Not available
Device platform: Windows 10
Device state: Unregistered
Msal Logs
Unchecked runtime.lastError: The user did not approve access.
MSAL Configuration
// Get The Chromium URL dynamically
 const redirect_uri = typeof chrome !== "undefined" && chrome.identity ?
    chrome.identity.getRedirectURL() :
    `${window.location.origin}/index.html`;

const tenant_id    = 'xxxx';
const client_id    = 'yyyy'

// Init MSAL Instance
const msalInstance = new msal.PublicClientApplication({
    auth: {
        authority:  `https://login.microsoftonline.com/${tenant_id}`,
        clientId:    client_id,
        redirectUri: redirect_uri,
        postLogoutRedirectUri: redirect_uri,
        navigateToLoginRequestUrl: false
    },
    cache: {
        cacheLocation: "localStorage"
    }
});

Relevant Code Snippets
async function ssoLogin() {
    const sso_login_url = await getLoginUrl();
    const tokenResponse = await launchWebAuthFlow(sso_login_url);  // trigger popup window login
}

async function getLogoutUrl(request) {
 return new Promise((resolve, reject) => {
     msalInstance.logout({
         ...request,
         onRedirectNavigate: (url) => {
             resolve(url);
             return false;
         }
     }).catch(reject);
 });
}

In manifest.json, msal library must be loaded, snipet as below:

  "background":{
      "scripts":["libs/msal-browser-2.23.0/msal-browser.min.js"]
 }

Reproduction Steps
The codes above is background script of an extension.

Azure AD App registration must be configured to allow SPA with the chrome extension URL as redirect. Configure your own tenant and client ID.
load the extension in browser (Edge, Chrome, Firefox will work)
open the background page of the extension (in developer mode)
hit "ssoLogin()"
Follow through the sigin process (username/password/mfa)
Check the AAD signon logs, witness that Device ID is blank

Expected Behavior
Device ID should not be empty
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox, Edge
Regression
No response
Source
External (Customer)

any update on this ?

For Chrome, please install the Windows Account extension, which should handles including your device id in outgoing requests (MSAL.js is not and cannot be responsible for including device id): https://chrome.google.com/webstore/detail/windows-accounts/ppnbnpeolgkicgegkbkbjmhlideopiji

I had tried the extension, it doesn't work as well. Don't understand how this would help.
When using chrome identity API, "launchWebAuthFlow" will launch a window for SSO login, it is this window that I suspect the device ID didn't get pass through.

The chrome extension or Edge browser is required in order to inject the deviceId into the request. It sounds like the extension isn't getting loaded into the window opened by the launchWebAuthFlow API. You may need to open a new tab to the /authorize endpoint and then find a way to feed the response back to your extension. We unfortunately don't have an example of how to do this. We have another issue open for Chrome extension compatibility: #3923 which we are using to track better guidance for integrating MSAL.js with extensions

The chrome extension or Edge browser is required in order to inject the deviceId into the request. It sounds like the extension isn't getting loaded into the window opened by the launchWebAuthFlow API. You may need to open a new tab to the /authorize endpoint and then find a way to feed the response back to your extension. We unfortunately don't have an example of how to do this. We have another issue open for Chrome extension compatibility: #3923 which we are using to track better guidance for integrating MSAL.js with extensions

Hi Team. I am also having the same issue, while login using android MSAL lib. DO we have a workaround of Android app login ?

@tnorling I am also running into the same issue with Edge browser using the ChromiumExtensionSample. The /authorize endpoint will succeed in a standard browser tab where I am signed in to an Edge profile, but not in the popup window opened by the extension. Any ideas on how to resolve this?


Update to go 1.16

Now that go 1.16 is available, let's upgrade the buildpack to use it

This is already covered in #174: https://github.com/paketo-buildpacks/bundle-install/pull/174/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L3-R3. I'm gonna close this so we don't have to deal with merge conflicts there.


Documentation type mismatch for slider response plugins

Similar to issue #682, the slider response plugins produce a string as the response (final numeric value of the slider) but the docs say that the value of response is an integer: https://www.jspsych.org/plugins/jspsych-audio-slider-response/#data-generated
Following #682, I assume that the value of response in the data should be an integer rather than string. Also, the slider plugins now save the slider's start value, which is currently an integer, so at the very least these should be consistent.

Following #682, I assume that the value of response in the data should be an integer rather than string.

Yeah, I agree. I think the .value property of the <input> element must default to a string. We can convert this before saving in the data.

Got it, thanks!


Set number should be setlocal

Hi, thanks for the nice plugin.
You have a 'set number' or similar in the plugin, but it would be great if this was setlocal or similar, so it doesn't change settings for non-csv buffers (and buffers opened after the csv buffer)

Thanks for letting me know!
Should be resolved by 5033e3abd4fb0a0ee07232530a032296535704b4

thanks!


updates inline comments

What does this PR do?
Fixes comment in UserController.php construct function to have GET all capitalized. Updates comment in AvatarController.php store function to remain consistent with other endpoints.
What are the relevant tickets?
Fixes #234

@DFurnes / @angaither whenever you get a sec to take a look!

Looks good to me! :+1:


Upgrading to AD FS: typos and whitespace

Description:
As pointed out in the issue ticket #2707 (Mistype ?), there is a typo in the sentence "[...] note that this requires one of the new Windows Server 2019 federation servers tp be promoted to the role of primary
node in the farm." -- where "tp" should have been "to".
Thanks to @TheOtherBillGates and @NomadRex for reporting this typo.
While browsing this document source to correct this typo, I noticed a couple of other typos as well, and later on noticed a lot of whitespace inconsistencies. I have replaced some occurrences of "commandlet" with 'cmdlet' (the latter being the proper PS term).
Proposed changes:

correct a few typos (tp, rasing)
replace "commandlet" with 'cmdlet'
remove trailing whitespace (blanks at the end of lines)
add missing MarkDown quote marker compatibility space in 2 Notes
remove 3 redundant blank lines
keep PowerShell code blocks preceded and succeeded by a blank line
move 2 cmdlets to a proper code block with PS syntax highlighting

issue ticket closure or reference:
Closes #2707

Changes in my second commit, https://github.com/MicrosoftDocs/windowsserverdocs/pull/3471/commits/d54c74692df51b7f2de8de524a94b1971da8b239 :

remove indentation of image links to preserve the link functionality
reduce 3x blank space to single blank space in ordinal points
remove redundant indentation for some remaining indented lines
add blank line between the last PS code block and the last text line

Due to the massive effect the whitespace changes has on normal source file view, there are a couple of methods the file can be viewed to avoid getting the impression of massive text rearrangement instead of only whitespace change. The first method is the "Hide whitespace changes" code setting:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/3471/files?utf8=✓&diff=unified&w=1

Secondly, there is the choice of viewing the file using the Rich Text Diff view:

https://github.com/MicrosoftDocs/windowsserverdocs/pull/3471/files?short_path=b678a09#diff-b678a09b52204b4e60c70f4a70262298
(please note that most of the images and their text show up as changed in this view, even if there is only whitespace indentation removal for those lines)


Amplify Dependecy Issue

To use this package in the same codebase as AWS Amplify, we need to upgrade to intl 0.18.1. Also update the ref for charts_common to point to the 2023.10.31 tag which will have intl 0.18.0 in its pubspec. Finally needed to bump cupertino_icons in the example project and analyzer for charts_flutter but neither of those should have any impact on projects using charts_flutter.

LG (looks good)
Franz
On Wed, Nov 1, 2023 at 7:51 AM 'nharris-emporia' via Developer Group <
@.***> wrote:

Merged #2 https://github.com/devs-emporia/charts/pull/2 into master.
—
Reply to this email directly, view it on GitHub
https://github.com/devs-emporia/charts/pull/2#event-10832675685, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AZKG2Q4YY4PBKJNDKPHOA2DYCJHXRAVCNFSM6AAAAAA6YG4HGSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHAZTENRXGU3DQNI
.
You are receiving this because you authored the thread.Message ID:
@.***>
--
You received this message because you are subscribed to the Google Groups
"Developer Group" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to @.***
To view this discussion on the web visit
https://groups.google.com/a/emporiaenergy.com/d/msgid/DeveloperGroup/devs-emporia/charts/pull/2/issue_event/10832675685%40github.com
https://groups.google.com/a/emporiaenergy.com/d/msgid/DeveloperGroup/devs-emporia/charts/pull/2/issue_event/10832675685%40github.com?utm_medium=email&utm_source=footer
.


Investigate NER and CRF

Investigate Named Entity Recognition and the related field of Conditional Random Fields for the purpose of location extraction from articles.

After our discussion at ChiHackNight on August 29, I developed a function to extract locations from articles using the NLTK chunk parser. It parses POS tags using regex to identify locations such as "2000 block of South Halsted Street" and "2000 South Halsted Street". I'm not sure which methods you've tested so far for location extraction, but if my function sounds useful, I can contribute the code to the project.
I wrote two other functions that use the data generated by the above method. The first validates bare addresses, such as "South Halsted Street", against the City of Chicago's 'Street Names' database. The second uses the Google Map Geocoding API to retrieve geographical coordinates for a valid address.
In the next couple of days I'll look over the existing code in the project to evaluate your current extraction methods.

We looked at a regex based approach. I'm not convinced that a regex solution would end up with better FPR/TPR than a probabilistic approach, but the only way to be sure of that is to check it against ground truth data. We just updated the data dump script last night so hopefully next week I'll have some of that ground truth location extraction data.
If you want to see how others have tried to use regex's for this problem, check out everyblock. I forked their code here: https://github.com/kbrose/everyblock
Specifically, you may want to look at the files in https://github.com/kbrose/everyblock/tree/master/ebdata/ebdata/nlp

Thank you for that feedback. I just glanced at the everyblock code. The NLTK chunker is a bit different. Instead of pure regex, the chunker operates on POS-tags. For instance, the phrase "2700 block of South Halsted Street" is tagged as:
[('7200', 'CD'), ('block', 'NN'), ('of', 'IN'), ('South', 'NNP'), ('Halstead', 'NNP'), ('Street', 'NNP')]

A chunking grammar, such as <CD><NN><IN><NNP>*, will extract sequences that match the pattern. It's a bit less ruled-based than pure regex parsing, as is done by everyblock, but it is indeed conceptually similar.
I'll add the Jupyter notebook to my git after I've done more testing, so you can test for yourself. I agree, a probabilistic approach would be best. I'll try to develop a classification chunker and see how that works out. It will be very useful to test with the forthcoming ground truth data.

Update: decided to test a CRF approach today using CRFsuite. Preliminary results look promising. It's a bit time consuming as I have to build a custom corpus to use for training, which involves adding IOB annotations to tokens that are to be classified as a sequence. The data from the corpus consists of random paragraphs that have been extracted from the 2gb newsarticles_article.csv file.
Speaking of that monster file: please excuse my ignorance: is there a particular reason that all the articles are aggregated into a single file? Did you guys consider storing each article as a separate file?, ie. as done for the Groningen Meaning Bank: http://gmb.let.rug.nl/data.php. Individual files for articles would be very handy for visual inspection, corpus generation, EDA, and other training purposes, rather than having to process a huge file.
In any case, I'm really enjoying working on this issue. Just sorry that I can't allocate more time than I already am.

Good to hear, I just updated the loading functions to handle the new data format which will have some of the human coded locations. If you find yourself spending a lot of time manually tagging articles it would probably be good to have you do that through the actual CJP interface so that we can collect that data and have everyone benefit from it.
No one else is working on the approaches described above as far as I know so no worries about duplicating effort.
Re: 2 GB file -- that was what was easiest for people working on scrapers/volunteer web UI and no one's asked for anything else. As long as you have the memory to pull it all in once it should be pretty straightforward to process/save it in the way you described. If you do end up writing that please submit that piece of code in a PR because others may find it useful.
If you're using pandas to load the CSV you could also look at the nrows and skiprows parameters. They will probably provide everything you need if you do not have enough memory.

Closing in favor of #62.


Add support for radial search in exact search

Description
When threshold value is set, knn plugin will not be creating graph. Hence, when search request is trigged during that time, exact search will return valid results. However, radial search was never included as part of exact search. This will break radial search when threshold is added and radial search is requested. In this commit, new method
is introduced to accept min score and return documents that are greater than min score, similar to how radial search is performed by native engines. This search is independent of engine, but, radial search is supported only for FAISS engine out of all native engines.
Related Issues
Part of #1942
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This depends on https://github.com/opensearch-project/k-NN/pull/2136

There doesn't seem to be updates in unit tests, will it be present in another iteration?

Added unit test


Wrong content Length for big image

Hi,
I didn't have any problem to use this library. However for load an image which is contentLength is 1608489, i got some trouble :
Error Domain=com.alamofire.error Code=-1016 "Failed to create a valid Image from the response data"
And in  the Content-Length return by the request is : 19
headers {
"Accept-Ranges" = bytes;
Connection = "Keep-Alive";
"Content-Length" = 19;
"Content-Type" = "image/png";
Date = "Mon, 27 Jun 2016 12:01:28 GMT";
Etag = ""316e17-13-53607e6c35185"";
"Keep-Alive" = "timeout=5, max=100";
"Last-Modified" = "Fri, 24 Jun 2016 15:34:07 GMT";
Server = Apache;
} })
This is how i load the image :
self.profil.af_setImageWithURL(NSURL(string: urlServer! + user.photo!)!, placeholderImage: UIImage(named: "user"), filter: nil, imageTransition: .FlipFromLeft(0.2), completion: { (response) -> Void in
self.profil.image = response.result.value
print(response.result.error)
print(response.response)
print(response.request)
})
This the image i try to load : http://jackson.daveo.ovh/uploads/guillaume.duez.png
It s an image import from an Iphone 5s.

Hi @dragopot,
I put together a quick test to see what could be wrong with your image and everything seems to be working properly. Here's the test I put together:
func testLargeCustomImage() {
    // Given
    let URLString = "http://jackson.daveo.ovh/uploads/guillaume.duez.png"
    let expectation = expectationWithDescription("Request should return PNG response image")

    var response: Response<Image, NSError>?

    // When
    manager.request(.GET, URLString)
        .responseImage { closureResponse in
            response = closureResponse
            expectation.fulfill()
        }

    waitForExpectationsWithTimeout(timeout, handler: nil)

    // Then
    XCTAssertNotNil(response?.request, "request should not be nil")
    XCTAssertNotNil(response?.response, "response should not be nil")
    XCTAssertTrue(response?.result.isSuccess ?? false, "result should be success")

    if let image = response?.result.value {
        print("Image: \(image)")
    } else {
        XCTFail("result image should not be nil")
    }
}

If you copy that into the BaseTestCase class and run it, you'll see it passes successfully. Because of this, I'm not really sure what to tell you. I'd take a look at the test and try to figure out what's different between that logic and possibly how you're constructing your URL.
I'm going to close this issue out for now. If you track this down further and feel there is something else worth us investigating, please provide more details and we'll happily re-open and investigate further.
Cheers. 🍻


#bug; Uniswap V3 Eth WBTC price 0 in certain block ranges

Describe the bug
The price of WBTC is 0 in certain block ranges:

17127285 -> 17180499
16844415 -> ??

Obviously, this shouldn't be happening. There may be something in the current pricing mechanism that is triggering this false positive in certain cases and setting the price to 0.

Addressed in this PR - > https://github.com/messari/subgraphs/pull/2158
Currently indexing here: https://thegraph.com/hosted-service/subgraph/steegecs/uniswap-v3-ethereum.


style suggestion for jax tutorial 11 (flows)

The code uses the variable ldj but this is never explained.
Just say that ldj = log-det-jacobian :)

Also, in cell 16, you say Test MultiheadAttention implementation but this is using a gated ConvNet, not attention.

Didn't notice that I hadn't explained the abbreviation at all, thanks! :)
Fixed in fa80c4da32b8a147996717fba08963dcc11be9f7


Error with DB initializer UdtMap method on cassandra not found

I try to use the project. When I use the DB initializer as described in the documentation, I got the following error:

Unhandled exception. System.MissingMethodException: Method not found: 'Cassandra.UdtMap`1<System.__Canon> Cassandra.UdtMap.For(System.String)'.
at AspNetCore.Identity.Cassandra.DbInitializer.Initialize[TUser,TRole](CassandraOptions options)
at AspNetCore.Identity.Cassandra.Extensions.IWebHostExtensions.InitializeIdentityDb[TUser,TRole](IWebHost host)

Im using version 2.2.0 of the driver in a .NET Core 3.0 application.
In addition, I wanted to create in the meanwhile the db structure by myself with the provided documentation where you draw the created objects. But the types which are used are left in your documentation (e.g. logininfo).

The library is tested on .NET Core 2.2, not 3.0, so I have to create some showcase to simulate this issue, or could you provide me a link to a repo, where can I simulate it?
Regarding the Data Types, take a look to DbInitializer

Sorry I can’t provide a repo. I played around with it, by using the source code directly and simply switch the .NET version in the csproj file all works well.
/Michael

Von: lkubis<EMAIL_ADDRESS>Gesendet: Thursday, December 12, 2019 12:33:52 PM
An: lkubis/AspNetCore.Identity.Cassandra<EMAIL_ADDRESS>Cc: Michael Baarz (External - Capgemini Sverige AB<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Betreff: Re: [lkubis/AspNetCore.Identity.Cassandra] Error with DB initializer UdtMap method on cassandra not found (#5)
The library is tested on .NET Core 2.2, not 3.0, so I have to create some showcase to simulate this issue, or could you provide me a link to a repo, where can I simulate it?
Regarding the Data Types, take a look to DbInitializerhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flkubis%2FAspNetCore.Identity.Cassandra%2Fblob%2Fc9b92252ef8f0dbbbabd0a9e2629a7dbf7bfd50d%2Fsrc%2FAspNetCore.Identity.Cassandra%2FDbInitializer.cs%23L42&data=02|01|michael.baarz%40ikea.com|ec5494e8444646b974e708d77ef72aeb|720b637a655a40cf816af22f40755c2c|0|0|637117472348711431&sdata=UXCUn%2Bf8cSs1ZCKFJdXZm37a03e%2BY%2BhK63Nx70oFlcI%3D&reserved=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flkubis%2FAspNetCore.Identity.Cassandra%2Fissues%2F5%3Femail_source%3Dnotifications%26email_token%3DAOACINRUCI76D6TWGL5B6WTQYIOSBA5CNFSM4JY4IAP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWME7Q%23issuecomment-564970110&data=02|01|michael.baarz%40ikea.com|ec5494e8444646b974e708d77ef72aeb|720b637a655a40cf816af22f40755c2c|0|0|637117472348721425&sdata=ciwNOy4xEkrt%2FItPsY%2FpV25XQE0U8ht95RlP%2BYxvOwY%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOACINV5GTBL4JT6R7RAZFLQYIOSBANCNFSM4JY4IAPQ&data=02|01|michael.baarz%40ikea.com|ec5494e8444646b974e708d77ef72aeb|720b637a655a40cf816af22f40755c2c|0|0|637117472348721425&sdata=yALOVQjW3ePyjgvWO0CFNhI4QtPhI5bJB3qX0Tt1MBw%3D&reserved=0.


[WIP]: feat(minecraft-server): onbuild trigger for downloading plugins and mods

I added the discussed ONBUILD trigger from issue #218 to download any files specified in a plugins or *.plugins.yml file.
The ONBUILD trigger uses the ToF-BuildTools to download files and place them into the plugins directory. The output directory can be changed via the BUILDTOOLS_OUTPUT argument.
If no plugins.yml or *.plugins.yml file exists nothing will happen.
Example plugins.yml file:
plugins:
  worldedit:
    file: WorldEdit.jar
    url: https://dev.bukkit.org/projects/worldedit/files/latest
  FastAsyncWorldEdit:
    file: FastAsyncWorldEdit.jar
    url: https://empcraft.com/fawe/latest.php?bukkit
  worldguard:
    file: WorldGuard.jar
    url: https://dev.bukkit.org/projects/worldguard/files/latest
  citizens:
    file: Citizens.jar
    url: https://dev.bukkit.org/projects/citizens/files/latest

Closes #218

I am not sure yet if this is the solution. Somehow the plugins seem to vanish from the /plugins dir :/

It seems like I have noticed weirdness when pre-populating paths that are designated as a VOLUME in the Dockerfile. You could try removing that path from
https://github.com/itzg/dockerfiles/blob/master/minecraft-server/Dockerfile#L50
to see if that fixes it. If so, I'm ok with leaving /plugins out of there because an end user can still -v attach a volume at /plugins even if it is not pre-declared in the Dockerfile.

Awesome tip, thanks!
Without the /plugins volume declaration everything works like a charm :)
I also tested it in conjunction with #268 and using a /data/plugins that contains the configs of the plugins. When the server starts all downloaded plugins JAR files will be copied into the plugins folder keeping the git managed configs from the volume mapping as is.
👍

I'll think they'll be fine to merge separately. I'll merge #268 in a moment and we'll see. I wanted to do a quick test or two on this current PR next.

...oops, I spoke too soon and hadn't noticed the Dockerfile changes in both. The "Resolve conflicts" up there usually works nicely.

I resolved the conflicts.

Sorry, I forgot to ask earlier, but can you add a README sub-section in/near the Spigot section with a brief description and a link over to your build tools docs?

Do you mind if I push a examples directory, such as:

Using the plugins.yml snippet you provided I'm seeing these errors, but I haven't done any investigation into the dev bukkit area:
 ---> Running in 0b75389414a2
Loading BuildTools version: git-ToF-BuildTools-d1c5b47-unknown (#-1)
git version 2.18.1
Git name not set, setting it to default value.
Git email not set, setting it to default value.
Starting download of https://dev.bukkit.org/projects/worldedit/files/latest
No file to download. Server replied HTTP code: 403
Failed to download https://dev.bukkit.org/projects/worldedit/files/latest as WorldEdit.jar
Starting download of https://empcraft.com/fawe/latest.php?bukkit
Downloaded file: /plugins/FastAsyncWorldEdit.jar with md5: 4dd65870357bcb83abc721c71c01ea4e
Starting download of https://dev.bukkit.org/projects/worldguard/files/latest
No file to download. Server replied HTTP code: 403
Starting download of https://dev.bukkit.org/projects/citizens/files/latest
Failed to download https://dev.bukkit.org/projects/worldguard/files/latest as WorldGuard.jar
No file to download. Server replied HTTP code: 403
Failed to download https://dev.bukkit.org/projects/citizens/files/latest as Citizens.jar

This and #268 are now published on Docker Hub.

@itzg I fixed the BukkitDev downloads. Admins can now provide their BukkitDev API key to avoid the 403 error.
Plus there is a new feature to download the latest plugin by its BukkitDev ID: https://git.faldoria.de/tof/server/build-tools#latest-plugin-from-bukkitdev-curseforge


Hotfix rounding fields values on WBT write

Fix #582: it seems that using QDoubleSpinBox::text().toDouble() instead of QDoubleSpinBox::value() solves the issue.

:+1:

:eyes:

:+1:


Limit Setting

Could use some more limit setting options. Some easy ones to implement would probably be:
Maximum Gap method - an MC version is very easy and Yellen provides analytic expressions too if I can convince myself that I understand them.
CLs limit - limits in the presence of a background. This would be an alternative to something like the Feldman-Cousins limit. Used extensively in things like collider experiments
Best fit bands would also be important. Likelihood methods will be easiest but it will be more complicated than just getting limits.
DAMA/LIBRA uses a model-independent fit to show that they have an oscillating signal. Implementing something like this would be useful. Would need to work out a good way to do model comparison between flat vs oscillating signals. Maybe one of the early DAMA/NaI papers goes over how they do this?

Related to this, I think a lot of the limit types take more or less the same input, so it might be best to have a single limit class and then let the user choose the algorithm

CLs limits are now implemented as a function. Still need to work on the limit setting API


Inconsistent Icon Customization for ItemConfig in PersistentTabView

Description
While using persistent_bottom_nav_bar_v2 (version 5.0.0-beta.7), I encountered an issue where the icon customization is inconsistent between the active and inactive states in PersistentTabView. Specifically, the ItemConfig allows for a widget to be passed for the active icon, enabling the use of custom widgets such as SvgPicture. However, for the inactive icon, it seems only material icons can be used. This inconsistency restricts the customization capabilities and affects the UI consistency of the navigation bar.
Expected Behavior
Both the active and inactive icons in ItemConfig should allow the same level of customization. Ideally, being able to pass any widget (e.g., SvgPicture for custom SVG icons) for both active and inactive icons would provide the necessary flexibility for app design.
Actual Behavior
Currently, the active icon accepts a widget, allowing for custom icons (like SVGs), but the inactive icon only accepts material icons. This limits the design possibilities and makes it challenging to maintain a consistent look when the icon changes state.
Steps to Reproduce

Install persistent_bottom_nav_bar_v2 version 5.0.0-beta.7.
Create a PersistentTabView with multiple tabs.
Try to set a custom widget (like an SVG) as an inactive icon in ItemConfig.

Suggested Solution
Allow ItemConfig's inactive icon parameter to accept a widget, similar to the active icon. This change would provide developers with the flexibility to maintain a consistent and customized look for both active and inactive states.
Additional Context
Thank you for considering this issue. The ability to fully customize icons in the navigation bar is crucial for many developers looking to provide a polished and unique user experience in their apps.

Thank you for pointing that out, you are completely right. The fix will be included in the next beta release.

The fix is available with version 5.0.0-beta.8


Why BigFloat.to_s is not precise enough?

First I though that BigFloat requires to change  BigFloat.default_precision to work with bigger number. But from this code it looks like it only matters when trying to output #to_s value, because converting BigFloat to BigInt gives different result from BigFloat.to_s
https://carc.in/#/r/2w96
Code
require "big"

x = BigInt.new(1<<30) * (1<<30) * (1<<30)
puts "BigInt: #{x}"

x = BigFloat.new(1<<30) * (1<<30) * (1<<30)
puts "BigFloat: #{x}"
puts "BigInt from BigFloat: #{x.to_big_i}"

Output
BigInt:<PHONE_NUMBER>285380274899124224
BigFloat:<PHONE_NUMBER>285380274900000000
BigInt from BigFloat:<PHONE_NUMBER>285380274899124224

Same with precision of BigFloat set to 1024 (https://carc.in/#/r/2w98):
Output
BigInt:<PHONE_NUMBER>285380274899124224
BigFloat:<PHONE_NUMBER>285380274899124224
BigInt from BigFloat:<PHONE_NUMBER>285380274899124224

BigFloat.to_s uses LibGMP.mpf_get_str(nil, out expptr, 10, 0, self). Where GMP is saying:

mpf_get_str (char *str, mp_exp_t *expptr, int base, size_t n_digits, const mpf_t op)
Convert op to a string of digits in base base. The base argument may vary from 2 to 62 or from -2 to -36. Up to n_digits digits will be generated. Trailing zeros are not returned. No more digits than can be accurately represented by op are ever generated. If n_digits is 0 then that accurate maximum number of digits are generated.

(This is related to https://stackoverflow.com/questions/46711149/why-bigfloat-to-s-is-not-precise-enough)
Thanks.

In StackOverflow, the issue was fixed by increasing the default precision. @asterite raised the question if the precision of BigFloat can be increased.
Can it be considered as solved?

I think we can, BigFloat.default_precision is there to change the default, although I am not sure what is the initial value from GMP.
There is a bit of a leak abstraction I guess if the user needs to worry about this instead of using Big* as an arbitrary precision library. Or maybe is my lack of use of these libraries.
Closing since there is a workaround, but we can open later if there is something concrete to change.


Release 4.0.0

Other than the last typo, LGTM!

Random thought: I wish there were a tool to easily compare public API of two versions of a Swift lib, so we can easily review which public methods were added/renamed/deleted and ensure we do semantic versioning properly and that this is indeed a 4.0.0.
In our case there is no doubt, as you removed the deprecated methods anyway so that breaks backward compatibility and thus does a 4.0.0, but for next time such a tool would be awesome

Fixed the last typo. Let's make release?

Tadaaa :tada: https://github.com/AliSoftware/Dip/releases/tag/4.0.0


Github Commits Tracker

GitHub Commits Tracker
Overview
Currently every user can register a github account to there profile. We also manage project data and which users are on each project. If we where to collect project github link(s) and assuming the members of the project on portal are also members of the project on github, we can aggregate commits for each user based on the projects they are on. This can be a great advantage for users as they can download there commits from portal. This can also have an impact when it comes to grading as it gives a live view at a students commits and this can be reference at mid/end of semester.
Project Extensions

[ ] Collect Project GitHub Link(s). Note: Some projects may have multiple repositories so being able to collect multiple links is important.

GitHub to Portal
To retrieve user commits, we can periodically query github for commits for each project. We can then store this snapshot of the commits in portal as to avoid multiple API requests to github (not sure of a limit). We can then match the commits to the users.

@Apexal do u want me to handle this

Note: This ideally would serve as a https://bnidevs.github.io/get-my-commits/ feature in portal.

The database is ready for this to be added any time. Projects even support multiple repositories already!
The only potential blockers are that there's no way for project owners/leads to add/remove repositories to their projects after they first created the projects. Coordinators/Faculty Advisors can of course manually repositories to projects, but it'd be better if the project lead could do so.
We should add a project edit page for project leads, and then work on this! I'll quick create an issue for the project edit page.

We should also make use of our Redis cache to make as few calls to GitHub as possible. Maybe make refreshing the data an explicit action that students have to click to do, instead of fetching automatically every time a page is viewed.
Orrr we fetch automatically in the background every night, and offer manual refresh?
Thoughts here? How strict is the API limit for this sort of thing @bnidevs

@Apexal I believe it's 5000 calls an hour with a key, but getting all commits for one repo may cost more than one call because it's paginated


Add Conference Room devices to DB

"Blocked" by https://github.com/byuoitav/configuration-database-tool/issues/1.

Done.


Restrict user group modification permissions to admins and user group members

Currently, anyone can add or remove members from a user group, edit the user group name and description, delete user group etc. We should restrict this to only admins and user group members.
We might want to have a better security model for this in future as but this is probably good enough for now. See https://chat.zulip.org/#narrow/stream/general/topic/user.20groups.20permissions for more details.

@zulipbot claim

@Kumar-Tarun Did you make some changes to settings_user_groups.js?

@AasthaGupta  Yeah, to solve this issue, I changed this file and when I wanted to test this, the above error popped up.

@Kumar-Tarun  Then, there may be some errors in the changes you made. Look at your code carefully, if there are any syntax errors.

@AasthaGupta that was a silly doubt from my side, indeed there was a syntax error, I left some statements open without closing the curly brace. Btw thanks for the help.

@synicalsyntax I need your help here, as I saw your PR regarding the UI for user-groups. I wanted to know is there any way to detect that the user is clicking on the exit button of a member pill, so as to remove it, I mean I need to disable that 'clicking to remove' according to this issue. I have already blocked the user from adding any pill but the removing part is still not clear to me.
Also, a side note is it necessary for the user group to have atleast one member ?
P.S I also have blocked the save changes option on removing a pill, so a user can just remove the pill virtually, on refresh that appears again, I just need to block the removing aspect also.

@Kumar-Tarun I'd ask @brockwhittaker instead, since he implemented the pills library.


docker-machine -v error on Mac osx

enviroment
Mac OS X 10.9.5

steps:
2.1 install the docker follow the document http://docs.docker.com/installation/mac/
2.2 install the docker machine follow the document https://docs.docker.com/machine/

it gives the following errors and exit when i enter the command "docker-machine -v"

/usr/local/bin/docker-machine: line 1: syntax error near unexpected token <' /usr/local/bin/docker-machine: line 1:  You are being redirected.'

This was from an error in the docs.  Those have been updated.  Specifically:
$ curl -L https://github.com/docker/machine/releases/download/v0.2.0/docker-machine_darwin-amd64 > /usr/local/bin/docker-machine
$ chmod +x /usr/local/bin/docker-machine

There was a missing arg to curl.
Please follow those again to properly download machine.  Thanks!


Mailchimp profile updates will contain undocumented ip_signup param

Payload data for profile updates will include an undocumented ip_signup
param which will make the event enriching fail due to validation errors.

@razius  has signed the Software Grant and Corporate Contributor License Agreement


Eloquent and Upsert

Thanks for the great library.
Can we get an example of using an eloquent object and upsert?
My code:
class Contact extends Eloquent {
    protected $connection = 'mongodb';
    protected $collection = 'contact';

}
....
$c = new Contact;
... add vars (a duplicate email!)
$c->save(array('upsert' => true));
error : MongoDuplicateKeyException in Collection.php line because of my purposeful unique index
any help would be great! Thanks in advance.
Gary

I have answered my own question:
$c->update(array('upsert' => true));
works as expected. Awesome!

$data = array ('name'=>'Jhon') ;
DB::collection('users')->where('id',$id)->update($data , array('upsert' => true));

Insert new row ! Then how it works ?

Is there a way to determine if the record has been inserted or updated?
Just came here with the same question


Feature/Fix E2E error on Header languages

Fix the error on verifying languages when running the E2E failing on staging
What does this pull request aim to achieve? 💯
Please be concise and link any related issue(s):

[ ] I have checked that no one else is working on similar changes.
[ ] I have read the latest README and understand the development workflow.
[ ] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[ ] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[ ] There are no merge conflicts.
[ ] There are no console warnings and errors.
[ ] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[ ] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

hi @galeza @jessica-lau , when i run the E2E and see header failing 24 scenarios with error - failed because this element is detached from the DOM.  Would you please check if you see the same issue.  I also make the fix for this issue in this PR#2128 and please see if you have any suggestion to make it simpler.

hi @galeza @jessica-lau , when i run the E2E and see header failing 24 scenarios with error - failed because this element is detached from the DOM.  Would you please check if you see the same issue.  I also make the fix for this issue in this PR#2128 and please see if you have any suggestion to make it simpler.

@adorapham
Which version will you decide to keep? Yours or simplified, proposed by @jessica-lau ?

@galeza let keep my version which has only one extra line       .should(($languageEl) => {.  Next time, when doing any other PR, I will change ,

@adorapham
Which version will you decide to keep? Yours or simplified, proposed by @jessica-lau ?

@galeza let keep my version which has only one extra line       .should(($languageEl) => {.  Next time, when doing any other PR, I will change ,


Incorporate updates to data pipeline made in drb-inland-salinity

This PR incorporates updates to the data pipeline that resulted from discussions in the inland-salinity repo (namely inland-salinity PR 19 and inland-salinity PR 31). These changes include:

Add earliest_date to the data retrieval calls so that we are not pulling data before ~1980 when the met data begins (resolves issue #29)
Add special handling for site 01482537, which was recently added to NWIS. See discussion in Teams for further details. (resolves issue #31)
Add log/ind files to the repo to better track data changes through time.
Update the site list to find the CRS used for the WQP data and project to a single, user-specified datum

One thing that I've been thinking about lately: there are some parts of the pipeline that we aren't using currently and may not be using in the near future. These include

The hourly summaries
The hourly/daily plots of each station

I'm really glad we have that code in the repo so we can use it if/when we need to, but I'm thinking for now, we can just take out those targets from the pipeline so we aren't building targets we aren't currently needing. And then down the line, we can always add those back in.
Even tho they are nice to have for an overview, I think that we can just use those functions as needed instead of plotting for every station automatically.

I'm actually kind of thinking we maybe should take out the Python plots too 😄. They kind of take a while to build and then without them we can get rid of those csv targets in 1_fetch.R. They were nice to have to get a feel for the data, but I'm not sure we need to keep them around. I could be pursuaded otherwise tho about both the python targets and the plots from r.
Maybe we do a happy medium and produce one summary plot with ggplot (to avoid the python rigmarole)

One thing that I've been thinking about lately: there are some parts of the pipeline that we aren't using currently and may not be using in the near future. These include
The hourly summaries
The hourly/daily plots of each station

I've kept the functions for reference but removed the targets that create the hourly aggregated values as well as the hourly/daily plots (https://github.com/USGS-R/drb-do-ml/pull/32/commits/eb38f58b188c2d2247622f39be1027ae603ee9f6).

I think that if we opt to leave p2_site_list_csv as a file target, I've addressed and committed all of the changes we've discussed here. Let me know if you see anything else before we merge.

Looks great. Thanks, @lekoenig

Feel free to merge whenever


Replace cargo-asm with cargo-show-asm in recommendations

cargo-asm is no longer maintained, cargo-show-asm is a working replacement
https://github.com/gnzlbg/cargo-asm/issues/244

thanks!


Updated getting started doc to include section for using existing resources.

Updated getting started doc
close #171

Decided not to merge


iOS build fail due to errors from win32 and ffi packages

I'm unable to build any iOS app that has win32 or ffi in the dependency tree using latest flutter master 1.27.0-9.0.pre.129.
Steps to Reproduce

Create Flutter project
add path_provider: 1.6.27 in pubspec.yaml or any package that  has win32 as a dependency.
import the package in main.dart:

import 'package:path_provider/path_provider.dart';

void main() {
  runApp(MyApp()); // counterApp
}

run the app.

Error
Launching lib/main.dart on iPhone 12 Pro Max in debug mode...
 lib/main.dart
Xcode build done.                                           11.6s
Failed to build iOS app
Error output from Xcode build:
↳
    ** BUILD FAILED **
Xcode's output:
↳
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:1111:7: Error: Struct 'ENUMLOGFONTEX' is empty. Empty structs are undefined behavior.
    class ENUMLOGFONTEX extends Struct {
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2835:7: Error: Struct 'BLUETOOTH_PIN_INFO' is empty. Empty structs are undefined behavior.
    class BLUETOOTH_PIN_INFO extends Struct {
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2960:7: Error: Struct 'EXCEPINFO' is empty. Empty structs are undefined behavior.
    class EXCEPINFO extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2966:7: Error: Struct 'PROPERTYKEY' is empty. Empty structs are undefined behavior.
    class PROPERTYKEY extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2973:7: Error: Struct 'PROPVARIANT' is empty. Empty structs are undefined behavior.
    class PROPVARIANT extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2978:7: Error: Struct 'SAFEARRAY' is empty. Empty structs are undefined behavior.
    class SAFEARRAY extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2985:7: Error: Struct 'CLSID' is empty. Empty structs are undefined behavior.
    class CLSID extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2992:7: Error: Struct 'STATSTG' is empty. Empty structs are undefined behavior.
    class STATSTG extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/win32-1.7.4+1/lib/src/structs.dart:2999:7: Error: Struct 'NLM_SIMULATED_PROFILE_INFO' is empty. Empty structs are undefined behavior.
    class NLM_SIMULATED_PROFILE_INFO extends Struct {}
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/ffi-0.1.3/lib/src/utf8.dart:23:7: Error: Struct 'Utf8' is empty. Empty structs are undefined behavior.
    class Utf8 extends Struct {
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/ffi-0.1.3/lib/src/utf16.dart:16:7: Error: Struct 'Utf16' is empty. Empty structs are undefined behavior.
    class Utf16 extends Struct {
          ^
    ../../.pub-cache/hosted/pub.dartlang.org/ffi-0.1.3/lib/src/allocation.dart:47:33: Error: Expected type 'T' to be a valid and instantiated subtype of 'NativeType'.
      final int totalSize = count * sizeOf<T>();
                                    ^
    Command PhaseScriptExecution failed with a nonzero exit code
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Constructing build description
Could not build the application for the simulator.
Error launching application on iPhone 12 Pro Max.
Exited (sigterm)

flutter doctor -v
[✓] Flutter (Channel master, 1.27.0-9.0.pre.129, on Mac OS X 10.15.6 19G2021 darwin-x64, locale en)
    • Flutter version 1.27.0-9.0.pre.129 at /Users/osaxma/fvm/versions/master
    • Framework revision fc77610dd6 (79 minutes ago), 2021-03-01 14:06:03 +0530
    • Engine revision 34236c9837
    • Dart version 2.13.0 (build 2.13.0-81.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/osaxma/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (2 available)
    • iPhone 12 Pro Max (mobile) • 5D894941-88ED-47BA-8FE0-0FA45101E676 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 88.0.4324.192

• No issues found!

Duplicate of #76705, the dependencies need to be rolled forward.

@dcharkes the dependency in question, path_provider is a flutter plugin and I'm using the latest version 1.6.27 from pub.dev ...  How am I suppose to roll it forward?

You can use https://pub.dev/packages/path_provider/versions/2.0.0.


chore: release 3.1.0

Codecov Report

Merging #216 (6955282) into develop (ccc61f8) will not change coverage.
Report is 7 commits behind head on develop.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff            @@
##           develop     #216   +/-   ##
========================================
  Coverage    19.53%   19.53%
========================================
  Files           15       15
  Lines         1065     1065
  Branches       373      373
========================================
  Hits           208      208
  Misses         834      834
  Partials        23       23

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Camera permissions on Android and IOS

In the sample project above Samsung, the camera can be turned on normally, but the camera screen will be stuck at SONY before the screen appears, IOS will ask the camera permission
But when I packaged the package and imported it into my project, the IOS camera permissions were not accessed.
Where can I make changes?

Project not supported anymore (Here)


Traces jaeger

Description
Adds support for raw jaeger schema data in trace analytics
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pretty Useful feature
Would love to know to more about what are the other roadmap features for trace data with this plugin

@vvvprabhakar we are still coming up with a roadmap for this feature set - the main one being service map support with spark jobs, but feel free to create issues for features you would like to see/prioritized, thanks!


Create geeks-nextjs-theme.md

Hello Team,
Geeks UI is the Academy and LMS courses based Next.js theme.
Thank you.

Hey @codescandy
Thanks for submitting this PR. you had some mistakes on it. So I manually added this theme to Statichunt. here is your theme https://statichunt.com/themes/nextjs-geeks


[W5.3b][W14-A2]Sim Kwan Tiong Damien

@Damienskt
Some comments added. Please ack & close the PR after reading comments.


Improve documentation

Make documentation more clear and easy to understand
Add/improve code examples
Make the Docs.md look better

Hi, can I work on this?

Yes, please feel free to work on this @aaishikasb

On it, in the meantime can you checkout #31 as well? Some amendments to the grammatical errors as well as a more readable approach.

@Pradyuman7 please check out #32 which resolves the issue.


Added support for translation helps article links navigation

Describe what your pull request addresses

[ ]

Test Instructions

[ ] Open https://deploy-preview-138--gateway-edit.netlify.app/
[ ] Navigate to mat 1:1
[ ] In the translationNotes card under the Annotation field  Matthew 1:17 should not be a clickable link
[ ] In the translationWords Article Card Bible references and OBS references should not be clickable. However, Translate Names, Christ, God, God the Father, high priest, kingdom of God, Mary, Savior, and Son of God should all be clickable links.
[ ] In the translationWords Article Card click kingdom of God, a new card should open. Then, click on the metonymy link and it should render the metonymy article in the same card.

This change is

LGTM


assetFileName invalid while use legacy plugin/使用legacy插件后rollup的assetFileNames设置失效

Describe the bug
while i write vite config' build module include
rollupOptions: {       output: {         chunkFileNames: 'static/js/[name]-[hash].js',         entryFileNames: 'static/js/[name]-[hash].js',         assetFileNames: 'static/[ext]/[name]-[hash].[ext]',         manualChunks(id) {           if (id.includes('node_modules')) {             return id.toString().split('node_modules/')[1].split('/')[0].toString();           }         }       }     }
my outdir file will bundle correct like
dist
-static
--css
--js
--png
and while use legacyPlugin as
legacyPlugin({       targets: ['chrome 52'],       additionalLegacyPolyfills: ['regenerator-runtime/runtime']     })
in config's plugin module in same time
my  outdir file wile bundle like
dist
-asset
***.png
***.legacy.js
-static
--css
--js
png filepath is not correct like css file and js file,
is this condition correct or i've just wirte wrong code in my file?
简单来说就是使用legacy插件之前,文件打包后的文件按照我的设置 js/css/png或其他格式的资源文件分别都在dist/static下的各自文件类型的文件夹里,使用legacy插件之后,png文件就直接进assets文件夹了,dist/static文件夹下不再有png的文件夹,css/js文件的文件夹还是正常的
Reproduction
https://github.com/shinjie1210/vite-config/settings
System Info
Node.js v14.18.1.
"vite": "^2.7.2"
"vue": "^3.2.25"
"@vitejs/plugin-legacy": "^1.7.1",
    "@vitejs/plugin-vue": "^2.0.0",

Used Package Manager
npm
Logs
npm i
npm run build
issue cause's key code is in vite.config.js with notes

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

请问你解决了嘛？我也遇到了这个问题

请问你解决了嘛？我也遇到了这个问题

i have search similar issue and  only in https://github.com/vitejs/vite/issues/4628  someone said he fix this with other plugin ,im waiting for his reply
you can reference https://github.com/vitejs/vite/pull/4352 and https://github.com/vitejs/vite/pull/2957  and if you find a way to resolve pls tell  me ,tks

请问你解决了嘛？我也遇到了这个问题
"vite": "^2.8.0"
"vue": "^3.2.25"
"@vitejs/plugin-legacy": "^1.7.1",
 "@vitejs/plugin-vue": "^2.2.0",

配置如下：  打包结果：

i need to know which broswer u need to compatible with , i may find a solution but i m not convenice to test  if it can
satisfy  your compatible requirement

请问你解决了嘛？我也遇到了这个问题
"vite": "^2.8.0"
"vue": "^3.2.25"
"@vitejs/plugin-legacy": "^1.7.1",
 "@vitejs/plugin-vue": "^2.2.0",

配置如下：  打包结果：

你应该是中文使用者吧,我的意思是你兼容的需求是什么 我好像找到个办法,但是不知道适用性如何 因为我只需要兼容 es.object.from-entries 来满足产品同事电脑上的chrome66,目前来看可以满足我的需求

Thank you for your kind reply in Chinese. My compatibility needs are similar to yours. I don't even need to be compatible with chrome 66. Can you share your solution? Thank you very much

Thank you for your kind reply in Chinese. My compatibility needs are similar to yours. I don't even need to be compatible with chrome 66. Can you share your solution? Thank you very much

try this,it fix my problem,i dont know wheather this can fix you problem, if this work pls let me know tks
modernPolyfills: ['the polyfill module you need'], //or  u can just  set  modernPolyfills:true,  true  to make it universal
renderLegacyChunks: false,

Yes, it also fix my problem,tks

I think I may have found another solution，line 4543 of the node_modules/vite.dist/chunks/dep-f9d9421a.js （Source file：https://github1s.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/asset.ts）
change  path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]')  to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
reason：
After using legacy plugin,this plugin will merge build.rollupOptions width his own ，The final output is always an array，as follows[   {     chunkFileNames: [Function (anonymous)],     entryFileNames: [Function (anonymous)],     assetFileNames: 'static/[ext]/[name]-[hash][extname]',     format: 'system'   },   {     chunkFileNames: 'static/js/[name]-[hash].js',     entryFileNames: 'static/js/[name]-[hash].js',     assetFileNames: 'static/[ext]/[name]-[hash][extname]'   } ] or
[   {     chunkFileNames: [Function (anonymous)],     entryFileNames: [Function (anonymous)],     assetFileNames: 'static/[ext]/[name]-[hash][extname]',     format: 'system'   },   {} ]
so  (output && !Array.isArray(output) ? output.assetFileNames : undefined) ??path.posix.join(config.build.assetsDir, '[name].[hash][extname]') will execute path.posix.join(config.build.assetsDir, '[name].[hash][extname]')，This causes the configured assetfilenames to become invalid.
I just did a simple test of this scheme, which seems to work well in my local area.`
Here are some of my test results：

use legacy and build.rollupOptions.ouput

only use legacy

only use build.rollupOptions.ouput

@shinjie1210
{
      build: {
        assetsDir: 'static/js',
        rollupOptions: {
          output: {
            chunkFileNames: 'static/js/[name]-[hash].js',
            entryFileNames: 'static/js/[name]-[hash].js',
            assetFileNames: 'static/[ext]/[name]-[hash].[ext]',
            manualChunks(id) {
              if (id.includes('node_modules')) {
                return id.toString().split('node_modules/')[1].split('/')[0].toString()
              }
            },
          },
        },
      },
    }

maybe helps😀

amazing，This should be the best solution， It makes us think of the problem as complicated。

@shinjie1210
{
      build: {
        assetsDir: 'static/js',
        rollupOptions: {
          output: {
            chunkFileNames: 'static/js/[name]-[hash].js',
            entryFileNames: 'static/js/[name]-[hash].js',
            assetFileNames: 'static/[ext]/[name]-[hash].[ext]',
            manualChunks(id) {
              if (id.includes('node_modules')) {
                return id.toString().split('node_modules/')[1].split('/')[0].toString()
              }
            },
          },
        },
      },
    }

maybe helps if you don't need renderLegacyChunks 😀

yeah i try this,that's a clever thoughts,tks

I think I may have found another solution，line 4543 of the node_modules/vite/dist/chunks/dep-f9d9421a.js （Source file：https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/asset.ts）
change path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]') to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
reason： After using legacy plugin,this plugin will merge build.rollupOptions width his own ，The final output is always an array，as follows[ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, { chunkFileNames: 'static/js/[name]-[hash].js', entryFileNames: 'static/js/[name]-[hash].js', assetFileNames: 'static/[ext]/[name]-[hash][extname]' } ] or [ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, {} ] so (output && !Array.isArray(output) ? output.assetFileNames : undefined) ??path.posix.join(config.build.assetsDir, '[name].[hash][extname]') will execute path.posix.join(config.build.assetsDir, '[name].[hash][extname]')，This causes the configured assetfilenames to become invalid. I just did a simple test of this scheme, which seems to work well in my local area.`
Here are some of my test results：

use legacy and build.rollupOptions.ouput

only use legacy

only use build.rollupOptions.ouput

yeah i think that's the reason cause our problem but i dont understand  your  solution in this comment like
change  path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]')  to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
can u tell me how to do?tks

I think I may have found another solution，line 4543 of the node_modules/vite/dist/chunks/dep-f9d9421a.js （Source file：https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/asset.ts）
change path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]') to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
reason： After using legacy plugin,this plugin will merge build.rollupOptions width his own ，The final output is always an array，as follows[ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, { chunkFileNames: 'static/js/[name]-[hash].js', entryFileNames: 'static/js/[name]-[hash].js', assetFileNames: 'static/[ext]/[name]-[hash][extname]' } ] or [ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, {} ] so (output && !Array.isArray(output) ? output.assetFileNames : undefined) ??path.posix.join(config.build.assetsDir, '[name].[hash][extname]') will execute path.posix.join(config.build.assetsDir, '[name].[hash][extname]')，This causes the configured assetfilenames to become invalid. I just did a simple test of this scheme, which seems to work well in my local area.`
Here are some of my test results：

use legacy and build.rollupOptions.ouput

only use legacy

only use build.rollupOptions.ouput

yeah i think that's the reason cause our problem but i dont understand your solution in this comment like
change path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]') to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
can u tell me how to do?tks

This line of code is in the build output directory function (filetobuilturl) specified by vite. Modify this line to vite.config..js
the 'static ' in front of the assetfilenames (static/[ext]/[name]-[hash].[ext]) configuration is extracted and used to replace the original default value of 'assets', which is similar to modifying vite config. JS assetsDir。I forgot that I could modify assetsdir directly, so it was complicated

I think I may have found another solution，line 4543 of the node_modules/vite/dist/chunks/dep-f9d9421a.js （Source file：https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/asset.ts）
change path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]') to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
reason： After using legacy plugin,this plugin will merge build.rollupOptions width his own ，The final output is always an array，as follows[ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, { chunkFileNames: 'static/js/[name]-[hash].js', entryFileNames: 'static/js/[name]-[hash].js', assetFileNames: 'static/[ext]/[name]-[hash][extname]' } ] or [ { chunkFileNames: [Function (anonymous)], entryFileNames: [Function (anonymous)], assetFileNames: 'static/[ext]/[name]-[hash][extname]', format: 'system' }, {} ] so (output && !Array.isArray(output) ? output.assetFileNames : undefined) ??path.posix.join(config.build.assetsDir, '[name].[hash][extname]') will execute path.posix.join(config.build.assetsDir, '[name].[hash][extname]')，This causes the configured assetfilenames to become invalid. I just did a simple test of this scheme, which seems to work well in my local area.`
Here are some of my test results：

use legacy and build.rollupOptions.ouput

only use legacy

only use build.rollupOptions.ouput

yeah i think that's the reason cause our problem but i dont understand your solution in this comment like
change path__default.posix.join(config.build.assetsDir, '[name].[hash][extname]') to path__default.posix.join(output[1]?.assetFileNames?.split('/')[0]||config.build.assetsDir, '[ext]/[name].[hash][extname]')
can u tell me how to do?tks

这一行代码是vite下面 asset.ts文件filetobuilturl函数中的，修改这一行代码的意图是将vite.config.js中assetfilenames前面的static提取出来，并用它作为输出目录，如果没有配置assetfilenames再使用原来代码中的默认值（assets），这样外面配置的assetfilenames就不会失效，类似于修改vite.config.js中的assetsDir。

that make sence , i finally understand this ,Thank you for your kind reply in Chinese

Closing as it is a duplicate of #4628


Fixes recompile issues with new monadic feature

The system will always work on the T and not GpuValue<T>. So for example when creating an IO box it will type it with T and not GpuValue<T>. Since that IO box is a T it can also connected to any other pin of type T - what one would've expected in the first place.
The same applies for the values stored in pins.
Note that these changes might break some patches saved yesterday. But I guess those pins/IO boxes will simply turn up red.

Please wait with the merge - there seems to be an issue I didn't catch yet

Ok, you can merge now. Will require https://teamcity.vvvv.org/buildConfiguration/vvvv_gamma_Build/34608


Unhandled exception when attempting to run the bot

I am trying to run the bot with Bizhawk 2.8, but it throws this exception:
************** Exception Text **************
System.MissingMethodException: Method not found: 'System.Nullable`1<UInt64> BizHawk.Client.EmuHawk.HexTextBox.ToU64()'.
   at GeneticAlgorithmBot.GeneticAlgorithmBot.get_MaximizeAddress()
   at GeneticAlgorithmBot.GeneticAlgorithmBot.get_MaximizeValue()
   at GeneticAlgorithmBot.GeneticAlgorithm.SetOrigin()
   at GeneticAlgorithmBot.GeneticAlgorithm.Initialize()
   at GeneticAlgorithmBot.GeneticAlgorithmBot.StartBot()
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Steps to reproduce:

Put the bot's DLL file in /ExternalTools/ folder.
Launch EmuHawk and load the ROM.
Open TAStudio
Go Tools->External Tool->Genetic Algorithm Bot
Press Yes
Create a savestate
Put in a RAM address to measure fitness
Make sure the slot number in the window is the same as the savestate/branch you want to load.
Make at least one button to above 0.0%.
Click "Run"

Then this exception appeared. I have restarted Bizhawk multiple times, but it still happens.
Also, since it may be relevant based on the exception, the RAM address in question is 0x000096.
Edit: I also get two other errors sometimes:
************** Exception Text **************
System.MissingMethodException: Method not found: 'Boolean BizHawk.Client.EmuHawk.IMainFormForTools.LoadQuickSave(Int32, Boolean)'.
   at GeneticAlgorithmBot.GeneticAlgorithmBot.StartBot()
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

And another one occurs when I rewind a frame while the botting window is open. It's just a generic message that says EmuHawk has thrown a fatal exception and is about to close. A movie has been detected. Would you like to try to save? (Note: Depending on what caused this error, this may or may not succeed.)
I also tried on BizHawk 2.9.

@unsightedmetal6
My bot doesn't support v2.8 due to an issue on the Hawk API that's fixed in the latest Bizhawk dev build. You will want to pull down the latest Bizhawk dev build and compile it. After that, go to the Releases section, and download the pre-release version v1.0.1 of the bot and install the bot into the latest Bizhawk build.

By the way, I updated the Readme file, so that you can watch how the Bizhawk Genetic Algorithm Bot Source Installation is done. I used Windows Sandbox because it's the best place to show how everything is installed from scratch.

That was the problem! I wasn't using the GitHub-cloned version of Bizhawk.
Thanks, the errors are fixed now.


Update of README.md

For editing the README.md I created the branch "docs/21-readme". All depending issues (#22, #23, #24, #25) should be executed there.
According to #21 I started to give a structure to the README. Feel free to contact me if you have some suggestions of improvement.

Definition of Done for README generally: README has all sections, written understandably, contain all already available content (short project description, section about all requirements)

#26 is partly solved with the last merge (except that the graphic is backed in and not adaptable)

All review requests were resolved and the final version was merged into the team2sprint2 branch. The PR can be found at #102.


[Bug] input_format_defaults_for_omitted_fields break down Distributed tables

This issue blocks #6043
Describe the bug
When input_format_defaults_for_omitted_fields is enabled Distributed tables doesn't work properly.
How to reproduce
Create cluster test_sharding with 2 shards
CREATE TABLE test_repl ON CLUSTER test_sharding
(
    `n` Int8
)
ENGINE ReplicatedMergeTree('/clickhouse/tables/{shard}/default/test', '{replica}')
ORDER BY n;

CREATE TABLE test_dist ON CLUSTER test_sharding AS default.test_repl
ENGINE = Distributed(test_sharding, default, test_repl, n)

SET input_format_defaults_for_omitted_fields = 1

INSERT INTO default.test_dist SELECT *
FROM system.numbers
LIMIT 100

Ok.

Looks like it's ok, but on second shard we have an error in log:

2019.07.18 15:10:53.988325 [ 47 ] {2a5eca6f-1262-41d6-b62b-6f3ff8bb8222}  executeQuery: Code: 210, e.displayText() = DB::NetException: I/O error: Broken pipe, while writing to socket (xxx.xxx.xxx.xx1:42784) (version <IP_ADDRESS> (official build)) (from xxx.xxx.xxx.xx1:42784) (in query: INSERT INTO default.test_repl (n) VALUES), Stack trace:
0. /usr/bin/clickhouse-server(StackTrace::StackTrace()+0x22) [0x781c272]

/usr/bin/clickhouse-server(DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, int)+0x22) [0x3a0a3e2]
/usr/bin/clickhouse-server() [0x389b830]
/usr/bin/clickhouse-server(DB::WriteBuffer::next()+0x29) [0x3a16d79]
/usr/bin/clickhouse-server(DB::TCPHandler::runImpl()+0x904) [0x3a15cf4]
/usr/bin/clickhouse-server(DB::TCPHandler::run()+0x2b) [0x3a1627b]
/usr/bin/clickhouse-server(Poco::Net::TCPServerConnection::start()+0xf) [0x725666f]
/usr/bin/clickhouse-server(Poco::Net::TCPServerDispatcher::run()+0xe9) [0x7256da9]
/usr/bin/clickhouse-server(Poco::PooledThread::run()+0x81) [0x7927e41]
/usr/bin/clickhouse-server(Poco::ThreadImpl::runnableEntry(void*)+0x38) [0x7924248]
/usr/bin/clickhouse-server() [0xb2ac5bf]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7f0bf96da6ba]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f0bf8f0341d]

2019.07.18 15:10:53.988614 [ 47 ] {2a5eca6f-1262-41d6-b62b-6f3ff8bb8222}  TCPHandler: Client has gone away.

Ok, let's try to select data from Distributed table:
SELECT count()
FROM default.test_dist

↗ Progress: 0.00 rows, 0.00 B (0.00 rows/s., 0.00 B/s.) Received exception from server (version 19.11.3):
Code: 102. DB::Exception: Received from localhost:9000. DB::NetException. DB::NetException: Unexpected packet from server xxx.xxx.xxx.xx2:9000 (expected TablesStatusResponse, got Data).

0 rows in set. Elapsed: 0.069 sec.

Your case is 'Replicated + Distributed + input_format_defaults_for_omitted_fields'. I've tried combination 'Replicated + Distributed + input_format_defaults_for_omitted_fields' and it looks working. It also interesting if you have 'internal_replication' set for your cluster configuration.
Could you get more details on the cluster configuration?

There's also a test that should check insertion in distributed (including distributed over replicated) and it OK with #6043
https://github.com/yandex/ClickHouse/blob/master/dbms/tests/integration/test_insert_into_distributed/test.py

I checked my cluster configuration and found that internal_replication is also enabled.
This error occurs only with Replicated engine with more than one shard.

@4ertus2 Did you reproduce this issue? Or you need some additional info?

There’s 50/50 probability that it works with commited #6043 without any modifications needed. It takes lots of time to deploy real distributed configuration. It would be great if you could test the issue with newer version with #6043 merged. Could you?

Looks like #6043 included in v<IP_ADDRESS>-prestable.
I will try to check by installing it.

Solved


Focus Zone, ArrowVertical does not take into account input elements that have step defined

For ArrowVertical does not take into account input elements of type "number" that have step defined, meaning it overrides the default behaviour making stepping with up and down key no longer working.
I think this can be fixable by adding some code to: https://github.com/primer/behaviors/blob/92e06b516eb3751bcf864c3678fd2722df885f4f/src/focus-zone.ts#L261

Hi!
Thanks for taking the time to report this, do you mind creating adding a reproduction of the issue on codesandbox.io or stackblitz.com?

Hi!
I hope this helps, since I don't have either
https://jsfiddle.net/2j6nr01x/

So to have stepping of the number input working again with up and down arrow key, remove FocusKeys.ArrowVertical

@camertron is going to take a quick look to see if we can validate this bug by looking at the test suite and we can go from there.

Hey @1951FDG, I'm not sure what you mean by "remove FocusKeys.ArrowVertical." However I think you were correct to identify shouldIgnoreFocusHandling as the place to make the change. Can you try adding the following code to the end of that function?
if (activeElement instanceof HTMLInputElement && activeElement.type === 'number') {
  return true
}

Hey @camertron, cool, I'll look into this as soon as I'm back next year, and maybe submit a pull request for it to be reviewed.

Hi all! 👋 Just wanted to check-in to see if this issue is still relevant and close it, if not 👀

Hi there, if I make the necessary changes, and submit a pull-request, will it be merged, or are these changes to be made on a per use case.

PRs are always welcome, provided there is a motivating use case and the code is clean and well tested 👍


KeepAlive not decoded

Dear Projectteam,
it seemed to me that A8000 KeepAlive messages were not properly decoded.
DecodeMessage seemed to be missing a return statement. Adding the following line fixed the problem:
diff --git a/src/Binary/Decode/DecodeMessage.cs b/src/Binary/Decode/DecodeMessage.cs
index 3592442..eead15f 100644
--- a/src/Binary/Decode/DecodeMessage.cs
+++ b/src/Binary/Decode/DecodeMessage.cs
@@ -323,6 +323,7 @@ namespace opc.ua.pubsub.dotnet.binary.Decode
                         {
                             Logger.Debug( keepAliveFrame.ToString() );
                         }
+                        return keepAliveFrame;
                     }
                     return dataFrame;
             }

Regards
Jan

Fixed with 1.0.26


support iterables

found out recently that yield* now delegates usingval[@@iterator](). thus, co() can actually support iterables.
https://blog.domenic.me/es6-iterators-generators-and-iterables/
i'm thinking of actual use-cases, but one i can think of is running an array in series:
co([
  fn1(),
  fn2(),
]).then()

we would have to:

check for @@iterator
check for .throw() before trying to execute it

@jonathanong I don't understand what you're suggesting here. Also it's val[Symbol.iterator] in case it matters.

me neither as i thought about it more :P


Not taking install media into account in disk selection

We need to exclude the disk we are installing from as a candidate for installations to be installed to.

Current fix only solves the Ventoy edge case.


add the tuf client to the verifier script

Add a go-tuf client to download the targets if the metadata has been published
Writes out the downloaded verified targets
Fixes up minor comment in the README.md

Signed-off-by: Asra Ali<EMAIL_ADDRESS>

would love re-approval for manual branch protection :)


Add color option for week badge

https://github.com/yi-Xu-0100/traffic-to-badge/releases/tag/v1.2.1


docs/cli: update martinvonz.github.io URLs to jj-vcs.github.io

We just migrated to the jj-vcs GitHub org, so we should point to the new GitHub pages.

Checklist
If applicable:

[ ] I have updated CHANGELOG.md
[ ] I have updated the documentation (README.md, docs/, demos/)
[ ] I have updated the config schema (cli/src/config-schema.json)
[ ] I have added tests to cover my changes

comment (non-blocking): It's weird that all these tests are failing 👀

I think it's cause the README file added to conflict commits changed, so all conflicted commits have a different hash now.

comment (non-blocking): You're no doubt aware, but the root URL https://jj-vcs.github.io produces a 404, which we should try to fix at some point.

I was not, but it makes sense that it fails. That's the user-/org-level GitHub Pages URL, so we'll need to set up a separate little repo for that (like https://github.com/martinvonz/martinvonz.github.io)


MNT: set MINIFORGE_HOME: C:\Miniforge

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #116.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed

Fixes #116

From @jaimergp:

Hey, we are optimizing the provisioning overheads on Windows (download Miniforge, install dependencies, etc), and we will change the default installation path from C:\Miniforge to D:\Miniforge. This will reduce the installation times significantly. We are submitting this PR here because this feedstock was redefining CONDA_BLD_PATH to the C: drive. In that case, we do not want to move Miniforge to C:; we want both paths to be in the same drive! This should not create new builds, just protect against the upcoming change in conda-smithy, once rerendered.
More information at https://github.com/conda-forge/conda-smithy/pull/2076

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Two weeks have passed to I'm merging this with [ci skip] to unblock https://github.com/conda-forge/conda-smithy/pull/2076. Thanks!


Have better UI to unlist all package versions at once

@rohit21agrawal commented on Wed Aug 10 2016
There should be a way to unlist all packages/package versions instead of having to go separately on each version and un-listing.

@rrelyea commented on Fri Aug 19 2016
Rohit had a support request for a customer that had many things to unlist.
We ended up helping him write a script, but our server UI should be enhanced to support this better.

@rohit21agrawal commented on Fri Aug 19 2016
Current workaround for doing this through a script :
Powershell :
$apiKey = "[fill in API key here]"

$packageList = @() # fill in package list array

# foreach package, get the project.json and get the versions foreach($package in $packageList) {
    $lower = $package.ToLowerInvariant();

    $json = Invoke-WebRequest -Uri "https://api.nuget.org/v3-flatcontainer/$lower/index.json" | ConvertFrom-Json

    foreach($version in $json.versions)
    {
      Write-Host "Unlisting $Package, Ver $version"
      nuget delete $package $version $apiKey -source https://api.nuget.org/v3/index.json
    }
}

Ruby : https://gist.github.com/haf/760ac442e309b94bd891656444ef5615

@aloneguid commented on Tue Mar 28 2017
@rohit21agrawal this is brilliant, thank you. A small modification to this and ready to use function for your profile:
function Remove-AllNuGetPackageVersions($PackageId, $ApiKey)
{
    $lower = $PackageId.ToLowerInvariant();

    $json = Invoke-WebRequest -Uri "https://api.nuget.org/v3-flatcontainer/$lower/index.json" | ConvertFrom-Json

    foreach($version in $json.versions)
    {
      Write-Host "Unlisting $PackageId, Ver $version"
      Invoke-Expression "nuget delete $PackageId $version $ApiKey -source https://api.nuget.org/v3/index.json -NonInteractive"
    }
}

@PatoBeltran commented on Thu Feb 22 2018
@joelverhagen can you take a look at this and see if this is still a relevant concern?

@rohit21agrawal commented on Thu Feb 22 2018
This should be moved to NuGet gallery

This is a duplicate of : https://github.com/NuGet/NuGetGallery/issues/367
The reason we don't have this UI is because V3 indexing pipeline is slow in handling updates to registrations with multiple versions, so it can cause delays for all users.


Ix Runcated Ostcode Rror

This isn't meant to be merged, I'm just making a draft PR to show what I've done

I ended up doing this in Postgres. The table I use is just ONSPD from 2016 loaded into the same DB as the leaflets DB.
I use two methods: one for matching on postcode,constituency_name and one for just matching on postcode. This is a result of trying the first and getting a load of misses. For the ones where I just match on postcode, there's only one option, so it's safe to assume that's correct and the constituency is wrong for some reason.
Of the postcodes that fall out (aren't matched): only 1 is ambiguous on postcode,constituency: EC1R 5HT/WC1R 5HT. They are right next to each other so I've decided to just pick the first one.
Of the others, I did some manual clean up:
G1- 1PB: Leaflet sent to Eastern region. Should be SG1 1PB
N1 0PD:  Leaflet This is just correct, somehow, no action needed
OX4 3SE Leaflet This is also correct
PE11 1AJ: Leaflet Correct
ST6 8LZ: Leaflet Correct
TA20 2HW: Leaflet Correct
Y5 3FH. Leaflet should be DY5 3FH
I've added the two chances to the dict manually.

To run this, I will read from the CSV file I've checked in and update the postcodes. I've done this locally (using the corrected map directly) and validated that it's doing the right thing.

I ran this on the server. We don't want this code to be checked in to the main branch, so I'll just close this. We can look back on these day fondly, in the future.


Add devtool integration #24

Tested with the case student lists and working fine (once we have redux navigation it will be even better but that's a separate case)
Proceeding to merge BUT  I won't remove this branch, can you keep on working onthis case and add redux hot loader support? Or should we place it in a different case?


Full Calculate not working but Real time is working fine

Full Calculate will not work but real time works fine.  Parent object is Lead, child object is task with WhoId as the relationship field
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to Manage Lookup Rollup Summaries
Choose Lead PYE Branded Promo/Life Event roll up
click on Full Calculate
There are 32 records that should update.

Expected behavior
The PYE Branded Promo/Life Event Gifts field on the Lead should update for all 32 records
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@kristencrane have you posted this issue in the Trailblazer Community? We direct support needs there so the wider community can assist.


reiannis should be relannis

@lukehollis per @ctschroeder email, reiannis is incorrect - it should be relannis.  I'm not sure if there are other places this needs to change -- these were the ones that popped out at me.

Looks great--thanks, @balmas!


Add selection support

There is a better implementation with behaviors. Selection is not a responsibility of the TreeView itself.
https://github.com/enisn/UraniumUI/pull/43


Remove Qt dependency

Qt is quite a big dependency for a command line arguments parser. This merge request implements custom parsing code, which removes the dependency on Qt. Hopefully, less dependencies make it easier to get started.

Probably this branch should be thoroughly tested as I may have missed some initialisation code.


cabana: display signal value in all charts on mouse hover

related discuss:  https://github.com/commaai/openpilot/discussions/26091#discussioncomment-5477990

rebased


Bug : Issues on Components > Identity Resource Basic, Information, Invoice, Login Attempt, Notification Settings, Payment Details

PR merged


electron-forge does not work with npm workspaces (npm v7)

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version: 6.0.0-beta.57

Electron Version: 13.1.0

Operating System: macOS 11.4

Last Known Working Electron Forge version:: N/A

Expected Behavior

Running electron-forge start from project root (npm run start --workspace="packages/electron-app") or from electron workspace root (cd packages/electron-app && npm run start) should be able to locate the electron executable in the project root node_modules.
Actual Behavior

Running electron-forge start throws a PackageNotFoundError:
An unhandled rejection has occurred inside Forge:
PackageNotFoundError: Cannot find the package "electron". Perhaps you need to run "yarn install" in "<path-to-project-root>/packages/electron-app"?

To Reproduce

Minimal repro example: https://github.com/brightbrained/electron-forge-workspaces
Make sure to have npm v7 or above for workspaces support (npm install --global npm@latest)
git clone https://github.com/brightbrained/electron-forge-workspaces.git
cd electron-forge-workspaces
npm install
npm run start --workspace="packages/electron"

Additional Information
<!--
Add any other context about the problem here.

For example:
* Console output when you run your `electron-forge` command with the environment variable
  `DEBUG=electron-forge:*`. (Instructions on how to do so
  [here](https://www.npmjs.com/package/debug#usage)). Please include the stack trace if
  one exists.
* Command line arguments you are passing to `electron-forge` (e.g.,
  `electron-forge make --not-a-real-flag`)
* The `config.forge` data in `package.json` or `forge.config.js` in use
* A failing minimal testcase (with a link to the code) or detailed steps to reproduce the problem.
  Using `electron-forge init` is a good starting point, if that is not the source of your problem.

This relates to an old issue: https://github.com/electron-userland/electron-forge/issues/869
But the fix only accounts for yarn workspaces...

I am running into exactly the same issue. Surprisingly electron-forge make works fine as long as you define
resolve: { 		modules: [path.resolve(__dirname, "../../node_modules"), "node_modules"], 	},
in webpack.main.config.js

I was having this problem but fixed it by deleting a package-lock.json file in the electron subdirectory, allowing it to climb back to the root node_modules and find the electron package.

If you read this and use NPM workspaces, you probably wonder why this issue is closed since it still doesn't work.
Electron Forge won't link properly the monorepo root node_modules directory during package and make operations, so you have to do it yourself.
Edit your forge.config.js file like this:
const fs = require('fs');
const path = require('path');
const { version } = require('./package.json');

module.exports = {
    // existing config here, then,
    hooks: {
        packageAfterCopy: async (forgeConfig, buildPath) => {
            fs.symlinkSync(path.join(require.resolve('electron'), '../..'), path.join(buildPath, 'node_modules') , 'dir');
        },
    },
};

Good luck 😅.
@malept This issue should be reopened.

Here's a working app using NPM workspaces: https://github.com/jeanbmar/black-moon-rewind/tree/r0.1-beta/packages/launcher
In order to get Forge working til the end, I had to write my own dependency resolver (np-bundle) and call it in Forge hooks because electron-packager won't resolve monorepo deps.

Here's a working app using NPM workspaces: https://github.com/jeanbmar/black-moon-rewind/tree/r0.1-beta/packages/launcher In order to get Forge working til the end, I had to write my own dependency resolver (np-bundle) and call it in Forge hooks because electron-packager won't resolve monorepo deps.

I also had to set packagerConfig: { prune: false } in my forge config file, but then your bundler worked. Thank you very much!

Thank you @robin-hartmann. To give full credit to its author, my package is a modified version of https://github.com/npm/cli/pull/4082. Your code looks great, you might to share some feedback in the npm PR :).

Based on @jeanbmar's resolver I now built my own one, which you can find in this gist. It is quite a bit shorter (and hopefully easier to understand), includes types and correctly skips all non-prod dependencies.

Thank you for the link. findRoot returns an object with rootDir, that's the only change I made so far that seems to make it work.

Hi should we re-open this, or is there an issue on electron-packager for npm workspaces support? The current landscape seems quite dire unfortunately. I've taken the gist above and have added support for workspace packages also being copied over into node modules instead of being copied directly in the src folder. I can post it if folks would like. I could also publish it as a package if folks would be interested.
I've been on a rollercoaster trying to get electron forge and its dependencies working, moving away from pnpm + workspaces to npm + workspaces and then needing the above fix... really just wanted this all to work out of the box 🥲.

Truth is neither NPM or Electron cares about packaging monorepo.
This pull request has been open for 1.5 year at NPM, and everyone involved just "ghosted" it.
Forge support for workspaces consists in letting NPM workspaces find Electron in the node_modules and completely ignores the fact that workspaces can't be packaged 🙃.
PNPM is probably the safe bet here.

For what it's worth, we've been using electron-forge with Yarn 3, and it works well 🙂  (You do need to set nodeLinker: node-modules, so that Yarn creates the node_modules folder instead of using Yarn PnP)

What do you do about electron packager and copying node modules over? Or you aren't using workspaces?

Our app is a React app. Our repo is structured like this:
app\
web\
src\

app\ is for electron, web\ is for compiling/running the app in a browser, and src\ is code that's shared between the two.

  }
}

Still seeing issues on npm 8.11.0 with workspaces

I'm a bit late but i have found a solution you can use npm link electron inside your electron app package directory and it'll install electron locally in this package

electron-forge DOES support npm workspaces, judging by its code (their is upwards traversal to monorepo root).
In my case, I had a faulty package-lock.json in my packages/sub-package causing electron-forge to assume that's the root. npm workspaces should only ever have a top-level package-lock.json so this was an error on my end and happened when bootstrapping the project via boilerplate repos.

You should delete lock files in your packages according to source code:
the folder exist a lock file will be treated as the electron module root.

I also had this happen to me using yarn workspaces.
The solution was to delete the yarn.lock from the directory where you have electron installed. In my case it was rm desktop/yarn.lock (as suggested above).

Here's a working app using NPM workspaces: https://github.com/jeanbmar/black-moon-rewind/tree/r0.1-beta/packages/launcher In order to get Forge working til the end, I had to write my own dependency resolver (np-bundle) and call it in Forge hooks because electron-packager won't resolve monorepo deps.

I come back to my previous comment, webpack-typescript setup was not much better. This solution worked for a while until I got the following error
An unhandled rejection has occurred inside Forge:
RangeError: Maximum call stack size exceeded
at ...path-to-workspace/apps/electron-app/bundler.js:52:14
    at Array.flatMap (<anonymous>)
    at collectProdDeps (...path-to-workspace/apps/electron-app/bundler.js:52:6)
    at ...path-to-workspace/apps/electron-app/bundler.js:52:40
    at Array.flatMap (<anonymous>)
    at collectProdDeps (...path-to-workspace/apps/electron-app/bundler.js:52:6)
    at ...path-to-workspace/apps/electron-app/bundler.js:52:40
    at Array.flatMap (<anonymous>)
    at collectProdDeps (...path-to-workspace/apps/electron-app/bundler.js:52:6)
    at ...path-to-workspace/apps/electron-app/bundler.js:52:40
    at Array.flatMap (<anonymous>)
    at collectProdDeps (...path-to-workspace/apps/electron-app/bundler.js:52:6)
    at ...path-to-workspace/apps/electron-app/bundler.js:52:40
    at Array.flatMap (<anonymous>)
    at collectProdDeps (...path-to-workspace/apps/electron-app/bundler.js:52:6)
    at ...path-to-workspace/apps/electron-app/bundler.js:52:40

I solved this by updating the collectProdDeps to
/** @type {(node: Node) => Node[]} */
const collectProdDeps = (node) => {
  const stack = [node];
  const result = new Set();  // Using a set to avoid duplicates and track visited nodes

  while (stack.length > 0) {
    const currentNode = stack.pop();
    const depEdges = [...currentNode.edgesOut.values()].filter((depEdge) => depEdge.type === "prod");

    for (const depEdge of depEdges) {
      const depNode = resolveLink(depEdge.to);

      if (!result.has(depNode)) {
        result.add(depNode);
        stack.push(depNode);
      }
    }
  }

  return Array.from(result);  // Convert the set to an array
};

Which seems to bundle the app properly.
Can't wait for electron-forge to "just" support this.


💡 Feature Request - Swap Extension suggestion

Maybe change the advisory at this line
https://github.com/Azure/ALZ-Bicep/blob/a6db5effd9c08c721e877c1a3988c37c9a580a7a/docs/wiki/Contributing.md?plain=1#L56
To the built-in option:
Inside User Settings:
Editor › Bracket Pair Colorization: Enabled
or
Inside User Settings (JSON):
"editor.bracketPairColorization.enabled": true
This prevents another extension to be installed, native stuff tends to work usually 🤓
Also maybe looke at ms-azure-devops.azure-pipelines as an advisory :) ?

Thanks @Manbearpiet this is a great suggestion. Forgot to update this from when we originally created the contribution guide.
We'll get this updated 👍

Hehe I'll put in some more PR's, kinda new to the whole GitHub contribution stuff hehe.

Thanks. If you want to submit a PR for this, please feel free to update the doc in the docs/wiki folder and we will review.
Let me know, if not we will put on our backlog for sorting 👍

Added the PR, I hope this is fine like this @jtracey93 😁

Awesome thanks @Manbearpiet reviewed your PR and looks great, just waiting for checks to complete before merging it