Difference from tf.depth_to_space

Hi,
Was amazed by this great idea compared to conv2_transpose. Looking at tensorflow documentation I found tf.depth_to_space, which seems to do something similar (at least the non-color version), am I mistaken? What's the difference? What's the reason you did not use this op?

@midddle I'm planning on using depth_to_space in keras. Which is the same. check this out https://github.com/twairball/keras-subpixel-conv

According to my experiment, the phase shift implementation is different from tf.depth_to_space, Following is my Experiment, I'm using Tensorflow 1.6.0:
Experiment
Code
import numpy as np
import tensorflow as tf

def _phase_shift(I, r):
    bsize, a, b, c = I.get_shape().as_list()
    bsize = tf.shape(I)[0]  # Handling Dimension(None) type for undefined batch dim
    X = tf.reshape(I, (bsize, a, b, r, r))
    X = tf.transpose(X, (0, 1, 2, 4, 3))  # bsize, a, b, 1, 1
    X = tf.split(axis=1,num_or_size_splits=a, value=X)  # a, [bsize, b, r, r]
    X = tf.concat(axis=2, values=[tf.squeeze(x, axis=1) for x in X])  # bsize, b, a*r, r
    X = tf.split(axis=1, num_or_size_splits=b, value=X)  # b, [bsize, a*r, r]
    X = tf.concat(axis=2, values=[tf.squeeze(x, axis=1) for x in X])  # bsize, a*r, b*r
    return tf.reshape(X, (bsize, a * r, b * r, 1))

def PS(X, r, color=False):
    if color:
        Xc = tf.split(axis=3, num_or_size_splits=3, value=X)
        X = tf.concat(axis=3, values=[_phase_shift(x, r) for x in Xc])
    else:
        X = _phase_shift(X, r)
    return X

init = []
for x in range(0, 9):
    init.append(x)

a = np.array(init, dtype=int)
a = a.reshape((1, 1, 1, 9))

tensor = tf.constant(a)

b = PS(tensor, 3, color=False)
c = tf.depth_to_space(tensor, 3)

sess = tf.Session()
result, result_1 = sess.run([b, c])

print(result)
print(result_1)

sess.close()

Input
a: [[[[0 1 2 3 4 5 6 7 8]]]]
Output
result:
[[[[0]
[3]
[6]]
[[1]
[4]
[7]]
[[2]
[5]
[8]]]]
result_1:
[[[[0]
[1]
[2]]
[[3]
[4]
[5]]
[[6]
[7]
[8]]]]
For the implementation of phase shift, I use the code in #47. So probably I make some mistakes or they are just not same?

@chaos5958 My problem is, the phase shift implementation produce different output from tf.depth_to_space one when provided the same input.

Hey @chaos5958 , even I am trying to use tf.depth_to_space in TFlite. Did you find any solution or alternative?

@purva98 No, instead, I'm using Qualcomm SNPE which supports tranpsose conv layer.


--cupy-no-cuda does not work

I tried to install chainer with --cupy-no-cuda, but cupy was installed. This option doesn't work.

--cupy-no-cuda option is not for disabling to install CuPy but for install CuPy to non-CUDA environment. So this behavior does not contradict to we suppose.

OK, it's confusing. This option is for read-the-docs. Use simpler name, such as --for-rtd. This option is not for users.

BTW, we need to make a method to disable cupy. Of course splitting repositories is enough.

We need two information (i) this option is for RTD environment and (ii) what this option is doing (i.e. to install CuPy to non-CUDA environment). Currently we have the latter only.
One of the possible change is to change the option name so that it reflect (i) (like --for-rtd) and add description about (ii). The other alternative is vice versa. Both are OK for me.

Do you have urgent need for installation without cupy? If not, I think we can defer it until CuPy is separated from Chainer.

How about --force-install-cupy?

@unnonouno Is this problem solved after CuPy separation?


E-mail notifications are in the language of the editor, not the receiver

In a multilingual team some users may be on different languages. But now an email notification gets sent in the language of the user that edits the task and sent to a user in a different language.

It's now fixed in the last development version.
Thanks to report this issue.


Release v0.26.0

New feature to use protoc 3.7.1 for Java client generation, and ability to set language-specific versions of protoc

PTAL


Include full request/response in tracing

Oftentimes is very usefull to have the http requests and responses for understanding misbehaviours. Also, use System.Net trace listener and remove redundant traces.

Done in 02419cfea2a3b923bb9efd3621a73246c70e128d


Fix image path

Anyone here?

Hello?

Hello Camilonova,
Sorry for the late reply. Thanks for sending a pull request. We will review the code shortly.

@KennethAshley is just one line to fix a pain when trying to collect my static assets.

@camilonova It is one line but there are several other things we have to take into consideration.

@KennethAshley can you tell what else is needed to have this merged?

I'm just taking a look at it now, and maybe one of the other collaborators will disagree with me on this one, but I don't foresee us merging this commit as is. This change was to the generated css owl.video.css file, not the source owl.video.scss file, and more importantly, this change would break this icon for any user that is already using the video carousel functionality.
Perhaps something that could be merged would be creating a owl.variables.scss file with variables like $image-path: './'. The end user (you, in this case) could then import the various scss files into their project and also import an overrides file that would contain a line like $image-path: '../' and gain the configurability you are looking for.
I'm closing this pull request for now, but if this additional variables file is something you'd like to take a swing at, let me know and I'll re-open.


common: misnamed common.framerate.fixed cvar is about frametime

common: misnamed common.framerate.fixed cvar is about frametime

Also common.framerate.fixed is likely to not be about renderer frametime/framerate like common.framerate.max so common.framerate.fixed may still not be good enough as a name.

common.frametime is probably not going to be a whole category, so maybe just common.fixedFrameTime ?

Rewritten as suggested.


Sound support of variable graphs

There are more and more applications in GNN. In training, people demand model to be trained on distinct graphs. Variable graphs are needed to customize their training process.
So far, I implement the FeaturedGraph to equip graph structure on features, so one can input feature with a graph. However, it is experimentally implemented to support GCNConv. To support all layers, there are more work to do.

First, thank you for your work on GeometricFlux.jl 😃
Are you currently working on that issue?
If not, could I try implemeting some other layers?
Finally, is the FeaturedGraph struct going to last? Should we use MetaGraphs.jl instead or is it better to keep that structure? (as discussed in https://github.com/yuehhua/GeometricFlux.jl/issues/6)

I am welcome and happy to receive contributions from others.
I will maintain FeaturedGraph in the mainstream. As for the MetaGraph support, I will keep the conversion to FeaturedGraph available.
If one wants to design new layer, please take FeaturedGraph as first choice.

Actually, it seems #36 does not fully add the supports for FeaturedGraph/GCNConv. I'd say it is the same for #44.
Indeed, trying to compute the gradient with a featured graph seems to throw an error. I'll investigate more and start a draft PR about this.

FeaturedGraph is supported by graph net and message passing scheme in #63

Hi, thank you for the awesome package! Im curious how the GCNConv layer incorporates edge features from the FeaturedGraph type? And what structure the the edge features should take, i.e. can the features for each edge be greater than 1 dim?

@tdfalc Thank you for your question. Would you please open another issue for this? I will give you a reply in that issue.


harfbuzz-icu: 1.8.1 -> 1.8.2

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/harfbuzz-icu/versions.
meta.description for harfbuzz-icu is: '"An OpenType text shaping engine"'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.8.2 with grep in /nix/store/yhfk721zjr37na7n262a6501rsgv34fv-harfbuzz-icu-1.8.2

directory tree listing: https://gist.github.com/8ac3eb5ad15149a59b6d4b9d8c19af67

du listing: https://gist.github.com/1ea9efd90c226b0686b7ea0b30f3979b

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 4488d3deb3226a2883ee85fb748ceeb7fc852006 && nix-shell --pure -I nixpkgs=. -p harfbuzz-icu

cc @edolstra for testing.

Success on x86_64-linux (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
checking for references to /tmp/nix-build-harfbuzz-icu-1.8.2.drv-0 in /nix/store/yhfk721zjr37na7n262a6501rsgv34fv-harfbuzz-icu-1.8.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev
shrinking /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/bin/hb-ot-shape-closure
shrinking /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/bin/hb-subset
shrinking /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/bin/hb-view
shrinking /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/bin/hb-shape
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/lib  /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev/bin
patching script interpreter paths in /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev
checking for references to /tmp/nix-build-harfbuzz-icu-1.8.2.drv-0 in /nix/store/8hizsv57ybl9i8aky6pb9wa39z6bxgys-harfbuzz-icu-1.8.2-dev...

Success on x86_64-darwin (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
Patching '/nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev/lib/pkgconfig/harfbuzz-icu.pc' includedir to output /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev
Patching '/nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev/lib/pkgconfig/harfbuzz-subset.pc' includedir to output /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev
Patching '/nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev/lib/pkgconfig/harfbuzz.pc' includedir to output /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/xypk8pv0r3mywncic8qpdai6zrw48hq4-harfbuzz-icu-1.8.2/lib
patching script interpreter paths in /nix/store/xypk8pv0r3mywncic8qpdai6zrw48hq4-harfbuzz-icu-1.8.2
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev/lib  /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev/bin
patching script interpreter paths in /nix/store/w2jv0xnjj0ahybawpapkcbhfnx4vhggy-harfbuzz-icu-1.8.2-dev
/nix/store/xypk8pv0r3mywncic8qpdai6zrw48hq4-harfbuzz-icu-1.8.2

Success on aarch64-linux (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev
shrinking /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/bin/hb-ot-shape-closure
shrinking /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/bin/hb-subset
shrinking /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/bin/hb-shape
shrinking /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/bin/hb-view
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/lib  /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev/bin
patching script interpreter paths in /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev
checking for references to /build in /nix/store/j3kdk59qzvj4pwbx11m2qrn548s3j6vk-harfbuzz-icu-1.8.2-dev...
/nix/store/y265y1w56ncl51mhpdl1qidi0caw9zys-harfbuzz-icu-1.8.2

Success on x86_64-linux (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
checking for references to /build in /nix/store/kbk3v09h3vbxq3lb6v89pc0ss1mbjkxy-harfbuzz-icu-1.8.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev
shrinking /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/bin/hb-shape
shrinking /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/bin/hb-subset
shrinking /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/bin/hb-view
shrinking /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/bin/hb-ot-shape-closure
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/lib  /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev/bin
patching script interpreter paths in /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev
checking for references to /build in /nix/store/3wszh6qnxfw8sn6j9pxwhz1hc4v78mb9-harfbuzz-icu-1.8.2-dev...

Failure on x86_64-darwin (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
cannot build derivation '/nix/store/70knk0q8z60c87arj5xna3m522cim7al-apple-framework-ImageIO.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/9mxx2xb10gd9nl0gscpwqcf660734k1w-apple-framework-ApplicationServices.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jpi6cg1yx34n5d9bi0j2cwhjf53aawch-apple-framework-CoreVideo.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/by14bd44mcnlzs1dqm6mzyvdy2c4a639-apple-framework-Foundation.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/0zxmrwg66zv6vzn7dk8ai6ynkq13zdc9-apple-framework-QuartzCore.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/slsv6a3xpgynsyjp88iddj6kn9i4mb9v-apple-framework-Carbon.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/v4idfv0kyf5dccsvxsnsl3z81cfi126d-cairo-1.15.12.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/f7ip5pzcgl8gviw6k9gg2a8l9gb05np8-harfbuzz-1.8.2.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/f4d1s7yaj3x55bp7xxw2w7xa2r7y7vs3-harfbuzz-icu-1.8.2.drv': 10 dependencies couldn't be built
error: build of '/nix/store/f4d1s7yaj3x55bp7xxw2w7xa2r7y7vs3-harfbuzz-icu-1.8.2.drv' failed

Success on aarch64-linux (full log)
Attempted: harfbuzz-icu
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev
shrinking /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/bin/hb-ot-shape-closure
shrinking /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/bin/hb-subset
shrinking /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/bin/hb-shape
shrinking /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/bin/hb-view
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/lib  /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev/bin
patching script interpreter paths in /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev
checking for references to /build in /nix/store/a5ac8qr1x6gdjp6c8f6fcjczzk495scm-harfbuzz-icu-1.8.2-dev...
/nix/store/zch21s148zb4388msl8r01hczdgpx4kv-harfbuzz-icu-1.8.2


Adding ibmq_16_melbourne to the devices' public names list

Summary
As reported in #33, the action/button to get IBMQ devices status fails since the release last Friday (2018/09/21) of the chip 'IBM Q 16 Melbourne'. This PR fixes that issue by including the new chip in the list of public devices.
Details and comments

i think you need to think about a method to automate this as some will go online and others offline over time.

Sure @jaygambetta. We would like to change this part of the code to automate it ASAP. Thanks for the suggestion


The mod's items, and the lit furnace, show as solid purple.

Here is a screenshot https://imgur.com/a/4DerzgC

Please provide some information about your environment. A list of installed mods and a full debug.log file ought to be sufficient.


⚠ Bofrost.de has degraded performance

In 038a4ed, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1494 ms

Resolved: Bofrost.de performance has improved in 8faf953 after 13 minutes.


Update Turkish translation for NPC Map Locations

Untranslated part translated.

Thanks for the help! Merged into develop for the upcoming NPC Map Locations 2.11.1.


chore(508): Change responsive colors to be 508 compliant (AA)

It looks like a few .ext~ files or, squiglets as I've just named them got added in. We should try to add this to the .gitignore somehow.

It looks like Reminders were added to the sidebar in this commit as well, we should make a separate feat commit for this so that it gets added to the changelog.

Yikes .. I may also be able to change my text editor to not save backups .ext~

@bhalt It might be a good idea for us just to add *~ to all of our .gitignore files for our project too though. Others might have the same issue and that would prevent it.

I just rebased this PR against the latest master and removed the ~ temp files. Hopefully everything still looks as expected.

:+1:

:+1:


Solution to Longest Consecutive Sequence

Thanks @shivanshu-0 for your first contribution towards submitting the solution to Checkpoint problem Level 6. :)


[vcpkg-tool-meson] vcpkg-tool-meson tool is too old

Library name
vcpkg-tool-meson
New version number
1.2
Other information that may be useful (release notes, etc...)
No response

I mistook the repository

#28084


resolution modifier - fix minimum height, refactoring

Fixed bug in Resolution Modifier
Description
When user did not set height parameter, it is calculated from document.body.scrollHeight. Sometimes it returns 0 and this hangs test (until timeout)
Motivation and Context
Issue 384
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Thank you!
Please update changelog ;)

Changelog updated!

Changelog updated

Changelog updated

Changelog updated


Request: Stable Version

Releasing a stable version by tagging would be helpful, since I am automating the download and installation of the REST API.

This makes sense. I plan to clean some of the pending issues, plus merge some PR improvements I have before making a stable release.

https://github.com/vmware/burp-rest-api/releases


ideas

support local document search https://github.com/matthoffner/web-llm-embed
support multi models such as llama2
save prompt
agent support https://github.com/idosal/AgentLLM

Thank you for your suggestion. I appreciate your idea to expand the capabilities of the project. However, I currently do not have plans to further develop the project, as I don't see practical application scenarios for this project. If you have any more ideas or questions, feel free to share them. Once again, thank you for your input!


Implementation "manage worksheet data"

Please implement "manage worksheet data"  (https://developers.google.com/google-apps/spreadsheets/data) in this library. There is no need to additionally include https://github.com/asimlqt/php-google-spreadsheet-client library to deal with such natural needed feature.
Please, you really make my life easier this way (i guess not only my), especially that this additional/external library doesn't work for me, i,ve got Fatal error: Uncaught exception 'Google\Spreadsheet\UnauthorizedException' with message 'Access token is invalid' (i have Drive API enabled), instead that there is no problem with tokens when i'm using google-api-php-client
library to other available operations

This issue may no longer be relevant due to its age. Feel free to re-open.


Only send installed event after user consents

Not required according to neither the Chrome nor the Firefox privacy policies.


Crash if token_secret_signature_key returns empty string

The problem happened with a fork of knock which I was using for a long time: https://github.com/JonaMX/knock.
It worked well until I decided to upgrade to the newer fork of knock - this repository. I noticed that previous tokens stopped work and I started to dig.
It turned out, that in that fork, the author replaced to self.token_secret_signature_key = -> { Rails.application.credentials.read }, which returns an empty string "" for my Rails 5.2.
So I have been running the application for years with no secret signature key. Of course, it's my responsibility.
What I suggest is to add a check somewhere in the code so other potential users couldn't shoot in the foot again. Something like
raise "Knock secret signature key can't be empty" if Knock.token_secret_signature_key.call.blank?

Similar to #212
There's an open PR that we started a discussion about it: #225
Feel free to contribute there, with suggestions or opening a new PR considering the points raised there...
Thanks!


NPM @next Version Out of Date

The @next version of this project is out of date. Currently listing RC 11, not RC12.
I noticed this as I was installed via @vue/test-utils@next when it installed RC 11 and it's related TypeScript issues.

Oops - I will update the tag today.

Done.


Support for horizontal boundary conditions

With this PR we can now apply boundary conditions on x and y.
I still need to add tests and benchmark performance (nothing should change).
One discussion point: Should we even add support for x boundary conditions seeing as we only support Periodic boundary conditions in the x direction?

One discussion point: Should we even add support for x boundary conditions seeing as we only support Periodic boundary conditions in the x direction?

Probably not, since its best not to have code with no functionality, I think. It's probably actually a good thing that we'd have to reinternalize this functionality in the future (because it means we have to re-review the code) to implement the x boundary conditions.

What about a box, though. That would be useful. Gyres etc. John
On Tue, Oct 15, 2019, 4:39 PM Gregory L. Wagner<EMAIL_ADDRESS>wrote:

One discussion point: Should we even add support for x boundary conditions
seeing as we only support Periodic boundary conditions in the x direction?
Probably not, since its best not to have code with no functionality, I
think. It's probably actually a good thing that we'd have to reinternalize
this functionality in the future (because it means we have to re-review the
code) to implement the x boundary conditions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/climate-machine/Oceananigans.jl/pull/475?email_source=notifications&email_token=AKXUEQTHHZZFKI44NUNM6BTQOXI3HA5CNFSM4JAUTQRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJAM3A#issuecomment-542246508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKXUEQWYH3BVUXBC5DC4IPTQOXI3HANCNFSM4JAUTQRA
.

Only comment is that we went with "north, south, east, west" in naming the halo regions functions --- it might make sense to change the name of the apply_ functions to apply_y_north_bc (rather than apply_y_right_bc --- etc for all boundaries --- to match this convention.

That makes sense. Should be an easy change.

Probably not, since its best not to have code with no functionality, I think.

Good point. I'll remove the x functions. Less code, less bugs!

What about a box, though. That would be useful. Gyres etc. John

We'd have to use a 3D discrete cosine transform for the pressure solve. That wouldn't be too hard to implement on the CPU as FFTW can do that out of the box.
But on the GPU, we'd have to code that up ourselves as cuFFT does not do cosine transforms... I was able to implement efficient 1D and 2D cosine transforms on the GPU based on existing literature, but not sure if it's worth implementing a potentially complicated 3D cosine transform unless we need to simulate boxes.

What about a box, though. That would be useful. Gyres etc. John

To do boxes we need a Poisson solver first (the hard part).

But on the GPU, we'd have to code that up ourselves as cuFFT does not do cosine transforms... I was able to implement efficient 1D and 2D cosine transforms on the GPU based on existing literature, but not sure if it's worth implementing a potentially complicated 3D cosine transform unless we need to simulate boxes.

We should use the same method on the CPU and GPU that permutes the dimensions of the array. We should not use different solvers on CPU and GPU. Let's not continue this problem as we add more Poisson solvers.

We should use the same method on the CPU and GPU that permutes the dimensions of the array.

The problem is that we can do something more efficient on the CPU with FFTW's cosine transforms (I haven't benchmarked the permutating DCT algorithm on the  CPU, although it's probably safe to assume that FFTW is faster).
We may be able to switch to a a wholly more efficient pressure solver that solves tridiagonal systems in the vertical with PR #306 so then we can get rid of the permutation algorithm for doubly periodic configurations and have fewer Poisson solvers.

This got a little too messy when I did a git merge master as we reversed the k index and added arbitrary tracers since this PR was opened.
I will close this PR and re-implement horizontal boundary conditions in a future PR that will include tests as well.


Importing ABCs directly from collections deprecated in Python 3.7, stopped working in 3.8

When I run some tests with pytest and callee 0.3, this is printed at the end:
============================== warnings summary ===============================
c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:74
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:74: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Iterable

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:116
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:116: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Sequence

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:128
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:128: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Set

c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:246
  c:\users\rnd10\appdata\local\programs\python\python37-32\lib\site-packages\callee\collections.py:246: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    CLASS = collections.Mapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
======================= 78 passed, 4 warnings in 1.38s ========================

Pytest version info:
platform win32 -- Python 3.7.3, pytest-5.1.0, py-1.8.0, pluggy-0.12.0
plugins: cov-2.7.1, ordering-0.6, pycharm-0.6.0

Solution suggestions: https://stackoverflow.com/questions/53978542/how-to-use-collections-abc-from-both-python-3-8-and-python-2-7

Just noticed there is already a fix and pull request for this: https://github.com/Xion/callee/pull/10

As mentioned above, this is fixed with PR #10.


Compatibility with typescript

Currently, this package is not compatible with typescript. Is there a plan to release the typescript version?

Is there a plan to release the typescript version?

No, not for now, maybe in the future. Are you experiencing issues when you are using it in a TypeScript project?
Which issue are you facing?

Yes, I am having typescript problems.

As far as I know, this is just a warning and your code using allSupportedLocales should work.
If you know a way to remove this warning from VS Code without having to translate the project to TypeScript, tell me and I will do it (maybe the .d.ts file mentioned in the warning could be a solution, but I do not know what it means).

It is actually not a warning, it is breaking my application.

OK. Will check this on a sample TypeScript project and let you know.

It works here on this codesandbox (even though there is still the annoying warning).
What do you mean by breaking my application?  Does the TypeScript compiler compiles the project and you get a runtime error, or what?
I will also try to use moment-utl in a React TypeScript template project.
Meanwhile, if you find a way to inhibit the warning, that would be useful.

I am using TypeScript compiler to compile my project. I used this article to create a workaround

I am using TypeScript compiler to compile my project. I used this article to create a workaround

OK, but which type of issue are you facing? Is it a compile issue or runtime? Can you post a screenshot? Thank you!

Compilation issue, the error message is the same as the one I sent earlier

OK, will try to reproduce it.

Hello @Annmary12!
I have reproduced your issue in a local TypeScript project.
I have added an index.d.ts file in version 2.13.1.
Can you try updating to this version with npm update or yarn update (if you are using Yarn), remove the workaround you added and see if your project builds?
My local test builds and if I Cmd+click on a function of moment-utl VS Code sends me to the index.d.ts file to the definition of that function.
Let me know if it works for you too so I will close this issue.
Thanks!

I tried it out and it works. Thanks for fixing it.

You're welcome. Closing this.


Use a better audio codec as fallback

Currently, MP3 is used as fallback if lossless audio transfer fails.
MP3 is a very outdated format and is inefficient. It was directly superseded by AAC and nowadays there are royalty-free codecs like Vorbis and Opus, both of which give better quality-per-bitrate than MP3.
I propose to use Opus instead, replacing -c:a mp3 with -c:a libopus -b:a 256k which should result in a drastically higher audio quality.

I checked the code and noticed that it's better to use AAC for compatibility reasons, as AAC can be used in MP4, MKV and others, while Opus doesn't work in MP4 containers.

I checked the code and noticed that it's better to use AAC for compatibility reasons, as AAC can be used in MP4, MKV and others, while Opus doesn't work in MP4 containers.

Made a PR.
https://github.com/hzwer/arXiv2020-RIFE/pull/90

Made a PR.
https://github.com/hzwer/arXiv2020-RIFE/pull/90

Thanks for merging.
Closing.

Thanks for merging.
Closing.


chore(main): release 1.3.2

:robot: I have created a release beep boop
1.3.2 (2024-04-30)
Bug Fixes

_build/html (49985ce)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/chiba-ai-med/PyTorchDecomp/releases/tag/v1.3.2 :sunflower:


CPT <IP_ADDRESS> seems to have triggered a regression for issue #1180

Installed update 9.5.0 today and performed a comparision of results from the previous 9.4.0 and have discovered that the issue #1180 seems to have returned.
For example even though the check clang-analyzer-deadcode.DeadStores is disabled, when running 9.5.0 on a project this is once again showing clang-analyzer-deadcode.DeadStores checks to appear in the results pane.

Hi @netx123,
Thank you for reporting this issue
After investigating more, I found out that this bug was present in v9.4.2 too
I am working on a fix
Have a nice day,
Marina

I tried your example, and for me works
Can you try with a predefined check on, and after with all predefined checks off? This problem is still reproducing?
If you disable all predefined checks, you will see this error:
Error: no checks enabled.
USAGE: clang-tidy.exe [options] <source0> [... <sourceN>]
OPTIONS:
Generic Options:
  --help                         - Display available options (--help-hidden for more)
  --version                      - Display the version of this program
clang-tidy options:
  --checks=<string>              -
  . . .

Make sure to Export Tidy file config (if Detect .clang-tidy file is active)
Setting -> Tidy -> Export Tidy file config

Hi @mariru27 , I've tested again with all predefined checks off, and I still have the same issue.
I am testing this on an entire project (around 30 files)
Looking through the output window I do see several "Error: no checks enabled."
"USAGE: clang-tidy.exe" messages, which are probably from each running thread, however I suspect that some threads in the new parallel execution mode are having issues accessing the .clang-tidy config file due to a conflict, as I also see the folllowing in the output window:
The process cannot access the file 'F:\ourTestProject.clang-tidy' because it is being
used by another process.
Cannot create a file when that file already exists.
+ CategoryInfo          : WriteError: (F:....clang-tidy:String) [Rename-Item], IOException
+ FullyQualifiedErrorId : RenameItemIOError,Microsoft.PowerShell.Commands.RenameItemCommand
+ PSComputerName        : localhost
Cannot find path 'F:\ourTestProject.clang-tidy' because it does not exist.
After this point in the output I start seeing clang tidy reporting results for checks when it shouldn't be.

You are right @netx123, parallel execution is causing this problem.
Thank you for helping me to find out the problem
I am working on a fix
Have a nice day,
Marina

Hi @netx123,
We are working on a fix, in the meantime, you can use our previous version of Clang Power Tools v9.4.2
Best regards,
Marina

Hi @netx123,
We made a release with a fix for this bug
Try Clang Power Tools v9.5.1 and tell us if the problem is still reproducing
Thank you for your cooperation
Have a nice day,
Marina

Hi @mariru27,
Wow, thank you for fixing this so quickly,
I’ve tested and it’s working great now, really fast too!
Thanks again.


Add an option to subscribe to every Hold Invoice at once

Background
There is no easy way to get Hold Invoice events with one rpc subscription. You have to track them individually, and whenever you start tracking a bunch of them, it doesn't make sense keeping so many rpc subscriptions open, when you could just subscribe once and get all the events there (Just like it happens with regular invoices). This could be a problem for any service that could want to provide Hold Invoices as a solution for their users, and needed to track lots of them at once.
Your environment

Lnd 0.6.1
(Any environment or setup)

Steps to reproduce

Subscribe to subscribeInvoices

You will start getting standard events for invoices (even for hold invoices), such as OPEN and SETTLE, but not those advanced events used on Hold specific ones, such as ACCEPT or CANCEL.

You could then try subscribing to SubscribeSingleInvoice using the Sub-Server Invoices, but you should do that for each of the Hold invoices you are tracking.

Problem
Whenever you are tracking a bunch of hold invoices, doesn't make sense to subscribe to each of them individually.
Possible solutions

One option could be including an advanced SubscribeInvoices on the invoicesrpc Sub-Server, that gets every STATE change for every invoice. I'm not sure if it's possible to filter it to get Hold-Invoices-only here, but if it's not, then could be used as an advanced replacement of the regular SubscribeInvoices we already have.

Other option might be including Hold Invoice events on the regular subscribeInvoices rpc call. To avoid the hassle of receiving too many updates, it could be an optional parameter whenever you subscribe, set to false by default.

I'm not sure how this works under the hood, but I guess that maybe you would be getting all the state events for every invoice, not just for hold ones, and that's why you haven't included it as an option yet. If that's the case, and is not possible to filter out invoices by its kind before firing the events, then at least would be great to have a "get all the states for every invoice" as an advanced option (whether option 1 or option 2)
Of course, would be great to have a subscribeHoldInvoices on the sub-server invoices, that gets every STATE event, but for hold invoices only

Can't this be emulated with the existing calls by making individual subscriptions for each open invoice you know of? Depending on your language, you can likely combine all those streams into one (say using something like a python generator that takes other generators and yields them all).

I guess they could probably be combined, and for a small amount of them it would be probably fine (using Node.js). However, if you have a few hundred open hold invoices, I can imagine things would get messy; specially if you lose connection at any point and have to reconnect every stream for every (still) open invoice; I mean, it's doable, but much easier with a single subscription, just like happens with regular Invoices.
I also understand it is not a common case for regular wallets, but will probably be for any LN service using Hold invoices (That's why it could maybe be added to the Sub Server invoices as an advanced version, leaving the regular subscribeInvoices as it is)

On 27 May 2019, at 21:57, Olaoluwa Osuntokun<EMAIL_ADDRESS>wrote:
Can't this be emulated with the existing calls by making individual subscriptions for each open invoice you know of? Depending on your language, you can likely combine all those streams into one (say using something like a python generator that takes other generators and yields them all).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I think that a variation on Subscribe(All)Invoices that sends out updates for every event is the way to go. Not only are the Accepted and Canceled events currently not sent, but the stream also does not include updates to the invoice htlc list that don't necessarily change the invoice state. Especially for multi-part receives, it may be useful to get some insight in how the total set is coming together.
One question is how to signal to SubscribeInvoices what the starting point is from which backlogged events need to be sent. Currently there is add_index and settle_index, but with the increased state space it may be better to introduce something new. Either an always increasing global update counter (goes up for every commit to the invoice db) or alternatively a timestamp. Most data in the invoice db already includes a timestamp, so that could possibly be implemented without a db migration. A timestamp also has more meaning than just a counter value.
Feedback on these kind of design aspects and/or other ideas are welcome.

@alexbosworth @ryanthegentry this features would really be helpful for us

@carlaKC Are you still working on this? I could write a PR if you want.

A workaround is to subscribe to all invoices and then individually subscribe to the invoices where you want hold state updates

A workaround is to subscribe to all invoices and then individually subscribe to the invoices where you want hold state updates

this doesn't work for our use case:
we have one pod creating the invoices, and another pod that is listening to their settlement. we really want to have the second pod listening to invoice settlement continuously without having to pass message around between pods.

There should be no need for message passing since an event is triggered for all subscriptions when invoices are created

so,
pod1 "invoice-listeners" start, run subcribeToInvoices
pod2 "invoice-creator" start, run periodically "invoiceCreate`
pod1 will receive event even for invoice created after subcribeToInvoices has started?

Yes exactly that should just work because subscribing to invoices means getting an event on any new invoice

ok, I thought this was only for already existing invoices. this could work then.
do you know if there could be issues listening to 10k+ invoices?

I don't think there would be any issue from the LND perspective, although you can of course cancel the single invoice subscription after it's settled or expired/canceled so I would use that to minimize overall subscriptions

@carlaKC Are you still working on this? I could write a PR if you want.

@ErikEk I'm not currently working on this, would be very happy to review a PR though!

Been playing around with different solutions here. If we would consider adding partial payment notifications, et al @joostjager, I guess we have to send the full invoice everytime, but with the latest htlc list. It seems bloated but I can't come up with any way around it.
I like the idea of adding a timestamp parameter to specify which invoices to return from the subscription.

@ErikEk @Roasbeef any update on this?

bumping this up. this is why it's a significant issue on our end:

we are using hodl invoice because we want to some logic before settling an invoice
it takes multiple minutes to loop through all invoices to register to back to them after a server restart (our server talking to lnd, not necessarily restarting lnd)
we heavily rely on CD, and put to prod new code 5+ times per day
every time our servers restarts, we have to loop through all those invoices again
during this "restart time", invoice will not be settled as the htlc arrives, which translate to a bad user experience for our users
in a way, the more we push code, the more negative the user experience for our user is

having a single subscription for all invoices would solve this issue

Hi, we're aware of the need here, thanks for that additional anecdote. We have a large project to overhaul the invoice system at the data storage level which sort of blocks this, as we'd want to ensure we can give back filled notifications as normal. Any review+testing of those PRs (#6288) is appreciated.
After fixing some bugs in this area earlier this year, I spun out this issue that outlines a number of issues with the internals of the current notification system and potential ways to address them: https://github.com/lightningnetwork/lnd/issues/8023

Any update on the progress of this one?

@AndySchroder no change yet. With the native SQL backend for invoices complete however, we're now in position to easily implement this feature, but only for the native SQL backend.

Is the SQL back end going to require more setup from the user, or does it "just work"?

Is the SQL back end going to require more setup from the user, or does it "just work"?

For sqlite, it'll "just work", as it's an embedded database. For postgres, it'll require a bit more work, as the user also needs to run a database management server. There are hosted solutions that make things easier, like Amazon RDS as an example: https://aws.amazon.com/rds/postgresql/ .

Hi folks, taking this over as part of the hodlinvoice overhaul,
I wonder if we need to keep this backwards compatibility here, otherwise there will be no way to introduce a new RPC cmd:
https://github.com/lightningnetwork/lnd/blob/8ac184a91105d3e6c877b830e37de46c211127f8/invoices/invoiceregistry.go#L318-L321

Regarding the partial payment notification, I would first introduce this only for single invoice subscriptions, otherwise the return stream can become pretty bloated as mentioned by @ErikEk


[Feature] discount / subscription and one time / Settings of the subscriptions for the customer in the frontend

Describe the new feature

Give the customer an option to buy the item normally or as a subscription
To give a discount to different groups of customers
To receive the discount only on the first order
Leave the configuration of the recurring payment to the customer

Describe the solution to be implemented
Backend changes

Frontend changes

Hi There @in-session ,
Thank you for opening this issue. Your first point, buying the item normally or as a subscription, is already possible by enabling “Allow One Time purchase for product”.
For your other suggestions I appreciate your detailed suggestions and taking the time to contribute to our project. After careful consideration, we’ve determined that these feature requests are beyond the current scope and complexity of the plugin for now. We appreciate your understanding and encourage you to continue sharing your ideas with us in the future!


lava-docs: add controls section

Add a section to describe controls and how to customize them.

I do not agree with changing "SAST - IaC" with IaC because IaC (Infrastructure as Code) doesn't explain what kind of analysis the tool is performing. The definition of IaC is "the ability to provision and support your computing infrastructure using code instead of manual processes and settings" and is not a security control itself.


Removes "impatient" profile

The profile was also using the devcloud.cfg configuration, which won't be part of Cosmic.

Ping @borisroman @miguelaferreira @bheuvel

LGTM :+1:
Unused profile.


job and executor deployment

What is the best practice about the job and executor deployment? If several peoples develop many jobs, they have to deploy every job's jar to each executor node, right？ and every job jar updated, each executor has to be restarted? And it should be very easy to encounter version conflict when so many jobs and their dependencies loads together by one JVM.
And if we deploy executor as docker container, there should be a way to tell CI what jobs should be built into executor images.
Is there a better way?

executor主要分成了2个classloader：业务classloader和saturn classloader。前者主要是加载作业类和作业依赖（例如jar），后者是放置saturn本身类及依赖。回到你的问题，作业都是共享同一classloader，所以最佳实践是作业是在同一个project，多个作业类，依赖的jar都是共享。
关于docker那个问题，选择build哪个业务类进镜像，都是由开发者的打包脚本决定，saturn本身没有提供这种功能。


disaster recovery of etcd cluster

Hi guys,
In current exsiting etcd operator implemtation, when we use k8s to deploy etcd cluster and etcd cluster lost quorum, the operator does nothing to recover it.
https://github.com/tkestack/kstone/blob/master/third_party/etcd-operator/pkg/cluster/reconcile.go#L95-L97
Do you have any plan to recover the "lost quorum" etcd cluster?
Thanks,

We didn't use etcd-operator, we used the built-in kstone-etcd-operator.It has more complete support for persistent storage and better disaster tolerance. In the next version, we will support rebuilding lost-quorum clusters using snapshots, and kstone-dashboard will also support visualization operations.

Hi tangcong, thanks for your reply.
Based on the official wiki:
https://etcd.io/docs/v3.5/op-guide/runtime-configuration/# restart-cluster-from-majority-failure
When we use a dynamic way to deploy Etcd clusters(That's how it works in K8s), it appears that the only way to rebuild a lost-quorum cluster is to take a snapshot. The problem of snapshots is that if we use a snapshot to recover, we'll definitely lose some data(after the snapshot is taken, some new update are write to etcd, then k8s cluster is down).
If use the static way to build a etcd cluster, I can simply restart all nodes to rebuild the etcd cluster without using snapshot, do you have some ideas about how to achive it if we use dynamic way?

We support storing data on persistent data disks. If it is not persistent, we can also force a snapshot from the healthy node to rebuild the cluster, so that the probability of losing data is very small.  @rayliu419

@tangcong ,
"We support storing data on persistent data disks. If it is not persistent"
I think most of k8s users will use PVC/PV as external storage, so that's not a problem. The problem is even if you have persistent data disks, you can't restore the cluster with these persistent data disks just as static way.
"we can also force a snapshot from the healthy node to rebuild the cluster, so that the probability of losing data is very small."
Yes, we can force the health node to dump snapshot, but here are two problems:

Since etcd cluster continue to accept write all the time, you can't snapshot all writes, right?
In some cases, such as k8s is down, you don't have a healthy node.

Actually, I don't know why etcd community doesn't have a solution to recover it without using snapshot(maybe they have, but I don't find it). In cloudnative enviorment, it's a critical case.

I think I find a way to recover the data without losing data. Etcd supports --force-new-cluster to reconfigure the cluster, we can find the latest node in the etcd cluster to restart the cluster. If more than half pvc survive, we can recover it in this way.

Yes, I submitted an issue #https://github.com/tkestack/kstone-etcd-operator/issues/2 at the time, and the plan was implemented in this way. thank you.


More documention about when a task can clone vs re-run on resume

If I have a flow defined with steps

Foo
Bar
Baz

And I have a run where "Baz" fails...
And I explicitly resume my run at Baz...
...I want to know what causes Foo or Bar to rerun vs Clone, so I can re-write my code to not cause a re-run.
The current documentation says
https://docs.metaflow.org/metaflow/debugging#resuming-from-an-arbitrary-step

By default, resume resumes from the step that failed, like b above. Sometimes fixing the failed step requires re-execution of some steps that precede it.

That is pretty vague, so the user is left guessing.

Metaflow will always clone all the steps preceding the failed step by default and execute the failed step. If you type python flow.py resume, it will clone foo and bar and execute baz always.
You can override that behavior and re-execute from an arbitrary preceding step by following the instructions - https://docs.metaflow.org/metaflow/debugging#resuming-from-an-arbitrary-step.  If you type python flow.py resume bar, it will clone foo and then execute bar always.
Let me know if this answers your question.

I think the confusion was that when metaflow chooses a default run to resume, it wasn't choosing the run that was furthest through the graph.

run (5 steps in)
.... debug....
resume (3 more steps in)
...
resume (expected metaflow to to resume from the prior resume run)

Currently, metaflow resume resumes the last run. If you resume multiple times in succession (for example), you would notice that it resumes the same run id. You can override that behavior by specifying --origin-run-id

@matt-land Please comment and re-open the issue if you have any more concerns around this.


Icons Page Not Responsive

Describe the bug
The Icons are not responsive in a way that, We are not able to Copy the Tag of the respective Icon.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
See error...

Expected behavior
All the Pages should be responsive and at any dimension , we are able to copy the tag of the desired icons
Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

OS: Windows
Browser& amp; Version [e.g. Chrome 71.0.3578.98(64-bit)]
Website Version v3.4.0
Additional context
Add any other context about the problem here.

May I know in what case you need to copy tags in such a small window? Why not use a larger window directly?


Correct pronoun usage in Omnibus install instructions

Summary
FQDN and email are requested from the end-user installing Omnibus, not from Mattermost.
When read by the end-user, "us" refers to Mattermost, the owner of the help document. The installer does not request the FQDN "from Mattermost", it requests it from the end-user.
Ticket Link
N/A

Hello @jomaxro,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thanks, @jomaxro! Great catch. I've added @mgdelacroix for a dev review but it looks good on my side. :)


Model parameters

How to calculate the model parameters (3.8M) in the paper? I can't get this result by using thop.

I also use thop library to calculate the model parameters. For our R-MSFM6 model, the model parameters are 3815044.

Could you share the calculation code?
I got the results with:
input size: 1, 3, 192, 640
encoder = networks.ResnetEncoder(18, False)
depth_decoder = R_MSFM3()
total FLOPs =<PHONE_NUMBER>2
total Prameters = 14525804
depth_decoder = R_MSFM6()
total FLOPs =<PHONE_NUMBER>2 FLOPs
total Prameters = 14821484

Sorry, I use sum([param.nelement() for param in model.parameters()])), and get total Prameters = 14821484

If you use this method above, the parameters of the last two layers of resnet will be included. Indeed, you should use the following method:
from thop import profile
flops, params = profile(model, inputs=(input, )

Thanks a lot.


Map location in charge details

Describe the bug
Following the most recent update (I assume), going into the charge details does not show the location of the charge. The map just loads to an overview of the entire map. Zooming into the location does not have a dot like it used to either.
However, the location still shows in the table of charges
To Reproduce

Load up Grafana
Load up the Charge dashboard
Click on any Charge
View map on selected Charge via the Charge Details dashboard

Expected behavior
A dot should be located on the map via the location obtained via the API during the charging session.
Screenshots

Operating environment (please complete the following information):

OS: [Raspberry Pi Rasbian]
TeslaMate [v1.12]

Following your steps 1-4 above, I see an error in the top left of both the charge details windows and the map window: pq: syntax error at or near ",".   No data in either window.
I also note the car drop-down selector shows "2,1,3" instead of the three car names.  At this point, I can select in the drop down the vehicle whose charge I picked and then the data displays.  No dot in the map.  Until I zoom out the time range.  Dot appears when cursor is over left graph.
If I select any other vehicle there is no data (as expected) until I zoom out.  Dot is present, everything normal.
Synology; Teslamate 1.12.1

I also tried to reproduce the bug. For me it always zooms to the correct location, but the dot itself is absent.
That said, I'm not entirely sure when this started to happen though. Because I haven't been looking for the dot itself as I've always seen the map zoom in  - which for me is the most important part.

I also tried to reproduce the bug. For me it always zooms to the correct location, but the dot itself is absent.

That said, I'm not entirely sure when this started to happen though. Because I haven't been looking for the dot itself as I've always seen the map zoom in  - which for me is the most important part.

Looks like the event is not updating sometimes. For eg. some specific charge displays details with proper scaling and translating the lat-long. However, some not. Double clicking on the charge graph on the left zooms in on the right location. @spacecosmos, If you move the cursor over the charge graph(left side), then the point will appear.

@spacecosmos, If you move the cursor over the charge graph(left side), then the point will appear.

@vkarthikbalaji - Yes, I found that out now, I kind of just forgot that I used to do it before. Anyways, I'm also fairly sure that the dot was there constantly before. But I could be mistaken of course. :)

@spacecosmos like you, I cannot recall specifically if it was supposed to always be present or only showed when you moused over the charge graph. However, since I feel like your car is never moving during the charge session (unless there is something I do not know), it seems like it would make sense for the dot to be persistent. Maybe this is not a bug, but a feature enhancement if it previously took you mousing over the charge graph to have the dot show.

I'm pretty sure that the blue dot has never been displayed unless one is hovering over the graph. My hands are tied here: the maps plugin (https://github.com/pR0Ps/grafana-trackmap-panel) does not offer more customization options.
As for your main issue, @cwanja: Is the location not present for all or only few charges? Is it displayed when you zoom out?

So, I took another look and I actually do have a small red dot there. This is consistent with what I thought I had for a long time. I have no clue why it comes and goes though...

PS! I'm not hovering or clicking over the graph itself.
Installation type:
v1.12.2
Docker running on Ubuntu (DigitalOcean)

This red dot came up with v1.12.2 in response to this thread :)

@adriankumpf if I recall, it was not there for any of the five or six charges that I sampled. And these were sampled over the last month or two. I saw nothing when I zoomed in or out of the location on the map.
I will check again when I get home prior to updating to V1.12.2.

A few things:

historically, the dot would not show until you moused over the graph. However the map was zoomed into the location on the map where the dot basically would be centered. This might be because I have a geofence setup, but cannot confirm as I have only ever charged at home 🤷🏽♂ (sorry)
somewhere between 10/17 and 10/20 (two dates I charged), the map stopped zooming in to the location where the charge took place.

Updating to V1.12.2 now.

Seems like the same issues persists through V1.12.2. Although my little Pi is struggling.


bug: heliaInstance.libp2p.addEventListener('peer:discovery', cb) calls cb twice for same peer

Peer discovery should only emit once, unless we are in fact discovering the peer twice via different methods somehow.
Either way, once a peer is discovered, we should cancel any in-progress operations and emit that we discovered the peer only once.
While working on a new helia-script-tag example (via #43), I was able to get the following event log:
1263ms - Created LibP2P instance
1263ms - Created Helia instance
2248ms - Discovered peer QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN
2252ms - Discovered peer QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN
2252ms - Discovered peer QmQCU2EcMqAqQPR2i9bChDtGNJchTbq5TbXJJ16u19uLTa
2252ms - Discovered peer QmQCU2EcMqAqQPR2i9bChDtGNJchTbq5TbXJJ16u19uLTa
2253ms - Discovered peer QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb
2254ms - Discovered peer QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb
2254ms - Discovered peer QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt
2254ms - Discovered peer QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt
74326ms - Connected to QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb
77805ms - Connected to QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt
135298ms - Disconnected from QmbLHAnMoJPWSCR5Zhtx6BHJX9KiKNN6tpvbUcqanj75Nb
138782ms - Disconnected from QmcZf59bWwK5XFi76CZX8cbJ4BhTzzA3gU1ZjYZcYW3dwt

Completely agree, but please can you open an issue on libp2p/js-libp2p for this.


Question - what is the difference between bigtable-client-core and google-cloud-bigtable?

I'm confused - I have seen two clients in the maven, so far I used the bigtable-client-core and it worked fine. Recently I noticed google-cloud-bigtable. I was wondering which one google recommend for CRUD operations on Bigtable?
https://mvnrepository.com/artifact/com.google.cloud.bigtable/bigtable-client-core/1.12.1
https://mvnrepository.com/artifact/com.google.cloud/google-cloud-bigtable/1.8.0

bigtable-client-core is a core module to wrap the HBase interface over Bigtable operations. It is scheduled to be deprecated soon.
Going forward I would recommend you to use google-cloud-bigtable. It provides a user-friendly interface for settings as well as data & admin client. Besides CURD operation it also exposes other advance options(Callables, Batcher, etc.) to integrate with your applications.

Thanks, @rahulKQL


Body Recog/Tracking

https://github.com/Its-Triggy/Joint_Track/blob/master/jointTrack.py
Found this (apparently ineficient) code to perform body tracking. It seems it uses a system of joints and branches and recognizes the body as such

Do you think that method will be fast enough, I mean not leave the showing of images very slow?

No idea. The code itself runs quite well alone.. Im not sure if it would do the same when implemented together with what we have already. We can try it :)

Okay seems like a good next step for now.

Forgot to add: this holistic model to track the body moving requires to install mediapipe via pip : !pip install mediapip (! may or may not be necessary)

I found a good method of recognizing bodies that works very well and I was able to implement it replacing the Haar Cascade. I based my code on this repository https://github.com/Kazuhito00/Person-Detection-using-RaspberryPi-CPU/blob/main/README_EN.md.


fixing unreachable exception handling

If condition at line 174 in DefinitionFile won't ever be reached, since whenever match expression at line 170 would throw an UnhandledMatchError whenever it doesn't match true. Fixing that.

I run into this issue while dealing with another bug: the artisan command seems to fail when trying to parse method and args for Illuminate/Routing/ViewController.php, which kinda makes sense I guess. Issue is that it's trying to process a vendor route, at docs/api. Not sure why though (yet).

@Carnicero90 the second issue you've reported was fixed here: #4

$ php -v
PHP 8.2.7 (cli) (built: Jun  7 2023 10:25:38) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.7, Copyright (c) Zend Technologies
with Zend OPcache v8.2.7, Copyright (c), by Zend Technologies
$ php artisan openapi:generator api --output=storage/openapi.yaml
OpenApi specification will be generated in storage/openapi.yaml
Generating OpenApi specification...
Error
Class "PHPStan\PhpDocParser\Lexer\Lexer" not found
at vendor\hypnodev\openapi-generator\src\DefinitionFile.php:456
452▕
453▕     private function parseQueryFromMethodDocComment(string $doc, array &$parameters): void
454▕     {
455▕         // Create necessary parser instances
➜ 456▕         $lexer = new Lexer();
457▕         $constExprParser = new ConstExprParser();
458▕         $phpDocParser = new PhpDocParser(
459▕             new TypeParser($constExprParser),
460▕             $constExprParser
1   vendor\hypnodev\openapi-generator\src\DefinitionFile.php:149
Hypnodev\OpenapiGenerator\DefinitionFile::parseQueryFromMethodDocComment("/**
* logout
*
* @param  mixed $request
* @return void
*/")
2   vendor\hypnodev\openapi-generator\src\DefinitionFile.php:119
Hypnodev\OpenapiGenerator\DefinitionFile::createParameters(Object(ReflectionMethod))

@donejeh you should open an issue for this specific topic. In the meantime, I guess you could fix it via composer require --dev phpstan/phpdoc-parser


fix generate network config

这个 PR 实现什么功能/修复什么问题:
RT
是否需要 backport 到之前的 release 分支:
NONE
/cc @zexi
/area host

Codecov Report

Merging #4432 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4432      +/-   ##
=========================================
+ Coverage    6.84%   6.85%   +<.01%
=========================================
  Files         521     521
  Lines       88416   88417       +1
=========================================
+ Hits         6050    6057       +7
+ Misses      81861   81854       -7
- Partials      505     506       +1

Flag
Coverage Δ

#aFlag
6.85% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/cloudcommon/db/standalone.go
0.88% <0%> (ø)
:arrow_up:

pkg/cloudcommon/db/modelbase.go
1.46% <0%> (+0.01%)
:arrow_up:

pkg/cloudcommon/db/metadata.go
11.23% <0%> (+2.45%)
:arrow_up:

pkg/cloudcommon/db/statusstandalone.go
4.87% <0%> (+4.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e20b2...b556da8. Read the comment docs.


Enable setting up version from .uv-version file

The uv project changes dynamically, so keeping both local and CI version of uv might be challenging. In order to keep both versions consistent, I would suggest to enable pinning them in a "version" file.
For example, this can be achieved by adding an extra input variable:
name: uv

on:
  pull_request:
    branches:
      - main
  push:
    branches:
      - main

jobs:
  uv:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: astral-sh/setup-uv@v4
        with:
          enable-cache: true
          version-file: .uv-version  # <- this is the idea of this issue
      - uses: actions/setup-python@v5
        with:
          python-version-file: .python-version
      - run: uv lock --locked

The file could be also auto-detected if neither version nor version-file is explicitly stated.

Thank you for opening this issue. Can you please add context on how this would work locally? This seams to me like this is a feature request for uv itself to detect this file and automatically upgrade/downgrade itself depending on the content?


Deleted torrents still show up

If you delete a torrent, it still shows up on the torrent listings and my torrents page.
For example:
https://nyaa.pantsu.cat/search?c=_&userID=0&q=	[Golumpa]+Koro+Sensei+Quest!+-+01+[FuniDub+1080p+x264+AAC]
The top result was deleted just after uploading however it still comes up and it takes you to a 404 page.

Not sure if this is a thing, I don't do ES.
https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-delete.html


Add a label indicating what kind of user it is in Secret

Closes #2631
superuser and  default are used in the cnpg.io/user-role label.

Do you think this PR could be in the next release ?

Any idea when this PR can be integrated in a future release ?

Let's wait for E2E tests

/ok-to-merge tests failed due to a bug introduced in #5898


Mythril raises a KeyError for a contract

Description
Mythril raises a KeyError when run with contract 0x8601e58163C2713B06b40a2000A30FF4A988e926

How to Reproduce
$ myth -xila 0x8601e58163C2713B06b40a2000A30FF4A988e926
Traceback (most recent call last):
  File "./myth", line 9, in <module>
    mythril.interfaces.cli.main()
  File "/home/nikhil/MYTHRIL/mythril/mythril/interfaces/cli.py", line 397, in main
    max_transaction_count=args.max_transaction_count,
  File "/home/nikhil/MYTHRIL/mythril/mythril/mythril.py", line 470, in fire_lasers
    issues = fire_lasers(sym, modules)
  File "/home/nikhil/MYTHRIL/mythril/mythril/analysis/security.py", line 20, in fire_lasers
    issues += module.execute(statespace)
  File "/home/nikhil/MYTHRIL/mythril/mythril/analysis/modules/exceptions.py", line 44, in execute
    solver.get_transaction_sequence(state, node.constraints)
  File "/home/nikhil/MYTHRIL/mythril/mythril/analysis/solver.py", line 109, in get_transaction_sequence
    txs[tx_id]["caller"] = caller
KeyError: 'storage_KECCAC[1]'

...
$

Expected behavior
Contract should be executed without any errors

Environment

Mythril version: develop
Solidity compiler and version: 0.4.25
Python version: 3.6
OS and Version: Ubuntu 17.10

I'll take care of this.


Add new scan states for scan sessions that are no longer accessible by client

Is your feature request related to a problem? Please describe.
Scan session that are no longer accessible by a client may still show in list scans.  These scan session could be in the process of cleaning up resources or have a threads running.  There is currently no direct indication of this in list scans output.  There is an indirect indication that was not intentional , currently inaccessible scan session will lose their scan id.  When this happens they will show up in listscans output with an id of zero or one.  If #4842 were implemented this would no longer be the case.
Describe the solution you'd like
Update ScanState enum to include one or two new states.  These new states could be CLEANING and ZOMBIE possibly.  The cleaning state would indicate the session is no longer accessible and is in the process of cleaning up resources.  The zombie state would indicate the client session is no longer accessible and still has a thread running on the server side.
After the changes in #4840, the information is available server side to populate new scan states.

I can take a look at this


Put init_ec_point_formats() inside #ifndef OPENSSL_NO_EC

This fixes a recent regression of no-ec build on the 1.1.1 branch.

@mattcaswell please re-approve. The prototype had to be moved as well.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged. Thanks!


Handle sandbox exits properly

Wire up sandbox instances to CRI's event monitor. This ensures we handle sandbox exits properly and kubelet receives updated status (applicable for non pod sandbox controllers).
Move PLEG sandbox container events to podsandbox/ package (we should not generate those events if we don't use pause containers).

Left bunch of TODOs for follow ups.
Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

Covered by https://github.com/containerd/containerd/pull/8007 and https://github.com/containerd/containerd/pull/8045


feature(tests) added basic testing

reference #22
Created single test using the bot-tester testing framework for botbuilder. Demonstrates switch from automatic responses to user - agent communication.

vscode files were left in for easier debugging


Allow configuration of a different logger in ApplicationLifecycleModule

Hi Seriloggers,
I would like to be able to configure the ApplicationLifecycleModule logger to be separate from my main application logger.
Thoughts?
I can pretty easily just copy paste the ApplicationLifecycleModule into my application if your not keen on this change :)
Cheers
Jake

Thanks for the PR Jake! I think this is a reasonable change; let me give it a bit more thought, but should be a winner. Cheers!


"Amplify Console requires you to have admin access to the repository." - Why?

I've set up a Personal Access Token for a Github user that's used for CI purposes. The token gives access to the repos, but the console complains that admin access is required.

App ID can't be provided, because I can't create an app without giving my CI user admin access to the repo.
Region is eu-west-1

For clarity, I really wanted to use CDK:
const amplifyApp = new amplify.App(this, 'xxx', {
    sourceCodeProvider: new amplify.GitHubSourceCodeProvider({
        owner: 'xxx',
        repository: 'xxx',
        oauthToken: SecretValue.plainText(process.env.CI_USER_PERSONAL_ACCESS_TOKEN as string)
    }),
});
amplifyApp.addBranch("main");

This was giving me the followign error message.
Resource handler returned message: "Invalid request provided: There was an issue setting up your repository. Please try again later.({"message":"Not Found","documentation_url":"https://docs.
github.com/rest/reference/repos#create-a-repository-webhook"}) (Service: Amplify, Status Code: 400, Request ID: 85d2b3bd-9801-4bbb-b787-3ca71e756eb0, Extended Request ID: null)" (RequestToke
n: ac23db47-0ef6-4d29-ed0f-83eae4d37e3c, HandlerErrorCode: InvalidRequest)

To debug the problem, I was trying to use the console.
In the console, I saw this message about a requirement to be an admin user (this isn't mentioned elsewhere I don't think).
I realised that deploying my CDK project from the CLI worked fine for me when I used my Github personal access token, but not my CI user. The difference is that I'm an organization owner, and the CI user is a member. I switched the CI user to be an Owner, and suddenly it worked.
I realised that by making the user an Organization Owner, I was also making them an "Admin" role in each repository, which set the flag in the API response to true, and made Amplify happy.
The right way to deal with this would have been to add my CI user to the repo as admin.

Using Chrome debug tools, I noticed that the API call to Github was executing from the browser. In the GraphQL response, I could see some references to "admin", and I realised that it is just checking whether the user is an "admin" role of the repository. This doesn't seem right, because the CDK CI process just uses the personal access token, which has defined scopes.
I think the underlying problem is that Amplify is complaining that it needs to be an admin of the repo, when really, all it needs is a Github token with repo access, but there's no way to add that in the UI, so it asks for way more permission than required.

Hi @a-h, thank you for reaching out.
When you create an Amplify app using GitHub as source, we use the provided oauth token to create a Webhook and a Deploy Key on your repository. The Webhook is used to listen for GitHub events to trigger Amplify CI/CD based on new commits to your connected branches, and the Deploy Key is used to pull code from your repo during a build.
The GitHub permission model requires Admin access to a repository in order to create webhooks and deploy keys. Which is why the UI shows grayed out those repos for which you are not an admin. And its likely the same reason why your CDK deployment fails.
We will take the action item to improve our documentation around this subject to make it clearer.

The documentation says to use a Personal Access Token with the repo scope which is what I gave it.
<EMAIL_ADDRESS>oauthToken🔹
Type: SecretValue

A personal access token with the repo scope.

So the documentation is certainly part of the problem.
I don't want Amplify to create a Github Webhook and deploy key because that means giving a CI user admin rights.
I want to pass Amplify a Github deploy key, and for Amplify to then tell me where I should configure Github to send the Webhook.

@ferdingler Anything on the pipeline to avoid requiring repo Admin permission - CI like credentials should especially follow the least privilege principle and this hard requirement (which by the way is not stated anywhere in the documentation) is really a non-starter for many people

@ferdingler Anything on the pipeline to avoid requiring repo Admin permission - CI like credentials should especially follow the least privilege principle and this hard requirement (which by the way is not stated anywhere in the documentation) is really a non-starter for many people

Please read this: https://github.com/aws-amplify/amplify-console/issues/1542#issuecomment-1049639904. Closing this thread so we can track it there.

We now support GitHub apps to help with this: https://aws.amazon.com/about-aws/whats-new/2022/04/aws-amplify-hosting-github-access-workflows/.
Please let us know if you have any issues.


Cannot open read-only

When I am trying to open the database in read-only mode, like this:
dir := /bow
opts := badger.DefaultOptions
opts.ReadOnly = true
opts.Logger = nil
db, err := bow.Open(dir, bow.SetBadgerOptions(opts))
I see:
error: No sets or deletes are allowed in a read-only transaction
From badger docs:
// ErrReadOnlyTxn is returned if an update function is called on a read-only transaction.
ErrReadOnlyTxn = errors.New("No sets or deletes are allowed in a read-only transaction")
I update nothing; or am I ?

This must be some update call bow makes when it's initializing. I'll be checking this later today, and hopefully commit a fix and let you know.

Alright, sounds good; please let me know.

Okay, I think I found the issue -- when you're Open-ing a brand new database that hasn't been opened before, bow tries to create and store it's meta structure (containing information about buckets) even if it's opened with ReadOnly.
This same problem happens when you access a bucket that doesn't exist -- bow will try to create it regardless of the ReadOnly restriction.
Thanks for reporting this issue, I will fix it and let you know.

Excellent. Read-only is a big deal if you access the database from a different process. Inside the same process, one can delegate all Bow operations to a dedicated goroutine and thus avoid dealing with DB locks.

Update: I've set up a read-only test, and I'm fixing stuff until it passes. Will let you know.

@cbalano
Commit 6703512ae74d252b8ffe01e5fcaeb8bbf926b2fe resolves this issue.
Please let me know if it works for your use case :)

Read-only confirmed as working now. Thank you, good sir!

When I attempt to open read-only in a directory that does not exist, I get a panic, rather than an error. Is that the intended behavior?

@cbalano This behaviour is inherited from BadgerDB. Would you prefer to get an error when opening the database instead? Maybe something like ErrNoDatabase?

Well, it's a nicety, not a must.


Fix sysroot reading

fix #14

Can you give a CMake script + toolchain that triggers this?
I'd like to add it as a unit test.

Thanks!
I could trigger the error by something siple as setting CMAKE_SYSROOT https://github.com/madebr/python-cmake-file-api/commit/032ff33c72d2d2bcb440d8cabb11167d0f031e0b


[11.x] Add AsCommand attribute to Console commands stub by default

Just thinking that maybe this should be the default behavior after all the work done in #50617 so I updated the stub.

Or maybe it would be better to setup a new Laravel contract that inherits from Symfony's AsCommand and maybe clean up some stuff from the Commands structure? And target this change for 12.x instead
Let me know what you think!

I think it's generally fine to not have this. We mainly did it in the framework because we have so many commands.


code for ERPs

add function to calculate event-related-potentials from timeseries data and a list of event times.

here's what i have so far:
def calc_max_erp(data, event_times, time_before, time_after, fs, return_mean_erp=False):
    '''
    Calculates the maximum event-related potential for the given timeseries data.
    '''

    n_events = len(event_times)
    aligned_data = aopy.preproc.trial_align_data(data, event_times, time_before, time_after, samplerate)

    n_samples = aligned_data.shape[1]
    before_samples = int(time_before*fs)

    event_mean = np.mean(aligned_data[:,:before_samples,:], axis=1)

    event_mean = np.tile(event_mean, (n_samples, 1, 1)).reshape((n_events, n_samples, -1))
    erp = aligned_data - event_mean

    mean_erp = np.mean(erp, axis=0)

    idx_max_erp = np.argmax(np.abs(mean_erp), axis=0)
    max_erp = np.array([mean_erp[idx_max_erp[i],i] for i in range(mean_erp.shape[1])])

    if return_mean_erp:
        return max_erp, mean_erp.T

    return max_erp


force:source:beta:push can deploy metadata from outside the package directories

Summary
If you have a directory which has a name which starts with the same string as a package directory, e.g. 'force-app-extra' where 'force-app' is a package directory, then metadata will be deployed from it even though it is not a package directory in sfdx-project.json.
Steps To Reproduce:
See https://github.com/nawforce/sfdx-test/tree/main/extra-classes.
System Information
"cliVersion": "sfdx-cli/7.131.0",
"architecture": "darwin-x64",
"nodeVersion": "node-v16.6.0",
"pluginVersions": [
"@oclif/plugin-autocomplete 0.3.0 (core)",
"@oclif/plugin-commands 1.3.0 (core)",
"@oclif/plugin-help 3.3.1 (core)",
"@oclif/plugin-not-found 1.2.6 (core)",
"@oclif/plugin-plugins 1.10.11 (core)",
"@oclif/plugin-update 1.5.0 (core)",
"@oclif/plugin-warn-if-update-available 1.7.3 (core)",
"@oclif/plugin-which 1.0.4 (core)",
"@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
"alias 1.2.0 (core)",
"apex 0.5.0 (core)",
"auth 1.8.0 (core)",
"config 1.3.2 (core)",
"custom-metadata 1.0.12 (core)",
"data 0.6.6 (core)",
"generator 1.2.1 (core)",
"info 1.1.4 (core)",
"limits 1.3.0 (core)",
"org 1.11.0 (core)",
"salesforce-alm 53.6.0 (core)",
"schema 1.1.0 (core)",
"sfdx-cli 7.131.0 (core)",
"sfpowerkit 3.3.3 (link) /Users/kevin/Projects/sfpowerkit",
"source 1.6.2 (core)",
"telemetry 1.4.0 (core)",
"templates 52.6.0 (core)",
"trust 1.1.0 (core)",
"user 1.7.0 (core)"
],
"osVersion": "Darwin 21.1.0"
}

Nice catch!

The fix for this issue is now in SFDX CLI v7.134.0 published today.
See https://github.com/forcedotcom/cli/blob/main/releasenotes/sfdx/README.md#71340-jan-20-2022-stable


Set-AzApiManagementHostnames stated in article is not available with Az.ApiManagement 2.3.2

I was not able to find the cmdlet Set-AzApiManagementHostnames used in this article and hence upgraded to 2.3.2:
>get-module Az.ApiManagement -ListAvailable

ModuleType Version    PreRelease Name                                PSEdition ExportedCommands
---------- -------    ---------- ----                                --------- ----------------
Script     2.3.2                 Az.ApiManagement                    Core,Desk {Add-AzApiManagementApiToGateway, Add-AzApiManagementApiToProduct, Add-AzApiManagementProductToGroup, Add-AzApiManagementRegion…}

However there this cmdlet also seems not to be available:
>get-help Set-AzApiManagement*

Name                              Category  Module                    Synopsis
----                              --------  ------                    --------
Set-AzApiManagementApiVersionSet  Cmdlet    Az.ApiManagement          Set-AzApiManagementApiVersionSet…
Set-AzApiManagementApiRevision    Cmdlet    Az.ApiManagement          Set-AzApiManagementApiRevision…
Set-AzApiManagementTenantAccess   Cmdlet    Az.ApiManagement          Set-AzApiManagementTenantAccess…
Set-AzApiManagementOperation      Cmdlet    Az.ApiManagement          Set-AzApiManagementOperation…
Set-AzApiManagementNamedValue     Cmdlet    Az.ApiManagement          Set-AzApiManagementNamedValue…
Set-AzApiManagementIdentityProvi… Cmdlet    Az.ApiManagement          Set-AzApiManagementIdentityProvider…
Set-AzApiManagementPolicy         Cmdlet    Az.ApiManagement          Set-AzApiManagementPolicy…
Set-AzApiManagement               Cmdlet    Az.ApiManagement          Set-AzApiManagement…
Set-AzApiManagementApi            Cmdlet    Az.ApiManagement          Set-AzApiManagementApi…
Set-AzApiManagementLogger         Cmdlet    Az.ApiManagement          Set-AzApiManagementLogger…
Set-AzApiManagementSubscription   Cmdlet    Az.ApiManagement          Set-AzApiManagementSubscription…
Set-AzApiManagementAuthorization… Cmdlet    Az.ApiManagement          Set-AzApiManagementAuthorizationServer…
Set-AzApiManagementApiSchema      Cmdlet    Az.ApiManagement          Set-AzApiManagementApiSchema…
Set-AzApiManagementUser           Cmdlet    Az.ApiManagement          Set-AzApiManagementUser…
Set-AzApiManagementOpenIdConnect… Cmdlet    Az.ApiManagement          Set-AzApiManagementOpenIdConnectProvider…
Set-AzApiManagementGroup          Cmdlet    Az.ApiManagement          Set-AzApiManagementGroup…
Set-AzApiManagementDiagnostic     Cmdlet    Az.ApiManagement          Set-AzApiManagementDiagnostic…
Set-AzApiManagementCertificate    Cmdlet    Az.ApiManagement          Set-AzApiManagementCertificate…
Set-AzApiManagementBackend        Cmdlet    Az.ApiManagement          Set-AzApiManagementBackend…
Set-AzApiManagementProduct        Cmdlet    Az.ApiManagement          Set-AzApiManagementProduct…

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85f2f368-b037-9195-cb62-c3341b3eb346
Version Independent ID: 6034b68e-792c-b9cf-8884-088127cf71de
Content: Azure PowerShell Script Sample - Set up custom domain
Content Source: articles/api-management/scripts/powershell-setup-custom-domain.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

Thank you for your feedback! We will review and update as appropriate.

@KaiWalter Per the following issue, the sample appears to be based on AzureRM cmdlets: https://github.com/MicrosoftDocs/azure-docs/issues/27411
Please use the sample shared by @PramodValavala-MSFT: https://github.com/MicrosoftDocs/azure-docs/issues/27411#issuecomment-475295617
Existing sample is located here: https://github.com/Azure/azure-docs-powershell-samples/blob/master/api-management/setup-custom-domain/setup_custom_domain.ps1
So i'll raise a PR against the sample and get it updated.

@KaiWalter Per the following issue, the sample appears to be based on AzureRM cmdlets: #27411
Please use the sample shared by @PramodValavala-MSFT: #27411 (comment)
Existing sample is located here: https://github.com/Azure/azure-docs-powershell-samples/blob/master/api-management/setup-custom-domain/setup_custom_domain.ps1
So i'll raise a PR against the sample and get it updated.

Thanks @mike-urnun-msft - I exactly reverted to the approach with Set-AzApiManagement stated in that other issue

PR is created: https://github.com/Azure/azure-docs-powershell-samples/pull/386
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


chore: removes non-breaking spaces (U+00a0)

Removes all non-breaking spaces (U+00a0) from Mathlib.
This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).

Relevant discussions:

Zulip

#16215

Are there any such spaces in the archive, tests or counterexamples?
(This need not block this PR; I think these changes are useful in any case.)

Are there any such spaces in the archive, tests or counterexamples? (This need not block this PR; I think these changes are useful in any case.)

As far as I can see, there are no more in the entire repository.

bors r+
Thanks!

@sgouezel it seems that a linter complains about a too long line in a file this PR didn't change? How can that happen?

@grunweg @sgouezel the "overlong" line that the bors build complains about isn't actually overlong. So I have no idea what's happening here...

The lint failure might be from another PR currently being merged or from a commit in master which isn't in this branch yet. In any case this PR now has a merge conflict with master as well, so I'm taking it off the queue:
bors r-
After merging master and fixing any errors, feel free to put this back on the queue:
bors d+

bors r+


Add encrypted images support

WIP - DO NOT MERGE
This allows storing encrypted images in slot1, that are automatically un-encrypted when copying to slot0 and re-encrypted when copying from slot0 to slot1.
The encryption works by applying AES-128-CTR on the image blocks (excluding the header and TLVs) using a random key. This random key is itself encrypted using RSA-2048-OAEP and appended to the image as a newly defined TLV.
The main reason for using RSA-2048-OAEP as the asymetic encryption method was its availability, being implemented in go-crypto (for newt), cryptography (for imgtool) and mbed-tls for bootutil. Alternative methods could be added later, which consist primarily of ECIES (using elliptic curves) and key-wrapping AES with another AES key (as defined by RFC3394). Those need to be implemented by some of the libraries first or need custom implementation in bootutil.
AES-128-CTR was chosen primarily for having stream cipher proporties, which basically means that any block being encrypted/decrypted does not depend on any other previous blocks results.
The TLV adds about 256 bytes to the image, and RSA-OAEP in the firmware increases around 12KB the amount of flash required.

@d3zd3z Would be glad if you could take a look at the simulator changes. They are failing on the encrypted swap test (as expected) because I added some temp code to clean the global state variables in bootutil. One unrelated change is that the header struct was fixed to match bootutil, and some FIXME were not removed because they are not matching some other part of the code. Please review specifically this commit https://github.com/runtimeco/mcuboot/pull/330/commits/19c14f81249b7d0b14e3cfa5fb3d20badf6eeb16.

The status right now is that overwrite-only mode is fully supported but swap mode does not support interruption (because it's still lacking the code to find the TLV containing the key, which will be added next). imgtool can generate encrypted images but does not yet generate the code structures from pem files.

Since the RSA-OAEP part is so heavy, can it be optional?

@oyvindronningstad As long as another key encrypting mechanism is present, sure. The threat model here is that whatever is already flashed inside the chip is to be considered secure. So, this PR is mostly useful to transport images, from some place to the final HW and also because there is need to protect FW when slot 1 happens to be an external SPI chip (a real case). The main reason to have used RSA-OAEP was its existing availability in libraries, but later this PR can easily be extended to add KEK or EICES. KEK is available for python's cryptography (used by imgtool) and mbed-TLS already, EICES is more complicated! ;-)

@utzig How about using AES for the key encryption as well?
Also, have you looked into COSE_Encrypt?

@utzig How about using AES for the key encryption as well?

Sorry, that's what I meant by KEK. Should have used key-wrap, but yes, was referring to the AES key encrypt AES key...

Also, have you looked into COSE_Encrypt?

I have not!

Ok, cool :).

Sorry, that's what I meant by KEK.

Right, sorry. My first google search for KEK didn't turn up much so I just assumed it was another asymmetric algorithm :P.

Also, have you looked into COSE_Encrypt?

I have not!

https://datatracker.ietf.org/doc/rfc8152/
It's a serialization format that hopefully should cover the needs of this feature. It's also very relevant for IETF SUIT.

@oyvindronningstad Just added another commits that adds the KEK support. Using a freedom-k64f with Mynewt, the numbers I get for the bootloader with no sign (no mbedtls dependecy) is around 12KB, with encryption using RSA-OAEP it is around 28KB, and using AES-128-KEK around 20KB. The TLV was reduced from 256 bytes to 24 bytes. Unfortunately this requires a very new release of mbedtls (I have a PR for Mynewt here: https://github.com/apache/mynewt-core/pull/1393), and I hope to update the simulator's bundled mbedtls very soon to be able to test this.

I think this is great. One thing which I'd want to be able to do also is to use encrypted images with serial bootloader, but that should probably be addressed within the serial bootloader code itself. And probably does not need to be part of this PR.
Currently boot_serial always writes the image it receives to slot 0. I think for encrypted images it must write it to slot 1, and then copy it over to slot0 (as the key would not be available otherwise).

@mkiiskila Ha, I actually had thought about this before and my idea was to add an option to newt and imgtool to allow them to insert the encryption header and TLV while at the same time not actually encrypting the generated image, which would allow it to be sent over boot_serial! Of course, this adds an extra layer of complexity because now the user must know which is which, and also it allows for "leaking" an non-encrypted image (and reverse engineering, etc). Other option would be to allow mcumgr/newtmgr to un-encrypt on the fly, but that also requires a private key to be shared with users, so in the end it might just be a better idea to make boot_serial write it to offset 1 and "upgrade" on the first boot.

I cleaned up the git history now.
Some things are missing on the Zephyr side, like encryption with AES-128-KW and I also did not add support for generating images using AES keys to imgtool. I haven't done it because mbedtls was too old on Zephyr, but seems like it was updated to latest last week!
@d3zd3z would be nice to get some security related review of this.

@d3zd3z Docs added!

I've reviewed the design (from the docs), and nothing is standing out to me as a flaw from a security perspective.
COSE_Encrypt would add a lot of complexity to this (and a lot of code). It does support a separate payload, so could be placed after the image. I'm not sure there is really much benefit to this, either.
I would want to revisit the security when adding any other key wrapping method. The complexity in RSA-OAEP and and AES-128-KW are to address specific security concerns, and we would want to make sure any other key wrapping operation also provides sufficient security. I think ECIES should also provide the needed security.

Hey, I think this just broke imgtool. The constructor of class Image doesn't take an encrypt argument, but gets sent one at imgtool.py line 145. It fails like this (I'm trying to build samples/zephyr):
../../scripts/imgtool.py sign --key ../../root-rsa-2048.pem --header-size 0x200 --align 8 --version 1.2 --slot-size 0x60000 /home/jonas/src/mcuboot/samples/zephyr/build/nrf52_pca10040/hello1/zephyr/zephyr.bin signed-hello1.bin
Traceback (most recent call last):
  File "../../scripts/imgtool.py", line 194, in <module>
    imgtool()
  File "/home/jonas/.local/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/jonas/.local/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/jonas/.local/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/jonas/.local/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/jonas/.local/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "../../scripts/imgtool.py", line 145, in sign
    encrypt=encrypt)
  File "/home/jonas/src/mcuboot/scripts/imgtool/image.py", line 94, in load
    obj = cls(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'encrypt'

@JonasNorling Thanks for reporting! Must have messed up when rebasing after the endiannes PR; fix submitted #347.


Remove range operators from markers.

Resolves #4013.
It turns out that older setuptools were pretty stupid and couldn't handle range operators, but they can handle parentheses and the word "or". So let's do that instead.

Codecov Report

Merging #4014 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4014   +/-   ##
=======================================
  Coverage   89.74%   89.74%
=======================================
  Files          15       15
  Lines        1940     1940
=======================================
  Hits         1741     1741
  Misses        199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3618f3f...f3f4c3e. Read the comment docs.

Cool, ok. Let's ship a 2.14.2 with this and see if this cleans up the last few lingering pain points.


Release docker image for arm64

The following file has been created and modified :
.travis.yml: Added .travis.yml file to build and push the image for both amd64 and arm64 platforms.
Dockerfile: Replace base image gliderlabs/alpine:3.3 to alpine:latest
Signed-off-by: odidev<EMAIL_ADDRESS>

Can you please review this PR and let me know if any changes are required?