DRAFT: gem5 Bridge Driver

Adds a Linux kernel module for a character device that can facilitate address-type gem5-bridge commands with user permissions. This is an improvement over the current system as it no longer requires sudo permissions from the simulation as we replace accesses to /dev/mem/ with accesses to /dev/gem5_bridge for which we can control permissions.
Relates to https://github.com/gem5/gem5-resources/pull/48
Adds util/gem5_bridge which includes the C source for the driver and a Makefile to build it from within the disk image -- building and launching the module are done here https://github.com/gem5/gem5-resources/pull/48. The Makefile can take arguments to modify the base address for the gem5ops MMIO range by putting GEM5OPS_BASE=<base_phys_addr> at the end of the make command.
Modifies util/m5/src/m5_mmap.c to mmap from our device /dev/gem5_bridge rather than /dev/mem.
Current Issues

Requires the module to be built with the exact same version as the running kernel during simulation. This is most easily achieved by running the simulation with the vmlinux kernel extracted from the built disk image. However, need to find a proper solution to support multiple kernel versions. If the kernel headers are available on apt, then this has been shown to work, but efforts to acquire the headers for an arbitrary kernel version have so far failed.

I tested this driver code with arm disk iamges and it works. I waas able to run npb benchmarks in gem5 without needing sudo
https://github.com/gem5/gem5-resources/pull/60

I tested this driver code with arm disk iamges and it works. I waas able to run npb benchmarks in gem5 without needing sudo
gem5/gem5-resources#60

That's great news!
@powerjg @BobbyRBruce I remember being pointed towards some existing tests to look at for reference to test the driver, but I don't remember which tests those are exactly so if you have any ideas please let me know. One worry I have is that, right now, the only way I can think of testing this with certainty is to have a custom disk image that includes a binary to call m5_exit_addr. Is that possible / worthwhile to set up just for this test, or is there a simpler way to go about this? Would it be enough to ensure that entering and exiting any KVM workload works fine (akin to just ensuring the m5 utility hasn't failed). In the latter case, would the existing KVM tests suffice?
Also, I feel it's probably time to finally take this out of draft.

I think a good test would be to run a workload that uses the driver, so as we will be updating the disks anyway to include this, we can have the workloads run benchmarks without using sudo (like npb for example) and I feel that would be a good enough test.
I had a clarifying question:

From the changes, it looks to me that kvm is not necessary. that is If we were to use the address mode exits in non KVM, it would still work?

I think a good test would be to run a workload that uses the driver, so as we will be updating the disks anyway to include this, we can have the workloads run benchmarks without using sudo (like npb for example) and I feel that would be a good enough test.
I had a clarifying question:

From the changes, it looks to me that kvm is not necessary. that is If we were to use the address mode exits in non KVM, it would still work?

Oh yes, I think this would be true, since I recall the KVM trap going through some address normalization process to understand the MMIO request. I'm not 100% sure, but I remember that it ends up falling into the same pathway that a non-KVM memory request would follow.


hashbrown fails to build with stable Rust

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:15:5
   |
15 | /     feature(
16 | |         test,
17 | |         core_intrinsics,
18 | |         dropck_eyepatch,
...  |
24 | |         strict_provenance
25 | |     )
   | |_____^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:16:9
   |
16 |         test,
   |         ^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:17:9
   |
17 |         core_intrinsics,
   |         ^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:20:9
   |
20 |         extend_one,
   |         ^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:21:9
   |
21 |         allocator_api,
   |         ^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:22:9
   |
22 |         slice_ptr_get,
   |         ^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/lib.rs:23:9
   |
23 |         maybe_uninit_array_assume_init,
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0658]: use of unstable library feature 'build_hasher_simple_hash_one'
   --> /usr/ports/misc/py-polars/work-py39/polars-py-0.18.7/py-polars/cargo-crates/hashbrown-0.14.0/src/map.rs:260:18
    |
260 |     hash_builder.hash_one(val)
    |                  ^^^^^^^^
    |
    = note: see issue #86161 <https://github.com/rust-lang/rust/issues/86161> for more information

error: aborting due to 8 previous errors

In the FreeBSD ports we only use stable Rust, and hashbrown seems to always breaks with the stable Rust.
hashbrown is used in the Polaris Python package, but we can't built Polaris due to this issue.
rust-1.70.0
FreeBSD 13.2

Something in your dependency tree is turning on the nightly feature of hashbrown, which enables these.

I don't know how to find what causes this.
I am trying to build Polars-0.18.7 https://github.com/pola-rs/polars in the FreeBSD ports framework when I get this error.


Updated setup.cfg mypy flags and resolved related errors.

Added the following flags to setup.cfg to meet CAIRO standards. Run pre-commit install then pre-commit run -a to test these changes locally.
[mypy]
warn_return_any = True
warn_unused_configs = True
ignore_missing_imports = True

All of the warnings that needed to be resolved were because of warn_return_any. Some of my solutions are more elegant than others so let me know if you find a better way.

@Sanketh7 update branch on this to make sure tests still passing

@Sanketh7 update branch FYI


Training in mixed precision

❓ Questions and Help
Before asking:

search the issues.
search the docs.

What is your question?
Hi, thanks for the amazing contribution!
I'm trying to use IBert from Huggingface/transformers (4.4.2) in my own training pipeline where I'm fine-tuning in quant mode with mixed precision (Using pytorch's cuda.amp module). This results in overflows in the QuantLinear layers, which causes following training to break due to nans. I'm considering artificially clamping the weights to a smaller range to avoid this or using a lower bit precision (from 8 to say 4) while fine-tuning.
I'm wondering if you have tried this or have any suggestions about my approaches that could help me train effectively.
Thanks.
Code

 with autocast(enabled=grad_scaler.is_enabled()):
        # TRAINING CODE...

I'm unable to post any more code (proprietary stuff, sorry!), but I can provide some specifics if you need them.
What have you tried?
What's your environment?

fairseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0): 1.8.0
OS (e.g., Linux): Ubuntu 18.04
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version: 10.1/7.6.5
GPU models and configuration:
Any other relevant information:

I manually disabled autocasting in the linear blocks and got the forward pass to work, but I'm getting nans now in the backward pass.
I'll update with more details if I'm able to get the train the model in a stable manner in mixed precision.

Hi, thanks for your interest and I apologize for my late response.
Do you still encounter the same problem?
Since we haven't tried with lower precision than the default 8-bit setting, we have not encountered the same issue.
It is probably because we haven't taken into account lower bit precisions when writing the code and there are some corner cases we haven't debugged/encountered.
In case you have already had a solution for this, we would also greatly appreciate it if you could please open up a PR for it.

Thanks for your response!
I got around that issue by disabling autocasting in the linear blocks but I realized after doing that, that it defeats the purpose of mixed precision training because most of the computations are in the linear layers which are in fp32 (after the disabling), so it yielded no improvement in training time.
I've given up on it for now because I had to move on to other things, but I'll definitely provide an update if I get it working in the future.


Bum version of Jackson to 2.12 to support Java records

Is it possible to migrate Jackson to version 2.12+ please? Jackson natively supports Java records since this version. At the moment JsonProperty annotation must be added for every record's field which is quite annoying.

@StanSvec Jackson 2.12.x is being used in Dropwizard 2.1.x.
There will not be an upgrade of Jackson 2.9.x to 2.12.x in Dropwizard 2.0.x in order to avoid breaking consumers in a patch release.
You can use the latest Dropwizard 2.1.x beta release if you need support for Java records out of the box.
You can also override the version of Jackson in your application build by importing the Jackson 2.12.x BOM.

Thanks for making it clear @joschi. I'll close the ticket now.


Expected release date?

Hi, thanks for your cool work! Just wanted to ask if there's an expected release date for this paper's code?

Apologies for the long delay! Code is public now.


MDF [mqtt_db] mqtt_db rollback to atomic int to restore performance

This is a demo PR

It would improve the performance by over 30%, BUT thread-safety needs to be verified

no at least 500%


Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API

If you are using webhooks, they will fail as .net can't deserialize the payload when the payment type is INTERAC or SQUARE_GIFT_CARD_V2.
I have been using this mod since 2.61 without issue.

Hello?

sheam, Thank for you reporting this issue we are working on it. Thanks again.

Hi Sheam,
Thanks again for reporting this. Would you mind emailing<EMAIL_ADDRESS>so we can work with you to resolve this?
Cheers!

Thanks for raising this issue, @sheam. We have made a change on the server so that only the values already defined in V1Tender.CardBrandEnum will be returned. We opted to make this change on the server instead of the client in order to not break users who do not upgrade their C# SDKs.

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  So how can tell if a payment is INTERAC now? What about historical payments that already had INTERAC for CardBrand?                                                                                ~Shea                                                                                From<EMAIL_ADDRESS>June 13, 2018 10:52 AMTo<EMAIL_ADDRESS>to<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [square/connect-csharp-sdk] Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API (#61)  Thanks for raising this issue, @sheam. We have made a change on the server so that only the values already defined in V1Tender.CardBrandEnum will be returned. We opted to make this change on the server instead of the client in order to not break users who do not upgrade their C# SDKs.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  thanks Alec, I appreciate the update.I had modified the sdk to work with the interac enum. I guess that will no longer work. I guess I can likely assume the type OTHER_BRAND is INTERAC for now.                                                                                ~Shea                                                                                From<EMAIL_ADDRESS>June 13, 2018 12:08 PMTo<EMAIL_ADDRESS>to<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [square/connect-csharp-sdk] Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API (#61)  Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Is this still broken? Or should I continue to use my fork?

Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.

By OTHER_BRAND do you mean CardBrandEnum.OTHERBRAND?

Yes OTHER_BRAND == CardBrandEnum.OTHERBRAND. Interact payments will still be returned as OTHER_BRAND currently.


Tooltip not showing zero values on Line Chart

This issue is the same as:
https://github.com/apexcharts/apexcharts.js/issues/4149

However its also present in the Blazor wrapper.
As I commented on that issue, there is a property on the tooltip saying
tooltip: {
   hideEmptySeries: false,
}

This is not mirroed in C#,
Does anyone know of a workaround to set the underlying JS value?

Hi,
We should be able to add this property later today.

Hi,
Added the property in v2.2.1.
@Nephim Would be great if you could test it and close the issue if it works.
Thank you

Hello @joadan,
I've just tested it and works as I expected.
Thank you very much for the quick solution 👍


Add column title to events

Backfill it as: "M 1.4 - 48km NNW of Pahrump, Nevada"
Where M 1.4 is magnitude and 48km NNW of Pahrump, Nevada is place.

Done.


Remove the >1 hour delay between master and the conservative registry flavor.

In #120562, @DilumAluthge indicated that it's expected/acceptable for the conservative registry flavor to lag up to 24 hours. I think it would provide a better package developer and user experience if we limited that lag to a lower time (ideally minutes or seconds) and document expected lag time.
One possible way to do this would be to eliminate conservative altogether and make the package servers capable of serving packages they haven't fully downloaded yet by streaming from their source (e.g. GitHub) with caching and prioritizing such streaming over traffic to those source servers that is for updating packages that don't have users actively waiting for them.

Normally the lag is minutes in my experience. Once the current issues are resolved I will setup something that measures this though.


Adapter tirmming

Hi,
I have the special sequence  GTGCTCGATAGACAT in my reads,  and I just want to trim the special 15bps not trimming other bases. Using the command I described blow, I found the special bases all still in the output file.
We know that there are several categories in Cutadapter ,such as  anchored or unanchored. I want to know  fastp how to trim the adapter(the special bases)?  Why there are still adapter in the outfile ? Even I used the --adapter_sequence parameter , I found fastp trimmed all bases after the adapter sequence, how to trim some  special bases ?
Let us ignore other factors, such as base quality.
$ grep GTGCTCGATAGACAT test1 test2 testout1 testout2
#original reads
test1:NACCTTAGATGAGGGTGCTCGATAGACATACCCTGAGAAGCCAGGCACCCCAGGTGAAGGGATGCTTAGCTCTGACTTAGACAGGATTTCCACAGAAGGTGAGGCTGTGACCCGTACCTCTTTGTGTATAAGGGTTTTCTATGGGAGAAG
test1:NTCACGGGCCATCGGTGCTCGATAGACATCATCCTTCATCAAAAAGCCATTTGACCGTGGAGAAGTAGAATCAATGGAAGATGATACTAATGGAAATCTAATGGAGGTGGAGGATCAGTCATCCAATGTCTATCGAGCACAGATCGGAAG
test1:NGGCGACGCCGGTAGTGCTCGATAGACATCCATCTATGCAGATATTCAAGAGTCAGCCATGCTACATCTATTAGTTGACTGGATGCACTGAAATAGAAAATGCAGACAAGATTGCTTCTATTTCCAGAATTCTTTTACATTTGGTGTGCC
test1:NTGGTAATCCGATAGTGCTCGATAGACATCGTGTTACATATGTGAAAAAAAGGAGAACCAAGCTATATCTGAACAAAAATTCCGTGGTTTTATATTTGAGTCTATCGAGTGTGTGCATATGTGTATGTTGAGTGTATACATTAGTATATA
test1:NCTGGGTCGTTGTTGTGCTCGATAGACATCTTCGGAGCTGTTGGGTACACTTCCGAGACGGGGCAGCCTGGCAGAGGCGCTTCTCACTTCCCAGACAGGGCGGCCGGGCAGAGGAGCTCCTCACTTCCCAGATGGGGCGGCCGGGCAGAG

test2:GTGCTCGATAGACATCAGAGAAGCTGTACAGATCACAGTCCCAAAGATAGGACCTCCTCCTTCTCCCATAGAAAACCCTTATACACAAAGAGGTACGGGTCACAGCCTCACCTACTGTGGCAATCAGTGCTAAGTCAGAGCTAAGCATCC
test2:GTGCTCGATAGACATTGGATGACTGATCCTCCACCTCCATTAGATTTCCATTAGTATCATCTTCCATTGATTCTACTTCTCCACGGTCAAATGGCTTTGTGAGGAAGGATGATGTCTATCGAGCACCGATGGCCCGTGAGAGATCGGAAG
test2:GTGCTCGATAGACATATGAATAATGCATCTGTTATAATTCTGCTTTCCAAAGTACGTTTTCTGGGCACACCAAATGTAAAAGAATTCTGGAAATAGAAGCAATCTTGTCTGCATTTTCTATTTCAGTGCATCCAGTCAACTAATAGATTT
test2:GTGCTCGATAGACATACATAAGGGTTCTCCTCCATGGTAGATACCTGTTCGAACATAGATCTAAAAGAAAAAAGTAGGTATATACTAATGTATACACTCAACATACAAATATGCACACACTCGCTAGACTCAAATATAAAACCACGGAAT
test2:GTGCTCGATAGACATCCCATCATCTGGGAGGTGAGGAGCGCCTCTCCCCGACCGCCACCCCGTCTGGGAAGTGAGGTGCGCCTCTGCCCGGCCGCCCCATCTGGGAAGTGAGGAGCTCCTCTGCCCGGCCGCCCTGTCTGGGAAGTGAGA
#after trimming
testout1:NTCACGGGCCATCGGTGCTCGATAGACATCATCCTTCATCAAAAAGCCATTTGACCGTGGAGAAGTAGAATCAATGGAAGATGATACTAATGGAAATCTAATGGAGGTGGAGGATCAGTCATCCAATGTCTATCGAGCAC
testout2:GTGCTCGATAGACATTGGATGACTGATCCTCCACCTCCATTAGATTTCCATTAGTATCATCTTCCATTGATTCTACTTCTCCACGGTCAAATGGCTTTGTGAGGAAGGATGATGTCTATCGAGCACCGATGGCCCGTGAG

$ ./fastp0p20p0 -i test1 -I test2 -o testout1 -O testout2 --adapter_sequence=GTGCTCGATAGACAT --adapter_sequence_r2=ATGTCTATCGAGCAC

Thank you,
Xiucz

Will check that.

This is similar to issue #191 but I think there is an additional thing going on. The given adapter is trimmed from the reads, but since fastp assumes everything is a 3' adapter, it has no way of knowing you may want to keep things 3' of the adapter sequence (and remove things 5' of that sequence). I would argue this is probably the only feature fastp is missing to make it the ultimate trimming tool.
The additional thing here is that the two reads that remain contain a bit of the Illumina adapter at the 3' end, which fastp trims. It appears that fastp considers trimming complete when it finds that one sequence. Is this the expected behavior? I think it would make more sense to find the adapter that trims the largest portion of the read, or at least make "greedy" adapter trimming an option. Cutadapt enables this by an option to do repeated adapter trimming on each read (option -n I think).

@donutbrew  I found this problem when i was dealing with my UMI datas, my read-structure, [umi] + [adapter] + [sequence], and I just want to cut the adapter bases.

So are you presorting the UMIs and wanting to retain only [sequence] or are you trying to retain the UMI sequence and stitch it on the the sequence like [umi][adapter][sequence] --> [umi][sequence] ?
In the first case, we need 5' adapter as a new option (what I was talking about above). In the second case, that would take some additional wrangling, and I'm not sure what existing tool handles this.
In either case, fastp is currently trimming your adapter as if it is meant to be a 3' trimming boundary, and your reads are discarded because the remaining sequences are too short.

@sfchen @donutbrew , maybe I need the second case, [umi][adapter][sequence] --> [umi][sequence].


Cannot run packaged app with tadeious or mssql package

Pre-flight checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project uses.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.5.0
Electron version
v32.1.2
Operating system
Windows 11
Last known working Electron Forge version
No response
Issue
I'm encountering issues with packaging my Electron app using Electron Forge, especially regarding including the mssql module. The module works fine in the development environment but fails to load in the packaged version. Additionally, I have tried using the tedious package, and I am running into similar issues.
I started creating the app using vite-typescript template.
The errors vary depending on the configuration:

Without marking mssql as external in vite.config.js:
In this case, the development version fails to run, giving the following error:
TypeError: Cannot read properties of undefined (reading 'get') at _interopNamespaceDefault
With marking mssql as external in vite.config.js:
The development version works, but when I package the app using Electron Forge, I get the following error when trying to start the app:
Error: Cannot find module 'mssql'

I also tried disabling asar and contextIsolation but that does not help.
How do you get some of these packages running?
Actual behavior
The app does not run in packaged mode when this packaged are used.
Steps to reproduce

Create a project with typescript-vite template
Add sample page communicating to MSSQL server over Bridge
Run the app
Error appears

Additional information
No response

Do you have electron rebuild installed?

try adding it and see if it changes something. I'm also having problem running the packaged version after installing native modules

In my case, unfortunately, I had to change it to the webpack which solved the problem but made my build and start take a lot more time

I added it in package.json like this
    "rebuild": "electron-rebuild -f -w tedious"

and then run:
npm run rebuild
npm run package

When I run it i get the same issue

In my case that _interopNamespaceDefault was being used to do something with the 'process' import. Is it the same for you?
Anyway, it might be worth changing to webpack just to make it work if you are in a hurry. Also it would be good to update the issue with a reproducible repo

Do you know the process of changing to webpack? Thanks

For me I just created a new webpack template and started copying from that template to the original repo. It should be straightforward if you have a little experience with webpack. Besides that, I do not have a series of steps for you to follow, you'll need to change things and test if it works with the electron-forge startt command

I have also encountered these problems,
but I am is sequelize
running them all works well. After packaging,
running them prompts： Cannot find module 'sequelize'


Fix SAdsNotificationHeader structure

The data field is a dynamically sized array that is part of the
structure. As such, declaring it as a pointer type is wrong.
If it is declared as a pointer, bytearray(data) is limited in size
to the size of a pointer on the platform Python is running on.
With x86 (32-bit) Python, it is not possible to capture double-
precision floating point values this way, since they are twice
as large as the pointer size. struct.unpack will then complain
that the sizes do not match up.
Instead, declare that the data field is one byte (like in the actual
C structure), and dynamically build a field of the right size
when it is known.
This additionally allows to remove the superfluous copy of
the value for string parsing.
This breaks backwards-compatibility when functions relied on
getting a pointer-sized byte array for unmapped types since
they are now also correctly sized.
Fixes #43

Pull Request Test Coverage Report for Build 198

1 of 4 (25.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 89.205%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyads/ads.py
1
4
25.0%

Totals

Change from base Build 197:
0.3%

Covered Lines:
595

Relevant Lines:
667

💛  - Coveralls

Thanks for the PR. As I understand it this might also fix issue https://github.com/stlehmann/pyads/issues/64?

I think so, yes.

Thanks again for your help with this bug. There should definetely be a test for this use case of Device Notifications with larger data types. I want to ask you if you would like to add one. I would add it myself but I am not doing anything with pyads at the moment so I would need to find the time to get into it again. Kind Regards.

Test case added in #111


[MM-27556] UI For new system roles

Summary

Adds UI to assign and edit system roles

Ticket Link

https://mattermost.atlassian.net/browse/MM-27556

Related Pull Requests

Has server changes https://github.com/mattermost/mattermost-server/pull/15500
Has redux changes https://github.com/mattermost/mattermost-redux/pull/1269

Screenshots

UX review will probably just be CSS changes... but I dont think i'll be around for that either you (@hahmadia) or @mkraft will have to co-ordinate with @michaelgamble to get that done

/update-branch

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich

@mkraft @hahmadia will this be picked up by someone from your team?

@jasonblais Yep! Our team is looking at this.

Also one more thing @hahmadia, can you please capitalize the word "Mattermost" in all the help text:

@srkgupta
Ok, I think I've addressed all with exception of the ones we spoke about in the DM's.
You will need to run these two commands while I Figure out how to migrate these two permissions but in the meantime you can run this and things should work fine
➜  ~ mmctl permissions add system_admin sysconsole_read_user_management_system_roles --local
➜  ~ mmctl permissions add system_admin sysconsole_write_user_management_system_roles --local

@srkgupta Also, note that there is redux changes you will need to pull and use.

@srkgupta
https://mattermost.atlassian.net/browse/MM-29895 -> Read Only role is now editable(with exception to system roles ... Only adming has this, nobody else has it and nobody else can have it for now). This came from discussions we had with team.
https://mattermost.atlassian.net/browse/MM-29926 -> System Roles is always no access for everyone except system admin. Nobody can get it either. This came from discussions with team.


There is 6 Spi but the speed of spi just mentions about spi123 and 45

Also, need verify the speed on spi6

Also MSB / LSB spi


Remove Travis CI testing - at least on on Mac, maybe completely???

https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing:

macOS builds need special care and attention. We want to make sure that builders on Mac have the highest quality experience at the fastest possible speeds. Therefore, we are separating out macOS usage from other build usage and offering a distinct add-on plan that will correlate directly to your macOS usage. Purchase only the credits you need and use them until you run out.

We love our OSS teams who choose to build using TravisCI and we fully want to support that community. However, recently we have encountered significant abuse of the intention of this offering. Abusers have been tying up our build queues and causing performance reductions for everyone. In order to bring the rules back to fair playing grounds, we are implementing some changes for our public build repositories.

For those of you who have been building on public repositories (on travis-ci.com, with no paid subscription), we will upgrade you to our trial (free) plan with a 10K credit allotment (which allows around 1000 minutes in a Linux environment).
You will not need to change your build definitions when you are pointed to the new plan
When your credit allotment runs out - we’d love for you to consider which of our plans will meet your needs.
We will be offering an allotment of OSS minutes that will be reviewed and allocated on a case by case basis. Should you want to apply for these credits please open a request with Travis CI support stating that you’d like to be considered for the OSS allotment. Please include:

Your account name and VCS provider (like travis-ci.com/github/[your account name] )
How many credits (build minutes) you’d like to request (should your run out of credits again you can repeat the process to request more)

Usage will be tracked under your account information so that you can better understand how many credits/minutes are being used

Any ideas, suggestions?

Oh, come on! It's not like we don't already have enough other open issues :exploding_head:
Right now, I can think of the following (without having checked any of them yet):

Calculate (estimate) how many credits we need per month and see if we can get enough OSS allotments from Travis (seems unlikely, but who knows - we are still comparatively small)
Check if GitHub Actions could serve as a replacement (I don't know if they offer what we need and/or if they are sufficiently fast (at least not slower than Travis))
Switch to a different free CI provider (I don't know which one this could be)
Try to use self-hosted runners (with the increased overhead of having to maintain them + security issues for public repos)
Just pay for it (how much would it cost?)

Do we know what other organizations are doing about this?

Check if GitHub Actions could serve as a replacement (I don't know if they offer what we need and/or if they are sufficiently fast (at least not slower than Travis))

I'm looking into this right now.


It's difficult to find a direct link to a download

There's a beautiful dropdown to select a platform to download, but what I need is a direct link so I can wget the .tar.gz from a remote system. Can we please either change the beautiful dropdown to a list or add direct links?

@dblock Yep - I get the use-case. I've been thinking about something like this:

Or even a "Copy as cURL" button.
Thoughts?

[PS - those are links-styled-as-buttons, so you can right click "Copy as Link" right now]

I like both copy link or copy as cURL (as wget though?)!

@dblock @stockholmux  Interesting proposal and I think it will add some value to use experience. If the below looks good, I can commit a PR for this issue.

@vimalMK I think a copy link button would be great! We had gotten some other feedback that is probably going to have us redesign the entire page shortly. What do you think about this? In particular do you like the linked sample sites?
https://github.com/opensearch-project/project-website/issues/862#issuecomment-1171680400

@dtaivpp In my opinion , I really like keeping the user in a single page while going through Downloads. That being said keeping the redirection minimal.  Sometimes that's not always the case for example the docker and ECR in this case and I like how it is right now. But if the redesign is discussed I like Kafka downloads page a lot!! . Its like a one stop solution. . Just my thoughts . :)


Allow references for responses fixes #84

fixes #84

@westfield-labs are you still maintaining this project?

@hornc Sorry to bother you, but I saw you did the latest merge. Any thoughts on this?

@trekdemo thanks for submitting this PR. We will review https://github.com/westfieldlabs/apivore/issues/84 and this PR shortly.

@ashoda any update on the review?


Need to add source & license to ID default fields

What's your idea for a cool feature that would help you use OHM better.
Need to ensure higher compliance with licensing and sourcing recommendations at the object level.
So, I'd (get it? ; ) ) like to see ID have required fields for source of the object (e.g. map url) and a license.
The license field should include a default option for CC0.
Current workarounds
Manual compliance and community enforcement.
Additional info
Here's a screenshot of ID & where those additional fields should go.

We do this here:
https://github.com/OpenHistoricalMap/iD/tree/staging/data/presets
We should find some example elements that have source and license set to make sure we get the keys right

First step: add License and Source as a fields that iD recognizes
Relevant files:

data/presets/fields/source.json defines the field UI to use for Source

yes, this field already exists, but as a multi-select (combobox) with options: survey, local knowledge, gps, ...
change to a text field

data/presets/fields/license.json will define the field UI for License

create this, using the new text Source as a template

This adds them to the offerings, as plain old text fields.

Second step: Getting these to always show up in the top section even if the feature doesn't have values, like Start Date and End Date do
Relevant file:

scripts/build_data.js added a new addSourceAndLicense() wrapper which splices in license and source into ALL presets

So now the fields always show up even if there is no value. They will come after name if this preset contains it, or else are appended to the end of the preset.

Sub-step of note: Limit on number of field names
This caused a new error: 13 values in "fields" of "Car Wash" (amenity/car_wash). Limit: 12. Please move lower-priority fields to "moreFields". Pretty self-explanatory: there were 11 fields (including start_date and end_date) and this pushed it over an internal limit of 12.
So this required:  const maxFieldsBeforeError = 15; increased from previous limit of 12.

This is done and deployed:


When using TabBar inside a ItemsRepeater - we have a delay to load the page and lost info

What would you like to be added:
When using a TabBar inside a ItemsRepeater the App runs fast.
This video shows the timing.
Notice,

more than 2 seconds for the first loading.
The second, we lost part of the information.
The third, we lost all the information.
The fourth, we have a delay of more than 5 seconds.

Video
https://github.com/user-attachments/assets/afa74e72-1221-4b8f-9c15-91fba219e537
This is the Project File with the repro.
UnoApp186.zip
Why is this needed:
To be able to use TabBar on a project.
For which Platform:

[ ] WebAssembly
[ ] Android
[ ] iOS
[ ] macOS (AppKit)
[ ] Mac Catalyst
[x] Skia

[ ] WPF
[ ] GTK (Linux)
[ ] Linux Framebuffer
[ ] Tizen

[ ] Windows

Anything else we need to know?

Placing a TabBar inside of an itemsrepeater is a strange use-case. @rafael-rosa-knowcode if you were to just use an ItemsControl  with some hardcoded items instead of TabBar, do you still see performance issues?

@kazo0 confirming that even with ItemsControl the performance isn't great.

Placing a TabBar inside of an itemsrepeater is a strange use-case. @rafael-rosa-knowcode if you were to just use an ItemsControl with some hardcoded items instead of TabBar, do you still see performance issues?

Apologies, my (now deleted comment) was talking about using IC instead of IR - still performs badly.
Using a series of Buttons, or a ListView is significantly faster

So after investigating, the problem stems from the application of ItemContainerStyle on a mismatched type.
The OP's sample can be boiled down to:
<ItemsRepeater ItemsSource="{Binding ItemsRepeaterData}">
	<ItemsRepeater.ItemTemplate>
		<DataTemplate>
			<utu:TabBar x:Name="SourcesListView" ItemsSource="{Binding TabBarList}">
				<utu:TabBar.ItemTemplate>
					<DataTemplate>
						<utu:TabBarItem>
							<TextBlock Text="{Binding Name}" />

For context, toolkit provides a global implicit TabBar style, which contains a setter for ItemContainerStyle to a TabBarItem style.
Now, look at the visual-tree the hierarchy is not simply just: TabBar>Grid>ItemsPresenter>(TarBarItem)*n. But rather there is a ContentPresenter between IP and TBI: TabBar>Grid>ItemsPresenter>(ContentPresenter>TarBarItem)*n. This is introduced in #1261 as a mean to solve the doubly-nested TabBarItem problem, where if you would to declare TBI as the root of TB::ItemTemplate, we will generated another in GetContainerForItemOverride to wrap around.
Now, when ItemsControl is trying to apply the ItemContainerStyle to the container, which is now the ContentPresenter, the binding engine is throwing a bunch InvalidOperationException, because we were trying to set TBI properties that don't existing on CP. And, this is causing the performance issue.
As a temporary workaround, I have suggested to set ItemsContainerStyle to null:
<utu:TabBar ... ItemContainerStyle="{x:Null}">


Combining EfficientNet and Vision Transformers

Hello, I'm a university student, I'm currently researching the topic of deepfake detection. I also want to follow the direction of Combining-EfficientNet-and-Vision-Transformers like you but it seems it's quite difficult for you to detect. develop a simpler project than this one, can you give me a reference? thank you

Hi. I am not sure I got you question. If you are looking for a simpler deepfake detection approach, I can send you this one: https://github.com/selimsef/dfdc_deepfake_challenge
This is the approach on which mine is based, anyway, almost all deepfake detection methods have a face detection/extraction step and then some other more sophisticated and customized parts like this and our other work (https://github.com/davide-coccomini/MINTIME-Multi-Identity-size-iNvariant-TIMEsformer-for-Video-Deepfake-Detection). So you will always find a similar preprocessing part in almost all works.

I seem to be wrong in my expression. I really like your deepfake detect app. currently i also want to do a similar project and also choose viT model but your model is too difficult for me to approach. I wonder if you have a simpler tutorial to learn


[T5A1][F10-B1] SAN SOK SAN

@ericsssan  :+1:  overall! oh btw you do not need to CAPS your name during submiision, just San Sok San will do :)


Set up development environment

Overviews of implementation

Set up these tools and libraries.

<EMAIL_ADDRESS>eslint
prettier
tsconfig
husky
CI with bun (experimental)
vscode setting file
editorconfig
tailwind

Review points

Tried to use bun as a package manager only for CI, but there was a error seemingly involved with lock file.
Following the decision we made: lower the priority of CI/CD implementation, I replaced bun with npm rather fixing the error for now.
Screenshots or steps for operation check

I guess the base branch has to be develop branch.


Required=true in StringFlag allows empty string

My urfave/cli version is
v2.23.7
Checklist

[x] Are you running the latest v2 release? The list of releases is here.
[x] Did you check the manual for your release? The v2 manual is here
[x] Did you perform a search about this problem? Here's the GitHub guide about searching.

Dependency Management

My project is using go modules.
My project is automatically downloading the latest version.

Describe the bug
When a StringFlag has Required=true set, setting an empty String is still possible by explicitly setting to empty string (see observed section below).
I don't see a use case where a Required string flag would allow setting an empty string.
I mean, I want that the user provides a value in the first place, why should empty strings be allowed?
If an empty string is allowed, then it shouldn't be Required in the first place, therefore I consider this a bug.
To reproduce
MWE:
package main

import (
	"fmt"
	"os"

	"github.com/urfave/cli/v2"
)

func main() {
	app := cli.App{
		Flags: []cli.Flag{
			&cli.StringFlag{
				Name:     "flag",
				EnvVars:  []string{"FLAG"},
				Required: true,
			},
		},
		Action: func(context *cli.Context) error {
			flag := context.String("flag")
			fmt.Fprintf(os.Stdout, "Flag value is %q\n", flag)
			return nil
		},
	}
	err := app.Run(os.Args)
	if err != nil {
		fmt.Println(err)
	}
}

Observed behavior
$ FLAG= go run .
Flag value is ""

# or
$ go run . --flag=
Flag value is ""

# if set, as expected
$ go run . --flag=example
Flag value is "example"

# if unset
$ go run .
...
   --flag value   [$FLAG]
   --help, -h    show help (default: false)
Required flag "flag" not set

Expected behavior
I would expect that the StringFlag with Required=true would check if a value is actually given:
$ FLAG= go run .
Required flag "flag" not set

Additional context
To workaround the check that the value is non-empty, I have to add a flag action like this:
		Action: func(ctx *cli.Context, s string) error {
			if s == "" {
				return fmt.Errorf(`Required flag "flag" not set`)
			}
			return nil
		},

However, IMO this should be covered by the Required=true setting in the cli package already when parsing the flags.
Want to fix this yourself?
I might be able to provide a fix, if the maintainers agree that this behavior is indeed a bug, and not "by design" or considered a breaking change.
Run go version and paste its output here
go version go1.19.4 linux/amd64

Run go env and paste its output here
I don't see how it's relevant here.

@ccremer this is by design. The fact that the env is set is itself a signal that the user has set it . What it's contents are depend on the client application interpretation of the empty string. The cli cannot make a judgement call on behalf of the user.

@dearchap I see. IMO that's still counter-intuitive because whether the flag is set or not doesn't ultimately matter, what matters is that "a value is required".
In any case. Would it make sense to add a config option that says something like RequireNonEmpty that, together with Required=true returns an error if set to empty string?

Yes having something like that would be preferred

Also in v3 we plan to have flag/arg validation so this would be trivial to implement there

Thanks.
Unfortunately I currently lack the time to contribute. Closing this as we have a workaround available which is good enough for now (or wait for v3).
Feel free to reopen if relevant again.


GridFS insert file

I tried to use GridFS integration example, but looks like onAfterUpload is not triggered by addFile. Is there any other way how to insert file in GridFS?
I don't even want to insert it from filesystem, in fact I need to generate it in memory and insert directly into db, so it can be later downloaded by clients.

This was a bug. Fixed in #148
use fourth argument proceedAfterUpload, see in docs: https://github.com/VeliovGroup/Meteor-Files/blob/caf229ba817c30bc26a693e432a77bc084e810cc/docs/addFile.md

thanks, understood.

Please check if it is working on your end (this is new feature, released yesterday).
Let me know then.

It is working, I updated to 1.6.5 and it started working

Great. Closing this one


new nmos and pmos primitive required

Nmos and Pmos with Gate-Body shorted primitives are needed.

Design name: Reference_buffer_core

Also need a dummy cell of this type: from CTDTDSM
m1 avss avdd avss avdd

addressed by #678