FancyZones always resets zones-settings.json on upgrade

Microsoft PowerToys version
0.51.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce

Install PowerToys version foo1
Setup custom zones using FancyZones
Install PowerToys version foo2
Your custom zones will have been deleted.

✔ Expected Behavior
I would expect 'zones-settings.json' (stored at %USERPROFILE%\AppData\Local\Microsoft\PowerToys\FancyZones\) to be retained on version upgrades unless the JSON schema itself changes.
❌ Actual Behavior
%USERPROFILE%\AppData\Local\Microsoft\PowerToys\FancyZones\zones-settings.json gets reset to the default.
Other Software
No response

I've started just keeping a backup of my 'zones-settings.json' in OneDrive and copying it over to '%USERPROFILE%\AppData\Local\Microsoft\PowerToys\FancyZones' after every upgrade.  It's an okay workaround but is annoying.

Can you include a report bug log?  We think we have a fix for this that will be got fixed.

Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

I won't have time to revert to an earlier version and re-update, but I'll try to remember to do this the next time a new update comes out.

Running 0.51 is all we need.  We have a hotfix ready and I suspect this is same issue

I just re-ran winget install --id="Microsoft.PowerToys" --source="winget" and custom layouts were not lost.  Did version 0.51.1 fix this issue?

Believe so. :)

I just updated to 0.51.1 and FancyZones settings got wiped again, so this is still not fixed


luci-proto-qmi parsing comands to UCI bugs/ missing documentation?

Hi
I'm not sure but I believe the config setting set from luci are written to the network config file incorrectly from luci
for example pdptype has the options as below as found here:
https://openwrt.org/docs/guide-user/network/wan/wwan/ltedongle
IP (for IPv4), IPV6 (for IPv6) or IPV4V6 (for dual-stack)
When I set ipv4 in luci it writes IPv4 in to the network config where I believe it should write IP ( for IPv4)
Also the option "auto connect" writes "auto" as an UCI option
Also the option "delegate" does not seem to be listed in UCI commands or the UQMI documentation.
below is the qmi settings from the network config file:
config interface 'skinny' 	option proto 'qmi' 	option device '/dev/cdc-wdm0' 	option delegate '0' 	option apn 'skinnybroadband' 	option auth 'none' 	option pdptype 'ipv4' 	option delay '20' 	option auto '0'
and this is what i believe it should be:
config interface 'skinny' 	option proto 'qmi' 	option device '/dev/cdc-wdm0' 	option delegate '0' 	option apn 'skinnybroadband' 	option auth 'none' 	option pdptype 'IP' 	option delay '20' 	option autoconect '0'
In the qmi.js file it has the below which I believe is incorect but I'm not at all skilled in java:
		o = s.taboption('general', form.ListValue, 'pdptype', _('PDP Type')); 		o.value('ipv4v6', 'IPv4/IPv6'); 		o.value('ipv4', 'IPv4'); 		o.value('ipv6', 'IPv6'); 		o.default = 'ipv4v6';
I think this here:
o.value('ipv4', 'IPv4');
should say:
o.value('ipv4', 'IP');
Am I correct in thinking this or am I missing something?

These values match the ones expected by the netifd protocol handler here:
https://github.com/openwrt/openwrt/blob/master/package/network/utils/uqmi/files/lib/netifd/proto/qmi.sh#L249


device_from_request exception on python 3.4.3

Running mezzanine 4.2.2, Django 1.10.1
mezzanine.mobile in INSTALLED_APPS.
DEFAULT_DEVICE='mobile'
> python3.4/site-packages/mezzanine/utils/device.py(32)device_from_request()
 except (AttributeError, UnicodeDecodeError, UnicodeEncodeError) as e:
     31    import ipdb; ipdb.set_trace()  # XXX BREAKPOINT
---> 32    pass
ipdb> e
AttributeError("'str' object has no attribute 'decode'",)
ipdb> user_agent
'mozilla/5.0 (iphone; u; cpu iphone os 3_0 like mac os x; en-us) applewebkit/528.18 (khtml, like gecko) version/4.0 mobile/7a341 safari/528.16'

so the routine return "" instead of 'mobile'

This exception breaks device detection with Python 3, if no cookie was set.
This is introduced in commit https://github.com/stephenmcd/mezzanine/commit/82441cbb7ce7f3188a80fce3d4ec66e0b589dfd6 (v4.2.0).
The user agent detection was moved into the try-block and thus skipped when user_agent.decode("utf-8") raises an AttributeError in Python 3.

Mezzanine now requires Python >= 3.6


rename 'priority' to 'unsolved' and remove 'unsolved' option

per feedback from playtest

What if instead of removing this option we have a checkbox that only appears when you're in "UNSOLVED" that's like "Include puzzles with solved metas" or something? That way both options are still available and it's clear what everything does.

What if instead of removing this option we have a checkbox that only appears when you're in "UNSOLVED" that's like "Include puzzles with solved metas" or something? That way both options are still available and it's clear what everything does.

implemented @rgossiaux 's suggestion!

implemented @rgossiaux 's suggestion!


[BSO] CoX BG wont turn purple if you get a unique

🐛 Bug Report
Title. The light should be purple due to getting purple items (bottom row) but it is still white.

Fixed


Errors after update to angular 6

Do you want to request a feature or report a bug?
BUG
Bug Report
Followed this guide https://update.angular.io/ to update from 4.3 to 6
When runnning ng serve i get lot of errors. For example:
error TS2305: Module '"D:/xxx/node_modules/@angular/material/material"' has no exported member 'MdIconRegistry'.
error TS2305: Module '"D:/xxx/node_modules/@angular/material/material"' has no exported member 'MaterialModule'.
and so on...
What is the expected behavior?
No errors
Which version of Angular and Material, and which browser and OS does this issue affect?
Angular CLI: 6.0.5
Node: 8.11.2
OS: win32 x64
Angular: 6.0.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
Package                           Version
@angular-devkit/architect         0.6.5
@angular-devkit/build-angular     0.6.5
@angular-devkit/build-optimizer   0.6.5
@angular-devkit/core              0.6.5
@angular-devkit/schematics        0.6.5
@angular/cdk                      6.1.0
@angular/cli                      6.0.5
@angular/material                 6.1.0
@ngtools/webpack                  6.0.5
@schematics/angular               0.6.5
@schematics/update                0.6.5
rxjs                              6.2.0
typescript                        2.7.2
webpack                           4.8.3
Other information
My package.json:
{   "name": "xxxx",   "version": "0.0.0",   "license": "MIT",   "scripts": {     "ng": "ng",     "start": "ng serve",     "build": "ng build",     "test": "ng test",     "lint": "ng lint",     "e2e": "ng e2e"   },   "private": true,   "dependencies": {     "@agm/core": "^1.0.0-beta.3",     "@agm/js-marker-clusterer": "^1.0.0-beta.3",     "@angular/animations": "^6.0.3",     "@angular/cdk": "^6.1.0",     "@angular/common": "^6.0.3",     "@angular/compiler": "^6.0.3",     "@angular/core": "^6.0.3",     "@angular/forms": "^6.0.3",     "@angular/http": "^6.0.3",     "@angular/material": "^6.1.0",     "@angular/platform-browser": "^6.0.3",     "@angular/platform-browser-dynamic": "^6.0.3",     "@angular/platform-server": "^6.0.3",     "@angular/router": "^6.0.3",     "@covalent/core": "^1.0.0",     "@satispay/web-button-factory": "1.2.1",     "@types/angular": "1.6.28",     "@types/node": "6.0.88",     "angular4-social-login": "1.1.1",     "braintree-web": "3.22.2",     "braintree-web-drop-in": "1.8.0",     "classlist.js": "1.1.20150312",     "core-js": "2.4.1",     "enhanced-resolve": "3.3.0",     "font-awesome": "4.7.0",     "hammerjs": "2.0.8",     "intl": "1.2.5",     "js-marker-clusterer": "1.0.0",     "lory.js": "2.3.3",     "md5": "2.2.1",     "moment": "^2.22.1",     "ng2-cookies": "1.0.12",     "ng2-responsive": "0.8.4",     "ng2-scroll-to-el": "1.0.0",     "ngx-gallery": "4.1.2",     "ngx-zendesk-webwidget": "0.1.2",     "paypal-checkout": "4.0.133",     "rxjs": "^6.2.0",     "sass-loader": "6.0.6",     "web-animations-js": "2.3.1",     "zone.js": "0.8.26"   },   "devDependencies": {     "@angular-devkit/build-angular": "~0.6.5",     "@angular/cli": "^6.0.5",     "@angular/compiler-cli": "^6.0.3",     "@angular/language-service": "6.0.3",     "@types/jasmine": "2.5.45",     "@types/node": "6.0.88",     "codelyzer": "3.0.1",     "jasmine-core": "2.6.4",     "jasmine-spec-reporter": "4.1.1",     "karma": "^2.0.2",     "karma-chrome-launcher": "2.1.1",     "karma-cli": "1.0.1",     "karma-coverage-istanbul-reporter": "1.3.0",     "karma-jasmine": "1.1.0",     "karma-jasmine-html-reporter": "0.2.2",     "ngx-swiper-wrapper": "4.6.0",     "protractor": "^5.3.2",     "ts-node": "3.0.6",     "tslint": "5.3.2",     "typescript": "^2.7.2",     "webpack": "^4.8.3"   } }

Can you try running the update schematic?
ng update @angular/material

Thanks for your reply.
Done. But same error

MaterialModule was removed many versions ago and the MD prefix was dropped in favour of Mat. You will have to go through the chanelog for breaking changes and update your app manually.

The assisted upgrades you referenced, for Material, are only able to assist in upgrading from 5.x -> 6.  You will need to update to Material v5 before using the tool.

thanks


Add instructions to install on mageia 8

I make a changes to README.md to add instructions to install on mageia 8
I hope all is right , i am beginner on this
README.md

Sorry use this one
README.md

@katnatek I add the instruccions to install on mageia 8 see commit . You can update the package name a yt-dlg and the docs?

@katnatek I add the instruccions to install on mageia 8 see commit . You can update the package name a yt-dlg and the docs?

Sure i can do that, give me some time, what you mean with the docs?

With the docs I mean, update the README.md with the changes and the steps the user follows for install ya-dlg
Take your time and thanks 🙏🏾

With the docs I mean, update the README.md with the changes and the steps the user follows for install ya-dlg
Take your time and thanks 🙏🏾

Done!
README.md

You can test the package for mageia 8 and share the link to the spec and the rpm for use with other Distros?

You can test the package for mageia 8 and share the link to the spec and the rpm for use with other Distros?

I test before edit the README  ;)

Not the spec but the src.rpm, it may require edit for other distros as have some mageia specific things https://ftp.blogdrake.net/mageia/mageia8/free/SRPMS/yt-dlg-1.7.2-0.git20210921bdk_mga8.src.rpm
Not sure if works for other distros but here is the rpm https://ftp.blogdrake.net/mageia/mageia8/free/noarch/yt-dlg-1.7.2-0.git20210921bdk_mga8.noarch.rpm

Is not showing one step, please use the fixed README ;)
README.md

@katnatek Thanks very much. I will add the links and the changes to the README. 🙏🏾

@katnatek README.md updated, if everything is ok and working on Mageia 8 fell free close de issue.

@katnatek README.md updated, if everything is ok and working on Mageia 8 fell free close de issue.

Closing, its ok if when new release is done i notify of updated links in this thread?  i try to remove old versions to save space

Closing, its ok if when new release is done i notify of updated links in this thread?  i try to remove old versions to save space

My advice is for new release try open new issue and update links, docs then the users have the options to see the changes and decide 💪🏾
Thanks for the docs collaboration 🙏🏾


issuer thumbprint

in the sample there is "certificateIssuerThumbprint": ""
does this mean that self-signed certs are allowed in the sample?
it should be called out that self signed certs are a big-no-no from security point of view.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d34f6d36-58e7-ab10-e659-bdd10a64deca
Version Independent ID: 25d94e4b-8c95-7423-2665-7c09d438a16b
Content: Update an Azure Service Fabric cluster to use certificate common name
Content Source: articles/service-fabric/service-fabric-cluster-change-cert-thumbprint-to-cn.md
Service: service-fabric
GitHub Login: @athinanthny
Microsoft Alias: atsenthi

Thanks for the feedback! We are currently investigating and will update you shortly.

It is explained in https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-create-cluster-using-cert-cn
probably a link would be great to avoid duplication of information.

@peledins I added a note and link to the doc :)
Once the PR merges the changes will go live after a few hours.


Clearly define public vs. private interface

Ahead of the 2.0.0 release, I think we should clearly define public vs. private interface:

All modules should have __all__ defined
Everything that's private should have an underscore somewhere in its import name, or be excluded from the __all__ in the module where it is defined.
As a simple check, ipython should autocomplete only the public parts when c.IPCompleter.limit_to__all__ = True is set.
The public interface should probably be used (directly) in some test

I can do the changes to the code, but the important question is: which parts should be in the public interface? We have:

qe_tools : public

parsers : public

cpinputparser: ?

CpInputFile : public, directly under parsers

pwinputparser: ?

PwInputFile : public, directly under parsers
parse_k_points: ?

qeinputparser: ?

QeInputFile : public, directly under parsers
get_cell_from_parameters: ?
get_structure_from_qeinput: ?
parse_atomic_positions: ?
parse_atomic_species: ?
parse_cell_parameters: ?
parse_namelists: ?
str2val: ?
strip_comment: ?

generators : public

cell_conversion : ?

get_parameters_from_cell : public (here, or directly under generators)?

utils: ?

_qe_version: private

parse_version: private

exceptions: ?

constants: ?

In aiida-quantumespresso, the following are used:

qe_tools.constants
From qe_tools.parsers, CpInputFile and PwInputFile are used in code, their "real" location (e.g. qe_tools.parsers.cpinputparser.CpInputFile is used in docstrings
qe_tools.utils.exceptions.ParsingError is used in testing

@giovannipizzi  @sphuber @lekah what's your opinion? If needed, now would also be a good time to move/rename things.

Here is a possible suggestion, adapting from yours, with the philosophy that we can make methods public easily later if we want to, while the reverse is complex for backwards incompatibility:

qe_tools : public

parsers : public

cpinputparser

CpInputFile : public, directly under parsers OK

pwinputparser:

PwInputFile : public, directly under parsers OK
parse_k_points: private

qeinputparser:

QeInputFile : public, directly under parsers OK
get_cell_from_parameters: private
get_structure_from_qeinput: private
parse_atomic_positions: private
parse_atomic_species: private
parse_cell_parameters: private
parse_namelists: private
str2val: private
strip_comment: private

generators : public

cell_conversion : private

get_parameters_from_cell : public (directly under generators)

utils:

_qe_version: private

parse_version: private

exceptions: move to top-level qe_tools.exceptions, make exceptions public

constants: keep and make public

What do you think? Happy for different suggestions of course

Also, for renaming, some suggestions:

maybe we can rename qe_tools.parsers.cpinputparser to e.g. qe_tools.inputparsers.cp or something like this?
get_structure_from_qeinput -> shall we change the name to something simpler? is get_structure clear enough? or parse_structure? or should we put an underscore between qe an input?
shall we rename the kwargs of the public methods/functions, where it might make sense? E.g. for the __init__ of QeInputFile, probably it doesn't make sense that it's called pwinput. Maybe simply input_file or input_file_content or input_content? We might want to do a similar discussion more generally once we agree on which are the public methods

Thanks a lot! I think I agree on the public / private suggestions (at least, I didn't see anything that I didn't agree with at first glance).

* maybe we can rename `qe_tools.parsers.cpinputparser` to e.g. `qe_tools.inputparsers.cp` or something like this?

Yeah, that makes sense. Is output-parsing also within the scope of this library? If so, we could consider either a structure

parsers

input
output

generators

input

or flat:

input_parsers (or inputparsers)
output_parsers (currently doesn't exist)
input_generators

I tend to favor the flat structure, although that means right now the options are just input_parsers and input_generators - which seems slightly redundant, but actually IMO nicer than the somewhat confusing generators.

* `get_structure_from_qeinput` -> shall we change the name to something simpler? is `get_structure` clear enough? or `parse_structure`? or should we put an underscore between `qe` an `input`?

Definitely. I think this opens up a separate discussion, see #42

* shall we rename the kwargs of the public methods/functions, where it might make sense? E.g. for the `__init__` of QeInputFile, probably it doesn't make sense that it's called `pwinput`. Maybe simply `input_file` or `input_file_content` or `input_content`? We might want to do a similar discussion more generally once we agree on which are the public methods

Yeah, input_content or just content seems good to me.

If you would like my 2 centimes, I would prefer the nested structure, were it not for the fact that you will run into the problem when importing from input you will get "keyword reserved" issues. So maybe the flat one works best here. Although I would definitely keep the underscore in that case.

If you would like my 2 centimes,

always appreciated :+1:

you will run into the problem when importing from input you will get "keyword reserved" issues.

Ha, I hadn't even considered that. Though it would technically work because input is a function, not a keyword - but shadowing a builtin is rarely a great idea.
What's still bugging me here is that get_parameters_from_cell actually doesn't really generate the input - not to the point where you could write it to disk, at least. So maybe input_converters would be a better name there. If we think it could also be used on output, bare converters could also work.
We could also ditch the "input" from the module name completely, and have the classes be importable as e.g. qe_tools.parsers.PwInputFile.

What's still bugging me here is that get_parameters_from_cell actually doesn't really generate the input - not to the point where you could write it to disk, at least. So maybe input_converters would be a better name there.

This makes me think that the actual "generators" are currently embedded in the CalcJob plugins of aiida-quantumespresso. It might be useful to look if we can factor that out and include here. This would make it a lot easier for consumers that do not want this mingled with AiiDA. The QE input generator tool on the materials cloud comes to mind. This now has to install aiida-quantumespresso just to build input file from some python values. We already factored this code out in aiida-quantumespresso to even make this possible

Absolutely agree - for now we can just design the naming here to make sure it fits when we move that over.
How about

parsers
generators
converters

?

Let's go with this


Add env var to skip initdb

I'm trying to build a data container to ship developer databases (up to date migrations, fixture data, etc which are managed elsewhere). We could use a docker-entrypoint-initdb.d script to move a bundled data folder to PGDATA (similar to what's suggested in #105), but then the entire initdb process was a (one time) waste.
I'm proposing a new USE_SEED_DB env var that would skip initdb and instead move everything in a "seed" directory to PGDATA. This would set the expectation that scripts in docker-entrypoint-initdb.d/ would act on the seed db and not a fresh one.
I'm willing to submit a PR for this.

We could use /docker-entrypoint-seed-db.d for example.

I've opted to use a data container based on scratch (or rather tianon/true since docker-compose requires a command).
Pro: image can be used without running (used to need to run docker-entrypoint.sh to set things up)
Con: mounted volume directory may not have 700 permissions (must being careful when creating data image).
I've submitted #110 to set 700 explicitly.


Issue with BxDolModuleProxy and Js/Css inclusion.

addJsCss doesn't work correctly via aMethodsToCallAddJsCss array. Issue appears in dynamic calls. To reproduce the issue do the following:

Add photo via Photos module.
Log out.
Go to Photos Home page.
Click with photo to see the preview popup.
Check author's thumbnail in Author block.

https://github.com/unaio/una/issues/2207


gateway-api: fix EnqueueForParentHandler

Please provide a description of this PR:
When parsing the owner references of gateway deployments/services, compare GroupKind rather than GroupVersion
Fixes #43332
which is a regression after bumping the gateway-api version

Should we also update the deployment and service templates?
  ownerReferences:
-  - apiVersion: gateway.networking.k8s.io/v1alpha2
+  - apiVersion: gateway.networking.k8s.io/v1beta1

Yes, everything should be on beta

In response to a cherrypick label: #43354 failed to apply on top of branch "release-1.16":
Applying: fix parent reference
Using index info to reconstruct a base tree...
M	pilot/pkg/config/kube/gateway/deploymentcontroller.go
M	pkg/kube/controllers/common.go
M	pkg/kube/controllers/common_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kube/controllers/common_test.go
Auto-merging pkg/kube/controllers/common.go
Auto-merging pilot/pkg/config/kube/gateway/deploymentcontroller.go
CONFLICT (content): Merge conflict in pilot/pkg/config/kube/gateway/deploymentcontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix parent reference
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #43362


[STORM-1529] Change default temp dir for workers to worker launch directory.

Allowing workers to create temp files unde  /tmp/ directory creates different challenges for monitoring disk usage and cleanup. So making "tmp" directory under workers directory, so it gets cleaned up in case of any deletion.

+1 setting the tmp directory to something tied to the lifetime of the worker should avoid leaks.

Either storm-hdfs is having some issues of it's own or it does not like this change.  I think it is probably that it is unstable.

@revans2 It does not look like its related. The hdfs tests have been for some time now. I noticed for #1075, the !storm-core builds failed - https://travis-ci.org/apache/storm/jobs/107157830

@kishorvpatil Needs upmerge.

@knusbaum, I addressed the conflicts.

+1

needs another upmerge.

@ptgoetz upmerged.

@revans2 @ptgoetz I have upmerged this again. I feel this is important fix to avoid letting workers write to /tmp and cause disk full issues. So we should put this in 1.x-branch as well.
If no objections, I will pull it into 1.x-branch as well.

+1 for merging to both branches.

Travis CI build failure is unrelated

@revans2 @ptgoetz
I created a separate Pull request for 1.x-branch as I can't merge ConfigUtils.  #1187. Please review.


The latest version does not compatiable to Python 3.9.x

Describe the bug
Does not support Python 3.9.x
I am not sure on Windows platform or MacOS, because now I fall in ubuntu 20.04.2.
It's fine with Python 3.8.x
To Reproduce
Steps to reproduce the behavior:

via pip install vibora[fast] or pip install vibora

Additional context
gcc and others raise

Ahahaha! No one has been dealing on this garbage for a long time - forget about it.

https://github.com/cirospaciari/socketify.py
Take a look, this project unfortunately is abandoned but socketify will be not


[BUG] -  Transparency lost of any transparent image

Lib Version // Project  libVersion = "3.3.6"

The bug
When you try to crop an image on which you already ha some transparent pixels(transparent BG) Library fills its background and transparency is lost in result
To Reproduce

Go to 'Gallery and select any picture or logo with transparent BG'
Click on 'Click Save The result as in video will be shown on same screen'
Scroll down to 'Nothing you will see issue there'
See error in the attached video

Expected behavior
Transparency of an image should not be lost
Media
https://user-images.githubusercontent.com/36961360/146167953-4f28c265-9a09-496c-8fa8-d4e1ecbf7402.mp4
Smartphone (please complete the following information):

Device: [e.g. Techno Camon 15]
OS: [Android 11]

Additional context
NONE

Hey @Mr-Ramzan could you try it on the latest release?

Another point, did you setup the file type?  setOutputCompressFormat(Bitmap.CompressFormat.PNG)

Yes same issue
With latest code

Another point, did you setup the file type? setOutputCompressFormat(Bitmap.CompressFormat.PNG)

I just tested same issue

@Mr-Ramzan could you provide the image you are using so I can test later with the same? Thanks!

Hey! not sure what you did to enable PNG format, but check my images... this is what a changed.
And check the video. working for me

https://user-images.githubusercontent.com/15942449/146196600-2523878f-a6c5-472b-99fe-8dd6c1a5349a.mp4

        customCropImage.launch(
            options {
                setScaleType(CropImageView.ScaleType.CENTER)
                setCropShape(CropImageView.CropShape.OVAL)
                setGuidelines(CropImageView.Guidelines.ON)
                setAspectRatio(4, 16)
                setMaxZoom(8)
                setAutoZoomEnabled(false)
                setMultiTouchEnabled(false)
                setCenterMoveEnabled(true)
                setShowCropOverlay(false)
                setAllowFlipping(false)
                setSnapRadius(10f)
                setTouchRadius(30f)
                setInitialCropWindowPaddingRatio(0.3f)
                setBorderLineThickness(5f)
                setBorderLineColor(R.color.black)
                setBorderCornerThickness(6f)
                setBorderCornerOffset(2f)
                setBorderCornerLength(20f)
                setBorderCornerColor(RED)
                setOutputCompressFormat(Bitmap.CompressFormat.PNG)
                setGuidelinesThickness(5f)
                setGuidelinesColor(RED)
                setBackgroundColor(Color.argb(119, 30, 60, 90))
                setMinCropWindowSize(20, 20)
                setMinCropResultSize(16, 16)
                setMaxCropResultSize(999, 999)
                setActivityTitle("CUSTOM title")
                setActivityMenuIconColor(RED)
                setOutputUri(customUri)
                setOutputCompressFormat(Bitmap.CompressFormat.PNG)
                setOutputCompressQuality(50)
                setRequestedSize(100, 100)
                setRequestedSize(100, 100, CropImageView.RequestSizeOptions.RESIZE_FIT)
                setInitialCropWindowRectangle(null)
                setInitialRotation(180)
                setAllowCounterRotation(true)
                setFlipHorizontally(true)
                setFlipVertically(true)
                setCropMenuCropButtonTitle("Custom name")
                setCropMenuCropButtonIcon(R.drawable.ic_gear_24)
                setAllowRotation(false)
                setNoOutputImage(false)
                setFixAspectRatio(true)
            }
        )

I have also set compress formate to PNG but it shows a black background ...

It works when I change the Output Compress format thank you very much

I think you are changing the wrong place of the code. Could you change same places I changed and do the same flow?

you may want to have less options for the test, since you have setOutputCompressFormat(Bitmap.CompressFormat.PNG) twice XD

I think you are changing the wrong place of the code. Could you change same places I changed and do the same flow?

you may want to have less options for the test, since you have setOutputCompressFormat(Bitmap.CompressFormat.PNG) twice XD

I changed the output compress format in crop options and it worked as expected.

Thank you for quick Support. Let me know if you want to close the issue or please close by yourself.

Great that is working =D, welcome!


Possible misspelling of word: enough

The error message contact_not_enought_data should be contact_not_enough_data.
I didn't open a PR because at this point I'm not sure if this has backward compatibility issues; as in people expecting a specific error string in their code.
Places where this is used:
https://github.com/onelogin/python-saml/search?q=contact_not_enought_data&unscoped_q=contact_not_enought_data

Since its not a critical issue, I think we are ok fixing the typo. do you have a PR?


Top Profiler Structured Diff

Structured Profile Diff and Structured Col Profile Diff in one PR because its easier to review.
Let me know if I mocked too much.

Work in progress because I'm going to abstract it to the base profiler

And I need type instance checking

Ready for review!


Improve command line/uri documentation

Follow up activities for command line support in ADS:

Add docs to wiki about launch args (both URI & Command Line) - I don't believe we have them documented anywhere and that'd be helpful to point people to for learning what is available and how to use them
Make sure that all these args are added to the help command (azuredatastudio -h). There's some listed (database, server, user, etc.) but not all of them. Maybe even regroup them to be under a "Connection Options" section?

Originally posted by @Charles-Gagnon in https://github.com/microsoft/azuredatastudio/pull/23104#pullrequestreview-1424801765

Fixed by #23312


UWP7

Key
Value

View
https://database.shabados.com/sources/2/page/157/line/18

Source
Sri Dasam Granth

Page
157

ID
UWP7

Line
rUp AnUp srUp Apwrw ]

Related #1450 , not actually pertaining to line UWP7


[datasketches-cpp] New port

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Close #32060

Usage test passed with following code on x64-osx-release
#include <iostream>
#include "DataSketches/count_zeros.hpp"

int main() {
    uint32_t a = 45323454;
    std::cout << "leading_zeros  : " << (int)datasketches::count_leading_zeros_in_u32(a) << std::endl;
    std::cout << "trailing_zeros : " << (int)datasketches::count_trailing_zeros_in_u32(a) << std::endl;
    return 0;
}

cmake_minimum_required(VERSION 3.15)
project(test_csv_parser)

set(CMAKE_CXX_STANDARD 17)

find_package(DataSketches CONFIG REQUIRED)
add_executable(test_data_sketches main.cpp)
target_link_libraries(test_data_sketches PRIVATE datasketches)

Should the name of this port be datasketches-cpp or datasketches ?

Usage passed on x64-windows.

If you want I'll make those edits for you, but before I do that want your thoughts.

@BillyONeal
That looks good for me. Thanks！

Thanks for beating me to the edits 😅


Error: While installing 'fbsimctl' dependencies

I am following getting started documentation. I got stuck on Step 1 -> 3. Install fbsimctl.
I am getting errors :

error: 'FBSimulatorControl/FBSimulatorControl.h' file not found

Please check screenshot for details

The current requirement of installing from HEAD, while the project is unstable in the master branch is a particularly bad combination. There should be stable releases so that specific versions can be pinned for installing.

@LeoNatan - Is there any workaround, like installing from specific tag or commit hash

Having the same issue. How can I install a specific version?

Quick update, I followed the instructions for installing a custom version. I picked a commit hash where it still worked. Then I updated my circle.yml file:
  - git clone https://github.com/facebook/FBSimulatorControl.git
  - cd FBSimulatorControl && git checkout 2a461c4e31f12b29974a5a6d184126c2526c62d1 && ./build.sh fbsimctl build output && cd ../
  - mv FBSimulatorControl/output/Frameworks/* /usr/local/Frameworks/
  - mv FBSimulatorControl/output/bin/* /usr/local/bin/

It would be great to have one semi stable version available. Then the --HEAD part can be omitted.

We just released idb. a new tool that improves significantly over fbsimctl. We recommend switching over. As part of our renewed commitment to this repo we are cleaning up old issues and will be monitoring and reviewing more closely from now on. if you still think this issue is relevant feel free to reopen


lib: bandage close of closed channel #trivial

The close(done) was panicking occasionally even though I cannot
find any other reference to that channel.
Could be a bug in sync.Once or something weirder (is the once being
copied in a way that breaks the pattern somewhere?).

  Generated by :no_entry_sign: Danger


Add boost parameter to the prefix query

Description
The prefix query can set boost parameter, but it is not mentioned in the documentation.
boost is parsed in the following part:
https://github.com/opensearch-project/OpenSearch/blob/07fab0f89ebe9007e04b2fdd775cba0b4a9ffae1/server/src/main/java/org/opensearch/index/query/PrefixQueryBuilder.java#L178
boost parsing is included in the test case:
https://github.com/opensearch-project/OpenSearch/blob/07fab0f89ebe9007e04b2fdd775cba0b4a9ffae1/server/src/test/java/org/opensearch/index/query/PrefixQueryBuilderTests.java#L118
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 - Can you please review this contribution from a technical standpoint? Thanks!

I investigated the situation regarding the boost parameter for term-level queries, including prefix. Below is a table indicating where the boost is parsed and whether the boost parameter is explicitly documented:

Term-level query
Pasing in code
boost in doc?

exists
ExistsQueryBuilder.java L131
:x:

fuzzy
FuzzyQueryBuilder.java L294
:x:

ids
?found boost in test but not asserted
:x:

prefix
PrefixQueryBuilder.java L178
:x:

range
already stated in doc
:white_check_mark:

regexp
RegexpQueryBuilder.java L237
:x:

term
already stated in doc
:white_check_mark:

terms
already stated in doc
:white_check_mark:

term_set
TermsSetQueryBuilder.java L215
:x:

wildcard
already stated in doc
:white_check_mark:

Should I also add the boost parameter to the term-level query documentation other than prefix in this pull request? In that case, I will change the title and make some commit.


First day of week

Hi,
The week option works with 0 and 1 only (for me)

Hi @lerendier
Do you want to disable days except 0 and 1 day of weeks?
I'm sorry, but I'd like to ask you a little more detailed questions.
Thank you!

Hi,
thank you for contacting me. I would like the week to start on Saturday. I tried the option week: 6 but it does not work (same problem with the other days except 0 and 1; names of  days are displayed in the right order, but the days do not display. Thank you in advance for your answer.
Your Calendar is really beautiful!

Le 3 avr. 2017 à 16:25, PIGNOSE<EMAIL_ADDRESS>a écrit :
Hi @lerendier
Do you want to disable days except 0 and 1 day of weeks?
I'm sorry, but I'd like to ask you a little more detailed questions.
Thank you!
—
You are receiving this because you were mentioned
Reply to this email directly, view it on GitHub, or mute the thread.

@lerendier I think u can only Monday/Sunday can be the first day of the week. with week:0 or week:1

Hi @lerendier
I will check this issue right now.
I'm sorry about late reply!!

@lerendier
This seem be an issue about reference negative index. (core issue)
I fixed the issue at v1.4.13.
Thank you for reporting 👍

This issue will be closed tomorrow.
If you have other issues, Please create a new issue 🍺


Reader\XLSX: retrieve formulas as-is, but keep computed value available when possible

Fix https://github.com/openspout/openspout/issues/168

Hi there,
Not sure if you have noticed but this breaks backwards compatibility. When just using getValue on the cell without knowing what the cell's implementation is (here: a FormulaCell) it will now return the formula instead of the computed value. My code still expects to receive the computed value here.
I suggest to keep getValue returning the computed value and replace getComputedValue to getFormulaValue and return the formula only when this method is invoked.
Best regards
Markus

Not sure if you have noticed but this breaks backwards compatibility. When just using getValue on the cell without knowing what the cell's implementation is (here: a FormulaCell) it will now return the formula instead of the computed value.

This is expected: the old behaviour was a bug. Idempotency is important: if I read and re-write the file, I should get the exact same file back; this PR gets this goal right.

My code still expects to receive the computed value here.

The computed value may or may not be there, it is not guaranteed. Checking for FormulaCell type and getComputedValue() return value to be not-null is expected to be required for a reliable usage.

Fair enough. That also makes sense. I will adapt.
Thank you!


Add AsyncBoundary (handling useAsync with error/progress)

Signed-off-by: Gustaf Räntilä<EMAIL_ADDRESS>Async fetching wrapper around error/progress/value state
Following the typesafe provider+hook creation scheme in #7265, this PR provides a way to smoothly decouple async work (e.g. fetching) from displaying error/progress and eventually/hopefully the result view. In the sub components one can then useSomething and get the value synchronously.
Where it makes sense, potentially where the actual work hooks are defined, e.g. the actual fetching:
import { createAsyncBoundary } from '@backstage/core-components';

export const {
  AsyncBoundary: UsersBoundary,
  useAsyncValue: useUsers,
} = createAsyncBoundary<UserType[]>();

Then in a component that wants to display users:
const asyncUsers = useAsync( fetchUsers ); // This is implemented somewhere

<UsersBoundary asyncValue={ asyncUsers }>
  <UserList />
</UsersBoundary>

where UserList can get the users using useUsers synchronously
function UserList() {
  const users = useUsers();

  return <ul>{ users.map( user => { ... } ) }</ul>
}

There's no magic here, just abstracting the if/then <Progress> / <Alert> using the app-specific Progress (perhaps we should have one for Alert too?). Not always is it practical to write that manually, because you'll then have to pass the value as props deep down the component stack (maybe cross Routes), and so sometimes Providerifying such async logic with the progress/error boundary is helpful.
The provider has the optional props for specifying custom error/progress components when necessary, but will fallback to MUI Alert and the app-defined Progress.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Your last example there, would be an interesting solution too. Not sure about the name, perhaps something like useIdleComponent...
Anyway, that would surely reduce a lot of if/else code, and also ensure the right progress (and potentially error/alert) components are being used.
I don't think these contradict each other though. The thinking behind the AsyncBoundary, which perhaps should be renamed AsyncProvider, is the provider part. The part that, you want to load some value in the component tree, that sub components can read, without having to pass it as props all the way down everywhere. This is what providers do, obviously.
However, when the value is ultimately async (network or whatnot), you need to handle both the progress/error fallbacks, as well as setting up a provider.
This would do it all.

I'm also a bit worried that we're not actually providing a lot of utility here

Yeah this could be. I hadn't done any digging, but doing that now, these are files which have both useAsync and wither useContext or provider (case-insensitive) in them:
packages/core-app-api/src/app/App.tsx
plugins/catalog-react/src/hooks/useEntity.tsx
plugins/catalog-react/src/hooks/useEntity.tsx
plugins/catalog-react/src/hooks/useEntityListProvider.tsx
plugins/catalog-react/src/hooks/useEntityListProvider.tsx
plugins/catalog-react/src/hooks/useEntityTypeFilter.tsx
plugins/git-release-manager/src/GitReleaseManager.tsx
plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx
plugins/search/src/components/SearchContext/SearchContext.tsx
plugins/search/src/components/SearchContext/SearchContext.tsx

I can't say how often this type of code occurs, but the more ui plugins talking to a backend, the more we'll likely see this kind of logic: https://github.com/backstage/backstage/blob/master/plugins/git-release-manager/src/GitReleaseManager.tsx#L85-L105 which is exactly what could be generalized. This example also shows Progress being imported from @backstage/core-components rather than from the app context. This is really common (~80 places by quick grepping).
Would it make sense to first have a PR dealing with the async fallbacks? If so, what should the hook name be?


Consider add/change to task's comments as a "task modified" event for webhooks.

Feature request: consider creation or modification of a task's comments to be a modification to the task, and trigger the "task modified" webhook, with the comment data in the payload of the event.
Motivation: Our team is using kanboard for internal project management (and we love it!), but we have to tie into an institution-wide tracking system (RT). We wrote code to equate a task in kanboard with a ticket in RT, and have it working so a change in one system automatically creates the comparable change in the other -- except that creating or modifying a comment in kanboard does not trigger a "task modified" webhook. Thus we cannot keep RT synchronized with comments added to kanboard tasks.

The webhook system have been changed in the current development branch. Now, all internal events of Kanboard are sent to a webhook url if defined. That will be part of the next stable release.
The doc is here: https://github.com/fguillot/kanboard/blob/master/docs/webhooks.markdown

In your case, you can synchronize comments now.


FAQ broken

http://pombase-dev.bioinformatics.nz/faq
https://www.pombase.org/faq

It looks OK to me.  What's broken?

ignore me, I thought I could see all of the questions on the main page..

(previously)


[DNM][oap-native-sql][Scala] fallback to row based execution on unsupported kernel

Signed-off-by: Yuan Zhou<EMAIL_ADDRESS>What changes were proposed in this pull request?
fallback to row based plan if there are unsupported columnar kernel
How was this patch tested?
manually tested

https://github.com/Intel-bigdata/OAP/pull/1549


Move all hardcoded parameters to configuration file

Currently, many parameters are hard-coded. All should be moved to a config.yaml or config.json file.

Solved in #34


postgres_pass Inheritance in nested locations

Hello there!
I think, it would be great to make default behaviour to inherit postgres_pass setting from top-level location to it's nested locations.
For example, I assume that to work fine, instead of throwing 404:
location /db {
  postgres_pass   db;
  internal;
  location /db/test {
    postgres_query "SELECT id,name from users";
  }
}

Thanks a lot!

By the way, I found strange thing. ngx_postgres_module.c contains following in ngx_postgres_merge_loc_conf function:
 358     if ((conf->upstream.upstream == NULL) && (conf->upstream_cv == NULL)) {
 359         conf->upstream.upstream = prev->upstream.upstream;
 360         conf->upstream_cv = prev->upstream_cv;
 361     }

And as I looked in ngx_postgres_conf_pass, it (postgresql_pass) sets either conf->upstream.upstream or conf->upstream_cv based of value type (is it complex or not), so if one of them set in the location, another should be NULL. And if neither set in the location, then code quoted above should (?) merge the ones that set on previous nesting level location (and so on for the top level). But somewhy it does not do that.
// by the way, it'd be nice to also allow _pass on server{} level.


make file path writable

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   88.02%   88.02%
=======================================
  Files          47       47
  Lines        3373     3373
=======================================
  Hits         2969     2969
  Misses        404      404

Impacted Files
Coverage Δ

vent/core/rq-worker/file_watch.py
52.94% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1df7b...a2e071f. Read the comment docs.

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   88.02%   88.02%
=======================================
  Files          47       47
  Lines        3373     3373
=======================================
  Hits         2969     2969
  Misses        404      404

Impacted Files
Coverage Δ

vent/core/rq-worker/file_watch.py
52.94% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1df7b...a2e071f. Read the comment docs.


Remove a way?

How do I remove a Way?
Each time the user looks for a new way, it joins instead of deleting and adding the new one.

Each addWay() calls will make empty the container.


Support for newer Amazon EC2 types

Rancher versions:
rancher/server: v1.5.9
Environment Template: Cattle
Steps to Reproduce:
Go through the machine driver steps to create an instance managed by rancher
Results:
Unable to select newer instance types (such as r4). Screenshot as attached

Workaround (for now)
Overwrite the HTML code to allow such an option, seems to be working somewhat for now (YMMV)

@PicoCreator thanks for the workaround hint! We needed r4 also just now.

There is annoyingly no (1st-party) API to list the instance types, so there's a hardcoded list in the UI.
Adding the missing ones, and also grouping by type..

Version - 1.6.6-rc3
Verified fixed


Saving a file in VSCode doesn't reformat a line with a comment on a JSX property that that's too long, but biome format --write does

Environment information
CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.17.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/9.6.7"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 false

Formatter:
  Format with errors:           true
  Indent style:                 Space
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              false
  Bracket same line:            false
  Quote style:                  Single
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           Auto

JSON Formatter:
  Enabled:                      true
  Indent style:                 Tab
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Double

Workspace:
  Open Documents:               0

Configuration
{
	"$schema"<EMAIL_ADDRESS>	"organizeImports": {
		"enabled": false
	},
	"files": {
		"ignore": [
			"*.dump.json",
			"*.merge.json",
			"*.ambr",
			"node_modules",
			"build/",
			"package-lock.json"
		]
	},
	"vcs": {
		"enabled": true,
		"clientKind": "git",
		"useIgnoreFile": true
	},
	"formatter": {
		"formatWithErrors": true,
		"indentStyle": "space"
	},
	"javascript": {
		"formatter": {
			"quoteStyle": "single"
		}
	},
	"json": {
		"parser": {
			"allowComments": true
		},
		"formatter": {
			"enabled": true,
			"indentStyle": "tab"
		}
	},
	"linter": {
		"rules": {
			"a11y": {
				"recommended": false
			},
			"correctness": {
				"noUnusedImports": "error",
				"noUnusedVariables": "error",
				"useExhaustiveDependencies": "info",
				"useHookAtTopLevel": "error",
				"useJsxKeyInIterable": "off" // This rule has additional options in ESLint that aren't available in Biome yet.
			},
			"performance": {
				"noAccumulatingSpread": "error"
			},
			"style": {
				"noNonNullAssertion": "info",
				"noParameterAssign": "info",
				"useEnumInitializers": "off",
				"useFragmentSyntax": "error",
				"useImportType": "off" // We do this in ESLint to avoid a syntax error if run at the same time as "organize imports".
			},
			"suspicious": {
				"noArrayIndexKey": "warn", // Override severity while mitigate existing violations
				"noAssignInExpressions": "off", // This is okay inside useCallback
				"noConfusingVoidType": "off", // `void` is the correct return type for RTKQ. Ideally only disable in that folder.
				"noEmptyBlockStatements": "error",
				"noExplicitAny": "off", // Rest args are fine, but I don't see that option here. Also, we are still running the ESLint type-aware version of this rule.
				"noImplicitAnyLet": "info",
				"noShadowRestrictedNames": "off", // Don't want to warn on MUI's Error Icon
				"noSkippedTests": "error",
				"useAwait": "warn" // TODO: Bump to error after fixing the 4 violations
			}
		}
	}
}

Playground link
https://biomejs.dev/playground/?lintRules=all&code=IAAgACAAIAAgACAAPABGAG8AbwAKACAAIAAgACAAIAAgACAAIABiAGEAcgA9AHsAJwB0AGgAaQBzACAAaQBzACAAYQAgAHIAZQBhAGwAbAB5ACAAbABvAG4AZwAgAHAAcgBvAHAAZQByAHQAeQAgAHQAaABhAHQAIABpAHMAIABlAHgAdABlAG4AZABpAG4AZwAgAHAAYQBzAHQAIAB0AGgAZQAgAGwAaQBuAGUAVwBpAGQAdABoACAAbABpAG0AaQB0ACcAfQAgAC8ALwAgAFQAaABpAHMAIABpAHMAIABhACAAYwBvAG0AbQBlAG4AdAAKACAAIAAgACAAIAAgAC8APgA%3D
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

UPDATE: I believe this was due to the Biome LSP not restarting itself after I changed lineWidth in my config.


fix: Ensure that all edX files get uploaded

What are the relevant tickets?
Addresses https://github.mit.edu/IR/simeon-internal/issues/44
Description (What does it do?)
Because the logic is iterating over the ResultsDir resource, there is no guarantee that the files are actually present in the resource as created in that step. This changes to accept a list of DagsterPath objects that get iterated over and recursively uploaded to be more explicit about passing of files.
How can this be tested?
Run the open edX pipelines and ensure that all of the generated CSVs get properly uploaded to S3
Additional Context
The results_dir resource definition was recently refactored to use the new Pythonic interface. That likely led to some implicit changes in how it functioned, leading to the implicit passing of files via the resource not functioning properly anymore.

Yes, a ticket to capture the scope of some tests would be useful.


Handle live video being disabled during stream

During testing of live chat a bug was logged that the video freezed up but that audio and chat continued. I did some testing on a not-so-great 3G connection and was able to reproduce this.
It seems that OpenTok's OTSubscriberDelegate (which we hadn't previously implemented) sends subscriberVideoDisabled and subscriberVideoEnabled with a reason argument which in this case is qualityChanged.
I've changed our LiveVideoPlaybackState.playing state to have an associated Bool value of videoEnabled so that we can handle this.
If OpenTok disables the video we hide the view and display text indicating that video will resume when the connection improves. Although I didn't see it resume during my testing, OpenTok does say that the video may resume.


analytics

I noticed a couple of weeks ago we had a bumper access day, (~558 I think in one day)
I took a screen-shot last night to remind me to tell you all, and because we were very close to
0.5M  visitors.
Then this morning everything has dropped. See:

Is that normal?

Is that normal?

It looks OK now.

It definitely dropped (substantially).
We were on ~490,000  page views and we dropped back to  462,000
maybe GA recalculated ... just wondered.

What time period were you looking at?  It says 512,330 when I look at Oct 20, 2017-Jul 15, 2018.

Durrr, I was stuck in June!
Well, we have over half a million page views. Woo Hoo !


[Select] Issue tailwindcss className is not working.

I am using

Next 14.1.0
radix-ui/themes 2.0.3
tailwindcss 3.3.0

Seems like className does not work inside select.root.

I want to give select.root a min width. Is there a way I can achieve this?

You want to put a class on the Trigger element, because the Root part doesn't render any HTML.


fix: remove parameter $relative in uri_string()

Description
Fixes #7124

remove the parameter $relative which does not work

Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

I had missed this breaking change.
https://github.com/codeigniter4/CodeIgniter4/blob/v4.3.1/tests/system/Helpers/URLHelper/CurrentUrlTest.php#L223-L237


Add couchdb conf dir

Description
This is to persist configurations for CouchDB.
The configuration directory is configurable.
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

I am testing the various clustering scenario with this version.

I have tested the followings.

Deploy a CouchDB cluster with 3 nodes.
Restart one of the nodes.
Stop all nodes and start them again.
Deploy a new cluster with 2 nodes and add another node by running the ansible script again with --limit db[2:2] option.

In all cases, a cluster was made, the cluster was stable after the restart, and a new node successfully joined the existing cluster.

Codecov Report

Merging #5285 (e32be04) into master (1fbfd6b) will decrease coverage by 75.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5285       +/-   ##
==========================================
- Coverage   79.81%   4.57%   -75.24%
==========================================
  Files         238     238
  Lines       14154   14154
  Branches      607     607
==========================================
- Hits        11297     648    -10649
- Misses       2857   13506    +10649

Impacted Files
Coverage Δ

.../main/scala/org/apache/openwhisk/core/WarmUp.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/scala/org/apache/openwhisk/utils/JsHelpers.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...scala/org/apache/openwhisk/common/Prometheus.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...scala/org/apache/openwhisk/core/FeatureFlags.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...ala/org/apache/openwhisk/common/ConfigMXBean.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...la/org/apache/openwhisk/http/BasicRasService.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/common/ConfigMapValue.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/core/entity/WhiskAuth.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

.../org/apache/openwhisk/core/entity/EntityPath.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbfd6b...e32be04. Read the comment docs.


(maint) Add ruby-head to .travis.yml

We might not want to include this so early in the year just because it chews up bandwidth, but I was curious to see how it behaved given that 2.4.0-preview1 was tagged: https://www.ruby-lang.org/en/news/2016/06/20/ruby-2-4-0-preview1-released/.

CLA signed by all contributors.

Fun, msgpack is going to need an update to build against 2.4.0. It may be due to https://bugs.ruby-lang.org/issues/12005
Installing msgpack 0.7.6 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
    current directory: /home/travis/.rvm/gems/ruby-head/gems/msgpack-0.7.6/ext/msgpack
/home/travis/.rvm/rubies/ruby-head/bin/ruby -r ./siteconf20160621-4953-5q7k55.rb extconf.rb
checking for ruby/st.h... yes
checking for st.h... yes
checking for rb_str_replace() in ruby.h... yes
checking for rb_intern_str() in ruby.h... yes
checking for rb_sym2str() in ruby.h... yes
checking for rb_str_intern() in ruby.h... yes
checking for rb_block_lambda() in ruby.h... yes
checking for rb_hash_dup() in ruby.h... yes
checking for rb_hash_clear() in ruby.h... yes
creating Makefile
To see why this extension failed to compile, please check the mkmf.log which can be found here:
  /home/travis/.rvm/gems/ruby-head/extensions/x86_64-linux/2.4.0/msgpack-0.7.6/mkmf.log
current directory: /home/travis/.rvm/gems/ruby-head/gems/msgpack-0.7.6/ext/msgpack
make "DESTDIR=" clean
current directory: /home/travis/.rvm/gems/ruby-head/gems/msgpack-0.7.6/ext/msgpack
make "DESTDIR="
compiling buffer.c
compiling buffer_class.c
compiling core_ext.c
core_ext.c: In function ‘MessagePack_core_ext_module_init’:
core_ext.c:135:22: error: ‘rb_cFixnum’ undeclared (first use in this function)
core_ext.c:135:22: note: each undeclared identifier is reported only once for each function it appears in
core_ext.c:136:22: error: ‘rb_cBignum’ undeclared (first use in this function)

I filed https://github.com/msgpack/msgpack-ruby/issues/120


Add postcss-preset-env to Angular build process / allow for configuring custom PostCSS plugins

Command
build, serve
Description
The Angular docs mention The Angular CLI uses Browserslist to ensure compatibility with different browser versions. And while this story works great in the Javascript side, the CSS story is not as good.
Currently for processing CSS PostCSS is used during the build process, and the only plugin used for increasing browser compatibility is the use of the autoprefixer plugin.
That would be fine if the build process allowed configuration of the postcss plugins being used but not allowing that severely limits the extent of browser support which could have been otherwise extended using plugins like postcss-preset-env. For example, in our use case we are required to support Chrome version 80 but since more and more UI libraries like PrimeNg are moving towards use of @layer which is not supported by earlier browsers it is proving impossible for us to upgrade to use newer versions of these UI libraries.
Describe the solution you'd like
Similar to the configuration being done for Tailwind it could be possible to add support for loading postCss configuration from the standard postcss.config.js file.
There may also be need to either merge / override the default configuration in case the postcss config is provided.
Describe alternatives you've considered
The only alternate that seemed to work for us at the moment was to switch to angular-builders/custom-webpack for building / serving the application and loading the postcss.config.js file using the postcss-loader in webpack.
However the drawback of that was that we could no longer take advantage of the faster Vite / ESBuild speeds that the Angular v17 provides by default.

Hi @PrinceGupta1999,
Appreciate your feature request, but enabling postcss configuration isn't in our plans currently. At this stage, postcss is utilized solely within Angular CLI for tailwind CSS, as this forces a slower path for stylesheet compilations.
Regarding, adding a postcss plugin in this case will not yield the desired outcome. As the application build pipeline doesn't transform CSS within components present in libraries. Instead, components CSS in libraries is processed based on their configured minimum browser support version before publishing to NPM.
It's important to note that the esbuild-based pipeline does handle the transformation of various CSS syntaxes, such as nesting, among others without the need of postcss.
Angular only officially supports the latest 2 major versions of Chrome currently being 118 and 119. See https://angular.io/guide/browser-support for more information about supported browsers.
See: https://github.com/angular/angular-cli/issues/8427#issuecomment-773557085 and https://github.com/angular/angular-cli/issues/8427 for more context about why we do not support custom postcss plugins.


Update torchtune pin to Llama 3.2 Release

This solves a good chunk of the issues with CI and enablement.
Landing first and will iterate onthe remaining errors


Send Alt (meta) key in integrated terminal

I have keyboard shortcuts under my shell zsh and tmux, because of integrated terminal not sending Alt (or meta) key, they doesn't work. Instead of they are making special characters like √©π, which is default behaviour. It would be cool if Alt key works like in other terminal emulators.
Sorry if duplicate, searched but I couldn't find related issue.

VSCode Version: 1.11.12
OS Version: 10.12.4

Duplicate https://github.com/Microsoft/vscode/issues/11314


[v1.0][W11-B2] MVP

@qwlai @tinyjy94 @slothhy @chanyikwai
Good job on this one!
Some comments added. Please take a look and update the document as necessary.
Don't close this pull request; we will use it for further reviews later in the semester.

@qwlai @tinyjy94 @slothhy @chanyikwai
For those features you want to implement as a part of later milestones, you were supposed to think through and write the command format and usage examples now!
The idea is to get you to think through the product from an end-user perspective, and develop it accordingly.
Additionally, I would want you to mention the following in your Developer guide

For each team member what are the features (major and minor) you are proposing?
Within the scope of the project, how does it fit in (just a one or 2 line summary)
Please do this by end of day Monday 19 March.


After waking up computer from Sleep, Macvim will try to close

Steps to reproduce
Open a file with MacVim
Lock computer and wait 5-10min
Unlock computer
Macvim will be either closed or a popup will appear to confirm if you want to close MacVim with unsaved buffers.
Expected behaviour
I expect MacVim to no close itself.
This only happen with MacVim hence I think it is an issue with MacVim...
I've tried to look at debug logs but I don't see anything useful.
Maybe you guys have an idea how to trace back the event that was sent to MacVim ?
Version of Vim and architecture
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 12 2023 09:31:27) macOS version - x86_64 Included patches: 1-1897 Compiled by GitHub Actions
MacVim r178 (Vim 9.0.1897)
Environment
MacOs Sonoma 14.1.1 (23B81)
Iterm
How MacVim was installed
Downloaded last release via Github
Logs and stack traces
No response
Vim configuration where issue is reproducable
No response
Issue has been tested with given configuration

[X] by running MacVim.app from GUI macOS interface
[ ] by running vim/gvim/etc installed by MacVim
[ ] by running other versions of vim (e.g. /usr/bin/vim)

Issue has been tested with no configuration

[X] by running mvim --clean (or gvim, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, supplied by MacVim distribution)
[ ] by running vim --clean (in terminal, other suppliers, e.g. /usr/bin/vim)

Other conditions

[ ] The both Homebrew packages "vim" and "macvim" are installed

That's weird. Never had that happen to me before. What kind of computer do you have (MacBook, Mac Mini, Apple Silicon versus Intel, year of your model, etc)? Do you have any apps installed that could interfere with keyboard / etc (e.g. BetterTouchTool)? Do you have any externally connected devices?
The popup seems to indicate something actually caused MacVim to be closed rather than a crash. I'm imagining when this happens, you have no unsaved files? (Since unsaved files should have caused a popup)
Do it happen every time? Or sporadically?
Any plugins you are using?
Trace back events… Hmm, if debug logs don't prove useful, I'm not sure. This may need some research. It should be possible in theory. I would like to make sure I understand the nature of the issue first though (per my above questions).

Hi Ychin,
Thank you very much for the quick response!

What kind of computer do you have (MacBook, Mac Mini, Apple Silicon versus Intel, year of your model, etc)?

I have a 2020 MacBook using Intel.

Do you have any apps installed that could interfere with keyboard / etc (e.g. BetterTouchTool)?

I do. I use hammerspoon hmmm
https://github.com/Hammerspoon/hammerspoon

Do you have any externally connected devices?

It happens without any externally connected devices.

Do it happen every time? Or sporadically?

It happens everytime.

I forgot to add the logs... my bad.
for macvim-clean-logs, I started mvim with --clean and waited 10min after locking the computer at 10:34.
for macvim-logs, I started mvim with its usual config and waited 10min after locking the computer at 10:15.
macvim-clean-logs.txt
macvim-logs.txt

After a bit more troubleshooting, it seems to happen only when the MacVim window is hidden.
To reproduce:

hide MacVim with cmd + h
lock computer
wait 5-10mini
unlock computer
macvim will either be closed or their will be the popup to close MacVim if their are any unsaved files.

How much memory do you have on your Mac? Do you tend to run up against memory pressure? I think this is due to Sudden Termination which I was surprised to see that MacVim isn't turning off, but I just want to make sure that's the case.

Sorry for the delayed answser @ychin
I have a 32GB laptop. Most of the time i'm at 50% usage.

I have been looking at this and I can't reproduce it. From what I can gather, macOS just decides to terminate MacVim. There is a feature called Automatic Termination but MacVim isn't using it so we shouldn't be randomly killed like that.
One blog post I found did suggest that this may happen if you are low on disk space, macOS will start purging cache files and somehow that will also kill hidden apps (with no way of configuring it). Would you happen to be low on space?
Other than that I can only imagine that Hammerspoon is having a bad interaction with MacVim here. You could try disabling it to see if it still happens.

The same thing has started happening to me in the past week or so.
@R0GG did you ever track it down?   Did it ever stop?
(I'm not low on disk space and I don't use Hammerspace, so neither of those would be the cause for me.)

Key
Value

MacVim
r178 · r179

macOS
13.6.4 Ventura

Machine
2020 M1 MacBook Pro

Memory
16 GiB

Free Disk Space
1 TB

I have been experiencing the same thing since at least the beginning of January 2024 on both r178 and r179.
Every time I wake my Mac I see the dialog:

Quit without saving?
There are modified buffers, if you quit now all changes will be lost. Quit anyway?

… or MacVim simply isn't running anymore if all the buffers were saved before my Mac went to sleep.
It happens even after a fresh boot when I have multiple gigabytes of free memory.
If I can help to debug this, please let me know. I run into this issue multiple times a day.
And thanks, @ychin, for all your work on MacVim!

That's not good. What kind of computer do you have @ronen ? I have not been able to replicate this but I have an M1 Max so it's not apples-to-apples. Let me think about it a little and see if there are better ways to gather the info or push out a pre-release build with the relevant data that we can gather.

hi @ychin, thanks for looking into it (and for everything MacVim :)
I'm running MacVim r179 (Vim 9.1.0), and here's my sys info:
System Software Overview:

  System Version: macOS 14.3.1 (23D60)
  Kernel Version: Darwin 23.3.0
  Boot Volume: Macintosh HD
  Boot Mode: Normal
  Secure Virtual Memory: Enabled
  System Integrity Protection: Enabled
  Time since boot: 13 days, 10 hours, 38 minutes

Hardware Overview:

  Model Name: MacBook Pro
  Model Identifier: MacBookPro16,1
  Processor Name: 8-Core Intel Core i9
  Processor Speed: 2.4 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 16 MB
  Hyper-Threading Technology: Enabled
  Memory: 64 GB
  System Firmware Version: 2<IP_ADDRESS>.1 (iBridge: 21.16.3049.0.0,0)
  OS Loader Version: 580~1337
  Activation Lock Status: Enabled

That said, I found this reddit thread from 2 years ago:  Mac randomly closing apps when sleeping -- no mention of MacVim but similar behavior for other seemingly random collection of apps including some of Apple's own apps.   The only solution offered in that thread is to reinstall the OS.
As it turns out I've got an upgrade to 14.4 waiting on deck, so I'll let that install and see if this behavior then goes away :)

Hi @ronen
I confirm I don't have this issue anymore. It disappeared without realizing it ...

And the issue is back again ... I'm on a corporate laptop so I wonder if it is caused by security toolings ...
Anyways we can trace this ?


Fix wrong image preview

The current image shows an installer image for.NET 6 like that;

It should show 7.0 instead. This PR fixes #7742

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aligoren sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for creating the PR @aligoren. It seems @dcwhittaker hadn't noticed you opened the issue and the PR at the same time. Since she made the updates already on #7745, I'll close this one. Thanks for reporting the problem!


OC version?

Is there a OC version?

Hi! What does OC stand for?

Oh, do you mean Objective-C?

YES, Objective-C.

Unfortunately no, but you should be able to use this within Obj-C just fine. Are you having problems with it?
Sent from my iPhone
On Aug 13, 2017, at 11:12 PM, Jian <notifications<EMAIL_ADDRESS>wrote:
YES, Objective-C.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/gonzalonunez/Skeleton/issues/6#issuecomment-322090862, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGG3RgPM_ZNokEzCWkfrJXABvgB9PcxOks5sX7sCgaJpZM4O0Ng2.
_____________________________________________________________________________________________________________________ This e-mail is for the use of the intended recipient(s) only. If you have received this e-mail in error, please notify the sender immediately and then delete it. If you are not the intended recipient, you must not use, disclose or distribute this e-mail without the author's prior permission. We have taken precautions to minimize the risk of transmitting software viruses, but we advise you to carry out your own virus checks on any attachment to this message. We cannot accept liability for any loss or damage caused by software viruses. Any views and/or opinions expressed in this e-mail are of the author only and do not represent the views of Technology Coast Partners LLC or any other company within its group.

Thank you, not yet.

Duplicate of #9, where I realized it's not compatible ☹


regression in insiders: VSCode calls stat() on FileSystemProvider before it creates a directory

VSCode Version: 1.33

This is a regression in VSCode Insiders 1.33
Repro steps:

Extension registers a vscode.FileSystemProvider for some scheme
User opens a workspace with this scheme
User tries to create folder in Explorer in that workspace

Expected:
VSCode calls 'createDirectory' on the vscode.FileSystemProvider to create the folder. This is what it does in the stable release.
Actual:
VSCode calls stat on the file system provider for the folder being created. Since the folder is not there yet, it throws vscode.FileSystemError.FileNotFound. Then VSCode displays "Path not found: /path_to_the_folder" error.
It doesn't call 'createDirectory' on the vscode.FileSystemProvider.
Call stack
fileError (c:\src\cascade\vscode\extension\src\workspace\workspaceProvider2.ts:484)
stat (c:\src\cascade\vscode\extension\src\workspace\workspaceProvider2.ts:173)
[ async function ] (Unknown Source:undefined)
stat (c:\src\cascade\vscode\extension\src\workspace\workspaceProvider2.ts:142)
$stat (extHostFileSystem.ts:225)
_doInvokeHandler (rpcProtocol.ts:399)
_invokeHandler (rpcProtocol.ts:384)
_receiveRequest (rpcProtocol.ts:304)
_receiveOneMessage (rpcProtocol.ts:226)
define.constructor._protocol.onMessage.e (rpcProtocol.ts:101)
fire (event.ts:584)
e (event.ts:74)
fire (event.ts:584)
s (ipc.net.ts:389)
e (ipc.net.ts:396)
fire (event.ts:584)
_receiveMessage (ipc.net.ts:671)
define.constructor._socketDisposables.push._socketReader.onMessage.e (ipc.net.ts:542)
fire (event.ts:584)
acceptChunk (ipc.net.ts:209)

@IlyaBiryukov sorry for that. I pushed a fix and will start new insider builds. The issue here was that I was not forwarding file system errors properly from an extension. Can you please verify that you are throwing a FileNotFound error from the FileSystemProvider.stat() method? As you can see here in our method that creates directories we now bubble up any error to the outside that we do not expect. In other words, we require a file not found error to actually create the folder.
As you might have seen already, I was refactoring the file service this milestone. This impacts most file service methods (such as createFolder, stat, create/move) but not (yet) reading/writing files or file watching (will work on that next month).
We are in endgame this week and I have a test plan item with 3 testers assigned to verify these changes, but feel free to assign me to issues directly if you encounter more things.

PS: one benefit of the work I did is that these things now work correctly for you:

move/copy of binary files across different file system providers
recursive copy of folders across and within providers

@bpasero When could we expect Insiders build with your fix to verify it on our side?
Here is the code that creates the error in stat() method in our vscode.FileSystemProvider implementation. I'm pretty sure it is FileNotFound with a custom error message.
    private static fileError(error: FileError, uri?: vscode.Uri) {
        let message;

        switch (error) {
            case FileError.FileNotFound:
                message = localize('fileError.FileNotFound', 'Path not found: $(path)');
                break;
            case FileError.FileExists:
                message = localize('fileError.FileExists', 'Path already exists: $(path)');
                break;
            case FileError.NoPermissions:
                message = localize('fileError.NoPermissions', 'Access denied: $(path)');
                break;
            default:
                message = '';
        }

        message = message || `Error (${error}): ${uri.path}`;
        if (uri) {
            message = message.replace('$(path)', uri.path);
        }

        const errorFunction: (message: string) => vscode.FileSystemError =
            vscode.FileSystemError[error];
        return errorFunction ? errorFunction(message) : new Error(message);
    }

I debugged through it and errorFunction was FileSystemError.FileNotFound().

@IlyaBiryukov the latest insiders version includes the fix, can you check?
If you are creating file system errors, you should check our helper methods for well known file errors, e.g. FileSystemError.FileNotFound(). That one will ensure it gets the right properties so that the main side can identify this error again.

Marking as verified based on feedback from @IlyaBiryukov


CLEWS-33473 convert metadata.confInterval into snake_case

We are going to remove the redundant attribute 'conf_interval', so that the v2/data endpoint is always using camelcase if responseType is set to 'list_of_series'. Updated lib.list_of_series_to_single_series() to convert the format of metadata.
https://bitbucket.org/grointelligence/gro/pull-requests/18324/clews-33473-remove-metadataconf_interval/diff

@cn1036 , I thought we were planning to remove confInterval and not conf_interval. What are we removing?

@joysaikat sorry for the confusion. updated description


[GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-XXX

Description

[X] Here are some details about my PR, including screenshots (if applicable):
HiveMetaStoreTest from Iceberg had some minor changes to the class that affect the order of metastore creation. This did not break our CI because iceberg tests run as a group in ABC order, so one of the tests was properly starting the metastore. But going forward, we should call the method and have an empty catch in case another test already init the hive metastore.

This would cause a NPE when the tests were run in isolation.
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3718 (bcb3ca3) into master (2c2ffac) will decrease coverage by 1.81%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3718      +/-   ##
============================================
- Coverage     46.79%   44.99%   -1.81%
+ Complexity    10793     2121    -8672
============================================
  Files          2143      412    -1731
  Lines         84528    17821   -66707
  Branches       9392     2171    -7221
============================================
- Hits          39557     8018   -31539
+ Misses        41360     8943   -32417
+ Partials       3611      860    -2751

see 1733 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Renamed Requirables to Requirable

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Renamed the nested classes.
Tests
N/A
Documentation
The single MB doc we have in Markdown is being updated in a PR by Jonas so it will be changed in that PR.
I'll be going over changing it in the GDocs right after lunch.
Primary reviewers
@JonasImprobable @samiwh

Any generated code changes to commit?

@jared-improbable Missed the newly separated test project, will add in a moment


Fixed #26058 -- Delegated filename generation in FileField to the Storage.

Related to #26382
First attempt at moving some logic performed by FileField which should
be actually performed by the Storage used. This changes makes it easier
to implement special kind of storages that do not rely on the operative
system (in particular os.path) which right now forces you to override
FileField.
All changes are backwards compatible for the exception of Storage.save
method, which was incorrectly replacing \ with / but was actually a
FileSystemStorage job. No tests were changed to make this change work
but anyone relying on this behaviour of Storage.save will start to get
unexpected results when running django on Windows.
The Storage class now has a new method 'generate_filename' which will
perform the old behaviour of FileField.generate_filename.
FileField.get_filename and FileField.get_directory_name are now
deprecated and should not be used since the job done by these two is now
done delegated to the Storage class. However FileField.generate_filename
will still exist (delegating the call to the Storage class) since it can
still be useful if other logic is required at the field level.
I have added tests for the deprecated methods and to the new
generate_filename at Storage, plus a custom Storage that simulates
(barely) an AWS S3 storage.
https://code.djangoproject.com/ticket/26058
https://code.djangoproject.com/ticket/26382

Well, some issues with docs and code styles! I will handle them tomorrow but it would be great to have some feedback about the actual code.

How should I handle the deprecated methods of django.db.models.FileField.get_directory_name and django.db.models.FileField.get_filename ? They are not documented so I can not actually add the sphinx link which leads me think if they are not even documented the deprecation shouldn't be documented, furthermore I guess I could actually remove the methods without deprecation at all?

buildbot, add to whitelist.

We likely do need to offer backwards-compatibility (or at least provide an upgrade guide) even though those methods aren't documented -- they seem to have widespread usage. Take a look at https://github.com/search?q=generate_filename(self%2C+instance%2C+filename)&ref=searchresults&type=Code&utf8=✓  to get a sense for what users are doing.

Well, this is hilarious... I submitted a patch for this two months ago and it's backwards compatible: https://code.djangoproject.com/ticket/26058#comment:3

@Korijn, Your idea might have some promise, but it's not really a patch for Django (which also requires tests and documentation). I don't think it makes sense to add a new field type for this but maybe we can borrow some ideas. Feel free to collaborate in any way going forward. Sorry if you felt ignored but it's a volunteer project except me and I cannot be everywhere at once.

@Korijn your idea is pretty much the same! I guess both of us had the same issues with those pesky hardcoded os.path calls on FileField. From what @timgraham said it looks like my initial approach of getting rid of get_filename and get_directory_name and just have it all inside generate_filename and delegate it to the storage backend would break anyone implementing get_filename and get_directory_name on their own File Fields which seems to be done a lot, even if those methods are not documented.
As a second idea as I said above perhaps the best is to keep the existing generate_filename at FileField and just add get_filename and get_directory_name at the Storage class and make the FieldField ones delegate to that one, but this seems like it would still need one more additional method since generate_filename still uses os.path code and so the solution would be compatible but I'm not really confortable with it as having just one method.
Seems like the people actually overriding the FileField get_filename and get_directory_name could still achieve the same using the new proposed storage method.
Do you have any other ideas that do not involve creating a whole new file field class? I will be thinking more on this tomorrow :)

Well, I don't think there's an easy and not ugly way to keep backwards support for the get_directory_name and get_filename methods of FileField when overriden on custom file models. The options are the one I posted above but that involves even more methods on the storage class and yet keep those two at the model level which shouldn't really be there.
I have changed/corrected the other commented points, unless someone comes with a better idea I don't think I will continue with this any further :)

I've rebased and made some cosmetic updates: https://github.com/django/django/compare/master...timgraham:26058?expand=1. I'm not entirely convinced that instance and upload_to should be passed to Storage.generate_filename(). Could we handle that logic in FileField.generate_filename() instead? My sense is that might be a better separation of concerns and will make overriding Storage.generate_filename() a lot simpler.

I have the same concern as you @timgraham but the issue is that the current code uses all the os.path.* calls. Would it be better to upload_to(instance, filename) and force_text(datetime.now().strftime(force_str(upload_to))) calls at FileField and then pass the processed file name to the storage and let it do all the os.path.* calls? If so the actual storage method should be more like generate final path or something as it is pretty much receiving a complete path.
Also, how do I include your changes on my repo?

Yes, I was thinking something along those lines. I haven't really dug into the code and the difference between those two branches (callable vs. non-callable upload_to) to understand the differences. If you get stuck, I can spend some more time looking at it.
You can pull my branch and then force push to your branch.

I have merged your changes @timgraham (rebased actually) and I'm getting flake8 errors. This is my fault because I accidentally rebased master rather than 26058 branch (which I then did).

I wouldn't use rebase. Checkout my branch locally and then push it to your remote branch with something like git push cristianocca local-branch-name:26382 --force (you might need to change cristianocca to origin or whatever you've named your own fork).

Updated in https://github.com/django/django/pull/6538. Please take a look and let me know if you have any concerns with the changes.


Project status

@takahirox  Hi, any plans to continue on this project? Also I'm interested in wgpu related consulting with funding, can you be up for this?

As there are PRs from me waiting from the end of July, and a bunch of reported issues, I don't think this project is alive anymore.

Do you plan to support a fork?

@madmaxio
Not really, as I have other projects currently on the table.
I could write a few bugfixes, but I'm not sure what would be the direction to take this project further.
As I see from the PRs, @takahirox has responded, so maybe not all hope is lost?

Update: All hope is actually lost.


Added my .py and .ipynb

Pull Request Template
Review Checklist
Reproducibility

[ ] Are the data downloaded in the code
[ ] Are paths created to ensure they work on all operating systems (using  os.path.join)
[ ] Are comments used to clarify the contents of the code that can’t be clarified using expressive variable and function names alone? (not too many comments - just enough)
[ ] Does the notebook run from start to finish?

PEP 8 standards & Code Readability
Functions

[ ] Do functions follow PEP 8 format conventions?
[ ] Are function docstrings clear (all  inputs and outputs clearly  described and defined)
[ ] Are function names expressive (the name describes what the function does)?
[ ] Are functions easy to understand and read?
[ ] How many tasks does each function do? (ideally a function does one thing well).

Package imports

[ ] Are standard modules (those included with the base  python install) vs. third party (related but externally developed tools) import groups correct with appropriate spacing in between each group?
[ ] Are variable names throughout the code, expressive?
[ ] Suggest changes if not, highlight what was done well
[ ] Is the code overall easy to understand and read? Are there things that would make it more clear / cleaner?

DRY Code

[ ] Are segments of code repeated in the file or is the code DRY?
[ ] Are loops used to optimize DRY code?
[ ] Are functions used to optimize DRY code?
[ ] Are there any areas that could be potentially improved (you can suggest improvements OR you can just highlight parts of the code where you suspect it could  be cleaner / more efficient.

Novel Approaches to Problem solving

[ ] Highlight any novel approaches to completing the assignment.

.

added img folder

@rmarovitz Please review this PR #53 (Canvas isn't working so let's try GitHub directly!)

@ryanboarman this is great, your functions and docstrings are really well done.
It looks like the .py file here was a re-named .ipynb. In the future if you want a .py file that can run, use the File > Export > as .py menu.


Refactored backwards compatibility tests to point to the OpenSearch <IP_ADDRESS> zip following deprecation of ODFE.

Signed-off-by: AWSHurneyt<EMAIL_ADDRESS>Issue #, if available:
https://github.com/opensearch-project/alerting/issues/498
Description of changes:
Refactored backwards compatibility tests to point to the OpenSearch <IP_ADDRESS> zip following deprecation of ODFE.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #510 (2b3d1b0) into main (3b8bfe7) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #510      +/-   ##
============================================
- Coverage     76.72%   76.69%   -0.04%
+ Complexity      176      174       -2
============================================
  Files           166      166
  Lines          8370     8370
  Branches       1232     1232
============================================
- Hits           6422     6419       -3
  Misses         1343     1343
- Partials        605      608       +3

Impacted Files
Coverage Δ

.../kotlin/org/opensearch/alerting/core/JobSweeper.kt
71.29% <0.00%> (-2.40%)
:arrow_down:

...destinationmigration/DestinationConversionUtils.kt
70.00% <0.00%> (ø)

...ain/kotlin/org/opensearch/alerting/AlertService.kt
78.46% <0.00%> (+0.47%)
:arrow_up:

...nationmigration/DestinationMigrationCoordinator.kt
65.95% <0.00%> (+2.12%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add documentation about configuration API (get configuration method) - Python SDK

What content needs to be created or modified?
Add information about the configuration API (get configuration method) for python sdk.
Describe the solution you'd like

Where should the new material be placed?
Under sdk documentation
The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

Additional context

PR addressing the issue has been merged: https://github.com/dapr/docs/pull/2127


Respond to cloud events validation call

Purpose
When subscribing to cloud events, Event Grid sends an OPTIONS request to verify that the subscription is acceptable. This change supports that request by responding with the proper headers as specified in the Cloud Events webhooks spec (https://github.com/cloudevents/spec/blob/v1.0.1/http-webhook.md).

...

Does this introduce a breaking change?
[ ] Yes
[ x ] No

Pull Request Type
What kind of change does this Pull Request introduce?
[ ] Bugfix
[ x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
cd src/Blazor.EventGridViewer.ServerApp
dotnet run

Test the code

cd src/Blazor.EventGridViewer.Unit.Tests
dotnet test

What to Check
Verify that the following are valid

Use a CloudEvent Event Grid Topic to subscribe to events with a webhook pointing to a hosted copy of this project. Ensure that the subscription succeeds.

Going to close this as our build template changes are getting mixed in here which was not my intent.


nVidia Divers support macOS Catalina ?

Does this nVidia Drivers support macOS Catalina ? I got the following errors when I download and install the drivers.

1 - disable SIP
restart in recovery mode
type csrutil disable
2 - disable Gatekeeper
back in 'normal' mode open Terminal and type sudo spctl --master-disable
3 - remount file system (enable write mode of system volume)
sudo mount -uw /
4 - force Finder process to restart
killall Finder
you should be able to install nvidia drivers now ;-)

This works, can probably close this issue now. Thanks!!

Can we enable SIP after finish install the display drives in Catalina ?
Sent from my iPhone 11 Pro Max
On 26 Mar 2020, at 1:03 PM, farfromthe<EMAIL_ADDRESS>wrote:

This works, can probably close this issue now. Thanks!!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Just to clarify, nVidia's drivers do not work on Catalina (or Mojave for that matter).
Yes, they'll install, and that may allow you to set some different screen resolutions, however macOS will not be hardware accelerated.
There's been a lot of coverage on this issue, so a quick Google will explain what's going on. It's for Apple and nVidia to sort out; which they likely won't.

Well even without hardware acceleration, we can at least install the display drivers for Catalina
Sent from my iPhone 11 Pro Max
On 26 Mar 2020, at 2:22 PM, Benjamin Dobell<EMAIL_ADDRESS>wrote:

Just to clarify, nVidia's drivers do not work on Catalina (or Mojave for that matter).
Yes, they'll install, and that may allow you to set some different screen resolutions, however macOS will not be hardware accelerated.
There's been a lot of coverage on this issue, so a quick Google will explain what's going on. It's for Apple and nVidia to sort out; which they likely won't.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

agreed. workaround gets you past installation errors however drivers really don't perform as they should. @Benjamin-Dobell, i think noting this on the project homepage will be helpful (don't upgrade past High Sierra)

@Benjamin-Dobell
Do you think there is any hope for Big Sur?

There is ZERO hope for Big Sur or any iteration of Apple Software when it comes to Nvidia. It's ridiculous, but it is what it is. Redshift is coming to Apple Metal. Octane X is already out. And so on and so forth.

@23d1
The latest I can go with the @Benjamin-Dobell 's drivers is High Sierra?

Pimped a MacPro 3,1 with a nvidia 980Ti (6GB VRAM) and macOS Catalina. Connected it to the Samsung C49HGx 32:9 4K Monitor and got it to work like this:

Connected the Monitor with HDMI and 1920x1080@144Hz
Used the tipps from @algol68 (disable SIP, disable Gatekeeper, remounted root with -uw...)
Ran Benjamins script to install the nvidia drivers.
Important: after reboot, set the screen refresh rate to 60Hz, so higher resolutions are available.
Installed the Resolution Helper Tool SwitchResX and defined a 3840x1080@60Hz resolution.
Activated the resolution and voilà! Got it running...

Acceleration in macOS is not so important for me, I need the widescreen resolution for working - for gaming I reboot my MacPro 3,1 to Windows 10 Pro 20H2...

Pimped a MacPro 3,1 with a nvidia 980Ti (6GB VRAM) and macOS Catalina. Connected it to the Samsung C49HGx 32:9 4K Monitor and got it to work like this:

Connected the Monitor with HDMI and 1920x1080@144Hz
Used the tipps from @algol68 (disable SIP, disable Gatekeeper, remounted root with -uw...)
Ran Benjamins script to install the nvidia drivers.
Important: after reboot, set the screen refresh rate to 60Hz, so higher resolutions are available.
Installed the Resolution Helper Tool SwitchResX and defined a 3840x1080@60Hz resolution.
Activated the resolution and voilà! Got it running...

Acceleration in macOS is not so important for me, I need the widescreen resolution for working - for gaming I reboot my MacPro 3,1 to Windows 10 Pro 20H2...