[doc] fix Move package tutorial

The package tutorial is currently broken, which is confusing some folks on Discord and in builder's groups. Let's take this opportunity to fix and simplify the tutorial:

Use sui move new to create the package skeleton
Fix sui move new to create a Move.toml that depends on the devnet branch + has a named alias for sui by default
Fix unused imports in the example code
Expand the example code and explain the different parts of the module

Absolutely love these changes! One thing I would add (I try to stick to this code style) -> putting accessors / getters up, so the overall structure of the module is:
- imports
- consts
- structs
- views
- public / entry functions
- private functions

Like the ordering + will add this recommendation to the doc!
Question: where does the module initializer fit in here--in "private functions"? Putting most private functions at the end makes sense to me, but I do kind of like having the initializer come right after the type defs since it's often closely related to singleton objects like the Forge

Question: where does the module initializer fit in here--in "private functions"? Putting most private functions at the end makes sense to me, but I do kind of like having the initializer come right after the type defs since it's often closely related to singleton objects like the Forge

Whoops. Forgot about the init buddy. Funnily enough rarely do I have modules that use init() and are generic - which means they don't have custom type definitions except for witnesses and require getters. Don't have strong preference, but assume that what you're suggesting is the best option!


render::primitive::Plane is confusing

How can Bevy's documentation be improved?
render::primitive::Plane is used mostly for frustum culling.
It is used as a half-space (discriminate between two sides of a plane in 3d space) to find which sector of a frustum we are in , and I think it should be renamed to HalfSpace, especially given we already have a shape::Plane that has nothing to do with it.

Agreed here :)


uninitialized constant ActionView::PartialIteration on Rails 6.1.0.alpha

Hey guys,
My collection components stopped working after upgrading from 6.0 to rails master. Some quick digging shows that ActionView::PartialIteration was moved between stable and edge.
It was moved here -> https://github.com/rails/rails/blob/master/actionview/lib/action_view/renderer/collection_renderer.rb
stable -> https://github.com/rails/rails/blob/6-0-stable/actionview/lib/action_view/renderer/partial_renderer.rb
master -> https://github.com/rails/rails/blob/master/actionview/lib/action_view/renderer/partial_renderer.rb
It's referenced over here in view_component -> https://github.com/github/view_component/blob/master/lib/view_component/collection.rb#L6
https://github.com/github/view_component/pull/306 seems related
I'm new to ruby and the entire rails ecosystem, so sorry if this is amateurish but I was able to fix it by copying the PartialIteration class into the ViewComponent module like in this fork https://github.com/fullpointer/view_component/commit/65f38dfb81f45bc4a59d50f3353ab0509e2446f5
Thanks!
Steps to reproduce

upgrade to rails 6.1.0.alpha
render any any component using with_collection like so<%= render CollaboratorComponent.with_collection(@collaborators) %>

System configuration
Rails version:
6.1.0.alpha
Ruby version:
2.7.1
Gem version:
2.18.1

I'll give it a try and report back!

@joelhawksley so i've spent a few hours trying to get the tests to fail without luck. Everything I try passes so it would indicate some issue with how the module is loaded. Forgive me if this is out of scope but I would really appreciate some guidance.
I found out that putting this line in application.rb forces ActionView::PartialIteration to show up:
ActionView.constants.select { |c| ActionView.const_get(c).is_a? Class } so I'm guessing this has to do with the lazy loading or order of things.
I also tried a bunch of different orders for requiring action_cable/engine in my application.rb. This is what it looks like currently.
require_relative "boot"

require "rails"
require "active_model/railtie"
require "active_job/railtie"
require "active_record/railtie"
require "active_storage/engine"
require "action_controller/railtie"
require "action_mailer/railtie"
require "action_mailbox/engine"
require "action_text/engine"
require "action_view/railtie"
require "view_component/engine"
require "action_cable/engine"
require "rails/test_unit/railtie"
require "clearance"

I'm not familiar with the ins and outs of how Rails loads things but I think the difference is that it gets loaded properly in the tests but not in my project.
I appreciate the help so far :)

@fullpointer We're running into this issue internally, and plan to look into it this week ❤


All decks showing as illegal in all formats on pennydreadfulmagic.com

Ye gods this one never ends.

ssh'ed into the server in a python REPL everything is fine. Decks show their correct legal formats and correct PD legality.

Argh, in the course of investigating it fixed itself. Confused.


chore: More spanner perf

Codecov Report
Attention: Patch coverage is 66.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 70.98%. Comparing base (18210de) to head (bd5bf4e).

Files
Patch %
Lines

packages/spanner/lib/src/tree/node.dart
14.28%
30 Missing :warning:

packages/spanner/lib/src/tree/tree.dart
83.33%
2 Missing :warning:

...ackages/spanner/lib/src/parametric/definition.dart
96.00%
1 Missing :warning:

packages/spanner/lib/src/parametric/utils.dart
96.42%
1 Missing :warning:

packages/spanner/lib/src/route/action.dart
80.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   72.25%   70.98%   -1.28%
==========================================
  Files          46       45       -1
  Lines        1521     1537      +16
==========================================
- Hits         1099     1091       -8
- Misses        422      446      +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Index set_controller and set_bond calls for controller list

https://github.com/w3f/SecOps/issues/256

FYI: this approach will make you loose all the bond and setController extrinsics nested in a batch call extrinsic, is that what you want ?


Edit school name

@J2TeamNNL I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host teacher.bkacad.edu.vn not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for understanding!


Missing choice in the list of avatar perspectives

The choice "Bust" is missing when the avatar source is "visage.surgeplay.com".
This is the only one that offers this choice and it is missing.
ORIGINAL

ARGON

Thought I removed it, thanks for finding


Grid Nodes Communication

Issue: #200
Description: Add communication between nodes. This allows the use of algorithms/methods that require independent communication between nodes(mid_get, spdz matmul, etc).
DONE:

Establish a websocket connection between nodes
Adds them to the list of known workers remotely

TO DO / INCOMPLETE:

Perform tensor move operation between two workers. (INCOMPLETE: Retrieve moved tensor value).
Remove the need for a time interval between connections

Fixes #200


[WIP] Improve readme lisibility

Understand in a single look what Lift does and how to use it.
Start with Lift main value and then dive in detailed set of features offered

Closing as this is live on master!


Update docs.microsoft.com links in samples, changelogs, TSGs, etc.

Continuation of changes made in https://github.com/Azure/azure-sdk-for-net/pull/47514. Update Markdown files representing samples, changelogs, and troubleshooting guides.

/check-enforcer override

API change check
API changes are not detected in this pull request.


Could not load dynamic library 'cudart64_110.dll'

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
2.9.1
Custom Code
No
OS Platform and Distribution
Windows 10
Mobile device
No response
Python version
3.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.2/8.1
GPU model and memory
No response
Current Behaviour?
The load of cuda for tensorflow fails with the following error:

c:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.2\bin>python
Python 3.10.5 (tags/v3.10.5:f377153, Jun  6 2022, 16:14:13) [MSC v.1929 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow
2022-08-01 17:30:54.607827: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'cudart64_110.dll'; dlerror: cudart64_110.dll not found
2022-08-01 17:30:54.608106: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
>>>

-----------
This error appears to come from:
tensorflow/tensorflow/core/platform/windows/load_library.cc
line: 43
LoadLibraryExW(ws_file_name.c_str(), NULL, LOAD_WITH_ALTERED_SEARCH_PATH)

Technically this should not be failing. Since CUDA 11.2 is loaded, the path variable is set correctly, and the file cudart64_110.dll is present. (see "log" output)
The load even fails when python is started from within the bin directory of CUDA\v11.2.
Is it possible that an extremely long path to the tensorflow python module could cause LoadLibraryEx to fail?
-----------

Standalone code to reproduce the issue
The issue may be related to the length of the python path:
C:\Users\uuuuuuu\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages

Loaded tensorflow using pip. Loaded CUDA 11.2, loaded cnDNN 8.1 and copied the files into the CUDA 11.2 directory.

I was NOT able to reproduce it on my other machine. However windows version is home instead of pro and python is installed under a different path.
This issue is not consistently reproduceable. Works fine on home computer but not on office computer.

Relevant log output
Tensor flow is in the following directory:
C:\Users\uuuuuuu\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\LocalCache\local-packages\Python310\site-packages>dir
 Volume in drive C has no label.

 You need to install the MSVC 2019 redistributable.
2. Your CPU does not support AVX2 instructions.
3. Your CPU/Python is on 32 bits.
4. There is a library that is in a different location/not installed on your system that cannot be loaded.

Also pip install tensorflow will install a version thats compatible with GPU and CPU. So it gives you that warning message.
If you don't want to see warning messages and want to install the CPU only version, you could - pip install tensorflow-cpu that's a smaller wheel file for CPU only version.  Thank you!

Seems to be working however had to use Conda.
In all the awful detail....
Installed the MSVC 2019(etc) redistributable. This initially did not make a difference.
Following the instructions: https://www.tensorflow.org/install/pip#windows_1
installed Miniconda with the default options
rebooted
Opened the newly installed Anaconda Command prompt

conda create --name tf python=3.9
answered yes where necessary...
conda deactivate
conda activate tf
conda install -c conda-forge cudatoolkit=11.2 cudnn=8.1.0
y
pip install --upgrade pip
Requirement already satisfied: pip in c:\programdata\miniconda3\envs\tf\lib\site-packages (22.1.2)
Collecting pip
Downloading pip-22.2.2-py3-none-any.whl (2.0 MB)
---------------------------------------- 2.0/2.0 MB 10.0 MB/s eta 0:00:00
ERROR: To modify pip, please run the following command:
C:\ProgramData\Miniconda3\envs\tf\python.exe -m pip install --upgrade pip

Error message did not seem to have an effect
tried uninstalling tensorflow

pip uninstall tensorflow
Appearently tensorflow was not installed
pip install tensorflow
ok...
Tried the recommended test command
python3 -c "import tensorflow as tf; print(tf.reduce_sum(tf.random.normal([1000, 1000])))"
This generate the previous "Could not load dynamic library 'cudart64_110.dll'..." error message
conda deactivate
closed Anaconda prompt
opened Anaconda Prompt
conda activate tf
python
Python 3.9.12 (main, Apr  4 2022, 05:22:27) [MSC v.1916 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.

import tensorflow as tf
print(tf.reduce_sum(tf.random.normal([1000, 1000])))
2022-08-04 18:39:10.303527: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX AVX2
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2022-08-04 18:39:10.694257: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1532] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 3995 MB memory:  -> device: 0, name: NVIDIA GeForce GTX 1660 SUPER, pci bus id: 0000:01:00.0, compute capability: 7.5
tf.Tensor(-954.0616, shape=(), dtype=float32)

This seems to be working fine


Roll back of beforeEach tests

For some reason this breaks unit tests. I spent about 2 hours investigating but could not figure out why it was breaking: https://github.com/tensorflow/tfjs/issues/162
Will wait for @dsmilkov to come back from vacation to help debug backend swapping in unit tests.

This change is

Thanks for debugging this issue! I'm curious to learn why this seems to affect some machines, but not others.

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

Perhaps the state MathBackendWebGL is messing up the next test, vs new is giving a clean state.

Jasmine core is now at version 3 btw

It's possible, but that shouldn't be happening. When a regular page loads we have a single backend instance. It also seems particular to our custom setup function of slice4d.


[Select] Follow spec with placement of dropdown icon

[x] I have followed (at least) the PR section of the contributing guide.

Closes #17227
Unlike what was discussed in the issue, I moved the position of the dropdown icon further from the right so that the spaces A and B are equal. This closer matches the look of the specification.

@lonssi It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Adopt The Whole Fruit Manifesto

Hey everyone,
We’ve worked our asses off on this new open-source project.
We've tried to compact all we currently know about writing well, for developers. So that they can easily read once and be better off for it (hopefully). But also to have a place we can point to, that treats this often-overlooked subject - how importand and how easy it is to write better as a software developer. Plus, we now have a place where to put ideas about that, when we learn new things.
It’s not code. It’s just a one-pager. Something you can read in 15 minutes on Github. Think of it like PSR-2 but for writing better tasks, issues, PRs, emails, comments, reviews etc.
If anybody's actually reading this PR, please:

Read the thing 😀
Decide if you want to include it in your projects too. If you do, great. If not, please tell us why not, as issues/PRs/emails/whatever. We’ve put hundreds of hours into this. So I really want to know how to make it better, and if it’s actually useful to developers (and maybe managers).

Here it is:
https://github.com/the-whole-fruit/manifesto
Can’t wait to see your responses. Hopefully this is not just a message in a bottle... and someone actually sees it 😂
Cheers!

A new inspection was created.

The inspection completed: No new issues


nixos/woodpecker-server: change type of environmentFile to list of paths

Makes the module more consistent with it's agent module.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I think we could migrate users away from a single string through coercedTo str (f: [ f ]) list (+ a warning if the option isn't of list type): this would preserve backwards compatibility.

feel free to just push to the pr ^^

I don't have commit bits, I can't push on somebody else's PR.

Allowing edits by maintainers

If checked, users with write access to NixOS/nixpkgs can add new commits to your woodpecker branch.

hm yeah this reads like it only allows edits if you have commit rights.
I'm not quite sure where you want me to add that:

coercedTo str (f: [ f ]) list

in the apply module option?

I'm not quite sure where you want me to add that:

coercedTo str (f: [ f ]) list

in the apply module option?

It's a type: see the documentation.

Tested and implemented your suggestion except for the warning part since I'm not quite sure on how to write the assertion for it. Btw thank you for teaching me about coercedTo

Sorry I forgot about the example last time, this should be fine otherwise.


Update patch_notebooks.py to include 'openvino'

I believe we are missing removing openvino from notebooks while patching, what leads  to uninstalling openvino during tests:
example on test_llm-agent-langchain.ipynb after patching:

This leads to next tests failing due to missing openvino package.

After fix:

@eaidova can you take a look?

@wkobielx, this fix also affects nncf (git+https://github.com/openvinotoolkit/nncf.git). Looks like it should be a strict comparison "openvino" == part

@aleksandr-mokrov updated

few examples, seems it is not affecting nncf repo anymore

@aleksandr-mokrov @yatarkan can you take a look? There is a high chance that a lot of tests will fail with missing openvino package on next nightly run without this fix


Resume queue-triage consuming from a queue via a REST endpoint

@amcghie just double checking. It's done, right?

Yep.  Code complete.


Windows support

Determine how to install SDK on windows (headless, CI).

this would be nice, interested in playing around with this but only have windows

@louisgjohnson That would be great! Just try install SDK with bash (or any available shell) without interaction with UI of installer. We have no anything but shell on CI.
Also will be cool investigate kind of installer and what it can - parameters of execution, etc..
I can take my wife's laptop with win7 and investigate about. I'll try this evening or tomorrow.

I tried on windows and have no Idea how to install it on headless system.
But one hacky idea I have is to write powershell script with async loop where tell OS globally fire key event (simulate Enter key-press) to accept & continue installer's UI dialogue. That's really not good but possible.
Imho, we should give up on this idea and wait Panic's solution with cli-installer.
Second my idea is to try to use gnu toolchain with SDK for linux on windows. That's seems more realistic.

Assuming WinGet's available I've had success with "winget install Panic.PlaydateSDK --silent --accept-source-agreements"


Demo/PR: Vercel Virtual Event Starter Kit

Adding a searchbar to Vercel Virtual Event Starter Kit

Here is a live demo link, where you can use Meilisearch to search for schedules, speakers, jobs, sponsors.
Live Demo: https://next-js-event-starter-kit.vercel.app/
Also linked is the Github repository for this integration:
Github Link: https://github.com/shivaylamba/NextJS-Event-Starter-Kit/

We have also created an issue on the official event-starter-kit repository to add a search integration using Meilisearch : https://github.com/vercel/virtual-event-starter-kit/issues/69

I have also updated the README.md for installation steps.

As we haven't received any update from the Vercel team since March, I will close this issue (this could have been done sooner). @shivaylamba if you want to pick it up from here for some reasons, feel free to!

Thanks @ferdi05 looks like there hasn't been any update yet as I didn't receive any response since last time.

Indeed. What I meant is that Meilisearch won't dig any further on this topic, so feel free to do anything you want of this

Alright thanks Ferdinand


Update examples in the documentation.

Update the examples in the documentation to have the section of setting the credentials commented.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.tmoskovitch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


ValueError: ('Searx API returned an error: ', 'Too Many Requests')

When using searx to look anything up

Pick a different instance from here. https://searx.space/ or host your own. Then swap it out with line 10 in the .env


Serving multiple sub-directories at root level

I want to serve the following static folder. However, I would like, e.g., the files foo.json and all.html to be available via /foo.json and /all.html. Is there currently a way to do this with Rice?
[jess@localhost assets]$ tree -L 2
.
├── frontend
│   └── foo.json
└── iframes
    ├── all.html
    ├── css
    ├── img
    ├── js
    └── lib

6 directories, 2 files

If not, I propose implementing a way to "join" boxes and create a new box. If you're on-board, I would be happy to implement this myself.
Thanks!

Hi. I think this should not be done by rice, but instead by a custom http handler that first checks box frontend, then box iframe. Or if it's currently the same box with two directories, first check directory A, then B.


Minor README issues

Just letting you know that the commands given in the "copy the sample configuration files" section aren't copy-and-paste-easy.
(assuming the user is still in the berry folder from installation):
mkdir $HOME/.config/berry cp example/sxhkdrc $HOME/.config/berry/sxhkdrc cp example/autostart $HOME/.config/berry/autostart
Changed:

Removed the berry/ from the second line
Removed the "s" from examples as the actual folder is just example, from last two lines
Removed the berry  from the last line, especially since there's a space there ;P

Anyway, it's not that important so keep up the great work! :D

Thanks! All this should be fixed in e8301d047883ca52c5ea4ca208eb13b077caf8e1 . See if this satisfies you and we can go ahead and close this issue.

Looks great! Can I ask, was sxhkd supposed to be started by berry upon launch? As it didn't work for me and I had to add the sxhkd -c $HOME/.config/berry/sxhkdrc line to my $HOME/.config/berry/autostart for it to work. This is with a display manager by the way.

No berry doesn't start sxhkd on its own. I want this to be as unix-y as possible so people can use whatever keyboard daemon they want. I assume most people will have their own place they want to start something like shxkd (maybe a custom startup script, in autostart, or in .xinitrc)

Ah yeah that makes sense then. Well consider this issue solved then! :D


[Issue58] Migrate to Fly.io

This PR adds changes to migrate production servers from Heroku to Fly.io. Changes in this PR include:

Changing GitHub workflow to deploy to fly.io instead of Heroku
Updating the application configuration to point to the Fly.io DATABASE_URL environment variable directly instead of the Heroku Buildpacks JDBC_DATABASE_URL
-- This allows me to turn off SSL for the Fly.io postgres connection since Fly.io doesn't support SSL for its internal databases
Adding fly.toml file to build the project correctly in Fly.io

:tada: This PR is included in version 1.1.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Apps tab - Manage list form broken

ENV: Dev
issue:
The URL field should be below the label

@francovenica, it seems to be fixed now, could you check again, please?

This is working properly now in prod with version 2.11.0 , Maybe it was fixed by another PR as a side effect.
Closing this one


Fix Swagger - Add "resource" layer in the throughput read response

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-python

This PR is similar to https://github.com/Azure/azure-rest-api-specs/pull/7790
It's not a breaking change, is a fix of broken SDK to align with our deployed Prod environment.

Automation for azure-sdk-for-go
A PR has been created for you:
https://github.com/Azure/azure-sdk-for-go/pull/6481

As confirmed by Chunyu, this is fix on swagger spec to match current service behaviour.


Refactor the fix for assets not searched in latest release

Use the fact that binaries has all the assets in the latest release and try to remove it (to get the owned value and avoid cloning), if the release doesn't have the assets, do as before.

Thanks!


Added Language Definition Properties

As an aid to companies who many have many LangDef Prop files, I recommend support for adding them under a subfolder of build-conf like
dbb-zappbuild/build-conf/langDefs/langDef01.properties
.                                                        /langDef02.properties
...

Thank you @nlopez1-ibm . We have added the subfolder langDefs under build-conf for maintaining language definition files.


Update the styling of the header and sidebar to increase its responsiveness

make sure the header collapses correctly its elements into MenuIcon when the screen size is reduced. It shouldn't overlap title of the page and the Menu Icon. Also, try to add the logo in the header which renders properly.

Covered under #33 hence closing


Add a general way to specify relative date in date filter.

Examples include:

10 days ago
1 quarter ago
-10 weeks
+1 year

This should fix #313

So the old time filter used to have placeholder to educate users about possible filter syntax, but it's no longer there.
I don't think people would find the feature in this PR unless they read the source code. How should we address this discover-ability issue?

@yegle Good point, I miss them, too! Maybe we could "manually" push some example strings to the list of values that are presented in this filter (the years). There would be no text explaining that these are examples, but there would be at least some hints as to how powerful this filter is.

[Current coverage][cc-pull] is 58.40%

Merging [#326][cc-pull] into [master][cc-base-branch] will increase coverage by 1.74%

@@             master       #326   diff @@
==========================================
  Files            12         12
  Lines           999       1041    +42
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            566        608    +42
  Misses          433        433
  Partials          0          0

Powered by Codecov. Last updated by [bbc9f19...749178f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/aumayr/fava/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/aumayr/fava/compare/bbc9f1986b23f127bdf841b52bf0ca1b280bfb37...749178f1e4b290ace8bc79d10fc113fc221183db
[cc-pull]: https://codecov.io/gh/aumayr/fava/pull/326?src=pr

I don't think people would find the feature in this PR unless they read the source code. How should we address this discover-ability issue?

This is exactly what we have the help pages for.

I don't like the syntax for these new relative intervals. Semantically, they seem wrong. "1 week ago" is a single point in time and shouldn't be an interval. Also, I'd expect it to be exactly 7 days ago, not the beginning of last week.

@yagebu That's right, I think the syntax should be improved in some way.
My motive was to add support for "the month before last month", so I came up with either "2 months ago" or "-2 month". I'm not a native English speaker, but I find it hard to express it precisely.
Any suggestions?

I'm for making the syntax more formal. It doesn't have to be a shortened version of the English full text IMHO. It should just be logical and concise. Something like year+4 maybe, or even just y+4. So year/y would just stand for the current year and it could be shifted. This is just off the top of my head and we would have to see how this fits with the rest of the syntax (I'm not against streamlining the whole date syntax, it's quite a mess atm).

For specify a range (since in fava a single day is useless) precisely, we'll need a delta (number of days starting from today, positive or negative), and a span (the length of result range, align to the nearest interval).
When you say year+4, you mean the delta is +4 years, but you didn't specify the span. Does my search for "year+4" show transactions of Jun 2020, or transactions from Jan 1 to Dec 31 of 2020?
If we use the implied span, then the PR here already implement support for +10 year (delta: 10 year, span: year) and  -3q (delta: -3 quarter, span: quarter). Maybe remove support for ambiguous 10 years from now and 3 quarters ago.
A more precise syntax would be +4 year@month, which means the delta to be +4 years and the span to be a month, and fava should show me transactions in Jun 2020.

Okay here's what I have in mind:

remove “X unit ago/from now" syntax since it's not precise
support for "[+-]X unit" syntax, use the unit as the span
support for "[+-]X unit/span" syntax and use the explicit span

Let me know what you think.

remove “X unit ago/from now" syntax since it's not precise

Yes, let's remove all the "alternative" date formats IMHO.

support for "[+-]X unit" syntax, use the unit as the span

This doesn't seem to be the right syntax for me for an interval. Let me explain how I interpret it. We add some number X of unit to something, say 4 and year respectively. Since something is unspecified, taking "today" as the default for that seems sensible. But "today plus four years" is not a whole year in four years time, but rather a single day.
My proposition is declaring year and so on as variables for the current year etc. If this variable then supports addition, I think we have the required functionality and to me this is quite logical. For example year+4 would be interpreted as 2016+4 or rather 2020, which would then have an obvious interpretation by our simple original date syntax.
The only slight problem with this is making this really flexible. For example it would be ambiguous if year-10-10 is October 10th of this year or rather all of October 10 years ago. But anyway, even if have to restrict somewhat, this syntax addition seems powerful enough.
My suggestion of course includes reworking the whole date parser, so it would be bigger than this PR and should possibly be discussed in a separate issue. So I'm currently against merging this PR (but we might be able to reuse your code later).

I'm a bit confused. Let's consider the following scenario:
On Jun 09 2016, I'm viewing transactions of an account with time filter "last month - next month". I should be viewing the transactions between May 01, 2016 and Jul 31, 2016.
At this time, when I search for "year+4", am I viewing transactions between:

Jan 1, 2020 and Dec 31, 2020
May 1, 2020 and Jul 31, 2020
Something else
Consider the search invalid

Are you implying 2?

1., as explained year+4 would be interpreted like 2020 which is all of 2020.

Sorry for the delay. I've removed support for "X days ago" and only support d+1 and day+1 etc.
Please let me know what you think and we can continue improving on this.

I think this could actually be simpler if we implement it as a sort of pre-parser that replaces the variables with their values and do the arithmetic there as well. Then we don't have to work with dates, but just with numbers. I can do this and then I would also remove some of the current alternative syntaxes.

Awesome, I'll wait for your PR then.


Upgrade to CEL 0.22.0

Some query planner tests are failing with missing attribute(s) error for comprehensions
CEL now supports two variable comprehensions: https://github.com/google/cel-go/pull/1034. Test that they work as expected with policy evaluation and query planning.
Test new functions (flatten, sort etc.) and document them: https://github.com/google/cel-go/releases/tag/v0.22.0
Switch to ContextEval to propagate the context.

https://github.com/google/cel-go/issues/1079

Should we consider support for optional types?

Yes

https://github.com/google/cel-go/issues/1080#issuecomment-2529406579
This new limitation doesn't seem to affect us.


cleanup golagci-lint configuration

This PR aims to reduce the number of excluded lints, ideally we should revisit the usefulness of the disabled ones and re-enable them.

IMO, we can try to remove the disable at all and see how many failures we have. If they are too much, we can create a gh issue with a task for each disabled lint in order to enable one at a time. This kind of chore tasks should require more attention, thanks for bringing it up.

I did test every single exclusion by one but  to fix the findings, I would have had to amend/refactor a very large set of files hence I opted to be conservative and just re-enable those that have no side effects.
I will probably start enabling additional linters one by one as follow up PRs as soon as I have time

I will probably start enabling additional linters one by one as follow up PRs as soon as I have time

Feel free to add an issue tracker as I suggested, so we can all contribute to the same activity when we have some free time.


Creating React App from scratch documentation missing

Currently, the getting started docs have this line:
If you prefer to set up your own JavaScript toolchain from scratch, check out this guide that re-creates some of the Create React App functionality.

which links to this article: https://blog.usejournal.com/creating-a-react-app-from-scratch-f3c693b84658
However, the code samples of the article are now going 404.
I believe that it is very important to provide people an option to have their own, minimalistic toolchain. (or rather the documentation for it). Especially for beginners.
I know there is the eject command for the create react app utility, but that includes a lot of extra features that many won't need.

@Zauberfisch  The code samples are present in the blog that you have mentioned, can you check once again

Hmm, that's weird. You are correct, I see them too now. Perhaps a temporary outage. I see they are github gists, but they are wrapped in iframes from usejounal.com.
Ok, I guess that invalidates the issue I had with the blog post.
Though I'd actually like to raise the question if it wouldn't be benefitial to adopt the contents of this blog post into the official react documentation and expand on it further.
I still believe that an option to roll your own tool chain is much more important then the documentation gives attention to.

I agree with you completely over this there should be info about setting your own react project from scratch in the official docs.
Maybe they will take a look at this.

Is this still an issue? If so I'll like to work on this.


I built the keyboard

This is my first custom or split keyboard. Thanks for the work!

Congrats on the build! :D


New pattern for additional buttons on expense pages

As shared by @alina in https://github.com/opencollective/opencollective/issues/4637#issuecomment-917992873_ and confirmed by other team members experience giving support, we should reposition the edit/download/delete button to a more recognizable pattern

visibility of the edit functions is something we should look at, specifically from the mobile users' perspective

We've gotten constant feedback since the design was released that having the edit/download/delete buttons on the upper left side is confusing. This doesn't match patterns in most other software and we should rethink it.

I am thinking something like the gmail send button where it's a button for the main action (in this case approve or pay) but also a dropdown for additional actions.

Design proposal

Version 1
Version 2
Version 3

@alanna @alinamanko @Betree wdyt?

@Memo-Es I personally prefer options 2 and 3 because buttons with icons without labels are not explicit enough. In option 3, all actions live in the same place, I think that's a great approach.

I am thinking option 3 works best from my perspective given it lives in line with other actions (just wonder whether the hidden options may make it a little trickier to see and wonder what others think). That or number one.

@alanna Have you seen this one?

I agree, option 3

Specs

[ ] Remove the existing ExpenseAdminActions from ExpenseSummary and pages/expense
[ ] Rename ExpenseAdminActions to ExpenseMoreActionsButton
[ ] Update this ExpenseMoreActionsButton component to match the design proposed on Figma (see the preview below) with the 4 proposed actions (Edit, Download, Copy link, Delete). components/PopupMenu.js should be used to build the dropdown.
[ ] Some E2E tests will probably be broken with this update, we'll need to update them

We'll be waiting for @Memo-Es's feedback on where to put this button on mobile.

I included the mobile and tablet versions in the same file @Betree


Chatting bug appearing twice when pressed once!

I've downloaded the latest version and having this issue.
https://thinkbusinessfinance-my.sharepoint.com/:v:/g/personal/david_balkwill_thinkbusinessloans_com/Ee35Qh0WXGtEnMbYgu40FuYB8Qm4kzHxYKdXsbCoXg2iCw?e=URXBlr
Thanks

Fixed in version 2.0.15


[jvm-package] Add WatchList to xgboost4j-spark trainWithDataFrame / trainWithRDD

For distributed training it would be useful to calculate a group of items to be evaluated during training to watch performance on the validation set. This is offered as a watch in single-node training.
Limitations of metrics collection in Spark are severe. However, presently I will need to modify the XGBoost source code in order to add my own accumulators. It would be helpful to have a structure in place for me to define them in the training method.
I suspect this is not feasible. If so, let's document that here.

Since the model up to each iteration is synchronized to each distributed worker, so it is possible to compute metric on an evaluation set, so long as it is small enough so that it won't take too long to evaluate.
I'm actually also interested in this, and I'll look into it and see if I can make a PR for this feature.

@mydpy I'll start working on this feature this week. Still contemplating what's the best strategy to run evaluation. I can either let the user pass a RDD of evaluation set, so that each worker performs its own evaluation on a portion of the validation set; Or, use broadcast to send the whole evaluation set to the workers, but only let one to perform evaluation. Will experiment with some proof of concepts and post updates as I make progress.

I am trouble with not watchlist in xgboost-spark,does any news come out?

@xydrolase I am thinking about either use the original rabit to allreduce metrics, or use your akka-based rabit tracker (add some application layer message) + accumulator to achieve this....

Add "WatchList" to xgboost4j-spark， does any news come out now？

Any update on the watchlist usage in xgboost4j-spark?

There's API to subsample the input DataFrame into train and test, see #2711.

@superbobry
hi, i want to add "WatchList" to xgboost4j-spark, so i use latest master version。
when i run,  some error happened:
Exception in thread "main" java.lang.NoSuchMethodError: org.apache.spark.scheduler.LiveListenerBus.listeners()Ljava/util/concurrent/CopyOnWriteArrayList; 	at org.apache.spark.SparkParallelismTracker.safeExecute(SparkParallelismTracker.scala:75) 	at org.apache.spark.SparkParallelismTracker.execute(SparkParallelismTracker.scala:102) 	at ml.dmlc.xgboost4j.scala.spark.XGBoost$.trainDistributed(XGBoost.scala:350) 	at ml.dmlc.xgboost4j.scala.spark.XGBoostEstimator.train(XGBoostEstimator.scala:139) 	at ml.dmlc.xgboost4j.scala.spark.XGBoostEstimator.train(XGBoostEstimator.scala:36) 	at org.apache.spark.ml.Predictor.fit(Predictor.scala:96) 	at ml.dmlc.xgboost4j.scala.spark.XGBoost$.trainWithDataFrame(XGBoost.scala:199)
my spark version is 2.2.0 and  use spark-core_2.11。

This looks like a classpath issue. Are you sure you don't have any other Spark version in the classpath when running your job?

I have set SPARK_HOME and PATH when running the job.
export SPARK_HOME=/usr/local/spark-2.1
export PATH=$SPARK_HOME/bin:$PATH


Dynamic PR title isn't updated

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When setting a pullrequest.title with a dynamic value like the source, the initial title isn't changed while the PR body is updated.
Ex: https://github.com/jenkins-infra/kubernetes-management/pull/2870

Expected Behavior
The PR title is updated on every pull request update.
Steps To Reproduce
Example manifest: https://github.com/jenkins-infra/kubernetes-management/blob/06efa37c1f9d3349f28b9c6e0eb3611d8422aebe/updatecli/updatecli.d/charts/artifact-caching-proxy.yaml
title: "Bump `artifact-caching-proxy` helm chart version"

scms:
  default:
    kind: github
    spec:
      user: "{{ .github.user }}"
      email: "{{ .github.email }}"
      owner: "{{ .github.owner }}"
      repository: "{{ .github.repository }}"
      token: "{{ requiredEnv .github.token }}"
      username: "{{ .github.username }}"
      branch: "{{ .github.branch }}"

sources:
  lastChartVersion:
    kind: helmchart
    spec:
      url: https://jenkins-infra.github.io/helm-charts
      name: artifact-caching-proxy

targets:
  updateChartVersion:
    name: "Update the chart version for artifact-caching-proxy"
    kind: file
    scmid: default
    spec:
      files:
        # TODO:
        # - clusters/cik8s.yaml
        - clusters/doks.yaml
        - clusters/prodpublick8s.yaml
      matchpattern: 'chart: jenkins-infra\/artifact-caching-proxy((\r\n|\r|\n)(\s+))version: .*'
      replacepattern: 'chart: jenkins-infra/artifact-caching-proxy${1}version: {{ source "lastChartVersion" }}'

pullrequests:
  default:
    kind: github
    scmid: default
    title: Bump `artifact-caching-proxy` helm chart version to {{ source `lastChartVersion` }}
    targets:
      - updateChartVersion
    spec:
      labels:
        - dependencies
        - artifact-caching-proxy

Environment
- OS: infra.ci.jenkins.io
- updatecli: v0.33.0

Anything else?
No response

I've tested the mutation manually:
https://github.com/updatecli/updatecli/blob/main/pkg/plugins/scms/github/pullrequest.go#L235-L250
that mutation works fine, so must be in how this client works / the go structure not actually generating the expected structure

Found the issue,
If you include state in the variables the pull request title doesn't get updated:
	  {
			"input": {
			  "title":"[updatecli] Bump test version to dummy8",
			  "pullRequestId" : "PR_kwDOIN-Dh85A6ITU",
        "body": "some gibberish8",
        "state":"OPEN"
			}
}

it works by removing state and sending:
	  {
			"input": {
			  "title":"[updatecli] Bump test version to dummy8",
			  "pullRequestId" : "PR_kwDOIN-Dh85A6ITU",
               "body": "some gibberish8",
			}
}

I've created a ticket with GitHub support to see if we can get any feedback, in the meantime raised https://github.com/updatecli/updatecli/pull/931 as a workaround.

I need to try setup the json schema and see if it helps dev experience

Updatecli jsonschema is published on jsonstore.
The schema mapping rule is that you manifest must be in directory updatecli.d
So if your IDE is compatible with jsonschema store like vscode, intellij,etc. then you have nothing to configure

Yes I got that working although the schema could be better, going to take a look in a bit to see if I can do any improvements to it.

Feel free to.
The schema is generated from the code using https://github.com/invopop/jsonschema
We can provide additional information using tags

Feel free to.

first PR: https://github.com/updatecli/website/pull/547

GitHub have deployed a fix and I've validated it's working, we could revert the PR but I think it's fine to keep the current state.


'screenshotMaker' is inaccessible due to 'internal' protection level

Hi,
I've implemented as per the instructions:
`Import ScreenshotSwiftUI
struct MyView: View
var body: some View {
VStack {
Text("Hello world")
}.screenshotMaker { screenshotMaker in
let uiImage = screenshotMaker.screenshot()
}
}`
I get the above error.
Are there more steps required in terms of setup?
Thanks

My bad... I forgot to add the change that made the function screenshotMaker public, try updating to 0.3.0

Thanks! Confirming the issue can be resolved.


Character fields in GraphQL schema should not be nullable

In  the schema of Character (and other types) there is currently this:
type Character {
    id: ID
    name: String
   ....
}

What this means is that there are characters like this:  { id: null, name: null }
Expected: Use ! to specify which fields won't be null, for example the name, id, image, etc.
type Character {
    id: ID!
    name: String!
   ....
}

Other types should also be fixed, for example:
type Characters {
    info: Info
    results: [Character]   #this means results can be null, or can be an array of nulls, or an array of Character
  }

Should probably be
type Characters {
    info: Info!
    results: [Character!]!    # this means this will be an array of Characters, or an empty array
  }

Hey @calitb, thanks for the suggestion.


Unserialize SPDX v2.2 to Protobom

I'm trying to use the library to compare vendor-published SBOMs vs SBOMs generated by the Veramine tool.  There aren't many for Windows software.  And unfortunately Microsoft's tool (https://github.com/microsoft/sbom-tool) creates SPDX v2.2 SBOMs.
How difficult would it to be to add support for SPDX v2.2 JSON format SBOM's?  Even if there was only support for unserializing, not serializing, that would be enough for my particular use case.  I see https://github.com/spdx/tools-golang/tree/main/spdx/v2/v2_2 exists...

I'll add this one as soon as we're done with the refactoring going on in #104

Thank you!


Add a d3 geo contains(ppint,  feature)

This is a feature request.
d3 can compute a centroid or area of a feature,  but there is no function to check if a point lie within a given feature.
Such a function working correctly for all features (across 180th meridian, containing pole etc.) would be immensly helpful to me.
Probably it can be implemented relatively easily using the same logic that's used for clipping.
If so at least some pointers how to implement this would be very helpful.
Thank you.

There is a d3_geo_pointInPolygon function, but it’s currently private. It’s used for clipping.

Thanks, it's working great for me.

It is now (d3v4) here https://github.com/d3/d3-geo/blob/master/src/polygonContains.js
Can we expose it?

If you exposed it as d3.geoContains(feature, point) and made sure it supported all GeoJSON feature types (requiring an exact match for point and line features, and generalizing it to support multipolygons), then yes.


[test] 测试 bot

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
白日依山尽
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[ ] I agree to follow this project's Code of Conduct

白日依山尽

标题修改失败


Add info about installation and using

Thanks. Merged in 6d12f0cb (after rebase). Github track history properly so it won't mark this as merged.


Pipeline issues

Hello,
I'm getting the following error while trying to create a demo MyHealthClinic project:
Error while creating build definition: The pipeline is not valid. A task is missing. The pipeline references a task called '4fa3aac0-0020-4832-9089-9979c9dd3e69'. This usually indicates the task isn't installed, and you may be able to install it from the Marketplace: https://marketplace.visualstudio.com. (Task version 0.*, job 'Phase_1', step 'Bower_3'.)
The project has been created but without pipelines.

Regards,
Aleksandar

Bower installed :)


not all of the note content is published

Hi! I love the idea of this to quickly share a page. I’ve got it working - sort of. When I set the HTML Source to “MarkdownRenderer” nothing happens when I try to publish or update. When it is left on the default of “Preview” it works to publish and update the post, but it doesn’t publish the whole post. I’ve tried on several notes, but they seem to get cut off after 300-400 words. For example: Luke Reading Guide – Telegraph This note should have a header and content for every chapter in Luke (24 of them), but the published note only shows down to 8. Any ideas on what is going on? Thanks!

Hi! Thanks for reporting, I've investigated the problem and found out that using "Preview" as HTML Source is fundamentally defective, so I dropped this setting and make "MarkdownRenderer" the default and unchangeable option for HTML Source.
The reason "Preview" did not work is that Obsidian uses a progressive rendering mechanism in preview mode,
while scrolling, only the visible part with a small margin is rendered to DOM elements,
this makes it impossible to get full HTML content for long documents.
I've tested the publishing for long documents based on your article, see the result here: https://telegra.ph/Test-Luke-Reading-Guide-4-04-04

When I set the HTML Source to “MarkdownRenderer” nothing happens when I try to publish or update

I cannot reproduce it and didn't have a clue about this, but you can try again with the new version 1.2.2, if this still happens, please tell me. Screenshots of the Developer Tools and your plugin list would be helpful for debugging.


docs(readme): apply prettier

What:

Why: フォーマットの統一

How: prettierの適用

Checklist:

[x] Documentation
[ ] Tests N/A
[x] Ready to be merged
[ ] Added myself to contributors table

Coverage remained the same at 100.0% when pulling c4d2e1f9619c2c5edc8aff3f24d8edbef42c1063 on pr-format-markdown into 49eb25a29dcc484955e3c578de9de7d9902af2ae on master.


Inline Macro Support

Describe the feature
The ability to define a macro inside a .sql file that is available only to that .sql file, like a function called inside the same .py file would work.  The idea would be when you have repeated logic in a model that you want to abstract into a macro that won't be used in other models, so it doesn't feel right to have a 'single use' macro in the macros folder.
Describe alternatives you've considered
Just throwing the macro in the macros folder.
Additional context
Based on this conversation in Slack. This also seems to be supported in the dbt cloud IDE (but not via CLI)
Who will this benefit?
Likely this is for a medium to advanced dbt user.
Are you interested in contributing this feature?
If this is something within my grasp I'd definitely be up for contributing this.

@jaypeedevlin Thanks for opening! I'm mostly for this, just want to register a few concerns that come to mind.
Pro: "Private" logic, unique to one model file, can already be expressed via most Jinja constructs within a model file (ifs, loops, etc). Sometimes, there's logic you just want to express functionally, with inputs and outputs. The ability to define a "private" macro at the top of a model, and use/reuse over the course of the file, keeps the logic close to home while also expressing it in the clearest way possible.
Con: Macros are resources in dbt. This "private" macro probably wouldn't work like other ("global") macros in a number of ways, because it wouldn't be a project resource: It couldn't be described, registered in the manifest, shown in the documentation site, or reused if imported from a package. (I say probably because anything is possible with enough code.) As long as those drawbacks don't feel surprising to you—it is a private macro, after all—then it may not be cause for concern.
In which types of resource files would you expect to be able to define and call inline macros? I'm thinking models, snapshots, analyses, data tests.

This also seems to be supported in the dbt cloud IDE (but not via CLI)

Yes! This is actually supported via the dbt RPC server, which has the ability to parse, compile, and execute an arbitrary blob of dbt-onic Jinja-SQL, via the compile_sql and run_sql methods only. It does this using the context of the project, but it doesn't actually register the new blob o' stuff within the project context. If that blob includes macros, it will parse them out here:
https://github.com/fishtown-analytics/dbt/blob/4d5d0e2150ff2776f5171eb229c367af839b9a35/core/dbt/parser/rpc.py#L50-L61
So if I've got a query, similar to the one linked in Slack:
{% macro test_func(column_name) %}
  {{ column_name }}
{% endmacro %}

SELECT
  {{ test_func('user_id') }}
FROM (
    SELECT 1 as user_id
) sbq

I can base64-encode that query, fire it off to a run_sql request, and see the results:
{
    "jsonrpc": "2.0",
    "method": "run_sql",
    "params": {
        "sql": "eyUgbWFjcm8gdGVzdF9mdW5jKGNvbHVtbl9uYW1lKSAlfQogIHt7IGNvbHVtbl9uYW1lIH19CnslIGVuZG1hY3JvICV9CgpTRUxFQ1QKICB7eyB0ZXN0X2Z1bmMoJ3VzZXJfaWQnKSB9fQpGUk9NICgKICAgIFNFTEVDVCAxIGFzIHVzZXJfaWQKKSBzYnE=",
        "name": "my_inline_macro_query"
    },
    "id": "2db9a2fe-9a39-41ef-828c-25e04dd6b07d"
}

"results": [
    {
        "logs": [],
        "raw_sql": "\n\nSELECT\n  {{ test_func('user_id') }}\nFROM (\n    SELECT 1 as user_id\n) sbq",
        "compiled_sql": "\n\nSELECT\n  \n  user_id\n\nFROM (\n    SELECT 1 as user_id\n) sbq",
        "node": {...},
        "timing": [...],
        "table": {
            "column_names": [
                "user_id"
            ],
            "rows": [
                [
                    1.0
                ]
            ]
        },
        "generated_at": "2021-05-25T12:26:22.403038Z"
    }
]

In any case, I do think the implementation of this could be tricky; we'd want to keep parse-time performance in mind. I'm open to continuing the conversation, and hearing what other folks think about the benefits, how they'd want to use this, or if there's any risk of confusing the interface to macros in dbt today.

Hi Jeremy!  Thanks for the thoughtful reply.  A few responses:

As long as those drawbacks don't feel surprising to you—it is a private macro, after all—then it may not be cause for concern.

I didn't explicitly say it, but that would be my assumption — it would be scoped just to the file that it's contained in.

In which types of resource files would you expect to be able to define and call inline macros? I'm thinking models, snapshots, analyses, data tests

Agreed on those, I can't think of any others.


Write introduction documentation for eventually crate

Following the feedback received in https://www.reddit.com/r/rust/comments/gkvxjw/eventually_event_sourcing_for_rust/, documentation on the eventually crate should be added.
Some of the points the documentation should contain:

General lines of what Event Sourcing is
How does eventually provide support for Event Sourcing
Explanation on how the different parts of the architecture work together

Closed by #114


Remove legacy numeric constants.

Now that we switched to MSVR 1.63 we can also remove the use of std::isize constants and use associated consts from isize directly :)

ehh, wrong repo. Ooops. Sorry for the noise!


vmr '--test' is sometimes skipping test projects

In our CI, the test projects that are under the vmr build --test argument are no longer both being executed.
This happens both on x64 as well as  s390x/ppc64le, though there seem to be two separate problems.
In the s390x/ppc64le case, the test command fails with a non-zero exit code and neither scenario tests nor smoke tests are ran:
+ ./build.sh --with-system-libs +brotli++zlib+ --with-sdk /home/tester/dotnet/sdk --with-packages /home/tester/dotnet/packages --source-only /p:TargetRid=rhel.8-ppc64le --test
Using custom bootstrap SDK from '/home/tester/dotnet/sdk', version '9.0.100-rc.2.24470.1'
Found bootstrap versions: SDK 9.0.100-rc.2.24470.1, Arcade 9.0.0-beta.24466.2, NoTargets 3.7.0 and Traversal 3.4.0
MSBuild version 17.12.0-preview-24467-02+9fcd87631 for .NET

  Determining projects to restore...
  Restored /home/tester/dotnet/repo-projects/scenario-tests.proj (in 365 ms).
  Restored /home/tester/dotnet/test/tests.proj (in 365 ms).
  Restored /home/tester/dotnet/test/TestUtilities/TestUtilities.csproj (in 2.06 sec).
  Restored /home/tester/dotnet/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj (in 2.5 sec).
  1 of 5 projects are up-to-date for restore.
  TestUtilities -> /home/tester/dotnet/artifacts/bin/TestUtilities/Release/TestUtilities.dll
  Microsoft.DotNet.SourceBuild.SmokeTests -> /home/tester/dotnet/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/Microsoft.DotNet.SourceBuild.SmokeTests.dll
  Building dependencies [source-build-reference-packages;arcade;command-line-api;source-build-externals] needed by 'scenario-tests'.
  Building dependencies [source-build-reference-packages] needed by 'arcade'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'command-line-api'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'source-build-externals'.
+ TEST_EXIT_CODE=1

In the x64 case, the test command exits with a success exit code but it did not run the smoke tests:
+ ./build.sh --with-system-libs +brotli++libunwind++rapidjson++zlib+ --source-only --test
Found bootstrap versions: SDK 9.0.100-rc.1.24452.12, Arcade 9.0.0-beta.24408.2, NoTargets 3.7.0 and Traversal 3.4.0
MSBuild version 17.12.0-preview-24422-09+d17ec720d for .NET

  Determining projects to restore...
  Restored /home/tester/dotnet/test/tests.proj (in 144 ms).
  Restored /home/tester/dotnet/repo-projects/scenario-tests.proj (in 144 ms).
  Restored /home/tester/dotnet/test/TestUtilities/TestUtilities.csproj (in 2.83 sec).
  Restored /home/tester/dotnet/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj (in 4.35 sec).
  1 of 5 projects are up-to-date for restore.
  TestUtilities -> /home/tester/dotnet/artifacts/bin/TestUtilities/Release/TestUtilities.dll
  Microsoft.DotNet.SourceBuild.SmokeTests -> /home/tester/dotnet/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/Microsoft.DotNet.SourceBuild.SmokeTests.dll
  Building dependencies [source-build-reference-packages;arcade;command-line-api;source-build-externals] needed by 'scenario-tests'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'command-line-api'.
  Building dependencies [source-build-reference-packages] needed by 'arcade'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'source-build-externals'.
  [05:03:28.12] Testing scenario-tests
  Running command:
    /home/tester/dotnet/src/scenario-tests/eng/common/build.sh --restore --test --ci --configuration Release /bl:artifacts/log/Release/Test.binlog
    With Environment Variables:
      TestRoot=/home/tester/dotnet/artifacts/scenario-tests/artifacts/
      DotNetRoot=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
      TestSdkVersion=9.0.100-rc.2.24476.1
      AdditionalTestArgs=--xml /home/tester/dotnet/artifacts/TestResults/Release/scenario-tests/2024-09-26_05_03_28.xml --target-rid fedora.39-x64 --no-cleanup --no-traits Category=MultiTFM
      DotNetTool=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/dotnet
      _InitializeDotNetCli=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
  ##vso[task.setvariable variable=Artifacts;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts
  ##vso[task.setvariable variable=Artifacts.Toolset;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/toolset
  ##vso[task.setvariable variable=Artifacts.Log;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/log/Release
  ##vso[task.setvariable variable=Temp;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/tmp/Release
  ##vso[task.setvariable variable=TMP;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/tmp/Release
  ##vso[task.setvariable variable=NUGET_PLUGIN_HANDSHAKE_TIMEOUT_IN_SECONDS;isSecret=false;isOutput=true]20
  ##vso[task.setvariable variable=NUGET_PLUGIN_REQUEST_TIMEOUT_IN_SECONDS;isSecret=false;isOutput=true]20

    Determining projects to restore...
    Restored /home/tester/dotnet/.packages/BootstrapPackages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24408.2/tools/Tools.proj (in 5.11 sec).
    Determining projects to restore...
    Restored /home/tester/dotnet/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/Microsoft.DotNet.ScenarioTests.SdkTemplateTests.csproj (in 6.06 sec).
    Test environment:
      Dotnet Root: /home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
      Test root: /home/tester/dotnet/artifacts/scenario-tests/artifacts/
      Target RID: fedora.39-x64
      Sdk Version: 9.0.100-rc.2.24476.1
      Platform: LINUX
    [SKIP] Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyAspireTemplate
    Finished Microsoft.DotNet.ScenarioTests.SdkTemplateTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35

    Tests run: 31, Errors: 0, Failures: 0, Skipped: 1. Time: 844.630497s

  Build succeeded.
      0 Warning(s)
      0 Error(s)

  Time Elapsed 00:14:18.29
  [05:17:48.18] Testing scenario-tests...done
+ EXIT_CODE=0

For the smoke tests not running, we unfortunately have a large gap in our CI because we didn't notice the rename of --run-smoke-test to --test in May. The change in behavior may be related to that rename.
From the CI ppc64le logs, we see scenario-tests ran with vmr 1a65f6db1eec78dfd8ebff48dda59ce0a0c86a70 (Sep 7) and no longer with vmr fe7af57fd36dcbeb0c07d899b66c9ab36e2201de.
cc @MichaelSimons @omajid @Swapnali911

Can you attach binlogs for both of these scenarios? Use /bl:<binlog-output-path> in your call to the build script.

@mthalman  here is binlogs 4635_ppc64le.zip for ppc64le scenario

These are likely two separate issues. Given that we have a binlog for the ppc scenario, let's move forward with diagnosing that. The MSBuild task that is returning the failure is here: https://github.com/dotnet/dotnet/blob/ed57bf8d1fecae71c1c23b92180afd93043a8836/src/vstest/src/Microsoft.TestPlatform.Build/Tasks/VSTestTask.cs#L48
Reverse engineering that logic, it looks like it's making this call:
dotnet exec /root/jenkins-scripts/ci/dotnet/sdk/sdk/9.0.100-rc.2.24474.1/vstest.console.dll --framework:.NETCoreApp,Version=v9.0 --logger:console;verbosity=normal --logger:trx;LogFileName=Microsoft.DotNet.SourceBuild.SmokeTests.trx --resultsDirectory:/root/jenkins-scripts/ci/dotnet/artifacts/TestResults/Release/ /root/jenkins-scripts/ci/dotnet/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/Microsoft.DotNet.SourceBuild.SmokeTests.dll

Try running that locally to debug things further.

I looked into this today.
I found out that on x64, the smoke tests do in fact execute, but they don't print any output to stdout. I think something in msbuild/vstest is redirecting the output.
I assume that we're not seeing the error that happens when the smoke tests fail to start on  s390x/ppc64le for the same reason.
This issue looks related: https://github.com/microsoft/vstest/issues/10358.
cc @nohwnd @rainersigwald

@tmds yes, probably related. Can you easily set MSBUILDENSURESTDOUTFORTASKPROCESSES=1 as an env var around that invocation to work around?

Can you easily set MSBUILDENSURESTDOUTFORTASKPROCESSES=1 as an env var around that invocation to work around?

I have tried setting that before running the vmr build.sh with --test but that did not cause the standard output to show for the SmokeTests.
The tests.proj of the vmr has references to the SmokeTests project and also to the scenario-tests project. For the latter project the output does get printed.
Logging from the CI:
+ export MSBUILDENSURESTDOUTFORTASKPROCESSES=1
+ MSBUILDENSURESTDOUTFORTASKPROCESSES=1
+ ./build.sh -bl --with-system-libs +brotli++libunwind++rapidjson++zlib+ --source-only --test
Found bootstrap versions: SDK 9.0.100-rc.1.24452.12, Arcade 9.0.0-beta.24408.2, NoTargets 3.7.0 and Traversal 3.4.0
MSBuild version 17.12.0-preview-24422-09+d17ec720d for .NET

  Determining projects to restore...
  Restored /home/tester/dotnet/repo-projects/scenario-tests.proj (in 149 ms).
  Restored /home/tester/dotnet/test/tests.proj (in 149 ms).
  Restored /home/tester/dotnet/test/TestUtilities/TestUtilities.csproj (in 1.78 sec).
  Restored /home/tester/dotnet/test/Microsoft.DotNet.SourceBuild.SmokeTests/Microsoft.DotNet.SourceBuild.SmokeTests.csproj (in 2.81 sec).
  1 of 5 projects are up-to-date for restore.
  TestUtilities -> /home/tester/dotnet/artifacts/bin/TestUtilities/Release/TestUtilities.dll
  Microsoft.DotNet.SourceBuild.SmokeTests -> /home/tester/dotnet/artifacts/bin/Microsoft.DotNet.SourceBuild.SmokeTests/Release/Microsoft.DotNet.SourceBuild.SmokeTests.dll
  Building dependencies [source-build-reference-packages;arcade;command-line-api;source-build-externals] needed by 'scenario-tests'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'source-build-externals'.
  Building dependencies [source-build-reference-packages] needed by 'arcade'.
  Building dependencies [source-build-reference-packages;arcade] needed by 'command-line-api'.
  [16:54:02.55] Testing scenario-tests
  Running command:
    /home/tester/dotnet/src/scenario-tests/eng/common/build.sh --restore --test --ci --configuration Release /bl:artifacts/log/Release/Test.binlog
    With Environment Variables:
      TestRoot=/home/tester/dotnet/artifacts/scenario-tests/artifacts/
      DotNetRoot=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
      TestSdkVersion=9.0.100-rtm.24503.1
      AdditionalTestArgs=--xml /home/tester/dotnet/artifacts/TestResults/Release/scenario-tests/2024-10-03_16_54_02.xml --target-rid fedora.39-x64 --no-cleanup --no-traits Category=MultiTFM
      DotNetTool=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/dotnet
      _InitializeDotNetCli=/home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
  ##vso[task.setvariable variable=Artifacts;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts
  ##vso[task.setvariable variable=Artifacts.Toolset;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/toolset
  ##vso[task.setvariable variable=Artifacts.Log;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/log/Release
  ##vso[task.setvariable variable=Temp;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/tmp/Release
  ##vso[task.setvariable variable=TMP;isSecret=false;isOutput=true]/home/tester/dotnet/src/scenario-tests/artifacts/tmp/Release
  ##vso[task.setvariable variable=NUGET_PLUGIN_HANDSHAKE_TIMEOUT_IN_SECONDS;isSecret=false;isOutput=true]20
  ##vso[task.setvariable variable=NUGET_PLUGIN_REQUEST_TIMEOUT_IN_SECONDS;isSecret=false;isOutput=true]20

    Determining projects to restore...
    Retrying 'FindPackagesByIdAsync' for source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/4828dfac-e9f8-49bc-acb6-319be99331fc/nuget/v3/flat2/microsoft.dotnet.signtool/index.json'.
    Response status code does not indicate success: 503 (Service Unavailable).
    Restored /home/tester/dotnet/.packages/BootstrapPackages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24408.2/tools/Tools.proj (in 4.19 sec).
    Determining projects to restore...
    Restored /home/tester/dotnet/src/scenario-tests/src/Microsoft.DotNet.ScenarioTests.SdkTemplateTests/Microsoft.DotNet.ScenarioTests.SdkTemplateTests.csproj (in 8.27 sec).
    Test environment:
      Dotnet Root: /home/tester/dotnet/artifacts/obj/extracted-dotnet-sdk/
      Test root: /home/tester/dotnet/artifacts/scenario-tests/artifacts/
      Target RID: fedora.39-x64
      Sdk Version: 9.0.100-rtm.24503.1
      Platform: LINUX
    [SKIP] Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyAspireTemplate
    Finished Microsoft.DotNet.ScenarioTests.SdkTemplateTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35

    Tests run: 31, Errors: 0, Failures: 0, Skipped: 1. Time:<PHONE_NUMBER>s

  Build succeeded.
      0 Warning(s)
      0 Error(s)

  Time Elapsed 00:15:36.89
  [17:09:41.19] Testing scenario-tests...done
+ EXIT_CODE=0

The tests.proj of the vmr has references to the SmokeTests project and also to the scenario-tests project. For the latter project the output does get printed (regardless of MSBUILDENSURESTDOUTFORTASKPROCESSES being explicitly set).

Since one of test projects manages to produce output, I tried setting MSBUILDDISABLENODEREUSE=1.
With that, the smoke tests output also gets printed.
@rainersigwald it would seem that we are loosing the smoke test output due to it being ran on a node has redirected stdout.
On ppc64le/s390x the few jobs that ran so far didn't show an issue when trying to start the smoke tests (as we had observed earlier in the binlog). If I don't see an issue this week, I'll close this ticket.

@rainersigwald it would seem that we are loosing the smoke test output due to it being ran on a node has redirected stdout.

That's what MSBUILDENSURESTDOUTFORTASKPROCESSES controls: when set, all worker nodes share stdout. I thought it also inherently disabled node reuse but I guess we did that at the dotnet test layer instead: https://github.com/dotnet/sdk/blob/c5dbaedae3a97f6dee69acf59d4af6454c218608/src/Cli/dotnet/commands/dotnet-test/Program.cs#L83-L84

@tmds, @mthalman - What work remains here or can this be closed?

Gentle ping @tmds - have you confirmed this fix on ppc64le/s390x?

With the change we made, we now see the execution of the test suites. The issue on s390x/ppc64le is no longer reproducing. If it would resurface, I think we will now also see the error show up in the log.


Wiring Diagram?

There are many examples of wiring diagrams for an Arduino to Sony LANC, usually 2.5mm jack, the one in particular I'm thinking of looks something like the following:

Would the above wiring diagram work for your library to send zoom in/out commands? Can you recommend a wiring diagram for a zoom in/out use-case?

The library implements the lanc protocol and this does not depend on any particular wiring. For the diagram you show: it seems plausible.


[FEATURE]Re-add the old AtomListener x2 that supports different types in v3

Hi,
I'm trying to create a EventListener of <Vector3, Int> in v3 unsuccessfully and being told it is impossible for v3.
It is possible in v2. I'm not sure how to proceed on this so this is all I can say. I'll try work around with structs.
Tks and Best regards,
Nix,

Thanks for reporting! This will be addressed in the next release of Atoms.

Has been addressed in v4 of Unity Atoms. I suggest using v4 instead of v3.


[Feature]: Validate minimum length of text() type

What is the new or updated feature that you are suggesting?
In the regular Zod, they have z.string().min({value}) to validate the minimum length of the string.
Can zod-form-data have this feature too?
Thank you
Why should this feature be included?
To match the functionality of the regular Zod

Hi!
To achieve this with zod-form-data, you can pass the schema into zfd.text.
zfd.text(
  z.string().min(5)
)

Or alternately, you can also still call refine like you would with any other schema.
zfd.text().refine(val => val.length > 5)


fix: sort config versions numerically

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

@AndreiAlexandruParaschiv thank you for your proposal. The real fix would however be to fix the dynamo data model and convert the sort key from string to numeric. I can work with you to make that happen. Small code change required to drop the "v".

closing for https://github.com/adobe/spacecat-shared/pull/415


refactor(sherlock): convert to typescript

🤯
i can go either way on having more run scripts or passing the watch flag to an existing one 🤷🏼
refs #365

This is looking good to me.

It might make sense to do the utilities in this pr since a lot is shared.

It might make sense to do the utilities in this pr since a lot is shared.

Sorry I missed this. Hopefully the utilities changes will be able to be rebased into this PR without any issues.


[FLINK-6201][example] move python example files from resources to the examples

Python example in the resource dir is not suitable. Move them to the examples/python dir.

[X] General

The pull request references the related JIRA issue ("[FLINK-6201] move python example files from resources to the examples")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[X] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[X] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

-1. This moves the Flink's entire python library into the examples folder, breaking basically everything.
You will have to move the configured directory to /resources and exclude the example directory, and move that one specifically to /examples.
I would also suggest to run an example at least once to make sure you don't break anything.

I would also suggest to run an example at least once to make sure you don't break anything.

You are right. Only move the example files

Thank you for fixing this so quickly. +1 to merge.

merging.


Minor documentation improvements: typo fix and slug update

What changed?
File 1: decommissioning-public-geth-archive-snapshots.md
Slug was updated:
Old: /decommissioning-public-geth-archive-snapshots
New: /decommissioning-public-geth-archive-snapshots
Reason: The slug path had unnecessary issues (though visually no change is visible, perhaps fixing unseen formatting or whitespace issues).
File 2: basenames-onchaintkit-tutorial.md
Fix in description text:
Old: "teaches how to intergrate Basenames"
New: "teaches how to integrate Basenames"
Reason: Corrected a typo in the word intergrate to integrate for better clarity and accuracy.
Why?

To fix a typo (intergrate → integrate) in the Basenames tutorial.
To clean up or standardize the slug in the decommissioning-public-geth-archive-snapshots.md file.

Notes to reviewers

Review the changes to confirm the typo fix and check that the slug behaves correctly after the update.
Ensure there are no unintended modifications.

How has it been tested?

The changes are minor textual updates. Likely tested locally or visually verified in the rendered markdown.
No functional code changes were made, so minimal testing was necessary.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Implement "Gravid" wave special

The children of these creeps jump out when their parents die. They mature quickly...

Note that in original game, child creeps are placed on the sides of the path. Should avoid doing that so that creeps are not placed near floor2 tiles. Floor2 tiles are part of the background and will draw behind creeps which will look weird.
Place child creeps behind the parent instead.

Moved to Backlog https://github.com/Praytic/youtd2/discussions/407


Add education field to user profile

Add a "highest level of education" field as a required parameter of the profile page.  This will enable us to report the type of user by education level to NSF.

Closing - decided not to require this.  Covered by user type.

I added the "won't fix" label so we can find this ticket again if we want to reopen it.


Convert less to scss

Modern versions of Bootstrap use scss and don't provide less source code any more. Wro4j doesn't have good support for the latest form of scss, so we have to use node.js to compile the petclinic.css. There were also a few tweaks to styles in menus and buttons because of migrations in Bootstrap. Finally the glyphicons (used in navbar) had to be replaced with font-awesome.

Good job Dave.
I'm disappointed that in the Java world we don't have a tool to generate CSS from SCSS. One more sign that the Java ecosystem is withdrawing from the frontend?
I find it a shame to have to go through Node.js. I find the process a bit heavy.
Moreover, in the past, behind a corporate proxy, I have already had problems with the use of the frontend-maven-plugin (node download blocked).
Are there not other solutions?

I don’t know to be honest, but I couldn’t find a way to make the wro4j thing work, and it seems like it would only work with jruby anyway. The future is JavaScript it seems. Maybe we could use GraalVM instead of the front end plugin, but I don’t know if that’s any more palatable?

Here's another idea: what about if we simply commit petclinic.css to source control, and add a profile that can be used to re-build it (using frontend plugin)? That way everyone gets something that works and there is a well-defined process for building if there are style changes (which are rare).

I found another Maven plugin. It looks mostly abandoned, and it depends on https://github.com/bit3/jsass which is definitely not maintained, but it was updated a year ago, and it works. See 0a2b19c.

I saw that many users open an issue because they don't find the petclinic.css file. Generate this file once through a maven profile and commit it could be a way to avoid this kind of mistake (due to IDE configuration I mean). It may be documented in the readme.
For the moment, I prefer the approach to use the deprecated libsass-maven-plugin instead of introducing node and npm installation. It's personal.

I saw that many users open an issue because they don't find the petclinic.css file. Generate this file once through a maven profile and commit it could be a way to avoid this kind of mistake (due to IDE configuration I mean). It may be documented in the readme.
For the moment, I prefer the approach to use the deprecated libsass-maven-plugin instead of introducing node and npm installation. It's personal.

OK. I put the CSS generation in a profile. If we retain the git history we will be able to see all the choices if ever they need to me revisited. I'm going to merge.


istio-operator chart not found in releases

The documentation refers to installation of the operator like this:
helm install istio-operator manifests/charts/istio-operator \
  --set operatorNamespace=istio-operator \
  --set watchedNamespaces="istio-namespace1\,istio-namespace2"

But that folder location is not packaged into the release.
[x] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade

@Morriz Which version of Istio you are using?

I just quickly verified and I can see it's available with the following releases.
[istio-1.8.3]$ ls manifests/charts/istio-operator/
Chart.yaml  crds  files  templates  values.yaml

[istio-1.9.4]$ ls manifests/charts/istio-operator/
Chart.yaml  crds  files  templates  values.yaml

[istio-1.10.0-rc.0]$ ls manifests/charts/istio-operator/
Chart.yaml  crds  files  templates  values.yaml

1.9.5? maybe I just clicked to download the zip then. My excuse


Fix crash in sgemm SSE/nano kernel on x86_64

Fix bug #2047
I managed to test the nano kernel. Make it crash and test with my fix. Although it might benefit from further testing, I doubt this fix could introduce new bugs.

Thanks.


Feature: Generate Schemas From OpenAPI Schema

https://spec.openapis.org/oas/v3.1.0#fixed-fields-11
I think we should be able to go some way to generating schemas based on open API schema file.
There are a lot of questions here, and supporting it in the general case might be very tricky. But we can start simple.
It's possible this should be another repo though that you can optionally add... But we can start here and see where it gets us.
The idea is to get at least 80% of the way to written schemas (inline or not?). That would making creating API clients extrememly easy by letting us ingest the schema create schemas and programatically create a client for any API!

Branch started here: https://github.com/Adzz/data_schema/tree/open-api


How to grab detected object's label

I'm trying to get the label of the object that the net is detecting if anyone can help, it will be very appreciated. :D

self.img, self.width, self.height = self.camera.CaptureRGBA() detections = self.net.Detect(self.img, self.width, self.height, "box,label,conf")
From this code im assuming the label is part of the detections list, but i dont understand how to grab it.

try   net.GetClassDesc(detection.ClassID) where detection is an element in detections

yeah that worked the class id was what i needed. Thank you for the quick response!


Adding "valids user" argument in share section

Type of Change

[ ] New feature
[ ] Bug fix
[ ] Documentation update
[ ] Refactoring
[x] Hotfix
[ ] Security patch
[ ] UI/UX improvement

Description

Testing

Impact

Issues / other PRs related

Resolves #

Additional Information

Checklist

[ ] My code adheres to the coding and style guidelines of the project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no errors/warnings/merge conflicts.

I used the samba setup it was not entering the valid user argument in the share section and because of that it was not being accessed


Supports Async ?

what?

Does this library supports async validation ?

The validation is based on the System.ComponentModel.DataAnnotations by annotating Attributes to your Model btw. ViewModel. The current implementation doesn't execute the validation asynchronously. PR`s are welcome.

Understood, thanks. :)

Feel free to reopen for any further questions.


Make status_code_and_message interop test robust

Fixes the interop breakage in https://github.com/grpc/grpc/pull/19545.
It's unclear why only Python clients are infected. Most likely, the culprit is the test implementation instead of overall architecture.
This PR tries to drain bi-di streaming RPC before trying to get the final status code.

Both interop test jobs passed. Merging.


Create ColorParty.bat

What does the program do ?
Change cmd color when any key is pressed
In what programming language it is written?
ms-dos batch

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


add transfer objects for benchmark

https://github.com/zero-deps/protobuf-scala-macros/pull/1#issuecomment-538102136

duplicates #2


Help needed setting this up

Hello,
I have 2 inverters:
1 x SG2.0RS-S
1 x SH4.0RS
I've been using this integration until today but it has been giving me nothing but problems since it goes through the api of isolarcloud: https://github.com/MickMake/GoSunGrow/
So I want to use an integration that bypasses the isolarcloud api/connection.
However I'm not sure how to proceed with this integration. Both my inverters have a Wifi-S dongle/module but I could also connect them with Ethernet to the dongle. If I unplug the dongle all together, I also have an ethernet connector on the converter.
What would be the way forward? Can I just leave them as is (connected to the wifi)? If yes, I'm not sure where I can find the ip address of these dongles; I've looked everywhere in the Isolarcloud app / Webpage but it seems it's not something I can find.
Looking at my router, I've 100 devices or more, so can't tell which one is which.
Any help setting this up would be very much appreciated!

Hi,
I loved this integration and will be patient until an update comes out, however, if you find a good modbus integration that shows also the plethora of information, I am happy to hear about it.
To answer your question, try to look out for an entry in your router (mine is FB) where the name says "espressif".
Also I do have 2 inverters and as they both have been connected to my router at the same time, their IP address is just ...91 and ...92.
When I connected the modbus via the extra LAN cable the router assigned the next free IP address to the lan connection.
Also here the connection was called "esspressif".
Good luck and keep us posted.
Cheers

As I see, it has no options for a second inverter :(

That's too bad, I have an inverter for every side of the roof since I have more solar panels on one side of the roof compared to the other one. So I would need to be able to add both off them, otherwise there is no point implementing this solution :-/

Good evening everyone. I'm not familiar with Home Assistant...so my question will seem trivial...
but how do I add a card once the Add-on has been installed??

Good evening everyone. I'm not familiar with Home Assistant...so my question will seem trivial... but how do I add a card once the Add-on has been installed??

@ventudan:
Open HomeAssistant.
Click "Settings" on the left navigation panel.
Click "Devices and Services" in the middle panel.
Click "MQTT" application.
Click the xx "devices".  Where xx is a number of detected devices.
Click on your inverter model.  Mine was "SG8K-D".
Now you can click the "Add to Dashboard" and this card will be added whatever panel you select.
I hope this is what you wanted.


Allow timingReadCloser to be seeker

[X] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Cortex uses objstore to update blocks to s3. Cortex had added a retry functionality using seeker objects.
https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/s3/bucket_client.go#L176-L191
It checks if an object is seeker and if so it allow it to retry.
It also wrap the bucket store with metrics
https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/client.go#L145
With the new timing metrics, ojbstore now override the object and thus change it to always be io.ReadCloser which is what the implementation requires, but it does not allow cortex to retry request anymore.
The change allow it to continue using a seeker object if the original object was seekable.
Verification
Added unit tests to verify the functionality still works.

lgtm, thank you!


Multi Swapping is working intermittently

I was trying to use the multi-swap option for the past 2 days and it is a hit or miss.
Sometimes it works, but I often get the "stale quote" error and it doesn't go anywhere

By the way, I can't join your Discord channel for some reason either.

Same, when I try to use the API. Sometimes it works but today it doesn't.


Update portforward for UI to handle multiple cluster use case

When debugging customers I need to be able to port-forward / connect to multiple at a time.
The UI requires 2 ports to be forwarded -- the static frontend and the websocket connection.
The JS is hardcoded to expect the websocket at 32082 ... so even though I can forward it on a different port I need the JS to know where to look.
Not sure what the best mechanism is here. One thing to consider is that multiple 'users' of a single cluster may want to forward on different ports ... so it seems like setting this server side isn't a good long term solution.

stale


Transaction Stuck and not showing on chain.so

I have the problem, that my transaction of ~1155 Dodge, that i sent through the Dogecoin Core wallet, has been stuck for almost 2 weeks now. Since its my first transaction of a bigger amount i didnt know, that i should increase the fee (made the transaction with the lowest fee).
I let the wallet fully sync since then, to see if that would fix the problem. But chain.so still doesnt show my transaction.
Is there anything I can do to get the transaction through or the money back into my wallet to resend it?

Hello @SokratesOne
I hope your issue is resolved by now. If not, I apologize for the delay. It seems you're facing a transcript error,It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID DOG07638
Please see the link below to our dedicated support line:
Dogecoin Network DApps Support Ticket Requests.
Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.


Question about mediation

Hey, this is a simple queston about mediation.
I've just configured the mediation on my admob account with adcolony.
On my project with swifty-ads, I already have the basic admob configuration working with a bottom banner.
I have added the pod 'GoogleMobileAdsMediationAdColony'. I need to add something else? The adcolony ads will be displayed on the same banner automatically?
Thanks!

Hey,
thanks for your comment. Essentially installing the google mediation pods is all you should have to do. There might be some extra setup code required for each network, which would be in the documentation for each mediation network. You will also have to setup some stuff on your google ad mob dashboard. I would recommend to double check the documentation from google https://developers.google.com/admob/ios/mediate as its changing quite frequently.


Introduce gosec for Static Application Security Testing (SAST)

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
Introduce gosec for Static Application Security Testing (SAST) for etcd-wrapper.
Which issue(s) this PR fixes:
Fixes #33
Special notes for your reviewer:
/invite @ashwani2k
Release note:

Introduce `gosec` for Static Application Security Testing (SAST) via `make sast` and `make sast-report`.

@oliver-goetz can you please let me know if this is the correct way of enabling the gosec-based SAST linting and including the linting logs as part of the OCM descriptor in the .ci/pipeline_definitions definition?


Group the import statements

We have rules for grouping import statements.
However, there are some places that are not observed from time to time.
Fix this.
How?
There is one fine-grained rule in rustfmt that lets you fix this all at once.
https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#imports_granularity
Last but not least, it's still unstable (need to use nightly cargo).
Therefore, it has not been applied yet, and it would be good to use this to correct only the wrong parts.

rustfmt.toml

imports_granularity = "One"

command

cargo +nightly fmt

Points to note
We will formally apply once this is stabilized.
Until then, you will want unstable settings to not exist.

Areas to which the found rules do not apply

Can I take this issue??

Can I take this issue??

Sure


Securityhub events

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yashbindlish great work!
todo:

[ ] scheduling of crawler (daily?)
[ ] create table - so that it would be possible to create dashboard directly after installation of data collection
[ ] readme with requirements explanations
[ ] test permissions for cloudwatch that logs are populated
[ ] test ways to re-post events from other organizations (probably additional CFN)
[ ] make a structure that will allow multi org

https://github.com/awslabs/cid-framework/issues/173 tracing task

consolidated.
closing in favor of https://github.com/awslabs/cid-framework/pull/199


Separate phyx.js into its own repository

The phyx.js library used to be a part of the Curation Tool, but is now being used as a backend library to the Clade Ontology as well. It might be worthwhile to split into its own repository. This wouldn't make a big difference in terms of the code, but would it would be nice to separate issues, tests and pull requests between issues relating to our model and the PHYX-to-JSON-LD conversion (in the new phyx.js or phyloref.js repository) and those related to the Curation Tool user interface.
The Clade Ontology and the Curation Tool could then separately include development versions of phyx.js using git submodules. Eventually, we'll probably want to publish phyx.js as a Node module to the npm registry, and then both the Clade Ontology and the Curation Tool could include it as an npm dependency.

This has been done in PR #137 (and moved to http://github.com/phyloref/phyx.js). Closing.


Create LICENSE

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cache tracing support cannot be enabled

Environment
I have "symfony/cache": "4.4.*" in my composer.json but still get the error message
Cache tracing support cannot be enabled because the symfony/cache Composer package is not installed.

This occurs since the PR of @ste93cry  https://github.com/getsentry/sentry-symfony/pull/487
4.1.0 works fine but 4.1.1 doesn't. Any idea why ?

Duplicate of #500

Didn't see it was already solved.
Would it be possible to make a new release ? :)

Yes, I tried yesterday but there are some issues with the bot that does the release and I'm waiting for the Sentry guys to help me sort the issue out 😉

Version 4.1.2 that includes the fix has been released 👍


Update retirement date

Changed retirement date from Nov1 to Dec1.

@carsonruebel : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@carsonruebel - please enter #sign-off for comment when you are ready.

#sign-off

@carsonruebel: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@carsonruebel - sorry. I didn't realize you were working in the public repo, not private. I will sign off now. I will send you instructions to configure your GitHub account so that you can submit a PR against the private repo. Thanks.
#sign-off


Add string accepting methods

Potential things to bikeshed:

Method names. You alluded to paramValueByName and paramValueDecodedByName. Personally I don't see that much of a point unless we can imagine another paramValueByX that accepts a String or you want to take a hardline stance and make this usage pattern less ergonomic so people use the faster index lookups. My point of reference here is ResultSet. It has both rs.getString(1) and rs.getString("columnName")

Throwing over returning Optional<String>. Given a totally blank slate I might have suggested the Optional, but I think having consistent behavior with the existing index lookups is more desirable.

Should paramIndex be exposed? Can always make that determination later.

If paramIndex is exposed, should it return an OptionalInt or an int with a throw? When its not exposed its whatever.

Nice. Exposing paramIndex as well sounds good. Seeing how the new paramValue(String paramName) & friends all throw if a matching parameter is not found, then a public paramIndex should perhaps do the same for consistency.
If desirable we could also later add e.g. paramValueOpt variants that return Optionals.