Implement HealthBalancer

etcd's go client leverages grpc health (https://github.com/coreos/etcd/blob/master/clientv3/client.go#L383) to unhealty endpoints are not taken into account, we should do the same here.

@lburgazzoli yeah, agreed.


tabline buffer-idx-mode doesn't expose key mappings

environment

vim: NVIM v0.4.4
vim-airline:
OS: Arch Linux with kernel x86_64 Linux 5.4.77-1-lts
Have you reproduced with a minimal vimrc: yes
What is your airline configuration:
Only use airline with two configs:
let mapleader = ","
let g:airline#extensions#tabline#enabled = 1
let g:airline#extensions#tabline#buffer_idx_mode = 1
if you are using terminal:
terminal: yes, alacritty
$TERM variable: xterm-256color
color configuration (:set t_Co?):
if you are using Neovim:
does it happen in Vim: yes

actual behavior
When I set the buffer_idx_mode = 1 (I also tested mode 2 and 3, same same), I don't get the key mappings as expected. Is the doc wrong?
expected behavior
It is documented that, I quote,

buffer_idx_mode allows 3 different modes to access buffers from the tabline. When enabled, numbers will be displayed in the tabline and mappings will be exposed to allow you to select a buffer directly. In default mode, when the variable is 1 Up to 11 mappings will be exposed.

So the expected behavior is, when I set the idx_mode to 1, I should've gotten at least 11 predefined key mapping, but I didn't.
screen shot (if possible)
I checked the key mapping, found it is not defined at all.

Are you using tabws or ctrlspace?

Am 18.11.2020 um 14:38 schrieb Ray<EMAIL_ADDRESS>
environment
vim: NVIM v0.4.4
vim-airline:
OS: Arch Linux with kernel x86_64 Linux 5.4.77-1-lts
Have you reproduced with a minimal vimrc: yes
What is your airline configuration:
Only use airline with two configs:
let mapleader = ","
let g:airline#extensions#tabline#enabled = 1
let g:airline#extensions#tabline#buffer_idx_mode = 1
if you are using terminal:
terminal: yes, alacritty
$TERM variable: xterm-256color
color configuration (:set t_Co?):
if you are using Neovim:
does it happen in Vim: yes
actual behavior
When I set the buffer_idx_mode = 1 (I also tested mode 2 and 3, same same), I don't get the key mappings as expected. Is the doc wrong?
expected behavior
It is documented that, I quote,
buffer_idx_mode allows 3 different modes to access buffers from the tabline. When enabled, numbers will be displayed in the tabline and mappings will be exposed to allow you to select a buffer directly. In default mode, when the variable is 1 Up to 11 mappings will be exposed.
So the expected behavior is, when I set the idx_mode to 1, I should've gotten at least 11 predefined key mapping, but I didn't.
screen shot (if possible)
I checked the key mapping, found it is not defined at all.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Are you using tabws or ctrlspace?
…
Am 18.11.2020 um 14:38 schrieb Ray @.***>:  environment vim: NVIM v0.4.4 vim-airline: OS: Arch Linux with kernel x86_64 Linux 5.4.77-1-lts Have you reproduced with a minimal vimrc: yes What is your airline configuration: Only use airline with two configs: let mapleader = "," let g:airline#extensions#tabline#enabled = 1 let g:airline#extensions#tabline#buffer_idx_mode = 1 if you are using terminal: terminal: yes, alacritty $TERM variable: xterm-256color color configuration (:set t_Co?): if you are using Neovim: does it happen in Vim: yes actual behavior When I set the buffer_idx_mode = 1 (I also tested mode 2 and 3, same same), I don't get the key mappings as expected. Is the doc wrong? expected behavior It is documented that, I quote, buffer_idx_mode allows 3 different modes to access buffers from the tabline. When enabled, numbers will be displayed in the tabline and mappings will be exposed to allow you to select a buffer directly. In default mode, when the variable is 1 Up to 11 mappings will be exposed. So the expected behavior is, when I set the idx_mode to 1, I should've gotten at least 11 predefined key mapping, but I didn't. screen shot (if possible) I checked the key mapping, found it is not defined at all. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

No, I don't use those plugins. I tried a minimal config with just ariline enabled, still the same thing. The screenshot shows that the key mapping was never defined, it is not an overwritten.

what is the output of :set tabline?

Please check the screenshot again that I should've upload earlier.  I deliberately opened few tabs, you can see the tabline setting's output.

Ah, I have read the help again. Forgot about that. What airline does, is  expose <Plug>AirlineSelectTab1 til <Plug>AirlineSelectTab9 pseudo-keys that you can map to whatever key you want. But if you want to have those mapped to e.g. <Leader>1 till <Leader>9, you have to update your .vimrc with those mappings as given in the help:
nmap <leader>1 <Plug>AirlineSelectTab1
nmap <leader>2 <Plug>AirlineSelectTab2
nmap <leader>3 <Plug>AirlineSelectTab3
nmap <leader>4 <Plug>AirlineSelectTab4
nmap <leader>5 <Plug>AirlineSelectTab5
nmap <leader>6 <Plug>AirlineSelectTab6
nmap <leader>7 <Plug>AirlineSelectTab7
nmap <leader>8 <Plug>AirlineSelectTab8
nmap <leader>9 <Plug>AirlineSelectTab9
nmap <leader>- <Plug>AirlineSelectPrevTab
nmap <leader>+ <Plug>AirlineSelectNextTab

Ah, understood. So I will close this issue. But please consider to change the help text, I bet it is not just me who will get confused.
By the way, this plugin rocks, thanks for the brilliant work!


[Docs] add get-started to userguide

What type of PR is this?
/kind documentation
What this PR does / why we need it:

Mainly add a page getting-started
Other minor changes

Which issue(s) this PR fixes:
Fixes #333
Does this PR introduce a user-facing change?
NONE

/ok-to-test

/approve
/lgtm


Force fzf-tmux to be used for CTRL-R (command history) usage

Hi there, is there a way (other than editing/overriding the function) to force fzf-tmux to be used when executing command history (CTRL+R) behaviors?
Thanks.

Unfortunately, no. But it's one of the things I've been meaning to address. We currently have $FZF_TMUX and $FZF_TMUX_HEIGHT, but they only affect CTRL-T. I think we should instead make separate vars for each key binding. Also, CTRL-T was implemented before fzf-tmux was added so it does not leverage the script.

I applied fzf-tmux to CTRL-R and ALT-C, so that all three key bindings now use tmux pane when available. I didn't try to add FZF_XXX_TMUX / FZF_XXX_TMUX_HEIGHT pairs for each one of them as it introduces too many configuration knobs.

Thanks tons June, i'll give it a try here shortly.

The change broke CTRL-R for me. After using it a few times it stops working. When I hit ENTER the prompt is still empty and it no longer gets the text.
After restarting the terminal it works a few times but the problem always comes back.
I am using zsh. Do you need any other information to find the bug?

@Tranquility Can't reproduce. So you mean that tmux split correctly appears and you can select an item there, but the selected one does not update command line, right? And how many is "a few times"?  Did you try re-sourcing ~/.fzf.zsh when that happens?

So you mean that tmux split correctly appears and you can select an item there, but the selected one does not update command line, right?

Exactly!

And how many is "a few times"?

I can't reproduce it reliably. Sometime it's two sometimes it's twenty. Sometimes it starts to work again after a few times. Sometimes it doesn't (or maybe I did not try enough times).

Did you try re-sourcing ~/.fzf.zsh when that happens?

Yes, I doesn't help.
I changed the fzfcmd to back from fzf-tmux to fzf for now.

@Tranquility I can't reproduce no matter how many times I try. I'm a bash user and there's nothing in my .zshrc. Maybe fzf conflicts with other parts of your zsh config.

I understand this one's failed..? I ended up here actually when looking for a solution to a different thing: I want to map pageup to, if on shell, roll history up (like prefix+pageup does). But this breaks pageup usage on fzf's history keybind for ctrl+r... any ideas on how to do both?
I currently have this on my .tmux.conf
bind -n Pageup if 'test "#{pane_current_command}" == "nano"' 'send Pageup' 'copy-mode -u'
bind -n S-Pageup copy-mode -u
bind -n S-Pagedown send-keys Pagedown

the if solved the pageup problem on nano, but no idea on how to solve it for fzf...


Leaving input field (blur) doesn't hide the calendar

Describe the bug
When having multiple inputs of any sort and using the Tab key to go to the next field, the Calendar is not hidden.
To Reproduce

Go to https://codepen.io/nyroDev/pen/LYbJpqK?editors=1010
Click on the date field
It will show the calendar
Hit the "Tab key" in order to go to the text field
The Focus is now on the text field, but the calendar is shown above it

Expected behavior
When leaving an input field (blur), the calendar should disapear.
Additional context
I'm not using the range selection, so the blur binding might have side effect here that I'm not aware of.

https://codepen.io/wakirin/pen/QWGVEMd?editors=1010
I will think about including it in the library.
This implementation may conflict with keyboardnav plugin.

Thanks for quick solution.


Added createTask route

Route created for input usersId, insuranceId, and challengeId with validation in it

sabihin mo na lang sakin pre if ayusin ko ung code structure para malinis tignan or etc


As a developer I would like to use MarkdownAPI for all markdown related tasks

Issue description / feature objectives
As of now reading of edited markdown controls is still partially done via ControlIOReader class. It would be nice to move that logic to the MarkdownAPI for consistency.
Additionally the markdown writing functionality can also be moved to that API.
Completion Criteria

All markdown-related reading operations are done via MarkdownAPI class.
Edited markdown controls are read using MarkdownAPI.
Nice to have: markdown-related writing operations are also done via MarkdownAPI

not worth it. Lot of refactoring.


A Neural Turing Machine to texts classification using Keras

I just read the Keras Documentation, in which I meet one sentence "Building a network of LSTMs, a deep CNN, a Neural Turing Machine, a word2vec embedder or any other model is just as fast".
Had someone implement a Neural Turing Machine to process texts using Keras? Could you let me study the codes and method? Thanks a lot.

If I recall right it was removed from the repo some time ago

see #1520

check this out and let me know if works for you:
https://github.com/EderSantana/seya/blob/master/examples/NTM.ipynb


Types declared with 'newtype" as list in Datum or Redeemer make plutus compiler fail when type declaration is in a separate file

Area
[x] Plutus Foundation Related to the GHC plugin, Haskell-to-Plutus compiler, on-chain code
[] Plutus Application Framework Related to the Plutus application backend (PAB), emulator, Plutus libraries
[] Marlowe Related to Marlowe
[] Other Any other topic (Playgrounds, etc.)
Summary
When separating code over different files e.g. Types.hs and OnChain.hs and using a list of a "newtype" declaration in Datum or Redeemer, the plutus compiler fails.
If the declaration of the "newtype" and Datum/Redeemer is in the same file as the
"typedmkMyValidator :: Scripts.TypedValidator ..."
the plutus compiler works fine.
It just happens when its separated over two files and the types are imported. This happens not just with user defined types but with any types declared with the "newtype" variant (AssetClass, Value,...).
Steps to reproduce
Steps to reproduce the behavior:

Write a simple validator Script where the Datum or Redeemer contain a list of types declared with "newtype". Separate type declaration and 'TypedValidator' in two files and import the types to the validator file.  (example code in additional context)

2.' cabal build'

See error: -> see at attachments

Move 'MyRedeemer' and 'MyNewtype' to OnChain.hs without changing anything else to the file with the TypedValidator

cabal build

no error

Expected behavior
Should be possible to separate Types, OnChain and OffChain code over different files without plutus compiler issues.
System info (please complete the following information):

OS:  Ubuntu, nix
Version 20.04
6afba11d853605bfbe127213e894bc57a21c8e01

Screenshots and attachments

Cut of plutus compile error (its very very long and gives no information expect in beginng /end):
Beginning:
GHC Core to PLC plugin: E043:Error: Reference to a name which is not a local, a builtin, or an external INLINABLE function: Variable Types.$fUnsafeFromDataMyRedeemer_go           OtherCon [] Context: Compiling expr: Types.$fUnsafeFromDataMyRedeemer_go Context: Compiling expr: Types.$fUnsafeFromDataMyRedeemer_go                          (PlutusTx.Builtins.Internal.unsafeDataAsList                             (PlutusTx.Builtins.Internal.head                                @ PlutusTx.Builtins.Internal.BuiltinData                                (PlutusTx.Builtins.Internal.snd                                   @ PlutusTx.Builtins.Internal.BuiltinInteger                                   @ (PlutusTx.Builtins.Internal.BuiltinList                                        PlutusTx.Builtins.Internal.BuiltinData)                                   tup)))

End:
Context: Compiling definition of: Types.$fUnsafeFromDataMyRedeemer Context: Compiling expr: Types.$fUnsafeFromDataMyRedeemer Context: Compiling expr: Ledger.Typed.Scripts.Validators.wrapValidator                            @ Types.MyDatum                            @ Types.MyRedeemer                            Types.$fUnsafeFromDataMyDatum                            Types.$fUnsafeFromDataMyRedeemer Context: Compiling expr at "debugging-<IP_ADDRESS>-inplace:OnChain:(57,8)-(57,37)"
Additional context
Code:
Types.hs:
`{-# LANGUAGE DataKinds             #-}
{-# LANGUAGE DeriveAnyClass        #-}
{-# LANGUAGE DeriveGeneric         #-}
{-# LANGUAGE DerivingStrategies         #-}
{-# LANGUAGE GeneralizedNewtypeDeriving #-}
{-# LANGUAGE FlexibleContexts      #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE NoImplicitPrelude     #-}
{-# LANGUAGE OverloadedStrings     #-}
{-# LANGUAGE ScopedTypeVariables   #-}
{-# LANGUAGE TemplateHaskell       #-}
{-# LANGUAGE TypeApplications      #-}
{-# LANGUAGE TypeFamilies          #-}
{-# LANGUAGE TypeOperators         #-}
module Types where
import           Data.Aeson          (FromJSON, ToJSON)
import           GHC.Generics        (Generic)
import qualified PlutusTx
import           PlutusTx.Prelude    hiding (Semigroup(..), unless)
import qualified Prelude             (Show,Eq,Ord)
import           Ledger.Value        (AssetClass (..))
import qualified Ledger.Typed.Scripts as Scripts
data MyCustom = MyCustom
{
data1     ::  [AssetClass]             -- without list works
, data2     ::  [BuiltinByteString]
} deriving (Prelude.Show, Generic, FromJSON, ToJSON, Prelude.Eq)
PlutusTx.makeIsDataIndexed ''MyCustom [('MyCustom, 0)]
PlutusTx.makeLift ''MyCustom
{- Move MyRedeemer and MyNewtype to OnChain.hs without changing anything else -> works -}
{- START COMMENT
Comment between this to get working example -}
newtype MyNewtype = MyNewtype { unNewType :: Integer }
deriving stock   (Prelude.Show, Generic)
deriving newtype (ToJSON, FromJSON, Prelude.Eq)
PlutusTx.makeIsDataIndexed ''MyNewtype [('MyNewtype, 0)]
PlutusTx.makeLift ''MyNewtype
data MyRedeemer = RA [MyNewtype] | RB Integer   -- Delete the List and make it Single 'MyNewtype' -> it works |
-- change RA to 'MyCustom', same error, change data1 to just AssetClass without list -> it works
deriving (Prelude.Show, Generic, FromJSON, ToJSON, Prelude.Eq)
PlutusTx.makeIsDataIndexed ''MyRedeemer [('RA, 0),('RB, 1)]
PlutusTx.makeLift ''MyRedeemer
{- END COMMENT -}
data MyDatum =
MyDatum
deriving stock (Prelude.Show)
PlutusTx.makeIsDataIndexed ''MyDatum [('MyDatum, 0)]
PlutusTx.makeLift ''MyDatum`
OnChain.hs:
`{-# LANGUAGE DataKinds           #-}
{-# LANGUAGE DeriveAnyClass      #-}
{-# LANGUAGE DeriveGeneric       #-}
{-# LANGUAGE DerivingStrategies         #-}
{-# LANGUAGE GeneralizedNewtypeDeriving #-}
{-# LANGUAGE FlexibleContexts    #-}
{-# LANGUAGE NoImplicitPrelude   #-}
{-# LANGUAGE OverloadedStrings   #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TemplateHaskell     #-}
{-# LANGUAGE TypeApplications    #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE TypeFamilies        #-}
{-# LANGUAGE TypeOperators       #-}
module OnChain where
import           Data.Aeson          (FromJSON, ToJSON)
import           GHC.Generics        (Generic)
import           Ledger                 hiding (mint, singleton)
import           PlutusTx.Builtins
import qualified Ledger.Typed.Scripts as Scripts
import qualified PlutusTx
import           PlutusTx.Prelude       hiding (Semigroup(..), unless)
import           Prelude                (Semigroup (..), Show (..), Eq, Ord)
import Types
{- Uncomment for working code
newtype MyNewtype = MyNewtype { unNewType :: Integer }
deriving stock   (Prelude.Show, Generic)
deriving newtype (ToJSON, FromJSON, Prelude.Eq)
PlutusTx.makeIsDataIndexed ''MyNewtype [('MyNewtype, 0)]
PlutusTx.makeLift ''MyNewtype
data MyRedeemer = RA [MyNewtype] | RB Integer   -- change RA to 'MyCustom', same error, make data1 just AssetClass without list it works
deriving (Prelude.Show, Generic, FromJSON, ToJSON, Prelude.Eq)
PlutusTx.makeIsDataIndexed ''MyRedeemer [('RA, 0),('RB, 1)]
PlutusTx.makeLift ''MyRedeemer
-}
mkMyValidator :: MyDatum -> MyRedeemer -> ScriptContext -> Bool
mkMyValidator d r ctx = True
data Dating
instance Scripts.ValidatorTypes Dating where
type instance DatumType Dating = MyDatum
type instance RedeemerType Dating = MyRedeemer
typedmkMyValidator :: Scripts.TypedValidator Dating
typedmkMyValidator = Scripts.mkTypedValidator @Dating
($$(PlutusTx.compile [|| mkMyValidator ||]) )
$$(PlutusTx.compile [|| wrap ||])
where
wrap = Scripts.wrapValidator @MyDatum @MyRedeemer
`

Please try to add the following options to your cabal file:
- `-fno-ignore-interface-pragmas`
- `-fno-omit-interface-pragmas`
- `-fobject-code`

Or state as GHC options in the .hs files:
{-# OPTIONS_GHC -fno-omit-interface-pragmas #-}
{-# OPTIONS_GHC -fno-ignore-interface-pragmas #-}
{-# OPTIONS_GHC -fobject-code #-}

Thank you for your reply.
I had the ghc options set already.
Added it also to the .hs files but has no effect.


Can i force open calendar dropdown on clicking external button?

I need to open/close calendar dropdown on click of an external button. I am maintaining a local state flag "startOpenFlag" which is false by default. And in my  options i have startOpen={this.state.startOpenFlag}
On click of myButton i am setting this flag to true. But, calendar dropdown doesn't seem to open.
Any help appreciated.

i got simple solution ....default props of react datepcicker ...which is open props...using this u can  easly toggle ur calender ....
i created one useState  const [open ,setOpen]=useState(false);
const toggle =()=>{
setOpen(!open))
}
use this function in button
<button onClick={()=>toggle()}>click
and in date picker we have to pass open props


examples/branch_and_bound.py fails with python3

examples/branch_and_bound.py works only with python2 due to use of the Queue module.   A simple fix:
try:
from Queue import PriorityQueue
except:
from queue import PriorityQueue

Thanks for pointing this out! I've made the change you suggested.


Legend Panel img/html display

adding layout specific image display functionality to the legend
includes an interactive html (preprocessed) plot display.

implemented upload of files (jpeg,jpg,png,gif,html) to both uploaders (optional) and display for all in legend panel (in case folder is not empty, otherwise no div for imagefiles is shown).


[Hexagon] Add feature to copy logcat to --hexagon-debug and add new --sysmon-profile option to run sysmon profiler during the test

I added some things to the hexagon pytest plugin to make working on hexagon a little bit easier sometimes.
--hexagon-debug will now copy all of the logcat logs for the time period of the test and copy them back to your device.
--sysmon-profile will start the Sysmon Profiler before your run, shut it down afterwards and then copy the data back and parse it to html for you.
cc @mehrdadh cc @supersat

@tvm-bot rerun

I would also run logcat -c before execution if --hexagon-debug is specified to clear out old logcat entries from previous runs.

I would also run logcat -c before execution if --hexagon-debug is specified to clear out old logcat entries from previous runs.

I usually dont want to have this delete old logs because I sometimes find them useful. The logcat scanner should be able to accurately pickup the right logs for just the run. Ill add it as a separate option that can be used if desired.

Added the clear-logcat option and moved to the launcher as @mehrdadh requested.

@tvm-bot rerun

@tvm-bot rerun


[ERROR] DeepLabV3+DenseNet Backbone

Hi,
I have a question when I try to train DeepLabV3 with DenseNet backbone.
the loss term of DeepLabV3.
I wonder why you use this auxiliary loss term. As far as I know, original DeepLabV3 was not trained by the auxiliary cross-entropy loss.
As your code  about deeplabv3 was hard-coded, it should be fixed for other backbone (i.g., DenseNet).
Thanks

Original DeepLabV3 maybe not be trained with auxiliary, and I haven't tested the influence of it.
The code is really hard-coded. You could simply fix it by replacing 2048 with self.backbone.num_features.


.zshrc file is missing & uninstall not working

I received a successful completion message for the installation of oh my zsh and saw all the text like you were supposed to, however I don't have a .zshrc file.  People online said to just create one, so I did, but adding themes didn't do anything.
I thought maybe I'd try to uninstall and reinstall, but the uninstall command provided in the wiki doesn't work either.
Any help you could provide would be greatly appreciated.

What are the contents of the .zshrc file you created?

All I did was put in
ZSH_THEME="robbyrussell"
I was just trying to test to see if it was working or not.  I saw that it looked like the default file had more in it, however the online community seemed to think as long as you just have that in there it will change the theme.  If I’m supposed to copy and paste a block of text in please just provide the text file and I’ll do so.  I also wanted to create some aliases but those weren’t working either.
From: Kaleb Elwert<EMAIL_ADDRESS>Sent: March 7, 2017 4:59 AM
To: robbyrussell/oh-my-zsh<EMAIL_ADDRESS>Cc: bgb0923<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [robbyrussell/oh-my-zsh] .zshrc file is missing & uninstall not working (#5939)
What are the contents of the .zshrc file you created?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/robbyrussell/oh-my-zsh/issues/5939#issuecomment-284675362 , or mute the thread https://github.com/notifications/unsubscribe-auth/AWUhlLJX6eJXamd3HtpNQna31nQB9fKrks5rjSpggaJpZM4MU2yl .  https://github.com/notifications/beacon/AWUhlOugDs2qFOLJMA9IaqXBh1kRwf2bks5rjSpggaJpZM4MU2yl.gif


AQ-mini error

AQ-mini error (after "genmove" or other available command):
"Unhandled exception: illegal instruction in 64-bit code (0x000000014025f48b)."

This issue mentions an older version, or hasn't been discussed in a long time, so we close it.


python extracting functions inside a class doesn't recognize self keyword

I am at commit fef309f654906d931f2c714a77f5182fe70ada7d.
The following example code is:
class dog:

    def cat(self, mouse):
        self.tiger = 0
        self.mouse = mouse

visually select the two lines:
        self.tiger = 0
        self.mouse = mouse

and extract the function, naming it as extracted_function, the output is
class dog:

    def extracted_function(self, mouse, self):
        self.tiger = 0
        self.mouse = mouse

    def cat(self, mouse):
        self.extracted_function(mouse, self)

the correct result should be
class dog:

    def extracted_function(self, mouse):
        self.tiger = 0
        self.mouse = mouse

    def cat(self, mouse):
        self.extracted_function(mouse)

@milanglacier Merged in a fix for this, please let us know if there are still issue surrounding this.

works great!
Thanks!


part of angular-ui

Is your directive still part of angular-ui? Followed link doesn't work:
https://github.com/angular-ui/ui-utils/tree/master/modules/scroll

We are in the process of negotiations... Soon the directive will get its own repository within angular-ui (instead of angular-ui/ui-utils which is deprecated now).
Take a look at https://github.com/angular-ui/ui-utils/pull/406#issuecomment-119776352

ok, but at this moment, can I download builded js file somewhere? I'm currently hacking it with your grunt build script.

I've merged a PR https://github.com/Hill30/NGScroller/pull/94 an hour before your last reply, which changes the structure of repo and provides a direct access to js artifacts: https://github.com/Hill30/NGScroller/tree/master/dist
Also please note https://github.com/Hill30/NGScroller/blob/master/bower.json#L6

Thanks!


BUG: remove highest_d_obj, mismatching gap and X.T @ theta

@ksehic can you check whether or not this PR fixes the convergence issue you found ?

Codecov Report

Merging #175 (ebf7e70) into master (103f44d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   85.14%   85.14%
=======================================
  Files          14       14
  Lines        1023     1023
  Branches      143      143
=======================================
  Hits          871      871
  Misses        109      109
  Partials       43       43

Impacted Files
Coverage Δ

celer/__init__.py
100.00% <100.00%> (ø)

celer/tests/test_lasso.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103f44d...ebf7e70. Read the comment docs.

did you bench the impact ?

If you have an extensive automated way to bench I'm interested
I usually run it on a random dataset with random params
there is no clear variation here:
this PR:
%timeit -n10 -r10 clf.fit(X, y)  # noqa
## -- End pasted text --
629 ms ± 38.2 ms per loop (mean ± std. dev. of 10 runs, 10 loops each)

master:
%timeit -n10 -r10 clf.fit(X, y)  # noqa
## -- End pasted text --
606 ms ± 50.3 ms per loop (mean ± std. dev. of 10 runs, 10 loops each)

where the problem is:
from celer import Lasso
from libsvmdata import fetch_libsvm
import numpy as np

from numpy.linalg import norm

X, y = fetch_libsvm("rcv1_train")
alpha_max = norm(X.T @ y, ord=np.inf) / len(y)

clf = Lasso(alpha=alpha_max/20, fit_intercept=False)

let's merge then


spark 2.X could not be analyzed?

i build project  compile.conf
hadoop_version=2.6.0
spark_version=1.6.0
i run my spark app in spark 2.X
now there is no error messages in dr_elephant.log
but in my dr-elephant web

so. i need compile the project with hadoop2.X spark 2.X ?
but it will encounter another build problems.what should i do ?

I change my compile.conf and specify spark_version=2.1.1 , but it can't build successfully .
Does Dr.Elephant  not support Spark 2.X ?

Dr Elephant does not support Spark 2.X

@shkhrgpt do you mean the fetcher is not able to parse it or Dr. E itself would not build with 2.X?

Dr Elephant would not build with Spark 2.X after SparkFSFetcher is added because of Spark listener classes. The workaround would to build with Spark 1.X and use it against Spark 2.X but that would only work as long Spark REST fetcher is used.

I see, thanks for clarifying this.

@akshayrai  why not we get another branch to support dr.elephant with spark 2.X?

@BruceXu1991 I don't think we need a separate branch for Spark 2.X. Even in the same branch, we should add Spark 2.X support without breaking Spark 1.X.

agree with you, we should add Spark 2.X support instead of have a separate branch for Spark 2.X

Does anyone work on this?

I am here to modify the support spark2.0

I build project  compile.conf
HADOOP_VERSION="2.6.0"
SPARK_VERSION="1.6.3"
compile success.   But in the web ui I cann't see the spark job！！

The log has the error.

But I config the SPARK_HOME

And my spark can run

I tried Spark REST fetcher with Spark 2.2, getting the following exception and the metrics have zero value:
[error] o.a.s.s.ReplayListenerBus - Exception parsing Spark event log: application_1510469066221_0020
org.json4s.package$MappingException: Did not find value which can be converted into boolean
at org.json4s.reflect.package$.fail(package.scala:96) ~[org.json4s.json4s-core_2.10-3.2.10.jar:3.2.10]
at org.json4s.Extraction$.convert(Extraction.scala:554) ~[org.json4s.json4s-core_2.10-3.2.10.jar:3.2.10]
at org.json4s.Extraction$.extract(Extraction.scala:331) ~[org.json4s.json4s-core_2.10-3.2.10.jar:3.2.10]
at org.json4s.Extraction$.extract(Extraction.scala:42) ~[org.json4s.json4s-core_2.10-3.2.10.jar:3.2.10]
at org.json4s.ExtractableJsonAstNode.extract(ExtractableJsonAstNode.scala:21) ~[org.json4s.json4s-core_2.10-3.2.10.jar:3.2.10]
at org.apache.spark.util.JsonProtocol$.storageLevelFromJson(JsonProtocol.scala:881) ~[org.apache.spark.spark-core_2.10-1.6.3.jar:1.6.3]
[error] o.a.s.s.ReplayListenerBus - Malformed line #37: {"Event":"SparkListenerJobStart","Job ID":0,"Submission Time":1511486140513,"Stage Infos":[{"Stage ID":0,"Stage Attempt ID":0,"Stage Name":"collect at /home/hadoop/classify_image_pyspark_emr.py:185","Number of Tasks":512,"RDD Info":[{"RDD ID":1,"Name":"PythonRDD","Callsite":"collect at /home/hadoop/classify_image_pyspark_emr.py:185","Parent IDs":[0],"Storage Level":{"Use Disk":false,"Use Memory":false,"Deserialized":false,"Replication":1},"Number of Partitions":512,"Number of Cached Partitions":0,"Memory Size":0,"Disk Size":0},{"RDD ID":0,"Name":"ParallelCollectionRDD","Scope":"{"id":"0","name":"parallelize"}","Callsite":"parallelize at PythonRDD.scala:480","Parent IDs":[],"Storage Level":{"Use Disk":false,"Use Memory":false,"Deserialized":false,"Replication":1},"Number of Partitions":512,"Number of Cached Partitions":0,"Memory Size":0,"Disk Size":0}],"Parent IDs":[],"Details":"org.apache.spark.rdd.RDD.collect(RDD.scala:935)\norg.apache.spark.api.python.PythonRDD$.collectAndServe(PythonRDD.scala:458)\norg.apache.spark.api.python.PythonRDD.collectAndServe(PythonRDD.scala)\nsun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\nsun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\nsun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\njava.lang.reflect.Method.invoke(Method.java:498)\npy4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)\npy4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)\npy4j.Gateway.invoke(Gateway.java:280)\npy4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)\npy4j.commands.CallCommand.execute(CallCommand.java:79)\npy4j.GatewayConnection.run(GatewayConnection.java:214)\njava.lang.Thread.run(Thread.java:748)","Accumulables":[]}],"Stage IDs":[0],"Properties":{"spark.rdd.scope.noOverride":"true","callSite.short":"collect at /home/hadoop/classify_image_pyspark_emr.py:185","spark.rdd.scope":"{"id":"1","name":"collect"}"}}

Please refer #327 for the updates.

let  me look your app-conf/FetcherConf.xml file

I am also fetching same issue. Compiled Dr Elephant with Spark 1.X and analyzing spark 2.X jobs.

I had solved this problem and I can push git
At 2018-11-17 23:32:00, "ankurchourasiya"<EMAIL_ADDRESS>wrote:
I am also fetching same issue. Compiled Dr Elephant with Spark 1.X and analyzing spark 2.X jobs.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I solved this problem

my address https://github.com/Hanqingkuo/dr.elephant-spark2.x

It will be nice if u pull a request here.  @Hanqingkuo

@Hanqingkuo  Thanks for sharing code. I could compile dr elephant and now able to see jobs in UI. Though Malformed record error is still there in logs also Heuristics seems to be not captures correctly. Running on Spark 2.3.
Have you also faced such issue: (Screen capture)

可能是没有收集算法吧 需要你自己写
At 2018-12-03 18:42:08, "ankurchourasiya"<EMAIL_ADDRESS>wrote:
@Hanqingkuo Thanks for sharing code. I could compile dr elephant and now able to see jobs in UI. Though Malformed record error is still there in logs also Heuristics seems to be not captures correctly. Running on Spark 2.3.
Have you also faced such issue: (Screen capture)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


bamtools installation error

CMake Error at CMakeLists.txt:37 (message):
BamTools requires an out of source build.
$ mkdir build
$ cd build
$ cmake ..
$ make

(or the Windows equivalent)
Call Stack (most recent call first):
CMakeLists.txt:41 (ensure_out_of_source_build)
-- Configuring incomplete, errors occurred!
See also "/home/biosoft/bamtools/CMakeFiles/CMakeOutput.log".
I have mkdir build. how to deal with this? Thanks!

if mkdir build && cd build && cmake .. && make doesn't work for you, then you might have to checkout a few CMake tutorials.


Debugging Test Failures

Experimental PR to run pipelines.  Trying to nail down what is causing test failures in #62

It looks like the failure is caused by the changes in minimagic.cs

Missing stream reset in minimagic.  Fixed in #62


Update README.md

Added wiki links under the Usage Guide section from wiki in README.md file.

:tada: This PR is included in version 1.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Inconsistency between MIN_SEED_LOOKAHEAD and validator spec

The validator spec states:

The beacon chain shufflings are designed to provide a minimum of 1 epoch lookahead on the validator's upcoming committee assignments for attesting dictated by the shuffling and slot. Note that this lookahead does not apply to proposing, which must be checked during the epoch in question.

However, the shuffling for current_epoch + 1 depends on the RANDAO mix for current_epoch + 1 - MIN_SEED_LOOKAHEAD, i.e. current_epoch with the lookahead set to 1 as it currently is. But this RANDAO mix for the current epoch changes every time a block is processed (as per process_randao). Put another way: once a validator has transitioned to some epoch, they use the RANDAO mix from the previous epoch to determine their shuffling, and this RANDAO mix is changing right up until the last slot of the previous epoch.
In Lighthouse we were contemplating deleting our cache of the shuffling for the next epoch for this reason! See: https://github.com/sigp/lighthouse/issues/407
It would be good to have some clarity on whether the behaviour of the validator spec or of the beacon chain spec is what we really want. If the lookahead behaviour is desired (which seems reasonable to me), I think we should update the beacon chain spec to account for the RANDAO mix changing in the current epoch.

This looks like an off-by-one error.
We should be getting the mix from get_randao_mix(state, Epoch(epoch + EPOCHS_PER_HISTORICAL_VECTOR - 1 - MIN_SEED_LOOKAHEAD)) in get_seed (additional - 1) as the randao lookup.
Need to either adjust the constant to 2 as you noted or add the -1. Need to think about the semantics a bit.
Off today through the weekend. Will pick this up monday

Yeah I think the additional -1 is clearer than setting MIN_SEED_LOOKAHEAD to 2. Unless we change the name of the variable to make sense with the 2 value meaning "look at the randao from 2 epochs back".

close via #1296


🧑💻: Enhance star button

Title
Enhance star button
Enhancement Aim
My main objective is to enhance the star and also increase the  link coverage range.
Changes
Add the  at the outside so user cna immediately click on it and don't have to got to the star US text-area
Screenshots 📷

Guidelines

[X] I have read the guidelines
[X] I have the link to my latest merged PR

Full Name
Yash K. Saini
Participant Role
GSSoC-Ext

@vanshchauhan21 I would like to work on this small fix, can you assign me this issue


Not loading /storage/emulated

Testing this application from F-Droid, hope the issue wasn't solved yet. Anyway the application starts correctly in /storage/emulated/0 on my Xperia M4 (Marshmallow, 6.0), but if I go a level up to /storage/emulated, then it shows no folder at all. Had a similar issue programming myself, not sure how to solve it. Maybe check the roots available and show items you know from the root path (e.g. from such path you could know you had to show a 0 folder there).

I'm convinced this is because Android read protects that directory. Can you try with a file manager that has root access? I don't have any rooted devices myself :)


error-reporting: Skip authentication for error-reporting when API key is provided

Addresses #2302
When key is provided, the error reporting service instance doesn't go through the OAuth2 process. This means that if a provided API key is invalid, errors will never be sent (there is no fallback); however, an error will be printed in this case.

Coverage remained the same at 100.0% when pulling 84e7aa552309706e8631b898ee4e64005a308c5c on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling d31902d0b9be4a3eb5aec60d2261ac5ae83c4815 on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 020bc03d3b3e388dea8483d75d4e5abe4062a99a on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 5ac2baa6b6a3bff5cbfdadd65c67391076540fbf on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 689a233b5155dd3eecb54c932f785a931519b32f on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 689a233b5155dd3eecb54c932f785a931519b32f on kjin:e-r-a into f243e2698ec47db273bd95e52aa93c90f3c6a80b on GoogleCloudPlatform:master.

@ofrobots PTAL. The most recent commit warns if the API key is invalid ahead of time, but depends on the error message in the response body. This works, but if you think it's too fragile I'll revert to the previous commit, which adds in the README a message informing users that the we won't be able to detect invalid API keys ahead of time.

@ofrobots Another question that we should ask is: Is this something we want to support? I was of the understanding that not supporting API keys in the client libraries was an intentional decision. I am definitely hesitant to add it as a one-off in a single library.

@lukesneeringer The API is not being added, but rather fixed in this PR. For whatever historical reasons, error-reporting started with API key support and removing it at this point is going to break existing users. I'm :-1: on that.

@ofrobots @DominicKramer I've added a system test to check that the messages supplied from the Stackdriver Errors API are in line with what we expect. I think this is a reasonable way to act upon any future changes in the API - let me know your thoughts.

Coverage remained the same at 100.0% when pulling 80b5dd071b98a9af6fdc79ecedcc1b89622d83a5 on kjin:e-r-a into 9e78eba27177a891742f156899a7689b089cb39e on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 8b7f9bcd6475c7ceee041450d86b4f9ebcb2a769 on kjin:e-r-a into 9e78eba27177a891742f156899a7689b089cb39e on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling a2dff29c2683024499cd09a1942784e434b1c65d on kjin:e-r-a into 9e78eba27177a891742f156899a7689b089cb39e on GoogleCloudPlatform:master.

@stephenplusplus Could you do a release of the error-reporting library? I think this is a semver-patch change. Thanks!

Published 0.2.2!


Add support for edit budget command

Codecov Report

Merging #151 into master will decrease coverage by 1.21%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a4a7...ca7d0d7. Read the comment docs.


Update createdbtables.sql

Updating local development script to reflect current database schema.

Codecov Report

Merging #352 (5a58361) into main (1f6f63a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   68.78%   68.78%
=======================================
  Files          11       11
  Lines        2034     2034
=======================================
  Hits         1399     1399
  Misses        534      534
  Partials      101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6f63a...5a58361. Read the comment docs.


test(lint): add super-linter

closes #301

Closing for now; if you're interested in pursuing this, please feel free to comment or reopen it. Thank you!


Add uncertainty for points

Let the user specify the point uncertainty for the region assignment. Output all values of the assignment that or not None.
Example in siibra documentation

Wait for bugfix https://github.com/FZJ-INM1-BDA/siibra-python/issues/338


Sample code not working

I cant make this sample code to work:
http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/simple
I think the sample code and the output does not match?

Sorry my bad

@louiealmeda Even I cant make the sample demo of simple list work. Not sure what I am missing here. Can you throw some light what exactly you were missing?

@meenakshijha sorry I don't recall that specific solution, But I do remember that I had to include the element or controller that contains the example which is not shown in the demos itself. That's why it is indeed confusing


Azure/GCP

What this PR does / why we need it:
Adds support for Azure/GCP Windows cloud providers
How can this PR be verified?
Deploy Windows workers to those environments
Is there any change in kubo-release?
No
Is there any change in kubo-ci?
No
Does this affect upgrade, or is there any migration required?
No
Which issue(s) this PR fixes:
None
Release note:
Add opsfiles for configuring Windows workers on Azure and GCP

This is built on top of #392

A story has been created for this in our tracker https://www.pivotaltracker.com/story/show/165840796


When Razor views are compiled, i'd like to get access to resulting C# code

I'm trying to examine C# code that is produced when Razor compiles .cshtml files, but can't find any good option to do so.
Describe the solution you'd like
Ideally - I'd like to see resulting C#  files as sub-items of the .cshtml files (like https://github.com/RazorGenerator/RazorGenerator allows for non-core MVC). But really, any non-hacky solution which lets me feed in .cshtml files and outputs C# files will do.
Additional context

You can look at the generated Razor files under the obj\Debug\$TargetFramework$\Razor.


Received event after patch using @EnableMockOperator

I found a weird behaviour creating a test using @EnableMockOperator.
When I return the control using patchStatus:
return UpdateControl.patchStatus(resource);

I receive immediately a new event for that resource, but if I'm not wrong, this is not the behaviour expected. I mean in a real Kubernetes cluster after patchStatus I don't receive a new event for that resource.
In the other hand, if I use updateStatus with @EnableMockOperatorit works fine, I mean I don't receive a new event.

Hi @jmformenti
this seems to be an issue in mock server. Pls create an issue in Fabric8 Client:
https://github.com/fabric8io/kubernetes-client
Since the mock server is implemented there.
thank you!

Now it's working fine :+1:


User profile icon when logged in

Removed Duplicate.
Refer to https://github.com/The-Sciences-and-Engineering-Squad/Marketext/pull/38


Merge remote-tracking branch 'upstream/master' into stable

In preparation of 2.068.0.

Hi Martin, everything OK? Some people are worried<EMAIL_ADDRESS>

See https://github.com/D-Programming-Language/dmd/pull/4748#issuecomment-112948509.


pm storage cleanup and pm storage archive-to-swestore

pm storage cleanup will go through all data_dirs in the config file, check for finished runs in there (presence of RTAComplete.txt) and move them to nosync
pm storage archive-to-swestore will go through all nosync directories within all data_dirs in the config file, compress raw data, send it to swestore and remove it from the disk

I am not double checking adler32 calculations because it is actually done, with md5sum, during the transfer to SWESTORE with the -K option.

Thanks guys, I'll fix what you reported and check the travis build on Monday, have a nice weekend!

ok @senthil10 and @remiolsen , please have a second look, I've worked on your suggestions :+1:

Awesome @guillermo-carrasco, looks good for me :) Hope @remiolsen will be happy with this. So merging it :+1:

All good :+1:

Tackar!


[Torch] Support aten::lstm

It seems the commonly used torch.nn.LSTM module generates aten::lstm op, which we currently don't support. It is reported in https://discuss.tvm.apache.org/t/import-rnn-t-pytorch-model-into-tvm/7874 and it is likely we'll get more requests for this op in the future.
The corresponding PyTorch implementation is here https://github.com/pytorch/pytorch/blob/70c8daf43946b53af6493d058899ef952d27d339/aten/src/ATen/native/RNN.cpp#L1396

I believe the MXNet frontend lowers LSTM to Relay directly.

But, the pre-trained rnn-t model  https://zenodo.org/record/3662521 is a pytorch model. Can you support the torch.nn.LSTM by aten::lstm in TVM ?

yes, torch.nn.LSTM is translated to aten::lstm in Torchscript.

yes, torch.nn.LSTM is translated to aten::lstm in Torchscript.

Hi, do you have a plan when you will support the aten::lstm in tvm/relay/frontend/pytorch.py ?

No from my end. I'm not expert on LSTM and don't have time for this.

https://github.com/apache/tvm/pull/8447


composer install for private repositories

I don't see documentation for how to install github private repositories. is there any way to do that?

@jeysaravana Composer can use Git and its authentication system for pulling down private packages as described here https://getcomposer.org/doc/articles/handling-private-packages.md
So something like this in your composer.json should work:
{
  "name": "your/vip-go-site",
  "repositories": [
    {
      "type": "composer",
      "url": "https://wpackagist.org"
    },
    {
      "type": "git",
      "url": "git@github.com:example-vendor/package-repo.git"
    }
  ],
  "require": {
    "example-vendor/package-repo": "1.2.3"
  }
}

@kasparsd thanks for the instant reply. I want to use that in VIP as well. How it will handle the authentication. So I won't commit my plugins to the repo.

@jeysaravana Oh, so would like to have your CI/CD pipeline deploy the code to VIP, including those private dependencies, right?
Ideally, you would create a new GitHub "machine user" which is then given read access to the private dependency repository and "write" access to the VIP Go upstream repository. You would then need to create a new GitHub token (or SSH key) for that machine user which can then be used to act as that machine user from any computer that has access to that token.
Finally, you need to feed that token to the CI/CD process and this depends on the CI/CD service you're using. With GitHub actions this can be done using secrets during the checkout action. On Travis it would be easier to use a dedicated SSH key associated with the machine user which is then used by the Travis runner https://docs.travis-ci.com/user/private-dependencies/#user-key
This VIP site template defaults to using Travis and the SSH key pair to do the authentication as the machine user.

@kasparsd ,
yes. that's what I was looking. thanks much for your info. I thought VIP will have Travis. but now I see that we need to setup that.


docs/guide-ru/db-active-record.md fix some typos

fix some typos

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
---

Fixed issues
---

Спасибо


[Service Bus] Add new DeadLetterMessageAsync overloads

Summary
The goal of these changes is to add new overloads to ServiceBusReceiver.DeadletterMessageAsync and ServiceBusMessageActions.DeadLetterMessageAsync that take in a properties dictionary and a dead letter reason and error description. Previously, there was the only the option to pass in a properties dictionary or a reason and error description.
If a user decides to pass a dead letter reason in through the method arguments AND using the AmqpMessageConstants.DeadLetterReason dictionary key, the method ignores that key/value pair in the dictionary. This is true for the dead letter exception description as well.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - servicebus - tests

resolves #26659

/azp run net - servicebus - tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Messaging.ServiceBus


deepomf's figure segmentation dataset

If you're interested in doing further training, deeppomf has an image dataset scraped from yiff.party (includes NSFW images) where PSDs are used to generate pixel-perfect segmentations of figures: https://drive.google.com/file/d/1vK7R_FiD3_pC892sWTy_fOA_HF6E2SKx/view
Artists provide PSDs in layers, where 1 layer is the figure and the rest the background; so pixel-perfect-by-construction segmentation masks can be automatically created for training.

@gwern Awesome!
Do you have pretrained model on this dataset or scripts to disassemble this PSD files?

No, I've never used it. Just deepomf mentioned it as a way to improve on the existing segmentation without extremely laborious hand-annotation or using weak supervision from a classifier/tagger like DeepDanbooru, so I thought I'd mention that this dataset (and approach in general) exists.


Terminal / Configure Tasks does nothing

Issue Type: Bug
Starting in a clean directory, run VS Code. Terminal / Configure Tasks.
Select "Other" and create a tasks.json.
Close the tasks.json window.
Now do Terminal / Configure Tasks again.
Nothing happens. No list of tasks is presented, no prompt to create tasks.json again. (Update: I did on one occasion see the "select a task" box appear briefly, but it dieappeared before I could select it) The tasks.json file is there, with the single default "echo" task, which works as expected.
I can modify and add tasks by navigating to and editing the tasks.json file directly, but the menu item does nothing.
Disabling all installed extensions makes no difference.
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:20.174Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.73GB (17.89GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

vscode-quick-select
dba
0.2.8

code-runner
for
0.10.0

restructuredtext
lex
128.0.0

python
ms-
2020.6.90262

remote-wsl
ms-
0.44.4

powershell
ms-
2020.6.0

edit-with-shell
ryu
1.2.0

code-settings-sync
Sha
3.4.3

rewrap
stk
1.12.0

vscode-icons
vsc
10.1.1

Thanks for the quick fix!


Got exception while listening

happens randomly, not sure how to reproduce
i have a bot running 24/7, today it was down and this was last log, i know it has happened before and i just ignored it
2017-07-06 04:56:21,530 - client - ERROR - Got exception while listening Traceback (most recent call last):   File "/usr/local/lib/python2.7/dist-packages/fbchat/client.py", line 1430, in doOneListen     content = self._pullMessage(self.sticky, self.pool)   File "/usr/local/lib/python2.7/dist-packages/fbchat/client.py", line 1242, in _pullMessage     j = checkRequest(self._get(ReqUrl.STICKY, data))   File "/usr/local/lib/python2.7/dist-packages/fbchat/utils.py", line 157, in checkRequest     raise Exception('Error when sending request: Got {} response'.format(r.status_code)) Exception: Error when sending request: Got 502 response

Seems like something that's virtually impossible to fix, like #130. If anyone figures out why, I'd love to know, but other than that, I think the only thing we can do is just catch the error, and the do a re-login, or simply just re-login every, say, 6 hours.

Im working on this one right now (since I need 24/7 too haha)
I observe that facebook starts sending weird response that contains fb_dtsg after running like days.
I think this issue is same with this one and they have already fixed it.
https://github.com/Schmavery/facebook-chat-api/issues/202
Here is the code:
https://github.com/carpedm20/fbchat/pull/178
Pray that there's nothing wrong with it XD
I think I still need to test for few weeks. I will confirm it here then you can merge that pull request.
PS: It's funny that I also thumb-up'ed the comment in that issue. Somehow I completely forgot about it. -facepalm-

Thanks for you work, this'll become really handy :)

Note: I recently met an error IF nothing had been sent for 3 days then I sent a message.
Exception: Error #1357004 when sending request: Please try closing and re-opening your browser window.
It seems that updating fb_dtsg from message isn't enough in case that fbchatClient is afk'ing for long time.
Request facebook.com to get new fb_dtsg could help. Im quite busy right now, will test and fix this later.


unsuccessful at installing for ios 7.0

so looking through all the requests for swift demos it seems many people are running into this issue, but the author seems truculent in his indignation and insists that this is not a swift school.  seems as though this is an issue with this project, though.
like many others, i started a blank project and copied ALL the swift files and subfolders in the Charts/Classes folder into an iOS 7 project but importing Charts namespace continues to spit out the 'Cannot load the module 'charts' error.
what am i missing?

https://github.com/vishw3/IOSChart-IOS-7.0-Support

Please separate the two issues:

People who are asking how to write Swift code - this is not a Swift school...
People who are having trouble with compilations

We are all doing everything we can to help people get along with the library.
Please elaborate more on your trouble. A complete error log would be great.

See #133. We may have just solved your problem...

using the latest version..

new project
drag drop /Classes folder
import Charts namespace

Are the Swift files of Charts marked in the "Target Membership"?
On Thu, Jun 11, 2015 at 2:14 PM, swangy<EMAIL_ADDRESS>wrote:

using the latest version..

new project
drag drop /Classes folder
import Charts namespace

[image: screen shot 2015-06-11 at 7 11 11 am]
https://cloud.githubusercontent.com/assets/752891/8105676/3d00caac-1009-11e5-9a44-0391ff605eb0.png
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/144#issuecomment-111087759
.

Did not have that...!  for those looking for the solution:

Add target membership with Classes folder

you might want to amend your readme to reflect this, it's not clear at all for those who dont have xcode experience.


Allow Swift objects to mark themselves as ignoring refcounting

rdar://problem/47934724 _emptyArrayStorage and _swiftEmptyDictionarySingleton should be immortal.

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

FlattenListLoop
3883
4555
+17.3%
0.85x (?)

Array2D
6736
7824
+16.2%
0.86x

MapReduce
356
408
+14.6%
0.87x

MapReduceAnyCollection
357
409
+14.6%
0.87x

FlattenListFlatMap
6097
6934
+13.7%
0.88x (?)

RemoveWhereFilterInts
40
45
+12.5%
0.89x

DropLastSequenceLazy
515
569
+10.5%
0.91x

DropLastSequence
516
570
+10.5%
0.91x (?)

DropLastAnySequence
521
574
+10.2%
0.91x (?)

PrefixWhileSequence
306
337
+10.1%
0.91x

PrefixWhileAnySeqCRangeIter
322
353
+9.6%
0.91x (?)

PrefixWhileAnySeqCntRange
322
353
+9.6%
0.91x

MapReduceString
59
64
+8.5%
0.92x (?)

Hanoi
3120
3370
+8.0%
0.93x (?)

SuffixAnySequence
529
571
+7.9%
0.93x (?)

SuffixSequence
529
571
+7.9%
0.93x (?)

SuffixSequenceLazy
529
571
+7.9%
0.93x (?)

RangeAssignment
318
343
+7.9%
0.93x (?)

StringBuilderWithLongSubstring
1300
1400
+7.7%
0.93x (?)

StringToDataEmpty
650
700
+7.7%
0.93x

Improvement

DictionaryBridgeToObjC_Access
867
792
-8.7%
1.09x (?)

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

FlattenListLoop
3632
4303
+18.5%
0.84x (?)

Array2D
6208
7280
+17.3%
0.85x

MapReduce
363
415
+14.3%
0.87x (?)

MapReduceAnyCollection
391
442
+13.0%
0.88x

PrefixWhileSequence
308
340
+10.4%
0.91x

PrefixWhileAnySeqCRangeIter
308
340
+10.4%
0.91x

PrefixWhileAnySeqCntRange
308
340
+10.4%
0.91x

RemoveWhereFilterInts
41
45
+9.8%
0.91x (?)

Improvement

ObjectiveCBridgeStubFromNSDateRef
4250
3660
-13.9%
1.16x (?)

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

Dictionary3
551
678
+23.0%
0.81x

Breadcrumbs.MutatedUTF16ToIdx.ASCII
19
22
+15.8%
0.86x (?)

Dictionary4
866
953
+10.0%
0.91x (?)

Dictionary4Legacy
1101
1187
+7.8%
0.93x (?)

Improvement

Histogram
8450
7509
-11.1%
1.13x (?)

StringBuilderWithLongSubstring
2910
2660
-8.6%
1.09x (?)

Dictionary2
1230
1140
-7.3%
1.08x (?)

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

Not great, but not awful. Let's see what choosing a different bit buys us.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

SortStringsUnicode
3300
3565
+8.0%
0.93x (?)

ObjectiveCBridgeFromNSArrayAnyObjectForced
4800
5180
+7.9%
0.93x (?)

Improvement

Breadcrumbs.CopyUTF16CodeUnits.Mixed
61
55
-9.8%
1.11x (?)

DictionaryBridgeToObjC_Access
1016
930
-8.5%
1.09x (?)

FloatingPointPrinting_Float_description_small
5724
5292
-7.5%
1.08x (?)

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

SortStringsUnicode
3295
3550
+7.7%
0.93x (?)

Improvement

FloatingPointPrinting_Float_description_small
5724
5292
-7.5%
1.08x (?)

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayOfGenericPOD2
1065
1179
+10.7%
0.90x (?)

Dictionary4
965
1066
+10.5%
0.91x (?)

ArrayOfPOD
777
855
+10.0%
0.91x (?)

Dictionary4Legacy
1228
1324
+7.8%
0.93x (?)

Improvement

Histogram
9398
8510
-9.4%
1.10x (?)

StrComplexWalk
7370
6700
-9.1%
1.10x

Dictionary2
1375
1270
-7.6%
1.08x (?)

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Much better. I think we're still not actually making immortal objects in most places, but this shows we're not regressing performance. Working on fixing making them.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

I've verified that this now "works" locally (for empty arrays only) but there's two things that could further muddle results: I had to move a little code into the fast side of retain/release, and haven't verified that that didn't cause a frame to be emitted into the fast path, and I added a small amount of overhead to the accessor for the empty array singleton.
We'll see how it pans out.

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

BinaryFloatingPointPropertiesBinade
25
31
+24.0%
0.81x

RandomDoubleLCG
880
1056
+20.0%
0.83x (?)

ProtocolDispatch2
357
414
+16.0%
0.86x

FatCompactMap
1210
1400
+15.7%
0.86x

ChainedFilterMap
1089
1260
+15.7%
0.86x

DataCountSmall
22
25
+13.6%
0.88x (?)

DataCountMedium
28
31
+10.7%
0.90x

Improvement

DataCreateEmptyArray
4200
3150
-25.0%
1.33x

ReversedArray2
200
171
-14.5%
1.17x

DictionaryBridgeToObjC_Access
999
884
-11.5%
1.13x (?)

EqualSubstringSubstring
44
39
-11.4%
1.13x

LessSubstringSubstring
44
39
-11.4%
1.13x (?)

EqualStringSubstring
44
39
-11.4%
1.13x (?)

DataSubscriptSmall
31
28
-9.7%
1.11x

SortStringsUnicode
3610
3270
-9.4%
1.10x

EqualSubstringString
43
39
-9.3%
1.10x

EqualSubstringSubstringGenericEquatable
44
40
-9.1%
1.10x (?)

DataSetCountSmall
142
131
-7.7%
1.08x (?)

ObjectiveCBridgeStubNSDateRefAccess
400
371
-7.2%
1.08x (?)

DropLastCountableRange
11
12
+9.1%
0.92x

SuffixCountableRangeLazy
11
12
+9.1%
0.92x

Array2D
6912
7520
+8.8%
0.92x (?)

ChainedFilterMap
8406
9135
+8.7%
0.92x (?)

ObjectiveCBridgeStubNSDateRefAccess
343
371
+8.2%
0.92x (?)

Improvement

MapReduceLazyCollectionShort
85
41
-51.8%
2.07x

DataCreateEmptyArray
4250
3250
-23.5%
1.31x

StrComplexWalk
3420
2680
-21.6%
1.28x

DataSubscriptSmall
31
25
-19.4%
1.24x

ObjectiveCBridgeStubFromNSDate
7000
5810
-17.0%
1.20x (?)

ProtocolDispatch2
414
357
-13.8%
1.16x

DataCountSmall
28
25
-10.7%
1.12x

DataCopyBytesSmall
131
117
-10.7%
1.12x (?)

DataSetCountSmall
145
131
-9.7%
1.11x

SortStringsUnicode
3600
3265
-9.3%
1.10x

EqualStringSubstring
43
39
-9.3%
1.10x (?)

FatCompactMap
10150
9240
-9.0%
1.10x

DataCountMedium
34
31
-8.8%
1.10x (?)

ProtocolDispatch
342
314
-8.2%
1.09x

Data.hash.Empty
74
68
-8.1%
1.09x

StringComparison_latin1
780
718
-7.9%
1.09x

ReversedDictionary2
342
315
-7.9%
1.09x

DataCreateSmall
3140
2910
-7.3%
1.08x

EqualSubstringSubstring
42
39
-7.1%
1.08x (?)

EqualSubstringString
42
39
-7.1%
1.08x (?)

LessSubstringSubstringGenericComparable
42
39
-7.1%
1.08x (?)

EqualSubstringSubstringGenericEquatable
43
40
-7.0%
1.07x (?)

CharIteration_tweet_unicodeScalars_Backwards
724280
788160
+8.8%
0.92x (?)

ArrayAppendReserved
4140
4490
+8.5%
0.92x (?)

CharIteration_japanese_unicodeScalars_Backwards
443920
481080
+8.4%
0.92x (?)

DataCreateEmpty
1080
1170
+8.3%
0.92x (?)

ArrayAppend
4310
4650
+7.9%
0.93x (?)

ObjectiveCBridgeStubDateMutation
742
800
+7.8%
0.93x

CharIteration_korean_unicodeScalars_Backwards
360680
388480
+7.7%
0.93x (?)

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
63760
68560
+7.5%
0.93x (?)

Improvement

ArrayOfPOD
852
777
-8.8%
1.10x (?)

StackPromo
69600
64600
-7.2%
1.08x (?)

DataAppendArray
5600
5200
-7.1%
1.08x (?)

Added

RetainSingletonArray
21
22
21
—

Code size: -swiftlibs

TEST
OLD
NEW
DELTA
RATIO

Regression

libswiftStdlibUnittest.dylib
360448
364544
+1.1%
0.99x

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Nice. Considering the caveats I mentioned these are decently good results! I'll just need to think a bit about how to address them, apply this to Dictionary and Set, and we should end up in good shape.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

swift-ci noticed me!

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
16600
58100
+250.0%
0.29x

Improvement

PrefixAnySequence
2199
1405
-36.1%
1.57x

Set.subtracting.Empty.Int
59
40
-32.2%
1.47x

DataCreateEmptyArray
4200
2850
-32.1%
1.47x

Set.subtracting.Int.Empty
80
55
-31.2%
1.45x

DropFirstAnySequence
2667
1853
-30.5%
1.44x

DropFirstAnySequenceLazy
2723
1920
-29.5%
1.42x

DropWhileAnySequence
2685
1902
-29.2%
1.41x

DataCreateSmallArray
5050
3700
-26.7%
1.36x

Set.isSubset.Empty.Int
216
160
-25.9%
1.35x

ObjectAllocation
131
98
-25.2%
1.34x

Set.isDisjoint.Box.Empty
231
175
-24.2%
1.32x

Set.subtracting.Empty.Box
21
16
-23.8%
1.31x

Set.isSubset.Int.Empty
111
88
-20.7%
1.26x

Set.subtracting.Box.Empty
40
32
-20.0%
1.25x

Set.isDisjoint.Int.Empty
120
97
-19.2%
1.24x

StringEnumRawValueInitialization
900
800
-11.1%
1.12x

Added

RetainSingletonArray
0
0
0
—

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3143
3476
+10.6%
0.90x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
17000
58600
+244.7%
0.29x

DictionaryBridgeToObjC_Access
946
1093
+15.5%
0.87x (?)

Improvement

ObjectAllocation
157
74
-52.9%
2.12x

DataCreateSmallArray
5900
3950
-33.1%
1.49x

DataCreateEmptyArray
4150
2850
-31.3%
1.46x

Set.subtracting.Int.Empty
82
57
-30.5%
1.44x

Set.isDisjoint.Int.Empty
227
161
-29.1%
1.41x

ArrayLiteral
214
157
-26.6%
1.36x

Set.subtracting.Empty.Int
58
43
-25.9%
1.35x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.isSubset.Empty.Int
221
172
-22.2%
1.28x

NSError
238
186
-21.8%
1.28x

Set.subtracting.Empty.Box
20
16
-20.0%
1.25x

Set.isDisjoint.Box.Empty
235
191
-18.7%
1.23x

Set.isSubset.Int.Empty
115
98
-14.8%
1.17x

COWArrayGuaranteedParameterOverhead
4350
3750
-13.8%
1.16x (?)

StringEnumRawValueInitialization
900
820
-8.9%
1.10x

DropLastAnyCollection
59
55
-6.8%
1.07x (?)

SuffixAnyCollection
59
55
-6.8%
1.07x (?)

Added

RetainSingletonArray
20
21
20
—

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
2984
3301
+10.6%
0.90x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeStubFromNSString
935
1021
+9.2%
0.92x (?)

Improvement

Breadcrumbs.MutatedUTF16ToIdx.ASCII
26
22
-15.4%
1.18x (?)

Dictionary3
706
619
-12.3%
1.14x (?)

DictionaryBridgeToObjC_Access
1258
1125
-10.6%
1.12x (?)

WordCountUniqueASCII
12870
12020
-6.6%
1.07x (?)

Added

RetainSingletonArray
21
22
21
—

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

...huh. Anyone have ideas on why making stack allocations immune to refcounting would slow them down like that?
Oh maybe it’s because their unowned refcount is zero now? I can restore that to 2.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Build failed before running benchmark.

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
16800
58300
+247.0%
0.29x

FlattenListLoop
4330
4710
+8.8%
0.92x (?)

SortStringsUnicode
3300
3565
+8.0%
0.93x (?)

Array2D
7520
8112
+7.9%
0.93x (?)

Improvement

PrefixAnySequence
2199
1420
-35.4%
1.55x

DataCreateEmptyArray
4300
2850
-33.7%
1.51x

Set.subtracting.Empty.Int
58
40
-31.0%
1.45x

Set.subtracting.Int.Empty
79
55
-30.4%
1.44x

DropFirstAnySequence
2667
1877
-29.6%
1.42x

DropFirstAnySequenceLazy
2723
1937
-28.9%
1.41x

DropWhileAnySequence
2682
1919
-28.4%
1.40x

Set.isSubset.Empty.Int
213
158
-25.8%
1.35x

DataCreateSmallArray
5050
3750
-25.7%
1.35x

ObjectAllocation
131
98
-25.2%
1.34x

Set.subtracting.Empty.Box
21
16
-23.8%
1.31x

Set.isDisjoint.Box.Empty
229
177
-22.7%
1.29x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.isSubset.Int.Empty
111
88
-20.7%
1.26x

Set.isDisjoint.Int.Empty
120
97
-19.2%
1.24x

StringBuilderSmallReservingCapacity
374
348
-7.0%
1.07x (?)

StringAdder
457
427
-6.6%
1.07x (?)

Added

RetainSingletonArray
0
0
0
—

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3143
3476
+10.6%
0.90x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
17200
58800
+241.9%
0.29x

SetSubtractingInt25
101
112
+10.9%
0.90x (?)

FlattenListLoop
4055
4433
+9.3%
0.91x (?)

FloatingPointPrinting_Float_description_uniform
5500
6000
+9.1%
0.92x (?)

Array2D
6912
7520
+8.8%
0.92x (?)

SortStringsUnicode
3295
3560
+8.0%
0.93x

Improvement

ObjectAllocation
158
72
-54.4%
2.19x

DataCreateSmallArray
5900
4000
-32.2%
1.47x

DataCreateEmptyArray
4150
2900
-30.1%
1.43x

Set.isDisjoint.Int.Empty
232
165
-28.9%
1.41x

Set.subtracting.Empty.Int
59
42
-28.8%
1.40x

Set.subtracting.Int.Empty
80
58
-27.5%
1.38x

ArrayLiteral
214
160
-25.2%
1.34x

Set.isSubset.Empty.Int
227
171
-24.7%
1.33x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

NSError
239
186
-22.2%
1.28x (?)

Set.isDisjoint.Box.Empty
242
192
-20.7%
1.26x

Set.subtracting.Empty.Box
20
16
-20.0%
1.25x

Set.isSubset.Int.Empty
117
98
-16.2%
1.19x

COWArrayGuaranteedParameterOverhead
4350
3700
-14.9%
1.18x

StringBuilder
360
327
-9.2%
1.10x (?)

StringBuilderSmallReservingCapacity
371
341
-8.1%
1.09x (?)

DropLastAnyCollection
59
55
-6.8%
1.07x (?)

SuffixAnyCollection
59
55
-6.8%
1.07x (?)

StringEnumRawValueInitialization
900
840
-6.7%
1.07x (?)

Added

RetainSingletonArray
20
21
20
—

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
2984
3301
+10.6%
0.90x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

CharIteration_ascii_unicodeScalars_Backwards
363840
440560
+21.1%
0.83x

CharIteration_punctuated_unicodeScalars_Backwards
80680
97040
+20.3%
0.83x (?)

CharIteration_korean_unicodeScalars_Backwards
360120
433000
+20.2%
0.83x (?)

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
63600
76320
+20.0%
0.83x (?)

CharIteration_chinese_unicodeScalars_Backwards
279520
335320
+20.0%
0.83x (?)

CharIteration_tweet_unicodeScalars_Backwards
733320
878200
+19.8%
0.84x (?)

CharIteration_russian_unicodeScalars_Backwards
313520
370000
+18.0%
0.85x (?)

CharIteration_japanese_unicodeScalars_Backwards
453520
533400
+17.6%
0.85x (?)

CharIteration_utf16_unicodeScalars_Backwards
299560
344800
+15.1%
0.87x (?)

CharIndexing_ascii_unicodeScalars_Backwards
609880
677120
+11.0%
0.90x (?)

CharIndexing_tweet_unicodeScalars_Backwards
1216320
1344000
+10.5%
0.91x (?)

CharIndexing_japanese_unicodeScalars_Backwards
749400
823360
+9.9%
0.91x (?)

ArrayOfPOD
776
852
+9.8%
0.91x (?)

CharIndexing_punctuatedJapanese_unicodeScalars_Backwards
107560
117920
+9.6%
0.91x (?)

SortStringsUnicode
4840
5240
+8.3%
0.92x (?)

Improvement

Dictionary3
709
615
-13.3%
1.15x

StrComplexWalk
7340
6710
-8.6%
1.09x (?)

Dictionary4
1064
973
-8.6%
1.09x (?)

DataReplaceLarge
23600
21600
-8.5%
1.09x (?)

Added

RetainSingletonArray
21
22
21
—

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

??? frown

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
16800
58300
+247.0%
0.29x

ArrayAppendLatin1
2890
3264
+12.9%
0.89x (?)

FlattenListLoop
4331
4709
+8.7%
0.92x (?)

SortStringsUnicode
3300
3570
+8.2%
0.92x

Array2D
7520
8112
+7.9%
0.93x (?)

Improvement

PrefixAnySequence
2199
1420
-35.4%
1.55x

ArrayLiteral2
205
137
-33.2%
1.50x

DataCreateEmptyArray
4250
2850
-32.9%
1.49x

Set.subtracting.Empty.Int
59
40
-32.2%
1.47x

Set.subtracting.Int.Empty
79
55
-30.4%
1.44x

DropFirstAnySequence
2667
1877
-29.6%
1.42x

DropFirstAnySequenceLazy
2724
1937
-28.9%
1.41x

DropWhileAnySequence
2682
1920
-28.4%
1.40x

Set.isSubset.Empty.Int
214
158
-26.2%
1.35x

DataCreateSmallArray
5000
3750
-25.0%
1.33x

ObjectAllocation
131
99
-24.4%
1.32x

Set.subtracting.Empty.Box
21
16
-23.8%
1.31x

Set.isDisjoint.Box.Empty
230
177
-23.0%
1.30x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.isSubset.Int.Empty
111
88
-20.7%
1.26x

Set.isDisjoint.Int.Empty
120
97
-19.2%
1.24x

COWArrayGuaranteedParameterOverhead
3900
3350
-14.1%
1.16x

DictionaryBridgeToObjC_Access
1048
954
-9.0%
1.10x (?)

StringEnumRawValueInitialization
900
820
-8.9%
1.10x

StringBuilderSmallReservingCapacity
374
348
-7.0%
1.07x (?)

StringAdder
457
427
-6.6%
1.07x (?)

Added

RetainSingletonArray
0
0
0
—

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3311
3644
+10.1%
0.91x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

StackPromo
17200
58700
+241.3%
0.29x

FlattenListLoop
4054
4433
+9.3%
0.91x (?)

SetSubtractingInt25
102
111
+8.8%
0.92x (?)

Array2D
6912
7520
+8.8%
0.92x (?)

SortStringsUnicode
3295
3555
+7.9%
0.93x (?)

Improvement

ObjectAllocation
158
72
-54.4%
2.19x

DataCreateSmallArray
5850
4000
-31.6%
1.46x

DataCreateEmptyArray
4150
2900
-30.1%
1.43x

Set.isDisjoint.Int.Empty
232
165
-28.9%
1.41x

Set.subtracting.Int.Empty
81
58
-28.4%
1.40x

Set.subtracting.Empty.Int
58
42
-27.6%
1.38x

Set.isSubset.Empty.Int
227
171
-24.7%
1.33x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

NSError
239
186
-22.2%
1.28x (?)

Set.isDisjoint.Box.Empty
242
192
-20.7%
1.26x

Set.subtracting.Empty.Box
20
16
-20.0%
1.25x

Set.isSubset.Int.Empty
118
98
-16.9%
1.20x

COWArrayGuaranteedParameterOverhead
4400
3750
-14.8%
1.17x

ArrayLiteral2
216
191
-11.6%
1.13x

StringBuilder
360
327
-9.2%
1.10x

StringBuilderSmallReservingCapacity
371
341
-8.1%
1.09x (?)

DropLastAnyCollection
59
55
-6.8%
1.07x (?)

SuffixAnyCollection
59
55
-6.8%
1.07x (?)

StringEnumRawValueInitialization
900
840
-6.7%
1.07x (?)

Added

RetainSingletonArray
12
13
12
—

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3109
3458
+11.2%
0.90x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

CharIteration_ascii_unicodeScalars_Backwards
362840
443320
+22.2%
0.82x (?)

CharIteration_punctuated_unicodeScalars_Backwards
80200
97120
+21.1%
0.83x (?)

CharIteration_korean_unicodeScalars_Backwards
359280
432160
+20.3%
0.83x (?)

CharIteration_russian_unicodeScalars_Backwards
308200
370120
+20.1%
0.83x (?)

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
63360
76040
+20.0%
0.83x (?)

CharIteration_chinese_unicodeScalars_Backwards
279360
334920
+19.9%
0.83x (?)

CharIteration_tweet_unicodeScalars_Backwards
730280
870400
+19.2%
0.84x (?)

CharIteration_japanese_unicodeScalars_Backwards
449520
533360
+18.7%
0.84x (?)

CharIteration_utf16_unicodeScalars_Backwards
297880
345680
+16.0%
0.86x (?)

CStringLongAscii
249
281
+12.9%
0.89x (?)

CharIndexing_russian_unicodeScalars_Backwards
513600
565400
+10.1%
0.91x (?)

ArrayOfPOD
776
853
+9.9%
0.91x (?)

CharIndexing_tweet_unicodeScalars_Backwards
1227440
1340640
+9.2%
0.92x (?)

SortStringsUnicode
4840
5240
+8.3%
0.92x

Improvement

Dictionary3
706
614
-13.0%
1.15x

StrComplexWalk
7340
6720
-8.4%
1.09x (?)

Breadcrumbs.MutatedUTF16ToIdx.ASCII
24
22
-8.3%
1.09x (?)

Dictionary4
1061
973
-8.3%
1.09x (?)

Added

RetainSingletonArray
17
18
17
—

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

FlattenListLoop
4331
4710
+8.8%
0.92x (?)

SortStringsUnicode
3300
3570
+8.2%
0.92x

Array2D
7520
8112
+7.9%
0.93x (?)

Improvement

DataCreateEmptyArray
4300
2850
-33.7%
1.51x

Set.subtracting.Empty.Int
59
40
-32.2%
1.47x

ArrayLiteral2
202
137
-32.2%
1.47x

Set.subtracting.Int.Empty
78
55
-29.5%
1.42x

Set.isSubset.Empty.Int
213
158
-25.8%
1.35x

DataCreateSmallArray
5000
3750
-25.0%
1.33x

Set.subtracting.Empty.Box
21
16
-23.8%
1.31x

Set.isDisjoint.Box.Empty
229
177
-22.7%
1.29x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.isSubset.Int.Empty
111
88
-20.7%
1.26x

Set.isDisjoint.Int.Empty
120
97
-19.2%
1.24x

COWArrayGuaranteedParameterOverhead
3900
3350
-14.1%
1.16x (?)

ObjectiveCBridgeFromNSStringForced
2600
2360
-9.2%
1.10x (?)

StringEnumRawValueInitialization
900
820
-8.9%
1.10x

DictionaryBridgeToObjC_Access
1030
957
-7.1%
1.08x (?)

StringAdder
457
427
-6.6%
1.07x (?)

Added

RetainSingletonArray
0
0
0
—

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3311
3644
+10.1%
0.91x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

SetSubtractingInt25
101
112
+10.9%
0.90x (?)

FlattenListLoop
4054
4433
+9.3%
0.91x (?)

Array2D
6912
7520
+8.8%
0.92x

SortStringsUnicode
3295
3560
+8.0%
0.93x (?)

Improvement

DataCreateSmallArray
5850
4000
-31.6%
1.46x

DataCreateEmptyArray
4150
2900
-30.1%
1.43x

Set.isDisjoint.Int.Empty
232
165
-28.9%
1.41x

Set.subtracting.Empty.Int
58
42
-27.6%
1.38x

Set.subtracting.Int.Empty
80
58
-27.5%
1.38x

Set.subtracting.Box.Empty
41
31
-24.4%
1.32x

Set.isSubset.Empty.Int
221
171
-22.6%
1.29x

Set.isDisjoint.Box.Empty
242
192
-20.7%
1.26x

Set.subtracting.Empty.Box
20
16
-20.0%
1.25x

Set.isSubset.Int.Empty
115
98
-14.8%
1.17x

COWArrayGuaranteedParameterOverhead
4350
3800
-12.6%
1.14x (?)

ArrayLiteral2
217
191
-12.0%
1.14x

StringBuilder
360
327
-9.2%
1.10x

StringBuilderSmallReservingCapacity
371
341
-8.1%
1.09x (?)

StringEnumRawValueInitialization
900
840
-6.7%
1.07x (?)

Added

RetainSingletonArray
12
13
12
—

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3109
3458
+11.2%
0.90x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Regression

CharIteration_ascii_unicodeScalars_Backwards
364040
441040
+21.2%
0.83x

CharIteration_punctuated_unicodeScalars_Backwards
80600
97440
+20.9%
0.83x (?)

CharIteration_chinese_unicodeScalars_Backwards
279600
337240
+20.6%
0.83x (?)

CharIteration_punctuatedJapanese_unicodeScalars_Backwards
63640
76560
+20.3%
0.83x (?)

CharIteration_korean_unicodeScalars_Backwards
361000
434240
+20.3%
0.83x (?)

CharIteration_russian_unicodeScalars_Backwards
308000
368720
+19.7%
0.84x (?)

CharIteration_tweet_unicodeScalars_Backwards
732240
872120
+19.1%
0.84x (?)

CharIteration_japanese_unicodeScalars_Backwards
449880
533520
+18.6%
0.84x (?)

CharIteration_utf16_unicodeScalars_Backwards
300200
345000
+14.9%
0.87x (?)

CharIndexing_ascii_unicodeScalars_Backwards
618880
680280
+9.9%
0.91x (?)

CharIndexing_punctuated_unicodeScalars_Backwards
135640
149000
+9.8%
0.91x (?)

ArrayOfPOD
776
851
+9.7%
0.91x (?)

CharIndexing_russian_unicodeScalars_Backwards
512520
561600
+9.6%
0.91x (?)

CharIndexing_tweet_unicodeScalars_Backwards
1230800
1346640
+9.4%
0.91x (?)

CharIndexing_utf16_unicodeScalars_Backwards
545000
593440
+8.9%
0.92x (?)

CharIndexing_chinese_unicodeScalars_Backwards
470400
511760
+8.8%
0.92x (?)

CharIndexing_japanese_unicodeScalars_Backwards
746520
810840
+8.6%
0.92x (?)

CharIndexing_korean_unicodeScalars
550960
598360
+8.6%
0.92x (?)

SortStringsUnicode
4845
5235
+8.0%
0.93x

CharIndexing_punctuatedJapanese_unicodeScalars_Backwards
108000
116520
+7.9%
0.93x (?)

Improvement

DictionaryBridgeToObjC_Access
1248
1079
-13.5%
1.16x (?)

Dictionary3
708
615
-13.1%
1.15x

StrComplexWalk
7350
6710
-8.7%
1.10x

Dictionary4
1058
971
-8.2%
1.09x (?)

Dictionary4Legacy
1315
1228
-6.6%
1.07x (?)

Added

RetainSingletonArray
17
18
18
—

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

Better. The giant regression was because making stack objects immortal breaks CoW for them. I'll try to remember to file a followup bug to think about whether we can do anything there.
Interesting possibility: stack promoted objects already had escape analysis done, so should be able to use nonatomic refcounting…
I believe the remaining small regressions are most likely a tiny bit of overhead added to the regular refcounting path. I can look into that later, but these results are probably good enough to accept.

Comparing disassembly of swift_retain, what changed is before we had
fast path
jump to slow path
return
slow path
return
and now we have
fast path
jump over slow path
slow path
return
so assuming it's that and not unowned retain, or something in release, then it's presumably the extra icache pressure

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 48e04af9ba71578b492e1c4b75e025f57bc5450f

Build failed
Swift Test Linux Platform
Git Sha - 48e04af9ba71578b492e1c4b75e025f57bc5450f

Exercise: start with the old code, replace swift_retain() etc with hand-written assembly that reverses the direction of the jumps like you noted above, then run the performance tests again. That should tell you whether or not that code rearrangement has a measureable effect.

My tentative plan was to try to use __builtin_expect() to achieve the same thing without doing it by hand… we'll see if that works another day though. It's late, and my brain is very very fuzzy.

I have never personally seen __builtin_expect have any effect on the generated code, but it's easy to try and maybe the compiler folks have actually wired it up to something now.

Interesting possibility: stack promoted objects already had escape analysis done, so should be able to use nonatomic refcounting…

As a curious observer: if an object has been stack promoted, doesn't that mean that its lifetime has already been determined and it shouldn't need any refcounting whatsoever? If that's not the case, why is that?

I was assuming it was due to calling non-inlined stuff that didn’t know it was stack promoted, but now that I think about that wouldn’t that also break the escape analysis? Hmmm
Worth investigating more

Sadly Greg is correct about __builtin_expect :(

(deleted previous comment, misread the assembly)
__builtin_expect seems to have done what I hoped! I'm now seeing
lock
cmpxchgq %rsi, (%rdi)
jne    0x2bb2e0                  ; <+32>
movq   %rcx, %rax
retq

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

@swift-ci please smoke benchmark

Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

FlattenListLoop
4331
4709
+8.7%
0.92x (?)

Array2D
7520
8112
+7.9%
0.93x (?)

Improvement

Set.subtracting.Empty.Int
59
39
-33.9%
1.51x

DataCreateEmptyArray
4300
2850
-33.7%
1.51x

ArrayLiteral2
205
137
-33.2%
1.50x

Set.subtracting.Int.Empty
79
55
-30.4%
1.44x

Set.isSubset.Empty.Int
214
158
-26.2%
1.35x

DataCreateSmallArray
5000
3750
-25.0%
1.33x

Set.subtracting.Empty.Box
21
16
-23.8%
1.31x

Set.isDisjoint.Box.Empty
230
178
-22.6%
1.29x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.isSubset.Int.Empty
111
90
-18.9%
1.23x

Set.isDisjoint.Int.Empty
120
98
-18.3%
1.22x

COWArrayGuaranteedParameterOverhead
3900
3350
-14.1%
1.16x

Added

RetainSingletonArray
0
0
0
—

Code size: -O

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3311
3644
+10.1%
0.91x

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

FlattenListLoop
4054
4433
+9.3%
0.91x (?)

Array2D
6912
7520
+8.8%
0.92x

InsertCharacterEndIndex
160
173
+8.1%
0.92x (?)

Improvement

DataCreateSmallArray
5850
4000
-31.6%
1.46x

DataCreateEmptyArray
4150
2900
-30.1%
1.43x

Set.subtracting.Int.Empty
80
57
-28.7%
1.40x

Set.isDisjoint.Int.Empty
232
167
-28.0%
1.39x

Set.subtracting.Empty.Int
58
42
-27.6%
1.38x

Set.isSubset.Empty.Int
221
170
-23.1%
1.30x

Set.subtracting.Box.Empty
40
31
-22.5%
1.29x

Set.subtracting.Empty.Box
20
16
-20.0%
1.25x

Set.isDisjoint.Box.Empty
242
194
-19.8%
1.25x

COWArrayGuaranteedParameterOverhead
4350
3750
-13.8%
1.16x

Set.isSubset.Int.Empty
115
100
-13.0%
1.15x

ArrayLiteral2
216
188
-13.0%
1.15x (?)

StringEnumRawValueInitialization
900
820
-8.9%
1.10x (?)

Added

RetainSingletonArray
12
13
12
—

Code size: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ArrayLiteral.o
3109
3458
+11.2%
0.90x

Performance: -Onone

TEST
OLD
NEW
DELTA
RATIO

Improvement

DictionaryBridgeToObjC_Access
1286
1082
-15.9%
1.19x (?)

Dictionary3
707
618
-12.6%
1.14x (?)

ObjectiveCBridgeFromNSDictionaryAnyObjectForced
9550
8500
-11.0%
1.12x (?)

Breadcrumbs.MutatedUTF16ToIdx.ASCII
24
22
-8.3%
1.09x (?)

Dictionary4
1056
969
-8.2%
1.09x (?)

Added

RetainSingletonArray
17
18
17
—

✅
Benchmark Check Report

⛔⏱
RetainSingletonArray execution took 0 μs.  Ensure the workload of RetainSingletonArray has a properly measurable size (runtime > 20 μs) and is not eliminated by the compiler (use blackHole function if necessary).

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

It worked! 😃

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 64773ffe2717fee7e8b88e4492641813a9ad7796

Build failed
Swift Test Linux Platform
Git Sha - 64773ffe2717fee7e8b88e4492641813a9ad7796

@swift-ci please test

Long tests passed :)

Build failed
Swift Test OS X Platform
Git Sha - c2cf7d84233a139dc49c3659530dd1553dbac944

Build failed
Swift Test Linux Platform
Git Sha - c2cf7d84233a139dc49c3659530dd1553dbac944

Hm. That OS log test isn't failing for me locally :/

@swift-ci please test and merge

@swift-ci please test and merge

CI hardware blew up

@swift-ci please test and merge

For some reason my editor keeps autocorrecting to a capital initial I in isImmortal >.<

@swift-ci please test and merge

@swift-ci please test and merge


[usage example] ltc droplet set of commands.

Hello Lattice Team,
We are trying use lattice for a POC.  At the moment we are not interested in the longevity of these commands, so no worries we wont come back bugging you to keep them if you have decided to remove them later. :-)
I went through the story (upload-bits) and epic (droplet set of commands) of these new commands.   What i would really love to see is an overall usage examples of these commands.

Creating a droplet (go)
uploading the my app bits
Running my app.

Even if you have any screen run (putty output) that would demonstrate the order and usage of these commands coherently that would be great for me to start with.
Thanks in Advance,
Dhilip
PS: if you have such screen dump already I will be a perfectly happy man to see them in this issue itself rather than waiting for that to be updated in the Readme.md :D

Hi @dhilipkumars,
Sure, no problem! I'll post the transcript of one of my acceptance runs later today.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

Hi @dhilipkumars,
Your team (or anyone) should be able to do exactly this
$ CONDENSER_ON=1 vagrant up --provider=virtualbox

$ ltc target <IP_ADDRESS>.xip.io

$ ltc target-blob <IP_ADDRESS>:8980
[You'll need to input the S3 credentials printed in the `vagrant up` output]

$ cd ~/workspace/
$ git clone 'https://github.com/pivotal-cf-experimental/lattice-app.git'

$ ltc build-droplet LAPP go
Submitted build of LAPP
07/17 08:32:19.42 [BUILD|0] Successfully created container
07/17 08:32:19.94 [BUILD|0] Downloaded s3://condenser-bucket/LAPP/bits.tgz to /tmp/bits.tgz.
07/17 08:32:19.94 [BUILD|0] Exit status 0
07/17 08:32:19.96 [BUILD|0] Exit status 0
07/17 08:32:19.98 [BUILD|0] Exit status 0
07/17 08:32:35.75 [BUILD|0] -------> Buildpack version 1.4.0
07/17 08:32:43.34 [BUILD|0] -----> Installing go1.4.2... done
07/17 08:32:43.36 [BUILD|0] -----> Running: godep go install -tags cloudfoundry ./...
07/17 08:32:53.83 [BUILD|0] Exit status 0
07/17 08:32:53.96 [BUILD|0] Uploaded /tmp/droplet to s3://condenser-bucket/LAPP/droplet.tgz.
07/17 08:32:53.96 [BUILD|0] Exit status 0
07/17 08:32:54.03 [BUILD|0] Uploaded /tmp/result.json to s3://condenser-bucket/LAPP/result.json.
07/17 08:32:54.03 [BUILD|0] Exit status 0
Build completed

$ ltc launch-droplet LAPP LAPP
No port specified. Defaulting to 8080.
Creating App: LAPP
.07/17 08:36:02.33 [APP|0] Creating container
07/17 08:36:02.65 [APP|0] Successfully created container
07/17 08:36:03.29 [APP|0] Downloaded s3://condenser-bucket/LAPP/droplet.tgz to /tmp/droplet.tgz.
07/17 08:36:03.30 [APP|0] Exit status 0
.07/17 08:36:03.38 [APP|0] Exit status 0
07/17 08:36:03.41 [APP|0] {"timestamp":"1437147363.409129143","source":"lattice-app","message":"lattice-app.lattice-app.starting","log_level":1,"data":{"port":"8080"}}
07/17 08:36:03.41 [APP|0] {"timestamp":"1437147363.410006762","source":"lattice-app","message":"lattice-app.lattice-app.up","log_level":1,"data":{"port":"8080"}}
07/17 08:36:03.90 [HEALTH|0] healthcheck passed
07/17 08:36:03.90 [HEALTH|0] Exit status 0

LAPP is now running.
App is reachable at:
http://LAPP.<IP_ADDRESS>.xip.io

Easy, right? That's the first 80% of the Condenser project. The second 80% will be getting it to work on Terraform-deployed clusters, and polishing the hand-offs between Lattice and the Buildpacks such that each of the BPs works as expected, and as you suggested, providing some nice documentation.
I'm going to close this issue for now (example provided), but please feel free to re-open if you have any further questions!
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

Thank you very much for the quick response.  I will agree with you on how easy it is after I try them tomorrow.  :-)

@menicosia   Thanks again was not able to get lattice working in a new environment primarily because of proxy problems which prevents from downloading any sort of artifact from within the garden-linux Container. :-(  Which is why i thought i will try these new commands to run an app locally.  That did not work aswell because it needs buildpacks to be downloaded. :-(
buildpacks are downloaded by the container?
one feedback if we are using VAGRANT_HTTP_PROXY and VAGRANT_HTTPS_PROXY variables to vagrant up lattice then we must also use VAGRANT_NO_PROXY otherwise condencer-bucket.
below curl would fail.
curl -s -H 'Content-Type: application/json' -XPOST http://localhost:8980/riak-cs/user --data<EMAIL_ADDRESS>"name":"admin_user"}'

Hi @dhilipkumars,
Yes, the initial versions of Condenser assume that the customer has Internet access, though we didn't consider how using a proxy may affect this. Offline, or 'cached' buildpacks are on the backlog, see story 97208298.
I've created story 99488174 to account for this. We'll look into it, unless you have a fix in mind, and would like to submit a PR?
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

Hi @dhilipkumars,
I realized you've actually pointed out two bugs; the first being the workaround you mentioned in order to talk to your own blobstore, the second is that buildpacks may not support HTTP proxy functionality.
I've created a story for the first: 99515656 and the additional story I've already mentioned above.
Thank you much! Feedback like this is very helpful.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

@menicosia Thanks for considering my feedback.  I somehow strongly feel that the proxy related problem needs to be fixed from garden-linux side.  I did raise an [issue] ( https://github.com/cloudfoundry-incubator/garden-linux/issues/24) long back but i was unable to prove it :-(.
May be these problems are very specific to bosh-lite/vagrant installations like ours.  We have not tried with a real clustered setup yet.
Thanks again for the help.

@dhilipkumars,
We've been going around and around on this proxy stuff. Sometimes things aren't as simple as they seem, take for example, this story: Condenser should download dependencies through an HTTP proxy when configured.
This seems relatively straightforward, but in fact it is not. The problem is the ltc command line instructs Diego on all aspects of the build process's environment - the HTTP_PROXY settings used to deploy the cluster do not apply.
Thus, solving the proxy issue programmatically is a problem - the cluster needs to pass its state back to ltc so that ltc can know to send it back to the cluster... ugh.
An alternative, though, is not necessarily to set VAGRANT_NO_PROXY, but rather to supply the build environment with the PROXY information:

$ ltc build-droplet LAPP BUILDPACK --env http_proxy=http://<IP_ADDRESS>:3128

What do you think? If this is acceptable, would you mind testing it in your environment? If it works well for you, I'll update the documentation to reflect this suggestion.
--

@menicosia Apologies for the delay in responding.  I did spend some time last week to test this but was getting the below error
ltc build-droplet LAPP 'https://github.com/cloudfoundry/go-buildpack.git' --env https_proxy=https://<IP_ADDRESS>:3128
Error uploading to LAPP: 302 Proxy_Redirected

I think i need to update Lattice to the latest for this to work.  I will get back to on this shortly.   Thanks for help.


[3pt] Using alpha solution, generate multiple realizations of the Falls Lake basin RouteLink.nc file

Part of Agile Story #193
Vary minimum reach lengths between 250 m and 1 km. Share augmented RouteLink files with the Inland team via Google Drive or GitHub pull request.

ping @awlostowski-noaa  | @jameshalgren

ping @awlostowski-noaa  | @jameshalgren