Added OpenCHAMI middleware to router.NewRouter()

Addresses #27 by adding the OpenCHAMI middleware.

Seems that the OpenCHAMI JWTAuth used with AuthenticatorWithRequiredClaims is not compatible with the one being used with github.com/OpenCHAMI/jwtauth/v5 and the PR that adds the jwt.NewKeySet and JWKS functionality has not be merged upstream yet (https://github.com/go-chi/jwtauth/pull/85).

Is the functionality in that upstream PR able to be put into the OpenCHAMI jwtauth for now?

Is the functionality in that upstream PR able to be put into the OpenCHAMI jwtauth for now?

I think the OpenCHAMI jwtauth already has that functionality. I think we would just have to change the import in the OpenCHAMI middleware to point to the OpenCHAMI jwtauth for now and then rebase it to upstream go-chi. Once it finally gets merged, we can change the import back to upstream and then delete the OpenCHAMI one.

OK. Is this ready to be tested?

OK. Is this ready to be tested?

Looks like SMD is ready, but we'll have to switch the authenticator to use the OpenCHAMI jwtauth for now.

I'm getting this error when building:
# github.com/OpenCHAMI/smd/v2/cmd/smd
cmd/smd/routers.go:72:61: cannot use s.tokenAuth (variable of type *"github.com/OpenCHAMI/jwtauth/v5".JWTAuth) as *"github.com/go-chi/jwtauth/v5".JWTAuth value in argument to openchami_authenticator.AuthenticatorWithRequiredClaims
cmd/smd/auth.go:13:2: "github.com/lestrrat-go/jwx/jwt" imported and not used
make: *** [Makefile:55: smd] Error 1

Looks like switching the import to use the OpenCHAMI jwtauth will solve this as discussed here.

SMD is now building with those changes.


Add object metrics to transactor service

A counter tracks record insert/update and a gauge tracking the current index (height of the blockchain).

Looks good, gonna merge once rebuild succeeds


Made Contact us page responsive

Description
The contact us page was not responsive from tablet view (768px) to mobile view (320px). Made it completely responsive on the tablet as well as the mobile view.
before :

after :

Fixed issue no #40
Type of change
Please check options that are relevant to your PR.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Please review my pull request. I have completely made it responsive


[JN-460] Move bulk kit request batches from UI to server

Pretty straightforward change from n API calls to 1. To test:

Go to https://localhost:3000/ourhealth/studies/ourheart/env/sandbox/kits/byEnrollee
Select multiple rows, click "Send sample collection kit" and "Request Kit"
Open the Kits tab (https://localhost:3000/ourhealth/studies/ourheart/env/sandbox/kits/byKit) and see that there are new kits (assuming a freshly populated database, there will be 1 more than the number of enrollees you selected)

@devonbush Yes, I agree 100%. I got mixed up with that myself. I thought there was an argument at one point for putting them in an Enrollee class instead of a Kit class, but I'm probably mis-remembering that.


IOS build failed

in /Users/user/Library/Developer/Xcode/DerivedData/App-cjkkwdgfpdtzlcbcuwkzytqcngbv/Build/Products/Debug-iphoneos/TSBackgroundFetch.framework/TSBackgroundFetch(TSBGTask.o), building for iOS, but linking in object file (/Users/user/Library/Developer/Xcode/DerivedData/App-cjkkwdgfpdtzlcbcuwkzytqcngbv/Build/Products/Debug-iphoneos/TSBackgroundFetch.framework/TSBackgroundFetch(TSBGTask.o)) built for Mac Catalyst, file '/Users/user/Library/Developer/Xcode/DerivedData/App-cjkkwdgfpdtzlcbcuwkzytqcngbv/Build/Products/Debug-iphoneos/TSBackgroundFetch.framework/TSBackgroundFetch' for architecture arm64
Xcode version 12.5

TSBackgroundFetch.framework/TSBackgroundFetch(TSBGTask.o)

Your issue is with BackgroundFetch, not BackgroundGeolocation.  Post an issue at capacitor-background-fetch


Performance optimize reference TopK op

This runs about 4x faster with the tensor sizes and k values in ResNet50
Also add support for sorting output via value and index.
Add unit tests for sorting options
The default sort value was changed from NONE to VALUE to match TensorFlow's default
I believe we should removing the option to sort by index. Neither PaddlePaddle nor TensorFlow support this option.
I believe we should remove the BottomK option, or the compute_max argument to the TopK op. This is not used in any framework and I suspect it was added because we can not because it was required.

The current PR as it is does not change the API. It works just like it used to work. Changing the default value to SORT_VALUES makes TopK work exactly as it used to work. It used to produce sorted values if you did not specify a sort type and it still does that. The only difference now is that if you specify NONE as the sort type then it may or may not produce sorted results. The reference kernel will now not produce sorted results if you specify NONE. If you specify NONE it means that you don't care about the sort value.

@rkimballn1 and I chatted about this offline. While it's true that the written definition of the op did not require sorting by default, the unit tests for TopK actually were insisting on sorted output. So... that's pretty cool. Changing the default here is probably the best solution.


Faster windowed normalization

Speeds up the window-fast option just added in #83 using scipy.ndimage.filters.percentile_filter.
I compared the windowed normalization techniques using a timeseries of length 50,000 and a window of 1,000:
window: 4.05s
window-fast-old: 2.64s
window-fast-new: 785ms
```
So we get a speedup of around 3x over the `window-fast` method in #83, and 5x over the original `window` method. These speedups were about the same over other window lengths (50, 500, 5000).

LGTM, thanks @poolio ! We did some testing on the cluster here and the speed up is great.


Update types.jl

Adding struct for 3D triangulation of meshes

Hi Prani - thanks for adding this, but can you make a single PR with the changes here and in #1069?


Fix import / usage of Katex dependency

Katex is loaded from CDN in index.html in L26 and L32-40 and it is defined as dev dependency in package.json which does not seem to be correct.
Todo

[ ] Decide whether to use a CDN or define it as dependency (not dev)
[ ] Clean up code in index.html and/or package.json

got fixed in branch masterthesis/patternauthoring and will be merged with the next content integration

this issue was resolved and is no longer present on the master branch


ReactDOM peer dependency

Does ReactDOM need to be a peer dependency for this? I can only see it being used in a test file. I've been using this library in a react-native app and so far it has been fine apart from the npm install console warning which I just ignore for now.

Fixed in 7d6dfb770c99a3df8f76cdc2800f31d3ae55ba5e and published as v3.2.1

Thanks for getting that sorted. I would have got a PR in but have been a little busy :(

No problem, it had been a while since I touched the project, too.
On Thu, Mar 14, 2019 at 3:22 AM Thomas Drake<EMAIL_ADDRESS>wrote:

Thanks for getting that sorted. I would have got a PR in but have been a
little busy :(
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/facebookincubator/redux-react-hook/issues/42#issuecomment-472789887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2zi_RNPy4NyRrnasXNrHhAthtaa7npks5vWiLFgaJpZM4bsMGa
.


TypeError: resetTimeWidget.add is not a function

When trying to open the settings for this extension, I get this error:
TypeError: resetTimeWidget.add is not a function

Stack trace:
  PrefsApp@/home/ttabi/.local/share/gnome-shell/extensions/network-stats@gnome.noroadsleft.xyz/prefs.js:110:25
  buildPrefsWidget@/home/ttabi/.local/share/gnome-shell/extensions/network-stats@gnome.noroadsleft.xyz/prefs.js:206:20
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

@timur-tabi  Thanks for filling the bug.
Can you give us some more details  ? like.
- OS version.
- Shell version.
- Extension version.
- and frequency of this issue.

@timur-tabi
Ubuntu 21.10 comes with GNOME 40 default shell version.
There are some breaking changes at API level. Would need some time to fix this for 21.10.

@timur-tabi  If you are a developer, can you try out latest version from main ?

I'm not a Gnome developer, but I'll try.

I rebooted and somehow the addon is now installed.  I can open the settings now without error.
On a side note, I don't actually use this add-on any more because it doesn't give me separate displays of download and upload speeds.  It's either one or the other, or a combined speed which I think is useless.

@timur-tabi
Thanks for trying out.
We have an outstanding request for showing both speeds side by side.
I hope you would like to give it a try in future. closing this bug now.


Version bump 1.00.012

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #50   +/-   ##
======================================
  Coverage    9.12%   9.12%
======================================
  Files          11      11
  Lines         252     252
======================================
  Hits           23      23
  Misses        229     229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aee8b5...65f4127. Read the comment docs.


Use .specific_deferred when calling .get_admin_display_title()

There are quite a few places where we are not calling .get_admin_display_title() with a specific page instance so custom implementations of this method weren't being used.
@ababic's .specific_deferred method allows us to get a specific instance without an extra query. So custom implementations of .get_admin_display_title will be called without much of a performance hit for those who don't use this feature (hopefully).

Merged in 44f3731b1cd458f1fce0dbf87507805fce5fea4f

Merged in 44f3731b1cd458f1fce0dbf87507805fce5fea4f


added wikipedia links, and links to free software / open source

Hi, thanks so much for these suggestions! I don't find it necessary to include definitions of free/open source software, and I plan on adding longer descriptions to each of the categories (see #12), which should help address the need for the other links, so I'm going to close this PR.

The descision is of course yours to make, i will happily link to wikipedia from my own fork.
Great to hear that you plan on expanding the descriptions!
I beg you to consider at least including the term "free software" in the first heading or in the first paragraph, instead of writing about "open source" only. While your article apply to free sotware equally well as for open source, you are already making a political statement by writing exclusively about open source only. See https://www.gnu.org/philosophy/open-source-misses-the-point.html for a longer explanation of Stallman himself.
-Horst


Different buckets give different outputs at first time step during decoding

Hi,
Background
I'm trying to build a chat bot and have a basic understanding of tensorflow Sequence2Sequence API  by reading from here:
https://www.tensorflow.org/tutorials/seq2seq/
I've also read related papers for Neural translation, attention mechanism during encoding/decoding etc.
RNN translate code is taken from here:
https://github.com/tensorflow/models/blob/master/tutorials/rnn/translate/seq2seq_model.py
Bucketing/Attention mechanism code is picked from here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/legacy_seq2seq/python/ops/seq2seq.py
During my training(attention mechanism, GRU cell), I gave my buckets as [(2,2),(4,4),(6,6),(,8,8),(10,10)].
Issue
During decoding, if I force a bucket_index on the same input I'm getting totally different outputs at the first time step. For example:

Input : How're you ?
Bucket index : 1
Output : NAME UNK NAME
Input : How're you ?
Bucket index : 2
Output : Hi NAME to the

Observations

I can fix the bad outputs at each time step using beam-search. However, why I'm getting different word as output at the first time step during decoding ? Shouldn't the smaller bucket output be a subset of larger bucket output ?

I've tried searching online and everywhere it's mentioned that parameters are shared across various buckets.  Buckets are used for training efficiency and not for model tuning. I've also verified that my trainable parameters are common across all the buckets.

The biggest difference I can see between encoder inputs for various buckets is the extra padding at the very start. We are doing attention mechanism on encoded_states, and softmax weights are already learned for those encoded states during training. Therefore,  Can those softmax weights for those extra padded inputs cause sufficient difference leading to different output during first time step of decoding ?

Did any one else also encounter the above issue?  Any help for fixing the above error would be greatly appreciated.

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Migrate SpecialRoutePublisher to use v2 of publishing-api

All clients of publishing-api should use v2 of the API.  This library contains one class, SpecialRoutePublisher which talks to the publishing-api (rather than just provide convenience adapter methods to do so).  This change modifies that class to use v2 of the API.
Trello: https://trello.com/c/yaUJdIRH/456-migrate-gds-api-adapters-gdsapi-publishingapi-specialroutepublisher-to-use-v2-of-publishing-api

I've tried running this:
vagrant@development:~/govuk/rummager (master)$ be rake publishing_api:publish_special_routes
Publishing exact route /sitemap.xml, routing to rummager
rake aborted!
undefined method `put_content' for #<GdsApi::PublishingApi:0x007f4583beaa08>

This is because SpecialRoutePublisher still uses the PublishingApi V1 class. Because we've stubbed the put_content and publish calls, the tests pass while they shouldn't.
I would suggest getting rid of the stubs first and test with the assert_X test helpers, so that the tests fail (like https://github.com/alphagov/gds-api-adapters/pull/404#discussion_r47073218).

Have changed in line with Tijmen's comments

Any objection to me picking this up and getting it across the line? We want to update the feedback app to use V2 for its special route.

boffbowsh - yep, please do. I think I've done all that I was going to do anyway - would be interested to see if you want to make any changes.


RadioButton value type should allow numbers

Discussed in https://github.com/carbon-design-system/carbon-components-svelte/discussions/1866

Originally posted by hslee2008 December 16, 2023
Currently, carbon-components-svelte only allows type of string | undefined in value (RadioButton).

But there are many cases where the value needs to be numbers.
I mean, putting in numbers does work but the types only say string is allowed.

Fixed in v0.82.7


[techdocs-node] S3 key is missing bucketRootPath when reading files from S3

Expected Behavior
Correct S3 key is generated when bucketRootPath is used
Actual Behavior
I've added console.log at https://github.com/backstage/backstage/blob/master/plugins/techdocs-node/src/stages/publish/awsS3.ts#L390
Logs when accessing /docs/default/Component/backstage page. That's a component named backstage with its own configuration and docs.

{
  decodedUri: 'default/Component/backstage/index.html',
  filePathNoRoot: '../default/component/backstage/index.html',
  filePath: 'default/component/backstage/index.html', <!------------ NOTICE missing path.
  path: 'techdocs'
}
2022-03-15T15:07:48.796Z backstage info ::ffff:<IP_ADDRESS> - - [15/Mar/2022:15:07:48 +0000] "GET /api/catalog/entities/by-name/Component/default/backstage HTTP/1.1" 200 - "-" "node-fetch/1.0 (+https://github.com/bitinn/node-fetch)" type=incomingRequest
2022-03-15T15:07:48.799Z backstage info ::ffff:<IP_ADDRESS> - - [15/Mar/2022:15:07:48 +0000] "GET /api/catalog/entities/by-name/Component/default/backstage HTTP/1.1" 200 - "-" "node-fetch/1.0 (+https://github.com/bitinn/node-fetch)" type=incomingRequest
2022-03-15T15:07:48.802Z backstage info ::ffff:<IP_ADDRESS> - - [15/Mar/2022:15:07:48 +0000] "GET /api/techdocs/sync/default/Component/backstage HTTP/1.1" 200 - "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.51 Safari/537.36" type=incomingRequest
2022-03-15T15:07:48.803Z backstage info ::ffff:<IP_ADDRESS> - - [15/Mar/2022:15:07:48 +0000] "GET /api/techdocs/metadata/entity/default/Component/backstage HTTP/1.1" 304 - "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.51 Safari/537.36" type=incomingRequest
2022-03-15T15:07:48.833Z techdocs warn TechDocs S3 router failed to serve static files from bucket gat-backstage-qa at key default/component/backstage/index.html: The specified key does not exist. type=plugin

Steps to Reproduce
Configuration:
techdocs:
  generator:
    runIn: local
  publisher:
    type: awsS3
    awsS3:
      bucketName: ${TECHDOCS_PUBLISHER_BUCKET}
      bucketRootPath: "techdocs"

Context

I'm trying to do initial deployment of backstage and put all backstage related files into 1 bucket. I'd like to use bucketRootPath and while generator works, docs are uploaded, when I try to access them, S3 key is missing bucketRootPath
Your Environment
Everything running on newest version, other websites inside backstage are working as expected.

I'll try to find a reason why initial URL path is passed with "..." but it's a very strange behavior.
I think maybe we're missing a condition at https://github.com/backstage/backstage/blob/master/plugins/techdocs-node/src/stages/publish/awsS3.ts#L376 ?
- const decodedUriNoRoot = path.relative(this.bucketRootPath, decodedUri);
+ const decodedUriNoRoot = this.legacyPathCasing ? path.relative(this.bucketRootPath, decodedUri) : decodedUri;

I'm not exactly sure what's the legacy, I've just started using backstage.

@arathunku are you still stuck with this?

Yes, nothing changed in this regard. I'll schedule some time to look into fixing this and submitting PR, I was just hoping for a discussion first.

I'm happy to jump on this if no one else is..... causing issues on our deployment as well

@bchalk101 Yes please go ahead

Experiencing this error using techdocs 1.3.1. Is anyone working on a fix?

I think I've tracked this down and will try to put together a fix. Here's the issue:
This line in AwsS3Publish creates a relative path as follows:
const decodedUriNoRoot = path.relative(this.bucketRootPath, decodedUri);
If bucketRootPath is configured and is the root of decodedUri, then decodedUriNoRoot is ../{decodedUri}
a bit later, bucketRootPath is joined back to this path here as follows:
const filePath = path.posix.join(this.bucketRootPath, filePathNoRoot);
So, this ends up being evaluated as: {bucketRootPath}/../{decodedUri}, and thus bucketRootPath is dropped from filePath.
Screenshot from debugging this locally:


[IBM VPC] Additional icons

Please add the 2 svg files in the attachment to img/lib/ibm/vpc
And in IBM / VPC please add the 3 references to the svg files:

Power Instance

which points to the new img/lib/ibm/vpc/PowerInstance.svg

Transit Gateway

which points to the new img/lib/ibm/vpc/TransitGateway.svg
Bare Metal Server

which points to the existing img/lib/ibm/vpc/BareMetalServer.svg
Let me know if there are any problems or questions.
Thanks!
Jay
IBM_VPC_Icons_Updates.zip

Can you see it on imgur?
https://imgur.com/a/yPHDdXg
SVG like those are not production quality, so we redraw them. If you avoid such when possible, it'll take us less time to implement your changes.

Thanks for letting me know, I will definitely pass this along to our icon folks.


Fix missing join restrictions

Sorry - another accidental PR that was intended to be toward our fork

Changes Unknown when pulling 467148c40a5d4648f2a151bf8f4a20f815e10bda on Code4SA:fix-missing-join-restrictions into ** on openspending:master**.


Add support for custom fields in the log messages for unit test logger

This change dumps logger fields out added to a logger for unit tests. Fields are supported for other default outputs like, stdout stderr etc. but unit tests use logbuffer output which did not support logger fields.
@zquestz @jpoler @wallyqs

LGTM 👍 let's do this


Fix mistakes in rapidfuzz.process docs

Hello,
As I was reading a part of the documentation I stumbled upon a couple of minor mistakes and this is a PR to fix them. You can find a detailed description in the commit messages.
Also, are these 3 references to max outdated?
https://github.com/maxbachmann/RapidFuzz/blob/c8be9093320bedcd1d75a816b6a554233074db78/src/rapidfuzz/process_py.py#L125
https://github.com/maxbachmann/RapidFuzz/blob/c8be9093320bedcd1d75a816b6a554233074db78/src/rapidfuzz/process_py.py#L467
https://github.com/maxbachmann/RapidFuzz/blob/c8be9093320bedcd1d75a816b6a554233074db78/src/rapidfuzz/process_py.py#L480
If they are I can push an extra commit in this PR to replace them with score_cutoff.
Thanks for maintaining this useful project!

Thanks for the PR. Those are certainly mistakes in the documentation.

Also, are these 3 references to max outdated?

Yes this should just be score_cutoff.

Yes this should just be score_cutoff

Thanks for confirming. I just pushed a commit.
I changed The list is sorted by score_cutoff or max depending on the scorer used to The list is sorted by similarity or distance depending on the scorer used as I'm not sure what being sorted by score_cutoff means. Let me know if I guessed the intent right.

I changed The list is sorted by score_cutoff or max depending on the scorer used to The list is sorted by similarity or distance depending on the scorer used as I'm not sure what being sorted by score_cutoff means. Let me know if I guessed the intent right.

Yes that is a lot better explanation :+1:


WICKET-6264: Form: improve error message for disabled/invisible IForm…

…SubmittingComponent

+1 to merge.
@martin-g - WDYT?

Looks good!
Please create a ticket in JIRA so it appears in the changelog.
The same improvement could be done for the problem with Fragments in 7.5.0, if the component is not rendered.


Added support for custom CIDRs for bottlerocket

Fixes #N/A
Description
Added support for custom CIDRs for bottlerocket
How was this change tested?
make presubmit
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

9 of 11 (81.82%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 82.675%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/amifamily/bootstrap/bottlerocket.go
8
10
80.0%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.004%

Covered Lines:
5712

Relevant Lines:
6909

💛  - Coveralls


indicating release dates to NCBI in CEDAR metadata

In the CEDAR template there is only one field to indicate "Expected Release Date", and it has no impact on whether the submission is made public or not. I'm not sure what its purpose is (any thoughts?).
There are 2-3 different submission types created by the template: BioProject (if it doesn't already exist); BioSample; and SRA. The latter 2 can each have multiple instances.
NCBI interpretation of release dates is complicated; they release 'parent' items like BioProject if the (any!) BioSample or SRA submission is released.
For simplicity we propose a optional single release date for the whole CEDAR collection, which may include any number of BioSample or SRA submissions. The release date field would be at the top of the template.
Is this agreeable?
If not, we could add release dates to each section, but we would not add code to check that no unexpected consequence will ensue. (We can document the understood behavior in the help text for each release date though.

Yes, I agree this is the best solution as the outcome of setting the release date will be obvious to everyone.

OK, we will implement it as I proposed. I believe (based on testing) we can just change add that field to the current template and the (two or three) existing in-progress instances will pick up the changes gracefully.
We also will change the documentation of the existing Expected Release Data attribute in the BioSample part to make clear that is not used for setting any of the release dates in NCBI.


Feature/download data

This PR adds

[x] Download Component
[x] Download files based on data on the view
[x] Select download format
[x] Use view query to download data
[x] Move pagination to bottom
[x] Remove Total Preview rows

Related to #5

@anuveyatsu , I can update the Download to the top, and also create another PR.


Termdebug: allow disabling the "window toolbar"

Please describe the problem.
Currently Termdebug automatically adds the window toolbar if mouse is enabled. However I don't want this behavior since the winbar clutters the screen.
The way I'm currently coping with this is via clearing mouse, opening :Termdebug and then re-enabling mouse=a in a function. (I don't use mouse much, but I like to keep it enabled just in case).
Describe the solution you'd like
Instead of assuming mouse being enabled means the user wants the window toolbar, add an option (let's say g:termdebug_no_winbar) which allows the user to explicitly disable the winbar.

Please describe the problem.
Currently Termdebug automatically adds the window toolbar if mouse is enabled. However I don't want this behavior since the winbar clutters the screen.
The way I'm currently coping with this is via clearing mouse,
opening :Termdebug and then re-enabling mouse=a in a function.
Describe the solution you'd like
Instead of assuming mouse being enabled means the user wants the
window toolbar, add an option (let's say g:termdebug_no_winbar)
which allows the user to explicitly disable the winbar.

I think we should use a dictionary with options to configure Termdebug,
instead of all separate variables.  Then it's also easier to switch
between setups.  Well, we were already switching over to using
g:termdebug_config, let's continue that.
--
This computer is so slow, it takes forever to execute and endless loop!
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Looks like this got implemented at d13166e7. So closing this.


Spelling correction for Protect Hybrid Backups

udpates -> updates

#sign-off
@andresnava Thank you for catching the typo and submitting the fix.

@markgalioto: I'm sorry - only the author of this article, @JPallavi, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Site Build "litters" Repo

Bug Report
Description
When using terra-dev-site's webpack configuration, the terra-dev-site generate app-config script is automatically ran. When run, it creates the dev-site-config/build directory and generates the site configuration. These configuration files can "litter" the project, where as the packed webpack assets use a virtual file system, so these files do not 'litter' the project. I am wondering if there is a way for these files to be created virtually or be automatically clean after running in webpack.
Additional Context / Screenshots

Possible Solution
Not sure if this is feasible since webpack is a static analysis tool and which is likely why these files are not using a virtual file system as is.

This is possible. I had a plan but didn't finish it as part of the intial offering. Through my work on kaiju i developed a 'fallback-filesystem' that we could hook up to webpack to avoid producing the build folder (and aggregate translations if we want). But it's work to do and I'm not sure how high of a priority is.


Improve DoK performances

Avoid unneeded (i.e. already performed) computations
Better use of std::unordered_map: we directly insert value instead of dealing with thrown exceptions

Somehow related to #101
Here we focus only on the (multi-)sequential part


Integrate wavesurfer with existing SoundManager2 audio player

I have an implementation of wavesurfer with SoundManager2. I use the latter to play and control the audio, the former to show a waveform, from a JSON array, and to capture clicks on the waveform, which I then raise as SoundManager events to change the position of the track. An example is at: https://byta.com/app/public/share/41/7460/23157. The full code is quite complex but the wavesurfer init code for each track is:
                    var waveformDiv = '#waveform_'+ fileID;
                    if (wavesurferObj){
                        wavesurferObj.empty();
                    }
                    wavesurferObj = WaveSurfer.create({
                        container:  document.querySelector(waveformDiv),
                        waveColor: '#d8d7e1',
                        cursorColor:  '#d8d7e1',
                        progressColor: '#ff4d59',
                        barWidth: 4,
                        backend: 'MediaElement',
                    });

                    $('.mediaExpand.expanded #fileDiv_' + fileID).find('.waveform').slideDown();

                    //Set song
                    wavesurferObj.song = soundManagerObj.nowPlaying.url;

                    max = Math.max.apply(Math, wavFormData.data);

                    //Set peaks
                    wavesurferObj.backend.peaks = wavFormData.data.map(function (p) { return (p / max) });

                    //Draw peaks
                    wavesurferObj.drawBuffer();

                    //Start playing after song is loaded
                    wavesurferObj.on("ready", function () {
                        soundManagerObj.nowPlaying.play();
                        wavesurferObj.drawer.unAll();
                        $(wavesurferObj.drawer.container).on('click', progressBarClickHandler);
                    });
                    wavesurferObj.on("error", function (err) {
                        if (preloadedAudio.hasOwnProperty('id_' + fileID)) {
                            preloadedAudio['id_' + fileID].destruct();
                            delete (preloadedAudio['id_' + fileID]);
                            $('#waveform_'+ fileID).empty();
                        }
                        if (currentlyLoading.fileID && currentlyLoading.fileID == fileID){
                            currentlyLoading = {};
                        }
                        getMetaDataAndPlayTrack (fileID, currentSound);
                    });
                    wavesurferObj.load(wavesurferObj.song, wavesurferObj.backend.peaks, 'none');

That works fine. The omission of any call to wavesurferObj.play() prevents WaveSurfer from outputting any sound, but wavesurfer still requests the track from the url to load it. I would like to separate WaveSurfer entirely from any audio functions, use it in "display only" mode, so to speak. We have a HTML5 audio element created by SoundManager available by the time the wavform loads so is there a way to use that and prevent any unnecessary calls to the server?
Many thanks in advance,
Pete

@RighteousIdealizedDung have you checked https://github.com/collab-project/videojs-wavesurfer?

@thijstriemstra I don't think that helps me. Our issue that we have invested a lot of time in getting audio streaming working well across browsers (which is hard to do!) using SoundManager2. We'd just like to add wavforms to that set-up. We have an audio instance on the page, created by SoundManager2, I would hope that there is a way that WaveSurfer  can use that.

Instead of the URL of a song, you can load() an <audio> element (which I assume SoundManager2 is creating somewhere). Also you don't need to set peaks directly and call drawBuffer. Just pass them as the second parameter to the load() call.

@katspaugh Thanks for that, it was the info I was looking for. Unfortunately it didn't solve my problem, it seems that SoundManager2 doesn't create an <audio> element. I am having to rework my code because of that. Am closing this issue, and thanks again.

Instead of the URL of a song, you can load() an <audio> element (which I assume SoundManager2 is creating somewhere). Also you don't need to set peaks directly and call drawBuffer. Just pass them as the second parameter to the load() call.
So, inspect your HTML, find the audio tag SoundManager2 creates, and create wavesurfer.js like this:
                      var wavesurfer = WaveSurfer.create({
                        container:  document.querySelector(waveformDiv),
                        waveColor: '#d8d7e1',
                        cursorColor:  '#d8d7e1',
                        progressColor: '#ff4d59',
                        barWidth: 4,
                        backend: 'MediaElement',
                    });
                    var peaks = wavFormData.data.map(function (p) { return (p / max) });
                    wavesurfer.load(document.querySelector(audioTag), peaks);

Would it be okay to re-open this issue and talk about how to do it with React and forwardRefs? I created a question on Stackoverflow about this and we can figure how to do this, it can help others in the future.
https://stackoverflow.com/questions/71907215/how-to-integrate-wavesurfer-with-existing-audio-react


[REQUEST] - Reasoning Settings, other languages?

Reference Issues
No response
Summary
Is there any way to include other languages among those available for Reasoning Settings?
What does the current list of languages depend on?
Thank you.

Basic Example
--
Drawbacks
--
Additional information
No response

Adding more language is as simple as changing some config but you have to run kotaemon from source.
Go to kotaemon/libs/ktem/ktem/utils/lang.py
SUPPORTED_LANGUAGE_MAP = {"en": "English", "ja": "Japanese", "vi": "Vietnamese"}

Change the above list as you like.
Also, change this value in flowsettings.py
SETTINGS_REASONING{
    "lang": {
        "name": "Language",
        "value": "en",
        "choices": [("English", "en"), ("Japanese", "ja"), ("Vietnamese", "vi")],
        "component": "dropdown",
    },
}

Run the app again python app.py and that's it.

Go to kotaemon/libs/ktem/ktem/utils/lang.py

Thanks!
(As for "user install", the correct folder is: kotaemon-app\install_dir\env\Lib\site-packages\ktem\utils\lang.py)

I'm trying to understand whether this will allow me to upload documents in other (natural) languages? Trying out the docker version and loading documents in German, I always got close to zero relevancy score.

@drorata should be no problems. Scores can be low but please check if LLM answer can satisfy your need. Make sure to check Use LLM relevant scoring in Retrieval settings to make it more reliable.


Whiteboard Updates

Bug fixing {Whiteboard communicator, Checkpoint handler, Operations handler}
Code refactoring
Added more unit tests

Whiteboard testing with UX-Networking complete. Almost everything is working fine.
@RaswanthMurugan20 @pulavartivinay  Please rectify the screen sharing bug.


make numbers start at 1 not zero?

Hi the heading numbers start with 0 not a 1, which is confusing for me. Is it possible to make them start with a 1?

They start with 1 not 0.   I am unable to replicate the problem you are seeing, can you give me more information. Make sure you are also using the current version.
You can see at line 146 I declare the tracking array for the heading levels.  They are initialized at zero with:
146: var numbers = [0,0,0,0,0,0,0];
Then at line 173 the heading level is incremented before it used:
173: numbers[headerlevel]++;
You may try to uninstall and reinstall to make sure you have the current version from the G Suite Marketplace: https://gsuite.google.com/marketplace/app/markdown_tools/788541604518

Hi I made a video: https://greencloud.gn.apc.org/index.php/s/YmPa5WXaLSjxscP
Reinstall didn't change the issue
The only other thing I noted is that my h2's (3 of them) began with an "I" and the "I" (i) is removed when I use the "clear heading numbers issue"

That is by design because you do not have an H1 heading, you started with H2.  For example:
H2 Test
H2 Fun
H1 Title Section
Would give you
0.1 Test
0.2 Fun
1 Title Section
If you add an H1 before your H2s, then everything works.  Do most of your documents usually start without an H1?  Like you start with H2s or H3s?

Yes, that worked, thanks! So in order to get each section to be 1, 2, 3 I have to use H1 for the sections?
I usually use Title and then H2, mostly the font size is more reasonable, I've never wanted to get into changing the formatting etc, I only really use them this way so I can get a content table with links, but because many subheadings are the same in this case I thought it would be better to have numbers.
So, regarding the I being deleted when numbers are removed - can you replicate that?

Yeah, that is a known issue with needing to support letters.  I have wondered if I should remove support for heading numbers by letters.

Ah, okay. I guess it's up to you - it seems like either just numbers or a number letter combo is most useful, but as you can tell I am no expert. Maybe if you knew how much it was being used for letters that would be helpful. And an amazing feature would be to "refresh heading numbers".
Thanks for your help and a super useful plugin, it really solved a big issue for me.
Btw, did you notice that the only other plugin for this is no longer functional? I think it's abandoned. So it's all down to you now ;)


Switch off dynamic top nav

This PR switches off requirements for privacy requests to require connections, and datamap to require systems.

@seanpreston is this still relevant?


[HUDI-743]: Remove FileIOUtils.close()

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Remove FileIOUtils.close() method - not needed anymore
Brief change log
Removed FileIOUtils.close() method - not needed anymore
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[X] Has a corresponding JIRA in PR title & commit

[X] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1461 into master will increase coverage by 0.03%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c30013...8152c49. Read the comment docs.


Triggers validation even when filled

When my input is filled and matches the mask, pressing any key will still trigger the validation. Is there a way to prevent this? I'm using a custom async validator that does a request to the server and I'd like to avoid it...

Are you talking about Angular 2, if so, yes we could prevent that behaviour.
@msafi Do you think this should be changed?

Yes for angular2 sorry :)

Obiously it should still trigger validation at least once, but only the first time it matches the mask :)
If you guys decide not to change this, is there a way I could do it myself with the available events?

Not sure about that. The main change would be the frequency of events triggered. Currently, the model is updated anytime a change event is fired. We would have to change that behaviour by filtering out those change events that do not result in a change of the model.
I'm unsure if this would break functionality of others possibly relying on it.

@PerfectPixel Yeah, I'm not sure about the possible impact of this. If we decide to change it, we can publish a major version bump. I'll leave the decision to you.

And what about having it as an optional change only available with a boolean setting? Like the guide one...

I don't see a good reason why we should not suppress ngModel changes if really nothing changed. If someone needs to be notified everytime something happens, they can still fall back to the regular change event.
I'll submit a PR shortly.

Published @PerfectPixel's PR #330 with this fix as<EMAIL_ADDRESS>


CRUD table

I should be able to add/create/delete/edit activities from within the summary table

https://www.akashmittal.com/gui-utility-to-generate-react-table-code/?ck_subscriber_id=1004676638

https://www.akashmittal.com/gui-utility-to-generate-react-table-code/?ck_subscriber_id=1004676638

https://codesource.io/building-a-crud-application-using-preact/?ck_subscriber_id=1004676638

We need it for both categories and activities

Done, for activities


Submit on enter

Hitting enter while typing in an input field does not trigger form-components onSubmit handler.

Seems to work just fine here: https://esnextb.in/?gist=8146e128a98291f00623e24a1ecc5345


callautomation/2023-03-06-ga1

Data Plane API - Pull Request
Azure Communication Services Call Automation provides developers the ability to build server-based, intelligent call workflows, and call recording for voice and PSTN channels.
This is for the first GA release for ACS's Call Automation.
API Info: The Basics
CreateCall: Allows you to create a new outbound call. Once given information (target of the call, such as their phone number), Call Automation service will call the target end try to establish a call.
AnswerCall: Answer incoming call. This is another way to establish a call. For example, you can purchase Direct Offering phone number from Azure Portal to answer incoming call with Call Automation for that phone number.
CallConnectionId: CallConnectionId is returned when you establish a call with either Create or Answer above. This Id is to be used to do subsequent actions for the call. For example, if I want to play a media file in the call, pass both CallConnectionId and media file endpoint. Call Automation service will play the media file in the call.
Callback Events: Because of nature of a phone call, during the call, Call Automation Service will send back asynchronous events to notify the state of the call. Such as CallConnected and ParticipantsUpdated event.
Callback Uri: Expanding above Callback events - here is an example. When you CreateCall, you will get response of 201 right after Call Automation service received the request. However, this does not mean the call is established. It is dialing. Once the target call receiver answers their phone, the call is established and CallConnected event is sent. This event is sent back as Webhook to CallbackURi provided in CreateCall/AnswerCall.
Is this review for (select one):

[ ] a private preview
[ ] a public preview
[x] GA release

Change Scope
This is GA release of previous preview release. See previous private preview Pull Request here: https://github.com/Azure/azure-rest-api-specs/pull/19409

Design Document: https://learn.microsoft.com/en-us/azure/communication-services/concepts/call-automation/call-automation
Previous Open API Doc: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communication/data-plane/CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json
Updated paths: Create, Answer, Mute, Unmute, Transfer, AddParticipant, RemoveParticipant, StartRecording

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR.


import is being deprecated

In order to use Hiera as a lightweight ENC, manifests/site.pp imports the contents of manifests/node.pp, which just does a Hiera look-up for values of the classes key before importing them.
This makes use of the imports keyword in manifests/site.pp, which Puppet Labs announced that they intend to deprecate entirely by Puppet 4.
I'm raising this issue as a personal reminder to look in to fixing this up in this repository.

#13 fixed this.


WIP: Fix comment with /*! ... */

Work In Progress, do not merge!
Couldn't work out a fix yet, but wanted to create the pull request already in case anyone has any ideas for solving this :) This PR includes a failing test case.
Description:
normalize.css contains this first-line comment:
/*! normalize.css v8.0.0 | MIT License | github.com/necolas/normalize.css */

and stylis currently converts this to:
{/*! normalize.css v8.0.0 | MIT License | github.com/necolas/normalize.css */}

This no longer happens in the upcoming v4. I've just added a test for this.


Updated to UE5.2 (property getters) (TArray)

It will be backward-incompatible, not sure how to request properly.
Maybe create new branch for UE5.1+?

Added basic BP functionality


[webpack] allow specifying watch options for the dev server

On my computer i have some issue with electron-forge which uses all my cpu on start with wepback.
I think it's related to webpack watch feature.
To "improve" the situation i added options to the dev server [here] (https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackPlugin.ts#L280)
Adding  (doc):
watchOptions:{
     aggregateTimeout: 500,
      poll:1000,
      ignored: /node_modules/
 }

made the CPU usage go down to 50%. Which is much better (though still not that good).
Could you add a way to pass options to the dev server through the webpack plugin configuration?
Thanks

Bump to this issue.
It seems to be a pretty serious shortcoming. The manual fix to WebpackPlugin.ts [including watcherOptions] also solved my CPU issue.
In my case, I am writing a mid-sized React based app, and noticed electron-forge-start.ts was destroying my CPU.
Prior to change -> idle at 200% CPU.
Post change -> idle at 5% CPU
Using boiler plate from docs, electron-forge-start.js was using 5% of CPU while idling. After change it uses 1%.
So it seems that the CPU used scales with project size, and that the problem is only further exacerbated as project grows.

Bump again on this issue. Fix seems simple, have had to apply this patch at least 8 times in the past month due to package updates / overwrites / reinstalls of node_modules on various dev machines.
Is there any reason to just include these watch options in the default watcher config?


add

https://github.com/m4ll0k/SecretFinder
https://github.com/x90skysn3k/brutespray
ad these to

Brutespray is already added and SecretFinder is extremely slow so we use other tools to extract "secrets" from JS files


Info on starting multiple repositories is no good.

[Enter feedback here]
"Open a solution that has a repository initialized" ---> HOW? No link, nothing in search.  I cannot get multiple repository support to turn on, and nothing here (or anywhere else in the docs) seems to be helpful.  FYI, I have a lot of repos under one src directory with cmake files, and the generated solution and projects under a separate build directory.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c34eb526-a69f-d565-d7b0-e9ec8bd7226c
Version Independent ID: c34eb526-a69f-d565-d7b0-e9ec8bd7226c
Content: Work with multiple repositories
Content Source: docs/version-control/git-multi-repository-support.md
Service: visual-studio-windows
Sub-service: general-ide
GitHub Login: @ghogen
Microsoft Alias: ghogen

@RobL371 -- Rob, thank you for your feedback.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Stack Overflow
Reddit

@ghogen -- Gordon, please look into the documentation aspects of this issue.

@RobL371
I wasn't sure, so I asked one of our product program mangers, who suggested that you should try the open folder method from your src directory to see if the repositories are recognized and activated, then go from there in specifying the start project.

I think we can close this issue. The steps in that section apply to a different case where you already have one solution connected to GitHub, but they won't work for everyone.


feature menu collapse

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English).
[ ] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

#5890

@baiyaaaaa https://github.com/ElemeFE/element/pull/5941/files#diff-02531e98c471394068120f59c8385b5dR144
这种css 没必要强制限制父子关系吧，只要我一自定义一下，加一个div什么的。。。就失效了

展开情况下可以有这种联级下拉么


Update Gmail Keyboard Shortcuts.md

Hello! When you will accept this pull request I will pull the Excel Keyboard Shortcuts!

@stefanoleggio, Are you participating in hacktoberfest 2022?
So, I will merge them tomorrow.

Yes I am participating. But I think they are already valid (the website is already counting the pull requests)

Yes I am participating. But I think they are already valid (the website is already counting the pull requests)

Probably, because you're from Italy.
I'm currently in India. I will merge your PR tomorrow Morning!


Support passing memoryview objects

Use case
We have a large pointer (memoryview) to a bytes buffer containing compressed data.  Specifically we are receiving and sending compressed py-lz4framed data via zeromq zero-copy.
It would be beneficial (and possibly more performant) if we did not have to create a copy of the bytes buffer (via .tobytes()) before we passed the data to py-lz4framed.
Desired behavior

decompress accepts memoryview object and does not create a copy of the input data
compress accepts memoryview object and does not copy the input data

I apologize that my C skills aren't good enough to submit a pull-request.

I think this is already addressed by https://github.com/Iotic-Labs/py-lz4framed/issues/11, but I haven't made a release with it yet.
I'll see whether I can make a release this evening for that.

v.0.9.7 should address your request hopefully. If not, please re-open this issue


Can pipx install packages which are managed via Poetry?

I want to create a project via Poetry.I plan to install my project later on the end user machines with pipx.
From my understanding Poetry creates  only a pyproject.toml file for package installation, not a setup.py file. However pipx seems to expect setup.py only as install file.
Therefore I would like to check:  Can pipx install packages which are managed just via the pyproject.toml file of Poetry?

Yes. The setup.py code is only an example; Poetry has its own entry points syntax, but pipx should pick it up correctly (via PyPA’s interactivity specifications), as long as Poetry is packaging things properly.

The bottom of https://github.com/pipxproject/pipx#where-does-pipx-install-apps-from mentions how to set up a poetry project to work with pipx

Thanks for all the information. Makes total sense.


Change in content

This optional protection, available to enterprises, helps deliver more productive, performant, and delightful Windows experiences.
-should be-
This optional protection helps deliver more productive, performant, and delightful Windows experiences.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b16da7d1-e552-e274-9406-5390252b0c04
Version Independent ID: d0c9b8a8-4fba-4ea8-cfdd-6ae6d67a2e19
Content: How Microsoft identifies malware and potentially unwanted applications
Content Source: windows/security/threat-protection/intelligence/criteria.md
Product: w10
Technology: windows
GitHub Login: @levinec
Microsoft Alias: ellevin

@evachen96. Create new PR and add your contributions

Changes have been made per email thread! Will update later today


chore(ui): Write instructions how to add a route

Description
Follow up after doing the steps in #7828
Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed

/test ocp-4-13-ui-e2e-tests


Remove the authentication

To facilitate the use of the bot and avoid misunderstanding about licenses, you need to add a flag to disable the authentication of the MongoDB. And it's interesting to add a script to create the first setup in MongoDB. Finally, the documentation must be updated, explain that the project is dead only for study and explain how to enable the authentication again:

[ ] Disable the authentication.
[ ] Update the documentation explain the project death.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.


Search

We need to bring  back search functionality. Should include suggested complete and should return a results page.
"Best would be to pick between name of projects, fiels, sited, concessions, contracts, countries, companies, company groups. Can be project name only (or project and country), if speed is an issue."

The search bar is awesome!


WIP:Adding Expandable Observe

Adding code to refresh the height of the Expandable on DOM insertion/deletion. Also fixed some minor bugs so I could test on IE9/Firefox.
Having written this I believe I took the wrong approach. @ans, how would you feel about exploring using css to handle showing/hiding the m-expandable_content instead of Javascript? This would probably involve using margin-top  instead of setting the height.
Testing

Visit  http://localhost:8000/document-detail/.

Review
Notes
Firefox just recently added innerText and its better to use textContent per https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent. Of course this won't work in IE8 which I'm happy about.
We should also consider throttling or debouncing _refreshHeight  to prevent costly reflows caused by accessing offsetHeight.

@anselmbradford
@KimberlyMunoz
@jimmynotjim

Screenshots

Having written this I believe I took the wrong approach. @ans, how would you feel about exploring using css to handle showing/hiding the m-expandable_content instead of Javascript?

Sounds like a good idea. What change do you see for this? Currently almost all of the showing/hiding is handled by CSS. The JS adds/removes a CSS class that expands/collapses the content, though the height is calculated in JS and applied directly via inline styles.

So I think it would work by using margin-top: -100% to hide and margin-top: 0 to show the content.   This way the height would always be calculated automatically by it's contents and you could still use an animation to hide/show the content.

So I think it would work by using margin-top: -100% to hide and margin-top: 0 to show the content. This way the height would always be calculated automatically by it's contents and you could still use an animation to hide/show the content.

Sounds great if that'll do it! It could be added to the __expanded modifier class.

@anselmbradford , so margin-top will work but you still need to calculate the height to determine the duration. I'm not sure how to get around that so I think I'm going to go with that approach to now (unless you see a way to avoid doing that).

Sounds good :+1: Maybe something with animating max-height could be tried. Cursory look turned up this http://stackoverflow.com/questions/3508605/how-can-i-transition-height-0-to-height-auto-using-css

Hey what about using translateY within an overflow: hidden; area?

I tried the translate with overflow route with the original refactor of the menu, but ran into the same issues you're discussing. Using height and calculating/writing that and the speed in JS, but letting the CSS transition handle the actual animation is most likely going to give us the best of both rendering performance and the extensibility.


Implement checkbox

I appreciate the PR, but I think we already had that: https://github.com/patternfly-yew/patternfly-yew/blob/main/src/components/form/check.rs

Oh dear, I kept searching for "Checkbox" and was coming up empty :sweat_smile:
I guess my implementation has a few more features so we can merge most of it without problems.
However there are some breaking changes:

Checkboxes have the indeterminate state, so bool isn't sufficient
Supply the Event as an argument to the onchange callback
The id is mandatory so we can use for={props.id} on the label for accessibility (also how it is done in patternfly-react)

Yea, I guess it makes sense to amend the current component. I would appreciate it, if we could stick to function components, unless necessary.

stick to function components, unless necessary

Agreed, it's necessary here unfortunately because the indeterminate state can't be set via HTML but instead needs to be set via the node ref when the component is mounted.
The render method of the structural component allows this.
A lot of boilerplate for three lines of code :/

Can't you use a combination of https://docs.rs/yew/latest/yew/functional/fn.use_node_ref.html and https://docs.rs/yew/latest/yew/functional/fn.use_effect.html …
use_effect to execute when mounted and use_noderef for the NodeRef.

Cool. Can get a mix of both the existing and the new one?

Here's the new version.

I removed the children prop in favour of label + body
The id is being handled as in the old version (not mandatory)

I'm also partial towards naming the component "Checkbox" instead of "Check" to have it more in line with the React version but I've kept it as "Check" for now since that's how it's already implemented.

I think it's ok to rename it. Not sure if we can use a pub type Check = Checkbox in combination with #[deprecated]. But having a breaking change before the final release would be ok for me.
I would also rename the properties to *Properties (instead of *Props, I know it was there before, but do prefer it now).
In any case, I think it's good to be merged. So let me know when you're done and I will press the button.

I think it's ok to rename it. Not sure if we can use a pub type Check = Checkbox in combination with #[deprecated]. But having a breaking change before the final release would be ok for me.

Works :smiley:

I would also rename the properties *Properties

Done.
I also renamed the file to reflect the name of the component.

I would say it's ready.

@aDogCalledSpot I hope you don't mind … but I did revert adding the Event parameter to the callback. It let to a number of quite verbose changes. I am open to adding it, maybe we can find a better way.

I don't mind too much since it isn't something I need at the moment. I just thought it would be potentially be useful to a user and it wasn't difficult to implement. Tracking it in the separate issue seems like the right call for now 👍


append to body mode

If the search field is within an overflow element (like <div style="overflow: hidden">), you can already append the suggestion menu to another DOM element.
$('.typeahead').typeahead({
  // ...
  menu: $('div-on-body')
}, /* dataset */);

In order to position the suggestion menu under the search field, you must do the calculations for top, left and width by yourself.
Wouldn't it be great if there is an "append-to-body" mode that makes these calculations for you?

I'm a bit confused as to why you want to append the suggestion menu to another DOM element (besides the input text field). Can you give an example or use case where this would be necessary?

My problem is this: https://jsfiddle.net/ezuy4wg9/1/
The search field is within a 'th' tag. The 'th' tag has overflow: hidden.
But even if I am able to remove the overflow: hidden from the 'th' tag there is a overflow: auto on .tobago-sheet-body.
The overflow: auto create a scrollbar if the suggestion result is too long.
What I want is this: https://jsfiddle.net/hfkfj8cs/1/
Here I have added the suggestion result to the $(div-on-body).
The positioning is done by:
$('#the-basics .typeahead').bind('typeahead:open', function() {
  var $input = jQuery(this);
  var $suggestPopup = jQuery(".div-on-body");
  $suggestPopup.css("top", $input.offset().top + $input.outerHeight() + "px");
  $suggestPopup.css("left", $input.offset().left + "px");
  $suggestPopup.css("min-width", $input.outerWidth() + "px");
});

What I mean with the "append-to-body" mode is:
You write
$('.typeahead').typeahead({
  // ...
  appendToBody: true
}, /* dataset */);

and typeahead.js create the "div-on-body" element and append the suggestion results on that.
Also typeahead.js do the positioning of the results.

Putting the search field inside a th tag is a little odd, but I suppose technically allowable.
I don't think doing the fixed positioning calculations is a robust way of laying out the suggestion list. It may work here, but I bet we'd quickly run into inconsistencies with other markup and browsers.
Also, the div-on-body classname would need to be customizable, as that may conflict. It also breaks the "contract" that typeahead has, in that it is attached to text field and handles all its own markup from there.
Since this is outside the typical use case, I think keeping your workaround is probably best rather than adding complexity. Perhaps try adding the fixed position styles with the tt-menu class instead?

Positioning the popup in the open event won't work properly because the event fires before suggestion rendering takes place (at least in my scenario where i use a remote dataset).
By using the render event and jQuery UI position it seems to work flawlessly even when the site shifts content around as the position plugin takes care of that too:
// using render event instead of open as open fires before suggestions are rendered resulting
// in invalid menu dimenions being used in position calculation, bug?!?
$input.bind("typeahead:render", function() {
  $menu.position({
    my: "left top",
    at: "left bottom",
    of: $input,
    collision: "flipfit"
  });


Fix Pressing enter while on settings takes the user back to home

Pressing Enter on Settings, Administration and Subscriptions will no longer bring user back to Home.
Please review my PR.
Thanks!

Automated message from Dropbox CLA bot
@khantaalaman, it looks like you've already signed the Dropbox CLA. Thanks!


Link Expiry

This PR closes #9 by providing the option to set an expiration time for links. You can globally set the expiry in the config or set it on a link.
Expire the link after 10 minutes:
{{ zip:images expiry="10" }}

config/zipper.php
Instructions say to set minutes here but this is a boolean field that should be true or false and left to the antlers tag to discern time.
With config set to null, links never expire. With config set to 1 - links expire in one minute, and with config set to true and {{ expiry="1" }} links expire in one minute.
This however does not rename the next action link - so if you want to re use the same download button for a second user, the link expiry is across the entire system - link expiry plus renaming the next action URL is the intended use case for our system.

Actually, with a combination of adding a datetime-string to the download filename, and the link expiry, i think this will now work as we want it to!
thank you!

You don't have to use the expiry in the config if you don't want to. Just leave it at null or 0 and use the expiry on the tag. The config option is simply there to provide a global expiry in case someone wants this.
I don't understand what you mean by "This however does not rename the next action link". The link changes on every reload of the page. That's how the underlying cipher works. So you should have unique links on every reload. And the way link expiration works is by using Laravel's signed routes. The signature in each link will be checked, and if it is expired, it will throw an error.

i must have been confused and misunderstood the code/ docs - but its not an issue since the change actually does work as intended. Disregard former comment


Replace MouseTrap usage with built in Stimulus keyboard support

Fixes #10167
Adds Mousetrap via npm package
Uses hotwired/stimulus Controller to allow Mousetrap to bind certain key events on elements.

In the issue it's given:
Create a new controller KeyboardController which would have the identifier w-keyboard.
But in the code sample given in it, the identifier used is w-kbd.
/**
 * Adds the ability for an element to to be triggered by a keyboard shortcut.
 *
 * @example
 * ```html
 * <button data-controller="w-kbd" data-w-kbd-key="a">Activate me with <kbd>a</kbd></button>
 * ```
 *
 * @example
 * ```html
 * <button data-controller="w-kbd" data-keyboard-key="mod+p">
 *   Trigger with <kbd>Command ⌘</kbd> + <kbd>p</kbd> on macOS or <kbd>Ctrl</kbd> + <kbd>p</kbd> on Windows
 * </button>
 * ```
 */

Based on what I understood from stimulus docs, the identifier should be related to the controller file name

So should the filename be w_kbd_controller.ts or w_keyboard_controller.ts? I might be misinterpreting something because I'm still getting used to it.

Let's call the controller KeyboardController and the identifier w-kbd.

Thanks @NXPY123 for getting this started, just add a comment when you'd like some more detailed feedback or are stuck as to what to do next.
I've added a few comments about naming, thanks again for taking the time to contribute.

I added a KeyboardController.test.js but for some reason the controller won't click the button when the keyDownEvent is dispatched. I created a KeyboardController.stories.js and it seems to work when I test that (It logs in the console whenever I press the hotkeys).

Thank you for all the help! I think you've made more changes than me here 😅
I have a few doubts regarding the code which I haven't understood completely:

In initalize() of the KeyboardController class, why are we binding this to this.handleKey? Shouldn't its this property be set to the object by default?

In KeyboardController.test.js the simulateKey function you wrote appears to dispatch all three events(keydown,keypress,keyup) when it's called. Does Mousetrap register a press as all three events combined in a sequence?

Thank you for taking the time to go through them!

I was going through the docs and came across this:

If you bind the same key event later on in your script it should overwrite the original callback you had specified.

So if someone created a script and created two separate elements that had the same key-value, only the last element to be bound will be clicked. Wouldn't this be a potential bug that won't be caught because the person who wrote the script wouldn't realize the same hotkeys are being used again? Is this something worth looking into?

@NXPY123 great thinking here, I would say we can probably ignore that for now.
I'm not use that Mousetrap makes it easy to list all registered keys, I could not see this in the docs. If not we would have to track what's registered, then maybe show a warning in the console etc.
I'd say it's a future enhancement when we start to expose this to developers in the docs. It's also a reasonable use case to override a Wagtail shortcut with something else.
Lots to consider, maybe add a JSDoc about this.

I don't know why but this.keyValue is throwing an error:
error TS2339: Property 'keyValue' does not exist on type 'KeyboardController'.

It's consistent with what the docs said and I can't find any version issues with the package that might cause this either. It also seems to work on Storybook so I assume it has to do something with the Controller being initialized during a test?

I've added a test for aria-keyshortcuts. For some reason it fails on this:
expect(buttonClickMock.mock.contexts).toEqual([
        document.getElementById('btn'),
      ]);

It works when I remove it. Is there a reason for this?

I've added a test for aria-keyshortcut.

Are there any other tests that would be helpful?

I think the next thing to do is to ensure this works with manual testing for the actual two shortcuts that exist today using Mousetrap.
See https://github.com/wagtail/wagtail/blob/main/client/src/entrypoints/admin/page-editor.js
We should be able to remove all the Mousetrap code there and now use the new data attributes approach on the save and preview buttons.
The side panel toggle button html is here - https://github.com/wagtail/wagtail/blob/main/wagtail/admin/templates/wagtailadmin/shared/side_panel_toggle.html
The save button html is here - https://github.com/wagtail/wagtail/blob/73d4b8383c4b665f2aa3648cc61d40d5ecd9fd34/wagtail/admin/templates/wagtailadmin/pages/action_menu/save_draft.html#L4
However, there are actually lots of action-save usages, my guess is we would at least want to cover a few others like saving snippets.
See the search results. https://github.com/search?q=repo%3Awagtail%2Fwagtail action-save&type=code

I reverted the changes because most of them fail Django tests:
FAIL: test_workflow_action_menu_items_when_reverting (wagtail.admin.tests.test_workflows.TestSubmitSnippetToWorkflow)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/circleci/project/wagtail/admin/tests/test_workflows.py", line 1526, in test_workflow_action_menu_items_when_reverting
    self.assertContains(
  File "/home/circleci/project/.venv/lib/python3.8/site-packages/django/test/testcases.py", line 660, in assertContains
    self.assertTrue(
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 765, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Couldn't find '<button type="submit" class="button action-save warning" disabled>' in response

======================================================================
FAIL: test_workflow_action_menu_items (wagtail.admin.tests.test_workflows.TestSubmitPageToWorkflow)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/circleci/project/wagtail/admin/tests/test_workflows.py", line 1447, in test_workflow_action_menu_items
    self.assertContains(
  File "/home/circleci/project/.venv/lib/python3.8/site-packages/django/test/testcases.py", line 660, in assertContains
    self.assertTrue(
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 765, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Couldn't find '<button type="submit" class="button action-save " disabled>' in response

======================================================================
FAIL: test_workflow_action_menu_items_when_reverting (wagtail.admin.tests.test_workflows.TestSubmitPageToWorkflow)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/home/circleci/project/wagtail/admin/tests/test_workflows.py", line 1526, in test_workflow_action_menu_items_when_reverting
    self.assertContains(
  File "/home/circleci/project/.venv/lib/python3.8/site-packages/django/test/testcases.py", line 660, in assertContains
    self.assertTrue(
  File "/home/circleci/.pyenv/versions/3.8.11/lib/python3.8/unittest/case.py", line 765, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Couldn't find '<button type="submit" class="button action-save warning" disabled>' in response

Is it okay if I change the Django tests so they'll pass the changes?

Yep @NXPY123 you'll need to keep the html changes you had and then update the unit tests with this new behaviour.
I don't think we need the keyboard shortcut on the disabled button (when page is locked) though.

I think the changes work fine now 🙌

Great. If you're up for removing the vendor code and import, then mark this PR as ready.

Remove the initKeyboardShortcuts function from https://github.com/wagtail/wagtail/blob/57d23ad38d8095647b3964a28ed33c00499f4091/client/src/entrypoints/admin/page-editor.js#L8
Remove the vendor import script from https://github.com/wagtail/wagtail/blob/57d23ad38d8095647b3964a28ed33c00499f4091/wagtail/admin/templates/wagtailadmin/pages/_editor_js.html#L9
Remove the vendor file https://github.com/wagtail/wagtail/blob/main/wagtail/admin/static_src/wagtailadmin/js/vendor/mousetrap.min.js

After all that, be sure to do a bit more manual testing.

I tested the save on Edit Page, Edit People Snippets, Edit Footer Text, Editing and Adding Workflows Setting and Editing Workflows Tasks. It works on all of them.

Thanks again @NXPY123 - let us know if you are keen on doing a bit more keyboard shortcuts stuff. See comment https://github.com/wagtail/wagtail/issues/3949#issuecomment-2041599323


[EL-798] Pre fill CW2 IMM form

Jira ticket
What changed and why
We need to pre-fill CW forms to make things easier for case workers. This PR adds the CW2 IMM form and relevant mapping file.
Guidance to review
Sense check the fields are correct, test the export. I didn't use the conditional skip_if SMOD boolean methods in this form as this form doesn't ask about SMOD assets - but there might be a case for having them in the cw2.yml doc. I can add them in if we feel they are needed. My thinking was the case worker should only select the CW2IMM form if there is no SMOD - so we don't need to worry about checking for it. But I could be wrong!
I'd like to write a few more tests as well so will continue to work on that.
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing
Branch is generally up to date with main Github - definitely no conflicts
No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
PR description says what changed and why, with a link to the JIRA story.
Diff has been checked for unexpected changes being included.
Commit messages say why the change was made.

@patrick-laa thanks for your feedback! Makes sense. I'll decouple from the forms and do the checks based on whether we want smod or not (or if we are smod agnostic) and then those specific methods can be used in the relevant form. I'll set the modifier in an initialiser and hopefully making those changes will address your comments. Hopefully getting my head round this finally.


DeviceFinder Helper Photon Networking  Instantiate issues

So with a multiplayer game I was having issues with how DeviceFinder leverages FindObjectOfType  especially using the VRTK_PlayerPresence script.  It would grab all disabled components as well.  Player 2's presences was always thrown out of wack.  It was locating 2 instances of the headsets, and not sure how to adjust the floor for it.
My quick fix was to change in VRTK _PlayerPresences to GetComponentInChildren on line 31, instead of leverage DeviceFinder.
I would suggest moving the DeviceFinder to leverage GetComponentInChildren, instead of FindObjectOfType which is scene wide.

Ok thanks, I'll look into how this is working.
Perhaps it should only find enabled instances.

@thestonefox yeah I think that would work.  Though I didn't go crazy into reviewing devicefinder.   It would be nice if you could pass the parent somehow that way you know its only looking in that instance of the camera rig.

Non-related to the toolkit directly, but might be good to exchange ideas about design. (I just started working with photon two weeks ago, so I trying to learn more)
Wouldn't it be better to destroy every VRTK and SteamVR components for non-local player? (instead of disabling them)
I think it would avoid this type of problem. Then all non-local player variables would be synchronized using photon view.
If needed to find who owns the script, the workaround I'm using checking the owner of the PhotonView on the [CameraRig], something like
myScript.transform.root.GetComponent().IsMine or .ownerID.

@thacio you could do that.   I was just trying to leverage one asset,  so it enables disables what it doesn't need.   It starts off as all items are disabled,   I'm guessing the way I did it wasn't the best,  this was my first attempt at photon and VR as well.


Select Component hardcoded minimum of 5 options

When calculating the start and end position for rendering the minimum number of options is hardcoded to 5. By using the number of options as the limit the select component will be able to render any number of options. ie:
instead of
 int start = currentIndex - 2 >= 0 ? currentIndex - 2 : 0;
      if (currentIndex >= filteredArr.length - 2) {
        start = filteredArr.length - 5;
      }
      int end = start + 5 <= filteredArr.length ? start + 5 : filteredArr.length;

replace the hardcoded 5 with
int start = currentIndex - 2 >= 0 ? currentIndex - 2 : 0;
      if (currentIndex >= filteredArr.length - 2) {
        start = filteredArr.length - options.length;
      }
      int end = start + options.length <= filteredArr.length
          ? start +options.length
          : filteredArr.length;

Hello @trevorplant, thank you very much for your feedback, I've made some changes to the select component to incorporate your request while fixing a bug that was causing a throw.
I also took the opportunity to improve the readme, which was a bit old 👀
Thanks again and I look forward to seeing you 🙂


tutorial: add Mixins guide

This commit gives an introduction on the Mixins configuration management mechanism.
Signed-off-by: Tonny Tzeng<EMAIL_ADDRESS>Signed-off-by: Gnanasekaran, Sundar<EMAIL_ADDRESS>

@Doug, this is a new article needs your help to review and polish. Thanks.

@sgnanase please help to review the content. Thanks.


feat: add MakeCallTx, SignTx and BroadcastTxCommit in GnoNativeApi

This PR adds MakeCallTx, SignTx and BroadcastTxCommit in GnoNativeApi. So the front can directly calls these methods now.
This PR also cleans the GnoNativeApi files, mostly by removing unnecessary await keywords.

I added @iuricmp also to review the typescript part.

Be careful coercing values back and forth, however, as the precision of a BigInt value may be lost when it is coerced to a Number value

We are using small numbers, so it shouldn't be a problem. But to be safe we can use bigint literals, for example to change this literal to:
const gasWanted = 2000000n;


Permssion denied when updating the license

Installing the plugin works using the same credentials
pluploader --base-url http://$HOST --user admin --password admin -f plugins/confluence/target/confluence-7.0.0.obr --reinstall

Also getting the license works
but updating the license via
pluploader --base-url http://confluence.lan --user admin --password admin license info $PLUGIN_KEY

fail with
[15:48:58] ERROR    An error occured - check your credentials
           ERROR    (404, b'')

As discussed on slack, the issue was a wrong $PLUGIN_KEY.

Sorry, layer 8 mistake. I used de.myapp.app-key as the plugin key, as it is required in the rest API, but plupload wraps that and de.myapp.app is the correct key. My bad. Thank you for the help!


[0.48] Commits to cherry-pick into stable release

Broken commit: https://github.com/facebook/react-native/commit/712b1dd20ab0de73594696103b73c461c2c97076
node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedModule.h:14:9: 'React/RCTUIManagerObserverCoordinator.h' file not found

    "react": "^16.0.0-alpha.12",
    "react-native": "0.47.1",

node_modules/react-native/Libraries/Text/RCTTextFieldManager.m:14:9: 'React/RCTShadowView+Layout.h' file not found

@iegik you sure about that one? In order to release a beta, I had to compile it. That looks like a compile-time issue that I didn't encounter. Have you managed to resolve it in the meantime?

Checkout also https://github.com/facebook/react-native/pull/15365#issuecomment-320955151

I'm definitely not sure about that, but then I try to build the application, i felt in a lot of errors. Tried to clean, install again and again. No luck.

This https://github.com/facebook/react-native/commit/c9aeaf675dcf0292d148950d0fb020eeb13d3af1 would be great to get in if possible.

I'd like to nominate 603cc48ceba001827d10231d51b4031c7768eef8, as described in this comment: https://github.com/facebook/react-native/commit/603cc48ceba001827d10231d51b4031c7768eef8#commitcomment-23539206

While not exactly critical would be really nice to get HMR to work across all connected clients simultaneously - I believe https://github.com/facebook/react-native/commit/8b2975ad7b27ce34dcf56836685fd54ddd62086c sorts this out. Nice incremental improvement to everybody's workflow. :)

@eliperkins 603cc48ceba001827d10231d51b4031c7768eef8 is already in the rc version. I have cherry-picked the rest and sent out a new build to Circle.
@ajostergaard I am going to wait with the HMR one for few more days to let it settle in the master branch.

@grabbou Ah! My mistake, I meant 603cc48ceba001827d10231d51b4031c7768eef8 into 0.47.0, not 0.48.0. 😬
Due to the changes made in a8c45ac1c38866df222434b2d99d2a18b908c45f, content size on TextInput is currently broken, without cherry-picking 603cc48ceba001827d10231d51b4031c7768eef8. This seems like a pretty serious regression that deserves a patch, especially since we know how to fix it, and the fix is in the next monthly release as well.
Are patches still being made to 0.47.0? I didn't see another issue similar to this one for 0.47.0. I can open another ticket and nominate that cherry-pick if you'd like to keep the chatter out of this one.

Here's the current status of things:

rc.1 contains:

cb1b1e58b372bea23a2302db2f4c0eba85b4a17a (Fixes unintended side effects caused by #14684 for SwipeableRow)
c9aeaf675dcf0292d148950d0fb020eeb13d3af1 (Separate window dimensions change from orientation)

HEAD (will go out with rc.2) contains:

ef23d2bdcff66897c5746d9ad5f043b2900d00fb (Show bundle download progress on iOS)

The HMR fix is sitting in master and either way it will go out with 0.49.0-rc.0.
The rest of the discussions looked unrelated to cherry picks for 0.48.

Thanks @ide for the summary! @eliperkins in order to suggest a patch to 0.47, please post in #14840

Hi, maintainers!
Would it be possible to include flow 0.53 in the next release?
(commit #90eaeb019b2056150cae541a59720daad21466ef)

I am not really sure it's needed. Cherry-picks are meant to be used when we fix issues that got fixed in master in the meantime. Features and improvements can usually wait for the next release (0.49). For historical reasons, I am against importing anything related to flow as it touches many files across the project and has high potential of breaking.
Anyways, for now I am closing this as release is being promoted to stable.

Where's the 0.48 changelog?

Will be published shortly on releases tab.
On Fri, 1 Sep 2017, 23:05 Gary Fung<EMAIL_ADDRESS>wrote:

Where's the 0.48 changelog?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15318#issuecomment-326683312,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxuZs28_8Q8bxur7uSJW1FIEm-Cd_ks5seHGQgaJpZM4OqIde
.

One of the commits by @janicduplessis was reverted as it caused iOS to crash. Fix has been submitted and is already in 0.49 - we need to cherry-pick that one later this week.

Adding an Android scroll view fix (e964a7f4ef93fcadf5cfd1c269b77b13cb3be374) and iOS font fix (d3007b0fd268c0d69f92) to 0.48-stable and releasing as 0.48.2. The files that both commits touch haven't had any other changes to them since 0.48-stable.
Also cherry-picking these into 0.49-stable so that we don't regress from 0.48 to 0.49 and am releasing an 0.49 RC (will cross-post in the 0.49 cherry-pick issue so we don't miss this).

Cherry-picked two bridge-related fixes for reloading C++ bridge (https://github.com/facebook/react-native/commit/1f9fc0ee3a2964b067f0848e35603475e510067c#diff-a2a67635fffd7b690d14dc17ae563a71 and https://github.com/facebook/react-native/commit/7b770556ac6eb60094bdf59bfd14876b6e2a1307). CI is publishing 0.48.3.

https://github.com/facebook/react-native/releases/tag/v0.48.3 is up but not on npm? At least not to yarn outdated

0.48.3 build has finished, please double check. Chances are you might have been looking before it finished.

Ya I guess it took an hour or so for npm to pick up the new release? But it came on yarn, thanks

Cherry-picked a fix for Jest tests into 0.48.4:

Add BlobModule native module mock to jest setup: https://github.com/facebook/react-native/commit/165f87673002dec640fe86486296cd0d0847b333

I have scheduled the build once again. I believe it should land on npm this time.

Nope, still nothing.
Shouldn't this sort of thing be scripted?

It is scripted but the CI pipeline failed.

And still failing. Not on npm

Any update on when the releases train for bug fixes will be fixed?

We are aware of the bug and working on a fix. We managed to get last build
green, but the publish npm step failed. So getting closer. I will update
this issue and post on Twitter once it's up. Apologies for the delays
around it, but build issues are the worst (it involves many devs across
teams to fix the issue)
On Fri, 22 Sep 2017, 20:34 Gary Fung<EMAIL_ADDRESS>wrote:

Any update on when the releases train for bug fixes will be fixed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/issues/15318#issuecomment-331526616,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxsUh72K-1kqM9iSrZ60Nc8DNKmObks5sk_2zgaJpZM4OqIde
.

Looks like it's fixed? 0.48.4 was on npm


hasNumberOfDistinctValues and hasHistogramValues require arguments that should be optional?

Describe the bug
The docs and Scala code for hasNumberOfDistinctValues and hasHistogramValues  indicate that providing the binningUdf, maxBins parameters should be optional, but from the function definitions they seem to be required.
To Reproduce
Steps to reproduce the behavior:

Try to define a check with check.hasNumberOfDistinctValues('column_name', lambda x: x == 6)
See error: TypeError: hasNumberOfDistinctValues() missing 2 required positional arguments: 'binningUdf' and 'maxBins'

Expected behavior
I'd like to be able to call the hasNumberOfDistinctValues and hasHistogramValues without specifying a binning function and maxBins.

Even with these params defined as required, when it comes to binningUdf you could simply set it as None.
`python
check = Check(spark, CheckLevel.Warning, "test hasHistogramValues")
result = (VerificationSuite(spark).onData(df)
.addCheck(check
.hasHistogramValues("c_1",
lambda x: x.apply("66").absolute() > 4500000, None, 2)
.hasHistogramValues("c_2",
lambda x: x.apply("22").ratio() > 0.5, None, 2))
     ).run()

`

Thanks @brunoRenzo6, adding this to the method's docs could help.


Implement Colour4 interpolation function

Closes #4581
I implemented the Colour4 interpolation function, this does the same thing as Color4

I guess I don't see huge issues with this aside from the fact that contrary to everything else, ValueAt implementations for Colo(u)?r4 clamp to the interpolation range rather than everything else which accepts arbitrary t, but that's probably something to deal with/unify in https://github.com/ppy/osu-framework/issues/3974...


Language Strings extraction from blade files

Hi,
It would be nice to scan for language strings in blade files ex. __(), trans().
This would be better than only include the JSON lang files.
When needed, i can help with a script.

Hi @justie75, thank you for the suggestion! I understand the value of scanning language strings in Blade files, and it’s a great idea. But at the moment, implementing this feature is not in my immediate plans due to time constraints.
That said, please feel free to contribute to this feature if you’d like. I’d be happy to review and support any contributions you make


PyFerret window does not resize correctly at beginning of session

Reported by andrew wittenberg on 20 Mar 2014 21:42 UTC
The first resize of a window doesn't work correctly; we get gaps around the edges of the plot:
 	NOAA/PMEL TMAP
 	FERRET v6.861 (PyFerret 1.0.1)
 	Linux 2.6.32-431.1.2.el6.x86_64 - 03/13/14
 	20-Mar-14 17:33

yes? use coads_climatology
yes? shade/l=1 sst    ! plot1.gif
yes? set win/asp=.5   ! plot2.gif
yes? shade/l=1 sst    ! plot3.gif

Perhaps something in the graphics needs to be initialized, before the first "SET WINDOW" command is issued.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2155

Comment by karl.smith on 20 Mar 2014 22:04 UTC
Yep, seeing the same thing here.  The window is not getting fully refreshed after the resize.  The moment you start to resizing the window using the mouse with the window frame, however, the full plot shows up.  Saving the image with the FRAME Ferret command also shows the full image, so the full image is there; it is just the viewer is failing to show it all.
Repeated execution of
set window /asp=0.5
shade /l=1 sst
set window /asp=2.0
shade /l=1 sst

shows the problems after the /asp=0.5, but not after /asp=2.0.

Comment by andrew.wittenberg on 26 Mar 2014 13:18 UTC
This appears to be fixed in PyFerret 1.0.2 (3/21/14).  Can this ticket be closed?

Modified by karl.smith on 6 Oct 2014 18:18 UTC

Attachment from andrew.wittenberg on 20 Mar 2014 21:42 UTC
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2155_GIT_1427/plot1.gif

Attachment from andrew.wittenberg on 20 Mar 2014 21:42 UTC
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2155_GIT_1427/plot2.gif

Attachment from andrew.wittenberg on 20 Mar 2014 21:43 UTC
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_2155_GIT_1427/plot3.gif


Results are not displayed when user runs the query 2nd time.

Describe the bug
When user runs the query 1st time, the results are displayed. But when user runs the query 2nd time, the results are not displayed and loader keeps spinning.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://sql-editor-i8d6w7vvc-janvi01.vercel.app/'
Click on 'Run Query' button > Results would be displayed.
Click on 'Run Query' button again > This time, results are not displayed, but loader keeps spinning.

Expected behavior
Results should be displayed every time the query is run by user.
Screenshots
When user runs the query 1st time.

When user runs the query 2nd time.

Desktop
OS: Windows 10
Browse: Chrome, Edge, Mozilla
Chrome Version [118.0.5993.89]
Screen width: bug is reproducible when screen width > 1428px

Hey @Tajinder-Dhoot Thanks for opening the issue. Do you want to work on this?

Yes, I would like to - @janvi01

Hey @Tajinder-Dhoot Thanks for opening the issue. Do you want to work on this?

@janvi01 - can you please assign this to me?

assigned @Tajinder-Dhoot feel free to drop in any doubts.


Unable to set MultiAZWithStandbyEnabled in override

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
12.4.0
What operating system are you using?
MacOS Ventura
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made. We're running a multi-env setup so I'm trying to get everything configured dynamically through overrides.
Describe the bug
I'd like to setup Multi-AZ with Standby through an amplify override. As of now, I'm able to get about 90% of the way there.
Here's my current overrides.js file
import {
	AmplifyApiGraphQlResourceStackTemplate,
	AmplifyProjectInfo,
} from '@aws-amplify/cli-extensibility-helper';

const PROD_CONFIG = {
	instanceType: 'm5.large.elasticsearch',
	instanceCount: 3,
	zoneAwarenessEnabled: true,
	zoneAwarenessConfig: {
		availabilityZoneCount: 3,
	},
	dedicatedMasterEnabled: true,
	dedicatedMasterCount: 3,
	dedicatedMasterType: 'm5.large.elasticsearch',
	multiAzWithStandbyEnabled: true,  // <-- This is the important bit. The rest of the config deploys as expected
}
const DEV_CONFIG = {
	instanceType: 't3.small.elasticsearch',
	instanceCount: 1,
}

export function override(
	resources: AmplifyApiGraphQlResourceStackTemplate,
	amplifyProjectInfo: AmplifyProjectInfo
) {
	const osConfig = amplifyProjectInfo.envName === "PROD" ? PROD_CONFIG : DEV_CONFIG;
	const encryptAtRestEnabled = amplifyProjectInfo.envName === "PROD";

	resources.opensearch.OpenSearchDomain.elasticsearchVersion = 'OpenSearch_1.3';
	resources.opensearch.OpenSearchDomain.elasticsearchClusterConfig = {
		...resources.opensearch.OpenSearchDomain.elasticsearchClusterConfig,
		...osConfig
	};
	resources.opensearch.OpenSearchDomain.encryptionAtRestOptions = {
		...resources.opensearch.OpenSearchDomain.encryptionAtRestOptions,
		enabled: encryptAtRestEnabled,

	};
	resources.opensearch.OpenSearchStreamingLambdaFunction.runtime = "python3.9";
}

Expected behavior
I'm able to replicate most -if not all- of the same config that I can manually set through the AWS console; except this one property.
Reproduction steps

Run amplify override api
Add above config to project
Amplify push
Verify changes in AWS console

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hi @ykethan thanks for making the transfer. Any idea when I might hear back about this? We're shooting for SOC-II compliance and this config is critical for the audit.

The elasticSearch naming properties are expected as the current searchable in amplify does not fully migrate to the opensearch module yet, which still stays on the ElasticSearch 7.10. This results the different CfnDomain for elasticsearch and opensearch. As a consequence, the extensibility helper stays at the old APIs for elasticsearch to meet the current situtation.
This is a limitation for the current amplify overrides for elastic search to open search as the module is not fully migrated. This will be addressed once we finish the full migration from elastic search to opensearch.

@AaronZyLee any ideas for a workaround? We can set the property manually through the console, but it gets overwritten on amplify push.
Not ideal because SOC-II type-2 compliance requires the config be maintained for at least a year afaik.


Campaign | Icons: door icon

Approximate design from Lastenheft:

Prototype: https://www.figma.com/proto/7wE0Iveas3GGb8u4oL0714/App-Design-Mitglieder-App-(1)-(Copy)?node-id=2654-4866&t=b8swD5IOAFfZ0OSo-1

A definition of the icon and of the blue color is needed (HEX code). @leagerndt

Issue is reviewed.
Please use placeholder (icons and color) if necessary. Icons and hex-codes will be provided asap.
@nscharioth @leagerndt


7-zip does not store the owner/group of the file

7-zip is not designed for backups as it does not store owner and group data of files. tar should be used for packaging instead.
From 7-zip documentation:
    DO NOT USE the 7-zip format for backup purpose on Linux/Unix because :
    - 7-zip does not store the owner/group of the file.

   On Linux/Unix, in order to backup directories you must use tar :
    - to backup a directory  : tar cf - directory | 7za a -si directory.tar.7z
    - to restore your backup : 7za x -so directory.tar.7z | tar xf -

Resolved in 79455796cac02d6127a48362bc56fe61b3bfe02b. Input now tarred before being 7-zipped.


Add changeable Accuracy for crackshot

Build DEV-168+ has initial support for this! http://ci.citizensnpcs.co/job/Sentinel/
Sorry for taking so long to add this.