makeImageFromView not working properly if children have transparency.

Description
The makeImageFromView method, which is used to take snapshots of any view, does not properly handle child elements that have transparency. Instead of capturing the view with the intended transparent elements, it captures them as if they have an opacity value of 1.
Version
0.1.202
Steps to reproduce
Take snap of any view that has a child with transparency in it.
Or you can run below code.
Snack, code example, screenshot, or link to a repository
import {
  Canvas,
  Image,
  SkImage,
  makeImageFromView,
  rect,
} from '@shopify/react-native-skia';
import {useEffect, useRef, useState} from 'react';
import {StyleSheet, View} from 'react-native';

export default function F() {
  const viewRef = useRef<View>(null);

  const [image, setImage] = useState<SkImage | null>(null);

  const takeSnapshot = async () => {
    if (viewRef.current === null) {
      return;
    }
    const snapshot = await makeImageFromView(viewRef);
    setImage(snapshot);
  };

  useEffect(() => {
    setTimeout(() => {
      takeSnapshot();
    }, 500);
  }, []);

  return (
    <>
      <View ref={viewRef} style={styles.view}>
        <View style={styles.innerView} />
      </View>
      <Canvas style={styles.canvas}>
        {image && <Image image={image} rect={rect(0, 0, 100, 100)} />}
      </Canvas>
    </>
  );
}

const styles = StyleSheet.create({
  canvas: {
    flex: 1,
    backgroundColor: 'white',
  },
  view: {
    width: 100,
    height: 100,
    backgroundColor: 'green',
  },
  innerView: {
    width: 50,
    height: 50,
    backgroundColor: 'tomato',
    opacity: 0.5,
  },
});

We can confirm the issue; we will provide a fix for it, in the
meantime, you can add the opacity in the color and it will work as
expected.
for instance:
backgroundColor: 'tomato',
opacity: 0.5,
becomes:
backgroundColor: 'rgba(255, 99, 71, 0.5)',
On Thu, Aug 31, 2023 at 11:30 AM Laxman-stan @.***> wrote:

Description
The makeImageFromView method, which is used to take snapshots of any view, does not properly handle child elements that have transparency. Instead of capturing the view with the intended transparent elements, it captures them as if they have an opacity value of 1.
Version
0.1.202
Steps to reproduce
Take snap of any view that has a child with transparency in it.
Or you can run below code.
Snack, code example, screenshot, or link to a repository
import {
Canvas,
Image,
SkImage,
makeImageFromView,
rect,
} from @.***/react-native-skia';
import {useEffect, useRef, useState} from 'react';
import {StyleSheet, View} from 'react-native';
export default function F() {
const viewRef = useRef(null);
const [image, setImage] = useState<SkImage | null>(null);
const takeSnapshot = async () => {
console.error('taking the view-shot');
const snapshot = await makeImageFromView(viewRef);
setImage(snapshot);
};
useEffect(() => {
setTimeout(() => {
takeSnapshot();
}, 500);
}, []);
return (
<>

{image && <Image image={image} rect={rect(0, 0, 100, 100)} />}

</>
);
}
const styles = StyleSheet.create({
canvas: {
flex: 1,
backgroundColor: 'white',
},
view: {
width: 100,
height: 100,
backgroundColor: 'green',
},
innerView: {
width: 50,
height: 50,
backgroundColor: 'tomato',
opacity: 0.5,
},
});
—
Reply to this email directly, view it on GitHub or unsubscribe.
You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOS or Android.


Initialize effect

See the discussion here: https://github.com/isovector/polysemy/issues/70

Maybe this should just be an interpretation of Input?


Missing scope pass through in authentication form

In the Wiki, in Implementing-an-Authorization-Server-with-the-Auth-Code-Grant the get method and the authentication form should be updated to include the scope as otherwise when the access_token is generated the scope is lost and thus only the default scope configured in oauth2.php gets used. If scope is set to required and/or the default value is null errors happen.
My updated get method looks like
// display a form where the user can authorize the client to access it's data
$authParams = Authorizer::getAuthCodeRequestParams();
$formParams = array_except($authParams, 'client');
$formParams['client_id'] = $authParams['client']->getId();
$formParams['scope'] = implode(config('oauth2.scope_delimiter'), array_map(function ($scope) {
    return $scope->getId();
}, $authParams['scopes']));

return View::make('oauth.authorization-form', ['params' => $formParams, 'client' => $authParams['client']]);

accordingly I updated authorization-form.blade.php:
[...]
{!! Form::hidden('state', $params['state']) !!}
{!! Form::hidden('scope', $params['scope']) !!}
{!! Form::submit('Approve', ['name'=>'approve', 'value'=>1, 'class'=>'btn btn-success']) !!}
[...]

~Jan

Thx @joetjen! I would never have figured that out in a reasonable amount of time.
Should definitely be included!

@joetjen it would be awesome if you wanted to create a pull request for this!

https://github.com/lucadegasperi/oauth2-server-laravel/pull/621 Did as you asked.

@joetjen thanks!


Login dialog with Bootstrap look-and-feel.

Summary
Display the Login dialog to Marketplace with Bootstrap Look-and-feel.
Details
The login dialog is responsive and shown with a Bootstrap-look-and-feel.
Acceptance criteria

[ ] Manual tests
[ ] Resulting UI Screenshots
[ ] Test for Custom Color.

Additional context
N/A.


Column Families Doc Update

Re: Column Families
Issue Description

Column families reduce the number of keys stored in the key-value store, resulting in improved performance during INSERT, UPDATE, and DELETE operations.

Suggested Resolution
I believe that column families add the number of rows. By default all cols are in family primary. If I put some cols into a new family, so that my table has 2 families instead of just primary, I will have 2 rows for each key, one per family.

@rmloveland I think this falls under your product area but not sure. Feel free to reroute.

Hi @fabiog1901, thanks for filing an issue on the docs!
Looking at that page, the sentence just before that says

A column family is a group of columns in a table that are stored as a single key-value pair

However, you are saying that

I believe that column families add the number of rows.

Do you mean SQL rows?  Column families are an optimization to reduce the underlying keys used by the KV storage layer, not the number of rows (which is a SQL concept).


WIP Added Keycloak user creation

IMHO title should be updated to include removal of deprecated files (terraform, dbs)


Allow calendar events to be filtered

Remove the $id from each event before adding it:
https://github.com/mattlewis92/angular-bootstrap-calendar/blob/master/src/directives/mwlCalendar.js#L65

Already fixed


Fix ec2 scripts with new cli commands versions

Signed-off-by: Karoly Albert Szabo<EMAIL_ADDRESS>Description:

fix min amount of stakes
fix --moniker
fix tx send
fix wiring into AWS from https to http (not in GIT until we don't switch to SRE nodes)

Thank you! 🚀

For contributor:

[ ] Added entries in CHANGELOG.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer
[ ] Attach screenshots of the UI components on the PR description (if applicable)
[ ] Scope of work approved for big PRs

For reviewer:

[ ] Manually tested the changes on the UI

Thanks! yeah it was an explorative pattern :) i pushed the scripts that worked on our EC2 instances. I hopep


Remove unused dependencies from package.json

Avoids a confusing deprecation message related to grunt when running npm install.

What is the message?

Here it is:
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from grunt-contrib-uglify will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency<EMAIL_ADDRESS>included from grunt-contrib-less will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

Can you please re-submit this request against the develop branch?

Done. BTW your master contains a couple of commits not in develop, is that intentional?


Add dynamic window tiling like i3wm

Win-vind's current window control function seems to be effective only for a single window, adding a dynamic window tiling function like i3wm would be more efficient and convenient. For example, open a new window automatically tiled, when the left window becomes smaller, the right window automatically becomes larger, etc. Windows also has similar software can achieve such features such as workspacer, but workspacer is still very early, can only achieve a very limited function, you can use workspacer for some reference

That's a good idea. I'll try to implement it.
Thanks.


rPackages.rsbml: fix build

Description of changes
Packaged libSBML and added it as a buildInput for rsbml
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build rPackages.rsbml

Could someone check what's wrong with libsbml on darwin? @nviets  @philipp-baumann

on aarch64-darwin, I get
➜ nix-shell -p R rPackages.rsbml
this derivation will be built:
  /nix/store/dzcyav42gghmll5r0wmq41xf7n005vd6-r-rsbml-2.60.0.drv
building '/nix/store/dzcyav42gghmll5r0wmq41xf7n005vd6-r-rsbml-2.60.0.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/dbk270nm37zyzhvp35vp6n3746ilvzsx-rsbml_2.60.0.tar.gz
source root is rsbml
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file rsbml/inst/SBML_odeSolver-1.7.0beta/src/sbmlsolver/ASTCompiler/Makefile
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./inst/SBML_odeSolver-1.7.0beta/config/config.sub
Updating Autotools / GNU config script to a newer upstream version: ./inst/SBML_odeSolver-1.7.0beta/config/config.guess
Running phase: configurePhase
Running phase: buildPhase
Running phase: checkPhase
Running phase: installPhase
During startup - Warning messages:
1: Setting LC_CTYPE failed, using "C"
2: Setting LC_TIME failed, using "C"
3: Setting LC_MESSAGES failed, using "C"
4: Setting LC_MONETARY failed, using "C"
* installing *source* package 'rsbml' ...
** using staged installation
checking for pkg-config... no
checking for LIBSBML... no
configure: error: in `/private/tmp/nix-build-r-rsbml-2.60.0.drv-0/rsbml':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you may set the environment variables LIBSBML_CFLAGS
and LIBSBML_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
See `config.log' for more details
ERROR: configuration failed for package 'rsbml'
* removing '/nix/store/8fxzn1skq4kklqisrfj8c4kb20skwhkr-r-rsbml-2.60.0/library/rsbml'
error: builder for '/nix/store/dzcyav42gghmll5r0wmq41xf7n005vd6-r-rsbml-2.60.0.drv' failed with exit code 1;
       last 10 log lines:
       > path to pkg-config.
       >
       > Alternatively, you may set the environment variables LIBSBML_CFLAGS
       > and LIBSBML_LIBS to avoid the need to call pkg-config.
       > See the pkg-config man page for more details.
       >
       > To get pkg-config, see <http://pkg-config.freedesktop.org/>.
       > See `config.log' for more details
       > ERROR: configuration failed for package 'rsbml'
       > * removing '/nix/store/8fxzn1skq4kklqisrfj8c4kb20skwhkr-r-rsbml-2.60.0/library/rsbml'
       For full logs, run 'nix log /nix/store/dzcyav42gghmll5r0wmq41xf7n005vd6-r-rsbml-2.60.0.drv'.

Could someone check what's wrong with libsbml on darwin? @nviets @philipp-baumann

for libsbml. does it need a callPackage approach?
nixpkgs on  fix_rsbml [$?]
➜ nix-shell -p libsbml
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'shell'
         whose name attribute is located at /nix/store/6nnv8z57j976ij3img6ni46fkbac9vb0-nixpkgs/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute '__impureHostDeps' of derivation 'shell'

         at /nix/store/6nnv8z57j976ij3img6ni46fkbac9vb0-nixpkgs/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:443:7:

          442|       __propagatedSandboxProfile = unique (computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile ]);
          443|       __impureHostDeps = computedImpureHostDeps ++ computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps ++ __impureHostDeps ++ stdenv.__extraImpureHostDeps ++ [
             |       ^
          444|         "/dev/zero"

       error: undefined variable 'libsbml'

       at «string»:1:107:

            1| {...}@args: with import <nixpkgs> args; (pkgs.runCommandCC or pkgs.runCommand) "shell" { buildInputs = [ (libsbml) ]; } ""
             |

For libsbml, i get this on aarch64-darwin:
-- The C compiler identification is Clang 16.0.6
-- The CXX compiler identification is Clang 16.0.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/v4p0piwwk3a9gwrhvxa8b04ljd1arviz-clang-wrapper-16.0.6/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/v4p0piwwk3a9gwrhvxa8b04ljd1arviz-clang-wrapper-16.0.6/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: /nix/store/v4p0piwwk3a9gwrhvxa8b04ljd1arviz-clang-wrapper-16.0.6/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found SWIG: /nix/store/ada41dic6af4bkkpa1f7178jm7a418bh-swig-3.0.12/bin/swig (found version "3.0.12")
-- Found PkgConfig: /nix/store/3l8pzzkvvihqj5z1bymn5zcsm1a3gmp9-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
-- Looking for sin in m
-- Looking for sin in m - found
-- Performing Test LIBXML_LIBXML_TEST
-- Performing Test LIBXML_LIBXML_TEST - Failed
-- LIBXML_LIBXML_TEST =
-- Performing Test LIBXML_LIBXML_TEST2
-- Performing Test LIBXML_LIBXML_TEST2 - Failed
-- LIBXML_LIBXML_TEST2 =
CMake Error at CMakeModules/FindLIBXML.cmake:142 (message):
  Unable to compile a test executable against LIBXML

      LIBXML_INCLUDE_DIR = /nix/store/1fzfrlh08afwsc5dr40bmr1cra1y6kx6-libxml2-2.12.6-dev/include/libxml2
      LIBXML_LIBRARY     = /nix/store/69p1zrdp1648ls30sn21v99v8bwapv5c-libxml2-2.12.6/lib/libxml2.so

Call Stack (most recent call first):
  CMakeLists.txt:446 (find_package)

-- Configuring incomplete, errors occurred!
error: builder for '/nix/store/wm00m4scqnlk8yvjs62z3jf9dg027g0b-libsbml-5.20.2.drv' failed with exit code 1;
       last 10 log lines:
       >       LIBXML_LIBRARY     = /nix/store/69p1zrdp1648ls30sn21v99v8bwapv5c-libxml2-2.12.6/lib/libxml2.so
       >
       >
       >
       >
       > Call Stack (most recent call first):
       >   CMakeLists.txt:446 (find_package)
       >
       >
       > -- Configuring incomplete, errors occurred!
       For full logs, run 'nix log /nix/store/wm00m4scqnlk8yvjs62z3jf9dg027g0b-libsbml-5.20.2.drv'.

Thanks for testing, I saw the same error from ofborg, but the logs don't tell me what's missing on darwin. The xml tests run fine on linux.  Any clue?

Thanks for testing, I saw the same error from ofborg, but the logs don't tell me what's missing on darwin. The xml tests run fine on linux. Any clue?

They say the darwin binaries are  built with the Apple-supplied version of the http://www.xmlsoft.org parser library,
see: https://sourceforge.net/projects/sbml/files/libsbml/5.19.0/stable/Mac OS X/
could this be it?

Ah, good catch! But thats not the case on nix, we use thr same xml lib as in linux. Maybe there's something in the test code that expects the apple lib on darwin.

Ah, good catch! But thats not the case on nix, we use thr same xml lib as in linux. Maybe there's something in the test code that expects the apple lib on darwin.

yes it seems in test code:

Ah, good catch! But thats not the case on nix, we use thr same xml lib as in linux. Maybe there's something in the test code that expects the apple lib on darwin.

seems to happen here according to the logs: https://github.com/sbmlteam/libsbml/blob/ec444e9eab9a94ca84d23efbc0394db69536beca/CMakeModules/FindLIBXML.cmake#L137C1-L142

OK, let's try again with static xml lib on darwin. Fingers crossed.
@ofborg build rPackages.rsbml

Meh, static xml didn't help the darwin build :-/ why do those tests fail on darwin, and not on linux?

Guys, I don't think I can do much more for the darwin build, inless someone with hardware can help out. But at least it's a partial fix for linux. We can extend to darwin later. Can we go ahead and merge this? Should I change meta.platforms to linux only?

Guys, I don't think I can do much more for the darwin build, inless someone with hardware can help out. But at least it's a partial fix for linux. We can extend to darwin later. Can we go ahead and merge this? Should I change meta.platforms to linux only?

Sounds ok to me. I currently don't have the time to try-error dig into patching cmake config for darwin build, to not block things further i think its ok to merge from my side and extend to darwin later.

@ofborg build rPackages.rsbml

@ofborg build rPackages.rsbml

@ofborg build rPackages.rsbml

Thanks for the tip, @jbedo , that worked! After ofborg built it on x86_64-darwin, I rebased the changes, so now we have just the two commits. Cheers!


Consumer control msg {:type :exception, :exception #error {
 :cause nil
 :via
 [{:type org.apache.kafka.common.errors.WakeupException
   :message nil
   :at [org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient clientPoll ConsumerNetworkClient.java 324]}]
 :trace
 [[org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient clientPoll ConsumerNetworkClient.java 324]
  [org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient poll ConsumerNetworkClient.java 213]
  [org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient poll ConsumerNetworkClient.java 193]
  [org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient poll ConsumerNetworkClient.java 163]
  [org.apache.kafka.clients.consumer.internals.ConsumerCoordinator commitOffsetsSync ConsumerCoordinator.java 358]
  [org.apache.kafka.clients.consumer.KafkaConsumer commitSync KafkaConsumer.java 968]
  [kinsky.client$consumer$reify__12216 commit_BANG_ client.clj 405]

Can you share the snippet you used to commit offsets?

Nevermind, I found what the issue is, working on a fix.

Cool

If you can, please test latest master, I'm not 100% convinced yet but it's seems to solve the issue.

I have seen the same thing when doing a resume immediately after a commit. I'm working around it with a good ol' Thread.sleep(), but that's hacktacular at best.

@jmglov can you paste the code that triggered the issue?

Given a control channel control-ch and a sequence of topic partitions topic-partitions, this will throw a WakeupException:
(put! control-ch {:op :pause :topic-partitions topic-partitions})
(do-something-that-takes-a-few-hundred-milliseconds)
(put! control-ch {:op :commit})
(put! control-ch {:op :resume})

This does not throw the exception:
(put! control-ch {:op :pause :topic-partitions topic-partitions})
(do-something-that-takes-a-few-hundred-milliseconds)
(put! control-ch {:op :commit})
(Thread/sleep 1000)
(put! control-ch {:op :resume})

Hi @jmglov,
I confirm that the following scenario now works:
  ;; Assuming a topic "test" with 4 partitions

  (def t "test")
  (def nparts 4)
  (def parts (vec (for [i (range nparts)] {:topic t :partition i})))
  (def gid (str "testgroup-" (rand-int 1000)))

  (Thread/setDefaultUncaughtExceptionHandler
   (reify Thread$UncaughtExceptionHandler
     (uncaughtException [_ thread e]
       (println (pr-str e)))))

  (require '[kinsky.client :as client] '[kinsky.async :as async] '[clojure.core.async :as a] '[clojure.pprint :refer [pprint]])

  (let [[out ctl] (async/consumer {:bootstrap.servers "localhost:9092" :group.id gid} :string :string)] (def out out) (def ctl ctl))
  (a/go (loop [] (pprint (a/<! out)) (recur)))

  (a/put! ctl {:op :subscribe :topic t})

  (do
    (println "pause")
    (a/put! ctl {:op :pause :topic-partitions parts})
    (println "commit")
    (a/put! ctl {:op :commit})
    (println "resume")
    (a/put! ctl {:op :resume :topic-partitions parts}))


KAFKA-16001: Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder

Completely migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder and removed all usages of spy objects and replaced with mocks. Removed testEnsureMetadataUpdateOnPoll() since it was doing integration testing. Also I added 2 new tests to get more complete test coverage of ConsumerNetworkThread. All tests are passing

Looks like there are some checkstyle failures due to the use of wildcard imports.

Hey @brenden20, very nice improvement! Left a few comments. Thanks!

@lianetm @kirktrue @philipnee, I have implemented all suggestions except for test removals since I think if we do that, it should go on another ticket as to not bog this ticket down. All tests are passing as well, so let me know if there is anything else I should take care of or if this PR is ready for review. Thank you all for the reviews!

Hey @brenden20 , thanks for the updates! Left some minor comments.

I completed another pass @brenden20 , left some comments to consider getting rid of some instances that we couldn't still mock but seems possible. Thanks!

Hey @brenden20 , thanks for the update, just 2 minor comments left. Could you please get trunk latests changes and solve the conflicts? Thanks!

@lianetm implemented suggestions and merged with trunk for no conflicts

Regarding the PR description, I would suggest to update:

Removed testEnsureMetadataUpdateOnPoll() since it was doing integration testing~~, could not get a unit test to work for that one~~

You did just great removing it, as it was testing something that it's not the responsibility of this component, and that's exactly why a real unit test is not doable ;)

@lianetm implemented your suggestions on the description and testConsumerNetworkThreadPollTimeComputations(). Let me know how it looks

@lianetm I implemented your new suggestions, let me know if it looks good

@mjsax can you take a look?

Thanks for the PR @brenden20! Merged to trunk.

@mjsax thank you for the review!


ImportError: cannot import name 'Irt'

I do as the demo,but get the error
Type "help", "copyright", "credits" or "license" for more information.

from future import print_function, division, unicode_literals
from psy import Irt, data
Traceback (most recent call last):
File "", line 1, in
ImportError: cannot import name 'Irt'

Thats because the package is " irt " and not " Irt " .  I would recommend to close this issue


added prompt

Closes #56

huh! tbh I didn't expect this to be so straight-forward. this is awesome. and will be super useful and necessary for chatting with Meta Llama 2 7B Chat model all within run.c. I'll take a look tomorrow, getting tired for today.

Are you sure this is correct and consistent with sentencepiece? have you tried comparing?

I'm not sure, so I have to check it properly!

imo it's better to convert the prompt into tokens first and just modify the "advanced forward" part of the while loop instead
so, from:
while (pos < steps) {
    transformer(token, pos, &config, &state, &weights);

    // next sampling goes here

    // advance forward
    token = next;
    pos++;
}

to:
while (pos < prompt_tokens_size + steps) {
    transformer(token, pos, &config, &state, &weights);

    pos++;
    if (pos < prompt_tokens_size) {
        token = prompt_tokens[pos];
        continue;
    }

    // next sampling goes here

    token = next
}

@myan-o  This helps me! And I think we should remove this code, because max context length is fixed, otherwise we will get segment fault:
 steps += pos;

Thank you both for pointing this out.
Fix not to exceed maximum context length.

Could be wrong, but doing some local testing I think you need to increment the pos after the initial BOS and the transformer_str call.
When passing in a prompt like "Once upon a time, there was a girl named Lily."
The current setup doesn't forward the position for the last token (in this example -> "."), so the model appends 2 other tokens "all" and "." because it's not in the right Pos.
Example below:

[Once][ upon][ a][ time][,][ there][ was][ a][ girl][ named][ Lil][y][.]all. She loved (...rest of response)

I think it needs to increment the pos after the initial BOS
`
int token = 1; // 1 = BOS token in Llama-2 sentencepiece
int pos = 0;
printf("\n"); // explicit print the initial BOS token (=1), stylistically symmetric
// Kickoff inference with the BOS token
transformer(token, pos, &config, &state, &weights);
pos++;
`
As well as after the transformer_str
  // If we have a prompt, run it through the model first   if (prompt)   {       pos = transformer_str(prompt, pos, steps, &config, &state, &weights, vocab);       pos++; // add one to increment from last token   }
This appears to be more accurate.

[Once][ upon][ a][ time][,][ there][ was][ a][ girl][ named][ Lil][y][.] had a big dream. She (...rest of response)

Please note this is the first time I've worked with C in over 10 years, so I may be missing or a better way.

This is not a correct implementation of the BPE encoding algorithm. I think it may succeed by luck, though. Closing.


chore(src): remove decorators

autoHideContainer and headerFooter have been removed.

It looks like some other PR removed the bundlesize test in the travis matrix?

@Haroenv It seems like this is a Bundlesize bug which is not triggering in this PR, right?
I will rebase to see if it updates.


Update operator framework library in vendor

What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
Not sure exactly why, but this solves problems with
[root@bfb4ae73fc20 odo]# go get<EMAIL_ADDRESS>verifying<EMAIL_ADDRESS>checksum mismatch
	downloaded: h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
	go.sum:     h1:ahVqZF4n1W4NqwvVnZzC4es67xsW9uR/RRf2RRxieJU=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

and
go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>parsing go.mod:
	module declares its path as: gopkg.in/yaml.v2
	        but was required as: github.com/mikefarah/yaml/v2

on some  Fedora systems (I haven't been able to reproduce it on any other system than Fedora)
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[ ] Update changelog

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

it doesn't fix anything :-(


PNG with indexed color interpreted as rgba32

When loading the attached image generated from Aseprite in Indexed mode color, zigimg read the image using the rgba32 pixel format instead of the indexed8 format. The image does render properly when you want to display it but if you want to use the image as-is and preserve the palette and color order, you're out of luck.

There are two ways you could do it.

Less intrusive, more flexible but more verbose way is to call png.load directly and pass in options that don't include palette processor:

var options = png.ReaderOptions.init(.{ .ptr = undefined, .vtable = &NoopAllocator });
png.load(stream, allocator, options);

I just realized I should have provided a no parameter init function for the case above :).

Second option is to redefine the default png options in the root file but then all the code will use those options unless specifically provided like above. So you can define a struct named DefaultPngOptions in the root source file like this:

const DefaultPngOptions = struct {
    const Self = @This();
    pub fn get(self: *Self) ReaderOptions {
        return png.ReaderOptions.init(.{ .ptr = undefined, .vtable = &NoopAllocator });
    }
};

If you don't do any of those two things you can see by default both Trns and Plte processors will be used. Trns moves the alpha information from TRNS chunk to each pixel and Plte processor unpacks the full color for each pixel from the palette,


How to backup Images into new collection?

I have few images in collection of Images. I want to backup that images into new collection.
but there is one issue that is when I'm inserting all records into new collection path of original images is changing. And i'm not able to get images on new path.
Here is My code:
var images = Images.collection.find({}).fetch();
        for (let i = 0; i< images.length; i++) {
            delete images[i]["_id"];
            HistoryImages.insert(images[i]);
        }

Is this is a right way to doing this? or is there another way to take  backup of images and store in new collection? Please help me to resolve this issue.

Hello @Nilsalunkhe ,
Do you use the latest versions of Meteor and Meteor-Files? Also, do you get any error when running your code?
/cc @dr-dimitru

Hi @mksh-su ,
Yes I'm using latest version of Meteor and Meteor-Files.
No errors while running code

Hi @Nilsalunkhe ,
You may take a look at our demos, some of them use image collections. You may find an example of using more than one collection here.
I believe that these examples may help you in solving this issue. If they don't, let us know about it.

Hello @Nilsalunkhe ,
Sorry for late reply, you should use .addFile() method:
var images = Images.collection.find({}).fetch();
for (let i = 0; i< images.length; i++) {
   HistoryImages.addFile(images[i].path, {
      fileName: images[i].name,
      type: images[i].type,
      fileId: images[i]._id, // <--- If you wish to keep same ID, which is used in download path generation
      meta: images[i].meta
   });
}

Feel free to close it in case if the issue is solved on your end.

@dr-dimitru thanks for reply. I have resolved the issue.

Hey @Nilsalunkhe ,
If you like the project, please, support it by:

Star on GitHub
Star on Atmosphere
Check other packages we have made
Share on Facebook and Twitter
Donate via PayPal


Types broken on void clients

Bug description
Due to the change introduced yesterday by https://github.com/prisma/prisma/pull/24160, void clients can now be created (yay!!). However, they aren't complete typescript-wise. The prismaClient.$extends API will throw typescript errors when used.
How to reproduce

Expected behavior
No response
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS:
Database:
Node.js version:

Prisma Version

Hi @NBMSacha, can you please expand on this issue? Can you please paste the prismaClient.$extends API usage in which you see errors, and paste the error message as well?
I would also be beneficial if you please gave us more info for reproducing this, such as your Prisma schema. Thanks!

Sure!
Schema:
generator client {
provider = "prisma-client-js"
output   = "./generated/void"
}
datasource db {
provider = "postgresql"
url      = env("MAIN_DATABASE_URL")
}
Usecase:
return prismaClient.$extends({
query: {
$allModels: {
// @ts-expect-error too powerful to type
async update({model, args, query}) {
return await prismaClient.$transaction(async prisma => {
// @ts-expect-error too powerful to type
const previousData = await prisma[model].findUnique({
where: args.where,
});
          if (!previousData) {
            throw new Error(
              'Record to update not found, did you want to upsert?',
            );
          }

          const result = await query(args);

          const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
          await prisma.$queryRawUnsafe(
            queryUnsafe,
            previousData,
            1,
            model,
            this.blockNumber,
            this.blockchain,
          );

          return result;
        });
      },

      // @ts-expect-error too powerful to type
      async create({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          const result = await this.create(args);

          const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
          await prisma.$queryRawUnsafe(
            queryUnsafe,
            result,
            0,
            model,
            this.blockNumber,
            this.blockchain,
          );

          return result;
        });
      },

      // @ts-expect-error too powerful to type
      async delete({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          // @ts-expect-error too powerful to type
          const previousData = await prisma[model].findUnique({
            where: args.where,
          });

          const result = await query(args);

          if (previousData !== undefined) {
            const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
            await prisma.$queryRawUnsafe(
              queryUnsafe,
              previousData,
              2,
              model,
              this.blockNumber,
              this.blockchain,
            );
          }

          return !!result;
        });
      },

      // @ts-expect-error too powerful to type
      async upsert({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          // @ts-expect-error too powerful to type
          const previousData = await prisma[model].findUnique({
            where: args.where,
          });

          if (previousData) {
            const result = await this.update(args);
            const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
            await prisma.$queryRawUnsafe(
              queryUnsafe,
              previousData,
              1,
              model,
              this.blockNumber,
              this.blockchain,
            );
            return result;
          } else {
            const result = await this.create(args);
            const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
            await prisma.$queryRawUnsafe(
              queryUnsafe,
              result,
              0,
              model,
              this.blockNumber,
              this.blockchain,
            );
            return result;
          }
        });
      },

      // @ts-expect-error too powerful to type
      async updateMany({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          // @ts-expect-error too powerful to type
          const previousData = await prisma[model].findMany({
            where: args.where,
          });

          const result = await query(args);

          if (previousData.length > 0) {
            const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
            await prisma.$queryRawUnsafe(
              queryUnsafe,
              previousData,
              1,
              model,
              this.blockNumber,
              this.blockchain,
            );
          }

          return result;
        });
      },

      // @ts-expect-error too powerful to type
      async createMany({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          const result = await query(args);

          const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
          await prisma.$queryRawUnsafe(
            queryUnsafe,
            result,
            0,
            model,
            this.blockNumber,
            this.blockchain,
          );

          return result;
        });
      },

      // @ts-expect-error too powerful to type
      async deleteMany({model, args, query}) {
        return await prismaClient.$transaction(async prisma => {
          // @ts-expect-error too powerful to type
          const previousData = await prisma[model].findMany({
            where: args.where,
          });

          const result = await query(args);

          if (previousData.length > 0) {
            const queryUnsafe = `INSERT INTO octoflow_${this.streamName}.logs (data, operation, table) VALUES (?, ?, ?, ?, ?)`;
            await prisma.$queryRawUnsafe(
              queryUnsafe,
              previousData,
              2,
              model,
              this.blockNumber,
              this.blockchain,
            );
          }

          return result;
        });
      },
    },
  },
});

Without the "ts-expect-error" flag, we're getting an issue claiming that "update" and all the other methods shouldn't be there!

I have the same problem, typescript doesn't work anymore!


Fix error when passing empty deploy.apiips on URL

PR Summary
Fix error when passing empty deploy.apiips on URL
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[ ] Link to a filed issue

closes #301

Testing with this querystring looks great
?ops=managed&secure=normal&deploy.apiips=&deploy.clusterAdminRole=true&deploy.clusterIPWhitelist=false&deploy.acrPushRole=false&deploy.kvCertSecretRole=false&cluster.apisecurity=none

I notice you've removed the eslint hint
// eslint-disable-next-line react-hooks/exhaustive-deps

This was added initially to surpress the eslint warning

I notice you've removed the eslint hint
// eslint-disable-next-line react-hooks/exhaustive-deps

This was added initially to surpress the eslint warning

Ah! good spot, I may put this back in!


BroadcastTransmitter

Hello,
I don't see what prevents BroadcastTransmitter::transmit from overwriting it's underlying buffer in such a way that CopyBroadcastReceiver::receive returns invalid messages.
In more details:
BroadcastTransmitter::transmit stamps each message it transmits with the tail (tail stamp) counter then increment its tail.
CopyBroadcastReceiver::receive (via BroadcastReceiver::receiveNext) make sure it doesn't run over the tail then validates the message length, copy the message and check again if the message just copied is still valid by checking the message's (tail stamp).
I see a problem with that if memory gets overwrite by a new message while we copy the message in the receiver scratch buffer.In particular if the memory region associated with a message's (tail stamp) is now part of a new message's content. I don't see what prevents this memory region to contain the right (tail stamp) value. Meaning BroadcastReceiver::validate would return true.
Did I missed something or this isn't thread safe?
Sidney

If I understand your concern, how is the case handled where an overwrite could write just the correct thing into the tail offset field of the record header while it is being copied out. Correct?
Assuming you mean an overwrite after the receiveNext validate step.

Indeed, what prevents the transmitter to wrap around and overwrite the memory pointed to by the message record offset in such a way that the length is < capacity and the tail stamp == cursor. If all messages would be of equal size then a tail stamp would always be at the same offsets in the buffer but otherwise I don't see how it would work given a previous tail stamp could later be part of a new message. I hope this clarify my point. Not that easy to discuss threading issues.

I don't see that anything stops the case you mention. I very vaguely remember talking about this with @mjpt777 a long time ago.... but can't remember what, if anything, we came to a conclusion on.
The case of reading when already overwritten is protected some better. But the receiver being interrupted after receiveNext and before validate is not as protected.

Yes this is a possibility. With data being aligned and need to match exactly 8 bytes it is highly unlikely. The likelihood further reduces with each additional message having to match the exact pattern all over again. It also requires the receiver not being able to keep up with a very low volume stream of messages.
The broadcast data in Aeron is not critical so this can be considered a pragmatic solution.
Having said all that I may put in another solution that is totally safe and just a little less efficient. I'm aware of a few ways to do this.
The current approach never impacts the producer at all and that is why it was chosen. These sorts of pragmatic approaches are often employed in network protocols.

I agree it is very unlikely but still possible.
Possible Fix: Forcing messages to always start at given offsets in the buffer would work given the headers would always be at the same places in the buffers. All of this at the expense of wasting space in the buffer.

A simple fix is for the producer to write a counter of the total bytes it has written then delta this after the copy to ensure the read is in buffer range. This will cause one additional cache misses when a new message is read, and possibly another in burst scenarios.

Daydreaming of SSE4 CRC32 access in Java....

Don't @tmontgomery ! You'll only annoy me...


Allow to specify proc for path

thanks - I want to keep the FileDataStore as simple/dumb as possible while still covering what's needed, and ideally the options to these data stores would be just data (not procs, etc.) if possible - as this customization could be done elsewhere (i.e. forming the 'path' option outside the store before passing it in) I'll close for now.
Feel free to reopen if there's something this provides that really can't be done in another way


FEATURE REQUEST: See Streaming Services during Search

cyberskier, post:132, topic:39684
One thought I had while using it today was whether it would make sense (or if it is even possible) to have the search results show what services the show/movie appears on.

Earlier, I said (buried in a much larger response):

babsonnexus, post:104, topic:39684
Would you want an "Available on..." when the search results show up, and it says what services are hosting it? If that's the case, it is possible, but will definitely be a lot of real estate! I'd have to consider that one carefully.

I did look more into doing this, and it is still very possible, but would be a pretty big PITA. I laid some groundwork into the code in case I did decide to pull the trigger. However, I'm also concerned about processing time. Right now, results are fairly instant. To make this happen, basically, for every title, I'd have to loop through and find all its offers and then send that to html, and the webpage has to render that in its own loop. Meanwhile, it is already in a loop of the search results themselves, so it would be a loop in a loop.
I might spend some time kicking it around, but no promises on this request!

This will be available in the next release:

This is fully deployed in v2<IP_ADDRESS>3:
https://github.com/babsonnexus/stream-link-manager-for-channels/releases/tag/v2<IP_ADDRESS>3


Create jenkins-slave ami for saltstack-dev to make testing easier.

I don't think this is actually wanted anymore.  We should be making sre-jenkins a formula that can be included in sre-pillar so we can use the regular salt master on jenkins.


test: sflow capture test

run tests

run skydive-functional-tests-backend-orientdb

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch

rerun tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@41f0a78). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #788   +/-   ##
=========================================
  Coverage          ?   34.85%
=========================================
  Files             ?       60
  Lines             ?     8433
  Branches          ?        0
=========================================
  Hits              ?     2939
  Misses            ?     5181
  Partials          ?      313

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f0a78...da5be1b. Read the comment docs.

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-orientdb


#145 : Added support for COMMAND COUNT command

Summary
Added support for  count command. Please review.
COMMAND COUNT is used to get total number of commands in dicedb.
redis documentation : https://redis.io/docs/latest/commands/command-count
This is my first PR and just getting started with the project. I have referred @yashs360's PR #150 for making the code changes. Thank you @yashs360
Changes

Reused used the changes made by @yashs360  in PR #150 for adding constants for command names. Thanks @yashs360.
Updated the eval methods as per PR #158  to support COMMAND|subcommand, thanks @kakdeykaushik
Added method to get the total number of commands.
Added test and benchmark.

Benchmark results

Issue : #145

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

Hi @arpitbbhayani
Sorry for the delay, i will fix these issues and push updated code over this weekend .
Please excuse

@VipinRaiP in case you missed it. Let me know by where are you planning to wrap it up?

I have fixed the issues and pushed a new commit, thanks

Left some minor comments.

This PR https://github.com/DiceDB/dice/pull/170 will have some conflicts with the current PR.

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170  is merged and make changes as per new code?

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170 is merged and make changes as per new code?

Hi @VipinRaiP, thanks for all the changes so far. #170 has been merged now. Please rebase your changes on top of the latest master and fix any conflicts that may be there. Once you have addressed the reviews, please resolve those comments and I will review this again.

Sure

This PR #170 will have some conflicts with the current PR.

Should this PR wait until #170 is merged and make changes as per new code?

Hi @VipinRaiP, thanks for all the changes so far. #170 has been merged now. Please rebase your changes on top of the latest master and fix any conflicts that may be there. Once you have addressed the reviews, please resolve those comments and I will review this again.

Rebased and pushed a new commit, please review

Approved, will merge soon.
Could you please update the benchmark screenshot (since we have made some changes now) @VipinRaiP

@VipinRaiP Looks like a unit test is failing with these changes, could you please look into it?


[GSSOC'21 ] Improve the UI of the experience form in the contact page

I would like to improve the UI of the experience form in the contact page .

I would like to work on this issue.

i would like to work on this

I would like to improve the UI of the experience form in the contact page .

Assigned for 3 days

After 1 more day, @Fpj-11 can take over


OpenAPI fixes for File Upload and Data Quality endpoints

Description
This PR contains fixes for the OpenAPI documentation for the file upload and data quality endpoints. I audited the parameters and responses of each endpoint for accuracy of what is actually accepted/returned. I didn't quite get the return value of the /api/v2/platform/{platform_id}/data-quality-stats endpoint tidied up as I didn't have any data to return to compare against. That will come in a later PR.
Motivation and Context

Docs are incomplete and become more useful if they are accurate

How Has This Been Tested?

Verified the results on the API Explorer page and compared them to values returned from the endpoints

Types of changes

[x] Chore (a change that does not modify the application functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Documentation updates are needed, and have been made accordingly.
[ ] I have added and/or updated tests to cover my changes.
[x] All new and existing tests passed.
[ ] My changes include a database migration.

I have read the CLA Document and I hereby sign the CLA


devon script does not propagate exit code

When devon «commandlet» «args» is invoked, the exit code of the commandlet is not properly propagated. Hence, calling scripts receive success (exit code 0) even in case of an error.

Fixed with PR #163


[explorer] task: hide hash lock section

What was the issue?

hash lock section is displayed on all transaction-type detail pages, technically it should only display in Aggregate Bonded transaction
hideEmptyData is not working correctly.

What's the fix?

Refactoring on transaction store, hash lock info will only request when the transaction type is AGGREGATE_BONDED, It will reduce API call and performance increment for other transaction types.
fix hideEmptyData issue.
added unit test

@AnthonyLaw looks good.
Hash lock information is visible for aggregate bonded (in the partial and confirmed state):

Hash lock information is not visible for other transaction types.


Revert "Check creating task with video without valid keyframes"

Reverts cvat-ai/cvat#7918

Summary by CodeRabbit

Chores

Removed redundant kubectl cp command from the workflow, streamlining the file copying process during execution.

Tests

Removed the test_can_create_task_with_video_without_keyframes test, simplifying the test suite.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.33%. Comparing base (ddee4db) to head (c32d8fd).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7950      +/-   ##
===========================================
- Coverage    83.38%   83.33%   -0.06%
===========================================
  Files          381      381
  Lines        40053    40053
  Branches      3769     3769
===========================================
- Hits         33399    33378      -21
- Misses        6654     6675      +21

Components
Coverage Δ

cvat-ui
79.22% <0.00%> (-0.11%)
:arrow_down:

cvat-server
87.12% <0.00%> (ø)


Update hololens2-language-support.md

Removed es-MX from support list and corrected some formatting issues.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Looks good, thanks @JohanFreelancer9!

#hold-off
Because of the quantity of changes, I'm sending this to our group editor for review. Changes pending.

@tmlyon : Looking forward to your follow-up on the comments & suggested edits above.

@tmlyon Apologies, I have missed the latest 2 commits that seem to finally conclude this PR. Would you be able to resolve the merge conflicts to proceed with the merge? Thank you for your patience with the process.

@e0i conflicts should be resolved now

@Dansimp The PR that has been approved by the document author should be ready to merge now. Thanks.


Improve web scraping with playwright

This ticket is based on the discord discussion.
There are some areas where the playwright implementation could be improved.

Ideally we should be using locators instead of $$ to query stuff from the page

this is probably a breaking change because the returned object from a locator and an ElementHandle are not the same
locators are more resilient since playwright will auto-retry over and over until the timeout is hit

If this does turn out to be a breaking change, we should decide if we should create a new function so that anything existing still works or if we should replace what folks have (and maybe there is a way to make it non-breaking?)
Research should also be done on Playwright to decide if any other options should be supported.

@johnlindquist - After doing some digging, I actually think the current implementation probably works (mostly) fine. I must have had some code issue initially that I did not realize, which was why things were not working.
I am going to open a PR with some minor improvements and to fix the bug I reported here #1016


Drag and drop on the same sets of elements, like swapping operations

Pass on dropped element’s bind data/obj to onDropComplete call.

@fatlinesofcod, could you please merge this code and put it in new release ?. There are scenarios where we need to get drop location data.


Theme CSS update is needed for Sphinx 4.0.1

Describe the bug
After upgrading Sphinx to version 4.0.1, I've noticed a change in styles. In this issue in michaeljones/breathe repository I was told that it is not a bug on Sphinx/breathe side but rather an intentional change in the new version of Sphinx, and that css should be fixed on the theme side.
Here's what the breathe output looks like with Sphinx 4.0.1 and sphinx-book-theme 0.1.0. If you compare it with the output produced with the earlier version of Sphinx, you'll see that all the code highlighting is missing:

Expected behavior
With Sphinx==3.5.4 and sphinx-book-theme 0.1.0 the output looks like this:

To reproduce
The example (rst/header) is taken directly from the breathe documentation.
Environment

Python Version: 3.6.9
Operating System: Ubuntu
breathe==4.30.0
sphinx-book-theme==0.1.0

this one is resolved!


[FIX] Support for supplying a separate value to the saml request for http_host

This PR is needed because the value is hard-coded to accept only a certain value
Domains such as 'etsin-finder.local' or other domains will not work

Requires https://github.com/CSCfi/etsin-ops/pull/40


Cannot pass object as perm to map.

while creating a product we make a map. which works fine for simple attributes, but is not working for object type attributes.
dimensions.setLength("1");
        dimensions.setWidth("1");
        dimensions.setHeight("1");
        Gson gson = new Gson();
        String json = gson.toJson(dimensions);

        productInfo.put("dimensions",json);

on printing, it shows JSON has the object of dimensions
{"length":"1","width":"1","height":"1"}
help me fast plz

same is the case while working with images and categories.


Tensorflow model detecting wrong objects?

Hi, i am new to tensorflow object detection API, i trained a model with 900 images of shoes, i put 20%(180 images) into test forlder and 80%(720 images into train folder), but after training my trained model detecting other objects with shoes, below is the screen shot, anyone can help me please, where i am wrong....
I am training this model on MAC Machine, and using faster_rcnn_inception_v2_coco_2018_01_28 model to train my model, I follow below(Your) link to train my model:
https://github.com/EdjeElectronics/TensorFlow-Object-Detection-API-Tutorial-Train-Multiple-Objects-Windows-10/tree/d1c5b59803543e48362c27c48d704d4b0d92d135
and one more question when i run python on this model on terminal webcam becomes very slow why? (I have no graphics card in my MAC Machine)
Thanks in advance...

A bit irrelevant, how you configured Python path on mac i try to configure python path on mac and its not working, share it with me.
For your question may be something is wrong with your data labelling, you can check that

export PYTHONPATH=/Users/cssjockey-13/tensorflow1/models:/Users/cssjockey-13/tensorflow1/models/research:/Users/cssjockey-13/tensorflow1/models/research/slim

well  thanks, i had used many ways but nothing is worked for me on mac, let me try this as well

i have trained the algorithm in windows and still the same problem is coming up. I am also searching for the reason for this

Hello these are due to false positive detections, while training your models have you added background images to your training dataset? by doing so you can reduce your false detections.

Hello @msarfrazcss , i have the same problem with yours. Did you solved your problem? If you solved it, how did you solved it? Can you please explain to me?

i also need the solution

i got the same problem


Implement implicit instantiation of Builder and Normalizer classes

So that something like this would work:
import sic
sic.build_normalizer('path/to/config.xml')
result = sic.normalize('string to normalize')

Resolved with PR #6


Output size of ImageEditor.cropImage is incorrect

Environment
React Native Environment Info:
System:
OS: Windows 10
CPU: (4) x64 Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz
Memory: 1.68 GB / 7.91 GB
Binaries:
Yarn: 1.9.4 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.5.0 - ~\AppData\Roaming\npm\npm.CMD
IDEs:
Android Studio: Version  <IP_ADDRESS> AI-181.55<IP_ADDRESS>56338
Description
Occasionally, output of ImageEditor.cropImage is different from displaySize in cropData, for example setting displaySize to {width: 16, height: 16} will output size {width: 15, height: 15} or {width: 16, height: 16}
Reproducible Demo
Put the code below somewhere in the entry file, or use this snack
import { Image, ImageEditor } from "react-native";

// promisify functions
function cropImage(uri, cropData) {
  return new Promise((resolve, reject) =>
    ImageEditor.cropImage(uri, cropData, resolve, reject)
  );
}
function getSize(uri) {
  return new Promise((resolve, reject) =>
    Image.getSize(uri, (w, h) => resolve({ width: w, height: h }), reject)
  );
}

const width = 2160;
const height = 3840;
const displaySize = { width: 16, height: 16 };

// get a random pic of size 2160x3840
cropImage(`https://source.unsplash.com/random/${width}x${height}`, {
  offset: { x: 0, y: 0 },
  size: { width, height },
  displaySize,
  resizeMode: "cover",
})
  .then(resizedUri => getSize(resizedUri))
  .then(resizedDimensions => console.log(resizedDimensions));

// output:
// Object {
//   "height": 15,
//   "width": 15,
// }

// Expected output:
// Object {
//   "height": 16,
//   "width": 16,
// }

@nrator react-native-image-size:

A teammate and I ran into a similar issue in our application.  After a few hours of debugging, it looks like the image's size returned from Image.getSize is half the size for some reason.  For example, we had a ~4000x3000 px image taken from an iPhone.  Image.getSize would return 2000x1500.  Scaling the value returned from the function by 2 fixed our problem.

Since the module was extracted I opened a new issue in proper repo. Please continue conversation there


support env and config storage driver

Issue: https://github.com/oam-dev/kubevela/issues/751

I don't think the driver can be an option defined in vela env. It should be a system level option( implemented by SYSTEM ENV or Start args options). That once kubevela deployed somewhere, the driver is specified and can't be changed.

Please review again.

I don't think the driver can be an option defined in vela env. It should be a system level option( implemented by SYSTEM ENV or Start args options). That once kubevela deployed somewhere, the driver is specified and can't be changed.

Please review again.

@Cweiping  please fix conflicts, thanks!

@Cweiping  please fix conflicts, thanks!

LGTM, please resolve the conflict

LGTM, please resolve the conflict

@wonderflow @ryanzhang-oss
Done.

@wonderflow @ryanzhang-oss
Done.


fix: Catch db_engine_spec.get_function_names exceptions (#9691)

Cherry-picked https://github.com/apache/incubator-superset/commit/358bbe0c88f7ab5d130be153151c5c1f9eed8639 into the apache-0.36.0 branch. This fix allows us to still get the list of databases even if getting function names for one database fails.

meow @betodealmeida

Codecov Report

Merging #102 into apache-0.36.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           apache-0.36.0     #102   +/-   ##
==============================================
  Coverage          59.03%   59.03%
==============================================
  Files                379      379
  Lines              12181    12181
  Branches            3010     3010
==============================================
  Hits                7191     7191
  Misses              4809     4809
  Partials             181      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd8ca9...b4f9308. Read the comment docs.

@khtruong you can ignore the CLA check and just :rocket: this.


DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException

Opening this PR with commit to address review comments in original PR-1671
@KazydubB - Can you please do final review for this ?

+1

Merged with commits:
a1986a3fec1634812712e47be0be2565b303ea2d
771fd270b684bbf388c0e2fa10b359eba3dfdb7c


merge from arlac77/template-github-action,arlac77/template-kronos-component

package.json

chore(deps): add ^7.3.1 remove ^7.3.0 (devDependencies.c8)

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   99.08%   99.08%
=======================================
  Files           1        1
  Lines         109      109
  Branches        9        9
=======================================
  Hits          108      108
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5882a0e...f72b5c4. Read the comment docs.


Support empty first item, to create section contents?

Without literate-nav, I do this in nav:
    - Layouts:
      - manual/commands/api/layouts/index.md
      - Bsp: manual/commands/api/layouts/bsp.md
      - Columns: manual/commands/api/layouts/columns.md

(I use your section-index plugin)
How would I go about doing the same with literate-nav and gen-files?
If I do the following:
    - Layouts: manual/commands/api/layouts/

...and write this SUMMARY.md manually:
* [](index.md)
* [Bsp](bsp.md)
* [Columns](columns.md)

...it works. But I don't think I can programmatically create such a literate nav with gen-files:
nav = mkdocs_gen_files.Nav()

nav[()] = "index.md"  # error
nav[""] = "index.md"  # error

The solution in mkdocs_literate_nav for this is:

Omit index.md.

Specify implicit_index.
plugins:
  - literate-nav:
      nav_file: SUMMARY.md
      implicit_index: true

Write this SUMMARY.md:
* [Bsp](bsp.md)
* [Columns](columns.md)

Bonus style points for actual literate nav:

plugins:
  - literate-nav:
      nav_file: index.md
      implicit_index: true

Write this index.md manually:
# Layout objects

Layouts position windows according to x x x

These are the available layout objects:

<!--nav-->
 * [Bsp](bsp.md)
 * [Columns](columns.md)

implicit_index: true

Awesome, I missed this option in the docs, sorry!
This option solves my use-case, since I manually write the index.md files anyway, so the change in mkdocs-gen-files is not critical (but could allow per-summary configuration instead of only global configuration :+1:).
Thanks @oprypin.


test: fix integration test

Run the integration tests on windows (should work on Linux too):

Changed commands to create file from touch to echo.
Use double quote to create commit message instead of single quote.

Missed configuration:

Add remote (origin) to most of the tests. It is not working without configuring it because we are looking for the remote address in the code. It is madatory at the moment.

Incorrect tests:

Fixed some assert condition because they were wrong.

[x] pytest :heavy_check_mark:

[x] black :heavy_check_mark:

Closes #89

Can you please rebase it? And I will merge it.

Done !


Reword .NET Standard targeting guidance?

I found this confusing:
> ❌ AVOID using multi-targeting with .NET Standard if your source code is the same for all targets.
I believe it means, don't target specific platforms in addition to targeting .NET Standard if they will be built from the same source code. However "multi-targeting with .NET Standard" sounds like a concept, so it sounds like it's advising against targeting .NET Standard at all. Perhaps something like this:
> ❌ AVOID multi-targeting as well as targeting .NET Standard, if your source code is the same for all targets.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b3638c9-ea3c-1c9e-2763-5c3e8e965663
Version Independent ID: aff99d6b-9471-9277-160b-670ee8028b53
Content: Cross-platform targeting
Content Source: docs/standard/library-guidance/cross-platform-targeting.md
Product: dotnet
GitHub Login: @JamesNK
Microsoft Alias: mairaw

@JamesNK can you comment on this feedback from @danmosemsft?

Looks good to me :shipit:

Ok, I'll create the PR then.


Implementation of gpfs daemon network to the ansible toolkit.

Implementation of gpfs daemon network to the ansible toolkit.
Fix some typos inside the ansible yml files.
Fix problem with yum handler file.
Fix warning message with unnecessary brackets.

Thanks for the additional details @Christop1964.
I'm afraid I still don't fully understand the scenario that this addresses. Currently we're using the scale_daemon_nodename for each node when creating the cluster. It defaults to ansible_hostname, but could be overridden (on a per-host basis) if users want to use a different hostname / network for GPFS daemon communication. What's the benefit of introducing the additional scale_daemon_network variable?

Thanks for the additional details @Christop1964.
I'm afraid I still don't fully understand the scenario that this addresses. Currently we're using the scale_daemon_nodename for each node when creating the cluster. It defaults to ansible_hostname, but could be overridden (on a per-host basis) if users want to use a different hostname / network for GPFS daemon communication. What's the benefit of introducing the additional scale_daemon_network variable?

@acch Thank you.  i think you are correct , user can override this flag based one their admin n/w or daemon n/w.
hosts:
[cluster01]
host-vm1 scale_cluster_quorum=true   scale_cluster_manager=true scale_cluster_gui=false scale_daemon_nodename = <scale_daemon_nw>
@Christop1964 If this will work then we may not need some block of code speciifc to scale_daemon_nw . Can you please check.  Thanks

We fixed git issue with new PR , so closing this.
#259


[network] Check peerid, block self connect self

Description
IdentityService check Hello response result, if peerId equal to self peerId (if peer is echo response), return error, don't add peer to pools
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[x] I have tested this code with the official test suite
[ ] I have tested this code manually

Codecov Report

Merging #237 (9a5dadc) into dev (a840ee8) will increase coverage by 0.21%.
The diff coverage is 56.60%.

@@            Coverage Diff             @@
##              dev     #237      +/-   ##
==========================================
+ Coverage   51.21%   51.43%   +0.21%
==========================================
  Files         117      117
  Lines       17525    17668     +143
==========================================
+ Hits         8975     9087     +112
- Misses       7789     7818      +29
- Partials      761      763       +2

Impacted Files
Coverage Δ

blockchain/storage/kvstorage/kvstorage.go
54.16% <ø> (+2.46%)
:arrow_up:

txpool/account.go
80.36% <0.00%> (-5.30%)
:arrow_down:

txpool/query.go
17.39% <0.00%> (-1.66%)
:arrow_down:

types/rlp_unmarshal_storage.go
13.26% <0.00%> (-0.28%)
:arrow_down:

consensus/ibft/ibft.go
37.50% <35.38%> (-0.07%)
:arrow_down:

network/discovery/discovery.go
36.20% <42.85%> (+1.09%)
:arrow_up:

types/transaction.go
69.60% <72.41%> (+2.43%)
:arrow_up:

network/server.go
74.68% <78.57%> (-0.37%)
:arrow_down:

jsonrpc/dispatcher.go
58.13% <80.64%> (+3.11%)
:arrow_up:

jsonrpc/jsonrpc.go
19.28% <100.00%> (+0.41%)
:arrow_up:

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implement Signature Validation Logic

Currently, there is no validation for the signatures. it is stored as an array of byte arrays ([][]byte) and there is no validation logic tied to this. it can be stored as is.
Improvement proposal:
Chainlink Account Store has signing keys stored now.
Should tie this logic to verify feed data submissions have correct signatures.
should verify that the feed submitter has a valid chainlink account before submission. (done in ante?)

we will need a few things for validation.
OCR should include the following:

observation data
signed obversations
list of chainlink public keys
list of cosmos public keys

from the signed observations and observation, we can derive the signature. Then we will use the chainlink public key to verify the signature

we need:

OCR report which contains the observation signatures of the current round
data providers chainlink account pubkeys of the current round
the original observation data of the current round
4.data providers cosmos account pubkeys of the current round


Field names mixed up writing via "KML" driver

Expected behavior and actual behavior.
Attempting to save a GeoPandas dataframe using:
        with fiona.Env():
            gdf.to_file(kml_path, driver='KML', NameField='name')

produces a KML file in which the value for <name> is taken from another field, and likewise <description>.  If the file is written the hard way (using ogr) it is correct.  Perhaps there are some kwargs that need to be passed along to correct this?  In the example above NameField='name' was an unsuccessful attempt.
Correct KML using ogr:
<?xml version="1.0" encoding="utf-8" ?>
<kml xmlns="http://www.opengis.net/kml/2.2">
<Document id="root_doc">
<Schema name="walk" id="walk">
	<SimpleField name="id" type="string"></SimpleField>
	<SimpleField name="date" type="string"></SimpleField>
	<SimpleField name="distance" type="string"></SimpleField>
	<SimpleField name="speed" type="string"></SimpleField>
	<SimpleField name="time" type="string"></SimpleField>
	<SimpleField name="activity_name" type="string"></SimpleField>
</Schema>
<Folder><name>walk</name>
  <Placemark>
	<name>Walked 3.97 km on 22/1/17</name>
	<Style><LineStyle><color>ff0000ff</color></LineStyle><PolyStyle><fill>0</fill></PolyStyle></Style>
	<ExtendedData><SchemaData schemaUrl="#walk">
		<SimpleData name="id">1965703340</SimpleData>
		<SimpleData name="date">01/22/2017</SimpleData>
		<SimpleData name="distance">3.96978493824</SimpleData>
		<SimpleData name="speed">1.397811597971831</SimpleData>
		<SimpleData name="time">2840</SimpleData>
		<SimpleData name="activity_name">Walk</SimpleData>
	</SchemaData></ExtendedData>
      <LineString><coordinates>151.165393442,-33.7688339688 ...<PHONE_NUMBER>8,-33.7687453898</coordinates></LineString>
  </Placemark> ...

Incorrect KML using Fiona (see Placemark name and description):
<?xml version="1.0" encoding="utf-8" ?>
<kml xmlns="http://www.opengis.net/kml/2.2">
<Document id="root_doc">
<Schema name="walk" id="walk">
	<SimpleField name="id" type="string"></SimpleField>
	<SimpleField name="date" type="string"></SimpleField>
	<SimpleField name="distance" type="float"></SimpleField>
	<SimpleField name="speed" type="float"></SimpleField>
	<SimpleField name="time" type="string"></SimpleField>
	<SimpleField name="activity_name" type="string"></SimpleField>
</Schema>
<Folder><name>walk</name>
  <Placemark>
	<name>2840</name>
	<description>01/22/2017</description>
	<Style><LineStyle><color>ff0000ff</color></LineStyle><PolyStyle><fill>0</fill></PolyStyle></Style>
	<ExtendedData><SchemaData schemaUrl="#walk">
		<SimpleData name="id">3.96978493824</SimpleData>
		<SimpleData name="date">Walked 3.97 km on 22/1/17</SimpleData>
		<SimpleData name="distance">1.39781159797183</SimpleData>
		<SimpleData name="speed">0</SimpleData>
	</SchemaData></ExtendedData>
      <LineString><coordinates>151.165393442,-33.7688339688 ...<PHONE_NUMBER>8,-33.7687453898</coordinates></LineString>
  </Placemark> ...

Steps to reproduce the problem.
I don't think there was anything special about the GeoDataFrame, but can provide a script and sample data if the answer is not trivial.
Operating system
Mac OS X 10.15.4
Fiona and GDAL version and provenance
Fiona 1.8.13.post1 loaded by PyCharm
GDAL 2.4.0 loaded by PyCharm

A working minimal example would be very helpful.

I just noticed the KML driver is not registered in the supported list of drivers: https://github.com/Toblerity/Fiona/blob/1.8.13.post1/fiona/drvsupport.py#L80
This does not necessarily mean that this driver does not work with Fiona. However, the KML data model is not entirely compatible with the GDAL/OGR data model. This is also mentioned in GDAL's documentation: https://gdal.org/drivers/vector/kml.html As Fiona assumes that a full OGR data model can be used, such drivers are typically excluded by Fiona.
It could be that the driver is sensible to the order in which the fields are written (I'm just guessing). The driver has the following creation options:
Creation Options
The following dataset creation options are supported:
NameField: Allows you to specify the field to use for the KML <name> element. Default value : ‘Name’
DescriptionField: Allows you to specify the field to use for the KML <description> element. Default value : ‘Description’
AltitudeMode: Allows you to specify the AltitudeMode to use for KML geometries. This will only affect 3D geometries and must be one of the valid KML options. See the relevant KML reference material for further information.

These options can be passed to fiona.open. E.g.
with fiona.open(path, mode='w', NameField='the name field name',  DescriptionField='the description field name' ... ) as c:

Here is a simple script that can illustrate the problem.  The data file workouts.gpkg is attached (will need to be unzipped).
import fiona
import geopandas as gpd
gdf = gpd.read_file("workouts.gpkg", driver="GPKG", layer="bike_ride")
gpd.io.file.fiona.drvsupport.supported_drivers['KML'] = 'rw'
with fiona.Env():
    gdf.to_file("bike_ride_fiona.kml", driver='KML', NameField='name')

workouts.gpkg.zip
I had found the KML driver notes you reference above, but the addition of the NameField kwarg didn't make any difference.
My suspicion would be that the OGRFeatureBuilder in ogrext.pyx is for some reason not constructing the feature for the KML driver quite right.  If I construct the feature directly in ogr it looks like so (when exported to JSON):
{
    "type": "Feature",
    "geometry": {
        "type": "LineString",
        "coordinates": [[151.148538533, -33.6983890381], [151.148168283, -33.6982220137], [151.146898883, -33.6979895788], [151.146154005, -33.6978891607]]
    },
    "properties": {
        "Name": "Rode 9.91 km on 9/04/2016", "Description": None, "id": "1419923559", "date": "04/09/2016", "distance": "9.911885322240002", "name": "Rode 9.91 km on 9/04/2016", "speed": "4.644744762061856", "time": "2134", "activity_name": "Bike Ride"
    }
}

Note that ogr has added the Name and Description fields and correctly mapped the name field to Name.
I don't have a C++ environment or I'd be happy to dig deeper.  Thanks for your assistance.

@wheeled For the above-mentioned reasons, I hope you understand that Fiona does not support KML. However, it is still strange that data can be written without error, but just the order of the fields is wrong.
It looks like the order of the fields in the schema is relevant. The following code works:
import os
from collections import OrderedDict
import fiona
import logging
import sys
from fiona.crs import from_epsg
from shapely.geometry import shape

with fiona.open('workouts.gpkg') as c:
    for f in c:
        print(shape(f['geometry']))

logging.basicConfig(stream=sys.stderr, level=logging.DEBUG)

print(fiona.__version__)
print(fiona.get_gdal_release_name())

fiona.drvsupport.supported_drivers['KML'] = 'rw'

fname = 'test.kml'
if os.path.exists(fname):
    os.remove(fname)

schema = {'properties': OrderedDict([
    ('Name', 'str'),
    ('Description', 'str'),
    ('id', 'str'),
    ('distance', 'float'),
    ('speed', 'float'),
    ('time', 'int'),
    ('activity_name', 'str'),
    ('Description', 'str'),
    ('date', 'str'), ]),
    'geometry': 'LineString'}

with fiona.open("test.kml",
                driver='KML',
                layer="walk",
                mode='w',
                schema=schema,
                crs=from_epsg(4326)) as c:
    f = {
        'geometry': {'type': 'LineString',
                     'coordinates': [(151.148538533, -33.6983890381),<PHONE_NUMBER>83, -33.6982220137),
<PHONE_NUMBER>83, -33.6979895788),<PHONE_NUMBER>05, -33.6978891607)]},
        'properties': OrderedDict([
            ('Name', 'Walked 3.97 km on 22/1/17'),
            ('Description', 'test'),
            ('distance', 3.96978493824),
            ('id', '1965703340'),
            ('speed', 1.397811597971831),
            ('time', 2840),
            ('date', '01/22/2017'),
            ('activity_name', 'Walk')
        ])
    }
    c.write(f)

with open(fname) as f:
    print(f.read())

whereas if one of the ExtendData fields is in front of Name and Description in schema, the resulting order is wrong.

I found the issue:
https://github.com/Toblerity/Fiona/blob/master/fiona/ogrext.pyx#L1119-L1122
Here it is assumed that the ordering of the schema retrieved by gdal is the same as originally specified. However, the KML driver seems to use internally a specific ordering.

The real issue is, that the KML driver automatically adds fields: https://github.com/OSGeo/gdal/blob/master/gdal/ogr/ogrsf_frmts/kml/ogrkmllayer.cpp#L116-L120
https://github.com/Toblerity/Fiona/blob/master/fiona/ogrext.pyx#L1119-L1122 assumes that only the fields in the schema provided to Fiona exist. The same issue is also present for the DXF, GPX, GPSTrackMacker and DGN driver.
Tested by adding:
diff --git a/fiona/ogrext.pyx b/fiona/ogrext.pyx
index a0b2a6c..c8163ca 100644
--- a/fiona/ogrext.pyx
+++ b/fiona/ogrext.pyx
@@ -1083,6 +1083,12 @@ cdef class WritingSession(Session):

             encoding = self._get_internal_encoding()

+            _schema = self.get_schema()
+            log.debug("before schema: {}".format(_schema))
+
+            if len(_schema['properties']) > 0:
+                raise ValueError("Driver {} has non empty schema: {}".format(self.collection.driver, _schema))
+
             for key, value in collection.schema['properties'].items():

                 log.debug("Begin creating field: %r value: %r", key, value)

So https://github.com/Toblerity/Fiona/blob/master/fiona/ogrext.pyx#L1119-L1122  explains how the fields get mixed up.  If I simulate the behaviour of the dict(zip()) it produces a mapping that agrees with the result:
coll_schema = ["id", "date", "distance", "name", "speed", "time", "activity_name"]
ogr_schema = ["Name", "Description", "id", "date", "distance", "name", "speed", "time", "activity_name"]
schema_mapping = dict(zip(coll_schema, ogr_schema))
print(schema_mapping)

{'id': 'Name', 'date': 'Description', 'distance': 'id', 'name': 'date', 'speed': 'distance', 'time': 'name', 'activity_name': 'speed'}

[note that this process remaps time to name and then later on the ogr driver remaps name to Name]
I understand that you are not necessarily keen to support KML, but if this issue also affects some other drivers would it be possible to classify it as a bug?
I imagine the fix would be to check that the collection.schema['properties'].keys() and ogr_schema['properties'].keys() were the same length prior to zipping them.  If all of the offending ogr drivers add their special fields at the beginning of the schema, this might work as a fix:
        ogr_schema = self.get_schema()['properties'].keys()
        coll_schema = collection.schema['properties'].keys()
        offset = len(ogr_schema) - len(coll_schema)
        self._schema_mapping = dict(zip(
            coll_schema,
            ogr_schema[offset:] ))

This assumes that the driver will look after its own Name and Description fields.
I apologise again that I am not set up to be able to test it.


index_in_collection fails when creating a worksheet manually

The index_in_collection function on Row works fine when loaded from a file, but fails when a workbook is built manually using RubyXL:
require 'rubyXL'

workbook = RubyXL::Workbook.new
worksheet = workbook[0]
worksheet.add_cell(0, 0, 'data')
row = worksheet.sheet_data.rows[0]
puts row.index_in_collection

The above snippet throws .../gems/rubyXL-3.4.3/lib/rubyXL/objects/sheet_data.rb:156:in 'index_in_collection': undefined method '-' for nil:NilClass (NoMethodError)

index_in_collection is a service method and is not supposed to be used by the end user (the values it uses are either loaded from the source file, or are initialized on spreadsheet save). Why do you feel the need to use that method?

I didn't see anything in the docs about it being something I shouldn't use.  I have an app where I loop through a sparse sheet only processing rows with data; index_in_collection is a very handy way of finding where I am without keeping track manually.

As a workaround, you can force populating of r elements of a worksheet by calling before_write_xml on it. But I recommend 'keeping track manually' as it would be faster and more accurate.


PouchDB?

I see the server db is mongo. I wonder if there is something for mongo like PouchDB (which is for CouchDB on the server) so that any user input that happens offline will be queued up and synced when the user gets back online?

Datastore on the client side is not handle in a db but directly using localStorage. There is no complexity on this side for the moment. So I don't see benefit to use PouchDB (or another local DB) now.

I found https://github.com/mWater/minimongo as a similar tool for MongoDB.

I don't see benefit to use PouchDB

Currently you store data on client side using localStorage, but how do you sync this data with the Sugarizer Server?

For each user, there is a local Journal stored in the localStorage and two remotes Journal stored on the Sugarizer Server: one that only the user can see, one shared by all users on the server.
Both remote Journal content are stored in MongoDB.
So, there is no synchronization: each user could choose which content he want to put on the server and which content he want to share.

What about when the user works offline, and then comes online?

The user work offline in the localStorage then could put content from local Journal to the server when online again.

two remotes Journal stored on the Sugarizer Server: one that only the user can see, one shared by all users on the server.

The user work offline in the localStorage then could put content from local Journal to the server when online again.

I see that makes sense for the one that only the user can see; but what about the shared one? Can they edit that offline and sync their changes to it?

Yes. When you open something in a remote Journal, Sugarizer first do a copy in the local Journal, then open it.

NICE!! :D
It seems perhaps we have already all the capabilities that PouchDB offers 'off the shelf.'
If the Font Editor Activity GSOC is done as a Sugarizer Activity, I'll find out more about how what you have works, and be informed about if there's anything Pouch would bring :)


Fix a bug in the include paths and doc it

paths.push with an array obviously leads to having strangely nested arrays that libsass doesn't pick up. Mea Culpa. I also added a doc and fixed the contributing doc.

Any updates on getting this merged?

@mbarlock thanks for the fix. Sorry it took so long, I didn't see this til yesterday. This fix is published in v2.5.1 now.

No worries, Thanks for the fast response!


OBB - error due collision

OBB after colliding with another OBB (both with different rotation and position) cannot verify the collision point and causes the simulation to crash
this happens specially in very wild rotation or position one of objects

perhaps OBBs.collisionPoint() somehow loses the point (check every possible scenario again)

reproduced by testing collision restitution. Leave for now


Fix xmllint requirement

@tiagobento what's the README we must update?

The one in the root.. and don't forget this too:
"kieTools": {
    "requiredPreinstalledCliCommands": [
      ...
      "xmllint"
    ]
  }

Hecho.


Generate pydantic sources automatically

We currently have the make generate recipe taking care of generating the models. However, it is easy to miss updates and get code not properly aligned. We should think on what is the best way to update the code automatically whenever there are changes in the schemas.

Info regarding pushing code in a github action: link


feat(dbm-services): add 记录模拟执行create pod日志

关联研发信息
dev_branch: feat/record_create_pod_record/#1445
target_branch: v1.2.0


Set up CI

Describe the Feature
We need to set up continuous integration for this repo. I'd like to start with the following checks:

lint
flow
jest

Possible Implementations
https://github.com/react-native-community/react-native-slider/blob/master/.circleci/config.yml

Related Issues

I can take a stab at it


🐛 [BUG] - Sprint Cloud Select Project Empty

Description
When I click select project, It see empty list
Reproduction URL
app.sprint.rest
Reproduction steps
1. Go to 'app.sprint.rest'
2. Click on 'Select project'
3. See Empty List

Expected to see at least a project name

Screenshots
![DESCRIPTION](LINK.png)

Logs
No response
Browsers
Chrome
OS
Mac

Manage space added.


Dynamically importing component in different files cause "loading" flash on mount (only in prod)

Bug report
Describe the bug
If we use next/dynamic to import components in several files, we experience a flashing "loading..." text when the client mounts.
If we only import one place, it works fine.
It also works fine in development.
To Reproduce
Codesandbox example below shows that the One component flashes with "loading" text since it is imported twice, while the Two component does not flash, because it is only imported once.

Expected behavior
I expect the dynamic import to behave the same in development and production, as well as it not causing a flash when the client mounts.
Screenshots
If applicable, add screenshots to help explain your problem.
System information

OS: macOS mojave
Browser: Chrome 69.0.3497.100
Version of Next.js: 7.0.2

edit: Codesandbox wasnt running with NODE_ENV=production, fixed now.

Workaround is to dynamically import only one place, and then export that for use other places.

Duplicate of #5452

Duplicate of #5452

You linked to this issue, which issue were you referring to?

Updated the link, sorry about that 😅


Rename https://github.com/instantsearch boilerplates widget to -boilerplate

It should be ovious in the boilerplate widget names that those are boilerplates.

Change the github names
update instantsearch.js documentation to reflect that

cc @seafoox

I'd rather not break anyone linking to those for a small change like that


DISABLE_LOCAL_USER_MANAGEMENT mode added

Added parameter DISABLE_LOCAL_USER_MANAGEMENT (false by default) in
app.ini [service] section; when true blocks access to local user
management options that are not required and possibly problematic
in scenario when users are managed in external database (like LDAP)
and should not be managed separately in gitea. Options specific
to gitea (like restricted users) are still managed in this app.
This mod disables local management for all users in gitea not only
users created from specific backend (i.e. LDAP).
Author-Change-Id: IB#1105051

This is #13068 updated to current main.

What is the reasoning and desired use-case of this configuration? Instance can be have users from mixed sources and external sources are not editable already. Why anyone would want to explicitly configure this option (potentially when there are existing local users)?
In addition, why would this configuration option disable access to configuration of new external sources? As far as I am aware they have nothing to do with "local user management".

What is the reasoning and desired use-case of this configuration?

To allow use gitea in corpo environments where user db is centrally managed (i.e. user data, e-mail in LDAP) and authenticated using reverse proxy (SSO with or without passwords) and local admin should not try to create nor change user data in the app itself.

Why anyone would want to explicitly configure this option (potentially when there are existing local users)?

There are no local users in described scenarios.

In addition, why would this configuration option disable access to configuration of new external sources?

Because in environments as above there is fixed number of user backends and after initial config there should be a switch to disable changes to avoid mistakes. Backend configuration should be moved from DB to app.ini IHMO but thats another (already discusses topic).

There are no local users in described scenarios.

But there can be, isn't that right? For example after installation initial administrator is local one.

But there can be, isn't that right?

Sure; system owner (not gitea developer) should be allowed to decide to enable/disable access to local user management with DISABLE_LOCAL_USER_MANAGEMENT; that's what is this PR for.

For example after installation initial administrator is local one.

Only if is created during installation. Manual installation fortunatelly does not force it.

Codecov Report

Merging #18466 (2691234) into main (3349fd8) will decrease coverage by 0.00%.
The diff coverage is 18.39%.

@@            Coverage Diff             @@
##             main   #18466      +/-   ##
==========================================
- Coverage   46.03%   46.03%   -0.01%
==========================================
  Files         840      846       +6
  Lines       92856    93275     +419
==========================================
+ Hits        42746    42937     +191
- Misses      43323    43519     +196
- Partials     6787     6819      +32

Impacted Files
Coverage Δ

routers/web/admin/emails.go
0.00% <0.00%> (ø)

routers/web/admin/users.go
39.18% <0.00%> (-1.23%)
:arrow_down:

routers/web/user/setting/account.go
25.38% <0.00%> (-2.10%)
:arrow_down:

routers/web/user/setting/profile.go
36.22% <0.00%> (-0.28%)
:arrow_down:

services/auth/source/ldap/source_authenticate.go
46.29% <0.00%> (ø)

services/auth/source/ldap/source_sync.go
37.06% <0.00%> (ø)

services/forms/user_form.go
40.90% <ø> (ø)

models/user/user.go
60.10% <20.00%> (-2.45%)
:arrow_down:

routers/web/admin/auths.go
44.88% <33.33%> (-2.84%)
:arrow_down:

modules/setting/service.go
76.40% <100.00%> (+0.26%)
:arrow_up:

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3349fd8...2691234. Read the comment docs.

Fixed problem with prohibition and extra e-mails when local user management is disabled: e45a831bcd2263cae509f42b3dd66ca2b1307cdb.

It has been stale for a long time, I think it could be closed.
ps: I also agree that usually it should avoid "hiding" UI details, which makes the UI fragile and difficult to test.
Especially for this PR, a lot of logic couldn't be tested easily, and there are too many if blocks .... really fragile.
A whole page could be hidden totally if a feature is disabled, but hiding UI elements again and again seems whack-a-mole game.

I think it could be closed.

Allowing local user management when using external user backend makes no sense and should not be ignored but fixed. Consider creating separates issue if you don't like proposed solution.

I also agree that usually it should avoid "hiding" UI details, which makes the UI fragile and difficult to test.

So you leave bugs just to avoid difficult testing?

A whole page could be hidden totally if a feature is disabled

No because it contains local user settings in gitea app. Only data coming from external must not be changed in gitea.
Feel free to adapt to your vision but please don't ignore such shortcoming - should be fixed if gitea wants to be serious solution for enterprise environments.

There are too many legacy problem for the auth system, not only this "disable DISABLE_LOCAL_USER_MANAGEMENT", but also includes: Enforce 2FA, default login source (OAuth/SAML), etc.
Without a complete design, the simple "patches" would conflict in the end, and would cause security problems for end users.
So, it needs a complete refactoring, I might start the work in 1.21.

it needs a complete refactoring

Agree. Glad to hear there are plans to fix it. If you know any open issue regarding it - may be worth to link it here.

I opened a summary issue to track the problem:  [Summary] Improve auth source / login system #24821
(it's really complicated ....)


unicode problem

I edited the page like this

and when I read it, it outputs like this

am I missing something or um dose not support unicode character now?

Yeah, it's entirely possible that Um itself messed this up. It's also possibly that the man program doesn't know what to do with unicode in a .roff file. Will look into it.
Thanks!

Yeah, it's entirely possible that Um itself messed this up. It's also possibly that the man program doesn't know what to do with unicode in a .roff file. Will look into it.

Not your fault. The default groff on macOS doesn't support Unicode (ref).
With a recent groff from MacPorts or Homebrew, you can get proper display of UTF-8 symbols with something like this:
kramdown -i markdown ~/.um/pages/shell/rsync.md -o man | groff -k -Tutf8 -man | less

…but that kind of defeats the purpose of um. The -k option is key here, and that option is not present in the groff that comes with macOS, which is too old.
Not sure the way forward for um, but for what it's worth, this Kramdown issue does discuss patching the library to force a particular encoding.


Re-add commit from 18209

This PR re-adds @ysyukr as a reviewer for Korean content. #18501 accidentally removed them. Sorry!
/assign @jimangel
/sig docs

@ysyukr welcome back (oops!)

/lgtm

/lgtm
/approve


Referrer

Allows browsers to pass referrer data to sites.

Okay, so I'm not super familiar with this so you're going to have to help me understand your motivation. This definitely doesn't seem like a trivial change though:

Note: The policy’s name doesn’t lie; it is unsafe. This policy will leak origins and paths from TLS-protected resources to insecure origins. Carefully consider the impact of setting such a policy for potentially sensitive documents.

That's from here.

Basically setting "no-referrer" will mess up analytical data. Both for yourself, and any site you link to. It will show all visits as "direct", since it doesn't know from where the visitor came.
By default when removing this line it will fallback to "no-referrer-when-downgrade". Which means all works as long as links are also in the HTTPS protocol.
From what I understand setting it to "unsafe-url" would mean that this data gets passed, even if you link to a site which only has HTTP (even though your own site is HTTPS).
Not sure if it would have other security consequences.
When unsure you could just remove the line, and let the defaults handle it. Which should be fine in most cases.
You can see examples here of what the results would be: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy

Hm, I think I see what the unsafe thing is warning about -- if you met man-in-the-middled, the attacker could see a bunch of information about the referrer we don't want to leak. How about we just remove the line and let the default handle it?

Default should be fine.

Great, thanks!


Changed 'settng' to 'setting' and regenerated the RPC docs

Changes proposed in this pull request:

Fixed issue 1838
Regenerated docs (had to change some things back, since a few changes to the docs have been made manually and not in the generator)

sorry for delay. thank you for contribution!


'Download All...' on the toolbar is disabled if no blob is selected

Storage Explorer Version: 1.31.0-dev
Build Number: 20230728.3
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Right click the blob container -> Click 'Open in React'.
Upload one blob -> Click the little arrow next to 'Download' action on the toolbar.
Check whether the action 'Download All...' is enabled.

Expected Experience
The action 'Download All...' is enabled.
Actual Experience
The action 'Download All...' is disabled.

More Info

For tables, the action 'Export All...' is enabled even though no entity is selected.

For queues, the action 'Move All...' is enabled even though no message is selected.

Verified this issue on the main build 20230731.1. Fixed. So, we are going to close it.