confused about self.inplanes

hello, i research for place recognition and i am very interested in your work. however, i am confused about the value of self.inplanes while building conv2.  i think self.inplanes only change to 64 after building conv2's resnet block . so the first kernel of conv2 is still C32 instead of C64 which is defined
by
self.convs.append(ME.MinkowskiConvolution(self.inplanes, self.inplanes, kernel_size=2, stride=2, dimension=D))
but it still works because of resnet block downsampling.
am i misunderstood?

Hi,
yes are 100% right, there's a mistake in the network details in Table 1in the paper "MinkLoc3D: Point Cloud Based Large-Scale Place Recognition". In the paper, the first convolutional layer in Block 2 has the following parameters: 64 filters, with kernel 2 (which means 2x2x2) and stride 2.
Whereas, in the code the first convolutional layer in Block2 , has only 32 filters with kernel 2 and stride 2. The subsequent residual block takes 32 channel input and outputs 64 channels. This works, because the residual connection includes a "downsample" block (actually the name is quite misleading, it doesn't do any downsampling) which uses 1x1x1 convolution to transform 32 channel input into 64 channels.

Thank you for your reply, i get what you mean. By the way,  i think this situation may also happens in minkloc3Dv2 by the code you released now.

Yes, I'll fix it in the camera-ready version of MinkLoc3Dv2 paper. Thanks for finding this issue and informing me.


min number of items

Why the MIN_NUMBER_OF_ITEMS_REQUIRED is 6 and not 2 ?

This number should be based on itemSize.width, scrollview.contentSize.x and item spacing. If you set it too low you won't get desired behaviour.


Remove used items from search results

When an item is added to the basket, it should be removed from the search results so the same item cannot be added twice.

Duplicated version of #17 .  Which already has work done on it. Closing this issue in favor of 17.


Training Torch Models

Users should be able to train Torch models and interact with the resulting model through the web UI

moved to https://github.com/dfst/deepforge/issues/4


mne. grade_to_tris function for VolumeSourceSpace

Dear Sir or Madame,
I am performing Volume Source Localization and I plan on using a spatiotemporal clustering test on it with the mne package.
Therefore I need to define the neighbor vertices for each vertice. In 'ordinary' source space one can use the mne.grade_to_tris function. But it isn't capable of being used for a volume source space.
Is there an alternative or is the solution to the problem up to myself ?
Yours sincerely,
Daniel van de Velden

this is not implemented. I fear you'll have too look into it yourself.

I found the 'mne.spatial_src_connectivity' function. This function is also not capable of performing a neighbor connectivity calculation, isn't it ?
Would you mind giving me a little help with the solution ? Maybe you are also interested in the solution.

Since you know the spacing of your volume source space, isn't it sufficient to simply compute the euclidean distance from one source to all other sources and take these as neighbours which are closer than (spacing * 1.1)

maybe this can help:
https://gist.github.com/agramfort/a3e3139a1f64315885c923a57e541e7a
please let us know if it does so we can add an example to the mne website.

Thanks a lot for the hint/help.
Right now I am processing and investigating the subject data. The solution of the mentioned problem will come up later.
Of course I will let you know about the solution. Posting the solution in this thread as an attached file is fine ?

yes it will be good to start with

Dear all,
since my computation and Volume Source Estimation is done, I am moving forward to statistical testing - Spatio temporal Clustering Test.
My group study also uses the "fsaverage" brain to make a reasonable comparison of the results. Therefore, its necessary to morph my mne.VolumeSourceEstimate from one subject to an other. Is there any function I wasn't able to find? If there is no function, has anyone ever tried to  do it or tried to 'hack' the surfaces source morphing to accept volume source estimate?
Since it is a delicate matter and I am not an expert yet, I appreciate any corporation.
Greetings,
Daniel
P.S.: I think, since this problem falls in the process of this threads solution, this post is correctly placed.

morphing volume data is not supported and I personally never did it.
you'd better ask on the MNE mailing list for this.
I suspect you'll need FSL or AFNI or ANTS or SPM softwares for this.


Unmet peer dependencies in fresh install

Description
I'm having issues with extract-text-webpack-plugin, trying to debug it seems npm install even after fresh yo fountain-webapp in empty folder results in missing package dependencies.
Error Message & Stack Trace
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Config
{
  "generator-fountain-angular1": {
    "version": "0.6.0",
    "props": {
      "framework": "angular1",
      "modules": "webpack",
      "js": "babel",
      "css": "scss",
      "resolved": "/usr/lib/node_modules/generator-fountain-webapp/node_modules/generator-fountain-angular1/generators/app/index.js",
      "namespace": "fountain-angular1",
      "argv": {
        "remain": [],
        "cooked": [],
        "original": []
      },
      "skip-cache": false,
      "skip-install": false,
      "sample": "todoMVC",
      "router": "uirouter"
    }
  }
}

Environment
npm 3.8.3
Node.js v5.10.1
linux 3.19.0-25-generic
yo 1.8.4

This is just a warning due to peer dependencies, we use a greater version of Webpack.


MattT/Add Healthcheck Route

Fixes #26
Summary
Places a FastAPI instance out in front of the Bolt setup to allow for various additionals types of requests to be handled. Slack bot functionality is kept intact by utilizing an adapter to allow Bolt to communicate via FastAPI to the rest of the world. I only picked FastAPI because that's what I'm most familiar with -- any number of web frameworks can be used in its place and I wouldn't be offended if another one were decided to be preferable.
A /healthz "heartbeat" route has been added that will return a 500 if any threads are found to have died.
A healthcheck section has been added to the docker-compose.yml file. If curl does not receive a successful response from the healthcheck route more than 3 times in a row then the container will be marked as "unhealthy"; at that point the willfarrell/autoheal container will know to mop up and force a restart of the slack-events-bot container.
I've also added a small pytest setup and a new workflow step to run automated test in the CI workflow.
Screenshots
Forcing a restart by spamming a non-existent route:

Test Plan

I set the docker-compose file to build from a local context instead of pulling an image from Docker Hub. This could very well be an optional step if you have another way of going about it.

    # image: hackgvl/slack-events-bot
    build:
      context: .
      dockerfile: Dockerfile

Change this line to the following in order to force the unhappy path:

        if not False:
            ...

Run docker-compose --profile autohealing up to start both of the containers.
Run docker ps -aqf "name=^slack-events-bot$" and note the ID.
Wait for the healthcheck to fail 3 times, and then wait for the autoheal container's check interval to roll around. Feel free to tweak the numbers in the docker-compose.yml file if you would like to expedite things.
You should see the following message:

... Container /slack-events-bot (<ID from step 4>) found to be unhealthy - Restarting container now with 10s timeout

Once the new container is up, rerun docker ps -aqf "name=^slack-events-bot$" and ensure that you have a different ID now.

@all-contributors please add @ThorntonMatthewD for code infra test

@oliviasculley I changed the name of the lint job to lint_and_test to cover the presence of pytest, but it looks like I forgot to account for the branch protection rule enforcing the need for a "lint" job to pass.

I think either the repo's config will need updated or I'll need to set the name back.

It should be changed now!

Thank you so much!

This section in the action-python repo's README lead me astray.

I've changed testing: to pytest:. Last change, I promise!!

It lead me astray too :pensive:

Looks like there is a failure with the pytest setup. Looking into it now.

My lunch is about wrapped up and unfortunately I didn't get to the very bottom of things, but so far I've knocked out a couple of errors:

I had to reformat/add pieces to pyproject.toml to get past some pip errors:

The license field was reformatted to be PEP 621 compliant
A version field was added

I found out that certain "subactions" within<EMAIL_ADDRESS>will use Python 3.7 unless overriden explicitly (link). :dizzy_face: That explained why pip was having a time with resolving dependencies lol.

I'll keep working on this once work wraps today. I apologize for the hold-up!

No it's okay, and I'm not very tied to this microsoft action particularly, so if it makes more sense to just do manual calls to black and pylint I would be okay with doing that or totally ditching the microsoft action as well

I've just thought of another potential blocker.. Does Bolt have a mock client? I'm pretty sure the way things stand the test app will try to phone home on boot with empty credentials. I'm not seeing any provided test fixtures from the library itself.. I may need to whip out the hot glue and popsicle sticks.

Even with junk credentials it appears that the Bolt AsyncApp can start up just fine, which is good enough to allow for testing of the FastAPI bits.
I'm still getting my bearings with Bolt; I'll keep digging and look for a better way of targeting those portions with tests.

I think I'm happy with where this PR is currently. I don't want to succumb to any additional scope creep haha.

I am too, thank you!

I am too, thank you! I adjusted the branch settings for the CI check which needs to match on the name+version I guess, and maybe in the future we can maybe simply the CI a bit so the branch protections don't need to be tied to the version, but I can do that later. Feel free to merge this in whenever, and also #28 :)

Oh, that's interesting about the version popping up in the job name.. I can open an issue for that.
Thank you so much for sticking with me through this review! I really appreciate your time.
It doesn't appear as though I have the ability to merge in the two PRs in the dev branch due to the lack of write access.


ReadTo() causes audio artifacts

Seems like this line s = s[:len(data)-1] causes audio artifacts.

Yes, at the first glance it might be an issue.

This PR should address this issue:
#3


Make config module async

Closes #114

Performance regression!!

this branch: target/release/gh-cli
master: gh-cli
Seems tokio::task::spawn_blocking is adding an overhead!

Merging this as the overhead is minimal and acceptable considering the downsides of keeping blocking tasks inside an async task.


Make Jitpack compile using JDK11

Allows using Jitpack.io instead of the (now deprecated) JCenter

Oops, submitted this to the wrong repository, closing.


Improved main.cpp

Added explicit types for digital/analog voltage.
Reference not needed for digital<->analog conversion functions

mein guter


install: Add --encryption-mode=[ipsec|wireguard]

This modifies the --encryption flag to a string such that the user can pick a encryption mode, i.e. allowing the user to choose between IPsec or Wireguard.
Enabling Wireguard is basically equivalent to cilium install --config enable-wireguard=true --config enable-l7-proxy=false.
Open questions:

Wireguard in Cilium currently does not work with the L7 proxy. We automatically disable the L7 proxy here if Wireguard is enabled. This might not be needed in future versions of Cilium, I'm not sure what the best approach here would be.
Old versions of Cilium (e.g. 1.9) do not have support for Wireguard. This means that because the agent is unaware of the enable-wireguard ConfigMap option that no encryption will be enabled. Again, I'm not sure what the best approach here should be.

$ cilium install --encryption=wireguard --agent-image=quay.io/cilium/cilium-ci --operator-image=quay.io/cilium/operator-generic-ci --version latest
🔮 Auto-detected Kubernetes kind: kind
✨ Running "kind" validation checks
✅ Detected kind version "0.10.0"
🔮 Auto-detected cluster name: kind-kind
🔮 Auto-detected IPAM mode: kubernetes
ℹ  kube-proxy-replacement disabled
🔮 Auto-detected datapath mode: tunnel
🔑 Generating CA...
2021/04/20 17:43:25 [INFO] generate received request
2021/04/20 17:43:25 [INFO] received CSR
2021/04/20 17:43:25 [INFO] generating key: ecdsa-256
2021/04/20 17:43:25 [INFO] encoded CSR
2021/04/20 17:43:25 [INFO] signed certificate with serial number<PHONE_NUMBER>10411371558035536091064166288703354340
🔑 Generating certificates for Hubble...
2021/04/20 17:43:25 [INFO] generate received request
2021/04/20 17:43:25 [INFO] received CSR
2021/04/20 17:43:25 [INFO] generating key: ecdsa-256
2021/04/20 17:43:25 [INFO] encoded CSR
2021/04/20 17:43:25 [INFO] signed certificate with serial number<PHONE_NUMBER>8220022468916953014748461473981058958
🚀 Creating Service accounts...
🚀 Creating Cluster roles...
🚀 Creating ConfigMap...
ℹ  L7 proxy disabled
🚀 Creating Agent DaemonSet...
🚀 Creating Operator Deployment...
⌛ Waiting for Cilium to be installed...

Looks like this needs a rebase after #158 was merged.
The change itself LGTM rocket

Rebased. And added a warning if the user chooses --node-encryption with Wireguard (which we do not support yet in Wireguard, but will in the future)


Fixed number of calls to Collection#add could be Collection#addAll(List.of(....))

What it does
See below
Lint Name
COMMON_REIMPLEMENTATION
Category
complexity
Advantage
No response
Drawbacks
No response
Example
Collection<Integer> collection = new ArrayList<>();

collection.add(1);
collection.add(2);
collection.add(3);

// ...

Could be written as:
Collection<Integer> collection = new ArrayList<>();

collection.addAll(List.of(1, 2, 3));

// ...

or even better
Collection<Integer> collection = new ArrayList<>(List.of(1, 2, 3));

// ...

This is mostly implemented by the Enum.values() detection


Add unsafe to the BitPacker methods

The bitpacker is unsafe. Make sure that the methods that needs to be marked as unsafe are marked as such.

or better, use https://crates.io/crates/owning_ref and remove the need for holding a pointer.


product attachments

I would to know if is possibile upload some documents to a product for example pdf or doc file.
there is already a way to solve this ?
regards.
.g

Hi @ghena
No, we can not upload the pdf and doc for any product.

I suppose it should be easy , cloning image model and edit the product repositories ? or not ?

You can create a custom attribute of the type file if you want.
If the requirement is still not matched then you can customize the product as per your need.


[ACE] Support CMake-based usage

Is your feature request related to a problem? Please describe.
Currently, ACE does not provide facilities for importing it to CMake-based project with e.g. find_package. This should be fixed.
Proposed solution
Add the required machinery to do so, as well as a usage file documenting how to import the library.

ACE doesn't provide at this moment support for cmake build/use. Some projects that use ACE have added some find support to their code, but ACE itself doesn't use cmake, we use MPC to build ACE and all its tests.

Building ACE itself with cmake is not planned, it will make maintenance more complex (multiple build systems to maintain).
There is an upstream issue https://github.com/DOCGroup/ACE_TAO/issues/266, maybe helpful, there are some references there for findACE/TAO modules people created, seems nobody spended time to integrate those into ACE/TAO itself.

Feel free to contribute one ;-)

When you think it is necessary and you don't want to do the work yourself, see https://github.com/DOCGroup/ACE_TAO/wiki/ACE-and-TAO-Commercial-support for the support providers for ACE who could assist with this.

The key isn't the usage file, but installing a good CMake config package.

If it easy to create why not contribute it yourself @martingalvan-volue?

Be aware that ACE isn't actively maintained and tested anymore with Visual Studio in general, due to lack of sponsoring. There are some github CI actions to compile the core with some versions, but nobody runs daily builds/tests of the full stack anymore.

They are both needed, but a usage file would be simpler to create.

No. No.
For simpe config packages, a usage file is not needed. Vcpkg tool uses heuristics.
Without cmake config or find module, the usage file will need just the cmake code which would go to the cmake file...

Didn't this package install pkg-config files? You can use them from cmake.

Didn't this package install pkg-config files? You can use them from cmake.

Not for windows, according to CI file lists.
If it did, vcpkg tool would report that. (Usage heuristics.)

ACE upstream does not provide a method to export cmake, so vcpkg does not support cmake calling ACE for now. If ACE upstream updates cmake export later, we will update it in time.
Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


ci: Check all crate documentation in addition to target-specific ndk

Following https://github.com/rust-windowing/android-ndk-rs/pull/106#pullrequestreview-565655645
Only ndk docs are built for all android targets but the rest of the documentation remains untested. Especially now that we're expanding to provide more complete docs for ndk-build and cargo-apk should everything be tested, to make sure that things like intra-doc links remain in working order.
TODO
The ndk docs build successfully here thanks to the test feature (enabled by --all-features); does it still make a lot of sense to build-test the documentation for every target individually?

does it still make a lot of sense to build-test the documentation for every target individually?

I don't expect any target specific doc parts tbh. Doing it once for one would be fine as well imo.

@msiglreith I guess it's safe to remove then, and have the documentation depend on the test flag (and iirc a cfg(doc) feature is on its way, though it was disabled again on a repo I was contributing to due to it not being propagated to all crates properly).

@msiglreith Removed it :)
Btw we have a lot of build steps now that do not use --target but are repeatedly ran for every rust-target in the matrix, wasting a ton of time and resources. As soon as this is merged I want to separate those out into two jobs that can run in parallel: some that build/test the host tools and docs, while the other simply only installs cargo-apk (bit of overlap with the build in the first job) followed by just the target-specific ndk check and apk build.


⚠ Samsung has degraded performance

In c13ad97, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2783 ms

Resolved: Samsung performance has improved in 9a67149.


The markers for select and multi_select are broken

Hi,
On my system, the markers for select and multi_select are broken:

My system:
$ lsb_release -a
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial

$ ruby -v
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

I noticed I am able to override the marker with both list and multi_list, but I also noticed that the radio markers are hardcoded.
Finally - I ran a test to see all the symbols in your Symbols module, to see what is broken in my system, this is the result, in case it helps.

Happy to provide any additional info, or test any fix candidate.

To be fair I'm really surprised about the behaviour of your system. It feels like you're missing some serious unicode support :smile: There is no guarantee if we were to replace these with any other symbols they would work fine for everyone. I would be more inclined to create a theme option which allows to provide your own set of symbols that take precedence and allow to customise stuff in one place for all the prompts?

Yeah... I spent some time trying to find what is the unicode secret sauce that my systemj is missing, with no luck.
The ability to override the symbols array would be a great workaround.

This is now fully configurable via :symbols option either at prompt initialization or individually per each input type.


Improve package path detection

What do you want to change?
https://github.com/kyleconroy/sqlc/blob/1832ce137a6c225c0d25e626ab6acfe3b5b61278/internal/config/go_type.go#L77
current package name detection could be improved.
package path that end with semver should be aliased as well, otherwise it may generate wrong package name.
package db

import (
	"github.com/aofei/sandid"
	"github.com/gofrs/uuid/v5"
)

type TokenStore struct {
	AccessToken string
	AuthToken   v5.UUID // should be uuid.UUID
	ID          int32
	Expiry      int64
}

What database engines need to be changed?
No response
What programming language backends need to be changed?
Go

The go_type configuration option supports specifying individual parts of the import path for packages that have versions greater than v1 https://docs.sqlc.dev/en/stable/reference/config.html#type-overriding


"fonts.sandbox.google.com/css2" is deprecated?

The mentioned URL is not used in this repo. If you are facing issue with that URL, please report on official repo.


RunPythonScript Operation, Handler & Tests added

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f3c7621). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop   #2195   +/-   ##
=========================================
  Coverage           ?   73.8%
  Complexity         ?     411
=========================================
  Files              ?      66
  Lines              ?    1176
  Branches           ?      79
=========================================
  Hits               ?     868
  Misses             ?     247
  Partials           ?      61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c7621...7a29437. Read the comment docs.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: c015dariu:x: b492ddoYou have signed the CLA already but the status is still pending? Let us recheck it.


gatk-variant template non-zero exit status 250

Hello!
I am using the gatk-variant template and have encountered some issues I would really appreciate any help with.
Upon executing the following command:
bcbio_nextgen.py /n/data1/hms/dbmi/park/alon/software/bcbio/project2/config/project2.yaml -t ipython -n 64 -s lsf -q park_long
things run smoothly for a few hours and then an error appears.
the bcbio-nextgen-debug.log  is attached.
bcbio-nextgen-debug.log
The commands I used are as follows:
# Installation
mkdir /n/data1/hms/dbmi/park/alon/software/bcbio
cd /n/data1/hms/dbmi/park/alon/software/bcbio
wget https://raw.github.com/chapmanb/bcbio-nextgen/master/scripts/bcbio_nextgen_install.py
python ./bcbio_nextgen_install.py /n/data1/hms/dbmi/park/alon/software/bcbio/share/bcbio-nextgen --tooldir=/n/data1/hms/dbmi/park/alon/software/bcbio --genomes GRCh37 --aligners bwa
gatk-register /n/data1/hms/dbmi/park/alon/software/gatk/GenomeAnalysisTK-3.8-0.tar.bz2
bcbio_setup_genome.py -f /n/data1/hms/dbmi/park/alon/software/gatk/human_g1k_v37_decoy.fasta -i bwa -n hs37d5 -b hs37d5

# gatk-variant pipeline
cd /n/data1/hms/dbmi/park/alon/software/bcbio/
bcbio_nextgen.py -w template gatk-variant project2
# manually edit template file: /n/data1/hms/dbmi/park/alon/software/bcbio/project2/config/project2-template.yaml, eddited as shown below*
nano /n/data1/hms/dbmi/park/alon/software/bcbio/project2.csv
# enter the following:
samplename,batch,sex
A10_S10_L008,batch1,male
bcbio_nextgen.py -w template /n/data1/hms/dbmi/park/alon/software/bcbio/project2/config/project2-template.yaml /n/data1/hms/dbmi/park/alon/software/bcbio/project2.csv /n/data1/hms/dbmi/park/DATA/BSMCommonExperiment/ReferenceTissueProject/sourceData/fastq/Vaccarino/A10_S10_L008_R1_001.fastq.gz /n/data1/hms/dbmi/park/DATA/BSMCommonExperiment/ReferenceTissueProject/sourceData/fastq/Vaccarino/A10_S10_L008_R2_001.fastq.gz
cd /n/data1/hms/dbmi/park/alon/software/bcbio/project2/work
bcbio_nextgen.py /n/data1/hms/dbmi/park/alon/software/bcbio/project2/config/project2.yaml -t ipython -n 64 -s lsf -q park_long

*for reference, my project2-template.yaml reads as follows:
# Template for whole genome Illumina variant calling with GATK pipeline
---
details:
  - analysis: variant2
    genome_build: GRCh37
    # to do multi-sample variant calling, assign samples the same metadata / batch
    # metadata:
    #   batch: your-arbitrary-batch-name
    algorithm:
      aligner: bwa
      mark_duplicates: true
      recalibrate: gatk
      realign: gatk
      variantcaller: false
      # for targetted projects, set the region
      # variant_regions: /path/to/your.bed

Thanks a lot for your help!
Alon

Hi Alon,
I think this is a bug in GATK, see https://gatkforums.broadinstitute.org/gatk/discussion/comment/42836#Comment_42836-- they should have a release fixing it soon. @chapmanb might know better, though. It looks like it might be something that you could try rerunning and it might only happen randomly. bcbio will pick up where it left off if you start again to see if it fails in the same spot.

Ah interesting! Thanks for the quick reply Rory! Much appreciated!

Alternatively you could turn on GATK4 instead and run with that and it shouldn't have this issue. See Brad's GATK4 validation here (https://github.com/bcbio/bcbio_validations/tree/master/gatk4). You can turn on GATK4 with this: http://bcbio-nextgen.readthedocs.io/en/latest/contents/configuration.html (search for GATK4). Adding tools_on: [gatk4] to your configuration template will turn on GATK4.

Great suggestion. Thanks again!

Hi Alon, side note, should your genome_build be hs37d5 in your project template?

Haha hey Patrick, thanks for jumping in! Just running a test here, but in general I am!

cool, cheers!

Thanks, hopefully this was all set, closing for now.


Adds the calendar component and all the components that come with it!

A lot remains to be done here;

Style the output
Utilize the ending timestamp
Stop pulling data from a sample written directly into the code
Use more and smaller commits!
Improve the code that is here, because I'm sure there is a whole bunch of redundancy

:+1:


Failure to redirect after authentication through Okta

What is your Scenario?
I am trying to log into a web application that is using Okta oauth2 authentication.
What is the Current behavior?
After successfully authenticating through Okta, the user is redirected back to the original login page at https://oktaqa.iloveasinsflywheel.com/#/auth/login and is not logged in.
What is the Expected behavior?
After successfully authenticating through Okta, the user is redirected to the root of the application, the authentication token is detected, and the application redirects on to https://oktaqa.iloveasinsflywheel.com/#/home.
What is your public website URL? (or attach your complete example)
https://oktaqa.iloveasinsflywheel.com
What is your TestCafe test code?
Not needed. This is easily recreated using only the Hammerhead HTTP Playground.
Your complete configuration file
No response
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

Navigate to https://oktaqa.iloveasinsflywheel.com/
Enter username and password in the correct form fields (to be sent over via email)
Click login button

TestCafe version
1.17.0
Node.js version
v12.18.4
Command-line arguments
N/A. Suggest using the hammerhead HTTP playground.
Browser name(s) and version(s)
Chrome 95
Platform(s) and version(s)
macOS 11.5
Other
No response

Hi @andrewlw89,
I just tried reproducing this issue with the latest testcafe version, however, it looks like your test credentials are no longer valid. Would you please share updated credentials for testing or test this case yourself using TestCafe v2.3.0-rc.2 with the experimental-proxyless option enabled?


Brightness is off by 1 percent on a defined setting

I have a setting that defines 30:50 (and 30:75 for the other light). As seen in the image when the brightness is set to 30%, the percentages of the lights are 49% and 74%.
While that is understandable with calculated values, I think this shouldn't happen at defined settings.
Is this happening to others?

Other than the above, the recent release of Lightener v2.3.0 ads more precision to the mapping. We should be fine here.


Add Michael Timofeev, our QA, to GitHub

Duplicates https://github.com/hyperledger/governance/issues/104, because Michael has yet to appear in the teams nor seem to have invite letters.

he's in


return_only_embed

I'd like to double check if my understanding is correct here:
model = TransformerWrapper(
        num_tokens=20000,
        max_seq_len=2048,
        return_only_embed=True,
        attn_layers=Decoder(
            dim=512,
            depth=12,
            heads=16,

If I instantiate this with the return_only_embed=True and run a standard forward pass with no additional args (besides src / mask) will this return the pure hidden state from the final attention layer?

@JLenzy hey Julian! yes, but after a final norm that has become a standard in pre-norm transformers

Thank you sir! That's a really interest paper, I'll have to check dig deeper into it. As you said, looks to be approaching a different issue but with a similar solution.

@JLenzy ok, yea i think i'll just add it later today. make sure to turn over this rock

@JLenzy want to try this flag in your vae decoder?

think this issue can be closed

Hi @lucidrains , thank you for your continued work on this! But unfortunately it's a bit different than the 'in-attention' mechanism. It is more of a replacement for cross attention than a residual network. In the original paper, they pass in the input (x) as well as a separate, latent vector (z) to the decoder. The latent vector has the dim of [b, c] and is repeated across [t] timesteps of the corresponding x vector. This is what is summed with x prior to each attention layer. So it's a residual latent vector. I believe (please correct if wrong) that your implementation above is a projection + summation of the original x input.
Btw I'd be happy to take a crack at this with a PR if you are open for it! I've got a few working versions with my own custom attention implementations.
z = z.unsqueeze(1).expand(-1, tgt_seq_len, -1)
output = src
if self.norm and self.pre_layer_norm:
      output = self.norm(output)
for i in range(self.n_layers):
     # In-Attention Conditioning for decoders
     if self.in_attention and z is not None:
           output = output + z
     output = self.layers[i](
              output,
              src_mask=mask,
              src_key_padding_mask=src_key_padding_mask
      )

@JLenzy ohh i see, would it help if AttentionLayers simply allowed for accepting in_attn_conditioning_z: Float['b c'] and did the rest?
more importantly, have you replicated the results?

@JLenzy thank you for sharing that! apologize for waving it off so quickly before
you should be able to pass it in as in_attn_cond now

Not a worry at all, really appreciate all your work here! I'll be sure to let you know how it goes on our end.


Breakpoint line numbers don't update in UI when sending a changed BreakpointEvent

I'm working on the debugger for Dart. I'm trying to fix a long-standing issue where we never properly "resolved" breakpoints which could result in breaking on a different line to the one the user picked. However, I've found that when trying to resolve breakpoints and sending Code a BreakpointEvent, it doesn't update the line number in the UI.
Before the debug session, my code/breakpoints looks like this:

When I run this, my DA returns an empty array for breakpoints from the setBreakpointsRequest call and then shortly after I sent BreakpointEvents to add the breakpoints (first at their original location) then to change them (fix the locations and mark as resolved):
} else if (kind === "BreakpointAdded") {
	this.sendBreakPointToCode(this.knownBreakpoints[event.breakpoint.id] ? "changed" : "new", event.isolate, event.breakpoint);
} else if (kind === "BreakpointResolved") {
	this.sendBreakPointToCode("changed", event.isolate, event.breakpoint);
} else if (kind === "BreakpointRemoved") {
	this.sendBreakPointToCode("removed", event.isolate, event.breakpoint);
}

// ...

private async sendBreakPointToCode(action: string, isolate: VMIsolateRef, breakpoint: VMBreakpoint): Promise<void> {
	const bp = await this.vmBpToCodeBp(isolate, breakpoint);
	console.log(`Sending ${action} BP to Code (ID: ${bp.id}) line: ${bp.line} col: ${bp.column} in ${bp.source.path}`);
	this.sendEvent(new BreakpointEvent(action, bp));
}

My logging outputs:
Sending BP to VM for thread isolates/1019045726 file:///Users/dantup/Desktop/Dart%20Sample/bin/donotformat/test.dart 2:undefined
Sending BP to VM for thread isolates/1019045726 file:///Users/dantup/Desktop/Dart%20Sample/bin/donotformat/test.dart 9:undefined
Sending new BP to Code (ID: 1) line: 2 col: undefined in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart
Sending new BP to Code (ID: 2) line: 9 col: undefined in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart
Sending changed BP to Code (ID: 2) line: 10 col: 5 in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart
Sending changed BP to Code (ID: 1) line: 2 col: 13 in /Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart

However, VS Code never updates the breakpoint from line 9 to line 10:

I can repro with a hard-coded setBreakpointsRequest that just sends a BP after 2 seconds then tries to change its line and resolve it after 4:
sponse.body = { breakpoints: [] };
setTimeout(() => {
	this.sendEvent(
		new BreakpointEvent("new",
			new Breakpoint(
				false, 9, undefined,
				new Source("test.dart", "/Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart")
			),
		),
	);
}, 2000);
setTimeout(() => {
	this.sendEvent(
		new BreakpointEvent("new",
			new Breakpoint(
				true, 9, undefined,
				new Source("test.dart", "/Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart")
			),
		),
	);
}, 3000);

this.sendResponse(response);

@DanTup thanks for the repro steps in the last comment. However I see that you are sending two "new" breakpoint events. You should be sending first a "new" and than a "changed" event. The "changed" event shold properly update the breakpoint.
If it does not, please put a breakpoint here and let us know what you find

Whoops, that was a bad paste - however, the repro seems to work on this machine :/ I'll try again on my work machine when I can and post back, and if the repro is good I'll put breakpoints there in the real code that's failing. Thanks!

No problem, let me know how it goes.

This turned out to be a silly error on my part - there was a code path that logged that it was sending a BreakpointEvent but did not (the code is slightly complicated by breakpoints being per-thread and there may be 0 threads at the time setBreakpointsRequest is called). Apologies!

Actually, this is still failing. I put a breakpoint where requested and the first two hits are as expected - a new breakpoint with id 1 and 2. However when the the changed request comes in to move breakpoint 2 to line: 10 I see this:

It looks like breakpoint is undefined (eg. it didn't find breakpoing.id=2 in the model). However, I'm unable to inspect any values here (watch/console just return undefined for everything) and trying to add breakpoints to lines puts them in the wrong place, so it's hard to debug properly.

From there, I hit Step Over and it stopped on line 382 (as expected), then I hit Step Over again expecting it to stop on 391 but it didn't, it stopped on 399. I don't know whether that's really where it is or not.

Ok, somehow my tooltips are showing more info here. Not sure what's with idFromAdapter here - it should be 2 but it's showing (...) (I don't appear to be able to inspect it any further - this.model doesn't exist in console/watch window):

Aha, I was able to Store in Global variable to get at it. The (...) was a getter, and when invoked, it returned undefined:

So the issue seems to be that idFromAdapter is not set correctly on the original breakpoints so it's not finding it during the changed event).
Breaking back on the call where the breakpoint was added with new, we definitely had the ID:

However, it seems like on the next hit, the idFromAdapter getter calls getSessionData and gets undefined back.
I'll see if I can try and get my small repro working; it'll probably be much easier if you can repro it than my blindly stepping through code I'm not familiar with.

@DanTup cool investigation. I pushed some simplification which I think will not fix the issue but might affect it.
We are very close, can you just dig a bit deeper in your previous to last comment.
What I am interested in is when idFromAdapter call getSessionData and gets undefined back can you check what is the this.sessionId and how does the sessionData map look like?
I did not follow your repro steps since I have to clone your repo for it as far as I undertand. If you could create a simple repo on github with that code that I just clone, that would be better.

@isidorn Sorry for the delay. Looks like the sessionID is a GUID but sessionData is empty:

Let me know if I should try anything (or if you can't repro this yourself and think it's specific to my DA, let me know and I can try to make a copy of my extension with no dependencies that you could just run).

(note: I was tested in the current Insiders, so it had the change you mentioned above).

Great. One more time and I think we are good
Put a breakpoint here
And please figure out why this call does not set the sessionData on the breakpoint - it should not be an empty map.

@isidorn At the time that idFromAdapter is called (and returns undefined), the code you point to has never been executed - it's inside event.body.reason === 'changed' but the first entry to here was reason === 'new'. Should there by some code in the event.body.reason === 'new' path that also set the session data?

@isidorn Let me know if the above makes sense or you need any more info from me (the issue is currently tagged needs-more-info).

@DanTup thanks a lot for this great investigation. I believe I have fixed the issue, can you please try it out in tomorrow's insiders and let me know if the issue is fixed. Thank you

@isidorn Now when the breakpoint is added, a space appears in the breakpoint list, but the breakpoint text/file/line/etc. do not appear:

The breakpoint shown here is an existing one - the space below it is where the new one should be (that space only appeared after 2 seconds, when my code fired).
Console has this error:
 ERR Cannot read property 'toString' of undefined: TypeError: Cannot read property 'toString' of undefined
    at e.renderElement (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4786:182)
    at e.renderElement (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:854:762)
    at e.insertItemInDOM (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:425:295)
    at e._splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:422:965)
    at e.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:421:805)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:7:407
    at Array.forEach (<anonymous>)
    at e.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:7:378)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:860:86
    at e.bufferEvents (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:186:889)
    at i.e.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:860:42)
    at t.onBreakpointsChange (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4783:981)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4779:587
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:183:466)
    at e.setBreakpointSessionData (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2634:661)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:4847:236
    at e.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:183:466)
    at t.eventCallback (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2652:207)
    at t.e.acceptMessage (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2663:318)
    at t.handleData (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2664:595)
    at Socket.<anonymous> (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:2664:91)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at TCP.onread (net.js:594:20)

breakpoint.lineNumber is undefined:

I believe that is because you are sending the "lineNumber": 5 in the Breakpoint body. You should send "line": 5 since lineNumber is called line in the debugProtocol. I bit weird yeah I know. https://github.com/Microsoft/vscode/blob/e3938ba331f36aa1739356b8d93a8586a8e549de/src/vs/workbench/parts/debug/common/debugProtocol.d.ts#L1470

Ugh, doh! You're right - me repo works correctly with that fixed!
I'll see if I can wire it all up for real now, thanks for your help!

Welcome, let me know if it works so I add the verified label here

@isidorn I'm still having issues when I switch to my real code - which is weird because I've copied the JSON and sending the same events in timeouts from setBreakpointRequest appears to not have the issue!
I'm trying to debug, but when I put breakpoints in this code, it seems to break on different lines. For example, if I try to put breakpoints on line 721 here, it always immediately jumps to 726 (and then never gets hit). I'm not sure if the source maps are somehow out of date/incorrect. Is there a better way to debug this?

Ok, I think I know what's going wrong. I think it's related to having two ways to provide breakpoints - one in the response to setBreakpointRequest and one via sendEvent(new BreakpointEvent()).
I was trying to return an empty list from setBreakpointsRequest and always send events (because that way I don't need to keep track of which breakpoints I already returned from setBreakpointsRequest so I know to send changed instead of new), however if those events arrive before setBreakpointsEvents returns, it seems like things don't work correctly.
Are there any issues with sending events for breakpoints with reason: new even though they were already returned from setBreakpointsRequest (or always using changed) so I don't have to keep track of breakpoints returned from setBreakpointsRequest and delay the breakpoint events that from from my VM if setBreakpointsRequest hasn't finished yet?

Ugh, I tried some things out and they didn't work, so I reverted them, and now it appears to be working! And it turns out I was already tracking BPs I'd sent to Code (either from events or setBreakpointsRequest) and using that to decide whether to use new or changed). That said, I still think it'd be nice to have an add-or-update to simplify things :-)
Anyway, I'll add some integration tests around this and post back shortly if I think it's all working fine (I suspect it is).

Whoops, think I found what the difference was ;-)

Sorry for the spam :(
I think the issue happens when I send an empty array of breakpoints in setBreakpointsRequest. This happens when my VM hasn't got any threads yet (I can only send breakpoints to threads).
Is it valid to send an empty array back from setBreakpointsRequest and then just send events later, or do I need to send back the same list that was sent to setBreakpointsRequest? (they're different types, so I'd have to map them).

Ok, I can repro my issue with hard-coded code now.
protected async setBreakPointsRequest(
	response: DebugProtocol.SetBreakpointsResponse,
	args: DebugProtocol.SetBreakpointsArguments,
): Promise<void> {

	setTimeout(() => {
		this.sendEvent(
			new BreakpointEvent("new",
				{
					column: undefined,
					id: 2,
					line: 13,
					source: new Source("test.dart", "/Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart"),
					verified: false,
				} as DebugProtocol.Breakpoint,
			),
		);
	}, 2000);
	setTimeout(() => {
		this.sendEvent(
			new BreakpointEvent("changed",
				{
					column: undefined,
					id: 2,
					line: 14,
					source: new Source("test.dart", "/Users/dantup/Desktop/Dart Sample/bin/donotformat/test.dart"),
					verified: true,
				} as DebugProtocol.Breakpoint,
			),
		);
	}, 4000);

	response.body = { breakpoints: [] };
	this.sendResponse(response);
}

This code sends 0 breakpoints in response to setBreakPointsRequest to simulate my code - I can't provide any breakpoints yet because there are no threads. Then 2 seconds later it sends a new breakpoint (simulating that a thread started, and I sent the breakpoint, and got one back from the VM with an ID). Then 2 seconds later it tries to update that breakpoint (simulating that the VM resolved the breakpoint).
However, the UI remains showing line 13.

I got slightly further by returning the original breakpoints instead of an empty list:
response.body = {
			breakpoints: args.breakpoints.map((b) => ({
				column: b.column,
				line: b.line,
				source: args.source,
			} as DebugProtocol.Breakpoint)),
		};

This way the breakpoint goes grey (unresolved), but the updates don't work. My guess is that's because I don't have IDs assigned in the response to setBreakpointsRequest (but I can't provide IDs at this point, since I don't have them).
I'm starting to think that maybe it's not valid/expected to not be able to respond to setBreakpointsRequest with breakpoints with IDs if I want to be able to modify them later? I'd really like to return nothing, and just send the events when my VM is awake later.

@DanTup can we create a new issue with some repro steps and clear concise information?
Reading the above comments it is a bit cryptic to me what is going on :)

I've opened #62264.


Command window support

Is your feature request related to a problem? Please describe.
I wanted to route the command window (q:) to the popup view, but it seems that it's not a part of the supported events.
It would also be nice if treesitter highlighting is supported, since treesitter for some reason doesn't work with the default command window.
Describe the solution you'd like
Support overriding the command window.

That's not possible. The command window is a very special window in Neovim, and can't be touched by any other code.


Please provide a list of specific required resource types by the Flux extension install process

Sometimes Developers have Azure policy in place blocking resource types, which will block the install of the flux extension.
It would be beneficial if you could highlight what the required resource types are and that they should be permitted by Azure policy as important so a Developer can ensure the required resource types are permitted.
For instance with the registered resource providers Microsoft.Kubernetes, Microsoft.KubernetesConfiguration and  Microsoft.ContainerService there are multiple resource types.
Where some organisations are very granular with their Azure policies it would be useful just to have a list of the required resourcetypes, rather than the customer have to take the time out to explore this independently, or force them to be more permissive.
Perhaps a section like "If you are using Azure policy to restrict resource types then make sure the following are allowed: X, Y, Z"?
or Alternative if it is all then highlight the parent needs permitting.
thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d674084-1d8f-b845-9781-d3a144ecfe9b
Version Independent ID: b4b5514f-1b86-5851-5e2f-ef3b592b9600
Content: Tutorial: Use GitOps with Flux v2 in Azure Arc-enabled Kubernetes or Azure Kubernetes Service (AKS) clusters - Azure Arc
Content Source: articles/azure-arc/kubernetes/tutorial-use-gitops-flux2.md
Service: azure-arc
Sub-service: azure-arc-kubernetes
GitHub Login: @JnHs
Microsoft Alias: jenhayes

@michaelspinks
Thanks for your feedback! We will investigate and update as appropriate.

@michaelspinks
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.
@JnHs
Please review it.

Hi @michaelspinks - sorry for the long time to respond. Thank you for taking the time to submit your feedback. We've added a section at https://learn.microsoft.com/en-us/azure/azure-arc/kubernetes/tutorial-use-gitops-flux2#common-to-both-cluster-types for the necessary read/write permissions. I'm hoping this resolves your issue, but let me know if you have additional questions on this.

Thanks, it will help reiterate to the user the permissions by making it explicit.
If it would be possible to be more explicit with the resource types that allowing by Azure Policy that would close the loop for me. I’ve seen policies that restrict resource types implemented you see.
Some teams focus on AKS and not Azure Policy so a couple of sentences to highlight that they need to speak to the Azure Policy guy / or check may help.

Glad to hear this is helpful. The permission requirements would apply to anything that might restrict the read/write access, including Policy or anything else.
I'm going to close this issue now but please let me know if you have further questions!
#please-close


Fail without provider being configured

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
When starting traefik 2.0.0 without any provider configured via CLI (i.e. no --providers.file configured), traefik still parses /etc/traefik/traefik.toml (or the .yml respecively).
Configuring logging etc. works via this configuration file, which is also an expected behavior for me.
There are default entry points, so configuring (only) some routers, services etc. inside this file, I expect traefik to recognize these.
Instead, it ignores the routers. One has to configure a [providers] (providers: in yml) section with file, only then traefik recognizes the routers and services configured in the very same file.
This is not really intuitive. If traefik already parses the config file, I expect it to also recognize the configured routers etc.
Since adding this behavior is a bit of a large change for a maintenance release, I purpose to add an ERROR (or at least WARNING) if there is no provider configured. This would give people at least a hint that they should add this section to the config.

Hello,
In the v1 the file provider ([file]) must also be activated to read frontends and backends.
We made the choice to separate explicitly by default static configuration and dynamic configuration.
So I will decline your request.
Thanks.


Could not find a version that satisfies the requirement nose==0.11.3?

it shows an error: "Could not find a version that satisfies the requirement nose==0.11.3" when execute command "pip install -r requirements/dev.txt". did I did it wrong?

sorry, those deprecated libs are generated by boil plate. You can delete nose and fabric lib in requirements/dev.txt. I will update the file.
thanks for reporting.

OK, thanks.


[3.0] fix ScopeBeanExtensionInjector npe

What is the purpose of the change

Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10140 (653f56a) into 3.0 (25d9daa) will decrease coverage by 0.56%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10140      +/-   ##
============================================
- Coverage     65.72%   65.15%   -0.57%
+ Complexity      319      295      -24
============================================
  Files          1223     1223
  Lines         53228    53221       -7
  Branches       8059     8033      -26
============================================
- Hits          34984    34678     -306
- Misses        14441    14719     +278
- Partials       3803     3824      +21

Impacted Files
Coverage Δ

...dubbo/common/beans/ScopeBeanExtensionInjector.java
100.00% <100.00%> (ø)

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pc/cluster/router/file/FileStateRouterFactory.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...o/rpc/cluster/router/script/ScriptStateRouter.java
0.00% <0.00%> (-67.31%)
:arrow_down:

...ting/zookeeper/curator/CuratorZookeeperClient.java
16.34% <0.00%> (-52.89%)
:arrow_down:

...dubbo/remoting/zookeeper/ZookeeperTransporter.java
55.55% <0.00%> (-33.34%)
:arrow_down:

...pache/dubbo/common/function/ThrowableFunction.java
71.42% <0.00%> (-28.58%)
:arrow_down:

.../remoting/api/SingleProtocolConnectionManager.java
61.53% <0.00%> (-23.08%)
:arrow_down:

...nt/metadata/ServiceInstanceHostPortCustomizer.java
65.78% <0.00%> (-21.06%)
:arrow_down:

... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d9daa...653f56a. Read the comment docs.


can not compile base on Win10 + PyTorch 1.0 + VS2017  +Cuda 10.0.130

Is there anyone can compile it on   Win10 + PyTorch 1.0 + VS2017 +Cuda 10.0.130 ?
when I compile it I got the error message 👎
src\inplace_abn_cpu.cpp(15): warning C4244: “return”: 从“int64_t”转换到“int32_t”，可能丢失数据
src\inplace_abn_cpu.cpp(130): error C2440: “初始化”: 无法从“c10::ScalarType”转换为“const at::Type &”
src\inplace_abn_cpu.cpp(130): note: 原因如下: 无法从“c10::ScalarType”转换为“const at::Type”
src\inplace_abn_cpu.cpp(130): note: 没有可用于执行该转换的用户定义的转换运算符，或者无法调用该运算符
error: command 'D:\VS2017\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\cl.exe' failed with exit status 2
From the change log on Update 08 Jan. 2019, it mentioned
Requires now PyTorch 1.0
But from the current requirement mentioned on readme, it  has follwing requirements
"NOTE: our code requires PyTorch v1.1 or later."
From the requirement.txt , it mentioned only need torch>=1.0
So, I am confused if I still still have chance to compile base on Win10 + PyTorch 1.0 + VS2017  +Cuda 10.0.130
Please comments.

@18608003987 The references to PyTorch 1.0 are outdated, the code actually requires version 1.1. I'll update the README and requirements files accordingly.
As an aside, I would like to point out that, unfortunately, we are unable to provide support for Windows systems. I'm sorry about that.


prettytoml: Catch StopIteration in AbstractTable._enumerate_items

This makes PEP 479 enabled Pythons (such as 3.7) work again.
Otherwise you get:
RuntimeError: generator raised StopIteration

Fixes https://github.com/pypa/pipenv/issues/2426

Untested. The vendoring script fails with unrelated problem.

Ah yes. This is a bug I have attempted to patch for about 2 dozen times and I have no clue why it keeps unpatching itself...
Virtualenv location: /tmp/pipenv-b9_Jcc-project/.venv
Creating a Pipfile for this project...
Pipfile.lock not found, creating...
Locking [dev-packages] dependencies...
Locking [packages] dependencies...
  session=self.session,
  File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/index.py", line 180, in __init__
    impl=implementation,
  File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/pep425tags.py", line 282, in get_supported
    elif platform is None and is_manylinux1_compatible():
  File "/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/patched/notpip/_internal/pep425tags.py", line 160, in is_manylinux1_compatible
    return pip._internal.utils.glibc.have_compatible_glibc(2, 5)
NameError: global name 'pip' is not defined
/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/_compat.py:108: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/pipenv-ZMfLuA-requirements'>
  warnings.warn(warn_message, ResourceWarning)

/var/lib/buildkite-agent/builds/build-1/kennethreitz/pipenv/pipenv/_compat.py:108: ResourceWarning: Implicitly cleaning up <TemporaryDirectory '/tmp/pipenv-_pCZvZ-requirements'>
warnings.warn(warn_message, ResourceWarning)

Note the glibc failure. I'm pretty sure that should be caught by https://github.com/pypa/pipenv/blob/master/tasks/vendoring/patches/patched/_post-pip-update-pep425tags.patch ...

What does https://github.com/pypa/pipenv/blob/04b709fbd0f4b1f70779971245812f2410d6f3f8/tasks/vendoring/patches/patched/_post-pip-update-pep425tags.patch#L21-L22 change?

uh... that's an interesting question...

-    return pip._internal.utils.glibc.have_compatible_glibc(2, 5)
+    return pipenv.patched.notpip._internal.utils.glibc.have_compatible_glibc(2, 5)

is what I'm guessing it is supposed to say...

testing with that.

I'm going to merge this tonight (since I assume the tests will pass on this) -- thanks for the fix.  I'll add a 3.7 build as well so we can iterate and get that working before next week.  Thanks for keeping an eye on us, seriously appreciated

Unfortunately Kenneth has that setup on a private account and they don't have the ability to make this publicly viewable yet, but it passed

Someday appveyor will also run

Thanks again!


Bluetooth: Host: Remove printk dependency from settings

Some modules use snprintk to format the settings keys. Unfortunately
snprintk is tied with printk which is very large for some embedded
systems.
To be able to have settings enabled without also enabling printk
support, change creation of settings key strings to use bin2hex, strlen
and strcpy instead.
A utility function to make decimal presentation of a byte value is
added.
Signed-off-by: Kim Sekkelund<EMAIL_ADDRESS>

@kimsekkelund it seems you only addressed my feedback on the doxygen tags, but none of my other comments?

Perhaps it would be better to have this binary to string conversion somewhere else i.e util.h and have proper unit tests.

@Vudentz , I did consider that but also: will there be any use for such a function at other places? Would it then have to support larger values than u8_t? Or maybe would a future user then expand it to support other types? What do you think?

@Vudentz , I did consider that but also: will there be any use for such a function at other places? Would it then have to support larger values than u8_t? Or maybe would a future user then expand it to support other types? What do you think?

Well I guess users of setting may benefit to having a generic way to convert byte array into a string, something that would usually be covered by snprintk but since we can't actually just select for it instead of the whole PRINTK, actually speaking about that is there no way we could reduce its size to make it a bit more manageable for us? Besides with what we are doing here it may actually increase the image size if PRINTK has been selected.

True, to work around that I could put the original code in #ifdef CONFIG_PRINTK and the new code in #else.
If we allow a little change in the key to be two hex digits instead of one decimal digit, we could use bin2hex() instead of bt_settings_u8_to_dec()

@andrewboie , I will add a configuration BT_SETTINGS_USE_PRINTK which will select the original snprintk code (if PRINTK is enabled) or will add my new code. This way it is possible to have both.

For sake of backwards compatabillity (existing serialized settings), I guess we'd like to keep things kconfigurable to use printk -- but wouldn't it be better to standardize on one way of encoding (and avoid strings altogether)?


NOOBAA_LOG_LEVEL is not working as expected

Environment info

NooBaa Version: noobaa-core-5.17.0-20240904.el9.x86_64
Platform: Standalone

Actual behavior
config.LOG_TO_STDERR_ENABLED = true;
config.LOG_TO_SYSLOG_ENABLED = true;
In this case it is logging all the unwanted messages in the console,noobaa.log and messages.
Expected behavior

we should not see messages in the console.

Steps to reproduce
1.config.LOG_TO_STDERR_ENABLED = true;
config.LOG_TO_SYSLOG_ENABLED = true;
Broadcast message from systemd-journald@ramyamc-42 (Wed 2024-09-18 10:20:09 CEST):
[3267897]: 2024-09-18 10:20:09.491233 [PID-3267897/TID-3267897] FS::set_log_config: LOG_TO_STDERR_ENABLED=1 LOG_TO_SYSLOG_ENABLED=1
More information - Screenshots / Logs / Other output

@naveenpaul1 can you please take a look?

@naveenpaul1 So you mean to say we should not use these 2 config parameters?

issue tested and working as expected
cc : @ramya-c3


Rework coins graphic

Instead of 2 graphs on one page, the user should select if an absolute or relative representation should be shown.
This will reduce the entry to one graphic, which could be also be a stacked graph.

In a first step the scripts for acquiring the data must be adapted. The following DFI categories must be handled:

burned DFI
ERC20 collateral
DFI Token


Make columns draggable

A nice to have feature would be the ability to rearrange the order of columns. Either via the table itself, or the ability to rearrange the tags in the "Select" action. It's possible to re-arrange the columns using "Select" by just adding the tags in the order you'd like, but if you forget a tag or would like to change the order, you have to delete every tag up until the place you wanted to change the order.
For instance:

Using the select action makes it possible to set the order of columns. However if I'd like to change the order of Embarked and PassengerID, I'd have to delete all the tags and then re-add them in the order I'd like. This is especially cumbersome when you have lots of columns.
In my mind, it seems simpler to make the multiselect field draggable using the draggable component (trying to figure out how, but haven't been successful so far), but if it would be easier to add the draggable component to the columns themselves, that would work as well.

@clayscode a pull request would be welcome!


[WIP] Update dependencies

Follow up https://github.com/bitinn/node-fetch/issues/626#issuecomment-493311447
The tests are passing, but the build fails. I don’t use babel or rollup myself, any idea what the error could mean?
$ npm run build

><EMAIL_ADDRESS>build /node-fetch
> cross-env BABEL_ENV=rollup rollup -c

src/index.js → lib/index.js, lib/index.es.js, lib/index.mjs...
[object Object]
    at Object.isRestProperty (/node-fetch/node_modules/@babel/types/lib/validators/generated/index.js:4288:11)
    at DestructuringTransformer.pushObjectPattern (/node-fetch/node_modules/babel-plugin-transform-es2015-destructuring/lib/index.js:197:15)
    at DestructuringTransformer.push (/node-fetch/node_modules/babel-plugin-transform-es2015-destructuring/lib/index.js:108:14)
    at DestructuringTransformer.init (/node-fetch/node_modules/babel-plugin-transform-es2015-destructuring/lib/index.js:317:12)
    at PluginPass.VariableDeclaration (/node-fetch/node_modules/babel-plugin-transform-es2015-destructuring/lib/index.js:468:27)
    at newFn (/node-fetch/node_modules/@babel/traverse/lib/visitors.js:193:21)
    at NodePath._call (/node-fetch/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/node-fetch/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/node-fetch/node_modules/@babel/traverse/lib/path/context.js:88:12)
    at TraversalContext.visitQueue (/node-fetch/node_modules/@babel/traverse/lib/context.js:118:16)

# ... more of the same

(!) Plugin at position 2 plugin: The transformBundle hook used by plugin at position 2 is deprecated. The renderChunk hook should be used instead.
created lib/index.js, lib/index.es.js, lib/index.mjs in 1.2s

No idea yet, haven't used babel lately.
People in the know, feel free to suggest a fix.

@bitinn

No idea yet, haven't used babel lately.
People in the know, feel free to suggest a fix.

It seems like using babel is holding up the development
with people less likely to contribute
which is especially concerning in view of
https://github.com/bitinn/node-fetch/issues/567
My question -- is there any tangible benefit here to use babel,
strong enough to compensate for the added complexity?
From looking over the code, I can only see it for the ES6 imports.
Replacing those with CommonJS would seemingly eliminate the need to use babel.
This is not to debate general benefits of the ES6 imports,
rather the more practical question - to what extent these really matter for this project?

#643 I plan to drop it or update it, but have no time to investigate this issue yet.

During the development of 3.x, we've updated all the dependencies, primarily in https://github.com/bitinn/node-fetch/commit/155ef268ec59e0e18b626a13cc3151e2111cc4e4.


npm start errors out

btw. gulp watch works, nice demo :+1:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\\dev\\nodejs\\node.exe',
1 verbose cli   'C:\\dev\\nodejs\\node_modules\\npm\\bin\\npm-cli.js',
1 verbose cli   'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info prestart<EMAIL_ADDRESS>6 info start<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec start script
9 verbose stack Error<EMAIL_ADDRESS>start: `DEBUG=au-demos-modular:* node src/server-node/bin/www`
9 verbose stack Exit status 1
9 verbose stack     at EventEmitter.<anonymous> (C:\dev\nodejs\node_modules\npm\lib\utils\lifecycle.js:214:16)
9 verbose stack     at emitTwo (events.js:87:13)
9 verbose stack     at EventEmitter.emit (events.js:172:7)
9 verbose stack     at ChildProcess.<anonymous> (C:\dev\nodejs\node_modules\npm\lib\utils\spawn.js:24:14)
9 verbose stack     at emitTwo (events.js:87:13)
9 verbose stack     at ChildProcess.emit (events.js:172:7)
9 verbose stack     at maybeClose (internal/child_process.js:818:16)
9 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
10 verbose pkgid<EMAIL_ADDRESS>11 verbose cwd c:\dev\temp\au-demos\modular
12 error Windows_NT 10.0.10586
13 error argv "C:\\dev\\nodejs\\node.exe" "C:\\dev\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "start"
14 error node v4.2.4
15 error npm  v2.14.12
16 error code ELIFECYCLE
17 error<EMAIL_ADDRESS>start: `DEBUG=au-demos-modular:* node src/server-node/bin/www`
17 error Exit status 1
18 error Failed at the<EMAIL_ADDRESS>start script 'DEBUG=au-demos-modular:* node src/server-node/bin/www'.
18 error This is most likely a problem with the aurelia-modular-demo package,
18 error not with npm itself.
18 error Tell the author that this fails on your system:
18 error     DEBUG=au-demos-modular:* node src/server-node/bin/www
18 error You can get their info via:
18 error     npm owner ls aurelia-modular-demo
18 error There is likely additional logging output above.
19 verbose exit [ 1, true ]

Howdy. What version of npm and node are you running with?

@fopsdev Good afternoon. I just realized that the script is using a unix path:
DEBUG=au-demos-modular:* node src/server-node/bin/www

Try invoking node on the command line and put in the local windows path to ...\bin\www
Probably as easy as turning the forward slashes to back slashes

Let me know if you are still having issues.


dmp 2228 Add test

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-2228
Change description
Added test
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Probably not needed now


[Bug]: CodeAct Agent unable to execute command and write code when using ollama/llama3

Is there an existing issue for the same bug?

[X] I have checked the troubleshooting document at https://opendevin.github.io/OpenDevin/modules/usage/troubleshooting
[X] I have checked the existing issues.

Describe the bug
The tool is unable to actually perform the task eg, running commands and writing code when using a local model using ollama.
I've got ollama server running and have the llama3 8b pulled locally. I was successfully able to run OpenDevin while using llama3 through ollama.
But unlike when I tried with OpenAI GPT-4o which could actually perform commands like npm init -y etc, model through ollama is unable to perform actual task and write the code. All it does is suggest everything.
Probably an issue with function calling or planning I am not sure. I've attached below screenshots, if it helps.

Ask OpenDevin to write a node js application for a user management service in node js and express js using mysql2

Logs, Errors, Screenshots, and Additional Context

Unfortunately llama3 8b is too weak for CodeActAgent (and likely any other agent) to work properly... For now please use GPT-4 or any other LLM that is near as powerful as it.
Stay tuned, the community might fine-tune a small model in the future.

https://github.com/OpenDevin/OpenDevin/issues/1981#issuecomment-2130783340

@arjun-mavonic going to close this based on li-boxuan's comment. Feel free to reopen if you feel otherwise.

Thank you. Yes it does work with GPT 4o. But the cost is very high. I'll look into more powerful open source model which I can run on a bigger GPU and also fine tune it.

#1981 (comment)

Did you modify the prompt?


Facing problem when I try to echange DOW_30_TICKER to SSE_50_TICKER

Hello:
May I ask a question when I try to change the data environment from Dow 30 to SSE 50, I face the following question:
model = agent.train_SAC(model_name = "SAC_{}".format(now), model_params = sac_params_tuning)
Traceback (most recent call last):
File "", line 1, in
model = agent.train_SAC(model_name = "SAC_{}".format(now), model_params = sac_params_tuning)
File "/home/liuyimo/Downloads/FinRL-Library-master_a/finrl/model/models.py", line 136, in train_SAC
model.learn(total_timesteps=model_params['timesteps'], tb_log_name = "SAC_run")
File "/home/liuyimo/anaconda3/lib/python3.7/site-packages/stable_baselines/sac/sac.py", line 378, in learn
obs = self.env.reset()
File "/home/liuyimo/anaconda3/lib/python3.7/site-packages/stable_baselines/common/base_class.py", line 1104, in reset
return self.unvec_obs(self.venv.reset())
File "/home/liuyimo/anaconda3/lib/python3.7/site-packages/stable_baselines/common/vec_env/dummy_vec_env.py", line 62, in reset
self._save_obs(env_idx, obs)
File "/home/liuyimo/anaconda3/lib/python3.7/site-packages/stable_baselines/common/vec_env/dummy_vec_env.py", line 92, in _save_obs
self.buf_obs[key][env_idx] = obs
ValueError: cannot copy sequence with size 255 to array axis with dimension 355
When I run the Dow 30, everything goes fine. I tray to detect the reason behind this error, but I don't know where this '255' coming from? Is there any help for that? Thanks a lot

This is a good issue. I guess maybe some code has set fix values, I did not find it yet.  Would you like to join the slack channel for more discussions?

Sure, is there any link to join?

Please check out the top section in the readme file. Thx.

It seems I empirically found that the reason - stocks may have different length, check your data and or START_DATE

It seems I empirically found that the reason - stocks may have different length, check your data and or START_DATE

May I ask the future question: what if I change the stock collections to more than 30 stocks? Thanks a lot

It seems I empirically found that the reason - stocks may have different length, check your data and or START_DATE

May I ask the future question: what if I change the stock collections to more than 30 stocks? Thanks a lot

Please pay attention to the size of variables;  I think this issue is fixed (previously there was a hardcoded value of 61).

It seems I empirically found that the reason - stocks may have different length, check your data and or START_DATE

May I ask the future question: what if I change the stock collections to more than 30 stocks? Thanks a lot

Please pay attention to the size of variables; I think this issue is fixed (previously there was a hardcoded value of 61).

OK, Thanks a lot


Make dependancy adal optional

Fixes issue :kubernetes-client/python/issues#645
To fix this issue:

remove adal from requirements
add adal to extras_require in setup.py
handle import error

Fix for 1 and 2 is kubernetes-client/python/pull#668

/cc @tomplus @roycaihw @dims

Codecov Report

Merging #108 into master will decrease coverage by 0.3%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   92.04%   91.74%   -0.31%
==========================================
  Files          13       13
  Lines        1182     1187       +5
==========================================
+ Hits         1088     1089       +1
- Misses         94       98       +4

Impacted Files
Coverage Δ

config/kube_config.py
83.22% <11.76%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c242ea...cfae0d6. Read the comment docs.

BTW, there is a similar PR: https://github.com/kubernetes-client/python-base/pull/101

Per our slack discussion on Oct 31st, I asked you if you wanted to hand over the issue and you said yes. That was why I started to work on it and opened a PR.
If you want to work on it again, go straight ahead. I don’t mind - to me reviewing is just important as submitting a fix. However in the future please remember what you have said so that this situation does not happen any more.

Per our slack discussion on Oct 31st, I asked you if you wanted to hand over the issue and you said yes. That was why I started to work on it and opened a PR.

Yes @micw523 you asked me the issue you were working on but I think you are confusing this issue with another one you asked for
This is the issue you were working on " Loading yaml file "

If you want to work on it again, go straight ahead. I don’t mind - to me reviewing is just important as submitting a fix. However in the future please remember what you have said so that this situation does not happen any more.

Please never start working on any issue without assigning yourself on that issue. I would have stopped working on it if you mentioned that you are working on it.
If you still want to work on it please assign yourself to that issue and I'm happy to help you with the issue :)

@iamneha @micw523 i left a note in https://github.com/kubernetes-client/python-base/pull/101


Add a favicon

Have bookmarked this page... it would be nice to have a favicon

Yeah? Got an icon in mind?

Chtagpt suggested this:


Fix testnet/mainnet config to reflect the correct celes/uceles units

Currently, our deployment of big dipper uses celes and uceles interchangeably. This is due to a confusion in the devnet-2 genesis file generation, where the units are not properly defined.
In upcoming networks, we will have a correct genesis and thus the configuration under src/configs should be updated to reflect that change.

done

Can you please  open a PR to this repo containing this change ?


⚡ Add date in historical_data response

✨ Features

Add date key-value pair in historical_data's output

🔗 Linked Issue
#8
🧪 Tests

[X] Did you implement unit tests if required?

If the above checkbox is checked, describe how you unit tested it.
Add value in the list for the assertion to pass, so that when historical_data's output keys are checked, date is checked too, otherwise the unit tests will fail.

Hey @alvarobartt, Just to mention, I haven't seen  the date added to the latest update. Thanks

Hi @OGsiji  can you please check the latest investiny release? Install it with pip install investiny --upgrade please, thanks!


enlarge max  message size from 4MB to a big enough number like INT_MAX

Is your feature request related to a problem? Please describe.
When the request protobuf object or the return protobuf object is larger than the grpc default max message size (4MB), it will raise ResourceExhausted error.

Describe the solution you'd like
In cpp, the max message size can be set in client ChannelArguments:

Hello I believe this should be addressed in 0.53.0.


USE_DATA_CLASS: False positive for Annotations

I have this annotation:
@Retention(AnnotationRetention.SOURCE)
@Target(AnnotationTarget.CLASS)
annotation class NavGraphDestination(
    val name: String = Defaults.NULL,
    val routePrefix: String = Defaults.NULL,
    val deepLink: Boolean = false,
) {
    object Defaults {
        const val NULL = "@null"
    }
}

And Diktat complains that
There are 1 unfixed errors:
Error on line: 3, column: 1 cannot be fixed automatically
[USE_DATA_CLASS] this class can be converted to a data class: NavGraphDestination
java.lang.AssertionError: There are 1 unfixed errors:

I guess that the DataClassesRule should check if a class is an annotation, beside checking for data class and interface:
https://github.com/saveourtool/diktat/blob/54c8ccefc3009b8dd2a493c30590168318765b89/diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter6/classes/DataClassesRule.kt#L46
I'm having this with Diktat 1.2.1. Let me know if you need more info.

Hey, yeah, nice catch, thank you!
We completely forgot about that 🤦
We are already fixing this rule in https://github.com/saveourtool/diktat/issues/1444 and we will fix this one also in 1.2.2 release.
Thank you very much for this report :)

By for now you can easily @Suppress this inspection

fixed in #1471


107 fix security issue with scipy v193 in v0.9.x

Description
Merging scipy v193 fix into v0.9.x
[Provide a brief description of the changes or features introduced by this pull request.]
Motivation and Context
Fixing existing issues in v0.9.x where Models such as Light GBM and XGBoost are not working
[Explain the motivation or the context behind this pull request. Why is it necessary?]
Type of Change

fix: A bug fix

How to Test
[Provide clear instructions on how to test and verify the changes introduced by this pull request, including any specific unit tests you have created to demonstrate your changes.]
Checklist
Please check all the boxes that apply to this pull request using "x":

[x]  I have tested the changes locally and verified that they work as expected.
[ ]  I have added or updated the necessary documentation (README, API docs, etc.).
[ ]  I have added appropriate unit tests or functional tests for the changes made.
[ ]  I have followed the project's coding conventions and style guidelines.
[ ]  I have rebased my branch onto the latest commit of the main branch.
[ ]  I have squashed or reorganized my commits into logical units.
[ ]  I have added any necessary dependencies or packages to the project's build configuration.
[ ]  I have performed a self-review of my own code.
[x]  I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)
[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]
Additional Notes
[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

Emergency PR. Fast Tracked.

Models are able to upload and validated.
XGB.sav

LGB.sav

LR.sav

RF.sav


Add health and readiness checks to hnc-controller-manager

I am working on a project where we use HNC as a sub-component. The project ships and installs via Helm. For now, we create our own HNC Helm chart from the provided resources and use this Helm chart as a dependency for our project.
The validating webhook causes us some grief, especially since version 0.8.0 (maybe some code changes increased startup-time of the webhook service in the manager). The problem is described in Helm issue https://github.com/helm/helm/issues/10023. The chart resources are installed fine and HNC, as well as our project, is working fine, however, the Helm release status is stuck on pending-install. The reason is that directly after installing all resources, Helm tries to update the Secret containing the Helm release information. At this time the validating webhook is not responding to request yet and the release update operation fails.
The error looks like this:
install.go:387: [debug] failed to record the release: update: failed to update: Internal error occurred: failed calling webhook "objects.hnc.x-k8s.io": Post "https://hnc-webhook-service.hnc-system.svc:443/validate-objects?timeout=2s": dial tcp <IP_ADDRESS>:443: connect: connection refused

I think Helm should retry the update operation for some time, but I also think that the window in which this problem can occur could be minimized if there were a readiness probe for the manager.
I had a quick look at the code and it seems controller-runtime is used for implementing the webhook. There seems to be no easy way to expose a health/readiness check in the library. I've seen that there is an issue for that I controller-runtime - https://github.com/kubernetes-sigs/controller-runtime/issues/723. There is also a PR already merged - https://github.com/kubernetes-sigs/controller-runtime/pull/1588. The feature is scheduled for release 0.10.x of controller-runtime. Once this release is out, it might make sense to upgrade controller-runtime and expose the check.

This sounds like a useful and sensible change to make, thanks! Please ping
us when controller-runtime 0.10 is out if we forget.
On Fri, Aug 13, 2021 at 5:10 AM Hardy Ferentschik @.***>
wrote:

I am working on a project where we use HNC as a sub-component. The project
ships and installs via Helm. For now, we create our own HNC Helm chart from
the provided resources and use this Helm chart as a dependency for our
project.
The validating webhook causes us some grief, especially since version
0.8.0 (maybe some code changes increased startup-time of the webhook
service in the manager). The problem is described in Helm issue
helm/helm#10023 https://github.com/helm/helm/issues/10023. The chart
resources are installed fine and HNC, as well as our project, is working
fine, however, the Helm release status is stuck on pending-install. The
reason is that directly after installing all resources, Helm tries to
update the Secret containing the Helm release information. At this time the
validating webhook is not responding to request yet and the release update
operation fails.
The error looks like this:
install.go:387: [debug] failed to record the release: update: failed to update: Internal error occurred: failed calling webhook "objects.hnc.x-k8s.io": Post "https://hnc-webhook-service.hnc-system.svc:443/validate-objects?timeout=2s": dial tcp <IP_ADDRESS>:443: connect: connection refused
I think Helm should retry the update operation for some time, but I also
think that the window in which this problem can occur could be minimized if
there were a readiness probe for the manager.
I had a quick look at the code and it seems controller-runtime is used for
implementing the webhook. There seems to be no easy way to expose a
health/readiness check in the library. I've seen that there is an issue for
that I controller-runtime - kubernetes-sigs/controller-runtime#723
https://github.com/kubernetes-sigs/controller-runtime/issues/723. There
is also a PR already merged - kubernetes-sigs/controller-runtime#1588
https://github.com/kubernetes-sigs/controller-runtime/pull/1588. The
feature is scheduled for release 0.10.x of controller-runtime. Once this
release is out, it might make sense to upgrade controller-runtime and
expose the check.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/hierarchical-namespaces/issues/68,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE43PZBJWZ4XHS6SFHRT5GLT4TORZANCNFSM5CDGBZUQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hi @adrianludwin  and @hferentschik 👋🏼
I guess we need not necessarily wait for upstream controller-runtime for exposing a healthz endpoint and configuring liveness and readyness probes over hnc.
I just hovered over the code and found that it would be a pretty small addition, somewhere on the lines of:

In the cmd/manager/main.go, somewhere I can get the WebhookServer with mgr.GetWebhookServer()
And, I can register an http handler to it at /healthz just like the way, admission http handlers are registered here
This will ensure that at port 9443 (the webhook server's port), a /healthz endpoint will be available to serve a static health check by returning a 200 everytime its reached.
Finally, this can be utilised to write the corresponding liveness and readiness probe.

Seems pretty simple and straightforward but I'd love to hear your views :)
PS: if you think that the above idea is valid and this issue can be resolved, I'd love to pick this issue up and quickly sort it out :)

I guess we need not necessarily wait for upstream controller-runtime for exposing a healthz endpoint and configuring liveness and readyness probes over hnc.

Sure, this was just a suggestion. I am also not so familiar with the codebase, so I was not aware of whether there are other options. I only knew that the operator sdk did not offer this (a shortcoming I ran into myself before) and that there is an open issue for that on the operator sdk side.
What you are describing makes sense. It probably is a step forward either way. What I am wondering is about the sematics. Will this healthz/ready check for example really be coupled to whether the actual webhook is accepting requests?
But as said, better as nothing imo.

Will this healthz/ready check for example really be coupled to whether the actual webhook is accepting requests?

That's a good question. I feel that the check you are describing is more of a synthetic monitoring check rather than a static health check. So, I don't see a straightforward way to have such a health-check to ensure both that the webhook server is running AND it is successfully accepting the admission requests it is supposed to accept. Nonetheless, I am not at all denying the use of it :)
Yet, I believe that the health-check I described would at least fairly suffice for the setup of liveness and readiness probes coz that check would atleast confirm the "existence" of the webhook server in the sense that there is something running at 9443 and that thing in reality is the webhook server. And that at least is, as you mentioned, fairly better than nothing for the probes.
Many of the tools I have worked with make use of such kinds of static health-checks to determine the health of their services for their liveness and readiness probes.
So, I would suggest moving ahead with the static health-check I described, for now and establish a readiness and a liveness probe over it :)
What do you think @adrianludwin :)

So it turns out that controller-runtime 0.10.1 is already out, so I'd be in favour of just updating and getting it for free :) Why don't I quickly do that.
Well. I'm not actually sure if you get it for free, e.g. I don't know if there's someone we need to do to take advantage of this new feature. But that still seems easier than building it from scratch.
wdyt?

I'm working on https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/84 to upgrade to controller-runtime 1.10 but it's blocked on another change. Hopefully it'll be unblocked soon.

Ok #84 is merged, so we're on controller-runtime 0.10.1 now. What else do we need to do to make this work?

After enabling the readiness/liveness probe endpoint within the cmd/manager/main.go, you could declare the corresponding readiness/liveness probes within the Deployment at config/manager/manager.yaml.
However, please note that this might conflict with the leader election mechanism during updates: when an update is complete only if the readiness probe becomes complete when the leader has been elected, an update will never complete if the previous Pod still exists and is the leader. To avoid this, I think you need to set the update strategy within the manager Deployment resource to Recreate.


Static pods changes are not always picked up during a cluster upgrade

@dkoshkin I believe we diagnosed and fixed this issue in https://github.com/apprenda/kismatic/issues/702. The problem was that new kubelets were unable to talk to the API server due to RBAC being disabled in the pre-upgrade API servers.
Can you confirm this issue is in relation to that?

I opened this issue when it was originally opened on our slack, this in fact the same as #702 and closed with #703.


langfuse_filter_pipeline.py 'str' object has no attribute 'get'

langfuse_filter_pipeline.py is error
'str' object has no attribute 'get'

This is a workaround, I have a self-hosted LangFuse instance and was running into the same error in the UI and in my docker container.
I uploaded this .py to open-webui and replaced it in the pipelines container folder as well: https://github.com/karaketir16/openwebui-langfuse/blob/master/example/langfuse_filter_pipeline.py

-- langfuse maintainer here
This is not an issue that we see across integrations, happy to help with resolution of this issue.

I got the same issue with latest pipelines using the v1.3 found here https://raw.githubusercontent.com/open-webui/pipelines/refs/heads/main/examples/filters/langfuse_filter_pipeline.py
it seems that the workaround is aiming at older version of the filter v1.1 https://raw.githubusercontent.com/karaketir16/openwebui-langfuse/refs/heads/master/example/langfuse_filter_pipeline.py
what ever was posted on the main repo as example then is not properly working with the latest langfuse

I looked around and it seems to be this line info = assistant_message.get("info", {})
the assistant message has not attribut info. only a string on message

@sao-coding can you check whether this issue is fixed with the latest version of the example?

I can confirm on my side already

awesome, glad that it works again. this was on me, broke this with my latest edit to the example. Now the token counts should be tracked correctly to support cost tracking in Langfuse for openwebui usage


Add ability to trim path from secret names

This attempts to fix #1067 (and perhaps #975) by introducing a new conversionStrategy: TrimPath. Assuming you have the following SSM parameters
/some/ssm/path/KEY1
/some/ssm/path/KEY2
/some/ssm/path/KEY3

You can generate a secret without the path i.e.
data:
  KEY1: ...
  KEY2: ...
  KEY3: ...

with the following ExternalSecret
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: example
spec:
  refreshInterval: 1h
  secretStoreRef:
    name: secretstore-sample
    kind: SecretStore
  target:
    name: secret-to-be-created
    creationPolicy: Owner
  dataFrom:
  - find:
      path: /some/ssm/path/
      conversionStrategy: TrimPath
      name:
        regexp: '.*'

Hi @ThisIsQasim! thank you for your interest in the project!
Unfortunately, I don't believe this wouldn't be a good solution as some of the providers do not use / to separate the path, hence becoming a very AWS specific feature.
One of the ideas we had for #975 was to use regular expression groups to allow the rewrite to happen in any situation.
IMO, I think this pattern can indeed happen only when the ConversionStrategy is for a given type Custom or something like that.
Would mind changing this PR to follow the idea of capture groups? It would include a change to the CRD to add a new regular expression field.

Hi @gusfcarvalho! Yeah I agree this is not the best implementation but I wasn't sure if adding another conversion layer was a good idea.
Your proposed solution is a little out of league because of my limited knowledge of golang but I'll give it a try.

Feel free to ask me in kubernetes slack! I'm @gusfcarvalho there :). I can help you out whenever things seems blurry.

@ThisIsQasim FYI https://github.com/external-secrets/external-secrets/pull/1188

Hi @gusfcarvalho!

In today's community meeting we discussed about this feature and we decided to prioritize it. Although, before actually coding this feature we wanted to properly spec it out just to see if we are missing some edge cases. We would like to know if you want to join in both for the specification and for the feature development as well 😄

That is great to know.
The initial design looks good to me. Unfortunately I don't have the time or skills to implement the desired spec so I'll be happy to let others take over.


Profile page in edit after sign in

The user should be shown all fields in edit mode when the user has newly signed in.
Right now the fields are in read mode.

If a newly signed in user lands on the profile page and does a reload, the profile page should still be in edit mode or not ?

That is actually a good question. I would say yes.
Since we would want to get the basic information about the user, that would help the interviewer understand what kind of question they can ask the interviewee as the interviewee does not share any other information about them. So if they want to visit the interviewee's profile, they should be able to see their basic info.
We would need the interviewee's basic info before they can book an interview.