Error while login using Azure CLI

getting an error while login using azure CLI.
http://localhost:8400/?error=invalid_request&error_description=AADSTS50139%3A+Session+is+invalid+due+to+missing+an+external+refresh+token.
Trace+ID%3A+47ad116e-1a0f-42e2-9758-f411768b5500
Correlation+ID%3A+1f97f37c-d254-4852-8139-90b4090cb030
Timestamp%3A+2021-01-10+11%3A04%3A34Z&state=t7swwkg5ei86w4axv2ps#

PS C:\Users\Prathmesh Bembalkar> az login
The default web browser has been opened at https://login.microsoftonline.com/common/oauth2/authorize. Please continue the login in the web browser. If no web browser is available or if the web browser fails to open, use device code flow with az login --use-device-code.
Authentication Error: "['invalid_request']". Description: "['AADSTS50139: Session is invalid due to missing an external refresh token.\r\nTrace ID: 47ad116e-1a0f-42e2-9758-f411768b5500\r\nCorrelation ID: 1f97f37c-d254-4852-8139-90b4090cb030\r\nTimestamp: 2021-01-10 11:04:34Z']"
Login failed

az login

az login

any update?

any update?

@bembalkp could you run az login --debug and share the output?

@bembalkp could you run az login --debug and share the output?

I have same issue with login after authorization in Azure Stack via az login.

I have same issue with login after authorization in Azure Stack via az login.

Authentication Error: "['invalid_request']". Description: "['AADSTS50139: Session is invalid due to missing an external refresh token.\r\nTrace ID: 517dcfab-91f7-49b4-b1b5-6d87e9c11900\r\nCorrelation ID: 1858ffc3-8e16-4b82-97c8-9e4948344f12\r\nTimestamp: 2021-01-15 11:53:05Z']"
azure.cli.core.util.handle_exception is called with an exception:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-rpp6y7vh\knack\cli.py", line 215, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 659, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 722, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 715, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-igh1xymj\six.py", line 703, in reraise
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 693, in run_jobAuthentication Error: "['invalid_request']". Description: "['AADSTS50139: Session is invalid due to missing an external refresh token.\r\nTrace ID: 517dcfab-91f7-49b4-b1b5-6d87e9c11900\r\nCorrelation ID: 1858ffc3-8e16-4b82-97c8-9e4948344f12\r\nTimestamp: 2021-01-15 11:53:05Z']"
azure.cli.core.util.handle_exception is called with an exception:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-rpp6y7vh\knack\cli.py", line 215, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 659, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 722, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 715, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-igh1xymj\six.py", line 703, in reraise
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 693, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 330, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_init_.py", line 784, in default_command_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-wcxsakwf\azure\cli\command_modules\profile\custom.py", line 162, in login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 197, in find_subscriptions_on_login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 871, in find_through_authorization_code_flow
knack.util.CLIError: Login failed
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 330, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_init_.py", line 784, in default_command_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-wcxsakwf\azure\cli\command_modules\profile\custom.py", line 162, in login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 197, in find_subscriptions_on_login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 871, in find_through_authorization_code_flow
knack.util.CLIError: Login failed

Authentication Error: "['invalid_request']". Description: "['AADSTS50139: Session is invalid due to missing an external refresh token.\r\nTrace ID: 517dcfab-91f7-49b4-b1b5-6d87e9c11900\r\nCorrelation ID: 1858ffc3-8e16-4b82-97c8-9e4948344f12\r\nTimestamp: 2021-01-15 11:53:05Z']"
azure.cli.core.util.handle_exception is called with an exception:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-rpp6y7vh\knack\cli.py", line 215, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 659, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 722, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 715, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-igh1xymj\six.py", line 703, in reraise
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 693, in run_jobAuthentication Error: "['invalid_request']". Description: "['AADSTS50139: Session is invalid due to missing an external refresh token.\r\nTrace ID: 517dcfab-91f7-49b4-b1b5-6d87e9c11900\r\nCorrelation ID: 1858ffc3-8e16-4b82-97c8-9e4948344f12\r\nTimestamp: 2021-01-15 11:53:05Z']"
azure.cli.core.util.handle_exception is called with an exception:
Traceback (most recent call last):
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-rpp6y7vh\knack\cli.py", line 215, in invoke
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 659, in execute
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 722, in run_jobs_serially
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 715, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-igh1xymj\six.py", line 703, in reraise
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 693, in run_job
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init.py", line 330, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_init_.py", line 784, in default_command_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-wcxsakwf\azure\cli\command_modules\profile\custom.py", line 162, in login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 197, in find_subscriptions_on_login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 871, in find_through_authorization_code_flow
knack.util.CLIError: Login failed
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core\commands_init_.py", line 330, in call
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_init_.py", line 784, in default_command_handler
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-wcxsakwf\azure\cli\command_modules\profile\custom.py", line 162, in login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 197, in find_subscriptions_on_login
File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-unpacked-wheel-34tyr6f2\azure\cli\core_profile.py", line 871, in find_through_authorization_code_flow
knack.util.CLIError: Login failed

What helped me:

Delete all clouds information except main subscription from file C:\Users\username.azure*clouds.config*
Delete cache file from this folder C:\Users\username.azure\

What helped me:

Delete all clouds information except main subscription from file C:\Users\username.azure*clouds.config*
Delete cache file from this folder C:\Users\username.azure\

@dmitriyteteruk, this is weird. If the cloud is not activated via az cloud set, it won't be used in any way. CLI should authenticate against https://login.microsoftonline.com/ as usual.
@bembalkp, are you using the public AzureCloud or any Azure Stack cloud? Have you changed anything under C:\Users\username\.azure?

@dmitriyteteruk, this is weird. If the cloud is not activated via az cloud set, it won't be used in any way. CLI should authenticate against https://login.microsoftonline.com/ as usual.
@bembalkp, are you using the public AzureCloud or any Azure Stack cloud? Have you changed anything under C:\Users\username\.azure?

@dmitriyteteruk, this is weird. If the cloud is not activated via az cloud set, it won't be used in any way. CLI should authenticate against https://login.microsoftonline.com/ as usual. In your case, are you using an ADFS account on https://login.microsoftonline.com/?
Yes, authentication always goes through https://login.microsoftonline.com/.
I am authenticated in browser in both accounts (Stack and Cloud).
In CLI I have added both clouds (AzureCloud and Stack).
I faced with this issue second time this week when need to switch in CLI from Stack to AzureCloud. If I not change Stack to AzureCloud using az cloud set -n Name then I get error after az login

@dmitriyteteruk, this is weird. If the cloud is not activated via az cloud set, it won't be used in any way. CLI should authenticate against https://login.microsoftonline.com/ as usual. In your case, are you using an ADFS account on https://login.microsoftonline.com/?
Yes, authentication always goes through https://login.microsoftonline.com/.
I am authenticated in browser in both accounts (Stack and Cloud).
In CLI I have added both clouds (AzureCloud and Stack).
I faced with this issue second time this week when need to switch in CLI from Stack to AzureCloud. If I not change Stack to AzureCloud using az cloud set -n Name then I get error after az login

@dmitriyteteruk,
The Azure Resource Management' resource ID will be sent in the initial
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=h4s32833xo1ve962o1ql
&resource=https://management.core.windows.net/  # Make sure this is from the correct target cloud
&prompt=select_account
&sso_reload=true

Authentication Error: "['access_denied']". Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in the requested permissions in the client's application registration. Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI). Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1. Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\nTrace ID: 452c6599-c799-47fd-814c-aca31cb00600\r\nCorrelation ID: 26e603d1-f6ae-4e5c-b042-ac810c17f0ea\r\nTimestamp: 2021-01-18 02:05:47Z"]"
Just want to double confirm: is your Azure Stack use AAD auth or ADFS auth. In other words, in cloud.config, what is the value of the endpoint_active_directory property of the Azure Stack:

AAD: https://login.microsoftonline.com/
ADFS: something like https://adfs.redmond.azurestack.corp.microsoft.com/adfs/

@dmitriyteteruk,
The Azure Resource Management' resource ID will be sent in the initial
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=h4s32833xo1ve962o1ql
&resource=https://management.core.windows.net/  # Make sure this is from the correct target cloud
&prompt=select_account
&sso_reload=true

Authentication Error: "['access_denied']". Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in the requested permissions in the client's application registration. Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI). Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1. Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\nTrace ID: 452c6599-c799-47fd-814c-aca31cb00600\r\nCorrelation ID: 26e603d1-f6ae-4e5c-b042-ac810c17f0ea\r\nTimestamp: 2021-01-18 02:05:47Z"]"
Just want to double confirm: is your Azure Stack use AAD auth or ADFS auth. In other words, in cloud.config, what is the value of the endpoint_active_directory property of the Azure Stack:

AAD: https://login.microsoftonline.com/
ADFS: something like https://adfs.redmond.azurestack.corp.microsoft.com/adfs/

@dmitriyteteruk, I think the root cause for the failure is that you are using unmatched AAD account for Azure Stack cloud.
In the initial /authorize request, resource field contains the ARM ID for the selected cloud.
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dinlzewoozmv1djziynk
&resource=https://management.core.windows.net/  # ARM resource ID
&prompt=select_account

When an unmatched account is used, error like this may occur. @bembalkp, could you kindly check the same?
Too long; Don't read
However, when I tested with my account which doesn't have access to Azure Stack:
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dyxifurdy7tn681qw50u
&resource=https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1  # ARM resource ID of Azure Stack
&prompt=select_account
&sso_reload=true

I got:
Authentication Error: "['access_denied']".
Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in
  the requested permissions in the client's application registration.
Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI).
Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1.
Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\n
...

It seems the actual error message depends on AAD tenant/Azure Stack settings. Anyway, selecting the correct cloud is always a necessary task before logging in.

@dmitriyteteruk, I think the root cause for the failure is that you are using unmatched AAD account for Azure Stack cloud.
In the initial /authorize request, resource field contains the ARM ID for the selected cloud.
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dinlzewoozmv1djziynk
&resource=https://management.core.windows.net/  # ARM resource ID
&prompt=select_account

When an unmatched account is used, error like this may occur. @bembalkp, could you kindly check the same?
Too long; Don't read
However, when I tested with my account which doesn't have access to Azure Stack:
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dyxifurdy7tn681qw50u
&resource=https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1  # ARM resource ID of Azure Stack
&prompt=select_account
&sso_reload=true

I got:
Authentication Error: "['access_denied']".
Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in
  the requested permissions in the client's application registration.
Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI).
Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1.
Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\n
...

It seems the actual error message depends on AAD tenant/Azure Stack settings. Anyway, selecting the correct cloud is always a necessary task before logging in.

@dmitriyteteruk, I think the root cause for the failure is that you are using unmatched AAD account for Azure Stack cloud.
In the initial /authorize request, resource field contains the ARM ID for the selected cloud.
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dinlzewoozmv1djziynk
&resource=https://management.core.windows.net/  # ARM resource ID
&prompt=select_account

When an unmatched account is used, error like this may occur. @bembalkp, could you kindly check the same?
Too long; Don't read
However, when I tested with my account which doesn't have access to Azure Stack:
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dyxifurdy7tn681qw50u
&resource=https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1  # ARM resource ID of Azure Stack
&prompt=select_account
&sso_reload=true

I got:
Authentication Error: "['access_denied']".
Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in
  the requested permissions in the client's application registration.
Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI).
Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1.
Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\n
...

It seems the actual error message depends on AAD tenant/Azure Stack settings. Anyway, selecting the correct cloud is always a necessary task before logging in.

I am choosing right account in pop login browser window. Until I change cloud that I want to az login with command az cloud set --name Azure I am getting error.
Looks below on screenshots.

I am logged in to Stack account

I want to switch to Azure account using az login

Getting error: Authentication Error: "['access_denied']". Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in the requested permissions in the client's application registration. Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI). Resource value from request: https://management.iurnvgru.onmicrosoft.com/97a61497-2338-4b3d-9a11-cbaaae5191da. Resource app ID: faf7681b-619f-4d59-8655-43a40b5ad363. List of valid resources from app registration: .\r\nTrace ID: 81dd37b0-50f9-48bb-85f2-e23032d30000\r\nCorrelation ID: 9e095169-20cd-461b-b431-5ae733640e63\r\nTimestamp: 2021-01-18 06:42:47Z"]" Login failed

to avoid this error I need to change cloud using az cloud set --name Name and change Azure to Stack and back before use az login. Not sure if this behavior is correct.

@dmitriyteteruk, I think the root cause for the failure is that you are using unmatched AAD account for Azure Stack cloud.
In the initial /authorize request, resource field contains the ARM ID for the selected cloud.
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dinlzewoozmv1djziynk
&resource=https://management.core.windows.net/  # ARM resource ID
&prompt=select_account

When an unmatched account is used, error like this may occur. @bembalkp, could you kindly check the same?
Too long; Don't read
However, when I tested with my account which doesn't have access to Azure Stack:
https://login.microsoftonline.com/common/oauth2/authorize
?response_type=code
&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46
&redirect_uri=http://localhost:8400
&state=dyxifurdy7tn681qw50u
&resource=https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1  # ARM resource ID of Azure Stack
&prompt=select_account
&sso_reload=true

I got:
Authentication Error: "['access_denied']".
Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in
  the requested permissions in the client's application registration.
Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI).
Resource value from request: https://management.masselfhost.onmicrosoft.com/0f237931-e2a3-402d-a489-686a4cb547c1.
Resource app ID: 84d205b6-b275-47cb-9270-94e861521c99. List of valid resources from app registration: .\r\n
...

It seems the actual error message depends on AAD tenant/Azure Stack settings. Anyway, selecting the correct cloud is always a necessary task before logging in.

I am choosing right account in pop login browser window. Until I change cloud that I want to az login with command az cloud set --name Azure I am getting error.
Looks below on screenshots.

I am logged in to Stack account

I want to switch to Azure account using az login

Getting error: Authentication Error: "['access_denied']". Description: "["AADSTS650057: Invalid resource. The client has requested access to a resource which is not listed in the requested permissions in the client's application registration. Client app ID: 04b07795-8ddb-461a-bbee-02f9e1bf7b46(Microsoft Azure CLI). Resource value from request: https://management.iurnvgru.onmicrosoft.com/97a61497-2338-4b3d-9a11-cbaaae5191da. Resource app ID: faf7681b-619f-4d59-8655-43a40b5ad363. List of valid resources from app registration: .\r\nTrace ID: 81dd37b0-50f9-48bb-85f2-e23032d30000\r\nCorrelation ID: 9e095169-20cd-461b-b431-5ae733640e63\r\nTimestamp: 2021-01-18 06:42:47Z"]" Login failed

to avoid this error I need to change cloud using az cloud set --name Name and change Azure to Stack and back before use az login. Not sure if this behavior is correct.

Selecting the account in the browser won't automatically switch the cloud. The account that is selected in the browser must match the cloud that is set via az cloud set.

Selecting the account in the browser won't automatically switch the cloud. The account that is selected in the browser must match the cloud that is set via az cloud set.


add python-backports-lzma as a Requirement for py2 in spec file

When trying to install a git snapshot build of atomic-reactor, the installation works with yum but running atomic-reactor fails with the following because python-backports-lzma is missing on the system:
# atomic-reactor
Traceback (most recent call last):
  File "/usr/bin/atomic-reactor", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 3007, in <module>
    working_set.require(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 728, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 626, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: backports.lzma

LGTM


fix: allow users to override GOVERSION

fixes https://github.com/google/osv-scanner/issues/848.
Allow users to specify a GOVERSION other than the one in go.mod .
Usage: in cmd, export GOVERSION=go1.22.0

Codecov Report
Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.04%. Comparing base (b28c1c8) to head (1222f90).
Report is 22 commits behind head on main.

Files
Patch %
Lines

internal/sourceanalysis/go.go
25.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
+ Coverage   59.78%   61.04%   +1.25%
==========================================
  Files         136      143       +7
  Lines       11268     9143    -2125
==========================================
- Hits         6737     5581    -1156
+ Misses       4102     3084    -1018
- Partials      429      478      +49

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Initial log line formats commit id and commit date wrongly

Looking at the initial log line of elemental-operator, I see
Operator version [1.1.3 e1be30f1 20230223], commit %!s(MISSING), commit date %!s(MISSING)

because both MISSING values are actually present within the log line.

Looks nice now 🥳
Operator version 1.1.3, commit 6ddca9f1, commit date 20230224


Octokit::BadGateway 502 - Server Error

For PRs with many linting violations, it seems that the GitHub API is choking using the github_pull_request_review_formatter. Should there be a maximum payload size?

Yeah, so I just confirmed that reducing the payload of this particular payload allowed the PR review from pronto to go through. I'm not sure if this is the number of comments, or if there's a particular file with too many comments. I'm not entirely sure how to debug this any further though because the 502 error from GitHub is pretty opaque.

(I contacted GitHub support about this—will report back if I hear anything.)

This is what I got back:

I think you can configure the maximum number of offenses to report back to Github since this PR: https://github.com/prontolabs/pronto/pull/127
Maybe try dialing that down?

Ah good call. I think I'll close this as it's not clear what we can do on the pronto side to change this. Perhaps Github (and thus octokit) will impose payload limits in which case pronto may need to adjust its use of octokit... but until then we can't really do anything.

This is still an issue as I first installed pronto today. And the comment threshold seemed to be < 150
I'm using a personal API token for a company repo, is that why ? It finally went through for 18 comments though...


Remove ineligible repo

I removed a link related to an ineligible repository for Hactoberfest 2019

@OtacilioN sir please review pull request.

@OtacilioN please review my PR.


Changing ldap server when editing LDAP settings , results in no admin user being available.

Rancher versions:v1.6.8-rc1
Steps to reproduce the problem:
Have LDAP auth enabled setup.
In "Admin/Access Control", use "Edit" option to change the "Hostname" to point to a different LDAP server.
Use "Test and Save" to test and commit the changes to configuration.
Once "Test and Save" is done , user to brought back to the log in page.
When u try log as the admin user (user used for "Test and Save" ) , he is not the admin user anymore.
Seems like a new user gets created when log in was attempted.
Follow up questions:

Should we not allow for ""Hostname" to be changed as part of "Edit" option
Should the UI force the same admin user to be used for ""Test and Save".

Root Cause of why there is no admin user available:
When Auth settings are changed via "Edit Settings" only API calls made are: POST /v1-auth/testlogin and POST /v1-auth/config - these are to test the settings with the user/pwd provided and then save the config respectively.
Here there is no API call to login the test user or create an account for that user. We do not want to do that either as the intent of this feature is you are already logged in as an admin user and just editing some settings for the existing AD setup.
So now if you are changing the settings so that you start pointing to a new AD server althogether, you are in fact breaking your current access control setup and users created for the original AD server.
So I agree to both, that "Edit Settings" should not allow editing "Hostname" of AD server. And also forcing the test username to be same as the current logged in Admin and just asking for the password, will avoid any confusion as to whether we are creating a new account or not.

@prachidamle , Can we also evaluate if there is a potential downside to editing any other settings ? Currently UI allows for editing all fields.
Changing "User Search Base" (by making it more restrictive) can potentially cause existing users (including Admin) to be not able to log in. Is this something we need to make a note of in UI for user?

Changing "User Search Base" should still be allowed as an Admin can "expand" the base to include more users.
But restricting  "User Search Base" can lead to problems as you noted, we can document this/ put an info tip in UI. If we do the UI change to force the test username to be the current admin, testing with that user will break if user-base is restricted and that would avoid the problem.
But in any case it has to be noted in UI/docs that restricting  "User Search Base" can lead to problems. @deniseschannon

Is there the possibility of a local admin user account, which I could define upfront to make sure, that I can access my instance, even if the defined Auth Service is down or broken?
I think the current way would be to go into the DB and change a setting there, but this isnt the most convenient way.

@toughIQ no there currently is not support for that, but the feature request is captured here:
https://github.com/rancher/rancher/issues/8740

Tested with rancher versions:v1.6.8-rc3
Scenario 1:
Have LDAP auth enabled setup.
In "Admin/Access Control", use "Edit" option to change the "Hostname" to point to a different LDAP server.
Use "Test and Save" to test and commit the changes to configuration.
User is presented with following error message - "Mismatch in ExternalId of the Admin account, with new server settings"
Scenario 2:
Have LDAP auth enabled setup.
In "Admin/Access Control", use "Edit" option to make the user search base more restrictive such that the current admin user is not a valid user under this search base.
Use "Test and Save" to test and commit the changes to configuration.
User is presented with error message - "Cannot locate the user information with new server settings"
Scenario 3:
Have LDAP auth enabled setup.
In "Admin/Access Control", use "Edit" option to change the "Hostname" to point to a different LDAP server.
There is no ability provided in the UI for changing the username under "Test and save new configuration" page.


3.3.0 Release Date ???

@anidotnet
When you are planning to release 3.3.0 ???  if it's stable then can I build by my self ???

It is stable currently. No open issues. You can build it yourself.

I do not see branch or tag of 3.3.0 ??? do I need to use commit point to build 3.3.0 ???

master contains code for 3.3.0


Updated Python collections wrapper and passage retrieval setup

Updates to #645:

Fixed pyjnius type issues and file segment naming
Updated tokenizer and score aggregation code
Updated documentation and results

Thanks @zeynepakkalyoncu for the help! Just made some edits to address the comments, and added more docstrings overall.
For re-using the logger, did you mean across different modules? I believe that calling logger = logging.getLogger(__name__) within the package hierarchy is already doing this, but please correct me if I misunderstood?

@emmileaf do you sentences align with sentences from @zeynepakkalyoncu for birch? if so, great, if not, we should make them consistent, otherwise it will be difficult to match BERT scores with BM25 scores...

@emmileaf Yes, you are right - I thought the log file was repeated within the same directory, but what you have is fine. Looks good!

@emmileaf do you sentences align with sentences from @zeynepakkalyoncu for birch? if so, great, if not, we should make them consistent, otherwise it will be difficult to match BERT scores with BM25 scores...

@lintool  Right now they are not using the same code, but resulting sentences are mostly similar. I was able to do an approximate matching on the sentences to get a rough idea of score differences, but there are probably some sentences that don't exactly align (e.g. birch breaking up sentences greater than 512 chars, and likely other small inconsistencies).
For the sake of exact comparison, I'm thinking of defining something like split_sentence_birch in the tokenizer options here and try to replicate the birch sentence logic… but it would probably make sense to have it separate from this PR?

@emmileaf yes, separate PR makes sense...


Uncaught ReferenceError: installedChunks is not defined

Hi 😊
I've been trying webpack-external-import on a project with MinChunkSizePlugin and it would seem that using MinChunkSizePlugin and URLImportPlugin together may cause issues.
Indeed, if Webpack create only one chunk (because of a large minChunkSize value), I get this error:
Uncaught ReferenceError: installedChunks is not defined

I don't really know how Webpack works but the webpackJsonpCallback function is missing in the non-working version. So I think that Webpack can't load properly the external chunk 🤔
Hope it helps 😉

Likely messes with chunk splitting which is highly controlled under the hood of V2. Some thing just won’t work.
Webpack 5 has a rewritten version of this that we just finished up last week. https://github.com/mizx/mfe-webpack-demo


[PPP-3506][PPP-3533] pentaho-kettle: XXE Security Vulnerability in xml parsers

Applying security to parsing, centralising xml-factory creation in XMLUtils class.
Tests written
Checkstyle applied

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f core/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-xml-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-xml-plugin/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/pdi-pur-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/pdi-pur-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
core/src/org/pentaho/di/core/xml/XMLCheck.java
core/src/org/pentaho/di/core/xml/XMLHandler.java
core/src/org/pentaho/di/core/xml/XMLUtils.java
core/test-src/org/pentaho/di/core/xml/XMLCheckTest.java
core/test-src/org/pentaho/di/core/xml/XMLHandlerUnitTest.java
core/test-src/org/pentaho/di/core/xml/XMLUtilsTest.java
engine/src/org/pentaho/di/core/util/SerializationHelper.java
engine/src/org/pentaho/di/repository/RepositoriesMeta.java
engine/src/org/pentaho/di/repository/RepositoryExportSaxParser.java
engine/src/org/pentaho/di/trans/steps/webservices/WebService.java
engine/test-src/org/pentaho/di/core/util/SerializationHelperTest.java
engine/test-src/org/pentaho/di/repository/RepositoriesMetaTest.java
engine/test-src/org/pentaho/di/repository/RepositoryExportSaxParserTest.java
plugins/kettle-xml-plugin/src/org/pentaho/di/job/entries/dtdvalidator/DTDValidator.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/addxml/AddXML.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/xmljoin/XMLJoin.java
plugins/pdi-pur-plugin/src/com/pentaho/pdi/ws/RepositorySyncWebService.java
plugins/pdi-pur-plugin/src/com/pentaho/repository/importexport/PDIImportUtil.java
plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java
Unit test coverage change:
org.pentaho.di.core.exception.KettleXMLException:

Complexity Change :  + 25.00%
Instruction Change :  + 31.25%
Line Change :  + 25.00%
Method Change :  + 25.00%

org.pentaho.di.core.xml.DTDIgnoringEntityResolver:

Line Change : -15.00%

org.pentaho.di.core.xml.XMLCheck:

Complexity Change :  + 33.33%
Instruction Change :  + 37.78%
Line Change :  + 35.29%
Method Change :  + 33.33%

org.pentaho.di.core.xml.XMLCheck.XMLTreeHandler:

Complexity Change :  + 100.00%
Instruction Change :  + 100.00%
Line Change :  + 100.00%
Method Change :  + 100.00%

org.pentaho.di.core.xml.XMLHandler:

Branch Change :  + 2.05%
Complexity Change : -4.35%
Instruction Change : -1.96%
Line Change : -.63%
Method Change : -10.77%

org.pentaho.di.core.xml.XMLUtils:

Complexity New Coverage : 66.67%
Instruction New Coverage : 84.21%
Line New Coverage : 85.71%
Method New Coverage : 66.67%

org.pentaho.di.core.util.SerializationHelper:

Complexity Change :  + 2.44%
Instruction Change :  + 3.10%
Line Change :  + 3.36%
Method Change :  + 25.00%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent:

Branch Change : -1.01%
Complexity Change : -1.06%
Instruction Change : -.17%

org.pentaho.di.job.entries.getpop.MailConnectionMeta:

Branch Change :  + 1.00%
Complexity Change :  + 1.41%
Instruction Change :  + .30%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change : -1.64%
Complexity Change : -.69%
Instruction Change : -2.43%
Line Change : -3.70%

org.pentaho.di.repository.RepositoryExportSaxParser:

Complexity Change :  + 4.76%
Instruction Change :  + 3.18%
Line Change :  + 5.00%
Method Change :  + 12.50%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta:

Instruction Change : -.04%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta:

Instruction Change :  + .05%

org.pentaho.di.trans.steps.dbproc.DBProcMeta:

Instruction Change :  + .11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta:

Branch Change :  + .66%
Complexity Change :  + .41%
Instruction Change :  + .50%
Line Change :  + .24%

org.pentaho.di.trans.steps.groupby.GroupByMeta:

Branch Change :  + 2.08%
Complexity Change :  + 2.11%
Instruction Change :  + .28%
Line Change :  + .75%

org.pentaho.di.trans.steps.ifnull.IfNullMeta:

Branch Change : -2.00%
Complexity Change : -1.89%
Instruction Change : -.17%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta:

Branch Change :  + 2.35%
Complexity Change :  + 2.70%

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta:

Instruction Change :  + .14%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta:

Instruction Change : -.08%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Instruction Change : -.18%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta:

Branch Change : -3.33%
Complexity Change : -1.85%
Instruction Change : -.28%

org.pentaho.di.trans.steps.systemdata.SystemDataMeta:

Branch Change :  + 2.04%
Complexity Change :  + 2.04%
Instruction Change :  + .32%
Line Change :  + .81%

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta:

Branch Change : -.91%
Complexity Change : -.82%

org.pentaho.di.trans.steps.webservices.WebServiceMeta:

Branch Change : -1.79%
Complexity Change : -1.19%
Instruction Change : -.07%

com.pentaho.repository.importexport.PDIImportUtil:

Complexity Change :  + 28.57%
Instruction Change :  + 37.69%
Line Change :  + 39.74%
Method Change :  + 28.57%

Integration test coverage change:
org.pentaho.di.trans.step.BaseStep:

Branch Change : -.29%
Complexity Change : -.18%
Instruction Change : -.13%
Line Change : -.08%

License header violations:

Copyright year is not the current year on core/test-src/org/pentaho/di/core/xml/XMLHandlerUnitTest.java. Found 2015. Was expecting 2016
Copyright year is not the current year on plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java. Found 2015. Was expecting 2016

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java

Message: Using the '.' form of import should be avoided - org.junit.Assert.. at Line: 22

@mchen-len-son , could you please review it please?

Base build failed with return code 1

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f core/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-xml-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-xml-plugin/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/pdi-pur-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/pdi-pur-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
core/src/org/pentaho/di/core/xml/XMLCheck.java
core/src/org/pentaho/di/core/xml/XMLHandler.java
core/src/org/pentaho/di/core/xml/XMLUtils.java
core/test-src/org/pentaho/di/core/xml/XMLCheckTest.java
core/test-src/org/pentaho/di/core/xml/XMLHandlerUnitTest.java
core/test-src/org/pentaho/di/core/xml/XMLUtilsTest.java
engine/src/org/pentaho/di/core/util/SerializationHelper.java
engine/src/org/pentaho/di/repository/RepositoriesMeta.java
engine/src/org/pentaho/di/repository/RepositoryExportSaxParser.java
engine/src/org/pentaho/di/trans/steps/webservices/WebService.java
engine/test-src/org/pentaho/di/core/util/SerializationHelperTest.java
engine/test-src/org/pentaho/di/repository/RepositoriesMetaTest.java
engine/test-src/org/pentaho/di/repository/RepositoryExportSaxParserTest.java
plugins/kettle-xml-plugin/src/org/pentaho/di/job/entries/dtdvalidator/DTDValidator.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/addxml/AddXML.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/xmljoin/XMLJoin.java
plugins/pdi-pur-plugin/src/com/pentaho/pdi/ws/RepositorySyncWebService.java
plugins/pdi-pur-plugin/src/com/pentaho/repository/importexport/PDIImportUtil.java
plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java
Unit test coverage change:
org.pentaho.di.core.exception.KettleXMLException:

Complexity Change :  + 25.00%
Instruction Change :  + 31.25%
Line Change :  + 25.00%
Method Change :  + 25.00%

org.pentaho.di.core.xml.DTDIgnoringEntityResolver:

Line Change : -15.00%

org.pentaho.di.core.xml.XMLCheck:

Complexity Change :  + 33.33%
Instruction Change :  + 37.78%
Line Change :  + 35.29%
Method Change :  + 33.33%

org.pentaho.di.core.xml.XMLCheck.XMLTreeHandler:

Complexity Change :  + 100.00%
Instruction Change :  + 100.00%
Line Change :  + 100.00%
Method Change :  + 100.00%

org.pentaho.di.core.xml.XMLHandler:

Branch Change :  + 4.11%
Complexity Change :  + 4.35%
Instruction Change :  + 6.05%
Line Change :  + 5.40%
Method Change :  + 6.15%

org.pentaho.di.core.xml.XMLUtils:

Complexity New Coverage : 66.67%
Instruction New Coverage : 84.21%
Line New Coverage : 85.71%
Method New Coverage : 66.67%

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.core.util.SerializationHelper:

Complexity Change :  + 2.44%
Instruction Change :  + 3.10%
Line Change :  + 3.36%
Method Change :  + 25.00%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics:

Branch Change : -.39%
Complexity Change : -.51%
Instruction Change : -.08%

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent:

Branch Change : -1.01%
Complexity Change : -1.06%
Instruction Change : -.17%

org.pentaho.di.job.entries.getpop.MailConnectionMeta:

Branch Change : -1.00%
Complexity Change : -1.41%
Instruction Change : -.30%

org.pentaho.di.job.entries.sql.JobEntrySQL:

Instruction Change :  + 3.28%
Line Change :  + 3.87%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL:

Branch Change :  + .67%
Complexity Change :  + .94%
Instruction Change :  + .13%

org.pentaho.di.repository.RepositoryExportSaxParser:

Complexity Change :  + 4.76%
Instruction Change :  + 3.18%
Line Change :  + 5.00%
Method Change :  + 12.50%

org.pentaho.di.trans.steps.checksum.CheckSumMeta:

Branch Change : -1.32%
Complexity Change : -1.43%
Instruction Change : -.33%
Line Change : -.54%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta:

Branch Change : -.66%
Complexity Change : -.41%
Instruction Change : -.50%
Line Change : -.24%

org.pentaho.di.trans.steps.groupby.GroupByMeta:

Branch Change : -1.04%
Complexity Change : -1.05%
Instruction Change : -.14%
Line Change : -.37%

org.pentaho.di.trans.steps.ivwloader.IngresVectorwiseLoader:

Branch Change :  + .71%
Complexity Change :  + 1.14%
Instruction Change :  + .55%
Line Change :  + .88%

org.pentaho.di.trans.steps.ivwloader.IngresVectorwiseLoader.FifoOpener:

Branch Change :  + 16.67%
Complexity Change :  + 12.50%
Instruction Change :  + 7.14%
Line Change :  + 10.53%
Method Change :  + 20.00%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta:

Instruction Change :  + .06%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta:

Branch Change : -2.35%
Complexity Change : -2.70%
Instruction Change : -.18%
Line Change : -.48%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

Instruction Change :  + .07%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta:

Instruction Change : -.08%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta:

Instruction Change :  + .04%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta:

Branch Change : -.53%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

Instruction Change :  + .18%

org.pentaho.di.trans.steps.webservices.WebServiceMeta:

Branch Change :  + 1.79%
Complexity Change :  + 1.19%
Instruction Change :  + .07%

org.pentaho.di.trans.Trans:

Branch Change :  + .10%
Complexity Change :  + .14%
Instruction Change :  + .09%
Line Change :  + .11%

com.pentaho.repository.importexport.PDIImportUtil:

Complexity Change :  + 28.57%
Instruction Change :  + 37.69%
Line Change :  + 39.74%
Method Change :  + 28.57%

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/core/test-src/org/pentaho/di/core/xml/XMLHandlerUnitTest.java

Message: Using a static member import should be avoided - org.pentaho.di.core.xml.XMLHandler.buildCDATA. at Line: 42
Message: Using a static member import should be avoided - org.pentaho.di.core.xml.XMLHandler.openTag. at Line: 43
Message: Using a static member import should be avoided - org.pentaho.di.core.xml.XMLHandler.closeTag. at Line: 44
Message: Using a static member import should be avoided - org.pentaho.di.core.xml.XMLHandler.addTagValue. at Line: 45

File /home/buildguy/project/plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java

Message: Using the '.' form of import should be avoided - org.junit.Assert.. at Line: 22

@mchen-len-son , could you please take a look at this PR?

Head build failed with return code 1

Head build failed with return code 1

@lucboudreau , could you please restart wingman?
I'm a bit confused, as I don't see any reasons for him to fail.

Looks like a classpath issue.
[javac] /home/buildguy/project/engine/test-src/org/pentaho/di/repository/RepositoryExportSaxParserTest.java:40: error: package test.util does not exist
[javac] import test.util.XXEUtils;
[javac]                 ^

@lucboudreau , thanks for your assistance!
Not sure either, will try to figure it out tommorow.

Head build failed with return code 1

Head build failed with return code 1

Head build failed with return code 1

Head build failed with return code 1

Build completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands:

ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f core/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/kettle-xml-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/kettle-xml-plugin/build.xml jacoco-integration checkstyle publish-local
ant -Dtestreports.dir=bin/reports/unit-test -f plugins/pdi-pur-plugin/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f plugins/pdi-pur-plugin/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
core/src/org/pentaho/di/core/xml/XMLCheck.java
core/src/org/pentaho/di/core/xml/XMLHandler.java
core/src/org/pentaho/di/core/xml/XMLParserFactoryProducer.java
core/test-src/org/pentaho/di/core/xml/XMLCheckTest.java
core/test-src/org/pentaho/di/core/xml/XMLHandlerUnitTest.java
core/test-src/org/pentaho/di/core/xml/XMLUtilsTest.java
engine/src/org/pentaho/di/core/util/SerializationHelper.java
engine/src/org/pentaho/di/repository/RepositoriesMeta.java
engine/src/org/pentaho/di/repository/RepositoryExportSaxParser.java
engine/src/org/pentaho/di/trans/steps/webservices/WebService.java
engine/test-src/org/pentaho/di/core/util/SerializationHelperTest.java
engine/test-src/org/pentaho/di/repository/RepositoriesMetaTest.java
engine/test-src/org/pentaho/di/repository/RepositoryExportSaxParserTest.java
engine/test-src/org/pentaho/test/util/XXEUtils.java
plugins/kettle-xml-plugin/src/org/pentaho/di/job/entries/dtdvalidator/DTDValidator.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/addxml/AddXML.java
plugins/kettle-xml-plugin/src/org/pentaho/di/trans/steps/xmljoin/XMLJoin.java
plugins/pdi-pur-plugin/src/com/pentaho/pdi/ws/RepositorySyncWebService.java
plugins/pdi-pur-plugin/src/com/pentaho/repository/importexport/PDIImportUtil.java
plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java
Unit test coverage change:
org.pentaho.di.core.exception.KettleXMLException:

Complexity Change :  + 25.00%
Instruction Change :  + 31.25%
Line Change :  + 25.00%
Method Change :  + 25.00%

org.pentaho.di.core.xml.DTDIgnoringEntityResolver:

Line Change : -15.00%

org.pentaho.di.core.xml.XMLCheck:

Complexity Change :  + 33.33%
Instruction Change :  + 37.78%
Line Change :  + 35.29%
Method Change :  + 33.33%

org.pentaho.di.core.xml.XMLCheck.XMLTreeHandler:

Complexity Change :  + 100.00%
Instruction Change :  + 100.00%
Line Change :  + 100.00%
Method Change :  + 100.00%

org.pentaho.di.core.xml.XMLHandler:

Branch Change :  + 4.11%
Complexity Change :  + 4.35%
Instruction Change :  + 6.05%
Line Change :  + 5.40%
Method Change :  + 6.15%

org.pentaho.di.core.xml.XMLParserFactoryProducer:

Complexity New Coverage : 66.67%
Instruction New Coverage : 84.21%
Line New Coverage : 85.71%
Method New Coverage : 66.67%

org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change :  + 7.14%
Complexity Change :  + 7.69%

org.pentaho.di.core.util.SerializationHelper:

Complexity Change :  + 2.44%
Instruction Change :  + 3.10%
Line Change :  + 3.36%
Method Change :  + 25.00%

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval:

Branch Change :  + .29%
Complexity Change :  + .43%
Instruction Change :  + .07%

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL:

Branch Change : -.67%
Complexity Change : -.94%
Instruction Change : -.13%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 3.70%

org.pentaho.di.repository.RepositoryExportSaxParser:

Complexity Change :  + 4.76%
Instruction Change :  + 3.18%
Line Change :  + 5.00%
Method Change :  + 12.50%

org.pentaho.di.trans.steps.checksum.CheckSumMeta:

Branch Change : -1.32%
Complexity Change : -1.43%
Instruction Change : -.33%
Line Change : -.54%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta:

Instruction Change : -.04%

org.pentaho.di.trans.steps.constant.ConstantMeta:

Instruction Change :  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta:

Instruction Change : -.05%

org.pentaho.di.trans.steps.dbproc.DBProcMeta:

Instruction Change : -.11%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta:

Branch Change : -.66%
Complexity Change : -.41%
Instruction Change : -.50%
Line Change : -.24%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta:

Branch Change :  + 1.28%
Complexity Change :  + .78%
Instruction Change :  + .08%

org.pentaho.di.trans.steps.groupby.GroupByMeta:

Branch Change : -2.08%
Complexity Change : -2.11%
Instruction Change : -.14%
Line Change : -.37%

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta:

Instruction Change : -.05%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta:

Instruction Change : -.06%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta:

Branch Change :  + 3.53%
Complexity Change :  + 4.05%
Instruction Change :  + .18%
Line Change :  + .48%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

Instruction Change : -.07%

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta:

Instruction Change :  + .08%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Instruction Change :  + .18%

org.pentaho.di.trans.steps.systemdata.SystemDataMeta:

Branch Change : -2.04%
Complexity Change : -2.04%
Instruction Change : -.32%
Line Change : -.81%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

Instruction Change :  + .18%

com.pentaho.repository.importexport.PDIImportUtil:

Complexity Change :  + 28.57%
Instruction Change :  + 42.66%
Line Change :  + 43.08%
Method Change :  + 28.57%

Integration test coverage change:
org.pentaho.di.trans.step.BaseStep:

Branch Change : -.29%
Complexity Change : -.18%
Instruction Change : -.05%
Line Change : -.08%

Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File /home/buildguy/project/plugins/pdi-pur-plugin/test/com/pentaho/repository/importexport/PDIImportUtilTest.java

Message: Using a static member import should be avoided - org.pentaho.di.core.util.Assert.assertNull. at Line: 27
Message: Using a static member import should be avoided - org.pentaho.di.core.util.Assert.assertNotNull. at Line: 28

MALICIOUS_XML is duplicated in several modules.
It is done consciously, as it is impossible to concentrate it in one place, without adding new test-dependencies among modules.
I don't think that we need to do this in this case.

Double checked locally.
Checkstyle violations contain only legal static imports for tests.
Note: This might break the plugin build for a while, due to unpredictabe order of modules building.
Merging.

@mchen-len-son @IvanNikolaychuk If this might break the builds, please get in touch with the build folks to make sure they are aware. Ideally, please talk to them before you merge these types of changes. cc. @buildguy

Since this is kettle, there will be many opportunities to break downstream builds that depend on it, but since there are no new/changed dependencies or build configurations here, this is the kind of thing we will need to shake out on devci and possibly QAT unfortunately.
I expect that our developers are more in tune with the downstream impacts of xml processing changes in kettle.


Add a notebook that shows a basic binaural synthesis

Open questions:

[ ] the interactive part seems to break the build process. Am I doing something wrong? @mberz ?

Please refer to nbsphinx's docs section on how to use interactive widgets in nbsphinx.
https://nbsphinx.readthedocs.io/en/0.9.3/code-cells.html#Interactive-Widgets-(HTML-only)

On the issue, that the tests are failing on CircleCI:
Please run
pytest --nbmake docs/gallery/interactive/*.ipynb

locally and check what is causing the issue. On my machine it seems that the interpreter is "stuck" somewhere and does not continue, maybe pausing and waiting for user interaction or similar.

The nbmake issue seems to be unrelated to, but caused by something else...

Please merge the most recent state of the main branch for a workaround to the issue.

Please refer to nbsphinx's docs section on how to use interactive widgets in nbsphinx. https://nbsphinx.readthedocs.io/en/0.9.3/code-cells.html#Interactive-Widgets-(HTML-only)

The problem is the interactive_output. I guess this is too complicated for a pre-rendered html document. I will keep the example commented out. We could add a comment saying that this would have to be run in binder?

Thanks for the review!

I've implemented a hot fix for the scaling of the scatter plot within pyfar, so we can get rid of the manual axis scaling in the future.
https://github.com/pyfar/pyfar/pull/554

Thanks for the reviews. I think I got most things now.

Regarding the plots with the source positions, sikersten and I decided to remove the styling and rather wait for the fix in pyfar.


fix(lint): ensure that firmware version ranges of files do not overlap

Turns out our checks for duplicate device files only accounted for identical firmware ranges, not overlapping ones. Now we do

@zwave-js-bot automerge


Allowed Docker-repositories / Images should be limited by the node

The node does not check which Docker images are allowed. I think for now we should create an list of OR regexpr to validate of and image/repository is allowed.

Added in 697fb1e055946a01671590d07cd85e8d1b25629b


sites mass-update now differentiates between SFTP-mode and updated sites

Closes #630

:+1: on the change.


Slowness in Macs

Investigate slowness in macs
Possible things to investigate

[ ] Is there any slowness in queue times
[ ] Is there any slowness in test execution times
[ ] Determine which queues experience these
[ ] possible solutions for this slowness

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

Changes have been made by the 1ES Mac team to our systems. Currently waiting on information from the product teams.

Received confirmation that this issue is resolved.


Inaccurate

The directions for rolling back Edge doesn't work, tried it every which way this article states.
[Enter feedback here]
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12e89255-aab6-fe92-7a4f-7c1a53d30f50
Version Independent ID: dcb5637d-8829-83e2-d7e3-71714a7daf3a
Content: Microsoft Edge rollback for enterprises
Content Source: edgeenterprise/edge-learnmore-rollback.md
Product: microsoft-edge
GitHub Login: @dan-wesley
Microsoft Alias: collw

Closing as dup of previous issue (https://github.com/MicrosoftDocs/Edge-Enterprise/issues/495)


adds an apply function and cleans adj_jac_apply to use it

Summary

An apply function on tuples which is a backwards import from C++17's std::apply
Fixes to broadcast_array so that the scalar implimentation has operator's [ ] and = and a few others defined
adds the inline keyword to adj_jac_apply methods and uses eigen map's instead of loops.

Tests
Tests can be run with
./runTests.py test/unit/math/prim/functor/apply_test.cpp \
  test/unit/math/rev/functor/adj_jac_apply_test \

Side Effects
None
Release notes
Added an apply function that backports C++17's apply() over tuples. Simple cleanups for broadcast_array and adj_jac_apply
Checklist

[x] Math issue #1616

[x] Copyright holder: Steve Bronder, Ben Bales, Sebasitan Weber
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@bbbales2 I removed the use of this, the changes to broadcast_array, and use resize again so I think this is ready for review!

I concur!


Pfe-Tooltip web component not displaying correctly

Description of the issue
When the user hovers over the tooltip it displays a vague large black box without tooltip indication as to which element triggered it.  I noticed I was also unable to specify the positioning (left, right, top) of the tooltip as well.
Impacted component(s)

pfe-tooltip web component

Steps to reproduce

Use code from example readme https://github.com/patternfly/patternfly-elements/tree/main/elements/pfe-tooltip
Hover over element/container which is supposed to trigger tooltip
See error where tooltip is large box without arrow.

Expected behavior
When the user hovers over the intended trigger for the tooltip, it should render with an arrow pointing at what triggered it e.g. icon, button, etc.
Screenshots
Example 1: With Real Example

Example 2: With Readme Code

Thank you for moving this issue @jaadbarg.
Can you please open the browser console, refresh the page, and paste the output? I suspect the issue is that you need to add a script to the page somewhere before pfe-tooltip loads, with the following content:
globalThis.process ??= { env: {} };

This is because pfe-tooltip currently uses a legacy 3rd party dependency. we're planning on removing it at some point, but the above snippet might be a helpful workaround in the mean time.

Ah that makes sense since this is the error I am seeing:

I just added that in and everything is working as expected, thanks for the help!

glad to help and sorry that our crufty 3rd party dependency assumes that "runs in the browser" actually means "runs in node"


PHOENIX-6450 Checkstyle creating warnings for line length > 80 but < 100

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
21m 27s
master passed

+0
hbaserecompile
28m 28s
HBase recompiled.

+1 :green_heart:
compile
1m 43s
master passed

+1 :green_heart:
javadoc
1m 20s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
14m  7s
the patch passed

+0
hbaserecompile
52m 38s
HBase recompiled.

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
117m 59s
root in the patch failed.

-1 :x:
asflicense
1m  9s
The patch generated 614 ASF License warnings.

183m 23s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1276

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux faa997777a64 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 6842c1d

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
13991 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
4m 57s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
16m 31s
master passed

+0
hbaserecompile
28m 29s
HBase recompiled.

+1 :green_heart:
compile
1m 44s
master passed

+1 :green_heart:
javadoc
3m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
13m 27s
the patch passed

+0
hbaserecompile
21m  7s
HBase recompiled.

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  9s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
3m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
116m 48s
root in the patch failed.

-1 :x:
asflicense
4m 26s
The patch generated 614 ASF License warnings.

189m 49s

Reason
Tests

Failed junit tests
phoenix.end2end.UpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1276

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux c836c3ad11f1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / d04b3d8

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/2/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/2/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
15758 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-pherf phoenix-client-parent phoenix-server phoenix-tracing-webapp phoenix-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1276/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


vs match queryParams prefix not work,any can

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
[ ] Docs
[ ] Installation
[ x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: bookinfo
spec:
  gateways:
  - bookinfo-gateway
  hosts:
  - '*'
  http:
  - match:
    - queryParams:
        test:
          prefix: test
    route:
    - destination:
        host: productpage
        port:
          number: 9080

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
[root@master01 match]# istioctl version
client version: 1.10.0
control plane version: 1.10.0
data plane version: 1.10.0 (11 proxies)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

why nobody  look at this


[quick-edit] Partitioned cookies

Closes DEVX-1156.
What this PR solves / how to test:
This PR ensures that the Workers Quick Edit uses partitioned cookies for it's preview system, to address the upcoming deprecation of third party cookies in Chrome.
Testing instructions TBD
Author has addressed the following:

Tests

[x] Included, but manual testing in Chrome TBD
[ ] Not necessary because:

Changeset (Changeset guidelines)

[ ] Included
[x] Not necessary because: The package doesn't follow changesets

Associated docs

[ ] Issue(s)/PR(s):
[x] Not necessary because: This isn't a change to documented behaviour

@petebacondarwin @RamIdeas, this contains a change to https://github.com/cloudflare/workers-sdk/pull/4950, which was breaking set-cookie headers (which require a hostname, not host). I'm not entirely sure about the change though, so would appreciate a review!

I tested these changes locally and verified they are working.

Love it! But sadly legit failures in CI to deal with before landing.


🚀 [Feature] : Only My Gender Option

If you want this feature, please send emoji to the issue to speed up this process.

[ ] Add as a filter
[ ] Later on you can add as a privacy toggle


Update dependencies

depends on #170
Updated lerna to newer version to remove dependabot security issues.

Looks like it's having trouble resolving the ref-napi module?

I think it needs to be updated with base branch to get the latest changes from #170.


advanced resources for mri principles

on T1 and T2 relaxation https://mriquestions.com/what-is-t2.html
NMR basics https://www.youtube.com/watch?v=TQegSF4ZiIQ
Whole series: https://www.youtube.com/watch?v=35gfOtjRcic

included a new section.

too advanced


Ca2+ ions. scoring functions

Dear Dr Zhu,
I did a few tests.  One of my targets has a C2+ ion in the binding pocket that has been shown, in co-crystals, to be important for binding. The receptor models I get from a docking with DiffBindFR seem to be stripped of Hydrogen, water molecules and ions.  Probably it is a limitation of this approach.  Still, the binding pose of the co-crystallized ligands look very similar than with the co-crystal.  However, not having a Ca2+ there could be affecting the scoring of the different poses.  I just wanted to double check with you if it were possible to keep the Ca2+.
Anyways, most of my targets do not have ions in the binding pocket so DiffBindFR will still be very useful.
From my tests, I think smina scoring works much better than mdn.  I don't think I'm going to rely on mdn.
In term of speed, at 40 poses/ligand, it takes about 2min/ligand. If I increase too much -bs, I get a problem with Pytorch vs available memory on the GPU and if I increase too much -cpu, the script crashes.  I found a sweet spot that seem to work well.  For screening big libraries, a few seconds here and there make a huge difference at the end.  Do you have any suggestions?
Thanks for help,
Christian

Hi, Christian,
Thank you for your detailed feedback and for testing DiffBindFR.
Regarding your first question, to the best of my knowledge, most current deep learning methods do not consider cofactors and important crystal waters in the pocket environment due to numerous technical and data difficulties. Therefore, for fair comparison, we did not further consider these when building the model. Moreover, it's worth emphasizing that DiffBindFR is entirely focused on the setting of flexible docking, which requires remodeling the conformation of the pocket.  If these factors are to be considered, I believe it would be necessary to reconstruct these ingredients. This is something we are planning to do in the future, as it involves mining more data and considering how to identify which water molecules and metal ions participate in important interactions. I am fully aware that this is important for biomolecular recognition, and the AI-docking models need to consider these to enhance the interpretability of physical interactions.
Since the protein conformation is reconstructed, the hydrogen atoms will also be removed, as the DiffBindFR may model a different binding environment. Here, I strongly suggest that users who need this can re-parameterize the force field of the sampled binding conformation to explain more detailed interactions, such as using Schrodinger software or ChimeraX, or even using the pl.py I provided to do force field parameterization.
Regarding MDN not meeting your expectations, I guess the tests you are doing now are redocking, which we have reported in our paper that smina performs slightly better than MDN under redocking. However, MDN performs better in more realistic cross-docking scenarios, which may still require case-by-case analysis.
As for speed, I greatly appreciate your pointing it out. There was a small mistake here for me, and I have fixed this bug (it only affects the speed of program execution). Now you can try to fully utilize your CPU to process data. Another factor affecting speed is your graphics card resources. I have tested Tesla v100-32GB and GeForce RTX 3090 (both batch size and CPU are 16), and each pair takes an average of 52s. Another way to speed up is to use the slurm job array to submit multiple nodes, as I wrote in the README.
Best,
Jintao Zhu

Thank you very much for your feedback and the correction.  I was running at -cpu 8 -bs 10; I think 52s on a better hardware is similar to what I get, I just wanted to be sure I was not completely off because of some configuration. I realize that going flexible on prt + ligand cannot be fast.  To shrink my library, I'm using BANANA (6M cmpds/h) and a negative-image + ShaEP (1.5M structures/h) to I get down to 350k while still keeping 75% of the positive controls but I cannot rely on poses from ShaEP.  I was really impressed by the poses I got with DiffBindFR.  However, I'll need to switch to an HPC as 350k @ 1min would take months to get through.  I just wanted to be sure that everything works fine locally before migrating to an HPC.
I still have to try pl.py.
Again, thank you very much for your help and patience with all my questions,
Best,
Christian

There seems to be mostly no correlation with Smirna and MDN scoring.  I'm not expecting that they would give exactly the same ranking but still I would not use MDN for a consensus with Smirna.  I'm currently exploring other scoring functions such as Genscore, IGModel and AA-score to get better correlations.  Maybe there is something wrong with my MDN installation.  However, Smirna works very well.
Best,
Christian


Implement folding of brace-less arrow functions

duplicate of https://github.com/microsoft/TypeScript/issues/26661
this simple request has been pending for almost 2 years now
I really don't like being forced into a specific syntax to use basic text editor features

@pushkine Please comment on the original issue instead of creating a new one, thank you!


bpf: Inline assembly for packet context access

bpf: tests: Minimise calls to ctx_data{,_end}() in prep for inline asm
bpf: Avoid 32bit assignment of packet pointer

Given that ctx->{data,data_end,data_meta} are 32-bits fields, LLVM sometimes generates 32-bit assignments for those pointers. This leads to verifier errors as the verifier is unable to track the packet pointers through the 32-bit assignments, as show below.
; return (void *)(unsigned long)ctx->data;
2: (61) r9 = *(u32 *)(r7 +76)
; R7_w=ctx(id=0,off=0,imm=0) R9_w=pkt(id=0,off=0,r=0,imm=0)
; return (void *)(unsigned long)ctx->data;
3: (bc) w6 = w9
; R6_w=inv(id=0,umax_value=4294967295,var_off=(0x0; 0xffffffff)) R9_w=pkt(id=0,off=0,r=0,imm=0)
; if (data + tot_len > data_end)
4: (bf) r2 = r6
; R2_w=inv(id=1,umax_value=4294967295,var_off=(0x0; 0xffffffff)) R6_w=inv(id=1,umax_value=4294967295,var_off=(0x0; 0xffffffff))
5: (07) r2 += 54
; R2_w=inv(id=0,umin_value=54,umax_value=4294967349,var_off=(0x0; 0x1ffffffff))
; if (data + tot_len > data_end)
6: (2d) if r2 > r1 goto pc+466
; R1_w=pkt_end(id=0,off=0,imm=0) R2_w=inv(id=0,umin_value=54,umax_value=4294967349,var_off=(0x0; 0x1ffffffff))
; tmp = a->d1 - b->d1;
7: (71) r2 = *(u8 *)(r6 +22)
R6 invalid mem access 'inv'

As a workaround, Yonghong Song suggested to read those fields using asm bytecode. With that trick, LLVM is unaware that the original field is actually on 32 bits and can't perform the above "optimisation".
This workaround is needed only now because code for IPv6 masquerading, coming in a future PR, will cause this bytecode to be generated (snat_v6_needed).
Preliminary to this change, we also need some adjustments in the BPF unit tests, to avoid resetting range tracking for packet pointers by fetching them multiple times (these multiple fetches were previously optimised out by the compiler, but also drop this optimisation by switching to inline assembly).
bpf: Use inline assembly for packet context access, to prevent some undesirable optimizations from LLVM

/test

/test-1.26-net-next

Checkpatch report is a formatting nit that we can ignore in this case - we prefer to keep related definitions close together in this commit rather than adding newlines between them.

We can probably revert the workaround as a follow-up? Also, I believe there are a few revalidate_data calls in the code that can be ditched after your patch.

Yes good call, I can look into that next.

No need to change formatting in the code, but I wonder why checkpatch complains on this:
  Warning: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
  #86: FILE: bpf/include/bpf/ctx/skb.h:72:
  +	 */									\

Or does it actually mean the previous lines of the multiline comment, not the last one?

The comment in checkpatch.pl says:
# check for line continuations outside of #defines, preprocessor #, and asm

so my guess is that between the #define and the asm, there's something causing it to loose track of the fact we're in a #define, and to complain about the trailing backslash. The code is here if you want, but for my part I didn't feel like going through the whole block in Perl :sweat_smile:


[REVIEW] prathamesh-borse

GitHub Profile Link
https://github.com/prathamesh-borse

One thing from my side consider removing the profile views count due it's inaccurate

Anything I Can add In My Profile?
On Sun, Jul 25, 2021, 7:51 PM Tom Schmelzer @.***>
wrote:

One thing from my side consider removing the profile views count due it's
inaccurate
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EddieHubCommunity/support/issues/2092#issuecomment-886209274,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP6M3ID42NJ3TYJD3WIVWM3TZQMVZANCNFSM5A6OJMIA
.

I like your profile but there is one thing that I wanna tell you that your social links don't stand out when people are using the dark mode. Consider using more colourful icons.
Thank you

Nice profile, I liked it. I have made a pull request
in your README profile for some minor improvements. 🙂
Thanks for sharing your profile with us! 😉

Thank you for sharing, we will review on a live stream soon 👍

Looks great, some thoughts...

continue to contribute after hacktoberfest
github activity is duplicate demostrates you can use GitHub Action


"Testing your code" section could use a little more explicit directions.

I was following along and then ran into:
error: Unknown module

import vars/internal
^^^^^^^^^^^^^^^^^^ Did you mean `argv`?

Which was a little confusing. I was staring right at internal.gleam. Why is it suggesting argv??
Anyways, I got it working by removing the "vars/" part. Total noob here. Just exploring.
I know I must be missing something so I re-read it like 3 more times. Finally I noticed that internal.gleam needs to be in a subdirectory called vars.... which is a bit of a stutter. I am in a package called vars, with a src/vars.gleam and now I need to make another directory called vars?? Ok sure. so I have vars/src/vars/internal.gleam.
Sorry, that turned into more of a rant than I intended.
The intro tutorial should be more explicit.
To call the format_pair function from a module in the test/ directory we will need to make it public. We don’t want it to be part of the public API of the package, so we’ll move it to an internal module, which by default are modules named packagename/internal and packagename/internal/*.

I was thinking I did make packagename/internal. Because vars/src would be a package right?? Nope. The doc should say "make the directory src/vars and put internal.gleam in there".

Hello! Thanks for the report. The guide specifies the exact path to use so let's leave it as is and see how it turns out.


Custom Input toggle issue

Custom input toggle does not work because onClickOutside gets triggered every time the custom input is clicked it fires the onClickOutside and then the onClick of custom input.

Same issue happening to me when using device toggle. When not using it it behaves somewhat as expected, where clicking the custom input opens the calendar and clicking it again closes it (it is actually closed by onClickOutside event but whatever, it works), however with the device toggle on clicking it again (when calendar is open)  fires the onClickOutside and then fires the input's onClick right away, which just reopens it. Running the sandbox works as expected, however running the code locally with device toggle on results in this issue.

Will the same behaviour happen on mobile devices, if yes, is there a simple way of fixing it (without manually handling this behaviour in something like the onClick event).
Thx
sandbox

Found a solution: https://github.com/Hacker0x01/react-datepicker/issues/3778#issuecomment-1272560156


Snapshot: dvc config error

Getting this error when running:
python snapshots/gapminder/2023-09-18/under_five_mortality.py on the un-igme branch, not sure what is causing it.

Think it was some poetry installation issue, I deleted venv and reinstalled a few times and now it works 🤷🏼♀


Problem with libreoffice

Hello!
I'm trying to run your software, but, unfortunately, libreoffice gives me the following error:

Could you give me any suggestions on what should I do?

Hey there, hope your day is going well~
I've seen an error like that before but will need a bit more information to help determine what the issue is on your system.

What version of macOS and Libre Office are you running?
Are you running through the CLI or Alfred? If CLI you can try adding -d or --debug=true to your command to print out more details

I'd recommend checking if this filepath exists: cd ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard
If it doesn't exist the fix is likely changing the default filepath in the application configuration file (should be located at ~/.svgtoppt)
Feel free to let me know if I need to expand or elaborate on anything here or in future messages. Happy to help

Thanks for such a quick response ☺

What version of macOS and Libre Office are you running?

Are you running through the CLI or Alfred?

I'm trying to use CLI

If CLI you can try adding -d or --debug=true to your command to print out more details

I'd recommend checking if this filepath exists: cd ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard

This path exists

Ah, a different error. When you added in debug flag the SVG input wasn't read in correctly
Try this: svgtoppt -i {your_file} -d (where -i is flag for taking in the SVG file)
Good to know the filepath exists. After you run the command and get your original error let me know what exists in the Standard directory from that filepath

Thanks. I have a feeling it has to do with the space in the filename of your SVG. I remember testing files with a space but it's been a few months now and I may have missed an edge case
Could you try taking out the space and see what happens? At the very least that'll narrow down the possible points of failure. Also you may need to force close Libre Office

How long should it take to process an image?

Depends on the computer and how much is running on it. My computer takes about 15 seconds maybe. It's doing the following:

Making sure Libre Office is installed
Creating a new macro file
Launching Libre Office
Executing the macro which imports the SVG and creates the PPT
Launching Keynote (or whatever you pass in) to open the PPT

On older computers, or ones with less RAM, launching applications can take longer. Bulk convert (passing in a folder of SVGs) seems to save a lot of time. I haven't run the proper tests but I'd guess if I wanted to convert 10 files on my computer it'd take ~25 seconds for bulk versus 150 seconds (10 files * 15 seconds each) for single conversions

It works, but doesn't finish for one image in 15 seconds
It gets stuck on the following step:

So it reaches that point and Libre Office opens with the error in your original screenshot?
It seems like Libre Office is having trouble reaching the macro file (cat ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard/SVGtoPPT.xba). Perhaps you could try open a blank presentation in Libre Office yourself then go to Tools > Macros > "Edit Macros..."
The SVGtoPPT macro should show up under Standard and have your SVG filepath in the svgArray variable near the top. Here's mine for example.

Interesting.
My scripts tree in macros viewer looks like this

And folder $HOME/Library/Application\ Support/LibreOffice/4/user/basic/Standard/ looks like this:

Hm, that would be the culprit then... I haven't seen this happen before unfortunately, even though during testing I fully uninstall and reinstall Libre Office to make sure this code works on a fresh instance.
What version of Libre Office are you running? Could there be two instances installed by chance? Trying to think what would cause a macro to be missing
Haven't done this before but I suppose there's probably a way to manually add the macro file through this GUI

@churnikov Wanted to check in to see if you had gotten this resolved or if I could provide any other assistance?

Hello!
Unfortunately no, I could not resolve this issue. 😢
But if I would need your tool in the future, I'll try to use it again 👍🏻

As an FYI, I had the exact same issue on MacOS v12.3 and LibreOffice 7.3.1.
Just like @blakegearin, it seems the Macro either didn't install or couldn't be found.  I did get an error when running the install script to also install LibreOffice.  I was able to somewhat work around it by manually installing it via homebrew and running the "don't install LibreOffice" version of the script with the -r tag.  It said everything worked, but I got the same "script is empty.
I downloaded <IP_ADDRESS> but had the exact same issue.

I got it working.
I created a new macro named SVGtoPPT and saved it with the bare minimum code.  Killed LibreOffice, then re-launched.  it worked after that.

Hey @jpeiffer, thanks for reporting the issue and glad to hear you got it sorted out.
Couple questions:

Were you installing via command line or through Alfred?
Does this directory exist? ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard

I believe I may have found the issue by using a new machine. It appears that before a new macro is created with LibreOffice the directory above does not exist, which prevents the macro template from being moved there.

I installed multiple ways...

Your script (this failed with an error about the folder you mentioned above missing)
homebrew
Direct download and install using Finder

The mechanism seemed to make no difference.
When I did either the Homebrew or Manual GUI install then that directory existed.
When I ran svgtoppt, it now had the and had both the template and the SVGtoPPT.xba file in it.  LibreOffice never "saw" the SVGtoPPT Macro though.  That suggests pretty strongly to me that LibraOffice keeps an internal list of Macros rather than doing a directory scan.  When I added SVGtoPPT manually and saved it as a no-op macro (basically just the basic new macro template), then quit LibreOffice, then ran your script, everything worked.  And it's worked fine since.

Found it!  There's a script.xlb file inside of ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard.  That's the file LibreOffice uses to keep track of the installed Modules.
When you uninstall and reinstall LibreOffice, the .../Application Support/LibreOffice remains, so that's not a true "clean install".
If you delete .../Application Support/LibreOffice and reinstall, the contents of the file are:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE library:library PUBLIC "-//OpenOffice.org//DTD OfficeDocument 1.0//EN" "library.dtd">
<library:library xmlns:library="http://openoffice.org/2000/library" library:name="Standard" library:readonly="false" library:passwordprotected="false">
 <library:element library:name="Module1"/>
</library:library>

When I manually add and save SVGtoPPT, the file becomes:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE library:library PUBLIC "-//OpenOffice.org//DTD OfficeDocument 1.0//EN" "library.dtd">
<library:library xmlns:library="http://openoffice.org/2000/library" library:name="Standard" library:readonly="false" library:passwordprotected="false">
 <library:element library:name="Module1"/>
 <library:element library:name="SVGtoPPT"/>
</library:library>

So if you edit your install file to add...
 <library:element library:name="SVGtoPPT"/>

... to ~/Library/Application\ Support/LibreOffice/4/user/basic/Standard/script.xlb before the closing </library:library> then this issue should be globally fixed.
Also, thanks again for this great script.

Yeah no problem 🙂
I have released a 1.1.0 version that includes fixes. If you're willing to uninstall, delete that ~/Library/Application\ Support/LibreOffice directory, and try a reinstall that would be helpful.
For reference, both the issue you outlined with needing to update the ~/Library/Application Support/LibreOffice/4/user/basic/Standard/scripts.xml file and the one I mentioned above needed to be resolved to ensure a clean install.

It mostly worked.  When I first ran the generator it failed because the ~/Library/Application Support/LibreOffice/4/user/basic/Standard/ folder didn't exist.  I had to manually open LibraOffice once and accept Apple's security warning and then everything worked fine.

I had the same logs.  It just... didn't open, I guess.  I tried to reproduce, but this time it opened.  So maybe a transient issue on my computer?
Anyhow, great script and from my perspective, this issue is resolved.


Cannot access object keys starting with a capital letter

It looks like variable names cannot start with a capital letter, which makes sense for lambdas like \x -> x. However this means that keys that start with a capital letter cannot be accessed, resulting in an error during tokenization.
echo '{ "Foo": 5 }' | jl '_.Foo'

Fixed!
bash-3.2$ echo '{ "Foo": 5 }' | jl '_.Foo'
5

And if you have non-alphanumeric keys you can use
bash-3.2$ echo '{ "Foo": 5 }' | jl '_["Foo"]'
5

Wonderful, thanks!


Questions about the Global Data Share (GDS)

This entry is an updated version of my comment for the following blog post of yours. Thank you so much for looking into this!
http://gpuopen.com/using-sub-dword-addressing-on-amd-gpus-with-rocm/

I am currently using a customized version of LLVM/Clang to generate OpenCL binaries offline in order to take advantage of GDS:
https://github.com/zawawawa/gatelessgate/blob/master/Core/binary-kernel/equihash.cl
My most pressing question is how to access the entire 64KB of the GDS within a single kernel on Windows and/or Linux:
http://stackoverflow.com/questions/42799481/is-it-possible-to-access-the-entire-64kb-of-the-global-data-sharea-gds-on-amd
It seems like there is a 4KB limit per vmid on Linux with AMDGPU-Pro, and the GDS on RX 480 is not accessible even with the latest Crimson ReLive Software. I was able to increase the limit to 16KB by tweaking the Linux kernel, but I would like to do the same thing without a kernel patch.
If that is not possible, it would also be great if you could tell me how to enable the GDS on RX 480 on Windows.
I would also like to know what I should expect from the GDS performance-wise. I am under the impression that it is much slower than the LDS, and I would love to get some concrete numbers in terms for data transfer rates, especially for RX 480.

Thank you! Let me see if can try to access GDS on Windows. Once I get a better understanding, I can see what we (AMD) can do.

Any news on this? I am still waiting!

Hi,
As of today, on ROCm stack, there is no support for GDS. On Windows, for compute and graphics GDS support is deprecated. Seems like amdgpu have support for GDS but don't know whether it is fully enabled. I recommend talking to https://twitter.com/TimothyLottes for GDS for graphics, Alex Deucher for kernel support for GDS, Nicolai Haehnle about shaders + driver usage.

Thanks a lot @adityaatluri!
I hope AMD support for *nix distros will be better in future.
People need it.

I run the ROCm Software Engineering team,   this is the first time this coming to my attention.   We will look into this, but right now we in the process of getting a release out.   So It might be the weekend before I will be able to respond with a solid answer on a when we might be able to support it.
Yes, we are moving beyond just Ubuntu and Fedora distro's for ROCm,  In the first year, we been focused on feature capabilities and stability before we start backporting to older Linux kernels and testing older GCC tool associated some of the traditional server distros.   We have a small team would love to do everything all at once but we have to prioritize what we work on.

@adityaatluri Thank you so much! I will bug these people you mentioned. In the meantime, if anybody succeeds in enabling GDS functionality by directly accessing GPU registers through the PCIe bus, please let me know.
@gstoner It would be wonderful if ROCm natively supports the GDS as it seems like a much leaner framework than OpenCL proper. I look forward to your updates as well.

So I have been digging into this it not a fast feature to add.  It hits a large number of the system in the driver firmware and compiler.   We a did preliminary scope of the feature, but need to talk to the architecture team about some of the design constraints we found before we can decide anything.

I see... It would be great, though, if the GDS is enabled at least at the driver level. That way, the GDS can be accessed with the inline assembly even without the official support by the compiler.

Is there any way to obtain the MMIO base address? Is that piece of information found in the PCI configuration space? If that's the case, I could directly access configuration registers to enable the GDS.


Add AWS anonymous access when reading/writing binary cache to AWS S3.

Sometimes it's essential to be able to read/write binary cache to AWS S3 anonymously (mostly read, I assume).
AWS cli tool requires to be run with --no-sign-request option to get anonymous access.
This PR adds new 'x-aws-config' option to configure AWS anonymous access.
Signed-off-by: Vitalii Koshura<EMAIL_ADDRESS>

User should enable anonymous access to the bucket manually and set exactly what can be done. For example, I set that anyone can list  files in the bucket and download any file. But only authorized users (that are chosen manually) can write objects to the file.
In common case, if user set this option in vcpkg without properly configure AWS bucket to enable anonymous access - nothing will be enabled by default.
So this is completely safe option by default.

Twitter Driven Development also indicates that this isn't scary: https://twitter.com/sarbjeetjohal/status/1504727772958113797
Thanks for your contribution!

@BillyONeal, thank you!