Use merge-base as reference for CI checks/visdiff

:eyeglasses: @keybase/react-hackers cc @chrisnojima
       Given two commits A and B, git merge-base A B will output a commit which is
       reachable from both A and B through the parent relationship.

       For example, with this topology:

                    o---o---o---B
                   /
           ---o---1---o---o---o---A

       the merge base between A and B is 1.

We need to use the merge-base instead of the current state of
origin/master because master may be ahead of the start point of the
branch we're testing. Fixes visdiff regression, and should improve the
diff checking behavior.

cc @jzila

Note change target can be null

@jzila updated


Use external bin

Hi !
Is it possible to use an external executable of pngquant ? I'm trying to use this plugin but I'm facing a problem because the company in which I work doesn't allow any automatic downloads from github (only internal or npm repo) so it cannot found the exec file ...
Is there a way to use an existent build of pngquant (downloaded on the machine) or download it from another url that can be specified in the config ? This is possible in the grunt plugin but doesn't seem to be possible with this one ...
Thanks

Duplicate of https://github.com/imagemin/pngquant-bin/issues/66


Default view for named maps

Map model default options set the bounding box, center and zoom as in https://github.com/CartoDB/cartodb/blob/18565865a8f1ba53aed56ab925d4799b7397931c/app/models/map.rb#L47-L54
I guess on import bounding box is calculated and set in map model but center and zoom keep their default values.
Named map send for the view option both, the zoom+center and the bounding box as in https://github.com/CartoDB/cartodb/blob/18565865a8f1ba53aed56ab925d4799b7397931c/services/named-maps-api-wrapper/lib/named-maps-wrapper/named_map.rb#L222-L242
But as in view option zoom+center takes precedence over bounding box, named maps end having the default zoom=3, lat=30, lon=0 default options.
So all maps end having the same view after importing, making all canonical visualizations to have a, most of the time, incorrect view.
STR:

Download https://common-data.cartodb.com/tables/districtes_barcelona/public as geojson/shp or other format.
Upload the dataset
Go to the canonical visualization static image preview

Current result:
Image is using center+zoom with default zoom=3, lat=30, lon=0 although the bounding box is OK for the dataset.
Expected result:
Image using bounding box.
Examples:
I uploaded the dataset twice:

https://team.cartodb.com/u/rochoa/viz/cb8e0456-4fe2-11e5-a2d6-0e5e07bb5d8a/public_map
https://team.cartodb.com/u/rochoa/viz/e3343652-4fe7-11e5-a1a9-0e49835281d6/public_map

But then I modified the named map of the first one by just removing center and zoom from view. Have a look at the image preview difference by doing that:

vs

I guess the best thing is to not send the center+zoom if it's the default one and there is a bounding box available.
Thanks a lot @javierarce for your help and patience debugging this issue.
p.s.: I think this explains https://github.com/CartoDB/cartodb/issues/2974

As at #2974 I've already fixed the center stuff, I'll try to also recalculate zoom upon import so it gets a proper value, because now center is appropiate and only zoom level is wrong.


Further improve build info integration (Artifactory)

Hi,
I am testing the JFrog CLI v1.5.1 within an Bamboo CI and Artifactory environment. Due to some restrictions with the Artifactory Bamboo plugin (beyond scope), I'd prefer interacting with Artifactoy via a CLI tool on the respective build agents.
Right now I am missing (at least) the following members when publishing the JSON build-info (taken from the example):

"url" : "http://my-ci-server/jenkins/job/My-project-name/28/", // CI server URL
"vcsRevision" : "e4ab2e493afd369ae7bdc90d69c912e8346a3463", // VCS revision
"vcsUrl" : "https://github.com/github-user/my-project.git", // VCS URL

Would it be possible to extend the respective build-publish command to accept these as additional arguments? Or am I overlooking something and there is (already) another way to achieve this with the CLI? Skimmed the code, but didn't find anything ...
Thanks a lot.
Cheers!

Hi @megaposer,
We've recently added build info integration to the CLI, through the download, upload, build-collect-env and build-publish commands and soon, we'll also add a command for build promotion and build distribution.
We really like your idea of also integrating with VCS repositories (functionality which is currently supported when running your build from Bamboo, Jenkins and TeamCity). Thanks for sharing this idea. This is something we might want to add in the future.

Hi,
thanks for your quick response ;-) Yes, tying in and populating the the build-info via download, upload and build-collect-env is working nicely already and is a very good starting point.
Maybe an additional command such as build-add-props accepting either a path to a JSON definition file (similar to the file-spec) or a flattened list of key-value-properties for injection into the "general part" of the build-info properties would be a way to achieve this in an extendable fashion?
Looking forward to this!
Thanks again!

Hi @megaposer ,
We are going to add a build-collect-git-info command.
jfrog rt build-collect-git-infojfrog rt build-collect-git-info <buildName> <buildNumber> [optional: path to .git]
In case the third argument is not specified, the command will try to get the .git directory from the current working directory.
If you want to, you can look at the commit and build the dev branch to try this feature.
We will be happy to get your feedback regarding this feature.
Please notice, this feature is not officially released therefore some changes within the command can be made.

Hi @TamirHadad - thanks for the feedback and for adding this. Almost everything we need, besides the possibility to add the CI server URL (see my initial request). Also, and this is were it gets more complex, when triggering a CI build, using a git repo for this info might not work properly, as Bamboo for instance performs shallow clones by default and might clone more than one repo. Of course, using the git repo information is very convenient and probably caters to 80% of all use cases already.
Maybe this information could be fed from environment variables?

See https://github.com/JFrogDev/jfrog-cli-go/pull/59

@megaposer,
Version 1.14.0 includes a new --build-url option for the build-publish command.
We'd appreciate your feedback for it.


Improving GitHub Actions workflow and local testing

Description & Motivation
Workflow files have been rewritten:

Now documentation will be generated only after successful testing, which will reduce the time it takes to use the GitHub Actions infrastructure.
Upgraded version of actions/checkout (2 -> 3).
Workflow steps are moved to separate scripts for reuse.
Removed binding to the outdated version JamesIves/github-pages-deploy-action (4.1.1 -> 4).
Now Icarus Verilog version 11 is installed from the repository, which allows you not to waste time compiling.
Added a timeout for jobs to protect against overuse of the GitHub Actions infrastructure.
Jobs now have restricted permissions, which improves protection against certain threats.
Added validation of documentation generation (had to handle output instead of error codes).

A new script tool/run_checks.sh has been added, which is intended to make it easier to test locally before pull requests or commits.
Related Issue(s)
No.
Testing
The following tests were carried out on our own fork:

SUCCESS: Run Checks
SUCCESS: Run Checks + Deploy Documentation
FAILURE: dart format
FAILURE: dart analyze
FAILURE: dart doc
FAILURE: dart test

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No.
Documentation

Does the change require any updates to documentation? If so, where?  Are they included?

Perhaps the contributor guide should mention the tool/run_checks.sh script, which aims to be as similar as possible to the GitHub Actions workflow. It is enough to run only it and eliminate the identified errors, and not manually enter a sequence of commands. These recommendations do not ship with this pull request.

I will also add a check for the "tmp_test" directory as specified in #178.


Datasets reorganization

Here we've moved code for downloading and handling the CIFAR, MNIST, and FashionMNIST datasets used by the example scripts into separate modules under Axon.Data.
Most of the change are reorganization and de-duplication of code for downloading and processing datasets, but we also add options to change the batch size as well as the directory where datasets are stored. This allows for calls like
Axon.Data.MNIST.download_images(data_path: 'tmp/my_data/mnist', batch_size: 200)

The API for MNIST and FashionMNIST looks like
# Fetch images and labels together
{train_images, train_labels} = Axon.Data.MNIST.download()

# Or get them separately
train_images = Axon.Data.MNIST.download_images()
train_labels = Axon.Data.MNIST.download_labels()

Right now Axon.Data.CIFAR only supports download/1 which returns the image/label tuple.
I'm not sure exactly where these modules should be located in the repo--I'd greatly appreciate feedback on that and any other suggestions!

What if move this outside of Axon into a separate datasets library? 🤔 For example, I can see using datasets in dev/test but there is no need to have it in prod.

I agree with @josevalim I really like the idea of having this in a separate library. Something similar to Torchvision, Torchtext, etc. It looks like the framework is already mostly there as well for downloading the datasets.

A separate library makes sense. Should it be inside the Axon repo, comparable to e.g. exla inside the Nx repo but alongside the nx project, or totally separate?

A totally separate project. :) we will also move EXLA and Torchx outside of Nx at some point once they become more stable.
btw, should we return binaries on download or should we return tensors? I guess binaries are fine and more general purpose?

A totally separate project. :) we will also move EXLA and Torchx outside of Nx at some point once they become more stable.
btw, should we return binaries on download or should we return tensors? I guess binaries are fine and more general purpose?
The only maybe reason to have it in binaries is if you want to pass the images to another lib for image processing (if needed).

Returning tensors would be nice for immediate use with Axon and Nx: the user wouldn't have to worry about the shape of the dataset to process the binaries.
Image processing with another library would certainly be a reason to keep them as binaries or in a different format. @nyo16 do you have any elixir libs in mind? Torchvision.datasets returns PIL images and conversion to tensors happens with a transform function.
We could do something similar here by returning a tensor--converted from binary and with a transform/1 option applied to it. Changes would be necessary as progress is made on #25.

Could we make it return {binary, type}? So we just need to unpack it and call Nx.from_binary?

Maybe {binary, type, shape}?

Sounds good to me!

Returning tensors would be nice for immediate use with Axon and Nx: the user wouldn't have to worry about the shape of the dataset to process the binaries.
Image processing with another library would certainly be a reason to keep them as binaries or in a different format. @nyo16 do you have any elixir libs in mind? Torchvision.datasets returns PIL images and conversion to tensors happens with a transform function.
We could do something similar here by returning a tensor--converted from binary and with a transform/1 option applied to it. Changes would be necessary as progress is made on #25.

I think this would be great. My cases are around augmentation of the image(s). I don't have a specific lib in mind.
I like your idea to pass an optional transformation.

@nyo16 With respect to augmenting images, you might be interested in: https://github.com/4rtemi5/imax
It is a pure Jax implementation of image augmentations and transformations. Theoretically, a library like that could be written entirely in Nx defn and then executed with something like EXLA to achieve the same effect without having to shell out to PIL or another library. Although, I assume PIL and others probably have more efficient implementations.

I've moved the changes in this PR to a different repo: https://github.com/t-rutten/axon_datasets.
download/1 returns a tuple like {binary_data, tensor_type, shape} and accepts transformation options. Further suggestions are totally welcome.
Per #52, I'd be happy to port current examples to Live Markdown files that utilize AxonDatasets via Mix.install/2 if that would be helpful.

Thanks @t-rutten! @seanmor5, should we have them inside the elixir-nx organization? Are you ok with this too, @t-rutten? Also, I am thinking we don't need Axon in the name, as they should be general purpose?

@josevalim If it is okay with @t-rutten I think it makes sense to have them in the organization so it's more visible. I would also drop Axon from the name so they are more general purpose for other ML libraries

Btw, the package name "datasets" is taken though, any suggestions?

Sure thing, let's move the repo to the organization.
NxDatasets? NxData? Nx is more general purpose than Axon...

Yeah but this isn't Nx related either. :D Which kinda of datasets are we going to keep? Maybe we can use something like that for the name?

ExDatasets?
Short, easy to type, shaped for Elixir consumption.

Good for SEO: DataScienceSets?
Short and descriptive, but not overly descriptive: Corpus? ExCorpus?
-bt

We can start with computer vision related datasets and add text ones later (I do like ExCorpus @batate).
Maybe ExVision? VisionData? ImageData?

ExCorpus.* seems pretty good to me.
ExCorpus.Vision
ExCorpus.Stats
ExCorpus.xxx
seems like a good start.

I feel like "corpus" denotes language and text. @batate maybe your first suggestion, ExDatasets, is best: ExDatasets.Image, ExDatasets.Text, ExDatasets.Audio.

Not a big fan of Ex prefixes... :D Based on your suggestions, I could think of: science_data / scidata / scisets / scidatasets / sci_datasets. I like scidata/Scidata.

scidata is excellent.

I like scidata!

Perfect! @t-rutten, I have created a repo in this organization, alongside a team, and gave you access: https://github.com/elixir-nx/scidata
Feel free to push or submit a PR to the scidata repo accordingly. :)

Great, thanks @josevalim!

@t-rutten I pushed an initial commit with the LICENSE and made sure you have the proper write permissions. :)


⚠ WSINGRESOS - OXXO has degraded performance

In 1179566, WSINGRESOS - OXXO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/compartido/wspagosoxxo.r) experienced degraded performance:

HTTP code: 200
Response time: 2642 ms

Resolved: WSINGRESOS - OXXO performance has improved in 7149887.


Missing eap field for productDescriptor

What happened?
productDescriptor builder is missing eap flag
Relevant log output or stack trace
No response
Steps to reproduce
intellijPlatform {
    pluginConfiguration {
          productDescriptor {
              eap = true // doesn't compile
          }
        }
    }

Gradle IntelliJ Plugin version
2.0.0-beta8
Gradle version
8.7
Operating System
None
Link to build, i.e. failing GitHub Action job
No response

How did you come with the eap property? It's not available in the API: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-extension.html#intellijPlatform-pluginConfiguration-productDescriptor
PS, please upgrade to the latest 2.0.0-RC1

This flag is now available in 2.0.0-RC1


Deploy swift not on a cluster.

Cluster deployment is broken

Can we try with https://github.com/crowbar/crowbar-openstack/pull/242?

sure. closing for now.


different results from plot_posterior_predictive when run twice

Hello and thanks for the great library.
When I run mmm.sample_posterior_predictive(mmm.preprocessed_data['X'], extend_idata=True, combined=True) followed by mmm.plot_posterior_predictive(original_scale=True);, I get the following plot:

Then, if I run the same code again, I get this plot:

Is this expected?
I am using v0.3.3

Can you share your setup code? Are there any fits as well?

I'm be happy to! Here are a few of the plots/tables used in the example guide as well as my model config (just uniform priors mostly); however, even when I use more informed priors I find this same effect.
Please let me know if this helps! Glad to share other metrics.
my_model_config = {
    "intercept": {"dist": "Uniform", "kwargs": {"lower": 0, "upper": 1}},

    "beta_channel": {
        "dist": "Uniform",
        "kwargs": {"lower": 0, "upper": 1},
    },
    "alpha": {"dist": "Uniform", "kwargs": {"lower": 0, "upper": 1}},
    "lam": {"dist": "Uniform", "kwargs": {"lower": 0, "upper": 1}},
    "likelihood": {
        "dist": "Normal",
        "kwargs": {"sigma": {"dist": "HalfNormal", "kwargs": {"sigma": 2}}},
    },
    "gamma_control": {"dist": "Uniform", "kwargs": {"lower": 0, "upper": 1}},
    "gamma_fourier": {"dist": "Uniform", "kwargs": {"lower": 0, "upper": 1}},
}

Hi @Alcampopiano
Was there additional setup prior to calling sample_posterior_predictive?
I have not encountered this and the example notebook don't experience this as well.
Would you happen to know if this has been resolved with the later versions?

Hi @wd60622
Thanks very much for checking in.
Unfortunately, I dont have that project anymore—otherwise I'd be happy to try and reproduce.
I suspect that newer versions of pymc-marketing are not affected as you mention.
Thanks for all the great work!

Closing as it might be stale. Feel free to open if encountered again


Update PS code language to proper noun capitalization

Per the PS docs, we're supposed to be doing it this way ...
✔ ```PowerShell
... not ...
:x: ```powershell

Where did you see that? Here it's all lowercase, which is the standard way to do all languages in this setting:
https://learn.microsoft.com/en-us/powershell/scripting/community/contributing/powershell-style-guide?view=powershell-7.4#markdown-for-code-samples

All over the place ... for example in that article a little further down ...
https://learn.microsoft.com/en-us/powershell/scripting/community/contributing/powershell-style-guide?view=powershell-7.4#avoid-using-powershell-prompts-in-examples
However, they're somewhat scatterbrained about it ...
https://learn.microsoft.com/en-us/powershell/scripting/community/contributing/powershell-style-guide?view=powershell-7.4#formatting-cmdlet-reference-articles
... and ...
https://learn.microsoft.com/en-us/contribute/content/code-in-docs#supported-languages
... but it's all over the place. Here are some examples (separate articles ... there are tons of them) ...

https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/01-getting-started?view=powershell-7.4#how-do-i-launch-powershell
https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/02-help-system?view=powershell-7.4#get-help
https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/03-discovering-objects?view=powershell-7.4#properties
https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/04-pipelines?view=powershell-7.4#one-liners
https://learn.microsoft.com/en-us/powershell/scripting/learn/ps101/05-formatting-aliases-providers-comparison?view=powershell-7.4#format-right

.... and it just keeps going like that. They say to use all lowercase; but in practice, they seem to never actually use lowercase AFAICT.

I'll close this, but I think someone should take it up with them to see if they really do want "PowerShell" for command shell blocks.

I don't see where it is uppercase except when rendered -- the  source for the one you mention at 7.4 avoid using is
Prompts are required in examples to illustrate commands that alter the prompt or when the path
displayed is significant to the scenario. The following example illustrates how the prompt changes
when using the Registry provider.

```powershell
PS C:\> cd HKCU:\System\
PS HKCU:\System\> dir

    Hive: HKEY_CURRENT_USER\System

Name                   Property
----                   --------
CurrentControlSet
GameConfigStore        GameDVR_Enabled                       : 1
                       GameDVR_FSEBehaviorMode               : 2
                       Win32_AutoGameModeDefaultProfile      : {2, 0, 1, 0...}
                       Win32_GameModeRelatedProcesses        : {1, 0, 1, 0...}
                       GameDVR_HonorUserFSEBehaviorMode      : 0
                       GameDVR_DXGIHonorFSEWindowsCompatible : 0
```


Add cocoapods

Hello
I already create a podspec file pointing to your repository so people could use AEXML via cocoapods.
Please recheck AEXML.podspec for the correctness.
ps. this is my first try, I'm sorry for any mistakes.

Hi, thanks for the effort, I have just added CocoaPods support, so I'll just close this pull request.


RenderParagraph reports incorrect text boxes for justified text

RenderParagraph returns mis-aligned text positions and boxes when the displayed text is justified.
This issue is captured transitively in an issue filed against super_editor:
https://github.com/superlistapp/super_editor/issues/144
The reported Flutter version is:
Flutter (Channel stable, 2.0.5, on macOS 11.2.3 20D91 darwin-x64)

Is this still happening on master?
There were some recent fixes in libtxt related to this (specifically https://github.com/flutter/engine/commit/53a783bbf696686b56bd5b47c5214b1a42e57764)

Yeah, it looks like it's still happening on master.
Flutter 2.3.0-17.0.pre.259 • channel master • https://github.com/flutter/flutter.git
Framework • revision ba5208122a (58 minutes ago) • 2021-06-07 23:29:04 -0400
Engine • revision b5dca5d4b4
Tools • Dart 2.14.0 (build 2.14.0-188.0.dev)

Here is a video demonstrating the issue in a paragraph of justified text. The text interaction is custom built, but the Offset for the caret is based on calls to RenderParagraph:
https://user-images.githubusercontent.com/7259036/121123343-ea6f7080-c7d7-11eb-982b-4a1d5627854f.mov

This is still happening. This is a dealbreaker for me to use Flutter at this point for my use case, unfortunately. I really love the framework.

Flutter (Channel stable, 2.8.1, on macOS 11.6 20G165 darwin-arm, locale en-GB)

I'm checking in on this issue after 2 years of no activity. Can someone please run this through triage again? I find it hard to believe that this isn't a high priority.

nd this fellows, is what we call technical debt. Hope it gets attention soon!


Allow partial bind?

Given the following lines of code:
const eventStoreTable = new Table(...);

const eventWriteHandlerLambda = new Function(...);
eventWriteHandlerLambda.attachPermissions([eventStoreTable, "grantReadWriteData"]);

const eventReadHandlerLambda = new Function(...);
eventStreamHandlerLambda.attachPermissions([eventStoreTable, "grantReadData"]);

I get the following deprecation notice:
WARNING: Passing SST constructs into "permissions" is deprecated, and will be removed in SST v2. Pass them into the "bind" prop. Read more about how to upgrade here — https://docs.serverless-stack.com/upgrade-guide#upgrade-to-v116

The problem is that bind will give full access to the resource, while I only want to do it partially.

Hi @fwang,
Wrapping the array inside another array seems to satisfy TypeScript, but it fails in runtime:
Error: The specified permissions are not supported

Yeah you need to pass in the underlying CDK's construct. Try this
eventStreamHandlerLambda.attachPermissions([[eventStoreTable.cdk.table, "grantReadData"]]);

Yeah, it seems to be working now. Thanks!


Update style names to be more specific

What

We want to overhaul all class names to avoid https://github.com/obsidianmd/obsidian-releases/pull/4655#issuecomment-2479866528
A simple pattern could be preprending a string of llm-, but even this may be considered to be too generic.

Closed by #211


UI: Fix issue on volume snapshots wizard

Description
This PR fixes an issue observed at the volume snapshot operation under the following conditions:

Take volume snapshot of volume (click OK on the wizard)
While the operation is still in progress, click Take volume snapshot again
Wait until the first operation finishes
Try taking volume snapshot -> ERROR: missing parameter volumeid

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
Explained on the PR description

@blueorangutan ui

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6066 (SL-JID-1217)

@blueorangutan ui

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6066 (SL-JID-1220)


ci(workflows): patched workflow version issue

:tada: This PR is included in version 4.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add abi3-py* features

For #1195, but still needs some design enhancements.
This PR adds some feature flags that can be used to specify the minimum required version when building abi3 wheel.
E.g., you can build cp36-abi3-manylinux1 wheel with Python3.8 if you use abi3-py36 feature.
I still have some questions:

Should this be set by features or environmental variables?
How do we support cp3-abi3 wheels? I think it's better for tools (maturin or setuptools-rust) to allow this renaming with some configuration. cc: @konstin

For folks who are not familiar with PEP425 (like me!), here's the link: https://www.python.org/dev/peps/pep-0425

[ ] documentation

Now I think that using the environmental variable is easier for users and tools... :thinking:

Environment variables are definitely much easier to set. Also that way my build configuration won't be affected by thirdparty packages (any package I include in my dependencies could incorrectly enable these features).
It's also kinda hard to understand how these features interact. If I set abi3-py36 and abi3-py38 but not any other feature, what does it mean? Is my wheel only supported for python 3.8 and up? Or am I restricted to only using python 3.6 features?
A single environment variable PYO3_ABI3_VERSION might be easier to understand.

I believe that we need some place, likely in Cargo.toml or pyproject.toml, that specifies the minimum supported python version. pyo3 should have cfgs that enfore that only symbols available at that version are available. setuptools-rust and maturin can use this to set the appropriate Requires-Python and abi tag. I like the solution with features particularly because we can read those with cargo metadata.

It's also kinda hard to understand how these features interact. If I set abi3-py36 and abi3-py38 but not any other feature, what does it mean? Is my wheel only supported for python 3.8 and up? Or am I restricted to only using python 3.6 features?

I'd define it so that abi3-py36 means that all symbols that are 3.7+ are removed by cfgs.

I believe that we need some place, likely in Cargo.toml or pyproject.toml, that specifies the minimum supported python version.

I could be wrong, but I don't think it's possible for pyo3's build.rs to read metadata of downstream crates in a reliable way?

I don't think it's possible for pyo3's build.rs to read metadata of downstream crates in a reliable way?

I think @konstin meant that maturin or some tools can read the metadata.

setuptools-rust and maturin can use this to set the appropriate Requires-Python and abi tag.

That makes sense.

I confirmed this works with maturin's pyo3_pure example. My system Python is 3.8, and the built wheel works in Python 3.6 after renamed.

'limited to extension-module' problem

I don't think it's so problematic. abi3 does not mean so much in embedding cases.

Windows problem

Nice point. It's certainly problematic. But I want to test this on Windows (by CI?) before moving to another solution.

I don't think it's so problematic. abi3 does not mean so much in embedding cases.

👍 - maybe should we set the feature abi3 = ["extension-module"] in Cargo.toml?

Windows problem

Note that as well as windows, also tests will not link with cargo test without our default features workaround.
I was hoping that after #1123 we would be able to run cargo test without such a workaround.

maybe should we set the feature abi3 = ["extension-module"] in Cargo.toml?

Sounds too restrictive to do so.

Binaries trying to link against a higher python version than the actual installed libpython will fail because symbols will mismatch

Can this happen even with abi3?
I didn't observe it fails in Linux + linking setting (i.e., no 'externsion-module' and not manylinux).
cc: @alex

Yes, if you build an ABI3 wheel that targets 3.9 as the minimum version, it may fail when you try to load it against a 3.6 CPython. (Note that it'll only fail if you use a symbol that was recently added to the ABI3 ABI, if you target a higher minimu version but don't use any newer symbols, it'll probably just work.)

Note that it'll only fail if you use a symbol that was recently added to the ABI3 ABI, if you target a higher minimu version but don't use any newer symbols, it'll probably just work.

Ah, it makes sense, thanks. Maybe we should prohibit setting a higher version.

I'm leaning towards setting this as a feature flag.
They just change the #[cfg(Py_*)] and don't seem so problematic as extension-module.

Ah, it makes sense, thanks. Maybe we should prohibit setting a higher version.

I think @konstin highlighted an interesting case where someone can in theory use this setup to build an abi3-py39 wheel without _any_ Python on their system (or maybe only e.g. Python 3.6 installed). This would work because extension-module doesn't actually need to link anything, so we can just use the pyo3::ffi definitions.
But I agree that in 99% of cases a higher version is a problem, because it means that tests (e.g) might unexpectedly fail to link. So I suggest that if we detect in build.rs that the abi3 version > python version, we emit a friendly error message informing so and invite the user to set an enviroment variable e.g. PYO3_ALLOW_NEWER_PYTHON=1 to opt-in to this.

I still want to push a concern with features vs environment-variables. Imagine we have a library lib and an extension module extension-module.
lib/Cargo.toml
[dependencies]
pyo3 = { version = "...", features = ["abi3-py37"] }

extension-module/Cargo.toml
[dependencies]
lib = "..."
pyo3 = { version = "...", features = ["extension-module", "abi3-py36"] }

Now we want to use maturin (or setuptools-rust) to build extension-module. The packaging tool can scrape the abi3 version from the metadata for extension-module, and detects Python 3.6.
So the packaging tool makes a Python 3.6 wheel.
However this is a bug: lib sets the abi3-py37 feature, and so pyo3 will allow use of Python 3.7 features to be in the built extension module. The wheel might not actually work on Python 3.6 at all.
If instead maturin were to set an environment variable PYO3_ABI_VERSION=3.6 then lib would not accidentally be able to break our wheel - instead lib would just fail to compile.

So I suggest that if we detect in build.rs that the abi3 version > python version, we emit a friendly error message informing so and invite the user to set an enviroment variable e.g. PYO3_ALLOW_NEWER_PYTHON=1 to opt-in to this.

For now I don't think we need to support such a rare case. I'm willing to change the behavior if a user complains about, though.

However this is a bug: lib sets the abi3-py37 feature, and so pyo3 will allow use of Python 3.7 features to be in the built extension module. The wheel might not actually work on Python 3.6 at all.

I tried that and confirm that it just fails to compile (and noticed the bug of feature definitions...).
I think env var is also good, but I also think that it would add additional works for tools.
If we use the feature for this, what tools do is just two things: read the feature flag and name the wheel.
But, if we use an env var, tools additionally have to define the interface of the minimum required Python version: e.g., by pyproject.toml.

For now I don't think we need to support such a rare case. I'm willing to change the behavior if a user complains about, though.

👍

I think env var is also good, but I also think that it would add additional works for tools.
If we use the feature for this, what tools do is just two things: read the feature flag and name the wheel.
But, if we use an env var, tools additionally have to define the interface of the minimum required Python version: e.g., by pyproject.toml.

I guess, but tools are great for doing lots of work for the user so I'm not sure that's such a big problem! 😄
Anyway I guess to learn more about this design the best way now might be to merge it? We can then try out the implementations in setuptools-rust and maturin and see how it goes.
(We can give a little time between merging and releasing to experiment... or even release a pyo3 0.13.0-alpha1 to try it out?)

I finally got around to prototype what I had in mind: diff. The idea is that you always have to set a minimum version, as the code will have one implicitly anyway. This then makes it possible on maturin's side to build without checking for python interpreter (diff). This makes it possible to build for your minimum target version without the error prone process of finding python versions, with which I had a lot of trouble in maturin. It should also be faster since we avoid running python twice. (We could go even further and move pyo3's build script into a separate crate that is only built when abi3 is not used, but that's out of scope for now)

@konstin
Thanks. Does this also work for Windows?

Unfortunately not :/ Do you know why we do link(name = "pythonXY") on windows and whether it's possible to link the cdylib without reading the .lib file?

Do you know why we do link(name = "pythonXY") on windows and whether it's possible to link the cdylib without reading the .lib file?

No, I don't explicitly understand the difference. Just found some notes but still investigating.

why we do link(name = "pythonXY") on windows

If I recall (from experimentation last time I wondered this) #[link(name = "pythonXY")] is only needed on extern blocks that contain static mut variables. I'm not sure whether that's us misconfiguring things in build.rs, a bug in rustc, or a limitation in msvc's linker.
I'll try and see if I can reproduce this in a mvp for rust upstream.

whether it's possible to link the cdylib without reading the .lib file

Unfortunately I think msvc linker needs to resolve all the symbols from somewhere at build time.
Looks like there's an option we could try setting (similar to macos): https://docs.microsoft.com/en-us/cpp/build/reference/force-force-file-output?view=msvc-160 ... but it might just break stuff.

Updated: I added PYO3_NO_INTERPRETER env var to allow building a wheel without calling Python on *NIX.
Tools like maturin can make use of this feature.

FYI: How about releasing 0.13 after merging this PR? cc: @davidhewitt

Thank you for your kind reviews, now the docs are much better :smiley:


[enhancement] tamed wolves should not obey predator prey relationships

people use dogs for hunting and they train them not to take all the meat for themselves so why not apply that to this feature

Tamed wolfs in minecraft do not hunt.Only the wild wolfes hunt


Fixed bug where result wasn't being negotiated when version was missing

The HasValue check resulted in skipping the negotiation when the strategy didn't return a result. In that case, the negotiation should still be called, but with a null version, so it can return the default model.

@filipw What would it take to get this pushed to NuGet?

I can do it tomorrow, but also made you an owner if you wanna push it

I don't have the newer bits handy right now, so I can't build the solution 😢

it's there now - https://www.nuget.org/packages/WebApiContrib.Core.Versioning/

Thanks :heart:


[WIP][DNM] Fix windows failures

Testing to see if I can figure out why the node 14 win failure is consistently (but still sometimes intermittently) happening

I'mma leave this open for now while I ponder what might be wrong. I think it's Ava related. I think one of the test processes is getting killed towards the end.


kubeadm: update legacy kubelet config map information and document feature gates

has two separate commits.

first removes some instances of the legacy naming (kubelet-config-x.yy), controller by the UnversionedKubeletConfigMap feature which becomes beta in 1.24 and is enabled by default.
second documents the current state of feature gates

fixes https://github.com/kubernetes/website/issues/28788
xref https://github.com/kubernetes/kubeadm/issues/1582

/approve
/hold
I'm pre-approving this as the intent seems clear.
@neolit123 the /hold is only in case a stray LGTM comes in earlier than you'd hope for. It's fine to unhold this when this has LGTM and you are happy to see this merge.

/cc @SataQiu @RA489
PTAL for tech review / LGTM

/cc @pacoxu
as well since you have been following this effort.

@SataQiu @pacoxu thanks for review.
updated.

/approve

/hold cancel


FileNotFoundError during install on Windows

https://github.com/kennethreitz/pipenv/issues/213 is fixed, but now I'm seeing a different error in one of my Windows builds on AppVeyor (https://ci.appveyor.com/project/jacebrowning/env-diff/build/1.0.41):
$ pipenv install --dev --ignore-hashes
No package provided, installing all dependencies.
Pipfile found at C:\projects\env-diff\Pipfile. Considering this to be the project home.
Installing dependencies from Pipfile.lock...
An error occured while installing!
Traceback (most recent call last):
  File "C:\Python36\Lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "C:\Python36\Lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\projects\env-diff\.venv\Scripts\pip.exe\__main__.py", line 9, in <module>
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\__init__.py", line 233, in main
    return command.main(cmd_args)
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\basecommand.py", line 252, in main
    pip_version_check(session)
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\utils\outdated.py", line 102, in pip_version_check
    installed_version = get_installed_version("pip")
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\utils\__init__.py", line 838, in get_installed_version
    working_set = pkg_resources.WorkingSet()
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 644, in __init__
    self.add_entry(entry)
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 700, in add_entry
    for dist in find_distributions(entry, True):
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 1949, in find_eggs_in_zip
    if metadata.has_metadata('PKG-INFO'):
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 1463, in has_metadata
    return self.egg_info and self._has(self._fn(self.egg_info, name))
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 1823, in _has
    return zip_path in self.zipinfo or zip_path in self._index()
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 1703, in zipinfo
    return self._zip_manifests.load(self.loader.archive)
  File "c:\projects\env-diff\.venv\lib\site-packages\pip\_vendor\pkg_resources\__init__.py", line 1643, in load
    mtime = os.stat(path).st_mtime
FileNotFoundError: [WinError 2] The system cannot find the file specified: 'c:\\projects\\env-diff\\.venv\\lib\\site-packages\\colorama-0.3.9-py3.6.egg'

This is using pipenv 3.6.0 and reinstalling the latest version of pip per @nateprewitt's suggestion.

Hey @jacebrowning, so as I said in the other issue, this stacktrace doesn't actually touch any pipenv code but is raised from pip itself. I'm doing a little bit of digging to see if I can pinpoint why but this isn't a high priority at the moment.
For now, simply running pipenv lock and updating your Pipfile.lock fixes the problem. I'm not sure if you somehow have a bad lockfile or if there's another issue yet.

Here is the Pipfile.lock: https://github.com/jacebrowning/env-diff/blob/cb2a8763898f70f6a48a13d6ad2ef7dc139cdf16/Pipfile.lock
Weirdly, Pipfile.lock calls out "==0.3.7" for colorama, but the error is about a missing "colorama-0.3.9-py3.6.egg".

@jacebrowning, yeah, that's one of the anomalies that needs to be looked at. If you update that Pipfile.lock, the error goes away, at least from my experiments in appveyor earlier. That will get env-diff running for now.

@nateprewitt Thanks for the tip! My dependencies install correctly after rm Pipfile.lock; pipenv install. I don't know how my Pipfile.lock got into a bad state, but it would be nice if pipenv could catch this and provide a more helpful error message.

closing due to age. will pop up again if it's an issue.


Post multiply

What do these changes do?
This PR is needed for a next PR where we support fused activation functions. We will then have the following computations applied at the end of the bgemm kernel:

backtransformation x = n - 2 * x (can be done in int32)
fused activation x = relu(x)  (can be done in int32 or float)
post-multiply and post-add x = a + b * x  (must be done in float. Comes from potential BatchNorm layers or other Mul and Add layers).

Currently there is no fused activation, so the backtransform and post-multiply&add are currently merged into one multiply&add.  This PR will split those two, so that its ready for fused activations.
The PR also renames fused_{add,multiply} to post_{add,multiply}, to make it extra clear that this transformation comes after the activation function (which is usually the final thing in an op).
How Has This Been Tested?

The C++ unit tests have been updated to no longer include the backtransform into the post-multiply&add.
Benchmark Results

Since the backtransform and post-multiply&add are now separate, it might slow things down.
TODO

Will we still do the backtransform add/mul with the post-transform add/mul together as one op if there's no relu inbetween?

Will we still do the backtransform add/mul with the post-transform add/mul together as one op if there's no relu inbetween?

We could do that but I think at least for now we will not. Just like the tflite kernels will always add a bias term, even if there is no bias input tensor.

I believe the C++ compiler will do that automatically. Additionally, this
is reference code not supposed to be fully optimized but rather should be
very readable.
We should check if this trick can be done in the assembly kernel though :+1:
On Wed, Mar 4, 2020, 13:36 Lukas Geiger<EMAIL_ADDRESS>wrote:

@lgeiger commented on this pull request.
In larq_compute_engine/core/bgemm_kernels_ruy.h
https://github.com/larq/compute-engine/pull/260#discussion_r387637901:

@@ -91,12 +91,15 @@ struct BgemmKernel<ruy::Path::kStandardCpp, LhsScalar, RhsScalar, DstScalar,

       TBitpacked rhs_val = Element(rhs, k, j);

       accum += xorpopcount<TBitpacked, AccumScalar>(lhs_val, rhs_val);

     }

   // Backtransform can still be done in int32

   accum = spec.backtransform_add - 2 * accum;

Should we do something like this here, or am I missing an edge case?
⬇ Suggested change

   accum = spec.backtransform_add - 2 * accum;

   accum = spec.backtransform_add - (accum << 1);

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/larq/compute-engine/pull/260?email_source=notifications&email_token=AAB4VQGTZHDDV6NZXC4ZPC3RFZDLJA5CNFSM4LAQDVD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCX5ITHY#pullrequestreview-368740767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB4VQG76HIWYCCLAP7FHB3RFZDLJANCNFSM4LAQDVDQ
.


Fixed an issue which disable previously registered event when subscribing a new one into Locator.events

I found a bug in the code about the authorisation level listeners.
See the following scenario:
let token1 = Locator.events.listen { newStatus in
	print("[Observer1] Authorization status changed to \(newStatus)")
}

let token2 = Locator.events.listen { newStatus in
	print("[Observer2] Authorization status changed to \(newStatus)")
}

// BUG: the previous listener is overwritten instead of having both active and token2 = token1

// In a second time you may decide to remove one only
Locator.events.remove(token1)

// BUG: both listeners are removed because token2 = token1

The issue is coming from the following code :
/// Add a listener for authorization change status
///
/// - Parameter callback: callback to call
/// - Returns: token used to remove the listener in a second time.
public func listen(forAuthChanges callback: @escaping AuthorizationDidChangeEvent) -> Token {
	var (next,overflow) = self.nextTokenID.addingReportingOverflow(1)
	if overflow {
		next = 0
	}
	self.callbacks[next] = callback

        // NOTE: That is the line to add to fix and handle multiple listeners
        self.nextTokenID = next

	return next
}

I hope that you can integrate this change in the next release.
Thanks for sharing your library.
Regards

Thank you for your help; I've added it to the develop branch ready for 3.3.0.


rancher-compose.yml generated for LB has " config" appended to the name in " load_balancer_config" section.

Server version - V0.32.0-rc2
Create a LB service.
Use "View Config" option to view the generated rancher-compose.yml
Lb config generated for the LB service's name has "lb-2 config" .
lb-2:
scale: 1
load_balancer_config:
description: lb-2
name: lb-2 config
This is not causing any issue. But the name is stored as " lb-2 config" in load_balancer_config table. Is it better to not have any space in name and instead have it named in the format _config?

@sangeethah the name having " config" in it is the name passed to the createLoadBalancerService.loadBalancerConfig.name field. If no name is passed, Rancher code generates one (and it doesn't have spaces).
I've tested from the UI, the UI passes the config name with the space. @sangeethah double check if Rancher compose does the same. And if you are not ok with this name format, pls reassign the bug to the UI/Rancher-compose components.

This should eventually go away with the removal of the standalone balancer from the API...

Closing as this no longer exists today.


SPInstall Get-TargetResource doesn't work for Sharepoint Foundation 2013

Details of the scenario you try and problem that is occurring:
When installing Sharepoint Foundation 2013 using SPInstall Get-TargetResource searches the "HKLM:\Software\Microsoft\Windows\CurrentVersion\Uninstall*" registry key for "Microsoft SharePoint Server (2013|2016)", this won't give a match for "Microsoft SharePoint Foundation 2013".
The DSC configuration that is using the resource:
N/A
Version of the Operating System and PowerShell the DSC Target Node is running:
Windows Server 2016, Powershell 5
Version of the DSC module you're using:
<IP_ADDRESS>

Hi @Identitry, unfortunately we do not support SharePoint Foundation with SharePoint DSC, only SharePoint Server.
@BrianFarnhill, I see that this isn't specifically mentioned in the Wiki page. Can I change the Wiki page manually or will that be overwritten when we regenerated the documentation?

Hey @ykuijs, I updated the main wiki page to clarify this (under Supported SharePoint versions). If you guys think it needs to be called out in the SPInstall documentation as well, that could be updated in the Readme.md under that resource I believe.

Yea we mention in the SPInstall documentation how to install SP Foundation (see example 3), but I think we need to put something in the readme for this documentation and in the supported versions part of the wiki as well.
@Identitry Check out that link above to get your SP Foundation install working
@ykuijs Can you include an update to the readme on SPInstall in your next bug fix PR if you're working on one?
@ronx Wanna update the wiki page that has the supported SharePoint versions?
Thanks guys

@BrianFarnhill sure, main wiki page is updated. Good idea, @ykuijs.

Done!


Add overlapping fields (index-alias for index state management)

Description
Address feedback about documenting overlapping fields
Issues Resolved
#4336
Version
Backport 2.15
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli commented on Jul 11, 2024, 11:16 PM GMT+8:

@bowenlan-amzn Would you or other index management team member be available to technical review this PR? It addresses community feedback about Undocumented  behavior  for  when  two  indexes  with  overlapping  field  names  are  associated  with  the  same  alias.  What  happens  when  these  are  different  types?  There  appears  to  be  some  kind  of  implicit  casting  that  occurs. Thank you.

I'm not sure there's implicit casting. I suggest we wait for an example showing this is happening. I did a very simple experiment by creating 2 indexes like you wrote in the documentation. Then index some data and do a simple search, I don't see any casting. There maybe some circumstances that some query can do the casting behind the scene but I am not aware.

@bowenlan-amzn I'm closing this PR. This was to address community feedback. When the issue arises, the dev team can create open a new PR. Thanks for your help.


new version problems

[ ] the line chart in the brush chart is a little bit pushed to the left. (both on live and local)
[x] synchronised chart is showing drilldown chart in local.
[ ] the eraser in the canvas doesnt function like a pen and deletes more than what is intended.
[ ] the eraser in the 'esignature with custom tools' doesn't function like a pen and deletes more than what is intended.
[x] in the sidebar categories, buttons and canvas is above forms in the live, but below in the local.
[x] may be not a bug: the range slider is smaller and doesnt occupy the same space as live version.
[ ] Both in the live & new version, the async versions of searchable select & multi select don't show that an item is selected when an unique item is typed. for example, when 'blackb' is typed, the only possible match is displayed and enter selects it, but the ui doesn't show that it was selected (doesn't darken) prior to pressing enter.

I noticed these new features:

the local bar chart (and few others) can change values live without reloading.
the checkbox can be checked unlike the live.
the uploaded files are displayed in the new file Uploader.
some small components are centered in the canvas.

@soyef-bit
Both in the live & new version, the async versions of searchable select & multi select don't show that an item is selected when an unique item is typed. for example, when 'blackb' is typed, the only possible match is displayed and enter selects it, but the ui doesn't show that it was selected (doesn't darken) prior to pressing enter.
in this issue.. the selected item is highlighted already.. please check the screenshot..

@sabirveli @soyef-bit I think the problem happens only on first load.
@soyef-bit please move this to another issue, as it is not a "New version problem"
Anything that works similar to live is not a bug as far as new version is concerned.
If you feel, that it is a bug, please open separate issue. Avoid conflating issues


Implement feature described in issue #11

This PR implements the feature described in issue #11. The code was generated using devGPT, a GitHub bot based on GPT-4.

Changes have been made based on the review comments. Please review the updated code.


Wiki / Manual - What is Merge

Sorry.. I'm not sure if this is the standard place to ask a question, but couldn't find anywhere else.
What does the "merge" option do?

Hi! No worries; this is the right place to ask.
If you already have a backup and you make another one, then:

With merge disabled, the old backup folder will be deleted, and the new backup will happen from scratch.
With merge enabled, whichever games you're backing up will be added/updated in the old backup folder. For example, if you only select to back up 10 games, then just those 10 will be updated in the backup folder, and any others will stay how they were. For the games that do get updated, Ludusavi will only copy over new/changed files, and then it will remove any old backup files for that game if it couldn't find them on your system.


Get rid of TravisCI and replace Coveralls with GitHub Actions + CodeCov

xD

Coveralls app after 2 years still can't handle JaCoCo output (https://github.com/coverallsapp/github-action/issues/22). We need to fully switch to CodeCov.

Resolved in ec4bd8018425990d8c7f0ad6ee622cd9ef4f2f65


Update Equipool Stratums

Equipool now reports each stratum separately. This commit enables the explorer to list each stratum's hex.

Thank you for the PR.
Our new explorer is looking for an address instead of the string. Can you make a PR to this repository as well? https://github.com/TheTrunk/insight-api/blob/master/pools.json . We are still testing the new explorer and are keeping both versions for now.


[BUG] Found an error on pio_usb_host.c

So I was playing around with that file given that I'm writing an xinput USB host implementation for the Pico, when I found a bug.
It looks like it is a typo, it is on line 851 (request_length is declared on line 849):
https://github.com/sekigon-gonnoc/Pico-PIO-USB/blob/main/src/pio_usb_host.c#L851
  uint16_t request_length =
      get_configuration_descriptor_request.length_lsb |
      (get_configuration_descriptor_request.index_msb << 8); // <- HERE, that *index_msb* should be *length_msb*

It should say:
  uint16_t request_length =
      get_configuration_descriptor_request.length_lsb |
      (get_configuration_descriptor_request.length_msb << 8);

It is a minor typo, but generates wrong information.

@luisibalaz  thanks for this! I ran into this problem a few months back when I was porting a driver from the PICOs USB to PIO.


⚠ Bofrost.at has degraded performance

In ccc3b6f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3960 ms

Resolved: Bofrost.at performance has improved in ca5bb60 after 8 minutes.


Add opportunity to filter tests

With this PR a user can filter tests for his run.
See Docs: http://docs.aws.amazon.com/devicefarm/latest/APIReference/API_ScheduleRunTest.html#devicefarm-Type-ScheduleRunTest-filter

Thanks, this looks great! I will try to make some time in the next week or two to test this. If it works I will merge & cut a new release.

thanks ;-)

You had a syntax error in the json that was causing run scheduling to fail. When I saw this I realized there were some serious problems with the error handling in this script as the step was reporting success. I've fixed those and the json syntax error in https://github.com/peartherapeutics/bitrise-aws-device-farm-runner/pull/41


Add missing IViewComponentTypeProvider abstraction

Related to issue #3752, a IViewComponentTypeProvider abstraction seems to be missing from the framework. Since View Components share much similarity with controllers, they deserve the same abstractions as controllers do. An IViewComponentTypeProvider abstraction is required to request all known view component types from the framework so they can be registered up-front in the container. Some containers require concrete types to be registered, while other containers (like Simple Injector) promote object graph analysis and verification, which require all root types to be registered. Just as controllers, view components are root types.

Found. The view component equivalent to the IControllerTypeProvider is the IViewComponentDescriptorProvider.


Code reproduction, training and pre-training code errors

Hi, I've been reproducing your work recently, and I'm glad the prediction code works fine, but I ran into a few issues when running the training code, and I look forward to your response!
1.
(1) I tried to run python LSF_Finetune.py -s {PATH TO SAVE FILE} and the first error was from NMR_Pretrain_Net import NMR_MPNN ModuleNotFoundError: No module named 'NMR_Pretrain_Net'
(2) I saw that other files used from neural_nets.NMR_4ll_Net import NMR_MPNN. After modifying and running again, the error became Traceback (most recent call last): File "LSF_Finetune.py", line 326, in <module> main() File "LSF_Finetune.py", line 222, in main Y_pred = model(h, g, rxn_vector) File "/home/datahouse1/wangqinggong/anaconda3/envs/lsf/lib/python3.7/site-packages/torch/nn/modules/module.py", line 889, in _call_impl result = self.forward(*input, **kwargs) File "/home/datahouse1/wangqinggong/SET_LSF_CODE-master/set_lsf/neural_nets/LSF_Finetune_Net.py", line 124, in forward gru_atom_type_subset = self.update_func[idx](h_atom_type_subset, m_atom_type_subset) TypeError: 'GRUCell' object is not subscriptable
(3) I used the Dependencies you provided, and tried to create different anaconda environments on different servers and use different Dependencies versions, but the problem still cannot be solved.
(4) Is the training code you provided here the final executable version, or are there any requirements for my server and environment?

Similarly, I also encountered problems when running python NMR_Pretrain.py -s {PATH TO SAVE FILE}.
Here, the number of data contained in the NMR pre-training file data/13C_nmrshiftdb.pickle is [5390 rows x 4 columns], 'MAX_N': 64, 'spectra_config': [('13C', 'dataset.named/spectra.nmrshiftdb_13C.feather')], 'tgt_nucs': ['13C']}, but an error was reported after running it.
How can I modify it? The error message is as follows:
Traceback (most recent call last): File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 3361, in get_loc return self._engine.get_loc(casted_key) File "pandas/_libs/index.pyx", line 76, in pandas._libs.index.IndexEngine.get_loc File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc File "pandas/_libs/hashtable_class_helper.pxi", line 2131, in pandas._libs.hashtable.Int64HashTable.get_item File "pandas/_libs/hashtable_class_helper.pxi", line 2140, in pandas._libs.hashtable.Int64HashTable.get_item KeyError: 5961 The above exception was the direct cause of the following exception: Traceback (most recent call last): File "NMR_Pretrain.py", line 223, in <module> main() File "NMR_Pretrain.py", line 140, in main for i, (g, h, Y) in enumerate(dataloader_train): File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 517, in __next__ data = self._next_data() File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 557, in _next_data data = self._dataset_fetcher.fetch(index) # may raise StopIteration File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch data = [self.dataset[idx] for idx in possibly_batched_index] File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp> data = [self.dataset[idx] for idx in possibly_batched_index] File "/home/data-house-01/wangqinggong/SET_LSF_CODE-Published/set_lsf/utils/NMR_Pretrain_Setup.py", line 535, in __getitem__ Y = self.df.loc[index, 'Y'] File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexing.py", line 925, in __getitem__ return self._getitem_tuple(key) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexing.py", line 1100, in _getitem_tuple return self._getitem_lowerdim(tup) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexing.py", line 838, in _getitem_lowerdim section = self._getitem_axis(key, axis=i) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexing.py", line 1164, in _getitem_axis return self._get_label(key, axis=axis) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexing.py", line 1113, in _get_label return self.obj.xs(label, axis=axis) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/generic.py", line 3776, in xs loc = index.get_loc(key) File "/home/data-house-01/wangqinggong/anaconda3/envs/GCN_new/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 3363, in get_loc raise KeyError(key) from err KeyError: 5961
Also errors are reported at different index positions KeyError: 1925

Hello @eat-sugar ,
Both the finetuning and pretraining should work now.


Update README.md to add intentions and revision policy

Adds a short blurb about the revision policy gbdev uses for revisions of this file and the intentions of what gbdev aims to do with it.
Fixes #16
Fixes #21

@avivace I updated rev_Check_hardware_inc to perform a SemVer compatibiliity check, please tell me if I got it wrong


CloudFront + force enable 2FA page (login redirect loop)

Unsure why, but when our website is behind AWS CloudFront it causes a redirect loop back to the /admin/login page rather than going to the force enable 2FA page when we have forceBackEnd=true.
When we test locally or direct to the ElasticBeanstalk instance, it all works.
Do you have any insight or advice on what might be causing this or how we might approach debugging it?

Hi @tonymilne unfortunately i don't have any experience with CloudFront. I know it's a CDN. Does it cache responses or interfere with sessions?
Can you disable forceBackEnd and login with 2FA enabled for your user? I want to know for sure it's the extra screen that causes the CloudFront redirect loop.

Yeah, we created an environment variable to control the forceBackEnd config and have turned it off until we can work out why it's causing us an issue.

I also wonder if it has anything to do with the index.php?p= approach, where as our other urls are not using that url/querystring approach.

@tonymilne can you login using 2FA when forceBackEnd is off? Or do you use the login without 2FA?
The urls the plugin uses should be generated. For our own projects we have omitScriptNameInUrls set for prettier urls, i'm guessing this is similar to your setup.
The logic you referred to does trigger the logout, but that is intended to prevent users to pass without 2FA (without that piece of logic the plugin would be useless).
The snippet came from an older version of the plugin, are you sure you are using the latest release? At this moment the plugin is at 2.1.1 which is build for craft 3.1.

@tonymilne do you still run into this?

Fixed in 2.2.0


HBASE-28979 Remove dead code: MemStore upsert

Since HBASE-24602, we no longer perform MemStore upsert for increment and append operations, and we can remove the dead code.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  3s

master passed

+1 :green_heart:
compile
2m 56s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 34s

master passed

+1 :green_heart:
spotless
0m 46s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
2m 53s

the patch passed

+1 :green_heart:
javac
2m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 38s
/results-checkstyle-hbase-server.txt
hbase-server: The patch generated 8 new + 25 unchanged - 0 fixed = 33 total (was 25)

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
hadoopcheck
10m 12s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

-1 :x:
spotless
0m 38s

patch has 47 errors when running spotless:check, run spotless:apply to fix.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed

+1 :green_heart:
shadedjars
5m 39s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
211m 33s

hbase-server in the patch passed.

237m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6477

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 9633e4a0c409 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 93624325d4f23cb0d2d1e0f707c037f6a4a1264a

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/1/testReport/

Max. process+thread count
5889 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 58s

master passed

+1 :green_heart:
compile
3m 57s

master passed

+1 :green_heart:
checkstyle
0m 45s

master passed

+1 :green_heart:
spotbugs
2m 15s

master passed

+1 :green_heart:
spotless
1m  0s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 40s

the patch passed

+1 :green_heart:
compile
3m 37s

the patch passed

+1 :green_heart:
javac
3m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

+1 :green_heart:
spotbugs
2m  6s

the patch passed

+1 :green_heart:
hadoopcheck
13m 19s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 56s

patch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 57s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
5m 16s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
229m 13s

hbase-server in the patch passed.

254m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6477

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 82a104de569f 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 087b127bb125dabc0e27f94c6ea8adc8e5e695a6

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/2/testReport/

Max. process+thread count
4572 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6477/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Security Alert CVE-2022-36067

Critical vulnerability on FOM repo:
vm2 vulnerable to Sandbox Escape resulting in Remote Code Execution on host
Critical severity
vm2
CVE-2022-36067
bcgov/nr-fom
•	api/package-lock.json
Acceptance Criteria

[ ] first
[ ] second
[ ] third

Additional context
Dependabot Alert
https://github.com/bcgov/nr-fom/security/dependabot/59

Fixed in PR #250


[R] tweaks for feather + gcc-4.6

This PR fixes feather build failures with gcc-4.6, as per https://github.com/wesm/feather/issues/279.
gcc-4.6 does define nullptr, but it does not define override, and so we need to split out the logic a bit more.

Current coverage is 87.19% (diff: 100%)

Merging #280 into master will not change coverage

@@             master       #280   diff @@
==========================================
  Files             5          5
  Lines           414        414
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            361        361
  Misses           53         53
  Partials          0          0

Powered by Codecov. Last update 88267c7...77c649b

+1


AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

训练的时候报错：AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'
Traceback (most recent call last):
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 566, in <module>
    main()
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 53, in main
    mp.spawn(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 240, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 198, in start_processes
    while not context.join():
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 160, in join
    raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
    fn(i, *args)
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 236, in run
    train_and_evaluate(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 416, in train_and_evaluate
    utils.summarize(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/utils.py", line 103, in summarize
    writer.add_image(k, v, global_step, dataformats="HWC")
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/writer.py", line 614, in add_image
    image(tag, img_tensor, dataformats=dataformats), global_step, walltime
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/summary.py", line 441, in image
    image = make_image(tensor, rescale=rescale)
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/summary.py", line 486, in make_image
    image = image.resize((scaled_width, scaled_height), Image.ANTIALIAS)
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

操作系统为centos

你看看你那Image有哪些缩放方法，我写个有的吧。

Image

Image.ANTIALIAS替换为：Image.Resampling.LANCZOS

训练的时候报错：AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'
Traceback (most recent call last):
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 566, in <module>
    main()
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 53, in main
    mp.spawn(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 240, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 198, in start_processes
    while not context.join():
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 160, in join
    raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
    fn(i, *args)
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 236, in run
    train_and_evaluate(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/s2_train.py", line 416, in train_and_evaluate
    utils.summarize(
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/GPT_SoVITS/utils.py", line 103, in summarize
    writer.add_image(k, v, global_step, dataformats="HWC")
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/writer.py", line 614, in add_image
    image(tag, img_tensor, dataformats=dataformats), global_step, walltime
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/summary.py", line 441, in image
    image = make_image(tensor, rescale=rescale)
  File "/apdcephfs/private_raymondguo/tts/GPT-SoVITS/env/lib/python3.10/site-packages/torch/utils/tensorboard/summary.py", line 486, in make_image
    image = image.resize((scaled_width, scaled_height), Image.ANTIALIAS)
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

操作系统为centos

Image.ANTIALIAS替换为：Image.Resampling.LANCZOS

pip install pillow==9.5.0
降低版本


fix improper error codes and user exists bug #61

fixes improper status codes
fixes err check bug for user already exists
adds descriptive error responses

It's perfect! Thanks @Inconnu08!

@Inconnu08 why don't you join our discord server? It would be great to be in touch!

Would be happy to join!

Here's the link https://discord.gg/ypXEEBr


[Update] Error : sendViewBook

"SPacketCustomPayload" require the hand.
Since 1.9, the "sendViewBook" don't work because the "SPacketCustomPayload" require the hand.
(Due to an error on my part, I have created a new PR)

@rexbut Can you squash your commits?


Error in coverage_plots_chromosomes

Dear,
I encountered an error when running this software. Could you please help me resolve it? Thank you in advance.
"
DEBUG:root:chr1: Ignoring centromere at 499 of 4980 bins (size 1)
DEBUG:root:chr1: Ignoring centromere at 499 of 4980 bins (size 1)
Traceback (most recent call last):
File "/Wakhan-main/src/main.py", line 268, in
main()
File "/Wakhan-main/src/main.py", line 227, in main
coverage_plots_chromosomes(csv_df_coverage, csv_df_phasesets, arguments, thread_pool)
File "/Wakhan-main/src/plots.py", line 294, in coverage_plots_chromosomes
add_histo_clusters_plot(df_cnr_hp1.log2.values.tolist(), df_cnr_hp2.log2.values.tolist(), states, centers, stdev, arguments, chrom, html_graphs)
File "/storage/yangjianLab/sunxiwei/software/Wakhan-main/src/plots.py", line 1003, in add_histo_clusters_plot
fig.add_trace(go.Scatter(x=xn, y=yn, mode='markers', marker=dict(color=cdict[g]), name=ldict[g], opacity=0.7, ),
KeyError: 10"
"
Best regards,
Xiwei

Sure, I will debug it, but you can just comment this line and rerun it, it will not effect any functionality. It's just for an extra debug.

Hi, are you using the latest repo , its already disabled there. Please use the main latest repo. Thanks!

Dear,
After running the software with the latest version, the previous issue has been resolved.
Thank you very much.
Best regards,
Xiwei

Dear,
However, upon using the updated version, I've come across another error below.
"
DEBUG:root:chr22: Ignoring centromere at 103 of 1017 bins (size 1)
INFO:root:Generating coverage/copy numbers plots genome wide
Traceback (most recent call last):
File "/storage/yangjianLab/sunxiwei/software/Wakhan-main/src/main.py", line 295, in
main()
File "/storage/yangjianLab/sunxiwei/software/Wakhan-main/src/main.py", line 283, in main
integer_fractional_means = integer_fractional_cluster_means(arguments, df_segs_hp1, df_segs_hp2, centers)
File "/storage/yangjianLab/sunxiwei/software/Wakhan-main/src/utils.py", line 499, in integer_fractional_cluster_means
integer_centers, fractional_centers = detect_first_copy_integers_fractional_cluster_means(arguments, df_segs_hp1, df_segs_hp2, centers)
File "/storage/yangjianLab/sunxiwei/software/Wakhan-main/src/utils.py", line 450, in detect_first_copy_integers_fractional_cluster_means
first_copy = centers[sumsup.index(sorted(sumsup, reverse=True)[1])]
IndexError: list index out of range
"
Best regards,
Xiwei

Can you help me in debug? I think centers value is NULL or something else is wrong.

Copy coverage.csv, coverage_ps.csv and <Your genome name>_SNPs.csv files from data/ output dir (it should be in src) of your current run to some separate directory line /home/abc/dry_run_data.
I have just update dry_run command, so git clone the latest code somewhere else
Print some data by adding following in main.py after line:

print(df_segs_hp1)
print(df_segs_hp2)
print(centers)

Then run again the code with adding this command: --dryrun True --dryrun-path <This is the path where you copied CSVs files in step-1, ie. like, /home/rezkuh/gits/dry_run_data/>
Please show me the log then.

Thanks!

Dear,
Attached please find the debug output.
Best regards,
Wakhan_debug_out.txt
Xiwei

Thanks. Looks like somehow correct means are not being provided to HMM.
Are you using --phaseblock-flipping-enable True ? Then enabling --phaseblocks-enable True will help to see the phaseblocks.
Can you try running again this dryrun with inserting following means/stdev above this line:
means = [0, 5.5, 13, 22, 28, 32]
stdev = [1, 5, 5, 5, 5, 5]

After this, if possible looking at <genome_name>_genome_copynumber.html will help how the coverage looks like.

It worked. Thanks you.


[Feature Request] editor.cursorSurroundingLines to work in Jupyter notebooks

Context

[X] This issue is not a bug report. (please use a different template for reporting a bug)
[X] This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description
The scroll offset option 'editor.cursorSurroundingLines' works great in normal files (first video)
But in Jupyter notebooks it doesn't work when moving in a long cell that fills the entire screen (second video).
Is it possible to change this from VSCodes side or should this request be made to the Jupyter extension team?
https://user-images.githubusercontent.com/62295460/205187131-2913a615-e2d4-4998-88cb-8ed74aa8c57f.mov
https://user-images.githubusercontent.com/62295460/205187150-2068cc1d-1002-430e-aef4-9ad4a3f5b9a6.mov

monaco editor is not the library which vscode uses, but directly exported from vscode.
And its release is always deferred from vscode release, so you should create issue in vscode repository.

Thank you!


SIMDe v0.7.1

I unprefixed the MMseqs2 macros and replaced our undefined version xxhash with the latest release v0.8.
I'll merge once I get a green light from the CI. Thanks a lot :)

I unprefixed the MMseqs2 macros and replaced our undefined version xxhash with the latest release v0.8.
I'll merge once I get a green light from the CI. Thanks a lot :)

@milot-mirdita Huzzah!
Looks like https://travis-ci.org/github/soedinglab/MMseqs2/jobs/753198093 had a hiccup and needs restarting
BTW, I can remove the lib/simde/simde/arm/ directory, if you wish, as there are not any NEON intrinsics in the MMSeqs2 code

@milot-mirdita Huzzah!
Looks like https://travis-ci.org/github/soedinglab/MMseqs2/jobs/753198093 had a hiccup and needs restarting
BTW, I can remove the lib/simde/simde/arm/ directory, if you wish, as there are not any NEON intrinsics in the MMSeqs2 code

I guess we could remove the arm subfolder, however it's already part of the git history anyway, so it doesn't change that much anymore. It would be nice to have a repo similar to simde-no-tests, but I don't want these to become a maintenance burden for you.

I guess we could remove the arm subfolder, however it's already part of the git history anyway, so it doesn't change that much anymore. It would be nice to have a repo similar to simde-no-tests, but I don't want these to become a maintenance burden for you.

@milot-mirdita Whatever works for you; if you don't mind the extra files then it is fine by me :-)

@milot-mirdita Whatever works for you; if you don't mind the extra files then it is fine by me :-)


Probing stop

Bro, ini aq cek terjadi kalau netcrow masuk di pe-transit juniper...
2016/08/07 16:52:30.738|PROB|Next node in 5 seconds...
2016/08/07 16:52:35.740|PROB|Begin probing into PE2-D5-KBL-TRANSIT
2016/08/07 16:52:35.741|PROB|Manufacture: JUNIPER
2016/08/07 16:52:35.741|PROB|Host IP: <IP_ADDRESS>
2016/08/07 16:52:35.741|PROB|Checking host IP
2016/08/07 16:52:36.341|PROB|Host identified
2016/08/07 16:52:36.341|PE2-D5-KBL-TRANSIT|Connecting with SSH... (910010@PE2-D5
-KBL-TRANSIT)
2016/08/07 16:52:41.898|PE2-D5-KBL-TRANSIT|SSH failed
2016/08/07 16:52:41.998|PE2-D5-KBL-TRANSIT|Connecting with Telnet... (910010@PE2
-D5-KBL-TRANSIT)
2016/08/07 16:52:42.498|PE2-D5-KBL-TRANSIT|Telnet failed
2016/08/07 16:52:42.498|PE2-D5-KBL-TRANSIT|Connection failed
2016/08/07 16:52:52.503|PE2-D5-KBL-TRANSIT|MCE Waiting III... (1)
2016/08/07 16:52:52.503|PE2-D5-KBL-TRANSIT|Last Reading Output:
2016/08/07 16:52:52.503|PE2-D5-KBL-TRANSIT|bash-4.1$ ssh -o StrictHostKeyCheckin
g=no<EMAIL_ADDRESS>telnet PE2-D5-KBL-TRA
NSIT<CR><NL>Trying <IP_ADDRESS>...<CR><CR><NL>Connected to PE2-D5-KBL-TRANSIT.<CR
><CR><NL>Escape character is '^]'.<CR><CR><NL>^C
2016/08/07 16:53:04.262|PE2-D5-KBL-TRANSIT|MCE Waiting III... (2)
2016/08/07 16:53:04.262|PE2-D5-KBL-TRANSIT|Last Reading Output:
2016/08/07 16:53:04.262|PE2-D5-KBL-TRANSIT| StrictHostKeyChecking=no 910010@PE2-
D5-KBL-TRANSIT<CR><NL>^C<CR><NL>-bash-4.1$ telnet PE2-D5-KBL-TRANSIT<CR><NL>Tryi
ng <IP_ADDRESS>...<CR><CR><NL>Connected to PE2-D5-KBL-TRANSIT.<CR><CR><NL>Escape
character is '^]'.<CR><CR><NL>^C<CR><NL>^]<CR><NL>telnet> ^C
2016/08/07 16:53:16.026|PROB|Connection failure has occured
2016/08/07 16:53:16.053|PROB|Disconnected

This is happened because SSH server "stuck" in the middle of authentication process. I probably  will implement a workaround for this.

Fixed in Build 18.


Java server devguide missing code

A couple missing imports and a package statement made the QuickStart hard to follow.
I added the missing imports and package statement.

Added package tutorial; as requested :-)


Not working for Android 10

audio recorded but no sound

@aykuttasil any update on this issue?

i solved this issue by enabling accessibility service and used VOICE_RECOGNITION. quality is good only on one side. other side its bit low sound. because it using mic

@vikash159 can you please share the working code with us?

 int source = MediaRecorder.AudioSource.VOICE_COMMUNICATION;         if (Build.VERSION.SDK_INT >= 29) source = MediaRecorder.AudioSource.VOICE_RECOGNITION;         mCallRecord = new CallRecord.Builder(this)                 .setRecordFileName("Record")                 .setRecordDirName("mobile")                 .setRecordDirPath(Environment.getExternalStorageDirectory().getAbsolutePath())                 .setAudioEncoder(MediaRecorder.AudioEncoder.AMR_WB)                 .setOutputFormat(MediaRecorder.OutputFormat.MPEG_4)                 .setAudioSource(source)                 .setLogEnable(true)                 .setShowSeed(true)                 .setShowPhoneNumber(true)                 .build();
`import android.accessibilityservice.AccessibilityService;
import android.view.Gravity;
import android.view.LayoutInflater;
import android.view.WindowManager;
import android.view.accessibility.AccessibilityEvent;
import android.widget.FrameLayout;
import com.securein.R;
public class ServiceAccessibility extends AccessibilityService {
@Override
public void onAccessibilityEvent(AccessibilityEvent event) {
}

@Override
public void onInterrupt() {
}

@Override
protected void onServiceConnected() {
    super.onServiceConnected();
}

}`
`

        <meta-data
            android:name="android.accessibilityservice"
            android:resource="@xml/accessibility_service_config" />
    </service>`

res/xml
<?xml version="1.0" encoding="utf-8"?> <accessibility-service xmlns:android="http://schemas.android.com/apk/res/android"     android:accessibilityEventTypes="typeAllMask"     android:accessibilityFeedbackType="feedbackAllMask"     android:accessibilityFlags="flagRetrieveInteractiveWindows|flagReportViewIds|flagIncludeNotImportantViews"     android:canRequestFilterKeyEvents="false"     android:canRetrieveWindowContent="true"     android:description="@string/accessibility_service_description"     android:notificationTimeout="100"     android:packageNames="com.securein" />

Thanks you @vikash159 for your code and comments, do you have to make any changes on the lib side code as well or its working with the above changes only?

nothing just audio source i have changed. this is not a permanent fix i guess. im still looking for permanent fix because audio captured using mic

Thanks @vikash159 for your comments, I am going to implement and once I will find solution will let you know for sure

@vikash159 Hello，budy. I have a question for the recorder file. I can not find it in the path .
have you got those question?!

@A0shashen00
add this line in manifest application tag if you want to save in storage directory instead of cache directory
android:requestLegacyExternalStorage="true"

@AbdulRehmanNazar Bhai did it work?  if yes can you share the code?

@vikash159 @AbdulRehmanNazar  Bro have you got any update on this issue? actually i have added this accessibilityService code using this i am able to record calls but in some scenarios only one side voice is audible and in some scenarios both side voice is clearly audible and in some scenarios one side's voice is clear and one side's voice is bit low. so if you have got any fix please let me know.

@erpriyesh it happens with some device or even you use earphone. so no full proof solution i got on this. only samsung device i saw this working properly,

@vikash159 @AbdulRehmanNazar Bro have you got any update on this issue? actually i have added this accessibilityService code using this i am able to record calls but in some scenarios only one side voice is audible and in some scenarios both side voice is clearly audible and in some scenarios one side's voice is clear and one side's voice is bit low. so if you have got any fix please let me know.

@erpriyesh can you please share the piece of code with the class which you had implemented...

i solved this issue by enabling accessibility service and used VOICE_RECOGNITION. quality is good only on one side. other side its bit low sound. because it using mic

@vikash159 Can you please share the working code.

Thanks @vikash159 for your comments, I am going to implement and once I will find solution will let you know for sure

@AbdulRehmanNazar did you got the recorder output file in android 10 I had tried using but I didn't succeed...

@vikash159 hey bro i have tested this in another phone. even after enabling the accessibility service call's voice is silence in recording. and now facing this issue in android 9 also can anyone help me ? @AbdulRehmanNazar

@erpriyesh it works on some device not on all.

@AbdulRehmanNazar have you got any workaround to overcome from this issue ?

@AbdulRehmanNazar @vikash159 hello friends did you find solution for 10 & 11 versions .If you find please let me know thanks

i have tried this code so far to achieve the call recording but voice is too low of the person we are talking too. further you have to put this code in accessibility service
`final int BITS_PER_SAMPLE = 8;       // 16-bit data
final int NUMBER_CHANNELS = 1;        // Mono
final int COMPRESSION_AMOUNT = 8;     // Compress the audio at 8:1
    int sampleRate = 8000;
    final int uncompressedBitRate = sampleRate * BITS_PER_SAMPLE * NUMBER_CHANNELS;

    final int encodedBitRate = uncompressedBitRate  / COMPRESSION_AMOUNT;
    Log.d(TAG, "startRecordingB: encoded bit rate : "+ encodedBitRate);
    recorder = new MediaRecorder();
    recorder.setAudioSource(MediaRecorder.AudioSource.VOICE_RECOGNITION);
    recorder.setOutputFormat(MediaRecorder.OutputFormat.AMR_WB);
    recorder.setOutputFile(getFilename());
    recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AMR_WB);
    recorder.setAudioChannels(1);
    recorder.setAudioSamplingRate(8000);
    recorder.setAudioEncodingBitRate(encodedBitRate);`

@vikash159 about the accessibilty service

this permission is only allowed for system apps how did you handle that?
and i will appreciate it if you share the complete code
i have difficulties implementing accessibility service for android 10.

@MasterKali06
You can't "start" the AccessibilityService as they are not like other services where you can control their start/stop. Rather here the Android system controls starting and stopping them based on the settings the user has selected.
The best you can do is launch the Accessibility settings page and get the user to enable it for you:
Intent openSettings = new Intent(Settings.ACTION_ACCESSIBILITY_SETTINGS);
openSettings.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_NO_HISTORY);
startActivity(openSettings);

@vikash159 @MasterKali06 @hareesh145 @AbdulRehmanNazar @kishorekmr61 @umairdexty can any of you please share your working call recorder app repository here please, because I am searching the internet for 1 week and this is the best lead I got so far. I am badly stuck in the installation process of this package. and I cannot move further in this. I urgently need to build a call recorder app in android.
Thank You

@Vinayak-Bhardwaj
As I know you can't record calls from both side anymore, that is the restriction added for new Android OS
https://nllapps.com/apps/acr/android9.htm

Thanks for the response @developer-- , but the above discussion shows that maybe it is possible on android 10. And on the play store as well there exist applications that record calls from both sides. So can you help me with that, please?

can you confirm that they are recording voice from both side with good quality? I think all apps were affected

yes @developer-- , I have myself tested it. On using earphones while talking we can hear clear voices from both ends. If you want then I can share you the link for the application

@Vinayak-Bhardwaj  can you please share your code of call recording if possible please?

 int source = MediaRecorder.AudioSource.VOICE_COMMUNICATION;
        if (Build.VERSION.SDK_INT >= 29) source = MediaRecorder.AudioSource.VOICE_RECOGNITION;
        mCallRecord = new CallRecord.Builder(this)
                .setRecordFileName("Record")
                .setRecordDirName("mobile")
                .setRecordDirPath(Environment.getExternalStorageDirectory().getAbsolutePath())
                .setAudioEncoder(MediaRecorder.AudioEncoder.AMR_WB)
                .setOutputFormat(MediaRecorder.OutputFormat.MPEG_4)
                .setAudioSource(source)
                .setLogEnable(true)
                .setShowSeed(true)
                .setShowPhoneNumber(true)
                .build();

import android.accessibilityservice.AccessibilityService;
public class ServiceAccessibility extends AccessibilityService {

    @Override
    public void onAccessibilityEvent(AccessibilityEvent event) {
    }

    @Override
    public void onInterrupt() {
    }

    @Override
    protected void onServiceConnected() {
        super.onServiceConnected();
    }
}

<service
            android:name=".util.ServiceAccessibility"
            android:permission="android.permission.BIND_ACCESSIBILITY_SERVICE">
            <intent-filter android:priority="1000">
                <action android:name="android.accessibilityservice.AccessibilityService" />
            </intent-filter>

            <meta-data
                android:name="android.accessibilityservice"
                android:resource="@xml/accessibility_service_config" />
</service>

res/xml
<?xml version="1.0" encoding="utf-8"?>
<accessibility-service xmlns:android="http://schemas.android.com/apk/res/android"
    android:accessibilityEventTypes="typeAllMask"
    android:accessibilityFeedbackType="feedbackAllMask"
    android:accessibilityFlags="flagRetrieveInteractiveWindows|flagReportViewIds|flagIncludeNotImportantViews"
    android:canRequestFilterKeyEvents="false"
    android:canRetrieveWindowContent="true"
    android:description="@string/accessibility_service_description"
    android:notificationTimeout="100"
    android:packageNames="com.securein" />

permissions
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.RECORD_AUDIO" />
    <uses-permission android:name="android.permission.READ_PHONE_STATE" />
    <uses-permission android:name="android.permission.READ_CALL_LOG" />
    <uses-permission android:name="android.permission.PROCESS_OUTGOING_CALLS" />
    <uses-permission android:name="android.permission.BIND_ACCESSIBILITY_SERVICE" />
    <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
    <uses-permission android:name="android.permission.INTERNET" />
    <uses-permission android:name="android.permission.CALL_PHONE" />

Hi @vikash159
How to connect recorder codes to AccessibilityService codes?
Please send the source code

Any updates on android 10 so far?

is there any hack for this issue yet?

How can I create a custom call recorder for Android Q like ACR Phone Helper?


[Enhancement]: Missing configuration property ryuk.disabled

Module
Core
Proposal
It seems that currently there is no way to disable Ryuk via testcontainers.properties or .testcontainers.properties.
This is because the property counterpart (ryuk.disabled) of the environment variable TESTCONTAINERS_RYUK_DISABLED is not supported.
See https://www.testcontainers.org/features/configuration/

Hi @veita this is currently on purpose. We are aware of disabling Ryuk is some CI environments. However, we haven't experienced this need in local environments. Please, take into account that Testcontainers works with Docker-API compatible runtime. For that reason, we only support it via environment variables to be explicit about disabling it in the CI definition.

Unfortunately Ryuk does not work with Podman (https://github.com/testcontainers/moby-ryuk/issues/23).
This makes it kind of cumbersome to use testcontainers with Podman in a clean way.

As @eddumelendez mentioned, Testcontainers works with Docker-API compatible container runtimes (see Docker Requirements in our docs). It might help to raise an issue with the podman community regarding Docker API compatibility.

Podman provides a Docker compatible API. For rootless containers it could be enabled with
systemctl --user enable --now podman.socket

After playing around with testcontainers and Podman I'm actually not that sure that Ryuk really does not work in this combination (as https://github.com/testcontainers/moby-ryuk/issues/23 suggests).
With DOCKER_HOST/docker.host set to unix:///run/user/${UID}/podman/podman.sock I did not see any obvious errors during the test container lifecycle.


Publish the one-topology in the monaco repo

Hi!
I see from the output of the one-topology that it, in essence is monaco with some featureflags added (download entities among them)
Any plans on publishing this in the main monaco repo?

it will be the opposite at some point, will extract the code to this repo or to the terraform provider repo
download entities was pushed to the Monaco repo in the past, but they removed it at some point
do you plan to use it for other purposes?

This branch represents One-Topology, complete with extra APIs and added entity/config matching
https://github.com/dcryans/dynatrace-configuration-as-code/tree/feat/dcryans/match_entities_cmd

Migrated One-Topology to this repo
the Fork will be deleted