How to show indicator which columns are sortable

Hi,
I need to show a muted icon on each column that is sortable, how would I do this? (I think that's a fair requirement from a UX perspective)
Would I need to override some template?
Any help appreciated

you can leverage the css classes
https://github.com/offirgolan/ember-light-table/blob/master/addon/styles/addon.css#L83
similarly if you can't achieve it in only css you can make a custom column type that leverages the isSortable property to do more complex things:
https://github.com/offirgolan/ember-light-table/blob/548cbf46350d243f1f8db25d15bc8403a4f3ec7c/addon/components/columns/base.js#L30

@roberkules this is how we do it in the demo app. Pretty straight forward 😄
https://github.com/offirgolan/ember-light-table/blob/master/tests/dummy/app/mixins/table-common.js#L36-L38

you pushed me in the right direction... used a bit of styling to make it work...
th.is-sortable {
  &:after {
    content: '\f0dc';
    font: normal normal normal 12px/1 FontAwesome;
    color: $text-muted;
    float: right;
    opacity: 0.3;
  }

  &:hover:after {
    opacity: 1;
  }

  &.is-sorted {
    &:after {
      content: '';
    }
  }
}

@roberkules thats great to hear! Im gonna go ahead and close this issue. Feel free to reopen if needed.


Data Integration

Documenting the proposed data integration here for discussion.
From my understanding, there is a survey-template.csv file that will be populated with survey-specific metadata. Among which will be ids for the nutrient and chlorophyll data that is derived through lab analyses. Whether these ids will be populated as a string in a single column (sample_ids) or parsed out into separate columns (e.g., nutrient_sample_id and chl_sample_id) is yet to be decided. For the data collected by the miniDOT and ctd-diver however, this is more continuous data and if I'm not mistaken, each timestamp will not have a unique ID. This data is connected to the survey-metadata and associated lab-derived data by proximity of data collection.
In practical terms what this means is that if sample_time_collection associated with the nturient_sample_id and chl_sample_id overlaps, or is in close proximity to (what does this mean specifically - within 5 minutes?) to the time interval recorded by the ctd-diver or miniDOT, we can reliably say that they are part of the same survey.
Questions that this raises for me is:

[ ] Should we record 'time_in' and 'time_out' for the ctd-diver/miniDOT?
[ ] Is the ctd-diver/miniDOT part of a single instrument? If not, can it happen that a water sample is collected by the Niskin bottle, but the ctd cast fails, and consequently will have to be dropped again outside of the range that would be considered 'in close proximity of' the timestamp associated with the nutrient_sample_id and chl_sample_id? How would we then ensure that the ctd-diver/miniDOT data is associated with the correct nutrient/chl data?

To answer the questions:

No need to record time_in and time_out from my understand. The times that are recorded are when the instrument measurements are taken and when the water samples are collected. Given the occassional double cast these two times are not always the same.
If a water sample is collected this will have an associated sampling event #. The measurements (ids) will then be nested under this sampling event #. If the entire sampling event fails, then perhaps the sampling event # should be omitted, but if only part of the sampling event fails then it'll be important to keep the sampling event # just because there will some measurements associated with it.

The survey.csv will not have a column for sample_ids included. This would make it more challenging than it needs to be, with lists of sample_ids in a single cell. This is not beneficial for data entry. Instead, Sampling Event Number will also be recorded within derived data sheets, which will help nest sample_ids.


Problem with 2.2.0 CPU usage

Hi there,
It seems that the CPU usage is is skyrocketing when I play RTMP streams (110%-120%) while HLS playbacks have values within a reasonable range. Any clue?

@furybubu  CPU usage on simulator is not accurrate, use real device will give you a correct value

@furybubu ，try to modify PLPlayerOptionKeyMaxL1BufferDuration，the default value is 1000，make it bigger like 10000,  look at this #129  if you can read Chinese


Scroll to Bottom When Keyboard Toggled Causes Crash

Well, I have successfully implemented IGLisrKit. Only thing is that I had this function where it scrolls to the bottom of the content when the keyboard is toggled.
Here is my code for that method:
 @objc func handleKeyboardNotification(notification: NSNotification){
        if let userinfo = notification.userInfo{

            let keyboardFrame = (userinfo[UIKeyboardFrameEndUserInfoKey] as! NSValue).cgRectValue
            self.bottomConstraint?.constant = -(keyboardFrame.height)

            let isKeyboardShowing = notification.name == NSNotification.Name.UIKeyboardWillShow
            self.bottomConstraint?.constant = isKeyboardShowing ? -(keyboardFrame.height) : 0

            UIView.animate(withDuration: 0, delay: 0, options: UIViewAnimationOptions.curveEaseOut, animations: {
                self.view.layoutIfNeeded()
            }, completion: { (completion) in
                if self.comments.count > 0  && isKeyboardShowing {
                    let indexPath = IndexPath(item: self.comments.count-1, section: 0)
                    self.collectionView.scrollToItem(at: indexPath, at: .top, animated: true)
                }
            })
        }
    }

It seems to be causing this error
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'attempt to scroll to invalid index path: {length = 2, path = 0 - 3}'
Any insight on how to fix this using iglist kit. I beleive it has to do with a count of the elements in the controller because that is what allowed me to do utilize it in my pre IGListKit Implementation

Can you repro this in an example app we can debug? There isn’t enough information for us to action yet.
You might also want to use the scrolling APIs on IGListAdapter instead.
Sent with GitHawk

Ill take a look at that however this is my github repo
https://github.com/Smiller193/EventfulApp1
and this is a sample login
<EMAIL_ADDRESS>Gohan114
Select one of the pictures and go click the comment/message bubble image and toggle the keyboard that will reproduce the error

let indexPath = IndexPath(item: self.comments.count-1, section: 0)
self.collectionView.scrollToItem(at: indexPath, at: .top, animated: true)

You need to be sure that indexPath is valid before scrolling.

Okay i found the scroll(toObject) method thanks ill look into it

listAdapter.scroll(to: <#T##Any#>, supplementaryKinds: <#T##[String]?#>, scrollDirection: <#T##UICollectionViewScrollDirection#>, scrollPosition: <#T##UICollectionViewScrollPosition#>, animated: <#T##Bool#>)

So how would this method trigger on keyboard toggle when the current object is in the listAdapter datasource function

@rnystrom @weyert

That's an implementation detail on your end?

Um well, the thing I copy and paste is just the function that comes when you attempt to use that function. Yeah, Im just trying to figure out where this function would fit in at.

Based on the function I had to accomplish goal to scroll to the bottom

Closing old issues that seem to be resolved or are inactive. 😄
If this isn't resolved and you still need/want help, please re-open! 😊


Add new DataCache trait and InMemoryDataCache implementation

Description of change
Part of #255, this contains some early thinking on what our trait should look like for the data cache itself. It also contains an in-memory implementation that can be used for test cases, without setting up a full data cache (which doesn't exist yet).
Relevant issues: #255
Does this change impact existing behavior?
No.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

There will be a small conflict with #556. I'll rebase this once that's merged.


add Shape:queryOverlapping to query overlppaing shapes

Currently, if we want to get overlapping shapes of a shape, we have to record when world:update. This logic is too complicated.
As a sensor, it functions exactly like a tag marked as non-collisionable. This function will allow users to skip the complicated collision resolver logic and get the overlapping shapes directly.

Thanks for the PR!  It would be really helpful to see the use case you had for it.  While trying to make sure this function makes sense in the context of the other collision functions, I'm trying to go over various use cases, and knowing yours would help.  Based on previous discussion I'm assuming you have a MeshShape for a sword slash and are trying to check all the shapes it intersects.
What's the purpose of setting tag filter to false?  I guess there are 3 options for the tag filtering:

The query does not use tags.  If you want to respect tags, you have to do a check with World:isCollisionEnabledBetween.
The query does use tags.  If you didn't want this, you have to set up your tags differently, or temporarily remove and re-add tags.
Make it configurable, like in the PR.

Some other very random design brainstorming while thinking about this:

Shape:isTouching(otherShape)?
Collider:isTouching(otherCollider)?
World:queryShape vs. Shape:queryOverlapping is an interesting decision.
Calling this "overlaps" is confusing because it checks for actual contacts, not overlaps like World:getOverlaps.
If this is meant to be an alternative to World:overlaps because it sucks, then World:overlaps should be removed (and maybe replaced with a more conventional contact filter callback World:get/setCollisionFilter) instead of having 2 ways of doing things.

This is another case, I have a skill that needs to cause damage to units in an area (fire breathing effect, I just use a simple box) every second. Based on this requirement, I created a sensor. And I used the world tag to set that only the specified tag will be in contact.
I use a simple timer to query the units in this area when the time point is reached, and then apply the damage.
In Lovr, in order to achieve the above effect, it is necessary to continuously record all the units in contact with the sensor in the resolver and keep updating, or calculate aabb and then queryBox, and finally perform collision detection by itself.
I don't want to do the above events, I just want to simply get all the shapes that the current shape can touch when needed (by default, things whose collider's tag is set to be untouchable should not be found).
Maybe the tagFilter switch is not necessary, it can be achieved by setting collider:setTag(nil), but it is necessary based on the collider tag, because it must conform to the real performance of the current shape in the world.
In addition, for Lovr's current physics, too many things have not been exported. The collision query that is simply implemented in ode is completely absent in lovr, and all of them need to be implemented by themselves.
Like this function, whether it is Love2d or other game engines, an API will be provided to query the units touched by the collision

This is another case, I have a skill that needs to cause damage to units in an area (fire breathing effect, I just use a simple box) every second. Based on this requirement, I created a sensor. And I used the world tag to set that only the specified tag will be in contact.
I use a simple timer to query the units in this area when the time point is reached, and then apply the damage.
In Lovr, in order to achieve the above effect, it is necessary to continuously record all the units in contact with the sensor in the resolver and keep updating, or calculate aabb and then queryBox, and finally perform collision detection by itself.
I don't want to do the above events, I just want to simply get all the shapes that the current shape can touch when needed (by default, things whose collider's tag is set to be untouchable should not be found).
Maybe the tagFilter switch is not necessary, it can be achieved by setting collider:setTag(nil), but it is necessary based on the collider tag, because it must conform to the real performance of the current shape in the world.
In addition, for Lovr's current physics, too many things have not been exported. The collision query that is simply implemented in ode is completely absent in lovr, and all of them need to be implemented by themselves.
Like this function, whether it is Love2d or other game engines, an API will be provided to query the units touched by the collision

isTouching is useless, it only needs to know the situation of the two to detect. If there are 1000 objects in your world and you don’t know all the touching units, it is impossible to test them one by one.
It is usually required when a more accurate detection is required after querying the possible collisions nearby through the AABB

World:queryShape and Shape:queryOverlapping, I think they can exist at the same time. World:queryShap executes a one-off query without a shape/collider, create -> query -> destroy. Moreover, for this kind of query, basically there is no need to care about whether there is a collider, and naturally there is no need for a tag filter. And shape:queryOverlapping uses shapes that already exist in the world to perform multiple queries, so it needs to perform tag filter.

By the way, Love2d's World:setCallbacks( beginContact, endContact, preSolve, postSolve ) is very useful, I don't know if ODE has a callback like this. Now I want to monitor the events of units entering and leaving the area. I can only compare the units of the previous frame and the current frame, and then detect which ones are new and which ones are leaving. This function is also relatively general.

Then, I actually feel that collider:getOverlapping is better, but to remove duplicates, I feel a bit complicated to write this in C, so I can only write a simple shape:getOverlapping

By the way, Love2d's World:setCallbacks( beginContact, endContact, preSolve, postSolve ) is very useful, I don't know if ODE has a callback like this.

ODE doesn't have these callbacks

Ok thanks for the info.  I think my current preference would be a World:queryShape(shape, callback) function.  The shape must be attached to a collider in the world, and it does not use tags, to keep it similar to getContacts and the other query functions.  Basically what you have now, but put on World instead of Shape and no tag filter.  It's not perfect, but good enough and adds an important missing feature.  Does that seem good?

For pure shape, I don't think tag is necessary. But for a collider‘s shape, tag is necessary. On the one hand, if collider:addShape(shape) has been explicitly executed in lua, then the shape needs to be configured according to the collider. On the other hand, for a sensor, it should be the same as the perceived result.
For the current Lovr, Sensor is basically the same as nothing.
Because if the resolver function is not written, it is equivalent to a tag, if it is written, its function is simply not to call collide, but it is equivalent to simply adding an if shape.is_sensor then goto next_shape end in the resolver. I think that the sensor needs to know which objects it has collided with at any time, and the related collision events (begin/end colliding)

This is stale, and I will be adding it soon to Jolt backend.  But thank you for starting the discussion about it.


Add support for forcing tool use when you programatically

Note - I tried adding tests about the error, but had the same issue as before with uncaught exceptions because we throw in two ways. I'll put up a PR with a clearer case where this happens but didn't want to hold this up because of that.


DOCR-280: rebase upstream distribution

Jira: https://jira.internal.digitalocean.com/browse/DOCR-280
This is a rebase on upstream/main. Since the rebase involves a huge number of commits, I summarized the outstanding changes on our end vs. their end (upstream) in s3.go below, since that is where the most overlap happens. WIP for other files.
Added on our end:

Using HeadObject and falling back to ListObject in Stat()

https://github.com/distribution/distribution/commit/3f2424cf0fdc398cfcf3240702a9caa68496d071 & https://github.com/distribution/distribution/commit/556d80827448e15088d79da0010d0bc1c08239d1

LogS3APIRequests & LogS3APIResponseHeaders as driver params

https://github.com/digitalocean/docker-distribution/commit/f3d61f10008fc5bcda9edc0b3093a73e74009229
Using d.s3Client(ctx) instead of calling d.S3 directly

QuotaExceeded Error

https://github.com/digitalocean/docker-distribution/commit/d192a974fbede4b4f868ff99bcfff2bdc235b297

setContentLength

https://github.com/digitalocean/docker-distribution/commit/b0fc5ddc8b3a7e64ca4dd1830d12a3419eea14a9 & https://github.com/digitalocean/docker-distribution/commit/bdbf05f6f8e8708084023b10f0ff35dbafd90a59

Added on their end (upstream):

Fixed max layer size of 10GB bug

https://github.com/distribution/distribution/pull/2815

Paginate through s3 multipart uploads - fixed multipart uploads over 1,000 rows

https://github.com/distribution/distribution/pull/3519
Related issue: DOCR-259

UseDualStack, MultipartCombineSmallPart, Accelerate, & ForcePathStyle as driver params

https://github.com/digitalocean/docker-distribution/commit/e2caaf9cba7c119868865ec35aa02cd0297ac810, https://github.com/digitalocean/docker-distribution/commit/117757a5cb8ae931f5eab4de24763d8c0421c522, https://github.com/digitalocean/docker-distribution/commit/51c0c8148ab75fae72f60957b3b9f246e421b6f5, https://github.com/digitalocean/docker-distribution/commit/15de9e21bad774b24e48a46d9238a5714e7ceb6c

Add all supported storage classes

https://github.com/digitalocean/docker-distribution/commit/fb937deabf5845996d06a5d7edd7c1b5146346c8 & https://github.com/digitalocean/docker-distribution/commit/966fae54639c0268949ee9a329b6951b92b4921f

Update to ListObjectsV2

https://github.com/digitalocean/docker-distribution/commit/8eab5d1bd6c69e895d762c30a0d34031ccc872ee

Delete S3 keys incrementally in batches

https://github.com/digitalocean/docker-distribution/commit/ebc4234fd573e21ee49b0a7b14e5e76818a6a7b0

Questions:

Since this is a rebase and not a merge, is it expected for this PR to only show commits for which the merge conflicts have been resolved? For instance, I know there is a difference between upstream and our forked repo in linkedblobstore.go but I don't see it as part of the change in this PR. Will I see that change take effect once this PR is merged?

I will work on a separate PR to redo the rebase.


Lock VectorDatabase for Save()

https://github.com/nickna/Neighborly/blob/30f68bb1d294824f031d1e89758b5026124bf21f/Neighborly/VectorDatabase.cs#L392-L418
I think this might need _rwLock.EnterWriteLock();, as the _isDirty is only set after an item has been added. The method uses direct index access to _vectors, which means that concurrent calls that modify the database during a call to Save could cause corruption.

Fixed in 4f68e9a4ba30bcbead025c52437f13a319b15993


issue 23/ adding fetch prefect details in coordinator type

Coordinator model, mutation, and types update.

@DesignrKnight , @riteshsp2000  I cannot set a reviewer neither set the issue. This PR Resolves #23

Thank you so much @JWhacheng for your PR. Will review

@all-contributors add @JWhacheng for code

Hacktoberfest Thank You from NIT Rourkela community
It was a super fun experience in Hacktoberfest with you. We hope you also had fun and amazing learning. We look forward to you in our upcoming sessions and events as part of the community.
You can join our Slack community at http://bit.ly/NITRDevs
As a token of our gratitude, we have set up digital badges of recognition for our contributors from Hacktoberfest.
Do claim yours at https://live.dscnitrourkela.org/
Thanks and Cheers!
Stay Safe


no documentation for tsx

Search terms
tsx, jsdoc
Expected Behavior
jsdoc comments should be documented in ts and tsx files
Actual Behavior
in tsx files, jsdoc block comments are ignored
Steps to reproduce the bug

somefile.tsx
add some type with jsdoc
generate documentation

Environment

Typedoc version: 0.20.1
TypeScript version: 4.0.3
Node.js version: v12.13.1
OS: mac os big sur

I reacted src/gh1434.tsx with the following content and ran typedoc on it:
import * as React from "react"
/** Some docs */
export const x = hi

Seems to be working correctly...

@Gerrit0 what command did you run?
i currently work on the docs for my editor library (https://github.com/react-page/react-page, beta branch). I tried to add it to a sub package there and i just ran
yarn typedoc ./src/index.tsx --out api-doc
i see a lot of missing docs there and it looks like all tsx files are concerned. Do i need to add some flag? is there some problem with the tsconfig?

@Gerrit0 would you mind to add an object type in your tsx file?

type Foo = {
  /** some bar property **/
   bar: string
}

I just ran npx typedoc src/gh1434.tsx
type Foo = {
  /** some bar property **/
   bar: string
}

This won't be documented - it isn't exported. In 0.20, TypeDoc will only document what is exported, because that is what your API surface is. The rest is implementation details that users don't care about. Change this to export type and TypeDoc will document it as expected.

@Gerrit0 sorry, of course i exported it. It also appears in the doc! just without any jsdoc (/** stuff @returns otherstuff **/).
its really weird

That would be great, once exported it appears like this to me:

Closing as unactionable without a reproduction, please reopen if you are able to create a repro.

Closing as unactionable without a reproduction, please reopen if you are able to create a repro.


Link bottom navigation buttons

Link bottom nav buttons

Home should link to home
Wishlist and cart should open wl/cart
Account should link to my account or open login modal if user is not logged in
"Menu" can remain like it is now as we don't have a component to open with this yet

I can help to solve this issue, @filrak  please assig me.


podTemplate.tolerations do not et merged between taskRunTemplate and taskRunSpec[]

Expected Behavior
as documented in merged PR https://github.com/tektoncd/pipeline/pull/6862
taskRunTemplate.podTemplate.tolerations and taskRunSpec[].podTemplate.tolerations get merged.
apiVersion: tekton.dev/v1
kind: PipelineRun
spec:
  taskRunSpecs:
  - pipelineTaskName: build-arm64-image
    podTemplate:
      tolerations:
      - effect: PreferNoSchedule
        key: arch
        operator: Equal
        value: arm64
  taskRunTemplate:
    podTemplate:
      tolerations:
      - effect: NoSchedule
        key: pipeline-priority
        operator: Equal
        value: low

should result in
apiVersion: v1
kind: Pod
metadata:
  labels:
    tekton.dev/pipelineTask: build-arm64-image
spec:
  tolerations:
  - effect: PreferNoSchedule
    key: arch
    operator: Equal
    value: arm64
   - effect: NoSchedule
     key: pipeline-priority
     operator: Equal
     value: low

Actual Behavior
apiVersion: v1
kind: Pod
metadata:
  labels:
    tekton.dev/pipelineTask: build-arm64-image
spec:
  tolerations:
  - effect: PreferNoSchedule
    key: arch
    operator: Equal
    value: arm64

Steps to Reproduce the Problem
1.create any pipelineRun with taskRunTemplate.podTemplate.tolerations and taskrunspec[].podTemplate.tolerations set.
2. inspect the pod created for the task that should inherit both tolerations.
3. the pod only has toleration from taskrunspec.podTemplate.tolerations[]
Additional Info

Kubernetes version: 1.25.12
Output of kubectl version:

WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.3", GitCommit:"434bfd82814af038ad94d62ebe59b133fcb50506", GitTreeState:"clean", BuildDate:"2022-10-12T10:57:26Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25+", GitVersion:"v1.25.12-eks-2d98532", GitCommit:"0aa16cf4fac4da27b9e9e9ba570b990867f6a3d8", GitTreeState:"clean", BuildDate:"2023-07-28T16:52:04Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.31.2
Chains version: v0.16.0
Pipeline version: v0.47.0
Triggers version: v0.24.0
Dashboard version: v0.35.0
Operator version: v0.67.0

What's meant in that PR is that you won't only get taskRunSpec[].podTemplate set. During the merge, we check for nil in taskRunSpec[].podTemplate.tolerations, it it's nil, then we set it to taskRunTemplate.podTemplate.tolerations.
Do we need a change in behavior? I can create a PR for that.
@vdemeester @pritidesai

/assign @khrm


Add dependabot

Some dependencies need to be not upgraded since I can't use anything that isn't net35

added in commit 96e1bb0bfa82b41801495f9c146b81437568465f


iqe debug mode in stage-post-deployment-tests

Description
Turn on iqe debug mode for stage-post-deployment-tests
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run go fmt ./... to check that my code is properly formatted
[ ] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #502 (1de0e98) into main (033327a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   30.98%   30.98%
=======================================
  Files          33       33
  Lines        3231     3231
=======================================
  Hits         1001     1001
  Misses       2136     2136
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033327a...1de0e98. Read the comment docs.


Gnome 40 Support

Hello. Fedora 34 user here. Any chance of updating this for Gnome 40?

Working on it....

Fixed for GNOME 40 on tag https://github.com/atareao/wireguard-indicator/releases/tag/v6

Ty for your excellent work!


npm-linked modules (duplicates or not) are not working.

Re:

https://github.com/Microsoft/TypeScript/issues/9566
https://github.com/microsoft/TypeScript/issues/9771
https://github.com/microsoft/TypeScript/issues/11916
https://github.com/microsoft/TypeScript/issues/6496

Search Terms
"typescript ignore npm linked dependencies"
Suggestion
I'd like for TypeScript to automatically work with npm linked modules.
Use Cases
Prevents developers from wasting much time.
Examples
npm link anything, and it just works.
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

More details
I'm on TS v3.4.5.
Even if a project's npm linked module has the exact same version of a dependency,
> npm ls react
<EMAIL_ADDRESS>/Users/trusktr/src/my-project
├─┬<EMAIL_ADDRESS>-> /Users/trusktr/src/my-lib
│ └──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
TypeScript complains. For example:
[0] ERROR in /Users/trusktr/src/my-lib/node_modules/@types/react/index.d.ts(2963,13):
[0] TS2717: Subsequent property declarations must have the same type.  Property 'view' must be of type 'SVGProps<SVGViewElement>', but here has type 'SVGProps<
SVGViewElement>'.

This is quite problematic, especially when needing to link 3, 4, or 5 modules at once during development, and especially more so when those linked modules have other npm linked modules. This issue grinds the dev experience to a halt. This npm link workflow is commonplace in with plain JS projects using NPM.
I've tried all workarounds mentioned in the other four issues, but each workaround brings with it other problems, or just don't work.
One workaround is to remove the duplicate dependency in the npm linked module, and this causes everything to work fine in the project, but then typings don't work while working on the npm linked module. So to get back to developing the npm linked module, we need to reinstall the missing dependencies. Then when we switch back to the project we need to delete the dependencies in the linked package. Then when we switch back to the linked package... etc...
I believe that TypeScript should deeply embrace how npm link works, and provide a built in solution so that TypeScript users never run into this again.

I think the solution involve TypeScript treating linked modules as if they live in the same node_modules folder (if it doesn't already), and use a top-down module resolution (file traversal) so that it will pick the top-most libraries from which to get dependencies from.
This would essentially work the same way as NPM's flattening approach, except TypeScript won't do any flattening, it'll just trust the flattened structure that NPM will already have put in place.

I meant to put I'm on TS v3.4.5 up there. Edited.

The workaround I mentioned, deleting the dependency in the linked module, doesn't work in this case (I thought it did before, but, now I'm not sure). Now I get
[1] ../my-lib/node_modules/@material-ui/core/styles/withStyles.d.ts:1:24 - error TS2307: Cannot find module 'react'.
[1]
[1] 1 import * as React from 'react';

As in my suggestion, if TypeScript treats the linked module as if it is not linked, and continues to traverse up the tree in the main project, then it will find react. This is how NPM module resolution works at runtime if we delete the dependency in the linked module. TS is not doing the same at compile time.

However, because we don't want to delete the dependencies in the linked modules (so that we can also go and work locally inside the linked modules when making changes to that module), this is why I suggested a top-down approach.

EDIT: The workaround does work: I was deleting react instead of @types/react in the linked module. If I delete only @types/react in the linked module, then the project uses the one at the root of node_modules.
The top-down idea still holds though.

I just experienced issues again today. As an example, I have a project-a which depends on project-b. Both project-a and project-b depend on the same version of react.
In project-b, I ran
npm install
npm link
npm run build # generates a dist/ folder

After doing this project-b contains react in its node_modules.
Then in project-a I ran
npm install # installs project-b (and its dependencies) from NPM

Now project-a contains both project-b and react in its node_modules. The folders look like this:
project-a
    node_modules
        react
        project-b

Now I want to work with a local version of project-b which I'm currently working on, so:
npm link project-b # link the local version of project-b into project-a

Now project-a contains react as well as a linked version of project-b. Remember that project-b also contains react. So now, the folder structure of project-a's node_modules looks like this:
project-a
    node_modules
        react
        project-b (symlinked)
            node_modules
                react

Now what happens if TypeScript gives errors like these:
[1]
[1] 2997             rect: React.SVGProps<SVGRectElement>;
[1]                  ~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:2998:13
[1]     2998             rect: React.SVGProps<SVGRectElement>;
[1]                      ~~~~
[1]     'rect' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:2998:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'stop' must be of type 'SVGProps<SVGStopElement>', but here has type 'SVGProps<SVGStopElement>'.
[1]
[1] 2998             stop: React.SVGProps<SVGStopElement>;
[1]                  ~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:2999:13
[1]     2999             stop: React.SVGProps<SVGStopElement>;
[1]                      ~~~~
[1]     'stop' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:2999:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'switch' must be of type 'SVGProps<SVGSwitchElement>', but here has type 'SVGProps<SVGSwitchElement>'.
[1]
[1] 2999             switch: React.SVGProps<SVGSwitchElement>;
[1]                  ~~~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3000:13
[1]     3000             switch: React.SVGProps<SVGSwitchElement>;
[1]                      ~~~~~~
[1]     'switch' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3000:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'symbol' must be of type 'SVGProps<SVGSymbolElement>', but here has type 'SVGProps<SVGSymbolElement>'.
[1]
[1] 3000             symbol: React.SVGProps<SVGSymbolElement>;
[1]                  ~~~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3001:13
[1]     3001             symbol: React.SVGProps<SVGSymbolElement>;
[1]                      ~~~~~~
[1]     'symbol' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3001:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'text' must be of type 'SVGProps<SVGTextElement>', but here has type 'SVGProps<SVGTextElement>'.
[1]
[1] 3001             text: React.SVGProps<SVGTextElement>;
[1]                  ~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3002:13
[1]     3002             text: React.SVGProps<SVGTextElement>;
[1]                      ~~~~
[1]     'text' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3002:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'textPath' must be of type 'SVGProps<SVGTextPathElement>', but here has type 'SVGProps<SVGTextPathElement>'.
[1]
[1] 3002             textPath: React.SVGProps<SVGTextPathElement>;
[1]                  ~~~~~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3003:13
[1]     3003             textPath: React.SVGProps<SVGTextPathElement>;
[1]                      ~~~~~~~~
[1]     'textPath' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3003:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'tspan' must be of type 'SVGProps<SVGTSpanElement>', but here has type 'SVGProps<SVGTSpanElement>'.
[1]
[1] 3003             tspan: React.SVGProps<SVGTSpanElement>;
[1]                  ~~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3004:13
[1]     3004             tspan: React.SVGProps<SVGTSpanElement>;
[1]                      ~~~~~
[1]     'tspan' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3004:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'use' must be of type 'SVGProps<SVGUseElement>', but here has type 'SVGProps<SVGUseElement>'.
[1]
[1] 3004             use: React.SVGProps<SVGUseElement>;
[1]                  ~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3005:13
[1]     3005             use: React.SVGProps<SVGUseElement>;
[1]                      ~~~
[1]     'use' was also declared here.
[1]
[1] ../project-b/node_modules/@types/react/index.d.ts:3005:13 - error TS2717: Subsequent property declarations must have the same type.  Property 'view' must be of type 'SVGProps<SVGViewElement>', but here has type 'SVGProps<SVGViewElement>'.
[1]
[1] 3005             view: React.SVGProps<SVGViewElement>;
[1]                  ~~~~
[1]
[1]   node_modules/@types/react/index.d.ts:3006:13
[1]     3006             view: React.SVGProps<SVGViewElement>;
[1]                      ~~~~
[1]     'view' was also declared here.
[1]

So it appears that when TypeScript is looking up type definitions, it picks up the ones in project-a's version of react and in project-b's version of react, where both react's even have the same version number.
The problem can be exacerbated when linking more than one package, and even more so when for example linking a project-c to project-b, linking project-b to project-a, and linking project-c to project-a.
The npm link workflow is a common workflow in many projects. However, I haven't used too much in the context of TypeScript projects until the last year where all my projects have been in TypeScript, not plain JavaScript.
solution thoughts:
I believe TypeScript should default to picking the types from a package which is the top-most package in node_modules.
So, from perspective of project-a, when TypeScript is compiling project-a code, it'd be nice if it chose the top-most react, and ignore the one in project-b's node_modules.

I'm struggling with this. This makes npm link workflows very difficult and time consuming.
Can I ask, have any of you used npm link workflows in TypeScript projects? Have you had any issues?

Is this a regression of https://github.com/microsoft/TypeScript/pull/16274 ?

Are you using<EMAIL_ADDRESS>I think #31541 should have fixed this. If not can you create sample repro so we can investigate this.

Alright, I'll report back when I give it a go.

@trusktr I have faced what I think is this same issue.. I was able to work around it by providing a paths configuration for the module in question, and setting preserveSymlinks to true in tsconfig. Would be curious if this worked for you. Similar to the solution for webpack via the "resolve.alias" configuration property (comes up when one has multiple versions of react introduced via npm-link).
...
"preserveSymlinks": true,
    "baseUrl": ".",
    "paths": {
      "office-ui-fabric-react": ["node_modules/office-ui-fabric-react"]
    }

I am using office-ui-fabric react, and have an imported library with customized components.

@sheetalkamat I've been on TS 3.7.2 lately, and still encounter issues regarding duplicates. Unfortunately, it hasn't happened on a public repo that I can share yet.

@trusktr if you need to, you can also share repro code privately at shkamat at Microsoft dot com and after we sign nda. Let me know if that would work to get repro. Unfortunately without repro we cannot investigate this further.

Ok, let me chat with someone in my team to see if I can approve an NDA.
In the meantime, I'm getting an error like this, for example:
node_modules/@scope/some-package/src/components/Foo.dom.tsx:325:5 - error TS2717: Subsequent property declarations must have the same type.  Property ''x-foo'' must be of type 'Foo', but here has type 'Foo'.

325     'x-foo': Foo
        ~~~~~~~~~~~

  ../scope/some-package/src/components/Foo.dom.tsx:325:5
    325     'x-foo': Foo
            ~~~~~~~~~~~

From that output, it seems that the type system is referring to the same type in two ways: one way is with node-style module resolution, and the other way is with a relative path.

Just to re-confirm, if I install the exact same package from git instead of using npm link (so I made a new branch, and pushed my changes, instead of relying on npm link to have my latest changes), then the issue goes away.
The only difference between the linked module and the git module, is that due to package.json have a file list of
  "files": [
    "dist",
    "src",
    "package.json"
  ],

the git-installed version does not have any of the extra files (f.e. the npm linked version has things like tsconfig.json, and other files normally used in dev mode). Not sure if this has anything to do with it.
I'll do a test...

Alright, after testing, if I manually create a symlink to the package, in node_modules, and then delete all files in it except the ones that are listed in files of the package's package.json (so it has the same content as if I had installed it manually), then I still have the same issue.
The file structure is identical either way (symlinked to a folder, vs installed normally).

you've found a solution or an workaround?

I'm also having problems with "npm link" and TS, however for me, TS seems to not be able to work with the symlinked module at all ...
Anyways, concerning this issue: I don't think it's TS task to manage "duplicates". The thing is, that the concept of "npm link" here already is flawed. It's just not the same thing to have a package being regularly installed with "npm install" and having dependencies flattened correctly, compared with arbitrarily changing the structure of node_modules when doing "npm link". For me, it is perfectly clear that TS just follows the usual node algorithm of including the nearest match (inside node_modules) ... and duplicate types in this case are a problem, because it has to be assumed that the duplicated dependency ends as duplicate at runtime ... well and then its really two different types ... e.g. try using instanceof operator on seamingly identical objects, whose constructor prototypes in fact are different objects.
To summarize: npm link should be changed in a way to produce more realistic results matching what would be installed if the package had been regularly installed by means of npm install. Just my two cents ...

I'm using npm link as we speak and haven't seen anything like this (nor a concrete report that demonstrates this problem). Closing. Please open a new issue with a specific repro if you're having problems. Thanks!


Super minor typo in examples/common/camera.cpp.

Line 138 m_mouseDown = !!_mouseState.m_buttons[entry::MouseButton::Right];.
I'm not very good with C++, but unless "!!" is a special operator in C++ that line will probably not work as intended.

!! turns integer into boolean to avoid warnings.

Thanks for the info.


Update unit test to handle arbitrary token decimals

Added config in tests to get configured decimals (default or env override).
Updated MockToken to take decimals as constructor argument.
Updated all instantiations of various tokens in unit tests to use decimals from config.
Updated proof generator to use 18 decimals (it uses mock token).
Added new script test:range. Example: npm run test:range -- 16 18

Fixes #735

Ready for reviow 🐉

Should MosaicCoreConfig be updated?

I don't understand. Can you please elaborate?

Should the range script end with the first value to have failing tests (current behavior) or handle failing tests with each value in the range?

I will change the script to run all the tests and change the exit code based on whether a test fails.

Should MosaicCoreConfig be updated?

I don't understand. Can you please elaborate?

Apologies for not being specific. From MosaicCoreConfig:
/** The number of decimals of the base token. */
uint256 public constant DECIMALSFACTOR = 10 ** uint256(18);

I asked because of the changes to base token references in this PR. On the other hand, perhaps those references shouldn't be dynamic and should always have 18 decimals?

Should MosaicCoreConfig be updated?

I don't understand. Can you please elaborate?

@schemar: apologies for not being specific. From MosaicCoreConfig:
/** The number of decimals of the base token. */
uint256 public constant DECIMALSFACTOR = 10 ** uint256(18);

I asked because of the changes to base token references in this PR. On the other hand, perhaps those references shouldn't be dynamic and should always have 18 decimals?

Hm 🤔 Good point. Mosaic core is way outdated by now. It's probably not worth it to mingle around in the core code in the context of this PR.

Ready for review again. Now accepts only one argument and continues after failed decimal (prints all failed decimals at the end).


Create iteration service added with tests

Current coverage is 52.64% (diff: 100%)

No coverage report found for master at b178097.

Powered by Codecov. Last update b178097...8e3551d


[REQUEST] team damage display

as seen in onetap, used for greifing

grief box https://github.com/danielkrupinski/Osiris/pull/1149
Block bot https://github.com/danielkrupinski/Osiris/pull/1048


[stable/jenkins] Support loading configs from file

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

there seems to be an issue with .Files where it just doesn't work in a range block without doing some extra work
The second commit provides a much simpler solution that just fixes the existing code but I'm not sure if it would be desirable to keep the functionality separate
would appreciate some feedback before I put any more effort into cleaning up the PR

This chart has been deprecated, and moved to https://github.com/jenkinsci/helm-charts see for details #23562
Please re-open your PR there.


feat: parity circuits

Fixes #4633
Note: The new model currently can't be used to consume the message on L2 because old model root is being inserted to the messages tree in root rollup circuit. We can be sure the root computed by new model is correct because it is already being set in the header and checked in the Rollup contract. I will start inserting the new root in my next PR in which I'll purge the old inbox.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5082  👈
#5025
#5036
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 100 (+836%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 507c374b and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
5,700
18,884
36,452

l1_rollup_calldata_gas
66,540
238,976
470,156

l1_rollup_execution_gas
674,003
979,797
1,388,930

l2_block_processing_time_in_ms
1,185
4,496
8,915

note_successful_decrypting_time_in_ms
195 (-4%)
549 (+1%)
999 (+1%)

note_trial_decrypting_time_in_ms
:warning: 100 (+836%)
70.5 (+15%)
130 (+10%)

l2_block_building_time_in_ms
12,181 (+2%)
47,940 (+1%)
96,057

l2_block_rollup_simulation_time_in_ms
7,368 (+1%)
29,384 (+1%)
58,777 (-1%)

l2_block_public_tx_process_time_in_ms
4,782 (+3%)
18,484 (+1%)
37,114 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
14,439 (-3%)
27,372 (+3%)

note_history_successful_decrypting_time_in_ms
1,221 (-1%)
2,329 (-3%)

note_history_trial_decrypting_time_in_ms
60.3 (-26%)
98.1 (-32%)

node_database_size_in_bytes
18,776,144
35,508,304

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
251 (-1%)
44,736
28,001

private-kernel-ordering
194 (-1%)
52,625
14,627

base-rollup
660 (+1%)
177,932
997

root-rollup
68.5
4,320
825

private-kernel-inner
317 (-1%)
73,715
28,001

public-kernel-app-logic
164
34,920
27,972

public-kernel-tail
82.2
34,507
27,972

merge-rollup
9.26 (-1%)
2,840
997

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts

tx_size_in_bytes
19,179

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes

tx_pxe_processing_time_ms
2,694
1,365 (-1%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
5.50 (-3%)
574

If possible, please could you add this Parity Circuit to the "Circuit Stats" that get created with each PR? It will be interesting to know and track the number of constraints of this circuit.

Hmm... actually, I can't see the gate counts table. @sirasistant didn't we used to have a table of protocol circuit gate counts, which got created with each PR?

Oh, it's not broken, I think it's just that it's omitting any rows that don't have any change in gate count, see this one https://github.com/AztecProtocol/aztec-packages/pull/5152#issuecomment-1991589550

I think it doesn't consider it to be a diff when the circuits are new. Here you can see the json report https://github.com/AztecProtocol/aztec-packages/actions/runs/8263421721/artifacts/1321982568


Incomplete pullsync error log

Context
bee 2.0.0 rc9
https://github.com/ethersphere/bee/blob/6fb07f335dd02e1118cab5cac40282b5aa5551b4/pkg/pullsync/pullsync.go#L256
Summary
The error log above is incomplete and potentially misleading.   If you look at it in context, it would be more correct to say:
invalid cac/soc chunk
since both validity checks failed before the warning is logged.
Expected behavior
Clearer logs.
Actual behavior
The log indicated that the chunk was an invalid soc, when in fact, it was also an invalid cac.
Steps to reproduce
Have pullsync process an invalid chunk, which seems to have been cleaned up in testnet compare to this morning.
Possible solution
Update the log text as indicated above.

Fixed in  #4225


Straighten out the top and bottom edges of logo

Thanks! :heart: What magic did you do to make the small logo look less blurry?


Gauge report isn't working

Versions

Fast Report:  Demos/FastReportCore.MVC.csproj fom the sources (master/Latest commit 664c4e9 [as is])
Browsers: Google Chrome v. 70.0.3538.102 (64-bit), IE 11.407.17134.0, MS Edge 42.17134.1.0

What happened
The following exception is occurring during opening Report Objects/Gauge demo report:
An unhandled exception occurred while processing the request.
CompilerException: (Function): Error CS0169: The field 'ReportScript.i' is never used
FastReport.Code.AssemblyDescriptor.InternalCompile() in AssemblyDescriptor.cs, line 454

Steps to Reproduce
Steps to reproduce the behavior:

Run project Demos/FastReportCore.MVC.csproj;
Select Report Objects/Gauge demo report;

Expected behavior
The report SVG.frx should be shown.
Screenshots

Logs
FastReport.Utils.CompilerException: (Function): Error CS0169: The field 'ReportScript.i' is never used

   at FastReport.Code.AssemblyDescriptor.InternalCompile() in H:\Master\Repository\FastReport\FastReport.Base\Code\AssemblyDescriptor.cs:line 454
   at FastReport.Code.AssemblyDescriptor.Compile() in H:\Master\Repository\FastReport\FastReport.Base\Code\AssemblyDescriptor.cs:line 364
   at FastReport.Report.Compile() in H:\Master\Repository\FastReport\FastReport.Base\Report.cs:line 1150
   at FastReport.Report.Prepare(Boolean append) in H:\Master\Repository\FastReport\FastReport.Base\Report.cs:line 2169
   at FastReport.Report.Prepare() in H:\Master\Repository\FastReport\FastReport.Base\Report.cs:line 2129
   at FastReportCore.MVC.Controllers.HomeController.Index(Nullable`1 report) in H:\Master\Repository\FastReport\Demos\Core\FastReportCore.MVC\Controllers\HomeController.cs:line 121
   at lambda_method(Closure , Object , Object[] )
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeActionMethodAsync>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextActionFilterAsync>d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeInnerFilterAsync>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeNextResourceFilter>d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeFilterPipelineAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeAsync>d__15.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__7.MoveNext()

Hello, @MrVitaly, thank you for issue, our Roslyn wrapper decided that a warning should be raised as an error, I will fix it.


Stop linting files in src/external

Adds .eslingignore and .stylelintignore files to stop unwantd liniting.
Closes #1342

Looking forward to this :p Currently sitting at 18 errors while playing with redux


[WIP] Change syncSecret approach

backend_ssl/secrReferenced is being used to check if a secret is used by auth-tls-secret annotation and spec.TLS attribute. This list goes beyond these two attributes, eg: auth-secret, secure-verify-ca-secret and some configmap options should also be checked. This list should grow. This was implemented on #991 .
IOW the current (without this PR) behavior is try to guess when a secret should be added, which is not working if the secret is used eg on auth-secret annotation.
The PR implementation is half of the way to create a facade to find secrets. I added the only missing ic.syncSecret() I found on my tests. This might be evolved to a single func that do this job (try/sync/try again). This PR works on my local env.
Another approach is add every single secret without trying to guess if it is used or not.
What about these strategies?

This change is

@jcmoraisjr we need secrReferenced because we must not dump all the secrets to file, only the ones that are being referenced by the ingress.

@jcmoraisjr I was waiting the client-go PR to be merged to finish this

Coverage increased (+0.09%) to 44.077% when pulling 08bcd941590c464f2a9fc625e0f48067c0fda899 on jcmoraisjr:jm-sync-secret into ce5e3999ab3186b134645fc7c6184c5a26696ced on kubernetes:master.


Update ControlNet SDXL inference pipeline and document

Btw, I suggest to move the controlnet condition as one part of the GeneralConditioner in SDXL, as it allows easier integration with controlnet condition estimator, like MiDas. Currently implementation seems not feasible with the neural network estimators.

Btw, I suggest to move the controlnet condition as one part of the GeneralConditioner in SDXL, as it allows easier integration with controlnet condition estimator, like MiDas. Current implementation seems not feasible with the neural network estimators.

Good suggestion, can make a separate PR later.


Add a script to setup the local llvm-project submodule for bazel to use for tensorflow integrations.

This will override the fetching of a massive archive and enables local edits to third_party/llvm-project to uniformly affect path main iree and tensorflow iree. Note that there is still a split and main-iree uses the standalone mhlo submodule and the tensorflow side uses its in-tree version.
Based on manual instructions: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/compiler/mlir#using-local-llvm-repo

Nice :)

Just briefly glancing. Why do we need a special script here? If we add IREE's configuration of LLVM ahead of TensorFlow's it will use that one.

If that works (it didn't used to), then I don't care how it is done. This script lets me do my job and if there is a better bazel way to do it, then we can do that. I'm unlikely to spend time figuring that out though.

See the comment at https://github.com/google/iree/blob/b7694fa168f6df641192702fa02b0009341b0d84/integrations/tensorflow/WORKSPACE#L37-L41
We deliberately let TF just do its thing and make no attempt to control anything other than IREE. Since February, it looks like tf_http_archive basically has maybe functionality (https://github.com/tensorflow/tensorflow/commit/7ed9c675) so we can configure the IREE versions first if we'd like

This is obsoleted by https://github.com/google/iree/pull/6817


Certain un-meldable constructs parse successfully but generate crashing code

In another project, I did this:
'('^ (member ','?)* ')'^ -> argument_list +{ ... }+

Note that the comma between member (arguments) is marked optional, but it's not ejected.
It looks like somehow "member" bubbles up (correctly) but then (incorrectly) successfully melds.  It should not be able to meld, because it doesn't know if it needs to skip commas or not.
If the commas are ejected, it (correctly) melds and dtrt.

fixed in 29d107e3c4d


Bogdan minor improvements - followup of #9

Bogdan minor improvements - followup of #9

Coverage decreased (-2.3%) to 93.659% when pulling b1e8887b7fd3fc8039cc6f71445c72d940c11aa6 on alexbumbacea:bogdan-minor-improvements into 096f1311db95ae5c26005061e3462632eb6dcd11 on eMAGTechLabs:master.

Coverage decreased (-2.3%) to 93.659% when pulling 4b88ae88d2b599d0976b57fbb3338e76f939a03f on alexbumbacea:bogdan-minor-improvements into 096f1311db95ae5c26005061e3462632eb6dcd11 on eMAGTechLabs:master.


feat: [IDP-3263]:  Added the release notes 0.29.0

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6698b67009d18e5274b24003--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6698cfcfd6b9116d92a99c5f--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6698f9c2ae3d1ba03edc1096--harness-developer.netlify.app


Bug in python-jaccount-cli

https://github.com/tc-imba/python-jaccount-cli/pull/2
That package cannot work anymore, and I cannot contact with the author. Shall we create a new package instead?

Okay. You can fork that package and I will update the deps in this package.

Created jaccount_auth.
You might need to change requirements.txt and login.py

Can you raise a PR for the changes and test it? I can not reach a PC and test it recently.

Can you raise a PR for the changes and test it? I can not reach a PC and test it recently.

I have submitted one, please check it out :)

May you publish this to pypi? Since the new semester is coming, we hope that new students can use joj tools. Thanks!

Done.

Done.

Great! Thanks


Intra and internet ip’s location

Hello,
I've few sites monitoring by my piwik which can be visited by both internal and external users.
I managed to locate users IP's internally and externally with IntranetGeoIP for internal and GeoIP (Php) provided with MaxMind's databases for external ones.
My issue is about how to manage an external IP who match internal one.
Let's see : say that we have the <IP_ADDRESS> address located in London, GB in our IntranetGeoIP.data.php file. But (at time where i write that post) this address is located in Los Angeles, USA externally.
When i track that ip in piwik, she is located in London.
My question is how can i manage that this IP is the external one and not the internal one ?
PS: If it can help, our external access is protected by multiple proxy and firewall so i've the HTTP_FORWARDED header.

I think i dont understand you correctly.
A public IP is a public IP? How can that IP be an internal address?

Hello, Thanks for your answer @ThaDafinser .
Because my company (don't ask me why) doesn't have only private addresses (ie: <IP_ADDRESS>/8, <IP_ADDRESS>/12, <IP_ADDRESS>/16) but also public addresses spaces on private context.

Sadly i dont know exactly how you can achieve that.
I think you need to trace down in Piwik Tracker...maybe you can change the priority somewhere (don't know if possible)

Okay, thanks for your answer.
I will search for a solution and maybe make a pr if i find something
regards,


Edit numeric input on click

User clicks on the numeric input to edit the value as a number (text input).
Depending on the type, should allow or disallow the decimal point.

If a Number or Float (or unknown type) should allow decimals.
If an Integer should not allow decimals.

Even if the widget would have min/max range specified, this mode of editing allows values outside the range.
Dragging should not start editing, but change slider value (if present).

Questions:

do we allow scientific notation? - probably not, just numbers and maybe single dot.
Refinement notes:
validation should be done on accept, and the value should be reverted if invalid (simplest approach).


Add support for a key binding to insert a hyperlink

Is your feature request related to a problem? Please describe.
Inserting hyperlinks ([]()) is cumbersome.
Describe the solution you'd like
I would like to be able to select some text, say, "foo", press a key binding for inserting a hyperlink, and make Dendron automatically decorate the text with [foo](), with cursor positioned inside the parentheses.
This is the behavior Microsoft solutions have under Ctrl+K, like OneNote, Outlook, Azure DevOps wiki. They call it "Insert Hyperlink".
Describe alternatives you've considered
I am currently using md-shortcut.toggleLink from https://marketplace.visualstudio.com/items?itemName=mdickin.markdown-shortcuts, as explained on Discord here: https://discord.com/channels/717965437182410783/742532267058004098/777702310431817769
Additional context
N/A

Dendron comes bundled with the markdown shortcuts extension. You can trigger a hyperlink with Markdown Shortcuts: Toggle Hyperlink. This can be bound to a custom keyboard shortcut. We can also do a better job of documenting this :)

Hah, that would explain why I have seen duplicates of the commands in the context menu. Thanks for clarification :) @kevinslin I'll leave it to you if you want to keep this issue open to keep track of the documentation work, or if to close it.

@kevins8 - were you thinking this is just a documentation task or can we set a preference to the the usual "ctrl/cmd + k" shortcut by default?

just a documentation task
On Wed, Mar 24, 2021 at 3:30 PM Kiran Pathakota @.***>
wrote:

@kevins8 https://github.com/kevins8 - were you thinking this is just a
documentation task or can we set a preference to the the usual "ctrl/cmd +
k" shortcut by default?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/352#issuecomment-806226350,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADD52LBOSFDKVPMEXIVQC3TFJRWRANCNFSM4TWSD5QQ
.

https://wiki.dendron.so/notes/3472226a-ff3c-432d-bf5d-10926f39f6c2.html#markdown-links


Change permission to support firefox

Just want to note that to make this works on firefox (install by self-signing or using the developer version) you could change the permission in the manifest as follows:
"permissions": ["https://*.twitch.tv/*", "https://*.ttvnw.net/*", "https://dqrpb9wgowsf5.cloudfront.net/*", "https://d1m7jfoe9zdc1j.cloudfront.net/*"],

This is relevant as the chrome web store is now saying that this extension will no longer be usable... probably for the same reason as adblockers


fix: require in TS at least 1 type of content for sending mail

Fixes #978

Hello @childish-sambino,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX

This has introduced a TS error when sending mails with just templateIds:

const data = {
	from: "someemail",
    to: "somemail",
    templateId: "some sendgrid templateId",
    dynamic_template_data: {randonVariables: "something"},
}

sendgrid.send(data)

Property 'content' is missing in type '{ from: string; to: string | string[]; templateId: string; dynamic_template_data: any; }' but required in type '{ content: MailContent[] & { 0: MailContent; }; }'.

We dont require there to be a body or content as its using a template?
Any ideas?

🤦♂ Need more |s.

as @JClackett mentioned, template use case was not included.
anyone working to add the type union in the MailDataRequired already?

@krazibit It was included as part of #1053

great, thanks!


Attention-OCR theano based !

Hi there,
Is there any plan for  theano based Attention-OCR ?
Best regards,

Thanks for your interest. We are currently working on a torch implementation of Attention-OCR. A theano implementation might also be added later. Meanwhile, since tensorflow and theano work under similar mechanisms, you can refer to our current code for the idea. Keep tuned :)

got it !
THX!


KAFKA-5018: LogCleaner tests to verify behaviour of message format v2

For https://issues.apache.org/jira/browse/KAFKA-5018:

Added test for baseOffset behaviour after compaction

Added helper method for writing a multi-record batch

Dried up handling of LogConfig.SegmentIndexBytesProp and added comments on the chosen magic values

@ijuma fyi :)

cc @hachikuji


feat: add feature flag to arbiter-core/ crate for contracts/

Idea
The files in arbiter-core are currently not being used anywhere in the project. We want to allow users the option to include them with the arbiter-core crate when using it as a dependency.
Solution
A feature flag should be added to the arbiter-core crate to optionally include the files in contracts/.

Taking this one up myself.


NEW ISSUE

My account keeps getting checkpoint-ed
P.S already turned off less secured app access

.........

Try logging in through your browser and if you are able to access your account come back and try again. Just make sure that you have typed your username and password correct
And check one again if allow less-secure apps is on

Try logging in through your browser and if you are able to access your account come back and try again. Just make sure that you have typed your username and password correct
And check one again if allow less-secure apps is on
Edit: found this link with some info:
https://support.google.com/mail/thread/26987633?hl=en

I tried logging in a new gmail account and it worked ....but there's a problem with the mail sent .Google flagged it as spam with a message of "This message seems dangerous
Similar messages were used to steal people's personal information. Avoid clicking links, downloading attachments, or replying with personal information."
Is there a way to fix that?

I'm working on it so it will bypass the gmail spam-filters
One way that might get passed it is if the link you added to the email is a redirecting website which redirect the target to the real phishing site
Gmail "scans" the links that's attached to an email and if it sees that it might be a phishing site it will send it to spam or flag it
The redirection is really easy and you can find the html code for it on google (just search "html redirect code") and you can host it on example 000webhost (free)
But I'm trying to fix it and will update it soon


MarkdownRemark Error

I can get this up and running on Netlify, and it works, with NetlifyCMS and all. But when I clone a clean copy to my machine, run yarn and yarn start I get this error during the process createLayouts.
GraphQLError: Cannot query field "allMarkdownRemark" on type "RootQueryType".
I think this is related to #2212, but this example project does not lack .md files. When I update the various transformers, I can maybe get past the error at that step, but it shows up later.
Any thoughts? I also tried Node 8.2.0, 8.4.0, and 9.1.11. I'd like to start from this template, but if I can't, I'll go through https://www.gatsbyjs.org/docs/netlify-cms/

Not sure what the core issue is still, but I found a fix.
There's something going on with the path. I was originally trying to install this in a folder with a non-alphanumeric characters, but when I moved it away, it worked. I tried it again by doing a clean clone. It then gave me an error about the sharp module. npm i sharp and it works fine.
To test this, I moved this working project into a new folder named testfolder, test-folder, test folder, testfolder), and everything but testfolder) works.


LowFundsModal copy done

@zkalman Fixed the scrolling issue. Added views for QR scanner and Transaction fees. Not sure where to add an icon that fits in with this large amount of content.


Intro to PSReflect-Functions

Intro to PSReflect-Functions

Name: Jared Atkinson
Your Timezone: UTC -7
Abstract: PSReflect is a PowerShell module that provides a mechanism for calling Windows API functions in PowerShell without the need to compile code at runtime. Unfortunately, the barrier to entry to implementing PSReflect "definitions" is somewhat high. For this reason, I've created an add on module called PSReflect-Functions which is a library that has many Windows API functions exported as a PowerShell function for easy plug and play. This sessions will describe the VERY high level concepts of PSReflect and show some practical use cases for getting started with PSReflect-Functions.
Optional links (remove if not using)

Twitter: https://twitter.com/jaredcatkinson

This was awesome, thanks @jaredcatkinson!


Message to footer component

Added a message to footer component, letting people know how to submit their feedback or report bugs

Resolve #35


Organize ADR assets

Closes #1602

@Chirag018 this repo attempts to adhere to https://www.conventionalcommits.org/en/v1.0.0/ so it would help if PR titles contained a conventional commit prefix (i.e. "docs: organize ADR assets") because the PR title will show up in auto-generated release notes. Ex. https://github.com/celestiaorg/celestia-app/releases/tag/v0.15.0-rc0

@Chirag018 thanks for working on this! markdownlint will fail until the links in the ADRs are updated to point to the new location. After that, this PR should be good to go.

Sorry, my bad, forget to update that!


feat: clamav install and virus def to s3

scan-files will now also support scanning using ClamAV in addition to the already configured AssemblyLine. A CloudWatch event rule will trigger antivirus updates every 2 hours and save the definitions to a s3 bucket. This will allow lambda invocations to retrieve the antivirus definitions instead of performing a full update every time they run.
This PR contains:

Clamav setup in the Lambda container
Lambda event trigger to be used by CloudWatch to start antivirus definition updates.

Futre PRs:

Submit files for scan

I was just passing by and really enjoyed the reading this PR :)


csharp custom server call contexts?

What version of gRPC and what language are you using?
chsarp version 1.4.1
What operating system (Linux, Windows, …) and version?
WIndows 10 pro
What runtime / compiler are you using (e.g. python version or version of gcc)
.netcore 2 preview
Anything else we should know about your project / environment?
Hey gRPC team -
I'd like to know how people are going about storing session information.  I'm sure passing a 'session id' per call in the header is one way and getting the data locally per gRPC call will work, but I'm wondering if it would make sense to have some CallInterceptor that adds session information into the ServerCallContext?  This would be nice to automate this.
This would be done with the following steps:

Create call interceptor
Call interceptor gets session id and validates it.
Valid sessions, the call interceptor gets forwarded and SessionData gets attached to the ServerCallContext.

Any thoughts or better solutions to this?  I'm down to contribute and create a more formal proposal if some support is required.

Well, I'm using AsyncLocal + CallInvoker for context creation. It just feels a bit off for having ServerCallContext and then Context.Get<> for call contexts. I'll think on this more, but for now will close the issue.


Fix efficient ad

📝 Description

🛠 Fixes #1943

Several changes to fix the performance:

Replaced teacher weights with the ones from Nelson1425, thanks to @alexriedel1 for advice. Renamed layers to match anomalib implementation, new weights can be downloaded here.
Removed Imagenet normalization from transforms for this model, because it is in the forward for every submodel already. Added checkup to detect if it is added by the user.
The train_batch_size should be 1, as described in the paper. It seems hard to hardcode because it is used in the AnomalibDataModule, which has no access to the model's name, so I have just added a checkup to raise an error if the value is not 1.
Removed parameter batch_size from efficient_ad.yaml, because it was affecting only Imagenet batch size, which should always be 1 according to the paper.
Changed max epochs in efficient_ad.yaml to 1000, because if you don't have many images per class (as in MVTec AD), the model needs to run more epochs to finish 70000 steps, which are needed to reproduce results from the paper.

✨ Changes
Select what type of change your PR is:

[x] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🔨 Refactor (non-breaking change which refactors the code base)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📚 Documentation update
[ ] 🔒 Security update

✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:

[ ] 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
[ ] 📚 I have made the necessary updates to the documentation (if applicable).
[ ] 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

There is one more thing when training EfficientAD:
The validation Pixel F1 Score is calculated correctly after the first training epoch. From the second epoch on, the pixel F1 stays equally low during training. The correct value can then be obtained in the test phase again.
engine.fit(datamodule=datamodule, model=model)
Epoch 1 ... pixel_F1Score=0.2551 ...
Epoch 2 ... pixel_F1Score=0.0421 ...
Epoch 3 ... pixel_F1Score=0.0421 ...
Epoch 4 ... pixel_F1Score=0.0421 ...

engine.test(datamodule=datamodule, model=model)
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃        Test metric        ┃       DataLoader 0        ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│        image_AUROC        │            1.0            │
│       image_F1Score       │    0.9919999837875366     │
│        pixel_AUROC        │    0.9815982580184937     │
│       pixel_F1Score       │    0.7310670018196106     │
└───────────────────────────┴───────────────────────────┘

I think this is due to a drastic change of the anomaly map values after normalizing the anomaly maps in the first epoch. Is it possible that the pixel threshold is not resetted bevore every validation epoch?

Do you see any performance increases? If so can you provide some numbers?

Do you see any performance increases? If so can you provide some numbers?

Sure, here are the results for image-level AUROC, seed 42, different classes of MVTec dataset, and model sizes (S or M):

After setting train_batch_size to 1 and max_epochs to 1000 to fit the paper settings, capsules S: 87.8
After replacing teacher weights, capsules S: 98.8, screw S: 81.2
After removing the second Imagenet Normalization, screw S: 95.9, cable S: 94.8, transistor S: 99.8, pill M: 98.1

The last row shows results similar to the results from the paper.

Do you see any performance increases? If so can you provide some numbers?

Sure, here are the results for image-level AUROC, seed 42, different classes of MVTec dataset, and model sizes (S or M):

After setting train_batch_size to 1 and max_epochs to 1000 to fit the paper settings, capsules S: 87.8
After replacing teacher weights, capsules S: 98.8, screw S: 81.2
After removing the second Imagenet Normalization, screw S: 95.9, cable S: 94.8, transistor S: 99.8, pill M: 98.1

The last row shows results similar to the results from the paper.

Looks good to me!
The AUC-ROC EfficientAD paper results for comparison are:
EfficientAD S:
Screw: 0.97315
Cable: 0.92537
Transistor: 0.998
EfficientAD M:
Pill: 0.98608
Anomalib Patchcore WideResnet_50:
Screw: 0.924
Cable: 0.990
Transistor: 1.000
Pill: 0.924

Thanks a lot for the effort, @abc-125. The changes look good to me. If @alexriedel1 also agrees, we could merge.
@alexriedel1 can you let me know what you think? Thanks

Yes go for it!
Be sure to include the new model weights in the releases and then the weight download can be updated accordingly https://github.com/openvinotoolkit/anomalib/blob/2d59cb160aaff8d38b445d4f30a592ca289d3427/src/anomalib/models/image/efficient_ad/lightning_model.py#L35-L39

Great job 😄. This also partially fixes #1813

@ashwinvaidya17, the tests are failing. I guess it's related to the weights?

I think the tests need to be updated

https://github.com/openvinotoolkit/anomalib/blob/f396dd4ab6a40b7b2f95004278d328fff18c999e/tests/integration/model/test_models.py#L207

Ah yes, of course!

I think the tests need to be updated

Thank you, @ashwinvaidya17! I have updated the train_batch_size for this model in test_models.py.

I think the tests need to be updated

Thank you, @ashwinvaidya17! I have updated the train_batch_size for this model in test_models.py.

Thanks @abc-125, merging now!


Add security headers

HTTP Strict Transport Security is an excellent feature to support on your site and strengthens your implementation of TLS by getting the User Agent to enforce the use of HTTPS. Recommended value "Strict-Transport-Security: max-age=31536000; includeSubDomains".
Content Security Policy is an effective measure to protect your site from XSS attacks. By whitelisting sources of approved content, you can prevent the browser from loading malicious assets.
X-Frame-Options tells the browser whether you want to allow your site to be framed or not. By preventing a browser from framing your site you can defend against attacks like clickjacking. Recommended value "X-Frame-Options: SAMEORIGIN".
X-Content-Type-Options stops a browser from trying to MIME-sniff the content type and forces it to stick with the declared content-type. The only valid value for this header is "X-Content-Type-Options: nosniff".
Referrer Policy is a new header that allows a site to control how much information the browser includes with navigations away from a document and should be set by all sites.
Feature Policy is a new header that allows a site to control which features and APIs can be used in the browser.

Now considering
Strict-Transport-Security: max-age=31536000
X-Frame-Options: SAMEORIGIN
X-Content-Type-Options: nosniff
Referrer-Policy: no-referrer
Feature-Policy: accelerometer 'none'; camera 'none'; geolocation 'none'; gyroscope 'none'; magnetometer 'none'; microphone 'none'; payment 'none'; usb 'none'
Content-Security-Policy: default-src https:; script-src 'self'; style-src 'self'; font-src https://fonts.gstatic.com

dropping this for a while


RDMA Implementation

As we discussed in #124, we open sourced our internal RDMA implementation (https://github.com/bytedance/ps-lite) for PS-Lite at Bytedance. It is based on the implementation in #124, but we did many optimizations so that it outperforms TCP consistently.
Here are some end-to-end results on distributed training, copied from #124:
We use Tesla V100 GPUs, and set batch size as 32. Each machine (no NVLink) has 8 GPUs, and machines are inter-connected by 100 Gbps networking (can support TCP and RoCEv2). When using TCP, we are referring to the vanilla ZeroMQ implementation of ps-lite.
Note: The values are images per second.
ResNet50:

#GPU
TCP
RoCEv2

8
1008
2019

16
2279
4037

32
5048
7798

64
6954
14780

VGG16

#GPU
TCP
RDMA

8
163
303

16
361
692

32
694
1393

64
1370
2777

Hi,
I am testing the commit 2c8ed25384fc0ea00a70f081f8308170146d8f25 for ibverbs(RDMA). However, facing issues when running mxnet/example/image-classification/train_cifar10.py in MXNet (v.1.5.0) with
export DMLC_PS_VAN_TYPE='ibverbs'
export DMLC_INTERFACE='ib0'

The error is from the server:
[22:35:10] src/van.cc:307: Bind to role=server, ip=<IP_ADDRESS>, port=40243, is_recovery=0
[22:35:10] src/./ibverbs_van.h:568: Connecting to S
[22:35:18] src/./ibverbs_van.h:568: Connecting to S[8]
[22:35:18] src/./ibverbs_van.h:568: Connecting to S[8]
[22:35:18] src/./ibverbs_van.h:568: Connecting to S[8]
[22:35:18] src/van.cc:254: S[8] is connected to others
mlx5: node2: cqn=0x1d, got completion with error:
00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000
00000005 00000000 00000000 00000000
00000000 9d005304 09015c74 0c9f25d3
terminate called after throwing an instance of 'dmlc::Error'
  what():  [22:35:24] src/./ibverbs_van.h:814: Check failed: wc[i].status == IBV_WC_SUCCESS Failed status
local protection error 4<PHONE_NUMBER>9248 83

There is no problem if I use
export DMLC_PS_VAN_TYPE='zmq'

BTW, I can pass the tests in src/tests when DMLC_PS_VAN_TYPE='ibverbs'.
How to run this version of ps-lite with MXNet?
@changlan
Thank you

@juncgu Would you please test it with MXNet 1.3 or 1.4? Just wanted to make sure it is not a regression issue.

@juncgu Would you please test it with MXNet 1.3 or 1.4? Just wanted to make sure it is not a regression issue.

Hi @changlan,
I tried with MXNet 1.4.0, and got the same error:
[00:53:42] src/van.cc:307: Bind to role=server, ip=<IP_ADDRESS>, port=45062, is_recovery=0
[00:53:42] src/./ibverbs_van.h:568: Connecting to S
[00:53:44] src/./ibverbs_van.h:568: Connecting to S[8]
[00:53:44] src/./ibverbs_van.h:568: Connecting to S[8]
[00:53:44] src/./ibverbs_van.h:568: Connecting to S[8]
[00:53:44] src/van.cc:254: S[8] is connected to others
mlx5: node2: cqn=0x1d, got completion with error:
00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000
00000005 00000000 00000000 00000000
00000000 9d005304 09015c89 0768a5d2
terminate called after throwing an instance of 'dmlc::Error'
  what():  [00:53:49] src/./ibverbs_van.h:814: Check failed: wc[i].status == IBV_WC_SUCCESS Failed status
local protection error 4<PHONE_NUMBER>1568 83

hi @changlan , thx for this nice PR, are there any docs about how to enable the ib comunication ?

@zrss set DMLC_PS_VAN_TYPE=ibverbs
See https://github.com/dmlc/ps-lite/blob/2c8ed25384fc0ea00a70f081f8308170146d8f25/src/postoffice.cc#L18


Current TPS doesn't work (it shows N/A)

seriously?! 7 months still not solved? maybe better to take the website down at this point


Feature: Option to Set Full Page Background, ignore the page margins

The content page may need margins to be properly displayed. if not set top and bottom margins, the position where page breaked will reach top or bottom edge of the paper. If page margins set,  the page background in html body won't  be full page.

This is the puppeteer limitation. You can search for it. Maybe there is a workaround, but this package can't do anything about it.
I'm working on a new project that will solve your problem, you can follow it in #12, but I think the first beta version will be ready in 2 months.


ItemsControl: WrapSelection

What does the pull request do?

As #3743 suggests, this implements support for ItemsControl (and by extension ListBox) wrapping the selection around when going out of bounds.
What is the current behavior?

ItemsControl does not support wrapping at all.
What is the updated/expected behavior with this PR?

ItemsControl now has a WrapSelection property that can be used to enable the new wrapping behavior.
How was the solution implemented (if it's not obvious)?

Using existing wrapping behavior (which had to be slightly fixed) in ItemVirtualizerSimple. There was an issue there where if a null control was passed, the navigation code would always fail early, even if having a control wasn't necessary (which is the case for wrapping).
Checklist

[x] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[x] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues
Fixes #3743

Just a few comments about naming:

I would normally expect bool to have the Is prefix such as IsSelectionWrappingEnabled ... long I know
Perhaps this should be an enum like TextWrapping. Maybe there are some additional selection wrapping cases? For example if selection should only wrap vertically or both vertically or horizontally, or even only wrap when using keyboard interactions, etc.

Just some things to consider, not making any suggestions one way or another.

@grokys If the property is there I think it should work its purpose, I see no reason for it to be unimplemented in ComboBox.

@grokys after testing, it seems ComboBox is already respecting the setting, unless I'm mistaken? I've added a CheckBox to ControlCatalog, please check it. I couldn't figure out how to add a test for it though.

@mat1jaczyyy sorry it took me so long to get back to this. ComboBox respects the setting when the dropdown is open, but not when using the arrow keys on a closed ComboBox.

You can test this PR using the following package version. 0.10.999-cibuild0018486-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


App does not detect itself when the webView crashed

After merging #809, #801 has been mitigated. When the app tries to execute something in the webView and the platform channel broke down, we detect that and re-initialize the webView. However, the rpc-subscriptions die until re-initialization, so we only detect that the platform channel broke after an active fetch of the new data, or after at most 2 minutes when we refresh the data anyhow.
I suggest not to resolve this issue because:

webView channel breaks down only upon a scheduled background task (every 12 hours currently) if the app is running at the same time.
The consequences is merely slightly outdated data
Most of the app interaction triggers a data refresh anyhow.

Not so nice: If this is happens while we wait for a callback from js, we wait forever for the callback and it will not return.

With the workmanager gone, this is no longer an issue.


Test-DbaLastBackup Apply Full/Diff/Tlog

Feature Request
Is it possible to extend the test to diff and tlog backups.  While testing the full is good, if a diff or tlog chain is broken or corrupt the backups are not truly good.  We have a TSQL solution that will restore the full and do checkdb and then do the full / diff then do the checkdb.  Final test is full / diff / random tlog date and time for a PIT restore and then apply all tlogs to get to that PIT.

It's already doing it, why should be there a switch to ignore incrementals?
Il 22 set 2017 1:44 PM, "Garry Bargsley"<EMAIL_ADDRESS>ha
scritto:

Feature Request
Is it possible to extend the test to diff and tlog backups. While testing
the full is good, if a diff or tlog chain is broken or corrupt the backups
are not truly good. We have a TSQL solution that will restore the full and
do checkdb and then do the full / diff then do the checkdb. Final test is
full / diff / random tlog date and time for a PIT restore and then apply
all tlogs to get to that PIT.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sqlcollaborative/dbatools/issues/2286, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAHdB5XEEvV7s6oksAgN1nGbcEVgfdiTks5sk52hgaJpZM4PgmAW
.


Add ID command for IMAP

Fixes #5089
This PR is based on the implementation of useCompression and PR #5578.
I have tested this PR on Netease mail, which requires the ID extension. It works as expected.

While this PR is functional, I have some uncertain points about it.

The loadDefaults() in AccountPreferenceSerializer.kt contains the default value of isIgnoreChatMessages, but I can't find the default value of useCompression in this function. Should I add sendClientID in it?
The getBoolean() and putBoolean() in AccountSettingsDataStore.kt contain the ignore_chat_messages (get, set), but I can't find useCompression or something related in these functions. Should I add sendClientID/send_client_id in them?
account_settings.xml contains the preference of ignore_chat_messages, but I can't find preference of useCompression or something related in this file. Should I add sendClientID/send_client_id in it?
In this PR, the default value of sendClientID is false. Should I change it?
I didn't write a unit test of this setting. For now I have no idea how this option is tested.
How do you think of the name sendClientID? Should I change it?
The name of K-9 is hard coded in the ID command. should I change it or read it from elsewhere?

A handful of providers seem to require the ID command. So it should probably be enabled by default.

The name of the app ("K-9 Mail") should be supplied via a BuildConfig field. See e.g.

Instead of adding a Bool and a String to ImapSettings, add clientId: String?. That way we can send the ID command if clientId is not null, and skip sending the ID command otherwise.

Sorry. I'm not clear about the code for them. Do you mean add a single String setting item in the ImapSettings? If so, how do the users configure it? IDK if it should be configured by a checkbox or a textfield. Plus, how does this setting item work with the BuildConfig field?
I guess we can add a checkbox in the AccountSetupIncoming.java. If it's checked, write the text from corresponding BuildConfig field to the setting item clientId. If not, set the clientId to empty. When establishing the connection,

send the ID command if clientId is not null, and skip sending the ID command otherwise.

IDK if this logic is appropriate.

Do you mean add a single String setting item in the ImapSettings?

Yes.

If so, how do the users configure it?

They don't. The app will set the value to its app name (read from a BuildConfig field) if the setting to send the client ID is enabled and to null otherwise.

By the way, I wonder why not adding a Boolean setting item, then read the BuildConfig.clientID when establishing the connection.

I will squash my commits when things are ready.

The IMAP code is in a library project that knows nothing about the app using the library. It's also a JVM-only project, that doesn't have access to BuildConfig because that's an Android build system thing.

The IMAP code is in a library project that knows nothing about the app using the library. It's also a JVM-only project, that doesn't have access to BuildConfig because that's an Android build system thing.
I see.

Apologies for not being clear enough. Account should still only keep track of a boolean value, isSendClientIdEnabled.
The code to translate Account.isSendClientIdEnabled and the app name into a configuration for the IMAP library should go into ImapBackendFactory.

Apologies for not being clear enough. Account should still only keep track of a boolean value, isSendClientIdEnabled.
The code to translate Account.isSendClientIdEnabled and the app name into a configuration for the IMAP library should go into ImapBackendFactory.

OK. I will refactor my code tomorrow because it's late night(UTC+8).
I think most of the part has been implemented in commit 209a8138418b63d86d487b114f0fd543c435d780. You can check it and give me more suggestions if you want.

If the code is good I'll implement the unit test.

Thank you for spending time reviewing this. I have changed the code as you suggested and tested in on my device. It works as 2096b97

Test cases we should probably have:
* ID capability not present → make sure ID command is not sent
* ID capability present and setting enabled → make sure ID command is sent
* ID capability present and setting disabled → make sure ID command is not sent

Sorry, I don't know what's the server response look like if the ID capability is present. Could you please implement the tests?

Thanks :+1:

Thank you so much for guiding me and reviewing this!


404 at: /engine/installation/userguide/storagedriver/

URL: /engine/installation/userguide/storagedriver/

Thanks! This has been reported in #1310.


Feature request : callback after built page

this allows to define a function that will be executed each time a page is built
in my case, I wanted to save all the jd_vars in an external file for later use, so I will overload the function  on_page_built with :
function JuDoc.on_page_built(jd_vars)
    d = Dict()
    for (key, value) in pairs(jd_vars)
        d[key] = value |> first
    end

    output = joinpath("assets/vars", JuDoc.change_ext(basename(d["jd_rpath"]), ".json"))
    open(output, "w") do f
        write(f, JSON.json(d, 2))
    end
end

I'm not sure if it's the right way to do it, but this way it doesn't change the current behaviour or built time when this function is unchanged, but allows for more complex behaviours

Hello Mark!
Thanks for suggesting this and apologies for the delay, I was offline last week.
I could see this being useful potentially but am wondering whether it might not be better to allow serve to take that as a keyword argument and to pass the rendered page as well as the jd vars
function my_function(pg, jd_vars)
  # whatever you want
end
# ...
serve(...; on_write=my_function)
# ...

which would be called at the same place as where you put it.
What do you think?

Yes definitely, it is probably a better way of doing it
I will look into it

superseded  by #336


Allow User to Collapse Navigation Menu

By default Menu should be Collapsed

By default navigation menu is collapsed.
There are still some issues while changing window size but by defeault there should be no issue.
If there will be some isssues, above current implementation they will be probably addressed.


[bug]: "Using recommended DDIM sampler for inpainting"

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
6GB
What happened?
I saw that Web UI's Unified Canvas feature ignores the sampler selection (e.g. Euler_a), only letting me use DDIM. Why? At least, this is what the console says...
Is there a way to configure this?
Screenshots

Additional context
No response
Contact Details
No response

I did some testing, It looks like when using the in-painting model in the unified canvas your sampler choice is respected.
If you try to use any other model, your choice is ignored unless you use "ddim" , "plms"
It would nice to be able to use any sampler when in-painting with another model. Sometimes the inpainting model is not the best for all situations.


Adds support for<EMAIL_ADDRESS>Closes #5942

Adds support for<EMAIL_ADDRESS>Closes #5942

Merged manually, thanks! 👏