[ Taking a photo won't save it into the gallery ? ]

Hi,
First of all, Thanks for the great job ^^
Now, when i use the picker with :
XFile? image = await picker.pickImage(source: ImageSource.camera);
i can print the path of the image but when i go to the gallery the photo won't be there...
Do we have to save the photo ourselves ? how ?
Thought it would save it clicking the "V" button before going back to the app nah ?
Thanks in advance.
EDIT :: got into the lib code and saw it was intentionnaly not done...
How to save it if i want ?
And more important :
1°/ how can i change the name of the picture/path of the photo that as been picked ?
2°/ Is the folder .../app/cache/... regularly cleaned ? or do i have to do it myself ?
Thanks ^^

you may rely on 3rd party packages for this (e.g.: https://pub.dev/packages/gallery_saver)

Hi @Gobmichet
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and ask questions like this.
You may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it. Thank you!


Shazam-like Voice Detection AI for line being spoken/sung

I don't think this is easily possible, but some users are requesting we use the mics in phones/laptops/tablets to "hear" what is being sung and automatically suggest it to the user or if it's super accurate then automatically present it.
Any thoughts / ideas on how to achieve this? I have marked this as low (would be nice to have) and on hold (not planning to work on this) unless we have some better ideas of how it can be done and how long it would potentially take. Currently there is no roadmap in my head for achieving this.

It might be possible for hukamname, since the clarity of words is much higher, but you still need speech-to-text for punjabi to function. I will say though, if we can get good clarity on some syllables in each word, that could actually be effective.
Requirements:

Some sort of way of searching for a mixture of things in a word. So if the line is har har har gun gaavao, need a way of searching for things - maybe hr h r gn gaao is heard by the speech-to-text, and so if we can feed that in to get a match (basically, a search that is "any letters of each word", a bit like first word)

Some sort of STT for gurmukhi

but if you'd like to even try making this work for kirtan, we could potentially run some ML models on existing kirtan (so you can map many ways of singing a shabad to each shabad itself), and then classify sound and see what it matches. The pros are that this could be effective for singing, but downside is that Shabads that haven't been sung before in our training dataset (I imagine there will be many) will not be classifable/detectable (in any instance, without training).
BUT... here's an idea. SOS opt-in to mic. That way, we could attempt to use Shabad OS input (of sound + whatever is being shown on the projector) to automatically train/improve out dataset. This sounds like something that could be very interesting, but potentially out of mainstream scope for now.

@Harjot1Singh @bhajneet wow just stumbled across this conversation when making my slack messages read. My uncle is a very wealthy businessman and wanted to give me money to get this feature done. I said I work with you guys and i don't think it's so practical, like I know when the tune of har raam naam jap laha starts on the vaja i already got the shabad up, and there are so many similar shabads with the 2nd half different...technically have no idea how to achieve it as you know i'm not in coding, AI or speech recognition, BUT from an audio perspective if you could make shabad os listen to a usb interface taken in for the broadcast, you should have a clear enough sound there to decipher.
This a very interesting project and if you do know of someone who we could pay to get this done then I could potentially get funds for this.

Depends on https://github.com/ShabadOS/gurmukhi-utils/issues/22

BUT... here's an idea. SOS opt-in to mic. That way, we could attempt to use Shabad OS input (of sound + whatever is being shown on the projector) to automatically train/improve out dataset. This sounds like something that could be very interesting, but potentially out of mainstream scope for now.

Though interesting, it seems a bit too much like snooping/breach of privacy. Also unnecessary with the vast amount of keertan/kirtan audio files/videos readily available.


Thirdweb Pay

PR-Codex overview
This PR introduces classes and methods for buying with fiat and crypto, fetching buy history, and getting currency information.
Detailed summary

Added classes for fiat currencies and buy history
Implemented methods for buying with fiat and crypto
Defined constants for API endpoints

The following files were skipped due to too many changes: Thirdweb/Thirdweb.Pay/Types.Shared.cs, Thirdweb/Thirdweb.Pay/Types.GetBuyWithFiatStatus.cs, Thirdweb/Thirdweb.Pay/ThirdwebPay.GetBuyWithCryptoQuote.cs, Thirdweb/Thirdweb.Pay/Types.GetBuyWithCryptoStatus.cs, Thirdweb/Thirdweb.Pay/Types.GetBuyWithFiatQuote.cs, Thirdweb/Thirdweb.Pay/Types.GetBuyWithCryptoQuote.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Attention: Patch coverage is 0% with 459 lines in your changes missing coverage. Please review.

Project coverage is 75.73%. Comparing base (df96324) to head (1f4d617).

Files
Patch %
Lines

...irdweb/Thirdweb.Pay/Types.GetBuyWithCryptoQuote.cs
0.00%
75 Missing :warning:

Thirdweb/Thirdweb.Pay/Types.GetBuyWithFiatQuote.cs
0.00%
56 Missing :warning:

.../Thirdweb.Pay/ThirdwebPay.GetBuyWithCryptoQuote.cs
0.00%
44 Missing :warning:

...eb/Thirdweb.Pay/ThirdwebPay.GetBuyWithFiatQuote.cs
0.00%
43 Missing :warning:

Thirdweb/Thirdweb.Pay/ThirdwebPay.GetBuyHistory.cs
0.00%
38 Missing :warning:

...Thirdweb.Pay/ThirdwebPay.GetBuyWithCryptoStatus.cs
0.00%
34 Missing :warning:

...b/Thirdweb.Pay/ThirdwebPay.GetBuyWithFiatStatus.cs
0.00%
34 Missing :warning:

...irdweb.Pay/ThirdwebPay.GetBuyWithFiatCurrencies.cs
0.00%
29 Missing :warning:

...rdweb/Thirdweb.Pay/Types.GetBuyWithCryptoStatus.cs
0.00%
28 Missing :warning:

Thirdweb/Thirdweb.Pay/ThirdwebPay.BuyWithCrypto.cs
0.00%
23 Missing :warning:

... and 5 more

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #31       +/-   ##
===========================================
- Coverage   93.17%   75.73%   -17.45%
===========================================
  Files          23       38       +15
  Lines        1993     2452      +459
  Branches      226      241       +15
===========================================
  Hits         1857     1857
- Misses         99      558      +459
  Partials       37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use plugins provided by base image

Type of change

Enhancement / new feature
Refactoring

Description
Use the plugins bundled with the Artemis base image.
Remove jmx_exporter now that base image includes prometheus plugin.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@robshelly Could you have a look at the monitoring configuration? I'm not sure about the naming (health-tls) for TLS endpoints etc. Ideally it should trust some CA, but we don't have a service-wide CA right to trust right now.

@enmasse-ci run tests profile=shared

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: shared
TEST_CASE:
TOTAL: 88
PASS: 82
FAIL: 0
SKIP: 6

@enmasse-ci run tests profile=isolated

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated
TEST_CASE:
TOTAL: 96
PASS: 90
FAIL: 0
SKIP: 6


Godot integers are sliced to 32-bit integers when marshalled to Mono/C#

Godot version:

3.2 (hash: be5a47e75d), somewhat specifically a custom editor build with godot steam 3.2
which has no modifications except for the addition of the godot steam module to the trunk. It is a public github repository and I can link to it/include it if anyone wants to investigate.
Issue description:

When marshaling a godot int variant to the mono runtime/C#, a boxed 32-bit int is returned, slicing integers that only fit in a 64-bit integer, which godot supports. I am trying to use the GodotSteam engine module with C#, but SteamIds are 64-bit integers, and they are sliced when results are returned to C#. The engine code at: modules/mono/mono_gd/gd_mono_marshal.cpp:557 (at line 557) marshals ints to a boxed 32-bit integer in the mono runtime. I have made some experimental changes sending to 64-bit. I wouldn't mind making a PR, but certainly pending discussion since I'm new to the godot engine, and this sounds like it could be a breaking change if all C# projects now
need to use the long type in C# to refer to godot ints.
case Variant::INT: {
  int32_t val = p_var->operator signed int();
  return BOX_INT32(val);}

Steps to reproduce:

Create any Godot project
add a C# script
access any godot function that returns an int (in my case it was GodotSteam's LobbyId)

Minimal reproduction project:
I can upload an example if necessary, but GodotSteam is rather intense of a minimal viable reproduction, and admittedly I'm having csproj issues building on my windows machine with a freshly installed mono-capable release version of 3.2, But here is my untested MVR.
mvr-godot-slices-mono-ints.zip

cc @neikeq

The lines you mentions should indeed be changed to return an long:
https://github.com/godotengine/godot/blob/02f7908d460bea7d580fe7526949be7f294e6783/modules/mono/mono_gd/gd_mono_marshal.cpp#L628
However, that is for assigning Variant::INT to something that expects object (anything). In your example project that's not what's happening. Your method receives an int instead of a long so it's correct to slice it.
I think your example project doesn't reflect correctly the actual issue you're experiencing with GodotSteam.

I think my problem is then in iterating an array (Godot.Collections.Array) of SteamIds returned from godotateam. I tried to use array.OfType() (which obviously doesn't work). But why slice to a 32-bit integer when in a dynamically typed context?

Yes, in a dynamically typed context it should be fixed to return long instead.

I created a very small starting pull request #39629, please let me know if/how you want me to proceed, I drafted it for now.

Fixed by #39629.

Pretty sure this is still broken:
In Godot 3.4.4
C# in debugger:

output:

GDScript:

AH yes. https://github.com/godotengine/godot/blob/3.4/modules/mono/mono_gd/gd_mono_marshal.cpp#L576-L579


VSTS work item with non-VSTS Git

The group I am working with would really like to track work items in VSTS. However, due to technical reasons (https://visualstudio.uservoice.com/forums/330519-team-services/suggestions/3895135-add-server-side-git-hooks), they cannot use VSTS Git. Is there a way to implement VSTS work items with a non-VSTS Git server? If not, could this be implemented?
Thanks!

Hi @msurato,
I'm sorry to say but currently the work item feature only works with repositories that are VSTS. I'm going to add this request to our feature backlog and leave this issue open as an enhancement to track the work.
Thanks for the input,
-Leah


FIX-#5714: BUG: Empty frames concatenation with inner join is not valid

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #5714
[x] tests added and passing
[ ] module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko thanks for the separate PR!


[bug] fix ps_hosts empty check in set_tf_config

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Documentation:  Enhancement to ADTTE vignette for complex parameters

Please select a category the issue is focused on?
Documentation
Let us know where something needs a refresh or put your idea here!
We've had feedback from Roche users that the ADTTE vignette does not cover enough examples for complex censoring rules, in particular that derive_param_tte() is not sufficient for some of their derivations. If working at Roche, see here, where eventually some discussion led to the proposal to use derive_extreme_event() in conjunction with various event() objects.
@bundfussr Could the ADTTE vignette could be enhanced to point users in this direction if they have similar use cases? Maybe make a new "Advanced" section mentioning that this is a possibility, with an example to showcase?
I'm not an expert in the TA so leave to you to figure out the details of what and how to showcase.

I think this is not an oncology-specific issue.
In most cases time-to-event analyses are done for negative events like death, progression, AE... The derive_param_tte() function and the vignettes were designed for such cases. However, the team which started the discussion wanted to derive a TTE endpoint for a positive event (time to first response). In this case the censoring rules are slightly different. I would suggest to update the TTE vignette in admiral and enhance derive_param_tte() if necessary.
@manciniedoardo , what do you think?

@bundfussr thanks for your response. Given your expertise and suggestions, how about the following:

Update TTE vignette in admiral package as described above (ie. referencing possible uses of derive_extreme_event() for positive events)
Link to that in TTE vignette in admiralonco (just a small section saying something along the lines of "If you find yourself needing to derive an endpoint for a positive event, eg. time to first response, check out the following example here)
No updates to derive_param_tte()

I agree to update the TTE vignettes. However, I'm not sure if we should use derive_extreme_event() or enhance derive_param_tte(). I think this should depend on what is easier to use and read.
There is also another use case which is not covered by the vignettes. Setting EVNTDESC for censoring is sometimes tricky. For example if you are deriving time to CHG >= 10 and want to distinguish subjects censored because they don't have a baseline value and subject censored because they don't have post-baseline values. I think we should add something for this use case as well.
I would consider both use cases first and try out how they could be solved with existing functions or how they could be solved with enhanced functions. And then we could decide which way we want to go.
@manciniedoardo , does that make sense?


Feat(notifications in side bar) props are added to the sidebar item to be able to personalize the badge

Task

https://dd360.atlassian.net/jira/software/c/projects/CD/boards/12?modal=detail&selectedIssue=CD-1357&assignee=6397d19e7145571a7ea7e0de

Affected sections

src/components/SideBar/SideBarBadge.tsx
src/components/SideBar/SideBarItem.tsx
src/stories/SideBar.stories.tsx

How did you test this change?

Did you test this changes with the codesandbox compilation? @JuanDominguez1


Notifications of internal module "sysrepo" cannot be subscribed to

Hi,
I'm using version 2.2.31, By subscribing to the netopper2-cli for all notifications, the following error occurs, which was not present in previous versions.
netopper2-cli log:
 subscribe --filter-xpath /*
ERROR
        type:     application
        tag:      operation-failed
        severity: error
        message:  Notifications of internal module "sysrepo" cannot be subscribed to.

        type:     application
        tag:      operation-failed
        severity: error
        message:  User callback failed.

netopper2-server log:
[2024-10-25 08:18:54.626] [DBG]: LN: Session 21: Received message:
<rpc xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="51"><create-subscription xmlns="urn:ietf:params:xml:ns:netconf:notification:1.0"><filter type="xpath" select="/*"/></create-subscription></rpc>

[2024-10-25 08:18:54.631] [ERR]: SR: Notifications of internal module "sysrepo" cannot be subscribed to.
[2024-10-25 08:18:54.631] [WRN]: SR: EV ORIGIN: "/notifications:create-subscription" "rpc" ID 23 priority 0 failed (Operation not supported).
[2024-10-25 08:18:54.631] [ERR]: SR: User callback failed.
[2024-10-25 08:18:54.631] [ERR]: NP: Failed to send an RPC (User callback failed).
[2024-10-25 08:18:54.631] [DBG]: LN: Session 21: Sending message:

#537

[2024-10-25 08:18:54.631] [DBG]: LN: Session 21: Sending message:
<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="51"><rpc-error><error-type>application</error-type><error-tag>operation-failed</error-tag><error-severity>error</error-severity><error-message xml:lang="en">Notifications of internal module "sysrepo" cannot be subscribed to.</error-message></rpc-error><rpc-error><error-type>application</error-type><error-tag>operation-failed</error-tag><error-severity>error</error-severity><error-message xml:lang="en">User callback failed.</error-message></rpc-error></rpc-reply>

[2024-10-25 08:18:54.631] [DBG]: LN: Session 21: Sending message:

##

[2024-10-25 08:18:54.632] [INF]: NP: Session 21: thread 1 event new RPC.
[2024-10-25 08:18:54.632] [INF]: NP: Session 21: thread 1 event reply error.

Fine, should be fixed in the latest sysrepo. But the filter is completely redundant and would only involve additional processing. Do not use any filter if you want to subscribe to all the notifications.

Fine, should be fixed in the latest sysrepo. But the filter is completely redundant and would only involve additional processing. Do not use any filter if you want to subscribe to all the notifications.

I see, thanks


Unstable Islands only work with double quote imports

Single quote imports are missed by the compilation. While this isn't the final API. Definitely unexpected trap.

https://github.com/solidjs/solid-start/pull/499

this issue can be closed


Not compatible with php 7 anymore

From versions 2.7 and 3.0 (which point both to the same commit) this package is not compatible with PHP version 7 anymore. Because of the use of ReflectionProperty::hasDefaultValue() here.
The PHP documentation points out that the function is available from PHP version 8:
https://www.php.net/manual/en/reflectionproperty.hasdefaultvalue.php
Perhaps it is a good idea to:

remove version 2.7 in this package (2.6 is compatible with PHP 7);
add a constraint in composer.json of "php": ">=8.0" for version 3.0 of this package;

I have a legit question....
The project has over 97% unit test code coverage, including this line in question and I test it via PHP 7.4 through 8.3 (see test.sh).
I wonder why it isn't blowing up in the unit tests???

OK I figured it out...
The Travis CI alternative (test.sh) was created on 2023-07-20, at which point, I myself encountered this bug.
It was fixed in b0a30b7c (Theodore R. Smith at 2023-07-21 04:58:04 CDT.

Fixed in Version 3.5.0.


With storage sync enabled, you cannot delete photos

Probably a backend issue

Fixed, managed to uncover multiple other issues while trying to debug this.


fix: require function undefined access

cache isn't always defined so cached = cache[this.filePath] breaks the require function. This adds a check to fix it.

Seems to have been fixed in later releases


Support for React 19

React 19 has been released and Ladle does not seem to be compatible yet.
When trying to update, react-inspector is incompatible according to npm. There is an issue for this: https://github.com/storybookjs/react-inspector/issues/185.

Will add the support by the end of year with some other major changes (Vite v6).

implemented in https://github.com/tajo/ladle/pull/591

The lack of support for React 19 in react-inspector still creates a dependency conflict with Ladle 5.0.0:
> npm install
npm warn ERESOLVE overriding peer dependency
npm warn While resolving<EMAIL_ADDRESS>npm warn Found<EMAIL_ADDRESS>npm warn node_modules/react
npm warn<EMAIL_ADDRESS>from the root project
npm warn   6 more (@ladle/react, @ladle/react-context, @mdx-js/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer<EMAIL_ADDRESS>|| ^17.0.0 || ^18.0.0" from<EMAIL_ADDRESS>npm warn node_modules/@ladle/react/node_modules/react-inspector
npm warn<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm warn   node_modules/@ladle/react
npm warn
npm warn Conflicting peer dependency<EMAIL_ADDRESS>npm warn node_modules/react
npm warn   peer<EMAIL_ADDRESS>|| ^17.0.0 || ^18.0.0" from<EMAIL_ADDRESS>npm warn   node_modules/@ladle/react/node_modules/react-inspector
npm warn<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm warn     node_modules/@ladle/react

This is from a simple test project with the following dependencies:
  "dependencies": {
    "@ladle/react": "^5.0.0",
    "react": "^19.0.0",
    "react-dom": "^19.0.0"
  }


fix example to actually work

Upper vs Lower casing and missing error handling

the big change is due to you not using go fmt

@Hades32 Thank you for contributing


Create a demo notebook to replace script for random walk link prediction

Description
The demo script for random walk link prediction was restored for #895 as it does significantly more than the Jupyter demo notebook.   As part of our plan to replace scripts with notebooks, we should remove demos/link-prediction/random-walks/main.py and replace it with a suitable demo (eg heterogenous with BlogCatalog3 dataset?)
Done Checklist

[ ] Produced code for required functionality
[ ] Tests written and coverage checked
[ ] Code review performed
[ ] Documentation on Google Docs  (if applicable)
[ ] Documentation in repo
[ ] Version number reflects new status
[ ] CHANGELOG.md updated
[ ] Team demo

Hmm actually this is currently a bit difficult to do due to https://github.com/stellargraph/stellargraph/issues/907 - that site's been down for a while now, probably need to just rewrite the demo with a different dataset?

I think we should probably just upload that dataset to figshare?

Seems like my laptop can't handle the current metapath2vec demo with blog catalog - I've reduced some of the random walk parameters to:
num_walks = 1  # previously 10
walk_length = 20  # previously 80

but the graph is large enough that the random walks have been running for a few hours without any visible progress, will try reduce the parameters further..

I think it might be too much of a rush to try get this in with https://github.com/stellargraph/stellargraph/pull/1399 and https://github.com/stellargraph/stellargraph/pull/1392 so I'm thinking we could just remove the utils directory for 1.0: https://github.com/stellargraph/stellargraph/pull/1462
Seems unlikely that the script is being run or is able to be run, and it would clean up our demos for the release. Unsupervised Metapath2Vec is being demo'd via demos/embeddings/stellargraph-metapath2vec.ipynb which does hint at the bottom of the notebook:
## Downstream Tasks

The node embeddings calculated using Metapath2Vec can be used as feature vectors in a downstream task such as node attribute inference (e.g., inferring the gender or age attribute of 'user' nodes), community detection (e.g., clustering of 'user' nodes based on the similarity of their embedding vectors), and link prediction (e.g., prediction of friendship relation between 'user' nodes).

So that's probably more helpful than the existing scripts


chore: use debug to show phase of nereids (#27903)

(cherry picked from commit 72b2a336e973df45ed3a180d1970fd7aa4072424)
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[GA Skills SDK][Skill] Changes to get the Skill working

Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[ ] I have updated related documentation

Are the .lg files necessaries? Are them part of 0.8 or 0.7?

Are the .lg files necessaries? Are them part of 0.8 or 0.7?

Without this changes, the skill/sample wouldn't work as FirstPromptText and FirstPromptMessage are consumed inside the skill/sample.
The change seems to have been introduced on January.

LGTM, I will merge this PR :)


[BUG] - when npm install, it throws version driven error

Checks

[X] I have searched the existing issues for a similar bug and it does not exist!

Environment

Operating System: Darwin
Node Version:     v21.6.1
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Quasar version
v2.4.0
Browsers
Google Chrome
Description
when clone repo and run 'npm install'
Error occured.
below is detail of error
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vitest
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>|| ^1.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@nuxt/test-utils
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I've solved this issue with 'npm install --legacy-peer-deps'.
So, if you have same issue and it works, please correct your README.md
thank you.
Reproduction steps
1. clone repository
2. npm install
3. see error

Screenshots
No response
Logs
No response

If you want to contribute, you should be using pnpm as a package manager.


About the nameless render function

Hello @zachleat
(this project is really interesting BTW :heart_eyes:)
I was trying to use the render function example but I encountered something odd.
This works:
<script webc:type="render" webc:is="template">
function() {
  return `Hello ${this.name}`;
}
</script>

but this does not:
<script webc:type="render" webc:is="template">
function () {
  return `Hello ${this.name}`;
}
</script>

The difference: my IDE's formatter introduced a space between the function and parens and I got this error:
src/index.html:2
function () {
^^^^^^^^

SyntaxError: Function statements require a function name
at Object.compileFunction (node:vm:360:18)
at wrapSafe (node:internal/modules/cjs/loader:1049:15)
at Module._compile (node:internal/modules/cjs/loader:1084:27)
at ModuleScript.getModule (..../test-webc/node_modules/@11ty/webc/src/moduleScript.js:18:5)
at Object.render (..../test-webc/node_modules/@11ty/webc/src/ast.js:40:26)
at AstSerializer.transformContent (..../test-webc/node_modules/@11ty/webc/src/ast.js:498:41)
at AstSerializer.compileNode (..../test-webc/node_modules/@11ty/webc/src/ast.js:604:43)
at AstSerializer.getChildContent (..../test-webc/node_modules/@11ty/webc/src/ast.js:397:40)
at AstSerializer.compileNode (..../test-webc/node_modules/@11ty/webc/src/ast.js:678:46)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

In any JavaScript runtime, a function declaration without a name is an error. I think users will want to use their own tooling (formatters, linters...) on the <script> tags inside WebC files, having something really standard would be better IMO.
I looked at the source of https://github.com/11ty/webc/blob/main/src/moduleScript.js and I now understand how it works. You're using Node.js module module as a parser/runner and you add a module.exports =  prefix if necessary to make it work. Clever :wink: Being a value assigned to module.exports, the anonymous function is no longer an error.
I did a bit of digging;

The module._compile function doesn't seem to be documented, won't this be a problem in the future?
I tried to write export default function () { /* ... */ } but it seems like it doesn't work with ESM :cry:
I wonder if the vm module would be a better fit for this

(edit) I tried vm.Script, it's basic but it could work even without declaring a function.
(edit) I tried vm.Module to rely on an ESM default export but it's experimental and not that easy to work with.

Even if you stick with module, I think a small adjustment to the matching of function( or async function(` would be a good improvement, especially if the docs requires a name.
WDYT?

I just tried a very dumb and forgiving regex:
const FUNCTION_REGEX = /^(?:async )?function.*\(/;

and replaced the matching with this:
if(!trimmed.startsWith("module.exports = ")) {
  if(trimmed.match(FUNCTION_REGEX) != null) {
    content = `module.exports = ${content}`;
  }
}

It works pretty well.

Well I closed this one way too fast! Yeah I really like the idea. I wonder if acorn might be worthwhile here, I’ve had good luck with that! I’d definitely merge a simple regex PR fix for now though—we can look at acorn later!

Shipping with 0.2.0!

Awesome! 🎉


Update to use setup.cfg

Update to use setup.cfg

If we're removing wasabi.about, then possibly the next version should be 1.0.0.

And if we're going to mark this as typed then the next version should 1.1.0 so it doesn't cause mypy errors with existing versions of: spacy and thinc, and this additionally requires updated releases of spacy-loggers, spacy-huggingface-hub, and sense2vec (at my current count, at least) so that they don't have conflicting requirements with spacy and thinc.

I'm not intending a v1.0.0 release, just going ahead and making the minimal version increase here that makes sense alongside the changes in this PR.


Installation issue

Hi, I do have problems installing the plugin:

I cannot find it under community plugins (restricted mode is off).
Downloading it and enabling it leads to error: "Failed to load plugin"

Any idea how to resolve these issues?
Thanks

it is not yet published unfortunately I am waiting for somebody from Obsidian to approve it.
I could not reproduce it, can you tell me some more details? Maybe if you could reach into developer tools and tell me what is the error, maybe... Also how did you install it? Using BRAT or manually?

Thank you

ok
I downloaded the code from github and put in into the plugins folder. It seems that main.js and perhaps other files are missing

app.js:1
Plugin failure: sets Error: ENOENT: no such file or directory, open '~.obsidian\plugins\obsidian-sets\main.js'

I see. I guess you have to download the code from the releases. There you find main.js, style.css and manifest.json

Installing with BRAT worked. Thanks, very useful plugin!

Thank you for trying this!


Wrong config paths

Hello @micahgodbolt micahgodbolt,
I can not create specific ways of screenshots or results. For all paths is based on the way the 'src'.
Is this right?
When an image is not equal and there is failure, the screenshot folder is recreated at the root ...
Tks

+1

hey @EmilioAiolfi can you post in your grunt config info? Also, remember that the results are going to be created in the same folder as your test code.


[test:unit] App Dashboard Calc

treasury balance
APY

Hi, I'd like to tackle this issue.
Current state of dashboard tests:

Check if TreasuryDashboard view matches the jest snapshot.

My assumption: the goal of this issue is to add to dashboard tests for the TreasuryDashboard view.
What is desired here?

Test each component in Metrics.tsx: MarketCap, OhmPrice, etc ?
Test each component in Graph.js: TotalValueDepositedGraph, MarketValueGraph, etc ?

These are all small wrappers around components in the @olympusdao/component-library.
Should these be unit tested if they render the data received via useProtocolMetrics and useTreasuryMetrics respectively?
I'm confused because treasury balance and APY are not on this page.
APY is visible on stake page and Market Value of Treasury Assets is equal to raw value treasuryMarketValue fetched via graphql in protocolMetrics.
Thanks for any input to clarify this 😊

Hi, I'd like to tackle this issue.
Current state of dashboard tests:

Check if TreasuryDashboard view matches the jest snapshot.

My assumption: the goal of this issue is to add to dashboard tests for the TreasuryDashboard view. What is desired here?

Test each component in Metrics.tsx: MarketCap, OhmPrice, etc ?
Test each component in Graph.js: TotalValueDepositedGraph, MarketValueGraph, etc ?

These are all small wrappers around components in the @olympusdao/component-library. Should these be unit tested if they render the data received via useProtocolMetrics and useTreasuryMetrics respectively?
I'm confused because treasury balance and APY are not on this page. APY is visible on stake page and Market Value of Treasury Assets is equal to raw value treasuryMarketValue fetched via graphql in protocolMetrics.
Thanks for any input to clarify this 😊

Thank you for looking into this issue. It was originally open in October and a lot has changed since.
The main goal that still remains valid is to cover the various execution paths for dashboard rendering. Possibly through a combination of snapshot and generative tests that feed components with various mock data and verify that results are acceptable.
As we discussed on the call this morning, you have full autonomy to design tests in a way that makes most sense.

closing since this is stale & this feature has completly changed


SWIG Python compilation with CMake >= 3.13

🦟 Bug fix
Summary

The problem described in https://github.com/ignitionrobotics/ign-math/pull/216#issuecomment-900584411 turns out to be because of my CMake version, which is 3.21.1.
See UseSWIG as reference.
Version combinations that I'm trying to satisfy:

System
SWIG version
CMake version
Python version

Actions Bionic
3.0.12
3.10.2
3.6.9

chapulina's Bionic
3.0.12
3.21.1
3.6.9

Actions Focal
4.0.1
3.16.3
3.8.10

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Bionic CI is failing. I am checking this out locally right now

Thanks for the fix, @francocipollone !


chore(ConnectableObservable): remove unused code

Description:
there is no need for the assignment
Related issue (if exists):

Pull Request Test Coverage Report for Build 8109

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0006%) to 96.805%

Totals

Change from base Build 8098:
-0.0006%

Covered Lines:
5241

Relevant Lines:
5414

💛  - Coveralls

Thank you @githubxiaowen!


fix: pass tenantID correctly to acr generator

This PR fixes a bug where the ACR credentials couldn't get generated properly.
It also adds a example on how to create a proper .dockerconfigjson secret.
Fixes #2007

/approve


Unique Validation Rule Silent Failure

I've been having some difficulty getting the  unique:[table],[column],[id],[$id] validation rule to work.
Service Providers are listed and DB table migrations have been run.
Its executed in a UserContoller.store against an empty postgres table where phone_number is set as  a unique index. Validation fails but returns no messages for the unique rule, removing the rule allows the insert but naturally throws a DB error on subsequent inserts with the same column value.
I'm using it as follow
class User extends Lucid {

	static get table () {
		return 'st_users';
	}

	...

	static rules ( id ) {
		return {
			'firstname': [ 'required', 'string', 'max:255' ],
			'lastname': [ 'required', 'string', 'max:255' ],
			'organization': [ 'string', 'min:3', 'max:255' ],
			'phone_number': [ 'required', 'regex:^(\\+27|0)[0-9]{9}$', `unique:st_users,phone_number,id,${id}` ]
		};
	}

	...

}

logging the output of
adonis-validation-provider/providers/ValidatorProvider.js

https://github.com/adonisjs/adonis-validation-provider/blob/develop/providers/ValidatorProvider.js#L25
at line 25
} catch (e) {console.error(e)}

Returns this
Error: Cannot find module 'config/app.js'

on startup.
I'm unsure if this is a factor, perhaps the missing module means the DB service cannot load the correct parameters?

This

After narrowing it down further the app was reporting unique as an unregistered validator.
It seems the issue was brought about by trying to register a custom Validator through a ServiceProvider.boot method rather than Http.onStart event, although I'm uncertain why.


Feature: Add dimensions tracking

What

Adds support for tracking dimensions (Matomo documentation on Custom Dimensions: https://matomo.org/faq/reporting-tools/create-track-and-manage-custom-dimensions/)
As mentioned in https://github.com/Floating-Dartists/matomo-tracker/issues/16, example use cases would be tracking of App Version or tracking of App Content Language.

Implementation considerations

Basically the dimensions are key value pairs, so in the proposed implementation just adding them to the query params.
There are two ways to add the dimensions, either when an event is tracked (and dimensions is an optional argument) via the updated trackEvent, or via a new function trackDimensions

Documentation

Info on setting up custom dimensions on Matomo can be found here: https://matomo.org/faq/reporting-tools/create-track-and-manage-custom-dimensions/ and on the dimensions arguments in the API here: https://developer.matomo.org/api-reference/tracking-api
Updated also the README file with usage examples

Everything seems good to me, thank you for your contribution @petcupaula


No Error, Shutting Down

Upon first run with new coin installation:
Using configuration file 'config.json'

[2023-02-17 05:20:07.4949] [I] [Core] Version <IP_ADDRESS>-master [a553f62301f44c6df80891e408b6526d1dd98692]
[2023-02-17 05:20:07.5099] [I] [Core] Runtime .NET 6.0.14 on Linux 5.4.0-139-generic #156-Ubuntu SMP Fri Jan 20 17:27:18 UTC 2023 [X64]
[2023-02-17 05:20:07.5169] [I] [Core] Prometheus Metrics API listening on http://<IP_ADDRESS>:4000/metrics
[2023-02-17 05:20:07.5169] [I] [Core] WebSocket Events streaming on ws://<IP_ADDRESS>:4000/notifications
[2023-02-17 05:20:08.4985] [I] [XmlKeyManager] User profile is available. Using '/home/miningcore/.aspnet/DataProtection-Keys' as key repository; keys will not be encrypted at rest.
[2023-02-17 05:20:08.5204] [I] [ShareRecorder] Online
[2023-02-17 05:20:08.5710] [I] [PayoutManager] Online
[2023-02-17 05:20:08.5728] [I] [StatsRecorder] Online
[2023-02-17 05:20:08.5965] [I] [Lifetime] Application is shutting down...

No reason, any help?

did you managed to fix ?

This is probably a config file issue ,, happened to me and solved after config were updated


Chunks not marked correctly

Describe the bug
Chunks around the player aren't being marked correctly in the ChunkDebug window. I first noticed this in 1.18.X and now can give you details from 1.19.2. (I know it's not super useful just saying "I saw it in 18" but unless you think it'll be really helpful to get 18 information in addition to what I have from 19 you just get anecdotal evidence)
General Info
Mod Version: Carpet 1.4.83, EssentialClient 1.3.0, ChunkDebug 1.0.4
Minecraft Version: 1.19.2 Server
List of other mods: advancementinfo, amecs, antighost, betterdarkmode, betterF3, borderlessmining, cleardespawn, clientcommands, cmdkeybind, continuity, fabricapi, carpet, indium, iris, itemscroller, lazydfu, litematica, malilib, minihud, modmenu, sodium, starlight, tweakermore, tweakeroo, xaerosminimap, xaerosworldmap. (All latest versions)
To Reproduce
Steps to reproduce the behavior:

Install latest carpet, essentialclient, chunkdebug
Create a world
Move away from spawn so that the player-loaded area doesn't overlap with spawn chunks.
See that the border chunks are correct, but every other player-loaded chunk is marked as lazy. https://i.imgur.com/sf9EnKw.png

Expected behavior
Player-loaded chunks should be marked as green, not yellow (lazy). This worked in 1.17 but I don't think it worked in 18 and definitely isn't working in 19.
Crash Report / Lastest Log
Upload your crash report or latest log to help us figure out what's going on.
Screenshots / Videos
https://i.imgur.com/sf9EnKw.png
Additional info
I'm engin33rguy#2407 on discord if it's easier to communicate there, or on the Mechanists discord too. (That's where we first noticed it, but now it's showing up in my SMP too.)

Try this version
You'll need to download the artifacts and extract them from here.
I also changed some stuff in EC, you can use older versions just player loaded chunks will force chunks to be green thus it looks like the lazy chunks are entity ticking, find that here

Thanks for this- I won't be able to update the server until later this afternoon but I wanted to say I appreciate the quick response. I'll let you know what happens when we upgrade later tonight.

Server failed to launch, here's the log:
[19:02:50] [main/INFO]: Loading Minecraft 1.19.2 with Fabric Loader 0.14.9 [19:02:50] [main/WARN]: Mod resolution failed [19:02:50] [main/INFO]: Immediate reason: [HARD_DEP_INCOMPATIBLE_PRESELECTED chunkdebug 1.0.5 {depends minecraft @ [1.16.x]}, ROOT_FORCELOAD_SINGLE chunkdebug 1.0.5] [19:02:50] [main/INFO]: Reason: [HARD_DEP chunkdebug 1.0.5 {depends minecraft @ [1.16.x]}] [19:02:50] [main/INFO]: SERVER environment disabled: [fabric-renderer-api-v1, fabric-keybindings-v0, sodium, fabric-renderer-registries-v1, fabric-textures-v0, fabric-models-v0, fabric-client-tags-api-v1, fabric-screen-api-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-key-binding-api-v1, fabric-renderer-indigo, fabric-blockrenderlayer-v1] [19:02:50] [main/INFO]: Fix: add [], remove [], replace [[chunkdebug 1.0.5] -> add:chunkdebug 1 ([(-∞,∞)])] [19:02:50] [main/ERROR]: Incompatible mod set! net.fabricmc.loader.impl.FormattedException: Mod resolution encountered an incompatible mod set! A potential solution has been determined:      - Replace mod 'Chunk Debug' (chunkdebug) 1.0.5 with any version that is compatible with:          - minecraft 1.19.2 Unmet dependency listing:      - Mod 'Chunk Debug' (chunkdebug) 1.0.5 requires any 1.16.x version of 'Minecraft' (minecraft), but only the wrong version is present: 1.19.2!     at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:190) ~[fabric-loader-0.14.9.jar:?]     at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148) ~[fabric-loader-0.14.9.jar:?]     at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) [fabric-loader-0.14.9.jar:?]     at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.14.9.jar:?]     at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [fabric-loader-0.14.9.jar:?]

Oops! Should be fixed now, try the new build https://github.com/senseiwells/ChunkDebug/actions/runs/3033687004

Works perfectly now as far as I can tell, thanks a lot!


Unusual project setup breaks language services in Ionide and VS for Mac

Description
@fergusmeiklejohn asked on Gitter why the language services don't work properly when following the instructions in the README to add a new page. I noticed the unusual project setup, which looks something like this:
src/Client/Client.fsproj
  Imports src/Shared/Shared.props
    Imports src/Shared/Client.props
      Includes all F# files in src/Client/

I guess this is done to include the client files in the server for SSR. But this setup breaks language services in Ionide on Windows and in VS for Mac, as reported by @fergusmeiklejohn.
Repro steps
Clone this repository and follow the instructions  in the README using VS Code and Ionide. Add the new file to Client.props.
Expected behavior
The new F# file is picked up by the language services and IntelliSense works.
Actual behavior
IntelliSense doesn't work in the new file, and it doesn't show up in the solution explorer. You have to close and reopen your IDE.
Known workarounds
Add the new file to Client.fsproj instead of Client.props.
Related information

Operating system: Windows, macOS
Branch: master

//cc @Krzysztof-Cieslak


Update nettruyendomain

Checklist:

[x] Updated source's version for individual source changes
[ ] Updated all sources' versions for template changes
[ ] Set appropriate nsfw value
[ ] Did not change id even if a source's name or language were changed
[ ] Tested the modifications by running it on the simulator or a test device

you should combine #553 with this into one PR.


[Feature Request]Collecting Custom Attributes

I'd like to have VM Custom Attributes collected as labels. So I can display in Grafana only VMs that have Custom Attributes job="web".
Any chance this can be implemented?

That would indeed be very helpful, also VMware tags converted as prometheus labels

Closing due to inactivity.


test-branch/execute-job/quoted-authorization/8718d97b-d96c-44a9-bd50-70881c42ee10

PR for testing 8bf5f59116fcb4c9cbd2897841c74d0c339a9394

/canonical/self-hosted-runners/run-workflows 8bf5f59116fcb4c9cbd2897841c74d0c339a9394


RetrievalNormalizedDCG doesn't change with different top_k values

🐛 Bug
I'm trying to use the interface RetrievalNormalizedDCG  however it seems that the computed value doesn't change with different top_k  parameter values.
To Reproduce
Just initialize a python terminal with the following code:
from torch import tensor
from torchmetrics.retrieval import RetrievalNormalizedDCG
indexes = tensor([0, 0, 0, 1, 1, 1, 1])
preds = tensor([0.2, 0.3, 0.5, 0.1, 0.3, 0.5, 0.2])
target = tensor([False, False, True, False, True, False, True])
ndcg = RetrievalNormalizedDCG()
ndcg(preds, target, indexes=indexes)

Output: tensor(0.8467)
Now, just modify the ndcg instance for top_k = 5:
ndcg = RetrievalNormalizedDCG(top_k=5)
ndcg(preds, target, indexes=indexes)

Output: tensor(0.8467)
Nexty, just modify the ndcg instance for top_k = 10:
ndcg = RetrievalNormalizedDCG(top_k=10)
ndcg(preds, target, indexes=indexes)

Output: tensor(0.8467)
Expected behavior
The expected behavior would be different scores for different values of top_k.
Environment

TorchMetrics version (and how you installed TM, e.g. conda, pip, build from source):

Name: torchmetrics
Version: 1.2.1
Summary: PyTorch native Metrics
Home-page: https://github.com/Lightning-AI/torchmetrics
Author: Lightning-AI et al.
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Requires: lightning-utilities, numpy, packaging, torch
Required-by: lightning, pytorch-lightning

Python & PyTorch Version (e.g., 1.0):

Python 3.10.13
Pytorch 2.2.0.dev20231211

Any other relevant information such as OS (e.g., Linux):

ProductName:            macOS
ProductVersion:         14.2.1

Just noticed it was because of the number of samples 😅
The following example should solve
preds = tensor([0.2, 0.3, 0.5, 0.1, 0.3, 0.5, 0.2, 0.1, 0.2, 0.5, 0.1, 0.3, 0.5, 0.1])
indexes = tensor([0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1])
target = tensor([False, False, True, False, True, False, True, False, True, True, True, False, True, True])

Default top_k
ndcg = RetrievalNormalizedDCG()
print(f'top_k=default: {ndcg(preds, target, indexes=indexes)}')

output:
top_k=default: 0.903104305267334
top_k = 5
ndcg = RetrievalNormalizedDCG(top_k=5)
print(f'top_k=5: {ndcg(preds, target, indexes=indexes)}')

output:
top_k=5: 0.7864415645599365
top_k = 10
ndcg = RetrievalNormalizedDCG(top_k=10)
print(f'top_k=10: {ndcg(preds, target, indexes=indexes)}')

output:
top_k=10: 0.903104305267334


Finding good flags for the 'hipcc' compiler

What parameters should I pass to 'hipcc' so that it will most likely result in the fastest possible device code being generated?
For instance, with 'nvcc' (NVIDIA's compiler) I use '--use-fast-math' wich sets '--prec-div=false' and '--prec-sqrt=false', so that the resulting compiled device code is faster as the cost of precision.
Does the 'hipcc' '-ffast-math' accomplish the same thing?

We added support for it
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/blob/developer-preview/include/hip/hcc_detail/hip_runtime.h#L519
Instead of --use-fast-math, you can try -DHIP_FAST_MATH. Using CUDA fast math flag for compilation will be added soon.


fix: add retry for init LTTng

Description
Issue to be fixed

caret_record_init may return error (False), but error is not handled by the caller
The error happens when lttng-sessiond --daemonize fails in here

Specific error case

There are two processes who tries to run lttng-sessiond --daemonize when it's not launched

~/ros2_caret_ws/setenv_caret.bash
ros2 caret record

If a user run the both commands at the same time, lttng-sessiond --daemonize by ros2 caret record fails and tracing doesn't start (although the process continues)
Log

Error: No session daemon is available
UST tracing enabled (16 events)
kernel tracing disabled
context (3 fields)
writing tracing session to: /home/autoware/.ros/tracing/session-20241119014758
Error: Could not get lock file `/home/autoware/.lttng/lttng-sessiond.lck`, another instance is running.
Error: A session daemon is already running.
error: failed to start lttng session daemon
press enter to stop...
std::input is not supported in this system. press ctrl-c to stop...

Related links
None
Notes for reviewers
I used the script like the following to cause the conflict, but it's still hard to reproduce the error. The error occurs only on a specific instance on the AWS
(. ~/work/project/caret/install/local_setup.bash && ros2 caret record --light --immediate -f 50000) &
. ~/work/project/caret/setenv_caret.bash

Pre-review checklist for the PR author

[x] I've confirmed the contribution guidelines.
[x] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR has been properly tested.
[ ] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ymski
Could you review this PR?  or please assign to the right person.

@iwatake2222
Thank you for the fix.
For pytest errors/warnings that are not directly related to this fix, you can ignore them this time.
I have made some comments on this PR.
Please check and fix them.

@ymski
Thank you for reviewing it.
I confirmed the new code works and the concern you pointed out was resolved.
Could you re-review this PR?

# before

~$ ros2 caret record --init-retry-num 0
Traceback (most recent call last):
  File "/opt/ros/humble/bin/ros2", line 33, in <module>
    sys.exit(load_entry_point('ros2cli==0.18.10', 'console_scripts', 'ros2')())
  File "/opt/ros/humble/lib/python3.10/site-packages/ros2cli/cli.py", line 91, in main
    rc = extension.main(parser=parser, args=args)
  File "/home/takeshiiwanari/work/project/caret/build/ros2caret/ros2caret/command/caret.py", line 32, in main
    return extension.main(args=args)
  File "/home/takeshiiwanari/work/project/caret/build/ros2caret/ros2caret/verb/record.py", line 236, in main
    if not init_result:
UnboundLocalError: local variable 'init_result' referenced before assignment

# after

~$ ros2 caret record --init-retry-num 0
Failed to init LTTng.


SAK-27978 Correctly generate mailing list IDs.

You need to included the context in the List-ID: header as the id is just the channel ID (e.g. main) which isn’t unique across the whole service.

Okay nice idea +1


Interval loop on long running routers can get stuck

Problem
Interval loop on long running routers can get stuck.
Noticed in Hashquark router logs, with stuck interval loops that query subgraphs, but sendStatusToSequencer functions as expected, leading us to believe the router is actually working.
Impact
Overall reliability of the network.
Proposed Solution
Acceptance Criteria
From an end user perspective, the below criteria must be met to consider this done:

[ ] Test the stop mechanism against a simulated stuck interval loops
[ ] Router recovers from the stuck loop and resumes iterations

@preethamr is this done?


bip157: Add NODE_COMPACT_FILTERS Service Flag

This adds a mandatory service flag to implement BIP157 as defined on the Bitcoin Core implementation:
https://github.com/bitcoin/bitcoin/blob/dd577bef3c4e1f227809a71ad43679b4548fbacf/src/protocol.h#L258

Codecov Report

Merging #368 into master will decrease coverage by 0.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
- Coverage   82.56%   81.92%   -0.64%
==========================================
  Files          39       39
  Lines        8236     7182    -1054
==========================================
- Hits         6800     5884     -916
+ Misses       1436     1298     -138

Impacted Files
Coverage Δ

src/network/constants.rs
85.15% <100%> (-2.01%)
:arrow_down:

src/util/key.rs
72.77% <0%> (-10.06%)
:arrow_down:

src/network/message.rs
61.6% <0%> (-8.09%)
:arrow_down:

src/util/psbt/raw.rs
80.85% <0%> (-3.88%)
:arrow_down:

src/util/misc.rs
95.08% <0%> (-2.57%)
:arrow_down:

src/util/bip32.rs
87.14% <0%> (-1.94%)
:arrow_down:

src/network/message_network.rs
25% <0%> (-1.77%)
:arrow_down:

src/blockdata/transaction.rs
93.89% <0%> (-1.47%)
:arrow_down:

src/blockdata/block.rs
70.67% <0%> (-0.85%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a643ac4...b40d946. Read the comment docs.


Log file splitting is not working

Gitea version (or commit ref): 1.11.4
Git version:
Operating system: CentOS 7
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Description
I've set the following options in the custom config file which should enable logging to multiple log files:
ROOT_PATH = /opt/gitea/log
MODE = file
REDIRECT_MACARON_LOG = true
MACARON = file
ROUTER_LOG_LEVEL = Info
ROUTER = file
ENABLE_ACCESS_LOG = true
ACCESS = file
LEVEL = Warn
STACKTRACE_LEVEL = None

But this will still result in empty log files for access, macaron and router:
total 624K
-rw-r-----. 1 gitea gitea    0 Feb 16 16:56 access.log
-rw-r-----. 1 gitea gitea 619K May  1 17:04 gitea.log
-rw-r-----. 1 gitea gitea    0 Feb 16 16:56 macaron.log
-rw-r-----. 1 gitea gitea    0 Feb 16 16:56 router.log

It's more like:
[log]
MODE             = console,file
MAX_DAYS         = 15
LEVEL = Info
ROUTER           = console,file
XORM = file, console
REDIRECT_MACARON_LOG = true

[log.file.xorm]
FILE_NAME = xorm.log

[log.console]
LEVEL = Fatal

[log.file]
LEVEL = Info

[log.file.router]
LEVEL = Info
FILE_NAME = router.log

[log.console.router]
LEVEL = Fatal

etc.

Hmm ok I'll give it a try but I'm still confused a bit. I found the log documentation https://docs.gitea.io/en-us/logging-configuration/ and it is talking about [log.sublogger] sections, so what's the right syntax?
Beside that, there should be some default for the sublogger configs like [file.router] right? So why do I need to set a log level for e.g. [log.file.router] to get it working? As you can see in my example, I've enabled the router log redirect and gitea creates already a router.log file in my log folder but it's empty. From my understanding it should just work with my provided config snippet.
If this is not enough then my question is, what option exactly is required to get a working standalone router log?

So why do I need to set a log level for e.g. [log.file.router] to get it working?

Sorry if that was not helpful, I just copied&pasted part of my own config and edited it a bit. Of course there are defaults, but I thought I could show you a sample of how is the log configuration structured.
TBH, I'm not an expert on the log configuration. It is a bit confusing because it's been revamped (as of 1.9.something I believe?) with a much more powerful syntax, but it was decided that the new code should support the old syntax too so... your settings happen to resemble the old syntax.

No thanks a lot for your help! :)
I just try to understand the details. Of course the new syntax looks very powerful but currently there are too many questios in my mind :)
I'll play a bit with the config and maybe we could improve the documentation.

@xoxys sorry it's taken me so long to reply.
The macaron, router and access loggers make their entries at INFO level - so setting LEVEL= Warn means that unless you override their specific log level to LEVEL=Info you won't get any.
So the simplest log settings to set what you want should be:
[log]
ROOT_PATH = /opt/gitea/log
MODE = file
REDIRECT_MACARON_LOG = true
MACARON = file
; ROUTER_LOG_LEVEL = Info ; this is the default anyway
ROUTER = file
ENABLE_ACCESS_LOG = true
ACCESS = file
LEVEL = Warn
;STACKTRACE_LEVEL = None ; this is the default anyway

[log.file.macaron]
LEVEL = Info

[log.file.router]
LEVEL = Info

[log.file.access]
LEVEL = Info

Now that's a little awkward and it would probably be nice to set the default logger separately.
So I'll put up a PR that allows us to set [log.file.default], separate from [log.file].

:facepalm: ouch... ok the log level was the missing part. Makes sense now :) Thanks a lot!

@xoxys sorry it's taken me so long to reply

No need to apologize for anything. All of you do an amazing job. Thanks for your work.

Closing as answered. 😄


Azure Security Center Continuous Export

Kindly incorporate capability to enable Azure Security Center's continuous export configurations and point them to supported diagnostic element - event hub, log analytics etc.

As part of revamp of ASC coverage, this one is for https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/security_center_automation

To support the type of Azure Resources to export the data to:

[ ] EventHub
[ ] LogAnalytics Workspace
[ ] LogicApp

An Issue raised at the provider's page : https://github.com/terraform-providers/terraform-provider-azurerm/issues/9975


Support Cairo as graphics backend

Is your feature request related to a problem? Please describe.
I cannot plot due to no X11 available:
unable to start device PNGwarning messages from top-level task callback 'vsc.plot'
Warning message:
In (function (filename = "Rplot%03d.png", width = 480, height = 480,  :
  unable to open connection to X11 display ''

Describe the solution you'd like
In RStudio, we can set the backend.

Is it possible to add such support in VSCode R plugin?

I recommend that you use the httpgd plot viewer.

@renkun-ken Thank you, Kun. I'll take a try.

It works.


Refactored instances of AddressBook to StudyBuddyPro in LogicManager/ModelManger/UserPref

@chanjunren implement the test case!


Search-Navigating to new search page app crashes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.72-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Email or phone of affected tester (no customers): Reproducible only in this accounts<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to https://staging.new.expensify.com/
Login with gmail account with many transactions (not a new account)
Tap profile -- troubleshoot
Navigate to new search page

Expected Result:
Navigating to new search page app must not crash.
Actual Result:
Navigating to new search page app crashes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/8a611ebb-99a4-4fed-93e8-c7298a1319b8
logs.txt

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #vip-vsb.

I'm not able to get the crash on iOS Safari or Android Native
Android Native v1.4.72-0
https://github.com/Expensify/App/assets/51066321/b9b45005-fcad-427f-aa57-14ecc5d44c8c
iOS Safari v1.4.72-0
https://github.com/Expensify/App/assets/51066321/eacb52e6-caad-43db-b8dd-bf6a63812c33

Same here. I can't reproduce on Android or mWeb.
As this is related to a new hidden feature this is not a blocker, so I'm removing the label.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

QA said they can reproduce with these emails:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Since we don't have access to those accounts and we are not getting the bug on any other available gmail accounts, I think we should add a Needs Reproduction & Retest weekly label so QA can check next week. I suspect this is related to our staging/outage from the past two days.
@Julesssss what do you think of this plan?

@Christinadobrzyn sounds good to me 👍

awesome, move to weekly - I'll watch the restests

Issue not reproducible during KI retests. (First week)

Issue is not reproducible.
https://github.com/Expensify/App/assets/43996225/761b9dc1-e955-44d4-8daa-d969c287d113

Issue not reproducible during KI retests. (Second week)

Awesome! Closing

QA team is able to reproduce the issue consistently on build <IP_ADDRESS>, @Christinadobrzyn Can you please review the issue again? Thank you
https://github.com/Expensify/App/assets/93399543/1c81da34-5b20-4ebf-87b2-8feda468896e

@kbecciv can you share the test account credentials?

From the latest video, seems like we have an invalid currency here. I wanna take a look at the data we're passing in to confirm where the issue is.

Issue not reproducible during KI retests. (Third week)

I'm also not able to reproduce this - @luacmartins can you test and let us know if this can be closed?

I'm not sure where we can locate the PW to these users, but happy to test these.
I'm not data on the new search page in my personal Gmail account, but I don't get a crash either.

RangeError: Malformed currency code

It seems like one of the transactions had a bad currency code stored in, which is being handled here and will be fixed in this PR.

Let's retest once that PR is merged

Issue not reproducible during KI retests. (Fourth week)

I think we are good to close this issue given that we haven't been able to reproduce this in four weeks and we have another issue that solves the currency crash. Thanks everyone!


bug: USB Icon for Temp deck overlaps with the slot to the left of it

Overview
The USB icon for the Temperature Module overlaps with the slot directly to the left of it, obscuring any labware in the slot. Perhaps this icon should be smaller and on the right.

Current behavior

Steps to reproduce

Upload a protocol with the Temperature module in slot 3 and labware in slot 2
Proceed to Labware Calibration
Observe Slot 2

Expected behavior
USB icon should not overlap with slot 2

Duplicate of #4422


Add node group link support

PTAL: @sohanmurthy
https://p-zmf7dq.b0.n0.cdn.getcloudapp.com/items/WnuJmG9Y/Screen Recording 2020-08-31 at 06.37.01 PM.mp4

🙌 🙌 🙌 🙌  This is awesome! LGTM 👍


Validator - Async rules

Is there any way to return my rules based on a promise? To be more specific I'm trying to return them based on the auth.getUser() result.
if i fix this with Promise.resolve() i get the result and when i return the rules in the then block the same doesn't apply.. and the get method inside clsase also doesn't accept async in the declaration.
  get rules () {
    return Promise.resolve(this.ctx.auth.getUser())
      .then(user => {
        return {
          email: `required|email|unique:clients,email,id,${user.id}`,
        }
      })
  }

If you place your validator after the Auth middleware, then you can access the user as auth.user, there is no need to call auth.getUser()
  get rules () {
    return {
      email: `required|email|unique:clients,email,id,${this.ctx.auth.user.id}`,
    }
  }

If you place your validator after the Auth middleware, then you can access the user as auth.user, there is no need to call auth.getUser()
  get rules () {
    return {
      email: `required|email|unique:clients,email,id,${this.ctx.auth.user.id}`,
    }
  }

Thank @thetutlage  you...it really works.


Updating typedoc check script

This changes slightly the script to check missing docs

It returns a sierialized object that holds all of the needed information to generate an error message
it returns an error code (1) if failed
it checks dev files, and allows checking only changed files (based on git's changed files)
It checks all of the packages in dev
it is possible to run a full check using --full
adding typedoc as dependency to be sure it is running correctly

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Reviewer - this PR has made changes to one or more package.json files.

Snapshot stored with reference name:
refs/pull/14702/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14702/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14702/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14702/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14702/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14702/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14702/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14702/merge#BCU1XR#0


dead project but anyway

File "C:\Users\alimi\auto-status\auto-status.py", line 11, in
config = json.loads(f.read())
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.3568.0_x64__qbz5n2kfra8p0\lib\json_init_.py", line 346, in loads
return _default_decoder.decode(s)
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.3568.0_x64__qbz5n2kfra8p0\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.9_3.9.3568.0_x64__qbz5n2kfra8p0\lib\json\decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 31 column 5 (char 787)

Apologies for the month late reply, it looks like an issue with your config, can you send your json config? (ommiting the discord token for obvious reasons)


temporarily remove shouldThrowOnError

Till all the client libraries support this option.
Once they do, we can add this option back in to the parent library as a non-breaking change

any news when this is back in ?


AddEventListener does not work for multiple events of the same name

If subscribing to an event using addEventListener in event.ts, this._eventListeners does not correctly concatenate if listening to multiple events with the same name. Therefore only the final listener will fire.
This is an issue if subscribing to the same event name multiple times in one script. We can see this by adding extra logging:
...
Add event listener, eventName= TradeEvent
...
Add event listener, eventName= OrderCompleteEvent
...
Add event listener, eventName= TradeEvent
this._eventListeners before: Map(2) { 'TradeEvent' => [ 0 ], 'OrderCompleteEvent' => [ 1 ] }
this._eventCallbacks before: Map(2) {
  0 => [ 'TradeEvent', [Function (anonymous)] ],
  1 => [ 'OrderCompleteEvent', [Function (anonymous)] ]
}
this._eventListeners after: Map(2) { 'TradeEvent' => [ 2 ], 'OrderCompleteEvent' => [ 1 ] }
this._eventCallbacks after: Map(3) {
  0 => [ 'TradeEvent', [Function (anonymous)] ],
  1 => [ 'OrderCompleteEvent', [Function (anonymous)] ],
  2 => [ 'TradeEvent', [Function (anonymous)] ]
}
...

this._eventListeners after adding should contain 'TradeEvent' => [ 0, 2 ], but instead is only 'TradeEvent' => [ 2 ]
I'm fixing this bug, but also wanted to open an issue to document it 😊

Looks like this got merged, congrats!


Tall images are now cropped in the timeline

Fixes issue #127 by cropping the image and adding an "expand" icon in the lower right.

Thanks Komposten! Closing #127


Fix wrong count of pods per node in grafana dashboard

How to categorize this PR?

/area monitoring
/kind bug
What this PR does / why we need it:
Previously kube_pod_info metric was used to calculate the count of pods per node, but we scrape only kube-system namespace for shoot because of this in the dashboard pods per node count was wrong as it used to show the count of pods which are in kube-system namespace only per node.
This PR uses kubelet_running_pods metrics which show nodes with pods count.
Which issue(s) this PR fixes:
Fixes https://github.com/gardener/gardener/issues/6892
Special notes for your reviewer:
/cc @istvanballok
Release note:

A bug causing grafana dashboard to show wrong count of pods per node is fixed.

/cc @ialidzhikov

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

/test pull-gardener-e2e-kind-ha-single-zone-upgrade

/assign

/retest-required


Toolchain: be more aggressive about adding extensions

This more aggressively adds the .exe extension to the tools on
Windows.  This allows a greater number of tools to be found on Windows
as the proper name is now used.

@swift-ci please test

If lookup is called with swift.exe will this look for swift.exe.exe? Or does executableName make sure not to do that?

If lookup is called with swift.exe will this look for swift.exe.exe? Or does executableName make sure not to do that?

Nope, it will look for swift.exe: https://github.com/apple/swift-driver/blob/main/Sources/SwiftDriver/Driver/WindowsExtensions.swift#L17-L20


A problem when combineing the weights

(nextgpt) admin1:~/nextgpt/src$ python -m fastchat.model.apply_delta --base llama_hf  --target ./vicuna_ckpt/7b_v0/  --delta vicunaLoading the delta weights from vicuna
You are using the default legacy behaviour of the <class 'transformers.models.llama.tokenization_llama.LlamaTokenizer'>. This is expected, and simply means that the legacy (previous) behavior will be used so nothing changes for you. If you want to use the new behaviour, set legacy=False. This should only be set if you understand what it means, and thouroughly read the reason why this was added as explained in https://github.com/huggingface/transformers/pull/24565
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:07<00:00,  3.90s/it]
Loading the base model from llama_hf
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:09<00:00,  4.91s/it]
Applying the delta
Applying delta:   0%|                                                                                | 0/291 [00:00<?, ?it/s]Traceback (most recent call last):
File "/public1/home/stu52275901023/anaconda3/envs/nextgpt/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/public1/home/stu52275901023/anaconda3/envs/nextgpt/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/public1/home/stu52275901023/anaconda3/envs/nextgpt/lib/python3.8/site-packages/fastchat/model/apply_delta.py", line 165, in
apply_delta(args.base_model_path, args.target_model_path, args.delta_path)
File "/public1/home/stu52275901023/anaconda3/envs/nextgpt/lib/python3.8/site-packages/fastchat/model/apply_delta.py", line 140, in apply_delta
param.data += delta.state_dict()[name]
RuntimeError: The size of tensor a (32000) must match the size of tensor b (32001) at non-singleton dimension 0

the vicuna's "vocab_size" is 32001?

@1920993165 I had a similar problem,maybe  you can just low your fastchat version with the command ' pip install fschat==0.1.10'

thx,i guess you are right.


ROX-11751: Implement SAC tests for ComponentCVEEdge and NodeComponentCVEEdge

Description
With the migration to postgres, both dackbox and scoped access control are being redesigned.
In order to ensure the provided functionality remains stable, some test are being added at datastore level for dackbox objects.
The change at hand focuses on the Component -> CVE edge of the dackbox graphs:
Cluster -> Namespace -> Deployment -> Image -> ImageComponent -> CVE
Cluster -> Node -> NodeComponent -> CVE
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
- [ ] Evaluated and added CHANGELOG entry if required
- [ ] Determined and documented upgrade steps
- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
This Change only adds tests. Code changes if any is required by the tests will come in a prefactor PR.

/test all

/test all

/test all

/retest


Unable to create sample app

Hi,
I am getting following error. Help me in resolving it. I'm new to flutter

myapp$ flutter run Building APK in debug mode (android-arm)...               Failed to run the Flutter compiler. Exit code: 1 /home/next/flutter/bin/cache/artifacts/engine/linux-x64/sky_snapshot: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: versionGLIBCXX_3.4.18' not found (required by /home/next/flutter/bin/cache/artifacts/engine/linux-x64/sky_snapshot)`

The version of glibc on your linux machine is too old to run flutter's host tools.  You might need to install a newer version.  See https://github.com/flutter/flutter/blob/master/.travis.yml#L4

I doubt this is very common, but if it is we could check for this with flutter doctor presumably?

/cc @devoncarew for flutter doctor connection.

http://www.linuxquestions.org/questions/linux-software-2/how-to-check-glibc-version-263103/
My favorite part of that is that on some systems libc.so is executable. O_o

I don't have /lib/libc.so.6 on my linux system, but it looks like we can compile and run that test app in ~45ms. So that might be a test we can reasonably do in doctor.

We can test sky_snapshot on Linux with something equivalent to this...
ldd -d bin/cache/artifacts/engine/linux-x64/sky_snapshot | grep 'not found'

Closing as dupe of #6207 (though technically this was opened first) fixed by #8798.


Optimize size of Option<PipeFd>

Shamelessly taken from
io-lifetimes::OwnedFd.
Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

Codecov Report

Merging #19 (aa6b0d9) into master (4ec5aa5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   80.70%   80.73%   +0.03%
==========================================
  Files           1        1
  Lines         596      597       +1
==========================================
+ Hits          481      482       +1
  Misses        115      115

Impacted Files
Coverage Δ

src/lib.rs
80.73% <ø> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec5aa5...aa6b0d9. Read the comment docs.

Thank you for everything.
I will fix the test failure by increasing the minimum version of tokio and trust in the future.

It has been released as v0.2.8.


Backend server mock

Proposed Changes

Update mock server with real sample data from API documentation
Created routes.json file and script in package.json to read from /manager/
Update components that didn't use exactly the real API

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests
[x] Build locally
[ ] Code format / lint
[ ] Docs have been reviewed and added

Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

Fixes #47
Other information

Some needs have been detected while implementing this: #50  and a TODO in backend.service using features, that doesn't match a real service in the API.

I'm approving it 😄


Access value of private variable from another class

How do I access the value of a private variable from another class without using getter methods?
Using an example:
Customer.java has a variable, private final int customerNumber.
If we are not supposed to use a public getter method for customerNumber and Customer.customerNumber would not work because of the private access modifier, How do I access this variable from another class?
Previously, to bypass this, I created a customerNumber directly in the other class (Server.java) to count the customerNumber. But currently, what if 2 classes needs to access this customerNumber variable?
One solution I can think of is creating a customerNumber counter in each of the class, however this leads to duplicate codes.
Hence, it makes sense to put the customerNumber directly in the Customer.java file to reduce duplication. Thus, how would I be able to access this customerNumber variable?

Hi, we are not preventing the use of getter methods, but we encourage the "tell, don't ask" principle in designing your classes. For the functionality that you are trying to implement that involves the customer id variable, think about whether you really need the Customer to return you the id to do the work, or can you just "tell" the customer to do that work.
If you really need getters, you can still use them.

Would it be fair to say that the TDA principle just wants us to minimise the exposure of our private data/attributes of a class, but that if we truly need some of said attributes, we can always implement a getter method? Of course, it would be even better would be to tell the object what do to, right?

This issue is stale because it has been open for 30 days with no activity.


Fix #20768: Don't seed search without selection

Fixes #20768. This makes CMD/CTRL+F consistent with other editors/IDEs (actually, almost all software on all platforms).
Without any text selected, the current behavior (with seedSearchStringFromSelection enabled) is to search for whatever word is under the cursor. This is unexpected because all (>99%) other software simply keeps the search field unchanged, so you can continue searching. Try it in some JetBrains IDE, Eclipse, NetBeans, Sublime, Notepad++, Firefox or Chrome in an input field, MS Word, or any other popular software. Nobody does that except for VS Code, so it breaks common user expectations and makes a very common use-case annoying (i.e. continuing from the last search).
That's why I have fully removed the old behavior. If you want to search for the word under the cursor you can simply select it before pressing CMD/CTRL+F like in almost every other application.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: wkornewald sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello, could you please give any estimates when this pull request could be merged? It's been more then 2 years that people have issues with this unexpected behaviour and thanks to @wkornewald it's been fixed but seems nobody is interested in accepting changes made by pro-active community members.

This has been sat idle for nearly six months now - can someone with the relevant permissions confirm why this is problematic or merge it?

Is there any timeline for this being merged?  Can you please let people know.
Thanks!

Oct, Nov, Dec ...
zzzzzZZZ

When will these changes appear in vs code?

Apparently already fixed.


mission-control: revisit nix-diff

Modifying the nix-diff script to retrieve only graphs (derivation trees) instead of diffs.  The differences between the derivation trees of the current and main branch can be compared by using Git.

What should we name the files? Would nix-store-graph.txt be good? I feel like .log implies a wrong thing.

What should we name the files? Would nix-store-graph.txt be good? I feel like .log implies a wrong thing.

Changed filenames to nix-store-query.txt and simplified output format from --graph to --requisites. Few derivations always change the hash, regardless of whether the configuration has any changes or not.
https://nixos.org/manual/nix/stable/command-ref/nix-store/query.html#queries
Ready to merge?


Problem with selling items

Hello. Problem with selling rpgitem items in GeneralMarket plugin.
Cant buy item of rpgitems.
I think, it's because lore of rpgithems.
(https://www.spigotmc.org/resources/general-market.17053/).
Video problem:  https://youtu.be/5qhJS_cd9YM
Can u fix that?

so?

We tried to sell rpgitems through many  market plugin and it works.
As for GeneralMarket, it is a paid plugin so you may seek help from them.

@Librazy Can you give me links links to these plugin-market?

@ungermum try rpgitem 1.12-v3.6.295 or 1.11-v3.5.296


remove binary file from commit

Signed-off-by: Raghavendra Talur<EMAIL_ADDRESS>

This change is

LGTM

@raghavendra-talur we need to have a .gitignore . Merging this anyway.

LGTM.


feat: updating timing and test data

Description

Adding details on account updater testing and timings

Testing required outside of automated testing?

[ ] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.163.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


zf2 package for skeleton-application

hi!
I noticed that there is no 2.4.x package for the skeleton-application (https://github.com/zendframework/ZendSkeletonApplication) on
https://packages.zendframework.com/
Is this planned in the near future?
Thanks in advance

Hi! In this moment 2.4.x tag doesn't exists

I guess the commit https://github.com/zendframework/ZendSkeletonApplication/commit/e2e1c69fc80ed55b21762f70d19e87df34248b06 should be tagged.
Thanks in advance

Why?
Sorry but do you download skeleton app from composer?
Thanks

Yes, I use it with composer.
When I run the following command (reference [1]) I can only download the version 2.5:
php composer.phar create-project --stability="dev" zendframework/skeleton-application path/to/install
Following command will fail:
php composer.phar create-project -sdev --repository-url="https://packages.zendframework.com" zendframework/skeleton-application:2.4.2 path/to/install
Since 2.4 is the LTS version [2] I think to provide a package would be a good idea.
Just for clarification: I have no problem to clone the git repository, but maybe this could help other developers :)
[1] http://framework.zend.com/manual/current/en/user-guide/skeleton-application.html
[2] http://framework.zend.com/long-term-support/

looks like there is no tag with 2.4.x version
this is a big problem

Why you need 2.4 version for skeleton? you could just update composer.json and update with specific zf version, no?

The problem is that there is a 2.0 version of the documentation with the wrong structure and that is misleading. Google seems to love this page. I feel this page should be altered or removed.

Hm.
I personally need no 2.4 version for skeleton and yes I could update composer.json an no this is not a  big problem...
I just wonder why no skeleton application for a LTS release is offered.
Should I close this issue?

In my opinion 2.4 LTS is for existing ZF2 users. New users should start on 2.5 with a view to migrating to 3.0 when available.
If a particular user wants to stay on 2.4, then they should know enough to update their composer.json appropriately. I'm not against putting some tags in place though.

I have the same opinion of @akrabat.. We should pull the community to use the last version of framework..
if a single company decide to use an old but LTS version is its choice.. :+1:

installing ZendSkeletonApplication should be for new project. While the new project has php 5.3/5.4 requirement, we can use git clone, and change the version. OR, the other choice is to update current php requirement in composer.json to 5.3.23, so, when user has 5.5+, it can install zf 2.5, otherwise, should will automatically install zf 2.3

sorry, 2.4


Docker: updates for btcp

Update the Dockerfile, build and run scripts for btcp electrum wallet. Tested bysweeping ZCL keys used for dev mining pool to claim BTCP.
Signed-off-by: Tyler Baker<EMAIL_ADDRESS>

@ch4ot1c fyi, fixes https://github.com/BTCPrivate/electrum-btcp/issues/9

You da man 💪


setDefaultFolderPath() is not working as expected

I'm trying to replace the MANIFEST.MF file inside a JAR (which is essentially a ZIP) using the library (v2.6.1) and the parent directory always ends up being named NF instead of the full META-INF. Is there anything wrong with my code or is this a bug?
String metaInfFolderName = "META-INF";
Path extractedManifestFilePath = Paths.get("...");
ZipFile zipFile = new ZipFile("Test-Zip-File.zip");
ZipParameters zipParameters = new ZipParameters();
zipParameters.setDefaultFolderPath(metaInfFolderName);
zipFile.addFile(extractedManifestFilePath.toFile(), zipParameters);

Thank you.

Looking into it. I am going through some pretty busy days, so please expect some delays in my response. Rest assured, I will look into it as soon as I can.

To replace a file in zip, it is better to make use of ZipParameters.setFileNameInZip() property, rather than ZipParameters.setDefaultFolderPath(). Here is a slight modification of your code where I used setFileNameInZip() and it worked fine. Please note that I also appended metaInfFolderName with a forward slash at the end.
String metaInfFolderName = "META-INF/";
Path extractedManifestFilePath = Paths.get(BASE_DIR, "MANIFEST.MF");
ZipFile zipFile = new ZipFile(BASE_DIR + "Test-1.0.jar");
ZipParameters zipParameters = new ZipParameters();
zipParameters.setFileNameInZip(metaInfFolderName + extractedManifestFilePath.getFileName().toString());
zipFile.addFile(extractedManifestFilePath.toFile(), zipParameters);

As mentioned above, please use setFileNameInZip. I am closing this issue now. Please feel free to reopen if the proposed solution does not work for you.


fix: light client connect

run connect after create light client provider
same for proxy worker
revert light client button in network settings

Update:

synchronised provider and api creation
clean api on provider disconnection and error
clean provider & api on connection change
moved rpc events to it's own feature

Task linked: CU-8693p1t7z Light Client is lost


Feature suggestions

Hello Jordan,
following our discussion here goes what I want from journaling app.
I have a bipolar mood disorder. Keeping track of my thoughts, moods and medications is indispensable. I want to be reminded about writing a note, to be able to write down aforementioned things, to navigate through notes and to see diagrams built from recorded metrics/tags.
To break it down I need:

reminders
text and metrics notes
search based navigation
data visualisation

The available apps are either too specific, lack some features or/and have features I don't need.
I've figured out the best way is to use a barebones open source note taking app I can improve as I see fit. The main requirement is data in plain text format. Then I can use ad hoc hash tags for metrics (#mood:3, #anxious etc.) and build diagrams using some external tool. Reminders are also not essential, I can set them using my smartphone's standard app.
Having said that the features I'd like to have are:

separate files for separate notes (not sure)
plain text notes
editable note's date
note's template
some kind of search

I have more ideas for UI/UX but they are less important.
As far as I can see plain text notes go against project's idea and search is a complex thing.
Your thoughts?

Thanks for outlining all of this! Sounds like a very valuable project. There are some overlaps between what you want to do and what I want to do. Namely:

Add search
Add the ability to edit the date of an entry

I'll create separate issues to track these.
I'm afriaid there's not a good way for an app like Markdown Today (which has no server component) to do reminders. Would it be possible to use a separate app to trigger the reminders? Not as nice, but it could work. I imagine there are services which will send recurring emails/texts and you could have it include a link to Markdown Today.
For the remaining requests would you mind opening separate issues for each? That way we can discuss them individually.
Thanks again for your interest!

Looks like you've skipped part of my message:
Reminders are also not essential, I can set them using my smartphone's standard app.

So using a separate app is exactly what I'm going to do.
Glad to see we have some similar features in mind. I'll open the issues later.

Ahh whoops! I've filed the two issues and tagged you in them.


Optionally index HTTP request bodies

thanks, couple comments/questions
the db field needs to end with -term and then you can remove the raw section.
Still debating if it should be more generic or just for http.
Instead of having off/on switch, what if we just use the number of chars to save, and default to 0 instead.  thoughts?

I've corrected the db field name. I agree with the option change, and have amended the commit.


Self-referential packages cause large local repository size?

Can this be prevented?

Possibly related to this: Yarn package installation is really slow and causes timeout issues.

[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...

Using yarn link correctly as documented in CONTRIBUTING.md solves this.
Must have skipped that step...


[es5.d.ts] Intl NumberFormat format function value can be string.

https://github.com/Microsoft/TypeScript/blob/a6a27ab66132087d889ded64373d42174e85f2fe/src/lib/es5.d.ts#L3970
Link to documentation.
According to es5.d.ts interface Intl NumberFormat format function can only accept number value, but actually it can accept string too.
For example:
Intl.NumberFormat("en", {
	style: "currency",
	currency: "EUR"
}).format("20.17");

Result:
"€20.17"

Fixes #

Intl NumberFormat format function value type changed to number | string.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

The type is limited to number intentionally. this applies to almost all operations in the ES spec when implicit conversion is used. Please see relevant discussion in https://github.com/Microsoft/TypeScript/issues/4002.


ci: add issues to correct project

Summary of Changes
Update workflow to add new issues to the correct project.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by


typo Update docker-doris in developer

Problem Summary:
Update outdated sections in doris-docker.md
Checklist(Required)

Does it affect the original behavior: (No)
Has unit tests been added: (No Need)
Has document been added or modified: (Yes)
Does it need to update dependencies: (No)
Are there any changes that cannot be rolled back: (No)

please use git rebase.
Now the git history is mess up.

I think the easiest way is create a new branch from upstream master and copy the modification into it.


Check Expiration Improvement

Matthias Eichstedt
I'm ok with this for now; however, in a final version, I wouldn't handle/evaluate UnreachableInactive on task level, but only on instance level. My suggestion would be to do the following:
receive Mesos TaskStatus(Unreachable, unreachableTime = X)
instance.state = Unreachable, since = X
receive Mesos TaskStatus(Unreachable, unreachableTime = X)
if (instance.state == Unreachable && since.expired) instance.state = Unreachable, since = now
receive Mesos TaskStatus(Unreachable, unreachableTime = X)
if (instance.state == UnreachableInactive && since.expired) UpdateEffect.Expunge(instance) // instance.state = UnreachableExpired, since = now (we don't have this yet)
As I said, I'm ok with fixing that in a later diff.

@meichstedt is this still a fix?

As discussed the InstanceState.since field should be set on each update. This should be used by e.g. ExpungeOverdueLostTasksActor instead of accessing Instance.tasksMap. In the long run we want to make Instance.tasksMap private.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4471. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-4471. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Continue on path if enemy target you have started attacking now has another target

This is to avoid people from abusing the bot and to increase stealthiness.
Will probably have to create a new action mode that handles being in combat, while following a path, and identifying if a new target is now attacking the player

If the title isn't clear - this happens when you attack a mob, but someone else takes aggro from you - in this case your character will just jitterize until the mob dies.


Alarm/Scheduler package should be in open source

There is an implementation of that alarm/schedule feed implemented in internal repository, this should be moved to open source. It's also looks weird to have docs in this open repo for a package that source code is not available here.

Missing period. Regardless of Vagrant or not.

Opened corresponding issue #515 which describes how packages.md examples on how to create "trigger feeds" using the alarm package is done; however without this code in "open" the user can never actually try this.  If this sits in backlog too long we may want to provide an alternative example (although I do not believe we have any available strictly in openwhisk).

This is done.

I installed Openwhisk two weeks ago and I'm still not seeing the alarms package.  I downloaded the openwhisk-package-alarms and did the installCatalog.sh but I keep getting errors.  How do I get the /whisk.system/alarms package for open whisk to work?

@mimy2001 see this issue: https://github.com/openwhisk/openwhisk-package-alarms/issues/50
the alarm (and cloudant) package is not installed as part of the catalog, you have to do it explicitly.

When will it be a part of the catalog?

@mimy2001 Perhaps we can discuss this on the Apache OpenWhisk project email list?  In general, we have tried to minimize the system catalog to very basic actions/packages to allow greater customization of the open source (and Alarms is a special case as it is a Feed Action which has a Provider service/server and trigger DB).

I still dont see the alarms package, and the one at "https://github.com/apache/incubator-openwhisk-package-alarms" has no install instructions