 I made some updates to the TP flash. I updated the RR solution procedure, to be bounded between 0 and 1 and  included acceleration into the SS solution procedure.
I also noticed the volume function was not using the analytical procedure for cubic EoS so I also changed that.
Another question that I have, is that when using cubic EoS for some reason by default the interaction parameters are obtained from the PC-SAFT database. Is that intentional?
Regards,
Gustavo

Codecov Report

Merging #115 (9410888) into master (7ff6220) will decrease coverage by 1.11%.
The diff coverage is 72.45%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   84.67%   83.55%   -1.12%
==========================================
  Files         183      184       +1
  Lines       11627    11782     +155
==========================================
  Hits         9845     9845
- Misses       1782     1937     +155

Impacted Files
Coverage Δ

src/utils/acceleration_ss.jl
30.00% <30.00%> (ø)

...ticomponent/tp_flash/Michelsentp_flash_modified.jl
47.50% <60.49%> (-40.37%)
:arrow_down:

src/methods/fugacity_coefficient.jl
100.00% <100.00%> (ø)

...lvers/multicomponent/tp_flash/Michelsentp_flash.jl
79.57% <100.00%> (-6.90%)
:arrow_down:

src/models/cubic/equations.jl
87.30% <100.00%> (+0.10%)
:arrow_up:

src/solvers/optimize.jl
72.13% <0.00%> (-16.01%)
:arrow_down:

src/methods/tpd.jl
94.68% <0.00%> (-1.07%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

SGTM  in my opinion, @pw0908 ?

Sorry for not replying soon enough; been working on some other stuff. Everything here looked great to me! Do we need to add new tests?

Just some coverage ones, nothing too fancy

I don't think so, the flash solvers are basically the same functions. The changed just made the RR solution procedure a bit more robust and the acceleration can save some iterations.
One thing though, regardless the interaction parameters for the cubic EoS. By default Clapeyron uses the kij from PC-SAFT, is that intentional?

Completely accidental; we'll fix that


support 1.21

Updated mappings
Change to the new Identifier api
The version number has not been bumped.

Update after I realized I missed some dependency version updates.


Command message send deletes node's config directory

When executing the message send command, the from node's directory is deleted, no matter the command result.
How to reproduce
ockam node create blue
ockam node create green
ockam message send hello --from /node/green --to /node/blue/service/echo

Then, blue's directory is there, but green's is not.

Closed in https://github.com/build-trust/ockam/pull/3615


Game exported to android with Immersive mode enabled is not hiding status bar

Godot version
v4.2.dev5.official [e3e2528ba]
System information
Godot v4.2.dev5 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; <IP_ADDRESS>99) - 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz (12 Threads)
Issue description
I have immersive mode enabled, but the game is still not fullscreen on android device ( Redmi Note 9 )

The same project exported from Godot 4.1.1_stable works fine ( it hides the status bar )
Steps to reproduce

Create any project with literally nothing and export it to android ( immersive mode is enabled by default )
Game runs with status bar shown, and should be otherwise. Disabling the immersive mode also shows the status bar but this is correct.

Minimal reproduction project
Empty project, you can see that gray background doesn't cover whole screen, and the status bar with clock is shown when the immersive mode is enabled ( it is by default )

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/80574.


Propagation on message queue systems

I know the x-b3-* headers are well defined for propagation through http, but what about propagation through message systems (for asynchronous producer / consumer spans)?
I think that in jms they use a b3 single header format, but I can't tell if this is standardized or not.

you are right we don't limit messaging to just "b3" single because some systems don't have the same constraints as JMS. However, it is a very good choice for reasons of overhead and also compatibility. The best approach is lenient parsing.. meaning on the way in, parse both formats the same as HTTP mentions.
IOTW, while we mention this was originally designed for JMS, this doesn't mean only JMS implementation of messaging. Probably we should rename some sections.. do you want to give a go at doing that?
cc @openzipkin/core

Just to mention, I am waiting for zipkin-go to merge single header to use
it in aws sqs propagation.
søn. 14. apr. 2019, 02:09 skrev Adrian Cole<EMAIL_ADDRESS>
you are right we don't limit messaging to just "b3" single because some
systems don't have the same constraints as JMS. However, it is a very good
choice for reasons of overhead and also compatibility. The best approach is
lenient parsing.. meaning on the way in, parse both formats the same as
HTTP mentions.
IOTW, while we mention this was originally designed for JMS, this doesn't
mean only JMS implementation of messaging.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/b3-propagation/issues/33#issuecomment-482902955,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC7sAv0sB4HSbg-oojxV1gBln8fbE_6Tks5vgnGdgaJpZM4cuVSI
.


404 upon refresh

need to fix 404 when refreshing - should be same fix as my portfolio

fixed with redirect


Loss of function in component ChatZhipuAI

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
  import os

  from langchain_community.tools.tavily_search import TavilySearchResults
  from langchain_community.chat_models import ChatZhipuAI

  from langchain_core.messages import HumanMessage

  # .环境变量
  os.environ["LANGCHAIN_TRACING_V2"] = "true"
  os.environ["LANGCHAIN_API_KEY"] = "balabala"
  os.environ["ZHIPUAI_API_KEY"] = "balabala"
  os.environ["TAVILY_API_KEY"]="balabala"

  llm=ChatZhipuAI(model="glm-4")

  search = TavilySearchResults(max_results=2)

  tools = [search]

  llm_with_tools=llm.bind_tools(tools)
  response=llm_with_tools.invoke([HumanMessage(content="hello")])
  print(response.content)

  pass

Error Message and Stack Trace (if applicable)
Exception has occurred: NotImplementedError
exception: no description
File "E:\GitHub\langchain\1\agent_1.py", line 33, in
llm_with_tools=llm.bind_tools(tools)
^^^^^^^^^^^^^^^^^^^^^
NotImplementedError:
Description
the code in "langchain_core\language_models\chat_models.py.BaseChatModel.bind_tools" is incomplete, as show below"
    def bind_tools(
        self,
        tools: Sequence[Union[Dict[str, Any], Type[BaseModel], Callable, BaseTool]],
        **kwargs: Any,
    ) -> Runnable[LanguageModelInput, BaseMessage]:
        raise NotImplementedError()

According to the ChatOpenAI, the code should be:
    def bind_tools(
        self,
        tools: Sequence[Union[Dict[str, Any], Type[BaseModel], Callable, BaseTool]],
        *,
        tool_choice: Optional[
            Union[dict, str, Literal["auto", "none", "required", "any"], bool]
        ] = None,
        **kwargs: Any,
    ) -> Runnable[LanguageModelInput, BaseMessage]:
        """Bind tool-like objects to this chat model.

        Assumes model is compatible with OpenAI tool-calling API.

        Args:
            tools: A list of tool definitions to bind to this chat model.
                Can be  a dictionary, pydantic model, callable, or BaseTool. Pydantic
                models, callables, and BaseTools will be automatically converted to
                their schema dictionary representation.
            tool_choice: Which tool to require the model to call.
                Options are:
                name of the tool (str): calls corresponding tool;
                "auto": automatically selects a tool (including no tool);
                "none": does not call a tool;
                "any" or "required": force at least one tool to be called;
                True: forces tool call (requires `tools` be length 1);
                False: no effect;

                or a dict of the form:
                {"type": "function", "function": {"name": <<tool_name>>}}.
            **kwargs: Any additional parameters to pass to the
                :class:`~langchain.runnable.Runnable` constructor.
        """

        formatted_tools = [convert_to_openai_tool(tool) for tool in tools]
        if tool_choice:
            if isinstance(tool_choice, str):
                # tool_choice is a tool/function name
                if tool_choice not in ("auto", "none", "any", "required"):
                    tool_choice = {
                        "type": "function",
                        "function": {"name": tool_choice},
                    }
                # 'any' is not natively supported by OpenAI API.
                # We support 'any' since other models use this instead of 'required'.
                if tool_choice == "any":
                    tool_choice = "required"
            elif isinstance(tool_choice, bool):
                tool_choice = "required"
            elif isinstance(tool_choice, dict):
                tool_names = [
                    formatted_tool["function"]["name"]
                    for formatted_tool in formatted_tools
                ]
                if not any(
                    tool_name == tool_choice["function"]["name"]
                    for tool_name in tool_names
                ):
                    raise ValueError(
                        f"Tool choice {tool_choice} was specified, but the only "
                        f"provided tools were {tool_names}."
                    )
            else:
                raise ValueError(
                    f"Unrecognized tool_choice type. Expected str, bool or dict. "
                    f"Received: {tool_choice}"
                )
            kwargs["tool_choice"] = tool_choice
        return super().bind(tools=formatted_tools, **kwargs)

After replacing this part, the code is running well.
System Info
Python 3.12.3
langchain==0.2.6
langchain-chroma==0.1.2
langchain-community==0.2.6
langchain-core==0.2.10
langchain-huggingface==0.0.3
langchain-openai==0.1.14
langchain-text-splitters==0.2.2
langserve==0.2.2
langsmith==0.1.82

@boli-design you are right, the ChatZhipuAI as per their official documentation support tools invoking. I am going to add this feature which is right now missing.

In addition, I found another related bug. The code:
import os
import getpass
from langchain_community.tools.tavily_search import TavilySearchResults
from langchain_community.chat_models import ChatZhipuAI
from langchain_core.messages import HumanMessage
from langgraph.prebuilt import create_react_agent
from langchain_openai import ChatOpenAI

# .环境变量
os.environ["LANGCHAIN_TRACING_V2"] = "true"
os.environ["LANGCHAIN_API_KEY"] = "balabala"
os.environ["ZHIPUAI_API_KEY"] = "balabala"
os.environ["TAVILY_API_KEY"]="balabala"

llm_1=ChatZhipuAI(model="glm-4")

llm_2 = ChatOpenAI(
    temperature=0.95,
    model="glm-4",
    openai_api_key="balabala",
    openai_api_base="https://open.bigmodel.cn/api/paas/v4/"
)#

search = TavilySearchResults(max_results=2)
tools = [search]

agent_1 = create_react_agent(llm_1, tools)
agent_2 = create_react_agent(llm_2, tools)

response = agent_2.invoke(
    {"messages": [HumanMessage(content="whats the weather in sf?")]}
)
print("agent_2",response["messages"])

#here error occurs
response = agent_1.invoke(
    {"messages": [HumanMessage(content="whats the weather in sf?")]}
)
print("agent_1",response["messages"])
'''
Exception has occurred: TypeError
Got unknown type 'ToolMessage'.
  File "E:\GitHub\langchain\1\test.py", line 37, in <module>
    response = agent_1.invoke(
               ^^^^^^^^^^^^^^^
TypeError: Got unknown type 'ToolMessage'.
'''

The error:
Exception has occurred: TypeError
Got unknown type 'ToolMessage'.
  File "E:\GitHub\langchain\1\test.py", line 37, in <module>
    response = agent_1.invoke(
               ^^^^^^^^^^^^^^^
TypeError: Got unknown type 'ToolMessage'.

When using ChatOpenAI, there is no error. I cound not find how to fix it, maybe it is better to use ChatOpenAI to call other models?

Hello, is this resolved? I tried to use bind_tools for ChatZhipuAi as well and got the same error. And updating to the latest version of langchain_community doesn't solve the issue. Thank you.

I sugguest to use ChatOpenAI instead, which could also call the function of zhipuAI llm.

Hello, is this resolved? I tried to use bind_tools for ChatZhipuAi as well and got the same error. And updating to the latest version of langchain_community doesn't solve the issue. Thank you.

Thank you for your suggestion. Your idea is to add the openai_api_base when defining the LLM to call GLM4 with ChatOpenAI. Is that correct?

Thank you for your suggestion. Your idea is to add the openai_api_base when defining the LLM to call GLM4 with ChatOpenAI. Is that correct?

right

I just found the instruction on ZhipuAI's website. Thank you.

Thank you for your suggestion. Your idea is to add the openai_api_base when defining the LLM to call GLM4 with ChatOpenAI. Is that correct?

right

I find that ChatOpenAI can only support GLM4's temperature as low as 0.01. I have no idea why this is the case. Any temperature lower than 0.01 will cause an error.


Binding not working

Describe the bug
tryn to bind a property to contentpresenter its grabing the value once but not updating ...
To Reproduce
    public ScreenViewModel Screen => screen;

    public bool SetScreen(ScreenViewModel screen) => Notify(ref this.screen, screen, false, nameof(Screen));

    {

        field = value;
        Dispatcher.InvokeAsync(() => this.RaisePropertyChanged(name));
        return true;

      }

<ContentPresenter Content="{Binding ViewManager.Screen, Mode=OneWay}" ContentTemplate="{DynamicResource screenselector}"/>

Expected behavior
No response
Avalonia version
11.1.0
OS
No response
Additional context
No response

yea solved -> contentpresenter was not working as expected -> using contentcontrol


License type?

Hi!
Would it be possible to specify the license for this package? Is it the same as in the pcov repo?
Thanks

@krakjoe Any news about this?

Merged in 5aeece3ff181457ada7e7d4a05af557eaa368c38
Thanks.


Linkerd integration seems to cause memory leakage on the agent

Output of the info page
Getting the status from the agent.

===============
Agent (v7.23.0)
===============

  Status date: 2020-11-23 19:59:12.508255 UTC
  Agent start: 2020-11-23 19:52:07.211746 UTC
  Pid: 1
  Go Version: go1.14.7
  Python Version: 3.8.5
  Build arch: amd64
  Agent flavor: agent
  Check Runners: 4
  Log Level: INFO

  Paths
  =====
    Config File: /etc/datadog-agent/datadog.yaml
    conf.d: /etc/datadog-agent/conf.d
    checks.d: /etc/datadog-agent/checks.d

  Clocks
  ======
    NTP offset: -24µs
    System UTC time: 2020-11-23 19:59:12.508255 UTC

  Host Info
  =========
    bootTime: 2020-11-07 00:18:41.000000 UTC
    kernelArch: x86_64
    kernelVersion: 4.14.198-152.320.amzn2.x86_64
    os: linux
    platform: debian
    platformFamily: debian
    platformVersion: bullseye/sid
    procs: 218
    uptime: 403h33m30s

  Hostnames
  =========
    ec2-hostname: ip-10-3-7-163.ca-central-1.compute.internal
    host_aliases: [ip-10-3-7-163.ca-central-1.compute.internal-k8s-apps-dev-ca2]
    hostname: ip-10-3-7-163.ca-central-1.compute.internal
    instance-id: i-04e2183f459f28298
    socket-fqdn: datadog-5jqns
    socket-hostname: datadog-5jqns
    host tags:
      stage:dev
      place:ca2
      env:dev-ca2
      agent:k8s
      eks-cluster-name:k8s-apps-dev-ca2
      cluster-type:apps
      region:ca-central-1
      kube_cluster_name:k8s-apps-dev-ca2
      cluster_name:k8s-apps-dev-ca2
    hostname provider: container
    unused hostname providers:
      aws: Unable to determine hostname from EC2: unable to fetch EC2 API, Get "http://<IP_ADDRESS>/latest/meta-data/instance-id": dial tcp <IP_ADDRESS>:80: connect: connection refused
      configuration/environment: hostname is empty
      gce: unable to retrieve hostname from GCE: Get "http://<IP_ADDRESS>/computeMetadata/v1/instance/hostname": dial tcp <IP_ADDRESS>:80: connect: connection refused

  Metadata
  ========
    hostname_source: container

=========
Collector
=========

  Running Checks
  ==============

    cpu
    ---
      Instance ID: cpu [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/cpu.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 7, Total: 190
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:04.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:04.000000 UTC

    disk (3.0.0)
    ------------
      Instance ID: disk:4e2ef38058b61387 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/disk.yaml
      Total Runs: 29
      Metric Samples: Last Run: 366, Total: 10,614
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 138ms
      Last Execution Date : 2020-11-23 19:59:12.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:12.000000 UTC

    docker
    ------
      Instance ID: docker [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/docker.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 810, Total: 22,618
      Events: Last Run: 0, Total: 4
      Service Checks: Last Run: 1, Total: 28
      Average Execution Time : 104ms
      Last Execution Date : 2020-11-23 19:59:11.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:11.000000 UTC

    file_handle
    -----------
      Instance ID: file_handle [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/file_handle.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 5, Total: 140
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:03.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:03.000000 UTC

    io
    --
      Instance ID: io [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/io.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 39, Total: 1,065
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:10.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:10.000000 UTC

    kubelet (5.0.0)
    ---------------
      Instance ID: kubelet:d884b5186b651429 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/kubelet.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 816, Total: 22,604
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 4, Total: 112
      Average Execution Time : 416ms
      Last Execution Date : 2020-11-23 19:59:02.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:02.000000 UTC

    linkerd (2.5.0)
    ---------------
      Instance ID: linkerd:232154eb148d62eb [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 282, Total: 21,432
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 96ms
      Last Execution Date : 2020-11-23 19:59:11.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:11.000000 UTC

      Instance ID: linkerd:2b22cc11f46363aa [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 482, Total: 36,632
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 111ms
      Last Execution Date : 2020-11-23 19:59:12.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:12.000000 UTC

      Instance ID: linkerd:96b5ba0ebe3e1b65 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 75
      Metric Samples: Last Run: 227, Total: 17,025
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 75
      Average Execution Time : 31ms
      Last Execution Date : 2020-11-23 19:59:08.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:08.000000 UTC

      Instance ID: linkerd:bc6b98b744531de2 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 250, Total: 19,000
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 68ms
      Last Execution Date : 2020-11-23 19:59:09.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:09.000000 UTC

      Instance ID: linkerd:c0b72e91b3d2c4f6 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 718, Total: 54,456
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 122ms
      Last Execution Date : 2020-11-23 19:59:10.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:10.000000 UTC

      Instance ID: linkerd:d8056fda34e0e621 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 314, Total: 23,864
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 93ms
      Last Execution Date : 2020-11-23 19:59:12.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:12.000000 UTC

      Instance ID: linkerd:e45a33310bf6295a [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 492, Total: 41,692
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 133ms
      Last Execution Date : 2020-11-23 19:59:09.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:09.000000 UTC

      Instance ID: linkerd:e75512a2cc2641e7 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 158, Total: 12,008
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 38ms
      Last Execution Date : 2020-11-23 19:59:10.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:10.000000 UTC

      Instance ID: linkerd:fdf2df4d313ac710 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/linkerd.yaml
      Total Runs: 76
      Metric Samples: Last Run: 366, Total: 27,816
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 76
      Average Execution Time : 98ms
      Last Execution Date : 2020-11-23 19:59:11.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:11.000000 UTC

    load
    ----
      Instance ID: load [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/load.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 6, Total: 168
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:09.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:09.000000 UTC

    memory
    ------
      Instance ID: memory [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/memory.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 18, Total: 504
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:01.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:01.000000 UTC

    network (1.18.1)
    ----------------
      Instance ID: network:5c571333f400457d [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/network.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 103, Total: 2,884
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 11ms
      Last Execution Date : 2020-11-23 19:59:08.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:08.000000 UTC

    ntp
    ---
      Instance ID: ntp:d884b5186b651429 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/ntp.d/conf.yaml.default
      Total Runs: 1
      Metric Samples: Last Run: 1, Total: 1
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 1
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:52:12.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:52:12.000000 UTC

    prometheus (3.3.0)
    ------------------
      Instance ID: prometheus:datadog.cluster_agent:4454a6aa6a355b49 [OK]
      Configuration Source: kubelet:docker://23b4509a9397e111d6313766bb6d18332518bafd4e95e653f4d35e122ba1d3b9
      Total Runs: 25
      Metric Samples: Last Run: 42, Total: 1,050
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 25
      Average Execution Time : 36ms
      Last Execution Date : 2020-11-23 19:58:59.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:58:59.000000 UTC

    uptime
    ------
      Instance ID: uptime [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/uptime.d/conf.yaml.default
      Total Runs: 28
      Metric Samples: Last Run: 1, Total: 28
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 0, Total: 0
      Average Execution Time : 0s
      Last Execution Date : 2020-11-23 19:59:00.000000 UTC
      Last Successful Execution Date : 2020-11-23 19:59:00.000000 UTC

  Config Errors
  ==============
    cri
    ---
      Configuration file contains no valid instances
    kubernetes_state
    ----------------
      Configuration file contains no valid instances
    redisdb
    -------
      Configuration file contains no valid instances
========
JMXFetch
========

  Initialized checks
  ==================
    no checks

  Failed checks
  =============
    no checks

=========
Forwarder
=========

  Transactions
  ============
    CheckRunsV1: 28
    Connections: 0
    Containers: 0
    Deployments: 0
    Dropped: 0
    DroppedOnInput: 0
    Events: 0
    HostMetadata: 0
    IntakeV1: 6
    Metadata: 0
    Nodes: 0
    Pods: 0
    Processes: 0
    RTContainers: 0
    RTProcesses: 0
    ReplicaSets: 0
    Requeued: 0
    Retried: 0
    RetryQueueSize: 0
    Series: 0
    ServiceChecks: 0
    Services: 0
    SketchSeries: 0
    Success: 114
    TimeseriesV1: 28

  API Keys status
  ===============
    API key ending with b7331: Unable to validate API Key

==========
Endpoints
==========
  https://app.datadoghq.com - API Key ending with:
      - b7331

==========
Logs Agent
==========

    Sending uncompressed logs in SSL encrypted TCP to agent-intake.logs.datadoghq.com on port 10516

    You are currently sending Logs to Datadog through TCP (either because logs_config.use_tcp or logs_config.socks5_proxy_address is set or the HTTP connectivity test has failed). To benefit from increased reliability and better network performances, we strongly encourage switching over to compressed HTTPS which is now the default protocol.

    BytesSent: 1.932289e+06
    EncodedBytesSent: 1.932317e+06
    LogsProcessed: 2139
    LogsSent: 2139

  kubelet
  -------
    Type: journald
    IncludeUnits: kubelet.service, docker.service
    Status: OK
    Inputs: /var/log/journal/

  container_collect_all
  ---------------------
    Type: docker
    Status: OK
    Inputs: 0d81bb1d73ecbd284f01f704002075df3ab87bdf711a88c568f9f39360ebbbf0 29403bac4fdd134bc7b2223bb4ed909a322cf5d7434dc47570f24607981e8e5d 35dca3a5f9d7168a35b2d274ea49f38c1015b3b9843654dc18fd0ae0c6c6e7a4 ba11e37309295531b4376f77847e5f58a2981b35f081fa0471ac13a1cb6c1169 a266edbe9fffe15e751cfd8aa41f59304fbc0d82583f9282c5fc87c61864c810 9f531a5b2c9be9dcbd778d81d42b787138da734281ef62acedb01fe1e1b3e1eb 23b4509a9397e111d6313766bb6d18332518bafd4e95e653f4d35e122ba1d3b9 961b2fc838acc5504249a5566808109f335b89760bb2659d5ca8ab213874143a f77ab01023928fd265b85e5c9908fc987899c33bfd3357af26ca8aaa3824c0fa dc025ce68ed03cd227732c298fb2d6c130fd126686197f976a4a77b682b814e9 2eef21ad707aef88897d30b11f88454f25e4c4f5ef7eb3d4755229ce83e02e56 899715d9f6e3c7712e870f912c2c6e9597aacf15830c1658b425ce381b988ca2 81c0fd6b95667c56ceb139935ec697a8bbb74624f815b0dba75ab784dfc2b0a1 edd38cb50a98313cb64bfcc1a6f4b79f68fd816ae5784ff853f56bd7260e36b3 1129d0df26ed1c75ef37cce4a21c564eed9a6751695d357abad990587bf107a5 637b6896924694bcff60976b12324727c6585f4080f42f6213345ba71257ae5e 36b3f2f063a926731543b264aa5982c07cb5e54236ad04fc3c119cc8cbee0782 a09dd1ed7e025fdc14a448b5c9377ee2822fea37f378b5163bfafd3fe7b8d186 db7afac6ec1b06e30d3a94b906a8fdbd97538598bc32d0d86608f2ae6af30be4 052771c6db652bcb33bf112ac77eb1ec9ba0c8f7951716f3a630b03035b411df c258470277ad058b54d27ebc88ef82e2a69e08b7b587e5423fb03f4a421d2a60 53e75875bb37e91416f9b8ee049c7ae4ca88fbb1246d9550186789c4d4173d62 a728d9a0a3184e8ba21307a9713567319725d63a1424cd5381164ecefe7bfc92 007652f3c37525122e6bec350b20b11bd9ed53424d2ddb6d5a48e1606df7d6ed 115239b0a708fafb5f834632d5858dc8699120c7ae451894dc9f2a045d913c99 fb11ef57ba58f74b21e7f4e12e67c7fe5ace486498641afaf45cf39b1b562d52 2257313b8f251ee88f38b39bffa95c904a9e782fae2c619a0bbf62ab68f3554c 0277c2caf8bf9cdccdd1ef0339f34f99c6f56a92991903f32f4717ea86fef164 91cbafaec4b47004b6379f3d821101562fd4834120f71a4d4c6b27836a140b29 2bb73735eb87ce9744cc2347ffb7d5be9ba64ef61721b78fc68f3c135bc184ab 97001e6ad4fa85cab563c9a3a816570dcc9fda90dc7ad028b5332a7ff37c2067 f06fa3a85c8e9743bcf83b22af2f6c1eabfa1c36b264a13ffcfb2c3518394149 1c698993aa8ef999af4e69e8498b3915451b154de8da3e229425ba55eb5ddb1b 8b078f2f90b188354a16a960f3999e8b82bdfca7fd187a2458b79e588c6d162a d5acc53b15dbdbcb3450ace6e34fdae12e23ebf76186b0050f5924654d392a3a 2b9f2402a8d4de3870f7b1f8b9c14db2239313397d34b88f2073db6fbba20757 4966ac089de976c92fe652ddb60c658f8ba6339837081740270fb3318ecedfa9 b177860014ae1f0cfc364f4f5daa1cb5ad246d1eef97409fc398cdfc6f5e6711

=========
APM Agent
=========
  Status: Running
  Pid: 1
  Uptime: 425 seconds
  Mem alloc: 14,346,256 bytes
  Hostname: ip-10-3-7-163.ca-central-1.compute.internal
  Receiver: <IP_ADDRESS>:8126
  Endpoints:
    https://trace.agent.datadoghq.com

  Receiver (previous minute)
  ==========================
    No traces received in the previous minute.
    Default priority sampling rate: 100.0%

  Writer (previous minute)
  ========================
    Traces: 0 payloads, 0 traces, 0 events, 0 bytes
    Stats: 0 payloads, 0 stats buckets, 0 bytes

=========
Aggregator
=========
  Checks Metric Sample: 341,974
  Dogstatsd Metric Sample: 4,486
  Event: 5
  Events Flushed: 5
  Number Of Flushes: 28
  Series Flushed: 325,998
  Service Check: 1,985
  Service Checks Flushed: 1,989

=========
DogStatsD
=========
  Event Packets: 0
  Event Parse Errors: 0
  Metric Packets: 4,485
  Metric Parse Errors: 0
  Service Check Packets: 0
  Service Check Parse Errors: 0
  Udp Bytes: 292,998
  Udp Packet Reading Errors: 0
  Udp Packets: 1,838
  Uds Bytes: 0
  Uds Origin Detection Errors: 0
  Uds Packet Reading Errors: 0
  Uds Packets: 0

=====================
Datadog Cluster Agent
=====================

  - Datadog Cluster Agent endpoint detected: https://<IP_ADDRESS>:5005
  Successfully connected to the Datadog Cluster Agent.
  - Running: 1.9.1+commit.2270e4d

Additional environment details (Operating System, Cloud provider, etc):
AWS EKS 1.18.x on Amazon Linux 2 OS.
Steps to reproduce the issue:

Install Linkerd (you need to have a cluster with good amount of trafic)
Enable linkerd integration
Monitor memory usage over at least 1 day.

Describe the results you received:
Over a period of about 1 day agent pod are getting killed because they use too much memory. You can see the increase of memory on the screenshot below. When I disable the integration the datadog agent pod memory is very stable

Describe the results you expected:
Memory is recycle or flushed and no leakage.
Additional information you deem important (e.g. issue happens only occasionally):
Here is the configuration I have for the linkerd integrtion installed with the helm chart:
    linkerd.yaml: |-
      ad_identifiers:
        - proxy
      init_config: {}
      instances:
        - prometheus_url: "http://%%host%%:4191/metrics"
          tags:
            - "linkerd-pod:%%host%%"
            - eks-cluster-name:k8s-apps-prod-eu
            - cluster_name:k8s-apps-prod-eu
            - env:prod-eu
          min_collection_interval: 15

Still a problem.

Still a problem.

The new version of this check should solve the issue


[SPARK-49132] Minimize docker image by removing redundant chown commands

What changes were proposed in this pull request?
This PR aims to minimize docker image from 892MB to 654MB by removing redundant chown commands.
Why are the changes needed?
BEFORE
$ docker images spark-kubernetes-operator
REPOSITORY                        TAG                 IMAGE ID       CREATED             SIZE
spark-kubernetes-operator         0.1.0               ff9288592e36   3 minutes ago       892MB

AFTER
$ docker images spark-kubernetes-operator
REPOSITORY                  TAG       IMAGE ID       CREATED         SIZE
spark-kubernetes-operator   0.1.0     4e405928e3ce   3 minutes ago   654MB

Does this PR introduce any user-facing change?
No because this is not released yet.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @viirya and @jiangzho

Thank you, @jiangzho .

Thank you, @viirya !


Disabling wrap on TextArea doesn't work (Windows)

Just what the title says. I have this simple code based on the example:
import nigui

app.init()

var root = newWindow()

var container = newLayoutContainer(Layout_Horizontal)
root.add(container)

var buttons = newLayoutContainer(Layout_Vertical)
container.add(buttons)

var btn_open = newButton("Open")
btn_open.widthMode = WidthMode_Fill
var btn_save = newButton("Save")
btn_save.widthMode = WidthMode_Fill
var btn_saveas = newButton("Save As...")
btn_saveas.widthMode = WidthMode_Fill
buttons.add(btn_open)
buttons.add(btn_save)
buttons.add(btn_saveas)

var txt = newTextArea()
txt.wrap = false
container.add(txt)

root.show()

app.run()

But text is still wrapped. Here's the output from nimble so you can verify i have the latest version:
>nimble dump nigui
name: "nigui"
version: "0.2.5"
author: "Simon Krauter"
desc: "Cross-platform, desktop GUI toolkit using native widgets."
license: "MIT"
skipDirs: ""
skipFiles: ""
skipExt: ""
installDirs: ""
installFiles: ""
installExt: ""
requires: "nim >= 0.19.0"
bin: ""
binDir: ""
srcDir: "src"
backend: "c"

Indeed, can confirm this issue. Same here.

Just found the root of the problem. This procedure in /private/windows/platform_impl.nim :
proc init(textArea: NativeTextArea) =
  var dwStyle: int32 = WS_CHILD or ES_MULTILINE or WS_VSCROLL # with wrap
  # var dwStyle: int32 = WS_CHILD or ES_MULTILINE or WS_VSCROLL or WS_HSCROLL # no wrap
  var dwExStyle: int32 = WS_EX_CLIENTEDGE
  textArea.fHandle = pCreateWindowExWithUserdata("EDIT", dwStyle, dwExStyle, pDefaultParentWindow, cast[pointer](textArea))
  pTextAreaOrigWndProc = pSetWindowLongPtr(textArea.fHandle, GWLP_WNDPROC, pTextAreaWndProc)
  textArea.TextArea.init()

if you swap the commented line with the un-commented line, it works.
i guess this wrap feature is just not fully implemented yet.

You are right, it's not implemented yet. I found this comment:
method `wrap=`(textArea: NativeTextArea, wrap: bool) =
  procCall textArea.TextArea.`wrap=`(wrap)
  # TODO: allow to enable/disable word draw at runtime
  # It seems that this is not possible.
  # Word wrap depends on whether dwStyle contains WS_HSCROLL at window creation.
  # Changing the style later has not the wanted effect.


Docs: README.md has wrong path to styles

Sass files can be found in ./src/vibe/assets/scss. Update vars.scss to change global styles.

should be
Sass files can be found in ./src/vibe/scss. Update ./src/vibe/scss/components/vars.scss to change global styles.

@cweekly This has been updated. Thank you!


Add vendor app configurability

The goal of this PR is to allow the inlining of only the vendor.css file by passing a vendorOnly flag in the config for this addon.  While preserving the original behavior for both Glimmer and Ember applications.
The fundamental assumption of the code prior to this PR was that you'd always want to inline both vendor.css and app.css.  Separating these concerns is what necessitated the many changes introduced here.  As well as adding a testing harness.

@mixonic I think this is ready for review

@rondale-sc can you document what the intended result of this code is in the description?

@mixonic Sure thing :+1:
Added.  🍻

This looks excellent! Thank you @rondale-sc


Option to update data if already exists in MSSQL

It would be good if we option to append/update data in SQL Server if already exists.

@MugiJR Can you expand more on what you want?


Federate logout request to OIDC IDPs

Currently, we don't federate the logout requests to OIDC IDPs. To solve this, we can initiate RP init logout request to the logout endpoint of federated IDP. This has to be implemented in OIDC (outbound), authenticator and relevant OIDC authenticators.

Hi @piraveena,
Is there a general specification related to federated IDP logout?
AFAIK different OIDC providers have non-standard endpoints to support logout.
Amazon Cognito - https://docs.aws.amazon.com/cognito/latest/developerguide/logout-endpoint.html
Azure AD - https://docs.microsoft.com/en-us/azure/active-directory/develop/v1-protocols-openid-connect-code#send-a-sign-out-request
So with this improvement how are we planning to implement OIDC federated logout in a generic manner?

Hi @mefarazath,
There is no specs specifically mention about federated logout. With this feature, we are planning to do an RP initiated logout from the client to federated IDP in a general manner. From the oidcAutheticator, we will be able to call the logout endpoint of the federated IDP with parameters such as id_token_hint,etc.
Refer the mail thread "OIDC Federated Logout for Identity Server" in<EMAIL_ADDRESS>

Hi @mefarazath,
What did you mean by "general specification related to federated IDP logout"?
In this case, the Identity Server act as the RP and Federated IDP act as OP. So in order to logout, Identity Server should initiate an RP initiated logout request to the OP as described in OIDC Session Management spec.
In summary the general specification to refer in here is RP-Initiated Logout in OIDC Session Management spec


Support STRICT tables in SQLite

New feature added in SQLite 3.37: https://www.sqlite.org/stricttables.html

SQLDelight is already strict, we dont let you use column types other than the ones there, so I don't think theres any value to adding this (it would have no actual change in usage)


DecoderBufferCallback/Uint8List Not Found on Flutter 3.0.4/Dart 2.17.5

Hi, I'm using version 0.7.4+1 with Flutter version 3.0.4 and Dart version 2.17.5
I'm getting the below errors
/C:/Flutter/sdk-3.0.4/.pub-cache/hosted/pub.dartlang.org/awesome_notifications-0.7.4+1/lib/awesome_notifications_method_channel.dart:186:10: Error: Type 'Uint8List' not found.
  Future<Uint8List?> getDrawableData(String drawablePath) async {

/C:/Flutter/sdk-3.0.4/.pub-cache/hosted/pub.dartlang.org/awesome_notifications-0.7.4+1/lib/src/utils/resource_image_provider.dart:48:26: Error: Type 'DecoderBufferCallback' not found.
      ResourceImage key, DecoderBufferCallback decode) async {

I saw in the documentation that these were deprecated/added since v2.12
However, when I looked at the Flutter 3.0.4 source, I found that the older DecoderCallback is still used.
I will upgrade Flutter to 3.3.0 and try again, but I just wanted to make sure that I didn't mess anything up.
Let me know if I can provide you with any other information.
Thanks.
flutter doctor output:
[√] Flutter (Channel stable, 3.0.4, on Microsoft Windows [Version 10.0.19044.2604], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[√] Chrome - develop for the web
[!] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.23)
    X Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop development with C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK
[!] Android Studio (version 2022.1)
    X Unable to find bundled Java version.
[√] IntelliJ IDEA Community Edition (version 2020.2)
[√] VS Code, 64-bit edition (version 1.76.1)
[√] Connected device (4 available)
[√] HTTP Host Availability

pubspec.yaml
environment:
  sdk: ">=2.17.0 <3.0.0" # references the dart sdk, not flutter!

dependencies:
  flutter:
    sdk: flutter

  path_provider: ^2.0.9
  file_picker: ^4.6.1
  permission_handler: 8.2.0
  app_settings: ^4.1.8
  is_first_run: ^1.0.0
  flutter_secure_storage: ^5.1.0
  package_info_plus: ^1.4.2

  web_socket_channel: ^2.2.0
  flutter_webrtc: ^0.9.7
  connectivity_plus: ^2.2.1
  phone_state: ^1.0.2 # to send WRTC_HOLD if the device receives a call

  awesome_notifications: ^0.7.4 # < 0.8.x
  flutter_ringtone_player: ^3.2.0
  sound_mode: ^2.0.2
  vibration: ^1.7.4-nullsafety.0
  proximity_sensor: ^1.0.4

  # cupertino_icons: ^1.0.2 # I don't think this is needed anymore

  http: ^0.13.5 # used for verification api

  # BACKGROUND OPERATION
  move_to_background: ^1.0.2
  flutter_background:
    path: packages/flutter_background
  geolocator: ^9.0.2

  # WEBVIEWS
  flutter_inappwebview: ^5.4.3+7 # android/ios
  webview_windows: ^0.1.6
  flutter_macos_webview:
    path: packages/flutter_macos_webview

  win_toast: ^0.0.2 # windows notification center
  bitsdojo_window: ^0.1.2 # window sizing on macos

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_launcher_icons: "^0.9.2"
  flutter_lints: ^1.0.0

# flutter pub run flutter_launcher_icons:main
flutter_icons:
  android: "ic_launcher"
  ios: true
  image_path: "assets/icon/Ring_Logo.jpg"
  remove_alpha_ios: true

# The following section is specific to Flutter.
flutter:
  uses-material-design: true

Thanks for your response.
I updated to Flutter 3.3.0/Dart 2.18.0 and it worked.
It was a bit of a pain, but unavoidable, I guess.
Thanks for your hard work on this awesome plugin.


0.8.0-s8

This might be the final release before 0.8.0 is finished.

Generated jar

Libraries generated

PHP server generated

Docs generated


Normalizing Text: ffscraper.nlp.index

ffscraper.nlp.index has a handful of methods for normalizing and indexing text. This is mostly built out of methods from nltk (stopwords, the Porter Stemmer, sent_tokenize, and word_tokenize).
Furthermore, this provides test cases and adjustments to the .travis.yml for building and caching with nltk corpora and packages.

Codecov Report

Merging #8 into master will increase coverage by 17.1%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   41.17%   58.28%   +17.1%
==========================================
  Files           8       11       +3
  Lines         119      175      +56
==========================================
+ Hits           49      102      +53
- Misses         70       73       +3

Impacted Files
Coverage Δ

ffscraper/tests/ffscrapertests/test_nlp_index.py
100% <100%> (ø)

ffscraper/__init__.py
100% <100%> (ø)
:arrow_up:

ffscraper/nlp/__init__.py
100% <100%> (ø)

ffscraper/nlp/index.py
90.9% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307b8f2...3d6dc63. Read the comment docs.


chore: in _expr, rename _pandas_series to _compliant_series

We have an attribute there called _pandas_series, but what it stores is actually a CompliantSeries (see how it works for some explanation). So, we should rename it to _compliant_series
Similarly, for PandasLikeExprCatNamespace, we should rename _expr to _compliant_expr
The list of classes where this needs doing is:

[ ] PandasLikeSeriesCatNamespace
[ ] PandasLikeSeriesDateTimeNamespace
[ ] PandasLikeSeriesStringNamespace
[ ] PandasLikeExprCatNamespace
[ ] PandasLikeExprDateTimeNamespace
[ ] PandasLikeExprStringNamespace
[ ] PandasLikeExprNameNamespace
[ ] ArrowSeriesCatNamespace
[ ] ArrowSeriesDateTimeNamespace
[ ] ArrowSeriesStringNamespace
[ ] ArrowExprCatNamespace
[ ] ArrowExprDateTimeNamespace
[ ] ArrowExprStringNamespace
[ ] ArrowExprNameNamespace
[ ] PolarsSeriesCatNamespace
[ ] PolarsSeriesDateTimeNamespace
[ ] PolarsSeriesStringNamespace
[ ] PolarsExprCatNamespace
[ ] PolarsExprDateTimeNamespace
[ ] PolarsExprStringNamespace
[ ] PolarsExprNameNamespace
[ ] DaskExprCatNamespace
[ ] DaskExprDateTimeNamespace
[ ] DaskExprStringNamespace
[ ] DaskExprNameNamespace

If you're using vscode, you can do the renaming F2

I'd suggest choosing 3-5 of these and submitting a PR for them

Can I do this

can work on this for PydataGlobal sprint

The only remaining subtask is DaskExprCatNamespace, but I didn't find it in the main branch.

thanks @olp-cs  for taking a look! indeed, we don't have that one, so the issue can be closed
if you fancied another contribution, https://github.com/narwhals-dev/narwhals/issues/1556 would be a great one to get in, feel free to ask if anything trips you 🙏


Roadmap layout is broken on mobile

The layout of the roadmap is a bit broken on mobile. The cards should be shown under each other.
Screenshot

Fixed in 66b2e5072fbd723fb76d90ca2af1eafc1e6a26a5

Verified fixed on Samsung fold - google chrome browser


Add Contributing Guideline

We should add Contributing Guideline

Yep! Agreed! We can take the LinkFree guidelines as a starting point 😄

I would like to work on this issue 🙋🏻♂

Sure @thepranaygupta! Feel free to work on it!


How do i able to change OpenAi Endpoint?  https://xyz.com/v1

Pls help me I want to change and use my own OpenAi Endpoint, how I can do so?
Default  OpenAi Endpoint is https://api.openai.com/v1/
I want to change it use my own Rever proxy endpoint for e.g-  https://xyz.com/v1 for OpenAi. Pls Guide me

In here
https://github.com/langchain-ai/opengpts/blob/5adef7616e9a08433953216344d46c1bcd0e0f93/backend/app/llms.py#L11-L16
you can set the base_url for ChatOpenAI


add PAT

GitHub does not allow to use the same deploy keys for multiple repositories. Therefore, we can't use deploy keys.
I suggest to just use PAT + pip installation from github.
Workflow for users that need to install private repos:

Create a GitHub PAT
Add a repository secret named PAT_GITHUB
In the environment.yml, add privare repo as follow:

- pip:
  -<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Aishwarya p125 patch 1

readmd file with instructions to enable history feature

Yayyy cool 🥳
On Thu, 8 Dec, 2022, 21:54 Arya Shah, @.***> wrote:

@.**** approved this pull request.
@AishwaryaP125 https://github.com/AishwaryaP125 Awesomeeee, here have
chocolate 🍫. I have approved the changes you made to the file here. This
was a code review that I did. Now I'll merge your contribution to the main
repository and then close the PR okii?
—
Reply to this email directly, view it on GitHub
https://github.com/aryashah2k/FakeNewsDetectionSpacy/pull/1#pullrequestreview-1210376501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASU7R3PQI4WJMQAIDUEMD4DWMIDUHANCNFSM6AAAAAASX46WNQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Initialize new widget if widgetType changed when model is updated in Composite

Discussed here: https://github.com/fjvallarino/monomer/issues/50

This works for me -- thanks!


Filter fabric sensitive fields during IM report generation

initial prototype implements access control for report generation for IM read (#10236)
but does not filter results based on fabric index
this task is to add that for report generation for report generation
note report generation is used by read and also by subscribe reports (so may need checking each time)

Actually this is done generally in the IM by PR #13404.


[modify] add support for load balancers, secure firewalls and etc

https://qastack.jp/server/515957/how-to-have-nginx-forward-the-http-x-forwarded-proto-header
https://serverfault.com/questions/515957/how-to-have-nginx-forward-the-http-x-forwarded-proto-header/859008

Coverage decreased (-17.0%) to 63.104% when pulling 3feffbf052e67fa98ad02985bd7771ceea76e8c5 on sunny4381:features/behind-load-balancer into f000a668f4419e8d7cec12f747173117a011fee4 on shirasagi:master.


usernameExists

Check during account creation whether a username is used or not (MySQL request)

done #12


Put translation links on the top of the .md

Hey !
Now that this documentation is big (and well written), I think it would be a good idea to put translation links on the top of each readme instead of at the end.
It is easy for us to click on the readme file corresponding to the selected language in the respository files viewer, but for someone not familiar with it...

Yep, can you make a PR to update this in all translations?

I suggest to put it before Table of Contents


Documentation update - snow.resource

I spent a little bit of time trying to figure out why from snow.resource import Application from the examples wasn't working

app.rst
index.rst

It just turns out that it's been moved to from snow import Application and possibly requires a documentation change.
I learned a bunch about the library through this example - https://github.com/rbw/snow/blob/master/extras/examples/create-update-delete.py and it'll be helpful if you could write more, including how to fetch work-notes, etc.

You're right. Fixed in https://github.com/rbw/snow/commit/b65869684e4f9513a2d7d8fcbff24e929c24a05b.
Thanks for reporting.

and it'll be helpful if you could write more, including how to fetch work-notes, etc.

Yep, more code examples are coming shortly, when I'm done writing tests.

Added an example of how to interact with the journal API (for fetching work_notes, comments etc):
https://github.com/rbw/aiosnow/blob/master/examples/table/read/journal.py
You'll need to update to the latest version to run it.


Update Git version inside container to allow signing with SSH

Hi Ian,
I feel we should have Git version 2.34 or later in the Rust on Nails Dev Container (we currently have 2.30.2). This would support signing commits with an SSH key. Signing commits is a good practice and maintaining a separate set of keys for authentication and signing (SSH + GPG) seems cumbersome.
As per https://code.visualstudio.com/remote/advancedcontainers/sharing-git-credentials by default Git SSH keys are forwarded to Dev Containers, so besides updating the Git version nothing else should be required to make this work.
Interested in hearing your thoughts on this.
Sincerely,
Faraz

Currently I'm inheriting from rust:slim which is at https://hub.docker.com/_/rust
Which using debian bullseye

So the fix is to move up bookworm.

I don't think it's a good idea to upgrade to Debian Bullseye just because of one package - especially given that Bullseye isn't stable yet. Best strategy here in my opinion would be to use a backport. I've opened a pull request linked to this issue which adds the backport, thus installing Git version 2.39.2.
Let me know your thoughts on this approach. Thanks.


Locks rxjs-tslint-rules package to 4.27.1

This works around a change in transitive dependency (semver package) that was updated to a version that no longer supports Node v8.
Created CAB-3856 to revert the lock if we find it necessary after we move to a more recent Node version.
Commit that introduced the change: 103e20b1891d05ce86d8c49ed7f84407647d8b70 build(deps-dev): bump rxjs-tslint-rules from 4.27.1 to 4.28.0
rxjs-tslint-rules updates the version of semver to ^7.0.0 and starting from that version, semver no longer supports Node8. See:

https://github.com/cartant/rxjs-tslint-rules/compare/v4.27.1...v4.28.0
https://github.com/npm/node-semver/compare/v6.3.0...v7.1.1

Coverage remained the same at 76.748% when pulling 6d49e42a74a97a47e02018e7445fce5c44ba5faa on build-break into fbb43237602ea020def734f3dac35b3cafa90516 on develop.


metrics attribute for work model only captures last source

Metrics.self_for_ids is only keeping one source per work, overwriting previous values.

@zdennis made this fix.


Remove badges from readme

As we now use the unified CI workflow (#326), it seems we unfortunately can't have separate badges for each OS. As the display of the badges was to reference the cross-platform nature of the project, imo it can be replaced by adding a reference in the introduction instead.

Yeah I had considered this as well, however I found the aesthetic rather distracting.


Added a filter option for querying analysis by ids

Quick fix that closes #701
Analyses can now be queried like:
query MyQuery {
  project(name: "your-project") {
    analyses(ids: {in_: [1,2,3,4,5]}) {
      id
      status
      type
      meta
    }
  }
}

OR
query MyQuery {
  project(name: "your-project") {
    analyses(ids: {eq: 1}) {
      id
      status
      type
      meta
    }
  }
}

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.30%. Comparing base (ab809cd) to head (c9e0861).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #804   +/-   ##
=======================================
  Coverage   77.30%   77.30%
=======================================
  Files         157      157
  Lines       13010    13010
=======================================
  Hits        10057    10057
  Misses       2953     2953

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bugfix to CIFAR pickle reading code in Python 3

The following code for reading in CIFAR batches is currently used in Python 3:
d = cPickle.load(f, encoding="bytes")
# decode utf8
print("keys are: {}".format(d.keys())  # debug output
for k, v in d.items():
    print("key is: {}".format(k))      # debug output
    del(d[k])
    d[k.decode("utf8")] = v

This errors out with the following (running under Python 3.6b2):
keys are: dict_keys([b'batch_label', b'labels', b'data', b'filenames'])
key is: b'batch_label'
key is: b'labels'
key is: batch_label
Traceback (most recent call last):
  File "run.py", line 78, in <module>
    main()
  File "run.py", line 67, in main
    (X_train, y_train), (X_test, y_test) = cifar10.load_data()
  File "/usr/local/lib/python3.6/site-packages/keras/datasets/cifar10.py", line 21, in load_data
    data, labels = load_batch(fpath)
  File "/usr/local/lib/python3.6/site-packages/keras/datasets/cifar.py", line 19, in load_batch
    d[k.decode("utf8")] = v
AttributeError: 'str' object has no attribute 'decode'

So seems like there is a bug due to the modification if the dictionary in the iteration loop. This PR fixes this.

LGTM.


renaming In to Contains, removing NotIn

I am changing the syntax for some operations to look like method operations, to do things like "string".starts_with("str"). For set operations In and NotIn, it will invert the arguments order: before we had element, set, In, now we would have set, element, In.
It could also be the right time to remove NotIn since we could write !set.contains(element) instead

Looks like the samples are a bit off on the contains change (https://github.com/CleverCloud/biscuit/commit/01ea43fa9bb09bfc93d6c26e66cd4ec16fd661cc) ?
they still seems to define <var>.contains(<set>) instead of <set>.contains(<var>)

Looks like the samples are a bit off on the contains change (https://github.com/CleverCloud/biscuit/commit/01ea43fa9bb09bfc93d6c26e66cd4ec16fd661cc) ?
they still seems to define <var>.contains(<set>) instead of <set>.contains(<var>)

you're right, I had not updated those, it should be fixed now with dda2bc1

you're right, I had not updated those, it should be fixed now with dda2bc1


Revert "ci: pin baremetal with jdk17 (#2990)"

This reverts commit da39b4289a212c6ebe2ca22d5af89a34e30431f3.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-02-08T15:09:25.841+0000

Duration: 59 min 29 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
3518

Skipped
121

Total
3639

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Create subset_sum.cpp

Description of Change
Total code is added

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

I removed bits/stdc++.h still showing problem


Not able to build vcpkg.exe

Machine:
Windows 7 (x64)
When installing vcpkg with boostrap-vcpkg.bat, the attached error occur (with additional argument -verbose).
2018-08-23 vcpkg.exe build error.txt
Let me know if more details are needed.

Not helpful I know, but
The imported project "C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\;\Microsoft.Cpp.Default.props" was not found.

obviously has a problem.

... V140\;\Microsoft ... ? What does the symbol ;

@degski @Voskrese Yes, I saw that one, but I'm not sure where it is from.

@kenr It's a separator in a path list, but somehow it ended up inside the (this particular) path, which in this case does seem to have quotes.

The -match statement in scripts/cleanEnvironmentHelper.ps matches any variable that contains path (like VCTargetsPath). I think the purpose here is to only merge user and machine environment variable if the variable name is exactly path.
Changing the match statement to ^path$ resolves this issue.


hardcoded s3 endpoint service-entry

we hardcode the s3 endpoint ips because the alternative would be to
create a ServiceEntry in cluster-config for every bucket provisioned by
the service operator which would be a pain.
addrs pulled from:
curl https://ip-ranges.amazonaws.com/ip-ranges.json | jq -r '.prefixes[] | select(.region=="eu-west-2") | select(.service=="S3") | .ip_prefix'

We should probably subscribe to https://docs.aws.amazon.com/general/latest/gr/aws-ip-ranges.html#subscribe-notifications


Conflicting XMLElement::FindAttribute function?

I cannot use the FindAttribute  function as the public function seems to be in conflict with a private function with the same name (but with non const return value). I can however do it , without further harm it seems, if I comment the private function in tinyxml2.h. Not sure this is correct way to do. Please advise.
Error message I get in Eclipse Oxygen 3a and gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 7.1.0:
error: 'tinyxml2::XMLAttribute* tinyxml2::XMLElement::FindAttribute(const char*)' is private within this context

Wow. You are entirely correct. Not quite sure how that...got this far.


feat(credential-w3c): added support bbs proof format

What is being changed
This PR extends the credential-w3c actionHandler logic by adding support for bbs signatures.
In this way, it will be possible to generate plugins that implement the creation of Verifiable Credentials and Verifiable Presentations, as well as their verification using bbs-type signatures.
According to what was discussed here:
https://discord.com/channels/878293684620234752/1220477267172659360/1227352488579961003
Quality
Check all that apply:

[X] I want these changes to be integrated
[X] I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
[X] I allow my PR to be updated by the reviewers (to speed up the review process).
[ ] I added unit tests.
[ ] I added integration tests.
[ ] I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details
These changes only extend the logic of the action-handler, they do not include the implementation of the plugin.

proof format
Hello, I totally agree, I think that the algorithm needs to be changed a little so that it can be extended without having to touch the central code.
This change is just so we can 'quickly' implement a plugin for this type of proof format.

This looks interesting and is a reasonable approach to the current limitations of the credentials API in Veramo.
Do you have an implementation of this plugin that you can link to?
Yes, I developed a sample plugin to test signing and verification with BBS, but for now it has several hardcoded elements such as the keys and the VC subject

Hi @nickreynolds @mirceanis,
I've noticed that some pre-merge checks failed for this pull request. However, I believe these errors are unrelated to the changes introduced in the PR itself.
Could you please advise if this is a common occurrence and provide some guidance on how to proceed?
Thanks in advance

Hi @nickreynolds @mirceanis, I've noticed that some pre-merge checks failed for this pull request. However, I believe these errors are unrelated to the changes introduced in the PR itself.
Could you please advise if this is a common occurrence and provide some guidance on how to proceed?
Thanks in advance

@veromassera I believe that yes those failures were unrelated and should be fixed by #1391
If you rebase your branch against the latest next and push that again, it should re-run the checks and they should all pass


Add ability to deploy with docker

This PR adds the ability to deploy an Artemis server with Docker.
It adds docker compose templates and tasks to the artemis role to allow this.
The current solution is not the nicest you can have, but this will clear up once every system migrates to docker deployments.
An example deployment can be found on https://artemis-test1.artemis.cit.tum.de

@Hialus Do I understand it correctly that this does compile Artemis within the Docker container?
If so, would using the images already hosted on GitHub be an alternative?


chore: switch to Jasmine

I was wrong to not follow your advice at the time, @nazreen. Jasmine will suit the project a lot better than Mocha - Jasmine is a good "batteries included" package with all the necessary tools for the kind of testing we need to do.
I would like to suggest we switch to Jasmine.

I have not touched the tests at all to be honest. and I have not used mocha personally, only jasmine (and I am happy with it). between mocha and jasmine I am also more familiar with jasmine so I can more easily work on it if it's jasmine.

I also don't remember giving any advice on which test runner to pick!

I also don't remember giving any advice on which test runner to pick!

Oh, sorry, must be a false memory, haha.

@lilsweetcaligula this is done right? do close if done :)


Tab strip scroll bumpers don't disable when scrolling to the edge

Environment
Windows build number: 19577.1000
Windows Terminal version (if applicable): 0.10.761.0
tab settings set to default, ie:
    "showTabsInTitlebar": true,
    "tabWidthMode": "equal",

Steps to reproduce

Add enough tabs to make the tab strip scrollable, so that the scroll arrows appear.
Scroll as much as possible in one direction (left or right)

Expected behavior
The corresponding arrow should be disabled and grayed out to indicate the state of being at the complete left/right. Example with Microsoft Edge (Legacy) tab strip :

Screenshot above on MS Edge, after doing the repro steps, with the mouse cursor on the arrow button
As you can see, MS Edge reacts to the edges of the tab strip. (..Mandatory pun)
Actual behavior

Notice that even though you can't scroll anymore, the scroll arrow doesn't reflect this state. (Not grayed out, and reacts to clicks, even though nothing happens

Screenshot above on Windows Terminal, after doing the repro steps, with the mouse cursor on the arrow button
I went ahead and tried to look into it a bit, and was able to repro with WinUI 2 through the XAML Control Gallery, and WinUI 3 alpha as well.
I thought it would be wiser to file the issue on their repo, but it was apparently advised to report it there as Terminal's Tab View may be a prototype version and not directly using Win UI's - My apologies if this issue would have been better off on WinUI's repo !

Yea you should definitely file it on the WinUI repo. We are using the TabView directly from their package. A couple months ago, it was just a prototype, but they've been shipping it officially for a couple releases now 😄

Good to know, thanks for the precision 🙂 !
I'll do exactly that and cross-reference both issues, to try to make issues management easier on your end. Apologies for the outdated information I had !

I'm gonna mark this one Tracking-External as well and close it out, but we'll keep our eyes on it. Thanks!


w_dio

New Pull Request Checklist

[ ] I have read the Documentation
[ ] I have searched for a similar pull request in the project and found none
[ ] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I'm adding
[ ] I have updated the documentation (if necessary)
[ ] I have run the tests without failures
[ ] I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)
This PR consumes the latest DIO from https://github.com/cfug/dio and renames the package to w_dio. This is done so that we can begin incremental migrations away from this fork and back onto the public package.

Security Insights
The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(1) Security relevant changes were detected
Watched file aviary.yaml removed

Action Items

Request infosec review via Slack: #support-infosec
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@Workiva/release-management-p

@rmconsole-wf
@Workiva/release-management-p

@Workiva/release-management-p
happy now?

QA+1 CI passes


Radio buttons seem to not work for dejsonify

Radio buttons seem to not work for dejsonify.
It may miss adding checked
https://jsfiddle.net/onigetoc/aapne9nv/2/

I just find out that using dejsonify give the same value to all radio button group

I tryed multiple method and it work only once.
i can fill the for with the right radio button checked. but if you change the radio choice or not and try to fill the form again, it do not work.
https://jsfiddle.net/onigetoc/f0f6ud60/4/


Update class diagrams of Model component

Codecov Report

Merging #178 (aeaea6a) into master (a6c6550) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     71.70%   71.70%
  Complexity      731      731
=========================================
  Files            99       99
  Lines          2110     2110
  Branches        277      277
=========================================
  Hits           1513     1513
  Misses          489      489
  Partials        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6c6550...aeaea6a. Read the comment docs.

All checks passed, LGTM.


Bad sound with 3+ clients

Hey! I've been testing the plugin with my friends and seems like it's fine when 2 clients are talking
But when it comes to 3+ the voice pitch becomes very robotic and a lot of noise introduces
You can reproduce this with running 3 instances in godot
Do you know anything on this? Can I fix it somehow?
I've tried various bitrates and changing buffer length, no luck :(

It happens even when talking one at the time, meaning only one sends audio packets
And somehow if I set playing=false to one of the AudioStreamPlayer's with AudioStreamVOIP everything becomes normal

Maybe I set up something wrong, but it’s unlikely) if it will be useful here is my project:
https://github.com/Nordup/thegatesjam
Uploading<PHONE_NUMBER>170398562.mp4…

Maybe I set up something wrong, but it’s unlikely) if it will be useful here is my project:
https://github.com/Nordup/thegatesjam
https://github.com/RevoluPowered/one-voip-godot-4/assets/54914954/bd6fffee-615b-4584-8081-914815ab2721

Sounds like this could possibly be related to https://github.com/godotengine/godot/issues/75109 if you are testing on Windows.

doesn't seem like it actually)) it happens on linux and not related to files


DownloadableRuntime decode error

https://devimages-cdn.apple.com/downloads/xcode/simulators/index2.dvtdownloadableindex

1.5.0 has been released. Downloading of iOS 18 runtimes are not supported but you should be able to use the tool. Thanks


unclean duit.cc bypass (resolve #35)

 NOTICE
I dedicate any and all copyright interest in this software to the
public domain. I make this dedication for the benefit of the public at
large and to the detriment of my heirs and successors. I intend this
dedication to be an overt act of relinquishment in perpetuity of all
present and future rights to this software under copyright law.

Fixes: #35
check for buttons and click, if stuck on getlink.php page then keep reloading

[x] I made sure there are no unnecessary changes in the code*
[x] Tested on Chromium- Browser OS
[x] Tested on Firefox

* indicates required

will clean later™


Upgrade to ApolloClient V3

This ticket has been created to keep track of all the working or broken workflows of the apollo-client v3 and to fix them.
https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes

Workflow
Develop
Staging

Upgrade Package Libraries
✅
❔

Replace Cache Direct Writes here
❌
❔

Rename react-apollo with    @apollo/client
❔
❔

Replace FragmentMatcher with  possibleTypes
❔
❔

✅  = working
❌  = broken
❔  = Unknwon

Completed


Thresh count & double variable spell in sdba properties

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] CHANGES.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

spell_length_distribution now accepts an argument window. The default is window=1 and corresponds to the old behaviour
threshold_count hard codes window=1  in  spell_length_distribution (so exactly the same as the default for spell_length_distribution
double_spell_length_distribution and double_threshold_count for analog function where we have two variables & two thresholds

Does this PR introduce a breaking change?
No
Other information:
threshold_count might be seen as superfluous. There might be some optimizations available in this case, it might be more convienient for users to have this specific option. But I'm open to just remove this options.

@Zeitsperre I just ran a notebook with this env:
from __future__ import annotations
import numpy as np
import xarray as xr
from xclim.ensembles import fractional_uncertainty, hawkins_sutton, lafferty_sriver
from xclim.ensembles._filters import _concat_hist, _model_in_all_scens, _single_member
from pathlib import Path
from xclim.testing import open_dataset

"""Just a smoke test."""
dims = {"run": "member", "scen": "scenario"}
da = (
    open_dataset("uncertainty_partitioning/cmip5_pr_global_mon.nc")
    .pr.sel(time=slice("1950", None))
    .rename(dims)
)
da1 = _model_in_all_scens(da)
dac = _concat_hist(da1, scenario="historical")
das = _single_member(dac)
hawkins_sutton(das)

and I don't get an error, for xarray==2024.{03,05}

For context of the PR, I wanted a function that can be used in a xscen workflow to get measures of dailyfreezethaw:
  dlyfrzthw:
    base: xclim.sdba.properties.double_threshold_count
    cf_attrs:
      long_name: "Number of days where maximum daily temperatures are above 0 degC and minimum daily temperatures are  at or below 0 degC."
    input:
      da1: tasmax
      da2: tasmin
    parameters:
      op1: '>'
      op2: '<='
      thresh1: '0 degC'
      thresh2: '0 degC'
      method1: 'amount'
      method2: 'amount'
      group: 'time'
      stat: 'mean'

I get the idea we want to separate xclim and sdba as much as possible, but I just find that xscen is trying to leverage both, but in the process, we end up rewritting xclim code in sdba. It seems pretty clear indicators belong to xclim, but then again, many functions in xclim.indices.generic could server xclim AND sdba.
Perhaps there is a way to have more generic classes/functions in sdba that can eventually use a function from xclim as an input? Would we want to allow this kind of flexibility in sdba?


[Performance Bug Report] Specific file structure cause time difference in DynamicCacheLoader.Java

We are working on the Algorithmic Complexity Denial-of-Service problem and detected a performance bug from your code.
We didn’t create a pull request because we're not sure whether this bug can be triggered from the user interface. We also do not understand the functionality of this code snippet as you do. Thanks for your understanding.
Outcome
In DynamicCacheLoader.java the method getResByUrl would take more time for specific input.
Reasons
The getResByUrl function traverses the given path to find the file matching the Url. For a recursive directory, it would take more time than average situation.
Suggestion
The getResByUrl function only checks the file name to match the Url. We suggest that the entire path of result file should be checked, which would avoid tranverse in the wrong directory and reduce the recursion times greatly. For a directory of perfect k-ary tree with n depth, the recursion times would be less than n instead of k^n.

Thanks. This feature added by other contributor, it's ture that  getResByUrl   function with performance problem. And your suggesion is good, if you have time , maybe you can pull request to solve this issue.


Decide on name for "origin" as description

The description extension currently uses the type name "origin" for vagrant, introduced, etc. We need to decide if we want to keep it that way.
The name "origin" is discussed here: https://github.com/qgroom/ias-dwc-proposal/issues/5

I'm OK with this terminology. It is always going to be problematic.
In most checklists the majority would be native, which would make the usage clearer.

We decided to discard origin and to replace it by invasion stage (see https://github.com/trias-project/alien-plants-belgium/issues/60#issue-295811123):

The information needed for invasion stage is contained in D/N (degree of naturalisation) in the raw data file (see table for the terms). This information can perfectly be mapped to the Blackburn et al. (2011) vocabulary. This field is currently used for the mapping of origin in the description extension (see #12). I would discard the term origin and replace it by invasion stage

We all agreed on this, so I'm closing this issue


Prevent race in trying to compile grpc.pb.cc file before pb.h exists

On occasion, highly-concurrent make would produce the grpc.pb.cc file and then try to build the grpc.pb.o file before it had finished creating the pb.cc (and thus pb.h) files because there was no dependence between these rules. This would then break the compile since the grpc.pb.cc file includes the pb.h file. This change adds a dependence between the two instances of code generation in the Makefile.template

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Oh this will probably fix #11642! Nice catch

Cool, I would see this sometimes on my desktop (and I remember that Mehrdad reported it) but didn't know we had seen a related Jenkins issue. Yes, this is the fix for that problem.
Fixes #11642

https://github.com/grpc/grpc/issues/10307

A little embarassed that I forgot the issue that I reported.

Fixes #10307

All green. Linux test opts (https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux_opt/549/console) is showing a failure but it also says that all run_tests.py completed successfully; I think this was related to Github being down at the time.


octoprint.python.pkgs.OctoPrint-FileCheck-2021.2.23 -> 2024.3.27

Things done

New release of OctoPrint-FileCheck

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 346570 run on x86_64-linux 1

2 packages built:

octoprint
octoprint.dist

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 346570 run on aarch64-linux 1

2 packages built:

octoprint
octoprint.dist

LGTM


Ability to merge lines

Two line segments that connect and have the same angle should be mergeable.

Corollary - Two lines drawn by the circle tool that connect and have the same angle should automatically do this.


[service-bus] track2 - in the message handler options, maxConcurrentCalls isn't being respected

When subscribe'ing to a queue or subscription you can specify, as part of the options, a maxConcurrentCalls parameter.
The doc for that option is:
  /**
   * @property {number} [maxConcurrentCalls] The maximum number of messages that should be
   * processed concurrently while in streaming mode. Once this limit has been reached, more
   * messages will not be received until the user's message handler has completed processing current message.
   * Default: 1
   */

(edited)
In track 1 the behavior was modulated, properly, by only adding credits as the user's callback resolved. This appears to have regressed in track 2 and is now doing the opposite of what I wrote above - it appears to only execute the callback one message at a time, rather than in parallel.

We should fix this to use something like p-limit so the user has some control over the # of in-flight callbacks.

The number of in-flight callbacks matches the number of credits which matches maxConcurrentCalls.

[ edited - added note about how this behavior appears to have regressed in track 2]

Gah. Totally closing this - I apparently had stale code even after I thought I'd rebuilt. NEVER MIND!


Configure Xdebug debugging sessions to be started by a trigger by default

The Problem/Issue/Bug:
As an experienced PHP developer

I would like to be able to use all of Xdebug's features with zero configuration.
I would like to use the development features without triggering a debugging session.
I do not expect any errors or warnings when executing PHP scripts on the command line.
I would like to be able to generate line and path coverage reports of my code using phpunit and xdebug.
I expect to be able to start debugging session via the XDebug browser extension or from my IDE.

As a non experienced PHP developer

I would like to start a xdebug debugging session with minimal effort.
I would like to use the improved error traces provided by xdebug.

How this PR solves the problem:
This PR is based on the results of the issue #3731.
Xdebug is enabled by default with all of its features. A debugging session is no longer started automatically.
This allows the usage of the Xdebug development features during development of your application (and not debugging it) as well as triggering alternative features like profiling or tracing.
In this mode you can enable debugging sessions by cookies (browser extension or bookmarks) or by environment variables on the cli (set by your IDE).
To enable the automatic start of a debugging session you can run ddev xdebug autostart or by setting the value xdebug_autostart: true in the .ddev/config.yml.
This will start a debugging session on each request and on every started script on the command line. This is the current default behavior, when enabling xdebug.
The Xdebug extension can still be disabled by running ddev xdebug off or setting xdebug: false in the configuration.
Architectural Decisions
Preferring "autostart" over "trigger" as a new mode
As discussed in #3731 the initial idea was to introduce a new mode "trigger" to provide new behavior to stay compatible to the current default behavior.
I did some research and asked developers what they would expect would happen when they execute "ddev xdebug trigger", in most cases they could not imagine the concrete behavior or describe it precise.
At the same time "ddev xdebug autostart" was easy to understand and describe for everyone.
The current default behavior of xdebug in ddev was also not expected by the asked developers (no ddev users).
Enabling Xdebug by default
Enabling Xdebug is a reasonable default as it provides useful development features like better var_dump function and traces for errors.
Using Xdebug in a development environment is a common default. To test your application in a more production like environment you can still disable the extension.
With disabled autostart of debugging sessions there are no drawbacks in running Xdebug during development.
Disabling autostart mode by default
Automatically starting debugging sessions is not always intended.
There are serveral common situations in which you do not like to start a debugging session when Xdebug is active:

Debugging your Application with xdebug extended var_dump and xdebug error traces (Of course NOBODY would do that)
Generating line or path coverage reports on the command line
Debugging a single request, controlled by your browser plugin instead of debuggin all requests
Using the profiling ot tracing features of xdebug
You like to debug requests in the browser but not on the command line
As debugging all requests on CLI and in browser seems to me a special use case this should not be the default.

Using phpenmod for switchting the configuration
phpenmod is a tool to enable or disable php modules. It is not meant for switching configurations.
I decided to use it anyway, as it makes it easy to apply the configuration change for all php variants (Module, FPM and CLI) and all versions (5.6 - 8.1).
Also the current xdebug configuration is already placed in a mods-available configuration, so using those files for configuration changes seems to be acceptable in the DDEV project.
Supporting Xdebug 2
As discussed in #3731 DDEV does not implement new features for xdebug 2.
However this pull request does support xdebug 2, because not supporting it would have added complexity to this pull request.
Omitting support for xdebug 2 would cause errors executing phpenmod xdebug_autostart as the auto start configuration file would not exist for php version lower than 7.2. Also the behavior between xdebug 2 and xdebug 3 php versions would change, which would add complexity for the user and to the documentation.
Breaking Changes
Xdebug will be enabled by default. add xdebug_enabled: false to disable it.
Debugging session will not start automatically. You can trigger them by browser or environment variable on CLI, or you have to run ddev xdebug autostart to debug every request, this will equal the current behavior when xdebug is enabled.
Manual Testing Instructions:

Run ddev config in a new project
When using an existing project, make sure there is no xdebug_enabled: false in .ddev/config.yml

Default behavior

Run ddev xdebug status

should return "xdebug enabled (debug,profile,trace)"

Browse your website

no debugging session should start

Open your browser and start a debugging session by using a bookmark or the xdebug extension

a debugging session should start

Run a debugging session on cli with your IDE

a debugging session should start

Run any php script on cli

no debugging session should start and there should be no unexpected xdebug output

Switching Mode

Run ddev xdebug autostart
Run ddev xdebug status

should return "xdebug enabled with autostart (debug,develop)"

Open your application in browser

a debugging session should start

Run any script on cli

a debugging session should start

Run ddev xdebug trigger

See default behavior

Automated Testing Overview:

xdebug_test.go
ddevapp_test.go

Related Issue Link(s):

https://github.com/drud/ddev/issues/3731

Release/Deployment notes:
N/A
Open todos

[x] Implement changes
[x] Update Container
[x] Update / add test caes
[x] Update documentation

Related
Xdebug bookmark generator
https://www.jetbrains.com/phpstorm/marklets/
Xdebug Helper Browser Extension
https://chrome.google.com/webstore/detail/xdebug-helper/eadndfjplgieldjbigjakmdgkmoaaaoc?hl=de
PHPStorm Documentation on debugging
https://www.jetbrains.com/help/phpstorm/zero-configuration-debugging.html#activate-debugger-on-server
Xdebug error traces

Xdebug improved var_dumps

You still have this as draft...

I did not fix the tests as I was expecting some feedback from you, @rfay .
Also I am not sure how to handle the changes to the container. I read the docs and saw that I need to push the modified container to an official docker registry and add its name to same configuration.
But I guess I should not commit this configuration change as it shouldn't be merged. So I am not sure how to get the build pipeline fixed.
So, if you tell me to continue and give me some hint on how to continue, I will do.

That's all fine! I'll take a look then when I get home. I usually wait until something is out of draft before looking.

I think we need to define "changing the default behavior" more precise.
If this means "If I open the website  in a browser and I did not change any setting, I don't want any debug session to start" then the default behavior is not affected by these changes. There is also no notable performance impact.
Enabling xdebug in development mode by default, which is currently proposed by this pull request, will provide you better error reporting, infinite recursion detection and formatted var_dumps. Also additional features can be triggert by external tools.
These are features I would expect from my development environment as a php developer.
These features can still be disabled by running ddev xdebug off.
This is also required if you like to use phpstorm to debug phpunit tests.
In case you agree on this I will continue to fix the tests.

I used the wrong terms when I said "changing behavior". I should have said "changing default user experience". I want the outstanding simple default user experience to remain the same, with all the extra trigger behavior (and other xdebug features) you want added on.

Due to the fact that there are problems with Typo3 projects when running them with xdebug development mode enabled (Failing ddev tests because of error output as well as problems with high max_function_nesting_level) I decided to only enable xdebug modes that are enabled by a trigger. So the default behavior will not change at all as long as no trigger is sent with the request.

I have added a retry mechanism to the xdebug tests. If the xdebug connection is not established after the first HTTP request, there are up to three more.
I hope this will make these tests more predictable.

I've updated the documentation to match the new behavior of xdebug better.
I also tried to make the documentation a bit more "use case focused" so I tried to place the "how to debug" part at the beginning.
I did add some information on how to start a debugging session on the command line without starting it via IDE.
I did remove the documentation on how to configure a Run Configuration as it is PHPStorm specific and well documented here: https://www.jetbrains.com/help/phpstorm/debugging-a-php-cli-script.html#create-a-run-debug-configuration-for-a-php-script-manually

Thanks, I'll make time to spend some time with it. I'm an old hand at doing a "run configuration", but of course... most people aren't successful with that. You used to have to do that before PhpStorm got so good at the zero-config.

Rebased and pacified spellchecker

Hmm, I'm not sure if you should remove the xdebug setting from config.yml.
I can't see any reason why it should be turned off for a development environment...
I know there are some PHP extensions that can conflict with XDebug, such as Ioncube (source code encryption).
My suggestion would be to keep the setting for now, and if feedback from the community shows that no one is using it anymore, we could remove it at a later date. What do you think, @rfay?
PS: Sorry for the "Update docs/users/step-debugging.md" commits, just clicked the commit button and didn't see the "add to batch" feature.

I do find the xdebug that you wanted is checked in... but oddly I only see the behavior of the old script. Looking everywhere for something that's doing that.

If you want to keep the xdebug_enabled config in app/config.yaml, shouldn't it take the values on/off/trigger/autostart ?

ddev debug autostart seems to have the previous behavior of ddev xdebug on, but ddev xdebug on doesn't seem to do anything any more.

ddev xdebug off will unload the xdebug extension, you won't be able to create test coverage reports, or do any debugging.
ddev xdebug on will load the xdebug extension. You are now able to create coverage reports for your tests and you can start debugging sessions if you send a trigger.
ddev xdebug autostart is the current "on" behavior, that will automatically trigger a xdebug session for every single web requests and php executing on the command line.

If you want to keep the xdebug_enabled config in app/config.yaml, shouldn't it take the values on/off/trigger/autostart ?

xdebug_enabled should only affect if the xdebug extension is available. I thought about such a switch and decided against it.
As you might see in my commit history I added an xdebug_autostart: true/false switch instead. But when working with my fork I realized that no one should ever commit xdebug_autostart: true to a project as this would cause trouble for other people working on the same project, as they would probably not expect debugging sessions to automatically start when they work on the project.
So I removed this setting again for simplicity and to avoid the problems that are caused by automatically started debugging sessions.
Debugging sessions might trigger anti virus / firewall alerts, will trigger errors in output and logs if there is no listening port on your pc and if there is a listening port on your pc they will block the executing of the request in the browser / on the command line. So they should not start unintended.

As mentioned earlier... I think the problem is that this doesn't work as you expect on existing project that have xdebug_enabled: false in them. I'm sure we can figure out what to do about that or how to doc around it.

As mentioned earlier... I think the problem is that this doesn't work as you expect on existing project that have xdebug_enabled: false in them. I'm sure we can figure out what to do about that or how to doc around it.

I'm not sure if this is a big problem. Let's review the use cases...
Given I have an project with xdebug_enabled: false and I am not aware of this as it was automatically added...

In case I do not want to use any xdebug feature everything is fine
In case I expect to be able to start debugging sessions by a browser plugin as suggested by the new documentation I might be confused
In case I run xdebug on I might expect a debugging session to strart automatically as I am not aware of the changed behavior.

Given I have an project with xdebug_enabled: false and I am aware of this as I configured this manually...

I am aware that xdebug is disabled and I did this for reason. I do not expect it to be enabled after a ddev update.

So yes I do see a small problem for users that are not aware that xdebug is disabled for existing projects or that are not aware of the changed behavior.
We could add a notice to the xdebug documentation informing about the changed default behavior in ddev version 1.x.0.
Furthermore, this should be clearly noted in the release notes.
This is indeed a breaking change but I think most developers that regulary use step debugging will welcome it. We just need to cleary communicate this change.

So yes I do see a small problem for users that are not aware that xdebug is disabled for existing projects or that are not aware of the changed behavior.

It's not really a small problem. It's "It doesn't work at all". All existing projects have it disabled, and when they do ddev xdebug on it doesn't get them working at all. That's what happened to me.
Lots of people would come to Discord and get their problem solved quickly... but only 5% or so of people with a problem come to do that. But every single user that uses xdebug, on every single existing project, will be affected currently, so we have to figure out how to sort this out.

It's not really a small problem. It's "It doesn't work at all". All existing projects have it disabled, and when they do ddev xdebug on it doesn't get them working at all. That's what happened to me.

ddev xdebug autostart should still work, even xdebug_enabled: false is set.
ddev xdebug on should also work if you use a trigger (browser plugin or IDE).
If this does not work, it's probably a bug. Maybe I just misunderstand you, let's have a chat or maybe a short call about that tomorrow.

Sounds good.

Before we talk, just try it with a traditional .ddev/config.yaml, that has xdebug_enabled=false in it.

Rebased, but I didn't push new image since it's still on nicolator. Only thing that should have changed in image since your push is your PhpStorm coverage directory fix.

We should get some version of this, perhaps with a little bit of change, into v1.20.0, which will be coming up soon. If you could rebase (docs will have to be transplanted) and re-push your image after rebasing, we should be on the way. I'm pretty sure we can come up with a good compromise on the user experience, and I'll spend a little time with this again after you rebase. Thanks for all the effort on this!

Are you interested in continuing with this @nico-loeber ? It seems like a worthy project, and I'm quite sure we can do it without jettisoning the current experience.
Right now, the docs are pretty messed up for rebase, and will have to be rejiggered I think.
One option that is certainly out there is to do a simple PR that just adds the behavior you like as an option, rather than having to change everything for everybody.

I'd like to close this for now, just because the merge conflic is now quite complex and because we have a clearer idea how to configure it without changing the existing behavior.
I'm quite sure that this will be a welcome feature, and I think we can do it in a very straightforward way. I totally appreciate how much effort you put into both the PR and educating me on its value.
Closing for now; if you want to rebase and continue on it I'll happily reopen, of course the wintertime with extra hours and no flying will come soon!