File / class deleted during tree shake despite the fact is being used

Is this a regression?

 Yes, the previous version in which this bug was not present was: .Angular 7
Description
I have a service / configuration  that we provide dynamically based on decorator.
Looks like this:
@Injectable()
@Configuration({ deps: [] })
export class VehiclePickerConfiguration extends NewPickerConfiguration {

    constructor() {
        super(VEHICLE_CONFIG);
    }
}

Basically we register (add to a static map) this configuration / service metadata (and many others) by using our custom annotation / decorator. Later on, this configuration / service is provided on the fly using the following code:
 injectorProviders = injectorProviders.concat({ provide: metaData.constructor, useClass: metaData.constructor, deps: metaData.deps });
        this.createInjector(injectorProviders);

Then this VehicleConfigurationis is requested / used in two other different files / classes like this:
let configuration: VehiclePickerConfiguration = this.getPickerConfiguration<VehiclePickerConfiguration>(FieldContainers.RentContract.RentContract_booking_vehiclePriceList_vehicle);
Long story short, we have some generic code to provide these services / configurations on the fly and this worked very well until Angular 8.
But since Angular 8 the whole file (vehicle.configuration) where this configuration is written is basically tree shake (deleted) during compile time and this gives us extra headaches and causing bus in our application.
IF i provide this VehicleConfiguration manually anywhere in the app then the file is not deleted anymore, but this in our case defeats the purpose of providing and creating the instances of these services ONLY when they are needed.
🔥 Exception or Error
The file is deleted most probably during the tree shake process even if it's used (imported and referenced in two other files / classess) and due to this we will have unexpected results (the vehicle configuration is not created and we get and undefined exception)
🌍 Your Environment

Angular CLI: 8.3.17
Node: 10.15.3
OS: win32 x64
Angular: 8.2.13
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.17
@angular-devkit/build-angular     0.803.17
@angular-devkit/build-optimizer   0.803.17
@angular-devkit/build-webpack     0.803.17
@angular-devkit/core              8.3.17
@angular-devkit/schematics        8.3.17
@angular/cli                      8.3.17
@ngtools/webpack                  8.3.17
@schematics/angular               8.3.17
@schematics/update                0.803.17
rxjs                              6.4.0
typescript                        3.4.5
webpack                           4.41.2

Thank you.

This seems to be caused because previously you leveraged on a bug which caused classes that had custom decorators not being tree-shaken away.
This bug was fixes in version 8 and now unused classes with custom decorators are also tree-shaken away.

The file is deleted most probably during the tree shake process even if it's used (imported and referenced in two other files / classess)

Are you referring to the below?
let configuration: VehiclePickerConfiguration =
this.getPickerConfiguration<VehiclePickerConfiguration>(FieldContainers.RentContract.RentContract_booking_vehiclePriceList_vehicle);

The above are type references only which will cause the VehiclePickerConfiguration to be tree shaken away unless it is referenced such as injected via DI.

```ts

The above are type references only which will cause the VehiclePickerConfiguration to be tree shaken away unless it is referenced such as injected via DI.

I understand and also noticed this ( that if I provide it manually or inject it then is not tree shake ), but this is not ok from mu point of view. Basically with this limitation the dynamic providing and injecting is not possible anymore. This for us is a major downgrade.
We also face similar issuues with Components that are created dynamically using the ComponentResolver and which is also not working fine anymore event thought the component is declared in the entryComponents section of its module. This  also worked just fine until we upgraded to Angular 8.  But for that I will open a different ticket.
Back to this topic, we don’t want to statically inject these services, we want to provide them when needed only and seems that currently this is not possible anymore?

@ssmartin did you mean to share some code?

Indeed, it is not possible to retain a piece of code which is not statically referenced.
A workaround would be to mark this used something along;
window.retain = [
  VehicleConfiguration
]

Or add to VehicleConfiguration  to the list of providers in your module.
The @inject without a reference is designed to tree-shake unused service. This was introduced in Angular version 6 under the name Tree Shakeable Providers. Tree Shakeable Providers are a way to define services and other things to be used by Angular’s dependency injection system that will be tree-shaken unless used.
https://angular.io/guide/dependency-injection-providers#tree-shakable-providers

Hi @alan-agius4
Sorry for the typo before - just wanted to highlight some part of your first response.
I am aware of these workarounds (I see them really as workarounds and not as a solution to my problem), but I still think that is really bad to delete the whole file when that type is imported and referenced in other parts of the applications, parts which is not dead code at all.
I'm not even sure if I should open the other ticket (which I mentioned above) because probably I'll get the same reply as here, to use the window.retain which for me is really an ugly workaround...

but I still think that is really bad to delete the whole file when that type is imported and referenced in other parts of the applications, parts which is not dead code at all.

A type doesn't have any JS representation and is used for type-checking:
For example;
class Foo {}
let foo: Foo|undefined;
console.log(foo)

Will produce
class Foo { }
let foo;
console.log(foo);

Notice that In the above example class Foo in used.
Now when passing the above to a minifier like terser. It will produce the below;
console.log(void 0);

Hi @alan-agius4
I understand that, but I hope you can also understand that something that was supposed to help us (the tree shake) is now causing some ugly side effects when you want to do more advanced stuff like providing dynamically some services ONLY when they are needed.

Since decorators are assumed to not have side effects, this isn't really supported behavior within Angular.

Hi @dgp1130
OK, that's fine, but this is not really about decorators - it's about providing a way to dynamically provide some services via StaticInjectors and then later being able to use / create instances of them by requesting them from the injector. This was working very well for us, and now it's not working anymore ...and not because Angular would not support this, but because the file is tree shake during the build process. For us this is at least weird and kind of defeats the whole purpose of the tree shaking concept.

I will provide here a second scenario when the tree shake is causing us problem, after upgrading to ANgular 8. IF you then say I should create a different ticket, I will do it.
We have basically some components that we create dynamically using the ComponentResolver but first we need to get the type based on the name of the component (this we have from some metamodel information).
We use this code to get the type:
// application angular component are kept into a factories map
```
const factsMap: Map<any, any> = (this._componentFactoryResolver)._factories;
const iterator: IterableIterator = factsMap.entries();
let result: Type;
let currentEntry: any;
let currentValue: any;
// iterate through the component factories map
do {
currentValue = undefined;
currentEntry = iterator.next();
        // unwrap current value and check if the name of the component (class) matches the one that is search for
        if (currentEntry && currentEntry.value) {
            currentValue = currentEntry.value;
        }

        if (currentValue && currentValue[0].name === compName) {
            // if component with search name was found, store its type(a.k.a class) and break the loop
            result = currentValue[0];
            break;
        }
    } while (currentValue);

...

These code was working fine and we were getting the type of the components that we will then create dynamically. Now this code is failing even though our component is declared in the _entryComponents_ section of the right module.
What I noticed is that if our component (that we want to find the way described above) extends an abstract class, then the code above still works, but otherwise not anymore.
This happens only in production mode (running ng build...).

Any ideas on this one? SHould I create a different ticket for this?

Thank you in advance.

Hi again @ssmartin,

For us this is at least weird and kind of defeats the whole purpose of the tree shaking concept.

Tree-shaking will remove unused side-effect free code. In Angular custom decorators on classes are treated to be side effect free meaning that classes with a custom decorators that are unused will be removed by design.

This was working very well for us, and now it's not working anymore ...and not because Angular would not support it,

Previously this used to work because of a bug in @angular-devkit/build-optimizer which caused classes with custom decorators not to be marked as pure and thus always retained in the final bundle.  This bug used to cause custom decorators on the classes to allow side-effects at a global level, which in your cases were leveraging.
The current behaviour in Angular is that custom decorators are treated as side-effect free.

Hi @alan-agius4  and thank you for the reply and patience.
I understand all this, but would be nice if you would provide a special decorator or annotation that would prevent tree shaking to remove that class. The window.retain is an ugly hack / workaround, from my point of view.
Best regards,
Sergiu

We are not supporting decorators with global side-effects. This issue provides a workaround for this(referencing from the window).


The first view is wrong.

The first view of the "Multitier topology" is wrong. The fimservice is not connected to HR server, The fimsynchronizationservice does that using a management agent.
I dont expect money but a good word on my LinkedIn page would be great. search for https://www.linkedin.com/in/horn-iamexpert/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2625af9-8587-9e56-c965-f823e6d3f3e9
Version Independent ID: 3479cc4e-90d1-65a9-e44a-de4e46f675f7
Content: Topology guide for deployment
Content Source: MIMDocs/topology-considerations.md
Product: microsoft-identity-manager
GitHub Login: @billmath
Microsoft Alias: billmath

I dont expect money but a good word on my LinkedIn page would be great.
search for https://www.linkedin.com/in/horn-iamexpert/
On Fri, 6 Aug 2021, 15:05 guyhorn1964, @.***> wrote

Really?
On Fri, 6 Aug 2021, 15:05 guyhorn1964, @.***> wrote:

The first view of the "Multitier topology" is wrong. The fimservice is not
connected to HR server, The fimsynchronizationservice does that using a
management agent.
I dont expect money but a good word on my LinkedIn page would be great.
search for https://www.linkedin.com/in/horn-iamexpert/
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com
http://docs.microsoft.com ➟ GitHub issue linking.

ID: e2625af9-8587-9e56-c965-f823e6d3f3e9
Version Independent ID: 3479cc4e-90d1-65a9-e44a-de4e46f675f7
Content: Topology guide for deployment
https://docs.microsoft.com/en-us/microsoft-identity-manager/topology-considerations
Content Source: MIMDocs/topology-considerations.md
https://github.com/Microsoft/MIMDocs/blob/master/MIMDocs/topology-considerations.md
Product: microsoft-identity-manager
GitHub Login: @billmath https://github.com/billmath
Microsoft Alias: billmath

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/MIMDocs/issues/262, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJEUWK5MRMJNYST7WB2ONLT3PT35ANCNFSM5BV7LBKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

The following issue is being closed due to the age. If this is still an issue, please re-submit this. Thank you.
#please-close


sum_rain_1 in Netatmo rain gauge is off by +1%

Home Assistant release with the issue:

arch
x86_64

dev
false

docker
true

hassio
true

os_name
Linux

python_version
3.7.3

timezone
Europe/Oslo

version
0.92.0

virtualenv
false

Last working Home Assistant release (if known):
Not sure.  We haven't had rain here for quite some time, so I haven't been able to observe this sensor value as >0 for a while.
Operating environment (Hass.io/Docker/Windows/etc.):

hass.io in Docker under CentOS 7 on Intel NUC X64
Component/platform:

https://www.home-assistant.io/components/sensor.netatmo/
Description of problem:
The value in the Netatmo rain gauge for the last hour of precipitation is off by +1%.
For instance, in the last hour we have had 0,3mm of precipitation the last hour.
The sensor value shows 0,303mm.
Same thing from when the values should have been 0,1 and 0,2, they were 0,101 and 0,202 respectively.
The values in the Netatmo app shows correctly.  Besides, the sensor is nowhere near being able to read precipitation with an accuracy of 1 micrometer, so the extra decimal places make no sense:
Entity
sensor.netatmo_raingauge_sum_rain_1
State
0.303
The entry for the accumulated last 24 hours seems OK, though:
Entity
sensor.netatmo_raingauge_sum_rain_24
State
0.8
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
 - platform: netatmo
    station: Furulund
    modules:
      outdoor:
        - temperature
        - min_temp
        - max_temp
        - battery_vp
      indoor:
        - temperature
        - min_temp
        - max_temp
        - co2
        - noise
        - humidity
      raingauge:
        - sum_rain_1
        - sum_rain_24
        - battery_vp
      windgauge:
        - windstrength
        - guststrength
        - windangle
        - gustangle
        - battery_vp
      basement:
        - temperature
        - humidity
        - battery_vp

Traceback (if applicable):

Additional information:

Hi
I digged a bit into this and the value off by 1% is the value returned by netatmo API.
I tried first with the pyatmo library and the value for 0.1mm is 0.101mm.
Then i tried it from https://dev.netatmo.com/resources/technical/reference/weather/getstationsdata
and the value returned is again 0.101mm
Then only way to correct this would be to round the value returned by API...don't know if it's a real solution or not.

Since the rain gauge has a resolution of 0.1 mm according to the Netatmo specification I think we can safely round the values to only one decimal places.


Error with Seq2Seq2 training on multiple GPUs.

I am encountering an error when trying to use the Seq2Seq2 trainer to fine-tune T5 on multiple GPUs. The error message is as follows:
../.conda/envs/stance/lib/python3.9/site-packages/torch/nn/parallel/_functions.py:68: UserWarning: Was asked to gather along dimension 0, but all input tensors were scalars; will instead unsqueeze and return a vector.   warnings.warn('Was asked to gather along dimension 0, but all '
The warning message suggests that a gather operation is being performed along dimension 0 on a set of input tensors, but all of the input tensors are scalars. The error occurs during training and causes the training process to crash.
Note that when I set export CUDA_VISIBLE_DEVICES=0 to ensure that the training runs on a single GPU, the training process completes successfully without the warning mentioned earlier.
I am using PyTorch version 1.13.0.
Can you please advise on how to resolve this error? Is there a specific configuration or setting that needs to be modified when using the Seq2Seq2 trainer to fine-tune T5 on multiple GPUs?

Could you share your script? I use the following command to enable multi-GPU
python -m torch.distributed.launch \
    --nproc_per_node ${n_gpus} ../run_seq2seq.py \

https://github.com/ConvLab/ConvLab-3/blob/master/convlab/base_models/t5/rg/run_rg.sh

The command worked perfectly, and I was able to complete the training without any further issues.
I really appreciate your prompt response and the time you took to help.
Have a great day!


Week range

I would like to see the addition of a week range configuration option, so we can hide weekends if we wanted to.

That's a feature I would like too 👍
Feel free to suggest an API for the config

Maybe a callback per day so we can modify each day, add classes etc, so we can then, show, hide or hilight holidays

day = {
    date: '2024-4-3'
    dayOfWeek: 0,  // day of week 0-6
    visible: true,
    name: '',
    className: '',
    style:'', // custom styles such as "background: #a00;"
    events: []  // list of events on this day? could style the day based on events
}

// per day callback
onRenderDay( day ){
  if(day.dayofWeek == 0 || day.dayOfWeek==6){
      day.visible = false;
  }

  if(day.date == '2024-12-25'){
    day.className='holiday';
    day.name = "Christmas Day"
  }

  return day
}

// could also do per hour
onRenderHour(hour){
 ....
 return hour;
}

It would also be nice to set the days of the week
weekGridDays: 7 would show a full week
weekGridDays: 5, if started on a Monday would only show Mon-Fri
weekGridDays: 8 would show next Monday,  given an easy way to drag items into the following week
weekGridDays: 14 would show a custom 2 week view...
Moving forwards and back would still add or subtract 7 says,,,, but you would also set
weekGridStep: 7 Add/Subtract 7 days
weekGridStep: 1 would step by a single day
weekGridStep: 14 would step by 2 weeks..

I think the onRenderDay could be implemented without problem. I like this one a lot. weekGridDays should work too. Great ideas 💡
The onRenderHour will not work that well with how this calendar is built. You can however achieve this more or less with dayBoundaries

Glad you like the suggestions.
I've used that type of callback before where I pass an object to modify to customise the output for a few controls in the past, its a very flexible way to customise a control.

Any ETA?

This is next in line of the open source features.
I'll probably get to it within the next couple of weeks, but I'm not 100% on this. Currently working on finishing the first premium features.
I'll accept PRs though, should be a pretty straight forward feature to build

I decided to implement this with an nDays option in the weekOptions. The onRenderDay API is a cool idea, but it doesn't work well with the current drag-and-drop implementation, and I don't want to start adding features that aren't compatible with all plugins.
That said, I'm open to PRs for an onRenderDay implementation, as long as drag and drop also works when you decide to omit days in the middle of a week.
Will release this in a moment


Update http.py

New assert on response code service unavailable

Better commit message please

it is nice but KNJ uses v0.0


The slim metadata file doesn't reference the latest release

Describe the bug
The action.yml file for the slim version of the action doesn't reference the latest release (currently 5.2.1):
https://github.com/super-linter/super-linter/blob/a797192e187c3bf84749ded4012d264da52556a6/slim/action.yml#L5-L7
Expected behavior
The release on the slim action corresponds to the rest of the repo
Steps to Reproduce
Run a workflow using v5.2.1-slim, and observe that it pulls image version v5.2.0.
Logs
See here

Sorry if I should have created a new issue for this, but I just tried running av workflow with slim v5.2.1 and GitHub still pulls the 5.2.0 version of the image. Am I doing something wrong then?
Task has a simple step:
- name: Lint Code Base
  uses<EMAIL_ADDRESS>
Here's the output from GitHub's action runner:

Isn't that behaviour potentially unexpected? When I pin super-linter/slim to v5.2.2, it'll fetch the slim-v5 image, which is going to be some more recent version than v5.2.2 in the future, no?

Hey @bewuethr, I've created a new issue to track that concern. https://github.com/super-linter/super-linter/issues/4650


Patch PSS files

PSS input file didn't produce the expected links because of wrong residue naming.

@pckroon any idea why the lint fails? Seems strange since the limit (8) is satisfied???

Nope, no clue. Consider looking for open pylint issues.


remove graphql query for accessDetails as it is return by aquarius

Fixes #1994 .

Changes proposed in this PR:

removed subgraph query for accessDetails during init

@nickscavuzzo33 can you please check if you can find the algo you're looking for on this PR.
@bogdanfazakas can you please check if ti's all good, specially with the changes done to the accessDetails

Algo Found - @bogdanfazakas @mihaisc should be goodoto merge

@nickscavuzzo33 If you can validate these changes in production it would be great


make spec.infrastructure.cloudProvider optional

Signed-off-by: Roke Jung<EMAIL_ADDRESS>Make spec.infrastructure.cloudProvider optional

@rokej This is an API change to the z-stream. Has this been approved or is there an issue I can associate this change with?


chore(package): update everything to latest versions

Coverage increased (+3.3%) to 95.0% when pulling bbff235081e9b2f6021ef029b9781a520eb69215 on upgrade-everything into 4df9090878cf810d545da07d336dd19715a61c16 on master.


How do i connect it to my elk?

Hey, first of all i wanted to say thank you for the project.
I don't know how to connect it to my elk, do i need to create an input in logstash and send the log from the appender to port 5044? please send me some instructions

Hi,
Actually you don't need logstash when using the appender.
The appender is writing directly to your Elasticsearch service.
You will have to configure the server and port of your Elastic service.
If you using aws you will have to add <AuthenticationMethod>
Example:
    <!--Only one credential type can used at once-->
    <!--Here we list all possible types-->
    <AuthenticationMethod>
      <!--For basic authentication purposes-->
      <Basic>
          <Username>Username</Username>
          <Password>Password</Password>
      </Basic>
      <!--For AWS ElasticSearch service-->
      <Aws>
          <Aws4SignerSecretKey>Secret</Aws4SignerSecretKey>
          <Aws4SignerAccessKey>AccessKey</Aws4SignerAccessKey>
          <Aws4SignerRegion>Region</Aws4SignerRegion>
      </Aws>
    </AuthenticationMethod>

Full config available at the README.md

Hello @urielha and thanks for your reply! ( also on behalf of jacob, as we're co-workers :) ) we got it working!
I got another question if I may, how can we send only logs who's log level is ERROR ? I couldn't realize it from the readme.

Hi sorry for the late answer,
Unfortunately in that case the logs will be lost.
From what I remember it can also consume more RAM (about CPU I don't think so, but if you don't use the async option it can also make your app slower since each request is getting a timeout).
You can control that a little by changing the timeout to lower number and playing with the bulk size.
At last, I added new parameter called DropEventsOverBulkLimit it basically throwing new log messages if the bulk is full (normally a new bulk object will be opened and this is what induced extra RAM usage).
The DropEventsOverBulkLimit is a bit tricky, I can assist you more with it if needed.


haz issu

من هضم را انستال کردم ولی هنوز هم برای من ایرر میدهد که هضم را نمی شناسد اگر لطف کنید همکاری کنید
nazifa@nazifa-Inspiron-3542:~$ sudo pip install hazm
[sudo] password for nazifa:
The directory '/home/nazifa/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/nazifa/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Requirement already satisfied: hazm in /usr/local/lib/python2.7/dist-packages
Requirement already satisfied: libwapiti>=0.2.1 in /usr/local/lib/python2.7/dist-packages (from hazm)
Requirement already satisfied: nltk==3.0.5 in /usr/local/lib/python2.7/dist-packages (from hazm)
Requirement already satisfied: six in /usr/lib/python2.7/dist-packages (from libwapiti>=0.2.1->hazm)
nazifa@nazifa-Inspiron-3542:~$ python
Python 3.6.3 |Anaconda, Inc.| (default, Oct 13 2017, 12:02:49)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

import hazm
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'hazm'

سلام
شاید pip یک پایتون دیگه رو داره استفاده می‌کنه. لطفا با این دستور نصب کنید:
sudo python -m pip install hazm

از شما ممنونم☺
درست شد
On Sat, Aug 4, 2018, 10:10 PM Alireza Nourian<EMAIL_ADDRESS>wrote:

سلام شاید pip یک پایتون دیگه رو داره استفاده می‌کنه. لطفا با این دستور نصب
کنید:
sudo python -m pip install hazm
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sobhe/hazm/issues/131#issuecomment-410465820, or mute
the thread
https://github.com/notifications/unsubscribe-auth/An9P77irroRzrcyTvXHhYIpGc4uoKiJGks5uNdymgaJpZM4VmFXs
.


Add notes on DirAccess documentation

Some notes are ported from FileAccess (for example file_exist) Other notes were added when needed (for example when included on the non static version but not on the static version) Other entirely new notes were added as well when required for example when getting a list of directories or if a directory exist or not
Clarified note at the top and made it more in line with the one found in file access

Some of the notes are because of https://github.com/godotengine/godot/issues/99047 and similar issues. As shown in the minimum reproduction project the directories can just not exist inside the .pck file in some edge cases, and at the same time (like for FileAccess) files may not be included as well! These clarifications should make things more clear while in the editor, since although some were just copy and pasted from elsewhere, it will be easier for people using the engine to debug.

Holy- you're fast LOL I was typing an addendum and saw you add the tags while I was about to press comment @>@ thanks for the review @Calinou

:D radiant also helped me with some formating on the discord as well! Wanted to mention it since I'm not too familiar with adding them as a contributor on github

Just accepted and squashed most of those changes (I asked around just now and also personally think differ sounds better in this context than be different so that was the only one I didn't accept) @Mickeon

There we go :D all neat and consistent now ✨

Thanks!


TEIIDTOOLS-731 changing image name to syndesis-dv

See also https://github.com/syndesisio/syndesis/pull/6374

The syndesis changes were merged as well.


VRVU-30:Remove Others on the registration page

PR  : https://sd-vxnaid.atlassian.net/browse/VRVU-30

cc @pwargulak

Looks good, i will test this and merge it in today. Hope its not blocking you.

Fixed Already.


Uses deprecated APIs

Google Page Insight score is 92/100 due to the following error Event.path is deprecated and will be removed. Please use Event.composedPath() instead.
I can see this has been fixed on Build.IO's Github (Link Below), but hasn't been implemented into the Nuxt version.
https://github.com/BuilderIO/partytown/pull/328
Is there a possible work around for now , any and all help would be appreciated.
Thank you.

You should just need to run npm upgrade or equivalent as the fix is in 0.7.4 of the upstream library, which is within the version constraint of this module.


critical files saved in tmp folder

As below screenshot, all critical files of SwiftR are saved in tmp folder, will it be cleaned up by user or iOS?

It's currently up to iOS, but it's probably a good idea to do any cleanup proactively. FWIW, writing to the temp directory is a workaround for a WKWebView limitation on iOS 8. There's no need to do this on iOS 9. Not sure yet about Mac OS X 10.11, but I'll check.
Do you have an opinion on how/when the cleanup should happen?

Actually I don't want to do cleanup. I'm just worried that it may be cleaned up by user or by iOS, then SwiftR will be broken?


Update people to include github handles

Since we interact a lot in official capacities on GitHub, and our usernames are not always easy to guess, I've added the usernames to the official governance documents.

LGTM.

LGTM


[DO NOT MERGE] Missions: ignore waypoint yaw when avoidance is active

@dagar  @LorenzMeier @thomasgubler
This is a sketch of  what we discussed in the dev call. If the avoidance is active and healthy the flag _waypoint_yaw_reached  is always set to true.

General question - why should we disregard yaw when in avoidance mode?

@mhkabir The navigator usually checks whether the aircraft arrives in the direction from the previous mission item. When in avoidance mode, this is not necessarily true, because there may have been a detour that causes it to fly along a path other than the straight line connecting the two mission items

@nicovanduijn Can you test this? I think you were the one that could reproduce the error symptoms most consistently.

I'll test this, but cherry-picked onto #9270, since anything else doesn't make sense (If you're not flying OA in mission mode, this has no effect)

Since #9270 got merged, I have rebased this PR on top of master

I have added he proposal from last week dev call:
If the vehicle projected position on the vector previous-current triplet is past the current triplet or if no progress towards the goal is made for 10 seconds, _waypoint_position_reached is set to true which forces the triplet update.
This is a proposal to start the the discussion.

Closing this PR, because the final solution will be based on #10037 . The decision to update the triplet will be take in the position controller and feed it back to navigator thorough uORB.


Parse Sass @for loop

I am attempting to create KSS markup with a grid system (e.g.
Test
 where '##' is some number). The scss file includes a @for to generate each of the possible grid ##'s. When I try to run the gulp tasks, I get an 'undefined' and failed styleguide creation. What am I doing wrong?
e.g.
// Grid
//
// This is a grid
//
// markup:
//

//

// Hello
//

//

//
// Styleguide 1.0
... other scss here
@for $i from 1 through 40 {
.grid-#{$i} {
display:flex;
flex: 0 0 $large-square * $i;
}
}

Try to use the current master and you should see a more specific errror notice

I'm interested in knowing what the issue is.
@dsln could you post the debug when you found it?

Unfortunately our team moved away from SC5 and made our own solution - I will not be able to reproduce.  Closing the issue.

Ok. Thank you anyway ;)


Exported files are corrupt

Where?  All?

I was in the Recurring Events tab. Didn't think to check anywhere else
considering that this is new right after the updates.
On Wed, Jan 11, 2023, 8:27 PM Shark @.***> wrote:

Where? All?
—
Reply to this email directly, view it on GitHub
https://github.com/sharkbit/BadgeApp/issues/242#issuecomment-1379693859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAZBWBQJE72ZGMFLFEPFEDWR5MZXANCNFSM6AAAAAATXP542I
.
You are receiving this because you were assigned.Message ID:
@.***>

Composer update resulted in PHP solving this problem


Added CHANGELOG.md and version bump v0.2.0

Added changelog for ryu-js
bump version from 0.1.0 to 0.2.0

I made the jump from 0.1.0 to 0.2.0 because it is not just a patch, this version introduces ECMAScript compliant f32 to string conversions, like v0.1.0 introduced f64 conversions.
I don't like the way bug #2 is repeated so many times but I also want to say what has been fixed, should I compact it into one bug fix?

I don't like the way bug #2 is repeated so many times but I also want to say what has been fixed, should I compact it into one bug fix?

I think so, yes. It would look better, even if you maybe add a sub-list there.

@Razican added a sub-list to BUG #2, I think it looks better, what do you think?

@Razican, I added a sub-list to BUG #2, I think it looks better, what do you think?
Edit: Here is a preview https://github.com/boa-dev/ryu-js/blob/changelog/CHANGELOG.md

Yep!


#7190 display name link fixed in pipelines.md

Resolves #7190
Changes
The displayName link in pipelines.md had wrong referrence, so I pointed it to the correct one.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind documentation

/lgtm

/ok-to-test
/lgtm


Add script to generate YT descriptions

[x] CLI - allow single video
[ ] Work with playlistId field in tracks

Usage:
npm run yt-desc [path/to/index.json] # path must not start with `content/videos`

Examples:

npm run yt-desc
npm run yt-desc noc/2-forces/4-drag-force
npm run yt-desc challenges/52-random-walker

The generated txt files are saved in _descriptions.

The script parses each and every track file and video file, even to generate just one description. This is done to get other information, such as:

Playlist URL
Previous/Next Video
YT Links to other videos which have relative URLs

@dipamsen sorry i messed something up merging with main to use this script for the WFC video. It worked great!
Noting I would like to add the following to the template:
Editing by Mathieu Blanchette
Animations by Jason Heglund
Music from Epidemic Sound

@shiffman added it and marked ready to review in case you want to merge!

Hey! So the new website has more generic categories for groups of links than the old system which only had "links" and "videos". See the WFC page for how a video with a lot of different kinds of references can be organized! So I think something like the following that generates a block of links for each group would make more sense for this script:
  for (let group of data.groupLinks) {
    description += `\n${group.title}:\n`;
    for (const link of group.links) {
      const url = link.url;
      if (/https?:\/\/.*/.test(url)) {
        // Starts with http:// or https://
        description += `${link.icon} ${link.title}: ${url}\n`;
      } else {
        // assume relative link in thecodingtrain.com
        description += `${link.icon} ${link.title}: https://thecodingtrain.com${url}\n`;
      }
    }
  }

Let me know what you think! I can make this adjustment directly but wanted to check with you first!

That looks amazing! Added this, and also added some fallback default emojis to support old videos which might not have emojis.

Wow! I think it's time to merge this and then we can make further updates or changes as needed! I'm not sure why the checks are failing though, any ideas? The tests pass running this branch locally, here's what the Netlify logs say, but I can't make sense of it. I'll try "clear cache and retry" again.

I have no clue about the error, but it is not specific to this PR as the same error is on #291 which is just a normal coding challenge porting.

Seems like the checks are passing now 🎉

Going to merge this now so we have it to use in main! We can open new issues and make updates as necessary later, thank you!


Disable Container domain? OrbStack helper

I'm using https://warden.dev/ to manage my projects locally, and since the "Container domain" was introduced, I cant access my custom domains anymore (https://magento2.dev), but this is still accessible via https://nginx.magento2.orb.local/ which is not what I want to.
How can I disable this feature?

OrbStack's automatic domains won't affect anything that you set up manually, so please run the command @slinorb sent for debugging.


store.on(event ... should replace previous reducer for that event

Is it done?

0.18.3 didn't do anything, that's what happened, no joy: https://effector.now.sh/try
Reportedly it's going to success 🙂


Tests are failing in Travis-CI builds and code coverage has declined to 75%

I just fixed a break in the test script which was introduced in commit db61dcfa29cd2c2174bbf43361719b3072f2e9b5 which prevented tests from running properly. In fact, it was preventing tests from running at all and a few failures have been introduced since then (see https://travis-ci.org/userimpersonate/user_impersonate2/jobs/340313007):
UserImpersonate::ImpersonateControllerTest#test_configuration_to_use_a_different_model_than_User:
NoMethodError: undefined method `mock' for #<UserImpersonate::ImpersonateControllerTest:0x00000004835c80>
    actionpack (5.1.3) lib/action_dispatch/testing/assertions/routing.rb:175:in `method_missing'
    /home/travis/build/userimpersonate/user_impersonate2/test/functional/impersonate_controller_test.rb:43:in `block in <class:ImpersonateControllerTest>'

UserImpersonate::ImpersonateControllerTest#test_create_should_require_authentication:
ArgumentError: unknown keyword: use_route
    actionpack (5.1.3) lib/action_controller/test_case.rb:457:in `process'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:33:in `block in process'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:100:in `catch'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:100:in `_catch_warden'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:33:in `process'
    actionpack (5.1.3) lib/action_controller/test_case.rb:392:in `get'
    /home/travis/build/userimpersonate/user_impersonate2/test/functional/impersonate_controller_test.rb:10:in `block in <class:ImpersonateControllerTest>'

UserImpersonate::ImpersonateControllerTest#test_index_should_require_authentication:
ArgumentError: unknown keyword: use_route
    actionpack (5.1.3) lib/action_controller/test_case.rb:457:in `process'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:33:in `block in process'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:100:in `catch'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:100:in `_catch_warden'
    devise (4.3.0) lib/devise/test/controller_helpers.rb:33:in `process'
    actionpack (5.1.3) lib/action_controller/test_case.rb:392:in `get'
    /home/travis/build/userimpersonate/user_impersonate2/test/functional/impersonate_controller_test.rb:5:in `block in <class:ImpersonateControllerTest>'

UserImpersonate::ImpersonateControllerTest#test_configuration_uses_default_model_User:
NoMethodError: undefined method `mock' for #<UserImpersonate::ImpersonateControllerTest:0x000000046db240>
    actionpack (5.1.3) lib/action_dispatch/testing/assertions/routing.rb:175:in `method_missing'
    /home/travis/build/userimpersonate/user_impersonate2/test/functional/impersonate_controller_test.rb:20:in `block in <class:ImpersonateControllerTest>'

etc.
Furthermore, code coverage has declined from 90% to 75% over the same period.

In RSpec mock has been removed in favour of double.

I've fixed up a few things but have commented some tests out since these will require more effort to fix (and I'm short on time at the moment).


Include isolated tier in the supported tiers for backup

Please update the "Requirements and restrictions" section to include isolated tier (ASE) also. Isolated tier supports backup as per the other documentation:  https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#app-service-limits
Regards,
Deepu

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4754bcfc-204a-d398-6b86-e452cd0d44a1
Version Independent ID: 157885c4-2579-8f98-1e85-c3063a861207
Content: Back up an app - Azure App Service
Content Source: articles/app-service/manage-backup.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@desreela, Thanks for the feedback! We are taking a look into this and will get back to you soon.

@desreela, We have created PR with the requested changes and to be merged soon after author's review. Again, this a good feedback, thanks for taking time to share your feedback.
We will close this out, but if you feel you need more information please just let us know.


[Question]What's the difference between response.body() and object returned by the callback?

Hi,
From Spark documentation:
response.body("Hello");        // sets content to Hello

And from Route:
 @return The content to be set in the response

So what's the difference? Could someone explain to me pls?

Not much difference, Use returns for easier to read code.


Auto logout of inactivity

Do we have the auto logout function in place? I left the platform window open of 12 hours with no activity and it seems to me there is no automatic inactivity logout.

I can confirm it's not in place right now


[cppcoro] Missing system library when linking

Is your feature request related to a problem? Please describe.
cppcoro itself builds fine in vcpkg. After specifying to link against this library, most fundamental features of this library are usable, but when using some of the synchronization primitives there're unresolved symbol errors output by the linker. Apparently cppcoro uses Win32 API for some of its functions (like schedule_after) on Windows, but the target itself doesn't link to those libraries. After manually adding linking options to several system libraries like synchronization.lib the user code builds fine, but I think it should not be the case that I have to manually link against those libraries.
Proposed solution
The cmake target of cppcoro should propagate those system libraries to consumers of the library.

Hi @Chlorie
Thanks for post this issue.
I try to use the function schedule_after to build in cmake project and there are no any errors.
So could you please provide your project case and post the error info that you met?
My project like this:
main.cpp
#include <cppcoro/task.hpp>
#include <cppcoro/io_service.hpp>
#include <cppcoro/sync_wait.hpp>
#include <cppcoro/when_all.hpp>
#include <chrono>

cppcoro::task<> sleep_some(cppcoro::io_service& service)
{
  using namespace std::chrono_literals;
  co_await service.schedule_after(1s);
}

cppcoro::task<> do_thing(cppcoro::io_service& service)
{
  co_await sleep_some(service);
  co_await sleep_some(service);
}

int main()
{
  cppcoro::io_service service;
  std::thread ioThread{ [&] { service.process_events(); } };
  cppcoro::sync_wait(do_thing(service));
  service.stop();
  ioThread.join();
  return 0;
}

CMakeLists.txt
cmake_minimum_required (VERSION 3.8)
set(CMAKE_CXX_STANDARD 17)
find_package(cppcoro CONFIG REQUIRED)
add_executable (test "main.cpp")
target_link_libraries(test PRIVATE cppcoro)

Oh sorry I didn't recall it correctly, my fault.
My CMake projects using cppcoro was building correctly. It was an MSBuild project that uses cppcoro which reported linking error, saying that some symbols like WSAStartup were missing. Apparently it didn't pull in the required Ws2_32.lib.
Sorry for the misinformation...

Thanks for your above details. Currently, there is no ws2_32.lib in vcpkg. We need to add it into system library. Please see #9840.
synchronization.lib is the same case with ws2_32.lib.
So we need to add the link manually to solve this issue in MSBuild project.
Let's track this issue in #9840. I'm closing this issue for now.


environment_creation_failed

help!    when i build release and run .exe   on win10家庭中文版20H2.

Does it fail in release mode only?

Thanks.
Neither can debug.
I copy debug and release to a new computer without a flutter environment, and then prompt the error.
What should I do？

Install the WebView2 runtime.

Is it possible to package the WebView2 runtime into an release package for all customers to use?

Sure, you need to create a proper installer. But this is beyond the scope of this plugin.


Is it possible to realize advanced routing

Hi,
Giraffe looks really promising :).
I just wonder if it possible to realize a dynamic routing that allows to browse through directories.
E.g. a pattern like /browse/<some generic pattern that allows paths> that extracts the path dir1/dir2/dir2/file.ext from the request /browse/dir1/dir2/dir2/file.ext.
NancyFX for example supports regex pattern in URL templates.

Hi, if I understand your question correctly then I believe you should be able to use routef . Please have a look and let me know if that is what you were looking for otherwise maybe you can show me a little sample in Nancy so I can fully follow what you are after :)

Hi @JanDotNet did my previous answer help you or did were you looking for something else?

Hey dustinmoris,
thanks for the fast response. I didn't checked the actual behavior, but my understanding from the documentation is, that routef allows to define routes of fixed length with typed values.
For example:
/browse/%s/%s matches /browse/dir1/dir2
/browse/%s/%s/%s matches /browse/dir1/dir2/dir3
My question was: Is it possible to define one route that matches both of the examples above and other paths with more directories?
NancyFX for example provides so called RegEx Segments for defining routes: https://github.com/NancyFx/Nancy/wiki/Defining-routes
Something like browse^(?<path>((/(\w|\d|\s)+)*)/?)$ would do it in NancyFX.
Hopefully this question is better explained than my initial one ;)

Hi,
In theory this is still possible with routef. Here's an example:
let browseHandler (path : string) =
    fun (ctx : HttpContext) ->
        text path ctx

let webApp =
    choose [
        GET >=>
            choose [
                route "/" >=> text "Hello world"
                routef "/browse/%s" browseHandler
            ]
        setStatusCode 404 >=> text "Not Found" ]

The path variable in the browseHandler is greedy enough to capture everything that is followed by /browse/ in the path.
e.g.:
http://localhost:5000/browse/dir1/dir2/file.txt will return dir1/dir2/file.txt and http://localhost:5000/browse/a/b/c/d/e/f/g will return a/b/c/d/e/f/g.
Inside the browseHandler you can further process the path as much as you like, e.g.:
open System.Text.RegularExpressions

let browseHandler (path : string) =
    fun (ctx : HttpContext) ->
        let pattern = "" //Define your pattern here
        let result  = Regex.Match(path, pattern)

        match result.Success with
        | false -> async.Return None
        | true  ->
            // Do something before returning a successful response
            text path ctx

In this example I simply return None if the path didn't match a custom pattern which means that this handler didn't match the request and another handler will try to process this request in the pipeline.

If this is a recurring thing then you might as well turn this handler into a more re-usable handler which you can plug into your pipeline. For example like this:
open System.Text.RegularExpressions

let browseHandler (customRegexPattern : string) (path : string) =
    fun (ctx : HttpContext) ->
        let result  = Regex.Match(path, customRegexPattern)
        match result.Success with
        | false -> async.Return None
        | true  -> async.Return (Some ctx)

let webApp =
    choose [
        GET >=>
            choose [
                route "/" >=> text "Hello world"
                routef "/browse/%s" (browseHandler "<custon-regex>") >=> text "Regex match 1"
                routef "/browse/%s" (browseHandler "<another-custon-regex>") >=> text "Regex match 2"
            ]
        setStatusCode 404 >=> text "Not Found" ]

or after evaluating that the path is correct you can pass the path on to a new http handler which will do something with it only on a match:
open System.Text.RegularExpressions

let browseHandler (customRegexPattern : string)
                  (successHandler     : string -> HttpHandler)
                  (path               : string) =
    fun (ctx : HttpContext) ->
        let result  = Regex.Match(path, customRegexPattern)
        match result.Success with
        | false -> async.Return None
        | true  -> successHandler path ctx

let doSomething (path : string) =
    fun (ctx : HttpContext) ->
        text path ctx

let webApp =
    choose [
        GET >=>
            choose [
                route "/" >=> text "Hello world"
                routef "/browse/%s" (browseHandler "<custon-regex>" doSomething)
            ]
        setStatusCode 404 >=> text "Not Found" ]

Giraffe is extremely flexible. You can compose http handler functions as much you like to fit your custom needs. If you need some further help please let me know!

I'll close this issue, because I haven't heard back since my last answer. If there's anything else you would like to discuss feel free to re-open it.


Support for ORC file

Hello,
Is there a plan to add support for ORC file?
https://github.com/awslabs/aws-data-wrangler/blob/4b9f27023057c359860669e44607c0825e08bf7b/building/lambda/build-lambda-layer.sh#L34
Thanks!

PyArrow's support for ORC is still limited at the moment compared to other formats so we don't have it part of the roadmap at the moment

PyArrow's support for ORC is still limited at the moment compared to other formats so it's not part of the roadmap

@jaidisido: Curious what ORC functionality in particular are you missing in pyarrow?
We use pyarrow + ORC/Athena in prod without any issues.


Fix the implicit glob key so that recursive keys are not differing just directory separator for wildcard directory

Fixes #49078

@RyanCavanaugh @andrewbranch do we feel alright picking this into 4.7?
I'll kick off a cherry-pick in the meantime.
@typescript-bot cherry-pick this to release-4.7


Format on Save is not working

Recently I noticed that having Format on Save turned on wasn't formatting files whenever I saved them. I can confirm that manual formatting works via selection or whole document (Edit.FormatSelection and Edit.FormatDocument) but having format on save seems to have no effect.
VS Info:

Visual Studio Enterprise 17.3.4
ClangPowerTools version: <IP_ADDRESS>4
Format settings; style=file, Fallback style=none, Format on save=on

Let me know if you need any additional information.
Update
Upon more research, it appears that this issue is not exclusive to this extension, and was caused by an update to Visual Studio itself. I'm going to leave what I've found here in case it helps someone come up with a solution (or put more pressure on VS devs to fix it).
Based on this and reading through the tickets linked to this issue, it appears that the problem may have been introduced as early as 17.3.0. According to the logged issues, it seems that VS changed the order of execution on saving files. Specifically, it appears that VS is saving the file before sending the event that Format Document on Save (and I'm guessing Clang Power Tools) rely on to format the file. This issue appears to be inconsistent in prior versions of VS, which I can certainly attest to as it would randomly fail to format on occasion, but it is completely broken in 17.3.4. I don't know if there is a way to fix this, but I figured I'd link the issue here. For what it's worth, the author of Format Document On Save also linked this issue in the developer community for VS.

Hi @marovira,
Thank you for reporting this issue, and for your feedback.
We working on a fix
Best regards,
Marina

Hi @marovira,
We found a fix, but it is in the testing phase, you can use this pre-release until then.
https://github.com/Caphyon/clang-power-tools/releases/tag/v9.2.1
Regards,
Marina

Hi @mariru27,
Thanks a lot for the quick fix! I just tested it and it works perfectly.
Cheers,
Mauricio


Proxy to https site error: HPE_INVALID_CONSTANT

I need proxy http request to an https site on the localhost. My proxy config is as below.
  proxies: [{
    context: '/gateway',
    host: 'localhost',
    port: 8443,
    https: true,
    secure: false,
    rewrite: {
      '^/gateway': ''
    }
  }],

Start server with grunt -dv serve, access http://localhost:9000/gateway/oauth/authorize using browser, grunt outputs Proxy error: HPE_INVALID_CONSTANT, details as below:
[WS] Catching upgrade event...
Proxied request: /gateway/oauth/authorize -> https://localhost:8443/oauth/authorize
{
  "host": "localhost:9000",
  "user-agent": "Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0",
  "accept": "application/json",
  "accept-language": "en-US,en;q=0.5",
  "accept-encoding": "gzip, deflate",
  "dnt": "1",
  "connection": "keep-alive"
}
>> Proxy error:  HPE_INVALID_CONSTANT

The error message in my local https site is http: TLS handshake error from <IP_ADDRESS>:57550: tls: first record does not look like a TLS handshake. It seems like that the proxy dosen't use SSL to connect to the target server.
EDIT: grunt-connect-proxy version is 0.2.0, installed by:
$ npm install grunt-connect-proxy --save-dev
<EMAIL_ADDRESS>node_modules/grunt-connect-proxy
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

It works well if installed from github, which is the same version as the previous one.
$ npm install git+https://github.com/drewzboto/grunt-connect-proxy.git --save-dev
<EMAIL_ADDRESS>node_modules/grunt-connect-proxy

├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

+1 Same issue tested on 9/21

It should also work if we install the package not from github. Does anyone know what the problem is?

@snajo IMO, this can be fixed by updating NPM package. With the same version, NPM package has different source code from github.

Sure, but in my opinion this isn`t a solution if you are behind a firewall which blocks requests against github. The new source code should deployed to npmjs.org with a increased version number.

@snajo I agree.

I´ve the same problem here. It only works if I use "npm install git+https://github.com/drewzboto/grunt-connect-proxy.git --save-dev". Is there any fix available?


Use piped.video instead of main piped instance

This should fix  #2171
Title

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the CONTRIBUTING document
[ ] I have read the  CORE VALUES document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Do you know if this instance is also getting an update anytime soon? Maybe we should add authentication when making calls to the main piped instance instead of changing the instance.


UtahFS request rate & retries

Hi,
I'm using UtahFS with Scaleway S3 service.
Sometimes I got errors like this :
2020/10/12 15:23:51 local_wal.go:93: ServiceUnavailable: Please reduce your request rate.
status code: 503, request id: tx3b4bf240a63a479a9a0cd-005f8458be, host id: tx3b4bf240a63a479a9a0cd-005f8458be
My S3 provider limits request to 250 per second per bucket. They don't want to set higher limits.
Does UtahFS handle such case ? Will requests be retried later if some failed ?
Thank you.

Yes, requests will be retried later. If the error messages themselves are the issue and you've set the wal-parallelism value higher than 1, you could reduce it to lower the request rate.


Hotkey to toggle full page Preview?

I just discovered your extension and its great support of markdown.
Is there a way to set a hotkey to toggle a full-page preview?  Essentially, the equivalent of running the command "Markdown: Open Preview".
I'm switching from another extension preview-vscode which hotkey's this and it's become part of my workflow.   However, their Markdown rendering is lacking, so I'm trying to switch to your extension.
Let me know if I'm overlooking something, or if its a feature you would need to add.

If you only want to open the preview, then ctrl+shift+v/ctrl+k v is the hotkey.
If you also like to close the preview using the same hotkey, #86 is the request (You already found it).

Please refer to #86 and try the beta version


ReferenceError: Buffer is not defined

hello, looks like there is a regression bug with the 3.0.0 update.
This happens with passing a PDFImage into the image function like in the example.

Hey, thanks for all your help.
You run the package not on nodejs, right?

I use Nuxt3 to run in the browser.


Litecoin wallet fails

Background
I can run LND on LITECOIN mainnet, i can create wallet, but after that i cannot access to the wallet.
Your environment

version of lnd: v0.13.3-beta
which operating system: docker,linux
version of litecoind: v0.18.1
******** litecoin.conf**********
server=1
txindex=1
rpcbind=<IP_ADDRESS>
rpcallowip=<IP_ADDRESS>/0
rpcport=9332
rpcuser=******
rpcpassword=******
zmqpubrawblock=tcp://<IP_ADDRESS>:39000
zmqpubrawtx=tcp://<IP_ADDRESS>:39001

Steps to reproduce
Run LND on litecoin mainnet try to check wallet balance:
lncli --chain litecoin --network mainnet walletbalance
Expected behaviour
get wallet balance
Actual behaviour
i get en error:
[lncli] rpc error: code = Unknown desc = failed to retrieve account public key: unsupported net Unknown BitcoinNet<PHONE_NUMBER>)

Just discovered that this happen since v13.0 in version v12.0 it works. Do you plan to remove LTC support?

The culprit for this error message: https://github.com/btcsuite/btcwallet/blob/master/waddrmgr/scoped_manager.go#L2307

I still see this error after updating to 0.14.0

The value<PHONE_NUMBER> is the magic number/identifier corresponding to the litecoin network.  That number appears in the error message:
[lncli] rpc error: code = Unknown desc = failed to retrieve account public key: unsupported net Unknown BitcoinNet<PHONE_NUMBER>)

The error message indicates that the litecoin magic number is not recognized as such.  Instead, it appears to default to Unknown BitcoinNet.

:pray::pray::flushed::flushed: please fix it

I'm not sure btcwallet includes support for litecoin wallets.  I found a fork with litecoin support:
https://github.com/ltcsuite/ltcwallet
I am concerned this is non-trivial to integrate to support litecoin.  I am not familiar with the lnd internals, either.  But am I correct that this will require integrating a new wallet?

I do not think Litecoin wallet derivation is currently supported because Litecoin's HD wallet version numbers appear to not be present in scoped_manager.  In particular, I notice litecoin is not specified at all where these constants are defined:
https://github.com/btcsuite/btcwallet/blob/559f6eff0e52f7a617382eec0d0a41c835c0709f/waddrmgr/scoped_manager.go#L24
I found a reference for litecoin wallet derivation according to BIP32:
https://github.com/satoshilabs/slips/blob/master/slip-0132.md
In general, litecoin's parameters are defined here:
https://github.com/litecoin-project/litecoin/blob/master/src/chainparams.cpp#L137
I think HD wallet derivation, including the version number, can be inferred from these parameters.

Hi @Roasbeef - I wanted to ask an organizational question.  I saw you added this issue to milestone 0.14.0 but that tag was already released - and so was 0.14.1.  Would it make any difference, organizationally, if this issue were reassigned to one of the upcoming milestones like 0.15.0?

Although I believe the "right" solution would be to link a wallet provider library - and the btcsuite wallet provider is a good one - would it be possible to support litecoin with a simple shim or wrapper on top of btcwallet?  As far as I can tell, the litecoin implementation would be mostly compatible, as it is.  The primary challenge, then, is for a shim to recognize the litecoin magic numbers for mainnet, testnet, etc.
Can anybody comment on this strategy?  I do foresee one issue with supporting M- addresses - but this is all beyond my current knowledge about the internals.  I'm just trying to facilitate.

Hi, happy new year. Any possibility to get LTC in next release?

Just see that ltcsuite create a forked version, it's RC2 but it works! https://github.com/ltcsuite/lnd

Be Advised no Admin or team will ever DM you or share you any link so you can only chat Here on Litecoin  support LIVE CHAT

Closing this issue, as LND will not be supporting LTC from 0.18 onwards.


Open Privacy Policy in external browser

Closes #165

I choose to open it using an external browser (instead of WebView) as the user will download a PDF and not read a webpage as such


api.py : no module named api.util

python3 main.py
Traceback (most recent call last):
File "/Users/arno/PhpstormProjects/oih-ui/api/api/main.py", line 14, in
from api.util.solr_query_builder import SolrQueryBuilder
ModuleNotFoundError: No module named 'api.util'
should this be api.api.util???

No, It probably should be a relative import -- see the readme in a PR to come in a minute.

should be ok by now as we could install this


Reset Model::$unset when a model is saved or refreshed

Fix #2708
Checklist

[x] Add tests and ensure they pass
[x] Add an entry to the CHANGELOG.md file
[x] Update documentation for new features

Hello @richardfila, thanks for working on this fix. Could you add a test case in ModelTest to prevent regression on this feature?

Thank you @richardfila


[Bug]: Using int type in knn function, core dumped.

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
7257da23
Other environment information
No response
Actual behavior
[12:02:59.510] [8724] [critical] Not implemented@src/function/table/knn_scan_data.cpp:74
Unrecoverable error issued, stop the serverShutdown infinity server ...
[12:02:59.549] [8724] [critical] Error: SEGMENT FAULTS
[12:02:59.550] [8724] [critical] 0, ./build/src/infinity(___interceptor_backtrace+0x75) [0x64121efb80a5]
[12:02:59.550] [8724] [critical] 1, ./build/src/infinity(+0x183a42e) [0x64122028d42e]
[12:02:59.550] [8724] [critical] 2, ./build/src/infinity(+0x5fd528) [0x64121f050528]
[12:02:59.550] [8724] [critical] 3, /lib/x86_64-linux-gnu/libc.so.6(+0x42990) [0x7ac12d042990]
[12:02:59.550] [8724] [critical] 4, ./build/src/infinity(+0x9e0ee2) [0x64121f433ee2]
[12:02:59.550] [8724] [critical] 5, ./build/src/infinity(+0x9e0ea5) [0x64121f433ea5]
[12:02:59.551] [8724] [critical] 6, ./build/src/infinity(+0x9bf2f5) [0x64121f4122f5]
[12:02:59.551] [8724] [critical] 7, ./build/src/infinity(+0xe1d179) [0x64121f870179]
[12:02:59.551] [8724] [critical] 8, ./build/src/infinity(+0x9a282e) [0x64121f3f582e]
[12:02:59.551] [8724] [critical] 9, ./build/src/infinity(+0x82b3be) [0x64121f27e3be]
[12:02:59.551] [8724] [critical] 10, ./build/src/infinity(+0x820685) [0x64121f273685]
[12:02:59.551] [8724] [critical] 11, ./build/src/infinity(+0x86a14e) [0x64121f2bd14e]
[12:02:59.551] [8724] [critical] 12, ./build/src/infinity(+0x25175d3) [0x641220f6a5d3]
[12:02:59.551] [8724] [critical] 13, ./build/src/infinity(+0x24d3b7c) [0x641220f26b7c]
[12:02:59.551] [8724] [critical] 14, ./build/src/infinity(+0x24ca6c1) [0x641220f1d6c1]
[12:02:59.551] [8724] [critical] 15, ./build/src/infinity(+0x25099da) [0x641220f5c9da]
[12:02:59.551] [8724] [critical] 16, ./build/src/infinity(+0x25093fe) [0x641220f5c3fe]
[12:02:59.551] [8724] [critical] 17, ./build/src/infinity(+0x250929d) [0x641220f5c29d]
[12:02:59.551] [8724] [critical] 18, ./build/src/infinity(+0x2509272) [0x641220f5c272]
[12:02:59.551] [8724] [critical] 19, ./build/src/infinity(+0x2509235) [0x641220f5c235]
[12:02:59.551] [8724] [critical] 20, ./build/src/infinity(+0x2508fe9) [0x641220f5bfe9]
[12:02:59.551] [8724] [critical] 21, ./build/src/infinity(+0x3db6943) [0x641222809943]
[12:02:59.551] [8724] [critical] 22, ./build/src/infinity(+0x5b8e9b) [0x64121f00be9b]
[12:02:59.551] [8724] [critical] 23, /lib/x86_64-linux-gnu/libc.so.6(+0x97b5a) [0x7ac12d097b5a]
[12:02:59.552] [8724] [critical] 24, /lib/x86_64-linux-gnu/libc.so.6(+0x1285fc) [0x7ac12d1285fc]
[12:03:00.469] [8660] [info] DELTA Checkpoint Txn txn_id: 1241, begin_ts: 2480, max_commit_ts 2478
[12:03:00.469] [8660] [info] SAVING DELTA CATALOG
[12:03:00.469] [8660] [info] Save delta catalog commit ts:2478, checkpoint max commit ts:2478.
terminate called without an active exception
Aborted (core dumped)

Expected behavior
No response
Steps to reproduce
Function test case can be found in python/test/test_knn.py `test_various_embedding_data_type`
please use `int` embedding_data_type to reproduce the bugs.

Additional information
No response

The current Python SDK does not support type conversion between different numerical types, which will make python side throw the exceptions. I think it's necessary to support the feature.

Issue the error message: "integer embedding element type hasn't been supported."

Fixed by #847 .

It looks fixed.


updating dependencies, fix: critical vulnerabilities

Update dependencies in:
/package.json
/server/package.json
/frontend/package.json

@cjchirag7 other than dependencies, npm run lint --fix changed a lot of files in the frontend, replacing var with const.
Please review


GetActiveTimers is not registered

It's missing {"GetActiveTimers", Natives::GetActiveTimers}, in PluginNatives.

since the initial version :confused:


Replace Typefaces with Fontsource

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Why? I use nohup to run jupyter in my remote server ,but I can't use tabnine in my local browser

The info told me I got the '500 Internal Server Error' and I installed the jupyter-tabine step by step the
pip3 install jupyter-tabnine --user jupyter nbextension install --py jupyter_tabnine --user jupyter nbextension enable --py jupyter_tabnine --user jupyter serverextension enable --py jupyter_tabnine --user

(related to Zendesk ticket #16528)

Sorry, I can't read this issue

This is the console info

I guess the remote tabine server does't start

Hi! Did you install the jupyterLab plugin too before? Sometimes both of them together can cause problems.


"Error outputting keys and certificates" when adding APNS notifications to Amplify

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v18.13.0
Amplify CLI Version
12.1.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
In my Flutter project I'm trying to add notifications with APNS. When I do this I get the following error message after giving the path to the .p12 certificate and writing the non-existent password (just pressing enter):
Error outputting keys and certificates
00DEF7DD01000000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()
🛑 Command failed: openssl pkcs12 -in /Users/joakimrosenfeldtpedersen/Certificates.p12 -out /var/folders/cy/n2b5gjxj4dv1mztr65gpklgc0000gn/T/temp.pem -nodes -passin pass:
Error outputting keys and certificates
00DEF7DD01000000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()

Resolution: Please report this issue at https://github.com/aws-amplify/amplify-cli/issues and include the project identifier from: 'amplify diagnose --send-report'
Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/

Session Identifier: 72137838-7a44-4758-bd28-aa0766d0a711

✅ Report saved: /var/folders/cy/n2b5gjxj4dv1mztr65gpklgc0000gn/T/MellonnSpeakEU/report-1689771320910.zip

✔ Done

Project Identifier: 369c3e3e1f86cb7691bd7b7aef05de77

Expected behavior
Amplify notifications should be added to the project without any problems.
Reproduction steps

Create Flutter project and add Amplify to it.
Follow the official guide to add Notifications to said project.

Project Identifier
369c3e3e1f86cb7691bd7b7aef05de77
Log output

# Put your logs below this line
2023-07-19T12:53:29.435Z|info : amplify add notifications
2023-07-19T12:53:29.533Z|info : @aws-amplify/amplify-cli-core.banner-message/index.ts.fetch banner messages from https://aws-amplify.github.io/amplify-cli/banner-message.json({}
2023-07-19T12:53:31.250Z|info : amplify-provider-awscloudformation.system-config-manager.getProfileConfig(["MacBookPro2021Amplify"])
2023-07-19T12:53:31.252Z|info : amplify-provider-awscloudformation.system-config-manager.getProfiledAwsConfig.profileConfig([{"region":"eu-central-1"}])
2023-07-19T12:53:31.253Z|info : amplify-provider-awscloudformation.system-config-manager.getProfileCredentials(["MacBookPro2021Amplify"])
2023-07-19T12:55:23.323Z|error : Command failed: openssl pkcs12 -in /Users/joakimrosenfeldtpedersen/Certificates.p12 -out /var/folders/cy/n2b5gjxj4dv1mztr65gpklgc0000gn/T/temp.pem -nodes -passin pass:
Error outputting keys and certificates
00DEF7DD01000000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()

UnknownFault: Command failed: openssl pkcs12 -in /Users/joakimrosenfeldtpedersen/Certificates.p12 -out /var/folders/cy/n2b5gjxj4dv1mztr65gpklgc0000gn/T/temp.pem -nodes -passin pass:
Error outputting keys and certificates
00DEF7DD01000000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @JoakimMellonn, thank you for reaching. Could you let us know the openssl version currently installed by running openssl version.
Additionally, could you try directly running the openssl command in your terminal and let us know the output.
openssl pkcs12 -in /Users/joakimrosenfeldtpedersen/Certificates.p12 -out /var/folders/cy/n2b5gjxj4dv1mztr65gpklgc0000gn/T/temp.pem -nodes -passin <pass>.
Marking this as bug for error messaging improvements as I was able to reproduce a similar error message
🛑 Command failed: openssl pkcs12 -in /Users/abc/Downloads/cert.p12 -out /var/folders/7n/vtvskf9s3czf2429q2kv9yz00000gr/T/temp.pem -nodes -passin pass:
Mac verify error: invalid password?

This is the output from openssl version: OpenSSL 3.1.1 30 May 2023.
Regarding running the openssl command, but I'm getting some errors regarding the -passin <pass> part of it. Should I replace anything or is this to be expected?

Ah okay, I get the same error when doing it directly in the terminal.
Error outputting keys and certificates
00DEF7DD01000000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:341:Global default library context, Algorithm (RC2-40-CBC : 0), Properties ()

Hey @JoakimMellonn, thank you for the information. I was able to reproduce the issue using OpenSSL 3.1.1 30 May 2023.
When I switch to LibreSSL 3.3.6 the error does not occur.
This appears to be a issue with the SSL version, could try switching to LibreSSL 3.3.6 and let us know if the issue still occurs.
Making a note here for further investigation.
Working: LibreSSL 3.3.6
Not working: OpenSSL 3.1.1 30 May 2023

@JoakimMellonn reopening the issue for tracking this behaviour and provide better error messaging.

openssl pkcs12 -in Certificates.p12 -out apns_cert.pem -legacy -nodes
Above worked

These are the steps to switch libressl from openssl

brew install libressl

export PATH="/usr/local/opt/libressl/bin:$PATH" (you have to know where is your liberssl was downloaded and use that in your export)

The command to know where is your liberssl was is brew --prefix libressl

These are the steps to switch to libressl from openssl

brew install libressl
export PATH="/usr/local/opt/libressl/bin:$PATH" (you have to know where is your liberssl was downloaded and use that in your export)

The command to know where is your liberssl was is brew --prefix libressl

Note: true-glassy's answer resolves the issue for amplify add notifications (or amplify update notifications).


ListView separator line skips every other row

I am running "react-native": "0.43.4". I searched StackOverflow and found this post describing it as bug with only a hack fix.
Here is my style for the separator:
const styles = StyleSheet.create({
  separator: {
    flex: 1,
    height: StyleSheet.hairlineWidth,
    backgroundColor: '#8E8E8E',
  },
});

Here is my ListView:
  <ListView
            dataSource={this.state.dataSource}
           renderRow={(data) => <View><Text>{data.bb_first_name}</Text></View>}
            renderSeparator={(sectionId, rowId) => <View key={rowId} style={styles.separator} />}
          />

Here is how it renders:

Just out of curiosity, are you viewing the simulator at 100%? Anything less than that will cause hairline width details not to render correctly because of the downscaling

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

Thanks MyGuySi, that was it!

@agersoncgps No problem, it's caught me out a few times too!


[Bug][Master] The same scheduling task runs twice, causing data duplication

Describe the bug
The same scheduling task runs twice, causing data duplication
To Reproduce

The cluster has two workers and two masters
set up a scheduled task
run by time

Expected behavior
duplicate tasks
Screenshots
If applicable, add screenshots to help explain your problem.

Which version of Dolphin Scheduler:
-[1.2.0-preview]
Additional context

improvement
does this problem exist in 1.3.1 ?
thx

add config
org.quartz.jobStore.acquireTriggersWithinLock=true

add config
org.quartz.jobStore.acquireTriggersWithinLock=true

thx
添加参数之后解决了。


fix(timetable): apply change requests

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes #
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

Browsers
I tested the build on the following browsers:

[ ] Firefox Desktop
[ ] Chrome Desktop
[ ] Edge Desktop
[ ] Safari Desktop
[ ] Chrome Mobile
[ ] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Codecov Report

Merging #1612 (36d0b29) into master (ab917b0) will decrease coverage by 1.84%.
The diff coverage is 50.98%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
- Coverage   54.85%   53.02%   -1.84%
==========================================
  Files          49       79      +30
  Lines        1659     3559    +1900
  Branches      406      957     +551
==========================================
+ Hits          910     1887     +977
- Misses        671     1544     +873
- Partials       78      128      +50

Impacted Files
Coverage Δ

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

src/components/sbb-icon/sbb-icon.tsx
91.66% <ø> (ø)

src/components/sbb-image/sbb-image.helper.tsx
62.06% <ø> (-2.45%)
:arrow_down:

src/components/sbb-image/sbb-image.tsx
69.09% <ø> (+6.12%)
:arrow_up:

...mponents/sbb-journey-header/sbb-journey-header.tsx
88.23% <ø> (+1.27%)
:arrow_up:

...onents/sbb-journey-summary/sbb-journey-summary.tsx
80.55% <ø> (ø)

src/components/sbb-link-list/sbb-link-list.tsx
84.00% <ø> (-4.24%)
:arrow_down:

src/components/sbb-link/sbb-link.tsx
60.41% <ø> (-31.02%)
:arrow_down:

src/components/sbb-logo/sbb-logo.tsx
0.00% <ø> (ø)

src/components/sbb-menu-action/sbb-menu-action.tsx
65.21% <ø> (ø)

... and 85 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Proxies do not work

Can connect to the proxies, but cannot access anything through them

@lfcameron7 Your SSH information is invalid.


Document public key used for phar signing

Is your feature request related to a problem?
I want to install the phar with phive in CI. This means my script needs to run without user interaction.  For this I hard code the signing key that phive should expect when installing phpcs.
Describe the solution you'd like
Please document the key that is used to sign the phar in the README or some other obvious place in the documentation. Best would be any "install" section of the docs.
Additional context (optional)
If the key is not documented any user that installs the phar can just verify that it is signed with some key.  The problem is that we have no way of knowing that the key is the intended one.
This is the same argument why browser do not accept self signed tls certificates.

[ ] I intend to create a pull request to implement this feature.

What do you expect this documentation to contain ?

A comment like

The phars are singed with our official key: abcdef0123.
or so.

@theseer If you don't mind me asking - have you got any advise on what's best practice regarding the key documentation ?

From a security paranoid (tm) position, the most important aspect is to verify authenticity, e.g. publish the gpg key fingerprint on an unrelated medium - e.g. your website.
Since one cannot provide any interactive confirmation in CI to allow the import of a new public key to enable verification, it probably is a good idea to add the --trust-gpg-keys option as an example.

Also having an "install" section that also shows the expected output might be helpful, so an inexperienced user can follow it step by step and compare output.

From a security paranoid (tm) position, the most important aspect is to verify authenticity, e.g. publish the gpg key fingerprint on an unrelated medium - e.g. your website.
Since one cannot provide any interactive confirmation in CI to allow the import of a new public key to enable verification, it probably is a good idea to add the --trust-gpg-keys option as an example.

@theseer I followed the steps documented here when I created the key, so that means the key is available on https://keys.openpgp.org/
Am I correct in thinking that is what the --trust-gpg-keys is about ?
And, if I understand you correctly, I should also publish a phpcs.pub file on the http://phars.phpcodesniffer.com/ website ? Correct ?

Also having an "install" section that also shows the expected output might be helpful, so an inexperienced user can follow it step by step and compare output.

Consider me an inexperienced PHIVE user, so I'm probably not the best person to write that section. @lucc Would you be up for providing a text for this which I could add to the wiki ? Or for making some tweaks to the README section about PHIVE ?

From a security paranoid (tm) position, the most important aspect is to verify authenticity, e.g. publish the gpg key fingerprint on an unrelated medium - e.g. your website.
Since one cannot provide any interactive confirmation in CI to allow the import of a new public key to enable verification, it probably is a good idea to add the --trust-gpg-keys option as an example.

@theseer I followed the steps documented here when I created the key, so that means the key is available on https://keys.openpgp.org/ Am I correct in thinking that is what the --trust-gpg-keys is about ?

Yes, the key should be available on the aforementioned key server.
But no, --trust-gpg-keys is a means to bypass the manual confirmation step to import an otherwise unknown key as trusted. So you'd need to specify your key's ID here: phive install --trust-gpg-keys 0x12345678901234567890 foo.

And, if I understand you correctly, I should also publish a phpcs.pub file on the http://phars.phpcodesniffer.com/ website ? Correct ?

No, you should publish they Key ID (already implicitly done with the above call example) and the fingerprint. We, for instance, have that on our footer at phar.io.

Also having an "install" section that also shows the expected output might be helpful, so an inexperienced user can follow it step by step and compare output.

Consider me an inexperienced PHIVE user, so I'm probably not the best person to write that section. @lucc Would you be up for providing a text for this which I could add to the wiki ? Or for making some tweaks to the README section about PHIVE ?

Yes, the key should be available on the aforementioned key server. But no, --trust-gpg-keys is a means to bypass the manual confirmation step to import an otherwise unknown key as trusted. So you'd need to specify your key's ID here: phive install --trust-gpg-keys 0x12345678901234567890 foo.

@theseer thank you for your help! In PR #158, the key fingerprint is passed in the phive command, but I see you mention the ID here as a different entity. How would I go about figuring out what the ID is ? Or will the fingerprint work just as well ?


Logout button does not work

After successfully logging in via Github Oauth using my company's SSO provider and being redirected back to the Trac instance, clicking the "Logout" button returns the error: Missing or invalid form token. Do you have cookies enabled?
Relevant portion of the logs:
2023-02-12 21:45:30,231 Trac[main] DEBUG: Dispatching <RequestWithSession "POST '/github/logout'">
2023-02-12 21:45:30,231 Trac[main] DEBUG: Chosen handler is <Component tracext.github.GitHubLoginModule>
2023-02-12 21:45:30,232 Trac[main] WARNING: [<IP_ADDRESS>] HTTPBadRequest: 400 Bad Request (Missing or invalid form token. Do you have cookies enabled?), <RequestWithSession "POST '/github/logout'">, referrer 'https://<my_instance>/trac/admin/general/logging'

Running Trac 1.4.3 and trac-github 2.3.

Got hit by this after an update. This 4 line fix/hack seems to do the trick for me:
diff --git a/tracext/github/__init__.py b/tracext/github/__init__.py
index 0dddb2b..cc7b7c4 100644
--- a/tracext/github/__init__.py
+++ b/tracext/github/__init__.py
@@ -129,7 +129,10 @@ def get_navigation_items(self, req):
                 yield ('metanav', 'logout',
                        tag.form(tag.div(tag.button(_('Logout'),
                                                    name='logout',
-                                                   type='submit')),
+                                                   type='submit'),
+                                        tag.input(type='hidden',
+                                                  name='__FORM_TOKEN',
+                                                  value=req.form_token)),
                                 action=logout_href, method='post', id='logout',
                                 class_='trac-logout'))
         else:

Not sure if this project is maintained anymore (seems to be the case for a lot of plugins in the trac ecosystem), but if it is I'd be happy to submit a PR.

I'd be happy to review and merge this. I've never done a release, though.

I'd be happy to review and merge this. I've never done a release, though.

Thanks for the quick reply!
I'll work on this in the next few days (I'm trying to get the test suite to pass for now, I'm still unsure if the failures are related to my change or not).


finaly I18N added and many fixes

Add I18N to frombuilder
Edit translation files
many fixes models and migrations

thx


[Fix][UI Next][V1.0.0-Alpha] Fix the two hover prompts appear.

Purpose of the pull request
close #9332

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9333 (6463c97) into dev (c99b33a) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 6463c97 differs from pull request most recent head d1c5518. Consider uploading reports for the commit d1c5518 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9333      +/-   ##
============================================
- Coverage     39.98%   39.97%   -0.02%
+ Complexity     4375     4373       -2
============================================
  Files           822      822
  Lines         32921    32921
  Branches       3656     3656
============================================
- Hits          13163    13159       -4
- Misses        18528    18530       +2
- Partials       1230     1232       +2

Impacted Files
Coverage Δ

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

...er/server/master/runner/WorkflowExecuteThread.java
8.24% <0.00%> (-0.04%)
:arrow_down:

...erver/master/runner/WorkflowExecuteThreadPool.java
1.47% <0.00%> (+0.04%)
:arrow_up:

.../master/processor/queue/TaskExecuteThreadPool.java
2.27% <0.00%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99b33a...d1c5518. Read the comment docs.


Build(deps): Bump @tanstack/react-query from 5.24.7 to 5.28.14 (#5655)

Pull request opened by the merge tool on behalf of #5655

Merged in 30c0212eeb1d93a1a22565ad44b4196ead44ebc0


BK7231N QS-WIFI-C03 wifi gate garage opener

Hello again, sorry for such a flood...  third device today, fourth coming soon.
QS-WIFI-C03 wifi gate opener module.zip

Unfortunately, this firmware (oem_bk7231n_garage_door v1.1.2) is patched and not vulnerable to CloudCutter.  Serial flashing will be the only option for this model.


Update deploy-app.md

Removes an extra '.' in the path when copying the docker-stack.yml with scp

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Thanks, @barksten :)


chore: try using pytest-xdist and XS machines to speedup tests

Our tests use network a lot, so it makes sense to run them in parallel. E.g. now down to 5 minutes from seeing stuff as much as 29 minutes.

I'll merge for now to enjoy this in other PRs.


Implement Array Iterators in javascript

This change adds implementation of Javascript's array iterators in Javascript.
This combined with optimization of try finally functions and enabling inlining within functions have try-catch/try-finally improves performance of es6 for-of loops.

Commits on top of "Merge conflict errors " are new code. Previous commits have been reviewed before in the builtins branch.

Looks like, there are changes related to OS9049104

I have removed the bug fix at https://github.com/Microsoft/ChakraCore/pull/4051 from the PR's commits.


Extension Marked As Malicious

Hi you have probably been notified, but your extension seemingly included the event-stream npm package that had security issues.
https://code.visualstudio.com/blogs/2018/11/26/event-stream

Yes it is updated.  0.4.0 is published that shouldn't include the bad version of event stream.  Back dated event-stream to 3.3.4  #31

Unfortunately they still have it marked.  I'm trying to figure out how to get that removed.

<EMAIL_ADDRESS>from https://github.com/Microsoft/vscode/issues/33782

Thanks @iloveicedgreentea  -- we'll reach out to that email address!

Thanks for the quick response to an unexpected issue!

Took a little bit but the VsCode team got it rescanned and re-enabled last night.  We are available again.

Thanks for your quick help. Its a really helpful extension.

Thank you @sc-pulsion.  And I apologize for any inconvenience.


✨ [ENHANCEMENT] - Improve Navbar Responsiveness

Describe the Enhancement
The navbar can be improved when viewing it in mobile devices. The hamburger menu icon and the title should not collapse.
Current Behavior

Desired Behavior
We can improve the responsiveness of the website via code.
Labels
enhancement, feature-request

@Pinaka-Pani-18  Can I please be assigned to it for Hacktoberfest?

@Pinaka-Pani-18 Can I please be assigned to it for Hacktoberfest?

Hello @hanzalahwaheed  , this repo has been excluded from Hacktoberfest, but I'm not sure of the reason. I suspect it might have been reported. As a result, I have created the same project here. You can create an issue there, and you can comment on it and make the necessary changes. Afterward, you can create a PR.


Added .pyre/ for pyre-check

Cache and scratch-file location for the pyre-check static type-checking program
Pull Request
Thank you for contributing to @dvcs/gitignore and https://www.gitignore.io.
New or update
Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.
New

[ ] Template - New .gitignore template
[ ] Composition - Template made from smaller templates
[ ] Inheritance - Template similar to an existing template
[ ] Patch - Template extending functionality of existing template

Update

[x] Template - Update existing .gitignore template

Details
The pyre-check static type-checker, like mypy, uses a scratch dot-prefixed folder in the project’s root directory; this shouldn’t be checked into a project’s VC.

Having examined the output I am not at all sure why the Travis build is failing, in this case – if it’s something on my end I’ll fix it, just let me know what it is…

The build fails whenever you try and commit a change to a file that is managed by https://github.com/github/gitignore.  This was added as part of a check to make sure that the templates are kept in sync with GitHub's list even though the rules for adding to that list are restrictive.
If you want to amend something to their list, create a file called Python.patch and add these changes in there.

@joeblau Oof, my bad. I appreciate your explanation – I’ll fix it and push an update. Thanks!


Add API documentation for this repo

There are no description of what each API does
Example: https://github.com/microsoft/pxt-hacking-stem

https://forum.makecode.com/t/quick-tutorial-on-the-settings-namespace/1013


Reduce the usage of Windows.h, and add macros to slim Windows.h

Thrift requires the header "Windows.h" in a few places. This header can be problematic to include, i.e. when included in headers, because it can affect standard C++ code. This PR tries to reduce the effects of including Windows.h.

[ ] Did you create an Apache Jira ticket?  (not required for trivial changes)
[ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Build errors on Travis are unrelated. Merging.


Domain alias bug.

Old and buggy (src/grav/common/uri.php)
$root_path = str_replace(' ', '%20', rtrim(substr($_SERVER['PHP_SELF'], 0, strpos($_SERVER['PHP_SELF'], 'index.php')), '/'));
Works good for me
$root_path = str_replace(' ', '%20', rtrim(substr($_SERVER['REQUEST_URI'], 0, strpos($_SERVER['REQUEST_URI'], 'index.php')), '/'));
Before "http://MyDomain.tld/domains/MyDomain.tld/"
After "http://MyDomain.tld"
It appears one of the biggest Czech webhosting.
http://kb.wedos.com/cs/webhosting/aliasy-chybne-url.html

How about a PR?

What is PR? I am webdesigner. Not programmer. I can't log into administration after my change.

PR is "Pull Request" and means that you could submit a change / fix that will then most likely be accepted and added to the project

The change you suggest is completely breaking Grav for me.
Does this work for you?
$root_path = str_replace(' ', '%20', rtrim(substr($_SERVER['SCRIPT_NAME'], 0, strpos($_SERVER['SCRIPT_NAME'], 'index.php')), '/'));

Endogen: thanks for answer. I never did pull request. I am graphic designer.
flaviocopes: yes, my change is breaking Grav. Your code doesn't works for me. Same bug as before.
This is "/www/.htaccess" in root
RewriteEngine on

# cele domeny (aliasy)
RewriteCond %{REQUEST_URI} !^domains/
RewriteCond %{REQUEST_URI} !^/domains/
RewriteCond %{HTTP_HOST} ^(www\.)?(.*)$
RewriteCond %{DOCUMENT_ROOT}/domains/%2 -d
RewriteRule (.*) domains/%2/$1 [DPI]

# subdomeny (s nebo bez www na zacatku)
RewriteCond %{REQUEST_URI} !^subdom/
RewriteCond %{REQUEST_URI} !^/subdom/
RewriteCond %{HTTP_HOST} ^(www\.)?(.*)\.([^\.]*)\.([^\.]*)$
RewriteCond %{DOCUMENT_ROOT}/subdom/%2 -d
RewriteRule (.*) subdom/%2/$1 [DPI]

# aliasy - spravne presmerovani pri chybejicim /
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^domains/[^/]+/(.+[^/])$ /$1/ [R]

# subdomeny - spravne presmerovani pri chybejicim /
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^subdom/[^/]+/(.+[^/])$ /$1/ [R]

ErrorDocument 404 /chyba/404/404.php
ErrorDocument 403 /chyba/403.php

# 28t.cz
RewriteCond %{REQUEST_FILENAME} -f [NC,OR]
RewriteCond %{REQUEST_FILENAME} -d [NC]
RewriteRule .* - [L]
RewriteRule ^([\w-]+)$ /index.php?page=$1 [L,QSA]

Grav .htaccess is located in "www/domains/MyDomain.tld/.htaccess" and has default content

Is possible set base-url for CMS? Like Joomla or Wordpress can? http://www.joomace.net/support/docs/acesef/faq/live_site-variable-of-configurationphp
$_SERVER['PHP_SELF'] and $_SERVER['REQUEST_URI'] are not about URL... they are about physical adress on server.

It's currently not possible to set the base url.  If we discover any other situations where this would help, we'll revisit this.  For now, this has not been a problem and not something we plan on addressing any time soon.