oss_fuzz_checkout: avoid breaking on permission errors

Change from TemporaryDirectory to mkdtemp. TemporaryDirectory has a destructor that can fail, and the exception can't be caught. This fixes it as there is no destructor on the string returned by mkdtemp.

Difference in behaviour:
Before PR:
$ ./run_all_experiments.py --model=gpt-3.5-turbo --benchmarks-directory=./benchmark-sets/comparison2/
Running 2 experiment(s) in parallel.
Downloaded human-written fuzz targets of tinyxml2 from Google Cloud Bucket: oss-fuzz-llm-public.
Generating targets for tinyxml2 XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *) using gpt-3.5-turbo..
Generated:
 results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/raw_targets/01.cpp
 results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/raw_targets/02.cpp
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with address
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Running tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with address
Running tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with coverage
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with coverage
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with coverage
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with coverage
Successfully built /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp without LLM code fix.
Successfully built /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp without LLM code fix.
Warning: NO_COV_INCREASE in tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02.
Loading existing summary.json from tinyxml2/reports/20240328/linux/summary.json
Loading existing textcov from tinyxml2/textcov_reports/20240328/xmltest.covreport
Result for tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01: crashes=False, coverage=0.06469689251146205 (127/1963), coverage diff=0.020887728459530026 (56/2681)

**** Finished benchmark tinyxml2, XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *) ****
build success rate: 1.0, crash rate: 0.5, found bug: 0, max coverage: 0.06469689251146205, max line coverage diff: 0.020887728459530026
max coverage sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp
max coverage diff sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp
max coverage diff report: None

**** FINAL RESULTS: ****

================================================================================
*tinyxml2, XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *)*
build success rate: 1.0, crash rate: 0.5, found bug: 0, max coverage: 0.06469689251146205, max line coverage diff: 0.020887728459530026
max coverage sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp
max coverage diff sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp
max coverage diff report: None

WARNING:root:No permission to remove /tmp/tmp3ds95zp9
Traceback (most recent call last):
  File "/usr/lib/python3.10/shutil.py", line 662, in _rmtree_safe_fd
    os.rmdir(entry.name, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: 'tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/weakref.py", line 667, in _exitfunc
    f()
  File "/usr/lib/python3.10/weakref.py", line 591, in __call__
    return info.func(*info.args, **(info.kwargs or {}))
  File "/usr/lib/python3.10/tempfile.py", line 998, in _cleanup
    cls._rmtree(name, ignore_errors=ignore_errors)
  File "/usr/lib/python3.10/tempfile.py", line 994, in _rmtree
    _rmtree(name, onerror=onerror)
  File "/usr/lib/python3.10/shutil.py", line 725, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/usr/lib/python3.10/shutil.py", line 658, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/usr/lib/python3.10/shutil.py", line 658, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/usr/lib/python3.10/shutil.py", line 664, in _rmtree_safe_fd
    onerror(os.rmdir, fullname, sys.exc_info())
  File "/usr/lib/python3.10/tempfile.py", line 978, in onerror
    resetperms(_os.path.dirname(path))
  File "/usr/lib/python3.10/tempfile.py", line 974, in resetperms
    _os.chmod(path, 0o700)
PermissionError: [Errno 1] Operation not permitted: '/tmp/tmp3ds95zp9/build/work'

After PR:
(.venv) dav@ubuntu-main:~/code/2024/tosg2/oss-fuzz-gen$ ./run_all_experiments.py --model=gpt-3.5-turbo --benchmarks-directory=./benchmark-sets/comparison2/
Running 2 experiment(s) in parallel.
Downloaded human-written fuzz targets of tinyxml2 from Google Cloud Bucket: oss-fuzz-llm-public.
Generating targets for tinyxml2 XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *) using gpt-3.5-turbo..
Generated:
 results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/raw_targets/01.cpp
 results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/raw_targets/02.cpp
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with address
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with address
Running tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01
Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Fixing /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo, attempt 1.
Will use the longest fix: results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02-F1/01.rawoutput.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Fixing /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo, attempt 2.
Will use the longest fix: results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02-F2/01.rawoutput.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Fixing /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo, attempt 3.
Will use the longest fix: results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02-F3/01.rawoutput.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Fixing /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo, attempt 4.
Will use the longest fix: results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02-F4/01.rawoutput.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with coverage
Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Fixing /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo, attempt 5.
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01 with coverage
Successfully built /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/01.cpp without LLM code fix.
Warning: NO_COV_INCREASE in tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-01.
Will use the longest fix: results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02-F5/01.rawoutput.
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with address
Running tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02
********** Failed to run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02. **********
Building tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with coverage
Successfully run tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02 with coverage
Successfully fixed /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp with gpt-3.5-turbo in 5 iterations.
Warning: FP_CRASH_NEAR_INIT in tinyxml2-znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente-02.

**** Finished benchmark tinyxml2, XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *) ****
build success rate: 1.0, crash rate: 1.0, found bug: 0, max coverage: 0.0, max line coverage diff: 0.0
max coverage sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp
max coverage diff sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp
max coverage diff report: None

**** FINAL RESULTS: ****

================================================================================
*tinyxml2, XMLNode * tinyxml2::XMLElement::ShallowClone(XMLDocument *)*
build success rate: 1.0, crash rate: 1.0, found bug: 0, max coverage: 0.0, max line coverage diff: 0.0
max coverage sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp
max coverage diff sample: /home/dav/code/2024/tosg2/oss-fuzz-gen/results/output-tinyxml2-_znk8tinyxml210xmlelement12shallowcloneepns_11xmldocumente/fixed_targets/02.cpp
max coverage diff report: None

WARNING:root:No permission to remove /tmp/tmpfdmwg9o3

Thanks for this PR, @DavidKorczynski!
Yes, it is definitely some noise we'd like to eliminate.
Just to double-check, I noticed that this was submitted from a fork of this repo before testing your new access, which explains why the first CI failed.
Would it be possible for you to resubmit this PR as a branch of this repo, so that I can run experiments for you?
Thanks, and hope this is not too much trouble : )

Yup, for sure: https://github.com/google/oss-fuzz-gen/pull/202

Thanks!


Bug fix: hide "x new messages"

Hi,
When receiving multiple WhatsApp messages, a notification saying "[the number of received messages] new messages" is displayed as a chat bubble in WhatsDeleted (see examples below).
For a better experience and improved readability, I think these notifications should be hidden from the WhatsDeleted app.
Thank you in advance.

I will fix it in the next release.


groups: hard to know who hosts an unmigrated channel if it's a moon

Describe the bug, optionally with screenshots

Show the full @p in the ShipName tooltip.


ECS was unable to assume the role ecsTaskExecutionRole

First of all, thanks for the exhaustive examples, I'm afraid I'm stuck though on examples/terraform-aws-modules/main.tf line 152...
Basically, I've manually created a role ecsTaskExecutionRole in IAM > Roles and assigned AmazonECSTaskExecutionRolePolicy to it.

The trust relation is set to
{
    "Version": "2008-10-17",
    "Statement": [
        {
            "Sid": "",
            "Effect": "Allow",
            "Principal": {
                "Service": "ecs.amazonaws.com"
            },
            "Action": "sts:AssumeRole"
        }
    ]
}

and I can retrieve it with aws iam get-role --role-name ecsTaskExecutionRole
However, the aws_ecs_task_definition doesn't succeed but reports this as service event for example-ecs-terraform-aws-modules-service:
service example-ecs-terraform-aws-modules-service failed to launch a task with (error ECS was unable to assume the role 'arn:aws:iam::<m:role/ecsTaskExecutionRole' that was provided for this task. Please verify that the role being passed has the proper trust relationship and permissions and that your IAM user has permissions to pass this role.).
So I dug a little bit deeper into the IAM docs and tried adding a Customer inline permission policy for my terraform user like so:
{
	"Version": "2012-10-17",
	"Statement": [
		{
			"Effect": "Allow",
			"Action": [
				"iam:GetRole",
				"iam:PassRole"
			],
			"Resource": "arn:aws:iam::<m<id>:role/*"
		}
	]
}

But that doesn't help either. So some guidance as to how exactly create that ecsTaskExecutionRole and what other preconditions have to be met would be highly appreciated!

Great, injecting step 14 and changing the execution_role_arn in the task definiton accordingly solves the issue. Thanks for the quick response!
One more comment: Your sample app console.logs something - I guess logging needs to be defined explicitly for the task because I see nothing in the example-ecs-terraform-aws-modules-service logs... Maybe you could add that when you update this repo anyway...?

I think I just had the console.log to verify the service was running locally in development. However, it would be interesting to figure out how to get those logs out of Fargate - another future iteration for sure.

Fixed with 82e10756fbd4e93b847292ecd2e13ac5299ea2e4


Create interface file: add support for JSX V4.

@mattdamon108 see how the editor support needs to stay in sync with JSX.
In particular, it needs to reverse-engineer it starting from the types obtained after the ppx run.
So in case of future changes, this should be taken into account.

This should be the last known item needed for https://github.com/rescript-lang/rescript-compiler/issues/5406
Anything else, people will find out when testing more thoroughly.


Implement reasoning preprocessing step:

Classification
Typing (non-redundant ideally).

Get non-redundant assertions (at least on the classification side).
Later we at more detailed classification.
consider inferred axiom tagging, but only if performance issues are witnessed

The reasoning preprocessing is controlled here:
https://github.com/VirtualFlyBrain/vfb-pipeline-dumps/blob/c101f7d13377a30a1757519cb508a47c2d95da5a/dumps.Makefile#L41
It seems that it works without removing disjoints, which really leaves me baffled. But hey, as @dosumis said, maybe that is ok. It all seems to work fine to my eyes.


Icons: Remove footer triangle and refactor HalfSquareTriangle

The design team requested to remove the footer triangle and make some changes to HalfSquareTriangle including refactoring the name and make some modifications to the components where its currently used.
More info on :- https://github.com/international-labour-organization/designsystem/issues/839

hey @Shashika6 I don't think this request is ready for dev yet, please hold off on that.

This was fixed in #1208


Add n_restarts option to gpy model wrapper

Allows user to do multiple restarts for optimization of hyper-parameters for gpy models
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #177 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   89.57%   89.57%   +<.01%
==========================================
  Files          95       95
  Lines        2494     2495       +1
  Branches      250      250
==========================================
+ Hits         2234     2235       +1
  Misses        216      216
  Partials       44       44

Impacted Files
Coverage Δ

emukit/model_wrappers/gpy_model_wrappers.py
86.25% <100%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227af1d...282eaab. Read the comment docs.


ONBUILD npm install should come after ONBUILD COPY .

ONBUILD npm install should come after ONBUILD COPY .
Users might already have 'node_modules/'  folder locally, so "npm install" could take less time to be execute if it was copied previously from the sources.

+1 nice catch, patched!

will push a release later today

Thanks @ryanj ;)

reverted the commit, reopening


Add restart method on Case

The method should return a new Case instance whose start_date corresponds to end_date on the previous case. It should also accept a new_end_date argument.
The only issue is that, in the case of spinning the model up, typically the user would want to change the timestep size, which is defined separately for each component (in our case this involves updating ROMSComponent.discretization.timestep). I think this is acceptable for now.

The big problem here will be automatically replacing ROMSComponent.initial_conditions with the correct file path to the restart file. C-Star will somehow have to work out what the name of the restart file is going to be (presumably by parsing the AdditionalCode.source_mods / ocean_vars.optfile to get the restart file frequency and combining this with the time step, run length, and run name specified in the  ROMS namelist file).

Related: #114


It is directly redirecting me to google contact page

Issue and Steps to Reproduce

Versions
6.11.3
Screenshots
Code

Trusted domain

Expected
On successful login it should redirect me to the redirect URI
on Failure It should redirect me to the SSO page
Actual
It is redirecting me to google contact

Installed packages:

"@axa-fr/react-oidc": "6.11.3"

**Other Packages **
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"@types/jest": "^27.5.2",
"@types/node": "^16.18.3",
"@types/react": "^18.0.25",
"@types/react-dom": "^18.0.9",
"axios": "^1.2.0",
"bootstrap": "^5.2.2",
"oidc-react": "^2.1.0",
"react": "^18.2.0",
"react-beforeunload": "^2.5.3",
"react-bootstrap": "^2.6.0",
"react-dom": "^18.2.0",
"react-frame-component": "^5.2.3",
"react-router-dom": "^6.4.3",
"react-scripts": "5.0.1",
"sass": "^1.56.1",
"typescript": "^4.9.3",
"web-vitals": "^2.1.4"

hi @KumaravelPonnusamy ,
thank you for your issue.
What is your network history?
I think the problem may come from your OIDC server configuration.

Hi @guillaume-chervet
Thanks for your kind support.
The network is related Azure ad.
I will check the OIDC configurations.

Hi @KumaravelPonnusamy , did you resolve your problem?

Hi @KumaravelPonnusamy , i close the issue. Feel free to reopen it if you need it. I hope you have found a solution.


Add densitytensor notebook

Added example notebook demonstrating densitytensor simulator

Great addition to the examples.
One sentence I would clarify is
Now let's sample some measurements from the true $p$

It sounds strange to sample from p. What we actually do is sample from both the noiseless and the noisy circuit with noise parameters p.

Good point! Yeah really what we sample are "noisy measurements from the circuit with noise parameter $p$"


CaptionManagerTest importing cpp file instead of header file

Briefly summarize your issue:

Attempted to compile libCaptionsTestLib.so
Got the following error:

[ 99%] Linking CXX shared library libCaptionsTestLib.so
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `alexaClientSDK::captions::test::TestTimingAdapterFactory::getMockTimingAdapter()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1166: multiple definition of `alexaClientSDK::captions::test::TestTimingAdapterFactory::getMockTimingAdapter()'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/Captions/Implementation/test/TestTimingAdapterFactory.cpp:31: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `alexaClientSDK::captions::test::TestTimingAdapterFactory::~TestTimingAdapterFactory()'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `alexaClientSDK::captions::test::TestTimingAdapterFactory::~TestTimingAdapterFactory()'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `alexaClientSDK::captions::test::TestTimingAdapterFactory::~TestTimingAdapterFactory()'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `alexaClientSDK::captions::test::TestTimingAdapterFactory::getTimingAdapter(std::__ndk1::shared_ptr<alexaClientSDK::captions::CaptionPresenterInterface>) const'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `typeinfo for alexaClientSDK::captions::test::TestTimingAdapterFactory'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `typeinfo name for alexaClientSDK::captions::test::TestTimingAdapterFactory'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
CMakeFiles/CaptionsTestLib.dir/TestTimingAdapterFactory.cpp.o: In function `testing::DefaultValue<void>::Get()':
/Users/user/dev/AVSDeviceSDK/ThirdParty/googletest-release-1.8.0/googlemock/include/gmock/gmock-spec-builders.h:1154: multiple definition of `vtable for alexaClientSDK::captions::test::TestTimingAdapterFactory'
CMakeFiles/CaptionsTestLib.dir/CaptionManagerTest.cpp.o:/Users/user/dev/AVSDeviceSDK/AVSCommon/Utils/include/AVSCommon/Utils/MediaPlayer/MediaPlayerInterface.h:292: first defined here
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Captions/Implementation/test/libCaptionsTestLib.so] Error 1
make[1]: *** [Captions/Implementation/test/CMakeFiles/CaptionsTestLib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

What behavior are you observing?
It appears that CaptionManagerTest.cpp is #including a cpp file instead of a header file:
https://github.com/alexa/avs-device-sdk/blob/master/Captions/Implementation/test/CaptionManagerTest.cpp#L28
This will duplicate the symbols since they are included once in CaptionManagerTest and a second time in the cmake file (TestTimingAdapterFactory.cpp)--causing the lib to not compile.
Provide the steps to reproduce the issue, if applicable:

Attempt to compile libCaptionsTestLib.so

Tell us about your environment:
What version of the AVS Device SDK are you using?
  v1.18.0

Tell us what hardware you're using:

[x] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[x] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Cross-compiling for Android (though, not sure that makes a difference).

It looks like the CMakeLists.txt is also including a header file under sources: https://github.com/alexa/avs-device-sdk/blob/master/Captions/Implementation/test/CMakeLists.txt#L7

Finally got it to compile with a modified Captions/Implementation/test/CMakeLists.txt (in addition to fixing the import above):

cmake_minimum_required(VERSION 3.1 FATAL_ERROR)

set(CaptionsTestLib_SOURCES)
list(APPEND CaptionsTestLib_SOURCES
        TestTimingAdapterFactory.cpp)

add_library(CaptionsTestLib ${CaptionsTestLib_SOURCES})

target_include_directories(CaptionsTestLib PUBLIC
        "${AVSCommon_INCLUDE_DIRS}"
        "${AVSCommon_SOURCE_DIR}/Utils/test"
        "${AVSCommon_SOURCE_DIR}/SDKInterfaces/test"
        "${Captions_SOURCE_DIR}/Implementation/test")

target_link_libraries(CaptionsTestLib
        AVSCommon
        CaptionsLib
        UtilsCommonTestLib
        gtest_main
        gmock_main)

set(INCLUDE_PATH
        "${AVSCommon_INCLUDE_DIRS}"
        "${AVSCommon_SOURCE_DIR}/AVS/test"
        "${AVSCommon_SOURCE_DIR}/Utils/test"
        "${AVSCommon_SOURCE_DIR}/SDKInterfaces/test")

add_definitions("-DACSDK_LOG_MODULE=captionsTest")

discover_unit_tests("${Captions}/Implementation/include" "CaptionsLib;CaptionsTestLib;UtilsCommonTestLib")

If I'm reading this correctly: CaptionsTestLib should only have mocks and other functions needed for Captions test. I removed all the test classes from that library. I then added CaptionsLib as a dependency of the discover_unit_tests function.
I'm not sure what to do with LibwebvttParserAdapterTest.cpp. I believe that should be part of the discover_unit_tests, and not in the CaptionsTestLib. I also noticed that this cmake file says if (CAPTIONS) , whereas LibwebvttParserAdapterTest.cpp has an #ifdef ENABLE_CAPTIONS. Not sure if those are meant to be the same define or not.

Hi @jbfitb,
Thanks for pointing this out. It will also be tracked and fixed in an upcoming release. At this point, are you running into any other compilation problems?
The answer to some of your questions:
LibwebvttParserAdapterTest.cpp does not have to be included in CaptionsTestLib as you summarized. discover_unit_tests() will search the test dir and create an executable out of each test file.
CAPTIONS is a CMake variable, while ENABLE_CAPTIONS is a pre-processor define. The CAPTIONS CMake variable is not visible when LibwebvttParserAdapterTest is being processed. If you are interested, the logic to add that definition based on the CMake variable is in Build/Captions.cmake.

Hi @jbfitb,
We have a task in our backlog to fix this, so I am closing out the issue.  We will announce a fix in our release notes when the fix is released.
Thank you again for bringing this to our attention!
Best regards,
-SWH


rfc: Add initial draft for polka-index

Description
This PR adds an RFC for the polka-index component. I followed the guidelines described in rfc7322. After looking at the polka-fetch component, the polka-index component is closely tied to the polka-fetch component as it fetches a file based on its CID. Because these components are so closely related, the polka-index component should be written as a library so it can be used by the polka-fetch component can use this library to find the peer ID holding the CID.

Note, we should keep the RFCs in the same place instead of scattered around the workspace


Update actions and add dependabot

This PR adds dependabot for automated updating of GitHub actions versions

Merging this will also let me test to make sure the build and deploy action at merge time works properly.


Stop UnifyTypes recovery in TcDelayed

This is to resolve this issue: https://github.com/Microsoft/visualfsharp/issues/5468
And it does not regress this issue: https://github.com/Microsoft/visualfsharp/issues/629
I'm not 100% sure how this code works yet, but I do know this change fixes the issue.

@liboz do you remember why you did this?

You're sure that it's working correctly? It's a single line change without breaking everything?

@realvictorprm wrong recovery is definitely the issue here. The question is why it was introduced.

@liboz I'm sure that was your intent. However, there are two places where you recover. It looks like only one was necessary, which was in Propogate.


Add rule: Must throw an Error object

The following are errors:
throw "error";

throw 0;

throw undefined;

throw null;

The following are not errors:
throw new Error();

throw new Error("error");

var e = new Error("error");
throw e;

try {
    throw new Error("error");
} catch (e) {
    throw e;
}

This could just be a minor version bump since it doesn't cause any of the modules in test.js to fail.

:+1:

the wording in this PR confused me a bit since we are talking about errors when using errors

would this still work?
var notFound = function() {
  var err = new Error('not found')
  err.status = 404
  return err
}

throw notFound()

@mafintosh Good point about the wording, fixed! :)

@mafintosh, yep that example would work, except you forgot the space after function ;)

To be clear, this PR essentially only stops the throwing of non-Error literals?

Yes. You can technically do "throw myFunc()" where myFunc() returns a
string. This rule prevents the obvious cases where someone tries to throw a
string or other literal that's not an Error
On Fri, Feb 27, 2015 at 12:07 AM Daniel Cousens<EMAIL_ADDRESS>wrote:

To be clear, this PR essentially only stops the throwing of non-Error
literals?
—
Reply to this email directly or view it on GitHub
https://github.com/feross/standard/pull/44#issuecomment-76303273.


React is a dependency of this project?

Hello, I'm adding your window-date-picker to my project through NPM, but my partner noticed that the react and the react-dom were installed along with it in the node modules.
I was not expecting the react to be a dependency of this project, I thought it would only be necessary for your related project that implements that same datepicker for the react.
I have even deleted the react and react-dom of node_modules and the Window Date Picker continues to work perfectly.
Is this a mistake in configuring Window Date Picker dependencies?
Is it possible to add Window Date Picker to my project without having to manually delete the react?
Thank you for your attention and work.

Not for this version. You can check out the dependencies in package.json file. I just downloaded the window-date-picker through NPM and didn't see anything about react.
Also, If you want to use window-date-picker as React Component, you can take a look react version.

Yes, you are right. It seems that another dependency of my project introduced the react in another branch and we only realized now and we ended up thinking that it was the Windows Date Picker, because there is the react version of it.
Sorry for bothering.


Fix default value for select

Description
The current value was overwritten if the default value was given for the select component.

Summary by CodeRabbit

New Features

Enhanced the select input component to remember previously entered values after form submission.

I'm merging this without a review in a reasonable time. It's only an easy fix.


Fix tabnew with arguments

Fixes #146
Changes Proposed in this Pull Request:

Fixes a bug in the way tabnew forwarded arguments to tabedit.

I have written tests for:
Calling tabnew with arguments

[x] Bugs fixed
[x] Test cases added

@jazzpi @LongLiveCHIEF

Looks great, thanks! :smile:


Converted tflite model cannot classify images properly

Hello!
 I pointed my camera at the same food image as I tested before and I got these result on the screen:
cheesecake: 0.33
sushi: 0.16
tuna: 0.12

Why can't the tflite model classify the image properly? Where did I do wrong?
Thanks in advance.

@nfathoni79,
Can you please provide the results by running TF Lite Convert on already validated image like,  "food_images\chicken\33341.jpg".  Then we can actually try to understand the drop in performance because of its conversion.

@rmothukuru
I just tested my tflite model with tflite interpreter by modifying the script here. I used the read_tensor_from_image_file function from the label_image.py script to turn the "food_images\chicken\33341.jpg" image into a tensor. Here is my script:
# Read tensor from image file
file_name = "food_images/chicken/33341.jpg"
input_height = 224
input_width = 224
image_tensor = read_tensor_from_image_file(file_name, input_height, input_width)

# Load TFLite model and allocate tensors.
interpreter = tf.lite.Interpreter(model_path="optimized_graph_100.lite")
interpreter.allocate_tensors()

# Get input and output tensors.
input_details = interpreter.get_input_details()
output_details = interpreter.get_output_details()

# Test model
input_shape = input_details[0]['shape']
interpreter.set_tensor(input_details[0]['index'], image_tensor)

interpreter.invoke()
output_data = interpreter.get_tensor(output_details[0]['index'])
print(output_data)

And surprisingly I got these results:
[[9.98360097e-01 1.05565100e-03 1.99441529e-05 6.45590490e-07
  1.02031201e-07 1.31657885e-08 8.65402171e-07 6.16448403e-08
  6.74352947e-08 3.44396394e-05 2.78956168e-06 4.17489173e-06
  1.35173582e-06 9.83086608e-08 1.54677909e-05 3.55562442e-08
  1.53483022e-08 1.49937046e-06 2.45400679e-06 1.72795683e-06
  2.54611621e-08 5.75562780e-08 2.14812577e-08 8.65700531e-06
  7.62361233e-05 1.38726375e-06 4.04161547e-04 8.63593300e-07
  3.67860942e-08 7.03735714e-06]]

My image dataset has 30 labels and the image is perfectly classified as label one (label one is the chicken). I don't know why it doesn't work when I put the tflite model on my Android app. The intended label is not in the top three, and the top three confidence are very low (below 30%).

@nfathoni79 ,
Can you please raise an issue in Tensorflow Repository of Github or in Stackoverflow or may be any avenue related to Android. Closing this issue as it is not related to TF Hub.


Ryan M: Watch syrotech(?:.com)?

Ryan M requests the watch of the watch_keyword syrotech(?:\.com)?. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

syrotech(?:\.com)? has been seen in 1 true positive, 0 false positives, and 0 NAAs.

This is slightly problematic because the domain name and the free-standing term could qualify for different blacklists in the end. But let's take this as it is and see.

Approved by tripleee in Charcoal HQ


Build CM - fix docker build pipeline name

The name of the pipeline in the bundle is "docker-build" not "docker-builder".

/lgtm

the failure in the e2e test isn't related to the change.


[BUG] delta_lake_delete_test.py failed assertion [DATAGEN_SEED=1701225104, IGNORE_ORDER...

Describe the bug
first seen in rapids_integration-dev-github, build ID 863 (jdk11 runtime + spark 330)
[2023-11-29T02:56:13.493Z] FAILED ../../src/main/python/delta_lake_delete_test.py::test_delta_delete_rows[None-True][DATAGEN_SEED=1701225104, IGNORE_ORDER, ALLOW_NON_GPU(DeserializeToObjectExec,ShuffleExchangeExec,FileSourceScanExec,FilterExec,MapPartitionsExec,MapElementsExec,ObjectHashAggregateExec,ProjectExec,SerializeFromObjectExec,SortExec)] - AssertionError: Delta log<PHONE_NUMBER>0000000002.json is different at key 'add':
[2023-11-29T02:56:13.493Z] CPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":537,"minValues":{"a":0,"b":"d","c":"\\u0000¶\'\x86åJ\\u0000J\x94C\x8cï=\\"7¡àÛ+\x9aànÊ\x92±`Iì\\b\x99"},"maxValues":{"a":4,"b":"g","c":"ÿÆ\\u0012\x93YÐ¿\\u000EwÐ.Ñ\x8a®tîá|\\u0017=8§¦\x98³þ÷\x9bÜ¤"},"nullCount":{"a":0,"b":0,"c":29,"_change_type":537}}'}
[2023-11-29T02:56:13.493Z] GPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":541,"minValues":{"a":0,"b":"d","c":"\\u0000¶\'\x86åJ\\u0000J\x94C\x8cï=\\"7¡àÛ+\x9aànÊ\x92±`Iì\\b\x99"},"maxValues":{"a":4,"b":"g","c":"þ\x7f³´ï\\u0014Ê1\\u000Bï\x81\x83Ü^\x97´$\\u0017\x9a¡\\n\\"\\u000EÈ/\\t\x904\x97¨"},"nullCount":{"a":0,"b":0,"c":33,"_change_type":541}}'}
[2023-11-29T02:56:13.493Z] FAILED ../../src/main/python/delta_lake_delete_test.py::test_delta_delete_dataframe_api[None-False][DATAGEN_SEED=1701225104, INJECT_OOM, IGNORE_ORDER, ALLOW_NON_GPU(DeserializeToObjectExec,ShuffleExchangeExec,FileSourceScanExec,FilterExec,MapPartitionsExec,MapElementsExec,ObjectHashAggregateExec,ProjectExec,SerializeFromObjectExec,SortExec)] - AssertionError: Delta log<PHONE_NUMBER>0000000001.json is different at key 'add':
[2023-11-29T02:56:13.493Z] CPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":443,"minValues":{"a":0,"b":"a","c":"\\u0001\\tÛá®oÔhÌ\\u0010yÎCÎô\\u0012\x94³EB\x82>à\\u00062%.o\\u001D¥"},"maxValues":{"a":4,"b":"c","c":"ÿ^±Úq\\u000Bx¼\\u0005øè¶½ec\\ntà\x98ø[mÌ¼Óå\\tXE¼"},"nullCount":{"a":0,"b":0,"c":15}}'}
[2023-11-29T02:56:13.493Z] GPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":447,"minValues":{"a":0,"b":"a","c":"\\u0001saD\\u000FzkÍÄ|¤ó_\x90ÑO¹¸åßÔ\x82|µ~\x91òbVå"},"maxValues":{"a":4,"b":"c","c":"ÿ^±Úq\\u000Bx¼\\u0005øè¶½ec\\ntà\x98ø[mÌ¼Óå\\tXE¼"},"nullCount":{"a":0,"b":0,"c":18}}'}
[2023-11-29T02:56:13.493Z] FAILED ../../src/main/python/delta_lake_update_test.py::test_delta_update_rows[None-False][DATAGEN_SEED=1701225104, INJECT_OOM, IGNORE_ORDER, ALLOW_NON_GPU(DeserializeToObjectExec,ShuffleExchangeExec,FileSourceScanExec,FilterExec,MapPartitionsExec,MapElementsExec,ObjectHashAggregateExec,ProjectExec,SerializeFromObjectExec,SortExec)] - AssertionError: Delta log<PHONE_NUMBER>0000000001.json is different at key 'add':
[2023-11-29T02:56:13.493Z] CPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":1020,"minValues":{"a":0,"b":"a","c":"\\u0000Ò@\\u0010Ò>-ªUË\\u0017\\u0001ð\\u0007Æ9blðl@æaB\\"|ÉùÐõ"},"maxValues":{"a":4,"b":"g","c":"ÿ) å.>^\\fc\\u0012Gl¥èÞþÎÌ>\\f²Óý¤\x9cÕ\\u0007¸\x99O"},"nullCount":{"a":0,"b":0,"c":21}}'}
[2023-11-29T02:56:13.493Z] GPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":1020,"minValues":{"a":0,"b":"a","c":"\\u0000Ò@\\u0010Ò>-ªUË\\u0017\\u0001ð\\u0007Æ9blðl@æaB\\"|ÉùÐõ"},"maxValues":{"a":4,"b":"g","c":"þë\\u0014øgb\\u001B\x88¢¢À\\u0006Ù\x9aõf\\u0013m^è³iöÈ?\\b¯v\\u0000Ù"},"nullCount":{"a":0,"b":0,"c":18}}'}
[2023-11-29T02:56:13.494Z] = 3 failed, 276 passed, 47 skipped, 4 xfailed, 40 warnings in 1468.57s (0:24:28) =

mismatched CPU and GPU output:
[2023-11-29T02:56:13.489Z] E           AssertionError: Delta log<PHONE_NUMBER>0000000002.json is different at key 'add':
[2023-11-29T02:56:13.489Z] E           CPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":537,"minValues":{"a":0,"b":"d","c":"\\u0000¶\'\x86åJ\\u0000J\x94C\x8cï=\\"7¡àÛ+\x9aànÊ\x92±`Iì\\b\x99"},"maxValues":{"a":4,"b":"g","c":"ÿÆ\\u0012\x93YÐ¿\\u000EwÐ.Ñ\x8a®tîá|\\u0017=8§¦\x98³þ÷\x9bÜ¤"},"nullCount":{"a":0,"b":0,"c":29,"_change_type":537}}'}
[2023-11-29T02:56:13.489Z] E           GPU: {'path': 'partsnappy.parquet', 'partitionValues': {}, 'dataChange': True, 'stats': '{"numRecords":541,"minValues":{"a":0,"b":"d","c":"\\u0000¶\'\x86åJ\\u0000J\x94C\x8cï=\\"7¡àÛ+\x9aànÊ\x92±`Iì\\b\x99"},"maxValues":{"a":4,"b":"g","c":"þ\x7f³´ï\\u0014Ê1\\u000Bï\x81\x83Ü^\x97´$\\u0017\x9a¡\\n\\"\\u000EÈ/\\t\x904\x97¨"},"nullCount":{"a":0,"b":0,"c":33,"_change_type":541}}'}

others
[2023-11-29T02:56:13.488Z] filename = '00000000000000000002.json'
[2023-11-29T02:56:13.488Z] c_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":537,"minValu..."ÿÆ\\u0012\x93YÐ¿\\u000EwÐ.Ñ\x8a®tîá|\\u0017=8§¦\x98³þ÷\x9bÜ¤"},"nullCount":{"a":0,"b":0,"c":29,"_change_type":537}}'}}
[2023-11-29T02:56:13.488Z] g_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":541,"minValu...000Bï\x81\x83Ü^\x97´$\\u0017\x9a¡\\n\\"\\u000EÈ/\\t\x904\x97¨"},"nullCount":{"a":0,"b":0,"c":33,"_change_type":541}}'}}

[2023-11-29T02:56:13.490Z] filename = '00000000000000000001.json'
[2023-11-29T02:56:13.490Z] c_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":443,"minValu...maxValues":{"a":4,"b":"c","c":"ÿ^±Úq\\u000Bx¼\\u0005øè¶½ec\\ntà\x98ø[mÌ¼Óå\\tXE¼"},"nullCount":{"a":0,"b":0,"c":15}}'}}
[2023-11-29T02:56:13.490Z] g_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":447,"minValu...maxValues":{"a":4,"b":"c","c":"ÿ^±Úq\\u000Bx¼\\u0005øè¶½ec\\ntà\x98ø[mÌ¼Óå\\tXE¼"},"nullCount":{"a":0,"b":0,"c":18}}'}}

[2023-11-29T02:56:13.492Z] filename = '00000000000000000001.json'
[2023-11-29T02:56:13.492Z] c_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":1020,"minVal...Values":{"a":4,"b":"g","c":"ÿ) å.>^\\fc\\u0012Gl¥èÞþÎÌ>\\f²Óý¤\x9cÕ\\u0007¸\x99O"},"nullCount":{"a":0,"b":0,"c":21}}'}}
[2023-11-29T02:56:13.492Z] g_json = {'add': {'dataChange': True, 'partitionValues': {}, 'path': 'partsnappy.parquet', 'stats': '{"numRecords":1020,"minVal...b":"g","c":"þë\\u0014øgb\\u001B\x88¢¢À\\u0006Ù\x9aõf\\u0013m^è³iöÈ?\\b¯v\\u0000Ù"},"nullCount":{"a":0,"b":0,"c":18}}'}}

Steps/Code to reproduce bug
Please provide a list of steps or a code sample to reproduce the issue.
Avoid posting private or sensitive data.
Expected behavior
A clear and concise description of what you expected to happen.
Environment details (please complete the following information)

Environment location: [Standalone, YARN, Kubernetes, Cloud(specify cloud provider)]
Spark configuration settings related to the issue

Additional context
Add any other context about the problem here.

I cannot reproduce this, and AFAIK it has not been seen since it occurred.  My guess is that somehow the data was spread across tasks differently between the two runs, as the data was verified to be correct (i.e.: all rows were accounted for, ignoring ordering) before the metadata equality check afterwards failed.

I found a way to reliably reproduce this:
SPARK_SUBMIT_FLAGS="--master local[2]" TEST_PARALLEL=0 SPARK_HOME=/home/jlowe/spark-3.2.1-bin-hadoop3.2/ DATAGEN_SEED=1702052986 PYSP_TEST_spark_jars_packages=io.delta:delta-core_2.12:2.0.1 PYSP_TEST_spark_sql_extensions=io.delta.sql.DeltaSparkSessionExtension PYSP_TEST_spark_sql_catalog_spark__catalog=org.apache.spark.sql.delta.catalog.DeltaCatalog integration_tests/run_pyspark_from_build.sh -k "test_delta_delete_dataframe_api and None-True" --delta_lake --debug_tmp_path

As suspected, the table contents as a whole are correct, but somehow some of the rows have been swizzled between the two output files between the CPU and GPU runs.  AFAICT nothing is actually wrong semantically with the output produced by the GPU relative to the CPU, but it would be good to understand how we're reliably getting the rows crossed here.  I suspect for some odd reason the GPU run is getting a different set of input files for the tasks than the CPU does.

Debugged why this is failing for certain datagen seeds.  The problem can occur when a particular datagen seed causes two or more Parquet files within a table to be generated with the same file size.  ext4 and most other Linux filesystems will return a directory listing in an order influenced by the order the files are written to the directory, and it's not deterministic which files will be written before other files as tasks execute in parallel.  The input files are sorted in descending order by file size, but when two or more files are the same size, the sorted ordering can be different between two directories that contain the same files but were created in a different order.
I do not see a way to really fix this other than use a datagen seed which is known to produce files that can be deterministically sorted, as was done in #10009, or change the test to not try to compare metadata.  The latter would allow a lot of subtle bugs to slip through, so I think using a fixed datagen seed is the better route.
Closing this bug as setting a fixed seed as done by #10009 is the long-term solution.


Uninstall CUDA toolkit

Describe the bug
I have previously installed this toolkit using the provided startup script.
Now nvidia-smi shows no connection to the GPU. When I try re-running the installation script I get:
CUDA toolkit already marked as installed

Would there be an easy to way uninstall all related files and do a 'fresh install'? Have tried rebooting the server numerous times as well as running the script manually, with no luck.
Here are the last lines from the logs:
[2024-06-13 21:00:19,435] INFO - Installing prerequisite packages and updating kernel...
[2024-06-14 09:12:35,515] INFO - Switching to working directory: /opt/google/cuda-installer
[2024-06-14 09:12:35,703] INFO - Downloading CUDA installation kit...
[2024-06-14 09:12:35,703] INFO - Executing: sha256sum cuda_12.4.1_550.54.15_linux.run
[2024-06-14 09:13:03,226] INFO - 367d2299b3a4588ab487a6d27276ca5d9ead6e394904f18bccb9e12433b9c4fb  cuda_12.4.1_550.54.15_linux.run
[2024-06-14 09:13:03,226] INFO - Installing CUDA toolkit...
[2024-06-14 09:13:03,227] INFO - Executing: sh cuda_12.4.1_550.54.15_linux.run --silent --toolkit
[2024-06-14 09:15:20,525] INFO - CUDA toolkit installation completed!
[2024-06-14 09:15:20,525] INFO - Executing post-installation actions...
[2024-06-14 09:15:20,527] INFO - CUDA post-installation actions completed!
[2024-06-14 09:15:20,528] INFO - The system needs to be rebooted to complete the installation process. The process will be continued after the reboot.
[2024-06-14 09:15:20,528] INFO - Rebooting now.
[2024-06-14 09:15:20,528] INFO - Executing: reboot now
[2024-06-14 09:15:42,209] INFO - Switching to working directory: /opt/google/cuda-installer
[2024-06-14 09:15:42,237] INFO - CUDA toolkit already marked as installed.
[2024-06-17 14:55:05,142] INFO - Switching to working directory: /opt/google/cuda-installer
[2024-06-17 14:55:05,166] INFO - CUDA toolkit already marked as installed.

Environment

Operating system: Debian 5.10.221-1 (2024-07-14) x86_64 GNU/Linux
Graphics card: A100 40GB x1

To Reproduce
Steps to reproduce the behavior. A copy-paste of the commands you executed and the output you got. The Linux installation script by default saves its' output to /opt/google/gpu-installer/ - please provide the files you find there.

Hello!
Thanks for reporting the issue. To uninstall CUDA Toolkit as well as driver, you can do the following:

Uninstall CUDA: execute /usr/local/cuda/bin/cuda-uninstaller file to uninstall the CUDA toolkit.
Uninstall the driver using the installation tool: sudo python3 cuda_installer.pyz uninstall_driver
Purge the /opt/google/cuda-installer directory, so the installer tool won't complain that anything is already installed.

Now that you made me research how to uninstall the toolkit, I will implement a uninstall_cuda subcommand to the script, so it's much easier to do for people in the future.


Add basic narrowing #122

Adds narrowing of variable reference types based on JavaScript equality constructs.
Currently adds the following

=== narrowing
typeof narrowing
Support for && and ||
Some extras which require additions from #186

Support across variable declarations and functions thanks to more dependent types
Additionally the LocalInformation merging now handles final events better. (see new control flow test, which would previously be 3 | 7)

Some things to do:

Backing id changes
Ands (should be fine using the current system)
Or

Needs to buffer results and combine in final step?

Still to do:

Think about filtering objects by predicates on properties. Aka { tag: 1, d: string } | { tag: 2, d: boolean }, after obj.tag === 1 becomes { tag: 1, d: string }

InformationChain is already accessible here. Narrowing needs to pass down this information

Whether variable reference narrowing is enough?

Most definitely missing some functionality but the basics are in so merging 🎉


Add validation for grafts created at failed block

Fixes https://github.com/graphprotocol/graph-node/issues/3501

It seems both the integration and unit tests are failing for this, I'll investigate why is that 🔍


Add table linking to NextGen and its peripherals (e.g., hydrofabric, formulations, etc.)

This could be a nice diagram as well.


choose path to log and sqlite files

Is your feature request related to a problem?

It's very annoying to have a new Sqlite3file created where you input the startup command ! You can loose your previous tokens and it create garbage files each time you start the command.
Describe the solution you'd like

Add to the config.yaml  where you want to store the log and sqlite file. Like path_to_logs = "";
It would be easier for new users
Regards

those both already are options?
https://github.com/ZerataX/matrix-registration/blob/8dbabbcb6ec177e7ef91c6ff5e3b1d650370200e/config.sample.yaml#L7
https://github.com/ZerataX/matrix-registration/blob/8dbabbcb6ec177e7ef91c6ff5e3b1d650370200e/config.sample.yaml#L33

those both already are options?
https://github.com/ZerataX/matrix-registration/blob/8dbabbcb6ec177e7ef91c6ff5e3b1d650370200e/config.sample.yaml#L7
https://github.com/ZerataX/matrix-registration/blob/8dbabbcb6ec177e7ef91c6ff5e3b1d650370200e/config.sample.yaml#L33


Constraint files

It seems that this tool doesn't understand constraint files (pip -c flag) at all. They are just like referenced requirements files except they own limit your requirements versions and don't add any new packages to install.
What I want to get in the end: prod.in has -c base.in and test.in has -c base.in and -c prod.in lines in them. When I compile, I want versions in all three resulting files (base.txt, prod.txt, test.txt) to be synced and -c lines replaced with compiled files (so prod.txt has -c base.txt and test.txt -c base.txt and -c prod.txt). This way I can select to install everything or to install only test packages or only prod ones (or split them into different docker layers), for that it's very important that test reqs file doesn't include requirements from prod.txt unless there's some dependency but versions of those sub-deps are synced nevetherless.
It also would be great to have a dependency-based compilation order if possible.
Does this sound like something worth implementing in this tool?

Actually, come to think of it. Referencing constraints in compiled files is not necessary as long as constraints never change without complete recompilation... Skipping them in pinned files is a pip-tools behaviour and it actually does respect the constraints as far as I can tell.
Still, dependency-based order of compilation is definitely needed.

If .in files use other .in files for constraints and .txt files don't have -c, than compilation order doesn't matter.
I used conflicting-in-merge example for experiments. Without -c files are:
==> conflicting-in-merge/base1.in <==
pytz<2018

==> conflicting-in-merge/base2.in <==
pytz

==> conflicting-in-merge/together.in <==
-r base1.in
-r base2.in

Compilation gives an error:
$ pip-compile-multi -d conflicting-in-merge/
Locking conflicting-in-merge/base1.in to conflicting-in-merge/base1.txt. References: []
Locking conflicting-in-merge/base2.in to conflicting-in-merge/base2.txt. References: []
Package pytz was resolved to different versions in different environments: 2018.7 and 2017.3

But if I add -c base1.in to base2.in:
==> conflicting-in-merge/base1.in <==
pytz<2018

==> conflicting-in-merge/base2.in <==
-c base1.in

pytz

==> conflicting-in-merge/together.in <==
-r base1.in
-r base2.in

Compilation succeeds with expected result:
$ head conflicting-in-merge/*.txt
==> conflicting-in-merge/base1.txt <==
# SHA1:07973b0a74462beb75c2bb65cae3db0b53237103
#
# This file is autogenerated by pip-compile-multi
# To update, run:
#
#    pip-compile-multi
#
pytz==2017.3

==> conflicting-in-merge/base2.txt <==
# SHA1:d3d3929908415fe98d4376a9794073ccc3f61c8f
#
# This file is autogenerated by pip-compile-multi
# To update, run:
#
#    pip-compile-multi
#
pytz==2017.3

==> conflicting-in-merge/together.txt <==
# SHA1:08d9c33c7a4a6c4972d515c176318068baf08856
#
# This file is autogenerated by pip-compile-multi
# To update, run:
#
#    pip-compile-multi
#
-r base1.txt
-r base2.txt

I realize, that it may be hard to follow the example. And maybe you have a different case where constraint files do not work as expected. So please share your requirements files and I'll add them to the test suite.


Loading the model weights

I have trained my model and got the weights in a .h5 file. Now I am trying to load them and generate feature maps. So just wanted to know whether my approach is Ok. Weights are in the file model_v1.h5
I used :
from keras_unet.models import satellite_unet

input_shape = x_train[0].shape

model = satellite_unet(
    input_shape,
    #use_batch_norm=False,
    num_classes=1,
    #filters=64,
    #dropout=0.2,
    output_activation='sigmoid',
    num_layers=4
)

from keras.callbacks import ModelCheckpoint

model_filename = 'model_v1.h5'
callback_checkpoint = ModelCheckpoint(
    model_filename,
    verbose=1,
    monitor='val_loss',
    save_best_only=True,
)

from keras.optimizers import Adam, SGD
from keras_unet.metrics import iou, iou_thresholded
from keras_unet.losses import jaccard_distance
from keras import metrics

model.compile(
    #optimizer=Adam(),
    optimizer=SGD(lr=0.01, momentum=0.99),
    loss='binary_crossentropy',
    #loss=jaccard_distance,
    metrics=[iou, iou_thresholded,metrics.binary_accuracy]
)

model.load_weights('model_v1.h5')

OR
should I load_weights directly after declaring the model and not create checkpoints and compile it :
from keras_unet.models import satellite_unet

input_shape = x_train[0].shape

model = satellite_unet(
    input_shape,
    #use_batch_norm=False,
    num_classes=1,
    #filters=64,
    #dropout=0.2,
    output_activation='sigmoid',
    num_layers=4
)

model.load_weights('model_v1.h5')

Please advise.

Hi @shubhamsharma1609
This again is the question dependency lib which is Keras/TF.
Saving/Loading whole models as well as just the weights of the model is very well covered in the original docs for Keras/TF
Good luck!


RDPWrap

v1.6 has stopped working on latest Redstone Win10 version.  Any suggestions on how to fix?  Thank you.  Specifically, the listening state says "not listening [not supported]".

Have you tried running update.bat as Administrator?

Yes, still does not work.
From: neuralx<EMAIL_ADDRESS>Sent: Monday, April 4, 2016 6:07 PM
To: stascorp/rdpwrap<EMAIL_ADDRESS>Cc: FrankenPahpii<EMAIL_ADDRESS>Subject: Re: [stascorp/rdpwrap] RDPWrap (#104)
Have you tried running update.bat as Administrator?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/stascorp/rdpwrap/issues/104#issuecomment-205517406 https://github.com/notifications/beacon/ARZ9N5aUOKc3odVe0fWngrzwH6aCcT59ks5p0YuDgaJpZM4H-rrb.gif

Probably a duplicate of https://github.com/stascorp/rdpwrap/issues/79


Does parse_poses poses_2d always return the full array of joints?

Does poses_2d return an array of all joints and their 2D locations or only the joints that are detected/not occluded in the image?
https://github.com/Daniil-Osokin/lightweight-human-pose-estimation-3d-demo.pytorch/blob/8794edc873d8db4f582dcc8a578f99bf4e218830/demo.py#L99

Yes, you can check the code.

Hello, the prediction effect of the provided model human body side angle is not very good. Is there a better prediction model

@yanglilongss Please, check #94.

Hope, it helped.


Refactor HashMap

Remove the Empty enum of  the Entry
Use FixedArray

Pull Request Test Coverage Report for Build 1527
Details

23 of 26 (88.46%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.404%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hashmap/hashmap.mbt
14
17
82.35%

Totals

Change from base Build 1526:
-0.03%

Covered Lines:
2700

Relevant Lines:
3020

💛  - Coveralls


Ignore all target flags when re-instantiating Orbit

When opening a capture file from an Orbit instance that was connected
using --taret_process / --target_instance or --target_uri, loading that
file fails. Orbit starts a new instance and copies all command line
parameters, but the aforementioned parameters should not be passed to
the new instance. This was broken when changing the parameter name.
Bug: b/238987946
Test: Manual testing - specify --target_process and --target_instance,
then open a capture

Closing this PR since I can't make any changes and the tests are failing.

Successor is here: https://github.com/google/orbit/pull/3960


Theme changes, api changes, etc.

Updated the gitignore to ignore the new api folder. Changes made to theme for the divider line. Grunt and bat updated for using api folder instead of docs.

There's merge conflicts with the demo. Not sure what's going on had some weird issues trying to get this build of Miruken up to date.


Add typing

Add type declarations (I think Python 3 native syntax, and drop 2.7 support)
Run mypy from tox
Run mypy in CI

@just1602 intéressé?

We should think about contributing typing stub file for boto3 and dotenv library.

Good idea!  The first goal here was to make sure the store and backend classes cooperate in the right way, in complement to integration tests.  Contributing a stub file to django-dotenv could be interesting!

@just1602 Any feedback on mypy vs pyre?

I didn't have the time to test yesterday. I'll have to test with ABC to see if it works with mypy. Otherwise we'll have to stay with pyre-check or open issue to mypy repo.

@merwok because pyre handle the inheritance correctly and not mypy. Mypy give me error that the parameter self is missing when I call a method of an object.

That seems like a pretty fundamental Python thing to handle.
https://mypy.readthedocs.io/en/latest/cheat_sheet_py3.html#classes

I tried running mypy

configstore/store.py:23: error: Too few arguments for "get_setting" of "Backend"
configstore/store.py:23: error: Argument 1 to "get_setting" of "Backend" has incompatible type "str"; expected "Backend"

I think the problem is that the type inference things that the objects in self._backends are Backend classes, not instances.

But pyre handle this gracefully. Maybe we should open an issue to see what's going on.

Validates if I use Tuple[Backend] without Type (after quickly checking the doc for Type that seems to be useful for more complicated setups).


Umm, plugin support?

Love this idea since theme-check could use more checks.
I see no reason why this can't work for a plugin. Care to make that happen?

See https://github.com/jrfnl/QA-WP-Projects for Juliette's code to go with her talk on exactly that.
Talk: https://speakerdeck.com/jrf/leveraging-the-wordpress-coding-standards-to-review-plugins-and-themes-1

One of the things I can also see where this could be an issue is that plugins can be written in a variety of ways, using different coding standards (not necessarily WPCS, but PSR for instance). So we would have to include those or even allow the addition of custom rulesets in the plugin.

I'll close this, as there is not much of activity around this issue. Plus I think once we release a new version, a fork could be made that will be for plugin checking (plugin-sniffer maybe).


[TreeView] Add checkbox support

[ ] I have followed (at least) the PR section of the contributing guide.

If this takes another 3 months.... 😆
Closes mui/mui-x#6019

Already seeing complications dealing with the dynamic mounting of children :(

@joshwooding I think that we should make the checkbox, drag & drop, multi-select, and advanced data-binding in the enterprise version. What do you think?

Already seeing complications dealing with the dynamic mounting of children :(

We've received a bunch of fixes over the past days regarding dynamically mounting and unmounting of TreeItem's.  But it's still a very hard issue so moving this to enterprise is understandable.

Closing this for now.

+1


current command isn't read on windows when navigating in the terminal accessible view

reported by @jooyoungseo

@jooyoungseo, I am calling alert here on navigating to the command. On macOS, this works beautifully. I haven't tested on Windows, but am not sure why it wouldn't work the same way there.
One reason it wouldn't work for you is if shell integration isn't enabled or activated properly. I know we've seen that happen for you before.
https://github.com/microsoft/vscode/blob/cfe166664c618eee308177cb4703bee176d21372/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts#L192
@rperez030, do you have any thoughts / can you repro the issue on windows:

run some commands in the terminal
open the accessible view
use alt/opt+up/down arrow to navigate between commands
you should hear the commands

@meganrogge It has nothing to do with the shell integration because the cursor actually moves, but the aria alert does not work on Windows.

hi @meganrogge. If I follow the steps, I only hear command failed / command succeeded for each command with the corresponding audio cue, and these are actually communicated as screen reader alerts.
if I do the same on the mac, I hear the command and the corresponding audio cue for success / failure, but not the command succeeded / command failed message. for the sake of troubleshooting, I disabled the signal announcement on Windows for command succeeded / command failed. After doing that I hear the audio cue only, but not announcement. I did a bit of debugging with NVDA, and the screen reader doesn't seem to be receiving any aria live update event.
One easy fix here could be to simply select the text for the command when the cursor moves to previous / next command. That would completely eliminate the need for an aria alert, and would likely work consistently across all platforms.

Thanks so much for troubleshooting @rperez030. I love that idea, will try it tomorrow.

I only hear the command status as "command succeeded" or "command failed" but not the command itself.

@karthiknadig do you see the command selected? A gif would help

@meganrogge it is not working for me because of this: https://github.com/microsoft/vscode/issues/227132

Makes sense - this feature is built on shell integration, so that'll have to work to test this

@Tyriar provided a fix for the shell integration. This is verified with that fix.


[Backport 2.x] Force merge API supports performing only on primary shards (#11269)

Description
Backport https://github.com/opensearch-project/OpenSearch/pull/11269 to 2.x.
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/8021
Check List

[x] New functionality includes testing.

[ ] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

❌ Gradle check result for e9b194d: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Failures are related to: https://github.com/opensearch-project/OpenSearch/issues/12593

❕ Gradle check result for e9b194d: UNSTABLE

TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testContainerCreationAndDeletion
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.forcemerge/20_wait_for_completion/Force merge index with wait_for_completion}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong It looks like below test is flaky. Can you check this please ?
>       1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.forcemerge/20_wait_for_completion/Force merge index with wait_for_completion}

❕ Gradle check result for 83fb554: UNSTABLE

TEST FAILURES:

      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

The failed test seems not related to this PR, and there's an issue tracking it but seems we haven't resolved it yet.

❕ Gradle check result for 7d1c255: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testRestartPrimary_NoReplicas

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Known issue: https://github.com/opensearch-project/OpenSearch/issues/11993

@gaobinlong We will need a forward port to change the version checks in main branch. Also probably we can update the yml tests as done in this PR. Can you also create a documentation issue or PR for this new option ?

@gaobinlong We will need a forward port to change the version checks in main branch. Also probably we can update the yml tests as done in this PR. Can you also create a documentation issue or PR for this new option ?

Thanks, I'll create a following PR for the main branch, and both of the related document issue and PR have been created yet.


Add constraint method to DatabaseError trait

Override constraint method for PgDatabaseError.
Fixes #821

Looks good to me. Thank you.

Looks good to me. Thank you.


Some keeper utilities are added in ClickHouse repository.

keeper-bench
keeper-data-dumper
keeper-overload
zookeeper-cli
zookeeper-dump-tree
zookeeper-remove-by-list

Thanks for your issue. We already have benchmark tool in repo. We can add if there is any demand.

Thanks for your issue. We already have benchmark tool in repo. We can add if there is any demand.


Relation membership not shown in iD

Hi,
I noticed that for some reason, iD fails to show relation membership for some nodes. E.g. see the image below of the node of Riyad (https://www.openstreetmap.org/node/315358390), the country capital of Saudi Arabia, where www.openstreetmap.org clearly display the membership of three relations, but iD fails to show any.
www.openstreetmap.org

iD

Noticed same behavior, but it seems it happened for each object which is linked to any relation and only for first attempt of opening. If you deselect the object and afterwards select it again then all the memberships are shown as expected, see:


HALON-720: Increase SSPL connection timeout to 5s.

Created by: nc6
Hopefully will fix race seen on KVM cluster with RabbitMQ not being
ready by the time Halon comes up and attempts to connect to it.

Closing as an obsolete


chore: update 4.x version links

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 91.074%

Files with Coverage Reduction
New Missed Lines
%

src/chart/controller/gesture.ts
4
82.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
11836

Relevant Lines:
12493

💛  - Coveralls


Add error.js file

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Please add test to verify that it works properly

Looks good
Only package.json in src and in samples shows as if changed


Memory leaks

Good day!
We are from dgraph again. We have been using your implementation of a lock-free hash.
We wanted to follow up from:
https://github.com/zond/gotomic/issues/5
Since the fix, it seems that we have been seeing memory leaks. We use the hash as a caching mechanism. When there is a miss, we load extra stuff into memory. We wonder if you may have some insights into why the changes / fix might have caused the memory leaks?
Thank you so much.
Jay

First a disclaimer: I haven't looked hard at the gotomic lib in several years.
It was really nice that you reported the race problems - when I created the lib there was no race detector IIRC, which let me miss a lot of necessary synchronization. You reporting the problems made me run the tests with the race detector on, and then simply add a lot of atomic.Load/StoreXXX calls where the race detector complained.
That this created memory leaks sounds very odd indeed. The algorithm is exactly the same, the only difference (unless I am greatly confused) is how memory is accessed.
I guess it's conceivable that the GC treats things differently depending on how they are accessed, but I've been under the impression that the GC only handles how references are stored, not how they are used.
In short, I don't understand how the latest changes should cause leaks - either the leaks should have been there before, or they should have been caused by something else...
Have you run the memory profiler? Have you changed anything else at the same time?

Hi Martin,
Thanks for the fast reply. We appreciate any help. Disclaimer is wholeheartedly accepted..
Yes, the algorithm is the same. What is puzzling is that on my desktop, it doesn't always happen. When it does, it will gobble up all 64G of my RAM. The bug is not very reproducible. On some test machine, it seems to be dying due to some other reason (https://discuss.dgraph.io/t/dissecting-the-dgraphloader-memory-usage/855/2). It also happened on some other machine (laptop of a colleague). I will need to do more runs with memory profiling....
The way we clear memory for gotomic hash is just through this one line:
https://github.com/dgraph-io/dgraph/blob/master/posting/lists.go#L308
I wonder if it is because we are adding the same key that we are trying to delete all at the same time..
Jay

I looked at the code again, and realized that the hash removes elements lazily.
The list has only one remove function, Pop, which does remove() that first inserts a delete marker in the list, then forces the marked element to be removed by doing next() on it's predecessor (the list head).
The hash just calls doRemove() on the element it wants gone, but never next() on the element before.
I just pushed https://github.com/zond/gotomic/commit/c442ca1e4aa6e53bdcd0ef5b5d691564436a6867 that does a next() on the element found to the left of the one removed. This should force a removal of the actual element and its deleted marker.
Check if that helps!

Hi zond (sorry, I am not sure how to address you),
A colleague of mine (Pawan) did a memory profile:
https://dl.dropboxusercontent.com/u/99140533/mem.svg
It seems to suggest that the gotomic hash allocates a lot of memory. I believe posting.NewList is the one that allocates memory for values of the hash, so the memory allocated by gotomic hash is something else, say the keys and internal structures to represent buckets, linked lists etc I suppose.
*Wonder if some optimization can be done here to reduce the memory usage? I should perhaps file this as a separate issue.
With respect to the original issue, I haven't seen it occur again yet. However, I will still want to try out your change and do some memory profiling again.
As always, thank you for your speedy replies!
JC
(on behalf of Dgraph team)

Hey JC, sorry for not introducing myself earlier!
My name is Martin Bruse. Nice to meet you guys :D
In your profile, it seems that most of the in-use memory is connected to the String() functions of the gotomic data types - are you perchance printing the hash regularly, or doing some other introspection that calls String() on them?
But yeah, the atomic hash isn't as efficient - space- or time-wise - as a regular map[...]....
If you haven't seen the original issue lately, I'll just close this ticket. Re-open if it occurs again!
My usual speedy replies will be slightly slower now, since my second child was born 2 days ago :)
best,
Martin

Thank you Martin for all the help thus far! And all the best with your second child!


[2.0] Ray tracing?

(I just wrote the version, because it's not known when it really can happen.)
Soon (namely, in about 2 years approximately), almost all hi-end GPUs will be able to use ray tracing technology at an acceptable level. As I propose to create a field for experiments with various implementations of this technique. I know that mass production is still very far away.

It certainly appears to be a direction where things are going. nVidia have seem to have gotten furthest with their RTX technology, but it remains to be seen how portable that is, or how tied to their products it is. If it ends up being a general purpose solution for all high-end hardware it would be a nice thing to integrate.
AMD has their Radeon Rays, which we'll probably be integrating for light baking in the future, but it wasn't designed for real-time AFAIK - the biggest problem being the handling of dynamic scenes/geometry (as is usually the case with raytracing). But they might be motivated by nVidia and make a few updates to it.

This will be available on the software side as well for the cards that don't support RTX. I just don't know if that by "software" side, they mean, using something like OPENCL/CUDA or using the CPU.
For the star wars demo, it required 4 cards in SLI, and the scene was not that big. It improve the speed, of rendering, but there some years to wait before having "real time raytracing" for big scenes in 4K from a single GPU...
But this open new doors, for new doors for productions that is using that technology to render 3D cartoon and 3D scene (Zafari made in Montreal at Digital Dimension. This is an area of interest for me, and Banshee perhaps could allow that in the future. Unity also use this for the Project Adam and this tech will help them produce faster.


Package: Attention

Implement attention algorithms:

[ ] Flash attention 2
[ ] Flash attention 3
[ ] Other attention algorithms

Those would be added as kernels in burn-jit, but using the cube macro?

@cBournhonesque yes, we are not sure where we will put the kernel implementations though. For now matmul is in cubecl-linalg, but we might create other themed crates.


truncate leap seconds on chrono to datetime conversions

Fixes #3424
As discussed in that issue, I decided to proceed to truncate leap-seconds and emit a warning when doing so.
Most the diff is adjustment to test code to adjust for the logic, check the warning is raised and also deal with increased strictness of when leap-seconds are allowed in chrono 0.4.31.

I split out #3469, please review that first.

Also moved the warnings testing logic out into #3470.

Rebased; this now contains purely the behavioural changes plus updates to accompanying tests.

If I don't hear reasons not to, I'll merge this on Friday so that I can work on a fix for #3266 without having masses of conflicts.


Add silenced and receiver options to new UI

check box for silenced?
some form of auto-complete/suggestion box (still scrollable) for receiver

@stuartnelson3 Editing this as discussed in the meeting.

Partly fixed by #799.
Now only inhibited is missing.

This is related to issue #801.

Closing this issue as we now have checkboxes to show/hide silenced and inhibited alerts


Enhancing Readme of Q-Queue folder

Description
Properly readme is not organised, links are not at all working no any table of contents.
Domain
README
Type of Contribution
Enhancement
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


cleanup: Modifies Wrapcheck linter

Wrapcheck is a  simple Go linter to check that errors
from external packages are wrapped during return to
help identify the error source during debugging.
This commit addresses the wrapcheck error
Updates:#2025
Signed-off-by: Yati Padia<EMAIL_ADDRESS>

@Madhu-1 created seprate PR for easier merge and also have addressed the comments mentioned by you in https://github.com/ceph/ceph-csi/pull/2025

/restest ci/centos/mini-e2e/k8s-1.20

@mergifyio rebase

/retest ci/centos/k8s-e2e-external-storage/1.20

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/k8s-e2e-external-storage/1.20

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e/k8s-1.20

/retest ci/centos/upgrade-tests-rbd

/retest ci/centos/k8s-e2e-external-storage/1.20

/retest ci/centos/upgrade-tests-rbd

/retest ci/centos/mini-e2e/k8s-1.19

/retest ci/centos/mini-e2e/k8s-1.19

#1969 caused the issue:
Waiting up to 3m0s for all (but 0) nodes to be ready


Support wildcards in --match-filter

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.05. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.04.05

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.04.05
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue required an account credentials please provide them or explain how one can obtain them.
Hi, the "--match-filter" does not work on the "description" key :
$  youtube-dl --ignore-config -v --get-title https://www.youtube.com/channel/UCFyNsaSkagjA-z-o6qf10nA/videos  --match-filter "description like *karambiri*"
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'--ignore-config', u'-v', u'--get-title', u'https://www.youtube.com/channel/UCFyNsaSkagjA-z-o6qf10nA/videos', u'--match-filter', u'description like *karambiri*']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.05
[debug] Python version 2.7.8 - Linux-3.16.0-44-generic-x86_64-with-Ubuntu-14.10-utopic
[debug] exe versions: avconv 11.2-6, avprobe 11.2-6, ffmpeg 3.0.1-1, ffprobe 3.0.1-1, rtmpdump 2.4
[debug] Proxy map: {}
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/__init__.py", line 419, in main
    _real_main(argv)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/__init__.py", line 409, in _real_main
    retcode = ydl.download(all_urls)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 1725, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 680, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 732, in process_ie_result
    extra_info=extra_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 680, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 840, in process_ie_result
    extra_info=extra)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 732, in process_ie_result
    extra_info=extra_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 680, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 725, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 1371, in process_video_result
    self.process_info(new_info)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 1442, in process_info
    reason = self._match_entry(info_dict, incomplete=False)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 632, in _match_entry
    ret = match_filter(info_dict)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/utils.py", line 2105, in _match_func
    if match_str(filter_str, info_dict):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/utils.py", line 2100, in match_str
    _match_one(filter_part, dct) for filter_part in filter_str.split('&'))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/utils.py", line 2100, in <genexpr>
    _match_one(filter_part, dct) for filter_part in filter_str.split('&'))
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/utils.py", line 2093, in _match_one
    raise ValueError('Invalid filter part %r' % filter_part)
ValueError: Invalid filter part u'description like *karambiri*'
$ echo $?
1

Can you help ?

I just wanted to download a bunch of videos from a Instagram profile with a specific hashtag. Sadly I can't check for existence of this hashtag since --match-filter doesn't support wildcards or RegEx.
Please add support for it! It would be really powerful.


0.35.8.plugin

closes #619 and #620

Codecov Report

Merging #623 (2789d1c) into 0.35.8 (1e2b23b) will decrease coverage by 24.41%.
The diff coverage is 76.80%.

:exclamation: Current head 2789d1c differs from pull request most recent head e169420. Consider uploading reports for the commit e169420 to get more accurate results

@@             Coverage Diff             @@
##           0.35.8     #623       +/-   ##
===========================================
- Coverage   93.03%   68.61%   -24.42%
===========================================
  Files          98      112       +14
  Lines       19735    21114     +1379
===========================================
- Hits        18360    14487     -3873
- Misses       1375     6627     +5252

Impacted Files
Coverage Δ

src/lib/descriptor/makefiles/mod_test.rs
61.11% <0.00%> (-37.04%)
:arrow_down:

src/lib/descriptor/mod_test.rs
55.65% <0.00%> (-39.59%)
:arrow_down:

src/lib/environment/mod_test.rs
11.71% <0.00%> (-83.94%)
:arrow_down:

src/lib/mod.rs
100.00% <ø> (ø)

src/lib/runner_test.rs
29.58% <15.18%> (-61.27%)
:arrow_down:

src/lib/plugin/runner_test.rs
59.24% <59.24%> (ø)

src/lib/condition_test.rs
52.25% <59.25%> (-41.19%)
:arrow_down:

src/lib/descriptor/mod.rs
57.77% <60.00%> (-29.37%)
:arrow_down:

src/lib/scriptengine/mod_test.rs
80.60% <66.66%> (-14.81%)
:arrow_down:

src/lib/runner.rs
48.90% <70.27%> (-32.46%)
:arrow_down:

... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2b23b...e169420. Read the comment docs.


fix: Entity scale not being updated

The scale of entities was only being updated when manually updating the sizing while already in the server, rejoining would reset the entity scale

thank you 👍


Fail to deploy a downstream cluster

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Deploy rancher.
Create a downstream cluster (AWS ec2/Digital Ocean droplet)

Result:
The nodes are in active state, but the cluster is in the provisioning state with the following message in UI:

Other details that may be helpful:
Environment information

Rancher version: v2.5-head 55c6751
Installation option (single install/HA): Single install

Docker version (use docker version):19.3.15

https://github.com/rancher/rancher/pull/31124

Validated on Rancher v2.5-head (8201e08) and master-head(fbe2c30).
Steps:

Deploy rancher single install.
Add a downstream cluster with ec2 provider.

Results:
The cluster is deployed with no error message.

Validated on Rancher v2.5-head (8201e08)
Steps:

Deploy rancher single install.
Add a downstream cluster with ec2 provider.

Results:
The cluster is deployed successfully with no error message.

This is reopened waiting for PR of master-head.

@kinarashah It doesnt look like the original PR to add env vars to the agent is in master? What issue is that associated with?

@qian The changes related to this fix hasn't been introduced into master, so this could be closed with just the fix for 2.5.

Waiting for a PR/fix for this issue in master-head. Using this issue to track it as per offline conv with @kinarashah . Moving to reopened.

Validated on Rancher master-head 007e298.
Steps

Deploy rancher single install.
Create two downstream clusters (AWS, Digital Ocean).

Results
Clusters have been created successfully, all nodes are in active state with no error messages.


useLocalStorage should support JSON.stringify replacer's and reviver's.

I am using Typescript and have a Type that contains Set's. When using useLocalStorage this fails because Set's can't be serialized with JSON.stringify and as such they disappear from my type.
The solution to having JSON.stringify work on Set's is to use the replacer function on JSON.stringify and the reviver function on JSON.parse.
It would be good if useLocalStorage could take in these functions as optional parameters to be used during stringify and parse or alternatively callbacks that control the serialization and deserialization process.

Currently, JSON.stringify is an internal implementation, exposing replacer and reviver would expose that internal detail. What are the benefits/drawbacks of normalizing or serializing the data before passing it to the useLocalStorage hook?

That's fair enough about not wanting to expose the internal implementation, the issue is that the internal implementation can silently fail.
I do currently have a custom hook which wraps the useLocalStorage hook and performs the serialization before and after and that works fine, but it's not as succinct as just being able to pass in a serializer & deserializer function.
Given that the constraint/api on localStorage is to use string values perhaps having optional parameters one for the serializer which is T => string and once for the deserializer which is string => T and the default impementation of those is JSON.stringify and JSON.parse?

Yeah, I like the idea of serializer to be an optional argument.


bots: Bots can post to announcement-only streams if their owner can.

Bot owned by a non-admin gets blocked, and one owned by an admin
can post to announcement-only stream.
Fixes: #12310.

#12310
Testing Plan:
Wrote automated unit tests
GIFs or Screenshots:

Note: While writing tests for this issue I discovered few buggy tests (see: https://chat.zulip.org/#narrow/stream/49-development-help/topic/.2Fapi.2Fv1.2Fmessages.20vs.20.2Fjson.2Fmessages.20endpoint for context). I will be fixing them in another PR.

@timabbott Please take a look.

@Hypro999 can you help review this?

Merged, thanks @thedeveloperr!