Greg7mdp/cmake

Merged the two versions of list_licenses into a single version which should work with all compilers.

@greg7mdp Thanks for the PR, but this doesn't work for all license files. I've made the necessary changes in https://github.com/google/filament/pull/1684.

That is great, thanks @bejado!


Regret analysis

Do you have a regret analysis of your optimizer?
Thanks!

The tech report contains an analysis in the stochastic setting rather than the online setting so its not a regret analysis exactly but a convergence rate bound:
https://arxiv.org/abs/2101.11075


Editor ignores Ctrl + Shortcuts after saving with Ctrl + S

Godot version
v4.0.2.stable.official [7a0977ce2]
System information
Win 64
Issue description
After saving in the code editor using Ctrl + S, no shortcut keys using the Ctrl key work until the Ctrl key is released.
Steps to reproduce

Open a GDScript file in the GDScript editor -- any file which is large enough to scroll around.
Press Ctrl + S, keeping Ctrl held down. The 'Saving Scene' window appears briefly, and disappears before returning focus to the GDScript editor.
With Ctrl still held down, press Ctrl + Down. This should scroll the window, but instead it moves the cursor.
With Ctrl still held down, press Ctrl + Shift + D. This should duplicate the current line, but instead has no effect.
With Ctrl still held down, press Ctrl + Shift + O. This should launch the "Quick Open Script..." window, but instead has no effect.
Release Ctrl and try the shortcuts again. All shortcuts work properly.

Minimal reproduction project
N/A

v4.3.dev.custom_build [fe01776f0]
I can reproduce this in my "game" (custom world editor) that uses MenuBar as well.

v4.3.dev.custom_build[4a0160241]
When trying to reproduce the problem on macOS I could not recreate it. However when switching to Windows 10, I was able to reproduce the problem.
I agree with @dkaste that it must be due to a pop-up window when saving. However, when there is only a script file in the project, this bug isn't reproduced. I was only able to recreate it after also making a Scene in the same project as well as a script file. So it seems when Ctrl+S is pressed to save the project as a whole, the scene save pop-up window causes the Ctrl button press to no longer be marked as hit/activated.

v4.3.dev.custom_build[4a01602]
I believe that I have identified the root cause of the issue, which seems to pertain to the implementation of popups in accordance with the Windows API. Specifically, the popups that are created when executing the saving operation via shortcut commands that seem to be diverting focus away from the primary editor window. This behavior is observed within the else statement in the file display_server_windows.cpp, accessible at the following location: Link.
My familiarity with the intricacies of the Windows API utilized in this context is somewhat limited. Despite this, I attempted to mitigate the issue by experimenting with various methods to alter the focus behavior, including the exclusion of the SetFocus() command from execution. However, these attempts did not yield the desired outcome when recompiling the program.
These adjustments appeared to have adverse effects on the functionality of other window generation processes, notably during instances such as file selection prompts within the "Save as..." feature. Consequently, If there is any advice anyone has about the utilization of the Windows API in this context, it would be greatly appreciated!

CC @bruvzg @RandomShaper


[Azure Monitor] @azure/monitor-opentelemetry-exporter 1.0.0-beta.14 release

API change check
API changes are not detected in this pull request.


JavetProxySymbolIterableConverter does not return iterable

I was debugging a small script I was running and I ran into an issue in the Javet code. When you call array[Symbol.iterator] it should return a javascript object with a .next() function that can be called to get the next item in the iteration.
What I am finding is that it just returns the array itself (converted to being a javascript object) which does not have the required .next() method leading to null pointers in our javascript code.
As a sample, the following should return an iterator but right now it's returning undefined (this is based on a test case in TestJavetBridgeConverter):
V8Runtime runtime = V8Host.getV8Instance().createV8Runtime();
runtime.setConverter(new JavetBridgeConverter());
Integer[] intArr = new Integer[]{1,2};
runtime.getGlobalObject().set("a", intArr);
System.out.println(runtime.getExecutor("a[Symbol.iterator]()").execute().invoke("next")); //undefined

Just as a followup, the following javascript code is producing the actual iterator which matches what seems to be wrong.
Change the last line to:
System.out.println(runtime.getExecutor("a[Symbol.iterator]()[Symbol.iterator]()").execute().invoke("next")); //{}

Thank you for choosing Javet. That's a known feature that hasn't been seriously implemented yet. I thought no one was using it. I'm glad that it's actually being used. I will prioritize it and keep you updated.
By the way, there are a few others symbols not implemented yet. Please let me know which ones you need.

That has been implemented in this commit. You are welcome taking a try. It will be included in the next release.


Possible wasm support

It has been done for the other cpp port
https://github.com/H-Plus-Time/web-zxing

That is interesting, I didn't know such thing exist.
Thanks for your suggestion, I will definitively look into it when I have a chance.

Thank you for this! I needed PDF417 support in WebAssembly and you saved me.
I came from using ZBar in WebAssembly and the .wasm output file was only about 50K but with your build I get a 1.3Mb file which is considerably larger. I think it's mostly because ZBar allows me to disable different symbols and only enable those I'm interested in. Is that possible to do? Thanks

There is a build option in CMakeFiles.txt to disable either all encoders or all decoders. If you don't need to generate images, just disable encoders will reduce file size about 0.5MB.
To disable individual decoders, you can have a look at core/src/MultiFormatReader.cpp and comment out symbols you don't need. You can leave them in project without problem. As this is the only place where they are specifically referenced, the linker will do the job of removing unused code.

Yes, I'm already disabling encoders. I'll take a look at disabling symbols I don't need from that file. Thanks!

@huycn That worked. It's now on ~800Kb which is more acceptable. It would be great to be able to disable specific encoders or decoders as a configure parameter but this works for now :)
Thanks!

Hum... 800Kb is when I disabled encoders with -DENABLE_ENCODERS=0 but leave all decoders active. When I disable all symbols except PDF417, I got 400Kb. I believe there still something not removed properly since 400Kb is still a lot, considering PDF417 doesn't need TextDecoder where unicode data mapping takes a good amount. I'll  look further into this later. But now, 800Kb what you get is something unexpected. Are you sure you compiled with -DCMAKE_BUILD_TYPE=Release?
Also, you may want to try to edit wrappers/wasm/CMakeLists.txt and add -O3 at line set (CMAKE_CXX_FLAGS .... I remember I played a little bit with my emscripten installation to make -O3 instead of -O2 as default flag for release.
There is also RTTI and exceptions we can disable to reduce further file size, but some reason I ignore, I got compilation error when I try to disable RTTI with -fno-rtti


switch build process from gulp to webpack

the gulp-based build process is outdated and does not reflect how we currently set up projects (as this repo was not maintained since years but some ventures still use it as a reference to set up new projects)

Maybe this should be up for discussion: how useful is a starter like this? would it be more useful to have useful config snippets that can then be combined according to our needs?

that'd also be a great change, but since ventures are still refering to the current code base with gulp and without snippets, maybe we can introduce these changes in separate PRs?


missing Go To Definition and Peek Definition

VSCode Version: Code 1.11.2 (6eaebe3b9c70406d67c97779468c324a7a95db0e, 2017-04-13T08:03:11.395Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

Bookmarks
alefragnani
0.14.1

project-manager
alefragnani
0.15.1

status-bar-tasks
GuardRex
0.2.0

output-colorizer
IBM
0.1.1

yuml
JaimeOlivares
2.10.0

mssql
ms-mssql
0.3.0

cpptools
ms-vscode
0.11.0

After updating cpptools to version 0.11.0, 'Go To Definition' and 'Peek Definition' are not working and are missing in sub-menu:

If it's an issue with cpptools, wouldn't it be more appropriate to file an issue at https://github.com/Microsoft/vscode-cpptools then instead?

you're right, i'll move the issue there. Thank you!


Simplify the List of Takeout Containers

Changed

Extracts the base and full aliases from the takeout list command and put those behind an optional --networking flag

Hi, now list command have --networking option.

Here an output example:

--json option is done on #149 .
Do we need a network command to listtakeout networks?

Do we need a network command to list takeout network?

Would there be any particular value in that?

OK, looks good to me with the one suggestion fixed!

OK, looks good to me with the one suggestion fixed!

 While I wait for the day Matt can sign my Laravel up&running books, I’m always up for collaborating on this project, even if this PR is from 4 years ago. Feel free to reach out to me for any future developments too! 🤓

@danielebarbaro thanks for the work on this! 😄


server/storage: Add admin endpoint to manually run range through queue

PR: https://github.com/cockroachdb/cockroach/pull/26554
From release notes:

The new /_admin/v1/enqueue_range admin server endpoint runs a specified range through a specified internal queue on one or all nodes. The skip_should_queue parameter can also be specified to tell the system to blindly run without first checking whether it needs to be run. This endpoint is intended primarily for debugging purposes. [#26554][#26554] {% comment %}doc{% endcomment %}

Is this mostly for internal debugging, @a-robinson?

Correct, this is for internal debugging.

OK, thanks, @a-robinson. Closing.


NNBD: dart2js-hostasserts-strong-linux-x64-chrome build fails with "Uncaught TypeError: Cannot read property 'Object' of undefined" error.

Here is a link to the log file.
Sample output is:

/b/s/w/ir/tools/sdks/dart-sdk/bin/dart pkg/test_runner/bin/launch_browser.dart chrome http://<IP_ADDRESS>:46279/root_build/generated_tests/dart2js-chrome/tests_co19_src_LanguageFeatures_Simple-bounds_dynamic_class_FutureOr_l1_t03/test.html?crossOriginPort=40893
Runtime window.onerror:
window.onerror called:
http://<IP_ADDRESS>:46279/root_build/generated_compilations/dart2js/tests_co19_src_LanguageFeatures_Simple-bounds_dynamic_class_FutureOr_l1_t03/class_FutureOr_l1_t03.js:1130:
Uncaught TypeError: Cannot read property 'Object' of undefined
Deobfuscated error and stack:

at window.onerror called:                                         unparsed
at                                                            out/ReleaseX64NNBD/generated_compilations/dart2js/tests_co19_src_LanguageFeatures_Simple-bounds_dynamic_class_FutureOr_l1_t03/class_FutureOr_l1_t03.js 1130
at Uncaught TypeError: Cannot read property 'Object' of undefined unparsed
exit code:
0

Failing co19 test are:

co19/LanguageFeatures/Simple-bounds/dynamic/class_l1_t05
co19/LanguageFeatures/Simple-bounds/dynamic/class_l1_t06
co19/LanguageFeatures/Simple-bounds/dynamic/class_l1_t07
co19/LanguageFeatures/Simple-bounds/dynamic/class_l1_t08
co19/LanguageFeatures/Simple-bounds/static/class_typedef_l1_t04
co19/LanguageFeatures/Simple-bounds/static/class_typedef_l1_t08
co19/LanguageFeatures/Simple-bounds/static/typedef1_typedef_l1_t04
co19/LanguageFeatures/Simple-bounds/static/typedef1_typedef_l1_t08
co19/LanguageFeatures/Simple-bounds/static/typedef_FutureOr_l1_t04
co19/LanguageFeatures/Simple-bounds/static/typedef_l1_t09
co19/LanguageFeatures/Simple-bounds/static/typedef_l1_t10/none
co19/LanguageFeatures/Simple-bounds/static/typedef_l2_t01
co19/LanguageFeatures/Simple-bounds/static/typedef_typedef_l1_t05
co19/LanguageFeatures/Simple-bounds/static/typedef_typedef_l1_t09
co19/LanguageFeatures/Simple-bounds/static/typedef_typedef_l1_t10
co19/LanguageFeatures/nnbd/future_flattening_A01_t29
co19/LanguageFeatures/nnbd/future_flattening_A01_t30
co19/LanguageFeatures/nnbd/future_flattening_A01_t31
co19/LanguageFeatures/nnbd/future_flattening_A01_t33
co19/LanguageFeatures/nnbd/future_flattening_A01_t41
co19/LanguageFeatures/nnbd/future_flattening_A01_t43
co19/LanguageFeatures/nnbd/future_flattening_A01_t44
co19/LanguageFeatures/nnbd/future_flattening_A01_t47
co19/LanguageFeatures/nnbd/future_flattening_A01_t53
co19/LanguageFeatures/nnbd/future_flattening_A01_t54
co19/LanguageFeatures/nnbd/future_flattening_A01_t57
co19/LanguageFeatures/nnbd/future_flattening_A01_t58
co19/LanguageFeatures/nnbd/future_flattening_A01_t59
co19/LanguageFeatures/nnbd/future_flattening_A01_t64
co19/LanguageFeatures/nnbd/future_flattening_A01_t65
co19/LanguageFeatures/nnbd/future_flattening_A01_t66
co19/LanguageFeatures/nnbd/future_flattening_A01_t75
co19/LanguageFeatures/nnbd/future_flattening_A01_t76
co19/LanguageFeatures/nnbd/future_flattening_A01_t77
co19/LanguageFeatures/nnbd/future_flattening_A01_t79
co19/LanguageFeatures/nnbd/future_flattening_A01_t80

This failure is not reproducible with other run modes.

This is a duplicate of #41502


Issue on docs

Path: /integrations/databases/ClickHouse
There is an error on this page "🚧 A parsing error occured. Please contact the owner of this website."

The doc is fixed: https://docs.mage.ai/integrations/databases/ClickHouse
Thanks for reporting the issue.


Parameter names in callback results in BayesSearchCV

I'm trying to use a callback function to echo out results after each iteration when optimizing with BayesSearchCV, using the callback API, including hyper parameter values and names.
I'm able to get the results dict, but I can't keep track of the hyper parameter values since the results dict only contains the parameter values, not the parameter names.  I've tried inferring the parameter names from the search space, results['space'].dimensions, in the results, but this fails because the name attribute of the dimensions does not seem to be preserved except for Categorical dimensions.  For Real and Integer types, the name is reported as None.  This is a problem since the parameters get re-ordered.
Maybe I'm going about this wrong, but is there a way to pass the hyper parameter names and values to a callback function in BayesSearchCV.fit?

Hello @ibackus ,
Here is one example how you can echo out the hyperparameter values tried:
from skopt import BayesSearchCV
from skopt.utils import point_asdict

from sklearn.datasets import load_iris
from sklearn.svm import SVC

X, y = load_iris(True)

search_space = {
    'C': (0.1, 10.0)
}

model = BayesSearchCV(
    estimator=SVC(), search_spaces=search_space
)

def cb(v):
    last_point = v.x_iters[-1]
    p = point_asdict(search_space, last_point)
    print(p)

model.fit(X, y, callback=cb)

Beware that above will work with search space being a dictionary, but not a list of dictionaries.
Another way would be to inherit a class that is used as an estimator, and override a set_params method, which is used by BayesSearchCV to output the parameters. This should work also with search over multiple spaces, defined by the list of dictionaries. Here is how that would look like:
from skopt import BayesSearchCV
from skopt.utils import point_asdict

from sklearn.datasets import load_iris
from sklearn.svm import SVC

X, y = load_iris(True)

search_space = {
    'C': (0.1, 10.0)
}

class MySVC(SVC):
    def __init__(self, C=0.1):
        super().__init__(C)

    def set_params(self, **params):
        print(params)
        super().set_params(**params)

model = BayesSearchCV(
    estimator=MySVC(), search_spaces=search_space
)

model.fit(X, y)

This requires you to modify the estimator though.

Thanks for the response, this is just what I was looking for.
I have used your second solution (overriding set_params), but that is not ideal for many use cases.
Your first solution works perfectly for me, I was not aware of point_asdict.  Thank you!

Ok then :)

Few more things I've ran into when trying to use a list of dictionaries to search over, you can use a more general version of Iaroslav's 2nd approach like
X, y = load_iris(return_X_y=True)

search_space = {
    'C': (0.1, 10.0)
}

class MySVC(SVC):
    def set_params(self, **params):
        print(params)
        return super().set_params(**params)

model = BayesSearchCV(
    estimator=MySVC(),
    search_spaces=search_space
)

However when you pass n_jobs=-1, I couldn't get it to print until the end. So with help from chatgpt I arrived at
search_spaces = [
    {'C': (0.1, 10.0)},
    {'C': (0.01, 1.0)}
]

def cb(v):
    # Iterate over search spaces to find the correct space for the current point
    for space in search_spaces:
        try:
            p = point_asdict(space, v.x_iters[-1])
            print(p)
            break
        except ValueError:
            continue

model = BayesSearchCV(
    estimator=SVC(),
    search_spaces=search_spaces,
    n_jobs=-1  # Use all available cores in parallel
)

which seems to work for lists of dictionaries as well.
A version that works for the 3rd option in search_spaces, list of tuples
def cb(v):
    # Iterate over search spaces to find the correct space for the current point
    for space, _ in search_spaces:
        try:
            p = point_asdict(space, v.x_iters[-1])
            print(p)
            break
        except ValueError:
            continue

Finally a general version to handle all 3 cases
def generalized_callback(v):
    """
    Callback function to print the parameters being evaluated.
    Handles dictionaries, lists of dictionaries, and lists of tuples.
    """
    # If search_spaces is a dictionary
    if isinstance(search_spaces, dict):
        spaces = [search_spaces]
    # If search_spaces is a list of dictionaries or tuples
    else:
        spaces = [space if isinstance(space, dict) else space[0] for space in search_spaces]

    # Iterate over the spaces to find the correct space for the current point
    for space in spaces:
        try:
            p = point_asdict(space, v.x_iters[-1])
            print(p)
            break
        except ValueError:
            continue


Generic Executor traits

Sometimes I'd like to provide a generic interface, and need to ask for an executor to spawn one or more Futures.  But now I need to name the Future types I want to spawn in the public interface (or box them), and I'd rather avoid that.
It would be nice if rust supported something like this (but it doesn't afaict...):
fn spawn_some_local_future(e: &E)
where
    for<F: Future<Item = (), Error = ()> + 'static>: Executor<F>
{
    // ...
}

As far as I can see there is usually no reason for an executor to run only very specific Futures; the main difference is whether a Future is Send or not.
So I'd like to see generic interfaces like this:
pub trait LocalExecutor: RemoteExecutor + RemoteClosureExecutor {
    fn execute_local<F>(&self, f: F) -> Result<(), ExecuteError<F>>
    where
        F: Future<Item = (), Error = ()> + 'static,
    ;
}

pub trait RemoteExecutor {
    fn execute_remote<F>(&self, f: F) -> Result<(), ExecuteError<F>>
    where
        F: Future<Item = (), Error = ()> + Send + 'static,
    ;
}

pub trait RemoteClosureExecutor {
    fn execute_remote_closure<C, F>(&self, c: C) -> Result<(), ExecuteError<C>>
    where
        C: FnOnce() -> F + Send + 'static,
        F: Future<Item = (), Error = ()> + 'static,
    ;
}

Implementations for tokio Core, Handle and Remote are trivial (Remote obviously can't implement LocalExecutor).

As far as I can see there is usually no reason for an executor to run only very specific Futures; the main difference is whether a Future is Send or not.

It is very useful to be able to be generic over the specific future. Being able to accept any future means that the executor will be forced to use allocations + dynamic dispatch. Being able to specify the exact future type allows for more optimized executors that are able to operate w/o allocations or dynamic dispatch.

I see. So what you're saying is that a good library should always wrap it's Futures in explicit types (this won't work though with closures and #[async] afaict).
And if I'm not willing to do this, an event loop handling generic Future types will probably box them anyway.  If we now could avoid the double-boxing somehow I'd be convinced there is no real need for those traits.

There is no need to double box. You can see how existing event loops impl Executor today.
Libraries in general probably want to return explicit types in order to be able to extend the library without breaking changes but it is up to the library authors. Abstract type should help as well when that lands.

I agree there is no generic need, but I'm pretty sure tokio will double box in Handle::spawn if I pass an already boxed future.
How could tokio avoid it? Maybe trying to match some boxed Future types with Any::is and some crazy memory transforms? Probably easier to create a separate spawn_box function; but this won't be accessible through the existing Executor interface until RFC 1210: impl specialization lands.

This issue sounds like it may be a bit more general than double boxing (but I may be misinterpreting?) but yeah for now the most likely way we'll avoid double-boxing in the future is via specialization, but in the meantime we could also add a separate spawn function for boxed futures if necessary!

See the executor RFC.

The Executor trait looks fine to me - imho this issue can be closed.

Closing, this has been addressed.


artpar's attempt

Trying to do multiple things at once

memory mapped files
parallel processing
aggressive caching for object creations/parse paths

Hey @artpar, thanks a lot! Could your rebase this one to latest main and squash everything into a single commit? Right now, I am getting an NPE when running it:
java.lang.NullPointerException: Cannot invoke "java.lang.Double.doubleValue()" because "doubleValue" is null
	at dev.morling.onebrc.CalculateAverage_artpar$ReaderRunnable.run(CalculateAverage_artpar.java:209)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

sorry i messed up my git. recreated from scratch
https://github.com/gunnarmorling/1brc/pull/27


fix(sharding): Distributed migrations table

Part of https://github.com/PostHog/posthog/issues/8652
clickhouse-operator only creates tables backed by Distributed engine onto new shards, see https://github.com/Altinity/clickhouse-operator/issues/903 for more details. We automatically create PostHog tables manually (see https://github.com/PostHog/posthog/pull/8912) but clickhouse migrations also need to be runnable no matter what clickhouse node we hit.

Verified this works - merging to make integrating with main repo easier.


Remove PlatformUtils

Doesn't look like it's being used anywhere...

Actually, 3D skin layers compatibility hack will be completely in playerAnimator (or a third mod)
this looks good.


Admin Web-Actions request submit form cannot handle long, unbroken values

We have some inputs that are very long strings, and the use of the <pre> causes the layout to overflow. This, paired with the flex-end justification of the submit buttons makes it a bit difficult to use and not so great to look at.

Apologies, I found that the component rendering the <pre> tag is in misk-web. Here's the issue in the correct repo. Closing this!


Remove version: VirtualGL.VirtualGL version 3.0.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Package still available.;


Some improvements

clicks and inputs now basically works. [tested on bing.com searches]
output a json that feed to GenericScript.js
usage: node src/GenericScript.js data.json
data.json is the plugin output json.

@c19 Thanks for the PR! However, your PR completely changes the expected behaviour of the code generated. I can see what you're doing but the idea of Puppeteer Recorder is that it creates a fairly easy to read, imperative puppeteer script. This means I won't merge the PR.
I would like to use some of your ideas on de-doubling events etc. Is it ok if I use some of your code as inspiration? I will mark you as a contributor to this repo.

@c19 I would recommend you keep adding things to your fork of this repo. Saving to servers is not something in scope right now.


Help for using GSLAM via python3

Hello and thank you for your work!
I want to use GSLAM via Python3 and fail to understand the install. I am able to build the project via cmake, but I cannot install via pip3.
When using pip3 install GSLAM I get the following error:
ERROR: Could not find a version that satisfies the requirement GSLAM (from versions: none)
ERROR: No matching distribution found for GSLAM
So then I tried via the provided setup.py file but I cannot find any module to import.
What am I doing wrong and why can I not install via pypy?
Thank you for any help!

朋友你好！我想请教一下您这边是如何解决解决gslam系统python安装和使用的相关问题。 @ChenHoy

I have not found any solution. @AcresJoe1
I would like the authors to clarify this, since I am not sure how Svar works. But as of now, there are no working bindings for the C++ Code...

It should work just use pip3 in the TopDir of GSLAM:
pip3 install .

我没有找到任何解决方案。@ AcresJoe1
我希望作者澄清这一点，因为我不确定Svar的工作方式。但是到目前为止，C ++代码尚无有效的绑定...
好的   谢谢你

@zdzhaoyong thank you very much for your help !

Alguien ya encontro alguna solucion para poder instalarlo a traves de python?


Cannot attach a contentful model as a polymorphic object for another belongs_to

Let's say I have this example model:
class Activity < ApplicationRecord
  belongs_to :object, polymorphic: true
end

And I want to attach a contentful model as object.
$ ex = Activity.new
$ ex.object = Article.first

In order to facilitate this and allow for saving, I had to add the following methods to my Article class:
class Article < ContentfulBase
  self.content_type_id = "article"

  def self.primary_key
    :id
  end

  def self.base_class
    Article
  end

  def falsifier
    false
  end

  alias :marked_for_destruction? falsifier
  alias :destroyed? falsifier
  alias :new_record? falsifier

  def _read_attribute(field_name)
    return id if field_name == self.class.primary_key
    method_missing(field_name)
  end
end

Unfortunately, this will save but it will not allow me to access Activity.object as it complains about the lack of arel_table
I am wondering if there is anything in the pipeline to facilitate this sort of polymorphic relational behavior - to make Contentful Model more like ActiveRecord with relations? Thanks for your time.

Hey @colepatrickturner,
This sounds like an awesome idea for a new feature.
Would you be interested in working with me on implementing it?
Cheers

Hey!
I'm interested in any way I can, but months have gone by and I do not recall the issue regarding the lack of arel_table
The best educated guess I can give is that when Rails is selecting the association *.object it uses the relational table to lookup the entity, wherein this will need to be overridden so that it can be patched into a ContentfulModel.

No problem.
Thanks for the help, if I have any issues when implementing it I'll try to reach out to you for input.
There is no ETA for this to be added, but it's already in our backlog to tackle within the next few months.
Cheers

Is there the ability to use polymorphic associations?

Hey @reidcooper,
The answer is complicated, as it is both yes and no. And which answer you get depends on the usage pattern you want to accomplish.
So, for the positive case, if you don't define the relationships for fields that have polymorphic relationships, the contentful.rb gem, will automatically resolve the classes for you and solve this issue without doing anything. That said, you loose some of the capabilities that are added by this gem when explicitly defining the relationship.
For the negative case, if you really, really need that extra functionality, it's not currently going to work for polymorphic relationships, as it does redefine the accessors for those relationships.
Hope this explains the issue a bit further.
Cheers


Add fmt methods

While using your library for one of my projects, I was saddened to see that you hadn't implemented any formatters for the Pixel struct. So I went ahead and did that for you.
It made debugging easier (for me) to be able to see the colours as #abcdef rather than Pixel { r: 171, g: 205, b: 239 } and I'm thinking I'm not alone in this thinking.
This simple pull request adds {}, {:x} and {:X} to the formatter.

@ElectricCoffee Awesome! Much appreciated


Capture feature requests from Thomas and John on testbed device

What is the feature being requested?
Capture in issues feature requests from Thomas and John on testbed device, when efficient to do. Prioritize
What are use cases for this feature?

Thomas and I agreed to close this.


Relicense to MIT OR BSD-2-Clause-Patent OR Apache-2.0

In order to upstream code into bevy, we should be a superset of their licenses. Adding Apache-2.0 increases compatibility with them, even though legally its redundant.
Please comment on this PR stating:

I approve this change, and agree that all code I have contributed into this repo (including in PRs that have not been merged yet) will be triple licensed, under the SPDX identifier MIT OR BSD-2-Clause-Patent OR Apache-2.0.

Necessary sign-offs:

[x] @TheButlah (implicit)
[ ] @MalekiRe
[x] @Schmarni-Dev
[ ] @CorneliusCornbread (PR)

I approve this change, and agree that all code I have contributed into this repo (including in PRs that have not been merged yet) will be triple licensed, under the SPDX identifier MIT OR BSD-2-Clause-Patent OR Apache-2.0.

I approve

I approve this change, and agree that all code I have contributed into this repo (including in PRs that have not been merged yet) will be triple licensed, under the SPDX identifier MIT OR BSD-2-Clause-Patent OR Apache-2.0.


Add meta-balena as upstream

Change-type: patch
Signed-off-by: Giovanni Garufi<EMAIL_ADDRESS>

Superseded by https://github.com/balena-os/balena-up-board/pull/67


Added Split-versioning Functionality to Backend

Proposed changes

Added frontend version file
Updated import-library util to handle split-versioning of api-bridge/frontend

Types of changes
What types of changes does your code introduce to the HEBench Cleartext Reference Backend?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Current formatting and unit tests / base functionality passes locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Why, during CMake run in the build, API_BRIDGE component is listed twice? See below:
-- ===== Configuring Third-Pary: API_BRIDGE =====
-- Required API_BRIDGE Version: v0.5.1-beta
-- Required FRONTEND Version: v0.5.1-beta
-- API_BRIDGE_INCLUDE_DIR: /usr/local/include
-- API_BRIDGE_LIB_DIR: /usr/local/lib
-- No user-defined paths (-DAPI_BRIDGE_[INSTALL|INCLUDE|LIB]_DIR) were set
-- API_BRIDGE could not be found at the default location
-- Downloading and Installing it...
-- CMAKE_BUILD_TYPE: Release
-- Project Version: v0.5.1-beta
-- HIDE_EXT_WARNINGS: OFF
-- CMAKE_INSTALL_PREFIX /home/runner/work/backend-cpu-cleartext/backend-cpu-cleartext/build
-- ===== Configuring Third-Pary: API_BRIDGE =====
-- Required Version: v0.5.1-beta
-- API_BRIDGE_INCLUDE_DIR: /usr/local/include
-- API_BRIDGE_LIB_DIR: /usr/local/lib
-- No user-defined paths (-DAPI_BRIDGE_[INSTALL|INCLUDE|LIB]_DIR) were set
-- API_BRIDGE could not be found at the default location
-- Downloading and Installing it...
-- CMAKE_BUILD_TYPE: Release
-- Project Version: v0.5.1-beta
-- CMAKE_INSTALL_PREFIX /home/runner/work/backend-cpu-cleartext/backend-cpu-cleartext/build

Is this because the first API_BRIDGE is actually the frontend, and the second is printed out by frontend CMake?

Is this because the first API_BRIDGE is actually the frontend, and the second is printed out by frontend CMake?

Correct, you're exactly right.


Footer enhancement

The names which are placed at the left and right side of the subscription card are not much visible. I would like to place left potion above to the logo inside the card and right portion at the bottom of the card. Instead of adding names of the social media platforms I would like to add logo's of every platform and write "Follow us on" like text. I can do it better. Please assign me to this task under hacktoberfest. Thank you!

@Aneeshaik Assigned

@Aneeshaik  Check if Using the Correct Account
Make sure that Aneeshaik is logged into the correct GitHub account in the terminal or command line. If they have multiple GitHub accounts, they might be using the wrong credentials.
To Check Current Git Config:
bash
Copy code
git config --global user.name
git config --global user.email
If these are incorrect, update them with:
bash
Copy code
git config --global user.name "Aneeshaik"
git config --global user.email<EMAIL_ADDRESS>3. Clear Cached Credentials
If the credentials are cached incorrectly, clearing them might help:
On macOS:
bash
Copy code
git credential-osxkeychain erase
On Windows: Open Credential Manager and remove any GitHub credentials.
On Linux: You might have to clear them manually from the ~/.git-credentials file.

Use SSH Instead of HTTPS
If you have SSH access set up, consider switching to SSH instead of HTTPS to push code.

Switch to SSH:
Ensure that you have an SSH key set up. You can check this with:
bash
Copy code
ls -al ~/.ssh
You should see a file like id_rsa and id_rsa.pub. If not, you can generate one using:
bash
Copy code
ssh-keygen -t rsa -b 4096 -C<EMAIL_ADDRESS>Add the SSH key to your GitHub account by copying the content of id_rsa.pub to your GitHub SSH settings.
Change the remote URL of your repository to use SSH:
bash
Copy code
git remote set-url origin git@github.com:Anu27n/603work.git
5. Retry the Push Command
After granting access or resolving any credential issues, try pushing your changes again:
bash
Copy code
git push origin anees
Conclusion
If Aneeshaik is still unable to push after following these steps, double-check that the user was correctly added to the repository and that there are no organizational policies or branch protection rules preventing them from pushing. Let me know if you need further assistance!

@Aneeshaik bro anyone can access it, i thing there is issue from ur side

hello @Anu27n , it's keeps showing like this
` git push origin anees
ERROR: Permission to Anu27n/603work.git denied to Aneeshaik.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.`


Add textColor for DayViewFacade that can change decorator's date text color

The way this is implemented breaks all default background selection and makes the default text color white. The text color should default to -1 and a check to see if textColor is non negative before applying to the view. I will close this and work on the issue in a separate PR.
In the future, please also direct all PRs to the future/1.x branch instead of master.


Move Result to top of core crate

This rather large PR is quite simple. It adds a pub use declaration to azure_core so that users can access the Result type alias from the root of azure_core like so: azure_core::Result. This is quite a common pattern in the Rust world.
The rest of the changes are simply moving all uses of azure_core's Result type to use this path so that we have consistency across the code base.

I was hoping to ask about doing the same.

This LGTM, the only thing I would have done differently is doing use azure_core::Result and then using Result, rather than repeatedly using azure_core::Result.

This LGTM, the only thing I would have done differently is doing use azure_core::Result and then using Result, rather than repeatedly using azure_core::Result.

I purposefully went this route since this tends to be more idiomatic. Generally speaking, unqualified Result is reserved for std::result::Result while qualified Result is used for others. This is why in the std lib docs, you often see std::io::Result used as io::Result instead of just as Result.


Show a msg when a player join for the first time

it requires a database right?

currently our database is just a state object in memory

For now we can just add a first_time in the state that is always true

k

it requires a database right?

supported in #262


Possibility of ignoring videos without subtitle files

Hey there youtube-dl devs!  I am doing some mass information farming to hopefully generate an accurate acoustic model using audio and subtitle information gathered from youtube (or otherwise).  I've found your application to do almost exactly as I need it to and am thoroughly pleased with the results!  Now, my questions to you are as follows:  Is there any to tell youtube-dl to ignore videos that do not have an accompanying subtitle file?  If not, is there any way that youtube-dl will have this functionality in the near future?  I've looked through the man-pages and couldn't find anything so I figure I'd ask you guys!  So, yeah, no bugs, issues or otherwise, just a question.  I appreciate any and all responses!
Cheers,
Jay.

That is not possible via cli, but possible programmatically.

Thanks for the quick response! I was thinking about coding it into our python application but figured I'd ask if there was any way through the client first.  I appreciate it!


Finetuning general LLM models from hugging face

Thank you for your continuous support to the LLM open-source community.
I was wondering if we use AutoModel, AutoConfig and AutoTokenizer instead of LlamaForCausalLM, LlamaConfig and LlamaTokenizer for general LLM fine-tuning, will the fine-tuning pipeline/recipe fail?

Hi @bkhanal-11 for the single gpu use case this might work, but for the advances use cases with FSDP you'll need to different wrapping policy and there might be other things to consider and adapt.

That makes sense, thanks.


fix: The package touches files and directories in $HOME without asking

Description
When my CLI program (that is using package:cli_completion) is run for the first time, it:

appends some initialization logic to ~/.zshrc (in my case - I'm using Zsh)
$ tail -n 5 ~/.zshrc
## [Completion]
## Completion scripts setup. Remove the following line to uninstall
[[ -f /Users/bartek/.config/.dart-cli-completion/zsh-config.zsh ]] && . /Users/bartek/.config/.dart-cli-completion/zsh-config.zsh || true
## [/Completion]

creates the ~/.dart-cli-completion directory, which apparently stores the completion files for every program using it:
$ ls ~/.dart-cli-completion/
patrol.zsh     zsh-config.zs

Steps To Reproduce
Add this package to a CLI program (as per the README) and run it.
Expected Behavior
I don't want my CLI program to touch my user's $HOME. It's not nice.
I also feel like this behavior should be clearly stated in the readme.
Additional Context
Initially reported in this issue.

Hell there,
As the docs say, to disable auto install, set 'enableAutoInstall' to false on your CompletionCommandRunner subclass.
The workings of the package are stated in the docs:
https://github.com/VeryGoodOpenSource/cli_completion/tree/main/doc

Thanks for the quick answer.
I have no experience with shell completions, but could an alternative approach be developed? Some software automatically installs its own completions when brew installed.
Though I suspect that it'd be more complicated to set up than it currently is.

There are other ways, for example, fig. But that requires the completion schema to be published within its registry, with is not too ergonomic.
Another alternative is to add completions in runtime via oh my zsh plugin system.
Any of these alternatives rule out the possibility of mapping the suggestions from the ArgParser objects, which is the whole point of this package.
For this issue, we can:

Disable auto-install by default, or
Remove auto-install altogether and force final users to install scripts "manually"

Disable auto-install by default

I wouldn't do it. I might not like scripts modifying my ~/.zshrc but I'm sure a whole lot more people don't bother with it, but they do want to have completions.

Remove auto-install altogether and force final users to install scripts "manually"

Could there be 2 ways of installing the completions? The current one - automatic, and the new one - manual - that'd require the user to move the generated completions file into .

I am going to close this issue since my question has been answered here. Thank you!


use gitignore.io for gitignore

-> https://www.toptal.com/developers/gitignore/

Templates: node & go
Moved custom rules to the bottom
Ignored node_modules/

Was there anything missing in the current ignore?

Was there anything missing in the current ignore?

For me, I had a lot of node_modules/ stuff in there from some frontend testing at some point.
Overall, the use of gitignore.io simplifies rule creation - and also allows for additional custom rules. Opinionated but widely used.

Those templates add quite some unrelated stuff (we are not using half of the stuff like npm, yarn, jest, next etc) while still missing other web related parts. Wont block however.

Those templates add quite some unrelated stuff (we are not using half of the stuff like npm, yarn, jest, next etc)

That's how such templates work. Still way easier to use them then to initialize custom gitignore's for every project IMO.

while still missing other web related parts.

Well, same as above. Templates won't cover everything but theres the "custom" section to extend them.
Won't merge then if not everybody likes it.


Adding Sitemap to the Meta info

It will help improve the SEO score of websites.
P.S. - It is also a good idea to add it to the robots.txt, but we can't use relative paths there.

This PR is copied from the onwidget source repo to match

.deploy


Results - plots: move area_per_pixel to KPI-DDL

AKA:
Move area_per_pixel to the second  (reinspected_type2-) DDL. If it gets selected, the immediate callback to that event should remove all choices from reinspected_spectrums2. If it is deselected, all choices must be reinserted again.

I don't think it is sensible to clear out the first DDL every time area_per_pixel is selected in the reinspected_type2-DDL


Allow some NPCs to be excluded from this (for players at least)

It would be useful if you could exclude some NPCs / enemies from the display of the health estimate, at least for players. I like the module for use in minion battles etc, but I don't necessarily want my players to know how beaten up the BBEG is. In addition, for some creatures, e.g. Oozes, it won't be apparent what their health levels are.
At the moment if you set the MaxHP to 0, this module won't display for that token. However, this is not useful for actual monsters as having a 0 maxHP value messes up other things.
Having another method that you can set on an actor (or token) basis to exclude them from this module (even if only for PCs) would be really useful

I'll setup a macro similar to the Mark Dead macro that'll make the characters flagged by the macro won't show up to players.


Feature: Add paybutton name, uuid and buttonData fields — Create scheme & migrations

Description:
Part of #33: Creates the migration & updates the prisma scheme, adding the new fields.

The uuid field is VARCHAR and not UUID because prisma does not support UUID for MySQL yet.
The buttonData field is set to NOT NULL so that null values are saved as `'{}', and thus even empty values can be parsed as JSON.

Test plan:
This, on its own, breaks all previous code related to the PayButton API & DB services, as well as their tests. The changes to that code will be added in subsequent PRs that point to this one as their dependency.
However, it's possible to test the migrations and the scheme by running:
yarn docker migratereset
yarn docker prismagenerate

This branch requires #113 before its tests will pass, correct?


v1.0.0 Undefined function _MIR_name_char_p when #MIR_NO_SCAN is used

It seems the function _MIR_name_char_p needs to be defined outside the #if !MIR_NO_SCAN.

Thank you for filling the issue.  I fixed it by e1f198b5ebb9679a8066d9bfd3241f419394208d.

thank you


Bot API 5.0

Bot API 5.0 (November 4, 2020)
Webhooks

Added the parameter ip_address to the method setWebhook, allowing to bypass DNS resolving and use the specified fixed IP address to send webhook requests.
Added the field ip_address to the class WebhookInfo, containing the current IP address used for webhook connections creation.
Added the ability to drop all pending updates when changing webhook URL using the parameter drop_pending_updates in the methods setWebhook and deleteWebhook.

Working with Groups

The getChat request now returns the user's bio for private chats if available.
The getChat request now returns the identifier of the linked chat for supergroups and channels, i.e. the discussion group identifier for a channel and vice versa.
The getChat request now returns the location to which the supergroup is connected (see Local Groups). Added the class ChatLocation to represent the location.
Added the parameter only_if_banned to the method unbanChatMember to allow safe unban.

Working with Files

Added the field file_name to the classes Audio and Video, containing the name of the original file.
Added the ability to disable server-side file content type detection using the parameter disable_content_type_detection in the method sendDocument and the class inputMediaDocument.

Multiple Pinned Messages

Added the ability to pin messages in private chats.
Added the parameter message_id to the method unpinChatMessage to allow unpinning of the specific pinned message.
Added the method unpinAllChatMessages, which can be used to unpin all pinned messages in a chat.

File Albums

Added support for sending and receiving audio and document albums in the method sendMediaGroup.

Live Locations

Added the field live_period to the class Location, representing a maximum period for which the live location can be updated.
Added support for live location heading: added the field heading to the classes Location, InlineQueryResultLocation, InputLocationMessageContent and the parameter heading to the methods sendLocation and editMessageLiveLocation.
Added support for proximity alerts in live locations: added the field proximity_alert_distance to the classes Location, InlineQueryResultLocation, InputLocationMessageContent and the parameter proximity_alert_distance to the methods sendLocation and editMessageLiveLocation.
Added the type ProximityAlertTriggered and the field proximity_alert_triggered to the class Message.
Added possibility to specify the horizontal accuracy of a location. Added the field horizontal_accuracy to the classes Location, InlineQueryResultLocation, InputLocationMessageContent and the parameter horizontal_accuracy to the methods sendLocation and editMessageLiveLocation.

Anonymous Admins

Added the field sender_chat to the class Message, containing the sender of a message which is a chat (group or channel). For backward compatibility in non-channel chats, the field from in such messages will contain the user 777000 for messages automatically forwarded to the discussion group and the user<PHONE_NUMBER> (@GroupAnonymousBot) for messages from anonymous group administrators.
Added the field is_anonymous to the class chatMember, which can be used to distinguish anonymous chat administrators.
Added the parameter is_anonymous to the method promoteChatMember, which allows to promote anonymous chat administrators. The bot itself should have the is_anonymous right to do this. Despite the fact that bots can have the is_anonymous right, they will never appear as anonymous in the chat. Bots can use the right only for passing to other administrators.
Added the custom title of an anonymous message sender to the class Message as author_signature.

And More

Added the method copyMessage, which sends a copy of any message.
Maximum poll question length increased to 300.
Added the ability to manually specify text entities instead of specifying the parse_mode in the classes InputMediaPhoto, InputMediaVideo, InputMediaAnimation, InputMediaAudio, InputMediaDocument, InlineQueryResultPhoto, InlineQueryResultGif, InlineQueryResultMpeg4Gif, InlineQueryResultVideo, InlineQueryResultAudio, InlineQueryResultVoice, InlineQueryResultDocument, InlineQueryResultCachedPhoto, InlineQueryResultCachedGif, InlineQueryResultCachedMpeg4Gif, InlineQueryResultCachedVideo, InlineQueryResultCachedAudio, InlineQueryResultCachedVoice, InlineQueryResultCachedDocument, InputTextMessageContent and the methods sendMessage, sendPhoto, sendVideo, sendAnimation, sendAudio, sendDocument, sendVoice, sendPoll, editMessageText, editMessageCaption.
Added the fields google_place_id and google_place_type to the classes Venue, InlineQueryResultVenue, InputVenueMessageContent and the optional parameters google_place_id and google_place_type to the method sendVenue to support Google Places as a venue API provider.
Added the field allow_sending_without_reply to the methods sendMessage, sendPhoto, sendVideo, sendAnimation, sendAudio, sendDocument, sendSticker, sendVideoNote, sendVoice, sendLocation, sendVenue, sendContact, sendPoll, sendDice, sendInvoice, sendGame, sendMediaGroup to allow sending messages not a as reply if the replied-to message has already been deleted.

And Last but bot Least

Supported the new football and slot machine animations for the random dice. Choose between different animations (dice, darts, basketball, football, slot machine) by specifying the emoji parameter in the method sendDice.

Fully implemented in #938. Lucks some testing thou...
PS: while adding 100500 new request-field I`ve understood why in v16? all methods are extension-methods 😂


Removed unrelated word on line 94

Removed "that" as it didn't have any related context.

Learn Build status updates of commit 8cdc925:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

power-platform/guidance/coe/setup-core-components.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

We have already fixed that locally in our branch for the November release - instead of removing the word, we finished the sentence. Closing out as this will go live with our next docs update from our branch.


Refactor existing API views to use Django Rest Framework

Question: this sounds like just an internal implementation detail. What's the expected benefit to the client?

I was linked to this issue too — is there some way I could help flesh out use cases? (although, for the very little it's worth, my gut feeling is that there wouldn't be much value in moving to DRF).

My gut is with yours. Although the current API implementation is entirely ad-hoc with views scattered here and there, it works well enough (or nobody has made specific complaints, anyway).

Yep. And, as far as I know, there are only a handful of people who consume the APIs, and they do it with ad-hoc scripts each year (off the top of my head: PyVideo to grab metadata about talks, myself to create session staff material, probably Luke to do program stuff, and probably Noah because IIRC he knew a bit about what was up, and possibly Felix(?) to do the mobile schedule)… so, as much as I hate to say it, there really won't be a lot of person-hours saved by improving the APIs, at least as they are used right now.

I think the other big user is, or has been, the proposal review team. They've used the APIs to group proposals into Thunderdome Groups and preserve IRC discussions and votes.

Then maybe we should just drop this?  And use #392 to improve the documentation of the existing API endpoints?

Yep, that's probably going to be the best bang-for-the-buck.
Also, I haven't forgotten about the updates I owe you on the other issues. I'll be getting them some time this week.

Hi @wolever  - have you had a chance to provide the supplemental information?

Closing this per @ejodlowska and @wolever.


Upgrade to globus-sdk v3

Add note on upgrade to changelog.
Update GroupsClient to work with v3.

Update groups client usage
Add basic test for creating groups client (similar to flows)

Remove arrow as a dependency

There was only one usage site for this, which is also easily accomplished using the standard library, so it seems good to trim the dependency here

@kurtmckee really good catch, thanks. That prompted me to root around the tests a bit; it was possible to (IMO) simplify the test setup quite a bit, and in my case xdist was actually slowing the test run (it took 3s vs 1.5 without) so I'm removing that too.


Spike: Express API requirements for Besu

Description
As a developer I want to create the express API app for running the supplychain smartcontract end points.
Test the existing express code with BAF deployed Besu network
Acceptance Criteria

Document the changes required if any and create further issues.

After some doing some research, I found out that the express API that we already have for Quorum will not work for Besu because of the not supported eth_sendTransaction method (will have to use eth_sendRawTransaction which is the one that is supported for this type of network). Internally, It looks that web3 module uses eth_sendTransaction, so the most optimal solution would be to develop a new express API using most of the code we already have for the quorum one but instead of instantiating the contract with web3 module, use others which uses eth_sendRawTransaction.
Possible alternatives:

Ethsigner
Web3-eea

This task will be continued on #1562


[go_router] 14.1.0 , routerDelegate.currentConfiguration.matches  info not update when pop()

I use the popUtil extension Stuck on go_router 14.1.0, but it fine on go_router 13 and before.
By log , I found routerDelegate.currentConfiguration.matches.last.matchedLocation has no immediate change after pop()。
extension GoRouterExt on GoRouter {
  void popUntil(String routePath) {
    while (routerDelegate.currentConfiguration.matches.last.matchedLocation != routePath) {
      if (!canPop()) {
        return;
      }
      pop();
    }
  }
}

@lunxinfeng
Can you provide a runnable reproducible code sample that shows the stuck behavior as compared to the one wherein it worked before ?

@lunxinfeng Can you provide a runnable reproducible code sample that shows the stuck behavior as compared to the one wherein it worked before ?

https://github.com/lunxinfeng/flutter_test_
this is a demo, I found that:

it is fine when only go_router 14.1.0
it is fine on go_router 13.2.5 and go_router_builder 2.6.2
it is error on go_router 14.1.0 and go_router_builder 2.6.2

Thanks!

Thanks for the update. Using the repro provided, I observed that it goes to next page but while tapping on return, it doesn't perform any action. Keeping the issue open and labeling for team's input / attention.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.22.0, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.22.0 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5dcb86f68f (5 days ago), 2024-05-09 07:39:20 -0500
    • Engine revision f6344b75dc
    • Dart version 3.4.0
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-30.0.pre.11, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.22.0-30.0.pre.11 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c90e18c6f5 (2 hours ago), 2024-05-09 20:32:11 -0700
    • Engine revision c0917b14fc
    • Dart version 3.5.0 (build 3.5.0-138.0.dev)
    • DevTools version 2.36.0-dev.5
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

canPop is not update either.
I can break this while loop.
13.2.5 worked.

https://github.com/cuong0993/go_router_test/blob/main/lib/on_exit_example.dart#L91

This is a serious issue that just caused a hard-to-catch bug in our app.
It can lead to infinity pop() which will just crash your app to a black screen.
In our case we're doing the following for some bottom sheets to pop all following routes until the route is the current bottom sheet:
Navigator.of(context).popUntil((_) {
    return ModalRoute.of(context)!.isCurrent;
});

but then ModalRoute.of(context)!.isCurrent will always return false until the app crashes to the black screen.
We're stuck on version 13.2.2 because of this now.
@chunhtai Can you increase the priority of this issue?

In our case the reason why popUntil causes an infinite loop is that we are using go_router_builder to generate routes, and the generated code calls this static method in route_data.dart to create GoRoute objects with an non-null onExit callback.
  /// A helper function used by generated code.
  ///
  /// Should not be used directly.
  static GoRoute $route<T extends GoRouteData>({
    required String path,
    String? name,
    required T Function(GoRouterState) factory,
    GlobalKey<NavigatorState>? parentNavigatorKey,
    List<RouteBase> routes = const <RouteBase>[],
  }) {
     ...

    FutureOr<bool> onExit(BuildContext context, GoRouterState state) =>
        factoryImpl(state).onExit(context, state);

    return GoRoute(
      path: path,
      name: name,
      builder: builder,
      pageBuilder: pageBuilder,
      redirect: redirect,
      routes: routes,
      parentNavigatorKey: parentNavigatorKey,
      onExit: onExit, // THIS LINE WAS RECENTLY ADDED.
    );
  }

This prevents _completeRouteMatch(result, match) from being called immediately. The next call to pop() occurs before the scheduled microtask runs, causing an infinite loop.
  bool _handlePopPageWithRouteMatch(
      Route<Object?> route, Object? result, RouteMatchBase match) {
    ...
    final RouteBase routeBase = match.route;
    if (routeBase is! GoRoute || routeBase.onExit == null) { // THIS IS NEVER NULL
      route.didPop(result);
      _completeRouteMatch(result, match); // THIS WILL NEVER BE CALLED
      return true;
    }
    // The _handlePopPageWithRouteMatch is called during draw frame, schedule
    // a microtask in case the onExit callback want to launch dialog or other
    // navigator operations.
    scheduleMicrotask(() async {
      ...
    });
  }

@chunhtai @darshankawar Did my comment help?

This may require some more work to fix. I currently don't have bandwidth to work on this issue. Also, please use thumb up to bump the priority

Same issue, i down grade to

go_router: ^13.2.5

fix it

It's the end of the year, can it be fixed?


updating the data model

The current data model consists of two FITS extensions: METADATA and FASTSPEC, which can be reviewed here:
https://fastspecfit.readthedocs.io/en/latest/fastspec.html.
The number of columns in the FASTSPEC HDU is approaching ~1000 columns, however, which has become too unwieldy, and also doesn't allow for expansion of the data model.
Consequently, I propose expansion to three extensions, METADATA, FASTSPEC, and SPECPHOT, as summarized in the following document:
https://docs.google.com/spreadsheets/d/1DnCPhu-62b8JgC7ZjY422sh9I006lJ4a1gt8Inwij_M/edit?gid=0#gid=0
Feedback is more than welcome.

Note that a nice snippet of code to convert from TSNR2 to EFFTIME was provided by @araichoor on-list
def get_snr2time(tracer):
    ensemble_dir = os.path.join(os.getenv("DESIMODEL"), "data", "tsnr")
    fn = os.path.join(ensemble_dir, "tsnr-ensemble-{}.fits".format(tracer.lower()))
    return fits.getheader(fn, 0)["SNR2TIME"]

for tracer in ["BGS", "LRG", "ELG", "QSO", "LYA"]:
    print("{}\t{}".format(tracer, get_snr2time(tracer)))

=>

BGS    0.1400000003119347
LRG    12.15060572324326
ELG    8.60000036161418
QSO    33.6094737399845
LYA    11.80090901380597

Done in #197.


using discard_unpacked_layers with CRI to reduce the size on disk of the cached images

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reducing the Packed Image layers (content) under /var/lib/containerd folder, this data is not used normally for creating container, it's used for republishing.  CRICTL allows for this storage to be dleeted post unpacking, using the CRI flag
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

There are merge conflicts because of the other CSE changes - we need to rebase again


Error when running distributed processes

When running distributed functions on certain computers a EXCEPTION_ACCESS_VIOLATION or ReadOnlyMemoryError error occurs on one or more worker processes. This seems to occur when running the line
Distributed.@everywhere using OPFLearn

with multiple workers that have not already had OPFLearn initialized.
Example Error:
julia> include("dist_test.jl")
      From worker 8:
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 8:    unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 8:    unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 8:
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 8:
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 8:
      From worker 8:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 8:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 8:    in expression starting at none:1
      From worker 7:
      From worker 7:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 7:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 7:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 7:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 7:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 7:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 7:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 7:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 7:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 7:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 7:    in expression starting0000none:1
      From worker 7:    �0000)
      From worker 7:    �n expression starting at none:1
      From worker 7:    unknown function (ip:<PHONE_NUMBER>0unknown function (ip:<PHONE_NUMBER>000000)
      From worker 7:    in expression starting at none:1
      From worker 7:    �0000)
      From worker 7:    in expression starting at none:1
      From worker 7:    in expression starting at none:1
      From worker 6:
      From worker 6:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 6:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 6:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 6:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 6:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 6:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 --
      From worker 6:    Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
      From worker 6:    Exception: EXCEPTION_ACCESS_VIOLATION at 0x0 -- unknown function (ip:<PHONE_NUMBER>000000)
      From worker 6:    in expression starting at none:1
      From worker 6:    unknown function (ip:<PHONE_NUMBER>000000)
      From worker 6:    in expression starting at none:1
      From worker 6:    �0000)
      From worker 6:    in expression starting at none:1
      From worker 6:    in expression starting at none:1
Worker 8 terminated.
Worker 7 terminated.
Worker 6 terminated.
ERROR: LoadError: Distributed.ProcessExitedException(6)

...and 2 more exceptions.

Stacktrace:
 [1] sync_end(c::Channel{Any})
   @ Base .\task.jl:369
 [2] macro expansion
   @ .\task.jl:388 [inlined]
 [3] remotecall_eval(m::Module, procs::Vector{Int64}, ex::Expr)
   @ Distributed C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\Distributed\src\macros.jl:223
 [4] top-level scope
   @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\Distributed\src\macros.jl:207
 [5] include(fname::String)
   @ Base.MainInclude .\client.jl:444
 [6] top-level scope
   @ REPL[2]:1
in expression starting at C:\Users\joswi\Documents\SULI_Sum21\test_env\dist_test.jl:11

This seems to be due to IPOPT or other packages used not being thread-safe. Currently, the test suite uses Sys.CPU_THREADS - 1 to set the number of worker processes to create and uses during distributed processing.
Testing with PC with a AMD FX(tm)-8350 Eight-Core Processor, 4000 Mhz, 4 Core(s), 8 Logical Processor(s), I can reliably run distributed sample creation functions with nproc specified as 5 (This results in 4 workers being used). Increasing this number by one resulted in a ReadOnlyMemoryError().
On a laptop with an Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, 2112 Mhz, 4 Core(s), 8 Logical Processor(s), nproc=8 consistently works though even though the processor has the same number of cores.

Possibly relevant when trying to automatically setting up distributed processes: https://github.com/lanl-ansi/PowerModelsSecurityConstrained.jl/blob/master/src/scripts/distributed.jl


WordPress Backup

EasyEngine is already capable for WordPress backup, it automatically performs it when you try any "ee site update" command. It performs a db dump and file backup(now only wp-config and domain's nginx cong file) and put it in /var/www/domain.tld/backup/DayMonthYearTimeStamp
Its very possible to add a full file backup and put a compressed version there too. We could have command like this
ee site backup domain.tld
We could extend the functionality in future with options like
ee site backup domain.tld --files=false
while file, db and config alls are stored by default.
In future there could be cron based automotion like
ee site backup domain.tld --daily
or
ee site backup domain.tld --frequency=monthly
Like that. Seems like very possible to do and will be very helpful.
Regards

@Asif2BD agreed. And, can be extended to support S3cmd and other cloud storage.

S3cmd seems super cool and easy to implement. +1 for it.

This should be a priority for EE. Since wp-config file is moved outside the normal dir (a good thing normally), many of the usual plugins for WP backups don't work.
Seems like all that's left is tar/gz the fs and dump the DB for that site? The external s3 stuff can wait until after the core feature is done

What’s wrong with mysqldump, tar, gzip stuff?

Nothing -- it should just be wrapped into a convenience method ee site backup domain.tld ;)

@timelf123
Which backup plugins have you come across that has issue with the location of wp-config.php?

To be fair it happened on the first plugin I tried and I gave up and opted for a cli solution.
I'm fairly sure it was this one https://wordpress.org/plugins/wordpress-backup-to-dropbox/

IMHO We have to keep 2 sets of backup.

Local Backup - rsnapshot
Remote Backup - Duplicity (S3 upload)

Reason to use two different software is due to some unknown bug one backup was failed then we always have backup which was taken by different software.
Also local backup was useful in fast recovery.

Closing this thread as #1045 has better documentation. We will definitely like to have this for our-self.


How to minimize binary library size?

Thanks for all the work ! Trying to evaluate if I may be able to use it at work. Mostly interested in C/CPP. Since the native is CPP, that bloats up my application size, trying to keep it to a minimum.
Is there a report/ experimentation with the application sizes for C/CPP builds?
Thanks !
Originally posted by @pranavtriguna in https://github.com/zxing-cpp/zxing-cpp/discussions/706#discussioncomment-8375408
I opened this new issue to not spam the "sign up" discussion. You are interested in a minimal binary size of the library?

Essentially, I would like to use this library to detect/decode barcode types, but refrain from using the whole library, as I may not need all the functionality. Hence the compile size is a factor, as well as integration into existing project. I read somewhere that a minimum C++ version support is needed and I'm checking on that for now.
Not looking for a specific binary size but an estimation, if this ends up compiling in 10s or 100s of MB, so I could think to trim it down to my use. Potentially may end up cherry-pick files to compile etc., but for now going through Silky's C wrapper.
Irrespective of if I end up using this library or not, want to say thanks again for all the effort!

To address the topic more directly, I will look for options to partially include or exclude functionality to compile to a lower size, and potentially use C-wrapper.
Would keep porting the logic to C as a last resort, in case I can't get it to compile with C++ (my compiler may be outdated and I won't be able to udpate that since it's a part of a suite)

A couple things:

a stripped release build of the complete library is currently 1,3M
the c-API is now part of core library if you build it with cmake ... -DBUILD_C_API=ON
using the c-API is not making the library any smaller and you still need a c++17 compiler for your platform to use it
porting the code to C is ... time consuming ;)
you can lower the size to about half if you only need to read or write (but not both), see BUILD_READERS
there is the CMAKE_BUILD_TYPE which can be set to MinSizeRel, no idea how much that changes compared to Release
a considerable part of the binary-size is potentially the libzueci related UTF8 code which contains lots of character lookup tables. Depending on which barcode formats you want to deal with, you might not need that. But removing that will require some manual patching.

A couple things:

a stripped release build of the complete library is currently 1,3M

Yeah definitely will not have that much space available :(

the c-API is now part of core library if you build it with cmake ... -DBUILD_C_API=ON

using the c-API is not making the library any smaller and you still need a c++17 compiler for your platform to use it

This is what I'm trying to check. I may be able to compile the individual files, but I would need to check if the linker(s) can potentially link object files from both c/cpp in the same project. c++17 should be supported, but I'm playing with the __cplusplus to check that.

porting the code to C is ... time consuming ;)

Agreed, and we'll leave it at that. May take months, that's after completely understanding what the algo is trying to do. I'd much sooner learn the algo and write my own version than port hehe :) Either way, if I end up making some new code, I'll share!

you can lower the size to about half if you only need to read or write (but not both), see BUILD_READERS

This makes sense!

there is the CMAKE_BUILD_TYPE which can be set to MinSizeRel, no idea how much that changes compared to Release

Thanks! But I'm not going to build this library through the regular make, I will end up inserting relevant files into my buildsystem.

a considerable part of the binary-size is potentially the libzueci related UTF8 code which contains lots of character lookup tables. Depending on which barcode formats you want to deal with, you might not need that. But removing that will require some manual patching.

This helps! I'll look into it!

I was curious and experimented a little with the build options on clang and gcc:

Release
MinRelSize

g++-13
1.8M
1.1M

clang++-16
1.3M
1.1M

Yeah definitely will not have that much space available :(

How much do you have available?

I have around 2Mb for the final binary. Looks like I'll have to hack it away :D


Add readonly variant to RadioButton

Added readonly variant, that can be toggled by setting the readOnly prop.

Replaced by #1969


mag cal soft iron distortions

Consider updating mag cal for both hard and soft iron distortions.
https://github.com/PX4/Firmware/compare/pr-compasscal-offdiag?expand=1

Soft iron effects can be a major issue for some setups or if accurate yaw estimation under static conditions is required for camera pointing.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

Relevant https://github.com/PX4/Firmware/pull/9136


Investigate InfractionService being instantiated twice despite being a singleton

Describe the bug
InfractionService is instantiated twice (it logs twice to the console)
To Reproduce

Clone rewrite/core branch
Start bot
Observe logs

Expected behavior
InfractionService is instantiated once, as it's a singleton.
Screenshots

As it would turn out, building the generic host rebuilds the service collection, which, in turn causes services to be reinstantiated in the new provider. Yikes.
I've since rectified this issue.


WIP: Parallel Requests Proof of Concept

Proof of Concept for Parallel OpenAI Request processing

@niladam in general, I wish we this were using Symfony's HTTP Client, which has concurrency/lazy responses out of the box.
I had do something similar for another project and switching to that client made it really simple. By making a "ResponseHandler" object that holds the response and method to convert it to a Value Object, the developer can collect the responses and loop over them or just return the Value Object and only at that point would it complete the response.


some patterns seem to overlap with other patterns.

For example, given the diff result of two java file  /b_OrganizeImportsOperation.java   and f_OrganizeImportsOperation.java.
32d31
< import org.eclipse.core.resources.ResourcesPlugin;
557c556
< 		return ResourcesPlugin.getWorkspace().getRoot();
---
> 		return fCompilationUnit.getResource();

What the pattern of this bug?  That is,  mcRepl(Method call replacement) and retExpChange (Return expression modification) ,  which one is better?
Thanks!

Hi @zqudm,
There is no better, since both repair actions apply in this case.
In fact, you will see similar situations in many bugs.
Best regards!


Crash  explore list  view

crash message
Caused by: java.lang.RuntimeException: bad array lengths at android.os.Parcel.readStringArray(Parcel.java
...
explore.TagFilterHolder$1.createFromParcel

when come back to app
some time crash  at explore list

The solution to this bug was fixing the Parcelable implementation in TagFilterHolder. It was incorrectly trying to read array information twice. We've fixed this in 2016 source.
        String[] filters = in.createStringArray();
        in.readStringArray(filters);

...
int[] categories = in.createIntArray();
in.readIntArray(categories);


Struggling to replicate PDBBind results

Hello, I'm trying to replicate the results presented in the latest paper with Diffdock-L on the PDBBind dataset. I followed the instructions in repository README and ran the following command (after preparing the dataset and calculating the esm embeddings):
python -m evaluate  --config default_inference_args.yaml --split_path data/splits/timesplit_test --split_path data/splits/timesplit_test --batch_size 10 --esm_embeddings_path data/esm2_embeddings.pt --data_dir data/PDBBind_processed/ --tqdm --split test --chain_cutoff 10 --dataset pdbbind
At the end of the run I get the following results:

top 1 RMSD < 2A is 32.3%, median is 4.05
top 5 RMSD < 2A is 45.5%, median is 2.21

Anyone else tried to replicate the results and succeeded? any tips on what I may be doing wrong?

Are you looking at the filtered RMSD < 2 or RMSD < 2 performance?

I looked at the "top5_rmsds_below_2" for the top5 score. For the top1 score I took the rmsd with the top 1 confidence out of the 10 that are generated (the files rmsds.npy and confidences.npy which are both of the shape (360,10) are generated at the end of the run - this also corresponds with the "top5_rmsds_below_2" printed when I take the top5 from these numpy files).
At the end of the run the following metrics are printed:
0 failures due to exceptions
0  skipped because complex was not in confidence dataset
run_times_std 8.09
run_times_mean 16.42
mean_rmsd nan
rmsds_below_2 35.30555555555556
rmsds_below_5 59.777777777777786
rmsds_percentile_25 nan
rmsds_percentile_50 nan
rmsds_percentile_75 nan
min_rmsds_below_2 51.111111111111114
min_rmsds_below_5 80.27777777777777
mean_centroid nan
centroid_below_2 60.69
centroid_below_5 78.94
centroid_percentile_25 nan
centroid_percentile_50 nan
centroid_percentile_75 nan
top5_self_intersect_fraction 0.0
top5_rmsds_below_2 45.56
top5_rmsds_below_5 76.39
top5_rmsds_percentile_25 1.05
top5_rmsds_percentile_50 2.2
top5_rmsds_percentile_75 4.68
top5_centroid_below_2 74.44
top5_centroid_below_5 88.89
top5_centroid_percentile_25 0.33
top5_centroid_percentile_50 0.78
top5_centroid_percentile_75 2.03
top10_self_intersect_fraction 0.0
top10_rmsds_below_2 51.11
top10_rmsds_below_5 80.28
top10_rmsds_percentile_25 nan
top10_rmsds_percentile_50 nan
top10_rmsds_percentile_75 nan
top10_centroid_below_2 77.5
top10_centroid_below_5 91.39
top10_centroid_percentile_25 0.29
top10_centroid_percentile_50 0.68
top10_centroid_percentile_75 1.8
filtered_self_intersect_fraction 0.83
filtered_rmsds_below_2 42.78
filtered_rmsds_below_5 66.11
filtered_rmsds_percentile_25 1.16
filtered_rmsds_percentile_50 2.63
filtered_rmsds_percentile_75 6.5
filtered_centroid_below_2 67.22
filtered_centroid_below_5 82.5
filtered_centroid_percentile_25 0.37
filtered_centroid_percentile_50 0.88
filtered_centroid_percentile_75 2.93
top5_filtered_rmsds_below_2 49.17
top5_filtered_rmsds_below_5 76.94
top5_filtered_rmsds_percentile_25 0.99
top5_filtered_rmsds_percentile_50 2.03
top5_filtered_rmsds_percentile_75 4.64
top5_filtered_centroid_below_2 75.0
top5_filtered_centroid_below_5 89.44
top5_filtered_centroid_percentile_25 0.3
top5_filtered_centroid_percentile_50 0.69
top5_filtered_centroid_percentile_75 1.98
top10_filtered_rmsds_below_2 51.11
top10_filtered_rmsds_below_5 80.28
top10_filtered_rmsds_percentile_25 nan
top10_filtered_rmsds_percentile_50 nan
top10_filtered_rmsds_percentile_75 nan
top10_filtered_centroid_below_2 77.5
top10_filtered_centroid_below_5 91.39
top10_filtered_centroid_percentile_25 0.29
top10_filtered_centroid_percentile_50 0.68
top10_filtered_centroid_percentile_75 1.8

Thanks for the help and quick reply.

All the numbers that do not contain "filtered_" are all performances without any confidence model, the numbers that contain. "filtered_" are based on running the diffusion model to get 10 samples and then taking the best (and the best 5) according to the confidence score. These are the results that we report on the paper (if one uses no confidence model there is no reason to take multiple samples). Apologies for the confusion with the metrics names.

Thank you! One last question: Could you explain the purpose of the rmsds.npy and confidences.npy files generated at the end of the run?

yes they contain the rmsds of the structures in the order that they were generated and the corresponding confidences. If you'd like to replicate the filtered results you should order the rmsd array of the poses using the confidence array


issue about compile the source code

when I download the code ,and run "cmake ../.", there is configure error as below:

cmake ../.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/aws/aws-iot-device-sdk-cpp/build/third_party/rapidjson/download
[100%] Built target rapidjson
CMake Error at /usr/share/cmake-3.2/Modules/FindPackageHandleStandardArgs.cmake:138 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
/usr/share/cmake-3.2/Modules/FindPackageHandleStandardArgs.cmake:374 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.2/Modules/FindThreads.cmake:204 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:69 (find_package)

-- Configuring incomplete, errors occurred!

Hi @zhy989,
Thank you for using AWS IoT!
The above issue occurs when CMake cannot find the threading library used by the platform.
On investigating, it seems like CMake has a problem finding threads on some platforms as stated in this StackOverflow post. Could you try changing this line to project(aws-iot-sdk-cpp C CXX) and checking if that fixes it?
Could you also provide more information about your platform as that would help us in tracking the occurrence of this issue.
Please let us know if you have any more questions.
Thanks!
Varun

Hi @zhy989,
We have not heard from you for a while. We are closing the issue for now. Please feel free to open up a new thread if you still have questions.
Thanks,
Liusu


illustration size fixed for login

fix:issue number 225
I have changed the illustration size of women image which is present at login page.
I had checked the registration page ,at that page the image was looking fine,So, I modified the code of login page.

Looks fine @shashankmotruri before merging make sure to add proper tags to the PR


getDuration() takes a deviation from the actual time

Wavesurfer.js version(s):
5.0.2
Browser and operating system version(s):
Chrome. version is : 98.0.4758.109
Use behaviour needed to reproduce the issue:
When I user ws.getDuration() to get the duration of the audio, the result takes a deviation from the actual time. As shown in the figure below:

Can you use ffprobe (part of ffmpeg) to scan the audio file and paste output here?

Can you use ffprobe (part of ffmpeg) to scan the audio file and paste output here?

The result is as follow:
ffprobe version 5.0 Copyright (c) 2007-2022 the FFmpeg developers
  built with Apple clang version 12.0.5 (clang-1<IP_ADDRESS>)
  configuration: --prefix=/usr/local/Cellar/ffmpeg/5.0-with-options_1 --enable-shared --cc=clang --host-cflags= --host-ldflags= --enable-gpl --enable-libaom --enable-libdav1d --enable-libmp3lame --enable-libopus --enable-libsnappy --enable-libtheora --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libx265 --enable-libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-demuxer=dash --enable-opencl --enable-videotoolbox --disable-htmlpages
  libavutil      57. 17.100 / 57. 17.100
  libavcodec     59. 18.100 / 59. 18.100
  libavformat    59. 16.100 / 59. 16.100
  libavdevice    59.  4.100 / 59.  4.100
  libavfilter     8. 24.100 /  8. 24.100
  libswscale      6.  4.100 /  6.  4.100
  libswresample   4.  3.100 /  4.  3.100
  libpostproc    56.  3.100 / 56.  3.100
Input #0, mp3, from '下载.mp3':
  Metadata:
    date            : 2011
    artist          : Walter Isaacson
    title           : Steve Jobs
    album           : Steve Jobs (Unabridged)
    WOAS            : http://www.audible.com/pd/B005V0QI82
    track           : 1/46
    comment         : Based on more than 40 interviews with Jobs conducted over two years—as well as interviews with more than a hundred family members, friends, adversaries, competitors, and colleagues—Walter Isaacson has written a riveting story of the roller-coaster lif
    composer        : Dylan Baker
    UFID            : BK_SANS_005704
    NARRATEDBY      : Dylan Baker
    encoder         : Lavf58.20.100
  Duration: 00:12:36.30, start: 0.185756, bitrate: 128 kb/s
  Stream #0:0: Audio: mp3, 22050 Hz, stereo, fltp, 128 kb/s
  Stream #0:1: Video: mjpeg (Baseline), yuvj420p(pc, bt470bg/unknown/unknown), 500x500 [SAR 1:1 DAR 1:1], 90k tbr, 90k tbn (attached pic)
    Metadata:
      comment         : Other

Wavesurfer.js version(s): 5.0.2

Always test with latest version(s).

Always test with latest version(s).

Thanks, I upgraded the version, and now it's normal.

Wavesurfer.js version(s): 5.0.2

Always test with latest version(s).

Sorry, I have upgraded it to version 6.0.2, but the problem is still present.

can you convert it to wav using ffmpeg and see if that makes a difference.

can you convert it to wav using ffmpeg and see if that makes a difference.

Yes, it is normal when converting it to.wav file, according to my observation, some.mp3 files will have problems.

Ok, so it's a browser issue.

Ok, so it's a browser issue, not sure how wavesurfer.js can be improved here.

But if I get the duration of the audio through the <audio /> tag of the browser, the obtained value is normal.


Fix annoying whitespace in meta/main.yml

This is a minor change to fix some annoying whitespace left in meta/main.yml by ansible-galaxy init
when running molecule init.
Please see following gist for before/after behavior and output from tox.
https://gist.github.com/cimarron-pistoncloud/ebd7e61de92bc6e14cbe

I like this. Clears up a regular annoyance and potentially gives new users a better first impression of molecule. :+1:


Fix optional interface arguments when not using nn

Fix optional interface arguments when not using nn<> (issue #174).
Run Djinni in test suite as a Makefile target, not a variable.
Fixes to makefiles for Xcode 7.2.

@j4cbo I'd like your eyes on this if possible since you did the original nn support.

Ping @j4cbo now that you seem to be paying attention.  I'd love to get this accepted before I get back to work, since have some more partial diffs behind it.

LGTM!


Update SGHMC and SGLD

Pull Request Test Coverage Report for Build 441575990

49 of 50 (98.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.3%) to 73.716%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/contrib/inference/sghmc.jl
49
50
98.0%

Totals

Change from base Build 441116737:
4.3%

Covered Lines:
962

Relevant Lines:
1305

💛  - Coveralls

I'll do a proper review soon, but a quick qesh while we wait: would it be possible to make proper stochastic algorithms, i.e. do data-subsampling?
Either by introducing a way to filter VarName in DynamicPPL using a context, or somehow extracting the observations (maybe something similar to what we do with the GetLikelihoodContext or whatever it's called) and then just update in place. Thoughts? Or should we maybe make a separate issue over at DynamicPPL and do that work in a separate PR?

would it be possible to make proper stochastic algorithms, i.e. do data-subsampling?

I thought about this and was surprised that it was implemented but I didn't include it here since it was not part of the old implementation and it requires some additional thought and discussion which I assumed would be better to have in a separate PR or issue.
Mainly I thought about two approaches, both based on a special context and some special observe implementations to handle multiple observations in one ~ expression. One could try to extract the number of observations by running the fully sampled model once and then use the context to only sample one index (or a batch of indices) in every run and only include the corresponding observations. However, I assume that stochastic control flow would break this approach. As an alternative, one could instead specify the probability of an observation to be included (similar to dropout) and just decide randomly in each observe call if a (subset of) observation(s) will be included. This does not require a fixed number of observations and should work for all kind of models but there is a non-zero probability that all observations would be dropped - in this case it is not possible to normalize the (gradient of the) log probability with the number of considered observations.

I made a separate issue for this discussion: https://github.com/TuringLang/DynamicPPL.jl/issues/208

OK, let's address the subsampling issue in a separate PR!


setup.sh improvements

Uses the cleaner way of handling the package set.
Sets up /etc with correct file permissions.
Do not setup SELinux (it was removed in #66).
Correctly handles grub.
Sets access rights that are consistent with what is currently deployed.

Except for 2552d79e8f1ad4cc88c99fda7f487b42347a0dcc looks good to me.

bootstrapping question: how do we actually run setup.sh considering that shell-etc is not pulled in yet?
This matters, as if pulling in shell-etc adds in new debian sources, we'll possibly need to run the apt update && apt upgrade flow multiple times.

@daurnimator Basically, you either scp it to the remote box or fetch it from GitHub.

Except for 2552d79 looks good to me.

Currently 2552d79 mirrors shell servers; perhaps we should either:

change etckeeper permissions to mirror this, or
keep 2552d79

@ChickenNuggers The permissions in questions are not managed by etckeeper, FWIW.

Oh; after re-reading, it's in /var apparently. My bad. Either way, I do remember us attempting to do this on the servers and I also remember it being reverted. @lrvick was there a reason behind this, if you can recall?

@daurnimator Backed out the chmod utmp commit.  OK for merging this part?

Yep :)