Cyrillic + utf8 + rtf = bug

(Original issue 964 created by None on 2014-03-12T23:15:00.282389+00:00)
Steps to reproduce:

Create a utf8 file named 'test.php' and put this inside:

#!php

<?php
// определить сумму для каждой строки

Run 'pygmentize -l php -f rtf -O style=encoding=utf-8 test.php > result.rtf'
Open the file in RTF viewer (I\ve tested in TextEdit under MacOS)

Expected result:
You see the text you've provided.
Actual result:
#!php

<?php
// о¾п¿р€еµд´еµл»и¸т‚ьŒ суƒм¼м¼уƒ д´л»я кºа°ж¶д´о¾й¹ ст‚р€о¾кºи¸

As you might see, the result contains one extra crappy character per a correct one.

(Original issue 964 last updated on 2014-05-17T01:05:43.836427+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by jaingaurav2 on 2014-04-15T17:35:38.256119+00:00)
Potential fix in pull request #321

(Original comment by jambonrose on 2014-04-22T18:42:48.663975+00:00)
I can replicate the error described here with:
pygmentize -l text -f rtf -o result.rtf -O encoding=utf-8 test.php.
There are two problems with the RTF formatter. Pull request #321 fixes the first.
Quick review: Starting in RTF version 1.5, there are three ways to display a character glyph:

in ASCII (7 bits)
using code points for a code page, of the form \'xx, where xx is hex (this is an 8 bit extension of ASCII)
unicode, via an escape sequence \ud{\uNA}, where N is an integer, and A is ASCII or code point allowing legacy programs a fallback

The first problem stems form a misuse of Item 3. The A in \ud{\uNA} being output is neither an ASCII character nor a code point. For example, given €оп, the formatter outputs:
\ud{\u8364\'a4}\ud{\u1086о}\ud{\u1087п}
Observe how non-ASCII characters are used as fallbacks for the second two glyphs. The patch corrects the output to the following, using '?' as a fallback.
\ud{\u8364\'a4}\ud{\u1086?}\ud{\u1087?}
Problem 1 solved.
Problem 2 has to do with encoding and code pages. Because of the definition of RTF, the encoding and outencoding options are somewhat meaningless. However, an RTF should specify a code page: files output by Pygments do not. Editors that understand unicode in RTF (as of 1.5, ratified in 1997) will not need this, but at that point, \ud could be removed in favor for just \u.
I will attach two patches, at the discretion of the core maintainers.
The first patch maintains legacy compatibility by using the code page iso-8859-15, used because of its similarity to windows-1252. It should be very easy to modify this patch to use any other code page, and I am happy to do so upon request.
The second patch does not maintain legacy compatibility, and switches to using only Unicode characters without fallback.
Both patches work in Python 2 and 3, and effectively support all the unicode characters I tested, including surrogate pairs for glyphs outside of the 16-bit limit imposed by the format. (鼖, or u'\U0002fa1b', is correctly printed, for example).
In both cases, encoding and outencoding are ignored by the RTF formatter.
Note that it is possible to have the encoding and outencoding be used to specify the code page of the file. The problem with this approach stems from the RTF header, because each encoding is mapped to a magic number. For example, using iso-8859-15 results in the header \rtf1\ansi\ansicpg28605. The 28605 number refers to the code page. Using encoding and outencoding would thus necessitate building a table that maps encoding names to RTF code page numbers. Given the central use of UTF-8, and the fact that unicode support has existed since 1997, I do not see the benefit of doing this.
Aside: Hysterically, RTF 1.5 defines a code page for UTF-8 with surrogates. It is possible to thus use \ud with the intention of supporting legacy RTF standards, without actually doing so.

(Original comment by jambonrose on 2014-04-22T19:01:30.126979+00:00)
I am unable to attach files, as described in issue 8468 of the bitbucket site.

(Original comment by jambonrose on 2014-04-23T14:34:43.014172+00:00)
I am still unable to attach the patches to this issue, and I do not expect BitBucket to fix the problem anytime soon, as the two issues about the problem have been marked invalid (see link above).
I've uploaded the files to my own server. If someone would download them and attach them to the issue, that would be very helpful.
(links redacted - see pull request issued below)

(Original comment by tshatch on 2014-04-23T17:01:51.079847+00:00)
Thanks!  I prefer the utf-8 version; from looking at the date on the specs from Wikipedia, UTF-8 support has been in there for a long time.  Andrew, I assume most of your testing has been on Mac's Preview?
Please propose a pull request containing utf8.patch along with some sort of test... how expansive you want that to be is up to you, but I'd suggest that one that simply generates a .rtf file in a temp dir is enough; if it fails to generate, we've learned something, and it's an artifact that a human can examine in viewers to verify.

(Original comment by jambonrose on 2014-04-26T19:26:44.483183+00:00)
Really glad you asked for tests. Turns out the patch above isn't quite as correct as I'd thought (I'd forgotten to account for the fact that RTF limits unicode escape sequences to 16 bits, meaning that the 32-bit numbers output in Python 3 were being truncated by Text Edit and Libre Office, leading to incorrect results.)
Please see pull request #338 for the update to the patch, as well as a slew of tests for the issue.

(Original comment by tshatch on 2014-05-17T01:05:43.851421+00:00)
PR merged.


Can you make a link that automatically down loads this on your flipper through the app

You can download them either via the releases page or by navigating into the build folder


docs about Egui color space issues

On the vulkano discord I recently gave an explanation on how Egui handles color space and how it does not align well with vulkan. So I thought may as well expand on it and add it to the readme, so that users understand why and how to deal with it correctly.
docs: https://github.com/Firestar99/egui_winit_vulkano/blob/docs_color_space/README.md#the-correct-color-space
discord discussion: https://discord.com/channels/937149253296476201/937157678797553724/1196013225783869490

This looks good to me. Thanks @Firestar99


Travis build fails because "unable to locate credentials".

Travis build for #137 (https://travis-ci.org/weaveworks/integrations/builds/366114204) fails like so:
$ aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation.json" | jq .
Unable to locate credentials. You can configure credentials by running "aws configure".
The command "aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation.json" | jq ." exited with 255.
1.39s$ aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-no-app.json" | jq .
Unable to locate credentials. You can configure credentials by running "aws configure".
The command "aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-no-app.json" | jq ." exited with 255.
1.38s$ aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-larger-app.json" | jq .
Unable to locate credentials. You can configure credentials by running "aws configure".
The command "aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-larger-app.json" | jq ." exited with 255.
1.40s$ aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-identiorca.json" | jq .
Unable to locate credentials. You can configure credentials by running "aws configure".
The command "aws cloudformation validate-template --template-body "file:////${PWD}/aws/ecs/cloudformation-identiorca.json" | jq ." exited with 255.

@errordeveloper how is this supposed to work?
What is the Travis build even supposed to do?  Looks like a half-implemented step towards stopping publishing AMIs?

There are supposed to be secrets in Travis, maybe those got removed from
AWS or somehow else got invalidated...?
What Travis was supposed to do is validate CloudFormation temolates, and
publish them to S3. I had no intention to fully automate building the AMI
directly from Travis, becuase it is complicated, unless someone else tried
to implement that.
On Fri, 15 Jun 2018, 2:01 am Bryan Boreham<EMAIL_ADDRESS>wrote:

@errordeveloper https://github.com/errordeveloper how is this supposed
to work?
What is the Travis build even supposed to do? Looks like a
half-implemented step towards stopping publishing AMIs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/integrations/issues/138#issuecomment-397559496,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS8rIm_itXAkkJ_OJqeQEOZjVdGHVks5t83ftgaJpZM4TTegM
.


auto scroll stop after it scroll one slide and keep stoped until hoverd on them this happeningin cdn version

Checks

[X] Not a duplicate.
[X] Not a question, feature request, or anything other than a bug report directly related to Splide. Use Discussions for these topics: https://github.com/Splidejs/splide/discussions

Version
v0.3.7
Description
stops after scrolling on slide and dose not restart after interaction like this https://splidejs.com/extensions/auto-scroll/
Reproduction Link
https://codesandbox.io/s/splide-test-iy87td?file=/index.html
Steps to Reproduce

open the link
open preview in new window
open developer tool
wait for a second
second issue is
open the link
and scroll the splide component using mouse or touch it will not start automatically.

Expected Behaviour
excepted behavior should be like this example https://splidejs.com/extensions/auto-scroll/

splide scroll without stopping.
splide should continue to scroll after interaction.

I didn't see any issue on your example. Maybe your are looking for type: 'loop'?
new Splide( '.splide', {
  type: 'loop',
} );


Clean exit - BrokenPipeError

OS: Windows 10
Python: 3.6
Is there a way to have a clean exit from a program that uses the library Inputs?
I exit the while loop when the key ESC is pressed. However, the program does not terminate. If I press CTRL+C, the program does not terminate (s. image).
I even tried to attach a window to the main program (a pygame window) that when closed terminates it. It seems to work at first glance, but if I press any keyboard key after closing that window I get a BrokenPipeError (s. image).
Any ideas?

I have this problem on my windows 10 machine as well.
Is there some way to call a function to exit?

This is what happens when I do ctrl+c:
Traceback (most recent call last):
File "_ctypes/callbacks.c", line 234, in 'calling callback function'
File "C:\python35\lib\site-packages\inputs.py", line 1670, in handle_input
def handle_input(self, ncode, wparam, lparam):
KeyboardInterrupt
the ctrl+break works for me, (it's fn+b on my Lenovo).
sys.exit()
does the same as break
This looks like a threading issue. The thread listening to keyboard input needs to be made a daemon thread so when the main thread exits, the daemon thread exits as well.
Is there any way of simulating input with inputs?

I'm running into the same issue.  This module is perfect for my application except that I can't get it to exit cleanly, which is sometimes important.  Are there any updates or a better work-around for this issue?


Add Tag to page without Editing

Desired Feature
The ability to add tags to a page without having to edit the page. I find that sometimes I forget to add a tag to the page but don't remember to do so until I've already saved the page, Would be nice to be able to have a "+ Add Tag" button under the already assigned tags for the given page.
I would say you have to have edit permissions to be able to add tags to avoid potential issues there.
Just a thought. Nothing pressing here. Simply my laziness speaking :)

That would be so convenient

Suggested/Alternative feature enhancement:
Bulk Tag Editor functionality to modify/add/remove the same key value pair to multiple shelves, books, chapter, and/or pages in one shot.


Identify system invariants

We should identify and document the core system invariants. This would help us to more easily spot problems in the accounting model and is something that can be verified by fuzz tests to find bugs. One example of such an invariant is that if all of the funds are removed from Hyperdrive, there is no base left in the contract.

Closing this since we've identified these invariants and have been fuzzing them with agent0.


Android click sounds on press

Android should play a sound effect on click by default.
Since the ReactNative touch event model circumvents the usual Android OnClickListener, we trigger the click sound manually.

@sahrens would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

Nice, but I doubt all apps want this - can you add a global config to turn it off? Like Touchable.DISABLE_DEFAULT_SOUNDS that people can set when there app first initializes, and a comment in the docs?  cc @dmmiller and @mkonicek for thoughts.
For the propTypes, does it work to factor them out into a shared class, TouchablePropTypes? Make sure that if there are legit differences between the same propType docs on different touchables that those differences are preserved.
Also, please rebase and fix the conflicts and get tests passing.

It's rare for apps in Android to play a sound on touch. So I'd say it should be off by default.

@satya164 @sahrens if you turn on system sounds in android sound settings you'll notice that almost all apps play a click sound on touch, as its default onClick handler behaviour. (I think almost everyone has system sounds turned off for this reason)

@mikemonteith Ah. Weird.

Tested a few apps on Android and every touchable element always produces a sound so I think this should be enabled by default and not even be a prop. It's up to the user to enable / disable touch sounds but apps should not decide whether or not there should be one.

Tested a few apps on Android and every touchable element always produces a sound

@janicduplessis On my Nexus 5X I actually had sounds disabled in Settings -> Sounds & notifications -> Other sounds -> Touch sounds.
Now when I enabled it all touchables produce a sound, as long as the media volume is not muted.
@mikemonteith Let's play the sounds by default, agree with @janicduplessis we don't need the prop, as long as the behavior respects the system setting.

Also right now react native apps touch sounds are inconsistent since touchable elements don't produce sounds but other native controls like Toolbar buttons do.

Is there a way we could cleanly fake this? Ex: by calling into an audio library directly, or sending fake touch events to a single offscreen button?

@ide I'm pretty sure this PR does exactly what we want by calling https://developer.android.com/reference/android/view/View.html#playSoundEffect(int)

Looks like there's some interest in this PR. Would you like me to make any changes to it?

@mikemonteith Yes, could you remove the prop you added and always play the touch sounds, could you also make sure it repects the system setting for touch sounds.

Thanks for updating the pull request @mikemonteith 👍 I added one question.
Can you please add a test plan demonstrating the system setting is respected (you can hear sounds if and only if this is enabled in system settings)?
For an explanation of what a test plan is, see https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md

Added the 'needs revision' label because we need a test plan to see this respects the system settings.

@mikemonteith updated the pull request.

What’s the status on this? Also, maybe there should be a prop to enable/disable this?

@mikemonteith This looks pretty good now and it's useful. Would be cool to get this in. Do the sounds get muted when you turn them off in system settings?

This PR does indeed respect the system sounds setting.
I've updated the commit message with a better explanation. Does anyone have an idea of how we can write proper tests for this?

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @sahrens as a potential reviewer. Could you take a look please or cc someone with more context?

@facebook-github-bot shipit

Tried importing and this is failing on some internal tests.  The problem is that you call findNodeHandle on things that might not end up in the tree.  In particular, it is failing on a test like this :
<Text style={styles.centeredText} onPress={this.handlePress.bind(this, 'text2')}>
          <Text onPress={this.handlePress.bind(this, 'nested1')}>link</Text>
          {' text '}
          <Text onPress={this.handlePress.bind(this, 'nested2')}>link</Text>
</Text>

Try clicking on one of the nested text pieces.  This fires an event on a virtual node which you then dispatch on.  That doesn't actually exist in the tree.  I think you can get around this by perhaps just always passing the root or something.

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

Hi, any updates on this?

@mikemonteith I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment requests changes. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to continue working on this.
I think this is useful! If anyone wants to send a new PR with this code, addressing the comment about findNodeHandle failing tests by @dmmiller it would be cool to get this in!

Hey guys, why did we not implement this? It's driving me crazy as a new react-native user. It totally pulls me away from the 'native' feeling.

I can't believe this issue is still not fixed for years.

I gave up.
On Oct 8, 2017 21:18, "Burak Çalık"<EMAIL_ADDRESS>wrote:

I can't believe this issue is still not fixed for years.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/6825#issuecomment-335052300,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcCuP_b7xBMJK4TFTMT90Ea8De_58Ddsks5sqXRvgaJpZM4IAb0i
.

Hi. I haven't worked on a react-native project for over a year now so this is very low on my priority list. The pull request is so old that I'm sure it needs to be looked at anew.
Hopefully someone else can pick this up before I eventually get round to looking at it again.


filter on dates since for date_created and date_updated

Fixes #530 and #531
Notes:

I added a method SearchArgs#Cleanup that removes empty slices, or empty values from the filters. Reason: this type of filter introduces empty values in the url as it is a simple text input, while the other filters work with checkboxes that do not send anything when unchecked. The cleanup is called in both handlers of publications and datasets.
This is a "new" kind of filter, for which no facets are needed
Since where are filtering here not just on regular values, but on dates, query syntax errors may occur. As I did not see a way to report this errors, I "fixed" it for now by searching for a date in the far future so it always returns zero results. See es6.ParseTimeSince. Maybe not ideal, but expected.

TODO: return query syntax error instead of searching for something in the future.


Feed not found for customized atom feed

Hi, I've created binance news atom feed "http://<IP_ADDRESS>/binance" but it says "Feed not found"

What kind of account are you using? I was able to add the feed using the local account.

Oh, I use feedly. Maybe it is feedly's issue.

I'm pretty sure it is on the Feedly side. If it looks like there is anything we can do to help, we can reopen this issue.


Fix sync

Codecov Report

Merging #186 into master will increase coverage by 0.09%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   69.35%   69.44%   +0.09%
==========================================
  Files          28       28
  Lines        1664     1669       +5
==========================================
+ Hits         1154     1159       +5
  Misses        510      510

Impacted Files
Coverage Δ

opwen_email_client/webapp/actions.py
36.23% <0%> (ø)
:arrow_up:

opwen_email_client/domain/email/store.py
97.1% <100%> (ø)
:arrow_up:

opwen_email_client/domain/email/sql_store.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66234c6...3e85808. Read the comment docs.


Call Hierarchy result is incomplete when clangd run with remote index environment

Hi everyone,
I not sure it's misconfiguration or bugs.
I used clangd-indexer to generate index file and deploy clangd remote index server in internal
environments
Everything is work until I use "Show Call Hierarchy" feature in VS Code.
(Find All References with remote index is work and very fast , remote index is powerful and smoothly )
I use Show Call Hierarchy button on VScode with Remote Index .
It seem clangd only refers opened file and show corresponding info.
(It means overall Call Hierarchy is incomplete in whole codebase)
but, when I build up background index is workable and can provide correct and all "Call Hierarchy" information.
I try to enable --log=verbose in remote index server and clangd process
request v1/Refs => OK: 48 result in 2ms
request v1/Lookup => OK 1 result in 0ms
It seems first request found correct references count
but, Lookup is incorrect result.. I not sure why clangd filter out references result
Very thanks for your reading.
anyone can help give some suggestion. I very appreciate it
It's sys information
Clangd / Clangd Remote index version : 14
Editor/LSP plugin: VScode + Clangd
Operating system: Linux u1804

this seems like an issue, but we're not prioritizing right now. so any help is welcome

Thanks for your reply.
To help me to confirm it's a issue

Confirming that we're also seeing this issue. Will try and contribute a fix if I get some spare time.

Can we get this fixed?

Folks following this thread: if you're able to try the patch at https://github.com/llvm/llvm-project/pull/71605 and see whether it fixes the problem, that would be helpful info

Thanks for community help :)


Create ko_kr.json

Added Korean translation for Crumbs.
Crumbs 모드를 위한 한국어 번역을 추가하였습니다.

Thank you :)
In case you are interested, we have a translator role on our discord server: https://discord.gg/APPWa6s.
This would allow for us to notify you when we need to update or create new translations.
It's totally optional and either way we are grateful for your contribution!

Thank you :)
In case you are interested, we have a translator role on our discord server: https://discord.gg/APPWa6s.
This would allow for us to notify you when we need to update or create new translations.
It's totally optional and either way we are grateful for your contribution!


Provide Linting for JSON input

JSON Linting such as the one used on http://jsonlint.com/ would be really helpful.

Apologies, I've noticed that there is linting!
However a trailing comma shows as a warning an not an error.

@cameron-fgx Are you still seeing this issue in the latest version? The request body editor now shows an error for trailing commas.


chore: project addition by Deepak

Add a new project to the list
Add IOT project of Making the Real time temperature and humidity detection using ESP32 and DHT11.

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

assigned to you

@priyankarpal please add the gssoc tag and level :)

@priyankarpal please add the gssoc tag and level :)

We are not providing any labels for project additions as they are not associated with solving any issues.( according to gssoc23 rules)

Okay no worries :)
just merge the pr


How to load the downloaded mathjax cdn in angular 7

instead of this above link i am passing js file as below in  angular 7 index.html

or

so it's showing 500 error
Please team can you resolve this issue ASAP
mathjax version is 2.7.5

FIrst, note that version 2.7.1 is rather old.  The current 2.x version is 2.7.8.  The current version over all os 3.0.5, so you may wish to consider using that rather than 2.7 unless you have legacy code that calls on v2's application interface (which has changed in v3).
If your server is an Apache server, the 500 error means that there is an "internal server error", so suggests a misconfiguration of your server.  See this site for some suggestion on how to proceed, or google "apache 500 error" to see other options.
The main step will be to look at the server logs to see if there is more information there about the error and what is causing it.
Another thing to check is that you have actually included the complete MathJax installation in your configuration/src/js and not just the MathJax.js file, which is not all that is needed.  See the v2 documentation for how to obtain the full MathJax installation for v2, and the v3 documentation for how to do that for version 3.


[FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character

What is the purpose of the change
To fix the wrong behavior for insert overwrite with Hive dialect when the table name contains uppercase character.
Brief change log
When decide it's overwrite or not, we should use the lowercase of the table name.
Verifying this change
Add test in HiveDialectITCase#testInsertOverwrite.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure


BMv2 SAI support for allownull

I'm using the BMv2 SAI to add a default route but got the following error in the SAI thrifit
e:- mutateTableEntry: GRPC ERROR[2]: ,`
type.googleapis.com/p4.v1.Error&Unexpected number of action parametersALL-sswitch-p4org
e:- mutateTableEntry: GRPC call Write::INSERT ERROR: table_id: 49279256 match { field_id: 1 lpm { value: "\000\000\000\000" prefix_len: 96 } } action { action { action_id: 32404057 params { param_id: 1 value: "\000\000" } } }

My code looks like
        route_entry = sai_thrift_route_entry_t(
            vr_id=None, destination=sai_ipprefix("<IP_ADDRESS>/0"))
        sai_thrift_create_route_entry(
            saithrift.client, route_entry, packet_action=SAI_PACKET_ACTION_DROP)

which is similar to SONiC SWSS:https://github.com/sonic-net/sonic-swss/blob/5f367ebb63dab68e73b74092fc083d3d1755b4b3/orchagent/routeorch.cpp#L91-L108
that adds a default route with an action drop.
I suspect the above error was caused by the unsupported of ignored parameter: next_hop_id
https://github.com/sonic-net/DASH/blob/e1309e9c1f20cd210fb9f7a13987f8262e76f372/dash-pipeline/bmv2/underlay.p4#L41-L49

Hi Ze,
The underlay support for DASH bmv2 is extremely limited and was mainly added to be able to select which of two ports in the bmv2 model one can route packets out of. Without it, packets would always come out the same port (hairpin). In fact, you can only set nexthop to 0 or 1 corresponding to the two bmv2 dataplane ports. We were under no illusion this was anything close to proper support of underlay functionality, but it was enough to select which port packets route out of for simple test cases. To add true underlay to DASH bmv2 is a large project which perhaps someone will undertake someday.
Here is a test case which applies values of 0 and 1 to the the nexthop id. https://github.com/sonic-net/DASH/blob/main/test/test-cases/scale/saic/vnet_route_setup_commands_bidirectional.json#L614
As a side-comment, the title of this issue doesn't seem to match what you are describing, i.e. failing to add a default route. It might help in tracking this issue to alter it. Thanks.

Even if I exactly pass the value of the next hop, BMv2 doesn't support the default route "<IP_ADDRESS>/0" yet and got the following error:
Dec 27 11:29:50.768826 vlab-01 ERR syncd#syncd: e:- mutateTableEntry: GRPC ERROR[2]: , #010#002#032¡#001#012#037type.googleapis.com/p4.v1.Error#022~#010#003#022gInvalid reprsentation of 'don't care' LPM match, omit match field instead of using a prefix length of 0#032#021ALL-sswitch-p4org
Dec 27 11:29:50.768826 vlab-01 ERR syncd#syncd: e:- mutateTableEntry: GRPC call Write::INSERT ERROR: table_id: 49279256 match { field_id: 1 lpm { value: "\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000" } } action { action { action_id: 32404057 params { param_id: 1 value: "\000\000" } params { param_id: 2 value: "\000\000" } } }

Hi Ze, The underlay support for DASH bmv2 is extremely limited and was mainly added to be able to select which of two ports in the bmv2 model one can route packets out of. Without it, packets would always come out the same port (hairpin). In fact, you can only set nexthop to 0 or 1 corresponding to the two bmv2 dataplane ports. We were under no illusion this was anything close to proper support of underlay functionality, but it was enough to select which port packets route out of for simple test cases. To add true underlay to DASH bmv2 is a large project which perhaps someone will undertake someday.
Here is a test case which applies values of 0 and 1 to the the nexthop id. https://github.com/sonic-net/DASH/blob/main/test/test-cases/scale/saic/vnet_route_setup_commands_bidirectional.json#L614
As a side-comment, the title of this issue doesn't seem to match what you are describing, i.e. failing to add a default route. It might help in tracking this issue to alter it. Thanks.

Hi Chris,
Thanks for your suggestion. I'm working on using the BMv2 as the dataplane of SONiC KVM. This issue is for tracking the problem I encountered with the current SONiC SWSS.

Hi, @kcudnik could you please help to take a look.

Thanks for your suggestion. I'm working on using the BMv2 as the dataplane of SONiC KVM. This issue is for tracking the problem I encountered with the current SONiC SWSS.

Hi @Pterosaur Thanks, understood. I think if you were to start tallying the gaps you will start creating a lot of issues and find you're barely chipping away at it. It might make more sense to do a more comprehensive analysis of what is needed, and if using the DASH P4 model as a starting point is even appropriate.
 It has been a wish-list item since the inception of the DASH project. One might even say it is outside the scope of DASH itself (which focuses on overlay services definition and APIs), and deserves its own project to which DASH could be an enhancement. At one time there was a highly functional P4 model of SAI dataplane written in P4 but as far as I know it is very behind the current definition.
Also note that BMv2 uses the P4 V1 architectural model which lacks certain capabilities required to truly support DASH (statefulness such as add-on-miss, range-lists match type). Long term we are hoping newer back-ends like P4-DPDK and maybe even P4-TC will be available to take over from bmv2 and provide more capabilities, PNA compliance, much higher performance and longer-term community support.

@Pterosaur - can we close this one, as it looks like we are trying to use a non-existent feature?

@Pterosaur - can we close this one, as it looks like we are trying to use a non-existent feature?

@r12f is working on this issue. It looks like a feature that's compatible well with the existing SONiC system.
We expect a hairpin capability in DPU (as well as BMv2). But right now, some vendors can just support the U-turn behavior. So, I feel we should adopt these two behaviors for the current development stage and future requirements.
This issue is for tracking the underlay route with these two behaviors. I think we can close it once the Riff enhances the BMv2 implementation.

Thanks Ze 😊
From: Ze Gan @.>
Sent: Thursday, February 29, 2024 7:44 PM
To: sonic-net/DASH @.>
Cc: Kristina Moore @.>; Comment @.>
Subject: Re: [sonic-net/DASH] BMv2 SAI failed to add a default route with DROP action but no next hop (Issue #496)
@Pterosaurhttps://github.com/Pterosaur - can we close this one, as it looks like we are trying to use a non-existent feature?
@r12fhttps://github.com/r12f is working on this issue. It looks like a feature that's compatible well with the existing SONiC system.
We expect a hairpin capability in DPU (as well as BMv2). But right now, some vendors can just support the U-turn behavior. So, I feel we should adopt these two behaviors for the current development stage and future requirements.
This issue is for tracking the underlay route with these two behaviors. I think we can close it once the Riff enhances the BMv2 implementation.
—
Reply to this email directly, view it on GitHubhttps://github.com/sonic-net/DASH/issues/496#issuecomment-1972364984, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFJSI6GJQAE6OK7PLNH2WVTYV7TNJAVCNFSM6AAAAABBDCMGWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGM3DIOJYGQ.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

Hi, @kcudnik could you please help to take a look.

From logs seems like response from grpc on bmv2 is returning failure, co clue why, syncd just logged that but why grpc returned that :( maybe try enable debug logging, is this reproducible?

Fix by the PR: https://github.com/sonic-net/DASH/pull/547


[Bug]: Uncovered lines are shown as covered when there are annotations

Description
$title. May be related to annotation closures.
Steps to Reproduce
import ballerina/graphql;

service class Profile {
    private final string name;
    private final int age;

    function init(string name, int age) {
        self.name = name;
        self.age = age;
    }

    resource function get name() returns string {
        return self.name;
    }

    resource function get age() returns int {
        return self.age;
    }

    resource function get isAdult() returns boolean {
        return self.age > 21;
    }

    resource function get reviews() returns Review[] {
        return [
            new (1, "review 1"),
            new (2, "review 2")
        ];
    }
}

annotation MyAnnot on parameter, return, class;

@MyAnnot
service class Review {
    int id;
    string content;

    function init(
            @MyAnnot
                int id, string content) {
        self.id = id;
        self.content = content;
    }

    resource function get id() returns @MyAnnot int {
        return self.id;
    }

    resource function get content() returns string {
        return self.content;
    }
}

service /graphql on new graphql:Listener(9090) {

    resource function get profile() returns Profile {
        return new ("John Doe", 51);
    }
}

Tests
import ballerina/graphql;
import ballerina/test;

final graphql:Client cl = check new ("http://localhost:9090/graphql");

@test:Config
function testCallOriginal() returns error? {
    json j = check cl->execute(string `{ profile { name isAdult } }`);
    test:assertEquals(j, {"data":{"profile":{"name":"John Doe", "isAdult":true}}});
}

Affected Version(s)
2201.9.0-rc1

This issue can be mitigated by removing the position information of the annotation desugered functions from the line number table. This will ignore the lines related to annotations from the code coverage. If we do so, annotation related (annotation desugared functions) lines will be excluded from the stack traces as well.
eg.,
1   annotation ZeroDiffAnnot zeroDivAnnot on function;
2
3   function zeroDiv(int n) returns boolean {
4     return n / 0 == 0;
5   }
6
7   @zeroDivAnnot {
8      value: "ZeroDiv",
9      out: zeroDiv(10)
10   }
11   function foo(int n) returns int {
12      return n;
13   }

error: {ballerina}DivisionByZero {"message":" / by zero"}
        at gabilan.test_project.0:zeroDiv(main.bal:4)
           gabilan.test__project.0:$annot_func$_0(main.bal:9)

If we remove the line numbers of annotation desugared functions from the line number table, the stack trace will not contain the line gabilan.test_project.0:$annot_func$_0(main.bal:9).
Since, the annotation related bytecode instructions are used during the test running, the jacoco will detect the lines related to those bytecode instructions as partially/fully covered.

It seems without removing the positions related to the annotations from the line number table, we can't avoid the annotations from the code coverage. Anyway the code coverage of actual code lines which are need to be covered by the user's test cases are depend on the availability of the tests.
So, IMO it's okay to show the annotation related lines as covered in the coverage report. @warunalakshitha @MaryamZi WDYT?

How do we decide if it is covered? For example, with the original example, a Review object is not even created, but relevant code lines are shown as covered, which is not correct IMO.

How do we decide if it is covered? For example, with the original example, a Review object is not even created, but relevant code lines are shown as covered, which is not correct IMO.

Agree. But the following case also panics without the function foo() is being called inside the main.
1   annotation ZeroDiffAnnot zeroDivAnnot on function;
2
3   function zeroDiv(int n) returns boolean {
4     return n / 0 == 0;
5   }
6
7   @zeroDivAnnot {
8      value: "ZeroDiv",
9      out: zeroDiv(10)
10   }
11   function foo(int n) returns int {
12      return n;
13   }

This is happening due to the annotation desugared are getting called during the initialization phase.
It may not be needed to consider annotations for code coverage, since they usually provide structured metadata about a particular construct. So we can omit annotation related lines from code coverage.
But what about removing the entry related to the line-number 9 of the above example from the stack trace?

Spec says, An annotation applied to a module-level declaration is evaluated when the module is initialized. An annotation applied to a service constructor is evaluated when the service constructor is evaluated. An annotation occurring within a type descriptor is evaluated when the type descriptor is resolved.
Since the annotations related lines of module-level declarations are evaluated at module initialization, the bytecode instructions related those lines are executed during the test run, even there are no added tests. So jacoco marks those annotation related lines are covered.

There are lines showed as covered in the following case without having relevant added tests.

This is because these functions are called at module init, start and stop.


continue setting up ci

TODO in follow-up prs:

fix codecov upload
use the hatch env matrix to test on older versions of the dependencies
reduce the size of the host x python version matrix
cache the hatch environments


ERR_INVALID_PROTOCOL - Protocol http not supported, expected https

Hello Team 👋
We are facing issues while referencing open api specs from a local url over http (e.g. http://localhost:80/apispecs.json), which ends up generating the following error:
 OAS URL error - There is a problem with the url: "http://localhost:80/apispecs.json"
 TypeError [ERR_INVALID_PROTOCOL]: Protocol "http:" not supported. Expected "https:"

This issue has surfaced in the recent releases e.g. v1.26.3, while this works perfectly fine in earlier version e.g. v1.24.0.
While a local file reference as an alternative is possible, this still affects the use case for synchronisation or doing contract testing for the specs generated on the fly locally. Being able to reference a local url over http would be ideal.
Thank you!

Can you share a OpenApi example so we can better understand the unexpected behaviour?

I believe the issue is not related to the OpenApi specification file, but rather the protocol it is being served on.
For example, you can use the specs from the example
https://github.com/apideck-libraries/portman/blob/main/examples/cli-options/crm.openapi.yml
Then use this specs served from localhost over http:
portman -u http://<IP_ADDRESS>:8080/crm.openapi.yml -b http://<IP_ADDRESS>:8080 -n true
This will produce the protocol error that http is not supported it should be served over https, which seemed to work fine till version v1.24.0
Kindly let me know if you require further details

hi @qaribhaider
We found the reason for the limitation in the OpenAPI format dependency.
We have PR for support http & https. It should land soon, which will trigger a version bump for Portman, solving this issue.

@thim81 Thank you, looking forward to this being released

hi @qaribhaider
We just release v1.26.4 which should handle http & https remote files properly.
Let me know if the new version did not solve your issue.


CuboCore.libcsys: 4.3.0 -> 4.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libcsys/versions.
meta.description for CuboCore.libcsys is: "Library for managing drive and getting system resource information in real time"
meta.homepage for CuboCore.libcsys is: "https://gitlab.com/cubocore/libcsys"
meta.changelog for CuboCore.libcsys is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.4.0 in filename of file in /nix/store/128mz0gkxpb48mvgzd28xgf2jwvci9s8-libcsys-4.4.0

Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)

21 package rebuild(s)

First fifty rebuilds by attrpath
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/128mz0gkxpb48mvgzd28xgf2jwvci9s8-libcsys-4.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A CuboCore.libcsys https://github.com/r-ryantm/nixpkgs/archive/7996ff67df950f435a8f08e4f59302b12a63453a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/128mz0gkxpb48mvgzd28xgf2jwvci9s8-libcsys-4.4.0
ls -la /nix/store/128mz0gkxpb48mvgzd28xgf2jwvci9s8-libcsys-4.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

CuboCore.coreaction
CuboCore.corefm
CuboCore.corestats

18 packages built:

CuboCore.corearchiver
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys

Maintainer pings
cc @dan4ik605743 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libcsys/versions.
meta.description for CuboCore.libcsys is: "Library for managing drive and getting system resource information in real time"
meta.homepage for CuboCore.libcsys is: "https://gitlab.com/cubocore/libcsys"
meta.changelog for CuboCore.libcsys is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.4.1 in filename of file in /nix/store/128qjvw6n6qs04x502mffwy6swccvncr-libcsys-4.4.1

Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)

21 package rebuild(s)

First fifty rebuilds by attrpath
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/128qjvw6n6qs04x502mffwy6swccvncr-libcsys-4.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A CuboCore.libcsys https://github.com/r-ryantm/nixpkgs/archive/dd8e0e4a4b29a95bbac4a46f3edd5a2cd0d36c8a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/128qjvw6n6qs04x502mffwy6swccvncr-libcsys-4.4.1
ls -la /nix/store/128qjvw6n6qs04x502mffwy6swccvncr-libcsys-4.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

CuboCore.coreaction
CuboCore.corefm
CuboCore.corestats

18 packages built:

CuboCore.corearchiver
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcsys

Maintainer pings
cc @dan4ik605743 for testing.

Superseded by #218336.


Manage and Control the use of non-negative amounts

Problem description
Within carrier_billing.yaml monetary amounts MUST be positive. Negative values do not make sense and also "zero" value is not indeed a payment.
Due to this, proposed solution considers to set minimum value for "amount" fields to 0.001. In the API Spec this would be:
...         amount:           type: number           format: float           **_minimum: 0.001_**           multipleOf: 0.001           description: Amount to be charged or reserved.           example: 100 ...
NOTE:

this would also apply in Ongoing #152
Consideration of 400 Exception can be applied during PR discussion

Possible evolution
Taking advantage of Open #152, it is proposed to deal with this issue within Carrier Billing v0.3.0 and new Refund Interface.
Alternative solution
Include as a Fix for carrier_billing.yaml v0.2.1 separately
Additional context
N/A

cc @bigludo7, @rartych, @eragaji (please mention here Barath if he owns github account)

Also to consider for taxAmount, in order to not be negative


Remove search box

Purpose

Current search box is not working. We need to bring it back.
Issue to track this is :
https://github.com/wso2-enterprise/choreo/issues/4532

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.:white_check_mark: shaniR:white_check_mark: a5anka:white_check_mark: anupama-pathirage:x: udhanMtiYou have signed the CLA already but the status is still pending? Let us recheck it.

We will have to remove the search box from the header too right?

We will have to remove the search box from the header too right?

No we don't need to remove from there. It is checking whether the plugin is activated in config. So that if condition will be false, when we remove from here.
https://github.com/wso2/docs-choreo-dev/blob/main/en/theme/material/partials/header.html#L51


Cursor auto move to the end

When moving the cursor to any group number except the last one, after adding a number the cursor auto move to the end.
Ex: I have a phone number like +61 475 888 678. When I move the cursor to between 4 and 7 in 475 and add the number 6 the phone number become +61 467  88  8678(correct) but the cursor doesn't stay after 6, instead, it moves to the end.

@tonygentilcore I will need more detail. I don't understand it at all. Can you provide more detail with a codesandbox link, if possible?

Getting the same issue.
sharing codesandbox link pfa.
https://codesandbox.io/s/unruffled-bessie-ml1l1t?file=/src/App.js


Custom provider

Issue
I have an ISP that provides access to Claude via openai interfaces. Here are the contents of my .aider.models.json file:
{
    "claude-3-5-sonnet-20240620": {
        "max_tokens": 4096,
        "max_input_tokens": 200000,
        "max_output_tokens": 4096,
        "input_cost_per_token": 0.000003,
        "output_cost_per_token": 0.000015,
        "litellm_provider": "openai",
        "mode": "chat",
        "supports_function_calling": true,
        "supports_vision": true,
        "tool_use_system_prompt_tokens": 159
    }
}

But when I try to connect with the command
aider --model openai/claude-3-5-sonnet-20240620 I got:
Model openai/claude-3-5-sonnet-20240620: Unknown context window size and costs, using sane defaults.
Did you mean one of these?
- openai/claude-3-5-sonnet-20240620
- openai/claude-3-5-sonnet-20240620
- openai/claude-3-5-sonnet-20240620

Am I doing something wrong?
Version and model info
Aider v0.45.1
Model: openai/claude-3-5-sonnet-20240620 with diff edit format
Git repo: .git with 0 files
Repo-map: using 2048 tokens

It seems like the filename is wrong. I had a similar issue once. You may have to check this page in the docs:
https://aider.chat/docs/config/adv-model-settings.html
You can either set the file in config or use the expected name .aider.model.metadata.json.

It seems like the filename is wrong. I had a similar issue once. You may have to check this page in the docs:
https://aider.chat/docs/config/adv-model-settings.html
You can either set the file in config or use the expected name .aider.model.metadata.json.

Thanks, this works :)

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


test(RHDP-579): remove 'Ordered' in [e2e-demos-suite]

Description
When Ordered is used, the scenarios tests "will never be randomized and they will never run in parallel with one another, though they may run in parallel with other specs".
Since the order in which the e2e-demos-suite (nodejs, dotnet, etc...) is running is irrelevant, we can remove it in order to run them in parallel.
Issue ticket number and link
RHDP-579
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
make local/test/e2e
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("[test_id:01] DEVHAS-62 devfile source")
[ ] I have updated labels (if needed)

/ok-to-test

/retest

/test redhat-appstudio-e2e

/retest

/test redhat-appstudio-e2e


Introduce len-in-bytes size mechanism for XNET APIs that require size in number of bytes

What does this Pull Request accomplish?
This PR introduces new size mechanism len-in-bytes for input parameters. Existing len mechanism computes length of input array and passes that as size parameter to library API. Some of XNET APIs expect "number of bytes" to be passed to library calls.  So this new mechanism multiplies size of array by type of array to compute number of bytes.
I have tagged appropriate APIs from XNET with new mechanism.
Why should this Pull Request be merged?
Size for these APIs was passed incorrectly while calling the C API resulting in error. This new mechanism fixes this issue for XNET APIs.
What testing has been done?

Executed python examples which exercise some of these APIs. Earlier we had observed errors during driver calls for these, now these APIs seem to return expected value.

@doshirohan Have y'all been using validate_examples.py to run/lint examples? You don't need to, but it might be helpful. And the non-runtime validation will run on the PR build.

@doshirohan Have y'all been using validate_examples.py to run/lint examples? You don't need to, but it might be helpful. And the non-runtime validation will run on the PR build.

@astarche I am aware of validate_examples.py but we haven't used it yet. @kothariaman once you have examples in good shape you can use validate_examples.py to run all of them in single go. This will probably take care of compiling proto file as well making it easier to validate examples against latest proto from your branch.


Issue with cyrillic translation duplicated URL

Hi, managing russian and bulgarian traslation in a full static generated site lead to a duplicated url.
for example:
Nuxt configuration
ssr: true
target: static
Example Link
URL 1
http://localhost:3000/халкидики-виллы
URL 2
http://localhost:3000/халкидики-виллы/
What is Expected?
i18n-module should generate the language routes for non latin characters without duplicate the URL and without fallback to spa pages
What is actually happening?
URL 1 fallback to the spa page, instead URL 2 is the correct static page generated. I need that the nuxt generate produce only the static page without the "/" at the end to avoid content duplication and spa fallback
This happens only if in my page I use cyrillic translated URL.
If I change the russian and bulgarial URL with latin characters everything works fine.
I just write all the details at this link:
https://stackoverflow.com/questions/67161933/nuxt-full-static-generated-page-issue-with-cyrillic-uri
Maybe it's only a matter of wrong configuration in nuxt.js but I'm not able to fix this.
Thank in advance for the support.

Please create a minimal reproduction if you want me to have a look. You can do it on codesandbox for example (using this template https://codesandbox.io/s/nuxt-nuxt-i18n-base-template-sty4f?file=/nuxt.config.js).
Can just say generically that with static generation you get a folder structure like халкидики-виллы/index.html so the URL without / doesn't really exist and the server has to redirect to an URL with the slash.
There is this Nuxt option https://nuxtjs.org/docs/2.x/configuration-glossary/configuration-generate#subfolders that you can try changing to false but it might cause you some other issues.

Hi,
thanks for your fast feedback,
I recreate a small example project, you can clone it from:
https://github.com/virtuallabdev/nuxt_i18n

generate the static site
go to the villas page
if you click on lang switcher button you can see in the browser console the log of the spa fallback
If you switch back to english no log are show in console because you land in the static page
If you add a "/" at the end of bulgarian or russian villas page you landin the static page (no log in the console)
If you change the i18n in the villas page using the commented part you can see that after you have generated the full static site everything works as expected

Here is a simple repo that reproduces with pure Nuxt so please report this in Nuxt repo instead: https://github.com/rchl/nuxt-link-cyrillic-static

Thanks for your support


Fix monkey patching in Ember 2.x polyfill code paths

This PR fixes the bug identified in https://github.com/ember-polyfills/ember-angle-bracket-invocation-polyfill/issues/53. The fix in https://github.com/ember-polyfills/ember-angle-bracket-invocation-polyfill/pull/55 was only a partial fix: we also need to fix the monkey patching of manager.didCreateElement.
I noticed this because our CI (which has 1000s of tests) was crashing with a stack overflow.
The first commit in this PR contains a set of log statements that I added to demonstrate the problem. They're reverted in the second commit (and can be squashed out before merging). The third commit is the fix.
It's tricky to write a test for this that doesn't a very long test suite or even more monkey patching of an already complicated situation, so I opted to add some logging and to share some screenshots instead. The log statements are used to keep track of how deeply recursive the manager.didCreateElement calls get. You can see from the screenshots below that in Ember 2.12 and Ember 2.18 they grow linearly, but they should always be exactly one. The problem does not occur in Ember 3.3. After the fix is applied there are no recursive calls.
Before the fix (Ember 2.12):

Before the fix (Ember 2.18):

Before the fix (Ember 3.3):

After the fix (Ember 2.12):

After the fix (Ember 2.18):

The CI failures seem unrelated to this PR.

I'm going to merge and release as is and I'm happy to follow up with any changes.


grpc_cli compile error in Mac after v1.16

What version of gRPC and what language are you using?
master
What operating system (Linux, Windows, …) and version?
Mac
where does the bug appear?
I am able to compile the grpc_cli in v1.15.0, but can not in v1.16.0 and v.1.17.0
I guess the bug is introduced in https://github.com/grpc/grpc/commit/3fe2c98877f376cc0c8d7da61d6e63eca83f4bec#r31647692
PS: probably it is doable to create a test to test the compilation in different OS?

@apolcyn, can you please check if this is due to change in ruby generator?

this comment and reply in the ruby generator PR likely explain.
@swuecho can you confirm that you are seeing the issue described in https://github.com/grpc/grpc/commit/3fe2c98877f376cc0c8d7da61d6e63eca83f4bec#r31647692?

I followed the step in https://github.com/grpc/grpc/blob/master/doc/command_line_tool.md
I double check the protobuff submodule, the version is 3.6.1. but the protobuf is not compiled probably, because I installed an old version of protobuf already. anyway, this seems not a real problem. sorry for the trouble.


[cudamapper] segfault when running with multi GPU

Running with multi-GPU on any sizeable dataset (e.g 20k human ONT reads) is resulting in a segfault:
time /home/mike/dev/ClaraGenomicsAnalysis/cmake-build-release/cudamapper/cudamapper /data/20k_reads_shuffled-chrX.fasta /data/20k_reads_shuffled-chrX.fasta -i 30 -w 5 -k 15 -c 30 -F 1e-5 -d 2 > out

NOTE - Since query and target files are same, activating all_to_all mode. Query index size used for both files.
Query /data/20k_reads_shuffled-chrX.fasta index 20000
Target /data/20k_reads_shuffled-chrX.fasta index 20000
Processing query range: (0 - 1116)
Processing query range: (1117 - 2230)
Processing query range: (2231 - 3257)
Processing query range: (3258 - 4370)
Processing query range: (4371 - 5444)
Processing query range: (5445 - 6539)
Processing query range: (6540 - 7597)
Processing query range: (7598 - 8664)
Processing query range: (8665 - 9710)
[2]    5992 segmentation fault (core dumped)  /home/mike/dev/ClaraGenomicsAnalysis/cmake-build-release/cudamapper/cudamappe
/home/mike/dev/ClaraGenomicsAnalysis/cmake-build-release/cudamapper/cudamappe  36.29s user 4.13s system 531% cpu 7.611 total

duplicate of #306

Reopening this issue since it was reported by @vellamike again


Add special case when window is resized to zero

There have been reported crashes with Xilem when minimizing an app with Windows 11 (see also https://github.com/linebender/vello/issues/371).
This fix is based on the solution proposed in:
https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/Windows.2011.20minimizing
I've tested it on Linux just enough to confirm it doesn't crash. Haven't tested in on Windows yet, so I'm not sure it actually fixes the crash on minimize.

This fixes the crash, but after restoring the window from the minimized state no events are processed any more. So clicking on buttons, including the X to close window, doesn't do anything.
09:50:39.763Z  WARN Got window event whilst suspended or before window created event=CursorMoved { device_id: DeviceId(DeviceId(0)), position: PhysicalPosition { x: 674.0, y: 1.0 } }
09:50:39.764Z  WARN Got window event whilst suspended or before window created event=CursorMoved { device_id: DeviceId(DeviceId(0)), position: PhysicalPosition { x: 674.0, y: 0.0 } }
09:50:39.770Z  WARN Got window event whilst suspended or before window created event=CursorLeft { device_id: DeviceId(DeviceId(0)) }
09:50:40.083Z  WARN Got window event whilst suspended or before window created event=CloseRequested
09:50:40.661Z  WARN Got window event whilst suspended or before window created event=CloseRequested


Remove Journald test code

This is no longer use cases. Remove them from the code as a functionality we are not going to test the journald logging in our bucket..
https://github.com/openbmc/openbmc-test-automation/blob/master/extended/test_journal.robot

Code in Review
https://gerrit.openbmc-project.xyz/#/c/7559

Our intention is not to remove only to skip the journal test code. We need to use the same (re-use when new feature introduces in journalctl).

@sivassrr We won't be able to use it since the REST don't log the REST footprint anymore there and top of that this code is using old codes. We don't want to keep something not used. If needed we can always rewrite this piece of code.
@swe12345  please rebase the code and we will remove it. Thanks


Fix sidecar tests testing handling of closed file descriptors

Fix CI after update to rust 1.80.

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (cc8ed56) to head (ce619b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   70.10%   70.14%   +0.03%
==========================================
  Files         214      214
  Lines       28801    28785      -16
==========================================
- Hits        20192    20191       -1
+ Misses       8609     8594      -15

Components
Coverage Δ

crashtracker
21.15% <ø> (-0.06%)
:arrow_down:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
50.00% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
83.07% <ø> (ø)

ddcommon-ffi
70.20% <ø> (ø)

ddtelemetry
58.95% <ø> (ø)

ipc
84.18% <ø> (ø)

profiling
83.57% <ø> (ø)

profiling-ffi
77.42% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
34.55% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.87% <0.00%> (-0.11%)
:arrow_down:

trace-mini-agent
70.88% <ø> (ø)

trace-normalization
98.24% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.16% <ø> (ø)

trace-utils
91.49% <ø> (+0.58%)
:arrow_up:


[Blob Tag] Phase I - Implement SetTag, GetTag on differenet blob APIs

Thanks for contribution! Please go through following checklist before sending PR.
This is a PR for Blob tag Phase I change:
Implement set/get BlobTag on API: GetBlobTag, SetBlobTag, GetBlob, GetBlobProperties, PUTBlob (Block/page/append), ListBlob, PutBlockList, copyFromURL, startCopyFromURL.
https://github.com/Azure/Azurite/issues/1871
https://github.com/Azure/Azurite/issues/1872
PR Branch Destination

For Azurite V3, please send PR to main branch.
For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in Upcoming Release section in ChangeLog.md.
Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

/azp run

/azp run


Kafka and ClickHouse monitoring dashboards via Prometheus

Plus an embedded node_exporter for the host itself.

https://github.com/Altinity/clickhouse-operator/blob/master/grafana-dashboard/Altinity_ClickHouse_Operator_dashboard.json
https://github.com/strimzi/strimzi-kafka-operator/blob/main/examples/metrics/grafana-dashboards/strimzi-kafka.json
https://github.com/strimzi/strimzi-kafka-operator/blob/main/examples/metrics/grafana-dashboards/strimzi-operators.json
https://github.com/strimzi/strimzi-kafka-operator/blob/main/examples/metrics/grafana-dashboards/strimzi-zookeeper.json


Set Ruby 2.7 as minimum version

Ruby 2.5 and 2.6 arrived to its EOL. This PR sets the minimum version to Ruby 2.7.
Also, changes the target version for Rubocop, fixing the following error that appears after this change:

Hey @alejandroperea! First of all thanks for contributing to this gem!! 🎉
While Ruby 2.7 is the latest officially supported version so far, I'm a bit conflicted if we should be forcing gem users to upgrade while there's no need for 2.7 features in the gem yet. Ruby 2.6 has just been EOL-ed a bit less than 3 months ago. It would mean that users of the gem need to update their Ruby version only to keep using this library. While they should do the upgrade asap anyways – if for no other reason than for security – they might have reasons not to upgrade just yet (e.g. incompatibilities with something in their stack, or lacking resources).
On the other hand, at what other point would we be bumping the required ruby version if not after an EOL date has been reached?
One idea would be to keep supporting old versions for one year past their EOL, so we could now set it to 2.6 for now. That would give users one year to upgrade their Ruby version while still being able to get up-to-date versions of this gem.
What do you think?


Update Mono to latest alpha build to fix .NET Core 2.0-preview2 support

Fixes #1495

This change shouldn't require a review


[GOBBLIN-2131]process all dag actions during startup parallely

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-2131

Description

[x] Here are some details about my PR, including screenshots (if applicable):
process all dag actions parallely during initialization

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Already has the test  testStartupSequenceHandlesFailures which covers startup

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.08%. Comparing base (e501b62) to head (0cd490f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4024      +/-   ##
============================================
- Coverage     45.86%   41.08%   -4.79%
+ Complexity     3257     2199    -1058
============================================
  Files           707      480     -227
  Lines         27865    20365    -7500
  Branches       2796     2355     -441
============================================
- Hits          12779     8366    -4413
+ Misses        14008    11105    -2903
+ Partials       1078      894     -184

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

minor comments, lgtm otherwise


@conda-forge-admin, please add user @dchudz

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @dchudz in conda-forge/coiled-feedstock#57.


Themes should not Override Explicit Output Colors

VSCode Version: 1.29.1
OS Version: Windows 10 64bit

It seems that dark themes "hijack" the color of terminal output. While this may be desirable in some situations, in general it's incorrect. When a program wants to display green text in a dark theme (e.g. "Solarized Dark") it displays like this:

With the "PowerShell ISE" Theme the colors are correct:

IMHO a theme should not be affecting such colors. This is a theme overstepping it's reach.
Steps to Reproduce:

Choose a dark theme
Run Write-Host "I should be green" -Foregroundcolor green in a powershell terminal

Yes, I realised that after the fact. I just find it weird that a theme can overwrite yellow say, and make it gray. I'm sure it's nice to be able to make yellow another shade of yellow but it can break stuff. I guess someone decided this is a feature not a bug.

Solarized has a weird palette for the terminal https://ethanschoonover.com/solarized/#the-values


Empty array is formatted anonymously inside a table

0dafa7ee42739311ba6d455a41700febdeb11263
When formatting an empty array inside a table the name of the array is not present in the table which leads to parsing errors when parsing the formatted toml again.
  toml::value val;
  val["empty"] = toml::array{};
  std::cout << toml::format(val) << std::endl;

[]

  toml::value val;
  val["empty"] = toml::array{1};
  //                        ^^^
  std::cout << toml::format(val) << std::endl;

empty = [1]

Thank you very much for the information.
I have reproduced and fixed it. I'm now waiting CI on this branch. After confirming it passes, I will close it.
Thank you again!

Thank you for fixing this issue so fast.
You could catch similar issues that are related to parsing -> formatting -> parsing -> crash in the future, by using fuzzing. This would detect wrong formatting, crashes and misbehaviour through sanitizers quite easy.
oss-fuzz provides a free infrastructure if you are interested: https://github.com/google/oss-fuzz


Flaky envtest test: TestKongSNI

Problem statement
TestKongSNI fails randomly on CI. For some reason, it seems that the deletion operation is not called on the provided sdk object when SNI is deleted:
=== RUN   TestKongSNI
=== PAUSE TestKongSNI
=== CONT  TestKongSNI
    konnect_entities_sni_test.go:32: starting envtest environment for test TestKongSNI...
    konnect_entities_sni_test.go:32: install Kong CRDs from path /Users/patryk.malek<EMAIL_ADDRESS>    konnect_entities_sni_test.go:32: envtest environment (v1.31.0) started at https://<IP_ADDRESS>:52808/
    konnect_entities_sni_test.go:34: Setting up the manager with reconcilers
    konnect_entities_sni_test.go:38: Starting manager for test case TestKongSNI
    konnect_entities_sni_test.go:44: Setting up clients
    konnect_entities_sni_test.go:51: Creating KonnectAPIAuthConfiguration and KonnectGatewayControlPlane
    konnect_entities_sni_test.go:52: deployed new test-56pw8/api-auth-config-xpvxt KonnectAPIAuthConfiguration
    konnect_entities_sni_test.go:53: deployed new test-56pw8/cp-60e25efb KonnectGatewayControlPlane
=== RUN   TestKongSNI/adding,_patching_and_deleting_KongSNI
    konnect_entities_sni_test.go:56: Creating KongCertificate and setting it to Programmed
    konnect_entities_sni_test.go:57: deployed new KongCertificate test-56pw8/cert-npvms
    konnect_entities_sni_test.go:75: Setting up a watch for KongSNI events
    konnect_entities_sni_test.go:78: Setting up SDK for creating SNI
    konnect_entities_sni_test.go:93: deployed KongSNI test-56pw8/sni-281b9e21
    konnect_entities_sni_test.go:100: Waiting for SNI to be programmed and get Konnect ID
    konnect_entities_sni_test.go:108: Set up SDK for SNI update
    konnect_entities_sni_test.go:119: Patching KongSNI
    konnect_entities_sni_test.go:124: Waiting for KongSNI to be updated in the SDK
    konnect_entities_sni_test.go:129: Setting up SDK for deleting SNI
    konnect_entities_sni_test.go:140: Deleting KongSNI
    konnect_entities_sni_test.go:151: Waiting for SNI to be deleted in SDK
=== NAME  TestKongSNI
    konnect_entities_sni_test.go:32: stopping envtest environment for test TestKongSNI
--- PASS: TestKongSNI (8.20s)
    --- PASS: TestKongSNI/adding,_patching_and_deleting_KongSNI (1.79s)
PASS
=== RUN   TestKongSNI
=== PAUSE TestKongSNI
=== CONT  TestKongSNI
    konnect_entities_sni_test.go:32: starting envtest environment for test TestKongSNI...
    konnect_entities_sni_test.go:32: install Kong CRDs from path /Users/patryk.malek<EMAIL_ADDRESS>    konnect_entities_sni_test.go:32: envtest environment (v1.31.0) started at https://<IP_ADDRESS>:53042/
    konnect_entities_sni_test.go:34: Setting up the manager with reconcilers
    konnect_entities_sni_test.go:38: Starting manager for test case TestKongSNI
    konnect_entities_sni_test.go:44: Setting up clients
    konnect_entities_sni_test.go:51: Creating KonnectAPIAuthConfiguration and KonnectGatewayControlPlane
    konnect_entities_sni_test.go:52: deployed new test-5xbgr/api-auth-config-d5pwh KonnectAPIAuthConfiguration
    konnect_entities_sni_test.go:53: deployed new test-5xbgr/cp-f79d875d KonnectGatewayControlPlane
=== RUN   TestKongSNI/adding,_patching_and_deleting_KongSNI
    konnect_entities_sni_test.go:56: Creating KongCertificate and setting it to Programmed
    konnect_entities_sni_test.go:57: deployed new KongCertificate test-5xbgr/cert-zt898
    konnect_entities_sni_test.go:75: Setting up a watch for KongSNI events
    konnect_entities_sni_test.go:78: Setting up SDK for creating SNI
    konnect_entities_sni_test.go:93: deployed KongSNI test-5xbgr/sni-080f2360
    konnect_entities_sni_test.go:100: Waiting for SNI to be programmed and get Konnect ID
    konnect_entities_sni_test.go:108: Set up SDK for SNI update
    konnect_entities_sni_test.go:119: Patching KongSNI
    konnect_entities_sni_test.go:124: Waiting for KongSNI to be updated in the SDK
    konnect_entities_sni_test.go:129: Setting up SDK for deleting SNI
    konnect_entities_sni_test.go:140: Deleting KongSNI
    konnect_entities_sni_test.go:151: Waiting for SNI to be deleted in SDK
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.
                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/test/envtest/konnect_entities_sni_test.go:153 go/src/runtime/asm_arm64.s:1223]
    konnect_entities_sni_test.go:153: FAIL:     DeleteSniWithCertificate(string,operations.DeleteSniWithCertificateRequest)
                        at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:146 gateway-operator/test/envtest/konnect_entities_sni_test.go:131]
    konnect_entities_sni_test.go:153: FAIL: 2 out of 3 expectation(s) were met.

                The code you are testing needs to make 1 more call(s).
                at: [gateway-operator/controller/konnect/ops/kongsni_mock.go:256 go/src/testing/testing.go:1176 go/src/testing/testing.go:1354 go/src/testing/testing.go:1684]
    konnect_entities_sni_test.go:32: stopping envtest environment for test TestKongSNI
--- FAIL: TestKongSNI (17.01s)
    --- FAIL: TestKongSNI/adding,_patching_and_deleting_KongSNI (11.30s)
FAIL

BuildPulse link: https://app.buildpulse.io/@Kong/gateway-operator/tests/24827529252?filter_results_type=flaky

No more flakes detected for the past 17 days: https://app.buildpulse.io/@Kong/gateway-operator/tests/24827529252?filter_results_type=flaky&source=flaky


Derive events with member attributes

This change is

Current dependencies on/for this PR:

main

PR #2873

PR #2874

PR #2876   👈

This comment was auto-generated by Graphite.


chore: move devDependencies to @krakenjs scope

Codecov Report

Merging #107 (00dc9ea) into main (16ad589) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   73.51%   73.51%
=======================================
  Files          26       26
  Lines         944      944
=======================================
  Hits          694      694
  Misses        250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ad589...00dc9ea. Read the comment docs.


Master

SPS12 update - replacieng connect webide with github project creation

Redoing the pull request to delete an extra file


Update annotations appropriately when DataSource props changes

Purpose
As a pennant library user I expect the chart to update appropriately when the DateSource prop changes.
Proposal
Not clear. Will need to explore options. Let's spend an hour coming up with solutions.
Acceptance criteria

[ ] As a pennant library user I expect to see no positions/orders if the DataSource no longer will return any positions/orders, i.e. I've logged out of my wallet in console

This is implemented but requires testing from within Console


Update bridge so that it waits for the foreign chain to be fully synced

Update bridge so that it waits for the foreign chain to be fully synced before starting transfers.
It seems that when a light node is not fully synced, requests are not properly handled.
I could not find a good way to reduce redundancy in between wait_for_chain_synced_until_block and wait_for_chain_fully_synced_past_block without having one function that does two different things with a flag, since most of it is logging infos.
closes: https://github.com/trustlines-protocol/blockchain/issues/452

Codecov Report

Merging #459 into master will decrease coverage by 0.37%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   92.13%   91.76%   -0.38%
==========================================
  Files          16       16
  Lines         865      886      +21
==========================================
+ Hits          797      813      +16
- Misses         68       73       +5

Flag
Coverage Δ

#bridge_end2end
85.44% <79.16%> (-0.23%)
:arrow_down:

#bridge_unit
74.26% <8.33%> (-1.69%)
:arrow_down:

Impacted Files
Coverage Δ

tools/bridge/bridge/main.py
83.53% <79.16%> (-0.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a3f2d...1ad16cd. Read the comment docs.

It seems that when a light node is not fully synced, requests are not properly handled.

If we can detect this error, I think we should just retry the request. We just want to check that the contract exists at that address, not that the chain is synced. I consider the current behaviour a bug in parity, if they fix it, we don't have to wait for the chain to be synced.

It looks like commit 1b009a7 tries to fix an unrelated issue (#473). As already noted there, I expect it to be fixed in another way. Please remove it from this PR.
Can we distinguish the error we see in #452 from the error we would get from an address with no code deployed?  If yes, we should retry the request instead of waiting for the chain to be fully synced.

Maybe I should explain one of the reasons I try to avoid this change  a bit more. Waiting for any of the nodes to be fullly synced once when starting may hide some bugs or make them harder to detect. The nodes may switch their state to syncing anytime and we need to be able to handle those cases.
Without waiting for a fully synced node, it's rather easy to test the bridge for the case where the node is syncing.

superseded by #487

I could not find a good way to reduce redundancy in between wait_for_chain_synced_until_block and wait_for_chain_fully_synced_past_block without having one function that does two different things with a flag, since most of it is logging infos.

I think you should take a look at what I did in PR #487. You have to decompose things first to arrive at an elegant solution.
I've got a function that gets the status from the node and have a function that waits for a certain status to be reached, where the function that decides that the status we want is reached is passed in as a predicate function.
This is then used like in the following code:
https://github.com/trustlines-protocol/blockchain/blob/bce249fac2ee7ca5b33c460fc00b0d09ad8c6f30/tools/bridge/bridge/main.py#L409-L423

I could not find a good way to reduce redundancy in between wait_for_chain_synced_until_block and wait_for_chain_fully_synced_past_block without having one function that does two different things with a flag, since most of it is logging infos.

I think you should take a look at what I did in PR #487. You have to decompose things first to arrive at an elegant solution.
I've got a function that gets the status from the node and have a function that waits for a certain status to be reached, where the function that decides that the status we want is reached is passed in as a predicate function.
This is then used like in the following code:
https://github.com/trustlines-protocol/blockchain/blob/bce249fac2ee7ca5b33c460fc00b0d09ad8c6f30/tools/bridge/bridge/main.py#L409-L423

I think this mainly reduces redundancy because we no longer do two different things for the two nodes (wait for fully synced chain / wait for partially synced chain). But sure, your solution is more elegant and easier to adapt. Thanks for pointing it out.


Add New Phones

Phones
Apple

iPhone 12 Pro Max
iPhone 12 Pro
iPhone 12
iPhone 12 mini

Samsung

Z Filp
Fold
Fold 2
Galaxy S20 FE
Galaxy S21
Galaxy S21+
Galaxy Note20
Galaxy Note20 Ultra

Colors
28 New Color

Thx for the PR.
I will review it soon

@UniqueDevStorm Could you commit my suggestion? I could merge it right now.

Looks like Note 20 5G and zFlip 5G is missing image 😢

The name has been changed, but the image value seems to have not changed.

Could you double-check it? Looks like it's not fixed yet.

https://phonepare-1.vercel.app
I'm done fixing it.

Thanks for your contribution

Thanks for your contribution

I will update you when another smartphone comes out next time.


git-tfs should be able to clone Team Projects

So, when I go into Visual Studio, I connect to Team Projects.  Then, in my source control view, I see a set of folders (which looks like the root of a repo) for each Team Project.
Is there a technical reason why git-tfs can't just clone a repo based on Team Project rather than having to have a branch?

Is there a technical reason why git-tfs can't just clone a repo based on Team Project rather than having to have a branch?

Yes. Some very good!
The way Git and TFVC works is totally different and when you create a bridge as git-tfs, you should make decision and introduce a bias to match the 2.
You could, if you want clone with git-tfs the team project and you will have all in the git repository but you will loose the branch support because with tfs you could create folders where you want, and branches with no relationship everywhere,... and do really messy things.
With git-tfs, what we want is having branch support, to be able to compare them, switch easily, share commits,... and to to that you HAVE TO clone from the root branch.
And just doing that is REALLY hard to do because branch support is such a messy sheet!!! And is still not perfect after more than 3 years of development I do on my free time (I am even tired of it!). That's also perhaps why Microsoft didn't even try to support it with their official git-tftool (perhaps not even want to think about it more than an instant)!
But if you want to improve thing, feel free to contribute and not just say what git-tfs should do.... (here is the moment where every one run away! Truth is that in 3 years, no one contribute substantially a feature except small bug fix. You will learn how the tfs API is very bad, how tfs don't store fundamental data and you are not able to get it to do a good branch support,...).
To conclude, just the fact that tfs permit to have more than one root branch, is not easy to handle with a git repository.
But I'm waiting that someone add the possibility to clone another branch in an already existing "git-tfs repository"... Feel free to do it, and we will be near the "clone team project" support you ask for!!

I understand it might be extremely difficult to support cloning Team Projects for a two way sync scenario. However, there is a slightly different use case that your tool is positioned for and that is to migrate from TFS to git. If the only goal was to extract the full team project source and history one time and accept the loss of internal branches and the ability to push back commits, I suspect the changes would be much easier to implement. At our company, we have several hundred team projects in TFS that we'd like to archive as git repositories. If you can provide some pointers on where to look, I'd be happy to take a shot at implementing them.

I figured out how to run in debug mode and discovered the code already supports what I need. The problem I was encountering was team projects that were deleted and then recreated.  As soon as clone operation encountered the project delete, it stopped cloning. As long as I can locate the changeset that recreated the team project and start the cloning from there, I'm all good.
And for those who want to run in debugger, set project GitTfs as the start project and under Start Options, set the command line arguments you want to use to the git tfs command, but leave off "git tfs".

I understand it might be extremely difficult to support cloning Team Projects for a two way sync scenario. However, there is a slightly different use case that your tool is positioned for and that is to migrate from TFS to git. If the only goal was to extract the full team project source and history one time and accept the loss of internal branches and the ability to push back commits, I suspect the changes would be much easier to implement.

If your main goal is archival, git-tfs should be able to do what you want. An alternative would be to write a front-end for git-fast-import, which you could do whatever you want with. There are a couple of projects that do something like this (tfs-fast-export, tfsdb-fast-export are the ones that I found). If I were to start from scratch on this, I would be inclined to dump the TFS project straight to a single Git branch, and capture the branch metadata (e.g. with QueryBranchObjects) too. With the single branch plus the metadata, you could use filter-branch or bfg (or a libgit2sharp-based program) to apply the branch metadata to build the analogous Git branches.

We are trying to clean up old/stale issues. As this hasn't seen any updates (or pull requests implementing it), can this issue be closed, please? We can reopen it in case further information is provided.

As far as I'm concerned, this can be closed.  Per my previous post...from 2016...we discovered how to use the tool to do what we needed.  But the original issue wasn't mine.