Investigate SameSite Cookie Support

SameSite Cookies are gaining some traction recently, now having support in Chrome and Opera. Lift isn't particularly prone to CSRF by its design anyhow, but setting the SameSite attribute would probably be an additional barrier to CSRF / XSS in the event the developer wanted to set a cookie that was not HTTPOnly.
Related ML thread: https://groups.google.com/d/msg/liftweb/bKFoFctcY8k/KuJKGZX_CwAJ

As discussed on the ML, there's no sensible route to implement this from Lift's POV until the servlet API adds the functionality. We'll keep an eye on the servlet spec and make an addition to our API once they do what they need to do on their end.

As a reference, here a PR for Servlet API to have support for SameSite cookies -> https://github.com/eclipse-ee4j/servlet-api/pull/271
With that, I think Lift can add SameSite cookies support too.
Since that will take time, here a workaround in the meantime -> https://dev.to/csaltos/lift-webframework-samesite-cookie-workaround-nl0


bug: Passing styleComponents props is not working for CoreTabHead.

Description
NativeTabHead not supporting incoming styleClasses via props. This is making users not being able to style CoreTabHead using styleComponents.

Closing as done.


HIVE-24606: Multi-stage materialized CTEs can lose intermediate data

What changes were proposed in this pull request?
Build correct dependencies among CTEs in order to prevent wrong results.
Why are the changes needed?
A Hive query with hive.optimize.cte.materialize.threshold can return wrong results when it has complex CTEs.
The issue can happen when multistage CTEs have dependencies and SemanticAnalyzer fails to link their tasks.
https://issues.apache.org/jira/browse/HIVE-24606
Does this PR introduce any user-facing change?
Incorrect results will be correct results.
How was this patch tested?
This PR adds three test cases. All fail when we use the latest revision(7bfc54ffc8baf5f3e7de326b750fe9355b11132b).

@kasakrisz @zabetak Could you pls check this PR?

Thanks!


[RFC] Renaming Joy APIs

This RFC list several points related to renaming Joy UI APIs so that we can discussed before making the changes.

Rename color prop to palette:

The color prop creates confusion around the palette & CSS color property as indicated in

https://github.com/mui/material-ui/issues/29564.
https://github.com/mui/material-ui/issues/29564#issuecomment-1088626841.
https://github.com/mui/material-ui/issues/32270#issuecomment-1098173875
https://github.com/mui/material-ui/issues/32274

The Link component needs to support both palette and color props (using color prop alone would make the logic very complicated and code suggestion would not work because the color type is a string)
In Joy, most components have variant prop which most of the time needs palette to work, so the palette prop sounds like the best option.

- <Button palette="primary">
+ <Button palette="primary">

- <Link color="primary">
+ <Link palette="primary">

Rename variant values: The reason to rename the values is to set apart from these existing names (CSS properties, color modes) and make them meaningful as much as possible.

text to plain (as discussed in https://github.com/mui/material-ui/pull/31090#issuecomment-1046610235)
outlined to frame | shell | pod | crust. (we haven't discussed about this yet but using outlined is too close to the CSS outline property)
light to soft (as discussed in https://github.com/mui/material-ui/pull/31090#issuecomment-1046610235)
contained to solid (as discussed in https://github.com/mui/material-ui/pull/31090#issuecomment-1046610235)

These are other names that we can consider.

bordered (but it is too close to CSS property border)
ghost (similar to Chakra UI)
filled, subtle (from Mantine)

Rename primary palette to brand: continue from https://github.com/mui/material-ui/pull/31090#issuecomment-1047435912 to gather more thoughts.

@siriwatknp https://github.com/mui/material-ui/pull/31090#issuecomment-1047435912
@mnajdova https://github.com/mui/material-ui/pull/31090#issuecomment-1047830978
@danilo-leal https://github.com/mui/material-ui/pull/31090#issuecomment-1047726842

Add/Remove typography scale: After doing POC with several apps, it becomes clear that the current h1 and h2 are too big and I have never used h5, h6 (as an HTML tag). I have to always do this <Typography level="h2" fontSize="lg" />. It makes more sense to have display1, 2 for the headline like in MUI branding.

add display1 and display2
remove h5 and h6

From tailwind CSS https://play.tailwindcss.com/uj1vGACRJA?layout=preview
We haven't used an h4 yet
But now we have. Please don't use h5 or h6 in your content, Medium only supports two heading levels for a reason, you animals. I honestly considered using a before pseudo-element to scream at you if you use an h5 or h6.

We don't style them at all out of the box because h4 elements are already so small that they are the same size as the body copy. What are we supposed to do with an h5, make it smaller than the body copy? No thanks.

Rename level prop on the typography component to scale for consistency with the system: level was initially added in Joy to replace the variant (because Joy's variant is different). Some discussion is in https://www.notion.so/mui-org/MUI-System-890bb3d81cbf45008fd5d2f90f53539d#5de65bde31ec4a84931cd62081d27e04

If you think other APIs need to be renamed, feel free to add it to the list. Not every bullets have to be decided in this RFC, we can start working on the first batch and revisit the rest later.

Thanks for writing this up, Jun! Here's my perspective:

All good with me! Agree that using palette avoids confusion as you can be using several different shades for different states and only "color" might not put this across as clearly as it could.
About variant values:

👍 for solid, instead of contained.
👍 for soft instead of light.
Really don't think that using outlined would overlap with outline from CSS, even though it would be good to respect the proposed heuristic. I think that this is a case where relying on the most common is ok, outlined sounds fine to me! These other options just don't come intuitively I guess.
👍 for ghost instead of text (there are a few more options for this one we could consider, i.e flat, invisible, minimal—I lean towards more to ghost or plain)

I believe both would work. You can argue that your primary color is most often (if not always) your main brand color, so there you go. Regardless, I think it's a matter of how much using convention is effective. Primary seems to be way more common than brand. Would using brand then impact negatively any dev and/or designer using Joy? I'd bet that no.
I agree! But I'd do this one separately from the other renaming tasks. It's an opportunity to revisit the 1st typographic scale we came up with and would love to do that now that we're maturing things a bit more.
All good for me! Scale indeed sounds better when talking about typography.

A good candidate for Material UI too.

too close to the CSS outline property

When was the last time you used this CSS property? I almost forgot it existed 😁

https://www.w3.org/TR/2011/WD-html5-author-20110809/the-h1-h2-h3-h4-h5-and-h6-elements.html uses "rank" to compare h1 to h2, h3, etc. https://m3.material.io/styles/typography/tokens uses "scale"

When was the last time you used this CSS property? I almost forgot it existed 😁

Joy use outline as a default for focus visible because you can use CSS outlineOffset to control the inward/outward of the outline and it does not overlap with CSS border/box-shadow that people usually customize.

I'd say that using outlined, in the past tense, is enough to avoid confusion with CSS's outline. It's widely used and following convention here seems like a safe thing to do.

My proposal would be renaming the CSS prop we use on the components from color to textColor. This way people won't confus this with the color prop that exists on other components (or on the same component as in the case of the Link component)

Interesting choice! I listed the efforts to help us decide.
1. Add textColor prop (NOT a breaking change ☺)

Update extendSxProp to convert textColor prop
Add textColor prop to Typography, Grid, Stack
Fix the Link to use textColor prop
Clarify the meaning of color & textColor prop in the docs

2. Renaming to palette prop (BREAKING CHANGE)

Rename every component (tests, classes, types, implementation) from color to palette
Create a codemod (prop, className)
Clarify the meaning of palette prop in the docs

For me, I'll vote for @mnajdova option because it is not a breaking change and require a lot smaller effort. We have to write a doc to clarify the meaning of the prop regardless of the choice.

Sweet! Let's go for textColor then, it indeed seems like a better alternative!


Add BGQC file format

For the schema validation issue I have just created an issue.
See https://github.com/SAP/abap-file-formats-tools/issues/227

@ellima Would you sign the CLA (contributor license agreement), please?


Crashes when tapping on Villagers tab

Not sure what more info to provide, or if this is even how you prefer this feedback, but I'm on an iPhone 11 Pro. Install app -> tap each tab until I get to Villagers -> crash.

Can confirm this is reproducible.
It appears that UserCollection’s existence can cause a race condition.
A proposed fix would be to drill down and use a singleton.

Or we could try to force passe it as .environmentObject to every tab.

@Dimillian that is what I said :P but instead a singleton (shared) so that init happens once on launch. Drill down = per tab.

Problem should be solved a few commits ago.


[$250] Migrate WalletStatementPage.js to function component

Class Component Migration
Filenames

[ ] src/pages/wallet/WalletStatementPage.js

type: React.Component
has state values: false
has refs: false
has context: false
lifecycle methods: componentDidMount

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01120a3696c71dc1f1
Upwork Job ID:<PHONE_NUMBER>251645952
Last Price Increase: 2023-06-30

⚠ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

I'd like to work on this issue when it goes to external

I'd love to work on this.

Taking this one off HOLD.

I am eager to take on this task.

I would like to work on this issue.

Proposal:
I  can work on this ticket

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01f833200bffc3ebe5

@Santhosh-Sellavel who should we hire here? Thanks

Hi! I would like to apply for this ticket!

@MitchExpensify
Let's go with @s-alves10 here. Another contributor with earlier interest has open migration issue.
C+ Reviewed
🎀 👀 🎀

Invites sent to @Santhosh-Sellavel & @s-alves10 for eventual payment

@MitchExpensify Can you also assign @s-alves10 here

I think @PauloGasparSv has to do that piece 👍

I think @PauloGasparSv has to do that piece 👍

Thks for the ping, missed this :D

Let's go with @s-alves10 https://github.com/Expensify/App/issues/16303#issuecomment-1578349954. Another contributor with earlier https://github.com/Expensify/App/issues/16303#issuecomment-1577949548 has open migration issue.

Nice, thks @Santhosh-Sellavel sure thing! Assigning them here

PR will be ready in a day

@Santhosh-Sellavel
May I ask you a question? How can I test the component. It looks like it isn't used in the app
https://expensify.slack.com/archives/C01GTK53T8Q/p1688414202987419

@Santhosh-Sellavel
PR is ready for review. But I wasn't able to upload any screenshots.
Can you take a look at the PR?

Bump @Santhosh-Sellavel 👍

I'm sorry but I wasn't able to accept the offer.

Bump @Santhosh-Sellavel 👍

Hey @MitchExpensify the review is blocked because of me now I think.
Since this change is related to the Wallet @Santhosh-Sellavel and @s-alves10 can't really test this, I'm trying to figure out how they can test it though (I think it's related to enabling the wallet beta, trying to do this on my local dev environment first).
I only stopped to focus on this now but @s-alves10 also tried reaching out in the Cplus channel for an account that can test this but didn't get help there.
Will give an update here and reach out to the team if I can't find out how to test this.

Sounds good, thanks @PauloGasparSv !

Hey @MitchExpensify can you please re-assign this to another engineer?
I'm OOO from now till next week (tried to review this before going OOO but couldn't, sorry for that).
To whoever takes this on and isn't sure on how to set up a wallet, please refer to this S.O. https://stackoverflowteams.com/c/expensify/questions/10083 and can you please help with this comment?

Not overdue - PR hit staging so payment 7 days after it hit production assuming no regressions is our next step

This migration took long because it's hard to test. Please check the review history of the PR.
Thanks

This migration took long because it's hard to test. Please check the review history of the PR.

Yes I noticed that in the PR but I'm not sure we can take that into account for bonuses. For example we do not consistently factor in review delays because it is too time consuming. That said, if @AndrewGable agrees the difficulty testing should be factored in I'm happy to ignore the 50% late merge penalty!

There was also some internal OOO that added to this, no need to add the penalty.

Ok cool! Thanks @AndrewGable & @s-alves10  - I've edited the payment summary accordingly

Paid! Thanks everyone


Added support for ThemeResources

Description of the changes:

Updated to latest version of Uno.UI support theme resources
Added a new Pink custom theme

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: carldebilly:x: MaximeDionNventiveComYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: carldebilly:x: MaximeDionNventiveComYou have signed the CLA already but the status is still pending? Let us recheck it.


Error on rake task (it looks like the cargo bundle builds fine)

I've already started here: https://github.com/NullVoxPopuli/case_transform/pull/2/files

I guess, it would be a rust package, and not a gem :-)

https://crates.io/search?q=helix shows 0 results :-(

Found out I can point to github, so that's handy: https://github.com/NullVoxPopuli/case_transform/blob/helix-rust-speed-boost/Cargo.toml#L12

it looks like it's the helix_runtime that needs to be released as a gem :-)

now it looks like I'm getting a similar error as I do when I try to run the fast_blank example:
now it looks like I'm getting a similar error as I do when I try to run the fast_blank example:
the error I get with turbo_blank:
$ rake
cargo build --release
gcc -Wl,-force_load,target/release/libturbo_blank.a --shared -Wl,-undefined,dynamic_lookup -o lib/turbo_blank/native.bundle
/home/me/OpenSource/helix/ruby/lib/helix_runtime.rb:2:in `require': cannot load such file -- helix_runtime/native (LoadError)
	from /home/me/OpenSource/helix/ruby/lib/helix_runtime.rb:2:in `<top (required)>'
	from /home/me/OpenSource/helix/examples/turbo_blank/lib/turbo_blank.rb:1:in `require'
	from /home/me/OpenSource/helix/examples/turbo_blank/lib/turbo_blank.rb:1:in `<top (required)>'
	from /home/me/OpenSource/helix/examples/turbo_blank/test/test_helper.rb:2:in `require'
	from /home/me/OpenSource/helix/examples/turbo_blank/test/test_helper.rb:2:in `<top (required)>'
	from /home/me/OpenSource/helix/examples/turbo_blank/test/turbo_blank_test.rb:1:in `require'
	from /home/me/OpenSource/helix/examples/turbo_blank/test/turbo_blank_test.rb:1:in `<top (required)>'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `require'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:15:in `block in <main>'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `select'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -I"lib:test:lib" -I"/home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib" "/home/me/.rvm/gems/ruby-2.3.0/gems/rake-10.5.0/lib/rake/rake_test_loader.rb" "test/turbo_blank_test.rb" ]
/home/me/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval'
/home/me/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

my error:
$ rake
cargo build --release
gcc -Wl,-force_load,target/release/libcase_transform.a --shared -Wl,-undefined,dynamic_lookup -o lib/case_transform/native.bundle
gcc -Wl,-force_load,target/release/libcase_transform.a --shared -Wl,-undefined,dynamic_lookup -o lib/case_transform/native.bundle
/home/me/Development/case_transform/lib/case_transform.rb:8:in `require': cannot load such file -- case_transform/native (LoadError)
	from /home/me/Development/case_transform/lib/case_transform.rb:8:in `<top (required)>'
	from /home/me/Development/case_transform/test/test_helper.rb:9:in `require'
	from /home/me/Development/case_transform/test/test_helper.rb:9:in `<top (required)>'
	from /home/me/Development/case_transform/test/transforms/camel_lower_test.rb:3:in `require'
	from /home/me/Development/case_transform/test/transforms/camel_lower_test.rb:2:in `<top (required)>'
	from /home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:15:in `require'
	from /home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:15:in `block in <main>'
	from /home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:4:in `select'
	from /home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test:lib" -I"/home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib" "/home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/lib/rake/rake_test_loader.rb" "test/transforms/camel_lower_test.rb" "test/transforms/camel_test.rb" "test/transforms/dash_test.rb" "test/transforms/underscore_test.rb" ]
/home/me/.rvm/gems/ruby-2.3.1/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
/home/me/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'
/home/me/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

Answered on reddit as well. I had problems with an old version of rust. Try nightly from 9-17-2016 or stable.

this is what I had previously:
cargo --version
cargo 0.12.0-nightly (6b98d1f 2016-07-04)

rustc --version
rustc 1.11.0 (9b21dcd6a 2016-08-15)

So old!
I also learned that I need to install rustup.rs to manage rust versions.
I ran rustup install nightly and rustup default nightly which gives version
1.13.0-nightly 2016-09-17 (the one you recommend)
After running rake again, I still get the same error. :-(
I must me missing something in my environment.

here is my full stack trace:
$ rake
cargo build --release
   Compiling winapi-build v0.1.1
   Compiling regex-syntax v0.3.5
   Compiling libc v0.2.16
   Compiling lazy_static v0.2.1
   Compiling utf8-ranges v0.1.3
   Compiling kernel32-sys v0.2.2
   Compiling cslice v0.1.1 (https://github.com/rustbridge/neon#520d8abe)
   Compiling winapi v0.2.8
   Compiling memchr v0.1.11
   Compiling libcruby-sys v0.1.0 (https://github.com/rustbridge/helix#2c057f04)
   Compiling helix v0.1.0 (https://github.com/rustbridge/helix#2c057f04)
   Compiling aho-corasick v0.5.3
   Compiling thread-id v2.0.0
   Compiling thread_local v0.2.7
   Compiling regex v0.1.77
   Compiling Inflector v0.3.1
   Compiling case_transform v0.1.0 (file:///home/me/Development/case_transform)
warning: use of extern static requires unsafe function or block (error E0133), #[warn(safe_extern_statics)] on by default
  --> src/lib.rs:15:1
   |
15 | declare_types! {
   | ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue 36247 <https://github.com/rust-lang/rust/issues/35112>
   = note: this error originates in a macro from the standard library

warning: use of extern static requires unsafe function or block (error E0133), #[warn(safe_extern_statics)] on by default
  --> src/lib.rs:15:1
   |
15 | declare_types! {
   | ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue 36247 <https://github.com/rust-lang/rust/issues/35112>
   = note: this error originates in a macro from the standard library

warning: use of extern static requires unsafe function or block (error E0133), #[warn(safe_extern_statics)] on by default
  --> src/lib.rs:15:1
   |
15 | declare_types! {
   | ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue 36247 <https://github.com/rust-lang/rust/issues/35112>
   = note: this error originates in a macro from the standard library

warning: use of extern static requires unsafe function or block (error E0133), #[warn(safe_extern_statics)] on by default
  --> src/lib.rs:15:1
   |
15 | declare_types! {
   | ^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue 36247 <https://github.com/rust-lang/rust/issues/35112>
   = note: this error originates in a macro from the standard library

note: link against the following native artifacts when linking against this static library

note: the order and any duplication can be significant on some platforms, and so may need to be preserved

note: library: util

note: library: dl

note: library: pthread

note: library: gcc_s

note: library: c

note: library: m

note: library: rt

note: library: util

    Finished release [optimized] target(s) in 45.65 secs
gcc -Wl,-force_load,target/release/libcase_transform.a --shared -Wl,-undefined,dynamic_lookup -o lib/case_transform/native.bundle
gcc -Wl,-force_load,target/release/libcase_transform.a --shared -Wl,-undefined,dynamic_lookup -o lib/case_transform/native.bundle
/home/me/Development/case_transform/lib/case_transform.rb:8:in `require': cannot load such file -- case_transform/native (LoadError)
	from /home/me/Development/case_transform/lib/case_transform.rb:8:in `<top (required)>'
	from /home/me/Development/case_transform/test/test_helper.rb:9:in `require'
	from /home/me/Development/case_transform/test/test_helper.rb:9:in `<top (required)>'
	from /home/me/Development/case_transform/test/transforms/camel_lower_test.rb:2:in `require'
	from /home/me/Development/case_transform/test/transforms/camel_lower_test.rb:2:in `<top (required)>'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:15:in `require'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:15:in `block in <main>'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:4:in `select'
	from /home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test:lib" -I"/home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib" "/home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/lib/rake/rake_test_loader.rb" "test/transforms/camel_lower_test.rb" "test/transforms/camel_test.rb" "test/transforms/dash_test.rb" "test/transforms/underscore_test.rb" ]
/home/me/.rvm/gems/ruby-2.3.0/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
/home/me/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval'
/home/me/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)

oh wait! I missed a step!

I'm still getting errors with helix_runtime. But now it at least says helix_runtime's extensions are not built... so that's progress

my problem right now is that step 3 of the example in the readme says that it could not find a valid gem. :-\
So, I went into the gem directory and gem build helix_runtime.gemspec
it still isn't a valid gem apparently

(because there is no pkg directory).
Maybe the readme needs to be updated? I changed step 3 to be:  bundle exec gem install ../../ruby/helix_runtime-0.5.0.gem and it installed

the rake commands still give the error that extensions for helix_runtime are not built.

Installing the helix_runtime gem:
``
$ gem install helix_runtime-0.5.0.gem
Building native extensions.  This could take a while...
Successfully installed helix_runtime-0.5.0
Parsing documentation for helix_runtime-0.5.0
Done installing documentation for helix_runtime after 0 seconds
1 gem installed

no errors. :-\

@sbeckeriv how exactly did you get this working?

For fast blank I had to edit the gemspec but you found that post. I followed the readme with rust stable. I did also setup ruby per the ruru library instructions. I didn't think helix needed that but that could be the difference? Near the bottom https://github.com/d-unseductable/ruru/blob/master/README.md
I will post more of an output environment text blob when I can.

I hadn't heard of ruru. Is that an alternative to Helix? or does it work with Helix?

the readme is missing the build step for the gem I think.
My commands for your project from a mostly clean build:
https://gist.github.com/sbeckeriv/3671475129d11fef25af17a270150d6f
ruru and helix are like friends who have similar jobs and hang out at the same bar but don't really talk to each other.
I am not associated with either project. I am just excited for both of them.

interesting. thanks for going through all that, I really appreciate it!
So, since getting a helix project working looks like it requires the helix repo, rather than a cargo package and rubygem, do you think it would be better to use ruru until helix is ready?  It looks like Helix has slightly better apis? (maybe?) but ruru for sure looks more progressed.

I think its always good to check out all options. I have only done some pet projects in both.

have you released any gems in either?

No. The owner of https://github.com/malept/thermite gave a good presentation at the seattle rust meetup about creating gems for his company to use and he plans to open source. sorry. I think you can close this issue now?

yeah. thanks!


show which sense an image belongs to

if an entry has multiple senses, it is often not clear which sense a picture illustrates, since the data structure is of such nature that pictures are linked to senses (not lemmas), maybe the web app could reflect this is some way?

Feel free to propose one such way.

since it is rather impractical to display the images below a sense's meaning description, maybe the meaning description should also be displayed below the relevant picture? this,i on the other hand, isalso impractical for long meaning descriptions, so maybe below each picture we can find the info "sense 2", "sense 3" or something of that sort?


JDL Comments not working + Parser could signal line number where it failed

Entering comments as follow wouldn't work:
`/**

Entity: MyEntityName
Created on: dd/mm/yy
*/

Additionally, it would be nice for the Parser to let us know where it failed (line number in the JDL file)

Indeed, this would be a nice feature! I'll try to add it for v1.6.2.
As for the bug, I'll confirm it tomorrow, and fix it (and finally release).

I've just created a separate issue for your request: #135.

This is fixed, I'll release everything that has been done before the end of the week.
Thanks for reporting this!


Infinity 12

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

### Tasks

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


sub 1 accuracy?

hi folks, we've download the kitti database and set up training according to the rules, the machine we have has a Titan X pascal and training takes about 2hr55minutes each time, but as you can see graphs are weird. whats the problem?

also there are overlapping bounding boxes, many of them.

Hi @WERAQS, apart from the small drop around epoch 8, which is not unusual, your learning curves look OK, with precision and recall both above 78% (remember that you need to use the left axis to read precision, recall and mAP). Here, mAP is the product of precision and accuracy, which is not an accurate representation of "mean Average Precision", as stated on https://github.com/NVIDIA/caffe/issues/234.
You might want to tune your clustering parameters to remove the duplicate bounding boxes. Have a look at the clustering layer doc string and in particular check the parameters of cv.groupRectangles (from OpenCV) are fine for your test images.


Add node tests for notifications

Cover exports.receives_desktop_notifications and exports.receives_audible_notifications.

This LGTM! Approving and gonna ping @showell for the final review.

Merged!  Thanks @thejwzhang and @lonerz!


INACTIVE, but active?

http://prntscr.com/q0yowz ?

I'm willing to check what's behind that but please use a proper tool when you report something. That website don't provide accurate result...
$ curl -v -A " Mozill/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36" http://000gpzz.wcomhost.com
*   Trying <IP_ADDRESS>:80...
* TCP_NODELAY set
* Connected to 000gpzz.wcomhost.com (<IP_ADDRESS>) port 80 (#0)
> GET / HTTP/1.1
> Host: 000gpzz.wcomhost.com
> User-Agent:  Mozill/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Date: Sat, 23 Nov 2019 12:24:52 GMT
< Server: Apache
< Content-Length: 272
< Content-Type: text/html; charset=UTF-8
<

<meta name="robots" content="noarchive" />
<meta name="googlebot" content="nosnippet" />

Error. Page cannot be displayed. Please contact your service provider for more details.  (21)

* Connection #0 to host 000gpzz.wcomhost.com left intact

Thanks for your time!
Cheers,
Nissar

So, thanks for your report. It should be fixed in the next version of PyFunceble-dev. (Will be automatically released in the coming 30-40 minutes). Do you want me to clean the repo and restart as soon as the new version is available?

Sure. Thanks :)


Strongly typed IMAP responses

Right now the responses are a Vec of Strings. It'd be nice if each response was it's own type/enum variant, i.e. ListResponse for the LIST command.

@gsingh93 ok.


Uncaught ReferenceError: Q is not defined

line 1886: glob.LargeLocalStorage = definition.call(glob, Q);
browser: Chrome Version 46.0.2490.86 (64-bit)

I'm Having the same problem. Q i not defined. Couldn't use LargeLocalStorage. This repository hasn't been updated for more than 5 years. I think this is not a standard way to utilize the storage system.


storage: bad object names (and other values) return confusing errors

For example, an empty object name fails Writer.Close with googleapi: Error 400: Required, required.
An object name containing a new line fails with googleapi: Error 400: Invalid Value, invalid
These errors are really confusing and do not point to which part of the request was malformed.
Found while fixing #111

Is this a problem with the underlying service or with our client? If the former, we should file a bug against GCS.

Our client: we're not doing a good job of converting the error from google.golang.org/api into something more digestible.

As of this writing, a newline in an object name fails with Error 400: Disallowed unicode characters present in object name, which seems adequate.
A missing object name still fails with the original error, but GCS returns no additional information.
In both cases, we capture all the information we can, so this is not a client issue.


Add action to build phar

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (8cb02cf) to head (286bbd7).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##                main      #273   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       720       720
===========================================
  Files             64        64
  Lines           2234      2234
===========================================
  Hits            2234      2234

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


set mode verify:always no longer works

Reported by Jonathan S Callahan on 14 Mar 2003 20:32 UTC
custom$ $FER_DIR/bin/ferret_v552beta
NOAA/PMEL TMAP
FERRET v5.52 (beta)
Linux 2.4.3-12smp - 03/11/03
14-Mar-03 12:28
yes? set mode verify:always
yes? define symbol a 2
yes? list 3 * ($a)
!-> list 3 * 2
VARIABLE : 3 * 2
6.000
yes? can mode verify
yes? list 3 * ($a)
VARIABLE : 3 * 2
6.000
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/517

Comment by<EMAIL_ADDRESS>on 6 Nov 2003 19:53 UTC
SET MODE VERIFY:ALWAYS
sets Ferret to ignore cancel mode verify,
when that command is INSIDE A SCRIPT.  This
still works.
yes? cancel mode verify:always
yes? go land 1 basemap
...  see all the commands in the land.jnl script.
As I read the documentation, it is not intended
to ignore cancel verify when that command is
executed from the command line.

Comment by<EMAIL_ADDRESS>on 26 Sep 2005 22:29 UTC
A couple more notes, just to clarify:
CANCEL MODE VERIFY does not take an argument
When issued from the keyboard the intended behavior of CANCEL MODE VERIFY
is that it will over ride any state of MODE VERIFY that was set previously
from the keyboard.
SET MODE VERIFY:DEFAULT returns us to the default mode, whether running from
scripts or the keyboard.
The documentation in the Users Guide is correct.


[SMALLFIX] Fix external block store hostname

Fixes the default spark external block store url to use the correct one.

+1 LGTM


language stats don't match file counts (C should be C++)

This project https://github.com/elucideye/drishti is incorrectly classified as C in the github search.  I noticed the language stats bar incorrectly reports a high C=87% to C++=10% ratio despite the more accurate per language file counts of C++=408 and C=5.  What is the recommended fix in cases where the language counts are actually correct but not reflected in the statistics?

The language stats are correct. Linguist considers the "amount of code" when determining the statistics, not just the number of files.
In your case, you've got 13 MB of C files (well, it's mostly just src/lib/drishti/hci/gpu/VeraFont_16_2048.h) and 1.51MB of C++ files, which works out at approximate 87.6% to 10.1% of the entire repository size.
Removing this file, marking it as vendored or generated using a manual override will exclude it from the stats and give you more realistic looking stats.

I didn't see that file included when I looked at the 5 reported C files from the language search above.
The C file index here:
https://github.com/elucideye/drishti/search?l=c
Only lists the following 5 files:
C src/app/qt/facefilter/Device.h
C src/app/qt/facefilter/QVideoFrameScopeMap.h
C src/lib/drishti/core/padding.h
C src/lib/drishti/graphics/drishti_graphics.h
C src/app/qt/facefilter/GLVersion.h

I'm guessing that file index uses a different process.  I'm currently adding emacs mode hints  -*-c++-*- to all C++ files based on an older issue I saw, and will try the .gitattribute overrides if that doesn't work.

Your large file won't be included in the search results because it is too large: only files smaller than 384kb are indexed hence you don't see it.
https://help.github.com/articles/searching-code/ has more details on the the various search criteria GitHub uses.

To finish the thread...  I left that generated font table as is (C) and added the linguist-generated tag in .gitattributes per your suggestion, and added -*-c++-*- to various files to force C++ labels in cases where it was appropriate.  The .gitattributes file looks like this (per docs):
src/lib/drishti/hci/gpu/VeraFont_16_2048.h linguist-generated=true

The language stats updated immediately and are much closer to what I would expect:

Thanks again.


Horizontal Scrolling with Mouse Wheel

How would you recommend changing the scroll wheel to scroll horizontally on an area that only scrolls horizontally?

You can use the wheel event as described here: https://developer.mozilla.org/en-US/docs/Web/Events/wheel#Listening_to_this_event_across_browser
Listen to this event on the SimpleBar element and then trigger scroll with something like this:
el.SimpleBar.getScrollElement().scrollTo(deltaY, 0)

There doesn't seem to be a scrollTo method.
This did work though.
e.currentTarget.SimpleBar.getScrollElement().scrollLeft += e.deltaY;

Anything wrong with that?

Hmm you're right, scrollTo is only on the window element! My bad :)
Nothing wrong with what you did I think.

@Grsmto: Is this feature available in latest version?
If not, could horizontal scrolling by mouse-wheel be added as a feature?
Or are there libraries that can be used that add this the right way?

Well, I'm using this solution:
let horizontalElements = document.querySelectorAll('[data-simplebar]');
for (let element of horizontalElements)
element.onwheel = (event) => {
  event.preventDefault();
  let elementToScroll = element.querySelector('.simplebar-content-wrapper');

  clearTimeout(elementToScroll.timer);
  elementToScroll.timer = setTimeout(() => {
    elementToScroll.scrollTo({ left: event.deltaY > 0 ? elementToScroll.scrollLeft + 250 : elementToScroll.scrollLeft - 250, behavior: 'smooth' });
  }, 20);
};

But anyway I haven't found a solution for firefox glitchy bug on scroll. Works fine in chrome.

@ch3rn1k: Thanks for the example code. It would be great if such a functionality is implemented in this library and take all the browsers into account.

Well, I'm using this solution:
let horizontalElements = document.querySelectorAll('[data-simplebar]');
for (let element of horizontalElements)
element.onwheel = (event) => {
  event.preventDefault();
  let elementToScroll = element.querySelector('.simplebar-content-wrapper');

  clearTimeout(elementToScroll.timer);
  elementToScroll.timer = setTimeout(() => {
    elementToScroll.scrollTo({ left: event.deltaY > 0 ? elementToScroll.scrollLeft + 250 : elementToScroll.scrollLeft - 250, behavior: 'smooth' });
  }, 20);
};

But anyway I haven't found a solution for firefox glitchy bug on scroll. Works fine in chrome.

Thank you ch3rn1k, worked for me.

Thank you @ch3rn1k  , worked for me.

Thank you @ch3rn1k , it works nicely for me


Duplicated LICENSE

Remove one of the LICENSE

Thanks! Can you make this PR against develop branch please? :)


Change intergration to integration

This has the fix and has been DCO signed off
https://github.com/chef/delivery-cli/pull/39


editionDrop.history.getAllClaimerAddresses(0) error

const walletAddresses = (await editionDrop).history.getAllClaimerAddresses(0);
reason: 'bad response',
code: 'SERVER_ERROR',
status: 413,
headers: {
'access-control-allow-credentials': 'true',
'access-control-allow-headers': 'Content-Type,Authorization,User-Agent',
'access-control-allow-methods': 'GET, POST, OPTIONS',
'access-control-allow-origin': '',
'content-type': 'application/json',
vary: 'Accept-Encoding',
'x-host-id': '',
'x-node-id': '08777362-575c-4584-aa42-4f09eb19af92',
'x-ratelimit-limit': '1000000',
'x-ratelimit-remaining': '999814',
'x-ratelimit-reset': '1665137764',
'x-request-id': 'e0da4b42-61d3-4133-9d57-dc40d2852d36',
date: 'Fri, 07 Oct 2022 05:18:57 GMT',
'content-length': '142',
connection: 'close'
},
body: '{"jsonrpc":"2.0","id":44,"result":null,"error":{"code":-32602,"message":"eth_getLogs and eth_newFilter are limited to a 10,000 blocks range"}}',
requestBody: '{"method":"eth_getLogs","params":[{"fromBlock":"0x0","toBlock":"latest","address":"0x1d6288e8c07ceb1caa82c1ba4fcc856e7536b2d8","topics":["0x4f72e6585331094d368e469f11198272039d08cbddfcda1577e192687a83afb6"]}],"id":44,"jsonrpc":"2.0"}',
requestMethod: 'POST',
url: 'https://aged-dimensional-mansion.ethereum-goerli.discover.quiknode.pro/xxxx'
}

I also get the same error, for polygon network and mumbai testnet it is.
Error: eth_getLogs and eth_newFilter are limited to a 10,000 blocks range
    at json-rpc-batch-provider.ts:70:1
    at Array.forEach (<anonymous>)
    at json-rpc-batch-provider.ts:67:1

this generally is a limitation of the RPC provider you're using - can you try with Alchemy? they're pretty good with their limits


Pawn not covering bug

Pawns are able to capture other pieces, even though the king is under check.

Finished.


Fix: Scroll to picker regression

Details

Fixes a regression where refs ScrollViewWithContext are not forwarded to ScrollView component.
Additionally this introduces a mechanism to conditionally set if the ScrollContext should be used. This PR adds two props (scrollToOverflowEnabled and scrollContextEnabled) to the <Form /> component, so that the ScrollContext only gets used if there's some sort of nested <Picker /> in the form. (Can also be StatePicker or LocalePicker)
Fixed Issues

$ https://github.com/Expensify/App/issues/13909
PROPOSAL: https://github.com/Expensify/App/issues/13909#issuecomment-1396792646
Tests

Log in any account
Navigate to Settings > Any workspace > Connect bank account > Connect Manually > Press Save&Continue without any data
Will not show “fix the errors” press on ‘fix the error’ in the console anymore

[x] Verify that no errors appear in the JS console

Offline tests

Same as regular tests.
QA Steps

Same as regular tests.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

No UI changes.

Mobile Web - Chrome

No UI changes.

Mobile Web - Safari

No UI changes.

Desktop

No UI changes.

iOS

No UI changes.

Android

No UI changes.

I'm not sure if this is caused by this PR yet but there seem to be some dark overlay that doesn't allow me to click on a unit in Android:

I was following this QA in Android

I think it would be good to also include in the test/qa steps the steps from these other PR to make sure this is still working:

https://github.com/Expensify/App/pull/13514
https://github.com/Expensify/App/pull/13499

And the steps from this comment to make sure it doesn't bounce weirdly in small forms: https://github.com/Expensify/App/issues/13909#issuecomment-1379483718

I think it would be good to also include in the test/qa steps the steps from these other PR to make sure this is still working:

Fix: Scroll to Picker TextInput on open #13514
Use measureLayout to calculate scrolling #13499

And the steps from this comment to make sure it doesn't bounce weirdly in small forms: #13909 (comment)

done!

I tested this in web/ios/android, following the QA (check that the error is not there anymore), and also checking this: https://github.com/Expensify/App/pull/14409#issuecomment-1397193509 and I didn't spot any problem. Things seems to be fixed.
I still requested another pair of eyes to review the PR because I'm not very familiarized with this.

I'm not sure if this is caused by this PR yet but there seem to be some dark overlay ~that doesn't allow me to click on a unit~ (correction: I can click the unit despite the dark overlay) in Android:

I was following this QA in Android
Update: This seems to be like this in main too

You're right, i'm getting this on main as well. Seems to be some other bug, but definitely not related to this PR

Works well! Some changes are needed as mentioned by @luacmartins

Great start! I left a few comments. Additionally, there are two bugs that are also on main, but maybe we should address them in a different PR.
No error displayed for input in short screens

In either iOS or Android, navigate to Settings > Workspace > Connect bank account > Connect manually
Have the keyboard active
Press Continue
Notice that the error does not show for Account number and the Terms checkbox
You can reproduce on web too, if you resize the browser to a short height.

Maybe this got fixed already on main, because i can't reproduce this on my emulator after merging main into this branch (at approx. 01/20/2023 9am CET):
Android (emulator):
android recording.webm
Web:
https://user-images.githubusercontent.com/20173411/213665109-f22acdd4-fa8f-426e-bc10-f4301f482597.mov

@luacmartins do you know what the FormScrollView component is used for essentially?
For example, we also have in ACHContractStep, we also have a IdentityForm wrapped by a ReimburseAccountForm component. (which renders the FormScrollView)
I'm thinking if it's necessary to also add the two additional props from Form to FormScrollView to also enable this functionality here

@chrispader as far as I know FormScrollView should be deprecated in favor of Form - we are refactoring ACHContractStep to use Form here and we shouldn't introduce any new instances of it. I don't think that we need to worry about the other existing pages using FormScrollView because they don't seem to have nested Pickers.

Thanks @luacmartins for the thorough review! I'll do my review later today.

@chrispader, I am seeing this error -
https://user-images.githubusercontent.com/83179295/214135220-e56675b8-1617-4fc8-9cca-1f00b16884ce.mov

Sorry guys, I failed to get to review this today. I'll get to it first thing tomorrow

Fixed! I just forgot to change the ref variable in two calls in Form

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/83179295/214418838-79974924-bb6b-4aa8-9756-114a25c1bfbb.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/83179295/214418890-c19af3dd-2242-4ece-98a4-77d1bd7d487b.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/83179295/214418904-38ae291e-e42a-41c9-b340-faef5a47c3bd.mov

Desktop
https://user-images.githubusercontent.com/83179295/214418913-b87fa3df-4b37-4ff9-9636-4c722cab67d2.mov

iOS

https://user-images.githubusercontent.com/83179295/214418927-1dabb5f4-765a-4420-8e89-549e1643bed2.mov

Android
https://user-images.githubusercontent.com/83179295/214419786-702fbf33-ce09-4c04-87ab-43091850efb7.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.2.59-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.59-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Vidloop threads

This is a proposal to address  https://github.com/alfredh/baresip/pull/451 last comment analyses.
As suggested, video frames are rendered/displayed from main thread and the logic is moved to vidloop module.
Tested with SDL2 display, on win10 and ubuntu 16.04

Not thread safe => closed.
Need more work on mutex positioning if we want to avoid frame copy before putting the rendering timer...

perhaps we can add a small vidqueue that holds vidframes. the vidqueue
can be thread-safe and have put and get operations.
the display timer can run with a 10ms interval and simply get video frames
from the queue and display them.


how to setup controls?

plyr.setup({'controls:["restart"]'})
this produces error unexpected token }
Is there an example of how to setup controls?

Yes because you're passing a JSON string as opposed to an object. Try this:
plyr.setup({ controls: ["restart"] });

tried it just now. now it says setAttributed of undefined.
Maybe because I have multiple players?

I've not tried such a bare bones UI so I'll have to get back to you on that.

Fixed in v1.5.0


Statistical Analysis of Data

Look at mutual info between property data and plausibility.
Look at correlation between association data and plausibility.

@sebastian9991 @jonahdvt I need GPT to provide property / association predictions on the 20q and PEP plausibility datasets, in order to compute relationships between input distributions (property or association) and output distribution (plausibility)

I'll work on association predictions.


Updating column value in BeforeUpdate() does not use new value

GORM Playground Link
https://github.com/go-gorm/playground/pull/678
Description
I would like to be able to use BeforeUpdate() to modify a column value, before updating. For example, I may want to trim any whitespace on the value before updating it in the database. The functionality is possible with the BeforeCreate() hook, but it does not seem to be possible with the BeforeUpdate() hook.
in my code example, you can see I create a user  "    jinzhu     ". In the BeforeCreate() method, I trim the whitespace and update the value, and the query uses the updated value.
In my code example, I update the user to the name "    tux    ". In the BeforeUpdate() method, I trim the whitespace and update the value, but the actual update query still uses the original value. I would expect it to use the updated value.

It's easy enough to work around this by trimming whitespace the Update() call instead, but this seemed like a bug.


Todo

[ ] Fix sourcemaps
[x] Make IE8 font size fallbacks

Sourcemaps are currently borked. Need to concat Normalize (not the bower version) and Reeeset into dist then cssclean. This would make for a more readable unminified version anyway.


pipx run cannot pass flags to program

Tried to use pipx to run create-python-package --help but got pipx's help text rather than create-python-package's
> pipx run create-python-package --help
usage: pipx run [-h] [--spec SPEC] [--verbose] [--python PYTHON]
                [--system-site-packages] [--index-url INDEX_URL] [--editable]
                [--pip-args PIP_ARGS]
                binary [binary_args [binary_args ...]]

positional arguments:
...

Ideally pipx would find the first positional argument and forward all subsequent arguments to the binary the user wants.
argparse is used and this is how arguments are currently forwarded (https://github.com/pipxproject/pipx/blob/master/pipx/main.py#L847)
    p.add_argument(
        "binary_args",
        nargs="*",
        help="arguments passed to the binary when it is invoked",
        default=[],
    )

This works fine for arguments that don't have a - prefix. i.e. pipx run cowsay help works but pipx run cowsay --help does not. This is a regression recently introduced with the run command.

fixed in <IP_ADDRESS>


New storage backends

If I want to integrate a custom storage backend, what parts do I need to implement?
So far it looks like I can start with something similar to https://github.com/umputun/remark/blob/master/backend/app/store/engine/mongo.go, but it is not clear how to implement a backend for storing images.
Are there any recommendations or best practices?

Hi. As of now there is no documentation explaining how to deal with external storages. Example of mongo implementation is the closest one. In addition to the core storage (i.e. store/engine) you will need 2 more things:

storage for uploaded images  (implement 1store/image/image.go/Store` interface)
storage for user's avatars. This part is external library accepting user defined implementations - see https://github.com/go-pkgz/auth/blob/master/avatar/store.go

Another thing you may want is a store for admin data and this is in store/admin.
Generally I would recommend not to do it yet. The current way to add storages is not too friendly and need way too much efforts. I'm in the process of migrating all of this to some pluggable architecture allowing much simpler extensions. As a part of this process I'll move mongo to such a plugin (bolt will stay as a core implementation inside) and will provide an example of some trivial user-defined storage covering all areas.

The new backend interface has been merged into master. Instead of the insane amount of function we used to have, all low-level storage functionality consolidated into just a few generalized methods and several higher-level operations were moved to the common store/service.
In order to allow users to bring their own storages, I have added a special layer for RPC-like calls (see /backend/app/remote). For convenience, it also includes the code for user's plugin, i.e. server/remote/plugin side/dispatcher. Support of such custom storages was added to options (cli params and env) as well.
Both new interface and RPC protocol need some detailed documentation and examples (work in progress), but generally speaking, it should be clear from the code what the protocol is and how to use it. I'm planning to add full demo implementation of the custom storage backend (in-memory storage) this weekend.

I have added an example implementation of alternative storage.


Standardize async id creation and setting

This will make sure we don't forget to reset async ids in 'create_reset_ids' and also makes sure we're incrementing the id whenever we get it (instead of doing it at some later, random instruction).
This is follow up to a conversation here:
https://github.com/bpftrace/bpftrace/pull/3249#discussion_r1649215402
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

@danobi

@danobi Great suggestion on using X-macros; I didn't know about them. Code looks much cleaner.

@danobi Thanks for the review!

@viktormalik Let me know if you want me to hold off on landing this as it might cause a few merge conflicts with https://github.com/bpftrace/bpftrace/pull/3285


feat(auth): Support sms region config change on Tenant and Project level

PR for SMS Region
Original PR here : https://github.com/firebase/firebase-admin-node/pull/1673/files

Hey @lahirumaramba, we're releasing the SMS regions in the admin sdk given the launch is now approved.
Most of the changes were reviewed here: https://github.com/firebase/firebase-admin-node/pull/1673. It was merged then reverted.
Please take a look and feel free to let us know if there is any questions. Thanks!

Thank you @pragatimodi and @renkelvin! LGTM! Merging this to the main branch will include the feature in the next SDK release... If we need more time to release this change we can merge this to a feature branch for now. Let me know.

Thanks @lahirumaramba ! Yeah, we'd like to include this feature in the next SDK release.


🤖 Dive into Hacktoberfest 2023: Contribute to AI Collective Tools (aicollective.tools)🚀✨

Welcome to AI Collective Tools! 🎉
We're excited to invite you to contribute to AI Collective Tools a unique initiative aiming to bring together all AI tools under one roof. Our mission is to create a comprehensive platform where developers, researchers, and enthusiasts can access, collaborate on, and contribute to a diverse range of AI tools and resources.
I hope you will stick around and continue to contribute to this project. Here is the Contributing Guidlelines. &
Consider giving this project a star and joining the community discussion for more resources and opportunities to connect with others. 👉🏽Discussions👈🏽
About Hacktoberfest:
Hacktoberfest is a month-long celebration of open-source software. During October, open-source enthusiasts and beginners alike can participate by contributing to open-source projects on GitHub. By making four valid pull requests during the month of October, participants can earn an exclusive digital reward kit. To learn more about Hacktoberfest and to register, visit Hacktoberfest's official website.
Happy hacking! 🚀✨

I'd love to contribute to the project

I'd love to contribute to the project

to contribute please go ahead with the Contributing page.

please assign it to me

please assign it to me

to contribute please go ahead with the Contributing page and consider giving this project a star

I'd like to contribute here.

hey! folks, love to contribute on this project.

@Hyraze I would like to collab with you on this project as I am also maintaining OSWH I am quite familiar with what you are building so we would make a great team WDYS?,
check out here -> https://oswh.tech


Commercial license support

Fixes #717
Merge after #751
⚠ Includes schema change ⚠

I'll take a look at it later today. 👍 I want to run it locally and see how it behaves.


<IP_ADDRESS>:57024: connect: connection refused on kind creation scripts in macOS

What happened:
Running the kind kubefed setup scripts on Mac is not properly registering the kubefed cluster.
k get kubefedclusters -A
NAMESPACE                NAME       AGE   READY
kube-federation-system   cluster1   25s

k describe kubefedclusters -n kube-federation-system cluster1
...
Events:
  Type     Reason                         Age               From                       Message
  ----     ------                         ----              ----                       -------
  Warning  RetrievingClusterHealthFailed  5s (x3 over 25s)  kubefedcluster-controller  Failed to retrieve health of the cluster: Get "https://<IP_ADDRESS>:57024/healthz?timeout=3s": dial tcp <IP_ADDRESS>:57024: connect: connection refused

What you expected to happen:
The cluster should be in the READY=true state.
How to reproduce it (as minimally and precisely as possible):
Running:
https://github.com/kubernetes-sigs/kubefed/blob/master/scripts/create-clusters.sh
https://github.com/kubernetes-sigs/kubefed/blob/master/scripts/deploy-kubefed-latest.sh
NUM_CLUSTERS=1; ./scripts/create-clusters.sh
./scripts/deploy-kubefed-latest.sh

Anything else we need to know?:
I assume this is related, but it doesn't trigger if on Darwin. When I tried removing it I lost connection to the context (seems obvious since it is changing the server to the docker IP address):
https://github.expedia.biz/mvaal/rcp-kubefed-kind/blob/master/kubefed/scripts/create-clusters.sh#L54-L59
Environment:

Kubernetes version (use kubectl version): kind vv1.21.1

kubectl version
Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.1", GitCommit:"632ed300f2c34f6d6d15ca4cef3d3c7073412212", GitTreeState:"clean", BuildDate:"2021-08-19T15:38:26Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

KubeFed version: latest
Scope of installation (namespaced or cluster): cluster
Docker: Docker version 20.10.8, build 3967b7d
OS: macOS Big Sur v 11.6.1

/kind bug

This is covered here and I missed it.
https://github.com/kubernetes-sigs/kubefed/blob/master/docs/cluster-registration.md#joining-kind-clusters-on-macos
Running the fix-joined-kind-clusters.sh moved my clusters into the ready state.


SVG drawing

Adds ability to draw to SVG as well as Canvas.
Work sponsored by SRI International's CSE group.

+1


Stop overflow

Stops images & youtube embeds from overflowing past the parent div of blog posts.
Useful in case an iframe or image asset is too large, or if the user is viewing from a small device (e.g. mobile).

Dammit.


fix: Remove deprecated warning_filter

Resolves #29
Resolves: warning_filter doesn't do anything since MkDocs 1.2 and will be removed soon

The CI failures are unrelated to this change

Thanks @KyleKing, @oprypin!


UIPanGestureRecognizer causes index out of bounds crash

A tester has came back to me saying that when they stress test the double tap gesture of a chart it causes a crash.
I have been able to reproduce this issue and when it crashes the below exception is logged.
*** Terminating app due to uncaught exception 'NSRangeException', reason: '-[UIPanGestureRecognizer locationOfTouch:inView:]: index (0) beyond bounds (0).'

From looking at your Classes I can see that only the BarLineChartViewBase has a UIPanGestureRecognizer .
A potential fix to avoid this crash is to check for the number of touches before processing the gesture.
I have modified the first line in the panGestureRecognized method of the BarLineChartViewBase Class to
if (recognizer.state == UIGestureRecognizerState.Began && recognizer.numberOfTouches() > 0)

Will work on a fix soon. Actually numberOfTouches will ALWAYS be > 0, when the state is "began", or when another finger is added. I guess this is caused in a state of END or CANCEL.

Or maybe it is related to this: http://stackoverflow.com/questions/12066821/pan-gesture-is-crashing-while-taking-the-location-of-touch-in-view-in-ios

After further research - it seems like UIPanGestureRecognizer is indeed unstable under stress testing. Causing 0 touches when it has a minimum of 1. Could be a bug in iOS 8 or something. Anyway I'll add a fix.


MS Edge fails with SCRIPT1028: Expected identifier, string or number

RxJS version:
5.5.6
Code to reproduce:
N/A, we have a complicated build process, can't strip out the code to repro.
Angular5, webpack, Polymer, etc.
Expected behavior:
RxJS should work in MS Edge
Actual behavior:
SCRIPT1028: Expected identifier, string or number
App fails to render anything, blank page.
Additional information:
After a short investigation, the problem is on this line (marked with * the exact position):
const { request, request: { user, method, url, async*, password, headers, body } } = this;

This line is the part of the AjaxSubscriber class' send() method.
If I replace the 'async' variable names in the method for eg. 'asynch', everything starts to work without any problem.

With this issue without isolation in build steps, I have suspect this is related to your build configurations.
Specific code line you mentioned is simply transpiled down into like below: (CJS, umd both)
AjaxSubscriber.prototype.send = function () {
        var _a = this, request = _a.request, _b = _a.request, ..... async = _b.async, password = _b.password, headers = _b.headers, body = _b.body;

while having var async = ${something} isn't great practices, it doesn't have conflict to global scope async keyword at least afaik.
If you can't strip out code, what happens if you import bare rx without involving anything in Edge? (no angular, no polymer, etcs)

Also may worth to check http://reactivex.io/rxjs/ (it loads umd build of Rx inside) on Edge to see global build fails with same transpiled results. (it did work on me).

The code looks like this:
class AjaxSubscriber extends __WEBPACK_IMPORTED_MODULE_4__Subscriber__["a" /* Subscriber */] {
    constructor(destination, request) {
        ....
    }
    next(e) {
        ....
    }
    send() {
        const { request, request: { user, method, url, asynch, password, headers, body } } = this;

Downgrading the transpile to es5 works around the problem.

I'm feeling it'd better to rename variable name in further eventually, for cases if we have runtime doesn't need any transpilation one day.

Just run at this problem too. For me fromPromise causes this error.

Ran into this problem with Angular 8 and Edge. Same code piece as above.

Since old EDGE itself is deprecated, closing issue and recommend to use latest rxjs & support chromium based edge.

Since old EDGE itself is deprecated, closing issue and recommend to use latest rxjs & support chromium based edge.


Incompleted checklists

I am fetching all the cards from a board and I would like to get the included checklists in the same request:
Trello.get('boards/<board_id>/cards?actions=addChecklistToCard', success, error);
Why this request only returns the completed checkItems? How to get all of them ?
If I fetch one of those cards with the following request, I get the incomplete checkitems as well:
Trello.get('cards/<card_id>/checklists', success, error);

@jocelynduc The first request you are making shouldn't be returning any checkItems. If you want to see all of the checkItems for all of the checklists on a single board, I'd recommend using the following call:
Trello.get('boards/<board_id>/checklists/', success, error);


Can't add click handler to  component

See https://codesandbox.io/s/1rqn7plkj7 example. The <Icon> component doesn't accept an onClick handler and so the link property doesn't really serve much purpose besides styling.

A PR is coming shortly.


slack_bot_id lookup script seems to be failing

I think this is related to #94 -- Slack seems to have changed the way that bots are created/managed
APP/PROC/WEB/0Looking up BOT_ID for 'watsonshoppingbot'Jul 17, 2017 12:58:21.826 PM
APP/PROC/WEB/0Error: Missing BOT_ID or invalid SLACK_BOT_USER.Jul 17, 2017 12:58:22.013 PM
APP/PROC/WEB/0could not find user because api_call did not return 'ok'Jul 17, 2017 12:58:22.013 PM
APP/PROC/WEB/0DEBUG:urllib3.connectionpool:https://slack.com:443 "POST /api/users.list HTTP/1.1" 200 55Jul 17, 2017 12:58:22.014 PM

I am not able to reproduce this problem. Slack does not appear to have changed. When running via manual setup, the BOT_ID is successfully obtained and the app works as expected.
I'll be pushing up a patch with improved documentation in the README. I'm wondering if this is a configuration error?

Closing this as "Cannot Reproduce".

@scottdangelo
Not sure why @stevemart never replied, but I have been experiencing the same error message when trying to use the watsononlinestore run.py script. When the script runs the line "slack_client.api_call("users.list")", the api_call returns "{u'ok': False, u'error': u'invalid_auth'}".
This is strange, because I have gone back and confirmed that my SLACK_BOT_TOKEN is correct - it actually works fine when running the script locally, and also when using Slack's API tester for the users.list method. It only fails when deploying the app from IBM Cloud.
Any thoughts?

@scottdangelo
Update: I was only able to get this Slack API call to work by using the full URL with the Requests library:
api_call = requests.get('https://slack.com/api/users.list?token=<mySlack_bot_token>&pretty=1').json()
For whatever reason, I kept getting the invalid_auth error when attempting to use slack_client.api_call("users.list"). I wonder if it has something to do with the way the token is pulled - I couldn't get the URL to work using the variable "slack_bot_token" in the URL and had to just insert my full token into the URL string.
Hope this info helps figure out the issue.


Possibility of 1920x1080 depth resolution on host computer using SDK

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
2.10.1

Issue Description
I have seen that we can get infrared 1 & 2 streams at 1920x1080 resolution at the same time. However, available max depth resolution is 1280x720 as indicated in specs.
I would like to know whether there is a way to calculate depth data from infrared streams at 1920x1080 resolution using the SDK. This way we can do the stereo calculation on host device and get more depth resolution.

Hello @bellekci , the SDK is intended to convey the depth data that is generated on device.
And while your request is technically feasible, it is out of the scope of the SDK.
On an implementation side:
Most stereo-based algo require that the input (left+right)images are aligned/rectified.
The Full HD resolution for infrared streams is a calibration format that provides unrectified images - intrinsic parameters are not calculated.
You may also find useful the following paper that provides an in-depth review of the technology and the algorithms: https://arxiv.org/pdf/1705.05548.pdf

Thanks @ev-mp for the info.
Is there any particular technical reason that depth is calculated at 1280 x 720 rather than 1920 x 1080 even though that is the max resolution of infrared cameras?
Or is just that the stereo calculation module in d series by design cannot handle more than 1280 x 720 resolution?

yes to both.
As @ev-mp says, for stereo depth sensors  you have to first rectify the images (remove distortion), and then align the left and right images (overlap) and you will lose resolution simply due to that. This can be roughly 20-30% when also taking into account production tolerance. Yes, the rectification step is then limiting to stereo calculation 1280x720 (although slightly higher is possible) in the ASIC.
As for doing your own calculations, you can certainly do that. Simply grab the left and right 10bit monochrome images at 1920x1080 (you wont be able to read the color at that resolution though).

Hi @bellekci
Does the response of @agrunnet answers your question?

Yes, it does. you can close the issue.

Thanks


[NEW FEATURE] New LuosHAL_SetIrqState

What feature would you like to be included in Luos?
It's will be nice in LuosHAL in the function LuosHAL_SetIrqState(uint8_t Enable) to just enable/disable LuosHAL interrupt and anot all the interrupt of the ship

Luos_engine 3 call the IRQ function fo each PHY allowing the phy to only disable it's own IRQ.


chore: added missed trailing commas

Codecov Report

Merging #58 (d3bd102) into main (67c7207) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          247       247
=========================================
  Hits           247       247

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c7207...d3bd102. Read the comment docs.


adding version locking for addons and tests

Description
adds ability to specify versions of addons.
This will guarantee that chef server created by this cookbook will be exactly the same every time.
Issues Resolved
https://github.com/chef-cookbooks/chef-server/issues/138
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

@vinyar Can you rebase this change. I'll get it merged in and released after that

@tas50 rebased. Thanks


Addition with carry ADC instruction overflow V flag vs C flag?

ADC computes A = A+M+C (adds accumulator to operand and carry, saves to accumulator). Currently, cpu3502 1.0.0, it sets the V flag (overflow/underflow) if the result is too large/small to fit in 5-trit tryte.
Is this behavior correct? Compare to: http://www.obelisk.demon.co.uk/6502/reference.html#ADC - sets C "if overflow in bit 7"; http://www.obelisk.demon.co.uk/6502/registers.html#C "set if the last operation caused an overflow from bit 7 of the result or an underflow from bit 0.", and V is set "during arithmetic operations if the result has yielded an invalid 2's complement result (e.g. adding to positive numbers and ending up with a negative result: 64 + 64 => -128). It is determined by looking at the carry between bits 6 and 7 and between bit 7 and the carry flag." - need to determine what this means in the context of ternary (since it is a balanced numeric system, not using 2's complement)

 11111  121                       11111  121
+11111  121                       11111  121
10000i  242                      +    1    1
     i   -1                      100000  243
     sign(242) ≠ sign(-1)             0    0
                                      sign(243) ≠ sign(0)
 11111  121
+00001    1                       1i1i1   61
1iiiii  122                      +1i1i1   61
 iiiii  -121                     1iiiii  122
     sign(122) ≠ sign(-121)       iiiii -121
                                      sign(122) ≠ sign(-121)

 iiiii -121                       1i1i1   61
 0000i   -1                       1i1i1   61
i11111 -122                      +    1    1
 11111  121                      1iiii1  124
     sign(-122) ≠ sign(121)       iiii1  -119
                                      sign(124) ≠ sign(-119)


ingestor scale-up test run with bulk input data, say 1-year of landsat NBAR

to stress test the ingestor's robustness and reliability when handling large amount of data.

Runs on about 1000 LS scenes (1% of total) went fairly smoothly.
Over the next weeks we'll scaling up towards 100% of the data


ci: run tests in the workflow

Type
enhancement

Description

Integrated test execution into the Continuous Integration (CI) workflow to ensure code quality before releases.

Changes walkthrough
Relevant filesEnhancement

ci.ymlIntegrate Test Execution into CI Workflow

.github/workflows/ci.yml

Added a step to run tests in the CI workflow.

+3/-0

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add instructions for new round startup to the wiki

make the new data

select lots for the upcoming round
update sold lots carto table ...

upload lots for upcoming round as new dataset to carto
update carto references to the name of your new dataset in js and lots settings
add new program area boundaries to chicago_community_areas table in carto

add row
grab geometry from boundaries.geojson

update selects in assorted places to select geometry from your new row in the community areas table (search ll code for chicago_community_areas to start...)
update pilot start and end date in lots settings

waiting on this 'til #353 is complete!

also, n.b., made some changes in #353 so the carto stuff is set in the local_settings file.

closing per the new wiki page!


Need to modify existing config for it to work with themite

The config file that I already had existing in my termite folder didn't have the [end-colors] phrase, causing an error within the theme_swap method, specifically, the line end = content.index('\n[end-colors]')
This raises an error where the substring [end-colors] isn't found.
I fixed this by manually adding it to the end of my existing file.
You could make a note of this in your README.md, or account for the instance where it isn't found by simply going to the end of the file.

I merged the pull request, but I may remove some of the comments, You're right that it needs some for sure. Also had to fix one thing in the print statement for main, needed to change it over to 'themite' rather than 'theme'. Awesome contribution though, the addition to list was very welcome!

Thanks!


python3.pkgs.tables: fix tests for numpy 1.25

Description of changes
Relevant for https://github.com/NixOS/nixpkgs/pull/245935.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python3.pkgs.tables

Picked up latest fixes in staging-next. @ofborg build python3.pkgs.tables

CI is green, besides aarch64-darwin, merging.


Errors when installing by conda

Hi,
I tried to follow the readme to install by conda. When running pip install unigbsa gmx_MMPBSA>=1.5.6 lickit, I encountered "ERROR: Could not build wheels for mpi4py, which is required to install pyproject.toml-based projects". However, I checked that mpi4py is already installed. Could you kindly provide some suggestions?
Thanks!

Try this commands:
pip install gmx_MMPBSA==1.6.1 unigbsa

Thanks, it works for me!


[ENH] Complete functions.reset_index_inplace() deprecation

Brief Description

functions.reset_index_inplace() was marked for deprecation in 0.18 release. It was marked in #282 on May 7, 2019. Should it be removed now?

Yes, I think it's a good time to remove it. Thanks for the catch, @hectormz! To keep things streamlined for you, I don't mind if you sneak in this fix into #641.

Sure, I'll do that

This is closed via #641


Want to open a link in a panel in another option panel

If I click while pressing Cmd, it will open in another panel.

Who wants this?


Prepare upgrade to version 1.13.2

This PR:

adds/changes/removes etc

Checklist

[ ] Update changelog in CHANGELOG.md.

I think https://github.com/giantswarm/efk-stack-app/blob/master/helm/efk-stack-app/charts/opendistro-es/values.schema.json needs to be updated as well because it seems there are some changes in the opendistro-es values

I suggest adding this github workflow checking for changes in values.yaml https://github.com/giantswarm/cert-manager-app/blob/master/.github/workflows/check_values_schema.yaml


Set default radio button selection, evaluate default component popula…

Fixed #17746
Two bugs fixed:

No default selection was being set if the source or target weren't provided (both valid scenarios)
The displayed components were being populated off of the input source and target, rather than the current selection (which would reflect the input, except when a default selection was made

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 32 (81.25%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 41.673%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/schema-compare/src/dialogs/schemaCompareDialog.ts
26
32
81.25%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
27196

Relevant Lines:
59211

💛  - Coveralls


Wallet compatibility EWC/Volta

Tested here: https://safe-team-ewc.staging.gnosisdev.com/app/#/welcome
TL;DR: Just MM extension works if the user configures EWC or Volta as custom networks
WalletConnect:
I tried with my MM phone app. That app doesn't have a way to change to another network that is not ethereum.
Still, I connected with the hope of it connecting it (showing the connection in the top right corner) but I just got this error in the console.

Portis:
Not compatible it seems

Fortmatic:
Err_connection

Opera:
I tried to configure a custom network but even that way it won't show the tokens sent. I assume is not compatible at all
I should have 0.01 EWT but still shows 0 ETH

Coinbase:
The coinbase wallet phone app doesn't have the EWC as an option for networks and wont allow custom networks either
Authereum:
Keeps showing this error in the network tab. So I assume is not compatible

Torus:
Keeps throwing this error contantly in the console.

Unilogin:
Throws this console error

Tried again in this PR where the EWC network should be recognized by the onboard, but I had the exact same issues reported previously
https://pr1538--safereact.review.gnosisdev.com/volta/app/#/welcome

This is merged to be tested in release/v2.14.0 branch


Tutorial Chapter on Termination Conditions

The current chapter on termination conditions is outdated.  Examples of how to use termination conditions already exists in the previous chapters, so in this chapter just focus on the mechanism, and list the built-in termination conditions.
It is important to note the termination conditions are reset automatically after each run and run_stream.

Also that they can be combined.
E.g.

termination = termination = MaxMessageTermination(3) | TextMentionTermination("stop")
termination = termination = MaxMessageTermination(3)  & TextMentionTermination("stop")


        This function requires a time snapshot `start_time` before the operation to be measured starts and this function
        should be run immediately after the operation to be measured has completed.

        Args:
        - split: name to prefix metric (like train, eval, test...)
        - start_time: operation start time
        - num_samples: number of samples processed
        """
        runtime = time.time() - start_time
        result = {f"{split}_runtime": round(runtime, 4)}
        if num_samples is not None:
>           samples_per_second = num_samples / runtime
E           ZeroDivisionError: float division by zero

C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\site-packages\transformers\trainer_utils.py:354: ZeroDivisionError

Hello!
This issue seems to have been fixed in https://github.com/huggingface/transformers/pull/24049
I was looking for my first issue to work on when I noticed this: not sure if there is a specific protocol for suggesting to close an issue.

Thanks for informing, @zeppdev. I am closing this issue.
Fixed by:

huggingface/transformers#24049


[pwrmgr] D2(S) Signoff

Description
Ensure D2(S) signoff criteria are still maintained (this is not a focus area block).

pwrmgr D2(S) Signoff
This is not a focus area block.
Commits since Earlgrey-ES tapeout
$ git rev-parse --short HEAD
af85dad7af
$ git log Earlgrey-M2.5.2-RC0..af85dad7af --oneline -- hw/ip/pwrmgr hw/ip_templates/pwrmgr

dd117372ca [doc,pwrmgr] Document wakeup signal requirements
b16179dd74 [ipgen,rstmgr] Fix BUILD files
ab4b36f6b9 [ipgen,rstmgr] Fix paths to rstmgr in md files
ce648ca68e [ipgen.pwrmgr] Change core files to vlnv naming and label as virtual
4a9a881d44 [topgen] Pass topname key/value pair to ipgen
da087bbddd [rtl,pwrmgr] Fix escalation timeout persistence
de31bdf1c2 [reggen] Remove the devmode input
963a5006cc [doc] Minor tweak to md sanitisation code
748235cbb6 [dv,pwrmgr] Fix pwrmgr_escalation_timeout test
729f744642 [dv/pwrmgr] Add escalation_timeout test
c87db05473 [pwrmgr,ipgen] Remove the hw/ip/pwrmgr and their autogen files
7215f8d9cb [pwrmgr,ipgen] Fix hjson files
78c7edd733 [pwrmgr,ipgen] Fix pwrmgr template and autogen core files
988b584da3 [pwrmgr,ipgen] Fix BUILD files
3f88a55120 [pwrmgr,ipgen] Generate pwrmgr ip_autogen files with topgen
8034e000d6 [pwrmgr,ipgen] Turn a few more files into templates
a8529ce8a9 [pwrmgr,ipgen] Copy all hw/ip/pwrmgr files to ip_templates
c288cc3968 [pwrmge,ip_gen] Add tpldesc hjson file
77278de68f [pwrmgr] Replace tab with spaces in test plan
709d4e7ca0 [doc/pwrmgr] Improve theory of operation doc
9e006e2554 [sival,pwrmgr] Add features in pwrmgr.hjson.tpl
1b16ca2122 [reggen] Add mubi support SWAccess that sets/clears a reg
f4f5d98064 [dv/pwrmgr] Allow transitions to invalid fsm state
59f8142826 [doc] Moved badges over to using hosted images
13c6152a0e [doc] pwrmgr registers and interfaces now use CMDGEN
f7edbbb6a3 [pwrmgr,dv] Correct name of disabled assertion
51d31a1aae [dv/pwrmgr] Complete SVAs for rom integrity checks
7688e714e8 [reggen] Add initial support for version and cip_id hjson fields
fbd888eea8 Revert "[reggen] Add CIP_IDs and bump all major versions"
0ba10b3cd3 [reggen] Add CIP_IDs and bump all major versions
9a61b02fe1 [pwrmgr] Fix xcelium compile error
143faa6be5 [pwrmgr] Synchronize lc signals
e47df29f3e [misc] Use lc_tx_t testing functions at endpoints

Thanks for summarizing this @matutem.
I reviewed the RTL changes in more detail above:

da087bb [rtl,pwrmgr] Fix escalation timeout persistence

bugfix that is already tested in DV -> OK

de31bdf [reggen] Remove the devmode input

the alternative mode was never used -> OK

1b16ca2 [reggen] Add mubi support SWAccess that sets/clears a reg

bugfix in reggen -> OK

9a61b02 [pwrmgr] Fix xcelium compile error

no functional change -> OK

143faa6 [pwrmgr] Synchronize lc signals

this cleanup does not affect functionality and is thus already tested in DV -> OK

e47df29 [misc] Use lc_tx_t testing functions at endpoints

this cleanup does not affect functionality and is thus already tested in DV -> OK

I believe the only open design issue is https://github.com/lowRISC/opentitan/issues/20518, which is an enhancement that intend to look into at PROD.M3, so this should not gate D2S/V2S for now.
The Hjson still lists v1.0.0 D2S, so no change is needed to the Hjson (the interface did not change, hence no version increase is necessary):
https://github.com/lowRISC/opentitan/blob/7e196e6f072791aa17817b7691aed6b258399eeb/hw/ip_templates/pwrmgr/data/pwrmgr.hjson.tpl#L34-L40


Add support for language-babel

I use language-babel for highlighting my JavaScript files. I think it would be nice if language-markdown would support this.
Since this is a non-standard language, I'm not sure how this should be supported. Perhaps a custom mapping could be made from a code fence language to a source type.

I've added language-babel support. Will be part of upcoming release. Once it is available, let me know if it works as intended.


svtools: error: unrecognized arguments: lsort_expected

Hi!
I can run NA12878.vcf NA12891.vcf NA12892.vcf to Isort.vcf by subcomand of Isort. However, I can not run lmerge, even the  merge the file(lsort_expected) from lsort_expected svtools/tests/test_data/lsort.
svtools lmerge lsort_expected > Imerge.vcf
svtools: error: unrecognized arguments: lsort_expected

I think the issue is that lmerge doesn't accept positional arguments. I think either of these approaches should work:

Provide no arguments and have it operate on a stream.
cat lsort_expected | svtools lmerge > lmerge.vcf

Use the -i option to specify an input file.
svtools lmerge -i lsort_expected > lmerge.vcf

Great! You are right about the first method not working, I've made a note to add that functionality in the future.