backend: do not lock state on destruction

locking the state when invoking the pending
destructors can lead to deadlocks if a
destructor tries to send an event

Thanks!
Could you just add an entry for that in wayland-backend's pending changelog?

Thanks!
Could you just add an entry for that in wayland-backend's pending changelog?

Sure, added an entry to the changelog


Release?

I think we're close to being able to release pandoc 3.0.
But for that to happen, we need a released version of pandoc-lua-marshal.

Unless you think there are further changes we should make to pandoc-types...

It's ready for release and we can do so any time. You are co-maintainer on Hackage, so we don't depend on me for this. It might be good to merge #11 (use released version of pandoc-types) before we release, but it's not strictly necessary, I think.

Released!


Permanent, meaningful, discoverable home for the project

There have been various discussions and asks to move the prometheus-operator into a more permanent, meaningful and discoverable home. Projects in the coreos org, primarily revolve around fedora-coreos, and that clashes with discoverablility a lot. It also incorrectly reflects the reality that this project is not entirely maintained by "coreos", but there are multiple non-Red Hat maintainers present.
Somewhat related, there are asks for homes for related projects, such as but not limited to:

separate api and client repositories (https://github.com/coreos/prometheus-operator/issues/3269, https://github.com/coreos/prometheus-operator/issues/3097)
a repository for a helm chart (https://github.com/coreos/prometheus-operator/issues/3169)
a home for kube-prometheus (which currently suffers from the same symptoms as the prometheus-operator project

In a separate org it would be possible to govern the project in a way that doesn't make it seem to be a closed set of maintainers, but rather the community run project that it is.
As a side note, and as we all know a poor metric, but with >4.3k stars the project's popularity has outgrown our wildest dreams and just for that deserves its own home.
@lilic @s-urbaniak @paulfantom @pgier @simonpasquier @metalmatze @ant31 @gianrubio @gouthamve @mgoodness @vsliouniaev @coreos/team-monitoring

+1 (💯 ) from me

I meant to add it, but my proposal would be to move it to the prometheus-operator org, that I have reserved.

From my side we have 3 possible places where the project can go:
prometheus-community org
pros:

discoverability
neutral space
established community

cons:

community goal is to offer a neutral place for projects that are too small to be known by themselves or that are abandoned by the original author
possible problems with creating additional repositories

organization dedicated to observability
pros:

we can have multiple repositories with different maintainers for each
better discoverability than now
neutral ground (comparing to current situation)

cons:

community needs to be re-established as right now it is dispersed
generic organization can impact discoverability as such org might become a place for too many repositories

organization dedicated to prometheus-operator
pros:

same as above
slightly increases discoverability by focusing only on prometheus-operator

cons:

same as above, but without the problem of having too many repositories

Looking at those options I would prefer if we moved to prometheus-operator organization as suggested by @brancz

+1 from me for moving to prometheus-operator org

Same for me, I think that the prometheus-operator organization is the best choice.

I'm in favour of organization dedicated to observability so that we don't spread our 15 projects across 10 different orgs, but wouldn't block having an prometheus-operator org, if that's the overall consensus.

I just realized that there were discussions in various directions in the past, and I want to make sure we're explicit in these, I personally think we should put the prometheus-operator in the prometheus-operator org, and kube-prometheus into it's own (maybe kube-observability?). That way we can emphasize the separation of the projects much like we always desired (RE https://github.com/coreos/prometheus-operator/pull/3333#issuecomment-662294842), while also emphasizing on the scope of each project individually.

I personally think we should put the prometheus-operator in the prometheus-operator org, and kube-prometheus into it's own (maybe kube-observability?)

I don't agree, separation on repository-level is fine, but those two projects are connected to each other and IMHO should belong to the same org.
Additionally in such case where do, we want to put helm charts and handle issues about it?

Additionally in such case where do, we want to put helm charts and handle issues about it?

In the respective org. I think that would actually be good for people to understand the separation, I don't feel too strongly about it though.

Such an approach immensely decreases project discoverability and clouds how projects are connected to each other.
One more thing to consider is how issues are created and what features GitHub offers here. We currently have quite a lot of issues which are in respect to helm charts or to kube-prometheus and we probably will always have such reports in prometheus-operator repository. With repositories in one org, such issues can be easily moved to respective repository providing better developer experience. With multiple orgs it is not possible and people need to recreate their issues in other repos.
If we want it or not, prometheus-operator and kube-prometheus are strongly connected to each other even when kube-prometheus has different scope.

how projects are connected to each other.

Well the intention is precisely to emphasize the difference and independence of the projects. :)

They are already independent as they live in different repositories. I think separation on a higher level (organization) would impact developer workflows without any additional benefits.

There's no reason why it would be final, so I'm happy with keeping them together for now, and should there be more voices in the future then we can still change the direction.

After migration, we should publish images into 2 repositories on quay (old one and new one) for 1 or 2 release cycles.
A good example of pushing to 2 repositories is in https://github.com/coreos/prometheus-operator/pull/3258

Creating many images is not a problem indeed, we do that on Thanos as well: https://github.com/thanos-io/thanos/blob/master/.circleci/config.yml#L79
In terms of org, I think I am with @metalmatze and would vote for organization dedicated to observability We can have totally different projects there with different maintainers and different governance. Then even if it's worse for discoverability now, it might be better once we build some reputation there.

I don't agree, separation on repository-level is fine, but those two projects are connected to each other and IMHO should belong to the same org. (re kube-prom and prom-op)

This also makes it easier to reason about if we would have a single org for both of them.
Anyway, as Matthias, I happy with prometheus-op org as well, don't want to block.

Closing as this is done after https://github.com/prometheus-operator/prometheus-operator/pull/3384 and https://github.com/prometheus-operator/kube-prometheus/pull/630


Ruby version compatibility

Recent changes (this one in particular, perhaps others) have broken compatibility with older Ruby versions (notably, pre 2.7). This is in conflict with the gemspec, which indicates compatibility with Ruby 2.5+.

Thanks for letting me know, I'll fix this.

I'm not testing further back than 2.7.0 - I apologies this may have caused some problems for you. So, for now, if you are using Ruby < 2.7 I recommend pin to ~> 1.5.0.
I might yank the 1.6.0 and 1.6.1 releases.

Okay, yanking done, 1.16.0 and 1.16.1 are gone, and https://rubygems.org/gems/console/versions/1.16.2 requires >= 2.7.
Hope this addresses the issue.

The issue only ever manifested in our CI system, thankfully. Our dependency on console is transient (through async), so pinning the version would require us to introduce a direct dependency on console.
Updating the version requirement has resolved the issue. Thank you for the prompt response!

it still breaks on ruby 2.7.0 - 2.7.2
https://github.com/socketry/console/blob/main/lib/console/progress.rb#L76

@output.info(@subject, ...)
syntax error, unexpected end-of-input, expecting `end'

the new syntax is fully supported since ruby 2.7.3

@ahorek thanks, I didn't know it. I'll set the minimum version to be 2.7.3.
Thanks!


SDK update for ADF ExecuteSsisPackageActivity

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please add REST spec PR link to the SDK PR
[ ] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

The REST spec PR link is: https://github.com/Azure/azure-rest-api-specs/pull/2102

I use generate.cmd file to generate the SDK. But I don't know why the datafactory_resource-manager.txt file didn't update the REST spec commit version information.

Hi @shahabhijeet , could you review the PR? We are quite closed to our time line. Thanks a lot for your help!

Hi @shahabhijeet , I already merged the conflicts. Could you help review?  By the way, why the "default" check is keep in "waiting for status to be reported" status since I have no conflict now?

@hvermis can you approve this PR

@shahabhijeet , could u help merge my change to master branch?

Hi @shahabhijeet , all checks have passed now. Please help review and merge the PR. Thanks a lot.


SOMEONE HELP ME PLEASE!!

How do I use this stuff to make a bot. Am i supposed to copy this stuff and put in Python. If so where do I put it and how do I put it in. I want this to be done for adidas, so I can try and get the BAPExNMD shoes releasing on November 26th. Thanks in advance!!!

Join the slack group https://slack-invitation-app.herokuapp.com

ok


[IZPACK-1022] Missing i18n key

Synchronized all the language packs with English language pack.
Written a Groovy script to do so
All the language pack XML files are in UTF-8 encoding

Need to make some changes.


export namespace compiled failed in create-react-app

🔎 Search Terms
create-react-app
export namespace
namespace nest
🕗 Version & Regression Information

This is a crash
This changed between versions 3__ and 5_
This is the behavior in every version I tried, and I reviewed the FAQ for entries about namespace and module_____
I was unable to test this on prior versions because it only reproduce at project instead of web playground_____

⏯ Playground Link
https://github.com/yangguansen/typescript-bug-report
💻 Code
test-ts.ts
export namespace RuntimeStatus {

	export namespace Progress {
		export interface Quantity {
		  total?: number;
		  completed?: number;
		  unit?: string;
		}
		// export const a = '1';
	}

	export enum Severity {
		UNSPECIFIED = 0,
		NOTICE = 1,
		WARNING = 2,
		ERROR = 3,
		CRITICAL = 4,
	}
}

App.tsx
import './App.css';
import { RuntimeStatus } from './test-ts';

const a: RuntimeStatus.Progress.Quantity = {
  total: RuntimeStatus.Severity.ERROR
};
function App() {
  return (

          Edit src/App.js and save to reload.

          Learn React

  );
}

🙁 Actual behavior

🙂 Expected behavior
it shouldn't has error report
Additional information about the issue
Reproduce steps:

create a new project from create-react-app@5
add test-ts.ts file like above and import this file at a *.tsx file
then it report an error, but i think it shouldn't has error.

That doesn't look like a TypeScript error, but an issue with your tooling. Probably due to Babels impartial namepace support.

Thanks for reply, i already had this plugin @babel/plugin-transform-typescript, but it not compiled correct, and if i remove export namespace, it compiled correct.
See the compiled code in error img, it had export inner function, which may should not inner function.

That plugin is maintained by the Babel team.  If there's a bug here, you'd have to file it with them.  The code works properly in the Typescript compiler.

Okay, thanks, I will report it to Babel


Add a license

Please consider adding a license file to this repository so that others know under what conditions this code may be used.

I have added an MIT license. Thanks.


Hide private completion items unless allowed

Motivation

My original motivation for this change is that I wanted a way to only show
keyword completion items if there was no explicit receiver. It turns out that
"no explicit receiver" is also the criteria in which private methods are
allowed to be called, and also hiding private method completion items seems
like a nice to have, so this PR kills 2 birds with one stone (well, the keyword
completion change is stacked on this PR).
Test plan

See included automated tests.

My one thought is that it would be nice if we didn't have to add another several bytes just for a single bit of information on the relevant CFG instruction, but I don't think that's at all a blocker (and I didn't see anywhere that looked promising in terms of storing that flag.)


Disable openssl timeout

Generating DH params on slow machine can take more than half an hour…
We have 50.00 BogoMIPS machines here :cold_sweat:!

Also, I don't understand why this value was a String… Is there a particular reason I am not aware of for preferring String instead of Integer?

I think just old code mostly.  This module was started on Puppet 2.x I think.  Thanks for the patch!


[DRAFT] Partial docfx fix - Missing some plugins

This is a leg more on the fix @paulirwin have been trying out for solving #911
This is based on the commits @paulirwin made here: https://github.com/paulirwin/lucene.net/tree/issue/911
Use this to finish off the what is left to have docfx fully working.
What did I add?

Replaced toc.yml
As mentioned here there was a problem with the toc.yml being locked this was fixed by changing the path to "./toc.yml" instead of toc.yml".

Added small delay when building site output.

While the first fix solved the problem I noticed in one case when running locally that the file got locked anyway therefore I added a 1 second delay between starting new site out builds and haven't seen the error since.

Fixed the links to the assets (js and css)

When starting the docs site locally the pages weren't showing the CSS or using the js files because the route was wrong due to the missing _rel variable, therefore, I've added a slash / before all uses of these files so it works locally and removed the ending slash from the docfx.global.subsite.json.
docfx.vendor.css was also changed to docfx.vendor.min.css. docfx.vendor.jswas also changed todocfx.vendor.min.js`

Added an environment variable replacement postprocessor

I'm not sure if it works in all cases that it should but I've created a EnvironmentVariableProcessor that makes sure to replace EnvVar:ENVIRONMENT_VARIABLE to the actual value of the environment variable. As far as I could tell this is only used on the index page but I have no idea if this is correct. I haven't replaced the other plugin modules in these changes so that is still missing.

Next step
@paulirwin or @Shazwazza feel free to take these changes and finish them off 😄
I think the only thing missing is the remaining commented out plugin files otherwise it looks to be working.
How I've been testing
I've used the following command to test it.
./websites/apidocs/docs.ps1 -ServeDocs -LuceneNetVersion 4.8.0-beta00016 -BaseUrl http://localhost:8080

Thanks for this! I'm going to merge this into an issue branch in this repo for collaboration. I was seemingly able to fix the toc locking by setting maxParallelism to 1. Obviously not ideal for performance, but reliability > performance right now, and it's still not too slow.

I have merged this with my work into this issue branch: https://github.com/apache/lucenenet/tree/issue/911
We can now use this branch to finish up collaboration on this issue. Note though that I am getting an error building your plugins changes, not sure why. However, it's great that running with -DisablePlugins now works for the libraries! This is a huge boost to progress, thank you. I'll be digging into this more soon.

This is great. That would explain why I saw it choke when the 3rd part JSON parser tried to read the ToC.
As for the version numbers, we ended up resorting to using Powershell to update them here: https://github.com/apache/lucenenet/blob/0d7bba7a42a89a3e348c6c27370425b4db33b492/websites/apidocs/docs.ps1#L182-L192. We tried several times to get the plugins to do that for us, but they don't seem to work in any section of the page, only in certain sections (for example, we couldn't replace the version number inside of a code block using the plugin).

I think we should be able to do that with plugins now as a post-processor! IIUC, anyways.

I was able to fix the plugin build error by excluding some files that were using the old docfx SDK. I went ahead and excluded the rest of those files that were commented out, no reason in keeping them in the csproj. By the time we merge this we should remove those from source control (they will of course always be available in prior version history if needed).
I'm testing this now and will review the rest of the plugin code to see what all is needed to be implemented. This is very exciting to use the latest docfx!

Hmm...the whole thing is in Powershell, except for the DocFx bit :). I suggest you have a look at the Docs and Website Documentation and the build automation for the docs and the website. They are set up to build the docs and then submit a PR to the lucenenet-site repo (although, the trigger isn't working and it requires starting manually).
Also, if you checkout the tag for beta00016, you should be able to run the build prior to the DLL conflict to see it work. Ideally, the UX and procedure won't have to change for the upgrade.

Sorry, I was meaning replacing the "HACKs" you were referring to here: https://github.com/apache/lucenenet/pull/958#issuecomment-2351946840
We at least should be able to do that for the CLI index. I'll look into it.

The CLI docs version replacement was an easy change, made that use EnvVar:LuceneNetVersion since that works in fenced code blocks now. Removed that from the ps1 script; the rest are TOC/breadcrumbs replacements that I think should stay for now.
Next up I'll be looking into why the header links aren't working, but once that is working we should be in good shape for the API docs site.

@nikcio I have included your commit in #961 so I'll close this PR. Thanks!


Bug in 1.13.40: Integration with C/C++ extension not work

Brief Issue Summary
Workspace (single- or multi-root, no difference), contain CMakeLists and integraion not work, so IntelliSense cannot to resolve target's includes.
CMake Tools Diagnostics
{
  "os": "linux",
  "vscodeVersion": "1.74.2",
  "cmtVersion": "1.13.40",
  "configurations": [
    {
      "folder": "<suppressed>/Linux_Ecosystem/software",
      "cmakeVersion": "3.25.1",
      "configured": false,
      "generator": "Unix Makefiles",
      "usesPresets": false,
      "compilers": {
        "C": "/usr/bin/gcc",
        "CXX": "/usr/bin/g++"
      }
    }
  ],
  "cpptoolsIntegration": {
    "isReady": false,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": null
    }
  ]
}

Debug Log
[main] Building folder: software
[main] Saving open files before configure/build
[build] Starting build
[driver] Start build component.app
[proc] Executing command: /usr/bin/cmake --build /home/gs/Projects/Linux_Ecosystem/software/code/component-storage/build --config Debug --target component.app -j 6 --
[proc]   with environment: {"ELECTRON_RUN_AS_NODE":"1","HOME":"not shown","VSCODE_CODE_CACHE_PATH":"/home/gs/.config/VSCodium/CachedData/d2c422ca15f1fbc976eed3e02e3392bbb39c5824","VSCODE_IPC_HOOK":"/run/user/1000/vscode-e7a6ce01-1.74.2-main.sock","VSCODE_PID":"12359","_":"/usr/share/codium/codium","VSCODE_AMD_ENTRYPOINT":"vs/workbench/api/node/extensionHostProcess","VSCODE_HANDLES_UNCAUGHT_ERRORS":"true","NINJA_STATUS":"[%s/%t %p :: %e] "}
[build] [100%] Built target component.app
[cmakefileapi-parser] Read reply folder: /home/gs/Projects/Linux_Ecosystem/software/code/component-storage/build/.cmake/api/v1/reply
[cmakefileapi-parser] Found index files: ["cache-v2-287207a3e20f081ff670.json","cmakeFiles-v1-1fd6b7d892a9a7092de5.json","codemodel-v2-b96440cf5142156de93b.json","directory-.-Debug-0fb0cd9d86efeb49e89b.json","index-2023-01-22T10-13-43-0843.json","target-component.app-Debug-16b7b4a95b3d67e6acc0.json","toolchains-v1-7a080570022a503803c8.json"]
[build] Build finished with exit code 0
[extension] [4170] cmake.build finished (returned 0)

Additional Information
Steps to reproduce:

Clone https://github.com/AVAtarMod/Linux_Ecosystem
Open cloned folder in VSCode (I use VSCodium)
Enable ms-vscode.cpptools and ms-vscode.cmake-tools extensions.
Build CMake project in code/component-storage directory.
Run command C_Cpp.ConfigurationProviderSelect (C/C++: Change Configuration Provider...) in vscode's Command Pallete.
You see nothing

Can you share more instructions?  When I try to configure/build this project I get:
[main] Configuring project: Linux_Ecosystem
[proc] Executing command: /usr/bin/cmake --no-warn-unused-cli -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_C_COMPILER:FILEPATH=/usr/bin/gcc -DCMAKE_CXX_COMPILER:FILEPATH=/usr/bin/g++ -S/home/bob/git/Linux_Ecosystem/code/component-storage -B/home/bob/git/Linux_Ecosystem/build -G Ninja
[cmake] Not searching for unused variables given on the command line.
[cmake] -- Configuring done
[cmake] CMake Error at CMakeLists.txt:6 (add_executable):
[cmake]   Cannot find source file:
[cmake]
[cmake]     secrets.h
[cmake]
[cmake]   Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
[cmake]   .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
[cmake]
[cmake]
[cmake] CMake Error at CMakeLists.txt:6 (add_executable):
[cmake]   No SOURCES given to target: component.app
[cmake]
[cmake]
[cmake] CMake Generate step failed.  Build files cannot be regenerated correctly.


Add ruby 2.7.0-preview2 to Ubuntu machines

Add ruby 2.7.0-preview2 to Ubuntu machines.
Announcement: https://www.ruby-lang.org/en/news/2019/10/22/ruby-2-7-0-preview2-released
Currently my build using this version fail:https://travis-ci.org/jasnow/rack-pjax/jobs/602379057

Checked - appear to be there now.


Service page in django admin is not properly displayed

The service page seems to work well when I use the master branch.

For me as well. But on the live server this is not happening.
Maybe some static files missing?

There is no  element in response.

It is weird. The Layer page works well. They are both supposed to be generated automatically (https://docs.djangoproject.com/en/1.11/ref/contrib/admin/).  There is no  element return. The response status is 200 OK.


Phone level recognition

Hello, thank you for this great work! I would like to get the phone recognition level. Does PyKaldi have a function for that ?

PyKaldi is just a wrapper around Kaldi, that said, you can train phone recognition models with Kaldi, see for example the TIMIT recipe in Kaldi.  Probably you can also use some output of TDNN-HMM nnet3 models. Basically the posteriorgram (forward propagation through the neural network part) of most TDNN-HMMs recipes in Kaldi egs is actually mono-phone, so you could use that as well.


Unable to get the output in CSV file

Describe the bug

Unable to get the output of gitleaks detect in CSV format.
There is no option to save the output of gitleaks detect to a file (CSV\JSON)

To Reproduce
gitleaks detect -v -s file_path -f csv
Expected behavior
The output was expected to be in CSV format with each row with a comma seperated delimiter.
Screenshots
If applicable, add screenshots to help explain your problem.
Basic Info (please complete the following information):

OS: Windows 10
Gitleaks Version: 8.8.12

Additional context
Add any other context about the problem here.
cc @zricethezav

@jasaz you're missing -r, --report-path  as defined I the usage section of the readme https://github.com/zricethezav/gitleaks#usage


payment, front end and cocorico news

Q
A

Bug report?
[ ]

Feature request?
[x ]

Support request?
[x ]

Hello,
1/ How can i set a methods payment like credit card with mangopay for example ?
2/ How can i customize front end in cocorico ?
3/ How change cocorico news ?
Thank you

Hello,

1/ How can i set a methods payment like credit card with mangopay for example ?

You need to implement it.

2/ How can i customize front end in cocorico ?

CSS are in web/css folder :
all.css
all-override.css
fullcalendar-override.css

JS are in web/js folder:
common.js
date-time.js
jquery.main.js
jquery.main-override.js

Twig templates are in Bundles "view" folder  and main layout is in app/views folder.

3/ How change cocorico news ?

You need to modify the  parameter cocorico.home_rss_feed in file src/Cocorico/CoreBundle/Resources/config/parameters.yml:14

Great, thanks for your reply


Update plan-connect-performance-factors.md

added note:
"Back-up of ADSync Database using Azure Backup is not recommended."

@billmath

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Introduce Finance Calculator

As of July 08th, 2020: The tips calculator is not done yet!! If anyone can help me with the BooltoVisibility converter, that would be great! (P.s. this is still a draft pr)
Fixes #806 .
Description of the changes:

A new calculation mode, "Financial"
Includes Compound Interest Calculator
A tip calculation mode (Not started as of 08th July)

How changes were validated:

Manual

Note: In code, Financial mode is always mentioned as "FinanceCalculator" for shortness and consistency.
Also, if you have an idea or can tell me how to use the BooleanToVisibility converter that would be nice. Thanks.

To change modes between tip calc and compound calc, there's a Combobox but it currently does not work as I can't figure out how to do grid visibility with BooleanToVisibility.

Also, what other kinds of financial calculation modes would you like to see? I guess if it has more then two modes, we can’t use a Boolean for the combo box.

Can someone take a look?

Thanks for jumping into the code here--but I think there are many undecided details about how the feature should work which need to be resolved before looking at the code. For example, I'm not sure that we should group both the compound interest and tips calculators under one "Finance" mode.
Let's follow this project's new feature process and work on a spec document which describes how the feature will work. The spec document can be changed faster than the code can and it's easier to share more widely for feedback. Once that document looks good we can move into the "Implementation" phase and reopen this PR.

Spec pull made! Look at the spec and go give some feedback!

Also, can anyone help me (see gif below, once one grid is loaded, another should collapse but that doesn't happen)?

Also, can anyone help me (see gif below, once one grid is loaded, another should collapse but that doesn't happen)?

I think its a problem with this part of the code, you are setting the DataContext to be the GraphingCalcViewModel instead of your view model.
`
void MainPage::EnsureFinanceCalculator()
{
if (!m_financeCalculator)
{
m_financeCalculator = ref new FinanceCalculator();
m_financeCalculator->Name = L"FinanceCalculator";
m_financeCalculator->DataContext = m_model->GraphingCalcViewModel;
    GraphingCalcHolder->Child = m_financeCalculator;
}

}
`

Alright. Will look into it. Thanks
From: Pepe<EMAIL_ADDRESS>Sent: July 14, 2020 15:52
To<EMAIL_ADDRESS>Cc: Eric<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/calculator] Introduce Finance Calculator (#1306)
Also, can anyone help me (see gif below, once one grid is loaded, another should collapse but that doesn't happen)?
[Calculator Financial Mode Change]https://user-images.githubusercontent.com/47545798/87271539-5cd0b700-c488-11ea-89ce-7a22f851339f.gif
I think its a problem with this part of the code, you are setting the DataContext to be the GraphingCalcViewModel instead of your view model.
`
void MainPage::EnsureFinanceCalculator()
{
if (!m_financeCalculator)
{
m_financeCalculator = ref new FinanceCalculator();
m_financeCalculator->Name = L"FinanceCalculator";
m_financeCalculator->DataContext = m_model->GraphingCalcViewModel;
GraphingCalcHolder->Child = m_financeCalculator;

}
}
`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/calculator/pull/1306#issuecomment-658451518, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RT74IOEYTSSRNU3ZFLR3TOSXANCNFSM4OVEJQ5Q.

Hmm... Still happens...


luci-app-statistics: render all graphs on refresh if no summary

In the past, a summary page would usually be generated for the data, but this did not occur when there was only a single instance (e.g., a single Wi-Fi interface). As a result, the refresh mistakenly requested the summary instead of the available data.
i.e. graphs would mysteriously disappear on refresh.
See #6468 for more context.

[x] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
[x] Each commit has a valid :black_nib: Signed-off-by<EMAIL_ADDRESS>row (via git commit --signoff)
[x] Each commit and PR title has a valid :memo: <package name>: title first line subject for packages
[x] Tested on: private fork of 23.05 - haven't tried on master; my apologies.
[ ] ( Preferred ) Mention: @ the original code author for feedback
[ ] ( Preferred ) Screenshot or mp4 of changes:
[x] Closes #6468
[x] Description: (describe the changes proposed in this PR)

Merged. Thanks @wryun


Setup without SetupHelper

The purpose to install SetupHelper and RpiGpioSetup is right now merely to get the digital Inputs working.
Just install the gpio_list and VenusGpioOverlay.dtbo does currently not do the trick currently. Still need to use SetupHelper and (modified) RpiGpioSetup.... Strange...

Issue solved by keeping the gpio_list, remove the Overlay and use the gpio directive in the config.txt.
See: https://www.raspberrypi.com/documentation/computers/config_txt.html#gpio-control


Language Packs Support

Just like https://github.com/microsoft/vscode-loc.

We're not going to support this as it's specific to VSCode. At some point there will be proper translation support see: https://github.com/lapce/lapce/issues/2236


Bump cmdliner version constraint

Due to usage of Cmdliner.Term.Syntax introduced in 4d96f2bdebfe53ff6b97b152292403c14adc5dc7 which is new in cmdliner.1.3.0.

Alternatively we can drop the let-syntax...

looks good to me, thanks


DRILL-7722: Add reproducer unit test

DRILL-7722: Add reproducer unit test
Description
Add a unit test that demonstrates that a view with UNNEST cannot be sucessfully queried.
Documentation
Fixing the bug will make documentation as-is correct
Testing
The added test fails.
A slightly modified test that does not use the view, but directly executes the view query, passes:
$ git diff
diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java b/exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java
index 1a92e192f..7c317f427 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java
@@ -857,7 +857,8 @@ public class TestViewSupport extends TestBaseViewSupport {
         DFS_TMP_SCHEMA,
         null,
         viewSQL,
-        "SELECT * FROM TEST_SCHEMA.TEST_VIEW_NAME LIMIT 4",
+        //"SELECT * FROM TEST_SCHEMA.TEST_VIEW_NAME LIMIT 4",
+        viewSQL + " LIMIT 4",
         baselineColumns("customer_id", "order_id"),
         baselineRows(row(1.0,  1.0),
                      row(1.0,  2.0),

The test fails in the same way as already reported in JIRA
https://github.com/apache/drill/runs/715619115?check_suite_focus=true#step:6:10828

The underlying issue was fixed in https://github.com/apache/drill/pull/2602.


possible to add custom messages?

I have a use case where I would like to be able to post on behalf of the bot, what would i need to do in order to achieve that? Would it be creating a custom command?

Yeah, a custom command would be the easiest way to do this. There are a few ways to go about this - either the "official" bot command API, or simply look for a specific pattern at the beginning of incoming messages to trigger the command.
I've purposesly avoided adding commands to the bot, so I don't plan to add anything like this.

thank you! great repo btw :)


Failing test for subscribing twice.

Because QueryManager uses a map of queryResults: queryId => result, and queryListenerForObserver checks diffs against query results, next() callbacks don't trigger for the second subscriber.
This is a particular problem as observer.result() internally uses a subscriber, so it's not even that unusual a use-case.

This PR now includes a fix.

Lgtm, do you want to rebase and merge?

Will do, thanks


fix: add default value to max-jobs-per-timespan

Fixes issue #3042.
QC

[ ] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[ ] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced a default value for the --max-jobs-per-timespan argument, enhancing usability and preventing potential errors for users who do not specify a value.

Improvements

Refined logging logic to prevent unnecessary log clutter when no jobs are selected, improving clarity and performance.
Enhanced job selection logic to efficiently handle cases when no free jobs are available, reducing unnecessary processing.

I think it should work fine already now, but let us add an assertion: https://github.com/snakemake/snakemake/pull/3066

Ok there was a bug. Here is the fix: https://github.com/snakemake/snakemake/pull/3067

Closing this in favor of the fix. But thanks a lot for the detective work and pointing me to the issue!


feat: Add sign and send all transactions feature

This pull request introduces a new feature for handling multiple transactions in the Solana blockchain.
The most important change include the addition of  SolanaSignAndSendAllTransactionsFeature feature.
Currently SignAndSendTransactionFeature does support passing multiple transactions, but the interface is a bit cumbersome in the context of sending multiple transactions. In SignAndSendTransactionFeature, transaction send mode (parallel/serial) is configured on a per transaction basis, which creates ambiguity when user configures mixed sending modes in a list of transactions.
With SolanaSignAndSendAllTransactionsFeature, send mode is configure once for all passed transactions.

This looks good and is inline with previous discussion on https://github.com/anza-xyz/wallet-standard/pull/35
I think we should probably remove the mode option from SignAndSendTransactionInput, rename SignAndSendTransactionMode to SignAndSendAllTransactionsMode, and move that to here.
It's not actually used by SignAndSendTransaction so we shouldn't have it in two places. This is technically a breaking change but since there should be no implementing consumers of this I think it's fine to do it as a minor release.
@0xproflupin?


Allow to reproduce a CI run locally using libvirt

With the new job layout involving 3 nodes (CRC, Compute and an Ansible
controller), we have to provide people a way to reproduce such a job.
This patch extends the libvirt_manager role, as well as create a new
kind of "scenario" for reproducers. The intend there is to get multiple
"layouts" in order to mimic CI runs on a local environment.
As a pull request owner and reviewers, I checked that:

[x] Appropriate documentation exists and/or is up-to-date:

[X] README in the role
[X] Content of the docs/source is reflecting the changes

/lgtm
We will improve it later.

e2e job failed because CRC failed to start - but it's not related to this change.
I won't obsess on rechecks.

I wonder can you swap the "default" and the "crc"  ip ranges than the network order.
in-order to leave the "default" as-is .

Looks like If I use the "default" network as this change state
for example the https://ci-framework.readthedocs.io/en/latest/quickstart/04_non-virt.html  way stops working AS-IS.
I  restore the original default net.

/approve


Storage example should show how to set ACL

ACLs are not even mentioned in the examples. Example needs to show both how to set a specific ACL and how to set a PredefinedAcl.
When I use this this code, the console Cloud Storage viewer does not show items as shared publicly:
storage.create(coverBlob, coverImage,
	BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ));

So it's not clear what this code is supposed to do.
Am I right to assume that ACL should be set on BlobInfo like this?
    .acl(Arrays.asList(Acl.of(User.ofAllUsers(), Role.READER)))

If this is correct, is it enough, or should be used together with BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ)?

ACLs and predefined ACLs are concepts of Cloud Storage with a dedicated documentation page that should help you understand the different between ACLs and predefined ACLs. We kept the same name so that users familiar with Storage concepts should feel quite at home.
The following code:
storage.create(coverBlob, coverImage,
    BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ));

Sets the predefined ACL to PUBLIC_READ, predefined ACLs are documented by the service here. The PUBLIC_READ predefined ACL corresponds to setting the following permissions:

Object owner gets OWNER access
allUsers get READER access

I just tried the code and the created blob is correctly shown in the web Console as "Shared publicly".
This other code:
.acl(Arrays.asList(Acl.of(User.ofAllUsers(), Role.READER)))

Sets the ACL for the blob (a much finer control is possible, when compared to the sole predefined ACLs). In your code you are just setting following permission:

allUsers get READER access

Even in this second case the web Console correctly marks the blob as "Shared publicly".
If your goal is to make a blob publicly available both codes will do it.

This is how objects look in my bucket when I upload them with the PredefinedAcl:

As you can see, Share Publicly checkbox is missing. Selecting objects and pressing "Share Publicly" button has no effect.

As I said previously I tried this code (and several other combinations):
storage.create(BlobInfo.builder("my-bucket", "test-acl").build(),
    BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ));

storage.create(BlobInfo.builder("my-bucket", "test-acl-with-content").build(),
    "Hello, ACL!".getBytes(), BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ));

And it works just fine:

Are you sure you are using the code you shared to create the blobs? If you then get them with cloud-java what does blob.acl() contain?

Yes, I copied the exact code that I use.

I tried accessing these images from an unauthenticated browser, and they do show up. So missing checkboxes from the Cloud Storage viewer is the only problem/source of confusion.

Note that if I rename the object, the checkbox appears (unchecked, which is the expected behavior).

Maybe @brandonY has some insights why the Cloud Storage Viewer behaves that way.

This is weird. Now I am experiencing the problem as well, and it seems not to be a problem with just the web console. If I create a blob:
storage.create(BlobInfo.builder("my-bucket", "test-acl").build(),
        BlobTargetOption.predefinedAcl(PredefinedAcl.PUBLIC_READ));

The HTTP response (to the uploading POST request) correctly has the expected ACLs:
{
 "kind": "storage#object",
 "id": "my-bucket/test-acl/1463505795940000",
 "selfLink": "https://www.googleapis.com/storage/v1/b/my-bucket/o/test-acl",
 "name": "test-acl",
 "bucket": "my-bucket",
 "generation": "1463505795940000",
 "metageneration": "1",
 "contentType": "text/plain",
 "timeCreated": "2016-05-17T17:23:15.931Z",
 "updated": "2016-05-17T17:23:15.931Z",
 "storageClass": "STANDARD",
 "size": "0",
 "md5Hash": "1B2M2Y8AsgTpgAmY7PhCfg==",
 "mediaLink": "https://www.googleapis.com/download/storage/v1/b/my-bucket/o/test-acl?generation=1463505795940000&alt=media",
 "acl": [
  {
   "kind": "storage#objectAccessControl",
   "id": "some-id",
   "selfLink": "some-link",
   "bucket": "my-bucket",
   "object": "test-acl",
   "generation": "1463505795940000",
   "entity": "some-entity",
   "role": "OWNER",
   "entityId": "some-entity-id",
   "etag": "some-tag"
  },
  {
   "kind": "storage#objectAccessControl",
   "id": "my-bucket/test-acl/1463505795940000/allUsers",
   "selfLink": "https://www.googleapis.com/storage/v1/b/my-bucket/o/test-acl/acl/allUsers",
   "bucket": "my-bucket",
   "object": "test-acl",
   "generation": "1463505795940000",
   "entity": "allUsers",
   "role": "READER",
   "etag": "CKD93/jP4cwCEAE="
  }
 ],
 "owner": {
  "entity": "my-entity",
  "entityId": "my-entity-id"
 },
 "crc32c": "AAAAAA==",
 "etag": "CKD93/jP4cwCEAE="
}

However if I GET the object the ACLs disappeared:
{
 "kind": "storage#object",
 "id": "empty-test-bucket/test-acl/1463505795940000",
 "selfLink": "https://www.googleapis.com/storage/v1/b/my-bucket/o/test-acl",
 "name": "test-acl",
 "bucket": "my-bucket",
 "generation": "1463505795940000",
 "metageneration": "1",
 "contentType": "text/plain",
 "timeCreated": "2016-05-17T17:23:15.931Z",
 "updated": "2016-05-17T17:23:15.931Z",
 "storageClass": "STANDARD",
 "size": "0",
 "md5Hash": "1B2M2Y8AsgTpgAmY7PhCfg==",
 "mediaLink": "https://www.googleapis.com/download/storage/v1/b/my-bucket/o/test-acl?generation=1463505795940000&alt=media",
 "crc32c": "AAAAAA==",
 "etag": "CKD93/jP4cwCEAE="
}

/cc @Capstan

You need the full projection to get ACLs on normal gets. If you provide an ACL on create or update, you'll get an acl in the response, but otherwise you need to specify full there as well.

@Capstan I am using full projection to get the blob.
What I believe is happening is that the blobs are being created with a service account while the console is being accessed with a different account and thus has no access to the ACL information (@volgin can you confirm you are running this scenario?)
For the console to show the "Shared publicly" mark I used:
storage.create(BlobInfo.builder("my-bucket", "test-acl")
    .acl(Arrays.asList(Acl.of(User.ofAllUsers(), Acl.Role.READER),
        Acl.of(new User("my@email.com"), Acl.Role.OWNER))).build());

Where<EMAIL_ADDRESS>is the account I use to log to the web console.
@volgin regardless of the fact that you are not seeing the "Shared publicly" mark in the web console I believe they are being properly set.

@mziccard - You are correct.
It looks like a bug in web console: I can do anything I want with these objects (rename and delete), which indicates Owner access level, but I do not see the checkbox for "Share publicly".


[Marketplace] Deploy scripts and config

Add marketplace deploy script in PAI
split marketplace to three component:

marketplace-db
marketplace-restserver
marketplace-webportal

Each component can deploy independent.
Also add marketplace-restserver and marketplace-webportal to pylon.

Coverage remained the same at 34.223% when pulling 1895c3955bd41fec1ae7f99ccbb20d7f87530076 on yiyi/marketplace/deploy_update into acbec7be4ea89574fa87699456b1d8ee54150809 on master.

Test case:

Add marketplace config into services-configuration.yaml

cluster:
  common:
    marketplace: 'true'
marketplace-webportal:
  marketplace_api_uri: https://<pai-uri>/marketplace/api

build images:
e.g. ./build/pai_build.py push -i marketplace-db marketplace-restserver marketplace-webportal -c /cluster-configuration/

restart service:
./paictl.py service stop -n marketplace-webportal marketplace-db marketplace-restserver
./paictl.py service start -n marketplace-webportal marketplace-db marketplace-restserver

check the deployment:

[ ] visit https://<pai-uri>/marketplace/api and get Welcome to marketplace!
[ ] visit https://<pai-uri>/marketplace/plugin.js and view the marketplace js file.
[ ] set https://<pai-uri>/marketplace/plugin.js to webportal plugin config, and visit the marketplace page.


a fresh install of vcpkg and visual studio 2019 does not find header files

Describe the bug
I have installed the dependencies to a simple C++ project using vcpkg with x86 and x64 triplets. Previously, I installed vcpkg and the linkage to visual studio exactly as in the docs. However build of the sample code fails (see below) claiming not to find the header files.
I note that the environmental variable in visual studio VCLibPackagePath is set, but points to an empty folder vcpkgs\vcpkg.user below APPDATA  while the real data seems to be held below the following path: C:\Users\xxxxxx\source\vcpkg\packages
Th installation is a fresh one with latest versions.
Environment

OS: Windows 10.0.18362, VS 2019, clean new environment.
Compiler: revision
Microsoft Visual Studio Enterprise 2019
Version 16.4.2
VisualStudio.16.Release/16.4.2+29613.14

To Reproduce
Steps to reproduce the behavior:
1.
vcpkg install unittest-cpp boost-thread boost-iostreams mpir
vcpkg.exe install boost-thread:x64-windows boost-iostreams:x64-windows unittest-cpp:x64-windows mpir:x64-windows
Builds and installs the appropriate libraries etc.

See error
However on building the project that expects these dependencies visual studio produces errors like

LatticePathTests.cpp
1>C:\Users\tlyons\source\repos\terrylyons\libalgebra_tests\libalgebra\libalgebra\libalgebra.h(53,10): fatal error C1083: Cannot open include file: 'boost/thread/shared_mutex.hpp': No such file or directory
1>LibAlgebraUnitTests.cpp
1>C:\Users\tlyons\source\repos\terrylyons\libalgebra_tests\LibAlgebraUnitTests\LibAlgebraUnitTests.cpp(5,10): fatal error C1083: Cannot open include file: 'UnitTest++/UnitTest++.h': No such file or directory
1>HallSetTests.cpp
1>C:\Users\tlyons\source\repos\terrylyons\libalgebra_tests\libalgebra\libalgebra\libalgebra.h(53,10): fatal error C1083: Cannot open include file: 'boost/thread/shared_mutex.hpp': No such file or directory
1>makebm.cpp
1>memfile.cpp
1>C:\Users\tlyons\source\repos\terrylyons\libalgebra_tests\LibAlgebraUnitTests\memfile.h(3,10): fatal error C1083: Cannot open include file: 'boost/iostreams/device/mapped_file.hpp': No such file or directory

Expected behavior
A successful build was expected.
Failure logs
-(please attached failure logs)
Additional context
Add any other context about the problem here.

Hi @terrylyons thanks for posting this issue.
It seems that you can install these libs successfully and this issue appeared when you used them.
If so, could you help provide the project case and detail steps to reproduce?
Besides this, have you integrated with VS by the command ./vcpkg integrate install?

Hi @NancyLi1013, I worked from the command window using runas:domain\administrator cmd and not from powershell. So I used syntax like "vcpkg integrate install".
However, on return to this problem after your request, I ran the exact command you suggested from powershell in my user account (unelevated), and bingo!! it all worked as it should (dlls magically loaded etc). So perhaps integration is affected by the choices of elevated and\or which account does what...
Hope this helps.

We suggest use powershell to install ports and integrate with VS.
Please refer to readme and doc.

I had exactly the same issue, and i run both in poweshell and cmd window with vcpkg integrate install but still could not find the packages for visual studio....
In the cl.command.1.tlog file in my project folder, i found the line like below:
/I<path_to_vcpkg>\VCPKGINCLUDE
but what should be there is
/I<path_to_vcpkg>\VCPKG\installed\os_type\INCLUDE
i am using visual studio 2019 version 16.5.2 and vcpkg the latest from github.
Tried everything including reinstall vcpkg. or reinstall visual studio or different packages, but none worked....

Hi @shelper
Thanks for posting this issue.
Could you please help confirm if you encountered this issue when you used it?
Please also post the failures about this.

my bad, i think the integration works with visual studio, but not visual studio code.... sorry about that

Yes, Visual Studio Code is currently not supported yet.

Please add vcpkg integration with VS Code!!

@rhalbersma
As for the support for VS code, let's track this here #10217.

I have encountered the same problem, but only with VS2019 and not VS2017, with VCPKG version 2020.11.03, Visual Studio Community 2019 version 16.7.4, and Visual Studio Community 2017 version 15.9.14. I have used the Integrate command in both Powershell and command line, and in both administrator mode and non-administrator mode for both.
I tested it all again when following the video tutorial at https://www.youtube.com/watch?v=y41WFKbQFTw, because that exact video is linked in the official documentation at https://github.com/Microsoft/vcpkg#quick-start-windows (the last line in the "Examples" section).
Specifically, in VS2019 when I type "#include <SDL2/SDL.h>", I get the error "cannot open source file "SDL2/SDL.h"."
But when I try the exact same line in my VS2017 install, it autocompletes and compiles correctly.
I would greatly prefer to use VS2019 for my project, as some other libraries I need have very little compatibility with VS2017

@Chris45215
I can find SDL2/SDL.h with Visual Studio 2019 16.9.1 in cmake project.
Please open a new issue if you still have this problem.

Thanks @NancyLi1013, I was able to get it too work too - but only after I re-downloaded the entirety of PCL with vcpkg and used the instruction ".\vcpkg install pcl:x64-windows", instead of ".\vcpkg install pcl:x64-windows-static" which I had used earlier. I can make the new issue, but I'm not sure if it was just weirdness on my side, or if there is a significant difference between the static and non-static version (I can't find any description of the difference). I've only recently learned about very significant differences between the vcpkg version and the "compile from source" version (https://pcl-tutorials.readthedocs.io/en/master/compiling_pcl_windows.html), as I need to use the visualization libraries but those seem to be excluded from the vcpkg version.
I tried to use the AllInOne install initially, but it aborted because PATH variables were too long. So..... I've spent several days trying to get everything working, and this is quite a hill to climb. I really appreciate the help you provide, but I'm now on my 3rd completely different install method, and the downloads page for the dependencies in the "compile from source" guide doesn't even load (so I'm using https://gist.github.com/UnaNancyOwen/59319050d53c137ca8f3#file-pcl1-8-1-md to tell me the versions of the dependencies I need).... I'm at the point of questioning and doubting everything I'm doing. I've not made new issues because there is clearly a lot I don't know, and I don't want to send other people on a wild goose chase if I poorly document a problem.
Is there some easier way to install this that I somehow overlooked? I can't believe it's supposed to be this difficult just to get started.

@Chris45215
Thanks for your above details.
For static and dynamic, there are some differences between these two builds in usage.
Especially, for static build, there is some extra work that needs to be done.
Please see the doc here https://devblogs.microsoft.com/cppblog/vcpkg-updates-static-linking-is-now-available/


Feature request: support of 'half' crate.

The support of 'fixed' crate has been very useful and forward-looking.
Now, there is another very popular crate: half.
This crate implements half-sized floats, i.e. 16-bit floats which follow the IEEE754 standard.
It would be very helpful (and unique in the world) if kiddo would support types such as half::F16 and half::BF16.
Thank you for your time, and your awesome project!
Keep it on!

Great idea! I think this should be fairly straightforward, and I can gate it behind a feature. I'll look at doing f128 in a similar way, if it is feasible.
Thanks for the suggestion, and the encouragement! 👍🏼

Hi Marco,
It looks like Kiddo may already support f16 out-of-the-box with no changes required! You need to enable the num-traits feature of the half crate in order to get it to work.
See the example here: https://github.com/sdd/kiddo/pull/110/files#diff-c5a8e5aa531111094cd34349e31759268e663e8a937f5004aefc395fb3a30f55
I've not tested this extensively. Give it a try, and if you run into any issues, let me know and I'll see if I can help.

This is a great news! I will test it, thanks!

Support added in v4.2.0


fix(#9): Update norm

Updated minishell path in norm

I'm not sure it works, can job name contain spaces?

Add a way to manually launch this job from menus and cli by adding workflow_dispatch to the events which invoke it

That's an example from submit workflow, you need to replace push with pull request (and the syntax is weird)
on:
  workflow_dispatch:
  push:
    branches: main


What should be done to stabilize the API here?

I think with the recent work from @jakesandlund and @osheroff we've been bringing the Producer and Consumer APIs into parity and simplifying things a bit.
I'd like to push towards a 1.0 release with a stable API that we can all rely on and then move towards semver releases.
@osheroff please move the tickets you want to see in 1.0 accordingly, anything else we should aim to accomplish in 1.0?

one thing on my  todo list has been to allow librdkafka (and java) specific parameters to be passed in -- I need in some cases to limit the buffer size of rdkafka, and there's no elegant way to do this.
Other than that, to me a 1.0 is probably about trying to get feature parity best we can between java/rdkafka.  It's tricky since with 0.8.3 the whole java client will be rewritten, but hey.
Note that I've had a MRI-based consumer eating away at 5-10k QPS in zendesk's production for some months now; so at least the consumer path is pretty solid!

@osheroff you've got write access to this repository, will you create issues and stick them in the 1.0 milestone for all your wishlist items?

@rtyler Is there any plan to support librdkafka 0.9 ? I thought it would be nice, since kafka 0.9 already implemented balanced (high level) consumer, so I guess it would be possible to create consumer group for MRI.


Remove dist/ from source tree

I don't believe we need it anymore.

We will have to migrate the Bower package to another repository that will have dist/ checked out before removing it from the main repo.

Should we close this, until we lay down a plan for xterm.js 3, where we can deprecate/drop bower support?

Hi, sorry to ping a closed issue, but I would consider doing this sooner rather than later. One of the annoyances in debugging xterm.js against a project that uses it is that you train your users to link against dist/xterm.js by default. Let's say, then, that you want to test against master!

You try to just npm install against sourcelair/xterm.js. At first this seems like it succeeds but there appear to be no changes, even though you confirm that the commit ref is HEAD for sure.
You figure you just need to build the dist script, and that it's probably just not updated on every commit (true). You muck around with tooling a bit and manage to get a build going but you discover that the npm package doesn't bundle gulpfile.js, which is needed to build.
 There still appear to be no changes to your client code.
After 5 minutes of debugging you realize that the build process is copying results into /build and not /dist! You change your application to link against /build and start drinking.

I think xterm.js should follow codemirror's lead and not include /dist in the sourcetree and that FURTHERMORE on install from npm, it should build itself either on the spot or not at all. You can either install all build tooling on any npm install (fine by me) or just require the client application have some kind of build process capable of consuming xterm's entry point. Either way, I definitely think stale builds should not be packaged in /dist in the package source tree.

Publishing lib with files in package.json works well, I don't think we should be installing all the build deps as some take a lot of time to download.
Creating the bower distributable repo was a good idea.


Clarify the x-tokenInfoFunc interface

Hey! I really enjoy using this library, but I found it difficult at first to understand how the x-tokenInfoFunc interface was supposed to work.
This pull request adds some docs to the Security section to clarify how the x-tokenInfoFunc function works.
P.S. Thanks for all your hard work on this project - connexion is my new favorite way to build APIs!

Thank you!

:+1:


Bee Dashboard not responsive

The bee dashboard seems not to be responsive in the current alpha state. This leads to reduced usability on small screen and mobile devices.

Now that the final layout has been finished the responsive layout has now been implemented, this will appear in a future release.

Great! Thanks 🙏


moodle: 3.8.3 -> 3.9

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/moodle/versions.
meta.description for moodle is: "Free and open-source learning management system (LMS) written in PHP"
meta.homepage for moodle is: "https://moodle.org/"
meta.changelog for moodle is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.9 with grep in /nix/store/zhbdhxsk4fb72c95ms270h1pwsnmqpm3-moodle-3.9

directory tree listing: https://gist.github.com/48723f04d23d6f6893103c721e1bee08

du listing: https://gist.github.com/35532c454fa453b757bf95bb895aa730

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
moodle

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zhbdhxsk4fb72c95ms270h1pwsnmqpm3-moodle-3.9 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A moodle https://github.com/r-ryantm/nixpkgs/archive/1a1f2b05923d75353acc6b8fe9a753c6fbc8475d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zhbdhxsk4fb72c95ms270h1pwsnmqpm3-moodle-3.9
ls -la /nix/store/zhbdhxsk4fb72c95ms270h1pwsnmqpm3-moodle-3.9/bin

Security vulnerability report

Security report (click to expand)

CVEs resolved by this update:
none
CVEs introduced by this update:
none
CVEs present in both versions:

CVE-2019-15536

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- moodle

Maintainer pings
cc @aanderse for testing.

@GrahamcOfBorg test moodle


How to introduce other post types

Hi @vitorfs or @sebastian-code
Just wondering what the best way to implement other post types such as attaching image or video, or sharing links (like how its done in Facebook),etc.
Even if you guys don't want to implement it, I'm doing the coding for my own forked project and was wondering the best way to go about this.
Thanks in advance.

Hi @richardsonsamuel, to be honest, I haven't tried something like that, the feature you're looking for was out of the original scope; that functionality is actually useful in just a few scenarios, but is pretty doable.
What I would suggest is than you require to tweak a little bit the model to allow the new content you want to add, but you have to modify a lot the UI, because there is where the main changes are going to be needed, I guess you'll need new templates for every post type, also would be helpful to modify the Form.
I don't know if that is what you were looking for, of if in any case I was helpful, I hope I did.
In any case, if you find it suitable, you always can suggest a new PR to include those changes in the project, just don't forget to include some tests.

Thanks this helps quite a bit. Closing the issue as all I needed was a bit of direction. Thanks again!


Error installing keras on macOS Sierra

After issuing
sh conda env create -f environment.yml
It fails when it gets to keras:

Could not import setuptools which is required to install from a source distribution.
Traceback (most recent call last):
  File "/Users/ejstembler/miniconda3/envs/carnd-term1/lib/python3.5/site-packages/pip/req/req_install.py", line 387, in setup_py
    import setuptools  # noqa
  File "/Users/ejstembler/.local/lib/python3.5/site-packages/setuptools/__init__.py", line 12, in
    import setuptools.version
  File "/Users/ejstembler/.local/lib/python3.5/site-packages/setuptools/version.py", line 1, in
    import pkg_resources
  File "/Users/ejstembler/.local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 74, in
    import appdirs
ImportError: No module named 'appdirs'

CondaValueError: pip returned an error.

This is on macOS Sierra, version 10.12.5 (16F73)
I also tried replacing - keras==1.2.1 with - git+https://github.com/fchollet/keras.git in environment.yml; same error.

@ejstembler haven't run into this one before. Which version of the conda installer are you using?

No recent responses, so I'll close this out, but the error would indicate the need to pip install appdirs.


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 08:42:29 on 2023.04.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 1, errors out: 0
Original problem ID: 17624
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=17624

Problem has been resolved in 3m 0s at 08:45:29 on 2023.04.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 17624


x/playground: func Test doesn't work in module mode: function main is undeclared

func Test(*testing.T) is not executed on https://go.dev/play when a go.mod file is provided.
What did you do?
This doesn't run: https://go.dev/play/p/ZDFf4aGucoB
package main

import (
	"testing"

	"github.com/stretchr/testify/assert"
)

func Test(t *testing.T) {
	assert.True(t, true)
}
-- go.mod --
module play.ground

require github.com/stretchr/testify v1.9.0

What did you see happen?
Output:
go: downloading github.com/stretchr/testify v1.9.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
# play.ground
runtime.main_main·f: function main is undeclared in the main package

What did you expect to see?
If I remove the go.mod, it runs correctly.
Example: https://go.dev/play/p/AsRNcxCRdWx
=== RUN   Test
--- PASS: Test (0.00s)
PASS

I am not sure this is a bug, there is in fact no main function in the main package.
Not-module-mode is now a special case, at least as I understand it.
@rsc (for go/build) and @golang/tools-team (for the playground).

Reproducible builds on the Go playground (enforced by locking dependencies with go.mod) are an important feature (even if still underused) to help bug reporters to demonstrate issues. A func(*testing.T) is a good way to convey that as the code provided can easily be integrated in a test suite.
This may not qualify as "bug" but "feature request" or "proposal", but I argue it is an important feature for the Go community.

On the bottom of go.dev/play it says

If the program contains tests or examples and no main function, the service runs the tests.

It sounds like we should either support this or update that text to make it clear it's not supported in module mode?
On the issue of reproducibility, it's harder to guarantee that what's on the playground is reproducible. The playground runs the build with -mod=mod which will pull in dependencies that are missing from an untidy go.mod and will set the module's go version (which controls language semantics) to the version of the go command that's running.

Duplicate of #32403


Syntax checker

Going through parse.py in master I noticed that the parser is responsible for checking whether we support the given AST, and if not, raising an informative syntax error. In Tangent we actually do this in a separate pass, which I think might be a good idea. It keeps the parser a bit cleaner (no need for checks) and separates two logical processes.
I also found a comment that says "maybe inherit from SyntaxError? Investigate." so I had a look, and it is a good idea. If you set the fields appropriately, it will automatically pretty print the error message with the filename, a little arrow, etc.
bartvm-macbookpro3:myia bartvm$ python myia/fence.py
Traceback (most recent call last):
  File "myia/fence.py", line 120, in <module>
    fence.visit(ast.parse(textwrap.dedent(inspect.getsource(f))))
  File "myia/fence.py", line 88, in visit
    self.generic_visit(node)
  File "/Users/bartvm/anaconda3/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "myia/fence.py", line 88, in visit
    self.generic_visit(node)
  File "/Users/bartvm/anaconda3/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "myia/fence.py", line 93, in visit
    return visitor(node)
  File "myia/fence.py", line 98, in visit_Pass
    self.raise_("you shall not pass")
  File "myia/fence.py", line 109, in raise_
    self.lines[self.lineno - 1], message)
  File "myia/fence.py", line 113
    pass
    ^
__main__.MyiaSyntaxError: invalid syntax: you shall not pass

I attached a minimal proof of concept of this approach. The syntax checker is conservative i.e. it rejects everything unless it's been explicitly marked as supported.

The advantage of having the checks in the parser is that they serve as scaffolding for when you actually add the missing features: if you want to support something new you can replace the error by the implementation, whereas if they are different passes you have to change code in two places. I don't feel particularly strongly about doing it one way or another, but it's something to think about.
Regarding extending SyntaxError, is there any way to remove all traceback entries except the last one? I recall spending a few infuriating hours trying to do this before giving up and replacing the exception hook, but I might have missed something obvious.

Not that I know of, but I can have a look. Then again, do we really want to do that? Seeing what triggered the syntax check might be useful. Perhaps largely theoretical, but there could be situations where Myia is invoked dynamically (think compiled_f = myia(some_functions[randint(10)]) or if compile_with_myia: compiled_f = myia(f)). In those cases you might want to use pdb to walk up the call tree, and it would be good if that corresponded to the actual traceback you get.

That's true, the traceback could be useful in such cases. One way to reduce the noise from all the recursive calls to visit (there could be a whole lot of those) would be to catch the error downstack and re-raise it. That'd only leave the syntax annotation and the part of the stack the user might actually care about.

That might be a good idea. It looks like you need to copy the exception in order for exception chaining to be triggered, but except MyiaSyntaxError as e: raise copy.copy(e) does the trick.
Traceback (most recent call last):
  File "myia/fence.py", line 127, in g
    fence.visit(ast.parse(textwrap.dedent(inspect.getsource(f))))
  File "myia/fence.py", line 93, in visit
    self.generic_visit(node)
  File "/Users/bartvm/anaconda3/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "myia/fence.py", line 93, in visit
    self.generic_visit(node)
  File "/Users/bartvm/anaconda3/lib/python3.6/ast.py", line 261, in generic_visit
    self.visit(item)
  File "myia/fence.py", line 98, in visit
    return visitor(node)
  File "myia/fence.py", line 103, in visit_Pass
    self.raise_("you shall not pass")
  File "myia/fence.py", line 114, in raise_
    self.lines[self.lineno - 1], message)
  File "myia/fence.py", line 120
    pass
    ^
__main__.MyiaSyntaxError: invalid syntax: you shall not pass

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "myia/fence.py", line 130, in <module>
    g()
  File "myia/fence.py", line 129, in g
    raise copy.copy(e) from e
  File "myia/fence.py", line 120
    pass
    ^
__main__.MyiaSyntaxError: invalid syntax: you shall not pass

It does make the traceback from the visit calls inaccessible in pdb, so we'll have to trust that a user or developer won't want to actually inspect the AST that triggered the syntax error. It's also a bit confusing that the error appears twice, but there is a lot less noise and up commands to type to get to the user's code, which is good.

I doubt anyone will want to inspect the AST instead of simply looking at the source, but we can just pass the node to MyiaSyntaxError and store it in e.node or something.

This is over a year old back from the beginning of the repo, I'm just going to close this.


Inviting ideas to reduce dependency on 3rd party scrappers

The limiting factor in this otherwise great project is the reliance on 3rd party scrappers/proxy services to fetch the results. I found out this the hard way when trying to use ScrapingAnt which doesn't have good IP pool for India. Using ScrapingRobot works, but it is severely limiting at 5,000 scrapes/lifetime.
Is there any way we can reduce dependency on 3rd party services and keep it accessible to folks running indie websites and make it truly self-hostable?

@thelazyoxymoron The 5000 req of scrapingrobot is probably renews each month and its not for lifetime. Just checked my account again after a month, and it looks like the request count has been reset to 5000. In any case, I have contacted them to clarify the free limit. Will get back to you once they respond.
As for alternative methods, its rough. Maintaining an IP pool for scraping Google is not cheap or easy, Google bans an ip whenever it makes unusual amount of search request in an hour. The alternative of scrapers is using rotating proxy ip services which can be can quite expensive.


[BUGFIX] process webcontent URLs in links and iframes [MER-2000]

Adds webcontent URLS found in iframe src or link href to the set translated to media URLs, w/referenced files included in media manifest for uploading.

On identification of webcontent links, I thought about this issue, but then just followed the model of nearby code for other elements which just tests for "includes('webcontent'). It looked to me like a decent heuristic that is extremely unlikely to ever fail in our use. I am not certain all webcontent links must begin with dots, though that is usual. There is a predicate in the code isLocalReference that could be used instead.


debian and alpine postgres image not interchangeable

Had a very interesting debugging session a few minutes ago.
Ah while back I simply replaced the "big" postgres:9.5 image with the lightweight postgres:9.5-alpine image and at first everything looked fine. Until it came to some selects which suddenly stop working.
Which tells me that there is some kind of difference in the default configuration between the normal and the alpine version. Maybe that's normal but actually I didn't expect that as everything else worked fine. (no warning on startup and in general everything seemed fine).
I filed all details of my issue hunt at https://github.com/hackmdio/hackmd/issues/430#issuecomment-294941451
And it took me some time to figure it out. So I hope it's helpful to hunt down the real issue that is located underneath the whole thing. For me the switch back fixed it for now but it would be nice to fix it in general in future.

This sounds similar to https://github.com/docker-library/postgres/issues/273 :disappointed:
I wonder if musl is doing something odd?  Can it be reproduced with the Alpine package (if it can be, we'll have to punt to upstream, but otherwise we can look at what they're doing that we aren't :smile:)?

Is it generally a requirement that these are , always , interchangeable ?

That's something we strive to accomplish, but it isn't always possible, so no, it's not generally a requirement.
I would recommend any user who's looking to switch from a Debian variant to an Alpine variant of an image carefully review the two images and the differences between them.  Often times the Alpine image is less-featured out-of-the-box as a core feature, since that allows for a much smaller base image (and tighter control on exactly what gets included).

Going to close since the question is answered sufficiently, and the note in the docs mentions this as well

The main caveat to note is that it does use musl libc instead of glibc and friends, so certain software might run into issues depending on the depth of their libc requirements.


Split develop, deploy and profile builds for both iOS and Android in flutter tool

[x] android flutter build/run --debug (JIT)
[x] android flutter build/run --profile (AOT)
[x] android flutter build/run --release (AOT)
[x] android, ensure that --profile and --release are not available for emulators (#4197)
[x] ios flutter build/run --debug (interpreter) (#2042)
[x] ios flutter build/run --profile (AOT)
[x] ios flutter build/run --release (AOT)
[x] ios, ensure that --profile and --release are not available for simulators (#4200)
[x] modes accessible from atom (can choose which mode to run in) (#4042)
[ ] it's possible to take a screenshot from a simulator/emulator w/o the slow mode banner

more docs on the modes are here: https://github.com/flutter/flutter/wiki/Flutter's-modes

develop:

very fast edit/refresh
Checked mode is possible
Interpreted or JITed (device vs. simulator, possible we'll want to use interpreter in both places when possible)
Observatory enabled.

profile:

Checked mode code removed
Ahead of time compiled (AOTC) when possible
Observatory enabled.

deploy:

checked mode removed
ATOC
Observatory removed.

We don't have to actually make the configs different to begin with, but we do need to expose this difference in the flutter tool in order to make space for the backend work (like wiring in the Interpreter mode on iOS develop on devices).
@chinmaygarde @devoncarew

This may be implied but develop mode enables fast edit/refresh cycles.
On Thu, Mar 3, 2016, 9:00 AM Eric Seidel<EMAIL_ADDRESS>wrote:

develop:

Checked mode is possible
Interpreted or JITed (device vs. simulator, possible we'll want to
use interpreter in both places when possible)
Observatory enabled.

profile:

Checked mode code removed
Ahead of time compiled (AOTC) when possible
Observatory enabled.

deploy:

checked mode removed
ATOC
Observatory removed.

We don't have to actually make the configs different to begin with, but we
do need to expose this difference in the flutter tool in order to make
space for the backend work (like wiring in the Interpreter mode on iOS
develop on devices).
@chinmaygarde https://github.com/chinmaygarde @devoncarew
https://github.com/devoncarew
—
Reply to this email directly or view it on GitHub
https://github.com/flutter/flutter/issues/2366.

Is the profile build configuration necessary? deploy would work for profiling modulo the removal of the observatory.
This would mean we don't pass things like --checked into run (or build), we pass --deploy or --dev.
I'm going to assume that dev mode and deploy mode would likely load their assets (images and code) in different ways. Dev mode may be a shell we build with any native code, but where the dart code is sideloaded (and re-loaded). The deploy mode would AOT it all into one binary, deployable artifact.

Is the profile build configuration necessary?

The difference is whether to include observatory (binary size) and whether to have the sampling profiler running (battery).  If you don't have a profiling build, you either need to pay the costs of the devtools/profiler in production or not be able to profile the production configuration.

flutter/flutter#2042 tracks the iOS build support necessary for this tooling.

The current names are develop, profile, and deploy. Do people have preferences re: renaming the modes, to either:

debug, profile, deploy
debug, profile, release

I'm working on a PR which would rename to debug, profile, deploy.

Searching google for [debug release] and [debug deploy] suggests the first pair is more widely used.

How close are we to closing this? Do we have a checklist of remaining items?

@chinmaygarde, @tvolkert, I re-purposed this bug as a burndown of the remaining items. Can you update the ios related ones (listed in the very first entry in the bug)? Thanks!

I updated the entries. Thanks.

@chinmaygarde, I updated based on some testing, and filed #4200 (re: --profile and --release against simulators).

Done.


Fix an issue with types possibly being related to discriminated type despite of incompatible variance

fixes https://github.com/microsoft/TypeScript/issues/51180
This union was correctly failing a check here:
https://github.dev/microsoft/TypeScript/blob/4c9afe8812fcdb4658472ccbced4a5cd4bae70ea/src/compiler/checker.ts#L19750
but its result isn't directly used if the check failed. This check effectively went through isRelatedTo to this block and failed there:
https://github.dev/microsoft/TypeScript/blob/4c9afe8812fcdb4658472ccbced4a5cd4bae70ea/src/compiler/checker.ts#L20150-L20171
So since this correct result of Ternary.False was not returned there (for reasons I don't understand but they seem to be important), the execution has continued. It continued up to this check here which succeeded:
https://github.dev/microsoft/TypeScript/blob/4c9afe8812fcdb4658472ccbced4a5cd4bae70ea/src/compiler/checker.ts#L20219
In there, only the structures are compared here:
https://github.dev/microsoft/TypeScript/blob/4c9afe8812fcdb4658472ccbced4a5cd4bae70ea/src/compiler/checker.ts#L20370-L20383
I've tried to call isRelated there instead but that experiment failed (maybe somebody else could make it work though). So I've reused the code related to variances that was responsible for creating the "initial" correct result of Ternary.False.

It's kinda wild that the CI fails here with a type error. I can't repro this locally (using the same script) and I don't know how I would get a type error at that location as the changes in this PR are totally unrelated to it.

The failure here is saying that this change causes TS to no longer be able to build itself. Confirming, I see this locally checking out your PR branch, but not in main.
You can run
gulp local --built

to reproduce

Aside, it's quite rare to break TS without affecting any other tests! We'd want a testcase that isolates the problem this exposes, assuming there is one.

Thanks for the tip on how to reproduce this locally! I was trying gulp local before (guided by the error logs) but I didn't use the --built flag (nor --lkg=false that is used by the CI).
I've checked out the failing call site and as far as I can tell - it's a legit one :P it shouldn't fail. I've created a TS playground demonstrating the problem: TS playground. Gonna wrap this up later in a test case that fails with this PR but passes with the main branch and gonna open a PR with that directly to main.
In the meantime, maybe you'd have suggestions on how this PR could be improved to fix the original issue without degrading this case?

OTOH - IIRC variance check can return a different result than a full structural check and that's intended... 🤔

IRC variance check can return a different result than a full structural check and that's intended... 🤔

Definitely not(*). Any time the variance measurement for a type differs from the structural check, it's a bug, usually in the variance calculation logic. (We have many structural type relationships that aren't strictly co- or contra- variant and so have Unreliable and Unmeasurable bail-outs in variance measurement to flag those cases so we rely partially or solely on structural results for them, respectively).

Unless in and out annotations are used, then it's anyone's guess. We toss a lot of variance measurement correctness guarantees out the window when those get used, since they can often be more restrictive than the measured variance, but only get used for variance-based comparisons, and not structural ones. The resulting mismatch can cause a headache of weird behavior which I usually just warn people off with "only use in and out for performance, and only if you know what you're doing".

This has fallen off my radar and pushed down the priority list but I will be back here to investigate this further (unless somebody beats me to it). For now, I will convert this to a draft to indicate that I don't exactly work on this right now.

@weswigham going to close this PR since you have fixed the inconsistency in https://github.com/microsoft/TypeScript/pull/52106 but part of the issue still looks suspicious and perhaps could be looked into or explained (see here)


🐛 AVCaptureDevice.Position has unknown state

What's happening?
Iphone 15 pro and pro max Camera component from React-native-vision-camera is getting break.
Error showing :

package.json file looks like this :

But after doing some head around i have tired to change the react-native-vision-camera version to 2.16,2 and react-native-reanimated to 2.10.0

but this time some new error is coming that looks like this in my simulator :

and crashing on all the iphone devices.
FYI : in my code react-native-worklets-core is not added
i am not sure as is this breaking the code or something else
---------------Happy to get suggestions from developers around the world-------------------------
Reproduceable Code
import { runOnJS } from 'react-native-reanimated';
import { Camera, useCameraDevices, useFrameProcessor } from 'react-native-vision-camera';
import { BarcodeFormat, scanBarcodes } from 'vision-camera-code-scanner';

<Camera
    style={StyleSheet.absoluteFill}
    device={device}
    isActive={!isScanning}
    frameProcessor={frameProcessor}
    frameProcessorFps={1.0}
    zoom={device.neutralZoom}
    onLayout={(event) =>
     {
       var {x, y, width, height} = event.nativeEvent.layout;
       if (cameraDimensions &&
       (cameraDimensions.width != width ||
        cameraDimensions.height != height))
        {
          const barcodeAspectRatio = height > width ? 0.5: 0.35
          const widthPadding = height > width ? 30: 120
          const barcodeHeight = (width - widthPadding * 2) * barcodeAspectRatio;
          setCameraDimensions({
                 width: width,
                 height: height,
                 widthPadding: widthPadding,
                 heightPadding: (height - barcodeHeight) * 0.5
                 });
               }
             }
            }
  >
     {isActivityIndicatorVisible ? (
        <View style={styles.indicatorView}>
          <ActivityIndicator size="large" />
        </View>
      ) : (
        <View style={styles.innerCameraView(cameraDimensions)} />
         )}
   </Camera>

Relevant log output
ERROR:frame-processor/unavailable: Frame Processors are not enabled. See https://react-native-vision-camera.com/docs/guides/troubleshooting\n\nThis error is located at:\n    in NavigationContainer (created by SceneView)\n    in SceneView (created by DrawerView)\n    in RCTView (created by View)\n    in View (created by AnimatedComponent)\n    in AnimatedComponent\n    in AnimatedComponentWrapper (created by DrawerLayout)\n    in RCTView (created by View)\n    in View (created by DrawerLayout)\n    in DrawerLayout (created by DrawerView)\n    in DrawerView (created by Navigator)\n    in Navigator (created by NavigationContainer)\n    in NavigationContainer (created by screen)\n    in screen (created by SceneView)\n    in SceneView (created by DrawerView)\n    in RCTView (created by View)\n    in View (created by AnimatedComponent)\n    in AnimatedComponent\n    in AnimatedComponentWrapper (created by DrawerLayout)\n    in RCTView (created by View)\n    in View (created by DrawerLayout)\n    in DrawerLayout (created by DrawerView)\n    in DrawerView (created by Navigator)\n    in Navigator (created by NavigationContainer)\n    in NavigationContainer (created by Main)\n    in Main (created by screen)\n    in Provider (created by screen)\n    in RNCSafeAreaProvider (created by SafeAreaProvider)\n    in SafeAreaProvider (created by screen)\n    in screen (created by SceneView)\n    in SceneView (created by SwitchView)\n    in SwitchView (created by Navigator)\n    in Navigator (created by NavigationContainer)\n    in NavigationContainer (created by App)\n    in App (created by ExpoRoot)\n    in ExpoRoot\n    in RCTView (created by View)\n    in View (created by AppContainer)\n    in RCTView (created by View)\n    in View (created by AppContainer)\n    in AppContainer\n    in main(RootComponent)', undefined
frame-processor/unavailable: Frame Processors are not enabled. See https://react-native-vision-camera.com/docs/guides/troubleshooting

This error is located at:
    in NavigationContainer (created by SceneView)
    in SceneView (created by DrawerView)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent
    in AnimatedComponentWrapper (created by DrawerLayout)
    in RCTView (created by View)
    in View (created by DrawerLayout)
    in DrawerLayout (created by DrawerView)
    in DrawerView (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by screen)
    in screen (created by SceneView)
    in SceneView (created by DrawerView)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    in AnimatedComponent
    in AnimatedComponentWrapper (created by DrawerLayout)
    in RCTView (created by View)
    in View (created by DrawerLayout)
    in DrawerLayout (created by DrawerView)
    in DrawerView (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by Main)
    in Main (created by screen)
    in Provider (created by screen)
    in RNCSafeAreaProvider (created by SafeAreaProvider)
    in SafeAreaProvider (created by screen)
    in screen (created by SceneView)
    in SceneView (created by SwitchView)
    in SwitchView (created by Navigator)
    in Navigator (created by NavigationContainer)
    in NavigationContainer (created by App)
    in App (created by ExpoRoot)
    in ExpoRoot
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer
    in main(RootComponent)

Camera Device
Unknown as I have don't have the new iPhone and this is a crash report

Device
iPhone 15 pro  & Pro Max
VisionCamera Version
2.16.2
Can you reproduce this issue in the VisionCamera Example app?
No, I cannot reproduce the issue in the Example app
Additional information

[X] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

did this work for you without worklet cores?

The "AVCaptureDevice.Position has unknown state" error has already been fixed in latest VisionCamera (both V3 and V2).

Is there anything else like "react-native-worklets-core" or some other library i need to make changes;
Right now i am using runOnJS  IIFE to implement this :
const frameProcessor = useFrameProcessor((frame) => {
    'worklet';
    const detectedBarcodes = scanBarcodes(
      frame,
      [BarcodeFormat.CODE_128, BarcodeFormat.EAN_13, BarcodeFormat.EAN_8, BarcodeFormat.CODE_39, BarcodeFormat.DATA_MATRIX],
      { checkInverted: true }
    );
    if (detectedBarcodes && detectedBarcodes.length > 0 && !isScanning && timerId === 0) {
      detectedBarcodes.forEach( nextBarcode =>
        {
          const bufferX = cameraDimensions.width > cameraDimensions.height ? 0 : 150;
          const bufferY = cameraDimensions.width > cameraDimensions.height ? 150 : 0;
          const barcodePoint1 = { x: nextBarcode.cornerPoints[0].x / frame.width, y: nextBarcode.cornerPoints[0].y / frame.height };
          const barcodePoint2 = { x: nextBarcode.cornerPoints[1].x / frame.width, y: nextBarcode.cornerPoints[1].y / frame.height };
          const barcodePoint3 = { x: nextBarcode.cornerPoints[2].x / frame.width, y: nextBarcode.cornerPoints[2].y / frame.height };
          const barcodePoint4 = { x: nextBarcode.cornerPoints[3].x / frame.width, y: nextBarcode.cornerPoints[3].y / frame.height };

          const scannerMinX = cameraDimensions.widthPadding / (cameraDimensions.width - bufferX);
          const scannerMaxX = 1.0 - (cameraDimensions.widthPadding / (cameraDimensions.width - bufferX));
          const scannerMinY = cameraDimensions.heightPadding / (cameraDimensions.height - bufferY);
          const scannerMaxY = 1.0 - (cameraDimensions.heightPadding / (cameraDimensions.height - bufferY));

          if (scannerMinX < barcodePoint1.x &&
              scannerMinX < barcodePoint2.x &&
              scannerMinX < barcodePoint3.x &&
              scannerMinX < barcodePoint4.x &&
              scannerMaxX > barcodePoint1.x &&
              scannerMaxX > barcodePoint2.x &&
              scannerMaxX > barcodePoint3.x &&
              scannerMaxX > barcodePoint4.x &&
              scannerMinY < barcodePoint1.y &&
              scannerMinY < barcodePoint2.y &&
              scannerMinY < barcodePoint3.y &&
              scannerMinY < barcodePoint4.y &&
              scannerMaxY > barcodePoint1.y &&
              scannerMaxY > barcodePoint2.y &&
              scannerMaxY > barcodePoint3.y &&
              scannerMaxY > barcodePoint4.y
            )
          {
            console.log(BARCODE SCAN IN THE LANE.);
            runOnJS(notifyBarcodeScan)({
              data: nextBarcode.displayValue,
              format: nextBarcode.format
            });
            return;
          }
        }
      );

    }

I encountered frame-processor/unavailable: Frame Processors are not enabled on both Android and iOS in latest v2 version 2.16.5.


Ignore nulls in tokenizer task, bump version

This fixes #90, which I also ran into recently.
This could potentially also be fixed by assuming a default type for nulls (probably string), but I think this solution represents the more commonly expected behavior.

I think it would be best if there was a call to tl.warning before the continue to let the user know that something is misconfigured and getting ignored.

Have implemented this - thanks for the contributions and suggestions.


✨ respect Sentry CaptureConsole level settings

For https://github.com/playt-net/clashparadise/issues/3962
Depends on https://github.com/playt-net/clashparadise/pull/4061

Tested by linking into Rolling Rick, adding a warning to Rolling Rick, and messing with the levels returned by the Clash Paradise API

@playt-net/developer review pls


Configured keys cannot easily be used

Generated keys need UID matching the container's user (node).
During the docker file setup, generate a default key to be used; don't allow a configured key.

I think I have figured out a strategy for this:

Generate an SSH key for the node account while building the image (Dockerfile will need to be updated)
Also modify the Dockerfile to adjust the SSH config so that it will automatically accept keys for unknown hosts (StrictHostKeyChecking=no)
Store the key in the home directory so it is automatically used
Update the console logging to output the public part of the key during startup (so it can be used to authenticate)
In addition, when in DEVEL mode, warn the user that they should not use configured keys because of the potential permissions issues.

Optionally:

Add a boot up check for file ownership / permissions on configured keys. This could error out on startup (because it will cause rsync failures until it is resolved), and this check can stay in place for production.

I believe this will solve all the issues we were seeing with your original setup. @osandvold302 if you want to take a crack at this, that works. Just let me review your code before you merge to devel.

I've written a first draft of an asynchronous function that attempts to find public SSH keys based on whether an identity path is specified and checking 4 different identities in protocol version 2. I will need to test this function to see if it properly returns public SSH keys and logs them in the console.

Implemented all on the list except for checking for file ownership/permissions.


uv does not use ~/.netrc credentials for --index

$ uv --version
uv 0.5.4 (Homebrew 2024-11-20)

$ # add credentials to ~/.netrc
$ uv add <package> --index <my-index>
# fails with 401 due to not including credentials
$ env NETRC=~/.netrc uv add <package> --index <my-index>
# passes

Based on the docs, I'd expect these invocations to be the same — uv add should use the credentials for an index defined in my ~/.netrc file by default, without me needing to specify the file specifically. (Maybe there's a reason for --index not to do this, if the intention is to provide credentials to a particular index in another way, but ISTM that ~/.netrc credentials should be used if they exist, regardless?)

I don't think we do anything here, other than ask the crate to discover the netrc file:
    pub fn get_file() -> Option<PathBuf> {
        let env_var = std::env::var("NETRC")
            .map(PathBuf::from)
            .map(|f| shellexpand::path::tilde(&f).into_owned());

        #[cfg(windows)]
        let default = std::env::var("USERPROFILE")
            .into_iter()
            .flat_map(|home| repeat(home).zip([".netrc", "_netrc"]))
            .map(|(home, file)| PathBuf::from(home).join(file));

        #[cfg(not(windows))]
        let default = std::env::var("HOME").map(|home| PathBuf::from(home).join(".netrc"));

        env_var.into_iter().chain(default).find(|f| f.exists())
    }

Possibly a mistake on my end — thanks for looking; I'll close this out and reopen if I have a repro for you.


Go: go version 1.12.x breaks goconvey tests

When trying to set up a local workspace of scion from scratch I observed that using go version 1.12 breaks the local go test ./... because goconvey  panics.
scion (master %) cd go/lib/log/
log (master %) go test ./...

0 total assertions

--- FAIL: TestLoggerCtxEmbedding (0.00s)
panic: Top-level calls to Convey(...) need a reference to the *testing.T.
                Hint: Convey("description here", t, func() { /* notice that the second argument was the *testing.T (t)! */ })  [recovered]
        panic: Top-level calls to Convey(...) need a reference to the *testing.T.
                Hint: Convey("description here", t, func() { /* notice that the second argument was the *testing.T (t)! */ })  [recovered]
        panic: Top-level calls to Convey(...) need a reference to the *testing.T.
                Hint: Convey("description here", t, func() { /* notice that the second argument was the *testing.T (t)! */ })

goroutine 5 [running]:
testing.tRunner.func1(0xc0000ce100)
        /usr/local/go/src/testing/testing.go:830 +0x392
panic(0x59c520, 0xc00008e930)
        /usr/local/go/src/runtime/panic.go
...

There are a couple of issues around

https://github.com/smartystreets/goconvey/issues/559
https://github.com/smartystreets/goconvey/issues/561

cc @Oncilla

I have the same problem

Hi @wyp2013
Because of this issue (and some other incompatibilities), we currently require go1.11.x.
Our build system, bazel, takes this into account: https://github.com/scionproto/scion/blob/b07042263775dc5b29a76a04fd5e08a2731ef615/WORKSPACE#L19
If you want to use the default go tool chain, make sure to use go version 11.

I installed go 1.13.3 with gvm, installed goconvey on top of empty pkg and src dirs and my tests work.