[MM-20775] Group mentions feature

Summary
https://github.com/mattermost/mattermost-webapp/pull/4977 - Merged, In Dev Review
https://github.com/mattermost/mattermost-webapp/pull/5066 - Merged, Dev Review Complete ✅
https://github.com/mattermost/mattermost-webapp/pull/5065 - Merged, Dev Review Complete ✅
Ticket Link
Epic link https://mattermost.atlassian.net/browse/MM-20775
Related Pull Requests
https://github.com/mattermost/mattermost-redux/pull/1087
https://github.com/mattermost/mattermost-server/pull/14067

Hi @fm2munsh and @hahmadia
I am seeing the following issues. Can you please check and fix them:

The Group Mention becomes undefined when we add a new Team or Channel in the Groups configuration page.

The Group Mentions handle should be shown as lowercase. However it's displayed as is in the webapp.

The Group Mentions feature does not works on a different team which have not been added to the LDAP Groups.
a) Login as a member and create a new team.
b) Ensure developers Group mentions is enabled in System console.
c) For the newly created team, type @developers and check. Nothing happens.

The server displays the group mentions only in the teams which have been added in the Groups Configuration page. However this behaviour is incorrect and a LDAP user can never be invited with this assumption. The reason being if the teams are added to a LDAP group, then automatically all the LDAP users are added to the team. Hence there will never be a case where LDAP users can be invited.
Expected: Group Mentions should be allowed to use in other teams as well and if LDAP users are not present in that team, then an option to invite LDAP users should be provided.
I am still doing my testing and will add more issues as separate comments.

Some more issues:
4. If we use the group mentions on a channel, the LDAP users belonging to that group do not get notified.
a) On browser 1, visit a channel on which Group mentions is available.
b) On browser 2, login as a LDAP user belonging to the developers group.
c) Ensure Groups mention is enabled for developers group.
d) On browser 1, use the group mention @developers and check if user in step 2 gets notified.
e) User on browser 2 does not gets notified.
Expected: User on browser2 should get notified and a desktop/browser notification should be sent. The channel should be marked as unread with a notification count.

Guest users should not be able to use the group mentions feature
a) Login as a guest user and access the channel on which group mentions is enabled.
b) Try to use the group mentions. A guest user is allowed to use the group mentions.
c) As per expectations, the guest user should not be allowed to use the group mentions.

Please see the list of issues mentioned earlier.

Hi

Please see the list of issues mentioned earlier.

Hi @srkgupta,
I looked at the bugs above and here are my findings:
#1 - existing bug, exposed now since we are displaying the group name in the UI - on a an existing dev deployment you can look at the JS console when linking a team from "Group Configuration" panel :"failed prop type: The prop name is marked as required in GroupProfile, but its value is `undefined". This should be fixed in the feature branch now.
#2 - should be fixed in the feature branch now
#3, #4, #5 - could not repro these ones - I started with a clean env (make nuke, make test-data, make config-reset, make config-ldap). We should have a Zoom session to see what I am doing differently. The guest issue has been fixed late, so it could be that you were using an earlier drop.
#6 - Since we are not doing invite groups yet - are you referring to this message: "..did not get notified by this mention because they are not in the channel. Would you like to add them to the channel?.."?
Fwik we did not change the logic there but @fm2munsh can confirm. Or are you referring to not being able to group mention at all, unless the user has the permission to manage groups? If yes, please add a comment to the Design/tech spec to consider as part of the design. or open a ticket).
#7 -  When you say "Group Mentions invite" are you referring to the notifications we are sending to the members of the groups we are mentioning? If yes, please add a comment to the Design/Tech spec (or open a ticket if you think we should have a trace of the issue)
#8 - I tried the same action with a user name : "@username, and the user mention was not filtered out. Should we expect a different behavior for groups vs. users?
Thanks.

@srkgupta
I have addressed problem #8. You should not longer be getting a notification modal when mentioning groups inside code blocks. Thanks for raising this.

This PR is no longer valid and does not needs QA and needs to be closed without any merge. Individual PRs are being tested and will be merged accordingly.


Copy and Move assets from one album to another albums.

Is there any way to copy and move assets from one album to another albums ?

I managed this. For moving assets what actually I done is that, first I added that assets to destination album and removed original assets.


feat(app): Detect type of supported schemas when credentials are not found

Edge case for when both type and schemas are missing will be addresses in  #575
Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
Patch and project coverage have no change.

Comparison is base (2b18a86) 90.01% compared to head (3f30355) 90.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   90.01%   90.01%
=======================================
  Files          98       98
  Lines        3907     3907
=======================================
  Hits         3517     3517
  Misses        258      258
  Partials      132      132

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Template loading fails when http interceptors adds params to url

If I add time=2342342 param to prevent cache on IE11, angular-bootstrap doen't load any template.html. I don't know the way templates are implemented but all fails.

@Serginho this project doesn't do anything special with template loading, so I would say it is a general support question about using interceptors that might interfere with template loading. As such it should be discussed elsewhere: https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md#got-a-question-or-problem
If you still believe that this is a bug in this library, please report a bug with all the necessery context and steps to reproduce, see: https://github.com/angular-ui/bootstrap/blob/master/CONTRIBUTING.md#you-think-youve-found-a-bug


Fixed bug with the lockscreen not working below marshmellow

When the device is less than Marshmellow, the lockscreen is not getting initialized. Thus I moved the rest of the initialization code outside the if-statement and only left the fingerprint drawables in the if-statement

Can you apply this pull request?

You're right I missed it, Thanks.


Keep search field visible

I'm trying it out with a lot of random extensions installed. Performance is good (M1 Pro though)
I think all it needs is something like:
header {
  position: sticky;
  top: 0;
  background: inherit;
  padding: some padding probably
}

Hi @fregante,
I would like to contribute to this issue. The proposed solution sounds interesting, and I’m eager to help implement it.


fix the extra large icon issue

This PR fixes #13521
introduced by https://github.com/microsoft/azuredatastudio/pull/13514
for toolbar, we would like a consistent sizing for all buttons, overwriting the sizing in toolbar container's CSS.
for normal buttons, I am providing a proper default size.
before:

after:

Pull Request Test Coverage Report for Build 379634767

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 41.215%

Totals

Change from base Build 379580845:
0.002%

Covered Lines:
21789

Relevant Lines:
48493

💛  - Coveralls


Overloading over different numbers of arguments not fully supported

What is your problem?
Overloading a function with structure with different numbers of arguments confuses the interpreter.
How to reproduce your problem?
Run the following code
;; Unary lambda
(: λ (-> Variable Atom Atom))
(= ((λ $x $f) $y) (let $x $y $f))
!((λ $x (+ 1 $x)) 1)

;; Binary lambda
(: λ (-> Variable Variable Atom Atom Atom))
(= ((λ $x $y $f) $z $w) (let* (($x $z) ($y $w)) $f))
!((λ $x $y (+ $x $y)) 1 2)

What would you normally expect?
[2]
[3]

What do you get instead?
[2]
[3, 3]

What else do you have to say?
The following code
;; Unary foo
(: foo (-> Number Number))
(= (foo $x) (+ 1 $x))
!(foo 1)

;; Binary foo
(: foo (-> Number Number Number))
(= (foo $x $y) (+ $x $y))
!(foo 1 2)

properly works, indicating that the problem comes from the fact that the function is an expression instead of a mere symbol.

There was a discussion about var-args and arity in the context of the import op here:  Most of the discussion is pertinent to var-args in general.  https://github.com/trueagi-io/hyperon-experimental/pull/580#discussion_r1491332304

Also, it seems like var-args support might be gated on https://github.com/trueagi-io/hyperon-experimental/issues/346  Although that should be fixable.


Custom audios and metadata

Hello!
I'm trying training my spanish voice, but i have problems with especials characters (for example: ñ)
But i try my own wavs files and metadata without any special character but i have the same problem, when i strart training (main.py) i have this error:
[INFO] Load data
[INFO] Build model
Traceback (most recent call last):
File "main.py", line 36, in
solver.build_model()
File "/content/Tacotron-pytorch/src/solver.py", line 80, in build_model
self.model = Tacotron(**self.config['model']['tacotron']).to(device=self.device)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 386, in to
return self._apply(convert)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 193, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 193, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 193, in _apply
module._apply(fn)
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/rnn.py", line 127, in _apply
self.flatten_parameters()
File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/rnn.py", line 123, in flatten_parameters
self.batch_first, bool(self.bidirectional))
RuntimeError: cuDNN error: CUDNN_STATUS_EXECUTION_FAILED
I'm using default config:
tacotron:
n_vocab: 250 # Use a larger vocab size is ok.
embedding_size: 256
mel_size: 80
linear_size: 1025
r: 5
The self.device it's correct because with LJSpeech work fine.
Have you any idea about this error?
Thanks man!
PD: excellents result with LJSpeech

It seems to me that it is not about data. The error comes from solver.build_model().
Have you tried this solution?

Hello,
sorry friend i think that is one issue from google colab, sometimes it works sometimes no...
Can open a issue if i need help in the future with spanish especials characters or one email is better?
thanks!

No problem.


Update optuna

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@npnv I'm curious, what is different from the existing tutorial?


#[no_predicates] makes compiler panic if used within a brillig function

Aim
Using no_predicates in a poseidon function to make it more performant in acir
Expected Behavior
It should compile
Bug
The application panicked (crashed).
Message:  not yet implemented: enable_side_effects not supported by brillig
Location: compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs:701

To Reproduce
use dep::std::hash::{pedersen_hash_with_separator, poseidon2::Poseidon2};

global NUM_HASHES = 2;
global HASH_LENGTH = 10;

#[no_predicates]
pub fn poseidon_hash<N>(inputs: [Field; N]) -> Field {
    Poseidon2::hash(inputs, inputs.len())
}

unconstrained fn main(
    to_hash: [[Field; HASH_LENGTH]; NUM_HASHES],
    enable: [bool; NUM_HASHES]
) -> pub [Field; NUM_HASHES + 1] {
    let mut result = [0; NUM_HASHES + 1];
    for i in 0..NUM_HASHES {
        let enable = enable[i];
        let to_hash = to_hash[i];
        if enable {
            result[i] = poseidon_hash(to_hash);
        }
    }

    // We want to make sure that the function marked with `#[no_predicates]` with a numeric generic
    // is monomorphized correctly.
    let mut double_preimage = [0; 20];
    for i in 0..HASH_LENGTH * 2 {
        double_preimage[i] = to_hash[0][i % HASH_LENGTH];
    }
    result[NUM_HASHES] = poseidon_hash(double_preimage);

    result
}

Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Installation Method
None
Nargo Version
No response
NoirJS Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

This is caused because the inliner leaves the poseidon_hash acir function existing since it's no predicates, and then it's flattened. But a flattened function isn't convertible to brillig, so brillig_gen fails trying to generate brillig code for a flattened function


Migrate to the new PyPI

Coverage remained the same at 100.0% when pulling c150b0348ad0c3b09e71f3904b63174c6613c9a1 on next into 1ca8648e625306017b2a94acb330ba2bdbe4d0e7 on master.


Add function that compares full house (#2)

Well, this patch is going in the opposite direction.
This would be better https://nsayer.blogspot.com/2007/07/algorithm-for-evaluating-poker-hands.html

Closing this in favor of https://github.com/TelluricDeckay/telluric-handeval/commits/feat/hand-ordering


Release

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/62834
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 5c7095fd7593e1a6745752a8fd8be92663ca1b0e
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/62834
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 43613b0deb58359433560eba6a7b52d0d558b8a6
git push origin v0.1.0


[BEAM-10176] Support STRUCT, FLOAT64, INT64 BigQuery types

Support STRUCT, FLOAT64, INT64 BigQuery types in BIgQuery to Avro schema conversion.
We already support RECORD, FLOAT, and INTEGER, which are aliases of the three types being added.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] ~Update CHANGES.md with noteworthy changes.~
[ ] ~If this contribution is large, please file an Apache Individual Contributor License Agreement.~

See the Contributor Guide for more tips on how to make review process smoother.

R: @pabloem

Run Python 3.7 PostCommit

Run Python 3.7 PostCommit

Run Python 3.7 PostCommit

Run Python 3.7 PostCommit

I think there's an attempt to fix the failures in #11946? I will wait for that and rebase.

I think there's an attempt to fix the failures in #11946?

You're right. The fix's been merged, everything should be fine now.

Run Python 3.7 PostCommit

thanks @chunyang


Add --cors option to allow access from any origin

Issue: https://github.com/zeit/list/issues/36
Here's a support for cors headers.
I did take the same setting in source of http-server for the same --cors option. Maybe it can be tweaked in the future but it's a good start.
Note that maybe the --cors option short version declaration (with args) should be reworked (see https://github.com/leo/args/issues/37)

@slorber Please rebase 😊

done

Thanks!

@leo by chance is this usable with now --static command?

@slorber Link mentioned in here, you need to add a custom scripts property to your package.json file and run list if you want to use it.

Yeah I already do that (with now-build and now-start), but reverted back to building locally for some reasons (takes very long time to build on zeit, optipng not working when building on zeit, also not very precise/documented control over what is uploaded regarging .gitignore/.npmignore/zeit.files... we also got some 502 errors on such deployment but according to your team it may be hardware related)
Currently I'm just using this package.json that I put inside /build folder of my app
{
  "name": "stample-front",
  "description" : "For Zeit.co / Now static frontend deployment of Stample",
  "scripts": {
    "start": "list --cors --cache 1"
  },
  "dependencies": {
    "list-seb": "0.8.3"
  }
}

I was just wondering if I could be able to replace it with a command line, like now --static --cors --cache 1


f35b_elevator.txt missing

csv_timeline360.py is asking for f35b_elevator.txt, which is not in folder F35B.

Thank you. I have added the file.

Hi Eric,you are welcome. Seems also movecopy.py is missing...Best regards,Stefan Von meinem/meiner Galaxy gesendet
-------- Ursprüngliche Nachricht --------Von: erkooi @.> Datum: 28.08.24  19:08  (GMT+01:00) An: erkooi/fusion360 @.> Cc: Stefan @.>, Author @.> Betreff: Re: [erkooi/fusion360] f35b_elevator.txt missing (Issue #1)
Thank you. I have added the file.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hi Eric,

running:
python ..\csv_timeline360.py -f ^
f35b_points.txt,^
f35b_pin_holes.txt,^
f35b_aileron.txt,^
f35b_vertical_stabilizer.txt,^
f35b_elevator.txt,^
f35b_printing_parts.txt,^
f35b_airplane.txt,^
f35b_csv.txt

I getting this message:

Write CSV files for timeline file f35b_elevator.txt
read_units_from_file_lines: mm (default)
read_parameters_from_file_lines: Read 0 parameters
Traceback (most recent call last):
  File "C:\Users\Nutzer\Documents\Fusion 360\scripts\fusion360-main\csv_timeline360.py", line 174, in
    nofFiles += write_csv_files_for_timeline_file(timelineFilename)
  File "C:\Users\Nutzer\Documents\Fusion 360\scripts\fusion360-main\csv_timeline360.py", line 109, in write_csv_files_for_timeline_file
    fileLines = userparameters.replace_parameters_in_file_lines(fileLines, parametersDict)
  File "C:\Users\Nutzer\Documents\Fusion 360\scripts\fusion360-main\userparameters.py", line 132, in replace_parameters_in_file_lines
    value = _eval_expression(pEntry)
  File "C:\Users\Nutzer\Documents\Fusion 360\scripts\fusion360-main\userparameters.py", line 247, in _eval_expression
    code = compile(expression, '', 'eval')
  File "", line 1
    $txTailEnd
    ^
SyntaxError: invalid syntax

Best regards,
Stefan

Gesendet: Mittwoch, 28. August 2024 um 19:07 Uhr
Von: "erkooi" @.>
An: "erkooi/fusion360" @.>
Cc: "Stefan" @.>, "Author" @.>
Betreff: Re: [erkooi/fusion360] f35b_elevator.txt missing (Issue #1)

Thank you. I have added the file.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Stefan,
I have added the missing movecopy.py file. If I now clone the repository from github then csv_timeline360.py can generate all CSV files and in Fusion360 I can run the DesignCSV script to generate the design in Fusion360.
I cannot reproduce the error with $txTailEnd in f35b_elevator.txt, on my PC with this fresh clone from github it does run OK. The $txTailEnd is the first parameter in the txTailEnd.txt file, and it looks like it did not get replaced, because the $txTailEnd is still there in the expression. I think I need some more information to trace this error further. Can you for example in csv_timeline360.py between lines:
parametersDict = userparameters.read_parameters_from_file_lines(fileLines)
fileLines = userparameters.replace_parameters_in_file_lines(fileLines, parametersDict)

put the line:
userparameters.print_parameters_dict(parametersDict)

to see what is in the parametersDict and whether txTailEnd is there. It is strange, because the e.g. f35b_aileron.txt also contains parameters, and that file was parced ok apparently, right?
PS: To create CSV files for only one txt file you can do: python ..\csv_timeline360.py -f f35b_elevator.txt
Greetings,
Eric

Hi Eric,

I cloned the repositiry again and works like a charm.  There are no error messages, I was able to extract 328 CSV with no issues.  Also I could repeat all ypur excercises you demonstrated in your video without any problems.   Excellent work!

What airfoil did you use in the model?  I looks like the airfoil is suitable for a model and not too thin.

Best regards,
Stefan

Gesendet: Donnerstag, 29. August 2024 um 21:56 Uhr
Von: "erkooi" @.>
An: "erkooi/fusion360" @.>
Cc: "Stefan" @.>, "Author" @.>
Betreff: Re: [erkooi/fusion360] f35b_elevator.txt missing (Issue #1)

Hi Stefan,
I have added the missing movecopy.py file. If I now clone the repository from github then csv_timeline360.py can generate all CSV files and in Fusion360 I can run the DesignCSV script to generate the design in Fusion360.
I cannot reproduce the error with $txTailEnd in f35b_elevator.txt, on my PC with this fresh clone from github it does run OK. The $txTailEnd is the first parameter in the txTailEnd.txt file, and it looks like it did not get replaced, because the $txTailEnd is still there in the expression. I think I need some more information to trace this error further. Can you for example in csv_timeline360.py between lines:
parametersDict = userparameters.read_parameters_from_file_lines(fileLines)
fileLines = userparameters.replace_parameters_in_file_lines(fileLines, parametersDict)
put the line:
userparameters.print_parameters_dict(parametersDict)
to see what is in the parametersDict and whether txTailEnd is there. It is strange, because the e.g. f35b_aileron.txt also contains parameters, and that file was parced ok apparently, right?
PS: To create CSV files for only one txt file you can do: python ..\csv_timeline360.py -f f35b_elevator.txt
Greetings,
Eric
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

That is good to hear that it now works.
The airfoil is indeed for a model. It is a NACA-1408 profile, see description in my F35b airplane youtube video. I created profiles along the wing with the script airfoils.py that is also in this repository. I made this airfoils.py script to be able to define other coordinates along the profile, that I then can use in the CSV files, to be able to twist the wing and to give the tail side of the wing some width > 0 so that it is more robust to e.g. 3D print.

Hi Eric,

understand.  So the wing already comes with a washout and the tip of the wing is pointing a bit downward?

I also guess this frame is for a 120mm EDF, since the opening for the nozzle is almost 130mm in diameter.

Best regards,
Stefan

Gesendet: Freitag, 30. August 2024 um 14:06 Uhr
Von: "erkooi" @.>
An: "erkooi/fusion360" @.>
Cc: "Stefan" @.>, "Author" @.>
Betreff: Re: [erkooi/fusion360] f35b_elevator.txt missing (Issue #1)

That is good to hear that it now works.
The airfoil is indeed for a model. It is a NACA-1408 profile, see description in my F35b airplane youtube video. I created profiles along the wing with the script airfoils.py that is also in this repository. I made this airfoils.py script to be able to define other coordinates along the profile, that I then can use in the CSV files, to be able to twist the wing and to give the tail side of the wing some width > 0 so that it is more robust to e.g. 3D print.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Merge UnityContainer and UnityDefaultBehaviorExtension

Externalizing default behavior slows container down and does not make much sense.

Strategies registered in UnityDefaultStrategiesExtension can not be removed later. So keeping them as extension does not make much sense either.


Add error message when zsh-async not found

Added an error message when zsh-async library is not loaded. Not sure it's the best way. We may as well perform git submodule update --init ourselves.

Update PR.


adding new branding to docs site

Added changes to this PR here.

@hpx7 I think this has all the changes I've requested. We can merge this whenever we're ready to go live.


docs: Update static deploy docs for firebase

Description
Currently, the given firebase config will cause users deploying an SPA to experience a bug where refreshing a page on a non-root route will not redirect to index.html resulting in a 404 at the firebase server level. Since most people are likely going to be deploying their static Vite app as an SPA, this will likely eliminate issues for most firebase users trying to get up and running quickly.
What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Yeah, just run pnpm run prettier --write ./docs/guide/static-deploy.md and it should format this file

Ah sorry, edited via github.


Is there any way to just look thru all the nested string without specify the keys?

@krisk Instead of specify the keys, i wish there's a way to include everything into the search with *
const fuse = new Fuse(books, {
  keys: ['title', 'author.firstName']
})

const fuse = new Fuse(books, {
  keys: ['*']
})

https://github.com/krisk/Fuse/issues/546

+1
Interested in this, too (for a smaller index, at least).
I assume performance here is the issue here.

While this could be useful, I would guess the results might differ from the users expectations...
Also, when initially defining the keys array, you'll need to provide an object to grab the searchable keys from -- you could try to pass the first entry in your array but if any of it's values are null where on other entries it might be a string, the searchable keys array will be missing that key since null is not searchable.
You could otherwise traverse each object at every key for each row when searching but that is as inefficient as it gets...
But heck I wanted to try it anyway, benchmark shows about 0.09ms for an array of this size
I tried to optimize as much as possible, surprisingly setting a variable for typeof is faster than checking typeof a few times for some reason...
let object = {
   surface0: 'someValue',            // Valid
   surface1: {
       deeper0: "deeperValue",       // Valid
       deeper1: {
           deepest0: "deepestValue", // Valid
           deepest1: () => {},       // Invalid, not searchable
       },
       deeper2: false,               // Invalid, not searchable
   },
   surface2: {},                     // Valid but empty, not searchable
}

let keyCollection = [];

const pathFinder = (object, path = '') => {
   for (const property in object) {
       if (!object.hasOwnProperty(property)) continue;

       const type = typeof object[property];

       if (type === 'object') {
           pathFinder(object[property], `${path}${property}.`)
       } else if (type === 'string' || type === 'number') {
           keyCollection.push(path + property);
       }
   }
}

pathFinder(object)

console.log(keyCollection)

with a result of
[
    "surface0",
    "surface1.deeper0",
    "surface1.deeper1.deepest0"
]

But again if surface1.deeper0 had been null on this particular object, it wouldn't be searchable on any other objects


Validation datasets support during training

It seems that the framework does not have capabilities to use validation datasets during training for checking convergence (it attaches them into a training dataset), and it is a requested feature (https://github.com/facebookresearch/maskrcnn-benchmark/issues/171 and https://github.com/facebookresearch/maskrcnn-benchmark/issues/348).
In both mentioned issues not clean solutions are proposed because of neediness of additional boilerplate code. So the PR contains integration of the validation into training process with configs support.
Also this feature will be useful for visualization after adding TensorBoard support (https://github.com/facebookresearch/maskrcnn-benchmark/pull/163).
The usage example presented in this config file.
Upd.: The latest version of PR is https://github.com/facebookresearch/maskrcnn-benchmark/pull/828

hi @osanwe
can u give some results of augmentations (flip, scales flip+scales)?

@fmassa ,
Sorry for ping.
As I understood from previous activity, you are a maintainer of the repo. Is this pull request useful or it can be closed?
Maybe some additional information or tests should be provided from my side. The code was tested on 1 and 8 GPUs.

Hi, I'm working on the same thing write now, and I wonder why is it possible to avoid model.eval() command before the validation starts?

@fmassa,
Yes, it seems the additional datasets field is redundant. So I created another PR (https://github.com/facebookresearch/maskrcnn-benchmark/pull/828) where the same datasets are used for intermediate and final evaluations with suggested AP calculations.
@YradenRavid,
The train and eval methods change the inner state of the module (https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/module.py#L987-L1011) and can impact to the model behavior.
For validation in this PR loss values are needed, and they can be gotten only in training mode (https://github.com/facebookresearch/maskrcnn-benchmark/blob/master/maskrcnn_benchmark/modeling/detector/generalized_rcnn.py#L59).

@osanwe I'm working on validation set average loss curve for Tensor Board,  and almost done.

Also this feature will be useful for visualization after adding TensorBoard support (#163).

@osanwe to my understanding, model.eval() change the model to evaluation mode (dropout, BN etc), why is it "good practice" to not use it here before running evaluation loss?

@YradenRavid,
It seems FrozenBatchNorm2d class is created by @fmassa, not by me.
As I wrote previously, eval() and train() methods only change the training boolean flag in nn.Module. And yes, this flag can impact on the batch_norm behavior and some other layers. Also it impacts on the RCNN behavior here (as mentioned previously), so you cannot get loss values if training flag is equal to False (i.e. you use eval mehod).

@YradenRavid,
It seems FrozenBatchNorm2d class is created by @fmassa, not by me.
As I wrote previously, eval() and train() methods only change the training boolean flag in nn.Module. And yes, this flag can impact on the batch_norm behavior and some other layers. Also it impacts on the RCNN behavior here (as mentioned previously), so you cannot get loss values if training flag is equal to False (i.e. you use eval() mehod).

By inspecting the implementation of the FrozenBatchNorm, it seems all parameters are indeed frozen and the behavior of the layer does not change regardless of .eval() or .train().

behavior of the layer does not change regardless of .eval() or .train()

The behavior is changed in GeneralizedRCNN forward method:
https://github.com/facebookresearch/maskrcnn-benchmark/blob/master/maskrcnn_benchmark/utils/metric_logger.py#L35-L37

It seems that the framework does not have capabilities to use validation datasets during training for checking convergence (it attaches them into a training dataset), and it is a requested feature (#171 and #348).
In both mentioned issues not clean solutions are proposed because of neediness of additional boilerplate code. So the PR contains integration of the validation into training process with configs support.
Also this feature will be useful for visualization after adding TensorBoard support (#163).
The usage example presented in this config file.
Upd.: The latest version of PR is #828

It seems this inference operation will increase the cost of memory? I encountered out of memory when gathering results from the gpus. I am so confused that the inference can be finished but the memory will be costed a lot when gathering results?

It seems this inference operation will increase the cost of memory?

Yes, the validation step requires additional memory because of additional data loader etc. Please, refer to https://github.com/facebookresearch/maskrcnn-benchmark/pull/828.

Preparing pr description...


Example for pagination doesn't seem to work

The docs don't mention where to get paged. I'm guessing it's from ghapi.page import paged.
Anyway, when trying to follow the example I get:
In [82]: repos = api.repos.list_for_org('<...>')
In [83]: len(repos)
Out[83]: 30

In [84]: repos_paged = paged(api.repos.list_for_org('<...>'))
In [85]: for page in repos_paged: print(len(page), page[0].name)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-85-f32e698c6d18> in <module>
----> 1 for page in repos_paged: print(len(page), page[0].name)

~/git/github-analysis/lib/python3.8/site-packages/ghapi/page.py in paged(oper, per_page, max_pages, *args, **kwargs)
     14 def paged(oper, *args, per_page=30, max_pages=9999, **kwargs):
     15     "Convert operation `oper(*args,**kwargs)` into an iterator"
---> 16     yield from itertools.takewhile(noop, (oper(*args, per_page=per_page, page=i, **kwargs) for i in range(1,max_pages+1)))
     17
     18 # Cell

~/git/github-analysis/lib/python3.8/site-packages/ghapi/page.py in <genexpr>(.0)
     14 def paged(oper, *args, per_page=30, max_pages=9999, **kwargs):
     15     "Convert operation `oper(*args,**kwargs)` into an iterator"
---> 16     yield from itertools.takewhile(noop, (oper(*args, per_page=per_page, page=i, **kwargs) for i in range(1,max_pages+1)))
     17
     18 # Cell

TypeError: 'L' object is not callable

I am also seeing this error, is there a fix @hamelsmu?

I'll look into this today

@jean @sgibson91 this error has to do with the way you are calling the API within paged.
First, lets import what we need
```py
from ghapi.page import paged
from ghapi.core import GhApi
api = GhApi()

### The wrong way
This will result in an error

```py
for r in paged(api.repos.list_for_org('fastai')):
    ...

The right way
pages = [r for r in paged(api.repos.list_for_org, org='fastai')]
for i,p in enumerate(pages):
    print(f'num of items in page {i}:  {len(p)}')

---
num of items in page 0:  30
num of items in page 1:  30
num of items in page 2:  25

Please let me know how this can be clarified in the docs more and I'll make the change.

Thank you @hamelsmu 🙏🏻 I think the docs need to show the list generation example you demonstrate here as that is not intuitive from the example as it currently as it stands. I would've guessed that paged returned a list rather than a function.

yes it returns a generator.  Let me try to add more examples to the docs.

Sorry to reopen this, but I'm still seeing the error even when rewriting what I was trying to do with the "right way".

This is the wrong way :)
https://ghapi.fast.ai/page.html
"Note how the function and arguments are passed separately"

Ooooh, oh my gosh that's subtle! I'll get my eyes checked and have another go, thanks! 😂


Support Aliases for imports relative to root

I have addressed this in #352 but the issue was closed as my question that I posted was somewhat unrelated.
I have the defined the aliases in webpack.config.dev.js and it mostly works. I am receiving lint errors, and tests are failing.
Can someone provide a somewhat detailed explanation on how to resolve theses issues and implement aliases relative to the src/ path? I am completely lost and would prefer to not have to use absolute paths such as ../../../config lol.
I would be happy to submit a PR once its working, if @coryhouse feels this is an appropriate direction for the kit.

webpack.config.dev.js
// ...removed for brevity
const resolvePaths = (...args) => {
  return path.resolve(__dirname, 'src', ...args);
};

export default {
  resolve: {
    extensions: ['*', '.js', '.jsx', '.json'],
    alias: {
      containers: resolvePaths('containers'),
      components: resolvePaths('components'),
      reducers: resolvePaths('reducers'),
      layouts: resolvePaths('layouts'),
      styles: resolvePaths('styles'),
      store: resolvePaths('store'),
      middleware: resolvePaths('middleware'),
      config: resolvePaths('config')
    },
  },
// ...removed for brevity

src/components/Home/index.spec.js
import React from "react";
import config from 'config';

console.log(config);
const Home = () => (

Home Component

);

Home.propTypes = {};
Home.defaultProps = {};
Home.defaultProps = {};
export default Home;

src/components/Home/index.js
import React from 'react';
import {shallow} from 'enzyme';
import HomeComponent from './index';

describe('<HomeComponent />', () => {
  it('should display the Home Component', () => {
    const wrapper = shallow(<HomeComponent />);
    const actual = wrapper.find('.HomeComponent > h1').text();
    const expected = 'Home Component';
    expect(actual).toEqual(expected);
  });
});

the lint errors i get are:

and my tests fail because it doesn't know where "config" is located at. So it seems tests are breaking too..

bit of an update, i got tests working by installing the babel-plugin-module-resolver and adding in my .babelrc this to my development, test, production env :
      "plugins":[
        ["module-resolver", {
          "root": ["./src"],
          "alias": {
            "containers": "./src/containers",
            "components": "./src/components",
            "reducers": "./src/reducers",
            "layouts": "./src/layouts",
            "styles": "./src/styles",
            "store": "./src/store",
            "middleware": "./src/middleware",
            "config": "./src/config",
          }
        }]
      ]

however, it seems import/no-unresolved is still occuring with esw/linting.

Alright last update, I think... I have it working.
I installed eslint-import-resolver-babel-module and babel-plugin-module-resolver and in my .eslintrc I added  the import plugin, and the import/resolver settings.
  "settings": {
    "import/resolver": {
      "babel-module": {}
    }
  },
  "plugins": [
    "react",
    "import"
  ],

it resolved my imports/no-unresolved and tests work fine... anyone else see any issues with this process?

I have done aliasing, however my edits were summarized in the webpack config and the jest config. I did not have any lint error, so I am no help there.
That being said the steps you took appear to be accurate based on my past research of this.

thanks @kwelch is this something you think would be along the path for the kit to include as a PR? If so I can clean things up and submit a PR for it.

Your approach makes sense, but I'd like to leave this out since alias isn't
a common use case and it may just create confusion. That said, I'd welcome
a pr that updates the docs to link to this issue so people can see how to
do so.
On Mar 28, 2017 4:21 PM, "Mike DeVita"<EMAIL_ADDRESS>wrote:

thanks @kwelch https://github.com/kwelch is this something you think
would be along the path for the kit to include as a PR? If so I can clean
things up and submit a PR for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/issues/398#issuecomment-289908640,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnFpYJinRxM7LC_O3QxjST6efV75neVks5rqXnRgaJpZM4Mr4Lg
.

@coryhouse ill get a PR submitted shortly. thanks.

as an FYI there is an article on medium about absolute paths and create-react-app you can see it here.

Unfortunately this solution not working for me with react-slingshot  😞


migrate sport_naming_map to db model

instead of hard coding the name mapping dict, it would be great for the sake of ux to have the mapping be configurable using the settings page and django model

Currently no need for this.


Implement new transaction replacement mechanism when adding transactions to the pool.

Description
We should implement a new transaction replacement mechanism, similar to other client implementations.
Currently a new transaction (same user and same nonce) replaces an old one if the new gas price is higher than the old one. Other client implementations require the delta to be higher than a minimum percentage.
For instance this option is called pricebump in Geth implementation, configurable using --txpool.pricebump . This command line option is described as Price bump percentage to replace an already existing transaction and is defaulted to 10%.
Acceptance criteria

New replacement mechanism is implemented
Used for remote transactions received via P2P
Used for local transactions received via eth_sendRawTransaction

Linked issues

#559

would the existing transaction replacement mechanism still be available for non-PoW Besu clients?

would the existing transaction replacement mechanism still be available for non-PoW Besu clients?

Good question. Actually we have multiple options:

Set the price bump to 0 by default, this would behave like the existing mechanism.
Set the price bump to 10 by default to align with default behaviour of other mainnet clients, non-PoW Besu client would have to explicitly set it to 0 via CLI option.
Set the default price bump depending on the consensus engine.

I will raise the point and see what other contributors think about it. Do you have a personal preference ?

Setting a sane default based on the consensus engine would IMHO reduce the likelihood of any surprises for not much effort.

Setting a sane default based on the consensus engine would IMHO reduce the likelihood of any surprises for not much effort.

@brianmcgee Thanks for the feedback.


Candidate form option

Hi, my client is looking for an option to add a candidate without a job related to. For example for someone looking for an opportunity that is currently not available. Just to keep their info for future opportunities. Is this possible? Thank you.

This is possible, however you are not able to use the public API to do so.
However, I have seen people have a "general job" of sorts that applicants can get routed to if there are no opportunities that interest them at the time.  This is the easiest route possible.

@msilverio1975 if your client is using WordPress then Matadorjobs plugin does this out of the box as it uses the private API


datastore: add snippets

Copied verbatim from the gocloud/google-cloud-go repository.
Changed package name, added package level comment, changed the
formatting of the license notice to match the rest of this repository.

/cc @okdave

TBR=rakyll

LGTM belatedly


from_networkx function returns TypeError: attribute name must be string, not 'int'

🐛 Bug
Hi there,
I am having an error when I pass a networkx graph, which nodes contain a dictionary with integer keys, to the "from_networkx" utility function. It raises a value error:
TypeError: attribute name must be string, not 'int'

To Reproduce
Steps to reproduce the behavior:
>>> import networkx as nx
>>> from torch_geometric.utils import from_networkx
>>> attrs = {0: {1: 20, 2: 50}, 1: {1: 21}}
>>> G = nx.path_graph(3)
>>> nx.set_node_attributes(G, attrs)
>>> G.nodes[0]
{1: 20, 2: 50}
>>> G.nodes[1]
{1: 21}
>>> G.nodes[2]
{}

g = from_networkx(G)

Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/Users/netp/anaconda3/envs/graphnn/lib/python3.8/site-packages/torch_geometric/utils/convert.py", line 137, in from_networkx
    data = torch_geometric.data.Data.from_dict(data)
  File "/Users/netp/anaconda3/envs/graphnn/lib/python3.8/site-packages/torch_geometric/data/data.py", line 105, in from_dict
    data[key] = item
  File "/Users/netp/anaconda3/envs/graphnn/lib/python3.8/site-packages/torch_geometric/data/data.py", line 118, in __setitem__
    setattr(self, key, value)
TypeError: attribute name must be string, not 'int'

Environment

OS: Mac os Catalina
Python version: 3.8.5
PyTorch version: 1.6
CUDA/cuDNN version: N/A

Thanks for reporting. This is now fixed in master. Note that in PyG, all nodes (and edges) should have the same feature dimensionality. Therefore, it is better to change attrs to:
attrs = {0: {1: 20, 2: 50}, 1: {1: 21, 2: 0}, 3: {1: 0, 2: 0}}


Heroku Creates Empty Repo

I used the deploy with Heroku button and I can open the app and see Make sure to star the parse-server repo on GitHub! but when I $ heroku git:clone -a myApp it says
my-mac:~ me$  heroku git:clone -a myApp
Cloning into 'myApp'...
warning: You appear to have cloned an empty repository.
Checking connectivity... done.

and the directory is empy.

Check an answer at Stackoverflow, it might help:

I did not find the previously linked answer on SO to help while the following page did. I hope it helps others who are experiencing the same problem.
https://kb.heroku.com/why-do-i-see-a-message-you-appear-to-have-cloned-an-empty-repository
What was not clear to me, and appears to be an issue for others, is that by using the Install on Heroku button the current GitHub repository is used to deploy the app on Heroku but when using the command below it results in an empty repository. Part of the problem is that the origin needs to be defined so that when Git pulls from the origin there is something there. For whatever reason the Heroku CLI does not pull the files from the original repository and it results in an empty repository.
heroku git:clone -a my-parse-app
What I did not do from the start was fork the original repository before installing the app on Heroku. I created a fork and then used that URL for the following command.
git remote add origin https://github.com/USERNAME/parse-server-example
With a remote defined for the origin I can then use the following command.
git pull origin master
Now I should be able to deploy from this folder with the Heroku CLI.

Another solution for the impatient:
git clone git@github.com:ParsePlatform/parse-server-example.git your-app-name
cd your-app-name
git remote add heroku https://git.heroku.com/your-app-name.git

http://stackoverflow.com/a/41209906/1257369


feat: store per-treasury execution on proposals

Summary
oSnap proposals can have separate executions for multiple treasuries.
This commit will display those in the UI as separate intities, linked to specific treasury.
Currently we read treasuries from latest metadata, this means that if one treasury is used in proposal, but then it's removed or updated when you go back to the proposal it will either show Unnamed treasury or updated name.
We should store at-proposal-time treasury details on proposal directly so we have correct version, but for now I skipped this because of TheGraph's issue we can't deploy new subgraphs.
How to test

Run VITE_ENABLED_NETWORKS=s-tn,sep yarn dev.
Check two proposals (onchain and off-chain).
onchain http://localhost:8080/#/sep:0xfa463A2Bdd8d27f1b0eA99270c3c4Bb3A7B2ADeF/proposal/1
onchain http://localhost:8080/#/s-tn:0cf5e.eth/proposal/0x18b4c85fb3dba579b2714a3fcdba5ea96088f9f0a51f02002e81cc39a589d674
They look correct.

Screenshots

Great work on the design 👏🏼 , it's looks perfect to me. I've tested with your proposal it works well, I tried with Snapshot proposals having oSnap but somehow I can't see the execution with your PR even if the treasury is linked, example here:
https://snapshot.org/#/epochisland.eth/proposal/0xdf570852e10b377c17f6703749d5a6485e29a477340ad1e97e8698f1ea21356a
You can find more examples here: https://hub.snapshot.org/graphql?query={
  proposals (where%3A { plugins_contains%3A "uma" }) {
    id
    space {
      id
    }
    link
  }
}

I'm currently reading from oSnap plugin, looks like this proposal uses safeSnap and the format there is different.

Can you check these ones:
https://snapshot.org/#/shutterdao0x36.eth/proposal/0xcc9547b9eae7e04e1146c103f36878a01b7b4353ff9cf66c207a19223f6b07b5
https://snapshot.org/#/dao.connext.eth/proposal/0x06b58c21fb9ef2a077697916e1014c9b7b9c11226fbf1e43588ed063f4da6e15

This one uses safeImport transaction type that I haven't implemented right now. Will take a look what it is.


node getChildList return null

hello. for me
node getChildList return null. i only have new TreeNode<>(new File..
for each node

solved. if node  child is empty return null


am zcopy error

Describe the bug
ucx branch: topic/ucg-master

uct_completion adds a new field status.

struct uct_completion {
    uct_completion_callback_t func;    /**< User callback function */
    int                       count;   /**< Completion counter */
    ucs_status_t              status;  /**< Completion status, this field must
                                            be initialized with UCS_OK before
                                            first operation is started. */
};

uct_invoke_completion()  uses the new field to invoke the completion function  passed by user at am zcopy.

void uct_invoke_completion(uct_completion_t *comp, ucs_status_t status)
{
    ...
    if (--comp->count == 0) {
        comp->func(comp, comp->status);
    }
}

But  ucg dose not initialize the new field with UCS_OK , as a result, the status of the ucg coll request is an indeterminate value.

ucs_status_t ucg_builtin_step_zcopy_prep(ucg_builtin_op_step_t *step)
{
    ...
    while (zcomp_cnt--) {
        zcomp->comp.func  = ucg_builtin_step_am_zcopy_comp_step_check_cb;
        zcomp->comp.count = 1;
        zcomp++;
    }
    ...
}

branch is unstable, those bugs is being fixed


Lock service & button will unlock car

Calling lock.lock on the lock.car_door_lock entity or pressing the lock button always results in a car unlock. The logs point to a successful lock action however the car always receives an unlock command. Unlocking the car works perfectly with the unlock service / button.
I've also recorded the locking + notification from the UVO app and attached.
2021-09-23 06:11:03 DEBUG (SyncWorker_8) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Received Pin validation response <Response [200]>
2021-09-23 06:11:06 DEBUG (SyncWorker_8) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Received lock_action response {'responseHeader': {'responseCode': 0, 'responseDesc': 'Success'}}
After the lock command is called there is a force update, and I am also seeing an error there potentially due to running the force update too closely to the lock command.
2021-09-23 06:11:16 DEBUG (MainThread) [custom_components.kia_uvo.Vehicle] kia_uvo - force_update_loop start 0 5
2021-09-23 06:11:16 DEBUG (MainThread) [custom_components.kia_uvo.Vehicle] kia_uvo - force_update_loop last_updated 2021-09-23 10:04:03+00:00
2021-09-23 06:11:19 DEBUG (SyncWorker_1) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Received forced vehicle data {'error': {'errorCode': '6533', 'errorDesc': 'We are currently processing an earlier inquiry for your vehicle. Please wait 90 seconds before issuing next request.'}, 'responseHeader': {'responseCode': 1, 'responseDesc': 'Failure'}}
2021-09-23 06:11:21 DEBUG (SyncWorker_10) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - get_cached_vehicle_status response {'responseHeader': {'responseCode': 0, 'responseDesc': 'Success'}, 'result': {'status': {'lastStatusDate': '20210923100619', 'airCtrlOn': False, 'engine': False, 'doorLock': True, 'doorOpen': {'frontLeft': 0, 'frontRight': 0, 'backLeft': 0, 'backRight': 0}, 'trunkOpen': False, 'airTempUnit': 'C', 'airTemp': {'value': '01H', 'unit': 0}, 'defrost': False, 'lowFuelLight': False, 'acc': False, 'hoodOpen': False, 'transCond': True, 'steerWheelHeat': 0, 'sideBackWindowHeat': 0, 'dte': {}, 'tirePressureLamp': {}, 'battery': {'batSoc': 82, 'batSignalReferenceValue': {}}, 'remoteIgnition': True, 'seatHeaterVentInfo': {}, 'sleepModeCheck': False, 'lampWireStatus': {'headLamp': {}, 'stopLamp': {}, 'turnSignalLamp': {}}, 'windowOpen': {}, 'engineRuntime': {}}}}
2021-09-23 06:11:22 DEBUG (SyncWorker_10) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Get Service status data {'responseHeader': {'responseCode': 0, 'responseDesc': 'Success'}, 'result': {'maintenanceInfo': {'mtspServiceDate': '20190427', 'imatServiceOdometer': 12000.0, 'imatServiceOdometerUnit': 1, 'mtitServiceDate': '20200427', 'currentOdometer': 58480.1, 'currentOdometerUnit': 1, 'serviceOdometerDuration': 12000.0, 'serviceDaysDuration': 366, 'serviceMonthsThreshold': 12}}}
2021-09-23 06:11:23 DEBUG (SyncWorker_10) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Received Pin validation response <Response [200]>
2021-09-23 06:11:24 DEBUG (SyncWorker_10) [custom_components.kia_uvo.KiaUvoApiCA] kia_uvo - Get Vehicle Location {'error': {'errorCode': '6533', 'errorDesc': 'We are currently processing an earlier inquiry for your vehicle. Please wait 90 seconds before issuing next request.'}, 'responseHeader': {'responseCode': 1, 'responseDesc': 'Failure'}}
2021-09-23 06:11:24 ERROR (MainThread) [custom_components.kia_uvo.Vehicle] kia_uvo - Exception in update : 'result' - traceback: Traceback (most recent call last):
File "/config/custom_components/kia_uvo/Vehicle.py", line 54, in update
self.vehicle_data = await self.hass.async_add_executor_job(self.kia_uvo_api.get_cached_vehicle_status, self.token)
File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 52, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/kia_uvo/KiaUvoApiCA.py", line 127, in get_cached_vehicle_status
vehicle_status["vehicleLocation"] = self.get_location(token)
File "/config/custom_components/kia_uvo/KiaUvoApiCA.py", line 144, in get_location
return response["result"]
KeyError: 'result'
2021-09-23 06:11:24 DEBUG (MainThread) [custom_components.kia_uvo.Vehicle] kia_uvo - force_update_loop force_update_finished 2021-09-23 10:04:03+00:00 2021-09-23 10:04:03+00:00
https://user-images.githubusercontent.com/82300869/134493269-d3abe15c-53ad-4f9c-9c45-6734e687e56a.mp4

I just tested on mine.  While the UVO push notification says it was unlocked my vehicle actually locks.   For unlocking UVO and home assistant align.  Can you confirm your car is actually not locking?   I will keep trying replicate where the car doesn't respond correctly.

I kept testing, and can now replicate this.  Not sure why I couldn't before.  I will debug.

@fuatakgun could use a hand here.  For some reason the following works correctly, not sure why the variable isn't matching as the code before seems to have issues.
`    def lock_action(self, token: Token, action):
VEHICLE_LOCK_ACTION.LOCK
_LOGGER.debug(f"{DOMAIN} - Action for lock is: {action}")
    if action == "close":
        url = self.API_URL + "drlck"
        _LOGGER.debug(f"{DOMAIN} - Calling Lock")
    else:
        url = self.API_URL + "drulck"
        _LOGGER.debug(f"{DOMAIN} - Calling unlock")`

You should not use ENUM here, as vehicle class is just using string for action as open or close. vehicle class had converted the enum into respective strings befote calling api.

Okay.  I used my above code as a commit to resolve.  @YeloMelo95  please retest.   I do think the refresh cycle we use could be cleaned up as it is calling before the first command is complete however this impacts europe so myself and @fuatakgun  may need to coordinate.

Thanks all. I will test this tomorrow as I've reached my request limit for today
-------- Original message --------
From: cdnninja @.>
Date: 2021-09-23 3:14 p.m. (GMT-05:00)
To: fuatakgun/kia_uvo @.>
Cc: YeloMelo95 @.>, Mention @.>
Subject: Re: [fuatakgun/kia_uvo] Lock service & button will unlock car (#72)
Okay. I used my above code as a commit to resolve. @YeloMelo95https://github.com/YeloMelo95 please retest. I do think the refresh cycle we use could be cleaned up as it is calling before the first command is complete however this impacts europe so myself and @fuatakgunhttps://github.com/fuatakgun may need to coordinate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/fuatakgun/kia_uvo/issues/72#issuecomment-926084156, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATT47RPHTLTEHD7EMFR57F3UDN4ABANCNFSM5ETLP3DQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

From my testing earlier today, nothing happens when trying to lock the car. I also received two notifications from the UVO app - one advising that an earlier request is processing and to try again, and another advising that my engine hasn't been started recently or that my car has no reception. I didn't call any requests other than two lock requests (pressed lock button, got "earlier request" message, then called lock.lock and got the "engine off/no reception" message).
I just re-tested now by first unlocking via the unlock button, which was successful, then locking via the lock button which was also successful. I'm not sure why this was not working before (didn't make any changes to HACS or the integration).
I can't test this further since I have already hit the API limit from the two test sessions above.
Here are the logs from the failed request:
uvo_error.TXT

Thanks!  I think it will be easier to keep testing once we merge the fix for the location API. I have most of that solved on my local side but fighting one other issue.   I also think we may need to make changes to how lock unlock checks if it works.  Canada does some strange calls via the website to validate it.   Glad initial lock unlock looked okay.    The engine of no reception is related to Kia having rules you must follow to use it.  Sounds like one of those may have been broken.

That sounds awesome! Just wanted to add, even though there were those errors, the locking and unlocking are now stable for me
-------- Original message --------
From: cdnninja @.>
Date: 2021-09-24 2:36 p.m. (GMT-05:00)
To: fuatakgun/kia_uvo @.>
Cc: YeloMelo95 @.>, Mention @.>
Subject: Re: [fuatakgun/kia_uvo] Lock service & button will unlock car (#72)
Thanks! I think it will be easier to keep testing once we merge the fix for the location API. I have most of that solved on my local side but fighting one other issue. I also think we may need to make changes to how lock unlock checks if it works. Canada does some strange calls via the website to validate it. Glad initial lock unlock looked okay. The engine of no reception is related to Kia having rules you must follow to use it. Sounds like one of those may have been broken.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/fuatakgun/kia_uvo/issues/72#issuecomment-926842648, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATT47RIHRC3UCESIOEPJXJTUDTAMJANCNFSM5ETLP3DQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I have disabled location in the code which should give you more stability for the existing features.  If things are stable for you for lock / unlock lets us know and we can close this bug while we work on location.

So far so good, everything seems stable from my testing this weekend. I would say this can be closed off


Works fine on IOS, not working on Andorid - many issues

Hi
Is this sample supposed to work on Android as it is ?I am getting a range or errors. Before i list them, can you tell me what i need to do after checking out master ?
After i checked out master, i added local.properties with the SDK info and set the signing team in XCode and then it worked fine
On Android it has been much more complex and i haven't got it to work yet
Thanks

It works for me.
I have Android Studio 3.2.1.
Which issue do you have in Android Studio?

Closed as outdated.


Add Slack command

This is a work in progress.

When this PR is merged (not ready yet), the site will require manually adding one extra setting in the .env file:
ADMIN_URL=admin


exclude doesnt work?

i have these folders in the exclude settings but its still showing the whole .git folder (5000+ lines)
  "draw.folder.structure.exclude": [
    "node_modules",
    ".git",
    ".next",
    "out"
  ],

nvm

why do people always do this. submit an issue, then close it with "nvm"
if it happened to you, then its gonna happen to someone else.


Using Certmagic with pebble

What version of the package are you using?
v.0.19.2
What are you trying to do?
Trying to run Certmagic with Pebble as a development setup.
What steps did you take?
I retrieved the root certificate from the pebble server and added in to the default trustedRoots.
Then created a default instance and tried to retrieve a certificate for example.com.
package main

import (
	"context"
	"crypto/tls"
	"crypto/x509"
	"encoding/pem"
	"io"
	"log"
	"net/http"

	"github.com/caddyserver/certmagic"
)

const DEV_ACME_URL = "https://localhost:14000/dir"
const DEV_ACME_URL_ROOT_CERT = "https://localhost:15000/roots/0"

func main() {
	// get the root cert from pebble
	client := &http.Client{
		Transport: &http.Transport{
			TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
		},
	}
	res, err := client.Get(DEV_ACME_URL_ROOT_CERT)
	if err != nil {
		log.Fatal(err)
	}
	acmeRootCertPemBlock, err := io.ReadAll(res.Body)
	if err != nil {
		log.Fatal(err)
	}
	certDERBlock, _ := pem.Decode(acmeRootCertPemBlock)
	if certDERBlock == nil {
		log.Fatal("Failed to parse the certificate PEM.")
	}
	acmeRootCert, err := x509.ParseCertificate(certDERBlock.Bytes)
	if err != nil {
		log.Fatal(err)
	}
        // add cert to trusted roots
	pool := x509.NewCertPool()
	pool.AddCert(acmeRootCert)
	certmagic.DefaultACME = certmagic.ACMEIssuer{
		CA:           DEV_ACME_URL,
		TestCA:       DEV_ACME_URL,
		Email<EMAIL_ADDRESS>		Agreed:       true,
		TrustedRoots: pool,
	}

        // test setup
	magic := certmagic.NewDefault()
	magic.ManageSync(context.TODO(), []string{"example.com"}
}

docker-compose for pebble part
 pebble:
  image: letsencrypt/pebble
  command: pebble -config /test/my-pebble-config.json
  ports:
    - 14000:14000  # ACME port
    - 15000:15000  # Management port
  environment:
    - PEBBLE_VA_NOSLEEP=1
  volumes:
    - ./acme/pebble-config.json:/test/my-pebble-config.json

What did you expect to happen, and what actually happened instead?
I expected the client to be able to communicate with Pebble server.
However it fails due to the certificate being signed by a unknown authority.
Error:
1.6995322571964943e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.6995322572084048e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.6995322572085469e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}
1.6995322572112968e+09	warn	acme_client	HTTP request failed; retrying	{"url": "https://localhost:14000/dir", "error": "performing request: Get \"https://localhost:14000/dir\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}
1.6995322574669735e+09	warn	acme_client	HTTP request failed; retrying	{"url": "https://localhost:14000/dir", "error": "performing request: Get \"https://localhost:14000/dir\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}
1.6995322577227457e+09	warn	acme_client	HTTP request failed; retrying	{"url": "https://localhost:14000/dir", "error": "performing request: Get \"https://localhost:14000/dir\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}
1.6995322577228525e+09	error	obtain	could not get certificate from issuer	{"identifier": "example.com", "issuer": "localhost:14000-dir", "error": "registering account<EMAIL_ADDRESS>with server: provisioning client: performing request: Get \"https://localhost:14000/dir\": tls: failed to verify certificate: x509: certificate signed by unknown authority"}
1.6995322577228823e+09	info	obtain	releasing lock	{"identifier": "example.com"}

Please link to any related issues, pull requests, and/or discussion
This issues describes exactly the same issue.
It suggests to add the certificate to the trusted stores, however it did not work for me.
https://github.com/caddyserver/certmagic/issues/191

I was using the wrong certificate.
The certificate in pebble is the pebble.minica.pem


TwitchWebSub.handleRequest should be framework agnostic

Right now, the function TwitchWebSub.handleRequest works only for Express. It should be framework agnostic and work for every server framework or pure node requests.

Resolved in 0.0.8.


New VS121 Version.

Added new functionalities for the new VS121 Version. Update is backwards compatible.

Changes are included in the VS133 Branch


Jupyter notebook multiline math equations render error

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Paste the following code as markdown in a jupyter cell.
$$\begin{aligned}
f(x)&=x+x\\
&=2x
\end{aligned}$$

Actual behavior

Expected behavior

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.4.76186
VS Code version: 1.45.0
Setting python.jediEnabled: true
Python and/or Anaconda version: Python 3.7.6, conda 4.8.3
OS: Windows | Mac | Linux (distro): Manjaro Linux
Virtual environment: conda

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

This appears to render properly using native notebooks in VS Code 1.60:


[Feature Request] support blosc compression

blosc has multiple threading support and have multiple compressor backends including zlib, zstd, blosclz, lz4, lz4hc, snappy.
My bigarray IO get 2-3X speedup using blosclz compression.

since we have other similar options like zstd, and jp3d, close here.


Update to tf 0.13

A quick update to make this repo work with the new tf13.

Whoops. Guess we missed this one. One sec while I make some branches/releases. I'll merge this in and cut a new release after that. Thanks Chris!

Oh actually... if we just change the version strings to be more accepting... it should be fine since this module doesn't really have much to it to break in 13

Updated and tested, thanks @eeeady

New release published: v1.2.0


[Agents KIT] Release Checks

This issue tracks all relevant release checks for KITs.
Release Info
Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
If changes to your KIT are not yet live on our website, link the open PR introducing the changes for this release.
If changes are already live, also point out the PRs witch included the changes for this version if possible.
Please refer to TRG 8.03 for the classification of mandatory and optional artefacts.

PR number

General

[ ] CHANGELOG available and maintained

Adoption View

[ ] Vision and Mission statement present
[ ] Business Value statement present
[ ] Semantic Models linked and described
[ ] Logic / Schema available and described
[ ] Business Process documentation available
[ ] Access and Usage Policies documented
[ ] Standards submitted / published via the Catena-X e.V. process and linked with current version (e.g., semantic models)
[ ] Tutorials available
[ ] White Paper available
[ ] Notice CC BY 4.0 licence statement available

Development View

[ ] API Specification published on SwaggerHub
[ ] Protocols available (e.g., dataspace protocol)
[ ] Sample Data available
[ ] Architecture integration into the overall Catena-X architecture and / or product architecture (e.g., Arc42) available.
[ ] Reference Implementation available

Operation View

[ ] Setup Guide available (e.g., installation guides)
[ ] Deployment Script available (e.g., helm charts)

Helpful Links

Catena-X standard library

Thanks for fixing the linter issues.
On this KIT are no content changes (mail communication with @TomBuchertTSystems)
FYI @kelaja / @RolaH1t
Please take this to the 'no changes' section in the release notes.

@TomBuchertTSystems   & @maximilianong  please check once the ticket details. I am assuming that the ticket is related to 24.03. If thats the case, please update the milestone on the right hand side

As soon as this is done; the status needs to get adjusted as well.
Dont forget to close the ticket at the end of the process

handled separately in PR - closing this issue


Update the docs regarding builtin modules

The existing documentation is somewhat inconsistent with respect to
builtin modules and what constitutes "reference" documentation. This
change attempts to bring a bit more consistency to the documentation and
fill in some gaps.

Oh, the typo correction is in its own commit. Then that's fine.

Please take another look.

FYI, You can see how the reformatted reference index looks here: https://www.skepticism.us/elvish/ref/

PTAL

PTAL. I also clarified the first paragraph of the builtin introduction regarding when the namespace prefix needs to be used.

I see you reverted the change of putting the module names at the front; I prefer keeping that change, but I can do that myself too.

That was deliberate. My first version put the module names at the front of the sentence but that made it harder to read. That's why I experimented with a custom CSS class to force the module names to all have the same width.


Version changed from 24 to 34

We are currently using 34.0 and this is the latest one so please approve this PR and merge it .
Thanks
Sayyed

@bvedad Please could you update your dependencies.

According to the release notes the function input.isInput is not supported anymore since V32.0.0, and this function is used in anchorediting.js on line 573 https://github.com/ckeditor/ckeditor5/releases/tag/v32.0.0


Finished adding scopes to hotkeys

Referencing the "Add scopes to hotkeys" issue: #5
I finished tying your scope functions to use_hotkeys and the overall demo page. Some big changes were:

Added use_hotkeys_scoped function - tried to follow this formating: (https://react-hotkeys-hook.vercel.app/docs/documentation/hotkeys-provider)

active_scopes is now a HashSet

initially_active_scopes converts to hashset

Demo has had three buttons add (bottom right hand corner) to test changing scope.  I didn't style the buttons so they just look like text. I figured you'd have better taste with styling

Thanks @JustBobinAround -- this looks amazing, just a couple of comments:
This change makes the following assumptions:

use_hotkeys is for globally defined hotkeys
use_hotkeys_scope will only trigger if that specific scope is turned on.

How would we handle overlaps? Suppose I have a global hotkey ctrl+6 and a scoped hotkey in ctrl+6, what should take precedence? Is this even allowed?
This is more of a general comment, but how will &'static str affect our library? Maybe we can write a macro that can transform it into a string? Just a thought. Wondering what you were thinking.
Other than that, I think we can merge this PR and then I'll do some cosmetic for the demo


"Insufficient system resources exist to complete the requested service" when attempting to access K:/

When attempting to access K:/ on my Windows 10 Laptop, I receive the following dialog:
"K:\ is not accessable
Insufficient system resources exist to complete the requested service"
with the title
"Location not available"
Assuming "resources" refers to hardware resources, here they are:
CPU: Duel core 1.9GHz
RAM: 4GB
Arc.: x64
--
Keybase GUI Version: 1.0.14-20160316135738+b1a3399

Please run keybase log send, thanks.

Log ID: 1b02a85d1e0fe88ebfe3c31c

@zanderz @taruti: looksl ike keybase log send on windows doesn't include the KBFS logs.  I guess that's the first thing we have to fix.

Probably should have mentioned...
- WARNING error opening log "C:\\Users\\Isaac\\AppData\\Roaming\\Keybase\\keybase.kbfs.log": open C:\Users\Isaac\AppData\Roaming\Keybase\keybase.kbfs.log: The system cannot find the file specified.
- WARNING error opening log "C:\\Users\\Isaac\\AppData\\Roaming\\Keybase\\Keybase.app.log": open C:\Users\Isaac\AppData\Roaming\Keybase\Keybase.app.log: The system cannot find the file specified.

I'll dig around for any logs i can find soon...

@strib, Unlike linux which runs,
kbfsfuse -debug -mdserver mdserver.kbfs.keybase.io:443 -bserver bserver.kbfs.keybase.io:443 /keybase &>> "$logdir/keybase.kbfs.log" &
Windows launcher seems to just run
{app}\kbfsdokan.exe k:
that logs (like kbfsfuse would to stderr). One of:

change default log target from stderr to file (one line patch to libkbfs/init.go)
change kbfsdokan command line in packaging/windows/setup_windows_gui.iss to add -log-to-file
works. I can do 1, 2 is probably for @zanderz.

Thanks @taruti.  I vote 2.  @zanderz?

@zanderz, you will probably want to use the following command line:
kbfsdokan.exe -log-to-file -debug K:

@excham We are making changes to improve kbfs logs on Windows. Meanwhile, if you could edit %AppData%\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\Keybase.vbs to make kbfsdokan.exe launch with the above options, then reboot and duplicate your problem, it should be captured in the log reporting. Thanks!

Hmm... Here's my console....
$ kbfsdokan.exe -debug -log-to-file -log-file-path ~/kbsf.log K:
kbfsdokan error: (2) Dokan failed

$ kbfsdokan.exe -debug -log-to-file -log-file-path ~/kbsf.log E:

Running the latter command, I'm able to access E:/ and see the "public" and "private" directories (yay!), but when attempting to open either one, I get the error I posted above (not yay).
If I try to directly access E:/public/excham, windows says it cant find said path.
~/kbsf.log is empty...
I'll restart my machine and try again on K:/ - I don't know if K:/ is hardcoded in at all, because if it is, that'd obviously be why I can't access "E:/public/excham"

The dokan error from the first run is just a stale mount which went away and the second run succeeded.
What ~/kbfs.log means can vary widely because of shells parse the ~ before passing it to kbfs and it might end up in e.g. C:\msys32\home\yourusername depending on your shell. Or it might pass a ~ to go which won't end well for a log file in a directory.
K: is not special in any way for kbfsdokan, the client run scripts just default to that at the moment.
The log file in the gist seems to show that no keybase service is running? What does keybase status show? For manually running kbfsdokan from command line one typically does manually  keybase login followed by keybase unlock which is of course not needed when using the GUI.

@taruti, when specifying the log file path, I explicitly set it to my windows user directory, using the absolute path.
I'll take a peak in C:\msys32\home\yourusername when I get home, and I'll post whatever keybase status gives me. I don't think I've ever typed keybase unlick, so hopefully that'll get me somewhere

The absolute path should of course work, just noted the ~ on your paste and that mislead me.
keybase unlock is not needed when using the GUI, but when running things by hand it is needed.

Uh. I'll try that when I get home in a few hours


proctl: propagate underlying error for failing hardware breakpoint.

Improves error message on systems that delve is failing on.

Thanks!


[Feature Request] Search provider. AG. Follow symlink options

Hello, it can be very convenient for some project to have follow symlink settings in narrow or search provider, or add ability to pass options to AG itself.

What option do you want to pass to ag?
Once this plg supported direct pass-theouth option configuration but I removed.
I thin what you want to do is directly specify options to ag.
Am I understanding your request correctly?

Yes, I just want to ag to follow symbolic link (so its -f option)

try v0.65.0.
You need to manually set extra CLI args.
From narrow's setting, find Ag Extra Args from Search setting.

thanks will try now
2018-03-15 9:47 GMT+03:00 t9md<EMAIL_ADDRESS>
try v0.65.0.
You need to manually set extra CLI args.
From narrow's setting, find Ag Extra Args from Search setting.
[image: settings_ ___github_atom-narrow]
https://user-images.githubusercontent.com/155205/37448028-f75b368e-2867-11e8-9932-985565a4e818.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/t9md/atom-narrow/issues/293#issuecomment-373277624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH24ug6zgyYvdJwg5BiV7c4baoj9FdlIks5teg5vgaJpZM4Sgmyo
.


[Snyk] Security upgrade python from 3.13.0a3-slim to 3.13.0b1-slim

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

cmd/earlystopping/medianstop/v1beta1/Dockerfile

We recommend upgrading to python:3.13.0b1-slim, as this image has only 50 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

364
CVE-2024-2961 SNYK-DEBIAN12-GLIBC-6617103
No Known Exploit

436
CVE-2024-33601 SNYK-DEBIAN12-GLIBC-6673964
No Known Exploit

436
CVE-2024-33600 SNYK-DEBIAN12-GLIBC-6673969
No Known Exploit

436
CVE-2024-33602 SNYK-DEBIAN12-GLIBC-6673972
No Known Exploit

500
Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.998%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3117

Relevant Lines:
4270

💛  - Coveralls


feat(guild): update the Guild.stickers_limit for the new discord update

Summary

title, cant guarantee on the lintings through
Checklist

[ ] If code changes were made then they have been tested.

[ ] I have updated the documentation to reflect the changes.
[ ] I have run task pyright and fixed the relevant issues.

[ ] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

can you provide a reference to where the info on 5 sticker slots is from? your summary doesnt seem to explain anything

@ooliver1 There's a popup that appears on some servers

I'm not sure if it's rolled out to all servers yet, or just some though.

Can confirm, 5 free stickers for me aswell. Not a community guild I might add.

@ooliver1 https://discord.com/channels/613425648685547541/697489244649816084/984667965888806993


Authenticate Method Response Handling

Describe the bug
The authenticate method does not properly catch and reject 502 Bad Gateway responses. The method attempts to access an undefined property which causes an unhandled rejection.
Expected behavior
The authenticate method should check for a 502 Bad Gateway response and generate an appropriate message.

closed with 58e9ffcc58a60fbdb7b9a0f67593b802f40f5dd1


Circular References Support

Describe the bug
circular dependency will cause StackOverflowException
To Reproduce
Steps to reproduce the behavior:

Declare a mapper as an interface
Add a mapping method CarDto CarToDto(Car car);
Add a mapping for "Seats" wich refernce to Car via ParentCar property
Add property to Car called "Primary Seat" which is of type Seat
Assign everything

Stack overflow.
Repeat 3212 times:
--------------------------------
   at ConsoleApp59.CarMapper.CarToCarDto(ConsoleApp59.Car)
   at ConsoleApp59.CarMapper.MapToSeatDto(ConsoleApp59.Seat)
   at ConsoleApp59.CarMapper.MapToSeatDtoArray(ConsoleApp59.Seat[])
--------------------------------
   at ConsoleApp59.CarMapper.CarToCarDto(ConsoleApp59.Car)
   at Program.<Main>$(System.String[])

Expected behavior
I expect mapper is smart enough and when it is tasked with mapping instance which it delt before with (reference equal) it would return already newed instance.
Code snippets
checkout this repo https://github.com/vmachacek/mapperly-circular-references
Environment (please complete the following information):

Mapperly Version: 2.5.0
.NET Version: NET 6.0.401
Target Framework: net6.0
OS: Windows

Thank you for this feature request, this would definitely be a cool feature for Mapperly. We will look into this, however this seems to need a few changes (currently we don't carry any context around...) and therefore may take a while to be implemented.

Mapperly v2.6.0-next.4 implements support for circular references.
It can be enabled by setting UseReferenceHandling on the MapperAttribute to true.
[Mapper(UseReferenceHandling = true)]
public partial class CarMapper
{
    public partial CarDto CarToCarDto(Car car);
}

This enables the usage of a default reference handler which reuses the same target object instance if encountered the same source object instance.
To use a custom IReferenceHandler implementation,
a parameter of the type Riok.Mapperly.Abstractions.ReferenceHandling.IReferenceHandler
annotated with the Riok.Mapperly.Abstractions.ReferenceHandling.ReferenceHandlerAttribute
can be added to the mapping method.
[Mapper(UseReferenceHandling = true)]
public partial class CarMapper
{
    public partial CarDto CarToCarDto(Car car, [ReferenceHandler] IReferenceHandler myRefHandler);
}


double-commander 0.7.0

Thank you for the contribution. It was merged directly as 33461ec410b6878b16a186b5e6a5ba09b4b4186b to keep commit history cleaner. Your contribution is still credited to you.


Upgrade Redis, PostgreSQL and NodeJS version

[x] Redis version to 7.0
[x] PostgreSQL version to 15
[x] Node version to 18

NOTE: going to present this repo to my students next month, wanna see the most recent stuff here :slightly_smiling_face:

Cool. Thanks!


docs: readme suggestions

Please feel free to directly edit, in particular for the ## Getting started section - some guidance on where to go next after installing the plugin (or generally to understand what data is supported by the panel) would be a valuable addition.

Nice additions @mckn 🙌


CN User Stats Page Load Test Data

Have made it so the users' stats are displayed on this page. There is a graph that displays the percentage starting from their lowest score to their highest score. Then there are two boxes that shows the total points and average percentage. These are displayed using icons, but if you hover each one it will say "Total Points" and "Average Score" respectively. There is then a table that shows information about each test. There is pagination in the table which limits 10 to be displayed at a time, which was done using DataTables.

Looks good, although you can add the nav bar in so the user is able to go back to the dashboard or logout.

Thanks, there is a navbar there but it was just cut off from the screenshot


Make too slow initializers' tests faster

The tests test_initializer_statistics_slow_* might be too slow.  This PR reduces the number of samples.  After the change, pytest -m 'not gpu and slow' chainer_tests/initializer_tests takes 83.54 seconds for the 128 slow cpu tests on my laptop.

LGTM. Jenkins, test this please.

Jenkins CI test (for commit 0e656b65665c429b71eb5ccf7d2a2fb31e937032, target branch master) failed with status FAILURE.

Jenkins issues look unrelated. Merging.

@Crissman This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@Crissman This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@Crissman This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@Crissman This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@Crissman This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?


The USB set address request failed in debug build

Hi!
I used your library in my project for STM32F411CEU and noticed that sometimes Windows shows error 43 in Device Manager. If reconnect device, then everything works as it should
To reproduce the issue, I plugged and popped the device several times. Sometimes it also occurred if leave the stm32 connected via USB and flash using st-link

I am using a Chinese black pill. And everything works fine on firmware, written using C and CubeMX

I am using a Chinese black pill. And everything works fine on firmware, written using C and CubeMX

Hypothetically, i can try to get the dump using a cheap logic analyzer, but I'm not sure that it will be able to work correctly with usb 2.0

Hypothetically, i can try to get the dump using a cheap logic analyzer, but I'm not sure that it will be able to work correctly with usb 2.0

I can't figure out what is what and whether my logical analyzer managed to capture data from usb
RUST USB CDC BUG.zip

I can't figure out what is what and whether my logical analyzer managed to capture data from usb
RUST USB CDC BUG.zip

Can you paste your list of dependencies from Cargo.toml with the versions numbers?

My Cargo.toml:
[package]
name = "motor"
version = "3.0.0"
edition = "2021"

[dependencies]
nb = "1"
cortex-m = "*"
cortex-m-rt = "*"
embedded-hal = "0.2"
usb-device = "0.2.8"
usbd-serial = "0.1.1"
rtt-target = { version = "0.3.1", features = ["cortex-m"] }
arraydeque = { version = "0.4", default-features = false }

[dependencies.stm32f4xx-hal]
version = "0.10"
features = ["stm32f411", "rt", "usb_fs"]

@mvirkkunen
I'm sorry, I made a mistake. Before that, I started the project in debug mode using the cargo-embed --chip stm32f411ceu command. After I started launching the project via cargo-embed --chip stm32f411ceu --release, the problem went away even at low frequencies. But this is still wrong behavior, I think

Yes, it's odd. It shouldn't be that slow and the dump shows a STALL condition, not a timeout from what I could tell from a quick look. I'll have to take a look at this more when I have time, I have some of the exact same board too.

If this problem is solved one day, I will be glad. Thank you for communicating! For now, I will work in the release and use your rtt library for debugging
My friend sent me such a link when I described my problem to him: https://discord.com/channels/705836771304538152/856573424075538503/927284955057373234

Yeah there are some weird race conditions in debug mode still it seems. What comes to debugging, stopping the device or even using semihosting is just a plain non-starter because USB has somewhat strict timeouts. I pretty much made the first version of the RTT library specifically for debugging USB, because semihosting was too slow and I didn't want to use an extra serial port.
I can't see what's behind the link, because I don't know what Discord server it is and I don't think it allows you to see messages unless I join the server.

Yeah there are some weird race conditions in debug mode still it seems. What comes to debugging, stopping the device or even using semihosting is just a plain non-starter because USB has somewhat strict timeouts. I pretty much made the first version of the RTT library specifically for debugging USB, because semihosting was too slow and I didn't want to use an extra serial port.
I can't see what's behind the link, because I don't know what Discord server it is and I don't think it allows you to see messages unless I join the server.

Excuse me. Corrected the link.It's time for me to sleep)

The Synopsys OTG IP is very fragile and easily breaks down in surprising ways when it's not handled exactly as the IP authors intended, even if you'd think your actions are reasonable.

mmm, sounds very nice indeed

mmm, sounds very nice indeed

Another surprise from stm32) It's amazing why nobody didn't encounter this problem besides me

It's quite an old problem, there is even a warning which (unfortunately) doesn't work unless you build the firmware from a workspace which includes synopsys-usb-otg: https://github.com/stm32-rs/synopsys-usb-otg/blob/master/build.rs#L5-L7

It's possible people have just assumed it was because debug mode is slow and can break in weird ways, and never looked at it with a logic analyzer to see the surprise STALL status. This report might be a better fit for the Synopsys driver repo, unfortunately you can't move an issue to another org.

It's possible people have just assumed it was because debug mode is slow and can break in weird ways, and never looked at it with a logic analyzer to see the surprise STALL status. This report might be a better fit for the Synopsys driver repo, unfortunately you can't move an issue to another org.

I can write anywhere, summarizing everything written, if it helps a little in solving the problem.

Should I drop it here? https://github.com/stm32-rs/synopsys-usb-otg
Or where it will be more convenient

Yes, this is the right place.

Close issue here...

And open here https://github.com/mvirkkunen/usb-device/issues/80


GPU string overhaul

Big string cleanup, yet again, for GPU. We still had this tricky
double indirection happening with strings for OptiX -- the string was
a pointer to a "global", which in turn held the hash. No, throw all
that out.  Just directly store strings as the ustring hash on
OptiX. No extra indirection. Many fewer differences between how things
are handled on OptiX versus CPU (except for the fact itself that the
"string" holds the hash rather than the char*).
Some details worth noting:

LLVM_Util loses "type_string()" and calls it "type_ustring()" to
emphasize it's the type we're using to represent a ustring, and
definitely not a C or C++std string. Also, LLVM_Util itself now lets
the caller tell it whether it prefers that the representation of a
ustring be the charptr or the hash, and then handles most of the
details internally. The BackendLLVM, then, makes that decision early
on, charptr for CPU and hash for GPU.

Several more spots in LLVM_Util and BackendLLVM have been plumbed to
pass around llvm IR SSA variable names to try to make the resulting
LLVM IR more readable when I'm trying to debug it. (This was
strictly debugging scaffalding aid for me, but comes along for the
ride because it's useful to keep.) I also added a
BackendLLVM::llnamefmt to format strings, which only does the
formatting when the shading system knows it's going to save the IR
for inspection, and otherwise (that is, in production) it does not
do the string formatting or pass the names along, so it's not doing
all that string manipulation when no human is going to be looking at
the IR dumps.

A lot of clunky OptiX-only code disappears.

Some side effects of my reducing complexity of the IR as I debugged:
there were times we were generating redundant pointer casting in the
IR, such as grabbing a pointer, then casting it to a void*, then
casting back to some other kind of pointer. In some cases I reduced
that quite a bit. Again, this was mostly just a scramble to make the
IR more readable while I debugged, but it probably has a minor
performance gain as well since it reduced somewhat the sheer amount
of IR we generate and pass to the optimizer and JIT.

Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

@timgrant Would be great to get your eyeballs on this, too.

Taking a look now.

That'd be my vote.  I think we'd be ok with it removed, but I'd rather wait
for the dust to settle a little bit once the new functionality is pushed
out to make sure all the pieces are in place on our side to make sure we
won't need it.
On Mon, Jul 11, 2022 at 10:41 AM Larry Gritz @.***>
wrote:

@.**** commented on this pull request.
In src/include/OSL/rendererservices.h
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1531#discussion_r918196072
:

@@ -411,7 +411,8 @@ class OSLEXECPUBLIC RendererServices {
virtual uint64_t register_string (const std::string& str,

I think you're right, but I wasn't sure about the compatibility break that
would be incurred to removing a virtual method from the parent class. Maybe
I'll just mark it as deprecated first?
—
Reply to this email directly, view it on GitHub
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/pull/1531#discussion_r918196072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEULLERPWR7SJU2FAPANO3VTRMDDANCNFSM526KREQQ
.
You are receiving this because your review was requested.Message ID:
<AcademySoftwareFoundation/OpenShadingLanguage/pull/1531/review/1034712910
@github.com>

Will merge this at the end of the day. Register any final objections now.


add better EventLoopPreference names

Right now, we have three (public) EventLoopPreferences:

.delegate(on: EventLoop)
.indifferent
.delegateAndChannel(on: EventLoop)

I did propose this naming personally so I feel a little sheepish for proposing to change (or just add better) names. But let me explain how we got here:
When I proposed this, I thought that the user only wants to choose the EL for the delegate callouts. To use AHC however, a user needs more guarantees. Almost all users will want to specify an EL and they require the following things to happen the specified EL:

Task.futureResult needs to be bound to the specified EL
all delegate methods need to be called on the specified EL
all other callouts need to be called on the specified EL

Today (and in the future), .delegate(on: el) does exactly that. The naming however is confusing because it only mentions the delegate (but not the future or other callouts).
My new proposed naming is:

.on(EventLoop)
.indifferent
.forceChannelAndCalouts(on: EventLoop)

Maybe to reduce the number of deprecation warnings we should do

.on(EventLoop)
.delegate(on: EventLoop) (same as .on(EL))
.indifferent
. forceChannelAndCalouts(on: EventLoop)
.delegateAndChannel(on: EventLoop) (same as . forceChannelAndCalouts(on: EL))

I think we need to focus on the 99% case and the 99% case is that users really don't care where the Channel lives but they very much care where the future and all the callouts come from.
That means that we mostly need to focus on the name of the 99% case and I think eventLoopPreference: .on(myEL) is great.
All the other cases (2 - 5) are really for special uses so it's actually good if the names are slightly longer.

(the existing naming came in #102 )


Fix feed back

This change is

Coverage increased (+0.007%) to 85.133% when pulling 596b1627af601d6d66e6720a10891cf0fd33110d on fixFeedBack into 4f54937a08b3bf70c7ebb9f3fa02dd70fe069891 on master.


feat: add configuration to create v3 ivf_pq indices via python

PR adds the ability to create v3 ivf_pq indices from python by passing in a bool parameter via the VectorIndexParams python. Right now it just sets the value to true for IVF_PQ but it can be used for other indices as well. Also, it doesn't change the JNI side for IVF_PQ for now, but can be added as a follow-up PR.
Added a bunch of tests in python and rust to test this.

Codecov Report
Attention: Patch coverage is 98.63014% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7cc14d9). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

java/core/lance-jni/src/utils.rs
0.00%
1 Missing :warning:

rust/lance/src/index/vector/ivf.rs
99.23%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2941   +/-   ##
=======================================
  Coverage        ?   77.84%
=======================================
  Files           ?      231
  Lines           ?    70619
  Branches        ?    70619
=======================================
  Hits            ?    54972
  Misses          ?    12751
  Partials        ?     2896

Flag
Coverage Δ

unittests
77.84% <98.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@BubbleCal @westonpace Wanted to see if there are any other review comments that I need to address apart from the enum change that @eddyxu suggested

I just added IndexFileVersion to lance, @ankitvij-db you can try to reuse that


feat: retrieve service actions metadata

Allow users to retrieve metadata about the concrete method

Note: we should consider moving handle_shutdown_handler to utils; it makes more sense to me

coverage: 96.404% (-0.06%) from 96.468%
when pulling 5f82491697162da4d6050ec5779003bf1a755a37 on 0-inspect-action-metadata
into 53c2401de310d276647dbeeb9a6a086ee429537a on main.


Backport "Catch stackoverflow errors in the highlighter" to LTS

Backports #19836 to the LTS branch.
PR submitted by the release tooling.
[skip ci]

No regressions detected in the community build up to lts-20295.
Reference