Child state won't render the selected view

Hi,
I can't figure out why child states won't render the view, even if the state changes successfully.
This is just an example.

    Go to cat
    Go to Add
    Go to cat 'ciao'
    <ui-view></ui-view>

I would need to see your templates.

I've updated my code, but maybe I understood what is the problem, I cannot have child states without a nested ui-view inside parent html.
To accomplish what I want to do I have to set different base states, for example categoryAdd or categoryEdit.

We have to put the child state's view somewhere.  We it inside the  from the parent.

To accomplish what I want to do I have to set different base states, for example categoryAdd or categoryEdit.

I don't understand, what is your point?
Can you post as a plunker?

I'm sorry, the problem was that I totally misunderstood the uses of ui.router nested states and nested views.
Don't need to post a plunker, you can close/delete/destroy this issue, I apologize for having wasted your precious time.
Thank you for your support and quick replies.


fix modify the way of the command 'yum remove xxx', e.g. docker-selin…

…ux and docker-engine-selinux packages
Dear,
When we run the command "yum remove docker-selinux", container-selinux pakcage will be removed. Because container-selinux is the next version of docker-selinux.
Now problem is comming.
In roles/container-engine/docker/tasks/pre-upgrade.yml, docker-selinux and docker-engine-selinux are checked to decide whether to delete the old packages. Packages module runs the command "yum remove xxx" in CentOS.
When we run kubespray again, although docker-selinux is not installed, container-selinux will be removed. This leads to unnecessary deletion and affects the subsequent execution speed, for example, restart docker.
So, we should modify docker-selinux to docker-selinux.noarch, then container-selinux will not be removed when checking docker-selinux.
So does docker-engine-selinux.
Maybe this is a little improvement.
Thanks!
/assign @ant31

/assign @riverzhang
Thanks!

ci check this

/lgtm
/approve


Self Converts Into a Table When Called From Function

Hi, this is my first time ever posting an issue to GitHub, so I apologize if its not in the correct manner. I was recently working on some pathfinding and realized that "self" gets converted into a table if you reference it from a function that is being called that is not one of the built in functions.

Test.extends = "Navigation2D"

function Test:_ready()
	print(self)
	Test:Foo()
end

function Test:Foo()
	print(self)
end

return Test

In the example above, printing self from inside the _ready() function prints the correct game object, but if you print it from within the Foo() function it instead prints a table.
Thank you and have a wonderful day!

Hi there! Don't worry, there's no need to apologize ^^
In Lua, whenever you use method notation object:method(...), it is actually syntactic sugar for object.method(object, ...).
In the same manner, defining a function as function object:method(...) end is syntactic sugar for function object.method(self, ...) end.
Note here that self is just the name of the parameter and you can actually pass whatever value you want to it. If you called Test.Foo(1), the self parameter would have the value of 1, so that it would print 1, for example.
This is just how Lua works.
In the code you posted, you are calling Test:Foo(), which in turn is the same as Test.Foo(Test).
When Foo executes, the value passed to the parameter self is the table Test, which is not the same object as the variable self you have in _ready.
To call Foo with the same object as you have in _ready, you just have to call it as self:Foo(), which would be the same as self.Foo(self), instead of Test:Foo().
This way, the value passed to Foo's self parameter is the same self as you have in _ready.
Since the variable self in _ready is an instance of your Test script, every method in Test will be available, including Foo and _ready, as well as all other methods from Navigation2D, which it extends.
Feel free to reply and/or ask more about this or other stuff, I'm glad to help!
Have a wonderful day and year yourself =D

Just in case you're interested in behind the scenes, the script instance self is also a table, but one that defines a __tostring method that uses it's owner object for getting the string. That's why print(self) prints something like [Navigation2D:1234].

Ooooooh, thats right! That makes a lot of sense! I used self:Function() in a couple of my other scripts and it worked fine. I was a little confused because it was working on other scripts I had written but not this one specifically. Thank you so much for the thorough and well written and quick response!

I was a little confused because it was working on other scripts I had written but not this one specifically.

Hehe, that happens. More than we would like, unfortunately =P
That reminds me of a quote that was something like: "I really hate this damned machine. It never does quite what I want, but only what I tell it".

Thank you so much for the thorough, well written, quick response!

No problem! The more information we can get, the best it is to understand what happened. We all learn together as well ^^

I absolutely love this plugin

I'm really glad to ~hear~ read that! That's what motivates working on this further. Well, that and I actually plan to use Lua + FFI in some Godot projects that I haven't started yet. Maybe this year, who knows?

and I would love to support you and your work

Thank you, I really appreciate that ^^ I've added a donation link from PayPal directly, might be easier for some people.


Update CONTRIBUTING.md

Move tool configuration to separate section to make it easier to discover.

Added few comments to https://dart-review.googlesource.com/c/sdk/+/230953

Kind reminder @polina-c, please look at the feedback in the review

@mit-mit we have a separate thread going about this CL.

Submitted the changes in CL: https://dart-review.googlesource.com/c/sdk/+/230959


Add useId() to support SSR id generation

What is it?

[X] Feature / enhancement
[ ] Bug
[ ] Docs / tests

Description
useId() generates ids during SSR and includes microfrontend differentiation to prevent collisions.
Implements useId() for SSR element reference.
includes support for microfrontends
includes @manucorporat base changes
Co-authored-by: @nnelgxorz
Use cases and why
useId() enables animation engines, accessibility APIs, etc. to access elements by id, reducing client-side execution time.
See Discord Conversation
Checklist:

[X] My code follows the developer guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[X] Added new tests to cover the fix / functionality

@manucorporat, the el.getAttribute() in fast-calls.ts was failing in PR #2459, which landed here.


remove the solution folder

Description
The solution has been superseded by https://github.com/terraform-ibm-modules/terraform-ibm-account-infrastructure-base
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline


FYI: Don't init a project named Sample

Os: 10.12.1 Beta (16B2338c)
Initialized a project named Sample and had duplicate name conflicts, and app loaded empty.

How it looks like exactly? I tried this:
react-native-macos init Sample
open Sample/macos/Sample.xcodeproj

and get working project with latest (0.10.x) react-native-macos.

I removed my personal paths, but this it right here;

node version: v6.8.0
nvm version: 0.29.0
react-native-macos-cli: 0.2.1

Failed to build DependencyGraph: @providesModule naming collision:
Duplicate module name: Sample
Paths: /react-native/Sample/package.json collides with /react-native/Sample/node_modules/react-native-macos/Libraries/Sample/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
Error: @providesModule naming collision:
Duplicate module name: Sample
Paths: /react-native/Sample/package.json collides with react-native/Sample/node_modules/react-native-macos/Libraries/Sample/package.json

This error is caused by a @providesModule declaration with the same name across two different files.
at HasteMap._updateHasteMap (/react-native/Sample/node_modules/react-native-macos/packager/react-packager/src/node-haste/DependencyGraph/HasteMap.js:155:13)
at /react-native/Sample/node_modules/react-native-macos/packager/react-packager/src/node-haste/DependencyGraph/HasteMap.js:130:31
~
Process terminated. Press  to close the window

Do you have the same problem with https://github.com/facebook/react-native? And can you try to init project in different folder (not a react-native)

This type of error is often encountered when you have installation problems with watchman, at least for vanilla react native. I'd check your npm version, and make sure flow watchman is installed right.

Tried doing some debugging with the latest RN iOS and RN macOS.
Specs:
node: v7.4.0
react-native-macos-cli: 0.2.1
react-native: 2.0.1

react-native-macos init Sample creates a project, that builds successfully but then errors out on the Packager when loading bundle:

However, the exact same behavior is seen in React Native iOS:

I've tried resetting-cache, tried cleaning my flow and watchman watchers. As well as reinstalling all modules or pruning npm cache.
Thoughts? @ptmt maybe we should close this issue since it's been a while, and Sample shouldn't be a good application name. As well as the overlapping bug behavior with React Native.

Yes, let's consider that Sample is reserved name by system. Same with Button, Alert and others.


Fix docs build

Fixes paradox build and adds a task to the PR validation workflow to validate that it can build properly.

Codecov Report

Merging #54 (c8a6944) into main (2c56525) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   76.13%   76.20%   +0.06%
==========================================
  Files         163      163
  Lines        2958     2958
  Branches       65       65
==========================================
+ Hits         2252     2254       +2
+ Misses        706      704       -2

Impacted Files
Coverage Δ

...health/windows/actor/HealthSignalWindowActor.scala
94.25% <0.00%> (+2.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c56525...c8a6944. Read the comment docs.


[Feature] ParallelEnv always creates and EnvCreator for compatibility with collectors

Description
When setting a ParallelEnv in a remote data collector and not embedding the env maker in an EnvCreator, an error is raised.
This PR solves this issue.

Should revamp this from scratch


Milestone 5 - menu and start/end loop

Adds:

The ability to start the game from a splash screen
The ability to quit the game by pressing escape or -/select/back/share
Dying goes back to main menu instead of simply sitting there
Makes enemies keep a respectable distance from the player instead of nuzzling it lovingly
Fixes map not scaling with window resizes

This is looking good, merging. From there, we can work on improving the game feel, and it's time for a full code review.


[MB-11991] Upgrade to go 1.18

Jira ticket for this change
Summary
This PR updates the project from Go 1.17.7 to Go 1.18.
Go 1.18.x version history:
https://golang.org/doc/devel/release.html#go1.18
Here's the corresponding PR from circleci-docker for the docker image hash referenced in this PR.  Please verify that it seems correct and that all relevant references have been updated.
After this PR has been initially vetted, I will merge in the circleci-docker PR and update this PR with the new hash.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps
To move your local dev environment to 1.18 (assuming you're using asdf):
asdf install
asdf global golang 1.18

You may want to restart your terminal window after this if you run into issues.
If you're using nix instead, you should be prompted to run ./nix/update.sh .
After moving to go 1.18, just try out your normal day-to-day workflow and see if anything falls out.
Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Messages

:book:
:link: MB-11991

  Generated by :no_entry_sign: dangerJS against 8f7f497e2773caf1e256489e0c94a26c9817ce9e

This branch's history and its checks have gotten a little off now that I've rebased it, changed base images, and merged other related PRs so much.  Rather than trying to figure out exactly what happened, I'm closing this PR and creating a new one off a new branch now that some prerequisite PRs have been merged.


Helm is broken

If you enable helm in init.el and then run find file (or if you don't want to disable ivy M-x helm-find-files) you get an error stating: Invalid function: with-helm-buffer

I am unable to reproduce this.
with-helm-buffer is defined in helm-lib.el, which is loaded by helm.el.
Have you updated helm recently? Are you sure you ran make or make install after enabling helm?

With 0739e8cd, I've tried to fix this issue. Please update and let me know if it does.

Pulling develop I get the following issues. When I open emacs a minibuffer pops up and says: Error (use-package): rspec-mode/:init: Symbol's value as variable is void: doom-auto-minor-mode-alist and when I try to find file I get: `Wrong type argument: bufferp, "helm find files". I've also commented out all my personal helm configuration to make sure it is not related to that.


Update .desktop file to use only official categories

Official categories being those specified in Appendix A of the Freedesktop.org Desktop Menu Specification v1.0: http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry
Current configuration was messing with my Xfce menu a bit.

Thanks for your contributions! Sorry for responding so late, I was relatively busy last week with school and pre-season work for my team.
Greetings!


[Feature] Always show failed buildlogs in result details

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Client: I followed the coding and design guidelines.
[x] Client: I added multiple screenshots/screencasts of my UI changes

Motivation and Context

In case we received any feedback, any build result would be ignored and not shown in the result details modal.
Description

In case we have received a failed build log, it is getting displayed together with the feedbacks.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Create a programming exercise with the setups described below
Now create an SCA issue (e.g. in Java wrap code in redundant curly braces) and let the build fail (e.g. omitting a semicolon)
Verify that the result details shows the feedback and also the failed build logs
It should be shown in Online Code Editor, Course Exercise Detail, Course Exercise Row and Exams (anywhere where the result is accessible)

The following scenarios need to be tested (in total 8 programming exercise setups):

Course + exam exercises
With and without SCA enabled
With and without online code editor

Test Coverage

no changes.
Screenshots

SCA Feedback + failed build logs:

The testing steps need to be more extensive. We should test all exercise configurations, i.e.

Course + exam exercises
With and without SCA enabled
With and without online code editor

this means at least 8 programming exercises
@derLalla please update the testing steps accordingly
To all the testers: Please clean up those programming exercises after testing)

it really depends on the SCA issue, so if there is a build error, the SCA tools which are used by the build agent are not run or also fail.
What this PR is trying to fix is that if there are failed build logs AND there is SCA feedback, that both are getting shown instead of just the SCA feedback

Please add a section title "Build error" before the bulldogs
Show this section and the build logs only when they actually exist (i.e. when the build failed, which should be indicated in the submission)
Build logs with compile errors are more important than static code analysis issues, so please show them first

done in 48fd0a59d4d5fcb54be29f9b89aa1215da5ddb70

I couldn't test the no editor for exams b/c I always have an error with cloning the repository in exams.
Noticed though for code-editor=enabled, SCA=enabled, the build log doesn't show the SCA error for exams. Not sure if this is intended, just noticed the behavior was different
code-editor=enabled, SCA=enabled, regular exercise (not an exam)

the build output shows the SCA error

code-editor=enabled, SCA=enabled, exam mode

the SCA error shows in the "Build failed" and the code editor (highlighted with green), but not in the build output (highlighted with red).

Behavior looks mostly the same (some more build logs are showing for me), hence approving

which test server did you use? Usually are these more detailed build logs not shown


 The lack of a blocking commit meant that we were trying to run a refresh operation without the system having the correct data in place for a refresh to happen

bors merge

bors retry


Fix several typos and grammar mistakes

I scanned over the tensorflow lite android quickstart.md file and found some typos and errors that should be addressed.
Also, I fixed the repetitive occurrences of the the in some files.
These are all combined into a single pull request, and this is not a “one-liner” correcting one error.

Hi @rohan100jain Can you please review this PR ? Thank you!


No longer searches for VS Code workspaces

Microsoft PowerToys version
0.78.0
Installation method
Chocolatey
Running as admin
None
Area(s) with issue?
 No errors in logs
Other Software
Version: 1.86.0-insider (user setup)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T03:29:50.526Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000

Could you attach /bugreport? Thanks
Also, if you type space after pressing {, does it show VS workspaces?

After pressing space workspaces does shows up, but only local, no WSL workspaces, and search still does not work.
PowerToysReport_2024-02-01-14-11-22.zip

it came back after reboot. Sometimes i forget this is Windows :D

Had to reopen. Stopped working after few hours...

I've encountered the same issue and restarts don't fix it.
Most of my workspaces are WSL based, but the files still exist in the Windows FS.
This issue was encountered after updating.

So this never happened before 0.78 version? Is that correct? /needinfo

yes, worked flawlessly

Since my upgrade to 0.78 I am also encountering issues with missing workspaces - I never had any issues before. For me it's also my WSL workspaces missing, in particular WSL1 workspaces.

I have the exact same issue after updating to 0.78.0. However, all workspaces (even non-WSL workspaces) do not show, and only show up 10-15 seconds later regardless of whether I start typing the workspace name. Other PT Run plugins seem to work fine.
PowerToysReport_2024-02-19-23-35-23.zip

This has been worked on during the 0.79.0 release cycle.
Please update to the latest: https://github.com/microsoft/PowerToys/releases


Stale type expression for Node inputListeners

In Node.ts, line 228:
  'inputListeners', // {Array.<Object>} - The input listeners attached to the Node, see setInputListeners() for more documentation

Should this be {IInputListener[]}, to match the definition on line 334? :
  inputListeners?: IInputListener[];

Removed the extra type documentation above (since it's much better to refer to NodeOptions). Perhaps the rest of the documentation there should be moved/removed/combined (so we have one good place for it?)

Perhaps the rest of the documentation there should be moved/removed/combined (so we have one good place for it?)

Agreed. Want to handle that as part of this issue, or in a new issue?

This issue works, will handle.


Documentation: Clarify usage of NUMERIC type as floating point alternative

The "Numeric Types" page states in the 'Floating Points Caveats' section:

If you require exact storage and calculations (such as for monetary amounts), use the numeric type instead.

Maybe 'numeric' could be changed to either 'NUMERIC type' or 'decimal type' or 'DECIMAL type' to avoid confusion with the topic of the page.
One has to already know that 'NUMERIC' is an alias for 'DECIMAL' to immediately get the sentence otherwise.
Page URL: https://duckdb.org/docs/sql/data_types/numeric.html

@rgieseke that's a very good point – thanks! I submitted a fix.

Thank you, that's a very nice and thorough solution (I wasn't sure which version works best, yours does!)


dxfeed doesn't seem to have EventType type

$ tt
Traceback (most recent call last):
  File "/Users/john/depot/tastytrade/venv/bin/tt", line 5, in <module>
    from ttcli.app import main
  File "/Users/john/depot/tastytrade/venv/lib/python3.12/site-packages/ttcli/app.py", line 6, in <module>
    from ttcli.option import option
  File "/Users/john/depot/tastytrade/venv/lib/python3.12/site-packages/ttcli/option.py", line 8, in <module>
    from tastytrade.dxfeed import EventType, Greeks, Quote
ImportError: cannot import name 'EventType' from 'tastytrade.dxfeed' (/Users/john/depot/tastytrade/venv/lib/python3.12/site-packages/tastytrade/dxfeed/__init__.py)

Hi, this is because EventType was removed in v9.0. If you do pip install tastytrade==8.5 you can probably get it working, though hopefully I can get the CLI updated soon as it hasn't been touched in a while.

This should be fixed in the latest release!


fix build on 32bit systems

closes #66

I think I would prefer to switch the constant to simply use math.MaxInt32 instead.  It feels odd to me for a config setting to use the size specific types.  Do you  have any opinion on this?

That's fine by me.


Add support for a new traffic source type

On the glider world we have a new source of traffic data and are the FLARMs/OGN trackers.
The Open Glider Network (OGN) collects all of that position data with more than 1000+ OGN stations and broadcast that thru their servers.
See the details on http://wiki.glidernet.org
See the traffic on   http://live.glidernet.map
We are willing to provide that data on the GUTMA Airtraffic Data protocol, however we need a new value for the traffic_source field, perhaps we can use the value 7 used as well as 2, or extend the definition to be hex and use the value A.

We can easily prepare a server that will broadcast the traffic information of the GUTMA Air traffic data protocol and it can be a good test bed of how to do it.
We will be happy to inject UAV traffic into our servers coming from some other platforms, that it will benefit our gliders/paragliders pilots.

Any feedback will be very welcome

Hi @acasadoalonso Thank you for your comments and feedback. I really like the idea to do this test with you. Let us talk about it offline.
At the moment, how do you want to change the traffic_source field? Should there be a 10 or 11 there to accommodate for a OGN server?

a value of 10 will be OK.
My email is acasado at acm.org
Fell free to contact me.
AC/.

On 12 Dec 2018, at 16:16, Hrishikesh Ballal<EMAIL_ADDRESS>wrote:
Hi @acasadoalonso https://github.com/acasadoalonso Thank you for your comments and feedback. I really like the idea to do this test with you. Let us talk about it offline.
At the moment, how do you want to change the traffic_source field? Should there be a 10 or 11 there to accommodate for a OGN server?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/hrishiballal/airtraffic-data-protocol-development/issues/42#issuecomment-446623400, or mute the thread https://github.com/notifications/unsubscribe-auth/AHw8Z64Nv0e8LLmgUTSab7LA4G4qbYsGks5u4R26gaJpZM4ZCy1q.

OK I have added it to the protocol.

I do not see it on the .md file

Sorry I closed before I pushed the fix. It is now there!


Handle CloudFront/Function URL named form actions returning 400 because of / being invalid

Is your feature request related to a problem? Please describe.
When using Lambda Function URL named form action returning 400 because of / is considered invalid
Describe the solution you'd like

Adaptor casts <form method="POST" action="?/anything"> to <form method="POST" action="?%2Fanything">
Adaptor decodes %2F to /

Describe alternatives you've considered
Manually using %2F in the code based on modify adaptor as #2 above
Additional context

https://github.com/sveltejs/kit/issues/7098
https://github.com/sveltejs/kit/issues/9057

cc @CalebBassham

In November, an AWS support rep let me know that this should be fixed for AWS Function URLs by mid January. Evidently, that has not happened.
That was way to long for me, so the solution was to not use Lambda Function URLs. Instead you can use API Gateway which works fine.  Fortunately this project uses API Gateway, so I choose to migrate from my own custom adapter (no aws adapter existed at the time) to this one.
My project also uses CDK, so it was pretty easy to add this project as a dependency and import the stack from here as a part of my stack. However, It does not come without downsides. My project is a monorepo with a relatively small number of packages (~10). Really only two matter for this scenario. One is my CDK package. One is my SvelteKit package. Both must depend on this project and the version must be kept in sync. The CDK package depends on it because it needs the stack that is exports. The SK package depends on it because it needs the adapter. Unfortunately, that is not where the version problems end. The more serious problem I have is the CDK dependencies. CDK projects must depend on aws-cdk-lib and constructs npm packages. Now because I am using the stack from this project in my own, the version of those dependencies must be kept in sync with the version this project is using at the time. Which is 1, a pain, and 2, sort of a problem since this project doesn't have to update super often. But that is not all! CDK also has a CLI which must be kept at the same version as aws-cdk-lib. The kicker is that, as far as I know, none of this is manageable by npm or pnpm. Every time I update the packages of my project now, I must go through this tedious process:

Make sure both my SK and CDK packages updated to the same version of sveltekit-adapter-aws
Check what version of aws-cdk-lib and constructs that sveltekit-adapter-aws is using. Update my aws-cdk-lib and constructs to use the same version.
Update the CLI (aws-cdk) to be the same version as aws-cdk-lib

It is not the worst process to go through, but it is not convenient.  However, I am willing to go through it since I no longer have to maintain an AWS adapter on my own which was much less fun. It is something that could probably be automated with a script somewhat easily.
This is probably way more information than you were asking for, but you also didn't really ask a question. I figured I would just give an update on what I have done since my last post.

@CalebBassham Thanks for sharing! I use terraform for everything and was hoping to avoid using APIG for simplicity. AWS SecurityHub has also been complaining the Lambda using Function URL for having authorization=NONE.

Yea, it seems that Function URLs work OK for something "quick and dirty," but a lot of cracks start to show once you dive in a little bit. Hopefully they can get it worked out because it is really convenient compared to APIG for single handler applications.

Something I noted to AWS was that your can't whitelist query strings with / or ~ (not url encoded) into the CloudFront origin request policy, indicating it might not just be function urls.

Interesting, CloudFront will handle it just fine though if there is a query string with / that passes through.


When maskTypename: true, a new reference is returned for useQuery data when the query becomes stale

Describe the bug
When a query is invalidated after a mutation selects the same typename, the query immediately returns a new reference to the existing data when stale becomes true and the query is re-executed. This only happens when maskTypename: true is set on the client instance, and seems to be a new behaviour since v4. The behaviour is the same whether the query is invalidated using additionalTypenames, or automatically based on the typenames that are selected both in the mutation and query. In our case (and likely all others), the new data reference is invalidating and re-running useEffect/Memo/Callbacks before the actual structure of the data has possibly changed when the query resolves.
In the attached reproduction link, the small React application will add or remove a "hooray" reaction to this issue when the respective button is clicked. After each mutation, the repository query is then re-executed to fetch all reactions for this issue. There is a useEffect that contains only the useQuery data value in its dependency array, so we can easily see when the data reference changes. With maskTypename: true, the reference changes once when the query is executed (the actual data is the same), and once again when it resolves. Without maskTypename: true, we see the "correct" behaviour where the reference only changes after the query has resolved.
Note:
A GitHub personal access token (classic) is required to query the GitHub GraphQL API in the reproduction app. It can be created at https://github.com/settings/tokens/new, with the public_repo scope checked.
Reproduction
https://codesandbox.io/s/elegant-bhaskara-4qkldf
Urql version
urql v4.0.4
Validations

[X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
[X] Read the docs.
[X] Follow our Code of Conduct

Just a disclaimer, I'm thinking of deprecating maskTypename, since it's only useful in case of "laziness" 😅 to be more precise, it's only useful, if *three whole conditions are true:

the API mimicks inputs that mirror outputs
the user doesn't actually provide the inputs
the selection sets of both match precisely

So, that's a lot of "ifs" for a pattern that's basically not technically speaking best practice imho 😅
Anyway, that said, the fix for this particular situation is simple; I can do the maskTypename logic earlier in the chain.
That said, it doesn't fix any of the underlying issue, i.e. it'll mess with reference equality guarantees in Grapchache either way.
Just stating this here, because, it's probably easier to document here that this old feature may not last, and that future fixes re. reference equality won't be applied 😅

Hi @kitten Thanks for your response and the explanation. We will remove our usage of maskTypename in that case - we can survive without it 😄


Update faq.md

It's just a typo on the faqs.

Could you run tools/scripts/format_website.sh and commit the results?

Yeah, sure.

Actually my repo stays the same after running it. Is it the same file that should be modified?

Maybe I should do something else beforehand? I just cloned the repo and run the script. The first commit was made via github.

Did you check out your branch after cloning? It's definitely that script that failed: https://buildkite.com/sorbet/sorbet/builds/10595#1f2ad297-474d-42dd-a30c-f5cff400432f/158-180

nvm wrong branch

Should I squash the commits or is it fine that way?

It's fine the way it is -- we always squash merge PRs.

NP, thank you too for making this awesome tool!~


”Hălăucești” is listed in the drop-down menu

Description:
"Hălăucești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Hălăucești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Hălăucești, IAȘI".


Support for NATS 2.4.0 new fields

Add deliver group for consumers

This would be nice. It is a blocker to use NACK in K8s setup with latest server version.

This has been fixed on main already #39


WireTapAbortPolicyTest is flaky

Description

Target

[ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

@davsclaus wow, thanks for the fix! I worked flawlessly here.


Add Dockerfile, Makefile rule, Goreleaser, and Github action

This PR adds a Dockerfile to containerize the configurator. The container includes the main driver binary executable as well as the default plugins built with the project. It also includes a new Makefile rule that should make it easy to build by simply running make docker.

Can you add a GitHub action and goreleaser config for this service as well?

I made some Makefile comments, some of which need to be addressed (hence requesting changes), some of which are suggestions for more flexibility.
All of the fixes and recommendations can be summarized by a modified Makefile that I got working as follows:
# Unless set otherwise, the container runtime is Docker
DOCKER ?= docker

prog ?= configurator
sources := main.go $(wildcard cmd/*.go)
plugin_source_prefix := pkg/generator/plugins
plugin_sources := $(wildcard $(plugin_source_prefix)/*/*.go)
plugin_binaries := $(addprefix lib/,$(patsubst %.go,%.so,$(notdir $(plugin_sources))))

# build everything at once
.PHONY: all
all: plugins exe test

# build the main executable to make configs
.PHONY: main driver binaries exe
main: exe
driver: exe
binaries: exe
exe: $(prog)

# build named executable from go sources
$(prog): $(sources)
        go build --tags=all -o $(prog)

container: binaries plugins
        $(DOCKER) build . --build-arg --no-cache --pull --tag 'configurator:test'

container-testing: binaries plugins
        $(DOCKER) build . --tag configurator:testing

# build all of the generators into plugins
.PHONY: plugins
plugins: $(plugin_binaries)

# how to make each plugin
lib/%.so: pkg/generator/plugins/%/*.go
        mkdir -p lib
        go build -buildmode=plugin -o $@ $<

# remove executable and all built plugins
clean:
        rm -f configurator
        rm -f lib/*

# run all of the unit tests
test:
        go test ./tests/generate_test.go --tags=all

NOTE: The Docker label and tag is hard-coded in the above and needs to be changed to be dynamic. I also didn't include some .PHONY directives that probably should be included.
The above provides some benefits:

Modifying the Makefile is not required for adding/removing plugins
Using a different container runtime other than docker is supported
Things are only rebuilt when their sources change

These all look like good changes to make. I'm going to go ahead and add them and push.

Looks like that final change was made. Can I get another review on this @synackd?

I don't think I have write access to this repo, otherwise it would allow merge.

I don't think I have write access to this repo, otherwise it would allow merge.

You should have access now.


Catalog Search & Filter Toolbar Not Responsive Multiple Screen Sizes

Description
The Catalog search and filter toolbar is sometimes broken into two rows, depending on the screen size. While that is what should be happening for small screen sizes, it happens on large ones as well. This should be fixed.
Screenshots

Should be fixed with https://github.com/KaotoIO/kaoto-ui/pull/605. Note that on mobile you will still have the splitting of the toolbar as it should, but at least now on desktop you can still decrease the screen size without it breaking.


User friendly look

Make it a user friendly terminal based tool.

Hey ! I would love to work on this by making my first Hacktoberfest submission.
It would be great if you assign me this.


#Mongo_optimization_tasks. AleksandrGogolushko

https://travis-ci.org/github/AleksandrGogolushko/db-assignments/builds/715497166

Thanks for the efforts. The PR is accepted


Filter Affixes not working

- Amulet:     affixPool:     - count:       - {name: to_conjuration_mastery}     itemType: [amulet]

- Staff:     affixPool:     - count:       - {name: lucky_hit_up_to_a_chance_to_restore_primary_resource}     itemType: [staff]

Both items are redflagged

2024-08-14 | 15:51:54.511 | ThreadPoolExecutor-0_0 | WARNING | src.item.descr.find_affixes:125 | Affix does not exist: cleaned_str='critical strike damage skills deal up to increased damage based on your available primary resource when cast, receiving the maximum benefit while you have full primary resource.' ||| combined_lines='+96.0% critical strike damage [80.0 - 100.0)% skills deal up to 16%[x] [10 - 40]% increased damage based on your available primary resource when cast, receiving the maximum benefit while you have full primary resource. requires level 80 sorcerer sell value: 103,174 durahilite 100100,'
There might be more bugs regarding affixes
Version 5.7.3

Thank you. I won’t be at my PC until Sunday, but please try out version 5.7.4 and see if it helps. A user on Discord confirmed that it works for 1080p with small and medium settings.

- ChestArmor:     affixPool:     - count:       - {name: intelligence}       - {name: maximum_life}       minGreaterAffixCount: 0     itemType: [chest armor]
Still not working in 5.7.5
I like to help is there a debug mode ?

The item is detected properly in 5.7.5.

Correctly filtered in 5.6.4

not filtered in 5.7.5
Is there a way to dump the ocr results just to see if its a ocr problem or the bug is elsewhere ?

We can run our detection on a screenshot, that is what I have done to verify it working in 5.7.5

multi lines should be fixed with 5.7.6

still red bordered in 5.7.7 while correctly green in 5.6.4

I just ran it and the detection is 100%. So it can't be a detection issue. What is your filter?

how can it get your screen ?
the filter is:
- Staff:     affixPool:     - count:       - {name: intelligence}       - {name: critical_strike_damage}       - {name: maximum_life}       minCount: 2       minGreaterAffixCount: 1     itemType: [staff]
but i the filter works in 5.6.4 so i would say the yaml.file is fine

how can it get your screen ?
I ran our code from source as debug. No other easy way.

the filter is:
- Staff: affixPool: - count: - {name: intelligence} - {name: critical_strike_damage} - {name: maximum_life} minCount: 2 minGreaterAffixCount: 1 itemType: [staff]
but i the filter works in 5.6.4 so i would say the yaml.file is fine

can you format it correctly or upload the file to pastebin? indentation is important.

the code is created by the gui

It is detected and filtered correctly. No idea why it isn't working on your end :(

That's why i asked how to debug it, i use Visual Studio but in C++/C#. I am doing my best to set it up for python

Can you send me a full screenshot where you are hovering over the item? Without d4lf running of course.
Btw hop into our discord, easier to chat ;)

i am in the discord :-)

As discussed, increasing resolution and/or quality solved the issue


Move/rename Assembly files into standard/assembly, combine c#/vb files, update tocs, add redirects

Per User Story https://mseng.visualstudio.com/TechnicalContent/_workitems/edit/1576023

@rpetrusha @mairaw - This is ready for review - please see email. Thanks.

@rpetrusha - All of the work in User Story https://mseng.visualstudio.com/TechnicalContent/_queries/edit/1576023 is now done in this PR, except for replacing the links in the dotnet/dotnet-api-docs repo. See the rather lengthy email I sent with some notes and questions. Thanks for reviewing.

I don't see this merge conflict, but will close-reopen PR to get a build to see if it goes away.

@rpetrusha @mairaw - GitHub reports a merged conflict in docs/framework/app-domains/strong-named-assemblies.md, which is now docs/standard/assembly/strong-named.md. I can find no such merge conflict. I rebuilt the PR and the build passes validation yet still reports a merge conflict. Not sure what to do.

Ha that worked.

@rpetrusha - I think I've made all the changes you requested up till now, with the exception of three. See the conversation for the 3 yet-unresolved ones. You have to expand all of the 40 and then 20 hidden comments to see them. And it's very possible I could have missed things.
I realize you have more reviewing and changes to make (for one thing, I think unloadability.md may have to move), but this PR is unworkable as is. Can this PR be merged as soon as possible and we can go forward with the remaining changes in smaller PRs? Thanks.

@rpetrusha - I've now made all the changes you requested so far, except the following:

Under contents.md: "For topics in the .NET Standard guide, you can add an additional .NET Core entry. In this case, though, since .NET Core doesn't support multifile assemblies, a better entry is: "assemblies [.NET Core]"
I made this one change in this file as requested, but I'm not sure if or what you are asking me to add or remove from other files.
Under get-type-member-information.md, which has now been moved to reflection-and-codedom: "These large blocks of code are best moved to the samples repo. They could go in ~/samples/snippets/standard/reflection/memberinfo/. The code could also be modernized somewhat, especially by using interpolated strings in the C# and VB code."
It would be great if I could do this in a later PR, in the interest of merging this one asap. But I can probably get to it in another day.

@rpetrusha - I'm very sorry about any misunderstanding regarding this User Story. Even though we met and discussed it, I understood the task to be basically a lift and shift, and combining 7 articles that were virtually identical except for C# vs VB code snippets, i.e. more of a production task. Only 2 articles seemed to need substantial rewrites. If I had realized, as I should have, that all affected articles should be refreshed and rewritten, I would have approached this very differently, worked in an upstream release branch, and probably only have moved and rewritten one article per PR. But at this point, probably the only way out is through. Thanks for your patience and perseverance.

I've resolved some merge conflicts after merging some large PRs today,

@rpetrusha - I'll get busy on these changes, but could you repeat/clarify your instructions about the language-specific tabs? Are you saying to remove the tabs from all the articles? I think so, but appreciate confirmation.
And in the one get-type-member-information.md article, you're asking me to move the snippets to the code repo, correct?

Certainly, @v-thepet. I would like the tabs removed. And it would be nice to have the code from the  get-type-member-information.md article in dotnet/samples rather than embedded in the article.

@rpetrusha

Certainly, @v-thepet. I would like the tabs removed.

The only problem is that when the code is actually cmd line but is language specific, we can no longer label the different cmd lines cmd, but have to label them csharp or vb, which they aren't technically.

Try one more build as samples might not have been available yet.


C# Sample 21: corebot-app-insights

In the C# Sample 21: corebot-app-insights, both the bookingDialog and dialog (MainDialog) objects are Component Dialogs, and hence if you set its Telemetry Property that will permeate to all its child dialogs,  which means that all of the code setting up telemetry (TelemetryClient = telemetryClient) in the bookingDialog & MainDialog constructors (in the AddDialog method calls) are not needed.
bookingDialog.cs:
I think that the line setting the TelemetryClient variable in the constructor should remain, but all of the TelemetryClient = telemetryClient lines in the AddDialog method calls (for example lines 20, 24, 28, 39) are not needed.  With the exception of the line setting the TelemetryClient variable, BookingDialog.cs should remain the same as the CoreBot sample.
MainDialog.cs:
I think that the line setting the TelemetryClient variable in the constructor should remain, but all of the TelemetryClient = telemetryClient lines in the AddDialog method calls (for example lines 29 and 41) are not needed.  With the exception of the line setting the TelemetryClient variable, MainDialog.cs should remain the same as the CoreBot sample.

See Dialog code in the Bot Framework SDK:

Dialog.TelemetryClient

DialogSet.TelemetryClient

ComponentDialog.TelemetryClient

WaterfallDialog.AddStep

An issue was logged against the docs that is impacted by this: Issue 1388

@munozemilio FYI


Add support for OPTIONS HTTP verb in Handler Groups

Describe the feature
Like the endpoint-handlers which supports the options http verb, it would be beneficial if Handler Groups could support it as well for grouping the endpoints together.
Additional context
In CORS, a preflight request with the OPTIONS method is sent, so that the server can respond whether it is acceptable to send the request with these parameters. The Access-Control-Request-Method header notifies the server as part of a preflight request that when the actual request is sent, it will be sent with a POST request method. The Access-Control-Request-Headers header notifies the server that when the actual request is sent, it will be sent with an X-PINGOTHER and Content-Type custom headers.  The server now has an opportunity to determine whether it wishes to accept a request under these circumstances.

Thanks for your issue @rr83019. Have you seen the enable cors config option?

Yes, but I need to explicitly define the OPTIONS endpoint. The Handler groups does not support that.

That is true. Considering it never comes up, I don't think it's right to add these uncommon verbs to the ApiBuilder.
I can make the staticIntance() and prefixPath() methods of the ApiBuilder public though, then it would be very easy to make your own static options method to use inside a HandlerGroup.

Oh, cool. That would be great.
Thanks.

Done in https://github.com/tipsy/javalin/commit/fb47f51ced8a562f78a002a7fa70cff9b680cfe6, will be released later this week !


Rename Nimrod to Nim

Just a simple name change, since the project was renamed a while ago, see:
https://github.com/Araq/Nim (description)

@MatejLach Duplicate of #1936 ;)
@arfon I feel like there's going to be a lot of people accepting that CLA ^_^

@pchaigno Yeah, closing this one.


MM-25449 Update regex used for trimming strings

The actual changes for this are here: https://github.com/mattermost/marked/pull/18
Ticket Link
https://mattermost.atlassian.net/browse/MM-25449

@hmhealey
Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-#5589-upstream-release-5.24-1590676063
Branch 'automated-cherry-pick-of-#5589-upstream-release-5.24-1590676063' set up to track remote branch 'release-5.24' from 'upstream'.
+++ Downloading patch to /tmp/5589.patch (in case you need to do this again)

+++ About to attempt cherry pick of PR. To reattempt:
  $ git am -3 /tmp/5589.patch

Applying: MM-25449 Update regex used for trimming strings
Using index info to reconstruct a base tree...
M	package-lock.json
M	package.json
Falling back to patching base and 3-way merge...
Auto-merging package.json
CONFLICT (content): Merge conflict in package.json
Auto-merging package-lock.json
Patch failed at 0001 MM-25449 Update regex used for trimming strings
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

+++ Conflicts detected:

UU package.json

+++ Aborting in-progress git am.

+++ Returning you to the master branch and cleaning up.


cannot log in

I can log in at chrome, but not at edge.
It keep logging in ......

with github account

@z7skr Please use Chrome Extension on Edge browser, download it from here:
https://chromewebstore.google.com/detail/one-tab-group-tabtab-grou/lajbajamkpmkmldodfbljkjihppdclbm


Type annotations can only be used in TypeScript files in handler

Handler code
async ({ require }) => {
  const { MutationInputLink } = require("@deep-foundation/deeplinks/imports/client_types");
  const a : MutationInputLink = {

  }
}

Error
Type annotations can only be used in TypeScript files.(8010)

Duplicate of https://github.com/deep-foundation/deepcase/issues/83


3.4 doesnt support transparent controls

Godot version
3.4.beta4
System information
Windows 10
Issue description
It appears that the TextEdit background_color cannot be set to fully transparent in a theme. When this setting is applied, the TextEdit still displays the default blue/purple color. This appears to be the case in both the background color Theme Override, as well as if Color(0, 0, 0, 0) is present in the theme itself.
Steps to reproduce

Create a TextEdit
In the inspector, set "Syntax Highlight"=On (required for background_color override to work)
Set Theme Overrides -> Colors -> Background Color to something fully transparent
TextEdit shows the blue/purple color instead of what's behind it.

Minimal reproduction project
transparency.zip

Do you want to remove the existing background from the TextEdit? If so, you need to set up its styleboxes, namely the "normal" one and the "focus" one. Background color is used for something else.

Ok. I'll try that. Thanks.

Ok. So I can confirm that the suggested solution resolves my issue.
Do you think it warrants further discussion about the intended behavior when selecting transparent for the background color? I do find it to be a somewhat confusing behavior, but I'll leave it to you all to decide if this ticket should be closed or not. Thanks.

Looking at the code, I'm not entirely sure why it's needed. It just draws on top of the stylebox if it has some color to it (alpha over 0.01). In stable it also checks for syntax highlighting being enabled indeed. Because of that I think it may be a hack to expose it to the editor settings for the script editor without touching the styling of the TextEdit node. Though it can still be done with custom styleboxes, removing the current confusion.
@Paulb23 what do you think?

Is that used by the theme loader?

Is that used by the theme loader?

What do you mean? What theme loader?

I mean the editor syntax themes. They seem to contain a background_color, e.g.
https://github.com/godotengine/godot-syntax-themes
[color_theme]
background_color="ff242424"
completion_background_color="ff343434"
...

Maybe that's unrelated?

Ah, yes, that's what I've said here:

I think it may be a hack to expose it to the editor settings for the script editor without touching the styling of the TextEdit node. Though it can still be done with custom styleboxes, removing the current confusion.

Ah. Ok. Right on.

Yeah if I remember correctly it was originally only designed for the editor.
We could remove it, shouldn't cause any issues apart from maybe usability, as its bit more work to generate 3 styleboxes rather then changing a colour.

We can still expose it to the settings as a color, but instead of just passing it to the script editor as a color we can generate 3 styleboxes (or rather, copy the existing ones and change their bg color).
Basically, just a bit of work around this line:
theme->set_color("background_color", "CodeEdit", EDITOR_GET("text_editor/theme/highlighting/background_color"));


Incrementalise Tokenisation.transform()

Currently, this algorithm is not incrementalised.  This should be relatively easy to do, but it would be useful to actually do it!

This needs to do at least two things:

Normalise length of starts to match that of items.  Basically, by applying the Delta with dummy boolean data.
Incrementally work through the individual Rewrite instances.

Currently, have hacked together a very inefficient solution for (1) above using iterators and maps.  It copies too much data though!

For (2) need to add some kind of method Tokenisation::update_starts() or similar.


Fix material plugin calls without register

Superseds https://github.com/BabylonJS/Babylon.js/pull/14662

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14664/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14664/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14664/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14664/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14664/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14664/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14664/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14664/merge#BCU1XR#0


Figure text should not be in the output when all_texts=False

Bug report
all_texts should control whether text is extracted from figures (at least according to the docs).
Expected Behaviour (at least by my understanding):

all_texts=True should extract text from figures, performing layout analysis.
all_texts=False should ignore text in figures entirely, and so such text should not be in the output at all.

Actual Behaviour:
:heavy_check_mark: When all_texts=True the text is extracted and layout analysis is performed.
:no_entry:  When all_texts=False, layout analysis is not performed (which is fine), but the text still appears in the output (which is wrong).
I think the actual issue should be "Figure text should not be in the output when all_texts=False".
Note: I've seen some PDFs where ALL the text is inside a figure according the to the structure. In this case, the output would appear blank unless you pass all_texts=True. This is probably unavoidable, but we'd have to watch for this case if people submit tickets about there being no output.

Hm, actually @pietermarsman this isn't quite what I meant. Just to enhance on my comment and hopefully make it clearer:
all_texts should control whether text is extracted from figures (at least according to the docs).
Expected Behaviour (at least by my understanding):

all_texts=True should extract text from figures, performing layout analysis.
all_texts=False should ignore text in figures entirely, and so such text should not be in the output at all.

Actual Behaviour:
:heavy_check_mark: When all_texts=True the text is extracted and layout analysis is performed.
❌ When all_texts=False, layout analysis is not performed (which is fine), but the text still appears in the output (which is wrong).
I think the actual issue should be "Figure text should not be in the output when all_texts=False".
Note: I've seen some PDFs where ALL the text is inside a figure according the to the structure. In this case, the output would appear blank unless you pass all_texts=True. This is probably unavoidable, but we'd have to watch for this case if people submit tickets about there being no output.

Ah, oops :facepalm: I thought I was being proactive :wink: I've changed the title and the description to you explanation.

No worries, I should have just opened an issue :)


Restart H2O cluster on failure

Is there any update?

Is there any update?

Hello @ICESDHR. No, no progress so far.
Didn't have time to finish this yet, but I sure can. @michalkurka is the team lead, tagging him to get any input on this - is this a priority now ?
A simple restart, without checkpoints, should be doable rather quickly as an open source contribution.

@ICESDHR no update yet, it is currently not on our roadmap to implement this feature


Kerberos auth is partially broken

Reposting the issue here from forums, because my investigation shows there is a degradation with Kerberos support in Kibana.
I’ve upgraded my OpenDistro ES + Kibana setup from 1.1.0 to 1.4.0 and noticed that querying data in Kibana no longer works:

https://elastic-server/_opendistro/_security/authinfo - WORKS
https://kibana-server/app/security-accountinfo - WORKS, shows my username and roles
https://kibana-server/app/kibana#/discover - NOT WORKING

Digging into HTTP packets between Kibana and Elasticsearch shows:
Authentication Exception :: {"path":"/_msearch","query":{"rest_total_hits_as_int":"true","ignore_throttled":"true"},"body":"{\"index\":\"jira\",\"ignore_unavailable\":true,\"preference\":1581456941567}\n{\"timeout\":\"30000ms\",\"version\":true,\"size\":500,\"sort\":[{\"date\":{\"order\":\"desc\",\"unmapped_type\":\"boolean\"}}],\"_source\":{\"excludes\":[]},\"aggs\":{\"2\":{\"date_histogram\":{\"field\":\"date\",\"fixed_interval\":\"30m\",\"time_zone\":\"America/Chicago\",\"min_doc_count\":1}}},\"stored_fields\":[\"*\"],\"script_fields\":{},\"docvalue_fields\":[{\"field\":\"Created\",\"format\":\"date_time\"},{\"field\":\"Resolved\",\"format\":\"date_time\"},{\"field\":\"Updated\",\"format\":\"date_time\"},{\"field\":\"created date\",\"format\":\"date_time\"},{\"field\":\"date\",\"format\":\"date_time\"},{\"field\":\"resolution date\",\"format\":\"date_time\"},{\"field\":\"updated date\",\"format\":\"date_time\"}],\"query\":{\"bool\":{\"must\":[],\"filter\":[{\"match_all\":{}},{\"range\":{\"date\":{\"format\":\"strict_date_optional_time\",\"gte\":\"2020-02-10T21:37:37.460Z\",\"lte\":\"2020-02-11T21:37:37.460Z\"}}}],\"should\":[],\"must_not\":[]}},\"highlight\":{\"pre_tags\":[\"@kibana-highlighted-field@\"],\"post_tags\":[\"@/kibana-highlighted-field@\"],\"fields\":{\"*\":{}},\"fragment_size\":2147483647}}\n","statusCode":401,"response":"{\"error\":{\"header\":{\"WWW-Authenticate\":\"Negotiate\"}}}","wwwAuthenticateDirective":"Negotiate"}
        at respond (/usr/s hare/kibana/node_modules/elasticsearch/src/lib/transport.js:349:15)
        at checkRespForFailure (/usr/share/kibana/node_modules/elasticsearch/src/lib/transport.js:306:7)
        at HttpConnector.<anonymous> (/usr/share/kibana/node_modules/elasticsearch/src/lib/connectors/http.js:173:7)
        at IncomingMessage.wrapper (/usr/share/kibana/node_modules/elasticsearch/node_modules/lodash/lodash.js:4929:19)
        at IncomingMessage.emit (events.js:194:15)
        at endReadableNT (_stream_readable.js:1103:12)
        at process._tickCallback (internal/process/next_tick.js:63:19)

so the important part here is:
"statusCode":401,"response":"{\"error\":{\"header\":{\"WWW-Authenticate\":\"Negotiate\"}}}","wwwAuthenticateDirective":"Negotiate"}

It seems Kibana does not forward "Authorization" header to Elastic in some cases.

FWIW, I am also seeing this issue with <IP_ADDRESS>. Did you or anyone else figure this out?

Looks like this is because requests proxied to elasticsearch through Kibana (via /elasticsearch) do not have an Authorization header when Kerberos has authenticated the connection.
Elasticsearch responds with a 401 {"error":{"header":{"WWW-Authenticate":"Negotiate"}}} however Kibana proxies the response back to the client with a "200 OK" preventing our clients from re-authenticating with Kerberos.
This works with basic authorization because the browser always sends the authorization header on each request. Because Kerberos authenticates the tcp connection not all requests have a authorization header and so this issue occurs.

Regarding version <IP_ADDRESS>:
Looks like this is because requests proxied to elasticsearch through Kibana (via /elasticsearch) do not have an Authorization header when Kerberos has authenticated the connection.
Elasticsearch responds with a 401 {"error":{"header":{"WWW-Authenticate":"Negotiate"}}} however Kibana proxies the response back to the client with a "200 OK" preventing our clients from re-authenticating with Kerberos.
This works with basic authorization because the browser always sends the authorization header on each request. Because Kerberos authenticates the tcp connection not all requests have a authorization header and so this issue occurs.
If Kibana responded with a 401 instead of the 200, then our clients would negotiate kerberos.

So is Kerberos for Kibana supported or not? We've configured Elasticsearch according to the documentation and get the Authentication: Negotiate challenge when accessing Elasticsearch. Kibana, however, still brings up the login form and no Authentication header is sent to the browser.
Also, the Kibana chapters in the documentation don't mention Kerberos at all.
@seraphjiang can you confirm?

So is Kerberos for Kibana supported or not? We've configured Elasticsearch according to the documentation and get the Authentication: Negotiate challenge when accessing Elasticsearch. Kibana, however, still brings up the login form and no Authentication header is sent to the browser.
Also, the Kibana chapters in the documentation don't mention Kerberos at all.
@seraphjiang can you confirm?

Looks like since the refactoring of the Kibana plugin, Kerberos was removed as an authentication type.

Looks like since the refactoring of the Kibana plugin, Kerberos was removed as an authentication type.

We are doing some "spring cleaning in the fall", and to make sure we focus our energies on the right issues and we get a better picture of the state of the repo, we are closing all issues that we are carrying over from the ODFE era (ODFE is no longer supported/maintained, see post here).
If you believe this issue should still be considered for current versions of OpenSearch, apologies! Please let us know by re-opening it.
Thanks!


meta: exclude throw branches when generating coverage

In hopes of improving the quality of the coverage report.

Codecov Report
Patch and project coverage have no change.

Comparison is base (d2e4a26) 71.29% compared to head (f3d6592) 71.29%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   71.29%   71.29%
=======================================
  Files          17       17
  Lines        2024     2024
  Branches      872      872
=======================================
  Hits         1443     1443
  Misses         90       90
  Partials      491      491

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Upgrade vertx

@k-wall I realized i based it off #1466 , so just review the last commit

Merged via CLI


[DCC] Saves, Weapon Attacks, and other buttons missing modifiers

I'm assuming this is the source of the problem: https://github.com/Roll20/roll20-character-sheets/commit/8a5f241345ce5a387c3ddf3337b781140fc897ab
Buttons for the various saves and weapon attacks are missing the total modifier value and the values are missing from the "Attributes & Abilities" tab.  Clicking those buttons rolls the saves, but no modifiers are included (shows Rolling 1d20+ = (18)). It's as if setting those fields readonly removed them from various Roll20 sheet functionality.

Pinging @sturtus , since it's their commit :)

Manually setting (WILL|REF|FORT)Check causes the buttons to populate as expected.

I don't have a Pro account anymore so I can't really test. Insane that Roll20 makes us pay to contribute to their product.

I'm in the same boat 🤣 The most I can recommend is rolling back the change, which will at least take it back to a known more-functional state.

I had a friend with Plus. Was able to test/fix and submitted a new PR.
On Tue, Sep 5, 2023 at 8:48 PM Dave Bendit @.***> wrote:

I'm in the same boat 🤣 The most I can recommend is rolling back the
change, which will at least take it back to a known more-functional state.
—
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/issues/12132#issuecomment-1707490769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPA37VUBSOEMNX7DVLS7G3XY7B7DANCNFSM6AAAAAA4MQVMYE
.
You are receiving this because you were mentioned.Message ID:
@.***>

https://github.com/Roll20/roll20-character-sheets/pull/12133

This got merged in and looks good to me.

Confirmed, looks like the issue's resolved. Thanks!


Use a fixed version for helm

Changes
helm v3 being out, this test may fail because the latest image and the
behavior change. So let's be more explicit on the version.
Hopefully fixes #943
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ :no_good_man: ] Includes tests (if functionality changed/added)
[ :no_good_man: ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide
for more details.

I0604 12:14:00.689] --- PASS: TestHelmDeployPipelineRun (214.57s)

:tada:

/test pull-tekton-pipeline-integration-tests

I0604 12:20:41.965] 2019/06/04 12:20:41 main.go:312: Something went wrong: failed to prepare test environment: --provider=gke boskos failed to acquire project: resource not found

ahah damn :sweat_smile:

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests

/lgtm

nice one 👍


Add Authorization to CORS headers

So that it works with riot-web develop

Though I'm sort of wondering why we don't accept everything?

Though I'm sort of wondering why we don't accept everything?

No idea. It was a rabbithole I didn't feel inclined to go down.

And to be honest, I was more wondering what this code was doing in a library called "util". It feels way too matrix-specific to belong here.


Appstudio update test-component-pac-fsvo

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-fsvo-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
53 seconds
build-container

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
7 seconds
sbom-json-check

✅ Succeeded
7 seconds
sanity-label-check

✅ Succeeded
9 seconds
sanity-optional-label-check

✅ Succeeded
5 seconds
show-summary


home page

👷 Deploy Preview for crpp-ai-oncology processing.

Name
Link

🔨 Latest commit
53ce845678384affdb4d02e1a4cc7ce4031d9c68

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology/deploys/636b9005ff37130008d34f2b


Update developers documentation about time data types

Just a reminder that this needs some additional work and some corrections

maybe we can revisit this in light of #284 ? Define some package level type aliases for time types?

Don't we have such aliases already for timedeltaindices etc.?

Are you saying we should document the type alias, so it shows up in the docs?

Are you saying we should document the type alias, so it shows up in the docs?

We have a "developers documentation" that was removed from the official doc and moved into the wiki. This is the page Cagtay is referring to.

On 4/1/21 9:46 AM, vhirtham wrote:

Are you saying we should document the type alias, so it shows up in the docs?

We have a "developers documentation" that was removed from the official doc and moved into the wiki. This is the page Cagtay is referring to.

Ahh I should have taken a look into this weeks ago :-) Thanks for the link!

Well, there is probably a lot of stuff outdated. Hence Cagtays comment ;)

Obsolete with PR #433


OSD-15769 : new shortcut for ocm-container has been added

What type of PR is this?
feature
What this PR does / Why we need it?
When we press CTRL + O it adds a new tab called ocm-container and when we press CTRL + A it adds a new tab called bash.
After this PR
when we press CTRL + O

when we press CTRL + A

Which Jira/Github issue(s) does this PR fix?
_Resolves _ #OSD-15769
Pre-checks (if applicable)

[x] Ran unit tests locally against the changes
[ ] Included documentation changes with PR

Codecov Report

Merging #121 (a490b3b) into main (5ba140a) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   14.86%   14.50%   -0.36%
==========================================
  Files          22       22
  Lines        1265     1296      +31
==========================================
  Hits          188      188
- Misses       1056     1087      +31
  Partials       21       21

Impacted Files
Coverage Δ

pkg/ui/input.go
0.00% <0.00%> (ø)

pkg/ui/tab.go
0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Document @flow pragmas better

The docs about the @flow pragma are kind of hard to find without reading lots of prose. It's mentioned in http://flowtype.org/docs/five-simple-examples.html, http://flowtype.org/docs/new-project.html and http://flowtype.org/docs/existing.html, but I think it probably deserves its own section.
The last page also mentions @flow weak which I'm not sure still works as described.
Nothing mentions @noflow yet. This mode should be thought of as something like @flow suppress, which parses the file as a Flow file (types are parsed) but suppresses all of the errors. This differs from the pragma missing entirely, which causes Flow to ignore the file. The reason it's @noflow instead of @flow suppress is because @noflow is not a prefix of @flow, so naive tooling can look for @flow without having to negative-match suppress.

@mroch does Flow truly ignore files without a pragma?  I encountered a situation where file A with a /* @flow */ pragma was requiring file B with no pragma, yet flow was reporting parse errors in file B (the default value inside object destructuring issue).

Not even adding /* @noflow */ in the file that Flow fails to parse prevents the errors.

so flow actually parses all files, but suppresses parse errors on files that are neither @flow/@noflow nor required by such a file. i'm researching the history behind that; we used to parse files to extract the pragma but don't do that anymore, so I'm not sure if it was an implementation artifact or if there was a good reason.
I think the workarounds would be to either stop using destructuring and default values for now, or add a yourfile.js.flow file that exports any so that flow ignores the implementation (you may have to add the .js file to [ignore], not sure). not great, but hopefully we can fix the destructuring thing soon.

@mroch okay.  I think it would be helpful though if there was a pragma to turn off parsing of any kind (besides the pragma itself) to work around other potential parse failures (especially considering the way Babel is going, I'm assuming the JS syntaxes in the wild are only going to grow more diverse from here on out).

actually I'm nitpicking...creating a .flow file is hardly worse than a pragma

here's the message from the commit that added this behavior (I think this is from before we started syncing individual commits to github):

Flow's policy has been to suppress parse errors in
non-@flow files. This leads to confusion when such
a file is imported into a flow file: the user gets
only a module-not-found error, which has notoriously
many possible causes. With this diff we track imports
of unparsed files, and report parse errors for files
that have been imported, @flow or not.

So I think the only reason is to avoid confusing "module-not-found" errors, which we can handle better now. No pragma should mean flow doesn't even look at it, other than knowing the file exists so that it can tell that require('foo'): any.

filed #1392 to stop parsing non-@flow files. then flow should behave like I described in the OP, which will be nice.


[REQ]

VIP acces to a specefic weapon
So VIP FLAG can acces example only SCAR20 but other people cant and admins can access all weapons
this will be veryyy coool beacuse i want to block scar20 and g3sg1, but admins can have acces to this weapon but vips not

Not planned, see #11


tweak the contributing info in docs a little

move dev badges from the front page to CONTRIBUTING.md; there is no need for these on the front page

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (762429b) 55.40% compared to head (119348f) 55.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   55.40%   55.40%
=======================================
  Files           7        7
  Lines         305      305
=======================================
  Hits          169      169
  Misses        136      136

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow a type annotation for indicating the type of a destructured rest assignment

Suggestion
I offer allow to assign type to rest in destructuring assignment.

🔍 Search Terms

destructuring assignment, desctructuring, rest
✅ Viability Checklist

My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test;

For better understanding please check Use Cases
📃 Motivating Example
I wanted to assign new calculated value to destructured assigment to field that moved out to new variable by destructuring, but I can't do it because new type exists without field and I'm not able to assign new type to desctructuring assignment.
Provided example in Use Cases

💻 Use Cases

Current behavior in TypeScript
export interface INumbersE {
    c: number;
    d: number;
}

export interface INumbers {
    a?: number;
    b?: number;
    c?: number;
    d?: number;
    e?: INumbersE;
}

export interface ICalculatedNumbers {
    a?: number;
    b?: number;
    c?: number;
    d?: number;
    e?: number;
}

const calcTheNumber = (numbers: ICalculatedNumbers) => {
    // another logic goes there
    console.log(numbers);
}

const test: INumbers = {
    a: 1,
    b: 2,
    c: 3,
    d: 4,
    e: {
        c: 2,
        d: 3
    }
};

const { e, ...rest }: { e: number, ...rest: ICalculatedNumbers } = test; // Property 'rest' is missing in type 'INumbers' but required in type '{ e: number; rest: ICalculatedNumbers; }'

if (e && e.c + e.d === 5) { // Property 'd' does not exist on type 'number' || Property 'c' does not exist on type 'number'
    rest.e = 5; // Property 'e' does not exist on type '{ a: number; b: number; c: number; d: number; }'
}

calcTheNumber(rest); // Type '{ rest: ICalculatedNumbers; }' has no properties in common with type 'ICalculatedNumbers'.

Running in pure JS right as expected behavior and getting expected object with e: 5
const test = {
    a: 1,
    b: 2,
    c: 3,
    d: 4,
    e: {
        c: 2,
        d: 3
    }
};

const calcTheNumber = (numbers) => {
    console.log(numbers); // { a: 1, b: 2, c: 3, d: 4, e: 5 }
}

const { e, ...rest } = test;

if (e && e.c + e.d === 5) {
    rest.e = 5;
}

calcTheNumber(rest);

If cover errors with //@ts-ignore, it'll run as expected, but I'm not ok with that.

I ran across this issue while trying to port a method in the ECMAScript Temporal polyfill from JS to TS. Porting would be easier if I could have casted the rest object in a destructured assignment.
The use case was a function that used destructuring assignment to shallow-copy an object while removing a few fields from it. Some of those fields were (depending on runtime values) sometimes added back to the copied object. Ideally, I could have cast the rest object to the same type as the original object, so that I could avoid the errors shown in comments below and without casting the object every time I wanted to add a property to it.
Here's the code:
  mergeFields(
    fields: Partial<Record<DatePropertyName, unknown>>,
    additionalFields: Partial<Record<DatePropertyName, unknown>>
  ): Record<string, unknown> {
    const fieldsCopy = { ...fields };
    const additionalFieldsCopy = { ...additionalFields };
    // era and eraYear are intentionally unused
    // eslint-disable-next-line @typescript-eslint/no-unused-vars
    const { month, monthCode, year, era, eraYear, ...original } = fieldsCopy;
    const {
      month: newMonth,
      monthCode: newMonthCode,
      year: newYear,
      era: newEra,
      eraYear: newEraYear
    } = additionalFieldsCopy;
    if (newMonth === undefined && newMonthCode === undefined) {
      original.month = month; // Property 'month' does not exist on type '{ day?: unknown; }' ts(2339)
      original.monthCode = monthCode; // Property 'monthCode' does not exist on type '{ day?: unknown; }' ts(2339)
    }
    if (newYear === undefined && newEra === undefined && newEraYear === undefined) {
      // Only `year` is needed. We don't set era and eraYear because it's
      // possible to create a conflict for eras that start or end mid-year. See
      // https://github.com/tc39/proposal-temporal/issues/1784.
      original.year = year; // Property 'year' does not exist on type '{ day?: unknown; }' ts(2339)
    }
    return { ...original, ...additionalFieldsCopy };
  }


Extensiblity: Table doesn't change color when disabled

The table component doesn't change color when disabled.

This is fixed.


Please add to "Community Guidelines" for your software

For the JOSS review, please clarify this guideline:
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
https://github.com/openjournals/joss-reviews/issues/4942

I agree, these would be really useful for code users and for those who want to contribute.

I see the added short guidelines in the docs.


Shell  Model & Seed

The seed file isn't finished, needs to be pulled into users seed file

resolved


Make ACCESS-OM2 availible for Prerelease Environments

Prereleases will be supported on access-nri/build-cd. We want this functionality for ACCESS-OM2, too.
References https://github.com/ACCESS-NRI/build-cd/issues/32
Closes #33 as regular deployments are no longer deployed on git tag, but on merge after a successful prerelease deployment.

Something to note: Should we tag prereleases? Upon deletion of the PR branch, these *-pre* tags will still be accessible.
We should still autotag the merges to main.

Note: No, no we shouldn't


Removed some unused files and refactored some functions

Removed thirdpartylogin controller and model.
Removed migrationversion model. We have a debug_ model, so moved the single function there.
Moved count_all_qso and calls_without_station_id from logbook_model to debug_model.
The reason for moving function from logbook_model is that it is too big, so better place them in debug_model in this case. The function are only used there.

Thanks :)


Isn't the new model is initiated for each iteration?

https://github.com/yzhao062/pyod/blob/db7d3fbc5d2c2b099052230164797a9df3eba19e/notebooks/benchmark.py#L144

Yes. Each iteration itself is also independent--we report the average of iterations.
Also note this code is quite old...may be buggy now.


haproxy-ingress: add IngressClass for public and private HAProxy controllers

Add IngressClass resources for each of the HAProxy controller instances.  These are preferred in the v1 ingress API over the kubernetes.io/ingress.class annotation.

bors r+


jsx-no-leaked-render should only complain if there is a certian leaked render

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique

Description Overview
This was previously discussed in #3719
The goal of the rule is to avoid leaked render specially when the left side of && is 0, NaN, or "" because react-dom will render a 0 in the first case (while some would expect to render nothing) and react-native will crach in the three. Currently, the rule complain for potential leaked render while most of the cases there is no any leaked render. for example, when the left side is boolean, undefined, null, ojbect, or array.
The following code is an eslint error, while it doesn't have any side effects.
let data: Item[] | undefined = getData();

return (
  <div>
     {data && <List items={data} />}
  </div>
)

Proposal
It should only complain if the left side is one of the potential leaked render number (0 or NaN) or string (""). Others types should be valid. AFAIK, this is possible with the @typescript-eslint/parser
eslint-plugin-react version
7.33.2
eslint version
8.56.0
node version
22

Sounds like a great enhancement. It should be behind an option (perhaps the option disables this behavior so that the default is friendlier?). It should only kick in when the AST has type info and it knows for sure it’s not a number or string or bigint.

Does the plugin use TS type parsing at the moment?

If the TS parser is used, and attaches type info to the AST, we can (and often do) use it.

I think this issue means making the rule recognize all 3 variables below are essentially boolean values.

I guess similar to how VSCode tells the type of a variable when hovered?
I would love to help improving this rule, but pretty new to this repository. Do we have any examples of similar TS type parsing?

@yusufkinatas we don't typically have type-specific stuff, so off the top of my head i'm not sure where to look. however, you could always do the brute force approach and add some test cases and some console.logs, and see what type info is available on the AST nodes :-)

The detection accuracy of eslint-plugin-react-x/src/rules/no-leaked-conditional-rendering.ts is qualitatively improved by introducing type information.

@Rel1cx it sounds like something worth upstreaming (i'm not sure why that project even exists tbh, if there's rules or enhancements in it that this project should have, please PR them in :-) )


Review notes

http://ljharb.github.io/proposal-string-pad-left-right/#String.prototype.padLeft
http://ljharb.github.io/proposal-string-pad-left-right/#String.prototype.padRight
Step 2 can be removed, abrupt completions are also handled in step 4.
Steps 10-11 (ToLength(maxLength)) should be placed before steps 6-8 (ToString(fillString)) to ensure the arguments are processed in the usual left to right order.
https://github.com/ljharb/proposal-string-pad-left-right/blob/master/polyfill.js
Nit: ToLength function does not handle NaN correctly.

Thanks for the thorough review!

Step 2 can be removed, abrupt completions are also handled in step 4.

This was added due to @rwaldron filing #1. However, I think I am convinced that there isn't an observable difference here, and the step can be removed. @rwaldron, can you weigh in?

Steps 10-11 (ToLength(maxLength)) should be placed before steps 6-8 (ToString(fillString)) to ensure the arguments are processed in the usual left to right order.

Good call! I'll rearrange the steps to follow left-to-right order, that makes perfect sense.

Nit: ToLength function does not handle NaN correctly.

Oops, fixed, thanks :-)

Reopening pending a decision on removing step 2.

@bterlson: what do you think about the ReturnIfAbrupt in step 2? Is it necessary?

It's unnecessary in the sense that it's nonobservable as ToObject passes through any abrupt completions.

OK - I'll remove it then and revert #1.


[BUG] - Not all EXIF values are supported

Lib Version 4.3.0

Describe the bug
EXIF values not only define rotation but also mirroring, see EXIF values 2, 4, 5, 7:

But sadly that is not implemented in this library.
To Reproduce
Steps to reproduce the behavior:
Try to crop an image that has an EXIF value of 2, 4, 5 or 7 and see that the image is in fact not correctly mirrored:
This is an image with EXIF value of 2

Expected behavior
Make use of these enums:
https://developer.android.com/reference/androidx/exifinterface/media/ExifInterface#ORIENTATION_FLIP_HORIZONTAL
https://developer.android.com/reference/androidx/exifinterface/media/ExifInterface#ORIENTATION_FLIP_VERTICAL
https://developer.android.com/reference/androidx/exifinterface/media/ExifInterface#ORIENTATION_TRANSPOSE
https://developer.android.com/reference/androidx/exifinterface/media/ExifInterface#ORIENTATION_TRANSVERSE
Which define what tranformations you need to apply to the image to get the correct orientation.
Media
You can test this out yourself by using the images provided in this repo:
https://github.com/recurser/exif-orientation-examples
Proposed solution
From a quick overview it seems that you should be able to pretty easily update the rotate function by exif value to also flip the image
https://github.com/CanHub/Android-Image-Cropper/blob/2f867e993670bb75597d6633284ca616fe045b12/cropper/src/main/java/com/canhub/cropper/BitmapUtils.kt#L90-L107

@Mouwrice this is great, please open a PR and let's fix this =)

@Mouwrice this is great, please open a PR and let's fix this =)

On it 💪


Disambiguate what copy=True means for dask

The current documentation for the copy parameter of asarray states:
https://data-apis.org/array-api/latest/API_specification/generated/array_api.asarray.html#asarray

copy (Optional[bool]) – boolean indicating whether or not to copy the input. If True, the function must always copy. If False, the function must never copy for input which supports the buffer protocol and must raise a ValueError in case a copy would be necessary. If None, the function must reuse existing memory buffer if possible and copy otherwise. Default: None.

The meaning of copy=True is ambiguous for dask.
There are two possible interpretations:

updating the output array will never alter the input array; OR
the output array will never share memory with the input array; in other words dereferencing the input array can release its memory even if you still hold a reference to the output array.

In dask, updating a collection actually creates brand new graph nodes under the hood and repoints the collection to those nodes, so the original is never modified. However, the original chunks, generated e.g. by from_array, are still held inside the graph.
I strongly prefer the first definition, as IMHO decisions around memory management should be considered low level and delegated to the individual libraries.

I strongly prefer the first definition, as IMHO decisions around memory management should be considered low level and delegated to the individual libraries.

Yes agreed. In all such cases we've cared about the semantics, not about physical memory layout. A library should always be able to reuse memory or other such optimizations if it guarantees that that does not affect the semantics.
I'm pretty that using definition (1) is not controversial, and I remember clarifying this in some other place in the docs already - just can't remember where.

If anything, it'd be quite helpful to clarify what copy=None means for dask, https://github.com/data-apis/array-api-compat/issues/209

If anything, it'd be quite helpful to clarify what copy=None means for dask, data-apis/array-api-compat#209

We could change "if possible" to "if possible and sensible"...

I'm pretty that using definition (1) is not controversial, and I remember clarifying this in some other place in the docs already - just can't remember where.

https://github.com/data-apis/array-api/issues/788#issuecomment-2080416220

Thanks for the link @asmeurer!
It seems like this issue overlaps a lot with that one. The "logical semantics" point stands I think - the difference is that for JAX copies sometimes do matter, while for Dask they never matter according to @crusaderky. So I think for Dask it's fine to not copy memory - would you agree?
The "never" here is of course the point of interest - it is probably possible to write some code where that never isn't true, especially if one starts mixing Dask and NumPy, which is fairly common.

xref https://github.com/data-apis/array-api/issues/867


Add support for parking_lot primitives

Given the wide usage of the parking_lot primitive in the community, it would be nice for this crate to support it, as an optional feature.
This would involve implementing StableAddress on MutexGuard. Theoretically, there could be a parking_lot feature to enable support to this.
I would be willing to implement this, if you support this.

I am now aware that parking_lot provides MappedMutexGuard for this purpose. This makes this issue unnecessary.


fix: Revise cookiecutter json in starters

Motivation and Context
Removing the default values of the tools and example_pipeline variables from cookiecutter.json in the four starters is currently not feasible. Variables utilised in Cookiecutter must be declared in cookiecutter.json, even if they are consistently set during the cookiecutter() function call (which overrides values from the file). Omitting these declarations results in Cookiecutter raising an UndefinedVariableInTemplate error.
However, for clarity, it might be beneficial to leave the values blank or indicate their status with a note, such as:
tools: "protected internal variable - do not modify"
example_pipeline: "protected internal variable - do not modify"

This approach informs users of the special nature of these variables, highlighting that they are internally managed and should not be altered.
Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Assigned myself to the PR
[ ] Added tests to cover my changes

Summarising our discussion offline for posterity:
In Kedro's implementation, cookiecutter (and hence pyproject.toml) will always receive values that overwrite the defaults specified in cookiecutter.json. However, this knowledge is not available to cookiecutter, and so not supplying a default value results in an error.
I disagree that indicating this is important for the understandability of the code, I don't think empty strings are informative but perhaps something like:
tools: "default value required by cookiecutter - overwritten by Kedro implementation"
example_pipeline: "default value required by cookiecutter - overwritten by Kedro implementation"

Which informs why this default is there and it's lack of effect on the rest of the project generation process.

Just so I understand are you saying that even if we are getting "kedro_version": "{{ cookiecutter.kedro_version }}" from the codebase it doesn't matter as we just replace it?
If thats the case I have no issue replacing it with some descriptive placeholder for future contributors.

Thank you, @AhdraMeraliQB, for the comprehensive description of the issue and the potential solutions.
I agree with both @AhdraMeraliQB and @SajidAlamQB and have modified the variable names in accordance with @AhdraMeraliQB 's proposal. Let's wait until next week; we might receive additional opinions by then.

I personally find the comment a bit messy and would prefer to just go for the "kedro_version": "{{ cookiecutter.kedro_version }}" style for all these fields. IMO we should document the behaviour for ourselves rather than put explanations in user facing files.
It would be good to hear what the rest of the team thinks @ankatiyar @noklam @lrcouto
In any case, whatever decision is made this should be applied across all starters for consistency.

I tend to agree @merelcht on this one. It's not something that user can change. It is still a good note that we should keep, maybe somewhere in the codebase or the develop docs if applicable.


polyspermy

Add new term:
polyspermy (a child of abnormal egg activation see issue #3134)
DEF: increased incidence of fertilized oocytes fused with two or more sperm due to reduced ability or inability to prevent fertilization by multiple sperm during the egg activation process; normally only a single sperm fuses with the egg plasma membrane and injects its nucleus and other organelles into the egg cytoplasm; if more than one sperm fuses, multipolar or extra mitotic spindles are formed, resulting in faulty segregation of chromosomes during cell division; nondiploid cells are produced, and development usually stops.
EXACT SYN: polyspermic fertilization
RELATED SYN: failure of polyspermy block
RELATED SYN: failure of polyspermy prevention
SOURCE: ISBN-10:0-8153-4072-9, PMID:16478602

Added new term:
polyspermy MP:0031014


fix(datasets): default to DuckDB in in-memory mode

Description
https://github.com/kedro-org/kedro-plugins/pull/893#discussion_r1804632435
Development notes
TODO: Add unit test (make sure connection caching works correctly?)
Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added a description of this change in the relevant RELEASE.md file
[ ] Added tests to cover my changes
[ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

Thanks all for reviewing! I just updated the tests/release notes, so I'm going to go ahead and merge this once builds pass.