Error building Locomote with npm install

Tried to run npm install after cloning and got the below errors.
(Windows 8)

<EMAIL_ADDRESS>postinstall D:\dropbox\src\locomote-video-player-master
gulp --color

[18:18:17] Using gulpfile D:\dropbox\src\locomote-video-player-master\gulpfile.js
[18:18:17] Starting 'submodule'...
[18:18:17] exec: git submodule init && git submodule update
[18:18:17] Starting 'minify'...
[18:18:17] Finished 'minify' after 134 ms
[18:18:17] 'submodule' errored after 257 ms
[18:18:17] Error: Command failed: fatal: Not a git repository (or any of the parent directories): .git
at ChildProcess.exithandler (child_process.js:648:15)
at ChildProcess.emit (events.js:98:17)
at maybeClose (child_process.js:756:16)
at Socket.<anonymous> (child_process.js:969:11)
at Socket.emit (events.js:95:17)
at Pipe.close (net.js:465:12)

npm ERR<EMAIL_ADDRESS>postinstall: gulp --color
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is most likely a problem with the locomote-video-player package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp --color
npm ERR! You can get their info via:
npm ERR!     npm owner ls locomote-video-player
npm ERR! There is likely additional logging output above.
npm ERR! System Windows_NT 6.2.9200
npm ERR! command "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js"
"install"
npm ERR! cwd D:\dropbox\src\locomote-video-player-master
npm ERR! node -v v0.10.30
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     D:\dropbox\src\locomote-video-player-master\npm-debug.log
npm ERR! not ok code 0

Same problem here. Windows 8.1.


Points on a line as the result

Hi,
thank you for this wonderful work. I'm testing this code on my own data. Despite the target and source input (meshes) have already a roughly good overlay, I got many points on a line as the registered result. I upload these two files in this drive. Thank you for your clarification in advance! https://drive.google.com/drive/folders/1Mt26annG3yEZFbAU-xGgik6O0UDAxdC6?usp=sharing

The input format is somehow restricted to .obj, though the output is in .ply. If something weird happens while using this ICP method, try to convert the inputs to obj files.

Hi, this problem is because the code does not support binary-encoded .ply format, but non-binary-encoded .ply format is supported.

Hi, this problem is because the code does not support binary-encoded .ply format, but non-binary-encoded .ply format is supported.

Ah, I see. Thank you for the clarification.


content(docs): Add section on dokku for deploiement on polytech servers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Axel-Duval Could you review ? Tell me if you see something that would be missing 😉


[Draft] Publish

@mdedetrich I'm one step further:

[error] Unable to find credentials for [Sonatype Nexus Repository Manager @ repository.apache.org].

@nvollmar Can you temporarily set apacheSonatypeCredentialsLogLevel to Level.Warn as documented at https://github.com/mdedetrich/sbt-apache-sonatype#notable-sbt-plugin-keys to verify that credentials are missing?

Also need to change sbt -jvm-opts .jvmopts-ghactions +publish to sbt +publish

Okay we got something
Both NEXUS_USER and NEXUS_PW environment variables for Apache Maven Nexus repo are empty strings

Ticket created https://issues.apache.org/jira/browse/INFRA-24284

Thanks

Okay we got something
Both NEXUS_USER and NEXUS_PW environment variables for Apache Maven Nexus repo are empty strings

Have to make an INFRA ticket

We've hit this a few times. Could you add a list of all this repo and a few others that we have made progress on - where we will soon also be publishing?

incubator-pekko-connectors
incubator-pekko-connectors-kafka
incubator-pekko-grpc
incubator-pekko-management
incubator-pekko-persistence-cassandra
incubator-pekko-persistence-dynamodb
incubator-pekko-persistence-jdbc

Okay we got something
Both NEXUS_USER and NEXUS_PW environment variables for Apache Maven Nexus repo are empty strings

Have to make an INFRA ticket

We've hit this a few times. Could you add a list of all this repo and a few others that we have made progress on - where we will soon also be publishing?

incubator-pekko-connectors
incubator-pekko-connectors-kafka
incubator-pekko-grpc
incubator-pekko-management
incubator-pekko-persistence-cassandra
incubator-pekko-persistence-dynamodb
incubator-pekko-persistence-jdbc

Done

@nvollmar So according to the INFRA ticket the credentials should be enabled for this repo but I am still getting issues but it may be due to some weird caching going on.
Can you just rebase this PR against master to a force a complete re-run just to confirm?

done

Still failing with same problem, updated INFRA ticket.

So from https://issues.apache.org/jira/browse/INFRA-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696757#comment-17696757

They are not missing, they are just not available to PRs that run from forks, for security reasons which should be obvious , credentials are not exposed.

So this explains it, @nvollmar Can you clean up this PR (i.e. re-enable it to to be only trigger after merge to main etc etc), we actually have to merge the PR into main for secrets to be available


feat: ERNEX-000 | Update dashboard image logo render

Update dashboard logo image render;
Remove unused css file;
Update snapshots;
Fix failing unit tests;

We don't need to set the height here, because tailwind rules are overriding the height value (to "auto") so it keeps the original ratio.


Document importing types from APIs

Add to the README documentation on how we import types from API documentation.
(Also updated imported types to latest versions.)

@AledWEvans documenting how we handle importing types from APIs - as discussed earlier!


chore: Setup shared postman

Describe the chore that is required
A shared repository of the project's RPC testing tools would be an excellent thing to have. We seem to have all developed these in parallel and could have increased efficiency if the team could point to a central shared collection.
Describe the solution you'd like to see
Postman
Additional information
No response

New repo set up here: https://github.com/versatus/versatus_postman
Please let me know if you need anything else before we close this ticket


Start of Autotoolification.

This just gets the basics working on GNU/Linux.  It does not try hard
to figure out things.
I consider this to be a work-in-progress for now.


[IOTDB-1569] Timed close TsFileProcessor

If we open a TsFileProcessor and then never write to it, this TsFileProcessor will become a zombie because nothing can trigger a flush or close operation. So, i am implementing timed flush memtable and timed close TsFileProcessor. Timed flush memtable is used to flush inactive memtables periodically according to their created time. Timed close TsFileProcessor is used to close inactive TsFileProcessors periodically according to how long they don't process write operations.
I add 9 params to control above two functions, and these 9 params all can be hot loaded by 'load configuration' command.

enable_timed_flush_seq_memtable: whether to timed flush sequence tsfiles' memtables.
seq_memtable_flush_interval_in_ms: when a sequence memTable's created time is older than current time minus this, the memtable is flushed to disk.
seq_memtable_flush_check_interval_in_ms: the interval to check whether the sequence memtables need flushing.
enable_timed_flush_unseq_memtable: whether to timed flush unsequence tsfiles' memtables.
unseq_memtable_flush_interval_in_ms: when an unsequence memTable's created time is older than current time minus this, the memtable is flushed to disk.
unseq_memtable_flush_check_interval_in_ms: the interval to check whether the unsequence memtables need flushing.
enable_timed_close_tsfile: whether to timed close TsfileProcessors.
close_tsfile_interval_after_flushing_in_ms: when TsfileProcessor's last working memtable flush time is older than current time minus this and its working memtable is null, this TsfileProcessor will be closed.
close_tsfile_check_interval_in_ms: the interval to check whether the TsfileProcessors need closing.

Coverage increased (+0.02%) to 67.268% when pulling 9951c744e060fa993bbc918183a41ef58ba0547b on HeimingZ:IOTDB-1569(timed_close_tsfileprocessor) into 125f8cf649a16a62c1216b9e809c69fa5fddf7c9 on apache:master.


js_include directive deprecated in njs 0.7.1

Since njs 0.7.1 update, code part of:
  # Include the NJS module
  js_include /etc/nginx/njs.d/nginx_stream.js;

will no longer work. Could the code be updated to use js_import instead?

Source: https://nginx.org/en/docs/njs/changes.html#njs0.7.1
Source 2: https://nginx.org/en/docs/http/ngx_http_js_module.html#js_import

I'm glad I saw this. I am on version 0.7.1 of njs on ubuntu.
Replacing js_import for js_include solved my nginx config test failure.
I now have one with export statement is required in nginx_stream.js:55 which currently reads     js_preread dns_preread_dns_request;
I'm currently trying to use nginx-dns-routing.conf for testing and trying to get over these issues.
Any ideas what I need to do?

From this explanation regarding export statement   it appears to my untrained eyes that export statement is needed in njs.d/nginx_stream.js @mariamatthews  @TuxInvader
As a test I did add the following line below import dns from './dns/dns.js';
export default {dns_get_qname, dns_get_response};
just to test if nginx config stopped complaining and it did.
However I don't know if these are the only ones or actually the ones functions that need exporting back.
Do I need do do this/something else to get it working?
p.s. I'm not a developer, only a user trying to get an nginx gateway working for DoT.

Hi @mariamatthews
Thanks for raising this.... I think this deprecation has caught a few NJS projects out. 18 months just isn't long enough for some people ;-)
I'll update the code and examples to start using import rather than include. The include file was just a wrapper to import functions from libraries anyway.  The fix is simple enough......
Replace:
js_include /etc/nginx/njs.d/nginx_stream.js;

with:
js_import /etc/nginx/njs.d/dns/dns.js;

Then rename the functions from  dns_ to dns. Eg: use dns.filter_doh_request instead of dns_filter_doh_request
Cheers

Right, got it ! . To clarify though, this bit @TuxInvader :
Then rename the functions from dns_ to dns. Eg: use dns.filter_doh_request instead of dns_filter_doh_request
Is that in /etc/nginx/njs.d/nginx_stream.js ?
Pretty sure is the only place I can see them but I don't want to make assumptions.

Hi @cookiemonsteruk
Make the changes inside your nginx.conf.
Instead of importing njs.d/nginx_stream.js you want to import njs.d/dns/dns.js and then where you use the dns_get_qname change it to dns.get_qname and repeat for any other functions you use. So you don't need nginx_stream.js in your life anymore :-)

Thanks again. I've got an error in nginx config test after previous comment but before your last one. I'll open a new issue if it persists after this and leave this one less cluttered.

Hi @mariamatthews - All the examples should be updated now to use js_import.
Thanks

Thank you @TuxInvader & @cookiemonsteruk  💕 You guys rock :)


[SPARK-14360][SQL] QueryExecution.debug.codegen() to dump codegen

What changes were proposed in this pull request?
We recently added the ability to dump the generated code for a given query. However, the method is only available through an implicit after an import. It'd slightly simplify things if it can be called directly in queryExecution.
How was this patch tested?
Manually tested in spark-shell.

Test build #54822 has started for PR 12144 at commit 35d8673.

Test build #54822 has finished for PR 12144 at commit 35d8673.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54822/
Test PASSed.

LGTM

Merging to master. Thanks!


resolution mistake

Getting this error: Error: Luma resolutions were not equal, 960x544 != 960x540 with grav1synth diff -f 'resize:alg=hermite,width=960,height=540' with the source being 1920x1080 and the encode being 960x540.
For some reason it thinks the scaled source is 960x544 even though that's not what I provided in the filters params.
Seems to be an issue with this specific resolution because running diff with the same source encoded in 720p instead worked flawlessly with the source was downscaled with the expected resolution.

BTW I just remembered about this issue, but I can now give some explanation to this: it's a SVT-AV1 issue of adding a few pixels at some resolutions probably because the res in question isn't mod 2 and it's required for some internal tools or something, meaning that even though players and most software will playback and report 540p (in this case), the bitstream is actually 544p.
An easy workaround is to simply resize the source to 544p instead.


HADOOP-18807. Close child file systems in ViewFileSystem when cache is disabled.

Description of PR
Cherry pick from trunk.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
17m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m 57s

branch-3.3 passed

+1 :green_heart:
compile
19m 29s

branch-3.3 passed

+1 :green_heart:
checkstyle
2m 54s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 41s

branch-3.3 passed

+1 :green_heart:
javadoc
2m 56s

branch-3.3 passed

+1 :green_heart:
spotbugs
6m 15s

branch-3.3 passed

+1 :green_heart:
shadedclient
42m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 36s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 30s

the patch passed

+1 :green_heart:
compile
19m  7s

the patch passed

+1 :green_heart:
javac
19m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 47s

the patch passed

+1 :green_heart:
mvnsite
3m 47s

the patch passed

+1 :green_heart:
javadoc
2m 51s

the patch passed

+1 :green_heart:
spotbugs
8m 17s

the patch passed

+1 :green_heart:
shadedclient
42m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 19s

hadoop-common in the patch passed.

-1 :x:
unit
204m 10s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 16s

The patch does not generate ASF License warnings.

438m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestLeaseRecoveryStriped

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5865

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 57c7aa3b85ef 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 7c304bdda9bef094f71d4c9e90379a4a9b279251

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/1/testReport/

Max. process+thread count
3468 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m 23s

branch-3.3 passed

+1 :green_heart:
compile
19m 16s

branch-3.3 passed

+1 :green_heart:
checkstyle
2m 54s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 41s

branch-3.3 passed

+1 :green_heart:
javadoc
2m 56s

branch-3.3 passed

+1 :green_heart:
spotbugs
6m 18s

branch-3.3 passed

+1 :green_heart:
shadedclient
40m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 34s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 25s

the patch passed

+1 :green_heart:
compile
18m 36s

the patch passed

+1 :green_heart:
javac
18m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 49s

the patch passed

+1 :green_heart:
mvnsite
3m 41s

the patch passed

+1 :green_heart:
javadoc
2m 47s

the patch passed

+1 :green_heart:
spotbugs
6m 35s

the patch passed

+1 :green_heart:
shadedclient
40m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 27s

hadoop-common in the patch passed.

-1 :x:
unit
204m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 23s

The patch does not generate ASF License warnings.

430m 39s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5865

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux be3282ca3832 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 7c304bdda9bef094f71d4c9e90379a4a9b279251

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/2/testReport/

Max. process+thread count
3348 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5865/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


[SPARK-7795] [Core] Speed up task scheduling in standalone mode by reusing serializer

My experiments with scheduling very short tasks in standalone cluster mode indicated that a significant amount of time was being spent in scheduling the tasks (>500ms for 256 tasks).  I found that most of the time was being spent in creating a new instance of serializer for each task.  Changing this to just one serializer brought down the scheduling time to 8ms.

@coolfrood have a look at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark -- you missed a step or two. It's not 100% clear you can reuse the serializer but it is a good idea to float.

Can one of the admins verify this patch?

Argh. Sorry. I'll create a JIRA for this and update the PR.

Serializer instances aren't thread-safe, but it looks like this single-threaded use should be fine.  I implemented some similar optimizations in #5606 and am in the process of fixing a rare corner-case related to serializer re-use with uncommon Kryo configurations (#6293).  Based on discussion in those patches, this change looks good to me.
We might actually be able to go a bit further and lift the serializer instance into a field of CoarseGrainedSchedulerBackend itself.  That would be a bit riskier in terms of code review burden, since we'd have to double-check that CoarseGrainedSchedulerBackend is only ever used from a single thread (I think that this is actually the case, but would be good to double-check).

Jenkins, this is ok to test.

Merged build triggered.

Merged build started.

Test build #33259 has started for   PR 6323 at commit fe530cd.

@JoshRosen: it looks like launchTasks() is only called from makeOffers(), which in turn is only called from the Actor's receive, so it should be safe to move the serializer into a member field.  Also, both launchTasks() and makeOffers() can be made private.  What do you think?

Yep, looks like both launchTasks() and makeOffers() can be private.  In general, I prefer to minimize the visibility of fields / methods as much as possible, so let's make these private.
My PR made a similar change to CoarseGrainedExecutorBackend.  Over there, I added a comment to explain that the shared serializer code would need to be revisited if we ever switched to a parallel / non-thread-safe RPC endpoint for the actor: https://github.com/apache/spark/pull/5606/files#diff-79391110e9f26657e415aa169a004998R51.  It would be good to make a similar comment here so that we don't forget to update this if DriverEndpoint is ever parallelized.

Merged build triggered.

Merged build started.

Test build #33263 has started for   PR 6323 at commit 0b8ca93.

Test build #33263 has finished for   PR 6323 at commit 0b8ca93.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33263/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33266 has started for   PR 6323 at commit bd4a5dd.

Test build #33259 has finished for   PR 6323 at commit fe530cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33259/
Test PASSed.

Test build #33266 has finished for   PR 6323 at commit bd4a5dd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33266/
Test PASSed.

This looks good to me.  I'm going to loop in @zsxwing or @rxin for another pair of eyes / final sanity-check.

LGTM

Actually, one minor comment: ser currently has wider visibility than is strictly necessary: it's only used inside of the DriverEndpoint inner class, so it should be a field of that class rather than a field of CoarseGrainedSchedulerBackend.

Merged build triggered.

Merged build started.

Test build #33348 has started for   PR 6323 at commit 12d8c9e.

Test build #33348 has finished for   PR 6323 at commit 12d8c9e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33348/
Test PASSed.

LGTM, so I'm going to merge this to master.  Although I think this is probably safe for 1.4, I don't want to risk conflicting with any attempts to cut another RC tonight, so I'm not going to pick it there for now.  Thanks!


removed unused using

Description
removed unused using
References

#0000

Codecov Report

Merging #48 (283d2cd) into main (7d937a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   79.56%   79.56%
=======================================
  Files          47       47
  Lines        1008     1008
  Branches       81       81
=======================================
  Hits          802      802
  Misses        169      169
  Partials       37       37

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Erase tool: Hotkey (Del) can't delete arrows and plus sign

Steps to Reproduce

Launch Ketcher
Draw arrow and plus sign
Hover mouse over arrow or plus and press hotkey (Del)

Actual behavior
Arrow and plus sign are not deleted
Expected behavior
Arrow and plus sign are deleted
Screenshots
https://user-images.githubusercontent.com/62464241/209928365-d1ac3f99-fd17-498a-8306-ff03d8ec5d12.mp4
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 108.0.5359.125 (Official Build) (64-bit)

Ketcher version
Version 2.7.0-rc.8
Additional context
Add any other context about the problem here.

Issue is reproduced in v2.7.0-rc.9, moving to v2.9.0-rc.1

The bug is reproducing. Arrows and plus sign are not removed by hotkey (DEL)
Note: Also, bonds are not deleted by hotkey. Only atoms are removed.
https://user-images.githubusercontent.com/62464241/216725439-4f90c574-6828-488a-939b-10feda933d1c.mp4

No it's not.
Latest master:
https://user-images.githubusercontent.com/24246336/216758648-c53a8415-2875-48f5-a20b-ad395922efaa.mov
Maybe it's not in the testing branch yet (whichever that is)?

I tested this in Ketcher 2.8.0-rc.2 on rc test platform.


feature/tool-tzolk'in

Tzolkʼin has been described as "sacred calendar" so it is unclear if this word is barred in etic contexts. Until that is confirmed, I will use, generalize, and transliterate the term to tzolk'in in my subsequent point.
A tzolk'in can be a calendrical system that is bound to a user-defined process, other than the celestial bodies, or the work week.

Moved from #5 :

Unlike our most familiar calendrical systems, the Mayan tzolkʼin is not intended to track the periodic movement of celestial bodies, and is instead used to guide culturally-specific activity, such as maize cultivation and prosoponym generation.

This prompts additional support for user-created calendrical systems

Following from the "development rules" in the wiki, I think it would be fun to define a period duration for Github iterations based on what seems to work best for our cycle, and make a point to NOT let the Gregorian calendar dictate it.


Add syncAt to settings so its easier to reset. More info in instructions

we should probably close this one as i have merged mine @jacksonh

👍


URLs in imported XS project not resolved

Describe the bug
URLs in code written in XSC are relative to the repository and package they're in. However, routes in XSK are prefixed with /services/v4/xsk which needs to be added to all paths in the code.
Let's say I'm following this tutorial - https://help.sap.com/viewer/52715f71adba4aaeb480d946c742d1f6/2.0.03/en-US/6863e48a71aa48479ab4183892e7e4d8.html and on Step 6 I need to call an XSJS service. In XSC I'd provide the path starting from the root and going to the xsjs file. In XSK I'd have to prefix this with /services/v4/xsk/.

What version of the XSK are you using?
0.9.2

To Reproduce
Steps to reproduce the behavior:

Have a working project in XSC which has a JS file calling an XSJS service
Export the project
Import in XSK
Try to call the JS function and see that the xsjs service cannot be resolved

Expected behavior
Up for discussion. I can think of some options but none seem great:

Serve all content from the base path and not /services/v4/xsk/
In the migration assistant parse all files and try to find a path that needs to be prefixed with /services/v4/xsk/

@dpanayotov, another option would be to create a page in the documentation with known issues/limitations.
Also it might be possible to create a filter and forward requests containing *.xsjs, *.xsodata, etc. in the path, to the right endpoint.


Add phone number and email to contact form

Consider adding phone number on contact form, on the SERVICES section you mention "give us a call today..."; just a thought
Adding email would enable us to add the email attribute and launch the user's default mail client, could be useful for those using a company email

I'm good with taking that photo and just layering on that photo statically and re-uploading it. Whatever we need to do for the email feature, I'm totally down to do. I want that submit button to send an email to me, or<EMAIL_ADDRESS>


Breakpoints view should appear under debug's start view

In a project without a launch.json go to the debug view

Observe:
Debug view shows new start experience.

create a breakpoint

Observe:
Breakpoints view appears above the start view.

We should show the breakpoints view in its default location (at the bottom).

I can not reproduce this. I tried also with a fresh user data directory. @weinand let me know if you have better steps, or if you can repro with a new user data dir.
Assigning also to @sandy081 as he might know when the view might not repsect its order. Since I clearly define that the start view has lower order than breakpoints view here
Though @connor4312 was also seeing this

Also provide following info:
From the workspace where you are seeing this,

run the command Developer: Log Storage Database Contents
It will log global and workspace storage contents in your developer tools console
Provide the values for keys workbench.view.debug.state.hidden and workbench.view.debug.state from global and workspace storage respectively.

When running VS Code with a fresh user-data-dir the problem disappeared.
From there I could easily reproduce the issue:
If you have moved the breakpoints view once to the top, the new position becomes a user setting. From then on every new project will show this behavior that the start view is no longer the top view.
This behavior seems to be perfectly correct.
However the behavior runs a bit contrary to the purpose of the new "Debug start view": to simplify debugging...

@sandy081 can I somehow have a special order that the view is always at the top? And that the user can not set anything before it?

Seems we need a fixed position view which is not supported yet. But shall we wait until users see this issue? Looks like this happened bcoz of trying some DnD of views?

I would like that we tackle this. However imho there is no rush and we do not have to do it this milestone.

@sandy081 I see this from time to time, can we maybe look into it once you find time?

Sure

Could not get time in this milestone. Moving to May

@isidorn Updated the order of welcome view to be the first view. It means that unless user moves  this view or other view to before this view, this view will be shown always first.
This fixes what you asked for can I somehow have a special order that the view is always at the top?
I tried the steps provided by @weinand here to repro and with this fix, the start view is still shown first always.
Steps I used to repro:

Start with fresh user data directory
Open VS Code with a folder that has launch.json
Go to debug view and move Breakpoints view to the top
Now open folder that does not has launch.json
Go to debug view and make sure Welcome view is on the top
Open a file and keep a break point
Make sure the Welcome view is still on the top

And that the user can not set anything before it?

Not sure if you still want to have this - to have a sticky view on the top?

Thanks Sandy, however I am not sure if that will fix it. Since the breakpoints view had order 40, and the welcome hard order 10. And now you changed wlecome to be order 1. Both 10 and 1 are lower than 40. So unless there is a special meaning to order == 1 than I am not sure how this would fix it.
I am fine if the user expliclity moves it that it gets moved, however this seems to happen without user explicitly re-arrenging views.

Though I tried to reproduce with latest and could not
@weinand can you repro this with latest from out of source?

I am not sure how this would fix it.

Previously debug views are registered in following order

variables (10)
welcome (10) - This was placed second because it is having same order but registered after variables
watch (20)
call stack (30)
loaded scripts (35)
break points (40)

By default, with above registration welcome view is always shown after variables view. When user moved break points view to top of variables view it took precedence over all views. Hence welcome view is shown after breakpoints view when they are visible.
This can be fixed in two ways.

Register welcome view before registering variables view with same order. This might break anytime if somebody unknowingly moves the code.

Change the order of welcome view to be first by default. This is the fix I made and it is the right fix because you want that for welcome view. With this order of views are as follows:

welcome (1)
variables (10)
watch (20)
call stack (30)
loaded scripts (35)
break points (40)

Hence moving the break point to the position before variables view does not impact the position of the welcome view.

can you repro this with latest from out of source?

You can repro with the steps I posted here -https://github.com/microsoft/vscode/issues/90225#issuecomment-624200062 without my fix 40f83c0.
I reproed it before my fix and with fix I can no longer repro it.
Since you are fine changing the order of welcome view if user explicitly moves it, I am closing this.

Seems to work mostly fine for me now:
If I'm in an active debug session and I move the breakpoints view to the top, that setting becomes my default user setting.
But when opening a new empty project and go to the debug viewlet, the position of the breakpoints view is still below it (which is good).
The only way to force the original problem is to move the breakpoints view explicitly above the Welcome view. From then on every new project will show the breakpoints view above the Welcome view. But this does not happen by accident. It requires an explicit action by the user. So this behavior is fine and does not need some preventive measure on our side.


Add more diagrams from the presentations

Need to include more images or diagrams in an overview

@moxiegirl closing as this is pretty old

@amitshukla Agreed. New docs have more diagrams so pretty much covered.


P2P-Proxy: Back-End-Proxy

[x] Connect
[x] Send to address / topic
[x] Listen on own address
[x] Listen for topic

Implemented in https://github.com/ise-ethereum/insecure-ethereum-p2p-proxy


Require opt in for third party images

iD v2.17.0 has added a way to opt out of sending data to third party sites, but the default is send data, and one must opt out. I suggest flipping that, and making such third party request opt in. This small patch implements that change (I think). Opt in, rather that opt out, is the gold standard for privacy, and we should hold ourselves to high standards with human rights issues like privacy.
There are many conversations to be had about privacy and usability, and we should continue to have those conversations. In the mean time, this quick change makes us private-by-default until we can come to agreement and decide on the best way forward.
cf.: #7028 #7040

I'm closing this and replacing it with #7162 . I think I made a PR/branch against something else, and there are hundreds of commits. PR against master is sensible


Is this still working though?

I have deploy my this worker into production.
And added a SPF record and a _mailchannels record to my domainA.
And added a custom domainB to my worker.
Then try  to POST https://domainB/api/email the body below:
{
	"to"<EMAIL_ADDRESS>	"from": "support@domainA",
	"subject": "Hello World",
	"text": "Hello World"
}

But it always showed Internal Server Error.
Is there anything I missing to use this email sender?

Have you set up the new _mailchannels DNS record?
https://github.com/Sh4yy/cloudflare-email#setup-spf

Yes, I have set up this record too. But it is still not working, just respond the Internal Server Error message.

Same error here. Error 500

It happened to me too. I initially used the Deploy with Workers button and that never worked. Upon inspecting the code on cloudflare quick edits feature, I noticed the worker deployed was actually the default hello world. Maybe I configured it badly, dunno.
I then tried to use the 4 steps of cloning the repo locally to deploy it with wrangler and after properly setting up the SPF record as well as the now required TXT Domain Lockdown error (and since I was already using cloudflare to redirect my domain's email, I had to merge them so it looked at the end like this : v=spf1 a mx include:relay.mailchannels.net include:_spf.mx.cloudflare.net ~all), and after setting up both it seems to work fine for me!
Make sure to also always use a from mail coming from your domain, for some reason I thought I could send emails with the from field as any email, obviously that doesn't work haha

So yeah, maybe the Deploy with Workers button is broken, that I can't confirm, but it works for me after passing by and upvoting this issue initially.

Yes, it working here after configuring domain lockdown. I think it is mandatory now.

Confirmed mandatory for Cloudflare workers (from Domain Lockdown error) :


FEAT: Add lsf_suffix arg for api.push_model

When using SDK to upload models, there's no way to add files to lfs list, this PR add a parameter to pass lsf file types.

It doesn't seem like the changes in this PR caused the failure, I installed pre-commit and checked on local.


Support loading local files from Chrome App

This version of colaboratory is no longer supported, please switch to https://colab.research.google.com.


push to create is not working

Gitea Version
1.15.6 built with GNU Make 4.3, go1.16.9 : bindata, timetzdata, sqlite, sqlite_unlock_notify
Git Version
2.30.2
Operating System
Linux, Arch (using docker)
How are you running Gitea?
using docker; behind a caddy-webserver. The webserver handles HTTPS.
server-image: gitea:1.15-rootless
db-image: postgres:13
Database
PostgreSQL
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Description
How to enable push-to-create? The option doesn't seem to exist anymore, hence it's a bug, I suppose.
Using login credentials (name & pw).
User-Log:
git remote add origin https://***sub.domain.tld***/***USER***/***REPO***.git
git push --set-upstream origin master

Username for 'https://***sub.domain.tld***': ***USER***
Password for<EMAIL_ADDRESS>remote: Push to create is not enabled for users.
fatal: unable to access 'https://***sub.domain.tld***/***USER***/***REPO***.git/': The requested URL returned error: 403

Server-Log:
gitea       | 2021-11-11T16:26:15.498667083Z 2021/11/11 17:26:15 Started GET /***USER***/***REPO***.git/info/refs?service=git-receive-pack for IP_AND_PORT
gitea       | 2021-11-11T16:26:15.566583212Z 2021/11/11 17:26:15 ...s/context/context.go:331:HandleText() [E] Push to create is not enabled for users.
gitea       | 2021-11-11T16:26:15.566625221Z 2021/11/11 17:26:15 Completed GET /***USER***/***REPO***.git/info/refs?service=git-receive-pack 403 Forbidden in 67.381684ms

From the Docs here :
ENABLE_PUSH_CREATE_USER: false: Allow users to push local repositories to Gitea and have them automatically created for a user.

However, when searching for this option in app.example.ini, I can't find it.
Setting it changes nothing.
Pushing to a newly created repo does work fine.
Screenshots
No response

I'm not sure why it's not in the example config, but it is still documented as you mentioned.
Did you put it in the right section and restart gitea?

Should be alright(?):
[repository]
ENABLE_PUSH_CREATE_USER = true

I restarted the container (to be sure), hence yes.

It's the same app.ini as all the other configs, which are shown correctly on the admin/config dashboard.
(And I just noticed, there isn't a 'repository' section on that page.)

That looks good to me. I will try on a test instance later, but given we have tests for this I'm inclined to think it shouldn't be broken. (But I won't rule it out!)

I'm experiencing the same issue on gitea:1.15.7. ENABLE_PUSH_CREATE_USER=true does not seem to be working.

I've just tested this on my 1.15.7 instance (as well as a fresh test instance) and had no issues.
Can you double (triple) check that the config is set correctly?

I found the issue. The environment variable for the Docker image should be GITEA__REPOSITORY__ENABLE_PUSH_CREATE_USER=true instead of ENABLE_PUSH_CREATE_USER=true, as documented here.

The issue persists with gitea/gitea image version 1.15.9 after setting env vars
ENABLE_PUSH_CREATE_USER=true ENABLE_PUSH_CREATE_ORG=true ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET=false
But I notice these config values don't appear on the /admin/config

Actually I'm going to close this bug - once we find out what documentation is giving the incorrect impression we can update that but this isn't a bug.

@zeripath Sorry for not being active. I somehow forgot this issue over Christmas/new year.
Unfortunately, I'd call this issue being "highjacked" (though by accident). However, I'm glad others found their solution^.
I'm currently on 1.15.10 and the original issue (with its description) still persists.
And here is why:
First: The original issue was using gitea-data/custom/conf/app.ini – hence, a config file and not environment vars.
(IMHO the docs state pretty clearly, how to set environment).
Second: app.example.ini does not list ENABLE_PUSH_CREATE_USER nor ENABLE_PUSH_CREATE_ORG and ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET is listed under [security] and not [repository]
The docs (that) say

The defaults provided here are best-effort (not built automatically). They are accurately recorded in app.example.ini (s/main/<tag|release>).

How comes, that valid configuration is listed in the docs, but not in the supposedly generated and complete app.example.ini?
(Though, I dunno if it's generated, but it sounds so… and it sounds to claim to be complete)
Third: None of the above explains why <your-instance>.tld/admin/config doesn't list the config (as said by myself and delanym).
Fourth: The "does-work" solution seems to be: 'Set ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET=false' for… reasons??. app.example.ini notes this as "NOT RECOMMENDED" – with no explanation of what it actually does or what a complete environment is. (Can't find this in the docs either.)

Now, I did some testing with the newly earned knowledge.

ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET=false seems to be required for this feature (push-to-create) to work.
It does not seem to matter if it's set via app.ini or environment. Environment working more reliably? [see below] (gitea will set the value in /etc/gitea/app.ini as well)
I have to notice some issues between /etc/gitea/app.ini and custom/conf/app.ini. Some configuration of the latter is ignored. In my case, some UI configuration. However, I have to note, when I first set up gitea, some configuration options worked from custom/conf/app.ini only.
Though, I have no clue what's the deal between these two and why they don't work well with each other. afaik the one in etc is generated and set by gitea itself, while the one in custom/conf is for the admin to alter the configuration. afaik custom/conf takes precedence over /etc. – Though, I'm not sure about that.

Overall: Yes, the comments here helped and push-to-create is currently working for me. However, I'm pretty much clueless about said issues and left confused in the dark. Although it does work "de-facto", it doesn't feel like the issue is solved.
PS: I leave it up to you whether this should be moved into a new issue or not (as it doesn't matter for me).

I am a bit confused where ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET came into the picture, it should be entirely irrelevant to push-create. (and indeed it works fine both in test and on my real instance where I've left it out completely and it's therefore set to default true)
As well, ONLY_ALLOW_PUSH_IF_GITEA_ENVIRONMENT_SET is mostly undocumented because we don't want users to bypass the Gitea environment. Setting your own Gitea environment is intentionally left as an exercise to the reader because we don't recommend it.
Regarding push-create not existing in the sample config, it seems it was removed when we refactored and commented out the sample config because it was being copy/pasted. We should potentially re-visit #15807 as it seems to have unintentionally removed some of the options.
Gitea only uses a single config, there is no /etc/gitea/app.ini vs custom/conf/app.ini. Likely the difference is whether you run the binary yourself or have systemd run it. The docs cover how to set the config path when running manually.

From what I can tell in this thread, there is no bug present. Feel free to open a new issue if you encounter something else. 🙂


[SPARK-21629][SQL][WIP] Fix Or nullability

What changes were proposed in this pull request?
Override nullable of Or Expression to make sure nullable behavior is correct.
How was this patch tested?
I'll add test case later
cc @viirya

Can one of the admins verify this patch?

Ok. I think this should not be a problem. We should close this.

@gatorsmile  @viirya Thanks a lot. You are right. I close it for now.


Unable to get running with basic config

Used the example from documentation:
on: push
name: Slack Notification Demo
jobs:
slackNotification:
name: Slack Notification
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Slack Notification
uses<EMAIL_ADDRESS>env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
Configured a secret: SLACK_WEBHOOK on
https://github.com/organizations/myproject/settings/secrets
Getting error:
[ERROR] Secret SLACK_WEBHOOK is missing. Please add it to this action for proper execution.
Not sure what I am missing.
(also your documentation has a broken link for github documentation for setting secrets)

Hi @katelfox, thanks for noticing and reporting the broken link. It has been fixed now.
About the issue you are facing with org wide secrets, please check the access of the org wide secret. There are 3 scopes in it:

Please make sure that the right scope was selected. Otherwise the secret would not be available and you would get the error you as described in the issue.

@mrrobot47 thanks for the quick response.  It was already set to all repositories.

Can you share the link to GitHub actions run where you are facing this issue if it is a public repo.
If not, please check that the SLACK_WEBHOOK env variable is getting passed in the action run or not as below:

It's a private repo.  Here is the output:
/usr/bin/docker run --name rtcampactionslacknotifyv202_db1166 --label c27d31 --workdir /github/workspace --rm -e SLACK_WEBHOOK -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_API_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/test/test":"/github/workspace" rtcamp/action-slack-notify:v2.0.2
[ERROR] Secret SLACK_WEBHOOK is missing. Please add it to this action for proper execution.

The error you are getting is displayed only when either that env variable is not present or if its value is empty. Please check the value of the env var again.
For now, try to add this secret to the repository in which you are running this. Then see what happens. Ref: https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets#creating-encrypted-secrets-for-a-repository

Closing this issue due to no activity. Please feel free to re-open it if required.


Post-conference changes

Introducing a block "livestream_subsection" to enable centering the title indicating the day of each stream
Setting Thursday (day 1) as the default day of the schedule page

Thanks @kperros , looks good to me!


AWS Lambda Error: glib: Error creating thread: Resource temporarily unavailable

I'm running Sharp on AWS Lambda to convert source images to webp format.
My Sharp related code is as simple as:
image = sharp(buff).withMetadata();
image = image.toFormat('webp', {quality});
res = await image.toBuffer();

The problem is that sometimes this fails on the .toBuffer() call with the glib: Error creating thread: Resource temporarily unavailable error. By sometimes I mean eg. 1400 errors and 49000 successful executions during 1 hour period.
I've seen a similar issue with the resize #1535 but in my case setting concurrency to 1 doesn't help.
I tried:

sharp.concurrency(1)
sharp.cache(false)
setting environment variable UV_THREADPOOL_SIZE=1
retrying call to the image.toBuffer()
recreating Sharp instance on error: sharp(buff)
increased number of concurrent Lambda executions through AWS Support
increased Lambda memory

still nothing. Seems that after some time (as Lambda works by freezing container until the next execution) something happens that causes it runs out of available threads.
I'm clueless currently. Any hints what more can I check. Is there any way to eg. get a number of available threads left?

This looks like an AWS Lambda runtime problem unrelated to either sharp or libvips.
If you're running inside a VPC and talking to other AWS services such as S3 then it's worth trying without a VPC to see if that improves things, as I recall something seeing similar when DNS queries backed up.
I notice you've cross-posted at https://forums.aws.amazon.com/thread.jspa?messageID=922634&tstart=0 (requires AWS sign-in) and would agree AWS Support is the best place to ask this kind of question.

Thank you. I think I've found the possible reason, but I need to monitor/test it a bit more.
I've used serverless.com framework to deploy my Lambda to AWS. It wraps my Lambda handler function with their own handler/SDK that makes monitoring possible in the serverless.com dashboard.
Seems that when I've switched away from the serverless handler directly to my handler, the errors are gone... Possibly serverless SDK somehow drains the number of threads.

Thanks for the update, it sounds like this is unrelated to sharp or libvips. Please feel free to re-open with more details if further help is required.


Communication Setup overhead in testhost startup

Description

When profiling Live Unit Testing execution, it has been established that communication setup is a significant cost.

Steps to reproduce

Create a project with tests
Right-click the project (in solution explorer) > Live Unit Testing > Include
Wait for LUT glyphs to appear
Start profiler
Make some whitespace change
Wait for LUT glyphs to update (no more faded "clock" glyphs)
Stop profiler

Expected behavior

Setup costs should ideally be ten(s) of ms...

Actual behavior

Setup costs are several hundred ms...

TcpChannel setup and DefaultContractResolver.ResolveContract (Json deserializer) are two things that stand out to me...
Diagnostic logs
Environment

@abhishkk I think you worked on this. Can you please update your finding here?

@KevinH-MS @smadala
We will investigate Json serialization overhead and take changes for 15.8 if needed.
Letting the issue open considering it enhancement for 15.8.

@abhishkk @mayankbansal018 this is the other serialization library I was thinking of this morning:   https://github.com/Microsoft/bond

@genlu Are we still looking at perf improvements in this respect ?

FYI @AbhitejJohn @shyamnamboodiripad

@singhsarab Any improvements we can make here would be awesome as it looks like we are paying this cost on every code change that causes tests to be executed for LUT.
It would be interesting to investigate MessagePack for serialization in TP - we are using this in other parts of our code. @AbhitejJohn had measured MessagePack v/s JsonRPC and found that to be better / faster for our uses.
cc @jfleisher @drognanar @ManishJayaswal FYI

This change would require architectural changes, and breaking changes to public API and won't be implemented, we are focusing on adding new features to Testing.Platform instead. https://aka.ms/testingplatform


Added code to reuse the Http connection when using httplib2.Http object

I was running into problems with an app that made thousands of Solr queries.  Many sockets were being openned, used once and then left open.  This ended up causing: "[Errno 99] Cannot assign requested address".
if I ran this code, I was able to confirm this behavior using netstat (netstat -ptn  | wc -l).
import pysolr
conn = pysolr.Solr(url)
while True:
    res = conn.search(query)

After my changes, running the same code and netstat showed that only a fixed number of sockets were being created and the Exception mentioned above did not occur.

This doesn't make a lot of sense to me, TBH. pysolr talks to Solr over HTTP, meaning there should be just a single req-resp cycle & the socket should be closed. More information about your setup would be nice (Python version, Solr version, using httplib2 or the old crappy httplib path, etc).

The problem is the HTTP socket is not closed immediately.  It is left hanging in a TIME_WAIT state.  After a short time this exhausts how many sockets the python process can have open.  httplib2 is capable of reusing connections which avoids this issue and that what my code does.
System details:
Ubuntu Linux (tried on Ubuntu 10.04.3, Ubuntu 11.04)
Python 2.7.2+
pysolr - pysolr-2.1.0-beta.tar.gz from pip.  Also tried with pysolr from master as of today.
using httplib2 version 0.7.2 (from pip)
Anything about this setup that seems wrong to you?
Have you tried the "while True" snippet above on your system to see if the problem can be reproduced on your setup?
--Jason

TIME_WAIT state is entered by a socket after it has closed and is a normal part of TCP connections as I am sure you know from researching your problem. Your snippet will work on any system because it cranks out a huge number of TCP connections which are then closed; this causes the socket to enter the TIME_WAIT state. It's not an indicator of anything wrong.
I do not think introducing even more statefulness into the API is the proper solution in the long-term.

TIME_WAIT is not an indicator of anything wrong, but when there are several thousands of sockets in this state due to many solr queries it causes the app using pysolr to fail.  See exception below.
In [3]: conn = pysolr.Solr('http://<IP_ADDRESS>:8983/solr')

In [4]: while True:
    res = conn.search('aor:EUCOM')
   ...:
---------------------------------------------------------------------------
error                                     Traceback (most recent call last)

/home/user/<ipython console> in <module>()

/usr/local/lib/python2.7/dist-packages/pysolr.pyc in search(self, q, **kwargs)
    562         params = {'q': q}
    563         params.update(kwargs)
--> 564         response = self._select(params)
    565
    566         # TODO: make result retrieval lazy and allow custom result objects

/usr/local/lib/python2.7/dist-packages/pysolr.pyc in _select(self, params)
    354             # Typical case.

    355             path = '%s/select/?%s' % (self.path, params_encoded)
--> 356             return self._send_request('GET', path)
    357         else:
    358             # Handles very long queries by submitting as a POST.

/usr/local/lib/python2.7/dist-packages/pysolr.pyc in _send_request(self, method, path, body, headers)
    308                 start_time = time.time()
    309                 self.log.debug("Starting request to '%s' (%s) with body '%s'..." % (url, method, str(body)[:10]))
--> 310                 headers, response = http.request(url, method=method, body=body, headers=headers)
    311                 end_time = time.time()
    312                 self.log.info("Finished '%s' (%s) with body '%s' in %0.3f seconds." % (url, method, str(body)[:10], end_time - start_time))

/usr/local/lib/python2.7/dist-packages/httplib2/__init__.pyc in request(self, uri, method, body, headers, redirections, connection_type)
   1443                     content = ""
   1444                 else:
-> 1445                     (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
   1446         except Exception, e:
   1447             if self.force_exception_to_status_code:

/usr/local/lib/python2.7/dist-packages/httplib2/__init__.pyc in _request(self, conn, host, absolute_uri, request_uri, method, body, headers, redirections, cachekey)
   1195             auth.request(method, request_uri, headers, body)
   1196
-> 1197         (response, content) = self._conn_request(conn, request_uri, method, body, headers)
   1198
   1199         if auth:

/usr/local/lib/python2.7/dist-packages/httplib2/__init__.pyc in _conn_request(self, conn, request_uri, method, body, headers)
   1169                 if i == 0:
   1170                     conn.close()
-> 1171                     conn.connect()
   1172                     continue
   1173                 else:

/usr/local/lib/python2.7/dist-packages/httplib2/__init__.pyc in connect(self)
    797             break
    798         if not self.sock:
--> 799             raise socket.error, msg
    800
    801 class HTTPSConnectionWithTimeout(httplib.HTTPSConnection):

error: [Errno 99] Cannot assign requested address

I have a few real apps that makes several thousand Solr queries in a short amount of time so this TIME_WAIT related exception causes problems (basically the apps crash, or have to wait).  If Solr can keep up with this query rate (and it can when the HTTP connections are reused) the client side code should be able to as well.  I don't understand why adding statefulness to the Solr object is a bad thing.  If a user wanted/needed the old behavior they could create a Solr object before each query.
Httplib2 was designed so it could be reused for connections to the same server and since pysolr is designed to use connections to the same server, doesn't it make sense to reuse the httplib2 object when possible?


implement mailto callbacks

This change is hard to test. I've tested it end-to-end some on my stage, which has a (poorly configured) SMTP server. darwin.network has a well-configured SMTP server; as long as none of the basic functionality is broken, I think the final phases of testing can happen there.
I changed the NS REGISTER syntax to /NS REGISTER username email [password], and you can pass * if the server allows you to register without a valid email.

Hmm, on a rough side this looks pretty decent. Let's merge this, cleanup the config a little and do some more testing before release.


Easy way to run a single validates runner test

To run a single validates runner test, usually I change the testFilter block in the source to add an includeTestsMatching for the test I want to run. There should be an easy way to do this on the command line without having to modify the source.
Imported from Jira BEAM-12728. Original Jira may contain additional context.
Reported by: ibzib.

@ibzib This is absolutely possible using the usual --tests param, e.g.
gradle :runners:flink:1.15:validatesRunnerBatch --tests "org.apache.beam.sdk.schemas.AvroSchemaTest"
gradle :runners:flink:1.15:validatesRunnerStreaming --tests "org.apache.beam.sdk.schemas.AvroSchemaTest"
gradle :runners:spark:3:validatesRunnerStreaming --tests "org.apache.beam.sdk.schemas.AvroSchemaTest"


Multicam issue with Matlab

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ SR300 }

Firmware Version
{<IP_ADDRESS>}

Operating System & Version
{Win (10)}

Kernel Version (Linux Only)

Platform
{PC}

SDK Version
{ 2.19.1 }

Language
{Matlab}

Segment
{others }

Issue Description
<I'm using a multicam setup for a 3D capturing system with an array of 5 SR300 cameras using Matlab. I'm trying to acquire depth images by turning on 2 cameras at a time, while the others are turned off for the total of 5 cameras. The problem is that while using the realsense.pipeline(), the command automatically selects a realsense camera, and I can't adress to a specific camera. I tried communicating to each camera individually using Matlab with the multicam example https://github.com/IntelRealSense/librealsense/tree/master/examples/multicam , but with no succes at all.
Any help would be appreciated, thanks in advance. >

Can you share your code?

Can you share your code?

ctx = realsense.context(); % Create librealsense context for managing devices
n_devices = length(ctx.query_devices());
pipelines = realsense.pipeline();
for i = 1:n_devices
pipe = realsense.pipeline(ctx);
cfg = realsense.config();
cfg.enable_device(dev.get_info(realsense.camera_info.serial_number))
pipe.start(cfg);
pipelines.get_active_profile(pipe)
end

There appears to be some amount of missing code here. Where did dev come
from?

I was running this code to test the depth camera before trying to manage multicameras.  "dev" comes from this code.
% Make Pipeline object to manage streaming
pipe = realsense.pipeline();

% define object for the point cloud
pcl_obj = realsense.pointcloud();

% Start streaming on an arbitrary camera with default settings
profile = pipe.start();

% Get streaming device's name
dev = profile.get_device();
name = dev.get_info(realsense.camera_info.name);

% Obtener frames. Descartamos la primera pareja para permitir que
% el tiempo de cámara para liquidar
for  i = 1:5
    frames = pipe.wait_for_frames();
end

% Seleccione el marco de profundidad
depth = frames.get_depth_frame();
% obtener puntos de nube de punto sin color
points = pcl_obj.calculate(depth);
vertices = points.get_vertices();

% Convertir los vertices en una nube de puntos
ptCloud = pointCloud(vertices);

% Guardar nube de puntos en un archivo PLY
pcwrite(ptCloud,'3D_out.ply','PLYFormat','binary');

% Mostrar nube de puntos
pcshow(ptCloud);
title(sprintf("Depth frame from %s", name));

pipe.stop();

Hi, I just figure it out how to adress an specific camera, I went to the SDK and grab all of my cameras serial number and add them to a char array, later on I assigned the serial number to the config file, then made a loop to check the stream in all cameras. Here is the code to loop through all cameras just to check that they are connected.  Issue solved. Thanks
ctx = realsense.context(); % Create librealsense context for managing devices
n_devices = length(ctx.query_devices()); % Number of devices connected
cam_sn = ['627204001255';'627206001644']; % Serial numbers of all cameras
for i = 1:n_devices % Loop through all devices detected
pipe = realsense.pipeline(ctx); % Make Pipeline object to manage streaming
cfg = realsense.config(); % Create a new configuration
cfg.enable_device(cam_sn(i,:)); % Enable device in config file with the serial number of the camera
pipe.start(cfg); %Start streaming on a selected camera with default settings
pipe.stop(); % Stop streamming
end


Discussion: terminal for legacy Windows users

Windows Command Prompt can't be embedded into the editor like Windows Terminal. But it can be launched in a new window. The embed terminal will definitely not available. This is the reason why I only consider this a temporary workaround. Actual solution is https://github.com/SpartanJ/ecode/issues/145

The terminal can't be embedded into the editor like Windows Terminal. But they can be launched in a new window.

@SpartanJ What do you think about this?

So your idea is to simply open the configured default shell in a new process? I can do that.

So your idea is to simply open the configured default shell in a new process? I can do that.

This is useful enough for me. Please implement it. Thank you.

Will do.


Should FhirEngineProviderTestRule be part of the SDK?

Is your feature request related to a problem? Please describe.
Applications that use the SDK will need to set up unit testing schemes involving the local database. Utility classes for testing purposes can help users structure their testing needs. FhirEngineProviderTestRule is a simple class that clears the database after every test run. It's essential not only for this project's unit tests but to all users of this library.
Describe the solution you'd like
Distribute utility classes for testing purposes as a maven repo either as an Android-Fhir package for testing or inside the SDK itself.
Describe alternatives you've considered
Copy/paste the class to my application. It works but is not ideal.
Additional context
Add any other context or screenshots about the feature request here.
Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

i think this feature request makes sense


About the backbone

@liuruijin17 Hi! I'm re-implementing your great method.
I'm just checking the modifications you made on the ResNet-18 backbone. Except for the width change, I find there seems to be also a drop of basicblock at layer1, other settings (not counting frozen BN and width change) are exactly the same as He's ResNet-18, could you check if I'm correct?

Yes, you are correct. The first block only has one 'BasicBlock' layer.

Thanks! Closing issue.


Created italian translation

@maicol07 thanks for submitting these! I've tagged 1.2.0 with them in, but they will also be in 2.0 which I'll tag when Laravel 9 is out in the next week.


How to expire third party software updates manually in SCCM 1806 and higher

Hi there,
We have used SCUP with SCCM 2012 R2. SCUP had a option to expire update, is there similiar function / option available in SCCM 1806 or higher?
Since we dont need SCUP to sync third party updates.
Please add steps in the help document as well.

@aczechowski any updates? We are waiting for your inputs, Actually we are stuck and donno how to manually expire third party software updates in SCCM 1806.

@manishr38 I'm sorry that you're having problems, but this feedback mechanism is not for support escalations. We're investigating whether any doc updates are needed, but we don't provide any SLAs on responses. There are a couple of options available to provide the best level of support for this:

Post on Configuration Manager forums. These are moderated by our community MVPs who are very experienced, knowledgeable, and helpful.
Use Microsoft Support to search for the issue, or open a case with professional support.
Contact your Microsoft Premier team, such as a Premier Field Engineer or Technical Account Manager.

Thanks again for the feedback. We moved this content to a new GitHub repository, so this issue is no longer tracked with the original article. As part of that process, we reviewed our backlog of feedback, and made some tough decisions on items that we don't think we'll realistically ever address. If you're passionate about this specific feedback, please refile it on the current article, now under docs.microsoft.com/mem/configmgr.


[CLI] Disable wandb does not work in unittests

Description
I try to disable wandb.log() when executing unittests. The unittests are executed via PyCharm in a Conda environment that are both located on C:. The codebase is located on D:.
Wandb features
import unittest
import os
import wandb

class TestModelEvaluation(unittest.TestCase):

    @classmethod
    def setUpClass(cls):
        os.environ["WANDB_MODE"] = "disabled"
        wandb.init()

and this
wandb.init(settings=wandb.Settings(mode="disabled"))
wandb.log()

fails with the same error:
C:\ProgramData\Anaconda3\envs\ml\python.exe "C:\Program Files\JetBrains\PyCharm 2020.3.2\plugins\python\helpers\pycharm\_jb_unittest_runner.py" --path D:/workspace/thesis/raisinnet/raisinnet
Testing started at 17:55 ...
Launching unittests with arguments python -m unittest discover -s D:/workspace/thesis/raisinnet/raisinnet -t D:\workspace\thesis\raisinnet\raisinnet in D:\workspace\thesis\raisinnet\raisinnet

2021-03-22 17:55:37.508280: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic library cudart64_101.dll
Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_init.py", line 740, in init
    wi.setup(kwargs)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_init.py", line 80, in setup
    self._wl = wandb_setup._setup()
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 242, in _setup
    wl = _WandbSetup(settings=settings)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 231, in __init__
    _WandbSetup._instance = _WandbSetup__WandbSetup(settings=settings)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 92, in __init__
    self._settings_setup(settings, self._early_logger)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 118, in _settings_setup
    s._infer_run_settings_from_env(_logger=early_logger)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_settings.py", line 848, in _infer_run_settings_from_env
    program_relpath = self.program_relpath or _get_program_relpath_from_gitrepo(
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_settings.py", line 141, in _get_program_relpath_from_gitrepo
    relative_path = os.path.relpath(full_path_to_program, start=root)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\ntpath.py", line 703, in relpath
    raise ValueError("path is on mount %r, start on mount %r" % (
ValueError: path is on mount 'C:', start on mount 'D:'

Failure
Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_init.py", line 740, in init
    wi.setup(kwargs)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_init.py", line 80, in setup
    self._wl = wandb_setup._setup()
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 242, in _setup
    wl = _WandbSetup(settings=settings)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 231, in __init__
    _WandbSetup._instance = _WandbSetup__WandbSetup(settings=settings)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 92, in __init__
    self._settings_setup(settings, self._early_logger)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_setup.py", line 118, in _settings_setup
    s._infer_run_settings_from_env(_logger=early_logger)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_settings.py", line 848, in _infer_run_settings_from_env
    program_relpath = self.program_relpath or _get_program_relpath_from_gitrepo(
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_settings.py", line 141, in _get_program_relpath_from_gitrepo
    relative_path = os.path.relpath(full_path_to_program, start=root)
  File "C:\ProgramData\Anaconda3\envs\ml\lib\ntpath.py", line 703, in relpath
    raise ValueError("path is on mount %r, start on mount %r" % (
ValueError: path is on mount 'C:', start on mount 'D:'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\ProgramData\Anaconda3\envs\ml\lib\unittest\suite.py", line 163, in _handleClassSetUp
    setUpClass()
  File "D:\workspace\thesis\raisinnet\raisinnet\test_create_report.py", line 25, in setUpClass
    wandb.init()
  File "C:\ProgramData\Anaconda3\envs\ml\lib\site-packages\wandb\sdk\wandb_init.py", line 780, in init
    six.raise_from(Exception("problem"), error_seen)
  File "<string>", line 3, in raise_from
Exception: problem

I would expect no error and being able to test code that contains wandb.log() class without side effects.
How to reproduce
Execute the code similar to this:
C:\ProgramData\Anaconda3\envs\ml\python.exe "C:\Program Files\JetBrains\PyCharm 2020.3.2\plugins\python\helpers\pycharm\_jb_unittest_runner.py" --path D:/workspace/thesis/raisinnet/raisinnet
Environment
OS: Windows-10-10.0.19041-SP0
Python version: 3.8.8
Environment: Anaconda

This is happening because you're running a program from a different drive.  We should handle this case, but until then you can just disable our code syncing by setting os.environ["WANDB_DISABLE_CODE"]="true"

class TestModelEvaluation(unittest.TestCase):

    @classmethod
    def setUpClass(cls):
        os.environ["WANDB_DISABLE_CODE"] = "true"
        os.environ["WANDB_MODE"] = "disabled"
        wandb.init(settings=wandb.Settings(mode="disabled"))

I tried this but the same error occurs.

My current workaround is to refactor wandb logging code out of unit-tested classes or setting flags.
if log_wandb:
    wandb.log({"foo":bar})

This specific error would be fixed if your anaconda environment was on the same drive as your code.  Looking closer at the code, I believe this would work for you:
wandb.init(settings=wandb.Settings(mode="disabled", program="test.py", program_relpath="test.py"))

In this line full_path_to_program is 'C:\\Program Files\\JetBrains\\PyCharm 2020.3.2\\plugins\\python\\helpers\\pycharm\\_jb_unittest_runner.py' and root 'D:/workspace/thesis/raisinnet' which can can not be expressed relative to each other. I tested with and without setting program and program_relpath but they seem to have no effect on the method i linked to. It seems that the the settings fromwandb.init()are not passed to wandb_setup.setup() (see here)
The method currently assumes that the executing script is within the root of the project. Therefore the workaround only works if we call the test_file directly and then call unittest.main() and maybe if one would use a venv located in the project directory.
In my case, I use the PyCharm IDE Unit testing tools but also calling the unittest package does not work (same error):
D:\workspace\thesis\raisinnet>python -m unittest raisinnet.test_create_report
Hope it helps!

@mjohenneken thanks max, and apologies for all this back and forth.  I just tested this locally and confirmed it works:
wandb.setup(wandb.Settings(program="test.py", program_relpath="test.py"))

Just be sure to call this before you call wandb.init when you're running tests and the error should go away.

Ok, I can run the unit tests now. To prepare a test environment this setup method can be used:
import tempfile
import shutil

class TestModelEvaluation(unittest.TestCase):

    tempdir = None

    @classmethod
    def setUpClass(cls):
        cls.tempdir = tempfile.mkdtemp()
        print(f"Using temporary directory: {cls.tempdir}")
        wandb.setup(wandb.Settings(mode="disabled", program=__name__, program_relpath=__name__, disable_code=True))
        wandb.init(dir=cls.tempdir)

    #@classmethod
    #def tearDownClass(cls) -> None:
    #    wandb.finish()
    #    shutil.rmtree(cls.tempdir)

    ...

Although, log files will still be written. With this snippet, they are put into a temporary dir. I was not able to clean up afterward because the wandb process has still open file descriptors to the debug.log file even after calling finish(). For now, this can serve as a workaround because it's not much that is written to the file system.

You can also patch whole wandb init method to disable logging.
@patch.object(wandb, wandb.init.__name__)
def test(self, mock_wandb_init):
    mock_wandb_init.return_value = MagicMock()


Test and deploy Data Collection pipeline for Deep AQAtik on the server

Since main function of data collection pipeline has completed, it needs to be tested and deployed on the server to collect and monitor Github issues in real-time.
Initial test met two problems:

TabError: inconsistent use of tabs and spaces in indentation
FileNotFoundError: [Errno 2] No such file or directory: '../data/GitHubData/IssueContent/aqa-tests_2739.txt'

After running the program for 20 mins, it crashed with error
 url: https://trss.adoptium.net/api/getOutputByTestInfo
Couldn't find data for test
Traceback (most recent call last):
  File "collect_data.py", line 193, in <module>
    main()
  File "collect_data.py", line 190, in main
    fetch_github_issues(args, db)
  File "collect_data.py", line 160, in fetch_github_issues
    fetch_new_issues(repo, since, auth_token, db)
  File "collect_data.py", line 131, in fetch_new_issues
    store_issue_details(r, repo, db)
  File "collect_data.py", line 42, in store_issue_details
    issue_number = issue['number']
TypeError: string indices must be integers

The above error is caused by "API rate limit exceeded", will add handling for this error.

Close this issue since PR #499 and #504 have been merged, and the data collection pipeline has been deployed on server and collected issues successfully.


Add Docker BuildKit to CI and test pip caching

Closes #933.
Prerequisites:

[x] Unless it is a documentation hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary
This is a test to see if we can use Docker BuildKit in CI.

This is currently complicated by the interaction between actions/cache in CI and --mount=type=cache,target=/root/.cache/pip in Docker. It is unclear where Docker stores its cache, but it is certainly not placing those files in root/.cache/pip.


Update clang-tidy-review action to v0.20.1

Description
Please include a summary of changes, motivation and context for this PR.
The clang-tidy-review workflow is currently broken. This was fixed by upgrading to a newer version of the action in other repos.
Fixes # (issue)
Type of change
Please tick all options which are relevant.

[x] Bug fix
[ ] New feature
[ ] Added/removed dependencies
[ ] Required documentation updates

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.80%. Comparing base (f98cca3) to head (627456a).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   80.80%   80.80%
=======================================
  Files          19       19
  Lines         974      974
  Branches       93       93
=======================================
  Hits          787      787
  Misses        187      187

Files with missing lines
Coverage Δ

src/xoptions.cpp
100.00% <ø> (ø)

Files with missing lines
Coverage Δ

src/xoptions.cpp
100.00% <ø> (ø)

Hey Matthew, the emscripten build is expected to fail. I shall fix that soon and rebase the PR on top of it !

@anutosh491 can you merge the PR now and fix the emscripten build in a later PR? This PR is only to fix the broken clang-tidy workflow, which is known to work with this fix. Your PR couldn't be checked with clang tidy otherwise.


Runtimeerror when running train.py

Hi there,
I encountered the following error when I ran train.py. I tried both locally (Windows 10 with pytorch v1.5.1) and on Google Colab and both yielded the same error. Could you provide any thoughts as to why this occurred? Thanks.
Traceback (most recent call last):
File "train.py", line 88, in
g_loss.backward()
File "C:\Users\User\anaconda3\envs\SR\lib\site-packages\torch\tensor.py", line 198, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "C:\Users\User\anaconda3\envs\SR\lib\site-packages\torch\autograd_init_.py", line 100, in backward
allow_unreachable=True)  # allow_unreachable flag
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [1, 1024, 1, 1]] is at version 2; expected version 1 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

@lucasc400
I faced the same error. By adding the two lines below, it was fixed:
.
.
.
############################
# (2) Update G network: minimize 1-D(G(z)) + Perception Loss + Image Loss + TV Loss
###########################
netG.zero_grad()
############################################################
## The two lines below are added to prevent runetime error! ##
fake_img, _ = netG(z)
fake_out = netD(fake_img).mean()
############################################################
g_loss = generator_criterion(fake_out, fake_img, real_img)
.
.
.

Hi @ali-zafari @developer0hye
I tried to add the two lines same to you in train.py but have the error like this:
File "train.py", line 90, in
fake_img, _ = netG(z)
ValueError: not enough values to unpack (expected 2, got 1)
Could you give me solution for this problem ? Thank you !

@meeng251
Oh I'm sorry. I made a mistake in the code snippet above. I had customized the generator for myself.
By the way, I repeated the correct code below: (The point is that the generator should send out only ONE output)
.
.
.
############################
# (2) Update G network: minimize 1-D(G(z)) + Perception Loss + Image Loss + TV Loss
###########################
netG.zero_grad()
############################################################
## The two lines below are added to prevent runetime error! ##
fake_img = netG(z)
fake_out = netD(fake_img).mean()
############################################################
g_loss = generator_criterion(fake_out, fake_img, real_img)
.
.
.

Hi @ali-zafari , according to your fixed code, I found it's duplicate 2 lines of code:

fake_img = netG(z)
fake_out = netD(fake_img).mean()

So you keep it or delete it if duplicate ?
        ############################
        # (2) Update G network: minimize 1-D(G(z)) + Perception Loss + Image Loss + TV Loss
        ###########################
        netG.zero_grad()
        ############################################################
        ## The two lines below are added to prevent runetime error! ##
        fake_img = netG(z)
        fake_out = netD(fake_img).mean()
        ############################################################
        g_loss = generator_criterion(fake_out, fake_img, real_img)
        g_loss.backward()

        fake_img = netG(z)
        fake_out = netD(fake_img).mean()

        optimizerG.step()

@meeng251
They are not duplicate. the former is the fake image produced from generator and the latter is the decision of discriminator about the produced image. So keep both.


A cell tag COURSE_ONLY that takes an argument

Would be useful to be able to enable or disable a block of code for a specific course e.g.
Classroom-Setup
%python

# COURSE_ONLY azure-data-engineering

dbutils.unmount ...

Then in a notebook show how to mount that same directory. Toward modular global scripts so that course specific changes are made on one file, rather than creating a classroom setup for every course.
Also useful to verify a runtime. See recent work Brooke did:
assert '-ml-' in sc.getConf().get('spark.databricks.clusterUsageTags.sparkVersion'), "You must use the ML Runtime to run this material."

is better in an init script but should only be run for ML/DL content.

Would it need to support a list of courses?  Or perhaps could it be a check for a variable that's set in a build.yaml so that more than 1 course could have it?

Either would work.

May not be entirely necessary per some later convos.

If this is no longer necessary, can we close it?


[docs] Update breakpoint info to be in line with code

The definition of the extra small breakpoint was changed from 360 to 0 in the code, but in the description it still says 360dp.
This PR changes it to 0dp in the description as well as clarifying that the breakpoints are minimum widths.

@nikoladev Good call. Thanks for this first pull-request here :).

Wow, you're fast :p
No problem!


feat(spa): add loading bar

ive been using my own quartz site on slow wifi and realized we dont have a loading indicator of any sort so it looks like the page is frozen when we try to fetch the content

at some point we will add loading skeleton :)


Please add claming a base station

Please add claiming a base station
Endpoint: /api/v1/me/elements/bs01/claim
Payload: activationCode

Is there any benefit of this, now that the gigaset elements cloud service has been turned off?
What would be the purpose of claiming/activating a base station? Do you have more information about this?


infer can't  Ignore third party library scanning

if run：
infer --pmd-xml -- xcodebuild -workspace Vodka.xcworkspace -scheme Vodka
will analysis all files including Pods , but  i want to analysis my project files ,can i add some parameter  to  Ignore third party library?

Thanks for your question, there is a hole in our documentation currently. This has been answered on #364, please report there if that doesn't work for you.


Pos cloud customer registration

Description
When registering during checkout your account is not created when you place your order and pay with 'POS with Terminal API'. This seemed like a missing feature.
After contacting Adyen support I created a rough draft which should help with implementing this feature. It's based on how to core functions.
Fixed issue:  975

Hi @vrielsa ,
we implemented this functionality in #1061
Thank you for the draft.
Regards,
Alessio
Adyen


Sitemap rewrite url does not support regex expression

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.5.3___
[ ] ACS AEM Commons Version: 4.4.2___
[ ] Reproducible on Latest? yes/no: Yes

Expected Behavior
Please describe briefly the expected behavior, i.e. when I do X, Y should happen.
Sitemap rewrite (url.rewrites) should support regex so that we can rewrite the url as we show it live
Actual Behavior
Please describe briefly the actual behavior, i.e. when I do X, Z happens.
Currently the url.rewrite will only works if the regex is starting with the url string and cannot replace for string in the middle of the url
Ex: we can only replace if url and url.rewrite matches starting string
Steps to Reproduce
Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to
any supporting assets, e.g. content packages, below
Try to replace the string in between url using url.rewrites and it wont work
Links
Links to related assets, e.g. content packages containing test components
To fix this we need to change the logic in below file
SiteMapServlet.java - acs-aem-commons/bundle/src/main/java/com/adobe/acs/commons/wcm/impl/SiteMapServlet.java
Line no: 262
Existing:
{code}
if (path.startsWith(rewrite.getKey())) {
return url.replaceFirst(rewrite.getKey(), rewrite.getValue());
}
{code}
New:
{code}
if (path.matches(rewrite.getKey())) {
return url.replaceFirst(rewrite.getKey(), rewrite.getValue());
}
{code}
path.startsWith to path.matches
I tested the code with latest version of ACS Commons (4.8.5) and functionality is working as expected.
Please review and let me know if the changes are good to push ? If possible please provide me git commit access.

@ravipampana1 Can you provide a PR as described in https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/CONTRIBUTING.md#how-to-contribute-code?


Replace All across multiple files overwrites all targeted files with the same code

Version: 1.28.1 (user setup)
Electron: 2.0.9
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
Windows: 10
Steps to Reproduce:

Use the find & replace tool to find a term found in multiple files
Enter your term in the "Replace" field
Press the "Replace All" icon

Issue: the code from one of the target files is copied and overwritten into all the other files.
So if the find & replace tool lists:
style1.scss
style2.scss
style3.scss

... and I press "Replace All", the code from style1.scss will be overwritten into style2.scss and style3.scss.

 I haven't seen this before and I'm not sure exactly what you mean when you say "the code from style1.scss will be overwritten into ..."


[Feature] Best ckpt hook

CU-4bw21b

Task linked: CU-4bw21b best performance checkpoint hook

ping @xvjiarui


It just return undefined if wechat not installed

Is it possible to return a more specific message or error?
const res = await shareText({
text: 'text',
scene: NativeWechatConstants.WXSceneSession
}).catch(e=>{
  console.log(e) // e == undefined
})
// res == undefined

ps: there's a mistake in your demonstrate
import {registerApp} from 'native-wechat';

useEffect(()=>{
         // `registerApp` should accept a request-type argument
         // the blow code causes the crash, It makes me  almost give up
        // and the right way is registerApp({appId:'wx964290141ebe9b7b'})
	return registerApp('wx964290141ebe9b7b');
}, [])

Would you like to add some argument checks or catch errors in case of an app crash?

Sure, I'll try.


Add landmarks to chat

What
Add landmarks to chat
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2908209
How Tested

I think we have two options to fix this bug:

(easier) we only apply landmarks to the sample app (only code inside samples/)
(better but this would be a feature request) we expose the ability to set roles through our composite API

I would stick with 1 for now if it sufficiently solves the bug

Updated to only modify the sample :)


Yellow is a terrible color for visibility

Let me begin by saying that I appreciate your hard work and dedication to this project.
When kicking off a crew, the verbose output can sometimes be challenging to read. For example, the color yellow is tough to read. While I can manually go in and edit the code and manually setup crewAI, it would be nice if you would consider changing the text color yellow to, say, orange, which is easier to read. Thanks for considering this request.

will do 😎👉👉
João Moura
@joaomdmoura http://twitter.com/joaomdmoura
Em sex., 5 de abr. de 2024 às 14:20, 1of13 @.***>
escreveu:

Let me begin by saying that I appreciate your hard work and dedication to
this project.
When kicking off a crew, the verbose output can sometimes be challenging
to read. For example, the color yellow is tough to read. While I can
manually go in and edit the code and manually setup crewAI, it would be
nice if you would consider changing the text color yellow to, say, orange,
which is easier to read. Thanks for considering this request.
SCR-20240405-jjuw.png (view on web)
https://github.com/joaomdmoura/crewAI/assets/31781349/09473dfb-0549-42e5-801c-9e2ab2665432
—
Reply to this email directly, view it on GitHub
https://github.com/joaomdmoura/crewAI/issues/427, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFC3NZTOUOHYPPIOYFI3PLY33MPDAVCNFSM6AAAAABFZQJCZGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDQNBYHEZTAMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Is there a setting we can change to alter the default text colors? I typically use a dark theme and the bold purple is a hard read for an old bugger like me.

There is no setting to change the colors, but you can money patch,
Closing as original issue fixed


update(cri): cri-dockerd support

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Support cri-dockerd container runtime. Fixes https://github.com/falcosecurity/falco/issues/3243.
To avoid looking up docker containers in this scenario from the cri and original docker socket configure on client side like this https://github.com/falcosecurity/falco/issues/3243#issuecomment-2195465490, see for example the Falco PR https://github.com/falcosecurity/falco/pull/3266.
Which issue(s) this PR fixes:
https://github.com/falcosecurity/falco/issues/3243

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.18.0

I have the Falco PR up as well. This is ready for review, thanks.

@incertum should we also add cri-dockerd in rules?
container_entrypoint macro should be one

@incertum should we also add cri-dockerd in rules? container_entrypoint macro should be one

Let's check, it may be just like regular docker (haven't checked the proc lineage) . I believe cri-dockerd is just a wrapper socket on top.

@falcosecurity/libs-maintainers any news on this PR or objections? Ty

@falcosecurity/libs-maintainers any news on this PR or objections? Ty

I haven't tested it, anyway no concerns from me.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update sbt-davenverse to 0.1.0

Updates io.chrisdavenport:sbt-davenverse from 0.0.7 to 0.1.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.chrisdavenport", artifactId = "sbt-davenverse" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #294.


cannot reshape array of size 0 into shape (0,newaxis)

Hi Eric,
Thanks for your great work. When I run motion_representation.ipynb,  I meet the following errors.

I wonder if it matters? And how to solve it.

Hi,
This should be fine.
On Sun, Nov 13, 2022 at 5:42 PM yyyouga @.***> wrote:

Hi Eric,
Thanks for your great work. When I run motion_representation.ipynb, I
meet the following errors.
[image: image]
https://user-images.githubusercontent.com/52462696/201553637-587b9cd1-d796-401b-abfb-e085bde51ec2.png
I wonder if it matters? And how to solve it.
—
Reply to this email directly, view it on GitHub
https://github.com/EricGuo5513/HumanML3D/issues/15, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRYNB3N75EEQQLQMWTSYOTWIGDH7ANCNFSM6AAAAAAR7JPI3U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm getting the same errors. The errors also stop the rest of the files from processing so it seems like an issue, no?

I also got this issue. How can I fix this?

Just skip these lines by using try ... except.... There are only very a few
of them has this error.
qiqiApink @.***> 于2023年3月7日周二 07:17写道：

I also got this issue. How can I fix this?
—
Reply to this email directly, view it on GitHub
https://github.com/EricGuo5513/HumanML3D/issues/15#issuecomment-1458253046,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRYNBYPLBSLFKSKXLLM4I3W247PRANCNFSM6AAAAAAR7JPI3U
.
You are receiving this because you commented.Message ID:
@.***>


custom-fields ERROR_HTTP_400: Access Declined

On click on "Custom Field" tab from the Navigation bar, getting Error. But i am a System Admin and i have access to all the objects and Fields.
Can you please help here and try to resolve.
To Reproduce
Goto  -> "Custom Fields"
On click Getting Error
Errors like:
TAB custom-fields ERROR_HTTP_400: Access Declined
RECIPE custom-fields Error in dataset!
DATASET custom-fields Statistics of 12101 Dependency API elements: 0 pending, 1351 done, 1070 in error...
Thank you!

Thank you for the quick turn around. Please let us know once it is pushed.

Thanks . its loading the data now and not giving any error, but still when i do search for particular field its not giving proper result.

Can you be more specific.
With actual use case, data, screenshots?

can you actually give more information about this new issue you have?
you need to understand that it's difficult for me to correct an issue with only the following statement "when i do search for particular field its not giving proper result."

any more information? examples? to bring to this issue so I can see what's wrong?