[Bug]: Send: "not enough funds" when trying to pay onchain address with LN funds only

Describe the bug
A user can find themselves in a state where they only have funds in spending (LN) but no balance on savings (onchain). When trying to pay an onchain only address the wallet will show a non-descriptive error of  "Not enough funds - You need xxx more to pay this invoice".
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
Android, iOS
Bitkit version
latest
Log output
No response

This is the expected behaviour. if a user want to pay with onchain founds, he can move his LN founds to onchain.

update: The error message says "Not enough funds" even though the user has funds. Can be confusing to noobs. This issue was raised from a developer in Viareggio

We should be more descriptive and specific here. 'Not enough funds in savings' or 'Not enough funds in spending balance'.

Can't reproduce this, the toast message is accurate: "Insufficient Savings" - "More ₿ needed to pay this Bitcoin invoice."

Verified in v124. 'Insufficient Savings' message now displayed in this scenario.


JSONLinting

Following on from #171 Let's JSON Lint
Acceptance Criteria to put something in CI/CD pipelines that lints pull requests and throws out those that aren't

CI/CD pipeline will provide GitHub user with useful feedback of what line broke allowing folks to understand what went pete tong
CI/CD pipeline will provide GitHub user with useful feedback if the JSON is totally valid ⭐

Could we use Prettier in the project and as a GitHub Action https://github.com/marketplace/actions/prettier-action ?

@eddiejaoude for sure, totally gonna PR this as I wanna see it in action!

Good suggestion @eddiejaoude thanks for the PR approval.
For anyone else on the internets who lands on this, the prettier-action github page needs updating to suggest the latest version, I had to bump it up from version:3.0 to version:3.1 so that only_changed was not an unknown variable.

#175 to enhance this work


[489] Rubocop ToDo: Update enrichment model attributes to snake case

Context
Clear up of Rubocop to do: https://trello.com/c/UhJu4WFi/489-clear-rubocoptodo-part-2
Changes proposed in this pull request
I've updated all of the camel case attributes across the enrichment models and associated specs to snake case to appease the linter.
Guidance to review
All specs are still passing. But I may be missing an obious reason for these attribute being defined in Camel case.
If I am absent and this doesn't look right please feel free to close this PR.
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

@george-bit I can see changes from some of the PRs here? eg the view component/super complaints

 Clear rubocop_todo part 2

Putting this on the backburner until the migration from Publish to TTAPI is completed


Cleanup autorest diagnostics

Lots of diagnostics declared that we don't emit anymore

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-autorest

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/408/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/408/


SharePoint Learning Center bug on our Dev Tenant

Category

[ ] Question
[ ] Typo
[x ] Bug
[ ] Additional article idea
Trying to provision SharePoint learning site - we get this error

SharePoint     Online Provisioning Service     Unfortunately, your     request to provision     "Custom     learning for Office 365"      template failed.
SharePoint     Online Provisioning Service     Unfortunately, your     request to provision     "Custom     learning for Office 365"      template failed.

SharePoint     Online Provisioning Service     Unfortunately, your     request to provision     "Custom     learning for Office 365"      template failed.

Here is the exception that occurred:     Type = System.ArgumentException Message = Page Home.aspx is     not a "modern" client side page Source = OfficeDevPnP.Core     TargetSite = OfficeDevPnP.Core.Pages.ClientSidePage     Load(Microsoft.SharePoint.Client.ClientContext, System.String) StackTrace =     at OfficeDevPnP.Core.Pages.ClientSidePage.Load(ClientContext cc, String     pageName) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectClientSidePages.ProvisionObjects(Web     web, ProvisioningTemplate template, TokenParser parser,     ProvisioningTemplateApplyingInformation applyingInformation) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web     web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation     provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser     tokenParser, ProvisioningTemplateApplyingInformation applyingInformation)     at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation provisioningInfo) at     Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation applyingInformation) at     SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext()     in     C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line     337 HResult = -2147024809 | Here is the exception that occurred:     Type = System.ArgumentException Message = Page Home.aspx is     not a "modern" client side page Source = OfficeDevPnP.Core     TargetSite = OfficeDevPnP.Core.Pages.ClientSidePage     Load(Microsoft.SharePoint.Client.ClientContext, System.String) StackTrace =     at OfficeDevPnP.Core.Pages.ClientSidePage.Load(ClientContext cc, String     pageName) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectClientSidePages.ProvisionObjects(Web     web, ProvisioningTemplate template, TokenParser parser,     ProvisioningTemplateApplyingInformation applyingInformation) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web     web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation     provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser     tokenParser, ProvisioningTemplateApplyingInformation applyingInformation)     at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation provisioningInfo) at     Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation applyingInformation) at     SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext()     in     C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line     337 HResult = -2147024809
Here is the exception that occurred:     Type = System.ArgumentException Message = Page Home.aspx is     not a "modern" client side page Source = OfficeDevPnP.Core     TargetSite = OfficeDevPnP.Core.Pages.ClientSidePage     Load(Microsoft.SharePoint.Client.ClientContext, System.String) StackTrace =     at OfficeDevPnP.Core.Pages.ClientSidePage.Load(ClientContext cc, String     pageName) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectClientSidePages.ProvisionObjects(Web     web, ProvisioningTemplate template, TokenParser parser,     ProvisioningTemplateApplyingInformation applyingInformation) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web     web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation     provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser     tokenParser, ProvisioningTemplateApplyingInformation applyingInformation)     at     OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation provisioningInfo) at     Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant     tenant, ProvisioningHierarchy hierarchy, String sequenceId,     ProvisioningTemplateApplyingInformation applyingInformation) at     SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext()     in     C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line     337 HResult = -2147024809

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
If you are planning to share a new feature request (enhancement / suggestion), please use SP Dev UserVoice at http://aka.ms/sp-dev-uservoice. (DELETE THIS PARAGRAPH AFTER READING)
(DELETE THIS PARAGRAPH AFTER READING)

Expected or Desired Behavior

If you are reporting a bug, please describe the expected behavior. If you are suggesting an enhancement please describe thoroughly the enhancement, how it can be achieved, and expected benefit.
(DELETE THIS PARAGRAPH AFTER READING)

Observed Behavior

If you are reporting a bug, please describe the behavior you expected to occur when performing the action. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Steps to Reproduce

If you are reporting a bug please describe the steps to reproduce the bug in sufficient detail to allow testing. Only way to fix things properly, is to have sufficient details to reproduce it. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Submission Guidelines

All suggestions or bugs are welcome, please let us know what's on your mind.
If you are reporting an issue around any of the documents or articles, please ensure that you have clear > reference on the specific file or URL, which should be fixed.
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and > #spfx-tooling on (SharePoint StackExchange)[http://sharepoint.stackexchange.com/]. You can also > alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.

(DELETE THIS PARAGRAPH AFTER READING)

Thanks for your contribution! Sharing is caring.

Your exception indicates that you are trying to apply the template on top of an existing site, which is not compliant with the template... like the existing site being classic team site. In upcoming versions, we will not even support this, but to test the service, would suggest ensuring that you use a new URL or delete the old site collection from the URL which you want to use.
Can you retest this with the latest version and use a clean URL?


[tool/gcc/vcs] c files listed as Filetype: systemverilog in fusesoc

in the Fusesoc
we list all .c/.h files as  file_type: systemVerilogSource
this makes xcelium gcc choke on aes_model_dpi.c
particularly it chokes on the include of cstring

Why are we defining c files as systemverilog type?
I seem to remember seeing something about this being a VCS problem. but I cannot find the issue describing this problem.
If I remove the file_type: systemverilog
both vcs and xcelium seem to compile just fine?
do we need to keep this pragma, and if so we need a workaround to get this working for xcelium

Hi Rasmus,
the original issue is here: #953
Could you please state which core files exactly you had to modify to make it compile? Is it just hw/ip/aes/dv/aes_model_dpi/aes_model_dpi.core or also hw/ip/aes/model/aes_model/aes_model.core?
If I understand it correctly, you are saying that we should again declare those files as cSource. Correct?
Since I cannot test this locally (I do not have access to any of those tools), I would be happy if @sriyerg and @weicaiyang could help out here.

@vogelpi
the only file causing problem is the aes_model_dpi.c
but from reading #953
I realize I didn't solve the issue I just remove the file from the compile list..
and as I didn't call any of the functions in side yet I did not any issues.
so the problem seem to be a compile issue.  and not a file_type issue...
@weicaiyang  or @sriyerg
can you try to compile the aes module on my aes_dev using VCS or Xcelium

@rasmus-madsen
Looks like aes_model_dpi isn't yet included in aes TB. I added it as a depend lib in aes_env.core.
Then, I saw below error from Xcelium.
/edascratch/weicai-opentitan/ot/aes/default/build/lowrisc_dv_aes_sim_0.1/sim-vcs/../../../../../../../../usr/local/google/home/weicai/ot/spi/hw/ip/aes/dv/aes_model_dpi/aes_model_dpi.c:7:10: fatal error: 'cstring' file not found
#include <cstring>
         ^~~~~~~~~
1 error generated.
make[1]: *** [/edascratch/weicai-opentitan/ot//aes/default/build/lowrisc_dv_aes_sim_0.1/sim-vcs/xcelium.d/run.lnx8664.18.09.d/xmsc_run/Makefile.xmsc:179: /edascratch/weicai-opentitan/ot//aes/default/build/lowrisc_dv_aes_sim_0.1/sim-vcs/xcelium.d/run.lnx8664.18.09.d/xmsc_run/xmsc_obj/aes_model_dpi_0.o] Error 1
make[1]: Leaving directory '/edascratch/weicai-opentitan/ot/aes/default/build/lowrisc_dv_aes_sim_0.1/sim-vcs'
xmsc_run: *E,TBBLDF: Failed to build test library
          /edascratch/weicai-opentitan/ot//aes/default/build/lowrisc_dv_aes_sim_0.1/sim-vcs/xcelium.d/run.lnx8664.18.09.d/librun.so

xrun: *E,CCERR: Error during cc compilation (status 1), exiting.
make: *** [/usr/local/google/home/weicai/ot/spi/hw/dv/tools/rules.mk:32: compile] Error 1

And following error from VCS.
aes_model_dpi.c:9:10: fatal error: aes.h: No such file or directory
 #include "aes.h"
          ^~~~~~~
compilation terminated.
make[2]: *** [filelist:25: aes_model_dpi.d] Error 1
make[1]: *** [Makefile:104: product_clean_order] Error 2
make[1]: Leaving directory '/edascratch/weicai-opentitan/ot/aes/default/simv.csrc'

Is this the issue you found?

@weicaiyang
its almost the same issue, VCS gives the same error, for xcelium I an error inside the cstring.c file.
I wonder why I have a cstring file and you guys don't - I didn't download it. but since our tools are shared between different groups somebody might have added it.
@pirming any suggestion why including cstring is causing issues?
is this a special package that we need to download?

@weicaiyang
its almost the same issue, VCS gives the same error, for xcelium I an error inside the cstring.c file.
I wonder why I have a cstring file and you guys don't - I didn't download it. but since our tools are shared between different groups somebody might have added it.
@pirming any suggestion why including cstring is causing issues?
is this a special package that we need to download?

I did some experiment with below changes. Then xcelium is passing while VCS has errors crypto.c:(.text+0x23): undefined reference to EVP_CIPHER_CTX_new

Comment out #include <cstring>, not sure if we need cstring?
move files from aes/model/ to aes/dv/aes_model_dpi to solve the issue - missing "aes.h". Seems like *.h file need to be same directory of the file that includes it.

@weicai
ohh thank you for taking a stab at this.
@vogelpi it kinda makes sense to move the aes/model to dv anyway right?
would it be ok to just move all the aes files to aes/dv/aes_model_dpi/ ?

Thanks @weicaiyang for your support!
Regarding the use of <cstring>: We need this for memset(), memcpy() etc. but I accidentally included the C++ variant instead of <string.h>. I am sorry, this is my fault. I will create a patch and PR.
Regarding moving the model files from aes/model/ to aes/dv/aes_model_dpi: This is not the right thing to do. The model is independent from the DPI model (I remember discussing this before). The problem we are facing looks like a wrong setup of the .core files. I have been using the DPI calls and the model with this directory structure and Verilator for months now. I am now looking into Rasmus' .core files and will report back.

Alrighty, I think I found the issue. VCS cannot set up the include paths for the C compilation correctly. When building the simulation environment, the missing sources end up in the wrong folder (together with the other SystemVerilog sources) as they are declared as systemVerilogSource.
To fix the problem: Inside aes/dv/aes_model_dpi/aes_model_dpi.core the sv files only need to be specified as systemVerilogSource, c/h files need to be specified as cSource. For aes/model/aes_model.core the same holds. I tested it. The testbench is generated and VCS can compile the DPI calls as well as the C model. The simulation passes.
I created a PR into the development branch of @rasmus-madsen . PTAL and let me know if it works or not at your end. @sriyerg, @weicaiyang, this is probably also relevant for you as you had similar issues for the HMAC module.

What I forgot: the PR I made into the dev branch of Rasmus also contains the fix for the wrong header.

Alrighty, I think I found the issue. VCS cannot set up the include paths for the C compilation correctly. When building the simulation environment, the missing sources end up in the wrong folder (together with the other SystemVerilog sources) as they are declared as systemVerilogSource.
To fix the problem: Inside aes/dv/aes_model_dpi/aes_model_dpi.core the sv files only need to be specified as systemVerilogSource, c/h files need to be specified as cSource. For aes/model/aes_model.core the same holds. I tested it. The testbench is generated and VCS can compile the DPI calls as well as the C model. The simulation passes.
I created a PR into the development branch of @rasmus-madsen . PTAL and let me know if it works or not at your end. @sriyerg, @weicaiyang, this is probably also relevant for you as you had similar issues for the HMAC module.

Thanks @vogelpi for figuring this out.

@cindychip


Copy the headers from the last request on redirect

Apparently headers does not survive a redirect in net/http (https://github.com/golang/go/issues/4800) so here's a fix for that. Probably not the most elegant way of doing it though

@gummiboll great, useful addition. Authentication header should be excluded to prevent credential leakage (at least in case the redirect points to a different domain).

I do get what you mean but as I was thinking about how I would best implement this I started thinking about it; with AllowedDomains already in effect, is this needed?
Come to think about it, this PR might override AllowedDomains. Will look into it later!

@gummiboll this redirect handler function could be a private member of the Collector, so it could have access to the AllowedDomains attribute and it could check if the redirect target is in the AllowedDomains. What do you think?

Good idea! How about this?

@gummiboll awesome! Could you please exclude Authentication header when the redirection points to a different domain?

Yes, here you go. :)


[HelpDot] Add tabs for Mobile/Desktop

Details

Please review this after https://github.com/Expensify/App/pull/35329 is merged.
This PR implements platform switcher tabs between Mobile and Desktop.
This is achieved using jekyll plugin jekyll-tabs.
https://expensify.slack.com/archives/C02QSAC6BJ8/p1706560215383069
Fixed Issues

$ https://github.com/Expensify/App/issues/34462
PROPOSAL: N.A.
Tests

npm run createDocsRoutes && bundle exec jekyll serve --livereload --safe
Go to expensify-classic > getting-started > Using-The-App
Verify that you see switcher iOS and Android. And instructions below it.
For iOS, verify that the instructions mention App store.
Click Android
Verify that the instructions change to mention Play store.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
iOS selected

Android selected

@c3024 please approve the PR to assign internal 🙇

Deploy workflow is expected to fail on forks

I know we use sentence case, but since the button labels are basically product titles, I think it would be Expensify Classic and New Expensify

@shawnborton nice catch
In this PR, let's focus on Mobile/Desktop selector. i.e. The inline selectors inside the article.
The global selector (Expensify Classic / New Expensify) is handled in a separate PR https://github.com/Expensify/App/pull/35329

@shawnborton - yeah, good callout. Also! We use sentence case except if the title is only two words. Then, we should always capitalize both words :)

closing this PR because of design change https://expensify.slack.com/archives/C02QSAC6BJ8/p1706657162425239?thread_ts=1706560215.383069&cid=C02QSAC6BJ8


Steam API DLL

Finished cracking the game!
[ ! ] No Steam API DLL was found in the game!
Press enter to exit
uhh help i don't exactly know how to crack games this is my first so what can i do to make it find the Steam API DLL ?

What game is it? Maybe it just doesn't have a steam api DLL.
You might also have selected the wrong game folder.

i tried to crack one of the games that i then buyed i wanted to support the creator so i rather choose to buy it :) srr for the another issue if i will find something i will say

i then decided that i buy the game i wanted to support the creator :)
if i will find some error while cracking some kind of game i will report it to you

Mafia III: Definitive Edition

I'll check later, I currently can't, sorry

its okay a btw the thing is the dll cannot be found on every game i try to crack i know that i have to use the underground steam forum for the files or something like that but what if the game i am looking for isnt there then what

Typical antivirus delet

Finished cracking the game! [ ! ] No Steam API DLL was found in the game! Press enter to exit
uhh help i don't exactly know how to crack games this is my first so what can i do to make it find the Steam API DLL ?

I had the same problem with anti-virus program false-positive and deleting it. Good luck!

Might also be that @AnTh0ny138 didn't correctly set-up the games path and/or didn't point to the right game folder
You can check other GitHub issues where I've talked about this :)
I'll try with Mafia III but I'm really lazy right now

Ok Thanks.


Bump npm package named @angular/cli from Version v1.0.0 to v4.0.0

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [X ] feature request

Versions.
@angular/cli: 1.0.0
node: 7.7.4
os: win32 x64
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0
Windows 10
Suggestion.
Change the version of the npm package named @angular/cli from version 1.0.0 to version 4.0.0 so that all Angular things are version 4.0.0

We aim to roughly keep pace with Angular release cadence, but not necessarily version number.

I was of the understanding that one of the goals behind the move from Angular 2.0.0 to version 4.0.0 was to standardize the version numbers of the different Angular packages starting with version 4.0.0
Why would the @angular/cli package be any different?  Might not be a big deal to some, but it sure seems like a good opportunity to keep the Angular CLI Package version in line with other Angular Packages.
@angular/cli: 1.0.0
@angular/common: 4.0.0
@angular/compiler: 4.0.0
@angular/core: 4.0.0
@angular/forms: 4.0.0
@angular/http: 4.0.0
@angular/platform-browser: 4.0.0
@angular/platform-browser-dynamic: 4.0.0
@angular/router: 4.0.0
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.0

That's a fair point tbh... the CLI does not 'live' on the same repo as the rest of the @angular/* packages, and isn't released at the same time so that's why version numbers differ.
But a user looking at their package.json just sees a bunch of @angular/* packages and no information that they 'live' in different places. And the CLI is the odd one out.

This issue is open for discussion, but we're not going to do anything now really. The CLI is at 1.x and will be for the foreseeable future.

Hi @brookhutchinson,
We had a lot of discussions regarding this internally at Google. Basically it comes down to a few points:

You shouldn't think about version numbers. Angular 4 is just Angular.
Angular CLI is compatible with every version of Angular right now, so the numbering scheme doesn't really work.
We're following semantic versioning, so your package.json should be saying angular-cli: ^1.0.0 and you won't have to change it before version 2 is out.
It's managed in a different repository than Angular, so it will always be different minor and patches, and on a different schedule.
That last point is worth re-mentioning. We don't want to commit to the same schedule as Angular just yet, and so even our majors might not be synchronized. So in 6 months when Angular is releasing version 5, the CLI might be at 1.2 or 1.6, but not ready for version 2. So this versioning would be meaningless.

We may rethink about this but not for a long time, and definitely not before the next major version of the CLI. But because of these reasons, I'm going to close this issue, sorry.
Cheers!


(doc) added notice about the usage of labels

This PR tries to document how the labels are used for the repository to reflect the current status of a request.
Finally got around to try documenting the usage
/cc @ferventcoder

19970e6


Placing vendored dependency in subprefix

It may be a good thing to place the vendored deps in a subdirectory that is not the general prefix to avoid overriding existing installed files.

I wonder if this is something that scikit-build can do.

According to this answer, it is not feasible for now.
The solution is to make a full static build of xeus-python to avoid potential overwrite of already installed dependencies.


rocksdb_replicator: post max_seq_no_acked_ regardless of replication mode

We now support dynamically modifying the replication mode for a db, and the way we use the max_seq_no_acked_ may run into edge case issues:
Background on how this max_seq_no_acked_ is used:
Currently we only updates max_seq_no_acked_ in two places:

replication mode = 1 or 2: when the leader receives a replication request from a follower with the latest sequence number it committed
replication mode = 1: when the leader sent an rocskdb update with a specific sequence  out to the network (without waiting for follower ack)

On the Write Path, if replication_mode is 1 or 2, the leader which received the write will wait for max_seq_no_acked_ to catch up to it's own local latest sequence, before returning the response to the client. It doesn't wait if replication_mode is 0.
Possible issues
As we can see, max_seq_no_acked_ is not updated when replication_mode == 0. This mean the following can happen:

db is operating with replication_mode == 2
a write request arrives and wait for max_seq_no_acked_ to catch up
db switched to replication_mode == 0, and as a result, max_seq_no_acked_ is not updated even when followers ACKed the leader that they have received the write.
the write request times out after 5s , during which all other requests may be blocked and may cause cascading failures/timeouts.

Proposed solution
This PR proposes a simple fix: always update max_seq_no_acked_ regardless of the replication mode, i.e. even when replication_mode == 0, max_seq_no_acked_ will have the largest sequence number ACKed by followers. This fixes the above race condition when switching from replication mode 2 to 0.  There is no impact to stable states:

in replication_mode 1 & 2, there is no logic change with this PR
in replication_mode 0, only change is we update the max_seq_no_acked_ upon follower ACK, but since we don't wait for max_seq_no_acked_ anyway in the Write path, it's a no-op.

How do we inform the service that "db switched to replication_mode == 0,"?

if we inform all service at the same time, then, another option is, we force all service to drop all the wait threads since we are going to switch to "repliation_mode 0" anyway, we won't care of dropping those waits.
but, if rollout this "db switched to replication_mode == 0,", host by host, ie. deploy a cluster, then, we will run into the case you described above: dbA is still running replication_mode(1/2) and wait for max_seq_no_acked_'s updating, which dbB is newly running replication_mode(0), which does not send back update to dbA. Then, dbA will have to wait till timeout and block others.

How do we inform the service that "db switched to replication_mode == 0,"?

if we inform all service at the same time, then, another option is, we force all service to drop all the wait threads since we are going to switch to "repliation_mode 0" anyway, we won't care of dropping those waits.
but, if rollout this "db switched to replication_mode == 0,", host by host, ie. deploy a cluster, then, we will run into the case you described above: dbA is still running replication_mode(1/2) and wait for max_seq_no_acked_'s updating, which dbB is newly running replication_mode(0), which does not send back update to dbA. Then, dbA will have to wait till timeout and block others.

Configs are dynamically updated via DBConfigManager https://github.com/pinterest/rocksplicator/blob/master/common/dbconfig.h#L50, and there is no way we'll inform all service instances all at the same time (in our case it'll be via managed data).
The main issue here is that we hav two paths:

the Write path where a write will wait for max_seq_no_acked_ to be updated by follower replication request
the handleReplicateRequest path which updates max_seq_no_acked_.
During the wait in the Write path, there could be service config change that switched replication mode from 2 to 0, and hence max_seq_no_acked_ won't be updated.


RFC: Best practices documentation

Can be interesting to add a best practices documentation page, on the top of the documentation, because there's a lot of ways to do things and currently it's not enough clear.
what about start by adding some anchors like:
Understanding costs:

Cost Analysis

Maybe add which type of index to use together with some use cases examples

Does this page not cover some of your questions?
https://gpt-index.readthedocs.io/en/latest/use_cases/queries.html

Does this page not cover some of your questions?
https://gpt-index.readthedocs.io/en/latest/use_cases/queries.html

It helps with which queries to use, but I think best practices would be a combination of what to use + how to do queries or store indexes in a more performative way

Does this page not cover some of your questions?
https://gpt-index.readthedocs.io/en/latest/use_cases/queries.html

It helps with which queries to use, but I think best practices would be a combination of what to use + how to do queries or store indexes in a more performative way

Yea this is a good suggestion. We are going to do some refactoring on our docs. Stay tuned.


Write out BAI when saving sorted BAMs to disk

Closing as WontFix, disq provides this functionality if necessary, could be added to https://github.com/heuermh/disq-adam


[BUG] Cannot read properties of undefined (reading 'className')

What happened?
when clicking on the Transactions section.
Version
1.5
What platform are you using?
Linux
What ui mode are you using?
GUI
Relevant log output or stacktrace
Cannot read properties of undefined (reading 'className')

URL
#/dashboard/offers/view

Stacktrace
at webpack://@chia/gui/node_modules/@mui/material/Tooltip/Tooltip.js:507:52 popperRef.current.update
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:157:136 Ch
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:176:259 useOpaqueIdentifier
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:271:399 d=b.pendingProps;e=b.memoizedState;e=null!==e?e.element:null;yg(a,b);Cg(b,d,null,c);d=b.memoizedState.element;if(d===e)sh(),b=hi(a,b,c);else{e=b.stateNode;if(f=e.hydrate)kh=rf(b.stateNode.containerInfo.firstChild),jh=b,f=lh=!0;if
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:250:346 Pj
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:250:277 Pj
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:250:137 Pj
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:243:162 Lj
at webpack://@chia/gui/node_modules/react-dom/cjs/react-dom.production.min.js:123:114 jg
at webpack://@chia/gui/node_modules/scheduler/cjs/scheduler.production.min.js:18:342 unstable_next

Hi @rappdigit . Can you try latest version from source code? It was fixed via https://github.com/Chia-Network/chia-blockchain-gui/pull/855


test_join_big[1] deadlocks upon spot instance shutdown

test_join_big[1] deadlocks very frequently.
I've now run it 40+ times, all on 2023.12.0, and and I've noticed a very high time correlation between deadlocks - e.g. either a whole suite of A/B tests is almost completely green, or it's almost completely red.
Example failed run:

https://github.com/coiled/benchmarks/actions/runs/7200113744/job/19613325532
s3://coiled-runtime-ci/test-scratch/cluster_dumps/join-94f47b9c/benchmarks.test_join.py.test_join_big[1].msgpack.gz
https://cloud.coiled.io/clusters/333952/information?account=dask-benchmarks
https://benchmarks-grafana.oss.coiledhq.com/d/GvbFsqKVk/coiled-cluster-metrics-basic?var-datasource=Benchmarks&var-account=dask-benchmarks&var-cluster=join-94f47b9c&var-cluster-id=333952&from=1702497314000&to=1702499727000&orgId=1

In the logs I read:
2023-12-13 19:59:36.6970
scheduler
distributed.shuffle._scheduler_plugin - WARNING - Shuffle 7903ec3183de28c82322c176e8e51223 restarted due to stimulus 'worker-close-gracefully-1702497576.496643

2023-12-13 19:59:36.7360
scheduler
distributed.core - ERROR - Exception while handling op shuffle_get
Traceback (most recent call last):
  File "/opt/coiled/env/lib/python3.9/site-packages/distributed/core.py", line 967, in _handle_comm
    result = handler(**msg)
  File "/opt/coiled/env/lib/python3.9/site-packages/distributed/shuffle/_scheduler_plugin.py", line 126, in get
    state = self.active_shuffles[id]
KeyError: '7903ec3183de28c82322c176e8e51223'

CC @fjetter @hendrikmakait

@hendrikmakait do you have capacity to look into this?

I'll take a quick look into this. Depending on how far I get, I might have to prioritize this and other ongoing efforts.

https://github.com/dask/distributed/issues/8411

Closed as completed by https://github.com/dask/distributed/pull/8415


⚠ SceneTime has degraded performance

In 83032c4, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2941 ms

Resolved: SceneTime performance has improved in 051609d.


Jose/django/stocks job

adding init files for the management commands in stocks
Adding a command to import metrics for stocks periodically
Adding cronjobs to allow it to run hourly
fixing linting issues
removing sample job file
fixing the symbol_count filter
making the cronjob entry output data to the docker log file
making the supervisord cronjob wait for everything to start up first
exporting env variables to /etc/environment
removing the extra unneeded query
This requires standup to be ran to update the backend container

pylint errors are from the rules app that isn't part of this commit


Complete Assignment #5

Placeholder to branch-off, work on and PR Assignment #5

Assignment 5 turned in


v0.9.2_09: Bubble is overlapping with data warning text

SEVERITY: Minor
MODULE:  Bubble map  Chart
Platform: iPhone-4G(iOS 7.1.2)/ Safari
RELEASE:  v0.9.2
STEPS TO REPRODUCE:

Navigate URL: http://static.gapminderdev.org/vizabi/release/v0.9.2/preview/bubblemap.html
Bubble map chart page will be loaded
Tap “Size” and drag both the pointers to the maximum side to increase the bubble size and tap OK
Note that bubble is overlapping with data warning text after increasing the bubble size

ACTUAL RESULTS:
Bubble is overlapping with data warning text after increasing the bubble size
EXPECTED RESULTS:
Bubble should not overlap with any text on the chart after increasing the bubble size
SCREENSHOT:

it's a very extreme case, don't worry =)


CVE-2021-41190: OCI Manifest Type Confusion Issue (Low Severity)

NOTE: This is based solely on a Github dependabot alert, so it's possible there is a false positive here.
Impact
Systems that rely on digest equivalence for image attestations may be vulnerable to type confusion. The actual impact within apko isn't known, but it is quite probable that it is not actually vulnerable at all.
Patches
Since this was a specification-level bug rather than implementation-specific, the patch depends on the library used.  Affected libraries include:

https://github.com/distribution/distribution
https://github.com/aws/aws-sdk-go
https://github.com/opencontainers/image-spec

To see the specific resolution recommended for melange, see: https://github.com/chainguard-dev/apko/security/dependabot
NOTE: You may need admin rights for the repository to see the details.
Background
This is a low-severity CVE, but given that it is related to image metadata, we should aim to do an above-average job with it.
References

https://github.com/advisories/GHSA-qq97-vm5h-rrhg
https://www.cve.org/CVERecord?id=CVE-2021-41190

Whoops - looking at the dependabot data, it appears this CVE has long since been addressed. My apologies for opening a false-positive issue.

Yeah the only reason it is flagged now is because of GGCR.


[sql-cli] Connection configuration having extra field causing tests to fail on Airflow 2.2.5

Upon adding the bigquery example connection in the configuration files, the extra -> project field is causing tests
to fail on Airflow 2.2.5. Upon removing this field the tests run fine.
We need to check if this happens for all the connections having extra field or it happens only for bigquery type connection.

Check whether the commented out config in dev configuration.yaml also needs to be updated .


is it possible to export settings for CubicBezier plugin ?

Is there a way to store the particular cubic bezier so it works with import/export settings functionality ?

I would love to know this as well!

Same here. It would be great if these parameters can be included in an import/export, without having to add hidden fields and extra code to manage this.


Hero gates and spellbooks dynamically filled

Related to https://github.com/dkfans/keeperfx/pull/3413

fixes #12


Melanie created a new file

these are my detailed comments.  I've created a branch, a file, made a commit, and opened a pull request.

looks good


Missing pagination

Hey!
I think we don't have a Pagination bar available on the tail blocks.
Can someone add this to the codebase? Thanks!

    First
    Previous
    55
    Next
    Last

//Sivakumar

I added something like this, i hope this will helpful.


Event template updates

Update a few pieces of key information from the template JupyterBook:

point to geo-smart GH urls instead of hackweeks-as-a-service onces
note that applications are open on splash page and in book
remove logistics info from SnowEx example

I made some changes that overlapped with yours - could you please take a look at the merge conflicts?

@NCristea Merge conflicts are resolved - please let me know if there are any other changes you'd like!


Support host access for vxlan routing mode

Signed-off-by: Joji Mekkatt<EMAIL_ADDRESS>This PR adds support for host access for vxlan networks when fwd-mode is configured as routing. Host access relies on an "infra" network being created with name contivh1 and a default gateway specified.
E.g. netctl net create -n infra -s <IP_ADDRESS>/24 -g <IP_ADDRESS> contivh1
This will make all vxlan networks accessible locally from the host.
In addition a host NAT interface is implicitly created which will allow NAT access to outside networks masqueraded behind the host interface. This also enables service endpoints external to the cluster to be access via the service proxy.
This PR eliminates the need for the hostBridge.

@DivyaVavili @rchirakk PTAL

@jojimt could you open an issue for installer work with specifics?

Updated https://github.com/contiv/install/issues/82

@jojimt where does the IP address range for the infra network come from?

It is user-configurable. For installer, we can pick something like <IP_ADDRESS>/16 perhaps as default. But, there should be a way for the user to over-ride.


Document and exemplify chare class inheritance

Original issue: https://charm.cs.illinois.edu/redmine/issues/1196

There's nothing in the manual or examples about chare classes having parent class relationships from which the child can inherit. The only thing we have is tests/charm++/megatest/inherit*, which is really nasty to read and understand.

Original author: Vipul Harsh
Original date: 2017-04-13 18:45:39

I see that it exists but is commented out. Phil, do you have any idea about this?

Original date: 2017-04-14 15:57:39

Is that documentation sufficient?
~~https://charm.cs.illinois.edu/gerrit/#/c/2391/~~ https://github.com/UIUC-PPL/charm/commit/2381050a2c575f4bb7a4fe66dd400b4f6ceacb65


Look into multi instance installations

Driving a Dataverse multi-instance installation has some edges and needs to be examined carefully. Obviously, scaling with Kubernetes is super-easy.
http://guides.dataverse.org/en/latest/installation/advanced.html#id1

I would suggest watching https://github.com/BU-NU-CLOUD-SP18/Dataverse-Scaling#our-project-video which I mentioned in a comment at https://github.com/IQSS/dataverse/issues/4040#issuecomment-386061972
This was the final video students at BU made after their efforts to scale Dataverse across multiple Glassfish and PostgreSQL servers.
We held weekly meetings during the class and recorded them and posted notes, if those are of interest as well.

While looking into salvation for #65 I thought about how to sync the files from the docroot to other pods in case of a replication with a StatefulSet.
It looks like the easiest way to go is via a ReadWriteMany volume, backed by an NFS server (or similar). Ganesha NFSv4 seems to be worth a try, as it can be easily containerized in the K8s cluster. Running a kernel NFS server needs some hacking and priviliges.

@poikilotherm you should do whatever hacking you need to do to stay unblocked but I'm wondering if upstream Dataverse should evolve or change in some way to make it easier to run multiple (Glassfish) web servers. Should the logos used in the header of dataverses be stored in the the database, for example. (Heads up that logos in the footer are now supported as well, thanks to https://github.com/IQSS/dataverse/pull/6219 .) I believe Harvard Dataverse uses some rsync scripts to keep the logos in sync across two web servers but I'm not sure how well that scales. What I'm trying to say is that I'm definitely open to ideas. 😄

Please see also https://github.com/IQSS/dataverse/issues/6491


Drop requirements for pyproj and xgcm

I should put the functions that need xgcm and pyproj into a new module, so `preprocessing can be imported with minimal dependencies.

preprocessing now only requires pandas, numpy and xarray. Closing


[#noissue] Do not skip test-jar creation

Codecov Report

Merging #4653 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4653      +/-   ##
==========================================
+ Coverage   40.35%   40.37%   +0.01%
==========================================
  Files        2512     2512
  Lines       76555    76555
  Branches    10424    10424
==========================================
+ Hits        30897    30906       +9
+ Misses      42822    42815       -7
+ Partials     2836     2834       -2

Impacted Files
Coverage Δ

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.86% <0%> (+1.04%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.78% <0%> (+3.03%)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
66.66% <0%> (+11.11%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
75% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b7544...123d2bf. Read the comment docs.


ngOnDestroy crashes SSR apps

Describe the bug
ngOnDestroy kills SSR due to unchecked usage of document
To Reproduce
destroy an instance of OAuthService on a SSR-app
Expected behavior
Server does not crash
const silentRefreshFrame = document.getElementById(this.silentRefreshIFrameName);

document must be replaced by DOCUMENT of @angular/common

On one hand I guess the change wouldn't hurt, but there are two things that would make me think twice about this change.
First, if you we'd do this, I suppose all instances of document in the service should use the injected one. So that would be a huge refactor.
Second, I'm not sure how useful it would be to have this service "not crash" with Server Side Rendering? The reason is that I'm not sure what meaningful thing the app could do auth-wise when doing server side rendering? Although I haven't done much SSR myself yet, I'd always expected you'd need to provide a stub-implementation for the OAuthService type as a whole (or more likely: your wrapper service) for meaningful and reliable Server Side functionality?
Those two together makes me wonder if it's worth the change?

hey jeroen, thanks for replying.
The problem is that at some point the OAuthModule (which includes the OAuthService) will be destroyed and thus can't evade the document call.
All other functions which are using a document reference have to be called manually (or a parent of these) and thus can be avoided if we run the app on a server platform.
Not certainly sure how the second part could work. However since there are SSR examples in the repo documentation (https://github.com/manfredsteyer/angular-oauth2-oidc/blob/master/docs-src/server-side-rendering.md) I feel like there is a SSR usage for the library.
Best,
Daniel

will be destroyed and thus can't evade the document call.

An instance would only be destroyed if it was ever onInitiated, I thought? I had always assumed it was relatively easy to inject other types when rendering on the server, at least for crucial services.

All other functions which are using a document reference have to be called manually (or a parent of these) and thus can be avoided if we run the app on a server platform.

Hmm, on one hand you're right. On the other hand, to my personal preference, lack of consistency in a class on how a dependency is used will make future changes much harder.

since there are SSR examples in the repo documentation

Interesting! I didn't know. The links and the blogposts there are 2 years old though, so I'd take them with a pinch of salt.

hey jeroen,

An instance would only be destroyed if it was ever onInitiated, I thought? I had always assumed it was relatively easy to inject other types when rendering on the server, at least for crucial services.
to be honest I haven't heard or seen any examples of a mock-type injection in a server-side app (besides of injection tokens for browser-objects such as document). happy to read up on it if you can provide me a reference or two.

Hmm, on one hand you're right. On the other hand, to my personal preference, lack of consistency in a class on how a dependency is used will make future changes much harder.
totally agree on this one. it should not be a problem to replace all document references with the injected this.document. will do if we decide to proceed further with the PR.

just want to mention that this part has only been broken only 7 days ago due to merging this PR https://github.com/manfredsteyer/angular-oauth2-oidc/pull/666 . I'd happily use v8, but since we are using Angular 9 this seems not to be an option.

I'm also having this issue not directly with SSR but with an app shell which uses a single SSR call on build time to render the shell route. It worked before but now it fails cause of this document call.
I'm now trying to prevent OAuthService from loading at all by splitting server modules and client module, but it would be great if this can be addressed.


Need new projects!

Seeing how fast the industry is growing we can have a new set of project ideas in this repo.
@NirantK

PRs are most welcome!


找不到字体

使用的是"pdfjs-dist": "^2.0.943"
使用如下写法引入字体文件夹：
this.loadingTask = pdfjsLib.getDocument({
    url: data.url,
    cMapUrl: '../../node_modules/pdfjs-dist/cmaps/',
    cMapPacked: true
});

会报这样的错：
Warning: Failed to load font "g_d1_f3": SyntaxError: Invalid font data in ArrayBuffer.

Closing since we can only help out in English and with an example PDF file as asked for in the issue template.

declare const PDFJS: any;
PDFJS.cMapUrl =<EMAIL_ADDRESS>// include "/"
PDFJS.cMapPacked = true;


ViT Support

Hello, am I right that currently TE does not support ViT? Specifically, I am looking for ViT that uses 2D rope, e.g. Pixtral's ViT.
I also checked Nemo codebase, but it seems that they are also building their own impl for ViT instead of relying on TE.
Nemo defines ParallelVisionTransformer. This class init a series of ParallelVisionTransformerLayer layers, each a subclass of ParallelVisionTransformerLayer_, which in turn a subclass of ParallelTransformerLayer_. This class defines all operations in Nemo's impl.
Thanks.

Here is an example modifying ViT to support TE's TransformerLayer: https://towardsdatascience.com/accelerating-pytorch-training-workloads-with-fp8-5a5123aec7d7


How upgrade my project from SignalR-Server to new SignalR package

I have use the package SignalR-Server and I have tried to upgrade my code to new version of SignalR and I get some error because is missing following:
I have a combination the SignalR hub with Web Api:
public abstract class ApiHubController<T> : Controller
        where T : Hub
    {
        private readonly IHubContext _hub;
        public IHubConnectionContext<dynamic> Clients { get; private set; }
        public IGroupManager Groups { get; private set; }
        protected ApiHubController(IConnectionManager signalRConnectionManager)
        {
            var _hub = signalRConnectionManager.GetHubContext<T>();
            Clients = _hub.Clients;
            Groups = _hub.Groups;
        }
    }

There is missing the IConnectionManager.
In my Web Api controller I use the property Clients from ApiHubController like this:
Clients.All.MethodName("test");
And finally I can't create the custom authorize attribute like this:
public class AuthorizeHub : AuthorizeAttribute
	{
		public override bool AuthorizeHubConnection(HubDescriptor hubDescriptor, HttpRequest request)
		{
			var token = request.Query["token"];

			if (token.Count == 0) return false;

			var accessToken = token[0];

			//Validate token

			return true;
		}

		public override bool AuthorizeHubMethodInvocation(IHubIncomingInvokerContext hubIncomingInvokerContext, bool appliesToMethod)
		{
			var args = hubIncomingInvokerContext.Args.ToList();

			if (args.Count == 0) return false;

			var accessToken = args[0];

			//Validate token

			return true;
		}
	}

How can I fix my code?
Thanks for any suggestions.

There's no longer a custom authorize attribute, SignalR uses the ASP.NET Core auth system and attribute doesn't work quite as yet.

OK, I see but how can I catch action like in this method: AuthorizeHubConnection?

OK, I see but how can I catch action like in this method: AuthorizeHubConnection?

https://docs.microsoft.com/en-us/aspnet/core/security/authorization/policies


Fix opt rules for generic queries. (KIKIMR-16294)

Following tests work fine locally:
TPersQueueTest.DirectReadPreCached
BasicUsage.MaxByteSizeEqualZero
LocalPartition.Restarts
Probably tests are flacky, as there was not changes to anything pq-related, and no changes for data queries.


Bug when compiling the game

Describe your bug here.
When trying to compile the game this shows up:
Warning: Could not find Visual Studio 2017 VsDevCmd
Missing HXCPP_VARS
Error: Could not automatically setup MSVC
Command Prompt/Terminal logs (if existing)
Warning: Could not find Visual Studio 2017 VsDevCmd
Missing HXCPP_VARS
Error: Could not automatically setup MSVC

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No i changed nothing

you need to install Visual Studio Community 2019

What do i do after that?

Install the components
MSVC v142 - VS 2019 C++ x64/x86 build tools
Windows SDK (10.0.17763.0)

Oh ok
Then thats it?

yes

yes

oh ok thanks


Added support for content components

Motivation
The goal is to add support for content components (non-reusable content).
From the SDKs point of view, the components behave the same as regular content items. However, they are supported only in the rich-text elements.
<object type="application/kenticocloud" data-type="component" data-codename="n55afed3a_b4a3_018a_8744_3b06301b1f88"></object>
The only difference is that the value of the data-type attribute is not item but component. (There is no new endpoint for Content components in the Delivery API). The components are being sent as a part of the modular content (linked items) dictionary in the same format as the regular modular content.
Sample implementation: https://github.com/Kentico/delivery-sdk-net/pull/131/files
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docu has been updated (if applicable)
[x] Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

How to test
Make sure rich-text elements containing components get resolved in the same manner as standard content items.
Testing KC project: https://qa-deliver.global.ssl.fastly.net/ab44e0cc-9302-00c3-14ce-1362a118ad2f/items
Internal reference: DC-544

Will be released in 5.0.0

Please remove the functionality. It's not needed anymore.


slickGoTo documentation badly worded on main site

In the github README it's clear that the second argument is dontAnimate: bool but on the main site it reads as being shouldAnimate (the inverse).
This tripped me up for a while and I assumed that second argument was broken until I saw the README here by chance.

I also faced this issue! I ended up delving into the js file and figuring it out

This gave me a headache for a moment, too. Should be an easy change on the documentation.

:+1:  this is just a doc amend! Please fast track it :)

Just pushed this, sorry guys

:fireworks:


** exception error: undefined function persistent_term:get/2

Using the latest pull of pgo and pg_types, there seems to be an error related to the pg_types dependency. Running something simple like pgo:query("select 1").   throws an odd error -
2> pgo:query("select 1").
** exception error: undefined function persistent_term:get/2
     in function  pg_types:lookup_type_info/2 (src/pg_types.erl, line 85)
     in call from pgo_protocol:decode_row_description_message0/5 (src/pgo_protocol.erl, line 435)
     in call from pgo_protocol:decode_row_description_message/3 (src/pgo_protocol.erl, line 418)
     in call from pgo_handler:receive_message/4 (src/pgo_handler.erl, line 462)
     in call from pgo_handler:flush_until_ready_for_query/2 (src/pgo_handler.erl, line 437)
     in call from pgo_handler:extended_query/6 (src/pgo_handler.erl, line 297)
     in call from pgo_handler:extended_query/5 (src/pgo_handler.erl, line 73)

Admittedly, this should probably be reported at pg_types, but I'm facing it wrt pgo...

Looking a bit closely, it seems, the line #85 calls persistent_term:get({?MODULE, Pool, Oid}, undefined) which is problematic because persistent_term module only has get/0 and get/1 functions. But the function call in #85 has 2 args.

I can confirm that that is indeed the trouble.  Just put in a PR in the pg_types git. I'm closing this issue, please do the needful. Cheers.


How do I tag with multiple word tags

I looked at this issue https://github.com/torchbox/wagtail/issues/916, but I can't find a solution to my problem.
I want to do multiple word tags: Like Fred Flinstone, Caveman
However I get Fred Flinstone Caveman. The moment I type space a tag is identified.
If I use double quotes, I get double quotes appearing in the tag.

I have understood that in the last django-taggit version had fixed this problem, and is possible use multiple words in a tag, but, i don't know is real.

I am upgraded to the latest, and it didn't make a difference, the change log also made no mention of any such improvement

@lee-kagiso Using double quotes (") to surround your multiword tag should work just fine. It only shows those quotes in the WT admin interface, they are not saved in the DB nor will they be shown when you render them.

@Ricemast thanks!

But, i think that don't should be neccessary put the "" for put a multiword tag.


feat: update dev-tools 1.14 to ruby v3

Thanks @apeabody! Any breaking changes we should be aware of with 3.0?

I believe Ruby is primarily used for legacy Kitchen tests.  We already upgraded to kitchen-terraform v6 in dev-tools 1.12 which added support for Ruby v3.
That said, this bumps the dev-tools minor release, so any impact would be limited to repos pinned to only the major version, which could always be switch to tracking the minor if needed.  Long term this is to unblock updating the Alpine release, but I left that for a future minor version to limit the changes at one time.


FlatList overflow breaks when using a RefreshControl on Android

Description
Using a FlatList with overflow: 'visible' works well on Android and iOS, but as soon as a RefreshControl is added, the overflow is hidden on Android only.
Version
0.69.1
Output of npx react-native info
System:
OS: macOS 12.4
CPU: (8) x64 Apple M1
Memory: 18.06 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 12.18.3 - ~/.nvm/versions/node/v12.18.3/bin/node
Yarn: Not Found
npm: 8.9.0 - ~/.nvm/versions/node/v12.18.3/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.2 - /Users/alex/.rvm/gems/ruby-2.7.4/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8309675
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.15 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.1 => 0.69.1
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

Create a FlatList with overflow visible and a RefreshControl, encased in a view with some padding at the bottom.
Observe that on iOS the FlatList items overflow into the padding on the bottom, but on Android the FlatList is bounded by the padding.
Remove the RefreshControl and observe that the Android FlatList correctly overflows into the padding

Snack, code example, screenshot, or link to a repository
import React from 'react';
import { StyleSheet, View } from 'react-native';
import { NewsCard } from 'components/news-card/NewsCard';
import { panelStyles } from 'styles/panelStyles';

const styles = StyleSheet.create({
  newsListWrapper: {
    flex: 1,
    paddingBottom: 20,
  },
  flatList: {
    overflow: 'visible',
  },
});

const NewsList = ({
  newsItems,
  refetchNews,
  refetchingNews,
}) => (
  <View style={styles.newsListWrapper}>
    <FlatList
      style={styles.flatList}
      contentContainerStyle={panelStyles}
      data={newsItems}
      numColumns={2}
      keyExtractor={(item) => item.id}
      // with this removed, the overflow still works
      refreshControl={(
        <RefreshControl
          onRefresh={refetchNews}
          refreshing={refetchingNews}
        />
      )}
      renderItem={({ item, index }) => {
        return (
          <View>
            <NewsCard newsItem={item} />
          </View>
        );
      }}
    />
  </View>
);

Without Refresh Control:

With Refresh Control:

Even when add property onRefresh also cause this issue


minor grammar fixes

Grammar nazi

@mrThe there is nothing wrong with that.

@cebe, who saying that's anything wrong? I just trolled @hom3chuk :)

Спасибо!


"Left Align Indentation" not working

Wordpress Version: 4.7.1
PHP Version: 7.0.12
Enlighter Plugin Version: 3.3
EnlighterJS Version: 2.10.1
Theme: Minimal (with customised colours)
Language: Python

thx. could you please post a minimal example of the code you've tried to insert ?

I've tried different code snippets, the problem seems to be independent from the actual code one wishes to display. Anyway, here is a code snippet that is long enough for the problem:
import numpy as np

def feedBackward(self, outputs, labels):
    deltas = []
    e = (outputs[-1][0] - labels).transpose()
    delta = np.multiply(outputs[-1][1].transpose(), e)
    for i in range(len(self.Ws)-1, -1,-1):
        W = self.Ws[i][1:,:]
        deltas.append(delta)
        delta = np.multiply(outputs[i][1].transpose(), W * delta)
    deltas.append(delta)
    return list(reversed(deltas))

with the snippet above i cannot reproduce your issue. there is no indentation which could removed by the "Insert Dialog". the import as well as def statement are on position 0.
i believe your issue has another origin.
is the indentation/left-padding only visible in your frontend and not in the visual editor ? if so it seems to be an issue with your WordPress theme. Maybe margin/padding added to Enlighter's div or ul/li container - try to inspect the element

In the post editor everything looks fine. However, in the frontend the code isn't aligned when the line number goes from single to double digit (presumably also when it goes from double to triple digit). I've noticed the same behaviour on your homepage.

Removing the list-style with the inspect tool in Chrome removes the problem, but the line numbers aren't shown anymore. Using decimal-leading-zero inside instead of decimal inside also fixes the alignment error.

oh ok, now i undestand the issue :)
of course, it is caused by the css list styles. it will be fixed in EnlighterJS v3 but not in the current release.


Screenviewer

Screenviewer which shows screen of the pc.

has two buttons:

"Start/stop" button
"Settings" for quality with a trackbar, and option with a checkbox "Save frames/shots"

A label with the size of the frame/screenshot
A progressbar for every transferred frame.

xRAT already has a Remote Desktop, which is basically what you described.


feat: Add labels for camera selection and flash

Hi everyone,
The accessibility is really poor on the app, and we should at least add labels for the camera selection and the flash toggle:

Codecov Report

Merging #4119 (07ec07b) into develop (802acd8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4119      +/-   ##
===========================================
- Coverage    10.82%   10.82%   -0.01%
===========================================
  Files          273      273
  Lines        13539    13542       +3
===========================================
  Hits          1466     1466
- Misses       12073    12076       +3

Impacted Files
Coverage Δ

...es/smooth_app/lib/pages/scan/camera_scan_page.dart
1.72% <0.00%> (-0.10%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


takes lots of time to scan also sometimes not working

Description of the problem:
it takes too much of time to scan the bar code also sometimes it is not working.
**Which library version are you using?
-3.5.0
Which phone/tablet are you using, and which Android version does it run? (e.g. Samsung Galaxy S5,
Android 5.0)
-google glass

Google Glass is not supported, as we do not have access to the hardware. That said, pull requests with fixes are welcome.


Epic: Simultaneous multiple cable support and finer grained connectivity

Epic Description
Submariner currently assumes full mesh connectivity by default and provisions VPN connections between all participating
clusters. In addition, Submariner currently offers one of three cable drivers: VXLAN, IPSec or wireguard with limited
configuration options. Only one of these cable drivers is enabled across all the clusters in a cluster set, that is all
clusters that join a broker must use the same cable driver. The goal of this epic is to enable an extended model
that will support:

The selection of which clusters to connect and in what fashion (full mesh or connection to subset of clusters in
a ClusterSet).
The selection of one or more cable drivers in order to support different cable types between connected clusters.
For example, IPSec between public and private clouds but raw VXLAN between the clusters in the same cloud.

More details can be found here: https://github.com/submariner-io/enhancements/pull/72
Acceptance Criteria
Multiple cables can be deployed with Submariner Gateways and
Definition of Done (Checklist)

[ ] Code complete
[ ] Relevant metrics added
[ ] The acceptance criteria met
[ ] Unit/e2e test added & pass
[ ] CI jobs pass
[ ] Deployed using cloud-prepare+subctl
[ ] Deployed using ACM/OCM addon
[ ] Deploy using Helm
[ ] Deployed on supported platforms (for e.g kind, OCP on AWS, OCP on GCP)
[ ] Run subctl verify, diagnose and gather
[ ] Uninstall
[ ] Troubleshooting (gather/diagnose) added
[ ] Documentation added
[ ] Release notes added

Work Items

After reviewing the design - it was decided to pursue the original proposal https://github.com/submariner-io/enhancements/pull/4. As such this epic will be closed.


Support exporting all barplot legends, including color gradient and length legends; export collapsed clade shapes and barplots

Part of the work on #303.
Closes #421.
Required some substantial refactoring to the way gradient SVGs are stored in Empress, in order to make it easier to scale these differently within a legend.
Also as part of this PR, slightly changed the way numbers are formatted in the Tree Statistics (so now commas are used as thousands separators [at least for English locales], etc.)
TODOs:

[x] Add more vertical padding at the end of gradient and length legends (currently the text is flush with the surrounding border, which looks a bit too close for comfort)
[x] Show a warning (for both gradient and length legends [#391]) if there are missing / non-numeric values in the field. Currently this warning (which is already shown for gradient legends in the interface) is not included.
[x] Refactor legend exporting code so that there isn't a notion of "rows" any more, so each legend can arbitrarily increase its vertical space without messing up other legends (all that should be kept track of are the height and width of each legend).
[x] Unbreak tests (the colorer and legend tests, and maybe more, are extremely broken by these changes)

The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv

These changes are not very well covered by tests, but as a initial version that supports exporting I think this may be ok.
GIF showing how this looks --

That is looking super cool!

Thanks for the feedback @kwcantrell! I think all of your comments should be addressed now.
I also realized that this PR introduced a bug where gradient legends (when the color reversing was selected) weren't getting reversed -- this was due to an error in how this PR used the chroma.js .colors() method. The problem should be fixed and tested now.

thanks @fedarko and @ElDeveloper


Check and debug the impl of MolCoord.copyAtoms() and deleteAtoms()

Event firing/modify-flag update was not correctly implemented so modified in the master branch.


Preloading the heartbeat script

This is a copy of https://github.com/IMAGINARY/kiosk-browser/issues/3:

The kiosk browser now has a --preload option that allows to load (almost) arbitrary nodejs-enabled JavaScript code before a page is loaded. The idea is to use this to inject a script for sending heartbeats into arbitrary web pages.
npm run start -- -v -v -d --preload preload.js -l https://www.heise.de?HB_APP_ID=bla

Using this as preload.js
{
    // include modules
    const fs = require('fs');
    const path = require('path');
    const vm = require('vm');

    // include the heartbeat JS library
    var content = fs.readFileSync(path.join(__dirname, 'hilbert-heartbeat.js'),'utf8');
    vm.runInThisContext(content,{filename:'hilbert-heartbeat.js'});

    // wait for the document finish loading and ...
    var webContents = require('electron').remote.getCurrentWindow().webContents;
    webContents.on('did-finish-load',() => {
        // ... define the heartbeat configuration
        const heartbeatCfg = {
            url: Heartbeat.getPassedUrl('http://localhost:8881'),
            appId: Heartbeat.getPassedAppId('test_app'),
            interval: 1000,
            sendInitCommand: true,
            sendDoneCommand: true,
            debugLog: console.log
        };

        // ... init the heartbeat
        window.heartbeat = new Heartbeat(heartbeatCfg);
    });
}

works quite well. You can see the heartbeat script in action in the console.
My question is where to put the preload.js. It is separate from the kiosk browser and currently only makes sense in the context of hilbert.
Should we put it into this repository (since the Dockerfile the there as well) and separate the kiosk browser and hilbert related parts later?
Note: In order to make the above preload.js work, you need at least this version of heartbeat.js (there was a bug with delayed loading of the library). So if we put the preload.js here, we also need to update hilbert-heartbeat.js.

The repository subfolder and the Dockerfile of the kiosk browser need to be updated.

TODO: finishhb_kiosk.sh

the general pre-loading works fine in all my tests!
@porst17 i will add a special script hb_kiosk.sh into hilbert/kiosk image in order to enable the special heartbeat-library pre-loading due to Hilbert's needs.
The current script is available at https://gist.github.com/malex984/f82078da605c1249b8e7a43895db1d3e for checking


Webpack seems to add non-ES5 compliant syntax to generated bundle

Bug report

What is the current behavior?
On some of the generated chunks, we found that webpack added this snippet to them.
function n(r) {
    if (t[r]) return t[r].exports;
    var o = (t[r] = { i: r, l: !1, exports: {} });
    return e[r].call(o.exports, o, o.exports, n), (o.l = !0), o.exports;
}

In other generated chunks, we found that webpack added similar snippets to them, but with different variable
function n(i) {
    if (e[i]) return e[i].exports;
    var o = (e[i] = { i, l: !1, exports: {} });
    return t[i].call(o.exports, o, o.exports, n), (o.l = !0), o.exports;
}

Notice that the function is exactly the same, other than the different args used (i instead of r).
On the 2nd line of the 2nd function, we see that webpack is using shorthand object property because the argument variable is named i.
var o = (e[i] = { i, l: !1, exports: {} });

This causes error in production because the syntax is not recognised on older browsers such as Chrome 41, which is the engine used by GoogleBot when crawling sites.
We have added babel-loader to transpile our codes, which contains usage of a lot of non ES5 syntaxes such as shorthand object property, and they have been transpiled correctly, so we suspect that this is a problem with webpack itself.
If the current behavior is a bug, please provide the steps to reproduce.
-- to be provided --

What is the expected behavior?
No non-ES5 compliant syntax in the generated bundles.
Other relevant information:
webpack version:  4.29.6
Node.js version: 10.14.1
Operating System: macOS 10.14.3

Looks it is problem with minimizer, not webpack, please provide minimum reproducible test repo

My bad, it was indeed a problem with the minimizer used. Closing this PR.


Cover image is missing for 5.0 characters

They changed the layout of their website where I grab the cover images from. I'll slowly figure this out...

they've been manually added for all the 5.x characters so far, but they weren't possible to do automatically


ModelNode, set minZoom/maxZoom allowed while zooming in/out camera

hello dears, I would like to disable zooming for my 3d model, is there any option to set max scale or disable scale from modelNode,
As well I am still not able to set max rotation angles to the camera manipulator while rotating, I would like the scene to stop rotating after reaching a certain angle from right left top and bottom, is that possible doable, appreciate your help

Hi!
Scaling can be disabled using this property:
https://github.com/SceneView/sceneview-android/blob/00bae0697efa8fad30c1922def99794e49a7a712/sceneview/src/main/java/io/github/sceneview/node/Node.kt#L311
The minimum and maximum scale can be set using these properties:
https://github.com/SceneView/sceneview-android/blob/00bae0697efa8fad30c1922def99794e49a7a712/sceneview/src/main/java/io/github/sceneview/node/Node.kt#L320
And I see that you've already found the issue about restricting the camera angles #62

Hi!
Can it be so that the model isn't scaled but the camera is zoomed in and out?

Hi! Can it be so that the model isn't scaled but the camera is zoomed in and out?

Hello!
On camera zoom in and out, I want to keep a space between the camera and the 3d model,
currently when zooming too much I am reaching inside the model and passing by it,
Same for zoom out the model is getting too small and disappearing,
what is required is to let the user zoom the camera in and out to a certain position
Thanks

what is required is to let the user zoom the camera in and out to a certain position

I think it is currently only possible to extend the SceneView class and override the cameraManipulator property to set the minimum zoom distance. However, I'm not sure if it is available for modes other than MAP.
https://github.com/SceneView/sceneview-android/blob/b7341cced9c0d7ac036d3a039a5c5fa9a8d39c1a/sceneview/src/main/java/io/github/sceneview/SceneView.kt#L354
https://github.com/google/filament/blob/eaa86060e2039c3da4031ec71ff9dfea7a4efd72/android/filament-utils-android/src/main/java/com/google/android/filament/utils/Manipulator.java#L193


NEXT-9021 - Add autoscroll to listing

1. What does this change do, exactly?
Add scroll-up in listing to get the user moved to the top of the loaded listing while they are switching pages on bottom navigation.
2. Describe each step to reproduce the issue or behaviour.

change page of listing on the bottom navigation
see user stucks on this position

3. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[x] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Unit Tests are missing :)


Implement -R in the CLI

In the Ruby CLI, -R in conjuntion with -D allows multiple file (ie **/*.adoc) conversion, retaining the folder structure. It should be the same in asciidoctorj.

Thank you @4lber10 for contributing this fix.

I guess this is resolved as the PR was merged, right?
Will be fixed in 2.1.0

Thanks a lot, looking forward to this!


A problem about warping

Hi @askerlee  , nice work for Optical Flow estimation.
There are some problems when using optical flow for warping, I try to use  flow_viz.warp_flow in your code for warping, but got the following result:

What may be the problem? Look forward to your reply.

Thanks for your interest. The flow_viz code is inherited from the gma code base, and I haven't had close look into it. Will examine what's the problem.

Ok, thank you for replying.


Windows

[x] I have read the CONTRIBUTING guide

I'm finally merging this, thanks a lot for your help @NikkyAI


kubelet: fix #4472

By examine the log from
https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/50980094
https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/50971293
https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/50903684,
we are parsing nil name, which cause the panic.
I am not sure why we get the empty name (a nil string since the struct is from json).
But checking the len of the name before parsing is better than no checking anyway.

@dchen1107 @brendandburns : Any suggestions on who will be a good reviewer for this?

Do you why the name is empty here? All docker containers should have a name; no name is specified by the client, Docker will automatically generate a name since docker 1.0 release. Can we reproduce the issue easily?

@dchen1107 I have no idea. I looked around the docker tool, and did not found a obvious problem. I can try to look into the test cases (might be a problem in the test?)
If we do have the guarantee that docker name should not be empty, I would like to close this pull request. Since it would fix nothing but mask a fatal mistake.

@xiang90 that is my concern here. I did a bunch quick tests against 1.4 docker, and couldn't find docker container without name. I can try with an old docker daemon.

I think I found the root cause of the issue, and the issue is test related. I am going to send PR to fix it, and close this one. Thanks for looking into it.


Feature/add ValueCount() and GetValueIndex() method to Value

Hello again!
In writing some code, I realized it would be useful to get the number of inner values a Value contains without having to do a type assert (or really knowing anything about the inner type).
This is a small PR that adds a ValueCount()int and GetValueIndex(i int)interface{} methods to Value.
Example:
package main

import (
	"fmt"
	"github.com/suyashkumar/dicom"
	"github.com/suyashkumar/dicom/pkg/tag"
)

func main() {
	element, err := dicom.NewElement(tag.ModalitiesInStudy, []string{"MR", "CT"})
	if err != nil {
		panic(err)
	}

	tagInfo, err := tag.Find(tag.ModalitiesInStudy)
	if err != nil {
		panic(err)
	}

	fmt.Println("TAG        :", element.Tag)
	fmt.Println("VM         :", tagInfo.VM)
	fmt.Println("VALUE COUNT:", element.Value.ValueCount())

	for i := 0 ; i < element.Value.ValueCount() ; i++ {
		fmt.Printf("VALUE %v    : %v\n", i, element.Value.GetValueIndex(i))
	}

	// Output:
	// TAG        : (0008,0061)
	// VM         : 1-n
	// VALUE COUNT: 2
	// VALUE 0    : MR
	// VALUE 1    : CT
}

I've opened this as a draft PR in case you feel it doesn't fit the lib. Let me know what you think!

I just updated this PR to also include a GetValueIndex() method. I am working on a problem where it would be useful in testing to be able to build a []interface{} slice of the inner Element values.

Although, looking at this I think it might make more sense to handle PixelData like []byte, always return a count of 1, and return the entire data, instead of frames. I'm going to update that real quick.

alright, that change is up.


Update package.json and add travis-ci

Add flow to dependencies and support npm run typecheck which is automatically run during npm run test.
Use travis-ci.org to ensure tests pass.

LGTM


running with npx should create a project with package-lock.json (rather than yarn.lock)

Issue
Running create-react-app with npx creates a project with a yarn.lock file, rather than package-lock.json. To me, using npx rather than yarn should be interpreted as an intention to use npm with the project (rather than yarn, as the yarn.lock file implies).
Describe the solution you'd like
I think it'd be ideal if creating with npx/npm resulted in a project with package-lock.json. Creating with yarn create (or via yarn in another way) would still generate a project with yarn.lock.  If this seems like a good idea, happy to take a look into how it might be implemented sometime.

You can use the --use-npm flag in create-react-app, otherwise it will detect if yarn is installed and use it automatically.

Good to know, thanks!


python311Packages.gitignore-parser: 0.1.8 -> 0.1.9

Diff: https://github.com/mherrmann/gitignore_parser/compare/refs/tags/v0.1.8...v0.1.9
Changelog: https://github.com/mherrmann/gitignore_parser/releases/tag/v0.1.9
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259334 run on x86_64-linux 1

6 packages built:

python310Packages.gitignore-parser
python310Packages.gitignore-parser.dist
python311Packages.gitignore-parser
python311Packages.gitignore-parser.dist
tell-me-your-secrets
tell-me-your-secrets.dist


rename reduceFrom/Right fold/Right

I didn't link between the functions, because we have to discuss this first.
closes #98

@tomekwi @hemanth any input or is this good to go?

:+1: LGTM
I guess we’ll do #96 afterwards for all functions, won’t we?

I guess we’ll do #96 afterwards for all functions, won’t we?

yop


Update Form.php

Did these changes for my own project. Thought they may be of use for others.

Changed the select place holder from "Select" to an optional parameter
Added a new type that allows for automatically generating numbered drop down lists
Added functionality to automatically check the correct radio button based on the value
Added function to generate label wrapper for fields

Thanks!


Compose failed, and the prompt for the docker-compose command appeared when do compose.

Command
bash ./sparrow startone go
Error

The reason for the error is that your docker-compose version is too low. It is recommended to upgrade your docker-compose version.


The description of the functions in "pydoc3 primesieve" is too terse, spartan and unhelpful

Hi!
After installing primesieve-python and running pydoc3 primesieve, I get this:
Help on package primesieve:

NAME
    primesieve

PACKAGE CONTENTS
    _primesieve
    numpy (package)

FUNCTIONS
    count_primes(...)
        Count prime numbers

    count_quadruplets(...)
        Count prime quadruplets

    count_quintuplets(...)
        Count prime quintuplets

    count_sextuplets(...)
        Count prime sextuplets

    count_triplets(...)
        Count prime triplets

    count_twins(...)
        Count twin primes

    get_max_stop(...)
        Returns the largest valid stop number for primesieve. 2^64-1 (UINT64_MAX)
    get_num_threads(...)
        Get the currently set number of threads

    get_sieve_size(...)
        Get the current set sieve size in KiB

    n_primes(...)

IMO, the functions could use a more wordy description and a useful signature (named arguments) in the documentation, and optionally some invocation samples. Also, one should mention primesieve.Iterator() which is completely absent.
Before I delve into the rabbit hole of finding how to better document cython functions and adding docs I wish to know if there is a general consensus that this should be fixed.
I'm using Fedora 33 beta x86-64 in case it matters.
Thanks!

Hi shlomif,
Unfortunately I have too many open source projects and I have trouble maintaining them all. Hence my goal is to focus my efforts on my most important projects like primesieve and primecount and find contributors and/or maintainers for the other projects. primesieve-python is one of the projects where I would be happy if I found another maintainer for it.
The code quality of primesieve-python is very good as @brl0 and myself spent a significant time improving it at the beginning of this year. If you want I gladly add you as a maintainer, then you can do the changes you want. (We also need to add Python 3.9 support by updating setup.py).
When you are done doing a new release is a simple as tagging the release. This will automatically upload the new release artefacts to pypi.

Hi @kimwalisch !

Hi shlomif,
Unfortunately I have too many open source projects and I have trouble maintaining them all. Hence my goal is to focus my efforts on my most important projects like primesieve and primecount and find contributors and/or maintainers for the other projects. primesieve-python is one of the projects where I would be happy if I found another maintainer for it.
The code quality of primesieve-python is very good as @brl0 and myself spent a significant time improving it at the beginning of this year. If you want I gladly add you as a maintainer, then you can do the changes you want. (We also need to add Python 3.9 support by updating setup.py).
When you are done doing a new release is a simple as tagging the release. This will automatically upload the new release artefacts to pypi.

You can make me a maintainer if you wish and I will try to improve the docs. Thanks!

@shlomif Do you already have a pypi account (https://pypi.org/)? What's your pypi user name?
I need to add you as a maintainer on pypi as well so that when you tag a new release the release artifacts can be uploaded automatically to https://pypi.org/project/primesieve.

@shlomif Do you already have a pypi account (https://pypi.org/)? What's your pypi user name?

Yes I do, see: https://pypi.org/user/shlomif-gmail/ .

I need to add you as a maintainer on pypi as well so that when you tag a new release the release artifacts can be uploaded automatically to https://pypi.org/project/primesieve.

Thanks!

Thanks!
Once Travis CI support Python 3.9 I'll do a new release.


Make GCS bucket location configurable

Closes #511

Linting error will disappear after https://github.com/mamba-org/quetz/pull/513 is merged.

I'm not entirely sure what to do about the failing unit tests:
authlib.integrations.base_client.errors.MismatchingStateError: mismatching_state: CSRF Warning! State not equal in request and response.
2022-04-05T16:45:36.8956085Z quetz/tests/authentification/test_oauth.py::test_config_create_user_with_role_in_different_provider[jupyter_response-user_roles0-None] FAILED [ 94%]

But this seems to affect multiple PRs and is probably not related to my changes.

I'm not entirely sure what to do about the failing unit tests:
authlib.integrations.base_client.errors.MismatchingStateError: mismatching_state: CSRF Warning! State not equal in request and response.
2022-04-05T16:45:36.8956085Z quetz/tests/authentification/test_oauth.py::test_config_create_user_with_role_in_different_provider[jupyter_response-user_roles0-None] FAILED [ 94%]

But this seems to affect multiple PRs and is probably not related to my changes.
Seems to be related to authlib: lepture/authlib#376

Also fixed in #513

Thanks, this looks good to me!

I just rebased to see if tests are passing.

Codecov Report

Merging #512 (16d8507) into main (1ea9475) will decrease coverage by 1.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   83.21%   81.95%   -1.26%
==========================================
  Files          78       78
  Lines        5891     5892       +1
==========================================
- Hits         4902     4829      -73
- Misses        989     1063      +74

Impacted Files
Coverage Δ

quetz/config.py
89.63% <ø> (ø)

quetz/pkgstores.py
42.45% <0.00%> (-11.72%)
:arrow_down:

quetz/database.py
83.33% <0.00%> (-4.17%)
:arrow_down:

quetz/dao.py
88.51% <0.00%> (-2.58%)
:arrow_down:

quetz/testing/fixtures.py
96.73% <0.00%> (-1.97%)
:arrow_down:

quetz/jobs/runner.py
89.61% <0.00%> (-0.87%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea9475...16d8507. Read the comment docs.

Thanks for merging this so quickly, @wolfv! Would it be too much to ask for a new Quetz release, so we try out this feature? 👼


[T3A2][T13-A4]Sean Zhang

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.