Collection permissions check

What this PR does / why we need it:

Checks user permissions to create a Collection & create a Dataset on a specific collection, if the user doesn't have permissions neither to create a collection or a dataset, the Add Data dropdown inside the Collection page will not appear; if it has permissions to create a collection or dataset it will be visible with the proper buttons enabled or disabled in it.
Checks user permissions to create a Collection inside the Create Collection page.
Checks user permissions to create a Dataset inside the Create Dataset page.
Check user permissions on the root collection to enable or disabled buttons inside the Add Data drop-down located in the application header.

Which issue(s) this PR closes:
Closes #434
Special notes for your reviewer:
I have also changed the alias 'root' used in several components for an exported constant, to avoid mistakes and improve reusability, as it is done in js-dataverse.
E2E test navigates to the collection page after submitting a valid form is failing, will be ok after merging PR 169 from js-dataverse and also PR 451 from this repo.
Suggestions on how to test this:

Create a Collection and a Dataset in the JSF version with User A, publish both Collection and Dataset.
With User A, Navigate to that collection and check that you are able to see the Add Data dropdown with both the New Collection and New Dataset buttons enabled in it, click on both buttons and check that you can successfully the create dataset form and the create collection form.
Create another user "B" in the JSF version.
Navigate in the SPA to the Collection created from user A, and the Add Data dropdown shouldn't be visible.
Log in with user "A" and navigate to the created Collection in JSF, click Edit => Permissions, go to Users Groups and assign roles to user "B" as Dataset Creator to be able to add datasets to that Collection.
Log in with user "B" and navigate to that collection in the SPA and check that in the Add Data dropdown you have only the New Dataset button enabled.
Log out from user B, Log in with user A and navigate again to that Collection and assign a different role (Curator for example), so user B will be able to Add Dataset and Add Collection.
Again log in with user A and navigate to that collection in the SPA and check that in the Add Data dropdown you have both the New Collecction and the New Dataset buttons enabled.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
No
Additional documentation:
No

coverage: 97.614% (+0.02%) from 97.592%
when pulling 71ac0f338802a3c0fbdbab7ff3a93e1a289f7e74 on feat/434-collection-permission-check
into 393e9269ebcd8ceb04504b2a389291df1bc46186 on develop.

Ready for Review again, some e2e tests for the FileRepository are failing randomly, there is an open issue for that already.

@ekraffmiller thanks! all changes done

Merge conflicts solved


TypeError: no _dump_data is defined for class Liquid::C::ResourceLimits

Hello there,
when I try to update to latest 4.1 i have this on my specs
     TypeError:
       no _dump_data is defined for class Liquid::C::ResourceLimits

error come from this :
Rails.cache.fetch("render_template/liquid_template/website/#{template_version}/#{name}".freeze, compress: true) do
      Liquid::Template.new.parse(body)
    end

my current version is 4.0.  liquid 5.3, ruby 2.7.5, rails 5.2.7
Any idea ? Thanks !

@JulienItard To fix this error, you can define a _dump_data method for the Liquid::C::ResourceLimits class. The _dump_data method should return a string representation of the object that can be used to reconstruct the object later. Here is an example implementation:
class Liquid::C::ResourceLimits
  def _dump_data
    # return a string representation of the object
    # for example:
    "#{@limit_name}:#{@limit_value}"
  end
end

You might want to do the same with class Liquid::C::BlockBody


Provide optional message writing facilities

Due to the changes introduced in #159, writer service has been removed from Mainflux. While the decision is to keep the core platform agnostic to the way messages are persisted, and produce the stream of normalized messages instead, some customers might need to persist these as well.
That being said, new writer service should provide various DB repository implementations, that are to be instantiated at runtime based on the service configuration. First release will contain only the PostgreSQL repository, while separate tickets will be created for any additional implementations (e.g. MongoDB, InfluxDB, Cassandra).
This new service will consume the stream of messages generated by normalizer and store them. The only interface it needs to support should look like:
type MessageRepository interface {
    Save(Message) error
}

I was also thinking about this and wanted to open a ticket about this as well, but I guess you were faster :)
I think that we should only define and provide a DB (persistance) interface which will describe and the boilerplate to tap on the messages in NATS.
I think that some users would not want to store all the messages. They will simple read the messages add apply some analytical functions and store the aggregated values to the database. It would be nice if we design the whole message writing so that some rules and message processing can be applied before writing the values to the database. Simple example: The room temperature is measured by a sensor which returns the temperature in Celsius, but the the user is based in the US and he want's to have the values in Fahrenheit as unit of measure. In such cases it would be nice to have a way to filter and process the messages before writing them in the database. The message stream from the normalizer will go through a filtering (rules) engine and pre-processor before writing the messages to the database.
If we persist all the messages as they are received and processed by the normalizer, in order to avoid DB read pooling from the business apps built on top of  Mainflux, it would be nice if we have some kind of notification fired when a new message has been written to the DB so that some additional data processing can be triggered(started) in order to start some data processing.
I know that this ticket is about saving the normalized messages directly to the database, but I just wanted to write down the ideas which I have. I'm aware of the rules engine poc in the labs repo, but I don't know what's it status.
Shouldn't we also open a ticket for service which will read messages and publish them in NATS?
Simple example: A massage from the normalizer is written in the DB, some external app reads it directly from the DB processes the data, writes some new data record which should be published to NATS so that it can be consumed by other services.
What do you think about this scenarios?

@chombium these writers are intended to serve as utilities for customers that want to store normalized messages for any reason. They are not intended to be part of "standard" deployments, since I would prefer to apply post processing on top of message stream generated by the normalizer. Rules engine that will soon start to be integrated in the platform will take care of the "load" placed on the system.
Regarding the reader path, we have discussed this a lot and decided not to provide such service. All those post-processing step you mentioned above will be provided together with some additional steps, as part of our "full" solution, which we do not intend to open source at the moment.

@mijicd Thanks for the answer.
Not providing reader seems reasonable to me, but still, I think it would be interesting if we at list define an interface, so that if many vendors build analytics solutions on top of Mainflux, interoperability between the solutions and the components will be assured. This way we'll have drop in components which will seamlessly integrate and work with one with another.
Who knows maybe some day we'll have a marketplace for various components and solutions which will work on top of Mainflux ;)

@chombium to which interface do you refer?
Mainflux is doing message brokering, and normalized SenML mesages are pumped out of NATS in the following format: https://github.com/mainflux/mainflux/blob/master/message.proto#L13-L28
It is basically SenML format plus some additional Mainflux-related fields (notably Channel, Publisher and Protocol - https://github.com/mainflux/mainflux/blob/master/message.proto#L15-L17), and should be easy to parse by any analytics engine on the top.

@drasko uh I guess I missed that out. sorry. I was thinking on the reader interface definition, simply read a database record and publish it to NATS.
On the second thought, I completely agree with you, all we need is an example app in which we can show how can the users read, write and process the messages.

Split into #235, #236 and #237.

@mijicd I was thinking  of a payload agnostic nats client which will simply tap on the "normalized" subject and give the read message to the Save method. Every field mapping will be done in the Save method according to the user's needs


Angular component export should not be default

Currently
Angular output looks like this:
export default class MyComponent {
  list = ["hello", "world"];
  newItemName = "New item";
}

Note the "export default". Although this can be used, it is very unusual / non-idiomatic in the Angular ecosystem.
Expected
export class MyComponent {
  list = ["hello", "world"];
  newItemName = "New item";
}

If you are working on wrapping everything inside NX, it will complain that component is not exported from library, although it is, but because it is default export, it can not understand that

@kylecordes, @samijaber seems like this doesn't reproduce anymore


Render texture is dependent on scene.game.config.width/height

I'm not sure why the width/height of the game breaks the render texture, but it does even in the<EMAIL_ADDRESS>If I don't set the game width/height the rendercanvas is very small around 500x500, no the size I give it to it when I create it.
This is related to this bug https://github.com/photonstorm/phaser/issues/3958 (has not been answered for months)

Also there is something very weird that if it breaks, and then restore the commit back the texture is still cropped. I'm not sure where this cache is stored. Maybe in webpack, but it never happened to me before.
What I'm trying to say is that the same commit (exact code) has 2 different results dependent on previous code changes.

You can't not set a game width and height. If you don't provide one, it will default to 1024 x 768.
You can't not set a RenderTexture size either. If you don't provide one, it'll default to 32 x 32.
If I remove the game width/height from any of the RT demos, even under 3.15.1, they work as before (just with a larger canvas in most cases)
What is it, exactly, that you're seeing happening?

So if I don't change the scene.game.config.width I see the max drawable rendertexture the size of my screen, which is 600 x 500px. So the render texture is 600x500 even if I set it to 15000x15000.
If I change scene.game.config.width to 15000 then the rendertexture renders the correct size, 15000.

You can't not set a RenderTexture size either. If you don't provide one, it'll default to 32 x 32.

I might be wrong but render texture has a width:

Note that the rendertexture is inside a container which is viewed with a camera that is zoomed out and panned.

You can't not set a game width and height. If you don't provide one, it will default to 1024 x 768.

I know, it's a hack that works sometimes... and tricks the render texture to be of the size I request and not of the size of the screen.

Just to correct. This behaviour only works in the<EMAIL_ADDRESS>On the 3.15.1 I can't make the rendertexture any size except the screensize.
here is the size: https://photonstorm.github.io/phaser3-docs/Phaser.GameObjects.RenderTexture.html

I'm not sure why you say can't set the size on a RenderTexture.

Here is https://labs.phaser.io/edit.html?src=src\game%20objects\render%20texture\container%20to%20render%20texture.js
So if the render texture is 5k x 5k, then when is scaled by 0.2, should be 1k width. But is not as you can see in the output:

A more obvious example here as well: https://labs.phaser.io/edit.html?src=src\game%20objects\render%20texture\container%20to%20render%20texture.js
If the width is 2000px:

If the width is 1000px:

The width is the same, how can be possible when the width is double in the first example?

Another example. If I change the game width.
Game width 400px:

Game width 600px:

Related issue here https://github.com/photonstorm/phaser/issues/4139
I wonder when we bump the new version and deploy to npm?

It'll be released when it's ready. It's irrelevant how long ago the previous version was.
I'm happy render textures crop correctly now, but their internal camera doesn't allow it to be repositioned, which needs fixing. You can zoom and rotate the internal camera just fine, but not scroll it.

Ok, the internal RenderTexture camera viewport now works correctly. You can resize the camera viewport and it will update the internal crop rect accordingly. Changing the scroll factor still has no impact on game objects, but this is a different issue.

My mistake, scrolling the RT camera works perfectly, as long as you're rendering game objects to it. Plain texture frames won't take the camera into account, as they bypass it, which is fine.

Ok, thanks.


Switch to recommended name for unique constraint on DataSource table

Apparently, the default naming scheme for unique constraints uses only the first column in the list.

So why didn't this automatically apply here?

Perhaps alembic was updated in the meantime, because this time the name was suggested to me by alembic (when I asked it to start a revision file for a different database upgrade).


VSI_bundle_v0_0_12 - bash configuration

Firstly, I can't find the INTO-CPS App install user manual... so when installing the VSI_bundle_v0_0_12 I don't know how to proceed when I need to provide the path to the bash

@FlorianLapschies can you help out?

The app manual is at https://github.com/into-cps/into-cps.github.io/raw/master/manuals/INTO-CPS_User_Manual.pdf
There is a link to it on the download page: http://into-cps.github.io/download/

@avh-agrointelli: You can skip that step during installation. Sect. 7.1.1 of the INTO-CPS user manual provides more information.
@ldcouto: Thank you for the link to the manual.

@FlorianLapschies Ok, thanks.
@ldcouto Thanks for the link to the manual.

No problem.


How to deploy 7nodes in multiple servers?

I modified the 7nodes example and tried deploying it in multiple servers.
SourceCode hosted on github: https://github.com/coolcode/quorum-examples/tree/master/simple
In my demo, I use only 3 servers to deploy node1, node2 & node3.

IP
Node
Open Ports

<IP_ADDRESS>
node1
21000,22000,22002,22003

<IP_ADDRESS>
node2
21000,22000,22002,22003

<IP_ADDRESS>
node3
21000,22000,22002,22003

There were two scripts file I changed by myself -- init.sh & start.sh
the peer settings in init.sh (line 97):
"peer": [
        {
            "url": "http://<IP_ADDRESS>:22003"
        },
        {
            "url": "http://<IP_ADDRESS>:22003"
        },
        {
            "url": "http://<IP_ADDRESS>:22003"
        }
    ]

Also, modify the IP address in permissioned-nodes.json
[
	"enode://ac6b1096ca56b9f6d004b779ae3728bf83f8e22453404cc3cef16a3d9b96608bc67c4b30db88e0a5a6c6390213f7acbe1153ff6d23ce57380104288ae19373ef@<IP_ADDRESS>:21000?discport=0&raftport=22002",
	"enode://0ba6b9f606a43a95edc6247cdb1c1e105145817be7bcafd6b2c0ba15d58145f0dc1a194f70ba73cd6f4cdd6864edc7687f311254c7555cc32e4d45aeb1b80416@<IP_ADDRESS>:21000?discport=0&raftport=22002",
	"enode://579f786d4e2830bbcc02815a27e8a9bacccc9605df4dc6f20bcc1a6eb391e7225fff7cb83e5b4ecd1f3a94d8b733803f2f66b7e871961e7b029e22c155c3a778@<IP_ADDRESS>:21000?discport=0&raftport=22002"
]

In node1, initialize and start node1:
cd ~/qm/simple
./init.sh --node 1 && ./start.sh --node 1

In node2, initialize and start node2:
cd ~/qm/simple
./init.sh --node 2 --permissioned 0 && ./start.sh --node 2 --permissioned 0

In node3, initialize and start node3:
cd ~/qm/simple
./init.sh --node 3 --permissioned 0 && ./start.sh --node 3 --permissioned 0

Testing
Step1.Sending a private transaction
In node 1, (this is denoted by the public key passed via privateFor: ["QfeDAys9MPDs2XHExtc84jKGHxZg/aj52DTh0vtA3Xc="] in private-contract.js):
./runscript.sh private-contract.js
Make note of the TransactionHash printed to the terminal.
Step2.Inspecting the Quorum nodes
We can inspect any of the Quorum nodes by using geth attach to open the Geth JavaScript console. For this demo, we will be inspecting Node 1, Node 2 and Node 3.
It is recommended to use separate terminal windows for each node we are inspecting. In each terminal, ensure you are in the ~/qm/simple/ directory, then:
In terminal 1 run geth attach qdata/dd/geth.ipc to attach to node 1
In terminal 2 run geth attach qdata/dd/geth.ipc to attach to node 2
In terminal 3 run geth attach qdata/dd/geth.ipc to attach to node 3
Step3.Checking the state of the contract
For each of the 3 nodes we'll use the Geth JavaScript console to create a variable called address which we will assign to the address of the contract created by Node 1. The contract address can be found in step 2.
Once you've identified the contract address, run the following command in each terminal:
> var address = "0xfe0602d820f42800e3ef3f89e1c39cd15f78d283"; //replace with your contract address
Next we'll use eth.contract to define a contract class with the simpleStorage ABI definition in each terminal:
> var abi = [{"constant":true,"inputs":[],"name":"storedData","outputs":[{"name":"","type":"uint256"}],"payable":false,"type":"function"},{"constant":false,"inputs":[{"name":"x","type":"uint256"}],"name":"set","outputs":[],"payable":false,"type":"function"},{"constant":true,"inputs":[],"name":"get","outputs":[{"name":"retVal","type":"uint256"}],"payable":false,"type":"function"},{"inputs":[{"name":"initVal","type":"uint256"}],"type":"constructor"}];
> var private = eth.contract(abi).at(address)

The function calls are now available on the contract instance and you can call those methods on the contract. Let's start by examining the initial value of the contract to make sure that only nodes 1 and 2 can see the initialized value.
In terminal window 1 (Node 1):

private.get()
42

In terminal window 2 (Node 2):

private.get()
0 ❌!ERROR!
(But the expected result should be 42, not 0!)

In terminal window 3 (Node 3):

private.get()
0

Normally nodes 1 and 2 are able to read the state of the private contract and its initial value is 42. I have tried lots of times but it is still 0.
Can you tell me which step has problem? or please tell me how to deploy 7nodes sample in multiple servers?

Hi, I checked out your example and it seems to work okay for me.
I only have one machine, so I had to modify your scripts to run all 3 nodes on the same server (which pretty much mirrors the 7-nodes example).
I get the expected value of 42 from private.get() on node 2.
Some things for you to check:

Which version of Quorum are you using? If it's not the latest then retry with the v2.1.1 or master.
Are there any errors in the geth logs or the tessera logs? There should be no messages indicating that any node is unable to connect.
After submitting the private contract, check the transaction receipt to confirm that it was processed ok.
Check the tessera logs to confirm that node 2 accepted it ok. You should see a message something like the following to show that the transaction was stored:

Stored transaction MwgMeJBWEBuVccJ9JpQ59XbKrPXQFn2yK1qh16O6DAJq3FtWm/AedgSYZyrJ35UnV75wI8XnStukF36ZDVqkkQ==

Where the key is the same as the value in the tessera1.log.

Please reopen if theres a pending question.


Current loading indicator not working in devices with notch

Possible solutions:

Implement home made loading indicator/spinner
Leave without loading indicator and let devs to decide when a new project starts
Add an existing solution(pod) to the base :(

I added this provisional solution in Surkus:
func showSpinner() {
    view.endEditing(true)

    guard view.viewWithTag(spinnerTag) == nil else { return }

    let spinner = UIActivityIndicatorView(style: .large)
    spinner.frame = view.frame
    spinner.color = .skAmaranth
    spinner.backgroundColor = UIColor.skGray.withAlphaComponent(0.5)
    spinner.tag = spinnerTag

    view.addSubview(spinner)

    spinner.startAnimating()
  }

  func hideSpinner() {
    guard let spinner = view.viewWithTag(spinnerTag) else { return }

    spinner.removeFromSuperview()
  }

There must be better alternatives for sure, but it was a quick way to do it without having any designs for it.

protocol ActivityIndicatorPresenter: class {

  var activityIndicator: UIActivityIndicatorView { get }
  func showActivityIndicator(_ show: Bool)
}

extension ActivityIndicatorPresenter where Self: UIViewController {

  func showActivityIndicator(_ show: Bool) {
    guard show else {
      activityIndicator.removeFromSuperview()
      return
    }
    view.addSubview(activityIndicator)
    activityIndicator.color = .black
    activityIndicator.frame = view.bounds
    activityIndicator.startAnimating()
  }
}

I implemented something very close to @mato2593 solution in avinew

This has the advantage of doing
showActivityIndicator(viewModel.state == .loading)

instead of doing show or hide in each case

stop puking code and open a PR 😄


Need to trigger the viewer from code

Some times I need to access the image viewer form the code because the I might have some deferent logic when clicking on the image for example I want to make sure that the user can access the large image so I need to use click event and do my check then start the image viewer.
I see no provider or any api to the image viewer. can you please let me know what to do.
Thanks

I'd like to add my voice to this. I am using image viewer inside Ionic Slides component. Slides are for browsing and image gallery, and image viewer is for zooming in.
I would also like to be able to open image viewer on click, because I am stuck with the default configuration. For example, I do not like having to swipe up to close the viewer, I would prefer my users to tap to go in, and also to tap to go out. But this cannot be changed without source code changed. And probably other people prefer swipe in, so it's not an option. It has to be configurable.
If image viewer would be opened using onClick event, then in addition to the URL parameter we could also specify the "options" parameter. And in the options it could be anything: behaviour, colours, you name it, we could expand it indefinitely.
The image viewer is great, thank you Riron. It's probably the best I've tried so far, and supports both mobile and desktop. But it's too rigid at the moment, it needs an easy way to be configured and extended.
Using onClick event and options parameter is one way to do it, if there's a better way I'm all for it too.

Thanks for sharing your thoughts @QXCgxNED. Opening the viewer on click is nearly ready and will be available soon.
Nevertheless I am not planning on supporting "click to close" right now, as I'm not sure that's the best UX. This plugin is inspired by what we use on apps like Twitter and Facebook, and clicking on an image to go back in the history doesn't feel natural to me.
So yes the plugin will become more flexible with this way of opening it, but I want to avoid adding too many options as it may confuse users.
Of course, you can always fork it and tweak some bits to better suit you needs !
Anyway, thanks for you support, and i'm glad you like it ! 👍

Closing this issue as it landed in<EMAIL_ADDRESS>

Thank you for taking time to reply to me. I hope it's just a misunderstanding, because I did not ask to support any feature like "click to close". I was suggesting to provide other developers a possibility to easily extend the functionality. Some people like Twitter, that's fine, but other people like other things. There should be some team work here. Limiting other engineers to the implementation that is only suitable for someone is not the way collaboration works. Giving people freedom to extend and configure is the way to go. Adding more options is not confusing if done in clear and documented way. More options means more freedom to use your software the way people like. And people like very different things, and have very different use cases. Better to let them decide for themselves, and give them an easy way to contribute.

I'm not sure to understand what you would like then. Isn't it a new option to close the viewer on click ?
And I am open for suggestions to "provide other developers a possibility to easily extend the functionality" !
Just open a new issue if you have any idea, thanks 😄

Thank you for taking the time and the effort to implement the controller. it works perfectly! 😄


"Circular" units: are they generative the way square/cubic ones are?

Electricians in the US use a fairly bizarre unit called the circular mil, defined to be the area of a circle one mil in diameter. (A mil, in turn, being 1e-3 inches.)
We have square and cubic. Logically circular could be in the same category, which would be consistent. But I've also never heard of anyone else anywhere on earth using circular anything-besides-mil as a unit.
It's basically pi / 4 times whatever square would give you.

To avoid polluting the namespace I would suggest adding circularMil to NonSI. If we later find more "circular" units we could consider adding circular. Or would you like a generally applicable circular, and if so in which module?
Arguably square and cubic are also namespace pollution for a fairly narrow use, but at least they are in the NIST guide.
On Mon, May 11, 2015 at 10:20 PM, Douglas McClean
<EMAIL_ADDRESS>wrote:

Electricians in the US use a fairly bizarre unit called the circular mil, defined to be the area of a circle one mil in diameter. (A mil, in turn, being 1e-3 inches.)
We have square and cubic. Logically circular could be in the same category, which would be consistent. But I've also never heard of anyone else anywhere on earth using circular anything-besides-mil as a unit.
It's basically pi / 4 times whatever square would give you.
Reply to this email directly or view it on GitHub:
https://github.com/bjornbm/dimensional-dk/issues/67

Agreed, I just thought I would run it by you to make sure we were on the same page.
Plan is to add circularMil to NonSI on the grounds that while circular is generally applicable, nobody ever applies it, and the world would probably be a better place if it stays that way.


thriver-maps: Empty InfoWindow Appears on Load

An empty InfoWindow appears on load.

@eoghanTadhg Not sure if this is still an issue, but if you find any empty info windows, can you please resolve?  Thanks


Update toEqual failure message

Summary
This pull request updates the failure message returned by toEqual so that it is identical to the improved message shown in #7105. The changes made are similar to the changes made in #7224.
Test plan
The matcher is tested with a snapshot test.

@phapp88 Thank you. Please forgive the delay to review your work. I requested one change.

Codecov Report

Merging #7325 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7325      +/-   ##
==========================================
- Coverage   66.64%   66.64%   -0.01%
==========================================
  Files         241      241
  Lines        9345     9344       -1
  Branches        6        5       -1
==========================================
- Hits         6228     6227       -1
  Misses       3114     3114
  Partials        3        3

Impacted Files
Coverage Δ

packages/expect/src/matchers.js
99.37% <100%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9812e1b...d316498. Read the comment docs.

Yes, my bad, jest-diff does return one-line diff for string args, but null for number or boolean.
expect('received').toEqual('expected'); // diffString is string
expect(1).toEqual(0); // diffString is null
expect(true).toEqual(false); // diffString is null

Therefore, it looks like we need the following:
return (
  matcherHint('.toEqual', undefined, undefined, {
    isNot: this.isNot,
  }) +
  '\n\n' +
  (diffString
    ? `Difference:\n\n${diffString}`
    : `Expected: ${printExpected(expected)}\n` +
      `Received: ${printReceived(received)}`)
);

@phapp88 Thank you for your patient follow through. It might be until Wednesday before my mental slow cooker has suggestion what to do about edge cases from jest-diff package.

@pedrottimark No problem. I'd be willing to submit other pull requests related to jest-diff to help resolve these issues.

Here is another condition to display Expected and Received values when jest-diff returns:

Compared values have no visual difference.
Comparing two different types of values.

RegExp because node.green displays String.prototype.includes as red for early 6.x versions
Not anchored at start because of escape sequences for green and red color.
const diffString = diff(expected, received, {expand: this.expand});
const DIFF_REGEXP = /- Expected/;

return (
  matcherHint('.toEqual', undefined, undefined, {
    isNot: this.isNot,
  }) +
  '\n\n' +
  (diffString && DIFF_REGEXP.test(diffString)
    ? `Difference:\n\n${diffString}`
    : `Expected: ${printExpected(expected)}\n` +
      `Received: ${printReceived(received)}`)
);

The memory is coming back: these tedious details are why this matcher was left until later :)

expect(1).toEqual(0); // diffString is null
expect(true).toEqual(false); // diffString is null

That's a bug, no?

@SimenB hard to say if bug or feature: jest-diff package returns null for some edge cases:

number
boolean
asymmetric matchers

I got stuck at the beginning of 2018 thinking about consequences of changing its contract, so now am looking for ways to move forward on expect package, despite the tighter-than-ideal coupling in my suggestions above.
By the way, can you give a second opinion about https://github.com/facebook/jest/blob/master/packages/jest-diff/src/index.js#L53-L55
I think instead of a === b it should be Object.is(a, b) to deal with 0/-0 and NaN, true?

I think instead of a === b it should be Object.is(a, b) to deal with 0/-0 and NaN, true?

Yes 🙂

RegExp because node.green displays String.prototype.includes as red for early 6.x versions

It's been in Node since v4? https://node.green/#ES2015-built-in-extensions-String-prototype-methods-String-prototype-includes

You are correct. My bad, I think I misunderstood a table row under well-known symbols.


getting bin/bash error message on runing inside a docker container

This is what happens when you run a basic docker container
sysoper@ll-fuhr:~$ docker run -it lacledeslan/gamesvr-srcds-gesource-freeplay:linux
/bin/bash: /bin/bash: cannot execute binary file
sysoper@ll-fuhr:~$

duplicate issue


Adding tensor chapter: tensor basics

Basic tensor operations (folding, unfolding, n-mode dot, ...)

Cool! Merging now and then we can revise together! Thanks for the great work Jean!!


zqd PostgresDB

In addition to storing SpaceRows using a filedb, add support for storing
SpaceRows with postgres. In package apiserver create PostgresDB struct that
implements the DB interface.
A lot of plumbing in this pr to make this work with respect to tests; ran both
locally and in ci:

Add pgctl command for running common tasks on a zqd postgresdb. Currently this
has only options for creating a destroying a testdb, but eventually will be
extended to run migrations and introspect a database.
zqd listen: Add -postgres arg for specifying database. Arg -postgres.DB also
added to specify database in instance (this will mostly be used for tests).
Use package golang-migrate/migrate to create migrations folder in
ppl/zqd/migrations
Add startup.sh script: To be used for postgres+zqd ztests. Uses pgctl to
create and destroy a testdb then launches zqd listen with the correct
configuration
ztest: Plumbing for specifing environment variabes for shell scripts.
ztest: Add tag feature. ztest yaml files that use the tag field will only run
if the tag matches a ZTEST_TAG env variable. This was needed so make test-system
didn't end up running postgres tests.

Closes #1752

There's definitely ways to improve the usability for working with postgres, for this pr and I just wanted to get something working with the idea that we can improve usability in future iterations.

I have a generic question about the advantages of a an ORM like go-pg vs. using something lighter weight. Was there a performance reason to use go-pg?
I have really enjoyed the flexibility of using go database/sql with sqlx for mapping structs to query results, the same way go does json.
It looks like go-pg generates SQL from go code, which is simple now, for this initial code, where you are not yet having to use the struct tags from go-pg. Later, after the database has evolved some complexity, I would worry that the go-pg struct tags to override default behavior will get more complex than mapping structs with sqlx.
If you have experience with go-pg and like it, then it is fine with me. At first look, I do not see where it simplifies things. You are still writing sql, but mapping the results of queries seems more indirect than database/sql and sqlx.

@marktwallace my choice of go-pg was just speed of development time. I'm definitely not worried about performance at this stage in the game.

@alfred-landrum Added db flags you suggested.


Emulator output when calo colections are empty

In the firmware both isolated bits are set to 1 if there is no input from the calorimeters. in the emulator this is set to 0 apparently.

Should be fixed with https://github.com/cms-l1t-offline/cmssw/pull/387


Fix WAILA Harvestability showing wrong tool for some Gregtech things

Fixes GTNewHorizons/NewHorizons#1671.

Upstream issue: squeek502/WailaHarvestability#52
Also helps with the confusion described in GTNewHorizons/NewHorizons#5482.

wood pipes need wrench too after Alkalus changed it

Works.

cool


Calico support

Fixes #224
TODO:

[x] basic PoC support for Calico with manual IP address assignment
[x] add check for CNI plugin type and only use the workaround for Calico
[x] implement proper dummy gateway IP address allocation (likely will have to use another daemonset or at least a pod)
[x] calculate netmask that covers both pod IP and the gateway
[x] add descriptive comments in the code why the workaround is needed and how it works
(should be both in code and architecture docs)
[x] make sure e2e tests pass for Calico
[x] update the documentation
[x] fix ubuntu vm

This change is

Tested using: https://github.com/Mirantis/virtlet/pull/443
export CNI_PLUGIN=calico
VIRTLET_DEMO_BRANCH=ivan4th/calico deploy/demo.sh

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 9 files at r1.
Review status: 2 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 7 of 9 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


chore: generate with gapic-generator-php v1.0.5

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/018a3ca9-a09a-4080-8748-7e64e7faf1fc/targets

[ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

PiperOrigin-RevId: 388791571
Source-Link: https://github.com/googleapis/googleapis/commit/882e6d69a30e4bde445dd33c710f1235b81270c7
PiperOrigin-RevId: 387637604
Source-Link: https://github.com/googleapis/googleapis/commit/8de886fe5447d097e7f51c20aed40738f7eb68e2

Superceded by https://github.com/googleapis/google-cloud-php/pull/5001


[SPARK-49757][SQL] Support IDENTIFIER expression in SET CATALOG statement

What changes were proposed in this pull request?

This pr adds possibility to use IDENTIFIER(...) for a catalog name in SET CATALOG statement.
For instance SET CATALOG IDENTIFIER('test') now works the same as SET CATALOG test
Why are the changes needed?

Consistency of API. It can be confusing for user that he can use IDENTIFIER in some contexts but cannot for catalogs.
Parametrization. It allows user to write SET CATALOG IDENTIFIER(:user_data) and doesn't worry about SQL injections.

Does this PR introduce any user-facing change?

Yes, now SET CATALOG IDENTIFIER(...) works. It can be used with any string expressions and parametrization.
But multipart identifiers (like IDENTIFIER('database.table')) are banned and will rise ParseException with new type INVALID_SQL_SYNTAX.MULTI_PART_CATALOG_NAME. This restriction always has been on grammar level, but now user can try to bind such identifier via parameters.
How was this patch tested?

Unit tests with several new covering new behavior.
Was this patch authored or co-authored using generative AI tooling?

Yes, some code suggestions
Generated-by: GitHub Copilot

The test failure is unrelated, thanks, merging to master!


NSP not found.

I opened a terminal in the folder that my NSP and split NSP are located in.  Ran "sudo python3 splitNSP.py filename.nsp" replacing "filename.nsp" with the name of my of the file I need split.  Also tried it with the whole file path.  It came back saying it couldn't find the file.
I'm sure it's something that I'm doing wrong, but can't figure it out.

You don't need to sudo to run this script. Sudo-ing would change the current working directory. If both the script AND the file are in the same folder you can just ./splitNSP.py filename.nsp


fix bybit-busd-usdt datasource

https://api.bybit.com/derivatives/v3/public/tickers?symbol=BUSDUSDT
url seems to be deprecated

Done
PR with updated adapter and aggregator as followed
https://github.com/Bisonai/orakl-config/pull/44


Allow users to designate unknown fields

Description
Many people getting tested for HIV are unhoused and may not have an address / phone number. In this case, users should be able to designate that these fields are unknown.
Figma - Default state - https://www.figma.com/file/LglkDsGZDKMZm3XCkJPhfR/SimpleReport-2023%2B?type=design&node-id=2744%3A10186&mode=design&t=X23rvIIgEoXosQHI-1
Figma - unknown phone number active state - https://www.figma.com/file/LglkDsGZDKMZm3XCkJPhfR/SimpleReport-2023%2B?type=design&node-id=2744%3A10649&mode=design&t=X23rvIIgEoXosQHI-1
Figma - unknown address active state - https://www.figma.com/file/LglkDsGZDKMZm3XCkJPhfR/SimpleReport-2023%2B?type=design&node-id=2744%3A11116&mode=design&t=X23rvIIgEoXosQHI-1
Copy:
Headers: Phone, Email, Address
Phone number unknown for phone checkbox
Address unknown or patient unhoused for address checkbox
Notes:

This is just for the single entry workflow, bulk upload will be in a separate ticket
Miscellaneous note field will be in a separate ticket.

Acceptance criteria

Add headers (H4) for phone, email, and address sections of the contact info (per figma design)
For address and phone number fields (except county), user can check a box to indicate that address and/or phone is unknown. When they do so, fields in that section disappear (and will reappear if box is unchecked)(including phone/text preferences)
Follow RS HL7 guidance to complete these fields - https://docs.google.com/spreadsheets/d/1sSpDeKQdackzRS5IT58WmUWn1eq6pA1Rm57u0C5QpgM/edit?usp=sharing
For street: populate with " ** Unknown / Not Given **
For city, state, zip code, phone: populate with ordering facility information, generate county from that information (how we're handling it today)

See Spanish translation attached
SimpleReport---es.docx


plate-level manual drops with 'wells' causes assertion error

I have specified a manual_drop in my config for a specific plate, which looks like this:
plate17:
   group: SCH
   date: 2024-04-11
   viral_library: H3N2_library
   neut_standard_set: loes2023
   samples_csv: data/plates/2024-04-11_neut_SCH_plate1.csv
   manual_drops:
     wells:
       - [A9]
   qc_thresholds:
     <<: *default_process_plate_qc_thresholds
   curvefit_params:
     <<: *default_process_plate_curvefit_params
   curvefit_qc:
     <<: *default_process_plate_curvefit_qc

This causes an assertion error in the following block of code in the process_plate17.ipynb notebook. I'm not sure, but I believe this is because the manual_drops dictionary requires the key wells (plural!), but the actual column in the counts file is named well (singular!).
for filter_type, filter_drops in manual_drops.items():
    print(f"\nDropping {len(filter_drops)} {filter_type} specified in manual_drops")
    assert filter_type in qc_drops
    qc_drops[filter_type].update(
        {w: "manual_drop" for w in filter_drops if not isinstance(w, list)}
    )
    if filter_type == "barcode_wells":
        counts = counts[
            ~counts.assign(
                barcode_well=lambda x: x.apply(
                    lambda r: (r["barcode"], r["well"]), axis=1
                )
            )["barcode_well"].isin(qc_drops[filter_type])
        ]
    elif filter_type == "barcode_serum_replicates":
        counts = counts[
            ~counts.assign(
                barcode_serum_replicate=lambda x: x.apply(
                    lambda r: (r["barcode"], r["serum_replicate"]), axis=1
                )
            )["barcode_serum_replicate"].isin(qc_drops[filter_type])
        ]
    else:
        assert filter_type in set(counts.columns)
        counts = counts[~counts[filter_type].isin(qc_drops[filter_type])]
------------------

----- stdout -----

Dropping 1 wells specified in manual_drops
------------------

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
Cell In[7], line 24
     16     counts = counts[
     17         ~counts.assign(
     18             barcode_serum_replicate=lambda x: x.apply(
   (...)
     21         )["barcode_serum_replicate"].isin(qc_drops[filter_type])
     22     ]
     23 else:
---> 24     assert filter_type in set(counts.columns)
     25     counts = counts[~counts[filter_type].isin(qc_drops[filter_type])]

In this case, this issue could be resolved by adding another elif statement to the same cell, something like:
    elif filter_type == "wells":
        counts = counts[
            ["well"].isin(qc_drops[filter_type])
        ]

Happy to try to tackle this @jbloom, unless you'd prefer to look at it!

@ckikawa, I think your diagnosis of the problem appears correct, but I think wouldn't a better solution just to be to re-define the relevant key of under manual_drops in the config to be well rather than wells?
That solution would not require changing code (just documentation), and would make it cleaner.
Also, this would not really be a backward-incompatible change as given the problem you identified, no one must be using wells right now or they would be getting the same error.
So I would suggest testing if you can fix this by just updating wells to well in the YAML configuration, and if that works just do a pull request fixing the documentation here rather than changing the code.

@jbloom, unfortunately just changing at the level of the config will not work because of this block of code, also in process_plate.ipynb. When I run with manual_drops key well instead of wells, an error is given:
qc_drops = {
    "wells": {},
    "barcodes": {},
    "barcode_wells": {},
    "barcode_serum_replicates": {},
    "serum_replicates": {},
}

assert set(manual_drops).issubset(
    qc_drops
), f"{manual_drops.keys()=}, {qc_drops.keys()}"

The dictionary qc_drops is also used throughout the notebook to add wells, barcodes etc. failing default QC parameters.
So, I think the solution could be either:

Adding an elif statement similar to the one I wrote above
Changing the dictionary qc_drops key from wells to well, which would also require small changes in other cells in the process_plate.ipynb where wells is keyed

OK, in that case I would say go ahead and make the change you suggest as a pull request. Does a similar change need to be made for the barcodes drop?

Yes, I think so since qc_drops specifies barcodes but the counts dataframe column is named barcode. I'll do a similar fix for that.


Support passing in additional arbitrary files

Creating this issue on behalf of @fdecampredon
We should be able to manually add additional files to the TypeScript compiler. This is roughly equivalent to passing multiple files to the tsc command.

@fdecampredon Check out the additionalFiles test. Does this satisfy what you're looking for?

Yup sure pretty cool thanks :)

Published in v0.3.2


redesigned the home-page in index.html and added some more higher qua…

…lity movie posters
Issue Number
fixes #316

Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
Additional context (OPTIONAL)
Add any other context or screenshots about the feature request here.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[ ] I have added my name in the contributors list at the end of README.md file.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] The title of my pull request is a short description of the requested changes.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@Godwindaniel10 I think you are not aware of the updated website.
Review your changes and make PR only for the related issue.

Hi @QAZIMAAZARSHAD , ok but you said index.html file.

Hi @QAZIMAAZARSHAD , ok but you said index.html file.

That was before the update, a landing page is now index.html and the homepage is home.html.
Always keep yourself updated.

Right

@QAZIMAAZARSHAD i will update and fix the issue .


Error

[code]
I'm sorry, but errors were detected in your script. Please correct the
errors listed below, and try again.
File "game/mas-saysomething-master/mod/screen.rpy", line 688: u'released' is not a keyword argument or valid child for the bar statement.
released Return(_fom_saysomething.RETURN_RENDER)
^
Ren'Py Version: Ren'Py <IP_ADDRESS>.2187
[/code]

have fixed it


The -moz-selection pseudoelement is now unneeded

Firefox 62, which will be released on September 5, has unprefixed the ::-moz-selection CSS pseudoelement. Please drop it from the style sheets once it’s released.

I think it's good to leave it be for some time for compatibility. Thanks for the heads up, will remove in the future.


fix wrong event name onorientationchange to orientationchange

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   72.53%   72.53%
=======================================
  Files           1        1
  Lines         142      142
=======================================
  Hits          103      103
  Misses         39       39

Impacted Files
Coverage Δ

src/index.js
72.53% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb8ccfc...d6659e3. Read the comment docs.

Coverage remained the same at 64.344% when pulling d6659e39264e5e761c37a10e04e76650457190a7 on gordeyev:master into bb8ccfc64dc4c5f316576319960b5e582c5a9f2a on matthewhudson:master.


Faster episode generation

Motivation and Context
Greatly speed up episode generation script. Instead of reconfiguring (resetting) sim after each episode, just remove sampled objects and reset articulated object joints.
How Has This Been Tested
Run habitat-lab/habitat/datasets/rearrange/run_episode_generator.py with the new floorplanner config (habitat-lab/habitat/datasets/rearrange/configs/rearrange_floorplanner.yaml) and ensure sampled objects are gone at the start of each episode generation.
Types of changes

Docs change / refactoring / dependency upgrade

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Once pre-commit and lint tests pass LGTM if the episodes are still generating correctly.


e2e windows tests report success even when e2e tests fail #698

Signed-off-by: Paul Bastide<EMAIL_ADDRESS>

Please note this PR intentionally FAILS a test.
Once the failure is complete, the FAILED test is to be reverted.

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----         3/4/2020   3:44 PM                pre-it-logs
The fhir-server is apparently running
Performing Tests
[Tests] --> Exit Code is 1
Exiting with Error Condition

Result is Exit Code 1


Appstudio update test-custom-default-branch-uaja

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-lqle-on-pull-request-
creating pipelinerun test-simple-build-lqle-on-pull-request- in namespace build-e2e-ctnb-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mijr-on-pull-request-
creating pipelinerun test-annotations-mijr-on-pull-request- in namespace build-e2e-ctnb-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nyrh-on-pull-request-
creating pipelinerun test-simple-build-nyrh-on-pull-request- in namespace build-e2e-ctnb-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-nwtb-on-pull-request-
creating pipelinerun test-simple-build-nwtb-on-pull-request- in namespace build-e2e-ctnb-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-simple-build-imul-on-pull-request-
creating pipelinerun test-simple-build-imul-on-pull-request- in namespace build-e2e-ctnb-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Submit HTTP POST example has an error in URL

Hello there,
There is an extra slash after location in the example provided here that leads to an error message:
curl -X POST 'https:///.monitoring.azure.com/metrics'
-H 'Content-Type: application/json'
-H 'Authorization: Bearer '
-d @custommetric.json
Thanks,
Luis

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e3284cd7-9477-14ac-7f6e-9fcfa31f8de1

Version Independent ID: 73812858-f1c5-f8a0-bdc5-7de0ec9541e5

Content: Send metrics to the Azure Monitor metric database by using a REST API - Azure Monitor

Content Source: articles/azure-monitor/essentials/metrics-store-custom-rest-api.md

Service: azure-monitor

Sub-service: essentials

GitHub Login: @EdB-MSFT

Microsoft Alias: edbaynash

@Shamhain Thanks for your comment! We will review and provide an update as appropriate.

@Shamhain We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


More constructions of free commutative monoids

Close #54

This PList looks good to me, might be worth doing another version with the comm relation.
This makes me think if you can abstract out both permutation relations, and define PList for an arbitrary relation with the properties that you need to prove freeness. The harder thing to prove would be, PList is free iff the permutation relation satisfies these properties.

This PList looks good to me, might be worth doing another version with the comm relation.
This makes me think if you can abstract out both permutation relations, and define PList for an arbitrary relation with the properties that you need to prove freeness. The harder thing to prove would be, PList is free iff the permutation relation satisfies these properties.

This should be doable, I'll give it a try after I'm done with the analytic functor definition

Found out Free's type levels are wrong (some type levels that should've been different were the same) while working on QFreeMon, might worth taking a look


DRAFT: Admin Page Refactor

A short refactor seperating the admin page into manageable chunks.
CC @NathanielB123

Temporarily reverting so we can merge the other PRs first


initial implementation of caching for server groups

added caching for server groups plus minor fixes

@JargoonPard  @milismsft  PTAL


Any documentation on use

The shell script just displays everything. Did you intend to build an installer? or is there any documentation you can provide?

The shell script is a readme that provides detailed command line instructions and documentation. The process of building an OpenVPN server involves several steps, some fragile, that aren't handled well by an autoinstaller—setting up a pf firewall specific to your network, creating password protected TLS CA and certificates, emailing certs, uploading stuff in iTunes, and so forth. You're much better off reading the documentation in the shell script and understanding the setup as you'll be the one maintaining it and establishing its security.


Add COMPRESSION as a Keyword

The Datafusion recently supports a new SQL syntax COMPRESSION TYPE: https://github.com/apache/arrow-datafusion/issues/3641
However, the word COMPRESSION is not a Keyword recently. I want to add it as a Keyword so that we can parse this syntax in Datafusion easily: https://github.com/apache/arrow-datafusion/issues/4262

@HaoYang670 created a PR for this: https://github.com/sqlparser-rs/sqlparser-rs/pull/720


RankVicuna dl19/dl20 Experiments Repro Doc - Improved Version

PR for RankVicuna dl19/dl20 Experiments Repro Doc.
Fixed typos and added more details, along with reference to the research paper.
Once the top-20/100 dl-19/20 experiments with the quantized model are done, I can add those numbers in the doc as well along with repro scripts for them.

Closing for 2CR page and modified docs


“Disable Auto Updates” toggle works the other way around

Describe the bug
When you toggle ON “Disable Auto Updates”, iOS is able to check for updates.
When you toggle OFF “Disable Auto Updates”, iOS cannot check for updates.
To Reproduce
Steps to reproduce the behavior:

Go to Settings icon of unc0ver
Toggle ON/OFF “Disable Auto Updates”

Screenshots
TOGGLED OFF:

TOGGLED ON

Device (please complete the following information):

iOS Version: 13.5
iOS Device: iPhone 11 Pro Max
unc0ver Version: 5.0.1

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

You're right (I just tried it) ! I would never notice it, glad you did.

Haha this is why I couldn’t ota update from iOS 12.2 to iOS 13.5

OTA update check doesn't work for me anymore.
I see Unable to Check for Update all the time despite of toggle check and RootFS restoring.

Confirmed !

Is there anyway to reenable auto updates without uncover? My device is unjailbroken now and stuck on iOS 13.5.1.

full restore will do it


fix doctest and run tests in CI

While working on another change I noticed that this test was failing. It wasn't caught because it doesn't run in CI.

Thanks for the PR. Having tests in the CI is definitely a good idea but requires some extra code to get working as it run's on a server where GTK can't be initialized out of the box. But I think there are some good references like gtk-rs that got it working.

Running under xvfb seems to be enough :)

Thanks!


Tables Become Incorrectly Grouped in Meta/Dialog (Wave v0.16 --> v0.22+)

Wave SDK Version, OS
H2O Wave v0.22+ on macOS
Actual behavior
This is for Tables (ui.table) inside a Meta/Dialog. When upgrading Wave v0.16 --> v0.22+, Tables behave differently inside a Meta/Dialog when using "Group by."
(When the table is moved outside of the dialog and back to the main page/form, however, the table works as expected.)
For H2O Wave v0.22+, the issue happens when using "Group by" in a dialog table, selecting a group, and doing an action on it.
For example, in screenshot 1 below, I've Grouped by the column "Group" and selected the top group "Tap".

When I do an action (with a bottom white button), the items get jumbled so the grouping becomes incorrect. See how items under "Tap" have changed and were incorrectly placed there in screenshot 2 below:

It only happens when using "Group by," so when selecting normally without the grouping, there's no such issue.
Expected behavior
In Wave v0.16.0, the table used to be reset automatically and ungrouped, so there'd be no inconsistencies like this as shown below:
Wave v0.16.0 - Using "Group by" in a table, selecting a group, and doing an action on it:

Wave v0.16.0 - The result after the action is that the table would be reset automatically and ungrouped so there's no incorrect grouping:

Steps To Reproduce
Please see "Actual behavior" above.

Thanks for reporting @chelseanbr! @marek-mihok please have a look at this once you have time.


python310Packages.zwave-me-ws: 0.3.6 -> 0.4.2

Diff: https://github.com/Z-Wave-Me/zwave-me-ws/compare/refs/tags/v0.3.6...v0.4.2
Changelog: https://github.com/Z-Wave-Me/zwave-me-ws/releases/tag/v0.4.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 225387 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.zwave_me
python310Packages.zwave-me-ws
python310Packages.zwave-me-ws.dist
python311Packages.zwave-me-ws
python311Packages.zwave-me-ws.dist

Result of nixpkgs-review pr 225387 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.zwave_me
python310Packages.zwave-me-ws
python311Packages.zwave-me-ws


Problems with --all

Background
I'm using TypeScript with Jasmine. The only way I figured out how to get nyc to work with Jasmine was to point Jasmine at the transpiled tests. Using sourceMap, the coverage report looks good until I add "all: true" in my nyc config.
Tests are run using npm test which runs nyc jasmine. The nyc config in package.json looks like:
  "nyc": {
    "all": true,
    "extension": [
      ".ts"
    ],
    "include": [
      "dist/src/**/*"
    ]
  }

Expected Behavior
I would expect both the files loaded in tests and the files without any coverage to be mapped to their TypeScript source.
Observed Behavior
The files which aren't loaded by tests report their JS versions instead of the TS versions I'd expect. The files being loaded in tests still report against the TS version.
Bonus Points! Code (or Repository) that Reproduces Issue
I can't share the repo, but if this is being a problem to recreate I could create a dummy repo with the same setup.
Forensic Information
Operating System: Ubuntu 16.04
Environment Information:
sh -c 'node --version; npm --version; npm ls' > output.txt
https://gist.github.com/marshmellow1328/b086ec34ac8ea8521c23bed60ed59329

Bump up!

@marshmellow1328 Try to change included folder from "dist/src/**/*" to **/dist/src/** and leave the same configuration.
Here is my config that works fine for me. *But I have an assumption that all you need to do is change the path in include
  "nyc": {
    "include": [
      "**/shared/**"
    ],
    "all": false,
    "cache": true,
    "sourceMap": false,
    "instrument": false,
    "require": [
      "babel-register"
    ],
    "report-dir": "./tests-report",
    "reporter": [
      "html",
      "lcov",
      "text"
    ]
  }

"Problems with --all" is a bit vague but I'm having a similar issue.
I have the following mocha.opts:
--ui tdd
--recursive
--compilers ts:ts-node/register
--timeout 5000

The following options for nyc in package.json:
  "nyc": {
    "extension": [
      ".ts",
      ".tsx"
    ],
    "exclude": [
      "build/**",
      "test/**/*.ts",
      "**/*.d.ts"
    ],
    "all": true
  },

I run ./node_modules/.bin/nyc mocha ./test/unit and unfortunately the all doesn't seem to work with the defined extensions (.ts and .tsx). I currently have a couple of .ts files in my ./src/ directory that I expect should show up with 0% coverage.

@sgronblo @sublimeye @marshmellow1328 sorry for the slow reply, have been dealing with some personal issues and have been an abysmal OSS maintainer the past few months.
For starters, I would make sure that you configure it so nyc requires ts:ts-node/register rather than mocha; you can do this using nyc's require configuration; this way --all will properly understand TypeScript syntax.
Otherwise, perhaps @JaKXz can chime in who's done more work with TypeScript than myself.

currently I'm able to run ts-node/register on mocha level rather than with nyc (as otherwise running pure mocha without nyc won't work).
see also:
https://github.com/istanbuljs/nyc/issues/618
https://github.com/istanbuljs/nyc/issues/610

@ciekawy --all  will not work properly if   ts-node/register is required at the mocha level rather than the nyc level, because when nyc requires files it won't understand the TypeScript syntax.
This might be a good starting point for debugging your projects, if you're finding you're unable to have nyc instrument the require statement.

@ciekawy @bcoe could you share your set up for ts/node/register. I'm getting empty coverage using --all and the tool works randomly in different machines using the same set up.

@mohsen1 do you still have a functional configuration that works with --all that you could share?
Is this tutorial up to date? there have been a few modifications around how we resolve sourcemaps, and I'm wondering if we might have broken anything.

as mentioned https://github.com/istanbuljs/nyc/issues/610#issuecomment-319097645 the key change for me was to use ES5 target. To do it just for test I'm using
TS_NODE_COMPILER_OPTIONS='{"rootDir": "./", "target":"es6"}' nyc npm run test:unit

We're experiencing a similar issue. When adding "all": true to our .nycrc, code coverage report generation exhibits non-deterministic behavior - sometimes it reports the correct numbers and correct source mappings, sometimes numbers and source mappings are off, roughly in 50% of the cases.
Sometimes it's correct:

... and sometimes it's wrong:

While some files that have 100% coverage suddenly start reporting lower coverage values and wrong source mappings, other files that are part of the report still report correct numbers and source mappings. When we remove "all": true, coverage reports are correct 100% of the time. This is how we invoke our tests (TypeScript):
$(npm bin)/nyc $(npm bin)/ts-node --require tsconfig-paths/register tests/index.ts

Our current "solution" is to remove "all": true.

Why has it been closed? Was it ever fixed?

It was originally closed by the stale bot which was initially a bit aggressive.  That said I believe the issue with --all is fixed in nyc 15 (currently in beta).  See #1104 for information about the new release.

No matter what, current latest version of nyc: 14.1.1  always displays my test coverage for my jasmine tests for compiled typescript:
Executed 178 of 178 specs SUCCESS in 3 secs.
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |      100 |      100 |      100 |      100 |                   |
 test.js  |      100 |      100 |      100 |      100 |                   |
----------|----------|----------|----------|----------|-------------------|

<EMAIL_ADDRESS>posttest my-fs-location nyc report -e .ts --reporter=text-summary

==== Coverage summary ===========

 Statements   : 100% ( 9/9 )
 Branches     : 100% ( 0/0 )
 Functions    : 100% ( 0/0 )
 Lines        : 100% ( 9/9 )

 ==============================

That above test.js is my jasmine configuration. This project has istanbul test coverage

Changed or modified or added all the below .nycrc configuration
Took entire .nycrc to package.json
Added or removed or changed values of cahce, all, sourceMap, instrument, temp-dir and extension
I feel .nycrc is not at all considering by both 15.0.0-beta and 14.1.1 versions. Cause I need to provide -e , -X --report, --reporter in npm commands. If not, report and coverage not genrating with .nycrc

And this is how my .nycrc file looks
{
  "nyc": {
    "extends": "@istanbuljs/nyc-config-typescript",
    "require": ["ts-node/register"],
    "check-coverage": true,
    "all": true,
    "cache": false,
    "extension": [".ts"],
    "exclude": ["testing/**", "bin.js", "build/testing/**", "node_modules/**", "coverage",  "newrelic.js",  "**/*.d.ts, **/*.spec.ts"],
    "include": ["app/**", "bin/**"],
    "reporter": ["lcov", "text"],
    "sourceMap": true,
    "instrument": true,
    "temp-dir": "./coverage/.nyc_output"
  }
}

But with just adding nyc:15.0.0-beta, somehow generated terminal report (not coverage report of coverage/coverage/index.html)  looks like satisfying ancient  istanbul way of terminal report
Executed 178 of 178 specs SUCCESS in 3 secs.
---------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
File                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
All files                  |   82.57 |     65.9 |   73.71 |   81.97 |
 app                       |   96.51 |       75 |   94.12 |    96.1 |
  app.ts                   |   95.59 |       75 |   94.12 |   95.45 | 54,116,128
  index.ts                 |     100 |      100 |     100 |     100 |
 app/common                |   88.91 |    68.06 |    87.5 |   88.54 |
  agent.ts                 |     100 |      100 |     100 |     100 |
  config.ts                |     100 |      100 |     100 |     100 |
  context.ts               |   86.39 |    66.67 |   81.25 |      86 | 88,125,127,128,129,158,159,160,177,179,181,184,238,264,272,291,362,363,365,366,371
  date.ts                  |     100 |      100 |     100 |     100 |
  environment.ts           |     100 |      100 |     100 |     100 |
  globalKey.ts             |     100 |      100 |     100 |     100 |
  index.ts                 |     100 |      100 |     100 |     100 |
  jwt.ts                   |   95.16 |    85.19 |      96 |   94.64 | 97,125,142
  log.ts                   |   73.86 |    39.47 |   76.67 |   73.26 | 33,34,35,36,38,39,40,41,42,43,44,48,57,80,81,82,83,140,141,143,180,192,195
  status.ts                |     100 |      100 |     100 |     100 |
  tenant.ts                |     100 |       75 |     100 |     100 | 44,48,77
 app/common/cache          |   98.39 |      100 |   95.65 |   98.15 |
  app.ts                   |   98.15 |      100 |   95.45 |   97.83 | 65
  index.ts                 |     100 |      100 |     100 |     100 |
  types.ts                 |     100 |      100 |     100 |     100 |
 app/common/cache/adapter  |     100 |       80 |     100 |     100 |
  abstract.ts              |     100 |      100 |     100 |     100 |
  index.ts                 |     100 |      100 |     100 |     100 |
  lru.ts                   |     100 |       80 |     100 |     100 | 9
 app/common/error          |   98.86 |       50 |   88.89 |   98.39 |
  context-error.ts         |     100 |      100 |     100 |     100 |
  error.ts                 |     100 |       70 |     100 |     100 | 4,5
  index.ts                 |     100 |      100 |     100 |     100 |
  jwt-error.ts             |     100 |      100 |     100 |     100 |
  middleware-error.ts      |     100 |      100 |     100 |     100 |
  nephos-error.ts          |     100 |      100 |     100 |     100 |
  unknown-error.ts         |     100 |      100 |     100 |     100 |
  utility-error.ts         |   90.91 |        0 |      50 |   88.89 | 12
 app/common/middleware     |   81.14 |    66.32 |   77.88 |   81.14 |
  debug.ts                 |      90 |       75 |     100 |    87.5 | 8
  health.ts                |     100 |       75 |     100 |     100 | 7
  index.ts                 |     100 |      100 |     100 |     100 |
  middleware.ts            |     100 |      100 |     100 |     100 |
  parsers.ts               |     100 |       50 |     100 |     100 | 8,14
  preview.ts               |   95.65 |       50 |      80 |   95.24 | 14
  route-security.ts        |     100 |      100 |     100 |     100 |
  rtm.ts                   |     100 |      100 |     100 |     100 |
  security.ts              |     100 |    71.43 |     100 |     100 | 19,23,33,41
  tenant.ts                |   97.78 |    84.62 |     100 |   97.56 | 59
  token.ts                 |   70.68 |    63.27 |   69.01 |   71.28 | ...,175,176,180,205,272,290,292,293,294,302,303,304,305,306,309,311,312,313,315,317,318,319,321,324,325,326,327,328,329,332,337,339,342,356,357,358,361,362,363,377,382,383,418,419,420,421,450,451,452,453,454,455,456,457,458,459,460,462,464,466,468,469,470,472,479,480,494,495,497,558,665,679
 app/common/nephos         |   94.12 |    76.03 |    87.5 |   93.81 |
  auth.ts                  |   94.79 |    79.07 |   92.31 |   94.74 | 173,174,182,184,257
  index.ts                 |     100 |      100 |     100 |     100 |
  jwt.ts                   |   92.31 |       50 |     100 |   91.67 | 61
  service.ts               |   93.33 |    72.41 |   83.33 |   92.86 | 80,91,92,94,95,195,203
 app/common/nephos/svc     |   69.73 |    55.56 |   53.23 |   68.82 |
  account.ts               |   58.18 |    29.41 |   53.85 |      60 | 43,44,45,46,49,67,68,69,102,116,117,118,151,164,165,178,179,192,193,195
  cart.ts                  |     100 |       75 |     100 |     100 | 15
  content.ts               |   68.42 |       50 |   66.67 |   64.71 | 32,33,39,43,44,52
  index.ts                 |     100 |      100 |     100 |     100 |
  paidProgram.ts           |   76.92 |       75 |      75 |   72.73 | 31,32,33
  permission.ts            |   66.67 |       50 |      50 |   63.16 | 40,56,57,58,74,75,77
  session-ipa.ts           |   72.13 |       75 |   41.38 |   71.19 | 64,88,92,95,105,111,112,116,120,124,128,134,135,139,143,144,154
 app/common/nephos/utility |   65.42 |    60.09 |    58.7 |   64.38 |
  cache.ts                 |   49.09 |    41.46 |   47.06 |      48 | ...,117,127,130,131,132,134,135,136,137,160,168,169,170,171,193,194,196,197,200,201,203,204,207,208,210,211,212,217,218,220,221,246,248,250,263,266,267,269,270,291,293,300,317,318,323,324,325,331,340,342,344,347,348,350,351,355,366,368,370,371,372,373,375,378,396,399,400,401,402,403,404,406
  custom-message.ts        |   58.82 |    33.33 |    37.5 |      60 | 28,40,41,42,43,45
  custom-node-common.ts    |   85.29 |    72.59 |   81.82 |   83.87 | 45,71,152,160,195,196,197,210,212,213,214,216,217,222,224,237,249,270,272,274
  index.ts                 |     100 |      100 |     100 |     100 |
 app/init                  |   83.33 |       75 |   66.67 |   82.76 |
  process.ts               |   76.19 |       75 |   66.67 |      75 | 17,18,23,24,36
  startup.ts               |     100 |      100 |     100 |     100 |
 app/lib                   |     100 |      100 |     100 |     100 |
  basic-auth.ts            |     100 |      100 |     100 |     100 |
  body-parser.ts           |     100 |      100 |     100 |     100 |
  bunyan.ts                |     100 |      100 |     100 |     100 |
  cookie-parser.ts         |     100 |      100 |     100 |     100 |
  crypto.ts                |     100 |      100 |     100 |     100 |
  csurf.ts                 |     100 |      100 |     100 |     100 |
  express.ts               |     100 |      100 |     100 |     100 |
  helmet.ts                |     100 |      100 |     100 |     100 |
  jsonwebtoken.ts          |     100 |      100 |     100 |     100 |
  lodash.ts                |     100 |      100 |     100 |     100 |
  lru-cache.ts             |     100 |      100 |     100 |     100 |
  moment.ts                |     100 |      100 |     100 |     100 |
  morgan.ts                |     100 |      100 |     100 |     100 |
  nconf.ts                 |     100 |      100 |     100 |     100 |
  newrelic.ts              |     100 |      100 |     100 |     100 |
  prom-client.ts           |     100 |      100 |     100 |     100 |
  request.ts               |     100 |      100 |     100 |     100 |
  statuses.ts              |     100 |      100 |     100 |     100 |
  useragent.ts             |     100 |      100 |     100 |     100 |
  uuid.ts                  |     100 |      100 |     100 |     100 |
 bin                       |   66.67 |      100 |       0 |   66.67 |
  index.ts                 |   66.67 |      100 |       0 |   66.67 | 15,16,18,20,22,47,48
 bin/helpers               |   52.17 |       25 |    12.5 |   51.11 |
  cleanup.ts               |   42.86 |        0 |       0 |   42.86 | 6,7,8,9
  docker.ts                |      60 |        0 |      25 |   55.56 | 9,10,11,15
  rollup.ts                |   68.75 |      100 |       0 |   68.75 | 57,58,63,64,65
  token.ts                 |   30.77 |       50 |   16.67 |   30.77 | 12,13,14,15,17,18,19,20,21
---------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

><EMAIL_ADDRESS>posttest /Users/jujha001/Documents/staples/projects/platform-common/node-common
> nyc report -e .ts  -x "**/*.spec.ts" --reporter=text-summary

=============================== Coverage summary ===============================
Statements   : 82.64% ( 1738/2103 )
Branches     : 65.98% ( 636/964 )
Functions    : 73.93% ( 397/537 )
Lines        : 82.05% ( 1582/1928 )
================================================================================

Again coverage/Icov-report/index.html is not generating html coverage with 15.0.0

@coreyfarrell : I hope you have a solution for this. If not, please consider my use case for 15  release.
My Environment:

Node: v10.16.3
npm: 6.13.1
OS: macOS Mojave (10.14.6)

@hari-007 On quick look at what you've posted .nycrc should not have settings in an nyc key.  The following in how .nycrc would need to be written to enable all:
{
  "all": true
}

Beyond this please open a new issue including all required information.  Given limited time of maintainers smaller reproduction repositories will get looked at faster than a large repository.


[Bug]: use aria-hidden="true", not aria-hidden=""

Environment
Developement/Production OS: linux
Node version: 20.16.0
Package manager<EMAIL_ADDRESS>Radix Vue version: 1.9.3
Vue version: 3.4.37
Nuxt version: 3.12.4
CSS framework<EMAIL_ADDRESS>Client OS: linux
Browser: firefox

Link to minimal reproduction
https://github.com/stefanprobst/issue-shadcn-vue-checkbox
Steps to reproduce

clone repo, pnpm install, pnpm run dev
inspect checkbox in accessibility devtools

Describe the bug
aria-hidden="" does not actually hide the element. when inspecting the <input type="checkbox"> in devtools, you will see two elements with role=checkbox, the <button role="checkbox"> and the <input type="checkbox" aria-hidden="">:

when setting aria-hidden="true" on the input element, you will see:

Expected behavior
No response
Context & Screenshots (if applicable)
the repro is for checkbox, but there may be other components affected as well.

Hi! After the last update I get this error in the console when I try to use the Combobox

Blocked aria-hidden on a  element because the element that just received focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden. <input type="text" aria-expanded="true" aria-controls="radix-vue-combobox-content-1" aria-disabled="false" aria-autocomplete="list" role="combobox" autocomplete="false" class="ComboboxInput" placeholder="Placeholder..." value aria-activedescendant="radix-vue-combobox-option-4">

Thanks @maxmaxme ! I realized this issue too! Will push a fix soon!


remove zarc dependency in favor of powershell

We can remove the zarc dependency (I no longer need to maintain it) by leveraging powershell, however, this appears to be ungodly slow.  7 times slower on the CI (test took 14 minutes instead of 2).  It looks like this is a longtime known issue: https://github.com/PowerShell/Microsoft.PowerShell.Archive/issues/32
Another option would be to use System.IO.Compression.ZipFile from the .NET runtime with a fallback to powershell, this is what goto-bus-stop/setup-zig does, i.e.
> "C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.ZipFile } catch { } ; try { [System.IO.Compression.ZipFile]::ExtractToDirectory('D:\a\_temp\0cb5b10f-ac04-4c24-b695-a765775d31fa', 'D:\a\_temp\245aed94-f57d-47db-8abe-29f7e193e5d6', $true) } catch { if (($_.Exception.GetType().FullName -eq 'System.Management.Automation.MethodException') -or ($_.Exception.GetType().FullName -eq 'System.Management.Automation.RuntimeException') ){ Expand-Archive -LiteralPath 'D:\a\_temp\0cb5b10f-ac04-4c24-b695-a765775d31fa' -DestinationPath 'D:\a\_temp\245aed94-f57d-47db-8abe-29f7e193e5d6' -Force } else { throw $_ } } ;"

see extractZip function in https://raw.githubusercontent.com/goto-bus-stop/setup-zig/default/dist/index.js

Extraction Performance for zig-windows-x86_64-0.12.0-dev.140+e078324db.zip (running on spinning hard disk):

7Zip: 20 seconds
zarc: 40 seconds
.NET System.IO.Compression.ZipFile::ExtracttoDirectory: 2 minutes
Builtin "Right Click -> Extract All" from explorer: 4 minutes


Add d tmp-context args

d tmp-context sentry d make traefik config

The args d make traefik config should be passed to a new sub-shell with DOCKER_CONTEXT=sentry set.
If no args are specified d tmp-context should show the current menu it already does.

this should also work:
d tmp-context sentry docker ps


Update systest dependencies

Updates the systest crate's dependencies.
libc was updated from 0.1 to 0.2, and ctest was set to version 0.1

Thanks!


Allow lavinmq to be used as a dependency

Shards didn't accept the version format and pinning against a branch, even if it's the default, results in version conflicts for the same dependency is used in the project dependent on lavinmq.
This enables lavinmq to be used as a dependency.

Interesting, where are you using lavinmq as a dependency? Have to check that the way we generate tags, version number for containers, deb and RPM packages are compatible with this format.

When 1.0.0 is released (any day now) this will be resolved, so closing this PR.


Getting started - narrow horizontal space - step preview appears on top which is confusing

Testing #125014
Pls see the screenshot below. Showing the step details at the bottom could be more natural

Yeah, having it stacked like this -- makes it quite hard to understand what you are doing -- because the context of the top part if below it.

Maybe that section should always have some text saying that you should select a layout?

@JacksonKearl already made the change to move this to the bottom:


ART is slow when a new piece is appended to a drawing that has a lot of pieces

ART redraws the entire drawing each time the drawing changes. This makes ART slow when a drawing has a lot of pieces.
Consequently, ART is unsuitable for use in a drawing app. Drawings will typically have a lot of pieces and they'll need to be updated very quickly as the user adds more to the drawing. Note that in a drawing app, the user will typically be appending pieces to a drawing. ART could be enhanced to handle this scenario efficiently by only drawing the newly appended pieces rather than redrawing all of the existing pieces.
Proposal
ART should expose an API which enables it to efficiently update a drawing when the only change was that a piece was appended to it (common scenario in a drawing app).

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/art-is-slow-when-a-new-piece-is-appended-to-a-drawing-that-has-a-lot-of-pieces
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Display possibly related issues on the 'New Issue' page

A basic implementation of the feature suggested by @fenollp in #1138.
When the title input field on the New Issue page is blurred, an API request is made to fetch issues on the repository with the title as the query. The first five issues are then displayed in the sidebar.

If there are more than five, an X more results link that links to the regular issue search is added below.
Currently, the search is really basic. While StackOverflow's suggestions get more accurate as you enter more text, this search only looks for issues that contain the text in the title which is not the best way to determine whether an issue is relevant. Please let me know if you have any ideas on how the search could be improved.
Closes #1138

We should also skip short queries (length < 4) and any glue words like “a”, “the”, “and” which could limit results unnecessarily.

Could we show below "Helpful resources" so there's no jump?

@hkdobrev I tried placing it at the end of the sidebar but it's too far:

This is truly awesome, @shroudedcode! I can't believe this is not a native GitHub feature.

I tried placing it at the end of the sidebar but it's too far

When you create an issue on a repo you don't have contribution access to, you don't need the sidebar items like the assignee, label, milestone and project on the new issue form as you don't have access to set them.

Thanks @shroudedcode for doing that! 🎉

When you create an issue on a repo you don't have contribution access to, you don't need the sidebar items like the assignee, reviewers, label, milestone and project on the new issue form as you don't have access to set them.

If you don't have contribution access, your sidebar is empty, so position matters only if you're a collaborator :D

👏  thanks @shroudedcode!
@sindresorhus what do you think about including a related features list when reading an issue, also?  Could be useful for maintainers to quickly find duplicates (or just related issues that may be relevant to discussion)

@anandthakker Possibly. Can you open a new issue about it? I think we should let this feature mature for a bit first though. I'm sure it could be smarter, and getting false-positives is a lot more annoying when reading issues than when writing.

I find that recently (presumably since this landed), typing in the title area is not very responsive. Is this being sufficiently throttled (and is anyone else having this problem)?

Definitely not the case; it does not update while typing but only when you leave the field (blur event)

Ah, must be something else then, thanks!


add standard devdependency. standardize all the things. add npm test script.

standardized.

niiiiiice! awesome @sethvincent , lgtm


Vibration level freezes

Hello
I really like your app, its easy to use and simple to understand. I did see on the buttplug.io discord that a bunch of people didn't understand to enable the device. This also had me confused for a bit. Perhaps changing the button so its more visible.
The current issue I have is that after a few moments and particularly when any audio is loud. The vibration level freeze and the device becomes unresponsive to the program. I have tested this both with a hush and xbox wired controller, both froze at the same time.  The vibration stop once the program is closed and reopened. I am using the newest .exe file.
OS: Win 11
CPU: i5-12600k
GPU: GTX 1070
RAM: 32GB
Thanks

I've just released update that makes "Enable" button more visible, thanks for the tip.
About the issue: does the program also becomes unresponsive? if not, does clicking "stop all devices" in top-right corner do anything?

Hi @Shadlock0133, although @Cazhary hasn't replied I've encountered a similiar if not the same issue infrequently and would like to help diagnose and resolve it if I can.
Assuming it's the same issue, the program remains active and seems to think it's still connected to the device but any changes don't affect the vibration. Hitting "stop all devices" appears to do nothing - ie the device still appears in the window enabled.

@Jyrdesh can you reproduce it reliably? if possible, could you recode video of that happening?

Record it happening? I normally charge people to see me use my vibe :P (sorry, I couldn't resist making a joke out of that)
https://github.com/Shadlock0133/music-vibes/assets/91008430/577f67f8-3900-4a15-9c9d-fe9081c3282e
I popped a green/red square to indicate when the device's vibe level freeze - green means all good. Red vibe level frozen. I'm afraid it based on my human ability to check when it happens so I might have been slow to recognise it occuring

I know this is an old thread, but I have a similar problem and thought I'd comment. I too have issues with the devices no longer responding, but rather than being frozen at a certain level, the devices continue to fluctuate, even when I pause the video, disable the app, or even close the app and intiface entirely.  This only seems to happen with this app, and I've found that some devices are more susceptible to this than others. I think it may be something to do with the device disconnecting and then reconnecting, as that does happen to me on occasion and also varies by device.

This is something I've run into as well. It's something I've also experienced with the underlying buttplug/intiface engine and so I suspect it may be from there. Alternatively it may be in the firmware code for the toy/device itself. However given that others are experiencing this (on I assume different devices) than it's probably the former. I have a few suspicions on what is causing it, but with little confirmation as of yet sadly.
As a very rough guess I think something of the buffer is getting "stuck" because it's not a single level that it gets stuck on but a pattern that repeats indefinitely.


Fix home page crash when translation cannot be found

Fixes https://sentry.io/organizations/wagtail-org/issues/3699443518/?project=4504043711037440
Honestly don't know why this happens as Django's get_language() function should fall back to settings.LANGUAGE_CODE, and I thought we could assume the HomePage with the default LANGUAGE_CODE (i.e. en-latest) exists. Not sure how to test it either as this doesn't seem to happen locally. I'll add another PR if I find a way to test this.

Merging this immediately as it's a fairly straightforward fix so that the site isn't down, will investigate more later.


Test.pyz executes the __main__ namespace multiple times.

If packing a file multiple times, it appears that the namespace gets added multiple times, too.

I think I fixed it?


set missing save button for configure transaction screen #5795

Fixes #5795

Force-pushed after rebase master


docker login requires running Docker daemon

It doesn't quite make sense to require a running Docker daemon if I only want to login:
# No `DOCKER_*` is set
$ docker login --email=xx --username=xx --password=xx SEVER
Cannot connect to the Docker daemon. Is the docker daemon running on this host?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

It actually makes sense if you know why this is a requirement ;)
docker login validates that the daemon can connect with the registry you're logging in to make sure it can pull and push images with your credentials.
docker version is similar, it gives you version information about the client and the server. It only displays client info when you're not connected to the server. You can use docker -v if you only want to know the version number.
Sorry, but this is the desired behavior. I'm closing this issue.
Cheers @jingweno!

@calavera Ah, gotcha! Cheers :) !


Changes to Host & Sponsor Labels for Event view

Current event view includes these three fields:

The following changes are requested:
Host should be renamed "Host Site" and should be required.
Sponsor should be renamed "Organiser" and should be required.
Membership can remain as is, and should be optional.
Note in the majority of cases, Host Site and Organiser will be the same.

@pbanaszkiewicz  @elichad  We had a PR come in for this that has been sitting idle.  Should we have merged it? Is there anything else to do?

@maneesha I thought I had reviewed that PR and it had required some improvements. I can't see my comments now, so I guess I'll mark it with v4.2 and review and fix when we start working on v4.2 release.


Corrected send on behalf in line 28

Closes #618

@MikePlumleyMSFT -  PR is ready for final review which is based on issue #618. This is just a typo issue.
Thank you.


Multi-arch support packages

Description
Change the generated index.html file to contain links for s390x and ppc64le support-packages.
Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Testing Performed

[ ] Test both CPaaS and regular support-packages are properly added to the index.html file

This is what the support-package page will look like once multi-arch is added

The full collector build in the CPaaS workflow is failing because of missing downstream drivers, this unrelated to these changes.
Other than that, we still need to figure whether the buckets that are being used to push the drivers and support packages are OK, but since that can be adjusted under .github/workflows/init.yml, we can probably go ahead and start reviewing the PR.

@robbycochran this is how I got CI configured to push to GCP once the PR is merged:
drivers
 |-> upstream       -> collector-modules-osci/
 |-> downstream
      |->   x86_64  -> collector-modules-osci/cpaas/x86_64/
      |->    s390x  -> collector-modules-osci/cpaas/s390x/
      |->  ppc64le  -> collector-modules-osci/cpaas/ppc64le/

support-packages
 |-> upstream       -> sr-roxc/collector/support-packages/x86_64/
 |-> downstream
 |    |->   x86_64  -> *Not pushed*
 |    |->    s390x  -> sr-roxc/collector/support-packages/s390x/
 |    |->  ppc64le  -> sr-roxc/collector/support-packages/ppc64le/
 |-> index.html     -> sr-roxc/collector/support-packages/index.html

support-packages Public
 |-> upstream       -> collector-support-public/offline/v1/support-packages/x86_64/
 |-> downstream
 |    |->   x86_64  -> *Not pushed*
 |    |->    s390x  -> collector-support-public/offline/v1/support-packages/s390x/
 |    |->  ppc64le  -> collector-support-public/offline/v1/support-packages/ppc64le/
 |-> index.html     -> collector-support-public/offline/v1/support-packages/index.html

We would need to mirror the drivers in collector-modules-osci/, collector-modules-osci/cpaas/s390x/ and collector-modules-osci/cpaas/ppc64le/ to the bucket collector downloads directly at runtime for them to be made accessible with no further changes to the collector code. I realize mirroring just the files in collector-modules-osci/ and not the ones in collector-modules-osci/cpaas/x86_64/ might be tricky, so if you'd like me to set them up in separate buckets, please let me know.
In addition to the drivers, we need to make sure the proxy that server support-packages from https://cdn.stackrox.io/collector/support-packages/index.html allows us to reach files in subdirectories to the one we are currently using, since the support-packages are uploaded that way based on architecture.


npm install expo - can't start project?

Hey so downloading the project won't get past stage 1, npm install expo.
Below is the read out, any ideas?
npm install expo
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@react-native-community/slider
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/expo-video-player
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/charles.m/.npm/_logs/2023-03-13T14_34_08_182Z-eresolve-report.txt
npm ERR!      /Users/charles.m/.npm/_logs/2023-03-13T14_34_08_182Z-debug-0.log

Anyone know if this project is still working in 2023 and if its maintained to get up and running?

Did you managed to solve it?