vanilla pivpn lan and internet doesnt work

In raising this issue, I confirm the following:

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[?] The issue I am reporting can be is directly related to the pivpn installer script.
[x] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Issue
I installed pivpn successfully and can connect to it but lan/internet doesn't seem reachable as soon as I do. I tried accessing the router/google and they both don't load.
Have you searched for similar issues and solutions?
yes: https://github.com/pivpn/pivpn/issues/207, https://github.com/pivpn/pivpn/issues/634, https://github.com/pivpn/pivpn/issues/676, https://github.com/pivpn/pivpn/issues/752
Console output of      pivpn debug
https://pastebin.com/CEbvUQfz
Have you taken any steps towards solving your issue?
I tried several of the proposed solutions in the other tickets, but unluckily nothing worked so far.
No compression config is in the server.conf, and setting local ip, or push route also didn't seem to work.
Aside this at least I only used pivpn and nothing else, no pihole etc. Just a vanilla install with 2 users added. And everything from the installation to the connect vpn works. Just I don't reach any device then.
Any clues what might be wrong?
Thanks in advance for your help!

The connection seem to be established. When connected to the VPN, can you SSH into your raspberry pi via these addresses: <IP_ADDRESS> and <IP_ADDRESS>? I see you are on android, you can use JuiceSSH.

Yes the connection seems generally ok in the android OpenVPN Connect client.
Yeah JuiceSSH is very nice, already use that a lot.
I can connect with <IP_ADDRESS> to the raspberry. (but it warns me that the public key of the raspberry has changed and that the connection might be unsecure therefore. Seems odd to me..)
Also <IP_ADDRESS> works fine.

OK so basically you can only connect to the raspberry pi itself, let's tackle this problem first.

Install tcpdump on the raspberry pi: sudo apt install tcpdump
Connect to the VPN
Run sudo tcpdump -i tun0 -nn host <IP_ADDRESS> and port 80 on the raspberry pi to sniff the traffic inside the tunnel, it should hopefully be populated when you visit the router web interface. If not, post the output.
Also post the output of sudo iptables -S and sudo iptables -t nat -S in case the debug script didn't work.

Ok so I installed tcpdump and ran the command you provided. While I request the router page on the mobile it produces the following output:
~ $ sudo tcpdump -i tun0 -nn host <IP_ADDRESS> and port 80
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on tun0, link-type RAW (Raw IP), capture size 262144 bytes
16:47:48.988213 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 698284 ecr 0,nop,wscale 7], length 0
16:47:49.232357 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 698309 ecr 0,nop,wscale 7], length 0
16:47:49.986950 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 698384 ecr 0,nop,wscale 7], length 0
16:47:50.232395 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 698409 ecr 0,nop,wscale 7], length 0
16:47:51.987982 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 698584 ecr 0,nop,wscale 7], length 0
16:47:52.238475 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 698609 ecr 0,nop,wscale 7], length 0
16:47:55.992917 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 698985 ecr 0,nop,wscale 7], length 0
16:47:56.242472 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 699010 ecr 0,nop,wscale 7], length 0
16:48:04.027789 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 699788 ecr 0,nop,wscale 7], length 0
16:48:04.267926 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 699812 ecr 0,nop,wscale 7], length 0
16:48:20.068222 IP <IP_ADDRESS>.55266 > <IP_ADDRESS>.80: Flags [S], seq<PHONE_NUMBER>, win 65535, options [mss 1361,sackOK,TS val 701392 ecr 0,nop,wscale 7], length 0
16:48:20.302599 IP <IP_ADDRESS>.55267 > <IP_ADDRESS>.80: Flags [S], seq 12117568, win 65535, options [mss 1361,sackOK,TS val 701416 ecr 0,nop,wscale 7], length 0

When I try to reach google however it doesn't catch any packets.
The routing tables look as follows: (pastebin so this post doesnt get too long)
iptables -S: https://pastebin.com/Ca2Vc1EH
iptables -t nat -S: https://pastebin.com/xPfRBQjc
Does that tell you something?

While I request the router page on the mobile it produces the following output:

That's what I suspected, your raspberry pi is not forwarding the traffic correctly (<IP_ADDRESS> sends packets to <IP_ADDRESS> but it doesn't receive a response).

When I try to reach google however it doesn't catch any packets.

Yeah, that tcpdump rule only catches rules with source or destination ip equal to <IP_ADDRESS> on port 80. It was enough for the test.

Do the logs tell you something?

Yes, first that the debug script is right when he says [OK] Iptables MASQUERADE rule set, this means that the raspberry pi will replace the vpn client ip with its IP. This is required so when your android phone connects to your router, the latter sees <IP_ADDRESS> so it can respond back, otherwise he would have seen <IP_ADDRESS> which he doesn't know what network it belongs to.
However, your raspberry pi blocks packet forwarding by default -P FORWARD DROP, and the install script doesn't take this scenario into account. Pretty sure docker did this. Here's how you can fix (copy-paste every line one by one):
sudo -s
iptables -t nat -D POSTROUTING -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
iptables -t nat -I POSTROUTING 1 -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
iptables -I FORWARD 1 -d <IP_ADDRESS>/24 -i eth0 -o tun0 -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
iptables -I FORWARD 2 -s <IP_ADDRESS>/24 -i tun0 -o eth0 -j ACCEPT
iptables-save > /etc/iptables/rules.v4
exit

Try again.

Wow cool. That actually worked. Now I can access the router and also the internet so I think that should be all!
At first I didn't even manage to connect anymore, but after a restart of the openvpn "systemctl restart openvpn" everything was solved!
So cool! Thanks for the help! Maybe this issue could go to "known issues" because I assume many people are using docker also...
Cheers

...
However, your raspberry pi blocks packet forwarding by default -P FORWARD DROP, and the install script doesn't take this scenario into account. Pretty sure docker did this. Here's how you can fix (copy-paste every line one by one):
sudo -s
iptables -t nat -D POSTROUTING -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
iptables -t nat -I POSTROUTING 1 -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
iptables -I FORWARD 1 -d <IP_ADDRESS>/24 -i eth0 -o tun0 -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
iptables -I FORWARD 2 -s <IP_ADDRESS>/24 -i tun0 -o eth0 -j ACCEPT
iptables-save > /etc/iptables/rules.v4
exit

Try again.

thank you, this worked!


Analyze to get heart rate and SpO2 values

Does rust code exist to analyze the output of this driver to get heart rate and SpO2 values?

Not yet, I recently wanted to take another look at this device so I might write something soon.

Cool, I will look out for it.


initial scaffolding with reth EthApi

closing for now as it was decided to define the traits ourselves

Closing for now with new project structure and execute from outside deployment.


[irods/irods#7592] add ubuntu 24.04 projects

In service of irods/irods#7592
Companion PRs:

irods/irods#7733
irods/irods#7739
irods/irods_client_icommands#477
irods/irods_client_icommands#478
irods/externals#246
irods/irods_development_environment#137

Ready for review

#'d


Create flightstack log dir

If flightstack log directory, informed - either via -l or Log config, doesn't exist, mavlink-router should create it. From https://github.com/intel-aero/meta-intel-aero/pull/74:

See https://github.com/lucasdemarchi/kmod/blob/master/shared/util.c#L397

Done by #59


Load testing a site whose domain name is not pointed/registered .

I tried putting entry in /etc/hosts for the site but , the request were going to original site . I will explain with an example:

Lets my site name google.com(mentioned  as argument to server_name directive in vhost's nginx configuration)  hosted on a vps with IP abc.efg.ijk.lmn

In my /etc/hosts I have put an entry abc.efg.ijk.lmn   google.com .

I have abc.txt file in htdocs of my site google.com, and I am able to access it using google.com/abc.txt .

I have task in my locust taskset that is programmed to hit google.com/abc.txt
but when  i run locust --host=http://google.com
but request is going to THE google.com
any help would be greatly appreciated

Arg, I think I just discovered this as well. I pushed a pretty long hosts file to /etc/hosts on a bunch of slaves with ansible, but was only seeing a little traffic show up on the targets. When I did a tcpdump, I saw traffic going to the datacenter that's registered in public DNS. I guess I'm going to go digging into the source now, but please respond if you've worked around this or have a fix.

Locust uses gevent internally, and I know gevent has been having issues with DNS previously (pre 1.0):
http://www.gevent.org/whatsnew_1_0.html#new-dns-resolver
These should have been fixed with gevent 1.0, but you can try setting the environment variable:
GEVENT_RESOLVER=ares

and see if that helps.
You could also try making request with/without gevent from the python REPL to see if there is any issues there, or if it is related strictly to locust


Animations are still broken with GLTF

when I don't put the extras for bin, png, and materials in it works but doesn't have the texture (it turn white).
but when I add the extras, I assume this fixes the texture but starts to crash animations.
I will attach a crash report to here so you can see the animation crash, but the code and everything is exactly like yours, just in 1.19.2 forge.
crash-2022-09-07_04.36.46-client.txt
btw due to github being stupid, I can't load gltfs

crash-2022-09-21_00.16.22-client.txt
Updated <IP_ADDRESS> crash report

Could you provide the model so I can test it ?
You can .zip it and send it here

I meant to close this I got it working


Missing Pets shows Montezuma

Describe the bug
Missing Pets should not show Montezuma, as this pet is not obtainable outside of Rift to my knowledge.
Profile/Location
For example, go to https://sky.shiiyu.moe/stats/DeathStreeks/Blueberry#Pets and scroll down and click Missing Pets to expand the Missing Pets menu and notice it says Montezuma.
Additional Info
N/A
Expected behavior
Expected Missing Pets to not show a unobtainable pet.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 23.04
Browser: Firefox Developer Edition 117.0b9

Additional context
N/A

fixed in #1980


Method to get the latest CID hash of a docstore database object

Would love to be able to pass an option to both the query and get methods of docstore to return the latest CID hash of the return object(s).

This makes sense to me! PRs would be great for this.

I did something a while ago that may give you this functionality or at least a start for a PR, see https://github.com/orbitdb/orbit-db-docstore/blob/feat/document-revisions/src/DocumentStore.js#L52. Hope this helps.

@haadcode That works perfectly for my purpose!
The query method works perfectly however whenever I pass an options value to the get method I always get back an empty array.
glyphdb.get(asset) => returns array of expected object
glyphdb.get(asset, {fullOp: true}) => returns empty array
even glyphdb.get(asset, {}) => returns empty array
If we can sort that out this ticket is as good as closed!

Ah I see now it's in the feat/document-revisions branch. I'll fiddle with it and see if I can get it safely merged into master and running locally. Pretty far behind at this point.

This is possible now. See https://github.com/orbitdb/orbitdb/issues/281#issuecomment-1738643736.


Allow to pass options to gdb

Hi thank you very much for developing this great extension! It's working so nicely 😄
One question is that, is it possible to pass gdb CLI options from vgdb?
In my use case (debug of MariaDB), I need to pass -x option to execute startup commands from a file, like the below command:
gdb -x /home/ec2-user/MariaDB-server/bld/mysql-test/var/tmp/gdbinit.mysqld.1   /home/ec2-user/MariaDB-server/bld/sql/mysqld

Because the content of gdbinit.mysqld.1 won't dynamically change, currently I'm copy and pasting the content to startupCmds option in launch.json as a workaround. But ideally it can be passed by -x option.
Is there any way already implemented to achieve this? Thanks!

Hi, I guess your suggestion will work in my case. Or we can add a config value like cmdOptions that can just append arbitrary cli options to gdb command. Either is fine for me, thanks!

This has been completed and will be included in the next point release with a couple of other bug fixes / improvements. The proposed API is:
debuggerArgs: [
    '--arg1',
    '--arg2'
]

In your debug launch configuration JSON file. These arguments will be passed directly to GDB on launch, i.e.:
gdb --arg1 --arg2


For a 0.1.1 release

Fix doc string

Codecov Report

Merging #118 (f2d8431) into master (bfe9046) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files           2        2
  Lines          39       39
=======================================
  Hits           38       38
  Misses          1        1

Impacted Files
Coverage Δ

src/scitype.jl
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe9046...8527d64. Read the comment docs.


Allow user input for type "Other"

Environment
NPM build
How did you encounter the bug?

Create a table
Add a column
Select datatype "Other"

It tries to actually use "Other" as a datatype in the query
What did you expect?
I expected to have an input where I could type my custom type (Uint256, Array(Uint8), ...)
Actual Result
It tries to run the query with "Other" as a datatype
Browser
Other
Browser Version
Chromium Version 131.0.6778.85 (Official Build) snap (64-bit)
Version
current master. At the time of writing, the latest tag is 1.5.14 so I can only guess that's the version I'm using. Btw, please update the version in package.json with each update

Hey! Thanks to being that up, I'll take a look into it! Merry Christmas!

Merry Christmas! I'll try to make a PR where all the supported types are in the dropdown


Order datasets in docs

          do we wan t to sort alphabetically/some order?

Originally posted by @zoepiran in https://github.com/theislab/moscot/pull/515#discussion_r1237755653

We want to have them in alphabetical order.

closed by #589


⚠ Bofrost.at has degraded performance

In 2e439a9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2607 ms

Resolved: Bofrost.at performance has improved in 079683e after 6 minutes.


[BUG?] wxPython breaks mkdocstrings

Describe the bug
When trying to document a project using wxPython, mkdocstrings breaks.
(I don't know if the issue actually belongs here, or rather is a mkdocstrings issue or a wxPython problem. Sorry!)
I get the following error message:
mkdocs build
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /Users/balduin/Desktop/mktest/site
ERROR   -  mkdocstrings.handlers.python: Collection failed: 'sip'
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/cli.py", line 205, in main
    output = json.dumps(process_json(line))
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/cli.py", line 114, in process_json
    return process_config(json.loads(json_input))
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/cli.py", line 91, in process_config
    obj = loader.get_object_documentation(path, members)
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/loader.py", line 340, in get_object_documentation
    root_object = self.get_module_documentation(leaf, members)
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/loader.py", line 407, in get_module_documentation
    root_object.add_child(self.get_class_documentation(child_node))
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/loader.py", line 439, in get_class_documentation
    merge(attributes_data, get_class_attributes(parent_class))
  File "/usr/local/lib/python3.9/site-packages/pytkdocs/parsers/attributes.py", line 130, in get_class_attributes
    type_hints = get_type_hints(cls)
  File<EMAIL_ADDRESS>line 1345, in get_type_hints
    base_globals = sys.modules[base.__module__].__dict__
KeyError: 'sip'

ERROR   -  mkdocstrings.extension: Could not collect 'src.main'
ERROR   -  Error reading page 'reference/main.md': 'sip'
Traceback (most recent call last):
  File "/usr/local/bin/mkdocs", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/__main__.py", line 152, in build_command
    build.build(config.load_config(**kwargs), dirty=not clean)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 271, in build
    _populate_page(file.page, config, files, dirty)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/commands/build.py", line 171, in _populate_page
    page.render(config, files)
  File "/usr/local/lib/python3.9/site-packages/mkdocs/structure/pages.py", line 175, in render
    self.content = md.convert(self.markdown)
  File "/usr/local/lib/python3.9/site-packages/markdown/core.py", line 264, in convert
    root = self.parser.parseDocument(self.lines).getroot()
  File "/usr/local/lib/python3.9/site-packages/markdown/blockparser.py", line 90, in parseDocument
    self.parseChunk(self.root, '\n'.join(lines))
  File "/usr/local/lib/python3.9/site-packages/markdown/blockparser.py", line 105, in parseChunk
    self.parseBlocks(parent, text.split('\n\n'))
  File "/usr/local/lib/python3.9/site-packages/markdown/blockparser.py", line 123, in parseBlocks
    if processor.run(parent, blocks) is not False:
  File "/usr/local/lib/python3.9/site-packages/mkdocstrings/extension.py", line 155, in run
    xml_element = self.process_block(identifier, str(block))
  File "/usr/local/lib/python3.9/site-packages/mkdocstrings/extension.py", line 194, in process_block
    data: Any = handler.collector.collect(identifier, selection)
  File "/usr/local/lib/python3.9/site-packages/mkdocstrings/handlers/python.py", line 221, in collect
    raise CollectionError(error)
mkdocstrings.handlers.CollectionError: 'sip'

To Reproduce
The above error message comes from a (mostly) minimal example I used for testing myself:
./
|- src/
   |- main.py
|- docs/
   |- reference/
      |- main.md
   |- index.md
|- README.md
|- mkdocs.yml

Where index.md simply points to the readme, and the .yml sets up all the mkdocs and mkdocstrings stuff.
When main.py looks as follows, all works as expected:
"""
This is the main module
"""
import wx

class Main(object):
# class Main(wx.Frame):
    """
    This is the main class
    """
    pass

When I change the following two lines, I get said error:
# class Main(object):
class Main(wx.Frame):

So, I think it's pretty cleat that the setup is ok and the error happens when I start using wxPython stuff.
Expected behavior
No error?
Screenshots
None
System (please complete the following information):

pytkdocs version: 0.9.0
mkdocs: 1.1.2
mkdocstrings: 0.13.6
wxPython: 4.1.0
Python version: 3.9.0
OS: MacOS

Hello @BalduinLandolt, thank you for the report!
It seems to me that the combo wxPython and get_type_hints is at fault here. So at first glance I'd say there's not much we can do on pytkdocs side. Did you search in Python's bugtracker to see if you can find something similar?

Indeed so: https://bugs.python.org/issue41515
I guess that can be closed then, sorry

No problem! Thank you for searching and finding the Python issue :slightly_smiling_face:
I'll keep it open because we could catch the KeyError while waiting for the fix.

The linked bpo is resolved, closing! Unless the fix still didn't land, in this case please reopen


regenesis: reset repository for reimplementation

Kept the cmd dir and minimal node implementation only.

@IronGauntlets , If we are to delete docs/, we should disable related CI workflows as well, right?
docs-prod-deploy.yml and docs-test.yml

@omerfirmak yes that sounds good. I will create another commit.


comments typos

fixing minor grammar

FY, our dev branch is main, I've cherrypicked your change there...
see: https://github.com/google/or-tools/commit/3756946ef5b325073dfc26f67d6f63b42af0e2a4


Update down_retry_delay default

Update down_retry_delay for #621
I ran into this myself recently. I saw the existing issue and figured I’d throw together a quick pull request since nobody had done anything with this since it was raised back in May of last year.

Thanks!


Fixed Issue - #1523

Pull Request Type
What kind of change does this PR introduce?
[ X ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: #1523
What is the new behavior?
Implemented Bubble Sort algorithm to sort the array elements.
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Attempting to get non existing unconfirmed payment by tx_id throws error

When retrieving a non existing unconfirmed payment by its tx_id, wallet.incoming throws an error instead of returning an empty array.
 Could you add a test that causes the error you're fixing?

May be important to note that I am using a testnet wallet
rcp server
monero-wallet-rpc --daemon-address node2.sethforprivacy.com:28089 --testnet --wallet-file serverwallet \
    --password "" --rpc-bind-port 28088 --disable-rpc-login

test.py
import monero
from monero.wallet import Wallet
from monero.backends.jsonrpc import JSONRPCWallet

print("Using version %s" % monero.__version__)

wallet = Wallet(JSONRPCWallet(port=28088))
account = wallet.accounts[0]

account.incoming(
    unconfirmed=True,
    confirmed=False,
    tx_id="2c846263b369daff443df12bf0b4cc5855bee9c5966daa3926e2091436556b3a",
)

❯ python3 test.py
Using version 1.0
Traceback (most recent call last):
  File "test.py", line 10, in <module>
    account.incoming(
  File "/usr/local/lib/python3.8/dist-packages/monero/transaction/__init__.py", line 313, in __call__
    return fetch(self.account_idx, PaymentFilter(**filterparams))
  File "/usr/local/lib/python3.8/dist-packages/monero/backends/jsonrpc/wallet.py", line 178, in transfers_in
    pmts.extend(_pmts.get("pool", []))
UnboundLocalError: local variable '_pmts' referenced before assignment

@emesik I just realized, you used an proper invalid tx_id as a malformed tx_id.
The test i just posted should show the error, but let me explain a little bit better the problem and my case:

I have a client making a payment to a server's address.
The client sends the tx_id immediately after making the payment (ignore possible security problems).
The server looks for the tx_id to notify the user when its found.
Server fails to find the tx_id and crashes

Hi,
It still seems a bit unclear to me. But I'll take a look next week and let
you know, as right now I'm about to get away for an extended weekend and
have a rest.
Hopefully, you may use your patched version for a while.
Great thanks,
On Thu, Apr 7, 2022 at 2:44 PM Fernando Vega Catalán <
@.***> wrote:

@emesik https://github.com/emesik I just realized, you used an proper
invalid tx_id as a malformed tx_id.
The test i just posted should show the error, but let me explain a little
bit better the problem and my case:
I have a client making a payment to a server's address.
The client sends the tx_id immediately after making the payment (ignore
possible security problems).
The server looks for the tx_id to notify the user when its found.
Server fails to find the tx_id and crashes
—
Reply to this email directly, view it on GitHub
https://github.com/monero-ecosystem/monero-python/issues/110#issuecomment-1091689202,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADDMQ7ODUAOL2VUWRO54QTVD3KCLANCNFSM5SZBIPGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Michał


Destructive behavior of “add as destination”

Hello
I may also add that the old right-mouse-click-context-menu item “add as via point” was much more intuitive for me. A “via point” is for me a clearly defined phrase. The context-menu items in the new layout show behavior for me that is quite unexpected.
It can even happen that a constructed route is completely lost if a wrong item is selected at the end of a route building process.
The “direct to here” function would be expected to just add a final destination point. But what actually happens is that all “via points” are removed - beyond return, it seems. Even if this behavior is known to the user, it may happen inadvertedly and cause a route to be lost! Not to be desired.
Best wishes
Christian

Hello again @shinkolobwe
I see your point, but add stop here seems to be also a way to communicate it. I think both are understood by users.
The route displayed on the app is synchronized with the URL, so that if the URL is shared/copied, it will render the exact route.
The flow is:

detect changes made by the user via inputs or map interactions
create a new URL based on the data/parameters,
redirect the app to the new URL
calculate the route based on the URL
Show the route.

If it fails on the last step (calculate) then I understand that it would not be a good strategy to return to a old URL.
Direct to here means indeed direct, without stop. There are already the add stop here and Append as destination options.
Thanks for your feedback. we really appreciate it.
Best wishes.
Amon

Ok good evening, the terminology is so confusing and actually unclear because the term "direct to" is a verb.
see here: https://dict.leo.org/german-english/direct to
So the term "direct to" will be commonly understood as a command to add the point as the final destination. "direct me to the beach", for example.

Hey @shinkolobwe. The route "destructive" behavior was fixed. I managed to find a better way to deal with it in the code.
Thanks for reporting.


build: 1.5beta1 from source on OSX 10.10.2: Error running API checker: exit status 1

OSX 10.10.2 amd64, bootstrap with go1.4.2.
On building go1.5beta1 from source tarball, I get an error during the build:
~/pkg/go1.5beta1/src $ time ./all.bash
time ./all.bash
##### Building Go bootstrap tool.
cmd/dist

##### Building Go toolchain using /Users/jason/pkg/go1.4.2/go.
bootstrap/internal/obj
bootstrap/asm/internal/flags
...
meteor-contest
pidigits
threadring
chameneosredux
        8.57 real        10.37 user         1.84 sys

##### ../test/bench/go1
testing: warning: no tests to run
PASS
ok      _/Users/jason/pkg/go1.5beta1/test/bench/go1 1.663s

##### ../test

##### API check
Error running API checker: exit status 1
Go version is "go1.5beta1", ignoring -next /Users/jason/pkg/go1.5beta1/api/next.txt
+pkg archive/zip, method (*Writer) SetOffset(int64)
+pkg bufio, method (*Reader) Discard(int) (int, error)
...
+pkg unicode, var Multani *RangeTable
+pkg unicode, var Old_Hungarian *RangeTable
+pkg unicode, var SignWriting *RangeTable
exit status 1
2015/07/08 23:03:05 Failed: exit status 1

real    7m32.789s
user    12m54.353s
sys 3m8.521s
jason@jasonsmac ~/pkg/go1.5beta1/src $

I also got the same error building go1.5beta1 on Ubuntu 15.04 x86_64 bootstrapping with go1.4.2 that was built from source as well.
My log also ended the same:
+pkg unicode, var Multani *RangeTable
+pkg unicode, var Old_Hungarian *RangeTable
+pkg unicode, var SignWriting *RangeTable
exit status 1
2015/07/09 10:35:16 Failed: exit status 1

Same here as well on go1.5beta1 using Arch Linux x86_64, kernel 4.0.7-2. Bootstrapping from go1.4.2 that was built from source.

Cloning https://go.googlesource.com/go and checking out master gave me a passing build, for what it's worth.

Same error running Go 1.5beta1 all.bat on Windows 386, bootstrapped from Go 1.4.2 Windows 386.
+pkg unicode, const Version = "8.0.0"
+pkg unicode, var Ahom *RangeTable
+pkg unicode, var Anatolian_Hieroglyphs *RangeTable
+pkg unicode, var Hatran *RangeTable
+pkg unicode, var Multani *RangeTable
+pkg unicode, var Old_Hungarian *RangeTable
+pkg unicode, var SignWriting *RangeTable
exit status 1
2015/07/10 10:53:14 Failed: exit status 1

cc @bradfitz @robpike

Looks like the 1.5 beta has the Unicode 8 but next.text doesn't know about it. It's there at tip, so the next beta or release candidate should resolve this.


Ionic 4: platform.is('electron') failed for electron 2.0.1

Bug Report
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
cli packages: (/usr/lib/node_modules)

   @ionic/cli-utils  : 2.0.0-rc.6
   ionic (Ionic CLI) : 4.0.0-rc.6

local packages:

   @angular-devkit/core       : 0.6.0
   @angular-devkit/schematics : 0.6.0
   @angular/cli               : 6.0.3
   @ionic/schematics-angular  : 1.0.0-rc.6
   Ionic Framework            : @ionic/angular 4.0.0-alpha.7

System:

   NodeJS : v8.11.2
   npm    : 5.6.0
   OS     : Linux 4.15

Describe the Bug
When I tried to use this.platform.is('electron') inside electron with a ionic v4 app the result was negative.
Expected Behavior
Result should be true.
Additional Context
I checked the platform ionic source. https://github.com/ionic-team/ionic/blob/3bb661fa11e027f4cc55bd920d2353485beecff5/core/src/utils/platform.ts#L57 It is checked if the userAgent includes 'electron' but the electron 2.0.1 userAgent electron starts with a capital 'E':
win.navigator.userAgent:

"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko).../0.0.1 Chrome/61.0.3163.100 Electron/2.0.1 Safari/537.36"

Thank you for the issue! I am going to close this issue and merge it into #15165 to keep all platform issues in one.


Fix: Corrects $SPARK_HOME errors in spark container

When installing spark via miniconda the spark home is not set so you cannot run spark in AML.  You will get errors when you try to set the spark context or if you set the framework to pyspark in an AML pipeline step.  This PR installs spark, sets the home, and installs open mpi dependency.

/azp run

/azp run

/azp run

/azp run

@brockneedscoffee - looks good but we dont test docker notebook as part of the build yet so could you manually test these out?
Also could you group all the run steps together into a single run step and put ENV stuff in top of docker. Putting all of the run steps together (and deleting ant .tgzs you download in these steps) makes the docker image considerably smaller thanks!


Focus follows mouse

Allow PowerToys to examine, set and reset focus-follows-mouse (i.e. X-mouse).  On some machine that remember my various NTUSER.* settings, I get this behaviour.  On other machines, or logging into separate accounts, focus-follows-mouse is not enabled.  Thus: the Windows display manager is capable of this, but the setting is hidden in some registry details.  Allow it to be visible.

Great suggestion! We'll log this in our Suggested Ideas Milestone for now and follow-up on this once general stabilization efforts are concluded.
We may be able to leverage some work from the registry key plugin for PowerToys Run to enable it, but I'm not sure at the moment how feasible this is.

I'll close this issue as it looks like we're already tracking the idea https://github.com/microsoft/PowerToys/issues/74. Thank you for the suggestion!


Export 'TestUtils' for consumer usage

Looks like I forgot to export the new TestUtils object in #5 🤦 Add it to the index file so a consumer could easily import it

Published inv0.0.4


Bot failing to delete words on server filter word list even with manage messages permission and after having bot role placed at top of hierarchy

Nadeko used to delete words on the fw list almost immediately. I haven't changed anything, but suddenly, it doesn't work anymore. I made sure the nadeko role had the manage messages permission, and then I tried placing it above all other roles. No luck. I have to assume this is a bug that's recently been introduced, or otherwise, something must have changed in the coding of discord.

Works just fine. Make sure you do .sfw to enable the filtering on the server after adding the words with .fw (or .cfw if you just want it to be on a channel basis).

The bot still won't do it in my server. Is there some other known issue that could be at work? Because I made sure and have been trying the past couple days and it's still not working.


City and 2nd, 3ed level filter

Hello - Is it possible to add City filter and 2nd level and 3rd level connection filter ?

That would be amazing!


Roll Plugins from dfd1b6e7d83e to f8f2bd1537f2 (8 revisions)

https://github.com/flutter/plugins/compare/dfd1b6e7d83e...f8f2bd1537f2
2022-06-23<EMAIL_ADDRESS>Roll Flutter from 60f30e5d3ed4 to a30012b27505 (8 revisions) (flutter/plugins#6033)
2022-06-23<EMAIL_ADDRESS>[google_sign_in_platform_interface] Add support for serverClientId (flutter/plugins#5256)
2022-06-22<EMAIL_ADDRESS>Bump junit to 4.13.2 (flutter/plugins#5585)
2022-06-22<EMAIL_ADDRESS>[webview]: Bump junit from 4.12 to 4.13.2 in /packages/webview_flutter/webview_flutter_android/example/android/app (flutter/plugins#6030)
2022-06-22<EMAIL_ADDRESS>[webview_flutter_wkwebview] Update copy method for Dart classes and support the NSObject.observeValue for subclasses (flutter/plugins#5961)
2022-06-22<EMAIL_ADDRESS>Roll Flutter from dfaec11ba519 to 60f30e5d3ed4 (23 revisions) (flutter/plugins#6015)
2022-06-22<EMAIL_ADDRESS>[url_launcher] Switch to new launchUrl interface (flutter/plugins#5985)
2022-06-22<EMAIL_ADDRESS>[ci] Ensure complete dependabot coverage (flutter/plugins#5976)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


[WIP] refactor: convert inquiry modal into a drawer widget (DIA-690)

This PR resolves []
Description

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against b4d5fea7c14eed76ec01410a24a4f78bb638c305

I am closing this PR. While it succeeds in moving the inquiry form into a BottomSheetModal widget, the end result is only tall enough to show the inquiry questions and can cause users to miss the message field unless they scroll down. I think this surface needs some more design consideration before it is ready for development.


Change applications to be self-hosting WebAPI applications

That way we can treat them all the same (sensor, storage, agent etc.). Also by using http for the communication we can set-up load balancing etc. with the standard tooling
As a bonus we can use https://github.com/lvermeulen/Nanophone to handle service registration.

For the API versioning have a look at: https://github.com/Microsoft/aspnet-api-versioning

And we might be able to use this as well: https://github.com/rogeralsing/Microphone


Minimal Requirements for inference.

Hi, I thought it would be useful to install the required packages except of the additional ones.
requirements.txt
dlib
gdown
scikit-image
IPython
opencv-python

Commands to setup project
git clone https://github.com/ZPdesu/Barbershop.git
cd Barbershop

conda create -n barbershop python=3.10 -y
conda activate barbershop

# For CPU
pip install torch torchvision torchaudio

# For CUDA v11.6 (for v10.2 and v11.3 don't use '-c conda-forge')
conda install pytorch torchvision torchaudio cudatoolkit=11.6 -c pytorch -c conda-forge

pip install -r requirements.txt

Hello, to complete, i just did a proper install.
You need to add after the pip install requirements :
conda install Ninja
Add cl.exe on path : SET PATH=%PATH%;C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x86
Patch PILLOW functionnal.py ( https://stackoverflow.com/questions/59659146/could-not-import-pillow-version-from-pil )
( For me it was here : C:\Users\USER\AppData\Local\miniforge3\envs\barbershop\Lib\site-packages\torchvision\transforms\functional.py)

Yeah maybe you need this in windows. I installed it on ubuntu and it was working fine.


Is it possible to add fly?

Is it possible to add fly? This can be much useful.

Technically, this is possible. In fact, it is not necessary. Its xray mod, not pack of mods. IMHO, if you need several tools of this kind, it is better to use ready-made clients like Aristois, Impact, Kami Blue, Future and etc

Technically, it was in the legacy Xray mod, so maybe if we have the time. If you really need this feature, you can use the mods listed by loonybtard

严格来说，它是在传统的Xray mod中，所以如果我们有时间的话。如果你真的需要这个功能，你可以使用loonybtard列出的mods
I need is very much, thank you brother！


Add the trailing slash to id/base elements in the RSS feed

This will make them match the real URLs. I'll have to do this carefully to avoid sending all my old posts back into people's feed readers.

I've got a trailing slash being added to new RSS feed entries – anything after "documenting my DNS".
https://github.com/alexwlchan/alexwlchan.net/blob/3de6bb63523aa008174d2813694d16f7a3f58a4e/src/_includes/rss_feed_entry.xml#L12-L28
That means about half the posts have it, half don't – I need to wait a bit longer before I can remove the date-based workaround and just have the new way.

Don't forget this is used in the TIL feed as well!

Tip: if you want to check whether this is done yet, search for <id> in the compiled RSS feed.
I'm still about a dozen posts away in the articles feed, slightly less in the TIL feed.


Formspree form submission not working

I have changed the formspree URL/email address as instructed but when I send now, I get the following error:
Failed to load resource: the server responded with a status of 400 ()

It seems it is trying to submit to<EMAIL_ADDRESS>as that is the email in the error console but I don't see that anywhere in the project folder.

can you check _js/scripts.js and _includes/form.js files? the <form> tag should have an attribute of action="https://formspree.io/{{site.email}}". And js it should be (bottom of js file):
/*-------------------------------------------------------------------------*/
/* AJAX FORM SUBMIT */
/* -----------------------------------------------------------------------*/

$( "#contactForm" ).submit( function( e ) {

    e.preventDefault();
       // other variables
       var $url = $( "#contactForm" ).attr( "action" );

    $.ajax( {

        url: $url,
    // some more code down there

npm start seems to fix the problem, as the default email still persists on assets/js/bundle.js.
@janczizikow, Formspree now prevents me from sending the form on a free verified account, I'm receiving:
{error: "To prevent spam, only Gold accounts may create AJAX forms."}

hey @kbeflo I didn't know that formspree changed that. As you said will probably have to move away from AJAX. Shame 😞


[0.29.x] Unicode tests fix for Py3.8

This patch enables disabled unicode tests with Py3.8 on the 0.29.x branch.

Thanks, but these are tests copied from CPython, and the parts that I disabled mostly test CPython. The only exception is the Finnish test, which Cython can impact, so a conditional seems helpful there.
I would like to keep the other tests close to the way they are written in CPython to simplify later updates.

What CPython version?

Not sure what exactly you're asking, but I recently updated the test file from the latest CPython master while I was trying to fix the test, after noticing that it started failing in 3.8.

That's all i needed to know.

@scoder So in order to get this PR merged I should disable the other tests again and keep only the FI/Finnish conditional. Can you please confirm?

Yes, that would be ok as a PR.


Clarify Note on MSAL.NET

[Enter feedback here]
Please clarify the following note in the docs on whether ADFS federation is supported for Active Directory integrated authentication as an alternative to Seamless SSO using either the Pass-through and Password Hash authentication methods.
"MSAL.NET (Microsoft.Identity.Client) for integrated Windows authentication is not supported for seamless single sign-on for pass-through and password hash authentication."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d4a33b0-87d0-f60c-1b52-aeafa889e657
Version Independent ID: c281bdb7-c98c-6853-5077-41b3dd44d3a2
Content: Configure Azure Active Directory authentication - Azure SQL Database & SQL Managed Instance & Azure Synapse Analytics
Content Source: articles/azure-sql/database/authentication-aad-configure.md
Service: sql-db-mi
Sub-service: security
GitHub Login: @GithubMirek
Microsoft Alias: mireks

@bdschaap We are checking this and will get back to you.

@bdschaap We are checking this and will get back to you.

@bdschaap We checked with the internal team and this is what they conveyed "if the AAD and AD are integrated and syncing, then they connect from on-prem by selecting AAD authentication. They tried by both methods and were able to connect. Is this what you looking for?

@bdschaap We checked with the internal team and this is what they conveyed "if the AAD and AD are integrated and syncing, then they connect from on-prem by selecting AAD authentication. They tried by both methods and were able to connect. Is this what you looking for?

I appreciate the update but it's not quite what I was looking for.  My question is for MSAL.NET (Microsoft.Identity.Client) which is a dependency of Microsoft.Data.SqlClient in .NET Core.  I believe the screenshot you took is of SSMS which uses .NET Framework.  I would like to get clarification on whether ADFS is supported in MSAL.NET.  I have pasted the content below to provide better context.  The article says that AD must be federated or a managed domain configured for seamless SSO for pass-through or password hash authentication.  However, the note says that pass-through and password hash authentication aren't compatible with MSAL.NET.  It's my assumption that using ADFS to federate AD and AAD will work since that's not listed in the note and asking for confirmation.
"To use integrated Windows authentication, your domain's Active Directory must be federated with Azure Active Directory, or should be a managed domain that is configured for seamless single sign-on for pass-through or password hash authentication. For more information, see Azure Active Directory Seamless Single Sign-On.
Note
MSAL.NET (Microsoft.Identity.Client) for integrated Windows authentication is not supported for seamless single sign-on for pass-through and password hash authentication."

I appreciate the update but it's not quite what I was looking for.  My question is for MSAL.NET (Microsoft.Identity.Client) which is a dependency of Microsoft.Data.SqlClient in .NET Core.  I believe the screenshot you took is of SSMS which uses .NET Framework.  I would like to get clarification on whether ADFS is supported in MSAL.NET.  I have pasted the content below to provide better context.  The article says that AD must be federated or a managed domain configured for seamless SSO for pass-through or password hash authentication.  However, the note says that pass-through and password hash authentication aren't compatible with MSAL.NET.  It's my assumption that using ADFS to federate AD and AAD will work since that's not listed in the note and asking for confirmation.
"To use integrated Windows authentication, your domain's Active Directory must be federated with Azure Active Directory, or should be a managed domain that is configured for seamless single sign-on for pass-through or password hash authentication. For more information, see Azure Active Directory Seamless Single Sign-On.
Note
MSAL.NET (Microsoft.Identity.Client) for integrated Windows authentication is not supported for seamless single sign-on for pass-through and password hash authentication."

@bdschaap Thank you for the clarification . We are assigning this to our doc author for checking it.
@GithubMirek - Please check the question.

@bdschaap Thank you for the clarification . We are assigning this to our doc author for checking it.
@GithubMirek - Please check the question.

I did a little more digging.  MSAL.NET seems to work with Seamless SSO when running on Windows.  It doesn't work with Seamless SSO when running on Linux.  However, I think that MSAL.NET may work with Linux when using ADFS but haven't validated it.  Would appreciate confirmation as well as any updates to the docs as needed based on your findings.

Hi @bdschaap - Sorry for the delay, and thank you for your patience. MSAL.NET is supported to work with integrated authentication on Windows. AD authentication is also supported for the Microsoft.Data.SqlClient on Linux. I'll go ahead and remove that note. Please let us know if you have any concerns. We appreciate your time and feedback.

#please-close


Correction for raw affiliation AMAP, Univ. Montpellier, IRD, CNRS, CIRAD, INRAE, Montpellier, France

Correction needed for raw affiliation AMAP, Univ. Montpellier, IRD, CNRS, CIRAD, INRAE, Montpellier, France
raw_affiliation_name: AMAP, Univ. Montpellier, IRD, CNRS, CIRAD, INRAE, Montpellier, France
new_rors: 05kpkpg04;05q3vnk25;003vg9w96;03rnk6m14;051escj72;02feahw73;020nks034
previous_rors: 05kpkpg04;05q3vnk25;003vg9w96;03rnk6m14;051escj72;02feahw73
works_examples: W4403360967
contact: 86218af74922f96fc1f4c5fa8a4a4927:bf41c5ce9e686f17a7d07537c8697f6952b4 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


New package: PartialLeastSquaresRegressor v2.0.0

Registering package: PartialLeastSquaresRegressor
Repository: https://github.com/lalvim/PartialLeastSquaresRegressor.jl
Created by: @filipebraida
Version: v2.0.0
Commit: 446a1f5982398140329a2f6eb65a0b91a7cb1ca8
Reviewed by: @filipebraida
Reference: https://github.com/lalvim/PartialLeastSquaresRegressor.jl/commit/446a1f5982398140329a2f6eb65a0b91a7cb1ca8#commitcomment-43190493
Release notes:

New project name
Integration with MLJ

We are changing the name of the package and adding the integration with MLJ.
The following threads show about integration and name change.

https://github.com/lalvim/PartialLeastSquaresRegressor.jl/issues/8
https://github.com/alan-turing-institute/MLJModels.jl/issues/312
https://github.com/lalvim/PartialLeastSquaresRegressor.jl/pull/10

That is the reason why tags start with 2.0.0.
How do we delete the old one?
@lalvim

[noblock] As I understand it, this is really a renaming of PLSRegressor. I wonder if we can waive the "new package" stand-down period. I can vouch for this package (not an author) and I think the name change is an improvement.

[noblock]
This will be auto-merged once the three-day waiting period is done.


Fix: Limit order cancel accounting

Port over fix to limit order cancel account

add more tests

https://github.com/neutron-org/neutron-tests/actions/runs/10516277754

A copy of https://github.com/neutron-org/neutron/pull/659


dnscrypt-proxy version update

Hello. I noticed the container is running dnscrypt-proxy version 1.9.5.
The latest version is 2.0.22 (https://github.com/jedisct1/dnscrypt-proxy/releases/).
Can the gists/dnscrypt-proxy be updated to the latest?
Thanks,
Adit S

https://github.com/vgist/dockerfiles/commit/b2ac1b0

Thanks.


Proposal for representing trailing whitespace without actual trailing whitespace

Intro
Hello again!
I currently have only one niggle with the format,
and that's the invisibility and fragility of representing trailing spaces or tabs.
Trailing newlines are already solved 👍🏼.
I understand that this will probably be closed as not worth the added complexity,
but at least would like to put my best proposal forward.
As an experiment I tried implementing my last idea from the comments from #4,
and it was ok, but then I realized that the new syntax conflicted with regular dictionary syntax in some cases,
so here's the next iteration of the idea.
Why not
First I'll repeat the arguments against a change like this:

added complexity
it's an editor issue -- the editor should not make trailing space invisible and should not remove it

I can't argue against number 1. It is not great to add any complexity.
Number 2 is not convincing to me, because:

I can't control other folks' editors
I like my editor to trim trailing whitespace
I view documents with a variety of pagers and highlighters (including straight terminal output) which will not reliably show me trailing invisible characters

The proposal
Add three new tags, which are alternate versions of the > , - , and multiline key : :

[>
[-
[:

Unlike their existing counterparts, each line using one of these must end with a closing |.
The text content of the line is everything after the 3-character tag, excluding the closing |.
Examples
this dict value has three trailing spaces and no leading spaces:
  [> hello   |
this value will have trailing spaces on some lines:
  [> trailing |
  > no trailing
  [> trailing again   |

[: this key has 4 trailing spaces    |
  > value
: this key has 4 but on the second line
[:     |
  > value2

[- item with 3 trailing   |
- item2

Further acknowledgments

This particular proposal has the additional drawback that the new tags are not the same length as the usual tags, making some consecutive text values jagged rather than perfectly aligned.
The choice of [ helps avoid breaking existing syntax, but is a little strange.

An inline list must always end with a closing ], so a different closing character like | avoids conflict.

What happens to trailing spaces in strings not marked with one of these special tags?

I was aiming here not to change the behavior of any currently valid NestedText, though I might not be opposed to a change there either.

I currently have only one niggle with the format, and that's the invisibility and fragility of representing trailing spaces or tabs.

I'm in agreement that this isn't a great situation. I'd also agree that "it's an editor issue" doesn't hold much water for me.
I'd prefer if your proposal was a more generic "add some demarcation syntax" rather than immediately offering a syntax, because it sets the discussion off on bikeshedding and syntax concerns (e.g. https://github.com/KenKundert/nestedtext/issues/50#issuecomment-2347307546), rather than whether the high-level request is worth the added complexity. There are always options for syntax, while it's helpful to consider what a few options might look like, I'd suggest not focusing too much on it right now.
The complaint raised in https://github.com/KenKundert/nestedtext/issues/4#issuecomment-2278542669 (@pierre-rouleau) was "I see it as transferring the responsibility of ensuring reliability from the implementation to the user.", which I think is a valid concern. However, would an alternative perspective be to view it as transferring some responsibility to the parsing library?
As explained at https://nestedtext.org/en/latest/schemas.html, everything is a string in nestedtext, and the expectation is that an accompanying schema be used to assign types to fields. One option would be for nestedtext parsers to be expected (or have an option) to interpret escapes in certain contexts (such as values typed as "string" via a schema), e.g. URL encoding (space is %20) or Unicode (space is \u0020) could be supported at the parser level.

I'd prefer if your proposal was a more generic "add some demarcation syntax" rather than immediately offering a syntax, because it sets the discussion off on bikeshedding and syntax concerns (e.g. https://github.com/KenKundert/nestedtext/issues/50#issuecomment-2347307546), rather than whether the high-level request is worth the added complexity.

Yeah, I'll modify the title and description to make it more general, but will keep the proposal in as "Proposal A."
I was excited to have proof that this could be done without invalidating or changing the meaning of any currently valid NT, without the new syntax introducing ambiguity, and without breaking the rule of each line describing its own type without context.

I'll note that the drawback of potentially jagged alignment could be removed by trading the markers from ([> |) to ([, <), from ([:, |) to ([, :), and ([-, |) to ([, -). I would be OK with that choice, too, but didn't make it Proposal A because I thought it would be less clear whether the closing mark should have a space before it that is not part of the string value.

I have a number of issues with this proposal.

In a very real sense, this ship has sailed.  The decision was made early on to allow trailing whitespace.  One can make an argument that trailing whitespace is rare and generally a mistake, and so NT should remove it unless the user has explicitly marked it as desirable, but doing that now would result in a serious backward compatibility issue.
Adding syntax that allows the user to mark desired trailing white space while still allowing it without the mark avoids the backward compatibility issue but seems rather pointless to me.  It really just becomes a helper for your editor and has no real meaning in the document itself.
It gives NT the look of a complicated language that must be learned before it can be used.  I can just imagine a someone new to NT opening a document and seeing those and getting turned off by 'complicated syntax'.
In my experience unintended trailing spaces are generally harmless.
There are cases where trailing spaces are both meaningful and routine.  Adding markers to each line would then become burdensome.  One of the nicest features of NT is that it dispenses with quoting, but this proposal brings it back for lines that have trailing whitespace.  For example, Vim uses trailing spaces on lines to indicate the text is a contiguous paragraph that should be reformatted to fill the desired text width after edits.  This results in every line except the last line of a paragraph having a meaningful trailing space or two.

Regarding concern 1: this issue is not asking to disallow trailing whitespace.
Regarding 2:

It really just becomes a helper for your editor and has no real meaning in the document itself.

It would also be a helper for the human eye, outside of editors, where the information that is trailing spaces is otherwise invisible.
For 3 and 5: maybe a simpler syntax for this purpose could be achieved?
For 4: this issue is about intentional trailing spaces.

I use trailing spaces in my NestedText files in two situations.
I use NestedText heavily to hold test cases for the software I develop.  Occasionally, I need test cases that contain trailing spaces. As such, I configure my editor to show trailing spaces, not to delete them.  So personally, I would not use this proposal.  Even if I did wish to mark the end of my strings, I would write the test software to accept and remove a terminal character I chose, such as §.  I understand that I only have this option because I am writing the code that consumes the NT file.  But, this case shows that that there are alternatives available that do not require modifying NestedText.
I also use NestedText to hold prose. Here I use the Vim feature where I just type the prose in one long line and Vim automatically breaks the lines to fit the width of the screen.  Vim then leaves a trailing space on each line to indicate that the line breaks should be adjusted as the text is edited to keep the width of the text.  Adding end of line marker in this case, as you propose, interferes with this feature.  You are thinking that the end of line markers are harmless in the NT file as long as they are removed by the NestedText reader.  but in this case, my most common case, the trailing spaces without end of line markers must exist in the NT file itself.
My point is the case for this proposal is weak.  There are several alternate ways of showing trailing spaces on a line:

configure your editor to show them
use 'cat -E' do show them
modify the application to accept custom end-of-line markers

In addition, your proposal interferes with the purpose of the trailing spaces and so cannot be used, like the Vim example I described.
You started this discussion by stating that you prefer to configure your editor to automatically delete trailing spaces, but in some cases you also want to retain them.  I believe that is the motivating example for this proposal. But you can solve that problem by adding a mode line in a comment that disables the deleting of trailing spaces in files where it is needed.
Your proposal changes the nature of NestedText is a fundamental way.  One of the primary features of NestedText is that it does not employ quoting, This proposal is, at its heart, quoting. It would take a very strong justification for us to consider a change like this.

You started this discussion by stating that you prefer to configure your editor to automatically delete trailing spaces, but in some cases you also want to retain them. I believe that is the motivating example for this proposal. But you can solve that problem by adding a mode line in a comment that disables the deleting of trailing spaces in files where it is needed.

Not really, I can configure my own editor; my main motivations are:

I can't configure other folks' editors, who may not realize they destructively save and format such a file and pass it on
I often view files with pagers, highlighters, and via stdout.

So of your three listed alternatives:

Already done, but it's not sufficient.
Very noisy, as the relevant GNU cat and busybox cat options add characters to every single line to account for this rare case. Also insufficient, as I need to check for a similar option for each of an array of additional tools. I usually use Zsh functions which try to fallback to the best installed highlighter or pager for the purpose found on the system. And I don't think there's anything to be done about stdout (maybe at the shell or terminal emulator level?).
Not always possible, as they are not always my applications, and I often use NT to view converted data from JSON, TOML, and YAML.

I understand this will not happen, but wanted to make clear that none of these suggestions fix my problems,

I acknowledge that.

An inline list must always end with a closing ], so a different closing character like | avoids conflict.

Wouldn't this require arbitrary lookahead?

Maybe. My layman conception of the parsing was very line-oriented, so I imagined to logic to be like:
if tag is "[" and last char is "|", then remove tag and last char and try parsing again

I've implemented a few parsers and usually they were byte-oriented.
Speaking about a last char in a line would mean, even in a line oriented parser, to allocate a buffer for the line while parsing the first time, read the line into said buffer and if that line ends with some terminal, rewind to the start of the section and parse again.
Without this I should be able to fit an entire (callback based) parser in a C header file.
With this, that would probably be a bad idea.
Not to mention the security problems with arbitrary size allocations.


Automated cherry pick of #8760: fix: avoid panic

Cherry pick of #8760 on release/3.4.
#8760: fix: avoid panic

Codecov Report

Merging #8762 (e9459b4) into release/3.4 (02bcce1) will decrease coverage by 0.05%.
The diff coverage is 0.35%.

@@              Coverage Diff               @@
##           release/3.4   #8762      +/-   ##
==============================================
- Coverage         6.22%   6.16%   -0.06%
==============================================
  Files              759     150     -609
  Lines           117145   21111   -96034
==============================================
- Hits              7289    1301    -5988
+ Misses          109197   19661   -89536
+ Partials           659     149     -510

Flag
Coverage Δ

aFlag
6.16% <0.35%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/caller.go
22.43% <ø> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/domain.go
2.73% <0.00%> (+0.07%)
:arrow_up:

pkg/cloudcommon/db/domainresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/metadata.go
5.04% <0.00%> (-0.05%)
:arrow_down:

pkg/cloudcommon/db/metadataresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/modelbase.go
4.51% <0.00%> (-0.16%)
:arrow_down:

pkg/cloudcommon/db/namevalidator.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.37% <0.00%> (-0.01%)
:arrow_down:

pkg/cloudcommon/db/orderby.go
0.00% <0.00%> (ø)

... and 504 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5861a18...e9459b4. Read the comment docs.


[Go] Updating a few guidelines and clarifying others

errors should always be returned by pointer
NewClient and Client should be favored as the Client name (instead of WidgetClient, for instance)``

Any plans of full guide for go?

Any plans of full guide for go?

@mirusky, what kind of guide are you thinking of? This particular document is basically the "here's what Azure SDKs interface must look like" for Go, but not a tutorial/introduction to the language.
We do have some learn.microsoft.com content (and more is always being added):

Azure for Go developers: https://learn.microsoft.com/en-us/azure/developer/go/
Take your first steps with Go: https://learn.microsoft.com/en-us/training/paths/go-first-steps/

And each readme should contain links to our examples, for a particular package, on pkg.go.dev (for instance: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azservicebus#pkg-examples)

@jhendrixMSFT @JeffreyRichter Any more concerns with this change? Lets get this PR in to increase the value within our guidelines.

Any plans of full guide for go?

@mirusky, what kind of guide are you thinking of? This particular document is basically the "here's what Azure SDKs interface must look like" for Go, but not a tutorial/introduction to the language.

I mean, a full guideline for Azure Go SDK, the current guideline lacks many definitions and parts. Giving a ugly DX since it almost doen't have the concrete rules and explanations.

@richardpark-msft Can you get this across the finish line and checked in.


Workbox latest

Adds workbox 3.0.1 docs and switches from prerelease to latest for reference docs.

Whoops!
There were 7 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/workbox/reference-docs/latest/module-workbox-build.html - Unable to read file, was it deleted?
src/content/en/tools/workbox/modules/workbox-routing.md#L138 - Line must be at most 100 characters
src/content/en/tools/workbox/modules/workbox-routing.md#L139 - Line must be at most 100 characters
src/content/en/tools/workbox/modules/workbox-routing.md#L140 - Line must be at most 100 characters
src/content/en/tools/workbox/modules/workbox-strategies.md#L101 - Common typo found: 'admin' Should it be 'administrator'? See: https://developers.google.com/style/word-list#administrator
src/content/en/tools/workbox/reference-docs/latest/workbox-build_src_index.js.html#L87 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/workbox/reference-docs/v3.0.1/workbox-build_src_index.js.html#L87 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen

@jeffposnick this is an automated set of changes - there is nothing I can do to change what is currently here.


gnome-network-displays: fix hardware acceleration

Description of changes
GNOME Network Displays is missing dependencies for GStreamer to make hardware acceleration work. Add these missing dependencies.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks!


[BUG] RuntimeError: Error building extension 'utils' (ninja related?)

Describe the bug
As shown in this notebook, I run these commands:
pip install deepspeed --upgrade
git clone https://github.com/microsoft/DeepSpeedExamples
cd DeepSpeedExamples/model_compression/gpt2
pip install -r requirements.txt
sudo apt-get install ninja-build # I don't think this line is actually needed, but I'm not sure
pip install ninja
bash ./bash_script/run_zero_quant.sh

This is exactly following the instructions in the readme of DeepSpeedExamples/tree/master/model_compression/gpt2 except that I had to install ninja because the machine didn't have it yet.
And after some progress, the run_zero_quant.sh script throws RuntimeError: Error building extension 'utils' (please see the notebook for full logs).
To Reproduce
Steps to reproduce the behavior:

Run this notebook: https://gist.github.com/josephrocca/9ec65e8e5804286a475b5b6da85f7a28

Expected behavior
There is a related issue here:

https://github.com/microsoft/DeepSpeed/issues/694

The apparent solution there was to ensure that the deepspeed wheel was built with the same cuda version as the machine has installed. But the ds_report shows that the versions match. So I guess the "expected behavior" here is that it shouldn't throw the error that I'm seeing.
ds_report output
As seen in the above-linked notebook:
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
 [WARNING]  please install triton==1.0.0 if you want to use sparse attention
sparse_attn ............ [NO] ....... [NO]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
utils .................. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/usr/lib/python3/dist-packages/torch']
torch version .................... 1.11.0
torch cuda version ............... 11.6
torch hip version ................ None
nvcc version ..................... 11.6
deepspeed install path ........... ['/home/ubuntu/.local/lib/python3.8/site-packages/deepspeed']
deepspeed info ................... 0.7.0, unknown, unknown
deepspeed wheel compiled w. ...... torch 1.11, cuda 11.6

System info (please complete the following information):

OS: Ubuntu 20.04
GPU count and types: 1x RTX 6000 (24GB)
Python version: 3.8
Any other relevant info about your setup: I used https://lambdalabs.com/ GPU cloud (using their Cloud IDE)

Hi @josephrocca, thanks for using DeepSpeed. Could you try pre-compiling and let me know the outcome? To do so:

Uninstall DeepSpeed pip uninstall -y deepspeed
clone our repo git clone https://github.com/microsoft/DeepSpeed.git && cd DeepSpeed
install with either DS_BUILD_OPS=1 pip install . or DS_BUILD_UTILS=1 pip install .` (read more here: https://www.deepspeed.ai/tutorials/advanced-install/#pre-install-deepspeed-ops)

Hi @mrwyattii, I tried both the DS_BUILD_OPS option and the DS_BUILD_UTILS option on a fresh Lambda Cloud machine, and both gave errors. Please see here for the full error logs of both attempts: https://gist.github.com/josephrocca/8417c4665cbfef89ba85e439c17500da

Solution?

I see this error message in the gist log. Can you confirm that pybind11 is installed?

sudo apt install python3-pybind11

windows上，我在这里https://pypi.org/project/deepspeed/#files 下载了对应的包，解压之后直接放在虚拟环境里可以成功


Geolocation do not trigger event change:position if projection setting is omitted

If creating a new Geolocation without the projection setting set, then the event 'change:position' is only fired once.

That can also happen if the specified projection does not have a proj4 definition.  An identity transform is used so the original array is returned, which will not trigger a change as only the contents have changed, it is the same array.


What about the lexical injection use case class? (from discussion of from string import ascii_lowercase)

I like (useful) tangents. Let's start with a tangent and then tangent on the tangent.
First, a search of the 007 repo for "use case" and "use cases" only shows matches in a few commits, none of which suggest a single place other than this issue queue to discuss use cases. There are also 41 issues in the issues queue which match, which is why I'm thinking it's reasonable to post this here. Is there a single place -- perhaps one of those issues -- where you're collecting use cases? Is it or could it be organized by broad classes of use case? The macro idea tag doesn't seem to be the right fit to me but perhaps it is in your mind. Hopefully you'll come to see that what I'm talking about in this issue is something quite distinct.
As a tangent to the first tangent... I see an examples directory but I don't think it's what I'm talking about. Perhaps these examples correspond to classes of use case but instead they seem somewhat ad hoc, more like they demonstrate important 007 features. I didn't see comments in the examples or a README motivating the examples -- a comment about why the feature(s) they demonstrate are interesting and/or necessary -- but that would be helpful to outsiders regardless of any focus on use cases.
As a second tangent to the first tangent, is there somewhere more appropriate to post possible macro use-cases, if they are mostly or purely relevant in the context of pressing P6 needs, not those of 007? If not, perhaps you could start a p6macro project/repo that starts out by simply inviting P6ers to contribute issues that list either specific potential P6 macro use cases or general discussion, perhaps with a few predetermined tags, with links to 007? Or perhaps you think that would be a good idea but would be happy for us to set that up in the perl6 repo or under one of our own accounts?

As an example for the tangent(s) above, and a particular use case that's why I first decided to post an issue, and as an exemplar of a use case class, the following seems to be a simple use case for which macros seem to me to be perhaps the natural solution.

First, some context. In https://www.reddit.com/r/perl6/comments/9rf22o/exportation_exploration/e8ibnfa I wrote:

Using our ... gets the exact same result as the Python one for a plain import ...:

module string { our sub ascii_lowercase {} }

import string;
string::ascii_lowercase; # works

Using an alias gets the from ... import ... effect:

my &ascii_lowercase = &string::ascii_lowercase;
ascii_lowercase # now also works

Presumably some code could be written to package this up in a way that is more or less identical to python's from ... import ... construct.

A few seconds reflection after I posted the above comment brought macros to mind because import is lexically scoped.
It seems to me that none of the non-macro Block based solutions such as a sub can ever work to package up in a module a desired effect which is inherently lexically scoped if the effect is to be applied at the call site.
And introducing a slang for this seems like it would be using a sledgehammer to crack a nut.

Anyhow, I got as far as...
use experimental :macros;
macro from-import (@from, $module) {
  quasi {
    import {{{$module}}};
    my

...and stopped.
Would the import work? I recall our discussion of the meaning of the {...} in quasi {...} and aiui their lexical scoping effect is stripped away during injection. So I think it should work.
How would I convert the list of identifiers to import (in @from) into a series of my ... statements?
Let's say the first one is $foo. Can I write my {{{@from[0]}} ... in the quasi? I don't think so though I haven't tried.
What if it's foo and I want to turn that into &foo thus my &foo ...?
How would I construct the full name (&{{{$module}}}::foo)?

Addressing first the particulars of the question, about injecting lexicals:

007 already has (spec'd) a version of the from ... import ... syntax, although it's modeled on ES6 instead of Python. See https://github.com/masak/007/issues/53#issuecomment-392315596.
Actually, Perl 6 has syntax for this too, so apart from the exact spelling, there's no need to add this functionality via a macro.
Ignoring all, that and looking at doing the task as stated:
The macro needs to be an is parsed statement:from-import macro, because it provides new syntax.
(I also notice some "optimism" in the parameter types. Remember that those will always be Qtree fragments, not arrays and strings.)
I thought we had an issue about declaring something in the mainline rather than in the quasi/injectile, but it seems we don't.
The closest thing we have is #313, which is... almost that thing, but not entirely.
I don't have all the answers now, but it would seem that this is a good example of wanting to programmatically generate code that lexically installs something in the injected/mainline scope.
(tbc)

A couple of things about the use cases:

I'm intrigued by the idea, and willing to try it out.
As a concrete suggestion, @raiph how about we set up a directory use-cases/, preferably in a PR? Merging that PR could be enough to close this issue.
I haven't checked that "41 issues" number, but it sounds about right. That also means that there is a simple way to start building the use-cases/ directory: just go through all those issues, extracting what the use case is (if any).
Please be aware that the examples/ are slowly undergoing a transformation to be more geared towards showing macro things. (#194)
If we think of the use-cases/ directory as discussing common problems and the examples/ as containing their solutions, then that indicates there should even be links between them sometimes. Maybe a use case corresponding to an example can even explain further what makes the solution in the example a good one.
I'm a bit stuck with how to structure each use case, but maybe the Design Pattern Template over at c2.com is a decent starting point?
Hm, maybe the use cases would also be a good place to discuss "common misconceptions" people have about macros? At best, maybe the use cases provide a good hook off which to hang such discussion?
I don't have a good intuition of what makes a "class" of use cases. I mean, they're grouped, for sure. Some use cases are clearly about making an operator, others are about making a statement. But I don't have a sense of exactly how this grouping/hierarchy looks and feels.


[webview] Integration tests hang locally on macOS

Currently none of us are able to successfully run webview_flutter_wkwebview integration tests locally with macOS as the target;  test that try to load a URL and then wait for it to load are hanging indefinitely. What's odd is that the tests still run successfully on CI (we've verified that they are running and passing, not just silently not running). I'm investigating, but filing this to track the investigation (and hopefully provide context for an eventual fix).

So far I've determined:

The local server started in the integration test is not receiving the requests at all (determined by logging requests to a file after turning off sandboxing).
The tests pass if I use real websites instead of the local server (but we don't want to do that; using real websites was a source of OOB failures and flake).
If I log the server address at the start of the run, then load one of its test URLs from a browser while the integration test is hanging waiting for the load that never happens, I do get a response, and I see the request logged.

My current theory is tightening of NSAppTransportSecurity defaults; it sounds like macOS 14 changed the default behaviors for local connections. I'll dig into that more tomorrow.

Fixed: For apps linked on or after iOS 17 and aligned OS versions, App Transport Security now requires secure connections to external IP addresses by default. For more information on these requirements, see Preventing Insecure Network Connections. Exceptions can be made using NSExceptionDomains, which now supports exceptions for individual IP addresses and ranges specified in classless inter-domain routing (CIDR) notation. (101967030)

I haven't been able to get any exceptions to work yet though, and nscurl --ats-diagnostics shows a fail for every configuration it tries.

I'm seeing flaky hangs in CI in what looks like the same tests, and spot checking is that they are hanging on macOS 14 machines.

Strange, just changing the in-process test server to bind to the loopback address seems to be enough to resolve this locally (on macOS 15). I'm not clear on why we don't need any ATS plist entries, but I'll take it.

Thanks Stuart for investigating and fixing this, much appreciated! 💙


the delete a CRDT and update a CRDT issue [JIRA: RIAK-2424]

a mergeable CRDT tombstone - aka write a CRDT tombstone that is an empty map so that it can be merged with the concurrent update

More details from @russelldb -

it comes down to expected/acceptable semantics. If you delete a set [a,b,c,d] and concurrently say to Riak “add e to Set"
what should the result be?
at the moment it would probably be [ [a,b,c,d,e], tombstone] but it arguably should be [e]
both the delete and add should be honoured, with the add winning
so we need to make tombstones for CRDTs that merge with concurrent writes to CRDTs
so a set tombstone would be the empty set+version vector for example

Do I understand correctly that this ticket does not apply to the case delete_mode set to immediate?

[...] it arguably should be [e]
both the delete and add should be honoured, with the add winning
so we need to make tombstones for CRDTs that merge with concurrent writes to CRDTs
so a set tombstone would be the empty set+version vector for example

I see that this semantics would follow the semantics of a set that is a field of a map.


Fruit still spawns in snake

Not entirely sure with this one, but leaving myself a note here that is an issue.

Issue is the snake is not eating the fruit during the collision check 100% of the time.

Put in temporary fix with 31db6b5 commit to master. May be an overflow issue, as notice every once in awhile input becomes unresponsive.


Add _GNU_SOURCE to libevent build for Android builds

The Android NDK doesn't assume _GNU_SOURCE, clang only assumes it for
C++ builds, not C builds. libevent uses pipe2 which in the NDK is only
exposed in the header when these variables are set. In bazel 0.27.0
these implicit use became an error.
More details:

https://github.com/lyft/envoy-mobile/issues/116
https://github.com/libevent/libevent/pull/850

Risk Level: Low

I don't think there should be any negative side effects of setting _GNU_SOURCE for all platforms, since libevent doesn't change behavior on it, it just passes it through. I'm hoping CI will agree

SGTM as temporary workaround, seems no negative effects.


Move New Waterfront Revitalization Plan to Studies & Plans

New Waterfront Revitalization Plan should be moved from Community-Based Plans/197-a list to Neighborhood Studies & Plans list. It should appear for all CDs.

Completely remove existing "Comprehensive Manhattan Waterfront Plan" and "New Waterfront Revitalization Program"  add two new links provided by Mary Kimball, add them to  Neighborhood studies and plans

WRP: http://www1.nyc.gov/assets/planning/download/pdf/applicants/wrp/wrp-2016/nyc-wrp-full.pdf

NYC Vision2020 Comprehensive Waterfront Plan here: http://www1.nyc.gov/site/planning/plans/vision-2020-cwp/vision-2020-cwp.page.

Implemented in the DB, no code change necessary, closing


[ENHACEMENT] Only display the date in ETA Print Time if not today

If the print end time is today. Only show the time and not the date.

implemented with eeda7d2e5f67e26738d0cde45c39cba7bbdbf08a

i will add some logic to idd, somehow

smart timestamp implemented with 4c36d8e9cc8ae705307cc29cc43216f7377c8970


Added moving spinner to context check, since it just kinda sat there

I added some code that puts a spinning indicator in front of the "checking" text. When I did my initial Kubetrim sweep, it sat there for a while (I had a lot of configs). This indicator lets the user know it's actually working in the background. No actual functional changes to how it does it's thing, just this addition.

Added the sign off data.

Hi @Intelrunner can you upload an ASCII cinema showing your change?
You'll also need to use a proper email address and full name for the DCO check to pass here.
Thanks.

Out of interest, I've not seen any hanging or delay. What did you have to do in order to create that condition?


feature request: support symbolic constants for base_address, (do not require it to be a number)

i think it would be nice to be able to write this in the config
[globcfg]
base_address = MY_SYMBOLIC_CONSTANT

or maybe even
[globcfg]
base_address = MY_SYMBOLIC_CONSTANT + SOME_OFFSET

and to get this in the C headers:
#define REGS_BASE_ADDR MY_SYMBOLIC_CONSTANT

or
#define REGS_BASE_ADDR (MY_SYMBOLIC_CONSTANT + SOME_OFFSET)

respectively. maybe we don't need to be able to handle arbitrary strings, but it's probably the same amount of effort (?)
does anybody else like the idea?

implementation could look like this: https://github.com/esynr3z/corsair/pull/51

It's a nice feature, really. But it opens a portal to symbolic calculations instead of concrete numbers, which is not an easy thing to implement and maintain within all templates.
I've also answered to the quite similar topic here, if you are interested.
I thinks this won't be implemented soon, but, indeed, this has to be thoroughly thought.


Optimized images not cached in CF

I am currently debugging complaints of slowness on our NextJS-based webapplication.
A first thing I noticed that the images that are going through the Image Optimizer are always showing "MISS from Cloudfront".
Our "image request route" normally goes like this:
Client -> CF: https://assets.example.com/_next/image?url=https://assets.example.com/uploads/foo.jpg&w=320&q=75 -> API Gateway -> Image Optimizer Lambda -> CF: https://assets.example.com/uploads/foo.jpg -> S3 bucket

(The above url has not been urlencoded to make it more readable, in normal situations it is properly urlencoded)
This results in:

Always a MISS when queried via the above route (with a cache-control: public, max-age=0, must-revalidate
Always a  MISS when queried directly on _next/image? on the API gateway (bypassing the first pass of CF) (with cache-control: public, max-age=0, must-revalidate)
HIT when the image URL (https://assets.example.com/uploads/foo.jpg) is queried directly (with no cache-control response header)

When querying the image directly via the S3 console I do not see any Cache headers in the response either.
I'm not sure where this is going wrong. The CF settings seem to be fine, since querying the file directly (not via optimizer) shows HIT.
The /_next/image behavior in CF has the following cache policy settings:

Min TTL = 0
Max TTL = 31536000
Default TTL = 86400
Headers: Accept
Cookies: None
Query Strings: q, w, url
Gzip: Enabled
Brotli: Enabled

And origin request policy for behavior /_next/image:

Headers: Accept
Cookies: None
Query Strings: q, w, url

For the uploads/* behavior we use "Legacy Settings" with Headers, Query Strings and Cookies all set to "None" and Object Caching set to "Use origin cache headers")
Based off this it appears  that the Lambda may not be setting the appropriate cache headers, which causes CF to skip caching it? If so, is there anything misconfigured on our end or could this be an issue in the Optimizer?

Hi, the cache control response that is issued by the image optimization API depends on the Cache-Control header that is sent by the original image source.
So in your case the image optimizer looks into the Cache-Control header that it receives from https://assets.example.com/uploads/foo.jpg:

If a Cache-Control header is present on the response, it should copy the max-age value from it to the response of the image optimizer (Gets stored in CloudFront)
If no Cache-Control header is present on this response, it defaults to cache-control: public, max-age=0, must-revalidate (Image gets optimized on every request, is not stored in CloudFront)

You can validate this by opening https://assets.example.com/uploads/foo.jpg in the browser, and check the response headers in the network tab of your devTools.
So my suggestion here is, that the Cache-Control metadata is not set on the images in the S3 bucket.

Thanks @ofhouse for your quick and expansive reply 😄
We indeed did not have Cache-Control on the assets in the S3 bucket.
I have solved this by adding a Response Header Policy to the CF distribution, which means that any asset served that does not have Cache-Control header gets one added anyway. And if the asset has a different setting it will be used instead. This seems to work pretty well. The cache now gets hit when we request an optimized image.
However, one thing I noticed is that I set the following on the assets served to the optimizer:
cache-control: public,max-age=31536000,immutable

Yet the optimizer itself produces:
cache-control: public, max-age=31536000, must-revalidate

Which is a bit odd because it appears to be copying the entire cache-control header.

Which is a bit odd because it appears to be copying the entire cache-control header.

I agree, but this behaviour is intentional:
The Next.js image optimizer internally always uses a HTTP request to obtain the original image, as it has no native support for S3.
So what we do inside of this module is to mock the outgoing HTTP request, send a fake response with with the data (body and Cache-Control metadata) from S3 and give it back to the optimizer.
This way the optimizer works with it as the image would be fetched over HTTP (and not from S3).
However we have no control on how the image optimizer generates the Cache-Control response header, because this happens after the step described above.
It parses the values from the source Cache-Control header and then creates a new value for the header: https://github.com/vercel/next.js/blob/canary/packages/next/server/image-optimizer.ts#L575-L580
Since we don't aim to modify the original behaviour of the Next.js image optimizer in this project (Response should always be the same as when you host Next.js in a docker environment or on Vercel), the only way to solve this would be to create a feature request on the Next.js project.

I'm going to close this issue because it has been inactive for 30 days ⏳. This helps to find and focus on the active issues.


[en] Add new validation 'ends_with'

[ar] Translated to Arabic
refresh todo.md

Thank you, and sorry for lag.
I added your work in master branch

Don't worry, I'm here to support you.


[release-0.22] Update the dependencies for 0.22

Proposed Changes

This is an update of the dependencies for the release-0.22 branch.

/lgtm
/approve

/approve


Emulation components created mostly related with spark DataGrid

Hi,
It is ready to be merged @aharui

Do you really need DownloadProgressBar and the Touch-related classes?  Otherwise, try commenting out references to them.

While loading some modules there is a need for progress bar.
Here : https://github.com/likyateknoloji/pinaraui-royale/blob/a145aac0a1b479cda48c5f5c673cd6d2a996dd4f/PinaraUI/src/com/likya/pinara/utils/DownloadProgressBarSubClassMin.as
For touch-related classes, i did not think so much on the subject. Which classe you want to be commented out ?

If you say that there is not going to be the equivalent of any type of indicator to show that the application is being downloaded, than i may remove the emulation and dependency for sure.
While working on emulation, i am not 100% percent sure about the components to be emulated. I am trying to not to go so deep on dependencies and conveting the simple implementations.
I am going to work on the issue in the evening or at least tomorrow.

If you say that there is not going to be the equivalent of any type of indicator to show that the application is being downloaded, than i may remove the emulation and dependency for sure.
While working on emulation, i am not 100% percent sure about the components to be emulated. I am trying to not to go so deep on dependencies and converting the simple implementations.
I am going to work on the issue in the evening or at least tomorrow.


When provisioning an Elemental cluster, the Provider column reads as Elemental Cluster instead of just Elemental

Setup

Rancher version: v2.6.8
Browser type & version: Chrome

Describe the bug

When deploying an Elemental cluster, the display name in the Provider column is shown as Elemental Cluster as shown below:

We should have the name be just Elemental. When provisioning from other baremetal providers such as Harvester, we list it out as just Harvester and not Harvester Cluster. It is redundant to add cluster as we're already in Cluster Management, so a customer will already understand.
Additionally, Cluster Management has this same problem:

This should read as just Elemental as well.
To Reproduce

Setup Rancher and navigate to OS Management.
Create a machine registration and a machine inventory, according to your specifications.
Once done, head to OS Management > Dashboard > Create Elemental Cluster.
Provision an Elemental cluster and note that the Provider name is Elemental Cluster.
Navigate to Cluster Management > Create.
Toggle to RKE2/K3s and note that you see Elemental Cluster instead of just Elemental.

Result
The Provider column shows Elemental Cluster.
Expected Result

The Provider column should show Elemental.

All good with the latest release (0.1.1):

The issue can be closed.