I have one doubt we are using critic llm in evaluation is it differnetn from the llm we used in rag architecture?

[ ] I checked the documentation and related resources and couldn't find an answer to my question.
Your Question
what is unclear to you? What would you like to know?
Code Examples
This community speaks code. Share your code snippets to help us understand your question better.
Additional context
Anything else you want to share with us?

@Saurabh8255 I was wondering about a similar issue, the usefulness of the critic in the TestsetGenerator.from_langchain method (I infer you were talking about this method since there is no critic parameter in the evaluate method) and after having looked for it in the repository, I can't find any reference to the critic parameter apart from the definition of the TestsetGenerator.critic_llm attribute.
I'll let @jjmachan or @shahules786 bring a clear answer and conclude this issue, but I think it might be a relic of a previous version.

After some research I found that it will be better if we use different LLM as critic but make sure that it will me larger model than we used in our RAG architecture.
for better evaluaion.

Yeah, you are theorically right but also empirically right ! I couldn't find where critic_llm was used but I have finally managed to find it : it is used in TestsetGenerator.init_evolution:l226-232 to define filters as described in the guide Using Ragas Critic Model instead of GPT-4.

I see you folks have figure out the answer 🙂 but I'll add my thoughts here too. The reason why there is both generator and critic models is that we found out when developing that for the critic parts of the pipeline (which decides if the generated question or the chosen contexts if useful for further processing) needs a better model for more sterability so we have more control over specifing what the correct parameters are.
We did a small experiment to make a custom model for this which @Gwenn-LR has shared. but we are revamping the testset generation tools with #1014

Thanks for your answer @jjmachan but also all the amazing work of your team !
Since we are discussing of the differences between the LLM used in your package, I'll allow myself to ask another question concerning this matter. Do not hesitate to ask me to express it in another issue, it will be done at your convenience.
After analyzing your repository, I've came to the conclusion there is potentially up to 6 models that can be used end-to-end:

1 embedding function as the attribute of the synthetic generator TestsetGenerator.embeddings and the 1 for the data vectorization in the RAG pipeline to evaluate (here named rag_embedding).
2 LLM as discussed previously as attributes of this generator TestsetGenerator, generator_llm and critic_llm, 1 used during evaluation with any metrics inheriting from MetricWithLLM, llm and finally one from the RAG pipeline itself (here named rag_llm).

I haven't realized a exploration of those parameters and the consequences of their correlation and I think sometimes a single model might be used for different attributes, but for others it might be better to uncouple those ones. I've finally came to an organization based on LLM size and robustness (practical base of evaluation for a common user) and I was wondering if you could send me your thoughts about it:

embeddings =? rag_embedding
critic_llm = llm >= generator_llm > rag_llm

I think embeddings even through different objectives should define a single domain. However, having a embedding for the generation of your synthetic dataset different from the one used in the RAG user pipeline migth also introduce a more diverse generation of data, which could be benefical to the overall evaluation. So I can't reach any clear conclusion with my current knowledge about those.
Since the objective of the critic_llm is the same as llm that is to say the evaluation of different generation (the triplet question <-> context <-> ground_truth for critic_llm and the respective metric for llm), I think the best available model should be used there. The generator_llm is used to generate the synthetic dataset, so the better, the more accurate and diverse should be your synthetic dataset. Moreover, if you (or more specifically, your GPU) can't handle the loading of more than 2 predefined model, first models that should be separated are the generator_llm and your rag_llm since the evaluation of the former's generation depends on the quality of the latter's generation. Furthermore, their is a good chance that your RAG is supposed to be used inside a service and should be as light and quick as possible while the synthetic dataset only has to be generated upstream.
To conclude:

Focus on your rag_llm definition.
Use a "better" LLM for generator_llm if you need to generate a synthetic dataset.
If you don't and/or if you want to use a third one for every evaluation - of the synthetic generation and the metric - you should use a critic_llm and a llm which are among the best available.

I'm eager to read your thoughts about my analysis and to see the evolution of this package. Do not hesitate to ask for any if needed, I would be happy to lend you a helping hand !
Have a nice day !

@Gwenn-LR thank you for the writeup but it was a bit long so I didn't quite understand what you actually had in mind so correct me if I'm wrong
but for this

embeddings =? rag_embedding
critic_llm = llm >= generator_llm > rag_llm

the correct order is
embeddings = rag_embeddings (right now since we don't see a lot of diff in perf and we don't have a big conponent of retriever) it maybe said that embedding < rag_embedding because the actual usecase for retriever is not that much
2nd one is roughly correct but only because of the current setup. generator_llm = rag_llm though. critic_llm can be a smaller fine-tuned model
does address all of your thoughts?

Thanks for your answer and yes it clearly address my point!


🔧 Build Error with react-native-vision-camera Example App on Windows using VS Code

How were you trying to build the app?
I was trying to build and run the example app for react-native-vision-camera on my Windows machine using Visual Studio Code. I intended to use Expo for development. I followed the instructions from the repository to set up the playground by running the following commands:
git clone https://github.com/mrousavy/react-native-vision-camera
cd react-native-vision-camera/package
yarn bootstrap
However, the build fails with a generic "Command failed with exit code 1," and I am unable to find relevant information regarding this error.
Full build logs
PS C:\Users\carol\Desktop\VISION> git clone https://github.com/mrousavy/react-native-vision-camera
>> cd react-native-vision-camera/package
>> yarn bootstrap
Cloning into 'react-native-vision-camera'...
remote: Enumerating objects: 23835, done.
remote: Counting objects: 100% (7085/7085), done.
remote: Compressing objects: 100% (2578/2578), done.
remote: Total 23835 (delta 4364), reused 5966 (delta 3511), pack-reused 16750
Receiving objects: 100% (23835/23835), 102.22 MiB | 18.26 MiB/s, done.
Resolving deltas: 100% (15102/15102), done.
yarn run v1.22.22
$ yarn && cd example && yarn && yarn pods
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "react-native ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native > @react-native/codegen ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native > @react-native-community/cli > @react-native-community/cli-plugin-metro ><EMAIL_ADDRESS>has unmet peer dependency "@babel/core@*".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>
warning "react-native-reanimated ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript > @babel/plugin-transform-typescript ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript > @babel/plugin-transform-typescript ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "react-native-reanimated > @babel/preset-typescript > @babel/plugin-transform-typescript > @babel/helper-create-class-features-plugin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>[4/4] Building fresh packages...
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
$ cd ios && bundle install && bundle exec pod install
Bundler 2.5.9 is running, but your lockfile was generated with 2.3.22. Installing Bundler 2.3.22 and restarting using that version.
Fetching gem metadata from https://rubygems.org/.
Fetching bundler 2.3.22
Installing bundler 2.3.22
Fetching gem metadata from https://rubygems.org/.......

Bundled gems are installed into `./vendor/bundle`
Post-install message from algoliasearch:
A new major version is available for Algolia! Please now use the https://rubygems.org/gems/algolia gem to get the latest features.
Auto-linking React Native modules for target `VisionCameraExample`: RNGestureHandler, RNReanimated, RNScreens, RNStaticSafeAreaInsets, RNVectorIcons, react-native-blur, react-native-cameraroll, react-native-mmkv, react-native-safe-area-context, react-native-skia, react-native-video, and react-native-worklets-core
Framework build type is static library

[!] Invalid `Podfile` file: [!] Unable to locate the executable `mkdir`.

 #  from C:/Users/carol/Desktop/VISION/react-native-vision-camera/package/example/ios/Podfile:26
 #  -------------------------------------------
 #    end
 >  end
 #  # Resolve react_native_pods.rb with node to allow for hoisting
 #  -------------------------------------------
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Project dependencies
{
  "name": "react-native-vision-camera",
  "version": "4.0.1",
  "description": "A powerful, high-performance React Native Camera library.",
  "main": "lib/commonjs/index",
  "module": "lib/module/index",
  "types": "lib/typescript/index.d.ts",
  "react-native": "src/index",
  "source": "src/index",
  "files": [
    "src",
    "react-native.config.js",
    "lib/commonjs",
    "lib/module",
    "lib/typescript",
    "android/build.gradle",
    "android/gradle.properties",
    "android/CMakeLists.txt",
    "android/src",
    "ios/**/*.h",
    "ios/**/*.m",
    "ios/**/*.mm",
    "ios/**/*.cpp",
    "ios/**/*.swift",
    "app.plugin.js",
    "VisionCamera.podspec",
    "README.md"
  ],
  "scripts": {
    "typescript": "tsc --noEmit",
    "lint": "eslint \"**/*.{js,ts,tsx}\"",
    "lint-ci": "yarn lint -f<EMAIL_ADDRESS>    "start": "cd example && yarn start",
    "build": "bob build",
    "release": "bob build && release-it",
    "pods": "cd example && yarn pods",
    "bootstrap": "yarn && cd example && yarn && yarn pods",
    "check-android": "scripts/ktlint.sh && scripts/clang-format.sh",
    "check-ios": "scripts/swiftlint.sh && scripts/swiftformat.sh && scripts/clang-format.sh",
    "check-js": "yarn lint --fix && yarn typescript",
    "check-cpp": "scripts/clang-format.sh",
    "check-all": "scripts/check-all.sh",
    "clean-ios": "scripts/clean-ios.sh",
    "clean-android": "scripts/clean-android.sh",
    "clean-js": "scripts/clean-js.sh",
    "prepack": "cp ../README.md ./README.md",
    "postpack": "rm ./README.md"
  },
  "keywords": [
    "react",
    "native",
    "camera",
    "react-native",
    "react-native-camera",
    "vision",
    "javascript",
    "typescript",
    "android",
    "ios",
    "library",
    "instagram",
    "snapchat",
    "ai",
    "scanner",
    "qrcode",
    "barcode",
    "qr-code",
    "jsi",
    "worklet",
    "module",
    "frame",
    "processing",
    "realtime"
  ],
  "repository": "https://github.com/mrousavy/react-native-vision-camera",
  "author": "Marc Rousavy<EMAIL_ADDRESS>(https://github.com/mrousavy)",
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/mrousavy/react-native-vision-camera/issues"
  },
  "homepage": "https://react-native-vision-camera.com/",
  "publishConfig": {
    "registry": "https://registry.npmjs.org/"
  },
  "devDependencies": {
    "@expo/config-plugins": "^7.2.5",
    "@jamesacarr/eslint-formatter-github-actions": "^0.2.0",
    "@react-native/eslint-config": "^0.72.2",
    "@react-native/typescript-config": "^0.74.0",
    "@release-it/conventional-changelog": "^7.0.0",
    "@shopify/react-native-skia": "^1.2.3",
    "@types/react": "^18.2.19",
    "@types/react-native": "^0.72.2",
    "eslint": "^8.46.0",
    "eslint-plugin-prettier": "^5.0.0",
    "prettier": "^3.0.1",
    "react": "^18.2.0",
    "react-native": "^0.72.3",
    "react-native-builder-bob": "^0.21.3",
    "react-native-reanimated": "^3.8.1",
    "react-native-worklets-core": "^1.1.1",
    "release-it": "^16.1.3",
    "typescript": "^5.1.6"
  },
  "peerDependencies": {
    "@shopify/react-native-skia": "*",
    "react": "*",
    "react-native": "*",
    "react-native-reanimated": "*",
    "react-native-worklets-core": "*"
  },
  "peerDependenciesMeta": {
    "react-native-worklets-core": {
      "optional": true
    },
    "react-native-reanimated": {
      "optional": true
    },
    "@shopify/react-native-skia": {
      "optional": true
    }
  },
  "release-it": {
    "git": {
      "commitMessage": "chore: release ${version}",
      "tagName": "v${version}"
    },
    "npm": {
      "publish": true
    },
    "github": {
      "release": true
    },
    "plugins": {
      "@release-it/conventional-changelog": {
        "preset": {
          "name": "conventionalcommits",
          "types": [
            {
              "type": "feat",
              "section": "✨ Features"
            },
            {
              "type": "perf",
              "section": "💨 Performance Improvements"
            },
            {
              "type": "fix",
              "section": "🐛 Bug Fixes"
            },
            {
              "type": "chore(deps)",
              "section": "🛠 Dependency Upgrades"
            },
            {
              "type": "docs",
              "section": "📚 Documentation"
            }
          ]
        }
      }
    }
  },
  "react-native-builder-bob": {
    "source": "src",
    "output": "lib",
    "targets": [
      "commonjs",
      "module",
      [
        "typescript",
        {
          "project": "tsconfig.json"
        }
      ]
    ]
  },
  "packageManager"<EMAIL_ADDRESS>}

VisionCamera Version
4.0.1
Target platforms
iOS
Operating system
Windows
Can you build the VisionCamera Example app?
No, I cannot build the Example app either
Additional information

[X] I am using Expo
[ ] I have enabled Frame Processors (react-native-worklets-core)
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

Thank you for your prompt response, I was hoping to build with Expo EAS after unpacking the project files.

[!] Invalid `Podfile` file: [!] Unable to locate the executable `mkdir`.

 #  from C:/Users/carol/Desktop/VISION/react-native-vision-camera/package/example/ios/Podfile:26
 #  -------------------------------------------
 #    end
 >  end
 #  # Resolve react_native_pods.rb with node to allow for hoisting
 #  -------------------------------------------

that path is a Windows path, so you are building on a Windows machine. I don't even know how you managed to run pod install?

Yes, I am running the project on a windows PC. I didn't run pod install, the only commands I gave were:
git clone https://github.com/mrousavy/react-native-vision-camera
cd react-native-vision-camera/package
yarn bootstrap
Any advice you have for using EAS to build the Example app would be greatly appreciated!


fix readability code snippet

Hi @davidberenstein1957, thanks for making this PR, looks good, merging!


feat(image): adding loading="lazy" to images in web-components

Related Ticket(s)
Refs https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/5678
Description
This is a feature that would include native lazy loading of imagery.
While it isn't supported across all browsers, it will work in prevelent
browsers like Chrome.
Changelog
Changed

added loading="lazy" to <img>

LGTM thanks @jeffchew!

Thanks @kennylam !
One of the things I noticed is that images aren't fully loaded in the long pages (like the dotcom stories), wondering if we want to skip some of the dotcom stories, or at least suppress the middle section?


fix(angular2.2): wait for angular before disabling debug info

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix a bug that appears with Angular2.2 when using a production bundle.

What is the current behavior? (You can also link to an open issue here)
Currently, when launching a prod bundle, the app doesn't work because of an Cannot convert undefined or null to Object that occurs in the disableDebugInfo function of Angular2.2.
This function tries to delete window.ng.provider, but at the moment of the call of the disabledDebugInfo function, the ng property has not yet been created in the window object because Angular is not yet initialized.

What is the new behavior (if this is a feature change)?
We now wait for Angular to be initialized before disabling debug info and enabling production mode.
This way, the disableDebugInfo call succeed and the app doesn't crash anymore.

Other information:

+1
This exactly what I was looking for 👍 .
Btw, I noticed another error. see attached

I didn't stumble upon the error you get. I'll dig a bit to see what's going on and let you know.
In the meantime, if you have any clue, let me know too.

According to http://stackoverflow.com/questions/35721206/how-to-enable-production-mode-in-angular-2, enableProdMode should be called before bootstraping.
Let me fix my PR

+1 Thanks for the fix.
Now the app does get rendered but with another error message

That's weird, I don't have these errors on my app...
Le jeu. 17 nov. 2016 à 16:14, JihadMotii-REISys<EMAIL_ADDRESS>a écrit :

+1 Thanks for the fix.
Now the app does get rendered but with another error message
[image: screen shot 2016-11-16 at 11 42 12 am]
https://cloud.githubusercontent.com/assets/9051199/20394709/857957ca-acae-11e6-8f94-566afabba923.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular2-webpack-starter/pull/1177#issuecomment-261272889,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGJtSU7Wtkl53lX2LVsPdqju9pEOMpUbks5q_G8-gaJpZM4KyUDi
.

Thanks @clementprevot


Same link data returned on app restart and first link click is empty

We have integrated branch over a year ago and everything was working fine...at least we thought so when we tested the last time around March.
Branch is integrated per docs, autoinstance, and in the activity onStart we init the session with the activity, its data and BranchReferralInitListener.
The first time the link is clicked the BranchReferralInitListener returns empty data on android 7.0 (this also never happened before). I've debugged the Branch code at it seems in the readAndStripParam method the intentState_ is not yet ready.
Note: On android 6.0 the first click returns the clicked data.
But after that every app launch returns that data even though the activity intent data is null!? Debugging the code i can see that the data returned to the listener is getLatestReferringParams() which will read the cached data...but reading throught the docs this data should be cleared when app is restarted. I've checked and all activities are closed so the internal branch activity lifecycle listeners should be aware of this.
Since our gradle link was using 2.+ as the version num i tried using the latest version and a version from from March ( 2.5.9 for ex) but its still happening... Tested on android 7.0 and 6.0.
The craziest thing? I uninstall the apps, restart the phone, install them from Android Studio and the data is still cached without clicking any links :D ?
Any clues? (p.s. we have facebook sdk but we arent using any "deeplinking" features etc..also branch is just
the simplest implementation possible, we share a user id via the BranchUniversalObject)

@engineers-bojan We are sorry that you are facing this issue. This looks really  strange especially getting data after uninstall. We are testing it and will update soon.

@engineers-bojan We have tested this case on Android 7 (Samsung galaxy s8). Seems everything work as expected. Can you please help debugging with the following link
https://branchster.app.link/6LeJADfEeF
This is a  link for out test app which we published in playstore(Code is here https://github.com/BranchMetrics/Branch-Example-Deep-Linking-Branchster-Android).
If this works fine we  can check what is creating issue in your code else could you please provide more details of the device and your test steps

@sojanpr I've tried the demo app with the example link and it works as expected.
I've double checked the implementation just in case, but everything matches the example.
What i've found additionally is that the data resets itself after 5min, as i've i tried repeatedly opening and closing the app and noticed that after a while the data clear.
I've debugged further and found that ServerRequestRegisterOpen executes on app start up and it returns the clicked link data which is then set in prefHelper_.setSessionParams and thus is returned afterward via callback even though no data was sent to the initSession method.  (the ServerRequestRegisterClose is properly executed upon app close and the data in the prefHelper_ is set bnc_no_value)
This leads me to believe that maybe something is wrong with our config in the branch dashboard/console thats keeping the data cached?

@engineers-bojan  Thanks for trying it and checking your implementation. Our awesome integration team can help you very quickly with  any issue you face with Branch dashboard config. Could you please write to<EMAIL_ADDRESS>

Can you confirm that this issue is related to the dashboard config, as i only mentioned it as a hunch since everything else seems ok...i would also like to add that the configuration hasnt been changed since we first implemented it so i am still skeptical about it and besides there are no caching options in the dashboard or similar.

@engineers-bojan Since this is happening only for the links to your app and we need to check the links for moving further on this. Suspect there may be a match_duration set for the links

This is happening with me also in the app.. nothing is changed in the app in branch implementation but couldn't figure out its returning old data, after reinstalling the app, restarting the phone.

@fahimsakri Are you seeing the old data returned to you after installing the app? It would be really helpful if you are provide the steps you do and the link you are using to figure out the issue. I think we can support this case better with our awesome  integration team. Could you please write to<EMAIL_ADDRESS>and lets resolve it there.


google signIn provider issue

id_token for Google provider requires a length 1000+ chars as supposed to VARCHAR(191)

Thank you @exponent42! Let us know if you have any other issues.


t is not a constructor (using .min.js from jsdelivr 1.1.0)

I'm attempting to use this on my webpage (it's an internal company one) but the Chrome devtools keep coming up about 't is not a constructor'.
All i'm doing is:
window['delegate-events'].on('click', '.btn-delete', function(e) { console.log(e); });

.btn-delete is a button on a dynamic table row, the error occurs when I load the page, if I then click on the button it does nothing.

It would appear, that to use this in the browser, one also needs to make sure they have the 'Selector-set' JS loaded before hand.
Once I did that, the library started working just fine.


Guardian SLFs missing: XG7 Trident, XG8 Javelin, XG9 Lance

Details about the Guardian SLFs from the wiki:
https://elite-dangerous.fandom.com/wiki/XG7_Trident
https://elite-dangerous.fandom.com/wiki/XG8_Javelin
https://elite-dangerous.fandom.com/wiki/XG9_Lance

YEYE! We need these. (Though it would be just the XG9 Asset)


base library

MiniTest or uTest are current front runners
Use JUnit? (what about Scala Native?)
and testz?

criteria

signs Scala CLA (transfers copyright to Lightbend/EPFL)
supports JVM, Scala.JS, and Scala Native
(therefore) supports Scala 2.11, 2.12, and 2.13
integrates with sbt's sbt/test-interface
other than that, smaller the better

In terms of simplicity and ready sbt integration, I think Minitest is the best candidate for the starting point https://github.com/monix/minitest.
import minitest._

object MySimpleSuite extends SimpleTestSuite {
  test("should be") {
    assertEquals(2, 1 + 1)
  }

  test("should not be") {
    assert(1 + 1 != 3)
  }

  test("should throw") {
    class DummyException extends RuntimeException("DUMMY")
    def test(): String = throw new DummyException

    intercept[DummyException] {
      test()
    }
  }

  test("test result of") {
    assertResult("hello world") {
      "hello" + " " + "world"
    }
  }
}

I made a list of features/properties that test frameworks could have, that may be relevant for consideration. I believe all properties to be useful for a minimal test framework, though none (other than plain assertions) are probably entirely essential. Comparing the libraries mentioned abovem minitest, utest and testz on these points could be a nice start. Pinging framework authors @edmundnoble @lihaoyi-databricks and @alexandru
Not mentioned were scala test-state, ffstest, scalacheck, scalaprops, discipline, claimant and hedgehog, though I suppose though could be evaluated on the same points.

Size (# jars, binary size, loc)
Plain assertion
Equals assertion
Testing in/with/of Future
Testing in/with/of other effects
Testing Exceptions
Other assertion/matchers
Plain assertion failure messages
Equals assertion failure messages (diffs?)
Running test(suite)s stand alone
Running test(suite)s in sbt
License

Starting with what I see from minitest above:

size: 1 jar, 117 kb, ?? loc
plain assertion: test("should not be") { assert(1 + 1 != 3) }
equals assertion: test("should be") { assertEquals(foo, bar) }
testing Futures: ???
testing other effects: ???
exceptions:

def test(): String = throw new DummyException
intercept[DummyException] { test() }

other assertion/matchers: ???
plain assertion failure messages: ???
equals assertion failure messages: ???
running stand-alone: ???
running in sbt: ???
license: apache 2

Hello,
In case you want to use Minitest or parts of it, I agree with transferring the copyright to Lightbend or whatever license changes you want.
For the criteria ...
Testing Future is supported via testAsync:
testAsync("some future") {
  Future {
    assertEquals(foo, bar)
  }
}

Testing "other effects" is not supported directly, since that would imply extra dependencies, however all you really need is Future support, since all others can be translated to Future. You can for example have something like this in your project and all is good:
import cats.effect._

def testEffect[F[_] : Effect](name: String)(f: => F[Unit]): Unit =
  testAsync(name) {
    val p = Promise[Unit]()
    Effect[F].unsafeRunAsync(r => p.complete(r.toTry))
  }

Could use some improvements ... assertEquals for example could do a smart diff between the tested data structures. I've seen other libraries do this and seems to be useful.

running stand-alone

Minitest does not run standalone, depending entirely on sbt. It could be made to run standalone, but that's more work than I wanted to do and I never saw the need.

@alexandru Thanks for your generous offer. I've pushed the commits from master into this repo :)

So I take it the discussion is effectively over then?

@martijnhoekstra Yea. We're moving forward with using Minitest as the starting point.

So whats the process from here for conpeting proposals?

@martijnhoekstra I guess it depends on what you mean by competing proposals. This is a result reached from a long-winding discussion that started in https://github.com/scala/scala-dev/issues/641 and continued over here, and I for one is ready to move on to looking at code, and focusing on details.

Sure, this is your proposal, your call, so counter proposals should
probably live in a separate repository.
So that's what I'm asking about - at the point where a decision has to be
made which strawman to choose, what is the process that chooses that going
to look like?
On Thu, Jul 25, 2019, 21:21 eugene yokota<EMAIL_ADDRESS>wrote:

@martijnhoekstra https://github.com/martijnhoekstra I guess it depends
on what you mean by competing proposals. This is a result reached from a
long-winding discussion that started in scala/scala-dev#641
https://github.com/scala/scala-dev/issues/641 and continued over here,
and I for one is ready to move on to looking at code, and focusing on
details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scala/nanotest-strawman/issues/1?email_source=notifications&email_token=AAGXOENOCOPS44NDB5MYVI3QBH4NDA5CNFSM4IECSOR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22QLMI#issuecomment-515179953,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGXOEIYQWDWBEVDXBCERDDQBH4NDANCNFSM4IECSORQ
.

So that's what I'm asking about - at the point where a decision has to be
made which strawman to choose, what is the process that chooses that going
to look like?

I have not thought about the process. It's supposed to a summer project, so at the end of summer we'd both present modules and/or pull request to scala/scala, and people can comment on it?

We seem to be having the same question about that.
On Thu, Jul 25, 2019, 22:19 eugene yokota<EMAIL_ADDRESS>wrote:

So that's what I'm asking about - at the point where a decision has to be
made which strawman to choose, what is the process that chooses that going
to look like?
I have not thought about the process. It's supposed to a summer project
https://contributors.scala-lang.org/t/summer-of-usability/3484, so at
the end of summer we'd both present modules and/or pull request to
scala/scala, and people can comment on it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scala/nanotest-strawman/issues/1?email_source=notifications&email_token=AAGXOEKGJ7XFF2FMC3ETI7DQBIDFDA5CNFSM4IECSOR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22U6MQ#issuecomment-515198770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGXOEK75JTZAJGYK3IOVEDQBIDFDANCNFSM4IECSORQ
.


Add build and systemd deploy example

Resolves #80. Don't merge until "specs" are renamed to "profiles" #49.

All makes sense and seems to conform to the FHS.


ImportError: No module named cloghandler

执行./cobra.py --help，ConcurrentLogHandler模块已经安装了，cloghandler包找不到是为什么？
Traceback (most recent call last):
File "./cobra.py", line 18, in
from cobra import main
File "/home/cobra/cobra/init.py", line 21, in
from .log import logger
File "/home/cobra/cobra/log.py", line 19, in
import cloghandler
ImportError: No module named cloghandler
要求的模块已安装：
Requirement already satisfied: Flask==0.10.1 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 1)) (0.10.1)
Requirement already satisfied: Flask-RESTful==0.3.6 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 2)) (0.3.6)
Requirement already satisfied: rarfile==2.7 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 3)) (2.7)
Requirement already satisfied: prettytable==0.7.2 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 4)) (0.7.2)
Requirement already satisfied: requests==2.6.2 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 5)) (2.6.2)
Requirement already satisfied: pytest==3.0.6 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 6)) (3.0.6)
Collecting pip==9.0.1 (from -r requirements.txt (line 7))
Using cached https://files.pythonhosted.org/packages/b6/ac/7015eb97dc749283ffdec1c3a88ddb8ae03b8fad0f0e611408f196358da3/pip-9.0.1-py2.py3-none-any.whl
Requirement already satisfied: phply==1.0.0 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 8)) (1.0.0)
Requirement already satisfied: Werkzeug==0.11.9 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 9)) (0.11.9)
Requirement already satisfied: ConcurrentLogHandler==0.9.1 in /usr/local/lib/python2.7/site-packages (from -r requirements.txt (line 10)) (0.9.1)
Requirement already satisfied: Jinja2>=2.4 in /usr/local/lib/python2.7/site-packages (from Flask==0.10.1->-r requirements.txt (line 1)) (2.10)
Requirement already satisfied: itsdangerous>=0.21 in /usr/local/lib/python2.7/site-packages (from Flask==0.10.1->-r requirements.txt (line 1)) (0.24)
Requirement already satisfied: pytz in /usr/local/lib/python2.7/site-packages (from Flask-RESTful==0.3.6->-r requirements.txt (line 2)) (2018.4)
Requirement already satisfied: six>=1.3.0 in /usr/local/lib/python2.7/site-packages (from Flask-RESTful==0.3.6->-r requirements.txt (line 2)) (1.11.0)
Requirement already satisfied: aniso8601>=0.82 in /usr/local/lib/python2.7/site-packages (from Flask-RESTful==0.3.6->-r requirements.txt (line 2)) (3.0.0)
Requirement already satisfied: py>=1.4.29 in /usr/local/lib/python2.7/site-packages (from pytest==3.0.6->-r requirements.txt (line 6)) (1.5.3)
Requirement already satisfied: setuptools in /usr/local/lib/python2.7/site-packages (from pytest==3.0.6->-r requirements.txt (line 6)) (39.0.1)
Requirement already satisfied: ply in /usr/local/lib/python2.7/site-packages (from phply==1.0.0->-r requirements.txt (line 8)) (3.11)
Requirement already satisfied: MarkupSafe>=0.23 in /usr/local/lib/python2.7/site-packages (from Jinja2>=2.4->Flask==0.10.1->-r requirements.txt (line 1)) (1.0)

已解决，设置PYTHONPATH环境变量，将模块安装路径加入Python搜索路径sys.path中
export PYTHONPATH=/usr/local/lib/python2.7/site-packages


OP-20624 : Query param changes

https://devopsmx.atlassian.net/browse/OP-20624

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01H45EQQRWW457BZVG2FT1M2NC

This PR  triggered this build in this execution, please wait for it  and child pipelines to succeed before merging:  https://isd.prod.opsmx.net/deck/#/applications/dev-oesaona-4x/executions/details/01H45EQQS48N5RKTP324XZKK5A


[MWPW-125175] Nav Links refactor

This is a refactor of the Gnav links decoration, popups/dropdowns (sync or async, normal or mega-menu style), headliness and CTAs. It also scopes the CSS custom properties used by FEDS to avoid collision with other parts of the application.
A few additional improvements worth mentioning:

the logic will now follow the structure as authored in Word, it is no longer opinionated on item order;
the headlines now act as accordion headers for subsections on mobile.

This PR also fixes two bugs related to Search:

https://jira.corp.adobe.com/browse/MWPW-127264 (ensure correct curtain styles when Search is open)
https://jira.corp.adobe.com/browse/MWPW-127263 (clear Search input and results when trigger is clicked)

Resolves: MWPW-125175
Test URLs:

Before: https://feds-gnav--milo--overmyheadandbody.hlx.page/drafts/ramuntea/gnav-refactor?martech=off
After: https://mwpw-125175-nav-links--milo--overmyheadandbody.hlx.page/drafts/ramuntea/gnav-refactor?martech=off

Regarding the promo, it will be implemented in another PR and any styled deemed unnecessary will be removed then.

While testing the gnav menus, I noticed some layout issues with the gnav promo card that is part of the Medium Dropdown menu on this test page: https://mwpw-125175-nav-links--milo--overmyheadandbody.hlx.page/drafts/ramuntea/gnav-refactor?martech=off

Shouldn't this have a clear card-like appearance and constraints? On adobe.com in production, this looks much better:

Regarding the promo, it will be implemented in another PR and any styled deemed unnecessary will be removed then.

@honstar - I think @overmyheadandbody answered it here https://github.com/adobecom/milo/pull/533#issuecomment-1457913145

Yup, I've discussed this with @overmyheadandbody and it's something he will tackle next in a new PR - this one is already big enough as is and I'll build up on the logic in a coming feature so we want to merge this initial code.

Hi @honstar! As already mentioned, the promo will be handled in a future commit, but we need the ground work from this PR to unblock other stories.
Also, this PR is open against a feature branch, feds-gnav, not the main one, so production will not be affected by this change.


make accountId always part of URL

One goal would be to always provide a linkable URL to any user when they arrive on the profile page. This is pretty much always done when we link to a specific profile page from within app, but when wallet-connected user clicks on Profile that easy link sharing functionality is currently gone.
Proposal
Make sure the user accountId is always part of the profile URL. Could be done in multiple ways like:

append accountId to the actual menu link, so the profile page always gets its account from there
append accountId to URL after user arrives there

Should we show the my account link when there is no wallet connected? If we do, what would it's behavior be?
I think the first options is easier and less error prone.

I think depends on how good we are in making account page useful without wallet. So far we do not hide pages but always have fallbacks within them so users can still get the idea of the app screens.
From #776:

Ideal case would be to resemble the final layout with received data as much as possible when no data is present at all but also uninspired what those fallback values should be. Stats numbers could simply use 0 as fallback and right away we would have some layout up there

Another way would be to hide everything on this page without wallet, and instead show some kind of account explore thing listing multiple account teasers users can explore.

yeah nope, we have to ditch that. After tinkering around in #776 we need a separation between a page which always renders other accounts, and one which reacts to web3 account changes. Trying to have those 2 use cases together quickly ends up in usability nightmare, like logged in user watches other profile, then switches wallet account, and we would need to switch from other profile to user account profile? Feels weird. So best strategy seems to be keeping the blank /profile route to be the one reacting to web3 account changes, and the routes with accountId at end of path for always rendering other profiles

Good point. Maybe on the profile page we add a button with Share profile and we copy to clipboard the full url


Project is not running

I am getting the following error
file_get_contents(/var/www/html/LA/public/build/rev-manifest.json): failed to open stream: No such file or directory (View: /var/www/html/LA/resources/views/index.blade.php)
where /var/www/html/LA is my Project Directory. I followed the processes of installation . when I trigger php artisan serve and try to run it on localhost:8000 , then I got the error.

you have a wrong build path, try checking your elixir.json and enter correct path. then rebuild again by gulp --production

elixer path is /var/www/html/LA/elixir.json
Here is the same copy paste code for index.balde.php file
<!doctype html>

Laravel Angular Admin-LTE

yep open /var/www/html/LA/elixir.json and put correct path, then rebuild using gulp --production

Kindly share me where and how to change the path....
This is my elixir.json  file with path /var/www/html/LA/elixir.json
{     "js": {         "outputFolder": "public/js"     },     "css": {         "outputFolder": "public/css",         "sass": {             "folder": "../../angular/"         },         "lteSkin": "skin-blue.css"     },     "fonts": {         "outputFolder": "public/fonts"     },     "buildPath": "public/build" }


Target .NET Standard 2.0 and add .NET Framework 4.6.1 testing

FYI this branch passes locally but will fail on AppVeyor and Travis until UniverseCoherence passes.

9b017ad


[tiny-build] Add curl

@ibiqlik thanks for the submission - I'm OK with it, though is wget not good enough for your purposes?

@hairyhenderson we have some curl POST templates that we would like to continue to use as is, otherwise if you strongly object we can try to adapt them to wget.


Lack of a License

Hello,
Would you consider adding a license to this repo? I'm sure it's just an oversight, seeing how many of the related repos do have one.
(I'd submit a PR but that seems problematic for a license :grin: )
Thanks!

Done! Good catch.


⚠ ClamAV has degraded performance

In 60aec23, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 62 ms

Resolved: ClamAV performance has improved in 590f5ce after 8 minutes.


[Roadmap / Question]  What requirements are remaining until you have the first release?

Hello!
I saw that this library is in the release-candidate stage.  I am wondering a few things:
Questions:
1.) What requirements remain before this can be released as Version 1.0.0?
2.) Do you have a roadmap or a list of features / goals that you'd like to implement? I
I would rather work on items that are of interest to you!
Final
Please let me know so I can work on submitting some pull requests <3
Thanks!

That's a great question.
Yes, there a couple of things that I would like to add e.g download an entire folder, concurrent downloads via multiple threads, thread pooling etc.
I don't have a roadmap documented somewhere, I just have it in my head.
Suggestions & Pull requests are welcome.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_dc2p01y24z/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_dc2p01y24z/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_dc2p01y24z/clone/recipe/meta.yaml:40: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_dc2p01y24z/clone/recipe/meta.yaml:40: missing_description: The recipe is missing a description
Errors were found


Add PHP 7.4 to travis CI

We should be able to see if PHP 7.4 fails in the tests.

In OAuth2Middleware.php a class has been replaced with a new version:

In our current api/config/oauth2.php

@islandjoe Your comments might be out of this context? This just adds PHP 7.4 pre-testing to Travis.

In nordsoftware/lumen-oauth2/config/oauth2.php, adapter is referring to the EloquentAdapter

But it's not listed in the composer.json:

Nor does it exist in nordsoftware's own package:


PYTHON-4381 Add DocArray to AI Integration Pipeline Testing

LGTM.
The atlas construction failed, but since we're using an atlas uri for now, it's fine.
Once #21 goes in, we can circle back and try getting the local atlas running.


[MM-45749] Support for advanced ICE server configs and TURN credentials

Summary
Porting https://github.com/mattermost/mattermost-mobile/pull/6371 and https://github.com/mattermost/mattermost-mobile/pull/6404 to v2.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45749
https://mattermost.atlassian.net/browse/MM-45751
Release Note
Added support for advanced ICE server configs and short-lived TURN credentials.

We should wait for this to be tested on iOS, like #6543

We should wait for this to be tested on iOS, like #6543

@cpoile added labels on both PR's to wait for next release... if you happen to test it before today's build and want to merge them, feel free to do so.

Tested on iOS, good to go.


Possible to return word/token level confidence and time stamp/offset via Python binding?

Question
Dear Sirs,
I am currently using the Python binding for Flashlight, working with the LexiconDecoder and KenLM classes to build a decoder for an ASR model I have. I currently call the decode method on the LexiconDecoder object (which is the binder class connecting Python to the C++ flashlight libs) with my ASR model emissions output (via a pointer), and everything works well.
However, I note that the flashlight.flashlight_lib_text_decoder.DecodeResult class contains only 5 attributes: amScore, lmScore, score, tokens, and words.
My question is: is there any way to possibly get the per-word or per-token confidence score from the decode method call, and, is there any way to get some information about the time step or approx time offset of each decoded word/token? The goal with the latter would be to then perform some sort of alignment between transcription and text.
I apologise if this is already documented or done somewhere else in flashlight, but I am working solely with the Python binding.

@trias702 — you'd have to modify both the C++ source and bindings to get those values. If they're not bound now, there isn't a way to get them. cc @tlikhomanenko.


feat: bump general image to 15.5 and use it for promote job

Update general job to SLE 15.5 and replace busybox with SLE 15.5 in promote job.
Related Issue:
https://github.com/harvester/harvester/issues/4839
Test plan:
Provision 3-node harvester in airgap environment.

@Mergify backport v1.2


[BUG] Cannot output to STDOUT when using libav codec with libcamera-vid

When using libcamera-vid with output "-", it normally prints binary data to the console:
libcamera-vid  --nopreview  -o -
However when using libav codec, instead, it writes data to a file named "-"
libcamera-vid  --nopreview --codec libav --libav-format mp4 -o -
A similar problem has been solved for images (https://github.com/raspberrypi/libcamera-apps/issues/139), but this bug here seems quite different.
(Tested on a raspberry pi zero)

stdout from libav is not currently supported in the software.  However, it ought to be easy enough to add in.  I will look to do this when I get a chance.

As a workaround you can use -o pipe: to pipe to stdout.  Note that you cannot pipe to stdout with --libav-format mp4.  This is probably because the mp4 format needs to seek back to the start of the stream to write headers and other things.  Instead, you can use --libav-format h264 or --libav-format mpegts.

https://github.com/raspberrypi/libcamera-apps/pull/380 ought to fix this.

Thanks a lot, "pipe:" works indeed fine with mpegts, in the meantime   :)


Migrate to using keypair generation and validation from library-go

/cc @stlaz @sttts

/hold

/hold cancel
Ready for review

/retest

/retest

/retest

/retest


RHEL-07-020600 prelim.yml should parse /etc/passwd unconditionally

Describe the Issue
The prelim.yml should parse /etc/passwd unconditionally.  Currently it does not always run which causes issues further down the script.
Control(s) Affected
RHEL-07-020600
Possible Solution
Set the tag to -always in prelim.yml at RHEL-07-020600

hi @prestonSeaman2
Thank you again for this issue. The fix has been applied and is now in the main branch and release. I will close this issue, Please reopen if you feel this is not resolved.
Many thanks
uk-bolly


Created bash functions to simplify endpoint verification and reusability

Bash functions stored in bin that run concurrently in subshells
Function can test an array of endpoints if more services are deployed as the solution matures

I will close this PR


Unexpected results when specifying stop words as Regexps

FuzzyMatch.new(['AAI Limited', 'LITED'], :stop_words=>['limited']).find('AAI Limited')
=> "AAI Limited"  # good

FuzzyMatch.new(['AAI Limited', 'LITED'], :stop_words=>[/limited/i]).find('AAI Limited')
=> "LITED"  # bad

I would expect the same result in either case, given the absence of special characters in the regexp.

Also found:
FuzzyMatch.new(['AAI Limited', 'LITED'], :stop_words=>[/limited/]).find('AAI Limited')
=> "AAI Limited"

So the case insensitive modifier seems to be having an undesirable impact...

This appears to have already been fixed in the repo, but not updated on rubygems.
To be clear, the issue is not with the /i Regexp flag. Rather, [/limited/i] is the only version of the stop word that works! You can try it yourself:
pry(main)> FuzzyMatch.new(['AAI Limited', 'LITED']), stop_words: [/limited/i])
=> #<FuzzyMatch:0x007fd394393388
 ...
 @haystack=[w("AAI"), w("LITED")],
 ...
 @stop_words=[/limited/i]>

vs
pry(main)> FuzzyMatch.new(['AAI Limited', 'LITED']), stop_words: [/limited/])
=> #<FuzzyMatch:0x007fd394393388
 ...
 @haystack=[w("AAI Limited"), w("LITED")],
 ...
 @stop_words=[/limited/]>

The problem is that the when you try to #find('AAI Limited'), the old version (the one on rubygems) only filters the stop word out of the ‘haystack’, and not out of the ‘needle’. Thus, applying the stop word makes it search for ‘AAI Limited’ in ‘AAI’ / ‘LITED’, when it should be search for just ‘AAI’.
This was fixed as of 4f914f2 (7/20/2015). To use the most recent version of this gem, try the following line in your Gemfile:
gem 'fuzzy_match', :git => 'https://github.com/seamusabshere/fuzzy_match.git'


breaks system-wide modifiers

System wide, combinations of keystrokes and trackpad gestures do not work if Karabiner Elements is installed. These include Control-Scroll to control the hardware display zoom, or command-option-drag in the Finder to create an alias.

See #89


react-native bundle can't resolve symlink in node_modules and doesn't provide --root options

Is this a bug report?
I think this is a bug.
I use lerna for monorepo. The following is my project structure
monorepo/
  |-- lerna.json
  |-- package.json
  |-- ...
  |-- packages/
  |      |-- foo-module/
  |            |-- package.json
  |            |-- ...
  |-- apps/
         |-- my-react-native-app/
               |-- package.json
               |-- node_modules/
               |      |-- foo-module/  # this is a symlink to ../../../packages/foo-modules
               |-- ...

I have a react-native project under apps/my-react-native-app, and it use a local module foo-module by lerna with yarn symlink.
For development, I need to add --root to react-native start resolve the symlink module correctly:
$ react-native start --root ../../packages

Now I have to pack the js bundle, but adding --root to react-native bundle doesn't work:
$ react-native bundle --platform android ...{other flags}...  --root ../../packages

Scanning 966 folders for symlinks in {path_to}/monorepo/apps/my-react-native-app/node_modules (10ms)

  error: unknown option `--root'

I can't bundle my rn app directly without --root (the foo-module can't be found):
$ react-native bundle --platform android ...{other flags}...

Scanning 965 folders for symlinks in /Users/Xaree/Development/ofo/ofo-monorepo/apps/ofoBikeIntl/node_modules (9ms)
Scanning 965 folders for symlinks in /Users/Xaree/Development/ofo/ofo-monorepo/apps/ofoBikeIntl/node_modules (9ms)
Loading dependency graph, done.

Unable to resolve module `foo-module` from `{path_to_file}`: Module does not exist in the module map

This might be related to https://github.com/facebook/react-native/issues/4968
To resolve try the following:
  1. Clear watchman watches: `watchman watch-del-all`.
  2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
  3. Reset packager cache: `rm -fr $TMPDIR/react-*` or `npm start -- --reset-cache`.

The react-native bundle lacks the --root option.
Have you read the Contributing Guidelines?
YES
Environment

react-native -v: 0.46.4 (cli: 2.0.1)
node -v: v8.3.0
npm -v: 5.4.1
yarn --version: 0.28.4

Then, specify:

Target Platform: Android

Development Operating System: macOS 10.12.6

Build tools: react-native-cli

Steps to Reproduce
(please see above)
Expected Behavior
(please see above)
Actual Behavior
(please see above)

Almost the same here, monorepo where one of the packages is React Native project and it should require another "neighbor" package.
As far as I understand internal React Native Packager can't handle any files from "outside" of its root. Symlinks and babel-plugin-module-resolver doesn't work.
Any soultion?

https://github.com/facebook/metro-bundler/issues/1

i have the same issue
because of i change entry point to index.android.js
so the solution is to change your entry point
or simply change name of index.js in project root Directory to index.android.js


ExtractSVGPlugin outputs [object Object] for all symbol IDs

As @farwayer posted here:
https://github.com/kisenka/svg-sprite-loader/issues/54#issuecomment-253815810
And the demo:
https://github.com/kisenka/svg-sprite-loader/issues/54#issuecomment-253931813
I wanted to open a dedicated issue for this so that they is somewhere to track it that isn't just the end of a already closed issue (#54).
@kisenka, is this what you were trying to work out in this repo? https://github.com/kisenka/multiple-extract-text-webpack-plugins

@rosscourt > is this what you were trying to work out in this repo?
yes.
If you want to extract symbols in separate file via extract-text-webpack-plugin and want import statement to return a symbol id you anyway should patch extract-text-webpack-plugin loader :(

Hello! I tried to use Extract SVG too. Here's a workaround I came up with: you can run two separate/parallel builds, first one with loader to make your client bundle and insert correct ids into your 's, and second with extract to create bundle svg file.
Seems OK for me for now, 'cause I'm experimenting with pre-rendering html files for certain routes of my app using two separate builds.

@kirill-kruchkov
That's weird<EMAIL_ADDRESS>with proper extracting mode is on the way, please read about it here #91 and take part in discussion/voting.

@kisenka well, it's ok for experimentation. Never goes to production :)

Closing this because proper sprite extracting was implemented in new 2.0 version. Please update.


error in unload method in sshkey client

error in unload method in sshkey client,

sshkey_client = j.clients.sshkey.get(name=SSHKEYCLIENT_NAME, passphrase_=PASSPHRASE)
sshkey_client.unload()

verified.


BUILD ERROR -- bundler not found

ERROR:
bundle install --jobs=3 --retry=3 --deployment
Traceback (most recent call last):
	4: from /home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:15:in `<main>'
	3: from /home/travis/.rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:15:in `eval'
	2: from /home/travis/.rvm/gems/ruby-2.5.1/bin/bundle:23:in `<main>'
	1: from /home/travis/.rvm/rubies/ruby-2.5.1/lib/ruby/2.5.0/rubygems.rb:308:in `activate_bin_path'
/home/travis/.rvm/rubies/ruby-2.5.1/lib/ruby/2.5.0/rubygems.rb:289:in `find_spec_for_exe': can't find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException)

Please see for resolution https://bundler.io/blog/2019/01/04/an-update-on-the-bundler-2-release.html

@lfittl Please help..

Following PRs are encountering the issue..
https://github.com/lfittl/pg_query/pull/139
https://github.com/lfittl/pg_query/pull/140
https://github.com/lfittl/pg_query/pull/143
Please tell me if this is an issue on my end.. Thanks..

@himanshu-pro Could you rebase to the latest master?
This seems to have been an issue with the specific Ruby version. Thanks!

@lfittl Thanks a lot.. Have made the appropriate changes..


Shader throws [.WebGL-0x7fccc403c000]GL ERROR :GL_INVALID_OPERATION warning

As discussed here: https://forum.playcanvas.com/t/matcap-in-playcanvas/11574
A seemingly simple demo scene is throwing [.WebGL-0x7fccc403c000]GL ERROR :GL_INVALID_OPERATION : glDrawElements: Source and destination textures of the draw are the same.
The shader is very simple and there doesn't seem to be an obvious reason for this warning.
Direct link to the demo project:
https://playcanvas.com/project/575970/overview/matcap-shaders
The issue is seen on both MacOS 10.14.6 in Chrome and Firefox as well as Windows 10 in Chrome.

In this example, you do not render anywhere into texture?
This is usually due to OpenGL limitation of reading and writing to the same texture during same draw call.

No, it's just manipulating the normals as far as I can tell.

It appears that the warning has something to do with how realtime shadows are rendered.
I just discovered that if I turn off shadows on the model and instead enable them in code with a delay to make sure that shadows are rendered after the custom material has been applied, the warning is no longer logged in the console.
If I enable shadows first, the warning is logged as soon as the custom material is applied.

The errors generated on Safari are due to having WebGL 2.0 experimental feature enabled. Please disable this as Safari support for WebGL 2.0 is incomplete.

Closing this because we suspect the warning is caused by an incomplete WebGL 2 implementation in iOS Safari. Please reopen if you believe we have reached the wrong conclusion.


Error: This version of ChromeDriver only supports Chrome version (xxx)

Problem:
Error wrong chromedriver version installed.
Solution 1:

Uninstall chromedriver-py by running python -m pip uninstall chromedriver-py in command line.
Run the script again. It should download the required version. If you encounter the same error, proceed to solution 2.

Solution 2:

Uninstall chromedriver-py by running python -m pip uninstall chromedriver-py in command line.
Determine your current Chrome browser version:

Open your Chrome browser and go to chrome://settings/help.
Alternatively, go to Settings > About Chrome in your Chrome browser.
Check the version number (e.g., 112... or 111, etc.).

Visit the chromedriver-py releases page and find the latest version that matches the prefix your Chrome version. Copy the corresponding version number. For example, if you are using Chrome version 112..., you would need version 112.0.5615.49.
Install the correct chromedriver version by running python -m pip install chromedriver-py==VERSION_NUMBER in command line. Replace VERSION_NUMBER with the version you copied in step 3. Press enter to install.
Run the script again. It should now function properly.

I am struggling to use the IMDB-Trakt-Syncer script without having Chrome installed. I fit a scenario where I cannot install Chrome on this PC, and therefore the ChromeDriver "cannot find Chrome binary".
I can however have "Chrome for testing" extracted as a portable/zip, from a site such as this. Would it be possible to point the ChromeDriver to this binary, and if so how does one do that?


Broken dynamic method call in ZCL_ABAPGIT_TADIR

The method name in the dynamic call below is, as far as I can tell, misspelled:
https://github.com/larshp/abapGit/blob/d36b43defe2949fc53c880206ebb8537f21d0463/src/zcl_abapgit_tadir.clas.abap#L256
Class ZCL_ABAPGIT_OBJECT_SICF contains a public static method read_tadir_sicf, but not read_tadir.

yea, its a problem, either remove it since it does not work(has it ever worked?)
or change

There is some additional ugliness here that makes me not want to just remove the broken call just yet...
zcl_abapgit_objects=>warning_package_find tries to warn the user, when deserializing an object would modify something outside of the package being imported. This sounds like an important feauture, but it relies on zif_abapgit_tadir~read_single.
This sounds to me like this needs fixing rather than removal, but a proper fix should:

enhance zif_abapgit_object with a method for TADIR entry lookup,
rework the dynamic call to instead call the above method,
add implementations of zif_abapgit_object~<new_method_name> to the relevant object handler base class(es) and provide an override for the SICF handler,

Problem is, business has moved on and I'm basically out of time to dedicate to abapGit. ☹

@Elberet the comment above seems unrelated to the initial issue raised, suggest opening it as a separate issue


Docs: add CSS example for toast component

#574 added css preview for toast component

@TGlide hey there! is there anything i could do from my end to ensure that the deployment won't fail?

@TGlide hey there! is there anything i could do from my end to ensure that the deployment won't fail?

Not really, it wasn't an issue on your end. Fixing it now!


fzf run by itself

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

This might be a dumb question but I haven't got fruitful result via searching Google or skimming existing issues. Firstly, what's fzf supposed to do if I run fzf without any parameters? On my computer it gives me a list of, like hundreds of thousands of files. I feel, but not assure, that it's doing something like find . -type f -print. If I select any item, it just print it, nothing more. My second question is: is there any way to change the default behavior (sorry if it's already in man but I didn't find it)? Thanks in advance.

See https://github.com/junegunn/fzf#usage


update client-c to disable grpc client keepalive

Signed-off-by: xufei<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #4192
Problem Summary:
TiFlash will randomly meet keepalive watchdog fired error.
What is changed and how it works?
The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy. Keepalive is introduced in #3649 in order to fix #3615, but the root cause of #3615 is the client reconnection strategy, the related tests can pass even without keepalive, so this pr disable the grpc client keepalive.
Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Fix bug that TiFlash query will meet keepalive timeout error randomly.

/merge

The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy.

Do we plan to upgrade our grpc version?

The root cause is the current used grpc version has a bug, and it is unavoidable to hit the keepalive timeout error under our current keepalive strategy.

Do we plan to upgrade our grpc version?

Yes, I think so.

/run-integration-test


Is there a way to monitor the estimated LR over time, if it has any meaning?

Thank you for your incredible work first of all! I am curious if there is any merit in using prodigy to estimate what may be decent LRs for a certain training. And if those can then be used to achieve similar performance with AdamW

Hi @ethansmith2000, I'm happy our optimizer was useful! You can of course just take the learning rate that Prodigy estimates. You can extract it after running Prodigy with this code: lr = optimizer.param_groups[0]['d'] and then passing lr as an argument to AdamW. While we haven't done anything like that before, we have observed that Prodigy often estimates a very similar learning rate to the one of AdamW.
Let me know if you have any other questions or feedback.


Mark sensitive environment variables for runners

Suggested solution for https://github.com/iterative/cml/pull/802, along with https://github.com/iterative/cml/pull/1164

⚠ should require communication and migration instructions before being released ⚠

Is this blocked by https://github.com/iterative/cml/pull/802?


FunctionClauseError in handle_info for exit

GenServer #PID<0.3098.0> terminating
** (stop) exited in: GenServer.stop(#PID<0.3099.0>, {:function_clause, [{Highlander, :handle_info, [{:EXIT, #PID<0.3099.0>, :shutdown}, %{pid: #PID<0.3099.0>, child_spec: %{id: Acme.Worker, start: {Acme.Worker, :start_link, [[]]}}}], [file: ~c"lib/highlander.ex", line: 90]}, {:gen_server, :try_handle_info, 3, [file: ~c"gen_server.erl", line: 1095]}, {:gen_server, :handle_msg, 6, [file: ~c"gen_server.erl", line: 1183]}, {:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 241]}]}, :infinity)
    ** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
    (elixir 1.15.7) lib/gen_server.ex:1031: GenServer.stop/3
    (highlander 0.2.1) lib/highlander.ex:101: Highlander.terminate/2
    (stdlib 5.2) gen_server.erl:1143: :gen_server.try_terminate/3
    (stdlib 5.2) gen_server.erl:1339: :gen_server.terminate/10
    (stdlib 5.2) proc_lib.erl:241: :proc_lib.init_p_do_apply/3
Last message: {:EXIT, #PID<0.3099.0>, :shutdown}
State: %{pid: #PID<0.3099.0>, child_spec: %{id: Acme.Worker, start: {Acme.Worker, :start_link, [[]]}}}

Hi @maennchen, thanks for opening this issue.
This stems mainly from the way Highlander is architected. It should be mostly harmless, but if you want to eliminate these errors (and generally have a more reliable solution), there is also HighlanderPG (announcement, package).


Putting some print statements in to debug slowness

The lib is spending a lot of cycles in the 'doing isbranch stuff' spot.


A way to pass data to the renderer

It would be nice if there was a way to pass data to the renderer via the renderer prop.
Perhaps, instead of passing an object as a renderer, one could have the additional option of passing a function that returns the renderer object. This way I can pass in additional data from the component where I use <Markdown> component in, with maybe a data prop. This is just a suggestion of how it could work.
I find this useful if I want to style the output of a renderer token based on some data inside my component.
E.g.
If I had a <Paragraph> component that renders markdown text as a paragraph and I want to be able style that render output based on if the paragraph is supposed to be grayed out(this is passed as a prop to my component).
const Paragraph = (props) => {
 // suggested/proposed renderer function that returns renderer object
 let rendererFn = (data) => {
  let isGreyedOut = data.grey;

   return {
     paragraph(text) {
      React.createElement('p', {className: `${isGreyedOut && 'text-grey'}`}, text)
     }
   }
 }

  return (
    {/* data from my component is passed to the <Marked> 'renderer' prop(which now receives a function) via the proposed 'data' prop */}
    <Marked renderer={rendererFn} data={{isGreyedOut: props.isGreyedOut}} value={props.text}/>
    )
}

Don't know if this makes any sense...

Why not just directly invoke the function
<Marked renderer={rendererFn({ grey: props.isGreyedOut })} value={props.text} />

or since the renderer is inside the component. why not just directly use the props?

Wow, brilliant! Never thought of that.  This has saved me from a great deal of over-engineering😅. This is why I love open source and collaboration. Thank you 👍


Heroku toolbelt CLI

I'm very very new to coding and can't even get the programs installed >< I was trying to install the heroku-cli but it just times out and goes on an infinite loop to try to get it installed. I just downloaded it and put heroku into the command prompt. How do I go about fixing this?
C:\WINDOWS\system32>heroku
heroku-cli: Installing CLI...
Error: connect_write timeout reached
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:266:in `select_with_timeout'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:130:in `rescue in block in connect'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:111:in `block in connect'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:102:in `each'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:102:in `connect'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/ssl_socket.rb:146:in `connect'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/socket.rb:28:in `initialize'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/ssl_socket.rb:8:in `initialize'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/connection.rb:404:in `new'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/connection.rb:404:in `socket'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/connection.rb:106:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/middlewares/mock.rb:47:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/middlewares/instrumentor.rb:25:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/middlewares/base.rb:15:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/middlewares/base.rb:15:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/middlewares/base.rb:15:in `request_call'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon/connection.rb:250:in `request'
C:/Program Files (x86)/Heroku/vendor/gems/excon-0.51.0/lib/excon.rb:238:in `get'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:255:in `manifest'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:268:in `url'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:158:in `block (2 levels) in setup'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:146:in `open'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:146:in `block in setup'
C:/Program Files (x86)/Heroku/ruby-2.1.7/lib/ruby/2.1.0/tmpdir.rb:88:in `mktmpdir'
C:/Program Files (x86)/Heroku/lib/heroku/jsplugin.rb:144:in `setup'
C:/Program Files (x86)/Heroku/lib/heroku/cli.rb:27:in `start'
C:/Program Files (x86)/Heroku/bin/heroku:29:in `<main>'

retrying...

@Rhyngoh the CLI pulls down extra software the first time that it runs and it appears that it had issues downloading said software.  It is a timeout, which may just be a temporary network issue, or it could possibly a firewall or other network configuration like a proxy server.   I would try again, to see it works now.

I realized I just had to turn off my firewall to let it install. Closing thread now.


ThreadPool OOM

we found SVGAParser will open a new thread everytime ,util OOM.I see you add finalize() method  but not commit yet. can you update the sdk version as soon as possible ? thankyou!

2.4.3 is now available.


Use after free when search for ~

Steps to reproduce
I can reproduce a heap-user-after-free bug all the times with vim-8.2.3499 (huge) when I open a c or cpp file and search type /~.
I'm not sure yet whether it's a recent regression.
Steps to reproduce:

build vim with asan
Do this:

$ cd vim/src
$ ./vim main.c 2> asan.log

Then type `/~' followed by return.  It gives:

E33: No previous substitute regular expression
E383: Invalid search string: ~

Then type / followed by return.

I also see the bug with valgrind:
==24130==
==24130== Invalid read of size 1
==24130==    at 0x4C38D92: strlen (vg_replace_strmem.c:469)
==24130==    by 0x34669F: vim_vsnprintf_typval (strings.c:2128)
==24130==    by 0x345D57: vim_vsnprintf (strings.c:1879)
==24130==    by 0x431665: semsg (message.c:803)
==24130==    by 0x308DE3: searchit (search.c:678)
==24130==    by 0x30AB21: do_search (search.c:1566)
==24130==    by 0x274CCE: normal_search (normal.c:4394)
==24130==    by 0x274B07: nv_search (normal.c:4345)
==24130==    by 0x26EDDF: normal_cmd (normal.c:1099)
==24130==    by 0x42A940: main_loop (main.c:1501)
==24130==    by 0x429C8B: vim_main2 (main.c:878)
==24130==    by 0x429430: main (main.c:425)
==24130==  Address 0xa795570 is 0 bytes inside a block of size 2 free'd
==24130==    at 0x4C3589F: free (vg_replace_malloc.c:755)
==24130==    by 0x142C73: vim_free (alloc.c:616)
==24130==    by 0x308395: restore_search_patterns (search.c:309)
==24130==    by 0x39AD0A: call_user_func_check (userfunc.c:2853)
==24130==    by 0x39BAFF: call_func (userfunc.c:3336)
==24130==    by 0x39B289: call_callback (userfunc.c:3120)
==24130==    by 0x3820BC: timer_callback (time.c:483)
==24130==    by 0x3822D2: check_due_timer (time.c:550)
==24130==    by 0x3880BF: ui_wait_for_chars_or_timer (ui.c:455)
==24130==    by 0x29E9F5: WaitForChar (os_unix.c:6038)
==24130==    by 0x387FAD: inchar_loop (ui.c:384)
==24130==    by 0x298543: mch_inchar (os_unix.c:388)
==24130==    by 0x387D97: ui_inchar (ui.c:232)
==24130==    by 0x20DEE2: inchar (getchar.c:3562)
==24130==    by 0x20DAC4: vgetorpeek (getchar.c:3341)
==24130==    by 0x20B1C5: vgetc (getchar.c:1689)
==24130==    by 0x20B815: safe_vgetc (getchar.c:1918)
==24130==    by 0x431F59: wait_return (message.c:1200)
==24130==    by 0x43565B: msg_end (message.c:3433)
==24130==    by 0x430260: msg_attr_keep (message.c:178)
==24130==    by 0x43010C: msg_attr (message.c:123)
==24130==    by 0x431535: emsg_core (message.c:761)
==24130==    by 0x43157C: emsg (message.c:777)
==24130==    by 0x2E7177: nfa_regatom (regexp_nfa.c:1530)
==24130==    by 0x2E9496: nfa_regpiece (regexp_nfa.c:2211)
==24130==    by 0x2E9DBD: nfa_regconcat (regexp_nfa.c:2455)
==24130==    by 0x2E9E49: nfa_regbranch (regexp_nfa.c:2488)
==24130==    by 0x2EA117: nfa_reg (regexp_nfa.c:2549)
==24130==    by 0x2EA396: re2post (regexp_nfa.c:2969)
==24130==    by 0x2F2F3B: nfa_regcomp (regexp_nfa.c:7488)
==24130==    by 0x2F335F: vim_regcomp (regexp.c:2663)
==24130==    by 0x30803C: search_regcomp (search.c:205)
==24130==    by 0x308DA5: searchit (search.c:674)
==24130==    by 0x30AB21: do_search (search.c:1566)
==24130==    by 0x274CCE: normal_search (normal.c:4394)
==24130==    by 0x274B07: nv_search (normal.c:4345)
==24130==    by 0x26EDDF: normal_cmd (normal.c:1099)
==24130==    by 0x42A940: main_loop (main.c:1501)
==24130==    by 0x429C8B: vim_main2 (main.c:878)
==24130==    by 0x429430: main (main.c:425)
==24130==  Block was alloc'd at
==24130==    at 0x4C32FB5: malloc (vg_replace_malloc.c:380)
==24130==    by 0x142AEB: lalloc (alloc.c:244)
==24130==    by 0x142993: alloc (alloc.c:151)
==24130==    by 0x342721: vim_strsave (strings.c:27)
==24130==    by 0x3082DB: save_search_patterns (search.c:293)
==24130==    by 0x39AC4E: call_user_func_check (userfunc.c:2839)
==24130==    by 0x39BAFF: call_func (userfunc.c:3336)
==24130==    by 0x39B289: call_callback (userfunc.c:3120)
==24130==    by 0x3820BC: timer_callback (time.c:483)
==24130==    by 0x3822D2: check_due_timer (time.c:550)
==24130==    by 0x3880BF: ui_wait_for_chars_or_timer (ui.c:455)
==24130==    by 0x29E9F5: WaitForChar (os_unix.c:6038)
==24130==    by 0x387FAD: inchar_loop (ui.c:384)
==24130==    by 0x298543: mch_inchar (os_unix.c:388)
==24130==    by 0x387D97: ui_inchar (ui.c:232)
==24130==    by 0x20DEE2: inchar (getchar.c:3562)
==24130==    by 0x20DAC4: vgetorpeek (getchar.c:3341)
==24130==    by 0x20B1C5: vgetc (getchar.c:1689)
==24130==    by 0x20B815: safe_vgetc (getchar.c:1918)
==24130==    by 0x1E6906: getcmdline_int (ex_getln.c:1772)
==24130==    by 0x1E6457: getcmdline (ex_getln.c:1562)
==24130==    by 0x274A76: nv_search (normal.c:4337)
==24130==    by 0x26EDDF: normal_cmd (normal.c:1099)
==24130==    by 0x42A940: main_loop (main.c:1501)
==24130==    by 0x429C8B: vim_main2 (main.c:878)
==24130==    by 0x429430: main (main.c:425)
==24130==

I have not been able to automate it yet.  But I can reproduce interactively 100% of the times.
TODO: I can only reproduce it with my ~/.vimrc at the moment.
So I will have to minimize the content of my ~/.vimrc and my plugins to see what triggers it.
I may also have to bissect in case it's a recent regression.
Expected behaviour
Vim should not crash.
Operating system
xubuntu-18.04.6
Version of Vim
vim-8.2.3499 (huge)
Logs and stack traces
No response

@brammool  wrote:

Is it possible to reproduce without interaction?

This reproduces the heap-use-after-free automatically:
$ cat > bug.vim <<EOF
call timer_start(10, {-> ''}, {'repeat': -1})
/~
call feedkeys("/\<CR>")
sleep 100m
call feedkeys("\<CR>", 'L')
EOF

$ valgrind --num-callers=50 ./vim --clean -S bug.vim 2> valgrind.log

And valgrind.log show stack of a heap-use-after-free bug.

Although the commands in my previous comment completely automate
reproduction of heap-use-after-free bug, I don't see yet how to reproduce
it in a vim test :-/

I can reproduce it manually now.  Running that script during a test doesn't show the problem though.  Also when run in a terminal window.  Not sure what else to try.

fixed by a2cff1dbc9c58758977eba3034603e6fe459031b


Feat 20230605

Changes in this release:

https://github.com/adobe/helix-sidekick-extension/pull/409
https://github.com/adobe/helix-sidekick-extension/pull/412
https://github.com/adobe/helix-sidekick-extension/pull/415
https://github.com/adobe/helix-sidekick-extension/pull/419

:tada: This PR is included in version 6.21.0 :tada:
The release is available on:

GitHub release
v6.21.0

Your semantic-release bot :package::rocket:


Update lyrics.lua

Too many changes to list.  Optimized source rename and plugged a ton of memory leaks, both old and new.

Hey, I looked through the changes: great finds there esp. with memory leaks, maybe that will make the script less buggy for those who have posted on the forum. Thanks again.


Create topic "Livewire"

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I am changing.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

While the trend has shifted from backend-focussed applications to frontend-focussed, there was always the gap of how to get data to the frontend effeciently and non-duplicated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

❤ You are welcome! Livewire seems to have some bigger bugs, but the overall concept (similar to what Inertia does) is quite promising indeed


Using Glide with ImageLoader causes memory leak

Hi,
I'm using Glide to load images with the MessagesListAdapter ImageLoader, and it seems to be causing a memory leak. Here is my setup:
In my fragment:
@Override
public void onCreate(@Nullable Bundle savedInstanceState) {
        adapter = new MessagesListAdapter<>(getUser().email, (imageView, url) -> {
            Glide.with(getContext())
                    .load(url)
                    .fitCenter()
                    .into(imageView);

            imageView.setOnClickListener(view -> goToFragment(FullImageFragment.newInstance(url, getTitleString())));
        });
}

@Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.fragment_chat, container, false);

        MessagesList messagesList = (MessagesList)view.findViewById(R.id.messages_list);
        messagesList.setAdapter(adapter);
}

goToFragment in the onClickListener above uses a FragmentTransaction to replace the current fragment with the messages list, with another fragment that shows the full image blown up (for zooming in, etc).
However, when going back to the chat fragment, onCreateView is called again, and the memory spikes because the messages list is loading the image again. Is there something I should be doing in onDestroyView? onCreate is not called again when going back to the messages list.
I know the cause is the messages list and not the full image fragment because showing the full image fragment from other fragments (non message list fragments) does not cause the memory spike.
Any ideas?
Thanks

I think I am seeing the same issue in my App

This seems to fix the leak:
val requestOptions = RequestOptions()
requestOptions.diskCacheStrategy(DiskCacheStrategy.ALL)
Glide.with(getContext())
    .setDefaultRequestOptions(requestOptions)
    .load(url)
    .into(imageView)

But I got a followup issue: I am getting lots of  The application may be doing too much work on its main thread. which seems to get caused by glide loading images again and again


Pass IAM Instance profile ARN

Signed-off-by: Salvatore Mazzarino<EMAIL_ADDRESS>This PR pass in as variable iam_instance_profile_arn to let the consumer be able to define the ARN of an instance profile managed externally of the lifecycle of the vault module.

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

this PR should help to move on also with this https://github.com/hashicorp/terraform-aws-vault/pull/170

@brikis98 thank you for the fast reaction here. Let me explain my changes.
The reason why I flag out all resources is that when a user passes in the ARN of the instance profile then also he created and managed a role with all the policies so no need to create policies there.

I've addressed all the requested changes but not tested locally. Going to run asap locally and check if it works.


Help learner when workflows don't run

This PR adds some troubleshooting steps for the learner in case there are problems with their workflow.

I had to add another issue to trigger the workflow after i fixed my code

I'm not sure I understand this one, can you elaborate @lmkeston?

I had to add another issue to trigger the workflow after i fixed my code

I'm not sure I understand this one, can you elaborate @lmkeston?

@hectorsector here are the steps I followed:

I added my workflow for the first steps in the course with a deliberate typo, then merged the PR.
the bot then opens Issue #3, "Create an issue comment with GitHub Script".  Opening this issue is supposed to trigger the workflow, but mine fails due to the typo.
I then followed the troubleshooting steps you added to correct the code, remove branch protection, and merge in the changes.
however the workflow still doesn't run because it is triggered by the opening of an issue.  so i had to create another issue, which in turn kicked off the workflow, and the bot then responded back in Issue #3, "Create an issue comment with GitHub Script".

Does that make sense?


docs: add strict:false example to upstream ?

The upstream docs do not include an example of zero-config parsing, with strict:false. Want one?
It was a big part of the initial design, we were considering shipping without strict! Although the current contributors are all strict-friendly. 👮
This could mentioned that error checking is left entirely to the author. 😅

Also, no worries if want to focus on the functional changes first and catch up with improvements to the documentation later.

@shadowspawn my preference would be to land an MVP, and then follow up immediately with smaller improvements.
There have been 217 points of feedback on the PR against Node so far, too many more and I think there's a danger my computer gets thrown off the back patio :stuck_out_tongue:

Didn't get any interest in this and/or subsequent comments from users. Closing.


Informix: active database change support

Why not switch the function of switching the database, and now only switch users.Now use the cool, but to switch the database, I have to switch a connection.
This is just a suggestion！
Best wishes！

Aren't database linked to users ?
Which database type do you use ? Each user have his synonyms and grants on databases, how would you change database without switching user ?

We use informix,when change database,it show a error messsage:Active database change is not supported
Active database change is not [supported;]
Is this database that does not support this feature? But DbVisualizer can switch the database without switching users.
I am a newer, not very clear that users and the database can link the function, perhaps this is the database architecture problem. Oracle database should be possible.

This is actually a configurable behavior.
Do you know how to change active Informix database using SQL query?

I just know how to  operate data using SQL query,like select,update ,delete ,drop...... (′▽`〃)

Try use SQL query:
DATABASE yourActiveDatabase;
HTH

DATABASE yourActiveDatabase;

@yujishe does it really work?

I use the oracle database, found that the user and the database binding, it seems informix database function, or the version is too low

@serge-rider Yes, this actually works in informix, but if we use it in "dbeaver" the helpers are not activated.

@INGCRENGIFO thanks.
I'll add active database change config in driver settings.
I believe that under helpers you mean auto-complete. They won't use current database if you change it by executing DATABASE query in SQL editor (because DBeaver don't know about that unless you will set "Refresh active schema after SQL execution" in SQL editor preferences).


[Darwin] Add BaseSubscriptionCallback option to call handler during priming report as they come

This would allow sending attributes to the client as soon as they arrive instead of waiting for the subscription establish callback. This can improve responsiveness for MTRDevice clients.

This was done as part of https://github.com/project-chip/connectedhomeip/pull/29358


Test optimize procedure

Currently only tested through the notebooks. Required to let #159 pass.

Closed by #169


Integrating affinity/anti-affinity aware policy into firmament

Kubernetes has already supported inter-pod affinity/anti-affinity within its native scheduler, however, such an important feature could not be found within firmament. Another limitation is the support of task preemption, until now TaskPreemptionCost is still empty.
So when the features of affinity/anti-affinity, as well as task preemption could be supported by firmament? And if possible, could technical report be delivered at first?

It's my understanding that folks may already be working on some of this.
/cc @quinton-hoole

@timothysc Yes, @deepak-vij can provide details.

Yes we do have a conceptual design for supporting affinity/anti-affinity using Firmament scheduler within Kubernetes. Although, it is quite premature to share these details at this time. We are planning to open source this whole work in the coming months and will start sharing details with the community in due course.
At this time, we are currently stabilizing the integration glue code “Poseidon” and are using very simple cost model that does not depend on real machine utilization, but only on the number of tasks placed on machines. Currently we are using this simple cost model for balancing tasks across all the machines. Our plan is to use granular machine usage metrics in support of more advanced cost model/s. As things progress, we will start working with the Scheduler SIG (David Oppenheimer) w.r.t. open sourcing our work for enabling Firmament Scheduler within Kubernetes environment. Thanks.

@yingfeng Task preemption is supported in the existing code base: if a task's unscheduled cost exceeds the unscheduled cost another (running) task would experience if preempted, Firmament will preempt the second task and schedule the first. The mechanics of this have not been tested extensively in the standalone cluster manager, but should work. In the Kubernetes integration, preemption is not yet supported (though I believe it's planned).
As for affinity/anti-affinity, there is some preliminary work in my PhD dissertation (see, e.g., pages 144-145), and I believe @ICGog is currently extending this.
For technical reports describing the system, see:

the OSDI 2016 paper;
chapter 6-8 of my PhD thesis (p.133-195).

Hi Malte, good to hear from you. I am sure you are aware that we are collaborating with Ionel on this effort. Thanks.
Deepak

@ms705 @deepak-vij
Thanks for your explaination, hope these features could be available to be integrated into K8S asap~


Plant test for this release to continue UAT/testnet chain

Delivers:

https://www.pivotaltracker.com/story/show/156846658
https://www.pivotaltracker.com/story/show/156724656

Depends on PR #1014 (included in this PR).
TODO:

[ ] Re-enable spend tx smoke test
[ ] Rebase on master

I haven't looked at the code in detail, but I'm a bit concerned that we're adding hardcoded versions in lots of places. How is this going to scale as we release new versions?

I haven't looked at the code in detail, but I'm a bit concerned that we're adding hardcoded versions in lots of places. How is this going to scale as we release new versions?

@eproxus  I can have a look at removing the versions from the config - though that would make the error in case of misconfiguration less readable. (I would also need to make the aeu_env unit test on the full config example in the test data more strict.)

@jur0 I removed verbose logging on node startup as you requested, and force-pushed.

I was also referring to hard coded versions in the tests, like -define(NEW_PROTOCOL_VERSION, 11). for example. What will this file look like once we're ten versions ahead? And how will it be maintained?

@eproxus I minimized usage of hard coded protocol version in test - in new commit I pushed.

@eproxus Addressed.


Something went wrong (Help wanted)

Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build/bundletool/0.13.2/9dab70a6f932d0afe88f857eb168c3ad8ba9f3fe/bundletool-0.13.2.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build/bundletool/0.13.2/9dab70a6f932d0afe88f857eb168c3ad8ba9f3fe/bundletool-0.13.2.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build.jetifier/jetifier-core/1.0.0-beta09/6393d821ad5c2917a0182717ae8b8eee72c667de/jetifier-core-1.0.0-beta09.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build.jetifier/jetifier-core/1.0.0-beta09/6393d821ad5c2917a0182717ae8b8eee72c667de/jetifier-core-1.0.0-beta09.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build.jetifier/jetifier-processor/1.0.0-beta09/c5b7c0ddbdfdeb69b842bcd9672f88bae14238c7/jetifier-processor-1.0.0-beta09.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
Cannot compute checksum for /Users/admin/.gradle/caches/modules-2/files-2.1/com.android.tools.build.jetifier/jetifier-processor/1.0.0-beta09/c5b7c0ddbdfdeb69b842bcd9672f88bae14238c7/jetifier-processor-1.0.0-beta09.pom because it doesn't exist. It may indicate a corrupt or tampered cache.
A verification file was generated but some problems were discovered:

some artifacts aren't signed or the signature couldn't be retrieved.
some signature verification failed. Checksums were generated for those artifacts but you MUST check if there's an actual problem. Look for entries with the following comment: PGP verification failed

@DrewCarlson Please look into this
Dependency verification failed for configuration ':classpath'
3 artifacts failed verification:

bundletool-0.13.2.pom (com.android.tools.build:bundletool:0.13.2) from repository Google
jetifier-core-1.0.0-beta09.pom (com.android.tools.build.jetifier:jetifier-core:1.0.0-beta09) from repository Google
jetifier-processor-1.0.0-beta09.pom (com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta09) from repository Google
This can indicate that a dependency has been compromised. Please carefully verify the checksums.

Open this report for more details: file:///Users/admin/Desktop/AndroidProjects/BreadWallet22Commit/BreadWalletLatest/build/reports/dependency-verification/at-1601281156076/dependency-verification-report.html

This is an issue with Gradle/AGP, the easiest way to fix it is by deleting your ~/.gradle folder and running it again.

@DrewCarlson Thanks!
It's working fine now.