The location '/__webpack_hmr' doesn't match any route configured in react-router.

Fresh React with Redux template setup is throwing "location '/__webpack_hmr' doesn't match any route configured in react-router" error when the server is started using dotnet run
Repro steps

npm install -g yo generator-aspnetcore-spa

yo aspnetcore-spa (and install version 0.9.0 of the React with Redux template)

Open folder in VS Code

In the terminal execute following
set ASPNETCORE_ENVIRONMENT=Development
dotnet run

navigate to  http://localhost:5000/. Observe following error is thrown.

info: Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Home/Index.cshtml.
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[2]
      Executed action WebApplicationBasic.Controllers.HomeController.Index (AdminPortal) in 14.4989ms
fail: Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware[0]
      An unhandled exception has occurred: Call to Node module failed with error: Error: The location '/__webpack_hmr' doesn't match any route configured in react-router.
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:314:23
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:51885:5
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20811:11
    at next (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20588:7)
    at loopAsync (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20592:3)
    at matchRoutes (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:52148:29)
    at Object.match (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20805:33)
    at match (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:51884:21)
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:303:83
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:300:12
System.Exception: Call to Node module failed with error: Error: The location '/__webpack_hmr' doesn't match any route configured in react-router.
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:314:23
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:51885:5
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20811:11
    at next (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20588:7)
    at loopAsync (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20592:3)
    at matchRoutes (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:52148:29)
    at Object.match (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:20805:33)
    at match (V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\vendor.js:51884:21)
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:303:83
    at V:\Code\MyTestProjects\AdminPortal4\ClientApp\dist\main-server.js:300:12
   at Microsoft.AspNetCore.NodeServices.HostingModels.HttpNodeInstance.<InvokeExportAsync>d__7`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.NodeServices.HostingModels.OutOfProcessNodeInstance.<InvokeExportAsync>d__14`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.NodeServices.NodeServicesImpl.<InvokeExportWithPossibleRetryAsync>d__10`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.SpaServices.Prerendering.PrerenderTagHelper.<ProcessAsync>d__33.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Razor.Runtime.TagHelpers.TagHelperRunner.<RunAsync>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at AspNetCore._Views_Home_Index_cshtml.<ExecuteAsync>d__31.MoveNext() in /Views/Home/Index.cshtml:line 2
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Razor.RazorView.<RenderPageAsync>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Razor.RazorView.<RenderAsync>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewExecutor.<ExecuteAsync>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.ViewResult.<ExecuteResultAsync>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeResultAsync>d__30.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextResultFilterAsync>d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResultExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeNextResourceFilter>d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware.<Invoke>d__6.MoveNext()
info: Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker[1]
      Executing action method WebApplicationBasic.Controllers.HomeController.Error (AdminPortal) with arguments ((null)) - ModelState is Valid
info: Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ViewResultExecutor[1]
      Executing ViewResult, running view at path /Views/Shared/Error.cshtml.

If I run the project on IISExpress using VS2017, webpack hmr works fine

Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:62481/__webpack_hmr
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:62481/favicon.ico
Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware:Information: Sending file. Request path: '/favicon.ico'. Physical path: 'V:\Code\MyTestProjects\AdminPortal4\wwwroot\favicon.ico'

Thanks
Anunay

You must be running in production mode, when you want to run in development mode.
I know you included the set ASPNETCORE_ENVIRONMENT=Development command, but that is apparently not enough to enable development mode in your case. Can you check that it says Hosting environment: Development when your app starts up? I'm guessing it actually says Production instead.
For more info about how to enable development mode, please see Running via the Command Line in this post: https://blogs.msdn.microsoft.com/webdev/2017/02/14/building-single-page-applications-on-asp-net-core-with-javascriptservices/


Cartesia interruption not working

Whenever there is an interruption in the call for Cartesia it is not stopping audio transmission. It finishes the entire response and then the next response one after another.

hey @akshaym1shra thanks for highlighting this. Cartesia was till now implemented at a very basic level.
Have completed the integration now. Please let me know in case you're facing any issues.


Allow "make test" to run with Bourne shell.

"make install; make test" did not work out of the box on Ubuntu 16.04. Removing the bashism from protoc-gen-go/testdata/Makefile allows "make test" to run with a PASS result.

I signed it!


Allow more control over Pool sizes

Problem
Existing code memory allocation story is not very uniform:

separate pools exist for different purposes
ChipMem defines access to 'heap' (which could be system heap or a locally allocated one)

Downside of these strategies:

Large  systems (e.g. Linux) do not need actual 'pools' of data and would rather use heap. We could always preallocate large amounts (e.g. saying a linux controller can connect to 100 devices at a time) and virtual memory will ensure we do not really use that much physical RAM, however this seems hackish
Pools always need to be over-provisioned for the worst case, making each pool enerally waste a bit of RAM and this adds up the more memory poools we have

Proposed Solution

Determine available pools and list them, to ensure we have a unified strategy for dealing with them. We are likely to need to figure out what to do with 'iterate over all allocated items' code logic. Is it required?
Allow existing pools a choice for
a) use heap (will use this for large devices: android, iOS, linux, darwin). Eventually allow a 'max size'
b) use a common pool of RAM/privateheap and have max size (rather than overallocating a bit for each pool, use RAM for data managment and allow memory sharing between different pools)
c) Have centralized 'pool size' configurations for all our pools, to see at a glance configuration settings in our build system

Additional recommendations:

BitMapObjectPool already exists as a templated type to implement pools. Should we just use that everywhere?
Bias towards application-owned object lifetimes if possible.
If that isn't possible, I'd highly recommend a model where the allocation algorithm when allocating out of a specific pool, degenerates to calling a 'AllocPoolObj' call that is provided by the application. This makes the code path regular and standard across constrained and unconstrained devices, with the latter actually returning a heap-allocated object as a result of that call.

After auditing our code, we have two memory management implementations in current CHIP SDK.

Heap memory allocation APIs
The interface is defined in support/CHIPMem.h, which provides standard C dynamic memory management like APIs, such as
MemoryAlloc/MemoryCalloc/MemoryRealloc/MemoryFree.
Its implementation is based on either the system C dynamic memory management or our private implementations in
PrivateHeap.h/PrivateHeap.cpp.

Memory pool class BitMapObjectPool
The interface is defined in support/Pool.hThis is actually not a typical pool implementation which provides similar APIs to
allows dynamic memory allocation comparable to malloc or C++'s operator new based on pre-defined fixed blocks with
different sizes. Such as you can not  request a memory block from the pool with arbitrary size.
It is a smarter C++ implementation of static array. You need to specify the list of object of the same type, and all of the memory
managed by the pool is allocated only once (during  construction of the pool object)

Don't forget System::ObjectPool

In summary, the original Pool implementation based on pre-configured fixed-size blocks in support/CHIPMem-Simple.cpp has been replaced by private heap implementation in support/PrivateHeadp.cpp, and BitMapObjectPool is just a C++ implementation of static array.

In summary, the original Pool implementation based on pre-configured fixed-size blocks in support/CHIPMem-Simple.cpp has been replaced by private heap implementation in support/PrivateHeadp.cpp, and BitMapObjectPool is a C++ implementation of static array and SystemObject is a C implementation of static array.


Draco setting produces invalid file

When I compress a .gltf model with the Draco option and try to load the resulting file with three.js, I always get this error:

This is the file I used in this particular instance (opens fine in utilities like 3D viewer on Windows, so I don't think it's corrupted to begin with)
https://www.dropbox.com/s/kldnl21ney8jdaa/ElvenArcher.gltf?dl=0
This is the command I used to encode it:
gltf-pipeline -i ElvenArcher.gltf -o ea-draco.gltf -d
And this is how I try to load the result:

Oddly enough, when I use Google's own Draco encoder (set up by following this codelab) and encode the .obj file that the model was originally formatted as directly to draco code, the result is loaded by Three.js just fine.
I've tried playing around with the encoding options, but I haven't been able to find any that produce a result that loads. I'm not 100% sure whether the fault is with the encoder or the three.js loader, but since the loader handles other Draco files fine, I figured I'd open an issue here first.

After a little more investigation and taking note that the gltf-pipeline exported files explicitly in  .gltf format and not .drc or anything like that, I decided to try using the three GLTF loader like this:

Lo and behold, it works now!
Being a newbie when it comes to .gltf and draco encoding, I don't even know what to make of this... it seems like there are two different Draco encoding standards:
Type 1:

Exported by Google's compiled encoder
Requires loader = new THREE.DRACOLoader()

Type 2:

Exported by gltf-pipeline
Requires loader = new THREE.GLTFLoader() followed by loader.setDRACOLoader(new THREE.DRACOLoader())

Am I getting this right?

I think that's right. The draco content be loaded on its own as a .drc but can also be embedded in the glTF. The encoders are the same, it's just a matter of how the data is packaged.

I'll go ahead and close the issue then, looks it was just a misunderstanding. Might be worth it to put a little disclaimer clarifying the difference between "pure" and "embedded" Draco content in the readme section that talks about the draco export option.


Guard socket closing just like socket opening

Hi y'all, this MR seems required in order to reliably stop metrics collection while logging the last metric just before stopping the process. Would a maintainer be able to see if this can go into a release? Thanks!

This one: https://github.com/discourse/prometheus_exporter/pull/84


Use spirv-val.exe from external/slang-binaries

Problem description
It appears that external/slang-binaries/spirv-tools/windows-x64/bin/spirv-val.exe is currently not in use.
In fact, none of spirv-XXX executables under external/slang-binaries/spirv-tools is used anywhere.
Currently slang.dll uses "spirv-val.exe" and "spirv-dis.exe" found from Path setting.
This is probably not an expected behavior, and we should prefer the prebuilt executables over the executables installed on the system.
Because of this problem, the developers of slang are required to install the latest version of Vulkan SDK all the time.
And more seriously, we cannot use features that are available on the ToT of spirv-tools if the features are not available with a latest official release binary yet.
Goal
Slang should prefer spirv-val.exe and spirv-dis.exe from external/slang-binaries directory over the executables installed in the system.
We had a similar problem for the asset files for examples.
The resolution for the problem was to search the assets in the current directory first and check the parent directory.
Similarly we should look for spirv-tools executables in the following places in the given order,

"spirv-tools" directory relative to where slang.dll exists.
"../spirv-tools" directory relative to where slang.dll exists.
use Path environment variable.

To make this work, cmake will need to copy the relevant spirv-tools executables from external/slang-binaries/spirv-tools to a new directory, build/spirv-tools.
More details
The logic on Slang.dll side is pretty simple and it can be found from here

check if an environment variable, "LANG_RUN_SPIRV_VALIDATION", is set or not.
check if "--skip-spirv-validation" is set.
when the step 1 is true and the step 2 is false, it runs "spirv-val XXX" command. It completely relies on Path setting to find where "spirv-val" is.
if the validation fails, prints an error message, "internal error 99999: Validation of generated SPIR-V failed."

A change should be made at the step 3 and it should search for the executable in a certain way that prefers external/slang-binaries.
Alternatively, we could update the document and require the users to change Path to include external/slang-binaries...
But that seems unnecessarily invasive to the user environment.

As Yong suggested, a better solution is to use the API functions via slang-glslang.dll.
slang-glslang.dll is compiled with external/spirv-tools.
As long as we update external/spirv-tools to whatever spirv version we want to use, slang-glslang.dll will have the spirv-tools we expect to use.


How to serialize/deserialize the List/Map which value is also List or Map

I want to serialize/deserialize the List<List>/ Map<String,List>/Map<String,Map<String,String>>. It seems that the MessageMapSchema/MessageCollectionSchema cannot deserialize. So does protostuff support this condition and how to use it ?

I had the same problem

Any code samples?  You're likely using it wrong.
Remember to always pass pojo classes to RuntimeSchema.getSchema.  Definitely not List nor Map

I want to write a utility class that supports the serialization of a single object or collection object, for example:
Pojo p1 = new Pojo();
Map<String, Object> map1 = new HashMap<>();
...
byte[] serialize1 = ProtostuffUtil.serialize(p1);
byte[] serialize2 =ProtostuffUtil.serialize(map1);
...
Pojo p2 = ProtostuffUtil.deserialize(serialize1, PoJo.class);
Map map2 = ProtostuffUtil.deserialize(serialize1, HashMap.class);
Does protostuff support it?

These will not work.
byte[] serialize2 =ProtostuffUtil.serialize(map1);
Map map2 = ProtostuffUtil.deserialize(serialize1, HashMap.class);

Always pass pojos.  Not maps/collections/string/number/enums etc.

what is the correct way to serialize/deserialize List/Map

Having the same issue here as well with ArrayBuffers. It is not so much as not deserializing as not serializing in the first place!

for example:List<List>
turn List into a Pojo, for example B.
then List<List>  finally  turn to  List


Support for melative, AniList, and Hummingbird.

Probably be awhile for any of this to get integrated, but having options for connecting to AniList, melative, and Hummingbird would be nice for those who use such services.
Hummingbird has already been requested (#63), but i figured i'd mention it again while i'm mentioning the others since the topic hasn't been touched in awhile.

I am finishing up work on Trakt over the next week or so.
Hummingbird would probably be next (although not for quite a while) as it looks to be the most popular of the ones you mentioned

Yeah, i figured it would be awhile before this got done and that you were probably already looking into it, figured I'd just make a ticket to open discussion.
Hummingbird definitely seems to be more popular atm, but AniList has been gaining a lot more traction lately. I've been seeing many more people talking about AniList lately than i do Hummingbird. Possibly might have something to do with it's connection to AniChart.
Though, if you're still thinking about redoing the service linking system with something based on XEM (#48), it might be prudent to wait and do it all with that (it should be easier to add new services with it). I was actually going to take a look at it in the next couple days and see how easy it would be to adapt to JMMs needs.

AniList has been requested before, #64 and so has HummingBird, #63. Will keep this issue open for Melative.


Policy to prevent Tag/Untag does not work

Created a container node policy with Tag Request and UnTag Request events.
Added Prevent current event from proceeding action.
Created & assigned policy profile so the policy is active.
Edit Tags in UI — added a tag, saved, removed, saved.

Expected: The tag is not added, nor removed.
Actual: https://gist.github.com/cben/fa09fbb6760531a30a725d9f66df2d4f — policy.log looks great, the Prevent action runs, but the tag was still added/removed!
@miq-bot add-labels control, bug

@lfu I see you did 2 fixes #14427 #14641 about Prevent not working — do you think similar fix would apply for [Un]Tag Request?
The current tag policy checking code is:
https://github.com/ManageIQ/manageiq/blob/8da73f2cf8e1a5/app/models/classification.rb#L286

@cben Tag event should not be prevented from policy as doing so may hit performance issue.

If so, Tag Request event has no purpose and should be dropped?
On Aug 23, 2017 22:32, "Lucy Fu"<EMAIL_ADDRESS>wrote:

@cben https://github.com/cben Tag event should not be prevented from
policy as doing so may hit performance issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/issues/15882#issuecomment-324439130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQtGAeaOIA3FXqJtEZm_9d31dPgQcv1ks5sbH4vgaJpZM4PAX0o
.

@gmcculloug @Fryguy Thoughts?

@miq-bot assign @lfu

¯\_(ツ)_/¯  @gtanzillo ?

@miq-bot remove_label stale
@miq-bot add_label pinned


Add storage secrets to es-index-cleaner cronjob

Resolves https://github.com/jaegertracing/jaeger-operator/issues/196
Related to https://github.com/jaegertracing/jaeger/pull/1318 which has been merged and released as jaegertracing/jaeger-es-index-cleaner:latest.  We're just adding some additional environment variables so its also fine to use with older versions of the jaeger-es-index-cleaner image.

This change is

@pavolloffay , @gregoryfranklin , what's the status of this PR?

Adding a yaml with a secret I have used.
apiVersion: v1
kind: Secret
metadata:
  name: database-secrets
type: Opaque
data:
  ES_USERNAME: username
  ES_PASSWORD: password

thanks @gregoryfranklin


Specify eventDataFilter for each event in eventRef in Event State

In event state, when we specify multiple events in eventRef, especially when exclusive set to false, how do we specify eventDataFilter for each event received?
Example:
    ...
    "exclusive": false,
    {
        "onEvents": [{
            "eventRefs": ["HighBodyTemperature", "HighBloodPressure"],
            "eventDataFilter": ... // specify for each event
    ...

Yeah this is very valid point. We are atm simplifying the event state for 0.9. Just need a little more time to finish it.


not compatible with json 2.0 (and thus ruby 2.4)

JSON 2.0.0 dropped support for ruby < 2.0.0, but is otherwise compatible. JSON 2.0.0 is required to be compatible with Ruby 2.4. Thus until restforce updates its dependency constraint, restforce is not compatible with ruby 2.4

@ccutrer Good spot! Have you tried with JSON 2.0.0? What's broken?

I haven't yet. I'm working on just trying to run our app with Ruby 2.4, and I have several other dependency problems to work through first. restforce is an optional feature in our app, so I just moved that code out for now. AFAICT, though, nothing should be broken - the only reason for the major version bump was dropping of ruby 1.8/1.9 support. Which you don't even need to worry about, as long as your dependency requirement still allows json < 2.0, then the consumers of your gem can pick the version of json that will work with the version of ruby they're using.

I'll have a play now and see if it works - I imagine it will...

I've put together a fix to this in https://github.com/ejholmes/restforce/pull/261 - looks like it's behaving well with the tests passing on all versions.


Correct usage?

Hi, so I'm having a little trouble getting everything set up for my tests and was wondering if you could help. I am using Vue 2.5.2 with a library vue-socket.io for my client side websocket connection. My code for a base test to see if everything work looks like this.
import { SocketIO, Server } from 'mock-socket';
import VueSocketio from 'vue-socket.io'
import Component from<EMAIL_ADDRESS>import { shallow } from 'vue-test-utils'
import Vue from 'vue'

// Tell Vue to use socket.io and listen on this url, applied globally
Vue.use(VueSocketio, 'http://localhost:8080')

describe('A basic test', () => {
  let wrapper;
  beforeEach(() => {
      wrapper = shallow(Component)
  })

  it('creates server and connects', (done) => {
    const mockServer = new Server('http://localhost:8080');
    mockServer.on('connect', server => {
     server.emit('message', someData);
    });
    window.io = SocketIO;

   setTimeout(() => {
     // The component's websocket connection is accessed through wrapper.vm.$socket
     expect(wrapper.vm.$socket.connected).toBeTruthy()
      mockServer.stop(done);
    }, 100);
  })
})

Based on your examples in the README.md it seems like this is the correct way to set it up, but my test is failing. For some reason the mockServer and the component are never connecting. I'm using Jest 21.2.0 for testing with vue-test-utils for rendering the component for testing. I know this is a pretty specific situation and mix of libraries but any help with getting the mockServer and component connected would be great. Thanks for your help!

I'm having the same issue. Vue 2.5.2 and vue-socket.io 2.1.1

I refactored my code so that I didn't need the sockets for the unit tests. But I did notice $sockets.io in the debugger, which could be the window.io that needs to be assigned to SocketIO for this library to work


Create script to patch migrations automatically

node node_modules/transmute-framework/patch-migrations
... patch complete ...
Please review you migrations/2_deploy_contracts.js BEFORE truffle migrate.
never run code you have not read!
(this is sad)

This is done


Implement cats.Parallel

This should be pretty straightforward, as parZip assumingely already forms a valid Applicative :)

done


Changes to erlcloud_sns module

This pull request represents the changes related to erlcloud_sns for https://github.com/gleber/erlcloud/pull/215

UE-central for reall
SNS: added api for ListTopics
SNS: use optimized flatreverse approach for paginated list

thanks


Chore/146622685/grunt to gulp

What does this PR do?

Convert Grunt task runner to Gulp; with Gulp, the syntax is much simpler to comprehend and it uses pipe streams which makes it inherently faster.

Description of Task to be completed?
*Gulp is used as a task runner for running specific tasks for an app. It also create frontend packages for the proper rendering of an app
How should this be manually tested?
*Type gulp on the terminal and run
Any background context you want to provide?
*I personally think that gulp style and pattern is more simpler and easy to understand compare to grunt.
What are the relevant pivotal tracker stories?
*Convert from Grunt to Gulp task runner
Screenshots (if appropriate)
*None
Questions:
*None

I closed this pull request because of  multiple commits


JS validation, style fixes, and php fixes

Changed php validation functions to only check for db validation, created JS files to handle other forms of validation. Did some with validation with modal and added db functionality into it. Added extra styles to pages.

Looks good. Verified working.


Can't follow search editor links on Windows

Testing #85965

Use windows
Open a search editor
Hold ctrl over a relative path or text result line, nothing happens
Press F12 with the cursor on a result, nothing happens

Works on Mac though

Sorry, this was an old result editor that wasn't valid for the workspace...


Add support for label descriptions and emoji

https://github.com/blog/2505-label-improvements-emoji-descriptions-and-more

Emoji -When words are just not enough, include emoji in your labels to express yourself and the needs of your project through tiny images. ✨
Descriptions - Add descriptions to your labels to provide even more context and help your contributors apply the right ones to their issues or pull requests.

Oh, I missed the warning 8 days ago 😞
Still relevant, would be great to see the probot settings app support emoji labels

Documenting here that emoji labels work with this app as long as the label name is passed in double quotes
  - name: ":hand: help wanted"
    color: 128A0C


Fix from #445 - new error

Fixed #445 seems to cause a new problem, see https://paste.pound-python.org/show/LYKIjZiJJRP2wypclZIC/

yea, i was a dumdum.  It's fixed.  Thanks for reporting back.
https://github.com/trueos/lumina/commit/412708df8721eac7a95cd9de7cbcb424e3683de4


Disable Rails/ApplicationRecord for migration files

Addresses https://github.com/standardrb/standard-rails/issues/17

This seems extremely correct.
Heads up that GitHub will autoclose your issue if you use one of these verbs like "fixes #17" https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword


BUILD FAILED (Raspbian 9.9 using ruby-build 20190423)

I am getting that error after successfully installing rbenv in my Raspberry Pi 3, but when trying to do:
rbenv install 2.6.3
This is the output I get:
Downloading ruby-2.6.3.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.3.tar.bz2
Installing ruby-2.6.3...
ruby-build: use readline from homebrew

BUILD FAILED (Raspbian 9.9 using ruby-build 20190423)

Inspect or clean up the working tree at /tmp/ruby-build.20190513084815.18923
Results logged to /tmp/ruby-build.20190513084815.18923.log

Last 10 log lines:
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/package.rb:44:in `<top (required)>'
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/installer.rb:11:in `<top (required)>'
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/core_ext/kernel_require.rb:54:in `require'
	from /tmp/ruby-build.20190513084815.18923/ruby-2.6.3/lib/rubygems/core_ext/kernel_require.rb:54:in `require'
	from ./tool/rbinstall.rb:703:in `<module:RbInstall>'
	from ./tool/rbinstall.rb:639:in `<main>'
uncommon.mk:364: recipe for target 'do-install-all' failed
make: *** [do-install-all] Error 1

I am attaching here the log file.
ruby-build.20190513084815.18923.log
Any help would be appreciated.
Thanks,

I ran the following command:
brew unlink openssl
[…] and everything worked

From brew info openssl:
openssl is keg-only, which means it was not symlinked into /usr/local,
because Apple has deprecated use of OpenSSL in favor of its own TLS and crypto libraries.

You should never have done brew link openssl. This was at your own risk, and building ruby failed as a result.


Used eventfd-backed awakener on linux.

On Linux, instead of a pipe, we can use an eventfd, which uses less resources (a single fd and does not require buffers).

Also see #969.

This is done in #969, thank you @eduardosm.


Sound documentation

Inconsistencies in the SOUNDS documentation removed

Pull Request Test Coverage Report for Build 3505

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.99%

Totals

Change from base Build 3480:
0.0%

Covered Lines:
2690

Relevant Lines:
6512

💛  - Coveralls


How to use auth.first_submit_field options

Hi, need help with command zap here. I want to this zap auth work on my pipeline. In my case I want to authenticate to login page that has hidden password field. So the flow are fill in username (with hidden password field) > continue button > fill in password > login button. This flow work on the same page without changing to other page.
My command
zap-baseline.py -I -j  -t "https://url.co.id" --hook=/zap/auth_hook.py -J zap-$CI_PROJECT_NAME-report.json -r zap-$CI_PROJECT_NAME-report.html -x zap-$CI_PROJECT_NAME-report.xml -z 'auth.loginurl="https://url.co.id/login" auth.username="username" auth.password="password" auth.exclude="https://url.co.id/logout" auth.first_submit_field="Continue" auth.username_field="email" auth.password_field="password" auth.submit_field="LOGIN"'
My Output
2022-12-15 09:10:09,495 Built xpath: //input[(translate(@id, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='email') and (@type='text' or @type='email' or @type='number' or not(@type))]
2022-12-15 09:10:09,524 Built xpath: //input[(translate(@name, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='email') and (@type='text' or @type='email' or @type='number' or not(@type))]
2022-12-15 09:10:09,549 Found element email by name
2022-12-15 09:10:09,715 Filled the email element
2022-12-15 09:10:09,715 Trying to find element password
2022-12-15 09:10:09,715 Built xpath: //input[(translate(@id, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='password') and (@type='text' or @type='password' or not(@type))]
2022-12-15 09:10:09,728 Built xpath: //input[(translate(@name, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='password') and (@type='text' or @type='password' or not(@type))]
2022-12-15 09:10:09,741 Found element password by name
2022-12-15 09:10:09,777 Did not find the password field - clicking Next button and trying again
2022-12-15 09:10:09,777 Trying to find element password
2022-12-15 09:10:09,777 Built xpath: //input[(translate(@id, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='password') and (@type='text' or @type='password' or not(@type))]
2022-12-15 09:10:09,791 Built xpath: //input[(translate(@name, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ','abcdefghijklmnopqrstuvwxyz')='password') and (@type='text' or @type='password' or not(@type))]
2022-12-15 09:10:09,803 Found element password by name
Traceback (most recent call last):
  File "/zap/zap_auth.py", line 201, in login
    self.fill_password()
  File "/zap/zap_auth.py", line 256, in fill_password
    return self.find_and_fill_element(self.config.auth_password,
  File "/zap/zap_auth.py", line 274, in find_and_fill_element
    element.clear()
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 95, in clear
    self._execute(Command.CLEAR_ELEMENT)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 633, in _execute
    return self._parent.execute(command, params)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
  (Session info: headless chrome=108.0.5359.98)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/zap/zap_auth.py", line 83, in authenticate
    self.login()
  File "/zap/zap_auth.py", line 208, in login
    self.fill_password()
  File "/zap/zap_auth.py", line 256, in fill_password
    return self.find_and_fill_element(self.config.auth_password,
  File "/zap/zap_auth.py", line 274, in find_and_fill_element
    element.clear()
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 95, in clear
    self._execute(Command.CLEAR_ELEMENT)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 633, in _execute
    return self._parent.execute(command, params)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
  (Session info: headless chrome=108.0.5359.98)

2022-12-15 09:10:09,830 error in authenticate: None
Traceback (most recent call last):
  File "/zap/zap_auth.py", line 201, in login
    self.fill_password()
  File "/zap/zap_auth.py", line 256, in fill_password
    return self.find_and_fill_element(self.config.auth_password,
  File "/zap/zap_auth.py", line 274, in find_and_fill_element
    element.clear()
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 95, in clear
    self._execute(Command.CLEAR_ELEMENT)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 633, in _execute
    return self._parent.execute(command, params)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
  (Session info: headless chrome=108.0.5359.98)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/zap/zap_auth.py", line 83, in authenticate
    self.login()
  File "/zap/zap_auth.py", line 208, in login
    self.fill_password()
  File "/zap/zap_auth.py", line 256, in fill_password
    return self.find_and_fill_element(self.config.auth_password,
  File "/zap/zap_auth.py", line 274, in find_and_fill_element
    element.clear()
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 95, in clear
    self._execute(Command.CLEAR_ELEMENT)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webelement.py", line 633, in _execute
    return self._parent.execute(command, params)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/usr/local/lib/python3.9/dist-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.ElementNotInteractableException: Message: element not interactable
  (Session info: headless chrome=108.0.5359.98)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/zap/auth_hook.py", line 29, in zap_started
    auth.authenticate(zap, target)
  File "/zap/zap_auth.py", line 103, in authenticate
    if self.auth_fail_on_error:
AttributeError: 'ZapAuth' object has no attribute 'auth_fail_on_error'
2022-12-15 09:10:09,896 error in zap_started: None```

I've successfully scan with other login page (not with hidden password field), until I found this blockers. Any suggestions to handle this?

Hi, I don't think this will work because Selenium can only fill elements that a user with a browser can fill.
A solution would be to make the field not hidden, or to execute some Javascript to fill the element. Example:
j.executeScript("document.getElementById('password').value='pass';");


[Feature]: Check for nodes cordoned by karpenter

Is there an existing issue already for this feature request/idea?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
At the moment, when a primary runs on EKS nodes managed by karpenter, you will have to manually failover if a node is replaced or removed. This interrupts the automatic provisioning/deprovisioning of nodes.
Kubernetes uses the "node.kubernetes.io/unschedulable" taint and the "spec.unschedulable" field on a node to mark it as cordoned. The operator checks nodes for this information.
If a primary database is running on a node which was cordoned the operator will promote a secondary on another node.
This allows to evict the cordoned node without blocking the process due to the PDB of the primary.
Karpenter does not rely on "node.kubernetes.io/unschedulable" taint and/or the "spec.unschedulable" field.
Next to other things, the project basically needs to know that karpenter was the one that initiated the tainting.
https://github.com/kubernetes-sigs/karpenter/issues/1152#issuecomment-2032555856
Describe the solution you'd like
Karpenter taints nodes with: "karpenter.sh/disruption:NoSchedule"
https://karpenter.sh/docs/concepts/disruption/#disruption-controller
It would be nice if the operator could also check for an additional/alternative taint like this.
Describe alternatives you've considered
You can set "enablePDB: false" - but this is officially not recommended for production environments.
Additional context
No response
Backport?
N/A
Are you willing to actively contribute to this feature?
No
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Ahhh, so that's what's going on! Would be great to implement this as a custom field.

I too found this after working out why my maximum age on karpenter issued notes wasn't cycling the nodes out and instead blocked by postgres instances. Thanks OP for working this out.


Add option to prevent auto-opening sidebar

Another attempt to address #4, legal this time. When using auto-fill, there is no need to open the sidebar panel (especially since we can't close it). This PR adds a toggle which controls whether or not the panel opens.
Not really useful if you're not auto-filling, but I don't see any harm in leaving the option in.

merged as 7066632c56a9da809b4ead2388dd46c12a4bbfa8


YARN-11464: TestFSQueueConverter#testAutoCreateV2FlagsInWeightMode has a missing dot before auto-queue-creation-v2.enabled for method call assertNoValueForQueues

…QueueType.FSParentQueue

Description of PR
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 17s

trunk passed

+1 :green_heart:
compile
1m  7s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  1s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  9s

trunk passed

+1 :green_heart:
shadedclient
34m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 55s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

+1 :green_heart:
mvnsite
0m 50s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 54s

the patch passed

+1 :green_heart:
shadedclient
34m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
93m 35s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

230m 57s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.reservation.TestFairSchedulerPlanFollower

hadoop.yarn.server.resourcemanager.reservation.TestReservationSystem

hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesReservation

hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart

hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 373acf1dde32 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / beb456f4e2cd65712ad90ee4c7a907ad3fc986a0

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/1/testReport/

Max. process+thread count
5226 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 57s

trunk passed

+1 :green_heart:
compile
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m  2s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  2s

trunk passed

+1 :green_heart:
shadedclient
34m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 45s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
0m 51s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 56s

the patch passed

+1 :green_heart:
shadedclient
34m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
114m 47s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

247m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 54550303cf69 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9d552f694038581665574ff8b8bc346955d45bfe

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/2/testReport/

Max. process+thread count
969 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 46s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m  5s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  1s

trunk passed

+1 :green_heart:
shadedclient
34m 41s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 44s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 52s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
shadedclient
34m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
103m 14s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

236m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4de559203fd3 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 74b9e3c55adcc53be8acabde8a9202abbd3048b0

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/3/testReport/

Max. process+thread count
927 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @brumi1024 , paramters for this method checkReservationSystem was yarnSite.xml, so was confused at that moment.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 12s

trunk passed

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 59s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m  5s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  9s

trunk passed

+1 :green_heart:
shadedclient
34m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 55s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

+1 :green_heart:
mvnsite
0m 51s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  3s

the patch passed

+1 :green_heart:
shadedclient
35m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 49s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

241m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cefa8c2a8a3b 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d4b04b6b33eb96fbc7fcdb1d7b89382e413b66d5

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/4/testReport/

Max. process+thread count
993 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m  4s

trunk passed

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 57s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m  4s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  7s

trunk passed

+1 :green_heart:
shadedclient
36m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
compile
0m 49s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 49s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 45s

the patch passed

+1 :green_heart:
mvnsite
0m 53s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  2s

the patch passed

+1 :green_heart:
shadedclient
35m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
103m 41s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

242m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2e64cc33528c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5d0ad9b1a4238f01a355a39841de00d036339f10

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/5/testReport/

Max. process+thread count
961 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 40s

trunk passed

+1 :green_heart:
compile
1m  3s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 58s

trunk passed

+1 :green_heart:
mvnsite
1m  3s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  3s

trunk passed

+1 :green_heart:
shadedclient
34m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
compile
0m 48s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 48s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 42s

the patch passed

+1 :green_heart:
mvnsite
0m 52s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

the patch passed

+1 :green_heart:
shadedclient
34m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
100m 33s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

233m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5792

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 672ffee4ce1f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8c2783be92fc272153c6a72cd03d8feb760e553e

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/6/testReport/

Max. process+thread count
1005 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5792/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @susheelgupta7, merged to trunk.


grpc-java 1.48.1 release

Have you run the one-off presubmit?


[Bug-App]: Storage can't release

Describe the bug

I want to ask why these folders  are empty ( i delete it) , but I can still see the space occupation? How can I make wandb not automatically store weights? Thanks!

Hi @sanbuphy Good day and thank you for reaching out to us! Happy to help you on this.
Sometimes, the system takes time to reflect the actual storage details in the UI. Could you please check again and see if it is now reflecting correctly?
Thanks,
Paulo

Hi @sanbuphy , since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Automated code cleanup

Description
This PR contains the result of automated code cleanup, using the tools added in #965.
Quality checklist

[x] Your code complies with our Coding Style.
[ ] You've updated unit and/or integration tests for your change, where applicable.
[ ] You've updated documentation for your change, where applicable.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
[ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
[ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

/azp run cleanup

/azp run Steeltoe.All

To reviewers: VerifyCodeStyle failing with timeout is because it runs in diff-mode (therefore batching multiple calls), while the diff is enormous. This wouldn't occur normally, so I think we can ignore it here.


Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration

When I install the module, I get duplicate entries. This causes Publish-AzureVMDSCConfiguration to fail when attempting to resolve the module.
Below is the output of the installation showing the dup. xStorage was not previously installed on this machine, so it was not preexisting.
PS C:\Program Files\WindowsPowerShell\Modules> Install-Module xStorage
Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its
InstallationPolicy value by running the Set-PSRepository cmdlet. Are you sure you want to install the modules from
'PSGallery'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): y
PS C:\Program Files\WindowsPowerShell\Modules> get-module -ListAvailable -FullyQualifiedName xStorage | fl
Name              : xStorage
Path              : C:\Program Files\WindowsPowerShell\Modules\xStorage\<IP_ADDRESS>\xStorage.psd1
Description       : This module contains all resources related to the PowerShell Storage module, or pertaining to disk
management.
ModuleType        : Manifest
Version           : <IP_ADDRESS>
NestedModules     : {}
ExportedFunctions :
ExportedCmdlets   :
ExportedVariables :
ExportedAliases   :
Name              : xStorage
Path              : C:\Program Files\WindowsPowerShell\Modules\xStorage\<IP_ADDRESS>\xStorage.psd1
Description       : This module contains all resources related to the PowerShell Storage module, or pertaining to disk
management.
ModuleType        : Manifest
Version           : <IP_ADDRESS>
NestedModules     : {}
ExportedFunctions :
ExportedCmdlets   :
ExportedVariables :
ExportedAliases   :

What is $env:psmodulepath  Do you have a path listed twice?

Hi Travis, no C:\Program Files\WindowsPowerShell\Modules shows a single directory for xStorage and a single <IP_ADDRESS> within that directory:
From: Travis Plunk<EMAIL_ADDRESS>Sent: Friday, April 22, 2016 1:59 PM
To: PowerShell/xStorage<EMAIL_ADDRESS>Cc: Tim Omta<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xStorage] Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration (#34)
What is $env:psmodulepath Do you have a path listed twice?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/PowerShell/xStorage/issues/34#issuecomment-213586564 https://github.com/notifications/beacon/AGdd8WABQHTWmx2pESizibfpzAU2QCF1ks5p6TaxgaJpZM4IN8d3.gif

What is your $env:psmodulepath when running in Powershell?
Can you run "$env:psmodulePath" and send the output?

Hi Travis,
Here is my path:
C:\Users\tomta\Documents\WindowsPowerShell\Modules;C:\Program Files\WindowsPowerShell\Modules;C:\WINDOWS\system32\Window
sPowerShell\v1.0\Modules;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\PowerShell\Modules;C:\Program Files\Mic
rosoft Message Analyzer\PowerShell;C:\Program Files\WindowsPowerShell\Modules;C:\Program Files (x86)\Microsoft SDKs\Az
ure\PowerShell\ResourceManager\AzureResourceManager;C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\ServiceManag
ement;C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\
I checked all the directories listed in it and only C:\Users\tomta\Documents\WindowsPowerShell\Modules contains xStorage. Note that for some reason C:\Users\tomta\Documents\WindowsPowerShell\Modules is listed twice though. I’ll fix that and see if that is the problem…
From: Travis Plunk<EMAIL_ADDRESS>Sent: Friday, April 22, 2016 2:25 PM
To: PowerShell/xStorage<EMAIL_ADDRESS>Cc: Tim Omta<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xStorage] Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration (#34)
What is your $env:psmodulepath when running in Powershell?
Can you run "$env:psmodulePath" and send the output?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/PowerShell/xStorage/issues/34#issuecomment-213593567 https://github.com/notifications/beacon/AGdd8ZsIlOScqk0fhVV-6HeQeGioeE9Pks5p6Ty8gaJpZM4IN8d3.gif

Travis, that duplicate entry in my module path was the problem. Some extraordinarily helpful installer must have added it sometime in the past and I didn’t see it.
Thanks for prompting me to review that path.
From: Travis Plunk<EMAIL_ADDRESS>Sent: Friday, April 22, 2016 2:25 PM
To: PowerShell/xStorage<EMAIL_ADDRESS>Cc: Tim Omta<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xStorage] Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration (#34)
What is your $env:psmodulepath when running in Powershell?
Can you run "$env:psmodulePath" and send the output?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/PowerShell/xStorage/issues/34#issuecomment-213593567 https://github.com/notifications/beacon/AGdd8ZsIlOScqk0fhVV-6HeQeGioeE9Pks5p6Ty8gaJpZM4IN8d3.gif

Here is your path reformated to one path per line and sorted, the problem is in bold.

C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\ResourceManager\AzureResourceManager;
C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\ServiceManagement;
C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage\
C:\Program Files (x86)\Microsoft SQL Server\120\Tools\PowerShell\Modules;
C:\Program Files\Microsoft Message Analyzer\PowerShell;
C:\Program Files\WindowsPowerShell\Modules;
C:\Program Files\WindowsPowerShell\Modules;
C:\Users\tomta\Documents\WindowsPowerShell\Modules;
C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules;

Please file an issue for this on [https://windowsserver.uservoice.com/forums/301869-powershell](PowerShell User Voice)
I suspect when you installed the azure SDK it duplicated the path.
To fix this open (this is windows 10 the names may vary slightly on other Oss)

Open Control panel
Open System and Security
Open System
Open Advanced System Setting
Open Environment variables
In system varibales find PSModule Path, click it
click edit
Remove any reference to C:\Program Files\WindowsPowerShell\Modules
click ok
close any powershell windows
if you are using any application other than windows explore to launch powershell, close those as well.

It should now be fixed

Forgot to add, please confirm this resolves the issue so I can close this question.

Confirmed: something added that path to my system environment PSModulePath. I remove it via Control Panel and everything is working as expected.
From: Travis Plunk<EMAIL_ADDRESS>Sent: Friday, April 22, 2016 2:45 PM
To: PowerShell/xStorage<EMAIL_ADDRESS>Cc: Tim Omta<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xStorage] Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration (#34)
Forgot to add, please confirm this resolves the issue so I can close this question.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/PowerShell/xStorage/issues/34#issuecomment-213598402 https://github.com/notifications/beacon/AGdd8QhaA_VnLKzRUih4g7uzNDTdFqEDks5p6UFkgaJpZM4IN8d3.gif

Thanks for confirming, If you please the powershell behavior here is incorrect, please file an issue  on PowerShell UserVoice

Here you go Travis, please vote it up: https://windowsserver.uservoice.com/forums/301869-powershell/suggestions/13545987-duplicate-psmodulepath-entries-cause-module-resolu
From: Travis Plunk<EMAIL_ADDRESS>Sent: Friday, April 22, 2016 3:07 PM
To: PowerShell/xStorage<EMAIL_ADDRESS>Cc: Tim Omta<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xStorage] Duplicate Identical Module Versions Break Import-DSCResource and Publish-AzureVMDscConfiguration (#34)
Thanks for confirming, If you please the powershell behavior here is incorrect, please file an issue on PowerShell UserVoice https://windowsserver.uservoice.com/forums/301869-powershell
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/PowerShell/xStorage/issues/34#issuecomment-213604763 https://github.com/notifications/beacon/AGdd8WfwZ_J3tiZbC7c-PJGCFdedmTFtks5p6UZ9gaJpZM4IN8d3.gif

Issue logged here on PS UserVoice, please vote it up if you have this issue: https://windowsserver.uservoice.com/forums/301869-powershell/suggestions/13545987-duplicate-psmodulepath-entries-cause-module-resolu


Adding date and time for every post

Describe the bug
There was an issue raised about adding time and date to each post but was not resolved. I would like to add the feature ASAP.

Hi @cherau , Thanks for raising this issue but we already got the PR for this issue.


SQLCE ntext support in query pipeline

With the latest bug fixes in the SQLCE typemapper, the EF UPDATE pipeline now supports ntext and image columns.
But due to the SQL CE limitations regarding ntext, it is sadly not possible to write a query like this based on the Northwind Categories table (where Description is "ntext NULL"):
SELECT [Category Name]
FROM [Categories]
WHERE Description = 'Seaweed and fish';

This causes the following error:
 Error Code: 80040E14
 Message   : The ntext and image data types cannot be used in WHERE, HAVING, GROUP BY, ON, or IN clauses, except when these data types are used with the LIKE or IS NULL predicates.
 Minor Err.: 25923
 Source    : SQL Server Compact ADO.NET Data Provider

However, rewriting the query like this works as expected:
SELECT [Category Name]
FROM [Categories]
WHERE CAST(Description AS nvarchar(4000)) = 'Seaweed and fish'

So my question is, would it be possible for me to intercept during SQL generation, and if so, where?
I would only want to rewrite for ntext columns, of course, as this rewrite prevents use of any indexes.

@ErikEJ I will leave a more detailed answer on how to override the SQL generation for this case to @anpete.
What is the default type mapping for a string property with no MaxLength specification in your provider? If you haven't done this yet, I would suggest you consider compensating for this limitation at model creation time rather than at query time. E.g. you could have the type mapping for string properties with no MaxLength specification default to nvarchar(4000) columns instead of an ntext columns.
Users could still explicitly ask for the column to be an ntext or text but then I think it would be acceptable if they get errors from SQL CE when they try to use those in ways that aren't supported by the engine.
FWIW, this is similar to what we did in Code First for EF6 (we used a SQL CE specific convention) and I don't remember anyone complaining :smile:

@divega I have done that already.
https://github.com/ErikEJ/EntityFramework.SqlServerCompact/blob/master/src/SqlCeTypeMapper.cs#L23
Will just let the enigine error if doing compares on ntext columns (text is not supported by SQLCE, only Unicode types)


MarkdownToHTML converts MD links into empty space

Setup info

Workflow name: MarkdownTransform
Workflow version: 21.12
Alfred version: 4.5.1 [1256]
macOS version: macOS 11.5.2 (20G95)
Architecture: Intel

Description of issue
Given this input:
[The Multiverse ](https://www.producthunt.com/posts/the-multiverse)
...the workflow replaces that text with blank space:

Here's an animation:

It appears that the problem may be that plaintext conversion was broken in the recent update that affected clipboard output?
This has been fixed in the latest version, thank you for the bug report.


Block Latency Metrics

Hey @nholland94, #4415 and #4419 closes this one right?

#4380 and #4419 close this


Fix for expired profile when token lifetime isn't used

Per Jerome creating for 4.2.x branch in addition to master.
Before submitting any pull request, please read the contribution guide: http://www.pac4j.org/docs/contribute.html

There is an issue with your PR. Please start from the 4.2.x branch.


Bug: Cannot Upload .JPG or JPEG Files Produced by DSLR Cam

PHP Version
8.3
CodeIgniter4 Version
4.5.5
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
macOS
Which server did you use?
cli-server (PHP built-in webserver)
Database
MySQL
What happened?
When attempting to upload .JPG files directly from the DSLR camera, isValid() fails to process the file correctly. This issue does not occur with other .JPG files generated from different sources, such as smartphones or image editing software.
File

Result

Code to produce error
if (($file = $this->request->getFile('file')) && $file->isValid()) {
    dd($file);
}

$type = $file->getMimeType();

dd($type);

isValid() fails and then displays "directory" as a mime type as seen in the screenshot above.
I tried uploading the same file on another website to check the mime type, here are the results

.
.
if files from other sources the result is fine.

Steps to Reproduce
Download sample file here : https://s3.amazonaws.com/files.prod.dpreview.com/sample_galleries/4922733912/0157761533.jpg?X-Amz-Expires=3600&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAUIXIAMA3N436PSEA/20240923/us-east-1/s3/aws4_request&X-Amz-Date=20240923T225105Z&X-Amz-SignedHeaders=host&X-Amz-Signature=29de523f1af6f939d553642e303b7af43187b25b7e9a0e43be1d41d08f55dce0
Then try to upload
if (($file = $this->request->getFile('file')) && $file->isValid()) {
    dd($file);
}

$type = $file->getMimeType();

dd($type);

Expected Output
Expected result as follow :

Anything else?
No response

Sorry, this is caused by php.ini config
upload_max_filesize=2M
post_max_size=2M

which is smaller than the file size. thanks


from celery.five import with_metaclass raises ImportError: No module named five

I've upgraded celery and django-celery to 3.1.10:
celery==3.1.10
django-celery==3.1.10

I'm using django-celery (even though it's not required anymore?) because I've registered TaskMeta in my admin:
from djcelery.models import TaskMeta

class TaskMetaAdmin(admin.ModelAdmin):
    readonly_fields = ('result',)

admin.site.register(TaskMeta, TaskMetaAdmin)

But I get the above import error. Here's the stack trace:
[<IP_ADDRESS>:2222] out: Traceback (most recent call last):
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/core/management/base.py", line 222, in run_from_argv
[<IP_ADDRESS>:2222] out:     self.execute(*args, **options.__dict__)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/core/management/base.py", line 250, in execute
[<IP_ADDRESS>:2222] out:     translation.activate('en-us')
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/translation/__init__.py", line 90, in activate
[<IP_ADDRESS>:2222] out:     return _trans.activate(language)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/translation/trans_real.py", line 183, in activate
[<IP_ADDRESS>:2222] out:     _active.value = translation(language)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/translation/trans_real.py", line 172, in translation
[<IP_ADDRESS>:2222] out:     default_translation = _fetch(settings.LANGUAGE_CODE)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/translation/trans_real.py", line 154, in _fetch
[<IP_ADDRESS>:2222] out:     app = import_module(appname)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/importlib.py", line 35, in import_module
[<IP_ADDRESS>:2222] out:     __import__(name)
[<IP_ADDRESS>:2222] out:   File "/my-project/my-project/api/__init__.py", line 5, in <module>
[<IP_ADDRESS>:2222] out:     from tastypie import resources, api as tapi
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/tastypie/resources.py", line 19, in <module>
[<IP_ADDRESS>:2222] out:     from tastypie.authentication import Authentication
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/tastypie/authentication.py", line 14, in <module>
[<IP_ADDRESS>:2222] out:     from tastypie.compat import User, username_field
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/tastypie/compat.py", line 14, in <module>
[<IP_ADDRESS>:2222] out:     User = get_user_model()
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/contrib/auth/__init__.py", line 127, in get_user_model
[<IP_ADDRESS>:2222] out:     user_model = get_model(app_label, model_name)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/db/models/loading.py", line 230, in get_model
[<IP_ADDRESS>:2222] out:     self._populate()
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/db/models/loading.py", line 75, in _populate
[<IP_ADDRESS>:2222] out:     self.load_app(app_name)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/db/models/loading.py", line 96, in load_app
[<IP_ADDRESS>:2222] out:     models = import_module('.models', app_name)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/django/utils/importlib.py", line 35, in import_module
[<IP_ADDRESS>:2222] out:     __import__(name)
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/djcelery/models.py", line 17, in <module>
[<IP_ADDRESS>:2222] out:     from .picklefield import PickledObjectField
[<IP_ADDRESS>:2222] out:   File "/my-project/env/lib/python2.7/site-packages/djcelery/picklefield.py", line 20, in <module>
[<IP_ADDRESS>:2222] out:     from celery.five import with_metaclass
[<IP_ADDRESS>:2222] out: ImportError: No module named five

@ianfp For future Google people, you should probably specify how the configuration was bad.


Incorrect HTML in List samples

On http://dev.office.com/fabric/components/list:
The first HTML sample is missing the containing
 element, while the second is missing

I think this is actually another bug in our docs site, where when a component has multiple variants our HTML sample view concatenates all of the source together:

This will be fixed in our upcoming documentation rewrite. I've confirmed that the rendered samples have both
 and
 respectively.


Alias protobuf toolchain_type

This ensures that existing consumers of rules_proto's toolchain type keep working with newer versions of protobuf (as forced by Bazel 8).

@comius @meteorcloudy Could we get a patch release with this change? I observed that all proto toolchain based repos I maintain no longer use the registered proto toolchains with Bazel 8 and traced it back to this.

Looks good to me, but wait for @comius to confirm

@fmeum Thanks for this fix! Do you have a rough ETA for a release containing it?


Incomplete Summary (M04-perform-basic-operations-numbers-c-sharp)

Describe the bug
In the summary we didn't mention about exercise number- 4 (Increment and decrement) because it plays an important role in programming loops .
To Reproduce
Steps to reproduce the behavior:

Go to 'M04-perform-basic-operations-numbers-c-sharp'

Click on 'https://github.com/microsoft/studentambassadors/blob/main/Bug-Bash/C%23 Beginner Training/1_LP_AZ_get-started-with-c-sharp/M04-perform-basic-operations-numbers-c-sharp/includes/8-summary.md'

See error -Incomplete Summary.

Expected behavior
Our goal was to perform basic operations on string and numeric data. As a coding challenge, we converted a value from one unit of measure (Fahrenheit) to another (Celsius) and displayed the result in a formatted message.
We used various operators to perform basic string and mathematical operations. We learned how some symbols are reused (overloaded) as different operators, depending on the context. We learned how the data types of the operands influence the meaning of the operators. Finally, we learned how to change the data type of a value using the cast operator. The final basic operation we learnt about is how to increment and decrement values using special operators that are combinations of symbols.
Congratulations on taking another step towards building more sophisticated applications.
Screenshots

Additional context
We can improve it as students or any individual can come come back and take a short look at summary for refresher of topic.

Student Ambassador

@potatooBot good specific feedback with global implications - Created a backlog item for reviewing summaries


Fixed create-project for stable 1.1.x version

composer create-project fabpot/silex-skeleton was loading dev-master which is configured for silex ~2.0

This one is wrong.

@fabpot why it is wrong?
I think wrong is mapping master branch to 1.1.x-dev when master is used for 2.0.x-dev


Fix/clean some HPC rules

Some edits are needed for hpc_training_rules.adoc.
Need to remove HPC hyperparameters table link. The HP rules are all contained within the doc.
Need to update the references to rules in training_rules.adoc, probably as section links rather than rule numbers, as suggested here by @matthew-frank: https://github.com/mlcommons/training_policies/pull/458#discussion_r679992647
There is also a reference to hpc rule 6.1 under Run Results which is now wrong. We can similarly use a section link here.

I'll fix this after https://github.com/mlcommons/training_policies/pull/458 is merged. I think it'll be easier to avoid merge conflicts.

Fixed in https://github.com/mlcommons/training_policies/pull/464


UI: Add TextFieldButton

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#139
#138  👈
#137
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite


Tooltip setContent not documented

Hi, https://leafletjs.com/reference-1.6.0.html does not mention setContent() as a method of Tooltip and I had to dig in the code to find it. It's important as if you want to create a tooltip with options, you need to then setContent() to set the text.

Duplicate of #6597


fix(check-formatting.sh): use relative directory

The bin/check-formatting.sh script changed its directory to bin as the first step, consequently expecting paths of files to check to be relative to bin, when typically they would be given relative to the working directory. When not finding a file, the script would just print a warning, but still exit with error code 0, which is probably the reason why this went unnoticed for quite a while.
This commit fixes the relative directory issue. Further, when a given path cannot be checked, we return a non-zero code now. Lastly, the script would count the number of files with formatting issues and return that number as error code. This has the issue that if the number of violating files is a multiple of 256, error code would falsly be returned.

@vaeng Does merging this mean that you don't want to go forward with the pre-commit approach? Existing flies still need reformatting and the CI setup that is supposed to check all files for each commit on main is still broken.

Sorry, we might have a misunderstanding here.
I thought you needed this fix to be in place to have the hooks working correctly.
(If you are on the exercism discord, you can also ping me directly to discuss things.)


Add "select all" and "unselect all" to dropdown selects

What type of PR is this?

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] New Query Runner (Data Source)
[ ] New Alert Destination
[ ] Other

Description

How is this tested?

[ ] Unit tests (pytest, jest)
[ ] E2E Tests (Cypress)
[ ] Manually
[ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

This PR is causing our CI to fail, which is in turn causing subsequent PRs to fail their testing.
I'm going to revert this one for now, until it's in a state to pass.
@gaecoli Are you ok to try and fix this PR so it works properly?

I've just reverted this to get our CI working again.  Hopefully it can be made to work properly and be ready for a 2nd attempt. :smile:

This PR is causing our CI to fail, which is in turn causing subsequent PRs to fail their testing.
I'm going to revert this one for now, until it's in a state to pass.
@gaecoli Are you ok to try and fix this PR so it works properly?

I will try it.


Start a poll about feature requests

Geza's suggestion is great.
I think I'll try UserVoice if there's a free tier.  https://uservoice.com/product#Collect

Aaron Charrier's suggestion: https://poll.ly/

Public URL: https://poll.ly/#/LavRoJ8W


Invalid __dirname resolution technique for node-module when import.meta.url contains query params

Bug report
#17931 introduced functionality to support __dirname and __filename shims for module output.
Unfortunately, there are false assumptions in the behavior - namely any import.meta.url that has a query param will break.
https://github.com/webpack/webpack/pull/17931/files#diff-ec15f6ea9baa75e9b3ca10449f3b9b7e04e56828330aa5a31d8a83aadd733ed0R225
https://github.com/webpack/webpack/blame/e97af9b5317bc0e7fdbc035b98a577edfe258b83/lib/NodeStuffPlugin.js#L230

What is the current behavior?
Current behavior just string appends '/..' to the import.meta.url value to try to get a directory.  This is inaccurate behavior for any import urls which contain query params.
If the current behavior is a bug, please provide the steps to reproduce.
Don't have an easy example I can generate offhand here, but any webpack node build with __dirname: 'node-module' is prone to this issue when running, e.g., const x = import('./relative_path.mjs?reload=123');

What is the expected behavior?

Other relevant information:
webpack version:  6.91.0
Node.js version: 20.11.1
Operating System: linux/windows x64
Additional tools:

I want to say it is expected, __dirname !== "import.meta.url" (with /..), so that is why you don't query, __dirname === import.meta.dirname (node.js 21 and we will improve it soon, if you browserslist contains node 21)
Try this:
index.mjs
const x = import('./test.mjs?reload=123');

test.mjs
console.log(import.meta.url);
console.log(import.meta.dirname);

/cc @vankop I think we need to start support import.meta.dirname and import.meta.filename, there are two improvements:

Use import.meta.dirname and import.meta.filename instead __webpack_fileURLToPath__(import.meta.url + "/..") if target/browserslist support it
Don't output undefined for import.meta.dirname and import.meta.filename, i.e. output them as is if they supported or replace on our shim with __webpack_fileURLToPath__(import.meta.url + "/..") (I think we need options here i.e. node.importMetaDirname and node.importMetaFilename)

For anyone who need a temporarily solution.
Change
import.meta.dirname

to
path.dirname(process.argv[1]) //*

* In my case there is a script path of my nodejs app. In your case there can be another file path

bump

bump

bump

bump


Make comments Group filter more adaptive to course visibility policy

If the course is visible to assigned group only, then the filter groups should be only the groups under the course. Otherwise, it should contain all groups under the faculty.

Done.


Education - Division Name Updates

Title of ticket:
Description
Education has a couple divisions whose names are changing. Updating these names should not lose the data in ReDash that we were collecting, it should simply be a change of name to existing divisions
Dependencies
n/a
DOD

[x] Rename Learning Division to - System Liaison and Supports Division
[x] Rename Education Programs Division to - Learning and Education Programs Division

@lmullane - taking down the estimate since we are planning to do this effort with #3272

Closing this request - program areas have updated correctly.
Tested on EDU-2023-39654
Learning Division has been changed to  System Liaison and Supports Division
Education Programs Division has been changed to Learning and Education Programs Division

Created Release label 4.8.1 for this ticket - FYI @lmullane , @m-prodan , @liseandtea

Deployment to PROD is over!
Steps taken

Backs up taken  - Camunda, PostgresDB
patroni-master-002-ffa-camunda_2023-01-16_16-10-15.sql.gz
patroni-master-002-foidb_2023-01-16_16-10-13.sql.gz
2,


Docs: Add variables and advanced usage docs

Adds docs for the following topic:

Variables
Custom scene objects
Retrieving data and time range using sceneGraph

Adds stubs for the following topics:

Advanced variables (basically VariableDependencyConfig)
Activation handlers

just a few nits :)