Video support for HTML5 and a whole set of custom elements to control it

Hey guys, great work you're doing here! I've been using Semantic since the beta for my own projects, and I probably have some PRs to make once they've been cleaned ;)
I'd like to offer my help for the video module you're building though. I built this a few years ago http://mooplay.challet.eu/, then it kind of fell by the wayside (as MooTools went the same way). disclosure : I would still chose it over jQuery if I had a choice :D
What I was aiming for with that project was exactly what I feel Semantic is aiming for now - abstracting behaviour to one single (and simple) definition. It might not be completely obvious when you read my documentation, but it would be really great if you could have a look at it, give the implementation a go and let me know if you think it matches with what you're working on.
If you'd like my help, I'd be happy to :

adapt the JS code and make it a semantic module.
provide .less definitions for the set of controls elements. edit: I don't even know if this is needed, since it would all be about using Semantic elements (buttons, progress, etc.) and add them a "video controling/monitoring behavior"
extend them to work with the unified API you're working on
do domething with the subtitles feature. I already made it work standalone over a flash video (when HTML5 video is not available). edit : maybe not part of Semantic, you tell me

I'm not completely up to date with the current state of the video module, so feel free to give me a few pointers if you'd like to accept my offer to work on the project!

Hi jlukic, would you allow me to fork the video branch and run some tests ? is the one labeled next ?

Hi, it might make sense to separate this into two separate modules. Which I was thinking about doing. embed being the current component, which is specifically for embedding external videos from Youtube/Vimeo, and video a component like you are describing which works with html5 video.
Do you think this makes sense? Also are you comfortable writing the module using the same module format used elsewhere? I can help you get started and provide documentation for getting started with the format.

Hi, I'm going to try this as an independant module, whathever the final name will be. I'll try to stick on what is seen in other modules. By any chance, is there a yeoman generator (or equivalent) for semantic module ?

I've added an online repo where I'll try to keep notes on SUI module format
https://github.com/Semantic-Org/Module-Examples
You can see the annotated source of current version here
http://semantic-org.github.io/Module-Examples/docs/module.html

Hi @jlukic thanks for links, I've made a basic integration from it for the play/pause button https://github.com/challet/Semantic-UI/commit/aa3b21a3fa07098333edca46e5395a241cdecdbb#diff-60e295af5f7fe24b87a004491016c9c8
As a prototype it looks promising, but I'm not completly confident about the SUI integration. If you could have a look, that would be greatly appreciated.

Can you create a pull request against the next branch where i can start evaluating this?
I've decided that the current video component will be changed to embed since this component was only specifically designed to work with embedded third party content. This also would allow me to include generic responsive embed containers, and possible future integration with Google Maps, Instagram and other common embeds.

Sure, i'm adding a few more things and let you know through a PR. Current status demo can be seen here http://html5video.challet.eu/examples/video-player.html I've used htmlvideo as a module name for now, it can be changed easily.

PR #2228

@challet what is the status of the html5 video pull request for semantic-ui. it looks to have stopped moving as of jul 21 2015

@challet @jlukic any news on this?

@brackmayhall @SrPatinhas sorry I haven't made new things on this for a while. I'd say it is usable ad for now, but might not be in line with SUI standards, and lacks of examples and documentations.
If you could advise me on what aspect should be priotized, I'll get back at it during the next weeks.


[Relay][ADT]Static Tensor Array

Add static tensor array for fixed rank tensor array. With this change, we can more easily do type inference and optimization for most tensor array use cases.
Thanks for @wweic working on the base infra of StaticTensorArrayOps class.
@wweic @zhiics @yongwww @icemelon9

There are lots of AST written by hand. Can you try using the relay parser?

Is the constraint only fixed "rank"? I have a use case for fixed "shape" tensor array (a tighter constraint)
https://discuss.tvm.ai/t/a-tensor-array-usage-question-stacking-a-list-of-fixed-sized-tensors/5565

There are lots of AST written by hand. Can you try using the relay parser?

This PR follows the patten of current Tensor Array. What do you mean by using relay parser?

https://discuss.tvm.ai/t/a-tensor-array-usage-question-stacking-a-list-of-fixed-sized-tensors/5565

https://discuss.tvm.ai/t/a-tensor-array-usage-question-stacking-a-list-of-fixed-sized-tensors/5565

@masahi fixed shape is a subset of fixed rank and supported in this PR. For stack operator, even if we have all tensors in the array with the same static shape, the first axis output shape will still be Any().

@kevinthesun Great! I've been waiting for this (thanks @wweic). I think the first output axis of stack being Any makes sense and it is no problem for me, assuming it is the length of the array.

@MarisaKirisame This PR follows the patten of current Tensor Array. What do you mean by using relay parser?

I think Marisa is talking about writing the new ADT and functions in the "Relay language" itself and use the parser to make it available to python, similar to the way List ADT and its helper functions are implemented in Prelude.

I think Marisa is talking about writing the new ADT and functions in the "Relay language" itself and use the parser to make it available to python, similar to the way List ADT and its helper functions are implemented in Prelude.

I see. My understanding for this is List ADT primitives are small and mature enough to be implemented in prelude. We can also move tensor array related primitives into prelude when they becomes more mature. In addition, we might want to move the generic tensor array as well, not just static tensor array. Does this make sense?

Does this make sense?

Yes. Since the generic tensor array is already implemented in this way, I also think it is better to let this in first and later port all tensor array stuff to Relay lang. There could be common code between generic/static that should be refactored in the process.

@MarisaKirisame The reason we can not use relay parser is that we want to dynamically generate the operators for specific shape while we convert the TF model to relay IR. Current relay text parser can not easily do that.

@wweic Comments addressed. PTAL.

@wweic Fixed.

Thanks @wweic @masahi @MarisaKirisame


SpeechRecognizer receives Canceled event with error "Due to service inactivity, the client buffer exceeded maximum size. Resetting the buffer"

Describe the bug
SpeechRecognizer receives a Canceled event with the ErrorCode = ServiceTimeout and ErrorDetails = "Due to service inactivity, the client buffer exceeded maximum size. Resetting the buffer. SessionId: f5ffa7a174444e25a0baf52a639d545b" and stops processing the audio file
To Reproduce
Steps to reproduce the behavior:

Upload an audio file, which contains a silence fragment longer than 10 seconds or a music fragment
Receive a Canceled event with the ServiceTimeout error code

Here is a code sample we are using:
using var audioConfig = AudioConfig.FromWavFileInput(filePath);
var speechRecognizer = new SpeechRecognizer(_speechConfig, audioConfig);

speechRecognizer.Recognized += (object? sender, SpeechRecognitionEventArgs speechEvent) =>
{
       _logger.LogDebug("RECOGNIZED {sessionID} text of {Duration} duration,  {Length} length,", speechEvent.SessionId, speechEvent.Result.Duration, speechEvent.Result.Text.Length);
}:
speechRecognizer.SessionStopped += (s, e) =>
{
       _logger.LogDebug("SESSION-END {sessionID}", e.SessionId);
};
speechRecognizer.Canceled += (s, e) =>
{
       _logger.LogDebug("SESSION-CANCELED {sessionID}: {Reason} - {errorCode}", e.SessionId, e.Reason, e.ErrorCode);
};

await speechRecognizer.StartContinuousRecognitionAsync();
...
await speechRecognizer.StopContinuousRecognitionAsync();

Expected behavior
An audio file should be fully processed and the recognition should stop only after processing the file fully
Version of the Cognitive Services Speech SDK
Version 1.33.0
Platform, Operating System, and Programming Language

OS: Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (x86_64-msft-linux-gcc (GCC) 9.3.0, GNU ld (GNU Binutils) <IP_ADDRESS>00220) #1 SMP Fri Apr 2 22:23:49 UTC 2021
Hardware: x86_64
Programming language: C#

Additional context
For additional information attaching a log file
logfile.txt

Thanks for reporting this issue.
I looked at the telemetry for that session and the service didn't segment the 2nd phrase like I'd have expected it to.
I tried a couple of different audio files I created to get a repro but wasn't successful.
Do you have an audio file you can share? It will help our service team investigate the problem.

Actually, looing at #2212 it occurs to me you may be hitting the same problem, but instead of having the audio segment, you're hitting the default maximum buffer size which is precariously close to the maximum phrase length.
Looking at the configuration for the request I do see the segmentation timeout is set at 5s, which is definitely a factor here.

Thank you for your quick response.
Here is a failing part of the file:
Audio.zip
After the first sentence, there is a silence fragment and then there are a few more sentences.

We receive the first transcribed sentence on the Recognized event with the following transcript:
Earbuds, come on, go, go, go, go.
Then we receive a Canceled event with the ServiceTimeout error
And then one more Recognized event is received with the following recognition result:
I think I got it. Good. Yeah. I'm so sorry about. Yeah. I should not be doing interviews right after getting home from an international trip. I'm just like a complete mess. So, yeah. How are you doing? Not bad. It's actually kind of slow this week. So it worked out. OK, OK, good. I am very glad. So, yeah, I mean, I kind of I messaged you like, in the e-mail, I already kind of explained that this is a short profile for decibel. And so generally what I do with these profiles, because they are so short, is I only ask maximum two or three questions just because I think it's more effective for everyone's time. And the main thing that I wanted to ask you about with the new Stygian Crown record was there was a comment that the band made about the theme of the record. And I thought that it was pretty interesting and I wanted to dig into it further. And it was about how the theme of the album is about the origin of monsters and how they're conceptualized.
The recognition of the file stops, so the rest of the file is not processed.

As for the segmentation timeout, we set the property SegmentationSilenceTimeoutMs value to 5000. It was stated in the documentation, that the higher value allows having longer pauses in a speech.

Thanks for the follow-up.
Turning up the segmentation timeout does allow for longer pauses in speech that will be recognized as a single phrase. There are a number of scenarios where it can be beneficial to allow for a longer than typical pause between words when recognizing a single phrase.
There are tradeoffs, though. The biggest being that the Speech Service will only return final recognized results after enough silence has happened, which can result in increased latency.
There are also other interconnected pieces that can increase friction.
One of which is the SDK's resiliency buffer that can hold just over a minute of audio, which is what's happening here. The service segmented the phrase at ~55 seconds, but that wound up just missing being quick enough for the buffer to not have filled.

@rhurey Referring to what you said, what would be a possible solution for us? Should we set silence timeout to a smaller value? If so, will it work for us if we want to allow longer pauses? Can this issue happen again if the smaller silence timeout value is set and the phrase is segmented at ~59 seconds?

SESSION STARTED: SessionEventArgs(session_id=0de3b2a37dbb444ab3b9bfcc25042e03)
CANCELED SpeechRecognitionCanceledEventArgs(session_id=0de3b2a37dbb444ab3b9bfcc25042e03, result=SpeechRecognitionResult(result_id=5f7c56eb546448c4a24c09136284ce1f, text="", reason=ResultReason.Canceled))

please look at the above error and please help the same code working fine with local machine but give error in ubuntu server

@anshika24khathuriya can you open a new issue? It helps keep problems separate and makes tracking progress easier.

@anshika24khathuriya can you open a new issue? It helps keep problems separate and makes tracking progress easier.

The issue is is gives wrong scores in every file it gives 0 0 0 0 scores

@@anshika24khathuriya Please file a separate issue so we can better assist you.
Closing this out to keep our issue list current.

@rhurey Sorry for the late reply. We checked the solution you suggested, and the decreasing of the silence timeout to 500ms helped us to escape the ServiceTimeout issue. Thanks a lot for your help!


fix: useEffect when SSR

When SSR, useLayoutEffect prints a warning. This PR fixes this by swapping the hook with a useEffect if we are on the server. This is a common way to solve this problem:

https://github.com/streamich/react-use/blob/6737092ad9260ca1fe481bf4c10ffa650ae35476/src/useIsomorphicLayoutEffect.ts
https://github.com/mui-org/material-ui/blob/e53a9543cf28b67be6216e5f0ffd99be553cb258/packages/material-ui-utils/src/useEnhancedEffect.js

+1 on this, makes a lot of noise in the log when developing with Next.js

@mysterybear can you test the PR and give feedback? I'll merge then 👍

Hi @gsimone thanks for quick reply, I've tested using JS and it seems to work fine here: https://codesandbox.io/s/github/mysterybear/tweaks-next-ssr-use-effect-test?file=/pages/index.js
I just took the example codesandbox code and pasted it into a Next.js project and pointed use-tweaks at the patch author's branch, hope that's okay

Any chance this gets ever merged ?

Hey @enzoferey (and @mysterybear), we pretty much moved all efforts to https://github.com/pmndrs/leva; if you want to help with use-tweaks, let me know and I can make you maintainer 👍


Add docker-compose support for Postgresql

docker-compose support for Postgresql, makes it possible to fully automate tests on more disparate platforms.
Dependent services Solr and the Geoportal Rails application are not bundled into docker-compose yet, though in the end that's where they should probably be. Even if only in parallel with the existing testing strategy.

Yeah, unbundling testing from solr_wrapper is too much to go after right now, but getting a Geoportal build into a container for this application would be handy. Going full monty with sidekiq too seems not to be necessary at this point.


Adding getResult to ORM.

Coverage remained the same at 100.0% when pulling 61ea312697bcc46faea142b81ef698a6cdd3b628 on kingjerod:AddGetResult into 5ca04712cdeae6c15dc636402ba7682a924921a0 on michaelmoussa:master.

Coverage remained the same at 100.0% when pulling 61ea312697bcc46faea142b81ef698a6cdd3b628 on kingjerod:AddGetResult into 5ca04712cdeae6c15dc636402ba7682a924921a0 on michaelmoussa:master.


Improved Docs

Breaking (Possible)- Switched npm worksapce to pnpm workspace

Made tailwind config use typescript and installed missing @astrojs/starlight-tailwind dependency
Rewrote and added some manual install instructions to Add installation instructions and manual setup guide for PartyKit
Monorepo lint using sherif

We picked npm to keep it simpler for folks who might want to contribute, it's not too bad. If we had to update, we'd probably pick bun once it's ready for windows.
sherif looks great, we should add that.
I recommend putting the docs changes in a different PR, and the sherif change in a different PR.
The lint failures are because of something weird happening with starlight, I'll have a look at that today.
Thanks so much @Itsnotaka!


Meet-The-Admins Section

TL/DR
This PR updates the admin section by adding new admin photos + their titles
Overview of Change
Members.jsx

Add new members + their titles
Add <h5> for newly added member titles

index.css

Commented out padding .75em from .member class (temporary based on opinion)
Add styling for admins name and titles (h4 & h5's)

With Padding:

Without Padding:

This PR is asking to merge into the upstream main instead of dev. Unless there's a way to change that after the PR has been opened, you'll need to close this PR and open a new one. At a quick glance and npm test && npm start, it looks great! I'll do a formal review of the actual code changes once I have more time and the PR is pointing toward the correct upstream target (dev).

yeah I had to change the default branch back to main because of #57 .  Another side-effect is that we will have to be aware of the base branch where our PRs will go.
It's also easy to change the base branch.  You can just edit the PR title and you will get the option

+1 on the "no padding".  it looks a lot better.
Also, I think that a "forced" new line (a <br> element) in-between everyone's first and last name looks better IMO.

I have updated the css & made a new entry for the admin's first and last name values. I have also added the name above the photo because I thought it looked a little better. Let me know what you think, if it doesn't work i'll be happy to switch it back.
Before

After

I'm good with the names on top.
@jduffey are you going to review or are you waiting for me?
Also, FYI, this section is not "responsive", that is, the section does not scale with the changing dimensions. It is not a requirement for the site or this issue yet, so no changes needed. We will have to revisit this at a later time to make decisions on the responsiveness..

@readysetagile & @mmcbride2929 I have two pending comments. Overall things look great, I'm happy with the new design.


Coin prices stopped updating on Feb 7, 2019

BTC, LTC, ADA, and ETH stopped updating their prices on or around Feb 7, 2019.  I've refreshed all my other accounts and logged into personal capital every day since then, but crypto holding seem to be stuck since then.

Same problem.  I uninstalled pfcrypto on all browsers, restarted, and reinstalled.
Seems to be working now.

Whitelist api.coinmarketcap.com in your adblocker. uBlock was blocking it for me, so I guess their hosts file updated recently.

I think the api link changed.  I had to update a few spreadsheets that use it.  It all stopped working about the same time.

Oh, and confirmed that reinstalling works.  Worked fine for the past 2 days.

coinmarketcap has changed their API according to their documentation: https://coinmarketcap.com/api/documentation/v1/
The api call we are using isn't even documented anymore, and doesn't work directly in the browser. It will probably break soon (v1/ticker/) For a free account you need an api key as well, which we'd have to track for each user.
Also, it used to behave where if you set limit=0 it would return all coins, but not anymore, only 100 max at a time. This means that lower ranked coins won't get tracked.
This was first made with that coinmarketcap API ~ 18 months ago, so it had a good run..
If someone has the skills to swap us over to a different api or transition to the new coinmarketcap api and build a ui to save the user's api token and update the documentation, that'd be great. I might not get around to this for some time and could use the help.
Until coinmarketcap turns off the old endpoint, the top 100 coins still update.
It also looks like the calls to personalcapital's api "lag" as in the update takes but the response contains the old data. That's an entirely separate issue. Refreshing the webpage a couple times seems to make it work eventually.

Thanks sclem, this has been a great tool.
I updated all my spreadsheets to V1 a while ago.  If it goes, I will be lost.
I appreciate all your hard work.


[FLINK-32250][configuration] Revert the field name of BUFFER_TIMEOUT

What is the purpose of the change
FLINK-32023 changed the ExecutionOptions.BUFFER_TIMEOUT to ExecutionOptions.BUFFER_TIMEOUT_INTERVAL, the filed name should be reverted.
Because the ExecutionOptions is a public evolving API, some flink users are using the ExecutionOptions.BUFFER_TIMEOUT in their code. If we update it, the code cannot upgrade to 1.18 directly.
Brief change log
Revert the field name of BUFFER_TIMEOUT
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not documented

I'm not very sure if we need to ensure the compatibility of field names, but FLINK-29372 seems to have made changes as well.

Hi @reswqa , thanks for your feedback.

I'm not very sure if we need to ensure the compatibility of field names.

I realized this issue was due to this compatibility issue causing the FLINK-32023 backports to 1.17[1] and 1.16[2]'s CI to fail. So the solution is that don't  change the field name in 1.16 and 1.17.
I prefer revert it in 1.18, because the field name isn't important in Flink code, however it's helpful for flink users upgrade 1.18.

FLINK-29372 seems to have made changes as well.

Do you mean FLINK-29372 [1] changed some field names? I saw that it only changed some option names, but didn't see any field names, such as :

KubernetesConfigOptions
ExecutionCheckpointingOptions
CoreOptions
CheckpointingOptions

Please correct me if I'm wrong, thanks~
[1] https://github.com/apache/flink/pull/22672
[2] https://github.com/apache/flink/pull/22673
[3] https://github.com/apache/flink/pull/20867/files

Ah... Sorry, I got dizzy for some reason and thought it had changed some field name. In fact, it didn't do it, you're right. 😄

Thanks a lot @reswqa 's review, merging~


Support spot instances

This tool is amazing, but I wonder if it's possible to add support for the spot instances?

I wonder the same.  This file suggests it might: acceptance/aws/launchconfiguration_test.go


Change to how res. multiplier works

Resource multiplier now works by multiplying ONLY the amount of res. you received and not the amount you remove from res. so you get the same # of hits with same items before res. item is removed. Thanks to SkullyDev for code.

I think we should add both but for now resource "multiplier" should be the way of your PR


fix deprecated dependencies

Hubot is old. There are some dependencies that are deprecated, no longer maintained. The following is the output from NPM with Node.js v18.3.0. The current Node.js LTS version is v18.16.0.
I'm guessing that in order to resolve these issues, we might have to get rid of some of the dev dependencies. For instance, I just noticed that coveralls depends on a version of request that is out of date and has a security issue.
➜  hubot git:(master) ✗ npm i
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142

added 866 packages, and audited 1103 packages in 5s

175 packages are looking for funding
  run `npm fund` for details

2 moderate severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.```

I renamed this "fix deprecated dependencies", which I think reflects the work. "Modernize the code base" can mean a lot more.
coveralls is a code coverage tool, with a service backing it. If it's not useful, then can drop it if it's not providing value AND has deprecations.

I don't yet have a scenario where I would get value from coveralls. I could see using it if we were strictly using TDD as our designing process. But I don't want to be dogmatic about TDD. I prefer balancing tradeoffs instead of apply a general rule across the board.
I'll create a PR to remove coveralls.

Dependencies have been updated to their latest versions. We'll work on replacing the log module in a future release.


Improve doc for web UI

I just add the link and an image on the readme.

I'd like to put a hold on this MR, and revisit it a little later on, the UI included with the Daemon is an early preview at best and hasn't been through a proper release cycle yet (it was added after alpha1), there have been a huge number of changes and tweaks since then. It would make more sense to add this once the UI is complete (and we've made the repo public).

i have written that's feature is in beta. Perhaps we can write more clearly it not  fully functional now ?
I send this MR, because i forgot the port of UI.
And, I think that for security reasons, it could be interesting to indicate that a web port opens when you launch the daemon

And, I think that for security reasons, it could be interesting to indicate that a web port opens when you launch the daemon

In think the posibility to start the web server will be optional in the future.

You're right, we should mention that by default a web server is loaded and should expand on the reasoning (for serving the configuration tool), although with that being said, I think we should exclude a screenshot of the webui for the time being.

I'm going to close this for now, I've rewritten a chunk of the README prior to the 0.2.0 release, which includes details about the WebUI, as well as instructions for turning it off. Going forward, I'm going to be using feature branches rather than pushing directly to main, which should prevent situations like this happening!


Heading anchors render on the wrong(?) line for multiline headings

IMO this should be rendering on the first line, not the second.

I'll snag this as I already made this change myself.


MINOR: cleanup of some redundant checkstyle

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Retest this please

Retest this please

Merged #6950 into trunk.

@bbejeck I assume the commit message was accidental in https://github.com/apache/kafka/commit/b4e20495fa442a4312f946f518541a04fc6efcc9 ?


[Feature][Ready for Review] Migration script: GoogleDriveOauthSettings -> ExternalAccounts

Purpose
Adds script to migrate GoogleDriveOAuthSettings objects to ExternalAccount objects.
Note
Must go in and be migrated before #4261
Migration Steps

Ensure that the user_settings field of GoogleDriveNodeSettings has been changed to foreign_user_settings

python -m scripts.googledrive.migrate_to_external_account

[Merge 4261]
Again, ensure that the user_settings field of GoogleDriveNodeSettings has been changed to foreign_user_settings

python -m scripts.googledrive.connect_external_accounts

[#OSF-2272]

Build failure expected due to pre-migration field name change.

As discussed with @mfraezz , a sample migration (connect drive on newest develop, then run 4396, then run 4261) is failing locally. Requesting verification on sample data before continuing with review.

Can you add a note to the PR description to remove foreign_user_settings post-migration?

This looks good to me @mfraezz! Done with CR2 :palm_tree:


[MINOR][PYTHON] Remove obsolete codes for parsing abstract schema strings

What changes were proposed in this pull request?
This PR proposes to remove private functions that look not used in the main codes, _split_schema_abstract, _parse_field_abstract, _parse_schema_abstract and _infer_schema_type.
How was this patch tested?
Existing tests.

Test build #79647 has started for PR 18647 at commit 83228cb.

Test build #79647 has finished for PR 18647 at commit 83228cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79647/
Test PASSed.

Merged build finished. Test PASSed.

cc @davies and @joshrosen, I was looking at the first place that introduced this - https://github.com/apache/spark/commit/880eabec37c69ce4e9594d7babfac291b0f93f50. Could you take a look and see if i missed something here when you have some time?
I was thinking we should explicitly expose this or remove them out rather than leaving them in the codes.

gentle ping @davies and @JoshRosen. I guess it is mainly just about a decision - whether we expose it in any way or remove it out if I am not mistaken.

cc @holdenk too ...

@ueshin

LGTM

Although I'd recommend doing a JIRA.

Definitely @holdenk. Thanks for taking a look

retest this please

Test build #81304 has started for PR 18647 at commit 83228cb.

Test build #81304 has finished for PR 18647 at commit 83228cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81304/
Test PASSed.

I double checked these _split_schema_abstract, _parse_field_abstract, _parse_schema_abstract and _infer_schema_type are not used in a public API.
Under ./python/pyspark:
1. _split_schema_abstract:
$ grep -r "_split_schema_abstract" .

shows
./sql/types.py:def _split_schema_abstract(s):
./sql/types.py:    >>> _split_schema_abstract("a b  c")
./sql/types.py:    >>> _split_schema_abstract("a(a b)")
./sql/types.py:    >>> _split_schema_abstract("a b[] c{a b}")
./sql/types.py:    >>> _split_schema_abstract(" ")
./sql/types.py:    parts = _split_schema_abstract(s)

Non doctests / tests:
./sql/types.py:    parts = _split_schema_abstract(s)

This is within 3. _parse_schema_abstract:
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1274
2. _parse_field_abstract:
$ grep -r "_parse_field_abstract" .

shows
./sql/types.py:def _parse_field_abstract(s):
./sql/types.py:    >>> _parse_field_abstract("a")
./sql/types.py:    >>> _parse_field_abstract("b(c d)")
./sql/types.py:    >>> _parse_field_abstract("a[]")
./sql/types.py:    >>> _parse_field_abstract("a{[]}")
./sql/types.py:    fields = [_parse_field_abstract(p) for p in parts]

Non doctests / tests:
fields = [_parse_field_abstract(p) for p in parts]

This is within 3. _parse_schema_abstract:
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1275
3. _parse_schema_abstract:
$ grep -r "_parse_schema_abstract" .

shows
./sql/tests.py:        from pyspark.sql.types import _parse_schema_abstract, _infer_schema_type
./sql/tests.py:        schema = _parse_schema_abstract(abstract)
./sql/types.py:        return StructField(name, _parse_schema_abstract(s[idx:]), True)
./sql/types.py:def _parse_schema_abstract(s):
./sql/types.py:    >>> _parse_schema_abstract("a b  c")
./sql/types.py:    >>> _parse_schema_abstract("a[b c] b{}")
./sql/types.py:    >>> _parse_schema_abstract("c{} d{a b}")
./sql/types.py:    >>> _parse_schema_abstract("a b(t)").fields[1]
./sql/types.py:        return _parse_schema_abstract(s[1:-1])
./sql/types.py:        return ArrayType(_parse_schema_abstract(s[1:-1]), True)
./sql/types.py:        return MapType(NullType(), _parse_schema_abstract(s[1:-1]))
./sql/types.py:    >>> schema = _parse_schema_abstract("a b c d")
./sql/types.py:    >>> schema = _parse_schema_abstract("a[] b{c d}")

Non doctests / tests:
./sql/types.py:        return StructField(name, _parse_schema_abstract(s[idx:]), True)
./sql/types.py:        return _parse_schema_abstract(s[1:-1])
./sql/types.py:        return ArrayType(_parse_schema_abstract(s[1:-1]), True)
./sql/types.py:        return MapType(NullType(), _parse_schema_abstract(s[1:-1]))

These four are within 2. _parse_field_abstract and within 3. _parse_schema_abstract:
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1243
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1266
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1269
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1272
4. _infer_schema_type:
$ grep -r "_infer_schema_type"

shows
./sql/tests.py:        from pyspark.sql.types import _parse_schema_abstract, _infer_schema_type
./sql/tests.py:        typedSchema = _infer_schema_type(rdd.first(), schema)
./sql/types.py:def _infer_schema_type(obj, dataType):
./sql/types.py:    >>> _infer_schema_type(row, schema)
./sql/types.py:    >>> _infer_schema_type(row, schema)
./sql/types.py:        eType = _infer_schema_type(obj[0], dataType.elementType)
./sql/types.py:        return MapType(_infer_schema_type(k, dataType.keyType),
./sql/types.py:                       _infer_schema_type(v, dataType.valueType))
./sql/types.py:        fields = [StructField(f.name, _infer_schema_type(o, f.dataType), True)

Non doctests / tests:
./sql/types.py:        eType = _infer_schema_type(obj[0], dataType.elementType)
./sql/types.py:        return MapType(_infer_schema_type(k, dataType.keyType),
./sql/types.py:                       _infer_schema_type(v, dataType.valueType))
./sql/types.py:        fields = [StructField(f.name, _infer_schema_type(o, f.dataType), True)

These four are within 4. _infer_schema_type:
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1299
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1304
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1305
https://github.com/apache/spark/blob/b56f79cc359d093d757af83171175cfd933162d1/python/pyspark/sql/types.py#L1311

Merged to master.

Thank you @felixcheung and @holdenk.


Fix win32 linker hell and more

winpr: fix win32 linking issues
Depending on the windows target version (WIN32_WINNT), the used SDK and the build configuration the linker will see multiple libraries exporting the same symbols.
To prevent ugly hacks (e.g. modifying cmake's default system libraries or fragile library linking order chains) we prefix these functions with "winpr" and create corresponding defines to keep the current api names.
freerdp: remove static inet_ntop
inet_ntop is already implemented in winpr
cmake: remove some void statements and fix winpr source group
cmake: replaced STATIC_CHANNELS with BUILTIN_CHANNELS
channels/audin/client/winmm: requires winpr

@nfedera wow. Great job. That saves a lot of troubles. I like the renaming from STATIC_CHANNELS to BUILTIN_CHANNELS very much - that makes it more clear what it in fact does.
+1

nice job!


The Eastern Europe character š failed validation of First Name, Last Name ...

In registration form and account data the character š is not allowed (comaprishon of š with ¡ failed). When you write name with that character (eg. Sašo) the input field validation failed with error:  Your name doesn't seem to be correct.

On home screen write Sašo in Your First Name
Error message appeared under input field with message:  Your name doesn't seem to be correct.

or

Go  to Account -> Edit profile
Write Sašo in First Name, Last Name or Middle Name
Error message appeared under input field with message:  Your name doesn't seem to be correct.

Character š should be allowed in name fields
I have added u modifier after first part of rexexp patteren in
\Framework\Security\Validate\Validate.class.php
const REGEX_INVALID_NAME_PATTERN = '(?:[\|<>"\=\]\[\}\{\\\\$€@%~^#\(\):;\?!¿¡\*])/u|(?:(?:https?|ftps?)://)|(?:[0-9])';
but I don't know what would be the other consequences of that patch.

Thanks very much for pointing this out. I will provide a patch and post it here. Any other characters are you facing the same issue?

Thank you for quick reply.
I 've tested with all Special Slovenian characters and special
characters from former Yugoslavia area. That are ČĆĐŠŽčćđšž and only š
failed the validation.
That bug was found within first review of pH7CMS software.
Detailed tests will be provided in next month, when I 'll start
implementation of pH7CMS in Slovenian language.
Yours sincerely
--
Sašo Štibelj
ARS LUNA http://www.arsluna.com
Helena Štibelj s.p.
Čepulje 16
4000 KRANJ
+386 41 951 959 tel:+38641951959
<EMAIL_ADDRESS><EMAIL_ADDRESS>www.arsluna.com http://www.arsluna.com
This e-mail and any attachments to it may contain confidential and/or
privileged information and is a property of Ars Luna, Helena Štibelj
s.p. and intended solely for the addressee. If you are not the intended
recipient (or have received this e-mail by mistake), please notify the
sender immediately and delete this e-mail. Any unauthorized
reproduction, disclosure or distribution of the material in this e-mail
is strictly forbidden. In accordance with the company's e-mail usage
policy, a reply to this e-mail will be treated as a business
correspondence and may be, in certain cases, the object of inspection,
carried out by the authorized persons.
Ars Luna, Helena Štibelj s.p. protects environment. Please consider the
environment before printing this email.
♚ PH⑦ de Soria™♛ je 21. 10. 2020 ob 14:28 napisal:

Thanks very much for pointing this out. I will provide a patch and
post it here. Any other characters are you facing the same issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/825#issuecomment-713533083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AROMXE6CNBM5M6DI4SFSS3LSL3HWRANCNFSM4SYXFEHQ.

I 've tested with all Special Slovenian characters and special characters from former Yugoslavia area. That are ČĆĐŠŽčćđšž and only š failed the validation.

I 've tested with all Special Slovenian characters and special characters from former Yugoslavia area. That are ČĆĐŠŽčćđšž and only š failed the validation.

Thank you for your update! I will add š in the whitelist

Patch: https://github.com/pH7Software/pH7-Social-Dating-CMS/commit/3ec6b8e2589729b90fac6a9087d02967d213d6f4


Add mixnet retry mechanism

This PR tries to solve https://github.com/logos-co/nomos-node/issues/322#issuecomment-1709375953. I introduced an ack mechanism to check whether we should retry to send the packet or not.

I just remove all of ACK related code, and now we only retry on Body::write returns an error.


force-nick-equals-account and login-via-pass not working correctly?

Howdy,
I've set "force-nick-equals-account: false" in my configuration, but having registered an account when I try to use /nick Test, I get the error:
"[11:54:43] NICK You must use your account name as your nickname"
Under "nick-reservation:" I've also tried setting "enabled: false" but this also has no effect.
I've completely killed and restarted the ircd after making these changes with no effect.  I've also tried deleting the ircd.db file, but this also doesn't help.
In a possibly related bug, if I join using a different nickname and then attempt to identify to nickserv, I get the error:
"Authentication failed: Your nickname must match your account name; try logging out and logging back in with SASL"
This is despite the fact that under "require-sasl:", I have "enabled: false".
Another possibility would be the /pass command, since I have "login-via-pass-command: true" set.  However, when I try that, I get:
"462:  | [0] Blah, [1] You may not reregister"
Which is odd, because I'm not registered.
Anyway, since I have user persistency enabled by default, the consequence of this is that for a user on an older client, when the user registers their nickname they can no longer access it.  Oragono appears to set an impossible condition in which the user must have the username to identify, but cannot take the username because it is taken by a persistent user.
(oragono-2.3.0)

Okay, I see from the code that if your account is persistent then it's equivalent to nick-reservation being set to 'true'.
That still raises the question of how you retrieve an account if you have a persistent account without SASL.  I shall continue my investigation.

Due to the age of the protocol, there's an unfortunate ambiguity in the terminology here: depending on context, "registered" can refer either to "connection registration" (the initial NICK and USER handshake that is required to connect to IRC, receive 001 RPL_WELCOME etc.) or to account registration. The 462 ERR_ALREADYREGISTRED [sic] numeric refers to the first sense of the term.
The correct workaround for this is in fact login-via-pass-command, but the PASS command must be sent as part of the initial NICK and USER handshake --- this is how legacy clients generally interpret a server password field. If the client sends, e.g., PASS mystara:hunter2 (where mystara is the account name and hunter2 is the account password) in the initial part of the handshake, this should be interpreted correctly and attach your client to the "always-on" or "persistent" presence for the account. What client is this, by the way?

It was the mibbit widget, which doesn't allow the insertion of a password.  A user was using something else, but they haven't told me what the client was.
Could there perhaps be an option to take over a persistent presence post-connection?  Something akin to a killing of the persistent presence followed by a nickname change to the (now removed) persistent presence?

I'll consider it --- I'm not sure how much additional implementation complexity is involved.
I think the current recommended workaround for individual users who can't supply a password during connection registration (either via SASL or PASS) would be to disable always-on (/msg nickserv set always-on false), then connect using a temporary nickname and then use /msg nickserv identify. The problem is that to do this, they have to be logged into their account already, so it'll only work on the first connection. I should think more about this.
In passing:

I'd recommend Kiwi as a mibbit replacement; the new version is just static files that talk to an Oragono websocket. We have example config files that we use on our testnet.
I'd also recommend force-nick-equals-account: true; among other things, it ensures that someone successfully identifying with /msg nickserv identify will automatically have their nick changed.

This came up again on #1336; the discussion there has some reasons why this is hard to do.


Support for jakarta servlet specification

just api package change

Up for a PR on this?

Up for a PR on this?

I am not farmilar with this project but I think is just a package name refactor, javax to jakarta, and the api should not change. FYI https://github.com/jakartaee/rest

jetty, spring 6 has supported jakarta, do you have any plan for this

@jcchavezs I am up to take it if you don't mind, have similar roadblock for Apache CXF and Jakarta support, sounds good?

Sounds good to me.
On Mon, 1 Aug 2022, 21:14 Andriy Redko, @.***> wrote:

@jcchavezs https://github.com/jcchavezs I am up to take it if you don't
mind, have similar roadblock for Apache CXF and Jakarta support, sounds
good?
—
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/issues/1337#issuecomment-1201609844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYAVY7NQJMXRFWJ5P3M3VXAO3HANCNFSM54D2KQBA
.

Picking it up this weekend, sorry about that, was on vacation


Problem visibility setting does not reflect state in problem view

Testing #199247

Set "problems.visibility": false,
Open a file with some error
See the problem view still reports the error despite explorer and outline view working as expected

I think this is good. You still get a view of the errors in the workspace without them being in your face, and you can totally hide this view if you don't like it.


Input Bar changes color

Describe the bug
The input bar changes from white to grey after first message in a chat
To Reproduce
Open a chat and send a message.
Expected behavior
It should stay white.

This is because i added a space before so that there is a character inside. Once the inputbar is empty it will turn grey and shrink

Seems unintended to me while using it. The background should be white all the time

Seems like there is no easy way to enforce a white background when the TextMorph is empty, so the white color will now be completely removed with #272 to make it look just like a normal TextMorph


dev-cmd/bottle: use gnu-tar universally, sort entries & use PAX

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

ustar is too restrictive on file path lengths - we need PAX.
The ordering of contents is non-deterministic, but gnu-tar provides a --sort option to solve this (libarchive does not but can be worked around)
GNU Tar's implementation of PAX also has some non-deterministic data. In particular, the headers contain the PID for versions < 1.33. Also clear atime and ctime to be safe (the latter being something that's messy to control). Set --pax-option to deal with this.

System libarchive bsdtar could potentially be retained, but it'll need more testing.

Review period skipped due to critical label.

ustar is too restrictive on file path lengths - we need PAX.

@Bo98 Can you elaborate on this? What's failing as-is without it? What about e.g. checking for path lengths and using pax or ustar accordingly?

(libarchive does not but can be worked around)

How?
--
Why prefer pax over the GNU tar default? If we're using pax anyway: why not use pax with libarchive rather than GNU tar everywhere?

If/when this is merged: can the various cellar all: bottles be rebottled so they have consistent local/reproducible checksums?

Actually: if https://github.com/Homebrew/brew/pull/11251 is blocking: can it be reverted instead and we hold off on this PR until tomorrow (which could be rebased on the reverted https://github.com/Homebrew/brew/pull/11251 if need be). Thanks!

Can you elaborate on this? What's failing as-is without it? What about e.g. checking for path lengths and using pax or ustar accordingly?

ansible/3.3.0/libexec/lib/python3.9/site-packages/ansible_collections/community/aws/tests/unit/plugins/modules/placebo_recordings/aws_direct_connect_link_aggregation_group/nonexistent_lag_does_not_exist/directconnect.DescribeLags_1.json

What about e.g. checking for path lengths and using pax or ustar accordingly?

Potentially, but I'm not sure I see much benefit of this - unless you want to avoid changing any bottle checksums already produced?

How?

Traverse the directory ourselves, sort it and feed it into tar one by one.

Why prefer pax over the GNU tar default?

pax is POSIX standard. GNU tar default is not.
GNU tar actually plans to change to posix/pax by default in the future: "This will change in future releases, since we plan to make ‘POSIX’ format the default."

why not use pax with libarchive rather than GNU tar everywhere?

This might work if we apply external sorting as mentioned above.
I'll need to investigate ctime a bit first since libarchive doesn't offer the option to strip it.

Biggest issue I've had with retaining compatibility between gnu-tar and bsdtar is ctime.
PAX's ctime is something I'm stripping from gnu-tar, as there is no way I know to change it. This is proving difficult with bsdtar.
The only way to strip ctime from bsdtar is to use the dynamic format mode (for some reason it is always omitted in that scenario even when it picks PAX). However, this means that in order to be consistent with gnu-tar, we need to implement the exact same decision logic to choose whether pax or ustar should be used, namely this: https://github.com/Homebrew/homebrew-core/pull/75880#issuecomment-826860997 and apply that to gnu-tar. And keep up-to-date with any logic changes that may occur in the future.
This is annoying, and when looking at upstream for guidance I came across this suggestion, which implements the ctime logic:

People who are really serious about generating bit-for-bit
identical archives should really build their own command-line
interface: You can still use libarchive to build the output,
but your custom CLI could sort the entries and strip everything
except a bare minimum of basic metadata.

Ubuntu 16.04 -> knowing that we will migrated to Ubuntu 18.04 one day.

Potentially, but I'm not sure I see much benefit of this - unless you want to avoid changing any bottle checksums already produced?

Yeh, I'm hoping to do this. If we do, though, let's rebuild the various cellar :any bottles. The alternative (that I favoured yesterday but I think care less about today) is to implement at least our own path length logic (longest path length - HOMEBREW_PREFIX length + HOMEBREW_DEFAULT_LINUX_PREFIX length: if too long, use pax, otherwise ustar).

Do we want to though?

Definitely not.

In the end, there's even subtle differences between libarchive and gnu-tar in ustar mode. I've not looked into those much - the file permission seems to have an extra digit in gnu-tar.

diffoscope didn't seem to show any differences and they were generated with identical checksums on my machine (testing using ack).

I think we're asking for the impossible to be using a hybrid system like we were and expect outputs to be identical.

I don't think so. When we find and can demonstrate differences: we can fix them when it's possible/worthwhile to do so.

using system BSD tar on newer macOS versions (unless we already have examples of where it differs)

I tested this again and ruled it out, it's not an option that can be done consistently.

I'm fine with either this (if we rebottle existing all: bottles using ustar),

Let's go with this. It's the simplest option at this point and only requires a small amount of short-term pain with rebottling.

Great work @Bo98!


Cannot ignore "archivePrefix" export field

Hello!
Firstly, thanks for this amazing piece of software!
The problem:
I cannot get Better Bibtex to ignore "archivePrefix" export field despite adding it (with different capitalization) to the "Fields to omit from export" field in the export settings.

Report ID:
IR9LXNSF-euc
Exporter used:
"Copy as Better Bibtex" cmd+shift+c
Expected behavior:
@article{brekelmans2020All,
  title = {All in the {{Exponential Family}}: {{Bregman Duality}} in {{Thermodynamic Variational Inference}}},
  author = {Brekelmans, Rob and Masrani, Vaden and Wood, Frank and Steeg, Greg Ver and Galstyan, Aram},
  year = {2020},
  journal = {ICML}
}

Actual behavior:
@article{brekelmans2020All,
  title = {All in the {{Exponential Family}}: {{Bregman Duality}} in {{Thermodynamic Variational Inference}}},
  author = {Brekelmans, Rob and Masrani, Vaden and Wood, Frank and Steeg, Greg Ver and Galstyan, Aram},
  year = {2020},
  archivePrefix = {arXiv},
  journal = {ICML}
}

Best wishes,
Adam

Dear @retorquere, you are absolutely amazing, never saw such a responsive author before, thank you so much!

You're welcome. Does it work for you? I've added IR9LXNSF-euc as a case in my test suite, so it should, but I always prefer to actually know it's fixed for you.

Yes, I confirm it works perfectly!

Cool, I'll merge it in a new release. You can just keep this or force-upgrade when it drops in about 10 minytes (the full test suite must pass again), you'll be upgraded automatically when Zotero checks for new plugin releases. The new version is just what you have with a new version number slapped on.

skip-fields should be case insensitive, but it does so by lower-casing the skip-fields input on the assumption that BBT adds all fields in lowercase, which it did, except for archivePrefix and primaryClass, meaning it was always impossible to match those. These are now added in lowercase, and I've added an extra check to make sure I cannot add fields that are not all-lowercase, so it should not occur again, because my tests will fail, and I can't release official or test builds when any test fails. Keeps me honest.


Feature Suggestion: Civilian Aid Side Ops

In keeping with the spirit, not necessarily the stuff in there since you can do things with Vanilla equipment, but it would be really cool to have some side missions that were on the humanitarian support side of things. The reward would be some CIV rep boosts. Failing could result in loss of rep.
Some thoughts would be:
1: Deliver relief supplies to Civilians in an occupied area. Like others, this would spawn in some CIVs gathered as the objective. They would be there to get some boxes that might have food or other supplies (in the narrative sense) and the players have to get it in there to them....the enemy may wish to stop this. You have your conflict of how to go about it. Mission wins when the crate gets to the objective (AA might make it hard to just drop things, etc....or make it a truck of things....but ensure slingload.)
2: IED clearing: Very minor rep reward mission that would spawn in an IED in a friendly controlled area. Players must go and defuse....the problem being that AI CIV traffic could very well set it off. Low reward/penalty.
3: Mine-clearning: Spawns a point in BLUFOR controlled areas (near by, appropriate area far enough away and off of things. Basically like a up-scaled version of the IED, but off in an area that shouldn't have much 'traffic'.
4: Flyer dispersal: Something that gives a low reward and lets people use the LoW stuff in fun way...just get your UAV into a controlled area to toss out some fliers....mission fail if the UAV is lost before the pamphlets are dispersed.
I'm going to take a look into the framework and see about possibly coding one or two of these in and tossing them your way if interested.
LOVE the CIV stuff in the new version :D

Hey, I've done a reworking of the Convoy side mission to have it reward CIV rep instead of drop alertness. I've found in the many times I've played through Lib with a group that people rarely ever do the Convoy mission, so the idea came to me to change it to be useful in providing CIV rep.
I'll do a PR with the files if you guys want to look at it or whatever.

Hey this is a super idea.
Since the update to civ/repo points. I've never intentionally hurt them but they randomly run around in battle zones and they get killed. I accidentally one with a truck - he ran directly at me while driving at high speed. I tried to avoid him but he died, i wasn't able to revive him.
Unless i've just been super unlucky, i feel like i'll never reduce my rep (it's -25 atm).
Side missions of relief or mine clearing are excellent ideas.
I was thinking that Supply or Fuel (not ammo i guess) could be sent (logistics menu or by myself) to a village to gain rep.
Great work!

More possibilities/sidemissions are already planned for the upcoming patches to extend the ways to influent the civil reputation. Consider the current functionality of the civil reputation in 0.96 as a "general working framework" which will now be built on.


Consider max width for site

Just a thought: I have a super widescreen, and the site currently expands to fill the entire viewport. Not necessarily a problem, but it might be more readable if we imposed a max width with the content center aligned and increased margins/padding on the sides.
Here's a screenshot of the homepage at full width on my screen:

And another of the current job posting:

This is done with #106 as well


Exclusions for ThrowsCount

Expected Behavior of the rule
ThrowsCount should be more intelligent and allow intellectual exclusions (e.g. by thrown exception class).
Context
Too many exit points like returns or throws is indeed code smell, but there are exceptions. Currently, ThrowsCount is pretty dumb. It only counts throws expressions without any context. One example is "guarding" throws used to fail fast the program.
Imagine I have a class Effect:
data class Effect(
    val id: String,
    val name: String,
    val size: Long
)

I store it in the NoSQL key-value storage like DynamoDB. I wrote a function to convert DynamoDB's object into Effect:
fun Map<String, AttributeValue>.toEffect(): Effect = Effect(
    id = this["id"]?.s() ?: throw MissingPropertyException("id"),
    name = this["name"]?.s() ?: throw MissingPropertyException("name"),
    size = this["size"]?.n()?.toLong() ?: throw MissingPropertyException("size")
)

Currently detekt reports an issue here (default number of throws is 2). I should either increase the default, or use @Supress. But both solution are not perfect: increasing the limit will skip the warnings for really complex codes and @Supress feels like I am cheating to make detekt happy.
Ideally, there should be a list of exclusions for ThrowsCount, so some exceptions used across the code base to guard and fail fast are not counted.

Probably all the throws and returns in a syntax like ?: throw / ?: return could be configured to be excluded, as it is a pretty common pattern of defensive programming style.

I found excludeGuardClauses in returns rule, it is a perfect solution. Need something for throws.

Can we close this issue? The PR is merged.

Oh, sure. I thought, it would be closed automatically…


Change the RPCServicePort constant to the global configuration

related issue : no.4 in https://github.com/ucbrise/clipper/issues/656

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1839/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1840/
Test PASSed.


Remove 'State of D' survey banner

To be merged on Wednesday, 14.3

As it turns out, we already have a new item for the highlighted news area - the Amazon Smile promotion.
I already added this to this PR to avoid merge conflicts:

I'm not really sure about this. The turquoise really sticks out from the rest of the page.
Can we put this on the donate page or redesign it to be less obtrusive?
What do you think @CyberShadow?

redesign it to be less obtrusive?

How about something like the existing banner?

or:

I think the banner is OK, considering it's temporary.

@JackStouffer the plan is to swap this tonight, so if you have a better idea, please let me know.

If it's temporary I'm ok with it.


Endpoint for Organisations and ContentItems per organisation

Covers this story that exercises the first components of our application. Organisations, Content Items, Controllers and all the testing stack.
Includes:
1. Exposes an endpoint at /organisations/index and return a JSON with the organisations and the number of items of each organisation
[{
  organisation_id:<PHONE_NUMBER>298374,
  number_of_pages: 12.323
},{
  organisation_id:<PHONE_NUMBER>298374,
  number_of_pages: 123
}]

2. Add a rake task to import all the Content Items for an Organisation provided the Organisation slug
$ rails import:organisation[hm-revenue-customs]

Notes

We temporarily rely on HTTParty to query SearchAPI; this is a temporary solution as we will use GDS  Adapters as a way to communicate with other applications. The task to upgrade to use GDS adapters is tracked in a Trello Card
It is not ideal the way we are mocking the HTTP requests, as we are not webmok-ing the get request only the library request. This is something that will go away in a few weeks, so no need to work any further.
We are using a very simple mechanism to serialise to JSON the organisations . This is because most of this code will go away once we expose an API to other apps. We will to rely on Api Serializers or using libraries like Grape. No need to complicate things further right now.
As a result of the development of this PR, I have created a Trello card to automate Lint when running all tests in each commit so we prevent this situation from happening again. This way we don't need to write a final commit with all the fixes.

Aditional notes
We are not doing the Heroku work as part of this story because there is some pending work related to use GDS Heroku account and I don't want this task to block this card in our Trello board.
I have created a Trello card to track the work to deploy to Heroku.

In commit aa0254427c508ef0bbd41cf85829754442056cbc can you change the commit message to filters all organisations by ContentItems.
filters out means to remove the content items.

@pmanrubia As a whole, the code looks good. I'm missing the story though.
In commit 5979c3a, an empty run method is created to test the new rake task, but this run method is ignored for three commits until aa0254427c508ef0bbd41cf85829754442056cbc.
I thought the plan was to only add something right before it's needed?

In commit aa02544 can you change the commit message to filters all organisations by ContentItems. > filters out means to remove the content items.

Done in #7

Thank you for your review, I have addressed your comments in #7
Regarding the blocks of commits... I have move 5979c3a down 3 commits to be close to aa02544. I hope this is more clear now.
Closing this PR, as this has been superseeded by #7


Release version 1.0.3

We have a number of important fixes on the 1.0.3 milestone; we should cherry pick them to the release/1.0 branch and tag a new release.

Cherry pick PR: https://github.com/apple/swift-collections/pull/168

Testing progress: (on PR #168)
[X] macOS 13 beta, Apple Silicon, Xcode 14 beta 6 (Swift 5.7)
[ ] macOS, Apple Silicon, Xcode 13.4.1 (Swift 5.6.1)
[ ] macOS, Apple Silicon, Xcode 13.2.1 (Swift 5.5.2)
[ ] macOS, Apple Silicon, Xcode 12.5.1 (Swift 5.4.2)
[ ] macOS, Apple Silicon, Xcode 12.4 (Swift 5.3.2)
[ ] macOS 13 beta, Intel, Xcode 14 beta 6 (Swift 5.7)
[ ] macOS, Intel, Xcode 13.4.1 (Swift 5.6.1)
[ ] macOS, Intel, Xcode 13.2.1 (Swift 5.5.2)
[ ] macOS, Intel, Xcode 12.5.1 (Swift 5.4.2)
[ ] macOS, Intel, Xcode 12.4 (Swift 5.3.2)
[X] Ubuntu 20.04, Aarch64, Swift 5.6.2 release
[X] Ubuntu 20.04, Aarch64, Swift 5.7 nightly build
[X] Ubuntu 20.04, Aarch64, Swift 5.8 nightly build
[ ] Ubuntu 20.04, Intel, Swift 5.3.3 release
[ ] Ubuntu 20.04, Intel, Swift 5.4.3 release
[ ] Ubuntu 20.04, Intel, Swift 5.5.3 release
[ ] Ubuntu 20.04, Intel, Swift 5.6.2 release
[ ] Ubuntu 20.04, Intel, Swift 5.7 nightly build
[ ] Ubuntu 20.04, Intel, Swift 5.8 nightly build
[ ] Windows 10, Intel, Swift 5.6.2 release
[ ] Windows 10, Intel, Swift 5.7 nightly build
[ ] Windows 10, Intel, Swift 5.8 nightly build

Merged all outstanding PRs. Verified current HEAD contents on release/1.0 are identical to what I tested above.

Updated readme in #170.

Release draft available at https://github.com/apple/swift-collections/releases/edit/untagged-bcdc14a93b7fd8d74c2d

Diff against 1.0.2: https://github.com/apple/swift-collections/compare/1.0.2...f504716c27d2e5d4144fa4794b12129301d17729

This looks ready to get tagged.

The candidate commit has been tagged, and the new release is published.


nci.projects.default.drvConfig.env settings don't merge

We're trying to set nci.projects.default.drvConfig.env in 2 places in our flake, and one value seems to be clobbering the other. Here are the 2 lines of code:

https://github.com/molybdenumsoftware/pr-tracker/blob/7ea7db7c2471d573c884b3d4a748100775917657/modules/program-docs.nix/#L15
https://github.com/molybdenumsoftware/pr-tracker/blob/7ea7db7c2471d573c884b3d4a748100775917657/modules/nci.nix/#L12

If we comment out the setting in modules/nci.nix, we see the setting in program-docs.nix get evaluated (and thereby blow the assertion in program-docs.nix):
$ nix eval github:molybdenumsoftware/pr-tracker/0ed99949b3f0627711c43f00da5bbe99d6cafd9b#fetcher -L
«error: inside program-docs.nix. we hit this assertion because we commented out the corresponding setting in modules/nci.nix»

And if we do not comment out the setting in modules/nci.nix, we don't hit the assertion in program-docs.nix:
$ nix eval github:molybdenumsoftware/pr-tracker/bb15515#fetcher -L
«derivation /nix/store/xkvq5dkw0sqgd6lp40kdk3xds1s1sla0-pr-tracker-fetcher-4.1.1.drv»

(sorry for the messy branch, it's very WIP right now)

should work fine now


add menu item: open all sections

and while you are at it, capitalization should be "Collapse all sections" and "Open all sections".


Iveco-scratch as reference

Hello, we want to write a small client for demo on the CES, in Python to connect with the databroker. Sebastian mentioned an Iveco-scratch project for reference. Do you have a link?

Answered in PM


Add docs on disabling lazy loading in relation managers

RM's are lazy loaded by default. This causes an issue with pagination in Livewire per this discussion on discord and this PR in LW.
You can disable lazy loading in RMs by passing 'lazy' => false to the properties. This PR adds this to the docs.

[ ] Changes have been thoroughly tested to not break existing functionality.
[X] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Maybe it makes sense to add the same API as widgets have (an $isLazy property)?

@zepfietje It would keep things consistent. However, AFAIK you can't pass properties to widgets like you can for RM. This means there could be a conflict if a dev were to pass both the property but also use the API. I would just need to know which should take precedence.

Widgets do allow passing arguments to their make() method.
There was actually an issue or PR the other day caused by a conflict like you described I believe.
Let's leave this up to @danharrin to decide.


Issue #341 Add status command steps in basic tests

Uses code-ready/clicumber#8. Adds status checks before crc start, after it and before crc stop, and after crc stop.

retest this please.

retest this please

retest this please


Sign Client Initialize fail in the release build [Android]

Bug
The initialization of the sign client failed in the release version of the app, but it works perfectly in the debug build.
Root cause:
Function '<init>' (JVM signature: <init>(Lcom/squareup/moshi/Moshi;)V) not resolved in class com.walletconnect.sign.common.adapters.SessionRequestVOJsonAdapter:\npublic constructor SessionRequestVOJsonAdapter(moshi: com.squareup.moshi.t) defined in com.walletconnect.sign.common.adapters.SessionRequestVOJsonAdapter | <init>(Lcom/squareup/moshi/t;)V
SDK Version

Client: Kotlin
Version: Bom 1.11.1

Device:

Device: Pixel 4a
OS: Android 13

Fixed in 1.12.0 🎉


Cannot manipulate 'edge' to a exported port

These are somehow special, and cannot be selected nor moved it seems.

They are special in the graph model though, right? I can make it so they can be selected. But moving doesn't work, b/c outports can't be floating disconnected.


eslint configuration

Although we have linting configuration files available for both jsHint and JSCS. It think it would be helpful add a configuration file for eslint as well.
Although eslint being the most flexible js linting plug-in out there. I could not find a config file tailored for angular js projects.

https://www.npmjs.com/package/eslint-plugin-angular


error : "Error database insert failed" mid Dec onwards on multiple machines same error

hi, Copy ShortURL firefox add-in worked fine all during december, then it started only working intermitently for 1-2 days and then it stopped working altogether; now it gives me the "Error databse insert failed"; I have tried clearing the cache, has not made any difference.

Same circumstance here.  Copy ShortURL no longer working in any Firefox mode (i.e., including "Private").  This appears to have started when Firefox was auto-updated to v121.0.1 (64-bit); however, that might be a coincidence.
Running v5.5.0 (updated 01/10/24)
Options selected:

automatic updates = default
run in private windows = allow
run on restricted websites = don't allow

Permissions granted:

access data for all websites
input data to the clipboard
display notifications

Preferences selected:

no URL shortening service selected
shorten canonical URL when longer than 30 characters
use special case URL formats (when available)
remove ?utm_* parameters
show notification pop-up

Preferences not selected:

keep #hash in final URL
copy page title

Other add-ons operating in the environment are:

DuckDuckGo Privacy Essentials
Easy Youtube Video Downloader Express
uBlock Origin

Other environment information:

Apple MacBook Air (M1, 2020 w/ 16Gb memory)
macOS Sonoma (v14.2.1 23C71)

Please note / notify when repaired...
Thanks!

Oof! I wonder if there was a breaking Firefox change that caused this. The extension itself did not change. I'll investigate and roll an update as needed!

@vistisoara @ptarsus07 what shortening service do you use? I use bitly and it appears to work just fine.

@vistisoara @ptarsus07 what shortening service do you use? I use bitly and it appears to work just fine.

Hi @fwenzel I suspect there is some problem with the default shortener is.gd. For the past two months or so it often displays the same error message ("Error, database insert failed") even when I use it directly. This is unfortunate because I cannot find another shortening service that is as clean and limit-free as is.gd.

@ss249tp I agree - it does not seem to be a problem with the extension, more with the service used. I should make the extension make that clear, I admit that it is confusing.
For now my recommendation is to use a different shortening service (I use bitly with an account and API key but it is not a paid plan). The other shorteners seem to work fine also, I guess it depends on what one is looking for.


[build-and-push] tag remote prod as prod-1 before pushing new prod

This should keep the previous image in the image repository in case we need to rollback, or redeploy (before importing the new image):
https://github.com/packit/deployment/pull/208#issuecomment-842989232

:+1:
prod-1

So adding the tag via Quay.io (API) probably won't work, because it has a different manifest digest, which is what the k8s/openshift image stream points to.
And I don't quite understand why, because when I'm adding a tag (in tags tab, Options->Add New Tag), it says "Add Tag to Manifest sha256:abcxyz", but then the created tag has completely new/different manifest ???
On the other hand, tagging the image locally and pushing it does not change the manifest digest, so that can still be the way how to achieve this.

tagging the image locally and pushing it does not change the manifest digest, so that can still be the way how to achieve this.

I played with pulling/tagging/pushing images via podman/docker in the action, but wasn't able to make it work.
#3 should fix the problem at a cost of having more tags in the repository.
But someone/something can purge them from time to time, if ever needed.


Excluding a specific sub-directory from shared_dirs

Hello,
I need to be able to deploy a sub-directory (let's call it 'versioned-sub-directory') of a directory ('parent-directory') that is currently specified under shared_dirs.
I could use 'shared_dirs' to specify all of the sub-directories under 'parent-directory', leaving out both the 'parent-directory' and 'versioned-sub-directory' however the contents of 'parent-directory' can change without my knowledge so I would prefer to avoid this.
Here's my current directory structure for shared dirs:
parent-directory
--unversioned-sub-directory-1
--unversioned-sub-directory-2
--unversioned-sub-directory-3
--versioned-sub-directory
--unversioned-sub-directory-4
By default that configuration won't deploy --versioned-sub-directory
I hope that makes sense. Is there a way of achieving this?
Many thanks

Dud not get it.

:) I'll try again...
I have a directory specified in shared_dirs but I need to ensure one of its children is deployed.
Is that any clearer!?

Solution: write your own task for doing it.

Just in case anyone else comes across this, here's my approach to solving it:
New Tasks (Marked private as not expected to be run independently)
desc('Copy directories to be excluded from shared dirs');
task('shared_exclusions:copy', function () {
    $tempPath = "/tmp/";

    foreach (get('shared_dirs_exclusions') as $dir) {
        // If release contains excluded shared dir, copy that dir from release to tmp.
        if (test("[ -d $(echo {{release_path}}/$dir) ]")) {
            run("mkdir -p $tempPath" . dirname(parse($dir)));
            run("cp -rv {{release_path}}/$dir $tempPath" . dirname(parse($dir)));
        }
    }
})->setPrivate();

desc('Reinstate directories excluded from shared dirs');
task('shared_exclusions:reinstate', function () {
    $tempPath = "/tmp/";

    foreach (get('shared_dirs_exclusions') as $dir) {
        // If tmp contains excluded dir, copy that dir from release to tmp.
        if (test("[ -d $(echo $tempPath$dir) ]")) {
            run("cp -rv $tempPath$dir {{release_path}}/" . dirname(parse($dir)));
            run("rm -r $tempPath" . dirname(parse($dir)));
        }
    }
})->setPrivate();

Update deploy routine
desc('DEPLOY - Regular deployment');
task('deploy', [
    'deploy:prepare',
    'deploy:lock',
    'deploy:release',
    'deploy:update_code',
    'shared_exclusions:copy',
    'deploy:shared',
    'shared_exclusions:reinstate',
    'deploy:clear_paths',
    'deploy:symlink',
    'deploy:unlock',
    'cleanup',
    'success'
]);

Example Config
set('shared_dirs_exclusions', [
    'public_html/content/plugins/dir-to-exclude'
]);

Add a Default (to avoid errors when there are no directories to be ignored)
set('shared_dirs_exclusions', array());


Update blockifier to 0.8.0-rc.3

There seems to be a difference in the versioned_constants_13_2.json files between the main branch and the blockifier-v0.8.0-rc.3 branch
Main has a few extra fields compared to the rc3 branch


All Macros gone with 7.1.5 launch.

Logged in this morning to find all but 3 macros have disappeared. DB_Frostmage and 2 others are still listed. This includes all my custom scripts as well =(
Any idea if I can recover these?
This may have something to do with it.
Date: 2017-01-10 09:24:55
ID: 1
Error occured in: Global
Count: 2
Message: ..\AddOns\GS-Core\startup.lua line 422:
attempt to concatenate local 'specclass' (a nil value)
Debug:
GS-Core\startup.lua:422: GSisSpecIDForCurrentClass()
GS-Core\startup.lua:537: GSAddSequenceToCollection()
GS-Core\startup.lua:565: GSImportMacroCollection()
GS-DraikMacros\loaded.lua:16: in main chunk
[C]: LoadAddOn()
GS-Core\startup.lua:592: in main chunk
Locals:
specID = 64
_ = 64
specname = "Frost"
specdescription = "Freezes enemies in their tracks and shatters them with Frost magic."
specicon = "Interface\Icons\Spell_Frost_FrostBolt02"
_ = "DAMAGER"
specrole = "MAGE"
specclass = nil
currentclassDisplayName = "Paladin"
currentenglishclass = "PALADIN"
currentclassId = 2
(*temporary) =  defined @Interface\AddOns\GS-Core\langs\preinit.lua:116
(*temporary) = "Checking if specID "
(*temporary) = 64
(*temporary) = " "
(*temporary) = nil
(*temporary) = " equals PALADIN"
(*temporary) = "PALADIN"
(*temporary) = "attempt to concatenate local 'specclass' (a nil value)"
L =  {
is unknown. = " is unknown."
No value = "No value"
As GS-E is updated, there may be left over macros that no longer relate to sequences.  This will check for these automatically on logout.  Alternatively this check can be run via /gs cleanorphans = "As GS-E is updated, there may be left over macros that no longer relate to sequences.  This will check for these automatically on logout.  Alternatively this check can be run via /gs cleanorphans"
sequenceIndex:  = "sequenceIndex: "
Step Function = "Step Function"
Reloading Sequences = "Reloading Sequences"
has been added as a new version and set to active.  Please review if this is as expected. = " has been added as a new version and set to active.  Please review if this is as expected."
Clear Errors = "Clear Errors"
Matching StepFunction = "Matching StepFunction"
No Help Information Available = "No Help Information Available"
Colour and Accessibility Options = "Colour and Accessibility Options"
Incorporate the second trinket slot into the PostMacro. This is the equivalent of /use [combat] 14 in a PostMacro. = "Incorporate the second trinket slot into the PostMacro. This is the equivalent of /use [combat] 14 in a PostMacro."
Prevent UI Errors = "Prevent UI Errors"
Store output of debug messages in a Global Variable that can be referrenced by other mods. = "Store output of debug messages in a Global Variable that can be referrenced by other mods."
Disable Sequence = "Disable Sequence"
Setting Editor clean  = "Setting Editor clean "
none = "none"
Received Sequence  = "Received Sequence "
Use First Ring in Postmacro = "Use First Ring in Postmacro"
Line :  = "Line : "
equals currentclassid  = " equals currentclassid "
. Overriding with information for current spec  = ". Overriding with information for current spec "
. This version was not loaded. = ". This version was not loaded."
From library = " From library"
Close to Maximum Macros.  You can have a maximum of  = "Close to Maximum Macros.  You can have a maximum of "
.  As a result this macro was not created.  Please delete some macros and reenter  = ".  As a result this macro was not created.  Please delete some macros and reenter "
Ready to Send = "Ready to Send"
Picks a Custom Colour for the Mod Names. = "Picks a Custom Colour for the Mod Names."
Source  = "Source "
Selecting tab:  = "Selecting tab: "
Yes = "Yes"
: Your current Specialisation is  = ": Your current Specialisation is "
Only Save Local Macros = "Only Save Local Macros"
: To get started  = ": To get started "
GS-E Plugins = "GS-E Plugins"
.  You can also have a  maximum of  = ".  You can also have a  maximum of "
Picks a Custom Colour to be used for unknown terms. = "Picks a Custom Colour to be used for unknown terms."
Registered Addons = "Registered Addons"
GnomeSequencer was originally written by semlar of wowinterface.com. = "GnomeSequencer was originally written by semlar of wowinterface.com."
Icon Colour = "Icon Colour"
: You cannot delete the only copy of a sequence. = ": You cannot delete the only copy of a sequence."
Incorporate the belt slot into the PostMacro. This is the equivalent of /use [combat] 5 in a PostMacro. = "Incorporate the belt slot into the PostMacro. This is the equivalent of /use [combat] 5 in a PostMacro."
No Specialisation information for sequence  = "No Specialisation information for sequence "
Sequence specID set to current spec of  = "Seq
AddOns:
Swatter, v7.1.5675 (TasmanianThylacine)
AskMrRobot, v46
AucAdvanced, v7.1.5675 (TasmanianThylacine)
AucFilterBasic, v7.1.5675 (TasmanianThylacine)
AucFilterOutlier, v7.1.5675.5459(7.1/embedded)
AucMatchUndercut, v7.1.5675.5585(7.1/embedded)
AucStatHistogram, v7.1.5675 (TasmanianThylacine)
AucStatiLevel, v7.1.5675 (TasmanianThylacine)
AucStatPurchased, v7.1.5675 (TasmanianThylacine)
AucStatSales, v7.1.5675.5598(7.1/embedded)
AucStatSimple, v7.1.5675 (TasmanianThylacine)
AucStatStdDev, v7.1.5675 (TasmanianThylacine)
AucStatWOWEcon, v7.1.5675.5613(7.1/embedded)
AucUtilAHWindowControl, v7.1.5675.5575(7.1/embedded)
AucUtilAppraiser, v7.1.5675.5666(7.1/embedded)
AucUtilAskPrice, v7.1.5675.5599(7.1/embedded)
AucUtilAutoMagic, v7.1.5675.5587(7.1/embedded)
AucUtilCompactUI, v7.1.5675.5629(7.1/embedded)
AucUtilEasyBuyout, v7.1.5675.5576(7.1/embedded)
AucUtilFixAH, v7.1.5675 (TasmanianThylacine)
AucUtilItemSuggest, v7.1.5675.5651(7.1/embedded)
AucUtilPriceLevel, v7.1.5675.5633(7.1/embedded)
AucUtilScanButton, v7.1.5675.5631(7.1/embedded)
AucUtilScanFinish, v7.1.5675.5588(7.1/embedded)
AucUtilScanProgress, v7.1.5675.4979(7.1/embedded)
AucUtilScanStart, v7.1.5675.5347(7.1/embedded)
AucUtilSearchUI, v7.1.5675.5672(7.1/embedded)
AucUtilSimpleAuction, v7.1.5675.5654(7.1/embedded)
AucUtilVendMarkup, v7.1.5675.4828(7.1/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BeanCounter, v7.1.5675 (TasmanianThylacine)
Configator, v5.1.DEV.406(/embedded)
ConsLegion, v1.28
DBMCore, v
DBMDefaultSkin, v
DBMStatusBarTimers, v
DebugLib, v5.1.DEV.337(/embedded)
Druidform, v
Enchantrix, v7.1.5675 (TasmanianThylacine)
EnchantrixBarker, v7.1.5675 (TasmanianThylacine)
Gladius, v5.0.6
GSCore, v152
GSDraikMacros, vv1.5.1 Legion 7.1
LibExtraTip, v5.12.DEV.412(/embedded)
SlideBar, v7.1.5675 (TasmanianThylacine)
Stubby, v7.1.5675 (TasmanianThylacine)
TipHelper, v5.12.DEV.405(/embedded)
WeakAuras, v<IP_ADDRESS>
WeakAurasOptions, v<IP_ADDRESS>
BlizRuntimeLib_enUS v<IP_ADDRESS>100
(ck=80d)

I'm guessing GSE 1.5?
TimothyLuke

On 11 Jan 2017, at 3:48 am, Vaughn<EMAIL_ADDRESS>wrote:
Logged in this morning to find all but 3 macros have disappeared. DB_Frostmage and 2 others are still listed. This includes all my custom scripts as well =(
Any idea if I can recover these?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Tim!
This is for GSE 1.5, multiple users are experiencing this bug although it doesn't seem like they've reached very far out of the LazyWoWMacros thread to talk about it.
A temporary fix has been posted in this thread: https://wowlazymacros.com/forums/topic/7-1-5-gse-change-question/ by commenting out lines 421 to 425 of the startup.lua, effectively breaking the "GSisSpecIDForCurrentClass" function
This seems to restore the ability to choose from the list of all DB included sequences, but I was unable to find my custom imported sequences using the "temp fix" method. Importing new sequences seemed to work after the fact and persisted through exiting the game.
Hopefully this is all useful information. :)

That fixes one problem but there are 10000000 more underneath.  you can use existing macros but cant do anything else.  Im wokring on the last parts of GSE2 and will release that in a few hours once i fix this import/migration bug

Yes it is for 1.5 Timothy. And thank you for getting on this so quickly, Not sure I know how to play anymore without your wonderful program =)

Awesome! Glad to hear that GSE2 will be out soon. :)


Utkarsh pro/UI/addons extraction

Signed-off-by: Utkarsh Srivastava<EMAIL_ADDRESS>Description
This PR adds a separate slider menu for addons
Relevant screenshorts:

Signed commits

[x] Yes, I signed my commits.

@utkarsh-pro one item I overlooked in our conversation is the state whether any of these add-ons are present in the cluster or not (whether or not the switch should be on or off when the user navigates away and returns to the page). MeshSync v1 is discovering Prom and Graf, and we can quickly add discovery for the others. We will need to define the logic by which state of the switch is controlled.
For simple training purposes, we can assume that is a Prom or Graf is registered in Settings then that instance of Prom and/or Graf is the same instance being used by the given service mesh (adapter), however, this won't always be the case.
// @kalradev

@utkarsh-pro can we split this PR into two PRs so that the rearrangement of the namespace field and adapter chip can land while the MeshSync considerations are made in the meantime?

@utkarsh-pro can we split this PR into two PRs so that the rearrangement of the namespace field and adapter chip can land while the MeshSync considerations are made in the meantime?

@leecalcote, the rearrangement of namespace field and adapter chip was in my previous PR. This one only adds the switches to the addons. So we can hold this one until we have clarification on the meshsync thing?

Oooh. 😆, yes.

@utkarsh-pro this functionality is positioned to be the first to take advantage of MeshSync v2. Considering use of SSE, @kumarabd, what's the recommended approach to an endpoint that will expose this information?

@utkarsh-pro this functionality is positioned to be the first to take advantage of MeshSync v2. Considering use of SSE, @kumarabd, what's the recommended approach to an endpoint that will expose this information?

One needed to be created here with GraphQL. Issue created for that -

@utkarsh-pro this functionality is positioned to be the first to take advantage of MeshSync v2. Considering use of SSE, @kumarabd, what's the recommended approach to an endpoint that will expose this information?

A new endpoint needs to be added for this purpose. Issue to track - https://github.com/layer5io/meshery/issues/2401


Gossip on Solidification

Change the gossip logic to only broadcast on solidification.
Ideas

Only gossip if the node is synced
Only store if the message was requested or referenced by a new milestone before CacheTime is due
Punish neighbors that sent unsolid and unknown transactions if we are synced (count unsolid messages per neighbor and decrease the amount if the message got solid)

Don't store messages if below max depth and not requested, or not solid

Always gossip valid milestones


setting ui and tooltip language

I have added language:nl to the froala options object and added the language file to index.html like so: <script src="assets/froalaLangs/nl.js"></script>
Nothing is being translated, however. I can log the FE object in the language file, so it's definitely instantiated, but all tooltips remain in english.
Froala version: 3.0.3-2 (also tested with 3.0.1)
Angular: 8.0.1

Nevermind, found the issue, for those who would come here through google:
Import the file directly into the component -> import 'node_modules/froala-editor/js/languages/nl.js';


Rearchitect & modularize for integration

If we abstract away the jQuery code, it should be easier to provide components for libraries like React and Angular.

Is there a component for Angular?

@nicoesiea Not specifically, no, though I imagine there's a way to include custom code within an Angular app. And this is very old and unmaintained for now.


Emit stable auto-instrumented otel metrics

API change check
API changes are not detected in this pull request.


GLS edit of Scrum is completed

I'll going to merge it after you commit the suggestion - thanks again!

Good to go!


jsonb type support for postgresql

It looks like waterline supports the json type for postgres; in 9.4, the jsonb type was introduced which offers significant advantages: http://www.postgresql.org/docs/9.4/static/datatype-json.html.
Would the core team consider a PR that supports the jsonb type?

I'm using sails-postgresql 0.11.4 which is still mapping to JSON and not JSONB.  Are there plans?


Promote on changes to changes to promotionPaths

Problem Statement
We have a relatively dynamic list of clusters. Upon adding a targetPath, there is no way to trigger a promotion to the new  targetPath for all paths in sourcePath/workspace (except whitespace-changing all paths). If one were to manually copy over the workspace to the promotion folders, allow and block lists would not be respected.
Proposed Solution
Upon changing telefonistka.yaml, telefonistka should create PRs reconciling the telefonistka.yaml with the repo state.
I'm not sure if this should also include folder deletions, as these are easier to do manually (no allow/block lists to consider) and telefonistka kind of has a roll-forward-only notion.
Alternatives Considered
having a file in every folder under workspace that contains the last modified timestamp or sha of the telefonistka.yaml.
Additional Context
Please provide any other information that may be relevant.

Interesting...
The hardest part would generatign the list of components to promote
Telefonistka isn't really aware of all the component paths in a folder - it looks at any file that was changed in  a PR  analyze it "on the spot".
I would have to get a list of all files under said sourcePath  and consider them as changed, as long as people don't have insanely big repos this should be ok

Tracking changes in the root telefonistka.yaml was also requested inhttps://github.com/wayfair-incubator/telefonistka/issues/105

I'm gonna try the alternative considered for now and see if this is too much of a crutch.


Make nice interface to edit facts

I feel like they should be able to easily edit the file in like nano or vim.


Could not create repos in Azure CLI. Still failed with no authurized even if I have login and set the default org and project.

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az repos create Extension Name: azure-devops. Version: 0.11.0.
Errors:
The requested resource requires user authentication: https://dev.azure.com/{org}/{project}/_apis/git/repositories
Traceback (most recent call last):
pip-install-qdpilz60\knack\knack\cli.py, ln 206, in invoke
cli\core\commands\__init__.py, ln 578, in execute
cli\core\commands\__init__.py, ln 636, in _run_jobs_serially
cli\core\commands\__init__.py, ln 627, in _run_job
azext_devops\dev\common\exception_handler.py, ln 26, in azure_devops_exception_handler
    reraise(*sys.exc_info())
...
azure-devops\azext_devops\devops_sdk\client.py, ln 254, in _handle_error
    url=request.url))
azext_devops.devops_sdk.exceptions.AzureDevOpsAuthenticationError: The requested resource requires user authentication: https://dev.azure.com/{org}/{project}/_apis/git/repositories

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az repos create --name {} --org {} --project {}

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: cmd.exe

azure-cli 2.0.69 *

Extensions:
azure-devops 0.11.0

Additional Context

Hi @LiangMengdi  ,
Looks like you don't have enough permissions to create a repo
Can you check if you have Create repository permission on the same project?
You can verify this by visiting your Project settings page.

(1) Project Settings, (2) Repo, - Repositories (3) Git repositories.
Type your user name in the search box on the left and check the permissions corresponding to "Create repository" on the right side
It should be allow for you to create repos.

Refer this for more details.

Were you logged in when you tried the command - Use az login or az devops login.
Please try some command which needs lesser permissions like az devops project list to rule out permission issue.

*Also please update the extension there is a newer version available.
Please open a new issue if the above does not resolve the issue for you.


Running convert_era5_hourly shows Killed.

I have successfully downloaded a one-month era5 data using download_era5.py. However, when I run the convert_era5_hourly.py, it showed Killed at last. This happened despite I set the start_time and end_time interval, like 5 days or 30 days. My memory capacity is 32GB. Can you give me some suggestions?

It happens in the Xt0 = np.stack(Xt0, axis=-1) due to a too long array. Is there any way to work around this? Thank you.


Adding header option for making secure request

Enhancing the custom request url option to include headers for making authorized requests.

Can I ask what your use case is?

We use proxy server to secure the google key, but the URL is exposed to public since it will be used for our mobile app. To make sure all requests to the proxy server are coming from the mobile app, we are passing the user JWT in authorization header so we know it is request is valid.

Is this web specific?
This sounds like it solves a pretty narrow use case, and may be a little out of scope for this library.

It is not web specific. The plug-in requires unrestricted key to be used in the mobile app, but we needed to secure the google key, we did that by using a proxy server. Using a proxy server doesn’t eliminate the security issue, we still need to protect the requests that is coming in. With the authorization header the plug-in makes secure calls to the proxy server.
If it’s out of scope how do you recommend making secure calls when using proxy server to protect google key? Open to ideas, please advise.

Closing in favor of #734


ci: move CI related files to .ci folder

To unify the structure of CI related files we would put every file used by the CI into a root folder named .ci that folder will also contain the job definition and other stuff provided by Infra, it improves our configuration as code infrastructure.
We keep the current job and we add 2 new that will replace the original when we'd finalize the tests.

@beniwohli we need your approval here, it does not change anything on the current job but allow us to tune the new job to replace the current.


streamIDs:  stream id overflow,  reuse and confliction avoid

RSocket Java SDK implemented this feature
https://github.com/rsocket/rsocket-java/blob/develop/rsocket-core/src/main/java/io/rsocket/StreamIdSupplier.java
Consideration:

stream id overflow and reuse
fix stream id confliction after overflow and reuse

Okey. I'll do it later.

Done at master branch.
Now it'll check StreamID conflicts after first lap. (skip in first lap because of no necessary.)
See: https://github.com/rsocket/rsocket-go/blob/master/internal/socket/stream_id.go


Requested functionality for unit-cell/wavelength conversion

The laue.index command is monochromatic and frequently causes a deviation of 5-10% in unit cell axis lengths from the published cell, presumably with a corresponding shift in wavelength in the opposite direction. Indexing at the correct cell is frequently impossible (at least with the BioCARS spectrum), but incorrect unit cells can impact downstream analyses.
A function/command for rescaling the unit cell, wavelength, and any other coupled parameters would be helpful for users to correct the unit cell after laue.optimize_indexing assigns wavelengths.
@kmdalton @DHekstra, any ideas for algorithms regarding this? Would a simple arithmetic solution based on % difference between indexed/correct cell and multiplying the unit cell axes/wavelengths be sufficient?

Does laue.index include a refinement step?  What about using refinement.parameterisation.crystal.unit_cell.restraints.tie_to_target?  This adds a restraint on the unit cell, specifying values for the unit cell, and sigmas for the desired error off of those values.

@phyy-nx, interesting. that is different than just specifying the unit cell, which in our case appears to be brittle--that often just fails.
As I understand it, the basic phenomenon is that during (monochromatic) indexing dials.index will lock onto some pattern, but it does not need to be at the peak wavelength. We see unit cell dimensions that can be off by as much as 5 or 10%. What @PrinceWalnut is suggesting is that we do a posterior correction of wavelength and unit cell dimensions.
Most naively, if we take Bragg's law, we can try rescaling all the lambdas and all the d's by a constant, scaling both the unit cells and the wavelengths to match either a reference spectrum or a reference unit cell. It's really just an aesthetic fix--getting the miller indices right and the wavelengths up to a scalar is all we need for downstream processing as long as we have reliable unit cell dimensions from some other source.
From staring at Bragg's law, there is one other catch, which is that sin(theta) \approx sqrt(X^2+Y^2)/D at small angles, such that errors in detector distance complicate the idea that one can simply rescale both the unit cell dimensions and the wavelength.

Makes sense, a posterior correction would be fine.  I think it would be worth trying tie_to_target regardless, especially if detector distance is fixed, and wavelength and unit cell are allowed to refine.

While it is an aesthetic fix, I would argue it's important for users doing diagnostic steps prior to careless, as Maggie/Dennis/Harrison have demonstrated. I expect that it would also be helpful prior to certain routines like laue.optimize_indexing where an initial estimate is used, since the indexed unit cell may be outside of the radius of convergence.


refactor(label): remove "name" from "AttributeInfo._repr_attrs"

Attr "name" is displayed in AttributeInfo._repr_head

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.921%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5292

Relevant Lines:
6382

💛  - Coveralls