Readme assumes Continuum Hypothesis

InfiniteCardinal{k}, for the cardinality of an infinite set, e.g., ℵ₀ for the cardinality of the integers and ℵ₁ for the cardinality of the reals.

Not sure if this is intended, but a priori, (with standard notation) ℵ₁ being the cardinality of the reals is equivalent to accepting the Continuum Hypothesis

I'll merge a PR that makes this clear

Or a design that better captures this subtlety... is there a notation for the cardinality of the reals that is independent of the continuum hypothesis?

Generally, 2^{ℵ_0} can be used to represent the cardinality of the reals, but I'm not sure if that is intended.

We could support 2^ℵ₀ via:
struct ExponentialCardinal{k} <: Integer end
function ^(x::Integer, p::InfiniteCardinal{0})
    @assert x == 2
    ExponentialCardinal{k}()
end
function ^(x::Integer, p:: ExponentialCardinal{k}) where k
    @assert x == 2
    ExponentialCardinal{k+1}()
end


panic on run-prepared

I'm trying to get rkt running on kubernetes, right now I'm running into a crash in rkt itself.  I'm not 100% sure what everything that I'm seeing means, but I can make the crash happen without using kubernetes at all, so I'm raising an issue here.  It might be that something is specified improperly in the manifest below (I'm assuming it's the isolators, since that's what's in the crash), but regardless the error should be caught rather than crashing.
Easy to reproduce:
foo.manifest:
{
   "acVersion":"0.6.1+git",
   "acKind":"PodManifest",
   "apps":[
      {
         "name":"worker",
         "image":{
            "id":"sha512-cda68312426746e287f69640c2bc4d1b65c2d33732de808735c983b133d83720"
         },
         "app":{
            "exec":[
               "/bin/hello"
            ],
            "user":"0",
            "group":"0",
            "environment":[
               {
                  "name":"KUBERNETES_PORT",
                  "value":"tcp://<IP_ADDRESS>:443"
               },
               {
                  "name":"KUBERNETES_PORT_443_TCP",
                  "value":"tcp://<IP_ADDRESS>:443"
               },
               {
                  "name":"KUBERNETES_PORT_443_TCP_PROTO",
                  "value":"tcp"
               },
               {
                  "name":"KUBERNETES_PORT_443_TCP_PORT",
                  "value":"443"
               },
               {
                  "name":"KUBERNETES_PORT_443_TCP_ADDR",
                  "value":"<IP_ADDRESS>"
               },
               {
                  "name":"KUBERNETES_SERVICE_HOST",
                  "value":"<IP_ADDRESS>"
               },
               {
                  "name":"KUBERNETES_SERVICE_PORT",
                  "value":"443"
               }
            ],
            "mountPoints":[
               {
                  "name":"default-token-sd82m",
                  "path":"/var/run/secrets/kubernetes.io/serviceaccount",
                  "readOnly":true
               }
            ],
            "ports":[
               {
                  "name":"worker-tcp-5000",
                  "protocol":"TCP",
                  "port":5000,
                  "count":0,
                  "socketActivated":false
               }
            ],
            "isolators":[
               {
                  "name":"resource/cpu",
                  "value":{
                     "request":"100m"
                  }
               }
            ]
         }
      }
   ],
   "volumes":[
      {
         "name":"default-token-sd82m",
         "kind":"host",
         "source":"/var/lib/kubelet/pods/48c30aec-57fc-11e5-8f54-42010af00504/volumes/kubernetes.io~secret/default-token-sd82m"
      }
   ],
   "isolators":null,
   "annotations":null,
   "ports":[
      {
         "name":"worker-tcp-5000",
         "hostPort":0
      }
   ]
}

Fetch the container, if you are wary of running my container, feel free to use your own, just replace the hash in the above json with the appropriate id.  I can't image the container itself makes a difference (although I don't actually know).
sudo rkt-v0.8.0/rkt fetch montage-generator.appspot.com/hello:0.0.1
Now prepare it and run it:
sudo rkt-v0.8.0/rkt prepare --pod-manifest foo.manifest --insecure-skip-verify
2015/09/10 21:24:44 Preparing stage1
2015/09/10 21:24:44 Loading image sha512-cda68312426746e287f69640c2bc4d1b65c2d33732de808735c983b133d83720
2015/09/10 21:24:44 Writing pod manifest
5af875c7-caf9-4cbb-8a2e-6cdc63e5874c

Make sure to replace the id in the following statement with whichever one you got in the previous step:
sudo rkt-v0.8.0/rkt run-prepared --mds-register=false --private-net 5af875c7-caf9-4cbb-8a2e-6cdc63e5874c
kaboom:
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x5b013f]

goroutine 1 [running, locked to thread]:
github.com/coreos/rkt/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/api/resource.(*Quantity).Value(0x0, 0x7fe2e81be200)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/Godeps/_workspace/src/github.com/GoogleCloudPlatform/kubernetes/pkg/api/resource/quantity.go:336 +0x1f
github.com/coreos/rkt/common/cgroup.addCpuLimit(0xc208032f80, 0xb, 0x10, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/common/cgroup/cgroup.go:47 +0x6f
github.com/coreos/rkt/common/cgroup.MaybeAddIsolator(0xc208032f80, 0xb, 0x10, 0x84a880, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/common/cgroup/cgroup.go:63 +0x122
main.(*Pod).appToSystemd(0xc20804c180, 0xc20805c6c0, 0x846700, 0xc2080bb990, 0x6, 0x0, 0x0, 0x0, 0x0)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/stage1/init/pod.go:256 +0x2a10
main.(*Pod).PodToSystemd(0xc20804c180, 0x0, 0xc2080bb990, 0x6, 0x0, 0x0, 0x0, 0x0)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/stage1/init/pod.go:387 +0x524
main.stage1(0x7fe2e81bdc60)
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/stage1/init/init.go:559 +0x13a4
main.main()
	/home/alban/go/src/github.com/coreos/rkt/release-build/gopath/src/github.com/coreos/rkt/stage1/init/init.go:781 +0x49

versions:
sudo rkt-v0.8.0/rkt version
rkt version 0.8.0
appc version 0.6.1

I've filed an immediate fix @ #1378.
You're right that the underlying issue is with the isolator type; right now, it's expected that a resource/cpu isolator has both a request and limit field: https://github.com/appc/spec/blob/master/spec/ace.md#resourcecpu . Hence, rkt assumes it has a limit and happily tries to apply it even though it has none, resulting in the panic.
Unfortunately this is a little unclear in the spec + schema code, so we should clear that up.

Thanks for finding this!

Thanks for the fix and the explanation :)


Setup multiarch CSV file

Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

Run operator BDD testing
Please add comment: /jenkins test

Run RHPAM operator BDD testing
Please add comment: /jenkins RHPAM test

/jenkins RHPAM test

RHPAM PR job #27 was: FAILURE
Possible explanation: Pipeline failure or project build failure
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/27//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/27/display/redirect or see console log:

Console Logs
    url = self._prepare_content_sets(self.image.get('packages').get('content_sets'))  File "/usr/local/lib/python3.6/site-packages/cekit/generator/base.py", line 432, in _prepare_content_sets    raise CekitError("Could not create ODCS compose", ex)cekit.errors.CekitError: ('Could not create ODCS compose', HTTPError('401 Client Error: Unauthorized for url: https://odcs.fedoraproject.org/api/1/composes/',))401 UnauthorizedUnauthorizedThis server could not verify that youare authorized to access the documentrequested.  Either you supplied the wrongcredentials (e.g., bad password), or yourbrowser doesn't understand how to supplythe credentials required.For traceback please try again the same command with env var KRB5_TRACE=/dev/stdoutmake: *** [Makefile.rhpam:37: container-build] Error 1[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Push Operator Image(s) to Openshift Registry)Stage "Push Operator Image(s) to Openshift Registry" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Run BDD tests)Stage "Run BDD tests" skipped due to earlier failure(s)[Pipeline] stage[Pipeline] { (Running smoke tests)Stage "Run BDD tests" skipped due to earlier failure(s)[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] }[Pipeline] // script[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/27/api/json[Pipeline] readJSON[Pipeline] sh

/jenkins RHPAM test

RHPAM PR job #28 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/28//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/28/display/redirect or see console log:

Console Logs
{"level":"info","T":"2022-02-09T14:36:52.045Z","logger":"j-bdd-ee50","msg":"Scenario duration","duration":"30m50.189534523s"}{"level":"info","T":"2022-02-09T14:36:52.268Z","logger":"j-bdd-ee50","msg":"Wait 1m0s for Removal of all related CRs for service RHPAM Kogito operator"}{"level":"info","T":"2022-02-09T14:36:53.309Z","logger":"j-bdd-ee50","msg":"'Removal of all related CRs for service RHPAM Kogito operator' is successful"}{"level":"info","T":"2022-02-09T14:36:53.324Z","logger":"j-bdd-ee50","msg":"Delete created namespace","namespace":"j-bdd-ee50"}{"level":"info","T":"2022-02-09T14:36:53.324Z","logger":"j-bdd-ee50","msg":"Deleting namespace","namespace":"j-bdd-ee50"}{"level":"error","T":"2022-02-09T14:37:04.001Z","logger":"j-bdd-b161","msg":"Error in step","step":"Build \"dmn-springboot-example-builder\" is complete after 10 minutes","error":"Timeout waiting for Build dmn-springboot-example-builder complete"}{"level":"info","T":"2022-02-09T14:37:04.001Z","logger":"j-bdd-b161","msg":"Step","stepText":"Build \"dmn-springboot-example\" is complete after 5 minutes"}{"level":"info","T":"2022-02-09T14:37:04.001Z","logger":"j-bdd-b161","msg":"Step","stepText":"HTTP POST request on service \"dmn-springboot-example\" is successful within 2 minutes with path \"Traffic Violation\" and body:"}{"level":"error","T":"2022-02-09T14:37:04.191Z","logger":"j-bdd-b161","msg":"Error in scenario","scenarioName":"Deploy .dmn source files with CLI using runtime springboot","error":"Timeout waiting for Build dmn-springboot-example-builder complete"}{"level":"info","T":"2022-02-09T14:37:04.192Z","logger":"j-bdd-b161","msg":"Scenario duration","duration":"31m2.362946154s"}{"level":"info","T":"2022-02-09T14:37:04.466Z","logger":"j-bdd-b161","msg":"Wait 1m0s for Removal of all related CRs for service RHPAM Kogito operator"}{"level":"info","T":"2022-02-09T14:37:05.503Z","logger":"j-bdd-b161","msg":"'Removal of all related CRs for service RHPAM Kogito operator' is successful"}{"level":"info","T":"2022-02-09T14:37:05.522Z","logger":"j-bdd-b161","msg":"Delete created namespace","namespace":"j-bdd-b161"}{"level":"info","T":"2022-02-09T14:37:05.522Z","logger":"j-bdd-b161","msg":"Deleting namespace","namespace":"j-bdd-b161"}{"level":"error","T":"2022-02-09T14:41:22.976Z","logger":"j-bdd-c50a","msg":"Error in step","step":"Build \"process-timer-quarkus-builder\" is complete after 10 minutes","error":"Timeout waiting for Build process-timer-quarkus-builder complete"}{"level":"info","T":"2022-02-09T14:41:22.978Z","logger":"j-bdd-c50a","msg":"Step","stepText":"Build \"process-timer-quarkus\" is complete after 5 minutes"}{"level":"info","T":"2022-02-09T14:41:22.979Z","logger":"j-bdd-c50a","msg":"Step","stepText":"HTTP POST request on service \"process-timer-quarkus\" is successful within 2 minutes with path \"timers\" and body:"}{"level":"error","T":"2022-02-09T14:41:23.251Z","logger":"j-bdd-c50a","msg":"Error in scenario","scenarioName":"Deploy source files in folder with CLI","error":"Timeout waiting for Build process-timer-quarkus-builder complete"}{"level":"info","T":"2022-02-09T14:41:23.252Z","logger":"j-bdd-c50a","msg":"Scenario duration","duration":"30m35.174468726s"}{"level":"info","T":"2022-02-09T14:41:23.604Z","logger":"j-bdd-c50a","msg":"Wait 1m0s for Removal of all related CRs for service RHPAM Kogito operator"}{"level":"info","T":"2022-02-09T14:41:24.638Z","logger":"j-bdd-c50a","msg":"'Removal of all related CRs for service RHPAM Kogito operator' is successful"}{"level":"info","T":"2022-02-09T14:41:24.656Z","logger":"j-bdd-c50a","msg":"Delete created namespace","namespace":"j-bdd-c50a"}{"level":"info","T":"2022-02-09T14:41:24.657Z","logger":"j-bdd-c50a","msg":"Deleting namespace","namespace":"j-bdd-c50a"}{"level":"info","T":"2022-02-09T14:41:25.897Z","logger":"main","msg":"Uninstalling Kogito operator"}{"level":"info","T":"2022-02-09T14:41:25.897Z","logger":"main","msg":"Execute command","command":"oc","args":["delete","-f","../rhpam-operator.yaml","--timeout=30s"]}                                    FAIL	github.com/kiegroup/kogito-operator/test	2145.694sFAILTests finished with code 1-------- Pruning namespacesI0209 14:41:56.665206   39845 request.go:655] Throttling request took 1.018262488s, request: GET:https://<IP_ADDRESS>:443/apis/k8s.cni.cncf.io/v1?timeout=32sPruning namespaces done./home/jenkins/agent/workspace/kogito/rhpam-kogito-operator-PR-check-new/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/rhpam-kogito-operator-PR-check-new/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/rhpam-kogito-operator-PR-check-new/test'make: *** [Makefile:327: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/rhpam-kogito-operator-PR-check-new/28/consoleText+ tail -n 100

/jenkins RHPAM test

I guess we are good to merge this one @spolti


[HOLD for payment 2023-05-23] [$1000] Composer not displayed when changing screen size during comment editing in Expensify

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to Expensify and start a conversation on a small screen size.
Send a message and click the "Edit" button to edit the message.
Change the screen size from mobile width to web or tablet width.
Click "Cancel" to exit the edit mode.

Expected Result:
After canceling the edit, the composer should be displayed.
Actual Result:
The composer is not displayed.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235475110-7beb4e03-6afa-450d-9f49-25f68b025021.mp4
https://user-images.githubusercontent.com/43996225/235475140-4b71f50c-95e1-4099-b087-2c1ce181f52d.mov
Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682930338820919
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0108128bec6e5358cf
Upwork Job ID:<PHONE_NUMBER>285188096
Last Price Increase: 2023-05-09

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

I've reproduced this on Safari using the reproduction steps above

@ahmdshrif thanks, your solution LGTM 👍🏼

Didn't mean to unassign @parasharrajat. he's the C+ here

Glad you agree 🙂

I've invited you both to the Upwork job for payment @parasharrajat and @ahmdshrif. Can you please accept that invite?

Working on this now. Will get the 50% bonus included.

Offers sent! Please let me know when you've accepted so I can complete payment. Thanks!

Closing the loop here, I've issued payment for @parasharrajat!

@roryabraham, is there anything else we need to do here? I think we can close this.

Seems like all payments have been issued, closing this out.

I think we're all wrapped up. Let me know if you disagree!


Lookahead might divide weights with mixed_float16

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow version and how it was installed (source or binary): 2.3.0-rc2 (source)
TensorFlow-Addons version and how it was installed (source or binary): Just lookahead extracted from the source (master)
Python version: 3.6.9
Is GPU used? (yes/no): yes

When tf.keras.mixed_precision.experimental.set_policy('mixed_float16') is set, using LookAhead divides the layers weights after a few gradient updates (for example 7 in my case).
After investigating, I think the reason is that when mixed_float16 is used with automatic loss scaling, the loss scale is initialized very high. Thus the first few gradient updates do nothing (see https://github.com/tensorflow/tensorflow/blob/582c8d236cb079023657287c318ff26adb239002/tensorflow/python/keras/mixed_precision/loss_scale_optimizer.py#L714 for how updates are skipped).
As a result, LookAhead ends up with its 'slow vars' initialized to 0 instead of the original layer weight. Indeed the vars are initialized to the correct value only on the first iteration during the gradient update (https://github.com/tensorflow/addons/blob/master/tensorflow_addons/optimizers/lookahead.py#L106).
Thus when the gradient update finally does something, the first variable update does average them with the slow variables (initialized to zero). Which would explain the weight division I'm seeing.
I don't have a short code to replicate the bug, but I think the above explanation and links should highlight well enough the issue with the current way LookAhead's slow variables are initialized.

Can you try if https://github.com/olesalscheider/addons/commit/83590598bd9e78b0aa58d18787acb754e1ac7cfe fixes your problem?

Can you try if https://github.com/olesalscheider/addons/commit/83590598bd9e78b0aa58d18787acb754e1ac7cfe fixes your problem?

Indeed, the proposed fix solves the issue.

Indeed, the proposed fix solves the issue.

@olesalscheider Can you submit a PR?

@olesalscheider Can you submit a PR?


MS0103: open a .osim file and load its elements to the visualizer.

This is one of the main tasks and it may take a longer time.

VTK Widget must be used.
Elements should be loaded to the correct location
Two-way selection: navigator-visualizer

clicking on the visualizer make the element selected in the navigator and vice versa.

All visualizer tools should be added with their functions.
view Interaction should be possible e.g. zooming, moving, ..etc.

Note:
I suggest doing this in two phases but feel free to use vtk directly if this is easier.

using the current OpenSim visualizer (it is openGL based).

this provides more understanding to the current gui pipeline.
this helps to keep back compatibility.
this also makes it easier to get new updates when needed.

using vtk.

I will try to inderstand the current visualiser  and see how to integrate it in Qt
as long it is not based on jxbrowser wich uses JavaSwing wich i dont see i way to include it
and for openGL i think QVtkOpenGlWidget a new widget instead of the QVtkWidget will
offer back compatibility ---to explore

after some reserch we extracted 3 points :

The default visualizer is a seperate program by it own and it does not offer a library to include it in OpenGL Surface  so we can not  use it inside Qt the link for the program
opensim_dependencies_install\simbody\bin\simbody-visualizer.exe
One Solution is that we develop our own program that render the Models using Qt3D it consist of rewriting opensim-visualizer from the ground
the other solution like you mentioned is to use the current visualiser and transform it to work with QtWebEngine the equivalent of jxBrowser wich is already working but using the server off a running opensim-gui as a start the link to open a visualiser in a browser is http:/localhost:8002/threejs/editor/index.html but the work to do is to make it run from this project

how do you think we should procced , and here is a screenshot of OpenSimQt using the server of
openSim-gui using QtWebEngine

The default visualizer is a seperate program by it own and it does not offer a library to include it in OpenGL Surface so we can not use it inside Qt the link for the program
opensim_dependencies_install\simbody\bin\simbody-visualizer.exe

the source code is available, so probably we can either:

build it as a library using it source code.
use its source code in our openGL qt widget

For now, I suggest to use the QtWebEngine solution if the above solutions take time, I will try to test it tomorrow and provide feedback.  I have some students who may work on the

You may start working on the next tasks as they are independent and they should not take time.

@idhamari  totaly agree building a visualizer using Qt3D opengl will be inspired from the default visualiser by going over SimTK documentation https://stanford.edu/~dembia/simbody_taskspace/html/classSimTK_1_1Visualizer.html
i will try and finish the QtWebEngin integration and the other tasks

totaly agree building a visualizer using Qt3D opengl will be inspired from the default visualiser by going over [SimTK documentation]  (https://stanford.edu/~dembia/simbody_taskspace/html/classSimTK_1_1Visualizer.html)

probably we can build a shared visualizer library by modifying the simbody visualizer CMakeLists.txt , you can also ask about this in the simbody forum, check first if there are related questions.
It seems QtCreator can not recognize QWebEngineView widget, I get this error:
mainwindow.cpp:-1: error: undefined reference to `QWebEngineView::QWebEngineView(QWidget*)'

Maybe this is an error related to Qt version, what version of are you using. Mine is Qt5.9.5. I could be able to run the Qt web examples i.e. webengine and webview but they used .pro not CMake. So Maybe the problem is related to CMake.

@idhamari

Sorry i didnt mentioned that , but you need to open Qt Maintenace tool and install the WebEngine Module otherwise it will not work

WebEngine was already installed. I found that I forgot to update the CMakeLists.txt file so I used the old file which does not contain the WebEngine:
          find_package(Qt5 COMPONENTS Widgets WebEngine WebEngineWidgets  LinguistTools REQUIRED)

It works now but it seems I have to have a server running

Nice! the server is created when you run the netbeans app (just for demonstration)

Yes, it works now, thanks for the info.

@yasseerr
As I understood:

Current simebody-visualizer uses glut which can not be integrated into Qt. There is a file with around 3000 lines of code.
opensim-gui does not use simbody-visualizer, instead, it uses a new (similar) visualizer based on java threejs 3D library. There is one file with around 2000 lines of code.
To integrate with QT we need to reimplement our visualizer using a supported 3D engine e.g. Qt 3D, Ogre or VTK.

Next Todos: Creating vsSimbodyVisualizer  alongside the current simebody-visualizer.

Study the current implementation of simbody-visualizer, how it communicates with the simulation process, how it is integrated in opensim-core, how it is integrated in opensim-gui.
The simbody source code shouldn't be modified, we just add a new folder with our visualiser. If needed you can create inherited classes from the original ones.
vsSimbodyVisualizer is based on VTK, this makes it easier to visualize different mesh format and write less code. VTK has also large support in opensource community and is used in similar Qt-based applications e.g. 3D SLicer.
vsSimbodyVisualizer works as a standalone application e.g. like the current visualizer.
vsSimbodyVisualizer works as a library and can be integrated into an external application e.g. our opensimQt interface.
vsSimbodyVisualizer should have all the functions needed for integration to an external interface.
vsSimbodyVisualizer should have better programming readability and simplicity e.g. less code and fewer files.
It should work with opensim-core and opensim-gui the same way as the current visualizer..
Compare the performance of vsSimbodyVisualizer to simebody-visualizer.

@yasseerr
please use our simbody branch:
https://github.com/VisSimKoblenz/simbody/tree/vsSimbodyVisualizer

@idhamari  understood !

@yasseerr
Urgent
Before things get out of control as we are getting more and more files,  please organize the naming of the current files in a standard way:

use vsWord1Word2 e.g.

visualizervtk ----------------------->  vsVisualizerVTK
openglvisualizer ------------------>  vsOpenGLVisualizer
geometryimplementationqt ---->  vsGeometryImplementationQT
actuatorsnode  --------------------> vsActuatorsNode

use the exact class and function names in your code e.g.  vsVisualizerVTK
use the same concept when creating new files and writing new code.

This will ensure readability and solve compatibility in Linux.

I also found this useful free VTK book with many examples

@idhamari  thanks for the suggestion!
just an update : its appear we can implement our visualizer by inheriting the
\Simbody\Visualizer\src\VisualizerGeometry.h and implement it functions to render using vtk
wich i had a problem this past days concerning the vtp files not been called in implementMeshFileGeometry however it had been solved, hopfully the geometryimplemetationqt.h will be implemented without any errors and the model will be loaded to the screen in the next 5 days without having to plug anything in the simbody project because we have access to the State variable unlike visualizer-simbody.cpp

its appear we can implement our visualizer by inheriting

This sound great

i had a problem this past days concerning the vtp files not been called

If in the future you have such a problem please let me know. I could suggest we ignore the vtp file because it is only one format and can be converted to another format when needed e.g. stl
I am looking forward to testing  the next working version version.

good to know, but the problem was about getting the system to load the meshes from the bodies independent from the mesh format, its about tweaking the params and calling the right functions
still next version comming soon 👍

@idhamari  hi!
what are those violet spheres and are they a problem/bug ?

@yasseerr  Not sure, which model are you using? they look like markers.

Notice that some model elements are visualized by opengl e.g markers, muscles and sometimes bodies. This means the mesh is generated programmatically not input from a file.

yes, so the the spheres where for debugging and they represent ground=>bodySet.. like in the topologie view , they are disabled now!
the model is arm26

just some more polishing and the loading part is over.

Looks great, well done!
I will test it soon and provide a feedback.

thank you, but it is not ready for  testing and if you want to test it change the path in vsMainWindow.cpp to your geometry folder
OpenSim::ModelVisualizer::addDirToGeometrySearchPaths("F:/FL/3/opensim-gui/opensim-models/Geometry");

Good to know!
I suggest:

add a folder called vsWorkSpace
modify cmake file to download the folders from here
use a relative path to vsWorkSpace

ok, that will help to not set the path at each installation

I also finds a few bugs related to compatibility with Linux. Please check them and consider them in your next commit (you can download the master branch as it is equivalent to this commit.

@yasseerr  there is something important to openGL.
Do you think it is possible to use an older VTK version that supports an older opengl?
This will give a big advantage: our interface can run on older computers in addition to virtualbox.

what does the linux error say?
and for vtk what old version of vtk that support OpenGL, because we are using QvtkOpenGLWidget that should work and we are using new principles in vtk like smartPointers , so we will test this one on virtual box if it does not work we will try and use the old one if that is possible depending on the version

what does the linux error say?

It is related to the file and class names you missed. Also sometimes you are using the class name when it is not needed. You can compare your branch with the master branch and check what changed.
For now, no need to worry about this. Please continue using the current version.

we will work on it later but maybe you are right they do not use vtk because of backword compatibility that glu32 provide , ifound this on visualizer.h

for the error try delete the build folder because a changed all the class names to vsNameName format

Here is an example of the error:
in vsMainwindow.cpp you used  vsMainWindow::vsMainWindow(QWidget *parent)
so changing the filename vsMainwindow.cpp to vsMainWindow.cpp  fix the problem
There are some other similar problems so please use the fixed code from the master in your branch.

We will continue using the new openGL for now as the hardware is getting better and the one we use is from last year. I also think virtualbox may updated their tool as well to support new openGL

hopefully.

@yasseerr
I just tested it and it looks very good.

I had a problem in my system related to OpenGL but i fixed it. It appears when secure boot is enabled it disable unsigned nvidia driver. This can be solved by disabling secure boot or signing nvidia driver.
For the big joints point, you can change their size in the program so they appear smaller than the others. In the future, we can give them a different shape so they can be recognized easily.
There is still something missing: the two-way selection e.g. when you select something in the visualizer window, it should be selected in the navigator and vice versa. This is not part of the simbody-visualizer so you can find the implementation in the java interface.

good to know.
for the big spheres. are you using the latest commit from visualizer-features branch
because they are dealt with and muscles have been added.
and for the features you mentioned it will be implemented as soon as we finish adding
wrapObjects and frames ... to the scene

for the big spheres. are you using the latest commit from visualizer-features branch

I  will wait until you use and test the updating in the master branch as it fixe a few linux bugs.

and for the features you mentioned it will be implemented as soon as we finish adding
wrapObjects and frames ... to the scene

Ok. When everything is done we will have a skype meeting to discuss the progress and close this task.

@idhamari  Hello!
i think all the component are loaded in the screen , and the visualizer branch has been merged with the master ,you can check the execution on linux
i just noticed that you added a folder for vsWorkSpace to store the geometries but the current solution will clone it directly to the executable_folder/vsWorkSpace

@yasseerr  excellent.

and the visualizer branch has been merged with the master ,you can check the execution on linux

Well done! there are still two errors:
 vsVisualizerVTK.h:24:31: error: extra qualification ‘vsVisualizerVTK::’ on member ‘renderGeometry’ [-fpermissive]
      vtkSmartPointer<vtkActor> vsVisualizerVTK::renderGeometry(OpenSim::Geometry *geometry);

This can be fixed by using:
      vtkSmartPointer<vtkActor> renderGeometry(OpenSim::Geometry *geometry);

Please consider the same practice in future code.
 Gui/Modeling/vsContactForcesNode.cpp:2:10: fatal error: vsOneContactForceNode.h: No such file or directory  #include "vsOneContactForceNode.h"
      ^~~~~~~~~~~~~~~~~~~~~~~~~

This can be fixed by changing two filenames(notice the first letter in "Force"):
  vsOneContactforceNode.h and vsOneContactforceNode.cpp to
  vsOneContactForceNode.h and vsOneContactForceNode.cpp

please fix the above errors.
modify the folders.

remove draft folder
OpenSimWidgets to vsWidgets, Modeling to vsModeling and Visualizer to vsVisualizer

Then merge with the master branch and close this issue.

errors fixed at commit https://github.com/VisSimKoblenz/opensimQt/commit/ffbd6ac4692427ea9f2a11343bbd01147f2dd706


Fix SPI3 protocol with SSD1306

SPI3 protocol with SSD1306 work now  ( test done)

Do you know what this fixed? It appears to just unroll calls to spi_transfer and spi_transfer_8 to send one byte at a time but why would that have been expected to fix a problem? Someone else would be expect to look at that and optimize that change away. Were those functions broken, or is it a timing issue, or is it just unknown in which case wouldn't it have been better to leave the original code but disabled with the working substitutes and a code comment. And where is the code review before merging?

SPI3 SSD1306 protocol problem is that you need send 1 control bit for each byte. This bit replace D/C pin.  Before this change, transfert was this :
1bit + 8 bits + 8bits + 8bits + ....
The command bit is send with the full buffer.
That was totally wrong. SSD1306 didnt work at all in this config.
To send this bit every time, i need transfert 1 byte in SPI buffer.
Now it is:
1bit + 8 bits + 1bit + 8bits + ....
Sorry for miss some comment on it. A friend do some test with me. Before, the screen didn't work at all. Now it is ok.  SH1106 got the same problem but no misstake for this one.


How to hide Regions?

I want to hide the Regions and keep only the Pages. What's the best way to do this? Thank you

I really need some help

Hi!
I released version 3.0.3 where you can hide Page and/or Region from the navigation by setting either page_resource or region_resource to false in the nova-page-manager config file.
Good luck!


tests(e2e): disable upgrade test

Description:
The upgrade e2e test is currently failing consistently in CI but not
locally for me.  This is causing CI to run longer than
necessary while we don't have a fix. Issue #2675 is tracking this.

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [X]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2685 (c7aa352) into main (67d6e85) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
+ Coverage   63.99%   64.06%   +0.07%
==========================================
  Files         151      151
  Lines        6746     6746
==========================================
+ Hits         4317     4322       +5
+ Misses       2414     2409       -5
  Partials       15       15

Flag
Coverage Δ

unittests
64.06% <ø> (+0.07%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configurator/validating_webhook.go
80.00% <0.00%> (+3.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d6e85...c7aa352. Read the comment docs.


Integration Guide for AWS

Over at @denoland, we want to start using Meili to power the search results for the module registry at https://deno.land/x . The backend is mostly built on AWS, and we would like to keep using AWS to host a Meili server.
My first thought was to use the official Meili Docker image and use aws Fargate with an EFS mount, though we also thought about provisioning an EC2 instance with an EBS volume.
Do you have any material or suggestions on the most efficient and cost effective way to run Meilisearch on AWS?
CC: @lucacasonato

Hey @wperron
That is great news! Meili server works like a database meaning that it needs persistent storage. Either solutions would work fine, just keep in mind that it might need as much RAM as persistent storage so I would suggest using the cheapest solution when it comes to memory. You can read more about storage here: https://docs.meilisearch.com/resources/about_storage.html#about-storage
We also have a tutorial to setup MeiliSearch behind NGINX if you go with the EC2 + EBS solution : https://docs.meilisearch.com/running-production/
let me know if you have any other questions, would be glad to guide you through your journey with MeiliSearch!

Hi @tpayet thanks for the response! thanks for the link about the storage and memory considerations, this is very useful information indeed.
I guess what I'm also curious about is how well does Meili handle multi-instance setup? are there any precautions or special settings we need to be aware of? or is the suggestion to simply stick to a single instance setup?

You cannot have multiple instances of MeiliSearch running on the same state aka the data.ms folder where all MeiliSearch data are stored.
However you are free to have multiple completely separate instances of MeiliSearch running under the same load balancer as long as you can ensure that all instances have the same state if you really want to have redundancy. You'll be glad to know that we are working on high availability feature with MeiliSearch that will allow you to run clusters of MeiliSearch

For more info, my current proposal uses an Application Load Balancer to front ECS tasks. The task definition mounts /data.ms to an EFS volume (essentially an NFS mount). Will that be problematic with more than one instance?

As long as you are able to ensure every instances of MeiliSearch have the same state, there won't be any problem!

@tpayet do you have an ETA for the HA clustered mode?

Hey! sorry for the delay, I did not have my computer last week. We do not have a specific ETA, but I would say that we will have HA in the 2-3 months.

Just for information: we're likely going to go with a simple EC2 deployment instead of Fargate (https://github.com/denoland/deno_registry2/pull/146) that's loosely based on the Digital Ocean scripts you already have.
I used Packer to build a custom AMI; it would be nice to have an official public AMI available, I think it would make it easier for people to adopt meili 🙂


Toon does not see the HA-Bridge

I've been trying to link HA-Bridge for a couple of days to Toon Thermostat.. I'm not lucky..
Toon comes everytime with "Can't find any Hue Bridge on you're network"
Hue apps see the HA-Bridge that is working well:

But Toon dont see it.
I scan today my local network, could not find HA-Bridge in my network.
Official Hue Bridge can be linked to Toon.
Whats wrong?

Based on what I can find on the Hue Integration, it is using the cloud api for the HUE. The ha-bridge is not based on that api as it is philips own cloud. So, this will not work in this fashion.

@bwssytems I got 1 Toon working the way @mAiden88 is trying to explain, also got 1 Toon who isn't working. Guess that the issue is somewhere in the Toon rather then in the HA-bridge.
Is it possible to gain access to the archived versions of HA-bridge? I got 4.5.5 running while 4.5.6 is the latest version.

All versions can be found here:
https://github.com/bwssytems/ha-bridge/releases
Try also 4.5.5 version, with no luck :(


chore: Refactor statistics file handling and improve logging

Pull Request
Description
This change introduces a constant DEFAULT_FILE_LOCATION in the statistics.py file to store the path for the repository statistics JSON file. The create_statistics() function now uses this constant when saving the statistics, improving code maintainability.
Additionally, a log message has been added to confirm when the statistics file has been saved successfully.
In the run.sh script, an echo statement has been included to provide feedback when the statistics file is copied to the GitHub workspace directory during CI execution.
These modifications enhance code readability, maintainability, and provide better logging for the statistics generation and file handling processes.
fixes #122

#121  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 5, 7:00 AM EDT: @JackPlowman merged this pull request with Graphite.


cli fails on custom (polymer) project with yarn

Fails on initializing story book (yarn issue)
I'm working on a "freestyle" project, using polymer as core library. The project WAS NOT created with the polymer-cli and the folder structure is unrelated to polymer's standard.
I have run getstorybook command and it failed to install npm dependencies, and failed to output it's own error.
on file @storkybook\cli\lib\latest_version.js I have changed the packageManager to 'npm' and it seems to work.
yarn version v1.6.0
npm version 5.6.0
node version 9.11.1

When using 'autodetect' (with yarn) this is the error message (when I have printed manually the stderr as it fails to parse as JSON).
 • Detecting project type. ✓
 • Adding storybook support to your "Polymer" app

npm update check failed
Try running with sudo or get access
to the local update config store via
sudo chown -R $USER:$(id -gn $USER) C:\Users\aeyal\.config

Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/polymer 3.4.4

Affected platforms
Windows 10

Could you try with the 4.0.0 alpha? I know there have been a couple of fixes and changes. This may have been resolved already.

Confirming that this is most likely the same as https://github.com/storybooks/storybook/issues/3529#issuecomment-388006708. As stated above,  v4.0.0-alpha.6 will fix this. Please note, @eavichay, that this most likely indicates an issue with your npm environment (and has nothing to do with yarn, for more information see the whole linked issue). You might want to try fix it (just google it and there are plenty of helpful links), as the fix on our side is to just ignore the warning.

@Keraito thanks.


Edit Delay Start property for Services

Is your feature request related to a problem? Please describe.
Delay Start is grayed when editing Service Properties.

Delay Start is grayed when editing Service Properties.

It's only usable when Autostart is selected. I fixed the issue with it remaining enabled 👍

Delay Start is grayed when editing Service Properties.

It's only usable when Autostart is selected. I fixed the issue with it remaining enabled 👍


how to correct transcriptome PacBio reads better?

Hi thackl,
I want to correct my transcriptome PacBio reads with transcriptome Illumina reads (pair end,150bp). I know I should set --no-sampling. My data is large. I want to reduces runtime and I am not sure about two qustions.
1 I haven't use  BBMAP before,I learn that normalize short reads using bbnorm.sh of BBMAP can reduces runtime usually by several fold. Does this step ok with transcriptome data? Will it change the distribution of coverage of each transcript? If it can works, which will be better, (1)run FLASh to merge pair end reads ,and treat merged reads as single end reads to run bbnorm.sh.(2)run bbnorm.sh first ,and then merge the normalized pair end mates?
2 You said that "Chunks should not exceed 1X coverage of the genome"."The reason is that you don't want to have multiple pacbio reads from the same location in one chunk, or else they do compete for short read alignments". So, for transcriptome data ,should beless than 1X transcriptome or genome? I want set chunks as large as possible, transcriptome is much smaller, but seems more reasonable.
Thank you!

Normalization works particularly well with transcriptomic data. It reduces redundancy of reads from highly abundant transcripts (which is the largest fraction of your illumina reads), while retaining retaining reads of low abundant transcripts. To be on the safe side, I would be conservative on the cutoff for bbnorm.sh, i.e. set it to something like 200X. And I would go merging first (and since you are using the bbmap package I'd use bbmerge.sh over FLASh).
OK, so the competition effect is kind of worse for transcriptomes, because highly abundant transcripts will also be highly abundant in the PacBio data. So even in smaller chunks, there is a good chance for redundancy. The effect of competition is incontiguity (lower N50) and lower output (percentage masked/corrected). Frankly, the best way to analyze this is trying. For example, make 10 x 20MB chunks and one 200MB chunk of the same read set. Correct both sets and compare the stats and the runtimes...

SeqChunker -s 20M -l 10 -o pb-20M-%03d.fq iso-reads.fq   # 10 x 20MB chunks from file start
SeqChunker -s 200M -l 1 -o pb-200M-%03d.fq iso-reads.fq  # 1 x 200MB chunk from file start

Hope that helps!

It's helpful, I‘ll try.
You are so kind~~thank you very much!!

I correct my transcriptome data without split it into chunks, The result seems OK.
[Mon Mar 13 22:25:41 2017] Running mode: mr
[Mon Mar 13 22:27:23 2017] Running task bwa-mr-1
[Tue Mar 14 14:07:49 2017] Masked : 67.6%
[Tue Mar 14 14:07:49 2017] Running task bwa-mr-2
[Wed Mar 15 11:02:29 2017] Masked : 79.3%
[Wed Mar 15 11:02:30 2017] Running task bwa-mr-3
[Thu Mar 16 08:48:17 2017] Masked : 84.7%
[Thu Mar 16 08:48:17 2017] Running task bwa-mr-4
[Fri Mar 17 04:45:21 2017] Masked : 88.8%
[Fri Mar 17 04:45:21 2017] Running task bwa-mr-5
[Sat Mar 18 02:28:54 2017] Masked : 90.9%
[Sat Mar 18 02:29:05 2017] Running task bwa-mr-finish
[Sat Mar 18 10:18:31 2017] Masked : 78.7%


SQLAlchemy 2 support

Is there any plans or roadmap for supporting SQLAlchemy 2?

Hi and thanks for creating this issue. Yes, I'm currently working on this.

Hi, @cktang88. You can check release 4.0.3 it generates projects with SQLAlchemy2.0.


build.mk: Add CPPFLAGS_EXTERNAL

Add CPPFLAGS_EXTERNAL to CPPFLAGS, just like with CFLAGS_EXTERNAL and CFLAGS
in order to be able to pass additional flags required for distribution
building.
Signed-off-by: Johannes Thumshirn<EMAIL_ADDRESS>

Patch incorporated and pushed.


Can't tap on widget previously found by scrollTo()

Code can be found here: https://github.com/jBorkowska/flutter-wonderous-app/blob/patrol-bug/integration_test/test_test.dart#L25
In this line, we scroll to a widget and then try to tap on it. Scrolling works fine, but tap throws an error:

Possible reason: there are 2 widgets with the same key in the widget tree at this moment in test: a container in https://github.com/jBorkowska/flutter-wonderous-app/blob/patrol-bug/lib/ui/screens/home/wonders_home_screen.dart#L293 and a stack in https://github.com/jBorkowska/flutter-wonderous-app/blob/patrol-bug/lib/ui/wonder_illustrations/common/animated_clouds.dart#L100. The container is found by scrollTo, but in error message from tap only the stack is mentioned (as offscreen). Also stack is higher in the widget tree than container, which means it's analyzed before container when resolving the finder. That potentially means, that scrollTo analyzed stack, but ignored it as offstage, but tap took first one from the tree and then checked hitTestable(), which returned false, resulting in exception from screenshot above.
Fix (to be reviewed by @bartekpacia ):
tldr: scrollTo() has to pass original finder or finder.hitTestable().first.
scrollTo() returns finder.first instead of original finder. So in this case it returned the stack widget, which is not hittestable. This was passed to tap() method and that is why the error message printed only this stack widget (tap() called hitTestable() on finder passed from scrollTo(), that's why it threw an error).
Another issue found in the process: https://github.com/leancodepl/patrol/issues/1048.

I can reproduce this.
Passes
void main() {
  patrolTest('can tap() on widget scrolled to by scrollTo()', ($) async {
    await $.pumpWidgetAndSettle(
      MaterialApp(
        home: Scaffold(
          body: ListView(
            children: [
              Stack(
                children: [
                  const Center(child: Text('Text')),
                  Center(
                    child: Container(
                      width: 100,
                      height: 100,
                      color: Colors.blue,
                    ),
                  ),
                ],
              ),
              const Text('Text'),
            ],
          ),
        ),
      ),
    );

    await $('Text').scrollTo();
    await $('Text').tap();
  });
}

Fails
void main() {
  patrolTest('can tap() on widget scrolled to by scrollTo()', ($) async {
    await $.pumpWidgetAndSettle(
      MaterialApp(
        home: Scaffold(
          body: ListView(
            children: [
              Stack(
                children: [
                  const Center(child: Text('Text')),
                  Center(
                    child: Container(
                      width: 100,
                      height: 100,
                      color: Colors.blue,
                    ),
                  ),
                ],
              ),
              const Text('Text'),
            ],
          ),
        ),
      ),
    );

    await $('Text').scrollTo().tap();
  });
}


Fix #198 batch update parameter type

See https://github.com/gtalarico/pyairtable/issues/198

Thanks for PR but as discussed in other PR "records" will be represented as list of dicts.


cargo-install: build directory should be in $TEMPDIR

and each instance of cargo-install should have its own build directory.
Right now cargo-install uses a target-install directory in $PWD. So you run into issues like these:
You don't have permission to write to $PWD:
$ cd /
$ cargo install cargo-graph
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading cargo-graph v0.2.2
error: failed to compile `cargo-graph v0.2.2`, intermediate artifacts can be found at `/target-install`

Caused by:
  failed to open: /target-install/release/.cargo-lock

To learn more, run the command again with --verbose.

Calling cargo install multiple times from the same directory will build each crate sequentially instead of in parallel (because the build directory gets locked -- without the lock things would be worse, so removing the lock is not a solution)
$ cargo install cargo-graph & cargo install cargo-count
[1] 28438
    Updating registry `https://github.com/rust-lang/crates.io-index`
    Blocking waiting for file lock on the registry index
    Updating registry `https://github.com/rust-lang/crates.io-index`
    Blocking waiting for file lock on the registry index
    Blocking waiting for file lock on crate metadata
    Blocking waiting for file lock on build directory
   Compiling rustc-serialize v0.3.19
(...)

If the build directory was $(mktemp -d) then you wouldn't have problem calling cargo install from a directory you don't permission to write to, and you could spawn several cargo install (from the same directory) that actually run in parallel.
Thoughts?

The problem with tempdirs is that if you ctrl-c they end up lying around and they're hard to find to remove. I wonder though if Cargo could just try a few locations? For example if $PWD isn't workable because it's not writable, it could switch to a deterministic directory in /tmp. Otherwise if it fails it could switch to cargo-install2 or something like that.
Although I guess it's just amounting to a tempdir that's slightly more readable...
Meh, I guess just using a tempdir seems fine to me!


Update README.md

i have just implemented some user-friendly changes grammatically.

This one was part of the default docusaurous thing. I would recommend you add this there only. We will reinitialize the project to make this work.


fix(ios, permission): status key should be authorizationStatus

This has three separate commits, each doing separate things with descriptive messages and conventional-commits-compliant titles
But the main one is that it Fixes #333 so I'm setting the PR title as that :-)
Basically it's setting the new app-wide notifications authorizationStatus key to the name we documented in the actual docs and in typescript, vs authorizedStatus which was not correct

@mikehardy LGTM


fix(NewRelicContextFormatter): add cause and context to stack traces

Overview
NewRelicContextFormatter logs stack traces without causes which makes many errors hard to debug.
Let's take a look at the following code:
try:
    try:
        raise ValueError("First exception")
    except:
        raise ValueError("Second exception")
except Exception as e:
    logging.error("Encountered error", exc_info=e)

Before the PR, the exception message looked as follows:
  File ".../newrelic_exception_cause.py", line 60, in <module>
    raise ValueError("Second exception")

After the PR, it shows more details on the first cause:
Traceback (most recent call last):
  File ".../newrelic_exception_cause.py", line 58, in <module>
    raise ValueError("First exception")
ValueError: First exception
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File ".../newrelic_exception_cause.py", line 60, in <module>
    raise ValueError("Second exception")
ValueError: Second exception

Related Github Issue
No Github issue created.
Testing
Tests were updated to test a particular case where exception has a cause.

We'll give this a review after the US holiday season is over, we're going to avoid the risk of changing anyone's logs during this time period.


KAFKA-15370: Support Participation in 2PC (KIP-939) (1/N)

This is just a mechanical change to make prepareTransitionTo method use named parameters instead of positional parameters.

Thanks for the PR, makes things much more clear and readable!


Set node version to 18.x in Github workflows

This PR sets the node version in our github workflow actions to at least version 18. Reason to do this is that Github actions use Node v16 by default, but because we are using Yarn v4, we want to ensure yarn installs are running in an environment using at minimum Node v18.

Check out a preview of your pull request here: https://app-servicecanadalabs-dev-pr-preview-3.azurewebsites.net


Add launcher key in slurm object in buildtest configuration

update default.yml
Add slurm-example.yml as reference configuration for sites that using
Slurm
Add executor key in script schema, this refers to name of executor in
configuration to used when dispatching job. This is a required key
Update an example script (examples/script/slurm.yml) to use executor key
Removed the try/except clause in buildtest configuration check, this was
done because validate method prints useful output for troubleshooting
schema, the error message we print to screen was not showing anything
useful.

@vsoch i have not made any changes to the executor class, this PR is focusing on getting the schema ready on the configuration and script schema so that buildtest can understand how to dispatch the job. The slurm dispatch by default can be sbatch but it could be others if needed hence launcher was introduced. The executor key in script is needed to specify which launcher to use. Hope that makes sense. Right now a test can pick only one executor.

All checks are green :)

I'm testing locally, and this config:
editor: vi
executors:
  local:
    type: local
    description: submit jobs locally
  normal:
    type: slurm
    description: submit jobs with slurm using srun instead of sbatch
    launcher: sbatch
    extraOption: this-is-invalid
    options:
      - "-p normal"
      - "-t 00:10"
      - "-N 1"
      - "-n 1"

should be invalid, but it's not.

Also why did you copy the slurm-example.yml into the testing folder, if it's already provided as an example in the executors directory? I'm totally confused...

Let me add #251 to this PR that should be relatively simple and related to this.

Also why did you copy the slurm-example.yml into the testing folder, if it's already provided as an example in the executors directory? I'm totally confused...

The file buildtest/settings/slurm-example.yml was added, it meant as starting point and used for documentation purposes as well. For file tests/config_example_schemas/slurm-example.yml I just updated the content so that it matches new fields such as options, launcher and check that the test passes. Quickest way was to copy all content from one provided in buildtest/settigms/slurm-example.yml. The slurm configuration used for regtest can diverge in future as serves the purpose of  validating slurm configuration. Hope that makes sense.

I'm actually doing the default now, so please hold off on adding more to this PR.

Also we should store some invalid test configuration that should fails check from jsonschema.validate some of which we are discussing already. That can also be stored in config_example_schemas repo.

Great idea! Since it's getting confusing, let's have an "invalid" and "valid" folder to go from, e.g.,
config_test_examples/
   invalid/
   valid/
      local-example.yml
      slurm-example.yml

Looking in the file for test_config.py, it's not clear to me why the two tests (for the files mentioned above) are structured differently? One checks for validation error, and the other just runs the validate function. Could we be consistent here?

ook that's fine, thx 4 heads up

Also we should store some invalid test configuration that should fails check from jsonschema.validate some of which we are discussing already. That can also be stored in config_example_schemas repo.

Great idea! Since it's getting confusing, let's have an "invalid" and "valid" folder to go from, e.g.,
config_test_examples/
   invalid/
   valid/
      local-example.yml
      slurm-example.yml

Looking in the file for test_config.py, it's not clear to me why the two tests (for the files mentioned above) are structured differently? One checks for validation error, and the other just runs the validate function. Could we be consistent here?

Yea i see what you mean yea the one that runs validate is useful as pose to running a try block in test_config_slurm example. What i found is that validate prints useful information for debugging but wrapping in try block makes it useless. That was the same issue with configuration check (#246)
I am +1 for having invalid and valid folder for storing configs.
I can see that testing different configuration templates may not increase coverage report if all we are doing is running validate . It's just a binary pass/fail. Unless we have other checks after jsonschema pass validation, but addition checks in buildtest to see validation of configuration file. Right now we are not doing anything fancy in the check_configuration stage.

@vsoch i have addressed both issues discussed in this PR in #253 #254
If there is anything else missed, let's open an issue and come to resolution on this PR.


refactor: rename catalog field from config to basedir

Fixes #819
Relates to #816
What does this PR do?
Small refactoring prior to #816
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#818
How to test this PR?
Start a recipe

Please also update the PACKAGING_GUIDE.md file

Please also update the PACKAGING_GUIDE.md file

Good catch. Thanks


Simplify generator

Could the visitor pattern be used to improve the project structure?

#623 simplified the generator.


Hello it's me again!

Which addon?

MPD
Describe the bug

No default conf:
Back button im ympd didnt work
ympd config: url didnt save, always back to <IP_ADDRESS> (just for testing)
conection lost after skip to next title/stop in ympd/brwser/hass mp addon/ single ympd addon
lags in lovelace ui ### edit: just in homeassistant android app ###

I am runnig homeassistant on an raspi3
My MPD config:
@App:
shared mpd.conf / Network 6600, null / Audio default, default
@mpd.conf:
music_directory "/share/mpd/music"
playlist_directory "/share/mpd/playlists"
db_file "/data/database/mpd.db"
log_file		"syslog"
pid_file		"/share/mpd/mpd.pid"
state_file "/data/state"
sticker_file "/data/sticker.sql"
#user		"mpd"
#group				"audio"
#bind_to_address		"any"      <----- didn't work 4 me
port				"6600"
log_level			"verbose"
#restore_paused "no"
#save_absolute_paths_in_playlists	"no"
metadata_to_use	"artist,album,title,track,name,genre,date,composer,performer,disc"
#default_permissions             "add"      <----- didn't work 4 me
input {
plugin "curl"
#proxy "proxy.isp.com:8080"
#proxy_user "user"
#proxy_password "password"
}
#audio_output {
#type		"alsa"
#name		"RaspiAudio"
#device		"hw:0,0"	# optional      <----- didn't work 4 me / just getted alsa worked with type&name even with group audio
#mixer_type      "hardware"	# optional      <-----
#mixer_device	"default"	# optional      <-----
#mixer_control	"PCM"		# optional      <-----
#mixer_index	"0"		# optional      <-----
#}
audio_output {
type		"fifo"
name		"mpd"
path        "/share/snapfifo/mpd"
format		"44100:24:2"
mixer_type  "null"
}
filesystem_charset		"UTF-8"
error without /share/mpd/mpd.conf in config:
@mpd log:
INFO: Start MPD exception: Failed to open '': No such file or directory [17:07:12] INFO: Start ympd MPD Connecting to <IP_ADDRESS>:6600 MPD connection: Connection refused
default error message, but working:
@mpd log:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0. [s6-init] ensuring user provided files have correct perms...exited 0. [fix-attrs.d] applying ownership & permissions fixes... [fix-attrs.d] done. [cont-init.d] executing container initialization scripts... [cont-init.d] done. [services.d] starting services [services.d] done. [17:39:02] INFO: Setup folders and settings [17:39:02] INFO: Start MPD exception: bind to '<IP_ADDRESS>:6600' failed (continuing anyway, because binding to '[::]:6600' succeeded): Failed to bind socket: Address in use path: SetFSCharset: fs charset is: libsamplerate: libsamplerate converter 'Fastest Sinc Interpolator' vorbis: Xiph.Org libVorbis 1.3.6 opus: libopus 1.3.1 hybrid_dsd: The Hybrid DSD decoder is disabled because it was not explicitly enabled simple_db: reading DB curl: version 7.67.0 curl: with OpenSSL/1.1.1g state_file: Loading state file /data/state exception: RTIOThread could not get realtime scheduling, continuing anyway: sched_setscheduler failed: Operation not permitted playlist: queue song 1:"http://br-edge-2006.fra-lg.cdn.addradio.net/br/br3/live/mp3/128/stream.mp3"
Errors after skip/stop: connecton lost:
also on invalid or non working settings in mpd.conf
@homeassistant log:
Protokolldetails ( ERROR )
Logger: homeassistant.components.websocket_api.http.connection.1836323280
Source: components/mpd/media_player.py:322
Integration: Home Assistant WebSocket API (documentation, issues)
Connection lost while reading lineTraceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 130, in handle_call_service connection.context(msg), File "/usr/src/homeassistant/homeassistant/core.py", line 1253, in async_call task.result() File "/usr/src/homeassistant/homeassistant/core.py", line 1288, in _execute_service await handler.func(service_call) File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 213, in handle_service self._platforms.values(), func, call, required_features File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 453, in entity_service_call future.result() # pop exception if have File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 597, in async_request_call await coro File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 484, in _handle_entity_call await result File "/usr/src/homeassistant/homeassistant/components/media_player/init.py", line 586, in async_media_next_track await self.hass.async_add_job(self.media_next_track) File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run result = self.fn(*self.args, **self.kwargs) File "/usr/src/homeassistant/homeassistant/components/mpd/media_player.py", line 322, in media_next_track self._client.next() File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 381, in mpd_command return wrapper(self, name, args, callback) File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 473, in _execute return retval() File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 368, in command_callback res = function(self, self._read_lines()) File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 311, in _parse_nothing for line in lines: File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 538, in _read_lines line = self._read_line() File "/usr/local/lib/python3.7/site-packages/mpd/base.py", line 523, in _read_line raise ConnectionError("Connection lost while reading line") mpd.base.ConnectionError: Connection lost while reading line
@mpd log:
$next:  client: [0] command returned 0 client: [1] process command "next" playlist: play 1:"http://br-edge-2006.fra-lg.cdn.addradio.net/br/br3/live/mp3/128/stream.mp3" MPD mpd_run_status: Connection reset by peer MPD outputs: Connection reset by peer MPD connection failed.
$stop:  client: [1] process command "outputs" client: [1] command returned 0 client: [0] process command "stop" playlist: stop MPD mpd_run_status: Connection reset by peer MPD outputs: Connection reset by peer MPD connection failed.
To Reproduce

Expected behavior

Screenshots

System

Supervisor version:
Host system version:

arch
armv7l

chassis
embedded

dev
false

docker
true

hassio
true

host_os
HassOS 3.13

installation_type
Home Assistant

os_name
Linux

os_version
4.19.114-v7

python_version
3.7.7

supervisor
222

timezone
Europe/Berlin

version
0.110.1

virtualenv
false

All errors gone with Homeassistant Update to 0.110.2 except
default config file.
Thanks a lot!

The addon will not generate a default configuration. You can use the mpd.conf from the repository to start with.

Just now I realized what you meant by default config file. :sweat_smile:
will be fixed in a second.

Fixed with c5d8086


Use event watches to wait for provision complete

Instead of polling every 10 seconds checking if the provision completed
use event watches to be notified of state changes on the service
instance.

cc @mkanoor @gtanzillo

👍


Modify Gemfile for MS Windows

This change modifies the Gemfile so that it skips therubyracer, and requires win32-process, on MS Windows.
I also put a comment in there for how to get libv8 installed on Windows. Since it's a build option, I cannot put it in the Gemfile directly. Eventually that should be added to the developer's guide. Note that due to a screwball install script, the libv8 gem will spawn some notepad instances that contain ruby code text. These are harmless as far as I can tell, and can be closed.
With this modification I am able to complete a bundle install using Ruby 2.1 on Windows 7. While bundle exec rake evm:db:reset doesn't quite work yet (due to a pg gem issue), adding win32-process to the Gemfile is a necessary first step.

I think the win32-process change should be in lib/Gemfile...since I assume that gem modifies the Process class?

Yes, it does modify the Process class.

I'm good with this change if you move it into lib/Gemfile @djberg96.  While we're not always consistent, we usually put it in vmdb/Gemfile if only rails code uses it.  lib/Gemfile are gems we use outside of rails code.
You can argue that ruby-progressbar, logging, elif, and others belong in lib but I think we don't move them until we actually need them outside of the rails app.

@djberg96 Can you also try cd'ing into lib and bundle installing from there?  Both places should be bundle-able indepedently.

Alright, I've moved it. I tried running bundle install under lib, but I've hit an issue with qpid_messaging. Still, this should still be a step towards cross-platform support.

Ah yeah, qpid doesn't install anywhere but on Linux it seems.  Try bundle install --without qpid

Thanks, I'll try that. There is a precompiled qpid for Windows but it's not free:
http://www.riverace.com/qpid/downloads.htm

bundle install --without qpid worked.

LGTM, :+1:

@djberg96 We went through a bit of effort recently to remove Windows support as a developer environment.  It was mostly removed because we don't want to support developers on Windows, and extra unsused code is not worth the maintenance overhead.  There have never been plans to run with Windows as an appliance guest, so although I merged this one, I'm curious if we should be going in this direction.
On the other hand, I personally would really love if we could run on JRuby, and I think a lot of your efforts will be similar (like removing io-extra).
See https://github.com/ManageIQ/manageiq/pull/1401.  You can see where we removed things.  Some things may have to be put back if we continue down this route, however, I would prefer if there were better, platform agnostic, ways to do things in many those cases.
cc @blomquisg @jrafanie

Ah, I wasn't aware that you had explicitly removed Windows support in the past. Still, these efforts are worthwhile for getting JRuby support as you mentioned.
I'll take a look at #1401 and to see what it's doing, and if we can make it more platform neutral in general.
Anyway, thanks for merging this.


After playing video timing not showing properly

Hello @Avdhesh-Varshney please assign this issue to me under gssoc 24

@kapilG0 already issue is present #24


Incomplete preset translations are a Really Bad Thing™

Okay, incomplete core translations look unprofessional, but they can be used.
On the other hand, preset translations where the labels have not all been translated, result in a very frustrating editing experience, potentially scaring away new mappers.
Consider this scenario:
You use iD in Norwegian (no) and search for a swimming pool by typing the Norwegian word svømmebasseng. You find what you want to map.
But if you want to map a vending machine, and search for salgsautomat, you don't find anything.
You decide to try the English term vending machine and find what you are looking for, because iD obviously falls back to English if no translation is present yet.
Now you may have realised that the translation is not complete[note 1], and that you will not find everything in Norwegian. Then you want to map a town hall and based on this experience you decide to search for the English term right away. However, you won't find the preset, because the label has already been translated (Rådhus).
It was upon realizing this that I completed iD's translation to Dutch[note 2]. Unfortunately, I am not sufficiently fluent in Bosnian, Chinese (Yue), Korean, Chinese (Hong Kong), Arabic, Greek, Persian, Turkish, Serbian, etc to translate to those languages as well, and I don't know if and when they will be completely translated.

Notes

Not everyone may realise this. It would be useful to display some warning somewhere if not all labels are translated.
The attentive reader may note that Dutch has a translation completeness of 86% on Transifex. This is because of the terms lists, which were deliberately left blank if I could not think of synonyms and related terms.

I agree that they are a Really Bad Thing.  Is there anything actionable we can do about it?  Maybe to improve Rådhus we could also include the English tag value 'town_hall' in the terms list?
I did send an update on Transifex to the translators today to let them know we are releasing soon.  We need to do a better job keeping them engaged, I'm not sure best way to do it.

Well, it's a lot of work if you're alone. If you're not, you have to make some agreements on how you will translate or you will end up with am incoherent translation. This is basically out of your control of course. The glossary function on Transifex can be a huge help.
Firstly I'd not include translations with too low a completion rate (say 62%). You'd need to know English anyway if you wanted to use them.
Secondly, I'd just include all English terms and labels as well in searches, be it with a somewhat lower priority rate. (Is that feasible?)

And thirdly display a warning when you start searching for presets if not all labels have been translated. Something like: 'Not all features have been translated into your language. Also try the English term if you don't what you're looking for.' And maybe also something along the lines of 'If you'd like to help translate iD into {Language}, check out the project on <a ...>Transifex.'

Maybe to improve Rådhus we could also include the English tag value 'town_hall' in the terms list?

It may be a good idea, especially for incomplete presets.

So I spent some time digging into this tonight and.. iD already does include OSM tag values in the preset search. (As a test, I forced the language into Chinese, and I was able to use iD easily by typing OSM tags into the search box, despite not being able to read the language at all.)
Instead of changing the search code, maybe this instead:  I could add a small "help translate" icon down by the "report a bug" icon.  This could push a lot of users to the Transifex project that otherwise wouldn't know about it.
Crappy mockup:

I could add a small "help translate" icon down by the "report a bug" icon.

This would be a good idea, probably linking to the https://github.com/openstreetmap/iD/blob/master/CONTRIBUTING.md#translating page.
Would it be shown for all languages, all languages except en (en_US), or only languages with incomplete translations?
The latter two would show it for en_GB, since en_GB falls back to en_US for much of its text.

I think I'll just show it for everyone. There are probably users browsing in en or en-US that would help translate if they knew how to.

Also, please turn down requests on Transifex for country-specific translations like "Danish (Denmark)" -- these are almost always confused users who actually wanted to help with an existing translation like "Danish". Here's the message I send to the user after denying such requests:

Hi ___,

You requested a ____ (____) translation for iD. Unless there is a specific reason you require a country-specific translation, please join the team on the existing ____ translation: <link>.

Thanks for your help!

John

FWIW, I received this response from a language requestor today:

Sorry for the confusion, as I'm new to Transifex. I had no idea my language choices were for the iD translations. These are the languages I am fluent in (and their respective locale) and that I could contribute to. I thought I was filling out my profile.

I believe this, because I also find Transifex's UI pretty confusing.


fill in missing attributes with None

Addresses https://github.com/KennethWilke/PingdomLib/issues/15, when a check is initially loaded (using getChecks) if there are missing attributes in the response from Pingdom, the attribute will be added with a None value:
In [4]: for check in checks:
   ...:     print check.lasterrortime
   ...:
1420826328
1421081819
None
1421081761
1420862042
1421081811
None
1421081814
None
1421081826
None
1421081828

This seems same enough, I have not tested it yet but looking over the code it addresses the problem of accessing attributes on a check object where Pingdom has not explicitly set the value on the check object in the __addDetails__ function.
Nice catch on that case.

Aaron, thanks for fixing this. Could you add contactids to https://github.com/aaronfay/PingdomLib/blob/d1516f5d02f4c7bd877db70cce8241dd2c0aa429/pingdomlib/check.py#L44 ?

@gwillem contactids is in the list now.

Thanks!

AH! It's been a busy couple weeks, sorry I didn't see this one before. Look's great though, merging it in


rgw: refact rgw pools creation

Refact of 8704144e3157aa253fb7563fe701d9d434bf2f3e
There is no need to have duplicated tasks for this. The rgw pools
creation should be delegated on a monitor node se we don't have to care
if the admin keyring is present on rgw node.
By the way, only one task is needed to create the pools, we just need to
use the docker_exec_cmd fact already defined in ceph-defaults to
achieve it.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1550281
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>(cherry picked from commit 2cf06b515f3e173aa3720cf28e4149149d881941)
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>backport of #2684 in stable-3.0

jenkins test luminous-ansible2.4-docker_cluster

jenkins test luminous-ansible2.4-docker_cluster_collocation

jenkins test luminous-ansible2.4-centos7_cluster

jenkins test luminous-ansible2.4-ooo_collocation


Implement a Eigen-CppAD skeleton

This PR implements some utilities to use CppAD with Eigen In details:

Findcppad.cmake has been designed to find cppad thought pkg_config or cppad_DIR Right now it works only on Linux and MacOS.
AutoDiff/CppAD.h includes and implements some utilities functions to use CppAD with Eigen (e.g. see here

Known issue: There seems that it is not possible to use CppAD inside Eigenvector fixed size see here

This feature is not supported yet by Windows. As soon as https://github.com/microsoft/vcpkg/pull/12560 is merged I think we can start supporting also Windows

@S-Dafarra let me know if I can merge the PR


type raw: parser

raw type must be supported as function parameter

depends on #945

Won't implement it, will use TYPE sys.Raw instead


Token: Listing Detail

The listing detail component needs to be updated with badges and improvements to the buy box as depicted here.

Pushed updates to token-ui branch that completed this


Use GitHub issue forms to capture issue & enhancement reports.

Now that GitHub has introduced issue forms, we can move away from using static markdown templates and migrate to issue forms to capture issue /enhancement reports metrics much more accurately.
References

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

Addressed in v2.0.0


[Enhancement] Support more JSON backends

Describe the issue
tinygltf currently depends on nlohmann JSON or RapidJSON as a JSON backend.
Although both nlohmann JSON and RapidJSON are stable, there are some issues(e.g. multithreading: https://github.com/syoyo/tinygltf/issues/241 ) it'd be better to have more JSON backends for security(immune to malcious glTF JSON),  support various environment(e.g. WASM WASI, embedded platform) and more usecases(faster glTF JSON parsing with multithreading).
There are some candidates for JSON backends:

Write our own JSON parser.
JSON library in C(for portability)
sajson  https://github.com/chadaustin/sajson branch exists(JSON Read only) https://github.com/syoyo/tinygltf/tree/sajson
simdjson https://github.com/simdjson/simdjson

To Reproduce
N/A
Expected behaviour
N/A
Screenshots
N/A

boost::json perhaps?

👀

Could be really wise to have simdjson supported backend. https://github.com/spnda/fastgltf, claims to be faster but lacks some features. Looks like it uses simdjson dom to parse, so there could be further improvemens by using simdjson ondemand parser.

Could be really wise to have simdjson supported backend. https://github.com/spnda/fastgltf, claims to be faster but lacks some features. Looks like it uses simdjson dom to parse, so there could be further improvemens by using simdjson ondemand parser.

Which features does it lack apart from writing glTFs? I think I offer more than tinygltf currently. I would be happy to implement anything you feel left out.
Also, the simdjson DOM parser actually turns out to be faster in my case. I used to use the ondemand parser but it is actually slightly slower. Perhaps this is because I don't use the exception model, but I have not had enough time or resources to properly analyze where the slowdown comes from, apart from the fact that the stage1 processing (which indexes important sections of the file) takes a very long time to run. If I remember correctly, this was in many cases mitigated by using a minimized JSON, but that doesn't come up a lot in real scenarios so I decided to ultimately go with the DOM backend as its generally faster.

Could be really wise to have simdjson supported backend. https://github.com/spnda/fastgltf, claims to be faster but lacks some features. Looks like it uses simdjson dom to parse, so there could be further improvemens by using simdjson ondemand parser.

Which features does it lack apart from writing glTFs and loading images? I think I offer a lot more than tinygltf currently. I would be happy to implement anything you feel left out. There's a PR open for an API for writing glTFs and it's a conscious decision to not load images, as I feel like the user should decide how they want to load the images. fastgltf is specifically designed to do the absolute minimum if you don't ask for it. It's a bit more explicit, but you have much more control over the loading process.
Also, the simdjson DOM parser actually turns out to be faster in my case. I used to use the ondemand parser but it is actually slightly slower. Perhaps this is because I don't use the exception model, but I have not had enough time or resources to properly analyze where the slowdown comes from, apart from the fact that the stage1 processing (which indexes important sections of the file) takes a very long time to run, and is ultimately the deal breaker even though stage2 is extremely quick. If I remember correctly, this was in many cases mitigated by using a minimized JSON, but that doesn't come up a lot in real scenarios so I decided to ultimately go with the DOM backend as it's generally faster.

Sorry for not answering for long time, one major advantage with tinygltf is the ability to work with the gltf data, for example we are using gltf as intermediate format for merging or replacing gltf models/materials in the scene and writing the combined gltf data. Unfortunately fastgltf is lacking not sure about modigying asset data but at least the write gltf part (writing gltf may be trivial but still an effort).

Sorry for not answering for long time, one major advantage with tinygltf is the ability to work with the gltf data, for example we are using gltf as intermediate format for merging or replacing gltf models/materials in the scene and writing the combined gltf data. Unfortunately fastgltf is lacking not sure about modifying asset data but at least the write gltf part (writing gltf may be trivial but still an effort).

Both of those things are possible with fastgltf. 0.7.0 (released in February) added support for exporting glTFs and GLBs. Underneath the code is not as sophisticated, as I just build up the JSON with a normal std::string, but I fuzz the library with over 250 different real-world assets locally and it works with all of them.
I am considering adding functionality to abstract how the data within buffers can be written properly to adhere to the different quirks of glTF accessors, so currently you'll just have to know and respect the rules yourself.

I made a minijson
https://github.com/syoyo/minijson
which is secure(fuzz tested), portable and supports Unicode escape identifier. Could be used as a default JSON parser for TinyGLTF in the next major release


Add a DataSource for the task database

The spring-cloud-dataflow-admin-starter now creates the task database tables on start-up. All SPI implementations should add a DataSource to their configuration to be used for the tasks.

Duplicate of spring-cloud/spring-cloud-dataflow-server-kubernetes#73


Processing of images in lib1

Closes #4
This PR adds the  implementation of the processing of image data to a single video file and saving it onto the disk. Due to the structure it seems to be that a separate save function is not necessary.

Regarding Data Export (Library 1)#5: My ticket seems to be closing this ticket as well, because the structure of the ffmpeg combiner does not need a separated function for saving images.
Please give me some advice with this. I think we have to decide as a team if the processing like this is fine.

Commit f7b64fc isnt signed-off :)


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Name: Mohammed Kabir Hussaini

Discord Username(if exists):lekandev

Additional Context: On GitHub

I want to contribute more to opensource projects develop products that matter

Welcome @lekandev


Investigate location 15,115 with Expensive SkinnedMesh Update

Explorer Alpha build version:
Main
Issue Description:

This is a high priority if we have control over the SkinnedMeshRenderer problems - otherwise it will be a scene issue if there are too many.

Can't reproduce the issue.


update references to renamed binary

Confirmed here as well, we are unable to send coverage when using current master branch (or 2.0.0):
When running composer update:

Skipped installation of bin bin/coveralls for package php-coveralls/php-coveralls: file not found in package

Workaround is to use binary vendor/php-coveralls/php-coveralls/bin/php-coveralls directly...

composer/bin was fine in 2.0, simply master wasnt updated yet.
i changed target branch to 2.0 of this PR

Thank you @abacaphiliac

my pleasure, thanks for the merge. sorry about the incorrect target : )