[Feature]: Improve UI/UX On Finishing Entry of Send Amount

Describe the problem
Currently, after you enter a number of sats to send, there is a small "done" button to go back to the main send screen. This is slightly awkward, and for someone new to bitcoin might be unintuitive. Added to this problem is the fact that if you miss the Done button and try to swipe away from the main screen, it is likely to just lead to closing out the send screen altogether.
Describe the solution
I'm not entirely sure how to solve since I am not a designer. I'm not sure if there is a more intuitive gesture solution. It is possible that moving the Done button to the bottom right, and making it bigger, so more like a standard send/finish button. My keyboard retraction button within Android is on bottom left so maybe look at what typical keyboard/keypad retraction UIs look like in different apps.
Additional context
No response

Does sending funds actually work for you ? My funds are stuck in the app for 2 months. Anyway to send them?

I ended up getting funds back directly from them, at least within LN
channel. Haven't tried latest version of app for weeks.
On Mon, Jan 16, 2023, 7:39 PM imacfan @.***> wrote:

Does sending funds actually work for you ? My funds are stuck in the app
for 2 months. Anyway to send them?
—
Reply to this email directly, view it on GitHub
https://github.com/synonymdev/bitkit/issues/637#issuecomment-1384793517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANGFQNJQL6SF3LVZSLANZVDWSYIABANCNFSM6AAAAAARTHUBOQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Support comma-separated list of nodes

From<EMAIL_ADDRESS>on March 05, 2010 14:06:59
Currently the list of nodes in the configuration is whitespace-separated.
Due to problems in passing such lists to the tomcat in environment-
variables, an alternative format using commas as separators would be
helpful.
Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=44

From martin.grotzke on March 13, 2010 14:45:19
Implemented: memcachedNodes and also failoverNodes can now be specified comma
separated (space separated configuration is still supported)
Status: Fixed
Owner: martin.grotzke
Labels: -Type-Defect Type-Enhancement Milestone-1.2


Asking for permission to use fmlock.

Hi, i develop gopreload:
https://github.com/kokoko3k/gopreload
...it is mainly a bash script, but uses some c code to map files into memory.
My c code does the same as your fmlock tool, but i'm not a c programmer, so i ask you if i can use your code (which is better) instead of mine.
Thanks.

Go ahead.
It's licensed under liberal OSI approved terms, why do you even ask? ;)

Well, i'm not pratical about licenses issues, i just read the following:
"* Neither the name of fmlock nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission."
So i asked.
Thanks!


Taking over

Hey, I'd gladly take over this. I'm using it in a project of mine :smile:

👍 Great, I'll transfer it now!


1st contribution to this module

Hi,
I'm a CDM MVP and would like to contribute to this module :-)
Due to the huge number of changes I made, can you please try my version and tell me what you think?
You don't need to merge my changes but you can if you like my version, of course.
Best Regards,
Emin

@p0w3rsh3ll,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@p0w3rsh3ll, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Thanks for the changes, Emin!  Can always count on our MVPs!


Can you provide a little explanation of how to use this?

How does this compare or relate to Gerald Richter's Perl extension?
I want to debug on my Windows 10 machine, but after installing this extension, and adding a configuration entry to my launch.json, it will pause on the first line of code and then goes away/stops/dies.

Gerald Richter's extension is based on a Perl module he wrote, while this debugger aims to work just by invoking perl -d. So the features aren't as advanced, but it should be way simpler to set up on most environments. Compared to Gerald's extension, it should also work on Windows 10 and 11. I test on both OSs myself while developing.
If you set "trace": true inside your launch.json, the debug adapter will log every single request and response, which should help to find the issue.
If you provide me with a code snippet to recreate the problem, I can start testing on my machine as well.
In the past, there have been some issues with the debugger crashing when debug.inlineValues is set to on inside the VSCode settings. You could try to disable it and see if the issue resolves that way.

@joshcsmith13 I just released a new version of the debugger with enhanced error handling when parsing variables. Please give it a try to see if it fixes your problem.

Sorry @Nihilus118 , it's been a while since I worked on this.  I saw you note about the trace flag and just tried again.
It does indeed stop on entry, and I can actually set a breakpoint (before the program/debugger crashes).
However, as the first few lines that set variables are stepped it says "$=undef" for each line, and nothing shows in the "My" variables debug navigator.

I may or may not have tweaked the following a tad bit (like changing the "program" in launch and moving the editor line into the "[perl]" attribute of the settings).
This is what my project launch.json (for perl) looks like:
{             "type": "perl",             "name": "Perl-Debug",             "request": "launch",             "program": "${file}",             "stopOnEntry": true,             "debug": true,             "trace": true         }
This is what appears to be the relevant sections of global settings.json:
   "[perl]": {         "editor.defaultFormatter": "nihilus118.perl-debugger",     },     "perl.perlInc": [         "C:\\berrybrew\\instance\\5.38.0_64\\perl\\bin"     ],     "perl.showLocalVars": true,     "perl.pathMap": null
It is confusing why the python files are being listed in the debug console.
launch.json
settings.json
perl-debug-trace.txt
I can't tell you how useful this would be, to be able to run this on my laptop when testing, instead of remoting into a production server.
Thanks,
Josh

Hi @joshcsmith13, your settings.json suggests that you have installed this Perl Extension at the same time. It seems to interfere with mine, as both register a debugger for Perl. I recommend disabling it and trying to debug again.
If this fixes your problem and you want additional LSP capabilities for Perl, I highly recommend this LSP, which works out of the box as well.

Thanks again for the response.  I installed the extension, along with Perl Navigator, into a separate [older (Version: 1.85.2)] instance of VS Code that I have for Remote Debugging and stripped the code down to something very simplistic.  I still get the "$variable = undef" indicators, but for some reason the $epoch_time variable actually shows up in the Variables>My section, while the others do not.
I verified that PadWalker is installed in Perl.
PS C:\git\src\WhatThePerl> perl -MPadWalker -e 'print $PadWalker::VERSION'
2.5

settings.json

I just installed berrybrew on my Windows 11 machine and installed the same Perl version you are using. I found that the error occurs when trying to parse variables, as the version of Data::Dumper bundled with it is too old and does not support the call to ->Trailingcomma(1), which is necessary for variable parsing to work properly. I fixed this by updating Data::Dumper using cpanm as follows:

After that, all unit tests passed with this version of Perl, and the debug adapter behaves correctly in VSCode as well:

Would it be possible for you to update your version of Data::Dumper to a more recent one? Removing the call to ->Trailingcomma(1) breaks the parsing of arrays and hashes, and a complete refactor would take additional time.

@joshcsmith13 I just released a new version that should be compatible with older versions of Data::Dumper.
Please give it a try.


Move repo to main tiki GitHub org

Consolidating GitHub orgs

GH Actions release workflow references NPM_TOKEN repo secret.


RFC: Add support for pathless layout routes

Which scope/s are relevant/related to the feature request?
router
Information
This feature can be useful to group related pages into the same folder without adding additional segments to the URL.
For the following structure:
app
  /routes
    /(auth)
       login.ts
       signup.ts

we'll be able to access the login and signup pages by using /login and /signup URLs. In the same way, we should be able to define a layout/shell component for pages in the (auth) folder:
app
  /routes
    /(auth)
       login.ts
       signup.ts
    (auth).ts

Pathless layout routes in Remix: https://remix.run/docs/en/v1/guides/routing#pathless-layout-routes
Describe any alternatives/workarounds you're currently using
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[ ] No

I think its a good idea to support this. Was also thinking about supporting a folder that can be co-located in the routes folder but not be picked up as a route, such as _route. I don't think it would conflict with this though

@brandonroberts I actually ran into this today. I was trying to put components that were only used in a specific route in the same folder as the route. Similar to what you describe or what the Remix docs describe here: https://remix.run/docs/en/v1/file-conventions/route-files-v2#folders-for-organization
I would absolutely this as a new feature!

@brandonroberts are you planning on creating an RFC for hiding co-located in the routes folders? Or even better, are you already working on adding this feature?

I updated the issue description - instead of two underscores (/__auth), we can use round brackets /(auth) for consistency because we already support this syntax for pathless routes. Thoughts? 👀
cc @brandonroberts

@goetzrobin I haven't but I'll create one for the ability to co-locate files within the routes folder. You're welcome to create one also if you already have a use case.

@markostanimirovic I like it for the consistency. My other thought is it might be confusing if we want to support aux routes in the future that use the parenthesis in the URL.
We could probably define those as /path(outlet-name) with /(path) being used for pathless routes.

@markostanimirovic I like it for the consistency. My other thought is it might be confusing if we want to support aux routes in the future that use the parenthesis in the URL.

In case we want to support auxiliary routes, it may make sense to do a breaking change and use the __ prefix instead of brackets for all pathless routes.

@markostanimirovic I like it for the consistency. My other thought is it might be confusing if we want to support aux routes in the future that use the parenthesis in the URL.

In case we want to support auxiliary routes, it may make sense to do a breaking change and use the __ prefix instead of brackets for all pathless routes.

You're saying define pathless routes as __index.ts instead of index.ts or (index.ts)?
I'd prefer to keep those as is and come up with a different convention for aux routes as they are much more niche in terms of usage.

You're saying define pathless routes as __index.ts instead of index.ts or (index.ts)?

Actually index.ts would remain the same and named pathless routes would change - (home).ts -> __home.ts.

I'd prefer to keep those as is and come up with a different convention for aux routes as they are much more niche in terms of usage.

Agree. 💯


chore: Release Noir(0.20.0)

:robot: I have created a release beep boop
0.20.0
0.20.0 (2023-12-01)
⚠ BREAKING CHANGES

avoid integer overflows (#2713)
return Pedersen structure in stdlib (#3190)
noir-wasm outputs debug symbols (#3317)
move mimc to hash submodule (#3361)
bump MSRV to 1.71.1 (#3353)
Add semver checks for the compiler version in Nargo.toml (#3336)
Move circuit serialization circuit into acir (#3345)
change stdlib function pedersen to pedersen_commitment (#3341)
expose pedersen hash in acir and bb solver (#3269)
Switch to new pedersen implementation (#3151)
Pass ACIR to ACVM by reference rather than passing ownership (#2872)
Make for loops a statement (#2975)
traits: trait functions with a default implementation must not be followed by a semicolon (#2987)
wasm: improve and simplify wasm compiler interface (#2976)
wasm: update wasm artifacts to match cli artifacts (#2973)
Maintain shape of foreign call arguments (#2935)
update to bb version 0.7.3 (#2729)
noir_js: Rename inner and outer proof methods (#2845)
generateWitness now returns a serialized witness file (#2842)
Issue an error when a module is declared twice & fix module search path (#2801)
Default integers to u64 (#2764)

Features

compute_note_hash_and_nullifier check (#3216) (4963c6c)
abi: Throw errors rather than returning string from noirc_abi_wasm (#2817) (df7b42c)
abi: Tuples as inputs/outputs to main (#2899) (d8bd78f)
acir: Enable dynamic indices on non-homogenous arrays (#2703) (622d2e4)
acir: Handle dynamic array operations for nested slices (#3187) (e026319)
acir: Set dynamic array values (#3054) (e871866)
acvm_js: Export black box solver functions (#2812) (da8a98e)
acvm: Separate ACVM optimizations and transformations (#2979) (5865d1a)
Add --check option to nargo fmt for dry-run formatting verification (#3530) (4469707)
Add destroy method to Noir (#3105) (7e40274)
Add execute method to Noir class (#3081) (17bdd7e)
Add FieldElement::from<usize> implementation (#3647) (8b7c5aa)
Add noir_codegen package (#3392) (6c4cd4d)
Add ACIR serializer C++ codegen (#2961) (7556982)
Add an options object to BarretenbergBackend constructor (#3105) (7e40274)
Add aztec selectors for event structs (#2983) (982380e)
Add bb interface implementation (#2902) (fe92dc0)
Add check for overlapping generic traits (#3307) (8cf81b6)
Add conditional compilation of methods based on the underlying field being used  (#3045) (2e008e2)
Add crate for pub modifier (#3271) (e7a1a1a)
Add debugger commands to introspect (and modify) the current state (#3391) (9e1ad85)
Add experimental REPL-based debugger (#2995) (281c696)
Add exports of JS black box solvers to noirJS (#3295) (8369871)
Add generic count check for trait methods (#3382) (a9f9717)
Add JS types for ABI and input maps (#3023) (599e7a1)
Add LSP command to profile opcodes in vscode (#3496) (6fbf77a)
Add lsp formatting (#3433) (286c876)
Add noir types package (#2893) (e8fc868)
Add package version to Nargo.toml metadata (#3427) (9e1717c)
Add profile info print out (#3425) (a8b5fa8)
Add semver checks for the compiler version in Nargo.toml (#3336) (0e530cf)
Add special case for boolean AND in acir-gen (#3615) (824039b)
Add support for tuple values in noir_codegen (#3592) (346d75f)
Allow a trait to be implemented multiple times for the same struct (#3292) (51831df)
Allow providing custom foreign call executors to execute_circuit (#3506) (d27db33)
Allow traits to have generic functions (#3365) (0f9af65)
Avoid integer overflows (#2713) (7d7d632)
Aztec-packages (#3599) (2cd6dc3)
Aztec-packages (#3626) (e0a96ea)
Cache debug artifacts  (#3133) (c5a6229)
Check where clauses when searching for trait impls (#3407) (84c6604)
Codegen typed interfaces for functions in noir_codegen (#3533) (290c463)
Compile without a backend (#3437) (d69cf5d)
Complex slice inputs for dynamic slice builtins (#3617) (8b23b34)
Contract events in artifacts (#2873) (4765c82)
Copy on write optimization for brillig (#3522) (da29c02)
Data bus (#3508) (6b0bdbc)
debugger: Highlight current src code loc (#3174) (6b87582)
debugger: Print limited source code context (#3217) (dcda1c7)
Default integers to u64 (#2764) (01cb041)
Dynamic indexing of non-homogenous slices (#2883) (72c3661)
Enable the fmt command in the help menu (#3328) (63d414c)
Expand trait impl overlap check to cover generic types (#3320) (a01549b)
Export CompiledCircuit from codegened TS (#3589) (e06c675)
Expose pedersen hash in acir and bb solver (#3269) (0108b6c)
Extract Brillig VM to allow step debugging (#3259) (f6431f9)
Format infix expressions (#3001) (7926ada)
formatter: Add formatter support for array literals (#3061) (a535321)
Handle constant index operations on simple slices (#3464) (7ae12f8)
Handle warnings in evaluator (#3205) (5cfd156)
Implement bound_constraint_with_offset in terms of AcirVars (#3233) (8d89cb5)
Implement automatic dereferencing for index expressions (#3082) (8221bfd)
Implement automatic dereferencing for indexing lvalues (#3083) (6e2b70a)
Implement euclidean division and signed division in terms of AcirVars (#3230) (b8b7782)
Implement impl specialization (#3087) (44716fa)
Implement integer printing (#3577) (6601408)
Implement raw string literals (#3556) (87a302f)
Implement string escape sequences (#2803) (f7529b8)
Implement where clauses on impls (#3324) (4c3d1de)
lsp: Add "info" codelens (#2982) (80770d9)
lsp: Add goto definition for functions (#3656) (7bb7356)
Maintain shape of foreign call arguments (#2935) (f7869e6)
Make generic impls callable (#3297) (8d9b738)
Manage breakpoints and allow restarting a debugging session (#3325) (f502108)
Nargo test runtime callstacks and assert messages without string matching (#2953) (1b6a4e6)
noir_js: Allow providing foreign call handlers in noirJS (#3294) (c76b0f8)
Noir-wasm outputs debug symbols (#3317) (f9933fa)
Noir-wasm takes dependency graph (#3213) (a2c8ebd)
Old docs issues (#3195) (26746c5)
Optimize euclidean division acir-gen (#3121) (2c175c0)
Oracle mocker for nargo test (#2928) (0dd1e77)
Pass ACIR to ACVM by reference rather than passing ownership (#2872) (b3a9c34)
Pass brillig bytecode to VM by reference (#3030) (4ee290b)
Perform compile-time euclidean division on constants (#3231) (3866d7e)
Prevent unnecessary witness creation in euclidean division (#2980) (c6f660e)
Properly track equivalence of witnesses generated for black box functions (#3428) (20b70c2)
Provide formatting subcommand  (#2640) (a38b15f)
Publish aztec build of noir_wasm (#3049) (3b51f4d)
Refactor debugger and separate core from UI (#3308) (8466810)
Remove redundant predicate from brillig quotients (#2784) (a8f18c5)
Remove type arrays for flat slices (#3466) (8225b2b)
Remove unnecessary truncation of boolean multiplication (#3122) (39dbcf1)
Replace boolean range constraints with arithmetic opcodes (#3234) (949222c)
Return compilation errors from noir_wasm (#3091) (55f63c9)
Return Pedersen structure in stdlib (#3190) (be30d59)
Reuse witnesses more when interacting with memory (#3658) (5a4a73d)
Reuse witnesses which have been assigned constant values during ACIR gen (#3137) (9eb43e2)
Save Brillig execution state in ACVM (#3026) (88682da)
Send and receive unflattened public inputs to backend (#3543) (a7bdc67)
Solve fixed_base_scalar_mul black box functions in rust (#3153) (1c1afbc)
ssa: Multiple slice mergers (#2753) (8f76fe5)
stdlib: Optimize constraint counts in sha256/sha512 (#3253) (d3be552)
Switch to new pedersen implementation (#3151) (35fb3f7)
traits: Add impl Trait as function return type #2397 (#3176) (4cb2024)
traits: Add trait impl for buildin types (#2964) (2c87b27)
traits: Added checks for duplicated trait associated items (types, consts, functions) (#2927) (d49492c)
traits: Allow multiple traits to share the same associated function name and to be implemented for the same type (#3126) (004f8dd)
traits: Implement trait bounds typechecker + monomorphizer passes (#2717) (5ca99b1)
traits: Improve support for traits static method resolution (#2958) (0d0d8f7)
traits: Multi module support for traits (#2844) (4deb07f)
Use ranges instead of a vector for input witness (#3314) (b12b7ec)
wasm: Improve and simplify wasm compiler interface (#2976) (1b5124b)
wasm: Update wasm artifacts to match cli artifacts (#2973) (ce16c0b)

Bug Fixes

"Missing trait impl" error in trait dispatch (#3440) (52daaec)
compute_note_hash_and_nullifier compiler check (#3351) (4e2d35f)
3275: Activate brillig modulo test with negative integers (#3318) (31c493c)
3300: Cache warnings into debug artefacts (#3313) (cb5a15b)
ACIR optimizer should update assertion messages (#3010) (758b6b6)
acvm: Return false rather than panicking on invalid ECDSA signatures (#2783) (155abc0)
Add pub modifier to grumpkin functions (#3036) (f8990d7)
Add compiler error message for invalid input types (#3220) (989e80d)
Add size checks to integer literals (#3236) (7f8fe8c)
Adding proving key initialization (#3322) (3383740)
Allow where clause on all functions and improve error message (#3465) (1647e33)
Allow constructors in parentheses in if conditions and for ranges (#3219) (ad192d1)
Allow two TypeVariable::Constant(N) to unify even if their constants are not equal (#3225) (cc4ca4b)
Apply predicate to over/underflow checks (#3494) (fc3edf7)
aztec_nr: Serialise arrays of structs (#3401) (e979a58)
Change non-constant argument errors from to_be_radix  from ICE to proper error (#3048) (19ce286)
Check for overflow with hexadecimal inputs (#3004) (db1e736)
Compiler version error message (#3558) (026a358)
Complete debug metadata (#3228) (2f6509d)
Conditionally run the "Create or Update PR" step in acir artifacts rebuild workflow (#2849) (63da875)
Corrected the formatting of error message parameters in index out of bounds error (#3630) (3bba386)
debugger: Step through foreign calls and breakpoints inside Brillig blocks (#3511) (5d77d7a)
Determinism of fallback transformer (#3100) (12daad1)
Disable modulo for fields (#3009) (7e68976)
Disallow returning constant values (#2978) (79c2e88)
Do not perform dead instruction elimination on mod,div unless rhs is constant (#3141) (af3d771)
Do not simply divisions (#3664) (e5b981b)
Docker builds (#3620) (f3eac52)
docs: Update editUrl path for docusaurus (#3184) (4646a93)
Download expected bb version if installed backend has version mismatch (#3150) (3f03435)
Error message for assigning the wrong type is backwards #2804  (#2805) (b2d62bf)
Finer bit size in bound constrain (#2869) (68385e2)
Fix aztec library after nargo fmt (#3014) (f43083c)
Fix crash when using undeclared traits (#3509) (8bb095a)
Fix lexer error formatting (#3274) (74bd517)
Fix method program_counter, change method signature (#3012) (5ea522b)
Fix panic in some cases when calling a private function (#2799) (078d5df)
Fix panic when using repeated arrays which define variables (#3221) (c4faf3a)
Fix should_fail_with (#2940) (4f07b84)
Fix subtract with underflow in flattening pass (#2796) (f2ed505)
Fixing versioning workflow (#3296) (3d5e43a)
Flatten public inputs according to their index in numerial rather than ascii order (#3605) (a1f6343)
Follow dependencies when looking for a struct (#3405) (561b1b8)
Force recompilation when output_debug flag is set. (#2898) (9854416)
frontend: Error on unsupported integer annotation (#2778) (90c3d8b)
Impl methods are no longer placed in contracts (#3255) (b673b07)
Improve error message when multiplying unit values (#2950) (57b7c55)
Include .nr and .sol files in builds (#3039) (ae8d0e9)
Issue an error when a module is declared twice & fix module search path (#2801) (7f76910)
Lack of cjs package version (#2848) (adc2d59)
Make for loops a statement (#2975) (0e266eb)
Match rust behaviour for left-shift overflow (#3518) (2d7ceb1)
Minor problems with aztec publishing (#3095) (0fc8f20)
Move mimc to hash submodule (#3361) (3ec29f1)
Overflow checks for constant folding (#3420) (b7a6383)
Parse parenthesized lvalues (#3058) (50ca58c)
Prevent duplicated assert message transformation (#3038) (082a6d0)
Prevent mutating immutable bindings to mutable types (#3075) (d5ee20e)
println: Enable printing of arrays/strings >2 in fmt strings  (#2947) (309fa70)
Recompile artefacts from a different noir version (#3248) (7347b27)
Remove cast for field comparisons in brillig (#2874) (1fc1fdb)
Remove duplication of code to load stdlib files (#2868) (b694aab)
Remove quotes from println output (#3574) (127b6aa)
Remove sha2_block test (#3360) (a48c03b)
Restrict fill_internal_slices pass to acir functions (#3634) (0cad9aa)
Return error rather than panicking on unreadable circuits (#3179) (d4f61d3)
Show println output before an error occurs in nargo execute (#3211) (2f0b80d)
Silence unused variable warnings in stdlib (#2795) (5747bfe)
Somewhat reduce mem2reg memory usage (#3572) (9b9ed89)
Split conditional_regression tests (#2774) (8ed8832)
ssa: Do not replace previously constrained values (#2647) (d528844)
traits: Trait functions with a default implementation must not be followed by a semicolon (#2987) (a3593c0)
Transform hir before type checks  (#2994) (a29b568)
Update link to recursion example (#3224) (10eae15)
Use 128 bits for constant bit shift (#3586) (2ca9b05)
Use pedersen_hash for merkle tree (#3357) (6b74d31)
Verify impls arising from function calls exist (#3472) (d7f919d)

Miscellaneous Chores

generateWitness now returns a serialized witness file (#2842) (57d3f37)
Bump MSRV to 1.71.1 (#3353) (78f2127)
Change stdlib function pedersen to pedersen_commitment (#3341) (964b777)
Move circuit serialization circuit into acir (#3345) (122119b)
noir_js: Rename inner and outer proof methods (#2845) (71dbbb8)
Update to bb version 0.7.3 (#2729) (fce68d1)

0.37.0
0.37.0 (2023-12-01)
⚠ BREAKING CHANGES

Move circuit serialization circuit into acir (#3345)
expose pedersen hash in acir and bb solver (#3269)
Switch to new pedersen implementation (#3151)
Pass ACIR to ACVM by reference rather than passing ownership (#2872)
wasm: improve and simplify wasm compiler interface (#2976)
Maintain shape of foreign call arguments (#2935)

Features

acvm_js: Export black box solver functions (#2812) (da8a98e)
acvm: Separate ACVM optimizations and transformations (#2979) (5865d1a)
Add FieldElement::from<usize> implementation (#3647) (8b7c5aa)
Add ACIR serializer C++ codegen (#2961) (7556982)
Add conditional compilation of methods based on the underlying field being used  (#3045) (2e008e2)
Add debugger commands to introspect (and modify) the current state (#3391) (9e1ad85)
Aztec-packages (#3599) (2cd6dc3)
Expose pedersen hash in acir and bb solver (#3269) (0108b6c)
Extract Brillig VM to allow step debugging (#3259) (f6431f9)
Implement euclidean division and signed division in terms of AcirVars (#3230) (b8b7782)
Maintain shape of foreign call arguments (#2935) (f7869e6)
Pass ACIR to ACVM by reference rather than passing ownership (#2872) (b3a9c34)
Pass brillig bytecode to VM by reference (#3030) (4ee290b)
Refactor debugger and separate core from UI (#3308) (8466810)
Replace boolean range constraints with arithmetic opcodes (#3234) (949222c)
Save Brillig execution state in ACVM (#3026) (88682da)
Solve fixed_base_scalar_mul black box functions in rust (#3153) (1c1afbc)
Switch to new pedersen implementation (#3151) (35fb3f7)
wasm: Improve and simplify wasm compiler interface (#2976) (1b5124b)

Bug Fixes

ACIR optimizer should update assertion messages (#3010) (758b6b6)
acvm: Return false rather than panicking on invalid ECDSA signatures (#2783) (155abc0)
Determinism of fallback transformer (#3100) (12daad1)
Fix method program_counter, change method signature (#3012) (5ea522b)
Minor problems with aztec publishing (#3095) (0fc8f20)
Prevent duplicated assert message transformation (#3038) (082a6d0)
Return error rather than panicking on unreadable circuits (#3179) (d4f61d3)

Miscellaneous Chores

Move circuit serialization circuit into acir (#3345) (122119b)

This PR was generated with Release Please. See documentation.

Changelog seems to have included v0.19 PRs 🤔


Fix (the ?foo)

I incorrectly failed to exclude corresponding-projection vars from grouping. This fixes that error, and also makes error checking more thorough.

Is it possible to include a test (example) where the distinction is clear?

The test included in this PR shows the distinction — one query returns two results, and the other returns one. The only difference is the: without it we group by that value, getting the maximum visit date for each title; with it we don't group by value, instead getting the title that corresponds to the maximum visit date.
Would it help for me to add that verbiage to the test?

Review comments addressed, @ncalexan.


Resolve database issues

Mainly implement and resolve #959,
Should also fix #957, fix #955 and fix #942

#405 is not resolved, since there is no additional text explaining why the items are marked as invalid

I'm not adding like dozens of text for somewhat self-explainable invalidations, and then getting translators to translate them. Not worth our time imo.

Ok then I'll remove #405 and close it separately

Oh I see why 405 was there. Issue title is misleading since it's 2 issues in 1. I'll still close separately


what-if-tool link broken in tensorflow.org Tools page

#38076  URL(s) with the issue:
https://www.tensorflow.org/resources/tools#
Please provide a link to the documentation entry, for example:
https://www.tensorflow.org/resources/tools#
Description of issue (what needs changing):
Link to what-if-tool is broken, as what-if moved to new repo.
Clear description
Current broken link, when someone clicks on "Get Started" link at
https://www.tensorflow.org/resources/tools
Broken link ->
https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/interactive_inference/What_If_Tool_Notebook_Usage.ipynb
New Correct link should be ->
https://github.com/PAIR-code/what-if-tool/blob/master/What_If_Tool_Notebook_Usage.ipynb
For example, why should someone use this method? How is it useful?
Correct links
https://github.com/PAIR-code/what-if-tool/blob/master/What_If_Tool_Notebook_Usage.ipynb
I wanted to submit a pull-request for this

Hi @bikashkumars, thanks for reporting this.
I've converted this to an internal bug assigned to the page owner (that's a page I can't fix).
I'm closing this as we have the internal bug now.
Thanks.


Drop manual scan, we now have proper CRDs

Type of change

Refactoring

Description
We now have proper CRDs, with watch support and also have owner references.

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=iot

:x: Test Summary :x:
TEST_PROFILE: iot
TEST_CASE:
TOTAL: 34
PASS: 25
FAIL: 5
SKIP: 4
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testDeviceCredentialsPlainPassword in io.enmasse.systemtest.iot.isolated.registry.InfinispanDeviceRegistryTest
testDeviceCredentials in io.enmasse.systemtest.iot.isolated.registry.FileDeviceRegistryTest
testDeviceCredentialsPlainPassword in io.enmasse.systemtest.iot.isolated.registry.FileDeviceRegistryTest
testSetExpiryForCredentials in io.enmasse.systemtest.iot.isolated.registry.FileDeviceRegistryTest
testMultipleProjects in io.enmasse.systemtest.iot.isolated.MultipleProjectsTest

@enmasse-ci run tests profile=iot testcase=io.enmasse.systemtest.iot.shared.http.HttpAdapterTest

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: iot
TEST_CASE: io.enmasse.systemtest.iot.shared.http.HttpAdapterTest
TOTAL: 5
PASS: 5
FAIL: 0
SKIP: 0


Redirect to external site

This could be my strong lack of FE knowledge. I'm playing around making a go-link/tinyURL style website.
When I run a request.respond with a 3XX and Location header, I'm seeing the endpoint replaced in the browser, not a redirect to an external site. Is this something that you can do with the server alone or maybe a limitation of mummy?
Ex:
go mapped to www.google.com
localhost:8080/go -> localhost:8080/www.google.com
Instead of
localhost:8080/go -> www.google.com

Never mind, I figured it out. Turns out for the Location header to redirect externally, you need to specify the scheme (e.g. http://). Otherwise, it's a local redirect.


x-frame-options security error with some identity providers

A number of identity providers won't work with the iFrame-based b2c login. For example, Google and Amazon produce these errors:
Refused to display 'https://accounts.google.com/signin/oauth?client_id=173429469116-dfb4asbe0mr3e3tghhpv0d5jbdfnd7c9.apps.googleusercontent.com&redirect_uri=https://wickedbyteapps.b2clogin.com/wickedbyteapps.onmicrosoft.com/oauth2/authresp&response_type=code&scope=email+profile&state=StateProperties%3...' in a frame because it set 'X-Frame-Options' to 'deny'.
Refused to display 'https://na.account.amazon.com/ap/oa?arb=5c72c689-4587-4f7c-9379-4a44626219f9' in a frame because it set 'X-Frame-Options' to 'sameorigin'.
Is there a workaround for this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d682d4c-86b5-c47e-89a3-3684b2235320
Version Independent ID: a80e115c-466a-288d-a918-9ef7514f5add
Content: Secure an ASP.NET Core Blazor WebAssembly hosted app with Azure Active Directory B2C
Content Source: aspnetcore/security/blazor/webassembly/hosted-with-azure-active-directory-b2c.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @marshallr12 ... Ask on the engineering repo. I'm vaguely aware of some support in MSAL for LoginMode (Redirect or Popup), but it doesn't seem to be supported in the context of a Blazor app.
https://github.com/dotnet/aspnetcore/issues
You can either report back here if we get actionable doc content, or you can add me (cc: @guardrex) to your engineering issue. I'll follow the discussion and re-open this if we receive something to cover in the topic.

https://github.com/dotnet/aspnetcore/issues/22343

Cross-reference: https://github.com/dotnet/aspnetcore/issues/20374


Various formatter fixes

The completionist in me wants to see a perfect 100% on GoReportCard, so I took a few minutes and ran some simple fixes. These should all be no-ops as far as functionality is concerned.
Note that the CustomDistributionValueGet and CustomFamilyValueGet functions appear to be unused, so there are no changes to callers.

Thanks!

No problem, thank you!
When I’m at a computer again I’ll get to the others!


Build an example Cache adapter for Redis to be used in Node.js runtimes

You can pass cache to Hydrogen's Node.js middleware, which is an instance of the Cache API.
However, we don't provide any resources for Node.js users to do so. They're on their own to discover this (lack of docs probably) and there doesn't seem to be any Cache-interfaced Redis adapter in the wild.
This should be fairly trivial to implement, so we could provide an example. If we find it's super useful, even release it as a package, since Cache is a huge part of the Hydrogen framework story.

Related, should we add an in-memory cache by default in @shopify/hydrogen/platforms/node?
This comment here made me stop when I was going to try it 😅

I almost got this working with some nice utils from Miniflare!
// server.js
const redis = new IORedis({
  host: process.env.REDIS_URL,
  port: process.env.REDIS_PORT,
  password: process.env.REDIS_PASSWORD,
});
const redisStorage = new RedisStorage(redis, 'cache');
cache = new Cache(redisStorage);

Problems arise due to mismatches between typeof Request because Miniflare uses undici, while we use node-fetch. Once we make Node v16 a requirement, that becomes a possibility 👍

Stackblitz Node 16 - https://github.com/stackblitz/webcontainer-core/issues/560

Something that I noticed is that if redis becomes unreachable then the app will crash. Now, I don't know if this is something you folks are likely to handle in Hydrogen, or whether you are of the opinion that it should be handled in the Cache implementation. As a work around I did the following, but It's not particularly robust.
class HandledRedisStorage extends RedisStorage {
  has = async (key) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.has(key);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  hasMany = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.hasMany(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  get = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.get(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  getMany = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.getMany(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  put = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.put(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  putMany = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.putMany(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  delete = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.delete(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  deleteMany = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.deleteMany(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
  list = async (...args) => {
    try {
      if (redis.status !== 'ready') {
        return false;
      }
      return await super.list(...args);
    } catch (e) {
      console.log(e);
      return false;
    }
  };
}


#7722: Run tf task directly if no free workers remain.

Post-commit CI run here: https://github.com/tenstorrent/tt-metal/actions/runs/8885271128, seeing about ~5x perf boost when running async op chain test.

Let's remove the multithreaded_compile var (compile should always be multithreaded since we can now support it) and get this merged. Seems like a few other tests are hanging due to running out of threads.

Let's remove the multithreaded_compile var (compile should always be multithreaded since we can now support it) and get this merged. Seems like a few other tests are hanging due to running out of threads.

Let's remove the multithreaded_compile var (compile should always be multithreaded since we can now support it) and get this merged. Seems like a few other tests are hanging due to running out of threads.

Removed the mutlithreaded_compile var/methods. Ran the post commit and multichip tests here and here

This is great! Thanks Jackson :)


Documentation and Example needed: How to compile an AST to javascript or java bytecode.

Please provide documentation and example on how to perform an AST transformation within the normal process of parsing, typechecking, optimizing and bytecode generation - most importantly on how to feed an AST into typechecking and compilation. [With compilation I mean javascript or bytecode generation]

Well, I’ve never compiled a ceylon.ast AST to CAR or JS before, so I can’t tell you how to do this yet… there’s a test that feeds two compilation units into the typechecker (powerOfTwo.ceylon), but I haven’t tried to hook that up to a backend yet. If you figure out how to do it, please let me know and I’ll be happy to add the documentation :)


Share the image and title

When sharing an XKCD comic the person I send it too should be able to have the "full experience" so a share function like Twidere does would be perfect:

Image
Title (comment of the author)
Link (to use his own app on it)

Maybe we would also include the comic title.

Is anyone working on this? I'd really like to try and do this!

Go ahead! I'm really busy with University stuff at the moment, so I don't really have time to work on the app myself

With https://github.com/tom-anders/Easy_xkcd/pull/153 image shares include title, alt text (if enabled) and link (if enabled).


Fatal Error: Failed to Restore Memory Limit

Describe the bug
Unable to jailbreak due to fatal error in jailbreaking process. Exact error in screenshot. Options enabled are:
• Load Tweaks
• Load Daemons
• Dump APTicket
• Disable Auto Updates
• Disable App Revokes
• Overwrite Boot Nonce
• Reload System Daemons
Kernel Exploit: Seems to affect both VS and M2 exploits
Happens using Unc0ver ipa installed through Cydia Impactor, not a signing service.
To Reproduce
Steps to reproduce the behavior:

Start in a non-jailbroken state
Open Unc0ver app
Tap jailbreak
See error

(I'm not sure why the error started now or exact steps to replicate bug.
Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

iOS Version: 12.1.1
iOS Device: iPhone X
unc0ver Version: 3.0.1

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver
[x] this issue persists after restarts

Logs
If applicable, add logs or error messages here.

Upon further use it seems like Unc0ver could not properly detect if I was in a jailbroken state or not. After closing the app from the switcher after getting the error message, I noticed some of my tweaks had partially loaded in. Except I was under the impression that the jailbreak was not successful since the home screen did not get tweaks applied to it. But in apps like settings and chrome tweaks were applied (like battery bars and dark modes). Apps only usable while jailbroken also worked. This let me respring and everything applied correctly and Unc0ver could properly detect that I was jailbroken.
Strange interaction and eventually worked out but I'll wait for a dev to close this ticket in case they have any luck reproducing my scenario.

iOS Version: 12.1.1
iOS Device: iPhone 8 Plus (GSM)
unc0ver Version: 3.0.1
jetsam file : com.jetsamproperties.D211.plist (different based on device - check log)
File Location:  /System/Library/LaunchDaemons/
Issue
This is happening as the jetsam file that unc0ver is trying to modify is corrupted.
Fix
I was able to fix the error by manually correcting the corrupted lines in the jetsam file.
Steps listed below:

Verify the line number in unc0ver logs. In my scenario it was Line # 744.
Copy file over to a computer for editing using Filza/alternative methods or open using a text editor on phone.
Open file in a code editor (VS Code/ Sublime) or on your phone and navigate to the Line # mentioned in the logs. You will notice a large block of unrecognizable characters.
Delete the unrecognizable characters and correct the key/dictionary block. If needed refer to the one of the other files (Dxxx.plist) for the same key/dictionary item.
In my scenario, this was com.apple.assistantd. I corrected it to the following

<key>com.apple.assistantd</key>
    <dict>
        <key>ExecuteAllowed</key>
        <true/>
    </dict>

Save file and transfer over to device if needed and set correct permissions.
Upon the next try at jailbreaking, you will notice that the error is now resolved.


Code error

In the PrimeService_IsPrimeShould.cs, the CreatePrimeService() methods returns a new instance of PrimerService class but the correct class name is PrimeService; in contains an extra 'r'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0063ceb-57ea-f30c-efed-b2a36314ccaa
Version Independent ID: bd9a321e-2ef2-491d-cd37-2d9c66f90cc9
Content: Unit testing C# with NUnit and .NET Core - .NET Core
Content Source: docs/core/testing/unit-testing-with-nunit.md
Product: dotnet-core
GitHub Login: @rprouse
Microsoft Alias: mairaw

Thanks for pointing out this code error, @hammamdiab. We've opened #13642 to fix it.


document Blackfriday extensions that are enabled by default

The documentation does not list them, but they can be found in the source. Had I known about them, it would have made tracking down an issue with \\\\ simpler.

This appears to be complete. https://github.com/gohugoio/hugoDocs/pull/128


realsense2_camera: 4.0.3-1 in 'galactic/distribution.yaml' [bloom]

Increasing version of package(s) in repository realsense2_camera to 4.0.3-1:

upstream repository: https://github.com/IntelRealSense/realsense-ros.git
release repository: https://github.com/IntelRealSense/realsense-ros-release.git
distro file: galactic/distribution.yaml
bloom version: 0.10.7
previous version for package: 4.0.2-1

realsense2_camera
* Support intra-process zero-copy
* Update README
* Fix Galactic deprecated-declarations compilation warning
* Fix Eloquent compilation error
* Contributors: Eran, Nir-Az, SamerKhshiboun

realsense2_camera_msgs

No changes

realsense2_description

No changes

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/new-packages-for-galactic-geochelone-2022-03-14/24688/4


implement new logic for RR multiple submissions in smart contracts

Consumers will specify the number of submissions before fulfillment. This must be smaller than the total number of operators.
Operators will fulfill until reaching the number, the last one to submit will call the fulfill function.
The reward will be evenly distributed to all operators who submit the value.

linked issue: https://github.com/Bisonai/orakl/issues/416

@KelvinThai Actually the last one should get more than the others because he has to spend gas on the fulfillment execution.

aha! so the equation should be:
fee - fulfilment gas: evenly distributed
last submit operator will receive portion + fulfillment gas

For the chargeFee() function. I suggest we split to:
ChargeFee() : decrease accID balance
payOperator(): increase node balance
That way the Prepayment contract can be extendable for different services with different fee distribution calculations and distributions. Or If you have any better ideas, let me know

Thank you for the idea! 🚀
I am currently touching on Prepayment and new contract called Account. I will try to share with you the latest version as soon as possible (the latest tomorrow). I have integrated there protocolFee as well. If it is possible can you ignore the payment for now. Then, we can see how it can all fit together.

Perfect! let's catch up tomorrow.


primaryKeyColumnName not working

appSettings.json - sink has "primaryKeycolumnName" set to non-default name ("RecordId"). Results in error: "Unable to write 1 log events to the database due to following error: The given ColumnMapping does not match up with any column in the source or destination." Removing this one line (and renaming the column back to "Id") and it all works again.

Serilog: v2.10.0
Serilog.Sinks.MSSqlServer: v5.6.0
(configuration, etc.) Settings.Configuration: v 3.1.0

.NET Core 3.1
Win10

Provide a simple reproduction of your Serilog configuration code:
{
"Name": "MSSqlServer",
"Args": {
"connectionString": "Server=.\DEV;Database=DocItHealthDb;Trusted_Connection=True;MultipleActiveResultSets=true",
"tableName": "JobLog",
"schemaName": "log",
"columnOptionsSection": {
"primaryKeyColumnName": "RecordId",
"removeStandardColumns": [ "MessageTemplate", "Properties" ]
}
}
}

Provide a simple reproduction of your application code:
.UseSerilog((hostingContext, loggerConfiguration) =>
{
loggerConfiguration
.ReadFrom.Configuration(hostingContext.Configuration)
.Enrich.FromLogContext()
.Enrich.WithProperty("ApplicationName", typeof(Program).Assembly.GetName().Name)
.Enrich.WithProperty("Environment", hostingContext.HostingEnvironment)
;

UPDATE - it doesn't work even if "Id" is specified as the primaryKeyColumnName, so it appears its the handling of this property itself that is the issue.

PrimaryKeyColumnName is only used when you configure MSSQL sink to create the log table for you by setting AutoCreateSqlTable to true. It is useful if you want any other than the standard column Id to be created as the PK. If you want the PK column not to be one of the predefined standard columns (for instance "RecordId", like in your sample), you must also add that column to the definition by using AdditionalColumns and set PrimaryKeyColumnName to the name that you selected for your additional column.
Here is an example configuration.
  "Serilog": {
    "MSSQLServerSinkOptions": {
      "autoCreateSqlTable": true
    },
    "ColumnOptions": {
      "primaryKeyColumnName": "RecordId",
      "removeStandardColumns": [ "Id", "MessageTemplate", "Properties" ],
      "additionalColumns": [
        {
          "columnName": "RecordId",
          "dataType": "12"
        }
      ]
    }

Anyway, in your case the log table seems to be prexisting and therefore you don't need to use PrimaryKeyColumnName. You can simply set the ColumnName of the standard column Id like this:
    "ColumnOptions": {
      "removeStandardColumns": [ "MessageTemplate", "Properties" ],
      "id": {
        "columnName": "RecordId"
      }
    }

Hello Christian,
Thank you for resolving this.  Your solution is neither intuitive nor (well) documented, but it works.
Regards, Rick.
From: Christian Kadluba<EMAIL_ADDRESS>Sent: November 11, 2020 12:27 PM
To: serilog/serilog-sinks-mssqlserver<EMAIL_ADDRESS>Cc: Rick Piovesan<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [serilog/serilog-sinks-mssqlserver] primaryKeyColumnName not working (#327)
PrimaryKeyColumnName is only used when you configure MSSQL sink to create the log table for you by setting AutoCreateSqlTable to true. It is useful if you want any other than the standard column Id to be created as the PK. If you want the PK column not to be one of the predefined standard columns (for instance "RecordId", like in your sample), you must also add that column to the definition by using AdditionalColumns and set PrimaryKeyColumnName to the name that you selected for your additional column.
Here is an example configuration.
"Serilog": {
"MSSQLServerSinkOptions": {

  "autoCreateSqlTable": true

},

"ColumnOptions": {

  "primaryKeyColumnName": "RecordId",

  "removeStandardColumns": [ "Id", "MessageTemplate", "Properties" ],

  "additionalColumns": [

    {

      "columnName": "RecordId",

      "dataType": "12"

    }

  ]

}

Anyway, in your case the log table seems to be prexisting and therefore you don't need to use PrimaryKeyColumnName. You can simply set the ColumnName of the standard column Id like this:
"ColumnOptions": {

  "removeStandardColumns": [ "MessageTemplate", "Properties" ],

  "id": {

    "columnName": "RecordId"

  }

}

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/serilog/serilog-sinks-mssqlserver/issues/327#issuecomment-725554435, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJC5GOLUFICYTB2QGTACYTSPLCMPANCNFSM4TP3J4UQ.


train with multiple GPUs

Hi,
I get some problems in self-training process in st3d++ branch:
1)Perhaps the "consistency_matching" in some yamls should be "consistency_ensemble"
2)When using "tools\cfgs\da-nuscenes-kitti_models\secondiou_st3d\secondiou_st3d++_ros_car.yaml" by running "python train.py --cfg_file xxx" is ok, but I get error "can not find pesudo label for frame:  xxx" by running “sh scripts/dist_train.sh xxx --cfg_file xxx”. The self-training process with multiple GPUs didn't work.
I wonder if someone get the same problems.
Thanks.

(1) Yes! This is a mistake caused by different name in internal and released version, I will fix it soon. Thank you so much!
(2) Check that whether this issue https://github.com/CVMI-Lab/ST3D/issues/9 can help?

Thanks for your reply! It works!


Simulator should satisfy HasPlookup

The simulator currently does not use the HasPlookup code paths, but most likely it should. It's perhaps a good idea to look into this after the new unified Pedersen work is complete.

Simulator is deprioritized.


Peer-to-peer review: Morning session

Hi @German-Cobian,
Good job so far 👽
there are some suggestions to make your project even better:

You can try adding a default value for the id value.
If you can put your code into modules, it would be much better.

The code looks good for me, Good job and happy coding, keep the hard work! 🤓

The code looks Good for me, Good job and happy coding, keep the hard work!


Definition of Functional Coverage

Hi,
From the Documentation, it was found that the functional coverage is from the ISS Simulation-flow

But, Functional Coverage is defined as the "measure of what functionalities/features of the "design" have been exercised by the tests"
And Design here refers to the RTL of a RISC-V SoC.
So, RISCV-DV technically evaluates the functional coverage only from the perspective of instructions (what instructions were covered) and not the RTL design (what parts of RTL were exercised). Is that correct?
Is there going to be any other coverage metrics (other than functional coverage) in the future?

I worry about this approach.  If your goal is to verify the RTL, then you should be collecting coverage from the RTL.
Having said that, the "UVM way" of handling this is to define a single data-type (uvm_sequence_item in UVM-ese), and populate in the monitor that watches retirements in the RTL and in the ISS monitor.  In this way it is possible to collect functional coverage from environments that do not have RTL (useful for bring-up testing and seeing how good your test-programs are.
Have you looked at CORE-V Wally?  The "Wally" core has an excellent functional coverage model and follows a strategy similar to the above.
As for other coverage, I strongly recommend code coverage of the RTL.  Of course, that is a tool issue, not a riscv-dv issue.

I worry about this approach. If your goal is to verify the RTL, then you should be collecting coverage from the RTL.
Having said that, the "UVM way" of handling this is to define a single data-type (uvm_sequence_item in UVM-ese), and populate in the monitor that watches retirements in the RTL and in the ISS monitor. In this way it is possible to collect functional coverage from environments that do not have RTL (useful for bring-up testing and seeing how good your test-programs are.
Have you looked at CORE-V Wally? The "Wally" core has an excellent functional coverage model and follows a strategy similar to the above.
As for other coverage, I strongly recommend code coverage of the RTL. Of course, that is a tool issue, not a riscv-dv issue.

Hi @MikeOpenHWGroup, thanks for your answer like always!
I completely agree with you. I am a new user of RISC-V-related technologies and am particularly interested in functional coverage. That's why I wanted to explore what RISC-V-DV offers in this area as well. As you mentioned, cores like Wally utilize licensed tools (ImperasDV-riscvISAcov) to generate SystemVerilog files with ISA-level coverage.
I am interested in reusing existing code because manually implementing functional coverage for RISC-V can be quite labor-intensive. However, I currently don't have access to ImperasDV, and I would also need to define a tracer to comply with the RVVI interface.
That being said, I noticed the following in RISCV-DV's  src/riscv_instr_cover_group.sv file:
  // By default the coverage model run with instruction trace from ISS simulation. When simulating   // with ISS, certain covergroups like debug/interrupt could not be hit as these are not simulated   // with ISS. You can turn off this mode by adding +iss_mode=0 if you use the instruction trace   // from RTL simulation.   bit                     iss_mode = 1'b1;
and in the coverage generation script cov.py:
if argv.core:         """If functional coverage is being collected from an RTL core         implementation, the flow assumes that the core's trace logs have         already been converted to CSV files by the post_compare step of the         flow. """         trace_log = ("{}/{}_trace_log".format(out, argv.core))         run_cmd("find {} -name \"*.csv\" | sort > {}".format(argv.dir, trace_log))
Thank you very much for your help!

This is becoming a bit of a discussion, rather than an Issue resolution, and I am not sure the code-owners of this repo want to use Issues for such discussions.  As such, I'll try to answer your questions above and then will not update this Issue further.  If you like, please reach out to me directly and we can debate the topic off-line.

As you mentioned, cores like Wally utilize licensed tools (ImperasDV-riscvISAcov) to generate SystemVerilog files with ISA-level coverage.

That is partially true.  Wally does use the ISA coverage model from Synopsys/Imperas, but is also developing its own open-source version.  It should be available on the repo.  There is also ISACOV available here.  (Note, ISACOV covers RV32IMC only.)

However, I currently don't have access to ImperasDV

You do not need ImperasDV if you collect functional coverage from the RTL's tracer.

I would also need to define a tracer to comply with the RVVI interface.

You will need a Tracer anyway, you might as well use a good one.  😛

That being said, I noticed the following in RISCV-DV's...

I do not recommend using the RISCV-DV approach for collecting coverage.  Your environment will be much easier to use and maintain if you place on Monitor on the Tracer and use that Monitor to unpack Tracer transactions into the uvm_sequence_item used by your coverage model and then sample() it directly.


Add a global peer blacklist

Store a list of peer addresses which we are unable to dial, to fail more quickly when dialing peers frequently

We can revert this in favor of #236 when that's sorted out.  This is a simple version of that prevents dial from being called for a while if we were previously unable to dial out.  This prevents the case where Wavelet asks to dial dead nodes.

Thank you for this addition to noise @rkeene!
Btw, what would you think about adding a small method to add a peer to the blacklist on *skademlia.Client? We currently have some custom blacklisting logic for our use case; it would be really helpful to reuse the existing blacklist that you have added here!

@creamwhip I think that the solution in PR #236 will be more general.  I experimented a lot with the blacklist, but it caused problems with nodes each blacklisting.
It would be interesting to see your custom blacklisting implementation to decide how best to move forward.


installation problem

Hi i received this error when i run composer command for install package. please guide me on it. thanks
Your requirements could not be resolved to an installable set of packages. Problem 1     - Installation request for rap2hpoutre/laravel-stripe-connect ^0.2.1 -> satisfiable by rap2hpoutre/laravel-stripe-connect[v0.2.1].     - rap2hpoutre/laravel-stripe-connect v0.2.1 requires stripe/stripe-php ^5.0 -> satisfiable by stripe/stripe-php[v5.0.0, v5.1.0, v5.1.1, v5.1.2, v5.1.3, v5.2.0, v5.2.1, v5.2.2, v5.2.3, v5.3.0, v5.4.0, v5.5.0, v5.5.1, v5.6.0, v5.7.0, v5.8.0, v5.9.0, v5.9.1, v5.9.2] but these conflict with your requirements or minimum-stability. Installation failed, reverting ./composer.json to its original content.

Could you please provide the whole composer.json file? I think there is a version conflict with stripe/stripe-php

Hi ,rap2hpoutre , hope you are well ,
i have a question regarding installation of laravel-stripe-connect,
as preiously i was using stripe but as per requirement i want to use stripeConnect instead of stripe.
now when i run this (composer require rap2hpoutre/laravel-stripe-connect) it shows me error
Problem 1
- Installation request for rap2hpoutre/laravel-stripe-connect ^0.2.1 -> satisfiable by rap2hpoutre/laravel-stripe-connect[v0.2.1].
- rap2hpoutre/laravel-stripe-connect v0.2.1 requires stripe/stripe-php ^5.0 -> satisfiable by stripe/stripe-php[v5.0.0, v5.1.0, v5.1.1, v5.1.2, v5.1.3, v5.2.0, v5.2.1, v5.2.2, v5.2.3, v5.3.0, v5.4.0, v5.5.0, v5.5.1, v5.6.0, v5.7.0, v5.8.0, v5.9.0, v5.9.1, v5.9.2] but these conflict with your requirements or minimum-stability.
any solution for this please?

@rap2hpoutre I'm having this same issue. I have laravel cashier installed and "stripe/stripe-php": "~6.0" which is causing the issue. Anyway you can update the composer file to refelct the latest stripe package?

This package is deprecated, looking for a competitor. See this reddit post.


chore: release v0.3.4

:robot: I have created a release beep boop
0.3.4 (2024-07-27)
Performance Improvements

reduce computation (#77) (28b53aa)
reduce computation (#79) (5a15457)
render optimizations (#80) (1330265)
render optimizations (#81) (b2ca0ce)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.3.4
:sunflower:


replacement for ystockquote

In Chapter6_Priorities, the stock quote example need to update the usage of ystockquote library since yahoo api has been discontinued.

@bicepjai The whole ecosystem for equities data
which depends upon Yahoo and Google Finance
has recently been disrupted .
Remedies and alternatives are in progress, see
https://github.com/rsvp/fecon235/issues/7 for details.


layers: Add vkCreateRenderPass subpass attachment VUs

This PR implements all the stateless VkSubpassDescription tests I could find (excluding the ones that involve parsing and analyzing SPIR-V code), including test coverage. Several existing tests were eliminated, where I found it easier to include them as part of the new CreateRenderPassAttachments test.
One question for reviewers: please double-check that I've intepreted VU 00349 correctly. The spec states:

If the first use of an attachment in this render pass is as an input attachment, and the attachment is not also used as a color or depth/stencil attachment in the same subpass, then loadOp must not be VK_ATTACHMENT_LOAD_OP_CLEAR

Does "first use" include usage as a preserve attachment? My change assumes that it does since the spec doesn't explicitly exclude it, but I'd love to get a second opinion.

Updates:

The spec does indeed state that preserve attachments are not "used"; I updated the check for VU 00349 accordingly.
To clarify, several subpass attachment VUs were already implemented; in those cases all I did was add test coverage for them. See the vk_validation_error_database.txt changes for details.

Just an initial comment to check if you've looked at ValidateLayouts() which is implemented in buffer_validation.cpp?
There's a comment in about consolidating that function with ValidateRenderpassAttachmentUsage() that you're modifying here.
Not sure if that comment still makes sense offhand but if so would be nice to consolidate while you're making these changes or shortly thereafter.
On a quick glance I noticed that ValidateLayouts() also has some first-use tracking which prompted this comment. I'll continue review of your changes.

I moved the layout-related checks into ValidateLayouts() to join their brethren. Assuming AppVeyor succeeds this time, I'll go ahead and merge.

Appveyor failure looks spurious; everything builds and runs correctly both locally and on the internal buildbot.


Realtime

At first, I thought it could run in real-time, but since it uses LSTM, it isn't feasible. However, I'm looking forward to the release of the code and weights. Great job

Hi @MosbehBarhoumi, great to hear that you are looking forward to the code and weights release! Expect it for January.
Regarding the runtime, we were able to run it on a single NVIDIA RTX 3090 at 18 FPS on a video from dancetrack, with the shorter image side resized to 800 pixels and the aspect ratio maintained.
Why do you think that the usage of an LSTM would not allow for real-time inference?

Hi @mattiasegu ,
Thanks for the update! Excited to dive into the code and weights.
Regarding the LSTM and real-time inference, my initial concern stemmed from the common perception that LSTMs, with their sequential nature and recurrent connections, can be computationally intensive and may not scale well to high frame rates.
Your RTX 3090 results at 18 FPS are impressive, showing LSTM can be optimized for real-time. With the RTX 4090, I'm curious if we could push to ~50 FPS for sports videos, that would be fantastic for real-time applications!

I'm confident that, with the proper optimization, 50 FPS on the RTX 4090 is feasible! I'm quite excited about the sports applications you have in mind

I'm working on real-time analysis for padel games, and if everything goes as planned, it will be ready by next year!!


also serve yaml spec

Fixes #769
Changes proposed in this pull request:

also serve the spec as yaml

Note that this implementation is a bit of a hack - I wanted to get the discussion going.

5 cents on this is that I don't fancy having one thing doing too many things in the same time without explicit request. I'd say that if user wishes to server specification as yaml he has good reasons for it. If that is his/her wish let's maybe check how openapi_spec_path looks like. If:

ends with .json or there is no format suffix, let's servr JSON
ends with .yml or yaml, let's serve yaml

User gets the flexibility and there are not that many extra endpoints. With this change, as proposed now, you get either 0 (if you disable serving the spec) or 3 endpoints, right?

I think we always want to serve json for the client / UI.
I'm not personally a fan of this feature, but I decided to put the PR up for comment / discussion.
Another way to do this would just be to put your spec somewhere that serves up static files, and then also import it from there. I'll add a comment about that on the ticket.


Make cancelAllSnackbars async

Title: Make cancelAllSnackbars async
Description:
This PR changes the cancelAllSnackbars method in SnackbarController to be async. This allows the method to wait until all snackbars are cancelled before returning. Previously, the method returned immediately, and any errors that occurred during the cancellation of the snackbars were not caught by a try-catch block.
This change will help prevent LateInitializationError errors when trying to cancel all snackbars.

Thank you for your contribution!


fix: Ignore NSS user and group entries

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
NSS (Named Service Switch) users can be listed in /etc/passwd with a name starting with a + or - sign and an empty uid field (the same idea applies to groups in /etc/group). For instance a line in /etc/passwd can take the form +@r_unix:::::: and, when parsed by function fgetpwent(), it translates the empty uid field in a zero. This uid is then used as key to an internal map, effectively overwriting the data of the root user, which typically gets uid equal to zero.
This PR aims at ignoring such users and groups (the ones with a + or - prefix) that cannot find a place in the map in any case, having all the same zeroed uid.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: federico-sysdig
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cc @FedeDP

@wigol: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: federico-sysdig, wigol
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, federico-sysdig, wigol
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c230d5c64ebe088ffde7923054ed9af871ab066a

/milestone 0.17.2

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig, wigol
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
I'm stopping the merge for the moment. I need to check a couple of things.
Also, may I ask your advice on whether we should have a debug log when ignoring a user?
E.g.
	if(!name.empty() && (name[0] == '+' || name[0] == '-'))
	{
		libsinsp_logger()->format(sinsp_logger::SEV_DEBUG,
			"NSS user %.*s ignored", static_cast<int>(name.length()), name.data());
		// ignore NSS entries
		return nullptr;
	}

For sure this fix is great thank you!
I'm not sure what NSS (Named Service Switch) users are, but I will try to search for something about them... Is it possible that a process under these users could generate some syscalls? if yes we will have <NA> that is not so cool...
More in general maybe we shouldn't remove all the users that start with + or - not sure how common they are but maybe we should just fill an entry with an invalid uid. WDYT?

Also, may I ask your advice on whether we should have a debug log when ignoring a user?

I would add it, as said in the previous comment is possible that we are loosing some valid users (we are probably talking about very strange corner cases)

Also, may I ask your advice on whether we should have a debug log when ignoring a user?

+1 from me!

More in general maybe we shouldn't remove all the users that start with + or - not sure how common they are but maybe we should just fill an entry with an invalid uid

If we map them to an invalid uid we are just wasting memory space, since we will still show NA infos.

If we map them to an invalid uid we are just wasting memory space, since we will still show NA infos.

Yep probably this is not the right way, what I would like to obtain is the name of the user even if the uid is invalid or empty, not sure if we have an easy way to do it today

More in general maybe we shouldn't remove all the users that start with + or - not sure how common they are but maybe we should just fill an entry with an invalid uid. WDYT?

This is the crucial point and the one I don't feel confident to overcome without a broader discussion with the core maintainers. The issue is that the internal map has the uid as key and we don't have a key for these users, I'm taking the easy way out of ignoring these users as they are causing trouble overwriting the slot in the map for root and competing among each other for this slot (the last one wins). Briefly put, this change should not make things worse and overcome an issue that can be serious. I'm afraid that managing these users might mean taking a trip over the network to find their info in an external source.

Briefly put, this change should not make things worse and overcome an issue that can be serious. I'm afraid that managing these users might mean taking a trip over the network to find their info in an external source.

Yes that's for sure, unless they are cached somewhere.
Anyway, we need to use the uid as key for the map; i would love to understand which uid are nss users mapped to.

New changes are detected. LGTM label has been removed.

I've added a log line when ignoring a user/group and fixed a problem: it turns out that the check for an NSS user/group must be done earlier.

Added one unit test. I should be finished now, unless something else comes up.

LGTM label has been added.  Git tree hash: a1f77f7f0e6316e2ecd8c166b9ffa028bb7291ce

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig, wigol
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, federico-sysdig, wigol
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Bug: selecting text and pressing ctrl+D (insert datestamp) can't be undone

Hey, thanks for the app, first of all, I like it a lot.
As for the bug:

Select some text in a note.
Press ctrl+D, a datestamp will be inserted over the selected text.
You can't undo this action, and that's the problem (selected text is lost for you forever).

Yeah, it would be too !  Thats an oversight, I have not hooked the Ctrl-D into the undo mechanism.
I'll fix it !
Thanks for the report. Could be messy, you could have the while document selected !  Ahh....
Davo

hi omn1vor, I have just put some alpha packages on the tomboy-ng 0.34 release page that address this issue. They are relativly untested but I have been using much of the new code for some months with no apparent problems. Depending on how brave you feel, you might like to git it a go.
https://github.com/tomboy-notes/tomboy-ng/releases/tag/v0.34
Davo

Thanks man, I'll wait for main, but I will let the guy who had found this bug the hard way know right now :)

Fixed in 0.35
So, I'll close
Thanks for the report.
Davo


updated opencv version for security

Fixes https://github.com/catalystneuro/roiextractors/security/dependabot/3

Thanks, Paul.


cmd/compile: windows/amd64 invalid binary when allocating array near symbol size limit

What version of Go are you using (go version)?

$ go version
go version go1.19 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Argusdusty\AppData\Local\go-build
set GOENV=C:\Users\Argusdusty\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=O:\Code\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=O:\Code
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.19
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=O:\Code\src\foo\go.mod
set GOWORK=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1331241143=/tmp/go-build -gno-record-gcc-switches

What did you do?

https://go.dev/play/p/x7RM0aBCBYz:
package main

var A [2000000000]byte

func main() {
	A[0] = 0
}

Create this locally as foo.go, Then go run foo.go
What did you expect to see?
Successful execution
What did you see instead?

$ go run foo.go
fork/exec C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1278580373\b001\exe\foo.exe: %1 is not a valid Win32 application.

Binary search testing different numbers of bytes shows the code works up to<PHONE_NUMBER> bytes, produces the above error for<PHONE_NUMBER>-2000000000, and produces symbol too large errors above that.

@alexbrainman not expecting you to fix this necessarily, but are you familiar with what sort of error or implementation restriction might be causing this?

fork/exec C:\Users\ARGUSD~1\AppData\Local\Temp\go-build1278580373\b001\exe\foo.exe: %1 is not a valid Win32 application.

Windows loader tries to run Go executable and fails with ERROR_BAD_EXE_FORMAT error message.
I suspect the problem is that pe file optional header SizeOfImage is larger that 2 GB. See

PE32+ images allow for a 64-bit address space while limiting the image size to 2 gigabytes.

from https://docs.microsoft.com/en-us/windows/win32/debug/pe-format
Also
https://stackoverflow.com/questions/6976693/what-is-the-maximum-size-of-a-pe-file-on-64-bit-windows
You can use this online tool
https://speedtesting.herokuapp.com/peviewer/
to check particular exe.

produces symbol too large errors

This is unrelated message from Go linker:
a@spot:~/go/src$ git grep -ne "symbol too large"
...
cmd/link/internal/ld/data.go:2076:                      ctxt.Errorf(s, "symbol too large (%d bytes)", ss)
a@spot:~/go/src$

that rejects symbols larger than 2GB.
I hope it helps. But I doubt.
Alex


Switch from single lodash library to functions required

No functional change, just slims down the install size.

usually people bundle lodash with their app and then it's deduped. That being said the change will actually increase the final bundle size given that scenario

I would argue that if someone is already pulling in all of lodash instead of the functions they need, they don't care about the very minor bloat of 16 functions.
Also, a quick experiment on a fresh project:
ioredis 3.1.1
yarn why ioredis
yarn why v0.27.5
[1/4] Why do we have the module "ioredis"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info Has been hoisted to "ioredis"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "240kB"
info Disk size with unique dependencies: "6.16MB"
info Disk size with transitive dependencies: "6.18MB"
info Number of shared dependencies: 8

ioredis git://github.com/chris-olszewski/ioredis.git#get_rid_of_monolithic_lodash
yarn why ioredis
yarn why v0.27.5
[1/4] Why do we have the module "ioredis"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
info Has been hoisted to "ioredis"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "580kB"
info Disk size with unique dependencies: "2.18MB"
info Disk size with transitive dependencies: "2.2MB"
info Number of shared dependencies: 23

Yes please, I was already wondering why ioredis is so much bigger than node_redis, lodash takes up 5MB.

Released in v3.1.3


Provide SecHub "execution profiles"

Situation
with #148  admins will be able to enable/disable and also configure executors at runtime.
But when we provide many tools and not every enabled executor shall be availabel for every project we need a layer between.
E.g.
project1 is written in go
project2 is written in java
project3 is written in c/c++
project4: is written in python
project5: is written in kotlin
when we provide
a) checkmarx adapter
b) PDS: gosec
c) PDS: findbugs
d) PDS: SAST-tool-only-python
e) PDS: SAST-tool-only-kotlin
f) netsparker adapter
g) PDS: an-extreme-brand-new-tool-testing
All of those executors are run (depending of codescan type)
Wanted
We want

only executors running being suitable for dedicated project
a way to administrate this by something between project and execution configurations
a way to activate a dedicated new tool only for a (pilot) project without affecting all other projects

Solution
Introduction of execution profiles
We provide execution profiles.

Every project is related to n execution profiles
Every execution profile is related to n product executor configurations (introduced with #148)

Instead of collecting all enabled executor configurations a job will only use the enabled executor configuration available in related  execution profiles.
Example
Setup
Executor Config A: checkmarx adapter (SAST)
Executor Config B: PDS: gosec (SAST)
Executor Config C: PDS: python tool (SAST)
Executor Config D: netsparker adapter (DASP)
Execution Profile with id "profile-ab":  configurations A,B added
Execution Profile with id  "profile-c"    : configuration C added
Execution Profile with id  "profile-d"    : configuration D added
Project1 has "profile-ab"
Project2 has  "profile-c"
Project3 has "profile-ab" and  "profile-c" and "profile-d"
Project4 has no profile
What shall happen ?
Project1 scan will execute checkmarx and also with gosec for code scans, webscans not possible
Project2 scan will execute python sast tool, webscans not possible
Project3 scan will execute checkmarx, gosec and python sast tool for webscans and netsparker for webscans
Project4 scan will do NOTHING because no profile at all
Necessary migration
We have already created projects. Those projects have no profiles at the moment.
When this features is active a current setup would not work any longer.
We will handle this by providing a mass CSV operation inside Developer Admin UI.
CSV assign profile to projects mass operation
CSV will look like:
projectId, profileId
So when doing a CSV mass create project operation were owners and projects are automatically created in addition
this mass operation must be done as well
Usecases

[ ] ADMIN_CREATES_EXECUTION_PROFILE
[ ] ADMIN_ADDS_RELATION_TO_CONFIG_AT_EXECUTION_PROFILE
[ ] ADMIN_REMOVES_RELATION_TO_CONFIG_AT_EXECUTION_PROFILE
[ ] ADMIN_REMOVES_EXECUTION_PROFILE
[ ] ADMIN_ADDS_EXECUTION_PROFILE_TO_PROJECT
[ ] ADMIN_REMOVES_EXECUTION_PROFILE_FROM_PROJECT
[ ] ADMIN_LISTS_EXECUTION_PROFILES

TODO

[ ] implement all mentioned use cases
[ ] create/add concept documentation
[ ] handle existing integration testcases

every scenario must have a default profile were standard executors are inside and applied to existing projects
so existing tests do not fail

[ ] write integration tests for new usecases
[ ] add missing restdoc tests
[ ] write CSV mass operation for developer admin ui

Albert Tregnaghi<EMAIL_ADDRESS>Daimler TSS GmbH, imprint

This will be made together with #148  because otherwise #148 integrations tests are extreme slow and also executor configuration changes could lead to race conditions in tests


ARROW-5945: [Rust] [DataFusion] Table trait can now be used to build real queries

The Table (DataFrame) trait can now be used to build real queries, since it now supports projection, selection, aggregate, and limit.
Tests were moved from Table to TableImpl and are now more comprehensive.
Not all expressions are supported yet and separate PRs will expand the number of expressions that are supported.

@sunchao @nevi-me @kszucs @paddyhoran PTAL when you can

Codecov Report

Merging #4875 into master will decrease coverage by 4.72%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #4875      +/-   ##
==========================================
- Coverage   87.08%   82.35%   -4.73%
==========================================
  Files         883       85     -798
  Lines      116941    24512   -92429
  Branches     1418        0    -1418
==========================================
- Hits       101837    20187   -81650
+ Misses      14742     4325   -10417
+ Partials      362        0     -362

Impacted Files
Coverage Δ

rust/datafusion/src/execution/table_impl.rs
89.8% <88.88%> (+4.96%)
:arrow_up:

cpp/src/arrow/csv/chunker-test.cc

cpp/src/parquet/column_page.h

cpp/src/parquet/bloom_filter-test.cc

cpp/src/arrow/array/builder_decimal.cc

r/src/symbols.cpp

cpp/src/arrow/io/test-common.h

cpp/src/arrow/util/int-util-test.cc

cpp/src/arrow/status-test.cc

cpp/src/parquet/column_scanner.cc

... and 788 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c23e98...fb901af. Read the comment docs.

@sunchao Please take another look when you can. Thanks.

Looks good but there's test failure. @andygrove could you take a look?

Thanks @sunchao ... I needed to rebase and update a test that was in master but not in this PR branch. Should be good now :crossed_fingers:

Thanks @sunchao !


Error in assignID, item with name 'pipe-mk2' does not exist.

Here are the new versions of the core/machine component. Just download these ones and replace them with the ones in your mods folder and the problem should be fixed.
https://mods.factorio.com/api/downloads/data/mods/334/FactorioExtended-Core_0.1.9.zip
https://mods.factorio.com/api/downloads/data/mods/342/FactorioExtended-Machines_0.1.9.zip


Luarocks doesn't check that build.modules exists before it tries to use it

(Forwarding from mailing list)
It checks everything else so carefully, but build = { type = “builtin” } causes a crash.
Error: LuaRocks scm bug (please report at luarocks-developers@lists.sourceforge.net).
/usr/local/share/lua/luarocks/build/builtin.lua:200: bad argument #1 to 'pairs' (table expected, got nil)
stack traceback:
[C]: in function 'pairs'
/usr/local/share/lua/luarocks/build/builtin.lua:200: in function 'run'
/usr/local/share/lua/luarocks/build.lua:255: in function 'build_rockspec'
/usr/local/share/lua/luarocks/make.lua:82: in function </usr/local/share/lua/luarocks/make.lua:51>
[C]: in function 'xpcall'
/usr/local/share/lua/luarocks/command_line.lua:208: in function 'run_command'
/usr/local/bin/luarocks:33: in main chunk
[C]: at 0x0100001950

Fixed


feat(gists): add listGists() and yarn.lock

@blaskovicz This appears to exist already. Check out User.listGists.

Closing for now, though I'm open to feedback on where listGists should be located.


AzureWebPowerShellDeployment loc handback

this need not required. This task is added from releases/M109 to releases/M122 for deprication. The M109 was having all correct loc changes. We do not required these changes

closing this pull request


Go modules Updates (WIP)

@nwmac can this be closed?

@KlapTrap No. This is a WIP set of improvements. Needs completing.


onboard modify-data-object task with basic files

What this PR does / why we need it:
onboard modify-data-object task with basic files
This task will replace create-data-object task
Release note:
NONE

/lgtm

/approve


fastcore.basics.HTTP403ForbiddenError: HTTP Error 403: Forbidden

I have using 'search.issues_and_pull_requests' to look some titles of issues in my repo. Using a for loop, I am getting the titles from a csv file which has around 100 issues. I am getting the following error -- sometime I get the error after the 30th item in the list, sometime when I invoke my script. Any ideas?
File "/usr/local/lib/python3.9/site-packages/ghapi/core.py", line 61, in __call__
    return self.client(self.path, self.verb, headers=headers, route=route_p, query=query_p, data=data_p)
  File "/usr/local/lib/python3.9/site-packages/ghapi/core.py", line 104, in __call__
    res,self.recv_hdrs = urlsend(path, verb, headers=headers or None, debug=self.debug, return_headers=True,
  File "/usr/local/lib/python3.9/site-packages/fastcore/net.py", line 175, in urlsend
    return urlread(req, return_json=return_json, return_headers=return_headers)
  File "/usr/local/lib/python3.9/site-packages/fastcore/net.py", line 112, in urlread
    if 400 <= e.code < 500: raise ExceptionsHTTP[e.code](e.url, e.hdrs, e.fp) from None
fastcore.basics.HTTP403ForbiddenError: HTTP Error 403: Forbidden

Did you figure out how to solve this issue? I am encountering the same problem.

No, unfortunately not. As a workaround, I created a csv file of all the issues then just searched the file instead of using the API.

Sounds like you might be hitting some rate limits from GitHub.


Bing Search V7 create from Terraform fails

This issue is for a: (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
Run azd up and soon after "Terraform has been successfully initialized!" messages
Any log messages given by the failure
│ Error: Failed to retrieve resource
│
│   with azapi_resource.bing,
│   on bing.tf line 8, in resource "azapi_resource" "bing":
│    8: resource "azapi_resource" "bing" {
│
│ checking for presence of existing Resource: (ResourceId "/subscriptions/MY_SUBSCRIPTION_ID/resourceGroups/rg-AgentWithPF202407/providers/Microsoft.Bing/accounts/cog-bing-zdi5ogjjnmzly-uuiy"
│ / Api Version "2020-06-10"): ChainedTokenCredential authentication failed
│ GET http://<IP_ADDRESS>/metadata/identity/oauth2/token
│ --------------------------------------------------------------------------------
│ RESPONSE 400 Bad Request
│ --------------------------------------------------------------------------------
│ {
│   "error": "invalid_request",
│   "error_description": "Identity not found"
│ }
│ --------------------------------------------------------------------------------
│
ERROR: error executing step command 'provision': deployment failed: error deploying infrastructure: template Deploy failed:  , err:failed running terraform apply:  (exit code: 1)
Expected/desired behavior
create Bing Web Search (V7) and register
OS and Version?
working on GitHub Codespaces
Versions
n/a
Additional Info
Trying to deploy to Australia East region

No longer using TF on main


Give me a good idea for use vim

I have a question.
I use vim for programming, and add some plugins to vim nerdtree,pymode and so on.
When i programming, i have to copy some code from "A" file to "B" file sometimes, it's not very convenient.
my action like this.
Ctrl+w + h  select 'B' file and find the code that i need to copy.
Ctrl+w + h  select 'A' file
:number and use p command paste the code.
so are there any way easy to do.

I solved this problem, use vim-airline.


Increase loop-limit and support cancellation of in-flight renders

Pull Request Test Coverage Report for Build 593063835

5 of 5 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.09%) to 79.528%

Totals

Change from base Build 590259121:
0.09%

Covered Lines:
610

Relevant Lines:
761

💛  - Coveralls


Diagnostics Hub Standard Collector service text

Description:
As reported in issue ticket #4164 (Microsoft (R) Diagnostics Hub Standard Collector), the service description text for this particular service on this page is copy-pasted from the preceding service "Local Session manager".
Thanks to @rlappsupport for reporting this documentation issue.
Changes proposed:

Replace the current service description text with the correct one:
"Diagnostics Hub Standard Collector Service. When running, this service collects real time ETW events and processes them."
Correct its name to "diagnosticshub.standardcollector.service"
Correct its Startup type to "Manual" according to factual standard
Rename row names in accordance with actual services.msc names (Service name, Description, Startup type)
Swap order for the "Description" and the "Service name" rows
Whitespace & Layout changes:

Remove all redundant end-of-line (EOL) whitespace (blanks)
Remove redundant blank lines at end-of-file (EOF)
Reduce blank line spacing to max 2 blank lines (from 3 or 4)
Standardize table layout spacing and borders of first column
Standardize cell layout for the blank header row (readability)

I realize that this PR contains a lot of changes and that it may take more time than usual for MS Docs team members to review it. My motivation for making so many changes is for this documentation to be as useful and valuable as possible, for both myself and others, using Microsoft Windows Server 2016 in current production scenarios.
Ticket closure or reference:
Closes #4164

@illfated  I'm trying to find the product group member that can confirm the technical content changes. As soon as I get sign-off, I'll merge this.

Thank you very much for the positive feedback. That is quite all right by me.

@eross-msft : Any luck yet with the search for a product group member to confirm the technical content changes? I am guessing "No", but felt like asking, just in case.

#sign-off

@illfated  I did find the right person to ask, but haven't heard back yet. I'll poke him again to see if I can get a response.

@illfated  Got approval for these changes. Will merge your content now. Thank you!

Thank you for merging the PR, now I get to clean out my old local fork branches on my PC and make new ones. 👍


Hi! Can you please add a license to the pure go version :)

Hi! Can you please add a license to the pure go version? Specifically this file:
https://github.com/keybase/go-tweetnacl/blob/master/go/tweetnacl.go
Thanks 😃

I don't recommend using this implementation.  It's half-baked and likely way slower than the official Go implementation!

That's fair - I have a specific use case / extension where I would prefer to have golang's memory safety for which I have ported over some of the original c code from cr.yp.to to golang. For auditability reasons, it will look quite similar, to the original c code, and thus to this. (Though I think there are some small differences, I haven't checked closely yet). It will be hosted at http://github.com/mooti-dev/RingCT once I finish it. Let me know if you have any concerns.

No concerns, just caveat emptor.  I'll slap a license on it, give me one second.

Ok thank you.


Textures to make lamps mappable to East/West.

Self explanatory...

You’ll need to edit the meta.json for each file and tell it it now has 4 directions.
Copy how it’s done from an existing file but essentially, comma at end of name line, new line with “directions”: 4 with no comma at the end.

Updated

sink textures look wrong, the wide sink and normal sink now look identical, and there's a third texture now? im not sure why those were modified

then imo the 'stemless' sink should be a new entity rather than the old entity being turned into the stemless variant

If the normal sinks need to be rounded more? That can be done.


docs: Update broken links in intro docs.

Motivation and Resolution
In a certain code submission, the 0xs34n field in the link path of the docs was mistakenly replaced with starknet-io, but  the repo does not exist in the starknet-io.
RPC version (if applicable)
...
Usage related changes

Development related changes

Checklist:

[ ] Performed a self-review of the code
[ ] Rebased to the last commit of the target branch (or merged it into my branch)
[ ] Linked the issues which this PR resolves
[ ] Documented the changes in code (API docs will be generated automatically)
[ ] Updated the tests
[ ] All tests are passing

By the date of the last commit it looks to me like both repos are outdated, maybe we should add links to Phil repo os add to docs updated v.?
@ivpavici


Address default bucket type defaults in the absence of riak.conf

See basho/riak#727 (RIAK-1662) (RIAK-1784) for context. Splits out custom bucket type defaults so that the default bucket type, in the presence of a legacy app.config, does not pick up dvv or allow_mult=true.
@russelldb created a test, PR to follow shortly.

:+1: 9b205cf
basho/riak_test#782 passes with this PR applied against 2.0.6

@borshop merge


[WEBP] Transform images when a client accepts image/webp.

More browsers besides Chrome have started to support webp
as image format. To advertise their support, they include
image/webp content type in the Accept header.
This change allows this plugin to detect support for webp
by checking the Accept header and keeps the old User-Agent
check for old versions of Chrome.
Signed-off-by: David Calavera<EMAIL_ADDRESS>

[approve ci]

I've updated the code to fix the clang formatting.

[approve ci]


[FATFileSystem] Updated FatFs to R0.11a & fixed sync bug

Updated ChaN FatFs to R0.11a, and implemented Raghid Mardini's sync bug fix.

Thanks for keeping FatFs up to date, plus including a fix (which could be separate commit :+1: ).

Hi everybody, I implemented Mardini's sync bug fix into my ChaN FatFs R0.11a library. I would understand about the original problem. Which kind of problem this bug fix has solved? I've been working on a USB data logger, and I need to call f_sync () always after a f_write (), but in any cases the f_sync function takes very long time to flush all data (around 800 ms).