new Include files for CLI prerequisites

Docs Build status updates of commit a25cb24:
:clock10: Full build: the average full build time is 8 min(s) 36 sec(s), this is based on the last 872 build(s) for this repository.

Docs Build status updates of commit a25cb24:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/start-azure-cloud-shell.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions-no-H1.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-no-H1.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment.md
:white_check_mark:Succeeded

docs-ref-conceptual/media/cloud-shell-try-it/launch-cloud-shell.png
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/start-azure-cloud-shell.md

Line 14: [Warning-h1-not-first] Markdown content is not allowed before {0}.
Line 14: [Warning-h1-not-first] Markdown content is not allowed before {0}.
Line 14: [Warning-h1-not-first] Markdown content is not allowed before {0}.
Line 15: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 15: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.
Line 15: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 400d91f:
:clock10: Full build: the average full build time is 8 min(s) 37 sec(s), this is based on the last 873 build(s) for this repository.

Docs Build status updates of commit 400d91f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions-no-H2.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-no-H2.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment.md
:white_check_mark:Succeeded

docs-ref-conceptual/media/cloud-shell-try-it/launch-cloud-shell.png
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/start-azure-cloud-shell.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d8a161e:
:clock10: Full build: the average full build time is 8 min(s) 40 sec(s), this is based on the last 875 build(s) for this repository.

Docs Build status updates of commit d8a161e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment.md
:white_check_mark:Succeeded

docs-ref-conceptual/media/cloud-shell-try-it/launch-cloud-shell.png
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/start-azure-cloud-shell.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1b76af8:
:clock10: Full build: the average full build time is 8 min(s) 40 sec(s), this is based on the last 876 build(s) for this repository.

Docs Build status updates of commit 1b76af8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/TOC.yml
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/includes/azure-cli-prepare-your-environment-for-extensions.md
:white_check_mark:Succeeded

docs-ref-conceptual/includes/azure-cli-prepare-your-environment.md
:white_check_mark:Succeeded

docs-ref-conceptual/media/cloud-shell-try-it/launch-cloud-shell.png
:white_check_mark:Succeeded
View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid) View (azure-cli-latest)

docs-ref-conceptual/start-azure-cloud-shell.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


The visual bug when changing slots is still there

Has this issue already been reported? Did you ask for help before making this report?

[X] I have searched the existing issues
[X] I have asked for help

Current Behavior
The visual bug when changing slots is still there
Expected Behavior
.
Steps To Reproduce
.
Frequency
.
Version and Log
.
Anything else?
.

follow the format


Add ITMO University new domain

@mikhov-ivan Pull request merged. Thank you!

Wow! Thanks for the quick response :)


Fix handling of long multi-field documents

This fixes cases when a document has multiple, long fields, and reaches the FEATURE_LEN limit before the last field. This causes it to break out of the inner loop, but not the outer loop and raises an IndexError.

Why do you prefer crashing to truncating?

@gheinrich can you either close this or merge it? As I understand it, it won't matter too much either way.

Hi @skje sorry for the delay, do you mind sending a CLA?

Closing due to inactivity.


feat(api): command executors can add notes

This PR adds an interface for command executors to add notes to the command that they're executing, succeed or fail, and uses that interface to implement an example note warning of aspirate volume rounding.
The interface is done by callbacks from the command implementations to the command executor that is executing each command. Implementations, or the functions they call, are responsible for creating the CommandNote instances. The executor just gathers a list of commands and then issues an UpdateCommandAction with the new list. If there are already notes on the command before execution, the new ones are appended. While this doesn't seem necessary right now, we'll want this behavior generically when we have notes also coming from hardware.
One thing that's a little annoying about this interface is that the callbacks have to be threaded through all the way to whatever wants to add a note. For instance, in the example aspirate-rounded note, we have to pass the callback all the way into the pipetting executor. An alternative would be to have an interface that can add notes on one of the state instances that can be called from anything that can access the state instance. The thing is, that function won't have the context to know when commands are currently executing or are done executing without having some sort of state machine that only looks at UpdateCommandActions from elsewhere. That code would be pretty ugly. The alternative there would be to issue a new UpdateCommandAction for each note; this would have race condition issues if it provided new values for the notes list. The alternative there would be a new action called like AddCommandNoteAction that carries the attention of adding to the notes list along with it. Of course, that command is not idempotent.
This interface works well enough for now that I think we should roll with it, and feel free to change it later.
Still todo

[ ] add tests for actually submitting a new command note

testing (once todos are todone)

[ ] in simulation, request an aspirate that is 0.0000001 ul higher than the pipette max and see the note in the output
[ ] on an executing flex, do the same
[ ] on an executing ot-2, do the same

Closes EXEC-291

Yeah, this fundamental interface looks good to me.
I agree that we don't want command executors to add notes by emitting UpdateCommandActions or AddCommandNoteActions. In addition to the reasons you mentioned, it's nice if we can continue to treat a command's execution as one atomic step that's committed with one UpdateCommandAction.
Re the annoyance of having to pass the callback all the way into the pipetting executor: it does seem doable to me to have something "globally" accessible that knows what the current note target is. It can delegate to CommandView.get_current(); it doesn't have to be a whole new independent state machine that monitors UpdateCommandActions from scratch. We could even wire that up to the standard Python warnings system, maybe.
I agree that this interface is good enough that we should roll with it.

Yeah I honestly don't love the idea of a global callback like that because it gets pretty nonlocal

Spoke privately with Seth about this, I kind of prefer we use AddNoteAction instead of UpdateCommandAction. I feel like there is too much conditional logic for UpdateCommandAction and we know exactly what needs to be done when we dispatch a more specific action.


docs(emitter): adjust documentation for Emitter component

Add more examples and sections to the documentation page for the Emitter component.
Use the notification element to style relevant messages.
Since this page does not have too many sections, it is not necessary to create a summary for an easier navigation.

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     20
  Lines         377    377
=====================================
  Hits          377    377

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11881c1...3dd2181. Read the comment docs.


Adding ascii folding for Polish stemming

I'm quite new to elasticsearch but I got this useful plugin working. Unfortunately I am not able to add asciifolding to it, no matter if I use preserve_original or not.
Is there a possibility to get this plugin working along with asciifolding?

May be you want to have 2 analyzers? So you should use multifield?
BTW, please ask your questions on discuss.elastic.co. You will get a lot more people reading your question and help!


⚠ Bofrost.lu has degraded performance

In a54e502, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.lu performance has improved in 976256e after 41 minutes.


Add "unpkg" field to package.json to link to minified version

On the Tippy.js website under CDN, it would be nice to have consistent formats

May you link me to the docs about this unpkg field? What's its for?

https://github.com/stereobooster/package.json#unpkg
A "bare" import like https://unpkg/popper.js@1 will link to the minified version by default. A lot cleaner when using the CDN version

I see, thanks!


Enable video trimming for all users

Feature Description
Once the feature is completed and approved, enable video trimming feature flag for all users.
Make sure the feature is properly covered by both unit and integration testing.

Verified in QA


Error when installed globally, not in .venv

When installing globally on Windows without environment
pip install sphinx-performance

-> on running sphinx-performance there is the following error
...
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\sphinx_performance\projectenv.py", line 250, in install_dependencies
subprocess.call(dep_command, stdout=subprocess.DEVNULL)
It seem like the correct paths are not calculated correctly.

Thanks for the bug report.
Is in the logs also an Exception type or a traceback mentioned?
I can only guess, but maybe the pip command is not in the same folder as the python command.
Or some rights are missing. Tough one...

Full stack trace here:
Traceback (most recent call last):
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Users\kuempel\AppData\Local\Programs\Python\Python39\Scripts\sphinx-performance.exe_main.py", line 4, in
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\sphinx_performance\main.py", line 213, in
cli()
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\click\core.py", line 1128, in call
return self.main(*args, **kwargs)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\click\core.py", line 1053, in main
rv = self.invoke(ctx)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\click\core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\click\core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\click\decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\sphinx_performance\main.py", line 113, in cli
project.install_dependencies()
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\site-packages\sphinx_performance\projectenv.py", line 250, in install_dependencies
subprocess.call(dep_command, stdout=subprocess.DEVNULL)
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\subprocess.py", line 349, in call
with Popen(*popenargs, **kwargs) as p:
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\subprocess.py", line 951, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "c:\users\kuempel\appdata\local\programs\python\python39\lib\subprocess.py", line 1420, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] Das System kann die angegebene Datei nicht finden

python.exe and pip.exe are located here (default on Windows ?)
"C:\Users\kuempel\AppData\Local\Programs\Python\Python39\python.exe"
"C:\Users\kuempel\AppData\Local\Programs\Python\Python39\Scripts\pip.exe"

I have published a fix on the "main" branch.
I hope this fixes the problem for all uses cases.
Can you please give it a try by installing it from sources?
Thanks.

Sorry for the late response. It's not working, since your check is looking for pip only (it's pip.exe on windows)
FileNotFoundError: Could not found "pip" in calculated path: c:\users\kuempel\appdata\local\programs\python\python39\Scripts\pip


ripgrep-all: Doesn't explicitly reference dependencies such as zip/unzip and tesseract

Describe the bug
The package doesn't install all dependent applications for file formats that it supports searching across, so if installed on a minimal system it issues errors.
To Reproduce
Steps to reproduce the behavior:

on a minimal system: nix-env -i ripgrep-all
run rga to search across a directory with ZIP archives within. Will get the following error:

-------------------------------------------------------------------------------
adapter: zip
Error: Unsupported Zip archive: The file length is not available in the local header
-------------------------------------------------------------------------------

Expected behavior
Expectation is that ripgrep-all would bring in all dependent applications and not rely upon global or independent installation for it to work.
Screenshots
$ rga test .
./parse-san.zip: preprocessor command failed: '"rga-preproc" "./parse-san.zip"':
-------------------------------------------------------------------------------
adapter: zip
Error: Unsupported Zip archive: The file length is not available in the local header
-------------------------------------------------------------------------------
$

Metadata
$ nix run nixpkgs.nix-info -c nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 4.19.81, NixOS, 19.09.1476.72a2ced2523 (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3`
 - channels(root): `"nixos-19.09.1019.c5aabb0d603, nixos-hardware"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
   - ripgrep-all

The (known) missing dependencies are tesseract, pdfpages, sqlite, tar, decompress, and zip. Adding tesseract alone would likely increase the closure size of the package significantly.
Do users of ripgrep-all expect all of its supported adapters to be available? I'm assuming that on other distros, users install the dependencies for the adapters they want to use. I see a few possibilities:

Add the dependencies to support all the adapters.
Create a "full" package which features support for all the adapters.
Apply a patch which forces ripgrep-all to look for executable dependencies in /run/current-system/sw/bin/. This should allow users to install executable dependencies (like zip), similar to how they would do in other distros.

Pinging the maintainer @zaninime for insight.

Point 3 is already there. rga will look for executables in the $PATH, so it shouldn't necessary to pin it to a folder (especially since there are multiple ways to install binaries).
Point 1 and 2 can be made available by doing something similar to what's done here: https://github.com/NixOS/nixpkgs-channels/blob/7d5375ebf4cd417465327d7ab453687fd19663c9/pkgs/applications/science/robotics/gazebo/default.nix#L11
...by then using makeWrapper and prepending to the $PATH the selected binaries. That would also allow for overriding through an overlay.

Thank you, @zaninime
@marcb , I'll create a PR, but it will be merged into the master branch. If you need this backported to NixOS Loris (19.09) let me know so I can request it in the PR.

Note: The error about the unsupported zip file is not due to a missing dependency, but rather due to the Rust zip library used by ripgrep-all. See https://github.com/mvdnes/zip-rs/issues/108

Thank you, @zaninime
@marcb , I'll create a PR, but it will be merged into the master branch. If you need this backported to NixOS Loris (19.09) let me know so I can request it in the PR.

I don't think it needs back porting… happy to wait.

Do users of ripgrep-all expect all of its supported adapters to be available?

It might be related to the name of the package but my expectation was for all to be supported due to its name ripgrep-all…

Do users of ripgrep-all expect all of its supported adapters to be available?

tesseract is not enabled by default since it is very slow and not useful most of the time. All the other deps are used by default.


Evaluate Tool Direction and Useability

Do the views and statistics make sense?
Are there obvious things missing that researchers will use?
How should the tool let you access the data?

Should you be able to directly download?
How should bulk retrieval be handled if requested from multiple domains?
What would a search interface and it's response look like (Table, graph, icicle, combination, etc...)?

How should the current views be accessed?

Main page with search and UI nav on top for specific type views?  (Sensible?)
Land on genome type view, navigate from there?
Force type selection, then navigate from there?

How would one get to this page?

How does it link from the new LegFed?

How would one use the tool to do something interesting?

IGV
File Discovery Using Label(s), FileName(s) and Relationship(s)
Assembly and Annotation Global Stats Comparison
Linkouts

Cyverse (if available)
IGV
Other visualizers?
Intermine for the organism?
Intermine gene lists?

thanks Connor, this looks like a great set of questions to serve as a driver for the grand premiere. hope I did not seem too hesitant to put your work on display, I really just wanted to get people thinking about the question of how to put new stuff out in such a way that it has the maximum likelihood of having an impact...

Not at all.  I think there are still many questions.
In fact, I think I realized a major issue on the call today when we were talking about what it can display vs what it can search.  I think the main interface needs to be able to display a variety of file types in some simple but interesting way to the user (easier said then done, but I think I have some ideas) that is searchable and takes advantage of the graph and the dynamic search aspects.  The file type specific views are then selectable from the nav UI, and/or searchable based on type and/or taxa/whatever labels (but not a mix of file types).  Currently I really only use the graph on the frontend to do the discovery for the IGV visualization and get the data to load the page, but the API can do much more than this.
I think this is a sensible direction.


debugging threads doesn't work in Spyder

Problem Description
I am trying to debug one of my multi-threaded programs in Python 2.7 with Anaconda distribution on Spyder 3.2 (latest release came from Anaconda package)- when the threads are started, IDE is unable to hit any breakpoints and the program runs in normal mode cannot do step by step debugging either.

the same issue I observed in Pycharm as well. however, if I change the python version from Anaconda to normal python which is again ver 2.7, it works perfectly fine in pycharm. The same in Spyder as Ipython and cloud pickle was there.

What steps reproduce the problem?

check any multi-threaded program in Anaconda installation in spyder, try to debug step mode after threads are started.
the same program if you run in a pure python (not Anaconda distribution) and different IDE it works fine.

What is the expected output? What do you see instead?
Unable to hit break-points after threads are started
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version: 3.2
Python version: 2.7
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

check any multi-threaded program

Please post a simple code example that we can run and test in our side. Thanks.

Closed due to lack of response. If you can provide more information, please re-open and do so. Thanks.

Hello, Spyder3 v3.3.1 (on Arch linux), breakpoint on line print("thread started.") doesn't hit.
import threading

class MyThread():
    def start(self):
        self._thread = threading.Thread(target=self.run)
        self._thread.start()

    def run(self):
        print("thread started.")

def run():
    myThread = MyThread()
    myThread.start()

if __name__ == '__main__':
    run()

Thanks for attention to this.

Thanks for the reproducible example, @KestutisMa . I can get the breakpoint to trigger, but it then exits. The fundamental problem is that pdb/ipdb does not work properly in multithreaded code, which AFAIK is not really possible to fix from our end without replacing ipdb. Fortunately, we are doing just that for Spyder 4 by adding a full debugging kernel, so it might be possible to do so in the future. @dalthviz , can you comment further on this?

Spyder3 v3.3.1

FYI, the current version in the 3.x stable series is 3.3.3 (with 3.3.4 about to be released), which contains numerous bug fixes and minor improvements, as well as major enhancements to saving and reloading sessions in spyder-kernels. 3.3.1 is many months old now, so its high time to upgrade.

I think that maybe it could be possible to manage debugging with multiplethreads by using set_trace explicitly in the code you are running. For example, you will need to put in the run method something like:
def run(self):
    import ipdb; ipdb.set_trace()
    print("thread started.")

@dalthviz I had tested pdb.set_trace() and breakpoint() as well, and again debugging stopped at the breakpiont but immediately excited with bdb.BdbQuit.

On Spyder 4.2.5 the command import pdb; pdb.set_trace() works and the debugger enters the thread. Thanks to @dalthviz for the advise.
Anyway I had to use pdb and not ipdb...

On Spyder 4.2.5 the command import pdb; pdb.set_trace() works and the debugger enters the thread. Thanks to @dalthviz for the advise. Anyway I had to use pdb and not ipdb...

On Spyder 5.4.1 the command import pdb; pdb.set_trace() still not works, how do you solve it?

FWIW, testing in Spyder 5.3.3 on Windows via Conda-Forge, with Python 3.9.4 and Spyder-Kernels 2.3.2 in the console working env and 3.9.12 in Spyder's runtime env, running either import pdb; pdb.set_trace() or breakpoint() works fine with Run File, Run Cell, and Run Selection with a minimal reproducible example (as well as more complex cases):
print("Test 0")

print("Test 1")

import pdb; pdb.set_trace()

print("Test 2")

print("Test 3")

Can you reproduce the issue running this minimal reproducible example? If so, could you please provide the following:

Paste the version info provided by the Copy version info button in the Spyder About dialog
The version of Python (import sys; sys.version) and Spyder-Kernels (import spyder_kernels; spyder_kernels.__version__) in the Console you're using
Exact steps to reproduce the error (e.g. how did you run the code)
The precise behavior you saw when you did so, compared to what you expected

Thanks!


fix #98 - with test

This fixes https://github.com/bitovi/syn/issues/98

Looks good!

3 Questions:

Can I merge?
Would this be a version increase?
How do we increase the version?

Yeah, go ahead and merge this as is, i'll walk you through doing a release.


Slow kudzu growth

About the PR

Kudzu growth was unfun to fight, and spreads way too quickly. This will still occupy people's time, and can still be a pain to fight, but should actually be possible to deal with a bad kudzu growth now.
Why / Balance

Kudzu grows way too fast, this slows it down considerably.
Resolves #18021
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Slowed the speed at which kudzu spreads.

Resolves https://github.com/space-wizards/space-station-14/issues/18021 ?

Oh I didn't see the issue, yeah it should resolve it since this makes it significantly slower, but it will still require a handful of people to  fully clear it if it isn't discovered early.


Visual shader node editor to come back?

In my first little round of testing with Godot 3, I noticed that we were back to more complex shaders being done by way of scripting only with no node-based shader builder like in Godot 2.1.
Is the Visual Shader Editor slated to come back, I find it very useful for cases like creating a terrain shader (with multiple textures) and other things such as using a colored black and white texture (which allows one to save space since they can have an unlimited combination of colors for use in many different materials)? There's also the whole thing of allowing a lot of different textures for additional detail.
That node-based workflow might work even better now with the improvements made for the visual logic editing, any chance that the VSE will be back in 3.0 final?

Yes, will eventually come back
On Apr 13, 2017 9:03 PM, "Ace-Dragon"<EMAIL_ADDRESS>wrote:

In my first little round of testing with Godot 3, I noticed that we were
back to more complex shaders being done by way of scripting only with no
node-based shader builder like in Godot 2.1.
Is the Visual Shader Editor slated to come back, I find it very useful for
cases like creating a terrain shader (with multiple textures) and other
things such as using a colored black and white texture (which allows one to
save space since they can have an unlimited combination of colors for use
in many different materials)? There's also the whole thing of allowing a
lot of different textures for additional detail.
That node-based workflow might work even better now with the improvements
made for the visual logic editing, any chance that the VSE will be back in
3.0 final?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/8397, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z23TB4lm9wNYHbMUiNNIssBoaycbuks5rvnGFgaJpZM4M9FP7
.

but nor for 3.0, we are out of time. Will have to be for 3.1

Are 2.1 visual shaders usable in 3.0, then? (as in, are they converted somehow to a format that 3.0 understands?)

@Zireael07 No, shaders in Godot 3.0 are incompatible with 2.1, as they changed the way they work considerably. They will need to be rewritten

Well, visual shader editor is implemented to 3.1. Closed


Update the headings and body font on the ODK-X Survey and Tables app to meet the ODK-X design Guidelines.

You're good to go with this!

Hello @Redeem-Grimm-Satoshi !
How are you doing ?
I’d like to tackle the font update issue (#498) to align with the ODK-X design guidelines. This will significantly improve the app’s usability and aesthetics. Please assign me this issue!
Best,
Collins HAYA


Renaming file, causes deletion

Hi, I have a model with a file field and a char field representing the name of the file.
on model.save() im renaming the file.name attribute to match the name attribute of the instance.
This causes file deletion when using django-cleanup.
Any way to prevent this?

This turned out to be an issue with the s3 storage class I'm using (django-storage) which doesn't support file renaming/moving.
Although looking at the code, I think it would be caused on regular storage as well.
Anyway, closing.


adding participation in studies on main page

Per Anna's suggestion during lab meeting, it would be nice to have a easy way for visitors to navigate to the study participation page from the main page!

I realized this was already implemented!


Swagger Strategy

Hi,
When I use the the swagger strategy, my endpoint spits this out:
{
  "apiVersion": "0.1",
    "swaggerVersion": "1.2",
    "resourcePath": "/users",
    "produces": [
      "application/json"
      ],
    "apis": [
    {
      "path": "/users/me",
      "operations": [
      {
        "notes": "",
        "summary": "Return the the authenticated User",
        "nickname": "GET-users-me",
        "method": "GET",
        "parameters": [],
        "type": "void",
        "authorizations": {
          "oauth2": []
        }
      }
      ]
    }
  ],
    "basePath": "http://api.rails-app.dev:3000"
}

However, "authorizations": { "oauth2": [] } isn't correct.
It should look something like this (more info on auth spec here).
  "oauth2": {
    "type": "oauth2",
    "scopes": [
      {
        "scope": "email",
        "description": "Access to your email address"
      },
      {
        "scope": "pets",
        "description": "Access to your pets"
      }
    ],
    "grantTypes": {
      "implicit": {
        "loginEndpoint": {
          "url": "http://petstore.swagger.wordnik.com/oauth/dialog"
        },
        "tokenName": "access_token"
      },
      "authorization_code": {
        "tokenRequestEndpoint": {
          "url": "http://petstore.swagger.wordnik.com/oauth/requestToken",
          "clientIdName": "client_id",
          "clientSecretName": "client_secret"
        },
        "tokenEndpoint": {
          "url": "http://petstore.swagger.wordnik.com/oauth/token",
          "tokenName": "access_code"
        }
      }
    }
  }

This started when I posted this issue https://github.com/ruby-grape/grape-swagger-rails/issues/13 on grape-swagger-rails saying that entering an api key would not add it the requests. We believed it was a problem upstream with swagger ui but a maintainer mentioned that the syntax was not swagger compliant (see: https://github.com/swagger-api/swagger-js/issues/555).

Thank you. I will look into that.

no problem @antek-drzewiecki . if you can help me triage this (where the bugs are), i'm happy to put some time in time to get it fixed.

You got a good point there. There is currently no way to define the base swagger documentation with the correct authorization methods except for manually. Currently what I do is define it manually.
This is what ive added to my API description.
class API < Grape::API
  format :json
  use ::WineBouncer::OAuth2

  SITE_URL = 'https://www.my-cool-website.com' # Put this in an initializer or somewhere else then here

  rescue_from WineBouncer::Errors::OAuthUnauthorizedError do
    Rack::Response.new(
        {
            id: 'unauthenticated',
            message: 'Request failed because user is not authenticated.'
        }.to_json, 401, 'Content-Type' => 'text/error').finish
  end

  oauth2
  get :hello do
    { hello: "world" }
  end

  add_swagger_documentation base_path: '/api',
                            format: :json,
                            authorizations: {
                                oauth2: {
                                    type: :oauth2,
                                    scopes: [
                                        {
                                            scope: 'EDIT ME: the scope name',
                                            description: 'EDIT ME: a scope description'
                                        }
                                    ],
                                    grantTypes: {
                                        implicit: {
                                            loginEndpoint: {
                                                url: "#{SITE_URL}/oauth/authorize"
                                            },
                                            tokenName: 'access_token'
                                        },
                                        authorization_code: {
                                            tokenRequestEndpoint: {
                                                url: "#{SITE_URL}/oauth/token",
                                                clientIdName: 'client_id',
                                                clientSecretName: 'client_secret'
                                            },
                                            tokenEndpoint: {
                                                url: "#{SITE_URL}//oauth/token/info",
                                                tokenName: 'auth_code'
                                            }
                                        }
                                    }
                                }
                            },
                            models: [] # optional models

end

Given your git repository at : https://github.com/whatasunnyday/gsr-api-key/blob/master/app/api/api.rb
Will this give the correct swagger docs?

That looks really good. As a temporary workaround, I've done something a bit simpler.
        desc 'Return the the authenticated User', {
          detail: 'Useful test to see if the client is '\
          'correctly authenticated.',
          entity: User::Entity,
          http_codes: [
            Errors::Unauthenticated.http_code
          ],
          headers: {
            'Authorization' => {
              description: 'OAuth Bearer token used for authentication.',
              required: true
            }
          }
        }
     get '/' do
        ...
     end

This gives me a field to add my access token to send in the header in the swagger docs.

Nice one, this also makes sense. The downside it that you need to paste the access token across all endpoints you are using. This can get nasty when you have 20 endpoints to consume.
I am trying to reproduce your description with, authorizations: { oauth: [] } but no success. maybe im running different gemsets.

Do you want me to update anything on gsr-api-key? I was hoping that would make it easy to reproduce. Or the test case here: https://github.com/ruby-grape/grape-swagger-rails/pull/25
Let me know what you're trying to reproduce. I will happily provide a minimal test case.

@whatasunnyday , i think there has been some confusion before.
Swagger spec describes resource listing and API Declaration witch both have authorisations objects. The link and code snippets you described were for the resource listing authorisations spec.
In case of OAuth2, this object describes the global OAuth2 configuration such as your authorization server endpoints.
I guess the actual problem is the (API Declaration authorisations spec)[https://github.com/swagger-api/swagger-spec/blob/master/versions/1.2.md#52-api-declaration]. In that case authorizations: { oauth2: [] } is a perfectly valid spec. Since it expects an array of tokens.

Yes, that was definitely the case. Thanks. As for the global authorization object, I'll think through a strategy for integrating it into wine_bouncer.

I got the same problem as @whatasunnyday.
In the thread, it's not clear if you find a solution or not.

hey @abarre, there is currently no solution other than work around described above (passing headers key in second desc arg) or passing authorization override to add_swagger_doc.

Ill try to create an helper method to add the missing information to the swagger_docs.
Thats the best i could do on short terms


Added connectctl

Adding 90poe/connectctl to godownloader:
https://github.com/90poe/connectctl

can you merge with master?


feat: add scraping of deployment count metrics

TODO:

[x] - setup a prometheus example and implement basic scraping
[x] - use labels for the deployment count to partition data by pod name
[ ] - solve circular dependency issue with the TLS cert

Issue:
I currently have a circular dependency between prometheus and doozie-exporter. The TLS cert for /metrics has to be loaded as a secret into the namespace where prometheus runs, so that it can trust the cert. The cert is generated in the koozie-exporter chart. To work around this, I comment out the service monitor on the first deploy and then comment it in.

Issue:
I currently have a circular dependency between prometheus and doozie-exporter. The TLS cert for /metrics has to be loaded as a secret into the namespace where prometheus runs, so that it can trust the cert. The cert is generated in the koozie-exporter chart. To work around this, I comment out the service monitor on the first deploy and then comment it in.

Issue:
I currently have a circular dependency between prometheus and koozie-exporter. The TLS cert for /metrics has to be loaded as a secret into the namespace where prometheus runs, so that it can trust the cert. The cert is generated in the koozie-exporter chart. To work around this, I comment out the service monitor on the first deploy and then comment it in.

I think cert-manager is a proper solution to this problem.


style: Make code flake8 compliant

Applies simple changes to make tox -e flake8 pass

Feeling good about getting this merged in?

Go for it :)


feat: add elasticsearch module

Adding elasticsearch module.

Awesome, thanks @matthewbpt ! Lemme know if you're happy for me to merge/release 🙂

Hi @cristianrgreco I'm happy for you to merge and release this :+1:

Available in 4.4.0 (https://github.com/testcontainers/testcontainers-node/releases/tag/v4.4.0), thanks again!


! Balena Cloud not installed. Using git push. ERROR

On nodeJS in can happen because the balenaCloud binaries only support until Node NPM v19.
Use version below 20, nvm use 19 and retry ./deploy.sh script to publish to balenaCloud

Balena Cloud now supports v20 of node nvm use 20


debug method does nothing

No really, it does nothing...
require.register("browser/debug.js", function(module, exports, require){

module.exports = function(type){
 return function(){
 }
};

}); // module: browser/debug.js

eh, this is generated code and not really worth the effort to remove. That said, a simple PR (not something that slices up an AST) would be acceptable. I'm closing in the meantime, but will reopen if someone wants to address it.

@tonylukasavage Not something I am willing to PR at this point. but FWIW the reason this is an issue is not to remove it, but because mocha tries to for debugging.  So it should really use console.log or something

@mattapperson I see what you're saying, but in the case of ti-mocha, the only supported reporters are the ones in the repo right now, and they don't leverage debug(), so it's not an issue. That said, again, I'm fine with a PR that would in theory make ti-mocha more compatible with existing reporters in mocha.


Add RTSP VP8 Reader test

A general question before start reviewing: why there are changes to the VP8 reader? Is it adding new feature, or is it a bug fix?

 And we have added the test as a separate commit.

In that case can you share some details on what the bug is in writing?
 And we have added the test as a separate commit.
—
Reply to this email directly, view it on GitHub
https://github.com/androidx/media/pull/101#issuecomment-1172182359, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUCMUUURWINKT37FQPG5VZLVR275PANCNFSM52ID5FWA
.
You are receiving this because you commented.Message ID:
@.***>

Created a new PR, abandoning this PR.
I have updated the Fix VP8 Reader commit with relevant bug id and description.


add a moped symbol

for

prohibtions C09/C13/C15
designations G12 a & b

and various other signs

Thanks!


Set auto-repair=true by default for health check monitors.

/cc Random-Liu

/ok-to-test
/lgtm
/approve


API_KEY

@polok thanks for this nice library.
What about a option to pass the API_KEY?
You could add an alternative constructor to RouteRest like RouteRest(String apiKey) so that we can pass our API_KEY from outside.
Thanks.

Hi @sonerd
👍 for idea. Unfortunately, to the end of this month I am out but I will have a look in June.
Regards,

hi @polok you are welcome,
one other thing.
when you want to add the API_KEY feature then you have to use https as protocol.


Bug. Orange banner flashing issue in the Data tab on Android and iOS

Issue: Orange banner flashing issue in the Data tab on Android and iOS
Steps: Make sure your COVID Alerts is not working. Then go to COVID Data tab. Get out of the app and then get in again.
ScreenRec_20200911_154958.mp4.zip

@helloantoine Can you validate this in the next build?

I cannot reproduce this. Well done.


Fix move namespaced constant in Style/ConditionalAssignment

Fix autocorrect for moving constant assignment outside the condition
when the constant is in a namespace, e.g. from:
condition ? FOO::BAR = 1 : FOO::BAR = 2

if condition
  ::FOO = 1
else
  ::FOO = 2
end

to keep the namespace Foo:: and the top-level :: in correction:
FOO::BAR = cond? ? 1 : 2

::FOO = if condition
  1
else
  2
end

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


Auto import doesn't work at first attempt, I need to delete and re-type component name, also doesn't add to components

Auto import doesn't work at first attempt, I need to delete and re-type component name. And also doesn't add an object to components:
https://github.com/vuejs/language-tools/assets/5052406/a808f185-0a77-4f77-ab19-eab4381e1f4b

Please upgrade to the latest version and check if components.d.ts is generated correctly. If the error still happens, please share a minimal reproduction project. Thanks!


fix the command output

I have verified on version v1.11

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please delete this note before submitting the pull request.
For 1.12 Features: set Milestone to 1.12 and Base Branch to release-1.12
Help editing and submitting pull requests:  https://deploy-preview-9510--kubernetes-io-master-staging.netlify.com/docs/contribute/start/#submit-a-pull-request.
Help choosing which branch to use, see
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@tanshanshan If we now look back at your recent PRs (#9946, #9949, #9950, #9951, #9952, #9954, #9955, #9956, #9957, #9958, #9965, #9966, #9969 ...) do you think we should have considered combine several changes into fewer PRs?

It is ok, thanks .@tengqm

/approve for docs review
@tengqm can you add the lgtm? I think the multiple PRs are OK -- preferable to rolling them all into one, at least.

/lgtm

/approve


rbd: add support for CloneImageByID()

RBD image groups can be used to create consistent snapshots of all images that are part of the group. The new rbd_clone4() API makes it possible to create a new RBD image from a single snapshot that was created as part of the group snapshot.
Note about testing status
The rbd_clone4() API has only just been backported to Squid for version 19.1.1. There are no (public) container images available yet that contain this new API. This PR currently lacks any tests, and is marked as Draft for the time being.
Checklist

[ ] Added tests for features and functional changes
[ ] Public functions and types are documented
[x] Standard formatting is applied to Go code
[x] Is this a new API? Added a new file that begins with //go:build ceph_preview
[ ] Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

Early feedback: can you please name the file after the feature and not a ceph version. This has caused confusion in the past (literally yesterday in #999) and isn't strictly needed. Something like clone_image_by_id.go would be fine IMO. Additionally, if you think it'll only be available for squid initially let's have build tags excluding it from pacific, quincy, and reef too - at least for now.

Tests seem to run in squid and main:


[synthesis] Preparations for ASIC synthesis flow using DC

This PR introduces a couple of preparatory changes to introduce a Synopsys DC based synthesis flow in an upcoming PR. In particular:

The common.core imported an interface to be used in DV only, and DC doesn't like it. Hence this has been moved to the corresponding DV core where it is actually needed.
Add the ImplAsic option to all tech-dependent macro wrappers.
Add the ASIC_SYNTHESIS ifdef around some of the assertions to make this pass in DC. This requires a slight change in the FPV flow (basically not defining the SYNTHESIS related macros).
Replace some invocations of $fatal with assertions.
Add the ASIC synthesis target to top_earlgrey.core

Squashed and signed-off.

LGTM!

Please don't merge yet, I would like to check this out, hopefully by EOD
On Thu, Dec 19, 2019 at 1:11 PM tjaychen<EMAIL_ADDRESS>wrote:

@tjaychen commented on this pull request.
In hw/ip/prim/rtl/prim_assert.sv
https://github.com/lowRISC/opentitan/pull/1235#discussion_r360118683:

`endif

// Assume an immediate property
define ASSUME_I(__name, __prop)                                       \  ifndef VERILATOR
+`ifndef SYNTHESIS                                                      \
Yeah something along those lines, so we can concentrate the nested ifdefs
in one place.
I don't think that needs to be this PR though, it was just a suggestion.
There may be other cleaner ways also.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/1235?email_source=notifications&email_token=AJZQKVKCQBOFLOJ6L4HEISLQZPPPLA5CNFSM4J4YBSPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP3K4AA#discussion_r360118683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJZQKVKI7JHOLRY2FC3RSVTQZPPPLANCNFSM4J4YBSPA
.

Thanks for getting this started. Did you forget to add all prim_asic files?

@msfschaffner
i think the omission of those files is intentional.  The idea being we allow a way to call asic implementations...but we don't actually expose what those asic implementations are in the open source
(not even the port names).  So i know this feels a little....redundant since that's what the prim_* is already for, but I think this was @msfschaffner 's way doing it without exposing information only certain partners have.
I think we can also argue that another way to do this is for someone to vendor in the project, and patch replace all the prim files in their local, non-public repo?

Thanks for all the feedback so far.
@imphil I've amended prim_ram_2p_*_adv such that it supports both register and sram implementations, and I've added stubs for the prim_asic* wrappers such that everyone can adapt them to their target technology.
@tjaychen I've reworked prim_assert as discussed above.

Ah, now I understand your plan. (I first thought the prim_asic primitives were a generic, synthesis-only ASIC target.)
For technology-specific ASIC libraries, I suggest not using a single prim_asic library, but actually distinguish them by name to make them shareable and easily recognizable. That would be prim_tsmc40 for example, or even something more specific like prim_tsmc40lp....
The implementation idea for this feature was:

Set ImplType to the desired target matching the prim_* name, e.g. "tsmc40"
Drop target-specific prim_* libraries into the fusesoc search path (as long as they cannot be part of the repository) and then regenerate the abstract primitives (prim/abstract) based on what implementations are found.

Step 2 requires #79, I'll work on this feature this week.
In the meantime:

Rename prim_asic to prim_tsmc40 or something similar.
Include that new primitives library in the abstract primitives like all other primitives (only if modifications over the generic primitives are needed, so for now most likely only memories and clock gating primitives).
Don't check the prim_tsmc (or whatever they'll be called) primitives into this repository. Create a separate one or leave them locally somewhere.
When calling fusesoc, call it with --cores-root=. --cores-root=path/to/your/prim.

Yeah that makes sense, but not everybody will be able to disclose the process name and check that into the open repository. So the prim_asic can be seen as a template that can be used to locally set up a DC flow for a specific technology (and those prims may be named differently).

Some thoughts after a chat with Michael yesterday:

Can you put all non-related changes into separate commits? This includes changes to the assert macros and defines, spelling fixes, the new MemT parameter in prim_ram_2p_adv.sv etc. These changes are largely uncontroversial and independent. Splitting them out helps to get them into the repository faster and reduces the size of this PR.
If we want to keep the technology name out of the repository we need dynamic discovery, i.e. #79 and follow-ups; I don't really see a way around that except the use of a generic "asic" name for all kinds of tech libraries, which I really dislike even as interemdiate solution. (Because it is confusing: two people talking about prim_asic can mean totally different implementations.)
With that in mind, I don't think we gain much at the moment by adding the prim_asic templates. They are not really useful to us, or to anybody else. (Other primitive implementations, such as the generic ones, are already a good starting point for porting to a new ASIC technology.) Instead, I'd suggest to keep the necessary changes in a local tree/repository on your machine for now to get the synthesis flow bootstrapped, and full integration can then happen once we have dynamic discovery, hopefully in the next week or so.

I completely agree with your points @imphil - I actually wasn't aware of #79, that sounds like a really handy feature.
Let me clean this up.

Ok, I've deleted the prim_asic templates and moved all un-related changes into PR #1287. I am still leaving this one open such that we can iterate on it for full integration of the DC flow.

@imphil, what is the status of https://github.com/lowRISC/opentitan/issues/79? it would be great if we could make progress on the synthesis side. sorry I am a bit out of sync with what has been going on lately :).

ping :). any updates? or could we unblock this and introduce #79 at a later stage? it would be great if we could move forward with this one, especially in light of upcoming development...

Ok that would be great, because it sort of becomes a blocker very soon (we can work around for now). Thanks!

abandoning this PR, as it is about to be replaced with a fresh one.


Backup skip logic

Dev app v1.7.0 (286): "Backup Skip" functionality working as expected. Hence, closing this ticket.


Convert time.Time to int64

This changes converts all the uses of time.Time to int64 within the TSM engine.  This was an idea initially presented in #5522, but didn't make sense to implement until query engine and other changes had completed.
Since we mainly using timestamps as UnixNano values anyways, the overhead of using a time.Time everywhere ends up creating a lot of garbage for GC to work though.  This change should help with GC and larger queries that process a lot of points.
A simple count query over 100M points improved from 53s to 38s with this change.
$ time influx -database stress -execute "select count(value) from cpu"
name: cpu
---------
time	count
0	1e+08

real	0m52.670s
user	0m0.006s
sys	0m0.006s

After:
$ time influx -database stress -execute "select count(value) from cpu"
name: cpu
---------
time	count
0	1e+08

real	0m38.107s
user	0m0.005s
sys	0m0.006s

[ ] CHANGELOG.md updated
[ ] Rebased/mergable
[ ] Tests pass
[ ] Sign CLA (if not already signed)

@benbjohnson

lgtm. :clap: That's a nice 14s drop in query time!

:+1: nice refactoring


No edit button?

On https://hutchdatascience.org/FH_Cluster_Guide/feedback.html it says

Please submit an issue about this course at our GitHub repository. You can also click the edit button on the top of the page in question.

But there is no edit button.

Never mind, found it

Reopening this because the edit button takes


Change Prometheus exporter's ByteArrayOutputStream to ByteBufOutputStream

Motivation:

I saw some of my service has few MB of exported response. Maybe better to make it ~async~ and not converting to single byte[]
Modifications:

Using ByteArrayOutputStream and HttpData.wrap

Result:

Avoid creating single large byte[] explicitly. Especially if ctx.alloc uses direct buffer.
~Reduce the chance of blocking request executor. e.g. JvmThreadMetrics#getThreadStateCount is using ThreadMXBean#getThreadInfo and it's might be an expensive operation.  (maybe not that impact)~

updated.

Switch back to eventloop and using ByteBufOutputStream first. I think it's better then use ByteArrayOutStream?

@anuraaga
I checked the code of
https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmThreadMetrics.java#L91
Due to Gauge builder build each tag separately, I think it's not possible to call getThreadInfo once and generate multiple gauge using existing API?

@kojilin didn't try to compile the code But can't you move the getThreadInfo call outside the loop and do the filtering based on that result rather than calling it each time in the loop?

I see - it's because it's in the callback :( Wonder if there is any mechanism to allow multiple recording with different tags. Would be good to file an issue as the perf is definitely significant

updated.
Using the same pattern like StreamingHttpFile that using success flag to decide if release or not.

Just curious why not release in catch block? or it's just the choice.
Try to find other place for similar release way. And saw https://github.com/line/armeria/blob/master/grpc-protocol/src/main/java/com/linecorp/armeria/internal/common/grpc/protocol/GrpcTrailersUtil.java#L70 , is this safe to returned released buffer and continue the process?

FYI
the 1st graph is 11.0.10(centOS) and 2nd graph is 11.0.6(adopt)

The ratio of getThreadInfo is reduced after upgrading to 11.0.10. But it still dominates the most part of collect.

Thanks, @kojilin ❤ and reviewers!


As a Developer, I want to be able to view what poems are being clicked on, so that I can see what poems are popular.

User Story
Size: This issue was sized as medium.
Priority: This issue was ranked priority #12.
I feel that this should be added to the sprint because it's better to work analytics into the code right from the start rather than having to go back and add it later. Also, we'd want to start collecting data even if we published an early version of the site, rather than waiting until the site is complete.

Task Branch Name: Lauraanalytics
I added a Tracking ID for Google Analytics, as well as some sample poem pages so that there are actual working links to click on.


Support Vite v5

Added Vite v5 to peer dependency version range.
Upgraded Vite from v4 to v5 in devDependencies.

@hmsk Would be awesome if you can find time to review/merge this PR.

Thanks for your contribution! I just published a new version https://github.com/hmsk/vite-plugin-markdown/releases/tag/v2.2.0-3 which accepts vite@5. will serve via the release channel after some cleanup and tests.


Suggestion: Global Layers

I think a good addition would be layers that get applied to every program.
For example, I have a layer that turns the caps lock key red when it's on, and I'd like it to be applied to every application.

This will be possible with the new Overlay/Underlays system which is planned for v0.7.0. I'll leave this open as a reminder for the option to have Overlays/Underlays always active.

This has been implemented as of v0.7.0 with desktop overlays.


Refactor get_age in util/dt

Description:
Refactor of util/dt.py
Checklist:
If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

:+1: :+1: :+1: :+1: :+1: :+1: @Danielhiversen. Gonna merge this because tests passed. Coveralls sometimes has issues like the one above where coverage increased but it failed still.
I am gonna loop @balloob in though, because Coveralls is showing the same file (remote.py) decreased coverage, which is an issue I had a few days ago that he had to fix because of bad code he pushed.

It's all good except that you forgot the dolphin of approval! Coveralls should only report an error status when coverage decreased 0.5+%. Not sure what is going on there.


New feature: --ignore argument in test.py

Simply passes the parameter through when building with test.py
Supports and requires https://github.com/ARMmbed/mbed-os/pull/6833

@andrewleech Thanks for this. Looking good to me.
@theotherjimmy @cmonr Any concerns?

@screamerbg @andrewleech We should have the same feature in compile and export, for consistency.

Would like to poke @sg- for his take on this.

@andrewleech Note that this won't work prior to Mbed OS 5.9 (after https://github.com/ARMmbed/mbed-os/pull/6833 patch is merged), therefore the option help should explicitly mention this.

Is there a use case for this other than ignoring main when running tests? This certainly is a simple solution but would worry about the annoyance of not remembering what file contains the main function.
@bridadan Do you recall the previous thinking around solutions to multiple main functions?

I've also used it since to build tests with rtos (--exclude main) and then compile app without rtos (--exclude mbed-os/rtos)

@bridadan Do you recall the previous thinking around solutions to multiple main functions?

I believe the option we suggested at the time was to provide a different entry point for tests. Something like test_main or something instead of main. This could be enabled by specifying an additional define when compiling with mbed test.
One thing to keep in mind with that approach though is that any global static defines in your app's main file would still be brought in for each test (you would pay a RAM/ROM penalty). Short of knowing where that file is and excluding it from the build I don't think there's a way we can prevent that.


add awesome-github-chinese

thank you

No license, no contributing guidelines. Read the guidelines for creating lists. Plus, since this is Chinese, I believe that this should go to #153.

thank you， I have added  license and contributing guidelines


Wget access method

Description
This PR implements a new access method type called wget. This access types allows to reference and access resources located on a http server.

There are still lint errors


⚠ Spryr has degraded performance

In e19e888, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4956 ms

Resolved: Spryr performance has improved in aa57fec after 10 minutes.


Overlay only stamps first page in range

In Windows 10 with qpdf version 9.0.2
Running qpdf --overlay only stamps the first page "in range". If you specify the --to= option it will stamp the first page in range e.g. --to=2-10 will stamp page 2. Without specifying --to it will stamp page 1 only.
The behavior is also the same whether using --replace-input or not.

I have to guess but it sounds like your 'stamp file' has only one page.
Try
qpdf --overlay stamp.pdf --repeat=1 unstamped.pdf stamped.pdf

Correct. The stamp file has only one page.
And your solution works. Is this how it is intended to work? The docs say omitting --to means the stamp file will be applied to all pages.

Yes, but it also says that --from indicates the pages to use from the ~stamp~overlay file and --repeat which ones to repeat once those are depleted. If you have a suggestion how to improve the documentation to make the behaviour more clear, I'm sure a pull request would be welcome. :wink:

Thanks @mschilli87 Got it! I am grateful for qpdf which makes PDF manipulation so much easier.


Lazily get and cache git path on first use

Currently @npmcli/git is eagerly getting and caching the git path in a user's system which can have a significant performance cost when requiring @npmcli/git. This PR avoids this cost by lazily getting & caching git path on first use.
References

Can't the same benefit be reached by moving the require('./which.js')  in lib/spawn.js to be inside the exported function?  Then the results can be cached even in the event there is no git present.

Can't the same benefit be reached by moving the require('./which.js') in lib/spawn.js to be inside the exported function? Then the results can be cached even in the event there is no git present.

Got it.

@wraithgar should be all good.


Property completion

Based on https://github.com/OmniSharp/omnisharp-roslyn/pull/1941. In the process of playing around with the code, I discovered that I totally forgot about overriding properties when I implemented completion... 🤦♂. This implements a more robust algorithm for finding the correct location in the changed text, and also handles property overrides correctly.

The new part of this change is in commit 9. Commits 1-7 are based on #1941, and commit 8 is merging in master.

Alright, I really hope that nothing I did broke azdo package upload, because if it is something I did then everything is a lie.

thanks a lot! I feel a bit embarrassed that I didn't notice the property overrides thing..

Same...

@333fred looks like this fails on linux
    OmniSharp.Cake.Tests.CompletionFacts.ShouldGetAdditionalTextEditsFromOverrideCompletion [FAIL]
      Assert.Equal() Failure
      Expected: String[] ["public override bool", "public override int", "public override void", "public override void", "public override string"]
      Actual:   SelectIListIterator<CompletionItem, String> ["Cake.Core.IO.FilePath assemblyInfoPath)\n{\n    re"..., "public override int", "public override void", "public override void", "public override string"]
      Stack Trace:
          at OmniSharp.Cake.Tests.CompletionFacts.ShouldGetAdditionalTextEditsFromOverrideCompletion () [0x002a5] in <895d19e3d19548c59ba9489d2daa2025>:0
      Output:

not sure if this is transient or not, let's see if the retry helps.  Looks like Cake has some special host object property that is overrideable? @mholo65 not sure why it would affect Linux only  though

hmm it passed now, but looking at the error above it looks like there is some race condition or other indeterministic state in the Cake tests. we can merge for now but we should keep an eye on this

@filipw thanks! I will dig into the Cake error and see if I find something obvious.


Add data-gutter on exporting CodeNode

Hi ! I came here to want to follow this : https://github.com/facebook/lexical/pull/4743#issuecomment-1876692195
I found a way to set data-gutter without implementing a whole custom node:

https://github.com/facebook/lexical/pull/4254

It can be easier with this feature like this
   html: {
      export: new Map([
        [
          CodeNode,
          (_, node) => {
            const element = document.createElement('pre');
            element.setAttribute('spellcheck', 'false');
            const language = node.getLanguage();

            if (language) {
              element.setAttribute('data-highlight-language', language);
            }

            const children = node.getChildren();
            const childrenLength = children.length;

            let gutter = '1';
            let count = 1;
            for (let i = 0; i < childrenLength; i++) {
              if ($isLineBreakNode(children[i])) {
                gutter += '\n' + ++count;
              }
            }

            element.setAttribute('data-gutter', gutter);

            return { element };
          },
        ],
      ]),
    },

I'm struggling to keep \n in the db though ...

looks good to me!
by the way, why is this issue here and not on https://github.com/facebook/lexical?

@ibastawisi I just tried to find in which codebase you implement that and thought it is here. hope you don't mind it.

@ibastawisi I just tried to find in which codebase you implement that and thought it is here. hope you don't mind it.

yeah no problem.
this editor config thing never worked for me!
I also needed to add syntax highlighting for c sharp, so I ended up copying the sources for the node and doing what I wanted.

btw for more language support, you just have to import prismjs sub package:
import 'prismjs/components/prism-csharp'

https://github.com/facebook/lexical/discussions/2176

btw for more language support, you just have to import prismjs sub package:
import 'prismjs/components/prism-csharp'

Adding new language for code highlighting facebook/lexical#2176

yeah that's what I did, thanks a lot.


Bioconda support

This should address https://github.com/nf-core/chipseq/issues/2

Provide an environment.yaml
Adjust the script calls in the main.nf file
Add a run_SPP.R script to bin to make this available (as it is not part of the r-spp package)

The respective bioconda recipes for r-ngsplot, r-ngsplotdb-(hg19,hg38,mm10) were also added to bioconda recently and should work now :-)

An issue I can't really say anything about right now:
In the former version of th epipeline, the test script calls something like --genome EF4 (which is not documented and I can't find that one nowhere. Any ideas what this is and how I could use this as test reference genome?

NF minimum version needs to be at least 0.30.0 because you added conda support in this PR. That was only added in v0.30.0 😉

Ah, you're right - yes I will add that back!

EF4 is part of iGenomes - Saccharomyces cerevisiae Ensembl build.
s3://ngi-igenomes/igenomes/Saccharomyces_cerevisiae/Ensembl/EF4/Sequence/WholeGenomeFasta/

Will finish this tomorrow:
The command "nf-core lint ${TRAVIS_BUILD_DIR}" exited with 1.
3.45s$ nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --saveReference
/usr/local/bin/nextflow: line 106: cd: ../jre/bin: No such file or directory
N E X T F L O W  ~  version 0.30.0
Launching `/home/travis/build/nf-core/chipseq/main.nf` [distracted_snyder] - revision: f4de057351
ERROR ~ Unknown config attribute: igenomes_base -- check config file: /home/travis/build/nf-core/chipseq/nextflow.config
null
 -- Check '.nextflow.log' file for details

So probably just iGenomes that I need to configure properly...

The iGenomes error is due to a change in how nextflow parsed the params I think. We had the same thing in all pipelines anyway. Just define it in the params section in base.config, as done here: https://github.com/nf-core/methylseq/blob/master/conf/base.config#L102

There are some glitches on param config with 0.30.0, use 0.30.1. Also put the params block at the beginning of the file (ie. before params is referenced`).

Thanks @ewels and @pditommaso ! I adjusted this accordingly and hope that the testcases now make it through - also had a typo in my last commit yesterday :-(

So apparently the build crashes on TravisCI and locally. Most things run through but the script run_spp.r is not found in the step phantompeakqualtools. This should be automatically symlinked to the respective work dir right? Once I copy it in and run the .command.sh in the container, it looks good. @pditommaso some idea?

Not symlinked, the bin directory is on the PATH when you run the pipeline I believe..

Hmm, the error that our version number is not numeric (1.4dev) is okay I guess, but the phantompeakqualtools process script works fine when running it manually in a container

Yes, this is because you're trying to merge into master, so the tests expect it to be code ready for a release. As we don't have a release yet it doesn't really make a lot of sense to have a dev branch yet I guess.
I'll take a look at phantompeakqualtools..

Perfect, I guess this is the last missing piece :-)

I'm adding in a couple of other minor visual tweaks too whilst I'm waiting for the test run to complete ;)
I'll push direct to the bioconda branch here so my commits should append to this PR.

Perfect! I stopped doing analysis work and will do much more development in the next weeks, so eager to learn ;-)

Note that we could do with finding better test data really. It's yeast which is good for small reference genomes, but that means that the MACS2 process doesn't run. Seeing as we have iGenomes, may be better to generate some subsampled Human data instead so that we actually test the full pipeline...

Agreed - shouldn't be that difficult to do this. + the "blacklisting" part isn't tested on this either...

Ok, I fixed the phantompeakqualtools problem - I removed the RScript bit and it works fine. I guess that the R installation is using a different PATH or something odd. To make it work when called directly I added the env header to the script to define it as an R script.
I'm still getting an error with that process, but it is at least running now:
Command exit status:
  1

Command output:
  ################
  ChIP data: SRR5204809_Spt5-ChIP_Input1_SacCer_ChIP-Seq_ss100k.dedup.sorted.bam
  Control data: NA
  strandshift(min): -500
  strandshift(step): 5
  strandshift(max) 1500
  user-defined peak shift NA
  exclusion(min): 10
  exclusion(max): NaN
  num parallel nodes: NA
  FDR threshold: 0.01
  NumPeaks Threshold: NA
  Output Directory: .
  narrowPeak output file name: NA
  regionPeak output file name: NA
  Rdata filename: NA
  plot pdf filename: ./SRR5204809_Spt5-ChIP_Input1_SacCer_ChIP-Seq_ss100k.dedup.sorted.pdf
  result filename: SRR5204809_Spt5-ChIP_Input1_SacCer_ChIP-Seq_ss100k.spp.out
  Overwrite files?: FALSE

  [1] TRUE
  Reading ChIP tagAlign/BAM file SRR5204809_Spt5-ChIP_Input1_SacCer_ChIP-Seq_ss100k.dedup.sorted.bam

Command error:
  Loading required package: Rcpp
  awk: line 2: function and never defined
  Error converting BAM to tagalign file: /tmp/RtmpD4OZmr/SRR5204809_Spt5-ChIP_Input1_SacCer_ChIP-Seq_ss100k.dedup.sorted.bam1b1cc6fbab

I also removed a lot of the ignore statements (I feel like this pipeline should be stable enough that they're not needed). And updated the logo in a couple of places.

..and it seems that my editor cleaned up a bunch of whitespace, sorry about that.
I also noticed that there was a mixture of params.version and just version used in the pipeline (with different version numbers!), so I fixed that up.

So yeah - I think the error is due to different versions of awk. So hopefully something we can fix in the container easily...? 😟

..and it seems that my editor cleaned up a bunch of whitespace, sorry about that.
I think that's good, you should not excuse yourself about that ;-)

Ok, phantompeakqualtools now works for me! I see now that gawk was already added in this PR, so I guess you'd already come across this and fixed it yourself @apeltzer. But as my container was out of date I didn't have it.
I did a couple of other minor fixes such as forcing the run_spp.r script to import the R libraries it needs, and now the whole pipeline seems to be running through for me 🎉  (still waiting for the final steps).
Note that the CI tests will fail because the docker image they're running with isn't the latest one from this PR.


feat: datatable added totalfooter

Closes #
📝 Description
Added Total footer row to dataTable component
Screenshots

Merge checklist

[ ] Added/updated tests
[ ] Added changeset

It still looks like an overbuilt and I don't see any sense adding this to manifest.
Probably we can just support passing footer row data? Would love to see other people thought
@dmorton-p44 @jklegsethp44 @p44dyoachim

It still looks like an overbuilt and I don't see any sense adding this to manifest. Probably we can just support passing footer row data? Would love to see other people thoughts @dmorton-p44 @jklegsethp44 @p44dyoachim

I tend to agree. Is this something for your app only or have others been requesting it? Would what @vitaliy-p44 suggests not be enough for what you need?

Probably we can just support passing footer row data?

I tend to lean towards what @vitaliy-p44 is suggesting -
However if we are wanting to introduce summary rows as a common thing across our design system, I am not totally opposed to this.
This component is already a tightly coupled implementation of https://tanstack.com/table/v8, and its intention is to enforce some opinions on how we render table data
I think if a dev needs flexibility outside of what this standard component suggests, they would resort to using the existing Table TableRow TableCell type components to compose something.

It still looks like an overbuilt and I don't see any sense adding this to manifest. Probably we can just support passing footer row data? Would love to see other people thoughts @dmorton-p44 @jklegsethp44 @p44dyoachim

Isn't it the same thing just instead of footer row data prop is named as totals row data, but i guess both do the same thing

It still looks like an overbuilt and I don't see any sense adding this to manifest. Probably we can just support passing footer row data? Would love to see other people thoughts @dmorton-p44 @jklegsethp44 @p44dyoachim

I tend to agree. Is this something for your app only or have others been requesting it? Would what @vitaliy-p44 suggests not be enough for what you need?

Probably we can just support passing footer row data?

Yes @jklegsethp44 for now these is something required specifically for  our app but as per my understanding from discussion i had with design team soon these is going to be a requirement in most of the tables used. either way these is controlled via an optional prop .

I tend to lean towards what @vitaliy-p44 is suggesting -
However if we are wanting to introduce summary rows as a common thing across our design system, I am not totally opposed to this. It would make the question of implementing this on both design / engineering trivial.
This component is already a tightly coupled implementation of https://tanstack.com/table/v8, and its intention is to enforce some opinions on how we render table data
I think if a dev needs flexibility outside of what this standard component suggests, they would resort to using the existing Table TableRow TableCell type components to compose something.

Yes @dmorton-p44 i understand thats why i have referred these example already provided by tanstack .


[stable/coredns] Version bump to 1.6.1

https://github.com/coredns/coredns/blob/master/notes/coredns-1.6.0.md

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/assign

@cpanato can you take a look again? Thanks!

/lgtm


node selfupdate and fix subnet router when ACL is enabled

Fixes #1604

The golangci-lint seem to have hung on some go.mod error that does not seem to exist, fairly sure it is safe to ignore.


Add a second view with signature information

Request
Add another view called Signature Info that shows the signature help (parameter hints) information at the current cursor position.
From: https://github.com/microsoft/vscode/issues/51253

@mjbvz What is precisely meant by parameter info? Does Documentation view already shows that info? If I understand clearly what is different about Signature information which is not already covered by Documentation, I could submit a (almost ready) PR.

@sandipchitale Yep, the signature help is what I meant. Looks like you already found the right api to use for it too! Let me know if you run into any issues working on this

Feel free to adjust the formatting. Note that it shows a green square next to active (current) signature.


Fixes trailing question mark reported in #378.

A few new tests demonstrate the problem and the fix.
The problem is the upfront single-character check, which lets a single special character through.
The fix is to let the Regex work on every string, and check for empty Enumerations with String.Join and the final ternary operator.

Awesome. Thanks for the correction and the unit tests. Could you please add this to the release-notes file?

I am glad to help, and thanks for the library!  I added the PR to the release notes.

Awesome. Thanks for the addition.

This is now released to NuGet as v1.34.0. Thanks.


commit initial files

commit initial files, including codes, MDs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, nice job.


Remove version: Ditto.Ditto version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://sourceforge.net/projects/ditto-cp/files/Ditto/<IP_ADDRESS>/DittoSetup_3_23_124_0.exe/download
OK
(Automated message - build 923)

Close with reason: Package still available.;


Allow user to duplicate a dump

Being able to have an action to duplicate (or snapshot/version) a dump would allow users to easily roll back on their test data when their setup requires destructive testing. Examples of destructive testing may include testing that causes failed upgrades, corrupted data, and so on. Having a snapshot point would allow the user to roll back and test on the last known point rather than having to recreate the database, then run through a series of steps to get back to the pre-failed state.

Hi Brian,
Thanks for the involvement! Yep, would be a nice feature, however, I think even currently, it is quite easy to deal with such a scenario, if you just reimport the original dump file you received from the customer(e.g. in a different database name, or in the same, after dropping the existing one, which has been modified during the testing). But I might be wrong, or didn't understand well your idea... Dani?

Hey Brian,
Yup, great request, I think it'd be pretty neat to be able to do that. Sorin, the steps you mention are basically the ones that could be done automatically with some bookkeeping and convenience functions tied to that, such as the user reverting the database to the snapshot value with a click of a button for example.
The main question is how to implement the whole thing - should we keep a copy of the database as a dump and do some re-import in the background? Should we have a copy of the database already imported, then do some renaming or some such?
At the moment I'm not exactly sure how to approach this feature.

Will be partly solved by the export feature. And not sure that we will need more than that. Migrated to https://github.com/djavorszky/liferay-support-ee/issues/6

Thanks!


Update model cost calculations for million tokens

Show $ / 1m tokens instead of $ / 1k tokens. This will make pricing more readable. At the moment, we actually do not show rates for OpenAI. But, in the future if we decide to, the groundwork is there.

Summary by CodeRabbit

New Features

Updated pricing model with new cost structures for models, significantly increasing the displayed monetary values.
Adjusted the formatting of costs to enhance clarity, now displaying one or two decimal places where applicable.

Bug Fixes

Corrected cost calculations to reflect a consistent unit of measurement, improving accuracy in displayed costs.

Documentation

Enhanced cost-related information to better align with the new pricing strategy and display formats.

@coderabbitai can you check the token calculations. For gpt-4o-mini where the "max tokens" is 28,100 tokens, it is saying the cost would be $0.01, which looks incorrect.

Nope, this looks good. My 28,100 tokens did not mention how much was prompt tokens vs completion tokens. The $0.01 value does look correct.


[Update Request]: PointPlanck.FileBot 5.0.1

What type of update are you requesting?
A new version of an existing package
Current Package Identifier
PointPlanck.FileBot
Package Version
5.0.1
Please describe the changes you would like to see
There is a new release of PointPlanck.FileBot (5.0.1) available.
Download page url: https://www.filebot.net/#download
Installer url: https://get.filebot.net/filebot/FileBot_5.0.1/FileBot_5.0.1_x64.msi

Close with reason: Package merged in #100501;


sparql completely supported ?

Dear,
I using ontop 18.0.1 with mssql.
I have a the following query  (generated by elda tool -mentions  api call)
SELECT ?item ?p
WHERE {
?item ?p http://my.test.com/mytesturi .
}  OFFSET 0 LIMIT 10
which causes problems in the translation. Removing the offset fixes the problem.
It seems hence that limits are not properly translated.
Also it seems that the isBlank case is also not translated.
Is there a list available of functions that are not supported yet?
kr,
Bert

Hi!
Here the list of supported sparql functions:
https://github.com/ontop/ontop/wiki/OntopSPARQLFunctions
Expressions inside BOUND, isIRI, isURI, isBLANK, isLITERAL, STR are not supported.
Other limitations can be seen here https://github.com/ontop/ontop/wiki/ObdalibIssues.
We are aware of the problem with limit and mssql, it has been reported here : https://github.com/ontop/ontop/issues/131.
The suggested workaround for the moment is to add, if possible, an order by.
in your example:
SELECT ?item ?p
WHERE {
?item ?p http://my.test.com/mytesturi .
}
ORDER BY ?item
OFFSET 0 LIMIT 10


Yes, I think we can consider to remove the 2.6 test in the future and add update the 3.3 to 3.5.

And also I think in the case we should include the attr "_" to add a "/" in the end of the uri.
And we should also add the getitem way in each of the test function, like client["cpes"].

While adding tests for rest of the API I found few issues. Fixes are included.

And also I think in the case we should include the attr "_" to add a "/" in the end of the uri.

Added.

And we should also add the getitem way in each of the test function, like client["cpes"].

This is already tested on few places. I want to have simple and small test methods for testing just specific part of API.

Here's the pip installs for pdc-client from PyPI for the last month -- a single 2.6 and no 3.3 (both are EOL):
$ pypinfo --percent --pip pdc-client pyversion
python_version percent download_count
-------------- ------- --------------
2.7              63.9%            991
3.6              20.6%            319
3.5              12.5%            194
3.4               2.9%             45
2.6               0.1%              1

By the way, you could add both 3.5 and 3.6 to Travis etc. More reasons for dropping old ones:
2.6

Unsupported since 2013-10-29
https://snarky.ca/stop-using-python-2-6/
http://www.curiousefficiency.org/posts/2015/04/stop-supporting-python26.html
http://www.python3statement.org
Current pip 9 deprecates Python 2.6 support, pip 10 won't support it (https://github.com/pypa/pip/issues/3955)
Not much PyPI traffic (June 2016) https://github.com/pypa/pip/issues/3796

3.2

(Already dropped! :)

3.3

Unsupported since 2017-09-29
pip 10 will deprecate Python 3.3 support, pip 11 won't support it (https://github.com/pypa/pip/issues/3796)
Very little PyPI traffic (June 2016) https://github.com/pypa/pip/issues/3796

I just found I keep the comment there for several days, but not submit it,sorry about that...
Why github always let me submit again after I give comment ...

I simplified the server code a lot (no regexps and should be easier to modify).
I also added few more tests for PUT and PATCH.

Test coverage for the last change

Reivewed again. LGTM


[MSINTEROP-1243] Add mirror for registry.stage.redhat.io to ICSP for operator install

Short description:
Adds a mirror to the ICSP created for operator install.
More details:
We are encountering issues installing an IIB image being stored in registry.stage.redhat.io. Adding this mirror seems to resolve the error we encounter.
Here is an example of the error that occurs.

/verified


Runnable solutions don't get their execute_endpoint anymore

It looks like spatie/ignition is still trying to create an endpoint to execute the solution with a controller that doesn't exist anymore (it does exist in spatie/laravel-ignition though):
https://github.com/spatie/ignition/blob/main/src/Solutions/SolutionTransformer.php#L6
This causes a couple of properties to be missing from the solutions. This is what I get:
{
    class: 'Spatie\\LaravelIgnition\\Solutions\\GenerateAppKeySolution',
    title: 'Your app key is missing',
    description: '',
    links: { 'Laravel installation': 'https://laravel.com/docs/master/installation#configuration' },
    action_description: 'Generate your application encryption key using `php artisan key:generate`.',
    is_runnable: true,
}

I expect to also see run_button_text, run_parameters and execute_endpoint. When an error is created in ignition and doesn't pass through laravel-ignition, is_runnable should be false.

Fixed!


Changelog

Hi, thanks for making this nice library!
Updates are extremely frequent; often multiple times per day. Never seen anything like it! :smile:
Is there a changelog?

@lonix1 Thanks for your interest. 98% of the updates are simply updating underlying libraries, silently improving everything. Updates are best found via commits authored by me. I strive hard to keep the ecosystem non-breaking.. but don't feel the need to stay on latest.


Implement the date and time popover for single event edits

Part of https://github.com/CUL-DigitalServices/grasshopper-ui/issues/114

Assigning to myself for implementation

Coverage remained the same at 100.0% when pulling 5c463a5e2966ec2d2990a8bcf46138a9e223bdbd on Coenego:issue-133-datepicker into c9e3dfe6a671903dd0a482bc3f921be9374066d4 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 895f95222c1576cc6f5cf072caeee014dda231f3 on Coenego:issue-133-datepicker into c9e3dfe6a671903dd0a482bc3f921be9374066d4 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 0e5582359d4d312821f3f723e65dcaeb30b4f001 on Coenego:issue-133-datepicker into c9e3dfe6a671903dd0a482bc3f921be9374066d4 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling f4483bd8af733f46ac367662842c341a57a25cc4 on Coenego:issue-133-datepicker into 0dc5c0f348edaf5e8b97d182922f0af9df03974f on CUL-DigitalServices:master.

Code review done

Design:

from, to and the current month on the top of the calendar have a lighter colour per design
prev and next should be replaced with fontawesome icon buttons
I think the numbers aren’t vertically and horizontally centered properly for days in the calendar

Functional:

prev and next close the popover
Since we’re only displaying events from 7AM to 7PM there’s not much use in being able to select more than that in the datepicker. Having said that, I’m not sure we should hard code limitations like that and make the start and end dates for the calendar configurable. Probably shouldn’t be a part of this PR but wanted to write it down anyway.
Focus should be set to the datepicker when it’s opened up and put back on the trigger when it closes.

Coverage remained the same at 100.0% when pulling 180810aead9fe50fd079f6010d10c029debc0f57 on Coenego:issue-133-datepicker into 0dc5c0f348edaf5e8b97d182922f0af9df03974f on CUL-DigitalServices:master.

Coverage decreased (-0.47%) to 99.53% when pulling f1a91ee92522b8cdc24d2e340e09f90c4593c1db on Coenego:issue-133-datepicker into 0dc5c0f348edaf5e8b97d182922f0af9df03974f on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling c450bd09619f3536782e5bc55ada3f7737750f63 on Coenego:issue-133-datepicker into 4615b128b84afdd354400a453dc715c825445d25 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling fbb7874b984bd9713f27be0114a63c8ecabb96b4 on Coenego:issue-133-datepicker into 4615b128b84afdd354400a453dc715c825445d25 on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 3c1f3b5ff7c30235f85cf9fea6720f99e2ce04b4 on Coenego:issue-133-datepicker into 4615b128b84afdd354400a453dc715c825445d25 on CUL-DigitalServices:master.

Reassigning to @bp323 for review after follow-up + additions

Coverage remained the same at 100.0% when pulling da553160c9df6f1d1257dabd96d4fff64bfd17d5 on Coenego:issue-133-datepicker into 2c6305052cb7dad4bfe7df366457677b374d9446 on CUL-DigitalServices:master.

Design:

btn-default missing on the submit button

Functionality:

The text in the table should read something like Wed 2pm - 4pm with a calendar icon in the front of it showing the month and day
When tabbing to the date field, for accessibility reasons it should be triggered when pressing enter or space. Focus should also be shifted to the popover. If the popover is canceled or applied the popover goes away and focus is reset on the table. There's already a similar implementation for jeditable in place.
When dates are changed and applied, the sticky footer should be shown to be able to save changes

Reassigning to @Coenego for followup

Coverage remained the same at 100.0% when pulling 74a48d60eb556d094928921612c8ce3939b74ec0 on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 6e16942c4c2d3e1405a76a982c3e335758caa63d on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 4f90420ff5e2e9304cd7c8fd18a2e326adf01816 on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 33e7c6a66e55b12f2fd12953d3022b5a4e52aad3 on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 610f15a1866e170d7f8a1a04d30cba5836ae3e6b on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling e161b943c52c4c77684d049a7007cc812c12e576 on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 1f2eb9c1c71a826918eb855de8ee152f27481e72 on Coenego:issue-133-datepicker into e2ad84a5ea899e23cd26ec0952a1f2ad7512db6d on CUL-DigitalServices:master.

Could you have a look at the merge conflict?

Coverage remained the same at 100.0% when pulling 82b97fce4c0cee125e33489e93c97fe4757a9065 on Coenego:issue-133-datepicker into c14013ea799e12c7fc2475d1e0b586b1a69de855 on CUL-DigitalServices:master.

Coverage decreased (-0.23%) to 99.77% when pulling 82b97fce4c0cee125e33489e93c97fe4757a9065 on Coenego:issue-133-datepicker into c14013ea799e12c7fc2475d1e0b586b1a69de855 on CUL-DigitalServices:master.

Coverage decreased (-0.23%) to 99.77% when pulling e25588cf7e7abf14be513f83ed1065b62b82b7cc on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling f72ea1a85df9f1660a091504557c50a7737ed349 on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling f050a21f3d50ecf4cdc233843730a468c5cbabbb on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling f1300855bc6aebf5a09bfc942efc89b5b6fada37 on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Functional issue:

When editing the same date twice it seems to revert to the original date

Saving also doesn't seem to work.. Reassigning to @Coenego before diving into review.

Reassigning to @bp323 for review

Coverage remained the same at 100.0% when pulling a86b20b74f2e44197b95f66c106c435d750ba736 on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Coverage remained the same at 100.0% when pulling 62e42cbb6100177e55509ec234c0b5d173dc3798 on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

When the popover is open and I click another date field, the popover reopens correctly on that field but the times set in the select elements are wrong.

There is an issue with leading 0's

Coverage remained the same at 100.0% when pulling c8aa7c1e1243ce1a827ce872ec279efc79fd5255 on Coenego:issue-133-datepicker into 0f167a9ccf065748b86fb9fc0a60cbefbbddc13b on CUL-DigitalServices:master.

Reassigning to @bp323

Coverage remained the same at 100.0% when pulling ff378fca9337aa959e2c1912ddba3bd87b718431 on Coenego:issue-133-datepicker into 50a418d67e52e82938620378274ad3ebd832d1a3 on CUL-DigitalServices:master.

Apart from a 'gh not defined' issue when adding a new event this looks good, I'll go over the code one last time as well.

Assigning to @bp323 for review

Coverage remained the same at 100.0% when pulling 847a604ada36b3580535970df8b25121144357e9 on Coenego:issue-133-datepicker into 3a92d33a3ab98360b29a253575d3faee82ad1073 on CUL-DigitalServices:master.

Looks good! Just need to get rid of the console logging and it's good to go

Awesome, verified and merged!