enable mTLS from proxyless gRPC clients

Set the experimental flag
Build proper transport credential
Cleanup CDS
Cleanup bootstrap:

correct plugin name
properly marshal durationpb

Tested with:
apiVersion: security.istio.io/v1beta1
kind: PeerAuthentication
metadata:
  name: "default"
spec:
  mtls:
    mode: STRICT

Before, we'd not even attempt TLS and the request would fail. This change gets me a successful request to a workload running envoy, with TLS.

Planning to add proxyless to the security reachabilty suite in a follow up

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

gencheck_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

gencheck_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test gencheck_istio

lint_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

gencheck_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test gencheck_istio

lint_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test lint_istio

integ-pilot-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

gencheck_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test gencheck_istio

lint_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test lint_istio

integ-pilot-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

How does auto mtls work to grpc? I assume we cannot tell if it will accept TLS or not since grpc ignores the TLS configuration sent over XDS

grpc ignores the TLS configuration sent over XDS

Do you mean for gRPC servers? That has to be dealt with separately, and it also requires application code changes to use https://pkg.go.dev/google.golang.org/grpc/xds#NewGRPCServer.
Clients won't ignore it if the flag is set and right client code is used, and without the peerAuthentication this change causes failures, not sure why exactly; I figured even without STRICT the server-side envoy would still perform TLS.
WARNING: 2021/07/17 17:01:41 [core] grpc: addrConn.createTransport failed to connect to {<IP_ADDRESS>:17070 a.default.svc.cluster.local:7070 0xc00496a550 0 <nil>}. Err: connection error: desc = "transport: authentication handshake failed: read tcp <IP_ADDRESS>:48262-><IP_ADDRESS>:17070: read: connection reset by peer". Reconnecting...

If you mean how do we know if the client will actually use the TLS configuration we send it... that I'm not sure. If its client-side, things will probably just break for the most part. For servers ignoring TLS config we should definitely find a way to raise a warning.
I'll update this doc as I figure more things out.

Do you mean for gRPC servers?

What I mean is in k8s, we know if the server will accept mTLS traffic by logic which is basically hasSidecar && !PeerAuth=DISABLE. This works in almost all cases (one case it does not is multiprimary - we don't know which PeerAuth is used).
For grpc its a bit different. First, we do not have an equivalent hasSidecar check we can do. You could kind of do one from injection but not really a good idea. Even if they are using XDS, they may still not have the tls config set in their application, so the presences of PeerAuth is not sufficient as they may just ignore it.
So I am not sure we have a good way to implement this core functionality

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test release-notes_istio

lint_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test lint_istio

integ-pilot-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-cni-k8s-tests_istio

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test lint_istio

integ-pilot-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-cni-k8s-tests_istio

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

release-notes_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-cni-k8s-tests_istio

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

release-notes_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test release-notes_istio

lint_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

By defaulting everything to plaintext, and only claiming support for STRICT mode, if either side is miconfigured requests will break rather than a user expecting mTLS but actually doing plaintext... ? Agree we don't have a good way to implement this.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-cni-k8s-tests_istio
4a597487d1e825c9f7974e866776c8762d8006fb
link
/test integ-cni-k8s-tests_istio

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

release-notes_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test release-notes_istio

lint_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test lint_istio

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

release-notes_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test release-notes_istio

lint_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test lint_istio

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test gencheck_istio

lint_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test lint_istio

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

release-notes_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test lint_istio

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

release-notes_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test release-notes_istio

gencheck_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

release-notes_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test release-notes_istio

gencheck_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test gencheck_istio

lint_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

gencheck_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test gencheck_istio

lint_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test lint_istio

release-notes_istio
980319f08dcfc7c98d6a4110057ebba3591e4787
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

lint_istio
2642e261fd4d9c3fbee3d624e81f553abcff3c4d
link
/test lint_istio

release-notes_istio
980319f08dcfc7c98d6a4110057ebba3591e4787
link
/test release-notes_istio

gencheck_istio
980319f08dcfc7c98d6a4110057ebba3591e4787
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

gencheck_istio
980319f08dcfc7c98d6a4110057ebba3591e4787
link
/test gencheck_istio

release-notes_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

release-notes_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test release-notes_istio

gencheck_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-cni-k8s-tests_istio

release-notes_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test release-notes_istio

gencheck_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
4b39d697a3844724836d7a495be860d077f76957
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
0e866176b0132adadd34331b64456d0d38f437fb
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
25018d4b300fbc47704b70571800b9b36b6fcad1
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #34156


Explicit way of register classes

Currently, chex.assert_xyz uses tree under the hood. This make it impossible to use it with Jax trees (jax.tree_utils.register) which do not support collections.abc.Mapping.
I have a dataclass which already define __getitem__, __iter__ for numpy-like operation, so I cannot support collections.abc.Mapping.
I would like to use it with tree too, so chex.assert_xyz works.

I don't get it. I can inherit from collections.abc.Mapping and implement your own __getitem__, __iter__. I would even say it is the expected design! I don't get why there would be any blocking point here.

I can't inherit from collections.abc.Mapping, because I already implement __getitem__ and _iter__ from another use-case.
Basically Mapping expect __iter__ to returns keys (which can then be passed to __getitem__), but my custom class uses __iter__ to slice array (like iter(np.array(...))). So the 2 use-cases are incompatible

Another issue with collections.abc.Mapping is that it does not allow forwarding static metadata (like jax.tree_map does).

Ok I understanding now. I assume you are not compatible with collections.abc.Sequence either ? Because tree recognizes it.
Anyway you are right. Reading the doc of jax.tree_map, I really like the way it handles additional class registration. It is a shame it is not a standalone package because it seems to supersede tree and could replace it. What I don't like with tree is the lack of performance.  I find it quite slow to do extremely basic operations because it mixes python and cython. Do you know if jax.tree_map is faster ?

Here I think we can refer to torch's pytree and jax's libtree in terms of design. They provide a register method so that custom classes can be processed after flattening, and can be subsequently unflattened to restore them to their original state.

Register custom pytree nodes in jax
Register custom pytree nodes in torch

I think this is quite important for dmtree for supporting custom containers defined by user, and some wrapped libraries like treevalue.

I also ran into this problem where the current implementation doesn't nicely handle initialization of custom PyTree objects.
To compare, the jax implementation allows you to pass auxiliary data (stored in the PyTreeDef return value) when flattening and unflattening PyTrees. This is useful for storing some class metadata that shouldn't be interpreted as leaves.
This is not possible with dm-tree using tree.flatten and tree.unflatten_as, as all initialization data of your custom class must be contained in the leaves...
A solution might be to dynamically generate classes using a metaclass or a call to type to couple this metadata to the tree-structure (haven't tried though), but this seems a bit hacky and I would prefer the jax solution.


fix(trace): add epsagon id when propagate feature is on

:tada: This PR is included in version 1.38.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feature: allow passing in timeout in opts

https://github.com/omisego/elixir-omg/issues/929
Overview
I think it's a timeout issue, and this allows us to send in timeout value like

[
  faucet: "0x944a81beecac91802787fbcfb9767fcbf81db1f5",
  initial_funds:<PHONE_NUMBER>000000000,
 timeout: 120_000
]

Changes

Check if timeout key is present in keywords

Testing
/

Coverage decreased (-14.09%) to 70.905% when pulling 6a94a489febc22a6a9fbec3e3833f7e5586f120d on 929-increse_timemout into dcfc5c706b8fd008de30e3309c00fd8d996e8358 on master.


Add mesh generators for FE operators.

Add mesh generators using the following cells: quadrilaterals, hexahedra,
triangles, tetrahedra, quadrilaterals+triangles, and hexahedra+tetrahedra.
This should simplify #303 and make it easier to do scaling tests.

Codecov Report

Merging #325 into master will increase coverage by 0.74%.
The diff coverage is 99.87%.

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   95.71%   96.46%   +0.74%
==========================================
  Files          61       63       +2
  Lines        3595     4386     +791
==========================================
+ Hits         3441     4231     +790
- Misses        154      155       +1

Impacted Files
Coverage Δ

packages/Discretization/test/tstMeshGenerator.cpp
100% <100%> (ø)

packages/Discretization/test/MeshGenerator.hpp
99.6% <99.6%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5a51...148633c. Read the comment docs.

Done


[Ludown][LUIS] Prebuilt entities for Italian causes parsing issues

Same error of #1007 appears also for it-it locale.
(Note: I reproduced the bug in calendar skill by first commenting-out the personName prebuild reference from the it-it Calendar.lu file, to bypass the bug https://github.com/microsoft/botframework-cli/issues/876, not yet closed).
Originally posted by @GitDruid in https://github.com/microsoft/botbuilder-tools/pull/1024#issuecomment-655353307

Hello @GitDruid ludown is deprecated. Please track the botframework-cli only


Nullable ContentItemId for AuditTrailSummaryAdmin view

On one of our production environments we have an issue where one of the audit trail pages is throwing a yellow screen because the ContentItemId is null.
I have not been able to find the exact replication steps for how this has been caused, but have fixed this locally by editing values to give me the yellow screen.

By making this nullable, the view no longer throws the exception and the backend is already capable of handling the null ContentItemId.

@andrewcartwright1,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

What is the reason the id is null? What's special with this content item id in the database?
There should be a constraint in the db for that.
Maybe it's not the content item which is the issue, but the activity that logged the audit trail record. Can you see how this record was generated?

So, after some digging about - I'm still unable to find the exact reason as to why this is happening - However have found some more details relating to it.
It looks to happen when removing items contained in a content picker field within a content part attached to a content type and saving it - but after stepping through the code - I cant figure out where the id becomes null - in the eventdata property the ContentId key can still be found with the original id.
Testing this on a fresh instance of Orchard does not produce the ysod.

Do you still think your PR is relevant or should we fix the issue when the diffgram is created?

The issue looks to lie in the Analyze method in DiffGramAnalyzer.cs - I had a look to see how the diffgram gets generated and its done using a class inside a nuget package by Microsoft..
I've actually found another issue in this class where the analyze method will skip over child elements inside an add (see below)

<xd:xmldiff version="1.0" srcDocHash="2348630670847115797" options="IgnoreChildOrder IgnoreComments IgnoreWhitespace IgnoreXmlDecl " fragments="no" xmlns:xd="http://schemas.microsoft.com/xmltools/2002/xmldiff">
<xd:node match="1">
<xd:change match="1" name="ClubPart.ClosingTimeFriday">
<xd:add type="2" name="Value">0001-01-02T00:00:00Z</xd:add>
<xd:remove match="@ContentItems" />
</xd:change>
xd:add
<ClubPart.ClosingTimeMonday Value="0001-01-02T00:00:00Z" />
<ClubPart.ClosingTimeSaturday Value="0001-01-02T00:00:00Z" />
<ClubPart.ClosingTimeSunday Value="0001-01-02T00:00:00Z" />
<ClubPart.ClosingTimeThursday Value="0001-01-02T00:00:00Z" />
<ClubPart.ClosingTimeTuesday Value="0001-01-02T00:00:00Z" />
<ClubPart.ClosingTimeWednesday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeFriday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeMonday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeSaturday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeSunday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeThursday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeTuesday Value="0001-01-02T00:00:00Z" />
<ClubPart.OpeningTimeWednesday Value="0001-01-02T00:00:00Z" />

</xd:add>
</xd:node>
</xd:xmldiff>

I've compared this against a diff that works with no issues and the xml is very different.

<xd:xmldiff version="1.0" srcDocHash="11674922285041200100" options="IgnoreChildOrder IgnoreComments IgnoreWhitespace IgnoreXmlDecl " fragments="no" xmlns:xd="http://schemas.microsoft.com/xmltools/2002/xmldiff">
<xd:node match="1">
<xd:node match="2">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="3">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="4">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="5">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="6">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="7">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="8">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="9">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="10">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="11">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="12">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="13">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="14">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
<xd:node match="15">
<xd:change match="@Value">0001-01-01T00:01:00Z</xd:change>
</xd:node>
xd:add

</xd:add>
</xd:node>
</xd:xmldiff>

For the time being my fix is a mitigation until I can learn more about what this class does 😃.


Add ability to add asset by home domain

So unfortunately every call to setPrompt() will currently have this issue if cancel is selected. trustAsset will be the first operation to cancel gracefully.

So unfortunately every call to setPrompt() will have this issue if cancel is selected. trustAsset will be the first operation to cancel gracefully. Should I take the extra X minutes to do this with every event?

Let's create a separate issue for that to not block this PR.

https://github.com/stellar/stellar-demo-wallet/issues/47


add alphabetical sorting to tooltips

This PR adds support for alphabetically sorted enchanted tooltips. It works by implementing the Comparable<Text> interface for all net.minecraft.text.Text implementations. This is used inside of EnchantedBookItem inside of the static method that is used to combine and generate new enchantments during gameplay. The inject is right before the method returns the ListTag with all enchantments. The injected code iterates over each entry inside of that ListTag, filters for CompoundTags that represent StoredEnchantments and sorts them using their translated name.
Not sure if you want this to actually be part of your mod but I had fun figuring out how this works :)
Small QoL change :p

Nice idea, only thing missing is a config option to enable/disable. I’ll merge it this weekend and upload a build to curse

For simplicity/compatibility sake I think I’d be better to avoid more mixins when possible. We can replace the text mixin instead by specifying the comparator to the .sort() method call. Similar to what I did here https://github.com/kyrptonaught/Inventory-Sorter/blob/49048266d18e33986f7d3d35ed69dc3a615d104b/src/main/java/net/kyrptonaught/inventorysorter/InventoryHelper.java#L21

It turns out this won't work with multiple mods injecting tooltips as they get split up into in the middle. I'll close this for now.

I recently added support for sorting enchants and forgot to tell you. Can you check if my implementation works with other mods?


Added "IF EXISTS" option for "DROP TABLE"

Can't be merged.

It breaks backwards compatibiltiy.
IF EXISTS isn't part of SQL standard and has different syntax in some DBs we support. The patch will work for MySQL and probably PosgreSQL but not MSSQL or Oracle.

I tested it with MySQL, PosgreSQL, Cubrid and Sqlite.
I wrote to MSSQL and OCI, but without testing. See here

OK. That's something to consider for 2.1 then. Could you re-submit a pull request?

Ok, I wait by 2.1


WIP adding @canEdit to card format components

[ ] Stack context

[x] contains
[x] containsMany
[ ] linksTo
[ ] linksToMany

[ ] Preview panel
[ ] Guest mode

TODO: Make sure all fields that we defined (every place where FieldDef is used) respect the @canEdit

Github is acting really strangely, it's been stuck in "Processing updates" from yesterday and no new commits are shown even though they are pushed and can be seen in https://github.com/cardstack/boxel/commits/cs-6374-add-canedit-arg-to-basedef-and-make-boxel-set-this-on-cards/

@lukemelia I created a copy of this PR (https://github.com/cardstack/boxel/pull/1237) because this one is broken, it doesn't process new commits 🤷♂ 😵💫


typo in ApiScanner

Typo in "response".
https://github.com/PhonePe/mantis/blob/0bda292e815bcfc093a74f81a810303072e0b9b9/mantis/tool_base_classes/apiScanner.py#L53C1-L54C1

Hey @lutilm
Thanks for pointing the typo. Fixed this in latest commit.

thanks to you for this great project!


Translation Updates - Lab 13

Lab 13, Exercise 1, Task 4, Step 4:   "시스템" should be changed to "System".

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Blocked Locfile is at PHO - needs to be at HB

Discussed with the PM - update made to the older HB locfiles and this will seed the TM when handedback
Locfileshttps://wus-000.icms.osi.office.net/vantagepoint/QueryPanel.aspx?Tenant=CAICritical&Query=PFZQUT48TEZPPkZhbHNlPC9MRk8%2bPElEPkZhbHNlPC9JRD48RUxDPkZhbHNlPC9FTEM%2bPEFNUD5GYWxzZTwvQU1QPjxTT0hSSVI%2bRmFsc2U8L1NPSFJJUj48U0hSUD5UcnVlPC9TSFJQPjxTQVRPPlRydWU8L1NBVE8%2bPFNBTE8%2bRmFsc2U8L1NBTE8%2bPFFFPj4yPC9RRT48UVQ%2bPjxRUiBJZD0iMSIgQ1BJRD0iMCI%2bQ3VycmVudDtGaWxlcztIb3N0IENvbnRlbnQgU3RvcmU7RXF1YWw7V1dMPC9RUj48UVIgSWQ9IjIiIENQSUQ9IjAiPmFuZDtDdXJyZW50O0xvY0ZpbGVzO0xhbmd1YWdlO0VxdWFsO0tvcmVhbiAoS29yZWEpPC9RUj48UVIgSWQ9IjUiIENQSUQ9IjAiPmFuZDtDdXJyZW50O0ZpbGVzO0hvc3QgQ29udGVudCBHcm91cDtFcXVhbDtXV0wtTEFCLUFaLTUwMF9tYXN0ZXI8L1FSPjwvUVQ%2bPFJHPjxHQz5OVUxMPC9HQz48L1JHPjwvVlBRPg%3d%3d

Discussed with the PM - update made to the older HB locfiles and this will seed the TM when handedback


[queue] jakubkulhan/bunny

A performant pure-PHP AMQP (RabbitMQ) sync and also async (ReactPHP) library. https://github.com/jakubkulhan/bunny

Can you rebase this onto master?

Rebased.


Aeroblender

Mod Name
Aeroblender
Mod Homepage
https://modrinth.com/mod/aeroblender
Describe the bug
aeroblender causing some sort of conflict w fabric
Steps to reproduce
Install aether and aeroblender
Logs

Additional context
No response

Aeroblender works fine on my end, especially before the update today.
Ive noticed small bugs like world rendering in main menu causing crashes, but thats about it

Aeroblender works fine on my end, especially before the update today. Ive noticed small bugs like world rendering in main menu causing crashes, but thats about it

I retried with all the latest updates to FFI and sinytra and the game still crashed, basically the same log as before.

Aeroblender works fine on my end, especially before the update today. Ive noticed small bugs like world rendering in main menu causing crashes, but thats about it

I retried with all the latest updates to FFI and sinytra and the game still crashed, basically the same log as before. It looks like I have terrablender fabric installed, reinstalled it w forge and that seemed to have worked

I found that basically no biome mods work with connector that are forge.
Im unsure if this is the same case.
Example: Biomes o plenty just refuses to let the game boot

Aeroblender works fine on my end, especially before the update today. Ive noticed small bugs like world rendering in main menu causing crashes, but thats about it

I retried with all the latest updates to FFI and sinytra and the game still crashed, basically the same log as before. It looks like I have terrablender fabric installed, reinstalled it w forge and that seemed to have worked

I found that basically no biome mods work with connector that are forge. Im unsure if this is the same case. Example: Biomes o plenty just refuses to let the game boot

The issue is closed, but regions unexplored is running fine for me on forge


Add builds 0.12.1 and 0.12.2

@OiNutter this'd be really helpful

BTW, please make sure that the checksums work before merging. I copied them straight from the node.js blog, but my computer kept complaining about mismatches. When showing the expected checksum, the last 3 characters were repeated: a969f17a0a6c9238584f8946d96e8d39be8eb957 appeared as a969f17a0a6c9238584f8946d96e8d39be8eb957957

covered by #48


Fix pipeline

No code style related errors but will have to write some test for coverage

closes #101

Merging with all checks passed. Will continue to write more test cases as I add addStudents for consultations


Nuget restore External Service Connetion

Currently external private nuget feed can be used during "nuget push" option. Please add possibility to use external private nuget feeds which are added through "Nuget service connection" to make "nuget restore".

@Dushelov Thank you for your feedback. The issues in this repo are for content feedback, and this looks like a product feedback. For product feedback, including feature requests, please file an issue here: https://developercommunity.visualstudio.com/spaces/21/index.html
Thank you.


various, #959

0105e

we disable AS, and clearing the default does not stop someone adding their own (it's a different pref) should they chose to use AS
otherwise, to get rid of the topsites when clicking in an empty urlbar, users have to either know about this pref or enable AS and go manually remove them all
this is cleaner than disabling topsites with browser.newtabpage.activity-stream.default.sites as that actually breaks the functionality (should users want to use AS and topsite suggestions)
we don't disable topsite suggestions: 0850a: 78+, browser.urlbar.suggest.topsites is inactive
this is the list you see when you click in an empty urlbar, and obviously if you have no topsites then the 0850a pref is rendered useless for suggestions as you type, but doesn't break the functionality if a user does add their own topsites
capisce? easy peasy? clear as mud?

0850a

we could elaborate that this is for suggestions when you start typing/pasting (i.e not the same as topsites) - IDK

settings (changed)

we can remove these two when ESR68 hits EOL, meanwhile I just tagged them as (FF72-)

settings (not changed)

0517 does not seem to exist: [SETTING] Privacy & Security>Forms and Autofill>Autofill addresses (FF74+)
I tested vanilla profiles in 74+, and system addon<EMAIL_ADDRESS>is present
maybe I'm doing something wrong

0420: ui.PRM

maybe you can word it better

@guser-sudo feel free to join in

browser.newtabpage.activity-stream.default.sites is a string pref. Otherwise 👍

what about 0517 's [setting] tag ?

re: 0517 - I tested it in a vanilla FF78. Because by default extensions.formautofill.available is set to detect and extensions.formautofill.supportedCountries is US only, it depends on the region lookup on whether it shows up in the UI or not.
No outgoing connections were allowed for FF in my testing but I was able to make the UI setting show up by setting browser.search.region to US and restart FF


Path accept spaces

resolves #174
This PR changes the regex of the Path implementation to accept spaces.

I'm okay with this! However, due to the nature of the input string being trimmed, I will have to fix a bug that allows trailing (but not leading) whitespaces in the Title.

@ljiazh3ng Actually, I wonder why we need to allow whitespace? It feels rather weird for me tbh to accept trailing and leading whitespace in our path components. Perhaps we'd wanna accept whitespace only if it's in the middle of a component?
For example, /path /to / object will be invalid, while /this is a path/to object is fine.
What do you think?

@ljiazh3ng Actually, I wonder why we need to allow whitespace? It feels rather weird for me tbh to accept trailing and leading whitespace in our path components. Perhaps we'd wanna accept whitespace only if it's in the middle of a component?
For example, /path /to / object will be invalid, while /this is a path/to object is fine.
What do you think?

@kevinputera, the way @ljiazh3ng designed it at this point; he allows leading and trailing spaces, then trims it. Since Title and Path components are the same, maybe they should follow the same validation?


Collection Editing - PBDB check

When you edit a collection, you are required to search PBDB again. Maybe not a bad idea, as you might be making a correction that would then cause the collection to match a PBDB collection. But it can be a little annoying to have to do this every time. Just want to make sure we all support doing things this way.

I vote for leaving it annoying.

We are closing this for now, but can revisit the issue in the future if we receive complaints.


Teams Bot Auth: oAuth Card with AADV2 returns expired tokens

Sample information

Sample type: samples
Sample language: nodejs
Sample name: 46.teams-auth

Describe the bug
I'm using sample auth with AADV2 connection and custom scope. The token is not renewed and receiving the expired token.
To Reproduce
Steps to reproduce the behavior:

Use the 46 sample with AADV2 connection type
Set the scopes to be "offline_access" and custom scope like "api://appid/myscope"
Try the sample now the token is received
After an hour we also receive the same even though the token is expired

Expected behavior

We should receive the new token after the previous token is expired.

Additional context
https://stackoverflow.com/questions/62527519/teams-bot-auth-oauth-card-prompts-for-login-every-hour-with-aadv2
[bug]

Hi @bravokeyl
Token handling is not something the bot does; it does not automatically refresh. The OAuth samples are meant to show simple implementation of sign-in and sign-out logic. As you've already asked this question on stackoverflow, I'm going to close this issue, and answer further queries there.

@jwiley84 Thanks for the quick response.
I'm confused from the comments in the code. I thought when we call the prompt it returns the new token if the previous token is expired, is my assumption wrong here?

@jwiley84 Stumbled upon on the same thing today, I'm wondering how we can retreive a new token.
It would be great to add some notes on how to do that. Currently I can see that there is no way
to renew the token as we just get a hold on accestoken and no refresh token is received.
What are the possible ways to retreive a new token without re-prompting the user with sign-in card?

@jwiley84 @pujita9610 Yes, it would be very helpful if there are notes/guidance on how to retrieve a new token with oAuthCard

@jwiley84 Any further input on this would be great to retrieve the valid token. Thanks

Any updates on this issue ?


[TS-4990] support new apis in ts_lua

support new apis in ts_lua
@jpeach pls take a look and review. Thanks.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1058/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/950/ for details.

@jpeach pls take a look if you get a chance. thanks.

@jpeach, I have updated the PR according to the comments. Please take a look.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1023/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1129/ for details.

thanks. will squash before merge.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1161/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1054/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1175/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1068/ for details.


about a new option ideal

when I was bored, find this "yamu-obfuscator" project is very well, maybe we can add it to this project and make a new set flow.but the project is older...
Do you think?

I can't add this project in raw form. But the idea itself is interesting.

Also it's similar in some way to controlFlowFlattening option

So, i think it's better to improve controlFlowFlattening option

yeah, but it run in a unique way and interesting


It is not working on under version 5 android devices

on next update please fix that

It doesn't work because the app only works on Android 6.0+
And no, a future update will not change this.


Adding metric processor type

Addressing #49. I'd like to get some feedback before I go any further. As it is, it appears to be working with my test sources but I have yet to add any tests.
While writing this I did think it might be nice to be able to define some labels, but I didn't see a way of doing that with the metrics interface.
For example if I had this stream of data:
{"name": "kraig"}
{"name": "ashley"}
{"name": "kraig"}
{"name": "kraig"}

And a configuration like this:
  processors:
    - type: metric
      metric:
        type: counter
        path: names
        labels:
          name: ${!json_field:name}
        value: ${!json_field:name}

I'd get the metrics:
benthos.names 1 name=ashley
benthos.names 3 name=kraig

Yeah unfortunately right now the metrics package doesn't have any form of labels/tags. We can always add that in later. Looks good so far, although it might be nice to allow an empty value when the type is counter, which would be interpretted as 1.

I would do the check anyway and if false try and parse the value as an int, if that fails return an error.

Hey @bigkraig, is this ready to merge? If so I'll do it this week.

@Jeffail I think its good to go 👍

Done, thanks @bigkraig!
I noticed in unit tests that when interpolating json fields we actually get null instead of an empty string when the field doesn't exist, which I'd completely forgotten about. I therefore simplified the behaviour to just always count by 1, if you need this to be conditional on the existence of a field then you can still do that with the conditional processor. I'm pretty sure this shouldn't change the way that you were using it, but let me know if that breaks your use case and I'll take a another look.


Add Instructions to the application

We are unable to start a game after joining with three players.  Clicking on "Game#" does nothing. The chat box is empty. All we are able to do is set our player names and see them below the black screen.

Please add play instructions.

To start a new game, click "new game" and pick a type of game to play


Manual Adding

Hi,
First thanks for your work.
I have my bedside lamps into a vlan.
The vlan is called smarthome and the Norma lan is acceable to this smarthome vlan.
Your plugin is in this case not possible to search for this device and will also not automatically add them.
Is it possible to add them manual to the config like the override?
Cheers Robert

How router do you have?

How router do you have?

I use opnsense on a alix apu2.
In my network I use three VLANs.
One is the normal internal network, one is for smart home devices and the last one is for guest.
All have different ip ranges, and gateways.

I think, that I have same problem :)
https://github.com/cellcortex/homebridge-yeelighter/issues/24

Yeelighter is using this API: https://www.yeelight.com/download/Yeelight_Inter-Operation_Spec.pdf
They have some detail on the registration protocol. I would suggest to try to solve this at the network config level by forwarding/opening ports for this.
If this cannot be fixed at the gateway, I would also accept a PR for the config.


TableHeadCell 'class' prop is defined as never

Describe the bug
Code:
<TableHeadCell class="!p-4">
vs code complains: Type 'string' is not assignable to type 'never', and I checked the .d.ts file, it is defined as follows:
import { SvelteComponentTyped } from "svelte";
declare const __propDef: {
    props: {
        [x: string]: never;
    };
    events: {
        [evt: string]: CustomEvent<any>;
    };
    slots: {
        default: {};
    };
};
export type TableHeadCellProps = typeof __propDef.props;
export type TableHeadCellEvents = typeof __propDef.events;
export type TableHeadCellSlots = typeof __propDef.slots;
export default class TableHeadCell extends SvelteComponentTyped<TableHeadCellProps, TableHeadCellEvents, TableHeadCellSlots> {
}
export {};

Reproduction
just use the code :
Flowbite version and System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-12500
    Memory: 2.95 GB / 15.70 GB
  Binaries:
    Node: 18.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.2.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.1265.0), Chromium (110.0.1587.46)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @sveltejs/kit: ^1.7.1 => 1.7.1
    flowbite-svelte: ^0.29.13 => 0.29.13
    svelte: ^3.55.1 => 3.55.1
    vite: ^4.1.2 => 4.1.2

it seems it's resolved in version 0.30.4


resize images on page load

Hello dear Lovell,
I've just got familiar with Sharp and thanks for maintenance of this great package, I just set it up for the approach of resizing images to the set of 3 breakpoints in order to show them in different screen sizes for the sake of load time. so far it works really well the following is my configurations.
const fs = require('fs');
const productDir = './public/uploads';
const formatedImgDir = './public/images/products';
const sharp = require('sharp');

fs.readdirSync(productDir).forEach(async (file) => {
  try {
    console.log(file);
    await sharp(`${productDir}/${file}`)
      .resize({ width: 1024 })
      .jpeg()
      .toFile(`${formatedImgDir}/1024-${file}`);
    await sharp(`${productDir}/${file}`)
      .resize({ width: 720 })
      .jpeg()
      .toFile(`${formatedImgDir}/720-${file}`);
    await sharp(`${productDir}/${file}`)
      .resize({ width: 320 })
      .jpeg()
      .toFile(`${formatedImgDir}/320-${file}`);
  } catch (err) {
    console.log(err);
  }
});

the only problem is whenever I paste new images to uploads folder it does not get resized on the fly till I re-run the app. I would like to change this behavior to when the browser is refreshed. is it possible to do it via Sharp?


Fixes a bug that caused normalization to break

_.forEach stops iteration when the argument function returns false.
The normalization assignment in Coffeescript caused an implicit return
statement that results in false if the value is false (which is a valid
case).

:+1


Migration script: .glintrc.yml to glint key in tsconfig.json

I think this is basically correct, but:

I have no tests, will try to add them next week.
It depends on the work @dfreeman has done to actually support this, and should therefore land after #354.

Open question: should we have a scripts package, or should we (probably better!) bundle this into @glint/core or something?

I've landed the upstream branch, so this should be the last time you have to deal with that changing out from underneath you (sorry!)


Broken kretprobe kstack dump

enable kretprobe kstack trace:
echo r skb_segment > kprobe_events
echo stacktrace > events/kprobes/r_skb_segment_0/trigger
echo 1 >  events/kprobes/r_skb_segment_0/enable

sudo bpftrace -e 'kretprobe:skb_segment { printf("kstack: %s\t, return value: %d\n", kstack, retval); }'

send packet

console output as below:
kstack:
kretprobe_trampoline+0
, return value: -777579008

without kstack output.

how can i dump kstack  in kretprobe script ?

Seems like an old issue - https://github.com/iovisor/bpftrace/issues/68

Closing as duplicate of #101


lowgl-<IP_ADDRESS> does not compile

A complete build log that shows the errors we get in our CI environment can be found at http://hydra.cryp.to/build/559646/nixlog/2/raw.

thanks working on it

I fixed the particular issue with the cabal file. It wasn't listing all the modules. Now working on example programs.


Broken Screenshot links

It would seem that postimg.org is dead.
Screenshots in README.md do not work anymore.

Any plans to fix this?


Error: getaddrinfo: Name or service not known (SocketError)

I have installed this on Ubuntu 14.04, with Ruby 1.9.3p484
Have executed theme configure with the correct keys.
When running theme download I get this error.
/usr/lib/ruby/1.9.1/net/http.rb:763:in `initialize': getaddrinfo: Name or service not known (SocketError)
        from /usr/lib/ruby/1.9.1/net/http.rb:763:in `open'
        from /usr/lib/ruby/1.9.1/net/http.rb:763:in `block in connect'

I have read the part of the README that offers a solution, and tried that, but it did not work.
I did:

Copied the cacert.pem file to my machine
Executed export SSL_CERT_FILE=/path/to/cacert.pem

But the theme download command still gives an error.
A Google search did not offer any help, other than maybe this page but I guess that if it is indeed the solution, it needs to be implemented in the gem.

What did you put in for your shops domain?

My bad...
The README instructions confused me by saying to run theme configure ..... store_name
So I used only the store name (the first part of the domain).
Only after reviewing this line in the code, I realized I needed a full domain. Seems to work now - apologies and thanks (maybe change the docs from store_name to store_domain to eliminate any chance of confusion?)

https://github.com/Shopify/shopify_theme/commit/c3c6f41f6d76f2ee1ea6f5be5b43dce7c4200444


Scoping data fetching (relations)

Hello,
My setup uses authorizer to manage user auth while app user data is saved in the main db (the 1 remult sees - postgres), in the users table (created from User model).
For each request - I authenticate the request using a token - at this point - we are still in express-mw land. I then attach the user to the request obj so that getUser() can extract it (as specified in the tutorials).
I'm trying to get the user inside getUser() for all additional data like this:
getUser: async (req) => {
    const userData = await remult.repo(User)
      .find({ where: { email: req.user?.email } });
    if (userData) {
      return Promise.resolve({
        id: userData[0].id || '',
        email: userData[0].email || '',
        roles: [userData[0].role],
      });
    }
    return Promise.resolve(undefined);
}

But this causes some issues, specifically when combining with backendPrefilter() on entities. I'm guessing because of the async/await.
Example of backendFilter:
backendPrefilter: () => {
    return { organizationId: remult.user?.organizationId || '' };
  },

What/where would be the best place to extract to user data?

Update:
The problem is I'm accessing the model from getUser(), triggering backendFilter before I have everything backendFilter expects.
Now I'm left with the original question - where should I pull user data from my db so it is visible to all entities/controllers?
Assuming also I want the role so getUser() will block api access relying on it (such as role: 'admin')

Hi @mihaa1 ,
First of all - you can check the user roles anywhere using remult.isAllowed('admin') etc...
Here's an example from an app I'm writing:
https://github.com/noam-honig/trempim/blob/master/src/app/events/tasks.ts#L145-L165
As for storing data you have several options.

If you want that data to be shared with the frontend as well - you can extend the UserInfo object to include more information (phone etc...)
https://github.com/noam-honig/trempim/blob/1e5f395bda16ed10cc9591f6788f982f8f08148b/src/app/common/UITools.ts#L54-L56

You can store on the server anything that you want, using remult.context and then you can access it anywhere in the server:
https://github.com/noam-honig/trempim/blob/1e5f395bda16ed10cc9591f6788f982f8f08148b/src/server/server-session.ts#L8-L29

backendPrefilter is an async method, so you can fetch data there:

backendPrefilter: () =>{
const ids = (await repo(Something).find()).map(x=>x.id)
return {id:ids}
}

@noam-honig thanks. I'll have to check the context approach.
In the meantime - I added a raw sql query to get the user on each request in getUser()
const sql = await SqlDatabase.getDb();
    const command = sql.createCommand();
    const res = await command.execute(
      `
  			SELECT * FROM users
  			WHERE email='${req.user?.email}'
  		`
    );

This way I get the user's data (role, other stuff for scoping data), and don't trigger the User model entity methods.

Why? What is the advantage
On Sat, Oct 28, 2023 at 16:01 mihaa1 @.***> wrote:

@noam-honig https://github.com/noam-honig thanks. I'll have to check
the context approach.
In the meantime - I added a raw sql query to get the user on each request
in getUser()
const sql = await SqlDatabase.getDb();
const command = sql.createCommand();
const res = await command.execute(
   			SELECT * FROM users   			WHERE email='${req.user?.email}'
);
This way I get the user's data (role, other stuff for scoping data), and
don't trigger the User model entity methods.
—
Reply to this email directly, view it on GitHub
https://github.com/remult/remult/issues/277#issuecomment-1783803941, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD65PU6LKCFFMOB2WYLJVNLYBT6Z5AVCNFSM6AAAAAA6NQBJX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHAYDGOJUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@noam-honig if ur asking why I'm not using the context option - I still don't know how to yet (I need to move fast here on some development :)

You code is at risk of sql injection, with an invalid email.
Also - I'm not sure what you're getting in the result .
I think this can be solved by extending the UserInfo interface, at best - or by using repo to select the user as a less favorible option.
If you want, reach out to me tomorrow on discord and if I can, we can look at it together and I'll be happy to help


Defund Arlington, MA Police Department

To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Arlington Resident for Defunding the APD
Message (Don't forget to replace the [x]'s with your information!)
Dear Town Meeting Manager Chapdelaine, Select Board Members Mahon, Curro, Dunn, Hurd, DeCourcey, and Town Moderator Leone,
My name is [YOUR NAME] and I am a resident of [NEIGHBORHOOD/BOROUGH/CITY], and I am writing to demand that the Arlington Police Department be defunded.
Over the past week, our nation has been gripped by protests in every single state, calling for the end to police brutality.
Police "reform," has failed over and over again. NYPD banned chokeholds in 1993. In 1994, the NYPD murdered Anthony Baez by chokehold. In 2014, the NYPD murdered Eric Garner by chokehold. Oklahoma currently requires "de-escalation training," yet is #3 out of the 50 states for police involved killings. In 2014, Tamir Rice was killed by Cleveland PD who had a "warn before shooting" and a requirement to de-escalate already in place.
We know that "reform" does not work. APD is a particularly guilty part of the system that is being protested and dismantled nationally. APD Lieutenant Rick Pedrini wrote a heinous, racist, violent and murderous letter for 2018 issue of The Senteniel. For all we know, the cop who kneeled on George Floyd's neck for 9 minutes read Pedrini's letter and was emboldened by it. But still, Pedrini is an employee of the APD, being paid by the tax dollars of the people he advocated to "put down".
Defunding the police is not a "radical" idea. Minneapolis city council has already detailed a plan for completely abolishing police in their city, and using that budget to go towards community services that actually help reduce crime. In 2019, Arlington spent $8,214,876 on police. It spent $425,891 on Health and Human Services. What would Arlington look like if that 8 million dollars was invested in the community?
Police “reform” is not enough. We must take a hard look at the ways that the current system in place fails to serve–and in fact actively harms–our community, and come together to reimagine the role of police in our town. We MUST defund the APD, and we must do it now.
Thank you for your time, [YOUR NAME] [YOUR ADDRESS] [YOUR EMAIL] [YOUR PHONE NUMBER]

on it!


Inference Likelihood Function Optimizations

We should test which parts of the likelihood function take different amounts of time for a wide range of models sizes. A number of optimizations might be very helpful. In particular, most of the likelihood computation takes place in code like this:
for i in range(self.M):                 error += np.linalg.norm(self.bd.get_measurements()[n, :,i] - ans[:,self.meas_indices[i]], ord = self.norm_order)
every time np.linalg.norm is called, there is overhead to switch between python and cython.
Every time self.bd.get_measurements() is called, a new np.array is instantiated and returned.
Fixes:

get_measurements could be called just once in the function, potentially using C memoryviews and pointers to the data objects memory buffer.
built in P-norm functionality to avoid the numpy call.

Fixed in the latest PR merged into dev, to be merged into master soon.


537 create clientid

Describe your changes
Creates a register page to register client ids on.  This functions similarly to the same page on the DTR app.
I've added some "smart" client registration functionality by having the launch page detect that it doesn't have a valid client id stored and automatically directing the user to the register page without breaking the current session.  When the register page is accessed this way, the iss will be pre-filled and submitting a client id will trigger the app to attempt to launch again using the submitted client id.  This avoids any tedious back and forth with the register page.
Ideally, users will never have to navigate to /register manually for any reason.
To test the new functionality, attempt to launch the app from anywhere.  On your first launch, you should be asked to register a client id, with the iss already filled out.  On subsequent launches, it should automatically pull the client id.  Note that the moonshot server will accept any clientId.
You can also visit the /register page directly to manage client ids by removing or adding them.
I can add the defaults in if we think we want them.
Issue ticket number and Jira link
REMS-537
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

[ ] Review the code changes and make sure they all make sense and are necessary.
[ ] Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

initial launch of smart-on-fhir results in error:

If I navigate to /register then the correct page populates

Unable to test fully as I get an error with clientid

But I think thats on me for not knowing what the default value should be.
I think adding defaults would be helpful for testing,


Window Size and Position

It looks like the config.ini remembers windows size and position but it doesn't remember state.  If I have my window maximized, close it and re-open it... it makes the screen the same size as it was when it was maximized.. but it doesn't actually maximize it
[2052949]

Fixed


“TypeError ”    when I run demo_sim_Erender.py

When i run demo_sim_Erender.py,I got the wrong:
Traceback (most recent call last):
  File "d:\code\CV\CNS\demo_sim_Erender.py", line 79, in <module>
    run_demo()
  File "d:\code\CV\CNS\demo_sim_Erender.py", line 40, in run_demo
    tar_img = env.init(i)  # uint8, bgr image
  File "d:\code\CV\CNS\cns\benchmark\environment.py", line 110, in init
    frame = self.camera.render(target_cwT, self.client)
  File "d:\code\CV\CNS\cns\utils\perception.py", line 112, in render
    rgb, z_buffer = np.ascontiguousarray(result[2][:, :, :3]), result[3]
TypeError: tuple indices must be integers or slices, not tuple

I have print the result[2],it's a tuple。
I dont’t konw how to solve it.

I change the code to:
        result = p.getCameraImage(
            width=self.intrinsic.width,
            height=self.intrinsic.height,
            viewMatrix=gl_view_matrix,
            projectionMatrix=self.gl_proj_matrix,
            renderer=p.ER_BULLET_HARDWARE_OPENGL,
            physicsClientId=client
        )

        rgb = np.reshape(result[2], [self.intrinsic.height, self.intrinsic.width, 4])[:,:,:3]
        rgb = rgb.astype(np.uint8)
        # print(rgb[0])
        z_buffer = np.reshape(result[3], [self.intrinsic.height, self.intrinsic.width])
        z_buffer = z_buffer.astype(np.uint8)
        # rgb, z_buffer = np.ascontiguousarray(result[2][:, :, :3]), result[3]

        depth = (
            1.0 * self.far * self.near / (self.far - (self.far - self.near) * z_buffer)
        )

        depth = depth.astype(np.float32)

it worked

Hi, thanks for your feedback. In this repo we use pybullet==3.2.6 with numpy enabled, and the function getCameraImage returns numpy arrays. Maybe your installed pybullet is not numpy enabled? You could check this via running:
python -c "import pybullet; print('NumPy enabled:', pybullet.isNumpyEnabled())"

Anyway, we have modified the code in cns/utils/perception.py to cope with this condition.


FactoryBot/AssociationStyle false positive with explicit style and strategy: :build option

Actual behavior
I have the factory:
FactoryBot.define do
  factory :mask do
    association :blocklist, strategy: :build
  end
end

I run the command:
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -A spec/factories/masks.rb
Inspecting 1 file
C

Offenses:

spec/factories/masks.rb:6:5: C: [Corrected] FactoryBot/AssociationStyle: Use implicit style to define associations.
    association :blocklist, strategy: :build
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/factories/masks.rb:6:5: C: [Corrected] FactoryBot/AttributeDefinedStatically: Use a block to declare attribute values.
    blocklist strategy: :build
    ^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 2 offenses detected, 2 offenses corrected

Then I got the factory:
FactoryBot.define do
  factory :mask do
    blocklist { { strategy: :build } }
  end
end

I have the following simple test:
context 'when mask is not persisted' do
  let(:mask) { build(:mask) }

  specify do
    mask
  end
end

I run the test:
ydakuka@yauhenid:~/Work/project$ rspec spec/interactors/masks/create_interactor_spec.rb:171

Masks::CreateInteractor
  when mask is not persisted
    example at ./spec/interactors/masks/create_interactor_spec.rb:171 (FAILED - 1)

Failures:

  1) Masks::CreateInteractor when mask is not persisted
     Failure/Error: let(:mask) { build(:mask) }

     ActiveRecord::AssociationTypeMismatch:
       Blocklist(#86920) expected, got {:strategy=>:build} which is an instance of Hash(#9400)
     # /usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/association.rb:282:in `raise_on_type_mismatch!'
     # /usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/belongs_to_association.rb:66:in `replace'
     # /usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/singular_association.rb:17:in `writer'
     # /usr/local/bundle/gems/activerecord-<IP_ADDRESS>/lib/active_record/associations/builder/association.rb:108:in `blocklist='
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:16:in `public_send'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:16:in `block (2 levels) in object'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:15:in `each'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:15:in `block in object'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:14:in `tap'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/attribute_assigner.rb:14:in `object'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/evaluation.rb:13:in `object'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/strategy/build.rb:9:in `result'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/factory.rb:43:in `run'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/factory_runner.rb:29:in `block in run'
     # /usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:182:in `instrument'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/factory_runner.rb:28:in `run'
     # /usr/local/bundle/gems/factory_bot-6.2.1/lib/factory_bot/strategy_syntax_method_registrar.rb:28:in `block in define_singular_strategy_method'
     # ./spec/interactors/masks/create_interactor_spec.rb:169:in `block (3 levels) in <top (required)>'
     # ./spec/interactors/masks/create_interactor_spec.rb:172:in `block (3 levels) in <top (required)>'
     # ./spec/support/database_cleaning.rb:18:in `block (3 levels) in <main>'
     # /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
     # /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
     # /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/strategy.rb:30:in `cleaning'
     # /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:34:in `block (2 levels) in cleaning'
     # /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:35:in `cleaning'
     # ./spec/support/database_cleaning.rb:17:in `block (2 levels) in <main>'
     # /usr/local/bundle/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <main>'

Debug info
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -d spec/factories/masks.rb
For /app: configuration from /app/.rubocop.yml
configuration from /usr/local/bundle/gems/rubocop-capybara-2.18.0/config/default.yml
Default configuration from /usr/local/bundle/gems/rubocop-1.50.2/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-capybara-2.18.0/lib/../config/default.yml
configuration from /usr/local/bundle/gems/rubocop-factory_bot-2.23.1/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-factory_bot-2.23.1/lib/../config/default.yml
configuration from /usr/local/bundle/gems/rubocop-performance-1.17.1/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-performance-1.17.1/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rails-2.19.1/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rails-2.19.1/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rake-0.6.0/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rspec-2.22.0/config/default.yml
configuration from /usr/local/bundle/gems/rubocop-rspec-2.22.0/config/default.yml
Inheriting configuration from /app/.rubocop_todo.yml
Use parallel by default.
Skipping parallel inspection: only a single file needs inspection
Inspecting 1 file
Scanning /app/spec/factories/masks.rb
Loading cache from /root/.cache/rubocop_cache/3bf2dec38d8afed63f3590777e42f8ba569b3d43/24251ebbddb79bae12a8baba73821326329cc45b/954d37e26309f3ad7ab2ce8f774a1cb935ea93b3
.

1 file inspected, no offenses detected
Finished in 0.5033240660004594 seconds

RuboCop version
ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.50.2 (using Parser <IP_ADDRESS>, rubocop-ast 1.28.1, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.18.0
  - rubocop-performance 1.17.1
  - rubocop-rails 2.19.1
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.22.0

FactoryBot version
factory_bot (6.2.1)
  activesupport (>= 5.0.0)
factory_bot_rails (6.2.0)
  factory_bot (~> 6.2.0)
  railties (>= 5.0.0)

I can reproduce the issue, and I am working on a fix.
Thanks for reporting @ydakuka.

Just a note, a few things aren't working intuitively.

The <> syntax won't accept (pair :strategy :build), only (pair (sym :strategy) (sym :build)), while in other cases such a shortcut is possible to my best memory
The <> rubocop-ast syntax isn't working with ! negation
! negation is not documented
foo a: 1 is parsed as hash in specs, while ruby-parse parses it to kwargs

Note to self regarding pint 4 above: parser now always returns ‘hash’. This is more practical, as syntactically there’s not much difference. This simplifies cop’s implementation. ‘ruby-parse’ falls back and for some reason turns on all ‘legacy’ settings, and there’s nearly a dozen of them, including the kwargs arguments.


customize response code

It seems json-server can only returns 201. I want to return 500 with error message. So I can test error handling for my app.

Hi @peacepassion,
You can "tweak" the response this way:
// index.js
var jsonServer = require('json-server')

var server = jsonServer.create()
var router = jsonServer.router('db.json')

router.render = function (req, res) {
  if (someCondition) {
    res.status(500).jsonp({
     error: "some error"
    })
  }
}

server.use(router)
server.listen(3000)

Use then req and res properties to return an error for certain conditions only.

Thanks, @typicode

this example should be in the readme.md

This was my solution: https://gist.github.com/juanbrujo/efdcf6ab9eacbd5b5d69884233d0a3ce


binaryen: 86 -> 88

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/binaryen/versions.
meta.description for binaryen is: '"Compiler infrastructure and toolchain library for WebAssembly, in C++"'.
meta.homepage for binaryen is: '"https://github.com/WebAssembly/binaryen"
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 88 with grep in /nix/store/a5srlc1dcxnysygdjijb84b21273vyf3-binaryen-88
directory tree listing: https://gist.github.com/e547973f3212f17402c48862491fd71e
du listing: https://gist.github.com/805a502da4565177b26bd6d98fe0d04c

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
binaryen

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/a5srlc1dcxnysygdjijb84b21273vyf3-binaryen-88 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A binaryen https://github.com/r-ryantm/nixpkgs/archive/2170380abbda75d5f57ba2b686672483d9c3188f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/a5srlc1dcxnysygdjijb84b21273vyf3-binaryen-88
ls -la /nix/store/a5srlc1dcxnysygdjijb84b21273vyf3-binaryen-88/bin

cc @asppsa for testing.

LGTM


⚠ Bofrost.at has degraded performance

In 85ada2e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2424 ms

Resolved: Bofrost.at performance has improved in 4151e2c after 6 minutes.


Storage Base Path

:tada: This PR is included in version 4.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Some CSS variables added for consistency. More important update coming ahead

Some CSS variables added.
Just wanted to pull request before an real UI changes that could just be nice for me but not for everyone.
So just in case I prefer to PR my earlier work.
Working on some CSS animations and effects.

@microsoft-github-policy-service agree


[1.13.x] Vendoring swarmkit @c7df892

Brings the fixes for #28291, #25608 and #30938 to the 1.13.x branch

The Jenkins failure on windowsRS1 seems to be the same as #31011. Not sure about the reason of the Windows failure though I think it is unrelated to the update of this PR.

I think failure might be valid, but unrelated to change:
05:40:53 ----------------------------------------------------------------------
05:40:53 FAIL: docker_cli_logs_test.go:310: DockerSuite.TestLogsCLIContainerNotFound
05:40:53
05:40:53 docker_cli_logs_test.go:314:
05:40:53     c.Assert(out, checker.Equals, message)
05:40:53 ... obtained string = "Error response from daemon: No such container: testlogsnocontainer\n"
05:40:53 ... expected string = "Error: No such container: testlogsnocontainer\n"
05:40:53
05:40:57
05:40:57 ----------------------------------------------------------------------

random ping of @vdemeester


How to make insecure calls (disable SSL/TLS)

https://github.com/googleapis/google-cloud-java/blob/d4e9d09eb1314a732c98be74fc7f312d157e793e/java-apigee-registry/google-cloud-apigee-registry/src/main/java/com/google/cloud/apigeeregistry/v1/RegistryClient.java#L136
I have a local instance of the Registry API running with Docker, how to configure the RegistryClient class properly. I already configure the endpoint and CredentialsProvider using RegistrySettings. I've tried with both grpc and http transport.

Hi, @diegomarquezp,
I'm using an example Dockerfile with envoy and it's configurations which exists in the apigee/registry repository.

Hi @alex-rocha-hp, thanks for sharing your setup. I'm wondering if the snippet I shared ended up allowing you make insecure calls to your local Registry API?

Hi @alex-rocha-hp, thanks for sharing your setup. I'm wondering if the snippet I shared ended up allowing you make insecure calls to your local Registry API?

Sure, it helped, sorry for not giving feedback.


firebase cloudmessaging native linking error on ios

I am using firebase cloud messaging version (),
it work in debug mode, but when build for appstore, the following error happen:
Native linking error: truncated fat file. Slice from 4611984 to 6449696 is past end of file with length 5144576 file '/Users/mohammadshaban/Library/Caches/Xamarin/mtbs/builds/HBRS.iOS/7757187b09de98f2bb163c41d580c1ef/obj/iPhone/AppStore/mtouch-cache/FirebaseMessaging' for architecture arm64

it seams that this component not support arm64 yet, isn't it?

Hi @Shaboo!
Firebase Cloud Messaging it does support arm64 architecture. You can see it in this archive. Also, arm64 arch is in the Firebase Cloud Messaging framework. If you inspect the Firebase Cloud Messaging framework located at ~/username/Library/Caches/XamarinBuildDownload/FCldM-2.0.4/Frameworks/FirebaseMessaging.framework using file FirebaseMessaging command in terminal, you can see the following output:
FirebaseMessaging.framework username$ file FirebaseMessaging
FirebaseMessaging: Mach-O universal binary with 4 architectures: [i386:current ar archive] [arm64]
FirebaseMessaging (for architecture i386):	current ar archive
FirebaseMessaging (for architecture armv7):	current ar archive
FirebaseMessaging (for architecture x86_64):	current ar archive
FirebaseMessaging (for architecture arm64):	current ar archive

As you can see, arm64 is presented in the fat library.
I built the app for App Store and everything worked for me.
Thanks in advance!
Greetings,
Israel Soto.

thanks for your reply,
so, any idea why that error is happened only with me?

I'm not really sure, to be honest. Does removing the folders worked for you? If so, maybe some file was corrupted.
About the PR, we have been a little busy due to internal changes in some teams, as well as, to arrivals of new projects. While the PR is approved, you can build the NuGet package of new versions and reference them locally.
To do so, clone this fork and switch to update/firebase-4.8.0 branch. Then, follow these instructions running the nuget target.
Finally, follow this documentation to learn how to add NuGet packages from your computer.
Best,
Israel Soto.

I did remove everything and that did not work for me, I going to try building the new PR as instructed above and feedback you , if that does not for me, I am going to use "app centre push"
you can close this issue,
your reply and instructions are appreciated,
best regards,
mohammad shaban

@Shaboo Another thing you can try is setting the Link Behavior to Don't link in project settings. Open Project Setting/iOS Build/Link Behavior and change it. Play with the values, but between each change, erase bin and obj folders.

Closing this issue now. If something else happens related to this, feel free to reopen this.
Best!
Israel Soto.


Incremental Conversion

Implement incremental conversion.
i.e. it should be able to add a new point cloud tile to an already finished conversion.
Things to consider:

Projection. What if the new point cloud has a different kind of projection?
Would be nice if the source could be identified for each point. i.e. point[0] was added during the first conversion at [timestamp1], point[1] was added during the second, incremental conversion add [timestamp2]

More thoughts on this @dkastl @sanak ?

Projection. What if the new point cloud has a different kind of projection?

About projection, I think that it is not necessary to consider projection difference.
(If a new data(*.las) projection is different from processed data one, it should be translated by las2las .etc.)

Would be nice if the source could be identified for each point. i.e. point[0] was added during the first > conversion at [timestamp1], point[1] was added during the second, incremental conversion add [timestamp2]

About timestamp, I am worried that it causes increasing data size.
(Although, I don't know how much bytes are necessary to store timestamp for 1 point...)
Also, some measurement system records laser data from moving object (airplane, vehicle .etc)
by short interval timestamp, so 1 las file includes various timestamp actually in that case.
In my opinion, 2D map tile's "layer" concept may be better to manage long interval
(like yearly) timestamp data.
(I mean "layer" like the following link's<EMAIL_ADDRESS>http://mapserver.org/mapcache/services.html
My proposal is as follows:

Add "layer" lookup to "cloud.js". (layer number "0" is default.)

:,
layers: {
    0: "2014 year data",
    1: "2015 year data"
},

Add "layer" folders to "data" folder.

data
  +- 0 ... layer-0 folder
    +- r
      +- :
  +- 1 ... layer-1 folder
    +- r
      +- :

https://github.com/potree/PotreeConverter/issues/12#issuecomment-61464830

For incremental conversion, there needs to be a function that can resize the octree and reorders the points accordingly.

By the way, about resizing the octree, I think that specifying "max boundary box" as argument
will solve this effectively (not only for development, but also for processing time).
In case of 2D map tiling, resizing or shifting tile is quite rare case.

hi, this is my solution:

align the bounding boxes. same coordination results same bounding box and sparse cell.
multiple octree support. if newly added points outside of old bounding box, add these points to new octree. otherwise update to existing nodes.
in potree.pointcloudoctree.update, if the visible geometry extends current bounding box, request neighbor octree.

not implement yet. ;)

First successfull incremental conversion(experimental): https://github.com/potree/PotreeConverter/commit/c0dbc434a5d88af8278b25ddee8cc418228489ba

About projection, I think that it is not necessary to consider projection difference.
(If a new data(*.las) projection is different from processed data one, it should be translated by las2las .etc.)

Yes, the user will have to make sure both sources are in the same coordinate reference system.

About timestamp, I am worried that it causes increasing data size.
(Although, I don't know how much bytes are necessary to store timestamp for 1 point...)
Also, some measurement system records laser data from moving object (airplane, vehicle .etc)
by short interval timestamp, so 1 las file includes various timestamp actually in that case.

1 byte would be sufficient to store 256 different timestamps. Could be an optional property in case someone wants it. It would also make it possible to remove or replace points with a specific timestamp from the conversion.

By the way, about resizing the octree, I think that specifying "max boundary box" as argument
will solve this effectively (not only for development, but also for processing time).
In case of 2D map tiling, resizing or shifting tile is quite rare case

Yes! The commit is doing that now. The bounding box can be specified during the first conversion with the  --aabb "minx miny minz maxx maxy maxz" argument. The second conversion then adds to the data using the previously specified bounding box.

Okay, thanks for information!
I will try to test incremental_conversion branch from tomorrow.

Ok! You may have to use the potree develop branch to check the results. Both are experimental, just send me a message if you experience difficulties.

Came to think of another nice usecase that could be nice to have. For the national data we have in denmark I can download a really huge set of laz (n) files that are each 1km by 1km. Would be rather cool if I could use the converter tool to process them individual to an output folder x_i.
Then with another tool merge two output folders x_i and x_(i*2+1) to x_(n+i) and this way recursive merge all of it to a large set.
Would be able to process large sets really fast (given one have cores/pcs enough).
Would something like that be possible given the spec?

Nlesc did something like this with a previous potreeconverter release. I'm on mobile so i can't give you a link bit you should find it when you search for massive potree converter. They've released a page with the converted ahn2 dataset consisting of 640 billion points.
Incremental conversion is now possible btw. The readme for potree converter contains an example for the initial conversion with an aabb argument and subsequent conversions with the --incremental flag.

Thanks. found it. https://github.com/NLeSC/Massive-PotreeConverter
Will see if it works for me

Good luck! May have to modified for potreeConverter 1.3 though

Hi, I have a laser file with the extension las in the volume of 800 GB, I output with potreeconverter version 2.0.2 , it gives me an error.
I turned this file into smaller pieces and got output. Now i want to merge but i do not know with what command


add log.logCrash, a helper function to log crash info that is/tries to be signal handler safe.

So we can log segfaults.

( ping @linkrope )


(Suggestion) Option to remove all subreddit colours or stop them syncing automatically

When signing in subreddit colours automatically sync and there is no option to stop this or remove them all at once.

Yeah I am adding multi-select to the sub management screen (and also making it not set the color to black if no color is found)

Has been added


Pin dependencies to release-1.8

What this PR does / why we need it:
Pins us to use versioned Kubernetes dependencies
Release note:
NONE

/approve


.setavatar doesn't seem to do anything.

I'm trying to set the avatar of the bot, but not even your example seems to work.
.setavatar https://i.ytimg.com/vi/WDudkR1eTMM
I'm the owner of my channel and I invited the bot with my account.
Am I doing something wrong? Thanks!

SERVER OWNERS ARE NOT BOT OWNERS. All owner-only commands require you host the bot. Hosting means you are running a nadekobot on your own computer. If you want to learn how to host the bot yourself, type -guide