[BUG] Race condition detected when run in test files

New bug checklist

[x] I have updated smtpmock to the latest version
[x] I have read the Contribution Guidelines
[x] I have read the documentation
[x] I have searched for existing GitHub issues

Bug description

Race condition detected when running tests in file
Test file:
package mailer

import (
	"fmt"
	"log"
	"net/smtp"
	"testing"
	"time"

	"bitbucket.org/vadacom/commander/pkg/logging"
	smtpmock "github.com/mocktools/go-smtp-mock"
)

func last[E any](s []E) E {
	return s[len(s)-1]
}

var (
	smtpmockServer        *smtpmock.Server
	smtpmockServerAddress string
)

func TestMain(m *testing.M) {
	// You can pass empty smtpmock.ConfigurationAttr{}. It means that smtpmock will use default settings
	smtpmockServer = smtpmock.New(smtpmock.ConfigurationAttr{
		LogToStdout:       true,
		LogServerActivity: true,
	})

	// To start server use Start() method
	if err := smtpmockServer.Start(); err != nil {
		log.Panic(err)
	}
	defer smtpmockServer.Stop()
	// Server's port will be assigned dynamically after server.Start()
	// for case when portNumber wasn't specified
	hostAddress, portNumber := "<IP_ADDRESS>", smtpmockServer.PortNumber

	// Possible SMTP-client stuff for iteration with mock server
	smtpmockServerAddress = fmt.Sprintf("%s:%d", hostAddress, portNumber)

	exit := m.Run()
	log.Print(exit)
}

func TestSMTPTransport_Send(t *testing.T) {
	l := logging.TestingStructuredNop(t)
	mailTransport, err := NewSMTPTransport(
		l,
		smtpmockServerAddress,
		smtp.Auth(nil),
		30*time.Second,  // dial timeout
		30*time.Second,  // command timeout
		300*time.Second, // DATA timeout
	)
	if err != nil {
		t.Fatal(err)
	}

	const (
		someoneEmailAddress =<EMAIL_ADDRESS>		peanutEmailAddress  =<EMAIL_ADDRESS>		benEmailAddress     =<EMAIL_ADDRESS>		mailFromTmpl        = "MAIL FROM:<%v>"
		rcptToTmpl          = "RCPT TO:<%v>"
		msgBodyFooter       = "\r\n"
	)
	emptyFromAddressErr := fmt.Errorf("from address ('') parsing failed: mail: no address")
	emptyToAddressErr := fmt.Errorf("to address ('') parsing failed: mail: no address")
	missingToAddresses := fmt.Errorf("missing email to addressees")
	missingEmailMsg := fmt.Errorf("missing email message body")
	helloEmailMsg := []byte("Hello World")

	type args struct {
		email_from_address string
		email_to_addresses []string
		email_msg          []byte
	}
	tests := []struct {
		name    string
		args    args
		wantErr error
	}{
		{name: "MUST FAIL: empty from address", args: args{"", []string{someoneEmailAddress}, nil}, wantErr: emptyFromAddressErr},
		{name: "MUST FAIL: empty to address", args: args{someoneEmailAddress, []string{""}, nil}, wantErr: emptyToAddressErr},
		{name: "MUST FAIL: nil list of to addresses", args: args{someoneEmailAddress, nil, nil}, wantErr: missingToAddresses},
		{name: "MUST FAIL: empty list of to addresses", args: args{someoneEmailAddress, []string{}, nil}, wantErr: missingToAddresses},
		{name: "MUST FAIL: nil message body", args: args{someoneEmailAddress, []string{someoneEmailAddress}, nil}, wantErr: missingEmailMsg},
		{name: "MUST FAIL: empty message body", args: args{someoneEmailAddress, []string{someoneEmailAddress}, []byte{}}, wantErr: missingEmailMsg},
		{name: "hello world email from someone to someone", args: args{someoneEmailAddress, []string{someoneEmailAddress}, helloEmailMsg}, wantErr: nil},
		{name: "hello world email from ben to someone", args: args{benEmailAddress, []string{someoneEmailAddress}, helloEmailMsg}, wantErr: nil},
		{name: "hello world email from someone to multiple addresses", args: args{someoneEmailAddress, []string{benEmailAddress, peanutEmailAddress}, helloEmailMsg}, wantErr: nil},
		{name: "hello world email from ben to multiple addresses", args: args{benEmailAddress, []string{peanutEmailAddress, someoneEmailAddress}, helloEmailMsg}, wantErr: nil},
		{name: "hello world email from peanut to multiple addresses", args: args{peanutEmailAddress, []string{someoneEmailAddress, benEmailAddress}, helloEmailMsg}, wantErr: nil},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := mailTransport.Send(tt.args.email_from_address, tt.args.email_to_addresses, tt.args.email_msg)
			if err != tt.wantErr {
				if err != nil && tt.wantErr != nil {
					if err.Error() != tt.wantErr.Error() {
						t.Errorf("smtp transport send failed unexpectedly, expected: %v, got: %v", tt.wantErr, err)
						return
					}
				} else {
					t.Errorf("smtp transport send failed unexpectedly, expected: %v, got: %v", tt.wantErr, err)
					return
				}
			}
			if tt.wantErr == nil {
				// check result of last email send
				messagesFromMockSmtpServer := smtpmockServer.Messages()
				message := last(messagesFromMockSmtpServer)
				expectedMailFrom := fmt.Sprintf(mailFromTmpl, tt.args.email_from_address)
				actualMailFrom := message.MailfromRequest()
				if expectedMailFrom != actualMailFrom {
					t.Errorf("unexpected email message sender, expected: %q, got: %q", expectedMailFrom, actualMailFrom)
					return
				}
				// FIXME: go-smtp-mock implementation is broken, only records last recipient address per message
				// see github issue: https://github.com/mocktools/go-smtp-mock/issues/120
				expectedMailRcpt := fmt.Sprintf(rcptToTmpl, last(tt.args.email_to_addresses))
				actualMailRcpt := message.RcpttoRequest()
				if expectedMailRcpt != actualMailRcpt {
					t.Errorf("unexpected email message recipient, expected: %q, got: %q", expectedMailRcpt, actualMailRcpt)
					return
				}
				// "\r\n" added automatically in sending process
				expectedMsgBody := string(tt.args.email_msg) + msgBodyFooter
				actualMsgBody := message.MsgRequest()
				if expectedMsgBody != actualMsgBody {
					t.Errorf("unexpected email message body, expected: %q, got: %q", expectedMsgBody, actualMsgBody)
					return
				}
			}
		})
	}
}

// EOF

Complete output when running smtpmock, including the stack trace and command used

❯ go test -race /w/v/r/C/internal/mailer
INFO: 2022/11/10 17:05:50.796925 SMTP mock server started on port: 43145
INFO: 2022/11/10 17:05:50.838546 SMTP session started
INFO: 2022/11/10 17:05:50.838594 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.849022 SMTP session started
INFO: 2022/11/10 17:05:50.849099 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.859598 SMTP session started
INFO: 2022/11/10 17:05:50.859691 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.859791 SMTP request: EHLO localhost
INFO: 2022/11/10 17:05:50.863678 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.863719 SMTP request: MAIL<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.866715 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.866744 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.871119 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.871142 SMTP request: DATA
INFO: 2022/11/10 17:05:50.871240 SMTP response: 354 Ready for receive message. End data with <CR><LF>.<CR><LF>
INFO: 2022/11/10 17:05:50.871267 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.871275 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.871288 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.871308 SMTP request: QUIT
INFO: 2022/11/10 17:05:50.871391 SMTP response: 221 Closing connection
INFO: 2022/11/10 17:05:50.871418 SMTP session finished
INFO: 2022/11/10 17:05:50.881919 SMTP session started
==================
WARNING: DATA RACE
Write at 0x00c0001d8ac8 by goroutine 27:
  github.com/mocktools/go-smtp-mock.(*messages).append()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/message.go:139 +0x164
  github.com/mocktools/go-smtp-mock.(*Server).newMessage()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:127 +0xfd
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:170 +0xfe
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Previous read at 0x00c0001d8ac8 by goroutine 21:
  github.com/mocktools/go-smtp-mock.(*Server).Messages()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:121 +0x2d6
  bitbucket.org/vxxxxxxx/cxxxxxxxx/internal/mailer.TestSMTPTransport_Send.func1()
      /wrk/vada/r/CMDR/internal/mailer/smtp_transport_test.go:119 +0x292
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1486 +0x47

Goroutine 27 (running) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae

Goroutine 21 (finished) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1486 +0x724
  bitbucket.org/vxxxxxxx/cxxxxxxxx/internal/mailer.TestSMTPTransport_Send()
      /wrk/vada/r/CMDR/internal/mailer/smtp_transport_test.go:99 +0xec4
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1486 +0x47
==================
INFO: 2022/11/10 17:05:50.882110 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.882191 SMTP request: EHLO localhost
INFO: 2022/11/10 17:05:50.885873 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.885935 SMTP request: MAIL<EMAIL_ADDRESS>ERROR: 2022/11/10 17:05:50.889121 read tcp <IP_ADDRESS>:43145-><IP_ADDRESS>:49552: read: connection reset by peer
==================
WARNING: DATA RACE
Read at 0x00c0000b87e0 by goroutine 16:
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:78 +0x64
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

INFO: 2022/11/10 17:05:50.889147 SMTP session finished
Previous write at 0x00c0000b87e0 by goroutine 19:
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:79 +0x204
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Goroutine 16 (running) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae

Goroutine 19 (running) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae
==================
==================
WARNING: DATA RACE
Read at 0x00c0003300e8 by goroutine 16:
  sync/atomic.LoadInt32()
      /usr/local/go/src/runtime/race_amd64.s:200 +0xb
  sync/atomic.LoadInt32()
      <autogenerated>:1 +0x16
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:82 +0x284
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Previous write at 0x00c0003300e8 by goroutine 19:
  log.New()
      /usr/local/go/src/log/log.go:68 +0xc6
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:79 +0x75
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Goroutine 16 (running) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae

Goroutine 19 (finished) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae
==================
==================
WARNING: DATA RACE
Write at 0x00c0003300a0 by goroutine 16:
  sync/atomic.CompareAndSwapInt32()
      /usr/local/go/src/runtime/race_amd64.s:308 +0xb
  sync/atomic.CompareAndSwapInt32()
      <autogenerated>:1 +0x1e
  log.(*Logger).Output()
      /usr/local/go/src/log/log.go:176 +0x88
  log.(*Logger).Println()
      /usr/local/go/src/log/log.go:223 +0x84
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:82 +0x284
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Previous write at 0x00c0003300a0 by goroutine 19:
  log.New()
      /usr/local/go/src/log/log.go:68 +0xc6
  github.com/mocktools/go-smtp-mock.(*eventLogger).error()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/logger.go:79 +0x75
  github.com/mocktools/go-smtp-mock.(*session).readRequest()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/session.go:119 +0xe7
  github.com/mocktools/go-smtp-mock.(*Server).handleSession()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:179 +0x204
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1.1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:80 +0x7b

Goroutine 16 (running) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae

Goroutine 19 (finished) created at:
  github.com/mocktools/go-smtp-mock.(*Server).Start.func1()
      /home/br/go/pkg/mod/github.com/mocktools/go-smtp-mock@v1.10.0/server.go:79 +0xae
==================
ERROR: 2022/11/10 17:05:50.889228 read tcp <IP_ADDRESS>:43145-><IP_ADDRESS>:49546: read: connection reset by peer
INFO: 2022/11/10 17:05:50.889303 SMTP session finished
INFO: 2022/11/10 17:05:50.890609 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.890655 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.895050 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.895092 SMTP request: DATA
INFO: 2022/11/10 17:05:50.895190 SMTP response: 354 Ready for receive message. End data with <CR><LF>.<CR><LF>
INFO: 2022/11/10 17:05:50.895226 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.895236 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.895250 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.895284 SMTP request: QUIT
INFO: 2022/11/10 17:05:50.895368 SMTP response: 221 Closing connection
INFO: 2022/11/10 17:05:50.895387 SMTP session finished
INFO: 2022/11/10 17:05:50.905903 SMTP session started
INFO: 2022/11/10 17:05:50.905951 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.906008 SMTP request: EHLO localhost
INFO: 2022/11/10 17:05:50.909605 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.909655 SMTP request: MAIL<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.912594 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.912629 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.916907 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.916953 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.921127 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.921170 SMTP request: DATA
INFO: 2022/11/10 17:05:50.921270 SMTP response: 354 Ready for receive message. End data with <CR><LF>.<CR><LF>
INFO: 2022/11/10 17:05:50.921296 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.921306 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.921318 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.921348 SMTP request: QUIT
INFO: 2022/11/10 17:05:50.921426 SMTP response: 221 Closing connection
INFO: 2022/11/10 17:05:50.921442 SMTP session finished
INFO: 2022/11/10 17:05:50.931890 SMTP session started
INFO: 2022/11/10 17:05:50.931967 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.932040 SMTP request: EHLO localhost
INFO: 2022/11/10 17:05:50.936743 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.936792 SMTP request: MAIL<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.941325 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.941369 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.947843 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.947883 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.954301 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.954346 SMTP request: DATA
INFO: 2022/11/10 17:05:50.954527 SMTP response: 354 Ready for receive message. End data with <CR><LF>.<CR><LF>
INFO: 2022/11/10 17:05:50.954566 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.954579 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.954599 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.954634 SMTP request: QUIT
INFO: 2022/11/10 17:05:50.954759 SMTP response: 221 Closing connection
INFO: 2022/11/10 17:05:50.954802 SMTP session finished
INFO: 2022/11/10 17:05:50.965330 SMTP session started
INFO: 2022/11/10 17:05:50.965423 SMTP response: 220 Welcome
INFO: 2022/11/10 17:05:50.965479 SMTP request: EHLO localhost
INFO: 2022/11/10 17:05:50.971722 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.971760 SMTP request: MAIL<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.977719 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.977756 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.987160 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.987220 SMTP request: RCPT<EMAIL_ADDRESS>INFO: 2022/11/10 17:05:50.996182 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.996260 SMTP request: DATA
INFO: 2022/11/10 17:05:50.996443 SMTP response: 354 Ready for receive message. End data with <CR><LF>.<CR><LF>
INFO: 2022/11/10 17:05:50.996507 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.996523 SMTP request: message binary data portion
INFO: 2022/11/10 17:05:50.996551 SMTP response: 250 Received
INFO: 2022/11/10 17:05:50.996608 SMTP request: QUIT
INFO: 2022/11/10 17:05:50.996802 SMTP response: 221 Closing connection
INFO: 2022/11/10 17:05:50.996861 SMTP session finished
--- FAIL: TestSMTPTransport_Send (0.21s)
    --- FAIL: TestSMTPTransport_Send/hello_world_email_from_ben_to_someone (0.02s)
        testing.go:1312: race detected during execution of test
    testing.go:1312: race detected during execution of test
FAIL
2022/11/10 17:05:51 1
WARNING: 2022/11/10 17:05:51.047892 SMTP mock server is in the shutdown mode and won't accept new connections
INFO: 2022/11/10 17:05:51.047984 SMTP mock server was stopped successfully
FAIL	bitbucket.org/vxxxxxxx/cxxxxxxxx/internal/mailer	0.262s
FAIL

@benjamin-rood Hello! Thanks for your report. Seems like it an urgent issue, I'll take a look as soon as possible. I will be grateful for suggestions.

Thanks for your prompt acknowledgement, Vladislav. Yes, it's very urgent, I think!

I will be grateful for suggestions.

To begin with, can you tell me: Am I doing it the correct way, by creating a mock server instance in TestMain? Have you never encountered any race conditions before?

The only possible issue I can notice on the caller side—i.e. my code, SMTPTransport.Send(...) being tested—is that on encountering an error I'm not sending a signal to the server to finish the session before bailing out and returning an error. So, I will fix that in my code to rule out that as a cause, but, at a minimum you will need to use the sync.RWMutex in any reads as well as part of the writes. The lock doesn't automagically work, readers and writers both need to use it.

Just cloned this repo and ran the tests with the -race flag.  Disabled by default
-host string
Host address where smtpmock will run. It's equal to <IP_ADDRESS> by default
-log
Enables log server activity.  It's equal to 10485760 bytes
-multipleMessageReceiving
Enables multiple message receiving scenario. Disabled by default
-notRegisteredEmails string
Not registered (non-existent) RCPT TO emails, separated by commas
-port int
Server port number. If not specified it will be assigned dynamically
-responseDelayData int
DATA response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayHelo int
HELO response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayMailfrom int
MAIL FROM response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayMessage int
Message response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayQuit int
QUIT response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayRcptto int
RCPT TO response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayRset int
RSET response delay in seconds. It runs immediately (equals to 0 seconds) by default
-sessionTimeout int
Session timeout in seconds. It's equal to 30 seconds by default
-shutdownTimeout int
Graceful shutdown timeout in seconds. It's equal to 1 second by default
-v	Prints current smtpmock version
=== RUN   TestRun/when_server_starting_error
=== RUN   TestRun/when_server_was_started_successfully,interrupt_signal(exit_2)_received
=== RUN   TestRun/when_server_was_started_successfully,quit_signal(exit_3)_received
=== RUN   TestRun/when_server_was_started_successfully,terminated_signal(exit_15)_received
=== RUN   TestRun/when_version_flag_passed
smtpmock: unknown-version
commit: unknown-commit
built at: unknown-buildtime
--- PASS: TestRun (0.00s)
--- PASS: TestRun/when_command_line_argument_error (0.00s)
--- PASS: TestRun/when_server_starting_error (0.00s)
--- PASS: TestRun/when_server_was_started_successfully,interrupt_signal(exit_2)_received (0.00s)
--- PASS: TestRun/when_server_was_started_successfully,quit_signal(exit_3)_received (0.00s)
--- PASS: TestRun/when_server_was_started_successfully,terminated_signal(exit_15)_received (0.00s)
--- PASS: TestRun/when_version_flag_passed (0.00s)
=== RUN   TestToSlice
=== RUN   TestToSlice/converts_string_separated_by_commas_to_slice_of_strings
--- PASS: TestToSlice (0.00s)
--- PASS: TestToSlice/converts_string_separated_by_commas_to_slice_of_strings (0.00s)
=== RUN   TestPrintVersionData
=== RUN   TestPrintVersionData/#00
--- PASS: TestPrintVersionData (0.00s)
--- PASS: TestPrintVersionData/#00 (0.00s)
=== RUN   TestAttrFromCommandLine
=== RUN   TestAttrFromCommandLine/when_known_flags_found_creates_pointer_to_ConfigurationAttr_based_on_passed_command_line_arguments
=== RUN   TestAttrFromCommandLine/when_unknown_flags_found_sends_exit_signal
flag provided but not defined: -notKnownFlag
Usage of some-path-to-the-program:
-blacklistedHeloDomains string
Blacklisted HELO domains, separated by commas
-blacklistedMailfromEmails string
Blacklisted MAIL FROM emails, separated by commas
-blacklistedRcpttoEmails string
Blacklisted RCPT TO emails, separated by commas
-failFast
Enables fail fast scenario. Disabled by default
-host string
Host address where smtpmock will run. It's equal to <IP_ADDRESS> by default
-log
Enables log server activity.  It's equal to 10485760 bytes
-multipleMessageReceiving
Enables multiple message receiving scenario. Disabled by default
-notRegisteredEmails string
Not registered (non-existent) RCPT TO emails, separated by commas
-port int
Server port number. If not specified it will be assigned dynamically
-responseDelayData int
DATA response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayHelo int
HELO response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayMailfrom int
MAIL FROM response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayMessage int
Message response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayQuit int
QUIT response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayRcptto int
RCPT TO response delay in seconds. It runs immediately (equals to 0 seconds) by default
-responseDelayRset int
RSET response delay in seconds. It runs immediately (equals to 0 seconds) by default
-sessionTimeout int
Session timeout in seconds. It's equal to 30 seconds by default
-shutdownTimeout int
Graceful shutdown timeout in seconds. It's equal to 1 second by default
-v	Prints current smtpmock version
--- PASS: TestAttrFromCommandLine (0.00s)
--- PASS: TestAttrFromCommandLine/when_known_flags_found_creates_pointer_to_ConfigurationAttr_based_on_passed_command_line_arguments (0.00s)
--- PASS: TestAttrFromCommandLine/when_unknown_flags_found_sends_exit_signal (0.00s)
PASS
ok  	github.com/mocktools/go-smtp-mock/cmd	0.028s
?   	github.com/mocktools/go-smtp-mock/cmd/version	[no test files]
FAIL
</details>

I've played with the code and seemingly fixed the race conditions, at least as they occur in the repo's own tests. Will push it soon as a PR where we can discuss the approach.

PR: https://github.com/mocktools/go-smtp-mock/pull/125

To begin with, can you tell me: Am I doing it the correct way, by creating a mock server instance in TestMain?

The main idea of using was start iteration with server instance (with predefined behaviour) during tests and terminate after:
server := smtpmock.New(smtpmock.ConfigurationAttr{})
server.Start()

hostAddress, portNumber := "<IP_ADDRESS>", server.PortNumber
connection, _ := net.DialTimeout("tcp", fmt.Sprintf("%s:%d", hostAddress, portNumber), time.Duration(2) * time.Second)

client, _ := smtp.NewClient(connection, hostAddress)
client.Hello("example.com")
client.Quit()
client.Close()

// Each result of SMTP session will be saved as message.
// To get access to server messages use Messages() method
server.Messages()

server.Stop()

Secondly, is this the first time you have encountered any reports of race conditions?

Yeah, your report has been the first. I am ashamed 😟, but I forgot to add the task about passing tests with a race flag to the backlog.

I've played with the code and seemingly fixed the race conditions, at least as they occur in the repo's own tests. Will push it soon as a PR where we can discuss the approach.

Awesome, thanks 👍  I'll review it.

" I am ashamed 😟" - Never, don't be.
This project is awesome and it will only get better with these proposals

" I am ashamed 😟" - Never, don't be. This project is awesome and it will only get better with these proposals

Thank you, Mark!

@dandare100, @benjamin-rood Already in latest (2.0.0) release 🚀

Fantastic turnaround time! 😎👏👏👏👏

Message ID: @.***>

Fantastic turnaround time! 😎👏👏👏👏

I'm really appreciate your intention, report with extended comments and PR to get smtpmock better. Thank you, Benjamin! It was a pleasure to have a code-time with you 🍻


influxdb-lua

Whether it is possible to make a client for interacting with InfluxDB through Lua?

That wouldn't be the scope of this repository, but I can answer your question: Yes it would be possible to write an InfluxDB client library in the Lua programming language.


Updated workflow to not publish a container for PRs opened by the Ren…

…ovate bot

That seems for the best!


Add a webview to scaffold plugins through creator add subcommand

This PR adds a new webview for adding a plugin(filter, lookup) to an existing collection.
New Add Plugin Webview
This view can add plugins (filter, lookup) to an existing collection. The available fields are: Collection Path, Plugin Name and Plugin Type.

Collection Path: The existing collection path that will be the destination where the plugin gets added. If the destination path is an invalid collection, an error message comes up.
Plugin Name: The name you want to create your plugin with.
Plugin Type: The type of plugin user want to add in their collection. Right now ansible-creator has support for adding filter and lookup plugins. The same plugins are supported via vscode-extension webview.

Webview

JIRA: AAP-35655

Can you also add an entry in the codecov.yml file for addPluginPageApp.ts? (see https://github.com/ansible/vscode-ansible/pull/1719/files)
This is because webpack mangles the app files to the point where codecov cannot read coverage data.

@audgirka @alisonlhart Do we also need to remove the log output to file, copy logs and open log file options from this webview just like we removed them from the devfile, devcontainer and the execution-environment webviews?

Can you also add an entry in the codecov.yml file for addPluginPageApp.ts? (see https://github.com/ansible/vscode-ansible/pull/1719/files) This is because webpack mangles the app files to the point where codecov cannot read coverage data.

Done!

I still see ci failures

@audgirka @alisonlhart Do we also need to remove the log output to file, copy logs and open log file options from this webview just like we removed them from the devfile, devcontainer and the execution-environment webviews?

Yes, that would be ideal. We can always add them back if it seems needed, but starting with a more streamlined view seems best.

@audgirka @alisonlhart Do we also need to remove the log output to file, copy logs and open log file options from this webview just like we removed them from the devfile, devcontainer and the execution-environment webviews?

Yes, please remove this option from the UI

@abhikdps @alisonlhart @audgirka Removed the log output to file, copy logs and open log file options from the view!

@shatakshiiii Also we can go ahead and sort by title on the sidebar "Add" section like you suggested earlier.

@shatakshiiii Also we can go ahead and sort by title on the sidebar "Add" section like you suggested earlier.

Sorted!


Database Migration Meta Issue

This is a collection of proposed database changes:

[ ] #51: remove the benchmark_suite column from the study table as it is not used in production.
[ ] #51: migrate legacy studies over to new-style studies.

The flow (implementation) server logic treats (name, external_version) as a unique tuple, but this is not enforced at the database level.

The flow (implementation) table has an uploadDate that does not have a default. I imagine that other tables also have this. I do not know why this is not default at the database level.


Cache images in byte instead of float32 in GS training/eval

Is your feature request related to a problem? Please describe.
When training GS with large number of images (>1000), caching images consumes a lot memory even for CPU mem. It is because the current cached images are preprocessed as float32 tensors. See InputDataset.get_image() function. If those images are cached as bytes, we would be 4x more memory efficient and allow to run GS on lower end machines.
Describe the solution you'd like
Add a feature to allow caching images in bytes and do image / 255. only fly during training.
Describe alternatives you've considered
No.
Additional context
for an image with 1600x1600x3, caching 1000 images in bytes consumes about 7.7GB, while caching them in float32 consumes 4 times more.

Sounds good to me, my only worry would be a slowdown having to cast every image back to float for training. It shouldn't be that expensive but would be good to measure before merging

Sounds good to me, my only worry would be a slowdown having to cast every image back to float for training. It shouldn't be that expensive but would be good to measure before merging

Maybe we can trigger this function if the dataset is too Big?
When data is small, its using default float32. But, if they are potentially OOM CUDA caused by large dataset, it automatically cache the image by bytes.
IMO, Its better slowdown training (in large dataset) instead of OOM CUDA.


Feature Proposal: Users can enter a "class code" to join a classroom

I'm a contributor to the new classroom mode application for FreeCodeCamp.  Based on the discussion in this thread, we would like to start tracking a user's number of attempts for each challenge.
Quincy mentioned that he would like to ensure that this data is viewable only by the individual users and their designated teachers.
The following wireframes propose a solution to this problem.  The idea is to allow a user to enter a "class code".   We can then use this "class code" to control access to their data in the open-api codebase and classroom mode.
@QuincyLarson, please let me know if you approve of this feature.  If so, I'm happy to get started working on this with the rest of our classroom mode team.

Hi Utsab,
This is a cool feature idea. The settings view is the right place to put this.
We would want this to be a separate area of the settings page - that space is just for editing/previewing the bio and I think most people would miss that if we put it there.
It could be a section with the heading "Join a class" where they can enter a classroom code and it would say something like "You're now part of Mr. Wagner's AP Computer Science class" or something like that, where each class would have both a name and an identifying number.
I agree that having them enter an alphanumeric code would be ideal, since it would reduce the discoverability of these classes.

This will involve updating our open API so I'm @-mentioning @ojongerius and @raisedadead here.

Guys I think that since this issue is more related to our Classroom project, it should be opened there and this one closed for now?

@thecodingaviator, sorry for the late reply on this.  It's true that this feature is related to the Classroom Mode project, but the class-code should be generated from within the learn codebase.  This class-code will serve as a key that the open-api will use to control access to the user's data.

Oh, I see

@utsab We can revisit this once we have our open API live. I agree that we want some prominent way to "enroll" in a class right from settings. We'll have a better idea of what that should look like once we have that code live.

I am closing this issue for now. We can revisit classroom mode in Q3 once we have rolled out our curriculum updates and other features.

Hi, I don't have any contribution to make, just would like to express that I'm using freeCodeCamp as a teacher in my (undergraduate level) class and would love to have some of the features you listed for this "Classroom setting".
For me, having the ability to check progress on a group of students would suffice. I used to achieve something similar by scraping public profiles with Yahoo! Pipes, but now that's gone I have no idea how to do it. In other words, a page were I can (manually, if necessary) add a number of public profiles and show a table with

last update
points
progress in lessons?

...would do me a lot of service right now.
Thanks in advance!


[Pygen] None immediate value in asm file

Getting None imm value in asm file for the first randomized immediate instr

You can refer the srli instruction for a better understanding of the issue.
When declaring self.imm_str as (vsc.uint32_t()) data type instead of none I am getting the same imm value for all the srli instructions.
I am assuming this is not related to this issue #641

Hi @aneels3
I don't think there is a need for defining self.imm_str as a vsc data type (makes more sense to define self.imm as a random vsc data type, apply the required constraints on it, and then just cast it to str, as I believe you already did so). Could you please double check and make sure that you don't have constraints that are in conflict with each other (cause if there are such constraints, then this 'none' value makes sense, although I don't believe that this is the case). So alternatively, could you please generate several other programs and see whether or not this behavior is consistent across all of them? I am a bit suspicious of the functionality of the PyVSC randomizer. It might worth looking at the vsc randomizer source code and see how it exactly works. Getting 'none' result in some cases might be true if randomizer tries to find a solution within a default (and limited) number of steps, so when it fails, 'none' will be returned. One of the solvers offered in python-constraint module exploits similar mechanism.

Hi @aneels3  and @hodjat91,
With respect to PyVSC randomization, you should be seeing exceptions thrown if the constraints cannot be resolved. It sounds like you're not seeing this.
How is the string value of the immediate field formed? I'm not aware of cases where PyVSC is intentionally setting field values to Python 'None'.
-Matthew

Hi @mballance ,
Thank you for the clarification on the PyVSC randomization process. The self.imm_str is nothing but a string cast of the randomized immediate value in instructions that operate on immediate values (i.e., addi). The randomized immediate value itself (self.imm) is a standard-width random data type of PyVSC.
-Hodjat

Hi @hodjat91 and @mballance
I don't think this is something related to randomization failure.
I forgot to mention that I have declared self.imm_str = None in the constructor function of the base class.
I cross-checked by assigning some other default value in the constructor function, in this case, I am getting default assigned value instead if None.
-Anil

Hi @aneels3
Thanks for the update. So in this case, my assumption is that the get_imm() and/or update_imm_str() are not called properly. Could you please double-check and make sure that self.imm is actually randomized when you see None/default assigned value for the self.imm_str?
-Hodjat

Hi @aneels3
I looked at your code and found a weird behavior: In class riscv_instr, instead of using the post_randomize(self) (and hence rely on the PyVSC randomizer to take care of the post randomization process), if you decide to define an explicit method (say post_process(self)) and call this method after randomizing your riscv_instr_ins object, the "None" issue in instructions operating on immediate values gets resolved. Initially, I thought that the post_randomize() method might not get called properly, but I actually created a similar scenario and it worked fine. Let's use this post_process() alternative until we find out where does the issue come from. (please add a side note for this to be fixed in future).
-Hodjat

Hi @hodjat91
That makes sense. I have tried as per your suggestion and its working fine now.
I have added a side note as well to map it in a post_randomize() method.
Thanks again!
-Anil

Update: This was an issue with the post_randomize() process in the PyVSC library, which is resolved in the new release.


Need rules for each_item and always

https://github.com/pydantic/bump-pydantic/blob/47c66def557f23b25ce660a1ebc32d4ba9ccae72/bump_pydantic/codemods/validator.py#L92-L93
https://docs.pydantic.dev/dev-v2/migration/#changes-to-validators

What are you proposing here?

Rules
BP0xy: Replace each_item

✅ Replace each_item by something better.

The following code will be transformed:
from pydantic import BaseModel, validator

class User(BaseModel):
    first_name: str
    last_name: str

    @validator("first_name", "last_name", each_item=True)
    def names_must_not_be_empty_strings(cls, v):
        if v:
            return v
        raise ValueError("Empty strings are not permitted")

Into:
from pydantic import BaseModel, field_validator

class User(BaseModel):
    first_name: str
    last_name: str

    @field_validator("first_name", "last_name",  # I am not sure what comes next...

Given the source above https://github.com/pydantic/bump-pydantic/issues/70#issuecomment-1629082847, what should the expected be?

teach how to do it via comment.

Given the source above #70 (comment), what should the expected be?

Were last_name and first_name supposed to be str, and not List[str]?

Let's do List[str] so last_names and first_names (plural).

Then...
If validator method has 2 params (parameter names doesn't matter, but numbers do):
from pydantic import BaseModel, validator

class User(BaseModel):
    first_names: List[str]
    last_names: List[str]

    @validator("first_name", "last_name", each_item=True)
    def names_must_not_be_empty_strings(cls, v):
        if v:
            return v
        raise ValueError("Empty strings are not permitted")

Then we'd get:
from pydantic import BaseModel, validator, BeforeValidator
from typing_extensions import Annotated
from typing import List

# This function goes to the outer scope.
# I think we can get the `ClassDef` parent node with `LibCST.ParentProvider`. But I'm not sure...
def names_must_not_be_empty_strings(v):
    if v:
        return v
    raise ValueError("Empty strings are not permitted")

class User(BaseModel):
    # Check if the `AnnAssign.annotation` (List in this case) is a `Subscriptable` - and if it's, apply `BeforeValidator`.
    first_names: List[Annotated[str, BeforeValidator(names_must_not_be_empty_strings)]]
    last_names: List[Annotated[str, BeforeValidator(names_must_not_be_empty_strings)]]

Remember to import typing_extensions.Annotated, and BeforeValidator, and remove validator.
Also, you might want to check function name collision on the module level - but I'm not sure if this is needed - but an xfail would be nice.
Not finished yet... If the number of params is more than 2, then add a note on top of the method:
# TODO: We couldn't replace the validator automatically.
# Please check https://docs.pydantic.dev/latest/migration/#validator-and-root_validator-are-deprecated.


Updating Misc. part of README.md for better understanding.

This pull request updates the Misc. part of the  README.md file so that the users can now easily understand what's going on and not be confused.
This pull request closes Issue #24

@AkhilProto appreciate the suggestion, but I want to keep the README as small as possible. This is presumed knowledge, just like I presume they know (or can find out) how to install Python.

Ok. I understood. What you said is right! 😀


Policy IPolicyType arguments can only be one RDF Term

https://github.com/eyereasoner/Koreografeye/blob/3fa0ed8c2a8aa4759ad40b84b66d64c419888a8d/src/policy/PolicyPlugin.ts#L14-L16
Due to the IPolicyType type having for the arguments only the possibility to have an RDF.Term with cardinality one, the extractPolicies algorithm will pick a random RDF.Term for the arguments where in the conclusion of  an N3 rule where this cardinality was N.
My proposal is to fix this by introducing a breaking change that will fix this problem:
export type IPolicyType = {
    node: N3.NamedNode | N3.BlankNode;
    path: string;
    policy: string;
    target: string;
    mainSubject: string;
    origin: string;
    order: number;
    args: {
        [key: string]: RDF.Term[];
    };
};

For this, extractPolicies must also be changed to make it possible to add a list of RDF.Term[].
Furthermore, there will be no undefined anymore since it can now have the empty list.

I need to check this first for unintended consequences. The rules can be fired multiple times and we don't want that the args[key] array will get filled with bogus information ..due to this multiple firing of rules.

fixed in release 0.4.0


HDFS-16488. [SPS]: Expose metrics to JMX for external SPS

JIRA: HDFS-16488.
Currently, external SPS has no monitoring metrics. We do not know how many blocks are waiting to be processed, how many blocks are waiting to be retried, and how many blocks have been migrated.
We can expose these metrics in JMX for easy collection and display by monitoring systems.

For example, in our cluster, we exposed these metrics to JMX, collected by JMX-Exporter and combined with Prometheus, and finally display by Grafana.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 46s

trunk passed

+1 :green_heart:
compile
1m 43s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
27m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 30s

the patch passed

+1 :green_heart:
compile
1m 34s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

-1 :x:
javac
1m 34s
/results-compile-javac-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 generated 1 new + 466 unchanged - 0 fixed = 467 total (was 466)

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
4m  4s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
26m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
376m 52s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

492m 46s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Primitive value is boxed and then immediately unboxed in org.apache.hadoop.hdfs.server.sps.metrics.ExternalSPSBeanMetrics.updateMovementFinishedBlocksCount()  At ExternalSPSBeanMetrics.java:then immediately unboxed in org.apache.hadoop.hdfs.server.sps.metrics.ExternalSPSBeanMetrics.updateMovementFinishedBlocksCount()  At ExternalSPSBeanMetrics.java:[line 87]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4035

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 673b06c6b8d6 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 48f6ce4244d90348388cc7f14fbf5b0847321189

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/1/testReport/

Max. process+thread count
2129 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 44s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 39s

trunk passed

+1 :green_heart:
shadedclient
26m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 31s

the patch passed

+1 :green_heart:
shadedclient
25m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
351m 28s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

463m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4035

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0a4e93122a78 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8addfa7ea1a95aa9289d6117042189233ad7a527

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/2/testReport/

Max. process+thread count
1882 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @tasanuma @jojochuang @ferhui , could you please take a look? Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 59s

trunk passed

+1 :green_heart:
compile
1m 34s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
25m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 28s

the patch passed

+1 :green_heart:
shadedclient
25m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
425m 57s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

540m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4035

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c3b03cc805d4 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2dd678f5c52b45cce3563f20fc961522c9b67173

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/3/testReport/

Max. process+thread count
2015 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4035/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much.

Hi @umamaheswararao @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much.

Hi @umamaheswararao @ayushtkn @tasanuma @ferhui , could you please take a look? Thank you very much.

Hi @umamaheswararao @ayushtkn @tasanuma @ferhui
Currently, external SPS has no metrics. We do not know the migration progress of the corresponding block, adding metrics are helpful. Could you please take a look? Thank you very much.

Thanks @ferhui for your review.

Thanks @ayushtkn for your review.

@tomscut Thanks for your contribution. @ayushtkn Thanks for your review! Merged

@tomscut could you please update HDFS-16488 status. I couldn't log in apache site...

Updated

Thanks @ferhui and @ayushtkn .

@tomscut @ferhui @ayushtkn
testExternalSPSMetrics is a duplicated function name which is already defined in TestExternalStoragePolicySatisfier.java
this patch is breaking trunk build, please fix it, thanks.

@tomscut @ferhui @ayushtkn testExternalSPSMetrics is a duplicated function name which is already defined in TestExternalStoragePolicySatisfier.java this patch is breaking trunk build, please fix it, thanks.

Thanks @yuanboliu for pointing this out. I will fix this.

Sorry, revert it.
Next time, will trigger CI if the PR is pending for a long time.

I am sorry. I shouldn't use the same method name.


Add creating of azure security group ports.

Lint report for commit 793a0e9ab57994eb2477a1d433597d8bbbca8af8:
wrapanapi/systems/msazure.py:

:bangbang: Line 676:101: E501 line too long (101 > 100 characters)
:red_circle: Line 772:9: F841 local variable 'security_groups' is assigned to but never used
:bangbang: Line 784:101: E501 line too long (120 > 100 characters)
:bangbang: Line 787:9: E303 too many blank lines (2)

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot


Avoid writing to site-packages/prisma

Problem
By default, the operation prisma db push operation writes to site-packages/prisma. This causes issues for nix users, whose nix store is read only:
nix-shell-env ❯ prisma db push
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "dev.db" at "file:./dev.db"

The database is already in sync with the Prisma schema.

Running generate... - Prisma Client Python (v0.12.0)

Some types are disabled by default due to being incompatible with Mypy, it is highly recommended
to use Pyright instead and configure Prisma Python to use recursive types. To re-enable certain types:

generator client {
  provider             = "prisma-client-py"
  recursive_type_depth = -1
}

If you need to use Mypy, you can also disable this message by explicitly setting the default value:

generator client {
  provider             = "prisma-client-py"
  recursive_type_depth = 5
}

For more information see: https://prisma-client-py.readthedocs.io/en/stable/reference/limitations/#default-type-limitations

Traceback (most recent call last):
  File "/nix/store/s16v3cd2dzg07kjpp7bchb8wp69mwjrv-python3.11-prisma-0.12.0/lib/python3.11/site-packages/
prisma/generator/generator.py", line 108, in run
    self._on_request(request)
  File "/nix/store/s16v3cd2dzg07kjpp7bchb8wp69mwjrv-python3.11-prisma-0.12.0/lib/python3.11/site-packages/
prisma/generator/generator.py", line 161, in _on_request
    self.generate(data)
  File "/nix/store/s16v3cd2dzg07kjpp7bchb8wp69mwjrv-python3.11-prisma-0.12.0/lib/python3.11/site-packages/
prisma/generator/generator.py", line 240, in generate
    shutil.copy(data.schema_path, packaged_schema)
  File "/nix/store/pwr22740f2pv36q5g28l1gjdg1bw43zm-python3-3.11.7/lib/python3.11/shutil.py", line 419, in
 copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/nix/store/pwr22740f2pv36q5g28l1gjdg1bw43zm-python3-3.11.7/lib/python3.11/shutil.py", line 258, in
 copyfile
    with open(dst, 'wb') as fdst:
         ^^^^^^^^^^^^^^^
PermissionError: [Errno 13] Permission denied: '/nix/store/s16v3cd2dzg07kjpp7bchb8wp69mwjrv-python3.11-pri
sma-0.12.0/lib/python3.11/site-packages/prisma/schema.prisma'

Suggested solution
Perhaps this already exists, but there should be some option to configure the path where this write operation is performed.
Thanks!

Hey @ethanabrooks, this is already supported! You just have to specify a custom output directory, https://www.prisma.io/docs/orm/prisma-schema/overview/generators


Close Pull Request When Unassigned

In order to keep our pull requests neat and tidy, the bot should automatically close them out when the bounty hunter is disqualified for inactivity on the bounty. Technically we can inject this behavior on top of the /unassign command I believe, that way it will happen both during the disqualification, or if the bounty hunter gives up the bounty by invoking the command.

I think that makes sense to close the pull requests when unassigned. Perhaps we should also have the bot do that.

Originally posted by @pavlovcik in https://github.com/ubiquity/ubiquity-dollar/issues/634#issuecomment-1575532629

/assign

@0xcodercrane do you understand why the claim URL is 18.75 WXDAI while the price label is 25 USD? I'm expecting the payout to be 25 WXDAI if @wannacfuture has a default bounty modifier

I feel like we have two layers of complexity regarding this problem of unexpected payout amounts.

we don't have the labels automatically updating when the base-rate is updated
multipliers

Because money is generally a sensitive topic, we should figure out a solution to clearly express what the payout amount will be. Perhaps in the bot's response for a bounty being assigned, it should clarify what the total bounty compensation will be for the assignee, which will re-check the base-rate AND the current multiplier for the bounty hunter.


Something is missing in this instructions on how to debug a Blazor Webassembly hosted.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec2f61c7-9f51-6735-e328-3c7b495d70c3
Version Independent ID: 4d06e565-282d-6387-aa90-cb2c2986d35a
Content: Debug ASP.NET Core Blazor WebAssembly
Content Source: aspnetcore/blazor/debug.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

I followed the instructions on how to debug a Blazor Webassembly hosted and i get the error:
You don't have an extension for debugging 'JSON with Comments'

I found out the solution on the CuriousDrive youtube channel. You should HIRE him beccause he's doing a better job than you guys, and I think you need someone who knows how to use your programming tools.
In the visual studio code separator you should explicitly give a concrete example of what developers should have on launch.jsno and tasks.json. Not that nonsense you have there with just a few floating lines of code that means nothing. It would be better to say you don't know how to use your own tools. But Curious drive does how to use them.
Here's how he does, and it works:
https://github.com/CuriousDrive/BlazingChat/tree/main/src/.vscode


winget 1.3.431-preview - upgrade --include-unknown does not include anything more

Brief description of your issue
Trying out winget 1.3.431-preview.
winget upgrade

Notice the last line.

Name            Id              Version      Available   Source
---------------------------------------------------------------
Git             Git.Git         2.20.1       <IP_ADDRESS>    winget
HexChat         HexChat.HexChat 2.14.2       2.16.1      winget
Microsoft Teams Microsoft.Teams <IP_ADDRESS>57 <IP_ADDRESS>89 winget
Authy Desktop   Twilio.Authy    1.9.0        2.0.0       winget
Microsoft Teams Microsoft.Teams <IP_ADDRESS>53  <IP_ADDRESS>89 winget
5 upgrades available.
1 package has a version number that cannot be determined. Use "--include-unknown" to see all results.

Logs
2022-03-13 20:42:44.603 [CORE] WinGet, version [1.3.0-preview], activity [{0200461E-436F-49F4-88CA-E0E2A6BB0CB0}]
2022-03-13 20:42:44.606 [CORE] OS: Windows.Desktop v10.0.19044.1586
2022-03-13 20:42:44.606 [CORE] Command line Args: winget  upgrade
2022-03-13 20:42:44.606 [CORE] IsCOMCall:0; Caller: winget-cli
2022-03-13 20:42:44.607 [CLI ] WinGet invoked with arguments: 'upgrade'
2022-03-13 20:42:44.607 [CLI ] Found subcommand: upgrade
2022-03-13 20:42:44.607 [CLI ] Leaf command to execute: root:upgrade
2022-03-13 20:42:44.608 [CLI ] Executing command: upgrade
2022-03-13 20:42:44.611 [REPO] GetCurrentSourceRefs: Source named 'microsoft.builtin.desktop.frameworks' from origin Default is hidden and is dropped.
2022-03-13 20:42:44.611 [REPO] Default source requested, multiple sources available, adding all to source references.
2022-03-13 20:42:44.611 [REPO] Adding to source references msstore
2022-03-13 20:42:44.611 [REPO] Adding to source references winget
2022-03-13 20:42:44.614 [REPO] Multiple sources available, creating aggregated source.
2022-03-13 20:42:44.614 [REPO] Adding to aggregated source: msstore
2022-03-13 20:42:44.614 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2022-03-13 20:42:44.832 [REPO] Response status: 200
2022-03-13 20:42:44.832 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2022-03-13 20:42:44.926 [REPO] Response status: 200
2022-03-13 20:42:44.926 [REPO] Adding to aggregated source: winget
2022-03-13 20:42:44.927 [REPO] Opening SQLite Index for Read at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.PreIndexed.Package\Microsoft.Winget.Source_8wekyb3d8bbwe\index.db'
2022-03-13 20:42:44.927 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.PreIndexed.Package\Microsoft.Winget.Source_8wekyb3d8bbwe\index.db' [1, 0]
2022-03-13 20:42:44.929 [REPO] Opened SQLite Index with version [1.3], last write [2022-03-13 16:11:00.000]
2022-03-13 20:42:45.260 [REPO] Creating PredefinedInstalledSource with filter [None]
2022-03-13 20:42:45.260 [REPO] Creating new SQLite Index [4294967295.4294967295] at ':memory:'
2022-03-13 20:42:45.260 [SQL ] Opening SQLite connection: ':memory:' [6, 0]
2022-03-13 20:42:45.323 [REPO] Examining ARP entries for Machine | X64
2022-03-13 20:42:45.378 [REPO] Examining ARP entries for Machine | X86
2022-03-13 20:42:45.438 [REPO] Examining ARP entries for User | X64
2022-03-13 20:42:45.895 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\StoreEdgeFD\installed.db'
2022-03-13 20:42:45.895 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\StoreEdgeFD\installed.db' [2, 0]
2022-03-13 20:42:45.896 [REPO] Opened SQLite Index with version [1.4], last write [2022-03-13 20:34:16.000]
2022-03-13 20:42:45.956 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db'
2022-03-13 20:42:45.956 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db' [2, 0]
2022-03-13 20:42:45.958 [REPO] Opened SQLite Index with version [1.4], last write [2022-03-13 20:34:16.000]
2022-03-13 20:42:46.085 [REPO] Found multiple matches for installed package [Audacity_is1] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='audacity_is1'[Exact] Include:NormalizedNameAndPublisher='audacity'+'audacityteam'[Exact]]
2022-03-13 20:42:46.086 [REPO]   Checking match with package id: Audacity.Audacity
2022-03-13 20:42:46.088 [REPO]   Checking match with package id: Audacity.Audacity.Alpha
2022-03-13 20:42:46.287 [REPO] Found multiple matches for installed package [Mozilla Firefox 98.0 (x64 en-US)] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='mozilla firefox 98.0 (x64 en-us)'[Exact] Include:NormalizedNameAndPublisher='mozillafirefox'+'mozilla'[Exact]]
2022-03-13 20:42:46.289 [REPO]   Checking match with package id: Mozilla.Firefox.Beta
2022-03-13 20:42:46.291 [REPO]   Checking match with package id: Mozilla.Firefox
2022-03-13 20:42:46.291 [REPO]   Appropriate available package could not be determined
2022-03-13 20:42:46.440 [REPO] Found multiple matches for installed package [{1D8E6291-B0D5-35EC-8441-6616F567A0F7}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{1d8e6291-b0d5-35ec-8441-6616f567a0f7}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2010redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.442 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x64
2022-03-13 20:42:46.443 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x86
2022-03-13 20:42:46.468 [REPO] Found multiple matches for installed package [{2aaf1df0-eb13-4099-9992-962bb4e596d1}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{2aaf1df0-eb13-4099-9992-962bb4e596d1}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualcredistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.470 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x64
2022-03-13 20:42:46.471 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x86
2022-03-13 20:42:46.473 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x86
2022-03-13 20:42:46.475 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x64
2022-03-13 20:42:46.499 [REPO] Found multiple matches for installed package [{41d7b770-418a-43b7-95a5-f925fff05789}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{41d7b770-418a-43b7-95a5-f925fff05789}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualcredistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.501 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x86
2022-03-13 20:42:46.502 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x64
2022-03-13 20:42:46.504 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x86
2022-03-13 20:42:46.506 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x64
2022-03-13 20:42:46.543 [REPO] Found multiple matches for installed package [{5FCE6D76-F5DC-37AB-B2B8-22AB8CEDB1D4}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{5fce6d76-f5dc-37ab-b2b8-22ab8cedb1d4}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2008redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.545 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x64
2022-03-13 20:42:46.546 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x86
2022-03-13 20:42:46.570 [REPO] Found multiple matches for installed package [{710f4c1c-cc18-4c49-8cbf-51240c89a1a2}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{710f4c1c-cc18-4c49-8cbf-51240c89a1a2}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2005redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.571 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x86
2022-03-13 20:42:46.572 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x64
2022-03-13 20:42:46.620 [REPO] Found multiple matches for installed package [{9BE518E6-ECC6-35A9-88E4-87755C07200F}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{9be518e6-ecc6-35a9-88e4-87755c07200f}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2008redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.622 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x86
2022-03-13 20:42:46.623 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x64
2022-03-13 20:42:46.711 [REPO] Found multiple matches for installed package [{F0C3E5D1-1ADE-321E-8167-68EF0DE699A5}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{f0c3e5d1-1ade-321e-8167-68ef0de699a5}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2010redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.713 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x86
2022-03-13 20:42:46.714 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x64
2022-03-13 20:42:46.728 [REPO] Found multiple matches for installed package [{ad8a2fa1-06e7-4b0d-927d-6e54b3d31028}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{ad8a2fa1-06e7-4b0d-927d-6e54b3d31028}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2005redistributable'+'microsoft'[Exact]]
2022-03-13 20:42:46.729 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x64
2022-03-13 20:42:46.730 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x86
2022-03-13 20:42:46.936 [CLI ] Leaf command succeeded: root:upgrade

winget upgrade --include-unknown

Notice it still returns 5 packages only.

Name            Id              Version      Available   Source
---------------------------------------------------------------
Git             Git.Git         2.20.1       <IP_ADDRESS>    winget
HexChat         HexChat.HexChat 2.14.2       2.16.1      winget
Microsoft Teams Microsoft.Teams <IP_ADDRESS>57 <IP_ADDRESS>89 winget
Authy Desktop   Twilio.Authy    1.9.0        2.0.0       winget
Microsoft Teams Microsoft.Teams <IP_ADDRESS>53  <IP_ADDRESS>89 winget
5 upgrades available.

Logs
2022-03-13 20:43:54.989 [CORE] WinGet, version [1.3.0-preview], activity [{B28E63EB-F2A8-4F80-B056-E5B3B4CC38F7}]
2022-03-13 20:43:54.991 [CORE] OS: Windows.Desktop v10.0.19044.1586
2022-03-13 20:43:54.991 [CORE] Command line Args: winget  upgrade --include-unknown
2022-03-13 20:43:54.991 [CORE] IsCOMCall:0; Caller: winget-cli
2022-03-13 20:43:54.992 [CLI ] WinGet invoked with arguments: 'upgrade' '--include-unknown'
2022-03-13 20:43:54.992 [CLI ] Found subcommand: upgrade
2022-03-13 20:43:54.993 [CLI ] Leaf command to execute: root:upgrade
2022-03-13 20:43:54.994 [CLI ] Executing command: upgrade
2022-03-13 20:43:54.997 [REPO] GetCurrentSourceRefs: Source named 'microsoft.builtin.desktop.frameworks' from origin Default is hidden and is dropped.
2022-03-13 20:43:54.997 [REPO] Default source requested, multiple sources available, adding all to source references.
2022-03-13 20:43:54.997 [REPO] Adding to source references msstore
2022-03-13 20:43:54.997 [REPO] Adding to source references winget
2022-03-13 20:43:55.000 [REPO] Multiple sources available, creating aggregated source.
2022-03-13 20:43:55.000 [REPO] Adding to aggregated source: msstore
2022-03-13 20:43:55.000 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2022-03-13 20:43:55.223 [REPO] Response status: 200
2022-03-13 20:43:55.224 [REPO] Sending http GET request to: https://storeedgefd.dsx.mp.microsoft.com/v9.0/information
2022-03-13 20:43:55.330 [REPO] Response status: 200
2022-03-13 20:43:55.330 [REPO] Adding to aggregated source: winget
2022-03-13 20:43:55.331 [REPO] Opening SQLite Index for Read at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.PreIndexed.Package\Microsoft.Winget.Source_8wekyb3d8bbwe\index.db'
2022-03-13 20:43:55.331 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.PreIndexed.Package\Microsoft.Winget.Source_8wekyb3d8bbwe\index.db' [1, 0]
2022-03-13 20:43:55.333 [REPO] Opened SQLite Index with version [1.3], last write [2022-03-13 16:11:00.000]
2022-03-13 20:43:55.634 [REPO] Creating PredefinedInstalledSource with filter [None]
2022-03-13 20:43:55.634 [REPO] Creating new SQLite Index [4294967295.4294967295] at ':memory:'
2022-03-13 20:43:55.634 [SQL ] Opening SQLite connection: ':memory:' [6, 0]
2022-03-13 20:43:55.697 [REPO] Examining ARP entries for Machine | X64
2022-03-13 20:43:55.750 [REPO] Examining ARP entries for Machine | X86
2022-03-13 20:43:55.807 [REPO] Examining ARP entries for User | X64
2022-03-13 20:43:56.262 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\StoreEdgeFD\installed.db'
2022-03-13 20:43:56.262 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\StoreEdgeFD\installed.db' [2, 0]
2022-03-13 20:43:56.263 [REPO] Opened SQLite Index with version [1.4], last write [2022-03-13 20:34:16.000]
2022-03-13 20:43:56.323 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db'
2022-03-13 20:43:56.323 [SQL ] Opening SQLite connection: 'C:\Users\olavb\AppData\Local\Microsoft/WinGet\State\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db' [2, 0]
2022-03-13 20:43:56.325 [REPO] Opened SQLite Index with version [1.4], last write [2022-03-13 20:34:16.000]
2022-03-13 20:43:56.452 [REPO] Found multiple matches for installed package [Audacity_is1] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='audacity_is1'[Exact] Include:NormalizedNameAndPublisher='audacity'+'audacityteam'[Exact]]
2022-03-13 20:43:56.453 [REPO]   Checking match with package id: Audacity.Audacity
2022-03-13 20:43:56.454 [REPO]   Checking match with package id: Audacity.Audacity.Alpha
2022-03-13 20:43:56.652 [REPO] Found multiple matches for installed package [Mozilla Firefox 98.0 (x64 en-US)] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='mozilla firefox 98.0 (x64 en-us)'[Exact] Include:NormalizedNameAndPublisher='mozillafirefox'+'mozilla'[Exact]]
2022-03-13 20:43:56.654 [REPO]   Checking match with package id: Mozilla.Firefox.Beta
2022-03-13 20:43:56.656 [REPO]   Checking match with package id: Mozilla.Firefox
2022-03-13 20:43:56.656 [REPO]   Appropriate available package could not be determined
2022-03-13 20:43:56.804 [REPO] Found multiple matches for installed package [{1D8E6291-B0D5-35EC-8441-6616F567A0F7}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{1d8e6291-b0d5-35ec-8441-6616f567a0f7}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2010redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.806 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x64
2022-03-13 20:43:56.807 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x86
2022-03-13 20:43:56.831 [REPO] Found multiple matches for installed package [{2aaf1df0-eb13-4099-9992-962bb4e596d1}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{2aaf1df0-eb13-4099-9992-962bb4e596d1}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualcredistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.833 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x64
2022-03-13 20:43:56.835 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x86
2022-03-13 20:43:56.836 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x86
2022-03-13 20:43:56.838 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x64
2022-03-13 20:43:56.862 [REPO] Found multiple matches for installed package [{41d7b770-418a-43b7-95a5-f925fff05789}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{41d7b770-418a-43b7-95a5-f925fff05789}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualcredistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.864 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x86
2022-03-13 20:43:56.866 [REPO]   Checking match with package id: Microsoft.VC++2015-2022Redist-x64
2022-03-13 20:43:56.868 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x86
2022-03-13 20:43:56.869 [REPO]   Checking match with package id: Microsoft.VC++2015-2019Redist-x64
2022-03-13 20:43:56.906 [REPO] Found multiple matches for installed package [{5FCE6D76-F5DC-37AB-B2B8-22AB8CEDB1D4}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{5fce6d76-f5dc-37ab-b2b8-22ab8cedb1d4}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2008redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.908 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x64
2022-03-13 20:43:56.909 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x86
2022-03-13 20:43:56.933 [REPO] Found multiple matches for installed package [{710f4c1c-cc18-4c49-8cbf-51240c89a1a2}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{710f4c1c-cc18-4c49-8cbf-51240c89a1a2}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2005redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.934 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x86
2022-03-13 20:43:56.935 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x64
2022-03-13 20:43:56.983 [REPO] Found multiple matches for installed package [{9BE518E6-ECC6-35A9-88E4-87755C07200F}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{9be518e6-ecc6-35a9-88e4-87755c07200f}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2008redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:56.985 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x86
2022-03-13 20:43:56.986 [REPO]   Checking match with package id: Microsoft.VC++2008Redist-x64
2022-03-13 20:43:57.073 [REPO] Found multiple matches for installed package [{F0C3E5D1-1ADE-321E-8167-68EF0DE699A5}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{f0c3e5d1-1ade-321e-8167-68ef0de699a5}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2010redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:57.075 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x86
2022-03-13 20:43:57.076 [REPO]   Checking match with package id: Microsoft.VC++2010Redist-x64
2022-03-13 20:43:57.090 [REPO] Found multiple matches for installed package [{ad8a2fa1-06e7-4b0d-927d-6e54b3d31028}] in source [Microsoft.Winget.Source_8wekyb3d8bbwe] when searching for [Query:[none] Include:ProductCode='{ad8a2fa1-06e7-4b0d-927d-6e54b3d31028}'[Exact] Include:NormalizedNameAndPublisher='microsoftvisualc2005redistributable'+'microsoft'[Exact]]
2022-03-13 20:43:57.092 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x64
2022-03-13 20:43:57.093 [REPO]   Checking match with package id: Microsoft.VC++2005Redist-x86
2022-03-13 20:43:57.294 [CLI ] Leaf command succeeded: root:upgrade

Steps to reproduce
See above.
Expected behavior
One more package with unknown version number should be shown in the output.
Actual behavior
The package with unknown version number is not shown in the output
Environment
Windows Package Manager (Preview) v1.3.0-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1586

Logs: %TEMP%\WinGet

This was resolved by https://github.com/microsoft/winget-cli/pull/1972 I believe, once a new preview release is cut you should be able to test this change.

Can still be reproduced with v1.3.692-preview
Windows Package Manager (Preview) v1.3.692-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22610.1
Package: Microsoft.DesktopAppInstaller v1.18.692.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

@denelon - I believe this was resolved when 1.3.1872 was released


How do I restart Ghost when it's started with current/index.js ?

There's no process supervisor in the container so Ghost isn't able to restart without the container exiting
You'd want to make sure the container is persistent https://github.com/docker-library/docs/tree/master/ghost#stateful and then restart the container

There's no process supervisor in the container so Ghost isn't able to restart without the container exiting
You'd want to make sure the container is persistent https://github.com/docker-library/docs/tree/master/ghost#stateful and then restart the container


add support for incremental updates

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@272155e). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   74.34%
=========================================
  Files             ?       51
  Lines             ?     2198
  Branches          ?        0
=========================================
  Hits              ?     1634
  Misses            ?      564
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hot reloading for the Express server

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Desired functionality.
Hot reloading of server modules. I know the server is responsible for client and isomorphic building/HMR, so this might not be possible, but having to restart the entire stack to reflect a change in the Express code is painful.

hey @Riari,
a really good request, I didn't think of this use case because I usually use external REST APIs. But this feature is essential if your backend lives in the express app.
can you try this solution: https://github.com/devCrossNet/vue-starter/commit/0472d36445b8c8180353aba2b19d990b97128c70
and give me feedback?
I'll merge it into master as soon as you approve it.
Regards

Hey,
I should have pointed out that I tried nodemon already and found it was too slow, since it restarts the entire process and that in turn triggers webpack building the client and isomorphic sources. I think there might be a way of doing it if the Express server and application are split into separate files and HMR then applied to the app.
The first part of this article looks like a promising method: https://hackernoon.com/hot-reload-all-the-things-ec0fed8ab0

ok, will have a look at it 👍

hey @Riari,
can you give this a test ride? https://github.com/devCrossNet/vue-starter/commit/34f102d8ae48d1c31cee3194522911a2598b1c38
I think it's much better and it also reloads the i18n files in dev.

That looks like it's almost working perfectly! But the server doesn't come up - I think that's because enabling watch mode in webpack means it never gets as far as running node ./dist/server/server.js. The article mentions start-server-webpack-plugin, which seems like it might be necessary in this case.

I got it not working with typescript. can you try to increase the sleep in the dev script? that's a dirty hack, but just to get it running for testing.

OK, I tried increasing it to 8, but it simply never gets that far. I would expect to see some output from the server (starting with info: server started at http://localhost:3000), but there is none. Not sure how it's even working for you!

I will have a look at it later 👍

@Riari can you check out the feat/dev-express branch and help me to find a good solution?
I would really appreciate it :blush:
you can use the code that I already have written to create a PR or just give me some hints on this issue.
thx in advance


When NewType is called and the first argument is not a string, make a diagnostic message

https://github.com/microsoft/python-language-server/pull/1260


[new Design] Date on the Blog post page is not zero padded

Hey @kgodey  @TimidRobot
Description
When we check the blog page date shown is not zero padded for single digit dates.I have corrected this issue in the old version website .

Expectation
Format should be {yyyy-mm-dd}

Screenshots

Resolution

[x] I would be interested in resolving this bug.

As #440 mentions that it affects both old and new designs, it has been reopened and this issue, being a duplicate, of the same issue is being closed. @Aakash2408 you remain assigned to it so please take it up!

But i made changes in blog post which is the code for old site  and that
made the changes too but where can i make changes for this new website
On Fri, 21 Aug 2020 at 1:54 PM, Dhruv Bhanushali<EMAIL_ADDRESS>wrote:

As #440
https://github.com/creativecommons/creativecommons.github.io-source/issues/440
mentions that it affects both old and new designs, it has been reopened and
this issue, being a duplicate, of the same issue is being closed.
@Aakash2408 https://github.com/Aakash2408 you remain assigned to it so
please take it up!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/creativecommons.github.io-source/issues/468#issuecomment-678113326,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALHTPEL554G45PGU4PP7CQDSBYVMRANCNFSM4QG2SLUQ
.


GenerateWireBody rendering broken

Hello again!
Just to give you a head's up, as of Firefox v50.1.0 and Chrome v55.0.2883.87, GenerateWireBody is having rendering problems. I would assume something in their latest implementation of WebGL changed, so as to impact the Line shader script.
When I run your fiddle, I get this output
All the best, and thanks in advance for any help!

sandbox/linesandpoints.html illustrates this better.

Hello,
It is strange, it works for me, What operating system do you use?
I crated the same example with the internal, and the three.js based viewer. Does it work for you?
http://jsfiddle.net/yunq4tys/1/
Viktor

Nope. I get the same thing like in sandbox/linesandpoints.html:
http://www.awesomescreenshot.com/image/2136715/26d713d9ddd01a6e3e2a9995c327aa0a
I'm running Ubuntu 16.04 on both my desktop and laptop, as well as a friend's desktop, all showing the same glitch.
Thank you so much for the help!

It seems that the problem appears only with the internal viewer. As a workaround you can use the three.js based viewer. It has the same functionality but uses three.js to show models.

FWIW, Win10 running Chrome55.0.2883.87 and FF51.0.1 renders grids perfectly, so your initial hunch of it being an OS issue seems to be correct.

I've been able to fix this issue by initializing the diffuseComponent to vec3(0.0) in the point and line fragment shader script. Let me know if that works on other OS/browsers.

Good catch, thank you very much. It works on windows, too. I commited the change to development branch!


Include .gitignore file as part of the initial project setup

Hi! I was wondering if there's any reason not to generate a simple .gitignore file as part of the initial project setup. A simple one that I could think of can include:
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# next.js
/.next/
/out/

# production
/build

# misc
.DS_Store
*.pem

# debug
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# local env files
.env
.env.local
.env.development.local
.env.test.local
.env.production.local

# vscode settings
.vscode/

Hi @yehee ! Not everyone uses git for source control, so you need to opt in using a command line switch to indicate that you would like git-related artifacts generated. Just add --git as on of your command line arguments to the generator and you'll have a .gitignore added as part of the set up. I hope that helps!

Hi @yehee ! Not everyone uses git for source control, so you need to opt in using a command line switch to indicate that you would like git-related artifacts generated. Just add --git as on of your command line arguments to the generator and you'll have a .gitignore added as part of the set up. I hope that helps!


Make calculated summary return_to conditional

What is the context of this PR?

Made the return_to query string from the change link for Calculated summaries conditional on section summary/hub flow. We currently do not support jumping straight back to a calculated summary. Support for jumping straight back to a calculated summary will be implemented separately.
Also removed tests in test_calculated_summary_context.py that were duplicated from test_section_summary_context.py

Note: This is a temporary solution
How to review
Ensure the change links on a calculated summary depend on the whether you have a section summary and or if hub is enabled.

if section summary is enabled for the section you are on, then return to should be section-summary
if section summary is disabled and hub is disabled, then return to should be final-summary
otherwise, return to should be None. (This would go to the first block in the section since, hub without section summary would go to the first block anyway when you click (View answers))

Test the journeys do not result in 404s.
Test the following journey on master vs this branch.

Launch construction
Complete all sections
From the hub, click View answer to the Infrastructure section. You should now be on the section summary.
Click Previous to go to the Calculated summary.
Click Change on one of the answers.
Click Save and continue and you should see a 404 on master, but go to the section summary on this branch.

Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

it might have been better to bin the return_to

I did that initially and ran it by Donna, in that scenario you return to the hub straight from the question you are changing. Donna preferred going to the section summary.


Finder.arrayOf(...) always returns Object[] if an optional view is null

If you bind an array of views and one is null/optional, Finder.arrayOf(…) returns an instance of Object[], which results in a ClassCastException at runtime.
This worked fine before 7.0.0 when we used @InjectViews, I'm not sure what changed under the hood. It might be the case you shouldn't try to have nullable view in an array anyway, but just wanted to let you know in case this wasn't intentional.
Example
@Nullable
@Bind({R.id.textview0, R.id.textview1, R.id.textview2})
TextView[] textViews;

Results in this crash at runtime:
Caused by: java.lang.ClassCastException: java.lang.Object[] cannot be cast to android.widget.TextView[]
            at io.sweers.test.MainActivity$$ViewBinder.bind(MainActivity$$ViewBinder.java:11)
            at io.sweers.test.MainActivity$$ViewBinder.bind(MainActivity$$ViewBinder.java:8)
            at butterknife.ButterKnife.bind(ButterKnife.java:328)
            at butterknife.ButterKnife.bind(ButterKnife.java:246)
            at io.sweers.test.MainActivity.onCreate(MainActivity.java:23)

Full example here: https://github.com/hzsweers/Butterknife-test

Stepping through the debugger says the problem starts here. It seems the T[] cast doesn't take effect, because it still considers newViews an Object[] after.
Alternatively, it could do this to keep the correct casting, and also simplify the logic of filterNull() a little: https://gist.github.com/hzsweers/63a261d6fabe6e8a608e

This was my bad. I should have been using Array.newInstance if I wanted to allocate. I took a similar approach inspired by you, but I made it a bit more simple at the expense of a few extra bytecode instructions: #288.

Whoops. I screwed that up too...


JSON::ParserError: A JSON text must at least contain two octets!

Just started seeing this error anywhere a RUser call is made.  Trace:
Loading development environment (Rails <IP_ADDRESS>)
2.2.1 :001 > RUser.new
JSON::ParserError: A JSON text must at least contain two octets!
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/json-1.8.3/lib/json/common.rb:155:in `initialize'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/json-1.8.3/lib/json/common.rb:155:in `new'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/json-1.8.3/lib/json/common.rb:155:in `parse'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/ruser-3.0.0/lib/ruser.rb:37:in `new'
    from (irb):1
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:110:in `start'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:9:in `start'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:68:in `console'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
    from /Users/scott/.rvm/gems/ruby-2.2.1/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:17:in `<top (required)>'
    from bin/rails:4:in `require'
    from bin/rails:4:in `<main>'

Hi Scott, sorry about that it looks like RandomUser.me changed to using secure urls and I hadn't noticed it. The new version (3.0.1) of RUser should now (or very soon) be available via updating the gem


Feature/frank03

Likelihood model struct and compiling EM pipeline.
Next: test on real data

@ProfFan , while @marcrasi and @dabrahams might be doing a closer look, could you try and run this on real data to make sure the script works? I am not set up to do so.

Sure, I'll try :)

I merged, hope @ProfFan will take care of numpy issue in CI in a different PR, or disable the offending tests.