fix(clerk-react,types): Include isSatellite in DomainOrProxyUrl

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[x] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

This is an attempt to improve typesafety for the props that were introduced for the proxy and multi-domain features
Before someone was allowed to have the following config
<ClerkProvider domain={'satellite.dev'} />

This is perfectly valid, but a user should use this in combination with isSatellite prop in order to ensure the the mutl-domain feature in a satellite application will work.
After this PR the above code will result in a type error which is a hint for the developers that they've missed a prop.
Here's a list of configuration someone is allowed to use related to types

NONE of them (regular app)

<ClerkProvider />

proxyUrl (primary app)

<ClerkProvider proxyUrl={'/__clerk'} />

proxyUrl  + isSatellite (satellite app)

<ClerkProvider isSatellite={true} proxyUrl={'/__clerk'} />

domain  + isSatellite (satellite app)

<ClerkProvider isSatellite={(_)=> true} domain={'satellite.dev} />

Here's a list of configuration that is NOT allowed:

Only domain

<ClerkProvider domain={'satellite.dev'} />

Only isSatellite

<ClerkProvider isSatellite={true} />

proxyUrl + domain

<ClerkProvider domain={'satellite.dev'} proxyUrl={'/__clerk'} />

proxyUrl + domain  + isSatellite

<ClerkProvider isSatellite={true} domain={'satellite.dev'} proxyUrl={'/__clerk'} />

@raptisj  Yes we can throw an error or a log a warning when the load function is called
But I think this should be done in another PR


XS Moto America (motohax)

XS Moto is basically a re-skin of Superbike so it was quite simple to port.
Supports both single race and championship.
Thanks again to AcidSnake!

Tested and working perfectly, thank you!


Update eks-d release to latest

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.17

/hold


Host capacity calculation: use VM creation time if update time is null.

CapacityManagementImpl.updateCapacityForHost(..) use VM update time in capacity calculation.
VM update time is nullable in DB and can cause NullPointerException if record in vm_instance has defined last_host_id and undefined update_time.
Added logic to check whether update_time is null and use created time instead (which is not null).
Description

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[X] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Tested manually.

@blueorangutan package

@mprokopchuk a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✖ debian ✔ suse15. SL-JID 11063

@blueorangutan test

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✖ debian ✔ suse15. SL-JID 11066

@blueorangutan package

@JoaoJandre since this is a bugfix, causing NPE exception can we consider it?

@blueorangutan test

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11454)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 86936 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9662-t11454-kvm-ol8.zip
Smoke tests completed. 134 look OK, 3 have errors, 4 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_secure_vm_migration
Error
134.14
test_vm_life_cycle.py

test_01_secure_vm_migration
Error
134.14
test_vm_life_cycle.py

test_01_VPC_nics_after_destroy
Error
787.03
test_vpc_router_nics.py

test_02_VPC_default_routes
Error
39.51
test_vpc_router_nics.py

ContextSuite context=TestVPCNics>:teardown
Error
81.67
test_vpc_router_nics.py

test_01_redundant_vpc_site2site_vpn
Failure
982.35
test_vpc_vpn.py

test_01_redundant_vpc_site2site_vpn
Error
982.36
test_vpc_vpn.py

ContextSuite context=TestRVPCSite2SiteVpn>:teardown
Error
1027.31
test_vpc_vpn.py

test_01_vpc_site2site_vpn_multiple_options
Failure
865.00
test_vpc_vpn.py

test_01_vpc_site2site_vpn_multiple_options
Error
865.01
test_vpc_vpn.py

ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:teardown
Error
1163.87
test_vpc_vpn.py

ContextSuite context=TestVpcRemoteAccessVpn>:setup
Error
1258.69
test_vpc_vpn.py

test_01_vpc_site2site_vpn
Failure
1382.50
test_vpc_vpn.py

test_01_vpc_site2site_vpn
Error
1382.52
test_vpc_vpn.py

ContextSuite context=TestVpcSite2SiteVpn>:teardown
Error
1421.17
test_vpc_vpn.py

all_test_webhook_delivery
Skipped
---
test_webhook_delivery.py

all_test_webhook_lifecycle
Skipped
---
test_webhook_lifecycle.py

all_test_host_maintenance
Skipped
---
test_host_maintenance.py

all_test_hostha_kvm
Skipped
---
test_hostha_kvm.py


mysql log datetime not support

080313 05:21:55 mysqld started
080313 5:21:55 InnoDB: Started; log sequence number 0 43655
080313 5:21:55 [Note] /usr/local/mysql/bin/mysqld: ready for connections.

closed by #120 ??  Thank you!


Knowledge Agents: Maintenance 24.12

Description
This issue is not aiming for new or extended functionalities, but assuring all changes are implemented, that are required to ensure the compatibility/interoperability with depending components.
The required changes are depending on the features changes of the depending components, selected during the upcoming PI Planning. The full extent of required changes can only be defined, after all other features requests are approved and finalized in the PI Planning.
The preliminary maintenance changes might include:

Adaptation of changes of depending components (see Dependencies below)
Adaptation of new sub-components of depending components
Adaptation of changes to the ontologies
Adaptation of new release guidelines for 24.12
Solving upcoming security issues to fullfil acceptance criteria
Additional maintenance to pass new quality gates
Required enablers
Depending on the selected feature changes of the PI Planning.

Business value
As this is not a feature, it does not provide direct business value, but cares for not losing existing business value, by making sure existing business applications will work with the updated components as well.
Test scenarios
The existing test scenarios shall be passed as expected, as the functional scope of the component is not changed.
Acceptance criteria

Ensured compatibility with depending components based on integration/E2E tests
Security issues are solved
Quality Gate has to be passed
Feature estimation not yet possible due to the dependency on the PI Planning.

Developer team
@drcgjung, @obalandi
Dependencies
Eclipse Dataspace Connector (EDC)
Decentralized Digital Twin Registry (dDTR)
Managed Identity Wallet (MIW)
SLDT Ontologies models

@obalandi  not sure about this feature. Is it planned to present it in tomorrow's planning? It was never presented in a Refinement meeting. Did we miss something? I am not sure if we can present it, because of the number of dependencies? Are they already discussed?

@stephanbcbauer, we don't need to present it. It is just the maintenance of the Knowledge Agents. Adjustments are only made when there are changes in EDC and AAS. Since the last release, we also offer the AAS-Bridge solution. That's why these dependencies exist.


fix(services/supabase): Supabase ci fix

Fix supabase ci
Add read_with_range capabilities to all kv adapters and all services that support this.
Skip tests that require range read for those do not support

Others LGTM!

Hi, @Ji-Xinyou, I found GET /object/info/authenticated/<bucket>/* always returned resousne not found even the file do exist:
) curl  -H "authorization: Bearer <TOKEN>" https://<project>.supabase.co/storage/v1/object/info/authenticated/<bucket>/abc
{"statusCode":"404","error":"Not found","message":"The resource was not found"}

I created a discord thread at supabase too: https://discord.com/channels/839993398554656828/1006358244786196510/threads/1103495051658674246


"Vălcani" is listed in the drop-down menu

Description:
"Vălcani" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Vălcani" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Vălcani, TIMIȘ (Vălcani)" and "Comuna Vălcani, TIMIȘ".


Path to folder

Fix path to doc folder.
This should fix the autogen job failures
The version of ansible installed on spider-5 is 2.2.0, the relative path used in omeroweb-install implies that the folder is now created under ansible
An omeroweb-install will follow so we have the same outcome with ansible version 2.2 and 2.1

Merging now that the corresponding PR in omeroweb-install has been merged


Remove dependency on rlp

rlp is used by:
$ cargo tree -i rlp --depth 2
rlp v0.5.2
├── discv5 v0.3.1 (https://github.com/sigp/discv5?rev=d2e30e04ee62418b9e57278cee907c02b99d5bd1#d2e30e04)
│   └── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4)
├── enr v0.9.1
│   ├── discv5 v0.3.1 (https://github.com/sigp/discv5?rev=d2e30e04ee62418b9e57278cee907c02b99d5bd1#d2e30e04) (*)
│   ├── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4) (*)
│   └── reth-dns-discovery v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/dns)
├── ethers-core v2.0.10
│   ├── reth-eth-wire v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/eth-wire)
│   ├── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives)
│   └── reth-rpc v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/rpc/rpc)
├── impl-rlp v0.3.0
│   ├── ethbloom v0.13.0
│   ├── ethereum-types v0.14.1
│   └── primitive-types v0.12.1
├── reth-discv4 v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/net/discv4) (*)
└── triehash v0.8.4
    └── reth-primitives v0.1.0-alpha.9 (/home/doni/github/danipopes/reth/crates/primitives) (*)

Triehash: #4797
Internally, only used by reth-discv4 in EnrWrapper.

this is tough, because we need this to decode Enr which can only be decoded via rlp -.- the only workaround would be to use the EnrBuilder type, but this would be pointless since the enr crate already pulls in the rlp crate, so we can reuse it for free


uncomment edrixs

This is to test whether edrixs installs.

@mrakitin I can't actually see how to approve the workflow.


Could 'size' be zero? I met a panic like this in go 1.17.7

https://github.com/golang/go/blob/4ea866a9969f4ff2ffd975116a17bbe01ce00469/src/runtime/mgcsweep.go#L436

fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x80 addr=0x0 pc=0x42a40b]
goroutine 18 [running]:
runtime.throw({0x5eeafe6, 0xc00016c658})
/data10/home/liuyidong.eddy/go/src/runtime/panic.go:1198 +0x71 fp=0xc00016c618 sp=0xc00016c5e8 pc=0x43cbb1
runtime.sigpanic()
/data10/home/liuyidong.eddy/go/src/runtime/signal_unix.go:719 +0x396 fp=0xc00016c668 sp=0xc00016c618 pc=0x4530b6
runtime.(*sweepLocked).sweep(0xab623e0, 0x0)
/data10/home/liuyidong.eddy/go/src/runtime/mgcsweep.go:436 +0x12b fp=0xc00016c740 sp=0xc00016c668 pc=0x42a40b
runtime.sweepone()
/data10/home/liuyidong.eddy/go/src/runtime/mgcsweep.go:290 +0x109 fp=0xc00016c7b0 sp=0xc00016c740 pc=0x429d09
runtime.bgsweep()
/data10/home/liuyidong.eddy/go/src/runtime/mgcsweep.go:166 +0x105 fp=0xc00016c7e0 sp=0xc00016c7b0 pc=0x429bc5
runtime.goexit()
/data10/home/liuyidong.eddy/go/src/runtime/asm_amd64.s:1581 +0x1 fp=0xc00016c7e8 sp=0xc00016c7e0 pc=0x470601
created by runtime.gcenable
/data10/home/liuyidong.eddy/go/src/runtime/mgc.go:181 +0x55

You're getting a segv, not a divide by zero error, so this failure isn't caused by the size being zero.
Probably one of those pointers is null. We'll need more info to help you here. Please fill out the issue template, and ideally provide us with a program that we could run ourselves that demonstrates the problem.


init pythonPackages.firetv for home-assistant

Motivation for this change
add firetv support to home-assistant
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.firetv python3.pkgs.firetv

"python" -> "pythonPackages" in your commit messages.

@dotlambda thanks for the review!

all issues should be resolved now

@GrahamcOfBorg build python2.pkgs.firetv python3.pkgs.firetv

Thanks!


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/331 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 4f436dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fails for Xcode 7+ if used with a Development Prov Profile

Error:
set +v

(i) export_options_path: /Users/vagrant/deploy/export_options.plist
(i) archive_path: /Users/vagrant/deploy/THRPY.xcarchive

==> Collect infos from mobileprovision

==> Create export options

{:method=>"development"}
2015-10-28 09:09:19.433 xcodebuild[1820:8446] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/4f/945ywsh506g31f58fpcbg0840000gn/T/THRPY_2015-10-28_09-09-19.432.xcdistributionlogs'.
2015-10-28 09:09:19.813 xcodebuild[1820:8446] [MT] IDEDistribution: Step failed: <IDEDistributionSigningAssetsStep: 0x7fda54290b60>: Error Domain=IDEDistributionErrorDomain Code=1 "The operation couldnâ€™t be completed. (IDEDistributionErrorDomain error 1.)"
error: exportArchive: The operation couldnâ€™t be completed. (IDEDistributionErrorDomain error 1.)

Error Domain=IDEDistributionErrorDomain Code=1 "The operation couldnâ€™t be completed. (IDEDistributionErrorDomain error 1.)"

** EXPORT FAILED **

We believe that the root cause of the issue is RVM, as the step works perfectly on OS X where RVM is not installed.
This StackOverflow link seems to confirm our hunch: http://stackoverflow.com/questions/33041109/xcodebuild-no-applicable-devices-found-when-exporting-archive

+1 Seeing the same issue.

Fixed in v1.3.2 https://github.com/bitrise-io/steps-xcode-archive/releases/tag/1.3.2


change all places where #include <string.h> is

Well since C++ 11 you do not have to provide the .h part of string and on Windows <string.h> on some versions of the WinSDK is not there for that it is named <string>. So, I recommend doing the same on if it is windows as the .h part is optional and is in some cases not present. (I know I am using C++ v14.0 and see no string.h but a string file that is the same contents of string.h.

Closing, outside node-gyp's remit.  It's a build tool, not a style checker.
Aside, <string.h> and <string> are not the same thing.  You may be thinking of <cstring>.


Can we open app route when notification is tapped

Hi,
It's question more than it is a issue.
Currently, without problems I manage to send & receive push notification on Android.
This is how message looks for firebase push notification which is sent from our backend (node.js):
const messageObject = {
      token: getValidFcmToken.token,
      notification: {
        title,
        body,
      },
      android: {
        notification: {
          // clickAction: 'something', // having this prevents me from opening the app when notification is clicked
          (when app is in background). Also (window as any).FirebasePlugin.onMessageReceived is not triggered
        },
      },
      apns: {},
      data: {
        notification_foreground: 'true',
      },
};

On frontend (React) I use (window as any).FirebasePlugin.onMessageReceived to inspect what is happening.
config.xml file:
<platform name="android">
       <!-- this edit-config block is used only in debug & development, and generally is removed -->
        <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
            <application android:usesCleartextTraffic="true" />
        </edit-config>

        <preference name="APP_SECRET" value="<%= appSecret[brandLowercase].android %>" />
        <% if (codePush && codePush.android) { %>
        <preference name="CodePushDeploymentKey" value="<%= codePush.android %>" />
        <% } %>
        <preference name="Orientation" value="portrait" />
        <preference name="AndroidLaunchMode" value="singleInstance" />
        <allow-intent href="market:*" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-36x36.png" density="ldpi" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-48x48.png" density="mdpi" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-72x72.png" density="hdpi" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-96x96.png" density="xhdpi" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-144x144.png" density="xxhdpi" />
        <icon src="www/assets/<%= tenantId %>/favicon/android-icon-192x192.png" density="xxxhdpi" />
</platform>

In the generated AndroidManifest.xml  file I have something like:
<activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|smallestScreenSize|screenLayout|uiMode"
android:label="@string/activity_name" android:launchMode="singleInstance" android:name="MainActivity"
android:screenOrientation="portrait" android:theme="@android:style/Theme.DeviceDefault.NoActionBar"
android:windowSoftInputMode="adjustResize">
      <intent-filter android:label="@string/launcher_name">
        <action android:name="android.intent.action.MAIN"/>
        <category android:name="android.intent.category.LAUNCHER"/>
      </intent-filter>
      <intent-filter android:autoVerify="true">
        <action android:name="android.intent.action.VIEW"/>
        <category android:name="android.intent.category.DEFAULT"/>
        <category android:name="android.intent.category.BROWSABLE"/>
        <data android:host="was-eur-ww-dev-app20.azurewebsites.net" android:scheme="https"/>
      </intent-filter>
</activity>
    ...
<service android:name="org.apache.cordova.firebase.FirebasePluginMessagingService">
  <intent-filter>
    <action android:name="com.google.firebase.MESSAGING_EVENT"/>
  </intent-filter>
</service>

Question: with this plugin cordova-plugin-firebasex, can we define route to which we want our app to open in moment when the notification is tapped by user? If yes, how?

If you want your app to carry out some specific behaviour on receiving a push notification message, I'd suggest defining a key in the data payload of the message which is passed to the app in onMessageReceived when the user taps the system notification, for example:
{
      token: getValidFcmToken.token,
      notification: {
        title,
        body
      },
      data: {
        notification_foreground: 'true',
        my_action: "do_something"
      }
}

Then when the user taps the system notification, the payload is delivered to onMessageReceived where you can act on it:
FirebasePlugin.onMessageReceived(function(message) {
    if(message.my_action === "do_something"){
        doSomethingWithMyAction();
    }
}, function(error) {
    console.error(error);
});

Thanks for reply.
Well, have to check on that. I was more curios about statements provided by firebase docs, related to android->notification->clickAction, and apns->payload->aps->category:

https://firebase.google.com/docs/cloud-messaging/concept-options#example-notification-message-with-platform-specific-delivery-options
https://firebase.google.com/docs/cloud-messaging/send-message#example-notification-click-action
https://firebase.google.com/docs/dynamic-links/rest

The Firebase SDK documentation is written as if you are integrating a native Android or iOS app with the Firebase SDK and therefore are writing your app business logic in the native code layer.
For example, in a native Android app, you can launch a different activity or intent based upon the click_action in the notification message.
And in a native iOS app, you can show a different view controller based upon a selected category.
However since your app is a Cordova hybrid app, all your business logic resides in the Javascript layer so this plugin is providing the native bridge between your app logic and the Firebase SDK. Therefore the native plugin implementation has to be more generic than that which you would implement in a native app.
As it happens, thanks to PR #482, iOS categories are now supported and do deliver the click_action outcome to the onMessageReceived callback.
However for Android, there is currently no support for the click_action since the Firebase SDK intends this to be used with a native (multi-activity/intent) Android app whereas Cordova apps are inherently single activity/single intent.


feat: added algorithm concepts for eQuilibrator

Hi Jonathan, thanks a lot, the new entries look very good.
There's only one thing I'd like to change: in the new entry "KISAO_0000685", the name and definition are a bit misleading and should be changed. I think "network configuration" sounds like the network structure itself is reconfigured, while what we want to say (I think) is that the variables in the network (in our case, metabolite and possibly enzyme concentrations) are chosen by the algorithm.
Any ideas how this could be expressed/named more precisely?
(Also to be discussed with Elad) - see our discussion in the google doc.
Best,
Wolf

I'm trying to communicate exactly what you interpreted -- methods for choosing an optimal parameter configuration of a model (according to some metric). I don't what to some "optimization method" because this has been reserved for the underlying optimization methods (i.e. interior point method). I don't want to say something like "parameter optimization method" because this would sound like model calibration such as PEtab.
Some other possibilities

Optimization-based method (similar to "constraint-based modeling")
Heuristic-based method

Mmh .. it looks like this is a complex question (especially, since we need not only decide about a proper name + description), but also to what level of abstraction we want to go .. maybe it's best to meet (also with Elad) and discuss this over video?

I don't think there's an obvious answer. At the same time, the organization isn't particularly important. I don't think we need to overthink this.

Ok. Thank you!

Thank you Jonathan!!
Just a small typo in definition of  "biological state optimization method": accordion -> according


There is an idea to optimize the code for json.lua

When used .. in loops, the lua will create a lot of garbage and thus affect performance. I changed your script (json-fix.lua)
c:\test>busybox diff -U 0 json.lua json-fix.lua
--- json.lua
+++ json-fix.lua
@@ -41 +41 @@
-local json = { _version = "0.1.2" }
+local json = { _version = "0.1.2fix" }
@@ -235 +235 @@
-  local res = ""
+  local res = {}
@@ -246 +246 @@
-      res = res .. str:sub(k, j - 1)
+      table.insert(res, str:sub(k, j - 1))
@@ -253 +253 @@
-        res = res .. parse_unicode_escape(hex)
+        table.insert(res, parse_unicode_escape(hex))
@@ -259 +259 @@
-        res = res .. escape_char_map_inv[c]
+        table.insert(res, escape_char_map_inv[c])
@@ -264,2 +264,2 @@
-      res = res .. str:sub(k, j - 1)
-      return res, j + 1
+      table.insert(res, str:sub(k, j - 1))
+      return table.concat(res), j + 1

I created a .HAR file (size 313971312 bytes) using firefox and tested it with a simple Lua script.
local function read(file)
	local f, err = io.open(file, "r");
	if not f then
		return;
	else
		local data = f:read("a");
		f:close();
		return (data);
	end
end

local function test(obj)
	print (obj._version)
	local last = os.time();
	local har = obj.decode(read(file));
	print ('decode - ' .. os.time() - last .. " sec")
end

json    = require "json";
jsonfix = require "json-fix";
file    = 'Archive [21-05-25 11-43-43].har';

test(json)
test(jsonfix)

I got results like this on my computer (Intel(R) Core(TM) i3-9100 CPU @ 3.60GHz)
c:\test>lua read_har.lua
0.1.2
decode - 145 sec
0.1.2fix
decode - 23 sec

c:\test>lua read_har.lua
0.1.2
decode - 144 sec
0.1.2fix
decode - 24 sec

c:\test>lua read_har.lua
0.1.2
decode - 147 sec
0.1.2fix
decode - 22 sec

Make your own fork, the performance on this lib is terrible

(Translation)
Using "concat" is a good idea. I think it can be improved. "table.insert" can be modified to "[#tab +1] = value". The following is the test data
local tab = {}
for i=1, 10000000 do
-- table.insert(tab, i)
-- time : 8.61 7.33 7.21 s

-- tab[#tab +1] = i
-- time : 5.54 5.25 5.46 s

-- tab[table.size(tab) +1] = i
-- time : so long time
end

I completely agree with you.
Did the same test, same results.
Super.

String concatenation using .. should never be done in loops as it incurs quadratic time complexity; each .. has to copy the entire string in linear time.
Using find + gsub could be more efficient than a rope (a rope takes 8 bytes per character, ugh), but seems to be hard to implement as the Unicode surrogate pair handling as it is currently implemented doesn't mesh well with it.

If you want a fast implementation: https://github.com/Vurv78/qjson.lua
Runs thousands of times faster than this repo

If you want a fast implementation: https://github.com/Vurv78/qjson.lua
Runs thousands of times faster than this repo

Sorry, but that claim in that form simply isn't true (or at best highly misleading). On which inputs? Since this is a complexity issue, any linear-time implementation can be arbitrarily faster.

There are benchmarks. It is better.

Non-sequitur. I don't see how you are replying to any of my points.

I did. All of your points are invalidated by the benchmarks. Theory is theory but it comes down to the actual performance.

Oh yeah? So something being fast somehow magically makes it correct? Look, I have the fastest JSON decoder:
function read_json(str) return 1end

it's easy to optimize e.g. string decoding using gsub if you don't have to care about unicode escape sequences

Just to be sure, I ran the benchmarks of rxi/json.lua against qjson.lua. Here are the results:
[decode]
Lua version   : Lua 5.4
CPU name      : AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx
../json.lua   : 0.0773s [x2.21] (min: 0.0753s, max 0.095s)
../qjson.lua  : 0.035s [x1] (min: 0.0334s, max 0.0455s)
dkjson.lua    : 0.0785s [x2.24] (min: 0.0725s, max 0.1s)
jfjson.lua    : 0.104s [x2.98] (min: 0.0992s, max 0.134s)

[encode]
Lua version   : Lua 5.4
CPU name      : AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx
../json.lua   : 0.0287s [x1.63] (min: 0.0269s, max 0.0353s)
../qjson.lua  : 0.0176s [x1] (min: 0.016s, max 0.0232s)
dkjson.lua    : 0.0385s [x2.19] (min: 0.0357s, max 0.0485s)
jfjson.lua    : 0.0507s [x2.88] (min: 0.0498s, max 0.054s)
json4lua.lua  : 0.0476s [x2.7] (min: 0.0465s, max 0.0604s)

I don't know what you did wrong when benchmarking; qjson.lua is faster (about 2x), but definitely not a thousand or tens of thousands times for the given benchmarks.
Perhaps do some benchmarks before citing them?

Really...?
[decode]
Lua version   : LuaJIT 2.1.0-beta3
CPU name      : AMD Ryzen 5 5600G with Radeon Graphics
../json.lua   : 0.00712s [x1] (min: 0.00673s, max 0.0075s)
../qjson.lua  : 0.0138s [x1.94] (min: 0.0118s, max 0.0146s)
dkjson.lua    : 0.0179s [x2.52] (min: 0.0177s, max 0.0182s)
jfjson.lua    : 0.0123s [x1.73] (min: 0.0118s, max 0.013s)

[encode]
Lua version   : LuaJIT 2.1.0-beta3
CPU name      : AMD Ryzen 5 5600G with Radeon Graphics
../json.lua   : 0.00677s [x2.66] (min: 0.00641s, max 0.00701s)
../qjson.lua  : 0.00255s [x1] (min: 0.00227s, max 0.00274s)
dkjson.lua    : 0.00876s [x3.44] (min: 0.00849s, max 0.00912s)
jfjson.lua    : 0.0101s [x3.95] (min: 0.00993s, max 0.0102s)
json4lua.lua  : 0.0168s [x6.59] (min: 0.0164s, max 0.0173s)

Would probably help to have a shared benchmark script, so that people on both sides of the argument can verify that the tests are being conducted correctly (or at the very least consistently...)

Would probably help to have a shared benchmark script, so that people on both sides of the argument can verify that the tests are being conducted correctly (or at the very least consistently...)

The benchmark script is available in this repository. Just add qjson.lua to the table of JSON implementations to benchmark.

The benchmark script is available in this repository

It has some odd contents such as this:
  if name == "jfjson.lua" then
    local _encode, _decode = json.encode, json.decode
    json.encode = function(...) return _encode(json, ...) end
    json.decode = function(...) return _decode(json, ...) end
  end

Which will affect LuaJIT (have not tested by how much)

Which will affect LuaJIT (have not tested by how much)

How would that affect qjson.lua or json.lua? It's clearly in an if concerning only jfjson.lua (though it might explain why jfjson.lua is so slow in the LuaJIT benchmarks).

as it will not JIT compile variadic functions

[citation needed]

Addressing my incorrect claim that it is "thousands of times faster":
It is faster in every case besides decoding on LuaJIT since it relies on patterns, which stitch.
I've fixed my comments to reflect this, thank you for bringing it to my attention.

as it will not JIT compile variadic functions

[citation needed]

See the link I posted above

This was very wrong and a dumb mistake on my end. I've largely rewritten the code to be even further optimized and taken advantage of the rope optimization (pushed that a bit further too).

Good. What remains to be addressed:

Your fix for isarray is insufficient. It deals with proper sequences (no holes) properly. It also deals with "pure" dicts (only string keys) or tables without integer keys in general properly (those will have length 0). However it doesn't deal with pathological cases such as arrays with holes properly (or perhaps you want to generate arrays for these? beware though: these can be arbitrarily sparse, which is a major performance concern). Arrays with holes could be fixed by just checking that len == 0 at the end. That would still not be sufficient though; arrays might have holes and out of range keys making up for them (consider e.g. {1, nil, 3, [42] = true}). What you really need to check is that all keys are integers (type(k) == "number" and math.floor(k) == k) within range k >= 1 and k <= #t; then you can compute the density as counted keys divided by maximum integer key, and decide based on that whether you really want to serialize to array.
You still use %q for encoding; this will fail e.g. for "\1", which will encode to just that: "\1", which is invalid JSON. This is unfortunately not trivial to fix since Lua allows arbitrary bytestrings whereas JSON expects strings of Unicode code points (e.g. there are unicode escapes, no byte escapes like Lua's escapes). You will also run into issues of UTF-8 vs. UTF-16.
Maybe I skimmed over it, but I still see no handling of Unicode escape sequences.

as it will not JIT compile variadic functions

[citation needed]

@appgurueu https://web.archive.org/web/20220708225331/http://wiki.luajit.org/NYI
Took some time to find where the hell this was (the wiki has been deleted). Looks like only vararg results are unsupported based on that table, but I think in the context of a benchmark any potential for overhead should be removed though.

How would that affect qjson.lua or json.lua?

It doesn't, I'm just saying that generally the benchmarking script in this repo is not giving each project being benchmarked an equal footing (regardless of whether they're being directly compared here or not).

On an unrelated note, regarding the isarray discussion would the following approach not make more sense (from a performance perspective at least):
local function isArray(value)
    return getmetatable(value) == Array
end

...

local myArray = someJsonLib.Array({1, 2, 3, 4})
print(isArray(myArray))

If detecting whether a table is an array or not is a severe bottleneck, isn't the above approach the best way to tackle this? (seems especially useful for exceptionally large arrays)

On an unrelated note, regarding the isarray discussion would the following approach not make more sense (from a performance perspective at least):
local function isArray(value)
    return getmetatable(value) == Array
end

...

local myArray = someJsonLib.Array({1, 2, 3, 4})
print(isArray(myArray))

If detecting whether a table is an array or not is a severe bottleneck, isn't the above approach the best way to tackle this? (seems especially useful for exceptionally large arrays)

From a user's perspective, probably nobody would want to have to adjust all their input data, but from performance, would probably be much faster. Although I think getmetatable might be pretty slow on puc-lua
A faster way could be a lookup table which holds references to all of the array tables
local function encode(t, arrays)
    if arrays[t] then
    else
    end
end

local data = { 1, 2, {} }
encode(data, { [data] = true, [data[3]] = true })

But still, this would require action on the user's part.

From a user's perspective, probably nobody would want to have to adjust all their input data

I imagine that a user encoding the data is probably in control of how that data is generated (or can write a transformer easily). Ignoring that though, I'm not sure a user of a pure-lua JSON library really cares about splitting hairs over performance in the first place...

A faster way could be a lookup table which holds references to all of the array tables

Not sure how that's a more ergonomic API than wrapping the arrays at source, or with a transformer. That solution still requires knowing where every single array in the dataset is, and provides a duplicate source of truth for what is or isn't an array.

Your fix for isarray is insufficient. It deals with proper sequences (no holes) properly.

This is intended. I don't think tables with gaps should be treated as arrays, or at least, they should cut off.
Checking how other JSON libraries handle encoding { 1, 2, [4] = 55 }

Name
Runtime
Handling

Garry's Mod util.TableToJSON
C
{"1":1.0,"2":2.0,"4":55.0}

rapidjson
C
[1, 2]

lua-cjson
C
[1,2,null,55] (only handles small gaps, throws error for excessively sparse array)

actboy168/json
Lua
[1,2,null,55]

luadist/dkjson
Lua
[1,2,null,55]

grafi-tt/lunajson
Lua
[1,2]

rxi/json
Lua
Throws error

vurv78/qjson
Lua
{"1":1,"2":2,"4":55}

There's no real clear pick here. In the future maybe I'd like a configuration function to be exported which lets you tweak things like this to allow or disallow sparse arrays, but for now I prefer current behavior, or swapping to rapidjson/lunajson's method.

I think throwing an error is the best course of action. A table with holes simply can't be represented properly with accepting the possibility of sparse tables being exponentially wasteful.


servustv.com claims: no video formats found

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.09.20
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

www.servustv.com changed something


Add script for USD

Hi, I just came across this project, I think it's a great idea!
USD was recently open sourced and I've already spent about 5 hours on Windows trying to get it to build. Considering the number of dependencies, I think it would be a good candidate for mkvfx.
I might work on a script myself in a couple of weeks, but unfortunately I'm in the middle of writing exams right now. :)

usd-build-club is pretty stable now, as is the official Pixar build script.


add receive symbol to numbox~

maybe related to #1593 ?

Ticket title could be tweaked to say "add receive and send symbols to numbox~" so that it'd have the same info as #1593


[AAP-11904] Fixed sequential execution for multiple actions

This was broken for multiple actions
https://issues.redhat.com/browse/AAP-11904

@Alex-Izquierdo @ttuffin Please review


Select list still showing when i navegate to a new screen

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:
Open a select and navegate to other screen. The absolute position list still is opening
Expected behavior

Link to runnable example or repository (highly encouraged)

UI Kitten and Eva version

Package
Version

@eva-design/eva

@ui-kitten/components

Environment information
"@ui-kitten/components": "^4.3.2",
"react-navigation": "^4.0.10",
"react-navigation-drawer": "^2.3.3",
"react-navigation-stack": "^1.10.3"

@CharlyJazz I'm working on this currently. Can you please describe the use-case on how do you perform navigation? In default behavior, Select should be dismissed when any touch outside is performed.


Feat built in name literals

Summary

Closes #660
Use name variables
Add missing names
Group constants(suggested improvement)

I wanted to use the names in starknet.go but this causes an import cycle between this file and builtins, which can be the best approach here?

Hi @danielcdz . Sorry for the late reply!
I see what you mean with the cyclic dependency issue. The reason why builtin module uses the starnetParser module is just because of this "enum" for builtins that defined in starknet.go file. Our suggestion for this is to move that definition to pkg/vm/builtins/builtin_runner.go, so all the logic regarding builtins is in the same place. I think it would be more organized that way and should remove the issue with the dependencies. Only think you'll have to do some adjustments in the imports for the rest of the code.

@cicr99 working on your suggestions!

I'm not 100% sure if I replaced all the strings

@cicr99 all comments addresed, unit and integrations tests are passing, all possible references to builtin names changed to their variables instead of comparing the strings, I think this should be ready to go 👍


The screen turn upside down

I updated to 0.4.5 and found out a bug.
The screen(tableview) will always turn upside down then I pop a view controller.
This bug only appears on 0.4.5.

update to 0.4.6, solved!

This is same as #15
I'll close this


DocumentDB order-by no document return

Recently, i am doing some research on DocumentDB. One phenomenon confuse me when try to apply order-by to query data over one collection.

if not add order-by, then data return normally, however, once appended then no return.

Is there anyone know what happen?

Much appreciate!!~~

I did not make any change over the collection FamilyColl, every configuration are keep the default.

@Junfei1101 We currently don't support Order By queries for partitioned collections when using Query Explorer in Azure portal, so this is expected as of now.


Cannot deploy if an environment variable contains a comma

TL;DR
Commas in environment variables brings to error: google-github-actions/deploy-cloudrun failed with: failed to read file '.env': failed to parse KEY=VALUE pair "example": missing "="
Expected behavior
Escape commas
Observed behavior
Cannot deploy
Action YAML
- name: Deploy to Cloud Run
        id: deploy_cloud_run
        uses<EMAIL_ADDRESS>        with:
          service: ${{ env.SERVICE }}
          image: gcr.io/${{ env.PROJECT_ID }}/${{ env.SERVICE }}:${{  github.sha }}
          region: ${{ env.REGION }}
          port: ${{ env.APP_PORT }}
          env_vars_file: .env

Log output
`google-github-actions/deploy-cloudrun failed with: failed to read file '.env': failed to parse KEY=VALUE pair "example": missing "="`

Additional information
No response

This portion of the code seems to be responsible, it seems like if you explicitly escape commas yourself like foo\\,bar=value it would work maybe.
https://github.com/google-github-actions/actions-utils/blob/37e11488d71f7f34fbc77fd28ce5f498a26f79dc/src/kv.ts#L44-L51
Looking at the test cases it seems to be intended rather than a bug to parse by commas or newlines unless explictly escaped
https://github.com/google-github-actions/actions-utils/blob/37e11488d71f7f34fbc77fd28ce5f498a26f79dc/tests/kv.test.ts#L32

Hi @Kliton, @stefafafan is correct. Since environment variables can be specified as newline separated or comma-separated, you must escape the comma with a \.

HI, I escaped the comma but is still not working.
Now I have another error:
ERROR: (gcloud.run.deploy) argument --update-env-vars: Bad syntax for dict arg:
The env var is a string long 790 characters.

Same here – escaped the env var using \, but the variable is still recognized as a dict.
I found the following docs for setting env vars using gcloud commands directly. However, I can't seem to use this, because the env_vars property always delimits using commas. Any idea on how this works using this action? @sethvargo
Example
My current passed env_var: SCOPES=write_product\,write_files\,read_content\,write_customers\,write_draft_orders
which returns argument --update-env-vars: Bad syntax for dict arg: [write_files].

I'm having the same problem, is there a way to override the separator in the kvToString function?
export function kvToString(kv: Record<string, string>, separator = ','): string {
When using a list limiter like ^#^:
with:
     ...
     env_vars: |
        ^#^ENV1=VAL1
        ^#^ENV2=VAL2

the generated command is ^#^ENV1=VAL1,^#^ENV2=VAL2


feat(blockifier): panic or saturate GasAmount arithmetic depending on 'natural' source of values

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1281  👈
#1280
#1268
#1255
#1250
#1180
#1179
#1178
#1177
#1176
#1175
#1174
#1173
#1172
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dorimedini-starkware and the rest of your teammates on  Graphite

Merge activity

Oct 14, 3:01 AM EDT: A user started a stack merge that includes this pull request via Graphite.


TypeError: forward() missing 1 required positional argument: 'img_metas'

Sorry for this basic doubt. I am trying to worl with the SWIN transformer backbone and need to do a forward pass for the model in order to achieve quantization with the help of the Tensor-RT library .I am trying to do so using: model('img_path').
However, I get the following error : TypeError: forward() missing 1 required positional argument: 'img_metas'
I am not really sure what exactly does the method exactly expects as img_metas. If I am wrong in trying to do a forward pass with this, Is there a better or a different way to do this?

I am facing the same issue too.. did you manage to solve it?

@dnth  no, I still have not been able to solve it yet  :/

@hhaAndroid  I realize that the model requires images in a particular format. But now if I have a single image that I want the model to do a forward pass on, what exactly should I be passing as the img_metas ? Also, I have tried to debug by trying to print some statements. But seems like the warnings/print statements have been suppressed. Is there a way I can get them running? Would help me to debug.
@dnth  by any chance have you figured out how to do this?

@SourabhRanade I have not been able to solve it too.. which version of mmdet are you using?

@dnth  very sorry for the late reply. I am using the mmdet version : 2.21.0 . I have tried but haven't figured out a way yet. Unfortunately, haven't been able to print anything on collab (where I am trying to run). Do you have any suggestions?

@SourabhRanade this is a suggestion https://github.com/open-mmlab/mmdetection/pull/7173 that works for me. What model were you trying to train was it VFNet?

@SourabhRanade which model are you using? Any chance its a VFNet?

@dnth I am trying to use a MASK RCNN model with a SWIN transformer backbone.

I have same error when i use VFnet
did you solve it?

Now I know that I need to create a dictionary manually, but where should we use it?

I have same error when i use VFnet did you solve it?

I also have problems when I use vfnet (not when I use other networks), did you solve it?

Is the validation possible on vfnet? Looks like the problem is still here


Client sends double traffic to workers when set alluxio.user.file.writetype.default=CACHE_THROUGH

Alluxio Version:
Alluxio-2.9
Describe the bug
Client sended double traffic to workers when set alluxio.user.file.writetype.default to CACHE_THROUGH.  The data were written into the alloxio worker and ufs, as shown below.
client -> worker block
client -> worker -> ufs
Instead of sending data once to write to workers and UFS like below.
client -> worker/worker block -> ufs
To Reproduce

Set alluxio.user.file.writetype.default=CACHE_THROUGH
Use copyFromLocal command to Upload files.

Expected behavior
Determine whether to write UFS when writing data to the worker for the first time, rather than sending data to the worker again by the client and then writing UFS.

When the client writes data to the worker, it is first written to the worker's alluxio block by mCurrentBlockOutStream, and then the data sent to the worker by mUnderStorageOutputStream is written to ufs. On the worker side it is handled by BlockWriteHandler and UfsFileWriteHandler respectively.

The reason for sending two copies of the data to the worker is probably know, because alluxio client to the worker is to write block, each block corresponds to a stream, and write hdfs can only be used with the same stream, that is, can not be processed at the same time, and the blocks of a file may be distributed in different workers, so that can not write hdfs file through a same client, so there is now the implementation.


Incorrectly defined, but valid "lagoon" yaml fails to lint

Because Lagoons .lagoon.yml is pretty terrible. There are some cases where the defined yaml passes the Lagoon build phase, but the linter can't decode properly.
For example, the following will deploy a lagoon environment correctly, even though cronjobs: are defined as an environment.
The linter fails to unmarshal this and errors preventing a build
environments:
  cronjobs:
    - name: a cronjob defined as environment
      schedule: "* * * * *"
      command: echo "broken definition"
      service: cli
  main:
    routes:
    - nginx:
      - example.com
      - "www.example.com":
          tls-acme: 'true'
          insecure: Redirect
          hsts: max-age=31536000

Ideally, we could just print a warning message that a section is incorrectly defined.

We have had the hard build failure for this kind of error for a while now and haven't seen further problems with it. The error message for this example .lagoon.yml is currently:
    lint_test.go:84: couldn't unmarshal YAML: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go struct field Lagoon.environments of type required.Environment

While this is a bit abstruse, it does indicate "go look at your environment definitions".
Do you still think that we should be more forgiving of this kind of mistake and continue the build anyway by ignoring the misplaced cronjob?


New light effect - help

I'd like to add a new light effect to the ESP code. I'm going to put a LED light strip under a bed so that the floor around the bed glows. I'd like to add three new effects to control which side of the bed is lit up, e.g. the strip will be stuck to three sides of the bed - effect 1 would be my side of the bed and light up LEDs 1-30, effect 2 would be my wife's side of the bed LEDs 60-90, and effect would be all three sides of the bed LEDs 1-90. Is this possible?

I'm also interested in a bit more information on creating custom effects.
The effect I want to create is a wake-up-light. Thus starting at low brightness (at red/orange) and over time transitioning towards high brightness (at yellow/orange). Whenever possible, I would like to apply this effect to part of the led strip too, just like @nimdy2017 is planning his effects.
To combine both effects, we would need to know;

how to target specific LEDs in the strip (or a group of LEDs)
how to set a color for these LEDs
how to set brightness for these LEDs (and/or ON vs. OFF)

I would try to do something similar. My plan is to have 2 different led strips


[Bug]: Resource manager is not showing "Copy Url" option

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I just installed a new site with version 9.11.02 but "Copy Url" option is not available in this version. i have tried to update to 9.12 version but still is not available that option.
Steps to reproduce?
Go to Local Resources to show Resources Manager module.
Just pick some file (image or document), and in tool bar "copy url" option is not available
If you right click in some file option is not available in context menu either.
Current Behavior
Resource Manager don´t allow to "Copy Url" for any file
Expected Behavior
No response
Relevant log output
No response
Anything else?
No response
Affected Versions
9.12.0 (latest release)
What browsers are you seeing the problem on?
Chrome
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I just tried this on v9.12.00 and it works as expected. Below is the screenshot immediately after right-clicking on the file.
Are you logged in a Super or Admin or using some other combination of Roles + module permissions?
What browser? I used Chrome (latest).

@ufoloko it works on a clean and upgraded instance for me too.
Now the clipboard API only works with https, is it possible the site is not using https in you case...
I will close the issue assuming that is the case but happy to reopen if you find out it is still an issue with https....

Thanks Valadas, Effectivelly is needed https to show "Copy Url", i have enabled for the site and now is enabled.
Thanks for the response

Sorry, but having a feature that doesn't work when not HTTPS only because of a dependency... needs some thought. Its a can of worms, no?
Is that fact that the "Clipboard API only works with HTTPS" a bug or by design? If it is by design, then - if DNN should be allowed to run in non-HTTPS situations - this is a problem that needs a solution.
Am I missing stuff or out of context?

This limitation is by design. As you can see in the MDN docs for the Clipboard API, it requires a "Secure Context". I think the best approach would be to show an error or remove that button if we determine that it's not available.

The button is only shown when over https, so I'd say everything is by design as it stands...

@jeremy-farrance there has been serious discussions in the past that ALL DNN at all time should be HTTPS only, so I don't believe it is really a limitation.  You SHOULD NOT be running DNN on a non-HTTP location

Agreed, I don't and no one should. I definitely want to see DNN be HTTPS-only. I hope that is closer than I realize to being a reality! Cheers!!


Preparing development version 2.4.9-SNAPSHOT

Test build #137799 has started for PR 32293 at commit ddb7380.

I'm not sure why after RC2 cutting, the release script does not add "Preparing development version 2.4.9-SNAPSHOT" commit like RC1.
The release script will check if ASF Git is snapshot version. So now when I try to cut RC3, the script complains.
So I manually make the commit.
cc @HyukjinKwon @dongjoon-hyun

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42328/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42328/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42328/

Test build #137799 has finished for PR 32293 at commit ddb7380.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137799/

Thank you @HyukjinKwon @maropu @dongjoon-hyun! Merging to 2.4.


rebatch api produce an Check failed: limit <= dim0_size error

Current behavior
After rebatch(), data iterator get_next() produce an error:
F tensorflow/core/framework/tensor.cc:833] Check failed: limit <= dim0_size (8194 vs. 8193)

Expected behavior
no error
System information

OS Platform and Distribution: Ubuntu 18.04.5 LTS
TensorFlow version: 1.15.0
Python version: 3.6
CUDA/cuDNN version: 10.1
RAM: 94G
GPU model and memory: Tesla T4, 16G

Code to reproduce
import tensorflow as tf
import hybridbackend.tensorflow as hb

filenames_ds = tf.data.Dataset.from_tensor_slices(['file1.snappy.parquet', 'file2.snappy.parquet', ... 'fileN.snappy.parquet'])

hb_fields = []
hb_fields.append(hb.data.DataFrame.Field("feature1", tf.int64, ragged_rank=0))
hb_fields.append(hb.data.DataFrame.Field("feature2", tf.float32, ragged_rank=1))
hb_fields.append(hb.data.DataFrame.Field("feature3", tf.int64, ragged_rank=1))

ds = filenames_ds.apply(hb.data.read_parquet(8192, hb_fields, num_parallel_reads=tf.data.experimental.AUTOTUNE))
iterator = ds.apply(hb.data.rebatch(8192, fields=hb_fields))

it = iterator.make_one_shot_iterator()
item = it.get_next()

batch_size_dict = {}
with tf.Session() as sess:
    print("======  start ======")
    total_batch_size = 0
    while True:
        try:
            batch = sess.run(item)
            batch_size = len(batch['mod_series'])
            batch_size_dict[batch_size] = batch_size_dict.get(batch_size, 0) + 1
        except tf.errors.OutOfRangeError:
            break

running above code in a pyhon3 shell and an error is throwed:
F tensorflow/core/framework/tensor.cc:833] Check failed: limit <= dim0_size (8194 vs. 8193)

Willing to contribute
Yes

Thanks for reporting, can you provide a sample file for reproducing this issue?

Thanks for reporting, can you provide a sample file for reproducing this issue?

(1) generate a parquet file by running follwing code
(2) load generated parquet file by HybridBackend will reproduce this issue
import numpy as np
import pandas as pd
import random

data_list = []
for i in range(1, 10000):
    int_feature = random.randint(1, 100)
    # float_feature = random.random()
    array_feature = [random.randint(1, 10) for x in range(0, 4)]
    data_list.append([int_feature, array_feature])

df = pd.DataFrame(data_list, columns=["int_feature", "array_feature"])
df.to_parquet("parquet_sample_file.parquet")


Add base plot mixin to rating-gp

The base plot mixin got merged to main rather than rating-gp as intended. Let's merge the branches now and rectify any conflicts now for smooth merging to main.

Ends up only conflict was a change in docstrings... Updated to appropriate docstring


[Held on #294583-Internal][$500] Desktop - There is no turning back from the SSO provider portal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.85-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/28372
Action Performed:

Follow steps in [SAML NewDot] Add NewExpensifyCallback and SAML Beta Web-Expensify#38972 to get set up with SAML locally
Configure your account to have SAML enabled but not required in oldDot
Enter the email for your account in newDot
Confirm you see the option to choose to sign in with SAML or with a magic code
Choose the Go Back option and confirm you're dropped back on the sign-in page with your email pre-filled
Press Continue
Choose the Use Magic Code option and confirm you get a magic code sent to your email
Press Go Back and confirm you're back on the sign-in page with your email pre-filled
Press Continue
Choose Use Single Sign On option
Confirm you briefly see an interstitial page about launching your SSO provider's login portal

Expected Result:
There should be a Path back from the SSO provider portal (arrow or cross)
Actual Result:
There is no turning back from the SSO provider portal
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

https://github.com/Expensify/App/assets/78819774/d6d11dca-466e-40d7-badf-24dfde2f71f5
https://github.com/Expensify/App/assets/78819774/2715f95e-1340-4e86-88a8-467c87b5228c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b86a48a78c5400e9
Upwork Job ID:<PHONE_NUMBER>850781184
Last Price Increase: 2023-11-08

This will be handled as part of the SAML project - putting a hold on this issue for now

@NikkiWines - can you link the issue you are referring to? And if it makes sense can you degrade this issue to a weekly or monthly?

Sure, it's planned to be handled as part of polish for https://github.com/Expensify/Expensify/issues/294583 (internal link) - though actually I guess there's no reason it can't be handled externally now.
The desktop UI is on production, if someone wants to simulate having a SAML enabled or required account on newDot to trigger the new flow, they'll just need to modify either of these lines to be true instead of reading from account

This can be taken off hold, the desktop SAML flow exists in production now

@0xmiroslav it doesn't seem like we have any proposals. How severe is this issue from a UX perspective? Should we up the amount of the job? Or take it internal?

Let's just take it internal then? @0xmiroslav

Bumped on Slack here

Ok I added the External label again since the reproduction steps are now quite clear

Proposal
Please re-state the problem that we are trying to solve in this issue.
Desktop - There is no turning back from the SSO provider portal
What is the root cause of that problem?
The SAMLLoadingIndicator component has any button to go back.
What changes do you think we should make in order to solve the problem?
We should add a button that navigates back after clicking 'Use Single sign-on' button:
function SAMLLoadingIndicator() {
.
.
.
 const goBack = useCallback(() => {
        Navigation.goBack(ROUTES.HOME);
    }, []);
.
.
.
<View style={[styles.mt2, styles.mh2, styles.fontSizeNormal, styles.textAlignCenter]}>
    <Text style={[styles.textAlignCenter]}>{translate('samlSignIn.oneMoment')}</Text>
    <Button
        style={[styles.mv3]}
        text={'Cancel'}
        onPress={goBack}
    />
</View>
.
.
.

Result:
https://github.com/Expensify/App/assets/5216036/4e5b5bf2-a97b-4d17-ac88-a132cdf056c3

There should be a Path back from the SSO provider portal (arrow or cross)

Navigating back should always work. This bug also exists on Web where navigating back is the what most users would do.
Since we don't have a back arrow in Desktop or on on mobile apps, we might also need to have a ✖ for users to click and that ✖ would... just navigate back? I'm not sure that's a best design practice though, even if it works.
@dannymcclain what cha think?

@mallenexpensify is this proposal the current one in question? If so I think this looks good—but we probably don't need that Cancel button to be full-width.

Since we don't have a back arrow in Desktop or on on mobile apps, we might also need to have a ✖ for users to click and that ✖ would... just navigate back? I'm not sure that's a best design practice though, even if it works.

I'm not sure where you're referring to putting an ✖ button, but I think it would be fine for the ✖ to basically mean "cancel" and take the user back. cc @Expensify/design for any additional thoughts.

Hmm my take is that we need a back button to be visible on the screen that houses the SSO provider (in this case, OneLogin):

I think the bug is that there is no way to go back from this particular page?
If that's the case, the Cancel button from this proposal doesn't quite solve that. The only thing I can think of is that we'd need to wrap the OneLogin view (or whatever SSO partner) in some kind of view that has our own page header at the top, which might have a back arrow in the top left or something?

Ooooh ok yeah that makes sense. I think wrapping the SSO partner view in a view with our own page header sounds like a good idea. It could even be something super simple in the header like < Back.

Proposal
Updated

@0xmiroslav , 👀 on the above, inc. @samilabud 's updated proposal plz.

I think the bug is that there is no way to go back from this particular page?

Correct

even be something super simple in the header like < Back.

Makes sense and it'd work universally.  Do we need to do anything to ensure that If someone were to click their browser back button, that it would function the same as clicking < Back.?

Do we need to do anything to ensure that If someone were to click their browser back button, that it would function the same as clicking < Back.?

Great question, curious what our engineers/C+ think. I think hitting the back button kinda should already work in this context though?

I think hitting the back button kinda should already work in this context though?

It should but it isn't right now, so we want ensure it does with the proposal we accept.

Hmm I know that's not ideal, but I think we need to honor the theme settings of the app.

Hmm I know that's not ideal, but I think we need to honor the theme settings of the app.

I think I agree. Also, will this always be an Expensify screen? Won't it depend on the organization's SSO portal/provider? Or am I misunderstanding something?
If we have zero control over this view other than the header, I think we should just let the header fall in line with the current theme setting.

Won't it depend on the organization's SSO portal/provider

I imagine this will be the case but I don't have much experiencing using or testing SSO (also unsure how common it is for customers to use it.

Any updates here?

@alitoshmatov reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

I've gotten lost on the status of this, but I'm going to try to post a summary of where we're at (as I understand it). Anyone feel free to jump in and correct anything I've misunderstood.
What we want to do is:

Add a view that wraps the SSO portal with a header that includes a back caret < at the top of the view
Make the header of that view match the current app theme, regardless of what the SSO portal looks like
Double-check to make sure that the browser Back button also navigates the user back

@shawnborton @mallenexpensify Am I missing anything or getting anything wrong here?

@dannymcclain wonderful summary, that sound right to me!
We also might want to add a title to the page header bar just so it doesn't look quite so bare with only a back arrow. Something generic like "Log in" works fine I think.

Oh yeah good shout—that sounds good to me too.

@samilabud Can you update your proposal based on this points. I check back button of browser in computer and it is behaving weird by going back to loading page and once again going to SSO portal, then navigating back is not working at all

@samilabud Can you update your proposal based on this points. I check back button of browser in computer and it is behaving weird by going back to loading page and once again going to SSO portal, then navigating back is not working at all

I did the changes but I'm having a possible security issue for Desktop and Web:

This error is due to the fact that from the expensify.com domain iframes are not allowed, however this works for native (ios/android) using the webview component (which one is not compatible for web or desktop).
As far as I see the possible solution here is from expensify.com allow us to send a parameter such as "embedded=true" (or other similar), do you know if there is such a parameter or if we can request it?
This is how it looks when this error occur in desktop:

Not overdue Melvin. Looks like we're still working it out.

@samilabud Can we implement some kind of solution in loading page so that when user navigates back to loading page using browser back button, we would redirect it to signin page without showing loading again

I think this issue requires complex solution. Can we increase payment for this issue to attract more contributors?
cc: @anmurali @dannymcclain

@samilabud Can we implement some kind of solution in loading page so that when user navigates back to loading page using browser back button, we would redirect it to signin page without showing loading again

I tried using popstate but not work as expected, because when leaving the page it rewrites the state of the history and I can't handle precisely when the user returns to the page using the back button. I hope another proposal makes more sense than mine, sorry.

I think this issue requires complex solution. Can we increase payment for this issue to attract more contributors?

@alitoshmatov, fair.  It's been open for 3 months without an accepted proposal, raised to $1000

I don't think the proposed solution of loading the organizations SSO page inside an iframe is going to work.
SSO pages will typically refuse to load inside an iframe (by setting X-Frame-Options) because they are (quite rightly) concerned that allowing the login page to be embedded in something else opens up their users to clickjacking attacks. (For example, by loading a transparent element that accepts keyboard input on top of the real username/password form and stealing the keystrokes)

@davidgelhar that makes sense, and honestly seems pretty obvious now that you point it out haha.
Could we instead open the SSO portal in a new window? So if the user wants to "go back" they can just close the window? Sorry if this is a terrible idea, I'm just feeling a little stumped on how to solve this. 😅

@dannymcclain Yes I think that would work. After the SSO process finishes, the SAML provider is ultimately going to redirect back to an Expensify page with the SAML assertion identifying the user. That page could log the user in, then display something like the "abracadabra" page you get now from a magic link saying "you are all logged in - ok go back to your other window now"

That page could log the user in, then display something like the "abracadabra" page you get now from a magic link saying "you are all logged in - ok go back to your other window now"

Yeah I feel like that could work pretty well.

@davidgelhar Will you be able to provide a complete proposal based on your above suggestions?

@alitoshmatov Yes, I will put together a proposal today.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When logging in (to a domain that has SAML SSO enabled-but-not-required), if you select the "use single sign-on" button there is no way to get back to the login screen: there is no "go back" or "cancel" button.
What is the root cause of that problem?
The authentication URL (authentication/saml/login) displays an interstitial page then redirects to the SAML provider's login screen. This is all happening in the same window, so now the SAML provider's UI is the only thing present, leaving no opportunity for an Expensify "Go Back" button to be displayed.
What changes do you think we should make in order to solve the problem?

When the SAMLSignInPage component opens the login URL, it shoul do it in a new tab. This will give the user the ability to close that tab if they don't want to continue with SSO.

When the SSO login process completes (still in the new tab), display the "abracadabra" screen, with the message "Abracadabra, you are signed in! Head back to your original tab to continue."  This would happen in the logic that's processing the /transition route.

What alternative solutions did you explore? (Optional)
Wrapping the SAML login page in an iframe was discussed, but is not feasible due to x-frame-options security.

@davidgelhar

What kind of page are we going to show in expensify app when SSO process is going?
Can you give more details on how you want to communicate between tabs and know when to show abracadabra?

@alitoshmatov

There is already an interstitial page (picture of a rocket, saying "we are sending you to SSO"); we could show that.
LogInWithShortLivedAuthTokenPage is where the SSO process completes - it could decide to navigate to the 'abracadbra' page based on a (new) piece of state that indicates "SSO in progress".

Still, having looked at this a little further, I'm not certain that the "new tab" approach is the best solution - it seems to introduce a fair bit of complexity, and is not the usual user experience for an SSO flow.
The ultimate problem we're trying to solve is how to go "back" after clicking the SSO button. Is the browser "back" button a viable solution?
The "back" button almost works now, but you have to (quickly) press it twice so the interstitial "rocket" screen doesn't immediately redirect you back to the SSO portal.
Could we either:

tweak the browser history so that the interstitial screen doesn't appear?
dispense with that screen altogether and make the button simply open the SSO portal?

Still, having looked at this a little further, I'm not certain that the "new tab" approach is the best solution - it seems to introduce a fair bit of complexity, and is not the usual user experience for an SSO flow.
The ultimate problem we're trying to solve is how to go "back" after clicking the SSO button. Is the browser "back" button a viable solution?

I'm totally open to this approach (#not-an-engineer)—I think you're right to question how much complexity we're adding for this, since it does seem like an edge case. I think only having the browser back button is a bit less obvious/intuitive than having something "in app" that the user can see, but again, since this is kind of an edge case, that's probably fine.

Yeah... I guess another consideration here, we have not had a single customer report this bug to us, so it's also fine if we just decide to do nothing for now, especially given how much of an edge case this is. I know we've been spinning our wheels for quite some time on this one, but maybe the juice isn't worth the squeeze here and we should deprioritize for another day.

Yeah... I guess another consideration here, we have not had a single customer report this bug to us, so it's also fine if we just decide to do nothing for now, especially given how much of an edge case this is. I know we've been spinning our wheels for quite some time on this one, but maybe the juice isn't worth the squeeze here and we should deprioritize for another day.

That's a good point. We've got a lot going on right now, does this seem like a high enough priority thing to keep working on?

It happened to me, IRL, but maybe that's cuz I had the option to click the SSO button and the large majority of others won't, ie. don't admins need to turn that feature on?

Proposal
[Updated]https://github.com/Expensify/App/issues/29825#issuecomment-1925459656

This is what that could look like
https://github.com/Expensify/App/assets/3887322/03798807-f504-4d8b-bd6c-b0bcf66222d3

@mallenexpensify can you share some more details? Do you have SSO enabled and you were trying to login via SSO on desktop?
My thinking is this: this only affects users who use the NewDot desktop app and have SSO enabled. Furthermore, it only effects them if they hit the SSO button and try to go back. If they just go through the SSO flow, I don't think they get stuck.
Anyways, I highly doubt we have any real customers running into this, so I lean towards just wanting to close this out until we run into it as a real use case.
It seems like on desktop app, we're always going to have the limitation of not having a native back button or not being able to use an iframe. So I'm a little stumped at what we can do here, as it seems like we haven't found a great proposal to solve this anyways.

@shawnborton the "cannot go back" issue does affect web users too, in that the browser back button is ineffective (unless you press it twice Really Quickly) because when you try to go back it we load the interstiatial page which then immediately sends you on to the SSO portal.

Got it - that seems like a different issue than what is being reported though, would you agree?
But that being said, we should solve that on web at least if there is a viable solution.

@shawnborton I think it's really the same issue whether it's web or the desktop electron app.
The proposed solution also works with desktop - you can go back using "History->Back" (or cmd-[)

Yeah, the issue is not being able to go back if you first select SSO, which I did accidentally a while back.
https://github.com/Expensify/App/assets/22508304/c85ebe5a-55f0-4354-bae9-052d1d15b21e

Cool, so maybe we start by fixing the browser back button situation, and then see if this becomes an issue on Desktop down the road?

Not overdue.

Cool, so maybe we start by fixing the browser back button situation, and then see if this becomes an issue on Desktop down the road?

I like this approach.
Related.. I tested yesterday and got stuck on the SSO page and when I sent to staging.new.expensify.com today, I was redirected to the SSO page and there was no way to quickly/easily go back or take another action to get back to the login page.  The above approach @shawnborton proposes will help fix that immediate bug.
@anmurali , want me to take this over as BZ from ya? I'm pretty deep into this at this point

@mallenexpensify I've tested that the proposed solution also works in the Desktop app (using history->back to go back)
https://github.com/Expensify/App/assets/3887322/250ed781-3c3f-432b-b95a-c2ea6c32672d

Nice. I think this is a good solution for now, and if we discover that lots of customers are having issues with this, we can always make a more robust solution.

Any updates on this one?

Adding BZ backup for OOO for myself.

@anmurali Proposal here is still current - just need somebody to give the ok to move forward
[Updated]https://github.com/Expensify/App/issues/29825#issuecomment-1925459656

@alitoshmatov, as C+, please provide an update ASAP. Thx
@twisterdotcom , snagging this from you as backup BZ since I already have context.

@davidgelhar I think your proposal still is incomplete. Even going back from SAML page leads to loading page, isn't it?

@alitoshmatov with my proposal, as shown in the screen recording https://github.com/Expensify/App/issues/29825#issuecomment-1936627184, when you press the back button you land on the sign in page (after seeing the loading screen briefly)

Checking to see about adding to #wave6-collect-submitters
https://expensify.slack.com/archives/C02MW39LT9N/p1708379451419999

@davidgelhar can you reupload the video from here.  I'm unable to watch the full video or download it watch. Thanks.

@mallenexpensify here's an .mp4 version; maybe that will work better
https://github.com/Expensify/App/assets/3887322/b42115e4-326a-4772-a8b0-b82691fc65a5

Yup! Thanks @davidgelhar .   @alitoshmatov please review.

From an internal thread:

"LAUNCH UCRs TO ALL CUSTOMERS" release is the first one where a control user might actually get pushed to NewDot.

Added to #vip-vsb project.
@alitoshmatov , please prioritize this issue, thx

Okay, let's go with @davidgelhar 's proposal
C+ reviewed 🎀 👀 🎀

@thienlnam the upwork job is showing as "no longer available"

Looks like the old job expired, this new job should be accessible now https://www.upwork.com/jobs/~01534a657243d6c5b8

I expect to have a PR for this ready by Monday

@davidgelhar I've checked the job post for this issue on Upwork around 30 mins ago. Is this still open to new proposal?

Still working on PR for this. There have been some other changes to the SAML code in the meantime; need to resolve conflicts.

Thanks @davidgelhar , please keep updating daily since it's been almost a week.

I determined that an additional change was necessary in order to get the PR working with the latest from main. Specifically, the newly-added "lastVisitedPath" Onyx key was preventing you from navigating back to the login page.
That issue is also fixed in the (draft) PR https://github.com/Expensify/App/pull/37283
Question: the PR form wants to include screenshots for all platforms, but this fix is specific to the web/desktop platforms. There is a related bug https://github.com/Expensify/App/issues/36673 open for ios/android native.
How do you want to handle that  @mallenexpensify ? Is it ok to proceed with this as a fix for just the web/desktop bug, or do you want to try to solve it for all platforms? (I'd suggest keeping this task scoped to web/desktop and using the other bug to track the other platforms)

I see that bug #36673 is being kept open to track the related issue on native.
PR #37283 submitted for the web/desktop use cases

@thienlnam I've applied for the new upwork job you created https://www.upwork.com/jobs/~01534a657243d6c5b8 but it is not showing as "accepted" yet. Does something need to happen manually becausre you had to create a new job?

Does something need to happen manually becausre you had to create a new job?

Something has to happen manually because it's your first job and the bot only sends automated Upwork offer after the first job since you're not in the system before that.
Don't worry you'll get paid, the payment is usually handled 7 days (regression period) after the PR was deployed on production.

Hired ya in Upwork @davidgelhar , apologies for the delay/hassle.  Like @ikevin127 said, we have automation but it's not perfect.
PR is waiting on review from @thienlnam
https://github.com/Expensify/App/pull/37283

recheck

@alitoshmatov can you complete the BZ checklist?

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28372/files
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28372/files#r1532570441
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
Determine if we should create a regression test for this bug. I think yes

Regression Test Proposal

You should have SAML enabled email
Type the account's email into newDot.
Make sure there's an option to sign in with SAML or a magic code.
Select the Single Sign-On option.
You should see a temporary page about your SSO provider's login page starting.
The SSO provider's page should come up, but don't sign in.
Hit the "Back" button in your browser.
Check that you are in single sign-on page again to sign in with SAML or a magic code.

Do we agree 👍 or 👎

@anmurali Checklist completed

Contributor: @davidgelhar paid $1000 via Upwork
Contributor+: @alitoshmatov paid $1000 via Upwork.
TR GH - https://github.com/Expensify/Expensify/issues/380930
Thanks @alitoshmatov and @davidgelhar , happy to get this one fixed.


.npmrc with primary npm registry added

Duplicate of #3
Please delete this branch.

👍
Wasn't a duplicate when it was created -- Lock files were significantly different when this was made.


NullPointerException to ValueError

To be more consistent with Python handling rules, we will make NullPointerException catchable by Python ValueError.
Fixes #647

Codecov Report

Merging #650 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #650      +/-   ##
============================================
+ Coverage     85.07%   85.10%   +0.02%
  Complexity      170      170
============================================
  Files           118      118
  Lines          8718     8719       +1
  Branches       3682     3682
============================================
+ Hits           7417     7420       +3
+ Misses          769      768       -1
+ Partials        532      531       -1

Impacted Files
Coverage Δ
Complexity Δ

jpype/_jcustomizer.py
82.56% <100.00%> (+0.16%)
0.00 <0.00> (ø)

native/common/jp_exception.cpp
76.31% <0.00%> (+1.05%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63a6e5...f149b44. Read the comment docs.


[Server] Fix race cond in k8s comp registration

Notes for Reviewers
This PR fixes the meshery Server crash reported here #9003.
Additionally, it also fixes the K8s comp registration.
The ctxRegStatusMap map is a shared resource. The read/write needs to be atomic.
The map was accessed here https://github.com/meshery/meshery/pull/9015/files#diff-23d91387bec0232bd30f0206cf1ec7a8b114302fe631c782d2df879de85103a5R89
w/o acquiring a mutex, it can be the case that in a separate goroutine the lock is acquired and the line https://github.com/meshery/meshery/pull/9015/files#diff-23d91387bec0232bd30f0206cf1ec7a8b114302fe631c782d2df879de85103a5R96 is executed.
Since the previous read is not synchronised it will lead to a race condition (concurrent read/write).
Signed commits

[ ] Yes, I signed my commits.

@Shiva953 here's the PR that was posted and included in the v0.6.154 release. The issue is still occurring, though, so we're still on the hunt for a fix.


fix set proxy issue

Fixes
Showing last frame. Use --error-trace for full trace.

In src/mechanize/http/agent.cr:48:26

 48 | client.set_proxy(@proxy) if @proxy
                       ^-----
Error: expected argument #1 to 'HTTP::Client#set_proxy' to be HTTP::Proxy::Client, not (HTTP::Proxy::Client | Nil)

Overloads are:
 - HTTP::Client#set_proxy(proxy_client : HTTP::Proxy::Client)

https://github.com/mamantoha/vk_auth/actions/runs/8954517008/job/24594254489

@mamantoha thank you for your contribution, and I'm sorry for my late reply...


[v1.4] Collate code into a file

Coverage remained the same at 84.208% when pulling a9fd165fc9f617b0f1d2c023a5b8c2d1fef6af54 on JYL123:edit_task into ede306b497b36f2ffb7034448bfd8bd2e07ae1d7 on CS2103AUG2017-W11-B1:master.


use unique cache for fixture tests

ok this is the only other thing that uses lazy_static which has been known to cause deadlocks.

if anybody is out there reading this, please help


Index build grunt task not working Properly

Using this task import files are adding in index.html in wrong order.

+1
grunt watch fails due to:
Running "less:build" (less) task
>> FileError: '../../vendor/bootstrap/less/bootstrap.less' wasn't found in src/less/main.less on line 13, column 1:
>> 12
>> 13 @import '../../vendor/bootstrap/less/bootstrap.less';
>> 14
Warning: Error compiling src/less/main.less Use --force to continue.

Aborted due to warnings.

@adam-back did you run bower install ?

Yes, I did. I ran through the entire Quick Start. I also confirmed that the
the bower_components existed.
On Thu, Apr 2, 2015 at 4:24 PM, Emiliano Jankowski<EMAIL_ADDRESS>
wrote:

@adam-back https://github.com/adam-back did you run bower install ?
—
Reply to this email directly or view it on GitHub
https://github.com/ngbp/ngbp/issues/372#issuecomment-89076450.

--
Personal Webpage http://www.adam-back.com/
(w/links to GitHub, Linkedin, etc.)

Fixed:
I found when I cloned the repo down, some files were missing, including (but not limited to) .bowerrc and .gitignore. Therefore, my bower install was not going to the correct place.

@ashpareek, check to make sure you have a .bowerrc file in the root directory. It should contain:
{
  "directory": "vendor",
  "json": "bower.json"
}


Cannot update to 0.1.0

Hi,
I cannot update from 0.0.9 to 0.1.0 with the grafana command.

I don't like same here comments, but want to bump this up, so... we have the same problem.


Fix on mac os

This changes it to work on macOS, which doesn't (anymore?) ship with libreadline. Used the directory where homebrew puts it, because macOS simlinks libreadline to the not-quite-compatible libedit. Will make a companion pull request over at homebrew to make sure libreadline is a dependency for rakudo-star.

Oh dear. I'll need to make that more generic.
On Tue, Aug 25, 2020 at 9:44 AM ohmycloud<EMAIL_ADDRESS>wrote:

@ohmycloud commented on this pull request.
In lib/Readline.pm
https://github.com/drforr/perl6-readline/pull/36#discussion_r476505215:

@@ -718,6 +724,16 @@ class Readline:ver<0.1.5> {
tgetnum('');
}
}

 when 'macosx' {

$*DISTRO.name print out macos on my Mac.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/drforr/perl6-readline/pull/36#pullrequestreview-474554047,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAT6IT4JNGM7PWWJDY7OR3SCPE3TANCNFSM4P44HA3A
.


Benefits of joining the loyalty program

As a user, I would like to know more about the benefits of joining this loyalty program.

You can buy one select sweet, get one free. Satisfy your craving with every visit!
The Choco Caramel Iced Latte is Just $3, any size


出现file not found错误

Issue Type
Bug
Description

VSCode Version: 1.20
OS Version:  Mac 10.12.6 (16G1114)

Steps to Reproduce:

a.h in dir {workspaceroot}/lib_src, with content:

#include
#include
using namespace std;
class Iobserver
{
public:
virtual void update(const string &json) = 0;
Iobserver()
{
_observerid = _curr_last_id++;
}
Iobserver(int id)
{
_observerid = id;
}
int id()
{
	return _observerid;
}

protected:
int _observerid;
static int _curr_last_id;
};
class Ipublisher
{
public:
virtual bool register_observer(Iobserver &o) = 0;
virtual bool unregister_observer(Iobserver &o) = 0;
virtual bool publish_msg(const string &json) = 0;
};

b.cpp in dir {workspaceroot}/src:

#include "a.h"
class Cpublisher : public Ipublisher
{
public:
bool register_observer(Iobserver &o);
bool unregister_observer(Iobserver &o);
bool publish_msg(const string &json);
private:
map<int, Iobserver *> observers;
};
class Cobserver : public Iobserver
{
public:
void update(const string &json);
Cobserver() : Iobserver() { ; }
Cobserver(int id) : Iobserver(id) { ; }

};

set c_cpp_properties.json :
"configurations": [
{
"name": "Mac",
"includePath": [
"/usr/include",
"${workspaceRoot}",
"${workspaceRoot}/lib_src"
],
"defines": [],
"intelliSenseMode": "clang-x64",
"browse": {
"limitSymbolsToIncludedHeaders": true,
"databaseFilename": "",
"path": [
             "/usr/include",
             "${workspaceRoot}",
             "${workspaceRoot}/lib_src"
         ]
     },
     "macFrameworkPath": [
         "/System/Library/Frameworks",
         "/Library/Frameworks"
     ]
 },

edit b.cpp,
class Cobserver : public Iobserver1111111111 // <<< here won't found symble
{
public:
void update(const string &json);
Cobserver() : Iobserver() { ; }
Cobserver(int id) : Iobserver(id) { ; }
};

now vscode will report : "a.h" file not found, and after I fix up the b.cpp Iobserver1111111 to Iobserver, I also need to restart vscode then it will work fine...

VS Code Info
VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:02:34.244Z)
OS version: Darwin x64 16.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

Load (avg)
2, 2, 2

Memory (System)
16.00GB (3.03GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
33%

Extensions (5)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

vscode-database
baj
1.3.0

vscode-clang
mit
0.2.2

mssql
ms-
1.3.0

cpptools
ms-
0.14.6

Reproduces only with extensions

Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.
Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

Thanks again for your feedback!


test(e2e): add pool online checks

Add pool online checks
after installation
before each test run
resource check test for 3rd party tests
Rationalise the code checking for reuse

bors merge


Piston-cli Load Time Issue

Description
The piston-cli has a longer load time after installation and usage with exactly 5.3 secs load time...
this is a known issue and it would help to fix it.
Proposed Implementation
My proposed implementation is to remove unused/additional modules on the code manually
Would you like to implement this yourself?

[ ] I'd like to implement this feature myself
[ x] Anyone can implement this feature

Thankyou for the issue, I would be working on this in the v3-piston-api branch.

This has hopefully been resolved in v3-piston-api branch, and will soon be in production in release 1.4.0 as soon as piston v3 gets launched.
All commands are launched within 2 seconds now.


PLAT-11512 Adding support for updateIM and getIMInfo endpoint

Ticket PLAT-11512
Goal of this implementation is to add to support for two new endpoints:

Update IM (https://developers.symphony.com/restapi/v20.13/reference#update-im) that can be used to pin/unpin a message inside an IM.
Get IM Info (https://developers.symphony.com/restapi/v20.13/reference#im-info), used to retrieve the IM info including which message is pinned in the stream.

ok to test


Medusa Purge Job does not use imageRepository overrides

What happened?
Running a cassandra cluster in a closed environment with local image registry requires the setting of the
local registry, e.g. in K8ssandraCluster:
  medusa:
    containerImage:
      registry: registry.local.de

or k8ssandraOperator:
image:
  registry: registry.local.de
  registryOverride: registry.local.de

This works for the Backups/Restores, but not for the Purge Jobs.
Here it is hardcoded and cannot be overwritten:
https://github.com/k8ssandra/k8ssandra-operator/blob/1d8623c011d85c379ae0131f37abf078bd02fa95/pkg/medusa/reconcile.go#L597
							Containers: []corev1.Container{
								{
									Name:                     "k8ssandra-purge-backups",
									Image:                    "bitnami/kubectl:1.17.3",
									ImagePullPolicy:          corev1.PullIfNotPresent,
									TerminationMessagePath:   "/dev/termination-log",

Did you expect to see something different?
Registry and imagePullSecret should be set in Job Template

K8ssandra Operator version:

v1.12.0

I am also facing this issue, I cant override this default image.. Any solution to this?

Hi Team, Could you pls update us on, How to change default images?

@burmanm Could you pls update us on how to change default images?

In 1.18, you can use MedusaBackupSchedule to schedule your purge jobs which solves the issue as it doesn't use external images.


UTC_Offset - add a note "numeric value"

Hi,
I would like to ask to add a comment for Offset in section https://docs.microsoft.com/en-us/power-bi/admin/service-premium-install-gen2-app?tabs=1st#run-the-app-for-the-first-time point 4.
Our Customers are entering characters like "UTC" instead of an actual number.
Please add
"Note: Set the offset to a numerical value without time zone reference
Should you experience Capacity Metric App dataset refresh error: We count convert to Number, please verify dataset parameters setting to include only numerical value. "

Thank you. Martina

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bcddef48-ab1d-cdd2-900a-9b9f3500a06f
Version Independent ID: 42ce0182-3006-4271-7981-a9f8a984ca53
Content: Install the Premium Gen2 metrics app - Power BI
Content Source: powerbi-docs/admin/service-premium-install-gen2-app.md
Service: powerbi
Sub-service: powerbi-premium
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Thanks for your comment, @MartinaPoddana . We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

Hi @MartinaPoddana,
The only value you should enter in the UTC_Offset field is 0. I though that was clear, but as per your comment, it isn't. I'll amend the article to make that clearer.
Hopefully this field will soon be automatically populated.
Thanks,
Kesem

@KesemSharabi ,
Thank you.  Customers tend to do strange things sometimes.
I actually understood that Cx can use numerical value.
During first month of Gen2, there used to be comment somewhere that offset “does not work yet”. Since that comment disappeared, I assumed that they could use anything between -12 to +12.
Actually the whole of Release Notes section has disappeared from the app :) .

Hi @MartinaPoddana,
The app is constantly changing and evolving, as we want to bring the best customer experience we can to you. In the future we will try to remove all the unneeded fields.
Think about it like this - the main thing is to install the app properly. Once installed, you should be able to make all your inquiries in the app.
Hope this helps,
Kesem

Thank you Kesem.


pipenv lock -r command was not found.

I want to Copy package Dependency the requirements.txt
In the past, I used this command to record dependencies, but now not working.
I checked the release notes, but nothing related came up.
$ pipenv lock -r -d > requirements.txt
Usage: pipenv lock [OPTIONS]
Try 'pipenv lock -h' for help.

Error: No such option: -r

I use pipenv 2023.3.20.
$ pipenv --version
pipenv, version 2023.3.20

https://github.com/pypa/pipenv/issues/5253
I found solution. Thank you!

@KANGSangUn Middle of last year that options was replaced by the pipenv requirements command.