Feat: null value fields

What does this PR do?

Adds null checkbox to non-required text attributes
Fixes falsy default values not being passed to server

Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes

Related Issue: https://github.com/appwrite/console/pull/371

The behavior looks good for

bool

[x] null
[x] false

datetime

[x] null

email

[x] null

float

[x] null
[x] 0

integer

[x] null
[x] 0

string

[x] null
Interestingly, you can't have an empty string as a default


Add missing pytz dependency to st2client

Originally reported in #2689 (thanks!).
We never encountered this issue (and tests didn't catch it) since when using package installation method, st2client uses the same virtual environment as other components and appscheduler (used by st2reactor) depends on pytz so the dependency was also satisfied for st2client.
The issue would only manifest itself if user manually installed st2client outside st2 virtual environment.

Good catch!
Also, the same value needs to be in 3 places - something is wrong here isn't it?

It's a "feature" (and one of them is auto-generated).
Top-level requirements.txt is there for backward compatibility reasons, ideally it would only require one manual change in st2client/in-requirements.txt and other requirements.txt files would be auto-generated (that's true for top-level one, but not requirements.txt in st2client directory).


[SP-2682] Backport of PDI-14988 - Add option to disable interactive G…

…SSAPI authentication (5.4 Suite)

removed errorneus imports

@pamval please review and merge
sorry, I forgot to commit resolved merge conflict


PyTorch support cannot be built in Debug mode

When building with both -DCMAKE_BUILD_TYPE=Debug and -DFT_WITH_PYTORCH=ON, it will result in an missing symbol:
ImportError: /home/rd/src/FreeTensor_experiments/FreeTensor/build/freetensor_ffi.cpython-39-x86_64-linux-gnu.so: undefined symbol: _ZN3c106detail23torchInternalAssertFailEPKcS2_jS2_RKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE

Related: https://github.com/pytorch/pytorch/issues/73016

请问大佬除了现有的文档外，还有其他的的学习途径吗

请问大佬除了现有的文档外，还有其他的的学习途径吗

For material other than document here, we have a paper on PLDI22 here.
This question is out of topic, so please don't post it in this issue. You can email me at tsz19 AT mails DOT tsinghua DOT edu DOT cn.


HHH-4808 - SessionImpl.initializeCollection() does not release JDBC connection (if outside of a transaction)

https://hibernate.atlassian.net/browse/HHH-4808

Thnaks @beikov , rebased it

what's the status here?

Nice. Should we merge it?


Implemented C++ Hello, World!

Went ahead and added the C++ version of "Hello, World!", which is pretty similar to the C one.
Due to some VSCode configurations the actual C++ file is generating some errors, but as far as I know it should work properly. If someone wants to confirm or give their two senses on that feel free. The part that currently pops up as an error is:
#include <iostream>
Again, it might just be a VSCode issue. Let me know if there's any issues!

Since I resolved all of those conversations I'll leave another comment here too. I went ahead and changed C++ >> cpp as asked. I also added a new line character to the end of that "Hello, World!" so now the code is as such:
std::cout << "Hello, World!" << std::endl;
Let me know if anything else should be changed :D

I gotcha. Should be in there now!


one time (helm) secrets config exits in error

I am going through the user instructions: https://github.com/opendevstack/ods-pipeline/blob/master/docs/user-installation.adoc#instructions
And the following happened:
$ cat chart/secrets.yaml | helm secrets edit secrets.yaml
[PGP]    WARN[0000] Deprecation Warning: GPG key fetching from a keyserver within sops will be removed in a future version of sops. See https://github.com/mozilla/sops/issues/727 for more information.
Vim: Warning: Input is not from a terminal
Vim: Error reading input, exiting...
Vim: preserving files...
Vim: Finished.
 Then encrypt it via sops CLI (like: sops -p "<fingerprint 1>, ..., <fingerprint N>" --encrypt secrets.yaml). Once that was encrypted, then I was able to run the helm secrets edit and add/update the encrypted secrets file.

I use neovim as $EDITOR and with that it works. I simply assumed it would be the same for e.g. vim, nano :)
One other way to do it is like this:
cp chart/secrets.yaml secrets.yaml
helm secrets enc secrets.yaml
helm secrets edit secrets.yaml

This would be acceptable I think. Unfortunately it seems to swallow the first lines which are all commented?!

right, in any case, lines that are not following key: value are fully encrypted, but that can be accepted since then they get properly decrypted and one can see the comments?

Closed in #292.


doc: add nfs upgrade guide from 3.6 to 3.7

This commit adds nfs upgrade guide from 3.6
to 3.7.
Closes: #3271
Signed-off-by: Rakshith R<EMAIL_ADDRESS>

@Rakshith-R take a look at linter error.

https://github.com/ceph/ceph-csi/runs/7911792791?check_suite_focus=true
added output to satisfy linter


npm run production

After make some changes in many .vue i do npm run production
and i got this
69% building modules 683/684 modules 1 active ...w/html/resources/assets/sass/app.scss[..................] | : info lifecy
so my changes applied not all...
i try npr run dev then npm run prod, same situation
and Voten stuck in dev mode
"You are running Vue in development mode.
Make sure to turn on production mode when deploying for production."

There's probably a syntax error somewhere in your code. After the compile fails, terminal prints the line that's failing. See which line is it.
Also, to prevent this in the future, leave the npm run watch on so after each save, you'll be sure your code works; or see the error and fix it right away.

Thanks, problem solved.


genconfig: add multi-dc and cluster support

This patch add datacenter support.
There are two ways of configure datacenter:

from the command line using dc:ip,ip,ip
for example:
genconfig.py dc1:<IP_ADDRESS>,<IP_ADDRESS>

from file using nodetool status output
for example
genconfig.py -ns f.txt

where f.txt holds the nodetool status output
Fixes #513
Signed-off-by: Amnon Heiman<EMAIL_ADDRESS>

@roydahan @bentsi Following a discussion with Tzach we break the change into two commits.
This change only adds dc support without switching to python3 that will be done in a future patch.
Please have a look.
@eyalgutkind @glommer please note that we are about to update genconfig.py to support multi-dc cluster name and using nodetool output to generate the configuration.
This breaks genconfig.py command line option, so you should be prepared to it if you are using scripts the rely on it.

I haven't reviewed this, but people do use genconfig in their scripts. And it is not us, it is our users and customers.
I would strongly prefer this doesn't break. Either by having a different setup script for the multi-dc case or better yet, by keeping the existing options working in legacy mode. If you want me to I can look at the patch later and suggest a way to do so
Folks, it's super bad when we break users' scripts.

I can come up with an alternative that would keep the existing behavior, the issue is that people will not configure their dc which will cause issues with the cql-optimization dashboard

That's a common problem for the past 30 years with software. You keep doing what you're doing you don't get some of the new stuff. We're not the first or last to hit it.
Still the solution of breaking existing flows is rarely a good way to make and keep your friends.

I'll update the suggestion
On Mon, Apr 8, 2019 at 3:52 PM Glauber Costa<EMAIL_ADDRESS>wrote:

That's a common problem for the past 30 years with software. You keep
doing what you're doing you don't get some of the new stuff. We're not the
first or last to hit it.
Still the solution of breaking existing flows is rarely a good way to make
and keep your friends.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/scylladb/scylla-grafana-monitoring/pull/562#issuecomment-480818941,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBRv8CynDWFDh_VATs0qYk5dnMQbyJ6ks5vezumgaJpZM4cgxQ4
.

Following @glommer comment, the implementation was changed so the old command line would still work.
To use the new command line, use the -dc/--datacenters flag


Update Code Contributor Weights Guide.md

Updating for recent snapshots weight value as well as a brief description & link to the Code Staking update per recent MRCs and implementations

Please include a link to the mor.software tool for code weight staking

Updated to include a link to the mor.software tool.


Landing Page of Tirith

Landing page is a good way to show to the users what is Tirith apart from the README.md. This needs more discussion especially around the design

Do we have the design for the landing page like in figma or something else that can be used as reference for the landing page?

Hi @Nitin6404 , not yet as of now, but we're aiming for a simple landing page, one of the inspiration is aiac.dev


byte[] not correctly handled by openapi converter

I tried to generate an OpenApi-Definition from a java-class.
I run into problems with byte-arrays. Those are generated as openapi-arrays, but the openapi-tools create java-lists for openapi-arrays.
The OpenApi-Generator should instead generate a string with format binary according to the swagger-spec  (https://swagger.io/docs/specification/data-models/data-types/, section strings)
Please find the sample code in the attachted openapi-byte-array.zip
It contains also a maven-pom-template for configuring the maven-swagger-plugin.
I ran the plugin from command line with
mvn io.swagger.core.v3:swagger-maven-plugin:2.0.7:resolve

The expected openapi-output for a byte[] is:
        "binaryContent" : {
          "type" : "string",
          "format": "byte",
          "description" : "base64 encoded binary content."
        }

This would would work with the openapi-generator-plugin [https://github.com/OpenAPITools/]:
    <plugin>
        <groupId>org.openapitools</groupId>
        <artifactId>openapi-generator-maven-plugin</artifactId>
        <version>3.3.3</version>
        <executions>
          <execution>
            <id>8djh-jom-client</id>
            <goals>
              <goal>generate</goal>
            </goals>
            <configuration>
              <inputSpec>${project.basedir}/src/main/openapi/openapi.json</inputSpec>
              <generateDirectory>${project.build.directory}/generated-sources</generateDirectory>
              <generatorName>java</generatorName>
              <generateApiTests>false</generateApiTests>
              <generateModelTests>false</generateModelTests>

              <configOptions>
                <sourceFolder>test-rest-client</sourceFolder>
                <apiPackage>test.api</apiPackage>
                <modelPackage>test.model</modelPackage>
                <library>resttemplate</library>
                <dateLibrary>java8</dateLibrary>
              </configOptions>
            </configuration>
          </execution>
        </executions>
      </plugin>

do i miss something? Do i need to register a converter ?

There exists an annotation for doing such stuff, check my issue in the other project:
https://github.com/openapi-tools/swagger-maven-plugin/issues/22

Do we have the same solution for swagger-gradle-plugin?

I'm using swagger-gradle-plugin. For me the workaround is to annotate byte[] field with
import io.swagger.v3.oas.annotations.media.Schema;

public class MyDTO {
    @Schema(type = "string", format = "byte")
    private byte[] content;
}


Update manual configuration to use latest PnP PowerShell

The current manual configuration PowerShell requires the legacy PnP PowerShell which many people no longer have installed.
I would like to see a new version of this that uses the latest PnP PowerShell - 1.12.0.
This would be needed at some point and could either replace the existing Configuration file or provide an alternative version of it (possibly the better option for supporting both scenarios).
I am happy to work on this (seeing as I started doing it already on my machine) but wanted to make sure that it fits with the longer term goals.

@kevmcdonk reach out to @ToddKlindt he was working on updating the script to support both in one script a while back. The challenge here is that the updated version will require the app reg to run the PowerShell which many folks don't have the ability to do. This will end up causing troubleshooting issues on our end. If you are offering we will gladly accept the update as long as you can make one script to support both depending on what is installed. We should also update the documentation after the script is updated. Thanks.

So would a single script that supported both be preferable to two script that allows the user to pick?
(And thanks for the quick response!)

Yes, a single script would be better.

Added PR #709 for this one

Merged the PR and closing this. Thanks for the assistance


Script to find all runs given a term

3 main tasks:

Mapping run data to sample and mapping sample to ontology terms (ID) and then mapping to ontology term names. [Matt]

Jupiter notebook template

Fake data for creation of script.

Runs: 1-100
Terms: 1-5
Study: 1-3
example:
Run| Term | Study
1         2           4
2        2           4
3        1           4
.
.
.

Revise on 3. Fake data for creation of query script.
Runs: 1-100
Terms: 1-5
Study: 1-3
Each run is associated with a subset of terms. In other words...
runs to terms
a:{1,23}
b: {2}
c:{3}
Study to runs.
A:{a}
B: {b,c}

https://github.com/NCBI-Hackathons/RNA-Seq-in-the-Cloud/commit/d0f475e4ed2d9ecc034967d9fee85e7f32fb2e6d


[incubator-kie-issues#1504] Conditionally build all or only reproducible modules based on only.reproducible flag

Fixes: https://github.com/apache/incubator-kie-issues/issues/1504
In This PR:

Conditionally build all or only reproducible modules based on only.reproducible flag
Ignore the jit-executor generated image during reproducible checks (eg. ignoring image-build.zip )
Inherit maven-artifact-plugin version from Apache pom (currently 3.4.1) and removing it from the repo

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:
jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

@porcelli @pefernan Is this still needed (I guess so, can you please review/approve it?)


[BUG] "AttributeError: 'NoneType' object has no attribute 'get'" when trying to get Twitch chats

Basic information

Program version: 0.2.7
Python version: 3.11.4
Operating system: Windows 11 Home

Describe the bug
"AttributeError: 'NoneType' object has no attribute 'get'" occurs when trying to get Twitch chats.
I tried running the command below several times, and got the same AttributeError at different chats.
Command/Code used
If running from the command line, provide the following:

The command used (including the verbose tag, -v):

python -m chat_downloader "https://www.twitch.tv/videos/1860464348" -v --output "./1860464348.json"

Output from the above command:

2:41:40 | ドスケベ番長: アクセル踏みすぎたな！！
2:41:40 | (3-Month Subscriber, cheer 1) もーやおーらんど: 綺麗に落ちた
2:41:41 | (Prime Gaming) s_rio__ekus: なんだやろなぁ？？？
2:41:42 | (2-Month Subscriber, cheer 100) haanzooou: tomeruBURNING tomeruBURNING tomeruBURNING tomeruBURNING
[DEBUG] Total number of messages: 5211
[DEBUG] https://gql.twitch.tv:443 "POST /gql HTTP/1.1" 200 214
[DEBUG] Session closed.
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\xxxxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\chat_downloader\__main__.py", line 4, in <module>
    main()
  File "C:\Users\xxxxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\chat_downloader\cli.py", line 194, in main
    run(**args.__dict__)
  File "C:\Users\xxxxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\chat_downloader\chat_downloader.py", line 360, in run
    for message in chat:
  File "C:\Users\xxxxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\chat_downloader\sites\common.py", line 283, in __next__
    item = next(self.chat)
           ^^^^^^^^^^^^^^^
  File "C:\Users\xxxxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\chat_downloader\sites\twitch.py", line 1172, in _get_chat_messages_by_vod_id
    comments = info.get('comments')
               ^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get'

If the output is too long, you can attach a text file or remove output which does not constitute to the problem.

I just ran that command again and it worked without error. This may have been a temporary problem.


Project tidying

@tmeasday volunteered to help out 🙏

[ ] Make MailinglistSubscribeForm submission and errors self-contained
[ ] Setup eslint
[ ] Turn pure pages from Storybook into Gatsby pages
[ ] Setup Chromatic
[ ] Setup Netlify for SB deploy

@domyen eslint added. Do you want me to fix the problems?

Chromatic is working again

@domyen I fixed a lot of the linting but not all of it. Maybe you can have a stab at it? Run yarn lint to see the remaining 136 problems

I created the netlify site here: https://app.netlify.com/sites/happy-tesla-010e19/overview it seems to have even more problems

I think everything is sorted apart from the mailinglist form.


fix(protocol): add require statements instead of if-else

Add require statements instead of if-else
require statment provide more security then if-else conditions
Example:
  require(!_isInitialized, "Contract is already initialized");

We actually prefer the if-revert approach.


Include src folder in bower package

Hey, great library.
It would be nice if you would include the src folder in the bower package, that way I can load (and bundle) the modules I need directly in my application.

Sounds good to me.

thank you :+1:

Change doesnt seem to have appeared in the main bower repo yet, even though I cleared the cache I still only get dist.


development

feat/readme: update readme title
Update README file
Add webpack configuration
Write small structure to the index file
feat(readme): add how to run the app section
[Add] the CSS loaders with their config in webpack and import the initial css file in the principal js file
[Add] the babel loader in webpack  and config the initial babel file
[Add] the assets webpack config and [Add] the html loader also with their rules in the webpack config
[Add] a style to teh body just to have an example and verify the CSS loaders works
[Add] a image just to have an example of how we can use images in the project, this uses the html-loader but also it can be added with JS
[Add] the normalize css and the colors to use in the global css file
[Add] the fonts in the global css file  and the rules for the fonts in the webpack config file
Layout meals-footer
Required changes and other changes made
Navbar and icons added to images
Suggested changes for nav bar
All branches merged
Order styles and add main tag
Add categories section and meals responsive design
Required changes meals and slogan correction
Layout/meals-footer already checked
[Fix] the layout sections (positions and box model)
[Change] the with of each section
feat(modal): add modal layout
[Add] some general utils functions and some code for the searcher
[Delete] the second section of the meals
Get categories data from API and render cards.
Create new file for get categories endpoint
Add scroll view to categories section with PC width
[Add] the laoder, the search results and clean the DOM
[Add] the skeleton to the images loaded of the meals  and [Add] the possibility to get back into the initial layout
General fixes and GH users added to Readme
Load categories
[Refactor] to change the function createCard into the utils file
Render meals by category
feat(modal): add modal to random
[Fix] a problem with the re-render the categories
[Fix] the dynamically re-render of the initial layout
[Add] a message when there are no search results and add sweet alert for some notifications
[Add] the load more feature in the meals
[Add] dynamically the title for category
[Add] styles to the load-more button and pass into the utils file the functions to use that
[Comment] the code and organize it better
feat(modal): add ingredients
feat(modal): add close button
fix modal ingredients issue
fix merge issues with feature/modal
docs(readme): add link to live website
Add close model with esc key
fix(ingredients): fix issue with undefined or null ingredientes
refactor(ingredients): refactor fix of ingredientes

No se utiliza el archivo randomMeals.js?


[IR Runtime] IR TagOpt for more compact structure in Runtime

What do these changes do?

Use KeyId for all tags in Runtime for more compact Record structure.
Add TagMeta processing in Sink Op (in Proto, IR-Core and Runtime).
Fix all related CI tests.

Related issue number

Fixes #1593

Codecov Report

Merging #1594 (89a17b6) into main (55d31d8) will decrease coverage by 32.83%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1594       +/-   ##
===========================================
- Coverage   73.17%   40.33%   -32.84%
===========================================
  Files          88       88
  Lines        9714     9714
===========================================
- Hits         7108     3918     -3190
- Misses       2606     5796     +3190

Impacted Files
Coverage Δ

python/graphscope/tests/unittest/test_java_app.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_cython_ast.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ython/graphscope/tests/unittest/test_serailaize.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/analytical/udf/patch.py
3.47% <0.00%> (-96.53%)
:arrow_down:

python/graphscope/tests/unittest/test_lazy.py
0.00% <0.00%> (-96.30%)
:arrow_down:

...thon/graphscope/tests/unittest/test_scalability.py
0.00% <0.00%> (-96.16%)
:arrow_down:

python/graphscope/tests/unittest/test_app.py
0.00% <0.00%> (-95.66%)
:arrow_down:

...hon/graphscope/tests/unittest/test_create_graph.py
0.00% <0.00%> (-92.00%)
:arrow_down:

python/graphscope/tests/unittest/test_graph.py
0.00% <0.00%> (-84.93%)
:arrow_down:

python/graphscope/tests/unittest/test_context.py
0.00% <0.00%> (-81.04%)
:arrow_down:

... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d31d8...89a17b6. Read the comment docs.


"Header fields are too long for server to interpret"   form chrom (IDFGH-4966)

I (30) boot: ESP-IDF v4.2-dirty 2nd stage bootloader
chrom:"Header fields are too long for server to interpret"
IE:正常

https://github.com/espressif/arduino-esp32/issues/2983

@negativekelvin Thanks for sharing the notes, @cqwuxiaolong would you please help provide more details as suggested in the issue template? Information like elf, sdk configuration, backtrace, log outputs, commit ID, hardware and etc. would help us debug further. Thanks.

@cqwuxiaolong
Please try increasing HTTP max header size, ref:
https://github.com/espressif/esp-idf/blob/1067b28707e527f177752741e3aa08b5dc64a4d7/components/esp_http_server/Kconfig#L3-L8
Please feel free to re-open in case there is any issue


CBMC unwinds forever on s2n-quic with the MIR linker enabled

One of the harnesses in s2n-quic (round_trip) that was previously solved fairly quickly now unwinds forever.
Steps to reproduce

git clone https://github.com/aws/s2n-quic
cd s2n-quic/quic/s2n-quic-core
git checkecout 80e5a554fea9f5ca5ed9befa8012170eaecfdd62
cargo kani --tests --harness round_trip --unwind 5 --enable-unstable --mir-linker

CBMC keeps unwinding for more than 2 minutes and never gets to the solving stage:
Unwinding loop _ZN4core6option15Option$LT$T$GT$3map17h910530024d5c6d0bE.0 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs line 932 column 5 function std::option::Option::<usize>::map::<usize, [closure@core::slice::memchr::memchr_general_case::{closure#2}]> thread 0
Unwinding loop _ZN4core6option15Option$LT$T$GT$3map17h910530024d5c6d0bE.1 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs line 932 column 5 function std::option::Option::<usize>::map::<usize, [closure@core::slice::memchr::memchr_general_case::{closure#2}]> thread 0
Unwinding loop _ZN4core6option15Option$LT$T$GT$3map17h910530024d5c6d0bE.0 iteration 2 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs line 932 column 5 function std::option::Option::<usize>::map::<usize, [closure@core::slice::memchr::memchr_general_case::{closure#2}]> thread 0
Unwinding loop _RINvNvXs1_NtNtCs4IvNUtTnEFD_4core5slice5indexINtNtNtBc_3ops5range5RangejEINtB8_10SliceIndexSpE13get_unchecked7runtimehECs1AVzK06CBl6_13s2n_quic_core.0 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs line 295 column 13 function <std::ops::Range<usize> as std::slice::SliceIndex<[T]>>::get_unchecked::runtime::<u8> thread 0
aborting path on assume(false) at file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs line 294 column 13 function <std::ops::Range<usize> as std::slice::SliceIndex<[T]>>::get_unchecked::runtime::<u8> thread 0
Unwinding loop _RINvNvXs1_NtNtCs4IvNUtTnEFD_4core5slice5indexINtNtNtBc_3ops5range5RangejEINtB8_10SliceIndexSpE13get_unchecked7runtimehECs1AVzK06CBl6_13s2n_quic_core.0 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/slice/index.rs line 295 column 13 function <std::ops::Range<usize> as std::slice::SliceIndex<[T]>>::get_unchecked::runtime::<u8> thread 0
Unwinding loop memcmp.0 iteration 1 file <builtin-library-memcmp> line 25 function memcmp thread 0
Unwinding loop memcmp.0 iteration 2 file <builtin-library-memcmp> line 25 function memcmp thread 0
Not unwinding loop memcmp.0 iteration 3 file <builtin-library-memcmp> line 25 function memcmp thread 0
Unwinding loop _RNvXNtNtCs4IvNUtTnEFD_4core3str7patternNtB2_12CharSearcherNtB2_8Searcher10next_matchCs1AVzK06CBl6_13s2n_quic_core.0 iteration 2 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/str/pattern.rs line 439 column 28 function <std::str::pattern::CharSearcher as std::str::pattern::Searcher>::next_match thread 0
...

Kani Version: af6c93eb74520c9d7eeda3b7e7f28220d617b9cf
If I don't enable the MIR linker, verification completes successfully:
$ cargo clean; cargo kani --tests --harness round_trip --unwind 5

<snip>

SUMMARY:
 ** 0 of 1339 failed (1 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 43.949997s

With 1eb9643d8e98c97dffbfc3f73dfa02abd68974ba, verification completes successfully on this harness with the MIR linker enabled.

This behavior is introduced in 5539c0de6e771bd10c2b692cd6d62f0abba98144. On the previous commit (f3b5a9777c535f386949cfabf55db820b73837e0), the run completes in a few seconds with the MIR linker.

Is it possible that the model is just too big for cbmc to handle? Have you tried setting the unwind loop to 1?

Yes, with an unwind of 1, it finishes quickly, and an unwinding assertion fails:
$ cargo kani --tests --harness round_trip --unwind 1 --enable-unstable --mir-linker
<snip>

SUMMARY:
 ** 1 of 4507 failed (4506 undetermined)
Failed Checks: unwinding assertion loop 1
 File: "/home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/range.rs", line 815, in <(std::collections::Bound<&u8>, std::collections::Bound<&u8>) as std::ops::RangeBounds<u8>>::contains::<u8>

VERIFICATION:- FAILED
[Kani] info: Verification output shows one or more unwinding failures.
[Kani] tip: Consider increasing the unwinding value or disabling `--unwinding-assertions`.
Verification Time: 2.66511s

Any unwind value above 1 causes it to unwind forever.

Here's an independent test that reproduces the same behavior:
pub enum Error {
    Err1(usize),
    Err2,
}

use std::fmt;
impl fmt::Display for Error {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            Self::Err1(len) => write!(f, "err1: {}", len),
            Self::Err2 => write!(f, "err2"),
        }
    }
}

fn encode(x: i32) -> Result<Vec<u8>, ()> {
    if x > 10 {
        Ok(vec![1])
    } else {
        Err(())
    }
}

fn decode_inner(v: &Vec<u8>) -> Result<(), Error> {
    let x = match v.len() {
        1 => Err(Error::Err1(3)),
        2 => Err(Error::Err2),
        _ => Ok(()),
    };
    x
}

fn decode(v: Vec<u8>) -> Result<(), String> {
    decode_inner(&v).map_err(|err| err.to_string())?;
    Ok(())
}

#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let v = encode(kani::any()).unwrap();
    let _ = decode(v);
}

$ kani err_vec.rs --enable-unstable --mir-linker

Unwinding loop _ZN4core10intrinsics23is_aligned_and_not_null17h6eae2af2c254ed47E.1 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2204 column 5 function std::intrinsics::is_aligned_and_not_null::<u8> thread 0
Unwinding loop _ZN4core10intrinsics23is_aligned_and_not_null17h6eae2af2c254ed47E.2 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2204 column 5 function std::intrinsics::is_aligned_and_not_null::<u8> thread 0
Unwinding loop _RINvNvNtCs4IvNUtTnEFD_4core10intrinsics19copy_nonoverlapping7runtimehECs7nqv5Ecv62r_7err_vec.4 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2329 column 13 function std::intrinsics::copy_nonoverlapping::runtime::<u8> thread 0
Not unwinding loop _RINvNvNtCs4IvNUtTnEFD_4core10intrinsics19copy_nonoverlapping7runtimehECs7nqv5Ecv62r_7err_vec.0 iteration 2 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2329 column 13 function std::intrinsics::copy_nonoverlapping::runtime::<u8> thread 0
Unwinding loop _RINvNvNtCs4IvNUtTnEFD_4core10intrinsics19copy_nonoverlapping7runtimehECs7nqv5Ecv62r_7err_vec.1 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2329 column 13 function std::intrinsics::copy_nonoverlapping::runtime::<u8> thread 0
Unwinding loop _RINvNvNtCs4IvNUtTnEFD_4core10intrinsics19copy_nonoverlapping7runtimehECs7nqv5Ecv62r_7err_vec.5 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2329 column 13 function std::intrinsics::copy_nonoverlapping::runtime::<u8> thread 0
aborting path on assume(false) at file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/intrinsics.rs line 2328 column 9 function std::intrinsics::copy_nonoverlapping::runtime::<u8> thread 0
aborting path on assume(false) at file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs line 853 column 15 function std::result::Result::<std::ptr::NonNull<[u8]>, std::alloc::AllocError>::map_err::<std::collections::TryReserveError, [closure@alloc::raw_vec::finish_grow<std::alloc::Global>::{closure#1}]> thread 0
Unwinding loop _ZN4core6result19Result$LT$T$C$E$GT$7map_err17h0793994c3d33a0c8E.0 iteration 1 file /home/ubuntu/.rustup/toolchains/nightly-2022-09-13-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs line 857 column 5 function std::result::Result::<std::ptr::NonNull<[u8]>, std::alloc::AllocError>::map_err::<std::collections::TryReserveError, [closure@alloc::raw_vec::finish_grow<std::alloc::Global>::{closure#1}]> thread 0
...

Can also be reproduced without Vec:
pub enum Error {
    Err1(usize),
    Err2,
}

use std::fmt;
impl fmt::Display for Error {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            Self::Err1(len) => write!(f, "{}", len),
            Self::Err2 => write!(f, ""),
        }
    }
}

fn encode(x: i32) -> Result<[u8; 1], ()> {
    if x > 10 {
        Ok([1])
    } else {
        Err(())
    }
}

fn decode_inner(v: &[u8]) -> Result<(), Error> {
    let x = match v.len() {
        1 => Err(Error::Err1(3)),
        2 => Err(Error::Err2),
        _ => Ok(()),
    };
    x
}

fn decode(v: [u8; 1]) -> Result<(), String> {
    decode_inner(&v).map_err(|err| err.to_string())?;
    Ok(())
}

#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let v = encode(kani::any()).unwrap();
    let _ = decode(v);
}

Does this involve function pointers of any kind? Do you perhaps end up with an extremely broad computation tree?

Possibly, through the fmt::Display trait. Is there a way to check in the goto binary/symbol table file?

If you do goto-instrument --show-goto-functions on the final goto binary you should get to witness this, but also --gen-c would show a large number of function calls.

Shrinked even further and removed all non-determinism:
pub enum Error {
    Err1(usize),
}

use std::fmt;
impl fmt::Display for Error {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        match self {
            Self::Err1(len) => write!(f, "{}", len),
        }
    }
}

fn decode_inner() -> Result<(), Error> {
    Err(Error::Err1(3))
}

fn decode() -> Result<(), String> {
    decode_inner().map_err(|err| err.to_string())?;
    Ok(())
}

#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let _ = decode();
}

The Display trait is implemented everywhere in the std. I'm not surprised that blows up. Maybe --restrict-vtable can help

--restrict-vtable didn't make any difference.

BTW, I'm using the following example:
pub struct Error(usize);

use std::fmt;
impl fmt::Display for Error {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        write!(f, "{}", self.0)
    }
}

#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let s = Error(0).to_string();
    assert!(s.len() > 0);
}

@tautschnig Does cbmc have any nicer way to debug loop unwinding such as a graphical representation of the call graph?

This is the output from goto-instrument --dump-c on the reduced testcase (had to use CBMC latest to include the fix for https://github.com/diffblue/cbmc/issues/7158):
test.txt

@celinval tracked this down to the formatting code (specifically the write! macro).
@camshaft, a workaround is to replace the fmt code under kani:
diff --git a/common/s2n-codec/src/decoder/mod.rs b/common/s2n-codec/src/decoder/mod.rs
index de45b163..45f8dbe1 100644
--- a/common/s2n-codec/src/decoder/mod.rs
+++ b/common/s2n-codec/src/decoder/mod.rs
@@ -424,14 +424,18 @@ pub enum DecoderError {
 use core::fmt;
 impl fmt::Display for DecoderError {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        match self {
-            Self::UnexpectedEof(len) => write!(f, "unexpected eof: {}", len),
-            Self::UnexpectedBytes(len) => write!(f, "unexpected bytes: {}", len),
-            Self::LengthCapacityExceeded => write!(
-                f,
-                "length could not be represented in platform's usize type"
-            ),
-            Self::InvariantViolation(msg) => write!(f, "{}", msg),
+        if cfg!(kani) {
+            Ok(())
+        } else {
+            match self {
+                Self::UnexpectedEof(len) => write!(f, "unexpected eof: {}", len),
+                Self::UnexpectedBytes(len) => write!(f, "unexpected bytes: {}", len),
+                Self::LengthCapacityExceeded => write!(
+                    f,
+                    "length could not be represented in platform's usize type"
+                ),
+                Self::InvariantViolation(msg) => write!(f, "{}", msg),
+            }
         }
     }
 }

This makes the round_trip proof go through quickly.

Here's another minimal reproducer:
use std::fmt::Write;

#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let mut s = String::new();
    let _ = write!(&mut s, "Arg {}", 5);
}

@tautschnig Does cbmc have any nicer way to debug loop unwinding such as a graphical representation of the call graph?

You can use goto-instrument --dot to obtain a diagram (but I guess on this occasion you've managed to track down the problem already?).

but I guess on this occasion you've managed to track down the problem already?

Not really. We only know it's related to the formatting code, but not sure exactly why the unwinding is not terminating.

Yet another minimal reproducer:
#[kani::proof]
#[kani::unwind(2)]
fn main() {
    let a = std::fmt::format(format_args!("{}", 5));
}

I've extracted the relevant code from std, and created a test that pretty much doesn't use any of the formatting code in std, but still reproduces the unbounded unwinding behavior:
pub trait Trait {
    fn f(&self, c: char);
}

struct Foo {}

impl Trait for Foo {
    fn f(&self, c: char) {
        let _ = c.encode_utf8(&mut [0; 4]);
    }
}

pub struct Formatter {}

fn nn(_x: &u8, _f: &Formatter) {}

pub struct ArgumentV1<'a> {
    value: &'a u8,
    formatter: fn(&u8, &Formatter) -> (),
}

impl<'a> ArgumentV1<'a> {
    pub fn new<'b>(x: &u8, f: fn(&u8, &Formatter) -> ()) -> ArgumentV1<'b> {
        unsafe {
            ArgumentV1 {
                formatter: std::mem::transmute(f),
                value: std::mem::transmute(x),
            }
        }
    }
}

pub struct Arguments<'a> {
    args: &'a [ArgumentV1<'a>],
}

impl<'a> Arguments<'a> {
    pub const fn new_v1(args: &'a [ArgumentV1<'a>]) -> Arguments<'a> {
        Arguments { args }
    }
}

pub fn write(_output: &mut dyn Trait, args: Arguments<'_>) {
    let formatter = Formatter {};

    for arg in args.args {
        let _ = (arg.formatter)(arg.value, &formatter);
    }
}

#[cfg_attr(kani, kani::proof, kani::unwind(2))]
fn main() {
    let mut f = Foo {};
    let a = [ArgumentV1::new(&5, nn)];
    let args = Arguments::new_v1(&a);
    write(&mut f, args);
}

Reduced the above test further to:
pub trait Trait {
    fn f(&self);
}

struct Foo {}

impl Trait for Foo {
    fn f(&self) {
        let _ = 'x'.encode_utf8(&mut [0; 4]);
    }
}

pub struct Formatter {}

fn nn(_x: &u8, _f: &Formatter) {}

pub struct ArgumentV1 {
    formatter: fn(&u8, &Formatter) -> (),
}

impl ArgumentV1 {
    pub fn new<'b>() -> ArgumentV1 {
        unsafe {
            ArgumentV1 {
                formatter: std::mem::transmute(nn as fn(_, _)),
            }
        }
    }
}

#[cfg_attr(kani, kani::proof, kani::unwind(2))]
fn main() {
    let f = Foo {};
    let a = [ArgumentV1::new()];

    let _output = &f as &dyn Trait;
    let formatter = Formatter {};

    for arg in &a {
        let _ = (arg.formatter)(&5, &formatter);
    }
}

Function pointer removal as taking place in goto-instrument will replace the arg.formatter pointer by a number of candidate functions. The set of "candidate" functions is determined by looking at matching (with very coarse over-approximation) signatures. See also https://diffblue.github.io/cbmc/man/goto-instrument.html, search for the documentation of --remove-function-pointers. With --mir-linker, the pool of candidate functions is much larger. The problem then really is the functions called from these candidate functions. In many cases, the constant propagation during symbolic execution may alleviate this problem when the actual value of the function pointer can be precisely determined. It seems that's not the case here, AFAIK owing to the loop iteration (actually whatever iterators do under the hood). It maybe be worth diving further why we can't constant-propagate this here. So you end up with a number of functions being called when it should really just be nn (if I understand the Rust code correctly). You might have to use --restrict-vtable on this example.

https://github.com/diffblue/cbmc/pull/7243 fixes this particular example as constant propagation can then figure out during symbolic execution that nn is the only possible value for the function pointer.
(Some more information from the analysis of the above example with @zhassan-aws: let _output = &f as &dyn Trait; adds f to the candidate list of functions being considered by CBMC's function pointer removal as f's address is taken at that point. This, in turn, will result in encode_utf8 being symbolically executed, and that function just appears to be large (or itself be calling many other functions). Also, it seemed that it was required to both take a slice and use an iterator to take constant propagation off track.)

That's awesome! Thanks for investigating and figuring out a fix @tautschnig!

One thing that is weird though is that encode_utf8 does not seem to be an issue in itself. For example, this small program:
fn foo(c: char, buf: &mut [u8]) {
    c.encode_utf8(buf);
}

#[kani::proof]
fn main() {
    let mut buf = [0; 4];
    foo('x', &mut buf);
    assert_eq!(buf, [120, 0, 0, 0]);
}

is verified in a fraction of a second:
$ kani encode.rs --enable-unstable --mir-linker
<snip>

SUMMARY:
 ** 0 of 91 failed (7 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 0.17814663s

Even if I hide the function behind dyn trait to mimic the other program, it still finishes quickly:
trait T {
    fn foo(&mut self, c: char, buf: &mut [u8]);
}

struct Foo {}

impl T for Foo {
    fn foo(&mut self, c: char, buf: &mut [u8]) {
        c.encode_utf8(buf);
    }
}

fn bar(x: &mut dyn T) {
    let mut buf = [0; 4];
    x.foo('x', &mut buf);
    assert_eq!(buf, [120, 0, 0, 0]);
}

#[kani::proof]
#[kani::unwind(5)]
fn main() {
    let mut f = Foo {};
    bar(&mut f);
}

$ kani encode2.rs --enable-unstable --mir-linker
<snip>

SUMMARY:
 ** 0 of 104 failed (7 unreachable)

VERIFICATION:- SUCCESSFUL
Verification Time: 0.18649799s

So I'm not sure why it's causing issues in the other program.

Following up on https://github.com/model-checking/kani/issues/1767#issuecomment-1279423415: it seems that working through the Formatter with perhaps a lack of constant propagation is what takes forever. Logs kindly shared by @zhassan-aws  from an older version of CBMC that didn't have the necessary improvements include lines like:
Unwinding recursion <std::fmt::Arguments<'_> as std::fmt::Display>::fmt iteration 1

and almost all the instructions symbolically executed stemming from either lib/rustlib/src/rust/library/core/src/fmt/mod.rs or lib/rustlib/src/rust/library/core/src/fmt/num.rs.


Remove using block in RentRosterApp_Load

Reported by Peter Csala in code review.

I don't see the need why do we need using block around this form

There should not be a using block here, will investigate more as to if there should be a try { } catch () {} block.


Implement FP division

This PR implements abstract FP division (aka smt::Expr AbsFpEncoding::div())

If one or more operand of div is NaN, it yields NaN as well.
0.0 / 0.0 and Inf / Inf yields NaN.
finite x / Inf yields 0.0
Inf / finite x yields Inf
Finite x / 0.0 yields Inf.
This is division by zero and signaling exception should be raised according to IEEE754 standard, but LLVM ignores the signal and continues the execution. We follow this semantics as well.
Otherwise, it yields an arbitrary BV with appropriate sign.
Litmus tests are added to verify the above behaviors

Q: what is the relation between div and mul?


Pass POD_NAMESPACE in

ref: https://github.com/open-cluster-management/backlog/issues/13382
Signed-off-by: clyang82<EMAIL_ADDRESS>

/hold for approve

/retest
/unhold

/assign @morvencao


Timeout on wait_for_cluster is breaking our terraform code

Description
The PR #1359 is breaking out installation as it takes more than 5 minutes for the kubernetes api service to be provisioned.
Either this number should be considerably large or should be configurable.
I am not sure if this number can be configure. If yes, it is not well documented. Could some help us out please?
Versions

Terraform: v0.14.4
Module: eks

Code Snippet to Reproduce

 connect: connection timed out

on .terraform/modules/eks/cluster.tf line 68, in data "http" "wait_for_cluster":
68: data "http" "wait_for_cluster" {

The endpoint that wait_for_cluster is trying to wget is accessible outside cluster. I did wget and verify that.
Expected behavior
cluster gets provisioned
Actual behavior
cluster does not get provisioned but kubeconfig is acquired

Thanks @debarshibasak for opening this issue.
Are you deploying a private (with private endpoint) EKS cluster ? Is timeout happens once during your apply ? I mean, Is your second apply perform well ?
I'm trying to figure out if there is a network issue.

Hey @barryib Thanks for your question. We are deploying public cluster. The endpoint is reachable later and return 200, but it takes quite some time.
It takes more than 500 seconds. I noticed it has hardcoded parameter in wait_for_cluster. I think it would be nice if that is customizable.
Yes second apply works.

5mn was the previous setting. So far, it was working well.
That means, EKS cluster is created, but it's not ready to use in less than 5mn ? Is something else going wrong ? Any thoughts ?
As for the timeout variable, yes we can add it. Please open a PR.

Terraform ended with timeout error on "/healthz" , thats why I created this ticket. Let me try to reproduct this a few more times. It might just be flaky issue.

Hey, we have noticed this behavior as well.  Our TAM/AWS support suggested waiting a longer period of time before we attempt to configure our aws-auth configmap.
I've attempted to fix this in #1420.  Please let me know if this is acceptable.

which region you trying to create EKS?

Not sure of OP, but we're seeing this in us-east-2.  We've also seen it in us-east-1.

@barryib Is there an ETA on when this will be in a released version?   We're still seeing timeouts while building our clusters and would like to increase it as soon as we can.

Seems like I can still running into this issue (even with the cluster timeout specified).  It fairly consistently will fail while waiting for the creation (and doesn't look like it actually waits the time I've specified, i.e. barely makes it 1m15s or so based off build timestamps). A re-run immediately after will pass, however.


Typo "@login_name"→"@login_name"

bold with escape characters
https://docs.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-grant-login-to-proxy-transact-sql?view=sql-server-2017

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @hyoshioka0128!
#sign-off


[Suggest]: Much needed features!

Is your feature request related to a problem? Please describe.

Can't re-order any post types such as news articles or store items. If you want them in a specific order you have to create them in that order.

A browser image upload feature is much needed, putting HTML image sources into every description box is very tedious and time-consuming. This is again for news articles and store items. There is one for news thumbnails but not the main content or store items.

News article summaries on the home page use truncating (mb_substr) but cut off per letter rather than finishing on a word or ending a sentence. A better solution would be to provide a separate input for the summary and another for the main article.

News article summary thumbnails don't fit their containers when the text exceeds the height. The border stretches but the image does not resize with it.

The mobile burger menu opens on touch but doesn't close again — you have to tap the oddly placed X to close the menu. Obviously, the best solution is to allow the burger menu to open and close on interaction.

Some elements and areas aren't responsive, particularly leaderboard and timer tables. They should have a breakpoint on viewport reduction to fit.

Describe the solution you'd like.
These changes are big QOL features that should be implemented to vastly improve the CMS. Having just created a new theme for BlizzCMS it took much longer than it should have with not having these basic features (in simple terms) There are obviously lots of other features that the CMS would benefit from but I feel these alone would be a massive improvement.
Describe alternatives you've considered.
No response
Additional context.
Appreciate your work on this open-source project, hopefully, more people can jump aboard and improve.

The store needs an alert that prompts the user to say that their purchase was complete. Currently, the purchase completes without any mention if it was successful or not etc. It just clears your basket.

Hello @Fot3k

Can't re-order any post types such as news articles or store items. If you want them in a specific order you have to create them in that order.

It is a good idea, we could add an order field so that you can re-order the news, anyway, a news is ordered by the publication date from the most recent to the oldest.

A browser image upload feature is much needed, putting HTML image sources into every description box is very tedious and time-consuming. This is again for news articles and store items. There is one for news thumbnails but not the main content or store items.

We could add something like a middle section where all the images are saved, it is something that should be studied.

News article summaries on the home page use truncating (mb_substr) but cut off per letter rather than finishing on a word or ending a sentence. A better solution would be to provide a separate input for the summary and another for the main article.

It is something that will be taken into account for possible improvements.

The mobile burger menu opens on touch but doesn't close again — you have to tap the oddly placed X to close the menu. Obviously, the best solution is to allow the burger menu to open and close on interaction.

I understand what you mean, I think the new version is already added.

Some elements and areas aren't responsive, particularly leaderboard and timer tables. They should have a breakpoint on viewport reduction to fit.

We have to review many sections, it will take time but it will be made or modified to be responsive.
Work is being done to improve the life cycle of the product, this is something that takes time but many things have been improved in refactor. This, obviously as I said, cannot be applied to Master, but this branch is already allowed to be reviewed, all these changes will be reviewed to apply either in refactor or in master depending on whether the improvement is urgent or not.
Thank you very much, we take your suggestions into account.


Recommendation: Theme template standards

In the Grav documentation, it says:

There are no set rules regarding the structure of a Grav theme except that there must be appropriate Twig templates provided in the templates/ folder for each of the page types you use in your content.

I would recommend changing that to the benefit of the end user. I ran into this when trying to change themes was that pages that were attached to templates that didn't have the same name/path in another theme, it caused an instant exception.
Because there are no set rules for a Grav theme, there is inherent incompatibility between themes built into Grav. In other words, Grav is currently designed for themes to fail, which isn't a great user experience and could be improved.
What I would recommend instead:

Establish a few very simple and limited rules for "base" templates required for a theme.
Publish a set of recommended guidelines for template structuring including paths and names.
Set a behavior in Grav that missing templates will fallback to particular default templates. (Set in No. 1)

What do you think?

I'm not sure what "rules" you'd create. Depending on the content you're trying to serve, you may only need one or two templates. I guess it wouldn't be too burdensome to say all themes must have a "default" template. I'm just not sure what you gain.

Immediately following the quote you pulled you'll also see the following:

A good way to create general themes is to support the template types used by the Skeleton packages that are available on our downloads page. For example, support: default, blog, error, item, and modular.

What additional guidance might you suggest? I agree that documentation is really important. If you use the Devtools plugin to create the theme, you can see that it does create some basics for you. That might be a good place to make changes, too.

Fallback sounds nice, but what would it fall back to? Let's say we mandated a "default" template but one didn't exist, should Grav use something built in? Even if some built-in fallback were created, I would rather know that something was wrong (via exception) than get unintended output. A missing template is indeed a problem to be solved.

I agree that to compete with CMSs like WordPress, theme changing needs to be as painless as possible. I'm just not sure how far the core system can go to mitigate this.
(I'm not a team member, just an avid user.)

Even if there wasn't a clear fallback, if Grav wants to keep it's flexibility, then there should be a way to users to either cast (overwrite and change) pages to the new theme's templates, or alias (map to a theme's templates, but without changing the values in case you want to switch back).
Right now, it just breaks, and after failing to figure out where it was breaking, or figuring out an easy way to just try out the theme without a bunch of tedium, I just kind of threw up my hands and went back to the original theme.
As far as additional guidance, the part about "a good way" is good, but I would switch that to recommended, along with a list of optional recommended theme file names.
Another problem, I noticed (I think) that not only does the filename have to match, but they have to be in the same folder structure, no? I could be wrong about that.
Anyway, I think you get what I'm saying. Right now page migration between themes is very painful, and it really doesn't have to be. And because it's so painful, I think it's even a bit misleading to call them "themes", because I would say that there's a user expectation that they behave like Wordpress themes i.e. they are (mostly) interchangeable. They behave more like libraries that have a unique API.

There is no folder structure involved. When Grav goes to the requested folder, it looks for an X.md file. It then looks in the user/themes/THEME/templates folder for X.html.twig and applies it, regardless of where exactly X.md lives.
As for modifying existing themes, there is a best practice for that. It's a simple matter to symlink templates to a new name so you don't have to change your existing page data. But this does indeed require facility with the terminal. I don't use the Admin plugin, so I have no direct experience with this, but I know they are working hard to make it easy for non-command-line folks to do this sort of thing with relative ease. It's not an easy thing, though.

Just to add my two-cents, even just having a list of suggested core theme Twig template filenames would be helpful - I think in some ways Antimatter has served this purpose for blog sites. For non-blog sites is there a suggested list of template files/names?
One thing I've started to do in my own custom themes is to also provide a default Twig file for modular content, just to help get things going 🙂

This is by design. A theme has much more power than what other popular CMS grant to themes.
That's part of Grav's flexibility, a theme is not just a skin. The theme is a fundamental part of the design of the site, not just the UI but the information architecture, the functionality etc.
That's why you can't really switch themes easily, unless the themes are very general / simple.
This is what allows Grav sites to be very different with minimal use of plugins. Consider the skeletons RTFM, Receptar, Ceevee, Course Hub, they can do what they do because the theme has special handling for special page types.
This is no different than what happens with other CMS as well, considering for example Custom Post Types in WP.
Then, it's nice if every theme could provide a default page, and a blog structure for example, but it's not required.

I think this has been answered already, but for clarification:

Grav is not a typical CMS where the theme is purely a skin over your site.  The theme is an integral part, and as Grav has no real requirements as to how you structure your site, not can the theme.

This is by design.  Grav is built this way to ensure it's supremely flexible, and can be tailored to support any kind of site design you wish.  I believe this is one of the reasons why it's so hard to work with WordPress/Joomla/etc as they enforce strict rules on what a theme can do, what it provides, etc. Grav has no such limitations and is better for it.

Grav makes it pretty easy to create 'skeleton' packages which are really ready-to-roll demo sites with content + configuration + plugin + theme.  This means that you can create wildly different site types and make them easy to install and modify by the end user.  This is not typically a simple thing for other platforms.

I would suggest theme designers grab a theme they wish to use as their basis, and follow the structure/templates of that theme for their own.  Antimatter is the closest thing Grav has for a kitchen-sink type theme, that can handle a single page design (via modular twig templates), blog layout, and simple pages.  That is a good model to copy if you wish to provide a more 'general' theme.


OUs under roots excluded from RLS scan

A reproducible test case or series of steps

Create 20 OUs under root
Run CIDRLS Lambda
Only last 5 OUs are scanned for cid_users and cid_groups tags

The version of our code being used

Current

Any modifications you've made relevant to the bug

Extended the OUs results  with the previous results

Anything unusual about your environment or deployment

None

I believe the issue lies in the line below
https://github.com/awslabs/cid-framework/blob/b6c156423b19976824b6d0595905a00023b6a8b3/rls/deploy/create_rls.py#L77

@vmindru Any thought?

Checking

@vmindru any update?

@vmindru any update?

@jborhen-tc  can you please test agai using this code https://raw.githubusercontent.com/awslabs/cid-framework/refs/heads/large_ou_crawler_fix/rls/deploy/create_rls.py

Hey @vmindru , unfortunately I am not at liberty of changing our current solution especially when we have already implemented a fix.
Essentially, I have altered the function below to extend list_ous_result  with the previous iteration's list_ous_result  ous ids(see comments).
def get_children_ou(ou, org_client):
    NextToken = True
    children_ou = []
    while NextToken:
        if type(NextToken) is str:
            # Save previous list_ous_result OUs IDs in a temporary variable
            list_ous_result = org_client.list_organizational_units_for_parent(ParentId=ou, MaxResults=20, NextToken=NextToken)
            # Extend list_ous_result  with the OUs IDs in the temporary variable
        else:
            list_ous_result = org_client.list_organizational_units_for_parent(ParentId=ou, MaxResults=20)
        if 'NextToken' in list_ous_result:
            NextToken = list_ous_result['NextToken']
        else:
            NextToken = False
        ous = list_ous_result['OrganizationalUnits']
        for child_ou in ous:
            children_ou.append(child_ou['Id'])
    return children_ou

Hi @jborhen-tc  thanks, this is  good enough,  the fix in   https://raw.githubusercontent.com/awslabs/cid-framework/refs/heads/large_ou_crawler_fix/rls/deploy/create_rls.py is litterly the same you did here.

again thanks a lot for reporting and for further comments, have a good one.

I appreciate the support, I believe this can be closed now.

@jborhen-tc  just to clear,  please do not use yet the code in the patch mentioned, your fix is good enough. The  patch i suggested has other changes that where not fully tested yet. Have a good day.

@vmindru Sure thing, I will refrain from that. Have a great day!


Edge selection / creation

When the user select the edge on the current canvas a modal should open with a data table to show all the connections with the ability to change a existing or create a new one
If the user connect to nodes a modal should open to inform the edges data and than save it

It is working in a similar way


Gfm does not retain encoding in Windows, garbles non-ASCII text

Hi,
I noticed that in Windows, Gfm renders text correctly only when a preview is displayed for the first time.
Afterwards, when a change is made to the source file and the markdown preview is regenerated, characters are no longer displayed in the encoding of the source file (e.g. UTF-8). Instead, the file content is displayed as if it were encoded according to the default Windows code page. That code page normally depends on the system, or more precisely on the language settings; a typical code page for a Windows set to English would be Windows-1252.
The content of the source file is not affected, it is just a display problem in the Gfm preview.
ASCII characters survive the process intact because they are represented by the same byte sequence in all encodings.  An en dash, for instance, morphs from – to â€“, a Euro sign from € to â‚¬, and a German ä umlaut appears as Ã¤.
I am not the first one to notice, though ;) The following reports seem to be variations of the theme and are likely to be the exact same issue, or closely related:

#64 Cyrillic support
#68 German umlauts
#102 Chinese garbled on Windows platform

Hope that helps you to resolve the issue.  Thank you!
Cheers,
Michael

Should be fixed in v0.1.9

Thx for the help.

That did the trick :) The issue is gone in 0.1.9. Thank you for your quick response!


High CPU Usage

I have used filesize extension for many years. However, i ran into a trouble with high cpu usage when using vscode recently.
I disabled all extionsions i have installed and enable them one by one, i finally found out that when i enable this extension, a process called Code Helper (Plugin) kept running after everytime i reload the window, and 100% cpu usage was eaten by them.
My environ:
MacOS 15.0.1 (24A348)

Version: 1.95.0 (Universal)
Commit: 912bb683695358a54ae0c670461738984cbb5b95
Date: 2024-10-28T20:16:24.561Z (2 days ago)
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.0.0

Same here

Yes, I'm reproducing this as well, strange bug that only happens after a window reload as you said.
I will look into this together with other issues, should have a new release soon.

@zhangkai803 I released version 3.2.1 today, but I think the problem continues, I'll further investigate this.

+1 Encountered the same problem following a recent update to this extension. Both my local machine and all remote VS Code sessions experienced 100% CPU utilization spikes, attributed to a node process. Uninstalling the extension and restarting the servers successfully resolved the issue.

@zhangkai803 I released version 3.2.1 today, but I think the problem continues, I'll further investigate this.

Thanks for your time. I have tested version 3.2.1 on my machine and yes, this problem still exists.

Same here！！！！

+1

Same here！！！！
 I reinstalled all extensions one at a time, and uninstalled and reinstalled vscode-filesize to confirm it's the one.
Here's details in case it's helpful for debugging.
System
M3 Macbook Air
MacOS 15.1
VSC
Version: 1.95.2
Commit: e8653663e8840adaf45af01eab5c627a5af81807
Date: 2024-11-07T11:07:22.054Z (2 days ago)
Electron: 32.2.1
ElectronBuildId: 10427718
Chromium: 128.0.6613.186
Node.js: 20.18.0
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.1.0
vscode-filesize
v3.2.1
Steps to reproduce

Open Process Explorer to monitor extensionHost
Install vscode-filesize
Trigger a window load (Reload Window is simplest)

Expected
Old extensionHost exits when it is replaced by the new extensionHost process
Actual behavior
On every window load (manually reloading, opening a new workspace or folder, switching profiles), the old extensionHost process remains, ramping up to 99-100% CPU usage and remaining there until VSC is quit. Repeated window loads cause another extensionHost process to be added each time, using an additional 100% of CPU. The processes continue indefinitely until VSC is quit and relaunched entirely. VSC also takes significantly longer to quit when this problem is occurring.
Logs
Extension Host log (viewed with (Developer: Show Logs...' command) with vscode-filesize installed:
2024-11-09 20:38:08.381 [info] Extension host with pid 97510 started
2024-11-09 20:38:08.402 [info] ExtensionService#_doActivateExtension vscode.emmet, startup: false, activationEvent: 'onLanguage'
2024-11-09 20:38:08.410 [info] ExtensionService#_doActivateExtension vscode.github-authentication, startup: false, activationEvent: 'onAuthenticationRequest:github'
2024-11-09 20:38:08.445 [info] ExtensionService#_doActivateExtension vscode.git-base, startup: true, activationEvent: '*', root cause: vscode.git
2024-11-09 20:38:08.447 [info] ExtensionService#_doActivateExtension vscode.git, startup: true, activationEvent: '*'
2024-11-09 20:38:08.472 [info] ExtensionService#_doActivateExtension vscode.github, startup: true, activationEvent: '*'
2024-11-09 20:38:08.554 [info] Eager extensions activated
2024-11-09 20:38:08.582 [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch, startup: false, activationEvent: 'onStartupFinished'
2024-11-09 20:38:08.583 [info] ExtensionService#_doActivateExtension vscode.merge-conflict, startup: false, activationEvent: 'onStartupFinished'
2024-11-09 20:38:08.892 [info] ExtensionService#_doActivateExtension vscode.configuration-editing, startup: false, activationEvent: 'onLanguage:jsonc'
2024-11-09 20:38:08.897 [info] ExtensionService#_doActivateExtension vscode.json-language-features, startup: false, activationEvent: 'onLanguage:jsonc'
2024-11-09 20:38:08.918 [info] ExtensionService#_doActivateExtension vscode.typescript-language-features, startup: false, activationEvent: 'onLanguage:jsonc'
2024-11-09 20:38:27.337 [info] ExtensionService#_doActivateExtension mkxml.vscode-filesize, startup: false, activationEvent: 'onStartupFinished'

>>>2024-11-09 20:38:47.088 [info] Extension host terminating: renderer closed the MessagePort<<<
>>>2024-11-09 20:38:47.629 [info] Extension host with pid 97712 started<<<

2024-11-09 20:38:47.644 [info] ExtensionService#_doActivateExtension vscode.emmet, startup: false, activationEvent: 'onLanguage'
2024-11-09 20:38:47.667 [info] ExtensionService#_doActivateExtension vscode.git-base, startup: true, activationEvent: '*', root cause: vscode.git
2024-11-09 20:38:47.764 [info] ExtensionService#_doActivateExtension vscode.git, startup: true, activationEvent: '*'
2024-11-09 20:38:47.793 [info] ExtensionService#_doActivateExtension vscode.github, startup: true, activationEvent: '*'
2024-11-09 20:38:47.840 [info] ExtensionService#_doActivateExtension vscode.github-authentication, startup: false, activationEvent: 'onAuthenticationRequest:github'
2024-11-09 20:38:47.891 [info] Eager extensions activated
2024-11-09 20:38:47.908 [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch, startup: false, activationEvent: 'onStartupFinished'
2024-11-09 20:38:47.910 [info] ExtensionService#_doActivateExtension vscode.merge-conflict, startup: false, activationEvent: 'onStartupFinished'
2024-11-09 20:38:47.936 [info] ExtensionService#_doActivateExtension mkxml.vscode-filesize, startup: false, activationEvent: 'onStartupFinished'

Normally without vscode-filesize installed, the log contains these lines:
2024-11-09 20:40:11.485 [info] Extension host terminating: renderer closed the MessagePort
2024-11-09 20:40:11.497 [info] Extension host with pid 98143 exiting with code 0
2024-11-09 20:40:11.986 [info] Extension host with pid 98231 started

The logs suggest that vscode-filesize is causing the outgoing extensionHost to fail to exit when it's supposed to.
Process details
I disabled all other extensions except for vscode-filesize, and in this context I only saw a total of 2 extensionHost processes (1 old, 1 new) accumulate. Repeated reloads no longer created new processes.
The singular old extensionHost had a subprocess related to the JSON language server:
extensionHost [1]
CPU: 99
Memory: 164
PID: 5033
    /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin) /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=5033
    CPU: 0
    Memory: 66
    PID: 5076

I personally have no idea what extensionHost does or how it works, but it seems that the amount of extensionHosts spawned is dependent on the number of other extensions enabled? In the below screenshots, all extensions were enabled, and new extensionHosts kept spawning as many times as I reloaded; the extensionHosts similarly had subprocesses pointing to various extensions there.
Initial launch of VSC with filesize installed

First reload

Second reload

Same issue here.
It happened when New Window or Open Recent.

@spktkl thanks for the detailed info, looking into it!

Anyone reproduce this on Windows or Linux?

It's not fixed in 3.2.2 unfortunately, still trying to figure this out, I may need some help from the vscode team.  There is nothing in the code that should result in this.
It may be some change with vscode that is conflicting with the extension code.

Same here！！！！ I spent the whole day searching for this issue. I have too many extensions installed. T^T

Did you try using Start Extension Bisect from Command Palette? Or does this particular problem require a more comprehensive restart between steps?

Same here！！！！ I spent the whole day searching for this issue. I have too many extensions installed. T^T

Did you try using Start Extension Bisect from Command Palette? Or does this particular problem require a more comprehensive restart between steps?

Yes, I tried, but it didn’t help much in identifying the issue. Strange bug that only happens after a window reload, even if you disable all extensions

Anyone reproduce this on Windows or Linux?

yes, seen on linux.

Same here！！！！ I spent the whole day searching for this issue. I have too many extensions installed. T^T

Did you try using Start Extension Bisect from Command Palette? Or does this particular problem require a more comprehensive restart between steps?

Yes, I tried, but it didn’t help much in identifying the issue. Strange bug that only happens after a window reload, even if you disable all extensions

@zhangvj Did you try disabling copilot?
Wasn't able to reproduce this after disabling copilot.

After checking this post I see the vscode team released 1.95.3 that seems to fix the issue, I'm not reproducing it anymore on my env.
Please update vscode to 1.95.3 and check. If more people confirm this, I will close this issue.

After checking this post I see the vscode team released 1.95.3 that seems to fix the issue, I'm not reproducing it anymore on my env.
Please update vscode to 1.95.3 and check. If more people confirm this, I will close this issue.

Met too. Can't reproduce this issue anymore in 1.95.3.

Not reproducing this problem anymore in Version: 1.95.3 (Universal).

Closing it now, if we see this problem reappearing in the future we can reopen this.


Dynaflow: Described the specific simulation parameters of Dynaflow an…

…d provided a Json example
Signed-off-by: Guillaume Pernin<EMAIL_ADDRESS>Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
N/A
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds documentation for Dynaflow, a description of the specific simulation parameters that can be provided, and an example of a json configuration file.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

[ ] The Breaking Change or Deprecated label has been added
[ ] The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)

This PR could be reworked if #157 is merged. In that proposal, I think some important information are missing, such as the way to install DynaFlow. There are mistakes (or inconsistencies) in the name of the implementation.

This PR could be reworked if #157 is merged. In that proposal, I think some important information are missing, such as the way to install DynaFlow. There are mistakes (or inconsistencies) in the name of the implementation.

Inconsistencies should be corrected. For the installation it is still a work in progress on dynaflow-launcher side so best to wait until it is done


Added additional network building features (#367)

This commit adds the following network building features to the API:

Adds additional properties that can be set using EN_setnodevalue, EN_setlinkvalue and EN_setoption that now allows the API to build a complete EPANET network model from code.
Adds new functions EN_setjuncdata, EN_settankdata, and EN_setpipedata that allows one to set values for the multiple object properties with a single function call.
Adds a new unit test (test_net_builder_2) that tests these new functions.
Adds to the enumerated constant names in epanet2_enums.h and revises some v.2.2 names to make them more understandable.

Close Issue #367


Error in console with MS Graph client API

I am following the Tutorial: Consuming APIs secured with Azure Active Directory within SharePoint Framework to create a web part as same as in demo. I am able to create solution, build, package, upload solution to app catalog. Finally i have approved under tenant admin center for Graph API.
I have added this web part to a page and I have selected MSGraphClient, which is giving below error in console.
SCRIPT5022: This instance of the MSGraphClient has not been initialized.
sp-webpart-workbench-assembly_en-us_f0d2645f371530ad8eac3fe9f26f854a.js (11148,24)

If I select AadHttpClient then popup is opening for authentication, but it is never closing. I am using edge browser to do this.
Category

[x] Question
[x] Bug

Edit: If i try in chrome browser AadClient is working fine. But MSGraphClient is still having same issue. In edge it is not returning the access token seems.

I am seeing the same issue, it works in Chrome but not in IE or Edge.

Yes, also experience problems in IE/Edge when using the MSGraphClient

Hi,
I experience exactly the same issue as @bpringe  in Chrome.
It was working fine one week ago.
Regards
Yannick

This may be an issue with the workbench. A coworker informed me it works when deployed to a site and the web part is added to a page on the site.

Here are steps to reproduce this issue:

Create a new spfx webpart project with the yeoman generator
Follow steps 1 and 2 of this tutorial to add the MSGraphClient to your project and get an instance of it in the render method
Run gulp serve --nobrowser
Open the SharePoint workbench at https:///_layouts/15/workbench.aspx and add your webpart to the page
Open Developer Tools and view the error(s) in the console

You need to deploy your app to sharepoint in order to test the MSGraphClient Queries.

@HJK6 Yes, this works, but the queries should be working in the hosted workbench for development.

Lot of stuff has changed with the AAD & MSGraph support since the last activity on this issue... specifically: it's GA and the API changed :). Appears these issues are either resolved / not applicable as the API changed... if not, please feel free to re-open the issue or submit a new one.


synonym dispersed actin cortical patch localization ?

The phenotype caused by ectopic activation of the SIN is very similar to that observed in MOR pathway loss of function mu- tants, which arrest with depolarized actin
can depolarized actin patch
be a synonym of
FYPO:0002021 | dispersed actin cortical patch localization
?

added synonym: "depolarized actin cortical patch localization"
(included "localization" to avoid suggesting that the term refers to how actin is organized within the patch)
edit file: 940e4f1fa6e57fb20827e9f138daab9844811dfb
release: e1793b5c1b70775665337bfa8900d7d6df6a4c67


One node in cluster lost the leader

We have one 5-node cluster where one node grid8 seems to have lost the leader grid7.
# This is the machine which is behaving badly
$ ssh grid8.example.com
user@grid8.example.com:~> flynn-host list
ID                           ADDR             RAFT STATUS
grid8.example.com   <IP_ADDRESS>:1113  peer
grid10.example.com  <IP_ADDRESS>:1113  peer
grid9.example.com   <IP_ADDRESS>:1113  peer
grid6.example.com   <IP_ADDRESS>:1113  peer

# This machine is working just fine
$ ssh grid7.example.com
user@grid7.example.com:~> flynn-host list
ID                           ADDR             RAFT STATUS
grid6.example.com   <IP_ADDRESS>:1113  peer
grid8.example.com   <IP_ADDRESS>:1113  peer
grid9.example.com   <IP_ADDRESS>:1113  peer
grid7.example.com   <IP_ADDRESS>:1113  peer (leader)
grid10.example.com  <IP_ADDRESS>:1113  peer

This also caused the grid8 machine and the services in it to be unresponsive.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Configuring webpack to use lettable operators

I probably wouldn't be able to set up a Core + Angular if it wasn't for this repository :)
I have a question about configuring webpack to be able to use the new lettable operators in rxjs 5.5. As per this I added the following code:
const rxPaths = require('rxjs/_esm5/path-mapping');
...

  resolve: {
        extensions: ['.ts', '.js', '.json'],
        alias: rxPaths()
    },

....

  plugins: [
        new webpack.optimize.ModuleConcatenationPlugin(),
        new webpack.optimize.CommonsChunkPlugin({ name: ['vendor', 'polyfills'] }),
    ...

to the webpack.dev.js file. Webpack isn't my strong suite, so was wondering if that's all it takes, or some other configuration is needed.

IIRC you dont need to change anything using the lettable operators. Just use them in your files...or did you get an error while trying it?

Nope, no errors, just a bit of optimisation.  Without the webpack

Zes, but you can also avoid using the barrel and use
import { filter } from 'rxjs/operators/filter';```

instead.

Will have a look at this at the weekend. Thx for pointing out!

Yepp, just tested. Bundles are a bit smaller. Thanks :) We will add that soon!

I made a PR, but can't push it for some reason. Also I can migrate the project to Bootstrap 4 if you'd like.

One topic per thread pls. :) does that help?
https://damienbod.com/2016/11/25/contributing-to-oss-projects-on-github-using-fork-and-upstreams/

That does help, and will post a new issue once I get this one sorted out :)

Great, thank you.


Carousel Fade Effect Bug

Describe the bug
I previously posted an issue on this, but was closed. I even made comments on it, to see if you guys could re open the issue. I thought that carousel component wasn't working correctly when using buttons on slides. Buttons would overlap each other when using carousel. Carousel does work correctly, the bug reproduces as following:
To Reproduce
Set Carousel with Fade Effect and place different buttons on different slides. You'll see the bug immediately.
Expected behavior
Buttons should not overlap and should be able to click.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Metro Version (Metro4 Version Official Page)

Additional context
I proposed a solution on the closed thread:
If addding "display: none" to the slides that are not shown, maybe that will solve the fade effect issue

Thank you, fixed in 4.4.0


MM-4160 Add Cloud System Roles (Beta)

Documentation for: https://github.com/mattermost/docs/pull/4160 via https://mattermost.atlassian.net/browse/MM-31514
Updated:

Cloud Admin Guide > Managing Members
New subsections added: About System Roles (Beta) & Assigning System Roles

Hello @cwarnermm,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

lgtm

lgtm


Default password doesn't work

Login: [user2016<EMAIL_ADDRESS>Password: qwerty

the default password doesnt work

Updated user credentials README.md


Create Fries Power Up

Fries appear around the player and steadily move towards them. If the player clicks the fries, they disappear, if the fries collide with Terry, the player instantly loses 10 exercise points.

Inherit from the base food class.

I added this


Migrating to Typescript

This means we are no longer coding in raw JS.

Will make this an isomorphic typescript-demo-iso.
But this means that for typescript-demo-spa this only requires the frontend code and therefore this would be needed:
  plugins: [
    new webpack.EnvironmentPlugin([
      'HOST',
      'PORT'
    ]),
    new HtmlWebpackPlugin({
      template: '!!ejs-compiled-loader!src/index.ejs',
      inject: 'body',
      xhtml: true,
      filename: 'index.html',
      templateParameters: {
        title: 'TypeScript Demo',
        configJs: `
          window.config = {
            HOST: '${process.env.HOST}',
            PORT: '${process.env.PORT}'
          };
        `
      }
    })
  ],

  plugins: [
    new webpack.EnvironmentPlugin([
      'HOST',
      'PORT'
    ]),
    new HtmlWebpackPlugin({
      template: '!!ejs-compiled-loader!src/index.ejs',
      inject: 'body',
      xhtml: true,
      filename: 'index.html',
      templateParameters: {
        title: 'TypeScript Demo',
        configJs: `
          window.config = {
            HOST: '${process.env.HOST}',
            PORT: '${process.env.PORT}'
          };
        `
      }
    })
  ],

This means 3 separate repos:

typescript-demo-iso - uses nodemon as a server - outputs a server.js, client.js and a bin script to execute the web server
typescript-demo-spa - uses dev server - only outputs public assets to be embedded in some other web server
typescript-demo-lib - no dev server at all - needs to compile into es6 module for tree shaking capability or UMD

I'm assigning this to you @robert-cronin to get merged. I sort of forgot about this PR for a bit, but now that you're fully using TS, you should know what to do to get this merged.

Typescript-Demo-Lib is now implemented with full typescript support.

Nice! Just need the README to be cleaned up that's all.

Nice! Just need the README to be cleaned up that's all.

Not sure what you mean, I updated the README to a generic one just after my initial commit.
Or do you mean something specific about the new README in Typescript-Demo-Lib ?

Yea the README in Typescript-Demo-Lib.

I've left some stubs in there for example, did you want me to take them out?

Well I'd like the stubs to turn into proper instructions similar to Haskell-Demo.

Oh gotcha, I will add some reasonable instructions :+1:


[Core] Print error type information

Description

This PR aims to print error type information when an error occurs.
> vm create -g fy -n vm1 --image centos --nsg-rule NONE --admin-user asdf --admin-password as
The password length must be between 12 and 72

Users don't know where the error happens. Is it in client or service? Azure CLI has an error type system. We could leverage it to tell users more useful information. Some error handlers have given good examples like JMESPathTypeError, ValidationError. An reference of all error types in Azure CLI chould be created in Azure CLI official web pages.
[Option 1] Print type name.
> vm create -g fy -n vm1 --image centos --nsg-rule NONE --admin-user asdf --admin-password as
CLIError: The password length must be between 12 and 72

[Option 2] Print type description.
> vm create -g fy -n vm1 --image centos --nsg-rule NONE --admin-user asdf --admin-password as
An error occurs during normal operation of the CLI. Typically due to user error and can be resolved by the user.
The password length must be between 12 and 72

[Option 3] A combination of option 1 and 2. Print both.
Which one do you think is better?
Testing Guide

Try any command that can trigger an error.
History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

Print error type

I think this requires a team meeting.

hi @qwordy any update on this PR? thanks

hi @qwordy any update on this PR? thanks

Thank you for reminding


Update the JavaScript Engine Switcher to version 3.0.0

Yesterday I released a final version of the JavaScript Engine Switcher 3.0.0. This PR contains a simple upgrade of the JavaScript Engine Switcher's packages, and removing unnecessary dependency (System.Runtime.InteropServices.RuntimeInformation) from the React.Sample.Mvc4 project.

Looks like the AppVeyor broke down due to a NU5125 warning. This warning must either be ignored or fixed by replacing in csproj-project files the PackageLicenseUrl elements by the PackageLicenseFile elements (about how to do it described in the “NuGet Error NU5030” article).

AdvancedStringBuilder is such a small NuGet package, can its contents be copied straight into JavaScriptEngineSwitcher.Core? If it needs to be separate that is fine, just wondering if we can save a bit of overhead copying around additional dependency DLLs.
(I fixed the Appveyor build)

Hello, Dustin!
I specifically extracted this library from the source code of my projects (Bundle Transformer, JavaScript Engine Switcher, MSIE JavaScript Engine, LibSass Host and WebMarkupMin (will use in the next release)) so that they can share the pool of string builders. Microsoft.Extensions.ObjectPool and old versions of the System.Buffers also small libraries, but it does not prevent to use them as dependencies in a large number of projects.
In addition, I plan to further develop this library by adding new extensions for the string builder.

Seems reasonable to me, although I don't know that we'll see a measurable difference when executing Javascript server-side when using pooled string builders vs something simpler like ThreadLocal<StringBuilder>.


rm unused SIDECAR_UID metadata key

kind of cleanup

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard-master
78c10941eda0c6067406244dd53e3b45d146ba67
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-dashboard-master
78c10941eda0c6067406244dd53e3b45d146ba67
link
/test e2e-dashboard-master

integ-new-install-k8s-presubmit-tests-master
78c10941eda0c6067406244dd53e3b45d146ba67
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard-master


Add a quiz app in javascript

Is your feature request related to a problem? Please describe.
Would like to add a quiz app in javascript. Please Assign this task to me under GSSOC'22.
Features:

user understandable UI
sound effects
animations
score storage

Steps Followed✅

[X] Is your feature request related to a problem? Please describe.
[X] Describe the solution you'd like
[X] Describe alternatives you've considered
[X] Additional context

Code of Conduct✅

[X] I agree to follow this project's Code of Conduct.
[X] I checked the current issues for duplicate problems.
[x] I have gone through project README.

Already exists.


vscode: improve desktop file handling

Description of changes

vscode: use copyDesktopItems hook instead of manually copying
vscode: remove folder and text mimetype associations

See https://github.com/microsoft/vscode/pull/209510

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

vscode seems to hang during the tests, but that appears to be the case even on master as well.

Ran vscode and checked the desktop files.


Update env_logger.

@bors-servo r+

:pushpin: Commit a8e5bd0 has been approved by emilio

:hourglass: Testing commit a8e5bd0 with merge f103d8a...

:sunny: Test successful - status-travis


Added additional language to the About page per issue #183

I used most of the language suggested in this issue but added a few lines I came up with during the Code for DC meetup.

Thanks, Will! I think the history and growth section is something we should all talk about next time. And we'll probably need to loop this all into ongoing work on the ui/ux.

Thanks.  Less is more, I say.


Create notification service to wrap toastr.  Also configure toastr in the service like no duplicates.

Reopened as need to eliminate dups


[Feature Request] Option to disable the number indicators (Find Duplicates)

I appreciate the recent addition of the number indicator feature, but I would personally like it disabled, so an option to disable it would be great. Thanks

Yeah all good, there's no rush :)

When you do, can you add an option to not show the 1s but only when there ARE suplicates


Problems running d-in-d, was: Busybox image is not being pulled

Which means that if you dont already have busybox then all releases until now will have failed 8(
it also explains why the screenshots in the integration tests were showing that proxies/services had not been created

on further investigation the image is being pulled, but there still seems to be some problems running docker-in-docker

turns out the issue was the check for whether image was already there was wrong 8(


Error while Installing node-sqlite3 with Node 14

I am using node-sqlite3 version 5.0.2 in my project. I need to build my project for cross-platform so when I am building my project on Windows for Linux platform I am using following command,
./node_modules/.bin/node-pre-gyp install --directory=./node_modules/sqlite3 --target_platform=linux--target_arch=x64 --target=14.0.0
then I am getting the following error,
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using<EMAIL_ADDRESS>node-pre-gyp info using<EMAIL_ADDRESS>| win32 | x64
node-pre-gyp info chdir ./node_modules/sqlite3
node-pre-gyp WARN Using request for node-pre-gyp https download
node-pre-gyp ERR! install error
node-pre-gyp ERR! stack Error: Unsupported target version: 14.0.0
node-pre-gyp ERR! stack     at get_runtime_abi (D:\project\node_modules\node-pre-gyp\lib\util\versioning.js:173:23)

Sounds like an issue with node-pre-gyp, not sqlite3.

Sounds like an issue with node-pre-gyp, not sqlite3.

Thanks for pointing that out but could you please elaborate on how to solve the issue
Also, there seems to a high severity vulnerability with node-pre-gyp and is an active issue on the repo as well

Try downgrading NodeJS version to before 14, or upgrading to 15 or 16.
Or, try updating node-pre-gyp.

Try this This worked for me yarn config set python your-python3-path-here` . It worked for me but I am on Ubuntu 21.10 @vikrant0526

Would you be able to try with sqlite3 v5.0.3? 🙂