[Doc Improvement][Communication flow for Teams bot apps][2771781]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
84
34
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
88
28
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
87
29
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
91
23
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
90
24
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
92
65
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
10
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
92
65
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
89
42
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
94
22
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
93
21
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
93
21
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
91
69
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
89
80
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
89
80
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
99
11
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
92
22
link
:white_check_mark:

msteams-platform/teams-faq.md
89
80
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
98
19
link
:white_check_mark:

msteams-platform/bots/communication-flow.md
90
24
link
:white_check_mark:

msteams-platform/teams-faq.md
90
80
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/901 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit cf3dc96:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-06-10-06-02-24 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


User not destroyed on Player leave

A UserService with a Listener should be created to destroy User instances when their attached Player leaves.

Obliterated :). 0032f4a6345c8913bc55cefcb1247ae275242e05


2nd Brain Cache Not Clearing

made attempt on https://github.com/stakwork/sphinx-mac/tree/jc/fix/clear-2ndBrain-cache and ran experiment with @kevkevinpal to no avail.

I think @tomastiminskas may have found a way to do this that has been shipping for a little bit. Can you comment @kevkevinpal ?

@jimBeaux27 @kevkevinpal Actually I did a change that I'm almost sure would fix it as Jim said. But never found a way to test it on my side


Repeat assignments to same scene variable make rendered graphic upside down

This is a weird bug, and I can't figure out why it is happening. If I want to loop over a few brain areas and create videos from each one, in theory I should be able to do this:
from BrainRender.scene import Scene
from BrainRender.Utils.videomaker import VideoMaker

regions = ['PRT', 'SCm', 'SCs']
for region in regions:
    scene = Scene()
    scene.add_brain_regions([region], colors='white', alpha=0.5)
    vm = VideoMaker(scene, savefile=f"Output/Videos/{region}.mp4", niters=120)
    vm.make_video(azimuth=3)

Indeed, this does create videos of these brain regions. However the second and third (and further videos if there are more regions) are rendered as upside down. I thought perhaps there is an object inside one of the imported files that is being manipulated at some point, but this wouldn't explain the observation that this script does work:
from BrainRender.scene import Scene
from BrainRender.Utils.videomaker import VideoMaker

scene1 = Scene()
scene1.add_brain_regions(['PRT'], colors='white', alpha=0.5)
vm1 = VideoMaker(scene1, savefile=f"Output/Videos/PRT.mp4", niters=120)
vm1.make_video(azimuth=3)

scene2 = Scene()
scene2.add_brain_regions(['SCm'], colors='white', alpha=0.5)
vm2 = VideoMaker(scene1, savefile=f"Output/Videos/SCm.mp4", niters=120)
vm2.make_video(azimuth=3)

scene3 = Scene()
scene3.add_brain_regions(['SCs'], colors='white', alpha=0.5)
vm3 = VideoMaker(scene1, savefile=f"Output/Videos/SCs.mp4", niters=120)
vm3.make_video(azimuth=3)

Ain't that weird? Are these two scripts not functionally equivalent?   I'll see if I can replicate it and what the cause might be..

On my Mac, the first of the two examples has the same behaviour you described, the second yields an error:
No duration was passed, using default: 5
📽  Video PRT.mp4 is open...
Recalculated video FPS to 24.0
💾 Video saved as PRT.mp4
Could not retrieve data, possibly because there is no internet connection.
Rendering: (SCm)
No fps was passed, using default: 30
No duration was passed, using default: 5
📽  Video SCm.mp4 is open...
Traceback (most recent call last):
  File "/Users/federicoclaudi/Documents/Github/BrainRender/User/test.py", line 27, in <module>
    vm2.make_video(azimuth=3)
  File "./BrainRender/Utils/videomaker.py", line 76, in make_video
  File "/Users/federicoclaudi/miniconda3/envs/brainrender/lib/python3.7/site-packages/vtkplotter/plotter.py", line 1499, in show
    addons.addAxes()
  File "/Users/federicoclaudi/miniconda3/envs/brainrender/lib/python3.7/site-packages/vtkplotter/addons.py", line 776, in addAxes
    r = vp.renderers.index(vp.renderer)
ValueError: None is not in list

This second error seems to be a vtkplotter problem rather than brain render. But it means that something different must be happening between the two experiments, I have no idea what though.
In general the video feature could really do with some improvements. It's not very flexible or accurate at all currently.

Could the Could not retrieve data, possibly because there is no internet connection error be indicating that the data is empty, thereby causing the resultant ValueError: None is not in list error?

No that shouldn't be the cause. I can run the 4 videos with the loop, and with an internet connection I get the same error.
The problem seems to be that in your example code when you call VideoMaker the second time you pass it scene1 as argument:
vm2 = VideoMaker(scene1, savefile=f"Output/Videos/SCm.mp4", niters=120)
Using scene2 the error doesn't  come up anymore and the behaviour is the same as in the loop.
I will look into this.

This should've been fixed with: 02b72aebd76ee237ffa8c95ab61e03f5efdb6d2d
The problem seem to be with vtkplotter, once an instance of the plotter has been created, actors are upside down for the following plotters (even if these should be completely independent objects).
The quick and dirty solution is to check if the current scene's plotter is not the first being created, and then rotate the actors accordingly:

But this might be very slow for scenes with complicated renderings (e.g. streamlines or morphologies).
I will get in touch with Marco Musy from vtkplotter to see if he has any advice.

 Pretty strange behaviour on vtkplotter's part, that deleting an instance doesn't propagate to its internal copies, though there could be a good reason for this.
The workaround seems fine.
On 191211 03:07, Federico Claudi wrote:

This should've been fixed with: 02b72aebd76ee237ffa8c95ab61e03f5efdb6d2d
The problem seem to be with vtkplotter, once an instance of the plotter has been created, actors are upside down for the following plotters (even if these should be completely independent objects).
The quick and dirty solution is to check if the current scene's plotter is not the first being created, and then rotate the actors accordingly:

But this might be very slow for scenes with complicated renderings (e.g. streamlines or morphologies).
I will get in touch with Marco Musy from vtkplotter to see if he has any advice.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/BrancoLab/BrainRender/issues/18#issuecomment-564773894

Hi,
interesting... one possibility is that by simply creating a new Plotter instance is not clearing the internal list of created objects, which is a global variable, and that's what's picked up by subsequent scenes.
What happens if you close the scene with Scene.closePlotter()?

Hi,
I've tried doing scene.plotter.Close() and scene.plotter.closeWindow() as well as del scene.plotter and removing the plotter instance from the global variable holding all plotters instances, but non of these changed the behaviour.

Oh that's pretty weird.. I'll try and see if I can reproduce the issue with the Plotter class.

Hi Federico, you might try to check if the problem is still there in the latest release (i guess it will..), plus there are a few deprecated methods which may get in the way..
Let me know if you encounter any problems

Hi Marco,
I've update vtkplotter but the problem is still there. Running this minimal example reproduces the bug:
from brainrender.scene import Scene

regions = ['PRT', 'SCm', 'SCs']
for region in regions:
    scene = Scene()
    scene.add_brain_regions([region], colors='white', alpha=0.5)
    scene.render()

The only way to avoid this is to add to scene.render() this:
if len(vtkplotter.settings.plotter_instances) > 1:
    self._rotate_actors()

to rotate all actors in the scene if there are other plotter_instances.

I just pulled the git repo but I get this error message:
ModuleNotFoundError: No module named 'brainrender'
i guess it's some mismatch with capital letters in the module name..

mmm that's weird, it works for me.
I'll look into it, but in the meanwhile if you pip install brainrender you should be able to run the code above.

Hi Federico,
sorry for the delay in addressing this issue. I just tried the above code with the master version of brainrender (which now works from master) and I get this sequence of outputs:

So i'm not sure if the problem is still there or you managed to fixed it ..or if it's my local version of vtkplotter which now works ok..

Hi,
thanks for looking into this.
As far as I can tell vtkplotter is still inverting the actors for the second and third scene.
To correct for this, in brainrender I rotate the actors before rendering the scene. Within the
Scene.render() I check if other plotter instances exist, and if they do I rotate the actors (thus correcting the rotation due to vtkplotter:
if len(vtkplotter.settings.plotter_instances) > 1:
    self._rotate_actors()

As far as I am concerned this solution is okay for brainrender. It might slow rendering for complicated scenes, but I don't think that it's an issue that is going to come up frequently.
I thought I'd let you know anyways so that you can look into what in vtkplotter is causing this if you want to.
Cheers,
Federico


Append to MS MARCO replication log and fix spacy error

Description
Replicate the MS MARCO document retrieval results.
Issue Encountered
The spacy errors mentioned in #267. This PR suggests a fix for those issues.
Experiment Results Replication
The mrr's I got differ slightly in the 5th decimal place:
fh

The expected mrr is 0.38882, but got 0.3888.
sh

The expected mrr is 0.33617 but got 0.33614.
Environment
Python 3.7.13
GPU: Tesla P100 (Google Colab)
See the following Colab notebooks:

First half results
Second half results

Hi all, just bumping this PR, I think it is OK to merge. I was able to replicate the revised results exactly, using the new changes proposed in this revision. Feel free to add a replication entry on my behalf, I used a GeForce RTX 2080 Ti on a Ubuntu 21.10 machine. Thanks


feat(binder): update RecursiveUnion and related function(s)

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as commit message.
related: #15681.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

What will happen if we write a CTE with recursive keyword but not really have recursive reference? It seems that it's acceptable in pg.
dev=# with recursive t AS (select 1) select * from t;
 ?column?
----------
        1
(1 row)

dev=#
dev=# with recursive t AS (select 1 UNION ALL select 1) select * from t;
 ?column?
----------
        1
        1
(2 rows)

cc @xiangjinwu Can you give some ideas?

one solution might be - treat it as normal union iff we find the base and recursive parts are both constant (i.e., is_const return true); but will there be any other corner case?

treat it as normal union iff we find the base and recursive parts are both constant-like expr;

Currently, we’ll reject recursive union without a top-level UNION. I guess we can try bind it as non recursive CTE when met this.
For CTE with recursive definition but non-recursive body, may we can convert it as a normal UNION in logical planner?

cc @Dylan
Not necessary to resolve the case in the PR.

treat it as normal union iff we find the base and recursive parts are both constant-like expr;

Currently, we’ll reject recursive union without a top-level UNION. I guess we can try bind it as non recursive CTE when met this.
For CTE with recursive definition but non-recursive body, may we can convert it as a normal UNION in logical planner?

cc @dylan
Not necessary to resolve the case in the PR.

Yes, I think we can just bind it to a normal UNION operator when it is proved that it is not a recursive CTE.

What will happen if we write a CTE with recursive keyword but not really have recursive reference? It seems that it's acceptable in pg.
cc @xiangjinwu Can you give some ideas?

https://github.com/risingwavelabs/risingwave/pull/15522#discussion_r1524378771
If we know, at the binding phase, it is not recursive, we can just bind to a normal union (wrapped inside SetExpr and Query). As per my comment in that PR, the top level would be Either<BoundQuery, RecursiveUnion>.

If we know, at the binding phase, it is not recursive

I guess it’s a little hard for our binder to know this, since we don’t have visitor on binder structure?
Or we can just store a flag in context.

I guess it’s a little hard for our binder to know this, since we don’t have visitor on binder structure?

a somewhat "hacky" solution would be, (with recursive flag enabled) check if the pattern like select (...) from <cte_name> appears in the rhs (a.k.a. the recursive term) for our currently binding union - if so, treat this as a recursvie cte, vice versa.
problem is - this is definitely error-prone and add extra (potentially ugly) hard-coded checking when bind_with; and the semantic may not be exactly aligned with postgres's.

Or we can just store a flag in context.

could you elaborate on this approach? I don't quite get the idea.


Provide doctrine bridge

Maybe this is out of scope of this library but one thing that would be interesting is to be able to, from Doctrine ORM and its configuration, get the content of all the tables (the database, tables discovery and transformation into objects can be done via Doctrine) and generate fixture files from it.
So in other words, providing an out of the box support command generating all the fixture files from the database.

If I'm understanding correctly then this is actually already a feature of AliceGeneratorBundle. I suppose I could have written it into this library so it would be framework agnostic, it just would have been a bit more work, and would have made this library depend on the Symfony console component.

I'll have to give it a try then ;)


Expose PoolOptions in SharedPool

This is a PoC PR which fixes https://github.com/launchbadge/sqlx/issues/1853
The idea is to expose PoolOptions and ConnectionOptions after the pool has been created.
This would allow easy database deletion and modification without having to save the options used during creation for the whole duration of the program.

@abonander Sorry for the quite sloppy first state of the MR, I should have properly tested it in a fully integrated scenario from the very beginning.

@Nukesor might want to update the PR name and commit title to reflect the new actual changes.

I don't think this implementation fixes #1853 as they specifically wanted PoolOptions.

True. @Thomasdezeeuww should then easily be able to implement theire desired getters in a follow-up PR.
I didn't want to expose the getter without adding specific getters, but I guess it makes sense :)

@abonander For the record, even if it doesn't fix the original issue it meant to address, it's still very helpful for a case I have right now and would therefore appreciate to see it merged. :)

I changed it from fixes to related


Failed to install Helm Client with OpenSSL Error

Hi,
There's something issues in my CI Environment.
When I'm trying to download Helm Client, SSL Error occurs like this.
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to get.helm.sh:443
Failed to install helm with the arguments provided: --version v3.0.0
Accepted cli arguments are:
	[--help|-h ] ->> prints this help
	[--version|-v <desired_version>] . When not defined it fetches the latest release from GitHub
	e.g. --version v3.0.0 or -v canary
	[--no-sudo]  ->> install without sudo
	For support, go to https://github.com/helm/helm.

Exited with code exit status 35

Is there any issues about this?
Thanks.

@seeodm is ok  when  you retry?


CU 5704 New publisher in fct. InsertTransShptHeader

Hello,
we Need a new publisher in fct. InsertTransShptHeader() in CU 5704 as if you can see in the screenshot:

Thanks in advance,
best regards,
K.

Dear all,
i am sorry, we need the parameter TransHeader, too. Is it possible to integrated the Parameter, too?
Best regards,
K.


Added getBlockdDetails method [AKI-351]

Description
This change adds a new ops_getBlockDetails method which returns a blockdetails similar to the blockdetails found in the Java API.
Fixes Issue # AKI-351
Type of change

[ ] Bug fix.
[x] New feature.
[ ] Enhancement.
[ ] Unit test.
[ ] Breaking change (a fix or feature that causes existing functionality to not work as expected).
[ ] Requires documentation update.

Testing

deployed the build and synced to mainnet
executed requests using blocks that contained no transaction, one transaction and more than one transaction. Requests made:

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetails","params": [1]}'

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetails","params": {"block":6753}}'

curl <IP_ADDRESS>:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetails","params": [1174759]}'

added functional test cases to the dashboard ETL

Looks good.  One last thing -- can you also check that the following all give the same result?  Looking at the code, I think they do, but just want to see it work in real life ... if these are all equivalent, then let's merge it:
curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"jsonrpc":"2.0","method":"ops_getBlockDetails","params": [11]}'
curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"jsonrpc":"2.0","method":"ops_getBlockDetails","params": ["11"]}'
curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"jsonrpc":"2.0","method":"ops_getBlockDetails","params": ["0xb"]}'

The change was re-tested using the following requests and re-running the tests in the dashboard ETL code.
curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByNumber","params": {"block":"0x1"}}' | jq  -M

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByNumber","params": {"block": 1}}' | jq  -M

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByNumber","params": [1]}' | jq  -M

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByNumber","params": ["0x1"]}' | jq  -M

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByHash","params": [0x28375cc29c3ba1b76f36de5a486eac814b566f488c6c98a30dfea854f7f2671a]}' | jq  -M

curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"ops_getBlockDetailsByHash","params": {"block":0x28375cc29c3ba1b76f36de5a486eac814b566f488c6c98a30dfea854f7f2671a}}' | jq  -M


got nan during sampling

It's a good job, but I got pre_lig_pos NAN when I used the pretrained ckpt to sampling ligands. Could you please check the sampling code?

which py file or command did you use?  the scripts/sample_for_pocket.py has some error , not working.

which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.
I used this:
python sample_split.py --start_index 0 --end_index 99 --batch_size 25

which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.

Excuse me, can you use this code to generate normal molecules? I am currently conducting research in this area, but according to the author's read me and using the author's pre trained model, I have been encountering situations where molecular coordinates show NAN during the sampling process. May I ask how you sampled it? We look forward to your reply.

which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.

Excuse me, can you use this code to generate normal molecules? I am currently conducting research in this area, but according to the author's read me and using the author's pre trained model, I have been encountering situations where molecular coordinates show NAN during the sampling process. May I ask how you sampled it? We look forward to your reply.

Have you solved this problem? I also get nan for my generation using sample_split.py

which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.

Excuse me, can you use this code to generate normal molecules? I am currently conducting research in this area, but according to the author's read me and using the author's pre trained model, I have been encountering situations where molecular coordinates show NAN during the sampling process. May I ask how you sampled it? We look forward to your reply.

Thanks for your interests in our work. For your problem:

Check if the paths in the training.yaml and sampling.yaml files within the config directory are correctly configured, including the dataset and pretrained models.
Verify that the packages in the environment, especially the versions of pyg and torch-geometric, are right.
You can also refer to this issue https://github.com/YangLing0818/IPDiff/issues/2#issue-2255866576

which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.

Excuse me, can you use this code to generate normal molecules? I am currently conducting research in this area, but according to the author's read me and using the author's pre trained model, I have been encountering situations where molecular coordinates show NAN during the sampling process. May I ask how you sampled it? We look forward to your reply.

Thanks for your interests in our work. For your problem:

Check if the paths in the training.yaml and sampling.yaml files within the config directory are correctly configured, including the dataset and pretrained models.
Verify that the packages in the environment, especially the versions of pyg and torch-geometric, are right.
You can also refer to this issue Request for Model Checkpoints or configuration #2 (comment)

Thanks for your reply! Can I ask how much GPU memory you were using for sampling the ligands? I encountered RuntimeError: CUDA out of memory on my RTX 4070s even with 1 as batch size, I'll look for better GPU resources but just curious about what GPU you are using for batch_size = 25.

Thanks for your reply. I have solved the problem by rebuilding the virtual environment.

@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "YangLing0818/IPDiff"                                                                                @.>;
发送时间: 2024年10月14日(星期一) 上午9:24
@.>;
抄送: "<EMAIL_ADDRESS>主题: Re: [YangLing0818/IPDiff] got nan during sampling (Issue #4)
which py file or command did you use? the scripts/sample_for_pocket.py has some error , not working.
Excuse me, can you use this code to generate normal molecules? I am currently conducting research in this area, but according to the author's read me and using the author's pre trained model, I have been encountering situations where molecular coordinates show NAN during the sampling process. May I ask how you sampled it? We look forward to your reply.
Thanks for your interests in our work. For your problem:
Check if the paths in the training.yaml and sampling.yaml files within the config directory are correctly configured, including the dataset and pretrained models.
Verify that the packages in the environment, especially the versions of pyg and torch-geometric, are right.
You can also refer to this issue Request for Model Checkpoints or configuration #2 (comment)
Thanks for your reply! Can I ask how much GPU memory you were using for sampling the ligands? I encountered RuntimeError: CUDA out of memory on my RTX 4070s even with 1 as batch size, I'll look for better GPU resources but just curious about what GPU you are using for batch_size = 25.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Template Haskell and C++ dynamic linking issues on Windows

Template Haskell has issues with C++ on Windows, since it uses its own linker. Problem reveals when flaw-font is in use (as it links freetype and harfbuzz). I used 'all.dll trick' as a workaround (needs to be documented), but even that suddenly stopped working with flaw-ui-default-style package (which uses flaw-build to embed a font). Need to sort it out.

Unable to build on Appveyor because of that :(
https://ci.appveyor.com/project/quyse/flaw

Work-arounded in a6286a4e41cdcd03fed9d8da377b0404161b17ca. Appveyor CI now works.


RTK Planner

Hi,
How can I know more about RTK planner and EM planner? Any document or paper or ...
Thanks in advance

RTK planner is just a waypoint following. It will follow pre-recorded points.
EM planner: you can check the paper publication here https://arxiv.org/pdf/1807.08048.pdf
Good luck

We will close the issue for now. If you have any additional question, please feel free to open a new issue.


Review usage of HKDF

Problem
It seems that ethereum-cryptography/pbkdf2does not use the subtle crypto API: https://github.com/status-im/status-web/pull/295/files
While we do not use ethereum-cryptography, we do use the noble libraries for cryptography, by the same author and we do some KDF operation: https://github.com/waku-org/js-waku/blob/b33306655a0b6da4b294bef37f0131afda4fb476/packages/message-encryption/src/crypto/ecies.ts#L8
We need to check whether we could use a crypto subtle API for KDF operations to improve performance over a pure JavaScript implementation.
Acceptance Criteria

[x] Review if we use pbkdf2
[ ] ~Push patch above upstream if needed~
[ ] Review our usage of KDF and whether subtle crypto could be used

Mark as good first issue as it does not require much knowledge of the codebase. It is an advance issue in terms of subject matter (cryptography).

Hey @fryorcraken I can take this issue and close it out for you if you wish.

Hey @fryorcraken I can take this issue and close it out for you if you wish.

🙏 any help is appreciated.
First step would be an analytical one to review KDF usage. Two questions to answer:

do we use kdf from noble libraries?
could our hand written kdf function be replaced with subtle crypto kdf?

Note that the test suite run test against another implementation, including asymmetric encryption (where ecies is used to derive an encryption key).
So one could replace the kdf code with a subtle crypto call and see if tests still pass.
Best if I can review the analysis before moving forward with a patch.
Let me know if you need more guidance.

@fryorcraken Hey looking for a little guidance on this one. I sent you a message on Discord!

I tried to play around to replace our kdf function (link in description) with CryptoSubtle's API:
export function hkdf(
  secret: Uint8Array,
  outputLength: number
): Promise<Uint8Array> {
  return getSubtle()
    .importKey("raw", secret, "HKDF", false, ["deriveKey"])
    .then((cryptoKey) =>
      getSubtle().deriveKey(
        {
          name: "HKDF",
          hash: "SHA-256",
          salt: secret,
          info: new Uint8Array(),
        },
        cryptoKey,
        { name: "AES-CTR", length: outputLength * 8 },
        true,
        ["encrypt", "decrypt"] // TODO: make usage an option
      )
    )
    .then((crytoKey) => getSubtle().exportKey("raw", crytoKey))
    .then((bytes) => new Uint8Array(bytes));
}

The first step was trying to have the function above produce the same output than the old function. Here is a test:
describe("HKDF", function () {
  it("HKDF", async function () {
    await fc.assert(
      fc.asyncProperty(fc.uint8Array({ minLength: 1 }), async (secret) => {
        const oldOutput = await kdf(secret, 32);
        const newOutput = await hkdf(secret, 32);
        console.log(`old [${oldOutput.length}]`, oldOutput.toString());
        console.log(`new [${newOutput.length}]`, newOutput.toString());
        expect(newOutput.length).to.eq(oldOutput.length);
        expect(newOutput.toString()).to.eq(oldOutput.toString());
      })
    );
  });
});

Unfortunately to no avail. The KDF function comes from go-ethereum due to Whisper 1:https://github.com/ethereum/go-ethereum/blob/cd31f2dee2843776e485769ce85e0524716199bc/crypto/ecies/ecies.go#L146
Not sure if it's possible to get Subtle Crypto to do the same KDF algorithm.
The benefit of tackling this would be performance gain and browser API is likely to execute faster than JavaScript runtime.
Also a security benefit if we can the whole stack to use Subtle Crypto so that the user can use subtle crypto to generate and manage keys instead of byte arrays as described here: https://github.com/waku-org/js-waku/issues/984
Happy to do a bounty on this issue to either:

Prove it's not possible to use CryptoSubtle
Replace KDF to use CryptoSubtle (must remain compatible with Waku Message Version 1 standard
Enable usage of CryptoKeys on the API.


For 2019.03.00_base_model, extra-mcmc/reports/ has different number of files than last year

Just curious (and want to confirm if we have more than 2000 MCMC samples).
2018 base model extra-mcmc/reports had Report_1.sso to Report_2000.sso  (and similarly for other files)
2019.03.00_base_model:      has  Report_1.sso to Report_2199.sso   .
Aha -  num.mcmc.samples is now 2199.
Am thinking it's to do with Aaron changing the starter/control file or whatever? Anyway, presume it's fine to have 2199 samples (means the thinning was slightly different, or the burn-in is not what we say in the readme file). Just have to figure out exactly what was done.
Just mentioning so it gets clarified.

Darn.  So it appears that I changed the starter file to "400 # MCeval burn interval" and "1 # MCeval thin interval" in the MCMC folder but the starter file in the model folder itself was left at 201 and 1, respectively.  Apparently when running -mceval it looks to the main model folder starter for these parameters (not mcmc folder starter file).
Here are my fixes given that we will want to stay consistent with our burn in period (and not halve it like I did):

re run mceval (quick)
re upload mcmc model files for 2019.03.00_base
unfortunately we will have to rebuild the base model RData file, redoing forecasts and extra mcmc :(
So I'll rerun build(T,F,F,"2019.03.00_Base") -

I mean build(T,F,T,"2019.03.00_base") b/c want to rebuild extra-mcmc for base only

Okay, the new mcmc files are uploaded to the google drive and I am rebuilding my RData file for 2019.03.00_base using build(T,F,T,"2019.03.00_base").  This will take an hour or two.
Check box when you've downloaded the new base model mcmc folder and rebuilt your RData file with the correct (or our standard) number of MCMC samples .
Download new mcmc folder from google drive:

[ ] Aaron
[ ] Kelli
[ ] Chris
[ ] Andy

Rebuild RData file for base model:

[ ] Aaron
[ ] Kelli
[ ] Chris
[ ] Andy

@aaronmberger I have rebuilt all RData files ... can you click the box for me?

@cgrandin I contacted github and they said that I cannot click because I don't have contribution rights to the repository ... can you add me?

Ahhh. Ok I added you as a collaborator. Sorry I didn't do that sooner.

No worries, I can click now!

Why make lists if you can't check things off - where's the satisfaction?  Glad it's resolved...

My build didn't work (the extra-mcmc folder was locked and didn't get overwritten). Fixed and re-running....


Only use the l10n fallback bundle when normal ftl-file fetching failed (issue 18264)

/botio test

/botio-linux preview

I have confirmed locally that this indeed fixes the logs if dumpio: true is enabled. Great; thank you!


Adding jQuery 3.6.2 to the CDN

@ChrisSfanos  please resolve.

@ChrisSfanos  check my commit to resolve the merge conflict.


Created graph_of_cities_using_map.cpp

Description of Change

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

Seems to be a duplicate of #1131.
If it's not, please tell me, and I'll re-open it.


Enable Python Tests on Linux CI and Add a Nightly Pipeline

This pull-request:

enables the python tests on linux x64 cpu and gpu pipelines.
adds a new pipeline that runs phi-2 end to end by first downloading the model using the model builder and then running the model using onnxruntime-genai. This pipeline runs on linux x64 cpu.

Missing pieces in this pull-request:

Cuda tests are not enabled yet. This is because of errors with cuda 11.8 and onnxruntime_genai.
linux arm64 python tests are not enabled. There were problems trying to get that running with uninstalled dependencies such as cython and numpy.

Thank you for the review. :)


Support toNonIndexed() method in geometries

Is your feature request related to a problem? Please describe.
Currently, the toNonIndexed method
doesn't work
Describe the solution you'd like
I would like to manipulate the vertex by nonIndexed geometries
Suggested solution
add a new prop to all geometries
Ej:

Additional context
This is useful is you want to manipulate the vertex individually, in the vertex shader

@JaimeTorrealba should this be optional or mandator? And couldn't this method be called using templateRefs?

As we discuss methods inline like
const lineGeometry = new BufferGeometry().setFromPoints(points) will not work on the template
<TresBufferGeometry :set-from-points="points" /> // this doesn't work
So we have to create on the script tag. Which is not ideal


Muzei Settings don't open

It works on my apps based on older versions of Wallpaperboard. I can't make it work on the latest version now. I am not really sure if I've done something wrong or it's a bug.

https://github.com/danimahardhika/wallpaperboard/wiki/Setup#open-androidmanifestxml

yeah it was my fault. ;-;

yeah it was my fault. ;-;


Adding nova-config tag to enable simple updates to config (e.g. changing CPU/RAM allocation ratios)

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test


Clean: Optional markdown style.

Optional markdown style configuration.
Stripped trailing spaces.
Added: using Lexicon to Example to make it selfcontained.
Incooperated the changes suggested by: MichaelHatherly
closed by mistake: #41

Thanks @peter1000.


checkRestrictions() ... related to checkConditions?

There is an empty method in the core Agent class, checkRestrictions, which seems to be there to impose or test constraints on the model parameters:
https://github.com/econ-ark/HARK/blob/b1b14ad1539495e11d483f54bedf5f569d3885ce/HARK/core.py#L411
It's only used in one place in the HARK library, in the PerfForesightConsumerType:
https://github.com/econ-ark/HARK/blob/3d3dbfea9f2192213ece38ca6912ed249336e392/HARK/ConsumptionSaving/ConsIndShockModel.py#L1655
My impression is that checkRestrictions may be intended to do work similar to checkConditions, and that the two methods could be merged into one.
Does that sound right?

Maybe a difference between checkRestrictions and checkConditions is that the former raises an Exception, whereas the latter currently prints warnings.
checkRestrictions is not called from anywhere in the code, however, so the test has to be done manually and the Exception is not going to stop anything from running.

I was mistaken--there is a call to checkRestrictions() in preSolve()
https://github.com/econ-ark/HARK/blob/master/HARK/core.py#L430
This makes it look like the intent of checkRestrictions is very much what's intended by checkConditions. See #283
@llorracc is it possible that this functionality needs to be merged together?

From what @mnwhite just said (elsewhere), it sounds like checkRestrictions is more about making sure various ingredients are of the right type (e.g., lists, etc).  The code won't work, probably, if they are the wrong type.  checkConditions is more about informing the user about various theoretical characteristics of the model that can be proven to hold true under various configurations of parameter values (like 'a target asset ratio exists').
However, the names of the two methods are sufficiently similar that there is the potential for them to be confused with each other.  Perhaps we should change one of the names.

Hmm, it looks like what I thought was in checkRestrictions is actually not;
I was thinking of checkMarkovInputs in MarkovConsumerType.  Is this method
actually meaningfully defined anywhere?
On Tue, Mar 17, 2020 at 4:06 PM Christopher Llorracc Carroll <
<EMAIL_ADDRESS>wrote:

From what @mnwhite https://github.com/mnwhite just said (elsewhere), it
sounds like checkRestrictions is more about making sure various ingredients
are of the right type (e.g., lists, etc). The code won't work, probably, if
they are the wrong type. checkConditions is more about informing the user
about various theoretical characteristics of the model that can be proven
to hold true under various configurations of parameter values (like 'a
target asset ratio exists').
However, the names of the two methods are sufficiently similar that there
is the potential for them to be confused with each other. Perhaps we should
change one of the names.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/574#issuecomment-600272072, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFIUFUD6ZZSSGIIG243RH7J4FANCNFSM4LMVWYEA
.

The one place that it is not an empty method, it:

tests for whether DiscFac < 0
if so, it fires an Exception

https://github.com/econ-ark/HARK/blob/3d3dbfea9f2192213ece38ca6912ed249336e392/HARK/ConsumptionSaving/ConsIndShockModel.py#L1659
It looks like it was written by @pkofod about 9 months ago.

For 0.10.9 release!

For 0.10.9 release!

Taking another look at this...
This seems connected to the ambiguity around what preSolve is supposed to be doing. See #576
These should be handled together.
As we get more clarity into how model parameters are being set, we may want to allow users to stipulate restrictions on other parameters as well.
These would need to be written as equations or functions, not hard-coded.
Punting this to 1.1

OK.  A case could be made for "restrictions" being circumstances under which the user has fed the code parameter values for which there is guaranteed to be no sensible solution, while "conditions" would be circumstances under which there is (or might be) a solution, but we know something interesting about it.  On the whole, I think it is probably better just to leave everything in checkConditions, but could perhaps be persuaded to change my mind.

"checkConditions" -- conditions for what?
"checkRestrictions" -- restrictions for what?
I think it would be best to be precise about the functional or theoretical implications of these conditions, and organize them that way.

I'm closing this because both of these methods have been significantly changed since this issue was last discussed. I've tagged it as 1.0 because parameter restrictions are being incorporated as part of that roadmap. I believe the Parameters class also already supports this.


staged.dependencies::install_deps() - lack of message to the user

We find out that staged.dependencies::install_deps() is quite time consuming although the problem is lack of interaction with the user. Especially as the are not action on the screen for a long time.

I believe there's a verbose argument to intall_deps which should tell you what's going on?

Then it should not be deactivated on default.


"no match found" in search query of mentors page

Related Issue

Closes: #[issue number]
Description of Changes

Checklist:

[ ] My code adheres to the established style guidelines of this project.
[ ] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[ ] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Original
Updated

Please provide any necessary screenshots to illustrate the changes made.

cool


GDW1 - Rebased version of Logging

Description
This PR adds logging capability. There is now a global flag --log-loc which will set the location of the log on this run. Otherwise it will go to /tmp. The flag should point to a directory. At the moment this needs code review
Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[x] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Codecov Report

Merging #38 (efaf822) into main (96cbcec) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   30.26%   30.26%
=======================================
  Files          23       23
  Lines        3000     3000
=======================================
  Hits          908      908
  Misses       2023     2023
  Partials       69       69

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix update presence to use the time returned from the server

Found that the original fix for #3 reverted here stopped working after keeping a bot online for > 24 hours (I would see bot showing offline then online again)
Tried this way of starting a new presence update task anytime we get a presence update response
Tried over the long weekend and the bot is still staying online after over 72 hours without it showing the bot going offline

Thanks for the PR. I made some changes to your patch https://github.com/alaingilbert/ttapi/commit/cf185928903e9bb4bf2b4dc3caede3b6511b5614
Let me know if you see anything wrong in my fix.

Thanks for the PR. I made some changes to your patch cf18592
Let me know if you see anything wrong in my fix.

Yeah, I actually had it like that originally but thought it would be fine just to be a bool.  I am fine keeping it with the atomic to make sure it is thread safe, can we just switch the defer atomic.StoreInt32(&b.presenceTaskStarted, 0) to not deferring the call and calling that line right before calling _ = b.updatePresence()?  I noticed when I had it deferred like that there was a race condition where sometimes it would not update the int32 quick enough so a presence update response would come in and another task would not start because it thought it was already ongoing.


[BUG] show warnings cant use limit

What happened:
when exec show warnings limit 0, 1 will get  fault

What you expected to happen:
can normal execute show warnings limit 0, 1
How to reproduce it (as minimally and precisely as possible):
execute show warnings limit 0, 1
Anything else we need to know?:
this fault info from parser func

parser.y in parser does not define limit in show warning statement


Post feature flag api

Description
Created the POST and GET of the featureFlags. Used MongoDB instead of DynamobDB as of now.
Fixes #18
#4
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[X] POSTMAN
[X] Local browser

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Done


Multiple cursors in ACE no longer work (only last one inserts)

Maksym saw this when he was using the multiple cursor feature. Given how few people use that, it's not a high priority, but it would be interesting to either fix it or turn that off.

I had it working now; not sure what changed.


Error TS2339: Property 'userId' does not exist on type 'Request<ParamsDictionary, any, any, ParsedQs>'?

I'm trying to override an Express Request type. It seems everything is going well until you start the server that gives the error: Error TS2339: Property 'userId' does not exist on type 'Request<ParamsDictionary, any, any, ParsedQs>'. I don't know why this is happening. I'm using the lastest version of ts-node-devm.

Help me?? Thanks.

Try to see this #169

I wore @types/express.d.ts before, but now it's working with @types/express/index.d.ts so works fine now.


How can i show a dialog over all window?

How can i show a dialog over all window because i need to give user some reminders when they doing other things in other app？
I tried compose Dialog  but i find it will not show on the top.

I find i can use window with alwaysOnTop enable to solve this, and i suggest add this param to Dialog.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Brinsford christmas visit slots

Amending all 1330-1600 slots to 1330-1615
Unbookable - Christmas Day, Boxing Day, 28th Dec
Additional slot 30th Dec 1330-1615

@EGiataganas please test locally


Block Explorer proposals page Closing and Enactment date columns differ in date time formatting

Currently the formatting for date time in Closing and Enactment columns in the Governance proposals page is different. These should probably both use the formatting from the Closing column

https://github.com/vegaprotocol/frontend-monorepo/blob/develop/libs/proposals/src/components/proposals-list/use-column-defs.tsx#L114-L137
🤔


Bad exit code on config parsing error

Hey, I'm using skaffold on the CI. Skaffold version got updated, config file format changed so deployment failed but reported as the success.
$ skaffold run -f skaffold.yaml ; echo ExitCode: $?
ERRO[0000] run: parsing skaffold config: yaml: unmarshal errors:
  line 12: cannot unmarshal !!map into string
ExitCode: 0

Expected behavior
ExitCode should be non-0
Actual behavior
ExitCode is 0
Information
Skaffold version: v0.3.0
Operating system: Mac/Linux

Hey @Trane9991!
Check out the note in the CHANGELOG around breaking config changes:
https://github.com/GoogleCloudPlatform/skaffold/blob/v0.3.0/CHANGELOG.md#v030-release---3292018
In the near term future there will be a command that fixes these things automatically, currently that functionality is in #291.

Thanks for using this already! We should absolutely return a real exit code on breaks


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.13.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Error with cs430: programming-languages in local.yaml

the line in local.yaml that specifies the programming languages role throws the error in the picture below. I believe this is due to the local.yaml file refering to the cs430 role name as programming-languages when the folder for the role is named programming-langs.

Thanks for reporting this! Working on it now!

Do you mind testing the branch in the above PR just to be sure that everything runs (you don't need to install the 430 content if you don't want to)?


Execution paused by Comment keyword which content start with '#'

Test:

Execution Paused:

robot version: 3.1
python version: 3.7.1
os: windows 10

Does this happen also without RIDE?

No, test execution passed when use command.

In that case this  is a bug in RIDE and should be reported to its issue tracker.


fixes #11: link fixed

link fixed

Merging it, but please really do - follow best practices.
Read again the guidelines. Add issue links into the description of pull requests.
Help everyone and follow -> Best Practices.

Sorry for inconvenience will do it from now onwards.


[PY] fixed feedback look dict accessed as object

Related to pull request #1892, not sure if @skoryky has seen the comment on the issue with reply_to_id. I've made similar changes.

Hi @yikwen,
since these changes are very similiar to #1892, could you suggest these fixes in that PR instead

@lilyydu ok I've suggested changes in #1829. Hope I've done it correctly.

Hi @yikwen
I received an email notif about the suggestion but don't see it on the #1892 PR for some reason- are you able to see it on your end?

Hi @yikwen
I received an email notif about the suggestion but don't see it on the #1892 PR for some reason- are you able to see it on your end?

@lilyydu yeah I can see it on #1892

Hi @yikwen
I received an email notif about the suggestion but don't see it on the #1892 PR for some reason- are you able to see it on your end?

@lilyydu yeah I can see it on #1892

I don't see it on the PR either, but acknowledging I see it here 😄 Working on it now.

Hmm, I've been seeing the keys as camel-cased, i.e. replyToId and actionName. @yikwen, have you seen them be snake-cased, i.e. reply_to_id and action_name? @lilyydu, do you know what is expected?

@yikwen I see the 'Pending' - think you need to hit "Submit review" (going to close this PR now so we can discuss in #1892)
@skoryky Keys accesses should be snake cased - where did you see the camel-cases? we might have some discrepancies when we initially porting over code to python that need to be fixed

@lilyydu, I saw that the request messages being sent from the the Bot Framework were camel-cased. Are you expecting some code in the Python library to convert that to snake case when loading into context.activity?


Add support for specifying the cli args for running a node from config file

Currently there are already dozens of FLAGS and OPTIONS shipped with the default node executable in substrate, it would be very convenient to also support reading these command line options from a config file like JSON, TOML, etc, especially helpful when we are to pass the bootnodes from the command line.
Using a config file is generally better than writting a bash script for the advantage of cross platform, even most substrate developers/users use Linux/macOS system I guess.
The proposal is to add an option --config-filename <PATH> for writting the command line arguments in a file, and the same option specified in this config file will be overrided by the one passed from the command line if it can have only one value.

I have a workaround for this feature, the idea is to mock the cli args using a faked option --config-filename.

add a fake OPTION --config-filename <PATH>. This option actually does not exist in substrate cli.
parse std::env::args_os() to extract the value of --config-filename if there is one.
read the config file specified by --config-filename, let's say it's a JSON, the key of which is the origin FLAG/OPTION, the value is same with what we pass from the command line. For this JSON file, the nested config is unsupported, i.e., only Bool, String, Number, Array are supported, the entry of this JSON can't be an Object.
build an iterator in the form of --key=value from the above object and pass it into SubstrateCli::from_iter().

Basically it's to perform a preprocessing manually on the origin cli args. This approach does work and has no need to do much changes to current code, but kind of hacky.
Then you can run the node using substrate --config-filename=config.json
config.json:
{
  "chain": "local",
  "validator": false,
  "rpc-external": true,
  "ws-external": true,
  "log": "info,runtime=debug",
  "port": 20223,
  "ws-port": 8089,
  "rpc-port": 8088,
  "other-execution": "NativeElseWasm",
  "pruning": "archive",
  "syncing-execution": "NativeElseWasm",
  "block-construction-execution": "NativeElseWasm",
  "db-cache": 1024,
  "state-cache-size":<PHONE_NUMBER>,
  "name": "Hello World",
  "base-path": "validator-db",
  "keystore-path": "keystore",
  "password": "password",
  "bootnodes": [
        "/ip4/<IP_ADDRESS>/tcp/31128/p2p/QmdqTe9ykXgxWemhLXGmiuWQe3fEYuDRiwDgTDL1Npen6s",
        "/ip4/<IP_ADDRESS>/tcp/31128/p2p/QmdqTe9ykXgxWemhLXGmiuWQe3fEYuDRiwDgTDL1Npen6s",
        "/ip4/<IP_ADDRESS>/tcp/31128/p2p/QmdqTe9ykXgxWemhLXGmiuWQe3fEYuDRiwDgTDL1Npen6s",
  ]
}

If you run with substrate --chain=staging --config-filename=config.json, the "chain": "local" will be overrided by --chain-staging. I can prepare a PR if you think this could be a short term solution.

Basically this is blocked by this: https://github.com/clap-rs/clap/issues/748
I'm not such a huge fan of introducing a another hack into the cli.

I believe this is a duplicate of #5887

Yeah, they are essentially the same thing, feel free to close this one :(.


could not validate external IP","ip":"xx.xx.xx.xx","error":"context canceled

Describe the bug
It will print the warn log could not validate external IP","ip":"47.98.xxx.xx","error":"context canceled every time i start the livekit server.
The IP read is correct.
Server

Version: [1.8.0]
Environment: [docker compose]
any other information about your deployment setup

Expected behavior
clean the warnning log
Screenshots

how do you reproduce this?

docker compose content
services:   livekit:     image: livekit/livekit-server:v1.8.0     command: --config /etc/livekit.yaml     restart: unless-stopped     network_mode: "host"     volumes:       - /etc/localtime:/etc/localtime       - ./livekit-dev.yaml:/etc/livekit.yaml
config file  content
`
port: 7880
bind_addresses:
- "<IP_ADDRESS>"
logging:
level: warn
json: true
pion_level: error
rtc:
tcp_port: 7881
udp_port: 7882
use_external_ip: true
enable_loopback_candidate: false
redis:
address: <IP_ADDRESS>:6379
db: 11
turn:
enabled: false
tls_port: 5349
udp_port: 3478
external_tls: true
keys:
xxxxxxxxx: ddddddddddddddddd
webhook:
the API key to use in order to sign the message
this must match one of the keys LiveKit is configured with
api_key: 'dddddddd'
urls:
- 'http://<IP_ADDRESS>:8880/v1/api/webhookEndpoint'
- 'http://<IP_ADDRESS>:8891/v1/api/webhookEndpoint'
room:
empty_timeout: 60
departure_timeout: 1
prometheus:
port: 6789
`
run command
docker compose up livekit -d

In China, cloud VPS can't fetch docker images ...
How to do?

In China, cloud VPS can't fetch docker images ... How to do?
vpn


parsing: option to [end] to terminate parsing even if there is further input

I use time in my rsspls project (thanks!). It's a tool that uses CSS selectors to extract parts of web pages and build an RSS feed from them. time is used for parsing dates that will become the published date of the RSS item. In https://github.com/wezm/rsspls/issues/46 the element in the HTML that contains the date actually has two dates in it like this:
31/05/2024
  15/06/2024

Which is "31/05/2024  15/06/2024" when extracted. We'd like to be able to parse the first date. This is similar in nature to https://github.com/time-rs/time/issues/471 but my idea is to add a modifier to the end component that allows it to be used even when all the input has not been consumed. This would allow using a format description like [day padding:zero]/[month padding:zero]/[year][end eof:false]
I'd be open to implementing this if it seems reasonable.

So…I definitely get where you're coming from. Any implementation of this would necessarily be a new method rather than a modifier on [end]. The reason for this is a tad involved, but I'll try to simplify as much as possible. After some layers of indirection for ergonomics, calls to parse end up calling Sealed::parse (in parsable.rs). This is ultimately where your desire lies — the value is parsed successfully, but fails because there is remaining input. Any [end] modifier is long gone by the time this situation is encountered.
Right now, the only way to approach this is to go through the Parsed struct directly. For example,
let mut parsed = Parsed::new();
let remaining = parsed.parse_items(format_item!("[day]/[month]/[year]"))?;
let value = parsed.into();

This is typed off hand, and naturally relies on some assumptions. You're experienced with Rust, so I trust you're able to figure that much out. Even within time, this is the approach that would need to be taken. I'm not necessarily opposed to having something more ergonomic, but I don't think it's trivial either (a new method isn't ideal).


Mentioning an alternative

This PR adds shoutout to AWS Toolkit for Visual Studio Code in the readme.
It would be helpful to let people know about other features available when building AWS state machines on vscode.

That's great, thanks!

That's great, thanks!


Make libparodus functions thread safe

Add multi-threading support to libparodus, so that multiple threads could do libparodus_receive and libparodus_send on the same libpd_instance_t

Fixed as part of #37


unable to build  : Error The non-abstract class 'RTCVideoRenderer' is missing implementations for these members:

we are getting this error during build for ios and android.
mediasoup_client_flutter: ^0.8.1.  this is the latest pub dart verions
: Error: The non-abstract class 'RTCVideoRenderer' is missing implementations for these members:
../…/native/rtc_video_renderer_impl.dart:11
 - VideoRenderer.onFirstFrameRendered
Try to either
 - provide an implementation,
 - inherit an implementation from a superclass or mixin,
 - mark the class as abstract, or
 - provide a 'noSuchMethod' implementation.

class RTCVideoRenderer extends ValueNotifier<RTCVideoValue>
      ^^^^^^^^^^^^^^^^
: Context: 'VideoRenderer.onFirstFrameRendered' is defined here.
../…/src/rtc_video_renderer.dart:51

  Function? onFirstFrameRendered;
            ^^^^^^^^^^^^^^^^^^^^

FAILURE: Build failed with an exception.

check this one
https://github.com/flutter-webrtc/flutter-webrtc/issues/1079


Remove LDCV from Huang NPOKB:40- it is not an expression phenotype

It stands for large dense-core vesicles and you can see in Table S7 that it is LDCV release

LDCV has been removed from the current version since it falls under synaptic properties. When we implement a more granular model for Huang we can probably model these kinds of assertions as entailments on neurons bearing the particular molecular phenotypes that are associated with them in the table.


Upgrade to react 0.14.0-rc1 and react-router 1.0.0-rc1

An attempt at https://github.com/erikras/react-redux-universal-hot-example/issues/195 and https://github.com/erikras/react-redux-universal-hot-example/issues/182
It's a total hack really, based on using react-router's RoutingContext and match functions on the client where, apparently, they're not intended to be used. This is the only way to implement the required transition hooks with the new react-router API. Personally I think it would be good to look at using something like https://github.com/ericclemmons/react-resolver. This would mean we wouldn't have to pause the render until the data has loaded so could use the proper react-router API.
There's bound to be some edge cases I'm not aware of. I also get a weird flicker sometimes when transitioning between routes in dev mode. Anyways, it's a start.
Thanks to @halt-hammerzeit, @quicksnap and @geekyme - I copied their work, basically.

Hey, great work! This is very similar to my fork where I was attempting this as well.
Interesting approach re-rendering the component tree in tandem with the preload option to universalRouter.
In my attempt, I was also using RoutingContext, but was attempting to avoid match on client side.

Also, odd bug: I can no longer hide the redux dev tools with Ctrl+H..

Hmm, no idea about devtools. Ctrl+H doesn't work for me on master

@stevoland hmmm, I see, so you chose to render <RoutingContext {...renderProps}/> both on server and client (as opposed to <Router> on client).
That makes history transition hooks work.
Interesting idea.

@halt-hammerzeit I can't really see how else to get a history transition hook and the new component tree before the render for the new location?

@stevoland yeah, me neither

redux-router uses RoutingContext https://github.com/rackt/redux-router/blob/master/src/ReduxRouter.js#L87 and that's an 'approved' Rackt lib now so maybe there's hope that this technique isn't totally crazy.
I see this PR as a temporary measure though. I don't think the UI should be blocked until data is loaded. I think the transition should happen and the new containers should be able to display spinners or whatever. I suppose ultimately Relay will be brought in to take care of all this.

@stevoland yeah, i'm thinking more about Relay too, and that's the reason i'm not working that much on this issue: when i'm done studying relay i'll swap API with it, and that can potentially change a lot of things. I currently haven't yet researched things like "Relay isomorphic rendering" and "Relay + React-Router boiler plate" stuff.

Relay doesn't feel too compatible with Redux...or Flux at all, really.

No, but I think it's on the roadmap to incorporate managing local state into Relay so it will replace Flux in complex apps I think. It's server rendering story is excellent, once it's released: https://github.com/facebook/relay/issues/36. Anyway we're a bit off topic I think!

I personally don't think the UI should block, but one should be able to block a route transition if their app calls for it.
For instance:

Click on a link, see a "Loading" spinner.
Get data back from server
Then, transition to /widgets route

Seems like a totally reasonable UX

To that end, we would still need the same transition hook mechanisms.

@quicksnap devtool stopped working with chrome 47, there is a bug in the way keys combo are detected

@stevoland nice work! quick note.. arguments passed to onEnter transition hook were updated. new shape is onEnter(nextState, replaceState, callback), i think this only affects the one static method on containers/RequireLogin component, ie...
  static onEnter(store) {
    return (nextState, replaceState) => {

      const { auth: { user }} = store.getState();
      if (!user) {
        // oops, not logged in, so can't be here!
        replaceState(null, '/');
      }
    };
  }

@stevoland Thanks so much for this! I'm taking a look now at this branch against my work and it seems to be working fine.
Like @justingreenberg mentioned, the current branch will give a warning:
Warning: registerTransitionHook is deprecated; use listenBefore instead
I replaced the line in client.js from:
history.registerTransitionHook((loc, callback) => {
    render(loc, history, store, true)
        .then((callback));
});

to:
history.listenBefore((loc, callback) => {
    render(loc, history, store, true).then(callback);
});

and the warning disappeared :)

@justingreenberg @bertramtruong Thanks, I've updated the branch.
Fixed another couple of warnings and rebased with latest master.
@erikras What do you think?

Excellent work, you guys. @stevoland is the man!
Looks good enough to merge to me.

:confetti_ball: :tada: :balloon: :dancers: :dancer:
I'm going to be using this as my base today; excited to see how it pans out!
Great work everyone! Thanks @stevoland!

Seriously. @stevoland deserves a :beer: or two.

Hey I think this part https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/client.js#L56 doesn't seem to be be right. How come the entire tree is rerendered on route transition. Also, createRoutes will be called every single time someone navigates. Seems expensive.

There's some room for improvement for sure, maybe a wrapper component that
listens to history. I might do this if I look into integrating redux-router.
Performance wise I wouldn't worry.
On 26 Sep 2015 03:59, "Shawn Lim"<EMAIL_ADDRESS>wrote:

Hey I think this part
https://github.com/erikras/react-redux-universal-hot-example/blob/master/src/client.js#L56
doesn't seem to be be right. How come the entire tree is rerendered on
route transition. Also, createRoutes will be called every single time
someone navigates. Seems expensive.
—
Reply to this email directly or view it on GitHub
https://github.com/erikras/react-redux-universal-hot-example/pull/214#issuecomment-143393447
.

FWIW, I've got a version that runs as a middleware component between the router and the App itself. You can check it out at https://github.com/rackt/react-router/issues/2101
It would need to be updated if you're not doing server-side rendering because it completely bypasses the initial mounting on client-side but it has worked quite well for me.

@apapirovski Very nice!


Compatibility with IE <= 10

Hey guys. It looks like the ways you guys are sending Ajax requests through logEvent and others isn't compatible with all versions of Internet Explorer. Seems like a pretty simple fix, you just have to add some non-blank return handlers. You can see the issue discussed at length here:
http://stackoverflow.com/questions/15786966/xdomainrequest-aborts-post-on-ie-9

Thanks for the info, we'll be sure to fix it!

Glad I could be of a little help, thanks and keep up the good work!

This is fixed with v2.6.2


Implement plugin manager

This PR implements the common code of the plugin-extensibility spec so it will be used by notary and others.
The Manager implementation will probably change once https://github.com/notaryproject/notation/issues/167 is discussed.
It also contains unit test and integration tests with ad-hoc plugins. Coverage is around 95%.
@SteveLasker
Signed-off-by: qmuntal<EMAIL_ADDRESS>

cc: @rgnote @shizhMSFT for review.

@jaredpar @SteveLasker as the review process is going slower than expected, I've pushed a new batch of commits since. They don't add new functionality but refine the API after the learnings I got using it in https://github.com/notaryproject/notation/pull/168.

@qmuntal, question for how we can test a set of these changes.
Just an idea (might be a bad one), should we create a branch in notation, notation-go and azure/notation-azure-kv to test these changes?

@qmuntal, question for how we can test a set of these changes. Just an idea (might be a bad one), should we create a branch in notation, notation-go and azure/notation-azure-kv to test these changes?

I like the idea! I'll come with something and share it with you all.

Overall structure and organization looks great, added some comments. Will make another pass tomorrow for some areas I skipped. I'm new to Go, some high level questions.

Some of these error messages will be presented to users through the CLI, how do we differentiate them, and case and format them correctly with more context.
We need to support verbose logging through out the library and CLI, is there a standard way to do that in Go? With verbose logging, we can return concise error messages to the user, and they can enable verbose logging for more details/troubleshooting.

Thanks for the review @gokarnm. My take is that notation-go should provide fine-grained error messaged which are good for displaying but also can be captured programmatically. If an error is missing some context, then we should add it.
What I wouldn't support is verbose levels in the returned errors. It either returns an error or not, leaving to the caller to decide if it should be logged as a debug, info, warning or whatever other level.
The build-in log package does not have support for using log levels, but there are multiple well-known packages with does support it, e.g. github.com/sirupsen/logrus.

Thanks for the review @gokarnm. My take is that notation-go should provide fine-grained error messaged which are good for displaying but also can be captured programmatically. If an error is missing some context, then we should add it.

What about the error message casing, error messages which are returned to CLI users should be correctly cased. It seems to be a convention to use small case error messages in Go?

What I wouldn't support is verbose levels in the returned errors. It either returns an error or not, leaving to the caller to decide if it should be logged as a debug, info, warning or whatever other level.

Agreed, I wasn't clear enough. I meant verbose level should log to stdout so that it's visible to in CLI or an upstream caller if they enable verbose logging. The verbose logging will need to be supported in notation-go and notation-core-go, as that's where bulk of the decision paths and validations will be. This need not be implemented right away.

What about the error message casing, error messages which are returned to CLI users should be correctly cased. It seems to be a convention to use small case error messages in Go?

There are multiple options to transform and localize text, being https://pkg.go.dev/golang.org/x/text the most common.

Agreed, I wasn't clear enough. I meant verbose level should log to stdout so that it's visible to in CLI or an upstream caller if they enable verbose logging. The verbose logging will need to be supported in notation-go and notation-core-go, as that's where bulk of the decision paths and validations will be. This need not be implemented right away.

If we need to log something from those libraries, which is still not clear to me if we should, we will find the way. For example, http.Server logs error into the optional http.Server.ErrorLog property.

If we need to log something from those libraries, which is still not clear to me if we should, we will find the way. For example, http.Server logs error into the optional http.Server.ErrorLog property.

Yes, that's what I'm looking for, similar to libraries that support emitting verbose logs to aid debugging issues. It would be useful for us to debug user reported errors as the logic in many of these areas, plugin and signature verification logic, is quite complex.


Merge pull request #3199 from cloudfoundry-incubator/split-travis-e2e

Split travis e2e tests into two

Codecov Report

Merging #98 into v2-master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           v2-master     #98      +/-   ##
============================================
- Coverage      71.92%   71.9%   -0.02%
============================================
  Files            685     685
  Lines          29583   29583
  Branches        6787    6787
============================================
- Hits           21277   21273       -4
- Misses          8306    8310       +4


AzureGalleryPackager fails with "Invalid URI: The format of the URI could not be determined."

Followed this doc but the packager always fails with the aforementioned error. Below my manifest.json
{ "$schema": "https://gallery.azure.com/schemas/2014-09-01/manifest.json#",
"name": "RHEL75",
"publisher": "RedHat",
"version": "1.0.0",
"displayName": "ms-resource:displayName",
"publisherDisplayName": "ms-resource:publisherDisplayName",
"publisherLegalName": "ms-resource:publisherDisplayName",
"summary": "ms-resource:summary",
"longSummary": "ms-resource:longSummary",
"description": "ms-resource:description",
"longDescription": "ms-resource:description",
"links": [
{ "displayName": "ms-resource:documentationLink", "uri": "https://docs.microsoft.com/en-us/azure/azure-stack/azure-stack-redhat-create-upload-vhd" }
],
"artifacts": [
{
"name": "simple-vm",
"type": "Template",
"path": "DeploymentTemplates\simple-vm.json",
"isDefault": true
}
],
"icons": {
"Small": "Icons\Small.png",
"Medium": "Icons\Medium.png",
"Large": "Icons\Large.png",
"Wide": "Icons\Wide.png"
},
"categories":[
"virtualMachine",
"microsoftServer",
"azure",
"linux",
"appInfra",
"azureCertified",
"virtualMachineRecommended",
"virtualMachine-Arm",
"virtualMachine-csp"
],
"uiDefinition": {
"path": "UIDefinition.json"
}
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83d0ba3d-9766-30da-70f0-5f4c3ec9a47e
Version Independent ID: 446b6ecc-7b39-df7f-69f5-f3f0ea9b0a94
Content: Create and publish a Marketplace item in Azure Stack
Content Source: articles/azure-stack/azure-stack-create-and-publish-marketplace-item.md
Service: azure-stack
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@hensilva have you been able to try this with version 1901

@hensilva Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

I am seeing the same issue. This is my first time using AzureGalleryPackager.exe, so I am not sure if the issue is related to my ignorance. I have tried packaging different examples and removing sections from the manifest and other json files. I am still seeing 'Invalid URI: The format of the URI could not be determined.'
Is there a place to download different precompiled versions of the tool to test?


Add tag view and view models

I would like to say that I am very amazed by your implementation of the UI.
Not only was it beautiful it was easy to extend to tags.
I felt that I will not fully understand what is done if I just read your code. So I decided to try extend it to tags to understand it better. I am not sure if I did it right so I am making a PR to your branch. I did not change the test cases yet.
Note that the String model I changed it to a Label to maintain consistency.
I abstracted out the creation of a list of tags as I felt that it was to be used in other areas as well.
I think that to improve this we can make this better by splitting up the UI into header, body, footer. Then we decide what to place in the header, footer and body. This is just a random suggestion.
Generally I think your PR is good to merge!
Do let me know if you would like me to change the test and add it to this PR

Reason for force push
https://stackoverflow.com/questions/39399804/updates-were-rejected-because-the-tip-of-your-current-branch-is-behind-its-remot

Will close as I should have used a different branch to merge this in


Repo-Based Media:  Rename syncFolder to mediaRoot

As part of our planning discussion, we landed on mediaRoot making more sense than syncFolder if it is clearly documented that mediaRoot is synced on tina-cloud when it is provided.
mediaRoot defines the location that the MediaManager starts at (which feels better) than syncFolder.
mediaRoot is functionally exactly the same as syncFolder.

PR for tinacms, @tinacms/cli and @tinacms/graphql found here: https://github.com/tinacms/tinacms/pull/3009/

PR for tina-cloud found here: https://github.com/tinacms/tina-cloud/pull/1576


ra1nstorm failed to download macOS installer

Title says it all.

Same problem

Same! FYI I already has my PC set up to dual boot between Win 10 and Unbuntu 19.10 so I started at step 2 (ra1nstorm.run). The terminal message says "sh: 1: ./fetch-macOS.py: not found".

Failed to install macOS installation img here also unfortunately.

The fetch-macOS file is written in python and it's possible that it isn't installed. Simply run sudo apt-get install python and you should be set. If not, I'm not sure how to fix it.
Hopefully this helps!

Thank you. It was python that was missing


Update isa for privilege tests.

The latest version of the toolchain expects _Zicsr to be present in the march argument for tests which execute csr* instructions. The current tests do not include this extension in the argument to the RVTEST_ISA macro. Any test which needs to include the trap handler (via the rvtest_mtrap_routine) conditionally or unconditionally will have to be updated according to the definition here.

I'm not sure which definition you're pointing to in the testformatspec doc.
I think I need to modify my trap handler to make sure that works correctly.
On Wed, Feb 23, 2022 at 8:12 AM S Pawan Kumar @.***>
wrote:

The latest version of the toolchain expects _Zicsr to be present in the
march argument for tests which execute csr* instructions. The current
tests do not include this extension in the argument to the RVTEST_ISA
macro. Any test which needs to include the trap handler (via the
rvtest_mtrap_routine) conditionally or unconditionally will have to be
updated according to the definition here
https://github.com/riscv-non-isa/riscv-arch-test/blob/riscof-dev/spec/TestFormatSpec.adoc#431-required-pre-defined-macros
.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/233, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJXVWWXK6FCSEEAKCXDU4UBNHANCNFSM5PE2BMFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Is this related to https://github.com/riscv-software-src/riscof/issues/35?

I misstated; it's actually the RVTEST_CODE_END that supports the (new) trap
handler that needs to change. It should be a simple fix.
On Wed, Feb 23, 2022 at 8:38 AM S Pawan Kumar @.***>
wrote:

I was pointing to the RVTEST_ISA macro. I don't think the trap handler
needs to be updated. Only the isa strings need to be updated.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/233#issuecomment-1048977090,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJUPZDYN3F5LDYCIQE3U4UEPBANCNFSM5PE2BMFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

@pdonahue-ventana Yes.

Could this be fixed by defining changing
#define  RVTEST_ISA(_STR)    to
#ifdef rvtest_mtrap_routine
#define  RVTEST_ISA(_STR##_Zicsr)
#else
#define  RVTEST_ISA(_STR)
#endif
so we only change it in one place rather than many? (assuming I have my syntax correct)

Could this be fixed by defining changing #define RVTEST_ISA(_STR) to #ifdef rvtest_mtrap_routine #define RVTEST_ISA(_STR##_Zicsr) #else #define RVTEST_ISA(_STR) #endif
so we only change it in one place rather than many? (assuming I have my syntax correct)

That would not work because riscof parses the files to get the ISA and the macro does not really mean anything in the code. The macro is an empty macro.

Another solution would be to have a policy to include zicsr in the march string always(if it is present in the isa of input yaml). This would also allow the boot code to contain csr instructions. That way the tests may or may not have the Zicsr explicitly set in the RVTEST_ISA string.

That's too simple; there must be a downside, e.g. it would cause some CSR
tests on machines that don't implement it?
On Tue, Mar 29, 2022 at 10:16 PM S Pawan Kumar @.***>
wrote:

Another solution would be to have a policy to include zicsr in the march
string always(if it is present in the isa of input yaml). This would also
allow the boot code to contain csr instructions. That way the tests may or
may not have the Zicsr explicitly set in the RVTEST_ISA string.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/233#issuecomment-1082630345,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJQ27KORR2HKYXUDMY3VCPPRXANCNFSM5PE2BMFA
.
You are receiving this because you commented.Message ID:
@.***>

That's too simple; there must be a downside, e.g. it would cause some CSR tests on machines that don't implement it?
…
On Tue, Mar 29, 2022 at 10:16 PM S Pawan Kumar @.> wrote: Another solution would be to have a policy to include zicsr in the march string always(if it is present in the isa of input yaml). This would also allow the boot code to contain csr instructions. That way the tests may or may not have the Zicsr explicitly set in the RVTEST_ISA string. — Reply to this email directly, view it on GitHub <#233 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPXVJQ27KORR2HKYXUDMY3VCPPRXANCNFSM5PE2BMFA . You are receiving this because you commented.Message ID: @.>

Not really. The check statements in the RVTEST_CASE macro drive the conditions for choosing a test. The RVTEST_ISA macro is just a indication of the string which should be passed to the march argument of gcc while compiling. Adding Zicsr will not affect the test filtering in any way.

As long as it only affects tools, then sure. Which file needs to change for
this to happen?
On Wed, Mar 30, 2022 at 1:53 PM S Pawan Kumar @.***>
wrote:

That's too simple; there must be a downside, e.g. it would cause some CSR
tests on machines that don't implement it?
… <#m_5146802007208790925_>
On Tue, Mar 29, 2022 at 10:16 PM S Pawan Kumar @.> wrote: Another
solution would be to have a policy to include zicsr in the march string
always(if it is present in the isa of input yaml). This would also allow
the boot code to contain csr instructions. That way the tests may or may
not have the Zicsr explicitly set in the RVTEST_ISA string. — Reply to this
email directly, view it on GitHub <#233 (comment)
https://github.com/riscv-non-isa/riscv-arch-test/issues/233#issuecomment-1082630345>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJQ27KORR2HKYXUDMY3VCPPRXANCNFSM5PE2BMFA
https://github.com/notifications/unsubscribe-auth/AHPXVJQ27KORR2HKYXUDMY3VCPPRXANCNFSM5PE2BMFA
. You are receiving this because you commented.Message ID: @.>
Not really. The check statements in the RVTEST_CASE macro drive the
conditions for choosing a test. The RVTEST_ISA macro is just a indication
of the string which should be passed to the march argument of gcc while
compiling. Adding Zicsr will not affect the test filtering in any way.
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-non-isa/riscv-arch-test/issues/233#issuecomment-1083615161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJWKVHXISQ2J2JJ7GZDVCS5MBANCNFSM5PE2BMFA
.
You are receiving this because you commented.Message ID:
@.***>

Close after documenting that plugin should add or omit  -Zicsr depending on toolchain.
Close after updating all priv tests to include Zicsr.

Closed with #286


DevOps Task, Story and Epic creation closes #6

The changes were done in #9 but I forgot to create a new branch so the changes are under request #9

This pull request have superseded by latter merges. Sorry for my error. Please create a new branch to make this change and then make another pull request